{"action":"created","comment":{"url":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/comments/93635449","pull_request_review_id":14167092,"id":93635449,"diff_hunk":"@@ -36,7 +36,7 @@\n # CHANGE THIS LIST OF FLAGS. YES, THIS IS THE DROID YOU HAVE BEEN LOOKING FOR.\n flags = [\n     '-DNDEBUG',\n-    '-DWITH_TBB',\n+    '-DNMC_HAVE_TBB',","path":".ycm_extra_conf.py","position":5,"original_position":5,"commit_id":"0cf18e2d01e1db4d276a10dd29eb2d7e7308225b","original_commit_id":"0cf18e2d01e1db4d276a10dd29eb2d7e7308225b","user":{"login":"biddisco","id":941548,"avatar_url":"https://avatars.githubusercontent.com/u/941548?v=3","gravatar_id":"","url":"https://api.github.com/users/biddisco","html_url":"https://github.com/biddisco","followers_url":"https://api.github.com/users/biddisco/followers","following_url":"https://api.github.com/users/biddisco/following{/other_user}","gists_url":"https://api.github.com/users/biddisco/gists{/gist_id}","starred_url":"https://api.github.com/users/biddisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biddisco/subscriptions","organizations_url":"https://api.github.com/users/biddisco/orgs","repos_url":"https://api.github.com/users/biddisco/repos","events_url":"https://api.github.com/users/biddisco/events{/privacy}","received_events_url":"https://api.github.com/users/biddisco/received_events","type":"User","site_admin":false},"body":"The explanation goes like this:\r\nA user says I want Option X (say cuda or openMP) so in CMake they say NMC_WITH_CUDA or NMC_WITH_OPENMP or something of that kind. (ignoring the fact that you have a threading model var for that). It might be that OpenMP is not found (OSX) but it isn't fatal, so you don't mind. Elsewhere in the code there will be checks for if(openmp) etc, which should of course test negative, so a common pattern is to have user facing options WITH_XXX and the actual vars that code checks to be HAVE_XXX so that if(WITH_openmp) passes add_definition(HAVE_openmp) is added. \r\nUser facing options use WITH, actual ifdefs in the code use HAVE to perform the checks (and if cmake needs it, it can also have HAVE_option vars set for various checks).\r\nThe commits themselves have quite long log messages with some explanations too.\r\n\r\nIf you don't like using WITH and HAVE, then a search/replace can change all the _HAVE_back to _WITH_ in a jiffy - (but I'd like to convince you to keep it)","created_at":"2016-12-22T14:49:18Z","updated_at":"2016-12-22T14:49:18Z","html_url":"https://github.com/eth-cscs/nestmc-proto/pull/137#discussion_r93635449","pull_request_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/137","_links":{"self":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/comments/93635449"},"html":{"href":"https://github.com/eth-cscs/nestmc-proto/pull/137#discussion_r93635449"},"pull_request":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/137","id":99108546,"html_url":"https://github.com/eth-cscs/nestmc-proto/pull/137","diff_url":"https://github.com/eth-cscs/nestmc-proto/pull/137.diff","patch_url":"https://github.com/eth-cscs/nestmc-proto/pull/137.patch","issue_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/issues/137","number":137,"state":"open","locked":false,"title":"CMake fixes","user":{"login":"biddisco","id":941548,"avatar_url":"https://avatars.githubusercontent.com/u/941548?v=3","gravatar_id":"","url":"https://api.github.com/users/biddisco","html_url":"https://github.com/biddisco","followers_url":"https://api.github.com/users/biddisco/followers","following_url":"https://api.github.com/users/biddisco/following{/other_user}","gists_url":"https://api.github.com/users/biddisco/gists{/gist_id}","starred_url":"https://api.github.com/users/biddisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biddisco/subscriptions","organizations_url":"https://api.github.com/users/biddisco/orgs","repos_url":"https://api.github.com/users/biddisco/repos","events_url":"https://api.github.com/users/biddisco/events{/privacy}","received_events_url":"https://api.github.com/users/biddisco/received_events","type":"User","site_admin":false},"body":"Here are some cmake related fixes that address #130 (rerunning modcc) and #134 (improving cmake names) as well as a few other cleanups and tweaks. \r\n\r\nI expect some pushback on the changing of #ifdef var names!","created_at":"2016-12-22T13:59:31Z","updated_at":"2016-12-22T14:49:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4452df61532bda5134bd22110b16eb82186a0641","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/137/commits","review_comments_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/137/comments","review_comment_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/issues/137/comments","statuses_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/statuses/0cf18e2d01e1db4d276a10dd29eb2d7e7308225b","head":{"label":"biddisco:cmake_fixes","ref":"cmake_fixes","sha":"0cf18e2d01e1db4d276a10dd29eb2d7e7308225b","user":{"login":"biddisco","id":941548,"avatar_url":"https://avatars.githubusercontent.com/u/941548?v=3","gravatar_id":"","url":"https://api.github.com/users/biddisco","html_url":"https://github.com/biddisco","followers_url":"https://api.github.com/users/biddisco/followers","following_url":"https://api.github.com/users/biddisco/following{/other_user}","gists_url":"https://api.github.com/users/biddisco/gists{/gist_id}","starred_url":"https://api.github.com/users/biddisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biddisco/subscriptions","organizations_url":"https://api.github.com/users/biddisco/orgs","repos_url":"https://api.github.com/users/biddisco/repos","events_url":"https://api.github.com/users/biddisco/events{/privacy}","received_events_url":"https://api.github.com/users/biddisco/received_events","type":"User","site_admin":false},"repo":{"id":77066335,"name":"nestmc-proto","full_name":"biddisco/nestmc-proto","owner":{"login":"biddisco","id":941548,"avatar_url":"https://avatars.githubusercontent.com/u/941548?v=3","gravatar_id":"","url":"https://api.github.com/users/biddisco","html_url":"https://github.com/biddisco","followers_url":"https://api.github.com/users/biddisco/followers","following_url":"https://api.github.com/users/biddisco/following{/other_user}","gists_url":"https://api.github.com/users/biddisco/gists{/gist_id}","starred_url":"https://api.github.com/users/biddisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biddisco/subscriptions","organizations_url":"https://api.github.com/users/biddisco/orgs","repos_url":"https://api.github.com/users/biddisco/repos","events_url":"https://api.github.com/users/biddisco/events{/privacy}","received_events_url":"https://api.github.com/users/biddisco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/biddisco/nestmc-proto","description":"Prototype for the NestMC multi-compartment neural network simulator","fork":true,"url":"https://api.github.com/repos/biddisco/nestmc-proto","forks_url":"https://api.github.com/repos/biddisco/nestmc-proto/forks","keys_url":"https://api.github.com/repos/biddisco/nestmc-proto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biddisco/nestmc-proto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biddisco/nestmc-proto/teams","hooks_url":"https://api.github.com/repos/biddisco/nestmc-proto/hooks","issue_events_url":"https://api.github.com/repos/biddisco/nestmc-proto/issues/events{/number}","events_url":"https://api.github.com/repos/biddisco/nestmc-proto/events","assignees_url":"https://api.github.com/repos/biddisco/nestmc-proto/assignees{/user}","branches_url":"https://api.github.com/repos/biddisco/nestmc-proto/branches{/branch}","tags_url":"https://api.github.com/repos/biddisco/nestmc-proto/tags","blobs_url":"https://api.github.com/repos/biddisco/nestmc-proto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biddisco/nestmc-proto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biddisco/nestmc-proto/git/refs{/sha}","trees_url":"https://api.github.com/repos/biddisco/nestmc-proto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biddisco/nestmc-proto/statuses/{sha}","languages_url":"https://api.github.com/repos/biddisco/nestmc-proto/languages","stargazers_url":"https://api.github.com/repos/biddisco/nestmc-proto/stargazers","contributors_url":"https://api.github.com/repos/biddisco/nestmc-proto/contributors","subscribers_url":"https://api.github.com/repos/biddisco/nestmc-proto/subscribers","subscription_url":"https://api.github.com/repos/biddisco/nestmc-proto/subscription","commits_url":"https://api.github.com/repos/biddisco/nestmc-proto/commits{/sha}","git_commits_url":"https://api.github.com/repos/biddisco/nestmc-proto/git/commits{/sha}","comments_url":"https://api.github.com/repos/biddisco/nestmc-proto/comments{/number}","issue_comment_url":"https://api.github.com/repos/biddisco/nestmc-proto/issues/comments{/number}","contents_url":"https://api.github.com/repos/biddisco/nestmc-proto/contents/{+path}","compare_url":"https://api.github.com/repos/biddisco/nestmc-proto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biddisco/nestmc-proto/merges","archive_url":"https://api.github.com/repos/biddisco/nestmc-proto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biddisco/nestmc-proto/downloads","issues_url":"https://api.github.com/repos/biddisco/nestmc-proto/issues{/number}","pulls_url":"https://api.github.com/repos/biddisco/nestmc-proto/pulls{/number}","milestones_url":"https://api.github.com/repos/biddisco/nestmc-proto/milestones{/number}","notifications_url":"https://api.github.com/repos/biddisco/nestmc-proto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biddisco/nestmc-proto/labels{/name}","releases_url":"https://api.github.com/repos/biddisco/nestmc-proto/releases{/id}","deployments_url":"https://api.github.com/repos/biddisco/nestmc-proto/deployments","created_at":"2016-12-21T16:07:47Z","updated_at":"2016-12-21T16:07:50Z","pushed_at":"2016-12-22T13:57:09Z","git_url":"git://github.com/biddisco/nestmc-proto.git","ssh_url":"git@github.com:biddisco/nestmc-proto.git","clone_url":"https://github.com/biddisco/nestmc-proto.git","svn_url":"https://github.com/biddisco/nestmc-proto","homepage":"https://eth-cscs.github.io/nestmc/","size":1891,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eth-cscs:master","ref":"master","sha":"0f00ede6025129ec8119da89544a46140813ce20","user":{"login":"eth-cscs","id":5744410,"avatar_url":"https://avatars.githubusercontent.com/u/5744410?v=3","gravatar_id":"","url":"https://api.github.com/users/eth-cscs","html_url":"https://github.com/eth-cscs","followers_url":"https://api.github.com/users/eth-cscs/followers","following_url":"https://api.github.com/users/eth-cscs/following{/other_user}","gists_url":"https://api.github.com/users/eth-cscs/gists{/gist_id}","starred_url":"https://api.github.com/users/eth-cscs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eth-cscs/subscriptions","organizations_url":"https://api.github.com/users/eth-cscs/orgs","repos_url":"https://api.github.com/users/eth-cscs/repos","events_url":"https://api.github.com/users/eth-cscs/events{/privacy}","received_events_url":"https://api.github.com/users/eth-cscs/received_events","type":"Organization","site_admin":false},"repo":{"id":69863074,"name":"nestmc-proto","full_name":"eth-cscs/nestmc-proto","owner":{"login":"eth-cscs","id":5744410,"avatar_url":"https://avatars.githubusercontent.com/u/5744410?v=3","gravatar_id":"","url":"https://api.github.com/users/eth-cscs","html_url":"https://github.com/eth-cscs","followers_url":"https://api.github.com/users/eth-cscs/followers","following_url":"https://api.github.com/users/eth-cscs/following{/other_user}","gists_url":"https://api.github.com/users/eth-cscs/gists{/gist_id}","starred_url":"https://api.github.com/users/eth-cscs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eth-cscs/subscriptions","organizations_url":"https://api.github.com/users/eth-cscs/orgs","repos_url":"https://api.github.com/users/eth-cscs/repos","events_url":"https://api.github.com/users/eth-cscs/events{/privacy}","received_events_url":"https://api.github.com/users/eth-cscs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eth-cscs/nestmc-proto","description":"Prototype for the NestMC multi-compartment neural network simulator","fork":false,"url":"https://api.github.com/repos/eth-cscs/nestmc-proto","forks_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/forks","keys_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/teams","hooks_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/hooks","issue_events_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/issues/events{/number}","events_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/events","assignees_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/assignees{/user}","branches_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/branches{/branch}","tags_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/tags","blobs_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/git/refs{/sha}","trees_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/statuses/{sha}","languages_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/languages","stargazers_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/stargazers","contributors_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/contributors","subscribers_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/subscribers","subscription_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/subscription","commits_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/commits{/sha}","git_commits_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/git/commits{/sha}","comments_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/comments{/number}","issue_comment_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/issues/comments{/number}","contents_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/contents/{+path}","compare_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/merges","archive_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/downloads","issues_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/issues{/number}","pulls_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls{/number}","milestones_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/milestones{/number}","notifications_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/labels{/name}","releases_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/releases{/id}","deployments_url":"https://api.github.com/repos/eth-cscs/nestmc-proto/deployments","created_at":"2016-10-03T11:03:22Z","updated_at":"2016-12-13T10:22:41Z","pushed_at":"2016-12-22T13:59:32Z","git_url":"git://github.com/eth-cscs/nestmc-proto.git","ssh_url":"git@github.com:eth-cscs/nestmc-proto.git","clone_url":"https://github.com/eth-cscs/nestmc-proto.git","svn_url":"https://github.com/eth-cscs/nestmc-proto","homepage":"https://eth-cscs.github.io/nestmc/","size":1874,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":49,"forks":8,"open_issues":49,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/137"},"html":{"href":"https://github.com/eth-cscs/nestmc-proto/pull/137"},"issue":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/issues/137"},"comments":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/eth-cscs/nestmc-proto/statuses/0cf18e2d01e1db4d276a10dd29eb2d7e7308225b"}}}}
{"actor":{"display_login":"biddisco"}}