{"action":"created","issue":{"url":"https://api.github.com/repos/samuelsimoes/rails-paypal-subscriptions-sample/issues/1","repository_url":"https://api.github.com/repos/samuelsimoes/rails-paypal-subscriptions-sample","labels_url":"https://api.github.com/repos/samuelsimoes/rails-paypal-subscriptions-sample/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/samuelsimoes/rails-paypal-subscriptions-sample/issues/1/comments","events_url":"https://api.github.com/repos/samuelsimoes/rails-paypal-subscriptions-sample/issues/1/events","html_url":"https://github.com/samuelsimoes/rails-paypal-subscriptions-sample/pull/1","id":187498373,"number":1,"title":"Some improvements","user":{"login":"coorasse","id":1319150,"avatar_url":"https://avatars.githubusercontent.com/u/1319150?v=3","gravatar_id":"","url":"https://api.github.com/users/coorasse","html_url":"https://github.com/coorasse","followers_url":"https://api.github.com/users/coorasse/followers","following_url":"https://api.github.com/users/coorasse/following{/other_user}","gists_url":"https://api.github.com/users/coorasse/gists{/gist_id}","starred_url":"https://api.github.com/users/coorasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coorasse/subscriptions","organizations_url":"https://api.github.com/users/coorasse/orgs","repos_url":"https://api.github.com/users/coorasse/repos","events_url":"https://api.github.com/users/coorasse/events{/privacy}","received_events_url":"https://api.github.com/users/coorasse/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-05T13:55:40Z","updated_at":"2016-11-05T22:57:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/samuelsimoes/rails-paypal-subscriptions-sample/pulls/1","html_url":"https://github.com/samuelsimoes/rails-paypal-subscriptions-sample/pull/1","diff_url":"https://github.com/samuelsimoes/rails-paypal-subscriptions-sample/pull/1.diff","patch_url":"https://github.com/samuelsimoes/rails-paypal-subscriptions-sample/pull/1.patch"},"body":"* Update README\r\n* use ruby-version\r\n* remove empty files\r\n* introduce bootstrap for a nicer layout\r\n* change to English and EUR\r\n* fix cancel subscription\r\n* Add Deploy button to Heroku\r\n* migrate to Rails 5"},"comment":{"url":"https://api.github.com/repos/samuelsimoes/rails-paypal-subscriptions-sample/issues/comments/258647884","html_url":"https://github.com/samuelsimoes/rails-paypal-subscriptions-sample/pull/1#issuecomment-258647884","issue_url":"https://api.github.com/repos/samuelsimoes/rails-paypal-subscriptions-sample/issues/1","id":258647884,"user":{"login":"samuelsimoes","id":1456228,"avatar_url":"https://avatars.githubusercontent.com/u/1456228?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelsimoes","html_url":"https://github.com/samuelsimoes","followers_url":"https://api.github.com/users/samuelsimoes/followers","following_url":"https://api.github.com/users/samuelsimoes/following{/other_user}","gists_url":"https://api.github.com/users/samuelsimoes/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelsimoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelsimoes/subscriptions","organizations_url":"https://api.github.com/users/samuelsimoes/orgs","repos_url":"https://api.github.com/users/samuelsimoes/repos","events_url":"https://api.github.com/users/samuelsimoes/events{/privacy}","received_events_url":"https://api.github.com/users/samuelsimoes/received_events","type":"User","site_admin":false},"created_at":"2016-11-05T22:57:42Z","updated_at":"2016-11-05T22:57:42Z","body":"Please don't get me wrong. I really appreciate your willingness to help, but your PR has some issues:\r\n\r\n* It does too many unrelated changes.\r\n* Some commits also does some unrelated changes.\r\n* There's no previous issues discussing some changes like bootstrap, heroku deploy, the pg as database and so on, so you didn't give me a chance to explain that most of this changes are good for a production app, but this is a very lean example Rails app to not introduce any other setup questions to help newcomers to get, without any noise, the architectural structure.\r\n\r\nSo, can you split it into small and focused pull requests to help us to discuss and review?\r\n\r\nBy the way, I left to you these reads:\r\n\r\nhttps://github.com/python/mypy/wiki/Good-Pull-Request\r\nhttp://blog.ploeh.dk/2015/01/15/10-tips-for-better-pull-requests/\r\nhttps://ro-che.info/articles/2016-09-18-good-pull-requests"}}
{"actor":{"display_login":"samuelsimoes"}}