{"action":"created","comment":{"url":"https://api.github.com/repos/playframework/playframework/pulls/comments/74699511","id":74699511,"diff_hunk":"@@ -0,0 +1,22 @@\n+/*\n+ * Copyright (C) 2009-2016 Lightbend Inc. <https://www.lightbend.com>\n+ */\n+package play.mvc\n+\n+import akka.stream.Materializer\n+import play.api.mvc.{ Filter => SFilter }\n+\n+/**\n+ * This class is a Wrapper Class to get around the different trait Encodings\n+ * between Scala 2.11 and Scala 2.12\n+ *\n+ * @param materializer a simple Materializer\n+ * @param underlying the Filter that should be converted to scala\n+ */\n+abstract class JFilter(materializer: Materializer, val underlying: Filter) extends SFilter {","path":"framework/src/play/src/main/scala/play/mvc/JFilter.scala","position":16,"original_position":16,"commit_id":"3ae66925b825bb37bf706a61d02f9d8d29c6c4ef","original_commit_id":"3ae66925b825bb37bf706a61d02f9d8d29c6c4ef","user":{"login":"schmitch","id":1641401,"avatar_url":"https://avatars.githubusercontent.com/u/1641401?v=3","gravatar_id":"","url":"https://api.github.com/users/schmitch","html_url":"https://github.com/schmitch","followers_url":"https://api.github.com/users/schmitch/followers","following_url":"https://api.github.com/users/schmitch/following{/other_user}","gists_url":"https://api.github.com/users/schmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/schmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmitch/subscriptions","organizations_url":"https://api.github.com/users/schmitch/orgs","repos_url":"https://api.github.com/users/schmitch/repos","events_url":"https://api.github.com/users/schmitch/events{/privacy}","received_events_url":"https://api.github.com/users/schmitch/received_events","type":"User","site_admin":false},"body":"Actually the `val` could be removed, but I tought it looks nicer inside the Java Filter to use `this.underlying()` instead of  `Filter.this` (guess that was personal preferences only).\r\nI wasn't sure about `private[play]` since i wasn't sure how that would compile.\r\n\r\nYeah guess `AbstractFilter` is way clearer, thanks.","created_at":"2016-08-14T10:31:32Z","updated_at":"2016-08-14T10:31:32Z","html_url":"https://github.com/playframework/playframework/pull/6432#discussion_r74699511","pull_request_url":"https://api.github.com/repos/playframework/playframework/pulls/6432","_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments/74699511"},"html":{"href":"https://github.com/playframework/playframework/pull/6432#discussion_r74699511"},"pull_request":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6432"}}},"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/6432","id":81214087,"html_url":"https://github.com/playframework/playframework/pull/6432","diff_url":"https://github.com/playframework/playframework/pull/6432.diff","patch_url":"https://github.com/playframework/playframework/pull/6432.patch","issue_url":"https://api.github.com/repos/playframework/playframework/issues/6432","number":6432,"state":"open","locked":false,"title":"[WIP] upgrades play-doc, twirl and fixes some hiccups while trying to get scala 2.12 to work","user":{"login":"schmitch","id":1641401,"avatar_url":"https://avatars.githubusercontent.com/u/1641401?v=3","gravatar_id":"","url":"https://api.github.com/users/schmitch","html_url":"https://github.com/schmitch","followers_url":"https://api.github.com/users/schmitch/followers","following_url":"https://api.github.com/users/schmitch/following{/other_user}","gists_url":"https://api.github.com/users/schmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/schmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmitch/subscriptions","organizations_url":"https://api.github.com/users/schmitch/orgs","repos_url":"https://api.github.com/users/schmitch/repos","events_url":"https://api.github.com/users/schmitch/events{/privacy}","received_events_url":"https://api.github.com/users/schmitch/received_events","type":"User","site_admin":false},"body":"DO NOT MERGE\r\n\r\nactually these adds a wrapper class JFilter which actually works around the different trait encoding\r\nthat will be introduced by scala 2.12\r\nand it removes some calls to Int.unbox() in java which aren't necessary since we can just cast these to Integer (which Int.unbox) will do anyway, calling the intValue() isn't needed since this won't be so much overhread here and the jvm can unbox it anyway\r\nit also adds the newest version of twirl and play-doc\r\n\r\n\r\nThings that are still broken, when having local jars for 2.12:\r\n- Two test fails (i.e FormSpec's not found out the correct issue yet but it will be scala compiler emitting error so maybe this is fixed in upstream already)\r\n- https://github.com/scala/scala-java8-compat won't add JFunction to 0.8.0-RC3 jar which is needed to get it working. (fixed here: https://github.com/scala/scala-java8-compat/pull/74)\r\n- Upgrading or removing Fork-Run / Sbt-Fork-Run (Actually these 4 projects made problems:\r\n    `ForkRunProtocolProject`,\r\n    `SbtForkRunProtocolProject`,\r\n    `ForkRunProject`,\r\n    `SbtForkRunPluginProject`,\r\n) however they are only necessary for activator so `sbtRcClient`, `sbtRcActorClient` could be commented out for trying out stuff, I couldn't find the sources for sbtrc so I don't know if things broke or not.\r\n\r\nMore errors aren't seen, basicall I can run all tests except two inside IntegrationTests. The play-scala-intro and play-scala templates are working fine when these things are applied.\r\n\r\nP.S.: These fixes are just working fine with 2.11 and current Play, but I wanted to wait until even scala-java8-compat is fixed.\r\n\r\nP.S.: 2.12 reduces the *jar file sizes dramastically. the play.jar is like half the size, like most other stuff.\r\n\r\n\r\nTODO Documentation Tests fail:\r\n```\r\n[error] /home/schmitch/projects/schmitch/play/playframework/documentation/target/twirl/java/javaguide/forms/html/csrf.template.scala:29: too many arguments for method apply: ()play.twirl.api.HtmlFormat.Appendable in object form\r\n[error] Seq[Any](_display_(/*7.2*/form(CSRF(routes.ItemsController.save()))/*7.43*/ {_display_(Seq[Any](format.raw/*7.45*/(\"\"\"\r\n[error]                               ^\r\n[error] /home/schmitch/projects/schmitch/play/playframework/documentation/target/twirl/java/javaguide/forms/html/csrf.template.scala:35: too many arguments for method apply: ()play.twirl.api.HtmlFormat.Appendable in object form\r\n[error] \"\"\"),_display_(/*13.2*/form(routes.ItemsController.save())/*13.37*/ {_display_(Seq[Any](format.raw/*13.39*/(\"\"\"\r\n[error]                            ^\r\n[error] /home/schmitch/projects/schmitch/play/playframework/documentation/target/twirl/java/javaguide/i18n/html/hellotemplate.template.scala:28: reference to Messages is ambiguous;\r\n[error] it is imported twice in the same scope by\r\n[error] import play.i18n._\r\n[error] and import play.api.i18n._\r\n[error] Seq[Any](_display_(/*3.2*/Messages/*3.10*/.get(\"hello\")),format.raw/*3.23*/(\"\"\"\r\n[error]                           ^\r\n[warn] two warnings found\r\n[error] three errors found\r\n[error] (Play-Documentation/test:compileIncremental) Compilation failed\r\n[error] Total time: 33 s, completed Aug 13, 2016 2:17:37 PM\r\n```","created_at":"2016-08-13T11:52:46Z","updated_at":"2016-08-14T10:31:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acf091c45c5667d71092d32cbbc7851dcd73846d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/playframework/playframework/pulls/6432/commits","review_comments_url":"https://api.github.com/repos/playframework/playframework/pulls/6432/comments","review_comment_url":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/6432/comments","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/3ae66925b825bb37bf706a61d02f9d8d29c6c4ef","head":{"label":"schmitch:updated-play-doc","ref":"updated-play-doc","sha":"3ae66925b825bb37bf706a61d02f9d8d29c6c4ef","user":{"login":"schmitch","id":1641401,"avatar_url":"https://avatars.githubusercontent.com/u/1641401?v=3","gravatar_id":"","url":"https://api.github.com/users/schmitch","html_url":"https://github.com/schmitch","followers_url":"https://api.github.com/users/schmitch/followers","following_url":"https://api.github.com/users/schmitch/following{/other_user}","gists_url":"https://api.github.com/users/schmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/schmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmitch/subscriptions","organizations_url":"https://api.github.com/users/schmitch/orgs","repos_url":"https://api.github.com/users/schmitch/repos","events_url":"https://api.github.com/users/schmitch/events{/privacy}","received_events_url":"https://api.github.com/users/schmitch/received_events","type":"User","site_admin":false},"repo":{"id":46038091,"name":"playframework","full_name":"schmitch/playframework","owner":{"login":"schmitch","id":1641401,"avatar_url":"https://avatars.githubusercontent.com/u/1641401?v=3","gravatar_id":"","url":"https://api.github.com/users/schmitch","html_url":"https://github.com/schmitch","followers_url":"https://api.github.com/users/schmitch/followers","following_url":"https://api.github.com/users/schmitch/following{/other_user}","gists_url":"https://api.github.com/users/schmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/schmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmitch/subscriptions","organizations_url":"https://api.github.com/users/schmitch/orgs","repos_url":"https://api.github.com/users/schmitch/repos","events_url":"https://api.github.com/users/schmitch/events{/privacy}","received_events_url":"https://api.github.com/users/schmitch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schmitch/playframework","description":"Play Framework","fork":true,"url":"https://api.github.com/repos/schmitch/playframework","forks_url":"https://api.github.com/repos/schmitch/playframework/forks","keys_url":"https://api.github.com/repos/schmitch/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schmitch/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schmitch/playframework/teams","hooks_url":"https://api.github.com/repos/schmitch/playframework/hooks","issue_events_url":"https://api.github.com/repos/schmitch/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/schmitch/playframework/events","assignees_url":"https://api.github.com/repos/schmitch/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/schmitch/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/schmitch/playframework/tags","blobs_url":"https://api.github.com/repos/schmitch/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schmitch/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schmitch/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/schmitch/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schmitch/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/schmitch/playframework/languages","stargazers_url":"https://api.github.com/repos/schmitch/playframework/stargazers","contributors_url":"https://api.github.com/repos/schmitch/playframework/contributors","subscribers_url":"https://api.github.com/repos/schmitch/playframework/subscribers","subscription_url":"https://api.github.com/repos/schmitch/playframework/subscription","commits_url":"https://api.github.com/repos/schmitch/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/schmitch/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/schmitch/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/schmitch/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/schmitch/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/schmitch/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schmitch/playframework/merges","archive_url":"https://api.github.com/repos/schmitch/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schmitch/playframework/downloads","issues_url":"https://api.github.com/repos/schmitch/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/schmitch/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/schmitch/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/schmitch/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schmitch/playframework/labels{/name}","releases_url":"https://api.github.com/repos/schmitch/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/schmitch/playframework/deployments","created_at":"2015-11-12T07:57:24Z","updated_at":"2016-02-26T10:15:18Z","pushed_at":"2016-08-13T11:55:36Z","git_url":"git://github.com/schmitch/playframework.git","ssh_url":"git@github.com:schmitch/playframework.git","clone_url":"https://github.com/schmitch/playframework.git","svn_url":"https://github.com/schmitch/playframework","homepage":"http://www.playframework.com/","size":83272,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"playframework:master","ref":"master","sha":"67c292fd484388412b11395b348847c8b938f9dd","user":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2340549,"name":"playframework","full_name":"playframework/playframework","owner":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/playframework/playframework","description":"Play Framework","fork":false,"url":"https://api.github.com/repos/playframework/playframework","forks_url":"https://api.github.com/repos/playframework/playframework/forks","keys_url":"https://api.github.com/repos/playframework/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playframework/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playframework/playframework/teams","hooks_url":"https://api.github.com/repos/playframework/playframework/hooks","issue_events_url":"https://api.github.com/repos/playframework/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/playframework/playframework/events","assignees_url":"https://api.github.com/repos/playframework/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/playframework/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/playframework/playframework/tags","blobs_url":"https://api.github.com/repos/playframework/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playframework/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playframework/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/playframework/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/playframework/playframework/languages","stargazers_url":"https://api.github.com/repos/playframework/playframework/stargazers","contributors_url":"https://api.github.com/repos/playframework/playframework/contributors","subscribers_url":"https://api.github.com/repos/playframework/playframework/subscribers","subscription_url":"https://api.github.com/repos/playframework/playframework/subscription","commits_url":"https://api.github.com/repos/playframework/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/playframework/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/playframework/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/playframework/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/playframework/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/playframework/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playframework/playframework/merges","archive_url":"https://api.github.com/repos/playframework/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playframework/playframework/downloads","issues_url":"https://api.github.com/repos/playframework/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/playframework/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/playframework/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/playframework/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playframework/playframework/labels{/name}","releases_url":"https://api.github.com/repos/playframework/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/playframework/playframework/deployments","created_at":"2011-09-07T09:24:08Z","updated_at":"2016-08-14T10:03:20Z","pushed_at":"2016-08-14T09:18:59Z","git_url":"git://github.com/playframework/playframework.git","ssh_url":"git@github.com:playframework/playframework.git","clone_url":"https://github.com/playframework/playframework.git","svn_url":"https://github.com/playframework/playframework","homepage":"http://www.playframework.com/","size":95121,"stargazers_count":8253,"watchers_count":8253,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2839,"mirror_url":null,"open_issues_count":283,"forks":2839,"open_issues":283,"watchers":8253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6432"},"html":{"href":"https://github.com/playframework/playframework/pull/6432"},"issue":{"href":"https://api.github.com/repos/playframework/playframework/issues/6432"},"comments":{"href":"https://api.github.com/repos/playframework/playframework/issues/6432/comments"},"review_comments":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6432/comments"},"review_comment":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/playframework/playframework/pulls/6432/commits"},"statuses":{"href":"https://api.github.com/repos/playframework/playframework/statuses/3ae66925b825bb37bf706a61d02f9d8d29c6c4ef"}}}}
{"actor":{"display_login":"schmitch"}}