{"action":"created","issue":{"url":"https://api.github.com/repos/juwai/juwai-lint-cfg/issues/16","repository_url":"https://api.github.com/repos/juwai/juwai-lint-cfg","labels_url":"https://api.github.com/repos/juwai/juwai-lint-cfg/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/juwai/juwai-lint-cfg/issues/16/comments","events_url":"https://api.github.com/repos/juwai/juwai-lint-cfg/issues/16/events","html_url":"https://github.com/juwai/juwai-lint-cfg/pull/16","id":179719029,"number":16,"title":"[Hotfix] add stylelint module.","user":{"login":"monochrome-yeh","id":9444581,"avatar_url":"https://avatars.githubusercontent.com/u/9444581?v=3","gravatar_id":"","url":"https://api.github.com/users/monochrome-yeh","html_url":"https://github.com/monochrome-yeh","followers_url":"https://api.github.com/users/monochrome-yeh/followers","following_url":"https://api.github.com/users/monochrome-yeh/following{/other_user}","gists_url":"https://api.github.com/users/monochrome-yeh/gists{/gist_id}","starred_url":"https://api.github.com/users/monochrome-yeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monochrome-yeh/subscriptions","organizations_url":"https://api.github.com/users/monochrome-yeh/orgs","repos_url":"https://api.github.com/users/monochrome-yeh/repos","events_url":"https://api.github.com/users/monochrome-yeh/events{/privacy}","received_events_url":"https://api.github.com/users/monochrome-yeh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"arkhi","id":277773,"avatar_url":"https://avatars.githubusercontent.com/u/277773?v=3","gravatar_id":"","url":"https://api.github.com/users/arkhi","html_url":"https://github.com/arkhi","followers_url":"https://api.github.com/users/arkhi/followers","following_url":"https://api.github.com/users/arkhi/following{/other_user}","gists_url":"https://api.github.com/users/arkhi/gists{/gist_id}","starred_url":"https://api.github.com/users/arkhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arkhi/subscriptions","organizations_url":"https://api.github.com/users/arkhi/orgs","repos_url":"https://api.github.com/users/arkhi/repos","events_url":"https://api.github.com/users/arkhi/events{/privacy}","received_events_url":"https://api.github.com/users/arkhi/received_events","type":"User","site_admin":false},"assignees":[{"login":"arkhi","id":277773,"avatar_url":"https://avatars.githubusercontent.com/u/277773?v=3","gravatar_id":"","url":"https://api.github.com/users/arkhi","html_url":"https://github.com/arkhi","followers_url":"https://api.github.com/users/arkhi/followers","following_url":"https://api.github.com/users/arkhi/following{/other_user}","gists_url":"https://api.github.com/users/arkhi/gists{/gist_id}","starred_url":"https://api.github.com/users/arkhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arkhi/subscriptions","organizations_url":"https://api.github.com/users/arkhi/orgs","repos_url":"https://api.github.com/users/arkhi/repos","events_url":"https://api.github.com/users/arkhi/events{/privacy}","received_events_url":"https://api.github.com/users/arkhi/received_events","type":"User","site_admin":false},{"login":"HouCoder","id":5292143,"avatar_url":"https://avatars.githubusercontent.com/u/5292143?v=3","gravatar_id":"","url":"https://api.github.com/users/HouCoder","html_url":"https://github.com/HouCoder","followers_url":"https://api.github.com/users/HouCoder/followers","following_url":"https://api.github.com/users/HouCoder/following{/other_user}","gists_url":"https://api.github.com/users/HouCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/HouCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HouCoder/subscriptions","organizations_url":"https://api.github.com/users/HouCoder/orgs","repos_url":"https://api.github.com/users/HouCoder/repos","events_url":"https://api.github.com/users/HouCoder/events{/privacy}","received_events_url":"https://api.github.com/users/HouCoder/received_events","type":"User","site_admin":false},{"login":"ben-juwai","id":8098026,"avatar_url":"https://avatars.githubusercontent.com/u/8098026?v=3","gravatar_id":"","url":"https://api.github.com/users/ben-juwai","html_url":"https://github.com/ben-juwai","followers_url":"https://api.github.com/users/ben-juwai/followers","following_url":"https://api.github.com/users/ben-juwai/following{/other_user}","gists_url":"https://api.github.com/users/ben-juwai/gists{/gist_id}","starred_url":"https://api.github.com/users/ben-juwai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben-juwai/subscriptions","organizations_url":"https://api.github.com/users/ben-juwai/orgs","repos_url":"https://api.github.com/users/ben-juwai/repos","events_url":"https://api.github.com/users/ben-juwai/events{/privacy}","received_events_url":"https://api.github.com/users/ben-juwai/received_events","type":"User","site_admin":false},{"login":"jonlys-juwai","id":8665640,"avatar_url":"https://avatars.githubusercontent.com/u/8665640?v=3","gravatar_id":"","url":"https://api.github.com/users/jonlys-juwai","html_url":"https://github.com/jonlys-juwai","followers_url":"https://api.github.com/users/jonlys-juwai/followers","following_url":"https://api.github.com/users/jonlys-juwai/following{/other_user}","gists_url":"https://api.github.com/users/jonlys-juwai/gists{/gist_id}","starred_url":"https://api.github.com/users/jonlys-juwai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonlys-juwai/subscriptions","organizations_url":"https://api.github.com/users/jonlys-juwai/orgs","repos_url":"https://api.github.com/users/jonlys-juwai/repos","events_url":"https://api.github.com/users/jonlys-juwai/events{/privacy}","received_events_url":"https://api.github.com/users/jonlys-juwai/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2016-09-28T09:10:05Z","updated_at":"2016-10-03T03:41:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/juwai/juwai-lint-cfg/pulls/16","html_url":"https://github.com/juwai/juwai-lint-cfg/pull/16","diff_url":"https://github.com/juwai/juwai-lint-cfg/pull/16.diff","patch_url":"https://github.com/juwai/juwai-lint-cfg/pull/16.patch"},"body":"## Summary of changes\r\n\r\n- Add stylelint module in package.json\r\n\r\n## How to Test\r\n\r\n- The others repository will use `juwai-lint-cfg`'s stylelint module.\r\n- We have to do as following actions once in your main repository:\r\n    - The other repositories have to remove their package.json's stylelint\r\n    - The other repositories have to change their grunt/gulp/wepack 's module link to here.\r\n        - for example: `require( 'juwai-lint-cfg/node_modules/stylelint' );`\r\n\r\n## Note\r\n- We could accord stylelint version with .stylelintrc in this repository now.\r\n\r\n/fyi: @HouCoder , @ben-juwai , @jonlys-juwai \r\n/cc: @arkhi "},"comment":{"url":"https://api.github.com/repos/juwai/juwai-lint-cfg/issues/comments/251020581","html_url":"https://github.com/juwai/juwai-lint-cfg/pull/16#issuecomment-251020581","issue_url":"https://api.github.com/repos/juwai/juwai-lint-cfg/issues/16","id":251020581,"user":{"login":"arkhi","id":277773,"avatar_url":"https://avatars.githubusercontent.com/u/277773?v=3","gravatar_id":"","url":"https://api.github.com/users/arkhi","html_url":"https://github.com/arkhi","followers_url":"https://api.github.com/users/arkhi/followers","following_url":"https://api.github.com/users/arkhi/following{/other_user}","gists_url":"https://api.github.com/users/arkhi/gists{/gist_id}","starred_url":"https://api.github.com/users/arkhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arkhi/subscriptions","organizations_url":"https://api.github.com/users/arkhi/orgs","repos_url":"https://api.github.com/users/arkhi/repos","events_url":"https://api.github.com/users/arkhi/events{/privacy}","received_events_url":"https://api.github.com/users/arkhi/received_events","type":"User","site_admin":false},"created_at":"2016-10-03T03:41:04Z","updated_at":"2016-10-03T03:41:04Z","body":"@monochrome-yeh: Did you freshly clone your repository and branch first, or did you create this new branch based on your branch with webback?\r\n@HouCoder: You need to checkout the branch or the commit where the changes have been made, otherewise npm will clone master (where there is no npm). Regardless, it won’t work though, you’re right:\r\n\r\n```json\r\n  \"devDependencies\": {\r\n    \"juwai-lint-cfg\": \"git@github.com:monochrome-yeh/juwai-lint-cfg#3128d87879b6038d12d07fad111e6471fbefbd1e\",\r\n    \"stylelint\": \"file:./node_modules/juwai-lint-cfg/node_modules/stylelint\"\r\n  }\r\n```\r\n\r\n---\r\n\r\nShouldn’t stylelint be available since it’s installed with juwai-lint-cfg?\r\nThat means we could only have this package.json for a new project:\r\n```json\r\n  \"devDependencies\": {\r\n    \"juwai-lint-cfg\": \"git@github.com:monochrome-yeh/juwai-lint-cfg#Hotfix-add-stylelint\"\r\n  }\r\n```\r\nThen we can have the same logic and create symbolic links in the `node_modules/.bin` folder once all linters have been installed.\r\n\r\nI’ll try this and make a PR on this branch."}}
{"actor":{"display_login":"arkhi"}}