{"action":"closed","number":31876,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/31876","id":60612973,"html_url":"https://github.com/rust-lang/rust/pull/31876","diff_url":"https://github.com/rust-lang/rust/pull/31876.diff","patch_url":"https://github.com/rust-lang/rust/pull/31876.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/31876","number":31876,"state":"closed","locked":false,"title":"rand: Fix OsRng::fill_bytes on Windows","user":{"login":"ollie27","id":7189418,"avatar_url":"https://avatars.githubusercontent.com/u/7189418?v=3","gravatar_id":"","url":"https://api.github.com/users/ollie27","html_url":"https://github.com/ollie27","followers_url":"https://api.github.com/users/ollie27/followers","following_url":"https://api.github.com/users/ollie27/following{/other_user}","gists_url":"https://api.github.com/users/ollie27/gists{/gist_id}","starred_url":"https://api.github.com/users/ollie27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ollie27/subscriptions","organizations_url":"https://api.github.com/users/ollie27/orgs","repos_url":"https://api.github.com/users/ollie27/repos","events_url":"https://api.github.com/users/ollie27/events{/privacy}","received_events_url":"https://api.github.com/users/ollie27/received_events","type":"User","site_admin":false},"body":"CryptGenRandom takes a DWORD (u32) for the length so it only supports\r\nwriting u32::MAX bytes at a time.\r\n\r\nCasting the length from a usize caused truncation meaning the whole\r\nbuffer was not always filled.\r\n\r\ncc #31841\r\n\r\nThis is the same as rust-lang-nursery/rand#99. I think it's a good idea to keep the implementations in sync.\r\n\r\nr? @alexcrichton ","created_at":"2016-02-25T02:02:03Z","updated_at":"2016-02-27T01:15:29Z","closed_at":"2016-02-27T01:15:29Z","merged_at":"2016-02-27T01:15:29Z","merge_commit_sha":"8dd9ea5759b3129ec8098b5b1c3831cae97ab66a","assignee":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/31876/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/31876/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/31876/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/ac3cc33fee5e0f576cc9f04f7df40cd5d968be43","head":{"label":"ollie27:win_fill_bytes","ref":"win_fill_bytes","sha":"ac3cc33fee5e0f576cc9f04f7df40cd5d968be43","user":{"login":"ollie27","id":7189418,"avatar_url":"https://avatars.githubusercontent.com/u/7189418?v=3","gravatar_id":"","url":"https://api.github.com/users/ollie27","html_url":"https://github.com/ollie27","followers_url":"https://api.github.com/users/ollie27/followers","following_url":"https://api.github.com/users/ollie27/following{/other_user}","gists_url":"https://api.github.com/users/ollie27/gists{/gist_id}","starred_url":"https://api.github.com/users/ollie27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ollie27/subscriptions","organizations_url":"https://api.github.com/users/ollie27/orgs","repos_url":"https://api.github.com/users/ollie27/repos","events_url":"https://api.github.com/users/ollie27/events{/privacy}","received_events_url":"https://api.github.com/users/ollie27/received_events","type":"User","site_admin":false},"repo":{"id":45603985,"name":"rust","full_name":"ollie27/rust","owner":{"login":"ollie27","id":7189418,"avatar_url":"https://avatars.githubusercontent.com/u/7189418?v=3","gravatar_id":"","url":"https://api.github.com/users/ollie27","html_url":"https://github.com/ollie27","followers_url":"https://api.github.com/users/ollie27/followers","following_url":"https://api.github.com/users/ollie27/following{/other_user}","gists_url":"https://api.github.com/users/ollie27/gists{/gist_id}","starred_url":"https://api.github.com/users/ollie27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ollie27/subscriptions","organizations_url":"https://api.github.com/users/ollie27/orgs","repos_url":"https://api.github.com/users/ollie27/repos","events_url":"https://api.github.com/users/ollie27/events{/privacy}","received_events_url":"https://api.github.com/users/ollie27/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ollie27/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/ollie27/rust","forks_url":"https://api.github.com/repos/ollie27/rust/forks","keys_url":"https://api.github.com/repos/ollie27/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ollie27/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ollie27/rust/teams","hooks_url":"https://api.github.com/repos/ollie27/rust/hooks","issue_events_url":"https://api.github.com/repos/ollie27/rust/issues/events{/number}","events_url":"https://api.github.com/repos/ollie27/rust/events","assignees_url":"https://api.github.com/repos/ollie27/rust/assignees{/user}","branches_url":"https://api.github.com/repos/ollie27/rust/branches{/branch}","tags_url":"https://api.github.com/repos/ollie27/rust/tags","blobs_url":"https://api.github.com/repos/ollie27/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ollie27/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ollie27/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/ollie27/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ollie27/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/ollie27/rust/languages","stargazers_url":"https://api.github.com/repos/ollie27/rust/stargazers","contributors_url":"https://api.github.com/repos/ollie27/rust/contributors","subscribers_url":"https://api.github.com/repos/ollie27/rust/subscribers","subscription_url":"https://api.github.com/repos/ollie27/rust/subscription","commits_url":"https://api.github.com/repos/ollie27/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/ollie27/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/ollie27/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/ollie27/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/ollie27/rust/contents/{+path}","compare_url":"https://api.github.com/repos/ollie27/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ollie27/rust/merges","archive_url":"https://api.github.com/repos/ollie27/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ollie27/rust/downloads","issues_url":"https://api.github.com/repos/ollie27/rust/issues{/number}","pulls_url":"https://api.github.com/repos/ollie27/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/ollie27/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/ollie27/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ollie27/rust/labels{/name}","releases_url":"https://api.github.com/repos/ollie27/rust/releases{/id}","deployments_url":"https://api.github.com/repos/ollie27/rust/deployments","created_at":"2015-11-05T10:22:49Z","updated_at":"2016-02-14T17:47:09Z","pushed_at":"2016-02-25T01:39:25Z","git_url":"git://github.com/ollie27/rust.git","ssh_url":"git@github.com:ollie27/rust.git","clone_url":"https://github.com/ollie27/rust.git","svn_url":"https://github.com/ollie27/rust","homepage":"https://www.rust-lang.org","size":281194,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"0ef8d426050318934d16d962325ec002eaf0c29d","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-02-26T23:40:13Z","pushed_at":"2016-02-27T01:15:23Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":471679,"stargazers_count":15425,"watchers_count":15425,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2993,"mirror_url":null,"open_issues_count":2328,"forks":2993,"open_issues":2328,"watchers":15425,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/31876"},"html":{"href":"https://github.com/rust-lang/rust/pull/31876"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/31876"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/31876/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/31876/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/31876/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/ac3cc33fee5e0f576cc9f04f7df40cd5d968be43"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bors","id":3372342,"avatar_url":"https://avatars.githubusercontent.com/u/3372342?v=3","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"commits":1,"additions":11,"deletions":7,"changed_files":1}}