{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/9410","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/9410/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/9410/comments","events_url":"https://api.github.com/repos/servo/servo/issues/9410/events","html_url":"https://github.com/servo/servo/pull/9410","id":128358569,"number":9410,"title":"Adding sync method to update atrr from inline style updates","user":{"login":"craftytrickster","id":10675565,"avatar_url":"https://avatars.githubusercontent.com/u/10675565?v=3","gravatar_id":"","url":"https://api.github.com/users/craftytrickster","html_url":"https://github.com/craftytrickster","followers_url":"https://api.github.com/users/craftytrickster/followers","following_url":"https://api.github.com/users/craftytrickster/following{/other_user}","gists_url":"https://api.github.com/users/craftytrickster/gists{/gist_id}","starred_url":"https://api.github.com/users/craftytrickster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craftytrickster/subscriptions","organizations_url":"https://api.github.com/users/craftytrickster/orgs","repos_url":"https://api.github.com/users/craftytrickster/repos","events_url":"https://api.github.com/users/craftytrickster/events{/privacy}","received_events_url":"https://api.github.com/users/craftytrickster/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"nox","id":123095,"avatar_url":"https://avatars.githubusercontent.com/u/123095?v=3","gravatar_id":"","url":"https://api.github.com/users/nox","html_url":"https://github.com/nox","followers_url":"https://api.github.com/users/nox/followers","following_url":"https://api.github.com/users/nox/following{/other_user}","gists_url":"https://api.github.com/users/nox/gists{/gist_id}","starred_url":"https://api.github.com/users/nox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nox/subscriptions","organizations_url":"https://api.github.com/users/nox/orgs","repos_url":"https://api.github.com/users/nox/repos","events_url":"https://api.github.com/users/nox/events{/privacy}","received_events_url":"https://api.github.com/users/nox/received_events","type":"User","site_admin":false},"milestone":null,"comments":19,"created_at":"2016-01-23T23:09:42Z","updated_at":"2016-02-18T10:15:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/9410","html_url":"https://github.com/servo/servo/pull/9410","diff_url":"https://github.com/servo/servo/pull/9410.diff","patch_url":"https://github.com/servo/servo/pull/9410.patch"},"body":"https://github.com/servo/servo/issues/9307\r\n\r\nI am not terribly confident in this PR, but `getAttribute(\"style\")` does update correctly now. If the implementation here is more or less \"correct\", I will add unit tests to confirm that the attr for style is updated correctly. If it is completely off, I will gladly keep trying, but I also understand if someone else with more experience with Rust and this area of the application wants to do it.\r\n\r\nThere are a few things I do not like here, such as:\r\n* Manually forming the string `new_style` in `sync_property_with_attrs_style` \r\n* In the `fn update_inline_style`, I needed to coerce the value to a string slice, so I did `&format!(\"{}\", &property_decl.name()`, but I am sure there is a better way to do this.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/9410)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/185639142","html_url":"https://github.com/servo/servo/pull/9410#issuecomment-185639142","issue_url":"https://api.github.com/repos/servo/servo/issues/9410","id":185639142,"user":{"login":"bors-servo","id":4368172,"avatar_url":"https://avatars.githubusercontent.com/u/4368172?v=3","gravatar_id":"","url":"https://api.github.com/users/bors-servo","html_url":"https://github.com/bors-servo","followers_url":"https://api.github.com/users/bors-servo/followers","following_url":"https://api.github.com/users/bors-servo/following{/other_user}","gists_url":"https://api.github.com/users/bors-servo/gists{/gist_id}","starred_url":"https://api.github.com/users/bors-servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors-servo/subscriptions","organizations_url":"https://api.github.com/users/bors-servo/orgs","repos_url":"https://api.github.com/users/bors-servo/repos","events_url":"https://api.github.com/users/bors-servo/events{/privacy}","received_events_url":"https://api.github.com/users/bors-servo/received_events","type":"User","site_admin":false},"created_at":"2016-02-18T10:15:22Z","updated_at":"2016-02-18T10:15:22Z","body":":umbrella: The latest upstream changes (presumably #9686) made this pull request unmergeable. Please resolve the merge conflicts."}}