{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/80212584","id":80212584,"diff_hunk":"@@ -28,75 +34,136 @@ public static function onBeforePageDisplay() {\n \t\treturn true;\n \t}\n \n-\tpublic static function render( $input, array $args ) {\n-\t\tglobal $wgCityId;\n+\t/**\n+\t * Checks arguments for errors.\n+\t * @param array $args\n+\t * @param string errorMessage Return parameter with the proper error message to show. Disregard if return is false\n+\t * @return true if ok, false if error\n+\t */\n+\tprivate function checkArguments( array $args, $modelData, &$errorMessage ) {\n+\t\t// mostrecent must be bool\n+\t\tif ( isset( $args['mostrecent'] ) &&\n+\t\t\t$args['mostrecent'] !== 'true' &&\n+\t\t\t$args['mostrecent'] !== 'false'\n+\t\t) {\n+\t\t\t$errorMessage = wfMessage( 'embeddable-discussions-parameter-error', 'mostrecent' )->plain() .\n+\t\t\t\twfMessage( 'embeddable-discussions-parameter-error-boolean' )->plain();\n+\n+\t\t\treturn false;\n+\t\t}\n \n-\t\t$showLatest = !empty( $args['mostrecent'] ) && filter_var( $args['mostrecent'], FILTER_VALIDATE_BOOLEAN );\n-\t\t$itemCount = empty( $args['size'] ) ? self::ITEMS_DEFAULT : intval( $args['size'] );\n-\t\t$columns = empty( $args['columns'] ) ? self::COLUMNS_DEFAULT : intval( $args['columns'] );\n-\t\t$category = empty( $args['category'] ) ? '' :  $args['category'];\n+\t\t// size must be integer in range\n+\t\tif ( isset( $args['size'] ) ) {\n+\t\t\t$size = $args['size'];\n \n-\t\tif ( $itemCount > self::ITEMS_MAX ) {\n-\t\t\t$itemCount = self::ITEMS_MAX;\n-\t\t}\n+\t\t\tif ( !ctype_digit( $size ) ||\n+\t\t\t\tintval( $size ) > self::ITEMS_MAX ||\n+\t\t\t\tintval( $size ) < self::ITEMS_MIN\n+\t\t\t) {\n+\t\t\t\t// TODO: Refactor error messages to avoid direct concatenation, see JPN-657\n+\t\t\t\t$errorMessage = wfMessage( 'embeddable-discussions-parameter-error', 'size' )->plain() .\n+\t\t\t\t\twfMessage( 'embeddable-discussions-parameter-error-range',\n+\t\t\t\t\t\tself::ITEMS_MIN , self::ITEMS_MAX )->plain();\n \n-\t\tif ( $itemCount < self::ITEMS_MIN ) {\n-\t\t\t$itemCount = self::ITEMS_MIN;\n+\t\t\t\treturn false;\n+\t\t\t}\n \t\t}\n \n-\t\tif ( $columns < self::COLUMNS_MIN ) {\n-\t\t\t$columns = self::COLUMNS_MIN;\n+\t\t// columns must be integer in range\n+\t\tif ( isset( $args['columns'] ) ) {\n+\t\t\t$columns = $args['columns'];\n+\n+\t\t\tif ( !ctype_digit( $columns ) ||\n+\t\t\t\tintval( $columns ) > self::COLUMNS_MAX ||\n+\t\t\t\tintval( $columns ) < self::COLUMNS_MIN\n+\t\t\t) {\n+\t\t\t\t// TODO: Refactor error messages to avoid direct concatenation, see JPN-657\n+\t\t\t\t$errorMessage = wfMessage( 'embeddable-discussions-parameter-error', 'columns' )->plain() .\n+\t\t\t\t\twfMessage( 'embeddable-discussions-parameter-error-range', self::COLUMNS_MIN , self::COLUMNS_MAX )->plain();\n+\n+\t\t\t\treturn false;\n+\t\t\t}\n \t\t}\n \n-\t\tif ( $columns > self::COLUMNS_MAX ) {\n-\t\t\t$columns = self::COLUMNS_MAX;\n+\t\t// category must be a valid category\n+\t\tif ( $modelData['invalidCategory'] ) {\n+\t\t\t// TODO: Refactor error messages to avoid direct concatenation, see JPN-657\n+\t\t\t$errorMessage = wfMessage( 'embeddable-discussions-parameter-error', $args['category'] )->plain() .","path":"extensions/wikia/EmbeddableDiscussions/EmbeddableDiscussionsController.class.php","position":98,"original_position":98,"commit_id":"626967a21c246d968355fcdd4abe699b747ea4d8","original_commit_id":"626967a21c246d968355fcdd4abe699b747ea4d8","user":{"login":"WikiaTech","id":13279985,"avatar_url":"https://avatars.githubusercontent.com/u/13279985?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiaTech","html_url":"https://github.com/WikiaTech","followers_url":"https://api.github.com/users/WikiaTech/followers","following_url":"https://api.github.com/users/WikiaTech/following{/other_user}","gists_url":"https://api.github.com/users/WikiaTech/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiaTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiaTech/subscriptions","organizations_url":"https://api.github.com/users/WikiaTech/orgs","repos_url":"https://api.github.com/users/WikiaTech/repos","events_url":"https://api.github.com/users/WikiaTech/events{/privacy}","received_events_url":"https://api.github.com/users/WikiaTech/received_events","type":"User","site_admin":false},"body":"![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) Define a constant instead of duplicating this literal \"category\" 5 times. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://10.8.74.32:9000/coding_rules#rule_key=php%3AS1192)\n","created_at":"2016-09-23T09:41:51Z","updated_at":"2016-09-23T09:41:51Z","html_url":"https://github.com/Wikia/app/pull/11313#discussion_r80212584","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/11313","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/80212584"},"html":{"href":"https://github.com/Wikia/app/pull/11313#discussion_r80212584"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/11313"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/11313","id":84993793,"html_url":"https://github.com/Wikia/app/pull/11313","diff_url":"https://github.com/Wikia/app/pull/11313.diff","patch_url":"https://github.com/Wikia/app/pull/11313.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/11313","number":11313,"state":"open","locked":false,"title":"JPN-644 Implement error messages for incorrect parameters to discussi…","user":{"login":"perjg","id":651004,"avatar_url":"https://avatars.githubusercontent.com/u/651004?v=3","gravatar_id":"","url":"https://api.github.com/users/perjg","html_url":"https://github.com/perjg","followers_url":"https://api.github.com/users/perjg/followers","following_url":"https://api.github.com/users/perjg/following{/other_user}","gists_url":"https://api.github.com/users/perjg/gists{/gist_id}","starred_url":"https://api.github.com/users/perjg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perjg/subscriptions","organizations_url":"https://api.github.com/users/perjg/orgs","repos_url":"https://api.github.com/users/perjg/repos","events_url":"https://api.github.com/users/perjg/events{/privacy}","received_events_url":"https://api.github.com/users/perjg/received_events","type":"User","site_admin":false},"body":" Implement error messages for incorrect parameters to discussions tag.\r\n\r\nThis also changes how category id is looked up from category name, in order to flag an incorrect category parameter correctly.\r\n\r\n@d34th4ck3r @Grunny @garthwebb ","created_at":"2016-09-13T06:50:59Z","updated_at":"2016-09-23T09:41:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07e32fcf41aa69d63f3850729f2c19eb22995c43","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/11313/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/11313/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/11313/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/626967a21c246d968355fcdd4abe699b747ea4d8","head":{"label":"Wikia:JPN-644","ref":"JPN-644","sha":"626967a21c246d968355fcdd4abe699b747ea4d8","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2016-09-03T16:51:09Z","pushed_at":"2016-09-23T09:41:12Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1430528,"stargazers_count":102,"watchers_count":102,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":81,"mirror_url":null,"open_issues_count":123,"forks":81,"open_issues":123,"watchers":102,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"cc5c3360f543f3f3cfb3c6b9898eee3743d6cf73","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2016-09-03T16:51:09Z","pushed_at":"2016-09-23T09:41:12Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1430528,"stargazers_count":102,"watchers_count":102,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":81,"mirror_url":null,"open_issues_count":123,"forks":81,"open_issues":123,"watchers":102,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/11313"},"html":{"href":"https://github.com/Wikia/app/pull/11313"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/11313"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/11313/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/11313/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/11313/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/626967a21c246d968355fcdd4abe699b747ea4d8"}}}}
{"actor":{"display_login":"WikiaTech"}}