{"action":"created","comment":{"url":"https://api.github.com/repos/kimai/kimai-mobile/pulls/comments/72395595","id":72395595,"diff_hunk":"@@ -82,6 +82,7 @@\n \t\t}\n \t});\n \t</script>\n+\t<link href=\"favicon.ico\" rel=\"shortcut icon\"></link>","path":"index.php","position":4,"original_position":4,"commit_id":"c97c4278f5ad95ee739d26df48e3fe57be0ff94c","original_commit_id":"c97c4278f5ad95ee739d26df48e3fe57be0ff94c","user":{"login":"kevinpapst","id":533162,"avatar_url":"https://avatars.githubusercontent.com/u/533162?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinpapst","html_url":"https://github.com/kevinpapst","followers_url":"https://api.github.com/users/kevinpapst/followers","following_url":"https://api.github.com/users/kevinpapst/following{/other_user}","gists_url":"https://api.github.com/users/kevinpapst/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinpapst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinpapst/subscriptions","organizations_url":"https://api.github.com/users/kevinpapst/orgs","repos_url":"https://api.github.com/users/kevinpapst/repos","events_url":"https://api.github.com/users/kevinpapst/events{/privacy}","received_events_url":"https://api.github.com/users/kevinpapst/received_events","type":"User","site_admin":false},"body":"The main problem is, that this \"app\" does not ship a favcon and your line only works in smoe circuminstances. If somebody has Kimai in a subfolder, there is probably no favicon.ico at that URL.\r\n","created_at":"2016-07-27T07:54:16Z","updated_at":"2016-07-27T07:54:16Z","html_url":"https://github.com/kimai/kimai-mobile/pull/17#discussion_r72395595","pull_request_url":"https://api.github.com/repos/kimai/kimai-mobile/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/kimai/kimai-mobile/pulls/comments/72395595"},"html":{"href":"https://github.com/kimai/kimai-mobile/pull/17#discussion_r72395595"},"pull_request":{"href":"https://api.github.com/repos/kimai/kimai-mobile/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/kimai/kimai-mobile/pulls/17","id":78798860,"html_url":"https://github.com/kimai/kimai-mobile/pull/17","diff_url":"https://github.com/kimai/kimai-mobile/pull/17.diff","patch_url":"https://github.com/kimai/kimai-mobile/pull/17.patch","issue_url":"https://api.github.com/repos/kimai/kimai-mobile/issues/17","number":17,"state":"open","locked":false,"title":"Added Kimai favicon","user":{"login":"joejoe31b","id":9375730,"avatar_url":"https://avatars.githubusercontent.com/u/9375730?v=3","gravatar_id":"","url":"https://api.github.com/users/joejoe31b","html_url":"https://github.com/joejoe31b","followers_url":"https://api.github.com/users/joejoe31b/followers","following_url":"https://api.github.com/users/joejoe31b/following{/other_user}","gists_url":"https://api.github.com/users/joejoe31b/gists{/gist_id}","starred_url":"https://api.github.com/users/joejoe31b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joejoe31b/subscriptions","organizations_url":"https://api.github.com/users/joejoe31b/orgs","repos_url":"https://api.github.com/users/joejoe31b/repos","events_url":"https://api.github.com/users/joejoe31b/events{/privacy}","received_events_url":"https://api.github.com/users/joejoe31b/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-26T06:39:33Z","updated_at":"2016-07-27T07:54:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b01ac4a87dd874e1e4e92ec4b6a98ef212b9e99a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kimai/kimai-mobile/pulls/17/commits","review_comments_url":"https://api.github.com/repos/kimai/kimai-mobile/pulls/17/comments","review_comment_url":"https://api.github.com/repos/kimai/kimai-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kimai/kimai-mobile/issues/17/comments","statuses_url":"https://api.github.com/repos/kimai/kimai-mobile/statuses/c97c4278f5ad95ee739d26df48e3fe57be0ff94c","head":{"label":"joejoe31b:favicons","ref":"favicons","sha":"c97c4278f5ad95ee739d26df48e3fe57be0ff94c","user":{"login":"joejoe31b","id":9375730,"avatar_url":"https://avatars.githubusercontent.com/u/9375730?v=3","gravatar_id":"","url":"https://api.github.com/users/joejoe31b","html_url":"https://github.com/joejoe31b","followers_url":"https://api.github.com/users/joejoe31b/followers","following_url":"https://api.github.com/users/joejoe31b/following{/other_user}","gists_url":"https://api.github.com/users/joejoe31b/gists{/gist_id}","starred_url":"https://api.github.com/users/joejoe31b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joejoe31b/subscriptions","organizations_url":"https://api.github.com/users/joejoe31b/orgs","repos_url":"https://api.github.com/users/joejoe31b/repos","events_url":"https://api.github.com/users/joejoe31b/events{/privacy}","received_events_url":"https://api.github.com/users/joejoe31b/received_events","type":"User","site_admin":false},"repo":{"id":64193310,"name":"kimai-mobile_dev","full_name":"joejoe31b/kimai-mobile_dev","owner":{"login":"joejoe31b","id":9375730,"avatar_url":"https://avatars.githubusercontent.com/u/9375730?v=3","gravatar_id":"","url":"https://api.github.com/users/joejoe31b","html_url":"https://github.com/joejoe31b","followers_url":"https://api.github.com/users/joejoe31b/followers","following_url":"https://api.github.com/users/joejoe31b/following{/other_user}","gists_url":"https://api.github.com/users/joejoe31b/gists{/gist_id}","starred_url":"https://api.github.com/users/joejoe31b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joejoe31b/subscriptions","organizations_url":"https://api.github.com/users/joejoe31b/orgs","repos_url":"https://api.github.com/users/joejoe31b/repos","events_url":"https://api.github.com/users/joejoe31b/events{/privacy}","received_events_url":"https://api.github.com/users/joejoe31b/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joejoe31b/kimai-mobile_dev","description":"jQuery mobile powered mobile frontend for Kimai, optimized for usage on mobile end devices like Tablets and Phones.","fork":true,"url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev","forks_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/forks","keys_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/teams","hooks_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/hooks","issue_events_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/issues/events{/number}","events_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/events","assignees_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/assignees{/user}","branches_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/branches{/branch}","tags_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/tags","blobs_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/statuses/{sha}","languages_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/languages","stargazers_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/stargazers","contributors_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/contributors","subscribers_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/subscribers","subscription_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/subscription","commits_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/contents/{+path}","compare_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/merges","archive_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/downloads","issues_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/issues{/number}","pulls_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/pulls{/number}","milestones_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/milestones{/number}","notifications_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/labels{/name}","releases_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/releases{/id}","deployments_url":"https://api.github.com/repos/joejoe31b/kimai-mobile_dev/deployments","created_at":"2016-07-26T05:43:48Z","updated_at":"2016-07-26T05:46:13Z","pushed_at":"2016-07-26T06:38:46Z","git_url":"git://github.com/joejoe31b/kimai-mobile_dev.git","ssh_url":"git@github.com:joejoe31b/kimai-mobile_dev.git","clone_url":"https://github.com/joejoe31b/kimai-mobile_dev.git","svn_url":"https://github.com/joejoe31b/kimai-mobile_dev","homepage":"","size":109,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kimai:master","ref":"master","sha":"de7ec007afb8d7650513e475e4bb4321af2fed4d","user":{"login":"kimai","id":981996,"avatar_url":"https://avatars.githubusercontent.com/u/981996?v=3","gravatar_id":"","url":"https://api.github.com/users/kimai","html_url":"https://github.com/kimai","followers_url":"https://api.github.com/users/kimai/followers","following_url":"https://api.github.com/users/kimai/following{/other_user}","gists_url":"https://api.github.com/users/kimai/gists{/gist_id}","starred_url":"https://api.github.com/users/kimai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimai/subscriptions","organizations_url":"https://api.github.com/users/kimai/orgs","repos_url":"https://api.github.com/users/kimai/repos","events_url":"https://api.github.com/users/kimai/events{/privacy}","received_events_url":"https://api.github.com/users/kimai/received_events","type":"Organization","site_admin":false},"repo":{"id":2983194,"name":"kimai-mobile","full_name":"kimai/kimai-mobile","owner":{"login":"kimai","id":981996,"avatar_url":"https://avatars.githubusercontent.com/u/981996?v=3","gravatar_id":"","url":"https://api.github.com/users/kimai","html_url":"https://github.com/kimai","followers_url":"https://api.github.com/users/kimai/followers","following_url":"https://api.github.com/users/kimai/following{/other_user}","gists_url":"https://api.github.com/users/kimai/gists{/gist_id}","starred_url":"https://api.github.com/users/kimai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimai/subscriptions","organizations_url":"https://api.github.com/users/kimai/orgs","repos_url":"https://api.github.com/users/kimai/repos","events_url":"https://api.github.com/users/kimai/events{/privacy}","received_events_url":"https://api.github.com/users/kimai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kimai/kimai-mobile","description":"jQuery mobile powered mobile frontend for Kimai, optimized for usage on mobile end devices like Tablets and Phones.","fork":false,"url":"https://api.github.com/repos/kimai/kimai-mobile","forks_url":"https://api.github.com/repos/kimai/kimai-mobile/forks","keys_url":"https://api.github.com/repos/kimai/kimai-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kimai/kimai-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kimai/kimai-mobile/teams","hooks_url":"https://api.github.com/repos/kimai/kimai-mobile/hooks","issue_events_url":"https://api.github.com/repos/kimai/kimai-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/kimai/kimai-mobile/events","assignees_url":"https://api.github.com/repos/kimai/kimai-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/kimai/kimai-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/kimai/kimai-mobile/tags","blobs_url":"https://api.github.com/repos/kimai/kimai-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kimai/kimai-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kimai/kimai-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/kimai/kimai-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kimai/kimai-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/kimai/kimai-mobile/languages","stargazers_url":"https://api.github.com/repos/kimai/kimai-mobile/stargazers","contributors_url":"https://api.github.com/repos/kimai/kimai-mobile/contributors","subscribers_url":"https://api.github.com/repos/kimai/kimai-mobile/subscribers","subscription_url":"https://api.github.com/repos/kimai/kimai-mobile/subscription","commits_url":"https://api.github.com/repos/kimai/kimai-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/kimai/kimai-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/kimai/kimai-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/kimai/kimai-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/kimai/kimai-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/kimai/kimai-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kimai/kimai-mobile/merges","archive_url":"https://api.github.com/repos/kimai/kimai-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kimai/kimai-mobile/downloads","issues_url":"https://api.github.com/repos/kimai/kimai-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/kimai/kimai-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/kimai/kimai-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/kimai/kimai-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kimai/kimai-mobile/labels{/name}","releases_url":"https://api.github.com/repos/kimai/kimai-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/kimai/kimai-mobile/deployments","created_at":"2011-12-14T21:23:13Z","updated_at":"2016-05-25T13:54:15Z","pushed_at":"2016-07-26T06:39:33Z","git_url":"git://github.com/kimai/kimai-mobile.git","ssh_url":"git@github.com:kimai/kimai-mobile.git","clone_url":"https://github.com/kimai/kimai-mobile.git","svn_url":"https://github.com/kimai/kimai-mobile","homepage":"","size":112,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":6,"forks":25,"open_issues":6,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kimai/kimai-mobile/pulls/17"},"html":{"href":"https://github.com/kimai/kimai-mobile/pull/17"},"issue":{"href":"https://api.github.com/repos/kimai/kimai-mobile/issues/17"},"comments":{"href":"https://api.github.com/repos/kimai/kimai-mobile/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/kimai/kimai-mobile/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/kimai/kimai-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kimai/kimai-mobile/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/kimai/kimai-mobile/statuses/c97c4278f5ad95ee739d26df48e3fe57be0ff94c"}}}}
{"actor":{"display_login":"kevinpapst"}}