{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/81590780","pull_request_review_id":2559704,"id":81590780,"diff_hunk":"@@ -76,11 +76,19 @@ void set_default_settings(Settings *settings)\n \tsettings->setDefault(\"tooltip_show_delay\", \"400\");\n \n \t// Some (temporary) keys for debugging\n+\t#ifdef NDEBUG","path":"src/defaultsettings.cpp","position":4,"original_position":4,"commit_id":"03cc42ddadcdf910eee2e197143c42cd94538750","original_commit_id":"03cc42ddadcdf910eee2e197143c42cd94538750","user":{"login":"rubenwardy","id":2122943,"avatar_url":"https://avatars.githubusercontent.com/u/2122943?v=3","gravatar_id":"","url":"https://api.github.com/users/rubenwardy","html_url":"https://github.com/rubenwardy","followers_url":"https://api.github.com/users/rubenwardy/followers","following_url":"https://api.github.com/users/rubenwardy/following{/other_user}","gists_url":"https://api.github.com/users/rubenwardy/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenwardy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenwardy/subscriptions","organizations_url":"https://api.github.com/users/rubenwardy/orgs","repos_url":"https://api.github.com/users/rubenwardy/repos","events_url":"https://api.github.com/users/rubenwardy/events{/privacy}","received_events_url":"https://api.github.com/users/rubenwardy/received_events","type":"User","site_admin":false},"body":"Look at the block above here ","created_at":"2016-10-03T16:49:53Z","updated_at":"2016-10-03T16:49:54Z","html_url":"https://github.com/minetest/minetest/pull/3896#discussion_r81590780","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/3896","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/81590780"},"html":{"href":"https://github.com/minetest/minetest/pull/3896#discussion_r81590780"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3896"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/3896","id":63564690,"html_url":"https://github.com/minetest/minetest/pull/3896","diff_url":"https://github.com/minetest/minetest/pull/3896.diff","patch_url":"https://github.com/minetest/minetest/pull/3896.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/3896","number":3896,"state":"open","locked":false,"title":"Improve the key change menu and set a few keybindings to be debug only.","user":{"login":"red-001","id":12450071,"avatar_url":"https://avatars.githubusercontent.com/u/12450071?v=3","gravatar_id":"","url":"https://api.github.com/users/red-001","html_url":"https://github.com/red-001","followers_url":"https://api.github.com/users/red-001/followers","following_url":"https://api.github.com/users/red-001/following{/other_user}","gists_url":"https://api.github.com/users/red-001/gists{/gist_id}","starred_url":"https://api.github.com/users/red-001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/red-001/subscriptions","organizations_url":"https://api.github.com/users/red-001/orgs","repos_url":"https://api.github.com/users/red-001/repos","events_url":"https://api.github.com/users/red-001/events{/privacy}","received_events_url":"https://api.github.com/users/red-001/received_events","type":"User","site_admin":false},"body":"See #3846. This also partially fixes #3847. \r\n\r\nI have added more keys to the key change menu, fixed a bug that stop the  keybinding for `forwards` from being changed if the warning about a key already being in use was visible and added a warning if the user tried to assign the `escape` to a keybinding. I set some keybindings to only have a key set to them by default in debug builds.\r\n![menu](https://cloud.githubusercontent.com/assets/12450071/13950943/d86e5714-f025-11e5-80c9-3aa7d49523d3.png)\r\n","created_at":"2016-03-21T13:39:01Z","updated_at":"2016-10-03T16:49:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8acdb0f32f21d83fa92ff7804a0a4eff06dc6121","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/3896/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/3896/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/3896/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/03cc42ddadcdf910eee2e197143c42cd94538750","head":{"label":"red-001:more_control_conf","ref":"more_control_conf","sha":"03cc42ddadcdf910eee2e197143c42cd94538750","user":{"login":"red-001","id":12450071,"avatar_url":"https://avatars.githubusercontent.com/u/12450071?v=3","gravatar_id":"","url":"https://api.github.com/users/red-001","html_url":"https://github.com/red-001","followers_url":"https://api.github.com/users/red-001/followers","following_url":"https://api.github.com/users/red-001/following{/other_user}","gists_url":"https://api.github.com/users/red-001/gists{/gist_id}","starred_url":"https://api.github.com/users/red-001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/red-001/subscriptions","organizations_url":"https://api.github.com/users/red-001/orgs","repos_url":"https://api.github.com/users/red-001/repos","events_url":"https://api.github.com/users/red-001/events{/privacy}","received_events_url":"https://api.github.com/users/red-001/received_events","type":"User","site_admin":false},"repo":{"id":39887838,"name":"minetest","full_name":"red-001/minetest","owner":{"login":"red-001","id":12450071,"avatar_url":"https://avatars.githubusercontent.com/u/12450071?v=3","gravatar_id":"","url":"https://api.github.com/users/red-001","html_url":"https://github.com/red-001","followers_url":"https://api.github.com/users/red-001/followers","following_url":"https://api.github.com/users/red-001/following{/other_user}","gists_url":"https://api.github.com/users/red-001/gists{/gist_id}","starred_url":"https://api.github.com/users/red-001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/red-001/subscriptions","organizations_url":"https://api.github.com/users/red-001/orgs","repos_url":"https://api.github.com/users/red-001/repos","events_url":"https://api.github.com/users/red-001/events{/privacy}","received_events_url":"https://api.github.com/users/red-001/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/red-001/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/red-001/minetest","forks_url":"https://api.github.com/repos/red-001/minetest/forks","keys_url":"https://api.github.com/repos/red-001/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/red-001/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/red-001/minetest/teams","hooks_url":"https://api.github.com/repos/red-001/minetest/hooks","issue_events_url":"https://api.github.com/repos/red-001/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/red-001/minetest/events","assignees_url":"https://api.github.com/repos/red-001/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/red-001/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/red-001/minetest/tags","blobs_url":"https://api.github.com/repos/red-001/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/red-001/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/red-001/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/red-001/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/red-001/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/red-001/minetest/languages","stargazers_url":"https://api.github.com/repos/red-001/minetest/stargazers","contributors_url":"https://api.github.com/repos/red-001/minetest/contributors","subscribers_url":"https://api.github.com/repos/red-001/minetest/subscribers","subscription_url":"https://api.github.com/repos/red-001/minetest/subscription","commits_url":"https://api.github.com/repos/red-001/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/red-001/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/red-001/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/red-001/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/red-001/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/red-001/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/red-001/minetest/merges","archive_url":"https://api.github.com/repos/red-001/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/red-001/minetest/downloads","issues_url":"https://api.github.com/repos/red-001/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/red-001/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/red-001/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/red-001/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/red-001/minetest/labels{/name}","releases_url":"https://api.github.com/repos/red-001/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/red-001/minetest/deployments","created_at":"2015-07-29T10:32:29Z","updated_at":"2016-03-05T16:02:48Z","pushed_at":"2016-09-29T13:43:15Z","git_url":"git://github.com/red-001/minetest.git","ssh_url":"git@github.com:red-001/minetest.git","clone_url":"https://github.com/red-001/minetest.git","svn_url":"https://github.com/red-001/minetest","homepage":"http://minetest.net/","size":42798,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"33a606c034a6dfea4a011b6d69077455bbb56746","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/minetest/minetest/deployments","created_at":"2011-08-07T13:48:36Z","updated_at":"2016-10-03T16:10:55Z","pushed_at":"2016-10-03T16:35:30Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":116943,"stargazers_count":2171,"watchers_count":2171,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":677,"mirror_url":null,"open_issues_count":876,"forks":677,"open_issues":876,"watchers":2171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3896"},"html":{"href":"https://github.com/minetest/minetest/pull/3896"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/3896"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/3896/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3896/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3896/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/03cc42ddadcdf910eee2e197143c42cd94538750"}}}}
{"actor":{"display_login":"rubenwardy"}}