{"action":"created","comment":{"url":"https://api.github.com/repos/sunpy/sunpy/pulls/comments/64152907","id":64152907,"diff_hunk":"@@ -58,18 +58,22 @@ def _get_url_for_timerange(self, timerange, **kwargs):\n             Data type to return for the particular GOES satellite. Supported\n             types depend on the satellite number specified. (default = xrs_2s)\n         \"\"\"\n-\n         # find out which satellite and datatype to query from the query times\n         sat_num = self._get_goes_sat_num(timerange.start, timerange.end)\n         base_url = 'http://umbra.nascom.nasa.gov/goes/fits/'\n-\n-        if timerange.start < parse_time('1999/01/15'):\n-            url = base_url + \"{date:%Y}/go{sat:02d}{date:%y%m%d}.fits\".format(\n-                date=timerange.start, sat=sat_num[0])\n-        else:\n-            url = base_url + \"{date:%Y}/go{sat:02d}{date:%Y%m%d}.fits\".format(\n-                date=timerange.start, sat=sat_num[0])\n-        return [url]\n+        total_days = (timerange.end - timerange.start).days + 1 \n+        all_dates = timerange.split(total_days)\n+        result = list()\n+        for day in all_dates:\n+            regex = \"{date:%Y}/go{sat:02d}\"\n+            if (day.end < parse_time('1999/01/15')):\n+                regex += \"{date:%y%m%d}.fits\"\n+            else:\n+                regex += \"{date:%Y%m%d}.fits\"\n+            url = base_url + regex.format(\n+                    date=day.end, sat=self._get_goes_sat_num(day.end, day.end)[0])","path":"sunpy/net/dataretriever/sources/goes.py","position":32,"original_position":26,"commit_id":"be2add59596b63f0e7e5a755180a41c5c1a27591","original_commit_id":"da5f46c450a3b84a6c1d2090eb7e73da9d4a1750","user":{"login":"dpshelio","id":963242,"avatar_url":"https://avatars.githubusercontent.com/u/963242?v=3","gravatar_id":"","url":"https://api.github.com/users/dpshelio","html_url":"https://github.com/dpshelio","followers_url":"https://api.github.com/users/dpshelio/followers","following_url":"https://api.github.com/users/dpshelio/following{/other_user}","gists_url":"https://api.github.com/users/dpshelio/gists{/gist_id}","starred_url":"https://api.github.com/users/dpshelio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpshelio/subscriptions","organizations_url":"https://api.github.com/users/dpshelio/orgs","repos_url":"https://api.github.com/users/dpshelio/repos","events_url":"https://api.github.com/users/dpshelio/events{/privacy}","received_events_url":"https://api.github.com/users/dpshelio/received_events","type":"User","site_admin":false},"body":"Please, add a test checking the change of satellite. Such some files belongs to satellite X and  others to satellite Y.","created_at":"2016-05-22T17:00:46Z","updated_at":"2016-05-22T17:00:46Z","html_url":"https://github.com/sunpy/sunpy/pull/1747#discussion_r64152907","pull_request_url":"https://api.github.com/repos/sunpy/sunpy/pulls/1747","_links":{"self":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/comments/64152907"},"html":{"href":"https://github.com/sunpy/sunpy/pull/1747#discussion_r64152907"},"pull_request":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/1747"}}},"pull_request":{"url":"https://api.github.com/repos/sunpy/sunpy/pulls/1747","id":67700985,"html_url":"https://github.com/sunpy/sunpy/pull/1747","diff_url":"https://github.com/sunpy/sunpy/pull/1747.diff","patch_url":"https://github.com/sunpy/sunpy/pull/1747.patch","issue_url":"https://api.github.com/repos/sunpy/sunpy/issues/1747","number":1747,"state":"open","locked":false,"title":"[unidown]Fixes test_goes_ud.py test. Modifies logic in GOESClient.","user":{"login":"sudk1896","id":6025419,"avatar_url":"https://avatars.githubusercontent.com/u/6025419?v=3","gravatar_id":"","url":"https://api.github.com/users/sudk1896","html_url":"https://github.com/sudk1896","followers_url":"https://api.github.com/users/sudk1896/followers","following_url":"https://api.github.com/users/sudk1896/following{/other_user}","gists_url":"https://api.github.com/users/sudk1896/gists{/gist_id}","starred_url":"https://api.github.com/users/sudk1896/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudk1896/subscriptions","organizations_url":"https://api.github.com/users/sudk1896/orgs","repos_url":"https://api.github.com/users/sudk1896/repos","events_url":"https://api.github.com/users/sudk1896/events{/privacy}","received_events_url":"https://api.github.com/users/sudk1896/received_events","type":"User","site_admin":false},"body":"This is formally my 1st PR for Google Summer of Code. It fixes a (possible) error in GOESClient and I have also fixed the corresponding test for it.\r\nThis is also referenced by #1626 , @Cadair please close that PR.\r\n@dpshelio @Cadair and any other SunPy developers please review so we can merge unidown into master.\r\nNote: This would need to have a fair amount of discussion too, I am modifying the downloading\r\n```\r\n_get_url_for_timerange\r\n``` \r\nlogic in goes.py . Kindly look at #1692 for a detailed discussion on this issue.","created_at":"2016-04-25T11:02:27Z","updated_at":"2016-05-22T17:00:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"762f3749862fd2a51defc9ad6ab140e69af29f0d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sunpy/sunpy/pulls/1747/commits","review_comments_url":"https://api.github.com/repos/sunpy/sunpy/pulls/1747/comments","review_comment_url":"https://api.github.com/repos/sunpy/sunpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sunpy/sunpy/issues/1747/comments","statuses_url":"https://api.github.com/repos/sunpy/sunpy/statuses/be2add59596b63f0e7e5a755180a41c5c1a27591","head":{"label":"sudk1896:goesfix","ref":"goesfix","sha":"be2add59596b63f0e7e5a755180a41c5c1a27591","user":{"login":"sudk1896","id":6025419,"avatar_url":"https://avatars.githubusercontent.com/u/6025419?v=3","gravatar_id":"","url":"https://api.github.com/users/sudk1896","html_url":"https://github.com/sudk1896","followers_url":"https://api.github.com/users/sudk1896/followers","following_url":"https://api.github.com/users/sudk1896/following{/other_user}","gists_url":"https://api.github.com/users/sudk1896/gists{/gist_id}","starred_url":"https://api.github.com/users/sudk1896/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudk1896/subscriptions","organizations_url":"https://api.github.com/users/sudk1896/orgs","repos_url":"https://api.github.com/users/sudk1896/repos","events_url":"https://api.github.com/users/sudk1896/events{/privacy}","received_events_url":"https://api.github.com/users/sudk1896/received_events","type":"User","site_admin":false},"repo":{"id":44807807,"name":"sunpy","full_name":"sudk1896/sunpy","owner":{"login":"sudk1896","id":6025419,"avatar_url":"https://avatars.githubusercontent.com/u/6025419?v=3","gravatar_id":"","url":"https://api.github.com/users/sudk1896","html_url":"https://github.com/sudk1896","followers_url":"https://api.github.com/users/sudk1896/followers","following_url":"https://api.github.com/users/sudk1896/following{/other_user}","gists_url":"https://api.github.com/users/sudk1896/gists{/gist_id}","starred_url":"https://api.github.com/users/sudk1896/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudk1896/subscriptions","organizations_url":"https://api.github.com/users/sudk1896/orgs","repos_url":"https://api.github.com/users/sudk1896/repos","events_url":"https://api.github.com/users/sudk1896/events{/privacy}","received_events_url":"https://api.github.com/users/sudk1896/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sudk1896/sunpy","description":"SunPy - Python for solar physics","fork":true,"url":"https://api.github.com/repos/sudk1896/sunpy","forks_url":"https://api.github.com/repos/sudk1896/sunpy/forks","keys_url":"https://api.github.com/repos/sudk1896/sunpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sudk1896/sunpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sudk1896/sunpy/teams","hooks_url":"https://api.github.com/repos/sudk1896/sunpy/hooks","issue_events_url":"https://api.github.com/repos/sudk1896/sunpy/issues/events{/number}","events_url":"https://api.github.com/repos/sudk1896/sunpy/events","assignees_url":"https://api.github.com/repos/sudk1896/sunpy/assignees{/user}","branches_url":"https://api.github.com/repos/sudk1896/sunpy/branches{/branch}","tags_url":"https://api.github.com/repos/sudk1896/sunpy/tags","blobs_url":"https://api.github.com/repos/sudk1896/sunpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sudk1896/sunpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sudk1896/sunpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sudk1896/sunpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sudk1896/sunpy/statuses/{sha}","languages_url":"https://api.github.com/repos/sudk1896/sunpy/languages","stargazers_url":"https://api.github.com/repos/sudk1896/sunpy/stargazers","contributors_url":"https://api.github.com/repos/sudk1896/sunpy/contributors","subscribers_url":"https://api.github.com/repos/sudk1896/sunpy/subscribers","subscription_url":"https://api.github.com/repos/sudk1896/sunpy/subscription","commits_url":"https://api.github.com/repos/sudk1896/sunpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sudk1896/sunpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sudk1896/sunpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sudk1896/sunpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sudk1896/sunpy/contents/{+path}","compare_url":"https://api.github.com/repos/sudk1896/sunpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sudk1896/sunpy/merges","archive_url":"https://api.github.com/repos/sudk1896/sunpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sudk1896/sunpy/downloads","issues_url":"https://api.github.com/repos/sudk1896/sunpy/issues{/number}","pulls_url":"https://api.github.com/repos/sudk1896/sunpy/pulls{/number}","milestones_url":"https://api.github.com/repos/sudk1896/sunpy/milestones{/number}","notifications_url":"https://api.github.com/repos/sudk1896/sunpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sudk1896/sunpy/labels{/name}","releases_url":"https://api.github.com/repos/sudk1896/sunpy/releases{/id}","deployments_url":"https://api.github.com/repos/sudk1896/sunpy/deployments","created_at":"2015-10-23T11:00:28Z","updated_at":"2016-03-02T14:59:27Z","pushed_at":"2016-05-18T18:28:21Z","git_url":"git://github.com/sudk1896/sunpy.git","ssh_url":"git@github.com:sudk1896/sunpy.git","clone_url":"https://github.com/sudk1896/sunpy.git","svn_url":"https://github.com/sudk1896/sunpy","homepage":"http://www.sunpy.org","size":37616,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sunpy:unidown","ref":"unidown","sha":"49e55ae721494faed73b7c41b5e8a29709c212ee","user":{"login":"sunpy","id":963197,"avatar_url":"https://avatars.githubusercontent.com/u/963197?v=3","gravatar_id":"","url":"https://api.github.com/users/sunpy","html_url":"https://github.com/sunpy","followers_url":"https://api.github.com/users/sunpy/followers","following_url":"https://api.github.com/users/sunpy/following{/other_user}","gists_url":"https://api.github.com/users/sunpy/gists{/gist_id}","starred_url":"https://api.github.com/users/sunpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunpy/subscriptions","organizations_url":"https://api.github.com/users/sunpy/orgs","repos_url":"https://api.github.com/users/sunpy/repos","events_url":"https://api.github.com/users/sunpy/events{/privacy}","received_events_url":"https://api.github.com/users/sunpy/received_events","type":"Organization","site_admin":false},"repo":{"id":2165383,"name":"sunpy","full_name":"sunpy/sunpy","owner":{"login":"sunpy","id":963197,"avatar_url":"https://avatars.githubusercontent.com/u/963197?v=3","gravatar_id":"","url":"https://api.github.com/users/sunpy","html_url":"https://github.com/sunpy","followers_url":"https://api.github.com/users/sunpy/followers","following_url":"https://api.github.com/users/sunpy/following{/other_user}","gists_url":"https://api.github.com/users/sunpy/gists{/gist_id}","starred_url":"https://api.github.com/users/sunpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunpy/subscriptions","organizations_url":"https://api.github.com/users/sunpy/orgs","repos_url":"https://api.github.com/users/sunpy/repos","events_url":"https://api.github.com/users/sunpy/events{/privacy}","received_events_url":"https://api.github.com/users/sunpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sunpy/sunpy","description":"SunPy - Python for Solar Physics","fork":false,"url":"https://api.github.com/repos/sunpy/sunpy","forks_url":"https://api.github.com/repos/sunpy/sunpy/forks","keys_url":"https://api.github.com/repos/sunpy/sunpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sunpy/sunpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sunpy/sunpy/teams","hooks_url":"https://api.github.com/repos/sunpy/sunpy/hooks","issue_events_url":"https://api.github.com/repos/sunpy/sunpy/issues/events{/number}","events_url":"https://api.github.com/repos/sunpy/sunpy/events","assignees_url":"https://api.github.com/repos/sunpy/sunpy/assignees{/user}","branches_url":"https://api.github.com/repos/sunpy/sunpy/branches{/branch}","tags_url":"https://api.github.com/repos/sunpy/sunpy/tags","blobs_url":"https://api.github.com/repos/sunpy/sunpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sunpy/sunpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sunpy/sunpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sunpy/sunpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sunpy/sunpy/statuses/{sha}","languages_url":"https://api.github.com/repos/sunpy/sunpy/languages","stargazers_url":"https://api.github.com/repos/sunpy/sunpy/stargazers","contributors_url":"https://api.github.com/repos/sunpy/sunpy/contributors","subscribers_url":"https://api.github.com/repos/sunpy/sunpy/subscribers","subscription_url":"https://api.github.com/repos/sunpy/sunpy/subscription","commits_url":"https://api.github.com/repos/sunpy/sunpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sunpy/sunpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sunpy/sunpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sunpy/sunpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sunpy/sunpy/contents/{+path}","compare_url":"https://api.github.com/repos/sunpy/sunpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sunpy/sunpy/merges","archive_url":"https://api.github.com/repos/sunpy/sunpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sunpy/sunpy/downloads","issues_url":"https://api.github.com/repos/sunpy/sunpy/issues{/number}","pulls_url":"https://api.github.com/repos/sunpy/sunpy/pulls{/number}","milestones_url":"https://api.github.com/repos/sunpy/sunpy/milestones{/number}","notifications_url":"https://api.github.com/repos/sunpy/sunpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sunpy/sunpy/labels{/name}","releases_url":"https://api.github.com/repos/sunpy/sunpy/releases{/id}","deployments_url":"https://api.github.com/repos/sunpy/sunpy/deployments","created_at":"2011-08-06T15:34:08Z","updated_at":"2016-05-01T13:57:41Z","pushed_at":"2016-05-20T16:40:28Z","git_url":"git://github.com/sunpy/sunpy.git","ssh_url":"git@github.com:sunpy/sunpy.git","clone_url":"https://github.com/sunpy/sunpy.git","svn_url":"https://github.com/sunpy/sunpy","homepage":"http://www.sunpy.org","size":141887,"stargazers_count":225,"watchers_count":225,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":156,"mirror_url":null,"open_issues_count":252,"forks":156,"open_issues":252,"watchers":225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/1747"},"html":{"href":"https://github.com/sunpy/sunpy/pull/1747"},"issue":{"href":"https://api.github.com/repos/sunpy/sunpy/issues/1747"},"comments":{"href":"https://api.github.com/repos/sunpy/sunpy/issues/1747/comments"},"review_comments":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/1747/comments"},"review_comment":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/1747/commits"},"statuses":{"href":"https://api.github.com/repos/sunpy/sunpy/statuses/be2add59596b63f0e7e5a755180a41c5c1a27591"}}}}
{"actor":{"display_login":"dpshelio"}}