{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8671","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8671/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8671/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8671/events","html_url":"https://github.com/bitcoin/bitcoin/pull/8671","id":175345744,"number":8671,"title":"Minimal fix to slow prevector tests as stopgap measure","user":{"login":"JeremyRubin","id":886523,"avatar_url":"https://avatars.githubusercontent.com/u/886523?v=3","gravatar_id":"","url":"https://api.github.com/users/JeremyRubin","html_url":"https://github.com/JeremyRubin","followers_url":"https://api.github.com/users/JeremyRubin/followers","following_url":"https://api.github.com/users/JeremyRubin/following{/other_user}","gists_url":"https://api.github.com/users/JeremyRubin/gists{/gist_id}","starred_url":"https://api.github.com/users/JeremyRubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeremyRubin/subscriptions","organizations_url":"https://api.github.com/users/JeremyRubin/orgs","repos_url":"https://api.github.com/users/JeremyRubin/repos","events_url":"https://api.github.com/users/JeremyRubin/events{/privacy}","received_events_url":"https://api.github.com/users/JeremyRubin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Tests","name":"Tests","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-09-06T20:38:18Z","updated_at":"2016-09-07T18:32:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8671","html_url":"https://github.com/bitcoin/bitcoin/pull/8671","diff_url":"https://github.com/bitcoin/bitcoin/pull/8671.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/8671.patch"},"body":"Tests are really slow because of BOOST_CHECK doing a lot of unnecessary things in wine, BOOST_CHECK can't just be ripped out because some people rely on certain features for there dev process.\r\n\r\nIn lieu of a more permanent fix, this PR minimally modifies PrevectorTests to use a local check. To make sure this local check isn't useless, it gets the seeds from the insecure random to allow tests to be repeated.\r\n\r\nThis should be an easy to merge PR; discussion about generally improving the unit test performance/framework beyond this can go here: https://github.com/bitcoin/bitcoin/issues/8670"},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/245374713","html_url":"https://github.com/bitcoin/bitcoin/pull/8671#issuecomment-245374713","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8671","id":245374713,"user":{"login":"MarcoFalke","id":6399679,"avatar_url":"https://avatars.githubusercontent.com/u/6399679?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"created_at":"2016-09-07T18:32:10Z","updated_at":"2016-09-07T18:32:10Z","body":"Thanks! utACK f71d4a3786611d564e4c239099501daee989b170"}}
{"actor":{"display_login":"MarcoFalke"}}