{"action":"created","issue":{"url":"https://api.github.com/repos/electron-userland/electron-packager/issues/387","repository_url":"https://api.github.com/repos/electron-userland/electron-packager","labels_url":"https://api.github.com/repos/electron-userland/electron-packager/issues/387/labels{/name}","comments_url":"https://api.github.com/repos/electron-userland/electron-packager/issues/387/comments","events_url":"https://api.github.com/repos/electron-userland/electron-packager/issues/387/events","html_url":"https://github.com/electron-userland/electron-packager/issues/387","id":157917547,"number":387,"title":"OS X extend-info not respected","user":{"login":"JimiC","id":1716442,"avatar_url":"https://avatars.githubusercontent.com/u/1716442?v=3","gravatar_id":"","url":"https://api.github.com/users/JimiC","html_url":"https://github.com/JimiC","followers_url":"https://api.github.com/users/JimiC/followers","following_url":"https://api.github.com/users/JimiC/following{/other_user}","gists_url":"https://api.github.com/users/JimiC/gists{/gist_id}","starred_url":"https://api.github.com/users/JimiC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimiC/subscriptions","organizations_url":"https://api.github.com/users/JimiC/orgs","repos_url":"https://api.github.com/users/JimiC/repos","events_url":"https://api.github.com/users/JimiC/events{/privacy}","received_events_url":"https://api.github.com/users/JimiC/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/electron-userland/electron-packager/labels/needs%20info","name":"needs info","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-06-01T14:14:24Z","updated_at":"2016-06-02T15:56:51Z","closed_at":null,"body":"When creating a package for OS X and 'extend-info' file is provided, which contains info that the user wants to override (i.e. CFBundleDisplayName), the packager doesn't respect them. \r\n\r\nelectron-packager version: 7.0.2\r\nElectron version: 1.2.0\r\nOS: OS X 10.11.5 (64bit)\r\nTarget Platform: darwin/x64\r\nOptions:\r\n\r\n    {\r\n\tappVersion: packageJson.version,\r\n\tdir: paths.src + paths.app,\r\n\tplatform: process.platform,\r\n\tarch: ['x64'],\r\n\tname: packageJson.name,\r\n\t//version: packageJson.devDependencies['electron-prebuilt'],\r\n\tdownload: { cache: './cache' },\r\n\tignore: '.+map',\r\n\tout: paths.out,\r\n\ticon: 'resources/' + process.platform + '/icon',\r\n\tasar: true,\r\n\toverwrite: true,\r\n\t'app-version': packageJson.version,\r\n\t'app-copyright': packageJson.copyright,\r\n\t'build-version': packageJson.version,\r\n\t'version-string': {\r\n\t\tCompanyName: packageJson.author.name,\r\n\t\tFileDescription: packageJson.name,\r\n\t\tProductName: packageJson.productName,\r\n\t\tOriginalFilename: packageJson.name + '.exe'\r\n\t},\r\n\t'extend-info': 'resources/' + process.platform + '/product.plist'\r\n    }"},"comment":{"url":"https://api.github.com/repos/electron-userland/electron-packager/issues/comments/223336764","html_url":"https://github.com/electron-userland/electron-packager/issues/387#issuecomment-223336764","issue_url":"https://api.github.com/repos/electron-userland/electron-packager/issues/387","id":223336764,"user":{"login":"JimiC","id":1716442,"avatar_url":"https://avatars.githubusercontent.com/u/1716442?v=3","gravatar_id":"","url":"https://api.github.com/users/JimiC","html_url":"https://github.com/JimiC","followers_url":"https://api.github.com/users/JimiC/followers","following_url":"https://api.github.com/users/JimiC/following{/other_user}","gists_url":"https://api.github.com/users/JimiC/gists{/gist_id}","starred_url":"https://api.github.com/users/JimiC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimiC/subscriptions","organizations_url":"https://api.github.com/users/JimiC/orgs","repos_url":"https://api.github.com/users/JimiC/repos","events_url":"https://api.github.com/users/JimiC/events{/privacy}","received_events_url":"https://api.github.com/users/JimiC/received_events","type":"User","site_admin":false},"created_at":"2016-06-02T15:56:51Z","updated_at":"2016-06-02T15:56:51Z","body":"@malept \r\n\r\nAs you can see in the OP in `package.json` I declare `name` and `productName` (which is used in declaring `version-string.ProductName`)\r\nIf I omit the `name` then `productName` gets used but it messes up the containing folder naming, and my O.C.D. doesn't allow that. Just because Apple likes to deviate from what most do, doesn't mean we have to settle for that. (Not saying that Apple does it wrong, I'm saying it does it differently). \r\n\r\n>  Perhaps what you want is a more robust version of specifying productName.\r\n\r\nIn my case `productName` is what I want to use for `CFBundleName`.\r\nI'll try to provide a PR and test it out, in order to meet everyone's liking.\r\n\r\nAre you OK if I use the `version-string` and add OS specific options?\r\nSomething like:\r\n```\r\n 'version-string': {\r\n    win32: {\r\n        CompanyName: packageJson.author.name,\r\n        FileDescription: packageJson.name,\r\n        ProductName: packageJson.productName,\r\n        OriginalFilename: packageJson.name + '.exe'\r\n    },\r\n    darwin: {\r\n        CFBundleName: packageJson.productName\r\n    }\r\n}\r\n```\r\nIn this case if the user doesn't specify the `CFBundleName` the `name` will be used.\r\nThis structure allows future usage of other attributes. \r\nHow does that sounds like?"}}
{"actor":{"display_login":"JimiC"}}