{"action":"opened","number":59,"pull_request":{"url":"https://api.github.com/repos/toretore/barby/pulls/59","id":60213177,"html_url":"https://github.com/toretore/barby/pull/59","diff_url":"https://github.com/toretore/barby/pull/59.diff","patch_url":"https://github.com/toretore/barby/pull/59.patch","issue_url":"https://api.github.com/repos/toretore/barby/issues/59","number":59,"state":"open","locked":false,"title":"Fixes GS1-128 barcodes without type given","user":{"login":"sfroehler","id":1552727,"avatar_url":"https://avatars.githubusercontent.com/u/1552727?v=3","gravatar_id":"","url":"https://api.github.com/users/sfroehler","html_url":"https://github.com/sfroehler","followers_url":"https://api.github.com/users/sfroehler/followers","following_url":"https://api.github.com/users/sfroehler/following{/other_user}","gists_url":"https://api.github.com/users/sfroehler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfroehler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfroehler/subscriptions","organizations_url":"https://api.github.com/users/sfroehler/orgs","repos_url":"https://api.github.com/users/sfroehler/repos","events_url":"https://api.github.com/users/sfroehler/events{/privacy}","received_events_url":"https://api.github.com/users/sfroehler/received_events","type":"User","site_admin":false},"body":"Fixes the the GS1-128 barcode generate for the case when no type is given:\r\n\r\nDue to the fact, that the ```GS1128#initialize``` method was not giving\r\nthe correct data to the initialize and that the overwritten\r\n```GS1128#data``` returned a different string then what was given in the\r\n```initialize``` method, the ```valid?``` method returned false.\r\n\r\nThis commit adjusts the initializer so it builds the correct data string\r\n(including the ```FNC1``` symbol at the application identifier)\r\nand removes the data method from the GS1128 class.","created_at":"2016-02-22T17:53:10Z","updated_at":"2016-02-22T17:53:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/toretore/barby/pulls/59/commits","review_comments_url":"https://api.github.com/repos/toretore/barby/pulls/59/comments","review_comment_url":"https://api.github.com/repos/toretore/barby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/toretore/barby/issues/59/comments","statuses_url":"https://api.github.com/repos/toretore/barby/statuses/6d8a7a269f33ab0eed03c03c67ca353c41fd59cb","head":{"label":"shipcloud:sf-fix-gs1-code128-initializer","ref":"sf-fix-gs1-code128-initializer","sha":"6d8a7a269f33ab0eed03c03c67ca353c41fd59cb","user":{"login":"shipcloud","id":4550749,"avatar_url":"https://avatars.githubusercontent.com/u/4550749?v=3","gravatar_id":"","url":"https://api.github.com/users/shipcloud","html_url":"https://github.com/shipcloud","followers_url":"https://api.github.com/users/shipcloud/followers","following_url":"https://api.github.com/users/shipcloud/following{/other_user}","gists_url":"https://api.github.com/users/shipcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/shipcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shipcloud/subscriptions","organizations_url":"https://api.github.com/users/shipcloud/orgs","repos_url":"https://api.github.com/users/shipcloud/repos","events_url":"https://api.github.com/users/shipcloud/events{/privacy}","received_events_url":"https://api.github.com/users/shipcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":52289187,"name":"barby","full_name":"shipcloud/barby","owner":{"login":"shipcloud","id":4550749,"avatar_url":"https://avatars.githubusercontent.com/u/4550749?v=3","gravatar_id":"","url":"https://api.github.com/users/shipcloud","html_url":"https://github.com/shipcloud","followers_url":"https://api.github.com/users/shipcloud/followers","following_url":"https://api.github.com/users/shipcloud/following{/other_user}","gists_url":"https://api.github.com/users/shipcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/shipcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shipcloud/subscriptions","organizations_url":"https://api.github.com/users/shipcloud/orgs","repos_url":"https://api.github.com/users/shipcloud/repos","events_url":"https://api.github.com/users/shipcloud/events{/privacy}","received_events_url":"https://api.github.com/users/shipcloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shipcloud/barby","description":"The Ruby barcode generator","fork":true,"url":"https://api.github.com/repos/shipcloud/barby","forks_url":"https://api.github.com/repos/shipcloud/barby/forks","keys_url":"https://api.github.com/repos/shipcloud/barby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shipcloud/barby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shipcloud/barby/teams","hooks_url":"https://api.github.com/repos/shipcloud/barby/hooks","issue_events_url":"https://api.github.com/repos/shipcloud/barby/issues/events{/number}","events_url":"https://api.github.com/repos/shipcloud/barby/events","assignees_url":"https://api.github.com/repos/shipcloud/barby/assignees{/user}","branches_url":"https://api.github.com/repos/shipcloud/barby/branches{/branch}","tags_url":"https://api.github.com/repos/shipcloud/barby/tags","blobs_url":"https://api.github.com/repos/shipcloud/barby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shipcloud/barby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shipcloud/barby/git/refs{/sha}","trees_url":"https://api.github.com/repos/shipcloud/barby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shipcloud/barby/statuses/{sha}","languages_url":"https://api.github.com/repos/shipcloud/barby/languages","stargazers_url":"https://api.github.com/repos/shipcloud/barby/stargazers","contributors_url":"https://api.github.com/repos/shipcloud/barby/contributors","subscribers_url":"https://api.github.com/repos/shipcloud/barby/subscribers","subscription_url":"https://api.github.com/repos/shipcloud/barby/subscription","commits_url":"https://api.github.com/repos/shipcloud/barby/commits{/sha}","git_commits_url":"https://api.github.com/repos/shipcloud/barby/git/commits{/sha}","comments_url":"https://api.github.com/repos/shipcloud/barby/comments{/number}","issue_comment_url":"https://api.github.com/repos/shipcloud/barby/issues/comments{/number}","contents_url":"https://api.github.com/repos/shipcloud/barby/contents/{+path}","compare_url":"https://api.github.com/repos/shipcloud/barby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shipcloud/barby/merges","archive_url":"https://api.github.com/repos/shipcloud/barby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shipcloud/barby/downloads","issues_url":"https://api.github.com/repos/shipcloud/barby/issues{/number}","pulls_url":"https://api.github.com/repos/shipcloud/barby/pulls{/number}","milestones_url":"https://api.github.com/repos/shipcloud/barby/milestones{/number}","notifications_url":"https://api.github.com/repos/shipcloud/barby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shipcloud/barby/labels{/name}","releases_url":"https://api.github.com/repos/shipcloud/barby/releases{/id}","deployments_url":"https://api.github.com/repos/shipcloud/barby/deployments","created_at":"2016-02-22T16:54:55Z","updated_at":"2016-02-22T16:54:55Z","pushed_at":"2016-02-22T17:52:17Z","git_url":"git://github.com/shipcloud/barby.git","ssh_url":"git@github.com:shipcloud/barby.git","clone_url":"https://github.com/shipcloud/barby.git","svn_url":"https://github.com/shipcloud/barby","homepage":"http://toretore.github.com/barby/","size":817,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"toretore:master","ref":"master","sha":"92c7b73e937f9f5eb804dee55deed39695c0da39","user":{"login":"toretore","id":251,"avatar_url":"https://avatars.githubusercontent.com/u/251?v=3","gravatar_id":"","url":"https://api.github.com/users/toretore","html_url":"https://github.com/toretore","followers_url":"https://api.github.com/users/toretore/followers","following_url":"https://api.github.com/users/toretore/following{/other_user}","gists_url":"https://api.github.com/users/toretore/gists{/gist_id}","starred_url":"https://api.github.com/users/toretore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toretore/subscriptions","organizations_url":"https://api.github.com/users/toretore/orgs","repos_url":"https://api.github.com/users/toretore/repos","events_url":"https://api.github.com/users/toretore/events{/privacy}","received_events_url":"https://api.github.com/users/toretore/received_events","type":"User","site_admin":false},"repo":{"id":662,"name":"barby","full_name":"toretore/barby","owner":{"login":"toretore","id":251,"avatar_url":"https://avatars.githubusercontent.com/u/251?v=3","gravatar_id":"","url":"https://api.github.com/users/toretore","html_url":"https://github.com/toretore","followers_url":"https://api.github.com/users/toretore/followers","following_url":"https://api.github.com/users/toretore/following{/other_user}","gists_url":"https://api.github.com/users/toretore/gists{/gist_id}","starred_url":"https://api.github.com/users/toretore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toretore/subscriptions","organizations_url":"https://api.github.com/users/toretore/orgs","repos_url":"https://api.github.com/users/toretore/repos","events_url":"https://api.github.com/users/toretore/events{/privacy}","received_events_url":"https://api.github.com/users/toretore/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toretore/barby","description":"The Ruby barcode generator","fork":false,"url":"https://api.github.com/repos/toretore/barby","forks_url":"https://api.github.com/repos/toretore/barby/forks","keys_url":"https://api.github.com/repos/toretore/barby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toretore/barby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toretore/barby/teams","hooks_url":"https://api.github.com/repos/toretore/barby/hooks","issue_events_url":"https://api.github.com/repos/toretore/barby/issues/events{/number}","events_url":"https://api.github.com/repos/toretore/barby/events","assignees_url":"https://api.github.com/repos/toretore/barby/assignees{/user}","branches_url":"https://api.github.com/repos/toretore/barby/branches{/branch}","tags_url":"https://api.github.com/repos/toretore/barby/tags","blobs_url":"https://api.github.com/repos/toretore/barby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toretore/barby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toretore/barby/git/refs{/sha}","trees_url":"https://api.github.com/repos/toretore/barby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toretore/barby/statuses/{sha}","languages_url":"https://api.github.com/repos/toretore/barby/languages","stargazers_url":"https://api.github.com/repos/toretore/barby/stargazers","contributors_url":"https://api.github.com/repos/toretore/barby/contributors","subscribers_url":"https://api.github.com/repos/toretore/barby/subscribers","subscription_url":"https://api.github.com/repos/toretore/barby/subscription","commits_url":"https://api.github.com/repos/toretore/barby/commits{/sha}","git_commits_url":"https://api.github.com/repos/toretore/barby/git/commits{/sha}","comments_url":"https://api.github.com/repos/toretore/barby/comments{/number}","issue_comment_url":"https://api.github.com/repos/toretore/barby/issues/comments{/number}","contents_url":"https://api.github.com/repos/toretore/barby/contents/{+path}","compare_url":"https://api.github.com/repos/toretore/barby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toretore/barby/merges","archive_url":"https://api.github.com/repos/toretore/barby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toretore/barby/downloads","issues_url":"https://api.github.com/repos/toretore/barby/issues{/number}","pulls_url":"https://api.github.com/repos/toretore/barby/pulls{/number}","milestones_url":"https://api.github.com/repos/toretore/barby/milestones{/number}","notifications_url":"https://api.github.com/repos/toretore/barby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toretore/barby/labels{/name}","releases_url":"https://api.github.com/repos/toretore/barby/releases{/id}","deployments_url":"https://api.github.com/repos/toretore/barby/deployments","created_at":"2008-02-17T13:40:24Z","updated_at":"2016-02-16T10:56:18Z","pushed_at":"2016-01-11T05:46:39Z","git_url":"git://github.com/toretore/barby.git","ssh_url":"git@github.com:toretore/barby.git","clone_url":"https://github.com/toretore/barby.git","svn_url":"https://github.com/toretore/barby","homepage":"http://toretore.github.com/barby/","size":1421,"stargazers_count":488,"watchers_count":488,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":100,"mirror_url":null,"open_issues_count":10,"forks":100,"open_issues":10,"watchers":488,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/toretore/barby/pulls/59"},"html":{"href":"https://github.com/toretore/barby/pull/59"},"issue":{"href":"https://api.github.com/repos/toretore/barby/issues/59"},"comments":{"href":"https://api.github.com/repos/toretore/barby/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/toretore/barby/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/toretore/barby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/toretore/barby/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/toretore/barby/statuses/6d8a7a269f33ab0eed03c03c67ca353c41fd59cb"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":43,"deletions":12,"changed_files":2}}