{"action":"created","issue":{"url":"https://api.github.com/repos/thoughtbot/rcm/issues/193","repository_url":"https://api.github.com/repos/thoughtbot/rcm","labels_url":"https://api.github.com/repos/thoughtbot/rcm/issues/193/labels{/name}","comments_url":"https://api.github.com/repos/thoughtbot/rcm/issues/193/comments","events_url":"https://api.github.com/repos/thoughtbot/rcm/issues/193/events","html_url":"https://github.com/thoughtbot/rcm/pull/193","id":197430000,"number":193,"title":"Handle spaces in dotfile name","user":{"login":"mike-burns","id":4550,"avatar_url":"https://avatars.githubusercontent.com/u/4550?v=3","gravatar_id":"","url":"https://api.github.com/users/mike-burns","html_url":"https://github.com/mike-burns","followers_url":"https://api.github.com/users/mike-burns/followers","following_url":"https://api.github.com/users/mike-burns/following{/other_user}","gists_url":"https://api.github.com/users/mike-burns/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-burns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-burns/subscriptions","organizations_url":"https://api.github.com/users/mike-burns/orgs","repos_url":"https://api.github.com/users/mike-burns/repos","events_url":"https://api.github.com/users/mike-burns/events{/privacy}","received_events_url":"https://api.github.com/users/mike-burns/received_events","type":"User","site_admin":false},"labels":[{"id":42596117,"url":"https://api.github.com/repos/thoughtbot/rcm/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-23T21:52:03Z","updated_at":"2016-12-23T22:51:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thoughtbot/rcm/pulls/193","html_url":"https://github.com/thoughtbot/rcm/pull/193","diff_url":"https://github.com/thoughtbot/rcm/pull/193.diff","patch_url":"https://github.com/thoughtbot/rcm/pull/193.patch"},"body":"Sooo ...\r\n\r\nIn mkrc, separate the list of files with newlines instead of spaces.\r\nChange the IFS when iterating to handle this.\r\n\r\nWe hand the file off to rcup, which encodes the file name by replacing\r\nspaces with the bell character (`\\a`).\r\n\r\nrcup then sends the file name off to lsrc, which decodes the bell back\r\ninto a space.\r\n\r\nShoutout to Sublime Text 3.\r\n\r\nCloses #135."},"comment":{"url":"https://api.github.com/repos/thoughtbot/rcm/issues/comments/269054062","html_url":"https://github.com/thoughtbot/rcm/pull/193#issuecomment-269054062","issue_url":"https://api.github.com/repos/thoughtbot/rcm/issues/193","id":269054062,"user":{"login":"bturrubiates","id":2322856,"avatar_url":"https://avatars.githubusercontent.com/u/2322856?v=3","gravatar_id":"","url":"https://api.github.com/users/bturrubiates","html_url":"https://github.com/bturrubiates","followers_url":"https://api.github.com/users/bturrubiates/followers","following_url":"https://api.github.com/users/bturrubiates/following{/other_user}","gists_url":"https://api.github.com/users/bturrubiates/gists{/gist_id}","starred_url":"https://api.github.com/users/bturrubiates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bturrubiates/subscriptions","organizations_url":"https://api.github.com/users/bturrubiates/orgs","repos_url":"https://api.github.com/users/bturrubiates/repos","events_url":"https://api.github.com/users/bturrubiates/events{/privacy}","received_events_url":"https://api.github.com/users/bturrubiates/received_events","type":"User","site_admin":false},"created_at":"2016-12-23T22:51:45Z","updated_at":"2016-12-23T22:51:45Z","body":"Also after these changes: \r\n\r\n```sh\r\n============================================================================\r\nTestsuite summary for rcm 1.3.0\r\n============================================================================\r\n# TOTAL: 36\r\n# PASS:  11\r\n# SKIP:  0\r\n# XFAIL: 0\r\n# FAIL:  25\r\n# XPASS: 0\r\n# ERROR: 0\r\n============================================================================\r\nSee ./test-suite.log\r\nPlease report to mburns@thoughtbot.com\r\n============================================================================\r\n```\r\n\r\nAfter the `tr` change: \r\n\r\n```sh\r\n============================================================================\r\nTestsuite summary for rcm 1.3.0\r\n============================================================================\r\n# TOTAL: 36\r\n# PASS:  36\r\n# SKIP:  0\r\n# XFAIL: 0\r\n# FAIL:  0\r\n# XPASS: 0\r\n# ERROR: 0\r\n============================================================================\r\n```\r\n\r\ndiff:\r\n```sh\r\ndiff --git a/share/rcm.sh.in b/share/rcm.sh.in\r\nindex 0246296..80e9e91 100644\r\n--- a/share/rcm.sh.in\r\n+++ b/share/rcm.sh.in\r\n@@ -152,13 +152,13 @@ DELIMITER=\"\\a\"\r\n encode() {\r\n   local file=\"$1\"\r\n\r\n-  echo \"$file\" | sed -e \"s/ /$DELIMITER/g\"\r\n+  echo \"$file\" | tr \" \" \"$DELIMITER\"\r\n }\r\n\r\n decode() {\r\n   local file=\"$1\"\r\n\r\n-  echo \"$file\" | sed -e \"s/$DELIMITER/ /g\"\r\n+  echo \"$file\" | tr \"$DELIMITER\" \" \"\r\n }\r\n\r\n : ${RCRC:=$HOME/.rcrc}\r\n```\r\n\r\n"}}
{"actor":{"display_login":"bturrubiates"}}