{"action":"created","issue":{"url":"https://api.github.com/repos/sympy/sympy/issues/11916","repository_url":"https://api.github.com/repos/sympy/sympy","labels_url":"https://api.github.com/repos/sympy/sympy/issues/11916/labels{/name}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/11916/comments","events_url":"https://api.github.com/repos/sympy/sympy/issues/11916/events","html_url":"https://github.com/sympy/sympy/pull/11916","id":194091152,"number":11916,"title":"Use Meijerg G-function methods for integrating sinc","user":{"login":"rohitrango","id":15312514,"avatar_url":"https://avatars.githubusercontent.com/u/15312514?v=3","gravatar_id":"","url":"https://api.github.com/users/rohitrango","html_url":"https://github.com/rohitrango","followers_url":"https://api.github.com/users/rohitrango/followers","following_url":"https://api.github.com/users/rohitrango/following{/other_user}","gists_url":"https://api.github.com/users/rohitrango/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitrango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitrango/subscriptions","organizations_url":"https://api.github.com/users/rohitrango/orgs","repos_url":"https://api.github.com/users/rohitrango/repos","events_url":"https://api.github.com/users/rohitrango/events{/privacy}","received_events_url":"https://api.github.com/users/rohitrango/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-07T16:07:07Z","updated_at":"2016-12-07T16:14:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/11916","html_url":"https://github.com/sympy/sympy/pull/11916","diff_url":"https://github.com/sympy/sympy/pull/11916.diff","patch_url":"https://github.com/sympy/sympy/pull/11916.patch"},"body":"Fixes #11856\r\n\r\nUses Meijerg G-function methods first for functions\r\nlike sinc(x) since this method finds the integral quicker.\r\n\r\nThis will not check using the G-functions if it is explicitly mentioned `meijerg=False`\r\nExamples-\r\n```\r\nIn [3]: sinc(t*x).integrate()\r\nOut[3]: \r\nSi(π⋅t)\r\n───────\r\n   π   \r\n```\r\nThe above example is quick since it uses the 'hack'. \r\n```\r\nIn [3]: nsinc(t).integrate(meijerg=False)\r\nOut[3]: \r\nSi(π⋅t)\r\n───────\r\n   π   \r\n```\r\nThe above example will NOT utilise the hack and will take a longer time to evaluate."},"comment":{"url":"https://api.github.com/repos/sympy/sympy/issues/comments/265491105","html_url":"https://github.com/sympy/sympy/pull/11916#issuecomment-265491105","issue_url":"https://api.github.com/repos/sympy/sympy/issues/11916","id":265491105,"user":{"login":"rohitrango","id":15312514,"avatar_url":"https://avatars.githubusercontent.com/u/15312514?v=3","gravatar_id":"","url":"https://api.github.com/users/rohitrango","html_url":"https://github.com/rohitrango","followers_url":"https://api.github.com/users/rohitrango/followers","following_url":"https://api.github.com/users/rohitrango/following{/other_user}","gists_url":"https://api.github.com/users/rohitrango/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitrango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitrango/subscriptions","organizations_url":"https://api.github.com/users/rohitrango/orgs","repos_url":"https://api.github.com/users/rohitrango/repos","events_url":"https://api.github.com/users/rohitrango/events{/privacy}","received_events_url":"https://api.github.com/users/rohitrango/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T16:14:00Z","updated_at":"2016-12-07T16:14:00Z","body":"One more optimization that can be done is to maintain a flag inside the `if isinstance(f,sinc) ...` clause and skip the same algorithm later if the flag is `True`. The reason I didn't do that is that I'm not sure whether the form of the function `g` helps in speeding up the G-method algorithm in any way. Plus, can I put some tests for this? \r\n@jksuom , your opinion ?"}}
{"actor":{"display_login":"rohitrango"}}