{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10588","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10588/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10588/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10588/events","html_url":"https://github.com/ManageIQ/manageiq/pull/10588","id":171913932,"number":10588,"title":"refactor validates_timeline to supports :timeline","user":{"login":"durandom","id":161888,"avatar_url":"https://avatars.githubusercontent.com/u/161888?v=3","gravatar_id":"","url":"https://api.github.com/users/durandom","html_url":"https://github.com/durandom","followers_url":"https://api.github.com/users/durandom/followers","following_url":"https://api.github.com/users/durandom/following{/other_user}","gists_url":"https://api.github.com/users/durandom/gists{/gist_id}","starred_url":"https://api.github.com/users/durandom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/durandom/subscriptions","organizations_url":"https://api.github.com/users/durandom/orgs","repos_url":"https://api.github.com/users/durandom/repos","events_url":"https://api.github.com/users/durandom/events{/privacy}","received_events_url":"https://api.github.com/users/durandom/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/darga/no","name":"darga/no","color":"555555"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/pluggable%20providers","name":"pluggable providers","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/refactoring","name":"refactoring","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"durandom","id":161888,"avatar_url":"https://avatars.githubusercontent.com/u/161888?v=3","gravatar_id":"","url":"https://api.github.com/users/durandom","html_url":"https://github.com/durandom","followers_url":"https://api.github.com/users/durandom/followers","following_url":"https://api.github.com/users/durandom/following{/other_user}","gists_url":"https://api.github.com/users/durandom/gists{/gist_id}","starred_url":"https://api.github.com/users/durandom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/durandom/subscriptions","organizations_url":"https://api.github.com/users/durandom/orgs","repos_url":"https://api.github.com/users/durandom/repos","events_url":"https://api.github.com/users/durandom/events{/privacy}","received_events_url":"https://api.github.com/users/durandom/received_events","type":"User","site_admin":false},"assignees":[{"login":"durandom","id":161888,"avatar_url":"https://avatars.githubusercontent.com/u/161888?v=3","gravatar_id":"","url":"https://api.github.com/users/durandom","html_url":"https://github.com/durandom","followers_url":"https://api.github.com/users/durandom/followers","following_url":"https://api.github.com/users/durandom/following{/other_user}","gists_url":"https://api.github.com/users/durandom/gists{/gist_id}","starred_url":"https://api.github.com/users/durandom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/durandom/subscriptions","organizations_url":"https://api.github.com/users/durandom/orgs","repos_url":"https://api.github.com/users/durandom/repos","events_url":"https://api.github.com/users/durandom/events{/privacy}","received_events_url":"https://api.github.com/users/durandom/received_events","type":"User","site_admin":false}],"milestone":null,"comments":23,"created_at":"2016-08-18T14:24:44Z","updated_at":"2016-10-24T14:52:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10588","html_url":"https://github.com/ManageIQ/manageiq/pull/10588","diff_url":"https://github.com/ManageIQ/manageiq/pull/10588.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/10588.patch"},"body":"From a UI perspective, every model, that includes `EventMixin` should basically support a timeline, because all methods that are used are in that mixin. \r\n\r\nNow have a look at all those models in the files list...\r\nI guess that means, that all those now have a timeline button?!\r\n\r\n@blomquisg makes sense?\r\n@h-kataria can you have a look?\r\n@simon3z can you check this for the Containers team?"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/255763537","html_url":"https://github.com/ManageIQ/manageiq/pull/10588#issuecomment-255763537","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10588","id":255763537,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-10-24T14:52:57Z","updated_at":"2016-10-24T14:52:57Z","body":"<rubocop />Checked commit https://github.com/durandom/manageiq/commit/00a016368a3090e0253eef32a2a35effd79c6bc2 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n18 files checked, 4 offenses detected\n\n**spec/helpers/application_helper/buttons/ems_timeline_spec.rb**\n- [ ] :grey_exclamation: - [Line 14](https://github.com/durandom/manageiq/blob/00a016368a3090e0253eef32a2a35effd79c6bc2/spec/helpers/application_helper/buttons/ems_timeline_spec.rb#L14), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [123/120]\n- [ ] :grey_exclamation: - [Line 24](https://github.com/durandom/manageiq/blob/00a016368a3090e0253eef32a2a35effd79c6bc2/spec/helpers/application_helper/buttons/ems_timeline_spec.rb#L24), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [123/120]\n- [ ] :grey_exclamation: - [Line 33](https://github.com/durandom/manageiq/blob/00a016368a3090e0253eef32a2a35effd79c6bc2/spec/helpers/application_helper/buttons/ems_timeline_spec.rb#L33), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [121/120]\n- [ ] :grey_exclamation: - [Line 6](https://github.com/durandom/manageiq/blob/00a016368a3090e0253eef32a2a35effd79c6bc2/spec/helpers/application_helper/buttons/ems_timeline_spec.rb#L6), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [121/120]\n"}}
{"actor":{"display_login":"miq-bot"}}