{"action":"created","comment":{"url":"https://api.github.com/repos/NetSys/bess/pulls/comments/90357945","pull_request_review_id":10874743,"id":90357945,"diff_hunk":"@@ -276,37 +287,45 @@ def do_dist_clean():\n     print 'Removing 3rd-party libraries...'\n     cmd('rm -rf %s %s' % (DPDK_FILE, DPDK_DIR))\n \n-def print_usage():\n-    print >> sys.stderr, \\\n-            'Usage: %s [all|dpdk|bess|kmod|clean|dist_clean|help]' % \\\n-            sys.argv[0]\n+def print_usage(parser):\n+    parser.print_help(file=sys.stderr)\n     sys.exit(2)\n \n+def update_benchmark_path(path):\n+    print 'Specified benchmark path %s' % path\n+    cxx_flags.extend(['-I', '%s/include'%(path)])","path":"build.py","position":71,"original_position":71,"commit_id":"9698ea81bd7c6fba1f50028e8daeb322c0d6416a","original_commit_id":"9698ea81bd7c6fba1f50028e8daeb322c0d6416a","user":{"login":"sangjinhan","id":1916976,"avatar_url":"https://avatars.githubusercontent.com/u/1916976?v=3","gravatar_id":"","url":"https://api.github.com/users/sangjinhan","html_url":"https://github.com/sangjinhan","followers_url":"https://api.github.com/users/sangjinhan/followers","following_url":"https://api.github.com/users/sangjinhan/following{/other_user}","gists_url":"https://api.github.com/users/sangjinhan/gists{/gist_id}","starred_url":"https://api.github.com/users/sangjinhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sangjinhan/subscriptions","organizations_url":"https://api.github.com/users/sangjinhan/orgs","repos_url":"https://api.github.com/users/sangjinhan/repos","events_url":"https://api.github.com/users/sangjinhan/events{/privacy}","received_events_url":"https://api.github.com/users/sangjinhan/received_events","type":"User","site_admin":false},"body":"just a minor nit: let's not add a whitespace after `-I` and `-L`, to be consistent with the existing `Makefile` style","created_at":"2016-12-01T00:06:14Z","updated_at":"2016-12-01T00:07:52Z","html_url":"https://github.com/NetSys/bess/pull/149#discussion_r90357945","pull_request_url":"https://api.github.com/repos/NetSys/bess/pulls/149","_links":{"self":{"href":"https://api.github.com/repos/NetSys/bess/pulls/comments/90357945"},"html":{"href":"https://github.com/NetSys/bess/pull/149#discussion_r90357945"},"pull_request":{"href":"https://api.github.com/repos/NetSys/bess/pulls/149"}}},"pull_request":{"url":"https://api.github.com/repos/NetSys/bess/pulls/149","id":95841986,"html_url":"https://github.com/NetSys/bess/pull/149","diff_url":"https://github.com/NetSys/bess/pull/149.diff","patch_url":"https://github.com/NetSys/bess/pull/149.patch","issue_url":"https://api.github.com/repos/NetSys/bess/issues/149","number":149,"state":"open","locked":false,"title":"Change build.py to accept lib locations","user":{"login":"apanda","id":3251,"avatar_url":"https://avatars.githubusercontent.com/u/3251?v=3","gravatar_id":"","url":"https://api.github.com/users/apanda","html_url":"https://github.com/apanda","followers_url":"https://api.github.com/users/apanda/followers","following_url":"https://api.github.com/users/apanda/following{/other_user}","gists_url":"https://api.github.com/users/apanda/gists{/gist_id}","starred_url":"https://api.github.com/users/apanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apanda/subscriptions","organizations_url":"https://api.github.com/users/apanda/orgs","repos_url":"https://api.github.com/users/apanda/repos","events_url":"https://api.github.com/users/apanda/events{/privacy}","received_events_url":"https://api.github.com/users/apanda/received_events","type":"User","site_admin":false},"body":"This changes build.py so that one can specify where Google Benchmark library is stored.\r\n\r\nThis change only adds a flag for one library, but it can easily be extended to others. I mostly did this because I am personally a bit weirded out by cloning the repository and running `make install`. I think it might be good to have similar stuff for gRPC (which needs to be built manually at the moment), protoc, and a few others. I can do that later, mostly wanted to test the waters to see if this was something others were OK with.\r\n\r\nBy the way, during development I noticed that `build.py` does not check `protoc` version, so it will get pretty far with old protobuf installations, but then fail in the Python bit. ","created_at":"2016-11-30T07:42:17Z","updated_at":"2016-12-01T00:07:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99767aacb43aae752deb71481873da2ea2fd1ab8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NetSys/bess/pulls/149/commits","review_comments_url":"https://api.github.com/repos/NetSys/bess/pulls/149/comments","review_comment_url":"https://api.github.com/repos/NetSys/bess/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NetSys/bess/issues/149/comments","statuses_url":"https://api.github.com/repos/NetSys/bess/statuses/9698ea81bd7c6fba1f50028e8daeb322c0d6416a","head":{"label":"apanda:c++","ref":"c++","sha":"9698ea81bd7c6fba1f50028e8daeb322c0d6416a","user":{"login":"apanda","id":3251,"avatar_url":"https://avatars.githubusercontent.com/u/3251?v=3","gravatar_id":"","url":"https://api.github.com/users/apanda","html_url":"https://github.com/apanda","followers_url":"https://api.github.com/users/apanda/followers","following_url":"https://api.github.com/users/apanda/following{/other_user}","gists_url":"https://api.github.com/users/apanda/gists{/gist_id}","starred_url":"https://api.github.com/users/apanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apanda/subscriptions","organizations_url":"https://api.github.com/users/apanda/orgs","repos_url":"https://api.github.com/users/apanda/repos","events_url":"https://api.github.com/users/apanda/events{/privacy}","received_events_url":"https://api.github.com/users/apanda/received_events","type":"User","site_admin":false},"repo":{"id":44359202,"name":"bess","full_name":"apanda/bess","owner":{"login":"apanda","id":3251,"avatar_url":"https://avatars.githubusercontent.com/u/3251?v=3","gravatar_id":"","url":"https://api.github.com/users/apanda","html_url":"https://github.com/apanda","followers_url":"https://api.github.com/users/apanda/followers","following_url":"https://api.github.com/users/apanda/following{/other_user}","gists_url":"https://api.github.com/users/apanda/gists{/gist_id}","starred_url":"https://api.github.com/users/apanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apanda/subscriptions","organizations_url":"https://api.github.com/users/apanda/orgs","repos_url":"https://api.github.com/users/apanda/repos","events_url":"https://api.github.com/users/apanda/events{/privacy}","received_events_url":"https://api.github.com/users/apanda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apanda/bess","description":"Berkeley Extensible Software Switch","fork":true,"url":"https://api.github.com/repos/apanda/bess","forks_url":"https://api.github.com/repos/apanda/bess/forks","keys_url":"https://api.github.com/repos/apanda/bess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apanda/bess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apanda/bess/teams","hooks_url":"https://api.github.com/repos/apanda/bess/hooks","issue_events_url":"https://api.github.com/repos/apanda/bess/issues/events{/number}","events_url":"https://api.github.com/repos/apanda/bess/events","assignees_url":"https://api.github.com/repos/apanda/bess/assignees{/user}","branches_url":"https://api.github.com/repos/apanda/bess/branches{/branch}","tags_url":"https://api.github.com/repos/apanda/bess/tags","blobs_url":"https://api.github.com/repos/apanda/bess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apanda/bess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apanda/bess/git/refs{/sha}","trees_url":"https://api.github.com/repos/apanda/bess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apanda/bess/statuses/{sha}","languages_url":"https://api.github.com/repos/apanda/bess/languages","stargazers_url":"https://api.github.com/repos/apanda/bess/stargazers","contributors_url":"https://api.github.com/repos/apanda/bess/contributors","subscribers_url":"https://api.github.com/repos/apanda/bess/subscribers","subscription_url":"https://api.github.com/repos/apanda/bess/subscription","commits_url":"https://api.github.com/repos/apanda/bess/commits{/sha}","git_commits_url":"https://api.github.com/repos/apanda/bess/git/commits{/sha}","comments_url":"https://api.github.com/repos/apanda/bess/comments{/number}","issue_comment_url":"https://api.github.com/repos/apanda/bess/issues/comments{/number}","contents_url":"https://api.github.com/repos/apanda/bess/contents/{+path}","compare_url":"https://api.github.com/repos/apanda/bess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apanda/bess/merges","archive_url":"https://api.github.com/repos/apanda/bess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apanda/bess/downloads","issues_url":"https://api.github.com/repos/apanda/bess/issues{/number}","pulls_url":"https://api.github.com/repos/apanda/bess/pulls{/number}","milestones_url":"https://api.github.com/repos/apanda/bess/milestones{/number}","notifications_url":"https://api.github.com/repos/apanda/bess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apanda/bess/labels{/name}","releases_url":"https://api.github.com/repos/apanda/bess/releases{/id}","deployments_url":"https://api.github.com/repos/apanda/bess/deployments","created_at":"2015-10-16T03:05:08Z","updated_at":"2015-10-16T03:05:09Z","pushed_at":"2016-11-30T23:14:26Z","git_url":"git://github.com/apanda/bess.git","ssh_url":"git@github.com:apanda/bess.git","clone_url":"https://github.com/apanda/bess.git","svn_url":"https://github.com/apanda/bess","homepage":"","size":4483,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NetSys:c++","ref":"c++","sha":"9b293f0248bb99abb7a02b115ebd6ec624831aa1","user":{"login":"NetSys","id":3665805,"avatar_url":"https://avatars.githubusercontent.com/u/3665805?v=3","gravatar_id":"","url":"https://api.github.com/users/NetSys","html_url":"https://github.com/NetSys","followers_url":"https://api.github.com/users/NetSys/followers","following_url":"https://api.github.com/users/NetSys/following{/other_user}","gists_url":"https://api.github.com/users/NetSys/gists{/gist_id}","starred_url":"https://api.github.com/users/NetSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetSys/subscriptions","organizations_url":"https://api.github.com/users/NetSys/orgs","repos_url":"https://api.github.com/users/NetSys/repos","events_url":"https://api.github.com/users/NetSys/events{/privacy}","received_events_url":"https://api.github.com/users/NetSys/received_events","type":"Organization","site_admin":false},"repo":{"id":41328795,"name":"bess","full_name":"NetSys/bess","owner":{"login":"NetSys","id":3665805,"avatar_url":"https://avatars.githubusercontent.com/u/3665805?v=3","gravatar_id":"","url":"https://api.github.com/users/NetSys","html_url":"https://github.com/NetSys","followers_url":"https://api.github.com/users/NetSys/followers","following_url":"https://api.github.com/users/NetSys/following{/other_user}","gists_url":"https://api.github.com/users/NetSys/gists{/gist_id}","starred_url":"https://api.github.com/users/NetSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetSys/subscriptions","organizations_url":"https://api.github.com/users/NetSys/orgs","repos_url":"https://api.github.com/users/NetSys/repos","events_url":"https://api.github.com/users/NetSys/events{/privacy}","received_events_url":"https://api.github.com/users/NetSys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NetSys/bess","description":"BESS: Berkeley Extensible Software Switch","fork":false,"url":"https://api.github.com/repos/NetSys/bess","forks_url":"https://api.github.com/repos/NetSys/bess/forks","keys_url":"https://api.github.com/repos/NetSys/bess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NetSys/bess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NetSys/bess/teams","hooks_url":"https://api.github.com/repos/NetSys/bess/hooks","issue_events_url":"https://api.github.com/repos/NetSys/bess/issues/events{/number}","events_url":"https://api.github.com/repos/NetSys/bess/events","assignees_url":"https://api.github.com/repos/NetSys/bess/assignees{/user}","branches_url":"https://api.github.com/repos/NetSys/bess/branches{/branch}","tags_url":"https://api.github.com/repos/NetSys/bess/tags","blobs_url":"https://api.github.com/repos/NetSys/bess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NetSys/bess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NetSys/bess/git/refs{/sha}","trees_url":"https://api.github.com/repos/NetSys/bess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NetSys/bess/statuses/{sha}","languages_url":"https://api.github.com/repos/NetSys/bess/languages","stargazers_url":"https://api.github.com/repos/NetSys/bess/stargazers","contributors_url":"https://api.github.com/repos/NetSys/bess/contributors","subscribers_url":"https://api.github.com/repos/NetSys/bess/subscribers","subscription_url":"https://api.github.com/repos/NetSys/bess/subscription","commits_url":"https://api.github.com/repos/NetSys/bess/commits{/sha}","git_commits_url":"https://api.github.com/repos/NetSys/bess/git/commits{/sha}","comments_url":"https://api.github.com/repos/NetSys/bess/comments{/number}","issue_comment_url":"https://api.github.com/repos/NetSys/bess/issues/comments{/number}","contents_url":"https://api.github.com/repos/NetSys/bess/contents/{+path}","compare_url":"https://api.github.com/repos/NetSys/bess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NetSys/bess/merges","archive_url":"https://api.github.com/repos/NetSys/bess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NetSys/bess/downloads","issues_url":"https://api.github.com/repos/NetSys/bess/issues{/number}","pulls_url":"https://api.github.com/repos/NetSys/bess/pulls{/number}","milestones_url":"https://api.github.com/repos/NetSys/bess/milestones{/number}","notifications_url":"https://api.github.com/repos/NetSys/bess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NetSys/bess/labels{/name}","releases_url":"https://api.github.com/repos/NetSys/bess/releases{/id}","deployments_url":"https://api.github.com/repos/NetSys/bess/deployments","created_at":"2015-08-24T21:51:31Z","updated_at":"2016-11-17T03:04:44Z","pushed_at":"2016-11-30T23:15:48Z","git_url":"git://github.com/NetSys/bess.git","ssh_url":"git@github.com:NetSys/bess.git","clone_url":"https://github.com/NetSys/bess.git","svn_url":"https://github.com/NetSys/bess","homepage":"","size":4667,"stargazers_count":45,"watchers_count":45,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":3,"forks":26,"open_issues":3,"watchers":45,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NetSys/bess/pulls/149"},"html":{"href":"https://github.com/NetSys/bess/pull/149"},"issue":{"href":"https://api.github.com/repos/NetSys/bess/issues/149"},"comments":{"href":"https://api.github.com/repos/NetSys/bess/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/NetSys/bess/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/NetSys/bess/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NetSys/bess/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/NetSys/bess/statuses/9698ea81bd7c6fba1f50028e8daeb322c0d6416a"}}}}
{"actor":{"display_login":"sangjinhan"}}