{"action":"created","issue":{"url":"https://api.github.com/repos/OSGP/Platform/issues/531","repository_url":"https://api.github.com/repos/OSGP/Platform","labels_url":"https://api.github.com/repos/OSGP/Platform/issues/531/labels{/name}","comments_url":"https://api.github.com/repos/OSGP/Platform/issues/531/comments","events_url":"https://api.github.com/repos/OSGP/Platform/issues/531/events","html_url":"https://github.com/OSGP/Platform/pull/531","id":192840027,"number":531,"title":"FLEX-2382 Municipality can now change the device and relais aliases","user":{"login":"Joep-Simons","id":5988459,"avatar_url":"https://avatars.githubusercontent.com/u/5988459?v=3","gravatar_id":"","url":"https://api.github.com/users/Joep-Simons","html_url":"https://github.com/Joep-Simons","followers_url":"https://api.github.com/users/Joep-Simons/followers","following_url":"https://api.github.com/users/Joep-Simons/following{/other_user}","gists_url":"https://api.github.com/users/Joep-Simons/gists{/gist_id}","starred_url":"https://api.github.com/users/Joep-Simons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joep-Simons/subscriptions","organizations_url":"https://api.github.com/users/Joep-Simons/orgs","repos_url":"https://api.github.com/users/Joep-Simons/repos","events_url":"https://api.github.com/users/Joep-Simons/events{/privacy}","received_events_url":"https://api.github.com/users/Joep-Simons/received_events","type":"User","site_admin":false},"labels":[{"id":197109694,"url":"https://api.github.com/repos/OSGP/Platform/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"rlemmers","id":11977743,"avatar_url":"https://avatars.githubusercontent.com/u/11977743?v=3","gravatar_id":"","url":"https://api.github.com/users/rlemmers","html_url":"https://github.com/rlemmers","followers_url":"https://api.github.com/users/rlemmers/followers","following_url":"https://api.github.com/users/rlemmers/following{/other_user}","gists_url":"https://api.github.com/users/rlemmers/gists{/gist_id}","starred_url":"https://api.github.com/users/rlemmers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlemmers/subscriptions","organizations_url":"https://api.github.com/users/rlemmers/orgs","repos_url":"https://api.github.com/users/rlemmers/repos","events_url":"https://api.github.com/users/rlemmers/events{/privacy}","received_events_url":"https://api.github.com/users/rlemmers/received_events","type":"User","site_admin":false},"assignees":[{"login":"rlemmers","id":11977743,"avatar_url":"https://avatars.githubusercontent.com/u/11977743?v=3","gravatar_id":"","url":"https://api.github.com/users/rlemmers","html_url":"https://github.com/rlemmers","followers_url":"https://api.github.com/users/rlemmers/followers","following_url":"https://api.github.com/users/rlemmers/following{/other_user}","gists_url":"https://api.github.com/users/rlemmers/gists{/gist_id}","starred_url":"https://api.github.com/users/rlemmers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlemmers/subscriptions","organizations_url":"https://api.github.com/users/rlemmers/orgs","repos_url":"https://api.github.com/users/rlemmers/repos","events_url":"https://api.github.com/users/rlemmers/events{/privacy}","received_events_url":"https://api.github.com/users/rlemmers/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-12-01T12:59:07Z","updated_at":"2016-12-05T11:14:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OSGP/Platform/pulls/531","html_url":"https://github.com/OSGP/Platform/pull/531","diff_url":"https://github.com/OSGP/Platform/pull/531.diff","patch_url":"https://github.com/OSGP/Platform/pull/531.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/OSGP/Platform/issues/comments/264828139","html_url":"https://github.com/OSGP/Platform/pull/531#issuecomment-264828139","issue_url":"https://api.github.com/repos/OSGP/Platform/issues/531","id":264828139,"user":{"login":"jenkins-ip-10-4-24-184","id":12208121,"avatar_url":"https://avatars.githubusercontent.com/u/12208121?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkins-ip-10-4-24-184","html_url":"https://github.com/jenkins-ip-10-4-24-184","followers_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/followers","following_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/following{/other_user}","gists_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/subscriptions","organizations_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/orgs","repos_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/repos","events_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/events{/privacy}","received_events_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/received_events","type":"User","site_admin":false},"created_at":"2016-12-05T11:14:42Z","updated_at":"2016-12-05T11:14:42Z","body":"SonarQube analysis reported 18 issues\n* ![CRITICAL](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-critical.png) 2 critical\n* ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) 12 major\n* ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) 3 minor\n* ![INFO](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-info.png) 1 info\n\nWatch the comments in this conversation to review them.\n\n#### Top 10 extra issues\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![CRITICAL](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-critical.png) [Device.java#L168](https://github.com/OSGP/Platform/blob/a0f21e806e9207e384fd504c9fe06f51d98c353c/osgp-domain-core/src/main/java/com/alliander/osgp/domain/core/entities/Device.java#L168): Make \"authorizations\" private or transient. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AS1948)\n1. ![CRITICAL](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-critical.png) [Device.java#L194](https://github.com/OSGP/Platform/blob/a0f21e806e9207e384fd504c9fe06f51d98c353c/osgp-domain-core/src/main/java/com/alliander/osgp/domain/core/entities/Device.java#L194): Make \"organisations\" private or transient. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AS1948)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [ConfigurationManagementService.java#L171](https://github.com/OSGP/Platform/blob/a0f21e806e9207e384fd504c9fe06f51d98c353c/osgp-adapter-domain-core/src/main/java/com/alliander/osgp/adapter/domain/core/application/services/ConfigurationManagementService.java#L171): Refactor this code to not nest more than 3 if/for/while/switch/try statements. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AS134)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [DeviceManagementService.java#L256](https://github.com/OSGP/Platform/blob/a0f21e806e9207e384fd504c9fe06f51d98c353c/osgp-adapter-ws-core/src/main/java/com/alliander/osgp/adapter/ws/core/application/services/DeviceManagementService.java#L256): Refactor this method to throw at most one checked exception instead of: com.alliander.osgp.shared.exceptionhandling.FunctionalException, com.alliander.osgp.domain.core.exceptions.ArgumentNullOrEmptyException [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AS1160)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [DeviceManagementService.java#L256](https://github.com/OSGP/Platform/blob/a0f21e806e9207e384fd504c9fe06f51d98c353c/osgp-adapter-ws-core/src/main/java/com/alliander/osgp/adapter/ws/core/application/services/DeviceManagementService.java#L256): The Cyclomatic Complexity of this method \"findDevices\" is 11 which is greater than 10 authorized. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AMethodCyclomaticComplexity)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [DeviceManagementService.java#L307](https://github.com/OSGP/Platform/blob/a0f21e806e9207e384fd504c9fe06f51d98c353c/osgp-adapter-ws-core/src/main/java/com/alliander/osgp/adapter/ws/core/application/services/DeviceManagementService.java#L307): The Cyclomatic Complexity of this method \"applyFilter\" is 30 which is greater than 10 authorized. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AMethodCyclomaticComplexity)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [DeviceManagementService.java#L326](https://github.com/OSGP/Platform/blob/a0f21e806e9207e384fd504c9fe06f51d98c353c/osgp-adapter-ws-core/src/main/java/com/alliander/osgp/adapter/ws/core/application/services/DeviceManagementService.java#L326): Refactor this code to not nest more than 3 if/for/while/switch/try statements. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AS134)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [DeviceManagementEndpoint.java#L114](https://github.com/OSGP/Platform/blob/a0f21e806e9207e384fd504c9fe06f51d98c353c/osgp-adapter-ws-core/src/main/java/com/alliander/osgp/adapter/ws/core/endpoints/DeviceManagementEndpoint.java#L114): Remove this unused method parameter \"request\". [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AS1172)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [Device.java#L217](https://github.com/OSGP/Platform/blob/a0f21e806e9207e384fd504c9fe06f51d98c353c/osgp-domain-core/src/main/java/com/alliander/osgp/domain/core/entities/Device.java#L217): Constructor has 9 parameters, which is greater than 7 authorized. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AS00107)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [Device.java#L400](https://github.com/OSGP/Platform/blob/a0f21e806e9207e384fd504c9fe06f51d98c353c/osgp-domain-core/src/main/java/com/alliander/osgp/domain/core/entities/Device.java#L400): Private method 'prePersist' is never used. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AUnusedPrivateMethod)\n"}}
{"actor":{"display_login":"jenkins-ip-10-4-24-184"}}