{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/5566","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/5566/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/5566/comments","events_url":"https://api.github.com/repos/apple/swift/issues/5566/events","html_url":"https://github.com/apple/swift/pull/5566","id":186401228,"number":5566,"title":"[test] Add '--param swift-version=3' to lit's configuration.","user":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars.githubusercontent.com/u/15097531?v=3","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-10-31T21:23:08Z","updated_at":"2016-10-31T22:38:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/5566","html_url":"https://github.com/apple/swift/pull/5566","diff_url":"https://github.com/apple/swift/pull/5566.diff","patch_url":"https://github.com/apple/swift/pull/5566.patch"},"body":"This allows us to run our entire test suite (well, okay, just invocations of swift/swiftc and swift-ide-test) under Swift 3 mode or Swift 4 mode, which will be more important as the two modes diverge. The default is Swift 3 mode for now, which matches the behavior before this patch (because the master compiler still calls itself 3.0).\r\n\r\nIndividual tests can still use `-swift-version 3` to override the mode set by lit, but if an entire test requires Swift 3 or Swift 4, there's also a new test feature \"SWIFT_VERSION=3\" or \"SWIFT_VERSION=4\". However, if you *do* need to override or restrict the version, you should also add a test for the \"other\" version as well, unless it's part of the Compatibility suite or otherwise specifically testing `-swift-version`-related functionality.\r\n\r\nThe next step is to figure out how we want to integrate this into our CI and pull request testing."},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/257441245","html_url":"https://github.com/apple/swift/pull/5566#issuecomment-257441245","issue_url":"https://api.github.com/repos/apple/swift/issues/5566","id":257441245,"user":{"login":"moiseev","id":64011,"avatar_url":"https://avatars.githubusercontent.com/u/64011?v=3","gravatar_id":"","url":"https://api.github.com/users/moiseev","html_url":"https://github.com/moiseev","followers_url":"https://api.github.com/users/moiseev/followers","following_url":"https://api.github.com/users/moiseev/following{/other_user}","gists_url":"https://api.github.com/users/moiseev/gists{/gist_id}","starred_url":"https://api.github.com/users/moiseev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moiseev/subscriptions","organizations_url":"https://api.github.com/users/moiseev/orgs","repos_url":"https://api.github.com/users/moiseev/repos","events_url":"https://api.github.com/users/moiseev/events{/privacy}","received_events_url":"https://api.github.com/users/moiseev/received_events","type":"User","site_admin":false},"created_at":"2016-10-31T22:38:07Z","updated_at":"2016-10-31T22:38:07Z","body":"I guess one can run both version 3 and version 4 tests by using multiple `RUN` commands. This is necessary for a case where the change itself is source compatible, but works differently across versions like, for example, 'operators as free functions' vs. 'operators as static members'."}}
{"actor":{"display_login":"moiseev"}}