{"action":"created","comment":{"url":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/comments/90476945","pull_request_review_id":10995578,"id":90476945,"diff_hunk":"@@ -118,50 +118,51 @@ def start(self, data):\n \n             The values in the dict are passed as arguments to the D-Bus methods on SoftwareContainerAgent.\n             The dict is mapped like so:\n-            Container.CONFIG - argument to SoftwareContainerAgent::CreateContainer\n-            Container.HOST_PATH - second argument to SoftwareContainerAgent::BindMountFolderInContainer\n-            Container.BIND_MOUNT_DIR - third argument to SoftwareContainerAgent::BindMountFolderInContainer\n-            Container.READONLY - fourth argument to SoftwareContainerAgent::BindMountFolderInContainer\n+            Container.CONFIG - argument to SoftwareContainerAgent::Create\n+            Container.HOST_PATH - second argument to SoftwareContainerAgent::BindMount\n+            Container.BIND_MOUNT_DIR - third argument to SoftwareContainerAgent::BindMount\n+            Container.READONLY - fourth argument to SoftwareContainerAgent::BindMount\n         \"\"\"\n         success = self.__create_container(data[Container.CONFIG])\n         if False == success:\n             print \"Failed to create container\"\n             return False\n         \n-        self.__bind_dir, success = self.__bindmount_folder_in_container(data[Container.HOST_PATH],\n-                                                               data[Container.BIND_MOUNT_DIR],\n-                                                               data[Container.READONLY])\n+        success = self.__bindmount_folder_in_container(data[Container.HOST_PATH],\n+                                                       data[Container.BIND_MOUNT_DIR],\n+                                                       data[Container.READONLY])\n         if False == success:\n             print \"Failed to retrieve binded folder\"\n             return False\n-\n-        return True\n+        else:\n+            self.__bind_dir = data[Container.BIND_MOUNT_DIR]","path":"servicetest/testframework/lib.py","position":49,"original_position":49,"commit_id":"f991d98399008699ef4fdb7da48ad32fe09c2e4d","original_commit_id":"f991d98399008699ef4fdb7da48ad32fe09c2e4d","user":{"login":"breakreturn","id":13065146,"avatar_url":"https://avatars.githubusercontent.com/u/13065146?v=3","gravatar_id":"","url":"https://api.github.com/users/breakreturn","html_url":"https://github.com/breakreturn","followers_url":"https://api.github.com/users/breakreturn/followers","following_url":"https://api.github.com/users/breakreturn/following{/other_user}","gists_url":"https://api.github.com/users/breakreturn/gists{/gist_id}","starred_url":"https://api.github.com/users/breakreturn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breakreturn/subscriptions","organizations_url":"https://api.github.com/users/breakreturn/orgs","repos_url":"https://api.github.com/users/breakreturn/repos","events_url":"https://api.github.com/users/breakreturn/events{/privacy}","received_events_url":"https://api.github.com/users/breakreturn/received_events","type":"User","site_admin":false},"body":"This is not necessarily the same as the original code w.r.t. the value in __bind_dir is it? Previously it was set by the external component which means we cover some actual behavior there, now we are reusing the value the user set. This should of course be the same, but this is a test after all.","created_at":"2016-12-01T16:01:27Z","updated_at":"2016-12-01T16:01:27Z","html_url":"https://github.com/Pelagicore/softwarecontainer/pull/188#discussion_r90476945","pull_request_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/188","_links":{"self":{"href":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/comments/90476945"},"html":{"href":"https://github.com/Pelagicore/softwarecontainer/pull/188#discussion_r90476945"},"pull_request":{"href":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/188"}}},"pull_request":{"url":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/188","id":95911860,"html_url":"https://github.com/Pelagicore/softwarecontainer/pull/188","diff_url":"https://github.com/Pelagicore/softwarecontainer/pull/188.diff","patch_url":"https://github.com/Pelagicore/softwarecontainer/pull/188.patch","issue_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/issues/188","number":188,"state":"open","locked":false,"title":"Major changes to the DBus API","user":{"login":"tobsan","id":122421,"avatar_url":"https://avatars.githubusercontent.com/u/122421?v=3","gravatar_id":"","url":"https://api.github.com/users/tobsan","html_url":"https://github.com/tobsan","followers_url":"https://api.github.com/users/tobsan/followers","following_url":"https://api.github.com/users/tobsan/following{/other_user}","gists_url":"https://api.github.com/users/tobsan/gists{/gist_id}","starred_url":"https://api.github.com/users/tobsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobsan/subscriptions","organizations_url":"https://api.github.com/users/tobsan/orgs","repos_url":"https://api.github.com/users/tobsan/repos","events_url":"https://api.github.com/users/tobsan/events{/privacy}","received_events_url":"https://api.github.com/users/tobsan/received_events","type":"User","site_admin":false},"body":"This removes some unused/obsolete methods, renames a few to more\r\nlogical names, and adds one new method to list containers.\r\n\r\nSigned-off-by: Tobias Olausson <tobias.olausson@pelagicore.com>","created_at":"2016-11-30T15:24:46Z","updated_at":"2016-12-01T16:01:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"131111cf5cd25581a3faff096e324e23a799fed5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/188/commits","review_comments_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/188/comments","review_comment_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/issues/188/comments","statuses_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/statuses/f991d98399008699ef4fdb7da48ad32fe09c2e4d","head":{"label":"tobsan:update_dbus_api","ref":"update_dbus_api","sha":"f991d98399008699ef4fdb7da48ad32fe09c2e4d","user":{"login":"tobsan","id":122421,"avatar_url":"https://avatars.githubusercontent.com/u/122421?v=3","gravatar_id":"","url":"https://api.github.com/users/tobsan","html_url":"https://github.com/tobsan","followers_url":"https://api.github.com/users/tobsan/followers","following_url":"https://api.github.com/users/tobsan/following{/other_user}","gists_url":"https://api.github.com/users/tobsan/gists{/gist_id}","starred_url":"https://api.github.com/users/tobsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobsan/subscriptions","organizations_url":"https://api.github.com/users/tobsan/orgs","repos_url":"https://api.github.com/users/tobsan/repos","events_url":"https://api.github.com/users/tobsan/events{/privacy}","received_events_url":"https://api.github.com/users/tobsan/received_events","type":"User","site_admin":false},"repo":{"id":67503888,"name":"softwarecontainer","full_name":"tobsan/softwarecontainer","owner":{"login":"tobsan","id":122421,"avatar_url":"https://avatars.githubusercontent.com/u/122421?v=3","gravatar_id":"","url":"https://api.github.com/users/tobsan","html_url":"https://github.com/tobsan","followers_url":"https://api.github.com/users/tobsan/followers","following_url":"https://api.github.com/users/tobsan/following{/other_user}","gists_url":"https://api.github.com/users/tobsan/gists{/gist_id}","starred_url":"https://api.github.com/users/tobsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobsan/subscriptions","organizations_url":"https://api.github.com/users/tobsan/orgs","repos_url":"https://api.github.com/users/tobsan/repos","events_url":"https://api.github.com/users/tobsan/events{/privacy}","received_events_url":"https://api.github.com/users/tobsan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tobsan/softwarecontainer","description":null,"fork":true,"url":"https://api.github.com/repos/tobsan/softwarecontainer","forks_url":"https://api.github.com/repos/tobsan/softwarecontainer/forks","keys_url":"https://api.github.com/repos/tobsan/softwarecontainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tobsan/softwarecontainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tobsan/softwarecontainer/teams","hooks_url":"https://api.github.com/repos/tobsan/softwarecontainer/hooks","issue_events_url":"https://api.github.com/repos/tobsan/softwarecontainer/issues/events{/number}","events_url":"https://api.github.com/repos/tobsan/softwarecontainer/events","assignees_url":"https://api.github.com/repos/tobsan/softwarecontainer/assignees{/user}","branches_url":"https://api.github.com/repos/tobsan/softwarecontainer/branches{/branch}","tags_url":"https://api.github.com/repos/tobsan/softwarecontainer/tags","blobs_url":"https://api.github.com/repos/tobsan/softwarecontainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tobsan/softwarecontainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tobsan/softwarecontainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/tobsan/softwarecontainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tobsan/softwarecontainer/statuses/{sha}","languages_url":"https://api.github.com/repos/tobsan/softwarecontainer/languages","stargazers_url":"https://api.github.com/repos/tobsan/softwarecontainer/stargazers","contributors_url":"https://api.github.com/repos/tobsan/softwarecontainer/contributors","subscribers_url":"https://api.github.com/repos/tobsan/softwarecontainer/subscribers","subscription_url":"https://api.github.com/repos/tobsan/softwarecontainer/subscription","commits_url":"https://api.github.com/repos/tobsan/softwarecontainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/tobsan/softwarecontainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/tobsan/softwarecontainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/tobsan/softwarecontainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/tobsan/softwarecontainer/contents/{+path}","compare_url":"https://api.github.com/repos/tobsan/softwarecontainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tobsan/softwarecontainer/merges","archive_url":"https://api.github.com/repos/tobsan/softwarecontainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tobsan/softwarecontainer/downloads","issues_url":"https://api.github.com/repos/tobsan/softwarecontainer/issues{/number}","pulls_url":"https://api.github.com/repos/tobsan/softwarecontainer/pulls{/number}","milestones_url":"https://api.github.com/repos/tobsan/softwarecontainer/milestones{/number}","notifications_url":"https://api.github.com/repos/tobsan/softwarecontainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tobsan/softwarecontainer/labels{/name}","releases_url":"https://api.github.com/repos/tobsan/softwarecontainer/releases{/id}","deployments_url":"https://api.github.com/repos/tobsan/softwarecontainer/deployments","created_at":"2016-09-06T11:57:27Z","updated_at":"2016-09-06T11:57:30Z","pushed_at":"2016-12-01T16:00:03Z","git_url":"git://github.com/tobsan/softwarecontainer.git","ssh_url":"git@github.com:tobsan/softwarecontainer.git","clone_url":"https://github.com/tobsan/softwarecontainer.git","svn_url":"https://github.com/tobsan/softwarecontainer","homepage":null,"size":2003,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Pelagicore:master","ref":"master","sha":"553e6fb1f87cba19941075b2846ddcbc7015c1e8","user":{"login":"Pelagicore","id":4661080,"avatar_url":"https://avatars.githubusercontent.com/u/4661080?v=3","gravatar_id":"","url":"https://api.github.com/users/Pelagicore","html_url":"https://github.com/Pelagicore","followers_url":"https://api.github.com/users/Pelagicore/followers","following_url":"https://api.github.com/users/Pelagicore/following{/other_user}","gists_url":"https://api.github.com/users/Pelagicore/gists{/gist_id}","starred_url":"https://api.github.com/users/Pelagicore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pelagicore/subscriptions","organizations_url":"https://api.github.com/users/Pelagicore/orgs","repos_url":"https://api.github.com/users/Pelagicore/repos","events_url":"https://api.github.com/users/Pelagicore/events{/privacy}","received_events_url":"https://api.github.com/users/Pelagicore/received_events","type":"Organization","site_admin":false},"repo":{"id":67503064,"name":"softwarecontainer","full_name":"Pelagicore/softwarecontainer","owner":{"login":"Pelagicore","id":4661080,"avatar_url":"https://avatars.githubusercontent.com/u/4661080?v=3","gravatar_id":"","url":"https://api.github.com/users/Pelagicore","html_url":"https://github.com/Pelagicore","followers_url":"https://api.github.com/users/Pelagicore/followers","following_url":"https://api.github.com/users/Pelagicore/following{/other_user}","gists_url":"https://api.github.com/users/Pelagicore/gists{/gist_id}","starred_url":"https://api.github.com/users/Pelagicore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pelagicore/subscriptions","organizations_url":"https://api.github.com/users/Pelagicore/orgs","repos_url":"https://api.github.com/users/Pelagicore/repos","events_url":"https://api.github.com/users/Pelagicore/events{/privacy}","received_events_url":"https://api.github.com/users/Pelagicore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Pelagicore/softwarecontainer","description":"Framework to manage and contain applications in an automotive setting","fork":false,"url":"https://api.github.com/repos/Pelagicore/softwarecontainer","forks_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/forks","keys_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/teams","hooks_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/hooks","issue_events_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/issues/events{/number}","events_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/events","assignees_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/assignees{/user}","branches_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/branches{/branch}","tags_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/tags","blobs_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/statuses/{sha}","languages_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/languages","stargazers_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/stargazers","contributors_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/contributors","subscribers_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/subscribers","subscription_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/subscription","commits_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/contents/{+path}","compare_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/merges","archive_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/downloads","issues_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/issues{/number}","pulls_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls{/number}","milestones_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/milestones{/number}","notifications_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/labels{/name}","releases_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/releases{/id}","deployments_url":"https://api.github.com/repos/Pelagicore/softwarecontainer/deployments","created_at":"2016-09-06T11:46:06Z","updated_at":"2016-10-25T13:24:35Z","pushed_at":"2016-12-01T16:00:15Z","git_url":"git://github.com/Pelagicore/softwarecontainer.git","ssh_url":"git@github.com:Pelagicore/softwarecontainer.git","clone_url":"https://github.com/Pelagicore/softwarecontainer.git","svn_url":"https://github.com/Pelagicore/softwarecontainer","homepage":"https://pelagicore.github.io/softwarecontainer/","size":5490,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":6,"forks":11,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/188"},"html":{"href":"https://github.com/Pelagicore/softwarecontainer/pull/188"},"issue":{"href":"https://api.github.com/repos/Pelagicore/softwarecontainer/issues/188"},"comments":{"href":"https://api.github.com/repos/Pelagicore/softwarecontainer/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Pelagicore/softwarecontainer/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/Pelagicore/softwarecontainer/statuses/f991d98399008699ef4fdb7da48ad32fe09c2e4d"}}}}
{"actor":{"display_login":"breakreturn"}}