{"action":"created","issue":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3709","repository_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3709/labels{/name}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3709/comments","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3709/events","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3709","id":141051643,"number":3709,"title":"Fix GroundPrimitive clipping issue","user":{"login":"bagnell","id":1494815,"avatar_url":"https://avatars.githubusercontent.com/u/1494815?v=3","gravatar_id":"","url":"https://api.github.com/users/bagnell","html_url":"https://github.com/bagnell","followers_url":"https://api.github.com/users/bagnell/followers","following_url":"https://api.github.com/users/bagnell/following{/other_user}","gists_url":"https://api.github.com/users/bagnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bagnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bagnell/subscriptions","organizations_url":"https://api.github.com/users/bagnell/orgs","repos_url":"https://api.github.com/users/bagnell/repos","events_url":"https://api.github.com/users/bagnell/events{/privacy}","received_events_url":"https://api.github.com/users/bagnell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-03-15T17:55:41Z","updated_at":"2016-03-15T21:30:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3709","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3709","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3709.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3709.patch"},"body":"Fixes #3706.\r\n\r\nRemoves the OBB optimization for better culling. The bounding volume was\r\npulling the far plane closer to the camera and causing the shadow volume\r\nto be clipped."},"comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments/197028051","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3709#issuecomment-197028051","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3709","id":197028051,"user":{"login":"pjcozzi","id":782098,"avatar_url":"https://avatars.githubusercontent.com/u/782098?v=3","gravatar_id":"","url":"https://api.github.com/users/pjcozzi","html_url":"https://github.com/pjcozzi","followers_url":"https://api.github.com/users/pjcozzi/followers","following_url":"https://api.github.com/users/pjcozzi/following{/other_user}","gists_url":"https://api.github.com/users/pjcozzi/gists{/gist_id}","starred_url":"https://api.github.com/users/pjcozzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjcozzi/subscriptions","organizations_url":"https://api.github.com/users/pjcozzi/orgs","repos_url":"https://api.github.com/users/pjcozzi/repos","events_url":"https://api.github.com/users/pjcozzi/events{/privacy}","received_events_url":"https://api.github.com/users/pjcozzi/received_events","type":"User","site_admin":false},"created_at":"2016-03-15T21:30:14Z","updated_at":"2016-03-15T21:30:14Z","body":">> Wouldn't it be more efficient to just also make the shadow volume smaller instead of making the bounding volume big?\r\n> \r\n> Yes, I wish we could. Most likely, we would need support from the terrain server to get the max/min height of the terrain over an area.\r\n\r\nIn the general case, I agree.  In this case, don't we know the max height of the smaller OBB?  Couldn't we use that?\r\n"}}