{"action":"created","issue":{"url":"https://api.github.com/repos/timber/timber/issues/1206","repository_url":"https://api.github.com/repos/timber/timber","labels_url":"https://api.github.com/repos/timber/timber/issues/1206/labels{/name}","comments_url":"https://api.github.com/repos/timber/timber/issues/1206/comments","events_url":"https://api.github.com/repos/timber/timber/issues/1206/events","html_url":"https://github.com/timber/timber/pull/1206","id":181421820,"number":1206,"title":"Regenerate image if modified date of source image newer than existing…","user":{"login":"dudewithamood","id":15866807,"avatar_url":"https://avatars.githubusercontent.com/u/15866807?v=3","gravatar_id":"","url":"https://api.github.com/users/dudewithamood","html_url":"https://github.com/dudewithamood","followers_url":"https://api.github.com/users/dudewithamood/followers","following_url":"https://api.github.com/users/dudewithamood/following{/other_user}","gists_url":"https://api.github.com/users/dudewithamood/gists{/gist_id}","starred_url":"https://api.github.com/users/dudewithamood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dudewithamood/subscriptions","organizations_url":"https://api.github.com/users/dudewithamood/orgs","repos_url":"https://api.github.com/users/dudewithamood/repos","events_url":"https://api.github.com/users/dudewithamood/events{/privacy}","received_events_url":"https://api.github.com/users/dudewithamood/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-06T13:56:00Z","updated_at":"2016-10-06T14:20:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/timber/timber/pulls/1206","html_url":"https://github.com/timber/timber/pull/1206","diff_url":"https://github.com/timber/timber/pull/1206.diff","patch_url":"https://github.com/timber/timber/pull/1206.patch"},"body":"**Ticket**: # <!-- Ignore this if not relevant -->\r\n**Reviewer**: @ <!-- Ignore this if not relevant -->\r\n\r\n#### Issue\r\nWhen the original file is replaced with a new version all generated files remain unchanged reflecting the original version.\r\n\r\n\r\n#### Solution\r\nBy comparing file modified dates between the source file and generated files the generated files can be regenerated if the source file is newer (has been changed more recently, indicating it has been changed/updated)\r\n\r\n\r\n#### Impact\r\nIt is backward compatible.\r\nThe only performance implication is the regeneration of images.\r\n\r\n#### Usage\r\nNo.\r\n\r\n\r\n#### Considerations\r\nSome way to clear generated images? One of the issues while developing is that images are resized to multiple sizes until the correct sizing is established and this generates image files that are not needed.\r\n\r\n\r\n#### Testing\r\n<!-- Are unit tests included? If they need to be written, please provide pseudo code for a scenario that fails without your code, but succeeds with it -->\r\nThey're not included - please check the code and test. I understand if it's not correct and needs to be adjusted as I'm not necessarily and expert.\r\n\r\nTest cases would be...\r\n\r\nWithout this code: original image is replaced (with same file name) and resized generated images reflect the image prior to being replaced\r\n\r\nWith the code:  original image is replaced (with same file name) and resized images are regenerated based on the updated source image"},"comment":{"url":"https://api.github.com/repos/timber/timber/issues/comments/251976846","html_url":"https://github.com/timber/timber/pull/1206#issuecomment-251976846","issue_url":"https://api.github.com/repos/timber/timber/issues/1206","id":251976846,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T14:20:50Z","updated_at":"2016-10-06T14:20:50Z","body":"\n[![Coverage Status](https://coveralls.io/builds/8215467/badge)](https://coveralls.io/builds/8215467)\n\nCoverage remained the same at 90.368% when pulling **b6c4d7fce4803180a2bb49e0537e083c525b6021 on dudewithamood:patch-1** into **a4d027c416413868fd9ad3b51620912eeb70d231 on timber:master**.\n"}}
{"actor":{"display_login":"coveralls"}}