{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-native/pulls/comments/53576537","id":53576537,"diff_hunk":"@@ -123,18 +123,19 @@ function buildAndRun(args, reject) {\n }\n \n function startServerInNewWindow() {\n+  var yargV = require('yargs').argv;\n+\n   const launchPackagerScript = path.resolve(\n     __dirname, '..', '..', 'packager', 'launchPackager.command'\n   );\n \n   if (process.platform === 'darwin') {\n-    child_process.spawnSync('open', [launchPackagerScript]);\n+    const termApp = yargV.open ? yargV.open : 'Terminal.app';\n+    return child_process.spawnSync('open', ['-a', termApp, launchPackagerScript]);\n   } else if (process.platform === 'linux') {\n-    child_process.spawn(\n-      'xterm',\n-      ['-e', 'sh', launchPackagerScript],\n-      {detached: true}\n-    );\n+    const term = yargV.term ? yargV.term : 'xterm';","path":"local-cli/runAndroid/runAndroid.js","position":20,"original_position":20,"commit_id":"99d2ff73fcc34e3cae2e3569c8658bcb755510fe","original_commit_id":"99d2ff73fcc34e3cae2e3569c8658bcb755510fe","user":{"login":"nmccready","id":583593,"avatar_url":"https://avatars.githubusercontent.com/u/583593?v=3","gravatar_id":"","url":"https://api.github.com/users/nmccready","html_url":"https://github.com/nmccready","followers_url":"https://api.github.com/users/nmccready/followers","following_url":"https://api.github.com/users/nmccready/following{/other_user}","gists_url":"https://api.github.com/users/nmccready/gists{/gist_id}","starred_url":"https://api.github.com/users/nmccready/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmccready/subscriptions","organizations_url":"https://api.github.com/users/nmccready/orgs","repos_url":"https://api.github.com/users/nmccready/repos","events_url":"https://api.github.com/users/nmccready/events{/privacy}","received_events_url":"https://api.github.com/users/nmccready/received_events","type":"User","site_admin":false},"body":"Copy paste error from PR comments. Which shall it be `--open` or `--term`?","created_at":"2016-02-21T23:41:53Z","updated_at":"2016-02-21T23:41:53Z","html_url":"https://github.com/facebook/react-native/pull/5232#discussion_r53576537","pull_request_url":"https://api.github.com/repos/facebook/react-native/pulls/5232","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments/53576537"},"html":{"href":"https://github.com/facebook/react-native/pull/5232#discussion_r53576537"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-native/pulls/5232"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/5232","id":55556865,"html_url":"https://github.com/facebook/react-native/pull/5232","diff_url":"https://github.com/facebook/react-native/pull/5232.diff","patch_url":"https://github.com/facebook/react-native/pull/5232.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/5232","number":5232,"state":"open","locked":false,"title":"run-android Chose your Term for OSX, and Linux","user":{"login":"nmccready","id":583593,"avatar_url":"https://avatars.githubusercontent.com/u/583593?v=3","gravatar_id":"","url":"https://api.github.com/users/nmccready","html_url":"https://github.com/nmccready","followers_url":"https://api.github.com/users/nmccready/followers","following_url":"https://api.github.com/users/nmccready/following{/other_user}","gists_url":"https://api.github.com/users/nmccready/gists{/gist_id}","starred_url":"https://api.github.com/users/nmccready/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmccready/subscriptions","organizations_url":"https://api.github.com/users/nmccready/orgs","repos_url":"https://api.github.com/users/nmccready/repos","events_url":"https://api.github.com/users/nmccready/events{/privacy}","received_events_url":"https://api.github.com/users/nmccready/received_events","type":"User","site_admin":false},"body":"Main goal is to get this passed for OSX. I assume this works for linux; please verify. Also if specs need to be added, please suggest\r\nan implementation as there is no __test__ dir for andriod.\r\n\r\nusing yargs (already a dependency) to allow other terminals besides OSX crummy default terminal. Like (iterm) :)\r\n\r\nmain use case:\r\n\r\n` react-native run-android --open iterm`\r\n\r\nThe nice thing about this in ITERM is it opens another tab by default which is way less intrusive then OSX default term.","created_at":"2016-01-10T03:20:48Z","updated_at":"2016-02-21T23:41:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"749d610a596567d290991c1ca207fdd19ec754ed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/5232/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/5232/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/5232/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/99d2ff73fcc34e3cae2e3569c8658bcb755510fe","head":{"label":"nmccready:feature/choseYourTerm","ref":"feature/choseYourTerm","sha":"99d2ff73fcc34e3cae2e3569c8658bcb755510fe","user":{"login":"nmccready","id":583593,"avatar_url":"https://avatars.githubusercontent.com/u/583593?v=3","gravatar_id":"","url":"https://api.github.com/users/nmccready","html_url":"https://github.com/nmccready","followers_url":"https://api.github.com/users/nmccready/followers","following_url":"https://api.github.com/users/nmccready/following{/other_user}","gists_url":"https://api.github.com/users/nmccready/gists{/gist_id}","starred_url":"https://api.github.com/users/nmccready/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmccready/subscriptions","organizations_url":"https://api.github.com/users/nmccready/orgs","repos_url":"https://api.github.com/users/nmccready/repos","events_url":"https://api.github.com/users/nmccready/events{/privacy}","received_events_url":"https://api.github.com/users/nmccready/received_events","type":"User","site_admin":false},"repo":{"id":48706379,"name":"react-native","full_name":"nmccready/react-native","owner":{"login":"nmccready","id":583593,"avatar_url":"https://avatars.githubusercontent.com/u/583593?v=3","gravatar_id":"","url":"https://api.github.com/users/nmccready","html_url":"https://github.com/nmccready","followers_url":"https://api.github.com/users/nmccready/followers","following_url":"https://api.github.com/users/nmccready/following{/other_user}","gists_url":"https://api.github.com/users/nmccready/gists{/gist_id}","starred_url":"https://api.github.com/users/nmccready/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmccready/subscriptions","organizations_url":"https://api.github.com/users/nmccready/orgs","repos_url":"https://api.github.com/users/nmccready/repos","events_url":"https://api.github.com/users/nmccready/events{/privacy}","received_events_url":"https://api.github.com/users/nmccready/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nmccready/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/nmccready/react-native","forks_url":"https://api.github.com/repos/nmccready/react-native/forks","keys_url":"https://api.github.com/repos/nmccready/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nmccready/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nmccready/react-native/teams","hooks_url":"https://api.github.com/repos/nmccready/react-native/hooks","issue_events_url":"https://api.github.com/repos/nmccready/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/nmccready/react-native/events","assignees_url":"https://api.github.com/repos/nmccready/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/nmccready/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/nmccready/react-native/tags","blobs_url":"https://api.github.com/repos/nmccready/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nmccready/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nmccready/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/nmccready/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nmccready/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/nmccready/react-native/languages","stargazers_url":"https://api.github.com/repos/nmccready/react-native/stargazers","contributors_url":"https://api.github.com/repos/nmccready/react-native/contributors","subscribers_url":"https://api.github.com/repos/nmccready/react-native/subscribers","subscription_url":"https://api.github.com/repos/nmccready/react-native/subscription","commits_url":"https://api.github.com/repos/nmccready/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/nmccready/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/nmccready/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/nmccready/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/nmccready/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/nmccready/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nmccready/react-native/merges","archive_url":"https://api.github.com/repos/nmccready/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nmccready/react-native/downloads","issues_url":"https://api.github.com/repos/nmccready/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/nmccready/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/nmccready/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/nmccready/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nmccready/react-native/labels{/name}","releases_url":"https://api.github.com/repos/nmccready/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/nmccready/react-native/deployments","created_at":"2015-12-28T18:28:19Z","updated_at":"2015-12-28T18:28:23Z","pushed_at":"2016-02-13T16:01:43Z","git_url":"git://github.com/nmccready/react-native.git","ssh_url":"git@github.com:nmccready/react-native.git","clone_url":"https://github.com/nmccready/react-native.git","svn_url":"https://github.com/nmccready/react-native","homepage":"http://facebook.github.io/react-native/","size":41155,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"dfacb6c8f21091cdbf5d56d46f81f7822dea173e","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-02-21T20:43:46Z","pushed_at":"2016-02-21T16:20:55Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":79629,"stargazers_count":27435,"watchers_count":27435,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5035,"mirror_url":null,"open_issues_count":1132,"forks":5035,"open_issues":1132,"watchers":27435,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/5232"},"html":{"href":"https://github.com/facebook/react-native/pull/5232"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/5232"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/5232/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/5232/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/5232/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/99d2ff73fcc34e3cae2e3569c8658bcb755510fe"}}}}