{"action":"created","comment":{"url":"https://api.github.com/repos/ska-sa/katcp-python/pulls/comments/76413538","id":76413538,"diff_hunk":"@@ -34,9 +34,11 @@\n from .sampling import format_inform_v5, format_inform_v4\n from .core import (SEC_TO_MS_FAC, MS_TO_SEC_FAC, SEC_TS_KATCP_MAJOR,\n                    VERSION_CONNECT_KATCP_MAJOR, DEFAULT_KATCP_MAJOR)\n-from .version import VERSION, VERSION_STR\n from .kattypes import (request, return_reply)\n \n+from katversion import get_version","path":"katcp/server.py","position":7,"original_position":7,"commit_id":"2cb8bc635b3696f7208bdba9a65f44f353120e87","original_commit_id":"2cb8bc635b3696f7208bdba9a65f44f353120e87","user":{"login":"ludwigschwardt","id":392144,"avatar_url":"https://avatars.githubusercontent.com/u/392144?v=3","gravatar_id":"","url":"https://api.github.com/users/ludwigschwardt","html_url":"https://github.com/ludwigschwardt","followers_url":"https://api.github.com/users/ludwigschwardt/followers","following_url":"https://api.github.com/users/ludwigschwardt/following{/other_user}","gists_url":"https://api.github.com/users/ludwigschwardt/gists{/gist_id}","starred_url":"https://api.github.com/users/ludwigschwardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludwigschwardt/subscriptions","organizations_url":"https://api.github.com/users/ludwigschwardt/orgs","repos_url":"https://api.github.com/users/ludwigschwardt/repos","events_url":"https://api.github.com/users/ludwigschwardt/events{/privacy}","received_events_url":"https://api.github.com/users/ludwigschwardt/received_events","type":"User","site_admin":false},"body":"The `get_version` function is used to extract versions from git repos, but the git repo won't be around once you install katcp.\r\n\r\nI would rather do `from . import __version__` or something similar. You should restrict `katversion` to `setup.py` and `__init__.py` and use the explicit `__version__` elsewhere.\r\n\r\n","created_at":"2016-08-26T12:55:09Z","updated_at":"2016-08-26T12:55:09Z","html_url":"https://github.com/ska-sa/katcp-python/pull/164#discussion_r76413538","pull_request_url":"https://api.github.com/repos/ska-sa/katcp-python/pulls/164","_links":{"self":{"href":"https://api.github.com/repos/ska-sa/katcp-python/pulls/comments/76413538"},"html":{"href":"https://github.com/ska-sa/katcp-python/pull/164#discussion_r76413538"},"pull_request":{"href":"https://api.github.com/repos/ska-sa/katcp-python/pulls/164"}}},"pull_request":{"url":"https://api.github.com/repos/ska-sa/katcp-python/pulls/164","id":82866379,"html_url":"https://github.com/ska-sa/katcp-python/pull/164","diff_url":"https://github.com/ska-sa/katcp-python/pull/164.diff","patch_url":"https://github.com/ska-sa/katcp-python/pull/164.patch","issue_url":"https://api.github.com/repos/ska-sa/katcp-python/issues/164","number":164,"state":"open","locked":false,"title":"Release notes for version 0.6.1; removed version.py because we use ka…","user":{"login":"fjoubert","id":8371143,"avatar_url":"https://avatars.githubusercontent.com/u/8371143?v=3","gravatar_id":"","url":"https://api.github.com/users/fjoubert","html_url":"https://github.com/fjoubert","followers_url":"https://api.github.com/users/fjoubert/followers","following_url":"https://api.github.com/users/fjoubert/following{/other_user}","gists_url":"https://api.github.com/users/fjoubert/gists{/gist_id}","starred_url":"https://api.github.com/users/fjoubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjoubert/subscriptions","organizations_url":"https://api.github.com/users/fjoubert/orgs","repos_url":"https://api.github.com/users/fjoubert/repos","events_url":"https://api.github.com/users/fjoubert/events{/privacy}","received_events_url":"https://api.github.com/users/fjoubert/received_events","type":"User","site_admin":false},"body":"…tversion now","created_at":"2016-08-26T10:31:53Z","updated_at":"2016-08-26T12:55:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01b78855bfa88b258f77a1e4487310b0b198d5bf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ska-sa/katcp-python/pulls/164/commits","review_comments_url":"https://api.github.com/repos/ska-sa/katcp-python/pulls/164/comments","review_comment_url":"https://api.github.com/repos/ska-sa/katcp-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ska-sa/katcp-python/issues/164/comments","statuses_url":"https://api.github.com/repos/ska-sa/katcp-python/statuses/2cb8bc635b3696f7208bdba9a65f44f353120e87","head":{"label":"ska-sa:user/fjoubert/release_prep_for_0.6.1","ref":"user/fjoubert/release_prep_for_0.6.1","sha":"2cb8bc635b3696f7208bdba9a65f44f353120e87","user":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":5854299,"name":"katcp-python","full_name":"ska-sa/katcp-python","owner":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ska-sa/katcp-python","description":"Python client and server library for the Karoo Array Telescope Control Protocol (KATCP)","fork":false,"url":"https://api.github.com/repos/ska-sa/katcp-python","forks_url":"https://api.github.com/repos/ska-sa/katcp-python/forks","keys_url":"https://api.github.com/repos/ska-sa/katcp-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/katcp-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/katcp-python/teams","hooks_url":"https://api.github.com/repos/ska-sa/katcp-python/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/katcp-python/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/katcp-python/events","assignees_url":"https://api.github.com/repos/ska-sa/katcp-python/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/katcp-python/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/katcp-python/tags","blobs_url":"https://api.github.com/repos/ska-sa/katcp-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/katcp-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/katcp-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/katcp-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/katcp-python/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/katcp-python/languages","stargazers_url":"https://api.github.com/repos/ska-sa/katcp-python/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/katcp-python/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/katcp-python/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/katcp-python/subscription","commits_url":"https://api.github.com/repos/ska-sa/katcp-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/katcp-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/katcp-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/katcp-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/katcp-python/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/katcp-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/katcp-python/merges","archive_url":"https://api.github.com/repos/ska-sa/katcp-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/katcp-python/downloads","issues_url":"https://api.github.com/repos/ska-sa/katcp-python/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/katcp-python/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/katcp-python/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/katcp-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/katcp-python/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/katcp-python/releases{/id}","deployments_url":"https://api.github.com/repos/ska-sa/katcp-python/deployments","created_at":"2012-09-18T09:52:58Z","updated_at":"2016-02-07T09:15:16Z","pushed_at":"2016-08-26T12:04:24Z","git_url":"git://github.com/ska-sa/katcp-python.git","ssh_url":"git@github.com:ska-sa/katcp-python.git","clone_url":"https://github.com/ska-sa/katcp-python.git","svn_url":"https://github.com/ska-sa/katcp-python","homepage":null,"size":2782,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"ska-sa:master","ref":"master","sha":"1f63b1102baa7c146d4f191f76742c4e3ccf0cb3","user":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":5854299,"name":"katcp-python","full_name":"ska-sa/katcp-python","owner":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ska-sa/katcp-python","description":"Python client and server library for the Karoo Array Telescope Control Protocol (KATCP)","fork":false,"url":"https://api.github.com/repos/ska-sa/katcp-python","forks_url":"https://api.github.com/repos/ska-sa/katcp-python/forks","keys_url":"https://api.github.com/repos/ska-sa/katcp-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/katcp-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/katcp-python/teams","hooks_url":"https://api.github.com/repos/ska-sa/katcp-python/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/katcp-python/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/katcp-python/events","assignees_url":"https://api.github.com/repos/ska-sa/katcp-python/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/katcp-python/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/katcp-python/tags","blobs_url":"https://api.github.com/repos/ska-sa/katcp-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/katcp-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/katcp-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/katcp-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/katcp-python/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/katcp-python/languages","stargazers_url":"https://api.github.com/repos/ska-sa/katcp-python/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/katcp-python/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/katcp-python/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/katcp-python/subscription","commits_url":"https://api.github.com/repos/ska-sa/katcp-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/katcp-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/katcp-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/katcp-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/katcp-python/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/katcp-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/katcp-python/merges","archive_url":"https://api.github.com/repos/ska-sa/katcp-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/katcp-python/downloads","issues_url":"https://api.github.com/repos/ska-sa/katcp-python/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/katcp-python/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/katcp-python/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/katcp-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/katcp-python/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/katcp-python/releases{/id}","deployments_url":"https://api.github.com/repos/ska-sa/katcp-python/deployments","created_at":"2012-09-18T09:52:58Z","updated_at":"2016-02-07T09:15:16Z","pushed_at":"2016-08-26T12:04:24Z","git_url":"git://github.com/ska-sa/katcp-python.git","ssh_url":"git@github.com:ska-sa/katcp-python.git","clone_url":"https://github.com/ska-sa/katcp-python.git","svn_url":"https://github.com/ska-sa/katcp-python","homepage":null,"size":2782,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ska-sa/katcp-python/pulls/164"},"html":{"href":"https://github.com/ska-sa/katcp-python/pull/164"},"issue":{"href":"https://api.github.com/repos/ska-sa/katcp-python/issues/164"},"comments":{"href":"https://api.github.com/repos/ska-sa/katcp-python/issues/164/comments"},"review_comments":{"href":"https://api.github.com/repos/ska-sa/katcp-python/pulls/164/comments"},"review_comment":{"href":"https://api.github.com/repos/ska-sa/katcp-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ska-sa/katcp-python/pulls/164/commits"},"statuses":{"href":"https://api.github.com/repos/ska-sa/katcp-python/statuses/2cb8bc635b3696f7208bdba9a65f44f353120e87"}}}}
{"actor":{"display_login":"ludwigschwardt"}}