{"action":"created","issue":{"url":"https://api.github.com/repos/tgriesser/knex/issues/1759","repository_url":"https://api.github.com/repos/tgriesser/knex","labels_url":"https://api.github.com/repos/tgriesser/knex/issues/1759/labels{/name}","comments_url":"https://api.github.com/repos/tgriesser/knex/issues/1759/comments","events_url":"https://api.github.com/repos/tgriesser/knex/issues/1759/events","html_url":"https://github.com/tgriesser/knex/pull/1759","id":185656427,"number":1759,"title":"Feature/alter column","user":{"login":"RWOverdijk","id":781745,"avatar_url":"https://avatars.githubusercontent.com/u/781745?v=3","gravatar_id":"","url":"https://api.github.com/users/RWOverdijk","html_url":"https://github.com/RWOverdijk","followers_url":"https://api.github.com/users/RWOverdijk/followers","following_url":"https://api.github.com/users/RWOverdijk/following{/other_user}","gists_url":"https://api.github.com/users/RWOverdijk/gists{/gist_id}","starred_url":"https://api.github.com/users/RWOverdijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RWOverdijk/subscriptions","organizations_url":"https://api.github.com/users/RWOverdijk/orgs","repos_url":"https://api.github.com/users/RWOverdijk/repos","events_url":"https://api.github.com/users/RWOverdijk/events{/privacy}","received_events_url":"https://api.github.com/users/RWOverdijk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2016-10-27T12:38:11Z","updated_at":"2016-11-23T10:30:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tgriesser/knex/pulls/1759","html_url":"https://github.com/tgriesser/knex/pull/1759","diff_url":"https://github.com/tgriesser/knex/pull/1759.diff","patch_url":"https://github.com/tgriesser/knex/pull/1759.patch"},"body":"Fixes some issues from #46 \n\nAfter this PR, a couple of things will have to be done:\n1. ~~Update the docs to document this method~~ https://github.com/knex/documentation/pull/8\n2. ~~Add to dialects (alter column works for most, and I already added mysql)~~\n3. ~~Add tests~~\n\nThe code in this PR works as follows:\n\n``` js\nknex.alterTable('user', table => {\n  table.string('something', 50).notNullable();\n  table.string('username', 35).notNullable().alter();\n  table.dropColumn('reasons');\n});\n```\n\nwhich generates:\n\n```\n~/projects/wetland [ time node app\nalter table `user` add `something` varchar(50) not null;\nalter table `user` modify `username` varchar(35) not null;\nalter table `user` drop `reasons`;\n```\n"},"comment":{"url":"https://api.github.com/repos/tgriesser/knex/issues/comments/262479044","html_url":"https://github.com/tgriesser/knex/pull/1759#issuecomment-262479044","issue_url":"https://api.github.com/repos/tgriesser/knex/issues/1759","id":262479044,"user":{"login":"elhigu","id":696345,"avatar_url":"https://avatars.githubusercontent.com/u/696345?v=3","gravatar_id":"","url":"https://api.github.com/users/elhigu","html_url":"https://github.com/elhigu","followers_url":"https://api.github.com/users/elhigu/followers","following_url":"https://api.github.com/users/elhigu/following{/other_user}","gists_url":"https://api.github.com/users/elhigu/gists{/gist_id}","starred_url":"https://api.github.com/users/elhigu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elhigu/subscriptions","organizations_url":"https://api.github.com/users/elhigu/orgs","repos_url":"https://api.github.com/users/elhigu/repos","events_url":"https://api.github.com/users/elhigu/events{/privacy}","received_events_url":"https://api.github.com/users/elhigu/received_events","type":"User","site_admin":false},"created_at":"2016-11-23T10:30:40Z","updated_at":"2016-11-23T10:30:40Z","body":"@RWOverdijk do you still have plans for doing those last changes to complete this one? After integration test and couple of error messages of unsupported dialects I'm good to merge this :)"}}
{"actor":{"display_login":"elhigu"}}