{"action":"created","comment":{"url":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/comments/80632749","pull_request_review_id":1676877,"id":80632749,"diff_hunk":"@@ -65,6 +65,18 @@ initial equation\n    equivalent air temperature calculation is close to 0.\n    If there are no walls, windows and ground at all, this might be\n    irrelevant.\", level=AssertionLevel.warning);\n+\n+equation\n+  delTEqLW=(TBlaSky-TDryBul)*alphaRad/(alphaRad+alphaWallOut);\n+  delTEqSW=HSol*aExt/(alphaRad+alphaWallOut);\n+  if withLongwave then\n+    TEqWin=TDryBul.+delTEqLWWin*abs(sunblind.-1);","path":"Annex60/ThermalZones/ReducedOrder/EquivalentAirTemperature/BaseClasses/PartialVDI6007.mo","position":38,"original_position":38,"commit_id":"1fb9bd3deb4c5bc422c6367b6b616efbbe8611ec","original_commit_id":"fa1f192261df9f924e412d07bad6e04687e9dd62","user":{"login":"mlauster","id":6892690,"avatar_url":"https://avatars.githubusercontent.com/u/6892690?v=3","gravatar_id":"","url":"https://api.github.com/users/mlauster","html_url":"https://github.com/mlauster","followers_url":"https://api.github.com/users/mlauster/followers","following_url":"https://api.github.com/users/mlauster/following{/other_user}","gists_url":"https://api.github.com/users/mlauster/gists{/gist_id}","starred_url":"https://api.github.com/users/mlauster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlauster/subscriptions","organizations_url":"https://api.github.com/users/mlauster/orgs","repos_url":"https://api.github.com/users/mlauster/repos","events_url":"https://api.github.com/users/mlauster/events{/privacy}","received_events_url":"https://api.github.com/users/mlauster/received_events","type":"User","site_admin":false},"body":"True, `abs()` is not necessary here. But as `sunblind` is a vector, it ends in:\r\n\r\n`TEqWin=TDryBul.+delTEqLWWin*(ones(n)-sunblind);`\r\n\r\nSo one function call for the other. But it looks more straight ahead.","created_at":"2016-09-27T07:20:01Z","updated_at":"2016-09-27T07:20:01Z","html_url":"https://github.com/iea-annex60/modelica-annex60/pull/525#discussion_r80632749","pull_request_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/525","_links":{"self":{"href":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/comments/80632749"},"html":{"href":"https://github.com/iea-annex60/modelica-annex60/pull/525#discussion_r80632749"},"pull_request":{"href":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/525"}}},"pull_request":{"url":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/525","id":86734865,"html_url":"https://github.com/iea-annex60/modelica-annex60/pull/525","diff_url":"https://github.com/iea-annex60/modelica-annex60/pull/525.diff","patch_url":"https://github.com/iea-annex60/modelica-annex60/pull/525.patch","issue_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/525","number":525,"state":"open","locked":false,"title":"Issue500 eq air temp","user":{"login":"mlauster","id":6892690,"avatar_url":"https://avatars.githubusercontent.com/u/6892690?v=3","gravatar_id":"","url":"https://api.github.com/users/mlauster","html_url":"https://github.com/mlauster","followers_url":"https://api.github.com/users/mlauster/followers","following_url":"https://api.github.com/users/mlauster/following{/other_user}","gists_url":"https://api.github.com/users/mlauster/gists{/gist_id}","starred_url":"https://api.github.com/users/mlauster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlauster/subscriptions","organizations_url":"https://api.github.com/users/mlauster/orgs","repos_url":"https://api.github.com/users/mlauster/repos","events_url":"https://api.github.com/users/mlauster/events{/privacy}","received_events_url":"https://api.github.com/users/mlauster/received_events","type":"User","site_admin":false},"body":"This closes #500 \r\n\r\n@mwetter, could you run the unit tests? Changes in the results should be minimal.","created_at":"2016-09-26T12:42:27Z","updated_at":"2016-09-27T07:20:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be9af24b5999597554e503ee4966085bb95ec055","assignee":{"login":"mwetter","id":1329080,"avatar_url":"https://avatars.githubusercontent.com/u/1329080?v=3","gravatar_id":"","url":"https://api.github.com/users/mwetter","html_url":"https://github.com/mwetter","followers_url":"https://api.github.com/users/mwetter/followers","following_url":"https://api.github.com/users/mwetter/following{/other_user}","gists_url":"https://api.github.com/users/mwetter/gists{/gist_id}","starred_url":"https://api.github.com/users/mwetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwetter/subscriptions","organizations_url":"https://api.github.com/users/mwetter/orgs","repos_url":"https://api.github.com/users/mwetter/repos","events_url":"https://api.github.com/users/mwetter/events{/privacy}","received_events_url":"https://api.github.com/users/mwetter/received_events","type":"User","site_admin":false},"assignees":[{"login":"mwetter","id":1329080,"avatar_url":"https://avatars.githubusercontent.com/u/1329080?v=3","gravatar_id":"","url":"https://api.github.com/users/mwetter","html_url":"https://github.com/mwetter","followers_url":"https://api.github.com/users/mwetter/followers","following_url":"https://api.github.com/users/mwetter/following{/other_user}","gists_url":"https://api.github.com/users/mwetter/gists{/gist_id}","starred_url":"https://api.github.com/users/mwetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwetter/subscriptions","organizations_url":"https://api.github.com/users/mwetter/orgs","repos_url":"https://api.github.com/users/mwetter/repos","events_url":"https://api.github.com/users/mwetter/events{/privacy}","received_events_url":"https://api.github.com/users/mwetter/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/525/commits","review_comments_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/525/comments","review_comment_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/525/comments","statuses_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/statuses/1fb9bd3deb4c5bc422c6367b6b616efbbe8611ec","head":{"label":"iea-annex60:issue500_eqAirTemp","ref":"issue500_eqAirTemp","sha":"1fb9bd3deb4c5bc422c6367b6b616efbbe8611ec","user":{"login":"iea-annex60","id":5323273,"avatar_url":"https://avatars.githubusercontent.com/u/5323273?v=3","gravatar_id":"","url":"https://api.github.com/users/iea-annex60","html_url":"https://github.com/iea-annex60","followers_url":"https://api.github.com/users/iea-annex60/followers","following_url":"https://api.github.com/users/iea-annex60/following{/other_user}","gists_url":"https://api.github.com/users/iea-annex60/gists{/gist_id}","starred_url":"https://api.github.com/users/iea-annex60/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iea-annex60/subscriptions","organizations_url":"https://api.github.com/users/iea-annex60/orgs","repos_url":"https://api.github.com/users/iea-annex60/repos","events_url":"https://api.github.com/users/iea-annex60/events{/privacy}","received_events_url":"https://api.github.com/users/iea-annex60/received_events","type":"Organization","site_admin":false},"repo":{"id":12990303,"name":"modelica-annex60","full_name":"iea-annex60/modelica-annex60","owner":{"login":"iea-annex60","id":5323273,"avatar_url":"https://avatars.githubusercontent.com/u/5323273?v=3","gravatar_id":"","url":"https://api.github.com/users/iea-annex60","html_url":"https://github.com/iea-annex60","followers_url":"https://api.github.com/users/iea-annex60/followers","following_url":"https://api.github.com/users/iea-annex60/following{/other_user}","gists_url":"https://api.github.com/users/iea-annex60/gists{/gist_id}","starred_url":"https://api.github.com/users/iea-annex60/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iea-annex60/subscriptions","organizations_url":"https://api.github.com/users/iea-annex60/orgs","repos_url":"https://api.github.com/users/iea-annex60/repos","events_url":"https://api.github.com/users/iea-annex60/events{/privacy}","received_events_url":"https://api.github.com/users/iea-annex60/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iea-annex60/modelica-annex60","description":"Modelica libraries that are used and/or developed within IEA EBC Annex 60","fork":false,"url":"https://api.github.com/repos/iea-annex60/modelica-annex60","forks_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/forks","keys_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/teams","hooks_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/hooks","issue_events_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/events{/number}","events_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/events","assignees_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/assignees{/user}","branches_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/branches{/branch}","tags_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/tags","blobs_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/git/refs{/sha}","trees_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/statuses/{sha}","languages_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/languages","stargazers_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/stargazers","contributors_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/contributors","subscribers_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/subscribers","subscription_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/subscription","commits_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/commits{/sha}","git_commits_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/git/commits{/sha}","comments_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/comments{/number}","issue_comment_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/comments{/number}","contents_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/contents/{+path}","compare_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/merges","archive_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/downloads","issues_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues{/number}","pulls_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls{/number}","milestones_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/milestones{/number}","notifications_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/labels{/name}","releases_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/releases{/id}","deployments_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/deployments","created_at":"2013-09-21T05:49:03Z","updated_at":"2016-06-22T12:23:17Z","pushed_at":"2016-09-27T06:01:25Z","git_url":"git://github.com/iea-annex60/modelica-annex60.git","ssh_url":"git@github.com:iea-annex60/modelica-annex60.git","clone_url":"https://github.com/iea-annex60/modelica-annex60.git","svn_url":"https://github.com/iea-annex60/modelica-annex60","homepage":null,"size":21933,"stargazers_count":14,"watchers_count":14,"language":"Modelica","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":46,"forks":30,"open_issues":46,"watchers":14,"default_branch":"master"}},"base":{"label":"iea-annex60:master","ref":"master","sha":"88c58b055010d0c1ad733b98310510dee0187f28","user":{"login":"iea-annex60","id":5323273,"avatar_url":"https://avatars.githubusercontent.com/u/5323273?v=3","gravatar_id":"","url":"https://api.github.com/users/iea-annex60","html_url":"https://github.com/iea-annex60","followers_url":"https://api.github.com/users/iea-annex60/followers","following_url":"https://api.github.com/users/iea-annex60/following{/other_user}","gists_url":"https://api.github.com/users/iea-annex60/gists{/gist_id}","starred_url":"https://api.github.com/users/iea-annex60/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iea-annex60/subscriptions","organizations_url":"https://api.github.com/users/iea-annex60/orgs","repos_url":"https://api.github.com/users/iea-annex60/repos","events_url":"https://api.github.com/users/iea-annex60/events{/privacy}","received_events_url":"https://api.github.com/users/iea-annex60/received_events","type":"Organization","site_admin":false},"repo":{"id":12990303,"name":"modelica-annex60","full_name":"iea-annex60/modelica-annex60","owner":{"login":"iea-annex60","id":5323273,"avatar_url":"https://avatars.githubusercontent.com/u/5323273?v=3","gravatar_id":"","url":"https://api.github.com/users/iea-annex60","html_url":"https://github.com/iea-annex60","followers_url":"https://api.github.com/users/iea-annex60/followers","following_url":"https://api.github.com/users/iea-annex60/following{/other_user}","gists_url":"https://api.github.com/users/iea-annex60/gists{/gist_id}","starred_url":"https://api.github.com/users/iea-annex60/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iea-annex60/subscriptions","organizations_url":"https://api.github.com/users/iea-annex60/orgs","repos_url":"https://api.github.com/users/iea-annex60/repos","events_url":"https://api.github.com/users/iea-annex60/events{/privacy}","received_events_url":"https://api.github.com/users/iea-annex60/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iea-annex60/modelica-annex60","description":"Modelica libraries that are used and/or developed within IEA EBC Annex 60","fork":false,"url":"https://api.github.com/repos/iea-annex60/modelica-annex60","forks_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/forks","keys_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/teams","hooks_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/hooks","issue_events_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/events{/number}","events_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/events","assignees_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/assignees{/user}","branches_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/branches{/branch}","tags_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/tags","blobs_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/git/refs{/sha}","trees_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/statuses/{sha}","languages_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/languages","stargazers_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/stargazers","contributors_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/contributors","subscribers_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/subscribers","subscription_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/subscription","commits_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/commits{/sha}","git_commits_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/git/commits{/sha}","comments_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/comments{/number}","issue_comment_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/comments{/number}","contents_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/contents/{+path}","compare_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/merges","archive_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/downloads","issues_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues{/number}","pulls_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls{/number}","milestones_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/milestones{/number}","notifications_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/labels{/name}","releases_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/releases{/id}","deployments_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/deployments","created_at":"2013-09-21T05:49:03Z","updated_at":"2016-06-22T12:23:17Z","pushed_at":"2016-09-27T06:01:25Z","git_url":"git://github.com/iea-annex60/modelica-annex60.git","ssh_url":"git@github.com:iea-annex60/modelica-annex60.git","clone_url":"https://github.com/iea-annex60/modelica-annex60.git","svn_url":"https://github.com/iea-annex60/modelica-annex60","homepage":null,"size":21933,"stargazers_count":14,"watchers_count":14,"language":"Modelica","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":46,"forks":30,"open_issues":46,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/525"},"html":{"href":"https://github.com/iea-annex60/modelica-annex60/pull/525"},"issue":{"href":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/525"},"comments":{"href":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/525/comments"},"review_comments":{"href":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/525/comments"},"review_comment":{"href":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iea-annex60/modelica-annex60/pulls/525/commits"},"statuses":{"href":"https://api.github.com/repos/iea-annex60/modelica-annex60/statuses/1fb9bd3deb4c5bc422c6367b6b616efbbe8611ec"}}}}
{"actor":{"display_login":"mlauster"}}