{"action":"created","issue":{"url":"https://api.github.com/repos/starwing/loki/issues/1","labels_url":"https://api.github.com/repos/starwing/loki/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/starwing/loki/issues/1/comments","events_url":"https://api.github.com/repos/starwing/loki/issues/1/events","html_url":"https://github.com/starwing/loki/pull/1","id":128750998,"number":1,"title":"add log service","user":{"login":"maocl1983","id":5360882,"avatar_url":"https://avatars.githubusercontent.com/u/5360882?v=3","gravatar_id":"","url":"https://api.github.com/users/maocl1983","html_url":"https://github.com/maocl1983","followers_url":"https://api.github.com/users/maocl1983/followers","following_url":"https://api.github.com/users/maocl1983/following{/other_user}","gists_url":"https://api.github.com/users/maocl1983/gists{/gist_id}","starred_url":"https://api.github.com/users/maocl1983/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maocl1983/subscriptions","organizations_url":"https://api.github.com/users/maocl1983/orgs","repos_url":"https://api.github.com/users/maocl1983/repos","events_url":"https://api.github.com/users/maocl1983/events{/privacy}","received_events_url":"https://api.github.com/users/maocl1983/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-26T07:55:04Z","updated_at":"2016-01-26T14:06:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/starwing/loki/pulls/1","html_url":"https://github.com/starwing/loki/pull/1","diff_url":"https://github.com/starwing/loki/pull/1.diff","patch_url":"https://github.com/starwing/loki/pull/1.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/starwing/loki/issues/comments/175030857","html_url":"https://github.com/starwing/loki/pull/1#issuecomment-175030857","issue_url":"https://api.github.com/repos/starwing/loki/issues/1","id":175030857,"user":{"login":"starwing","id":114483,"avatar_url":"https://avatars.githubusercontent.com/u/114483?v=3","gravatar_id":"","url":"https://api.github.com/users/starwing","html_url":"https://github.com/starwing","followers_url":"https://api.github.com/users/starwing/followers","following_url":"https://api.github.com/users/starwing/following{/other_user}","gists_url":"https://api.github.com/users/starwing/gists{/gist_id}","starred_url":"https://api.github.com/users/starwing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starwing/subscriptions","organizations_url":"https://api.github.com/users/starwing/orgs","repos_url":"https://api.github.com/users/starwing/repos","events_url":"https://api.github.com/users/starwing/events{/privacy}","received_events_url":"https://api.github.com/users/starwing/received_events","type":"User","site_admin":false},"created_at":"2016-01-26T14:06:25Z","updated_at":"2016-01-26T14:06:25Z","body":"socket写了一半来看你的代码，问题实在是太多了= =我暂时列一下（就不在代码里面直接review了，下次再给你演示这个功能，现在直接告诉你有哪些问题）\r\n\r\n  - [ ] 宏也要，而且更需要带lk前缀：因为宏无视作用域的特性，所以伤害性更大。\r\n  - [ ] log_name 不需要，接口上直接给大写字母作为log级别即可。\r\n  - [ ] 缩进混乱，缩进需要是四个空格，你要么在Windows下面写，要么把Vim配置好再说。\r\n  - [ ] 注释必须使用 C89 注释，不要使用C++风格的注释！\r\n  - [ ] log_color 应该有一个枚举作为索引。直接写死颜色太难看了，建议读配置。\r\n  - [ ] 直接使用log的主slot，不要新建write slot。\r\n  - [ ] 从 `lk_getconfig` 和 `lk_setconfig` 读取配置的工作未完成。\r\n  - [ ] `fini` 神马鬼= =能写全么？\r\n  - [ ] 目前merge config还是用的缺省值，需要改成 mask\r\n\r\n问题实在是太多了，按照优先级，先把格式问题都改了再提交一份我再来慢慢看吧。开源软件不一样，不只要把活儿做完，还要做的漂亮，这很重要。这一份代码我没法合并。你先改，改完了我教你rebase把历史弄干净了我再合并。就这样。"}}