{"action":"created","comment":{"url":"https://api.github.com/repos/baidu/Paddle/pulls/comments/86706855","pull_request_review_id":7350687,"id":86706855,"diff_hunk":"@@ -12,11 +11,8 @@ do\n     base_protostr=$protostr/$file\n     new_protostr=$protostr/$file.unitest\n     if [ -f $new_protostr ];then\n-        base_md5=`md5sum $base_protostr | awk '{print $1}'`\n-        new_md5=`md5sum $new_protostr | awk '{print $1}'`\n-        if [ $base_md5 != $new_md5 ];then\n-            echo $new_protostr: FAILED!\n-        else\n+        diff $base_protostr $new_protostr -u\n+        if [ $? -eq 0 ];then\n             echo $new_protostr: OK!\n         fi","path":"python/paddle/trainer_config_helpers/tests/configs/run_tests.sh","position":null,"original_position":19,"commit_id":"85a5f444b0e2c10c89775fabade3da52ac23f3df","original_commit_id":"8989322b82eb06570a3facdf7a3c3ea699be9e87","user":{"login":"reyoung","id":728699,"avatar_url":"https://avatars.githubusercontent.com/u/728699?v=3","gravatar_id":"","url":"https://api.github.com/users/reyoung","html_url":"https://github.com/reyoung","followers_url":"https://api.github.com/users/reyoung/followers","following_url":"https://api.github.com/users/reyoung/following{/other_user}","gists_url":"https://api.github.com/users/reyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/reyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reyoung/subscriptions","organizations_url":"https://api.github.com/users/reyoung/orgs","repos_url":"https://api.github.com/users/reyoung/repos","events_url":"https://api.github.com/users/reyoung/events{/privacy}","received_events_url":"https://api.github.com/users/reyoung/received_events","type":"User","site_admin":false},"body":"其实这里直接就退出也无所谓。因为单测一个错了其他的也可以不执行了。\r\n所以`set -e`是ok的。同时，后面的echo OK!也是不必要的了。而且，if [ -f ] 也是不必要的。出错就出错，直接返回一个错误值就好了。\r\n\r\n`diff`不要是 `-u`，直接返回diff的是什么就好了。这样也给运行单测的人一些错误提示。","created_at":"2016-11-07T02:41:16Z","updated_at":"2016-11-07T02:41:22Z","html_url":"https://github.com/baidu/Paddle/pull/363#discussion_r86706855","pull_request_url":"https://api.github.com/repos/baidu/Paddle/pulls/363","_links":{"self":{"href":"https://api.github.com/repos/baidu/Paddle/pulls/comments/86706855"},"html":{"href":"https://github.com/baidu/Paddle/pull/363#discussion_r86706855"},"pull_request":{"href":"https://api.github.com/repos/baidu/Paddle/pulls/363"}}},"pull_request":{"url":"https://api.github.com/repos/baidu/Paddle/pulls/363","id":92449066,"html_url":"https://github.com/baidu/Paddle/pull/363","diff_url":"https://github.com/baidu/Paddle/pull/363.diff","patch_url":"https://github.com/baidu/Paddle/pull/363.patch","issue_url":"https://api.github.com/repos/baidu/Paddle/issues/363","number":363,"state":"open","locked":false,"title":"generate protostr files with current config files","user":{"login":"wen-bo-yang","id":6229206,"avatar_url":"https://avatars.githubusercontent.com/u/6229206?v=3","gravatar_id":"","url":"https://api.github.com/users/wen-bo-yang","html_url":"https://github.com/wen-bo-yang","followers_url":"https://api.github.com/users/wen-bo-yang/followers","following_url":"https://api.github.com/users/wen-bo-yang/following{/other_user}","gists_url":"https://api.github.com/users/wen-bo-yang/gists{/gist_id}","starred_url":"https://api.github.com/users/wen-bo-yang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wen-bo-yang/subscriptions","organizations_url":"https://api.github.com/users/wen-bo-yang/orgs","repos_url":"https://api.github.com/users/wen-bo-yang/repos","events_url":"https://api.github.com/users/wen-bo-yang/events{/privacy}","received_events_url":"https://api.github.com/users/wen-bo-yang/received_events","type":"User","site_admin":false},"body":"1.  Protostr directory added that path is \"Paddle/python/paddle/trainer_config_helpers/tests/configs/protostr\".\r\nThe directory save protostr files that genterate with current config files.\r\n2. I modified check.md5 file and generate_protostr.sh files in order to check value of md5 between xxx.protostr and xxx.protostr.unitest and save new protostr files in protostr directory.","created_at":"2016-11-05T10:22:21Z","updated_at":"2016-11-07T02:41:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6981c5b4ecd006a2717aa42f410d708b1210e5fe","assignee":{"login":"reyoung","id":728699,"avatar_url":"https://avatars.githubusercontent.com/u/728699?v=3","gravatar_id":"","url":"https://api.github.com/users/reyoung","html_url":"https://github.com/reyoung","followers_url":"https://api.github.com/users/reyoung/followers","following_url":"https://api.github.com/users/reyoung/following{/other_user}","gists_url":"https://api.github.com/users/reyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/reyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reyoung/subscriptions","organizations_url":"https://api.github.com/users/reyoung/orgs","repos_url":"https://api.github.com/users/reyoung/repos","events_url":"https://api.github.com/users/reyoung/events{/privacy}","received_events_url":"https://api.github.com/users/reyoung/received_events","type":"User","site_admin":false},"assignees":[{"login":"reyoung","id":728699,"avatar_url":"https://avatars.githubusercontent.com/u/728699?v=3","gravatar_id":"","url":"https://api.github.com/users/reyoung","html_url":"https://github.com/reyoung","followers_url":"https://api.github.com/users/reyoung/followers","following_url":"https://api.github.com/users/reyoung/following{/other_user}","gists_url":"https://api.github.com/users/reyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/reyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reyoung/subscriptions","organizations_url":"https://api.github.com/users/reyoung/orgs","repos_url":"https://api.github.com/users/reyoung/repos","events_url":"https://api.github.com/users/reyoung/events{/privacy}","received_events_url":"https://api.github.com/users/reyoung/received_events","type":"User","site_admin":false},{"login":"luotao1","id":6836917,"avatar_url":"https://avatars.githubusercontent.com/u/6836917?v=3","gravatar_id":"","url":"https://api.github.com/users/luotao1","html_url":"https://github.com/luotao1","followers_url":"https://api.github.com/users/luotao1/followers","following_url":"https://api.github.com/users/luotao1/following{/other_user}","gists_url":"https://api.github.com/users/luotao1/gists{/gist_id}","starred_url":"https://api.github.com/users/luotao1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luotao1/subscriptions","organizations_url":"https://api.github.com/users/luotao1/orgs","repos_url":"https://api.github.com/users/luotao1/repos","events_url":"https://api.github.com/users/luotao1/events{/privacy}","received_events_url":"https://api.github.com/users/luotao1/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/baidu/Paddle/pulls/363/commits","review_comments_url":"https://api.github.com/repos/baidu/Paddle/pulls/363/comments","review_comment_url":"https://api.github.com/repos/baidu/Paddle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/baidu/Paddle/issues/363/comments","statuses_url":"https://api.github.com/repos/baidu/Paddle/statuses/85a5f444b0e2c10c89775fabade3da52ac23f3df","head":{"label":"wen-bo-yang:develop","ref":"develop","sha":"85a5f444b0e2c10c89775fabade3da52ac23f3df","user":{"login":"wen-bo-yang","id":6229206,"avatar_url":"https://avatars.githubusercontent.com/u/6229206?v=3","gravatar_id":"","url":"https://api.github.com/users/wen-bo-yang","html_url":"https://github.com/wen-bo-yang","followers_url":"https://api.github.com/users/wen-bo-yang/followers","following_url":"https://api.github.com/users/wen-bo-yang/following{/other_user}","gists_url":"https://api.github.com/users/wen-bo-yang/gists{/gist_id}","starred_url":"https://api.github.com/users/wen-bo-yang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wen-bo-yang/subscriptions","organizations_url":"https://api.github.com/users/wen-bo-yang/orgs","repos_url":"https://api.github.com/users/wen-bo-yang/repos","events_url":"https://api.github.com/users/wen-bo-yang/events{/privacy}","received_events_url":"https://api.github.com/users/wen-bo-yang/received_events","type":"User","site_admin":false},"repo":{"id":67660229,"name":"Paddle","full_name":"wen-bo-yang/Paddle","owner":{"login":"wen-bo-yang","id":6229206,"avatar_url":"https://avatars.githubusercontent.com/u/6229206?v=3","gravatar_id":"","url":"https://api.github.com/users/wen-bo-yang","html_url":"https://github.com/wen-bo-yang","followers_url":"https://api.github.com/users/wen-bo-yang/followers","following_url":"https://api.github.com/users/wen-bo-yang/following{/other_user}","gists_url":"https://api.github.com/users/wen-bo-yang/gists{/gist_id}","starred_url":"https://api.github.com/users/wen-bo-yang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wen-bo-yang/subscriptions","organizations_url":"https://api.github.com/users/wen-bo-yang/orgs","repos_url":"https://api.github.com/users/wen-bo-yang/repos","events_url":"https://api.github.com/users/wen-bo-yang/events{/privacy}","received_events_url":"https://api.github.com/users/wen-bo-yang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wen-bo-yang/Paddle","description":"PArallel Distributed Deep LEarning","fork":true,"url":"https://api.github.com/repos/wen-bo-yang/Paddle","forks_url":"https://api.github.com/repos/wen-bo-yang/Paddle/forks","keys_url":"https://api.github.com/repos/wen-bo-yang/Paddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wen-bo-yang/Paddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wen-bo-yang/Paddle/teams","hooks_url":"https://api.github.com/repos/wen-bo-yang/Paddle/hooks","issue_events_url":"https://api.github.com/repos/wen-bo-yang/Paddle/issues/events{/number}","events_url":"https://api.github.com/repos/wen-bo-yang/Paddle/events","assignees_url":"https://api.github.com/repos/wen-bo-yang/Paddle/assignees{/user}","branches_url":"https://api.github.com/repos/wen-bo-yang/Paddle/branches{/branch}","tags_url":"https://api.github.com/repos/wen-bo-yang/Paddle/tags","blobs_url":"https://api.github.com/repos/wen-bo-yang/Paddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wen-bo-yang/Paddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wen-bo-yang/Paddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/wen-bo-yang/Paddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wen-bo-yang/Paddle/statuses/{sha}","languages_url":"https://api.github.com/repos/wen-bo-yang/Paddle/languages","stargazers_url":"https://api.github.com/repos/wen-bo-yang/Paddle/stargazers","contributors_url":"https://api.github.com/repos/wen-bo-yang/Paddle/contributors","subscribers_url":"https://api.github.com/repos/wen-bo-yang/Paddle/subscribers","subscription_url":"https://api.github.com/repos/wen-bo-yang/Paddle/subscription","commits_url":"https://api.github.com/repos/wen-bo-yang/Paddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/wen-bo-yang/Paddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/wen-bo-yang/Paddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/wen-bo-yang/Paddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/wen-bo-yang/Paddle/contents/{+path}","compare_url":"https://api.github.com/repos/wen-bo-yang/Paddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wen-bo-yang/Paddle/merges","archive_url":"https://api.github.com/repos/wen-bo-yang/Paddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wen-bo-yang/Paddle/downloads","issues_url":"https://api.github.com/repos/wen-bo-yang/Paddle/issues{/number}","pulls_url":"https://api.github.com/repos/wen-bo-yang/Paddle/pulls{/number}","milestones_url":"https://api.github.com/repos/wen-bo-yang/Paddle/milestones{/number}","notifications_url":"https://api.github.com/repos/wen-bo-yang/Paddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wen-bo-yang/Paddle/labels{/name}","releases_url":"https://api.github.com/repos/wen-bo-yang/Paddle/releases{/id}","deployments_url":"https://api.github.com/repos/wen-bo-yang/Paddle/deployments","created_at":"2016-09-08T02:17:20Z","updated_at":"2016-09-08T02:17:22Z","pushed_at":"2016-11-06T06:53:34Z","git_url":"git://github.com/wen-bo-yang/Paddle.git","ssh_url":"git@github.com:wen-bo-yang/Paddle.git","clone_url":"https://github.com/wen-bo-yang/Paddle.git","svn_url":"https://github.com/wen-bo-yang/Paddle","homepage":"http://www.paddlepaddle.org/","size":8959,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"baidu:develop","ref":"develop","sha":"93e4d0cce6d3048f77aa46dc9d4ee5c3fb777d0c","user":{"login":"baidu","id":13245940,"avatar_url":"https://avatars.githubusercontent.com/u/13245940?v=3","gravatar_id":"","url":"https://api.github.com/users/baidu","html_url":"https://github.com/baidu","followers_url":"https://api.github.com/users/baidu/followers","following_url":"https://api.github.com/users/baidu/following{/other_user}","gists_url":"https://api.github.com/users/baidu/gists{/gist_id}","starred_url":"https://api.github.com/users/baidu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baidu/subscriptions","organizations_url":"https://api.github.com/users/baidu/orgs","repos_url":"https://api.github.com/users/baidu/repos","events_url":"https://api.github.com/users/baidu/events{/privacy}","received_events_url":"https://api.github.com/users/baidu/received_events","type":"Organization","site_admin":false},"repo":{"id":65711522,"name":"Paddle","full_name":"baidu/Paddle","owner":{"login":"baidu","id":13245940,"avatar_url":"https://avatars.githubusercontent.com/u/13245940?v=3","gravatar_id":"","url":"https://api.github.com/users/baidu","html_url":"https://github.com/baidu","followers_url":"https://api.github.com/users/baidu/followers","following_url":"https://api.github.com/users/baidu/following{/other_user}","gists_url":"https://api.github.com/users/baidu/gists{/gist_id}","starred_url":"https://api.github.com/users/baidu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baidu/subscriptions","organizations_url":"https://api.github.com/users/baidu/orgs","repos_url":"https://api.github.com/users/baidu/repos","events_url":"https://api.github.com/users/baidu/events{/privacy}","received_events_url":"https://api.github.com/users/baidu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/baidu/Paddle","description":"PArallel Distributed Deep LEarning","fork":false,"url":"https://api.github.com/repos/baidu/Paddle","forks_url":"https://api.github.com/repos/baidu/Paddle/forks","keys_url":"https://api.github.com/repos/baidu/Paddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baidu/Paddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baidu/Paddle/teams","hooks_url":"https://api.github.com/repos/baidu/Paddle/hooks","issue_events_url":"https://api.github.com/repos/baidu/Paddle/issues/events{/number}","events_url":"https://api.github.com/repos/baidu/Paddle/events","assignees_url":"https://api.github.com/repos/baidu/Paddle/assignees{/user}","branches_url":"https://api.github.com/repos/baidu/Paddle/branches{/branch}","tags_url":"https://api.github.com/repos/baidu/Paddle/tags","blobs_url":"https://api.github.com/repos/baidu/Paddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baidu/Paddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baidu/Paddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/baidu/Paddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baidu/Paddle/statuses/{sha}","languages_url":"https://api.github.com/repos/baidu/Paddle/languages","stargazers_url":"https://api.github.com/repos/baidu/Paddle/stargazers","contributors_url":"https://api.github.com/repos/baidu/Paddle/contributors","subscribers_url":"https://api.github.com/repos/baidu/Paddle/subscribers","subscription_url":"https://api.github.com/repos/baidu/Paddle/subscription","commits_url":"https://api.github.com/repos/baidu/Paddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/baidu/Paddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/baidu/Paddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/baidu/Paddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/baidu/Paddle/contents/{+path}","compare_url":"https://api.github.com/repos/baidu/Paddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baidu/Paddle/merges","archive_url":"https://api.github.com/repos/baidu/Paddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baidu/Paddle/downloads","issues_url":"https://api.github.com/repos/baidu/Paddle/issues{/number}","pulls_url":"https://api.github.com/repos/baidu/Paddle/pulls{/number}","milestones_url":"https://api.github.com/repos/baidu/Paddle/milestones{/number}","notifications_url":"https://api.github.com/repos/baidu/Paddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baidu/Paddle/labels{/name}","releases_url":"https://api.github.com/repos/baidu/Paddle/releases{/id}","deployments_url":"https://api.github.com/repos/baidu/Paddle/deployments","created_at":"2016-08-15T06:59:08Z","updated_at":"2016-11-07T00:49:48Z","pushed_at":"2016-11-06T06:53:34Z","git_url":"git://github.com/baidu/Paddle.git","ssh_url":"git@github.com:baidu/Paddle.git","clone_url":"https://github.com/baidu/Paddle.git","svn_url":"https://github.com/baidu/Paddle","homepage":"http://www.paddlepaddle.org/","size":18193,"stargazers_count":3725,"watchers_count":3725,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":845,"mirror_url":null,"open_issues_count":89,"forks":845,"open_issues":89,"watchers":3725,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/baidu/Paddle/pulls/363"},"html":{"href":"https://github.com/baidu/Paddle/pull/363"},"issue":{"href":"https://api.github.com/repos/baidu/Paddle/issues/363"},"comments":{"href":"https://api.github.com/repos/baidu/Paddle/issues/363/comments"},"review_comments":{"href":"https://api.github.com/repos/baidu/Paddle/pulls/363/comments"},"review_comment":{"href":"https://api.github.com/repos/baidu/Paddle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/baidu/Paddle/pulls/363/commits"},"statuses":{"href":"https://api.github.com/repos/baidu/Paddle/statuses/85a5f444b0e2c10c89775fabade3da52ac23f3df"}}}}
{"actor":{"display_login":"reyoung"}}