{"action":"opened","number":604,"pull_request":{"url":"https://api.github.com/repos/nest/nest-simulator/pulls/604","id":99229089,"html_url":"https://github.com/nest/nest-simulator/pull/604","diff_url":"https://github.com/nest/nest-simulator/pull/604.diff","patch_url":"https://github.com/nest/nest-simulator/pull/604.patch","issue_url":"https://api.github.com/repos/nest/nest-simulator/issues/604","number":604,"state":"open","locked":false,"title":"Fixed get targets for structural plasticity","user":{"login":"sdiazpier","id":12412962,"avatar_url":"https://avatars.githubusercontent.com/u/12412962?v=3","gravatar_id":"","url":"https://api.github.com/users/sdiazpier","html_url":"https://github.com/sdiazpier","followers_url":"https://api.github.com/users/sdiazpier/followers","following_url":"https://api.github.com/users/sdiazpier/following{/other_user}","gists_url":"https://api.github.com/users/sdiazpier/gists{/gist_id}","starred_url":"https://api.github.com/users/sdiazpier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdiazpier/subscriptions","organizations_url":"https://api.github.com/users/sdiazpier/orgs","repos_url":"https://api.github.com/users/sdiazpier/repos","events_url":"https://api.github.com/users/sdiazpier/events{/privacy}","received_events_url":"https://api.github.com/users/sdiazpier/received_events","type":"User","site_admin":false},"body":"This PR addresses issue #576 and issue #589 and substitutes PRs #582 and #584 and #595 by adding a new get targets function which checks if the target has defined synaptic elements before adding them to the possible targets list for deletion. After a deep analysis, I realized that the list of targets only cares for the synapse model and not for the existence of the synaptic elements in the target node. Usually a new synapse model is created for each synaptic elements pair. However this is not enforced in any way in the code and when one uses the same synapse model for all connections, this error will arise.\r\nChecking if the node contains the desired synaptic elements declared solves this problem.\r\nThank you to @sanjayankur31 and @jakobj who have been working hard to solve and understand this issue. This PR is the result of our accumulated efforts. ","created_at":"2016-12-23T11:04:57Z","updated_at":"2016-12-23T11:04:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nest/nest-simulator/pulls/604/commits","review_comments_url":"https://api.github.com/repos/nest/nest-simulator/pulls/604/comments","review_comment_url":"https://api.github.com/repos/nest/nest-simulator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nest/nest-simulator/issues/604/comments","statuses_url":"https://api.github.com/repos/nest/nest-simulator/statuses/ba9b2ddb97e9f3ea0a4c0d4360c4df6840e60029","head":{"label":"sdiazpier:sp_mpi_targetsbug","ref":"sp_mpi_targetsbug","sha":"ba9b2ddb97e9f3ea0a4c0d4360c4df6840e60029","user":{"login":"sdiazpier","id":12412962,"avatar_url":"https://avatars.githubusercontent.com/u/12412962?v=3","gravatar_id":"","url":"https://api.github.com/users/sdiazpier","html_url":"https://github.com/sdiazpier","followers_url":"https://api.github.com/users/sdiazpier/followers","following_url":"https://api.github.com/users/sdiazpier/following{/other_user}","gists_url":"https://api.github.com/users/sdiazpier/gists{/gist_id}","starred_url":"https://api.github.com/users/sdiazpier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdiazpier/subscriptions","organizations_url":"https://api.github.com/users/sdiazpier/orgs","repos_url":"https://api.github.com/users/sdiazpier/repos","events_url":"https://api.github.com/users/sdiazpier/events{/privacy}","received_events_url":"https://api.github.com/users/sdiazpier/received_events","type":"User","site_admin":false},"repo":{"id":35492687,"name":"nest-simulator","full_name":"sdiazpier/nest-simulator","owner":{"login":"sdiazpier","id":12412962,"avatar_url":"https://avatars.githubusercontent.com/u/12412962?v=3","gravatar_id":"","url":"https://api.github.com/users/sdiazpier","html_url":"https://github.com/sdiazpier","followers_url":"https://api.github.com/users/sdiazpier/followers","following_url":"https://api.github.com/users/sdiazpier/following{/other_user}","gists_url":"https://api.github.com/users/sdiazpier/gists{/gist_id}","starred_url":"https://api.github.com/users/sdiazpier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdiazpier/subscriptions","organizations_url":"https://api.github.com/users/sdiazpier/orgs","repos_url":"https://api.github.com/users/sdiazpier/repos","events_url":"https://api.github.com/users/sdiazpier/events{/privacy}","received_events_url":"https://api.github.com/users/sdiazpier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sdiazpier/nest-simulator","description":"The NEST simulator","fork":true,"url":"https://api.github.com/repos/sdiazpier/nest-simulator","forks_url":"https://api.github.com/repos/sdiazpier/nest-simulator/forks","keys_url":"https://api.github.com/repos/sdiazpier/nest-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdiazpier/nest-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdiazpier/nest-simulator/teams","hooks_url":"https://api.github.com/repos/sdiazpier/nest-simulator/hooks","issue_events_url":"https://api.github.com/repos/sdiazpier/nest-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/sdiazpier/nest-simulator/events","assignees_url":"https://api.github.com/repos/sdiazpier/nest-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/sdiazpier/nest-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/sdiazpier/nest-simulator/tags","blobs_url":"https://api.github.com/repos/sdiazpier/nest-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdiazpier/nest-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdiazpier/nest-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdiazpier/nest-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdiazpier/nest-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/sdiazpier/nest-simulator/languages","stargazers_url":"https://api.github.com/repos/sdiazpier/nest-simulator/stargazers","contributors_url":"https://api.github.com/repos/sdiazpier/nest-simulator/contributors","subscribers_url":"https://api.github.com/repos/sdiazpier/nest-simulator/subscribers","subscription_url":"https://api.github.com/repos/sdiazpier/nest-simulator/subscription","commits_url":"https://api.github.com/repos/sdiazpier/nest-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdiazpier/nest-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdiazpier/nest-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdiazpier/nest-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdiazpier/nest-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/sdiazpier/nest-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdiazpier/nest-simulator/merges","archive_url":"https://api.github.com/repos/sdiazpier/nest-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdiazpier/nest-simulator/downloads","issues_url":"https://api.github.com/repos/sdiazpier/nest-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/sdiazpier/nest-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/sdiazpier/nest-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/sdiazpier/nest-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdiazpier/nest-simulator/labels{/name}","releases_url":"https://api.github.com/repos/sdiazpier/nest-simulator/releases{/id}","deployments_url":"https://api.github.com/repos/sdiazpier/nest-simulator/deployments","created_at":"2015-05-12T14:21:49Z","updated_at":"2016-01-29T15:43:41Z","pushed_at":"2016-12-23T10:28:33Z","git_url":"git://github.com/sdiazpier/nest-simulator.git","ssh_url":"git@github.com:sdiazpier/nest-simulator.git","clone_url":"https://github.com/sdiazpier/nest-simulator.git","svn_url":"https://github.com/sdiazpier/nest-simulator","homepage":null,"size":16699,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nest:master","ref":"master","sha":"90e362ad6f69fc3b65ee3dc8f736f2e57ff78e7f","user":{"login":"nest","id":2377019,"avatar_url":"https://avatars.githubusercontent.com/u/2377019?v=3","gravatar_id":"","url":"https://api.github.com/users/nest","html_url":"https://github.com/nest","followers_url":"https://api.github.com/users/nest/followers","following_url":"https://api.github.com/users/nest/following{/other_user}","gists_url":"https://api.github.com/users/nest/gists{/gist_id}","starred_url":"https://api.github.com/users/nest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nest/subscriptions","organizations_url":"https://api.github.com/users/nest/orgs","repos_url":"https://api.github.com/users/nest/repos","events_url":"https://api.github.com/users/nest/events{/privacy}","received_events_url":"https://api.github.com/users/nest/received_events","type":"Organization","site_admin":false},"repo":{"id":33933892,"name":"nest-simulator","full_name":"nest/nest-simulator","owner":{"login":"nest","id":2377019,"avatar_url":"https://avatars.githubusercontent.com/u/2377019?v=3","gravatar_id":"","url":"https://api.github.com/users/nest","html_url":"https://github.com/nest","followers_url":"https://api.github.com/users/nest/followers","following_url":"https://api.github.com/users/nest/following{/other_user}","gists_url":"https://api.github.com/users/nest/gists{/gist_id}","starred_url":"https://api.github.com/users/nest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nest/subscriptions","organizations_url":"https://api.github.com/users/nest/orgs","repos_url":"https://api.github.com/users/nest/repos","events_url":"https://api.github.com/users/nest/events{/privacy}","received_events_url":"https://api.github.com/users/nest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nest/nest-simulator","description":"The NEST simulator","fork":false,"url":"https://api.github.com/repos/nest/nest-simulator","forks_url":"https://api.github.com/repos/nest/nest-simulator/forks","keys_url":"https://api.github.com/repos/nest/nest-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nest/nest-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nest/nest-simulator/teams","hooks_url":"https://api.github.com/repos/nest/nest-simulator/hooks","issue_events_url":"https://api.github.com/repos/nest/nest-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/nest/nest-simulator/events","assignees_url":"https://api.github.com/repos/nest/nest-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/nest/nest-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/nest/nest-simulator/tags","blobs_url":"https://api.github.com/repos/nest/nest-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nest/nest-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nest/nest-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/nest/nest-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nest/nest-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/nest/nest-simulator/languages","stargazers_url":"https://api.github.com/repos/nest/nest-simulator/stargazers","contributors_url":"https://api.github.com/repos/nest/nest-simulator/contributors","subscribers_url":"https://api.github.com/repos/nest/nest-simulator/subscribers","subscription_url":"https://api.github.com/repos/nest/nest-simulator/subscription","commits_url":"https://api.github.com/repos/nest/nest-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/nest/nest-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/nest/nest-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/nest/nest-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/nest/nest-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/nest/nest-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nest/nest-simulator/merges","archive_url":"https://api.github.com/repos/nest/nest-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nest/nest-simulator/downloads","issues_url":"https://api.github.com/repos/nest/nest-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/nest/nest-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/nest/nest-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/nest/nest-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nest/nest-simulator/labels{/name}","releases_url":"https://api.github.com/repos/nest/nest-simulator/releases{/id}","deployments_url":"https://api.github.com/repos/nest/nest-simulator/deployments","created_at":"2015-04-14T13:39:12Z","updated_at":"2016-12-17T00:12:47Z","pushed_at":"2016-12-22T22:21:43Z","git_url":"git://github.com/nest/nest-simulator.git","ssh_url":"git@github.com:nest/nest-simulator.git","clone_url":"https://github.com/nest/nest-simulator.git","svn_url":"https://github.com/nest/nest-simulator","homepage":null,"size":28191,"stargazers_count":96,"watchers_count":96,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":98,"mirror_url":null,"open_issues_count":173,"forks":98,"open_issues":173,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/604"},"html":{"href":"https://github.com/nest/nest-simulator/pull/604"},"issue":{"href":"https://api.github.com/repos/nest/nest-simulator/issues/604"},"comments":{"href":"https://api.github.com/repos/nest/nest-simulator/issues/604/comments"},"review_comments":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/604/comments"},"review_comment":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/604/commits"},"statuses":{"href":"https://api.github.com/repos/nest/nest-simulator/statuses/ba9b2ddb97e9f3ea0a4c0d4360c4df6840e60029"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":144,"deletions":20,"changed_files":4}}
{"actor":{"display_login":"sdiazpier"}}