{"action":"created","issue":{"url":"https://api.github.com/repos/bumptech/glide/issues/1274","repository_url":"https://api.github.com/repos/bumptech/glide","labels_url":"https://api.github.com/repos/bumptech/glide/issues/1274/labels{/name}","comments_url":"https://api.github.com/repos/bumptech/glide/issues/1274/comments","events_url":"https://api.github.com/repos/bumptech/glide/issues/1274/events","html_url":"https://github.com/bumptech/glide/pull/1274","id":161004850,"number":1274,"title":"Make the EngineReourceFactory of EngineJob configurable","user":{"login":"JektonLuo","id":7709976,"avatar_url":"https://avatars.githubusercontent.com/u/7709976?v=3","gravatar_id":"","url":"https://api.github.com/users/JektonLuo","html_url":"https://github.com/JektonLuo","followers_url":"https://api.github.com/users/JektonLuo/followers","following_url":"https://api.github.com/users/JektonLuo/following{/other_user}","gists_url":"https://api.github.com/users/JektonLuo/gists{/gist_id}","starred_url":"https://api.github.com/users/JektonLuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JektonLuo/subscriptions","organizations_url":"https://api.github.com/users/JektonLuo/orgs","repos_url":"https://api.github.com/users/JektonLuo/repos","events_url":"https://api.github.com/users/JektonLuo/events{/privacy}","received_events_url":"https://api.github.com/users/JektonLuo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bumptech/glide/labels/enhancement","name":"enhancement","color":"207de5"},{"url":"https://api.github.com/repos/bumptech/glide/labels/v4","name":"v4","color":"fbca04"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/bumptech/glide/milestones/5","html_url":"https://github.com/bumptech/glide/milestones/4.0","labels_url":"https://api.github.com/repos/bumptech/glide/milestones/5/labels","id":812599,"number":5,"title":"4.0","description":"Features/bugs that can only be fixed with breaking changes.","creator":{"login":"sjudd","id":1627211,"avatar_url":"https://avatars.githubusercontent.com/u/1627211?v=3","gravatar_id":"","url":"https://api.github.com/users/sjudd","html_url":"https://github.com/sjudd","followers_url":"https://api.github.com/users/sjudd/followers","following_url":"https://api.github.com/users/sjudd/following{/other_user}","gists_url":"https://api.github.com/users/sjudd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjudd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjudd/subscriptions","organizations_url":"https://api.github.com/users/sjudd/orgs","repos_url":"https://api.github.com/users/sjudd/repos","events_url":"https://api.github.com/users/sjudd/events{/privacy}","received_events_url":"https://api.github.com/users/sjudd/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":61,"state":"open","created_at":"2014-10-03T13:30:57Z","updated_at":"2016-06-19T00:28:46Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-06-18T03:42:12Z","updated_at":"2016-06-19T00:28:46Z","closed_at":"2016-06-19T00:28:46Z","pull_request":{"url":"https://api.github.com/repos/bumptech/glide/pulls/1274","html_url":"https://github.com/bumptech/glide/pull/1274","diff_url":"https://github.com/bumptech/glide/pull/1274.diff","patch_url":"https://github.com/bumptech/glide/pull/1274.patch"},"body":"<!-- Make sure you've run `gradlew clean check jar assemble` before commit. -->\r\n<!-- Don't forget that you can always force push to your private branches to make changes. -->\r\n<!-- Please make sure there are no weird commits in the change set by rebasing to latest upstream. -->\r\n<!-- Please squash typo/checkstyle/review fix commits into the base commit. -->\r\n\r\n## Description\r\nIf the `EngineReourceFactory` is a concrete class, there is not way\r\nto customize a new factory class, which makes the parameter `engineResourceFactory`\r\nin `EngineJob`'s ctor useless.\r\nBy changing `EngineReourceFactory` to a `interface`, we can easily improve it."},"comment":{"url":"https://api.github.com/repos/bumptech/glide/issues/comments/226972533","html_url":"https://github.com/bumptech/glide/pull/1274#issuecomment-226972533","issue_url":"https://api.github.com/repos/bumptech/glide/issues/1274","id":226972533,"user":{"login":"JektonLuo","id":7709976,"avatar_url":"https://avatars.githubusercontent.com/u/7709976?v=3","gravatar_id":"","url":"https://api.github.com/users/JektonLuo","html_url":"https://github.com/JektonLuo","followers_url":"https://api.github.com/users/JektonLuo/followers","following_url":"https://api.github.com/users/JektonLuo/following{/other_user}","gists_url":"https://api.github.com/users/JektonLuo/gists{/gist_id}","starred_url":"https://api.github.com/users/JektonLuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JektonLuo/subscriptions","organizations_url":"https://api.github.com/users/JektonLuo/orgs","repos_url":"https://api.github.com/users/JektonLuo/repos","events_url":"https://api.github.com/users/JektonLuo/events{/privacy}","received_events_url":"https://api.github.com/users/JektonLuo/received_events","type":"User","site_admin":false},"created_at":"2016-06-19T00:28:46Z","updated_at":"2016-06-19T00:28:46Z","body":"Since there is the ctor and I think it might used in some case in the framework sooner or later."}}
{"actor":{"display_login":"JektonLuo"}}