{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos/pulls/comments/77694531","id":77694531,"diff_hunk":"@@ -10,7 +10,7 @@ set -o errexit -o nounset -o pipefail\n : ${VIRTUAL_ENV?\"Must be run in a python virtual environment\"}\n \n # Install the latest version of pip\n-pip install pip==8.1.2\n+pip install --upgrade pip","path":"prep_local","position":5,"original_position":5,"commit_id":"9d80624859a21bf81955495e6834d854ee5f39da","original_commit_id":"9d80624859a21bf81955495e6834d854ee5f39da","user":{"login":"orsenthil","id":332330,"avatar_url":"https://avatars.githubusercontent.com/u/332330?v=3","gravatar_id":"","url":"https://api.github.com/users/orsenthil","html_url":"https://github.com/orsenthil","followers_url":"https://api.github.com/users/orsenthil/followers","following_url":"https://api.github.com/users/orsenthil/following{/other_user}","gists_url":"https://api.github.com/users/orsenthil/gists{/gist_id}","starred_url":"https://api.github.com/users/orsenthil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orsenthil/subscriptions","organizations_url":"https://api.github.com/users/orsenthil/orgs","repos_url":"https://api.github.com/users/orsenthil/repos","events_url":"https://api.github.com/users/orsenthil/events{/privacy}","received_events_url":"https://api.github.com/users/orsenthil/received_events","type":"User","site_admin":false},"body":"This is just looks like an ugly \"pip\" issue, that got fixed from 8.1.1 to 8.1.2\r\n\r\nhttps://github.com/pypa/pip/commit/8e236dd6a09bd2f70f9d4fc886da8c354d4c58f2#diff-297395da5417032dc5d0738a1fc7e136L1002\r\n\r\nFor pip itself, I think.\r\n\r\n`pip install --upgrade pip`\r\n\r\nis a reasonable solution.\r\n\r\nFor other packages, we will require the hardcoded version.\r\n\r\nSo, this change looks good to me.\r\n\r\nIf you want to be conservative, remove the `pip install pip==8.1.2` line itself and we can upgrade pip in the buildinfo.json.  \r\nSince this is a bug in pip, these are the two only two possible options for us.\r\n\r\n","created_at":"2016-09-06T18:43:07Z","updated_at":"2016-09-06T18:43:07Z","html_url":"https://github.com/dcos/dcos/pull/603#discussion_r77694531","pull_request_url":"https://api.github.com/repos/dcos/dcos/pulls/603","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments/77694531"},"html":{"href":"https://github.com/dcos/dcos/pull/603#discussion_r77694531"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos/pulls/603"}}},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos/pulls/603","id":83141030,"html_url":"https://github.com/dcos/dcos/pull/603","diff_url":"https://github.com/dcos/dcos/pull/603.diff","patch_url":"https://github.com/dcos/dcos/pull/603.patch","issue_url":"https://api.github.com/repos/dcos/dcos/issues/603","number":603,"state":"open","locked":false,"title":"Make DCOS build work on OS X","user":{"login":"aaronjwood","id":446283,"avatar_url":"https://avatars.githubusercontent.com/u/446283?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronjwood","html_url":"https://github.com/aaronjwood","followers_url":"https://api.github.com/users/aaronjwood/followers","following_url":"https://api.github.com/users/aaronjwood/following{/other_user}","gists_url":"https://api.github.com/users/aaronjwood/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronjwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronjwood/subscriptions","organizations_url":"https://api.github.com/users/aaronjwood/orgs","repos_url":"https://api.github.com/users/aaronjwood/repos","events_url":"https://api.github.com/users/aaronjwood/events{/privacy}","received_events_url":"https://api.github.com/users/aaronjwood/received_events","type":"User","site_admin":false},"body":"The changes here should make `./build-local.sh` work on OS X. I've updated the `README.md` as well to reflect what is needed on OS X.\r\n\r\nI'd like to hear everyone's feedback on this and see if it's something that would be worthwhile to merge.","created_at":"2016-08-29T18:06:32Z","updated_at":"2016-09-06T18:43:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e709bfe3eae162a75ed4a180da0ad499c5c0714a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos/pulls/603/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos/pulls/603/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos/issues/603/comments","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/9d80624859a21bf81955495e6834d854ee5f39da","head":{"label":"aaronjwood:osx","ref":"osx","sha":"9d80624859a21bf81955495e6834d854ee5f39da","user":{"login":"aaronjwood","id":446283,"avatar_url":"https://avatars.githubusercontent.com/u/446283?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronjwood","html_url":"https://github.com/aaronjwood","followers_url":"https://api.github.com/users/aaronjwood/followers","following_url":"https://api.github.com/users/aaronjwood/following{/other_user}","gists_url":"https://api.github.com/users/aaronjwood/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronjwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronjwood/subscriptions","organizations_url":"https://api.github.com/users/aaronjwood/orgs","repos_url":"https://api.github.com/users/aaronjwood/repos","events_url":"https://api.github.com/users/aaronjwood/events{/privacy}","received_events_url":"https://api.github.com/users/aaronjwood/received_events","type":"User","site_admin":false},"repo":{"id":66664874,"name":"dcos","full_name":"aaronjwood/dcos","owner":{"login":"aaronjwood","id":446283,"avatar_url":"https://avatars.githubusercontent.com/u/446283?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronjwood","html_url":"https://github.com/aaronjwood","followers_url":"https://api.github.com/users/aaronjwood/followers","following_url":"https://api.github.com/users/aaronjwood/following{/other_user}","gists_url":"https://api.github.com/users/aaronjwood/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronjwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronjwood/subscriptions","organizations_url":"https://api.github.com/users/aaronjwood/orgs","repos_url":"https://api.github.com/users/aaronjwood/repos","events_url":"https://api.github.com/users/aaronjwood/events{/privacy}","received_events_url":"https://api.github.com/users/aaronjwood/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aaronjwood/dcos","description":"DC/OS Build and Release tools","fork":true,"url":"https://api.github.com/repos/aaronjwood/dcos","forks_url":"https://api.github.com/repos/aaronjwood/dcos/forks","keys_url":"https://api.github.com/repos/aaronjwood/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaronjwood/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaronjwood/dcos/teams","hooks_url":"https://api.github.com/repos/aaronjwood/dcos/hooks","issue_events_url":"https://api.github.com/repos/aaronjwood/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/aaronjwood/dcos/events","assignees_url":"https://api.github.com/repos/aaronjwood/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/aaronjwood/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/aaronjwood/dcos/tags","blobs_url":"https://api.github.com/repos/aaronjwood/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaronjwood/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaronjwood/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaronjwood/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaronjwood/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/aaronjwood/dcos/languages","stargazers_url":"https://api.github.com/repos/aaronjwood/dcos/stargazers","contributors_url":"https://api.github.com/repos/aaronjwood/dcos/contributors","subscribers_url":"https://api.github.com/repos/aaronjwood/dcos/subscribers","subscription_url":"https://api.github.com/repos/aaronjwood/dcos/subscription","commits_url":"https://api.github.com/repos/aaronjwood/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaronjwood/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaronjwood/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaronjwood/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaronjwood/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/aaronjwood/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaronjwood/dcos/merges","archive_url":"https://api.github.com/repos/aaronjwood/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaronjwood/dcos/downloads","issues_url":"https://api.github.com/repos/aaronjwood/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/aaronjwood/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/aaronjwood/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/aaronjwood/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaronjwood/dcos/labels{/name}","releases_url":"https://api.github.com/repos/aaronjwood/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/aaronjwood/dcos/deployments","created_at":"2016-08-26T17:00:30Z","updated_at":"2016-08-26T17:00:31Z","pushed_at":"2016-09-02T15:32:21Z","git_url":"git://github.com/aaronjwood/dcos.git","ssh_url":"git@github.com:aaronjwood/dcos.git","clone_url":"https://github.com/aaronjwood/dcos.git","svn_url":"https://github.com/aaronjwood/dcos","homepage":"https://dcos.io","size":1482,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"7aa7d3cc3cf23f89334023244e85f1ad07bd2c1a","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56184050,"name":"dcos","full_name":"dcos/dcos","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos","description":"DC/OS Build and Release tools","fork":false,"url":"https://api.github.com/repos/dcos/dcos","forks_url":"https://api.github.com/repos/dcos/dcos/forks","keys_url":"https://api.github.com/repos/dcos/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos/teams","hooks_url":"https://api.github.com/repos/dcos/dcos/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos/events","assignees_url":"https://api.github.com/repos/dcos/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos/tags","blobs_url":"https://api.github.com/repos/dcos/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos/subscription","commits_url":"https://api.github.com/repos/dcos/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos/merges","archive_url":"https://api.github.com/repos/dcos/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos/downloads","issues_url":"https://api.github.com/repos/dcos/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos/deployments","created_at":"2016-04-13T20:31:58Z","updated_at":"2016-09-06T11:06:31Z","pushed_at":"2016-09-06T18:13:28Z","git_url":"git://github.com/dcos/dcos.git","ssh_url":"git@github.com:dcos/dcos.git","clone_url":"https://github.com/dcos/dcos.git","svn_url":"https://github.com/dcos/dcos","homepage":"https://dcos.io","size":2374,"stargazers_count":843,"watchers_count":843,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":148,"mirror_url":null,"open_issues_count":35,"forks":148,"open_issues":35,"watchers":843,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/603"},"html":{"href":"https://github.com/dcos/dcos/pull/603"},"issue":{"href":"https://api.github.com/repos/dcos/dcos/issues/603"},"comments":{"href":"https://api.github.com/repos/dcos/dcos/issues/603/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos/pulls/603/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos/pulls/603/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos/statuses/9d80624859a21bf81955495e6834d854ee5f39da"}}}}
{"actor":{"display_login":"orsenthil"}}