{"action":"created","issue":{"url":"https://api.github.com/repos/certbot/certbot/issues/3016","repository_url":"https://api.github.com/repos/certbot/certbot","labels_url":"https://api.github.com/repos/certbot/certbot/issues/3016/labels{/name}","comments_url":"https://api.github.com/repos/certbot/certbot/issues/3016/comments","events_url":"https://api.github.com/repos/certbot/certbot/issues/3016/events","html_url":"https://github.com/certbot/certbot/pull/3016","id":155409272,"number":3016,"title":"Make certbot-auto quieter without implementing --quiet","user":{"login":"bmw","id":6504915,"avatar_url":"https://avatars.githubusercontent.com/u/6504915?v=3","gravatar_id":"","url":"https://api.github.com/users/bmw","html_url":"https://github.com/bmw","followers_url":"https://api.github.com/users/bmw/followers","following_url":"https://api.github.com/users/bmw/following{/other_user}","gists_url":"https://api.github.com/users/bmw/gists{/gist_id}","starred_url":"https://api.github.com/users/bmw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmw/subscriptions","organizations_url":"https://api.github.com/users/bmw/orgs","repos_url":"https://api.github.com/users/bmw/repos","events_url":"https://api.github.com/users/bmw/events{/privacy}","received_events_url":"https://api.github.com/users/bmw/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/certbot/certbot/labels/letsencrypt-auto","name":"letsencrypt-auto","color":"00a080"},{"url":"https://api.github.com/repos/certbot/certbot/labels/ui%20/%20ux","name":"ui / ux","color":"5319e7"}],"state":"closed","locked":false,"assignee":{"login":"pde","id":479213,"avatar_url":"https://avatars.githubusercontent.com/u/479213?v=3","gravatar_id":"","url":"https://api.github.com/users/pde","html_url":"https://github.com/pde","followers_url":"https://api.github.com/users/pde/followers","following_url":"https://api.github.com/users/pde/following{/other_user}","gists_url":"https://api.github.com/users/pde/gists{/gist_id}","starred_url":"https://api.github.com/users/pde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pde/subscriptions","organizations_url":"https://api.github.com/users/pde/orgs","repos_url":"https://api.github.com/users/pde/repos","events_url":"https://api.github.com/users/pde/events{/privacy}","received_events_url":"https://api.github.com/users/pde/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/certbot/certbot/milestones/20","html_url":"https://github.com/certbot/certbot/milestones/0.7.0","labels_url":"https://api.github.com/repos/certbot/certbot/milestones/20/labels","id":1640144,"number":20,"title":"0.7.0","description":"","creator":{"login":"pde","id":479213,"avatar_url":"https://avatars.githubusercontent.com/u/479213?v=3","gravatar_id":"","url":"https://api.github.com/users/pde","html_url":"https://github.com/pde","followers_url":"https://api.github.com/users/pde/followers","following_url":"https://api.github.com/users/pde/following{/other_user}","gists_url":"https://api.github.com/users/pde/gists{/gist_id}","starred_url":"https://api.github.com/users/pde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pde/subscriptions","organizations_url":"https://api.github.com/users/pde/orgs","repos_url":"https://api.github.com/users/pde/repos","events_url":"https://api.github.com/users/pde/events{/privacy}","received_events_url":"https://api.github.com/users/pde/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":41,"state":"open","created_at":"2016-03-12T02:18:26Z","updated_at":"2016-05-25T05:19:16Z","due_on":"2016-05-19T07:00:00Z","closed_at":null},"comments":3,"created_at":"2016-05-18T03:26:31Z","updated_at":"2016-05-25T06:15:13Z","closed_at":"2016-05-18T21:22:37Z","pull_request":{"url":"https://api.github.com/repos/certbot/certbot/pulls/3016","html_url":"https://github.com/certbot/certbot/pull/3016","diff_url":"https://github.com/certbot/certbot/pull/3016.diff","patch_url":"https://github.com/certbot/certbot/pull/3016.patch"},"body":"Fixes #2990. I think this PR should be preferred to one that adds `certbot-auto` support for `--quiet`.\r\n\r\nInitially, I planned to provide `--quiet` support for the whole script, including bootstrapping and setting up the `virtualenv`. The problem with this is these steps don't happen very often and the output is often something the user should care about.\r\n\r\nWith this in mind, I set out to only implement `--quiet` support for the non-upgrading case. I did this in #3015 and then realized there are only two places where we output anything.\r\n\r\n1. We output \"Checking for new version...\" on every single run. This seems very excessive. I believe we are very clear that `certbot-auto` is a self updating script and this output is just clutter. I removed it entirely.\r\n2. We output \"Requesting root privileges to run certbot...\" on every run, even if we already have root. After fixing the bug of always showing this prompt, I hid it when using `--quiet`, however, if we're about use su/sudo to run `certbot`, we will likely be prompting you to enter a password. Asking for a `sudo` password with no context is a bad idea and isn't likely to be useful in the renewal case either. Therefore, to fix this problem, I only print these messages if we're about to use su/sudo.\r\n\r\nAnd...that fixes the problem! The fact we were able to do this without further complicated our temporary `certbot-auto` script is a win in my opinion and there is little to nothing to be gained by implementing `--quiet` on top of this PR.\r\n\r\nPlease let me know if you disagree!\r\n\r\nEDIT: I didn't list it explicitly, but we also output if we're going to use `su` instead of `sudo`. Again, if we're using `su`, we're likely going to prompt so I didn't see this as a problem."},"comment":{"url":"https://api.github.com/repos/certbot/certbot/issues/comments/221482741","html_url":"https://github.com/certbot/certbot/pull/3016#issuecomment-221482741","issue_url":"https://api.github.com/repos/certbot/certbot/issues/3016","id":221482741,"user":{"login":"bmw","id":6504915,"avatar_url":"https://avatars.githubusercontent.com/u/6504915?v=3","gravatar_id":"","url":"https://api.github.com/users/bmw","html_url":"https://github.com/bmw","followers_url":"https://api.github.com/users/bmw/followers","following_url":"https://api.github.com/users/bmw/following{/other_user}","gists_url":"https://api.github.com/users/bmw/gists{/gist_id}","starred_url":"https://api.github.com/users/bmw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmw/subscriptions","organizations_url":"https://api.github.com/users/bmw/orgs","repos_url":"https://api.github.com/users/bmw/repos","events_url":"https://api.github.com/users/bmw/events{/privacy}","received_events_url":"https://api.github.com/users/bmw/received_events","type":"User","site_admin":false},"created_at":"2016-05-25T06:15:12Z","updated_at":"2016-05-25T06:15:12Z","body":"@solarissmoke the code from this PR hasn't be included in a release yet. It'll be in the 0.7.0 release later this week."}}
{"actor":{"display_login":"bmw"}}