{"action":"closed","number":19636,"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/19636","id":98457171,"html_url":"https://github.com/JuliaLang/julia/pull/19636","diff_url":"https://github.com/JuliaLang/julia/pull/19636.diff","patch_url":"https://github.com/JuliaLang/julia/pull/19636.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/19636","number":19636,"state":"closed","locked":false,"title":"RFC: Rewrite homedir based on uv_os_homedir","user":{"login":"ararslan","id":6396159,"avatar_url":"https://avatars.githubusercontent.com/u/6396159?v=3","gravatar_id":"","url":"https://api.github.com/users/ararslan","html_url":"https://github.com/ararslan","followers_url":"https://api.github.com/users/ararslan/followers","following_url":"https://api.github.com/users/ararslan/following{/other_user}","gists_url":"https://api.github.com/users/ararslan/gists{/gist_id}","starred_url":"https://api.github.com/users/ararslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ararslan/subscriptions","organizations_url":"https://api.github.com/users/ararslan/orgs","repos_url":"https://api.github.com/users/ararslan/repos","events_url":"https://api.github.com/users/ararslan/events{/privacy}","received_events_url":"https://api.github.com/users/ararslan/received_events","type":"User","site_admin":false},"body":"Fixes #11331\r\n\r\nRather than relying on environment variables to determine the user's home directory, this calls `uv_os_homedir` from libuv, per @stevengj's suggestion.\r\n\r\nThe \"magic number\" of 1024 in there is what we're setting as the `PATH_MAX` if none is found in the system (see [src/support/dirpath.h](https://github.com/JuliaLang/julia/blob/master/src/support/dirpath.h)), so it seemed to me like a decent choice for the number of bytes to allocate for the output path. Let me know if that isn't reasonable or if there's a better choice.\r\n\r\nFor reference, here is the upstream libuv documentation on `uv_os_homedir`: http://docs.libuv.org/en/v1.x/misc.html#c.uv_os_homedir","created_at":"2016-12-17T21:59:34Z","updated_at":"2016-12-18T20:20:33Z","closed_at":"2016-12-18T20:20:33Z","merged_at":"2016-12-18T20:20:33Z","merge_commit_sha":"1d561e8ea2da54e6b0237a34790fb2b0c76083e6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/19636/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/19636/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/19636/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/5b04cb002ed65f4bbd8c0ea82cc4e3ba855dff56","head":{"label":"ararslan:aa/homedir","ref":"aa/homedir","sha":"5b04cb002ed65f4bbd8c0ea82cc4e3ba855dff56","user":{"login":"ararslan","id":6396159,"avatar_url":"https://avatars.githubusercontent.com/u/6396159?v=3","gravatar_id":"","url":"https://api.github.com/users/ararslan","html_url":"https://github.com/ararslan","followers_url":"https://api.github.com/users/ararslan/followers","following_url":"https://api.github.com/users/ararslan/following{/other_user}","gists_url":"https://api.github.com/users/ararslan/gists{/gist_id}","starred_url":"https://api.github.com/users/ararslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ararslan/subscriptions","organizations_url":"https://api.github.com/users/ararslan/orgs","repos_url":"https://api.github.com/users/ararslan/repos","events_url":"https://api.github.com/users/ararslan/events{/privacy}","received_events_url":"https://api.github.com/users/ararslan/received_events","type":"User","site_admin":false},"repo":{"id":57339960,"name":"julia","full_name":"ararslan/julia","owner":{"login":"ararslan","id":6396159,"avatar_url":"https://avatars.githubusercontent.com/u/6396159?v=3","gravatar_id":"","url":"https://api.github.com/users/ararslan","html_url":"https://github.com/ararslan","followers_url":"https://api.github.com/users/ararslan/followers","following_url":"https://api.github.com/users/ararslan/following{/other_user}","gists_url":"https://api.github.com/users/ararslan/gists{/gist_id}","starred_url":"https://api.github.com/users/ararslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ararslan/subscriptions","organizations_url":"https://api.github.com/users/ararslan/orgs","repos_url":"https://api.github.com/users/ararslan/repos","events_url":"https://api.github.com/users/ararslan/events{/privacy}","received_events_url":"https://api.github.com/users/ararslan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ararslan/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/ararslan/julia","forks_url":"https://api.github.com/repos/ararslan/julia/forks","keys_url":"https://api.github.com/repos/ararslan/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ararslan/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ararslan/julia/teams","hooks_url":"https://api.github.com/repos/ararslan/julia/hooks","issue_events_url":"https://api.github.com/repos/ararslan/julia/issues/events{/number}","events_url":"https://api.github.com/repos/ararslan/julia/events","assignees_url":"https://api.github.com/repos/ararslan/julia/assignees{/user}","branches_url":"https://api.github.com/repos/ararslan/julia/branches{/branch}","tags_url":"https://api.github.com/repos/ararslan/julia/tags","blobs_url":"https://api.github.com/repos/ararslan/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ararslan/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ararslan/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/ararslan/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ararslan/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/ararslan/julia/languages","stargazers_url":"https://api.github.com/repos/ararslan/julia/stargazers","contributors_url":"https://api.github.com/repos/ararslan/julia/contributors","subscribers_url":"https://api.github.com/repos/ararslan/julia/subscribers","subscription_url":"https://api.github.com/repos/ararslan/julia/subscription","commits_url":"https://api.github.com/repos/ararslan/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/ararslan/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/ararslan/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/ararslan/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/ararslan/julia/contents/{+path}","compare_url":"https://api.github.com/repos/ararslan/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ararslan/julia/merges","archive_url":"https://api.github.com/repos/ararslan/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ararslan/julia/downloads","issues_url":"https://api.github.com/repos/ararslan/julia/issues{/number}","pulls_url":"https://api.github.com/repos/ararslan/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/ararslan/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/ararslan/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ararslan/julia/labels{/name}","releases_url":"https://api.github.com/repos/ararslan/julia/releases{/id}","deployments_url":"https://api.github.com/repos/ararslan/julia/deployments","created_at":"2016-04-28T23:22:08Z","updated_at":"2016-04-28T23:22:16Z","pushed_at":"2016-12-17T22:59:59Z","git_url":"git://github.com/ararslan/julia.git","ssh_url":"git@github.com:ararslan/julia.git","clone_url":"https://github.com/ararslan/julia.git","svn_url":"https://github.com/ararslan/julia","homepage":"http://julialang.org/","size":102530,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"ded22594ec4f4ec83d40159b3a181ca5f90915ba","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2016-12-18T19:43:30Z","pushed_at":"2016-12-18T20:20:33Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":115458,"stargazers_count":7922,"watchers_count":7922,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1860,"mirror_url":null,"open_issues_count":2238,"forks":1860,"open_issues":2238,"watchers":7922,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/19636"},"html":{"href":"https://github.com/JuliaLang/julia/pull/19636"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/19636"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/19636/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/19636/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/19636/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/5b04cb002ed65f4bbd8c0ea82cc4e3ba855dff56"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"stevengj","id":2913679,"avatar_url":"https://avatars.githubusercontent.com/u/2913679?v=3","gravatar_id":"","url":"https://api.github.com/users/stevengj","html_url":"https://github.com/stevengj","followers_url":"https://api.github.com/users/stevengj/followers","following_url":"https://api.github.com/users/stevengj/following{/other_user}","gists_url":"https://api.github.com/users/stevengj/gists{/gist_id}","starred_url":"https://api.github.com/users/stevengj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevengj/subscriptions","organizations_url":"https://api.github.com/users/stevengj/orgs","repos_url":"https://api.github.com/users/stevengj/repos","events_url":"https://api.github.com/users/stevengj/events{/privacy}","received_events_url":"https://api.github.com/users/stevengj/received_events","type":"User","site_admin":false},"comments":4,"review_comments":3,"commits":1,"additions":16,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"stevengj"}}