{"action":"created","issue":{"url":"https://api.github.com/repos/enthought/sat-solver/issues/218","repository_url":"https://api.github.com/repos/enthought/sat-solver","labels_url":"https://api.github.com/repos/enthought/sat-solver/issues/218/labels{/name}","comments_url":"https://api.github.com/repos/enthought/sat-solver/issues/218/comments","events_url":"https://api.github.com/repos/enthought/sat-solver/issues/218/events","html_url":"https://github.com/enthought/sat-solver/pull/218","id":156055211,"number":218,"title":"FIX: Do not suggest literals without clauses","user":{"login":"noraderam","id":1151749,"avatar_url":"https://avatars.githubusercontent.com/u/1151749?v=3","gravatar_id":"","url":"https://api.github.com/users/noraderam","html_url":"https://github.com/noraderam","followers_url":"https://api.github.com/users/noraderam/followers","following_url":"https://api.github.com/users/noraderam/following{/other_user}","gists_url":"https://api.github.com/users/noraderam/gists{/gist_id}","starred_url":"https://api.github.com/users/noraderam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noraderam/subscriptions","organizations_url":"https://api.github.com/users/noraderam/orgs","repos_url":"https://api.github.com/users/noraderam/repos","events_url":"https://api.github.com/users/noraderam/events{/privacy}","received_events_url":"https://api.github.com/users/noraderam/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"cournape","id":25111,"avatar_url":"https://avatars.githubusercontent.com/u/25111?v=3","gravatar_id":"","url":"https://api.github.com/users/cournape","html_url":"https://github.com/cournape","followers_url":"https://api.github.com/users/cournape/followers","following_url":"https://api.github.com/users/cournape/following{/other_user}","gists_url":"https://api.github.com/users/cournape/gists{/gist_id}","starred_url":"https://api.github.com/users/cournape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cournape/subscriptions","organizations_url":"https://api.github.com/users/cournape/orgs","repos_url":"https://api.github.com/users/cournape/repos","events_url":"https://api.github.com/users/cournape/events{/privacy}","received_events_url":"https://api.github.com/users/cournape/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/enthought/sat-solver/milestones/9","html_url":"https://github.com/enthought/sat-solver/milestones/0.4.0","labels_url":"https://api.github.com/repos/enthought/sat-solver/milestones/9/labels","id":1745824,"number":9,"title":"0.4.0","description":"","creator":{"login":"cournape","id":25111,"avatar_url":"https://avatars.githubusercontent.com/u/25111?v=3","gravatar_id":"","url":"https://api.github.com/users/cournape","html_url":"https://github.com/cournape","followers_url":"https://api.github.com/users/cournape/followers","following_url":"https://api.github.com/users/cournape/following{/other_user}","gists_url":"https://api.github.com/users/cournape/gists{/gist_id}","starred_url":"https://api.github.com/users/cournape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cournape/subscriptions","organizations_url":"https://api.github.com/users/cournape/orgs","repos_url":"https://api.github.com/users/cournape/repos","events_url":"https://api.github.com/users/cournape/events{/privacy}","received_events_url":"https://api.github.com/users/cournape/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2016-05-03T17:50:32Z","updated_at":"2016-05-20T21:33:08Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-05-20T21:33:08Z","updated_at":"2016-05-23T16:56:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/enthought/sat-solver/pulls/218","html_url":"https://github.com/enthought/sat-solver/pull/218","diff_url":"https://github.com/enthought/sat-solver/pull/218.diff","patch_url":"https://github.com/enthought/sat-solver/pull/218.patch"},"body":"Closes #217 \r\n\r\n@johntyree I'd love to hear your thoughts on this and the corresponding issue. I believe that this solution is correct."},"comment":{"url":"https://api.github.com/repos/enthought/sat-solver/issues/comments/221030747","html_url":"https://github.com/enthought/sat-solver/pull/218#issuecomment-221030747","issue_url":"https://api.github.com/repos/enthought/sat-solver/issues/218","id":221030747,"user":{"login":"noraderam","id":1151749,"avatar_url":"https://avatars.githubusercontent.com/u/1151749?v=3","gravatar_id":"","url":"https://api.github.com/users/noraderam","html_url":"https://github.com/noraderam","followers_url":"https://api.github.com/users/noraderam/followers","following_url":"https://api.github.com/users/noraderam/following{/other_user}","gists_url":"https://api.github.com/users/noraderam/gists{/gist_id}","starred_url":"https://api.github.com/users/noraderam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noraderam/subscriptions","organizations_url":"https://api.github.com/users/noraderam/orgs","repos_url":"https://api.github.com/users/noraderam/repos","events_url":"https://api.github.com/users/noraderam/events{/privacy}","received_events_url":"https://api.github.com/users/noraderam/received_events","type":"User","site_admin":false},"created_at":"2016-05-23T16:56:56Z","updated_at":"2016-05-23T16:56:56Z","body":"> Semantically, what does this do? I suppose the solver will never assign the id, since it has no clauses to cause unit propagation nor will it ever be assumed by the policy. What do we do in that case? Hopefully just not touch the package?\r\n\r\nThe solver will completely ignore the package; we do nothing with it. In practice, that probably means leaving it installed, but it depends on what we're actually doing with the output of the solver. This is specifically happening in a case where we did not ask the solver to keep the package installed.\r\n\r\n\r\n\r\n> It seems like prepopulating id_to_clauses using from_keys(<pool ids>, []) would be another solution that doesn't change the meaning of anything or change the performance significantly. Is that feasible?\r\n\r\nIn that case, we still suggest the package as a potential assignment for our solver. That seems wrong to me. We're suggesting a literal for which we have no clauses because of the implementation detail that our `policy` is given an `installed_repository`. It presupposes that we must want packages that we already have installed. We shouldn't assume that: that's why we add `install` jobs to the `Request` for installed packages. "}}
{"actor":{"display_login":"noraderam"}}