{"action":"created","issue":{"url":"https://api.github.com/repos/brettc/partitionfinder/issues/98","repository_url":"https://api.github.com/repos/brettc/partitionfinder","labels_url":"https://api.github.com/repos/brettc/partitionfinder/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/brettc/partitionfinder/issues/98/comments","events_url":"https://api.github.com/repos/brettc/partitionfinder/issues/98/events","html_url":"https://github.com/brettc/partitionfinder/issues/98","id":154611393,"number":98,"title":"failing tests","user":{"login":"roblanf","id":895251,"avatar_url":"https://avatars.githubusercontent.com/u/895251?v=3","gravatar_id":"","url":"https://api.github.com/users/roblanf","html_url":"https://github.com/roblanf","followers_url":"https://api.github.com/users/roblanf/followers","following_url":"https://api.github.com/users/roblanf/following{/other_user}","gists_url":"https://api.github.com/users/roblanf/gists{/gist_id}","starred_url":"https://api.github.com/users/roblanf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblanf/subscriptions","organizations_url":"https://api.github.com/users/roblanf/orgs","repos_url":"https://api.github.com/users/roblanf/repos","events_url":"https://api.github.com/users/roblanf/events{/privacy}","received_events_url":"https://api.github.com/users/roblanf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"brettc","id":457283,"avatar_url":"https://avatars.githubusercontent.com/u/457283?v=3","gravatar_id":"","url":"https://api.github.com/users/brettc","html_url":"https://github.com/brettc","followers_url":"https://api.github.com/users/brettc/followers","following_url":"https://api.github.com/users/brettc/following{/other_user}","gists_url":"https://api.github.com/users/brettc/gists{/gist_id}","starred_url":"https://api.github.com/users/brettc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettc/subscriptions","organizations_url":"https://api.github.com/users/brettc/orgs","repos_url":"https://api.github.com/users/brettc/repos","events_url":"https://api.github.com/users/brettc/events{/privacy}","received_events_url":"https://api.github.com/users/brettc/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-05-13T00:42:44Z","updated_at":"2016-05-13T01:56:43Z","closed_at":null,"body":"@brettc, can you take a look at these. \r\n\r\nI have a small number of tests failing, all because of very small differences in the expected and observed AIC/BIC scores. There's a full list below. I think we need to do two things here:\r\n\r\n1. Update the expected values to the new observed values (the diffs appear to be caused by changes in likeilhoods from Phyml/RAxML).\r\n\r\n2. Increase the tolerance limit to, say, 1.0. Right now it's 0.1, and this often means we get these false positives with failing tests. 1.0 is small, but big enough to be robust to very small changes in the calculations from phyml/raxml.\r\n\r\nR"},"comment":{"url":"https://api.github.com/repos/brettc/partitionfinder/issues/comments/218933195","html_url":"https://github.com/brettc/partitionfinder/issues/98#issuecomment-218933195","issue_url":"https://api.github.com/repos/brettc/partitionfinder/issues/98","id":218933195,"user":{"login":"brettc","id":457283,"avatar_url":"https://avatars.githubusercontent.com/u/457283?v=3","gravatar_id":"","url":"https://api.github.com/users/brettc","html_url":"https://github.com/brettc","followers_url":"https://api.github.com/users/brettc/followers","following_url":"https://api.github.com/users/brettc/following{/other_user}","gists_url":"https://api.github.com/users/brettc/gists{/gist_id}","starred_url":"https://api.github.com/users/brettc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettc/subscriptions","organizations_url":"https://api.github.com/users/brettc/orgs","repos_url":"https://api.github.com/users/brettc/repos","events_url":"https://api.github.com/users/brettc/events{/privacy}","received_events_url":"https://api.github.com/users/brettc/received_events","type":"User","site_admin":false},"created_at":"2016-05-13T01:56:43Z","updated_at":"2016-05-13T01:56:43Z","body":"Ok -- will check this out (currently writing grants, so won't be straight away)."}}