{"action":"created","comment":{"url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls/comments/69156884","id":69156884,"diff_hunk":"@@ -8,6 +8,8 @@ export default Ember.Route.extend({\n     },\n     setupController(controller, model) {\n         this._super(controller, model);\n+        var metaschemas = this.store.findAll('metaschema');\n+        controller.set('metaschemas', metaschemas);","path":"tests/dummy/app/routes/nodes/detail/draft-registrations/index.js","position":5,"original_position":5,"commit_id":"4e7a2d87e9f0f4461df7fe601ff22a7b900b6e7e","original_commit_id":"5c68e4a81b1acf00d40c0359ccf5c6d56185f622","user":{"login":"abought","id":2957073,"avatar_url":"https://avatars.githubusercontent.com/u/2957073?v=3","gravatar_id":"","url":"https://api.github.com/users/abought","html_url":"https://github.com/abought","followers_url":"https://api.github.com/users/abought/followers","following_url":"https://api.github.com/users/abought/following{/other_user}","gists_url":"https://api.github.com/users/abought/gists{/gist_id}","starred_url":"https://api.github.com/users/abought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abought/subscriptions","organizations_url":"https://api.github.com/users/abought/orgs","repos_url":"https://api.github.com/users/abought/repos","events_url":"https://api.github.com/users/abought/events{/privacy}","received_events_url":"https://api.github.com/users/abought/received_events","type":"User","site_admin":false},"body":"Agreed- drafts are in no way a blocker for this PR, and wouldn't be even if the API was behaving better. \r\n\r\nJust making the note while the code was fresh.","created_at":"2016-06-30T15:40:34Z","updated_at":"2016-06-30T15:40:34Z","html_url":"https://github.com/CenterForOpenScience/ember-osf/pull/88#discussion_r69156884","pull_request_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls/88","_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls/comments/69156884"},"html":{"href":"https://github.com/CenterForOpenScience/ember-osf/pull/88#discussion_r69156884"},"pull_request":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls/88","id":75549314,"html_url":"https://github.com/CenterForOpenScience/ember-osf/pull/88","diff_url":"https://github.com/CenterForOpenScience/ember-osf/pull/88.diff","patch_url":"https://github.com/CenterForOpenScience/ember-osf/pull/88.patch","issue_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/issues/88","number":88,"state":"open","locked":false,"title":"Feature/Dirty Relationship Tracking Polishing [EOSF-79]","user":{"login":"pattisdr","id":9755598,"avatar_url":"https://avatars.githubusercontent.com/u/9755598?v=3","gravatar_id":"","url":"https://api.github.com/users/pattisdr","html_url":"https://github.com/pattisdr","followers_url":"https://api.github.com/users/pattisdr/followers","following_url":"https://api.github.com/users/pattisdr/following{/other_user}","gists_url":"https://api.github.com/users/pattisdr/gists{/gist_id}","starred_url":"https://api.github.com/users/pattisdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pattisdr/subscriptions","organizations_url":"https://api.github.com/users/pattisdr/orgs","repos_url":"https://api.github.com/users/pattisdr/repos","events_url":"https://api.github.com/users/pattisdr/events{/privacy}","received_events_url":"https://api.github.com/users/pattisdr/received_events","type":"User","site_admin":false},"body":"## Ticket\r\n\r\nhttps://openscience.atlassian.net/browse/EOSF-79\r\n\r\n# Purpose\r\n\r\nWraps up https://github.com/CenterForOpenScience/ember-osf/pull/78.  \r\n\r\nHave looked at changes to osf-adapter, still need to understand changes to dirtyRelationships.\r\n\r\n# Notes for Reviewers\r\n\r\n❗ The main fix was making multiple requests without refresh was causing errors in the console because dirty relationships weren't being cleared.  To test I would make multiple types of requests that add relationships one after another.\r\n\r\nMy changes:\r\n \r\n- fetched metaschemas instead of hardcoding\r\n- fixed js errors related to mapping snapshots\r\n- modified _doRelatedRequest - sometimes was getting request with list in list, maybe due to fix for previous item\r\n- Handling for adding a project to a collection (first attempt).  Linked_node serializer added because request to add a  linked_node to a collection needs to look like adding an institution to a node.  But there's no linked_node model, linked nodes are actually nodes. May need to rethink this.\r\n- Changes for running addCanonicalRecord or removeCanonicalRecord - wasn't being cleared.\r\n- Passing in internalModel instead of snapshot for _addRelated method (fixed institutions)\r\n\r\nIssues:\r\n- Deleting node links and deleting drafts don't properly update UI.  \r\n- Bulk updates to contributors still unreliable (maybe need changes API side?)\r\n\r\n## Routes Added/Updated\r\n\r\n\r\n","created_at":"2016-06-28T20:58:39Z","updated_at":"2016-06-30T15:40:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddd1533a60dcb4c2b181a9d2f692566d7983e822","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls/88/commits","review_comments_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls/88/comments","review_comment_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/issues/88/comments","statuses_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/statuses/4e7a2d87e9f0f4461df7fe601ff22a7b900b6e7e","head":{"label":"pattisdr:feature/relationship_dirty_tracking_review","ref":"feature/relationship_dirty_tracking_review","sha":"4e7a2d87e9f0f4461df7fe601ff22a7b900b6e7e","user":{"login":"pattisdr","id":9755598,"avatar_url":"https://avatars.githubusercontent.com/u/9755598?v=3","gravatar_id":"","url":"https://api.github.com/users/pattisdr","html_url":"https://github.com/pattisdr","followers_url":"https://api.github.com/users/pattisdr/followers","following_url":"https://api.github.com/users/pattisdr/following{/other_user}","gists_url":"https://api.github.com/users/pattisdr/gists{/gist_id}","starred_url":"https://api.github.com/users/pattisdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pattisdr/subscriptions","organizations_url":"https://api.github.com/users/pattisdr/orgs","repos_url":"https://api.github.com/users/pattisdr/repos","events_url":"https://api.github.com/users/pattisdr/events{/privacy}","received_events_url":"https://api.github.com/users/pattisdr/received_events","type":"User","site_admin":false},"repo":{"id":58407203,"name":"ember-osf","full_name":"pattisdr/ember-osf","owner":{"login":"pattisdr","id":9755598,"avatar_url":"https://avatars.githubusercontent.com/u/9755598?v=3","gravatar_id":"","url":"https://api.github.com/users/pattisdr","html_url":"https://github.com/pattisdr","followers_url":"https://api.github.com/users/pattisdr/followers","following_url":"https://api.github.com/users/pattisdr/following{/other_user}","gists_url":"https://api.github.com/users/pattisdr/gists{/gist_id}","starred_url":"https://api.github.com/users/pattisdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pattisdr/subscriptions","organizations_url":"https://api.github.com/users/pattisdr/orgs","repos_url":"https://api.github.com/users/pattisdr/repos","events_url":"https://api.github.com/users/pattisdr/events{/privacy}","received_events_url":"https://api.github.com/users/pattisdr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pattisdr/ember-osf","description":"","fork":true,"url":"https://api.github.com/repos/pattisdr/ember-osf","forks_url":"https://api.github.com/repos/pattisdr/ember-osf/forks","keys_url":"https://api.github.com/repos/pattisdr/ember-osf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pattisdr/ember-osf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pattisdr/ember-osf/teams","hooks_url":"https://api.github.com/repos/pattisdr/ember-osf/hooks","issue_events_url":"https://api.github.com/repos/pattisdr/ember-osf/issues/events{/number}","events_url":"https://api.github.com/repos/pattisdr/ember-osf/events","assignees_url":"https://api.github.com/repos/pattisdr/ember-osf/assignees{/user}","branches_url":"https://api.github.com/repos/pattisdr/ember-osf/branches{/branch}","tags_url":"https://api.github.com/repos/pattisdr/ember-osf/tags","blobs_url":"https://api.github.com/repos/pattisdr/ember-osf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pattisdr/ember-osf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pattisdr/ember-osf/git/refs{/sha}","trees_url":"https://api.github.com/repos/pattisdr/ember-osf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pattisdr/ember-osf/statuses/{sha}","languages_url":"https://api.github.com/repos/pattisdr/ember-osf/languages","stargazers_url":"https://api.github.com/repos/pattisdr/ember-osf/stargazers","contributors_url":"https://api.github.com/repos/pattisdr/ember-osf/contributors","subscribers_url":"https://api.github.com/repos/pattisdr/ember-osf/subscribers","subscription_url":"https://api.github.com/repos/pattisdr/ember-osf/subscription","commits_url":"https://api.github.com/repos/pattisdr/ember-osf/commits{/sha}","git_commits_url":"https://api.github.com/repos/pattisdr/ember-osf/git/commits{/sha}","comments_url":"https://api.github.com/repos/pattisdr/ember-osf/comments{/number}","issue_comment_url":"https://api.github.com/repos/pattisdr/ember-osf/issues/comments{/number}","contents_url":"https://api.github.com/repos/pattisdr/ember-osf/contents/{+path}","compare_url":"https://api.github.com/repos/pattisdr/ember-osf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pattisdr/ember-osf/merges","archive_url":"https://api.github.com/repos/pattisdr/ember-osf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pattisdr/ember-osf/downloads","issues_url":"https://api.github.com/repos/pattisdr/ember-osf/issues{/number}","pulls_url":"https://api.github.com/repos/pattisdr/ember-osf/pulls{/number}","milestones_url":"https://api.github.com/repos/pattisdr/ember-osf/milestones{/number}","notifications_url":"https://api.github.com/repos/pattisdr/ember-osf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pattisdr/ember-osf/labels{/name}","releases_url":"https://api.github.com/repos/pattisdr/ember-osf/releases{/id}","deployments_url":"https://api.github.com/repos/pattisdr/ember-osf/deployments","created_at":"2016-05-09T20:49:01Z","updated_at":"2016-05-09T20:49:02Z","pushed_at":"2016-06-30T12:51:14Z","git_url":"git://github.com/pattisdr/ember-osf.git","ssh_url":"git@github.com:pattisdr/ember-osf.git","clone_url":"https://github.com/pattisdr/ember-osf.git","svn_url":"https://github.com/pattisdr/ember-osf","homepage":null,"size":911,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"CenterForOpenScience:develop","ref":"develop","sha":"e126091aa32ab67dc62aa813ac6c494b1afba352","user":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":55632427,"name":"ember-osf","full_name":"CenterForOpenScience/ember-osf","owner":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/ember-osf","description":"","fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/ember-osf","forks_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/issues/comments{/number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/releases{/id}","deployments_url":"https://api.github.com/repos/CenterForOpenScience/ember-osf/deployments","created_at":"2016-04-06T18:51:35Z","updated_at":"2016-06-06T22:53:03Z","pushed_at":"2016-06-30T13:00:00Z","git_url":"git://github.com/CenterForOpenScience/ember-osf.git","ssh_url":"git@github.com:CenterForOpenScience/ember-osf.git","clone_url":"https://github.com/CenterForOpenScience/ember-osf.git","svn_url":"https://github.com/CenterForOpenScience/ember-osf","homepage":null,"size":1099,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":7,"forks":12,"open_issues":7,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls/88"},"html":{"href":"https://github.com/CenterForOpenScience/ember-osf/pull/88"},"issue":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf/issues/88"},"comments":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/CenterForOpenScience/ember-osf/statuses/4e7a2d87e9f0f4461df7fe601ff22a7b900b6e7e"}}}}
{"actor":{"display_login":"abought"}}