{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/60411362","id":60411362,"diff_hunk":"@@ -164,8 +165,8 @@ def collect_hosts(oo_cfg, existing_env=False, masters_set=False, print_summary=T\n             more_hosts = click.confirm('Do you want to add additional hosts?')\n \n     if num_masters == 1:\n-        master = next((host for host in hosts if host.master), None)\n-        master.storage = True\n+        master = next((host for host in hosts if host.is_master()), None)\n+        master['roles'].append('storage')","path":"utils/src/ooinstall/cli_installer.py","position":28,"original_position":28,"commit_id":"09ac00e5252939d2c270a655bffbd54de8dafc57","original_commit_id":"09ac00e5252939d2c270a655bffbd54de8dafc57","user":{"login":"detiber","id":915544,"avatar_url":"https://avatars.githubusercontent.com/u/915544?v=3","gravatar_id":"","url":"https://api.github.com/users/detiber","html_url":"https://github.com/detiber","followers_url":"https://api.github.com/users/detiber/followers","following_url":"https://api.github.com/users/detiber/following{/other_user}","gists_url":"https://api.github.com/users/detiber/gists{/gist_id}","starred_url":"https://api.github.com/users/detiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/detiber/subscriptions","organizations_url":"https://api.github.com/users/detiber/orgs","repos_url":"https://api.github.com/users/detiber/repos","events_url":"https://api.github.com/users/detiber/events{/privacy}","received_events_url":"https://api.github.com/users/detiber/received_events","type":"User","site_admin":false},"body":"Might want to have the ability to split out storage and lb hosts separate from the master, especially since they are not currently containerized.","created_at":"2016-04-20T13:57:11Z","updated_at":"2016-04-20T13:57:11Z","html_url":"https://github.com/openshift/openshift-ansible/pull/1778#discussion_r60411362","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1778","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/60411362"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/1778#discussion_r60411362"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1778"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1778","id":67185400,"html_url":"https://github.com/openshift/openshift-ansible/pull/1778","diff_url":"https://github.com/openshift/openshift-ansible/pull/1778.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/1778.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/1778","number":1778,"state":"open","locked":false,"title":"[WIP] Arbitrary installer yaml","user":{"login":"smunilla","id":873968,"avatar_url":"https://avatars.githubusercontent.com/u/873968?v=3","gravatar_id":"","url":"https://api.github.com/users/smunilla","html_url":"https://github.com/smunilla","followers_url":"https://api.github.com/users/smunilla/followers","following_url":"https://api.github.com/users/smunilla/following{/other_user}","gists_url":"https://api.github.com/users/smunilla/gists{/gist_id}","starred_url":"https://api.github.com/users/smunilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smunilla/subscriptions","organizations_url":"https://api.github.com/users/smunilla/orgs","repos_url":"https://api.github.com/users/smunilla/repos","events_url":"https://api.github.com/users/smunilla/events{/privacy}","received_events_url":"https://api.github.com/users/smunilla/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-20T13:22:12Z","updated_at":"2016-04-20T13:57:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1778/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1778/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/1778/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/09ac00e5252939d2c270a655bffbd54de8dafc57","head":{"label":"smunilla:wrapper_config","ref":"wrapper_config","sha":"09ac00e5252939d2c270a655bffbd54de8dafc57","user":{"login":"smunilla","id":873968,"avatar_url":"https://avatars.githubusercontent.com/u/873968?v=3","gravatar_id":"","url":"https://api.github.com/users/smunilla","html_url":"https://github.com/smunilla","followers_url":"https://api.github.com/users/smunilla/followers","following_url":"https://api.github.com/users/smunilla/following{/other_user}","gists_url":"https://api.github.com/users/smunilla/gists{/gist_id}","starred_url":"https://api.github.com/users/smunilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smunilla/subscriptions","organizations_url":"https://api.github.com/users/smunilla/orgs","repos_url":"https://api.github.com/users/smunilla/repos","events_url":"https://api.github.com/users/smunilla/events{/privacy}","received_events_url":"https://api.github.com/users/smunilla/received_events","type":"User","site_admin":false},"repo":{"id":43496991,"name":"openshift-ansible","full_name":"smunilla/openshift-ansible","owner":{"login":"smunilla","id":873968,"avatar_url":"https://avatars.githubusercontent.com/u/873968?v=3","gravatar_id":"","url":"https://api.github.com/users/smunilla","html_url":"https://github.com/smunilla","followers_url":"https://api.github.com/users/smunilla/followers","following_url":"https://api.github.com/users/smunilla/following{/other_user}","gists_url":"https://api.github.com/users/smunilla/gists{/gist_id}","starred_url":"https://api.github.com/users/smunilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smunilla/subscriptions","organizations_url":"https://api.github.com/users/smunilla/orgs","repos_url":"https://api.github.com/users/smunilla/repos","events_url":"https://api.github.com/users/smunilla/events{/privacy}","received_events_url":"https://api.github.com/users/smunilla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smunilla/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/smunilla/openshift-ansible","forks_url":"https://api.github.com/repos/smunilla/openshift-ansible/forks","keys_url":"https://api.github.com/repos/smunilla/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smunilla/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smunilla/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/smunilla/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/smunilla/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/smunilla/openshift-ansible/events","assignees_url":"https://api.github.com/repos/smunilla/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/smunilla/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/smunilla/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/smunilla/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smunilla/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smunilla/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/smunilla/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smunilla/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/smunilla/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/smunilla/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/smunilla/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/smunilla/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/smunilla/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/smunilla/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/smunilla/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/smunilla/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/smunilla/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/smunilla/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/smunilla/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smunilla/openshift-ansible/merges","archive_url":"https://api.github.com/repos/smunilla/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smunilla/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/smunilla/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/smunilla/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/smunilla/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/smunilla/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smunilla/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/smunilla/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/smunilla/openshift-ansible/deployments","created_at":"2015-10-01T13:08:40Z","updated_at":"2016-01-12T19:08:33Z","pushed_at":"2016-04-20T13:21:53Z","git_url":"git://github.com/smunilla/openshift-ansible.git","ssh_url":"git@github.com:smunilla/openshift-ansible.git","clone_url":"https://github.com/smunilla/openshift-ansible.git","svn_url":"https://github.com/smunilla/openshift-ansible","homepage":"","size":4204,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"1f490c2374038669df3d2bfcb01af54361f8907e","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Ansible Code","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2016-04-19T08:49:41Z","pushed_at":"2016-04-20T13:39:45Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"install.openshift.com","size":5877,"stargazers_count":154,"watchers_count":154,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":277,"mirror_url":null,"open_issues_count":296,"forks":277,"open_issues":296,"watchers":154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1778"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/1778"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/1778"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/1778/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1778/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/1778/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/09ac00e5252939d2c270a655bffbd54de8dafc57"}}}}