{"action":"created","issue":{"url":"https://api.github.com/repos/deric/puppet-mesos/issues/68","repository_url":"https://api.github.com/repos/deric/puppet-mesos","labels_url":"https://api.github.com/repos/deric/puppet-mesos/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/deric/puppet-mesos/issues/68/comments","events_url":"https://api.github.com/repos/deric/puppet-mesos/issues/68/events","html_url":"https://github.com/deric/puppet-mesos/pull/68","id":143345919,"number":68,"title":"Refactor mesos::property and its spec","user":{"login":"dmitryilyin","id":1746846,"avatar_url":"https://avatars.githubusercontent.com/u/1746846?v=3","gravatar_id":"","url":"https://api.github.com/users/dmitryilyin","html_url":"https://github.com/dmitryilyin","followers_url":"https://api.github.com/users/dmitryilyin/followers","following_url":"https://api.github.com/users/dmitryilyin/following{/other_user}","gists_url":"https://api.github.com/users/dmitryilyin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitryilyin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitryilyin/subscriptions","organizations_url":"https://api.github.com/users/dmitryilyin/orgs","repos_url":"https://api.github.com/users/dmitryilyin/repos","events_url":"https://api.github.com/users/dmitryilyin/events{/privacy}","received_events_url":"https://api.github.com/users/dmitryilyin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-24T20:03:34Z","updated_at":"2016-03-25T10:14:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/deric/puppet-mesos/pulls/68","html_url":"https://github.com/deric/puppet-mesos/pull/68","diff_url":"https://github.com/deric/puppet-mesos/pull/68.diff","patch_url":"https://github.com/deric/puppet-mesos/pull/68.patch"},"body":"* Add newline character to the end of a property value.\r\n  It doesn't mess with values because options are used\r\n  as the command line arguments by the shell\r\n* Refactored property definition with the cleaner code.\r\n  There is no need to treat numeric values differently,\r\n  set default ensure, use pick functions and defaults\r\n  from the params class.\r\n* Rewrite property spec and some other fixes\r\n* Add todo file"},"comment":{"url":"https://api.github.com/repos/deric/puppet-mesos/issues/comments/201228566","html_url":"https://github.com/deric/puppet-mesos/pull/68#issuecomment-201228566","issue_url":"https://api.github.com/repos/deric/puppet-mesos/issues/68","id":201228566,"user":{"login":"deric","id":138573,"avatar_url":"https://avatars.githubusercontent.com/u/138573?v=3","gravatar_id":"","url":"https://api.github.com/users/deric","html_url":"https://github.com/deric","followers_url":"https://api.github.com/users/deric/followers","following_url":"https://api.github.com/users/deric/following{/other_user}","gists_url":"https://api.github.com/users/deric/gists{/gist_id}","starred_url":"https://api.github.com/users/deric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deric/subscriptions","organizations_url":"https://api.github.com/users/deric/orgs","repos_url":"https://api.github.com/users/deric/repos","events_url":"https://api.github.com/users/deric/events{/privacy}","received_events_url":"https://api.github.com/users/deric/received_events","type":"User","site_admin":false},"created_at":"2016-03-25T10:14:35Z","updated_at":"2016-03-25T10:14:35Z","body":"Cool, next time try to be more careful with making too many changes at the same time. It usually (=always) breaks everything. Just few comments:\r\n\r\n * you can't set `notify` in `mesos::property`\r\n```\r\nnotify is a metaparam; this value will inherit to all contained resources in the mesos::property definition\r\n```\r\n *  \"There is no need to treat numeric values differently\" - That's not true. There's a good reason for that. See #47, that code ensure compatibility with future parser and Puppet 4.\r\n\r\nThanks for rewriting the specs, that seems to be a good way to go (though server specs will probably keep the `should` syntax)."}}