{"action":"closed","number":32,"pull_request":{"url":"https://api.github.com/repos/mgholam/fastJSON/pulls/32","id":90863941,"html_url":"https://github.com/mgholam/fastJSON/pull/32","diff_url":"https://github.com/mgholam/fastJSON/pull/32.diff","patch_url":"https://github.com/mgholam/fastJSON/pull/32.patch","issue_url":"https://api.github.com/repos/mgholam/fastJSON/issues/32","number":32,"state":"closed","locked":false,"title":"WriteStringDictionary: use IEnumerable instead of IDictionary","user":{"login":"jo-so","id":23032146,"avatar_url":"https://avatars.githubusercontent.com/u/23032146?v=3","gravatar_id":"","url":"https://api.github.com/users/jo-so","html_url":"https://github.com/jo-so","followers_url":"https://api.github.com/users/jo-so/followers","following_url":"https://api.github.com/users/jo-so/following{/other_user}","gists_url":"https://api.github.com/users/jo-so/gists{/gist_id}","starred_url":"https://api.github.com/users/jo-so/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jo-so/subscriptions","organizations_url":"https://api.github.com/users/jo-so/orgs","repos_url":"https://api.github.com/users/jo-so/repos","events_url":"https://api.github.com/users/jo-so/events{/privacy}","received_events_url":"https://api.github.com/users/jo-so/received_events","type":"User","site_admin":false},"body":"The current code of WriteStringDictionary doesn't use any special methods\r\nof IDictionary. It only requires an IEnumerable<KeyValuePair<string, object>>\r\nwhich eases the serialisation of custom types, because they only have to\r\nimplement the much more lightweight IEnumerable.GetEnumerator().\r\n\r\nSystem.Dynamic.ExpandoObject implements IEnumerable, too, which combines\r\nthe serialisation of ExpandoObject and Dictionary<string, object>.","created_at":"2016-10-25T18:25:30Z","updated_at":"2016-10-26T04:52:22Z","closed_at":"2016-10-26T04:52:22Z","merged_at":"2016-10-26T04:52:22Z","merge_commit_sha":"ab5831cda96c5d7f2e2fb5b454af549199e2a6bf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mgholam/fastJSON/pulls/32/commits","review_comments_url":"https://api.github.com/repos/mgholam/fastJSON/pulls/32/comments","review_comment_url":"https://api.github.com/repos/mgholam/fastJSON/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mgholam/fastJSON/issues/32/comments","statuses_url":"https://api.github.com/repos/mgholam/fastJSON/statuses/7d1dfb7fde7f72dd80a38fc4ff17d3a41f07d169","head":{"label":"jo-so:master","ref":"master","sha":"7d1dfb7fde7f72dd80a38fc4ff17d3a41f07d169","user":{"login":"jo-so","id":23032146,"avatar_url":"https://avatars.githubusercontent.com/u/23032146?v=3","gravatar_id":"","url":"https://api.github.com/users/jo-so","html_url":"https://github.com/jo-so","followers_url":"https://api.github.com/users/jo-so/followers","following_url":"https://api.github.com/users/jo-so/following{/other_user}","gists_url":"https://api.github.com/users/jo-so/gists{/gist_id}","starred_url":"https://api.github.com/users/jo-so/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jo-so/subscriptions","organizations_url":"https://api.github.com/users/jo-so/orgs","repos_url":"https://api.github.com/users/jo-so/repos","events_url":"https://api.github.com/users/jo-so/events{/privacy}","received_events_url":"https://api.github.com/users/jo-so/received_events","type":"User","site_admin":false},"repo":{"id":71795507,"name":"fastJSON","full_name":"jo-so/fastJSON","owner":{"login":"jo-so","id":23032146,"avatar_url":"https://avatars.githubusercontent.com/u/23032146?v=3","gravatar_id":"","url":"https://api.github.com/users/jo-so","html_url":"https://github.com/jo-so","followers_url":"https://api.github.com/users/jo-so/followers","following_url":"https://api.github.com/users/jo-so/following{/other_user}","gists_url":"https://api.github.com/users/jo-so/gists{/gist_id}","starred_url":"https://api.github.com/users/jo-so/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jo-so/subscriptions","organizations_url":"https://api.github.com/users/jo-so/orgs","repos_url":"https://api.github.com/users/jo-so/repos","events_url":"https://api.github.com/users/jo-so/events{/privacy}","received_events_url":"https://api.github.com/users/jo-so/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jo-so/fastJSON","description":"Smallest, fastest polymorphic JSON serializer","fork":true,"url":"https://api.github.com/repos/jo-so/fastJSON","forks_url":"https://api.github.com/repos/jo-so/fastJSON/forks","keys_url":"https://api.github.com/repos/jo-so/fastJSON/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jo-so/fastJSON/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jo-so/fastJSON/teams","hooks_url":"https://api.github.com/repos/jo-so/fastJSON/hooks","issue_events_url":"https://api.github.com/repos/jo-so/fastJSON/issues/events{/number}","events_url":"https://api.github.com/repos/jo-so/fastJSON/events","assignees_url":"https://api.github.com/repos/jo-so/fastJSON/assignees{/user}","branches_url":"https://api.github.com/repos/jo-so/fastJSON/branches{/branch}","tags_url":"https://api.github.com/repos/jo-so/fastJSON/tags","blobs_url":"https://api.github.com/repos/jo-so/fastJSON/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jo-so/fastJSON/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jo-so/fastJSON/git/refs{/sha}","trees_url":"https://api.github.com/repos/jo-so/fastJSON/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jo-so/fastJSON/statuses/{sha}","languages_url":"https://api.github.com/repos/jo-so/fastJSON/languages","stargazers_url":"https://api.github.com/repos/jo-so/fastJSON/stargazers","contributors_url":"https://api.github.com/repos/jo-so/fastJSON/contributors","subscribers_url":"https://api.github.com/repos/jo-so/fastJSON/subscribers","subscription_url":"https://api.github.com/repos/jo-so/fastJSON/subscription","commits_url":"https://api.github.com/repos/jo-so/fastJSON/commits{/sha}","git_commits_url":"https://api.github.com/repos/jo-so/fastJSON/git/commits{/sha}","comments_url":"https://api.github.com/repos/jo-so/fastJSON/comments{/number}","issue_comment_url":"https://api.github.com/repos/jo-so/fastJSON/issues/comments{/number}","contents_url":"https://api.github.com/repos/jo-so/fastJSON/contents/{+path}","compare_url":"https://api.github.com/repos/jo-so/fastJSON/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jo-so/fastJSON/merges","archive_url":"https://api.github.com/repos/jo-so/fastJSON/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jo-so/fastJSON/downloads","issues_url":"https://api.github.com/repos/jo-so/fastJSON/issues{/number}","pulls_url":"https://api.github.com/repos/jo-so/fastJSON/pulls{/number}","milestones_url":"https://api.github.com/repos/jo-so/fastJSON/milestones{/number}","notifications_url":"https://api.github.com/repos/jo-so/fastJSON/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jo-so/fastJSON/labels{/name}","releases_url":"https://api.github.com/repos/jo-so/fastJSON/releases{/id}","deployments_url":"https://api.github.com/repos/jo-so/fastJSON/deployments","created_at":"2016-10-24T14:07:47Z","updated_at":"2016-10-24T14:07:48Z","pushed_at":"2016-10-24T14:29:42Z","git_url":"git://github.com/jo-so/fastJSON.git","ssh_url":"git@github.com:jo-so/fastJSON.git","clone_url":"https://github.com/jo-so/fastJSON.git","svn_url":"https://github.com/jo-so/fastJSON","homepage":"http://www.codeproject.com/KB/IP/fastJSON.aspx","size":401,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mgholam:master","ref":"master","sha":"f90636a69532ed4246970aaccf6ae2676a23f46e","user":{"login":"mgholam","id":460565,"avatar_url":"https://avatars.githubusercontent.com/u/460565?v=3","gravatar_id":"","url":"https://api.github.com/users/mgholam","html_url":"https://github.com/mgholam","followers_url":"https://api.github.com/users/mgholam/followers","following_url":"https://api.github.com/users/mgholam/following{/other_user}","gists_url":"https://api.github.com/users/mgholam/gists{/gist_id}","starred_url":"https://api.github.com/users/mgholam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgholam/subscriptions","organizations_url":"https://api.github.com/users/mgholam/orgs","repos_url":"https://api.github.com/users/mgholam/repos","events_url":"https://api.github.com/users/mgholam/events{/privacy}","received_events_url":"https://api.github.com/users/mgholam/received_events","type":"User","site_admin":false},"repo":{"id":1540305,"name":"fastJSON","full_name":"mgholam/fastJSON","owner":{"login":"mgholam","id":460565,"avatar_url":"https://avatars.githubusercontent.com/u/460565?v=3","gravatar_id":"","url":"https://api.github.com/users/mgholam","html_url":"https://github.com/mgholam","followers_url":"https://api.github.com/users/mgholam/followers","following_url":"https://api.github.com/users/mgholam/following{/other_user}","gists_url":"https://api.github.com/users/mgholam/gists{/gist_id}","starred_url":"https://api.github.com/users/mgholam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgholam/subscriptions","organizations_url":"https://api.github.com/users/mgholam/orgs","repos_url":"https://api.github.com/users/mgholam/repos","events_url":"https://api.github.com/users/mgholam/events{/privacy}","received_events_url":"https://api.github.com/users/mgholam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgholam/fastJSON","description":"Smallest, fastest polymorphic JSON serializer","fork":false,"url":"https://api.github.com/repos/mgholam/fastJSON","forks_url":"https://api.github.com/repos/mgholam/fastJSON/forks","keys_url":"https://api.github.com/repos/mgholam/fastJSON/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgholam/fastJSON/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgholam/fastJSON/teams","hooks_url":"https://api.github.com/repos/mgholam/fastJSON/hooks","issue_events_url":"https://api.github.com/repos/mgholam/fastJSON/issues/events{/number}","events_url":"https://api.github.com/repos/mgholam/fastJSON/events","assignees_url":"https://api.github.com/repos/mgholam/fastJSON/assignees{/user}","branches_url":"https://api.github.com/repos/mgholam/fastJSON/branches{/branch}","tags_url":"https://api.github.com/repos/mgholam/fastJSON/tags","blobs_url":"https://api.github.com/repos/mgholam/fastJSON/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgholam/fastJSON/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgholam/fastJSON/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgholam/fastJSON/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgholam/fastJSON/statuses/{sha}","languages_url":"https://api.github.com/repos/mgholam/fastJSON/languages","stargazers_url":"https://api.github.com/repos/mgholam/fastJSON/stargazers","contributors_url":"https://api.github.com/repos/mgholam/fastJSON/contributors","subscribers_url":"https://api.github.com/repos/mgholam/fastJSON/subscribers","subscription_url":"https://api.github.com/repos/mgholam/fastJSON/subscription","commits_url":"https://api.github.com/repos/mgholam/fastJSON/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgholam/fastJSON/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgholam/fastJSON/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgholam/fastJSON/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgholam/fastJSON/contents/{+path}","compare_url":"https://api.github.com/repos/mgholam/fastJSON/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgholam/fastJSON/merges","archive_url":"https://api.github.com/repos/mgholam/fastJSON/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgholam/fastJSON/downloads","issues_url":"https://api.github.com/repos/mgholam/fastJSON/issues{/number}","pulls_url":"https://api.github.com/repos/mgholam/fastJSON/pulls{/number}","milestones_url":"https://api.github.com/repos/mgholam/fastJSON/milestones{/number}","notifications_url":"https://api.github.com/repos/mgholam/fastJSON/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgholam/fastJSON/labels{/name}","releases_url":"https://api.github.com/repos/mgholam/fastJSON/releases{/id}","deployments_url":"https://api.github.com/repos/mgholam/fastJSON/deployments","created_at":"2011-03-29T06:54:34Z","updated_at":"2016-10-25T07:18:14Z","pushed_at":"2016-10-26T04:52:22Z","git_url":"git://github.com/mgholam/fastJSON.git","ssh_url":"git@github.com:mgholam/fastJSON.git","clone_url":"https://github.com/mgholam/fastJSON.git","svn_url":"https://github.com/mgholam/fastJSON","homepage":"http://www.codeproject.com/KB/IP/fastJSON.aspx","size":494,"stargazers_count":128,"watchers_count":128,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":9,"forks":47,"open_issues":9,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mgholam/fastJSON/pulls/32"},"html":{"href":"https://github.com/mgholam/fastJSON/pull/32"},"issue":{"href":"https://api.github.com/repos/mgholam/fastJSON/issues/32"},"comments":{"href":"https://api.github.com/repos/mgholam/fastJSON/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/mgholam/fastJSON/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/mgholam/fastJSON/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mgholam/fastJSON/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/mgholam/fastJSON/statuses/7d1dfb7fde7f72dd80a38fc4ff17d3a41f07d169"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mgholam","id":460565,"avatar_url":"https://avatars.githubusercontent.com/u/460565?v=3","gravatar_id":"","url":"https://api.github.com/users/mgholam","html_url":"https://github.com/mgholam","followers_url":"https://api.github.com/users/mgholam/followers","following_url":"https://api.github.com/users/mgholam/following{/other_user}","gists_url":"https://api.github.com/users/mgholam/gists{/gist_id}","starred_url":"https://api.github.com/users/mgholam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgholam/subscriptions","organizations_url":"https://api.github.com/users/mgholam/orgs","repos_url":"https://api.github.com/users/mgholam/repos","events_url":"https://api.github.com/users/mgholam/events{/privacy}","received_events_url":"https://api.github.com/users/mgholam/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"mgholam"}}