{"action":"created","issue":{"url":"https://api.github.com/repos/edenhill/librdkafka/issues/883","repository_url":"https://api.github.com/repos/edenhill/librdkafka","labels_url":"https://api.github.com/repos/edenhill/librdkafka/issues/883/labels{/name}","comments_url":"https://api.github.com/repos/edenhill/librdkafka/issues/883/comments","events_url":"https://api.github.com/repos/edenhill/librdkafka/issues/883/events","html_url":"https://github.com/edenhill/librdkafka/pull/883","id":186808084,"number":883,"title":"Enrichment of Conf getter for callbacks.","user":{"login":"vin-d","id":20186331,"avatar_url":"https://avatars.githubusercontent.com/u/20186331?v=3","gravatar_id":"","url":"https://api.github.com/users/vin-d","html_url":"https://github.com/vin-d","followers_url":"https://api.github.com/users/vin-d/followers","following_url":"https://api.github.com/users/vin-d/following{/other_user}","gists_url":"https://api.github.com/users/vin-d/gists{/gist_id}","starred_url":"https://api.github.com/users/vin-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vin-d/subscriptions","organizations_url":"https://api.github.com/users/vin-d/orgs","repos_url":"https://api.github.com/users/vin-d/repos","events_url":"https://api.github.com/users/vin-d/events{/privacy}","received_events_url":"https://api.github.com/users/vin-d/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-02T13:59:32Z","updated_at":"2016-11-02T14:57:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edenhill/librdkafka/pulls/883","html_url":"https://github.com/edenhill/librdkafka/pull/883","diff_url":"https://github.com/edenhill/librdkafka/pull/883.diff","patch_url":"https://github.com/edenhill/librdkafka/pull/883.patch"},"body":"for issue #878\nAs the (C++) Conf setters do not forward callbacks in the C struct like with other parameters, special getter should be used to read the callbacks from the Conf.\nThis update also blocks the original Getter(String&, String&) to get the callbacks from the C struct."},"comment":{"url":"https://api.github.com/repos/edenhill/librdkafka/issues/comments/257889764","html_url":"https://github.com/edenhill/librdkafka/pull/883#issuecomment-257889764","issue_url":"https://api.github.com/repos/edenhill/librdkafka/issues/883","id":257889764,"user":{"login":"vin-d","id":20186331,"avatar_url":"https://avatars.githubusercontent.com/u/20186331?v=3","gravatar_id":"","url":"https://api.github.com/users/vin-d","html_url":"https://github.com/vin-d","followers_url":"https://api.github.com/users/vin-d/followers","following_url":"https://api.github.com/users/vin-d/following{/other_user}","gists_url":"https://api.github.com/users/vin-d/gists{/gist_id}","starred_url":"https://api.github.com/users/vin-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vin-d/subscriptions","organizations_url":"https://api.github.com/users/vin-d/orgs","repos_url":"https://api.github.com/users/vin-d/repos","events_url":"https://api.github.com/users/vin-d/events{/privacy}","received_events_url":"https://api.github.com/users/vin-d/received_events","type":"User","site_admin":false},"created_at":"2016-11-02T14:57:19Z","updated_at":"2016-11-02T14:57:19Z","body":"I started using the get() only for a mock KafkaConsumer object and, while\n only looking at the doxygen docs I wasn't aware that Conf didn't forward\ncallbacks to the c version of librdkafka, and that the get(string&,\nstring&) wasn't the way to do that.\n\nReading the source files I figured out that a KafkaConsumer directly reads\nthe callback variable from the Conf without using a getter. I thought that\na getter would still be a good thing to have a complete Conf interface and\nricher Doxygen docs.\n\n\nOn Wed, Nov 2, 2016 at 3:48 PM, Magnus Edenhill <notifications@github.com>\nwrote:\n\n> What are you using the get() interface for?\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/edenhill/librdkafka/pull/883#issuecomment-257886934>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ATQE25o8bmgELJx4JBPEN8D6R5uVYVqNks5q6KLBgaJpZM4KnRD->\n> .\n>\n\n-- \nThe information transmitted is intended only for the person or entity to \nwhich it is addressed and may contain confidential and/or privileged \nmaterial. Any review, retransmission, dissemination or other use of, or \ntaking of any action in reliance upon, this information by persons or \nentities other than the intended recipient is prohibited. If you received \nthis in error, please contact the sender and delete the material from any \ncomputer.\n"}}
{"actor":{"display_login":"vin-d"}}