{"action":"created","issue":{"url":"https://api.github.com/repos/OpenShot/libopenshot/issues/27","repository_url":"https://api.github.com/repos/OpenShot/libopenshot","labels_url":"https://api.github.com/repos/OpenShot/libopenshot/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/OpenShot/libopenshot/issues/27/comments","events_url":"https://api.github.com/repos/OpenShot/libopenshot/issues/27/events","html_url":"https://github.com/OpenShot/libopenshot/issues/27","id":148788631,"number":27,"title":"Tests fail to compile when imagemagick is not available","user":{"login":"sbraz","id":4833332,"avatar_url":"https://avatars.githubusercontent.com/u/4833332?v=3","gravatar_id":"","url":"https://api.github.com/users/sbraz","html_url":"https://github.com/sbraz","followers_url":"https://api.github.com/users/sbraz/followers","following_url":"https://api.github.com/users/sbraz/following{/other_user}","gists_url":"https://api.github.com/users/sbraz/gists{/gist_id}","starred_url":"https://api.github.com/users/sbraz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbraz/subscriptions","organizations_url":"https://api.github.com/users/sbraz/orgs","repos_url":"https://api.github.com/users/sbraz/repos","events_url":"https://api.github.com/users/sbraz/events{/privacy}","received_events_url":"https://api.github.com/users/sbraz/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-15T23:04:47Z","updated_at":"2016-04-19T17:19:07Z","closed_at":"2016-04-19T17:19:07Z","body":"I understand that imagemagick is now supposed to be completely optional. However, tests fail to compile when imagemagick is not available:\r\n```\r\n[ 97%] Linking CXX executable openshot-test\r\nCMakeFiles/openshot-test.dir/ImageWriter_Tests.cpp.o: In function `TestImageWriter_Test_Gif::RunImpl() const':\r\n/tmp/libopenshot/tests/ImageWriter_Tests.cpp:45: undefined reference to `openshot::ImageWriter::ImageWriter(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)'\r\n/tmp/libopenshot/tests/ImageWriter_Tests.cpp:48: undefined reference to `openshot::ImageWriter::SetVideoOptions(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, openshot::Fraction, int, int, int, int, bool)'\r\n/tmp/libopenshot/tests/ImageWriter_Tests.cpp:51: undefined reference to `openshot::ImageWriter::Open()'\r\n/tmp/libopenshot/tests/ImageWriter_Tests.cpp:54: undefined reference to `openshot::ImageWriter::WriteFrame(openshot::ReaderBase*, long, long)'\r\n/tmp/libopenshot/tests/ImageWriter_Tests.cpp:57: undefined reference to `openshot::ImageWriter::Close()'\r\n/tmp/libopenshot/tests/ImageWriter_Tests.cpp:61: undefined reference to `openshot::ImageReader::ImageReader(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)'\r\n/tmp/libopenshot/tests/ImageWriter_Tests.cpp:62: undefined reference to `openshot::ImageReader::Open()'\r\n/tmp/libopenshot/tests/ImageWriter_Tests.cpp:69: undefined reference to `openshot::ImageReader::GetFrame(long)'\r\nCMakeFiles/openshot-test.dir/ImageWriter_Tests.cpp.o: In function `openshot::ImageWriter::~ImageWriter()':\r\n/tmp/libopenshot/tests/../include/ImageWriter.h:86: undefined reference to `vtable for openshot::ImageWriter'\r\nCMakeFiles/openshot-test.dir/ImageWriter_Tests.cpp.o: In function `openshot::ImageReader::~ImageReader()':\r\n/tmp/libopenshot/tests/../include/effects/../ImageReader.h:67: undefined reference to `vtable for openshot::ImageReader'\r\ncollect2: error: ld returned 1 exit status\r\ntests/CMakeFiles/openshot-test.dir/build.make:447: recipe for target 'tests/openshot-test' failed\r\nmake[2]: *** [tests/openshot-test] Error 1\r\nCMakeFiles/Makefile2:352: recipe for target 'tests/CMakeFiles/openshot-test.dir/all' failed\r\nmake[1]: *** [tests/CMakeFiles/openshot-test.dir/all] Error 2\r\nmake[1]: *** Waiting for unfinished jobs....\r\n```"},"comment":{"url":"https://api.github.com/repos/OpenShot/libopenshot/issues/comments/212024443","html_url":"https://github.com/OpenShot/libopenshot/issues/27#issuecomment-212024443","issue_url":"https://api.github.com/repos/OpenShot/libopenshot/issues/27","id":212024443,"user":{"login":"sbraz","id":4833332,"avatar_url":"https://avatars.githubusercontent.com/u/4833332?v=3","gravatar_id":"","url":"https://api.github.com/users/sbraz","html_url":"https://github.com/sbraz","followers_url":"https://api.github.com/users/sbraz/followers","following_url":"https://api.github.com/users/sbraz/following{/other_user}","gists_url":"https://api.github.com/users/sbraz/gists{/gist_id}","starred_url":"https://api.github.com/users/sbraz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbraz/subscriptions","organizations_url":"https://api.github.com/users/sbraz/orgs","repos_url":"https://api.github.com/users/sbraz/repos","events_url":"https://api.github.com/users/sbraz/events{/privacy}","received_events_url":"https://api.github.com/users/sbraz/received_events","type":"User","site_admin":false},"created_at":"2016-04-19T17:19:07Z","updated_at":"2016-04-19T17:19:07Z","body":"I think the issue was only present when I tried to comment out imagemagick detection."}}