{"push_id":966335127,"size":6,"distinct_size":1,"ref":"refs/heads/orders-modern-ui","head":"01a454a6092499843444a62ef0514cdd252a5f3a","before":"dbc456a9485c143c9cd22833e9ae422c2cd2cb56","commits":[{"sha":"f1d5a8b345592a4168805c812e188171a45be121","author":{"email":"d9b599957bd54c22143053c16557076ca2185dbd@mantisbt.org","name":"Damien Regad"},"message":"Insert file attachments records in a single step\n\nCommit 12a7f8342b9df21b694a7c0bf23f251230add2ad split the attachment of\na BLOB in the bug_file and project_file tables in 2 steps, first\ninserting the record, then updating it to add the BLOB's content.\n\nThis introduced a regression with MySQL when SQL_MODE is set to\nSTRICT_ALL_TABLES and the database was created pre 1.3.x and\nsubsequently upgraded. In 1.2, BLOB columns are created with a NOT NULL\nattribute, due to custom ADOdb code (see 19dbfb0e290a30fcfe1ec29566e611d36c1c7aa9)\n\nThis reverts the behavior to what it was before 12a7f834, i.e. execute a\nsingle INSERT statement that also populates the BLOB (except with Oracle\nwhich requires this to occur as a separate operation).\n\nFixes #20547","distinct":false,"url":"https://api.github.com/repos/badfiles/mantisbt/commits/f1d5a8b345592a4168805c812e188171a45be121"},{"sha":"a3e52aab0964ca644a8c0714e3ab35e980e32ded","author":{"email":"d9b599957bd54c22143053c16557076ca2185dbd@mantisbt.org","name":"Damien Regad"},"message":"Ensure consistent definition blob columns\n\nIn 1.2.x, custom code in adodb-datadict.inc.php disabled silent dropping\nof NOT NULL attribute (see 19dbfb0e290a30fcfe1ec29566e611d36c1c7aa9).\nConsequently, BLOBs columns created in that version do not allow NULL\nvalues:\n\nmysql> desc mantis_bug_file_table content;\n+---------+----------+------+-----+---------+-------+\n| Field   | Type     | Null | Key | Default | Extra |\n+---------+----------+------+-----+---------+-------+\n| content | longblob | NO   |     | NULL    |       |\n+---------+----------+------+-----+---------+-------+\n\nIn 1.3, we reverted to standard ADOdb behavior, so the NOT NULL\nattribute is ignored by the data dictionary and BLOB columns are\nallowed to be NULL:\n\nmysql> desc mantis_bug_file_table content;\n+---------+----------+------+-----+---------+-------+\n| Field   | Type     | Null | Key | Default | Extra |\n+---------+----------+------+-----+---------+-------+\n| content | longblob | YES  |     | NULL    |       |\n+---------+----------+------+-----+---------+-------+\n\nThis results in an inconsistent schema definition between instances\nupgraded from 1.2.x to 1.3.x, vs created straight in 1.3.x.\n\nTo avoid any issues due to this situation, we add 2 schema steps to\nupdate the BLOB columns so they allow NULL values.\n\nIssue #20547","distinct":false,"url":"https://api.github.com/repos/badfiles/mantisbt/commits/a3e52aab0964ca644a8c0714e3ab35e980e32ded"},{"sha":"c7a47d315db2d129a7061d9df0a0c58e573bc8bf","author":{"email":"d9b599957bd54c22143053c16557076ca2185dbd@mantisbt.org","name":"Damien Regad"},"message":"Fix file attachment for PostgreSQL\n\nUse of an associative array causes issues with pgsql as it expects a\n0-based numeric array for the query parameters.\n\nIssue #20547","distinct":false,"url":"https://api.github.com/repos/badfiles/mantisbt/commits/c7a47d315db2d129a7061d9df0a0c58e573bc8bf"},{"sha":"53245f5c6397f74148a8cc6ddea9e38df2f47f77","author":{"email":"d9b599957bd54c22143053c16557076ca2185dbd@mantisbt.org","name":"Damien Regad"},"message":"Fix #20547: attachments upload","distinct":false,"url":"https://api.github.com/repos/badfiles/mantisbt/commits/53245f5c6397f74148a8cc6ddea9e38df2f47f77"},{"sha":"529c252524b2f9f47ce35cf009ff738ca1e39f99","author":{"email":"27968274357841f2ce0c43cd5b9203717ac3fdf7@mail.ru","name":"root"},"message":"Merge branch 'master' into master-modern-ui","distinct":false,"url":"https://api.github.com/repos/badfiles/mantisbt/commits/529c252524b2f9f47ce35cf009ff738ca1e39f99"},{"sha":"01a454a6092499843444a62ef0514cdd252a5f3a","author":{"email":"27968274357841f2ce0c43cd5b9203717ac3fdf7@mail.ru","name":"root"},"message":"fix conflict","distinct":true,"url":"https://api.github.com/repos/badfiles/mantisbt/commits/01a454a6092499843444a62ef0514cdd252a5f3a"}]}