{"action":"created","comment":{"url":"https://api.github.com/repos/druid-io/druid/pulls/comments/82545471","pull_request_review_id":3445791,"id":82545471,"diff_hunk":"@@ -82,6 +83,7 @@ public AggregatorsModule()\n \n   @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = \"type\")\n   @JsonSubTypes(value = {\n+      @JsonSubTypes.Type(name = \"math\", value = MathPostAggregator.class),","path":"processing/src/main/java/io/druid/jackson/AggregatorsModule.java","position":12,"original_position":12,"commit_id":"2df3d6cee2e53c0b2b8c322d6207fdaeba5f945a","original_commit_id":"2df3d6cee2e53c0b2b8c322d6207fdaeba5f945a","user":{"login":"navis","id":809395,"avatar_url":"https://avatars.githubusercontent.com/u/809395?v=3","gravatar_id":"","url":"https://api.github.com/users/navis","html_url":"https://github.com/navis","followers_url":"https://api.github.com/users/navis/followers","following_url":"https://api.github.com/users/navis/following{/other_user}","gists_url":"https://api.github.com/users/navis/gists{/gist_id}","starred_url":"https://api.github.com/users/navis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navis/subscriptions","organizations_url":"https://api.github.com/users/navis/orgs","repos_url":"https://api.github.com/users/navis/repos","events_url":"https://api.github.com/users/navis/events{/privacy}","received_events_url":"https://api.github.com/users/navis/received_events","type":"User","site_admin":false},"body":"sure","created_at":"2016-10-10T05:40:33Z","updated_at":"2016-10-10T05:40:33Z","html_url":"https://github.com/druid-io/druid/pull/2783#discussion_r82545471","pull_request_url":"https://api.github.com/repos/druid-io/druid/pulls/2783","_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments/82545471"},"html":{"href":"https://github.com/druid-io/druid/pull/2783#discussion_r82545471"},"pull_request":{"href":"https://api.github.com/repos/druid-io/druid/pulls/2783"}}},"pull_request":{"url":"https://api.github.com/repos/druid-io/druid/pulls/2783","id":65110227,"html_url":"https://github.com/druid-io/druid/pull/2783","diff_url":"https://github.com/druid-io/druid/pull/2783.diff","patch_url":"https://github.com/druid-io/druid/pull/2783.patch","issue_url":"https://api.github.com/repos/druid-io/druid/issues/2783","number":2783,"state":"open","locked":false,"title":"Math expressional parameters for aggregator","user":{"login":"navis","id":809395,"avatar_url":"https://avatars.githubusercontent.com/u/809395?v=3","gravatar_id":"","url":"https://api.github.com/users/navis","html_url":"https://github.com/navis","followers_url":"https://api.github.com/users/navis/followers","following_url":"https://api.github.com/users/navis/following{/other_user}","gists_url":"https://api.github.com/users/navis/gists{/gist_id}","starred_url":"https://api.github.com/users/navis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navis/subscriptions","organizations_url":"https://api.github.com/users/navis/orgs","repos_url":"https://api.github.com/users/navis/repos","events_url":"https://api.github.com/users/navis/events{/privacy}","received_events_url":"https://api.github.com/users/navis/received_events","type":"User","site_admin":false},"body":"Someone wanted druid to support expressional parameter for aggregator something like `sum(a + b / c)`. I don't know why it's needed either but this is it. Will make propose in dev mailing list soon after. \r\n\r\nBased on great work(#2090) of @himanshug.","created_at":"2016-04-04T08:29:14Z","updated_at":"2016-10-10T05:40:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66b1f09219d5396c31914de828ae184ea73f15e0","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/druid-io/druid/milestones/21","html_url":"https://github.com/druid-io/druid/milestones/0.9.3","labels_url":"https://api.github.com/repos/druid-io/druid/milestones/21/labels","id":1831000,"number":21,"title":"0.9.3","description":"","creator":{"login":"fjy","id":428325,"avatar_url":"https://avatars.githubusercontent.com/u/428325?v=3","gravatar_id":"","url":"https://api.github.com/users/fjy","html_url":"https://github.com/fjy","followers_url":"https://api.github.com/users/fjy/followers","following_url":"https://api.github.com/users/fjy/following{/other_user}","gists_url":"https://api.github.com/users/fjy/gists{/gist_id}","starred_url":"https://api.github.com/users/fjy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjy/subscriptions","organizations_url":"https://api.github.com/users/fjy/orgs","repos_url":"https://api.github.com/users/fjy/repos","events_url":"https://api.github.com/users/fjy/events{/privacy}","received_events_url":"https://api.github.com/users/fjy/received_events","type":"User","site_admin":false},"open_issues":46,"closed_issues":11,"state":"open","created_at":"2016-06-15T22:35:58Z","updated_at":"2016-10-07T21:48:00Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/druid-io/druid/pulls/2783/commits","review_comments_url":"https://api.github.com/repos/druid-io/druid/pulls/2783/comments","review_comment_url":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/druid-io/druid/issues/2783/comments","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/2df3d6cee2e53c0b2b8c322d6207fdaeba5f945a","head":{"label":"navis:expression-paramed-aggregator","ref":"expression-paramed-aggregator","sha":"2df3d6cee2e53c0b2b8c322d6207fdaeba5f945a","user":{"login":"navis","id":809395,"avatar_url":"https://avatars.githubusercontent.com/u/809395?v=3","gravatar_id":"","url":"https://api.github.com/users/navis","html_url":"https://github.com/navis","followers_url":"https://api.github.com/users/navis/followers","following_url":"https://api.github.com/users/navis/following{/other_user}","gists_url":"https://api.github.com/users/navis/gists{/gist_id}","starred_url":"https://api.github.com/users/navis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navis/subscriptions","organizations_url":"https://api.github.com/users/navis/orgs","repos_url":"https://api.github.com/users/navis/repos","events_url":"https://api.github.com/users/navis/events{/privacy}","received_events_url":"https://api.github.com/users/navis/received_events","type":"User","site_admin":false},"repo":{"id":45149930,"name":"druid","full_name":"navis/druid","owner":{"login":"navis","id":809395,"avatar_url":"https://avatars.githubusercontent.com/u/809395?v=3","gravatar_id":"","url":"https://api.github.com/users/navis","html_url":"https://github.com/navis","followers_url":"https://api.github.com/users/navis/followers","following_url":"https://api.github.com/users/navis/following{/other_user}","gists_url":"https://api.github.com/users/navis/gists{/gist_id}","starred_url":"https://api.github.com/users/navis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navis/subscriptions","organizations_url":"https://api.github.com/users/navis/orgs","repos_url":"https://api.github.com/users/navis/repos","events_url":"https://api.github.com/users/navis/events{/privacy}","received_events_url":"https://api.github.com/users/navis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/navis/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":true,"url":"https://api.github.com/repos/navis/druid","forks_url":"https://api.github.com/repos/navis/druid/forks","keys_url":"https://api.github.com/repos/navis/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/navis/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/navis/druid/teams","hooks_url":"https://api.github.com/repos/navis/druid/hooks","issue_events_url":"https://api.github.com/repos/navis/druid/issues/events{/number}","events_url":"https://api.github.com/repos/navis/druid/events","assignees_url":"https://api.github.com/repos/navis/druid/assignees{/user}","branches_url":"https://api.github.com/repos/navis/druid/branches{/branch}","tags_url":"https://api.github.com/repos/navis/druid/tags","blobs_url":"https://api.github.com/repos/navis/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/navis/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/navis/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/navis/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/navis/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/navis/druid/languages","stargazers_url":"https://api.github.com/repos/navis/druid/stargazers","contributors_url":"https://api.github.com/repos/navis/druid/contributors","subscribers_url":"https://api.github.com/repos/navis/druid/subscribers","subscription_url":"https://api.github.com/repos/navis/druid/subscription","commits_url":"https://api.github.com/repos/navis/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/navis/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/navis/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/navis/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/navis/druid/contents/{+path}","compare_url":"https://api.github.com/repos/navis/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/navis/druid/merges","archive_url":"https://api.github.com/repos/navis/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/navis/druid/downloads","issues_url":"https://api.github.com/repos/navis/druid/issues{/number}","pulls_url":"https://api.github.com/repos/navis/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/navis/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/navis/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/navis/druid/labels{/name}","releases_url":"https://api.github.com/repos/navis/druid/releases{/id}","deployments_url":"https://api.github.com/repos/navis/druid/deployments","created_at":"2015-10-29T00:22:35Z","updated_at":"2015-10-29T00:22:47Z","pushed_at":"2016-10-10T05:16:33Z","git_url":"git://github.com/navis/druid.git","ssh_url":"git@github.com:navis/druid.git","clone_url":"https://github.com/navis/druid.git","svn_url":"https://github.com/navis/druid","homepage":"http://druid.io","size":110070,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"druid-io:master","ref":"master","sha":"05ea88df5c1d5aac57e5217f25fad1b6787fe679","user":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":6358188,"name":"druid","full_name":"druid-io/druid","owner":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druid-io/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":false,"url":"https://api.github.com/repos/druid-io/druid","forks_url":"https://api.github.com/repos/druid-io/druid/forks","keys_url":"https://api.github.com/repos/druid-io/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/druid/teams","hooks_url":"https://api.github.com/repos/druid-io/druid/hooks","issue_events_url":"https://api.github.com/repos/druid-io/druid/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/druid/events","assignees_url":"https://api.github.com/repos/druid-io/druid/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/druid/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/druid/tags","blobs_url":"https://api.github.com/repos/druid-io/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/druid/languages","stargazers_url":"https://api.github.com/repos/druid-io/druid/stargazers","contributors_url":"https://api.github.com/repos/druid-io/druid/contributors","subscribers_url":"https://api.github.com/repos/druid-io/druid/subscribers","subscription_url":"https://api.github.com/repos/druid-io/druid/subscription","commits_url":"https://api.github.com/repos/druid-io/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/druid-io/druid/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/druid/merges","archive_url":"https://api.github.com/repos/druid-io/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/druid/downloads","issues_url":"https://api.github.com/repos/druid-io/druid/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/druid/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/druid/releases{/id}","deployments_url":"https://api.github.com/repos/druid-io/druid/deployments","created_at":"2012-10-23T19:08:07Z","updated_at":"2016-10-09T13:12:51Z","pushed_at":"2016-10-10T05:23:30Z","git_url":"git://github.com/druid-io/druid.git","ssh_url":"git@github.com:druid-io/druid.git","clone_url":"https://github.com/druid-io/druid.git","svn_url":"https://github.com/druid-io/druid","homepage":"http://druid.io","size":157119,"stargazers_count":3783,"watchers_count":3783,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":889,"mirror_url":null,"open_issues_count":549,"forks":889,"open_issues":549,"watchers":3783,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/2783"},"html":{"href":"https://github.com/druid-io/druid/pull/2783"},"issue":{"href":"https://api.github.com/repos/druid-io/druid/issues/2783"},"comments":{"href":"https://api.github.com/repos/druid-io/druid/issues/2783/comments"},"review_comments":{"href":"https://api.github.com/repos/druid-io/druid/pulls/2783/comments"},"review_comment":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/druid-io/druid/pulls/2783/commits"},"statuses":{"href":"https://api.github.com/repos/druid-io/druid/statuses/2df3d6cee2e53c0b2b8c322d6207fdaeba5f945a"}}}}
{"actor":{"display_login":"navis"}}