{"action":"created","comment":{"url":"https://api.github.com/repos/pydata/pandas/pulls/comments/56769939","id":56769939,"diff_hunk":"@@ -301,6 +301,20 @@ def _update_inplace(self, result, **kwargs):\n         # we want to call the generic version and not the IndexOpsMixin\n         return generic.NDFrame._update_inplace(self, result, **kwargs)\n \n+    @property\n+    def name(self):\n+        return self._name\n+\n+    @name.setter\n+    def name(self, value):\n+        if value is not None:\n+            if com.is_hashable(value):","path":"pandas/core/series.py","position":11,"original_position":11,"commit_id":"7111a7e5435c89f69c2e98b88ffa0aa3298ae039","original_commit_id":"7111a7e5435c89f69c2e98b88ffa0aa3298ae039","user":{"login":"chinskiy","id":4370169,"avatar_url":"https://avatars.githubusercontent.com/u/4370169?v=3","gravatar_id":"","url":"https://api.github.com/users/chinskiy","html_url":"https://github.com/chinskiy","followers_url":"https://api.github.com/users/chinskiy/followers","following_url":"https://api.github.com/users/chinskiy/following{/other_user}","gists_url":"https://api.github.com/users/chinskiy/gists{/gist_id}","starred_url":"https://api.github.com/users/chinskiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinskiy/subscriptions","organizations_url":"https://api.github.com/users/chinskiy/orgs","repos_url":"https://api.github.com/users/chinskiy/repos","events_url":"https://api.github.com/users/chinskiy/events{/privacy}","received_events_url":"https://api.github.com/users/chinskiy/received_events","type":"User","site_admin":false},"body":"Ok, but how better add object.__setattr__(self, '_name', value) to this code?\r\nobject.__setattr__(self, '_name', None) only if name attribute not added.","created_at":"2016-03-20T19:11:01Z","updated_at":"2016-03-20T19:11:01Z","html_url":"https://github.com/pydata/pandas/pull/12612#discussion_r56769939","pull_request_url":"https://api.github.com/repos/pydata/pandas/pulls/12612","_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/56769939"},"html":{"href":"https://github.com/pydata/pandas/pull/12612#discussion_r56769939"},"pull_request":{"href":"https://api.github.com/repos/pydata/pandas/pulls/12612"}}},"pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/12612","id":62688217,"html_url":"https://github.com/pydata/pandas/pull/12612","diff_url":"https://github.com/pydata/pandas/pull/12612.diff","patch_url":"https://github.com/pydata/pandas/pull/12612.patch","issue_url":"https://api.github.com/repos/pydata/pandas/issues/12612","number":12612,"state":"open","locked":false,"title":"BUG: ensure Series.name is hashable, #12610 ","user":{"login":"chinskiy","id":4370169,"avatar_url":"https://avatars.githubusercontent.com/u/4370169?v=3","gravatar_id":"","url":"https://api.github.com/users/chinskiy","html_url":"https://github.com/chinskiy","followers_url":"https://api.github.com/users/chinskiy/followers","following_url":"https://api.github.com/users/chinskiy/following{/other_user}","gists_url":"https://api.github.com/users/chinskiy/gists{/gist_id}","starred_url":"https://api.github.com/users/chinskiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinskiy/subscriptions","organizations_url":"https://api.github.com/users/chinskiy/orgs","repos_url":"https://api.github.com/users/chinskiy/repos","events_url":"https://api.github.com/users/chinskiy/events{/privacy}","received_events_url":"https://api.github.com/users/chinskiy/received_events","type":"User","site_admin":false},"body":" - [ ] closes #12610\r\n - [x] tests added / passed\r\n - [x] passes ``git diff upstream/master | flake8 --diff``\r\n\r\npandas >= 0.18.0 will no longer support compatibility with Python version 2.6 and since Python 2.6 we can use the abstract base class collections.Hashable.","created_at":"2016-03-13T23:51:26Z","updated_at":"2016-03-20T19:11:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e0409b05f6657cde87928abd4d1cc5745498447","assignee":null,"milestone":{"url":"https://api.github.com/repos/pydata/pandas/milestones/38","html_url":"https://github.com/pydata/pandas/milestones/0.18.1","labels_url":"https://api.github.com/repos/pydata/pandas/milestones/38/labels","id":1570594,"number":38,"title":"0.18.1","description":"after 0.18.0 of course!","creator":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"open_issues":161,"closed_issues":40,"state":"open","created_at":"2016-02-08T15:29:59Z","updated_at":"2016-03-20T15:31:10Z","due_on":"2016-04-26T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pydata/pandas/pulls/12612/commits","review_comments_url":"https://api.github.com/repos/pydata/pandas/pulls/12612/comments","review_comment_url":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/12612/comments","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/7111a7e5435c89f69c2e98b88ffa0aa3298ae039","head":{"label":"chinskiy:pandas_series_name_attribute","ref":"pandas_series_name_attribute","sha":"7111a7e5435c89f69c2e98b88ffa0aa3298ae039","user":{"login":"chinskiy","id":4370169,"avatar_url":"https://avatars.githubusercontent.com/u/4370169?v=3","gravatar_id":"","url":"https://api.github.com/users/chinskiy","html_url":"https://github.com/chinskiy","followers_url":"https://api.github.com/users/chinskiy/followers","following_url":"https://api.github.com/users/chinskiy/following{/other_user}","gists_url":"https://api.github.com/users/chinskiy/gists{/gist_id}","starred_url":"https://api.github.com/users/chinskiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinskiy/subscriptions","organizations_url":"https://api.github.com/users/chinskiy/orgs","repos_url":"https://api.github.com/users/chinskiy/repos","events_url":"https://api.github.com/users/chinskiy/events{/privacy}","received_events_url":"https://api.github.com/users/chinskiy/received_events","type":"User","site_admin":false},"repo":{"id":53806694,"name":"pandas","full_name":"chinskiy/pandas","owner":{"login":"chinskiy","id":4370169,"avatar_url":"https://avatars.githubusercontent.com/u/4370169?v=3","gravatar_id":"","url":"https://api.github.com/users/chinskiy","html_url":"https://github.com/chinskiy","followers_url":"https://api.github.com/users/chinskiy/followers","following_url":"https://api.github.com/users/chinskiy/following{/other_user}","gists_url":"https://api.github.com/users/chinskiy/gists{/gist_id}","starred_url":"https://api.github.com/users/chinskiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chinskiy/subscriptions","organizations_url":"https://api.github.com/users/chinskiy/orgs","repos_url":"https://api.github.com/users/chinskiy/repos","events_url":"https://api.github.com/users/chinskiy/events{/privacy}","received_events_url":"https://api.github.com/users/chinskiy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chinskiy/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/chinskiy/pandas","forks_url":"https://api.github.com/repos/chinskiy/pandas/forks","keys_url":"https://api.github.com/repos/chinskiy/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chinskiy/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chinskiy/pandas/teams","hooks_url":"https://api.github.com/repos/chinskiy/pandas/hooks","issue_events_url":"https://api.github.com/repos/chinskiy/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/chinskiy/pandas/events","assignees_url":"https://api.github.com/repos/chinskiy/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/chinskiy/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/chinskiy/pandas/tags","blobs_url":"https://api.github.com/repos/chinskiy/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chinskiy/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chinskiy/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/chinskiy/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chinskiy/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/chinskiy/pandas/languages","stargazers_url":"https://api.github.com/repos/chinskiy/pandas/stargazers","contributors_url":"https://api.github.com/repos/chinskiy/pandas/contributors","subscribers_url":"https://api.github.com/repos/chinskiy/pandas/subscribers","subscription_url":"https://api.github.com/repos/chinskiy/pandas/subscription","commits_url":"https://api.github.com/repos/chinskiy/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/chinskiy/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/chinskiy/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/chinskiy/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/chinskiy/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/chinskiy/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chinskiy/pandas/merges","archive_url":"https://api.github.com/repos/chinskiy/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chinskiy/pandas/downloads","issues_url":"https://api.github.com/repos/chinskiy/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/chinskiy/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/chinskiy/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/chinskiy/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chinskiy/pandas/labels{/name}","releases_url":"https://api.github.com/repos/chinskiy/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/chinskiy/pandas/deployments","created_at":"2016-03-13T20:42:45Z","updated_at":"2016-03-13T20:42:50Z","pushed_at":"2016-03-20T18:26:28Z","git_url":"git://github.com/chinskiy/pandas.git","ssh_url":"git@github.com:chinskiy/pandas.git","clone_url":"https://github.com/chinskiy/pandas.git","svn_url":"https://github.com/chinskiy/pandas","homepage":"http://pandas.pydata.org","size":79799,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"e55875e5753509a1397cd0a50825811926ace477","user":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pydata/pandas","owner":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydata/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pydata/pandas","forks_url":"https://api.github.com/repos/pydata/pandas/forks","keys_url":"https://api.github.com/repos/pydata/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/pandas/teams","hooks_url":"https://api.github.com/repos/pydata/pandas/hooks","issue_events_url":"https://api.github.com/repos/pydata/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/pandas/events","assignees_url":"https://api.github.com/repos/pydata/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/pandas/tags","blobs_url":"https://api.github.com/repos/pydata/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/pandas/languages","stargazers_url":"https://api.github.com/repos/pydata/pandas/stargazers","contributors_url":"https://api.github.com/repos/pydata/pandas/contributors","subscribers_url":"https://api.github.com/repos/pydata/pandas/subscribers","subscription_url":"https://api.github.com/repos/pydata/pandas/subscription","commits_url":"https://api.github.com/repos/pydata/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pydata/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/pandas/merges","archive_url":"https://api.github.com/repos/pydata/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/pandas/downloads","issues_url":"https://api.github.com/repos/pydata/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pydata/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pydata/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2016-03-20T10:28:50Z","pushed_at":"2016-03-20T18:53:10Z","git_url":"git://github.com/pydata/pandas.git","ssh_url":"git@github.com:pydata/pandas.git","clone_url":"https://github.com/pydata/pandas.git","svn_url":"https://github.com/pydata/pandas","homepage":"http://pandas.pydata.org","size":142096,"stargazers_count":5905,"watchers_count":5905,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2402,"mirror_url":null,"open_issues_count":1695,"forks":2402,"open_issues":1695,"watchers":5905,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/12612"},"html":{"href":"https://github.com/pydata/pandas/pull/12612"},"issue":{"href":"https://api.github.com/repos/pydata/pandas/issues/12612"},"comments":{"href":"https://api.github.com/repos/pydata/pandas/issues/12612/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/pandas/pulls/12612/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pydata/pandas/pulls/12612/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/pandas/statuses/7111a7e5435c89f69c2e98b88ffa0aa3298ae039"}}}}