{"action":"opened","number":29,"pull_request":{"url":"https://api.github.com/repos/dvidelabs/flatcc/pulls/29","id":98457580,"html_url":"https://github.com/dvidelabs/flatcc/pull/29","diff_url":"https://github.com/dvidelabs/flatcc/pull/29.diff","patch_url":"https://github.com/dvidelabs/flatcc/pull/29.patch","issue_url":"https://api.github.com/repos/dvidelabs/flatcc/issues/29","number":29,"state":"open","locked":false,"title":"Allow to generate scan for all fields as a default option","user":{"login":"skhoroshavin","id":5670522,"avatar_url":"https://avatars.githubusercontent.com/u/5670522?v=3","gravatar_id":"","url":"https://api.github.com/users/skhoroshavin","html_url":"https://github.com/skhoroshavin","followers_url":"https://api.github.com/users/skhoroshavin/followers","following_url":"https://api.github.com/users/skhoroshavin/following{/other_user}","gists_url":"https://api.github.com/users/skhoroshavin/gists{/gist_id}","starred_url":"https://api.github.com/users/skhoroshavin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skhoroshavin/subscriptions","organizations_url":"https://api.github.com/users/skhoroshavin/orgs","repos_url":"https://api.github.com/users/skhoroshavin/repos","events_url":"https://api.github.com/users/skhoroshavin/events{/privacy}","received_events_url":"https://api.github.com/users/skhoroshavin/received_events","type":"User","site_admin":false},"body":"We discussed possibility of adding scan functions for all fields as a default option and I tried to implement it.  I also tried in my project to remove keys from fields, regenerate headers with new flatcc and measure compilation time on my laptop. After several clean runs of \"time make all\" it became apparent that there is no noticeable effect on compilation time (7.5 sec before and after on average) nor binaries size (514K executable compiled in debug mode). Reader header size became even smaller (21K before, 20K after).","created_at":"2016-12-17T22:15:39Z","updated_at":"2016-12-17T22:15:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5de3a272ff5173d2c12a60c1d0d0780141f8330","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dvidelabs/flatcc/pulls/29/commits","review_comments_url":"https://api.github.com/repos/dvidelabs/flatcc/pulls/29/comments","review_comment_url":"https://api.github.com/repos/dvidelabs/flatcc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dvidelabs/flatcc/issues/29/comments","statuses_url":"https://api.github.com/repos/dvidelabs/flatcc/statuses/6c55157815216fd0a851223f0060fd868362e9c3","head":{"label":"skhoroshavin:master","ref":"master","sha":"6c55157815216fd0a851223f0060fd868362e9c3","user":{"login":"skhoroshavin","id":5670522,"avatar_url":"https://avatars.githubusercontent.com/u/5670522?v=3","gravatar_id":"","url":"https://api.github.com/users/skhoroshavin","html_url":"https://github.com/skhoroshavin","followers_url":"https://api.github.com/users/skhoroshavin/followers","following_url":"https://api.github.com/users/skhoroshavin/following{/other_user}","gists_url":"https://api.github.com/users/skhoroshavin/gists{/gist_id}","starred_url":"https://api.github.com/users/skhoroshavin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skhoroshavin/subscriptions","organizations_url":"https://api.github.com/users/skhoroshavin/orgs","repos_url":"https://api.github.com/users/skhoroshavin/repos","events_url":"https://api.github.com/users/skhoroshavin/events{/privacy}","received_events_url":"https://api.github.com/users/skhoroshavin/received_events","type":"User","site_admin":false},"repo":{"id":75012112,"name":"flatcc","full_name":"skhoroshavin/flatcc","owner":{"login":"skhoroshavin","id":5670522,"avatar_url":"https://avatars.githubusercontent.com/u/5670522?v=3","gravatar_id":"","url":"https://api.github.com/users/skhoroshavin","html_url":"https://github.com/skhoroshavin","followers_url":"https://api.github.com/users/skhoroshavin/followers","following_url":"https://api.github.com/users/skhoroshavin/following{/other_user}","gists_url":"https://api.github.com/users/skhoroshavin/gists{/gist_id}","starred_url":"https://api.github.com/users/skhoroshavin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skhoroshavin/subscriptions","organizations_url":"https://api.github.com/users/skhoroshavin/orgs","repos_url":"https://api.github.com/users/skhoroshavin/repos","events_url":"https://api.github.com/users/skhoroshavin/events{/privacy}","received_events_url":"https://api.github.com/users/skhoroshavin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skhoroshavin/flatcc","description":"FlatBuffers Compiler and Library in C for C","fork":true,"url":"https://api.github.com/repos/skhoroshavin/flatcc","forks_url":"https://api.github.com/repos/skhoroshavin/flatcc/forks","keys_url":"https://api.github.com/repos/skhoroshavin/flatcc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skhoroshavin/flatcc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skhoroshavin/flatcc/teams","hooks_url":"https://api.github.com/repos/skhoroshavin/flatcc/hooks","issue_events_url":"https://api.github.com/repos/skhoroshavin/flatcc/issues/events{/number}","events_url":"https://api.github.com/repos/skhoroshavin/flatcc/events","assignees_url":"https://api.github.com/repos/skhoroshavin/flatcc/assignees{/user}","branches_url":"https://api.github.com/repos/skhoroshavin/flatcc/branches{/branch}","tags_url":"https://api.github.com/repos/skhoroshavin/flatcc/tags","blobs_url":"https://api.github.com/repos/skhoroshavin/flatcc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skhoroshavin/flatcc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skhoroshavin/flatcc/git/refs{/sha}","trees_url":"https://api.github.com/repos/skhoroshavin/flatcc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skhoroshavin/flatcc/statuses/{sha}","languages_url":"https://api.github.com/repos/skhoroshavin/flatcc/languages","stargazers_url":"https://api.github.com/repos/skhoroshavin/flatcc/stargazers","contributors_url":"https://api.github.com/repos/skhoroshavin/flatcc/contributors","subscribers_url":"https://api.github.com/repos/skhoroshavin/flatcc/subscribers","subscription_url":"https://api.github.com/repos/skhoroshavin/flatcc/subscription","commits_url":"https://api.github.com/repos/skhoroshavin/flatcc/commits{/sha}","git_commits_url":"https://api.github.com/repos/skhoroshavin/flatcc/git/commits{/sha}","comments_url":"https://api.github.com/repos/skhoroshavin/flatcc/comments{/number}","issue_comment_url":"https://api.github.com/repos/skhoroshavin/flatcc/issues/comments{/number}","contents_url":"https://api.github.com/repos/skhoroshavin/flatcc/contents/{+path}","compare_url":"https://api.github.com/repos/skhoroshavin/flatcc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skhoroshavin/flatcc/merges","archive_url":"https://api.github.com/repos/skhoroshavin/flatcc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skhoroshavin/flatcc/downloads","issues_url":"https://api.github.com/repos/skhoroshavin/flatcc/issues{/number}","pulls_url":"https://api.github.com/repos/skhoroshavin/flatcc/pulls{/number}","milestones_url":"https://api.github.com/repos/skhoroshavin/flatcc/milestones{/number}","notifications_url":"https://api.github.com/repos/skhoroshavin/flatcc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skhoroshavin/flatcc/labels{/name}","releases_url":"https://api.github.com/repos/skhoroshavin/flatcc/releases{/id}","deployments_url":"https://api.github.com/repos/skhoroshavin/flatcc/deployments","created_at":"2016-11-28T20:36:43Z","updated_at":"2016-11-28T20:36:44Z","pushed_at":"2016-12-17T21:51:42Z","git_url":"git://github.com/skhoroshavin/flatcc.git","ssh_url":"git@github.com:skhoroshavin/flatcc.git","clone_url":"https://github.com/skhoroshavin/flatcc.git","svn_url":"https://github.com/skhoroshavin/flatcc","homepage":null,"size":1196,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dvidelabs:master","ref":"master","sha":"5db361c6e3f2fb2aadf8280e483592a9b2188fdb","user":{"login":"dvidelabs","id":767655,"avatar_url":"https://avatars.githubusercontent.com/u/767655?v=3","gravatar_id":"","url":"https://api.github.com/users/dvidelabs","html_url":"https://github.com/dvidelabs","followers_url":"https://api.github.com/users/dvidelabs/followers","following_url":"https://api.github.com/users/dvidelabs/following{/other_user}","gists_url":"https://api.github.com/users/dvidelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/dvidelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvidelabs/subscriptions","organizations_url":"https://api.github.com/users/dvidelabs/orgs","repos_url":"https://api.github.com/users/dvidelabs/repos","events_url":"https://api.github.com/users/dvidelabs/events{/privacy}","received_events_url":"https://api.github.com/users/dvidelabs/received_events","type":"Organization","site_admin":false},"repo":{"id":45867575,"name":"flatcc","full_name":"dvidelabs/flatcc","owner":{"login":"dvidelabs","id":767655,"avatar_url":"https://avatars.githubusercontent.com/u/767655?v=3","gravatar_id":"","url":"https://api.github.com/users/dvidelabs","html_url":"https://github.com/dvidelabs","followers_url":"https://api.github.com/users/dvidelabs/followers","following_url":"https://api.github.com/users/dvidelabs/following{/other_user}","gists_url":"https://api.github.com/users/dvidelabs/gists{/gist_id}","starred_url":"https://api.github.com/users/dvidelabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvidelabs/subscriptions","organizations_url":"https://api.github.com/users/dvidelabs/orgs","repos_url":"https://api.github.com/users/dvidelabs/repos","events_url":"https://api.github.com/users/dvidelabs/events{/privacy}","received_events_url":"https://api.github.com/users/dvidelabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dvidelabs/flatcc","description":"FlatBuffers Compiler and Library in C for C","fork":false,"url":"https://api.github.com/repos/dvidelabs/flatcc","forks_url":"https://api.github.com/repos/dvidelabs/flatcc/forks","keys_url":"https://api.github.com/repos/dvidelabs/flatcc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dvidelabs/flatcc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dvidelabs/flatcc/teams","hooks_url":"https://api.github.com/repos/dvidelabs/flatcc/hooks","issue_events_url":"https://api.github.com/repos/dvidelabs/flatcc/issues/events{/number}","events_url":"https://api.github.com/repos/dvidelabs/flatcc/events","assignees_url":"https://api.github.com/repos/dvidelabs/flatcc/assignees{/user}","branches_url":"https://api.github.com/repos/dvidelabs/flatcc/branches{/branch}","tags_url":"https://api.github.com/repos/dvidelabs/flatcc/tags","blobs_url":"https://api.github.com/repos/dvidelabs/flatcc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dvidelabs/flatcc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dvidelabs/flatcc/git/refs{/sha}","trees_url":"https://api.github.com/repos/dvidelabs/flatcc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dvidelabs/flatcc/statuses/{sha}","languages_url":"https://api.github.com/repos/dvidelabs/flatcc/languages","stargazers_url":"https://api.github.com/repos/dvidelabs/flatcc/stargazers","contributors_url":"https://api.github.com/repos/dvidelabs/flatcc/contributors","subscribers_url":"https://api.github.com/repos/dvidelabs/flatcc/subscribers","subscription_url":"https://api.github.com/repos/dvidelabs/flatcc/subscription","commits_url":"https://api.github.com/repos/dvidelabs/flatcc/commits{/sha}","git_commits_url":"https://api.github.com/repos/dvidelabs/flatcc/git/commits{/sha}","comments_url":"https://api.github.com/repos/dvidelabs/flatcc/comments{/number}","issue_comment_url":"https://api.github.com/repos/dvidelabs/flatcc/issues/comments{/number}","contents_url":"https://api.github.com/repos/dvidelabs/flatcc/contents/{+path}","compare_url":"https://api.github.com/repos/dvidelabs/flatcc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dvidelabs/flatcc/merges","archive_url":"https://api.github.com/repos/dvidelabs/flatcc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dvidelabs/flatcc/downloads","issues_url":"https://api.github.com/repos/dvidelabs/flatcc/issues{/number}","pulls_url":"https://api.github.com/repos/dvidelabs/flatcc/pulls{/number}","milestones_url":"https://api.github.com/repos/dvidelabs/flatcc/milestones{/number}","notifications_url":"https://api.github.com/repos/dvidelabs/flatcc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dvidelabs/flatcc/labels{/name}","releases_url":"https://api.github.com/repos/dvidelabs/flatcc/releases{/id}","deployments_url":"https://api.github.com/repos/dvidelabs/flatcc/deployments","created_at":"2015-11-09T21:21:58Z","updated_at":"2016-12-12T14:45:30Z","pushed_at":"2016-12-17T22:15:39Z","git_url":"git://github.com/dvidelabs/flatcc.git","ssh_url":"git@github.com:dvidelabs/flatcc.git","clone_url":"https://github.com/dvidelabs/flatcc.git","svn_url":"https://github.com/dvidelabs/flatcc","homepage":null,"size":1197,"stargazers_count":98,"watchers_count":98,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":4,"forks":24,"open_issues":4,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dvidelabs/flatcc/pulls/29"},"html":{"href":"https://github.com/dvidelabs/flatcc/pull/29"},"issue":{"href":"https://api.github.com/repos/dvidelabs/flatcc/issues/29"},"comments":{"href":"https://api.github.com/repos/dvidelabs/flatcc/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/dvidelabs/flatcc/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/dvidelabs/flatcc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dvidelabs/flatcc/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/dvidelabs/flatcc/statuses/6c55157815216fd0a851223f0060fd868362e9c3"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":38,"deletions":15,"changed_files":4}}
{"actor":{"display_login":"skhoroshavin"}}