{"action":"created","comment":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/49968415","id":49968415,"diff_hunk":"@@ -28,7 +28,7 @@ class UrlValidator extends Validator\n      * The pattern may contain a `{schemes}` token that will be replaced\n      * by a regular expression which represents the [[validSchemes]].\n      */\n-    public $pattern = '/^{schemes}:\\/\\/(([A-Z0-9][A-Z0-9_-]*)(\\.[A-Z0-9][A-Z0-9_-]*)+)/i';\n+    public $pattern = '/^({schemes}:\\\\/\\\\/)(www\\\\.)?([0-9u0000-uFFFF]*\\\\.\\\\-)?([0-9u0000-uFFFF\\\\-]*)\\\\.([a-zA-Z]{2,6})?([u0000-uFFFF]{2,6})\\\\/?([u0000-uFFFF0-9_\\\\-\\\\?=\\\\.\\\\&])*?/i';","path":"framework/validators/UrlValidator.php","position":5,"original_position":5,"commit_id":"e7d5a48f745dfb37ac2362b3ea94ed48b15203e0","original_commit_id":"e7d5a48f745dfb37ac2362b3ea94ed48b15203e0","user":{"login":"Shadowmad","id":14799398,"avatar_url":"https://avatars.githubusercontent.com/u/14799398?v=3","gravatar_id":"","url":"https://api.github.com/users/Shadowmad","html_url":"https://github.com/Shadowmad","followers_url":"https://api.github.com/users/Shadowmad/followers","following_url":"https://api.github.com/users/Shadowmad/following{/other_user}","gists_url":"https://api.github.com/users/Shadowmad/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadowmad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadowmad/subscriptions","organizations_url":"https://api.github.com/users/Shadowmad/orgs","repos_url":"https://api.github.com/users/Shadowmad/repos","events_url":"https://api.github.com/users/Shadowmad/events{/privacy}","received_events_url":"https://api.github.com/users/Shadowmad/received_events","type":"User","site_admin":false},"body":"Also, u0000-uFFFF is all possible Unicode. I can change that to 0-9a-zA-Z to limit regular expression to only English words. ","created_at":"2016-01-18T07:37:33Z","updated_at":"2016-01-18T07:37:33Z","html_url":"https://github.com/yiisoft/yii2/pull/10600#discussion_r49968415","pull_request_url":"https://api.github.com/repos/yiisoft/yii2/pulls/10600","_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/49968415"},"html":{"href":"https://github.com/yiisoft/yii2/pull/10600#discussion_r49968415"},"pull_request":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/10600"}}},"pull_request":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/10600","id":56297468,"html_url":"https://github.com/yiisoft/yii2/pull/10600","diff_url":"https://github.com/yiisoft/yii2/pull/10600.diff","patch_url":"https://github.com/yiisoft/yii2/pull/10600.patch","issue_url":"https://api.github.com/repos/yiisoft/yii2/issues/10600","number":10600,"state":"open","locked":false,"title":"Changed pattern of URL to match appropriate URL's","user":{"login":"Shadowmad","id":14799398,"avatar_url":"https://avatars.githubusercontent.com/u/14799398?v=3","gravatar_id":"","url":"https://api.github.com/users/Shadowmad","html_url":"https://github.com/Shadowmad","followers_url":"https://api.github.com/users/Shadowmad/followers","following_url":"https://api.github.com/users/Shadowmad/following{/other_user}","gists_url":"https://api.github.com/users/Shadowmad/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadowmad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadowmad/subscriptions","organizations_url":"https://api.github.com/users/Shadowmad/orgs","repos_url":"https://api.github.com/users/Shadowmad/repos","events_url":"https://api.github.com/users/Shadowmad/events{/privacy}","received_events_url":"https://api.github.com/users/Shadowmad/received_events","type":"User","site_admin":false},"body":"I have changed pattern of the url validator to match correct URLs so that error #10533 would not occure again. As explained in 10533, URLs are passing the tests, but URLs are not correct, this issue was encountered dut to the pattern issues. I ran PHPUnit tests and now everything is passing as well as checked URL in variety of programs to check if URL is correct or not. Please review and let me know if I should re do it or accepted\r\n\r\nThank you! ","created_at":"2016-01-18T02:58:36Z","updated_at":"2016-01-18T07:37:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df21c8570ac685dd8da60cb4122361604744b6fa","assignee":{"login":"SilverFire","id":4499203,"avatar_url":"https://avatars.githubusercontent.com/u/4499203?v=3","gravatar_id":"","url":"https://api.github.com/users/SilverFire","html_url":"https://github.com/SilverFire","followers_url":"https://api.github.com/users/SilverFire/followers","following_url":"https://api.github.com/users/SilverFire/following{/other_user}","gists_url":"https://api.github.com/users/SilverFire/gists{/gist_id}","starred_url":"https://api.github.com/users/SilverFire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SilverFire/subscriptions","organizations_url":"https://api.github.com/users/SilverFire/orgs","repos_url":"https://api.github.com/users/SilverFire/repos","events_url":"https://api.github.com/users/SilverFire/events{/privacy}","received_events_url":"https://api.github.com/users/SilverFire/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/yiisoft/yii2/milestones/16","html_url":"https://github.com/yiisoft/yii2/milestones/2.0.8","labels_url":"https://api.github.com/repos/yiisoft/yii2/milestones/16/labels","id":1242959,"number":16,"title":"2.0.8","description":"","creator":{"login":"cebe","id":189796,"avatar_url":"https://avatars.githubusercontent.com/u/189796?v=3","gravatar_id":"","url":"https://api.github.com/users/cebe","html_url":"https://github.com/cebe","followers_url":"https://api.github.com/users/cebe/followers","following_url":"https://api.github.com/users/cebe/following{/other_user}","gists_url":"https://api.github.com/users/cebe/gists{/gist_id}","starred_url":"https://api.github.com/users/cebe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cebe/subscriptions","organizations_url":"https://api.github.com/users/cebe/orgs","repos_url":"https://api.github.com/users/cebe/repos","events_url":"https://api.github.com/users/cebe/events{/privacy}","received_events_url":"https://api.github.com/users/cebe/received_events","type":"User","site_admin":false},"open_issues":62,"closed_issues":0,"state":"open","created_at":"2015-08-05T22:18:21Z","updated_at":"2016-01-18T07:05:08Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/yiisoft/yii2/pulls/10600/commits","review_comments_url":"https://api.github.com/repos/yiisoft/yii2/pulls/10600/comments","review_comment_url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yiisoft/yii2/issues/10600/comments","statuses_url":"https://api.github.com/repos/yiisoft/yii2/statuses/e7d5a48f745dfb37ac2362b3ea94ed48b15203e0","head":{"label":"Shadowmad:10533-url-validator-incorrect-values","ref":"10533-url-validator-incorrect-values","sha":"e7d5a48f745dfb37ac2362b3ea94ed48b15203e0","user":{"login":"Shadowmad","id":14799398,"avatar_url":"https://avatars.githubusercontent.com/u/14799398?v=3","gravatar_id":"","url":"https://api.github.com/users/Shadowmad","html_url":"https://github.com/Shadowmad","followers_url":"https://api.github.com/users/Shadowmad/followers","following_url":"https://api.github.com/users/Shadowmad/following{/other_user}","gists_url":"https://api.github.com/users/Shadowmad/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadowmad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadowmad/subscriptions","organizations_url":"https://api.github.com/users/Shadowmad/orgs","repos_url":"https://api.github.com/users/Shadowmad/repos","events_url":"https://api.github.com/users/Shadowmad/events{/privacy}","received_events_url":"https://api.github.com/users/Shadowmad/received_events","type":"User","site_admin":false},"repo":{"id":49847413,"name":"yii2","full_name":"Shadowmad/yii2","owner":{"login":"Shadowmad","id":14799398,"avatar_url":"https://avatars.githubusercontent.com/u/14799398?v=3","gravatar_id":"","url":"https://api.github.com/users/Shadowmad","html_url":"https://github.com/Shadowmad","followers_url":"https://api.github.com/users/Shadowmad/followers","following_url":"https://api.github.com/users/Shadowmad/following{/other_user}","gists_url":"https://api.github.com/users/Shadowmad/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadowmad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadowmad/subscriptions","organizations_url":"https://api.github.com/users/Shadowmad/orgs","repos_url":"https://api.github.com/users/Shadowmad/repos","events_url":"https://api.github.com/users/Shadowmad/events{/privacy}","received_events_url":"https://api.github.com/users/Shadowmad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Shadowmad/yii2","description":"Yii 2 framework main development repo","fork":true,"url":"https://api.github.com/repos/Shadowmad/yii2","forks_url":"https://api.github.com/repos/Shadowmad/yii2/forks","keys_url":"https://api.github.com/repos/Shadowmad/yii2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shadowmad/yii2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shadowmad/yii2/teams","hooks_url":"https://api.github.com/repos/Shadowmad/yii2/hooks","issue_events_url":"https://api.github.com/repos/Shadowmad/yii2/issues/events{/number}","events_url":"https://api.github.com/repos/Shadowmad/yii2/events","assignees_url":"https://api.github.com/repos/Shadowmad/yii2/assignees{/user}","branches_url":"https://api.github.com/repos/Shadowmad/yii2/branches{/branch}","tags_url":"https://api.github.com/repos/Shadowmad/yii2/tags","blobs_url":"https://api.github.com/repos/Shadowmad/yii2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shadowmad/yii2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shadowmad/yii2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shadowmad/yii2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shadowmad/yii2/statuses/{sha}","languages_url":"https://api.github.com/repos/Shadowmad/yii2/languages","stargazers_url":"https://api.github.com/repos/Shadowmad/yii2/stargazers","contributors_url":"https://api.github.com/repos/Shadowmad/yii2/contributors","subscribers_url":"https://api.github.com/repos/Shadowmad/yii2/subscribers","subscription_url":"https://api.github.com/repos/Shadowmad/yii2/subscription","commits_url":"https://api.github.com/repos/Shadowmad/yii2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shadowmad/yii2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shadowmad/yii2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shadowmad/yii2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shadowmad/yii2/contents/{+path}","compare_url":"https://api.github.com/repos/Shadowmad/yii2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shadowmad/yii2/merges","archive_url":"https://api.github.com/repos/Shadowmad/yii2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shadowmad/yii2/downloads","issues_url":"https://api.github.com/repos/Shadowmad/yii2/issues{/number}","pulls_url":"https://api.github.com/repos/Shadowmad/yii2/pulls{/number}","milestones_url":"https://api.github.com/repos/Shadowmad/yii2/milestones{/number}","notifications_url":"https://api.github.com/repos/Shadowmad/yii2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shadowmad/yii2/labels{/name}","releases_url":"https://api.github.com/repos/Shadowmad/yii2/releases{/id}","created_at":"2016-01-18T02:38:49Z","updated_at":"2016-01-18T02:38:53Z","pushed_at":"2016-01-18T02:55:09Z","git_url":"git://github.com/Shadowmad/yii2.git","ssh_url":"git@github.com:Shadowmad/yii2.git","clone_url":"https://github.com/Shadowmad/yii2.git","svn_url":"https://github.com/Shadowmad/yii2","homepage":"http://www.yiiframework.com","size":43997,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yiisoft:master","ref":"master","sha":"cee10cc3ef07ee22dd9f7673636c68168d451fad","user":{"login":"yiisoft","id":993323,"avatar_url":"https://avatars.githubusercontent.com/u/993323?v=3","gravatar_id":"","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"repo":{"id":3431193,"name":"yii2","full_name":"yiisoft/yii2","owner":{"login":"yiisoft","id":993323,"avatar_url":"https://avatars.githubusercontent.com/u/993323?v=3","gravatar_id":"","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yiisoft/yii2","description":"Yii 2 framework main development repo","fork":false,"url":"https://api.github.com/repos/yiisoft/yii2","forks_url":"https://api.github.com/repos/yiisoft/yii2/forks","keys_url":"https://api.github.com/repos/yiisoft/yii2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yiisoft/yii2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yiisoft/yii2/teams","hooks_url":"https://api.github.com/repos/yiisoft/yii2/hooks","issue_events_url":"https://api.github.com/repos/yiisoft/yii2/issues/events{/number}","events_url":"https://api.github.com/repos/yiisoft/yii2/events","assignees_url":"https://api.github.com/repos/yiisoft/yii2/assignees{/user}","branches_url":"https://api.github.com/repos/yiisoft/yii2/branches{/branch}","tags_url":"https://api.github.com/repos/yiisoft/yii2/tags","blobs_url":"https://api.github.com/repos/yiisoft/yii2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yiisoft/yii2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yiisoft/yii2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yiisoft/yii2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yiisoft/yii2/statuses/{sha}","languages_url":"https://api.github.com/repos/yiisoft/yii2/languages","stargazers_url":"https://api.github.com/repos/yiisoft/yii2/stargazers","contributors_url":"https://api.github.com/repos/yiisoft/yii2/contributors","subscribers_url":"https://api.github.com/repos/yiisoft/yii2/subscribers","subscription_url":"https://api.github.com/repos/yiisoft/yii2/subscription","commits_url":"https://api.github.com/repos/yiisoft/yii2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yiisoft/yii2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yiisoft/yii2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yiisoft/yii2/issues/comments{/number}","contents_url":"https://api.github.com/repos/yiisoft/yii2/contents/{+path}","compare_url":"https://api.github.com/repos/yiisoft/yii2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yiisoft/yii2/merges","archive_url":"https://api.github.com/repos/yiisoft/yii2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yiisoft/yii2/downloads","issues_url":"https://api.github.com/repos/yiisoft/yii2/issues{/number}","pulls_url":"https://api.github.com/repos/yiisoft/yii2/pulls{/number}","milestones_url":"https://api.github.com/repos/yiisoft/yii2/milestones{/number}","notifications_url":"https://api.github.com/repos/yiisoft/yii2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yiisoft/yii2/labels{/name}","releases_url":"https://api.github.com/repos/yiisoft/yii2/releases{/id}","created_at":"2012-02-13T15:32:36Z","updated_at":"2016-01-18T07:08:25Z","pushed_at":"2016-01-18T07:25:57Z","git_url":"git://github.com/yiisoft/yii2.git","ssh_url":"git@github.com:yiisoft/yii2.git","clone_url":"https://github.com/yiisoft/yii2.git","svn_url":"https://github.com/yiisoft/yii2","homepage":"http://www.yiiframework.com","size":46773,"stargazers_count":7370,"watchers_count":7370,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4346,"mirror_url":null,"open_issues_count":1066,"forks":4346,"open_issues":1066,"watchers":7370,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/10600"},"html":{"href":"https://github.com/yiisoft/yii2/pull/10600"},"issue":{"href":"https://api.github.com/repos/yiisoft/yii2/issues/10600"},"comments":{"href":"https://api.github.com/repos/yiisoft/yii2/issues/10600/comments"},"review_comments":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/10600/comments"},"review_comment":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/10600/commits"},"statuses":{"href":"https://api.github.com/repos/yiisoft/yii2/statuses/e7d5a48f745dfb37ac2362b3ea94ed48b15203e0"}}}}