{"action":"created","comment":{"url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/pulls/comments/72178413","id":72178413,"diff_hunk":"@@ -51,22 +51,83 @@ public List<ProteoformRelation> mass_difference_group\n                 this.group_count = value.Count;\n                 this.group_adjusted_deltaM = value.Select(r => r.delta_mass).Average();\n                 _mass_difference_group = value;\n+                this.accepted = set_accepted(); //dependent on peak count\n             }\n         }\n-        public int unadjusted_group_count { get; set; }\n+\n+        public int unadjusted_group_count { get; set; } //this is never set to anything? \n+        public string accession { get; set; } //theoretical for ET, null for EE\n+        public string name { get; set; } //theoretical for ET, null for EE\n+        public string fragment { get; set; }\n+        public string ptm_list { get; set; }\n+        public double proteoform_mass_1 { get; set; } //experiment for ET, experiment_1 for EE\n+        public double proteoform_mass_2 { get; set; } //theoretical for EE, experiment_2 for EE\n+        public double agg_intensity_1 { get; set; } //experiment for ET, experiment_1 for EE\n+        public double agg_intensity_2 { get; set; } //0 for ET, experiment_2 for EE\n+        public double agg_RT_1 { get; set; } //experiment for ET, experiment_1 for EE\n+        public double agg_RT_2 { get; set; } //0 for ET, experiment_2 for EE\n+        public int num_observations_1 { get; set; }\n+        public int num_observations_2 { get; set; } //0 for ET\n+        public int lysine_count { get; set; }\n         public double group_adjusted_deltaM { get; set; }\n+        public int running_sum { get; set; }","path":"ProteoformSuiteInternal/ProteoformRelation.cs","position":24,"original_position":24,"commit_id":"7d994e17efc7cda20a4b330b25953a141eb81a88","original_commit_id":"7d994e17efc7cda20a4b330b25953a141eb81a88","user":{"login":"acesnik","id":16342951,"avatar_url":"https://avatars.githubusercontent.com/u/16342951?v=3","gravatar_id":"","url":"https://api.github.com/users/acesnik","html_url":"https://github.com/acesnik","followers_url":"https://api.github.com/users/acesnik/followers","following_url":"https://api.github.com/users/acesnik/following{/other_user}","gists_url":"https://api.github.com/users/acesnik/gists{/gist_id}","starred_url":"https://api.github.com/users/acesnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acesnik/subscriptions","organizations_url":"https://api.github.com/users/acesnik/orgs","repos_url":"https://api.github.com/users/acesnik/repos","events_url":"https://api.github.com/users/acesnik/events{/privacy}","received_events_url":"https://api.github.com/users/acesnik/received_events","type":"User","site_admin":false},"body":"\"Running sum\" is redundant of the \"unadjusted group count.\" I think running_sum is quite vague. It took me a while to figure out what it meant when working through this code.","created_at":"2016-07-26T02:17:00Z","updated_at":"2016-07-26T02:17:00Z","html_url":"https://github.com/smith-chem-wisc/proteoform-suite/pull/166#discussion_r72178413","pull_request_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/pulls/166","_links":{"self":{"href":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/pulls/comments/72178413"},"html":{"href":"https://github.com/smith-chem-wisc/proteoform-suite/pull/166#discussion_r72178413"},"pull_request":{"href":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/pulls/166"}}},"pull_request":{"url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/pulls/166","id":78772446,"html_url":"https://github.com/smith-chem-wisc/proteoform-suite/pull/166","diff_url":"https://github.com/smith-chem-wisc/proteoform-suite/pull/166.diff","patch_url":"https://github.com/smith-chem-wisc/proteoform-suite/pull/166.patch","issue_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/issues/166","number":166,"state":"open","locked":false,"title":"ET GUI, and only allow in-range decimals to form peaks for EE/ET","user":{"login":"lschaffer2","id":16846041,"avatar_url":"https://avatars.githubusercontent.com/u/16846041?v=3","gravatar_id":"","url":"https://api.github.com/users/lschaffer2","html_url":"https://github.com/lschaffer2","followers_url":"https://api.github.com/users/lschaffer2/followers","following_url":"https://api.github.com/users/lschaffer2/following{/other_user}","gists_url":"https://api.github.com/users/lschaffer2/gists{/gist_id}","starred_url":"https://api.github.com/users/lschaffer2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lschaffer2/subscriptions","organizations_url":"https://api.github.com/users/lschaffer2/orgs","repos_url":"https://api.github.com/users/lschaffer2/repos","events_url":"https://api.github.com/users/lschaffer2/events{/privacy}","received_events_url":"https://api.github.com/users/lschaffer2/received_events","type":"User","site_admin":false},"body":"I made proteoform relations out of specifically Experimental or TheoreticalProteoforms, so that the variables could be set for a ProteoformRelation based on E/T variables and therefore visible in the dgv... let me know if  there is a better way ","created_at":"2016-07-26T00:05:19Z","updated_at":"2016-07-26T02:17:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e54fc23544b6e2975c1b5aa5a4495b1d29af038","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/pulls/166/commits","review_comments_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/pulls/166/comments","review_comment_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/issues/166/comments","statuses_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/statuses/7d994e17efc7cda20a4b330b25953a141eb81a88","head":{"label":"lschaffer2:master","ref":"master","sha":"7d994e17efc7cda20a4b330b25953a141eb81a88","user":{"login":"lschaffer2","id":16846041,"avatar_url":"https://avatars.githubusercontent.com/u/16846041?v=3","gravatar_id":"","url":"https://api.github.com/users/lschaffer2","html_url":"https://github.com/lschaffer2","followers_url":"https://api.github.com/users/lschaffer2/followers","following_url":"https://api.github.com/users/lschaffer2/following{/other_user}","gists_url":"https://api.github.com/users/lschaffer2/gists{/gist_id}","starred_url":"https://api.github.com/users/lschaffer2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lschaffer2/subscriptions","organizations_url":"https://api.github.com/users/lschaffer2/orgs","repos_url":"https://api.github.com/users/lschaffer2/repos","events_url":"https://api.github.com/users/lschaffer2/events{/privacy}","received_events_url":"https://api.github.com/users/lschaffer2/received_events","type":"User","site_admin":false},"repo":{"id":61892709,"name":"proteoform-suite-1","full_name":"lschaffer2/proteoform-suite-1","owner":{"login":"lschaffer2","id":16846041,"avatar_url":"https://avatars.githubusercontent.com/u/16846041?v=3","gravatar_id":"","url":"https://api.github.com/users/lschaffer2","html_url":"https://github.com/lschaffer2","followers_url":"https://api.github.com/users/lschaffer2/followers","following_url":"https://api.github.com/users/lschaffer2/following{/other_user}","gists_url":"https://api.github.com/users/lschaffer2/gists{/gist_id}","starred_url":"https://api.github.com/users/lschaffer2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lschaffer2/subscriptions","organizations_url":"https://api.github.com/users/lschaffer2/orgs","repos_url":"https://api.github.com/users/lschaffer2/repos","events_url":"https://api.github.com/users/lschaffer2/events{/privacy}","received_events_url":"https://api.github.com/users/lschaffer2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lschaffer2/proteoform-suite-1","description":"Analysis, visualization, validation suite for proteoform analysis","fork":true,"url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1","forks_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/forks","keys_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/teams","hooks_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/hooks","issue_events_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/issues/events{/number}","events_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/events","assignees_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/assignees{/user}","branches_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/branches{/branch}","tags_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/tags","blobs_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/statuses/{sha}","languages_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/languages","stargazers_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/stargazers","contributors_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/contributors","subscribers_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/subscribers","subscription_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/subscription","commits_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/contents/{+path}","compare_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/merges","archive_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/downloads","issues_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/issues{/number}","pulls_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/pulls{/number}","milestones_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/milestones{/number}","notifications_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/labels{/name}","releases_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/releases{/id}","deployments_url":"https://api.github.com/repos/lschaffer2/proteoform-suite-1/deployments","created_at":"2016-06-24T15:09:41Z","updated_at":"2016-06-24T15:09:42Z","pushed_at":"2016-07-26T00:08:49Z","git_url":"git://github.com/lschaffer2/proteoform-suite-1.git","ssh_url":"git@github.com:lschaffer2/proteoform-suite-1.git","clone_url":"https://github.com/lschaffer2/proteoform-suite-1.git","svn_url":"https://github.com/lschaffer2/proteoform-suite-1","homepage":null,"size":68535,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smith-chem-wisc:master","ref":"master","sha":"114bd421ad10083b787e32f1b715230dd855839f","user":{"login":"smith-chem-wisc","id":15989786,"avatar_url":"https://avatars.githubusercontent.com/u/15989786?v=3","gravatar_id":"","url":"https://api.github.com/users/smith-chem-wisc","html_url":"https://github.com/smith-chem-wisc","followers_url":"https://api.github.com/users/smith-chem-wisc/followers","following_url":"https://api.github.com/users/smith-chem-wisc/following{/other_user}","gists_url":"https://api.github.com/users/smith-chem-wisc/gists{/gist_id}","starred_url":"https://api.github.com/users/smith-chem-wisc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smith-chem-wisc/subscriptions","organizations_url":"https://api.github.com/users/smith-chem-wisc/orgs","repos_url":"https://api.github.com/users/smith-chem-wisc/repos","events_url":"https://api.github.com/users/smith-chem-wisc/events{/privacy}","received_events_url":"https://api.github.com/users/smith-chem-wisc/received_events","type":"Organization","site_admin":false},"repo":{"id":48062394,"name":"proteoform-suite","full_name":"smith-chem-wisc/proteoform-suite","owner":{"login":"smith-chem-wisc","id":15989786,"avatar_url":"https://avatars.githubusercontent.com/u/15989786?v=3","gravatar_id":"","url":"https://api.github.com/users/smith-chem-wisc","html_url":"https://github.com/smith-chem-wisc","followers_url":"https://api.github.com/users/smith-chem-wisc/followers","following_url":"https://api.github.com/users/smith-chem-wisc/following{/other_user}","gists_url":"https://api.github.com/users/smith-chem-wisc/gists{/gist_id}","starred_url":"https://api.github.com/users/smith-chem-wisc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smith-chem-wisc/subscriptions","organizations_url":"https://api.github.com/users/smith-chem-wisc/orgs","repos_url":"https://api.github.com/users/smith-chem-wisc/repos","events_url":"https://api.github.com/users/smith-chem-wisc/events{/privacy}","received_events_url":"https://api.github.com/users/smith-chem-wisc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smith-chem-wisc/proteoform-suite","description":"Analysis, visualization, validation suite for proteoform analysis","fork":false,"url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite","forks_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/forks","keys_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/teams","hooks_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/hooks","issue_events_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/issues/events{/number}","events_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/events","assignees_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/assignees{/user}","branches_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/branches{/branch}","tags_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/tags","blobs_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/git/refs{/sha}","trees_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/statuses/{sha}","languages_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/languages","stargazers_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/stargazers","contributors_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/contributors","subscribers_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/subscribers","subscription_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/subscription","commits_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/commits{/sha}","git_commits_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/git/commits{/sha}","comments_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/comments{/number}","issue_comment_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/issues/comments{/number}","contents_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/contents/{+path}","compare_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/merges","archive_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/downloads","issues_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/issues{/number}","pulls_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/pulls{/number}","milestones_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/milestones{/number}","notifications_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/labels{/name}","releases_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/releases{/id}","deployments_url":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/deployments","created_at":"2015-12-15T18:49:32Z","updated_at":"2016-07-25T01:12:06Z","pushed_at":"2016-07-26T00:08:49Z","git_url":"git://github.com/smith-chem-wisc/proteoform-suite.git","ssh_url":"git@github.com:smith-chem-wisc/proteoform-suite.git","clone_url":"https://github.com/smith-chem-wisc/proteoform-suite.git","svn_url":"https://github.com/smith-chem-wisc/proteoform-suite","homepage":null,"size":68574,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":24,"forks":6,"open_issues":24,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/pulls/166"},"html":{"href":"https://github.com/smith-chem-wisc/proteoform-suite/pull/166"},"issue":{"href":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/issues/166"},"comments":{"href":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/issues/166/comments"},"review_comments":{"href":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/pulls/166/comments"},"review_comment":{"href":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/pulls/166/commits"},"statuses":{"href":"https://api.github.com/repos/smith-chem-wisc/proteoform-suite/statuses/7d994e17efc7cda20a4b330b25953a141eb81a88"}}}}
{"actor":{"display_login":"acesnik"}}