{"action":"created","comment":{"url":"https://api.github.com/repos/erickt/rust-zmq/pulls/comments/91990950","pull_request_review_id":12500459,"id":91990950,"diff_hunk":"@@ -18,7 +29,7 @@ fn create_socketpair() -> (Socket, Socket) {\n     receiver.set_rcvtimeo(1000).unwrap();\n \n     receiver.bind(\"tcp://*:*\").unwrap();","path":"tests/test.rs","position":21,"original_position":21,"commit_id":"78919be8d215cd9d7bc8475a98f703ee7aa52338","original_commit_id":"78919be8d215cd9d7bc8475a98f703ee7aa52338","user":{"login":"erickt","id":84711,"avatar_url":"https://avatars.githubusercontent.com/u/84711?v=3","gravatar_id":"","url":"https://api.github.com/users/erickt","html_url":"https://github.com/erickt","followers_url":"https://api.github.com/users/erickt/followers","following_url":"https://api.github.com/users/erickt/following{/other_user}","gists_url":"https://api.github.com/users/erickt/gists{/gist_id}","starred_url":"https://api.github.com/users/erickt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erickt/subscriptions","organizations_url":"https://api.github.com/users/erickt/orgs","repos_url":"https://api.github.com/users/erickt/repos","events_url":"https://api.github.com/users/erickt/events{/privacy}","received_events_url":"https://api.github.com/users/erickt/received_events","type":"User","site_admin":false},"body":"Great! Would it be simpler to use tcp://127.0.0.1:xxxx here?","created_at":"2016-12-12T17:03:37Z","updated_at":"2016-12-12T17:03:57Z","html_url":"https://github.com/erickt/rust-zmq/pull/140#discussion_r91990950","pull_request_url":"https://api.github.com/repos/erickt/rust-zmq/pulls/140","_links":{"self":{"href":"https://api.github.com/repos/erickt/rust-zmq/pulls/comments/91990950"},"html":{"href":"https://github.com/erickt/rust-zmq/pull/140#discussion_r91990950"},"pull_request":{"href":"https://api.github.com/repos/erickt/rust-zmq/pulls/140"}}},"pull_request":{"url":"https://api.github.com/repos/erickt/rust-zmq/pulls/140","id":97591328,"html_url":"https://github.com/erickt/rust-zmq/pull/140","diff_url":"https://github.com/erickt/rust-zmq/pull/140.diff","patch_url":"https://github.com/erickt/rust-zmq/pull/140.patch","issue_url":"https://api.github.com/repos/erickt/rust-zmq/issues/140","number":140,"state":"open","locked":false,"title":"Fix connect()-related Appveyor/win test failures","user":{"login":"pfernie","id":1976913,"avatar_url":"https://avatars.githubusercontent.com/u/1976913?v=3","gravatar_id":"","url":"https://api.github.com/users/pfernie","html_url":"https://github.com/pfernie","followers_url":"https://api.github.com/users/pfernie/followers","following_url":"https://api.github.com/users/pfernie/following{/other_user}","gists_url":"https://api.github.com/users/pfernie/gists{/gist_id}","starred_url":"https://api.github.com/users/pfernie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfernie/subscriptions","organizations_url":"https://api.github.com/users/pfernie/orgs","repos_url":"https://api.github.com/users/pfernie/repos","events_url":"https://api.github.com/users/pfernie/events{/privacy}","received_events_url":"https://api.github.com/users/pfernie/received_events","type":"User","site_admin":false},"body":"On windows, connect() call fails when using the\r\nreturn of get_last_endpoint() after a wild-card\r\nbind, \"tcp://0.0.0.0:<PORT>\".\r\nInstead, we must use the form\r\n\"tcp://127.0.0.1:<PORT>\". This behavior is seen\r\nin the libzmq library[1] itself.\r\n [1]: https://github.com/zeromq/libzmq/blob/905286261969d4e4b1b956f2befacb8c1eae5e35/tests/test_unbind_wildcard.cpp#L45-L49","created_at":"2016-12-12T16:58:27Z","updated_at":"2016-12-12T17:03:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb6e6b57d9a8108ac08710a2d5c2d5a4202fde0a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/erickt/rust-zmq/pulls/140/commits","review_comments_url":"https://api.github.com/repos/erickt/rust-zmq/pulls/140/comments","review_comment_url":"https://api.github.com/repos/erickt/rust-zmq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/erickt/rust-zmq/issues/140/comments","statuses_url":"https://api.github.com/repos/erickt/rust-zmq/statuses/78919be8d215cd9d7bc8475a98f703ee7aa52338","head":{"label":"pfernie:appveyor-test-fixes","ref":"appveyor-test-fixes","sha":"78919be8d215cd9d7bc8475a98f703ee7aa52338","user":{"login":"pfernie","id":1976913,"avatar_url":"https://avatars.githubusercontent.com/u/1976913?v=3","gravatar_id":"","url":"https://api.github.com/users/pfernie","html_url":"https://github.com/pfernie","followers_url":"https://api.github.com/users/pfernie/followers","following_url":"https://api.github.com/users/pfernie/following{/other_user}","gists_url":"https://api.github.com/users/pfernie/gists{/gist_id}","starred_url":"https://api.github.com/users/pfernie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfernie/subscriptions","organizations_url":"https://api.github.com/users/pfernie/orgs","repos_url":"https://api.github.com/users/pfernie/repos","events_url":"https://api.github.com/users/pfernie/events{/privacy}","received_events_url":"https://api.github.com/users/pfernie/received_events","type":"User","site_admin":false},"repo":{"id":39301274,"name":"rust-zmq","full_name":"pfernie/rust-zmq","owner":{"login":"pfernie","id":1976913,"avatar_url":"https://avatars.githubusercontent.com/u/1976913?v=3","gravatar_id":"","url":"https://api.github.com/users/pfernie","html_url":"https://github.com/pfernie","followers_url":"https://api.github.com/users/pfernie/followers","following_url":"https://api.github.com/users/pfernie/following{/other_user}","gists_url":"https://api.github.com/users/pfernie/gists{/gist_id}","starred_url":"https://api.github.com/users/pfernie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfernie/subscriptions","organizations_url":"https://api.github.com/users/pfernie/orgs","repos_url":"https://api.github.com/users/pfernie/repos","events_url":"https://api.github.com/users/pfernie/events{/privacy}","received_events_url":"https://api.github.com/users/pfernie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pfernie/rust-zmq","description":"Rust zeromq bindings.","fork":true,"url":"https://api.github.com/repos/pfernie/rust-zmq","forks_url":"https://api.github.com/repos/pfernie/rust-zmq/forks","keys_url":"https://api.github.com/repos/pfernie/rust-zmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfernie/rust-zmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfernie/rust-zmq/teams","hooks_url":"https://api.github.com/repos/pfernie/rust-zmq/hooks","issue_events_url":"https://api.github.com/repos/pfernie/rust-zmq/issues/events{/number}","events_url":"https://api.github.com/repos/pfernie/rust-zmq/events","assignees_url":"https://api.github.com/repos/pfernie/rust-zmq/assignees{/user}","branches_url":"https://api.github.com/repos/pfernie/rust-zmq/branches{/branch}","tags_url":"https://api.github.com/repos/pfernie/rust-zmq/tags","blobs_url":"https://api.github.com/repos/pfernie/rust-zmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfernie/rust-zmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfernie/rust-zmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfernie/rust-zmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfernie/rust-zmq/statuses/{sha}","languages_url":"https://api.github.com/repos/pfernie/rust-zmq/languages","stargazers_url":"https://api.github.com/repos/pfernie/rust-zmq/stargazers","contributors_url":"https://api.github.com/repos/pfernie/rust-zmq/contributors","subscribers_url":"https://api.github.com/repos/pfernie/rust-zmq/subscribers","subscription_url":"https://api.github.com/repos/pfernie/rust-zmq/subscription","commits_url":"https://api.github.com/repos/pfernie/rust-zmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfernie/rust-zmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfernie/rust-zmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfernie/rust-zmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfernie/rust-zmq/contents/{+path}","compare_url":"https://api.github.com/repos/pfernie/rust-zmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfernie/rust-zmq/merges","archive_url":"https://api.github.com/repos/pfernie/rust-zmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfernie/rust-zmq/downloads","issues_url":"https://api.github.com/repos/pfernie/rust-zmq/issues{/number}","pulls_url":"https://api.github.com/repos/pfernie/rust-zmq/pulls{/number}","milestones_url":"https://api.github.com/repos/pfernie/rust-zmq/milestones{/number}","notifications_url":"https://api.github.com/repos/pfernie/rust-zmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfernie/rust-zmq/labels{/name}","releases_url":"https://api.github.com/repos/pfernie/rust-zmq/releases{/id}","deployments_url":"https://api.github.com/repos/pfernie/rust-zmq/deployments","created_at":"2015-07-18T14:42:02Z","updated_at":"2016-12-12T16:57:29Z","pushed_at":"2016-12-12T16:57:52Z","git_url":"git://github.com/pfernie/rust-zmq.git","ssh_url":"git@github.com:pfernie/rust-zmq.git","clone_url":"https://github.com/pfernie/rust-zmq.git","svn_url":"https://github.com/pfernie/rust-zmq","homepage":"","size":445,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"erickt:master","ref":"master","sha":"9ad79128faa3ff1ffaf527e1318d6291eb819af6","user":{"login":"erickt","id":84711,"avatar_url":"https://avatars.githubusercontent.com/u/84711?v=3","gravatar_id":"","url":"https://api.github.com/users/erickt","html_url":"https://github.com/erickt","followers_url":"https://api.github.com/users/erickt/followers","following_url":"https://api.github.com/users/erickt/following{/other_user}","gists_url":"https://api.github.com/users/erickt/gists{/gist_id}","starred_url":"https://api.github.com/users/erickt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erickt/subscriptions","organizations_url":"https://api.github.com/users/erickt/orgs","repos_url":"https://api.github.com/users/erickt/repos","events_url":"https://api.github.com/users/erickt/events{/privacy}","received_events_url":"https://api.github.com/users/erickt/received_events","type":"User","site_admin":false},"repo":{"id":2981351,"name":"rust-zmq","full_name":"erickt/rust-zmq","owner":{"login":"erickt","id":84711,"avatar_url":"https://avatars.githubusercontent.com/u/84711?v=3","gravatar_id":"","url":"https://api.github.com/users/erickt","html_url":"https://github.com/erickt","followers_url":"https://api.github.com/users/erickt/followers","following_url":"https://api.github.com/users/erickt/following{/other_user}","gists_url":"https://api.github.com/users/erickt/gists{/gist_id}","starred_url":"https://api.github.com/users/erickt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erickt/subscriptions","organizations_url":"https://api.github.com/users/erickt/orgs","repos_url":"https://api.github.com/users/erickt/repos","events_url":"https://api.github.com/users/erickt/events{/privacy}","received_events_url":"https://api.github.com/users/erickt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erickt/rust-zmq","description":"Rust zeromq bindings.","fork":false,"url":"https://api.github.com/repos/erickt/rust-zmq","forks_url":"https://api.github.com/repos/erickt/rust-zmq/forks","keys_url":"https://api.github.com/repos/erickt/rust-zmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erickt/rust-zmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erickt/rust-zmq/teams","hooks_url":"https://api.github.com/repos/erickt/rust-zmq/hooks","issue_events_url":"https://api.github.com/repos/erickt/rust-zmq/issues/events{/number}","events_url":"https://api.github.com/repos/erickt/rust-zmq/events","assignees_url":"https://api.github.com/repos/erickt/rust-zmq/assignees{/user}","branches_url":"https://api.github.com/repos/erickt/rust-zmq/branches{/branch}","tags_url":"https://api.github.com/repos/erickt/rust-zmq/tags","blobs_url":"https://api.github.com/repos/erickt/rust-zmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erickt/rust-zmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erickt/rust-zmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/erickt/rust-zmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erickt/rust-zmq/statuses/{sha}","languages_url":"https://api.github.com/repos/erickt/rust-zmq/languages","stargazers_url":"https://api.github.com/repos/erickt/rust-zmq/stargazers","contributors_url":"https://api.github.com/repos/erickt/rust-zmq/contributors","subscribers_url":"https://api.github.com/repos/erickt/rust-zmq/subscribers","subscription_url":"https://api.github.com/repos/erickt/rust-zmq/subscription","commits_url":"https://api.github.com/repos/erickt/rust-zmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/erickt/rust-zmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/erickt/rust-zmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/erickt/rust-zmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/erickt/rust-zmq/contents/{+path}","compare_url":"https://api.github.com/repos/erickt/rust-zmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erickt/rust-zmq/merges","archive_url":"https://api.github.com/repos/erickt/rust-zmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erickt/rust-zmq/downloads","issues_url":"https://api.github.com/repos/erickt/rust-zmq/issues{/number}","pulls_url":"https://api.github.com/repos/erickt/rust-zmq/pulls{/number}","milestones_url":"https://api.github.com/repos/erickt/rust-zmq/milestones{/number}","notifications_url":"https://api.github.com/repos/erickt/rust-zmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erickt/rust-zmq/labels{/name}","releases_url":"https://api.github.com/repos/erickt/rust-zmq/releases{/id}","deployments_url":"https://api.github.com/repos/erickt/rust-zmq/deployments","created_at":"2011-12-14T16:48:50Z","updated_at":"2016-12-11T17:25:19Z","pushed_at":"2016-12-12T16:58:27Z","git_url":"git://github.com/erickt/rust-zmq.git","ssh_url":"git@github.com:erickt/rust-zmq.git","clone_url":"https://github.com/erickt/rust-zmq.git","svn_url":"https://github.com/erickt/rust-zmq","homepage":"","size":5543,"stargazers_count":209,"watchers_count":209,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":74,"mirror_url":null,"open_issues_count":13,"forks":74,"open_issues":13,"watchers":209,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/erickt/rust-zmq/pulls/140"},"html":{"href":"https://github.com/erickt/rust-zmq/pull/140"},"issue":{"href":"https://api.github.com/repos/erickt/rust-zmq/issues/140"},"comments":{"href":"https://api.github.com/repos/erickt/rust-zmq/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/erickt/rust-zmq/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/erickt/rust-zmq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/erickt/rust-zmq/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/erickt/rust-zmq/statuses/78919be8d215cd9d7bc8475a98f703ee7aa52338"}}}}
{"actor":{"display_login":"erickt"}}