{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/core/pulls/comments/49998690","id":49998690,"diff_hunk":"@@ -81,7 +81,26 @@ function getACL() {\n \t\t\t];\n \t\t}\n \n-\t\treturn $acl;\n+\t\t// add the current user\n+\t\tif (isset($this->addressBookInfo['{' . \\OCA\\DAV\\CardDAV\\Sharing\\Plugin::NS_OWNCLOUD . '}owner-principal'])) {\n+\t\t\t$owner = $this->addressBookInfo['{' . \\OCA\\DAV\\CardDAV\\Sharing\\Plugin::NS_OWNCLOUD . '}owner-principal'];\n+\t\t\t$acl[] = [\n+\t\t\t\t\t'privilege' => '{DAV:}read',\n+\t\t\t\t\t'principal' => $owner,\n+\t\t\t\t\t'protected' => true,\n+\t\t\t\t];\n+\t\t\tif ($this->addressBookInfo['{' . \\OCA\\DAV\\CardDAV\\Sharing\\Plugin::NS_OWNCLOUD . '}read-only']) {","path":"apps/dav/lib/carddav/addressbook.php","position":31,"original_position":31,"commit_id":"1d4a10137d32a2c1501a6d92c2485ff5a428a1f1","original_commit_id":"1d4a10137d32a2c1501a6d92c2485ff5a428a1f1","user":{"login":"georgehrke","id":1250540,"avatar_url":"https://avatars.githubusercontent.com/u/1250540?v=3","gravatar_id":"","url":"https://api.github.com/users/georgehrke","html_url":"https://github.com/georgehrke","followers_url":"https://api.github.com/users/georgehrke/followers","following_url":"https://api.github.com/users/georgehrke/following{/other_user}","gists_url":"https://api.github.com/users/georgehrke/gists{/gist_id}","starred_url":"https://api.github.com/users/georgehrke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgehrke/subscriptions","organizations_url":"https://api.github.com/users/georgehrke/orgs","repos_url":"https://api.github.com/users/georgehrke/repos","events_url":"https://api.github.com/users/georgehrke/events{/privacy}","received_events_url":"https://api.github.com/users/georgehrke/received_events","type":"User","site_admin":false},"body":"In the CalDAV standard it's just read instead of read-only. Maybe we should consider following this pattern.\r\n\r\nhttps://trac.calendarserver.org/browser/CalendarServer/trunk/doc/Extensions/caldav-sharing.txt#L1124","created_at":"2016-01-18T13:34:56Z","updated_at":"2016-01-18T13:34:56Z","html_url":"https://github.com/owncloud/core/pull/21626#discussion_r49998690","pull_request_url":"https://api.github.com/repos/owncloud/core/pulls/21626","_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/49998690"},"html":{"href":"https://github.com/owncloud/core/pull/21626#discussion_r49998690"},"pull_request":{"href":"https://api.github.com/repos/owncloud/core/pulls/21626"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/21626","id":55645017,"html_url":"https://github.com/owncloud/core/pull/21626","diff_url":"https://github.com/owncloud/core/pull/21626.diff","patch_url":"https://github.com/owncloud/core/pull/21626.patch","issue_url":"https://api.github.com/repos/owncloud/core/issues/21626","number":21626,"state":"open","locked":false,"title":"Show group shared addressbooks","user":{"login":"DeepDiver1975","id":1005065,"avatar_url":"https://avatars.githubusercontent.com/u/1005065?v=3","gravatar_id":"","url":"https://api.github.com/users/DeepDiver1975","html_url":"https://github.com/DeepDiver1975","followers_url":"https://api.github.com/users/DeepDiver1975/followers","following_url":"https://api.github.com/users/DeepDiver1975/following{/other_user}","gists_url":"https://api.github.com/users/DeepDiver1975/gists{/gist_id}","starred_url":"https://api.github.com/users/DeepDiver1975/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeepDiver1975/subscriptions","organizations_url":"https://api.github.com/users/DeepDiver1975/orgs","repos_url":"https://api.github.com/users/DeepDiver1975/repos","events_url":"https://api.github.com/users/DeepDiver1975/events{/privacy}","received_events_url":"https://api.github.com/users/DeepDiver1975/received_events","type":"User","site_admin":false},"body":"How to test:\r\n1. POST https://github.com/owncloud/core/blob/share-addressbooks-with-groups-2/apps/dav/tests/travis/caldavtest/data/Resource/CardDAV/sharing/read-write/1.xml to an addressbook to share with a principal - either a user or a group\r\n2. see the addressbook popping up in the sharees list of addressbooks","created_at":"2016-01-11T16:36:20Z","updated_at":"2016-01-18T13:34:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45d0783afdc49d5dd72f211e261efbdffeb65a9a","assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/48","html_url":"https://github.com/owncloud/core/milestones/9.0-current","labels_url":"https://api.github.com/repos/owncloud/core/milestones/48/labels","id":1196845,"number":48,"title":"9.0-current","description":"","creator":{"login":"cmonteroluque","id":879976,"avatar_url":"https://avatars.githubusercontent.com/u/879976?v=3","gravatar_id":"","url":"https://api.github.com/users/cmonteroluque","html_url":"https://github.com/cmonteroluque","followers_url":"https://api.github.com/users/cmonteroluque/followers","following_url":"https://api.github.com/users/cmonteroluque/following{/other_user}","gists_url":"https://api.github.com/users/cmonteroluque/gists{/gist_id}","starred_url":"https://api.github.com/users/cmonteroluque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmonteroluque/subscriptions","organizations_url":"https://api.github.com/users/cmonteroluque/orgs","repos_url":"https://api.github.com/users/cmonteroluque/repos","events_url":"https://api.github.com/users/cmonteroluque/events{/privacy}","received_events_url":"https://api.github.com/users/cmonteroluque/received_events","type":"User","site_admin":false},"open_issues":651,"closed_issues":1009,"state":"open","created_at":"2015-07-07T14:21:23Z","updated_at":"2016-01-18T13:28:21Z","due_on":"2016-03-08T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/owncloud/core/pulls/21626/commits","review_comments_url":"https://api.github.com/repos/owncloud/core/pulls/21626/comments","review_comment_url":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/core/issues/21626/comments","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/1d4a10137d32a2c1501a6d92c2485ff5a428a1f1","head":{"label":"owncloud:share-addressbooks-with-groups-2","ref":"share-addressbooks-with-groups-2","sha":"1d4a10137d32a2c1501a6d92c2485ff5a428a1f1","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":"The ownCloud core","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","created_at":"2012-08-25T10:32:48Z","updated_at":"2016-01-18T13:03:27Z","pushed_at":"2016-01-18T13:17:30Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":"https://owncloud.org/","size":287150,"stargazers_count":4033,"watchers_count":4033,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1304,"mirror_url":null,"open_issues_count":1878,"forks":1304,"open_issues":1878,"watchers":4033,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"1fca96656d0f64e00d26cdcd2e8788c640f1230b","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":"The ownCloud core","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","created_at":"2012-08-25T10:32:48Z","updated_at":"2016-01-18T13:03:27Z","pushed_at":"2016-01-18T13:17:30Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":"https://owncloud.org/","size":287150,"stargazers_count":4033,"watchers_count":4033,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1304,"mirror_url":null,"open_issues_count":1878,"forks":1304,"open_issues":1878,"watchers":4033,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/21626"},"html":{"href":"https://github.com/owncloud/core/pull/21626"},"issue":{"href":"https://api.github.com/repos/owncloud/core/issues/21626"},"comments":{"href":"https://api.github.com/repos/owncloud/core/issues/21626/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/core/pulls/21626/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/core/pulls/21626/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/core/statuses/1d4a10137d32a2c1501a6d92c2485ff5a428a1f1"}}}}