{"action":"created","issue":{"url":"https://api.github.com/repos/MichalBusta/FASText/issues/9","repository_url":"https://api.github.com/repos/MichalBusta/FASText","labels_url":"https://api.github.com/repos/MichalBusta/FASText/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/MichalBusta/FASText/issues/9/comments","events_url":"https://api.github.com/repos/MichalBusta/FASText/issues/9/events","html_url":"https://github.com/MichalBusta/FASText/issues/9","id":166770182,"number":9,"title":"KeyPoint question","user":{"login":"wenhuach","id":8307298,"avatar_url":"https://avatars.githubusercontent.com/u/8307298?v=3","gravatar_id":"","url":"https://api.github.com/users/wenhuach","html_url":"https://github.com/wenhuach","followers_url":"https://api.github.com/users/wenhuach/followers","following_url":"https://api.github.com/users/wenhuach/following{/other_user}","gists_url":"https://api.github.com/users/wenhuach/gists{/gist_id}","starred_url":"https://api.github.com/users/wenhuach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenhuach/subscriptions","organizations_url":"https://api.github.com/users/wenhuach/orgs","repos_url":"https://api.github.com/users/wenhuach/repos","events_url":"https://api.github.com/users/wenhuach/events{/privacy}","received_events_url":"https://api.github.com/users/wenhuach/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-21T09:00:55Z","updated_at":"2016-07-21T11:58:56Z","closed_at":null,"body":"Hi,\r\nMay I ask some questions related to keypoints? \r\nI am debugging funtion fastext_inner_loop_12 in FASTex.cpp. I have the following questions, \r\n1 If the keypoint type is SEK,  the variable \"vmin\" only considers part of Pd or Pb, why?\r\n2 The keypoint score you used  is the min(abs(Ix - Ip)), right? It's different with what you said in your paper. \r\n3 May I know the reason why you check the corner and cornerout points?\r\n4 If the current pixel value is 164, the circle 12 pixel values are 93, 99,74,205,151,188,188,168,20,19,20,100 respectively, and the thereshold is 12, then it will be considererd as a SBK. But it contains all the three types Pb,Ps and Pd, while the paper said it should be contain only 2 types, (Pb and Ps) or （Pd and Ps）.\r\nThanks in advance. If I am wrong, please correct me."},"comment":{"url":"https://api.github.com/repos/MichalBusta/FASText/issues/comments/234233078","html_url":"https://github.com/MichalBusta/FASText/issues/9#issuecomment-234233078","issue_url":"https://api.github.com/repos/MichalBusta/FASText/issues/9","id":234233078,"user":{"login":"MichalBusta","id":4105136,"avatar_url":"https://avatars.githubusercontent.com/u/4105136?v=3","gravatar_id":"","url":"https://api.github.com/users/MichalBusta","html_url":"https://github.com/MichalBusta","followers_url":"https://api.github.com/users/MichalBusta/followers","following_url":"https://api.github.com/users/MichalBusta/following{/other_user}","gists_url":"https://api.github.com/users/MichalBusta/gists{/gist_id}","starred_url":"https://api.github.com/users/MichalBusta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichalBusta/subscriptions","organizations_url":"https://api.github.com/users/MichalBusta/orgs","repos_url":"https://api.github.com/users/MichalBusta/repos","events_url":"https://api.github.com/users/MichalBusta/events{/privacy}","received_events_url":"https://api.github.com/users/MichalBusta/received_events","type":"User","site_admin":false},"created_at":"2016-07-21T11:58:56Z","updated_at":"2016-07-21T11:58:56Z","body":"Hi,\nOn 07/21/2016 11:00 AM, wenhuach wrote:\n>\n> Hi,\n> May I ask some questions related to keypoints?\n> I am debugging funtion fastext_inner_loop_12 in FASTex.cpp. I have the \n> following questions,\n> 1 If the keypoint type is SEK, the variable \"vmin\" only considers part \n> of Pd or Pb, why?\n> 2 The keypoint scrore you used is the min(abs(Ix - Ip)), right? It's \n> different with what you said in your paper.\n>\n2: yes, you are right - you found the bug in paper - there should be min \ninstead of max.\n- if you have the dark keypoint, you will the darkest pixel from the \nbright  set, and the score is given by: Ix - min(Ip_min) - that is the \nreason why the \"vmin\" only considers part of Pd or Pb\n\n> 3 May I konw the reason why you check the corner and cornerout points?\n>\nwhat is corner-out point? you mean bends?\n\nMichal\n\n> Thanks in advance. If I am wrong, please correct me.\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub \n> <https://github.com/MichalBusta/FASText/issues/9>, or mute the thread \n> <https://github.com/notifications/unsubscribe-auth/AD6jsMV270hg5f2kyfxZP7ihSBYbosYmks5qXzVIgaJpZM4JRlZf>.\n>\n\n"}}
{"actor":{"display_login":"MichalBusta"}}