{"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/69193057","id":69193057,"diff_hunk":"@@ -88,27 +93,31 @@ PlanFeatures.propTypes = {\n \tavailable: PropTypes.bool,\n \tonUpgradeClick: PropTypes.func,\n \t// either you specify the plan prop or isPlaceholder prop\n-\tplan: React.PropTypes.string,\n-\tisPlaceholder: PropTypes.bool\n+\tplan: PropTypes.string,\n+\tisPlaceholder: PropTypes.bool,\n+\tisInSignup: PropTypes.bool","path":"client/my-sites/plan-features/index.jsx","position":39,"original_position":39,"commit_id":"48d7f4d65bea32724896a2471b4d0a76b70a5265","original_commit_id":"cf5107a78cd2d71409ac3b77eacbfc2697cc9d78","user":{"login":"gwwar","id":1270189,"avatar_url":"https://avatars.githubusercontent.com/u/1270189?v=3","gravatar_id":"","url":"https://api.github.com/users/gwwar","html_url":"https://github.com/gwwar","followers_url":"https://api.github.com/users/gwwar/followers","following_url":"https://api.github.com/users/gwwar/following{/other_user}","gists_url":"https://api.github.com/users/gwwar/gists{/gist_id}","starred_url":"https://api.github.com/users/gwwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwwar/subscriptions","organizations_url":"https://api.github.com/users/gwwar/orgs","repos_url":"https://api.github.com/users/gwwar/repos","events_url":"https://api.github.com/users/gwwar/events{/privacy}","received_events_url":"https://api.github.com/users/gwwar/received_events","type":"User","site_admin":false},"body":"It looked like `isInSignup` was being used to determine which data to use, eg from `QuerySitePlans` ( `/sites/$siteId/plans`) or `QueryPlans` (`/plans`). \r\n\r\nA future use case might be that we add another static marketing page, and so the `isInSignup` prop wouldn't make much sense.","created_at":"2016-06-30T19:14:11Z","updated_at":"2016-06-30T19:14:11Z","html_url":"https://github.com/Automattic/wp-calypso/pull/6376#discussion_r69193057","pull_request_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6376","_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/69193057"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/6376#discussion_r69193057"},"pull_request":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6376"}}},"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6376","id":75517022,"html_url":"https://github.com/Automattic/wp-calypso/pull/6376","diff_url":"https://github.com/Automattic/wp-calypso/pull/6376.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/6376.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/6376","number":6376,"state":"open","locked":false,"title":"Add PlanFeatures (redesigned plans) to the NUX flow","user":{"login":"lamosty","id":4988512,"avatar_url":"https://avatars.githubusercontent.com/u/4988512?v=3","gravatar_id":"","url":"https://api.github.com/users/lamosty","html_url":"https://github.com/lamosty","followers_url":"https://api.github.com/users/lamosty/followers","following_url":"https://api.github.com/users/lamosty/following{/other_user}","gists_url":"https://api.github.com/users/lamosty/gists{/gist_id}","starred_url":"https://api.github.com/users/lamosty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamosty/subscriptions","organizations_url":"https://api.github.com/users/lamosty/orgs","repos_url":"https://api.github.com/users/lamosty/repos","events_url":"https://api.github.com/users/lamosty/events{/privacy}","received_events_url":"https://api.github.com/users/lamosty/received_events","type":"User","site_admin":false},"body":"Fix for #6302. Replaces the current plans implementation at the NUX flow plans page with the redesigned plans components.\r\n\r\n## Screenshots\r\n\r\n### Without Custom Domain\r\n\r\n![selection_024](https://cloud.githubusercontent.com/assets/4988512/16458828/dd1eb4f4-3e20-11e6-8011-7cbdfc7de294.jpg)\r\n\r\n### With Custom Domain\r\n\r\n![selection_022](https://cloud.githubusercontent.com/assets/4988512/16456963/24804ec2-3e1a-11e6-8bc8-61e1842f8eea.jpg)\r\n\r\n## Testing Instructions\r\n\r\n1. Start Calypso with `ENABLE_FEATURES=manage/plan-features make run`;\r\n2. Navigate to http://calypso.localhost:3000/start/plans-features;\r\n3. Go through the flow with console open;\r\n4. Notice the new redesigned plans page;\r\n5. Does it look alright? Does it look the same as on the `/plans` page?\r\n6. Click on the upgrade btn on each plan;\r\n7. Does it move you to the next step and puts the plan into your cart?\r\n8. Try the above with and without custom domain. It should display four plans without custom domain and three plans with custom domain.\r\n\r\n## Todo\r\n\r\n- [x] Add Free plan when custom domain is not selected\r\n- [ ] Fix visuals of plans header, especially when there are four plans. Related #6375.\r\n\r\ncc @gwwar @artpi @mtias @rralian \r\n\r\nTest live: https://calypso.live/?branch=add/plan-features-nux","created_at":"2016-06-28T17:25:00Z","updated_at":"2016-06-30T19:14:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e64fd734764b270e50e13fa4bb430e18f62a0708","assignee":{"login":"lamosty","id":4988512,"avatar_url":"https://avatars.githubusercontent.com/u/4988512?v=3","gravatar_id":"","url":"https://api.github.com/users/lamosty","html_url":"https://github.com/lamosty","followers_url":"https://api.github.com/users/lamosty/followers","following_url":"https://api.github.com/users/lamosty/following{/other_user}","gists_url":"https://api.github.com/users/lamosty/gists{/gist_id}","starred_url":"https://api.github.com/users/lamosty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamosty/subscriptions","organizations_url":"https://api.github.com/users/lamosty/orgs","repos_url":"https://api.github.com/users/lamosty/repos","events_url":"https://api.github.com/users/lamosty/events{/privacy}","received_events_url":"https://api.github.com/users/lamosty/received_events","type":"User","site_admin":false},"assignees":[{"login":"lamosty","id":4988512,"avatar_url":"https://avatars.githubusercontent.com/u/4988512?v=3","gravatar_id":"","url":"https://api.github.com/users/lamosty","html_url":"https://github.com/lamosty","followers_url":"https://api.github.com/users/lamosty/followers","following_url":"https://api.github.com/users/lamosty/following{/other_user}","gists_url":"https://api.github.com/users/lamosty/gists{/gist_id}","starred_url":"https://api.github.com/users/lamosty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamosty/subscriptions","organizations_url":"https://api.github.com/users/lamosty/orgs","repos_url":"https://api.github.com/users/lamosty/repos","events_url":"https://api.github.com/users/lamosty/events{/privacy}","received_events_url":"https://api.github.com/users/lamosty/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/89","html_url":"https://github.com/Automattic/wp-calypso/milestones/Plans:%20Maintenance","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/89/labels","id":1768456,"number":89,"title":"Plans: Maintenance","description":"","creator":{"login":"fabianapsimoes","id":1248436,"avatar_url":"https://avatars.githubusercontent.com/u/1248436?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianapsimoes","html_url":"https://github.com/fabianapsimoes","followers_url":"https://api.github.com/users/fabianapsimoes/followers","following_url":"https://api.github.com/users/fabianapsimoes/following{/other_user}","gists_url":"https://api.github.com/users/fabianapsimoes/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianapsimoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianapsimoes/subscriptions","organizations_url":"https://api.github.com/users/fabianapsimoes/orgs","repos_url":"https://api.github.com/users/fabianapsimoes/repos","events_url":"https://api.github.com/users/fabianapsimoes/events{/privacy}","received_events_url":"https://api.github.com/users/fabianapsimoes/received_events","type":"User","site_admin":false},"open_issues":37,"closed_issues":63,"state":"open","created_at":"2016-05-16T10:50:24Z","updated_at":"2016-06-30T18:32:33Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6376/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6376/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/6376/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/48d7f4d65bea32724896a2471b4d0a76b70a5265","head":{"label":"Automattic:add/plan-features-nux","ref":"add/plan-features-nux","sha":"48d7f4d65bea32724896a2471b4d0a76b70a5265","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2016-06-30T15:40:31Z","pushed_at":"2016-06-30T19:11:11Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":80333,"stargazers_count":7523,"watchers_count":7523,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":931,"mirror_url":null,"open_issues_count":1316,"forks":931,"open_issues":1316,"watchers":7523,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"50208c96897079f709594c13f5279c8af4c68f4d","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2016-06-30T15:40:31Z","pushed_at":"2016-06-30T19:11:11Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":80333,"stargazers_count":7523,"watchers_count":7523,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":931,"mirror_url":null,"open_issues_count":1316,"forks":931,"open_issues":1316,"watchers":7523,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6376"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/6376"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/6376"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/6376/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6376/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6376/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/48d7f4d65bea32724896a2471b4d0a76b70a5265"}}}}
{"actor":{"display_login":"gwwar"}}