{"action":"created","comment":{"url":"https://api.github.com/repos/cahirwpz/mimiker/pulls/comments/87722889","pull_request_review_id":8323507,"id":87722889,"diff_hunk":"@@ -0,0 +1,67 @@\n+#include <mips/asm.h>\n+#include <errno.h>\n+\n+    .set noreorder\n+    .set noat\n+\n+/* This implementation uses newlib-specific errno processing. */\n+#define DO_SYSCALL(num)  \\","path":"user/syscalls.S","position":8,"original_position":8,"commit_id":"4b210edc44e8bcd96f6c9973ea11cd608aef0480","original_commit_id":"4b210edc44e8bcd96f6c9973ea11cd608aef0480","user":{"login":"rafalcieslak","id":6637987,"avatar_url":"https://avatars.githubusercontent.com/u/6637987?v=3","gravatar_id":"","url":"https://api.github.com/users/rafalcieslak","html_url":"https://github.com/rafalcieslak","followers_url":"https://api.github.com/users/rafalcieslak/followers","following_url":"https://api.github.com/users/rafalcieslak/following{/other_user}","gists_url":"https://api.github.com/users/rafalcieslak/gists{/gist_id}","starred_url":"https://api.github.com/users/rafalcieslak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafalcieslak/subscriptions","organizations_url":"https://api.github.com/users/rafalcieslak/orgs","repos_url":"https://api.github.com/users/rafalcieslak/repos","events_url":"https://api.github.com/users/rafalcieslak/events{/privacy}","received_events_url":"https://api.github.com/users/rafalcieslak/received_events","type":"User","site_admin":false},"body":"I believe this works well. I'm not sure if it's more clear, especially with how `bltz $v0, syscall_failed;` does not set `$ra` so that `syscall_failed` returns from 2 nested calls at once... but that's just my opinion.\r\n\r\nI'm pushing a commit which applies this change, but can you please finish the work on this branch? It doesn't seem I'm doing anything useful here at this point.","created_at":"2016-11-13T22:06:24Z","updated_at":"2016-11-13T22:06:24Z","html_url":"https://github.com/cahirwpz/mimiker/pull/127#discussion_r87722889","pull_request_url":"https://api.github.com/repos/cahirwpz/mimiker/pulls/127","_links":{"self":{"href":"https://api.github.com/repos/cahirwpz/mimiker/pulls/comments/87722889"},"html":{"href":"https://github.com/cahirwpz/mimiker/pull/127#discussion_r87722889"},"pull_request":{"href":"https://api.github.com/repos/cahirwpz/mimiker/pulls/127"}}},"pull_request":{"url":"https://api.github.com/repos/cahirwpz/mimiker/pulls/127","id":93438673,"html_url":"https://github.com/cahirwpz/mimiker/pull/127","diff_url":"https://github.com/cahirwpz/mimiker/pull/127.diff","patch_url":"https://github.com/cahirwpz/mimiker/pull/127.patch","issue_url":"https://api.github.com/repos/cahirwpz/mimiker/issues/127","number":127,"state":"open","locked":false,"title":"Expanding user syscall stubs","user":{"login":"rafalcieslak","id":6637987,"avatar_url":"https://avatars.githubusercontent.com/u/6637987?v=3","gravatar_id":"","url":"https://api.github.com/users/rafalcieslak","html_url":"https://github.com/rafalcieslak","followers_url":"https://api.github.com/users/rafalcieslak/followers","following_url":"https://api.github.com/users/rafalcieslak/following{/other_user}","gists_url":"https://api.github.com/users/rafalcieslak/gists{/gist_id}","starred_url":"https://api.github.com/users/rafalcieslak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafalcieslak/subscriptions","organizations_url":"https://api.github.com/users/rafalcieslak/orgs","repos_url":"https://api.github.com/users/rafalcieslak/repos","events_url":"https://api.github.com/users/rafalcieslak/events{/privacy}","received_events_url":"https://api.github.com/users/rafalcieslak/received_events","type":"User","site_admin":false},"body":"This branch effectively glues #125 and #126, so that the standard library can actually use system calls.\r\n\r\nGood news is that `printf` in userspace actually works now, even though we don't have `sbrk`. I don't know how does it do string formatting (all libc's internal memory allocation fails) but somehow it does.","created_at":"2016-11-12T13:12:32Z","updated_at":"2016-11-13T22:06:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7189a4375c91b8e110be080b2cf7fab3cbaa4e2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cahirwpz/mimiker/pulls/127/commits","review_comments_url":"https://api.github.com/repos/cahirwpz/mimiker/pulls/127/comments","review_comment_url":"https://api.github.com/repos/cahirwpz/mimiker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cahirwpz/mimiker/issues/127/comments","statuses_url":"https://api.github.com/repos/cahirwpz/mimiker/statuses/4b210edc44e8bcd96f6c9973ea11cd608aef0480","head":{"label":"rafalcieslak:syscalls-glue","ref":"syscalls-glue","sha":"4b210edc44e8bcd96f6c9973ea11cd608aef0480","user":{"login":"rafalcieslak","id":6637987,"avatar_url":"https://avatars.githubusercontent.com/u/6637987?v=3","gravatar_id":"","url":"https://api.github.com/users/rafalcieslak","html_url":"https://github.com/rafalcieslak","followers_url":"https://api.github.com/users/rafalcieslak/followers","following_url":"https://api.github.com/users/rafalcieslak/following{/other_user}","gists_url":"https://api.github.com/users/rafalcieslak/gists{/gist_id}","starred_url":"https://api.github.com/users/rafalcieslak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafalcieslak/subscriptions","organizations_url":"https://api.github.com/users/rafalcieslak/orgs","repos_url":"https://api.github.com/users/rafalcieslak/repos","events_url":"https://api.github.com/users/rafalcieslak/events{/privacy}","received_events_url":"https://api.github.com/users/rafalcieslak/received_events","type":"User","site_admin":false},"repo":{"id":47133877,"name":"mimiker","full_name":"rafalcieslak/mimiker","owner":{"login":"rafalcieslak","id":6637987,"avatar_url":"https://avatars.githubusercontent.com/u/6637987?v=3","gravatar_id":"","url":"https://api.github.com/users/rafalcieslak","html_url":"https://github.com/rafalcieslak","followers_url":"https://api.github.com/users/rafalcieslak/followers","following_url":"https://api.github.com/users/rafalcieslak/following{/other_user}","gists_url":"https://api.github.com/users/rafalcieslak/gists{/gist_id}","starred_url":"https://api.github.com/users/rafalcieslak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafalcieslak/subscriptions","organizations_url":"https://api.github.com/users/rafalcieslak/orgs","repos_url":"https://api.github.com/users/rafalcieslak/repos","events_url":"https://api.github.com/users/rafalcieslak/events{/privacy}","received_events_url":"https://api.github.com/users/rafalcieslak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rafalcieslak/mimiker","description":" An experiment with implementation of very simple operating system for Malta board ","fork":true,"url":"https://api.github.com/repos/rafalcieslak/mimiker","forks_url":"https://api.github.com/repos/rafalcieslak/mimiker/forks","keys_url":"https://api.github.com/repos/rafalcieslak/mimiker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rafalcieslak/mimiker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rafalcieslak/mimiker/teams","hooks_url":"https://api.github.com/repos/rafalcieslak/mimiker/hooks","issue_events_url":"https://api.github.com/repos/rafalcieslak/mimiker/issues/events{/number}","events_url":"https://api.github.com/repos/rafalcieslak/mimiker/events","assignees_url":"https://api.github.com/repos/rafalcieslak/mimiker/assignees{/user}","branches_url":"https://api.github.com/repos/rafalcieslak/mimiker/branches{/branch}","tags_url":"https://api.github.com/repos/rafalcieslak/mimiker/tags","blobs_url":"https://api.github.com/repos/rafalcieslak/mimiker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rafalcieslak/mimiker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rafalcieslak/mimiker/git/refs{/sha}","trees_url":"https://api.github.com/repos/rafalcieslak/mimiker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rafalcieslak/mimiker/statuses/{sha}","languages_url":"https://api.github.com/repos/rafalcieslak/mimiker/languages","stargazers_url":"https://api.github.com/repos/rafalcieslak/mimiker/stargazers","contributors_url":"https://api.github.com/repos/rafalcieslak/mimiker/contributors","subscribers_url":"https://api.github.com/repos/rafalcieslak/mimiker/subscribers","subscription_url":"https://api.github.com/repos/rafalcieslak/mimiker/subscription","commits_url":"https://api.github.com/repos/rafalcieslak/mimiker/commits{/sha}","git_commits_url":"https://api.github.com/repos/rafalcieslak/mimiker/git/commits{/sha}","comments_url":"https://api.github.com/repos/rafalcieslak/mimiker/comments{/number}","issue_comment_url":"https://api.github.com/repos/rafalcieslak/mimiker/issues/comments{/number}","contents_url":"https://api.github.com/repos/rafalcieslak/mimiker/contents/{+path}","compare_url":"https://api.github.com/repos/rafalcieslak/mimiker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rafalcieslak/mimiker/merges","archive_url":"https://api.github.com/repos/rafalcieslak/mimiker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rafalcieslak/mimiker/downloads","issues_url":"https://api.github.com/repos/rafalcieslak/mimiker/issues{/number}","pulls_url":"https://api.github.com/repos/rafalcieslak/mimiker/pulls{/number}","milestones_url":"https://api.github.com/repos/rafalcieslak/mimiker/milestones{/number}","notifications_url":"https://api.github.com/repos/rafalcieslak/mimiker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rafalcieslak/mimiker/labels{/name}","releases_url":"https://api.github.com/repos/rafalcieslak/mimiker/releases{/id}","deployments_url":"https://api.github.com/repos/rafalcieslak/mimiker/deployments","created_at":"2015-11-30T17:12:17Z","updated_at":"2016-11-05T15:34:25Z","pushed_at":"2016-11-13T20:35:38Z","git_url":"git://github.com/rafalcieslak/mimiker.git","ssh_url":"git@github.com:rafalcieslak/mimiker.git","clone_url":"https://github.com/rafalcieslak/mimiker.git","svn_url":"https://github.com/rafalcieslak/mimiker","homepage":"","size":1439,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cahirwpz:master","ref":"master","sha":"199e297ee7f1d13721cc8ed7362b0506a20feff8","user":{"login":"cahirwpz","id":265236,"avatar_url":"https://avatars.githubusercontent.com/u/265236?v=3","gravatar_id":"","url":"https://api.github.com/users/cahirwpz","html_url":"https://github.com/cahirwpz","followers_url":"https://api.github.com/users/cahirwpz/followers","following_url":"https://api.github.com/users/cahirwpz/following{/other_user}","gists_url":"https://api.github.com/users/cahirwpz/gists{/gist_id}","starred_url":"https://api.github.com/users/cahirwpz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cahirwpz/subscriptions","organizations_url":"https://api.github.com/users/cahirwpz/orgs","repos_url":"https://api.github.com/users/cahirwpz/repos","events_url":"https://api.github.com/users/cahirwpz/events{/privacy}","received_events_url":"https://api.github.com/users/cahirwpz/received_events","type":"User","site_admin":false},"repo":{"id":46346617,"name":"mimiker","full_name":"cahirwpz/mimiker","owner":{"login":"cahirwpz","id":265236,"avatar_url":"https://avatars.githubusercontent.com/u/265236?v=3","gravatar_id":"","url":"https://api.github.com/users/cahirwpz","html_url":"https://github.com/cahirwpz","followers_url":"https://api.github.com/users/cahirwpz/followers","following_url":"https://api.github.com/users/cahirwpz/following{/other_user}","gists_url":"https://api.github.com/users/cahirwpz/gists{/gist_id}","starred_url":"https://api.github.com/users/cahirwpz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cahirwpz/subscriptions","organizations_url":"https://api.github.com/users/cahirwpz/orgs","repos_url":"https://api.github.com/users/cahirwpz/repos","events_url":"https://api.github.com/users/cahirwpz/events{/privacy}","received_events_url":"https://api.github.com/users/cahirwpz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cahirwpz/mimiker","description":"An experiment with implementation of very simple operating system for Malta board","fork":false,"url":"https://api.github.com/repos/cahirwpz/mimiker","forks_url":"https://api.github.com/repos/cahirwpz/mimiker/forks","keys_url":"https://api.github.com/repos/cahirwpz/mimiker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cahirwpz/mimiker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cahirwpz/mimiker/teams","hooks_url":"https://api.github.com/repos/cahirwpz/mimiker/hooks","issue_events_url":"https://api.github.com/repos/cahirwpz/mimiker/issues/events{/number}","events_url":"https://api.github.com/repos/cahirwpz/mimiker/events","assignees_url":"https://api.github.com/repos/cahirwpz/mimiker/assignees{/user}","branches_url":"https://api.github.com/repos/cahirwpz/mimiker/branches{/branch}","tags_url":"https://api.github.com/repos/cahirwpz/mimiker/tags","blobs_url":"https://api.github.com/repos/cahirwpz/mimiker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cahirwpz/mimiker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cahirwpz/mimiker/git/refs{/sha}","trees_url":"https://api.github.com/repos/cahirwpz/mimiker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cahirwpz/mimiker/statuses/{sha}","languages_url":"https://api.github.com/repos/cahirwpz/mimiker/languages","stargazers_url":"https://api.github.com/repos/cahirwpz/mimiker/stargazers","contributors_url":"https://api.github.com/repos/cahirwpz/mimiker/contributors","subscribers_url":"https://api.github.com/repos/cahirwpz/mimiker/subscribers","subscription_url":"https://api.github.com/repos/cahirwpz/mimiker/subscription","commits_url":"https://api.github.com/repos/cahirwpz/mimiker/commits{/sha}","git_commits_url":"https://api.github.com/repos/cahirwpz/mimiker/git/commits{/sha}","comments_url":"https://api.github.com/repos/cahirwpz/mimiker/comments{/number}","issue_comment_url":"https://api.github.com/repos/cahirwpz/mimiker/issues/comments{/number}","contents_url":"https://api.github.com/repos/cahirwpz/mimiker/contents/{+path}","compare_url":"https://api.github.com/repos/cahirwpz/mimiker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cahirwpz/mimiker/merges","archive_url":"https://api.github.com/repos/cahirwpz/mimiker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cahirwpz/mimiker/downloads","issues_url":"https://api.github.com/repos/cahirwpz/mimiker/issues{/number}","pulls_url":"https://api.github.com/repos/cahirwpz/mimiker/pulls{/number}","milestones_url":"https://api.github.com/repos/cahirwpz/mimiker/milestones{/number}","notifications_url":"https://api.github.com/repos/cahirwpz/mimiker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cahirwpz/mimiker/labels{/name}","releases_url":"https://api.github.com/repos/cahirwpz/mimiker/releases{/id}","deployments_url":"https://api.github.com/repos/cahirwpz/mimiker/deployments","created_at":"2015-11-17T12:46:47Z","updated_at":"2016-10-23T17:00:09Z","pushed_at":"2016-11-13T20:35:38Z","git_url":"git://github.com/cahirwpz/mimiker.git","ssh_url":"git@github.com:cahirwpz/mimiker.git","clone_url":"https://github.com/cahirwpz/mimiker.git","svn_url":"https://github.com/cahirwpz/mimiker","homepage":"","size":1578,"stargazers_count":6,"watchers_count":6,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":7,"forks":12,"open_issues":7,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cahirwpz/mimiker/pulls/127"},"html":{"href":"https://github.com/cahirwpz/mimiker/pull/127"},"issue":{"href":"https://api.github.com/repos/cahirwpz/mimiker/issues/127"},"comments":{"href":"https://api.github.com/repos/cahirwpz/mimiker/issues/127/comments"},"review_comments":{"href":"https://api.github.com/repos/cahirwpz/mimiker/pulls/127/comments"},"review_comment":{"href":"https://api.github.com/repos/cahirwpz/mimiker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cahirwpz/mimiker/pulls/127/commits"},"statuses":{"href":"https://api.github.com/repos/cahirwpz/mimiker/statuses/4b210edc44e8bcd96f6c9973ea11cd608aef0480"}}}}
{"actor":{"display_login":"rafalcieslak"}}