{"action":"created","issue":{"url":"https://api.github.com/repos/clappr/clappr/issues/966","repository_url":"https://api.github.com/repos/clappr/clappr","labels_url":"https://api.github.com/repos/clappr/clappr/issues/966/labels{/name}","comments_url":"https://api.github.com/repos/clappr/clappr/issues/966/comments","events_url":"https://api.github.com/repos/clappr/clappr/issues/966/events","html_url":"https://github.com/clappr/clappr/pull/966","id":151839882,"number":966,"title":"Several enhancements in Player class","user":{"login":"gamtiq","id":1177323,"avatar_url":"https://avatars.githubusercontent.com/u/1177323?v=3","gravatar_id":"","url":"https://api.github.com/users/gamtiq","html_url":"https://github.com/gamtiq","followers_url":"https://api.github.com/users/gamtiq/followers","following_url":"https://api.github.com/users/gamtiq/following{/other_user}","gists_url":"https://api.github.com/users/gamtiq/gists{/gist_id}","starred_url":"https://api.github.com/users/gamtiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamtiq/subscriptions","organizations_url":"https://api.github.com/users/gamtiq/orgs","repos_url":"https://api.github.com/users/gamtiq/repos","events_url":"https://api.github.com/users/gamtiq/events{/privacy}","received_events_url":"https://api.github.com/users/gamtiq/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-04-29T10:48:34Z","updated_at":"2016-04-30T21:54:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/clappr/clappr/pulls/966","html_url":"https://github.com/clappr/clappr/pull/966","diff_url":"https://github.com/clappr/clappr/pull/966.diff","patch_url":"https://github.com/clappr/clappr/pull/966.patch"},"body":"I have made the following improvements in Player class:\r\n* refactored `setVolume` and `getVolume` methods (this change should fix #677)\r\n* changed implementation of `mute` and `unmute` methods to restore volume level\r\n* added `start` method\r\n* added `return this;` into interface methods so that make them chainable\r\n"},"comment":{"url":"https://api.github.com/repos/clappr/clappr/issues/comments/215997625","html_url":"https://github.com/clappr/clappr/pull/966#issuecomment-215997625","issue_url":"https://api.github.com/repos/clappr/clappr/issues/966","id":215997625,"user":{"login":"gamtiq","id":1177323,"avatar_url":"https://avatars.githubusercontent.com/u/1177323?v=3","gravatar_id":"","url":"https://api.github.com/users/gamtiq","html_url":"https://github.com/gamtiq","followers_url":"https://api.github.com/users/gamtiq/followers","following_url":"https://api.github.com/users/gamtiq/following{/other_user}","gists_url":"https://api.github.com/users/gamtiq/gists{/gist_id}","starred_url":"https://api.github.com/users/gamtiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamtiq/subscriptions","organizations_url":"https://api.github.com/users/gamtiq/orgs","repos_url":"https://api.github.com/users/gamtiq/repos","events_url":"https://api.github.com/users/gamtiq/events{/privacy}","received_events_url":"https://api.github.com/users/gamtiq/received_events","type":"User","site_admin":false},"created_at":"2016-04-30T21:54:41Z","updated_at":"2016-04-30T21:54:41Z","body":"I have added `start` method for convenience so that to make just one call instead of two (`load`/`configure` and `play`) when starting playing of new video.\r\nMaybe it is worth not to add new method but change implementation of `play` method so that it would be possible to pass optional parameters specifying source that should be played.\r\nIf that is accepted I can delete `start` method and move the appropriate logic into `play` method.\r\n"}}