{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/pulls/comments/66761737","id":66761737,"diff_hunk":"@@ -7,6 +7,7 @@ def self.present_content(batch_data)\n           item['content_id'],\n           item['format'],\n           item['index'],\n+          item['is_withdrawn'] == 'true' ? 'withdrawn' : 'not_withdrawn',","path":"lib/import/rummager_data_presenter.rb","position":4,"original_position":4,"commit_id":"b973eae0900d22417b9a072decac052d31b107b9","original_commit_id":"e7248650b8fd7a2a81e7d86dce2b4585fac864f8","user":{"login":"tijmenb","id":233676,"avatar_url":"https://avatars.githubusercontent.com/u/233676?v=3","gravatar_id":"","url":"https://api.github.com/users/tijmenb","html_url":"https://github.com/tijmenb","followers_url":"https://api.github.com/users/tijmenb/followers","following_url":"https://api.github.com/users/tijmenb/following{/other_user}","gists_url":"https://api.github.com/users/tijmenb/gists{/gist_id}","starred_url":"https://api.github.com/users/tijmenb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tijmenb/subscriptions","organizations_url":"https://api.github.com/users/tijmenb/orgs","repos_url":"https://api.github.com/users/tijmenb/repos","events_url":"https://api.github.com/users/tijmenb/events{/privacy}","received_events_url":"https://api.github.com/users/tijmenb/received_events","type":"User","site_admin":false},"body":"It's a boolean, not a string: https://github.com/alphagov/rummager/pull/649","created_at":"2016-06-13T09:20:03Z","updated_at":"2016-06-13T09:20:03Z","html_url":"https://github.com/alphagov/finding-things-migration-checker/pull/57#discussion_r66761737","pull_request_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/alphagov/finding-things-migration-checker/pulls/comments/66761737"},"html":{"href":"https://github.com/alphagov/finding-things-migration-checker/pull/57#discussion_r66761737"},"pull_request":{"href":"https://api.github.com/repos/alphagov/finding-things-migration-checker/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/pulls/57","id":73356675,"html_url":"https://github.com/alphagov/finding-things-migration-checker/pull/57","diff_url":"https://github.com/alphagov/finding-things-migration-checker/pull/57.diff","patch_url":"https://github.com/alphagov/finding-things-migration-checker/pull/57.patch","issue_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/issues/57","number":57,"state":"closed","locked":false,"title":"Ignore withdrawn items when checking what is missing from publishing-api","user":{"login":"benhyland","id":4282030,"avatar_url":"https://avatars.githubusercontent.com/u/4282030?v=3","gravatar_id":"","url":"https://api.github.com/users/benhyland","html_url":"https://github.com/benhyland","followers_url":"https://api.github.com/users/benhyland/followers","following_url":"https://api.github.com/users/benhyland/following{/other_user}","gists_url":"https://api.github.com/users/benhyland/gists{/gist_id}","starred_url":"https://api.github.com/users/benhyland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benhyland/subscriptions","organizations_url":"https://api.github.com/users/benhyland/orgs","repos_url":"https://api.github.com/users/benhyland/repos","events_url":"https://api.github.com/users/benhyland/events{/privacy}","received_events_url":"https://api.github.com/users/benhyland/received_events","type":"User","site_admin":false},"body":"We cannot link rummager base paths to pubilshing-api content ids\r\nwhen the item in question is withdrawn, because the lookup by\r\nbase path endpoint only returns published items.\r\n\r\nWe still need to include withdrawn items in the rummager import\r\nsince we need to prevent false positives in the opposite check.\r\n\r\nSo, this PR includes the is_withdrawn field from rummager and examines it\r\nin the single check where it has to be used as a filter.\r\n\r\n@davidslv and @benhyland","created_at":"2016-06-10T11:06:04Z","updated_at":"2016-06-13T09:20:03Z","closed_at":"2016-06-10T14:12:07Z","merged_at":"2016-06-10T14:12:07Z","merge_commit_sha":"7c066f06ffdaa3efe366bb7f6c01ebd60852507a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/pulls/57/commits","review_comments_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/pulls/57/comments","review_comment_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/issues/57/comments","statuses_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/statuses/b973eae0900d22417b9a072decac052d31b107b9","head":{"label":"alphagov:ignore-withdrawn-items-when-checking-missing-from-publishing-api","ref":"ignore-withdrawn-items-when-checking-missing-from-publishing-api","sha":"b973eae0900d22417b9a072decac052d31b107b9","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":57119961,"name":"finding-things-migration-checker","full_name":"alphagov/finding-things-migration-checker","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/finding-things-migration-checker","description":"Check that publishing-api, rummager links are in sync.","fork":false,"url":"https://api.github.com/repos/alphagov/finding-things-migration-checker","forks_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/forks","keys_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/teams","hooks_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/hooks","issue_events_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/events","assignees_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/tags","blobs_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/languages","stargazers_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/stargazers","contributors_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/contributors","subscribers_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/subscribers","subscription_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/subscription","commits_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/merges","archive_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/downloads","issues_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/deployments","created_at":"2016-04-26T10:37:14Z","updated_at":"2016-04-26T10:46:00Z","pushed_at":"2016-06-10T14:12:09Z","git_url":"git://github.com/alphagov/finding-things-migration-checker.git","ssh_url":"git@github.com:alphagov/finding-things-migration-checker.git","clone_url":"https://github.com/alphagov/finding-things-migration-checker.git","svn_url":"https://github.com/alphagov/finding-things-migration-checker","homepage":null,"size":128,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"b326c259b83a45f5d0fa8e28fb6b2a8b6f6a5cb4","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":57119961,"name":"finding-things-migration-checker","full_name":"alphagov/finding-things-migration-checker","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/finding-things-migration-checker","description":"Check that publishing-api, rummager links are in sync.","fork":false,"url":"https://api.github.com/repos/alphagov/finding-things-migration-checker","forks_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/forks","keys_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/teams","hooks_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/hooks","issue_events_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/events","assignees_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/tags","blobs_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/languages","stargazers_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/stargazers","contributors_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/contributors","subscribers_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/subscribers","subscription_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/subscription","commits_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/merges","archive_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/downloads","issues_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/finding-things-migration-checker/deployments","created_at":"2016-04-26T10:37:14Z","updated_at":"2016-04-26T10:46:00Z","pushed_at":"2016-06-10T14:12:09Z","git_url":"git://github.com/alphagov/finding-things-migration-checker.git","ssh_url":"git@github.com:alphagov/finding-things-migration-checker.git","clone_url":"https://github.com/alphagov/finding-things-migration-checker.git","svn_url":"https://github.com/alphagov/finding-things-migration-checker","homepage":null,"size":128,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/finding-things-migration-checker/pulls/57"},"html":{"href":"https://github.com/alphagov/finding-things-migration-checker/pull/57"},"issue":{"href":"https://api.github.com/repos/alphagov/finding-things-migration-checker/issues/57"},"comments":{"href":"https://api.github.com/repos/alphagov/finding-things-migration-checker/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/finding-things-migration-checker/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/finding-things-migration-checker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/finding-things-migration-checker/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/finding-things-migration-checker/statuses/b973eae0900d22417b9a072decac052d31b107b9"}}}}
{"actor":{"display_login":"tijmenb"}}