{"action":"created","comment":{"url":"https://api.github.com/repos/softdevteam/llrm/pulls/comments/71536735","id":71536735,"diff_hunk":"@@ -162,7 +205,7 @@ def _get_instructions(self, l_block, w_module):\n             prev = current_instr\n             w_instrs.append(current_instr)\n             l_instr = llwrap.LLVMGetNextInstruction(l_instr)\n-        return w_instrs\n+        return w_instrs[:]","path":"llvm_objects.py","position":90,"original_position":92,"commit_id":"f799473bbdc572cb53a3673a57e68b97c79503a4","original_commit_id":"104a0078776abb6f9c9469b41598d3cb8d7f5daf","user":{"login":"gabi-250","id":15640520,"avatar_url":"https://avatars.githubusercontent.com/u/15640520?v=3","gravatar_id":"","url":"https://api.github.com/users/gabi-250","html_url":"https://github.com/gabi-250","followers_url":"https://api.github.com/users/gabi-250/followers","following_url":"https://api.github.com/users/gabi-250/following{/other_user}","gists_url":"https://api.github.com/users/gabi-250/gists{/gist_id}","starred_url":"https://api.github.com/users/gabi-250/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabi-250/subscriptions","organizations_url":"https://api.github.com/users/gabi-250/orgs","repos_url":"https://api.github.com/users/gabi-250/repos","events_url":"https://api.github.com/users/gabi-250/events{/privacy}","received_events_url":"https://api.github.com/users/gabi-250/received_events","type":"User","site_admin":false},"body":"Well, even if it returns a copy, it wouldn't necessarily be an immutable list. I'm not sure why one way would be better than another. I would argue returning a copy is better, because the original version cannot be altered by the caller.","created_at":"2016-07-20T14:35:33Z","updated_at":"2016-07-20T14:35:33Z","html_url":"https://github.com/softdevteam/llrm/pull/11#discussion_r71536735","pull_request_url":"https://api.github.com/repos/softdevteam/llrm/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/softdevteam/llrm/pulls/comments/71536735"},"html":{"href":"https://github.com/softdevteam/llrm/pull/11#discussion_r71536735"},"pull_request":{"href":"https://api.github.com/repos/softdevteam/llrm/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/softdevteam/llrm/pulls/11","id":77777130,"html_url":"https://github.com/softdevteam/llrm/pull/11","diff_url":"https://github.com/softdevteam/llrm/pull/11.diff","patch_url":"https://github.com/softdevteam/llrm/pull/11.patch","issue_url":"https://api.github.com/repos/softdevteam/llrm/issues/11","number":11,"state":"open","locked":false,"title":"Optimizations","user":{"login":"gabi-250","id":15640520,"avatar_url":"https://avatars.githubusercontent.com/u/15640520?v=3","gravatar_id":"","url":"https://api.github.com/users/gabi-250","html_url":"https://github.com/gabi-250","followers_url":"https://api.github.com/users/gabi-250/followers","following_url":"https://api.github.com/users/gabi-250/following{/other_user}","gists_url":"https://api.github.com/users/gabi-250/gists{/gist_id}","starred_url":"https://api.github.com/users/gabi-250/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabi-250/subscriptions","organizations_url":"https://api.github.com/users/gabi-250/orgs","repos_url":"https://api.github.com/users/gabi-250/repos","events_url":"https://api.github.com/users/gabi-250/events{/privacy}","received_events_url":"https://api.github.com/users/gabi-250/received_events","type":"User","site_admin":false},"body":"This branch contains an optimized version of the interpreter. The improvements include the removal of the constants dict and of the calls to `get_block` in the interpreter.","created_at":"2016-07-18T09:04:23Z","updated_at":"2016-07-20T14:35:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80ea980b12e6bb87be48ea242256aed397e263fc","assignee":{"login":"cfbolz","id":85942,"avatar_url":"https://avatars.githubusercontent.com/u/85942?v=3","gravatar_id":"","url":"https://api.github.com/users/cfbolz","html_url":"https://github.com/cfbolz","followers_url":"https://api.github.com/users/cfbolz/followers","following_url":"https://api.github.com/users/cfbolz/following{/other_user}","gists_url":"https://api.github.com/users/cfbolz/gists{/gist_id}","starred_url":"https://api.github.com/users/cfbolz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfbolz/subscriptions","organizations_url":"https://api.github.com/users/cfbolz/orgs","repos_url":"https://api.github.com/users/cfbolz/repos","events_url":"https://api.github.com/users/cfbolz/events{/privacy}","received_events_url":"https://api.github.com/users/cfbolz/received_events","type":"User","site_admin":false},"assignees":[{"login":"cfbolz","id":85942,"avatar_url":"https://avatars.githubusercontent.com/u/85942?v=3","gravatar_id":"","url":"https://api.github.com/users/cfbolz","html_url":"https://github.com/cfbolz","followers_url":"https://api.github.com/users/cfbolz/followers","following_url":"https://api.github.com/users/cfbolz/following{/other_user}","gists_url":"https://api.github.com/users/cfbolz/gists{/gist_id}","starred_url":"https://api.github.com/users/cfbolz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfbolz/subscriptions","organizations_url":"https://api.github.com/users/cfbolz/orgs","repos_url":"https://api.github.com/users/cfbolz/repos","events_url":"https://api.github.com/users/cfbolz/events{/privacy}","received_events_url":"https://api.github.com/users/cfbolz/received_events","type":"User","site_admin":false},{"login":"vext01","id":604955,"avatar_url":"https://avatars.githubusercontent.com/u/604955?v=3","gravatar_id":"","url":"https://api.github.com/users/vext01","html_url":"https://github.com/vext01","followers_url":"https://api.github.com/users/vext01/followers","following_url":"https://api.github.com/users/vext01/following{/other_user}","gists_url":"https://api.github.com/users/vext01/gists{/gist_id}","starred_url":"https://api.github.com/users/vext01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vext01/subscriptions","organizations_url":"https://api.github.com/users/vext01/orgs","repos_url":"https://api.github.com/users/vext01/repos","events_url":"https://api.github.com/users/vext01/events{/privacy}","received_events_url":"https://api.github.com/users/vext01/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/softdevteam/llrm/pulls/11/commits","review_comments_url":"https://api.github.com/repos/softdevteam/llrm/pulls/11/comments","review_comment_url":"https://api.github.com/repos/softdevteam/llrm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/softdevteam/llrm/issues/11/comments","statuses_url":"https://api.github.com/repos/softdevteam/llrm/statuses/f799473bbdc572cb53a3673a57e68b97c79503a4","head":{"label":"softdevteam:optimizations","ref":"optimizations","sha":"f799473bbdc572cb53a3673a57e68b97c79503a4","user":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars.githubusercontent.com/u/10271085?v=3","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"repo":{"id":60781778,"name":"llrm","full_name":"softdevteam/llrm","owner":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars.githubusercontent.com/u/10271085?v=3","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/softdevteam/llrm","description":"The Low Level RPython Machine: A RPython interpreter for LLVM bytecode.","fork":false,"url":"https://api.github.com/repos/softdevteam/llrm","forks_url":"https://api.github.com/repos/softdevteam/llrm/forks","keys_url":"https://api.github.com/repos/softdevteam/llrm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softdevteam/llrm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softdevteam/llrm/teams","hooks_url":"https://api.github.com/repos/softdevteam/llrm/hooks","issue_events_url":"https://api.github.com/repos/softdevteam/llrm/issues/events{/number}","events_url":"https://api.github.com/repos/softdevteam/llrm/events","assignees_url":"https://api.github.com/repos/softdevteam/llrm/assignees{/user}","branches_url":"https://api.github.com/repos/softdevteam/llrm/branches{/branch}","tags_url":"https://api.github.com/repos/softdevteam/llrm/tags","blobs_url":"https://api.github.com/repos/softdevteam/llrm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softdevteam/llrm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softdevteam/llrm/git/refs{/sha}","trees_url":"https://api.github.com/repos/softdevteam/llrm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softdevteam/llrm/statuses/{sha}","languages_url":"https://api.github.com/repos/softdevteam/llrm/languages","stargazers_url":"https://api.github.com/repos/softdevteam/llrm/stargazers","contributors_url":"https://api.github.com/repos/softdevteam/llrm/contributors","subscribers_url":"https://api.github.com/repos/softdevteam/llrm/subscribers","subscription_url":"https://api.github.com/repos/softdevteam/llrm/subscription","commits_url":"https://api.github.com/repos/softdevteam/llrm/commits{/sha}","git_commits_url":"https://api.github.com/repos/softdevteam/llrm/git/commits{/sha}","comments_url":"https://api.github.com/repos/softdevteam/llrm/comments{/number}","issue_comment_url":"https://api.github.com/repos/softdevteam/llrm/issues/comments{/number}","contents_url":"https://api.github.com/repos/softdevteam/llrm/contents/{+path}","compare_url":"https://api.github.com/repos/softdevteam/llrm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softdevteam/llrm/merges","archive_url":"https://api.github.com/repos/softdevteam/llrm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softdevteam/llrm/downloads","issues_url":"https://api.github.com/repos/softdevteam/llrm/issues{/number}","pulls_url":"https://api.github.com/repos/softdevteam/llrm/pulls{/number}","milestones_url":"https://api.github.com/repos/softdevteam/llrm/milestones{/number}","notifications_url":"https://api.github.com/repos/softdevteam/llrm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softdevteam/llrm/labels{/name}","releases_url":"https://api.github.com/repos/softdevteam/llrm/releases{/id}","deployments_url":"https://api.github.com/repos/softdevteam/llrm/deployments","created_at":"2016-06-09T14:38:09Z","updated_at":"2016-06-15T12:49:31Z","pushed_at":"2016-07-19T14:36:22Z","git_url":"git://github.com/softdevteam/llrm.git","ssh_url":"git@github.com:softdevteam/llrm.git","clone_url":"https://github.com/softdevteam/llrm.git","svn_url":"https://github.com/softdevteam/llrm","homepage":null,"size":97,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"softdevteam:master","ref":"master","sha":"39c2474cd34e4e7e296cea561fc28a8db213cc75","user":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars.githubusercontent.com/u/10271085?v=3","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"repo":{"id":60781778,"name":"llrm","full_name":"softdevteam/llrm","owner":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars.githubusercontent.com/u/10271085?v=3","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/softdevteam/llrm","description":"The Low Level RPython Machine: A RPython interpreter for LLVM bytecode.","fork":false,"url":"https://api.github.com/repos/softdevteam/llrm","forks_url":"https://api.github.com/repos/softdevteam/llrm/forks","keys_url":"https://api.github.com/repos/softdevteam/llrm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softdevteam/llrm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softdevteam/llrm/teams","hooks_url":"https://api.github.com/repos/softdevteam/llrm/hooks","issue_events_url":"https://api.github.com/repos/softdevteam/llrm/issues/events{/number}","events_url":"https://api.github.com/repos/softdevteam/llrm/events","assignees_url":"https://api.github.com/repos/softdevteam/llrm/assignees{/user}","branches_url":"https://api.github.com/repos/softdevteam/llrm/branches{/branch}","tags_url":"https://api.github.com/repos/softdevteam/llrm/tags","blobs_url":"https://api.github.com/repos/softdevteam/llrm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softdevteam/llrm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softdevteam/llrm/git/refs{/sha}","trees_url":"https://api.github.com/repos/softdevteam/llrm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softdevteam/llrm/statuses/{sha}","languages_url":"https://api.github.com/repos/softdevteam/llrm/languages","stargazers_url":"https://api.github.com/repos/softdevteam/llrm/stargazers","contributors_url":"https://api.github.com/repos/softdevteam/llrm/contributors","subscribers_url":"https://api.github.com/repos/softdevteam/llrm/subscribers","subscription_url":"https://api.github.com/repos/softdevteam/llrm/subscription","commits_url":"https://api.github.com/repos/softdevteam/llrm/commits{/sha}","git_commits_url":"https://api.github.com/repos/softdevteam/llrm/git/commits{/sha}","comments_url":"https://api.github.com/repos/softdevteam/llrm/comments{/number}","issue_comment_url":"https://api.github.com/repos/softdevteam/llrm/issues/comments{/number}","contents_url":"https://api.github.com/repos/softdevteam/llrm/contents/{+path}","compare_url":"https://api.github.com/repos/softdevteam/llrm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softdevteam/llrm/merges","archive_url":"https://api.github.com/repos/softdevteam/llrm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softdevteam/llrm/downloads","issues_url":"https://api.github.com/repos/softdevteam/llrm/issues{/number}","pulls_url":"https://api.github.com/repos/softdevteam/llrm/pulls{/number}","milestones_url":"https://api.github.com/repos/softdevteam/llrm/milestones{/number}","notifications_url":"https://api.github.com/repos/softdevteam/llrm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softdevteam/llrm/labels{/name}","releases_url":"https://api.github.com/repos/softdevteam/llrm/releases{/id}","deployments_url":"https://api.github.com/repos/softdevteam/llrm/deployments","created_at":"2016-06-09T14:38:09Z","updated_at":"2016-06-15T12:49:31Z","pushed_at":"2016-07-19T14:36:22Z","git_url":"git://github.com/softdevteam/llrm.git","ssh_url":"git@github.com:softdevteam/llrm.git","clone_url":"https://github.com/softdevteam/llrm.git","svn_url":"https://github.com/softdevteam/llrm","homepage":null,"size":97,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/softdevteam/llrm/pulls/11"},"html":{"href":"https://github.com/softdevteam/llrm/pull/11"},"issue":{"href":"https://api.github.com/repos/softdevteam/llrm/issues/11"},"comments":{"href":"https://api.github.com/repos/softdevteam/llrm/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/softdevteam/llrm/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/softdevteam/llrm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/softdevteam/llrm/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/softdevteam/llrm/statuses/f799473bbdc572cb53a3673a57e68b97c79503a4"}}}}
{"actor":{"display_login":"gabi-250"}}