{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/exporter/pulls/comments/74395846","id":74395846,"diff_hunk":"@@ -26,7 +26,8 @@\n         \"symfony/http-kernel\": \"^2.3 || ^3.0\",\n         \"symfony/phpunit-bridge\": \"^2.7 || ^3.0\",\n         \"symfony/property-access\": \"^2.3 || ^3.0\",\n-        \"symfony/routing\": \"^2.3 || ^3.0\"\n+        \"symfony/routing\": \"^2.3 || ^3.0\",\n+        \"phpoffice/phpexcel\": \"1.8.*\"","path":"composer.json","position":6,"original_position":6,"commit_id":"06f1510ad0d9e4b61d2f808df5ffebce5dc8934f","original_commit_id":"06f1510ad0d9e4b61d2f808df5ffebce5dc8934f","user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=3","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"body":"Is it better for all versions of MS Office? Anyway, changing the default xls writer would be a BC-break IMO, which mean you wouldn't be able to make the PR on this branch. I think we should make it optional in this PR, and change it later on the master branch if it turns out to be indeed better.","created_at":"2016-08-11T09:58:40Z","updated_at":"2016-08-11T09:58:40Z","html_url":"https://github.com/sonata-project/exporter/pull/128#discussion_r74395846","pull_request_url":"https://api.github.com/repos/sonata-project/exporter/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/exporter/pulls/comments/74395846"},"html":{"href":"https://github.com/sonata-project/exporter/pull/128#discussion_r74395846"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/exporter/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/exporter/pulls/128","id":80115298,"html_url":"https://github.com/sonata-project/exporter/pull/128","diff_url":"https://github.com/sonata-project/exporter/pull/128.diff","patch_url":"https://github.com/sonata-project/exporter/pull/128.patch","issue_url":"https://api.github.com/repos/sonata-project/exporter/issues/128","number":128,"state":"open","locked":false,"title":"Better support for exports to MS Excel","user":{"login":"rapemer","id":10545057,"avatar_url":"https://avatars.githubusercontent.com/u/10545057?v=3","gravatar_id":"","url":"https://api.github.com/users/rapemer","html_url":"https://github.com/rapemer","followers_url":"https://api.github.com/users/rapemer/followers","following_url":"https://api.github.com/users/rapemer/following{/other_user}","gists_url":"https://api.github.com/users/rapemer/gists{/gist_id}","starred_url":"https://api.github.com/users/rapemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapemer/subscriptions","organizations_url":"https://api.github.com/users/rapemer/orgs","repos_url":"https://api.github.com/users/rapemer/repos","events_url":"https://api.github.com/users/rapemer/events{/privacy}","received_events_url":"https://api.github.com/users/rapemer/received_events","type":"User","site_admin":false},"body":"<!-- THE PR TEMPLATE IS NOT AN OPTION. DO NOT DELETE IT! -->\r\n\r\n<!--\r\n    Show us you choose the right branch.\r\n    Different branches are used for different things :\r\n    - 1.x is for everything backwards compatible, like patches, features and deprecation notices\r\n    - master is for deprecation removals and other changes that cannot be done without a BC-break\r\n    More details here: https://github.com/sonata-project/exporter/blob/1.x/CONTRIBUTING.md#the-base-branch\r\n-->\r\nWhen you want to export XLS and open with MS Office 365 with standard XlsWriter, it fails. It is better to use library phpoffice/phpexcel to work on latest Office.\r\n\r\n<!--\r\n    Specify which issues will be fixed/closed.\r\n    Remove it if this is not related.\r\n-->\r\n\r\n## Changelog\r\n\r\n<!-- MANDATORY\r\n    Fill the changelog part inside the code block.\r\n    Follow this schema: http://keepachangelog.com/\r\n-->\r\n\r\n<!-- REMOVE EMPTY SECTIONS -->\r\n```markdown\r\n### Added\r\n- Added `XlsExcelWriter`\r\n\r\n```\r\n\r\n## To do\r\n\r\n<!--\r\n    If this is a work in progress, COMPLETE and ADD needed tasks.\r\n    You can add as many tasks as you want.\r\n    If some are not relevant, just REMOVE them.\r\n-->\r\n\r\n- [ ] Add tests\r\n- [ ] Add documentation\r\n- [ ] Fix the build\r\n","created_at":"2016-08-04T17:10:41Z","updated_at":"2016-08-11T09:58:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ef71a8fd2ae8062cee30468d78370b961147497","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/exporter/pulls/128/commits","review_comments_url":"https://api.github.com/repos/sonata-project/exporter/pulls/128/comments","review_comment_url":"https://api.github.com/repos/sonata-project/exporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/exporter/issues/128/comments","statuses_url":"https://api.github.com/repos/sonata-project/exporter/statuses/06f1510ad0d9e4b61d2f808df5ffebce5dc8934f","head":{"label":"rapemer:1.x","ref":"1.x","sha":"06f1510ad0d9e4b61d2f808df5ffebce5dc8934f","user":{"login":"rapemer","id":10545057,"avatar_url":"https://avatars.githubusercontent.com/u/10545057?v=3","gravatar_id":"","url":"https://api.github.com/users/rapemer","html_url":"https://github.com/rapemer","followers_url":"https://api.github.com/users/rapemer/followers","following_url":"https://api.github.com/users/rapemer/following{/other_user}","gists_url":"https://api.github.com/users/rapemer/gists{/gist_id}","starred_url":"https://api.github.com/users/rapemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapemer/subscriptions","organizations_url":"https://api.github.com/users/rapemer/orgs","repos_url":"https://api.github.com/users/rapemer/repos","events_url":"https://api.github.com/users/rapemer/events{/privacy}","received_events_url":"https://api.github.com/users/rapemer/received_events","type":"User","site_admin":false},"repo":{"id":64950540,"name":"exporter","full_name":"rapemer/exporter","owner":{"login":"rapemer","id":10545057,"avatar_url":"https://avatars.githubusercontent.com/u/10545057?v=3","gravatar_id":"","url":"https://api.github.com/users/rapemer","html_url":"https://github.com/rapemer","followers_url":"https://api.github.com/users/rapemer/followers","following_url":"https://api.github.com/users/rapemer/following{/other_user}","gists_url":"https://api.github.com/users/rapemer/gists{/gist_id}","starred_url":"https://api.github.com/users/rapemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapemer/subscriptions","organizations_url":"https://api.github.com/users/rapemer/orgs","repos_url":"https://api.github.com/users/rapemer/repos","events_url":"https://api.github.com/users/rapemer/events{/privacy}","received_events_url":"https://api.github.com/users/rapemer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rapemer/exporter","description":"Exporter","fork":true,"url":"https://api.github.com/repos/rapemer/exporter","forks_url":"https://api.github.com/repos/rapemer/exporter/forks","keys_url":"https://api.github.com/repos/rapemer/exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapemer/exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapemer/exporter/teams","hooks_url":"https://api.github.com/repos/rapemer/exporter/hooks","issue_events_url":"https://api.github.com/repos/rapemer/exporter/issues/events{/number}","events_url":"https://api.github.com/repos/rapemer/exporter/events","assignees_url":"https://api.github.com/repos/rapemer/exporter/assignees{/user}","branches_url":"https://api.github.com/repos/rapemer/exporter/branches{/branch}","tags_url":"https://api.github.com/repos/rapemer/exporter/tags","blobs_url":"https://api.github.com/repos/rapemer/exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapemer/exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapemer/exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapemer/exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapemer/exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/rapemer/exporter/languages","stargazers_url":"https://api.github.com/repos/rapemer/exporter/stargazers","contributors_url":"https://api.github.com/repos/rapemer/exporter/contributors","subscribers_url":"https://api.github.com/repos/rapemer/exporter/subscribers","subscription_url":"https://api.github.com/repos/rapemer/exporter/subscription","commits_url":"https://api.github.com/repos/rapemer/exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapemer/exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapemer/exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapemer/exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapemer/exporter/contents/{+path}","compare_url":"https://api.github.com/repos/rapemer/exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapemer/exporter/merges","archive_url":"https://api.github.com/repos/rapemer/exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapemer/exporter/downloads","issues_url":"https://api.github.com/repos/rapemer/exporter/issues{/number}","pulls_url":"https://api.github.com/repos/rapemer/exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/rapemer/exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/rapemer/exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapemer/exporter/labels{/name}","releases_url":"https://api.github.com/repos/rapemer/exporter/releases{/id}","deployments_url":"https://api.github.com/repos/rapemer/exporter/deployments","created_at":"2016-08-04T16:32:23Z","updated_at":"2016-08-04T16:32:24Z","pushed_at":"2016-08-11T09:45:43Z","git_url":"git://github.com/rapemer/exporter.git","ssh_url":"git@github.com:rapemer/exporter.git","clone_url":"https://github.com/rapemer/exporter.git","svn_url":"https://github.com/rapemer/exporter","homepage":"","size":280,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.x"}},"base":{"label":"sonata-project:1.x","ref":"1.x","sha":"48905105792aa2bfbea234b6a9d6a168ff8c19fd","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":3548430,"name":"exporter","full_name":"sonata-project/exporter","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/exporter","description":"Exporter","fork":false,"url":"https://api.github.com/repos/sonata-project/exporter","forks_url":"https://api.github.com/repos/sonata-project/exporter/forks","keys_url":"https://api.github.com/repos/sonata-project/exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/exporter/teams","hooks_url":"https://api.github.com/repos/sonata-project/exporter/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/exporter/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/exporter/events","assignees_url":"https://api.github.com/repos/sonata-project/exporter/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/exporter/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/exporter/tags","blobs_url":"https://api.github.com/repos/sonata-project/exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/exporter/languages","stargazers_url":"https://api.github.com/repos/sonata-project/exporter/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/exporter/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/exporter/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/exporter/subscription","commits_url":"https://api.github.com/repos/sonata-project/exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/exporter/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/exporter/merges","archive_url":"https://api.github.com/repos/sonata-project/exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/exporter/downloads","issues_url":"https://api.github.com/repos/sonata-project/exporter/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/exporter/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/exporter/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/exporter/deployments","created_at":"2012-02-25T23:26:26Z","updated_at":"2016-05-22T17:51:19Z","pushed_at":"2016-08-11T09:45:43Z","git_url":"git://github.com/sonata-project/exporter.git","ssh_url":"git@github.com:sonata-project/exporter.git","clone_url":"https://github.com/sonata-project/exporter.git","svn_url":"https://github.com/sonata-project/exporter","homepage":"","size":370,"stargazers_count":85,"watchers_count":85,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":5,"forks":41,"open_issues":5,"watchers":85,"default_branch":"1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/exporter/pulls/128"},"html":{"href":"https://github.com/sonata-project/exporter/pull/128"},"issue":{"href":"https://api.github.com/repos/sonata-project/exporter/issues/128"},"comments":{"href":"https://api.github.com/repos/sonata-project/exporter/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/exporter/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/exporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/exporter/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/exporter/statuses/06f1510ad0d9e4b61d2f808df5ffebce5dc8934f"}}}}
{"actor":{"display_login":"greg0ire"}}