{"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/56867798","id":56867798,"diff_hunk":"@@ -138,7 +138,11 @@ func transferMoney(client *testClient, numAccounts, maxTransfer int) error {\n }\n \n func retryableError(err error) bool {\n-\treturn testutils.IsError(err, \"connection reset by peer\") || testutils.IsError(err, \"connection refused\") || testutils.IsError(err, \"failed to send RPC\") || testutils.IsError(err, \"EOF\")\n+\treturn testutils.IsError(err, \"connection reset by peer\") ||\n+\t\ttestutils.IsError(err, \"connection refused\") ||\n+\t\ttestutils.IsError(err, \"failed to send RPC\") ||\n+\t\ttestutils.IsError(err, \"EOF\") ||\n+\t\ttestutils.IsError(err, \"store.+not found\")","path":"acceptance/chaos_test.go","position":9,"original_position":9,"commit_id":"1377eabd100474562cab4fb80c65901ba2496bcd","original_commit_id":"1377eabd100474562cab4fb80c65901ba2496bcd","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"body":"nit: you can write this as\r\n```go\r\nreturn testutils.IsError(err, \"(connection reset by peer|connection refused|failed to send RPC|EOF|store.+not found)\")\r\n```","created_at":"2016-03-21T18:02:42Z","updated_at":"2016-03-21T18:02:42Z","html_url":"https://github.com/cockroachdb/cockroach/pull/5440#discussion_r56867798","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/5440","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/56867798"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/5440#discussion_r56867798"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/5440"}}},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/5440","id":63605403,"html_url":"https://github.com/cockroachdb/cockroach/pull/5440","diff_url":"https://github.com/cockroachdb/cockroach/pull/5440.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/5440.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5440","number":5440,"state":"open","locked":false,"title":"acceptance: allow \"store not found\" to be a retryable error","user":{"login":"vivekmenezes","id":11774212,"avatar_url":"https://avatars.githubusercontent.com/u/11774212?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekmenezes","html_url":"https://github.com/vivekmenezes","followers_url":"https://api.github.com/users/vivekmenezes/followers","following_url":"https://api.github.com/users/vivekmenezes/following{/other_user}","gists_url":"https://api.github.com/users/vivekmenezes/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekmenezes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekmenezes/subscriptions","organizations_url":"https://api.github.com/users/vivekmenezes/orgs","repos_url":"https://api.github.com/users/vivekmenezes/repos","events_url":"https://api.github.com/users/vivekmenezes/events{/privacy}","received_events_url":"https://api.github.com/users/vivekmenezes/received_events","type":"User","site_admin":false},"body":"A cockroach node can start serving before all its stores have been\r\nbootstrapped, so when a store is not visible it would be okay to\r\nretry the request later.\r\n\r\nAnother option is to hold the request for a while until the store\r\nis available. Or not serve until all the stores have been bootstrapped\r\nproperly.\r\n\r\ncloses #5024\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/5440)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-03-21T17:54:59Z","updated_at":"2016-03-21T18:02:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c4ce74c79beee8fee846d72773a6d222e4851b9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/5440/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/5440/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5440/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/1377eabd100474562cab4fb80c65901ba2496bcd","head":{"label":"vivekmenezes:vivek/recover","ref":"vivek/recover","sha":"1377eabd100474562cab4fb80c65901ba2496bcd","user":{"login":"vivekmenezes","id":11774212,"avatar_url":"https://avatars.githubusercontent.com/u/11774212?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekmenezes","html_url":"https://github.com/vivekmenezes","followers_url":"https://api.github.com/users/vivekmenezes/followers","following_url":"https://api.github.com/users/vivekmenezes/following{/other_user}","gists_url":"https://api.github.com/users/vivekmenezes/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekmenezes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekmenezes/subscriptions","organizations_url":"https://api.github.com/users/vivekmenezes/orgs","repos_url":"https://api.github.com/users/vivekmenezes/repos","events_url":"https://api.github.com/users/vivekmenezes/events{/privacy}","received_events_url":"https://api.github.com/users/vivekmenezes/received_events","type":"User","site_admin":false},"repo":{"id":34078715,"name":"cockroach","full_name":"vivekmenezes/cockroach","owner":{"login":"vivekmenezes","id":11774212,"avatar_url":"https://avatars.githubusercontent.com/u/11774212?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekmenezes","html_url":"https://github.com/vivekmenezes","followers_url":"https://api.github.com/users/vivekmenezes/followers","following_url":"https://api.github.com/users/vivekmenezes/following{/other_user}","gists_url":"https://api.github.com/users/vivekmenezes/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekmenezes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekmenezes/subscriptions","organizations_url":"https://api.github.com/users/vivekmenezes/orgs","repos_url":"https://api.github.com/users/vivekmenezes/repos","events_url":"https://api.github.com/users/vivekmenezes/events{/privacy}","received_events_url":"https://api.github.com/users/vivekmenezes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vivekmenezes/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":true,"url":"https://api.github.com/repos/vivekmenezes/cockroach","forks_url":"https://api.github.com/repos/vivekmenezes/cockroach/forks","keys_url":"https://api.github.com/repos/vivekmenezes/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vivekmenezes/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vivekmenezes/cockroach/teams","hooks_url":"https://api.github.com/repos/vivekmenezes/cockroach/hooks","issue_events_url":"https://api.github.com/repos/vivekmenezes/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/vivekmenezes/cockroach/events","assignees_url":"https://api.github.com/repos/vivekmenezes/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/vivekmenezes/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/vivekmenezes/cockroach/tags","blobs_url":"https://api.github.com/repos/vivekmenezes/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vivekmenezes/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vivekmenezes/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/vivekmenezes/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vivekmenezes/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/vivekmenezes/cockroach/languages","stargazers_url":"https://api.github.com/repos/vivekmenezes/cockroach/stargazers","contributors_url":"https://api.github.com/repos/vivekmenezes/cockroach/contributors","subscribers_url":"https://api.github.com/repos/vivekmenezes/cockroach/subscribers","subscription_url":"https://api.github.com/repos/vivekmenezes/cockroach/subscription","commits_url":"https://api.github.com/repos/vivekmenezes/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/vivekmenezes/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/vivekmenezes/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/vivekmenezes/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/vivekmenezes/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/vivekmenezes/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vivekmenezes/cockroach/merges","archive_url":"https://api.github.com/repos/vivekmenezes/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vivekmenezes/cockroach/downloads","issues_url":"https://api.github.com/repos/vivekmenezes/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/vivekmenezes/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/vivekmenezes/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/vivekmenezes/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vivekmenezes/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/vivekmenezes/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/vivekmenezes/cockroach/deployments","created_at":"2015-04-16T20:25:11Z","updated_at":"2016-01-22T03:53:14Z","pushed_at":"2016-03-21T17:54:29Z","git_url":"git://github.com/vivekmenezes/cockroach.git","ssh_url":"git@github.com:vivekmenezes/cockroach.git","clone_url":"https://github.com/vivekmenezes/cockroach.git","svn_url":"https://github.com/vivekmenezes/cockroach","homepage":null,"size":94542,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"a8a92a91547bacc676f57cd392065e77ecaddd8e","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2016-03-21T15:48:10Z","pushed_at":"2016-03-21T17:55:05Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"http://www.cockroachlabs.com","size":118708,"stargazers_count":6406,"watchers_count":6406,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":600,"mirror_url":null,"open_issues_count":330,"forks":600,"open_issues":330,"watchers":6406,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/5440"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/5440"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/5440"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/5440/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/5440/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/5440/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/1377eabd100474562cab4fb80c65901ba2496bcd"}}}}