{"action":"opened","number":613,"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/613","id":59425917,"html_url":"https://github.com/sonata-project/SonataPageBundle/pull/613","diff_url":"https://github.com/sonata-project/SonataPageBundle/pull/613.diff","patch_url":"https://github.com/sonata-project/SonataPageBundle/pull/613.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/613","number":613,"state":"open","locked":false,"title":"Fix fetching orphaned containers in composer view","user":{"login":"StrikeForceZero","id":983413,"avatar_url":"https://avatars.githubusercontent.com/u/983413?v=3","gravatar_id":"","url":"https://api.github.com/users/StrikeForceZero","html_url":"https://github.com/StrikeForceZero","followers_url":"https://api.github.com/users/StrikeForceZero/followers","following_url":"https://api.github.com/users/StrikeForceZero/following{/other_user}","gists_url":"https://api.github.com/users/StrikeForceZero/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeForceZero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeForceZero/subscriptions","organizations_url":"https://api.github.com/users/StrikeForceZero/orgs","repos_url":"https://api.github.com/users/StrikeForceZero/repos","events_url":"https://api.github.com/users/StrikeForceZero/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeForceZero/received_events","type":"User","site_admin":false},"body":"##### Orphaned containers were failing to render. \r\n\r\n---\r\n\r\nThe ajax call silently failed because it was attempting to get the href attribute on the `li` element for the container list. It would inject the current composer view into the right hand view effectively creating the \"window in a window effect\".\r\n\r\n- moved class and data attributes into anchor tag,\r\n- expanded anchor tag using `display:block` to fill the width of the li parent element\r\n- compiled sass into css\r\n\r\nThe `PageAdminController` was failing to render the orphaned container as it was attempting to get the container from the current template (which doesn't exist, thus passing an empty array and throwing an undefined index error). \r\n\r\n- added simple check to prevent error in PageAdminController\r\n\r\n---\r\n\r\nI'm not entirely sure of the side effects for not running:\r\n\r\n```php\r\nforeach ($blockServices as $code => $service) {\r\n   if (in_array($code, $container['blocks'])) {\r\n       continue;\r\n   }\r\n\r\n   unset($blockServices[$code]);\r\n}\r\n```\r\n\r\nbut now the user can view and edit orphaned blocks","created_at":"2016-02-15T23:36:49Z","updated_at":"2016-02-15T23:36:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/613/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/613/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/613/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/statuses/9aab06ae330d573308440c6e1ab09c51a6627df2","head":{"label":"StrikeForceZero:fix-composer-orphan-containers","ref":"fix-composer-orphan-containers","sha":"9aab06ae330d573308440c6e1ab09c51a6627df2","user":{"login":"StrikeForceZero","id":983413,"avatar_url":"https://avatars.githubusercontent.com/u/983413?v=3","gravatar_id":"","url":"https://api.github.com/users/StrikeForceZero","html_url":"https://github.com/StrikeForceZero","followers_url":"https://api.github.com/users/StrikeForceZero/followers","following_url":"https://api.github.com/users/StrikeForceZero/following{/other_user}","gists_url":"https://api.github.com/users/StrikeForceZero/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeForceZero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeForceZero/subscriptions","organizations_url":"https://api.github.com/users/StrikeForceZero/orgs","repos_url":"https://api.github.com/users/StrikeForceZero/repos","events_url":"https://api.github.com/users/StrikeForceZero/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeForceZero/received_events","type":"User","site_admin":false},"repo":{"id":50299524,"name":"SonataPageBundle","full_name":"StrikeForceZero/SonataPageBundle","owner":{"login":"StrikeForceZero","id":983413,"avatar_url":"https://avatars.githubusercontent.com/u/983413?v=3","gravatar_id":"","url":"https://api.github.com/users/StrikeForceZero","html_url":"https://github.com/StrikeForceZero","followers_url":"https://api.github.com/users/StrikeForceZero/followers","following_url":"https://api.github.com/users/StrikeForceZero/following{/other_user}","gists_url":"https://api.github.com/users/StrikeForceZero/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeForceZero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeForceZero/subscriptions","organizations_url":"https://api.github.com/users/StrikeForceZero/orgs","repos_url":"https://api.github.com/users/StrikeForceZero/repos","events_url":"https://api.github.com/users/StrikeForceZero/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeForceZero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/StrikeForceZero/SonataPageBundle","description":"A Layout manager on top of Symfony2","fork":true,"url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle","forks_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/forks","keys_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/teams","hooks_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/hooks","issue_events_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/issues/events{/number}","events_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/events","assignees_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/assignees{/user}","branches_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/branches{/branch}","tags_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/tags","blobs_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/languages","stargazers_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/stargazers","contributors_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/contributors","subscribers_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/subscribers","subscription_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/subscription","commits_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/contents/{+path}","compare_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/merges","archive_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/downloads","issues_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/issues{/number}","pulls_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/labels{/name}","releases_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/releases{/id}","deployments_url":"https://api.github.com/repos/StrikeForceZero/SonataPageBundle/deployments","created_at":"2016-01-24T17:46:19Z","updated_at":"2016-01-24T17:46:21Z","pushed_at":"2016-02-15T23:35:23Z","git_url":"git://github.com/StrikeForceZero/SonataPageBundle.git","ssh_url":"git@github.com:StrikeForceZero/SonataPageBundle.git","clone_url":"https://github.com/StrikeForceZero/SonataPageBundle.git","svn_url":"https://github.com/StrikeForceZero/SonataPageBundle","homepage":"http://sonata-project.org/bundles/page","size":3622,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sonata-project:master","ref":"master","sha":"506f7f9ffcaab5e8f1331221a91ebff18b5af8d6","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1141608,"name":"SonataPageBundle","full_name":"sonata-project/SonataPageBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataPageBundle","description":"A Layout manager on top of Symfony2","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataPageBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/deployments","created_at":"2010-12-06T00:18:21Z","updated_at":"2016-01-25T04:01:07Z","pushed_at":"2016-02-15T23:36:49Z","git_url":"git://github.com/sonata-project/SonataPageBundle.git","ssh_url":"git@github.com:sonata-project/SonataPageBundle.git","clone_url":"https://github.com/sonata-project/SonataPageBundle.git","svn_url":"https://github.com/sonata-project/SonataPageBundle","homepage":"http://sonata-project.org/bundles/page","size":4095,"stargazers_count":134,"watchers_count":134,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":143,"mirror_url":null,"open_issues_count":66,"forks":143,"open_issues":66,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/613"},"html":{"href":"https://github.com/sonata-project/SonataPageBundle/pull/613"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/613"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/613/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/613/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/613/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/statuses/9aab06ae330d573308440c6e1ab09c51a6627df2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":11,"deletions":10,"changed_files":5}}