{"push_id":1284527530,"size":53,"distinct_size":53,"ref":"refs/heads/master","head":"f4c98079ff57dbd552d91594cfe51259caf6bb60","before":"a8d03c9db4844657219fbc87531656dd22a510e9","commits":[{"sha":"bc6baf261bde0eee9a24bfdce79bb13250ef1748","author":{"name":"Chris Hopman","email":"b4caa24f9de55f461e4c51db2576ccfc3b9fb18e@fb.com"},"message":"Make it easier to configure different ndk paths\n\nSummary:\nEvery ndk update, dealing with figuring out all\nthe paths calculated in NdkCxxPlatforms that are now wrong and fixing\nthem has been a huge pain (the process was like: do a build/test, see a\nfailure, look into compiler flags and try to figure out which really\nlong path was wrong, find that in NdkCxxPlatforms, add ugly/hard to\nfollow conditional path resolution). This change moves most of the\npaths to be calculated off of a pattern like:\n    \"lib/{compiler_type}/{toolchain_target}/{compiler_version}\"\nAnd we assert that the resulting path actually exists. This makes it\nmuch easier to figure out which path calculations are wrong and to\neasily understand what paths are used with different ndk/compiler/etc\ncombinations and easily add a new such.\n\nThe paths are all calculated the same as before.\n\nTest Plan: run tests\n\nReviewed By: marcinkosiba\n\nfbshipit-source-id: 1e3db6f","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/bc6baf261bde0eee9a24bfdce79bb13250ef1748"},{"sha":"353daa2386fbac3d1e1051de09b1dc46284ce2ca","author":{"name":"Chris Hopman","email":"b4caa24f9de55f461e4c51db2576ccfc3b9fb18e@fb.com"},"message":"Make buck work with ndk r11 and r12\n\nSummary: Fix some toolchain paths calculations for Android's ndk r11 and r12.\n\nTest Plan:\nrun tests forcing it to use each of ndk r10, r11, and r12\n(easiest to do this by installing all of them and manipulating the\nversion files) on both linux + mac. Existing tests should catch any\nactual problems (particularly with the added path existence asserts).\n\nReviewed By: marcinkosiba\n\nfbshipit-source-id: bb0fe60","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/353daa2386fbac3d1e1051de09b1dc46284ce2ca"},{"sha":"47b0edd577904040243667412f1425aefc196cb7","author":{"name":"Yiding Jia","email":"84f92ac2001280e49f0ef1c97df3427725b4be4c@fb.com"},"message":"use cached rulekey for build events instead of recomputing\n\nSummary:\nIt seems like this buck event log code was recomputing the rule key\nfor every rule that passes through it instead of leveraging the cache\nin RuleKeyBuilderFactory and co.\n\nFixing this seems to improve clean-build speed by a little. It should\nbe noted that the results should be profiled with yourkit probes turned\noff, otherwise, they show a dramatic improvement.\n\nTest Plan:\nCI\n\nRun a build such that everything is build, rerun the build to get the clean build time.\n\nReviewed By: k21\n\nfbshipit-source-id: a738667","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/47b0edd577904040243667412f1425aefc196cb7"},{"sha":"7884f803756334da158ab7812588ea6cf3fa0898","author":{"name":"Ben Hamilton","email":"a30509bcba2b9894f05d2af0619d1e7675702ad1@fb.com"},"message":"Easy: Handle debug and info diagnostics from buck.py\n\nSummary:\nThis updates `buck.py` handling of `Diagnostics` calls\nto support `debug` and `info` levels.\n\nTest Plan:\nAdded `debug` and `info` diagnostics to `buck.py`,\nconfirmed they showed up in logs.\n\nReviewed By: andrewjcg\n\nfbshipit-source-id: 6d4a993","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/7884f803756334da158ab7812588ea6cf3fa0898"},{"sha":"c6cd84fb22ce7b6000fa40171702932f9028e450","author":{"name":"Ben Hamilton","email":"a30509bcba2b9894f05d2af0619d1e7675702ad1@fb.com"},"message":"Ensure Python glob() ignores directories starting with dot\n\nSummary:\nThe non-Watchman Python `glob()` implementation had a nasty bug:\neven if `include_dotfiles` was `False`, it would include files under\ndirectories whose names started with a dot.\n\nThis fixes the bug and adds tests.\n\nTest Plan: `buck test //src/com/facebook/buck/json:buck_test`\n\nReviewed By: andrewjcg\n\nfbshipit-source-id: 79ccaec","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/c6cd84fb22ce7b6000fa40171702932f9028e450"},{"sha":"8f92c86ddc77bfac25629b3772332b0728892e31","author":{"name":"Mark Wang","email":"ef7450a1f0ef1dd83819119188f9feef0990e9ee@fb.com"},"message":"Support manually specified ObjC bridging headers in Swift or mixed targets\n\nSummary:\nA bridging header is needed for Swift code to reference ObjC.  Add optional parameter to specify a manually-generated one.\n\nAutomatic bridging header generation will come in the future.\n\nTest Plan: CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: 77593e7","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/8f92c86ddc77bfac25629b3772332b0728892e31"},{"sha":"ae8b78721965eed8e7b0ad2c24ca5713b196867b","author":{"name":"Vladislav Alexeev","email":"caa47d39ae0ab3ce159d5ed47ba1172beb4c76b1@fb.com"},"message":"ListeningMultiSemaphore class to handle multiple resource allocation\n\nSummary: `ListeningMultiSemaphore` that is similar to `ListeningSemaphore` but accepts arbitrary resource types (represented and identified by `String`) and their maximum values via constructor.\n\nTest Plan: added test, CI\n\nReviewed By: Coneko\n\nfbshipit-source-id: 4420222","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/ae8b78721965eed8e7b0ad2c24ca5713b196867b"},{"sha":"17a50db92b59adf72c98bf6590764faf1da0a5cc","author":{"name":"Michael Lee","email":"368cb0e36d33ec70b463d07ce7b4ce52ad72699d@fb.com"},"message":"Switch type propagation to ImmutableList\n\nSummary: Also bserDeserialize can return a Null value, so annotate\n\nTest Plan: Type checkers\n\nReviewed By: marcinkosiba\n\nfbshipit-source-id: c9426a0","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/17a50db92b59adf72c98bf6590764faf1da0a5cc"},{"sha":"098c68d5da61f384eff7e0a5c79421312de1a73f","author":{"name":"Kellie Medlin","email":"8ef0cbf86318d8526251bdcfea047e18146a9d99@fb.com"},"message":"Allow nonexistant cell roots\n\nSummary:\nCross-platform Buck projects can vary wildly to the point of one platform\nrelying on the targets of a cellroot that another platform doesn't.  Instead of\nthrowing errors when parsing BUCK files on platforms where this cell root doesn't\nexist, let it succeed -- if the build really needs the cell root, it'll fail\nwhen accessing targets in that root.\n\nTest Plan:\nSuccessfully run 'buck project' on MacOSX for a project with a Linux-only\ncell root dependency.\n\nReviewed By: Coneko, mzlee\n\nfbshipit-source-id: 9171261","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/098c68d5da61f384eff7e0a5c79421312de1a73f"},{"sha":"82c47dbe8fd16dcce5e5f0cfc6f1f89b9b53dfa5","author":{"name":"Rui Barbosa Martins","email":"e0b976060a5bff07520a2ebeca31a68033eab2bd@fb.com"},"message":"Deleting unused/commented out method from interface ArtifactCache.\n\nSummary: Deleting unused/commented out method from interface ArtifactCache.\n\nTest Plan:\nci\nbuck test\n\nReviewed By: Coneko\n\nfbshipit-source-id: c0755b5","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/82c47dbe8fd16dcce5e5f0cfc6f1f89b9b53dfa5"},{"sha":"24553fd36c0a0ec36e61e5c9d3c128a573971068","author":{"name":"Uri Baghin","email":"a7e0cbdeeaa953dab447fa0b124a7e7c5f04aab4@fb.com"},"message":"Add quickstart command back.\n\nSummary: Docs intentionally missing since we're going to remove it again in a bit.\n\nTest Plan: CI\n\nReviewed By: aiked\n\nfbshipit-source-id: 8b79ecb","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/24553fd36c0a0ec36e61e5c9d3c128a573971068"},{"sha":"7b8bfd3c34cab99ad3cdc0de4bceb5bc07230ddc","author":{"name":"Andrew Gallagher","email":"f616904cf2b567dfa8d25d3c500af62b3183c5e1@fb.com"},"message":"haskell: include libraries in generated packages\n\nSummary:\nPreviously, package created by library rules only included interface\nfiles and omitted the libraries.  Since we used the `NativeLinkable`\ninterface to pass libraries directly to the linker, this allowed some\nminor dedup'ing of compilations for static-pic and shared build types.\nHowever, for template haskell to work, GHC needs to find the libraries\nof dependencies via the package DBs.\n\nTest Plan: CI\n\nReviewed By: JonCoens\n\nfbshipit-source-id: 322e418","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/7b8bfd3c34cab99ad3cdc0de4bceb5bc07230ddc"},{"sha":"38cfbfced90d9ad5d09d0ccc8dae2599db934170","author":{"name":"Andrew Gallagher","email":"f616904cf2b567dfa8d25d3c500af62b3183c5e1@fb.com"},"message":"haskell: make `prebuilt_haskell_library()` wrap prebuilt packages\n\nSummary:\nPreviously, the `prebuilt_haskell_library()` rule just wrapper raw\ninterface files and libraries.  This diff updates it to accept a\nproper prebuilt package.\n\nTest Plan: updated tests\n\nReviewed By: JonCoens\n\nfbshipit-source-id: 635e784","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/38cfbfced90d9ad5d09d0ccc8dae2599db934170"},{"sha":"75008a21fb5a82246b1e1964f14afd9ff7e601b9","author":{"name":"Michael Lee","email":"368cb0e36d33ec70b463d07ce7b4ce52ad72699d@fb.com"},"message":"Add a bser.load to compliment bser.loads\n\nSummary: Let pybser deserialize from a file-like object.\n\nTest Plan: Should probably get some unit tests, but right now trying to integrate with the buck to buck.py communication.\n\nReviewed By: bhamiltoncx\n\nfbshipit-source-id: fd549d0","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/75008a21fb5a82246b1e1964f14afd9ff7e601b9"},{"sha":"1dc4d2d24ad78eb2ffdbb105813c1aab4dd97546","author":{"name":"Michael Lee","email":"368cb0e36d33ec70b463d07ce7b4ce52ad72699d@fb.com"},"message":"Fix Serializer corner case\n\nSummary:\nIf BserSerializer.serializeToBuffer is given a byte buffer\ntoo small to handle the initial EMPTY_HEADER length, then Java will\nthrow a BufferOverflowException.\n\nTest Plan: Pass in a small ByteBuffer and don't get an exception.\n\nReviewed By: bhamiltoncx\n\nfbshipit-source-id: 6a0848b","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/1dc4d2d24ad78eb2ffdbb105813c1aab4dd97546"},{"sha":"fc43076ab0793c6a5dc16faa2cc4464ee438a9f1","author":{"name":"Michael Lee","email":"368cb0e36d33ec70b463d07ce7b4ce52ad72699d@fb.com"},"message":"Use bser to communicate between Buck and buck.py\n\nSummary: To handle cross-cell, we no longer have a single watch root and project prefix. This means we will need to communicate more than a single line at a time. Switch to bser to communicate from buck to buck.py (we already use it to communicate from buck.py back to buck).\n\nTest Plan: Ensure tests still pass.\n\nReviewed By: bhamiltoncx\n\nfbshipit-source-id: 154a788","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/fc43076ab0793c6a5dc16faa2cc4464ee438a9f1"},{"sha":"339e4fa57c7e51ad78b96ee338d8ea17e6582eb5","author":{"name":"Vladislav Alexeev","email":"caa47d39ae0ab3ce159d5ed47ba1172beb4c76b1@fb.com"},"message":"Switch ListeningMultiSemaphore to work with helper class ResourceAmounts instead of Map of resource->amount.\n\nSummary: After offline discussion about how we should represent amount of resources that job requires, we decided to have a helper class with explicit fields for each resource type.\n\nTest Plan: CI, updated tests\n\nReviewed By: Coneko\n\nfbshipit-source-id: 8f97d41","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/339e4fa57c7e51ad78b96ee338d8ea17e6582eb5"},{"sha":"4a89304f3d4c7afcec40050fae70e1dc896a9a08","author":{"name":"Omer Strulovich","email":"d76bca79c7354363141803d1b2a694c9a759479b@fb.com"},"message":"Do not aggregated targets with different Java source level in buck project\n\nSummary: This it the frist step in order to let targets for tools that use the JVM and are not Android avoid the aggregation so that they can be their own IntelliJ modules, and therefore have their own SDK and JDK set.\n\nTest Plan:\nUnit tests\n\n1. Run buck project for Facebook App and Editus\n2. See in Project Structure that Editus is separated.\n\nReviewed By: marcinkosiba\n\nfbshipit-source-id: 4229467","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/4a89304f3d4c7afcec40050fae70e1dc896a9a08"},{"sha":"caae9a24a34c536d6a050b68f3d0ff9f0204a77f","author":{"name":"Andrew Gallagher","email":"f616904cf2b567dfa8d25d3c500af62b3183c5e1@fb.com"},"message":"cxx: add custom prebuilt C/C++ library rule\n\nSummary:\nCurrently, the only way to model prebuilt C/C++ libraries is via the\n`prebuilt_cxx_library` rule.  However, since this enforces a 1:1\nrule to library mapping, it can make modeling groups of libraries\ndifficult in some situations (e.g. if the libraries contain cyclical\nreferences).\n\nThis diff adds a new `prebuilt_cxx_library_group` rule, which allows\nwrapping multiple libraries/flags into a single rule.  For each link\ntype (i.e. static, static-pic, and shared), the user can specify the\nexact args used link the library group using special macros to fill\nin the libraries.\n\nTest Plan: added tests\n\nReviewed By: Coneko\n\nfbshipit-source-id: 116cee2","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/caae9a24a34c536d6a050b68f3d0ff9f0204a77f"},{"sha":"17e0e7094562ac71c5441dd56cce4e636e90da36","author":{"name":"Michael Lee","email":"368cb0e36d33ec70b463d07ce7b4ce52ad72699d@fb.com"},"message":"Stop accepting a static watch_root and project_prefix\n\nSummary: Use the watchRoot and projectPrefix sent via buck\n\nTest Plan: Fix up tests\n\nReviewed By: marcinkosiba\n\nfbshipit-source-id: 00a9366","distinct":true,"url":"https://api.github.com/repos/shs96c/buck/commits/17e0e7094562ac71c5441dd56cce4e636e90da36"}]}
{"actor":{"display_login":"shs96c"}}