{"action":"created","comment":{"url":"https://api.github.com/repos/hypothesis/h/pulls/comments/87413004","pull_request_review_id":8026623,"id":87413004,"diff_hunk":"@@ -2,6 +2,33 @@\n \n {% from '../includes/annotation_card.html.jinja2' import annotation_card %}\n \n+{% macro search_result_nav(group_name) %}\n+<nav class=\"search-result-nav\">\n+  {%- if more_info %}\n+    <form method=\"POST\"> {# This <form> is needed for IE because it doesn't","path":"h/templates/activity/search.html.jinja2","position":7,"original_position":7,"commit_id":"8d00243768ca0688591a7f1d5ba6946857ef6241","original_commit_id":"8d00243768ca0688591a7f1d5ba6946857ef6241","user":{"login":"seanh","id":22498,"avatar_url":"https://avatars.githubusercontent.com/u/22498?v=3","gravatar_id":"","url":"https://api.github.com/users/seanh","html_url":"https://github.com/seanh","followers_url":"https://api.github.com/users/seanh/followers","following_url":"https://api.github.com/users/seanh/following{/other_user}","gists_url":"https://api.github.com/users/seanh/gists{/gist_id}","starred_url":"https://api.github.com/users/seanh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanh/subscriptions","organizations_url":"https://api.github.com/users/seanh/orgs","repos_url":"https://api.github.com/users/seanh/repos","events_url":"https://api.github.com/users/seanh/events{/privacy}","received_events_url":"https://api.github.com/users/seanh/received_events","type":"User","site_admin":false},"body":"Hmm, yeah","created_at":"2016-11-10T15:11:16Z","updated_at":"2016-11-10T15:11:16Z","html_url":"https://github.com/hypothesis/h/pull/4025#discussion_r87413004","pull_request_url":"https://api.github.com/repos/hypothesis/h/pulls/4025","_links":{"self":{"href":"https://api.github.com/repos/hypothesis/h/pulls/comments/87413004"},"html":{"href":"https://github.com/hypothesis/h/pull/4025#discussion_r87413004"},"pull_request":{"href":"https://api.github.com/repos/hypothesis/h/pulls/4025"}}},"pull_request":{"url":"https://api.github.com/repos/hypothesis/h/pulls/4025","id":92388411,"html_url":"https://github.com/hypothesis/h/pull/4025","diff_url":"https://github.com/hypothesis/h/pull/4025.diff","patch_url":"https://github.com/hypothesis/h/pull/4025.patch","issue_url":"https://api.github.com/repos/hypothesis/h/issues/4025","number":4025,"state":"open","locked":false,"title":"Add responsive layout to the group search page sidebar","user":{"login":"seanh","id":22498,"avatar_url":"https://avatars.githubusercontent.com/u/22498?v=3","gravatar_id":"","url":"https://api.github.com/users/seanh","html_url":"https://github.com/seanh","followers_url":"https://api.github.com/users/seanh/followers","following_url":"https://api.github.com/users/seanh/following{/other_user}","gists_url":"https://api.github.com/users/seanh/gists{/gist_id}","starred_url":"https://api.github.com/users/seanh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanh/subscriptions","organizations_url":"https://api.github.com/users/seanh/orgs","repos_url":"https://api.github.com/users/seanh/repos","events_url":"https://api.github.com/users/seanh/events{/privacy}","received_events_url":"https://api.github.com/users/seanh/received_events","type":"User","site_admin":false},"body":"<del>This is marked as WIP because it requires https://github.com/hypothesis/h/pull/4021 to be merged first and then will need a rebase.</del> (Done)\r\n\r\nThis adds responsive layout to the sidebar on the group search page. This is an MVP of this responsive layout, when you click on the \"More info\" button to open the sidebar it does a full page load and it does not show any animated \"slide in\" of the sidebar. It can be enhanced with JavaScript later (and this no-js behaviour kept for when js is not available), but I propose that this no-js version gets us 99% and is probably fine to ship with activity pages v1.\r\n\r\nThe way it works is:\r\n\r\n* A CSS media query means that when the screen is too small to show both the search results and the sidebar together then only the search results are shown and the sidebar is `display: none;`\r\n\r\n* Another media query means that on such small screens an additional `<nav>` containing the group name and a \"More info\" button is shown above the search results, instead of the sidebar\r\n\r\n* Clicking on the \"More info\" button does a full page reload and adds an `&more_info` param to the URL. This param causes the server to render a version of the page that, if the screen is too small to show both the search results and the sidebar together, shows only the sidebar rather than only the search results (this is just a case of toggling a CSS class on/off using a Jinja2 `{% if %}`). It also replaces the \"More info\" button with a \"Back\" button.\r\n\r\n* The \"Back\" button also does a full page reload and just removes the `&more_info` param so you get the first version of the page again.\r\n\r\n### Mockup\r\n\r\nNote that this mockup also contains a bunch of other new components that are not part of this PR:\r\n\r\n![30c697e2-9d3b-11e6-9193-c8995babfebf](https://cloud.githubusercontent.com/assets/22498/20016112/17e8d2c8-a2b6-11e6-968f-52401e89e99a.png)\r\n\r\n### Screenshots\r\n\r\n#### Phone\r\n\r\n![screenshot from 2016-11-04 17-45-31](https://cloud.githubusercontent.com/assets/22498/20016319/db7e76a2-a2b6-11e6-8c83-4608f8d984a6.png)\r\n\r\n![screenshot from 2016-11-04 17-46-00](https://cloud.githubusercontent.com/assets/22498/20016326/e1a6e60e-a2b6-11e6-93c0-ebbbccca37f5.png)\r\n\r\n#### Tablet\r\n\r\n![screenshot from 2016-11-04 17-46-33](https://cloud.githubusercontent.com/assets/22498/20016347/f3a1a0b0-a2b6-11e6-8202-31e0fec67e4b.png)\r\n\r\n![screenshot from 2016-11-04 17-46-49](https://cloud.githubusercontent.com/assets/22498/20016351/f8c18d4e-a2b6-11e6-8aec-cb6ec7985fab.png)\r\n\r\n#### Desktop\r\n\r\nWhen the screen is large enough the sidebar appears on the side as normal:\r\n\r\n![screenshot from 2016-11-04 17-47-27](https://cloud.githubusercontent.com/assets/22498/20016361/0ffd4322-a2b7-11e6-87b7-65a0e3705e94.png)\r\n\r\n### Transition\r\n\r\nGIF of the transition to and from the \"More info\" page on my dev machine (we'll see how fast this is on production):\r\n\r\n![peek 2016-11-04 15-44](https://cloud.githubusercontent.com/assets/22498/20016382/29143b4a-a2b7-11e6-8857-3c93366b0686.gif)\r\n\r\n### Resizing the window\r\n\r\nWhether you're on the search results or the sidebar version of the page, if you make the window bigger you will get the search results and the sidebar. This is relevant not only to people who resize windows (or maximize or fullscreen) but to bookmarking and then opening a bookmark, opening from browser history, sharing a link with someone else, using various OS and browser features to share tabs between phone and desktop, etc. There are many ways in which the `&more_info` version of the URL may get opened on a larger screen.\r\n\r\n![peek 2016-11-04 17-38](https://cloud.githubusercontent.com/assets/22498/20016463/769f8e3c-a2b7-11e6-90b0-64b3339853f7.gif)\r\n\r\n### Known issues\r\n\r\n* In Internet Explorer, any search query is lost when you click on the \"More info\" or \"Back\" button. This does not happen in other browsers. I don't think it can be fixed in IE except by using JavaScript.","created_at":"2016-11-04T18:03:02Z","updated_at":"2016-11-10T15:11:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4dcb5ea358c650aac36ea8b2a14d01136f8726a1","assignee":{"login":"robertknight","id":2458,"avatar_url":"https://avatars.githubusercontent.com/u/2458?v=3","gravatar_id":"","url":"https://api.github.com/users/robertknight","html_url":"https://github.com/robertknight","followers_url":"https://api.github.com/users/robertknight/followers","following_url":"https://api.github.com/users/robertknight/following{/other_user}","gists_url":"https://api.github.com/users/robertknight/gists{/gist_id}","starred_url":"https://api.github.com/users/robertknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertknight/subscriptions","organizations_url":"https://api.github.com/users/robertknight/orgs","repos_url":"https://api.github.com/users/robertknight/repos","events_url":"https://api.github.com/users/robertknight/events{/privacy}","received_events_url":"https://api.github.com/users/robertknight/received_events","type":"User","site_admin":false},"assignees":[{"login":"robertknight","id":2458,"avatar_url":"https://avatars.githubusercontent.com/u/2458?v=3","gravatar_id":"","url":"https://api.github.com/users/robertknight","html_url":"https://github.com/robertknight","followers_url":"https://api.github.com/users/robertknight/followers","following_url":"https://api.github.com/users/robertknight/following{/other_user}","gists_url":"https://api.github.com/users/robertknight/gists{/gist_id}","starred_url":"https://api.github.com/users/robertknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertknight/subscriptions","organizations_url":"https://api.github.com/users/robertknight/orgs","repos_url":"https://api.github.com/users/robertknight/repos","events_url":"https://api.github.com/users/robertknight/events{/privacy}","received_events_url":"https://api.github.com/users/robertknight/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hypothesis/h/pulls/4025/commits","review_comments_url":"https://api.github.com/repos/hypothesis/h/pulls/4025/comments","review_comment_url":"https://api.github.com/repos/hypothesis/h/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hypothesis/h/issues/4025/comments","statuses_url":"https://api.github.com/repos/hypothesis/h/statuses/8d00243768ca0688591a7f1d5ba6946857ef6241","head":{"label":"hypothesis:group-search-page-sidebar-responsive-layout","ref":"group-search-page-sidebar-responsive-layout","sha":"8d00243768ca0688591a7f1d5ba6946857ef6241","user":{"login":"hypothesis","id":1243215,"avatar_url":"https://avatars.githubusercontent.com/u/1243215?v=3","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"repo":{"id":3910945,"name":"h","full_name":"hypothesis/h","owner":{"login":"hypothesis","id":1243215,"avatar_url":"https://avatars.githubusercontent.com/u/1243215?v=3","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hypothesis/h","description":"Annotate with anyone, anywhere.","fork":false,"url":"https://api.github.com/repos/hypothesis/h","forks_url":"https://api.github.com/repos/hypothesis/h/forks","keys_url":"https://api.github.com/repos/hypothesis/h/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hypothesis/h/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hypothesis/h/teams","hooks_url":"https://api.github.com/repos/hypothesis/h/hooks","issue_events_url":"https://api.github.com/repos/hypothesis/h/issues/events{/number}","events_url":"https://api.github.com/repos/hypothesis/h/events","assignees_url":"https://api.github.com/repos/hypothesis/h/assignees{/user}","branches_url":"https://api.github.com/repos/hypothesis/h/branches{/branch}","tags_url":"https://api.github.com/repos/hypothesis/h/tags","blobs_url":"https://api.github.com/repos/hypothesis/h/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hypothesis/h/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hypothesis/h/git/refs{/sha}","trees_url":"https://api.github.com/repos/hypothesis/h/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hypothesis/h/statuses/{sha}","languages_url":"https://api.github.com/repos/hypothesis/h/languages","stargazers_url":"https://api.github.com/repos/hypothesis/h/stargazers","contributors_url":"https://api.github.com/repos/hypothesis/h/contributors","subscribers_url":"https://api.github.com/repos/hypothesis/h/subscribers","subscription_url":"https://api.github.com/repos/hypothesis/h/subscription","commits_url":"https://api.github.com/repos/hypothesis/h/commits{/sha}","git_commits_url":"https://api.github.com/repos/hypothesis/h/git/commits{/sha}","comments_url":"https://api.github.com/repos/hypothesis/h/comments{/number}","issue_comment_url":"https://api.github.com/repos/hypothesis/h/issues/comments{/number}","contents_url":"https://api.github.com/repos/hypothesis/h/contents/{+path}","compare_url":"https://api.github.com/repos/hypothesis/h/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hypothesis/h/merges","archive_url":"https://api.github.com/repos/hypothesis/h/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hypothesis/h/downloads","issues_url":"https://api.github.com/repos/hypothesis/h/issues{/number}","pulls_url":"https://api.github.com/repos/hypothesis/h/pulls{/number}","milestones_url":"https://api.github.com/repos/hypothesis/h/milestones{/number}","notifications_url":"https://api.github.com/repos/hypothesis/h/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hypothesis/h/labels{/name}","releases_url":"https://api.github.com/repos/hypothesis/h/releases{/id}","deployments_url":"https://api.github.com/repos/hypothesis/h/deployments","created_at":"2012-04-02T19:56:59Z","updated_at":"2016-11-09T20:27:40Z","pushed_at":"2016-11-10T14:56:36Z","git_url":"git://github.com/hypothesis/h.git","ssh_url":"git@github.com:hypothesis/h.git","clone_url":"https://github.com/hypothesis/h.git","svn_url":"https://github.com/hypothesis/h","homepage":"https://hypothes.is/","size":31883,"stargazers_count":737,"watchers_count":737,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":160,"mirror_url":null,"open_issues_count":92,"forks":160,"open_issues":92,"watchers":737,"default_branch":"master"}},"base":{"label":"hypothesis:master","ref":"master","sha":"d5fd70c7bb569882a344419c932e2364adb01b14","user":{"login":"hypothesis","id":1243215,"avatar_url":"https://avatars.githubusercontent.com/u/1243215?v=3","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"repo":{"id":3910945,"name":"h","full_name":"hypothesis/h","owner":{"login":"hypothesis","id":1243215,"avatar_url":"https://avatars.githubusercontent.com/u/1243215?v=3","gravatar_id":"","url":"https://api.github.com/users/hypothesis","html_url":"https://github.com/hypothesis","followers_url":"https://api.github.com/users/hypothesis/followers","following_url":"https://api.github.com/users/hypothesis/following{/other_user}","gists_url":"https://api.github.com/users/hypothesis/gists{/gist_id}","starred_url":"https://api.github.com/users/hypothesis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypothesis/subscriptions","organizations_url":"https://api.github.com/users/hypothesis/orgs","repos_url":"https://api.github.com/users/hypothesis/repos","events_url":"https://api.github.com/users/hypothesis/events{/privacy}","received_events_url":"https://api.github.com/users/hypothesis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hypothesis/h","description":"Annotate with anyone, anywhere.","fork":false,"url":"https://api.github.com/repos/hypothesis/h","forks_url":"https://api.github.com/repos/hypothesis/h/forks","keys_url":"https://api.github.com/repos/hypothesis/h/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hypothesis/h/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hypothesis/h/teams","hooks_url":"https://api.github.com/repos/hypothesis/h/hooks","issue_events_url":"https://api.github.com/repos/hypothesis/h/issues/events{/number}","events_url":"https://api.github.com/repos/hypothesis/h/events","assignees_url":"https://api.github.com/repos/hypothesis/h/assignees{/user}","branches_url":"https://api.github.com/repos/hypothesis/h/branches{/branch}","tags_url":"https://api.github.com/repos/hypothesis/h/tags","blobs_url":"https://api.github.com/repos/hypothesis/h/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hypothesis/h/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hypothesis/h/git/refs{/sha}","trees_url":"https://api.github.com/repos/hypothesis/h/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hypothesis/h/statuses/{sha}","languages_url":"https://api.github.com/repos/hypothesis/h/languages","stargazers_url":"https://api.github.com/repos/hypothesis/h/stargazers","contributors_url":"https://api.github.com/repos/hypothesis/h/contributors","subscribers_url":"https://api.github.com/repos/hypothesis/h/subscribers","subscription_url":"https://api.github.com/repos/hypothesis/h/subscription","commits_url":"https://api.github.com/repos/hypothesis/h/commits{/sha}","git_commits_url":"https://api.github.com/repos/hypothesis/h/git/commits{/sha}","comments_url":"https://api.github.com/repos/hypothesis/h/comments{/number}","issue_comment_url":"https://api.github.com/repos/hypothesis/h/issues/comments{/number}","contents_url":"https://api.github.com/repos/hypothesis/h/contents/{+path}","compare_url":"https://api.github.com/repos/hypothesis/h/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hypothesis/h/merges","archive_url":"https://api.github.com/repos/hypothesis/h/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hypothesis/h/downloads","issues_url":"https://api.github.com/repos/hypothesis/h/issues{/number}","pulls_url":"https://api.github.com/repos/hypothesis/h/pulls{/number}","milestones_url":"https://api.github.com/repos/hypothesis/h/milestones{/number}","notifications_url":"https://api.github.com/repos/hypothesis/h/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hypothesis/h/labels{/name}","releases_url":"https://api.github.com/repos/hypothesis/h/releases{/id}","deployments_url":"https://api.github.com/repos/hypothesis/h/deployments","created_at":"2012-04-02T19:56:59Z","updated_at":"2016-11-09T20:27:40Z","pushed_at":"2016-11-10T14:56:36Z","git_url":"git://github.com/hypothesis/h.git","ssh_url":"git@github.com:hypothesis/h.git","clone_url":"https://github.com/hypothesis/h.git","svn_url":"https://github.com/hypothesis/h","homepage":"https://hypothes.is/","size":31883,"stargazers_count":737,"watchers_count":737,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":160,"mirror_url":null,"open_issues_count":92,"forks":160,"open_issues":92,"watchers":737,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hypothesis/h/pulls/4025"},"html":{"href":"https://github.com/hypothesis/h/pull/4025"},"issue":{"href":"https://api.github.com/repos/hypothesis/h/issues/4025"},"comments":{"href":"https://api.github.com/repos/hypothesis/h/issues/4025/comments"},"review_comments":{"href":"https://api.github.com/repos/hypothesis/h/pulls/4025/comments"},"review_comment":{"href":"https://api.github.com/repos/hypothesis/h/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hypothesis/h/pulls/4025/commits"},"statuses":{"href":"https://api.github.com/repos/hypothesis/h/statuses/8d00243768ca0688591a7f1d5ba6946857ef6241"}}}}
{"actor":{"display_login":"seanh"}}