{"action":"created","issue":{"url":"https://api.github.com/repos/powertab/powertabeditor/issues/224","repository_url":"https://api.github.com/repos/powertab/powertabeditor","labels_url":"https://api.github.com/repos/powertab/powertabeditor/issues/224/labels{/name}","comments_url":"https://api.github.com/repos/powertab/powertabeditor/issues/224/comments","events_url":"https://api.github.com/repos/powertab/powertabeditor/issues/224/events","html_url":"https://github.com/powertab/powertabeditor/pull/224","id":176397990,"number":224,"title":"Bend edits","user":{"login":"PellTheTabber1","id":11949191,"avatar_url":"https://avatars.githubusercontent.com/u/11949191?v=3","gravatar_id":"","url":"https://api.github.com/users/PellTheTabber1","html_url":"https://github.com/PellTheTabber1","followers_url":"https://api.github.com/users/PellTheTabber1/followers","following_url":"https://api.github.com/users/PellTheTabber1/following{/other_user}","gists_url":"https://api.github.com/users/PellTheTabber1/gists{/gist_id}","starred_url":"https://api.github.com/users/PellTheTabber1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PellTheTabber1/subscriptions","organizations_url":"https://api.github.com/users/PellTheTabber1/orgs","repos_url":"https://api.github.com/users/PellTheTabber1/repos","events_url":"https://api.github.com/users/PellTheTabber1/events{/privacy}","received_events_url":"https://api.github.com/users/PellTheTabber1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2016-09-12T14:57:41Z","updated_at":"2016-09-18T01:05:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/powertab/powertabeditor/pulls/224","html_url":"https://github.com/powertab/powertabeditor/pull/224","diff_url":"https://github.com/powertab/powertabeditor/pull/224.diff","patch_url":"https://github.com/powertab/powertabeditor/pull/224.patch"},"body":"I've added a new method to the PowerTabEditor class in app (powertabeditor.cpp/.h) called updateNoteDurationForBend.  This is called in the editBend method of the same class.\r\n\r\nI then finished the else in midifile.cpp that had previously been a TODO, so that when the midi file plays, the note sounds the correct duration.\r\n\r\nI did not put any error/sanity checking in, but at least I can play my bends with proper duration on midi playback now.  The note duration is still undoable as it was added with the Undo Manager.\r\n\r\nThe dialog does NOT currently have dotted duration bends, perhaps this can be added later.\r\nI am coding on an Windows machine, but uploading from my Fatdog Linux, hence there may be text-formatting issues.  Not sure about this yet.  This is my first pull request.\r\n\r\nI noticed a line where a variable pos is declared but never used.  I've removed this, however, I will not post the update as it's fairly trivial and will not affect the code's execution.  Sorry, I put that line in and did not need pos.\r\n\r\nI have not agonized over whether this code could be put elsewhere such as in a constructor, and I have not range-checked it.  However, I need this code so bends sound the right amount.\r\n\r\nI have also observed that with my new code that extends the duration of the note in the score itself, that in midifile.cpp, there is not as much need of an if-else if-else.  It can pretty much be an if and an else.  Perhaps I need to check this one in but assign an issue to get things cleaned up - Linux vs. Windows tabs and that generateGradualBend issue, and perhaps check the code by testing how each if/else and case sound.  It might be ok or almost ok."},"comment":{"url":"https://api.github.com/repos/powertab/powertabeditor/issues/comments/247817437","html_url":"https://github.com/powertab/powertabeditor/pull/224#issuecomment-247817437","issue_url":"https://api.github.com/repos/powertab/powertabeditor/issues/224","id":247817437,"user":{"login":"PellTheTabber1","id":11949191,"avatar_url":"https://avatars.githubusercontent.com/u/11949191?v=3","gravatar_id":"","url":"https://api.github.com/users/PellTheTabber1","html_url":"https://github.com/PellTheTabber1","followers_url":"https://api.github.com/users/PellTheTabber1/followers","following_url":"https://api.github.com/users/PellTheTabber1/following{/other_user}","gists_url":"https://api.github.com/users/PellTheTabber1/gists{/gist_id}","starred_url":"https://api.github.com/users/PellTheTabber1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PellTheTabber1/subscriptions","organizations_url":"https://api.github.com/users/PellTheTabber1/orgs","repos_url":"https://api.github.com/users/PellTheTabber1/repos","events_url":"https://api.github.com/users/PellTheTabber1/events{/privacy}","received_events_url":"https://api.github.com/users/PellTheTabber1/received_events","type":"User","site_admin":false},"created_at":"2016-09-18T01:05:47Z","updated_at":"2016-09-18T01:05:47Z","body":"Commiting Stage 2 implementation of Hold using tie notes per Issues 224/225.  Files affected: powertabeditor.cpp/.h, midifile.cpp"}}
{"actor":{"display_login":"PellTheTabber1"}}