{"action":"created","comment":{"url":"https://api.github.com/repos/novoda/spikes/pulls/comments/69428148","id":69428148,"diff_hunk":"@@ -0,0 +1,57 @@\n+package com.novoda.todoapp.task.edit.presenter;\n+\n+import com.novoda.data.SyncedData;\n+import com.novoda.event.DataObserver;\n+import com.novoda.todoapp.navigation.Navigator;\n+import com.novoda.todoapp.task.TaskActionListener;\n+import com.novoda.todoapp.task.data.model.Task;\n+import com.novoda.todoapp.task.edit.displayer.EditTaskDisplayer;\n+import com.novoda.todoapp.task.presenter.IdProducer;\n+import com.novoda.todoapp.tasks.service.TasksService;\n+\n+import rx.subscriptions.CompositeSubscription;\n+\n+public class EditTaskPresenter {\n+\n+    private final TasksService tasksService;\n+    private final EditTaskDisplayer taskDisplayer;\n+    private final IdProducer idProducer;\n+\n+    final TaskActionListener taskActionListener;\n+\n+    private CompositeSubscription subscriptions = new CompositeSubscription();\n+\n+    public EditTaskPresenter(\n+            TasksService tasksService,\n+            EditTaskDisplayer taskDisplayer,\n+            Navigator navigator,\n+            IdProducer idProducer\n+    ) {\n+        this.tasksService = tasksService;\n+        this.taskDisplayer = taskDisplayer;\n+        this.idProducer = idProducer;\n+        taskActionListener = new TaskActionListener(this.tasksService, this.taskDisplayer, navigator, this.idProducer);\n+    }\n+\n+    public void startPresenting() {\n+        taskDisplayer.attach(taskActionListener);\n+        subscriptions.add(\n+                tasksService.getTask(idProducer.produce())\n+                        .subscribe(taskObserver)\n+        );\n+    }\n+\n+    public void stopPresenting() {\n+        taskDisplayer.detach(taskActionListener);\n+        subscriptions.clear();","path":"Architecture/TodoApp/android/core/src/main/java/com/novoda/todoapp/task/edit/presenter/EditTaskPresenter.java","position":46,"original_position":46,"commit_id":"3b1d8e87bfa738940d32bb37e70736cc69b99ca3","original_commit_id":"3b1d8e87bfa738940d32bb37e70736cc69b99ca3","user":{"login":"Dorvaryn","id":610924,"avatar_url":"https://avatars.githubusercontent.com/u/610924?v=3","gravatar_id":"","url":"https://api.github.com/users/Dorvaryn","html_url":"https://github.com/Dorvaryn","followers_url":"https://api.github.com/users/Dorvaryn/followers","following_url":"https://api.github.com/users/Dorvaryn/following{/other_user}","gists_url":"https://api.github.com/users/Dorvaryn/gists{/gist_id}","starred_url":"https://api.github.com/users/Dorvaryn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dorvaryn/subscriptions","organizations_url":"https://api.github.com/users/Dorvaryn/orgs","repos_url":"https://api.github.com/users/Dorvaryn/repos","events_url":"https://api.github.com/users/Dorvaryn/events{/privacy}","received_events_url":"https://api.github.com/users/Dorvaryn/received_events","type":"User","site_admin":false},"body":"Not at the moment I would say, it is small enough and only used once.","created_at":"2016-07-04T09:01:24Z","updated_at":"2016-07-04T09:01:24Z","html_url":"https://github.com/novoda/spikes/pull/116#discussion_r69428148","pull_request_url":"https://api.github.com/repos/novoda/spikes/pulls/116","_links":{"self":{"href":"https://api.github.com/repos/novoda/spikes/pulls/comments/69428148"},"html":{"href":"https://github.com/novoda/spikes/pull/116#discussion_r69428148"},"pull_request":{"href":"https://api.github.com/repos/novoda/spikes/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/novoda/spikes/pulls/116","id":76000330,"html_url":"https://github.com/novoda/spikes/pull/116","diff_url":"https://github.com/novoda/spikes/pull/116.diff","patch_url":"https://github.com/novoda/spikes/pull/116.patch","issue_url":"https://api.github.com/repos/novoda/spikes/issues/116","number":116,"state":"open","locked":false,"title":"UI Polish - Realigning the FAB, cleaning up the activity labels ","user":{"login":"Dorvaryn","id":610924,"avatar_url":"https://avatars.githubusercontent.com/u/610924?v=3","gravatar_id":"","url":"https://api.github.com/users/Dorvaryn","html_url":"https://github.com/Dorvaryn","followers_url":"https://api.github.com/users/Dorvaryn/followers","following_url":"https://api.github.com/users/Dorvaryn/following{/other_user}","gists_url":"https://api.github.com/users/Dorvaryn/gists{/gist_id}","starred_url":"https://api.github.com/users/Dorvaryn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dorvaryn/subscriptions","organizations_url":"https://api.github.com/users/Dorvaryn/orgs","repos_url":"https://api.github.com/users/Dorvaryn/repos","events_url":"https://api.github.com/users/Dorvaryn/events{/privacy}","received_events_url":"https://api.github.com/users/Dorvaryn/received_events","type":"User","site_admin":false},"body":"#### Problem\r\nThe activity labels on our TODO app were all wrong! They were all set to the same string, which was CHANGEME. \r\n\r\n#### Solution\r\nWe updated the activity labels. Additionally we made the FAB appear above the keyboard when you are typing the details of a new task.\r\n\r\n##### Test(s) added \r\n_yes_ - as many as we could, mainly around the `NewTaskPresenter` and `EditTaskPresenter`\r\n\r\n##### Screenshots\r\n| Before | Desired | After |\r\n| ------ | ----- | ----- |\r\n| ![novoda-todo-add-task](https://cloud.githubusercontent.com/assets/10560214/16526672/378433e4-3faa-11e6-84ad-d3fb324e9674.gif) | ![google-todo-add-task](https://cloud.githubusercontent.com/assets/10560214/16526682/461685d8-3faa-11e6-9eab-a073a2d753cb.gif) | ![novoda-todo-fixed](https://cloud.githubusercontent.com/assets/10560214/16526723/738bda0e-3faa-11e6-9d8e-09d262897002.gif) |\r\n\r\n###### Paired with \r\n@joetimmins  \r\n","created_at":"2016-07-01T15:51:01Z","updated_at":"2016-07-04T09:01:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3c78952c8e8d0dd26262734373de0f757d93faa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/novoda/spikes/pulls/116/commits","review_comments_url":"https://api.github.com/repos/novoda/spikes/pulls/116/comments","review_comment_url":"https://api.github.com/repos/novoda/spikes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/novoda/spikes/issues/116/comments","statuses_url":"https://api.github.com/repos/novoda/spikes/statuses/3b1d8e87bfa738940d32bb37e70736cc69b99ca3","head":{"label":"novoda:architecture/feature/ui-polish","ref":"architecture/feature/ui-polish","sha":"3b1d8e87bfa738940d32bb37e70736cc69b99ca3","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":13300550,"name":"spikes","full_name":"novoda/spikes","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/spikes","description":"Where ideas & concepts are born & incubated","fork":false,"url":"https://api.github.com/repos/novoda/spikes","forks_url":"https://api.github.com/repos/novoda/spikes/forks","keys_url":"https://api.github.com/repos/novoda/spikes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/spikes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/spikes/teams","hooks_url":"https://api.github.com/repos/novoda/spikes/hooks","issue_events_url":"https://api.github.com/repos/novoda/spikes/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/spikes/events","assignees_url":"https://api.github.com/repos/novoda/spikes/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/spikes/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/spikes/tags","blobs_url":"https://api.github.com/repos/novoda/spikes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/spikes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/spikes/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/spikes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/spikes/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/spikes/languages","stargazers_url":"https://api.github.com/repos/novoda/spikes/stargazers","contributors_url":"https://api.github.com/repos/novoda/spikes/contributors","subscribers_url":"https://api.github.com/repos/novoda/spikes/subscribers","subscription_url":"https://api.github.com/repos/novoda/spikes/subscription","commits_url":"https://api.github.com/repos/novoda/spikes/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/spikes/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/spikes/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/spikes/issues/comments{/number}","contents_url":"https://api.github.com/repos/novoda/spikes/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/spikes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/spikes/merges","archive_url":"https://api.github.com/repos/novoda/spikes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/spikes/downloads","issues_url":"https://api.github.com/repos/novoda/spikes/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/spikes/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/spikes/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/spikes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/spikes/labels{/name}","releases_url":"https://api.github.com/repos/novoda/spikes/releases{/id}","deployments_url":"https://api.github.com/repos/novoda/spikes/deployments","created_at":"2013-10-03T14:31:43Z","updated_at":"2016-06-28T13:56:49Z","pushed_at":"2016-07-03T20:05:42Z","git_url":"git://github.com/novoda/spikes.git","ssh_url":"git@github.com:novoda/spikes.git","clone_url":"https://github.com/novoda/spikes.git","svn_url":"https://github.com/novoda/spikes","homepage":"","size":31459,"stargazers_count":45,"watchers_count":45,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":3,"forks":8,"open_issues":3,"watchers":45,"default_branch":"master"}},"base":{"label":"novoda:architecture/develop","ref":"architecture/develop","sha":"2c10dfa3a709e08166b49f11d8968eddac63e6f2","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":13300550,"name":"spikes","full_name":"novoda/spikes","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/spikes","description":"Where ideas & concepts are born & incubated","fork":false,"url":"https://api.github.com/repos/novoda/spikes","forks_url":"https://api.github.com/repos/novoda/spikes/forks","keys_url":"https://api.github.com/repos/novoda/spikes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/spikes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/spikes/teams","hooks_url":"https://api.github.com/repos/novoda/spikes/hooks","issue_events_url":"https://api.github.com/repos/novoda/spikes/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/spikes/events","assignees_url":"https://api.github.com/repos/novoda/spikes/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/spikes/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/spikes/tags","blobs_url":"https://api.github.com/repos/novoda/spikes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/spikes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/spikes/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/spikes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/spikes/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/spikes/languages","stargazers_url":"https://api.github.com/repos/novoda/spikes/stargazers","contributors_url":"https://api.github.com/repos/novoda/spikes/contributors","subscribers_url":"https://api.github.com/repos/novoda/spikes/subscribers","subscription_url":"https://api.github.com/repos/novoda/spikes/subscription","commits_url":"https://api.github.com/repos/novoda/spikes/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/spikes/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/spikes/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/spikes/issues/comments{/number}","contents_url":"https://api.github.com/repos/novoda/spikes/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/spikes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/spikes/merges","archive_url":"https://api.github.com/repos/novoda/spikes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/spikes/downloads","issues_url":"https://api.github.com/repos/novoda/spikes/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/spikes/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/spikes/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/spikes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/spikes/labels{/name}","releases_url":"https://api.github.com/repos/novoda/spikes/releases{/id}","deployments_url":"https://api.github.com/repos/novoda/spikes/deployments","created_at":"2013-10-03T14:31:43Z","updated_at":"2016-06-28T13:56:49Z","pushed_at":"2016-07-03T20:05:42Z","git_url":"git://github.com/novoda/spikes.git","ssh_url":"git@github.com:novoda/spikes.git","clone_url":"https://github.com/novoda/spikes.git","svn_url":"https://github.com/novoda/spikes","homepage":"","size":31459,"stargazers_count":45,"watchers_count":45,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":3,"forks":8,"open_issues":3,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/novoda/spikes/pulls/116"},"html":{"href":"https://github.com/novoda/spikes/pull/116"},"issue":{"href":"https://api.github.com/repos/novoda/spikes/issues/116"},"comments":{"href":"https://api.github.com/repos/novoda/spikes/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/novoda/spikes/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/novoda/spikes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/novoda/spikes/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/novoda/spikes/statuses/3b1d8e87bfa738940d32bb37e70736cc69b99ca3"}}}}
{"actor":{"display_login":"Dorvaryn"}}