{"action":"created","issue":{"url":"https://api.github.com/repos/icewind1991/Streams/issues/5","repository_url":"https://api.github.com/repos/icewind1991/Streams","labels_url":"https://api.github.com/repos/icewind1991/Streams/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/icewind1991/Streams/issues/5/comments","events_url":"https://api.github.com/repos/icewind1991/Streams/issues/5/events","html_url":"https://github.com/icewind1991/Streams/pull/5","id":193122589,"number":5,"title":"Prevent duplicate closeCallback calls in case of GC ghosts","user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?v=3","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-02T14:00:25Z","updated_at":"2016-12-02T14:03:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/icewind1991/Streams/pulls/5","html_url":"https://github.com/icewind1991/Streams/pull/5","diff_url":"https://github.com/icewind1991/Streams/pull/5.diff","patch_url":"https://github.com/icewind1991/Streams/pull/5.patch"},"body":"Sometimes PHP 7 GC decides to call stream_close again even after the\r\nPHP request has ended, and even if fclose was called before already.\r\n\r\nNote: the ghost is even so ghostly that you can't see it with a debugger.\r\nObserved while debugging https://github.com/owncloud/core/issues/22370#issuecomment-263247010\r\n\r\nBasically with the log statements from https://github.com/owncloud/core/issues/26735 I can see that `fclose` was called and also the callback was called as well. But **still**, PHP somehow calls it again.\r\n\r\nAfter applying this fix, this specific scenario doesn't cause errors to be logged again.\r\n\r\n@icewind1991 "},"comment":{"url":"https://api.github.com/repos/icewind1991/Streams/issues/comments/264460454","html_url":"https://github.com/icewind1991/Streams/pull/5#issuecomment-264460454","issue_url":"https://api.github.com/repos/icewind1991/Streams/issues/5","id":264460454,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-12-02T14:03:09Z","updated_at":"2016-12-02T14:03:09Z","body":"\n[![Coverage Status](https://coveralls.io/builds/9100865/badge)](https://coveralls.io/builds/9100865)\n\nCoverage increased (+0.01%) to 95.946% when pulling **668abfee8077706134dbedbf9efcdd7b3285e273 on PVince81:stream_close_scare_away_ghosts** into **0700f81441200b33d929c108b9ee6d76b0104fa2 on icewind1991:master**.\n"}}
{"actor":{"display_login":"coveralls"}}