{"action":"opened","number":37,"pull_request":{"url":"https://api.github.com/repos/DigitalNZ/supplejack_website/pulls/37","id":76206704,"html_url":"https://github.com/DigitalNZ/supplejack_website/pull/37","diff_url":"https://github.com/DigitalNZ/supplejack_website/pull/37.diff","patch_url":"https://github.com/DigitalNZ/supplejack_website/pull/37.patch","issue_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/issues/37","number":37,"state":"open","locked":false,"title":"Kereru Feedback from Taylor","user":{"login":"Reinkaos","id":1848911,"avatar_url":"https://avatars.githubusercontent.com/u/1848911?v=3","gravatar_id":"","url":"https://api.github.com/users/Reinkaos","html_url":"https://github.com/Reinkaos","followers_url":"https://api.github.com/users/Reinkaos/followers","following_url":"https://api.github.com/users/Reinkaos/following{/other_user}","gists_url":"https://api.github.com/users/Reinkaos/gists{/gist_id}","starred_url":"https://api.github.com/users/Reinkaos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reinkaos/subscriptions","organizations_url":"https://api.github.com/users/Reinkaos/orgs","repos_url":"https://api.github.com/users/Reinkaos/repos","events_url":"https://api.github.com/users/Reinkaos/events{/privacy}","received_events_url":"https://api.github.com/users/Reinkaos/received_events","type":"User","site_admin":false},"body":"https://github.com/DigitalNZ/supplejack_website/pull/34/files#diff-69f1212264dad34091bc29861b2c05d5R63 is this RDoc style? It doesn’t look like YARD, should be changed\r\nhttps://github.com/DigitalNZ/supplejack_website/pull/34/files#diff-69f1212264dad34091bc29861b2c05d5R75 should be a new line before category here\r\n\r\nhttps://github.com/DigitalNZ/supplejack_website/pull/34/files#diff-cb647a499ca19eec9819d789ff810c1fR67 instead of an inject I think this would be done better by filtering out the blacklist and then calling .sum\r\n\r\nhttps://github.com/DigitalNZ/supplejack_website/pull/34/files#diff-dee9387cb565fd0c48822ce9462bfb19R12 this should still be a const, const only prevents reassigning the variable, not modifying it\r\n\r\nhttps://github.com/DigitalNZ/supplejack_website/pull/34/files#diff-1e2d4f1bdbe486f2da57c7812b53be03R29 this should be formatted nicer\r\n\r\nhttps://github.com/DigitalNZ/supplejack_website/pull/34/files#diff-6b3ffe2c969801010ebdd529de9df5ccR29 this array of categories should be extracted to a system level constant (i.e. in another file and it gets imported here) so it can be shared with the other locations that use it. It should also use _.includes instead of indexOf\r\nhttps://github.com/DigitalNZ/supplejack_website/pull/34/files#diff-6b3ffe2c969801010ebdd529de9df5ccR33 same as above\r\nhttps://github.com/DigitalNZ/supplejack_website/pull/34/files#diff-6b3ffe2c969801010ebdd529de9df5ccR99 this might as well just set dropdownIsVisible regardless of whether it’s visible or not\r\nhttps://github.com/DigitalNZ/supplejack_website/pull/34/files#diff-6b3ffe2c969801010ebdd529de9df5ccR120 should be !_.isUndefined, following line (121) should use the class level constant for categories that was created earlier\r\nhttps://github.com/DigitalNZ/supplejack_website/pull/34/files#diff-6b3ffe2c969801010ebdd529de9df5ccR127 this should be folded into the render method because that is basically what is happening anyway, you just need to look in two places\r\nhttps://github.com/DigitalNZ/supplejack_website/pull/34/files#diff-6b3ffe2c969801010ebdd529de9df5ccR157 this could be improved\r\n\r\nhttps://github.com/DigitalNZ/supplejack_website/pull/34/files#diff-002e6bb5d83c0f3d2097db36d1e151f6R22 this should make use of the imported system level constant \r\nhttps://github.com/DigitalNZ/supplejack_website/pull/34/files#diff-002e6bb5d83c0f3d2097db36d1e151f6R35 better formatting","created_at":"2016-07-05T00:23:31Z","updated_at":"2016-07-05T00:23:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/pulls/37/commits","review_comments_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/pulls/37/comments","review_comment_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/issues/37/comments","statuses_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/statuses/49aa23c3080139a4e46ef11a47d1a16fedf5271d","head":{"label":"DigitalNZ:rm/kereru-sifter-notes","ref":"rm/kereru-sifter-notes","sha":"49aa23c3080139a4e46ef11a47d1a16fedf5271d","user":{"login":"DigitalNZ","id":93386,"avatar_url":"https://avatars.githubusercontent.com/u/93386?v=3","gravatar_id":"","url":"https://api.github.com/users/DigitalNZ","html_url":"https://github.com/DigitalNZ","followers_url":"https://api.github.com/users/DigitalNZ/followers","following_url":"https://api.github.com/users/DigitalNZ/following{/other_user}","gists_url":"https://api.github.com/users/DigitalNZ/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalNZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalNZ/subscriptions","organizations_url":"https://api.github.com/users/DigitalNZ/orgs","repos_url":"https://api.github.com/users/DigitalNZ/repos","events_url":"https://api.github.com/users/DigitalNZ/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalNZ/received_events","type":"Organization","site_admin":false},"repo":{"id":21408136,"name":"supplejack_website","full_name":"DigitalNZ/supplejack_website","owner":{"login":"DigitalNZ","id":93386,"avatar_url":"https://avatars.githubusercontent.com/u/93386?v=3","gravatar_id":"","url":"https://api.github.com/users/DigitalNZ","html_url":"https://github.com/DigitalNZ","followers_url":"https://api.github.com/users/DigitalNZ/followers","following_url":"https://api.github.com/users/DigitalNZ/following{/other_user}","gists_url":"https://api.github.com/users/DigitalNZ/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalNZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalNZ/subscriptions","organizations_url":"https://api.github.com/users/DigitalNZ/orgs","repos_url":"https://api.github.com/users/DigitalNZ/repos","events_url":"https://api.github.com/users/DigitalNZ/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalNZ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DigitalNZ/supplejack_website","description":"This website demo is part of the standard Supplejack platform that can aggregate data and content from many different sources.","fork":false,"url":"https://api.github.com/repos/DigitalNZ/supplejack_website","forks_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/forks","keys_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/teams","hooks_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/hooks","issue_events_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/issues/events{/number}","events_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/events","assignees_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/assignees{/user}","branches_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/branches{/branch}","tags_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/tags","blobs_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/git/refs{/sha}","trees_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/statuses/{sha}","languages_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/languages","stargazers_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/stargazers","contributors_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/contributors","subscribers_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/subscribers","subscription_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/subscription","commits_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/commits{/sha}","git_commits_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/git/commits{/sha}","comments_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/comments{/number}","issue_comment_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/issues/comments{/number}","contents_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/contents/{+path}","compare_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/merges","archive_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/downloads","issues_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/issues{/number}","pulls_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/pulls{/number}","milestones_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/milestones{/number}","notifications_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/labels{/name}","releases_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/releases{/id}","deployments_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/deployments","created_at":"2014-07-02T01:53:48Z","updated_at":"2016-02-19T01:55:54Z","pushed_at":"2016-07-05T00:23:31Z","git_url":"git://github.com/DigitalNZ/supplejack_website.git","ssh_url":"git@github.com:DigitalNZ/supplejack_website.git","clone_url":"https://github.com/DigitalNZ/supplejack_website.git","svn_url":"https://github.com/DigitalNZ/supplejack_website","homepage":null,"size":5569,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"DigitalNZ:master","ref":"master","sha":"970883e9259078f0ae1173700f442672a4998122","user":{"login":"DigitalNZ","id":93386,"avatar_url":"https://avatars.githubusercontent.com/u/93386?v=3","gravatar_id":"","url":"https://api.github.com/users/DigitalNZ","html_url":"https://github.com/DigitalNZ","followers_url":"https://api.github.com/users/DigitalNZ/followers","following_url":"https://api.github.com/users/DigitalNZ/following{/other_user}","gists_url":"https://api.github.com/users/DigitalNZ/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalNZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalNZ/subscriptions","organizations_url":"https://api.github.com/users/DigitalNZ/orgs","repos_url":"https://api.github.com/users/DigitalNZ/repos","events_url":"https://api.github.com/users/DigitalNZ/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalNZ/received_events","type":"Organization","site_admin":false},"repo":{"id":21408136,"name":"supplejack_website","full_name":"DigitalNZ/supplejack_website","owner":{"login":"DigitalNZ","id":93386,"avatar_url":"https://avatars.githubusercontent.com/u/93386?v=3","gravatar_id":"","url":"https://api.github.com/users/DigitalNZ","html_url":"https://github.com/DigitalNZ","followers_url":"https://api.github.com/users/DigitalNZ/followers","following_url":"https://api.github.com/users/DigitalNZ/following{/other_user}","gists_url":"https://api.github.com/users/DigitalNZ/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalNZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalNZ/subscriptions","organizations_url":"https://api.github.com/users/DigitalNZ/orgs","repos_url":"https://api.github.com/users/DigitalNZ/repos","events_url":"https://api.github.com/users/DigitalNZ/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalNZ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DigitalNZ/supplejack_website","description":"This website demo is part of the standard Supplejack platform that can aggregate data and content from many different sources.","fork":false,"url":"https://api.github.com/repos/DigitalNZ/supplejack_website","forks_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/forks","keys_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/teams","hooks_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/hooks","issue_events_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/issues/events{/number}","events_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/events","assignees_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/assignees{/user}","branches_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/branches{/branch}","tags_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/tags","blobs_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/git/refs{/sha}","trees_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/statuses/{sha}","languages_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/languages","stargazers_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/stargazers","contributors_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/contributors","subscribers_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/subscribers","subscription_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/subscription","commits_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/commits{/sha}","git_commits_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/git/commits{/sha}","comments_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/comments{/number}","issue_comment_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/issues/comments{/number}","contents_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/contents/{+path}","compare_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/merges","archive_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/downloads","issues_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/issues{/number}","pulls_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/pulls{/number}","milestones_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/milestones{/number}","notifications_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/labels{/name}","releases_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/releases{/id}","deployments_url":"https://api.github.com/repos/DigitalNZ/supplejack_website/deployments","created_at":"2014-07-02T01:53:48Z","updated_at":"2016-02-19T01:55:54Z","pushed_at":"2016-07-05T00:23:31Z","git_url":"git://github.com/DigitalNZ/supplejack_website.git","ssh_url":"git@github.com:DigitalNZ/supplejack_website.git","clone_url":"https://github.com/DigitalNZ/supplejack_website.git","svn_url":"https://github.com/DigitalNZ/supplejack_website","homepage":null,"size":5569,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DigitalNZ/supplejack_website/pulls/37"},"html":{"href":"https://github.com/DigitalNZ/supplejack_website/pull/37"},"issue":{"href":"https://api.github.com/repos/DigitalNZ/supplejack_website/issues/37"},"comments":{"href":"https://api.github.com/repos/DigitalNZ/supplejack_website/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/DigitalNZ/supplejack_website/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/DigitalNZ/supplejack_website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DigitalNZ/supplejack_website/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/DigitalNZ/supplejack_website/statuses/49aa23c3080139a4e46ef11a47d1a16fedf5271d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":10,"additions":94,"deletions":101,"changed_files":12}}
{"actor":{"display_login":"Reinkaos"}}