{"action":"created","comment":{"url":"https://api.github.com/repos/harvesthq/chosen/pulls/comments/83652448","pull_request_review_id":4481269,"id":83652448,"diff_hunk":"@@ -392,8 +392,9 @@ class @Chosen extends AbstractChosen\n \n   single_deselect_control_build: ->\n     return unless @allow_single_deselect\n-    @selected_item.down(\"span\").insert { after: \"<abbr class=\\\"search-choice-close\\\"></abbr>\" } unless @selected_item.down(\"abbr\")\n-    @selected_item.addClassName(\"chosen-single-with-deselect\")\n+    unless @selected_item.down('.search-choice-close')\n+      @selected_item.down('span').insert { after: '<a class=\"search-choice-close\"></a>' }","path":"coffee/chosen.proto.coffee","position":25,"original_position":25,"commit_id":"1eec4b1754f0839e2b8d8d9aa3fb88e98cd0fd8b","original_commit_id":"1eec4b1754f0839e2b8d8d9aa3fb88e98cd0fd8b","user":{"login":"mlettini","id":563545,"avatar_url":"https://avatars.githubusercontent.com/u/563545?v=3","gravatar_id":"","url":"https://api.github.com/users/mlettini","html_url":"https://github.com/mlettini","followers_url":"https://api.github.com/users/mlettini/followers","following_url":"https://api.github.com/users/mlettini/following{/other_user}","gists_url":"https://api.github.com/users/mlettini/gists{/gist_id}","starred_url":"https://api.github.com/users/mlettini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlettini/subscriptions","organizations_url":"https://api.github.com/users/mlettini/orgs","repos_url":"https://api.github.com/users/mlettini/repos","events_url":"https://api.github.com/users/mlettini/events{/privacy}","received_events_url":"https://api.github.com/users/mlettini/received_events","type":"User","site_admin":false},"body":"Lines 28-30 of `sass/chosen.scss` force a cursor to all links within `.chosen-container`, but I agree that no href is less semantic.","created_at":"2016-10-17T14:16:19Z","updated_at":"2016-10-17T14:16:19Z","html_url":"https://github.com/harvesthq/chosen/pull/2726#discussion_r83652448","pull_request_url":"https://api.github.com/repos/harvesthq/chosen/pulls/2726","_links":{"self":{"href":"https://api.github.com/repos/harvesthq/chosen/pulls/comments/83652448"},"html":{"href":"https://github.com/harvesthq/chosen/pull/2726#discussion_r83652448"},"pull_request":{"href":"https://api.github.com/repos/harvesthq/chosen/pulls/2726"}}},"pull_request":{"url":"https://api.github.com/repos/harvesthq/chosen/pulls/2726","id":89495026,"html_url":"https://github.com/harvesthq/chosen/pull/2726","diff_url":"https://github.com/harvesthq/chosen/pull/2726.diff","patch_url":"https://github.com/harvesthq/chosen/pull/2726.patch","issue_url":"https://api.github.com/repos/harvesthq/chosen/issues/2726","number":2726,"state":"open","locked":false,"title":"use a tag instead of abbr tag for search-choice-close","user":{"login":"koenpunt","id":351038,"avatar_url":"https://avatars.githubusercontent.com/u/351038?v=3","gravatar_id":"","url":"https://api.github.com/users/koenpunt","html_url":"https://github.com/koenpunt","followers_url":"https://api.github.com/users/koenpunt/followers","following_url":"https://api.github.com/users/koenpunt/following{/other_user}","gists_url":"https://api.github.com/users/koenpunt/gists{/gist_id}","starred_url":"https://api.github.com/users/koenpunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koenpunt/subscriptions","organizations_url":"https://api.github.com/users/koenpunt/orgs","repos_url":"https://api.github.com/users/koenpunt/repos","events_url":"https://api.github.com/users/koenpunt/events{/privacy}","received_events_url":"https://api.github.com/users/koenpunt/received_events","type":"User","site_admin":false},"body":"fixes #495","created_at":"2016-10-15T14:35:26Z","updated_at":"2016-10-17T14:16:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2651fd41caad966167f7eb704b32d65c4969d4a7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/harvesthq/chosen/pulls/2726/commits","review_comments_url":"https://api.github.com/repos/harvesthq/chosen/pulls/2726/comments","review_comment_url":"https://api.github.com/repos/harvesthq/chosen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/harvesthq/chosen/issues/2726/comments","statuses_url":"https://api.github.com/repos/harvesthq/chosen/statuses/1eec4b1754f0839e2b8d8d9aa3fb88e98cd0fd8b","head":{"label":"harvesthq:search-choice-close","ref":"search-choice-close","sha":"1eec4b1754f0839e2b8d8d9aa3fb88e98cd0fd8b","user":{"login":"harvesthq","id":43635,"avatar_url":"https://avatars.githubusercontent.com/u/43635?v=3","gravatar_id":"","url":"https://api.github.com/users/harvesthq","html_url":"https://github.com/harvesthq","followers_url":"https://api.github.com/users/harvesthq/followers","following_url":"https://api.github.com/users/harvesthq/following{/other_user}","gists_url":"https://api.github.com/users/harvesthq/gists{/gist_id}","starred_url":"https://api.github.com/users/harvesthq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harvesthq/subscriptions","organizations_url":"https://api.github.com/users/harvesthq/orgs","repos_url":"https://api.github.com/users/harvesthq/repos","events_url":"https://api.github.com/users/harvesthq/events{/privacy}","received_events_url":"https://api.github.com/users/harvesthq/received_events","type":"Organization","site_admin":false},"repo":{"id":1631024,"name":"chosen","full_name":"harvesthq/chosen","owner":{"login":"harvesthq","id":43635,"avatar_url":"https://avatars.githubusercontent.com/u/43635?v=3","gravatar_id":"","url":"https://api.github.com/users/harvesthq","html_url":"https://github.com/harvesthq","followers_url":"https://api.github.com/users/harvesthq/followers","following_url":"https://api.github.com/users/harvesthq/following{/other_user}","gists_url":"https://api.github.com/users/harvesthq/gists{/gist_id}","starred_url":"https://api.github.com/users/harvesthq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harvesthq/subscriptions","organizations_url":"https://api.github.com/users/harvesthq/orgs","repos_url":"https://api.github.com/users/harvesthq/repos","events_url":"https://api.github.com/users/harvesthq/events{/privacy}","received_events_url":"https://api.github.com/users/harvesthq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/harvesthq/chosen","description":"Chosen is a library for making long, unwieldy select boxes more friendly.","fork":false,"url":"https://api.github.com/repos/harvesthq/chosen","forks_url":"https://api.github.com/repos/harvesthq/chosen/forks","keys_url":"https://api.github.com/repos/harvesthq/chosen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harvesthq/chosen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harvesthq/chosen/teams","hooks_url":"https://api.github.com/repos/harvesthq/chosen/hooks","issue_events_url":"https://api.github.com/repos/harvesthq/chosen/issues/events{/number}","events_url":"https://api.github.com/repos/harvesthq/chosen/events","assignees_url":"https://api.github.com/repos/harvesthq/chosen/assignees{/user}","branches_url":"https://api.github.com/repos/harvesthq/chosen/branches{/branch}","tags_url":"https://api.github.com/repos/harvesthq/chosen/tags","blobs_url":"https://api.github.com/repos/harvesthq/chosen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harvesthq/chosen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harvesthq/chosen/git/refs{/sha}","trees_url":"https://api.github.com/repos/harvesthq/chosen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harvesthq/chosen/statuses/{sha}","languages_url":"https://api.github.com/repos/harvesthq/chosen/languages","stargazers_url":"https://api.github.com/repos/harvesthq/chosen/stargazers","contributors_url":"https://api.github.com/repos/harvesthq/chosen/contributors","subscribers_url":"https://api.github.com/repos/harvesthq/chosen/subscribers","subscription_url":"https://api.github.com/repos/harvesthq/chosen/subscription","commits_url":"https://api.github.com/repos/harvesthq/chosen/commits{/sha}","git_commits_url":"https://api.github.com/repos/harvesthq/chosen/git/commits{/sha}","comments_url":"https://api.github.com/repos/harvesthq/chosen/comments{/number}","issue_comment_url":"https://api.github.com/repos/harvesthq/chosen/issues/comments{/number}","contents_url":"https://api.github.com/repos/harvesthq/chosen/contents/{+path}","compare_url":"https://api.github.com/repos/harvesthq/chosen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harvesthq/chosen/merges","archive_url":"https://api.github.com/repos/harvesthq/chosen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harvesthq/chosen/downloads","issues_url":"https://api.github.com/repos/harvesthq/chosen/issues{/number}","pulls_url":"https://api.github.com/repos/harvesthq/chosen/pulls{/number}","milestones_url":"https://api.github.com/repos/harvesthq/chosen/milestones{/number}","notifications_url":"https://api.github.com/repos/harvesthq/chosen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harvesthq/chosen/labels{/name}","releases_url":"https://api.github.com/repos/harvesthq/chosen/releases{/id}","deployments_url":"https://api.github.com/repos/harvesthq/chosen/deployments","created_at":"2011-04-18T15:07:41Z","updated_at":"2016-10-17T14:10:09Z","pushed_at":"2016-10-16T10:13:59Z","git_url":"git://github.com/harvesthq/chosen.git","ssh_url":"git@github.com:harvesthq/chosen.git","clone_url":"https://github.com/harvesthq/chosen.git","svn_url":"https://github.com/harvesthq/chosen","homepage":"http://harvesthq.github.io/chosen/","size":7074,"stargazers_count":20039,"watchers_count":20039,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3878,"mirror_url":null,"open_issues_count":148,"forks":3878,"open_issues":148,"watchers":20039,"default_branch":"master"}},"base":{"label":"harvesthq:master","ref":"master","sha":"f2fe103ef6ca7e6b6d1e59e8eafef66670f9e4ab","user":{"login":"harvesthq","id":43635,"avatar_url":"https://avatars.githubusercontent.com/u/43635?v=3","gravatar_id":"","url":"https://api.github.com/users/harvesthq","html_url":"https://github.com/harvesthq","followers_url":"https://api.github.com/users/harvesthq/followers","following_url":"https://api.github.com/users/harvesthq/following{/other_user}","gists_url":"https://api.github.com/users/harvesthq/gists{/gist_id}","starred_url":"https://api.github.com/users/harvesthq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harvesthq/subscriptions","organizations_url":"https://api.github.com/users/harvesthq/orgs","repos_url":"https://api.github.com/users/harvesthq/repos","events_url":"https://api.github.com/users/harvesthq/events{/privacy}","received_events_url":"https://api.github.com/users/harvesthq/received_events","type":"Organization","site_admin":false},"repo":{"id":1631024,"name":"chosen","full_name":"harvesthq/chosen","owner":{"login":"harvesthq","id":43635,"avatar_url":"https://avatars.githubusercontent.com/u/43635?v=3","gravatar_id":"","url":"https://api.github.com/users/harvesthq","html_url":"https://github.com/harvesthq","followers_url":"https://api.github.com/users/harvesthq/followers","following_url":"https://api.github.com/users/harvesthq/following{/other_user}","gists_url":"https://api.github.com/users/harvesthq/gists{/gist_id}","starred_url":"https://api.github.com/users/harvesthq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harvesthq/subscriptions","organizations_url":"https://api.github.com/users/harvesthq/orgs","repos_url":"https://api.github.com/users/harvesthq/repos","events_url":"https://api.github.com/users/harvesthq/events{/privacy}","received_events_url":"https://api.github.com/users/harvesthq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/harvesthq/chosen","description":"Chosen is a library for making long, unwieldy select boxes more friendly.","fork":false,"url":"https://api.github.com/repos/harvesthq/chosen","forks_url":"https://api.github.com/repos/harvesthq/chosen/forks","keys_url":"https://api.github.com/repos/harvesthq/chosen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harvesthq/chosen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harvesthq/chosen/teams","hooks_url":"https://api.github.com/repos/harvesthq/chosen/hooks","issue_events_url":"https://api.github.com/repos/harvesthq/chosen/issues/events{/number}","events_url":"https://api.github.com/repos/harvesthq/chosen/events","assignees_url":"https://api.github.com/repos/harvesthq/chosen/assignees{/user}","branches_url":"https://api.github.com/repos/harvesthq/chosen/branches{/branch}","tags_url":"https://api.github.com/repos/harvesthq/chosen/tags","blobs_url":"https://api.github.com/repos/harvesthq/chosen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harvesthq/chosen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harvesthq/chosen/git/refs{/sha}","trees_url":"https://api.github.com/repos/harvesthq/chosen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harvesthq/chosen/statuses/{sha}","languages_url":"https://api.github.com/repos/harvesthq/chosen/languages","stargazers_url":"https://api.github.com/repos/harvesthq/chosen/stargazers","contributors_url":"https://api.github.com/repos/harvesthq/chosen/contributors","subscribers_url":"https://api.github.com/repos/harvesthq/chosen/subscribers","subscription_url":"https://api.github.com/repos/harvesthq/chosen/subscription","commits_url":"https://api.github.com/repos/harvesthq/chosen/commits{/sha}","git_commits_url":"https://api.github.com/repos/harvesthq/chosen/git/commits{/sha}","comments_url":"https://api.github.com/repos/harvesthq/chosen/comments{/number}","issue_comment_url":"https://api.github.com/repos/harvesthq/chosen/issues/comments{/number}","contents_url":"https://api.github.com/repos/harvesthq/chosen/contents/{+path}","compare_url":"https://api.github.com/repos/harvesthq/chosen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harvesthq/chosen/merges","archive_url":"https://api.github.com/repos/harvesthq/chosen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harvesthq/chosen/downloads","issues_url":"https://api.github.com/repos/harvesthq/chosen/issues{/number}","pulls_url":"https://api.github.com/repos/harvesthq/chosen/pulls{/number}","milestones_url":"https://api.github.com/repos/harvesthq/chosen/milestones{/number}","notifications_url":"https://api.github.com/repos/harvesthq/chosen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harvesthq/chosen/labels{/name}","releases_url":"https://api.github.com/repos/harvesthq/chosen/releases{/id}","deployments_url":"https://api.github.com/repos/harvesthq/chosen/deployments","created_at":"2011-04-18T15:07:41Z","updated_at":"2016-10-17T14:10:09Z","pushed_at":"2016-10-16T10:13:59Z","git_url":"git://github.com/harvesthq/chosen.git","ssh_url":"git@github.com:harvesthq/chosen.git","clone_url":"https://github.com/harvesthq/chosen.git","svn_url":"https://github.com/harvesthq/chosen","homepage":"http://harvesthq.github.io/chosen/","size":7074,"stargazers_count":20039,"watchers_count":20039,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3878,"mirror_url":null,"open_issues_count":148,"forks":3878,"open_issues":148,"watchers":20039,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/harvesthq/chosen/pulls/2726"},"html":{"href":"https://github.com/harvesthq/chosen/pull/2726"},"issue":{"href":"https://api.github.com/repos/harvesthq/chosen/issues/2726"},"comments":{"href":"https://api.github.com/repos/harvesthq/chosen/issues/2726/comments"},"review_comments":{"href":"https://api.github.com/repos/harvesthq/chosen/pulls/2726/comments"},"review_comment":{"href":"https://api.github.com/repos/harvesthq/chosen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/harvesthq/chosen/pulls/2726/commits"},"statuses":{"href":"https://api.github.com/repos/harvesthq/chosen/statuses/1eec4b1754f0839e2b8d8d9aa3fb88e98cd0fd8b"}}}}
{"actor":{"display_login":"mlettini"}}