{"action":"created","comment":{"url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/comments/64410239","id":64410239,"diff_hunk":"@@ -190,50 +190,56 @@ public final RowFormatter getRowFormatter(\n       @Unretained final OffHeapByteSource vbytes) {\n     // if this is for the latest schema, then vbytes must have the same schema\n     // else we may need to read vbytes to get the schema it represents\n-    if (this.isLatestSchema) {\n-      assert getSchemaVersionFromValueBytes(vbytes) == formatter.schemaVersion:\n-        \"mismatch of versions: formatter=\" + formatter.schemaVersion\n-            + \", fromBytes=\" + getSchemaVersionFromValueBytes(vbytes);\n-\n-      return this.formatter;\n-    }\n-    else {\n-      return this.container.getRowFormatter(vbytes);\n-    }\n+    // Disabling this optimization for bug SNAP-766\n+//    if (this.isLatestSchema) {\n+//      assert getSchemaVersionFromValueBytes(vbytes) == formatter.schemaVersion:\n+//        \"mismatch of versions: formatter=\" + formatter.schemaVersion\n+//            + \", fromBytes=\" + getSchemaVersionFromValueBytes(vbytes);\n+//\n+//      return this.formatter;\n+//    }\n+//    else {\n+//      return this.container.getRowFormatter(vbytes);\n+//    }\n+    return this.container.getRowFormatter(vbytes);","path":"gemfirexd/core/src/main/java/com/pivotal/gemfirexd/internal/engine/sql/catalog/ExtraTableInfo.java","position":25,"original_position":25,"commit_id":"d71c61fd8bbb450c0558e39a26cdfaa26ce6adc5","original_commit_id":"d71c61fd8bbb450c0558e39a26cdfaa26ce6adc5","user":{"login":"kneeraj","id":1151021,"avatar_url":"https://avatars.githubusercontent.com/u/1151021?v=3","gravatar_id":"","url":"https://api.github.com/users/kneeraj","html_url":"https://github.com/kneeraj","followers_url":"https://api.github.com/users/kneeraj/followers","following_url":"https://api.github.com/users/kneeraj/following{/other_user}","gists_url":"https://api.github.com/users/kneeraj/gists{/gist_id}","starred_url":"https://api.github.com/users/kneeraj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kneeraj/subscriptions","organizations_url":"https://api.github.com/users/kneeraj/orgs","repos_url":"https://api.github.com/users/kneeraj/repos","events_url":"https://api.github.com/users/kneeraj/events{/privacy}","received_events_url":"https://api.github.com/users/kneeraj/received_events","type":"User","site_admin":false},"body":"The bug related to this has not been closed but deferred from 0.5","created_at":"2016-05-24T15:09:38Z","updated_at":"2016-05-24T15:09:38Z","html_url":"https://github.com/SnappyDataInc/snappy-store/pull/55#discussion_r64410239","pull_request_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/comments/64410239"},"html":{"href":"https://github.com/SnappyDataInc/snappy-store/pull/55#discussion_r64410239"},"pull_request":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/55","id":68566253,"html_url":"https://github.com/SnappyDataInc/snappy-store/pull/55","diff_url":"https://github.com/SnappyDataInc/snappy-store/pull/55.diff","patch_url":"https://github.com/SnappyDataInc/snappy-store/pull/55.patch","issue_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/55","number":55,"state":"open","locked":false,"title":"Delaying sending abnormal memory event send","user":{"login":"kneeraj","id":1151021,"avatar_url":"https://avatars.githubusercontent.com/u/1151021?v=3","gravatar_id":"","url":"https://api.github.com/users/kneeraj","html_url":"https://github.com/kneeraj","followers_url":"https://api.github.com/users/kneeraj/followers","following_url":"https://api.github.com/users/kneeraj/following{/other_user}","gists_url":"https://api.github.com/users/kneeraj/gists{/gist_id}","starred_url":"https://api.github.com/users/kneeraj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kneeraj/subscriptions","organizations_url":"https://api.github.com/users/kneeraj/orgs","repos_url":"https://api.github.com/users/kneeraj/repos","events_url":"https://api.github.com/users/kneeraj/events{/privacy}","received_events_url":"https://api.github.com/users/kneeraj/received_events","type":"User","site_admin":false},"body":"## Changes proposed in this pull request\r\n\r\nDelaying the sending of abnormal memory event for some time as an inexplicable\r\nspike in tenured heap space is being seen which is failing operations owing to\r\nLowMemoryException. The sampler thread delegates this to a separate thread when it comes to poll the heap for the first time.\r\n\r\n@rk-geode you also please look at the changes.\r\n## Patch testing\r\n\r\ntpcc perf test which was failing with this exception passes now even if spike comes.\r\n## Other PRs \r\n\r\n(Does this change required changes in other projects- snappyData, spark, spark-jobserver, aqp? Add the links of PR of the other subprojects that are related to this change)\r\n\r\n…","created_at":"2016-05-02T14:21:22Z","updated_at":"2016-05-24T15:09:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7d5d0958b7767f26f12452a2165ecec0563e8e2","assignee":{"login":"sumwale","id":11540628,"avatar_url":"https://avatars.githubusercontent.com/u/11540628?v=3","gravatar_id":"","url":"https://api.github.com/users/sumwale","html_url":"https://github.com/sumwale","followers_url":"https://api.github.com/users/sumwale/followers","following_url":"https://api.github.com/users/sumwale/following{/other_user}","gists_url":"https://api.github.com/users/sumwale/gists{/gist_id}","starred_url":"https://api.github.com/users/sumwale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumwale/subscriptions","organizations_url":"https://api.github.com/users/sumwale/orgs","repos_url":"https://api.github.com/users/sumwale/repos","events_url":"https://api.github.com/users/sumwale/events{/privacy}","received_events_url":"https://api.github.com/users/sumwale/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/55/commits","review_comments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/55/comments","review_comment_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/55/comments","statuses_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/statuses/d71c61fd8bbb450c0558e39a26cdfaa26ce6adc5","head":{"label":"SnappyDataInc:SNAP-728","ref":"SNAP-728","sha":"d71c61fd8bbb450c0558e39a26cdfaa26ce6adc5","user":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars.githubusercontent.com/u/11342682?v=3","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"repo":{"id":48800286,"name":"snappy-store","full_name":"SnappyDataInc/snappy-store","owner":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars.githubusercontent.com/u/11342682?v=3","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SnappyDataInc/snappy-store","description":"SnappyStore","fork":true,"url":"https://api.github.com/repos/SnappyDataInc/snappy-store","forks_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/forks","keys_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/teams","hooks_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/hooks","issue_events_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/events{/number}","events_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/events","assignees_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/assignees{/user}","branches_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/branches{/branch}","tags_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/tags","blobs_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/statuses/{sha}","languages_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/languages","stargazers_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/stargazers","contributors_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/contributors","subscribers_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/subscribers","subscription_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/subscription","commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/contents/{+path}","compare_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/merges","archive_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/downloads","issues_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues{/number}","pulls_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls{/number}","milestones_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/milestones{/number}","notifications_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/labels{/name}","releases_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/releases{/id}","deployments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/deployments","created_at":"2015-12-30T12:44:56Z","updated_at":"2016-04-22T19:15:21Z","pushed_at":"2016-05-24T14:22:33Z","git_url":"git://github.com/SnappyDataInc/snappy-store.git","ssh_url":"git@github.com:SnappyDataInc/snappy-store.git","clone_url":"https://github.com/SnappyDataInc/snappy-store.git","svn_url":"https://github.com/SnappyDataInc/snappy-store","homepage":"","size":115606,"stargazers_count":22,"watchers_count":22,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":10,"forks":4,"open_issues":10,"watchers":22,"default_branch":"snappy/master"}},"base":{"label":"SnappyDataInc:snappy/master","ref":"snappy/master","sha":"a11d93b7f98db38d82408e65bd041b643e5c9658","user":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars.githubusercontent.com/u/11342682?v=3","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"repo":{"id":48800286,"name":"snappy-store","full_name":"SnappyDataInc/snappy-store","owner":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars.githubusercontent.com/u/11342682?v=3","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SnappyDataInc/snappy-store","description":"SnappyStore","fork":true,"url":"https://api.github.com/repos/SnappyDataInc/snappy-store","forks_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/forks","keys_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/teams","hooks_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/hooks","issue_events_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/events{/number}","events_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/events","assignees_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/assignees{/user}","branches_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/branches{/branch}","tags_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/tags","blobs_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/statuses/{sha}","languages_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/languages","stargazers_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/stargazers","contributors_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/contributors","subscribers_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/subscribers","subscription_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/subscription","commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/contents/{+path}","compare_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/merges","archive_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/downloads","issues_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues{/number}","pulls_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls{/number}","milestones_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/milestones{/number}","notifications_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/labels{/name}","releases_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/releases{/id}","deployments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/deployments","created_at":"2015-12-30T12:44:56Z","updated_at":"2016-04-22T19:15:21Z","pushed_at":"2016-05-24T14:22:33Z","git_url":"git://github.com/SnappyDataInc/snappy-store.git","ssh_url":"git@github.com:SnappyDataInc/snappy-store.git","clone_url":"https://github.com/SnappyDataInc/snappy-store.git","svn_url":"https://github.com/SnappyDataInc/snappy-store","homepage":"","size":115606,"stargazers_count":22,"watchers_count":22,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":10,"forks":4,"open_issues":10,"watchers":22,"default_branch":"snappy/master"}},"_links":{"self":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/55"},"html":{"href":"https://github.com/SnappyDataInc/snappy-store/pull/55"},"issue":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/55"},"comments":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/statuses/d71c61fd8bbb450c0558e39a26cdfaa26ce6adc5"}}}}
{"actor":{"display_login":"kneeraj"}}