{"action":"created","comment":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/comments/74970588","id":74970588,"diff_hunk":"@@ -144,6 +144,7 @@\n   String UNIT_TYPE_CARRIER = \"carrier\";\n   String UNIT_TYPE_FIGHTER = \"fighter\";\n   String UNIT_TYPE_BOMBER = \"bomber\";\n+  String UNIT_TYPE_TAC_BOMBER = \"tactical_bomber\";","path":"src/games/strategy/triplea/Constants.java","position":4,"original_position":4,"commit_id":"8ea5805771129fc47cef5496cc24499b01d1ce5a","original_commit_id":"8ea5805771129fc47cef5496cc24499b01d1ce5a","user":{"login":"DanVanAtta","id":12397753,"avatar_url":"https://avatars.githubusercontent.com/u/12397753?v=3","gravatar_id":"","url":"https://api.github.com/users/DanVanAtta","html_url":"https://github.com/DanVanAtta","followers_url":"https://api.github.com/users/DanVanAtta/followers","following_url":"https://api.github.com/users/DanVanAtta/following{/other_user}","gists_url":"https://api.github.com/users/DanVanAtta/gists{/gist_id}","starred_url":"https://api.github.com/users/DanVanAtta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanVanAtta/subscriptions","organizations_url":"https://api.github.com/users/DanVanAtta/orgs","repos_url":"https://api.github.com/users/DanVanAtta/repos","events_url":"https://api.github.com/users/DanVanAtta/events{/privacy}","received_events_url":"https://api.github.com/users/DanVanAtta/received_events","type":"User","site_admin":false},"body":"This value is only used in TestUtil, please move it there.\r\nNot only that, the 'Constants.java' is not a very good design, I'd like to avoid adding to it.","created_at":"2016-08-16T16:31:51Z","updated_at":"2016-08-16T16:31:51Z","html_url":"https://github.com/triplea-game/triplea/pull/1074#discussion_r74970588","pull_request_url":"https://api.github.com/repos/triplea-game/triplea/pulls/1074","_links":{"self":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/comments/74970588"},"html":{"href":"https://github.com/triplea-game/triplea/pull/1074#discussion_r74970588"},"pull_request":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/1074"}}},"pull_request":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/1074","id":81439860,"html_url":"https://github.com/triplea-game/triplea/pull/1074","diff_url":"https://github.com/triplea-game/triplea/pull/1074.diff","patch_url":"https://github.com/triplea-game/triplea/pull/1074.patch","issue_url":"https://api.github.com/repos/triplea-game/triplea/issues/1074","number":1074,"state":"open","locked":false,"title":"Strategic bombing bug fix","user":{"login":"simon33-2","id":20733860,"avatar_url":"https://avatars.githubusercontent.com/u/20733860?v=3","gravatar_id":"","url":"https://api.github.com/users/simon33-2","html_url":"https://github.com/simon33-2","followers_url":"https://api.github.com/users/simon33-2/followers","following_url":"https://api.github.com/users/simon33-2/following{/other_user}","gists_url":"https://api.github.com/users/simon33-2/gists{/gist_id}","starred_url":"https://api.github.com/users/simon33-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon33-2/subscriptions","organizations_url":"https://api.github.com/users/simon33-2/orgs","repos_url":"https://api.github.com/users/simon33-2/repos","events_url":"https://api.github.com/users/simon33-2/events{/privacy}","received_events_url":"https://api.github.com/users/simon33-2/received_events","type":"User","site_admin":false},"body":"Hi,\r\nThis change appears to work to me but has testing errors as I've noted in issue #1066 \r\n\r\nI can't quite get the unit test right. I'm not sure how to allocate the attackers and targets together. Unlike all other combats, this is really multiple combats in the same territory resolved separately. That is the bug, if you prefer it being put that way.\r\n\r\nIf accepted, we'll also have to update the notes in the maps which say this doesn't work (and no reasonable work around).\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/triplea-game/triplea/1074)\n<!-- Reviewable:end -->\n","created_at":"2016-08-16T09:25:20Z","updated_at":"2016-08-16T16:31:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51109cdc5bf868fca4265a514f6f1aecf30494a0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/triplea-game/triplea/pulls/1074/commits","review_comments_url":"https://api.github.com/repos/triplea-game/triplea/pulls/1074/comments","review_comment_url":"https://api.github.com/repos/triplea-game/triplea/pulls/comments{/number}","comments_url":"https://api.github.com/repos/triplea-game/triplea/issues/1074/comments","statuses_url":"https://api.github.com/repos/triplea-game/triplea/statuses/8ea5805771129fc47cef5496cc24499b01d1ce5a","head":{"label":"simon33-2:master","ref":"master","sha":"8ea5805771129fc47cef5496cc24499b01d1ce5a","user":{"login":"simon33-2","id":20733860,"avatar_url":"https://avatars.githubusercontent.com/u/20733860?v=3","gravatar_id":"","url":"https://api.github.com/users/simon33-2","html_url":"https://github.com/simon33-2","followers_url":"https://api.github.com/users/simon33-2/followers","following_url":"https://api.github.com/users/simon33-2/following{/other_user}","gists_url":"https://api.github.com/users/simon33-2/gists{/gist_id}","starred_url":"https://api.github.com/users/simon33-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon33-2/subscriptions","organizations_url":"https://api.github.com/users/simon33-2/orgs","repos_url":"https://api.github.com/users/simon33-2/repos","events_url":"https://api.github.com/users/simon33-2/events{/privacy}","received_events_url":"https://api.github.com/users/simon33-2/received_events","type":"User","site_admin":false},"repo":{"id":65304386,"name":"triplea","full_name":"simon33-2/triplea","owner":{"login":"simon33-2","id":20733860,"avatar_url":"https://avatars.githubusercontent.com/u/20733860?v=3","gravatar_id":"","url":"https://api.github.com/users/simon33-2","html_url":"https://github.com/simon33-2","followers_url":"https://api.github.com/users/simon33-2/followers","following_url":"https://api.github.com/users/simon33-2/following{/other_user}","gists_url":"https://api.github.com/users/simon33-2/gists{/gist_id}","starred_url":"https://api.github.com/users/simon33-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon33-2/subscriptions","organizations_url":"https://api.github.com/users/simon33-2/orgs","repos_url":"https://api.github.com/users/simon33-2/repos","events_url":"https://api.github.com/users/simon33-2/events{/privacy}","received_events_url":"https://api.github.com/users/simon33-2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simon33-2/triplea","description":"TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.","fork":true,"url":"https://api.github.com/repos/simon33-2/triplea","forks_url":"https://api.github.com/repos/simon33-2/triplea/forks","keys_url":"https://api.github.com/repos/simon33-2/triplea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simon33-2/triplea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simon33-2/triplea/teams","hooks_url":"https://api.github.com/repos/simon33-2/triplea/hooks","issue_events_url":"https://api.github.com/repos/simon33-2/triplea/issues/events{/number}","events_url":"https://api.github.com/repos/simon33-2/triplea/events","assignees_url":"https://api.github.com/repos/simon33-2/triplea/assignees{/user}","branches_url":"https://api.github.com/repos/simon33-2/triplea/branches{/branch}","tags_url":"https://api.github.com/repos/simon33-2/triplea/tags","blobs_url":"https://api.github.com/repos/simon33-2/triplea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simon33-2/triplea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simon33-2/triplea/git/refs{/sha}","trees_url":"https://api.github.com/repos/simon33-2/triplea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simon33-2/triplea/statuses/{sha}","languages_url":"https://api.github.com/repos/simon33-2/triplea/languages","stargazers_url":"https://api.github.com/repos/simon33-2/triplea/stargazers","contributors_url":"https://api.github.com/repos/simon33-2/triplea/contributors","subscribers_url":"https://api.github.com/repos/simon33-2/triplea/subscribers","subscription_url":"https://api.github.com/repos/simon33-2/triplea/subscription","commits_url":"https://api.github.com/repos/simon33-2/triplea/commits{/sha}","git_commits_url":"https://api.github.com/repos/simon33-2/triplea/git/commits{/sha}","comments_url":"https://api.github.com/repos/simon33-2/triplea/comments{/number}","issue_comment_url":"https://api.github.com/repos/simon33-2/triplea/issues/comments{/number}","contents_url":"https://api.github.com/repos/simon33-2/triplea/contents/{+path}","compare_url":"https://api.github.com/repos/simon33-2/triplea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simon33-2/triplea/merges","archive_url":"https://api.github.com/repos/simon33-2/triplea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simon33-2/triplea/downloads","issues_url":"https://api.github.com/repos/simon33-2/triplea/issues{/number}","pulls_url":"https://api.github.com/repos/simon33-2/triplea/pulls{/number}","milestones_url":"https://api.github.com/repos/simon33-2/triplea/milestones{/number}","notifications_url":"https://api.github.com/repos/simon33-2/triplea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simon33-2/triplea/labels{/name}","releases_url":"https://api.github.com/repos/simon33-2/triplea/releases{/id}","deployments_url":"https://api.github.com/repos/simon33-2/triplea/deployments","created_at":"2016-08-09T15:03:19Z","updated_at":"2016-08-09T15:03:28Z","pushed_at":"2016-08-16T09:20:55Z","git_url":"git://github.com/simon33-2/triplea.git","ssh_url":"git@github.com:simon33-2/triplea.git","clone_url":"https://github.com/simon33-2/triplea.git","svn_url":"https://github.com/simon33-2/triplea","homepage":null,"size":707177,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"triplea-game:master","ref":"master","sha":"f61ba8dfe67cb1055fecda0871021d916670b334","user":{"login":"triplea-game","id":13318615,"avatar_url":"https://avatars.githubusercontent.com/u/13318615?v=3","gravatar_id":"","url":"https://api.github.com/users/triplea-game","html_url":"https://github.com/triplea-game","followers_url":"https://api.github.com/users/triplea-game/followers","following_url":"https://api.github.com/users/triplea-game/following{/other_user}","gists_url":"https://api.github.com/users/triplea-game/gists{/gist_id}","starred_url":"https://api.github.com/users/triplea-game/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triplea-game/subscriptions","organizations_url":"https://api.github.com/users/triplea-game/orgs","repos_url":"https://api.github.com/users/triplea-game/repos","events_url":"https://api.github.com/users/triplea-game/events{/privacy}","received_events_url":"https://api.github.com/users/triplea-game/received_events","type":"Organization","site_admin":false},"repo":{"id":39766308,"name":"triplea","full_name":"triplea-game/triplea","owner":{"login":"triplea-game","id":13318615,"avatar_url":"https://avatars.githubusercontent.com/u/13318615?v=3","gravatar_id":"","url":"https://api.github.com/users/triplea-game","html_url":"https://github.com/triplea-game","followers_url":"https://api.github.com/users/triplea-game/followers","following_url":"https://api.github.com/users/triplea-game/following{/other_user}","gists_url":"https://api.github.com/users/triplea-game/gists{/gist_id}","starred_url":"https://api.github.com/users/triplea-game/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triplea-game/subscriptions","organizations_url":"https://api.github.com/users/triplea-game/orgs","repos_url":"https://api.github.com/users/triplea-game/repos","events_url":"https://api.github.com/users/triplea-game/events{/privacy}","received_events_url":"https://api.github.com/users/triplea-game/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/triplea-game/triplea","description":"TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.","fork":false,"url":"https://api.github.com/repos/triplea-game/triplea","forks_url":"https://api.github.com/repos/triplea-game/triplea/forks","keys_url":"https://api.github.com/repos/triplea-game/triplea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/triplea-game/triplea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/triplea-game/triplea/teams","hooks_url":"https://api.github.com/repos/triplea-game/triplea/hooks","issue_events_url":"https://api.github.com/repos/triplea-game/triplea/issues/events{/number}","events_url":"https://api.github.com/repos/triplea-game/triplea/events","assignees_url":"https://api.github.com/repos/triplea-game/triplea/assignees{/user}","branches_url":"https://api.github.com/repos/triplea-game/triplea/branches{/branch}","tags_url":"https://api.github.com/repos/triplea-game/triplea/tags","blobs_url":"https://api.github.com/repos/triplea-game/triplea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/triplea-game/triplea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/triplea-game/triplea/git/refs{/sha}","trees_url":"https://api.github.com/repos/triplea-game/triplea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/triplea-game/triplea/statuses/{sha}","languages_url":"https://api.github.com/repos/triplea-game/triplea/languages","stargazers_url":"https://api.github.com/repos/triplea-game/triplea/stargazers","contributors_url":"https://api.github.com/repos/triplea-game/triplea/contributors","subscribers_url":"https://api.github.com/repos/triplea-game/triplea/subscribers","subscription_url":"https://api.github.com/repos/triplea-game/triplea/subscription","commits_url":"https://api.github.com/repos/triplea-game/triplea/commits{/sha}","git_commits_url":"https://api.github.com/repos/triplea-game/triplea/git/commits{/sha}","comments_url":"https://api.github.com/repos/triplea-game/triplea/comments{/number}","issue_comment_url":"https://api.github.com/repos/triplea-game/triplea/issues/comments{/number}","contents_url":"https://api.github.com/repos/triplea-game/triplea/contents/{+path}","compare_url":"https://api.github.com/repos/triplea-game/triplea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/triplea-game/triplea/merges","archive_url":"https://api.github.com/repos/triplea-game/triplea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/triplea-game/triplea/downloads","issues_url":"https://api.github.com/repos/triplea-game/triplea/issues{/number}","pulls_url":"https://api.github.com/repos/triplea-game/triplea/pulls{/number}","milestones_url":"https://api.github.com/repos/triplea-game/triplea/milestones{/number}","notifications_url":"https://api.github.com/repos/triplea-game/triplea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/triplea-game/triplea/labels{/name}","releases_url":"https://api.github.com/repos/triplea-game/triplea/releases{/id}","deployments_url":"https://api.github.com/repos/triplea-game/triplea/deployments","created_at":"2015-07-27T09:32:58Z","updated_at":"2016-07-28T03:58:42Z","pushed_at":"2016-08-16T09:25:25Z","git_url":"git://github.com/triplea-game/triplea.git","ssh_url":"git@github.com:triplea-game/triplea.git","clone_url":"https://github.com/triplea-game/triplea.git","svn_url":"https://github.com/triplea-game/triplea","homepage":null,"size":717182,"stargazers_count":24,"watchers_count":24,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":122,"forks":17,"open_issues":122,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/1074"},"html":{"href":"https://github.com/triplea-game/triplea/pull/1074"},"issue":{"href":"https://api.github.com/repos/triplea-game/triplea/issues/1074"},"comments":{"href":"https://api.github.com/repos/triplea-game/triplea/issues/1074/comments"},"review_comments":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/1074/comments"},"review_comment":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/1074/commits"},"statuses":{"href":"https://api.github.com/repos/triplea-game/triplea/statuses/8ea5805771129fc47cef5496cc24499b01d1ce5a"}}}}
{"actor":{"display_login":"DanVanAtta"}}