{"action":"created","issue":{"url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/116","repository_url":"https://api.github.com/repos/AtheMathmo/rusty-machine","labels_url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/116/labels{/name}","comments_url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/116/comments","events_url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/116/events","html_url":"https://github.com/AtheMathmo/rusty-machine/pull/116","id":169294525,"number":116,"title":"Adding min-max scaling transform for preprocessing","user":{"login":"AtheMathmo","id":10150986,"avatar_url":"https://avatars.githubusercontent.com/u/10150986?v=3","gravatar_id":"","url":"https://api.github.com/users/AtheMathmo","html_url":"https://github.com/AtheMathmo","followers_url":"https://api.github.com/users/AtheMathmo/followers","following_url":"https://api.github.com/users/AtheMathmo/following{/other_user}","gists_url":"https://api.github.com/users/AtheMathmo/gists{/gist_id}","starred_url":"https://api.github.com/users/AtheMathmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtheMathmo/subscriptions","organizations_url":"https://api.github.com/users/AtheMathmo/orgs","repos_url":"https://api.github.com/users/AtheMathmo/repos","events_url":"https://api.github.com/users/AtheMathmo/events{/privacy}","received_events_url":"https://api.github.com/users/AtheMathmo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-04T05:32:50Z","updated_at":"2016-08-05T14:43:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AtheMathmo/rusty-machine/pulls/116","html_url":"https://github.com/AtheMathmo/rusty-machine/pull/116","diff_url":"https://github.com/AtheMathmo/rusty-machine/pull/116.diff","patch_url":"https://github.com/AtheMathmo/rusty-machine/pull/116.patch"},"body":"This is a work in progress but I'm opening for feedback now. This will eventually resolve #112 .\r\n\r\nIn order to complete this PR I need to do the following:\r\n\r\n- Implement a scaler for zero centering and unit variance.\r\n- Add error handling in min/max case when column is a constant feature. I think for now just fail gracefully..?\r\n- Add better documentation and review module layout."},"comment":{"url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/comments/237869258","html_url":"https://github.com/AtheMathmo/rusty-machine/pull/116#issuecomment-237869258","issue_url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/116","id":237869258,"user":{"login":"tafia","id":7351502,"avatar_url":"https://avatars.githubusercontent.com/u/7351502?v=3","gravatar_id":"","url":"https://api.github.com/users/tafia","html_url":"https://github.com/tafia","followers_url":"https://api.github.com/users/tafia/followers","following_url":"https://api.github.com/users/tafia/following{/other_user}","gists_url":"https://api.github.com/users/tafia/gists{/gist_id}","starred_url":"https://api.github.com/users/tafia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tafia/subscriptions","organizations_url":"https://api.github.com/users/tafia/orgs","repos_url":"https://api.github.com/users/tafia/repos","events_url":"https://api.github.com/users/tafia/events{/privacy}","received_events_url":"https://api.github.com/users/tafia/received_events","type":"User","site_admin":false},"created_at":"2016-08-05T14:43:23Z","updated_at":"2016-08-05T14:43:23Z","body":"I am busy at the moment. I'll have another look tomorrow.\nFeel free to merge I'll open an issue if needed.\n\nOn 5 Aug 2016 22:30, \"James Lucas\" <notifications@github.com> wrote:\n\n> @tafia <https://github.com/tafia> - does the rest of this PR look ok to\n> you? If so I'll merge.\n>\n> It doesn't feel quite right to me but is a good first draft for people to\n> try out.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/AtheMathmo/rusty-machine/pull/116#issuecomment-237865800>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AHAszo6BaFG7hkcl0qBlC-bfXGWhEraCks5qc0j6gaJpZM4JcWpY>\n> .\n>\n"}}
{"actor":{"display_login":"tafia"}}