{"action":"created","comment":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/68834865","id":68834865,"diff_hunk":"@@ -53,10 +59,11 @@\n \n   @BeforeClass\n   public static final void beforeClass() throws Exception {\n-    FileSystem fileSystem = sLocalAlluxioClusterResource.get().getClient();\n+    sFileSystem = sLocalAlluxioClusterResource.get().getClient();\n     FileSystemTestUtils\n-        .createByteFile(fileSystem, \"/testFile1\", WriteType.CACHE_THROUGH, FILE_LEN);\n-    FileSystemTestUtils.createByteFile(fileSystem, \"/testFile2\", WriteType.THROUGH, FILE_LEN);\n+        .createByteFile(sFileSystem, \"/testFile1\", WriteType.CACHE_THROUGH, FILE_LEN);","path":"tests/src/test/java/alluxio/hadoop/HdfsFileInputStreamIntegrationTest.java","position":33,"original_position":33,"commit_id":"63f3adfab1dd40c733cf144b1ad557f2a601b801","original_commit_id":"63f3adfab1dd40c733cf144b1ad557f2a601b801","user":{"login":"aaudiber","id":3455177,"avatar_url":"https://avatars.githubusercontent.com/u/3455177?v=3","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"body":"These test files are shared mutable resources, so they shouldn't be created statically because then tests will interfere with each other. Could we move the test file creation to the `@Before`? Also, we should name them better as `inMemoryFile` and `ufsOnlyFile`, and define those names as static constants. To avoid collisions we could either delete the files in `@After` or add salt to make the names unique during each test, e.g. adding a random number from a large range or a UUID.\r\n\r\nIf we make these changes you won't need to add testFile3 any longer","created_at":"2016-06-28T20:19:34Z","updated_at":"2016-06-28T20:19:34Z","html_url":"https://github.com/Alluxio/alluxio/pull/3592#discussion_r68834865","pull_request_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/3592","_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/68834865"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/3592#discussion_r68834865"},"pull_request":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/3592"}}},"pull_request":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/3592","id":75102675,"html_url":"https://github.com/Alluxio/alluxio/pull/3592","diff_url":"https://github.com/Alluxio/alluxio/pull/3592.diff","patch_url":"https://github.com/Alluxio/alluxio/pull/3592.patch","issue_url":"https://api.github.com/repos/Alluxio/alluxio/issues/3592","number":3592,"state":"open","locked":false,"title":"[SMALLFIX] Remove the hardcoded read type (CACHE) from HdfsFileInputStream","user":{"login":"pfxuan","id":2773827,"avatar_url":"https://avatars.githubusercontent.com/u/2773827?v=3","gravatar_id":"","url":"https://api.github.com/users/pfxuan","html_url":"https://github.com/pfxuan","followers_url":"https://api.github.com/users/pfxuan/followers","following_url":"https://api.github.com/users/pfxuan/following{/other_user}","gists_url":"https://api.github.com/users/pfxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/pfxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfxuan/subscriptions","organizations_url":"https://api.github.com/users/pfxuan/orgs","repos_url":"https://api.github.com/users/pfxuan/repos","events_url":"https://api.github.com/users/pfxuan/events{/privacy}","received_events_url":"https://api.github.com/users/pfxuan/received_events","type":"User","site_admin":false},"body":"Right now, the read type of `HdfsFileInputStream` is hardcoded and can not accept the user's specification defined in configuration file `alluxio-site.properties`. This PR is used to activate the setting of `alluxio.user.file.readtype.default` for Hadoop and Spark workloads.","created_at":"2016-06-24T11:49:14Z","updated_at":"2016-06-28T20:19:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4eca00229ccb886ad24ec9fcfc5326316757946d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/3592/commits","review_comments_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/3592/comments","review_comment_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/issues/3592/comments","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/63f3adfab1dd40c733cf144b1ad557f2a601b801","head":{"label":"pfxuan:patch-5","ref":"patch-5","sha":"63f3adfab1dd40c733cf144b1ad557f2a601b801","user":{"login":"pfxuan","id":2773827,"avatar_url":"https://avatars.githubusercontent.com/u/2773827?v=3","gravatar_id":"","url":"https://api.github.com/users/pfxuan","html_url":"https://github.com/pfxuan","followers_url":"https://api.github.com/users/pfxuan/followers","following_url":"https://api.github.com/users/pfxuan/following{/other_user}","gists_url":"https://api.github.com/users/pfxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/pfxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfxuan/subscriptions","organizations_url":"https://api.github.com/users/pfxuan/orgs","repos_url":"https://api.github.com/users/pfxuan/repos","events_url":"https://api.github.com/users/pfxuan/events{/privacy}","received_events_url":"https://api.github.com/users/pfxuan/received_events","type":"User","site_admin":false},"repo":{"id":18997047,"name":"tachyon","full_name":"pfxuan/tachyon","owner":{"login":"pfxuan","id":2773827,"avatar_url":"https://avatars.githubusercontent.com/u/2773827?v=3","gravatar_id":"","url":"https://api.github.com/users/pfxuan","html_url":"https://github.com/pfxuan","followers_url":"https://api.github.com/users/pfxuan/followers","following_url":"https://api.github.com/users/pfxuan/following{/other_user}","gists_url":"https://api.github.com/users/pfxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/pfxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfxuan/subscriptions","organizations_url":"https://api.github.com/users/pfxuan/orgs","repos_url":"https://api.github.com/users/pfxuan/repos","events_url":"https://api.github.com/users/pfxuan/events{/privacy}","received_events_url":"https://api.github.com/users/pfxuan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pfxuan/tachyon","description":"Reliable File Sharing at Memory Speed Across Cluster Frameworks","fork":true,"url":"https://api.github.com/repos/pfxuan/tachyon","forks_url":"https://api.github.com/repos/pfxuan/tachyon/forks","keys_url":"https://api.github.com/repos/pfxuan/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfxuan/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfxuan/tachyon/teams","hooks_url":"https://api.github.com/repos/pfxuan/tachyon/hooks","issue_events_url":"https://api.github.com/repos/pfxuan/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/pfxuan/tachyon/events","assignees_url":"https://api.github.com/repos/pfxuan/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/pfxuan/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/pfxuan/tachyon/tags","blobs_url":"https://api.github.com/repos/pfxuan/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfxuan/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfxuan/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfxuan/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfxuan/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/pfxuan/tachyon/languages","stargazers_url":"https://api.github.com/repos/pfxuan/tachyon/stargazers","contributors_url":"https://api.github.com/repos/pfxuan/tachyon/contributors","subscribers_url":"https://api.github.com/repos/pfxuan/tachyon/subscribers","subscription_url":"https://api.github.com/repos/pfxuan/tachyon/subscription","commits_url":"https://api.github.com/repos/pfxuan/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfxuan/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfxuan/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfxuan/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfxuan/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/pfxuan/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfxuan/tachyon/merges","archive_url":"https://api.github.com/repos/pfxuan/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfxuan/tachyon/downloads","issues_url":"https://api.github.com/repos/pfxuan/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/pfxuan/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/pfxuan/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/pfxuan/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfxuan/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/pfxuan/tachyon/releases{/id}","deployments_url":"https://api.github.com/repos/pfxuan/tachyon/deployments","created_at":"2014-04-21T15:41:12Z","updated_at":"2016-02-23T05:19:14Z","pushed_at":"2016-06-28T17:58:37Z","git_url":"git://github.com/pfxuan/tachyon.git","ssh_url":"git@github.com:pfxuan/tachyon.git","clone_url":"https://github.com/pfxuan/tachyon.git","svn_url":"https://github.com/pfxuan/tachyon","homepage":"http://tachyon-project.org","size":55824,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Alluxio:master","ref":"master","sha":"b024350095bbe928a0521a7ac41637cbabaa52d1","user":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars.githubusercontent.com/u/16203694?v=3","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"alluxio","full_name":"Alluxio/alluxio","owner":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars.githubusercontent.com/u/16203694?v=3","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alluxio/alluxio","description":"Alluxio, formerly Tachyon, Memory Speed Virtual Distributed Storage System","fork":false,"url":"https://api.github.com/repos/Alluxio/alluxio","forks_url":"https://api.github.com/repos/Alluxio/alluxio/forks","keys_url":"https://api.github.com/repos/Alluxio/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alluxio/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alluxio/alluxio/teams","hooks_url":"https://api.github.com/repos/Alluxio/alluxio/hooks","issue_events_url":"https://api.github.com/repos/Alluxio/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/Alluxio/alluxio/events","assignees_url":"https://api.github.com/repos/Alluxio/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/Alluxio/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/Alluxio/alluxio/tags","blobs_url":"https://api.github.com/repos/Alluxio/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alluxio/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alluxio/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alluxio/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/Alluxio/alluxio/languages","stargazers_url":"https://api.github.com/repos/Alluxio/alluxio/stargazers","contributors_url":"https://api.github.com/repos/Alluxio/alluxio/contributors","subscribers_url":"https://api.github.com/repos/Alluxio/alluxio/subscribers","subscription_url":"https://api.github.com/repos/Alluxio/alluxio/subscription","commits_url":"https://api.github.com/repos/Alluxio/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alluxio/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alluxio/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alluxio/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/Alluxio/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alluxio/alluxio/merges","archive_url":"https://api.github.com/repos/Alluxio/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alluxio/alluxio/downloads","issues_url":"https://api.github.com/repos/Alluxio/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/Alluxio/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/Alluxio/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/Alluxio/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alluxio/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/Alluxio/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/Alluxio/alluxio/deployments","created_at":"2012-12-21T17:43:46Z","updated_at":"2016-06-28T13:01:22Z","pushed_at":"2016-06-28T20:15:20Z","git_url":"git://github.com/Alluxio/alluxio.git","ssh_url":"git@github.com:Alluxio/alluxio.git","clone_url":"https://github.com/Alluxio/alluxio.git","svn_url":"https://github.com/Alluxio/alluxio","homepage":"http://www.alluxio.org/","size":88254,"stargazers_count":2422,"watchers_count":2422,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1002,"mirror_url":null,"open_issues_count":22,"forks":1002,"open_issues":22,"watchers":2422,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/3592"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/3592"},"issue":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/3592"},"comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/3592/comments"},"review_comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/3592/comments"},"review_comment":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/3592/commits"},"statuses":{"href":"https://api.github.com/repos/Alluxio/alluxio/statuses/63f3adfab1dd40c733cf144b1ad557f2a601b801"}}}}
{"actor":{"display_login":"aaudiber"}}