{"action":"opened","number":33301,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/33301","id":68485785,"html_url":"https://github.com/rust-lang/rust/pull/33301","diff_url":"https://github.com/rust-lang/rust/pull/33301.diff","patch_url":"https://github.com/rust-lang/rust/pull/33301.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/33301","number":33301,"state":"open","locked":false,"title":"Plumb inference obligations through selection","user":{"login":"soltanmm","id":4889063,"avatar_url":"https://avatars.githubusercontent.com/u/4889063?v=3","gravatar_id":"","url":"https://api.github.com/users/soltanmm","html_url":"https://github.com/soltanmm","followers_url":"https://api.github.com/users/soltanmm/followers","following_url":"https://api.github.com/users/soltanmm/following{/other_user}","gists_url":"https://api.github.com/users/soltanmm/gists{/gist_id}","starred_url":"https://api.github.com/users/soltanmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltanmm/subscriptions","organizations_url":"https://api.github.com/users/soltanmm/orgs","repos_url":"https://api.github.com/users/soltanmm/repos","events_url":"https://api.github.com/users/soltanmm/events{/privacy}","received_events_url":"https://api.github.com/users/soltanmm/received_events","type":"User","site_admin":false},"body":"An alternative to this implementation of plumbing is adding a `nested` field to the `VtableObjectData` and `VtableFnPointer` variants and dumping the inferred obligations right into the `nested` fields of the `Vtable*` types.\r\n\r\n... And by 'alternative', given that I'm not familiar with the particulars of caching and how candidates and/or their bounds may or may not get invalidated or may or may no longer be obligated to fulfill a bound in the future, I mean: '*possibly correct implementation and what's currently in this PR is not only inefficient but outright awfully wrong*'.\r\n\r\nNext (in-parallel?) step is removing the [`consider_unification_despite_ambiguity`](\r\nhttps://github.com/rust-lang/rust/blob/ffca6c3e155cb6033b1f749d0ba1be32dfc4d22a/src/librustc/traits/project.rs#L244) in projection...\r\n\r\nr? @nikomatsakis ","created_at":"2016-05-01T03:15:29Z","updated_at":"2016-05-01T03:15:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/33301/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/33301/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/33301/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/bf98976ec559d36f2aac16c1552155f417046afc","head":{"label":"soltanmm:inquiry","ref":"inquiry","sha":"bf98976ec559d36f2aac16c1552155f417046afc","user":{"login":"soltanmm","id":4889063,"avatar_url":"https://avatars.githubusercontent.com/u/4889063?v=3","gravatar_id":"","url":"https://api.github.com/users/soltanmm","html_url":"https://github.com/soltanmm","followers_url":"https://api.github.com/users/soltanmm/followers","following_url":"https://api.github.com/users/soltanmm/following{/other_user}","gists_url":"https://api.github.com/users/soltanmm/gists{/gist_id}","starred_url":"https://api.github.com/users/soltanmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltanmm/subscriptions","organizations_url":"https://api.github.com/users/soltanmm/orgs","repos_url":"https://api.github.com/users/soltanmm/repos","events_url":"https://api.github.com/users/soltanmm/events{/privacy}","received_events_url":"https://api.github.com/users/soltanmm/received_events","type":"User","site_admin":false},"repo":{"id":36658663,"name":"rust","full_name":"soltanmm/rust","owner":{"login":"soltanmm","id":4889063,"avatar_url":"https://avatars.githubusercontent.com/u/4889063?v=3","gravatar_id":"","url":"https://api.github.com/users/soltanmm","html_url":"https://github.com/soltanmm","followers_url":"https://api.github.com/users/soltanmm/followers","following_url":"https://api.github.com/users/soltanmm/following{/other_user}","gists_url":"https://api.github.com/users/soltanmm/gists{/gist_id}","starred_url":"https://api.github.com/users/soltanmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltanmm/subscriptions","organizations_url":"https://api.github.com/users/soltanmm/orgs","repos_url":"https://api.github.com/users/soltanmm/repos","events_url":"https://api.github.com/users/soltanmm/events{/privacy}","received_events_url":"https://api.github.com/users/soltanmm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/soltanmm/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/soltanmm/rust","forks_url":"https://api.github.com/repos/soltanmm/rust/forks","keys_url":"https://api.github.com/repos/soltanmm/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soltanmm/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soltanmm/rust/teams","hooks_url":"https://api.github.com/repos/soltanmm/rust/hooks","issue_events_url":"https://api.github.com/repos/soltanmm/rust/issues/events{/number}","events_url":"https://api.github.com/repos/soltanmm/rust/events","assignees_url":"https://api.github.com/repos/soltanmm/rust/assignees{/user}","branches_url":"https://api.github.com/repos/soltanmm/rust/branches{/branch}","tags_url":"https://api.github.com/repos/soltanmm/rust/tags","blobs_url":"https://api.github.com/repos/soltanmm/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soltanmm/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soltanmm/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/soltanmm/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soltanmm/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/soltanmm/rust/languages","stargazers_url":"https://api.github.com/repos/soltanmm/rust/stargazers","contributors_url":"https://api.github.com/repos/soltanmm/rust/contributors","subscribers_url":"https://api.github.com/repos/soltanmm/rust/subscribers","subscription_url":"https://api.github.com/repos/soltanmm/rust/subscription","commits_url":"https://api.github.com/repos/soltanmm/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/soltanmm/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/soltanmm/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/soltanmm/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/soltanmm/rust/contents/{+path}","compare_url":"https://api.github.com/repos/soltanmm/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soltanmm/rust/merges","archive_url":"https://api.github.com/repos/soltanmm/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soltanmm/rust/downloads","issues_url":"https://api.github.com/repos/soltanmm/rust/issues{/number}","pulls_url":"https://api.github.com/repos/soltanmm/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/soltanmm/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/soltanmm/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soltanmm/rust/labels{/name}","releases_url":"https://api.github.com/repos/soltanmm/rust/releases{/id}","deployments_url":"https://api.github.com/repos/soltanmm/rust/deployments","created_at":"2015-06-01T12:16:11Z","updated_at":"2016-01-12T15:54:54Z","pushed_at":"2016-05-01T02:53:48Z","git_url":"git://github.com/soltanmm/rust.git","ssh_url":"git@github.com:soltanmm/rust.git","clone_url":"https://github.com/soltanmm/rust.git","svn_url":"https://github.com/soltanmm/rust","homepage":"http://www.rust-lang.org","size":290565,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"2a815a26c8ce70e1aede585827c020d9775a8faf","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-05-01T03:04:57Z","pushed_at":"2016-05-01T03:15:29Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":488377,"stargazers_count":16489,"watchers_count":16489,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3142,"mirror_url":null,"open_issues_count":2499,"forks":3142,"open_issues":2499,"watchers":16489,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/33301"},"html":{"href":"https://github.com/rust-lang/rust/pull/33301"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/33301"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/33301/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/33301/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/33301/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/bf98976ec559d36f2aac16c1552155f417046afc"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":209,"deletions":110,"changed_files":8}}