{"action":"created","comment":{"url":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/comments/61671412","id":61671412,"diff_hunk":"@@ -56,7 +56,8 @@ object Semaphore {\n \n   /** Create a new `Semaphore`, initialized with `n` available permits. */\n   def apply[F[_]](n: Long)(implicit F: Async[F]): F[Semaphore[F]] = {\n-    def ensureNonneg(n: Long) = if (n < 0) throw new IllegalArgumentException(\"n must be nonnegative, was: \" + n)\n+    def ensureNonneg(n: Long) = assert(n >= 0, s\"n must be nonnegative, was: $n \")","path":"core/src/main/scala/fs2/async/mutable/Semaphore.scala","position":5,"original_position":5,"commit_id":"bb15e27be98f545077aaaab5de8d860f81b68ee1","original_commit_id":"41f1c42ed6813f62b5bb2d2ae6beb0b93d75b012","user":{"login":"pchlupacek","id":678560,"avatar_url":"https://avatars.githubusercontent.com/u/678560?v=3","gravatar_id":"","url":"https://api.github.com/users/pchlupacek","html_url":"https://github.com/pchlupacek","followers_url":"https://api.github.com/users/pchlupacek/followers","following_url":"https://api.github.com/users/pchlupacek/following{/other_user}","gists_url":"https://api.github.com/users/pchlupacek/gists{/gist_id}","starred_url":"https://api.github.com/users/pchlupacek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pchlupacek/subscriptions","organizations_url":"https://api.github.com/users/pchlupacek/orgs","repos_url":"https://api.github.com/users/pchlupacek/repos","events_url":"https://api.github.com/users/pchlupacek/events{/privacy}","received_events_url":"https://api.github.com/users/pchlupacek/received_events","type":"User","site_admin":false},"body":"ok, I see your point. I'll introduce something like this in util?. I just think the if and throw is sort of unexpected. Maybe checkArgument(cond:Boolean, msg:=> String):Unit?","created_at":"2016-04-30T16:03:17Z","updated_at":"2016-04-30T16:03:17Z","html_url":"https://github.com/functional-streams-for-scala/fs2/pull/590#discussion_r61671412","pull_request_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/590","_links":{"self":{"href":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/comments/61671412"},"html":{"href":"https://github.com/functional-streams-for-scala/fs2/pull/590#discussion_r61671412"},"pull_request":{"href":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/590"}}},"pull_request":{"url":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/590","id":68469380,"html_url":"https://github.com/functional-streams-for-scala/fs2/pull/590","diff_url":"https://github.com/functional-streams-for-scala/fs2/pull/590.diff","patch_url":"https://github.com/functional-streams-for-scala/fs2/pull/590.patch","issue_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/issues/590","number":590,"state":"open","locked":false,"title":"Added docs for concurrent.join. Fixed the finalizer handler to be not…","user":{"login":"pchlupacek","id":678560,"avatar_url":"https://avatars.githubusercontent.com/u/678560?v=3","gravatar_id":"","url":"https://api.github.com/users/pchlupacek","html_url":"https://github.com/pchlupacek","followers_url":"https://api.github.com/users/pchlupacek/followers","following_url":"https://api.github.com/users/pchlupacek/following{/other_user}","gists_url":"https://api.github.com/users/pchlupacek/gists{/gist_id}","starred_url":"https://api.github.com/users/pchlupacek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pchlupacek/subscriptions","organizations_url":"https://api.github.com/users/pchlupacek/orgs","repos_url":"https://api.github.com/users/pchlupacek/repos","events_url":"https://api.github.com/users/pchlupacek/events{/privacy}","received_events_url":"https://api.github.com/users/pchlupacek/received_events","type":"User","site_admin":false},"body":"… called in every situation","created_at":"2016-04-30T14:33:48Z","updated_at":"2016-04-30T16:03:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ade3071a9b619fbc164411823f583dad53a7ac6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/590/commits","review_comments_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/590/comments","review_comment_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/issues/590/comments","statuses_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/statuses/bb15e27be98f545077aaaab5de8d860f81b68ee1","head":{"label":"functional-streams-for-scala:topic/redesign-join-termination-fix","ref":"topic/redesign-join-termination-fix","sha":"bb15e27be98f545077aaaab5de8d860f81b68ee1","user":{"login":"functional-streams-for-scala","id":14128107,"avatar_url":"https://avatars.githubusercontent.com/u/14128107?v=3","gravatar_id":"","url":"https://api.github.com/users/functional-streams-for-scala","html_url":"https://github.com/functional-streams-for-scala","followers_url":"https://api.github.com/users/functional-streams-for-scala/followers","following_url":"https://api.github.com/users/functional-streams-for-scala/following{/other_user}","gists_url":"https://api.github.com/users/functional-streams-for-scala/gists{/gist_id}","starred_url":"https://api.github.com/users/functional-streams-for-scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/functional-streams-for-scala/subscriptions","organizations_url":"https://api.github.com/users/functional-streams-for-scala/orgs","repos_url":"https://api.github.com/users/functional-streams-for-scala/repos","events_url":"https://api.github.com/users/functional-streams-for-scala/events{/privacy}","received_events_url":"https://api.github.com/users/functional-streams-for-scala/received_events","type":"Organization","site_admin":false},"repo":{"id":8609125,"name":"fs2","full_name":"functional-streams-for-scala/fs2","owner":{"login":"functional-streams-for-scala","id":14128107,"avatar_url":"https://avatars.githubusercontent.com/u/14128107?v=3","gravatar_id":"","url":"https://api.github.com/users/functional-streams-for-scala","html_url":"https://github.com/functional-streams-for-scala","followers_url":"https://api.github.com/users/functional-streams-for-scala/followers","following_url":"https://api.github.com/users/functional-streams-for-scala/following{/other_user}","gists_url":"https://api.github.com/users/functional-streams-for-scala/gists{/gist_id}","starred_url":"https://api.github.com/users/functional-streams-for-scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/functional-streams-for-scala/subscriptions","organizations_url":"https://api.github.com/users/functional-streams-for-scala/orgs","repos_url":"https://api.github.com/users/functional-streams-for-scala/repos","events_url":"https://api.github.com/users/functional-streams-for-scala/events{/privacy}","received_events_url":"https://api.github.com/users/functional-streams-for-scala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/functional-streams-for-scala/fs2","description":"Compositional, streaming I/O library for Scala","fork":false,"url":"https://api.github.com/repos/functional-streams-for-scala/fs2","forks_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/forks","keys_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/teams","hooks_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/hooks","issue_events_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/issues/events{/number}","events_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/events","assignees_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/assignees{/user}","branches_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/branches{/branch}","tags_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/tags","blobs_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/git/refs{/sha}","trees_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/statuses/{sha}","languages_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/languages","stargazers_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/stargazers","contributors_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/contributors","subscribers_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/subscribers","subscription_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/subscription","commits_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/commits{/sha}","git_commits_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/git/commits{/sha}","comments_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/comments{/number}","issue_comment_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/issues/comments{/number}","contents_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/contents/{+path}","compare_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/merges","archive_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/downloads","issues_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/issues{/number}","pulls_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls{/number}","milestones_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/milestones{/number}","notifications_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/labels{/name}","releases_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/releases{/id}","deployments_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/deployments","created_at":"2013-03-06T17:34:15Z","updated_at":"2016-04-26T11:27:46Z","pushed_at":"2016-04-30T15:50:34Z","git_url":"git://github.com/functional-streams-for-scala/fs2.git","ssh_url":"git@github.com:functional-streams-for-scala/fs2.git","clone_url":"https://github.com/functional-streams-for-scala/fs2.git","svn_url":"https://github.com/functional-streams-for-scala/fs2","homepage":"","size":5010,"stargazers_count":518,"watchers_count":518,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"open_issues_count":30,"forks":150,"open_issues":30,"watchers":518,"default_branch":"topic/redesign"}},"base":{"label":"functional-streams-for-scala:topic/redesign","ref":"topic/redesign","sha":"db1bf5d9a5b1e32593c8de44dc31c3f95f3144a1","user":{"login":"functional-streams-for-scala","id":14128107,"avatar_url":"https://avatars.githubusercontent.com/u/14128107?v=3","gravatar_id":"","url":"https://api.github.com/users/functional-streams-for-scala","html_url":"https://github.com/functional-streams-for-scala","followers_url":"https://api.github.com/users/functional-streams-for-scala/followers","following_url":"https://api.github.com/users/functional-streams-for-scala/following{/other_user}","gists_url":"https://api.github.com/users/functional-streams-for-scala/gists{/gist_id}","starred_url":"https://api.github.com/users/functional-streams-for-scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/functional-streams-for-scala/subscriptions","organizations_url":"https://api.github.com/users/functional-streams-for-scala/orgs","repos_url":"https://api.github.com/users/functional-streams-for-scala/repos","events_url":"https://api.github.com/users/functional-streams-for-scala/events{/privacy}","received_events_url":"https://api.github.com/users/functional-streams-for-scala/received_events","type":"Organization","site_admin":false},"repo":{"id":8609125,"name":"fs2","full_name":"functional-streams-for-scala/fs2","owner":{"login":"functional-streams-for-scala","id":14128107,"avatar_url":"https://avatars.githubusercontent.com/u/14128107?v=3","gravatar_id":"","url":"https://api.github.com/users/functional-streams-for-scala","html_url":"https://github.com/functional-streams-for-scala","followers_url":"https://api.github.com/users/functional-streams-for-scala/followers","following_url":"https://api.github.com/users/functional-streams-for-scala/following{/other_user}","gists_url":"https://api.github.com/users/functional-streams-for-scala/gists{/gist_id}","starred_url":"https://api.github.com/users/functional-streams-for-scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/functional-streams-for-scala/subscriptions","organizations_url":"https://api.github.com/users/functional-streams-for-scala/orgs","repos_url":"https://api.github.com/users/functional-streams-for-scala/repos","events_url":"https://api.github.com/users/functional-streams-for-scala/events{/privacy}","received_events_url":"https://api.github.com/users/functional-streams-for-scala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/functional-streams-for-scala/fs2","description":"Compositional, streaming I/O library for Scala","fork":false,"url":"https://api.github.com/repos/functional-streams-for-scala/fs2","forks_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/forks","keys_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/teams","hooks_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/hooks","issue_events_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/issues/events{/number}","events_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/events","assignees_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/assignees{/user}","branches_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/branches{/branch}","tags_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/tags","blobs_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/git/refs{/sha}","trees_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/statuses/{sha}","languages_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/languages","stargazers_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/stargazers","contributors_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/contributors","subscribers_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/subscribers","subscription_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/subscription","commits_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/commits{/sha}","git_commits_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/git/commits{/sha}","comments_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/comments{/number}","issue_comment_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/issues/comments{/number}","contents_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/contents/{+path}","compare_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/merges","archive_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/downloads","issues_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/issues{/number}","pulls_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls{/number}","milestones_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/milestones{/number}","notifications_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/labels{/name}","releases_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/releases{/id}","deployments_url":"https://api.github.com/repos/functional-streams-for-scala/fs2/deployments","created_at":"2013-03-06T17:34:15Z","updated_at":"2016-04-26T11:27:46Z","pushed_at":"2016-04-30T15:50:34Z","git_url":"git://github.com/functional-streams-for-scala/fs2.git","ssh_url":"git@github.com:functional-streams-for-scala/fs2.git","clone_url":"https://github.com/functional-streams-for-scala/fs2.git","svn_url":"https://github.com/functional-streams-for-scala/fs2","homepage":"","size":5010,"stargazers_count":518,"watchers_count":518,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"open_issues_count":30,"forks":150,"open_issues":30,"watchers":518,"default_branch":"topic/redesign"}},"_links":{"self":{"href":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/590"},"html":{"href":"https://github.com/functional-streams-for-scala/fs2/pull/590"},"issue":{"href":"https://api.github.com/repos/functional-streams-for-scala/fs2/issues/590"},"comments":{"href":"https://api.github.com/repos/functional-streams-for-scala/fs2/issues/590/comments"},"review_comments":{"href":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/590/comments"},"review_comment":{"href":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/functional-streams-for-scala/fs2/pulls/590/commits"},"statuses":{"href":"https://api.github.com/repos/functional-streams-for-scala/fs2/statuses/bb15e27be98f545077aaaab5de8d860f81b68ee1"}}}}