{"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/51538697","id":51538697,"diff_hunk":"@@ -184,11 +203,16 @@ class instance_deadmines : public InstanceMapScript\n             {\n                 switch (go->GetEntry())\n                 {\n-                    case GO_FACTORY_DOOR:   FactoryDoorGUID = go->GetGUID(); break;\n-                    case GO_IRONCLAD_DOOR:  IronCladDoorGUID = go->GetGUID();  break;\n-                    case GO_DEFIAS_CANNON:  DefiasCannonGUID = go->GetGUID();  break;\n-                    case GO_DOOR_LEVER:     DoorLeverGUID = go->GetGUID();     break;\n-                    case GO_MR_SMITE_CHEST: uiSmiteChestGUID = go->GetGUID();  break;\n+                    case GO_FACTORY_DOOR:   FactoryDoorGUID = go->GetGUID();","path":"src/server/scripts/EasternKingdoms/Deadmines/instance_deadmines.cpp","position":102,"original_position":102,"commit_id":"26782055f6659bcd8d3beea4be0105f812a4aceb","original_commit_id":"53cb77b906136507f13aeefba83ace55a36494dc","user":{"login":"tkrokli","id":4903600,"avatar_url":"https://avatars.githubusercontent.com/u/4903600?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrokli","html_url":"https://github.com/tkrokli","followers_url":"https://api.github.com/users/tkrokli/followers","following_url":"https://api.github.com/users/tkrokli/following{/other_user}","gists_url":"https://api.github.com/users/tkrokli/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrokli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrokli/subscriptions","organizations_url":"https://api.github.com/users/tkrokli/orgs","repos_url":"https://api.github.com/users/tkrokli/repos","events_url":"https://api.github.com/users/tkrokli/events{/privacy}","received_events_url":"https://api.github.com/users/tkrokli/received_events","type":"User","site_admin":false},"body":"Ah, right. Will fix.","created_at":"2016-02-02T08:43:00Z","updated_at":"2016-02-02T08:43:00Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/16453#discussion_r51538697","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16453","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/51538697"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/16453#discussion_r51538697"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16453"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16453","id":57935682,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/16453","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/16453.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/16453.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/16453","number":16453,"state":"open","locked":false,"title":"[WIP][3.3.5] Core/Scripts: Deadmines instance / Mr. Smite","user":{"login":"tkrokli","id":4903600,"avatar_url":"https://avatars.githubusercontent.com/u/4903600?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrokli","html_url":"https://github.com/tkrokli","followers_url":"https://api.github.com/users/tkrokli/followers","following_url":"https://api.github.com/users/tkrokli/following{/other_user}","gists_url":"https://api.github.com/users/tkrokli/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrokli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrokli/subscriptions","organizations_url":"https://api.github.com/users/tkrokli/orgs","repos_url":"https://api.github.com/users/tkrokli/repos","events_url":"https://api.github.com/users/tkrokli/events{/privacy}","received_events_url":"https://api.github.com/users/tkrokli/received_events","type":"User","site_admin":false},"body":"This is a Work in Progress for what needs to be done to make\r\nthe yells from Mr. Smite work, as well as a kneeling emote\r\nthat did not work before (unsupported emote method).\r\n\r\nI will need lots of constructive feedback to make it a working script.\r\n\r\nTarget points for this PR:\r\n- remove 2 hardcoded lines from the instance script\r\n- add all 3 missing say(yell) lines to creature text\r\n- use entries from creature_text via proper enum\r\n- make Mr. Smite use a proper kneeling emote\r\n- apply proper code style to enum sections\r\n\r\nWith all 4 yells for Mr. Smite available in creature_text,\r\nthis PR is open for suggestions on how to implement\r\nthe 2 missing yells in extra events in the scripts.","created_at":"2016-02-02T03:23:05Z","updated_at":"2016-02-02T08:43:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01c17139b1d1c55518eb2c0bb85f467e3522716f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16453/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16453/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/16453/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/26782055f6659bcd8d3beea4be0105f812a4aceb","head":{"label":"tkrokli:say_mr_smite_alarm","ref":"say_mr_smite_alarm","sha":"26782055f6659bcd8d3beea4be0105f812a4aceb","user":{"login":"tkrokli","id":4903600,"avatar_url":"https://avatars.githubusercontent.com/u/4903600?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrokli","html_url":"https://github.com/tkrokli","followers_url":"https://api.github.com/users/tkrokli/followers","following_url":"https://api.github.com/users/tkrokli/following{/other_user}","gists_url":"https://api.github.com/users/tkrokli/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrokli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrokli/subscriptions","organizations_url":"https://api.github.com/users/tkrokli/orgs","repos_url":"https://api.github.com/users/tkrokli/repos","events_url":"https://api.github.com/users/tkrokli/events{/privacy}","received_events_url":"https://api.github.com/users/tkrokli/received_events","type":"User","site_admin":false},"repo":{"id":33367544,"name":"TrinityCore","full_name":"tkrokli/TrinityCore","owner":{"login":"tkrokli","id":4903600,"avatar_url":"https://avatars.githubusercontent.com/u/4903600?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrokli","html_url":"https://github.com/tkrokli","followers_url":"https://api.github.com/users/tkrokli/followers","following_url":"https://api.github.com/users/tkrokli/following{/other_user}","gists_url":"https://api.github.com/users/tkrokli/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrokli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrokli/subscriptions","organizations_url":"https://api.github.com/users/tkrokli/orgs","repos_url":"https://api.github.com/users/tkrokli/repos","events_url":"https://api.github.com/users/tkrokli/events{/privacy}","received_events_url":"https://api.github.com/users/tkrokli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tkrokli/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/tkrokli/TrinityCore","forks_url":"https://api.github.com/repos/tkrokli/TrinityCore/forks","keys_url":"https://api.github.com/repos/tkrokli/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tkrokli/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tkrokli/TrinityCore/teams","hooks_url":"https://api.github.com/repos/tkrokli/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/tkrokli/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/tkrokli/TrinityCore/events","assignees_url":"https://api.github.com/repos/tkrokli/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/tkrokli/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/tkrokli/TrinityCore/tags","blobs_url":"https://api.github.com/repos/tkrokli/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tkrokli/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tkrokli/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/tkrokli/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tkrokli/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/tkrokli/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/tkrokli/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/tkrokli/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/tkrokli/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/tkrokli/TrinityCore/subscription","commits_url":"https://api.github.com/repos/tkrokli/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/tkrokli/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/tkrokli/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/tkrokli/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/tkrokli/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/tkrokli/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tkrokli/TrinityCore/merges","archive_url":"https://api.github.com/repos/tkrokli/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tkrokli/TrinityCore/downloads","issues_url":"https://api.github.com/repos/tkrokli/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/tkrokli/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/tkrokli/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/tkrokli/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tkrokli/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/tkrokli/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/tkrokli/TrinityCore/deployments","created_at":"2015-04-03T14:46:13Z","updated_at":"2016-01-11T04:39:21Z","pushed_at":"2016-02-02T08:29:47Z","git_url":"git://github.com/tkrokli/TrinityCore.git","ssh_url":"git@github.com:tkrokli/TrinityCore.git","clone_url":"https://github.com/tkrokli/TrinityCore.git","svn_url":"https://github.com/tkrokli/TrinityCore","homepage":"http://www.trinitycore.org","size":376489,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":7,"default_branch":"3.3.5"}},"base":{"label":"TrinityCore:3.3.5","ref":"3.3.5","sha":"60f8751c642282d1aae789ee37f654c452063780","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/deployments","created_at":"2010-12-28T23:40:07Z","updated_at":"2016-02-02T07:06:02Z","pushed_at":"2016-02-02T08:29:50Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":759430,"stargazers_count":3121,"watchers_count":3121,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3274,"mirror_url":null,"open_issues_count":1366,"forks":3274,"open_issues":1366,"watchers":3121,"default_branch":"6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16453"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/16453"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/16453"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/16453/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16453/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16453/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/26782055f6659bcd8d3beea4be0105f812a4aceb"}}}}