{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5202","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5202/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5202/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5202/events","html_url":"https://github.com/bitcoin/bitcoin/issues/5202","id":47653750,"number":5202,"title":"High fee warnings need to be reworked","user":{"login":"morcos","id":4360349,"avatar_url":"https://avatars.githubusercontent.com/u/4360349?v=3","gravatar_id":"","url":"https://api.github.com/users/morcos","html_url":"https://github.com/morcos","followers_url":"https://api.github.com/users/morcos/followers","following_url":"https://api.github.com/users/morcos/following{/other_user}","gists_url":"https://api.github.com/users/morcos/gists{/gist_id}","starred_url":"https://api.github.com/users/morcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morcos/subscriptions","organizations_url":"https://api.github.com/users/morcos/orgs","repos_url":"https://api.github.com/users/morcos/repos","events_url":"https://api.github.com/users/morcos/events{/privacy}","received_events_url":"https://api.github.com/users/morcos/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Wallet","name":"Wallet","color":"02d7e1"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2014-11-03T22:32:01Z","updated_at":"2016-02-02T19:11:19Z","closed_at":null,"body":"The code had 3 separate places where high fee values are hard coded. \r\n1. `WalletModel::prepareTransaction` in qt/walletmodel.cpp rejects transactions with a fee over .1 BTC initiated from QT.\r\n2. `nHighTransactionFeeWarning` defined in wallet.h generates a warning in init.cpp if a fee amount over .01 BTC is set with `-paytxfee`\r\n3. `AcceptToMemoryPool` in main.cpp rejects a transaction unless the override is set if the fee is greater than 10,000 times the minRelayTxFee (= ~.023 BTC for a simple 1 input, 2 output tx). \r\n\r\nIt seems like it would make sense to consolidate to one warning level and it should be significantly lower. (maybe 1,000 times the minRelayTxFee or just a fixed amount).\r\n\r\nFrom the standpoint of reworking the UI (#5200) there should be a warning that you could click through to allow the higher fee.   This would help address @petertodd's concerns in #4250.  \r\n\r\nAlso it seems like `AcceptToMemoryPool` is an odd place to have this check, perhaps we could move it somewhere else to handle an rpc initiated transaction?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/178764270","html_url":"https://github.com/bitcoin/bitcoin/issues/5202#issuecomment-178764270","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5202","id":178764270,"user":{"login":"MarcoFalke","id":6399679,"avatar_url":"https://avatars.githubusercontent.com/u/6399679?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"created_at":"2016-02-02T19:11:19Z","updated_at":"2016-02-02T19:11:19Z","body":"Addressed 3. in #7084. I will fix the remaining nits hopefully next week."}}