{"action":"created","comment":{"url":"https://api.github.com/repos/cuappdev/big-red-shuttle/pulls/comments/87707657","pull_request_review_id":8311079,"id":87707657,"diff_hunk":"@@ -60,31 +60,55 @@ class AppDelegate: UIResponder, UIApplicationDelegate {\n         tabBarController.tabBar.barTintColor = .brslightgrey\n         tabBarController.tabBar.layer.borderWidth = 0.5\n         tabBarController.tabBar.layer.borderColor = UIColor.lightGray.cgColor\n+        tabBarController.delegate = self\n         \n         //Set up window\n         window = UIWindow(frame: UIScreen.main.bounds)\n         window!.makeKeyAndVisible()\n         window?.rootViewController = tabBarController\n         \n-        //Test API\n-        api().registerUserToLogLocation(key: \"fedorko\") {\n-            //success\n-            print(\"Did successfully register user to log location\")\n-            \n-            api().logLocation(completion: { \n-                print(\"Did successfully register user to log location\")\n-                \n-                api().getLocation(completion: { (coordinate: Coordinate) in\n-                    print(\"bus is at latitude: \\(coordinate.latitude), longitude: \\(coordinate.longitude)\")\n-                })\n-            })\n-        }\n+//        //Test API\n+//        api().registerUserToLogLocation(key: \"fedorko\", success: { (json: JSON) in\n+//            print(\"here\")\n+//        }, failure: { (json: JSON) in\n+//            print(\"here\")\n+//\n+//        })\n+        \n+//        api().logLocation(success: { (json: JSON?) in\n+//            print(\"here\")\n+//\n+//        }, failure: { (json: JSON?) in\n+//            print(\"here\")\n+//        })\n+////\n+//        api().getLocation(success: { (json: JSON) in\n+//            print(\"here\")\n+//\n+//        }, failure: { (json: JSON) in\n+//            print(\"here\")\n+//        })\n         \n         //Light status bar\n         UIApplication.shared.statusBarStyle = .lightContent\n \n         return true\n     }\n+    \n+    var hiddenTabCounter = 0\n+    \n+    func tabBarController(_ tabBarController: UITabBarController, didSelect viewController: UIViewController) {\n+        if tabBarController.selectedIndex == 0 {\n+            hiddenTabCounter += 1\n+        } else {\n+            hiddenTabCounter = 0\n+        }","path":"big-red-shuttle/AppDelegate.swift","position":68,"original_position":68,"commit_id":"f883e6af0ffe7468eedd96a702a7e3bc5cb49b72","original_commit_id":"f883e6af0ffe7468eedd96a702a7e3bc5cb49b72","user":{"login":"acheng96","id":8130751,"avatar_url":"https://avatars.githubusercontent.com/u/8130751?v=3","gravatar_id":"","url":"https://api.github.com/users/acheng96","html_url":"https://github.com/acheng96","followers_url":"https://api.github.com/users/acheng96/followers","following_url":"https://api.github.com/users/acheng96/following{/other_user}","gists_url":"https://api.github.com/users/acheng96/gists{/gist_id}","starred_url":"https://api.github.com/users/acheng96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acheng96/subscriptions","organizations_url":"https://api.github.com/users/acheng96/orgs","repos_url":"https://api.github.com/users/acheng96/repos","events_url":"https://api.github.com/users/acheng96/events{/privacy}","received_events_url":"https://api.github.com/users/acheng96/received_events","type":"User","site_admin":false},"body":"condense lines 101-105:\r\n`hiddenTabCounter = tabBarController.selectedIndex == 0 ? hiddenTabCounter + 1 : 0`","created_at":"2016-11-13T08:07:06Z","updated_at":"2016-11-13T08:07:06Z","html_url":"https://github.com/cuappdev/big-red-shuttle/pull/20#discussion_r87707657","pull_request_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/cuappdev/big-red-shuttle/pulls/comments/87707657"},"html":{"href":"https://github.com/cuappdev/big-red-shuttle/pull/20#discussion_r87707657"},"pull_request":{"href":"https://api.github.com/repos/cuappdev/big-red-shuttle/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/cuappdev/big-red-shuttle/pulls/20","id":93465501,"html_url":"https://github.com/cuappdev/big-red-shuttle/pull/20","diff_url":"https://github.com/cuappdev/big-red-shuttle/pull/20.diff","patch_url":"https://github.com/cuappdev/big-red-shuttle/pull/20.patch","issue_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/issues/20","number":20,"state":"open","locked":false,"title":"Dennis/gps2","user":{"login":"dennisfedorko","id":7183643,"avatar_url":"https://avatars.githubusercontent.com/u/7183643?v=3","gravatar_id":"","url":"https://api.github.com/users/dennisfedorko","html_url":"https://github.com/dennisfedorko","followers_url":"https://api.github.com/users/dennisfedorko/followers","following_url":"https://api.github.com/users/dennisfedorko/following{/other_user}","gists_url":"https://api.github.com/users/dennisfedorko/gists{/gist_id}","starred_url":"https://api.github.com/users/dennisfedorko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennisfedorko/subscriptions","organizations_url":"https://api.github.com/users/dennisfedorko/orgs","repos_url":"https://api.github.com/users/dennisfedorko/repos","events_url":"https://api.github.com/users/dennisfedorko/events{/privacy}","received_events_url":"https://api.github.com/users/dennisfedorko/received_events","type":"User","site_admin":false},"body":"Halfway point for GPS integration. \r\n\r\nGPS.swift should process all GPS reading/writing events for controllers through adding observers as delegates. Instead of using notifications, I created a multi-delegate interface so multiple controllers could listen for GPS updates if they so choose.\r\n\r\nBackend component has been implemented/tested\r\n\r\nNeed to create driver login for logging bus location via DriverViewController which is currently displayed if we tap the tab bar navigation button 5 times in a row. (currently a blank screen)\r\n\r\nNeed to create marker/image for shuttle bus to fully test on map view.\r\n\r\nWe also need to consider edge cases for how to react if user is not logging correctly or some other error happens\r\n","created_at":"2016-11-13T07:54:37Z","updated_at":"2016-11-13T08:07:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ce8d89681bf7dd03768cedc108da2602331dc33","assignee":{"login":"acheng96","id":8130751,"avatar_url":"https://avatars.githubusercontent.com/u/8130751?v=3","gravatar_id":"","url":"https://api.github.com/users/acheng96","html_url":"https://github.com/acheng96","followers_url":"https://api.github.com/users/acheng96/followers","following_url":"https://api.github.com/users/acheng96/following{/other_user}","gists_url":"https://api.github.com/users/acheng96/gists{/gist_id}","starred_url":"https://api.github.com/users/acheng96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acheng96/subscriptions","organizations_url":"https://api.github.com/users/acheng96/orgs","repos_url":"https://api.github.com/users/acheng96/repos","events_url":"https://api.github.com/users/acheng96/events{/privacy}","received_events_url":"https://api.github.com/users/acheng96/received_events","type":"User","site_admin":false},"assignees":[{"login":"acheng96","id":8130751,"avatar_url":"https://avatars.githubusercontent.com/u/8130751?v=3","gravatar_id":"","url":"https://api.github.com/users/acheng96","html_url":"https://github.com/acheng96","followers_url":"https://api.github.com/users/acheng96/followers","following_url":"https://api.github.com/users/acheng96/following{/other_user}","gists_url":"https://api.github.com/users/acheng96/gists{/gist_id}","starred_url":"https://api.github.com/users/acheng96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acheng96/subscriptions","organizations_url":"https://api.github.com/users/acheng96/orgs","repos_url":"https://api.github.com/users/acheng96/repos","events_url":"https://api.github.com/users/acheng96/events{/privacy}","received_events_url":"https://api.github.com/users/acheng96/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/pulls/20/commits","review_comments_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/pulls/20/comments","review_comment_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/issues/20/comments","statuses_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/statuses/f883e6af0ffe7468eedd96a702a7e3bc5cb49b72","head":{"label":"cuappdev:dennis/gps2","ref":"dennis/gps2","sha":"f883e6af0ffe7468eedd96a702a7e3bc5cb49b72","user":{"login":"cuappdev","id":17533691,"avatar_url":"https://avatars.githubusercontent.com/u/17533691?v=3","gravatar_id":"","url":"https://api.github.com/users/cuappdev","html_url":"https://github.com/cuappdev","followers_url":"https://api.github.com/users/cuappdev/followers","following_url":"https://api.github.com/users/cuappdev/following{/other_user}","gists_url":"https://api.github.com/users/cuappdev/gists{/gist_id}","starred_url":"https://api.github.com/users/cuappdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuappdev/subscriptions","organizations_url":"https://api.github.com/users/cuappdev/orgs","repos_url":"https://api.github.com/users/cuappdev/repos","events_url":"https://api.github.com/users/cuappdev/events{/privacy}","received_events_url":"https://api.github.com/users/cuappdev/received_events","type":"Organization","site_admin":false},"repo":{"id":70748937,"name":"big-red-shuttle","full_name":"cuappdev/big-red-shuttle","owner":{"login":"cuappdev","id":17533691,"avatar_url":"https://avatars.githubusercontent.com/u/17533691?v=3","gravatar_id":"","url":"https://api.github.com/users/cuappdev","html_url":"https://github.com/cuappdev","followers_url":"https://api.github.com/users/cuappdev/followers","following_url":"https://api.github.com/users/cuappdev/following{/other_user}","gists_url":"https://api.github.com/users/cuappdev/gists{/gist_id}","starred_url":"https://api.github.com/users/cuappdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuappdev/subscriptions","organizations_url":"https://api.github.com/users/cuappdev/orgs","repos_url":"https://api.github.com/users/cuappdev/repos","events_url":"https://api.github.com/users/cuappdev/events{/privacy}","received_events_url":"https://api.github.com/users/cuappdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cuappdev/big-red-shuttle","description":null,"fork":false,"url":"https://api.github.com/repos/cuappdev/big-red-shuttle","forks_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/forks","keys_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/teams","hooks_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/hooks","issue_events_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/issues/events{/number}","events_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/events","assignees_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/assignees{/user}","branches_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/branches{/branch}","tags_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/tags","blobs_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/git/refs{/sha}","trees_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/statuses/{sha}","languages_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/languages","stargazers_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/stargazers","contributors_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/contributors","subscribers_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/subscribers","subscription_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/subscription","commits_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/commits{/sha}","git_commits_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/git/commits{/sha}","comments_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/comments{/number}","issue_comment_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/issues/comments{/number}","contents_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/contents/{+path}","compare_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/merges","archive_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/downloads","issues_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/issues{/number}","pulls_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/pulls{/number}","milestones_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/milestones{/number}","notifications_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/labels{/name}","releases_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/releases{/id}","deployments_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/deployments","created_at":"2016-10-12T23:04:21Z","updated_at":"2016-10-13T21:41:13Z","pushed_at":"2016-11-13T07:59:13Z","git_url":"git://github.com/cuappdev/big-red-shuttle.git","ssh_url":"git@github.com:cuappdev/big-red-shuttle.git","clone_url":"https://github.com/cuappdev/big-red-shuttle.git","svn_url":"https://github.com/cuappdev/big-red-shuttle","homepage":null,"size":129147,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"cuappdev:master","ref":"master","sha":"ef6b53b2d3c14a0f887c3f5b64015f8d9760e7c2","user":{"login":"cuappdev","id":17533691,"avatar_url":"https://avatars.githubusercontent.com/u/17533691?v=3","gravatar_id":"","url":"https://api.github.com/users/cuappdev","html_url":"https://github.com/cuappdev","followers_url":"https://api.github.com/users/cuappdev/followers","following_url":"https://api.github.com/users/cuappdev/following{/other_user}","gists_url":"https://api.github.com/users/cuappdev/gists{/gist_id}","starred_url":"https://api.github.com/users/cuappdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuappdev/subscriptions","organizations_url":"https://api.github.com/users/cuappdev/orgs","repos_url":"https://api.github.com/users/cuappdev/repos","events_url":"https://api.github.com/users/cuappdev/events{/privacy}","received_events_url":"https://api.github.com/users/cuappdev/received_events","type":"Organization","site_admin":false},"repo":{"id":70748937,"name":"big-red-shuttle","full_name":"cuappdev/big-red-shuttle","owner":{"login":"cuappdev","id":17533691,"avatar_url":"https://avatars.githubusercontent.com/u/17533691?v=3","gravatar_id":"","url":"https://api.github.com/users/cuappdev","html_url":"https://github.com/cuappdev","followers_url":"https://api.github.com/users/cuappdev/followers","following_url":"https://api.github.com/users/cuappdev/following{/other_user}","gists_url":"https://api.github.com/users/cuappdev/gists{/gist_id}","starred_url":"https://api.github.com/users/cuappdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuappdev/subscriptions","organizations_url":"https://api.github.com/users/cuappdev/orgs","repos_url":"https://api.github.com/users/cuappdev/repos","events_url":"https://api.github.com/users/cuappdev/events{/privacy}","received_events_url":"https://api.github.com/users/cuappdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cuappdev/big-red-shuttle","description":null,"fork":false,"url":"https://api.github.com/repos/cuappdev/big-red-shuttle","forks_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/forks","keys_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/teams","hooks_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/hooks","issue_events_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/issues/events{/number}","events_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/events","assignees_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/assignees{/user}","branches_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/branches{/branch}","tags_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/tags","blobs_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/git/refs{/sha}","trees_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/statuses/{sha}","languages_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/languages","stargazers_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/stargazers","contributors_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/contributors","subscribers_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/subscribers","subscription_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/subscription","commits_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/commits{/sha}","git_commits_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/git/commits{/sha}","comments_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/comments{/number}","issue_comment_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/issues/comments{/number}","contents_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/contents/{+path}","compare_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/merges","archive_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/downloads","issues_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/issues{/number}","pulls_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/pulls{/number}","milestones_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/milestones{/number}","notifications_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/labels{/name}","releases_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/releases{/id}","deployments_url":"https://api.github.com/repos/cuappdev/big-red-shuttle/deployments","created_at":"2016-10-12T23:04:21Z","updated_at":"2016-10-13T21:41:13Z","pushed_at":"2016-11-13T07:59:13Z","git_url":"git://github.com/cuappdev/big-red-shuttle.git","ssh_url":"git@github.com:cuappdev/big-red-shuttle.git","clone_url":"https://github.com/cuappdev/big-red-shuttle.git","svn_url":"https://github.com/cuappdev/big-red-shuttle","homepage":null,"size":129147,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cuappdev/big-red-shuttle/pulls/20"},"html":{"href":"https://github.com/cuappdev/big-red-shuttle/pull/20"},"issue":{"href":"https://api.github.com/repos/cuappdev/big-red-shuttle/issues/20"},"comments":{"href":"https://api.github.com/repos/cuappdev/big-red-shuttle/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/cuappdev/big-red-shuttle/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/cuappdev/big-red-shuttle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cuappdev/big-red-shuttle/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/cuappdev/big-red-shuttle/statuses/f883e6af0ffe7468eedd96a702a7e3bc5cb49b72"}}}}
{"actor":{"display_login":"acheng96"}}