{"action":"created","comment":{"url":"https://api.github.com/repos/confluentinc/ducktape/pulls/comments/74152707","id":74152707,"diff_hunk":"@@ -38,3 +38,12 @@ def configured(self):\n \n     def configure_logger(self):\n         raise NotImplementedError(\"configure_logger property must be implemented by a subclass\")\n+\n+    @staticmethod\n+    def close_logger(logger):","path":"ducktape/tests/logger.py","position":6,"original_position":6,"commit_id":"b311a178e5aaa1e00d41f1cc02ac42bbdb62b538","original_commit_id":"14c62660617234cb5a939b5cb0e4d9ece5957188","user":{"login":"ewencp","id":47366,"avatar_url":"https://avatars.githubusercontent.com/u/47366?v=3","gravatar_id":"","url":"https://api.github.com/users/ewencp","html_url":"https://github.com/ewencp","followers_url":"https://api.github.com/users/ewencp/followers","following_url":"https://api.github.com/users/ewencp/following{/other_user}","gists_url":"https://api.github.com/users/ewencp/gists{/gist_id}","starred_url":"https://api.github.com/users/ewencp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewencp/subscriptions","organizations_url":"https://api.github.com/users/ewencp/orgs","repos_url":"https://api.github.com/users/ewencp/repos","events_url":"https://api.github.com/users/ewencp/events{/privacy}","received_events_url":"https://api.github.com/users/ewencp/received_events","type":"User","site_admin":false},"body":"Why is this a static instead of just a member variable? Just to avoid the `if logger is not None` at the call site?","created_at":"2016-08-09T21:58:39Z","updated_at":"2016-08-09T21:58:39Z","html_url":"https://github.com/confluentinc/ducktape/pull/150#discussion_r74152707","pull_request_url":"https://api.github.com/repos/confluentinc/ducktape/pulls/150","_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ducktape/pulls/comments/74152707"},"html":{"href":"https://github.com/confluentinc/ducktape/pull/150#discussion_r74152707"},"pull_request":{"href":"https://api.github.com/repos/confluentinc/ducktape/pulls/150"}}},"pull_request":{"url":"https://api.github.com/repos/confluentinc/ducktape/pulls/150","id":80567285,"html_url":"https://github.com/confluentinc/ducktape/pull/150","diff_url":"https://github.com/confluentinc/ducktape/pull/150.diff","patch_url":"https://github.com/confluentinc/ducktape/pull/150.patch","issue_url":"https://api.github.com/repos/confluentinc/ducktape/issues/150","number":150,"state":"open","locked":false,"title":"[WIP]: use paramiko for ssh","user":{"login":"granders","id":1295932,"avatar_url":"https://avatars.githubusercontent.com/u/1295932?v=3","gravatar_id":"","url":"https://api.github.com/users/granders","html_url":"https://github.com/granders","followers_url":"https://api.github.com/users/granders/followers","following_url":"https://api.github.com/users/granders/following{/other_user}","gists_url":"https://api.github.com/users/granders/gists{/gist_id}","starred_url":"https://api.github.com/users/granders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granders/subscriptions","organizations_url":"https://api.github.com/users/granders/orgs","repos_url":"https://api.github.com/users/granders/repos","events_url":"https://api.github.com/users/granders/events{/privacy}","received_events_url":"https://api.github.com/users/granders/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-09T06:22:49Z","updated_at":"2016-08-09T21:58:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0426fac8a676a3c97b6e391e07b6f710179d1a77","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/ducktape/pulls/150/commits","review_comments_url":"https://api.github.com/repos/confluentinc/ducktape/pulls/150/comments","review_comment_url":"https://api.github.com/repos/confluentinc/ducktape/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/ducktape/issues/150/comments","statuses_url":"https://api.github.com/repos/confluentinc/ducktape/statuses/b311a178e5aaa1e00d41f1cc02ac42bbdb62b538","head":{"label":"confluentinc:try-paramiko","ref":"try-paramiko","sha":"b311a178e5aaa1e00d41f1cc02ac42bbdb62b538","user":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":28360638,"name":"ducktape","full_name":"confluentinc/ducktape","owner":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/ducktape","description":"System integration and performance tests","fork":false,"url":"https://api.github.com/repos/confluentinc/ducktape","forks_url":"https://api.github.com/repos/confluentinc/ducktape/forks","keys_url":"https://api.github.com/repos/confluentinc/ducktape/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/ducktape/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/ducktape/teams","hooks_url":"https://api.github.com/repos/confluentinc/ducktape/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/ducktape/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/ducktape/events","assignees_url":"https://api.github.com/repos/confluentinc/ducktape/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/ducktape/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/ducktape/tags","blobs_url":"https://api.github.com/repos/confluentinc/ducktape/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/ducktape/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/ducktape/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/ducktape/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/ducktape/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/ducktape/languages","stargazers_url":"https://api.github.com/repos/confluentinc/ducktape/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/ducktape/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/ducktape/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/ducktape/subscription","commits_url":"https://api.github.com/repos/confluentinc/ducktape/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/ducktape/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/ducktape/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/ducktape/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/ducktape/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/ducktape/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/ducktape/merges","archive_url":"https://api.github.com/repos/confluentinc/ducktape/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/ducktape/downloads","issues_url":"https://api.github.com/repos/confluentinc/ducktape/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/ducktape/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/ducktape/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/ducktape/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/ducktape/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/ducktape/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/ducktape/deployments","created_at":"2014-12-22T21:38:32Z","updated_at":"2016-08-07T03:29:29Z","pushed_at":"2016-08-09T20:17:34Z","git_url":"git://github.com/confluentinc/ducktape.git","ssh_url":"git@github.com:confluentinc/ducktape.git","clone_url":"https://github.com/confluentinc/ducktape.git","svn_url":"https://github.com/confluentinc/ducktape","homepage":null,"size":731,"stargazers_count":36,"watchers_count":36,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":36,"forks":10,"open_issues":36,"watchers":36,"default_branch":"master"}},"base":{"label":"confluentinc:parallel-test-runner","ref":"parallel-test-runner","sha":"5785b9d0c8e4fd467a749c093d45ba48d94feef8","user":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":28360638,"name":"ducktape","full_name":"confluentinc/ducktape","owner":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/ducktape","description":"System integration and performance tests","fork":false,"url":"https://api.github.com/repos/confluentinc/ducktape","forks_url":"https://api.github.com/repos/confluentinc/ducktape/forks","keys_url":"https://api.github.com/repos/confluentinc/ducktape/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/ducktape/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/ducktape/teams","hooks_url":"https://api.github.com/repos/confluentinc/ducktape/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/ducktape/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/ducktape/events","assignees_url":"https://api.github.com/repos/confluentinc/ducktape/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/ducktape/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/ducktape/tags","blobs_url":"https://api.github.com/repos/confluentinc/ducktape/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/ducktape/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/ducktape/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/ducktape/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/ducktape/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/ducktape/languages","stargazers_url":"https://api.github.com/repos/confluentinc/ducktape/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/ducktape/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/ducktape/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/ducktape/subscription","commits_url":"https://api.github.com/repos/confluentinc/ducktape/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/ducktape/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/ducktape/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/ducktape/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/ducktape/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/ducktape/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/ducktape/merges","archive_url":"https://api.github.com/repos/confluentinc/ducktape/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/ducktape/downloads","issues_url":"https://api.github.com/repos/confluentinc/ducktape/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/ducktape/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/ducktape/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/ducktape/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/ducktape/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/ducktape/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/ducktape/deployments","created_at":"2014-12-22T21:38:32Z","updated_at":"2016-08-07T03:29:29Z","pushed_at":"2016-08-09T20:17:34Z","git_url":"git://github.com/confluentinc/ducktape.git","ssh_url":"git@github.com:confluentinc/ducktape.git","clone_url":"https://github.com/confluentinc/ducktape.git","svn_url":"https://github.com/confluentinc/ducktape","homepage":null,"size":731,"stargazers_count":36,"watchers_count":36,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":36,"forks":10,"open_issues":36,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ducktape/pulls/150"},"html":{"href":"https://github.com/confluentinc/ducktape/pull/150"},"issue":{"href":"https://api.github.com/repos/confluentinc/ducktape/issues/150"},"comments":{"href":"https://api.github.com/repos/confluentinc/ducktape/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/ducktape/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/ducktape/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/ducktape/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/ducktape/statuses/b311a178e5aaa1e00d41f1cc02ac42bbdb62b538"}}}}
{"actor":{"display_login":"ewencp"}}