{"action":"created","issue":{"url":"https://api.github.com/repos/sportngin/saml_idp/issues/37","repository_url":"https://api.github.com/repos/sportngin/saml_idp","labels_url":"https://api.github.com/repos/sportngin/saml_idp/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/sportngin/saml_idp/issues/37/comments","events_url":"https://api.github.com/repos/sportngin/saml_idp/issues/37/events","html_url":"https://github.com/sportngin/saml_idp/issues/37","id":139685325,"number":37,"title":"Service Provider never gets the sign assertion flag from incoming SP metadata","user":{"login":"Yanchek99","id":611022,"avatar_url":"https://avatars.githubusercontent.com/u/611022?v=3","gravatar_id":"","url":"https://api.github.com/users/Yanchek99","html_url":"https://github.com/Yanchek99","followers_url":"https://api.github.com/users/Yanchek99/followers","following_url":"https://api.github.com/users/Yanchek99/following{/other_user}","gists_url":"https://api.github.com/users/Yanchek99/gists{/gist_id}","starred_url":"https://api.github.com/users/Yanchek99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yanchek99/subscriptions","organizations_url":"https://api.github.com/users/Yanchek99/orgs","repos_url":"https://api.github.com/users/Yanchek99/repos","events_url":"https://api.github.com/users/Yanchek99/events{/privacy}","received_events_url":"https://api.github.com/users/Yanchek99/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-03-09T20:03:42Z","updated_at":"2016-06-07T16:19:31Z","closed_at":"2016-06-07T16:19:31Z","body":"The ServiceProvider object will never get the sign assertions flag from incoming metadata because it is calling from the wrong method signature.  `sign_assertions` vs `sign_assertions`? \r\n\r\nhttps://github.com/sportngin/saml_idp/blob/master/lib/saml_idp/service_provider.rb#L27\r\n^ Here we can see it checking for a `sign_assertions?` method here `current_metadata.respond_to?(:sign_assertions?) && current_metadata.sign_assertions?`\r\n\r\nhttps://github.com/sportngin/saml_idp/blob/master/lib/saml_idp/incoming_metadata.rb#L19\r\n^ Here we can see that incoming_metadata.rb has no `sign_assertions?` method but instead has a `sign_assertions` method."},"comment":{"url":"https://api.github.com/repos/sportngin/saml_idp/issues/comments/224333612","html_url":"https://github.com/sportngin/saml_idp/issues/37#issuecomment-224333612","issue_url":"https://api.github.com/repos/sportngin/saml_idp/issues/37","id":224333612,"user":{"login":"jphenow","id":319230,"avatar_url":"https://avatars.githubusercontent.com/u/319230?v=3","gravatar_id":"","url":"https://api.github.com/users/jphenow","html_url":"https://github.com/jphenow","followers_url":"https://api.github.com/users/jphenow/followers","following_url":"https://api.github.com/users/jphenow/following{/other_user}","gists_url":"https://api.github.com/users/jphenow/gists{/gist_id}","starred_url":"https://api.github.com/users/jphenow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jphenow/subscriptions","organizations_url":"https://api.github.com/users/jphenow/orgs","repos_url":"https://api.github.com/users/jphenow/repos","events_url":"https://api.github.com/users/jphenow/events{/privacy}","received_events_url":"https://api.github.com/users/jphenow/received_events","type":"User","site_admin":false},"created_at":"2016-06-07T16:19:31Z","updated_at":"2016-06-07T16:19:31Z","body":"Closing for now since it sounds like this was more of a misunderstanding for now. If there are enhancement suggestions or explicit bugs we can discuss and reopen or open new issues as a result."}}
{"actor":{"display_login":"jphenow"}}