{"action":"created","issue":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1531","repository_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine","labels_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1531/labels{/name}","comments_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1531/comments","events_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1531/events","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1531","id":182590138,"number":1531,"title":"Implement Vertical rooms","user":{"login":"koosemose","id":6334643,"avatar_url":"https://avatars.githubusercontent.com/u/6334643?v=3","gravatar_id":"","url":"https://api.github.com/users/koosemose","html_url":"https://github.com/koosemose","followers_url":"https://api.github.com/users/koosemose/followers","following_url":"https://api.github.com/users/koosemose/following{/other_user}","gists_url":"https://api.github.com/users/koosemose/gists{/gist_id}","starred_url":"https://api.github.com/users/koosemose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koosemose/subscriptions","organizations_url":"https://api.github.com/users/koosemose/orgs","repos_url":"https://api.github.com/users/koosemose/repos","events_url":"https://api.github.com/users/koosemose/events{/privacy}","received_events_url":"https://api.github.com/users/koosemose/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/milestones/2","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/milestones/Version%200.2","labels_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/milestones/2/labels","id":2048498,"number":2,"title":"Version 0.2","description":"See https://github.com/TeamPorcupine/ProjectPorcupine/issues/1465 and https://github.com/TeamPorcupine/ProjectPorcupine/wiki/Milestone-0.2.","creator":{"login":"mikejbrown","id":855931,"avatar_url":"https://avatars.githubusercontent.com/u/855931?v=3","gravatar_id":"","url":"https://api.github.com/users/mikejbrown","html_url":"https://github.com/mikejbrown","followers_url":"https://api.github.com/users/mikejbrown/followers","following_url":"https://api.github.com/users/mikejbrown/following{/other_user}","gists_url":"https://api.github.com/users/mikejbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/mikejbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikejbrown/subscriptions","organizations_url":"https://api.github.com/users/mikejbrown/orgs","repos_url":"https://api.github.com/users/mikejbrown/repos","events_url":"https://api.github.com/users/mikejbrown/events{/privacy}","received_events_url":"https://api.github.com/users/mikejbrown/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":4,"state":"open","created_at":"2016-10-05T03:36:35Z","updated_at":"2016-10-16T15:51:18Z","due_on":"2017-01-01T00:00:00Z","closed_at":null},"comments":6,"created_at":"2016-10-12T17:51:22Z","updated_at":"2016-10-16T20:41:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/pulls/1531","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1531","diff_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1531.diff","patch_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1531.patch"},"body":"Currently rooms are single level only, and don't change when a tile within them is changed to empty.\r\n\r\nThis PR makes floodfill for room expand into 3 dimensions, and calls floodfilling when a tile is changed.\r\n\r\nIntended Behavior: Rooms on top level have a \"magic\" roof, and do not require anything above them to enclose them, rooms on lower levels require some kind of floor (i.e. not TileType.Empty) on the level above to act as roof. A room created across 2 z-Levels should have the same room index (and for all intents and purposes be a single room) if the upper floor doesn't completely separate it, and separate into two different rooms if the upper floor has its floor completely filled in.\r\n\r\nCloses #1491"},"comment":{"url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/comments/254073225","html_url":"https://github.com/TeamPorcupine/ProjectPorcupine/pull/1531#issuecomment-254073225","issue_url":"https://api.github.com/repos/TeamPorcupine/ProjectPorcupine/issues/1531","id":254073225,"user":{"login":"koosemose","id":6334643,"avatar_url":"https://avatars.githubusercontent.com/u/6334643?v=3","gravatar_id":"","url":"https://api.github.com/users/koosemose","html_url":"https://github.com/koosemose","followers_url":"https://api.github.com/users/koosemose/followers","following_url":"https://api.github.com/users/koosemose/following{/other_user}","gists_url":"https://api.github.com/users/koosemose/gists{/gist_id}","starred_url":"https://api.github.com/users/koosemose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koosemose/subscriptions","organizations_url":"https://api.github.com/users/koosemose/orgs","repos_url":"https://api.github.com/users/koosemose/repos","events_url":"https://api.github.com/users/koosemose/events{/privacy}","received_events_url":"https://api.github.com/users/koosemose/received_events","type":"User","site_admin":false},"created_at":"2016-10-16T20:41:01Z","updated_at":"2016-10-16T20:41:01Z","body":"Urgh, more annoying weirdness from TileType. Since it doesn't function like Furniture or Utilities and is just a change of the tile's Type, there's not anywhere to easily have it not do a roomfloodfill on a load... \r\n\r\nI'll see if I can find a workaround, I think if I check for a null room when doing a floodfill from tile placement... that might do it, as long as we continue to require floor to be under any furniture, or at least enclosing furniture."}}
{"actor":{"display_login":"koosemose"}}