{"action":"created","comment":{"url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/pulls/comments/51505130","id":51505130,"diff_hunk":"@@ -25,10 +25,11 @@ var KNOWN_STATICS = {\n };\n \n module.exports = function hoistNonReactStatics(targetComponent, sourceComponent) {\n-    var keys = Object.getOwnPropertyNames(sourceComponent);\n-    for (var i=0; i<keys.length; ++i) {\n-        if (!REACT_STATICS[keys[i]] && !KNOWN_STATICS[keys[i]]) {\n-            targetComponent[keys[i]] = sourceComponent[keys[i]];\n+    var sourceKeys = Object.getOwnPropertyNames(sourceComponent),\n+        targetKeys = Object.getOwnPropertyNames(targetComponent);\n+    for (var i=0; i<sourceKeys.length; ++i) {\n+        if (!REACT_STATICS[sourceKeys[i]] && !KNOWN_STATICS[sourceKeys[i]] && targetKeys.indexOf(sourceKeys[i]) === -1) {","path":"index.js","position":11,"original_position":11,"commit_id":"0808faad1d280231356c5dcaa9c3f538195af007","original_commit_id":"0808faad1d280231356c5dcaa9c3f538195af007","user":{"login":"mridgway","id":191142,"avatar_url":"https://avatars.githubusercontent.com/u/191142?v=3","gravatar_id":"","url":"https://api.github.com/users/mridgway","html_url":"https://github.com/mridgway","followers_url":"https://api.github.com/users/mridgway/followers","following_url":"https://api.github.com/users/mridgway/following{/other_user}","gists_url":"https://api.github.com/users/mridgway/gists{/gist_id}","starred_url":"https://api.github.com/users/mridgway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mridgway/subscriptions","organizations_url":"https://api.github.com/users/mridgway/orgs","repos_url":"https://api.github.com/users/mridgway/repos","events_url":"https://api.github.com/users/mridgway/events{/privacy}","received_events_url":"https://api.github.com/users/mridgway/received_events","type":"User","site_admin":false},"body":"Alright, let's do that then for now.","created_at":"2016-02-02T00:35:11Z","updated_at":"2016-02-02T00:35:11Z","html_url":"https://github.com/mridgway/hoist-non-react-statics/pull/9#discussion_r51505130","pull_request_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/mridgway/hoist-non-react-statics/pulls/comments/51505130"},"html":{"href":"https://github.com/mridgway/hoist-non-react-statics/pull/9#discussion_r51505130"},"pull_request":{"href":"https://api.github.com/repos/mridgway/hoist-non-react-statics/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/pulls/9","id":57889290,"html_url":"https://github.com/mridgway/hoist-non-react-statics/pull/9","diff_url":"https://github.com/mridgway/hoist-non-react-statics/pull/9.diff","patch_url":"https://github.com/mridgway/hoist-non-react-statics/pull/9.patch","issue_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/issues/9","number":9,"state":"open","locked":false,"title":"Do not overwrite existing keys (fixes #7)","user":{"login":"gajus","id":973543,"avatar_url":"https://avatars.githubusercontent.com/u/973543?v=3","gravatar_id":"","url":"https://api.github.com/users/gajus","html_url":"https://github.com/gajus","followers_url":"https://api.github.com/users/gajus/followers","following_url":"https://api.github.com/users/gajus/following{/other_user}","gists_url":"https://api.github.com/users/gajus/gists{/gist_id}","starred_url":"https://api.github.com/users/gajus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gajus/subscriptions","organizations_url":"https://api.github.com/users/gajus/orgs","repos_url":"https://api.github.com/users/gajus/repos","events_url":"https://api.github.com/users/gajus/events{/privacy}","received_events_url":"https://api.github.com/users/gajus/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-01T19:44:00Z","updated_at":"2016-02-02T00:35:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41792ecc8337458c64155360930b7a9a054f10ec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/pulls/9/commits","review_comments_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/pulls/9/comments","review_comment_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/issues/9/comments","statuses_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/statuses/0808faad1d280231356c5dcaa9c3f538195af007","head":{"label":"gajus:issue-7","ref":"issue-7","sha":"0808faad1d280231356c5dcaa9c3f538195af007","user":{"login":"gajus","id":973543,"avatar_url":"https://avatars.githubusercontent.com/u/973543?v=3","gravatar_id":"","url":"https://api.github.com/users/gajus","html_url":"https://github.com/gajus","followers_url":"https://api.github.com/users/gajus/followers","following_url":"https://api.github.com/users/gajus/following{/other_user}","gists_url":"https://api.github.com/users/gajus/gists{/gist_id}","starred_url":"https://api.github.com/users/gajus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gajus/subscriptions","organizations_url":"https://api.github.com/users/gajus/orgs","repos_url":"https://api.github.com/users/gajus/repos","events_url":"https://api.github.com/users/gajus/events{/privacy}","received_events_url":"https://api.github.com/users/gajus/received_events","type":"User","site_admin":false},"repo":{"id":50851423,"name":"hoist-non-react-statics","full_name":"gajus/hoist-non-react-statics","owner":{"login":"gajus","id":973543,"avatar_url":"https://avatars.githubusercontent.com/u/973543?v=3","gravatar_id":"","url":"https://api.github.com/users/gajus","html_url":"https://github.com/gajus","followers_url":"https://api.github.com/users/gajus/followers","following_url":"https://api.github.com/users/gajus/following{/other_user}","gists_url":"https://api.github.com/users/gajus/gists{/gist_id}","starred_url":"https://api.github.com/users/gajus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gajus/subscriptions","organizations_url":"https://api.github.com/users/gajus/orgs","repos_url":"https://api.github.com/users/gajus/repos","events_url":"https://api.github.com/users/gajus/events{/privacy}","received_events_url":"https://api.github.com/users/gajus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gajus/hoist-non-react-statics","description":"Copies non-react specific statics from a child component to a parent component","fork":true,"url":"https://api.github.com/repos/gajus/hoist-non-react-statics","forks_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/forks","keys_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/teams","hooks_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/hooks","issue_events_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/issues/events{/number}","events_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/events","assignees_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/assignees{/user}","branches_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/branches{/branch}","tags_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/tags","blobs_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/git/refs{/sha}","trees_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/statuses/{sha}","languages_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/languages","stargazers_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/stargazers","contributors_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/contributors","subscribers_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/subscribers","subscription_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/subscription","commits_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/commits{/sha}","git_commits_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/git/commits{/sha}","comments_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/comments{/number}","issue_comment_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/issues/comments{/number}","contents_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/contents/{+path}","compare_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/merges","archive_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/downloads","issues_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/issues{/number}","pulls_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/pulls{/number}","milestones_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/milestones{/number}","notifications_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/labels{/name}","releases_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/releases{/id}","deployments_url":"https://api.github.com/repos/gajus/hoist-non-react-statics/deployments","created_at":"2016-02-01T16:09:23Z","updated_at":"2016-02-01T16:09:23Z","pushed_at":"2016-02-01T19:43:33Z","git_url":"git://github.com/gajus/hoist-non-react-statics.git","ssh_url":"git@github.com:gajus/hoist-non-react-statics.git","clone_url":"https://github.com/gajus/hoist-non-react-statics.git","svn_url":"https://github.com/gajus/hoist-non-react-statics","homepage":null,"size":9,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mridgway:master","ref":"master","sha":"db044f2f45fe80a4d189e873385a5de9a0e12035","user":{"login":"mridgway","id":191142,"avatar_url":"https://avatars.githubusercontent.com/u/191142?v=3","gravatar_id":"","url":"https://api.github.com/users/mridgway","html_url":"https://github.com/mridgway","followers_url":"https://api.github.com/users/mridgway/followers","following_url":"https://api.github.com/users/mridgway/following{/other_user}","gists_url":"https://api.github.com/users/mridgway/gists{/gist_id}","starred_url":"https://api.github.com/users/mridgway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mridgway/subscriptions","organizations_url":"https://api.github.com/users/mridgway/orgs","repos_url":"https://api.github.com/users/mridgway/repos","events_url":"https://api.github.com/users/mridgway/events{/privacy}","received_events_url":"https://api.github.com/users/mridgway/received_events","type":"User","site_admin":false},"repo":{"id":36402138,"name":"hoist-non-react-statics","full_name":"mridgway/hoist-non-react-statics","owner":{"login":"mridgway","id":191142,"avatar_url":"https://avatars.githubusercontent.com/u/191142?v=3","gravatar_id":"","url":"https://api.github.com/users/mridgway","html_url":"https://github.com/mridgway","followers_url":"https://api.github.com/users/mridgway/followers","following_url":"https://api.github.com/users/mridgway/following{/other_user}","gists_url":"https://api.github.com/users/mridgway/gists{/gist_id}","starred_url":"https://api.github.com/users/mridgway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mridgway/subscriptions","organizations_url":"https://api.github.com/users/mridgway/orgs","repos_url":"https://api.github.com/users/mridgway/repos","events_url":"https://api.github.com/users/mridgway/events{/privacy}","received_events_url":"https://api.github.com/users/mridgway/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mridgway/hoist-non-react-statics","description":"Copies non-react specific statics from a child component to a parent component","fork":false,"url":"https://api.github.com/repos/mridgway/hoist-non-react-statics","forks_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/forks","keys_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/teams","hooks_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/hooks","issue_events_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/issues/events{/number}","events_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/events","assignees_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/assignees{/user}","branches_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/branches{/branch}","tags_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/tags","blobs_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/git/refs{/sha}","trees_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/statuses/{sha}","languages_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/languages","stargazers_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/stargazers","contributors_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/contributors","subscribers_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/subscribers","subscription_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/subscription","commits_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/commits{/sha}","git_commits_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/git/commits{/sha}","comments_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/comments{/number}","issue_comment_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/issues/comments{/number}","contents_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/contents/{+path}","compare_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/merges","archive_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/downloads","issues_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/issues{/number}","pulls_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/pulls{/number}","milestones_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/milestones{/number}","notifications_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/labels{/name}","releases_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/releases{/id}","deployments_url":"https://api.github.com/repos/mridgway/hoist-non-react-statics/deployments","created_at":"2015-05-27T23:28:29Z","updated_at":"2016-02-01T18:21:43Z","pushed_at":"2016-02-01T19:44:01Z","git_url":"git://github.com/mridgway/hoist-non-react-statics.git","ssh_url":"git@github.com:mridgway/hoist-non-react-statics.git","clone_url":"https://github.com/mridgway/hoist-non-react-statics.git","svn_url":"https://github.com/mridgway/hoist-non-react-statics","homepage":null,"size":10,"stargazers_count":44,"watchers_count":44,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mridgway/hoist-non-react-statics/pulls/9"},"html":{"href":"https://github.com/mridgway/hoist-non-react-statics/pull/9"},"issue":{"href":"https://api.github.com/repos/mridgway/hoist-non-react-statics/issues/9"},"comments":{"href":"https://api.github.com/repos/mridgway/hoist-non-react-statics/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/mridgway/hoist-non-react-statics/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/mridgway/hoist-non-react-statics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mridgway/hoist-non-react-statics/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/mridgway/hoist-non-react-statics/statuses/0808faad1d280231356c5dcaa9c3f538195af007"}}}}