{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6744","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6744/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6744/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6744/events","html_url":"https://github.com/cockroachdb/cockroach/pull/6744","id":155170228,"number":6744,"title":"ui next: UIData reducer.","user":{"login":"mrtracy","id":6969858,"avatar_url":"https://avatars.githubusercontent.com/u/6969858?v=3","gravatar_id":"","url":"https://api.github.com/users/mrtracy","html_url":"https://github.com/mrtracy","followers_url":"https://api.github.com/users/mrtracy/followers","following_url":"https://api.github.com/users/mrtracy/following{/other_user}","gists_url":"https://api.github.com/users/mrtracy/gists{/gist_id}","starred_url":"https://api.github.com/users/mrtracy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrtracy/subscriptions","organizations_url":"https://api.github.com/users/mrtracy/orgs","repos_url":"https://api.github.com/users/mrtracy/repos","events_url":"https://api.github.com/users/mrtracy/events{/privacy}","received_events_url":"https://api.github.com/users/mrtracy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"maxlang","id":3691886,"avatar_url":"https://avatars.githubusercontent.com/u/3691886?v=3","gravatar_id":"","url":"https://api.github.com/users/maxlang","html_url":"https://github.com/maxlang","followers_url":"https://api.github.com/users/maxlang/followers","following_url":"https://api.github.com/users/maxlang/following{/other_user}","gists_url":"https://api.github.com/users/maxlang/gists{/gist_id}","starred_url":"https://api.github.com/users/maxlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxlang/subscriptions","organizations_url":"https://api.github.com/users/maxlang/orgs","repos_url":"https://api.github.com/users/maxlang/repos","events_url":"https://api.github.com/users/maxlang/events{/privacy}","received_events_url":"https://api.github.com/users/maxlang/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2016-05-17T03:36:57Z","updated_at":"2016-05-17T06:15:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6744","html_url":"https://github.com/cockroachdb/cockroach/pull/6744","diff_url":"https://github.com/cockroachdb/cockroach/pull/6744.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/6744.patch"},"body":"Create reducer for storing persisted UIData to the server. The reducer is very\r\nsimple, but includes the important `saveUIData` and `loadUIData` asynchronous\r\naction creators. These action creates are responsible for properly encoding and\r\ndecoding UIData for storage on the server.\r\n\r\nCommit also adds admin server protos into the compiled javascript protobuf set.\r\nDue to an unexpected syntax incompatibility with typescript, one field in the\r\nprotobuf definition had to be renamed from `default` to `default_value`\r\n(\"default\" being a reserved word in typescript).\r\n\r\nCommit also has a locally updated typings definition for ByteBuffer.js, which is\r\nexactly the same change previously made to Long.js. These changes will\r\neventually be pushed back to DefinitelyTyped, but are locally referenced to\r\navoid being blocked.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/6744)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/219628672","html_url":"https://github.com/cockroachdb/cockroach/pull/6744#issuecomment-219628672","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6744","id":219628672,"user":{"login":"maxlang","id":3691886,"avatar_url":"https://avatars.githubusercontent.com/u/3691886?v=3","gravatar_id":"","url":"https://api.github.com/users/maxlang","html_url":"https://github.com/maxlang","followers_url":"https://api.github.com/users/maxlang/followers","following_url":"https://api.github.com/users/maxlang/following{/other_user}","gists_url":"https://api.github.com/users/maxlang/gists{/gist_id}","starred_url":"https://api.github.com/users/maxlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxlang/subscriptions","organizations_url":"https://api.github.com/users/maxlang/orgs","repos_url":"https://api.github.com/users/maxlang/repos","events_url":"https://api.github.com/users/maxlang/events{/privacy}","received_events_url":"https://api.github.com/users/maxlang/received_events","type":"User","site_admin":false},"created_at":"2016-05-17T06:15:17Z","updated_at":"2016-05-17T06:15:17Z","body":"\n\n\n\n\n\nReview status: 12 of 13 files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.\n\n---\n\n*[ui/next/app/redux/uiData.ts, line 152 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/6744#-KHwu1oDG8xYpm1XUCPP:-KHxLHrhoiUADzWAH3e7:55296286) ([raw file](https://github.com/cockroachdb/cockroach/blob/c39c659f29dc6090476f912689b7b8655eedff69/ui/next/app/redux/uiData.ts#L152)):*\n<details><summary><i>Previously, maxlang (Max Lang) wrote…</i></summary>\n> Why is `response.json()` a `Promise`?</details>\nNevermind, I see it's part of the spec\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/6744)*\n<!-- Sent from Reviewable.io -->\n"}}