{"action":"created","comment":{"url":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/comments/66235693","id":66235693,"diff_hunk":"@@ -0,0 +1,45 @@\n+from collections import OrderedDict\n+\n+from malcolm.core.attributemeta import AttributeMeta\n+from malcolm.core.monitorable import Monitorable\n+\n+\n+class Attribute(Monitorable):\n+    \"\"\"Represents a value with type information that may be backed elsewhere\"\"\"\n+\n+    def __init__(self, name, meta):\n+        super(Attribute, self).__init__(name=name)\n+        self.meta = meta\n+        self.value = None\n+        self.put_func = None\n+\n+    def set_put_function(self, func):\n+        self.put_func = func\n+\n+    def put(self, value):\n+        \"\"\"Call the put function with the given value\"\"\"\n+        self.put_func(value)\n+\n+    def set_value(self, value):\n+        self.value = value","path":"malcolm/core/attribute.py","position":24,"original_position":24,"commit_id":"0997c8cfdab112142239d7d3fa2ecf18c997cdad","original_commit_id":"0997c8cfdab112142239d7d3fa2ecf18c997cdad","user":{"login":"thomascobb","id":7705060,"avatar_url":"https://avatars.githubusercontent.com/u/7705060?v=3","gravatar_id":"","url":"https://api.github.com/users/thomascobb","html_url":"https://github.com/thomascobb","followers_url":"https://api.github.com/users/thomascobb/followers","following_url":"https://api.github.com/users/thomascobb/following{/other_user}","gists_url":"https://api.github.com/users/thomascobb/gists{/gist_id}","starred_url":"https://api.github.com/users/thomascobb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomascobb/subscriptions","organizations_url":"https://api.github.com/users/thomascobb/orgs","repos_url":"https://api.github.com/users/thomascobb/repos","events_url":"https://api.github.com/users/thomascobb/events{/privacy}","received_events_url":"https://api.github.com/users/thomascobb/received_events","type":"User","site_admin":false},"body":"Should call self.on_changed([[\"value\"], value])","created_at":"2016-06-08T11:05:21Z","updated_at":"2016-06-08T11:05:21Z","html_url":"https://github.com/dls-controls/pymalcolm/pull/44#discussion_r66235693","pull_request_url":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/comments/66235693"},"html":{"href":"https://github.com/dls-controls/pymalcolm/pull/44#discussion_r66235693"},"pull_request":{"href":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/44","id":73026167,"html_url":"https://github.com/dls-controls/pymalcolm/pull/44","diff_url":"https://github.com/dls-controls/pymalcolm/pull/44.diff","patch_url":"https://github.com/dls-controls/pymalcolm/pull/44.patch","issue_url":"https://api.github.com/repos/dls-controls/pymalcolm/issues/44","number":44,"state":"open","locked":false,"title":"Add Attribute class","user":{"login":"xen-0","id":3749031,"avatar_url":"https://avatars.githubusercontent.com/u/3749031?v=3","gravatar_id":"","url":"https://api.github.com/users/xen-0","html_url":"https://github.com/xen-0","followers_url":"https://api.github.com/users/xen-0/followers","following_url":"https://api.github.com/users/xen-0/following{/other_user}","gists_url":"https://api.github.com/users/xen-0/gists{/gist_id}","starred_url":"https://api.github.com/users/xen-0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xen-0/subscriptions","organizations_url":"https://api.github.com/users/xen-0/orgs","repos_url":"https://api.github.com/users/xen-0/repos","events_url":"https://api.github.com/users/xen-0/events{/privacy}","received_events_url":"https://api.github.com/users/xen-0/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-08T10:58:18Z","updated_at":"2016-06-08T11:05:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1ecae2223105d3a78d74d592a195b75cfe7c5bb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/44/commits","review_comments_url":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/44/comments","review_comment_url":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dls-controls/pymalcolm/issues/44/comments","statuses_url":"https://api.github.com/repos/dls-controls/pymalcolm/statuses/0997c8cfdab112142239d7d3fa2ecf18c997cdad","head":{"label":"dls-controls:attribute","ref":"attribute","sha":"0997c8cfdab112142239d7d3fa2ecf18c997cdad","user":{"login":"dls-controls","id":8448831,"avatar_url":"https://avatars.githubusercontent.com/u/8448831?v=3","gravatar_id":"","url":"https://api.github.com/users/dls-controls","html_url":"https://github.com/dls-controls","followers_url":"https://api.github.com/users/dls-controls/followers","following_url":"https://api.github.com/users/dls-controls/following{/other_user}","gists_url":"https://api.github.com/users/dls-controls/gists{/gist_id}","starred_url":"https://api.github.com/users/dls-controls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dls-controls/subscriptions","organizations_url":"https://api.github.com/users/dls-controls/orgs","repos_url":"https://api.github.com/users/dls-controls/repos","events_url":"https://api.github.com/users/dls-controls/events{/privacy}","received_events_url":"https://api.github.com/users/dls-controls/received_events","type":"Organization","site_admin":false},"repo":{"id":51362478,"name":"pymalcolm","full_name":"dls-controls/pymalcolm","owner":{"login":"dls-controls","id":8448831,"avatar_url":"https://avatars.githubusercontent.com/u/8448831?v=3","gravatar_id":"","url":"https://api.github.com/users/dls-controls","html_url":"https://github.com/dls-controls","followers_url":"https://api.github.com/users/dls-controls/followers","following_url":"https://api.github.com/users/dls-controls/following{/other_user}","gists_url":"https://api.github.com/users/dls-controls/gists{/gist_id}","starred_url":"https://api.github.com/users/dls-controls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dls-controls/subscriptions","organizations_url":"https://api.github.com/users/dls-controls/orgs","repos_url":"https://api.github.com/users/dls-controls/repos","events_url":"https://api.github.com/users/dls-controls/events{/privacy}","received_events_url":"https://api.github.com/users/dls-controls/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dls-controls/pymalcolm","description":"Scanning in the middlelayer, v2","fork":false,"url":"https://api.github.com/repos/dls-controls/pymalcolm","forks_url":"https://api.github.com/repos/dls-controls/pymalcolm/forks","keys_url":"https://api.github.com/repos/dls-controls/pymalcolm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dls-controls/pymalcolm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dls-controls/pymalcolm/teams","hooks_url":"https://api.github.com/repos/dls-controls/pymalcolm/hooks","issue_events_url":"https://api.github.com/repos/dls-controls/pymalcolm/issues/events{/number}","events_url":"https://api.github.com/repos/dls-controls/pymalcolm/events","assignees_url":"https://api.github.com/repos/dls-controls/pymalcolm/assignees{/user}","branches_url":"https://api.github.com/repos/dls-controls/pymalcolm/branches{/branch}","tags_url":"https://api.github.com/repos/dls-controls/pymalcolm/tags","blobs_url":"https://api.github.com/repos/dls-controls/pymalcolm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dls-controls/pymalcolm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dls-controls/pymalcolm/git/refs{/sha}","trees_url":"https://api.github.com/repos/dls-controls/pymalcolm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dls-controls/pymalcolm/statuses/{sha}","languages_url":"https://api.github.com/repos/dls-controls/pymalcolm/languages","stargazers_url":"https://api.github.com/repos/dls-controls/pymalcolm/stargazers","contributors_url":"https://api.github.com/repos/dls-controls/pymalcolm/contributors","subscribers_url":"https://api.github.com/repos/dls-controls/pymalcolm/subscribers","subscription_url":"https://api.github.com/repos/dls-controls/pymalcolm/subscription","commits_url":"https://api.github.com/repos/dls-controls/pymalcolm/commits{/sha}","git_commits_url":"https://api.github.com/repos/dls-controls/pymalcolm/git/commits{/sha}","comments_url":"https://api.github.com/repos/dls-controls/pymalcolm/comments{/number}","issue_comment_url":"https://api.github.com/repos/dls-controls/pymalcolm/issues/comments{/number}","contents_url":"https://api.github.com/repos/dls-controls/pymalcolm/contents/{+path}","compare_url":"https://api.github.com/repos/dls-controls/pymalcolm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dls-controls/pymalcolm/merges","archive_url":"https://api.github.com/repos/dls-controls/pymalcolm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dls-controls/pymalcolm/downloads","issues_url":"https://api.github.com/repos/dls-controls/pymalcolm/issues{/number}","pulls_url":"https://api.github.com/repos/dls-controls/pymalcolm/pulls{/number}","milestones_url":"https://api.github.com/repos/dls-controls/pymalcolm/milestones{/number}","notifications_url":"https://api.github.com/repos/dls-controls/pymalcolm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dls-controls/pymalcolm/labels{/name}","releases_url":"https://api.github.com/repos/dls-controls/pymalcolm/releases{/id}","deployments_url":"https://api.github.com/repos/dls-controls/pymalcolm/deployments","created_at":"2016-02-09T11:21:37Z","updated_at":"2016-03-14T14:22:17Z","pushed_at":"2016-06-08T10:58:18Z","git_url":"git://github.com/dls-controls/pymalcolm.git","ssh_url":"git@github.com:dls-controls/pymalcolm.git","clone_url":"https://github.com/dls-controls/pymalcolm.git","svn_url":"https://github.com/dls-controls/pymalcolm","homepage":null,"size":1107,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"dls-controls:master","ref":"master","sha":"2eb7b4412ee3dfd76a9199dcc8e2883221e15da3","user":{"login":"dls-controls","id":8448831,"avatar_url":"https://avatars.githubusercontent.com/u/8448831?v=3","gravatar_id":"","url":"https://api.github.com/users/dls-controls","html_url":"https://github.com/dls-controls","followers_url":"https://api.github.com/users/dls-controls/followers","following_url":"https://api.github.com/users/dls-controls/following{/other_user}","gists_url":"https://api.github.com/users/dls-controls/gists{/gist_id}","starred_url":"https://api.github.com/users/dls-controls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dls-controls/subscriptions","organizations_url":"https://api.github.com/users/dls-controls/orgs","repos_url":"https://api.github.com/users/dls-controls/repos","events_url":"https://api.github.com/users/dls-controls/events{/privacy}","received_events_url":"https://api.github.com/users/dls-controls/received_events","type":"Organization","site_admin":false},"repo":{"id":51362478,"name":"pymalcolm","full_name":"dls-controls/pymalcolm","owner":{"login":"dls-controls","id":8448831,"avatar_url":"https://avatars.githubusercontent.com/u/8448831?v=3","gravatar_id":"","url":"https://api.github.com/users/dls-controls","html_url":"https://github.com/dls-controls","followers_url":"https://api.github.com/users/dls-controls/followers","following_url":"https://api.github.com/users/dls-controls/following{/other_user}","gists_url":"https://api.github.com/users/dls-controls/gists{/gist_id}","starred_url":"https://api.github.com/users/dls-controls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dls-controls/subscriptions","organizations_url":"https://api.github.com/users/dls-controls/orgs","repos_url":"https://api.github.com/users/dls-controls/repos","events_url":"https://api.github.com/users/dls-controls/events{/privacy}","received_events_url":"https://api.github.com/users/dls-controls/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dls-controls/pymalcolm","description":"Scanning in the middlelayer, v2","fork":false,"url":"https://api.github.com/repos/dls-controls/pymalcolm","forks_url":"https://api.github.com/repos/dls-controls/pymalcolm/forks","keys_url":"https://api.github.com/repos/dls-controls/pymalcolm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dls-controls/pymalcolm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dls-controls/pymalcolm/teams","hooks_url":"https://api.github.com/repos/dls-controls/pymalcolm/hooks","issue_events_url":"https://api.github.com/repos/dls-controls/pymalcolm/issues/events{/number}","events_url":"https://api.github.com/repos/dls-controls/pymalcolm/events","assignees_url":"https://api.github.com/repos/dls-controls/pymalcolm/assignees{/user}","branches_url":"https://api.github.com/repos/dls-controls/pymalcolm/branches{/branch}","tags_url":"https://api.github.com/repos/dls-controls/pymalcolm/tags","blobs_url":"https://api.github.com/repos/dls-controls/pymalcolm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dls-controls/pymalcolm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dls-controls/pymalcolm/git/refs{/sha}","trees_url":"https://api.github.com/repos/dls-controls/pymalcolm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dls-controls/pymalcolm/statuses/{sha}","languages_url":"https://api.github.com/repos/dls-controls/pymalcolm/languages","stargazers_url":"https://api.github.com/repos/dls-controls/pymalcolm/stargazers","contributors_url":"https://api.github.com/repos/dls-controls/pymalcolm/contributors","subscribers_url":"https://api.github.com/repos/dls-controls/pymalcolm/subscribers","subscription_url":"https://api.github.com/repos/dls-controls/pymalcolm/subscription","commits_url":"https://api.github.com/repos/dls-controls/pymalcolm/commits{/sha}","git_commits_url":"https://api.github.com/repos/dls-controls/pymalcolm/git/commits{/sha}","comments_url":"https://api.github.com/repos/dls-controls/pymalcolm/comments{/number}","issue_comment_url":"https://api.github.com/repos/dls-controls/pymalcolm/issues/comments{/number}","contents_url":"https://api.github.com/repos/dls-controls/pymalcolm/contents/{+path}","compare_url":"https://api.github.com/repos/dls-controls/pymalcolm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dls-controls/pymalcolm/merges","archive_url":"https://api.github.com/repos/dls-controls/pymalcolm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dls-controls/pymalcolm/downloads","issues_url":"https://api.github.com/repos/dls-controls/pymalcolm/issues{/number}","pulls_url":"https://api.github.com/repos/dls-controls/pymalcolm/pulls{/number}","milestones_url":"https://api.github.com/repos/dls-controls/pymalcolm/milestones{/number}","notifications_url":"https://api.github.com/repos/dls-controls/pymalcolm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dls-controls/pymalcolm/labels{/name}","releases_url":"https://api.github.com/repos/dls-controls/pymalcolm/releases{/id}","deployments_url":"https://api.github.com/repos/dls-controls/pymalcolm/deployments","created_at":"2016-02-09T11:21:37Z","updated_at":"2016-03-14T14:22:17Z","pushed_at":"2016-06-08T10:58:18Z","git_url":"git://github.com/dls-controls/pymalcolm.git","ssh_url":"git@github.com:dls-controls/pymalcolm.git","clone_url":"https://github.com/dls-controls/pymalcolm.git","svn_url":"https://github.com/dls-controls/pymalcolm","homepage":null,"size":1107,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/44"},"html":{"href":"https://github.com/dls-controls/pymalcolm/pull/44"},"issue":{"href":"https://api.github.com/repos/dls-controls/pymalcolm/issues/44"},"comments":{"href":"https://api.github.com/repos/dls-controls/pymalcolm/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dls-controls/pymalcolm/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/dls-controls/pymalcolm/statuses/0997c8cfdab112142239d7d3fa2ecf18c997cdad"}}}}
{"actor":{"display_login":"thomascobb"}}