{"action":"created","comment":{"url":"https://api.github.com/repos/redox-os/ion/pulls/comments/49940766","id":49940766,"diff_hunk":"@@ -438,19 +240,16 @@ pub struct Mode {\n     value: bool,\n }\n \n-fn on_command(command_string: &str,\n-              commands: &BTreeMap<String, Command>,\n-              variables: &mut BTreeMap<String, String>,\n-              modes: &mut Vec<Mode>) {\n+fn on_command(command_string: &str, commands: &BTreeMap<String, Command>, shell: &mut Shell) {\n     // Show variables\n     if command_string == \"$\" {\n-        for (key, value) in variables.iter() {\n+        for (key, value) in shell.variables.iter() {","path":"src/main.rs","position":436,"original_position":436,"commit_id":"e40c6ad5dd778dea61652b9524038f3c064b02dc","original_commit_id":"e40c6ad5dd778dea61652b9524038f3c064b02dc","user":{"login":"skylerberg","id":4156131,"avatar_url":"https://avatars.githubusercontent.com/u/4156131?v=3","gravatar_id":"","url":"https://api.github.com/users/skylerberg","html_url":"https://github.com/skylerberg","followers_url":"https://api.github.com/users/skylerberg/followers","following_url":"https://api.github.com/users/skylerberg/following{/other_user}","gists_url":"https://api.github.com/users/skylerberg/gists{/gist_id}","starred_url":"https://api.github.com/users/skylerberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skylerberg/subscriptions","organizations_url":"https://api.github.com/users/skylerberg/orgs","repos_url":"https://api.github.com/users/skylerberg/repos","events_url":"https://api.github.com/users/skylerberg/events{/privacy}","received_events_url":"https://api.github.com/users/skylerberg/received_events","type":"User","site_admin":false},"body":"It looks like the BTreeMap happens to keep it in alphabetical order. I will make sure that it sorts them when it prints them out when I change it to a hashmap.","created_at":"2016-01-17T03:40:58Z","updated_at":"2016-01-17T03:40:58Z","html_url":"https://github.com/redox-os/ion/pull/23#discussion_r49940766","pull_request_url":"https://api.github.com/repos/redox-os/ion/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/redox-os/ion/pulls/comments/49940766"},"html":{"href":"https://github.com/redox-os/ion/pull/23#discussion_r49940766"},"pull_request":{"href":"https://api.github.com/repos/redox-os/ion/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/redox-os/ion/pulls/23","id":56262195,"html_url":"https://github.com/redox-os/ion/pull/23","diff_url":"https://github.com/redox-os/ion/pull/23.diff","patch_url":"https://github.com/redox-os/ion/pull/23.patch","issue_url":"https://api.github.com/repos/redox-os/ion/issues/23","number":23,"state":"open","locked":false,"title":"Move builtins to their own module","user":{"login":"skylerberg","id":4156131,"avatar_url":"https://avatars.githubusercontent.com/u/4156131?v=3","gravatar_id":"","url":"https://api.github.com/users/skylerberg","html_url":"https://github.com/skylerberg","followers_url":"https://api.github.com/users/skylerberg/followers","following_url":"https://api.github.com/users/skylerberg/following{/other_user}","gists_url":"https://api.github.com/users/skylerberg/gists{/gist_id}","starred_url":"https://api.github.com/users/skylerberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skylerberg/subscriptions","organizations_url":"https://api.github.com/users/skylerberg/orgs","repos_url":"https://api.github.com/users/skylerberg/repos","events_url":"https://api.github.com/users/skylerberg/events{/privacy}","received_events_url":"https://api.github.com/users/skylerberg/received_events","type":"User","site_admin":false},"body":"This change should make it possible to test builtins easier. Furthermore builtin functions now have function signatures that reflect how they actually operate.","created_at":"2016-01-16T20:21:40Z","updated_at":"2016-01-17T03:40:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5895e82b68f2cb6aee1009b3f0914b2578aa3d2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/redox-os/ion/pulls/23/commits","review_comments_url":"https://api.github.com/repos/redox-os/ion/pulls/23/comments","review_comment_url":"https://api.github.com/repos/redox-os/ion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redox-os/ion/issues/23/comments","statuses_url":"https://api.github.com/repos/redox-os/ion/statuses/e40c6ad5dd778dea61652b9524038f3c064b02dc","head":{"label":"skylerberg:master","ref":"master","sha":"e40c6ad5dd778dea61652b9524038f3c064b02dc","user":{"login":"skylerberg","id":4156131,"avatar_url":"https://avatars.githubusercontent.com/u/4156131?v=3","gravatar_id":"","url":"https://api.github.com/users/skylerberg","html_url":"https://github.com/skylerberg","followers_url":"https://api.github.com/users/skylerberg/followers","following_url":"https://api.github.com/users/skylerberg/following{/other_user}","gists_url":"https://api.github.com/users/skylerberg/gists{/gist_id}","starred_url":"https://api.github.com/users/skylerberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skylerberg/subscriptions","organizations_url":"https://api.github.com/users/skylerberg/orgs","repos_url":"https://api.github.com/users/skylerberg/repos","events_url":"https://api.github.com/users/skylerberg/events{/privacy}","received_events_url":"https://api.github.com/users/skylerberg/received_events","type":"User","site_admin":false},"repo":{"id":48017610,"name":"ion","full_name":"skylerberg/ion","owner":{"login":"skylerberg","id":4156131,"avatar_url":"https://avatars.githubusercontent.com/u/4156131?v=3","gravatar_id":"","url":"https://api.github.com/users/skylerberg","html_url":"https://github.com/skylerberg","followers_url":"https://api.github.com/users/skylerberg/followers","following_url":"https://api.github.com/users/skylerberg/following{/other_user}","gists_url":"https://api.github.com/users/skylerberg/gists{/gist_id}","starred_url":"https://api.github.com/users/skylerberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skylerberg/subscriptions","organizations_url":"https://api.github.com/users/skylerberg/orgs","repos_url":"https://api.github.com/users/skylerberg/repos","events_url":"https://api.github.com/users/skylerberg/events{/privacy}","received_events_url":"https://api.github.com/users/skylerberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skylerberg/ion","description":"","fork":true,"url":"https://api.github.com/repos/skylerberg/ion","forks_url":"https://api.github.com/repos/skylerberg/ion/forks","keys_url":"https://api.github.com/repos/skylerberg/ion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skylerberg/ion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skylerberg/ion/teams","hooks_url":"https://api.github.com/repos/skylerberg/ion/hooks","issue_events_url":"https://api.github.com/repos/skylerberg/ion/issues/events{/number}","events_url":"https://api.github.com/repos/skylerberg/ion/events","assignees_url":"https://api.github.com/repos/skylerberg/ion/assignees{/user}","branches_url":"https://api.github.com/repos/skylerberg/ion/branches{/branch}","tags_url":"https://api.github.com/repos/skylerberg/ion/tags","blobs_url":"https://api.github.com/repos/skylerberg/ion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skylerberg/ion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skylerberg/ion/git/refs{/sha}","trees_url":"https://api.github.com/repos/skylerberg/ion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skylerberg/ion/statuses/{sha}","languages_url":"https://api.github.com/repos/skylerberg/ion/languages","stargazers_url":"https://api.github.com/repos/skylerberg/ion/stargazers","contributors_url":"https://api.github.com/repos/skylerberg/ion/contributors","subscribers_url":"https://api.github.com/repos/skylerberg/ion/subscribers","subscription_url":"https://api.github.com/repos/skylerberg/ion/subscription","commits_url":"https://api.github.com/repos/skylerberg/ion/commits{/sha}","git_commits_url":"https://api.github.com/repos/skylerberg/ion/git/commits{/sha}","comments_url":"https://api.github.com/repos/skylerberg/ion/comments{/number}","issue_comment_url":"https://api.github.com/repos/skylerberg/ion/issues/comments{/number}","contents_url":"https://api.github.com/repos/skylerberg/ion/contents/{+path}","compare_url":"https://api.github.com/repos/skylerberg/ion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skylerberg/ion/merges","archive_url":"https://api.github.com/repos/skylerberg/ion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skylerberg/ion/downloads","issues_url":"https://api.github.com/repos/skylerberg/ion/issues{/number}","pulls_url":"https://api.github.com/repos/skylerberg/ion/pulls{/number}","milestones_url":"https://api.github.com/repos/skylerberg/ion/milestones{/number}","notifications_url":"https://api.github.com/repos/skylerberg/ion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skylerberg/ion/labels{/name}","releases_url":"https://api.github.com/repos/skylerberg/ion/releases{/id}","created_at":"2015-12-15T03:34:44Z","updated_at":"2016-01-15T07:11:12Z","pushed_at":"2016-01-16T20:19:44Z","git_url":"git://github.com/skylerberg/ion.git","ssh_url":"git@github.com:skylerberg/ion.git","clone_url":"https://github.com/skylerberg/ion.git","svn_url":"https://github.com/skylerberg/ion","homepage":null,"size":83,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"redox-os:master","ref":"master","sha":"4ec58cb85d1db6eff172786196d1cf87112e32c7","user":{"login":"redox-os","id":14909902,"avatar_url":"https://avatars.githubusercontent.com/u/14909902?v=3","gravatar_id":"","url":"https://api.github.com/users/redox-os","html_url":"https://github.com/redox-os","followers_url":"https://api.github.com/users/redox-os/followers","following_url":"https://api.github.com/users/redox-os/following{/other_user}","gists_url":"https://api.github.com/users/redox-os/gists{/gist_id}","starred_url":"https://api.github.com/users/redox-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redox-os/subscriptions","organizations_url":"https://api.github.com/users/redox-os/orgs","repos_url":"https://api.github.com/users/redox-os/repos","events_url":"https://api.github.com/users/redox-os/events{/privacy}","received_events_url":"https://api.github.com/users/redox-os/received_events","type":"Organization","site_admin":false},"repo":{"id":43815123,"name":"ion","full_name":"redox-os/ion","owner":{"login":"redox-os","id":14909902,"avatar_url":"https://avatars.githubusercontent.com/u/14909902?v=3","gravatar_id":"","url":"https://api.github.com/users/redox-os","html_url":"https://github.com/redox-os","followers_url":"https://api.github.com/users/redox-os/followers","following_url":"https://api.github.com/users/redox-os/following{/other_user}","gists_url":"https://api.github.com/users/redox-os/gists{/gist_id}","starred_url":"https://api.github.com/users/redox-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redox-os/subscriptions","organizations_url":"https://api.github.com/users/redox-os/orgs","repos_url":"https://api.github.com/users/redox-os/repos","events_url":"https://api.github.com/users/redox-os/events{/privacy}","received_events_url":"https://api.github.com/users/redox-os/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redox-os/ion","description":"The Ion Shell. Compatible with Redox and Linux.","fork":false,"url":"https://api.github.com/repos/redox-os/ion","forks_url":"https://api.github.com/repos/redox-os/ion/forks","keys_url":"https://api.github.com/repos/redox-os/ion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redox-os/ion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redox-os/ion/teams","hooks_url":"https://api.github.com/repos/redox-os/ion/hooks","issue_events_url":"https://api.github.com/repos/redox-os/ion/issues/events{/number}","events_url":"https://api.github.com/repos/redox-os/ion/events","assignees_url":"https://api.github.com/repos/redox-os/ion/assignees{/user}","branches_url":"https://api.github.com/repos/redox-os/ion/branches{/branch}","tags_url":"https://api.github.com/repos/redox-os/ion/tags","blobs_url":"https://api.github.com/repos/redox-os/ion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redox-os/ion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redox-os/ion/git/refs{/sha}","trees_url":"https://api.github.com/repos/redox-os/ion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redox-os/ion/statuses/{sha}","languages_url":"https://api.github.com/repos/redox-os/ion/languages","stargazers_url":"https://api.github.com/repos/redox-os/ion/stargazers","contributors_url":"https://api.github.com/repos/redox-os/ion/contributors","subscribers_url":"https://api.github.com/repos/redox-os/ion/subscribers","subscription_url":"https://api.github.com/repos/redox-os/ion/subscription","commits_url":"https://api.github.com/repos/redox-os/ion/commits{/sha}","git_commits_url":"https://api.github.com/repos/redox-os/ion/git/commits{/sha}","comments_url":"https://api.github.com/repos/redox-os/ion/comments{/number}","issue_comment_url":"https://api.github.com/repos/redox-os/ion/issues/comments{/number}","contents_url":"https://api.github.com/repos/redox-os/ion/contents/{+path}","compare_url":"https://api.github.com/repos/redox-os/ion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redox-os/ion/merges","archive_url":"https://api.github.com/repos/redox-os/ion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redox-os/ion/downloads","issues_url":"https://api.github.com/repos/redox-os/ion/issues{/number}","pulls_url":"https://api.github.com/repos/redox-os/ion/pulls{/number}","milestones_url":"https://api.github.com/repos/redox-os/ion/milestones{/number}","notifications_url":"https://api.github.com/repos/redox-os/ion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redox-os/ion/labels{/name}","releases_url":"https://api.github.com/repos/redox-os/ion/releases{/id}","created_at":"2015-10-07T12:45:04Z","updated_at":"2016-01-12T18:09:04Z","pushed_at":"2016-01-16T20:21:42Z","git_url":"git://github.com/redox-os/ion.git","ssh_url":"git@github.com:redox-os/ion.git","clone_url":"https://github.com/redox-os/ion.git","svn_url":"https://github.com/redox-os/ion","homepage":"","size":109,"stargazers_count":18,"watchers_count":18,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":13,"forks":8,"open_issues":13,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redox-os/ion/pulls/23"},"html":{"href":"https://github.com/redox-os/ion/pull/23"},"issue":{"href":"https://api.github.com/repos/redox-os/ion/issues/23"},"comments":{"href":"https://api.github.com/repos/redox-os/ion/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/redox-os/ion/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/redox-os/ion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redox-os/ion/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/redox-os/ion/statuses/e40c6ad5dd778dea61652b9524038f3c064b02dc"}}}}