{"action":"closed","number":674,"pull_request":{"url":"https://api.github.com/repos/bloomberg/chef-bach/pulls/674","id":86191182,"html_url":"https://github.com/bloomberg/chef-bach/pull/674","diff_url":"https://github.com/bloomberg/chef-bach/pull/674.diff","patch_url":"https://github.com/bloomberg/chef-bach/pull/674.patch","issue_url":"https://api.github.com/repos/bloomberg/chef-bach/issues/674","number":674,"state":"closed","locked":false,"title":"Correct http_proxy issue and failure to find environment/Test-Laptop.json","user":{"login":"cbaenziger","id":4192761,"avatar_url":"https://avatars.githubusercontent.com/u/4192761?v=3","gravatar_id":"","url":"https://api.github.com/users/cbaenziger","html_url":"https://github.com/cbaenziger","followers_url":"https://api.github.com/users/cbaenziger/followers","following_url":"https://api.github.com/users/cbaenziger/following{/other_user}","gists_url":"https://api.github.com/users/cbaenziger/gists{/gist_id}","starred_url":"https://api.github.com/users/cbaenziger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbaenziger/subscriptions","organizations_url":"https://api.github.com/users/cbaenziger/orgs","repos_url":"https://api.github.com/users/cbaenziger/repos","events_url":"https://api.github.com/users/cbaenziger/events{/privacy}","received_events_url":"https://api.github.com/users/cbaenziger/received_events","type":"User","site_admin":false},"body":"This should fix Chef-BACH #663. It works by moving the expansion of `cluster.tgz` to before anything needing `../cluster` is run. Particularly the following is fixed:\r\n````\r\n++ python -c 'import json; print json.load(file('\\''environments/Test-Laptop.json'\\''))[\"override_attributes\"][\"bcpc\"][\"bootstrap\"][\"server\"]+'\\'':80'\\'''\r\nTraceback (most recent call last):\r\n  File \"<string>\", line 1, in <module>\r\nIOError: [Errno 2] No such file or directory: 'environments/Test-Laptop.json'\r\n````\r\nAs it was caused by the following execution chain:\r\n* [`bootstrap_chef.sh`:77](https://github.com/bloomberg/chef-bach/blob/9600c76c1288501e341cd6e82ee4b884d5fbf0c0/bootstrap_chef.sh#L77) calls `setup_chef_cookbooks.sh`\r\n* [`setup_chef_cookbooks.sh`:16](https://github.com/bloomberg/chef-bach/blob/9600c76c1288501e341cd6e82ee4b884d5fbf0c0/setup_chef_cookbooks.sh#L16) calls `load_binary_server_info`\r\n* [`load_binary_server_info`](https://github.com/bloomberg/chef-bach/blob/9600c76c1288501e341cd6e82ee4b884d5fbf0c0/proxy_setup.sh#L36) is defined in `proxy_setup.sh` and references `environments/${environment}.json`\r\n* [`environments`](https://github.com/bloomberg/chef-bach/blob/6f9131102002525778c3cfa4309949d03003c1c9/environments) is a symlink to `../cluster/environments` -- which does not exist at this point\r\n\r\nIt is unsatisfying that this happened to work for folks in the past but I believe that to be due to poor state clean-up of the `../cluster` directory in the past. Any new clone in a new directory location would hit this issue.","created_at":"2016-09-21T15:54:51Z","updated_at":"2016-09-21T15:59:21Z","closed_at":"2016-09-21T15:59:20Z","merged_at":"2016-09-21T15:59:20Z","merge_commit_sha":"2ea56f89101df7c682035d14e9447087fc7d5d47","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bloomberg/chef-bach/pulls/674/commits","review_comments_url":"https://api.github.com/repos/bloomberg/chef-bach/pulls/674/comments","review_comment_url":"https://api.github.com/repos/bloomberg/chef-bach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bloomberg/chef-bach/issues/674/comments","statuses_url":"https://api.github.com/repos/bloomberg/chef-bach/statuses/02a9135a4fee6426adecaf9bd509f5a3e29dd88a","head":{"label":"cbaenziger:http_environment_fix","ref":"http_environment_fix","sha":"02a9135a4fee6426adecaf9bd509f5a3e29dd88a","user":{"login":"cbaenziger","id":4192761,"avatar_url":"https://avatars.githubusercontent.com/u/4192761?v=3","gravatar_id":"","url":"https://api.github.com/users/cbaenziger","html_url":"https://github.com/cbaenziger","followers_url":"https://api.github.com/users/cbaenziger/followers","following_url":"https://api.github.com/users/cbaenziger/following{/other_user}","gists_url":"https://api.github.com/users/cbaenziger/gists{/gist_id}","starred_url":"https://api.github.com/users/cbaenziger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbaenziger/subscriptions","organizations_url":"https://api.github.com/users/cbaenziger/orgs","repos_url":"https://api.github.com/users/cbaenziger/repos","events_url":"https://api.github.com/users/cbaenziger/events{/privacy}","received_events_url":"https://api.github.com/users/cbaenziger/received_events","type":"User","site_admin":false},"repo":{"id":25824446,"name":"chef-bach","full_name":"cbaenziger/chef-bach","owner":{"login":"cbaenziger","id":4192761,"avatar_url":"https://avatars.githubusercontent.com/u/4192761?v=3","gravatar_id":"","url":"https://api.github.com/users/cbaenziger","html_url":"https://github.com/cbaenziger","followers_url":"https://api.github.com/users/cbaenziger/followers","following_url":"https://api.github.com/users/cbaenziger/following{/other_user}","gists_url":"https://api.github.com/users/cbaenziger/gists{/gist_id}","starred_url":"https://api.github.com/users/cbaenziger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbaenziger/subscriptions","organizations_url":"https://api.github.com/users/cbaenziger/orgs","repos_url":"https://api.github.com/users/cbaenziger/repos","events_url":"https://api.github.com/users/cbaenziger/events{/privacy}","received_events_url":"https://api.github.com/users/cbaenziger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cbaenziger/chef-bach","description":"Chef recipes for Bloomberg's deployment of Hadoop and related components","fork":true,"url":"https://api.github.com/repos/cbaenziger/chef-bach","forks_url":"https://api.github.com/repos/cbaenziger/chef-bach/forks","keys_url":"https://api.github.com/repos/cbaenziger/chef-bach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbaenziger/chef-bach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbaenziger/chef-bach/teams","hooks_url":"https://api.github.com/repos/cbaenziger/chef-bach/hooks","issue_events_url":"https://api.github.com/repos/cbaenziger/chef-bach/issues/events{/number}","events_url":"https://api.github.com/repos/cbaenziger/chef-bach/events","assignees_url":"https://api.github.com/repos/cbaenziger/chef-bach/assignees{/user}","branches_url":"https://api.github.com/repos/cbaenziger/chef-bach/branches{/branch}","tags_url":"https://api.github.com/repos/cbaenziger/chef-bach/tags","blobs_url":"https://api.github.com/repos/cbaenziger/chef-bach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbaenziger/chef-bach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbaenziger/chef-bach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbaenziger/chef-bach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbaenziger/chef-bach/statuses/{sha}","languages_url":"https://api.github.com/repos/cbaenziger/chef-bach/languages","stargazers_url":"https://api.github.com/repos/cbaenziger/chef-bach/stargazers","contributors_url":"https://api.github.com/repos/cbaenziger/chef-bach/contributors","subscribers_url":"https://api.github.com/repos/cbaenziger/chef-bach/subscribers","subscription_url":"https://api.github.com/repos/cbaenziger/chef-bach/subscription","commits_url":"https://api.github.com/repos/cbaenziger/chef-bach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbaenziger/chef-bach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbaenziger/chef-bach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbaenziger/chef-bach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbaenziger/chef-bach/contents/{+path}","compare_url":"https://api.github.com/repos/cbaenziger/chef-bach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbaenziger/chef-bach/merges","archive_url":"https://api.github.com/repos/cbaenziger/chef-bach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbaenziger/chef-bach/downloads","issues_url":"https://api.github.com/repos/cbaenziger/chef-bach/issues{/number}","pulls_url":"https://api.github.com/repos/cbaenziger/chef-bach/pulls{/number}","milestones_url":"https://api.github.com/repos/cbaenziger/chef-bach/milestones{/number}","notifications_url":"https://api.github.com/repos/cbaenziger/chef-bach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbaenziger/chef-bach/labels{/name}","releases_url":"https://api.github.com/repos/cbaenziger/chef-bach/releases{/id}","deployments_url":"https://api.github.com/repos/cbaenziger/chef-bach/deployments","created_at":"2014-10-27T15:02:22Z","updated_at":"2016-02-09T02:12:36Z","pushed_at":"2016-09-20T05:57:11Z","git_url":"git://github.com/cbaenziger/chef-bach.git","ssh_url":"git@github.com:cbaenziger/chef-bach.git","clone_url":"https://github.com/cbaenziger/chef-bach.git","svn_url":"https://github.com/cbaenziger/chef-bach","homepage":null,"size":3263,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bloomberg:master","ref":"master","sha":"27500e1d85acadc9227fb757dfc32c556c5c4fd8","user":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=3","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"repo":{"id":24933148,"name":"chef-bach","full_name":"bloomberg/chef-bach","owner":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=3","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bloomberg/chef-bach","description":"Chef recipes for Bloomberg's deployment of Hadoop and related components","fork":false,"url":"https://api.github.com/repos/bloomberg/chef-bach","forks_url":"https://api.github.com/repos/bloomberg/chef-bach/forks","keys_url":"https://api.github.com/repos/bloomberg/chef-bach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bloomberg/chef-bach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bloomberg/chef-bach/teams","hooks_url":"https://api.github.com/repos/bloomberg/chef-bach/hooks","issue_events_url":"https://api.github.com/repos/bloomberg/chef-bach/issues/events{/number}","events_url":"https://api.github.com/repos/bloomberg/chef-bach/events","assignees_url":"https://api.github.com/repos/bloomberg/chef-bach/assignees{/user}","branches_url":"https://api.github.com/repos/bloomberg/chef-bach/branches{/branch}","tags_url":"https://api.github.com/repos/bloomberg/chef-bach/tags","blobs_url":"https://api.github.com/repos/bloomberg/chef-bach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bloomberg/chef-bach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bloomberg/chef-bach/git/refs{/sha}","trees_url":"https://api.github.com/repos/bloomberg/chef-bach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bloomberg/chef-bach/statuses/{sha}","languages_url":"https://api.github.com/repos/bloomberg/chef-bach/languages","stargazers_url":"https://api.github.com/repos/bloomberg/chef-bach/stargazers","contributors_url":"https://api.github.com/repos/bloomberg/chef-bach/contributors","subscribers_url":"https://api.github.com/repos/bloomberg/chef-bach/subscribers","subscription_url":"https://api.github.com/repos/bloomberg/chef-bach/subscription","commits_url":"https://api.github.com/repos/bloomberg/chef-bach/commits{/sha}","git_commits_url":"https://api.github.com/repos/bloomberg/chef-bach/git/commits{/sha}","comments_url":"https://api.github.com/repos/bloomberg/chef-bach/comments{/number}","issue_comment_url":"https://api.github.com/repos/bloomberg/chef-bach/issues/comments{/number}","contents_url":"https://api.github.com/repos/bloomberg/chef-bach/contents/{+path}","compare_url":"https://api.github.com/repos/bloomberg/chef-bach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bloomberg/chef-bach/merges","archive_url":"https://api.github.com/repos/bloomberg/chef-bach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bloomberg/chef-bach/downloads","issues_url":"https://api.github.com/repos/bloomberg/chef-bach/issues{/number}","pulls_url":"https://api.github.com/repos/bloomberg/chef-bach/pulls{/number}","milestones_url":"https://api.github.com/repos/bloomberg/chef-bach/milestones{/number}","notifications_url":"https://api.github.com/repos/bloomberg/chef-bach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bloomberg/chef-bach/labels{/name}","releases_url":"https://api.github.com/repos/bloomberg/chef-bach/releases{/id}","deployments_url":"https://api.github.com/repos/bloomberg/chef-bach/deployments","created_at":"2014-10-08T09:16:26Z","updated_at":"2016-09-01T07:26:30Z","pushed_at":"2016-09-21T15:59:20Z","git_url":"git://github.com/bloomberg/chef-bach.git","ssh_url":"git@github.com:bloomberg/chef-bach.git","clone_url":"https://github.com/bloomberg/chef-bach.git","svn_url":"https://github.com/bloomberg/chef-bach","homepage":null,"size":5525,"stargazers_count":36,"watchers_count":36,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":133,"forks":36,"open_issues":133,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bloomberg/chef-bach/pulls/674"},"html":{"href":"https://github.com/bloomberg/chef-bach/pull/674"},"issue":{"href":"https://api.github.com/repos/bloomberg/chef-bach/issues/674"},"comments":{"href":"https://api.github.com/repos/bloomberg/chef-bach/issues/674/comments"},"review_comments":{"href":"https://api.github.com/repos/bloomberg/chef-bach/pulls/674/comments"},"review_comment":{"href":"https://api.github.com/repos/bloomberg/chef-bach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bloomberg/chef-bach/pulls/674/commits"},"statuses":{"href":"https://api.github.com/repos/bloomberg/chef-bach/statuses/02a9135a4fee6426adecaf9bd509f5a3e29dd88a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"http-418","id":1435487,"avatar_url":"https://avatars.githubusercontent.com/u/1435487?v=3","gravatar_id":"","url":"https://api.github.com/users/http-418","html_url":"https://github.com/http-418","followers_url":"https://api.github.com/users/http-418/followers","following_url":"https://api.github.com/users/http-418/following{/other_user}","gists_url":"https://api.github.com/users/http-418/gists{/gist_id}","starred_url":"https://api.github.com/users/http-418/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/http-418/subscriptions","organizations_url":"https://api.github.com/users/http-418/orgs","repos_url":"https://api.github.com/users/http-418/repos","events_url":"https://api.github.com/users/http-418/events{/privacy}","received_events_url":"https://api.github.com/users/http-418/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"http-418"}}