{"action":"created","comment":{"url":"https://api.github.com/repos/fabric8io/gofabric8/pulls/comments/51992604","id":51992604,"diff_hunk":"@@ -217,6 +223,7 @@ func NewCmdDeploy(f *cmdutil.Factory) *cobra.Command {\n \t\t},\n \t}\n \tcmd.PersistentFlags().StringP(\"domain\", \"d\", defaultDomain(), \"The domain name to append to the service name to access web applications\")\n+\tcmd.PersistentFlags().StringP(\"apidomain\", \"\", \"--domain\", \"if set the fabric8 pod uses that domain to call the console\")","path":"cmds/deploy.go","position":28,"original_position":28,"commit_id":"fcf9ee575f956a48096f98b3a8a8ec49ddf500af","original_commit_id":"fcf9ee575f956a48096f98b3a8a8ec49ddf500af","user":{"login":"jimmidyson","id":464659,"avatar_url":"https://avatars.githubusercontent.com/u/464659?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmidyson","html_url":"https://github.com/jimmidyson","followers_url":"https://api.github.com/users/jimmidyson/followers","following_url":"https://api.github.com/users/jimmidyson/following{/other_user}","gists_url":"https://api.github.com/users/jimmidyson/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmidyson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmidyson/subscriptions","organizations_url":"https://api.github.com/users/jimmidyson/orgs","repos_url":"https://api.github.com/users/jimmidyson/repos","events_url":"https://api.github.com/users/jimmidyson/events{/privacy}","received_events_url":"https://api.github.com/users/jimmidyson/received_events","type":"User","site_admin":false},"body":"Maybe we call the param `oauth-authorize-uri` just to be clear? The reason it was domain before was because we reused that as a suffix for the console route as well as the authorize URI - as you've said this isn't really valid & needs to be 2 separate params.","created_at":"2016-02-05T09:22:01Z","updated_at":"2016-02-05T09:22:01Z","html_url":"https://github.com/fabric8io/gofabric8/pull/29#discussion_r51992604","pull_request_url":"https://api.github.com/repos/fabric8io/gofabric8/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/fabric8io/gofabric8/pulls/comments/51992604"},"html":{"href":"https://github.com/fabric8io/gofabric8/pull/29#discussion_r51992604"},"pull_request":{"href":"https://api.github.com/repos/fabric8io/gofabric8/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/fabric8io/gofabric8/pulls/29","id":58344827,"html_url":"https://github.com/fabric8io/gofabric8/pull/29","diff_url":"https://github.com/fabric8io/gofabric8/pull/29.diff","patch_url":"https://github.com/fabric8io/gofabric8/pull/29.patch","issue_url":"https://api.github.com/repos/fabric8io/gofabric8/issues/29","number":29,"state":"closed","locked":false,"title":"add an --apidomain param to the deploy command","user":{"login":"MarWestermann","id":3732226,"avatar_url":"https://avatars.githubusercontent.com/u/3732226?v=3","gravatar_id":"","url":"https://api.github.com/users/MarWestermann","html_url":"https://github.com/MarWestermann","followers_url":"https://api.github.com/users/MarWestermann/followers","following_url":"https://api.github.com/users/MarWestermann/following{/other_user}","gists_url":"https://api.github.com/users/MarWestermann/gists{/gist_id}","starred_url":"https://api.github.com/users/MarWestermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarWestermann/subscriptions","organizations_url":"https://api.github.com/users/MarWestermann/orgs","repos_url":"https://api.github.com/users/MarWestermann/repos","events_url":"https://api.github.com/users/MarWestermann/events{/privacy}","received_events_url":"https://api.github.com/users/MarWestermann/received_events","type":"User","site_admin":false},"body":"\r\nI added a new param apidomain which is used for pod template if it is different then domain param. adjusted readme accordingly\r\n","created_at":"2016-02-04T20:35:22Z","updated_at":"2016-02-05T09:22:01Z","closed_at":"2016-02-04T21:11:41Z","merged_at":"2016-02-04T21:11:41Z","merge_commit_sha":"2ef7e168d99516070da0c66fdee71a7e6cbeeb74","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fabric8io/gofabric8/pulls/29/commits","review_comments_url":"https://api.github.com/repos/fabric8io/gofabric8/pulls/29/comments","review_comment_url":"https://api.github.com/repos/fabric8io/gofabric8/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8io/gofabric8/issues/29/comments","statuses_url":"https://api.github.com/repos/fabric8io/gofabric8/statuses/fcf9ee575f956a48096f98b3a8a8ec49ddf500af","head":{"label":"MarWestermann:master","ref":"master","sha":"fcf9ee575f956a48096f98b3a8a8ec49ddf500af","user":{"login":"MarWestermann","id":3732226,"avatar_url":"https://avatars.githubusercontent.com/u/3732226?v=3","gravatar_id":"","url":"https://api.github.com/users/MarWestermann","html_url":"https://github.com/MarWestermann","followers_url":"https://api.github.com/users/MarWestermann/followers","following_url":"https://api.github.com/users/MarWestermann/following{/other_user}","gists_url":"https://api.github.com/users/MarWestermann/gists{/gist_id}","starred_url":"https://api.github.com/users/MarWestermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarWestermann/subscriptions","organizations_url":"https://api.github.com/users/MarWestermann/orgs","repos_url":"https://api.github.com/users/MarWestermann/repos","events_url":"https://api.github.com/users/MarWestermann/events{/privacy}","received_events_url":"https://api.github.com/users/MarWestermann/received_events","type":"User","site_admin":false},"repo":{"id":51103460,"name":"gofabric8","full_name":"MarWestermann/gofabric8","owner":{"login":"MarWestermann","id":3732226,"avatar_url":"https://avatars.githubusercontent.com/u/3732226?v=3","gravatar_id":"","url":"https://api.github.com/users/MarWestermann","html_url":"https://github.com/MarWestermann","followers_url":"https://api.github.com/users/MarWestermann/followers","following_url":"https://api.github.com/users/MarWestermann/following{/other_user}","gists_url":"https://api.github.com/users/MarWestermann/gists{/gist_id}","starred_url":"https://api.github.com/users/MarWestermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarWestermann/subscriptions","organizations_url":"https://api.github.com/users/MarWestermann/orgs","repos_url":"https://api.github.com/users/MarWestermann/repos","events_url":"https://api.github.com/users/MarWestermann/events{/privacy}","received_events_url":"https://api.github.com/users/MarWestermann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MarWestermann/gofabric8","description":null,"fork":true,"url":"https://api.github.com/repos/MarWestermann/gofabric8","forks_url":"https://api.github.com/repos/MarWestermann/gofabric8/forks","keys_url":"https://api.github.com/repos/MarWestermann/gofabric8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarWestermann/gofabric8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarWestermann/gofabric8/teams","hooks_url":"https://api.github.com/repos/MarWestermann/gofabric8/hooks","issue_events_url":"https://api.github.com/repos/MarWestermann/gofabric8/issues/events{/number}","events_url":"https://api.github.com/repos/MarWestermann/gofabric8/events","assignees_url":"https://api.github.com/repos/MarWestermann/gofabric8/assignees{/user}","branches_url":"https://api.github.com/repos/MarWestermann/gofabric8/branches{/branch}","tags_url":"https://api.github.com/repos/MarWestermann/gofabric8/tags","blobs_url":"https://api.github.com/repos/MarWestermann/gofabric8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarWestermann/gofabric8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarWestermann/gofabric8/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarWestermann/gofabric8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarWestermann/gofabric8/statuses/{sha}","languages_url":"https://api.github.com/repos/MarWestermann/gofabric8/languages","stargazers_url":"https://api.github.com/repos/MarWestermann/gofabric8/stargazers","contributors_url":"https://api.github.com/repos/MarWestermann/gofabric8/contributors","subscribers_url":"https://api.github.com/repos/MarWestermann/gofabric8/subscribers","subscription_url":"https://api.github.com/repos/MarWestermann/gofabric8/subscription","commits_url":"https://api.github.com/repos/MarWestermann/gofabric8/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarWestermann/gofabric8/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarWestermann/gofabric8/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarWestermann/gofabric8/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarWestermann/gofabric8/contents/{+path}","compare_url":"https://api.github.com/repos/MarWestermann/gofabric8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarWestermann/gofabric8/merges","archive_url":"https://api.github.com/repos/MarWestermann/gofabric8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarWestermann/gofabric8/downloads","issues_url":"https://api.github.com/repos/MarWestermann/gofabric8/issues{/number}","pulls_url":"https://api.github.com/repos/MarWestermann/gofabric8/pulls{/number}","milestones_url":"https://api.github.com/repos/MarWestermann/gofabric8/milestones{/number}","notifications_url":"https://api.github.com/repos/MarWestermann/gofabric8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarWestermann/gofabric8/labels{/name}","releases_url":"https://api.github.com/repos/MarWestermann/gofabric8/releases{/id}","deployments_url":"https://api.github.com/repos/MarWestermann/gofabric8/deployments","created_at":"2016-02-04T20:32:35Z","updated_at":"2016-02-04T20:32:36Z","pushed_at":"2016-02-04T20:33:47Z","git_url":"git://github.com/MarWestermann/gofabric8.git","ssh_url":"git@github.com:MarWestermann/gofabric8.git","clone_url":"https://github.com/MarWestermann/gofabric8.git","svn_url":"https://github.com/MarWestermann/gofabric8","homepage":null,"size":16539,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8io:master","ref":"master","sha":"fe91a6f4f05d039cd3ecdd4668fe7b07c219098b","user":{"login":"fabric8io","id":6074349,"avatar_url":"https://avatars.githubusercontent.com/u/6074349?v=3","gravatar_id":"","url":"https://api.github.com/users/fabric8io","html_url":"https://github.com/fabric8io","followers_url":"https://api.github.com/users/fabric8io/followers","following_url":"https://api.github.com/users/fabric8io/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io/subscriptions","organizations_url":"https://api.github.com/users/fabric8io/orgs","repos_url":"https://api.github.com/users/fabric8io/repos","events_url":"https://api.github.com/users/fabric8io/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io/received_events","type":"Organization","site_admin":false},"repo":{"id":39738994,"name":"gofabric8","full_name":"fabric8io/gofabric8","owner":{"login":"fabric8io","id":6074349,"avatar_url":"https://avatars.githubusercontent.com/u/6074349?v=3","gravatar_id":"","url":"https://api.github.com/users/fabric8io","html_url":"https://github.com/fabric8io","followers_url":"https://api.github.com/users/fabric8io/followers","following_url":"https://api.github.com/users/fabric8io/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io/subscriptions","organizations_url":"https://api.github.com/users/fabric8io/orgs","repos_url":"https://api.github.com/users/fabric8io/repos","events_url":"https://api.github.com/users/fabric8io/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8io/gofabric8","description":null,"fork":false,"url":"https://api.github.com/repos/fabric8io/gofabric8","forks_url":"https://api.github.com/repos/fabric8io/gofabric8/forks","keys_url":"https://api.github.com/repos/fabric8io/gofabric8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8io/gofabric8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8io/gofabric8/teams","hooks_url":"https://api.github.com/repos/fabric8io/gofabric8/hooks","issue_events_url":"https://api.github.com/repos/fabric8io/gofabric8/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8io/gofabric8/events","assignees_url":"https://api.github.com/repos/fabric8io/gofabric8/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8io/gofabric8/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8io/gofabric8/tags","blobs_url":"https://api.github.com/repos/fabric8io/gofabric8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8io/gofabric8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8io/gofabric8/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8io/gofabric8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8io/gofabric8/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8io/gofabric8/languages","stargazers_url":"https://api.github.com/repos/fabric8io/gofabric8/stargazers","contributors_url":"https://api.github.com/repos/fabric8io/gofabric8/contributors","subscribers_url":"https://api.github.com/repos/fabric8io/gofabric8/subscribers","subscription_url":"https://api.github.com/repos/fabric8io/gofabric8/subscription","commits_url":"https://api.github.com/repos/fabric8io/gofabric8/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8io/gofabric8/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8io/gofabric8/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8io/gofabric8/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8io/gofabric8/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8io/gofabric8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8io/gofabric8/merges","archive_url":"https://api.github.com/repos/fabric8io/gofabric8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8io/gofabric8/downloads","issues_url":"https://api.github.com/repos/fabric8io/gofabric8/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8io/gofabric8/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8io/gofabric8/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8io/gofabric8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8io/gofabric8/labels{/name}","releases_url":"https://api.github.com/repos/fabric8io/gofabric8/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8io/gofabric8/deployments","created_at":"2015-07-26T19:34:31Z","updated_at":"2016-01-14T15:37:07Z","pushed_at":"2016-02-04T21:21:23Z","git_url":"git://github.com/fabric8io/gofabric8.git","ssh_url":"git@github.com:fabric8io/gofabric8.git","clone_url":"https://github.com/fabric8io/gofabric8.git","svn_url":"https://github.com/fabric8io/gofabric8","homepage":null,"size":16540,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":10,"forks":9,"open_issues":10,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8io/gofabric8/pulls/29"},"html":{"href":"https://github.com/fabric8io/gofabric8/pull/29"},"issue":{"href":"https://api.github.com/repos/fabric8io/gofabric8/issues/29"},"comments":{"href":"https://api.github.com/repos/fabric8io/gofabric8/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8io/gofabric8/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8io/gofabric8/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8io/gofabric8/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8io/gofabric8/statuses/fcf9ee575f956a48096f98b3a8a8ec49ddf500af"}}}}