{"action":"created","comment":{"url":"https://api.github.com/repos/CGAL/cgal/pulls/comments/50559327","id":50559327,"diff_hunk":"@@ -985,7 +983,8 @@ void MainWindow::open(QString filename)\n     default:\n       load_pair = File_loader_dialog::getItem(fileinfo.fileName(), selected_items, &ok);\n   }\n-  \n+  viewer->context()->makeCurrent();\n+  qDebug()<<\"Current\";","path":"Polyhedron/demo/Polyhedron/MainWindow.cpp","position":21,"original_position":21,"commit_id":"eb867bb8102605af26b83e75af7662dfa6d06ea2","original_commit_id":"eb867bb8102605af26b83e75af7662dfa6d06ea2","user":{"login":"lrineau","id":5746675,"avatar_url":"https://avatars.githubusercontent.com/u/5746675?v=3","gravatar_id":"","url":"https://api.github.com/users/lrineau","html_url":"https://github.com/lrineau","followers_url":"https://api.github.com/users/lrineau/followers","following_url":"https://api.github.com/users/lrineau/following{/other_user}","gists_url":"https://api.github.com/users/lrineau/gists{/gist_id}","starred_url":"https://api.github.com/users/lrineau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrineau/subscriptions","organizations_url":"https://api.github.com/users/lrineau/orgs","repos_url":"https://api.github.com/users/lrineau/repos","events_url":"https://api.github.com/users/lrineau/events{/privacy}","received_events_url":"https://api.github.com/users/lrineau/received_events","type":"User","site_admin":false},"body":"should be removed","created_at":"2016-01-22T16:45:40Z","updated_at":"2016-01-22T16:45:40Z","html_url":"https://github.com/CGAL/cgal/pull/654#discussion_r50559327","pull_request_url":"https://api.github.com/repos/CGAL/cgal/pulls/654","_links":{"self":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/comments/50559327"},"html":{"href":"https://github.com/CGAL/cgal/pull/654#discussion_r50559327"},"pull_request":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/654"}}},"pull_request":{"url":"https://api.github.com/repos/CGAL/cgal/pulls/654","id":56579511,"html_url":"https://github.com/CGAL/cgal/pull/654","diff_url":"https://github.com/CGAL/cgal/pull/654.diff","patch_url":"https://github.com/CGAL/cgal/pull/654.patch","issue_url":"https://api.github.com/repos/CGAL/cgal/issues/654","number":654,"state":"open","locked":false,"title":"Demo fix for OS X (fix for #437)","user":{"login":"maxGimeno","id":11310805,"avatar_url":"https://avatars.githubusercontent.com/u/11310805?v=3","gravatar_id":"","url":"https://api.github.com/users/maxGimeno","html_url":"https://github.com/maxGimeno","followers_url":"https://api.github.com/users/maxGimeno/followers","following_url":"https://api.github.com/users/maxGimeno/following{/other_user}","gists_url":"https://api.github.com/users/maxGimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/maxGimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxGimeno/subscriptions","organizations_url":"https://api.github.com/users/maxGimeno/orgs","repos_url":"https://api.github.com/users/maxGimeno/repos","events_url":"https://api.github.com/users/maxGimeno/events{/privacy}","received_events_url":"https://api.github.com/users/maxGimeno/received_events","type":"User","site_admin":false},"body":"This PR repairs the 3D demos on OS X.\r\n\r\n- Most of the problems were caused by the fact that on OS X, the paintGL function of an OpenGLWidget is called during the setupUi() call (in the MainWindow), when the viewer's scene is still pointing to NULL, which caused a segfault. \r\n- Some demos did not display 3D effects, this was caused by the fact that on OS X, OpenGL binds automatically the color attribute to 0 in the shaders, and OpenGL does not dipslay anything when a setAttributeValue is made on the attribute 0.\r\n- There were some errors due to Shaders that were still written in GLSL 330 instead of 120.","created_at":"2016-01-20T08:56:26Z","updated_at":"2016-01-22T16:45:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93058280c8361854a439f4d69d4e7139db77a0c6","assignee":null,"milestone":{"url":"https://api.github.com/repos/CGAL/cgal/milestones/7","html_url":"https://github.com/CGAL/cgal/milestones/4.8-beta","labels_url":"https://api.github.com/repos/CGAL/cgal/milestones/7/labels","id":1202221,"number":7,"title":"4.8-beta","description":"","creator":{"login":"lrineau","id":5746675,"avatar_url":"https://avatars.githubusercontent.com/u/5746675?v=3","gravatar_id":"","url":"https://api.github.com/users/lrineau","html_url":"https://github.com/lrineau","followers_url":"https://api.github.com/users/lrineau/followers","following_url":"https://api.github.com/users/lrineau/following{/other_user}","gists_url":"https://api.github.com/users/lrineau/gists{/gist_id}","starred_url":"https://api.github.com/users/lrineau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrineau/subscriptions","organizations_url":"https://api.github.com/users/lrineau/orgs","repos_url":"https://api.github.com/users/lrineau/repos","events_url":"https://api.github.com/users/lrineau/events{/privacy}","received_events_url":"https://api.github.com/users/lrineau/received_events","type":"User","site_admin":false},"open_issues":36,"closed_issues":256,"state":"open","created_at":"2015-07-10T10:06:47Z","updated_at":"2016-01-22T16:27:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/CGAL/cgal/pulls/654/commits","review_comments_url":"https://api.github.com/repos/CGAL/cgal/pulls/654/comments","review_comment_url":"https://api.github.com/repos/CGAL/cgal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CGAL/cgal/issues/654/comments","statuses_url":"https://api.github.com/repos/CGAL/cgal/statuses/eb867bb8102605af26b83e75af7662dfa6d06ea2","head":{"label":"maxGimeno:FixForMac-GF","ref":"FixForMac-GF","sha":"eb867bb8102605af26b83e75af7662dfa6d06ea2","user":{"login":"maxGimeno","id":11310805,"avatar_url":"https://avatars.githubusercontent.com/u/11310805?v=3","gravatar_id":"","url":"https://api.github.com/users/maxGimeno","html_url":"https://github.com/maxGimeno","followers_url":"https://api.github.com/users/maxGimeno/followers","following_url":"https://api.github.com/users/maxGimeno/following{/other_user}","gists_url":"https://api.github.com/users/maxGimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/maxGimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxGimeno/subscriptions","organizations_url":"https://api.github.com/users/maxGimeno/orgs","repos_url":"https://api.github.com/users/maxGimeno/repos","events_url":"https://api.github.com/users/maxGimeno/events{/privacy}","received_events_url":"https://api.github.com/users/maxGimeno/received_events","type":"User","site_admin":false},"repo":{"id":38375573,"name":"cgal","full_name":"maxGimeno/cgal","owner":{"login":"maxGimeno","id":11310805,"avatar_url":"https://avatars.githubusercontent.com/u/11310805?v=3","gravatar_id":"","url":"https://api.github.com/users/maxGimeno","html_url":"https://github.com/maxGimeno","followers_url":"https://api.github.com/users/maxGimeno/followers","following_url":"https://api.github.com/users/maxGimeno/following{/other_user}","gists_url":"https://api.github.com/users/maxGimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/maxGimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxGimeno/subscriptions","organizations_url":"https://api.github.com/users/maxGimeno/orgs","repos_url":"https://api.github.com/users/maxGimeno/repos","events_url":"https://api.github.com/users/maxGimeno/events{/privacy}","received_events_url":"https://api.github.com/users/maxGimeno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxGimeno/cgal","description":"The public CGAL repository","fork":true,"url":"https://api.github.com/repos/maxGimeno/cgal","forks_url":"https://api.github.com/repos/maxGimeno/cgal/forks","keys_url":"https://api.github.com/repos/maxGimeno/cgal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxGimeno/cgal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxGimeno/cgal/teams","hooks_url":"https://api.github.com/repos/maxGimeno/cgal/hooks","issue_events_url":"https://api.github.com/repos/maxGimeno/cgal/issues/events{/number}","events_url":"https://api.github.com/repos/maxGimeno/cgal/events","assignees_url":"https://api.github.com/repos/maxGimeno/cgal/assignees{/user}","branches_url":"https://api.github.com/repos/maxGimeno/cgal/branches{/branch}","tags_url":"https://api.github.com/repos/maxGimeno/cgal/tags","blobs_url":"https://api.github.com/repos/maxGimeno/cgal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxGimeno/cgal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxGimeno/cgal/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxGimeno/cgal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxGimeno/cgal/statuses/{sha}","languages_url":"https://api.github.com/repos/maxGimeno/cgal/languages","stargazers_url":"https://api.github.com/repos/maxGimeno/cgal/stargazers","contributors_url":"https://api.github.com/repos/maxGimeno/cgal/contributors","subscribers_url":"https://api.github.com/repos/maxGimeno/cgal/subscribers","subscription_url":"https://api.github.com/repos/maxGimeno/cgal/subscription","commits_url":"https://api.github.com/repos/maxGimeno/cgal/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxGimeno/cgal/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxGimeno/cgal/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxGimeno/cgal/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxGimeno/cgal/contents/{+path}","compare_url":"https://api.github.com/repos/maxGimeno/cgal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxGimeno/cgal/merges","archive_url":"https://api.github.com/repos/maxGimeno/cgal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxGimeno/cgal/downloads","issues_url":"https://api.github.com/repos/maxGimeno/cgal/issues{/number}","pulls_url":"https://api.github.com/repos/maxGimeno/cgal/pulls{/number}","milestones_url":"https://api.github.com/repos/maxGimeno/cgal/milestones{/number}","notifications_url":"https://api.github.com/repos/maxGimeno/cgal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxGimeno/cgal/labels{/name}","releases_url":"https://api.github.com/repos/maxGimeno/cgal/releases{/id}","deployments_url":"https://api.github.com/repos/maxGimeno/cgal/deployments","created_at":"2015-07-01T14:25:52Z","updated_at":"2015-07-01T14:26:51Z","pushed_at":"2016-01-22T16:14:23Z","git_url":"git://github.com/maxGimeno/cgal.git","ssh_url":"git@github.com:maxGimeno/cgal.git","clone_url":"https://github.com/maxGimeno/cgal.git","svn_url":"https://github.com/maxGimeno/cgal","homepage":"http://www.cgal.org","size":522777,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CGAL:master","ref":"master","sha":"df741e6cd5b6dd0eeec9328a004e177ffa729fac","user":{"login":"CGAL","id":5746664,"avatar_url":"https://avatars.githubusercontent.com/u/5746664?v=3","gravatar_id":"","url":"https://api.github.com/users/CGAL","html_url":"https://github.com/CGAL","followers_url":"https://api.github.com/users/CGAL/followers","following_url":"https://api.github.com/users/CGAL/following{/other_user}","gists_url":"https://api.github.com/users/CGAL/gists{/gist_id}","starred_url":"https://api.github.com/users/CGAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CGAL/subscriptions","organizations_url":"https://api.github.com/users/CGAL/orgs","repos_url":"https://api.github.com/users/CGAL/repos","events_url":"https://api.github.com/users/CGAL/events{/privacy}","received_events_url":"https://api.github.com/users/CGAL/received_events","type":"Organization","site_admin":false},"repo":{"id":24677392,"name":"cgal","full_name":"CGAL/cgal","owner":{"login":"CGAL","id":5746664,"avatar_url":"https://avatars.githubusercontent.com/u/5746664?v=3","gravatar_id":"","url":"https://api.github.com/users/CGAL","html_url":"https://github.com/CGAL","followers_url":"https://api.github.com/users/CGAL/followers","following_url":"https://api.github.com/users/CGAL/following{/other_user}","gists_url":"https://api.github.com/users/CGAL/gists{/gist_id}","starred_url":"https://api.github.com/users/CGAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CGAL/subscriptions","organizations_url":"https://api.github.com/users/CGAL/orgs","repos_url":"https://api.github.com/users/CGAL/repos","events_url":"https://api.github.com/users/CGAL/events{/privacy}","received_events_url":"https://api.github.com/users/CGAL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CGAL/cgal","description":"The public CGAL repository","fork":false,"url":"https://api.github.com/repos/CGAL/cgal","forks_url":"https://api.github.com/repos/CGAL/cgal/forks","keys_url":"https://api.github.com/repos/CGAL/cgal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CGAL/cgal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CGAL/cgal/teams","hooks_url":"https://api.github.com/repos/CGAL/cgal/hooks","issue_events_url":"https://api.github.com/repos/CGAL/cgal/issues/events{/number}","events_url":"https://api.github.com/repos/CGAL/cgal/events","assignees_url":"https://api.github.com/repos/CGAL/cgal/assignees{/user}","branches_url":"https://api.github.com/repos/CGAL/cgal/branches{/branch}","tags_url":"https://api.github.com/repos/CGAL/cgal/tags","blobs_url":"https://api.github.com/repos/CGAL/cgal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CGAL/cgal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CGAL/cgal/git/refs{/sha}","trees_url":"https://api.github.com/repos/CGAL/cgal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CGAL/cgal/statuses/{sha}","languages_url":"https://api.github.com/repos/CGAL/cgal/languages","stargazers_url":"https://api.github.com/repos/CGAL/cgal/stargazers","contributors_url":"https://api.github.com/repos/CGAL/cgal/contributors","subscribers_url":"https://api.github.com/repos/CGAL/cgal/subscribers","subscription_url":"https://api.github.com/repos/CGAL/cgal/subscription","commits_url":"https://api.github.com/repos/CGAL/cgal/commits{/sha}","git_commits_url":"https://api.github.com/repos/CGAL/cgal/git/commits{/sha}","comments_url":"https://api.github.com/repos/CGAL/cgal/comments{/number}","issue_comment_url":"https://api.github.com/repos/CGAL/cgal/issues/comments{/number}","contents_url":"https://api.github.com/repos/CGAL/cgal/contents/{+path}","compare_url":"https://api.github.com/repos/CGAL/cgal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CGAL/cgal/merges","archive_url":"https://api.github.com/repos/CGAL/cgal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CGAL/cgal/downloads","issues_url":"https://api.github.com/repos/CGAL/cgal/issues{/number}","pulls_url":"https://api.github.com/repos/CGAL/cgal/pulls{/number}","milestones_url":"https://api.github.com/repos/CGAL/cgal/milestones{/number}","notifications_url":"https://api.github.com/repos/CGAL/cgal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CGAL/cgal/labels{/name}","releases_url":"https://api.github.com/repos/CGAL/cgal/releases{/id}","deployments_url":"https://api.github.com/repos/CGAL/cgal/deployments","created_at":"2014-10-01T12:22:47Z","updated_at":"2016-01-20T07:31:42Z","pushed_at":"2016-01-22T16:14:22Z","git_url":"git://github.com/CGAL/cgal.git","ssh_url":"git@github.com:CGAL/cgal.git","clone_url":"https://github.com/CGAL/cgal.git","svn_url":"https://github.com/CGAL/cgal","homepage":"http://www.cgal.org","size":553560,"stargazers_count":175,"watchers_count":175,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":102,"mirror_url":null,"open_issues_count":109,"forks":102,"open_issues":109,"watchers":175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/654"},"html":{"href":"https://github.com/CGAL/cgal/pull/654"},"issue":{"href":"https://api.github.com/repos/CGAL/cgal/issues/654"},"comments":{"href":"https://api.github.com/repos/CGAL/cgal/issues/654/comments"},"review_comments":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/654/comments"},"review_comment":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/654/commits"},"statuses":{"href":"https://api.github.com/repos/CGAL/cgal/statuses/eb867bb8102605af26b83e75af7662dfa6d06ea2"}}}}