{"action":"created","comment":{"url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/pulls/comments/70732925","id":70732925,"diff_hunk":"@@ -198,9 +201,9 @@ void vtkMRMLMarkupsToModelNode::ReadXMLAttributes( const char** atts )\n       nameString << attValue;\n       nameString >> this->KochanekTension;\n     }\n-\n   }\n-  //vtkDebugMacro(\"XML atts number of tools read \"<<GetNumberOfTools());\n+\n+  this->Modified();","path":"MarkupsToModel/MRML/vtkMRMLMarkupsToModelNode.cxx","position":165,"original_position":165,"commit_id":"9e52a003f5774e94a86846638f1062ed4919b9b4","original_commit_id":"9e52a003f5774e94a86846638f1062ed4919b9b4","user":{"login":"lassoan","id":307929,"avatar_url":"https://avatars.githubusercontent.com/u/307929?v=3","gravatar_id":"","url":"https://api.github.com/users/lassoan","html_url":"https://github.com/lassoan","followers_url":"https://api.github.com/users/lassoan/followers","following_url":"https://api.github.com/users/lassoan/following{/other_user}","gists_url":"https://api.github.com/users/lassoan/gists{/gist_id}","starred_url":"https://api.github.com/users/lassoan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lassoan/subscriptions","organizations_url":"https://api.github.com/users/lassoan/orgs","repos_url":"https://api.github.com/users/lassoan/repos","events_url":"https://api.github.com/users/lassoan/events{/privacy}","received_events_url":"https://api.github.com/users/lassoan/received_events","type":"User","site_admin":false},"body":"Instead of hardcoding calling of Modified(), use Set... functions, which take care of calling Modified() if something is actually modified. Call StartModify/EndModify to prevent multiple Modified event invokations (see for example how it is done in vtkMRMLSegmentEditorNode).","created_at":"2016-07-14T00:38:02Z","updated_at":"2016-07-14T00:38:02Z","html_url":"https://github.com/SlicerIGT/SlicerIGT/pull/90#discussion_r70732925","pull_request_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/pulls/90","_links":{"self":{"href":"https://api.github.com/repos/SlicerIGT/SlicerIGT/pulls/comments/70732925"},"html":{"href":"https://github.com/SlicerIGT/SlicerIGT/pull/90#discussion_r70732925"},"pull_request":{"href":"https://api.github.com/repos/SlicerIGT/SlicerIGT/pulls/90"}}},"pull_request":{"url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/pulls/90","id":77289769,"html_url":"https://github.com/SlicerIGT/SlicerIGT/pull/90","diff_url":"https://github.com/SlicerIGT/SlicerIGT/pull/90.diff","patch_url":"https://github.com/SlicerIGT/SlicerIGT/pull/90.patch","issue_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/issues/90","number":90,"state":"open","locked":false,"title":"Markupstomodel guiupdate","user":{"login":"tavaughan","id":6616890,"avatar_url":"https://avatars.githubusercontent.com/u/6616890?v=3","gravatar_id":"","url":"https://api.github.com/users/tavaughan","html_url":"https://github.com/tavaughan","followers_url":"https://api.github.com/users/tavaughan/followers","following_url":"https://api.github.com/users/tavaughan/following{/other_user}","gists_url":"https://api.github.com/users/tavaughan/gists{/gist_id}","starred_url":"https://api.github.com/users/tavaughan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tavaughan/subscriptions","organizations_url":"https://api.github.com/users/tavaughan/orgs","repos_url":"https://api.github.com/users/tavaughan/repos","events_url":"https://api.github.com/users/tavaughan/events{/privacy}","received_events_url":"https://api.github.com/users/tavaughan/received_events","type":"User","site_admin":false},"body":"Not ready for actual merging yet, but please review:\r\n1. How the GUI and MRML node are synchronized\r\n2. Why the combobox selections aren't loaded from saved scenes\r\nThanks,\r\nThomas\r\n","created_at":"2016-07-13T13:36:24Z","updated_at":"2016-07-14T00:38:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de22c0f19d6a287d2cbbc5edf6a619f0c30462f9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/pulls/90/commits","review_comments_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/pulls/90/comments","review_comment_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/issues/90/comments","statuses_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/statuses/9e52a003f5774e94a86846638f1062ed4919b9b4","head":{"label":"tavaughan:markupstomodel-guiupdate","ref":"markupstomodel-guiupdate","sha":"9e52a003f5774e94a86846638f1062ed4919b9b4","user":{"login":"tavaughan","id":6616890,"avatar_url":"https://avatars.githubusercontent.com/u/6616890?v=3","gravatar_id":"","url":"https://api.github.com/users/tavaughan","html_url":"https://github.com/tavaughan","followers_url":"https://api.github.com/users/tavaughan/followers","following_url":"https://api.github.com/users/tavaughan/following{/other_user}","gists_url":"https://api.github.com/users/tavaughan/gists{/gist_id}","starred_url":"https://api.github.com/users/tavaughan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tavaughan/subscriptions","organizations_url":"https://api.github.com/users/tavaughan/orgs","repos_url":"https://api.github.com/users/tavaughan/repos","events_url":"https://api.github.com/users/tavaughan/events{/privacy}","received_events_url":"https://api.github.com/users/tavaughan/received_events","type":"User","site_admin":false},"repo":{"id":61669898,"name":"SlicerIGT","full_name":"tavaughan/SlicerIGT","owner":{"login":"tavaughan","id":6616890,"avatar_url":"https://avatars.githubusercontent.com/u/6616890?v=3","gravatar_id":"","url":"https://api.github.com/users/tavaughan","html_url":"https://github.com/tavaughan","followers_url":"https://api.github.com/users/tavaughan/followers","following_url":"https://api.github.com/users/tavaughan/following{/other_user}","gists_url":"https://api.github.com/users/tavaughan/gists{/gist_id}","starred_url":"https://api.github.com/users/tavaughan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tavaughan/subscriptions","organizations_url":"https://api.github.com/users/tavaughan/orgs","repos_url":"https://api.github.com/users/tavaughan/repos","events_url":"https://api.github.com/users/tavaughan/events{/privacy}","received_events_url":"https://api.github.com/users/tavaughan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tavaughan/SlicerIGT","description":"Modules supporting image-guided interventions in 3D Slicer.","fork":true,"url":"https://api.github.com/repos/tavaughan/SlicerIGT","forks_url":"https://api.github.com/repos/tavaughan/SlicerIGT/forks","keys_url":"https://api.github.com/repos/tavaughan/SlicerIGT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tavaughan/SlicerIGT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tavaughan/SlicerIGT/teams","hooks_url":"https://api.github.com/repos/tavaughan/SlicerIGT/hooks","issue_events_url":"https://api.github.com/repos/tavaughan/SlicerIGT/issues/events{/number}","events_url":"https://api.github.com/repos/tavaughan/SlicerIGT/events","assignees_url":"https://api.github.com/repos/tavaughan/SlicerIGT/assignees{/user}","branches_url":"https://api.github.com/repos/tavaughan/SlicerIGT/branches{/branch}","tags_url":"https://api.github.com/repos/tavaughan/SlicerIGT/tags","blobs_url":"https://api.github.com/repos/tavaughan/SlicerIGT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tavaughan/SlicerIGT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tavaughan/SlicerIGT/git/refs{/sha}","trees_url":"https://api.github.com/repos/tavaughan/SlicerIGT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tavaughan/SlicerIGT/statuses/{sha}","languages_url":"https://api.github.com/repos/tavaughan/SlicerIGT/languages","stargazers_url":"https://api.github.com/repos/tavaughan/SlicerIGT/stargazers","contributors_url":"https://api.github.com/repos/tavaughan/SlicerIGT/contributors","subscribers_url":"https://api.github.com/repos/tavaughan/SlicerIGT/subscribers","subscription_url":"https://api.github.com/repos/tavaughan/SlicerIGT/subscription","commits_url":"https://api.github.com/repos/tavaughan/SlicerIGT/commits{/sha}","git_commits_url":"https://api.github.com/repos/tavaughan/SlicerIGT/git/commits{/sha}","comments_url":"https://api.github.com/repos/tavaughan/SlicerIGT/comments{/number}","issue_comment_url":"https://api.github.com/repos/tavaughan/SlicerIGT/issues/comments{/number}","contents_url":"https://api.github.com/repos/tavaughan/SlicerIGT/contents/{+path}","compare_url":"https://api.github.com/repos/tavaughan/SlicerIGT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tavaughan/SlicerIGT/merges","archive_url":"https://api.github.com/repos/tavaughan/SlicerIGT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tavaughan/SlicerIGT/downloads","issues_url":"https://api.github.com/repos/tavaughan/SlicerIGT/issues{/number}","pulls_url":"https://api.github.com/repos/tavaughan/SlicerIGT/pulls{/number}","milestones_url":"https://api.github.com/repos/tavaughan/SlicerIGT/milestones{/number}","notifications_url":"https://api.github.com/repos/tavaughan/SlicerIGT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tavaughan/SlicerIGT/labels{/name}","releases_url":"https://api.github.com/repos/tavaughan/SlicerIGT/releases{/id}","deployments_url":"https://api.github.com/repos/tavaughan/SlicerIGT/deployments","created_at":"2016-06-21T21:57:18Z","updated_at":"2016-06-21T21:57:19Z","pushed_at":"2016-07-13T13:33:52Z","git_url":"git://github.com/tavaughan/SlicerIGT.git","ssh_url":"git@github.com:tavaughan/SlicerIGT.git","clone_url":"https://github.com/tavaughan/SlicerIGT.git","svn_url":"https://github.com/tavaughan/SlicerIGT","homepage":null,"size":2783,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SlicerIGT:master","ref":"master","sha":"f263e7140f42da3b383f4e930ffcca51e06235ca","user":{"login":"SlicerIGT","id":2845029,"avatar_url":"https://avatars.githubusercontent.com/u/2845029?v=3","gravatar_id":"","url":"https://api.github.com/users/SlicerIGT","html_url":"https://github.com/SlicerIGT","followers_url":"https://api.github.com/users/SlicerIGT/followers","following_url":"https://api.github.com/users/SlicerIGT/following{/other_user}","gists_url":"https://api.github.com/users/SlicerIGT/gists{/gist_id}","starred_url":"https://api.github.com/users/SlicerIGT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlicerIGT/subscriptions","organizations_url":"https://api.github.com/users/SlicerIGT/orgs","repos_url":"https://api.github.com/users/SlicerIGT/repos","events_url":"https://api.github.com/users/SlicerIGT/events{/privacy}","received_events_url":"https://api.github.com/users/SlicerIGT/received_events","type":"Organization","site_admin":false},"repo":{"id":6869446,"name":"SlicerIGT","full_name":"SlicerIGT/SlicerIGT","owner":{"login":"SlicerIGT","id":2845029,"avatar_url":"https://avatars.githubusercontent.com/u/2845029?v=3","gravatar_id":"","url":"https://api.github.com/users/SlicerIGT","html_url":"https://github.com/SlicerIGT","followers_url":"https://api.github.com/users/SlicerIGT/followers","following_url":"https://api.github.com/users/SlicerIGT/following{/other_user}","gists_url":"https://api.github.com/users/SlicerIGT/gists{/gist_id}","starred_url":"https://api.github.com/users/SlicerIGT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlicerIGT/subscriptions","organizations_url":"https://api.github.com/users/SlicerIGT/orgs","repos_url":"https://api.github.com/users/SlicerIGT/repos","events_url":"https://api.github.com/users/SlicerIGT/events{/privacy}","received_events_url":"https://api.github.com/users/SlicerIGT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SlicerIGT/SlicerIGT","description":"Modules supporting image-guided interventions in 3D Slicer.","fork":false,"url":"https://api.github.com/repos/SlicerIGT/SlicerIGT","forks_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/forks","keys_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/teams","hooks_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/hooks","issue_events_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/issues/events{/number}","events_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/events","assignees_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/assignees{/user}","branches_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/branches{/branch}","tags_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/tags","blobs_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/git/refs{/sha}","trees_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/statuses/{sha}","languages_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/languages","stargazers_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/stargazers","contributors_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/contributors","subscribers_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/subscribers","subscription_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/subscription","commits_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/commits{/sha}","git_commits_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/git/commits{/sha}","comments_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/comments{/number}","issue_comment_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/issues/comments{/number}","contents_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/contents/{+path}","compare_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/merges","archive_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/downloads","issues_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/issues{/number}","pulls_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/pulls{/number}","milestones_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/milestones{/number}","notifications_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/labels{/name}","releases_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/releases{/id}","deployments_url":"https://api.github.com/repos/SlicerIGT/SlicerIGT/deployments","created_at":"2012-11-26T17:30:45Z","updated_at":"2016-05-11T06:28:10Z","pushed_at":"2016-07-13T13:36:24Z","git_url":"git://github.com/SlicerIGT/SlicerIGT.git","ssh_url":"git@github.com:SlicerIGT/SlicerIGT.git","clone_url":"https://github.com/SlicerIGT/SlicerIGT.git","svn_url":"https://github.com/SlicerIGT/SlicerIGT","homepage":null,"size":3087,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":40,"forks":20,"open_issues":40,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SlicerIGT/SlicerIGT/pulls/90"},"html":{"href":"https://github.com/SlicerIGT/SlicerIGT/pull/90"},"issue":{"href":"https://api.github.com/repos/SlicerIGT/SlicerIGT/issues/90"},"comments":{"href":"https://api.github.com/repos/SlicerIGT/SlicerIGT/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/SlicerIGT/SlicerIGT/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/SlicerIGT/SlicerIGT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SlicerIGT/SlicerIGT/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/SlicerIGT/SlicerIGT/statuses/9e52a003f5774e94a86846638f1062ed4919b9b4"}}}}
{"actor":{"display_login":"lassoan"}}