{"action":"closed","number":120,"pull_request":{"url":"https://api.github.com/repos/mesos/storm/pulls/120","id":64555080,"html_url":"https://github.com/mesos/storm/pull/120","diff_url":"https://github.com/mesos/storm/pull/120.diff","patch_url":"https://github.com/mesos/storm/pull/120.patch","issue_url":"https://api.github.com/repos/mesos/storm/issues/120","number":120,"state":"closed","locked":false,"title":"Add support for building storm-mesos docker images based on storm, mesos versions","user":{"login":"salimane","id":403938,"avatar_url":"https://avatars.githubusercontent.com/u/403938?v=3","gravatar_id":"","url":"https://api.github.com/users/salimane","html_url":"https://github.com/salimane","followers_url":"https://api.github.com/users/salimane/followers","following_url":"https://api.github.com/users/salimane/following{/other_user}","gists_url":"https://api.github.com/users/salimane/gists{/gist_id}","starred_url":"https://api.github.com/users/salimane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salimane/subscriptions","organizations_url":"https://api.github.com/users/salimane/orgs","repos_url":"https://api.github.com/users/salimane/repos","events_url":"https://api.github.com/users/salimane/events{/privacy}","received_events_url":"https://api.github.com/users/salimane/received_events","type":"User","site_admin":false},"body":"This PR makes it possible to automate the building of storm-mesos docker images based on storm, mesos versions.\r\n\r\nI've also included in this PR:\r\n\r\n- an onbuild version of the storm-mesos docker image to import from if needed\r\n- ability to build a JAVA 8 runtime version of the docker image\r\n- add a makefile for building and pushing docker images\r\n- update the function ``dockerImage`` in ``build_release.sh`` to use the new make target\r\n\r\nTo build a new storm-mesos docker image, just do:\r\n```shell\r\nmake help\r\nmake images STORM_RELEASE=0.10.0 MESOS_RELEASE=0.28.0 DOCKER_REPO=mesos\r\n```\r\n\r\nThis PR needs to be merged before I could finish off #83  #117 with automated docker image building on docker hub\r\n\r\nWith this PR, we can also close #109 .\r\n\r\ncc @erikdw @lfundaro @DarinJ @dsKarthick \r\nThanks","created_at":"2016-03-30T00:23:23Z","updated_at":"2016-04-18T07:01:41Z","closed_at":"2016-04-18T07:01:40Z","merged_at":"2016-04-18T07:01:40Z","merge_commit_sha":"fa0858fae2d0ebeab0692ad79943275d6b7aedbd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mesos/storm/pulls/120/commits","review_comments_url":"https://api.github.com/repos/mesos/storm/pulls/120/comments","review_comment_url":"https://api.github.com/repos/mesos/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesos/storm/issues/120/comments","statuses_url":"https://api.github.com/repos/mesos/storm/statuses/0d469178eb715c6236e3161a9e612c3a6ed0ecc5","head":{"label":"salimane:docker_builds","ref":"docker_builds","sha":"0d469178eb715c6236e3161a9e612c3a6ed0ecc5","user":{"login":"salimane","id":403938,"avatar_url":"https://avatars.githubusercontent.com/u/403938?v=3","gravatar_id":"","url":"https://api.github.com/users/salimane","html_url":"https://github.com/salimane","followers_url":"https://api.github.com/users/salimane/followers","following_url":"https://api.github.com/users/salimane/following{/other_user}","gists_url":"https://api.github.com/users/salimane/gists{/gist_id}","starred_url":"https://api.github.com/users/salimane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salimane/subscriptions","organizations_url":"https://api.github.com/users/salimane/orgs","repos_url":"https://api.github.com/users/salimane/repos","events_url":"https://api.github.com/users/salimane/events{/privacy}","received_events_url":"https://api.github.com/users/salimane/received_events","type":"User","site_admin":false},"repo":{"id":40649016,"name":"storm","full_name":"salimane/storm","owner":{"login":"salimane","id":403938,"avatar_url":"https://avatars.githubusercontent.com/u/403938?v=3","gravatar_id":"","url":"https://api.github.com/users/salimane","html_url":"https://github.com/salimane","followers_url":"https://api.github.com/users/salimane/followers","following_url":"https://api.github.com/users/salimane/following{/other_user}","gists_url":"https://api.github.com/users/salimane/gists{/gist_id}","starred_url":"https://api.github.com/users/salimane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salimane/subscriptions","organizations_url":"https://api.github.com/users/salimane/orgs","repos_url":"https://api.github.com/users/salimane/repos","events_url":"https://api.github.com/users/salimane/events{/privacy}","received_events_url":"https://api.github.com/users/salimane/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/salimane/storm","description":"Storm on Mesos!","fork":true,"url":"https://api.github.com/repos/salimane/storm","forks_url":"https://api.github.com/repos/salimane/storm/forks","keys_url":"https://api.github.com/repos/salimane/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salimane/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salimane/storm/teams","hooks_url":"https://api.github.com/repos/salimane/storm/hooks","issue_events_url":"https://api.github.com/repos/salimane/storm/issues/events{/number}","events_url":"https://api.github.com/repos/salimane/storm/events","assignees_url":"https://api.github.com/repos/salimane/storm/assignees{/user}","branches_url":"https://api.github.com/repos/salimane/storm/branches{/branch}","tags_url":"https://api.github.com/repos/salimane/storm/tags","blobs_url":"https://api.github.com/repos/salimane/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salimane/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salimane/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/salimane/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salimane/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/salimane/storm/languages","stargazers_url":"https://api.github.com/repos/salimane/storm/stargazers","contributors_url":"https://api.github.com/repos/salimane/storm/contributors","subscribers_url":"https://api.github.com/repos/salimane/storm/subscribers","subscription_url":"https://api.github.com/repos/salimane/storm/subscription","commits_url":"https://api.github.com/repos/salimane/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/salimane/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/salimane/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/salimane/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/salimane/storm/contents/{+path}","compare_url":"https://api.github.com/repos/salimane/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salimane/storm/merges","archive_url":"https://api.github.com/repos/salimane/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salimane/storm/downloads","issues_url":"https://api.github.com/repos/salimane/storm/issues{/number}","pulls_url":"https://api.github.com/repos/salimane/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/salimane/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/salimane/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salimane/storm/labels{/name}","releases_url":"https://api.github.com/repos/salimane/storm/releases{/id}","deployments_url":"https://api.github.com/repos/salimane/storm/deployments","created_at":"2015-08-13T08:58:58Z","updated_at":"2016-03-26T20:41:26Z","pushed_at":"2016-04-18T06:17:24Z","git_url":"git://github.com/salimane/storm.git","ssh_url":"git@github.com:salimane/storm.git","clone_url":"https://github.com/salimane/storm.git","svn_url":"https://github.com/salimane/storm","homepage":null,"size":322,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mesos:master","ref":"master","sha":"90916449c528672b919a0cfabbfba787dd4501d8","user":{"login":"mesos","id":229272,"avatar_url":"https://avatars.githubusercontent.com/u/229272?v=3","gravatar_id":"","url":"https://api.github.com/users/mesos","html_url":"https://github.com/mesos","followers_url":"https://api.github.com/users/mesos/followers","following_url":"https://api.github.com/users/mesos/following{/other_user}","gists_url":"https://api.github.com/users/mesos/gists{/gist_id}","starred_url":"https://api.github.com/users/mesos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesos/subscriptions","organizations_url":"https://api.github.com/users/mesos/orgs","repos_url":"https://api.github.com/users/mesos/repos","events_url":"https://api.github.com/users/mesos/events{/privacy}","received_events_url":"https://api.github.com/users/mesos/received_events","type":"Organization","site_admin":false},"repo":{"id":21285858,"name":"storm","full_name":"mesos/storm","owner":{"login":"mesos","id":229272,"avatar_url":"https://avatars.githubusercontent.com/u/229272?v=3","gravatar_id":"","url":"https://api.github.com/users/mesos","html_url":"https://github.com/mesos","followers_url":"https://api.github.com/users/mesos/followers","following_url":"https://api.github.com/users/mesos/following{/other_user}","gists_url":"https://api.github.com/users/mesos/gists{/gist_id}","starred_url":"https://api.github.com/users/mesos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesos/subscriptions","organizations_url":"https://api.github.com/users/mesos/orgs","repos_url":"https://api.github.com/users/mesos/repos","events_url":"https://api.github.com/users/mesos/events{/privacy}","received_events_url":"https://api.github.com/users/mesos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesos/storm","description":"Storm on Mesos!","fork":false,"url":"https://api.github.com/repos/mesos/storm","forks_url":"https://api.github.com/repos/mesos/storm/forks","keys_url":"https://api.github.com/repos/mesos/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesos/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesos/storm/teams","hooks_url":"https://api.github.com/repos/mesos/storm/hooks","issue_events_url":"https://api.github.com/repos/mesos/storm/issues/events{/number}","events_url":"https://api.github.com/repos/mesos/storm/events","assignees_url":"https://api.github.com/repos/mesos/storm/assignees{/user}","branches_url":"https://api.github.com/repos/mesos/storm/branches{/branch}","tags_url":"https://api.github.com/repos/mesos/storm/tags","blobs_url":"https://api.github.com/repos/mesos/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesos/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesos/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesos/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesos/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/mesos/storm/languages","stargazers_url":"https://api.github.com/repos/mesos/storm/stargazers","contributors_url":"https://api.github.com/repos/mesos/storm/contributors","subscribers_url":"https://api.github.com/repos/mesos/storm/subscribers","subscription_url":"https://api.github.com/repos/mesos/storm/subscription","commits_url":"https://api.github.com/repos/mesos/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesos/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesos/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesos/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesos/storm/contents/{+path}","compare_url":"https://api.github.com/repos/mesos/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesos/storm/merges","archive_url":"https://api.github.com/repos/mesos/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesos/storm/downloads","issues_url":"https://api.github.com/repos/mesos/storm/issues{/number}","pulls_url":"https://api.github.com/repos/mesos/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/mesos/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/mesos/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesos/storm/labels{/name}","releases_url":"https://api.github.com/repos/mesos/storm/releases{/id}","deployments_url":"https://api.github.com/repos/mesos/storm/deployments","created_at":"2014-06-27T18:51:37Z","updated_at":"2016-04-13T09:39:39Z","pushed_at":"2016-04-18T07:01:41Z","git_url":"git://github.com/mesos/storm.git","ssh_url":"git@github.com:mesos/storm.git","clone_url":"https://github.com/mesos/storm.git","svn_url":"https://github.com/mesos/storm","homepage":null,"size":485,"stargazers_count":91,"watchers_count":91,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":18,"forks":48,"open_issues":18,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesos/storm/pulls/120"},"html":{"href":"https://github.com/mesos/storm/pull/120"},"issue":{"href":"https://api.github.com/repos/mesos/storm/issues/120"},"comments":{"href":"https://api.github.com/repos/mesos/storm/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/mesos/storm/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/mesos/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesos/storm/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/mesos/storm/statuses/0d469178eb715c6236e3161a9e612c3a6ed0ecc5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"erikdw","id":1111441,"avatar_url":"https://avatars.githubusercontent.com/u/1111441?v=3","gravatar_id":"","url":"https://api.github.com/users/erikdw","html_url":"https://github.com/erikdw","followers_url":"https://api.github.com/users/erikdw/followers","following_url":"https://api.github.com/users/erikdw/following{/other_user}","gists_url":"https://api.github.com/users/erikdw/gists{/gist_id}","starred_url":"https://api.github.com/users/erikdw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikdw/subscriptions","organizations_url":"https://api.github.com/users/erikdw/orgs","repos_url":"https://api.github.com/users/erikdw/repos","events_url":"https://api.github.com/users/erikdw/events{/privacy}","received_events_url":"https://api.github.com/users/erikdw/received_events","type":"User","site_admin":false},"comments":9,"review_comments":18,"commits":1,"additions":225,"deletions":33,"changed_files":6}}