{"action":"created","issue":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/6726","repository_url":"https://api.github.com/repos/DynamoDS/Dynamo","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/6726/labels{/name}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/6726/comments","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/6726/events","html_url":"https://github.com/DynamoDS/Dynamo/pull/6726","id":159865007,"number":6726,"title":"remove changes to IPreferences and IWatchViewModel","user":{"login":"mjkkirschner","id":508936,"avatar_url":"https://avatars.githubusercontent.com/u/508936?v=3","gravatar_id":"","url":"https://api.github.com/users/mjkkirschner","html_url":"https://github.com/mjkkirschner","followers_url":"https://api.github.com/users/mjkkirschner/followers","following_url":"https://api.github.com/users/mjkkirschner/following{/other_user}","gists_url":"https://api.github.com/users/mjkkirschner/gists{/gist_id}","starred_url":"https://api.github.com/users/mjkkirschner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjkkirschner/subscriptions","organizations_url":"https://api.github.com/users/mjkkirschner/orgs","repos_url":"https://api.github.com/users/mjkkirschner/repos","events_url":"https://api.github.com/users/mjkkirschner/events{/privacy}","received_events_url":"https://api.github.com/users/mjkkirschner/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/DynamoDS/Dynamo/labels/LGTM","name":"LGTM","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-13T02:53:35Z","updated_at":"2016-06-20T15:20:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/6726","html_url":"https://github.com/DynamoDS/Dynamo/pull/6726","diff_url":"https://github.com/DynamoDS/Dynamo/pull/6726.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/6726.patch"},"body":"### Purpose\r\n\r\nhttp://adsk-oss.myjetbrains.com/youtrack/issue/MAGN-10147\r\n\r\nThis PR moves changes that were made to `IPreferences` and `IWatchViewModel` after 1.0 to separate interfaces that the concrete types implement in addition to those original interfaces.\r\n\r\nFor example `PreferenceSettings` now implements `IPreferences` in addition to `IBackgroundPreferences` and `IPreviewBubblePreferences` - these other interfaces should most likely be fused with IPreferences when we can break the API.\r\n\r\nI've obsoleted the removed property `IsBackgroundPreviewActive` and it now calls the new API methods and searches for the default background preview name.\r\n\r\nI've also added two tests using the 1.0 API since we are re-adding it.\r\n\r\n### Declarations\r\n\r\nCheck these if you believe they are true\r\n\r\n- [x] The code base is in a better state after this PR\r\n- [x] Is documented according to the [standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards)\r\n- [x] The level of testing this PR includes is appropriate\r\n- [x] User facing strings, if any, are extracted into `*.resx` files\r\n- [ ] All tests pass using the self-service CI.\r\n- [ ] Snapshot of UI changes, if any.\r\n\r\n### Reviewers\r\n\r\n@sharadkjaiswal \r\n@QilongTang \r\n\r\n### FYIs\r\n\r\n@Benglin \r\n@kronz \r\n@jnealb "},"comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments/227174482","html_url":"https://github.com/DynamoDS/Dynamo/pull/6726#issuecomment-227174482","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/6726","id":227174482,"user":{"login":"sm6srw","id":7033002,"avatar_url":"https://avatars.githubusercontent.com/u/7033002?v=3","gravatar_id":"","url":"https://api.github.com/users/sm6srw","html_url":"https://github.com/sm6srw","followers_url":"https://api.github.com/users/sm6srw/followers","following_url":"https://api.github.com/users/sm6srw/following{/other_user}","gists_url":"https://api.github.com/users/sm6srw/gists{/gist_id}","starred_url":"https://api.github.com/users/sm6srw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sm6srw/subscriptions","organizations_url":"https://api.github.com/users/sm6srw/orgs","repos_url":"https://api.github.com/users/sm6srw/repos","events_url":"https://api.github.com/users/sm6srw/events{/privacy}","received_events_url":"https://api.github.com/users/sm6srw/received_events","type":"User","site_admin":false},"created_at":"2016-06-20T15:20:31Z","updated_at":"2016-06-20T15:20:31Z","body":"@mjkkirschner It looks really good! "}}
{"actor":{"display_login":"sm6srw"}}