{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/kvproto/pulls/comments/58865304","id":58865304,"diff_hunk":"@@ -150,23 +143,24 @@ message CmdCommitThenGetResponse {\n }\n \n message Request {\n-    optional MessageType type                           = 1;\n-    optional CmdGetRequest cmd_get_req                  = 2;\n-    optional CmdScanRequest cmd_scan_req                = 3;\n-    optional CmdPrewriteRequest cmd_prewrite_req        = 4;\n-    optional CmdCommitRequest cmd_commit_req            = 5;\n-    optional CmdCleanupRequest cmd_cleanup_req          = 6;\n-    optional CmdRollbackThenGetRequest cmd_rb_get_req   = 7;\n-    optional CmdCommitThenGetRequest cmd_commit_get_req = 8;\n+    optional MessageType               type               = 1;\n+    optional Context                   context            = 2;\n+    optional CmdGetRequest             cmd_get_req        = 3;\n+    optional CmdScanRequest            cmd_scan_req       = 4;\n+    optional CmdPrewriteRequest        cmd_prewrite_req   = 5;\n+    optional CmdCommitRequest          cmd_commit_req     = 6;\n+    optional CmdCleanupRequest         cmd_cleanup_req    = 7;\n+    optional CmdRollbackThenGetRequest cmd_rb_get_req     = 8;","path":"proto/kvrpcpb.proto","position":114,"original_position":114,"commit_id":"51e39a6f595e731c721742ec5349c0b6b4e51106","original_commit_id":"51e39a6f595e731c721742ec5349c0b6b4e51106","user":{"login":"qiuyesuifeng","id":1953644,"avatar_url":"https://avatars.githubusercontent.com/u/1953644?v=3","gravatar_id":"","url":"https://api.github.com/users/qiuyesuifeng","html_url":"https://github.com/qiuyesuifeng","followers_url":"https://api.github.com/users/qiuyesuifeng/followers","following_url":"https://api.github.com/users/qiuyesuifeng/following{/other_user}","gists_url":"https://api.github.com/users/qiuyesuifeng/gists{/gist_id}","starred_url":"https://api.github.com/users/qiuyesuifeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiuyesuifeng/subscriptions","organizations_url":"https://api.github.com/users/qiuyesuifeng/orgs","repos_url":"https://api.github.com/users/qiuyesuifeng/repos","events_url":"https://api.github.com/users/qiuyesuifeng/events{/privacy}","received_events_url":"https://api.github.com/users/qiuyesuifeng/received_events","type":"User","site_admin":false},"body":"How about directly using `cmd_rollback_get_req`?\r\nSeems much clearer.","created_at":"2016-04-07T12:52:54Z","updated_at":"2016-04-07T12:52:54Z","html_url":"https://github.com/pingcap/kvproto/pull/40#discussion_r58865304","pull_request_url":"https://api.github.com/repos/pingcap/kvproto/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/pingcap/kvproto/pulls/comments/58865304"},"html":{"href":"https://github.com/pingcap/kvproto/pull/40#discussion_r58865304"},"pull_request":{"href":"https://api.github.com/repos/pingcap/kvproto/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/kvproto/pulls/40","id":65571075,"html_url":"https://github.com/pingcap/kvproto/pull/40","diff_url":"https://github.com/pingcap/kvproto/pull/40.diff","patch_url":"https://github.com/pingcap/kvproto/pull/40.patch","issue_url":"https://api.github.com/repos/pingcap/kvproto/issues/40","number":40,"state":"open","locked":false,"title":"[DNM] kvrpc: move context to Request","user":{"login":"disksing","id":12077877,"avatar_url":"https://avatars.githubusercontent.com/u/12077877?v=3","gravatar_id":"","url":"https://api.github.com/users/disksing","html_url":"https://github.com/disksing","followers_url":"https://api.github.com/users/disksing/followers","following_url":"https://api.github.com/users/disksing/following{/other_user}","gists_url":"https://api.github.com/users/disksing/gists{/gist_id}","starred_url":"https://api.github.com/users/disksing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/disksing/subscriptions","organizations_url":"https://api.github.com/users/disksing/orgs","repos_url":"https://api.github.com/users/disksing/repos","events_url":"https://api.github.com/users/disksing/events{/privacy}","received_events_url":"https://api.github.com/users/disksing/received_events","type":"User","site_admin":false},"body":"@ngaut @siddontang @morefreeze @BusyJay PTAL","created_at":"2016-04-07T04:01:14Z","updated_at":"2016-04-07T12:52:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb4e10babee904c73832e4926bcfec29be4631c2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/kvproto/pulls/40/commits","review_comments_url":"https://api.github.com/repos/pingcap/kvproto/pulls/40/comments","review_comment_url":"https://api.github.com/repos/pingcap/kvproto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/kvproto/issues/40/comments","statuses_url":"https://api.github.com/repos/pingcap/kvproto/statuses/51e39a6f595e731c721742ec5349c0b6b4e51106","head":{"label":"pingcap:disksing/move-context","ref":"disksing/move-context","sha":"51e39a6f595e731c721742ec5349c0b6b4e51106","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":53628424,"name":"kvproto","full_name":"pingcap/kvproto","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/kvproto","description":"Protocol buffer files for TiKV","fork":false,"url":"https://api.github.com/repos/pingcap/kvproto","forks_url":"https://api.github.com/repos/pingcap/kvproto/forks","keys_url":"https://api.github.com/repos/pingcap/kvproto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/kvproto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/kvproto/teams","hooks_url":"https://api.github.com/repos/pingcap/kvproto/hooks","issue_events_url":"https://api.github.com/repos/pingcap/kvproto/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/kvproto/events","assignees_url":"https://api.github.com/repos/pingcap/kvproto/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/kvproto/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/kvproto/tags","blobs_url":"https://api.github.com/repos/pingcap/kvproto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/kvproto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/kvproto/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/kvproto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/kvproto/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/kvproto/languages","stargazers_url":"https://api.github.com/repos/pingcap/kvproto/stargazers","contributors_url":"https://api.github.com/repos/pingcap/kvproto/contributors","subscribers_url":"https://api.github.com/repos/pingcap/kvproto/subscribers","subscription_url":"https://api.github.com/repos/pingcap/kvproto/subscription","commits_url":"https://api.github.com/repos/pingcap/kvproto/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/kvproto/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/kvproto/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/kvproto/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/kvproto/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/kvproto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/kvproto/merges","archive_url":"https://api.github.com/repos/pingcap/kvproto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/kvproto/downloads","issues_url":"https://api.github.com/repos/pingcap/kvproto/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/kvproto/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/kvproto/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/kvproto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/kvproto/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/kvproto/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/kvproto/deployments","created_at":"2016-03-11T00:50:02Z","updated_at":"2016-04-02T12:21:36Z","pushed_at":"2016-04-07T04:01:14Z","git_url":"git://github.com/pingcap/kvproto.git","ssh_url":"git@github.com:pingcap/kvproto.git","clone_url":"https://github.com/pingcap/kvproto.git","svn_url":"https://github.com/pingcap/kvproto","homepage":null,"size":628,"stargazers_count":9,"watchers_count":9,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":9,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"7f5d59cf06dd5dae027ca4364132209a336fb9b4","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":53628424,"name":"kvproto","full_name":"pingcap/kvproto","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/kvproto","description":"Protocol buffer files for TiKV","fork":false,"url":"https://api.github.com/repos/pingcap/kvproto","forks_url":"https://api.github.com/repos/pingcap/kvproto/forks","keys_url":"https://api.github.com/repos/pingcap/kvproto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/kvproto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/kvproto/teams","hooks_url":"https://api.github.com/repos/pingcap/kvproto/hooks","issue_events_url":"https://api.github.com/repos/pingcap/kvproto/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/kvproto/events","assignees_url":"https://api.github.com/repos/pingcap/kvproto/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/kvproto/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/kvproto/tags","blobs_url":"https://api.github.com/repos/pingcap/kvproto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/kvproto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/kvproto/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/kvproto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/kvproto/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/kvproto/languages","stargazers_url":"https://api.github.com/repos/pingcap/kvproto/stargazers","contributors_url":"https://api.github.com/repos/pingcap/kvproto/contributors","subscribers_url":"https://api.github.com/repos/pingcap/kvproto/subscribers","subscription_url":"https://api.github.com/repos/pingcap/kvproto/subscription","commits_url":"https://api.github.com/repos/pingcap/kvproto/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/kvproto/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/kvproto/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/kvproto/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/kvproto/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/kvproto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/kvproto/merges","archive_url":"https://api.github.com/repos/pingcap/kvproto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/kvproto/downloads","issues_url":"https://api.github.com/repos/pingcap/kvproto/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/kvproto/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/kvproto/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/kvproto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/kvproto/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/kvproto/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/kvproto/deployments","created_at":"2016-03-11T00:50:02Z","updated_at":"2016-04-02T12:21:36Z","pushed_at":"2016-04-07T04:01:14Z","git_url":"git://github.com/pingcap/kvproto.git","ssh_url":"git@github.com:pingcap/kvproto.git","clone_url":"https://github.com/pingcap/kvproto.git","svn_url":"https://github.com/pingcap/kvproto","homepage":null,"size":628,"stargazers_count":9,"watchers_count":9,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/kvproto/pulls/40"},"html":{"href":"https://github.com/pingcap/kvproto/pull/40"},"issue":{"href":"https://api.github.com/repos/pingcap/kvproto/issues/40"},"comments":{"href":"https://api.github.com/repos/pingcap/kvproto/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/kvproto/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/kvproto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/kvproto/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/kvproto/statuses/51e39a6f595e731c721742ec5349c0b6b4e51106"}}}}