{"action":"created","issue":{"url":"https://api.github.com/repos/shurcooL/vfsgen/issues/25","repository_url":"https://api.github.com/repos/shurcooL/vfsgen","labels_url":"https://api.github.com/repos/shurcooL/vfsgen/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/shurcooL/vfsgen/issues/25/comments","events_url":"https://api.github.com/repos/shurcooL/vfsgen/issues/25/events","html_url":"https://github.com/shurcooL/vfsgen/pull/25","id":197301963,"number":25,"title":"WIP: Generate separate data and common files.","user":{"login":"shurcooL","id":1924134,"avatar_url":"https://avatars.githubusercontent.com/u/1924134?v=3","gravatar_id":"","url":"https://api.github.com/users/shurcooL","html_url":"https://github.com/shurcooL","followers_url":"https://api.github.com/users/shurcooL/followers","following_url":"https://api.github.com/users/shurcooL/following{/other_user}","gists_url":"https://api.github.com/users/shurcooL/gists{/gist_id}","starred_url":"https://api.github.com/users/shurcooL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shurcooL/subscriptions","organizations_url":"https://api.github.com/users/shurcooL/orgs","repos_url":"https://api.github.com/users/shurcooL/repos","events_url":"https://api.github.com/users/shurcooL/events{/privacy}","received_events_url":"https://api.github.com/users/shurcooL/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-23T02:05:35Z","updated_at":"2016-12-23T02:10:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/shurcooL/vfsgen/pulls/25","html_url":"https://github.com/shurcooL/vfsgen/pull/25","diff_url":"https://github.com/shurcooL/vfsgen/pull/25.diff","patch_url":"https://github.com/shurcooL/vfsgen/pull/25.patch"},"body":"The goal is to resolve #23, to make it possible to use vfsgen multiple\ntimes in same package.\n\nPreviously, that would cause an error because the same types would be\ndefined in each generated file.\n\nThe approach to solve that is to generate two files:\n\n-\tVFS data file\n-\tcommon type definitions file\n\nThis avoids the multiple declaration issues in an efficient way.\n\nA downside is having 2 files as generated output, instead of one."},"comment":{"url":"https://api.github.com/repos/shurcooL/vfsgen/issues/comments/268929717","html_url":"https://github.com/shurcooL/vfsgen/pull/25#issuecomment-268929717","issue_url":"https://api.github.com/repos/shurcooL/vfsgen/issues/25","id":268929717,"user":{"login":"shurcooL","id":1924134,"avatar_url":"https://avatars.githubusercontent.com/u/1924134?v=3","gravatar_id":"","url":"https://api.github.com/users/shurcooL","html_url":"https://github.com/shurcooL","followers_url":"https://api.github.com/users/shurcooL/followers","following_url":"https://api.github.com/users/shurcooL/following{/other_user}","gists_url":"https://api.github.com/users/shurcooL/gists{/gist_id}","starred_url":"https://api.github.com/users/shurcooL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shurcooL/subscriptions","organizations_url":"https://api.github.com/users/shurcooL/orgs","repos_url":"https://api.github.com/users/shurcooL/repos","events_url":"https://api.github.com/users/shurcooL/events{/privacy}","received_events_url":"https://api.github.com/users/shurcooL/received_events","type":"User","site_admin":false},"created_at":"2016-12-23T02:10:51Z","updated_at":"2016-12-23T02:10:51Z","body":"Some open questions remaining:\r\n\r\n1. Small question. What to name the generated common file. I went with \"vfsgencommon.go\", is that okay? It should always be the same name so that multiple invocations of vfsgen don't result in multiple common files (the goal is to always have just one per package).\r\n\r\n2. Big question. It currently changes the behavior to always generate 2 files. Is that the way to go? Or is it better to make the \"common\" file an optional feature that user has to opt in, otherwise use previous behavior of generating one file?\r\n\r\n    Giving user control makes for a harder to use API (they have to understand what's correctly enable the common file when needed), and complicates the implementation because there are 2 different generation paths. But if the majority of users don't need common file, it's nicer to have just 1 generated output file..."}}
{"actor":{"display_login":"shurcooL"}}