{"action":"created","comment":{"url":"https://api.github.com/repos/apache/reef/pulls/comments/51199603","id":51199603,"diff_hunk":"@@ -35,35 +35,33 @@ internal sealed class RootContextLauncher\n         \n         private readonly IInjector _rootServiceInjector = null;\n \n-        private ContextRuntime _rootContext = null;\n+        private readonly IConfiguration _rootContextConfiguration;\n \n-        private ContextConfiguration _rootContextConfiguration = null;\n+        private ContextRuntime _rootContext = null;\n \n-        public RootContextLauncher(ContextConfiguration rootContextConfig, Optional<ServiceConfiguration> rootServiceConfig, Optional<TaskConfiguration> rootTaskConfig)\n+        public RootContextLauncher(string id, IConfiguration contextConfiguration,\n+            Optional<ServiceConfiguration> rootServiceConfig, Optional<TaskConfiguration> rootTaskConfig)\n         {\n-            _rootContextConfiguration = rootContextConfig;\n+            Id = id;\n+            _rootContextConfiguration = contextConfiguration;\n             _rootServiceInjector = InjectServices(rootServiceConfig);\n             RootTaskConfig = rootTaskConfig;\n         }\n \n         public Optional<TaskConfiguration> RootTaskConfig { get; set; }\n \n-        public ContextConfiguration RootContextConfig\n-        {\n-            get { return _rootContextConfiguration; }\n-            set { _rootContextConfiguration = value; }\n-        }\n+        public string Id { get; private set; }\n \n         internal ContextRuntime GetRootContext()\n         {\n             if (_rootContext == null)\n             {\n-                _rootContext = GetRootContext(_rootServiceInjector, _rootContextConfiguration);\n+                _rootContext = new ContextRuntime(Id, _rootServiceInjector, _rootContextConfiguration);","path":"lang/cs/Org.Apache.REEF.Common/Runtime/Evaluator/Context/RootContextLauncher.cs","position":null,"original_position":35,"commit_id":"8a9a89dc5b09420185dfe8bfe5d02ae809401156","original_commit_id":"39e61d439e2d8990603add1b93d241003deee7fd","user":{"login":"afchung","id":2817619,"avatar_url":"https://avatars.githubusercontent.com/u/2817619?v=3","gravatar_id":"","url":"https://api.github.com/users/afchung","html_url":"https://github.com/afchung","followers_url":"https://api.github.com/users/afchung/followers","following_url":"https://api.github.com/users/afchung/following{/other_user}","gists_url":"https://api.github.com/users/afchung/gists{/gist_id}","starred_url":"https://api.github.com/users/afchung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afchung/subscriptions","organizations_url":"https://api.github.com/users/afchung/orgs","repos_url":"https://api.github.com/users/afchung/repos","events_url":"https://api.github.com/users/afchung/events{/privacy}","received_events_url":"https://api.github.com/users/afchung/received_events","type":"User","site_admin":false},"body":"Filed REEF-1167.","created_at":"2016-01-28T22:37:27Z","updated_at":"2016-01-28T22:37:27Z","html_url":"https://github.com/apache/reef/pull/799#discussion_r51199603","pull_request_url":"https://api.github.com/repos/apache/reef/pulls/799","_links":{"self":{"href":"https://api.github.com/repos/apache/reef/pulls/comments/51199603"},"html":{"href":"https://github.com/apache/reef/pull/799#discussion_r51199603"},"pull_request":{"href":"https://api.github.com/repos/apache/reef/pulls/799"}}},"pull_request":{"url":"https://api.github.com/repos/apache/reef/pulls/799","id":57291524,"html_url":"https://github.com/apache/reef/pull/799","diff_url":"https://github.com/apache/reef/pull/799.diff","patch_url":"https://github.com/apache/reef/pull/799.patch","issue_url":"https://api.github.com/repos/apache/reef/issues/799","number":799,"state":"open","locked":false,"title":"[REEF-1160] Deprecate O.A.R.Driver.ContextConfiguration and add O.A.R…","user":{"login":"afchung","id":2817619,"avatar_url":"https://avatars.githubusercontent.com/u/2817619?v=3","gravatar_id":"","url":"https://api.github.com/users/afchung","html_url":"https://github.com/afchung","followers_url":"https://api.github.com/users/afchung/followers","following_url":"https://api.github.com/users/afchung/following{/other_user}","gists_url":"https://api.github.com/users/afchung/gists{/gist_id}","starred_url":"https://api.github.com/users/afchung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afchung/subscriptions","organizations_url":"https://api.github.com/users/afchung/orgs","repos_url":"https://api.github.com/users/afchung/repos","events_url":"https://api.github.com/users/afchung/events{/privacy}","received_events_url":"https://api.github.com/users/afchung/received_events","type":"User","site_admin":false},"body":"….Common.Context.ContextConfiguration\r\n\r\nThis addressed the issue by\r\n  * Deprecated O.A.R.Driver.ContextConfiguration (and options) and add O.A.R.Common.Context.ContextConfiguration (and options).\r\n  * Added tests for currently the only functionality of ContextConfigurations -- allowing submission of Context IDs.\r\n  * Deprecated default context handlers and created new classes for them in O.A.R.Common.\r\n\r\nJIRA:\r\n  [REEF-1160](https://issues.apache.org/jira/browse/REEF-1160)","created_at":"2016-01-26T23:39:38Z","updated_at":"2016-01-28T22:37:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"933e064448bb1a126595247c623e7169fd801b9e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/reef/pulls/799/commits","review_comments_url":"https://api.github.com/repos/apache/reef/pulls/799/comments","review_comment_url":"https://api.github.com/repos/apache/reef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/reef/issues/799/comments","statuses_url":"https://api.github.com/repos/apache/reef/statuses/8a9a89dc5b09420185dfe8bfe5d02ae809401156","head":{"label":"afchung:REEF-1160","ref":"REEF-1160","sha":"8a9a89dc5b09420185dfe8bfe5d02ae809401156","user":{"login":"afchung","id":2817619,"avatar_url":"https://avatars.githubusercontent.com/u/2817619?v=3","gravatar_id":"","url":"https://api.github.com/users/afchung","html_url":"https://github.com/afchung","followers_url":"https://api.github.com/users/afchung/followers","following_url":"https://api.github.com/users/afchung/following{/other_user}","gists_url":"https://api.github.com/users/afchung/gists{/gist_id}","starred_url":"https://api.github.com/users/afchung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afchung/subscriptions","organizations_url":"https://api.github.com/users/afchung/orgs","repos_url":"https://api.github.com/users/afchung/repos","events_url":"https://api.github.com/users/afchung/events{/privacy}","received_events_url":"https://api.github.com/users/afchung/received_events","type":"User","site_admin":false},"repo":{"id":31485914,"name":"reef","full_name":"afchung/reef","owner":{"login":"afchung","id":2817619,"avatar_url":"https://avatars.githubusercontent.com/u/2817619?v=3","gravatar_id":"","url":"https://api.github.com/users/afchung","html_url":"https://github.com/afchung","followers_url":"https://api.github.com/users/afchung/followers","following_url":"https://api.github.com/users/afchung/following{/other_user}","gists_url":"https://api.github.com/users/afchung/gists{/gist_id}","starred_url":"https://api.github.com/users/afchung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afchung/subscriptions","organizations_url":"https://api.github.com/users/afchung/orgs","repos_url":"https://api.github.com/users/afchung/repos","events_url":"https://api.github.com/users/afchung/events{/privacy}","received_events_url":"https://api.github.com/users/afchung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/afchung/reef","description":"Mirror of Apache REEF","fork":true,"url":"https://api.github.com/repos/afchung/reef","forks_url":"https://api.github.com/repos/afchung/reef/forks","keys_url":"https://api.github.com/repos/afchung/reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/afchung/reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/afchung/reef/teams","hooks_url":"https://api.github.com/repos/afchung/reef/hooks","issue_events_url":"https://api.github.com/repos/afchung/reef/issues/events{/number}","events_url":"https://api.github.com/repos/afchung/reef/events","assignees_url":"https://api.github.com/repos/afchung/reef/assignees{/user}","branches_url":"https://api.github.com/repos/afchung/reef/branches{/branch}","tags_url":"https://api.github.com/repos/afchung/reef/tags","blobs_url":"https://api.github.com/repos/afchung/reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/afchung/reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/afchung/reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/afchung/reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/afchung/reef/statuses/{sha}","languages_url":"https://api.github.com/repos/afchung/reef/languages","stargazers_url":"https://api.github.com/repos/afchung/reef/stargazers","contributors_url":"https://api.github.com/repos/afchung/reef/contributors","subscribers_url":"https://api.github.com/repos/afchung/reef/subscribers","subscription_url":"https://api.github.com/repos/afchung/reef/subscription","commits_url":"https://api.github.com/repos/afchung/reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/afchung/reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/afchung/reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/afchung/reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/afchung/reef/contents/{+path}","compare_url":"https://api.github.com/repos/afchung/reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/afchung/reef/merges","archive_url":"https://api.github.com/repos/afchung/reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/afchung/reef/downloads","issues_url":"https://api.github.com/repos/afchung/reef/issues{/number}","pulls_url":"https://api.github.com/repos/afchung/reef/pulls{/number}","milestones_url":"https://api.github.com/repos/afchung/reef/milestones{/number}","notifications_url":"https://api.github.com/repos/afchung/reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/afchung/reef/labels{/name}","releases_url":"https://api.github.com/repos/afchung/reef/releases{/id}","deployments_url":"https://api.github.com/repos/afchung/reef/deployments","created_at":"2015-03-01T03:44:31Z","updated_at":"2016-01-13T15:51:07Z","pushed_at":"2016-01-28T22:36:27Z","git_url":"git://github.com/afchung/reef.git","ssh_url":"git@github.com:afchung/reef.git","clone_url":"https://github.com/afchung/reef.git","svn_url":"https://github.com/afchung/reef","homepage":"","size":34146,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"58a86f9b1e7c58b71ee693b2267abcd32f10973b","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":25623941,"name":"reef","full_name":"apache/reef","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/reef","description":"Mirror of Apache REEF","fork":false,"url":"https://api.github.com/repos/apache/reef","forks_url":"https://api.github.com/repos/apache/reef/forks","keys_url":"https://api.github.com/repos/apache/reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/reef/teams","hooks_url":"https://api.github.com/repos/apache/reef/hooks","issue_events_url":"https://api.github.com/repos/apache/reef/issues/events{/number}","events_url":"https://api.github.com/repos/apache/reef/events","assignees_url":"https://api.github.com/repos/apache/reef/assignees{/user}","branches_url":"https://api.github.com/repos/apache/reef/branches{/branch}","tags_url":"https://api.github.com/repos/apache/reef/tags","blobs_url":"https://api.github.com/repos/apache/reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/reef/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/reef/languages","stargazers_url":"https://api.github.com/repos/apache/reef/stargazers","contributors_url":"https://api.github.com/repos/apache/reef/contributors","subscribers_url":"https://api.github.com/repos/apache/reef/subscribers","subscription_url":"https://api.github.com/repos/apache/reef/subscription","commits_url":"https://api.github.com/repos/apache/reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/reef/contents/{+path}","compare_url":"https://api.github.com/repos/apache/reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/reef/merges","archive_url":"https://api.github.com/repos/apache/reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/reef/downloads","issues_url":"https://api.github.com/repos/apache/reef/issues{/number}","pulls_url":"https://api.github.com/repos/apache/reef/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/reef/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/reef/labels{/name}","releases_url":"https://api.github.com/repos/apache/reef/releases{/id}","deployments_url":"https://api.github.com/repos/apache/reef/deployments","created_at":"2014-10-23T07:00:10Z","updated_at":"2016-01-26T06:56:14Z","pushed_at":"2016-01-28T22:36:28Z","git_url":"git://github.com/apache/reef.git","ssh_url":"git@github.com:apache/reef.git","clone_url":"https://github.com/apache/reef.git","svn_url":"https://github.com/apache/reef","homepage":"","size":46413,"stargazers_count":40,"watchers_count":40,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":45,"mirror_url":"git://git.apache.org/reef.git","open_issues_count":5,"forks":45,"open_issues":5,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/reef/pulls/799"},"html":{"href":"https://github.com/apache/reef/pull/799"},"issue":{"href":"https://api.github.com/repos/apache/reef/issues/799"},"comments":{"href":"https://api.github.com/repos/apache/reef/issues/799/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/reef/pulls/799/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/reef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/reef/pulls/799/commits"},"statuses":{"href":"https://api.github.com/repos/apache/reef/statuses/8a9a89dc5b09420185dfe8bfe5d02ae809401156"}}}}