{"action":"created","comment":{"url":"https://api.github.com/repos/flycheck/flycheck/pulls/comments/86512437","pull_request_review_id":7167384,"id":86512437,"diff_hunk":"@@ -8711,6 +8715,25 @@ rustc command.  See URL `https://www.rust-lang.org'.\"\n                (and (flycheck-buffer-saved-p)\n                     (locate-dominating-file (buffer-file-name) \"Cargo.toml\"))))\n \n+(flycheck-define-checker rust-cargo-clippy\n+  \"A Rust syntax checker and linter using clippy.\n+\n+This syntax checker needs the cargo clippy subcommand. See URL `https://github.com/Manishearth/rust-clippy'\"\n+  :command (\"cargo\" \"clippy\"\n+            (eval flycheck-cargo-clippy-args)\n+            \"--\"  \"--error-format=json\"\n+            (option-list \"-L\" flycheck-rust-library-path concat)\n+            (eval flycheck-rust-args))\n+  :error-parser flycheck-parse-rust\n+  :error-explainer flycheck-rust-error-explainer\n+  :modes rust-mode\n+  :predicate (lambda ()\n+               ;; Since we build the entire project with cargo clippy we require\n+               ;; that the buffer is saved.  And of course, we also need a Cargo\n+               ;; file :)\n+               (and (flycheck-buffer-saved-p)\n+                    (locate-dominating-file (buffer-file-name) \"Cargo.toml\"))))","path":"flycheck.el","position":53,"original_position":53,"commit_id":"ea7e09a5058509d8d281931c94864acf476a5388","original_commit_id":"ea7e09a5058509d8d281931c94864acf476a5388","user":{"login":"lunaryorn","id":224922,"avatar_url":"https://avatars.githubusercontent.com/u/224922?v=3","gravatar_id":"","url":"https://api.github.com/users/lunaryorn","html_url":"https://github.com/lunaryorn","followers_url":"https://api.github.com/users/lunaryorn/followers","following_url":"https://api.github.com/users/lunaryorn/following{/other_user}","gists_url":"https://api.github.com/users/lunaryorn/gists{/gist_id}","starred_url":"https://api.github.com/users/lunaryorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunaryorn/subscriptions","organizations_url":"https://api.github.com/users/lunaryorn/orgs","repos_url":"https://api.github.com/users/lunaryorn/repos","events_url":"https://api.github.com/users/lunaryorn/events{/privacy}","received_events_url":"https://api.github.com/users/lunaryorn/received_events","type":"User","site_admin":false},"body":"Please move the check for `Cargo.toml` into an `:enabled` function (see `javascript-eslint` for an example of the `:enabled` field), so that we only check for the file once when the checker is used first and not every single time.\r\n\r\nI presume the `clippy` command is not built-in to `cargo`?  If so `:enabled` also needs to check whether the subcommand is present.","created_at":"2016-11-04T09:40:57Z","updated_at":"2016-11-04T09:45:43Z","html_url":"https://github.com/flycheck/flycheck/pull/1156#discussion_r86512437","pull_request_url":"https://api.github.com/repos/flycheck/flycheck/pulls/1156","_links":{"self":{"href":"https://api.github.com/repos/flycheck/flycheck/pulls/comments/86512437"},"html":{"href":"https://github.com/flycheck/flycheck/pull/1156#discussion_r86512437"},"pull_request":{"href":"https://api.github.com/repos/flycheck/flycheck/pulls/1156"}}},"pull_request":{"url":"https://api.github.com/repos/flycheck/flycheck/pulls/1156","id":92262766,"html_url":"https://github.com/flycheck/flycheck/pull/1156","diff_url":"https://github.com/flycheck/flycheck/pull/1156.diff","patch_url":"https://github.com/flycheck/flycheck/pull/1156.patch","issue_url":"https://api.github.com/repos/flycheck/flycheck/issues/1156","number":1156,"state":"open","locked":false,"title":"Add the rust-cargo-clippy checker","user":{"login":"dzamlo","id":2960379,"avatar_url":"https://avatars.githubusercontent.com/u/2960379?v=3","gravatar_id":"","url":"https://api.github.com/users/dzamlo","html_url":"https://github.com/dzamlo","followers_url":"https://api.github.com/users/dzamlo/followers","following_url":"https://api.github.com/users/dzamlo/following{/other_user}","gists_url":"https://api.github.com/users/dzamlo/gists{/gist_id}","starred_url":"https://api.github.com/users/dzamlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzamlo/subscriptions","organizations_url":"https://api.github.com/users/dzamlo/orgs","repos_url":"https://api.github.com/users/dzamlo/repos","events_url":"https://api.github.com/users/dzamlo/events{/privacy}","received_events_url":"https://api.github.com/users/dzamlo/received_events","type":"User","site_admin":false},"body":"Fixes GH-1154","created_at":"2016-11-03T23:57:45Z","updated_at":"2016-11-04T09:45:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d35d0f07952deaf8694a0161061e281807ac05ef","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/flycheck/flycheck/pulls/1156/commits","review_comments_url":"https://api.github.com/repos/flycheck/flycheck/pulls/1156/comments","review_comment_url":"https://api.github.com/repos/flycheck/flycheck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flycheck/flycheck/issues/1156/comments","statuses_url":"https://api.github.com/repos/flycheck/flycheck/statuses/ea7e09a5058509d8d281931c94864acf476a5388","head":{"label":"dzamlo:master","ref":"master","sha":"ea7e09a5058509d8d281931c94864acf476a5388","user":{"login":"dzamlo","id":2960379,"avatar_url":"https://avatars.githubusercontent.com/u/2960379?v=3","gravatar_id":"","url":"https://api.github.com/users/dzamlo","html_url":"https://github.com/dzamlo","followers_url":"https://api.github.com/users/dzamlo/followers","following_url":"https://api.github.com/users/dzamlo/following{/other_user}","gists_url":"https://api.github.com/users/dzamlo/gists{/gist_id}","starred_url":"https://api.github.com/users/dzamlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzamlo/subscriptions","organizations_url":"https://api.github.com/users/dzamlo/orgs","repos_url":"https://api.github.com/users/dzamlo/repos","events_url":"https://api.github.com/users/dzamlo/events{/privacy}","received_events_url":"https://api.github.com/users/dzamlo/received_events","type":"User","site_admin":false},"repo":{"id":72686040,"name":"flycheck","full_name":"dzamlo/flycheck","owner":{"login":"dzamlo","id":2960379,"avatar_url":"https://avatars.githubusercontent.com/u/2960379?v=3","gravatar_id":"","url":"https://api.github.com/users/dzamlo","html_url":"https://github.com/dzamlo","followers_url":"https://api.github.com/users/dzamlo/followers","following_url":"https://api.github.com/users/dzamlo/following{/other_user}","gists_url":"https://api.github.com/users/dzamlo/gists{/gist_id}","starred_url":"https://api.github.com/users/dzamlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzamlo/subscriptions","organizations_url":"https://api.github.com/users/dzamlo/orgs","repos_url":"https://api.github.com/users/dzamlo/repos","events_url":"https://api.github.com/users/dzamlo/events{/privacy}","received_events_url":"https://api.github.com/users/dzamlo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dzamlo/flycheck","description":"On the fly syntax checking for GNU Emacs","fork":true,"url":"https://api.github.com/repos/dzamlo/flycheck","forks_url":"https://api.github.com/repos/dzamlo/flycheck/forks","keys_url":"https://api.github.com/repos/dzamlo/flycheck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dzamlo/flycheck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dzamlo/flycheck/teams","hooks_url":"https://api.github.com/repos/dzamlo/flycheck/hooks","issue_events_url":"https://api.github.com/repos/dzamlo/flycheck/issues/events{/number}","events_url":"https://api.github.com/repos/dzamlo/flycheck/events","assignees_url":"https://api.github.com/repos/dzamlo/flycheck/assignees{/user}","branches_url":"https://api.github.com/repos/dzamlo/flycheck/branches{/branch}","tags_url":"https://api.github.com/repos/dzamlo/flycheck/tags","blobs_url":"https://api.github.com/repos/dzamlo/flycheck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dzamlo/flycheck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dzamlo/flycheck/git/refs{/sha}","trees_url":"https://api.github.com/repos/dzamlo/flycheck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dzamlo/flycheck/statuses/{sha}","languages_url":"https://api.github.com/repos/dzamlo/flycheck/languages","stargazers_url":"https://api.github.com/repos/dzamlo/flycheck/stargazers","contributors_url":"https://api.github.com/repos/dzamlo/flycheck/contributors","subscribers_url":"https://api.github.com/repos/dzamlo/flycheck/subscribers","subscription_url":"https://api.github.com/repos/dzamlo/flycheck/subscription","commits_url":"https://api.github.com/repos/dzamlo/flycheck/commits{/sha}","git_commits_url":"https://api.github.com/repos/dzamlo/flycheck/git/commits{/sha}","comments_url":"https://api.github.com/repos/dzamlo/flycheck/comments{/number}","issue_comment_url":"https://api.github.com/repos/dzamlo/flycheck/issues/comments{/number}","contents_url":"https://api.github.com/repos/dzamlo/flycheck/contents/{+path}","compare_url":"https://api.github.com/repos/dzamlo/flycheck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dzamlo/flycheck/merges","archive_url":"https://api.github.com/repos/dzamlo/flycheck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dzamlo/flycheck/downloads","issues_url":"https://api.github.com/repos/dzamlo/flycheck/issues{/number}","pulls_url":"https://api.github.com/repos/dzamlo/flycheck/pulls{/number}","milestones_url":"https://api.github.com/repos/dzamlo/flycheck/milestones{/number}","notifications_url":"https://api.github.com/repos/dzamlo/flycheck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dzamlo/flycheck/labels{/name}","releases_url":"https://api.github.com/repos/dzamlo/flycheck/releases{/id}","deployments_url":"https://api.github.com/repos/dzamlo/flycheck/deployments","created_at":"2016-11-02T22:15:50Z","updated_at":"2016-11-02T22:15:52Z","pushed_at":"2016-11-03T23:56:49Z","git_url":"git://github.com/dzamlo/flycheck.git","ssh_url":"git@github.com:dzamlo/flycheck.git","clone_url":"https://github.com/dzamlo/flycheck.git","svn_url":"https://github.com/dzamlo/flycheck","homepage":"http://www.flycheck.org","size":16182,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flycheck:master","ref":"master","sha":"f8c20f4f986ba79f1e6960d3bc59498e6fb5eff3","user":{"login":"flycheck","id":5254142,"avatar_url":"https://avatars.githubusercontent.com/u/5254142?v=3","gravatar_id":"","url":"https://api.github.com/users/flycheck","html_url":"https://github.com/flycheck","followers_url":"https://api.github.com/users/flycheck/followers","following_url":"https://api.github.com/users/flycheck/following{/other_user}","gists_url":"https://api.github.com/users/flycheck/gists{/gist_id}","starred_url":"https://api.github.com/users/flycheck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flycheck/subscriptions","organizations_url":"https://api.github.com/users/flycheck/orgs","repos_url":"https://api.github.com/users/flycheck/repos","events_url":"https://api.github.com/users/flycheck/events{/privacy}","received_events_url":"https://api.github.com/users/flycheck/received_events","type":"Organization","site_admin":false},"repo":{"id":6158882,"name":"flycheck","full_name":"flycheck/flycheck","owner":{"login":"flycheck","id":5254142,"avatar_url":"https://avatars.githubusercontent.com/u/5254142?v=3","gravatar_id":"","url":"https://api.github.com/users/flycheck","html_url":"https://github.com/flycheck","followers_url":"https://api.github.com/users/flycheck/followers","following_url":"https://api.github.com/users/flycheck/following{/other_user}","gists_url":"https://api.github.com/users/flycheck/gists{/gist_id}","starred_url":"https://api.github.com/users/flycheck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flycheck/subscriptions","organizations_url":"https://api.github.com/users/flycheck/orgs","repos_url":"https://api.github.com/users/flycheck/repos","events_url":"https://api.github.com/users/flycheck/events{/privacy}","received_events_url":"https://api.github.com/users/flycheck/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flycheck/flycheck","description":"On the fly syntax checking for GNU Emacs","fork":false,"url":"https://api.github.com/repos/flycheck/flycheck","forks_url":"https://api.github.com/repos/flycheck/flycheck/forks","keys_url":"https://api.github.com/repos/flycheck/flycheck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flycheck/flycheck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flycheck/flycheck/teams","hooks_url":"https://api.github.com/repos/flycheck/flycheck/hooks","issue_events_url":"https://api.github.com/repos/flycheck/flycheck/issues/events{/number}","events_url":"https://api.github.com/repos/flycheck/flycheck/events","assignees_url":"https://api.github.com/repos/flycheck/flycheck/assignees{/user}","branches_url":"https://api.github.com/repos/flycheck/flycheck/branches{/branch}","tags_url":"https://api.github.com/repos/flycheck/flycheck/tags","blobs_url":"https://api.github.com/repos/flycheck/flycheck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flycheck/flycheck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flycheck/flycheck/git/refs{/sha}","trees_url":"https://api.github.com/repos/flycheck/flycheck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flycheck/flycheck/statuses/{sha}","languages_url":"https://api.github.com/repos/flycheck/flycheck/languages","stargazers_url":"https://api.github.com/repos/flycheck/flycheck/stargazers","contributors_url":"https://api.github.com/repos/flycheck/flycheck/contributors","subscribers_url":"https://api.github.com/repos/flycheck/flycheck/subscribers","subscription_url":"https://api.github.com/repos/flycheck/flycheck/subscription","commits_url":"https://api.github.com/repos/flycheck/flycheck/commits{/sha}","git_commits_url":"https://api.github.com/repos/flycheck/flycheck/git/commits{/sha}","comments_url":"https://api.github.com/repos/flycheck/flycheck/comments{/number}","issue_comment_url":"https://api.github.com/repos/flycheck/flycheck/issues/comments{/number}","contents_url":"https://api.github.com/repos/flycheck/flycheck/contents/{+path}","compare_url":"https://api.github.com/repos/flycheck/flycheck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flycheck/flycheck/merges","archive_url":"https://api.github.com/repos/flycheck/flycheck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flycheck/flycheck/downloads","issues_url":"https://api.github.com/repos/flycheck/flycheck/issues{/number}","pulls_url":"https://api.github.com/repos/flycheck/flycheck/pulls{/number}","milestones_url":"https://api.github.com/repos/flycheck/flycheck/milestones{/number}","notifications_url":"https://api.github.com/repos/flycheck/flycheck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flycheck/flycheck/labels{/name}","releases_url":"https://api.github.com/repos/flycheck/flycheck/releases{/id}","deployments_url":"https://api.github.com/repos/flycheck/flycheck/deployments","created_at":"2012-10-10T14:45:13Z","updated_at":"2016-11-04T09:32:18Z","pushed_at":"2016-11-03T23:57:45Z","git_url":"git://github.com/flycheck/flycheck.git","ssh_url":"git@github.com:flycheck/flycheck.git","clone_url":"https://github.com/flycheck/flycheck.git","svn_url":"https://github.com/flycheck/flycheck","homepage":"http://www.flycheck.org","size":19839,"stargazers_count":1165,"watchers_count":1165,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":226,"mirror_url":null,"open_issues_count":60,"forks":226,"open_issues":60,"watchers":1165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flycheck/flycheck/pulls/1156"},"html":{"href":"https://github.com/flycheck/flycheck/pull/1156"},"issue":{"href":"https://api.github.com/repos/flycheck/flycheck/issues/1156"},"comments":{"href":"https://api.github.com/repos/flycheck/flycheck/issues/1156/comments"},"review_comments":{"href":"https://api.github.com/repos/flycheck/flycheck/pulls/1156/comments"},"review_comment":{"href":"https://api.github.com/repos/flycheck/flycheck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flycheck/flycheck/pulls/1156/commits"},"statuses":{"href":"https://api.github.com/repos/flycheck/flycheck/statuses/ea7e09a5058509d8d281931c94864acf476a5388"}}}}
{"actor":{"display_login":"lunaryorn"}}