{"action":"closed","number":4202,"pull_request":{"url":"https://api.github.com/repos/bundler/bundler/pulls/4202","id":55301899,"html_url":"https://github.com/bundler/bundler/pull/4202","diff_url":"https://github.com/bundler/bundler/pull/4202.diff","patch_url":"https://github.com/bundler/bundler/pull/4202.patch","issue_url":"https://api.github.com/repos/bundler/bundler/issues/4202","number":4202,"state":"closed","locked":false,"title":"Start adding unit tests for SharedHelpers","user":{"login":"RochesterinNYC","id":1504464,"avatar_url":"https://avatars.githubusercontent.com/u/1504464?v=3","gravatar_id":"","url":"https://api.github.com/users/RochesterinNYC","html_url":"https://github.com/RochesterinNYC","followers_url":"https://api.github.com/users/RochesterinNYC/followers","following_url":"https://api.github.com/users/RochesterinNYC/following{/other_user}","gists_url":"https://api.github.com/users/RochesterinNYC/gists{/gist_id}","starred_url":"https://api.github.com/users/RochesterinNYC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RochesterinNYC/subscriptions","organizations_url":"https://api.github.com/users/RochesterinNYC/orgs","repos_url":"https://api.github.com/users/RochesterinNYC/repos","events_url":"https://api.github.com/users/RochesterinNYC/events{/privacy}","received_events_url":"https://api.github.com/users/RochesterinNYC/received_events","type":"User","site_admin":false},"body":"Backfilling some unit tests for the `Bundler::SharedHelpers` module. This PR doesn't add all the unit tests yet as I'd like some feedback on whether I'm on the right track regarding the level of mocking out and the interaction of some of the testee methods with private methods.\r\n\r\nRelated to discussion at #4195 regarding unit tests.","created_at":"2016-01-07T05:40:55Z","updated_at":"2016-01-08T14:29:50Z","closed_at":"2016-01-08T14:29:50Z","merged_at":"2016-01-08T14:29:50Z","merge_commit_sha":"91c6f372b541f2d3e95231791388fc33d2d07a4a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bundler/bundler/pulls/4202/commits","review_comments_url":"https://api.github.com/repos/bundler/bundler/pulls/4202/comments","review_comment_url":"https://api.github.com/repos/bundler/bundler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bundler/bundler/issues/4202/comments","statuses_url":"https://api.github.com/repos/bundler/bundler/statuses/db934707af011515f4c775cd7e372dffa86f8b7f","head":{"label":"RochesterinNYC:add-unit-tests-for-shared-helpers","ref":"add-unit-tests-for-shared-helpers","sha":"db934707af011515f4c775cd7e372dffa86f8b7f","user":{"login":"RochesterinNYC","id":1504464,"avatar_url":"https://avatars.githubusercontent.com/u/1504464?v=3","gravatar_id":"","url":"https://api.github.com/users/RochesterinNYC","html_url":"https://github.com/RochesterinNYC","followers_url":"https://api.github.com/users/RochesterinNYC/followers","following_url":"https://api.github.com/users/RochesterinNYC/following{/other_user}","gists_url":"https://api.github.com/users/RochesterinNYC/gists{/gist_id}","starred_url":"https://api.github.com/users/RochesterinNYC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RochesterinNYC/subscriptions","organizations_url":"https://api.github.com/users/RochesterinNYC/orgs","repos_url":"https://api.github.com/users/RochesterinNYC/repos","events_url":"https://api.github.com/users/RochesterinNYC/events{/privacy}","received_events_url":"https://api.github.com/users/RochesterinNYC/received_events","type":"User","site_admin":false},"repo":{"id":43209520,"name":"bundler","full_name":"RochesterinNYC/bundler","owner":{"login":"RochesterinNYC","id":1504464,"avatar_url":"https://avatars.githubusercontent.com/u/1504464?v=3","gravatar_id":"","url":"https://api.github.com/users/RochesterinNYC","html_url":"https://github.com/RochesterinNYC","followers_url":"https://api.github.com/users/RochesterinNYC/followers","following_url":"https://api.github.com/users/RochesterinNYC/following{/other_user}","gists_url":"https://api.github.com/users/RochesterinNYC/gists{/gist_id}","starred_url":"https://api.github.com/users/RochesterinNYC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RochesterinNYC/subscriptions","organizations_url":"https://api.github.com/users/RochesterinNYC/orgs","repos_url":"https://api.github.com/users/RochesterinNYC/repos","events_url":"https://api.github.com/users/RochesterinNYC/events{/privacy}","received_events_url":"https://api.github.com/users/RochesterinNYC/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RochesterinNYC/bundler","description":"Manage your application's gem dependencies with less pain","fork":true,"url":"https://api.github.com/repos/RochesterinNYC/bundler","forks_url":"https://api.github.com/repos/RochesterinNYC/bundler/forks","keys_url":"https://api.github.com/repos/RochesterinNYC/bundler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RochesterinNYC/bundler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RochesterinNYC/bundler/teams","hooks_url":"https://api.github.com/repos/RochesterinNYC/bundler/hooks","issue_events_url":"https://api.github.com/repos/RochesterinNYC/bundler/issues/events{/number}","events_url":"https://api.github.com/repos/RochesterinNYC/bundler/events","assignees_url":"https://api.github.com/repos/RochesterinNYC/bundler/assignees{/user}","branches_url":"https://api.github.com/repos/RochesterinNYC/bundler/branches{/branch}","tags_url":"https://api.github.com/repos/RochesterinNYC/bundler/tags","blobs_url":"https://api.github.com/repos/RochesterinNYC/bundler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RochesterinNYC/bundler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RochesterinNYC/bundler/git/refs{/sha}","trees_url":"https://api.github.com/repos/RochesterinNYC/bundler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RochesterinNYC/bundler/statuses/{sha}","languages_url":"https://api.github.com/repos/RochesterinNYC/bundler/languages","stargazers_url":"https://api.github.com/repos/RochesterinNYC/bundler/stargazers","contributors_url":"https://api.github.com/repos/RochesterinNYC/bundler/contributors","subscribers_url":"https://api.github.com/repos/RochesterinNYC/bundler/subscribers","subscription_url":"https://api.github.com/repos/RochesterinNYC/bundler/subscription","commits_url":"https://api.github.com/repos/RochesterinNYC/bundler/commits{/sha}","git_commits_url":"https://api.github.com/repos/RochesterinNYC/bundler/git/commits{/sha}","comments_url":"https://api.github.com/repos/RochesterinNYC/bundler/comments{/number}","issue_comment_url":"https://api.github.com/repos/RochesterinNYC/bundler/issues/comments{/number}","contents_url":"https://api.github.com/repos/RochesterinNYC/bundler/contents/{+path}","compare_url":"https://api.github.com/repos/RochesterinNYC/bundler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RochesterinNYC/bundler/merges","archive_url":"https://api.github.com/repos/RochesterinNYC/bundler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RochesterinNYC/bundler/downloads","issues_url":"https://api.github.com/repos/RochesterinNYC/bundler/issues{/number}","pulls_url":"https://api.github.com/repos/RochesterinNYC/bundler/pulls{/number}","milestones_url":"https://api.github.com/repos/RochesterinNYC/bundler/milestones{/number}","notifications_url":"https://api.github.com/repos/RochesterinNYC/bundler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RochesterinNYC/bundler/labels{/name}","releases_url":"https://api.github.com/repos/RochesterinNYC/bundler/releases{/id}","created_at":"2015-09-26T14:59:07Z","updated_at":"2015-09-26T14:59:11Z","pushed_at":"2016-01-08T06:09:17Z","git_url":"git://github.com/RochesterinNYC/bundler.git","ssh_url":"git@github.com:RochesterinNYC/bundler.git","clone_url":"https://github.com/RochesterinNYC/bundler.git","svn_url":"https://github.com/RochesterinNYC/bundler","homepage":"http://bundler.io","size":18803,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bundler:master","ref":"master","sha":"873c59226087df8fb251e9cf6d41e59500cd83d4","user":{"login":"bundler","id":1137638,"avatar_url":"https://avatars.githubusercontent.com/u/1137638?v=3","gravatar_id":"","url":"https://api.github.com/users/bundler","html_url":"https://github.com/bundler","followers_url":"https://api.github.com/users/bundler/followers","following_url":"https://api.github.com/users/bundler/following{/other_user}","gists_url":"https://api.github.com/users/bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bundler/subscriptions","organizations_url":"https://api.github.com/users/bundler/orgs","repos_url":"https://api.github.com/users/bundler/repos","events_url":"https://api.github.com/users/bundler/events{/privacy}","received_events_url":"https://api.github.com/users/bundler/received_events","type":"Organization","site_admin":false},"repo":{"id":488514,"name":"bundler","full_name":"bundler/bundler","owner":{"login":"bundler","id":1137638,"avatar_url":"https://avatars.githubusercontent.com/u/1137638?v=3","gravatar_id":"","url":"https://api.github.com/users/bundler","html_url":"https://github.com/bundler","followers_url":"https://api.github.com/users/bundler/followers","following_url":"https://api.github.com/users/bundler/following{/other_user}","gists_url":"https://api.github.com/users/bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bundler/subscriptions","organizations_url":"https://api.github.com/users/bundler/orgs","repos_url":"https://api.github.com/users/bundler/repos","events_url":"https://api.github.com/users/bundler/events{/privacy}","received_events_url":"https://api.github.com/users/bundler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bundler/bundler","description":"Manage your application's gem dependencies with less pain","fork":false,"url":"https://api.github.com/repos/bundler/bundler","forks_url":"https://api.github.com/repos/bundler/bundler/forks","keys_url":"https://api.github.com/repos/bundler/bundler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bundler/bundler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bundler/bundler/teams","hooks_url":"https://api.github.com/repos/bundler/bundler/hooks","issue_events_url":"https://api.github.com/repos/bundler/bundler/issues/events{/number}","events_url":"https://api.github.com/repos/bundler/bundler/events","assignees_url":"https://api.github.com/repos/bundler/bundler/assignees{/user}","branches_url":"https://api.github.com/repos/bundler/bundler/branches{/branch}","tags_url":"https://api.github.com/repos/bundler/bundler/tags","blobs_url":"https://api.github.com/repos/bundler/bundler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bundler/bundler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bundler/bundler/git/refs{/sha}","trees_url":"https://api.github.com/repos/bundler/bundler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bundler/bundler/statuses/{sha}","languages_url":"https://api.github.com/repos/bundler/bundler/languages","stargazers_url":"https://api.github.com/repos/bundler/bundler/stargazers","contributors_url":"https://api.github.com/repos/bundler/bundler/contributors","subscribers_url":"https://api.github.com/repos/bundler/bundler/subscribers","subscription_url":"https://api.github.com/repos/bundler/bundler/subscription","commits_url":"https://api.github.com/repos/bundler/bundler/commits{/sha}","git_commits_url":"https://api.github.com/repos/bundler/bundler/git/commits{/sha}","comments_url":"https://api.github.com/repos/bundler/bundler/comments{/number}","issue_comment_url":"https://api.github.com/repos/bundler/bundler/issues/comments{/number}","contents_url":"https://api.github.com/repos/bundler/bundler/contents/{+path}","compare_url":"https://api.github.com/repos/bundler/bundler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bundler/bundler/merges","archive_url":"https://api.github.com/repos/bundler/bundler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bundler/bundler/downloads","issues_url":"https://api.github.com/repos/bundler/bundler/issues{/number}","pulls_url":"https://api.github.com/repos/bundler/bundler/pulls{/number}","milestones_url":"https://api.github.com/repos/bundler/bundler/milestones{/number}","notifications_url":"https://api.github.com/repos/bundler/bundler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bundler/bundler/labels{/name}","releases_url":"https://api.github.com/repos/bundler/bundler/releases{/id}","created_at":"2010-01-26T00:46:38Z","updated_at":"2016-01-08T14:11:44Z","pushed_at":"2016-01-08T14:29:47Z","git_url":"git://github.com/bundler/bundler.git","ssh_url":"git@github.com:bundler/bundler.git","clone_url":"https://github.com/bundler/bundler.git","svn_url":"https://github.com/bundler/bundler","homepage":"http://bundler.io","size":24713,"stargazers_count":3185,"watchers_count":3185,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1452,"mirror_url":null,"open_issues_count":72,"forks":1452,"open_issues":72,"watchers":3185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bundler/bundler/pulls/4202"},"html":{"href":"https://github.com/bundler/bundler/pull/4202"},"issue":{"href":"https://api.github.com/repos/bundler/bundler/issues/4202"},"comments":{"href":"https://api.github.com/repos/bundler/bundler/issues/4202/comments"},"review_comments":{"href":"https://api.github.com/repos/bundler/bundler/pulls/4202/comments"},"review_comment":{"href":"https://api.github.com/repos/bundler/bundler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bundler/bundler/pulls/4202/commits"},"statuses":{"href":"https://api.github.com/repos/bundler/bundler/statuses/db934707af011515f4c775cd7e372dffa86f8b7f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"homu","id":10212162,"avatar_url":"https://avatars.githubusercontent.com/u/10212162?v=3","gravatar_id":"","url":"https://api.github.com/users/homu","html_url":"https://github.com/homu","followers_url":"https://api.github.com/users/homu/followers","following_url":"https://api.github.com/users/homu/following{/other_user}","gists_url":"https://api.github.com/users/homu/gists{/gist_id}","starred_url":"https://api.github.com/users/homu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homu/subscriptions","organizations_url":"https://api.github.com/users/homu/orgs","repos_url":"https://api.github.com/users/homu/repos","events_url":"https://api.github.com/users/homu/events{/privacy}","received_events_url":"https://api.github.com/users/homu/received_events","type":"User","site_admin":false},"comments":23,"review_comments":2,"commits":5,"additions":76,"deletions":10,"changed_files":1}}