{"action":"created","issue":{"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/311","repository_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui","labels_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/311/labels{/name}","comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/311/comments","events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/311/events","html_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/311","id":172664240,"number":311,"title":"Ticket 1492: Fix missing icons ","user":{"login":"DominicOram","id":10086797,"avatar_url":"https://avatars.githubusercontent.com/u/10086797?v=3","gravatar_id":"","url":"https://api.github.com/users/DominicOram","html_url":"https://github.com/DominicOram","followers_url":"https://api.github.com/users/DominicOram/followers","following_url":"https://api.github.com/users/DominicOram/following{/other_user}","gists_url":"https://api.github.com/users/DominicOram/gists{/gist_id}","starred_url":"https://api.github.com/users/DominicOram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominicOram/subscriptions","organizations_url":"https://api.github.com/users/DominicOram/orgs","repos_url":"https://api.github.com/users/DominicOram/repos","events_url":"https://api.github.com/users/DominicOram/events{/privacy}","received_events_url":"https://api.github.com/users/DominicOram/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-23T10:28:04Z","updated_at":"2016-08-25T16:16:07Z","closed_at":"2016-08-25T08:58:20Z","pull_request":{"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/311","html_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/311","diff_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/311.diff","patch_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/311.patch"},"body":"### Description of work\r\n\r\nFixes https://github.com/ISISComputingGroup/IBEX/issues/1492\r\nAlso adds a check build script that should prevent the same error from happening again\r\n\r\n### To test\r\n\r\nRun build.bat\r\nConfirm that arrow icons appear in synoptic editor and in groups panel of config editor (see original ticket) of the new build\r\n\r\nRemove the /icons/ path from a build.properties\r\nRun build.bat\r\nConfirm the build doesn't work with a sensible error\r\n\r\n### Acceptance criteria\r\n\r\nOriginal issue is fixed and new script works as expected\r\n\r\n---\r\n\r\n#### Code Review\r\n\r\n- [x] Is the code of an acceptable quality?\r\n- [x] Does the code conform to the [coding standards](https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/GUI-Coding-Conventions)? Is it well structured with small focussed classes/methods/functions?\r\n- Are there unit tests in place? Are the unit tests small and test the a class in isolation?\r\n- Are there [system tests](https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/System-Testing-with-RCPTT) in place? Do they test a minimal set of functionality and leave the gui as close as possible to its original state?\r\n- [ ] Have the changes been documented in the [release notes](https://github.com/ISISComputingGroup/IBEX/wiki/ReleaseNotes_Dev). If so, do they describe the changes appropriately?\r\n\r\n### Functional Tests\r\n\r\n- [x] Do changes function as described? Add comments below that describe the tests performed.\r\n- [x] How do the changes handle unexpected situations, e.g. bad input?\r\n- Has developer documentation been updated if required?\r\n\r\n### Final Steps\r\n- [ ] Reviewer has moved the [release notes](https://github.com/ISISComputingGroup/IBEX/wiki/ReleaseNotes_Dev) entry for this ticket in the \"Changes merged into master\" section"},"comment":{"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/comments/242447536","html_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/311#issuecomment-242447536","issue_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/311","id":242447536,"user":{"login":"DominicOram","id":10086797,"avatar_url":"https://avatars.githubusercontent.com/u/10086797?v=3","gravatar_id":"","url":"https://api.github.com/users/DominicOram","html_url":"https://github.com/DominicOram","followers_url":"https://api.github.com/users/DominicOram/followers","following_url":"https://api.github.com/users/DominicOram/following{/other_user}","gists_url":"https://api.github.com/users/DominicOram/gists{/gist_id}","starred_url":"https://api.github.com/users/DominicOram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominicOram/subscriptions","organizations_url":"https://api.github.com/users/DominicOram/orgs","repos_url":"https://api.github.com/users/DominicOram/repos","events_url":"https://api.github.com/users/DominicOram/events{/privacy}","received_events_url":"https://api.github.com/users/DominicOram/received_events","type":"User","site_admin":false},"created_at":"2016-08-25T16:16:07Z","updated_at":"2016-08-25T16:16:07Z","body":"Changes added to release notes"}}
{"actor":{"display_login":"DominicOram"}}