{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/3","id":79387614,"html_url":"https://github.com/wireapp/wire-ios-sync-engine/pull/3","diff_url":"https://github.com/wireapp/wire-ios-sync-engine/pull/3.diff","patch_url":"https://github.com/wireapp/wire-ios-sync-engine/pull/3.patch","issue_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/3","number":3,"state":"closed","locked":false,"title":"Refactor image uploading & downloading transcoder","user":{"login":"typfel","id":7156,"avatar_url":"https://avatars.githubusercontent.com/u/7156?v=3","gravatar_id":"","url":"https://api.github.com/users/typfel","html_url":"https://github.com/typfel","followers_url":"https://api.github.com/users/typfel/followers","following_url":"https://api.github.com/users/typfel/following{/other_user}","gists_url":"https://api.github.com/users/typfel/gists{/gist_id}","starred_url":"https://api.github.com/users/typfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typfel/subscriptions","organizations_url":"https://api.github.com/users/typfel/orgs","repos_url":"https://api.github.com/users/typfel/repos","events_url":"https://api.github.com/users/typfel/events{/privacy}","received_events_url":"https://api.github.com/users/typfel/received_events","type":"User","site_admin":false},"body":"This PR extracts the image uploading/downloading from the `ZMClientMessageTranscoder`\r\ninto two new request strategies. The plan after that is to add a modified upstream\r\nsync to the ZMClientMessageTrancoder for updating a message once a link preview\r\nhas been processed.\r\n\r\nWhat is missing:\r\n- ~~~Tests needs to be updated~~~\r\n- ~~~Link preview uploading needs to be added to `ZMClientMessageTranscoder`~~~ - I would like to this as separate PR.","created_at":"2016-07-29T16:32:50Z","updated_at":"2016-09-13T13:07:59Z","closed_at":"2016-09-13T13:07:58Z","merged_at":"2016-09-13T13:07:58Z","merge_commit_sha":"b927449a2e55f8e79f0e2361b8ed6fd0e0390f1d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/3/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/3/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/3/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/statuses/c41f5824c178b3848fdd24311ea27be160087065","head":{"label":"wireapp:feature/refactor-image-transcoder-ZIOS-7015","ref":"feature/refactor-image-transcoder-ZIOS-7015","sha":"c41f5824c178b3848fdd24311ea27be160087065","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":53574338,"name":"wire-ios-sync-engine","full_name":"wireapp/wire-ios-sync-engine","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-ios-sync-engine","description":"iOS synchronization library for Wire","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine","forks_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/deployments","created_at":"2016-03-10T10:02:14Z","updated_at":"2016-09-06T09:57:28Z","pushed_at":"2016-09-13T13:07:58Z","git_url":"git://github.com/wireapp/wire-ios-sync-engine.git","ssh_url":"git@github.com:wireapp/wire-ios-sync-engine.git","clone_url":"https://github.com/wireapp/wire-ios-sync-engine.git","svn_url":"https://github.com/wireapp/wire-ios-sync-engine","homepage":"https://wire.com","size":5433,"stargazers_count":90,"watchers_count":90,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":90,"default_branch":"develop"}},"base":{"label":"wireapp:develop","ref":"develop","sha":"c5689b3dc426c649f6e1d876205b75a83b35b772","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":53574338,"name":"wire-ios-sync-engine","full_name":"wireapp/wire-ios-sync-engine","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars.githubusercontent.com/u/16047324?v=3","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-ios-sync-engine","description":"iOS synchronization library for Wire","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine","forks_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/deployments","created_at":"2016-03-10T10:02:14Z","updated_at":"2016-09-06T09:57:28Z","pushed_at":"2016-09-13T13:07:58Z","git_url":"git://github.com/wireapp/wire-ios-sync-engine.git","ssh_url":"git@github.com:wireapp/wire-ios-sync-engine.git","clone_url":"https://github.com/wireapp/wire-ios-sync-engine.git","svn_url":"https://github.com/wireapp/wire-ios-sync-engine","homepage":"https://wire.com","size":5433,"stargazers_count":90,"watchers_count":90,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":90,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/3"},"html":{"href":"https://github.com/wireapp/wire-ios-sync-engine/pull/3"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/3"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-ios-sync-engine/statuses/c41f5824c178b3848fdd24311ea27be160087065"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"marcoconti83","id":620000,"avatar_url":"https://avatars.githubusercontent.com/u/620000?v=3","gravatar_id":"","url":"https://api.github.com/users/marcoconti83","html_url":"https://github.com/marcoconti83","followers_url":"https://api.github.com/users/marcoconti83/followers","following_url":"https://api.github.com/users/marcoconti83/following{/other_user}","gists_url":"https://api.github.com/users/marcoconti83/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoconti83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoconti83/subscriptions","organizations_url":"https://api.github.com/users/marcoconti83/orgs","repos_url":"https://api.github.com/users/marcoconti83/repos","events_url":"https://api.github.com/users/marcoconti83/events{/privacy}","received_events_url":"https://api.github.com/users/marcoconti83/received_events","type":"User","site_admin":false},"comments":6,"review_comments":11,"commits":10,"additions":832,"deletions":689,"changed_files":8}}
{"actor":{"display_login":"marcoconti83"}}