{"action":"created","comment":{"url":"https://api.github.com/repos/sovereign/sovereign/pulls/comments/56760902","id":56760902,"diff_hunk":"@@ -1,4 +1,5 @@\n #!/bin/bash\n+service apache2 stop","path":"roles/common/files/letsencrypt-gencert","position":null,"original_position":2,"commit_id":"0abf92734e79cc29ce8c0539d6135383e07f13d2","original_commit_id":"c3c2cbf096c9c0d37bd592b3023910a9c654f636","user":{"login":"mikeashley","id":9498928,"avatar_url":"https://avatars.githubusercontent.com/u/9498928?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeashley","html_url":"https://github.com/mikeashley","followers_url":"https://api.github.com/users/mikeashley/followers","following_url":"https://api.github.com/users/mikeashley/following{/other_user}","gists_url":"https://api.github.com/users/mikeashley/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeashley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeashley/subscriptions","organizations_url":"https://api.github.com/users/mikeashley/orgs","repos_url":"https://api.github.com/users/mikeashley/repos","events_url":"https://api.github.com/users/mikeashley/events{/privacy}","received_events_url":"https://api.github.com/users/mikeashley/received_events","type":"User","site_admin":false},"body":"I am thinking about the invariant.  Apache is running when this task list runs.  After the gencert script (which is run conditionally), Apache is left running.  I don't see the need for the last start task, and I worry it will confuse future readers who also wonder why it's there, trying to answer the question, \"what is the condition that led to the author thinking they needed to (re)start Apache from Ansible???\"","created_at":"2016-03-20T08:44:23Z","updated_at":"2016-03-20T08:44:23Z","html_url":"https://github.com/sovereign/sovereign/pull/533#discussion_r56760902","pull_request_url":"https://api.github.com/repos/sovereign/sovereign/pulls/533","_links":{"self":{"href":"https://api.github.com/repos/sovereign/sovereign/pulls/comments/56760902"},"html":{"href":"https://github.com/sovereign/sovereign/pull/533#discussion_r56760902"},"pull_request":{"href":"https://api.github.com/repos/sovereign/sovereign/pulls/533"}}},"pull_request":{"url":"https://api.github.com/repos/sovereign/sovereign/pulls/533","id":62843751,"html_url":"https://github.com/sovereign/sovereign/pull/533","diff_url":"https://github.com/sovereign/sovereign/pull/533.diff","patch_url":"https://github.com/sovereign/sovereign/pull/533.patch","issue_url":"https://api.github.com/repos/sovereign/sovereign/issues/533","number":533,"state":"open","locked":false,"title":"Idempotency fixes to LetsEncrypt handling.","user":{"login":"carljm","id":61586,"avatar_url":"https://avatars.githubusercontent.com/u/61586?v=3","gravatar_id":"","url":"https://api.github.com/users/carljm","html_url":"https://github.com/carljm","followers_url":"https://api.github.com/users/carljm/followers","following_url":"https://api.github.com/users/carljm/following{/other_user}","gists_url":"https://api.github.com/users/carljm/gists{/gist_id}","starred_url":"https://api.github.com/users/carljm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carljm/subscriptions","organizations_url":"https://api.github.com/users/carljm/orgs","repos_url":"https://api.github.com/users/carljm/repos","events_url":"https://api.github.com/users/carljm/events{/privacy}","received_events_url":"https://api.github.com/users/carljm/received_events","type":"User","site_admin":false},"body":"Previous to this PR, because the ZNC and dovecot roles were modifying the LetsEncrypt renewal cron job in place, every subsequent run would reinstall the original version of that cron job. This causes spurious \"changed\" tasks, as well as problems if e.g. the LetsEncrypt tasks are run outside of a full run (because the cronjob will be restored to its non-updated form). This PR fixes that by making each post-renew task an independent script, found and executed by the cronjob. Tested and working.","created_at":"2016-03-15T01:41:55Z","updated_at":"2016-03-20T08:44:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"641e6883e10df6b9f6ec8a4dafa4156970b02b46","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sovereign/sovereign/pulls/533/commits","review_comments_url":"https://api.github.com/repos/sovereign/sovereign/pulls/533/comments","review_comment_url":"https://api.github.com/repos/sovereign/sovereign/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sovereign/sovereign/issues/533/comments","statuses_url":"https://api.github.com/repos/sovereign/sovereign/statuses/0abf92734e79cc29ce8c0539d6135383e07f13d2","head":{"label":"carljm:post-renew","ref":"post-renew","sha":"0abf92734e79cc29ce8c0539d6135383e07f13d2","user":{"login":"carljm","id":61586,"avatar_url":"https://avatars.githubusercontent.com/u/61586?v=3","gravatar_id":"","url":"https://api.github.com/users/carljm","html_url":"https://github.com/carljm","followers_url":"https://api.github.com/users/carljm/followers","following_url":"https://api.github.com/users/carljm/following{/other_user}","gists_url":"https://api.github.com/users/carljm/gists{/gist_id}","starred_url":"https://api.github.com/users/carljm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carljm/subscriptions","organizations_url":"https://api.github.com/users/carljm/orgs","repos_url":"https://api.github.com/users/carljm/repos","events_url":"https://api.github.com/users/carljm/events{/privacy}","received_events_url":"https://api.github.com/users/carljm/received_events","type":"User","site_admin":false},"repo":{"id":50822275,"name":"sovereign","full_name":"carljm/sovereign","owner":{"login":"carljm","id":61586,"avatar_url":"https://avatars.githubusercontent.com/u/61586?v=3","gravatar_id":"","url":"https://api.github.com/users/carljm","html_url":"https://github.com/carljm","followers_url":"https://api.github.com/users/carljm/followers","following_url":"https://api.github.com/users/carljm/following{/other_user}","gists_url":"https://api.github.com/users/carljm/gists{/gist_id}","starred_url":"https://api.github.com/users/carljm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carljm/subscriptions","organizations_url":"https://api.github.com/users/carljm/orgs","repos_url":"https://api.github.com/users/carljm/repos","events_url":"https://api.github.com/users/carljm/events{/privacy}","received_events_url":"https://api.github.com/users/carljm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carljm/sovereign","description":"A set of Ansible playbooks to build and maintain your own private cloud: email, calendar, contacts, file sync, IRC bouncer, VPN, and more.","fork":true,"url":"https://api.github.com/repos/carljm/sovereign","forks_url":"https://api.github.com/repos/carljm/sovereign/forks","keys_url":"https://api.github.com/repos/carljm/sovereign/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carljm/sovereign/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carljm/sovereign/teams","hooks_url":"https://api.github.com/repos/carljm/sovereign/hooks","issue_events_url":"https://api.github.com/repos/carljm/sovereign/issues/events{/number}","events_url":"https://api.github.com/repos/carljm/sovereign/events","assignees_url":"https://api.github.com/repos/carljm/sovereign/assignees{/user}","branches_url":"https://api.github.com/repos/carljm/sovereign/branches{/branch}","tags_url":"https://api.github.com/repos/carljm/sovereign/tags","blobs_url":"https://api.github.com/repos/carljm/sovereign/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carljm/sovereign/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carljm/sovereign/git/refs{/sha}","trees_url":"https://api.github.com/repos/carljm/sovereign/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carljm/sovereign/statuses/{sha}","languages_url":"https://api.github.com/repos/carljm/sovereign/languages","stargazers_url":"https://api.github.com/repos/carljm/sovereign/stargazers","contributors_url":"https://api.github.com/repos/carljm/sovereign/contributors","subscribers_url":"https://api.github.com/repos/carljm/sovereign/subscribers","subscription_url":"https://api.github.com/repos/carljm/sovereign/subscription","commits_url":"https://api.github.com/repos/carljm/sovereign/commits{/sha}","git_commits_url":"https://api.github.com/repos/carljm/sovereign/git/commits{/sha}","comments_url":"https://api.github.com/repos/carljm/sovereign/comments{/number}","issue_comment_url":"https://api.github.com/repos/carljm/sovereign/issues/comments{/number}","contents_url":"https://api.github.com/repos/carljm/sovereign/contents/{+path}","compare_url":"https://api.github.com/repos/carljm/sovereign/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carljm/sovereign/merges","archive_url":"https://api.github.com/repos/carljm/sovereign/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carljm/sovereign/downloads","issues_url":"https://api.github.com/repos/carljm/sovereign/issues{/number}","pulls_url":"https://api.github.com/repos/carljm/sovereign/pulls{/number}","milestones_url":"https://api.github.com/repos/carljm/sovereign/milestones{/number}","notifications_url":"https://api.github.com/repos/carljm/sovereign/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carljm/sovereign/labels{/name}","releases_url":"https://api.github.com/repos/carljm/sovereign/releases{/id}","deployments_url":"https://api.github.com/repos/carljm/sovereign/deployments","created_at":"2016-02-01T07:27:59Z","updated_at":"2016-02-01T07:28:00Z","pushed_at":"2016-03-17T18:17:09Z","git_url":"git://github.com/carljm/sovereign.git","ssh_url":"git@github.com:carljm/sovereign.git","clone_url":"https://github.com/carljm/sovereign.git","svn_url":"https://github.com/carljm/sovereign","homepage":null,"size":870,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sovereign:jessie","ref":"jessie","sha":"70460b53a7a1bb442ed3769829239bbffadef27b","user":{"login":"sovereign","id":6289855,"avatar_url":"https://avatars.githubusercontent.com/u/6289855?v=3","gravatar_id":"","url":"https://api.github.com/users/sovereign","html_url":"https://github.com/sovereign","followers_url":"https://api.github.com/users/sovereign/followers","following_url":"https://api.github.com/users/sovereign/following{/other_user}","gists_url":"https://api.github.com/users/sovereign/gists{/gist_id}","starred_url":"https://api.github.com/users/sovereign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sovereign/subscriptions","organizations_url":"https://api.github.com/users/sovereign/orgs","repos_url":"https://api.github.com/users/sovereign/repos","events_url":"https://api.github.com/users/sovereign/events{/privacy}","received_events_url":"https://api.github.com/users/sovereign/received_events","type":"Organization","site_admin":false},"repo":{"id":12228746,"name":"sovereign","full_name":"sovereign/sovereign","owner":{"login":"sovereign","id":6289855,"avatar_url":"https://avatars.githubusercontent.com/u/6289855?v=3","gravatar_id":"","url":"https://api.github.com/users/sovereign","html_url":"https://github.com/sovereign","followers_url":"https://api.github.com/users/sovereign/followers","following_url":"https://api.github.com/users/sovereign/following{/other_user}","gists_url":"https://api.github.com/users/sovereign/gists{/gist_id}","starred_url":"https://api.github.com/users/sovereign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sovereign/subscriptions","organizations_url":"https://api.github.com/users/sovereign/orgs","repos_url":"https://api.github.com/users/sovereign/repos","events_url":"https://api.github.com/users/sovereign/events{/privacy}","received_events_url":"https://api.github.com/users/sovereign/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sovereign/sovereign","description":"A set of Ansible playbooks to build and maintain your own private cloud: email, calendar, contacts, file sync, IRC bouncer, VPN, and more.","fork":false,"url":"https://api.github.com/repos/sovereign/sovereign","forks_url":"https://api.github.com/repos/sovereign/sovereign/forks","keys_url":"https://api.github.com/repos/sovereign/sovereign/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sovereign/sovereign/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sovereign/sovereign/teams","hooks_url":"https://api.github.com/repos/sovereign/sovereign/hooks","issue_events_url":"https://api.github.com/repos/sovereign/sovereign/issues/events{/number}","events_url":"https://api.github.com/repos/sovereign/sovereign/events","assignees_url":"https://api.github.com/repos/sovereign/sovereign/assignees{/user}","branches_url":"https://api.github.com/repos/sovereign/sovereign/branches{/branch}","tags_url":"https://api.github.com/repos/sovereign/sovereign/tags","blobs_url":"https://api.github.com/repos/sovereign/sovereign/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sovereign/sovereign/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sovereign/sovereign/git/refs{/sha}","trees_url":"https://api.github.com/repos/sovereign/sovereign/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sovereign/sovereign/statuses/{sha}","languages_url":"https://api.github.com/repos/sovereign/sovereign/languages","stargazers_url":"https://api.github.com/repos/sovereign/sovereign/stargazers","contributors_url":"https://api.github.com/repos/sovereign/sovereign/contributors","subscribers_url":"https://api.github.com/repos/sovereign/sovereign/subscribers","subscription_url":"https://api.github.com/repos/sovereign/sovereign/subscription","commits_url":"https://api.github.com/repos/sovereign/sovereign/commits{/sha}","git_commits_url":"https://api.github.com/repos/sovereign/sovereign/git/commits{/sha}","comments_url":"https://api.github.com/repos/sovereign/sovereign/comments{/number}","issue_comment_url":"https://api.github.com/repos/sovereign/sovereign/issues/comments{/number}","contents_url":"https://api.github.com/repos/sovereign/sovereign/contents/{+path}","compare_url":"https://api.github.com/repos/sovereign/sovereign/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sovereign/sovereign/merges","archive_url":"https://api.github.com/repos/sovereign/sovereign/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sovereign/sovereign/downloads","issues_url":"https://api.github.com/repos/sovereign/sovereign/issues{/number}","pulls_url":"https://api.github.com/repos/sovereign/sovereign/pulls{/number}","milestones_url":"https://api.github.com/repos/sovereign/sovereign/milestones{/number}","notifications_url":"https://api.github.com/repos/sovereign/sovereign/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sovereign/sovereign/labels{/name}","releases_url":"https://api.github.com/repos/sovereign/sovereign/releases{/id}","deployments_url":"https://api.github.com/repos/sovereign/sovereign/deployments","created_at":"2013-08-19T22:09:16Z","updated_at":"2016-03-20T03:55:15Z","pushed_at":"2016-03-18T08:27:06Z","git_url":"git://github.com/sovereign/sovereign.git","ssh_url":"git@github.com:sovereign/sovereign.git","clone_url":"https://github.com/sovereign/sovereign.git","svn_url":"https://github.com/sovereign/sovereign","homepage":null,"size":1085,"stargazers_count":5182,"watchers_count":5182,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":455,"mirror_url":null,"open_issues_count":43,"forks":455,"open_issues":43,"watchers":5182,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sovereign/sovereign/pulls/533"},"html":{"href":"https://github.com/sovereign/sovereign/pull/533"},"issue":{"href":"https://api.github.com/repos/sovereign/sovereign/issues/533"},"comments":{"href":"https://api.github.com/repos/sovereign/sovereign/issues/533/comments"},"review_comments":{"href":"https://api.github.com/repos/sovereign/sovereign/pulls/533/comments"},"review_comment":{"href":"https://api.github.com/repos/sovereign/sovereign/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sovereign/sovereign/pulls/533/commits"},"statuses":{"href":"https://api.github.com/repos/sovereign/sovereign/statuses/0abf92734e79cc29ce8c0539d6135383e07f13d2"}}}}