{"action":"created","comment":{"url":"https://api.github.com/repos/shazow/urllib3/pulls/comments/69431636","id":69431636,"diff_hunk":"@@ -0,0 +1,75 @@\n+import time\n+\n+from ..packages.six.moves.http_cookiejar import (\n+    DefaultCookiePolicy as PythonCookiePolicy,\n+    CookieJar as PythonCookieJar\n+)\n+\n+\n+class DefaultCookiePolicy(PythonCookiePolicy):\n+    \"\"\"\n+    The default urllib3 cookie policy - similar to the Python default,\n+    but :param:`strict_ns_domain` is set to `DomainStrict` for security.\n+    \"\"\"\n+    def __init__(self, *args, **kwargs):\n+        policy = PythonCookiePolicy.DomainStrict\n+        kwargs.setdefault('strict_ns_domain', policy)\n+        # Old-style class on Python 2\n+        PythonCookiePolicy.__init__(self, *args, **kwargs)\n+\n+\n+class CookieJar(PythonCookieJar):\n+\n+    def __init__(self, policy=None):\n+        policy = policy or DefaultCookiePolicy()","path":"urllib3/util/sessioncontext.py","position":24,"original_position":24,"commit_id":"66c86185280d92d2fc64177d4a496a834d4d93c7","original_commit_id":"66c86185280d92d2fc64177d4a496a834d4d93c7","user":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"body":"We maybe want to use an explicit `is not None` check here, rather than rely on the truthiness of arbitrary objects.","created_at":"2016-07-04T09:30:27Z","updated_at":"2016-07-04T09:30:27Z","html_url":"https://github.com/shazow/urllib3/pull/904#discussion_r69431636","pull_request_url":"https://api.github.com/repos/shazow/urllib3/pulls/904","_links":{"self":{"href":"https://api.github.com/repos/shazow/urllib3/pulls/comments/69431636"},"html":{"href":"https://github.com/shazow/urllib3/pull/904#discussion_r69431636"},"pull_request":{"href":"https://api.github.com/repos/shazow/urllib3/pulls/904"}}},"pull_request":{"url":"https://api.github.com/repos/shazow/urllib3/pulls/904","id":74815148,"html_url":"https://github.com/shazow/urllib3/pull/904","diff_url":"https://github.com/shazow/urllib3/pull/904.diff","patch_url":"https://github.com/shazow/urllib3/pull/904.patch","issue_url":"https://api.github.com/repos/shazow/urllib3/issues/904","number":904,"state":"open","locked":false,"title":"Approved SessionManager changes","user":{"login":"haikuginger","id":7773758,"avatar_url":"https://avatars.githubusercontent.com/u/7773758?v=3","gravatar_id":"","url":"https://api.github.com/users/haikuginger","html_url":"https://github.com/haikuginger","followers_url":"https://api.github.com/users/haikuginger/followers","following_url":"https://api.github.com/users/haikuginger/following{/other_user}","gists_url":"https://api.github.com/users/haikuginger/gists{/gist_id}","starred_url":"https://api.github.com/users/haikuginger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haikuginger/subscriptions","organizations_url":"https://api.github.com/users/haikuginger/orgs","repos_url":"https://api.github.com/users/haikuginger/repos","events_url":"https://api.github.com/users/haikuginger/events{/privacy}","received_events_url":"https://api.github.com/users/haikuginger/received_events","type":"User","site_admin":false},"body":"Basic implementation of the SessionManager cookie-handling logic.","created_at":"2016-06-22T16:25:55Z","updated_at":"2016-07-04T09:30:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"137fe3501229dafb969784855a81f8d46c81b3f1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/shazow/urllib3/pulls/904/commits","review_comments_url":"https://api.github.com/repos/shazow/urllib3/pulls/904/comments","review_comment_url":"https://api.github.com/repos/shazow/urllib3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shazow/urllib3/issues/904/comments","statuses_url":"https://api.github.com/repos/shazow/urllib3/statuses/66c86185280d92d2fc64177d4a496a834d4d93c7","head":{"label":"haikuginger:approved-session-manager","ref":"approved-session-manager","sha":"66c86185280d92d2fc64177d4a496a834d4d93c7","user":{"login":"haikuginger","id":7773758,"avatar_url":"https://avatars.githubusercontent.com/u/7773758?v=3","gravatar_id":"","url":"https://api.github.com/users/haikuginger","html_url":"https://github.com/haikuginger","followers_url":"https://api.github.com/users/haikuginger/followers","following_url":"https://api.github.com/users/haikuginger/following{/other_user}","gists_url":"https://api.github.com/users/haikuginger/gists{/gist_id}","starred_url":"https://api.github.com/users/haikuginger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haikuginger/subscriptions","organizations_url":"https://api.github.com/users/haikuginger/orgs","repos_url":"https://api.github.com/users/haikuginger/repos","events_url":"https://api.github.com/users/haikuginger/events{/privacy}","received_events_url":"https://api.github.com/users/haikuginger/received_events","type":"User","site_admin":false},"repo":{"id":54031804,"name":"urllib3","full_name":"haikuginger/urllib3","owner":{"login":"haikuginger","id":7773758,"avatar_url":"https://avatars.githubusercontent.com/u/7773758?v=3","gravatar_id":"","url":"https://api.github.com/users/haikuginger","html_url":"https://github.com/haikuginger","followers_url":"https://api.github.com/users/haikuginger/followers","following_url":"https://api.github.com/users/haikuginger/following{/other_user}","gists_url":"https://api.github.com/users/haikuginger/gists{/gist_id}","starred_url":"https://api.github.com/users/haikuginger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haikuginger/subscriptions","organizations_url":"https://api.github.com/users/haikuginger/orgs","repos_url":"https://api.github.com/users/haikuginger/repos","events_url":"https://api.github.com/users/haikuginger/events{/privacy}","received_events_url":"https://api.github.com/users/haikuginger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/haikuginger/urllib3","description":"Python HTTP library with thread-safe connection pooling, file post support, sanity friendly, and more.","fork":true,"url":"https://api.github.com/repos/haikuginger/urllib3","forks_url":"https://api.github.com/repos/haikuginger/urllib3/forks","keys_url":"https://api.github.com/repos/haikuginger/urllib3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haikuginger/urllib3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haikuginger/urllib3/teams","hooks_url":"https://api.github.com/repos/haikuginger/urllib3/hooks","issue_events_url":"https://api.github.com/repos/haikuginger/urllib3/issues/events{/number}","events_url":"https://api.github.com/repos/haikuginger/urllib3/events","assignees_url":"https://api.github.com/repos/haikuginger/urllib3/assignees{/user}","branches_url":"https://api.github.com/repos/haikuginger/urllib3/branches{/branch}","tags_url":"https://api.github.com/repos/haikuginger/urllib3/tags","blobs_url":"https://api.github.com/repos/haikuginger/urllib3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haikuginger/urllib3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haikuginger/urllib3/git/refs{/sha}","trees_url":"https://api.github.com/repos/haikuginger/urllib3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haikuginger/urllib3/statuses/{sha}","languages_url":"https://api.github.com/repos/haikuginger/urllib3/languages","stargazers_url":"https://api.github.com/repos/haikuginger/urllib3/stargazers","contributors_url":"https://api.github.com/repos/haikuginger/urllib3/contributors","subscribers_url":"https://api.github.com/repos/haikuginger/urllib3/subscribers","subscription_url":"https://api.github.com/repos/haikuginger/urllib3/subscription","commits_url":"https://api.github.com/repos/haikuginger/urllib3/commits{/sha}","git_commits_url":"https://api.github.com/repos/haikuginger/urllib3/git/commits{/sha}","comments_url":"https://api.github.com/repos/haikuginger/urllib3/comments{/number}","issue_comment_url":"https://api.github.com/repos/haikuginger/urllib3/issues/comments{/number}","contents_url":"https://api.github.com/repos/haikuginger/urllib3/contents/{+path}","compare_url":"https://api.github.com/repos/haikuginger/urllib3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haikuginger/urllib3/merges","archive_url":"https://api.github.com/repos/haikuginger/urllib3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haikuginger/urllib3/downloads","issues_url":"https://api.github.com/repos/haikuginger/urllib3/issues{/number}","pulls_url":"https://api.github.com/repos/haikuginger/urllib3/pulls{/number}","milestones_url":"https://api.github.com/repos/haikuginger/urllib3/milestones{/number}","notifications_url":"https://api.github.com/repos/haikuginger/urllib3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haikuginger/urllib3/labels{/name}","releases_url":"https://api.github.com/repos/haikuginger/urllib3/releases{/id}","deployments_url":"https://api.github.com/repos/haikuginger/urllib3/deployments","created_at":"2016-03-16T12:56:31Z","updated_at":"2016-03-16T12:56:32Z","pushed_at":"2016-06-22T17:05:58Z","git_url":"git://github.com/haikuginger/urllib3.git","ssh_url":"git@github.com:haikuginger/urllib3.git","clone_url":"https://github.com/haikuginger/urllib3.git","svn_url":"https://github.com/haikuginger/urllib3","homepage":"http://urllib3.readthedocs.org/","size":2839,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"shazow:sessionmanager","ref":"sessionmanager","sha":"f69ad8e1b3e5c81c82f87a8126dffc3a7f02a3c8","user":{"login":"shazow","id":6292,"avatar_url":"https://avatars.githubusercontent.com/u/6292?v=3","gravatar_id":"","url":"https://api.github.com/users/shazow","html_url":"https://github.com/shazow","followers_url":"https://api.github.com/users/shazow/followers","following_url":"https://api.github.com/users/shazow/following{/other_user}","gists_url":"https://api.github.com/users/shazow/gists{/gist_id}","starred_url":"https://api.github.com/users/shazow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shazow/subscriptions","organizations_url":"https://api.github.com/users/shazow/orgs","repos_url":"https://api.github.com/users/shazow/repos","events_url":"https://api.github.com/users/shazow/events{/privacy}","received_events_url":"https://api.github.com/users/shazow/received_events","type":"User","site_admin":false},"repo":{"id":2410676,"name":"urllib3","full_name":"shazow/urllib3","owner":{"login":"shazow","id":6292,"avatar_url":"https://avatars.githubusercontent.com/u/6292?v=3","gravatar_id":"","url":"https://api.github.com/users/shazow","html_url":"https://github.com/shazow","followers_url":"https://api.github.com/users/shazow/followers","following_url":"https://api.github.com/users/shazow/following{/other_user}","gists_url":"https://api.github.com/users/shazow/gists{/gist_id}","starred_url":"https://api.github.com/users/shazow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shazow/subscriptions","organizations_url":"https://api.github.com/users/shazow/orgs","repos_url":"https://api.github.com/users/shazow/repos","events_url":"https://api.github.com/users/shazow/events{/privacy}","received_events_url":"https://api.github.com/users/shazow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shazow/urllib3","description":"Python HTTP library with thread-safe connection pooling, file post support, sanity friendly, and more.","fork":false,"url":"https://api.github.com/repos/shazow/urllib3","forks_url":"https://api.github.com/repos/shazow/urllib3/forks","keys_url":"https://api.github.com/repos/shazow/urllib3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shazow/urllib3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shazow/urllib3/teams","hooks_url":"https://api.github.com/repos/shazow/urllib3/hooks","issue_events_url":"https://api.github.com/repos/shazow/urllib3/issues/events{/number}","events_url":"https://api.github.com/repos/shazow/urllib3/events","assignees_url":"https://api.github.com/repos/shazow/urllib3/assignees{/user}","branches_url":"https://api.github.com/repos/shazow/urllib3/branches{/branch}","tags_url":"https://api.github.com/repos/shazow/urllib3/tags","blobs_url":"https://api.github.com/repos/shazow/urllib3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shazow/urllib3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shazow/urllib3/git/refs{/sha}","trees_url":"https://api.github.com/repos/shazow/urllib3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shazow/urllib3/statuses/{sha}","languages_url":"https://api.github.com/repos/shazow/urllib3/languages","stargazers_url":"https://api.github.com/repos/shazow/urllib3/stargazers","contributors_url":"https://api.github.com/repos/shazow/urllib3/contributors","subscribers_url":"https://api.github.com/repos/shazow/urllib3/subscribers","subscription_url":"https://api.github.com/repos/shazow/urllib3/subscription","commits_url":"https://api.github.com/repos/shazow/urllib3/commits{/sha}","git_commits_url":"https://api.github.com/repos/shazow/urllib3/git/commits{/sha}","comments_url":"https://api.github.com/repos/shazow/urllib3/comments{/number}","issue_comment_url":"https://api.github.com/repos/shazow/urllib3/issues/comments{/number}","contents_url":"https://api.github.com/repos/shazow/urllib3/contents/{+path}","compare_url":"https://api.github.com/repos/shazow/urllib3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shazow/urllib3/merges","archive_url":"https://api.github.com/repos/shazow/urllib3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shazow/urllib3/downloads","issues_url":"https://api.github.com/repos/shazow/urllib3/issues{/number}","pulls_url":"https://api.github.com/repos/shazow/urllib3/pulls{/number}","milestones_url":"https://api.github.com/repos/shazow/urllib3/milestones{/number}","notifications_url":"https://api.github.com/repos/shazow/urllib3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shazow/urllib3/labels{/name}","releases_url":"https://api.github.com/repos/shazow/urllib3/releases{/id}","deployments_url":"https://api.github.com/repos/shazow/urllib3/deployments","created_at":"2011-09-18T18:08:28Z","updated_at":"2016-06-30T09:15:56Z","pushed_at":"2016-07-02T20:26:54Z","git_url":"git://github.com/shazow/urllib3.git","ssh_url":"git@github.com:shazow/urllib3.git","clone_url":"https://github.com/shazow/urllib3.git","svn_url":"https://github.com/shazow/urllib3","homepage":"https://urllib3.readthedocs.io/","size":4942,"stargazers_count":1062,"watchers_count":1062,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":357,"mirror_url":null,"open_issues_count":118,"forks":357,"open_issues":118,"watchers":1062,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shazow/urllib3/pulls/904"},"html":{"href":"https://github.com/shazow/urllib3/pull/904"},"issue":{"href":"https://api.github.com/repos/shazow/urllib3/issues/904"},"comments":{"href":"https://api.github.com/repos/shazow/urllib3/issues/904/comments"},"review_comments":{"href":"https://api.github.com/repos/shazow/urllib3/pulls/904/comments"},"review_comment":{"href":"https://api.github.com/repos/shazow/urllib3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shazow/urllib3/pulls/904/commits"},"statuses":{"href":"https://api.github.com/repos/shazow/urllib3/statuses/66c86185280d92d2fc64177d4a496a834d4d93c7"}}}}
{"actor":{"display_login":"Lukasa"}}