{"action":"created","issue":{"url":"https://api.github.com/repos/buildkite-plugins/docker-compose-buildkite-plugin/issues/7","repository_url":"https://api.github.com/repos/buildkite-plugins/docker-compose-buildkite-plugin","labels_url":"https://api.github.com/repos/buildkite-plugins/docker-compose-buildkite-plugin/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/buildkite-plugins/docker-compose-buildkite-plugin/issues/7/comments","events_url":"https://api.github.com/repos/buildkite-plugins/docker-compose-buildkite-plugin/issues/7/events","html_url":"https://github.com/buildkite-plugins/docker-compose-buildkite-plugin/pull/7","id":179120726,"number":7,"title":"Add a short sha tag to pushed images","user":{"login":"anoldguy","id":1304498,"avatar_url":"https://avatars.githubusercontent.com/u/1304498?v=3","gravatar_id":"","url":"https://api.github.com/users/anoldguy","html_url":"https://github.com/anoldguy","followers_url":"https://api.github.com/users/anoldguy/followers","following_url":"https://api.github.com/users/anoldguy/following{/other_user}","gists_url":"https://api.github.com/users/anoldguy/gists{/gist_id}","starred_url":"https://api.github.com/users/anoldguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anoldguy/subscriptions","organizations_url":"https://api.github.com/users/anoldguy/orgs","repos_url":"https://api.github.com/users/anoldguy/repos","events_url":"https://api.github.com/users/anoldguy/events{/privacy}","received_events_url":"https://api.github.com/users/anoldguy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-26T01:06:53Z","updated_at":"2016-09-27T07:18:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/buildkite-plugins/docker-compose-buildkite-plugin/pulls/7","html_url":"https://github.com/buildkite-plugins/docker-compose-buildkite-plugin/pull/7","diff_url":"https://github.com/buildkite-plugins/docker-compose-buildkite-plugin/pull/7.diff","patch_url":"https://github.com/buildkite-plugins/docker-compose-buildkite-plugin/pull/7.patch"},"body":"This is a proof-of-concept PR.\r\n\r\nI love this plugin!!  This plugin made it a breeze to split up our tests and dropped our previous pipeline times from 10+ min down to under 5 for the worst case, and down to 2m30s in the best case!\r\n\r\nHowever, the tags it produces, are, well...ugly.  They're completely cromulent on the backend, but we use those tag names in a deploy tool, and well, who wants to deploy `my-application-app-build-100`?  We're already used to the git short sha's, so I think it'd be nice to have an option to push that tag to the repo.\r\n\r\nThis commit adds the short sha (`git rev-parse --short $BUILDKITE_COMMIT`) as a tag that's pushed to the repo.\r\n\r\nI'm not emotionally invested in this exact code change, so as long as we've got some way to indicate either \"add the short sha as a tag\" or \"use this as a tag for this build\", my request would be met.\r\n\r\nAgain, thanks for this great plugin!"},"comment":{"url":"https://api.github.com/repos/buildkite-plugins/docker-compose-buildkite-plugin/issues/comments/249785601","html_url":"https://github.com/buildkite-plugins/docker-compose-buildkite-plugin/pull/7#issuecomment-249785601","issue_url":"https://api.github.com/repos/buildkite-plugins/docker-compose-buildkite-plugin/issues/7","id":249785601,"user":{"login":"iroller","id":338294,"avatar_url":"https://avatars.githubusercontent.com/u/338294?v=3","gravatar_id":"","url":"https://api.github.com/users/iroller","html_url":"https://github.com/iroller","followers_url":"https://api.github.com/users/iroller/followers","following_url":"https://api.github.com/users/iroller/following{/other_user}","gists_url":"https://api.github.com/users/iroller/gists{/gist_id}","starred_url":"https://api.github.com/users/iroller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iroller/subscriptions","organizations_url":"https://api.github.com/users/iroller/orgs","repos_url":"https://api.github.com/users/iroller/repos","events_url":"https://api.github.com/users/iroller/events{/privacy}","received_events_url":"https://api.github.com/users/iroller/received_events","type":"User","site_admin":false},"created_at":"2016-09-27T07:18:53Z","updated_at":"2016-09-27T07:18:53Z","body":"Hi there. I wanted to add that docker-compose [has](https://docs.docker.com/compose/compose-file/) the following option:\r\n```\r\nIf you specify image as well as build, then Compose names the built image with the webapp and optional tag specified in image:\r\n\r\nbuild: ./dir\r\nimage: webapp:tag\r\n```\r\n\r\nIt'd be great to support this method and push `webapp:tag` to docker registry.\r\n\r\nAlso you can use interpolation and do something like this in docker-compose.yml:\r\n```\r\nimage: company/webapp:${BUILDKITE_COMMIT}\r\n```\r\n_(I tried it, it works)_\r\n\r\nThe only missing part here is for docker-compose-buildkite-plugin to push the proper tag. Adding a new tag isn't even required unless you need multiple tags."}}
{"actor":{"display_login":"iroller"}}