{"action":"created","issue":{"url":"https://api.github.com/repos/LLNL/spack/issues/1298","repository_url":"https://api.github.com/repos/LLNL/spack","labels_url":"https://api.github.com/repos/LLNL/spack/issues/1298/labels{/name}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/1298/comments","events_url":"https://api.github.com/repos/LLNL/spack/issues/1298/events","html_url":"https://github.com/LLNL/spack/pull/1298","id":166343923,"number":1298,"title":"Remove mechanism that auto-accepts Oracle license agreements without …","user":{"login":"citibeth","id":1924215,"avatar_url":"https://avatars.githubusercontent.com/u/1924215?v=3","gravatar_id":"","url":"https://api.github.com/users/citibeth","html_url":"https://github.com/citibeth","followers_url":"https://api.github.com/users/citibeth/followers","following_url":"https://api.github.com/users/citibeth/following{/other_user}","gists_url":"https://api.github.com/users/citibeth/gists{/gist_id}","starred_url":"https://api.github.com/users/citibeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citibeth/subscriptions","organizations_url":"https://api.github.com/users/citibeth/orgs","repos_url":"https://api.github.com/users/citibeth/repos","events_url":"https://api.github.com/users/citibeth/events{/privacy}","received_events_url":"https://api.github.com/users/citibeth/received_events","type":"User","site_admin":false},"labels":[{"id":503169733,"url":"https://api.github.com/repos/LLNL/spack/labels/java","name":"java","color":"006b75","default":false},{"id":446620033,"url":"https://api.github.com/repos/LLNL/spack/labels/ready","name":"ready","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-19T14:22:12Z","updated_at":"2016-12-20T17:29:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/LLNL/spack/pulls/1298","html_url":"https://github.com/LLNL/spack/pull/1298","diff_url":"https://github.com/LLNL/spack/pull/1298.diff","patch_url":"https://github.com/LLNL/spack/pull/1298.patch"},"body":"…user's consent or approval.  Removed because it could cause legal liability for users and LLNL.\n\nAdded virtual dependency `java`.\n\nTODO later:\n- Add better documentation on how to deal with licensed-binary installs like this one, using Spack mirrors.\n- Add a real IcedTea build.\n"},"comment":{"url":"https://api.github.com/repos/LLNL/spack/issues/comments/268304757","html_url":"https://github.com/LLNL/spack/pull/1298#issuecomment-268304757","issue_url":"https://api.github.com/repos/LLNL/spack/issues/1298","id":268304757,"user":{"login":"hartzell","id":312978,"avatar_url":"https://avatars.githubusercontent.com/u/312978?v=3","gravatar_id":"","url":"https://api.github.com/users/hartzell","html_url":"https://github.com/hartzell","followers_url":"https://api.github.com/users/hartzell/followers","following_url":"https://api.github.com/users/hartzell/following{/other_user}","gists_url":"https://api.github.com/users/hartzell/gists{/gist_id}","starred_url":"https://api.github.com/users/hartzell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hartzell/subscriptions","organizations_url":"https://api.github.com/users/hartzell/orgs","repos_url":"https://api.github.com/users/hartzell/repos","events_url":"https://api.github.com/users/hartzell/events{/privacy}","received_events_url":"https://api.github.com/users/hartzell/received_events","type":"User","site_admin":false},"created_at":"2016-12-20T17:29:10Z","updated_at":"2016-12-20T17:29:10Z","body":"When I run this, it explodes with an error about a bad checksum.  If I were walking into this innocently it wouldn't occur to me to go read the package comment for an explanation about what went wrong.\r\n\r\n```\r\n[hartzelg@rpbuchop001 spack-jdk-test]$ spack install jdk\r\n==> Installing jdk\r\n==> Fetching http://download.oracle.com/otn-pub/java/jdk/8u92-b14/jdk-8u92-linux-x64.tar.gz\r\n######################################################################## 100.0%\r\n==> Warning: The contents of\r\n  the archive\r\n   look like HTML.\r\n  The checksum will likely be bad.  If it is, you can use\r\n  'spack clean <package>' to remove the bad archive, then\r\n  fix your internet gateway issue and install again.\r\n==> Error: ChecksumError: md5 checksum failed for /isilon/Analysis/scratch/hartzelg/spack/spack-jdk-test/var/spack/stage/jdk-8u92-lqg2aamhdvr7l6uxxpvo3quogxpaj2c4/jdk-8u92-linux-x64.tar.gz\r\n    Expected 65a1cc17ea362453a6e0eb4f13be76e4 but got 81ee08846975d4b8d46acf3b6eddf103\r\n/isilon/Analysis/scratch/hartzelg/spack/spack-jdk-test/lib/spack/spack/package.py:952, in do_fetch:\r\n     920      def do_fetch(self, mirror_only=False):\r\n     921          \"\"\"\r\n     922          Creates a stage directory and downloads the tarball for this package.\r\n     923          Working directory will be set to the stage directory.\r\n     924          \"\"\"\r\n     925          if not self.spec.concrete:\r\n     926              raise ValueError(\"Can only fetch concrete packages.\")\r\n     927\r\n     928          start_time = time.time()\r\n     929          if spack.do_checksum and self.version not in self.versions:\r\n     930              tty.warn(\"There is no checksum on file to fetch %s safely.\" %\r\n     931                       self.spec.format('$_$@'))\r\n     932\r\n     933              # Ask the user whether to skip the checksum if we're\r\n     934              # interactive, but just fail if non-interactive.\r\n     935              ck_msg = \"Add a checksum or use --no-checksum to skip this check.\"\r\n     936              ignore_checksum = False\r\n     937              if sys.stdout.isatty():\r\n     938                  ignore_checksum = tty.get_yes_or_no(\"  Fetch anyway?\",\r\n     939                                                      default=False)\r\n     940                  if ignore_checksum:\r\n     941                      tty.msg(\"Fetching with no checksum.\", ck_msg)\r\n     942\r\n     943              if not ignore_checksum:\r\n     944                  raise FetchError(\"Will not fetch %s\" %\r\n     945                                   self.spec.format('$_$@'), ck_msg)\r\n     946\r\n     947          self.stage.fetch(mirror_only)\r\n     948\r\n     949          self._fetch_time = time.time() - start_time\r\n     950\r\n     951          if spack.do_checksum and self.version in self.versions:\r\n  >> 952              self.stage.check()\r\n     953\r\n     954          self.stage.cache_local()\r\n```\r\n\r\nWhat would it take to rework the fetch stage to generate a helpful message?"}}
{"actor":{"display_login":"hartzell"}}