{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/13564","repository_url":"https://api.github.com/repos/edx/edx-platform","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/13564/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/13564/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/13564/events","html_url":"https://github.com/edx/edx-platform/pull/13564","id":179162381,"number":13564,"title":"Handle when no video transcript uploaded for a language","user":{"login":"mushtaqak","id":6991154,"avatar_url":"https://avatars.githubusercontent.com/u/6991154?v=3","gravatar_id":"","url":"https://api.github.com/users/mushtaqak","html_url":"https://github.com/mushtaqak","followers_url":"https://api.github.com/users/mushtaqak/followers","following_url":"https://api.github.com/users/mushtaqak/following{/other_user}","gists_url":"https://api.github.com/users/mushtaqak/gists{/gist_id}","starred_url":"https://api.github.com/users/mushtaqak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mushtaqak/subscriptions","organizations_url":"https://api.github.com/users/mushtaqak/orgs","repos_url":"https://api.github.com/users/mushtaqak/repos","events_url":"https://api.github.com/users/mushtaqak/events{/privacy}","received_events_url":"https://api.github.com/users/mushtaqak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-26T07:59:10Z","updated_at":"2016-09-27T12:19:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/13564","html_url":"https://github.com/edx/edx-platform/pull/13564","diff_url":"https://github.com/edx/edx-platform/pull/13564.diff","patch_url":"https://github.com/edx/edx-platform/pull/13564.patch"},"body":"### Description\r\n\r\nThis change handles the case when no transcript file is uploaded for a language then raise an exception that transcript file is not uploaded yet. This wouldn't let user save transcript language if no transcript file is uploaded for it.\r\n\r\nAlso, this change handles the videos that have language already added in the database but no transcript file was uploaded. This prevents showing of such languages as transcript on the video.\r\n\r\n### [TNL-5200](https://openedx.atlassian.net/browse/TNL-5200)\r\n\r\n### [Sandbox](https://videotranscript.sandbox.edx.org/)\r\n\r\n### Testing\r\n- [x] Unit\r\n- [x] Acceptance\r\n\r\n### Reviewers\r\nIf you've been tagged for review, please check your corresponding box once you've given the :+1:.\r\n\r\n- [ ] Code review: @muzaffaryousaf\r\n- [ ] Code review: @muhammad-ammar \r\n- [ ] Doc: @catong \r\n- [ ] Product: @sstack22 \r\n\r\n### Post-review\r\n- [ ] Squash commits"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/249848339","html_url":"https://github.com/edx/edx-platform/pull/13564#issuecomment-249848339","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/13564","id":249848339,"user":{"login":"mushtaqak","id":6991154,"avatar_url":"https://avatars.githubusercontent.com/u/6991154?v=3","gravatar_id":"","url":"https://api.github.com/users/mushtaqak","html_url":"https://github.com/mushtaqak","followers_url":"https://api.github.com/users/mushtaqak/followers","following_url":"https://api.github.com/users/mushtaqak/following{/other_user}","gists_url":"https://api.github.com/users/mushtaqak/gists{/gist_id}","starred_url":"https://api.github.com/users/mushtaqak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mushtaqak/subscriptions","organizations_url":"https://api.github.com/users/mushtaqak/orgs","repos_url":"https://api.github.com/users/mushtaqak/repos","events_url":"https://api.github.com/users/mushtaqak/events{/privacy}","received_events_url":"https://api.github.com/users/mushtaqak/received_events","type":"User","site_admin":false},"created_at":"2016-09-27T12:19:04Z","updated_at":"2016-09-27T12:19:04Z","body":"@sstack22 If you try to add a new transcript language and upload no transcript file [here in sandbox](https://studio-videotranscript.sandbox.edx.org/container/block-v1:edX+DemoX+Demo_Course+type@vertical+block@cc30e75f063e45c3b8bffdfec0b8b169?action=new), you would get the error message and corresponding transcript language is not saved now :\r\n\r\n<img width=\"1185\" alt=\"screen shot 2016-09-27 at 5 16 47 pm\" src=\"https://cloud.githubusercontent.com/assets/6991154/18872909/3f4fd922-84d6-11e6-82e8-2fba1d2e6a9c.png\">\r\n\r\n\r\nThe issue is the error message is too generic and does not tell what the error has occurred leading user ambiguity. \r\n\r\nI have tried to find the correct solution but to implement a good solution would take good amount of time.\r\n\r\nI have also tried to catch this exception at [_save_xblock](https://github.com/edx/edx-platform/blob/35ae67b530b53c675c8ad0baa038f01f3f74fe1f/cms/djangoapps/contentstore/views/item.py#L541) method which is also called when editor is saved, handling exception here outputs the correct error message :\r\n\r\n<img width=\"1186\" alt=\"screen shot 2016-09-27 at 5 16 14 pm\" src=\"https://cloud.githubusercontent.com/assets/6991154/18872918/4796ffde-84d6-11e6-8ded-1a8be4228260.png\">\r\n\r\nWhat do you think, we should do here ?\r\n"}}
{"actor":{"display_login":"mushtaqak"}}