{"action":"created","issue":{"url":"https://api.github.com/repos/angular-slider/angularjs-slider/issues/355","repository_url":"https://api.github.com/repos/angular-slider/angularjs-slider","labels_url":"https://api.github.com/repos/angular-slider/angularjs-slider/issues/355/labels{/name}","comments_url":"https://api.github.com/repos/angular-slider/angularjs-slider/issues/355/comments","events_url":"https://api.github.com/repos/angular-slider/angularjs-slider/issues/355/events","html_url":"https://github.com/angular-slider/angularjs-slider/issues/355","id":161900153,"number":355,"title":"Changing the way to set label to increase customizability","user":{"login":"Liooo","id":1630378,"avatar_url":"https://avatars.githubusercontent.com/u/1630378?v=3","gravatar_id":"","url":"https://api.github.com/users/Liooo","html_url":"https://github.com/Liooo","followers_url":"https://api.github.com/users/Liooo/followers","following_url":"https://api.github.com/users/Liooo/following{/other_user}","gists_url":"https://api.github.com/users/Liooo/gists{/gist_id}","starred_url":"https://api.github.com/users/Liooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Liooo/subscriptions","organizations_url":"https://api.github.com/users/Liooo/orgs","repos_url":"https://api.github.com/users/Liooo/repos","events_url":"https://api.github.com/users/Liooo/events{/privacy}","received_events_url":"https://api.github.com/users/Liooo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular-slider/angularjs-slider/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-06-23T11:28:33Z","updated_at":"2016-07-08T13:04:17Z","closed_at":null,"body":"## Problem\r\nThe library doesn't have capability to customize label using angular directive.\r\n\r\n## Solution\r\nExposing variables that store label strings on the template's scope, rather than setting with `$.html()`\r\nHere's the [quick simple code change](https://github.com/liooo/angularjs-slider/commit/1b2ccbe010d66df1a31911ea4e7fc0b45b2db874).\r\n\r\nand here's the [jsfiddle](https://jsfiddle.net/apm79kcf/6/). \r\n\r\ni roughly looked through the code, and noticed i still need to fix the following things, in addition to the change above.\r\n\r\n1. [the logic to recalcute the dimension](https://github.com/angular-slider/angularjs-slider/blob/master/src/rzslider.js#l764-l774)\r\n2. use css `display:hide` rather than `opacity:0` to hide combo label or model/high label as they switch, in case for example there's ng-click attached on either of the element ([written here](https://github.com/angular-slider/angularjs-slider/blob/master/src/rzslider.js#L1262))\r\n3. leaving the backward compatibility (but probably we don't need `translate` option in the future if we're doing this)\r\n\r\n\r\n## Question\r\nwhat do you guys think of this idea and the solution?\r\n"},"comment":{"url":"https://api.github.com/repos/angular-slider/angularjs-slider/issues/comments/231353891","html_url":"https://github.com/angular-slider/angularjs-slider/issues/355#issuecomment-231353891","issue_url":"https://api.github.com/repos/angular-slider/angularjs-slider/issues/355","id":231353891,"user":{"login":"ValentinH","id":2678610,"avatar_url":"https://avatars.githubusercontent.com/u/2678610?v=3","gravatar_id":"","url":"https://api.github.com/users/ValentinH","html_url":"https://github.com/ValentinH","followers_url":"https://api.github.com/users/ValentinH/followers","following_url":"https://api.github.com/users/ValentinH/following{/other_user}","gists_url":"https://api.github.com/users/ValentinH/gists{/gist_id}","starred_url":"https://api.github.com/users/ValentinH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ValentinH/subscriptions","organizations_url":"https://api.github.com/users/ValentinH/orgs","repos_url":"https://api.github.com/users/ValentinH/repos","events_url":"https://api.github.com/users/ValentinH/events{/privacy}","received_events_url":"https://api.github.com/users/ValentinH/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T13:04:17Z","updated_at":"2016-07-08T13:04:17Z","body":"OK So I think that the  #358 pull request corresponds to what you need."}}
{"actor":{"display_login":"ValentinH"}}