{"action":"created","comment":{"url":"https://api.github.com/repos/NancyFx/Nancy/pulls/comments/54337760","id":54337760,"diff_hunk":"@@ -0,0 +1,217 @@\n+﻿namespace Nancy.Json.Simple\r\n+{\r\n+    using System;\r\n+    using System.Collections.Generic;\r\n+    using System.Globalization;\r\n+    using System.Linq;\r\n+    using Nancy.Extensions;\r\n+\r\n+    internal class NancySerializationStrategy : PocoJsonSerializerStrategy\r","path":"src/Nancy/Json/Simple/NancySerializationStrategy.cs","position":9,"original_position":9,"commit_id":"9d29b5304d7381846f23d1741cb517cfbe395448","original_commit_id":"9d29b5304d7381846f23d1741cb517cfbe395448","user":{"login":"jchannon","id":105126,"avatar_url":"https://avatars.githubusercontent.com/u/105126?v=3","gravatar_id":"","url":"https://api.github.com/users/jchannon","html_url":"https://github.com/jchannon","followers_url":"https://api.github.com/users/jchannon/followers","following_url":"https://api.github.com/users/jchannon/following{/other_user}","gists_url":"https://api.github.com/users/jchannon/gists{/gist_id}","starred_url":"https://api.github.com/users/jchannon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchannon/subscriptions","organizations_url":"https://api.github.com/users/jchannon/orgs","repos_url":"https://api.github.com/users/jchannon/repos","events_url":"https://api.github.com/users/jchannon/events{/privacy}","received_events_url":"https://api.github.com/users/jchannon/received_events","type":"User","site_admin":false},"body":"problem with this is SimpleJson is marked as internal via an ifdef, we can change that to public if needs be but as it stands there would be an issue as this would be public but its inherited type would be internal. What should be done?","created_at":"2016-02-27T19:10:48Z","updated_at":"2016-02-27T19:10:48Z","html_url":"https://github.com/NancyFx/Nancy/pull/2313#discussion_r54337760","pull_request_url":"https://api.github.com/repos/NancyFx/Nancy/pulls/2313","_links":{"self":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/comments/54337760"},"html":{"href":"https://github.com/NancyFx/Nancy/pull/2313#discussion_r54337760"},"pull_request":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/2313"}}},"pull_request":{"url":"https://api.github.com/repos/NancyFx/Nancy/pulls/2313","id":60682416,"html_url":"https://github.com/NancyFx/Nancy/pull/2313","diff_url":"https://github.com/NancyFx/Nancy/pull/2313.diff","patch_url":"https://github.com/NancyFx/Nancy/pull/2313.patch","issue_url":"https://api.github.com/repos/NancyFx/Nancy/issues/2313","number":2313,"state":"open","locked":false,"title":"Replace internal json serialization with SimpleJson","user":{"login":"jasonmead","id":156773,"avatar_url":"https://avatars.githubusercontent.com/u/156773?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonmead","html_url":"https://github.com/jasonmead","followers_url":"https://api.github.com/users/jasonmead/followers","following_url":"https://api.github.com/users/jasonmead/following{/other_user}","gists_url":"https://api.github.com/users/jasonmead/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmead/subscriptions","organizations_url":"https://api.github.com/users/jasonmead/orgs","repos_url":"https://api.github.com/users/jasonmead/repos","events_url":"https://api.github.com/users/jasonmead/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmead/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-25T14:01:13Z","updated_at":"2016-02-27T19:10:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43e37b06dcf6923216ebff3f062b4d973764ca9a","assignee":null,"milestone":{"url":"https://api.github.com/repos/NancyFx/Nancy/milestones/38","html_url":"https://github.com/NancyFx/Nancy/milestones/2.0","labels_url":"https://api.github.com/repos/NancyFx/Nancy/milestones/38/labels","id":965127,"number":38,"title":"2.0","description":"Authentication update to use the (horrible) .net 4.5 style ClaimsPrincipal.","creator":{"login":"grumpydev","id":527013,"avatar_url":"https://avatars.githubusercontent.com/u/527013?v=3","gravatar_id":"","url":"https://api.github.com/users/grumpydev","html_url":"https://github.com/grumpydev","followers_url":"https://api.github.com/users/grumpydev/followers","following_url":"https://api.github.com/users/grumpydev/following{/other_user}","gists_url":"https://api.github.com/users/grumpydev/gists{/gist_id}","starred_url":"https://api.github.com/users/grumpydev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grumpydev/subscriptions","organizations_url":"https://api.github.com/users/grumpydev/orgs","repos_url":"https://api.github.com/users/grumpydev/repos","events_url":"https://api.github.com/users/grumpydev/events{/privacy}","received_events_url":"https://api.github.com/users/grumpydev/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":110,"state":"open","created_at":"2015-02-04T09:08:48Z","updated_at":"2016-02-27T13:12:26Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/NancyFx/Nancy/pulls/2313/commits","review_comments_url":"https://api.github.com/repos/NancyFx/Nancy/pulls/2313/comments","review_comment_url":"https://api.github.com/repos/NancyFx/Nancy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NancyFx/Nancy/issues/2313/comments","statuses_url":"https://api.github.com/repos/NancyFx/Nancy/statuses/9d29b5304d7381846f23d1741cb517cfbe395448","head":{"label":"jasonmead:SimpleJson","ref":"SimpleJson","sha":"9d29b5304d7381846f23d1741cb517cfbe395448","user":{"login":"jasonmead","id":156773,"avatar_url":"https://avatars.githubusercontent.com/u/156773?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonmead","html_url":"https://github.com/jasonmead","followers_url":"https://api.github.com/users/jasonmead/followers","following_url":"https://api.github.com/users/jasonmead/following{/other_user}","gists_url":"https://api.github.com/users/jasonmead/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmead/subscriptions","organizations_url":"https://api.github.com/users/jasonmead/orgs","repos_url":"https://api.github.com/users/jasonmead/repos","events_url":"https://api.github.com/users/jasonmead/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmead/received_events","type":"User","site_admin":false},"repo":{"id":47803152,"name":"Nancy","full_name":"jasonmead/Nancy","owner":{"login":"jasonmead","id":156773,"avatar_url":"https://avatars.githubusercontent.com/u/156773?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonmead","html_url":"https://github.com/jasonmead","followers_url":"https://api.github.com/users/jasonmead/followers","following_url":"https://api.github.com/users/jasonmead/following{/other_user}","gists_url":"https://api.github.com/users/jasonmead/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmead/subscriptions","organizations_url":"https://api.github.com/users/jasonmead/orgs","repos_url":"https://api.github.com/users/jasonmead/repos","events_url":"https://api.github.com/users/jasonmead/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmead/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasonmead/Nancy","description":"Lightweight, low-ceremony, framework for building HTTP based services on .Net and Mono","fork":true,"url":"https://api.github.com/repos/jasonmead/Nancy","forks_url":"https://api.github.com/repos/jasonmead/Nancy/forks","keys_url":"https://api.github.com/repos/jasonmead/Nancy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasonmead/Nancy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasonmead/Nancy/teams","hooks_url":"https://api.github.com/repos/jasonmead/Nancy/hooks","issue_events_url":"https://api.github.com/repos/jasonmead/Nancy/issues/events{/number}","events_url":"https://api.github.com/repos/jasonmead/Nancy/events","assignees_url":"https://api.github.com/repos/jasonmead/Nancy/assignees{/user}","branches_url":"https://api.github.com/repos/jasonmead/Nancy/branches{/branch}","tags_url":"https://api.github.com/repos/jasonmead/Nancy/tags","blobs_url":"https://api.github.com/repos/jasonmead/Nancy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasonmead/Nancy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasonmead/Nancy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasonmead/Nancy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasonmead/Nancy/statuses/{sha}","languages_url":"https://api.github.com/repos/jasonmead/Nancy/languages","stargazers_url":"https://api.github.com/repos/jasonmead/Nancy/stargazers","contributors_url":"https://api.github.com/repos/jasonmead/Nancy/contributors","subscribers_url":"https://api.github.com/repos/jasonmead/Nancy/subscribers","subscription_url":"https://api.github.com/repos/jasonmead/Nancy/subscription","commits_url":"https://api.github.com/repos/jasonmead/Nancy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasonmead/Nancy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasonmead/Nancy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasonmead/Nancy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasonmead/Nancy/contents/{+path}","compare_url":"https://api.github.com/repos/jasonmead/Nancy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasonmead/Nancy/merges","archive_url":"https://api.github.com/repos/jasonmead/Nancy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasonmead/Nancy/downloads","issues_url":"https://api.github.com/repos/jasonmead/Nancy/issues{/number}","pulls_url":"https://api.github.com/repos/jasonmead/Nancy/pulls{/number}","milestones_url":"https://api.github.com/repos/jasonmead/Nancy/milestones{/number}","notifications_url":"https://api.github.com/repos/jasonmead/Nancy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasonmead/Nancy/labels{/name}","releases_url":"https://api.github.com/repos/jasonmead/Nancy/releases{/id}","deployments_url":"https://api.github.com/repos/jasonmead/Nancy/deployments","created_at":"2015-12-11T03:37:35Z","updated_at":"2016-02-01T02:56:19Z","pushed_at":"2016-02-25T14:00:45Z","git_url":"git://github.com/jasonmead/Nancy.git","ssh_url":"git@github.com:jasonmead/Nancy.git","clone_url":"https://github.com/jasonmead/Nancy.git","svn_url":"https://github.com/jasonmead/Nancy","homepage":"http://nancyfx.org","size":42806,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NancyFx:master","ref":"master","sha":"c9c13782fb2d4aa46ac05260c7e6939c4f355d2a","user":{"login":"NancyFx","id":706659,"avatar_url":"https://avatars.githubusercontent.com/u/706659?v=3","gravatar_id":"","url":"https://api.github.com/users/NancyFx","html_url":"https://github.com/NancyFx","followers_url":"https://api.github.com/users/NancyFx/followers","following_url":"https://api.github.com/users/NancyFx/following{/other_user}","gists_url":"https://api.github.com/users/NancyFx/gists{/gist_id}","starred_url":"https://api.github.com/users/NancyFx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NancyFx/subscriptions","organizations_url":"https://api.github.com/users/NancyFx/orgs","repos_url":"https://api.github.com/users/NancyFx/repos","events_url":"https://api.github.com/users/NancyFx/events{/privacy}","received_events_url":"https://api.github.com/users/NancyFx/received_events","type":"Organization","site_admin":false},"repo":{"id":738250,"name":"Nancy","full_name":"NancyFx/Nancy","owner":{"login":"NancyFx","id":706659,"avatar_url":"https://avatars.githubusercontent.com/u/706659?v=3","gravatar_id":"","url":"https://api.github.com/users/NancyFx","html_url":"https://github.com/NancyFx","followers_url":"https://api.github.com/users/NancyFx/followers","following_url":"https://api.github.com/users/NancyFx/following{/other_user}","gists_url":"https://api.github.com/users/NancyFx/gists{/gist_id}","starred_url":"https://api.github.com/users/NancyFx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NancyFx/subscriptions","organizations_url":"https://api.github.com/users/NancyFx/orgs","repos_url":"https://api.github.com/users/NancyFx/repos","events_url":"https://api.github.com/users/NancyFx/events{/privacy}","received_events_url":"https://api.github.com/users/NancyFx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NancyFx/Nancy","description":"Lightweight, low-ceremony, framework for building HTTP based services on .Net and Mono","fork":false,"url":"https://api.github.com/repos/NancyFx/Nancy","forks_url":"https://api.github.com/repos/NancyFx/Nancy/forks","keys_url":"https://api.github.com/repos/NancyFx/Nancy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NancyFx/Nancy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NancyFx/Nancy/teams","hooks_url":"https://api.github.com/repos/NancyFx/Nancy/hooks","issue_events_url":"https://api.github.com/repos/NancyFx/Nancy/issues/events{/number}","events_url":"https://api.github.com/repos/NancyFx/Nancy/events","assignees_url":"https://api.github.com/repos/NancyFx/Nancy/assignees{/user}","branches_url":"https://api.github.com/repos/NancyFx/Nancy/branches{/branch}","tags_url":"https://api.github.com/repos/NancyFx/Nancy/tags","blobs_url":"https://api.github.com/repos/NancyFx/Nancy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NancyFx/Nancy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NancyFx/Nancy/git/refs{/sha}","trees_url":"https://api.github.com/repos/NancyFx/Nancy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NancyFx/Nancy/statuses/{sha}","languages_url":"https://api.github.com/repos/NancyFx/Nancy/languages","stargazers_url":"https://api.github.com/repos/NancyFx/Nancy/stargazers","contributors_url":"https://api.github.com/repos/NancyFx/Nancy/contributors","subscribers_url":"https://api.github.com/repos/NancyFx/Nancy/subscribers","subscription_url":"https://api.github.com/repos/NancyFx/Nancy/subscription","commits_url":"https://api.github.com/repos/NancyFx/Nancy/commits{/sha}","git_commits_url":"https://api.github.com/repos/NancyFx/Nancy/git/commits{/sha}","comments_url":"https://api.github.com/repos/NancyFx/Nancy/comments{/number}","issue_comment_url":"https://api.github.com/repos/NancyFx/Nancy/issues/comments{/number}","contents_url":"https://api.github.com/repos/NancyFx/Nancy/contents/{+path}","compare_url":"https://api.github.com/repos/NancyFx/Nancy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NancyFx/Nancy/merges","archive_url":"https://api.github.com/repos/NancyFx/Nancy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NancyFx/Nancy/downloads","issues_url":"https://api.github.com/repos/NancyFx/Nancy/issues{/number}","pulls_url":"https://api.github.com/repos/NancyFx/Nancy/pulls{/number}","milestones_url":"https://api.github.com/repos/NancyFx/Nancy/milestones{/number}","notifications_url":"https://api.github.com/repos/NancyFx/Nancy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NancyFx/Nancy/labels{/name}","releases_url":"https://api.github.com/repos/NancyFx/Nancy/releases{/id}","deployments_url":"https://api.github.com/repos/NancyFx/Nancy/deployments","created_at":"2010-06-24T19:35:22Z","updated_at":"2016-02-26T22:04:36Z","pushed_at":"2016-02-27T13:12:26Z","git_url":"git://github.com/NancyFx/Nancy.git","ssh_url":"git@github.com:NancyFx/Nancy.git","clone_url":"https://github.com/NancyFx/Nancy.git","svn_url":"https://github.com/NancyFx/Nancy","homepage":"http://nancyfx.org","size":62790,"stargazers_count":3788,"watchers_count":3788,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":995,"mirror_url":null,"open_issues_count":127,"forks":995,"open_issues":127,"watchers":3788,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/2313"},"html":{"href":"https://github.com/NancyFx/Nancy/pull/2313"},"issue":{"href":"https://api.github.com/repos/NancyFx/Nancy/issues/2313"},"comments":{"href":"https://api.github.com/repos/NancyFx/Nancy/issues/2313/comments"},"review_comments":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/2313/comments"},"review_comment":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/2313/commits"},"statuses":{"href":"https://api.github.com/repos/NancyFx/Nancy/statuses/9d29b5304d7381846f23d1741cb517cfbe395448"}}}}