{"action":"created","comment":{"url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/pulls/comments/63128909","id":63128909,"diff_hunk":"@@ -101,27 +103,44 @@ TeleopTwistJoy::TeleopTwistJoy(ros::NodeHandle* nh, ros::NodeHandle* nh_param)\n     nh_param->param<double>(\"scale_angular_turbo\",\n         pimpl_->scale_angular_turbo_map[\"yaw\"], pimpl_->scale_angular_map[\"yaw\"]);\n   }\n-\n-  ROS_INFO_NAMED(\"TeleopTwistJoy\", \"Teleop enable button %i.\", pimpl_->enable_button);\n-  ROS_INFO_COND_NAMED(pimpl_->enable_turbo_button >= 0, \"TeleopTwistJoy\",\n-      \"Turbo on button %i.\", pimpl_->enable_turbo_button);\n+  \n+  ROS_INFO_COND_NAMED(pimpl_->enable_button >= 0, \n+                      \"TeleopTwistJoy\",\n+                      \"Teleop enable button %i.\", \n+                      pimpl_->enable_button);\n+  ROS_INFO_COND_NAMED(pimpl_->enable_turbo_button >= 0, \n+                      \"TeleopTwistJoy\",\n+                      \"Turbo on button %i.\", \n+                      pimpl_->enable_turbo_button);\n+  ROS_INFO_COND_NAMED(pimpl_->break_button >= 0, \n+                      \"TeleopTwistJoy\",\n+                      \"Breaking on button %i.\", \n+                      pimpl_->break_button);\n \n   for (std::map<std::string, int>::iterator it = pimpl_->axis_linear_map.begin();\n       it != pimpl_->axis_linear_map.end(); ++it)\n   {\n-    ROS_INFO_NAMED(\"TeleopTwistJoy\", \"Linear axis %s on %i at scale %f.\",\n-    it->first.c_str(), it->second, pimpl_->scale_linear_map[it->first]);\n-    ROS_INFO_COND_NAMED(pimpl_->enable_turbo_button >= 0, \"TeleopTwistJoy\",\n-        \"Turbo for linear axis %s is scale %f.\", it->first.c_str(), pimpl_->scale_linear_turbo_map[it->first]);\n+     ROS_INFO_COND_NAMED(pimpl_->enable_button >= 0,","path":"src/teleop_twist_joy.cpp","position":47,"original_position":49,"commit_id":"426bfb0f8cfbe761ee4c6e5b98e0783e7b58d5ee","original_commit_id":"e6a27af5c52f769e7c389643372a4b5fa3b203a5","user":{"login":"tonybaltovski","id":2964763,"avatar_url":"https://avatars.githubusercontent.com/u/2964763?v=3","gravatar_id":"","url":"https://api.github.com/users/tonybaltovski","html_url":"https://github.com/tonybaltovski","followers_url":"https://api.github.com/users/tonybaltovski/followers","following_url":"https://api.github.com/users/tonybaltovski/following{/other_user}","gists_url":"https://api.github.com/users/tonybaltovski/gists{/gist_id}","starred_url":"https://api.github.com/users/tonybaltovski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonybaltovski/subscriptions","organizations_url":"https://api.github.com/users/tonybaltovski/orgs","repos_url":"https://api.github.com/users/tonybaltovski/repos","events_url":"https://api.github.com/users/tonybaltovski/events{/privacy}","received_events_url":"https://api.github.com/users/tonybaltovski/received_events","type":"User","site_admin":false},"body":"Extra space here and below.","created_at":"2016-05-13T03:23:36Z","updated_at":"2016-05-13T03:23:36Z","html_url":"https://github.com/ros-teleop/teleop_twist_joy/pull/22#discussion_r63128909","pull_request_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/pulls/comments/63128909"},"html":{"href":"https://github.com/ros-teleop/teleop_twist_joy/pull/22#discussion_r63128909"},"pull_request":{"href":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/pulls/22","id":69827559,"html_url":"https://github.com/ros-teleop/teleop_twist_joy/pull/22","diff_url":"https://github.com/ros-teleop/teleop_twist_joy/pull/22.diff","patch_url":"https://github.com/ros-teleop/teleop_twist_joy/pull/22.patch","issue_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/issues/22","number":22,"state":"open","locked":false,"title":"ENABLE_BUTTON is now optional. Also added a braking button.","user":{"login":"andresgongora","id":12051510,"avatar_url":"https://avatars.githubusercontent.com/u/12051510?v=3","gravatar_id":"","url":"https://api.github.com/users/andresgongora","html_url":"https://github.com/andresgongora","followers_url":"https://api.github.com/users/andresgongora/followers","following_url":"https://api.github.com/users/andresgongora/following{/other_user}","gists_url":"https://api.github.com/users/andresgongora/gists{/gist_id}","starred_url":"https://api.github.com/users/andresgongora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresgongora/subscriptions","organizations_url":"https://api.github.com/users/andresgongora/orgs","repos_url":"https://api.github.com/users/andresgongora/repos","events_url":"https://api.github.com/users/andresgongora/events{/privacy}","received_events_url":"https://api.github.com/users/andresgongora/received_events","type":"User","site_admin":false},"body":"**ENABLE_BUTTON**\r\nThe `enable_button` can be disabled by assigning joystick button \"-1\" to it. By default it is still assigned to button 0.\r\n\r\n~~**BREAK_BUTTON**~~ **BRAKE_BUTTON**\r\nBecause without `enable_button` the no-movement command would never be sent (it gets sent when enable_button is released) a breaking button was added which does exactly that.\r\n\r\nThe ~~`break_button`~~ `brake_button` is by default disabled (assigned to button \"-1\"). If enabled, breaking takes preference over any other kind of movement.\r\n","created_at":"2016-05-12T12:28:08Z","updated_at":"2016-05-13T03:23:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e461c072f76f169cc7876ff2b4996080a9d5f539","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/pulls/22/commits","review_comments_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/pulls/22/comments","review_comment_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/issues/22/comments","statuses_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/statuses/426bfb0f8cfbe761ee4c6e5b98e0783e7b58d5ee","head":{"label":"andresgongora:optional_enable_and_break_buttons","ref":"optional_enable_and_break_buttons","sha":"426bfb0f8cfbe761ee4c6e5b98e0783e7b58d5ee","user":{"login":"andresgongora","id":12051510,"avatar_url":"https://avatars.githubusercontent.com/u/12051510?v=3","gravatar_id":"","url":"https://api.github.com/users/andresgongora","html_url":"https://github.com/andresgongora","followers_url":"https://api.github.com/users/andresgongora/followers","following_url":"https://api.github.com/users/andresgongora/following{/other_user}","gists_url":"https://api.github.com/users/andresgongora/gists{/gist_id}","starred_url":"https://api.github.com/users/andresgongora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresgongora/subscriptions","organizations_url":"https://api.github.com/users/andresgongora/orgs","repos_url":"https://api.github.com/users/andresgongora/repos","events_url":"https://api.github.com/users/andresgongora/events{/privacy}","received_events_url":"https://api.github.com/users/andresgongora/received_events","type":"User","site_admin":false},"repo":{"id":58639086,"name":"teleop_twist_joy","full_name":"andresgongora/teleop_twist_joy","owner":{"login":"andresgongora","id":12051510,"avatar_url":"https://avatars.githubusercontent.com/u/12051510?v=3","gravatar_id":"","url":"https://api.github.com/users/andresgongora","html_url":"https://github.com/andresgongora","followers_url":"https://api.github.com/users/andresgongora/followers","following_url":"https://api.github.com/users/andresgongora/following{/other_user}","gists_url":"https://api.github.com/users/andresgongora/gists{/gist_id}","starred_url":"https://api.github.com/users/andresgongora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresgongora/subscriptions","organizations_url":"https://api.github.com/users/andresgongora/orgs","repos_url":"https://api.github.com/users/andresgongora/repos","events_url":"https://api.github.com/users/andresgongora/events{/privacy}","received_events_url":"https://api.github.com/users/andresgongora/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andresgongora/teleop_twist_joy","description":"Simple joystick teleop for twist robots","fork":true,"url":"https://api.github.com/repos/andresgongora/teleop_twist_joy","forks_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/forks","keys_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/teams","hooks_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/hooks","issue_events_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/issues/events{/number}","events_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/events","assignees_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/assignees{/user}","branches_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/branches{/branch}","tags_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/tags","blobs_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/git/refs{/sha}","trees_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/statuses/{sha}","languages_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/languages","stargazers_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/stargazers","contributors_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/contributors","subscribers_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/subscribers","subscription_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/subscription","commits_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/commits{/sha}","git_commits_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/git/commits{/sha}","comments_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/comments{/number}","issue_comment_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/issues/comments{/number}","contents_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/contents/{+path}","compare_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/merges","archive_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/downloads","issues_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/issues{/number}","pulls_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/pulls{/number}","milestones_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/milestones{/number}","notifications_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/labels{/name}","releases_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/releases{/id}","deployments_url":"https://api.github.com/repos/andresgongora/teleop_twist_joy/deployments","created_at":"2016-05-12T12:22:30Z","updated_at":"2016-05-12T12:22:31Z","pushed_at":"2016-05-12T16:23:18Z","git_url":"git://github.com/andresgongora/teleop_twist_joy.git","ssh_url":"git@github.com:andresgongora/teleop_twist_joy.git","clone_url":"https://github.com/andresgongora/teleop_twist_joy.git","svn_url":"https://github.com/andresgongora/teleop_twist_joy","homepage":null,"size":42,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"indigo-devel"}},"base":{"label":"ros-teleop:indigo-devel","ref":"indigo-devel","sha":"d397f08c364d31fa43c034d593e99619fc09e3df","user":{"login":"ros-teleop","id":8250152,"avatar_url":"https://avatars.githubusercontent.com/u/8250152?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-teleop","html_url":"https://github.com/ros-teleop","followers_url":"https://api.github.com/users/ros-teleop/followers","following_url":"https://api.github.com/users/ros-teleop/following{/other_user}","gists_url":"https://api.github.com/users/ros-teleop/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-teleop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-teleop/subscriptions","organizations_url":"https://api.github.com/users/ros-teleop/orgs","repos_url":"https://api.github.com/users/ros-teleop/repos","events_url":"https://api.github.com/users/ros-teleop/events{/privacy}","received_events_url":"https://api.github.com/users/ros-teleop/received_events","type":"Organization","site_admin":false},"repo":{"id":22066489,"name":"teleop_twist_joy","full_name":"ros-teleop/teleop_twist_joy","owner":{"login":"ros-teleop","id":8250152,"avatar_url":"https://avatars.githubusercontent.com/u/8250152?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-teleop","html_url":"https://github.com/ros-teleop","followers_url":"https://api.github.com/users/ros-teleop/followers","following_url":"https://api.github.com/users/ros-teleop/following{/other_user}","gists_url":"https://api.github.com/users/ros-teleop/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-teleop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-teleop/subscriptions","organizations_url":"https://api.github.com/users/ros-teleop/orgs","repos_url":"https://api.github.com/users/ros-teleop/repos","events_url":"https://api.github.com/users/ros-teleop/events{/privacy}","received_events_url":"https://api.github.com/users/ros-teleop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros-teleop/teleop_twist_joy","description":"Simple joystick teleop for twist robots","fork":false,"url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy","forks_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/forks","keys_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/teams","hooks_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/hooks","issue_events_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/issues/events{/number}","events_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/events","assignees_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/assignees{/user}","branches_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/branches{/branch}","tags_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/tags","blobs_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/statuses/{sha}","languages_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/languages","stargazers_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/stargazers","contributors_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/contributors","subscribers_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/subscribers","subscription_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/subscription","commits_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/contents/{+path}","compare_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/merges","archive_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/downloads","issues_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/issues{/number}","pulls_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/pulls{/number}","milestones_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/milestones{/number}","notifications_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/labels{/name}","releases_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/releases{/id}","deployments_url":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/deployments","created_at":"2014-07-21T14:00:56Z","updated_at":"2016-02-06T03:44:57Z","pushed_at":"2016-05-12T16:23:18Z","git_url":"git://github.com/ros-teleop/teleop_twist_joy.git","ssh_url":"git@github.com:ros-teleop/teleop_twist_joy.git","clone_url":"https://github.com/ros-teleop/teleop_twist_joy.git","svn_url":"https://github.com/ros-teleop/teleop_twist_joy","homepage":null,"size":64,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":2,"forks":15,"open_issues":2,"watchers":8,"default_branch":"indigo-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/pulls/22"},"html":{"href":"https://github.com/ros-teleop/teleop_twist_joy/pull/22"},"issue":{"href":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/issues/22"},"comments":{"href":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/ros-teleop/teleop_twist_joy/statuses/426bfb0f8cfbe761ee4c6e5b98e0783e7b58d5ee"}}}}