{"action":"created","comment":{"url":"https://api.github.com/repos/mybatis/generator/pulls/comments/50088241","id":50088241,"diff_hunk":"@@ -223,7 +224,11 @@ public String getFormattedContent(int indentLevel, boolean interfaceMethod) {\n                     comma = true;\r\n                 }\r\n \r\n-                sb.append(fqjt.getShortName());\r\n+                if(compilationUnit.getImportedTypes().contains(fqjt)) {\r\n+                    sb.append(fqjt.getShortName());\r\n+                } else {\r\n+                    sb.append(fqjt.getFullyQualifiedName());\r\n+                }\r\n             }\r","path":"core/mybatis-generator-core/src/main/java/org/mybatis/generator/api/dom/java/Method.java","position":40,"original_position":40,"commit_id":"e52c2bb8e43447e928c942af4b2eba2375333ede","original_commit_id":"e52c2bb8e43447e928c942af4b2eba2375333ede","user":{"login":"szediwy","id":4198982,"avatar_url":"https://avatars.githubusercontent.com/u/4198982?v=3","gravatar_id":"","url":"https://api.github.com/users/szediwy","html_url":"https://github.com/szediwy","followers_url":"https://api.github.com/users/szediwy/followers","following_url":"https://api.github.com/users/szediwy/following{/other_user}","gists_url":"https://api.github.com/users/szediwy/gists{/gist_id}","starred_url":"https://api.github.com/users/szediwy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szediwy/subscriptions","organizations_url":"https://api.github.com/users/szediwy/orgs","repos_url":"https://api.github.com/users/szediwy/repos","events_url":"https://api.github.com/users/szediwy/events{/privacy}","received_events_url":"https://api.github.com/users/szediwy/received_events","type":"User","site_admin":false},"body":"Probably forgot to do it :-) - thanks for the hint.\n\nZitat von Jeff Butler <notifications@github.com>:\n\n>> @@ -223,7 +224,11 @@ public String getFormattedContent(int  \n>> indentLevel, boolean interfaceMethod) {\n>>                      comma = true;\n>>                  }\n>>\n>> -                sb.append(fqjt.getShortName());\n>> +                if(compilationUnit.getImportedTypes().contains(fqjt)) {\n>> +                    sb.append(fqjt.getShortName());\n>> +                } else {\n>> +                    sb.append(fqjt.getFullyQualifiedName());\n>> +                }\n>>              }\n>\n> Why is this not a call to your `addTypeName` method also?\n>\n> ---\n> Reply to this email directly or view it on GitHub:\n> https://github.com/mybatis/generator/pull/63/files#r50047524\n\n\n\n","created_at":"2016-01-19T09:19:08Z","updated_at":"2016-01-19T09:19:08Z","html_url":"https://github.com/mybatis/generator/pull/63#discussion_r50088241","pull_request_url":"https://api.github.com/repos/mybatis/generator/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/mybatis/generator/pulls/comments/50088241"},"html":{"href":"https://github.com/mybatis/generator/pull/63#discussion_r50088241"},"pull_request":{"href":"https://api.github.com/repos/mybatis/generator/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/mybatis/generator/pulls/63","id":55334980,"html_url":"https://github.com/mybatis/generator/pull/63","diff_url":"https://github.com/mybatis/generator/pull/63.diff","patch_url":"https://github.com/mybatis/generator/pull/63.patch","issue_url":"https://api.github.com/repos/mybatis/generator/issues/63","number":63,"state":"open","locked":false,"title":"Added simple support for non-imported java types.","user":{"login":"szediwy","id":4198982,"avatar_url":"https://avatars.githubusercontent.com/u/4198982?v=3","gravatar_id":"","url":"https://api.github.com/users/szediwy","html_url":"https://github.com/szediwy","followers_url":"https://api.github.com/users/szediwy/followers","following_url":"https://api.github.com/users/szediwy/following{/other_user}","gists_url":"https://api.github.com/users/szediwy/gists{/gist_id}","starred_url":"https://api.github.com/users/szediwy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szediwy/subscriptions","organizations_url":"https://api.github.com/users/szediwy/orgs","repos_url":"https://api.github.com/users/szediwy/repos","events_url":"https://api.github.com/users/szediwy/events{/privacy}","received_events_url":"https://api.github.com/users/szediwy/received_events","type":"User","site_admin":false},"body":"This allows additional Java classes/interfaces with same name of already generated class lying in different packages.","created_at":"2016-01-07T12:58:48Z","updated_at":"2016-01-19T09:19:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a5586a323f5fb111f5ab6a2acf36cede6a7fffd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mybatis/generator/pulls/63/commits","review_comments_url":"https://api.github.com/repos/mybatis/generator/pulls/63/comments","review_comment_url":"https://api.github.com/repos/mybatis/generator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mybatis/generator/issues/63/comments","statuses_url":"https://api.github.com/repos/mybatis/generator/statuses/e52c2bb8e43447e928c942af4b2eba2375333ede","head":{"label":"szediwy:master","ref":"master","sha":"e52c2bb8e43447e928c942af4b2eba2375333ede","user":{"login":"szediwy","id":4198982,"avatar_url":"https://avatars.githubusercontent.com/u/4198982?v=3","gravatar_id":"","url":"https://api.github.com/users/szediwy","html_url":"https://github.com/szediwy","followers_url":"https://api.github.com/users/szediwy/followers","following_url":"https://api.github.com/users/szediwy/following{/other_user}","gists_url":"https://api.github.com/users/szediwy/gists{/gist_id}","starred_url":"https://api.github.com/users/szediwy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szediwy/subscriptions","organizations_url":"https://api.github.com/users/szediwy/orgs","repos_url":"https://api.github.com/users/szediwy/repos","events_url":"https://api.github.com/users/szediwy/events{/privacy}","received_events_url":"https://api.github.com/users/szediwy/received_events","type":"User","site_admin":false},"repo":{"id":49199705,"name":"generator","full_name":"szediwy/generator","owner":{"login":"szediwy","id":4198982,"avatar_url":"https://avatars.githubusercontent.com/u/4198982?v=3","gravatar_id":"","url":"https://api.github.com/users/szediwy","html_url":"https://github.com/szediwy","followers_url":"https://api.github.com/users/szediwy/followers","following_url":"https://api.github.com/users/szediwy/following{/other_user}","gists_url":"https://api.github.com/users/szediwy/gists{/gist_id}","starred_url":"https://api.github.com/users/szediwy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szediwy/subscriptions","organizations_url":"https://api.github.com/users/szediwy/orgs","repos_url":"https://api.github.com/users/szediwy/repos","events_url":"https://api.github.com/users/szediwy/events{/privacy}","received_events_url":"https://api.github.com/users/szediwy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/szediwy/generator","description":"A code generator for MyBatis and iBATIS.","fork":true,"url":"https://api.github.com/repos/szediwy/generator","forks_url":"https://api.github.com/repos/szediwy/generator/forks","keys_url":"https://api.github.com/repos/szediwy/generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/szediwy/generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/szediwy/generator/teams","hooks_url":"https://api.github.com/repos/szediwy/generator/hooks","issue_events_url":"https://api.github.com/repos/szediwy/generator/issues/events{/number}","events_url":"https://api.github.com/repos/szediwy/generator/events","assignees_url":"https://api.github.com/repos/szediwy/generator/assignees{/user}","branches_url":"https://api.github.com/repos/szediwy/generator/branches{/branch}","tags_url":"https://api.github.com/repos/szediwy/generator/tags","blobs_url":"https://api.github.com/repos/szediwy/generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/szediwy/generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/szediwy/generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/szediwy/generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/szediwy/generator/statuses/{sha}","languages_url":"https://api.github.com/repos/szediwy/generator/languages","stargazers_url":"https://api.github.com/repos/szediwy/generator/stargazers","contributors_url":"https://api.github.com/repos/szediwy/generator/contributors","subscribers_url":"https://api.github.com/repos/szediwy/generator/subscribers","subscription_url":"https://api.github.com/repos/szediwy/generator/subscription","commits_url":"https://api.github.com/repos/szediwy/generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/szediwy/generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/szediwy/generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/szediwy/generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/szediwy/generator/contents/{+path}","compare_url":"https://api.github.com/repos/szediwy/generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/szediwy/generator/merges","archive_url":"https://api.github.com/repos/szediwy/generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/szediwy/generator/downloads","issues_url":"https://api.github.com/repos/szediwy/generator/issues{/number}","pulls_url":"https://api.github.com/repos/szediwy/generator/pulls{/number}","milestones_url":"https://api.github.com/repos/szediwy/generator/milestones{/number}","notifications_url":"https://api.github.com/repos/szediwy/generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/szediwy/generator/labels{/name}","releases_url":"https://api.github.com/repos/szediwy/generator/releases{/id}","created_at":"2016-01-07T11:05:56Z","updated_at":"2016-01-07T11:05:59Z","pushed_at":"2016-01-07T15:20:37Z","git_url":"git://github.com/szediwy/generator.git","ssh_url":"git@github.com:szediwy/generator.git","clone_url":"https://github.com/szediwy/generator.git","svn_url":"https://github.com/szediwy/generator","homepage":"http://www.mybatis.org/generator/","size":24317,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mybatis:master","ref":"master","sha":"62d4b203305168645b72cc96e6a19abff1b918ae","user":{"login":"mybatis","id":1483254,"avatar_url":"https://avatars.githubusercontent.com/u/1483254?v=3","gravatar_id":"","url":"https://api.github.com/users/mybatis","html_url":"https://github.com/mybatis","followers_url":"https://api.github.com/users/mybatis/followers","following_url":"https://api.github.com/users/mybatis/following{/other_user}","gists_url":"https://api.github.com/users/mybatis/gists{/gist_id}","starred_url":"https://api.github.com/users/mybatis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mybatis/subscriptions","organizations_url":"https://api.github.com/users/mybatis/orgs","repos_url":"https://api.github.com/users/mybatis/repos","events_url":"https://api.github.com/users/mybatis/events{/privacy}","received_events_url":"https://api.github.com/users/mybatis/received_events","type":"Organization","site_admin":false},"repo":{"id":8121707,"name":"generator","full_name":"mybatis/generator","owner":{"login":"mybatis","id":1483254,"avatar_url":"https://avatars.githubusercontent.com/u/1483254?v=3","gravatar_id":"","url":"https://api.github.com/users/mybatis","html_url":"https://github.com/mybatis","followers_url":"https://api.github.com/users/mybatis/followers","following_url":"https://api.github.com/users/mybatis/following{/other_user}","gists_url":"https://api.github.com/users/mybatis/gists{/gist_id}","starred_url":"https://api.github.com/users/mybatis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mybatis/subscriptions","organizations_url":"https://api.github.com/users/mybatis/orgs","repos_url":"https://api.github.com/users/mybatis/repos","events_url":"https://api.github.com/users/mybatis/events{/privacy}","received_events_url":"https://api.github.com/users/mybatis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mybatis/generator","description":"A code generator for MyBatis and iBATIS.","fork":false,"url":"https://api.github.com/repos/mybatis/generator","forks_url":"https://api.github.com/repos/mybatis/generator/forks","keys_url":"https://api.github.com/repos/mybatis/generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mybatis/generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mybatis/generator/teams","hooks_url":"https://api.github.com/repos/mybatis/generator/hooks","issue_events_url":"https://api.github.com/repos/mybatis/generator/issues/events{/number}","events_url":"https://api.github.com/repos/mybatis/generator/events","assignees_url":"https://api.github.com/repos/mybatis/generator/assignees{/user}","branches_url":"https://api.github.com/repos/mybatis/generator/branches{/branch}","tags_url":"https://api.github.com/repos/mybatis/generator/tags","blobs_url":"https://api.github.com/repos/mybatis/generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mybatis/generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mybatis/generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/mybatis/generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mybatis/generator/statuses/{sha}","languages_url":"https://api.github.com/repos/mybatis/generator/languages","stargazers_url":"https://api.github.com/repos/mybatis/generator/stargazers","contributors_url":"https://api.github.com/repos/mybatis/generator/contributors","subscribers_url":"https://api.github.com/repos/mybatis/generator/subscribers","subscription_url":"https://api.github.com/repos/mybatis/generator/subscription","commits_url":"https://api.github.com/repos/mybatis/generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/mybatis/generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/mybatis/generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/mybatis/generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/mybatis/generator/contents/{+path}","compare_url":"https://api.github.com/repos/mybatis/generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mybatis/generator/merges","archive_url":"https://api.github.com/repos/mybatis/generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mybatis/generator/downloads","issues_url":"https://api.github.com/repos/mybatis/generator/issues{/number}","pulls_url":"https://api.github.com/repos/mybatis/generator/pulls{/number}","milestones_url":"https://api.github.com/repos/mybatis/generator/milestones{/number}","notifications_url":"https://api.github.com/repos/mybatis/generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mybatis/generator/labels{/name}","releases_url":"https://api.github.com/repos/mybatis/generator/releases{/id}","created_at":"2013-02-10T11:14:50Z","updated_at":"2016-01-19T02:42:03Z","pushed_at":"2016-01-17T20:45:20Z","git_url":"git://github.com/mybatis/generator.git","ssh_url":"git@github.com:mybatis/generator.git","clone_url":"https://github.com/mybatis/generator.git","svn_url":"https://github.com/mybatis/generator","homepage":"http://www.mybatis.org/generator/","size":26070,"stargazers_count":405,"watchers_count":405,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":423,"mirror_url":null,"open_issues_count":11,"forks":423,"open_issues":11,"watchers":405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mybatis/generator/pulls/63"},"html":{"href":"https://github.com/mybatis/generator/pull/63"},"issue":{"href":"https://api.github.com/repos/mybatis/generator/issues/63"},"comments":{"href":"https://api.github.com/repos/mybatis/generator/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/mybatis/generator/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/mybatis/generator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mybatis/generator/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/mybatis/generator/statuses/e52c2bb8e43447e928c942af4b2eba2375333ede"}}}}