{"action":"created","issue":{"url":"https://api.github.com/repos/MatAtBread/nodent-runtime/issues/4","repository_url":"https://api.github.com/repos/MatAtBread/nodent-runtime","labels_url":"https://api.github.com/repos/MatAtBread/nodent-runtime/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/MatAtBread/nodent-runtime/issues/4/comments","events_url":"https://api.github.com/repos/MatAtBread/nodent-runtime/issues/4/events","html_url":"https://github.com/MatAtBread/nodent-runtime/pull/4","id":185240161,"number":4,"title":"Add build that preserves stringification.","user":{"login":"STRML","id":1197375,"avatar_url":"https://avatars.githubusercontent.com/u/1197375?v=3","gravatar_id":"","url":"https://api.github.com/users/STRML","html_url":"https://github.com/STRML","followers_url":"https://api.github.com/users/STRML/followers","following_url":"https://api.github.com/users/STRML/following{/other_user}","gists_url":"https://api.github.com/users/STRML/gists{/gist_id}","starred_url":"https://api.github.com/users/STRML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STRML/subscriptions","organizations_url":"https://api.github.com/users/STRML/orgs","repos_url":"https://api.github.com/users/STRML/repos","events_url":"https://api.github.com/users/STRML/events{/privacy}","received_events_url":"https://api.github.com/users/STRML/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-25T21:34:08Z","updated_at":"2016-10-26T15:19:57Z","closed_at":"2016-10-26T08:06:16Z","pull_request":{"url":"https://api.github.com/repos/MatAtBread/nodent-runtime/pulls/4","html_url":"https://github.com/MatAtBread/nodent-runtime/pull/4","diff_url":"https://github.com/MatAtBread/nodent-runtime/pull/4.diff","patch_url":"https://github.com/MatAtBread/nodent-runtime/pull/4.patch"},"body":"For use with fast-async, it is important that both $asyncbind\r\nand $asyncspawn can be stringified and have no dependencies.\r\n\r\nTo do so, we require the contents of their dependencies and\r\ninline them.\r\n\r\nBoth unminified and minified source are written. By default,\r\nthe minified source is used.\r\n\r\nThis reduces runtime size slightly (due to the removal of\r\nprocessIncludes()) and no longer uses eval, making it compatible\r\nwith a strict Content-Security-Policy.\r\n\r\nFixes #3"},"comment":{"url":"https://api.github.com/repos/MatAtBread/nodent-runtime/issues/comments/256380277","html_url":"https://github.com/MatAtBread/nodent-runtime/pull/4#issuecomment-256380277","issue_url":"https://api.github.com/repos/MatAtBread/nodent-runtime/issues/4","id":256380277,"user":{"login":"matAtWork","id":9590115,"avatar_url":"https://avatars.githubusercontent.com/u/9590115?v=3","gravatar_id":"","url":"https://api.github.com/users/matAtWork","html_url":"https://github.com/matAtWork","followers_url":"https://api.github.com/users/matAtWork/followers","following_url":"https://api.github.com/users/matAtWork/following{/other_user}","gists_url":"https://api.github.com/users/matAtWork/gists{/gist_id}","starred_url":"https://api.github.com/users/matAtWork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matAtWork/subscriptions","organizations_url":"https://api.github.com/users/matAtWork/orgs","repos_url":"https://api.github.com/users/matAtWork/repos","events_url":"https://api.github.com/users/matAtWork/events{/privacy}","received_events_url":"https://api.github.com/users/matAtWork/received_events","type":"User","site_admin":false},"created_at":"2016-10-26T15:19:57Z","updated_at":"2016-10-26T15:19:57Z","body":"You're right in many respects. \r\n\r\nAvoiding Uglify is a personal thing - I just like to keep dependencies to a minimum.\r\n\r\nUnless I misunderstood something, any changes to zousan and thenable.js would need to be done twice as legacy code can refer to either the 'runtime' (quite new) or the files directly, and placing a `require` in the runtime stops it being serializable with no dependencies. I don't encourage people to refer to specific implementation files, but before the runtime existed as a separate module, that's what people did.\r\n\r\nI really hope NOT to add anything new to the runtime (the two functions have basically existed forever, and external interface hasn't changed in maybe 2 years). In fact, the later builds have a \"no runtime\" which puts the burden into your Promise implementation.\r\n\r\nThe final point (not using `/dist`) was simply to avoid making unnecessary changes - I just ran into that in https://github.com/MatAtBread/fast-async/issues/24 where a small change (not generating the runtime if the file contained no asyncs/awaits) broke someone's build. I'm just happier extending the interface to meet your needs than changing an existing one.\r\n\r\nOne issue here is that fast-async (nodent via babel) doesn't get the same level of testing as nodent by itself does - I just don't use babel enough, so I'm always more nervous about making changes.\r\n\r\n "}}
{"actor":{"display_login":"matAtWork"}}