{"action":"created","comment":{"url":"https://api.github.com/repos/parro-it/libui-node/pulls/comments/66680655","id":66680655,"diff_hunk":"@@ -1,4 +1,4 @@\n-const libui = require('.');\n+const libui = require('./index.js');","path":"example.js","position":2,"original_position":2,"commit_id":"8f05e8de70e600fd0da17f9861db76052ffbfc89","original_commit_id":"18c186c1f41a25a48fdf6294cefa6a471c55f2d7","user":{"login":"parro-it","id":11197111,"avatar_url":"https://avatars.githubusercontent.com/u/11197111?v=3","gravatar_id":"","url":"https://api.github.com/users/parro-it","html_url":"https://github.com/parro-it","followers_url":"https://api.github.com/users/parro-it/followers","following_url":"https://api.github.com/users/parro-it/following{/other_user}","gists_url":"https://api.github.com/users/parro-it/gists{/gist_id}","starred_url":"https://api.github.com/users/parro-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parro-it/subscriptions","organizations_url":"https://api.github.com/users/parro-it/orgs","repos_url":"https://api.github.com/users/parro-it/repos","events_url":"https://api.github.com/users/parro-it/events{/privacy}","received_events_url":"https://api.github.com/users/parro-it/received_events","type":"User","site_admin":false},"body":"Why this change? `require('.')` should be independent by the cwd and equivalent to `require('./index.js')`","created_at":"2016-06-10T21:03:06Z","updated_at":"2016-06-10T21:03:06Z","html_url":"https://github.com/parro-it/libui-node/pull/2#discussion_r66680655","pull_request_url":"https://api.github.com/repos/parro-it/libui-node/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/parro-it/libui-node/pulls/comments/66680655"},"html":{"href":"https://github.com/parro-it/libui-node/pull/2#discussion_r66680655"},"pull_request":{"href":"https://api.github.com/repos/parro-it/libui-node/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/parro-it/libui-node/pulls/2","id":73418597,"html_url":"https://github.com/parro-it/libui-node/pull/2","diff_url":"https://github.com/parro-it/libui-node/pull/2.diff","patch_url":"https://github.com/parro-it/libui-node/pull/2.patch","issue_url":"https://api.github.com/repos/parro-it/libui-node/issues/2","number":2,"state":"open","locked":false,"title":"Fix build on OS X","user":{"login":"jjrv","id":778781,"avatar_url":"https://avatars.githubusercontent.com/u/778781?v=3","gravatar_id":"","url":"https://api.github.com/users/jjrv","html_url":"https://github.com/jjrv","followers_url":"https://api.github.com/users/jjrv/followers","following_url":"https://api.github.com/users/jjrv/following{/other_user}","gists_url":"https://api.github.com/users/jjrv/gists{/gist_id}","starred_url":"https://api.github.com/users/jjrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjrv/subscriptions","organizations_url":"https://api.github.com/users/jjrv/orgs","repos_url":"https://api.github.com/users/jjrv/repos","events_url":"https://api.github.com/users/jjrv/events{/privacy}","received_events_url":"https://api.github.com/users/jjrv/received_events","type":"User","site_admin":false},"body":"`auto.gypi` and `auto-top.gypi` are specific to the user's environment so it would be better to remove them from Github and call `autogypi` from an `install` script, which could also compile libui.\r\n\r\nThe `libui` compiled library file name is different on OS X. It seems with these changes it works, also on Linux.\r\n","created_at":"2016-06-10T18:49:07Z","updated_at":"2016-06-10T21:03:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1e3d6f91f1d3aeb34460f9a43be6bf4b98b4d1a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/parro-it/libui-node/pulls/2/commits","review_comments_url":"https://api.github.com/repos/parro-it/libui-node/pulls/2/comments","review_comment_url":"https://api.github.com/repos/parro-it/libui-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/parro-it/libui-node/issues/2/comments","statuses_url":"https://api.github.com/repos/parro-it/libui-node/statuses/8f05e8de70e600fd0da17f9861db76052ffbfc89","head":{"label":"jjrv:master","ref":"master","sha":"8f05e8de70e600fd0da17f9861db76052ffbfc89","user":{"login":"jjrv","id":778781,"avatar_url":"https://avatars.githubusercontent.com/u/778781?v=3","gravatar_id":"","url":"https://api.github.com/users/jjrv","html_url":"https://github.com/jjrv","followers_url":"https://api.github.com/users/jjrv/followers","following_url":"https://api.github.com/users/jjrv/following{/other_user}","gists_url":"https://api.github.com/users/jjrv/gists{/gist_id}","starred_url":"https://api.github.com/users/jjrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjrv/subscriptions","organizations_url":"https://api.github.com/users/jjrv/orgs","repos_url":"https://api.github.com/users/jjrv/repos","events_url":"https://api.github.com/users/jjrv/events{/privacy}","received_events_url":"https://api.github.com/users/jjrv/received_events","type":"User","site_admin":false},"repo":{"id":60862322,"name":"libui-node","full_name":"jjrv/libui-node","owner":{"login":"jjrv","id":778781,"avatar_url":"https://avatars.githubusercontent.com/u/778781?v=3","gravatar_id":"","url":"https://api.github.com/users/jjrv","html_url":"https://github.com/jjrv","followers_url":"https://api.github.com/users/jjrv/followers","following_url":"https://api.github.com/users/jjrv/following{/other_user}","gists_url":"https://api.github.com/users/jjrv/gists{/gist_id}","starred_url":"https://api.github.com/users/jjrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjrv/subscriptions","organizations_url":"https://api.github.com/users/jjrv/orgs","repos_url":"https://api.github.com/users/jjrv/repos","events_url":"https://api.github.com/users/jjrv/events{/privacy}","received_events_url":"https://api.github.com/users/jjrv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jjrv/libui-node","description":"Node bindings for libui, an awesome native UI library for Unix, OSX and Windows","fork":true,"url":"https://api.github.com/repos/jjrv/libui-node","forks_url":"https://api.github.com/repos/jjrv/libui-node/forks","keys_url":"https://api.github.com/repos/jjrv/libui-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjrv/libui-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjrv/libui-node/teams","hooks_url":"https://api.github.com/repos/jjrv/libui-node/hooks","issue_events_url":"https://api.github.com/repos/jjrv/libui-node/issues/events{/number}","events_url":"https://api.github.com/repos/jjrv/libui-node/events","assignees_url":"https://api.github.com/repos/jjrv/libui-node/assignees{/user}","branches_url":"https://api.github.com/repos/jjrv/libui-node/branches{/branch}","tags_url":"https://api.github.com/repos/jjrv/libui-node/tags","blobs_url":"https://api.github.com/repos/jjrv/libui-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjrv/libui-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjrv/libui-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjrv/libui-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjrv/libui-node/statuses/{sha}","languages_url":"https://api.github.com/repos/jjrv/libui-node/languages","stargazers_url":"https://api.github.com/repos/jjrv/libui-node/stargazers","contributors_url":"https://api.github.com/repos/jjrv/libui-node/contributors","subscribers_url":"https://api.github.com/repos/jjrv/libui-node/subscribers","subscription_url":"https://api.github.com/repos/jjrv/libui-node/subscription","commits_url":"https://api.github.com/repos/jjrv/libui-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjrv/libui-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjrv/libui-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjrv/libui-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjrv/libui-node/contents/{+path}","compare_url":"https://api.github.com/repos/jjrv/libui-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjrv/libui-node/merges","archive_url":"https://api.github.com/repos/jjrv/libui-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjrv/libui-node/downloads","issues_url":"https://api.github.com/repos/jjrv/libui-node/issues{/number}","pulls_url":"https://api.github.com/repos/jjrv/libui-node/pulls{/number}","milestones_url":"https://api.github.com/repos/jjrv/libui-node/milestones{/number}","notifications_url":"https://api.github.com/repos/jjrv/libui-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjrv/libui-node/labels{/name}","releases_url":"https://api.github.com/repos/jjrv/libui-node/releases{/id}","deployments_url":"https://api.github.com/repos/jjrv/libui-node/deployments","created_at":"2016-06-10T16:33:59Z","updated_at":"2016-06-10T16:33:59Z","pushed_at":"2016-06-10T20:38:22Z","git_url":"git://github.com/jjrv/libui-node.git","ssh_url":"git@github.com:jjrv/libui-node.git","clone_url":"https://github.com/jjrv/libui-node.git","svn_url":"https://github.com/jjrv/libui-node","homepage":"","size":32,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"parro-it:master","ref":"master","sha":"9e5bf4f839532ee6641e08cf427f954ad1b570a2","user":{"login":"parro-it","id":11197111,"avatar_url":"https://avatars.githubusercontent.com/u/11197111?v=3","gravatar_id":"","url":"https://api.github.com/users/parro-it","html_url":"https://github.com/parro-it","followers_url":"https://api.github.com/users/parro-it/followers","following_url":"https://api.github.com/users/parro-it/following{/other_user}","gists_url":"https://api.github.com/users/parro-it/gists{/gist_id}","starred_url":"https://api.github.com/users/parro-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parro-it/subscriptions","organizations_url":"https://api.github.com/users/parro-it/orgs","repos_url":"https://api.github.com/users/parro-it/repos","events_url":"https://api.github.com/users/parro-it/events{/privacy}","received_events_url":"https://api.github.com/users/parro-it/received_events","type":"User","site_admin":false},"repo":{"id":59367691,"name":"libui-node","full_name":"parro-it/libui-node","owner":{"login":"parro-it","id":11197111,"avatar_url":"https://avatars.githubusercontent.com/u/11197111?v=3","gravatar_id":"","url":"https://api.github.com/users/parro-it","html_url":"https://github.com/parro-it","followers_url":"https://api.github.com/users/parro-it/followers","following_url":"https://api.github.com/users/parro-it/following{/other_user}","gists_url":"https://api.github.com/users/parro-it/gists{/gist_id}","starred_url":"https://api.github.com/users/parro-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parro-it/subscriptions","organizations_url":"https://api.github.com/users/parro-it/orgs","repos_url":"https://api.github.com/users/parro-it/repos","events_url":"https://api.github.com/users/parro-it/events{/privacy}","received_events_url":"https://api.github.com/users/parro-it/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/parro-it/libui-node","description":"Node bindings for libui, an awesome native UI library for Unix, OSX and Windows","fork":false,"url":"https://api.github.com/repos/parro-it/libui-node","forks_url":"https://api.github.com/repos/parro-it/libui-node/forks","keys_url":"https://api.github.com/repos/parro-it/libui-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parro-it/libui-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parro-it/libui-node/teams","hooks_url":"https://api.github.com/repos/parro-it/libui-node/hooks","issue_events_url":"https://api.github.com/repos/parro-it/libui-node/issues/events{/number}","events_url":"https://api.github.com/repos/parro-it/libui-node/events","assignees_url":"https://api.github.com/repos/parro-it/libui-node/assignees{/user}","branches_url":"https://api.github.com/repos/parro-it/libui-node/branches{/branch}","tags_url":"https://api.github.com/repos/parro-it/libui-node/tags","blobs_url":"https://api.github.com/repos/parro-it/libui-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parro-it/libui-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parro-it/libui-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/parro-it/libui-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parro-it/libui-node/statuses/{sha}","languages_url":"https://api.github.com/repos/parro-it/libui-node/languages","stargazers_url":"https://api.github.com/repos/parro-it/libui-node/stargazers","contributors_url":"https://api.github.com/repos/parro-it/libui-node/contributors","subscribers_url":"https://api.github.com/repos/parro-it/libui-node/subscribers","subscription_url":"https://api.github.com/repos/parro-it/libui-node/subscription","commits_url":"https://api.github.com/repos/parro-it/libui-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/parro-it/libui-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/parro-it/libui-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/parro-it/libui-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/parro-it/libui-node/contents/{+path}","compare_url":"https://api.github.com/repos/parro-it/libui-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parro-it/libui-node/merges","archive_url":"https://api.github.com/repos/parro-it/libui-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parro-it/libui-node/downloads","issues_url":"https://api.github.com/repos/parro-it/libui-node/issues{/number}","pulls_url":"https://api.github.com/repos/parro-it/libui-node/pulls{/number}","milestones_url":"https://api.github.com/repos/parro-it/libui-node/milestones{/number}","notifications_url":"https://api.github.com/repos/parro-it/libui-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parro-it/libui-node/labels{/name}","releases_url":"https://api.github.com/repos/parro-it/libui-node/releases{/id}","deployments_url":"https://api.github.com/repos/parro-it/libui-node/deployments","created_at":"2016-05-21T15:38:05Z","updated_at":"2016-06-10T14:56:39Z","pushed_at":"2016-06-10T20:38:22Z","git_url":"git://github.com/parro-it/libui-node.git","ssh_url":"git@github.com:parro-it/libui-node.git","clone_url":"https://github.com/parro-it/libui-node.git","svn_url":"https://github.com/parro-it/libui-node","homepage":"","size":40,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/parro-it/libui-node/pulls/2"},"html":{"href":"https://github.com/parro-it/libui-node/pull/2"},"issue":{"href":"https://api.github.com/repos/parro-it/libui-node/issues/2"},"comments":{"href":"https://api.github.com/repos/parro-it/libui-node/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/parro-it/libui-node/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/parro-it/libui-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/parro-it/libui-node/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/parro-it/libui-node/statuses/8f05e8de70e600fd0da17f9861db76052ffbfc89"}}}}
{"actor":{"display_login":"parro-it"}}