{"action":"closed","number":335,"pull_request":{"url":"https://api.github.com/repos/robotology/icub-main/pulls/335","id":69136970,"html_url":"https://github.com/robotology/icub-main/pull/335","diff_url":"https://github.com/robotology/icub-main/pull/335.diff","patch_url":"https://github.com/robotology/icub-main/pull/335.patch","issue_url":"https://api.github.com/repos/robotology/icub-main/issues/335","number":335,"state":"closed","locked":false,"title":"[icubCluster] Add icon","user":{"login":"Tobias-Fischer","id":5497832,"avatar_url":"https://avatars.githubusercontent.com/u/5497832?v=3","gravatar_id":"","url":"https://api.github.com/users/Tobias-Fischer","html_url":"https://github.com/Tobias-Fischer","followers_url":"https://api.github.com/users/Tobias-Fischer/followers","following_url":"https://api.github.com/users/Tobias-Fischer/following{/other_user}","gists_url":"https://api.github.com/users/Tobias-Fischer/gists{/gist_id}","starred_url":"https://api.github.com/users/Tobias-Fischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tobias-Fischer/subscriptions","organizations_url":"https://api.github.com/users/Tobias-Fischer/orgs","repos_url":"https://api.github.com/users/Tobias-Fischer/repos","events_url":"https://api.github.com/users/Tobias-Fischer/events{/privacy}","received_events_url":"https://api.github.com/users/Tobias-Fischer/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nThis small pull request adds an icon to `icub-cluster.py`, which makes it easier to find in the window list :).\r\nThe icon is from http://www.easyicon.net/language.en/31236-cluster_icon.html - maybe someone could contribute a prettier one.\r\n\r\n\r\nBest,\r\nTobi\r\nPS: I'm not sure who's best to handle this PR, maybe @lornat75?\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/robotology/icub-main/pull/335%23issuecomment-217413829%22%2C%20%22https%3A//github.com/robotology/icub-main/pull/335%23issuecomment-217798492%22%2C%20%22https%3A//github.com/robotology/icub-main/pull/335%23issuecomment-217798522%22%2C%20%22https%3A//github.com/robotology/icub-main/pull/335%23issuecomment-217798668%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/robotology/icub-main/pull/335%23issuecomment-217413829%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22PS%3A%20Code%20for%20setting%20the%20icon%20found%20on%20https%3A//stackoverflow.com/questions/11176638/python-setting-application-icon%22%2C%20%22created_at%22%3A%20%222016-05-06T11%3A15%3A48Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/5497832%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/Tobias-Fischer%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%22%2C%20%22created_at%22%3A%20%222016-05-09T07%3A52%3A33Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/3738070%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/pattacini%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3Ashipit%3A%22%2C%20%22created_at%22%3A%20%222016-05-09T07%3A52%3A44Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/3738070%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/pattacini%22%7D%7D%2C%20%7B%22body%22%3A%20%22Tested%3A%20it%27s%20working%20nicely.%20Thanks%20for%20the%20add-in.%22%2C%20%22created_at%22%3A%20%222016-05-09T07%3A53%3A39Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/3738070%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/pattacini%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%7D%2C%20%22approved%22%3A%20%7B%22https%3A//github.com/pattacini%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/3738070%3Fv%3D3%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n\n<img src='http://www.codereviewhub.com/site/github-approved-avatar.png'><a href='https://github.com/pattacini'><img src='https://avatars.githubusercontent.com/u/3738070?v=3' width=34 height=34></a>\n\n- [ ] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/robotology/icub-main/pull/335#issuecomment-217413829'>General Comment</a></b>\n- <a href='https://github.com/Tobias-Fischer'><img border=0 src='https://avatars.githubusercontent.com/u/5497832?v=3' height=16 width=16'></a> PS: Code for setting the icon found on https://stackoverflow.com/questions/11176638/python-setting-application-icon\n- <a href='https://github.com/pattacini'><img border=0 src='https://avatars.githubusercontent.com/u/3738070?v=3' height=16 width=16'></a> :+1:\n- <a href='https://github.com/pattacini'><img border=0 src='https://avatars.githubusercontent.com/u/3738070?v=3' height=16 width=16'></a> :shipit:\n- <a href='https://github.com/pattacini'><img border=0 src='https://avatars.githubusercontent.com/u/3738070?v=3' height=16 width=16'></a> Tested: it's working nicely. Thanks for the add-in.\n\n\n<a href='https://www.codereviewhub.com/robotology/icub-main/pull/335?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/robotology/icub-main/pull/335?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/robotology/icub-main/pull/335?approve=0'><img src='http://www.codereviewhub.com/site/github-undo-approve.png' height=26></a>&nbsp;<a href='https://github.com/robotology/icub-main/pull/335'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2016-05-06T11:14:53Z","updated_at":"2016-05-09T07:53:50Z","closed_at":"2016-05-09T07:53:50Z","merged_at":"2016-05-09T07:53:50Z","merge_commit_sha":"69943a33f69c57f6e5f9733563a7cbc82061a011","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/robotology/icub-main/pulls/335/commits","review_comments_url":"https://api.github.com/repos/robotology/icub-main/pulls/335/comments","review_comment_url":"https://api.github.com/repos/robotology/icub-main/pulls/comments{/number}","comments_url":"https://api.github.com/repos/robotology/icub-main/issues/335/comments","statuses_url":"https://api.github.com/repos/robotology/icub-main/statuses/8fd74ea1b764f6aedd3127d2cbe5498b492a5f8e","head":{"label":"robotology:feature/icub-cluster-icon","ref":"feature/icub-cluster-icon","sha":"8fd74ea1b764f6aedd3127d2cbe5498b492a5f8e","user":{"login":"robotology","id":1587191,"avatar_url":"https://avatars.githubusercontent.com/u/1587191?v=3","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"repo":{"id":15800559,"name":"icub-main","full_name":"robotology/icub-main","owner":{"login":"robotology","id":1587191,"avatar_url":"https://avatars.githubusercontent.com/u/1587191?v=3","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/robotology/icub-main","description":"The iCub Main Software Repository","fork":false,"url":"https://api.github.com/repos/robotology/icub-main","forks_url":"https://api.github.com/repos/robotology/icub-main/forks","keys_url":"https://api.github.com/repos/robotology/icub-main/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robotology/icub-main/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robotology/icub-main/teams","hooks_url":"https://api.github.com/repos/robotology/icub-main/hooks","issue_events_url":"https://api.github.com/repos/robotology/icub-main/issues/events{/number}","events_url":"https://api.github.com/repos/robotology/icub-main/events","assignees_url":"https://api.github.com/repos/robotology/icub-main/assignees{/user}","branches_url":"https://api.github.com/repos/robotology/icub-main/branches{/branch}","tags_url":"https://api.github.com/repos/robotology/icub-main/tags","blobs_url":"https://api.github.com/repos/robotology/icub-main/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robotology/icub-main/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robotology/icub-main/git/refs{/sha}","trees_url":"https://api.github.com/repos/robotology/icub-main/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robotology/icub-main/statuses/{sha}","languages_url":"https://api.github.com/repos/robotology/icub-main/languages","stargazers_url":"https://api.github.com/repos/robotology/icub-main/stargazers","contributors_url":"https://api.github.com/repos/robotology/icub-main/contributors","subscribers_url":"https://api.github.com/repos/robotology/icub-main/subscribers","subscription_url":"https://api.github.com/repos/robotology/icub-main/subscription","commits_url":"https://api.github.com/repos/robotology/icub-main/commits{/sha}","git_commits_url":"https://api.github.com/repos/robotology/icub-main/git/commits{/sha}","comments_url":"https://api.github.com/repos/robotology/icub-main/comments{/number}","issue_comment_url":"https://api.github.com/repos/robotology/icub-main/issues/comments{/number}","contents_url":"https://api.github.com/repos/robotology/icub-main/contents/{+path}","compare_url":"https://api.github.com/repos/robotology/icub-main/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robotology/icub-main/merges","archive_url":"https://api.github.com/repos/robotology/icub-main/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robotology/icub-main/downloads","issues_url":"https://api.github.com/repos/robotology/icub-main/issues{/number}","pulls_url":"https://api.github.com/repos/robotology/icub-main/pulls{/number}","milestones_url":"https://api.github.com/repos/robotology/icub-main/milestones{/number}","notifications_url":"https://api.github.com/repos/robotology/icub-main/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robotology/icub-main/labels{/name}","releases_url":"https://api.github.com/repos/robotology/icub-main/releases{/id}","deployments_url":"https://api.github.com/repos/robotology/icub-main/deployments","created_at":"2014-01-10T14:50:19Z","updated_at":"2016-05-07T15:38:55Z","pushed_at":"2016-05-09T07:53:50Z","git_url":"git://github.com/robotology/icub-main.git","ssh_url":"git@github.com:robotology/icub-main.git","clone_url":"https://github.com/robotology/icub-main.git","svn_url":"https://github.com/robotology/icub-main","homepage":null,"size":160589,"stargazers_count":21,"watchers_count":21,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":52,"forks":38,"open_issues":52,"watchers":21,"default_branch":"master"}},"base":{"label":"robotology:master","ref":"master","sha":"ba049595d09d6a7a0294b3ba18be920c784f8989","user":{"login":"robotology","id":1587191,"avatar_url":"https://avatars.githubusercontent.com/u/1587191?v=3","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"repo":{"id":15800559,"name":"icub-main","full_name":"robotology/icub-main","owner":{"login":"robotology","id":1587191,"avatar_url":"https://avatars.githubusercontent.com/u/1587191?v=3","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/robotology/icub-main","description":"The iCub Main Software Repository","fork":false,"url":"https://api.github.com/repos/robotology/icub-main","forks_url":"https://api.github.com/repos/robotology/icub-main/forks","keys_url":"https://api.github.com/repos/robotology/icub-main/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robotology/icub-main/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robotology/icub-main/teams","hooks_url":"https://api.github.com/repos/robotology/icub-main/hooks","issue_events_url":"https://api.github.com/repos/robotology/icub-main/issues/events{/number}","events_url":"https://api.github.com/repos/robotology/icub-main/events","assignees_url":"https://api.github.com/repos/robotology/icub-main/assignees{/user}","branches_url":"https://api.github.com/repos/robotology/icub-main/branches{/branch}","tags_url":"https://api.github.com/repos/robotology/icub-main/tags","blobs_url":"https://api.github.com/repos/robotology/icub-main/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robotology/icub-main/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robotology/icub-main/git/refs{/sha}","trees_url":"https://api.github.com/repos/robotology/icub-main/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robotology/icub-main/statuses/{sha}","languages_url":"https://api.github.com/repos/robotology/icub-main/languages","stargazers_url":"https://api.github.com/repos/robotology/icub-main/stargazers","contributors_url":"https://api.github.com/repos/robotology/icub-main/contributors","subscribers_url":"https://api.github.com/repos/robotology/icub-main/subscribers","subscription_url":"https://api.github.com/repos/robotology/icub-main/subscription","commits_url":"https://api.github.com/repos/robotology/icub-main/commits{/sha}","git_commits_url":"https://api.github.com/repos/robotology/icub-main/git/commits{/sha}","comments_url":"https://api.github.com/repos/robotology/icub-main/comments{/number}","issue_comment_url":"https://api.github.com/repos/robotology/icub-main/issues/comments{/number}","contents_url":"https://api.github.com/repos/robotology/icub-main/contents/{+path}","compare_url":"https://api.github.com/repos/robotology/icub-main/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robotology/icub-main/merges","archive_url":"https://api.github.com/repos/robotology/icub-main/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robotology/icub-main/downloads","issues_url":"https://api.github.com/repos/robotology/icub-main/issues{/number}","pulls_url":"https://api.github.com/repos/robotology/icub-main/pulls{/number}","milestones_url":"https://api.github.com/repos/robotology/icub-main/milestones{/number}","notifications_url":"https://api.github.com/repos/robotology/icub-main/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robotology/icub-main/labels{/name}","releases_url":"https://api.github.com/repos/robotology/icub-main/releases{/id}","deployments_url":"https://api.github.com/repos/robotology/icub-main/deployments","created_at":"2014-01-10T14:50:19Z","updated_at":"2016-05-07T15:38:55Z","pushed_at":"2016-05-09T07:53:50Z","git_url":"git://github.com/robotology/icub-main.git","ssh_url":"git@github.com:robotology/icub-main.git","clone_url":"https://github.com/robotology/icub-main.git","svn_url":"https://github.com/robotology/icub-main","homepage":null,"size":160589,"stargazers_count":21,"watchers_count":21,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":52,"forks":38,"open_issues":52,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/robotology/icub-main/pulls/335"},"html":{"href":"https://github.com/robotology/icub-main/pull/335"},"issue":{"href":"https://api.github.com/repos/robotology/icub-main/issues/335"},"comments":{"href":"https://api.github.com/repos/robotology/icub-main/issues/335/comments"},"review_comments":{"href":"https://api.github.com/repos/robotology/icub-main/pulls/335/comments"},"review_comment":{"href":"https://api.github.com/repos/robotology/icub-main/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/robotology/icub-main/pulls/335/commits"},"statuses":{"href":"https://api.github.com/repos/robotology/icub-main/statuses/8fd74ea1b764f6aedd3127d2cbe5498b492a5f8e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pattacini","id":3738070,"avatar_url":"https://avatars.githubusercontent.com/u/3738070?v=3","gravatar_id":"","url":"https://api.github.com/users/pattacini","html_url":"https://github.com/pattacini","followers_url":"https://api.github.com/users/pattacini/followers","following_url":"https://api.github.com/users/pattacini/following{/other_user}","gists_url":"https://api.github.com/users/pattacini/gists{/gist_id}","starred_url":"https://api.github.com/users/pattacini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pattacini/subscriptions","organizations_url":"https://api.github.com/users/pattacini/orgs","repos_url":"https://api.github.com/users/pattacini/repos","events_url":"https://api.github.com/users/pattacini/events{/privacy}","received_events_url":"https://api.github.com/users/pattacini/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":13,"deletions":1,"changed_files":3}}