{"action":"opened","number":39,"pull_request":{"url":"https://api.github.com/repos/ccgus/CocoaScript/pulls/39","id":56337304,"html_url":"https://github.com/ccgus/CocoaScript/pull/39","diff_url":"https://github.com/ccgus/CocoaScript/pull/39.diff","patch_url":"https://github.com/ccgus/CocoaScript/pull/39.patch","issue_url":"https://api.github.com/repos/ccgus/CocoaScript/issues/39","number":39,"state":"open","locked":false,"title":"Additional fixes.","user":{"login":"samdeane","id":206306,"avatar_url":"https://avatars.githubusercontent.com/u/206306?v=3","gravatar_id":"","url":"https://api.github.com/users/samdeane","html_url":"https://github.com/samdeane","followers_url":"https://api.github.com/users/samdeane/followers","following_url":"https://api.github.com/users/samdeane/following{/other_user}","gists_url":"https://api.github.com/users/samdeane/gists{/gist_id}","starred_url":"https://api.github.com/users/samdeane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samdeane/subscriptions","organizations_url":"https://api.github.com/users/samdeane/orgs","repos_url":"https://api.github.com/users/samdeane/repos","events_url":"https://api.github.com/users/samdeane/events{/privacy}","received_events_url":"https://api.github.com/users/samdeane/received_events","type":"User","site_admin":false},"body":"This is an evolution of the code in PR #34. We've had some crashes reported for Sketch using that code, so I've refined it further.\r\n\r\nI still don't think I've got all the crashes out, so I will probably have to reinstate the JSValueProtect hack in the meantime.\r\n\r\nDebugging this code is quite interesting though.\r\n\r\nI've downgraded a couple of the assertions to just be debug() statements, and I get the \"box should have been disassociated\" one firing occasionally, seemingly when things are being cleaned up.\r\n\r\nIt looks like it's firing for something that was passed as a parameter in a function call, though I'm not 100% certain.","created_at":"2016-01-18T12:35:51Z","updated_at":"2016-01-18T12:35:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ccgus/CocoaScript/pulls/39/commits","review_comments_url":"https://api.github.com/repos/ccgus/CocoaScript/pulls/39/comments","review_comment_url":"https://api.github.com/repos/ccgus/CocoaScript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ccgus/CocoaScript/issues/39/comments","statuses_url":"https://api.github.com/repos/ccgus/CocoaScript/statuses/81e15f9bdd1c00358df68a9e3d6ef98e156bb042","head":{"label":"BohemianCoding:feature/7496-latest-sketch-beta-crashes","ref":"feature/7496-latest-sketch-beta-crashes","sha":"81e15f9bdd1c00358df68a9e3d6ef98e156bb042","user":{"login":"BohemianCoding","id":4498264,"avatar_url":"https://avatars.githubusercontent.com/u/4498264?v=3","gravatar_id":"","url":"https://api.github.com/users/BohemianCoding","html_url":"https://github.com/BohemianCoding","followers_url":"https://api.github.com/users/BohemianCoding/followers","following_url":"https://api.github.com/users/BohemianCoding/following{/other_user}","gists_url":"https://api.github.com/users/BohemianCoding/gists{/gist_id}","starred_url":"https://api.github.com/users/BohemianCoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BohemianCoding/subscriptions","organizations_url":"https://api.github.com/users/BohemianCoding/orgs","repos_url":"https://api.github.com/users/BohemianCoding/repos","events_url":"https://api.github.com/users/BohemianCoding/events{/privacy}","received_events_url":"https://api.github.com/users/BohemianCoding/received_events","type":"Organization","site_admin":false},"repo":{"id":18133839,"name":"CocoaScript","full_name":"BohemianCoding/CocoaScript","owner":{"login":"BohemianCoding","id":4498264,"avatar_url":"https://avatars.githubusercontent.com/u/4498264?v=3","gravatar_id":"","url":"https://api.github.com/users/BohemianCoding","html_url":"https://github.com/BohemianCoding","followers_url":"https://api.github.com/users/BohemianCoding/followers","following_url":"https://api.github.com/users/BohemianCoding/following{/other_user}","gists_url":"https://api.github.com/users/BohemianCoding/gists{/gist_id}","starred_url":"https://api.github.com/users/BohemianCoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BohemianCoding/subscriptions","organizations_url":"https://api.github.com/users/BohemianCoding/orgs","repos_url":"https://api.github.com/users/BohemianCoding/repos","events_url":"https://api.github.com/users/BohemianCoding/events{/privacy}","received_events_url":"https://api.github.com/users/BohemianCoding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BohemianCoding/CocoaScript","description":"JavaScript + the Cocoa frameworks, and then ObjC brackets show up to party as well.","fork":true,"url":"https://api.github.com/repos/BohemianCoding/CocoaScript","forks_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/forks","keys_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/teams","hooks_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/hooks","issue_events_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/issues/events{/number}","events_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/events","assignees_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/assignees{/user}","branches_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/branches{/branch}","tags_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/tags","blobs_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/statuses/{sha}","languages_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/languages","stargazers_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/stargazers","contributors_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/contributors","subscribers_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/subscribers","subscription_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/subscription","commits_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/contents/{+path}","compare_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/merges","archive_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/downloads","issues_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/issues{/number}","pulls_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/pulls{/number}","milestones_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/milestones{/number}","notifications_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/labels{/name}","releases_url":"https://api.github.com/repos/BohemianCoding/CocoaScript/releases{/id}","created_at":"2014-03-26T10:05:51Z","updated_at":"2014-12-18T15:45:34Z","pushed_at":"2016-01-16T17:38:44Z","git_url":"git://github.com/BohemianCoding/CocoaScript.git","ssh_url":"git@github.com:BohemianCoding/CocoaScript.git","clone_url":"https://github.com/BohemianCoding/CocoaScript.git","svn_url":"https://github.com/BohemianCoding/CocoaScript","homepage":null,"size":2030,"stargazers_count":1,"watchers_count":1,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ccgus:master","ref":"master","sha":"6c67f2ce0e653fad48e3e8bc060da73e4837638f","user":{"login":"ccgus","id":60178,"avatar_url":"https://avatars.githubusercontent.com/u/60178?v=3","gravatar_id":"","url":"https://api.github.com/users/ccgus","html_url":"https://github.com/ccgus","followers_url":"https://api.github.com/users/ccgus/followers","following_url":"https://api.github.com/users/ccgus/following{/other_user}","gists_url":"https://api.github.com/users/ccgus/gists{/gist_id}","starred_url":"https://api.github.com/users/ccgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccgus/subscriptions","organizations_url":"https://api.github.com/users/ccgus/orgs","repos_url":"https://api.github.com/users/ccgus/repos","events_url":"https://api.github.com/users/ccgus/events{/privacy}","received_events_url":"https://api.github.com/users/ccgus/received_events","type":"User","site_admin":false},"repo":{"id":13851254,"name":"CocoaScript","full_name":"ccgus/CocoaScript","owner":{"login":"ccgus","id":60178,"avatar_url":"https://avatars.githubusercontent.com/u/60178?v=3","gravatar_id":"","url":"https://api.github.com/users/ccgus","html_url":"https://github.com/ccgus","followers_url":"https://api.github.com/users/ccgus/followers","following_url":"https://api.github.com/users/ccgus/following{/other_user}","gists_url":"https://api.github.com/users/ccgus/gists{/gist_id}","starred_url":"https://api.github.com/users/ccgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccgus/subscriptions","organizations_url":"https://api.github.com/users/ccgus/orgs","repos_url":"https://api.github.com/users/ccgus/repos","events_url":"https://api.github.com/users/ccgus/events{/privacy}","received_events_url":"https://api.github.com/users/ccgus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ccgus/CocoaScript","description":"JavaScript + the Cocoa frameworks, and then ObjC brackets show up to party as well.","fork":false,"url":"https://api.github.com/repos/ccgus/CocoaScript","forks_url":"https://api.github.com/repos/ccgus/CocoaScript/forks","keys_url":"https://api.github.com/repos/ccgus/CocoaScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ccgus/CocoaScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ccgus/CocoaScript/teams","hooks_url":"https://api.github.com/repos/ccgus/CocoaScript/hooks","issue_events_url":"https://api.github.com/repos/ccgus/CocoaScript/issues/events{/number}","events_url":"https://api.github.com/repos/ccgus/CocoaScript/events","assignees_url":"https://api.github.com/repos/ccgus/CocoaScript/assignees{/user}","branches_url":"https://api.github.com/repos/ccgus/CocoaScript/branches{/branch}","tags_url":"https://api.github.com/repos/ccgus/CocoaScript/tags","blobs_url":"https://api.github.com/repos/ccgus/CocoaScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ccgus/CocoaScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ccgus/CocoaScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/ccgus/CocoaScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ccgus/CocoaScript/statuses/{sha}","languages_url":"https://api.github.com/repos/ccgus/CocoaScript/languages","stargazers_url":"https://api.github.com/repos/ccgus/CocoaScript/stargazers","contributors_url":"https://api.github.com/repos/ccgus/CocoaScript/contributors","subscribers_url":"https://api.github.com/repos/ccgus/CocoaScript/subscribers","subscription_url":"https://api.github.com/repos/ccgus/CocoaScript/subscription","commits_url":"https://api.github.com/repos/ccgus/CocoaScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/ccgus/CocoaScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/ccgus/CocoaScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/ccgus/CocoaScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/ccgus/CocoaScript/contents/{+path}","compare_url":"https://api.github.com/repos/ccgus/CocoaScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ccgus/CocoaScript/merges","archive_url":"https://api.github.com/repos/ccgus/CocoaScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ccgus/CocoaScript/downloads","issues_url":"https://api.github.com/repos/ccgus/CocoaScript/issues{/number}","pulls_url":"https://api.github.com/repos/ccgus/CocoaScript/pulls{/number}","milestones_url":"https://api.github.com/repos/ccgus/CocoaScript/milestones{/number}","notifications_url":"https://api.github.com/repos/ccgus/CocoaScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ccgus/CocoaScript/labels{/name}","releases_url":"https://api.github.com/repos/ccgus/CocoaScript/releases{/id}","created_at":"2013-10-25T04:09:47Z","updated_at":"2016-01-09T01:51:15Z","pushed_at":"2015-12-17T13:03:36Z","git_url":"git://github.com/ccgus/CocoaScript.git","ssh_url":"git@github.com:ccgus/CocoaScript.git","clone_url":"https://github.com/ccgus/CocoaScript.git","svn_url":"https://github.com/ccgus/CocoaScript","homepage":null,"size":2407,"stargazers_count":214,"watchers_count":214,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":12,"forks":16,"open_issues":12,"watchers":214,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ccgus/CocoaScript/pulls/39"},"html":{"href":"https://github.com/ccgus/CocoaScript/pull/39"},"issue":{"href":"https://api.github.com/repos/ccgus/CocoaScript/issues/39"},"comments":{"href":"https://api.github.com/repos/ccgus/CocoaScript/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/ccgus/CocoaScript/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/ccgus/CocoaScript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ccgus/CocoaScript/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/ccgus/CocoaScript/statuses/81e15f9bdd1c00358df68a9e3d6ef98e156bb042"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":81,"additions":468,"deletions":210,"changed_files":33}}