{"action":"closed","number":12013,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12013","id":84826635,"html_url":"https://github.com/joomla/joomla-cms/pull/12013","diff_url":"https://github.com/joomla/joomla-cms/pull/12013.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/12013.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12013","number":12013,"state":"closed","locked":false,"title":"Fix error in mergeHeadData method for html document","user":{"login":"csthomas","id":9054379,"avatar_url":"https://avatars.githubusercontent.com/u/9054379?v=3","gravatar_id":"","url":"https://api.github.com/users/csthomas","html_url":"https://github.com/csthomas","followers_url":"https://api.github.com/users/csthomas/followers","following_url":"https://api.github.com/users/csthomas/following{/other_user}","gists_url":"https://api.github.com/users/csthomas/gists{/gist_id}","starred_url":"https://api.github.com/users/csthomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csthomas/subscriptions","organizations_url":"https://api.github.com/users/csthomas/orgs","repos_url":"https://api.github.com/users/csthomas/repos","events_url":"https://api.github.com/users/csthomas/events{/privacy}","received_events_url":"https://api.github.com/users/csthomas/received_events","type":"User","site_admin":false},"body":"### Summary of Changes\r\n\r\nThis PR does two things:\r\n* extend tests in order to display the error in php Travis tests.\r\n* fix the error generated by `array_unique` function\r\n\r\n### Testing Instructions\r\n\r\nHow to reproduce notices?\r\n```php\r\n$html = new JDocumentHtml();\r\n$html->addHeadLink('http://www.example.com', 'Start');\r\n$html->addHeadLink('http://www.example.com/end', 'End');\r\n$html->mergeHeadData($html->getHeadData());\r\n```\r\ngenerates several:\r\n```\r\nPHP Notice:  Array to string conversion in /home/[...]/libraries/joomla/document/html.php on line 222\r\n```\r\n\r\nAnd `$html->_links` contain only first link.\r\n\r\nAfter patch this notice disappears and links contain all links.\r\n\r\n### Documentation Changes Required\r\nNo\r\n","created_at":"2016-09-12T07:35:59Z","updated_at":"2016-10-18T17:32:42Z","closed_at":"2016-10-18T17:32:42Z","merged_at":"2016-10-18T17:32:42Z","merge_commit_sha":"15af4a578170f02c25794c397909548f83831efa","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/14","html_url":"https://github.com/joomla/joomla-cms/milestones/Joomla%203.7.0","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/14/labels","id":1750036,"number":14,"title":"Joomla 3.7.0","description":"","creator":{"login":"brianteeman","id":1296369,"avatar_url":"https://avatars.githubusercontent.com/u/1296369?v=3","gravatar_id":"","url":"https://api.github.com/users/brianteeman","html_url":"https://github.com/brianteeman","followers_url":"https://api.github.com/users/brianteeman/followers","following_url":"https://api.github.com/users/brianteeman/following{/other_user}","gists_url":"https://api.github.com/users/brianteeman/gists{/gist_id}","starred_url":"https://api.github.com/users/brianteeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianteeman/subscriptions","organizations_url":"https://api.github.com/users/brianteeman/orgs","repos_url":"https://api.github.com/users/brianteeman/repos","events_url":"https://api.github.com/users/brianteeman/events{/privacy}","received_events_url":"https://api.github.com/users/brianteeman/received_events","type":"User","site_admin":false},"open_issues":58,"closed_issues":160,"state":"open","created_at":"2016-05-05T16:42:34Z","updated_at":"2016-10-18T17:32:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12013/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12013/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12013/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/03bde816bc902d3df1fa9dd4b8bff3b5f0330cef","head":{"label":"csthomas:hhvm_fix_document_html","ref":"hhvm_fix_document_html","sha":"03bde816bc902d3df1fa9dd4b8bff3b5f0330cef","user":{"login":"csthomas","id":9054379,"avatar_url":"https://avatars.githubusercontent.com/u/9054379?v=3","gravatar_id":"","url":"https://api.github.com/users/csthomas","html_url":"https://github.com/csthomas","followers_url":"https://api.github.com/users/csthomas/followers","following_url":"https://api.github.com/users/csthomas/following{/other_user}","gists_url":"https://api.github.com/users/csthomas/gists{/gist_id}","starred_url":"https://api.github.com/users/csthomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csthomas/subscriptions","organizations_url":"https://api.github.com/users/csthomas/orgs","repos_url":"https://api.github.com/users/csthomas/repos","events_url":"https://api.github.com/users/csthomas/events{/privacy}","received_events_url":"https://api.github.com/users/csthomas/received_events","type":"User","site_admin":false},"repo":{"id":45381530,"name":"joomla-cms","full_name":"csthomas/joomla-cms","owner":{"login":"csthomas","id":9054379,"avatar_url":"https://avatars.githubusercontent.com/u/9054379?v=3","gravatar_id":"","url":"https://api.github.com/users/csthomas","html_url":"https://github.com/csthomas","followers_url":"https://api.github.com/users/csthomas/followers","following_url":"https://api.github.com/users/csthomas/following{/other_user}","gists_url":"https://api.github.com/users/csthomas/gists{/gist_id}","starred_url":"https://api.github.com/users/csthomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csthomas/subscriptions","organizations_url":"https://api.github.com/users/csthomas/orgs","repos_url":"https://api.github.com/users/csthomas/repos","events_url":"https://api.github.com/users/csthomas/events{/privacy}","received_events_url":"https://api.github.com/users/csthomas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/csthomas/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/csthomas/joomla-cms","forks_url":"https://api.github.com/repos/csthomas/joomla-cms/forks","keys_url":"https://api.github.com/repos/csthomas/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/csthomas/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/csthomas/joomla-cms/teams","hooks_url":"https://api.github.com/repos/csthomas/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/csthomas/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/csthomas/joomla-cms/events","assignees_url":"https://api.github.com/repos/csthomas/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/csthomas/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/csthomas/joomla-cms/tags","blobs_url":"https://api.github.com/repos/csthomas/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/csthomas/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/csthomas/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/csthomas/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/csthomas/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/csthomas/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/csthomas/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/csthomas/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/csthomas/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/csthomas/joomla-cms/subscription","commits_url":"https://api.github.com/repos/csthomas/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/csthomas/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/csthomas/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/csthomas/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/csthomas/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/csthomas/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/csthomas/joomla-cms/merges","archive_url":"https://api.github.com/repos/csthomas/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/csthomas/joomla-cms/downloads","issues_url":"https://api.github.com/repos/csthomas/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/csthomas/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/csthomas/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/csthomas/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/csthomas/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/csthomas/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/csthomas/joomla-cms/deployments","created_at":"2015-11-02T08:28:28Z","updated_at":"2016-01-13T19:36:09Z","pushed_at":"2016-10-13T11:46:58Z","git_url":"git://github.com/csthomas/joomla-cms.git","ssh_url":"git@github.com:csthomas/joomla-cms.git","clone_url":"https://github.com/csthomas/joomla-cms.git","svn_url":"https://github.com/csthomas/joomla-cms","homepage":"https://www.joomla.org","size":161221,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:3.7.x","ref":"3.7.x","sha":"904f591fe174ce59ef17b1dc3ed92620b7a20132","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-10-18T16:32:43Z","pushed_at":"2016-10-18T17:32:42Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":304617,"stargazers_count":2154,"watchers_count":2154,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2313,"mirror_url":null,"open_issues_count":522,"forks":2313,"open_issues":522,"watchers":2154,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/12013"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/12013"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/12013"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/12013/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/12013/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/12013/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/03bde816bc902d3df1fa9dd4b8bff3b5f0330cef"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rdeutz","id":467356,"avatar_url":"https://avatars.githubusercontent.com/u/467356?v=3","gravatar_id":"","url":"https://api.github.com/users/rdeutz","html_url":"https://github.com/rdeutz","followers_url":"https://api.github.com/users/rdeutz/followers","following_url":"https://api.github.com/users/rdeutz/following{/other_user}","gists_url":"https://api.github.com/users/rdeutz/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeutz/subscriptions","organizations_url":"https://api.github.com/users/rdeutz/orgs","repos_url":"https://api.github.com/users/rdeutz/repos","events_url":"https://api.github.com/users/rdeutz/events{/privacy}","received_events_url":"https://api.github.com/users/rdeutz/received_events","type":"User","site_admin":false},"comments":9,"review_comments":0,"commits":2,"additions":6,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"rdeutz"}}