{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-metron/issues/345","repository_url":"https://api.github.com/repos/apache/incubator-metron","labels_url":"https://api.github.com/repos/apache/incubator-metron/issues/345/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-metron/issues/345/comments","events_url":"https://api.github.com/repos/apache/incubator-metron/issues/345/events","html_url":"https://github.com/apache/incubator-metron/pull/345","id":187585474,"number":345,"title":"METRON-532 Define Profile Period When Calling PROFILE_GET","user":{"login":"mattf-horton","id":908957,"avatar_url":"https://avatars.githubusercontent.com/u/908957?v=3","gravatar_id":"","url":"https://api.github.com/users/mattf-horton","html_url":"https://github.com/mattf-horton","followers_url":"https://api.github.com/users/mattf-horton/followers","following_url":"https://api.github.com/users/mattf-horton/following{/other_user}","gists_url":"https://api.github.com/users/mattf-horton/gists{/gist_id}","starred_url":"https://api.github.com/users/mattf-horton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattf-horton/subscriptions","organizations_url":"https://api.github.com/users/mattf-horton/orgs","repos_url":"https://api.github.com/users/mattf-horton/repos","events_url":"https://api.github.com/users/mattf-horton/events{/privacy}","received_events_url":"https://api.github.com/users/mattf-horton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-06T20:11:12Z","updated_at":"2016-11-07T18:41:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-metron/pulls/345","html_url":"https://github.com/apache/incubator-metron/pull/345","diff_url":"https://github.com/apache/incubator-metron/pull/345.diff","patch_url":"https://github.com/apache/incubator-metron/pull/345.patch"},"body":"This PR builds on top of @nickwallen 's work in METRON-529, which has already been committed to master.  It adds an optional argument to PROFILE_GET, allowing run-time overrides of the profiler client global configuration parameters.  The primary use case is when historical profiles have been created with a different profile configuration than is currently configured, and the analyst needing to access them does not want to change the global client configuration so as not to disrupt the work of other analysts working with current profiles.\r\n\r\nThe proposed placement of the optional Map argument is before the group sequence, so as not to disrupt the current usage of a variable-length sequence of 'group' arguments.  Example:\r\n```\r\n// Retrieve all values for 'entity1' from 'profile1' that occurred on 'weekdays' over the past month,\r\n// overriding the usual global client configuration parameters for window duration.\r\nPROFILE_GET('profile1', 'entity1', 1, 'MONTHS', {'profiler.client.period.duration' : '2', 'profiler.client.period.duration.units' : 'MINUTES'}, 'weekdays')\r\n```\r\n\r\nAn alternative would be to change the 'groups' argument into a List, rather than a variable-length sequence of Strings, then put the config_override Map after the groups List.  Let me know if you think this would be a better implementation, as I can change it very quickly.  Of course the original usage would be retained for backward compatibility, but perhaps deprecated.\r\n\r\nTesting:  This change is restricted to the Stellar function implementation, so the expanded junit test is largely sufficient.  Also, a previous version of this code passed Travis in a preview PR against Nick's work branch."},"comment":{"url":"https://api.github.com/repos/apache/incubator-metron/issues/comments/258923179","html_url":"https://github.com/apache/incubator-metron/pull/345#issuecomment-258923179","issue_url":"https://api.github.com/repos/apache/incubator-metron/issues/345","id":258923179,"user":{"login":"cestella","id":540359,"avatar_url":"https://avatars.githubusercontent.com/u/540359?v=3","gravatar_id":"","url":"https://api.github.com/users/cestella","html_url":"https://github.com/cestella","followers_url":"https://api.github.com/users/cestella/followers","following_url":"https://api.github.com/users/cestella/following{/other_user}","gists_url":"https://api.github.com/users/cestella/gists{/gist_id}","starred_url":"https://api.github.com/users/cestella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cestella/subscriptions","organizations_url":"https://api.github.com/users/cestella/orgs","repos_url":"https://api.github.com/users/cestella/repos","events_url":"https://api.github.com/users/cestella/events{/privacy}","received_events_url":"https://api.github.com/users/cestella/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T18:41:02Z","updated_at":"2016-11-07T18:41:02Z","body":"@mattf-horton No worries, get better, man."}}
{"actor":{"display_login":"cestella"}}