{"action":"closed","number":166,"pull_request":{"url":"https://api.github.com/repos/novoda/spikes/pulls/166","id":89266212,"html_url":"https://github.com/novoda/spikes/pull/166","diff_url":"https://github.com/novoda/spikes/pull/166.diff","patch_url":"https://github.com/novoda/spikes/pull/166.patch","issue_url":"https://api.github.com/repos/novoda/spikes/issues/166","number":166,"state":"closed","locked":false,"title":"Introduce the static analysis plugin","user":{"login":"mr-archano","id":1069201,"avatar_url":"https://avatars.githubusercontent.com/u/1069201?v=3","gravatar_id":"","url":"https://api.github.com/users/mr-archano","html_url":"https://github.com/mr-archano","followers_url":"https://api.github.com/users/mr-archano/followers","following_url":"https://api.github.com/users/mr-archano/following{/other_user}","gists_url":"https://api.github.com/users/mr-archano/gists{/gist_id}","starred_url":"https://api.github.com/users/mr-archano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mr-archano/subscriptions","organizations_url":"https://api.github.com/users/mr-archano/orgs","repos_url":"https://api.github.com/users/mr-archano/repos","events_url":"https://api.github.com/users/mr-archano/events{/privacy}","received_events_url":"https://api.github.com/users/mr-archano/received_events","type":"User","site_admin":false},"body":"This project is a re-write of the [static-analysis-plugin](https://github.com/mr-archano/static-analysis-plugin) I started a while ago. I realised that would be better to start fresh and put a little more emphasis on testing while trying to involve more people in the design of the plugin itself.\r\n\r\nSo far only the integration with Checkstyle is provided (for both Android and Java projects), along with the possibility to define thresholds of warnings/errors that will cause a build to crash. The default behaviour of `Checkstyle` tasks has been then overridden to take in account such thresholds and notify the user with more meaningful logs.\r\n\r\n\r\nRandom notes:\r\n- Despite the mention of `healthy, versionable and configurable defaults` this PR doesn't bring any of that. The reason being I started the re-write from a different angle, focusing more on having a solid, fully testable setup. Support for rules via maven artifacts will be easy to port from the old plugin.\r\n- There's a lot of code for testing, I know, but I figured would be better to spend some time upfront and provide utilities to create and configure test projects for the integration tests. More info will be provided as inlined comments in this PR.","created_at":"2016-10-13T19:27:56Z","updated_at":"2016-10-16T14:14:50Z","closed_at":"2016-10-16T14:14:50Z","merged_at":"2016-10-16T14:14:50Z","merge_commit_sha":"a8e896d3efa386b78d00cfaa83add9e152a2e83f","assignee":{"login":"devisnik","id":1219911,"avatar_url":"https://avatars.githubusercontent.com/u/1219911?v=3","gravatar_id":"","url":"https://api.github.com/users/devisnik","html_url":"https://github.com/devisnik","followers_url":"https://api.github.com/users/devisnik/followers","following_url":"https://api.github.com/users/devisnik/following{/other_user}","gists_url":"https://api.github.com/users/devisnik/gists{/gist_id}","starred_url":"https://api.github.com/users/devisnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devisnik/subscriptions","organizations_url":"https://api.github.com/users/devisnik/orgs","repos_url":"https://api.github.com/users/devisnik/repos","events_url":"https://api.github.com/users/devisnik/events{/privacy}","received_events_url":"https://api.github.com/users/devisnik/received_events","type":"User","site_admin":false},"assignees":[{"login":"devisnik","id":1219911,"avatar_url":"https://avatars.githubusercontent.com/u/1219911?v=3","gravatar_id":"","url":"https://api.github.com/users/devisnik","html_url":"https://github.com/devisnik","followers_url":"https://api.github.com/users/devisnik/followers","following_url":"https://api.github.com/users/devisnik/following{/other_user}","gists_url":"https://api.github.com/users/devisnik/gists{/gist_id}","starred_url":"https://api.github.com/users/devisnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devisnik/subscriptions","organizations_url":"https://api.github.com/users/devisnik/orgs","repos_url":"https://api.github.com/users/devisnik/repos","events_url":"https://api.github.com/users/devisnik/events{/privacy}","received_events_url":"https://api.github.com/users/devisnik/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/novoda/spikes/pulls/166/commits","review_comments_url":"https://api.github.com/repos/novoda/spikes/pulls/166/comments","review_comment_url":"https://api.github.com/repos/novoda/spikes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/novoda/spikes/issues/166/comments","statuses_url":"https://api.github.com/repos/novoda/spikes/statuses/ccfc7e838c236f1d99b78e173f1bf1f44830f746","head":{"label":"novoda:static-analysis-plugin/init","ref":"static-analysis-plugin/init","sha":"ccfc7e838c236f1d99b78e173f1bf1f44830f746","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":13300550,"name":"spikes","full_name":"novoda/spikes","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/spikes","description":"Where ideas & concepts are born & incubated","fork":false,"url":"https://api.github.com/repos/novoda/spikes","forks_url":"https://api.github.com/repos/novoda/spikes/forks","keys_url":"https://api.github.com/repos/novoda/spikes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/spikes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/spikes/teams","hooks_url":"https://api.github.com/repos/novoda/spikes/hooks","issue_events_url":"https://api.github.com/repos/novoda/spikes/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/spikes/events","assignees_url":"https://api.github.com/repos/novoda/spikes/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/spikes/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/spikes/tags","blobs_url":"https://api.github.com/repos/novoda/spikes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/spikes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/spikes/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/spikes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/spikes/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/spikes/languages","stargazers_url":"https://api.github.com/repos/novoda/spikes/stargazers","contributors_url":"https://api.github.com/repos/novoda/spikes/contributors","subscribers_url":"https://api.github.com/repos/novoda/spikes/subscribers","subscription_url":"https://api.github.com/repos/novoda/spikes/subscription","commits_url":"https://api.github.com/repos/novoda/spikes/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/spikes/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/spikes/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/spikes/issues/comments{/number}","contents_url":"https://api.github.com/repos/novoda/spikes/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/spikes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/spikes/merges","archive_url":"https://api.github.com/repos/novoda/spikes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/spikes/downloads","issues_url":"https://api.github.com/repos/novoda/spikes/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/spikes/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/spikes/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/spikes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/spikes/labels{/name}","releases_url":"https://api.github.com/repos/novoda/spikes/releases{/id}","deployments_url":"https://api.github.com/repos/novoda/spikes/deployments","created_at":"2013-10-03T14:31:43Z","updated_at":"2016-10-14T09:01:42Z","pushed_at":"2016-10-16T14:14:51Z","git_url":"git://github.com/novoda/spikes.git","ssh_url":"git@github.com:novoda/spikes.git","clone_url":"https://github.com/novoda/spikes.git","svn_url":"https://github.com/novoda/spikes","homepage":"","size":44814,"stargazers_count":191,"watchers_count":191,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":4,"forks":38,"open_issues":4,"watchers":191,"default_branch":"master"}},"base":{"label":"novoda:master","ref":"master","sha":"9ffba1f8e6a1b40c7d4f56965c8ed7afbae81b33","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":13300550,"name":"spikes","full_name":"novoda/spikes","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/spikes","description":"Where ideas & concepts are born & incubated","fork":false,"url":"https://api.github.com/repos/novoda/spikes","forks_url":"https://api.github.com/repos/novoda/spikes/forks","keys_url":"https://api.github.com/repos/novoda/spikes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/spikes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/spikes/teams","hooks_url":"https://api.github.com/repos/novoda/spikes/hooks","issue_events_url":"https://api.github.com/repos/novoda/spikes/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/spikes/events","assignees_url":"https://api.github.com/repos/novoda/spikes/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/spikes/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/spikes/tags","blobs_url":"https://api.github.com/repos/novoda/spikes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/spikes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/spikes/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/spikes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/spikes/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/spikes/languages","stargazers_url":"https://api.github.com/repos/novoda/spikes/stargazers","contributors_url":"https://api.github.com/repos/novoda/spikes/contributors","subscribers_url":"https://api.github.com/repos/novoda/spikes/subscribers","subscription_url":"https://api.github.com/repos/novoda/spikes/subscription","commits_url":"https://api.github.com/repos/novoda/spikes/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/spikes/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/spikes/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/spikes/issues/comments{/number}","contents_url":"https://api.github.com/repos/novoda/spikes/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/spikes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/spikes/merges","archive_url":"https://api.github.com/repos/novoda/spikes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/spikes/downloads","issues_url":"https://api.github.com/repos/novoda/spikes/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/spikes/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/spikes/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/spikes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/spikes/labels{/name}","releases_url":"https://api.github.com/repos/novoda/spikes/releases{/id}","deployments_url":"https://api.github.com/repos/novoda/spikes/deployments","created_at":"2013-10-03T14:31:43Z","updated_at":"2016-10-14T09:01:42Z","pushed_at":"2016-10-16T14:14:51Z","git_url":"git://github.com/novoda/spikes.git","ssh_url":"git@github.com:novoda/spikes.git","clone_url":"https://github.com/novoda/spikes.git","svn_url":"https://github.com/novoda/spikes","homepage":"","size":44814,"stargazers_count":191,"watchers_count":191,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":4,"forks":38,"open_issues":4,"watchers":191,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/novoda/spikes/pulls/166"},"html":{"href":"https://github.com/novoda/spikes/pull/166"},"issue":{"href":"https://api.github.com/repos/novoda/spikes/issues/166"},"comments":{"href":"https://api.github.com/repos/novoda/spikes/issues/166/comments"},"review_comments":{"href":"https://api.github.com/repos/novoda/spikes/pulls/166/comments"},"review_comment":{"href":"https://api.github.com/repos/novoda/spikes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/novoda/spikes/pulls/166/commits"},"statuses":{"href":"https://api.github.com/repos/novoda/spikes/statuses/ccfc7e838c236f1d99b78e173f1bf1f44830f746"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mr-archano","id":1069201,"avatar_url":"https://avatars.githubusercontent.com/u/1069201?v=3","gravatar_id":"","url":"https://api.github.com/users/mr-archano","html_url":"https://github.com/mr-archano","followers_url":"https://api.github.com/users/mr-archano/followers","following_url":"https://api.github.com/users/mr-archano/following{/other_user}","gists_url":"https://api.github.com/users/mr-archano/gists{/gist_id}","starred_url":"https://api.github.com/users/mr-archano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mr-archano/subscriptions","organizations_url":"https://api.github.com/users/mr-archano/orgs","repos_url":"https://api.github.com/users/mr-archano/repos","events_url":"https://api.github.com/users/mr-archano/events{/privacy}","received_events_url":"https://api.github.com/users/mr-archano/received_events","type":"User","site_admin":false},"comments":0,"review_comments":26,"commits":26,"additions":1008,"deletions":0,"changed_files":25}}
{"actor":{"display_login":"mr-archano"}}