{"action":"created","comment":{"url":"https://api.github.com/repos/SumOfUs/Champaign/pulls/comments/75829581","id":75829581,"diff_hunk":"@@ -23,13 +20,98 @@ def auth_headers\n     it 'returns member information for the member' do\n       get \"/api/stateless/members/#{member.id}\", nil, auth_headers\n       expect(response.status).to eq(200)\n-      expect(json_hash.keys).to include('id', 'first_name', 'last_name', 'email')\n+      expect(json_hash.keys).to include('id', 'first_name', 'last_name', 'email', 'country', 'city', 'postal', 'address1', 'address2')\n       expect(json_hash).to match({\n-                                   id: member.id,\n-                                   first_name: member.first_name,\n-                                   last_name: member.last_name,\n-                                   email: member.email\n-                                 }.as_json)\n+         id: member.id,\n+         first_name: member.first_name,\n+         last_name: member.last_name,\n+         email: member.email,\n+         country: member.country,\n+         city: member.city,\n+         postal: member.postal,\n+         address1: member.address1,\n+         address2: member.address2\n+       }.as_json)\n+    end\n+  end\n+\n+  describe 'PUT update' do\n+    context 'with valid parameters' do\n+\n+      let(:params) {{\n+        member: {\n+          first_name: \"Harry\",\n+          last_name: \"Tubman\",\n+          email: \"test+1@example.com\",\n+          country: \"United Kingdom\",\n+          city: \"London\",\n+          postal: \"12345\",\n+          address1: \"Jam Factory 123\"\n+        }\n+      }}\n+\n+      subject do\n+        put \"/api/stateless/members/#{member.id}\", params, auth_headers\n+      end\n+\n+      it 'updates the member locally and sends it back as json' do\n+        subject\n+        expect(json_hash).to match({\n+                                     id: member.id,\n+                                     first_name:  params[:member][:first_name],\n+                                     last_name:  params[:member][:last_name],\n+                                     email:  params[:member][:email],\n+                                     country:  params[:member][:country],\n+                                     city:  params[:member][:city],\n+                                     postal:  params[:member][:postal],\n+                                     address1:  params[:member][:address1],\n+                                     address2:  params[:member][:address2]\n+                                   }.as_json)\n+      end\n+\n+      it 'sends the message to the AK processor' do\n+        allow(ChampaignQueue).to receive(:push)","path":"spec/requests/api/stateless/members_spec.rb","position":79,"original_position":79,"commit_id":"cbb262be62fdda2059edca78699856e86a400d47","original_commit_id":"cbb262be62fdda2059edca78699856e86a400d47","user":{"login":"osahyoun","id":12949,"avatar_url":"https://avatars.githubusercontent.com/u/12949?v=3","gravatar_id":"","url":"https://api.github.com/users/osahyoun","html_url":"https://github.com/osahyoun","followers_url":"https://api.github.com/users/osahyoun/followers","following_url":"https://api.github.com/users/osahyoun/following{/other_user}","gists_url":"https://api.github.com/users/osahyoun/gists{/gist_id}","starred_url":"https://api.github.com/users/osahyoun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osahyoun/subscriptions","organizations_url":"https://api.github.com/users/osahyoun/orgs","repos_url":"https://api.github.com/users/osahyoun/repos","events_url":"https://api.github.com/users/osahyoun/events{/privacy}","received_events_url":"https://api.github.com/users/osahyoun/received_events","type":"User","site_admin":false},"body":"I was going to say that it's an expensive operation we should stop from executing for each spec, but I've just checked the code and I see we're returning `false` outside of production:\r\n\r\n```ruby\r\n  def push(opts)\r\n    if Rails.env.production?\r\n      client.push(opts)\r\n    else\r\n      false\r\n    end\r\n  end\r\n```","created_at":"2016-08-23T09:21:57Z","updated_at":"2016-08-23T09:21:57Z","html_url":"https://github.com/SumOfUs/Champaign/pull/635#discussion_r75829581","pull_request_url":"https://api.github.com/repos/SumOfUs/Champaign/pulls/635","_links":{"self":{"href":"https://api.github.com/repos/SumOfUs/Champaign/pulls/comments/75829581"},"html":{"href":"https://github.com/SumOfUs/Champaign/pull/635#discussion_r75829581"},"pull_request":{"href":"https://api.github.com/repos/SumOfUs/Champaign/pulls/635"}}},"pull_request":{"url":"https://api.github.com/repos/SumOfUs/Champaign/pulls/635","id":82197360,"html_url":"https://github.com/SumOfUs/Champaign/pull/635","diff_url":"https://github.com/SumOfUs/Champaign/pull/635.diff","patch_url":"https://github.com/SumOfUs/Champaign/pull/635.patch","issue_url":"https://api.github.com/repos/SumOfUs/Champaign/issues/635","number":635,"state":"open","locked":false,"title":"Update member","user":{"login":"Tuuleh","id":6524052,"avatar_url":"https://avatars.githubusercontent.com/u/6524052?v=3","gravatar_id":"","url":"https://api.github.com/users/Tuuleh","html_url":"https://github.com/Tuuleh","followers_url":"https://api.github.com/users/Tuuleh/followers","following_url":"https://api.github.com/users/Tuuleh/following{/other_user}","gists_url":"https://api.github.com/users/Tuuleh/gists{/gist_id}","starred_url":"https://api.github.com/users/Tuuleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tuuleh/subscriptions","organizations_url":"https://api.github.com/users/Tuuleh/orgs","repos_url":"https://api.github.com/users/Tuuleh/repos","events_url":"https://api.github.com/users/Tuuleh/events{/privacy}","received_events_url":"https://api.github.com/users/Tuuleh/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-22T14:08:00Z","updated_at":"2016-08-23T09:21:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6272f166c5eeab0cf3537ac9824fd00f80292157","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SumOfUs/Champaign/pulls/635/commits","review_comments_url":"https://api.github.com/repos/SumOfUs/Champaign/pulls/635/comments","review_comment_url":"https://api.github.com/repos/SumOfUs/Champaign/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SumOfUs/Champaign/issues/635/comments","statuses_url":"https://api.github.com/repos/SumOfUs/Champaign/statuses/cbb262be62fdda2059edca78699856e86a400d47","head":{"label":"SumOfUs:update-member","ref":"update-member","sha":"cbb262be62fdda2059edca78699856e86a400d47","user":{"login":"SumOfUs","id":7574652,"avatar_url":"https://avatars.githubusercontent.com/u/7574652?v=3","gravatar_id":"","url":"https://api.github.com/users/SumOfUs","html_url":"https://github.com/SumOfUs","followers_url":"https://api.github.com/users/SumOfUs/followers","following_url":"https://api.github.com/users/SumOfUs/following{/other_user}","gists_url":"https://api.github.com/users/SumOfUs/gists{/gist_id}","starred_url":"https://api.github.com/users/SumOfUs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SumOfUs/subscriptions","organizations_url":"https://api.github.com/users/SumOfUs/orgs","repos_url":"https://api.github.com/users/SumOfUs/repos","events_url":"https://api.github.com/users/SumOfUs/events{/privacy}","received_events_url":"https://api.github.com/users/SumOfUs/received_events","type":"Organization","site_admin":false},"repo":{"id":33684818,"name":"Champaign","full_name":"SumOfUs/Champaign","owner":{"login":"SumOfUs","id":7574652,"avatar_url":"https://avatars.githubusercontent.com/u/7574652?v=3","gravatar_id":"","url":"https://api.github.com/users/SumOfUs","html_url":"https://github.com/SumOfUs","followers_url":"https://api.github.com/users/SumOfUs/followers","following_url":"https://api.github.com/users/SumOfUs/following{/other_user}","gists_url":"https://api.github.com/users/SumOfUs/gists{/gist_id}","starred_url":"https://api.github.com/users/SumOfUs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SumOfUs/subscriptions","organizations_url":"https://api.github.com/users/SumOfUs/orgs","repos_url":"https://api.github.com/users/SumOfUs/repos","events_url":"https://api.github.com/users/SumOfUs/events{/privacy}","received_events_url":"https://api.github.com/users/SumOfUs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SumOfUs/Champaign","description":"SumOfUs Online Campaign Platform.","fork":false,"url":"https://api.github.com/repos/SumOfUs/Champaign","forks_url":"https://api.github.com/repos/SumOfUs/Champaign/forks","keys_url":"https://api.github.com/repos/SumOfUs/Champaign/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SumOfUs/Champaign/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SumOfUs/Champaign/teams","hooks_url":"https://api.github.com/repos/SumOfUs/Champaign/hooks","issue_events_url":"https://api.github.com/repos/SumOfUs/Champaign/issues/events{/number}","events_url":"https://api.github.com/repos/SumOfUs/Champaign/events","assignees_url":"https://api.github.com/repos/SumOfUs/Champaign/assignees{/user}","branches_url":"https://api.github.com/repos/SumOfUs/Champaign/branches{/branch}","tags_url":"https://api.github.com/repos/SumOfUs/Champaign/tags","blobs_url":"https://api.github.com/repos/SumOfUs/Champaign/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SumOfUs/Champaign/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SumOfUs/Champaign/git/refs{/sha}","trees_url":"https://api.github.com/repos/SumOfUs/Champaign/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SumOfUs/Champaign/statuses/{sha}","languages_url":"https://api.github.com/repos/SumOfUs/Champaign/languages","stargazers_url":"https://api.github.com/repos/SumOfUs/Champaign/stargazers","contributors_url":"https://api.github.com/repos/SumOfUs/Champaign/contributors","subscribers_url":"https://api.github.com/repos/SumOfUs/Champaign/subscribers","subscription_url":"https://api.github.com/repos/SumOfUs/Champaign/subscription","commits_url":"https://api.github.com/repos/SumOfUs/Champaign/commits{/sha}","git_commits_url":"https://api.github.com/repos/SumOfUs/Champaign/git/commits{/sha}","comments_url":"https://api.github.com/repos/SumOfUs/Champaign/comments{/number}","issue_comment_url":"https://api.github.com/repos/SumOfUs/Champaign/issues/comments{/number}","contents_url":"https://api.github.com/repos/SumOfUs/Champaign/contents/{+path}","compare_url":"https://api.github.com/repos/SumOfUs/Champaign/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SumOfUs/Champaign/merges","archive_url":"https://api.github.com/repos/SumOfUs/Champaign/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SumOfUs/Champaign/downloads","issues_url":"https://api.github.com/repos/SumOfUs/Champaign/issues{/number}","pulls_url":"https://api.github.com/repos/SumOfUs/Champaign/pulls{/number}","milestones_url":"https://api.github.com/repos/SumOfUs/Champaign/milestones{/number}","notifications_url":"https://api.github.com/repos/SumOfUs/Champaign/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SumOfUs/Champaign/labels{/name}","releases_url":"https://api.github.com/repos/SumOfUs/Champaign/releases{/id}","deployments_url":"https://api.github.com/repos/SumOfUs/Champaign/deployments","created_at":"2015-04-09T18:16:20Z","updated_at":"2016-07-27T13:12:35Z","pushed_at":"2016-08-23T09:02:21Z","git_url":"git://github.com/SumOfUs/Champaign.git","ssh_url":"git@github.com:SumOfUs/Champaign.git","clone_url":"https://github.com/SumOfUs/Champaign.git","svn_url":"https://github.com/SumOfUs/Champaign","homepage":null,"size":10280,"stargazers_count":25,"watchers_count":25,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":18,"forks":10,"open_issues":18,"watchers":25,"default_branch":"development"}},"base":{"label":"SumOfUs:membersapi","ref":"membersapi","sha":"49ea2482a57369d581c9dcbd25d7426f03142071","user":{"login":"SumOfUs","id":7574652,"avatar_url":"https://avatars.githubusercontent.com/u/7574652?v=3","gravatar_id":"","url":"https://api.github.com/users/SumOfUs","html_url":"https://github.com/SumOfUs","followers_url":"https://api.github.com/users/SumOfUs/followers","following_url":"https://api.github.com/users/SumOfUs/following{/other_user}","gists_url":"https://api.github.com/users/SumOfUs/gists{/gist_id}","starred_url":"https://api.github.com/users/SumOfUs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SumOfUs/subscriptions","organizations_url":"https://api.github.com/users/SumOfUs/orgs","repos_url":"https://api.github.com/users/SumOfUs/repos","events_url":"https://api.github.com/users/SumOfUs/events{/privacy}","received_events_url":"https://api.github.com/users/SumOfUs/received_events","type":"Organization","site_admin":false},"repo":{"id":33684818,"name":"Champaign","full_name":"SumOfUs/Champaign","owner":{"login":"SumOfUs","id":7574652,"avatar_url":"https://avatars.githubusercontent.com/u/7574652?v=3","gravatar_id":"","url":"https://api.github.com/users/SumOfUs","html_url":"https://github.com/SumOfUs","followers_url":"https://api.github.com/users/SumOfUs/followers","following_url":"https://api.github.com/users/SumOfUs/following{/other_user}","gists_url":"https://api.github.com/users/SumOfUs/gists{/gist_id}","starred_url":"https://api.github.com/users/SumOfUs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SumOfUs/subscriptions","organizations_url":"https://api.github.com/users/SumOfUs/orgs","repos_url":"https://api.github.com/users/SumOfUs/repos","events_url":"https://api.github.com/users/SumOfUs/events{/privacy}","received_events_url":"https://api.github.com/users/SumOfUs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SumOfUs/Champaign","description":"SumOfUs Online Campaign Platform.","fork":false,"url":"https://api.github.com/repos/SumOfUs/Champaign","forks_url":"https://api.github.com/repos/SumOfUs/Champaign/forks","keys_url":"https://api.github.com/repos/SumOfUs/Champaign/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SumOfUs/Champaign/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SumOfUs/Champaign/teams","hooks_url":"https://api.github.com/repos/SumOfUs/Champaign/hooks","issue_events_url":"https://api.github.com/repos/SumOfUs/Champaign/issues/events{/number}","events_url":"https://api.github.com/repos/SumOfUs/Champaign/events","assignees_url":"https://api.github.com/repos/SumOfUs/Champaign/assignees{/user}","branches_url":"https://api.github.com/repos/SumOfUs/Champaign/branches{/branch}","tags_url":"https://api.github.com/repos/SumOfUs/Champaign/tags","blobs_url":"https://api.github.com/repos/SumOfUs/Champaign/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SumOfUs/Champaign/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SumOfUs/Champaign/git/refs{/sha}","trees_url":"https://api.github.com/repos/SumOfUs/Champaign/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SumOfUs/Champaign/statuses/{sha}","languages_url":"https://api.github.com/repos/SumOfUs/Champaign/languages","stargazers_url":"https://api.github.com/repos/SumOfUs/Champaign/stargazers","contributors_url":"https://api.github.com/repos/SumOfUs/Champaign/contributors","subscribers_url":"https://api.github.com/repos/SumOfUs/Champaign/subscribers","subscription_url":"https://api.github.com/repos/SumOfUs/Champaign/subscription","commits_url":"https://api.github.com/repos/SumOfUs/Champaign/commits{/sha}","git_commits_url":"https://api.github.com/repos/SumOfUs/Champaign/git/commits{/sha}","comments_url":"https://api.github.com/repos/SumOfUs/Champaign/comments{/number}","issue_comment_url":"https://api.github.com/repos/SumOfUs/Champaign/issues/comments{/number}","contents_url":"https://api.github.com/repos/SumOfUs/Champaign/contents/{+path}","compare_url":"https://api.github.com/repos/SumOfUs/Champaign/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SumOfUs/Champaign/merges","archive_url":"https://api.github.com/repos/SumOfUs/Champaign/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SumOfUs/Champaign/downloads","issues_url":"https://api.github.com/repos/SumOfUs/Champaign/issues{/number}","pulls_url":"https://api.github.com/repos/SumOfUs/Champaign/pulls{/number}","milestones_url":"https://api.github.com/repos/SumOfUs/Champaign/milestones{/number}","notifications_url":"https://api.github.com/repos/SumOfUs/Champaign/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SumOfUs/Champaign/labels{/name}","releases_url":"https://api.github.com/repos/SumOfUs/Champaign/releases{/id}","deployments_url":"https://api.github.com/repos/SumOfUs/Champaign/deployments","created_at":"2015-04-09T18:16:20Z","updated_at":"2016-07-27T13:12:35Z","pushed_at":"2016-08-23T09:02:21Z","git_url":"git://github.com/SumOfUs/Champaign.git","ssh_url":"git@github.com:SumOfUs/Champaign.git","clone_url":"https://github.com/SumOfUs/Champaign.git","svn_url":"https://github.com/SumOfUs/Champaign","homepage":null,"size":10280,"stargazers_count":25,"watchers_count":25,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":18,"forks":10,"open_issues":18,"watchers":25,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/SumOfUs/Champaign/pulls/635"},"html":{"href":"https://github.com/SumOfUs/Champaign/pull/635"},"issue":{"href":"https://api.github.com/repos/SumOfUs/Champaign/issues/635"},"comments":{"href":"https://api.github.com/repos/SumOfUs/Champaign/issues/635/comments"},"review_comments":{"href":"https://api.github.com/repos/SumOfUs/Champaign/pulls/635/comments"},"review_comment":{"href":"https://api.github.com/repos/SumOfUs/Champaign/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SumOfUs/Champaign/pulls/635/commits"},"statuses":{"href":"https://api.github.com/repos/SumOfUs/Champaign/statuses/cbb262be62fdda2059edca78699856e86a400d47"}}}}
{"actor":{"display_login":"osahyoun"}}