{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppet/issues/4660","repository_url":"https://api.github.com/repos/puppetlabs/puppet","labels_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4660/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4660/comments","events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4660/events","html_url":"https://github.com/puppetlabs/puppet/pull/4660","id":133109868,"number":4660,"title":"(maint) Use catalog and resource matchers","user":{"login":"joshcooper","id":737664,"avatar_url":"https://avatars.githubusercontent.com/u/737664?v=3","gravatar_id":"","url":"https://api.github.com/users/joshcooper","html_url":"https://github.com/joshcooper","followers_url":"https://api.github.com/users/joshcooper/followers","following_url":"https://api.github.com/users/joshcooper/following{/other_user}","gists_url":"https://api.github.com/users/joshcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcooper/subscriptions","organizations_url":"https://api.github.com/users/joshcooper/orgs","repos_url":"https://api.github.com/users/joshcooper/repos","events_url":"https://api.github.com/users/joshcooper/events{/privacy}","received_events_url":"https://api.github.com/users/joshcooper/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-11T22:56:40Z","updated_at":"2016-02-11T23:05:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/4660","html_url":"https://github.com/puppetlabs/puppet/pull/4660","diff_url":"https://github.com/puppetlabs/puppet/pull/4660.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/4660.patch"},"body":"Refactor the inline catalog unit tests to use `manifest_to_catalog` helper and resource matchers. I ran into an issue where generated resources didn't have an ensure value and calling `to_ral` doesn't work when you're on *nix and it's a Windows file path. The ensure value part is fixed in this PR, and I added a pending test for the second part. I recommend using `git log -p --reverse --patience 0dfeecd..` to review the changes."},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/183094431","html_url":"https://github.com/puppetlabs/puppet/pull/4660#issuecomment-183094431","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4660","id":183094431,"user":{"login":"kylog","id":1752967,"avatar_url":"https://avatars.githubusercontent.com/u/1752967?v=3","gravatar_id":"","url":"https://api.github.com/users/kylog","html_url":"https://github.com/kylog","followers_url":"https://api.github.com/users/kylog/followers","following_url":"https://api.github.com/users/kylog/following{/other_user}","gists_url":"https://api.github.com/users/kylog/gists{/gist_id}","starred_url":"https://api.github.com/users/kylog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylog/subscriptions","organizations_url":"https://api.github.com/users/kylog/orgs","repos_url":"https://api.github.com/users/kylog/repos","events_url":"https://api.github.com/users/kylog/events{/privacy}","received_events_url":"https://api.github.com/users/kylog/received_events","type":"User","site_admin":false},"created_at":"2016-02-11T23:05:39Z","updated_at":"2016-02-11T23:05:39Z","body":"Does the \"Set ensure value for generated resources\" part merit a PUP ticket? Not sure what the consequences are tbh."}}