{"action":"created","comment":{"url":"https://api.github.com/repos/IIIF/mirador/pulls/comments/76478976","id":76478976,"diff_hunk":"@@ -386,6 +131,265 @@\n     listenForActions: function() {\n       var _this = this;\n \n+      this._thisResize = function(){\n+        _this.resize();\n+      };\n+      this._thisRotate = function(event) {\n+        _this.rotate(event);\n+        _this.resize();\n+      };\n+      this.viewer.addHandler('animation', this._thisResize);\n+      this.viewer.addHandler('open', this._thisResize);\n+      this.viewer.addHandler('animation-finish', this._thisResize);\n+      this.viewer.addHandler('update-viewport', this._thisResize);\n+      this.viewer.addHandler('resize',this._thisResize);\n+      this.viewer.addHandler('rotate', this._thisRotate);\n+      this.viewer.addHandler('constrain',this._thisResize);\n+\n+      this._thisDestroy = function(){\n+        _this.destroy();\n+      };\n+\n+      this.viewer.addHandler('close',this._thisDestroy);\n+\n+      this.eventsSubscriptions.push(this.eventEmitter.subscribe('DESTROY_EVENTS.'+this.windowId, function(event) {","path":"js/src/annotations/osd-svg-overlay.js","position":287,"original_position":287,"commit_id":"b66d762525fa9da1b7001a6cb6b858e8d1b85389","original_commit_id":"b66d762525fa9da1b7001a6cb6b858e8d1b85389","user":{"login":"radpet","id":13572835,"avatar_url":"https://avatars.githubusercontent.com/u/13572835?v=3","gravatar_id":"","url":"https://api.github.com/users/radpet","html_url":"https://github.com/radpet","followers_url":"https://api.github.com/users/radpet/followers","following_url":"https://api.github.com/users/radpet/following{/other_user}","gists_url":"https://api.github.com/users/radpet/gists{/gist_id}","starred_url":"https://api.github.com/users/radpet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radpet/subscriptions","organizations_url":"https://api.github.com/users/radpet/orgs","repos_url":"https://api.github.com/users/radpet/repos","events_url":"https://api.github.com/users/radpet/events{/privacy}","received_events_url":"https://api.github.com/users/radpet/received_events","type":"User","site_admin":false},"body":"Do you unsubscribe for this event in the destroy()?","created_at":"2016-08-26T19:58:31Z","updated_at":"2016-08-26T19:58:31Z","html_url":"https://github.com/IIIF/mirador/pull/1079#discussion_r76478976","pull_request_url":"https://api.github.com/repos/IIIF/mirador/pulls/1079","_links":{"self":{"href":"https://api.github.com/repos/IIIF/mirador/pulls/comments/76478976"},"html":{"href":"https://github.com/IIIF/mirador/pull/1079#discussion_r76478976"},"pull_request":{"href":"https://api.github.com/repos/IIIF/mirador/pulls/1079"}}},"pull_request":{"url":"https://api.github.com/repos/IIIF/mirador/pulls/1079","id":82944505,"html_url":"https://github.com/IIIF/mirador/pull/1079","diff_url":"https://github.com/IIIF/mirador/pull/1079.diff","patch_url":"https://github.com/IIIF/mirador/pull/1079.patch","issue_url":"https://api.github.com/repos/IIIF/mirador/issues/1079","number":1079,"state":"closed","locked":false,"title":"whenever window is initialized or updated, make sure we unsubscribe f…","user":{"login":"rsinghal","id":2371632,"avatar_url":"https://avatars.githubusercontent.com/u/2371632?v=3","gravatar_id":"","url":"https://api.github.com/users/rsinghal","html_url":"https://github.com/rsinghal","followers_url":"https://api.github.com/users/rsinghal/followers","following_url":"https://api.github.com/users/rsinghal/following{/other_user}","gists_url":"https://api.github.com/users/rsinghal/gists{/gist_id}","starred_url":"https://api.github.com/users/rsinghal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsinghal/subscriptions","organizations_url":"https://api.github.com/users/rsinghal/orgs","repos_url":"https://api.github.com/users/rsinghal/repos","events_url":"https://api.github.com/users/rsinghal/events{/privacy}","received_events_url":"https://api.github.com/users/rsinghal/received_events","type":"User","site_admin":false},"body":"…rom any events in odd-region-draw-tool and osd-svg-overlay, since they will be re-subscribed\r\ncloses #1075 ","created_at":"2016-08-26T19:53:23Z","updated_at":"2016-08-26T19:58:31Z","closed_at":"2016-08-26T19:58:19Z","merged_at":"2016-08-26T19:58:19Z","merge_commit_sha":"c1186a00e03e04d533da127d199fcee25c38ff8e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/IIIF/mirador/pulls/1079/commits","review_comments_url":"https://api.github.com/repos/IIIF/mirador/pulls/1079/comments","review_comment_url":"https://api.github.com/repos/IIIF/mirador/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IIIF/mirador/issues/1079/comments","statuses_url":"https://api.github.com/repos/IIIF/mirador/statuses/b66d762525fa9da1b7001a6cb6b858e8d1b85389","head":{"label":"IIIF:1075-destroy-events","ref":"1075-destroy-events","sha":"b66d762525fa9da1b7001a6cb6b858e8d1b85389","user":{"login":"IIIF","id":5812589,"avatar_url":"https://avatars.githubusercontent.com/u/5812589?v=3","gravatar_id":"","url":"https://api.github.com/users/IIIF","html_url":"https://github.com/IIIF","followers_url":"https://api.github.com/users/IIIF/followers","following_url":"https://api.github.com/users/IIIF/following{/other_user}","gists_url":"https://api.github.com/users/IIIF/gists{/gist_id}","starred_url":"https://api.github.com/users/IIIF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IIIF/subscriptions","organizations_url":"https://api.github.com/users/IIIF/orgs","repos_url":"https://api.github.com/users/IIIF/repos","events_url":"https://api.github.com/users/IIIF/events{/privacy}","received_events_url":"https://api.github.com/users/IIIF/received_events","type":"Organization","site_admin":false},"repo":{"id":19078059,"name":"mirador","full_name":"IIIF/mirador","owner":{"login":"IIIF","id":5812589,"avatar_url":"https://avatars.githubusercontent.com/u/5812589?v=3","gravatar_id":"","url":"https://api.github.com/users/IIIF","html_url":"https://github.com/IIIF","followers_url":"https://api.github.com/users/IIIF/followers","following_url":"https://api.github.com/users/IIIF/following{/other_user}","gists_url":"https://api.github.com/users/IIIF/gists{/gist_id}","starred_url":"https://api.github.com/users/IIIF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IIIF/subscriptions","organizations_url":"https://api.github.com/users/IIIF/orgs","repos_url":"https://api.github.com/users/IIIF/repos","events_url":"https://api.github.com/users/IIIF/events{/privacy}","received_events_url":"https://api.github.com/users/IIIF/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IIIF/mirador","description":"An open-source, web-based 'multi-up' viewer that supports zoom-pan-rotate functionality, ability to display/compare simple images, and images with annotations.","fork":false,"url":"https://api.github.com/repos/IIIF/mirador","forks_url":"https://api.github.com/repos/IIIF/mirador/forks","keys_url":"https://api.github.com/repos/IIIF/mirador/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IIIF/mirador/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IIIF/mirador/teams","hooks_url":"https://api.github.com/repos/IIIF/mirador/hooks","issue_events_url":"https://api.github.com/repos/IIIF/mirador/issues/events{/number}","events_url":"https://api.github.com/repos/IIIF/mirador/events","assignees_url":"https://api.github.com/repos/IIIF/mirador/assignees{/user}","branches_url":"https://api.github.com/repos/IIIF/mirador/branches{/branch}","tags_url":"https://api.github.com/repos/IIIF/mirador/tags","blobs_url":"https://api.github.com/repos/IIIF/mirador/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IIIF/mirador/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IIIF/mirador/git/refs{/sha}","trees_url":"https://api.github.com/repos/IIIF/mirador/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IIIF/mirador/statuses/{sha}","languages_url":"https://api.github.com/repos/IIIF/mirador/languages","stargazers_url":"https://api.github.com/repos/IIIF/mirador/stargazers","contributors_url":"https://api.github.com/repos/IIIF/mirador/contributors","subscribers_url":"https://api.github.com/repos/IIIF/mirador/subscribers","subscription_url":"https://api.github.com/repos/IIIF/mirador/subscription","commits_url":"https://api.github.com/repos/IIIF/mirador/commits{/sha}","git_commits_url":"https://api.github.com/repos/IIIF/mirador/git/commits{/sha}","comments_url":"https://api.github.com/repos/IIIF/mirador/comments{/number}","issue_comment_url":"https://api.github.com/repos/IIIF/mirador/issues/comments{/number}","contents_url":"https://api.github.com/repos/IIIF/mirador/contents/{+path}","compare_url":"https://api.github.com/repos/IIIF/mirador/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IIIF/mirador/merges","archive_url":"https://api.github.com/repos/IIIF/mirador/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IIIF/mirador/downloads","issues_url":"https://api.github.com/repos/IIIF/mirador/issues{/number}","pulls_url":"https://api.github.com/repos/IIIF/mirador/pulls{/number}","milestones_url":"https://api.github.com/repos/IIIF/mirador/milestones{/number}","notifications_url":"https://api.github.com/repos/IIIF/mirador/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IIIF/mirador/labels{/name}","releases_url":"https://api.github.com/repos/IIIF/mirador/releases{/id}","deployments_url":"https://api.github.com/repos/IIIF/mirador/deployments","created_at":"2014-04-23T17:02:00Z","updated_at":"2016-08-24T22:50:38Z","pushed_at":"2016-08-26T19:58:19Z","git_url":"git://github.com/IIIF/mirador.git","ssh_url":"git@github.com:IIIF/mirador.git","clone_url":"https://github.com/IIIF/mirador.git","svn_url":"https://github.com/IIIF/mirador","homepage":"","size":13048,"stargazers_count":110,"watchers_count":110,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":66,"mirror_url":null,"open_issues_count":194,"forks":66,"open_issues":194,"watchers":110,"default_branch":"release2.1"}},"base":{"label":"IIIF:release2.1","ref":"release2.1","sha":"09457bf8afbacfa651d80a17c3fb4726d2d5ff77","user":{"login":"IIIF","id":5812589,"avatar_url":"https://avatars.githubusercontent.com/u/5812589?v=3","gravatar_id":"","url":"https://api.github.com/users/IIIF","html_url":"https://github.com/IIIF","followers_url":"https://api.github.com/users/IIIF/followers","following_url":"https://api.github.com/users/IIIF/following{/other_user}","gists_url":"https://api.github.com/users/IIIF/gists{/gist_id}","starred_url":"https://api.github.com/users/IIIF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IIIF/subscriptions","organizations_url":"https://api.github.com/users/IIIF/orgs","repos_url":"https://api.github.com/users/IIIF/repos","events_url":"https://api.github.com/users/IIIF/events{/privacy}","received_events_url":"https://api.github.com/users/IIIF/received_events","type":"Organization","site_admin":false},"repo":{"id":19078059,"name":"mirador","full_name":"IIIF/mirador","owner":{"login":"IIIF","id":5812589,"avatar_url":"https://avatars.githubusercontent.com/u/5812589?v=3","gravatar_id":"","url":"https://api.github.com/users/IIIF","html_url":"https://github.com/IIIF","followers_url":"https://api.github.com/users/IIIF/followers","following_url":"https://api.github.com/users/IIIF/following{/other_user}","gists_url":"https://api.github.com/users/IIIF/gists{/gist_id}","starred_url":"https://api.github.com/users/IIIF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IIIF/subscriptions","organizations_url":"https://api.github.com/users/IIIF/orgs","repos_url":"https://api.github.com/users/IIIF/repos","events_url":"https://api.github.com/users/IIIF/events{/privacy}","received_events_url":"https://api.github.com/users/IIIF/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IIIF/mirador","description":"An open-source, web-based 'multi-up' viewer that supports zoom-pan-rotate functionality, ability to display/compare simple images, and images with annotations.","fork":false,"url":"https://api.github.com/repos/IIIF/mirador","forks_url":"https://api.github.com/repos/IIIF/mirador/forks","keys_url":"https://api.github.com/repos/IIIF/mirador/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IIIF/mirador/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IIIF/mirador/teams","hooks_url":"https://api.github.com/repos/IIIF/mirador/hooks","issue_events_url":"https://api.github.com/repos/IIIF/mirador/issues/events{/number}","events_url":"https://api.github.com/repos/IIIF/mirador/events","assignees_url":"https://api.github.com/repos/IIIF/mirador/assignees{/user}","branches_url":"https://api.github.com/repos/IIIF/mirador/branches{/branch}","tags_url":"https://api.github.com/repos/IIIF/mirador/tags","blobs_url":"https://api.github.com/repos/IIIF/mirador/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IIIF/mirador/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IIIF/mirador/git/refs{/sha}","trees_url":"https://api.github.com/repos/IIIF/mirador/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IIIF/mirador/statuses/{sha}","languages_url":"https://api.github.com/repos/IIIF/mirador/languages","stargazers_url":"https://api.github.com/repos/IIIF/mirador/stargazers","contributors_url":"https://api.github.com/repos/IIIF/mirador/contributors","subscribers_url":"https://api.github.com/repos/IIIF/mirador/subscribers","subscription_url":"https://api.github.com/repos/IIIF/mirador/subscription","commits_url":"https://api.github.com/repos/IIIF/mirador/commits{/sha}","git_commits_url":"https://api.github.com/repos/IIIF/mirador/git/commits{/sha}","comments_url":"https://api.github.com/repos/IIIF/mirador/comments{/number}","issue_comment_url":"https://api.github.com/repos/IIIF/mirador/issues/comments{/number}","contents_url":"https://api.github.com/repos/IIIF/mirador/contents/{+path}","compare_url":"https://api.github.com/repos/IIIF/mirador/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IIIF/mirador/merges","archive_url":"https://api.github.com/repos/IIIF/mirador/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IIIF/mirador/downloads","issues_url":"https://api.github.com/repos/IIIF/mirador/issues{/number}","pulls_url":"https://api.github.com/repos/IIIF/mirador/pulls{/number}","milestones_url":"https://api.github.com/repos/IIIF/mirador/milestones{/number}","notifications_url":"https://api.github.com/repos/IIIF/mirador/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IIIF/mirador/labels{/name}","releases_url":"https://api.github.com/repos/IIIF/mirador/releases{/id}","deployments_url":"https://api.github.com/repos/IIIF/mirador/deployments","created_at":"2014-04-23T17:02:00Z","updated_at":"2016-08-24T22:50:38Z","pushed_at":"2016-08-26T19:58:19Z","git_url":"git://github.com/IIIF/mirador.git","ssh_url":"git@github.com:IIIF/mirador.git","clone_url":"https://github.com/IIIF/mirador.git","svn_url":"https://github.com/IIIF/mirador","homepage":"","size":13048,"stargazers_count":110,"watchers_count":110,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":66,"mirror_url":null,"open_issues_count":194,"forks":66,"open_issues":194,"watchers":110,"default_branch":"release2.1"}},"_links":{"self":{"href":"https://api.github.com/repos/IIIF/mirador/pulls/1079"},"html":{"href":"https://github.com/IIIF/mirador/pull/1079"},"issue":{"href":"https://api.github.com/repos/IIIF/mirador/issues/1079"},"comments":{"href":"https://api.github.com/repos/IIIF/mirador/issues/1079/comments"},"review_comments":{"href":"https://api.github.com/repos/IIIF/mirador/pulls/1079/comments"},"review_comment":{"href":"https://api.github.com/repos/IIIF/mirador/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IIIF/mirador/pulls/1079/commits"},"statuses":{"href":"https://api.github.com/repos/IIIF/mirador/statuses/b66d762525fa9da1b7001a6cb6b858e8d1b85389"}}}}
{"actor":{"display_login":"radpet"}}