{"action":"created","comment":{"url":"https://api.github.com/repos/zcash/zcash/pulls/comments/78941385","id":78941385,"diff_hunk":"@@ -592,15 +592,72 @@ TEST(wallet_tests, UpdatedNoteData) {\n \n     // The txs should initially be different\n     EXPECT_NE(wtx.mapNoteData, wtx2.mapNoteData);\n-    EXPECT_NE(wtx.mapNoteData[jsoutpt].witnesses, wtx2.mapNoteData[jsoutpt].witnesses);\n+    EXPECT_EQ(1, wtx.mapNoteData[jsoutpt].witnesses.size());\n \n     // After updating, they should be the same\n-    EXPECT_TRUE(wallet.UpdatedNoteData(wtx, wtx2));\n+    EXPECT_TRUE(wallet.UpdatedNoteData(wtx2, wtx));\n     EXPECT_EQ(wtx.mapNoteData, wtx2.mapNoteData);\n-    EXPECT_EQ(wtx.mapNoteData[jsoutpt].witnesses, wtx2.mapNoteData[jsoutpt].witnesses);\n+    EXPECT_EQ(1, wtx.mapNoteData[jsoutpt].witnesses.size());\n     // TODO: The new note should get witnessed (but maybe not here) (#1350)\n }\n \n+TEST(wallet_tests, UpdatedNoteDataWhenReindexing) {\n+    TestWallet wallet;\n+\n+    // Enable reindexing\n+    SoftSetBoolArg(\"-reindex\", true);","path":"src/wallet/gtest/test_wallet.cpp","position":34,"original_position":34,"commit_id":"5105c3aab80b5fa1c97bff8b45058966981bb4eb","original_commit_id":"5105c3aab80b5fa1c97bff8b45058966981bb4eb","user":{"login":"daira","id":643204,"avatar_url":"https://avatars.githubusercontent.com/u/643204?v=3","gravatar_id":"","url":"https://api.github.com/users/daira","html_url":"https://github.com/daira","followers_url":"https://api.github.com/users/daira/followers","following_url":"https://api.github.com/users/daira/following{/other_user}","gists_url":"https://api.github.com/users/daira/gists{/gist_id}","starred_url":"https://api.github.com/users/daira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daira/subscriptions","organizations_url":"https://api.github.com/users/daira/orgs","repos_url":"https://api.github.com/users/daira/repos","events_url":"https://api.github.com/users/daira/events{/privacy}","received_events_url":"https://api.github.com/users/daira/received_events","type":"User","site_admin":false},"body":"Does this get reset after the test?","created_at":"2016-09-15T11:21:08Z","updated_at":"2016-09-15T11:21:08Z","html_url":"https://github.com/zcash/zcash/pull/1402#discussion_r78941385","pull_request_url":"https://api.github.com/repos/zcash/zcash/pulls/1402","_links":{"self":{"href":"https://api.github.com/repos/zcash/zcash/pulls/comments/78941385"},"html":{"href":"https://github.com/zcash/zcash/pull/1402#discussion_r78941385"},"pull_request":{"href":"https://api.github.com/repos/zcash/zcash/pulls/1402"}}},"pull_request":{"url":"https://api.github.com/repos/zcash/zcash/pulls/1402","id":85382218,"html_url":"https://github.com/zcash/zcash/pull/1402","diff_url":"https://github.com/zcash/zcash/pull/1402.diff","patch_url":"https://github.com/zcash/zcash/pull/1402.patch","issue_url":"https://api.github.com/repos/zcash/zcash/issues/1402","number":1402,"state":"open","locked":false,"title":"Drop note witness caches on reindexing","user":{"login":"str4d","id":4993799,"avatar_url":"https://avatars.githubusercontent.com/u/4993799?v=3","gravatar_id":"","url":"https://api.github.com/users/str4d","html_url":"https://github.com/str4d","followers_url":"https://api.github.com/users/str4d/followers","following_url":"https://api.github.com/users/str4d/following{/other_user}","gists_url":"https://api.github.com/users/str4d/gists{/gist_id}","starred_url":"https://api.github.com/users/str4d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/str4d/subscriptions","organizations_url":"https://api.github.com/users/str4d/orgs","repos_url":"https://api.github.com/users/str4d/repos","events_url":"https://api.github.com/users/str4d/events{/privacy}","received_events_url":"https://api.github.com/users/str4d/received_events","type":"User","site_admin":false},"body":"This PR also fixes a test that was passing arguments in the wrong order.\r\n\r\nCloses #1394","created_at":"2016-09-15T10:50:07Z","updated_at":"2016-09-15T11:21:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"925d98a9a635d242792790dc8157604e29c86d41","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/zcash/zcash/milestones/37","html_url":"https://github.com/zcash/zcash/milestones/1.0.0-beta2%20-%20audit%20mitigations%20and%20critical%20bug%20fixes","labels_url":"https://api.github.com/repos/zcash/zcash/milestones/37/labels","id":1927770,"number":37,"title":"1.0.0-beta2 - audit mitigations and critical bug fixes","description":"","creator":{"login":"nathan-at-least","id":4369700,"avatar_url":"https://avatars.githubusercontent.com/u/4369700?v=3","gravatar_id":"","url":"https://api.github.com/users/nathan-at-least","html_url":"https://github.com/nathan-at-least","followers_url":"https://api.github.com/users/nathan-at-least/followers","following_url":"https://api.github.com/users/nathan-at-least/following{/other_user}","gists_url":"https://api.github.com/users/nathan-at-least/gists{/gist_id}","starred_url":"https://api.github.com/users/nathan-at-least/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathan-at-least/subscriptions","organizations_url":"https://api.github.com/users/nathan-at-least/orgs","repos_url":"https://api.github.com/users/nathan-at-least/repos","events_url":"https://api.github.com/users/nathan-at-least/events{/privacy}","received_events_url":"https://api.github.com/users/nathan-at-least/received_events","type":"User","site_admin":false},"open_issues":45,"closed_issues":9,"state":"open","created_at":"2016-08-07T20:14:01Z","updated_at":"2016-09-15T10:50:07Z","due_on":"2016-10-03T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/zcash/zcash/pulls/1402/commits","review_comments_url":"https://api.github.com/repos/zcash/zcash/pulls/1402/comments","review_comment_url":"https://api.github.com/repos/zcash/zcash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zcash/zcash/issues/1402/comments","statuses_url":"https://api.github.com/repos/zcash/zcash/statuses/5105c3aab80b5fa1c97bff8b45058966981bb4eb","head":{"label":"str4d:1394-reindex-drop-witness-caches","ref":"1394-reindex-drop-witness-caches","sha":"5105c3aab80b5fa1c97bff8b45058966981bb4eb","user":{"login":"str4d","id":4993799,"avatar_url":"https://avatars.githubusercontent.com/u/4993799?v=3","gravatar_id":"","url":"https://api.github.com/users/str4d","html_url":"https://github.com/str4d","followers_url":"https://api.github.com/users/str4d/followers","following_url":"https://api.github.com/users/str4d/following{/other_user}","gists_url":"https://api.github.com/users/str4d/gists{/gist_id}","starred_url":"https://api.github.com/users/str4d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/str4d/subscriptions","organizations_url":"https://api.github.com/users/str4d/orgs","repos_url":"https://api.github.com/users/str4d/repos","events_url":"https://api.github.com/users/str4d/events{/privacy}","received_events_url":"https://api.github.com/users/str4d/received_events","type":"User","site_admin":false},"repo":{"id":52462432,"name":"zcash","full_name":"str4d/zcash","owner":{"login":"str4d","id":4993799,"avatar_url":"https://avatars.githubusercontent.com/u/4993799?v=3","gravatar_id":"","url":"https://api.github.com/users/str4d","html_url":"https://github.com/str4d","followers_url":"https://api.github.com/users/str4d/followers","following_url":"https://api.github.com/users/str4d/following{/other_user}","gists_url":"https://api.github.com/users/str4d/gists{/gist_id}","starred_url":"https://api.github.com/users/str4d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/str4d/subscriptions","organizations_url":"https://api.github.com/users/str4d/orgs","repos_url":"https://api.github.com/users/str4d/repos","events_url":"https://api.github.com/users/str4d/events{/privacy}","received_events_url":"https://api.github.com/users/str4d/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/str4d/zcash","description":"zcash","fork":true,"url":"https://api.github.com/repos/str4d/zcash","forks_url":"https://api.github.com/repos/str4d/zcash/forks","keys_url":"https://api.github.com/repos/str4d/zcash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/str4d/zcash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/str4d/zcash/teams","hooks_url":"https://api.github.com/repos/str4d/zcash/hooks","issue_events_url":"https://api.github.com/repos/str4d/zcash/issues/events{/number}","events_url":"https://api.github.com/repos/str4d/zcash/events","assignees_url":"https://api.github.com/repos/str4d/zcash/assignees{/user}","branches_url":"https://api.github.com/repos/str4d/zcash/branches{/branch}","tags_url":"https://api.github.com/repos/str4d/zcash/tags","blobs_url":"https://api.github.com/repos/str4d/zcash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/str4d/zcash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/str4d/zcash/git/refs{/sha}","trees_url":"https://api.github.com/repos/str4d/zcash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/str4d/zcash/statuses/{sha}","languages_url":"https://api.github.com/repos/str4d/zcash/languages","stargazers_url":"https://api.github.com/repos/str4d/zcash/stargazers","contributors_url":"https://api.github.com/repos/str4d/zcash/contributors","subscribers_url":"https://api.github.com/repos/str4d/zcash/subscribers","subscription_url":"https://api.github.com/repos/str4d/zcash/subscription","commits_url":"https://api.github.com/repos/str4d/zcash/commits{/sha}","git_commits_url":"https://api.github.com/repos/str4d/zcash/git/commits{/sha}","comments_url":"https://api.github.com/repos/str4d/zcash/comments{/number}","issue_comment_url":"https://api.github.com/repos/str4d/zcash/issues/comments{/number}","contents_url":"https://api.github.com/repos/str4d/zcash/contents/{+path}","compare_url":"https://api.github.com/repos/str4d/zcash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/str4d/zcash/merges","archive_url":"https://api.github.com/repos/str4d/zcash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/str4d/zcash/downloads","issues_url":"https://api.github.com/repos/str4d/zcash/issues{/number}","pulls_url":"https://api.github.com/repos/str4d/zcash/pulls{/number}","milestones_url":"https://api.github.com/repos/str4d/zcash/milestones{/number}","notifications_url":"https://api.github.com/repos/str4d/zcash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/str4d/zcash/labels{/name}","releases_url":"https://api.github.com/repos/str4d/zcash/releases{/id}","deployments_url":"https://api.github.com/repos/str4d/zcash/deployments","created_at":"2016-02-24T17:50:40Z","updated_at":"2016-09-01T12:28:09Z","pushed_at":"2016-09-15T10:48:39Z","git_url":"git://github.com/str4d/zcash.git","ssh_url":"git@github.com:str4d/zcash.git","clone_url":"https://github.com/str4d/zcash.git","svn_url":"https://github.com/str4d/zcash","homepage":"https://z.cash/","size":43637,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":5,"default_branch":"zc.v0.11.2.latest"}},"base":{"label":"zcash:master","ref":"master","sha":"0163f8faa29a14f8757e5dce930f4c2530065215","user":{"login":"zcash","id":16122764,"avatar_url":"https://avatars.githubusercontent.com/u/16122764?v=3","gravatar_id":"","url":"https://api.github.com/users/zcash","html_url":"https://github.com/zcash","followers_url":"https://api.github.com/users/zcash/followers","following_url":"https://api.github.com/users/zcash/following{/other_user}","gists_url":"https://api.github.com/users/zcash/gists{/gist_id}","starred_url":"https://api.github.com/users/zcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcash/subscriptions","organizations_url":"https://api.github.com/users/zcash/orgs","repos_url":"https://api.github.com/users/zcash/repos","events_url":"https://api.github.com/users/zcash/events{/privacy}","received_events_url":"https://api.github.com/users/zcash/received_events","type":"Organization","site_admin":false},"repo":{"id":26987049,"name":"zcash","full_name":"zcash/zcash","owner":{"login":"zcash","id":16122764,"avatar_url":"https://avatars.githubusercontent.com/u/16122764?v=3","gravatar_id":"","url":"https://api.github.com/users/zcash","html_url":"https://github.com/zcash","followers_url":"https://api.github.com/users/zcash/followers","following_url":"https://api.github.com/users/zcash/following{/other_user}","gists_url":"https://api.github.com/users/zcash/gists{/gist_id}","starred_url":"https://api.github.com/users/zcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcash/subscriptions","organizations_url":"https://api.github.com/users/zcash/orgs","repos_url":"https://api.github.com/users/zcash/repos","events_url":"https://api.github.com/users/zcash/events{/privacy}","received_events_url":"https://api.github.com/users/zcash/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zcash/zcash","description":"zcash","fork":false,"url":"https://api.github.com/repos/zcash/zcash","forks_url":"https://api.github.com/repos/zcash/zcash/forks","keys_url":"https://api.github.com/repos/zcash/zcash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zcash/zcash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zcash/zcash/teams","hooks_url":"https://api.github.com/repos/zcash/zcash/hooks","issue_events_url":"https://api.github.com/repos/zcash/zcash/issues/events{/number}","events_url":"https://api.github.com/repos/zcash/zcash/events","assignees_url":"https://api.github.com/repos/zcash/zcash/assignees{/user}","branches_url":"https://api.github.com/repos/zcash/zcash/branches{/branch}","tags_url":"https://api.github.com/repos/zcash/zcash/tags","blobs_url":"https://api.github.com/repos/zcash/zcash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zcash/zcash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zcash/zcash/git/refs{/sha}","trees_url":"https://api.github.com/repos/zcash/zcash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zcash/zcash/statuses/{sha}","languages_url":"https://api.github.com/repos/zcash/zcash/languages","stargazers_url":"https://api.github.com/repos/zcash/zcash/stargazers","contributors_url":"https://api.github.com/repos/zcash/zcash/contributors","subscribers_url":"https://api.github.com/repos/zcash/zcash/subscribers","subscription_url":"https://api.github.com/repos/zcash/zcash/subscription","commits_url":"https://api.github.com/repos/zcash/zcash/commits{/sha}","git_commits_url":"https://api.github.com/repos/zcash/zcash/git/commits{/sha}","comments_url":"https://api.github.com/repos/zcash/zcash/comments{/number}","issue_comment_url":"https://api.github.com/repos/zcash/zcash/issues/comments{/number}","contents_url":"https://api.github.com/repos/zcash/zcash/contents/{+path}","compare_url":"https://api.github.com/repos/zcash/zcash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zcash/zcash/merges","archive_url":"https://api.github.com/repos/zcash/zcash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zcash/zcash/downloads","issues_url":"https://api.github.com/repos/zcash/zcash/issues{/number}","pulls_url":"https://api.github.com/repos/zcash/zcash/pulls{/number}","milestones_url":"https://api.github.com/repos/zcash/zcash/milestones{/number}","notifications_url":"https://api.github.com/repos/zcash/zcash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zcash/zcash/labels{/name}","releases_url":"https://api.github.com/repos/zcash/zcash/releases{/id}","deployments_url":"https://api.github.com/repos/zcash/zcash/deployments","created_at":"2014-11-22T03:13:10Z","updated_at":"2016-09-15T10:19:59Z","pushed_at":"2016-09-15T10:50:07Z","git_url":"git://github.com/zcash/zcash.git","ssh_url":"git@github.com:zcash/zcash.git","clone_url":"https://github.com/zcash/zcash.git","svn_url":"https://github.com/zcash/zcash","homepage":"https://z.cash/","size":50066,"stargazers_count":974,"watchers_count":974,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":114,"mirror_url":null,"open_issues_count":409,"forks":114,"open_issues":409,"watchers":974,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zcash/zcash/pulls/1402"},"html":{"href":"https://github.com/zcash/zcash/pull/1402"},"issue":{"href":"https://api.github.com/repos/zcash/zcash/issues/1402"},"comments":{"href":"https://api.github.com/repos/zcash/zcash/issues/1402/comments"},"review_comments":{"href":"https://api.github.com/repos/zcash/zcash/pulls/1402/comments"},"review_comment":{"href":"https://api.github.com/repos/zcash/zcash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zcash/zcash/pulls/1402/commits"},"statuses":{"href":"https://api.github.com/repos/zcash/zcash/statuses/5105c3aab80b5fa1c97bff8b45058966981bb4eb"}}}}
{"actor":{"display_login":"daira"}}