{"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments/88597593","pull_request_review_id":9167050,"id":88597593,"diff_hunk":"@@ -64,6 +71,36 @@ def download_requests_stream(request_stream, destination, message=None):\n     progress_bar.finish()\n \n \n+class UrllibDownlaoder(object):","path":"snapcraft/internal/indicators.py","position":65,"original_position":65,"commit_id":"eb078e8481dcc035c6f0a82dd9e6b0dbfcfdae33","original_commit_id":"eb078e8481dcc035c6f0a82dd9e6b0dbfcfdae33","user":{"login":"elopio","id":617831,"avatar_url":"https://avatars.githubusercontent.com/u/617831?v=3","gravatar_id":"","url":"https://api.github.com/users/elopio","html_url":"https://github.com/elopio","followers_url":"https://api.github.com/users/elopio/followers","following_url":"https://api.github.com/users/elopio/following{/other_user}","gists_url":"https://api.github.com/users/elopio/gists{/gist_id}","starred_url":"https://api.github.com/users/elopio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elopio/subscriptions","organizations_url":"https://api.github.com/users/elopio/orgs","repos_url":"https://api.github.com/users/elopio/repos","events_url":"https://api.github.com/users/elopio/events{/privacy}","received_events_url":"https://api.github.com/users/elopio/received_events","type":"User","site_admin":false},"body":"typo: Downlaoder/Downloader","created_at":"2016-11-18T04:19:27Z","updated_at":"2016-11-18T04:28:26Z","html_url":"https://github.com/snapcore/snapcraft/pull/900#discussion_r88597593","pull_request_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/900","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments/88597593"},"html":{"href":"https://github.com/snapcore/snapcraft/pull/900#discussion_r88597593"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/900"}}},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapcraft/pulls/900","id":93422718,"html_url":"https://github.com/snapcore/snapcraft/pull/900","diff_url":"https://github.com/snapcore/snapcraft/pull/900.diff","patch_url":"https://github.com/snapcore/snapcraft/pull/900.patch","issue_url":"https://api.github.com/repos/snapcore/snapcraft/issues/900","number":900,"state":"open","locked":false,"title":"ftp source support","user":{"login":"3v1n0","id":345675,"avatar_url":"https://avatars.githubusercontent.com/u/345675?v=3","gravatar_id":"","url":"https://api.github.com/users/3v1n0","html_url":"https://github.com/3v1n0","followers_url":"https://api.github.com/users/3v1n0/followers","following_url":"https://api.github.com/users/3v1n0/following{/other_user}","gists_url":"https://api.github.com/users/3v1n0/gists{/gist_id}","starred_url":"https://api.github.com/users/3v1n0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3v1n0/subscriptions","organizations_url":"https://api.github.com/users/3v1n0/orgs","repos_url":"https://api.github.com/users/3v1n0/repos","events_url":"https://api.github.com/users/3v1n0/events{/privacy}","received_events_url":"https://api.github.com/users/3v1n0/received_events","type":"User","site_admin":false},"body":"As requested on bug https://bugs.launchpad.net/snappy/+bug/1602323\r\n\r\nThis adds support for FTP sources, using urllib was the quickest choice, and with some refactor of the indicator module, adding a progressbar was possible too. If using ftplib or others is preferred let me know, but I went for the fastest and safer way.\r\n\r\nIn theory this path could be used also for http(s) downloads, but not to change what we've done so far, I've left that job to the nicer `requests` library. `requests` being an HTTP only library has no native suppot for this, while trying to use something like [requests-ftp](https://pypi.python.org/pypi/requests-ftp) I don't think is a choice (looking quite immature).\r\n\r\n","created_at":"2016-11-12T01:34:34Z","updated_at":"2016-11-18T04:28:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18633e0557eb9723d50a58c3f5d5b6dea1748748","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/900/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/900/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/issues/900/comments","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/eb078e8481dcc035c6f0a82dd9e6b0dbfcfdae33","head":{"label":"3v1n0:ftp-source-support","ref":"ftp-source-support","sha":"eb078e8481dcc035c6f0a82dd9e6b0dbfcfdae33","user":{"login":"3v1n0","id":345675,"avatar_url":"https://avatars.githubusercontent.com/u/345675?v=3","gravatar_id":"","url":"https://api.github.com/users/3v1n0","html_url":"https://github.com/3v1n0","followers_url":"https://api.github.com/users/3v1n0/followers","following_url":"https://api.github.com/users/3v1n0/following{/other_user}","gists_url":"https://api.github.com/users/3v1n0/gists{/gist_id}","starred_url":"https://api.github.com/users/3v1n0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3v1n0/subscriptions","organizations_url":"https://api.github.com/users/3v1n0/orgs","repos_url":"https://api.github.com/users/3v1n0/repos","events_url":"https://api.github.com/users/3v1n0/events{/privacy}","received_events_url":"https://api.github.com/users/3v1n0/received_events","type":"User","site_admin":false},"repo":{"id":58781157,"name":"snapcraft","full_name":"3v1n0/snapcraft","owner":{"login":"3v1n0","id":345675,"avatar_url":"https://avatars.githubusercontent.com/u/345675?v=3","gravatar_id":"","url":"https://api.github.com/users/3v1n0","html_url":"https://github.com/3v1n0","followers_url":"https://api.github.com/users/3v1n0/followers","following_url":"https://api.github.com/users/3v1n0/following{/other_user}","gists_url":"https://api.github.com/users/3v1n0/gists{/gist_id}","starred_url":"https://api.github.com/users/3v1n0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3v1n0/subscriptions","organizations_url":"https://api.github.com/users/3v1n0/orgs","repos_url":"https://api.github.com/users/3v1n0/repos","events_url":"https://api.github.com/users/3v1n0/events{/privacy}","received_events_url":"https://api.github.com/users/3v1n0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/3v1n0/snapcraft","description":"Snapcraft is a delightful packaging tool","fork":true,"url":"https://api.github.com/repos/3v1n0/snapcraft","forks_url":"https://api.github.com/repos/3v1n0/snapcraft/forks","keys_url":"https://api.github.com/repos/3v1n0/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3v1n0/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3v1n0/snapcraft/teams","hooks_url":"https://api.github.com/repos/3v1n0/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/3v1n0/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/3v1n0/snapcraft/events","assignees_url":"https://api.github.com/repos/3v1n0/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/3v1n0/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/3v1n0/snapcraft/tags","blobs_url":"https://api.github.com/repos/3v1n0/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3v1n0/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3v1n0/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/3v1n0/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3v1n0/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/3v1n0/snapcraft/languages","stargazers_url":"https://api.github.com/repos/3v1n0/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/3v1n0/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/3v1n0/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/3v1n0/snapcraft/subscription","commits_url":"https://api.github.com/repos/3v1n0/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/3v1n0/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/3v1n0/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/3v1n0/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/3v1n0/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/3v1n0/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3v1n0/snapcraft/merges","archive_url":"https://api.github.com/repos/3v1n0/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3v1n0/snapcraft/downloads","issues_url":"https://api.github.com/repos/3v1n0/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/3v1n0/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/3v1n0/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/3v1n0/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3v1n0/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/3v1n0/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/3v1n0/snapcraft/deployments","created_at":"2016-05-14T00:17:31Z","updated_at":"2016-05-14T00:17:32Z","pushed_at":"2016-11-18T03:10:02Z","git_url":"git://github.com/3v1n0/snapcraft.git","ssh_url":"git@github.com:3v1n0/snapcraft.git","clone_url":"https://github.com/3v1n0/snapcraft.git","svn_url":"https://github.com/3v1n0/snapcraft","homepage":null,"size":5510,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"0b584f6863a972aec2a40c15f056dc54376615ca","user":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars.githubusercontent.com/u/19532717?v=3","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":45199136,"name":"snapcraft","full_name":"snapcore/snapcraft","owner":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars.githubusercontent.com/u/19532717?v=3","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snapcore/snapcraft","description":"Snapcraft is a delightful packaging tool","fork":false,"url":"https://api.github.com/repos/snapcore/snapcraft","forks_url":"https://api.github.com/repos/snapcore/snapcraft/forks","keys_url":"https://api.github.com/repos/snapcore/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapcraft/teams","hooks_url":"https://api.github.com/repos/snapcore/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapcraft/events","assignees_url":"https://api.github.com/repos/snapcore/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapcraft/tags","blobs_url":"https://api.github.com/repos/snapcore/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapcraft/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapcraft/subscription","commits_url":"https://api.github.com/repos/snapcore/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapcraft/merges","archive_url":"https://api.github.com/repos/snapcore/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapcraft/downloads","issues_url":"https://api.github.com/repos/snapcore/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapcraft/deployments","created_at":"2015-10-29T17:23:15Z","updated_at":"2016-11-17T17:02:06Z","pushed_at":"2016-11-18T03:59:58Z","git_url":"git://github.com/snapcore/snapcraft.git","ssh_url":"git@github.com:snapcore/snapcraft.git","clone_url":"https://github.com/snapcore/snapcraft.git","svn_url":"https://github.com/snapcore/snapcraft","homepage":null,"size":8366,"stargazers_count":235,"watchers_count":235,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":138,"mirror_url":null,"open_issues_count":17,"forks":138,"open_issues":17,"watchers":235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/900"},"html":{"href":"https://github.com/snapcore/snapcraft/pull/900"},"issue":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/900"},"comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/900/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/900/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/900/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapcraft/statuses/eb078e8481dcc035c6f0a82dd9e6b0dbfcfdae33"}}}}
{"actor":{"display_login":"elopio"}}