{"action":"created","comment":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/comments/70161220","id":70161220,"diff_hunk":"@@ -24,14 +30,30 @@ A plain color as a background:\n \n ## Attributes\n \n-Note that the sky primitive inherits common [mesh attributes](./mesh-attributes.md).\n-\n | Attribute       | Component Mapping       | Default Value |\n-|-----------------|-------------------------|---------------|\n+| --------        | -----------------       | ------------- |\n+| color           | material.color          | #FFF          |\n+| metalness       | material.metalness      | 0             |\n+| opacity         | material.opacity        | 1             |\n+| phi-length      | geometry.phiLength      | 360           |\n+| phi-start       | geometry.phiStart       | 0             |\n | radius          | geometry.radius         | 100           |","path":"docs/primitives/a-sky.md","position":41,"original_position":41,"commit_id":"e73cf29b6484f628fea65948be5b96f2e5bae5e2","original_commit_id":"e73cf29b6484f628fea65948be5b96f2e5bae5e2","user":{"login":"bryik","id":12419712,"avatar_url":"https://avatars.githubusercontent.com/u/12419712?v=3","gravatar_id":"","url":"https://api.github.com/users/bryik","html_url":"https://github.com/bryik","followers_url":"https://api.github.com/users/bryik/followers","following_url":"https://api.github.com/users/bryik/following{/other_user}","gists_url":"https://api.github.com/users/bryik/gists{/gist_id}","starred_url":"https://api.github.com/users/bryik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryik/subscriptions","organizations_url":"https://api.github.com/users/bryik/orgs","repos_url":"https://api.github.com/users/bryik/repos","events_url":"https://api.github.com/users/bryik/events{/privacy}","received_events_url":"https://api.github.com/users/bryik/received_events","type":"User","site_admin":false},"body":"The default radius value for a-sky is 5000, right? It was changed back recently: https://github.com/aframevr/aframe/pull/1585","created_at":"2016-07-09T02:53:00Z","updated_at":"2016-07-09T02:53:00Z","html_url":"https://github.com/aframevr/aframe/pull/1494#discussion_r70161220","pull_request_url":"https://api.github.com/repos/aframevr/aframe/pulls/1494","_links":{"self":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/comments/70161220"},"html":{"href":"https://github.com/aframevr/aframe/pull/1494#discussion_r70161220"},"pull_request":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1494"}}},"pull_request":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/1494","id":71109266,"html_url":"https://github.com/aframevr/aframe/pull/1494","diff_url":"https://github.com/aframevr/aframe/pull/1494.diff","patch_url":"https://github.com/aframevr/aframe/pull/1494.patch","issue_url":"https://api.github.com/repos/aframevr/aframe/issues/1494","number":1494,"state":"open","locked":false,"title":"update docs 0.3.0","user":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?v=3","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"body":"## Guide\r\n\r\n- [x] 1. Introduction\r\n- [x] 2. Getting Started / Installation\r\n- [x] 3. Building a Basic Scene \r\n- [x] 4. Building an Advanced Scene\r\n- [x] <s>5. Thinking in A-Frame</s> *concepts already explained everywhere, for now*\r\n- [x] 6. Best Practices\r\n- [x] 7. Device &amp; Browser Support\r\n- [x] <s>8. Optimizing Performance</s> *merged into Best Practices*\r\n- [x] <s>Example: Making Scenes Multiuser</s> *leave for a blog post*\r\n- [x] <s>Example: Creating Data Visualizations</s> *leave for a blog post*\r\n- [x] <s>Example: Creating Audio Visualizations</s> *leave for a blog post*\r\n\r\n## Geometry\r\n\r\n- [x] cone\r\n- [x] registerGeometry\r\n- [x] geometry.buffer\r\n- [x] geometry.skipCache\r\n- [x] geometry.mergeTo\r\n- [x] Isocahedron, octahedron, dodecahedron, tetrahedron\r\n\r\n## Primitives\r\n\r\n- [x] a-circle primitive\r\n- [x] sound primitive\r\n- [x] torusKnot primitive\r\n- [x] registering a primitive\r\n- [x] analogy to 'assemblage' or 'bundle' or 'prefab'\r\n- [x] a-*hedron primitives\r\n\r\n## Misc\r\n\r\n- [x] updateSchema\r\n- [x] combine shader docs into material component\r\n- [x] utils\r\n- [x] rStats\r\n- [x] debug component\r\n- [x] explain DOM serialization\r\n- [x] camera.zoom\r\n- [x] default lighting tweak\r\n- [x] mention useful components where appropriate (gltf, fit-texture, etc)\r\n- [x] fix element/HUD in camera docs\r\n- [x] flushToDOM\r\n\r\n## Future\r\n\r\n- embedded\r\n- fullscreen on flat\r\n- controllers","created_at":"2016-05-23T19:45:44Z","updated_at":"2016-07-09T02:53:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b5c24aaac6853589a17c7bbbe5ed08f46fcf842","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aframevr/aframe/pulls/1494/commits","review_comments_url":"https://api.github.com/repos/aframevr/aframe/pulls/1494/comments","review_comment_url":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aframevr/aframe/issues/1494/comments","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/e73cf29b6484f628fea65948be5b96f2e5bae5e2","head":{"label":"ngokevin:docs030","ref":"docs030","sha":"e73cf29b6484f628fea65948be5b96f2e5bae5e2","user":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?v=3","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"repo":{"id":48299418,"name":"aframe","full_name":"ngokevin/aframe","owner":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?v=3","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ngokevin/aframe","description":"Building Blocks for the VR Web","fork":true,"url":"https://api.github.com/repos/ngokevin/aframe","forks_url":"https://api.github.com/repos/ngokevin/aframe/forks","keys_url":"https://api.github.com/repos/ngokevin/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngokevin/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngokevin/aframe/teams","hooks_url":"https://api.github.com/repos/ngokevin/aframe/hooks","issue_events_url":"https://api.github.com/repos/ngokevin/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/ngokevin/aframe/events","assignees_url":"https://api.github.com/repos/ngokevin/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/ngokevin/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/ngokevin/aframe/tags","blobs_url":"https://api.github.com/repos/ngokevin/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngokevin/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngokevin/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngokevin/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngokevin/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/ngokevin/aframe/languages","stargazers_url":"https://api.github.com/repos/ngokevin/aframe/stargazers","contributors_url":"https://api.github.com/repos/ngokevin/aframe/contributors","subscribers_url":"https://api.github.com/repos/ngokevin/aframe/subscribers","subscription_url":"https://api.github.com/repos/ngokevin/aframe/subscription","commits_url":"https://api.github.com/repos/ngokevin/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngokevin/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngokevin/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngokevin/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/ngokevin/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/ngokevin/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngokevin/aframe/merges","archive_url":"https://api.github.com/repos/ngokevin/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngokevin/aframe/downloads","issues_url":"https://api.github.com/repos/ngokevin/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/ngokevin/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/ngokevin/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/ngokevin/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngokevin/aframe/labels{/name}","releases_url":"https://api.github.com/repos/ngokevin/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/ngokevin/aframe/deployments","created_at":"2015-12-19T22:31:05Z","updated_at":"2016-03-29T22:44:31Z","pushed_at":"2016-07-08T21:00:21Z","git_url":"git://github.com/ngokevin/aframe.git","ssh_url":"git@github.com:ngokevin/aframe.git","clone_url":"https://github.com/ngokevin/aframe.git","svn_url":"https://github.com/ngokevin/aframe","homepage":"https://aframe.io/","size":128754,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"aframevr:master","ref":"master","sha":"6edb276703aac60acfd105b4b5b8f715b39121ac","user":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars.githubusercontent.com/u/16024092?v=3","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"repo":{"id":42488903,"name":"aframe","full_name":"aframevr/aframe","owner":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars.githubusercontent.com/u/16024092?v=3","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aframevr/aframe","description":"Building Blocks for the VR Web","fork":false,"url":"https://api.github.com/repos/aframevr/aframe","forks_url":"https://api.github.com/repos/aframevr/aframe/forks","keys_url":"https://api.github.com/repos/aframevr/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aframevr/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aframevr/aframe/teams","hooks_url":"https://api.github.com/repos/aframevr/aframe/hooks","issue_events_url":"https://api.github.com/repos/aframevr/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/aframevr/aframe/events","assignees_url":"https://api.github.com/repos/aframevr/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/aframevr/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/aframevr/aframe/tags","blobs_url":"https://api.github.com/repos/aframevr/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aframevr/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aframevr/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/aframevr/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/aframevr/aframe/languages","stargazers_url":"https://api.github.com/repos/aframevr/aframe/stargazers","contributors_url":"https://api.github.com/repos/aframevr/aframe/contributors","subscribers_url":"https://api.github.com/repos/aframevr/aframe/subscribers","subscription_url":"https://api.github.com/repos/aframevr/aframe/subscription","commits_url":"https://api.github.com/repos/aframevr/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/aframevr/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/aframevr/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/aframevr/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/aframevr/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/aframevr/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aframevr/aframe/merges","archive_url":"https://api.github.com/repos/aframevr/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aframevr/aframe/downloads","issues_url":"https://api.github.com/repos/aframevr/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/aframevr/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/aframevr/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/aframevr/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aframevr/aframe/labels{/name}","releases_url":"https://api.github.com/repos/aframevr/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/aframevr/aframe/deployments","created_at":"2015-09-15T02:04:40Z","updated_at":"2016-07-09T02:01:51Z","pushed_at":"2016-07-09T02:23:34Z","git_url":"git://github.com/aframevr/aframe.git","ssh_url":"git@github.com:aframevr/aframe.git","clone_url":"https://github.com/aframevr/aframe.git","svn_url":"https://github.com/aframevr/aframe","homepage":"https://aframe.io/","size":157617,"stargazers_count":2345,"watchers_count":2345,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":408,"mirror_url":null,"open_issues_count":231,"forks":408,"open_issues":231,"watchers":2345,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1494"},"html":{"href":"https://github.com/aframevr/aframe/pull/1494"},"issue":{"href":"https://api.github.com/repos/aframevr/aframe/issues/1494"},"comments":{"href":"https://api.github.com/repos/aframevr/aframe/issues/1494/comments"},"review_comments":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1494/comments"},"review_comment":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1494/commits"},"statuses":{"href":"https://api.github.com/repos/aframevr/aframe/statuses/e73cf29b6484f628fea65948be5b96f2e5bae5e2"}}}}
{"actor":{"display_login":"bryik"}}