{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30969","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30969/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30969/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30969/events","html_url":"https://github.com/kubernetes/kubernetes/pull/30969","id":172060250,"number":30969,"title":"Make sure the StatusCode is taken into account in DoRaw()","user":{"login":"asalkeld","id":420707,"avatar_url":"https://avatars.githubusercontent.com/u/420707?v=3","gravatar_id":"","url":"https://api.github.com/users/asalkeld","html_url":"https://github.com/asalkeld","followers_url":"https://api.github.com/users/asalkeld/followers","following_url":"https://api.github.com/users/asalkeld/following{/other_user}","gists_url":"https://api.github.com/users/asalkeld/gists{/gist_id}","starred_url":"https://api.github.com/users/asalkeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asalkeld/subscriptions","organizations_url":"https://api.github.com/users/asalkeld/orgs","repos_url":"https://api.github.com/users/asalkeld/repos","events_url":"https://api.github.com/users/asalkeld/events{/privacy}","received_events_url":"https://api.github.com/users/asalkeld/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge","name":"do-not-merge","color":"e11d21"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-label-needed","name":"release-note-label-needed","color":"db5a64"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00"}],"state":"open","locked":false,"assignee":{"login":"krousey","id":157083,"avatar_url":"https://avatars.githubusercontent.com/u/157083?v=3","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},"assignees":[{"login":"krousey","id":157083,"avatar_url":"https://avatars.githubusercontent.com/u/157083?v=3","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-08-19T05:57:23Z","updated_at":"2016-08-23T01:45:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30969","html_url":"https://github.com/kubernetes/kubernetes/pull/30969","diff_url":"https://github.com/kubernetes/kubernetes/pull/30969.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/30969.patch"},"body":"**What this PR does / why we need it**:\r\nCurrently if there is an error (not found) the error printed out\r\nis to do with the inablity to convert an empty body into the expected json.\r\n\r\nThis patch will fill in the err correctly.\r\n\r\nexample of before (with NotFound error):\r\n$ kubectl top node\r\nfailed to unmarshall heapster response: json: cannot unmarshal object into Go value of type []v1alpha1.NodeMetrics\r\n\r\nNow:\r\n$ kubectl top node\r\nthe server could not find the requested resource (get services http:heapster:)\r\n\r\n**Which issue this PR fixes** \r\nrelated to bug #30818\r\n\r\n**Special notes for your reviewer**:\r\nNone\r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30969)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/241603306","html_url":"https://github.com/kubernetes/kubernetes/pull/30969#issuecomment-241603306","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30969","id":241603306,"user":{"login":"asalkeld","id":420707,"avatar_url":"https://avatars.githubusercontent.com/u/420707?v=3","gravatar_id":"","url":"https://api.github.com/users/asalkeld","html_url":"https://github.com/asalkeld","followers_url":"https://api.github.com/users/asalkeld/followers","following_url":"https://api.github.com/users/asalkeld/following{/other_user}","gists_url":"https://api.github.com/users/asalkeld/gists{/gist_id}","starred_url":"https://api.github.com/users/asalkeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asalkeld/subscriptions","organizations_url":"https://api.github.com/users/asalkeld/orgs","repos_url":"https://api.github.com/users/asalkeld/repos","events_url":"https://api.github.com/users/asalkeld/events{/privacy}","received_events_url":"https://api.github.com/users/asalkeld/received_events","type":"User","site_admin":false},"created_at":"2016-08-23T01:45:27Z","updated_at":"2016-08-23T01:45:27Z","body":"\n\n\n\nReview status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[test/e2e/networking.go, line 71 \\[r4\\]](https://reviewable.kubernetes.io:443/reviews/kubernetes/kubernetes/30969#-KPnKXlqg18U8w3pAnbL:-KPp3XKEacNh514Jb2lw:b-p1sahv) ([raw file](https://github.com/kubernetes/kubernetes/blob/d5a13ad420b783b9ce60bcbd655b38694b3a2716/test/e2e/networking.go#L71)):*\n<details><summary><i>Previously, krousey wrote…</i></summary>\n> Delete this comment\n</details>\nWill do, thanks for spotting that.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.kubernetes.io:443/reviews/kubernetes/kubernetes/30969)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"asalkeld"}}