{"action":"created","comment":{"url":"https://api.github.com/repos/remind101/stacker/pulls/comments/74145464","id":74145464,"diff_hunk":"@@ -89,6 +89,10 @@ def resolve_parameters(parameters, blueprint, context, provider):\n             values = value.split(\",\")\n             for v in values:\n                 v = v.strip()\n+                # Skip parameters not referencing another stack","path":"stacker/actions/build.py","position":4,"original_position":4,"commit_id":"838a858065286e132567f2dd12425ffe45ce3e37","original_commit_id":"580685d6cc8d146edc788fb5db0f68a344306b38","user":{"login":"acmcelwee","id":1056585,"avatar_url":"https://avatars.githubusercontent.com/u/1056585?v=3","gravatar_id":"","url":"https://api.github.com/users/acmcelwee","html_url":"https://github.com/acmcelwee","followers_url":"https://api.github.com/users/acmcelwee/followers","following_url":"https://api.github.com/users/acmcelwee/following{/other_user}","gists_url":"https://api.github.com/users/acmcelwee/gists{/gist_id}","starred_url":"https://api.github.com/users/acmcelwee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acmcelwee/subscriptions","organizations_url":"https://api.github.com/users/acmcelwee/orgs","repos_url":"https://api.github.com/users/acmcelwee/repos","events_url":"https://api.github.com/users/acmcelwee/events{/privacy}","received_events_url":"https://api.github.com/users/acmcelwee/received_events","type":"User","site_admin":false},"body":"I agree. Consolidating that would probably pave the way for the work that's being proposed in #184.","created_at":"2016-08-09T21:11:58Z","updated_at":"2016-08-09T21:11:58Z","html_url":"https://github.com/remind101/stacker/pull/183#discussion_r74145464","pull_request_url":"https://api.github.com/repos/remind101/stacker/pulls/183","_links":{"self":{"href":"https://api.github.com/repos/remind101/stacker/pulls/comments/74145464"},"html":{"href":"https://github.com/remind101/stacker/pull/183#discussion_r74145464"},"pull_request":{"href":"https://api.github.com/repos/remind101/stacker/pulls/183"}}},"pull_request":{"url":"https://api.github.com/repos/remind101/stacker/pulls/183","id":79834658,"html_url":"https://github.com/remind101/stacker/pull/183","diff_url":"https://github.com/remind101/stacker/pull/183.diff","patch_url":"https://github.com/remind101/stacker/pull/183.patch","issue_url":"https://api.github.com/repos/remind101/stacker/issues/183","number":183,"state":"open","locked":false,"title":"support mixed parameters referencing / not referencing other stacks","user":{"login":"troyready","id":1806418,"avatar_url":"https://avatars.githubusercontent.com/u/1806418?v=3","gravatar_id":"","url":"https://api.github.com/users/troyready","html_url":"https://github.com/troyready","followers_url":"https://api.github.com/users/troyready/followers","following_url":"https://api.github.com/users/troyready/following{/other_user}","gists_url":"https://api.github.com/users/troyready/gists{/gist_id}","starred_url":"https://api.github.com/users/troyready/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troyready/subscriptions","organizations_url":"https://api.github.com/users/troyready/orgs","repos_url":"https://api.github.com/users/troyready/repos","events_url":"https://api.github.com/users/troyready/events{/privacy}","received_events_url":"https://api.github.com/users/troyready/received_events","type":"User","site_admin":false},"body":"Currently parameters can reference multiple outputs in other stacks:\r\n```\r\nSomeParameter: stack1::Output1,stack2::Output2\r\n```\r\n\r\nThis commit allows parameter lists to also include variables not\r\nreferencing another stack, e.g.:\r\n```\r\nSomeParameter: ${ThingInEnvFile},stack1::Output1\r\n```\r\n\r\nI considered updating the documentation in [Using Outputs as Parameters](https://github.com/remind101/stacker/blob/master/docs/config.rst#using-outputs-as-parameters), but I'm not sure how to change the last part (\"You can also pull multiple...\") to note the functionality. Maybe a new section? Maybe the new functionality doesn't need to be called out?","created_at":"2016-08-03T01:18:21Z","updated_at":"2016-08-09T21:11:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79b37705d7e1107e2fbbc14764231a81c8482055","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/remind101/stacker/pulls/183/commits","review_comments_url":"https://api.github.com/repos/remind101/stacker/pulls/183/comments","review_comment_url":"https://api.github.com/repos/remind101/stacker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/remind101/stacker/issues/183/comments","statuses_url":"https://api.github.com/repos/remind101/stacker/statuses/838a858065286e132567f2dd12425ffe45ce3e37","head":{"label":"troyready:multi_param_types","ref":"multi_param_types","sha":"838a858065286e132567f2dd12425ffe45ce3e37","user":{"login":"troyready","id":1806418,"avatar_url":"https://avatars.githubusercontent.com/u/1806418?v=3","gravatar_id":"","url":"https://api.github.com/users/troyready","html_url":"https://github.com/troyready","followers_url":"https://api.github.com/users/troyready/followers","following_url":"https://api.github.com/users/troyready/following{/other_user}","gists_url":"https://api.github.com/users/troyready/gists{/gist_id}","starred_url":"https://api.github.com/users/troyready/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troyready/subscriptions","organizations_url":"https://api.github.com/users/troyready/orgs","repos_url":"https://api.github.com/users/troyready/repos","events_url":"https://api.github.com/users/troyready/events{/privacy}","received_events_url":"https://api.github.com/users/troyready/received_events","type":"User","site_admin":false},"repo":{"id":64773324,"name":"stacker","full_name":"troyready/stacker","owner":{"login":"troyready","id":1806418,"avatar_url":"https://avatars.githubusercontent.com/u/1806418?v=3","gravatar_id":"","url":"https://api.github.com/users/troyready","html_url":"https://github.com/troyready","followers_url":"https://api.github.com/users/troyready/followers","following_url":"https://api.github.com/users/troyready/following{/other_user}","gists_url":"https://api.github.com/users/troyready/gists{/gist_id}","starred_url":"https://api.github.com/users/troyready/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troyready/subscriptions","organizations_url":"https://api.github.com/users/troyready/orgs","repos_url":"https://api.github.com/users/troyready/repos","events_url":"https://api.github.com/users/troyready/events{/privacy}","received_events_url":"https://api.github.com/users/troyready/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/troyready/stacker","description":"An opinionated AWS CloudFormation Stack builder.","fork":true,"url":"https://api.github.com/repos/troyready/stacker","forks_url":"https://api.github.com/repos/troyready/stacker/forks","keys_url":"https://api.github.com/repos/troyready/stacker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/troyready/stacker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/troyready/stacker/teams","hooks_url":"https://api.github.com/repos/troyready/stacker/hooks","issue_events_url":"https://api.github.com/repos/troyready/stacker/issues/events{/number}","events_url":"https://api.github.com/repos/troyready/stacker/events","assignees_url":"https://api.github.com/repos/troyready/stacker/assignees{/user}","branches_url":"https://api.github.com/repos/troyready/stacker/branches{/branch}","tags_url":"https://api.github.com/repos/troyready/stacker/tags","blobs_url":"https://api.github.com/repos/troyready/stacker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/troyready/stacker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/troyready/stacker/git/refs{/sha}","trees_url":"https://api.github.com/repos/troyready/stacker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/troyready/stacker/statuses/{sha}","languages_url":"https://api.github.com/repos/troyready/stacker/languages","stargazers_url":"https://api.github.com/repos/troyready/stacker/stargazers","contributors_url":"https://api.github.com/repos/troyready/stacker/contributors","subscribers_url":"https://api.github.com/repos/troyready/stacker/subscribers","subscription_url":"https://api.github.com/repos/troyready/stacker/subscription","commits_url":"https://api.github.com/repos/troyready/stacker/commits{/sha}","git_commits_url":"https://api.github.com/repos/troyready/stacker/git/commits{/sha}","comments_url":"https://api.github.com/repos/troyready/stacker/comments{/number}","issue_comment_url":"https://api.github.com/repos/troyready/stacker/issues/comments{/number}","contents_url":"https://api.github.com/repos/troyready/stacker/contents/{+path}","compare_url":"https://api.github.com/repos/troyready/stacker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/troyready/stacker/merges","archive_url":"https://api.github.com/repos/troyready/stacker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/troyready/stacker/downloads","issues_url":"https://api.github.com/repos/troyready/stacker/issues{/number}","pulls_url":"https://api.github.com/repos/troyready/stacker/pulls{/number}","milestones_url":"https://api.github.com/repos/troyready/stacker/milestones{/number}","notifications_url":"https://api.github.com/repos/troyready/stacker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/troyready/stacker/labels{/name}","releases_url":"https://api.github.com/repos/troyready/stacker/releases{/id}","deployments_url":"https://api.github.com/repos/troyready/stacker/deployments","created_at":"2016-08-02T16:24:43Z","updated_at":"2016-08-02T16:24:44Z","pushed_at":"2016-08-05T17:23:51Z","git_url":"git://github.com/troyready/stacker.git","ssh_url":"git@github.com:troyready/stacker.git","clone_url":"https://github.com/troyready/stacker.git","svn_url":"https://github.com/troyready/stacker","homepage":null,"size":593,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"remind101:master","ref":"master","sha":"145307f9cb68aff1a9a07d4d47dbc254a0610553","user":{"login":"remind101","id":376343,"avatar_url":"https://avatars.githubusercontent.com/u/376343?v=3","gravatar_id":"","url":"https://api.github.com/users/remind101","html_url":"https://github.com/remind101","followers_url":"https://api.github.com/users/remind101/followers","following_url":"https://api.github.com/users/remind101/following{/other_user}","gists_url":"https://api.github.com/users/remind101/gists{/gist_id}","starred_url":"https://api.github.com/users/remind101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remind101/subscriptions","organizations_url":"https://api.github.com/users/remind101/orgs","repos_url":"https://api.github.com/users/remind101/repos","events_url":"https://api.github.com/users/remind101/events{/privacy}","received_events_url":"https://api.github.com/users/remind101/received_events","type":"Organization","site_admin":false},"repo":{"id":28885080,"name":"stacker","full_name":"remind101/stacker","owner":{"login":"remind101","id":376343,"avatar_url":"https://avatars.githubusercontent.com/u/376343?v=3","gravatar_id":"","url":"https://api.github.com/users/remind101","html_url":"https://github.com/remind101","followers_url":"https://api.github.com/users/remind101/followers","following_url":"https://api.github.com/users/remind101/following{/other_user}","gists_url":"https://api.github.com/users/remind101/gists{/gist_id}","starred_url":"https://api.github.com/users/remind101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remind101/subscriptions","organizations_url":"https://api.github.com/users/remind101/orgs","repos_url":"https://api.github.com/users/remind101/repos","events_url":"https://api.github.com/users/remind101/events{/privacy}","received_events_url":"https://api.github.com/users/remind101/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/remind101/stacker","description":"An opinionated AWS CloudFormation Stack builder.","fork":false,"url":"https://api.github.com/repos/remind101/stacker","forks_url":"https://api.github.com/repos/remind101/stacker/forks","keys_url":"https://api.github.com/repos/remind101/stacker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/remind101/stacker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/remind101/stacker/teams","hooks_url":"https://api.github.com/repos/remind101/stacker/hooks","issue_events_url":"https://api.github.com/repos/remind101/stacker/issues/events{/number}","events_url":"https://api.github.com/repos/remind101/stacker/events","assignees_url":"https://api.github.com/repos/remind101/stacker/assignees{/user}","branches_url":"https://api.github.com/repos/remind101/stacker/branches{/branch}","tags_url":"https://api.github.com/repos/remind101/stacker/tags","blobs_url":"https://api.github.com/repos/remind101/stacker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/remind101/stacker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/remind101/stacker/git/refs{/sha}","trees_url":"https://api.github.com/repos/remind101/stacker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/remind101/stacker/statuses/{sha}","languages_url":"https://api.github.com/repos/remind101/stacker/languages","stargazers_url":"https://api.github.com/repos/remind101/stacker/stargazers","contributors_url":"https://api.github.com/repos/remind101/stacker/contributors","subscribers_url":"https://api.github.com/repos/remind101/stacker/subscribers","subscription_url":"https://api.github.com/repos/remind101/stacker/subscription","commits_url":"https://api.github.com/repos/remind101/stacker/commits{/sha}","git_commits_url":"https://api.github.com/repos/remind101/stacker/git/commits{/sha}","comments_url":"https://api.github.com/repos/remind101/stacker/comments{/number}","issue_comment_url":"https://api.github.com/repos/remind101/stacker/issues/comments{/number}","contents_url":"https://api.github.com/repos/remind101/stacker/contents/{+path}","compare_url":"https://api.github.com/repos/remind101/stacker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/remind101/stacker/merges","archive_url":"https://api.github.com/repos/remind101/stacker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/remind101/stacker/downloads","issues_url":"https://api.github.com/repos/remind101/stacker/issues{/number}","pulls_url":"https://api.github.com/repos/remind101/stacker/pulls{/number}","milestones_url":"https://api.github.com/repos/remind101/stacker/milestones{/number}","notifications_url":"https://api.github.com/repos/remind101/stacker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/remind101/stacker/labels{/name}","releases_url":"https://api.github.com/repos/remind101/stacker/releases{/id}","deployments_url":"https://api.github.com/repos/remind101/stacker/deployments","created_at":"2015-01-06T21:46:05Z","updated_at":"2016-08-04T00:18:16Z","pushed_at":"2016-08-09T17:38:39Z","git_url":"git://github.com/remind101/stacker.git","ssh_url":"git@github.com:remind101/stacker.git","clone_url":"https://github.com/remind101/stacker.git","svn_url":"https://github.com/remind101/stacker","homepage":null,"size":651,"stargazers_count":88,"watchers_count":88,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":27,"forks":30,"open_issues":27,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/remind101/stacker/pulls/183"},"html":{"href":"https://github.com/remind101/stacker/pull/183"},"issue":{"href":"https://api.github.com/repos/remind101/stacker/issues/183"},"comments":{"href":"https://api.github.com/repos/remind101/stacker/issues/183/comments"},"review_comments":{"href":"https://api.github.com/repos/remind101/stacker/pulls/183/comments"},"review_comment":{"href":"https://api.github.com/repos/remind101/stacker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/remind101/stacker/pulls/183/commits"},"statuses":{"href":"https://api.github.com/repos/remind101/stacker/statuses/838a858065286e132567f2dd12425ffe45ce3e37"}}}}
{"actor":{"display_login":"acmcelwee"}}