{"action":"created","issue":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1184","repository_url":"https://api.github.com/repos/greenplum-db/gpdb","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1184/labels{/name}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1184/comments","events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1184/events","html_url":"https://github.com/greenplum-db/gpdb/pull/1184","id":181558366,"number":1184,"title":"Set persistentTid and persistentSerialNum in XLog record in log_newpa…","user":{"login":"slari-pivotal","id":14188626,"avatar_url":"https://avatars.githubusercontent.com/u/14188626?v=3","gravatar_id":"","url":"https://api.github.com/users/slari-pivotal","html_url":"https://github.com/slari-pivotal","followers_url":"https://api.github.com/users/slari-pivotal/followers","following_url":"https://api.github.com/users/slari-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/slari-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/slari-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slari-pivotal/subscriptions","organizations_url":"https://api.github.com/users/slari-pivotal/orgs","repos_url":"https://api.github.com/users/slari-pivotal/repos","events_url":"https://api.github.com/users/slari-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/slari-pivotal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-07T00:38:57Z","updated_at":"2016-10-12T06:33:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1184","html_url":"https://github.com/greenplum-db/gpdb/pull/1184","diff_url":"https://github.com/greenplum-db/gpdb/pull/1184.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/1184.patch"},"body":"…ge().\r\n\r\nThe log_newpage() routine allocates an XLog record on the stack with\r\nuninitialized persistentTid and persistentSerialNum fields.  Insertion of these\r\nXLog records causes problems in XLog replay during recovery.\r\n\r\nThis commit insures that the XLog records written by log_newpage() always have\r\nthe persistentTid and persistentSerial set correctly.\r\n\r\nThis commit also makes the test\r\nsrc/test/tinc/tincrepo/mpp/gpdb/tests/storage/crashrecovery/test_reindex_pg_class.py\r\npass."},"comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments/253130972","html_url":"https://github.com/greenplum-db/gpdb/pull/1184#issuecomment-253130972","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1184","id":253130972,"user":{"login":"hlinnaka","id":191602,"avatar_url":"https://avatars.githubusercontent.com/u/191602?v=3","gravatar_id":"","url":"https://api.github.com/users/hlinnaka","html_url":"https://github.com/hlinnaka","followers_url":"https://api.github.com/users/hlinnaka/followers","following_url":"https://api.github.com/users/hlinnaka/following{/other_user}","gists_url":"https://api.github.com/users/hlinnaka/gists{/gist_id}","starred_url":"https://api.github.com/users/hlinnaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlinnaka/subscriptions","organizations_url":"https://api.github.com/users/hlinnaka/orgs","repos_url":"https://api.github.com/users/hlinnaka/repos","events_url":"https://api.github.com/users/hlinnaka/events{/privacy}","received_events_url":"https://api.github.com/users/hlinnaka/received_events","type":"User","site_admin":false},"created_at":"2016-10-12T06:33:10Z","updated_at":"2016-10-12T06:33:10Z","body":"BTW, I hit a similar issue during the 8.3 merge. See discussion at https://groups.google.com/a/greenplum.org/forum/m/#!msg/gpdb-dev/xJ4Y9czAPh8/5-UY9oeyAwAJ. It would be really nice to have an assertion to prevent this from happening again."}}
{"actor":{"display_login":"hlinnaka"}}