{"action":"created","comment":{"url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/pulls/comments/72667516","id":72667516,"diff_hunk":"@@ -222,38 +206,33 @@\n \n     describe '#add_general_notes' do\n       before do\n-        allow(r).to receive(:mods).and_return(mods)\n         subject.send(:add_general_notes, sdb, solr_doc)\n       end\n \n       context 'no general notes, but other types of notes' do\n-        let(:mods) do\n-          Nokogiri::XML <<-EOF\n-            <mods xmlns=\"#{Mods::MODS_NS}\">\n-              <note displayLabel=\"preferred citation\">(not a document subtype)</note>\n-              <note displayLabel=\"Document subtype\">memorandums</note>\n-              <note displayLabel=\"Donor tags\">Knowledge Systems Laboratory</note>\n-            </mods>\n-            EOF\n+        let(:modsbody) do\n+          <<-EOF\n+            <note displayLabel=\"preferred citation\">(not a document subtype)</note>\n+            <note displayLabel=\"Document subtype\">memorandums</note>\n+            <note displayLabel=\"Donor tags\">Knowledge Systems Laboratory</note>\n+          EOF\n         end\n \n         it 'is blank' do\n-          expect(solr_doc['general_notes_ssim']).to be_blank\n+          expect(solr_doc).not_to include 'general_notes_ssim'\n         end\n       end\n \n       context 'ignore extra notes' do\n-        let(:mods) do\n-          Nokogiri::XML <<-EOF\n-            <mods xmlns=\"#{Mods::MODS_NS}\">\n-              <note displayLabel=\"Document subtype\">memorandums</note>\n-              <note>a generic note</note>\n-            </mods>\n-            EOF\n+        let(:modsbody) do\n+          <<-EOF\n+            <note displayLabel=\"Document subtype\">memorandums</note>\n+            <note>a generic note</note>\n+          EOF\n         end\n \n         it 'extracts the doc subtypes' do\n-          expect(solr_doc['general_notes_ssim']).to contain_exactly 'a generic note'","path":"spec/lib/spotlight/dor/indexer_spec.rb","position":257,"original_position":257,"commit_id":"c96685ba53c578b077ad4f1e1e3b05d0dc36bc2e","original_commit_id":"b40a403d5c45c6e1f36695d6394585aa22930cdf","user":{"login":"cbeer","id":111218,"avatar_url":"https://avatars.githubusercontent.com/u/111218?v=3","gravatar_id":"","url":"https://api.github.com/users/cbeer","html_url":"https://github.com/cbeer","followers_url":"https://api.github.com/users/cbeer/followers","following_url":"https://api.github.com/users/cbeer/following{/other_user}","gists_url":"https://api.github.com/users/cbeer/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeer/subscriptions","organizations_url":"https://api.github.com/users/cbeer/orgs","repos_url":"https://api.github.com/users/cbeer/repos","events_url":"https://api.github.com/users/cbeer/events{/privacy}","received_events_url":"https://api.github.com/users/cbeer/received_events","type":"User","site_admin":false},"body":"I disagree. I don't think our upstream or downstream consumers care what type of thing it is, just that it contains particular elements. If this was new code, :shrug:, but changing the existing (and perfectly valid) matcher seems unnecessary. ","created_at":"2016-07-28T17:42:58Z","updated_at":"2016-07-28T17:42:58Z","html_url":"https://github.com/sul-dlss/spotlight-dor-resources/pull/83#discussion_r72667516","pull_request_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/pulls/comments/72667516"},"html":{"href":"https://github.com/sul-dlss/spotlight-dor-resources/pull/83#discussion_r72667516"},"pull_request":{"href":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/pulls/83","id":79107713,"html_url":"https://github.com/sul-dlss/spotlight-dor-resources/pull/83","diff_url":"https://github.com/sul-dlss/spotlight-dor-resources/pull/83.diff","patch_url":"https://github.com/sul-dlss/spotlight-dor-resources/pull/83.patch","issue_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/issues/83","number":83,"state":"open","locked":false,"title":"Geonames","user":{"login":"atz","id":109954,"avatar_url":"https://avatars.githubusercontent.com/u/109954?v=3","gravatar_id":"","url":"https://api.github.com/users/atz","html_url":"https://github.com/atz","followers_url":"https://api.github.com/users/atz/followers","following_url":"https://api.github.com/users/atz/following{/other_user}","gists_url":"https://api.github.com/users/atz/gists{/gist_id}","starred_url":"https://api.github.com/users/atz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atz/subscriptions","organizations_url":"https://api.github.com/users/atz/orgs","repos_url":"https://api.github.com/users/atz/repos","events_url":"https://api.github.com/users/atz/events{/privacy}","received_events_url":"https://api.github.com/users/atz/received_events","type":"User","site_admin":false},"body":"This provides needed functionality for geonames resolution, bbox extraction and ENVELOPE indexing for a new SRPT solr field.\r\n\r\nRelates to: https://github.com/sul-dlss/exhibits/issues/209","created_at":"2016-07-27T22:18:12Z","updated_at":"2016-07-28T17:42:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5cd0c74d8f35171336ff390974b8c23981ce93c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/pulls/83/commits","review_comments_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/pulls/83/comments","review_comment_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/issues/83/comments","statuses_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/statuses/c96685ba53c578b077ad4f1e1e3b05d0dc36bc2e","head":{"label":"sul-dlss:geonames","ref":"geonames","sha":"c96685ba53c578b077ad4f1e1e3b05d0dc36bc2e","user":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"repo":{"id":17453060,"name":"spotlight-dor-resources","full_name":"sul-dlss/spotlight-dor-resources","owner":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sul-dlss/spotlight-dor-resources","description":"Harvest Stanford DOR resources into a Spotlight exhibit","fork":false,"url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources","forks_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/forks","keys_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/teams","hooks_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/hooks","issue_events_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/issues/events{/number}","events_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/events","assignees_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/assignees{/user}","branches_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/branches{/branch}","tags_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/tags","blobs_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/git/refs{/sha}","trees_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/statuses/{sha}","languages_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/languages","stargazers_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/stargazers","contributors_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/contributors","subscribers_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/subscribers","subscription_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/subscription","commits_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/commits{/sha}","git_commits_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/git/commits{/sha}","comments_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/comments{/number}","issue_comment_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/issues/comments{/number}","contents_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/contents/{+path}","compare_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/merges","archive_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/downloads","issues_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/issues{/number}","pulls_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/pulls{/number}","milestones_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/milestones{/number}","notifications_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/labels{/name}","releases_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/releases{/id}","deployments_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/deployments","created_at":"2014-03-05T19:55:10Z","updated_at":"2016-01-21T19:43:56Z","pushed_at":"2016-07-27T23:56:55Z","git_url":"git://github.com/sul-dlss/spotlight-dor-resources.git","ssh_url":"git@github.com:sul-dlss/spotlight-dor-resources.git","clone_url":"https://github.com/sul-dlss/spotlight-dor-resources.git","svn_url":"https://github.com/sul-dlss/spotlight-dor-resources","homepage":"","size":317,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"sul-dlss:master","ref":"master","sha":"514d933318bfa2447d3d13f3dac878c575a9a88f","user":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"repo":{"id":17453060,"name":"spotlight-dor-resources","full_name":"sul-dlss/spotlight-dor-resources","owner":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sul-dlss/spotlight-dor-resources","description":"Harvest Stanford DOR resources into a Spotlight exhibit","fork":false,"url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources","forks_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/forks","keys_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/teams","hooks_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/hooks","issue_events_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/issues/events{/number}","events_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/events","assignees_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/assignees{/user}","branches_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/branches{/branch}","tags_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/tags","blobs_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/git/refs{/sha}","trees_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/statuses/{sha}","languages_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/languages","stargazers_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/stargazers","contributors_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/contributors","subscribers_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/subscribers","subscription_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/subscription","commits_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/commits{/sha}","git_commits_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/git/commits{/sha}","comments_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/comments{/number}","issue_comment_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/issues/comments{/number}","contents_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/contents/{+path}","compare_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/merges","archive_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/downloads","issues_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/issues{/number}","pulls_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/pulls{/number}","milestones_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/milestones{/number}","notifications_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/labels{/name}","releases_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/releases{/id}","deployments_url":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/deployments","created_at":"2014-03-05T19:55:10Z","updated_at":"2016-01-21T19:43:56Z","pushed_at":"2016-07-27T23:56:55Z","git_url":"git://github.com/sul-dlss/spotlight-dor-resources.git","ssh_url":"git@github.com:sul-dlss/spotlight-dor-resources.git","clone_url":"https://github.com/sul-dlss/spotlight-dor-resources.git","svn_url":"https://github.com/sul-dlss/spotlight-dor-resources","homepage":"","size":317,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/pulls/83"},"html":{"href":"https://github.com/sul-dlss/spotlight-dor-resources/pull/83"},"issue":{"href":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/issues/83"},"comments":{"href":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/sul-dlss/spotlight-dor-resources/statuses/c96685ba53c578b077ad4f1e1e3b05d0dc36bc2e"}}}}
{"actor":{"display_login":"cbeer"}}