{"action":"created","issue":{"url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/448","repository_url":"https://api.github.com/repos/broadinstitute/firecloud-ui","labels_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/448/labels{/name}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/448/comments","events_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/448/events","html_url":"https://github.com/broadinstitute/firecloud-ui/pull/448","id":158213971,"number":448,"title":"GAWB-727 prep","user":{"login":"MattPutnam","id":785011,"avatar_url":"https://avatars.githubusercontent.com/u/785011?v=3","gravatar_id":"","url":"https://api.github.com/users/MattPutnam","html_url":"https://github.com/MattPutnam","followers_url":"https://api.github.com/users/MattPutnam/followers","following_url":"https://api.github.com/users/MattPutnam/following{/other_user}","gists_url":"https://api.github.com/users/MattPutnam/gists{/gist_id}","starred_url":"https://api.github.com/users/MattPutnam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattPutnam/subscriptions","organizations_url":"https://api.github.com/users/MattPutnam/orgs","repos_url":"https://api.github.com/users/MattPutnam/repos","events_url":"https://api.github.com/users/MattPutnam/events{/privacy}","received_events_url":"https://api.github.com/users/MattPutnam/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"dmohs","id":1545444,"avatar_url":"https://avatars.githubusercontent.com/u/1545444?v=3","gravatar_id":"","url":"https://api.github.com/users/dmohs","html_url":"https://github.com/dmohs","followers_url":"https://api.github.com/users/dmohs/followers","following_url":"https://api.github.com/users/dmohs/following{/other_user}","gists_url":"https://api.github.com/users/dmohs/gists{/gist_id}","starred_url":"https://api.github.com/users/dmohs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmohs/subscriptions","organizations_url":"https://api.github.com/users/dmohs/orgs","repos_url":"https://api.github.com/users/dmohs/repos","events_url":"https://api.github.com/users/dmohs/events{/privacy}","received_events_url":"https://api.github.com/users/dmohs/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-06-02T18:56:07Z","updated_at":"2016-06-06T22:52:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/broadinstitute/firecloud-ui/pulls/448","html_url":"https://github.com/broadinstitute/firecloud-ui/pull/448","diff_url":"https://github.com/broadinstitute/firecloud-ui/pull/448.diff","patch_url":"https://github.com/broadinstitute/firecloud-ui/pull/448.patch"},"body":"This is another refactor in preparation of GAWB-727.  I was going to just make this the first commit of the main PR to come, but it's hefty enough to warrant its own PR.\r\n\r\nThis refactoring pulls all of the row calculation logic into a single place, `:refresh-rows` which is called on load and if the data or query params change.  The current client-side pagination just processes the passed-in data; server-side pagination will fire an AJAX call.  Note that this is now the only place that touches `:data` except for the FilterGroupBar, which only uses it for counting and will be overridden with manual counts anyway.\r\n\r\n- [x] **Submitter**: Rebase to develop. DO NOT SQUASH\r\n- [x] **Submitter**: Make sure Swagger is updated if API changes\r\n- [x] **Submitter**: Make sure documentation for code is complete\r\n- [x] **Submitter**: Review code comments; remove done TODOs, create stories for remaining TODOs\r\n- [x] **Submitter**: Include the JIRA issue number in the PR description\r\n- [x] **Submitter**: Add description or comments on the PR explaining the hows/whys (if not obvious)\r\n- [x] **Submitter**: Tell tech lead that the PR exists if s/he wants to look at it\r\n- [x] **Submitter**: Anoint a lead reviewer (LR). **Assign PR to LR**\r\n- [x] **LR**: Initial review by LR and others.\r\n- [ ] Comment / review / update cycle:\r\n  * Rest of team may comments on PR at will\r\n  * **LR assigns to submitter** for feedback fixes\r\n  * Submitter updates documentation as needed\r\n  * Submitter rebases to develop again if necessary\r\n  * Submitter makes further commits. DO NOT SQUASH. **Reassign to LR** for further feedback\r\n- [ ] **Tech lead**: sign off\r\n- [x] **LR**: sign off\r\n- [ ] **Assign to submitter** to finalize\r\n- [ ] **Submitter**: Squash commits, rebase if necessary\r\n- [ ] **Submitter**: Verify all tests go green, including CI tests\r\n- [ ] **Submitter**: Merge to develop \r\n- [ ] **Submitter**: Delete branch after merge\r\n- [ ] **Submitter**: Check configuration files in Jenkins in case they need changes\r\n- [ ] **Submitter**: **Test this change works on dev environment after deployment**. YOU own getting it fixed if dev isn't \r\nworking for ANY reason!\r\n- [ ] **Submitter**: Verify swagger UI on dev server still works after deployment\r\n- [ ] **Submitter**: Inform other teams of any API changes via hipchat and/or email\r\n- [ ] ~~**Submitter**: Mark JIRA issue as resolved once this checklist is completed~~\r\n"},"comment":{"url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/comments/224113258","html_url":"https://github.com/broadinstitute/firecloud-ui/pull/448#issuecomment-224113258","issue_url":"https://api.github.com/repos/broadinstitute/firecloud-ui/issues/448","id":224113258,"user":{"login":"dmohs","id":1545444,"avatar_url":"https://avatars.githubusercontent.com/u/1545444?v=3","gravatar_id":"","url":"https://api.github.com/users/dmohs","html_url":"https://github.com/dmohs","followers_url":"https://api.github.com/users/dmohs/followers","following_url":"https://api.github.com/users/dmohs/following{/other_user}","gists_url":"https://api.github.com/users/dmohs/gists{/gist_id}","starred_url":"https://api.github.com/users/dmohs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmohs/subscriptions","organizations_url":"https://api.github.com/users/dmohs/orgs","repos_url":"https://api.github.com/users/dmohs/repos","events_url":"https://api.github.com/users/dmohs/events{/privacy}","received_events_url":"https://api.github.com/users/dmohs/received_events","type":"User","site_admin":false},"created_at":"2016-06-06T22:52:51Z","updated_at":"2016-06-06T22:52:51Z","body":"👍  Code looks good. I didn't run it, so I'll do that tomorrow, but as far as I am concerned, this can be merged regardless."}}
{"actor":{"display_login":"dmohs"}}