{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/93835007","pull_request_review_id":14369231,"id":93835007,"diff_hunk":"@@ -2281,6 +2170,10 @@ floor{To}(::Type{To}, A::SparseMatrixCSC) = floor.(To, A)\n trunc{To}(::Type{To}, A::SparseMatrixCSC) = trunc.(To, A)\n round{To}(::Type{To}, A::SparseMatrixCSC) = round.(To, A)\n \n+# broadcast_zpreserving[!] deprecated in 0.6. Wasn't exported prior, so need these\n+# definitions for the deprecation to serve its purpose. Remove after 0.6.","path":"base/sparse/sparsematrix.jl","position":123,"original_position":123,"commit_id":"08ed837a3f027dfdbbacfa552cf9e2182134c109","original_commit_id":"08ed837a3f027dfdbbacfa552cf9e2182134c109","user":{"login":"tkelman","id":5934628,"avatar_url":"https://avatars.githubusercontent.com/u/5934628?v=3","gravatar_id":"","url":"https://api.github.com/users/tkelman","html_url":"https://github.com/tkelman","followers_url":"https://api.github.com/users/tkelman/followers","following_url":"https://api.github.com/users/tkelman/following{/other_user}","gists_url":"https://api.github.com/users/tkelman/gists{/gist_id}","starred_url":"https://api.github.com/users/tkelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkelman/subscriptions","organizations_url":"https://api.github.com/users/tkelman/orgs","repos_url":"https://api.github.com/users/tkelman/repos","events_url":"https://api.github.com/users/tkelman/events{/privacy}","received_events_url":"https://api.github.com/users/tkelman/received_events","type":"User","site_admin":false},"body":"could also eval the deprecation into this module from deprecated.jl","created_at":"2016-12-25T23:29:47Z","updated_at":"2016-12-25T23:29:47Z","html_url":"https://github.com/JuliaLang/julia/pull/19720#discussion_r93835007","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/19720","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/93835007"},"html":{"href":"https://github.com/JuliaLang/julia/pull/19720#discussion_r93835007"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/19720"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/19720","id":99329064,"html_url":"https://github.com/JuliaLang/julia/pull/19720","diff_url":"https://github.com/JuliaLang/julia/pull/19720.diff","patch_url":"https://github.com/JuliaLang/julia/pull/19720.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/19720","number":19720,"state":"open","locked":false,"title":"Deprecate broadcast_zpreserving[!]","user":{"login":"Sacha0","id":5799177,"avatar_url":"https://avatars.githubusercontent.com/u/5799177?v=3","gravatar_id":"","url":"https://api.github.com/users/Sacha0","html_url":"https://github.com/Sacha0","followers_url":"https://api.github.com/users/Sacha0/followers","following_url":"https://api.github.com/users/Sacha0/following{/other_user}","gists_url":"https://api.github.com/users/Sacha0/gists{/gist_id}","starred_url":"https://api.github.com/users/Sacha0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sacha0/subscriptions","organizations_url":"https://api.github.com/users/Sacha0/orgs","repos_url":"https://api.github.com/users/Sacha0/repos","events_url":"https://api.github.com/users/Sacha0/events{/privacy}","received_events_url":"https://api.github.com/users/Sacha0/received_events","type":"User","site_admin":false},"body":"This pull request deprecates `Base.SparseArrays.broadcast_zpreserving[!]`, please see #19533 for more. Best!","created_at":"2016-12-25T20:37:07Z","updated_at":"2016-12-25T23:29:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e08e60ade0dc0ed4541251cbc24ff8171960bd8c","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/JuliaLang/julia/milestones/20","html_url":"https://github.com/JuliaLang/julia/milestone/20","labels_url":"https://api.github.com/repos/JuliaLang/julia/milestones/20/labels","id":1298021,"number":20,"title":"0.6.0","description":"","creator":{"login":"JeffBezanson","id":744556,"avatar_url":"https://avatars.githubusercontent.com/u/744556?v=3","gravatar_id":"","url":"https://api.github.com/users/JeffBezanson","html_url":"https://github.com/JeffBezanson","followers_url":"https://api.github.com/users/JeffBezanson/followers","following_url":"https://api.github.com/users/JeffBezanson/following{/other_user}","gists_url":"https://api.github.com/users/JeffBezanson/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffBezanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffBezanson/subscriptions","organizations_url":"https://api.github.com/users/JeffBezanson/orgs","repos_url":"https://api.github.com/users/JeffBezanson/repos","events_url":"https://api.github.com/users/JeffBezanson/events{/privacy}","received_events_url":"https://api.github.com/users/JeffBezanson/received_events","type":"User","site_admin":false},"open_issues":127,"closed_issues":80,"state":"open","created_at":"2015-09-09T16:35:16Z","updated_at":"2016-12-25T20:37:07Z","due_on":"2017-02-28T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/19720/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/19720/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/19720/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/08ed837a3f027dfdbbacfa552cf9e2182134c109","head":{"label":"Sacha0:depbczpres","ref":"depbczpres","sha":"08ed837a3f027dfdbbacfa552cf9e2182134c109","user":{"login":"Sacha0","id":5799177,"avatar_url":"https://avatars.githubusercontent.com/u/5799177?v=3","gravatar_id":"","url":"https://api.github.com/users/Sacha0","html_url":"https://github.com/Sacha0","followers_url":"https://api.github.com/users/Sacha0/followers","following_url":"https://api.github.com/users/Sacha0/following{/other_user}","gists_url":"https://api.github.com/users/Sacha0/gists{/gist_id}","starred_url":"https://api.github.com/users/Sacha0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sacha0/subscriptions","organizations_url":"https://api.github.com/users/Sacha0/orgs","repos_url":"https://api.github.com/users/Sacha0/repos","events_url":"https://api.github.com/users/Sacha0/events{/privacy}","received_events_url":"https://api.github.com/users/Sacha0/received_events","type":"User","site_admin":false},"repo":{"id":46197044,"name":"julia","full_name":"Sacha0/julia","owner":{"login":"Sacha0","id":5799177,"avatar_url":"https://avatars.githubusercontent.com/u/5799177?v=3","gravatar_id":"","url":"https://api.github.com/users/Sacha0","html_url":"https://github.com/Sacha0","followers_url":"https://api.github.com/users/Sacha0/followers","following_url":"https://api.github.com/users/Sacha0/following{/other_user}","gists_url":"https://api.github.com/users/Sacha0/gists{/gist_id}","starred_url":"https://api.github.com/users/Sacha0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sacha0/subscriptions","organizations_url":"https://api.github.com/users/Sacha0/orgs","repos_url":"https://api.github.com/users/Sacha0/repos","events_url":"https://api.github.com/users/Sacha0/events{/privacy}","received_events_url":"https://api.github.com/users/Sacha0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sacha0/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/Sacha0/julia","forks_url":"https://api.github.com/repos/Sacha0/julia/forks","keys_url":"https://api.github.com/repos/Sacha0/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sacha0/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sacha0/julia/teams","hooks_url":"https://api.github.com/repos/Sacha0/julia/hooks","issue_events_url":"https://api.github.com/repos/Sacha0/julia/issues/events{/number}","events_url":"https://api.github.com/repos/Sacha0/julia/events","assignees_url":"https://api.github.com/repos/Sacha0/julia/assignees{/user}","branches_url":"https://api.github.com/repos/Sacha0/julia/branches{/branch}","tags_url":"https://api.github.com/repos/Sacha0/julia/tags","blobs_url":"https://api.github.com/repos/Sacha0/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sacha0/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sacha0/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sacha0/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sacha0/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/Sacha0/julia/languages","stargazers_url":"https://api.github.com/repos/Sacha0/julia/stargazers","contributors_url":"https://api.github.com/repos/Sacha0/julia/contributors","subscribers_url":"https://api.github.com/repos/Sacha0/julia/subscribers","subscription_url":"https://api.github.com/repos/Sacha0/julia/subscription","commits_url":"https://api.github.com/repos/Sacha0/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sacha0/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sacha0/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sacha0/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sacha0/julia/contents/{+path}","compare_url":"https://api.github.com/repos/Sacha0/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sacha0/julia/merges","archive_url":"https://api.github.com/repos/Sacha0/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sacha0/julia/downloads","issues_url":"https://api.github.com/repos/Sacha0/julia/issues{/number}","pulls_url":"https://api.github.com/repos/Sacha0/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/Sacha0/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/Sacha0/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sacha0/julia/labels{/name}","releases_url":"https://api.github.com/repos/Sacha0/julia/releases{/id}","deployments_url":"https://api.github.com/repos/Sacha0/julia/deployments","created_at":"2015-11-14T23:50:27Z","updated_at":"2015-11-14T23:50:41Z","pushed_at":"2016-12-25T23:14:10Z","git_url":"git://github.com/Sacha0/julia.git","ssh_url":"git@github.com:Sacha0/julia.git","clone_url":"https://github.com/Sacha0/julia.git","svn_url":"https://github.com/Sacha0/julia","homepage":"http://julialang.org/","size":101950,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"4793e88185573387a514e3e40ca14128d4920886","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2016-12-25T21:51:43Z","pushed_at":"2016-12-25T23:14:12Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":117021,"stargazers_count":7946,"watchers_count":7946,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1864,"mirror_url":null,"open_issues_count":2243,"forks":1864,"open_issues":2243,"watchers":7946,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/19720"},"html":{"href":"https://github.com/JuliaLang/julia/pull/19720"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/19720"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/19720/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/19720/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/19720/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/08ed837a3f027dfdbbacfa552cf9e2182134c109"}}}}
{"actor":{"display_login":"tkelman"}}