{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/ProboCI/probo-styleguide/pulls/1","id":63731501,"html_url":"https://github.com/ProboCI/probo-styleguide/pull/1","diff_url":"https://github.com/ProboCI/probo-styleguide/pull/1.diff","patch_url":"https://github.com/ProboCI/probo-styleguide/pull/1.patch","issue_url":"https://api.github.com/repos/ProboCI/probo-styleguide/issues/1","number":1,"state":"closed","locked":false,"title":"Updates for integrating into web app","user":{"login":"tortillaj","id":851788,"avatar_url":"https://avatars.githubusercontent.com/u/851788?v=3","gravatar_id":"","url":"https://api.github.com/users/tortillaj","html_url":"https://github.com/tortillaj","followers_url":"https://api.github.com/users/tortillaj/followers","following_url":"https://api.github.com/users/tortillaj/following{/other_user}","gists_url":"https://api.github.com/users/tortillaj/gists{/gist_id}","starred_url":"https://api.github.com/users/tortillaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tortillaj/subscriptions","organizations_url":"https://api.github.com/users/tortillaj/orgs","repos_url":"https://api.github.com/users/tortillaj/repos","events_url":"https://api.github.com/users/tortillaj/events{/privacy}","received_events_url":"https://api.github.com/users/tortillaj/received_events","type":"User","site_admin":false},"body":"@sean3325 here are some updates I am suggesting as part of integrating this with the web app. I don't think they will affect the Drupal site or probo.ci at all ...\r\n\r\n## Removals\r\n\r\nI removed these from the style guide\r\n\r\n1. Change the clipboard button so that the clipboard icon has the same background gradient as the button itself. \r\n1. Remove the background for icon only buttons. (Buttons where the visible part is only an icon, like the red, delete X button)\r\n1. Pull the segment atoms out of this styleguide. They are only useful for the web app, and the styles are really specific to the markup, meaning they won't be easily reused in other projects.\r\n1. Remove the width and margin of the select menus, because both of those properties will change depending on where the select menu lives on a page.\r\n\r\n## Additions\r\n\r\nI didn't add these, they are just ideas for future updates\r\n\r\n1. Styles for disabled green, blue, and black buttons","created_at":"2016-03-22T14:45:01Z","updated_at":"2016-03-22T20:02:36Z","closed_at":"2016-03-22T20:02:36Z","merged_at":"2016-03-22T20:02:36Z","merge_commit_sha":"4bcbbd430ceab093ab0bf3c723fbb6bcd8b5ce23","assignee":{"login":"tortillaj","id":851788,"avatar_url":"https://avatars.githubusercontent.com/u/851788?v=3","gravatar_id":"","url":"https://api.github.com/users/tortillaj","html_url":"https://github.com/tortillaj","followers_url":"https://api.github.com/users/tortillaj/followers","following_url":"https://api.github.com/users/tortillaj/following{/other_user}","gists_url":"https://api.github.com/users/tortillaj/gists{/gist_id}","starred_url":"https://api.github.com/users/tortillaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tortillaj/subscriptions","organizations_url":"https://api.github.com/users/tortillaj/orgs","repos_url":"https://api.github.com/users/tortillaj/repos","events_url":"https://api.github.com/users/tortillaj/events{/privacy}","received_events_url":"https://api.github.com/users/tortillaj/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ProboCI/probo-styleguide/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ProboCI/probo-styleguide/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ProboCI/probo-styleguide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ProboCI/probo-styleguide/issues/1/comments","statuses_url":"https://api.github.com/repos/ProboCI/probo-styleguide/statuses/e87b3aa86f1174e183b08a6b4a566e3e71d59575","head":{"label":"ProboCI:tortillaj-patch-1","ref":"tortillaj-patch-1","sha":"e87b3aa86f1174e183b08a6b4a566e3e71d59575","user":{"login":"ProboCI","id":12071240,"avatar_url":"https://avatars.githubusercontent.com/u/12071240?v=3","gravatar_id":"","url":"https://api.github.com/users/ProboCI","html_url":"https://github.com/ProboCI","followers_url":"https://api.github.com/users/ProboCI/followers","following_url":"https://api.github.com/users/ProboCI/following{/other_user}","gists_url":"https://api.github.com/users/ProboCI/gists{/gist_id}","starred_url":"https://api.github.com/users/ProboCI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProboCI/subscriptions","organizations_url":"https://api.github.com/users/ProboCI/orgs","repos_url":"https://api.github.com/users/ProboCI/repos","events_url":"https://api.github.com/users/ProboCI/events{/privacy}","received_events_url":"https://api.github.com/users/ProboCI/received_events","type":"Organization","site_admin":false},"repo":{"id":51379237,"name":"probo-styleguide","full_name":"ProboCI/probo-styleguide","owner":{"login":"ProboCI","id":12071240,"avatar_url":"https://avatars.githubusercontent.com/u/12071240?v=3","gravatar_id":"","url":"https://api.github.com/users/ProboCI","html_url":"https://github.com/ProboCI","followers_url":"https://api.github.com/users/ProboCI/followers","following_url":"https://api.github.com/users/ProboCI/following{/other_user}","gists_url":"https://api.github.com/users/ProboCI/gists{/gist_id}","starred_url":"https://api.github.com/users/ProboCI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProboCI/subscriptions","organizations_url":"https://api.github.com/users/ProboCI/orgs","repos_url":"https://api.github.com/users/ProboCI/repos","events_url":"https://api.github.com/users/ProboCI/events{/privacy}","received_events_url":"https://api.github.com/users/ProboCI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ProboCI/probo-styleguide","description":"ProboCI common style standards","fork":false,"url":"https://api.github.com/repos/ProboCI/probo-styleguide","forks_url":"https://api.github.com/repos/ProboCI/probo-styleguide/forks","keys_url":"https://api.github.com/repos/ProboCI/probo-styleguide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProboCI/probo-styleguide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProboCI/probo-styleguide/teams","hooks_url":"https://api.github.com/repos/ProboCI/probo-styleguide/hooks","issue_events_url":"https://api.github.com/repos/ProboCI/probo-styleguide/issues/events{/number}","events_url":"https://api.github.com/repos/ProboCI/probo-styleguide/events","assignees_url":"https://api.github.com/repos/ProboCI/probo-styleguide/assignees{/user}","branches_url":"https://api.github.com/repos/ProboCI/probo-styleguide/branches{/branch}","tags_url":"https://api.github.com/repos/ProboCI/probo-styleguide/tags","blobs_url":"https://api.github.com/repos/ProboCI/probo-styleguide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProboCI/probo-styleguide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProboCI/probo-styleguide/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProboCI/probo-styleguide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProboCI/probo-styleguide/statuses/{sha}","languages_url":"https://api.github.com/repos/ProboCI/probo-styleguide/languages","stargazers_url":"https://api.github.com/repos/ProboCI/probo-styleguide/stargazers","contributors_url":"https://api.github.com/repos/ProboCI/probo-styleguide/contributors","subscribers_url":"https://api.github.com/repos/ProboCI/probo-styleguide/subscribers","subscription_url":"https://api.github.com/repos/ProboCI/probo-styleguide/subscription","commits_url":"https://api.github.com/repos/ProboCI/probo-styleguide/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProboCI/probo-styleguide/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProboCI/probo-styleguide/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProboCI/probo-styleguide/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProboCI/probo-styleguide/contents/{+path}","compare_url":"https://api.github.com/repos/ProboCI/probo-styleguide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProboCI/probo-styleguide/merges","archive_url":"https://api.github.com/repos/ProboCI/probo-styleguide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProboCI/probo-styleguide/downloads","issues_url":"https://api.github.com/repos/ProboCI/probo-styleguide/issues{/number}","pulls_url":"https://api.github.com/repos/ProboCI/probo-styleguide/pulls{/number}","milestones_url":"https://api.github.com/repos/ProboCI/probo-styleguide/milestones{/number}","notifications_url":"https://api.github.com/repos/ProboCI/probo-styleguide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProboCI/probo-styleguide/labels{/name}","releases_url":"https://api.github.com/repos/ProboCI/probo-styleguide/releases{/id}","deployments_url":"https://api.github.com/repos/ProboCI/probo-styleguide/deployments","created_at":"2016-02-09T16:22:34Z","updated_at":"2016-03-18T19:05:24Z","pushed_at":"2016-03-22T20:02:36Z","git_url":"git://github.com/ProboCI/probo-styleguide.git","ssh_url":"git@github.com:ProboCI/probo-styleguide.git","clone_url":"https://github.com/ProboCI/probo-styleguide.git","svn_url":"https://github.com/ProboCI/probo-styleguide","homepage":"http://proboci.github.io/probo-styleguide/","size":1415,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ProboCI:master","ref":"master","sha":"b0f2461c7bb94b0ad913b46f5260c72f9c56a0d9","user":{"login":"ProboCI","id":12071240,"avatar_url":"https://avatars.githubusercontent.com/u/12071240?v=3","gravatar_id":"","url":"https://api.github.com/users/ProboCI","html_url":"https://github.com/ProboCI","followers_url":"https://api.github.com/users/ProboCI/followers","following_url":"https://api.github.com/users/ProboCI/following{/other_user}","gists_url":"https://api.github.com/users/ProboCI/gists{/gist_id}","starred_url":"https://api.github.com/users/ProboCI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProboCI/subscriptions","organizations_url":"https://api.github.com/users/ProboCI/orgs","repos_url":"https://api.github.com/users/ProboCI/repos","events_url":"https://api.github.com/users/ProboCI/events{/privacy}","received_events_url":"https://api.github.com/users/ProboCI/received_events","type":"Organization","site_admin":false},"repo":{"id":51379237,"name":"probo-styleguide","full_name":"ProboCI/probo-styleguide","owner":{"login":"ProboCI","id":12071240,"avatar_url":"https://avatars.githubusercontent.com/u/12071240?v=3","gravatar_id":"","url":"https://api.github.com/users/ProboCI","html_url":"https://github.com/ProboCI","followers_url":"https://api.github.com/users/ProboCI/followers","following_url":"https://api.github.com/users/ProboCI/following{/other_user}","gists_url":"https://api.github.com/users/ProboCI/gists{/gist_id}","starred_url":"https://api.github.com/users/ProboCI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProboCI/subscriptions","organizations_url":"https://api.github.com/users/ProboCI/orgs","repos_url":"https://api.github.com/users/ProboCI/repos","events_url":"https://api.github.com/users/ProboCI/events{/privacy}","received_events_url":"https://api.github.com/users/ProboCI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ProboCI/probo-styleguide","description":"ProboCI common style standards","fork":false,"url":"https://api.github.com/repos/ProboCI/probo-styleguide","forks_url":"https://api.github.com/repos/ProboCI/probo-styleguide/forks","keys_url":"https://api.github.com/repos/ProboCI/probo-styleguide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProboCI/probo-styleguide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProboCI/probo-styleguide/teams","hooks_url":"https://api.github.com/repos/ProboCI/probo-styleguide/hooks","issue_events_url":"https://api.github.com/repos/ProboCI/probo-styleguide/issues/events{/number}","events_url":"https://api.github.com/repos/ProboCI/probo-styleguide/events","assignees_url":"https://api.github.com/repos/ProboCI/probo-styleguide/assignees{/user}","branches_url":"https://api.github.com/repos/ProboCI/probo-styleguide/branches{/branch}","tags_url":"https://api.github.com/repos/ProboCI/probo-styleguide/tags","blobs_url":"https://api.github.com/repos/ProboCI/probo-styleguide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProboCI/probo-styleguide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProboCI/probo-styleguide/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProboCI/probo-styleguide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProboCI/probo-styleguide/statuses/{sha}","languages_url":"https://api.github.com/repos/ProboCI/probo-styleguide/languages","stargazers_url":"https://api.github.com/repos/ProboCI/probo-styleguide/stargazers","contributors_url":"https://api.github.com/repos/ProboCI/probo-styleguide/contributors","subscribers_url":"https://api.github.com/repos/ProboCI/probo-styleguide/subscribers","subscription_url":"https://api.github.com/repos/ProboCI/probo-styleguide/subscription","commits_url":"https://api.github.com/repos/ProboCI/probo-styleguide/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProboCI/probo-styleguide/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProboCI/probo-styleguide/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProboCI/probo-styleguide/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProboCI/probo-styleguide/contents/{+path}","compare_url":"https://api.github.com/repos/ProboCI/probo-styleguide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProboCI/probo-styleguide/merges","archive_url":"https://api.github.com/repos/ProboCI/probo-styleguide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProboCI/probo-styleguide/downloads","issues_url":"https://api.github.com/repos/ProboCI/probo-styleguide/issues{/number}","pulls_url":"https://api.github.com/repos/ProboCI/probo-styleguide/pulls{/number}","milestones_url":"https://api.github.com/repos/ProboCI/probo-styleguide/milestones{/number}","notifications_url":"https://api.github.com/repos/ProboCI/probo-styleguide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProboCI/probo-styleguide/labels{/name}","releases_url":"https://api.github.com/repos/ProboCI/probo-styleguide/releases{/id}","deployments_url":"https://api.github.com/repos/ProboCI/probo-styleguide/deployments","created_at":"2016-02-09T16:22:34Z","updated_at":"2016-03-18T19:05:24Z","pushed_at":"2016-03-22T20:02:36Z","git_url":"git://github.com/ProboCI/probo-styleguide.git","ssh_url":"git@github.com:ProboCI/probo-styleguide.git","clone_url":"https://github.com/ProboCI/probo-styleguide.git","svn_url":"https://github.com/ProboCI/probo-styleguide","homepage":"http://proboci.github.io/probo-styleguide/","size":1415,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ProboCI/probo-styleguide/pulls/1"},"html":{"href":"https://github.com/ProboCI/probo-styleguide/pull/1"},"issue":{"href":"https://api.github.com/repos/ProboCI/probo-styleguide/issues/1"},"comments":{"href":"https://api.github.com/repos/ProboCI/probo-styleguide/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ProboCI/probo-styleguide/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ProboCI/probo-styleguide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ProboCI/probo-styleguide/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ProboCI/probo-styleguide/statuses/e87b3aa86f1174e183b08a6b4a566e3e71d59575"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sean3325","id":502409,"avatar_url":"https://avatars.githubusercontent.com/u/502409?v=3","gravatar_id":"","url":"https://api.github.com/users/sean3325","html_url":"https://github.com/sean3325","followers_url":"https://api.github.com/users/sean3325/followers","following_url":"https://api.github.com/users/sean3325/following{/other_user}","gists_url":"https://api.github.com/users/sean3325/gists{/gist_id}","starred_url":"https://api.github.com/users/sean3325/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean3325/subscriptions","organizations_url":"https://api.github.com/users/sean3325/orgs","repos_url":"https://api.github.com/users/sean3325/repos","events_url":"https://api.github.com/users/sean3325/events{/privacy}","received_events_url":"https://api.github.com/users/sean3325/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":7,"additions":308,"deletions":1076,"changed_files":11}}