{"action":"opened","number":636,"pull_request":{"url":"https://api.github.com/repos/joyent/smartos-live/pulls/636","id":72583235,"html_url":"https://github.com/joyent/smartos-live/pull/636","diff_url":"https://github.com/joyent/smartos-live/pull/636.diff","patch_url":"https://github.com/joyent/smartos-live/pull/636.patch","issue_url":"https://api.github.com/repos/joyent/smartos-live/issues/636","number":636,"state":"open","locked":false,"title":"OS-5442 metadata agent cannot deal with stale sockets showing up post…","user":{"login":"joshwilsdon","id":78194,"avatar_url":"https://avatars.githubusercontent.com/u/78194?v=3","gravatar_id":"","url":"https://api.github.com/users/joshwilsdon","html_url":"https://github.com/joshwilsdon","followers_url":"https://api.github.com/users/joshwilsdon/followers","following_url":"https://api.github.com/users/joshwilsdon/following{/other_user}","gists_url":"https://api.github.com/users/joshwilsdon/gists{/gist_id}","starred_url":"https://api.github.com/users/joshwilsdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshwilsdon/subscriptions","organizations_url":"https://api.github.com/users/joshwilsdon/orgs","repos_url":"https://api.github.com/users/joshwilsdon/repos","events_url":"https://api.github.com/users/joshwilsdon/events{/privacy}","received_events_url":"https://api.github.com/users/joshwilsdon/received_events","type":"User","site_admin":false},"body":"… OS-4897\r\n\r\nThis changes the metadata agent to keep the fs.stat() info from a new socket when we create it. This way when we're checking for a stale socket we can also check the ino and dev fields and the ctime in order to detect metadata.sock files that have been swapped underneath us (from a zfs rollback for example).\r\n\r\nThis also adds a test case which reproduces the problem when not accompanied by the fix here.\r\n\r\nNote: There is a bunch of other reformatting in that test case that goes along with this. That's because I've added the test file to the list of files we check with `make check` and I had to reformat the existing code in order to make it pass.","created_at":"2016-06-03T23:26:54Z","updated_at":"2016-06-03T23:26:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joyent/smartos-live/pulls/636/commits","review_comments_url":"https://api.github.com/repos/joyent/smartos-live/pulls/636/comments","review_comment_url":"https://api.github.com/repos/joyent/smartos-live/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joyent/smartos-live/issues/636/comments","statuses_url":"https://api.github.com/repos/joyent/smartos-live/statuses/afd4e72e17924fd596d8a5db498d6e5f6dda3365","head":{"label":"joyent:OS-5442","ref":"OS-5442","sha":"afd4e72e17924fd596d8a5db498d6e5f6dda3365","user":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=3","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"repo":{"id":2203782,"name":"smartos-live","full_name":"joyent/smartos-live","owner":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=3","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joyent/smartos-live","description":"For more information, please see http://smartos.org/  For any questions that aren't answered there, please join the SmartOS discussion list: http://smartos.org/smartos-mailing-list/","fork":false,"url":"https://api.github.com/repos/joyent/smartos-live","forks_url":"https://api.github.com/repos/joyent/smartos-live/forks","keys_url":"https://api.github.com/repos/joyent/smartos-live/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joyent/smartos-live/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joyent/smartos-live/teams","hooks_url":"https://api.github.com/repos/joyent/smartos-live/hooks","issue_events_url":"https://api.github.com/repos/joyent/smartos-live/issues/events{/number}","events_url":"https://api.github.com/repos/joyent/smartos-live/events","assignees_url":"https://api.github.com/repos/joyent/smartos-live/assignees{/user}","branches_url":"https://api.github.com/repos/joyent/smartos-live/branches{/branch}","tags_url":"https://api.github.com/repos/joyent/smartos-live/tags","blobs_url":"https://api.github.com/repos/joyent/smartos-live/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joyent/smartos-live/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joyent/smartos-live/git/refs{/sha}","trees_url":"https://api.github.com/repos/joyent/smartos-live/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joyent/smartos-live/statuses/{sha}","languages_url":"https://api.github.com/repos/joyent/smartos-live/languages","stargazers_url":"https://api.github.com/repos/joyent/smartos-live/stargazers","contributors_url":"https://api.github.com/repos/joyent/smartos-live/contributors","subscribers_url":"https://api.github.com/repos/joyent/smartos-live/subscribers","subscription_url":"https://api.github.com/repos/joyent/smartos-live/subscription","commits_url":"https://api.github.com/repos/joyent/smartos-live/commits{/sha}","git_commits_url":"https://api.github.com/repos/joyent/smartos-live/git/commits{/sha}","comments_url":"https://api.github.com/repos/joyent/smartos-live/comments{/number}","issue_comment_url":"https://api.github.com/repos/joyent/smartos-live/issues/comments{/number}","contents_url":"https://api.github.com/repos/joyent/smartos-live/contents/{+path}","compare_url":"https://api.github.com/repos/joyent/smartos-live/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joyent/smartos-live/merges","archive_url":"https://api.github.com/repos/joyent/smartos-live/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joyent/smartos-live/downloads","issues_url":"https://api.github.com/repos/joyent/smartos-live/issues{/number}","pulls_url":"https://api.github.com/repos/joyent/smartos-live/pulls{/number}","milestones_url":"https://api.github.com/repos/joyent/smartos-live/milestones{/number}","notifications_url":"https://api.github.com/repos/joyent/smartos-live/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joyent/smartos-live/labels{/name}","releases_url":"https://api.github.com/repos/joyent/smartos-live/releases{/id}","deployments_url":"https://api.github.com/repos/joyent/smartos-live/deployments","created_at":"2011-08-14T01:08:28Z","updated_at":"2016-06-03T16:13:39Z","pushed_at":"2016-06-03T23:26:54Z","git_url":"git://github.com/joyent/smartos-live.git","ssh_url":"git@github.com:joyent/smartos-live.git","clone_url":"https://github.com/joyent/smartos-live.git","svn_url":"https://github.com/joyent/smartos-live","homepage":"","size":39072,"stargazers_count":1039,"watchers_count":1039,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"open_issues_count":266,"forks":165,"open_issues":266,"watchers":1039,"default_branch":"master"}},"base":{"label":"joyent:master","ref":"master","sha":"b159661b621136d59b6b4d19330b2450e989b145","user":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=3","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"repo":{"id":2203782,"name":"smartos-live","full_name":"joyent/smartos-live","owner":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=3","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joyent/smartos-live","description":"For more information, please see http://smartos.org/  For any questions that aren't answered there, please join the SmartOS discussion list: http://smartos.org/smartos-mailing-list/","fork":false,"url":"https://api.github.com/repos/joyent/smartos-live","forks_url":"https://api.github.com/repos/joyent/smartos-live/forks","keys_url":"https://api.github.com/repos/joyent/smartos-live/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joyent/smartos-live/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joyent/smartos-live/teams","hooks_url":"https://api.github.com/repos/joyent/smartos-live/hooks","issue_events_url":"https://api.github.com/repos/joyent/smartos-live/issues/events{/number}","events_url":"https://api.github.com/repos/joyent/smartos-live/events","assignees_url":"https://api.github.com/repos/joyent/smartos-live/assignees{/user}","branches_url":"https://api.github.com/repos/joyent/smartos-live/branches{/branch}","tags_url":"https://api.github.com/repos/joyent/smartos-live/tags","blobs_url":"https://api.github.com/repos/joyent/smartos-live/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joyent/smartos-live/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joyent/smartos-live/git/refs{/sha}","trees_url":"https://api.github.com/repos/joyent/smartos-live/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joyent/smartos-live/statuses/{sha}","languages_url":"https://api.github.com/repos/joyent/smartos-live/languages","stargazers_url":"https://api.github.com/repos/joyent/smartos-live/stargazers","contributors_url":"https://api.github.com/repos/joyent/smartos-live/contributors","subscribers_url":"https://api.github.com/repos/joyent/smartos-live/subscribers","subscription_url":"https://api.github.com/repos/joyent/smartos-live/subscription","commits_url":"https://api.github.com/repos/joyent/smartos-live/commits{/sha}","git_commits_url":"https://api.github.com/repos/joyent/smartos-live/git/commits{/sha}","comments_url":"https://api.github.com/repos/joyent/smartos-live/comments{/number}","issue_comment_url":"https://api.github.com/repos/joyent/smartos-live/issues/comments{/number}","contents_url":"https://api.github.com/repos/joyent/smartos-live/contents/{+path}","compare_url":"https://api.github.com/repos/joyent/smartos-live/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joyent/smartos-live/merges","archive_url":"https://api.github.com/repos/joyent/smartos-live/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joyent/smartos-live/downloads","issues_url":"https://api.github.com/repos/joyent/smartos-live/issues{/number}","pulls_url":"https://api.github.com/repos/joyent/smartos-live/pulls{/number}","milestones_url":"https://api.github.com/repos/joyent/smartos-live/milestones{/number}","notifications_url":"https://api.github.com/repos/joyent/smartos-live/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joyent/smartos-live/labels{/name}","releases_url":"https://api.github.com/repos/joyent/smartos-live/releases{/id}","deployments_url":"https://api.github.com/repos/joyent/smartos-live/deployments","created_at":"2011-08-14T01:08:28Z","updated_at":"2016-06-03T16:13:39Z","pushed_at":"2016-06-03T23:26:54Z","git_url":"git://github.com/joyent/smartos-live.git","ssh_url":"git@github.com:joyent/smartos-live.git","clone_url":"https://github.com/joyent/smartos-live.git","svn_url":"https://github.com/joyent/smartos-live","homepage":"","size":39072,"stargazers_count":1039,"watchers_count":1039,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"open_issues_count":266,"forks":165,"open_issues":266,"watchers":1039,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joyent/smartos-live/pulls/636"},"html":{"href":"https://github.com/joyent/smartos-live/pull/636"},"issue":{"href":"https://api.github.com/repos/joyent/smartos-live/issues/636"},"comments":{"href":"https://api.github.com/repos/joyent/smartos-live/issues/636/comments"},"review_comments":{"href":"https://api.github.com/repos/joyent/smartos-live/pulls/636/comments"},"review_comment":{"href":"https://api.github.com/repos/joyent/smartos-live/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joyent/smartos-live/pulls/636/commits"},"statuses":{"href":"https://api.github.com/repos/joyent/smartos-live/statuses/afd4e72e17924fd596d8a5db498d6e5f6dda3365"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":412,"deletions":129,"changed_files":3}}
{"actor":{"display_login":"joshwilsdon"}}