{"action":"opened","number":6,"pull_request":{"url":"https://api.github.com/repos/DynamoDS/GReg/pulls/6","id":62031351,"html_url":"https://github.com/DynamoDS/GReg/pull/6","diff_url":"https://github.com/DynamoDS/GReg/pull/6.diff","patch_url":"https://github.com/DynamoDS/GReg/pull/6.patch","issue_url":"https://api.github.com/repos/DynamoDS/GReg/issues/6","number":6,"state":"open","locked":false,"title":"Callback inside upload callback.","user":{"login":"ikeough","id":1139788,"avatar_url":"https://avatars.githubusercontent.com/u/1139788?v=3","gravatar_id":"","url":"https://api.github.com/users/ikeough","html_url":"https://github.com/ikeough","followers_url":"https://api.github.com/users/ikeough/followers","following_url":"https://api.github.com/users/ikeough/following{/other_user}","gists_url":"https://api.github.com/users/ikeough/gists{/gist_id}","starred_url":"https://api.github.com/users/ikeough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikeough/subscriptions","organizations_url":"https://api.github.com/users/ikeough/orgs","repos_url":"https://api.github.com/users/ikeough/repos","events_url":"https://api.github.com/users/ikeough/events{/privacy}","received_events_url":"https://api.github.com/users/ikeough/received_events","type":"User","site_admin":false},"body":"This PR fixes an issue with the package manager where the URL of an uploaded package was not being set. This was due to the outer callback from the waterfall being called before the upload method could complete, setting the url. In this PR, we extend the upload methods to take a callback, in which we call the outer callback. This ensures that the url is set for the package.\r\n\r\nFYI @pboyer ","created_at":"2016-03-08T06:42:53Z","updated_at":"2016-03-08T06:42:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/GReg/pulls/6/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/GReg/pulls/6/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/GReg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoDS/GReg/issues/6/comments","statuses_url":"https://api.github.com/repos/DynamoDS/GReg/statuses/14fafbf03e57349d8f16c65b881f24e6c63934c0","head":{"label":"ikeough:master","ref":"master","sha":"14fafbf03e57349d8f16c65b881f24e6c63934c0","user":{"login":"ikeough","id":1139788,"avatar_url":"https://avatars.githubusercontent.com/u/1139788?v=3","gravatar_id":"","url":"https://api.github.com/users/ikeough","html_url":"https://github.com/ikeough","followers_url":"https://api.github.com/users/ikeough/followers","following_url":"https://api.github.com/users/ikeough/following{/other_user}","gists_url":"https://api.github.com/users/ikeough/gists{/gist_id}","starred_url":"https://api.github.com/users/ikeough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikeough/subscriptions","organizations_url":"https://api.github.com/users/ikeough/orgs","repos_url":"https://api.github.com/users/ikeough/repos","events_url":"https://api.github.com/users/ikeough/events{/privacy}","received_events_url":"https://api.github.com/users/ikeough/received_events","type":"User","site_admin":false},"repo":{"id":50871626,"name":"GReg","full_name":"ikeough/GReg","owner":{"login":"ikeough","id":1139788,"avatar_url":"https://avatars.githubusercontent.com/u/1139788?v=3","gravatar_id":"","url":"https://api.github.com/users/ikeough","html_url":"https://github.com/ikeough","followers_url":"https://api.github.com/users/ikeough/followers","following_url":"https://api.github.com/users/ikeough/following{/other_user}","gists_url":"https://api.github.com/users/ikeough/gists{/gist_id}","starred_url":"https://api.github.com/users/ikeough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikeough/subscriptions","organizations_url":"https://api.github.com/users/ikeough/orgs","repos_url":"https://api.github.com/users/ikeough/repos","events_url":"https://api.github.com/users/ikeough/events{/privacy}","received_events_url":"https://api.github.com/users/ikeough/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ikeough/GReg","description":"Package Manager Server for Dynamo","fork":true,"url":"https://api.github.com/repos/ikeough/GReg","forks_url":"https://api.github.com/repos/ikeough/GReg/forks","keys_url":"https://api.github.com/repos/ikeough/GReg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ikeough/GReg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ikeough/GReg/teams","hooks_url":"https://api.github.com/repos/ikeough/GReg/hooks","issue_events_url":"https://api.github.com/repos/ikeough/GReg/issues/events{/number}","events_url":"https://api.github.com/repos/ikeough/GReg/events","assignees_url":"https://api.github.com/repos/ikeough/GReg/assignees{/user}","branches_url":"https://api.github.com/repos/ikeough/GReg/branches{/branch}","tags_url":"https://api.github.com/repos/ikeough/GReg/tags","blobs_url":"https://api.github.com/repos/ikeough/GReg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ikeough/GReg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ikeough/GReg/git/refs{/sha}","trees_url":"https://api.github.com/repos/ikeough/GReg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ikeough/GReg/statuses/{sha}","languages_url":"https://api.github.com/repos/ikeough/GReg/languages","stargazers_url":"https://api.github.com/repos/ikeough/GReg/stargazers","contributors_url":"https://api.github.com/repos/ikeough/GReg/contributors","subscribers_url":"https://api.github.com/repos/ikeough/GReg/subscribers","subscription_url":"https://api.github.com/repos/ikeough/GReg/subscription","commits_url":"https://api.github.com/repos/ikeough/GReg/commits{/sha}","git_commits_url":"https://api.github.com/repos/ikeough/GReg/git/commits{/sha}","comments_url":"https://api.github.com/repos/ikeough/GReg/comments{/number}","issue_comment_url":"https://api.github.com/repos/ikeough/GReg/issues/comments{/number}","contents_url":"https://api.github.com/repos/ikeough/GReg/contents/{+path}","compare_url":"https://api.github.com/repos/ikeough/GReg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ikeough/GReg/merges","archive_url":"https://api.github.com/repos/ikeough/GReg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ikeough/GReg/downloads","issues_url":"https://api.github.com/repos/ikeough/GReg/issues{/number}","pulls_url":"https://api.github.com/repos/ikeough/GReg/pulls{/number}","milestones_url":"https://api.github.com/repos/ikeough/GReg/milestones{/number}","notifications_url":"https://api.github.com/repos/ikeough/GReg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ikeough/GReg/labels{/name}","releases_url":"https://api.github.com/repos/ikeough/GReg/releases{/id}","deployments_url":"https://api.github.com/repos/ikeough/GReg/deployments","created_at":"2016-02-01T21:12:58Z","updated_at":"2016-02-01T21:12:59Z","pushed_at":"2016-03-08T06:39:50Z","git_url":"git://github.com/ikeough/GReg.git","ssh_url":"git@github.com:ikeough/GReg.git","clone_url":"https://github.com/ikeough/GReg.git","svn_url":"https://github.com/ikeough/GReg","homepage":"https://dynamopackages.com","size":751,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DynamoDS:master","ref":"master","sha":"2d7f6ec7e5cac308c7954baae6a1b6e2ed33a8f1","user":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":12445350,"name":"GReg","full_name":"DynamoDS/GReg","owner":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoDS/GReg","description":"Package Manager Server for Dynamo","fork":false,"url":"https://api.github.com/repos/DynamoDS/GReg","forks_url":"https://api.github.com/repos/DynamoDS/GReg/forks","keys_url":"https://api.github.com/repos/DynamoDS/GReg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/GReg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/GReg/teams","hooks_url":"https://api.github.com/repos/DynamoDS/GReg/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/GReg/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/GReg/events","assignees_url":"https://api.github.com/repos/DynamoDS/GReg/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/GReg/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/GReg/tags","blobs_url":"https://api.github.com/repos/DynamoDS/GReg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/GReg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/GReg/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/GReg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/GReg/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/GReg/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/GReg/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/GReg/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/GReg/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/GReg/subscription","commits_url":"https://api.github.com/repos/DynamoDS/GReg/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/GReg/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/GReg/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/GReg/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/GReg/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/GReg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/GReg/merges","archive_url":"https://api.github.com/repos/DynamoDS/GReg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/GReg/downloads","issues_url":"https://api.github.com/repos/DynamoDS/GReg/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/GReg/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/GReg/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/GReg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/GReg/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/GReg/releases{/id}","deployments_url":"https://api.github.com/repos/DynamoDS/GReg/deployments","created_at":"2013-08-28T21:44:53Z","updated_at":"2016-03-07T17:40:40Z","pushed_at":"2016-03-08T06:42:53Z","git_url":"git://github.com/DynamoDS/GReg.git","ssh_url":"git@github.com:DynamoDS/GReg.git","clone_url":"https://github.com/DynamoDS/GReg.git","svn_url":"https://github.com/DynamoDS/GReg","homepage":"https://dynamopackages.com","size":748,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/GReg/pulls/6"},"html":{"href":"https://github.com/DynamoDS/GReg/pull/6"},"issue":{"href":"https://api.github.com/repos/DynamoDS/GReg/issues/6"},"comments":{"href":"https://api.github.com/repos/DynamoDS/GReg/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/GReg/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/GReg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/GReg/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/GReg/statuses/14fafbf03e57349d8f16c65b881f24e6c63934c0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":7,"changed_files":2}}