{"action":"closed","issue":{"url":"https://api.github.com/repos/videojs/videojs-contrib-ads/issues/126","repository_url":"https://api.github.com/repos/videojs/videojs-contrib-ads","labels_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/issues/126/labels{/name}","comments_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/issues/126/comments","events_url":"https://api.github.com/repos/videojs/videojs-contrib-ads/issues/126/events","html_url":"https://github.com/videojs/videojs-contrib-ads/issues/126","id":113559993,"number":126,"title":"Videojs events still propagated when the minified version of Videojs is used","user":{"login":"gabrieli","id":2760516,"avatar_url":"https://avatars.githubusercontent.com/u/2760516?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrieli","html_url":"https://github.com/gabrieli","followers_url":"https://api.github.com/users/gabrieli/followers","following_url":"https://api.github.com/users/gabrieli/following{/other_user}","gists_url":"https://api.github.com/users/gabrieli/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrieli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrieli/subscriptions","organizations_url":"https://api.github.com/users/gabrieli/orgs","repos_url":"https://api.github.com/users/gabrieli/repos","events_url":"https://api.github.com/users/gabrieli/events{/privacy}","received_events_url":"https://api.github.com/users/gabrieli/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2015-10-27T11:14:37Z","updated_at":"2016-11-14T22:06:11Z","closed_at":"2016-11-14T22:06:11Z","body":"Based on the event propagation changes you've made starting with 2.0.0, I understand that it's expected for usual player evens to not be propagated during ad play. For example, on an ad end, the plugin would send only the 'adended' event.\n\nWhen using the cdn version of videojs - http://vjs.zencdn.net/4.12.14/video.js - I see that on ad end, both 'adended' and 'ended' events are sent. \nWeirdly enough, when using the dev version of Videojs, built locally, the player behaves as expected and only sends 'adended' on ad end. \n"}}
{"actor":{"display_login":"incompl"}}