{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/88556532","pull_request_review_id":9128052,"id":88556532,"diff_hunk":"@@ -32,6 +32,8 @@ export const urls = {\n   thirdPartyFrameHost: env['thirdPartyFrameHost'] || 'ampproject.net',\n   thirdPartyFrameRegex: thirdPartyFrameRegex || /^d-\\d+\\.ampproject\\.net$/,\n   cdn: env['cdnUrl'] || 'https://cdn.ampproject.org',\n+  cdnProxyRegex: /^https:\\/\\/([a-zA-Z0-9_-]+\\.)?cdn\\.ampproject\\.org/,\n+  localhostProxyRegex: /^https?:\\/\\/localhost:[0-9]+\\/(c|v)\\//,","path":"src/config.js","position":5,"original_position":5,"commit_id":"44077c9943d17f89d50af3edef365e0069bb2bc8","original_commit_id":"44077c9943d17f89d50af3edef365e0069bb2bc8","user":{"login":"muxin","id":3897214,"avatar_url":"https://avatars.githubusercontent.com/u/3897214?v=3","gravatar_id":"","url":"https://api.github.com/users/muxin","html_url":"https://github.com/muxin","followers_url":"https://api.github.com/users/muxin/followers","following_url":"https://api.github.com/users/muxin/following{/other_user}","gists_url":"https://api.github.com/users/muxin/gists{/gist_id}","starred_url":"https://api.github.com/users/muxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muxin/subscriptions","organizations_url":"https://api.github.com/users/muxin/orgs","repos_url":"https://api.github.com/users/muxin/repos","events_url":"https://api.github.com/users/muxin/events{/privacy}","received_events_url":"https://api.github.com/users/muxin/received_events","type":"User","site_admin":false},"body":"What if the url is like `http://localhost.example.com`? I don't want to treat this as localhost","created_at":"2016-11-17T21:59:56Z","updated_at":"2016-11-17T21:59:56Z","html_url":"https://github.com/ampproject/amphtml/pull/5901#discussion_r88556532","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/5901","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/88556532"},"html":{"href":"https://github.com/ampproject/amphtml/pull/5901#discussion_r88556532"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/5901"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/5901","id":91473054,"html_url":"https://github.com/ampproject/amphtml/pull/5901","diff_url":"https://github.com/ampproject/amphtml/pull/5901.diff","patch_url":"https://github.com/ampproject/amphtml/pull/5901.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/5901","number":5901,"state":"open","locked":false,"title":"Allow *.cdn.ampproject.org as amp cache origin","user":{"login":"muxin","id":3897214,"avatar_url":"https://avatars.githubusercontent.com/u/3897214?v=3","gravatar_id":"","url":"https://api.github.com/users/muxin","html_url":"https://github.com/muxin","followers_url":"https://api.github.com/users/muxin/followers","following_url":"https://api.github.com/users/muxin/following{/other_user}","gists_url":"https://api.github.com/users/muxin/gists{/gist_id}","starred_url":"https://api.github.com/users/muxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muxin/subscriptions","organizations_url":"https://api.github.com/users/muxin/orgs","repos_url":"https://api.github.com/users/muxin/repos","events_url":"https://api.github.com/users/muxin/events{/privacy}","received_events_url":"https://api.github.com/users/muxin/received_events","type":"User","site_admin":false},"body":"Fixes #5754 \n","created_at":"2016-10-29T00:58:15Z","updated_at":"2016-11-17T21:59:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acbbba09b1e6127dde80e8720814ef140ee9c8b5","assignee":{"login":"cramforce","id":89679,"avatar_url":"https://avatars.githubusercontent.com/u/89679?v=3","gravatar_id":"","url":"https://api.github.com/users/cramforce","html_url":"https://github.com/cramforce","followers_url":"https://api.github.com/users/cramforce/followers","following_url":"https://api.github.com/users/cramforce/following{/other_user}","gists_url":"https://api.github.com/users/cramforce/gists{/gist_id}","starred_url":"https://api.github.com/users/cramforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramforce/subscriptions","organizations_url":"https://api.github.com/users/cramforce/orgs","repos_url":"https://api.github.com/users/cramforce/repos","events_url":"https://api.github.com/users/cramforce/events{/privacy}","received_events_url":"https://api.github.com/users/cramforce/received_events","type":"User","site_admin":false},"assignees":[{"login":"cramforce","id":89679,"avatar_url":"https://avatars.githubusercontent.com/u/89679?v=3","gravatar_id":"","url":"https://api.github.com/users/cramforce","html_url":"https://github.com/cramforce","followers_url":"https://api.github.com/users/cramforce/followers","following_url":"https://api.github.com/users/cramforce/following{/other_user}","gists_url":"https://api.github.com/users/cramforce/gists{/gist_id}","starred_url":"https://api.github.com/users/cramforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramforce/subscriptions","organizations_url":"https://api.github.com/users/cramforce/orgs","repos_url":"https://api.github.com/users/cramforce/repos","events_url":"https://api.github.com/users/cramforce/events{/privacy}","received_events_url":"https://api.github.com/users/cramforce/received_events","type":"User","site_admin":false},{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/5901/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/5901/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/5901/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/44077c9943d17f89d50af3edef365e0069bb2bc8","head":{"label":"muxin:cors-origin-change","ref":"cors-origin-change","sha":"44077c9943d17f89d50af3edef365e0069bb2bc8","user":{"login":"muxin","id":3897214,"avatar_url":"https://avatars.githubusercontent.com/u/3897214?v=3","gravatar_id":"","url":"https://api.github.com/users/muxin","html_url":"https://github.com/muxin","followers_url":"https://api.github.com/users/muxin/followers","following_url":"https://api.github.com/users/muxin/following{/other_user}","gists_url":"https://api.github.com/users/muxin/gists{/gist_id}","starred_url":"https://api.github.com/users/muxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muxin/subscriptions","organizations_url":"https://api.github.com/users/muxin/orgs","repos_url":"https://api.github.com/users/muxin/repos","events_url":"https://api.github.com/users/muxin/events{/privacy}","received_events_url":"https://api.github.com/users/muxin/received_events","type":"User","site_admin":false},"repo":{"id":58148082,"name":"amphtml","full_name":"muxin/amphtml","owner":{"login":"muxin","id":3897214,"avatar_url":"https://avatars.githubusercontent.com/u/3897214?v=3","gravatar_id":"","url":"https://api.github.com/users/muxin","html_url":"https://github.com/muxin","followers_url":"https://api.github.com/users/muxin/followers","following_url":"https://api.github.com/users/muxin/following{/other_user}","gists_url":"https://api.github.com/users/muxin/gists{/gist_id}","starred_url":"https://api.github.com/users/muxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muxin/subscriptions","organizations_url":"https://api.github.com/users/muxin/orgs","repos_url":"https://api.github.com/users/muxin/repos","events_url":"https://api.github.com/users/muxin/events{/privacy}","received_events_url":"https://api.github.com/users/muxin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muxin/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/muxin/amphtml","forks_url":"https://api.github.com/repos/muxin/amphtml/forks","keys_url":"https://api.github.com/repos/muxin/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muxin/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muxin/amphtml/teams","hooks_url":"https://api.github.com/repos/muxin/amphtml/hooks","issue_events_url":"https://api.github.com/repos/muxin/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/muxin/amphtml/events","assignees_url":"https://api.github.com/repos/muxin/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/muxin/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/muxin/amphtml/tags","blobs_url":"https://api.github.com/repos/muxin/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muxin/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muxin/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/muxin/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muxin/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/muxin/amphtml/languages","stargazers_url":"https://api.github.com/repos/muxin/amphtml/stargazers","contributors_url":"https://api.github.com/repos/muxin/amphtml/contributors","subscribers_url":"https://api.github.com/repos/muxin/amphtml/subscribers","subscription_url":"https://api.github.com/repos/muxin/amphtml/subscription","commits_url":"https://api.github.com/repos/muxin/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/muxin/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/muxin/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/muxin/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/muxin/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/muxin/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muxin/amphtml/merges","archive_url":"https://api.github.com/repos/muxin/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muxin/amphtml/downloads","issues_url":"https://api.github.com/repos/muxin/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/muxin/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/muxin/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/muxin/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muxin/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/muxin/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/muxin/amphtml/deployments","created_at":"2016-05-05T17:18:38Z","updated_at":"2016-05-05T17:18:42Z","pushed_at":"2016-11-17T21:16:33Z","git_url":"git://github.com/muxin/amphtml.git","ssh_url":"git@github.com:muxin/amphtml.git","clone_url":"https://github.com/muxin/amphtml.git","svn_url":"https://github.com/muxin/amphtml","homepage":"https://ampproject.org","size":184902,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"f65b44e7d5544d0d15861553e1c24c4ef31a95d9","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2016-11-17T21:59:00Z","pushed_at":"2016-11-17T21:53:31Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":229442,"stargazers_count":9078,"watchers_count":9078,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1399,"mirror_url":null,"open_issues_count":992,"forks":1399,"open_issues":992,"watchers":9078,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/5901"},"html":{"href":"https://github.com/ampproject/amphtml/pull/5901"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/5901"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/5901/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/5901/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/5901/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/44077c9943d17f89d50af3edef365e0069bb2bc8"}}}}
{"actor":{"display_login":"muxin"}}