{"action":"closed","issue":{"url":"https://api.github.com/repos/RoundingWellOS/marionette.toolkit/issues/182","repository_url":"https://api.github.com/repos/RoundingWellOS/marionette.toolkit","labels_url":"https://api.github.com/repos/RoundingWellOS/marionette.toolkit/issues/182/labels{/name}","comments_url":"https://api.github.com/repos/RoundingWellOS/marionette.toolkit/issues/182/comments","events_url":"https://api.github.com/repos/RoundingWellOS/marionette.toolkit/issues/182/events","html_url":"https://github.com/RoundingWellOS/marionette.toolkit/issues/182","id":182447459,"number":182,"title":"Support accepting a region instance on start","user":{"login":"paulfalgout","id":2028470,"avatar_url":"https://avatars.githubusercontent.com/u/2028470?v=3","gravatar_id":"","url":"https://api.github.com/users/paulfalgout","html_url":"https://github.com/paulfalgout","followers_url":"https://api.github.com/users/paulfalgout/followers","following_url":"https://api.github.com/users/paulfalgout/following{/other_user}","gists_url":"https://api.github.com/users/paulfalgout/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfalgout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfalgout/subscriptions","organizations_url":"https://api.github.com/users/paulfalgout/orgs","repos_url":"https://api.github.com/users/paulfalgout/repos","events_url":"https://api.github.com/users/paulfalgout/events{/privacy}","received_events_url":"https://api.github.com/users/paulfalgout/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"paulfalgout","id":2028470,"avatar_url":"https://avatars.githubusercontent.com/u/2028470?v=3","gravatar_id":"","url":"https://api.github.com/users/paulfalgout","html_url":"https://github.com/paulfalgout","followers_url":"https://api.github.com/users/paulfalgout/followers","following_url":"https://api.github.com/users/paulfalgout/following{/other_user}","gists_url":"https://api.github.com/users/paulfalgout/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfalgout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfalgout/subscriptions","organizations_url":"https://api.github.com/users/paulfalgout/orgs","repos_url":"https://api.github.com/users/paulfalgout/repos","events_url":"https://api.github.com/users/paulfalgout/events{/privacy}","received_events_url":"https://api.github.com/users/paulfalgout/received_events","type":"User","site_admin":false},"assignees":[{"login":"paulfalgout","id":2028470,"avatar_url":"https://avatars.githubusercontent.com/u/2028470?v=3","gravatar_id":"","url":"https://api.github.com/users/paulfalgout","html_url":"https://github.com/paulfalgout","followers_url":"https://api.github.com/users/paulfalgout/followers","following_url":"https://api.github.com/users/paulfalgout/following{/other_user}","gists_url":"https://api.github.com/users/paulfalgout/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfalgout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfalgout/subscriptions","organizations_url":"https://api.github.com/users/paulfalgout/orgs","repos_url":"https://api.github.com/users/paulfalgout/repos","events_url":"https://api.github.com/users/paulfalgout/events{/privacy}","received_events_url":"https://api.github.com/users/paulfalgout/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2016-10-12T06:42:35Z","updated_at":"2016-10-18T06:54:38Z","closed_at":"2016-10-18T06:54:38Z","body":"Application will by default take a region selector as Marionette does, but we should allow for a region instance to be passed to the application that would just replace `_region` I think we should avoid allowing region selectors to be passed at start as regions belonging to views are far better than various top-level DOM queries.\r\n\r\nie:\r\n```js\r\n// not ideal for child apps\r\nmyChildApp.start({ region: '.some-region-class' });\r\n```\r\n\r\n```js\r\n// much better\r\nconst MyView = Mn.View.extend({\r\n  regions: {\r\n    someRegion: '.some-region-class'\r\n  }\r\n});\r\n// ...\r\n\r\nmyChildApp.start({ region: myView.getRegion('someRegion') });\r\n```\r\n\r\nAlso this should be the exception that breaks the rule.. the region instance API should be available in `onBeforeStart`\r\n"}}
{"actor":{"display_login":"paulfalgout"}}