{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaStats/NullableArrays.jl/issues/104","repository_url":"https://api.github.com/repos/JuliaStats/NullableArrays.jl","labels_url":"https://api.github.com/repos/JuliaStats/NullableArrays.jl/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/JuliaStats/NullableArrays.jl/issues/104/comments","events_url":"https://api.github.com/repos/JuliaStats/NullableArrays.jl/issues/104/events","html_url":"https://github.com/JuliaStats/NullableArrays.jl/pull/104","id":152030534,"number":104,"title":"Update show methods to Julia 0.5","user":{"login":"nalimilan","id":1120448,"avatar_url":"https://avatars.githubusercontent.com/u/1120448?v=3","gravatar_id":"","url":"https://api.github.com/users/nalimilan","html_url":"https://github.com/nalimilan","followers_url":"https://api.github.com/users/nalimilan/followers","following_url":"https://api.github.com/users/nalimilan/following{/other_user}","gists_url":"https://api.github.com/users/nalimilan/gists{/gist_id}","starred_url":"https://api.github.com/users/nalimilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalimilan/subscriptions","organizations_url":"https://api.github.com/users/nalimilan/orgs","repos_url":"https://api.github.com/users/nalimilan/repos","events_url":"https://api.github.com/users/nalimilan/events{/privacy}","received_events_url":"https://api.github.com/users/nalimilan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-30T13:34:01Z","updated_at":"2016-05-04T17:09:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JuliaStats/NullableArrays.jl/pulls/104","html_url":"https://github.com/JuliaStats/NullableArrays.jl/pull/104","diff_url":"https://github.com/JuliaStats/NullableArrays.jl/pull/104.diff","patch_url":"https://github.com/JuliaStats/NullableArrays.jl/pull/104.patch"},"body":"Since JuliaLang/julia#15928, Nullable() is printed as #NULL, which\r\nmeans we no longer need to override show methods from Base.\r\nThis fixes breakage in current Julia 0.5.\r\nAlso fix a bug in show(), where NullableArray{T,N} was printed as the\r\nelement type prefix: add parentheses to make it clear this is the type\r\nof the container.\r\n\r\nFixes https://github.com/JuliaStats/NullableArrays.jl/issues/103. The diff is messy, but all I did is move the bottom of the file under the `else`, and add `show()` for 0.5. This means the day we'll drop support for 0.4, the file will be almost empty. Though since the printing code is being refactored in Base, we may well have to adjust this again; at some point, when things will have stabilized, we should try to rely only on public APIs, or copy `show_delim_array` (which is the only private function we use now).\r\n\r\nThere's a small regression/difference as regards the alignment of `#NULL`: it was previously aligned on the right, and it's now on the left. If that's considered a bad thing, we should make a simple PR against Base to add `alignment(::Nullable)`."},"comment":{"url":"https://api.github.com/repos/JuliaStats/NullableArrays.jl/issues/comments/216934684","html_url":"https://github.com/JuliaStats/NullableArrays.jl/pull/104#issuecomment-216934684","issue_url":"https://api.github.com/repos/JuliaStats/NullableArrays.jl/issues/104","id":216934684,"user":{"login":"davidagold","id":11862683,"avatar_url":"https://avatars.githubusercontent.com/u/11862683?v=3","gravatar_id":"","url":"https://api.github.com/users/davidagold","html_url":"https://github.com/davidagold","followers_url":"https://api.github.com/users/davidagold/followers","following_url":"https://api.github.com/users/davidagold/following{/other_user}","gists_url":"https://api.github.com/users/davidagold/gists{/gist_id}","starred_url":"https://api.github.com/users/davidagold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidagold/subscriptions","organizations_url":"https://api.github.com/users/davidagold/orgs","repos_url":"https://api.github.com/users/davidagold/repos","events_url":"https://api.github.com/users/davidagold/events{/privacy}","received_events_url":"https://api.github.com/users/davidagold/received_events","type":"User","site_admin":false},"created_at":"2016-05-04T17:09:51Z","updated_at":"2016-05-04T17:09:51Z","body":"Awesome. Thank you very much for this. We probably should file that PR against Base to deal with alignment issues. I'll see about that. "}}