{"action":"closed","number":4111,"pull_request":{"url":"https://api.github.com/repos/emberjs/data/pulls/4111","id":56838450,"html_url":"https://github.com/emberjs/data/pull/4111","diff_url":"https://github.com/emberjs/data/pull/4111.diff","patch_url":"https://github.com/emberjs/data/pull/4111.patch","issue_url":"https://api.github.com/repos/emberjs/data/issues/4111","number":4111,"state":"closed","locked":false,"title":"[BUGFIX beta] Add ducktyping of `AdapterError`","user":{"login":"danmcclain","id":144138,"avatar_url":"https://avatars.githubusercontent.com/u/144138?v=3","gravatar_id":"","url":"https://api.github.com/users/danmcclain","html_url":"https://github.com/danmcclain","followers_url":"https://api.github.com/users/danmcclain/followers","following_url":"https://api.github.com/users/danmcclain/following{/other_user}","gists_url":"https://api.github.com/users/danmcclain/gists{/gist_id}","starred_url":"https://api.github.com/users/danmcclain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmcclain/subscriptions","organizations_url":"https://api.github.com/users/danmcclain/orgs","repos_url":"https://api.github.com/users/danmcclain/repos","events_url":"https://api.github.com/users/danmcclain/events{/privacy}","received_events_url":"https://api.github.com/users/danmcclain/received_events","type":"User","site_admin":false},"body":"There are `instanceof` checks for `AdapterError`; this removes it in favor of checking for a property on the error. `isAdapterError` appears on all errors that use `AdapterError` as the base.\r\n\r\n\r\nThis PR is looking to avoid the need to import private errors in fastboot to keep the same code flow in the ajax method used in node land, related PR: https://github.com/tildeio/ember-cli-fastboot/pull/95","created_at":"2016-01-22T02:14:59Z","updated_at":"2016-01-27T19:18:41Z","closed_at":"2016-01-27T19:18:41Z","merged_at":"2016-01-27T19:18:41Z","merge_commit_sha":"1be186449491f3ad46af48df841b0597531b7bc1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/data/pulls/4111/commits","review_comments_url":"https://api.github.com/repos/emberjs/data/pulls/4111/comments","review_comment_url":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/data/issues/4111/comments","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/ee7bc80104df6a41f80c877a7ec0dd7a46d0b488","head":{"label":"danmcclain:ducktype-error-checking","ref":"ducktype-error-checking","sha":"ee7bc80104df6a41f80c877a7ec0dd7a46d0b488","user":{"login":"danmcclain","id":144138,"avatar_url":"https://avatars.githubusercontent.com/u/144138?v=3","gravatar_id":"","url":"https://api.github.com/users/danmcclain","html_url":"https://github.com/danmcclain","followers_url":"https://api.github.com/users/danmcclain/followers","following_url":"https://api.github.com/users/danmcclain/following{/other_user}","gists_url":"https://api.github.com/users/danmcclain/gists{/gist_id}","starred_url":"https://api.github.com/users/danmcclain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmcclain/subscriptions","organizations_url":"https://api.github.com/users/danmcclain/orgs","repos_url":"https://api.github.com/users/danmcclain/repos","events_url":"https://api.github.com/users/danmcclain/events{/privacy}","received_events_url":"https://api.github.com/users/danmcclain/received_events","type":"User","site_admin":false},"repo":{"id":17887909,"name":"data","full_name":"danmcclain/data","owner":{"login":"danmcclain","id":144138,"avatar_url":"https://avatars.githubusercontent.com/u/144138?v=3","gravatar_id":"","url":"https://api.github.com/users/danmcclain","html_url":"https://github.com/danmcclain","followers_url":"https://api.github.com/users/danmcclain/followers","following_url":"https://api.github.com/users/danmcclain/following{/other_user}","gists_url":"https://api.github.com/users/danmcclain/gists{/gist_id}","starred_url":"https://api.github.com/users/danmcclain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmcclain/subscriptions","organizations_url":"https://api.github.com/users/danmcclain/orgs","repos_url":"https://api.github.com/users/danmcclain/repos","events_url":"https://api.github.com/users/danmcclain/events{/privacy}","received_events_url":"https://api.github.com/users/danmcclain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danmcclain/data","description":"A data persistence library for Ember.js.","fork":true,"url":"https://api.github.com/repos/danmcclain/data","forks_url":"https://api.github.com/repos/danmcclain/data/forks","keys_url":"https://api.github.com/repos/danmcclain/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danmcclain/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danmcclain/data/teams","hooks_url":"https://api.github.com/repos/danmcclain/data/hooks","issue_events_url":"https://api.github.com/repos/danmcclain/data/issues/events{/number}","events_url":"https://api.github.com/repos/danmcclain/data/events","assignees_url":"https://api.github.com/repos/danmcclain/data/assignees{/user}","branches_url":"https://api.github.com/repos/danmcclain/data/branches{/branch}","tags_url":"https://api.github.com/repos/danmcclain/data/tags","blobs_url":"https://api.github.com/repos/danmcclain/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danmcclain/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danmcclain/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/danmcclain/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danmcclain/data/statuses/{sha}","languages_url":"https://api.github.com/repos/danmcclain/data/languages","stargazers_url":"https://api.github.com/repos/danmcclain/data/stargazers","contributors_url":"https://api.github.com/repos/danmcclain/data/contributors","subscribers_url":"https://api.github.com/repos/danmcclain/data/subscribers","subscription_url":"https://api.github.com/repos/danmcclain/data/subscription","commits_url":"https://api.github.com/repos/danmcclain/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/danmcclain/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/danmcclain/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/danmcclain/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/danmcclain/data/contents/{+path}","compare_url":"https://api.github.com/repos/danmcclain/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danmcclain/data/merges","archive_url":"https://api.github.com/repos/danmcclain/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danmcclain/data/downloads","issues_url":"https://api.github.com/repos/danmcclain/data/issues{/number}","pulls_url":"https://api.github.com/repos/danmcclain/data/pulls{/number}","milestones_url":"https://api.github.com/repos/danmcclain/data/milestones{/number}","notifications_url":"https://api.github.com/repos/danmcclain/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danmcclain/data/labels{/name}","releases_url":"https://api.github.com/repos/danmcclain/data/releases{/id}","deployments_url":"https://api.github.com/repos/danmcclain/data/deployments","created_at":"2014-03-19T01:10:47Z","updated_at":"2016-01-14T12:16:43Z","pushed_at":"2016-01-27T18:37:36Z","git_url":"git://github.com/danmcclain/data.git","ssh_url":"git@github.com:danmcclain/data.git","clone_url":"https://github.com/danmcclain/data.git","svn_url":"https://github.com/danmcclain/data","homepage":"","size":10609,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"2322aacc3f3e4fb4fe9b30c7d790c45126fa5c73","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":3016562,"name":"data","full_name":"emberjs/data","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/data","description":"A data persistence library for Ember.js.","fork":false,"url":"https://api.github.com/repos/emberjs/data","forks_url":"https://api.github.com/repos/emberjs/data/forks","keys_url":"https://api.github.com/repos/emberjs/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/data/teams","hooks_url":"https://api.github.com/repos/emberjs/data/hooks","issue_events_url":"https://api.github.com/repos/emberjs/data/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/data/events","assignees_url":"https://api.github.com/repos/emberjs/data/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/data/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/data/tags","blobs_url":"https://api.github.com/repos/emberjs/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/data/languages","stargazers_url":"https://api.github.com/repos/emberjs/data/stargazers","contributors_url":"https://api.github.com/repos/emberjs/data/contributors","subscribers_url":"https://api.github.com/repos/emberjs/data/subscribers","subscription_url":"https://api.github.com/repos/emberjs/data/subscription","commits_url":"https://api.github.com/repos/emberjs/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/data/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/data/merges","archive_url":"https://api.github.com/repos/emberjs/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/data/downloads","issues_url":"https://api.github.com/repos/emberjs/data/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/data/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/data/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/data/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/data/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/data/deployments","created_at":"2011-12-20T01:50:40Z","updated_at":"2016-01-26T13:46:20Z","pushed_at":"2016-01-27T19:18:41Z","git_url":"git://github.com/emberjs/data.git","ssh_url":"git@github.com:emberjs/data.git","clone_url":"https://github.com/emberjs/data.git","svn_url":"https://github.com/emberjs/data","homepage":"","size":19094,"stargazers_count":2618,"watchers_count":2618,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1014,"mirror_url":null,"open_issues_count":186,"forks":1014,"open_issues":186,"watchers":2618,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/4111"},"html":{"href":"https://github.com/emberjs/data/pull/4111"},"issue":{"href":"https://api.github.com/repos/emberjs/data/issues/4111"},"comments":{"href":"https://api.github.com/repos/emberjs/data/issues/4111/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/data/pulls/4111/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/data/pulls/4111/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/data/statuses/ee7bc80104df6a41f80c877a7ec0dd7a46d0b488"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bmac","id":54056,"avatar_url":"https://avatars.githubusercontent.com/u/54056?v=3","gravatar_id":"","url":"https://api.github.com/users/bmac","html_url":"https://github.com/bmac","followers_url":"https://api.github.com/users/bmac/followers","following_url":"https://api.github.com/users/bmac/following{/other_user}","gists_url":"https://api.github.com/users/bmac/gists{/gist_id}","starred_url":"https://api.github.com/users/bmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmac/subscriptions","organizations_url":"https://api.github.com/users/bmac/orgs","repos_url":"https://api.github.com/users/bmac/repos","events_url":"https://api.github.com/users/bmac/events{/privacy}","received_events_url":"https://api.github.com/users/bmac/received_events","type":"User","site_admin":false},"comments":12,"review_comments":1,"commits":1,"additions":6,"deletions":1,"changed_files":3}}