{"action":"created","comment":{"url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/pulls/comments/87941053","pull_request_review_id":8530772,"id":87941053,"diff_hunk":"@@ -1,266 +1,258 @@\n pragma solidity ^0.4.4;\n \n-/*\n-*  Possible missing functions\n-* - integrity check? to perform check and make sure certain values are available and correct\n-*\n+/**\n+*  Things still missing/needs fixing:\n+*   in bid(), check if the ROSCA/rounds is started before allow bidding\n+*   in startRound() , check if minimumParticipants requirement is met (what happens if it doesn't? should we move the startTime?)\n+*   in withdraw() , add fee related logic\n+*   in startRound() , lowestBid should be contributionSize * amount of people in ROSCA\n+*   checkingContribution, check whether or not a member as contributed as least contributionSize at the end of Round\n+*   in withdraw() , check if opt_destination provided is valid address\n */\n-contract rosca {\n-    address constant WETRUST = 0x0;\n-\n-    enum Period { Weekly, Monthly } // are we only allwing 2 options?\n-\n-    event LogParticipantRegistered(address user);\n-    event LogContributionMade(address user, uint amount);\n-    event LogNewLowestBid(uint bid,address winnerAddress);\n-    event LogRoundFundsRelease(address winnerUniqName, uint amountInWei);\n-\n-\n-    //added\n-    event LogFundsWithdrawal(address user, uint amount,address destination);\n-    event LogStartOfPeriod(uint currentRound);\n-\n-    //state variables\n-    address foreman;\n-    uint roundSum;\n-    uint numRounds;\n-    uint currentEpoch;\n-    uint numEpochs;\n-    int8 minParticipants;\n-    uint roundPeriodInDays;\n-    uint startTime;\n-    int16 feeToService;\n-    address feeAddress;\n-    uint currentRound;  //currentRound will be set to 0 when ROSCA is created and will turn to one when the ROSCA actually start\n-\n-    /*\n-        not sure about which structures to use yet\n+contract ROSCA {\n+  address constant WETRUST = 0x0;\n+  uint constant MIN_CONTRIBUTION_SIZE = 1000000000000;\n+  uint constant MAX_FEE_IN_THOUSANDTH = 20;\n+\n+  event LogParticipantRegistered(address user);\n+  event LogContributionMade(address user, uint amount);\n+  event LogNewLowestBid(uint bid,address winnerAddress);\n+  event LogRoundFundsRelease(address winnerUniqName, uint amountInWei);\n+  event LogFundsWithdrawal(address user, uint amount,address destination);\n+  event LogStartOfPeriod(uint currentRound);\n+\n+  //state variables","path":"contracts/rosca.sol","position":37,"original_position":58,"commit_id":"b96cf0234f3c22a9af28c78ed703d3449fbea3e3","original_commit_id":"b96cf0234f3c22a9af28c78ed703d3449fbea3e3","user":{"login":"rmerom","id":650968,"avatar_url":"https://avatars.githubusercontent.com/u/650968?v=3","gravatar_id":"","url":"https://api.github.com/users/rmerom","html_url":"https://github.com/rmerom","followers_url":"https://api.github.com/users/rmerom/followers","following_url":"https://api.github.com/users/rmerom/following{/other_user}","gists_url":"https://api.github.com/users/rmerom/gists{/gist_id}","starred_url":"https://api.github.com/users/rmerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmerom/subscriptions","organizations_url":"https://api.github.com/users/rmerom/orgs","repos_url":"https://api.github.com/users/rmerom/repos","events_url":"https://api.github.com/users/rmerom/events{/privacy}","received_events_url":"https://api.github.com/users/rmerom/received_events","type":"User","site_admin":false},"body":"nitpick: space after // according to style guide (here and in other lines), e.g.\r\n// state variables","created_at":"2016-11-15T03:15:22Z","updated_at":"2016-11-15T03:15:22Z","html_url":"https://github.com/WeTrustPlatform/rosca-contracts/pull/2#discussion_r87941053","pull_request_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/pulls/comments/87941053"},"html":{"href":"https://github.com/WeTrustPlatform/rosca-contracts/pull/2#discussion_r87941053"},"pull_request":{"href":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/pulls/2","id":93676154,"html_url":"https://github.com/WeTrustPlatform/rosca-contracts/pull/2","diff_url":"https://github.com/WeTrustPlatform/rosca-contracts/pull/2.diff","patch_url":"https://github.com/WeTrustPlatform/rosca-contracts/pull/2.patch","issue_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/issues/2","number":2,"state":"open","locked":false,"title":"Implement rosca interface","user":{"login":"shine2lay","id":5243508,"avatar_url":"https://avatars.githubusercontent.com/u/5243508?v=3","gravatar_id":"","url":"https://api.github.com/users/shine2lay","html_url":"https://github.com/shine2lay","followers_url":"https://api.github.com/users/shine2lay/followers","following_url":"https://api.github.com/users/shine2lay/following{/other_user}","gists_url":"https://api.github.com/users/shine2lay/gists{/gist_id}","starred_url":"https://api.github.com/users/shine2lay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shine2lay/subscriptions","organizations_url":"https://api.github.com/users/shine2lay/orgs","repos_url":"https://api.github.com/users/shine2lay/repos","events_url":"https://api.github.com/users/shine2lay/events{/privacy}","received_events_url":"https://api.github.com/users/shine2lay/received_events","type":"User","site_admin":false},"body":"i did the changes you requested, let me know if i missed somethings","created_at":"2016-11-15T00:20:20Z","updated_at":"2016-11-15T03:15:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a308838a71420622e2211a48673a8918c5bcdb6b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/pulls/2/commits","review_comments_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/pulls/2/comments","review_comment_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/issues/2/comments","statuses_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/statuses/b96cf0234f3c22a9af28c78ed703d3449fbea3e3","head":{"label":"shine2lay:implement_rosca_interface","ref":"implement_rosca_interface","sha":"b96cf0234f3c22a9af28c78ed703d3449fbea3e3","user":{"login":"shine2lay","id":5243508,"avatar_url":"https://avatars.githubusercontent.com/u/5243508?v=3","gravatar_id":"","url":"https://api.github.com/users/shine2lay","html_url":"https://github.com/shine2lay","followers_url":"https://api.github.com/users/shine2lay/followers","following_url":"https://api.github.com/users/shine2lay/following{/other_user}","gists_url":"https://api.github.com/users/shine2lay/gists{/gist_id}","starred_url":"https://api.github.com/users/shine2lay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shine2lay/subscriptions","organizations_url":"https://api.github.com/users/shine2lay/orgs","repos_url":"https://api.github.com/users/shine2lay/repos","events_url":"https://api.github.com/users/shine2lay/events{/privacy}","received_events_url":"https://api.github.com/users/shine2lay/received_events","type":"User","site_admin":false},"repo":{"id":73576739,"name":"rosca-contracts","full_name":"shine2lay/rosca-contracts","owner":{"login":"shine2lay","id":5243508,"avatar_url":"https://avatars.githubusercontent.com/u/5243508?v=3","gravatar_id":"","url":"https://api.github.com/users/shine2lay","html_url":"https://github.com/shine2lay","followers_url":"https://api.github.com/users/shine2lay/followers","following_url":"https://api.github.com/users/shine2lay/following{/other_user}","gists_url":"https://api.github.com/users/shine2lay/gists{/gist_id}","starred_url":"https://api.github.com/users/shine2lay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shine2lay/subscriptions","organizations_url":"https://api.github.com/users/shine2lay/orgs","repos_url":"https://api.github.com/users/shine2lay/repos","events_url":"https://api.github.com/users/shine2lay/events{/privacy}","received_events_url":"https://api.github.com/users/shine2lay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shine2lay/rosca-contracts","description":"Ethereum Contracts for WeTrust ROSCA","fork":true,"url":"https://api.github.com/repos/shine2lay/rosca-contracts","forks_url":"https://api.github.com/repos/shine2lay/rosca-contracts/forks","keys_url":"https://api.github.com/repos/shine2lay/rosca-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shine2lay/rosca-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shine2lay/rosca-contracts/teams","hooks_url":"https://api.github.com/repos/shine2lay/rosca-contracts/hooks","issue_events_url":"https://api.github.com/repos/shine2lay/rosca-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/shine2lay/rosca-contracts/events","assignees_url":"https://api.github.com/repos/shine2lay/rosca-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/shine2lay/rosca-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/shine2lay/rosca-contracts/tags","blobs_url":"https://api.github.com/repos/shine2lay/rosca-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shine2lay/rosca-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shine2lay/rosca-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/shine2lay/rosca-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shine2lay/rosca-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/shine2lay/rosca-contracts/languages","stargazers_url":"https://api.github.com/repos/shine2lay/rosca-contracts/stargazers","contributors_url":"https://api.github.com/repos/shine2lay/rosca-contracts/contributors","subscribers_url":"https://api.github.com/repos/shine2lay/rosca-contracts/subscribers","subscription_url":"https://api.github.com/repos/shine2lay/rosca-contracts/subscription","commits_url":"https://api.github.com/repos/shine2lay/rosca-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/shine2lay/rosca-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/shine2lay/rosca-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/shine2lay/rosca-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/shine2lay/rosca-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/shine2lay/rosca-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shine2lay/rosca-contracts/merges","archive_url":"https://api.github.com/repos/shine2lay/rosca-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shine2lay/rosca-contracts/downloads","issues_url":"https://api.github.com/repos/shine2lay/rosca-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/shine2lay/rosca-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/shine2lay/rosca-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/shine2lay/rosca-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shine2lay/rosca-contracts/labels{/name}","releases_url":"https://api.github.com/repos/shine2lay/rosca-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/shine2lay/rosca-contracts/deployments","created_at":"2016-11-12T20:29:28Z","updated_at":"2016-11-12T20:29:30Z","pushed_at":"2016-11-15T00:18:25Z","git_url":"git://github.com/shine2lay/rosca-contracts.git","ssh_url":"git@github.com:shine2lay/rosca-contracts.git","clone_url":"https://github.com/shine2lay/rosca-contracts.git","svn_url":"https://github.com/shine2lay/rosca-contracts","homepage":null,"size":331,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WeTrustPlatform:develop","ref":"develop","sha":"64e273500985da4afe18f1df3469b6c445289593","user":{"login":"WeTrustPlatform","id":22733080,"avatar_url":"https://avatars.githubusercontent.com/u/22733080?v=3","gravatar_id":"","url":"https://api.github.com/users/WeTrustPlatform","html_url":"https://github.com/WeTrustPlatform","followers_url":"https://api.github.com/users/WeTrustPlatform/followers","following_url":"https://api.github.com/users/WeTrustPlatform/following{/other_user}","gists_url":"https://api.github.com/users/WeTrustPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/WeTrustPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WeTrustPlatform/subscriptions","organizations_url":"https://api.github.com/users/WeTrustPlatform/orgs","repos_url":"https://api.github.com/users/WeTrustPlatform/repos","events_url":"https://api.github.com/users/WeTrustPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/WeTrustPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":73515004,"name":"rosca-contracts","full_name":"WeTrustPlatform/rosca-contracts","owner":{"login":"WeTrustPlatform","id":22733080,"avatar_url":"https://avatars.githubusercontent.com/u/22733080?v=3","gravatar_id":"","url":"https://api.github.com/users/WeTrustPlatform","html_url":"https://github.com/WeTrustPlatform","followers_url":"https://api.github.com/users/WeTrustPlatform/followers","following_url":"https://api.github.com/users/WeTrustPlatform/following{/other_user}","gists_url":"https://api.github.com/users/WeTrustPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/WeTrustPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WeTrustPlatform/subscriptions","organizations_url":"https://api.github.com/users/WeTrustPlatform/orgs","repos_url":"https://api.github.com/users/WeTrustPlatform/repos","events_url":"https://api.github.com/users/WeTrustPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/WeTrustPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WeTrustPlatform/rosca-contracts","description":"Ethereum Contracts for WeTrust ROSCA","fork":false,"url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts","forks_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/forks","keys_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/teams","hooks_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/hooks","issue_events_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/events","assignees_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/tags","blobs_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/languages","stargazers_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/stargazers","contributors_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/contributors","subscribers_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/subscribers","subscription_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/subscription","commits_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/merges","archive_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/downloads","issues_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/labels{/name}","releases_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/deployments","created_at":"2016-11-11T22:05:15Z","updated_at":"2016-11-11T22:08:13Z","pushed_at":"2016-11-15T00:20:20Z","git_url":"git://github.com/WeTrustPlatform/rosca-contracts.git","ssh_url":"git@github.com:WeTrustPlatform/rosca-contracts.git","clone_url":"https://github.com/WeTrustPlatform/rosca-contracts.git","svn_url":"https://github.com/WeTrustPlatform/rosca-contracts","homepage":null,"size":328,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/pulls/2"},"html":{"href":"https://github.com/WeTrustPlatform/rosca-contracts/pull/2"},"issue":{"href":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/issues/2"},"comments":{"href":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/statuses/b96cf0234f3c22a9af28c78ed703d3449fbea3e3"}}}}
{"actor":{"display_login":"rmerom"}}