{"action":"created","comment":{"url":"https://api.github.com/repos/mono/mono/pulls/comments/78760821","id":78760821,"diff_hunk":"@@ -165,10 +167,11 @@ int\n mono_w32handle_unlock_handle (gpointer handle);\n \n typedef enum {\n-\tMONO_W32HANDLE_WAIT_RET_SUCCESS_0 =  0,\n-\tMONO_W32HANDLE_WAIT_RET_ALERTED   = -1,\n-\tMONO_W32HANDLE_WAIT_RET_TIMEOUT   = -2,\n-\tMONO_W32HANDLE_WAIT_RET_FAILED    = -3,\n+\tMONO_W32HANDLE_WAIT_RET_SUCCESS_0   =  0,\n+\tMONO_W32HANDLE_WAIT_RET_ABANDONED_0 =  0x80,","path":"mono/utils/w32handle.h","position":30,"original_position":30,"commit_id":"3219d11898c929ebd7e8f2cfc796fdf6c5507649","original_commit_id":"3219d11898c929ebd7e8f2cfc796fdf6c5507649","user":{"login":"ludovic-henry","id":660779,"avatar_url":"https://avatars.githubusercontent.com/u/660779?v=3","gravatar_id":"","url":"https://api.github.com/users/ludovic-henry","html_url":"https://github.com/ludovic-henry","followers_url":"https://api.github.com/users/ludovic-henry/followers","following_url":"https://api.github.com/users/ludovic-henry/following{/other_user}","gists_url":"https://api.github.com/users/ludovic-henry/gists{/gist_id}","starred_url":"https://api.github.com/users/ludovic-henry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludovic-henry/subscriptions","organizations_url":"https://api.github.com/users/ludovic-henry/orgs","repos_url":"https://api.github.com/users/ludovic-henry/repos","events_url":"https://api.github.com/users/ludovic-henry/events{/privacy}","received_events_url":"https://api.github.com/users/ludovic-henry/received_events","type":"User","site_admin":false},"body":"It should be `MONO_W32HANDLE_WAIT_RET_SUCCESS_0 + MONO_W32HANDLE_MAXIMUM_WAIT_OBJECTS`","created_at":"2016-09-14T14:34:49Z","updated_at":"2016-09-14T14:34:49Z","html_url":"https://github.com/mono/mono/pull/3545#discussion_r78760821","pull_request_url":"https://api.github.com/repos/mono/mono/pulls/3545","_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/comments/78760821"},"html":{"href":"https://github.com/mono/mono/pull/3545#discussion_r78760821"},"pull_request":{"href":"https://api.github.com/repos/mono/mono/pulls/3545"}}},"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/3545","id":84668398,"html_url":"https://github.com/mono/mono/pull/3545","diff_url":"https://github.com/mono/mono/pull/3545.diff","patch_url":"https://github.com/mono/mono/pull/3545.patch","issue_url":"https://api.github.com/repos/mono/mono/issues/3545","number":3545,"state":"open","locked":false,"title":"Correctly handle abandoned mutexes on non-Windows platforms","user":{"login":"ntherning","id":135765,"avatar_url":"https://avatars.githubusercontent.com/u/135765?v=3","gravatar_id":"","url":"https://api.github.com/users/ntherning","html_url":"https://github.com/ntherning","followers_url":"https://api.github.com/users/ntherning/followers","following_url":"https://api.github.com/users/ntherning/following{/other_user}","gists_url":"https://api.github.com/users/ntherning/gists{/gist_id}","starred_url":"https://api.github.com/users/ntherning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntherning/subscriptions","organizations_url":"https://api.github.com/users/ntherning/orgs","repos_url":"https://api.github.com/users/ntherning/repos","events_url":"https://api.github.com/users/ntherning/events{/privacy}","received_events_url":"https://api.github.com/users/ntherning/received_events","type":"User","site_admin":false},"body":"When a thread owning a mutex doesn't release it before it exits and a second thread tries to take it using e.g. Mutex.WaitOne() an AbandonedMutexException should be thrown. This is what .NET and Mono on Windows does.\r\n\r\nThis patch builds on the work done in PR #2267, which modifies the Win32 emulation of WaitForSingleObjectEx(), SignalObjectAndWait() and WaitForMultipleObjectsEx() to return WAIT_ABANDONED_0 when expected, and updates it to the current HEAD. It also adds a few test methods to WaitHandleTest that test that WaitHandle.WaitAny() and WaitHandle.WaitAll() follows the .NET behaviour.","created_at":"2016-09-09T15:16:24Z","updated_at":"2016-09-14T14:34:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94071c5f31482ed84c4af5e90198ddec9b819ae8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mono/mono/pulls/3545/commits","review_comments_url":"https://api.github.com/repos/mono/mono/pulls/3545/comments","review_comment_url":"https://api.github.com/repos/mono/mono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/mono/issues/3545/comments","statuses_url":"https://api.github.com/repos/mono/mono/statuses/3219d11898c929ebd7e8f2cfc796fdf6c5507649","head":{"label":"ntherning:throw-AbandonedMutexException-on-unix","ref":"throw-AbandonedMutexException-on-unix","sha":"3219d11898c929ebd7e8f2cfc796fdf6c5507649","user":{"login":"ntherning","id":135765,"avatar_url":"https://avatars.githubusercontent.com/u/135765?v=3","gravatar_id":"","url":"https://api.github.com/users/ntherning","html_url":"https://github.com/ntherning","followers_url":"https://api.github.com/users/ntherning/followers","following_url":"https://api.github.com/users/ntherning/following{/other_user}","gists_url":"https://api.github.com/users/ntherning/gists{/gist_id}","starred_url":"https://api.github.com/users/ntherning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntherning/subscriptions","organizations_url":"https://api.github.com/users/ntherning/orgs","repos_url":"https://api.github.com/users/ntherning/repos","events_url":"https://api.github.com/users/ntherning/events{/privacy}","received_events_url":"https://api.github.com/users/ntherning/received_events","type":"User","site_admin":false},"repo":{"id":53493195,"name":"mono","full_name":"ntherning/mono","owner":{"login":"ntherning","id":135765,"avatar_url":"https://avatars.githubusercontent.com/u/135765?v=3","gravatar_id":"","url":"https://api.github.com/users/ntherning","html_url":"https://github.com/ntherning","followers_url":"https://api.github.com/users/ntherning/followers","following_url":"https://api.github.com/users/ntherning/following{/other_user}","gists_url":"https://api.github.com/users/ntherning/gists{/gist_id}","starred_url":"https://api.github.com/users/ntherning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntherning/subscriptions","organizations_url":"https://api.github.com/users/ntherning/orgs","repos_url":"https://api.github.com/users/ntherning/repos","events_url":"https://api.github.com/users/ntherning/events{/privacy}","received_events_url":"https://api.github.com/users/ntherning/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ntherning/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":true,"url":"https://api.github.com/repos/ntherning/mono","forks_url":"https://api.github.com/repos/ntherning/mono/forks","keys_url":"https://api.github.com/repos/ntherning/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ntherning/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ntherning/mono/teams","hooks_url":"https://api.github.com/repos/ntherning/mono/hooks","issue_events_url":"https://api.github.com/repos/ntherning/mono/issues/events{/number}","events_url":"https://api.github.com/repos/ntherning/mono/events","assignees_url":"https://api.github.com/repos/ntherning/mono/assignees{/user}","branches_url":"https://api.github.com/repos/ntherning/mono/branches{/branch}","tags_url":"https://api.github.com/repos/ntherning/mono/tags","blobs_url":"https://api.github.com/repos/ntherning/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ntherning/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ntherning/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/ntherning/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ntherning/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/ntherning/mono/languages","stargazers_url":"https://api.github.com/repos/ntherning/mono/stargazers","contributors_url":"https://api.github.com/repos/ntherning/mono/contributors","subscribers_url":"https://api.github.com/repos/ntherning/mono/subscribers","subscription_url":"https://api.github.com/repos/ntherning/mono/subscription","commits_url":"https://api.github.com/repos/ntherning/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/ntherning/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/ntherning/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/ntherning/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/ntherning/mono/contents/{+path}","compare_url":"https://api.github.com/repos/ntherning/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ntherning/mono/merges","archive_url":"https://api.github.com/repos/ntherning/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ntherning/mono/downloads","issues_url":"https://api.github.com/repos/ntherning/mono/issues{/number}","pulls_url":"https://api.github.com/repos/ntherning/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/ntherning/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/ntherning/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ntherning/mono/labels{/name}","releases_url":"https://api.github.com/repos/ntherning/mono/releases{/id}","deployments_url":"https://api.github.com/repos/ntherning/mono/deployments","created_at":"2016-03-09T11:42:37Z","updated_at":"2016-03-09T11:43:56Z","pushed_at":"2016-09-14T13:50:03Z","git_url":"git://github.com/ntherning/mono.git","ssh_url":"git@github.com:ntherning/mono.git","clone_url":"https://github.com/ntherning/mono.git","svn_url":"https://github.com/ntherning/mono","homepage":"http://www.mono-project.com/","size":413866,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"8f7a1683c23d483b40aa965801f5a7998b9bfd3a","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791611,"name":"mono","full_name":"mono/mono","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":false,"url":"https://api.github.com/repos/mono/mono","forks_url":"https://api.github.com/repos/mono/mono/forks","keys_url":"https://api.github.com/repos/mono/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono/teams","hooks_url":"https://api.github.com/repos/mono/mono/hooks","issue_events_url":"https://api.github.com/repos/mono/mono/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono/events","assignees_url":"https://api.github.com/repos/mono/mono/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono/tags","blobs_url":"https://api.github.com/repos/mono/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono/languages","stargazers_url":"https://api.github.com/repos/mono/mono/stargazers","contributors_url":"https://api.github.com/repos/mono/mono/contributors","subscribers_url":"https://api.github.com/repos/mono/mono/subscribers","subscription_url":"https://api.github.com/repos/mono/mono/subscription","commits_url":"https://api.github.com/repos/mono/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono/merges","archive_url":"https://api.github.com/repos/mono/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono/downloads","issues_url":"https://api.github.com/repos/mono/mono/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono/releases{/id}","deployments_url":"https://api.github.com/repos/mono/mono/deployments","created_at":"2010-07-22T18:06:36Z","updated_at":"2016-09-14T11:20:44Z","pushed_at":"2016-09-14T13:50:04Z","git_url":"git://github.com/mono/mono.git","ssh_url":"git@github.com:mono/mono.git","clone_url":"https://github.com/mono/mono.git","svn_url":"https://github.com/mono/mono","homepage":"http://www.mono-project.com/","size":503303,"stargazers_count":4894,"watchers_count":4894,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2331,"mirror_url":null,"open_issues_count":135,"forks":2331,"open_issues":135,"watchers":4894,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/3545"},"html":{"href":"https://github.com/mono/mono/pull/3545"},"issue":{"href":"https://api.github.com/repos/mono/mono/issues/3545"},"comments":{"href":"https://api.github.com/repos/mono/mono/issues/3545/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/mono/pulls/3545/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/mono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/mono/pulls/3545/commits"},"statuses":{"href":"https://api.github.com/repos/mono/mono/statuses/3219d11898c929ebd7e8f2cfc796fdf6c5507649"}}}}
{"actor":{"display_login":"ludovic-henry"}}