{"action":"created","issue":{"url":"https://api.github.com/repos/oscarotero/Embed/issues/138","repository_url":"https://api.github.com/repos/oscarotero/Embed","labels_url":"https://api.github.com/repos/oscarotero/Embed/issues/138/labels{/name}","comments_url":"https://api.github.com/repos/oscarotero/Embed/issues/138/comments","events_url":"https://api.github.com/repos/oscarotero/Embed/issues/138/events","html_url":"https://github.com/oscarotero/Embed/pull/138","id":151554606,"number":138,"title":"More complete support of URL parsing","user":{"login":"dman-coders","id":1018669,"avatar_url":"https://avatars.githubusercontent.com/u/1018669?v=3","gravatar_id":"","url":"https://api.github.com/users/dman-coders","html_url":"https://github.com/dman-coders","followers_url":"https://api.github.com/users/dman-coders/followers","following_url":"https://api.github.com/users/dman-coders/following{/other_user}","gists_url":"https://api.github.com/users/dman-coders/gists{/gist_id}","starred_url":"https://api.github.com/users/dman-coders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dman-coders/subscriptions","organizations_url":"https://api.github.com/users/dman-coders/orgs","repos_url":"https://api.github.com/users/dman-coders/repos","events_url":"https://api.github.com/users/dman-coders/events{/privacy}","received_events_url":"https://api.github.com/users/dman-coders/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-28T05:47:32Z","updated_at":"2016-04-28T07:58:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/oscarotero/Embed/pulls/138","html_url":"https://github.com/oscarotero/Embed/pull/138","diff_url":"https://github.com/oscarotero/Embed/pull/138.diff","patch_url":"https://github.com/oscarotero/Embed/pull/138.patch"},"body":"The URL support - specifically  `\\Embed\\Url::buildUrl()` - doesn't include all parts of potential URLs. It's missing `port` number and `user:pass` parts.\r\n\r\nI discovered this while writing some unit tests for a utility that was using this library, and tried to make some requests to itself - which was hosted on an internal sandboxed environment which ran the webserver on an alternate port.\r\nPort is important, and though I don't have a use-case for user:pass support, we may as well support the URL syntax fully.\r\n\r\nIt looks like the same omission exists in `getAbsolute()`, but I don't have a test-case for that..\r\nThis fix was written with reference to http://php.net/manual/en/function.parse-url.php#106731 , that seems to be pretty accurate."},"comment":{"url":"https://api.github.com/repos/oscarotero/Embed/issues/comments/215340540","html_url":"https://github.com/oscarotero/Embed/pull/138#issuecomment-215340540","issue_url":"https://api.github.com/repos/oscarotero/Embed/issues/138","id":215340540,"user":{"login":"oscarotero","id":377873,"avatar_url":"https://avatars.githubusercontent.com/u/377873?v=3","gravatar_id":"","url":"https://api.github.com/users/oscarotero","html_url":"https://github.com/oscarotero","followers_url":"https://api.github.com/users/oscarotero/followers","following_url":"https://api.github.com/users/oscarotero/following{/other_user}","gists_url":"https://api.github.com/users/oscarotero/gists{/gist_id}","starred_url":"https://api.github.com/users/oscarotero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscarotero/subscriptions","organizations_url":"https://api.github.com/users/oscarotero/orgs","repos_url":"https://api.github.com/users/oscarotero/repos","events_url":"https://api.github.com/users/oscarotero/events{/privacy}","received_events_url":"https://api.github.com/users/oscarotero/received_events","type":"User","site_admin":false},"created_at":"2016-04-28T07:58:33Z","updated_at":"2016-04-28T07:58:33Z","body":"Cheers!\r\nPlease, can you add some tests [here](https://github.com/oscarotero/Embed/blob/master/tests/UrlTest.php)?\r\nThanks for your contribution!"}}