{"action":"created","comment":{"url":"https://api.github.com/repos/ably/ably-java/pulls/comments/59838500","id":59838500,"diff_hunk":"@@ -140,6 +140,18 @@ public ConnectionManager(final AblyRealtime ably, Connection connection) {\n \t\t\tLog.e(getClass().getName(), msg, e);\n \t\t\tthrow new RuntimeException(msg, e);\n \t\t}\n+\n+\t\ttry {\n+\t\t\tconnectivityStateChangeEmitter = (ConnectivityStateChangeEmitter) Class.forName(\"io.ably.lib.transport.ConnectivityStateChangeEmitterImpl\").newInstance();\n+\t\t\tconnectivityStateChangeEmitter.on(this);\n+\t\t} catch (ClassNotFoundException e) {\n+\t\t\te.printStackTrace();","path":"core/src/main/java/io/ably/lib/transport/ConnectionManager.java","position":27,"original_position":18,"commit_id":"a56e4bea409286a69eec8c49a2fd924b4e7d820a","original_commit_id":"2b9828542f057fc49bad2cd1d7d36605ae7940c3","user":{"login":"paddybyers","id":1137574,"avatar_url":"https://avatars.githubusercontent.com/u/1137574?v=3","gravatar_id":"","url":"https://api.github.com/users/paddybyers","html_url":"https://github.com/paddybyers","followers_url":"https://api.github.com/users/paddybyers/followers","following_url":"https://api.github.com/users/paddybyers/following{/other_user}","gists_url":"https://api.github.com/users/paddybyers/gists{/gist_id}","starred_url":"https://api.github.com/users/paddybyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paddybyers/subscriptions","organizations_url":"https://api.github.com/users/paddybyers/orgs","repos_url":"https://api.github.com/users/paddybyers/repos","events_url":"https://api.github.com/users/paddybyers/events{/privacy}","received_events_url":"https://api.github.com/users/paddybyers/received_events","type":"User","site_admin":false},"body":"> Should this not go to the logger?\r\n\r\nIt's an error that formally must be handled, but it indicates a packaging error with the library rather than any error that can realistically occur in practice. So either we know for sure from our build/CI process that it will never happen, and we just have an empty catch block, or we call the logger. On Android you won't necessarily see `System.err` in logcat, so if you're relying on this message to realise there's a problem in development, it should go to the logger.","created_at":"2016-04-15T07:54:59Z","updated_at":"2016-04-15T07:54:59Z","html_url":"https://github.com/ably/ably-java/pull/125#discussion_r59838500","pull_request_url":"https://api.github.com/repos/ably/ably-java/pulls/125","_links":{"self":{"href":"https://api.github.com/repos/ably/ably-java/pulls/comments/59838500"},"html":{"href":"https://github.com/ably/ably-java/pull/125#discussion_r59838500"},"pull_request":{"href":"https://api.github.com/repos/ably/ably-java/pulls/125"}}},"pull_request":{"url":"https://api.github.com/repos/ably/ably-java/pulls/125","id":65062006,"html_url":"https://github.com/ably/ably-java/pull/125","diff_url":"https://github.com/ably/ably-java/pull/125.diff","patch_url":"https://github.com/ably/ably-java/pull/125.patch","issue_url":"https://api.github.com/repos/ably/ably-java/issues/125","number":125,"state":"open","locked":false,"title":"RTN20","user":{"login":"gokhanbarisaker","id":914990,"avatar_url":"https://avatars.githubusercontent.com/u/914990?v=3","gravatar_id":"","url":"https://api.github.com/users/gokhanbarisaker","html_url":"https://github.com/gokhanbarisaker","followers_url":"https://api.github.com/users/gokhanbarisaker/followers","following_url":"https://api.github.com/users/gokhanbarisaker/following{/other_user}","gists_url":"https://api.github.com/users/gokhanbarisaker/gists{/gist_id}","starred_url":"https://api.github.com/users/gokhanbarisaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gokhanbarisaker/subscriptions","organizations_url":"https://api.github.com/users/gokhanbarisaker/orgs","repos_url":"https://api.github.com/users/gokhanbarisaker/repos","events_url":"https://api.github.com/users/gokhanbarisaker/events{/privacy}","received_events_url":"https://api.github.com/users/gokhanbarisaker/received_events","type":"User","site_admin":false},"body":"- [x] RTN20a\r\n- [x] RTN20b","created_at":"2016-04-03T07:56:28Z","updated_at":"2016-04-15T07:54:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba24f4caeca4179579f83f2f0c05fd5c816c583e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ably/ably-java/pulls/125/commits","review_comments_url":"https://api.github.com/repos/ably/ably-java/pulls/125/comments","review_comment_url":"https://api.github.com/repos/ably/ably-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ably/ably-java/issues/125/comments","statuses_url":"https://api.github.com/repos/ably/ably-java/statuses/a56e4bea409286a69eec8c49a2fd924b4e7d820a","head":{"label":"gokhanbarisaker:RTN20","ref":"RTN20","sha":"a56e4bea409286a69eec8c49a2fd924b4e7d820a","user":{"login":"gokhanbarisaker","id":914990,"avatar_url":"https://avatars.githubusercontent.com/u/914990?v=3","gravatar_id":"","url":"https://api.github.com/users/gokhanbarisaker","html_url":"https://github.com/gokhanbarisaker","followers_url":"https://api.github.com/users/gokhanbarisaker/followers","following_url":"https://api.github.com/users/gokhanbarisaker/following{/other_user}","gists_url":"https://api.github.com/users/gokhanbarisaker/gists{/gist_id}","starred_url":"https://api.github.com/users/gokhanbarisaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gokhanbarisaker/subscriptions","organizations_url":"https://api.github.com/users/gokhanbarisaker/orgs","repos_url":"https://api.github.com/users/gokhanbarisaker/repos","events_url":"https://api.github.com/users/gokhanbarisaker/events{/privacy}","received_events_url":"https://api.github.com/users/gokhanbarisaker/received_events","type":"User","site_admin":false},"repo":{"id":47753381,"name":"ably-java","full_name":"gokhanbarisaker/ably-java","owner":{"login":"gokhanbarisaker","id":914990,"avatar_url":"https://avatars.githubusercontent.com/u/914990?v=3","gravatar_id":"","url":"https://api.github.com/users/gokhanbarisaker","html_url":"https://github.com/gokhanbarisaker","followers_url":"https://api.github.com/users/gokhanbarisaker/followers","following_url":"https://api.github.com/users/gokhanbarisaker/following{/other_user}","gists_url":"https://api.github.com/users/gokhanbarisaker/gists{/gist_id}","starred_url":"https://api.github.com/users/gokhanbarisaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gokhanbarisaker/subscriptions","organizations_url":"https://api.github.com/users/gokhanbarisaker/orgs","repos_url":"https://api.github.com/users/gokhanbarisaker/repos","events_url":"https://api.github.com/users/gokhanbarisaker/events{/privacy}","received_events_url":"https://api.github.com/users/gokhanbarisaker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gokhanbarisaker/ably-java","description":"Java client for Ably real-time messaging service","fork":true,"url":"https://api.github.com/repos/gokhanbarisaker/ably-java","forks_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/forks","keys_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/teams","hooks_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/hooks","issue_events_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/issues/events{/number}","events_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/events","assignees_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/assignees{/user}","branches_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/branches{/branch}","tags_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/tags","blobs_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/statuses/{sha}","languages_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/languages","stargazers_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/stargazers","contributors_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/contributors","subscribers_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/subscribers","subscription_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/subscription","commits_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/contents/{+path}","compare_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/merges","archive_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/downloads","issues_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/issues{/number}","pulls_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/pulls{/number}","milestones_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/milestones{/number}","notifications_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/labels{/name}","releases_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/releases{/id}","deployments_url":"https://api.github.com/repos/gokhanbarisaker/ably-java/deployments","created_at":"2015-12-10T10:00:14Z","updated_at":"2016-01-12T19:32:12Z","pushed_at":"2016-04-15T06:36:26Z","git_url":"git://github.com/gokhanbarisaker/ably-java.git","ssh_url":"git@github.com:gokhanbarisaker/ably-java.git","clone_url":"https://github.com/gokhanbarisaker/ably-java.git","svn_url":"https://github.com/gokhanbarisaker/ably-java","homepage":null,"size":4950,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ably:master","ref":"master","sha":"040a55d9af77e665060be0e1ce1bf13fab04fb1e","user":{"login":"ably","id":1859245,"avatar_url":"https://avatars.githubusercontent.com/u/1859245?v=3","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"repo":{"id":27377253,"name":"ably-java","full_name":"ably/ably-java","owner":{"login":"ably","id":1859245,"avatar_url":"https://avatars.githubusercontent.com/u/1859245?v=3","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ably/ably-java","description":"Java client for Ably real-time messaging service","fork":false,"url":"https://api.github.com/repos/ably/ably-java","forks_url":"https://api.github.com/repos/ably/ably-java/forks","keys_url":"https://api.github.com/repos/ably/ably-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ably/ably-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ably/ably-java/teams","hooks_url":"https://api.github.com/repos/ably/ably-java/hooks","issue_events_url":"https://api.github.com/repos/ably/ably-java/issues/events{/number}","events_url":"https://api.github.com/repos/ably/ably-java/events","assignees_url":"https://api.github.com/repos/ably/ably-java/assignees{/user}","branches_url":"https://api.github.com/repos/ably/ably-java/branches{/branch}","tags_url":"https://api.github.com/repos/ably/ably-java/tags","blobs_url":"https://api.github.com/repos/ably/ably-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ably/ably-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ably/ably-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/ably/ably-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ably/ably-java/statuses/{sha}","languages_url":"https://api.github.com/repos/ably/ably-java/languages","stargazers_url":"https://api.github.com/repos/ably/ably-java/stargazers","contributors_url":"https://api.github.com/repos/ably/ably-java/contributors","subscribers_url":"https://api.github.com/repos/ably/ably-java/subscribers","subscription_url":"https://api.github.com/repos/ably/ably-java/subscription","commits_url":"https://api.github.com/repos/ably/ably-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/ably/ably-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/ably/ably-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/ably/ably-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/ably/ably-java/contents/{+path}","compare_url":"https://api.github.com/repos/ably/ably-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ably/ably-java/merges","archive_url":"https://api.github.com/repos/ably/ably-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ably/ably-java/downloads","issues_url":"https://api.github.com/repos/ably/ably-java/issues{/number}","pulls_url":"https://api.github.com/repos/ably/ably-java/pulls{/number}","milestones_url":"https://api.github.com/repos/ably/ably-java/milestones{/number}","notifications_url":"https://api.github.com/repos/ably/ably-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ably/ably-java/labels{/name}","releases_url":"https://api.github.com/repos/ably/ably-java/releases{/id}","deployments_url":"https://api.github.com/repos/ably/ably-java/deployments","created_at":"2014-12-01T11:54:06Z","updated_at":"2016-04-01T20:09:08Z","pushed_at":"2016-04-15T06:36:26Z","git_url":"git://github.com/ably/ably-java.git","ssh_url":"git@github.com:ably/ably-java.git","clone_url":"https://github.com/ably/ably-java.git","svn_url":"https://github.com/ably/ably-java","homepage":null,"size":4986,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":33,"forks":11,"open_issues":33,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ably/ably-java/pulls/125"},"html":{"href":"https://github.com/ably/ably-java/pull/125"},"issue":{"href":"https://api.github.com/repos/ably/ably-java/issues/125"},"comments":{"href":"https://api.github.com/repos/ably/ably-java/issues/125/comments"},"review_comments":{"href":"https://api.github.com/repos/ably/ably-java/pulls/125/comments"},"review_comment":{"href":"https://api.github.com/repos/ably/ably-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ably/ably-java/pulls/125/commits"},"statuses":{"href":"https://api.github.com/repos/ably/ably-java/statuses/a56e4bea409286a69eec8c49a2fd924b4e7d820a"}}}}