{"action":"created","issue":{"url":"https://api.github.com/repos/zurb/foundation-emails/issues/547","repository_url":"https://api.github.com/repos/zurb/foundation-emails","labels_url":"https://api.github.com/repos/zurb/foundation-emails/issues/547/labels{/name}","comments_url":"https://api.github.com/repos/zurb/foundation-emails/issues/547/comments","events_url":"https://api.github.com/repos/zurb/foundation-emails/issues/547/events","html_url":"https://github.com/zurb/foundation-emails/pull/547","id":169387952,"number":547,"title":"Set maxLineLength option to 800 for htmlmin","user":{"login":"alxscms","id":1698628,"avatar_url":"https://avatars.githubusercontent.com/u/1698628?v=3","gravatar_id":"","url":"https://api.github.com/users/alxscms","html_url":"https://github.com/alxscms","followers_url":"https://api.github.com/users/alxscms/followers","following_url":"https://api.github.com/users/alxscms/following{/other_user}","gists_url":"https://api.github.com/users/alxscms/gists{/gist_id}","starred_url":"https://api.github.com/users/alxscms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxscms/subscriptions","organizations_url":"https://api.github.com/users/alxscms/orgs","repos_url":"https://api.github.com/users/alxscms/repos","events_url":"https://api.github.com/users/alxscms/events{/privacy}","received_events_url":"https://api.github.com/users/alxscms/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/zurb/foundation-emails/labels/awaiting%20reply","name":"awaiting reply","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-04T14:28:04Z","updated_at":"2016-10-19T08:03:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zurb/foundation-emails/pulls/547","html_url":"https://github.com/zurb/foundation-emails/pull/547","diff_url":"https://github.com/zurb/foundation-emails/pull/547.diff","patch_url":"https://github.com/zurb/foundation-emails/pull/547.patch"},"body":"Gmail automatically adds linebreaks if lines are too long and doesn't care about code being split by newlines at invalid HTML split-points. This PR prevents this to happen."},"comment":{"url":"https://api.github.com/repos/zurb/foundation-emails/issues/comments/254742524","html_url":"https://github.com/zurb/foundation-emails/pull/547#issuecomment-254742524","issue_url":"https://api.github.com/repos/zurb/foundation-emails/issues/547","id":254742524,"user":{"login":"alxscms","id":1698628,"avatar_url":"https://avatars.githubusercontent.com/u/1698628?v=3","gravatar_id":"","url":"https://api.github.com/users/alxscms","html_url":"https://github.com/alxscms","followers_url":"https://api.github.com/users/alxscms/followers","following_url":"https://api.github.com/users/alxscms/following{/other_user}","gists_url":"https://api.github.com/users/alxscms/gists{/gist_id}","starred_url":"https://api.github.com/users/alxscms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxscms/subscriptions","organizations_url":"https://api.github.com/users/alxscms/orgs","repos_url":"https://api.github.com/users/alxscms/repos","events_url":"https://api.github.com/users/alxscms/events{/privacy}","received_events_url":"https://api.github.com/users/alxscms/received_events","type":"User","site_admin":false},"created_at":"2016-10-19T08:03:38Z","updated_at":"2016-10-19T08:03:38Z","body":"Sorry for replying back so late, I've been quite busy these days.\r\nSince my pull request I kept having problems with some weird rendering of my emails on gmail, even though maxLineLength was set to 800 (I chose 800 as a secure limit instead of 998). So I changed it to 78 and it appears that it solved all my problems. No more weird truncating of my html source code done by the client.\r\n\r\nYou can see a detailed explanation of how email clients behave here [https://www.emailonacid.com/blog/article/email-development/line-length-in-html-email](https://www.emailonacid.com/blog/article/email-development/line-length-in-html-email).\r\n\r\nMaybe the most interesting is this :\r\n\r\n> There are two limits that this standard places on the number of characters in a line. Each line of characters MUST be no more than 998 characters, and SHOULD be no more than 78 characters, excluding the CRLF.\r\n> \r\n> The 998 character limit is due to limitations in many implementations which send, receive, or store Internet Message Format messages that simply cannot handle more than 998 characters on a line. Receiving implementations would do well to handle an arbitrarily large number of characters in a line for robustness sake. However, there are so many implementations which (in compliance with the transport requirements of [RFC2821]) do not accept messages containing more than 1000 character including the CR and LF per line, it is important for implementations not to create such messages.\r\n> \r\n> The more conservative 78 character recommendation is to accommodate the many implementations of user interfaces that display these messages which may truncate, or disastrously wrap, the display of more than 78 characters per line, in spite of the fact that such implementations are non-conformant to the intent of this specification (and that of [RFC2821] if they actually cause information to be lost). Again, even though this limitation is put on messages, it is incumbent upon implementations which display messages to handle an arbitrarily large number of characters in a line (certainly at least up to the 998 character limit) for the sake of robustness."}}
{"actor":{"display_login":"alxscms"}}