{"action":"created","comment":{"url":"https://api.github.com/repos/dashbase/dashbase-engine-web/pulls/comments/93996736","pull_request_review_id":14526770,"id":93996736,"diff_hunk":"@@ -163,7 +168,7 @@ private static void routeMetricsMessage(RapidWebsocketMessage message, WebSocket\n       sendMessageThroughWebsocket(out, loadingMessage);\n       final HashMap params = mapper.readValue(message.payload, HashMap.class);\n       if (params.containsKey(\"type\") && params.containsKey(\"host\") && params.containsKey(\"port\")) {\n-        performMetrics(out, params.get(\"type\").toString(), params.get(\"host\").toString(), params.get(\"port\").toString(), lang);\n+        performMetrics(out, params.get(\"type\").toString(), params.get(\"host\").toString(), params.get(\"port\").toString(), lang, false);","path":"app/websocket/WebsocketMessageManager.java","position":31,"original_position":31,"commit_id":"eb215ac2914f7f15217de9168cfeef459f828f98","original_commit_id":"eb215ac2914f7f15217de9168cfeef459f828f98","user":{"login":"javasoze","id":168714,"avatar_url":"https://avatars.githubusercontent.com/u/168714?v=3","gravatar_id":"","url":"https://api.github.com/users/javasoze","html_url":"https://github.com/javasoze","followers_url":"https://api.github.com/users/javasoze/followers","following_url":"https://api.github.com/users/javasoze/following{/other_user}","gists_url":"https://api.github.com/users/javasoze/gists{/gist_id}","starred_url":"https://api.github.com/users/javasoze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javasoze/subscriptions","organizations_url":"https://api.github.com/users/javasoze/orgs","repos_url":"https://api.github.com/users/javasoze/repos","events_url":"https://api.github.com/users/javasoze/events{/privacy}","received_events_url":"https://api.github.com/users/javasoze/received_events","type":"User","site_admin":false},"body":"use String.valueOf() over .toString() to be more robust in case the string is null. (.toString() would throw NPE)","created_at":"2016-12-28T05:40:18Z","updated_at":"2016-12-28T05:40:18Z","html_url":"https://github.com/dashbase/dashbase-engine-web/pull/322#discussion_r93996736","pull_request_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/pulls/322","_links":{"self":{"href":"https://api.github.com/repos/dashbase/dashbase-engine-web/pulls/comments/93996736"},"html":{"href":"https://github.com/dashbase/dashbase-engine-web/pull/322#discussion_r93996736"},"pull_request":{"href":"https://api.github.com/repos/dashbase/dashbase-engine-web/pulls/322"}}},"pull_request":{"url":"https://api.github.com/repos/dashbase/dashbase-engine-web/pulls/322","id":99329600,"html_url":"https://github.com/dashbase/dashbase-engine-web/pull/322","diff_url":"https://github.com/dashbase/dashbase-engine-web/pull/322.diff","patch_url":"https://github.com/dashbase/dashbase-engine-web/pull/322.patch","issue_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/issues/322","number":322,"state":"closed","locked":false,"title":"externalized metrics as it was causing a delay in rendering results","user":{"login":"khou","id":5259411,"avatar_url":"https://avatars.githubusercontent.com/u/5259411?v=3","gravatar_id":"","url":"https://api.github.com/users/khou","html_url":"https://github.com/khou","followers_url":"https://api.github.com/users/khou/followers","following_url":"https://api.github.com/users/khou/following{/other_user}","gists_url":"https://api.github.com/users/khou/gists{/gist_id}","starred_url":"https://api.github.com/users/khou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khou/subscriptions","organizations_url":"https://api.github.com/users/khou/orgs","repos_url":"https://api.github.com/users/khou/repos","events_url":"https://api.github.com/users/khou/events{/privacy}","received_events_url":"https://api.github.com/users/khou/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-25T21:18:09Z","updated_at":"2016-12-28T05:40:18Z","closed_at":"2016-12-27T20:44:25Z","merged_at":"2016-12-27T20:44:25Z","merge_commit_sha":"399e53b494a6c147549749b2875a966e3a0d0d65","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/pulls/322/commits","review_comments_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/pulls/322/comments","review_comment_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/issues/322/comments","statuses_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/statuses/eb215ac2914f7f15217de9168cfeef459f828f98","head":{"label":"khou:externalize_search_metrics","ref":"externalize_search_metrics","sha":"eb215ac2914f7f15217de9168cfeef459f828f98","user":{"login":"khou","id":5259411,"avatar_url":"https://avatars.githubusercontent.com/u/5259411?v=3","gravatar_id":"","url":"https://api.github.com/users/khou","html_url":"https://github.com/khou","followers_url":"https://api.github.com/users/khou/followers","following_url":"https://api.github.com/users/khou/following{/other_user}","gists_url":"https://api.github.com/users/khou/gists{/gist_id}","starred_url":"https://api.github.com/users/khou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khou/subscriptions","organizations_url":"https://api.github.com/users/khou/orgs","repos_url":"https://api.github.com/users/khou/repos","events_url":"https://api.github.com/users/khou/events{/privacy}","received_events_url":"https://api.github.com/users/khou/received_events","type":"User","site_admin":false},"repo":{"id":71510733,"name":"dashbase-engine-web","full_name":"khou/dashbase-engine-web","owner":{"login":"khou","id":5259411,"avatar_url":"https://avatars.githubusercontent.com/u/5259411?v=3","gravatar_id":"","url":"https://api.github.com/users/khou","html_url":"https://github.com/khou","followers_url":"https://api.github.com/users/khou/followers","following_url":"https://api.github.com/users/khou/following{/other_user}","gists_url":"https://api.github.com/users/khou/gists{/gist_id}","starred_url":"https://api.github.com/users/khou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khou/subscriptions","organizations_url":"https://api.github.com/users/khou/orgs","repos_url":"https://api.github.com/users/khou/repos","events_url":"https://api.github.com/users/khou/events{/privacy}","received_events_url":"https://api.github.com/users/khou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/khou/dashbase-engine-web","description":null,"fork":true,"url":"https://api.github.com/repos/khou/dashbase-engine-web","forks_url":"https://api.github.com/repos/khou/dashbase-engine-web/forks","keys_url":"https://api.github.com/repos/khou/dashbase-engine-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/khou/dashbase-engine-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/khou/dashbase-engine-web/teams","hooks_url":"https://api.github.com/repos/khou/dashbase-engine-web/hooks","issue_events_url":"https://api.github.com/repos/khou/dashbase-engine-web/issues/events{/number}","events_url":"https://api.github.com/repos/khou/dashbase-engine-web/events","assignees_url":"https://api.github.com/repos/khou/dashbase-engine-web/assignees{/user}","branches_url":"https://api.github.com/repos/khou/dashbase-engine-web/branches{/branch}","tags_url":"https://api.github.com/repos/khou/dashbase-engine-web/tags","blobs_url":"https://api.github.com/repos/khou/dashbase-engine-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/khou/dashbase-engine-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/khou/dashbase-engine-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/khou/dashbase-engine-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/khou/dashbase-engine-web/statuses/{sha}","languages_url":"https://api.github.com/repos/khou/dashbase-engine-web/languages","stargazers_url":"https://api.github.com/repos/khou/dashbase-engine-web/stargazers","contributors_url":"https://api.github.com/repos/khou/dashbase-engine-web/contributors","subscribers_url":"https://api.github.com/repos/khou/dashbase-engine-web/subscribers","subscription_url":"https://api.github.com/repos/khou/dashbase-engine-web/subscription","commits_url":"https://api.github.com/repos/khou/dashbase-engine-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/khou/dashbase-engine-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/khou/dashbase-engine-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/khou/dashbase-engine-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/khou/dashbase-engine-web/contents/{+path}","compare_url":"https://api.github.com/repos/khou/dashbase-engine-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/khou/dashbase-engine-web/merges","archive_url":"https://api.github.com/repos/khou/dashbase-engine-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/khou/dashbase-engine-web/downloads","issues_url":"https://api.github.com/repos/khou/dashbase-engine-web/issues{/number}","pulls_url":"https://api.github.com/repos/khou/dashbase-engine-web/pulls{/number}","milestones_url":"https://api.github.com/repos/khou/dashbase-engine-web/milestones{/number}","notifications_url":"https://api.github.com/repos/khou/dashbase-engine-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/khou/dashbase-engine-web/labels{/name}","releases_url":"https://api.github.com/repos/khou/dashbase-engine-web/releases{/id}","deployments_url":"https://api.github.com/repos/khou/dashbase-engine-web/deployments","created_at":"2016-10-20T22:52:47Z","updated_at":"2016-10-20T22:52:49Z","pushed_at":"2016-12-25T21:14:51Z","git_url":"git://github.com/khou/dashbase-engine-web.git","ssh_url":"git@github.com:khou/dashbase-engine-web.git","clone_url":"https://github.com/khou/dashbase-engine-web.git","svn_url":"https://github.com/khou/dashbase-engine-web","homepage":null,"size":1309,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dashbase:master","ref":"master","sha":"ba03f504d499970c9006f0bf9737c7acc69f4559","user":{"login":"dashbase","id":19232363,"avatar_url":"https://avatars.githubusercontent.com/u/19232363?v=3","gravatar_id":"","url":"https://api.github.com/users/dashbase","html_url":"https://github.com/dashbase","followers_url":"https://api.github.com/users/dashbase/followers","following_url":"https://api.github.com/users/dashbase/following{/other_user}","gists_url":"https://api.github.com/users/dashbase/gists{/gist_id}","starred_url":"https://api.github.com/users/dashbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashbase/subscriptions","organizations_url":"https://api.github.com/users/dashbase/orgs","repos_url":"https://api.github.com/users/dashbase/repos","events_url":"https://api.github.com/users/dashbase/events{/privacy}","received_events_url":"https://api.github.com/users/dashbase/received_events","type":"Organization","site_admin":false},"repo":{"id":58936654,"name":"dashbase-engine-web","full_name":"dashbase/dashbase-engine-web","owner":{"login":"dashbase","id":19232363,"avatar_url":"https://avatars.githubusercontent.com/u/19232363?v=3","gravatar_id":"","url":"https://api.github.com/users/dashbase","html_url":"https://github.com/dashbase","followers_url":"https://api.github.com/users/dashbase/followers","following_url":"https://api.github.com/users/dashbase/following{/other_user}","gists_url":"https://api.github.com/users/dashbase/gists{/gist_id}","starred_url":"https://api.github.com/users/dashbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashbase/subscriptions","organizations_url":"https://api.github.com/users/dashbase/orgs","repos_url":"https://api.github.com/users/dashbase/repos","events_url":"https://api.github.com/users/dashbase/events{/privacy}","received_events_url":"https://api.github.com/users/dashbase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dashbase/dashbase-engine-web","description":"Dashbase Web Interface","fork":false,"url":"https://api.github.com/repos/dashbase/dashbase-engine-web","forks_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/forks","keys_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/teams","hooks_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/hooks","issue_events_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/issues/events{/number}","events_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/events","assignees_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/assignees{/user}","branches_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/branches{/branch}","tags_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/tags","blobs_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/statuses/{sha}","languages_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/languages","stargazers_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/stargazers","contributors_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/contributors","subscribers_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/subscribers","subscription_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/subscription","commits_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/contents/{+path}","compare_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/merges","archive_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/downloads","issues_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/issues{/number}","pulls_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/pulls{/number}","milestones_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/milestones{/number}","notifications_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/labels{/name}","releases_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/releases{/id}","deployments_url":"https://api.github.com/repos/dashbase/dashbase-engine-web/deployments","created_at":"2016-05-16T13:57:31Z","updated_at":"2016-11-28T06:58:16Z","pushed_at":"2016-12-27T20:44:25Z","git_url":"git://github.com/dashbase/dashbase-engine-web.git","ssh_url":"git@github.com:dashbase/dashbase-engine-web.git","clone_url":"https://github.com/dashbase/dashbase-engine-web.git","svn_url":"https://github.com/dashbase/dashbase-engine-web","homepage":"http://staging.dashbase.io","size":1356,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":13,"forks":1,"open_issues":13,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dashbase/dashbase-engine-web/pulls/322"},"html":{"href":"https://github.com/dashbase/dashbase-engine-web/pull/322"},"issue":{"href":"https://api.github.com/repos/dashbase/dashbase-engine-web/issues/322"},"comments":{"href":"https://api.github.com/repos/dashbase/dashbase-engine-web/issues/322/comments"},"review_comments":{"href":"https://api.github.com/repos/dashbase/dashbase-engine-web/pulls/322/comments"},"review_comment":{"href":"https://api.github.com/repos/dashbase/dashbase-engine-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dashbase/dashbase-engine-web/pulls/322/commits"},"statuses":{"href":"https://api.github.com/repos/dashbase/dashbase-engine-web/statuses/eb215ac2914f7f15217de9168cfeef459f828f98"}}}}
{"actor":{"display_login":"javasoze"}}