{"action":"created","comment":{"url":"https://api.github.com/repos/purescript/purescript/pulls/comments/83556021","pull_request_review_id":4393148,"id":83556021,"diff_hunk":"@@ -291,7 +291,7 @@ moduleToJs (Module coms mn imps exps foreigns decls) foreign_ =\n       evaluate = JSVariableIntroduction Nothing evaluatedObj (Just obj)\n       objAssign = JSVariableIntroduction Nothing newObj (Just $ JSObjectLiteral Nothing [])\n       copy = JSForIn Nothing key jsEvaluatedObj $ JSBlock Nothing [JSIfElse Nothing cond assign Nothing]\n-      cond = JSApp Nothing (JSAccessor Nothing \"hasOwnProperty\" jsEvaluatedObj) [jsKey]\n+      cond = JSApp Nothing (JSAccessor Nothing \"call\" (JSAccessor Nothing \"hasOwnProperty\" (JSObjectLiteral Nothing []))) [jsEvaluatedObj, jsKey]","path":"src/Language/PureScript/CodeGen/JS.hs","position":5,"original_position":5,"commit_id":"4f2959aab1c81136e7b63f51e9beffe6a8052a0c","original_commit_id":"4f2959aab1c81136e7b63f51e9beffe6a8052a0c","user":{"login":"rightfold","id":5132125,"avatar_url":"https://avatars.githubusercontent.com/u/5132125?v=3","gravatar_id":"","url":"https://api.github.com/users/rightfold","html_url":"https://github.com/rightfold","followers_url":"https://api.github.com/users/rightfold/followers","following_url":"https://api.github.com/users/rightfold/following{/other_user}","gists_url":"https://api.github.com/users/rightfold/gists{/gist_id}","starred_url":"https://api.github.com/users/rightfold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rightfold/subscriptions","organizations_url":"https://api.github.com/users/rightfold/orgs","repos_url":"https://api.github.com/users/rightfold/repos","events_url":"https://api.github.com/users/rightfold/events{/privacy}","received_events_url":"https://api.github.com/users/rightfold/received_events","type":"User","site_admin":false},"body":"But that would break when a variable named `Object` is in scope.","created_at":"2016-10-16T17:39:19Z","updated_at":"2016-10-16T17:39:19Z","html_url":"https://github.com/purescript/purescript/pull/2391#discussion_r83556021","pull_request_url":"https://api.github.com/repos/purescript/purescript/pulls/2391","_links":{"self":{"href":"https://api.github.com/repos/purescript/purescript/pulls/comments/83556021"},"html":{"href":"https://github.com/purescript/purescript/pull/2391#discussion_r83556021"},"pull_request":{"href":"https://api.github.com/repos/purescript/purescript/pulls/2391"}}},"pull_request":{"url":"https://api.github.com/repos/purescript/purescript/pulls/2391","id":89524432,"html_url":"https://github.com/purescript/purescript/pull/2391","diff_url":"https://github.com/purescript/purescript/pull/2391.diff","patch_url":"https://github.com/purescript/purescript/pull/2391.patch","issue_url":"https://api.github.com/repos/purescript/purescript/issues/2391","number":2391,"state":"open","locked":false,"title":"Support record updates on records with field named hasOwnProperty","user":{"login":"rightfold","id":5132125,"avatar_url":"https://avatars.githubusercontent.com/u/5132125?v=3","gravatar_id":"","url":"https://api.github.com/users/rightfold","html_url":"https://github.com/rightfold","followers_url":"https://api.github.com/users/rightfold/followers","following_url":"https://api.github.com/users/rightfold/following{/other_user}","gists_url":"https://api.github.com/users/rightfold/gists{/gist_id}","starred_url":"https://api.github.com/users/rightfold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rightfold/subscriptions","organizations_url":"https://api.github.com/users/rightfold/orgs","repos_url":"https://api.github.com/users/rightfold/repos","events_url":"https://api.github.com/users/rightfold/events{/privacy}","received_events_url":"https://api.github.com/users/rightfold/received_events","type":"User","site_admin":false},"body":"Previously this would fail.","created_at":"2016-10-16T12:23:18Z","updated_at":"2016-10-16T17:39:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c648ea98908ff0c6d218420af29eebdbe6134ba","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/purescript/purescript/pulls/2391/commits","review_comments_url":"https://api.github.com/repos/purescript/purescript/pulls/2391/comments","review_comment_url":"https://api.github.com/repos/purescript/purescript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/purescript/purescript/issues/2391/comments","statuses_url":"https://api.github.com/repos/purescript/purescript/statuses/4f2959aab1c81136e7b63f51e9beffe6a8052a0c","head":{"label":"rightfold:master","ref":"master","sha":"4f2959aab1c81136e7b63f51e9beffe6a8052a0c","user":{"login":"rightfold","id":5132125,"avatar_url":"https://avatars.githubusercontent.com/u/5132125?v=3","gravatar_id":"","url":"https://api.github.com/users/rightfold","html_url":"https://github.com/rightfold","followers_url":"https://api.github.com/users/rightfold/followers","following_url":"https://api.github.com/users/rightfold/following{/other_user}","gists_url":"https://api.github.com/users/rightfold/gists{/gist_id}","starred_url":"https://api.github.com/users/rightfold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rightfold/subscriptions","organizations_url":"https://api.github.com/users/rightfold/orgs","repos_url":"https://api.github.com/users/rightfold/repos","events_url":"https://api.github.com/users/rightfold/events{/privacy}","received_events_url":"https://api.github.com/users/rightfold/received_events","type":"User","site_admin":false},"repo":{"id":71045387,"name":"purescript","full_name":"rightfold/purescript","owner":{"login":"rightfold","id":5132125,"avatar_url":"https://avatars.githubusercontent.com/u/5132125?v=3","gravatar_id":"","url":"https://api.github.com/users/rightfold","html_url":"https://github.com/rightfold","followers_url":"https://api.github.com/users/rightfold/followers","following_url":"https://api.github.com/users/rightfold/following{/other_user}","gists_url":"https://api.github.com/users/rightfold/gists{/gist_id}","starred_url":"https://api.github.com/users/rightfold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rightfold/subscriptions","organizations_url":"https://api.github.com/users/rightfold/orgs","repos_url":"https://api.github.com/users/rightfold/repos","events_url":"https://api.github.com/users/rightfold/events{/privacy}","received_events_url":"https://api.github.com/users/rightfold/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rightfold/purescript","description":"A small strongly typed language that compiles to Javascript","fork":true,"url":"https://api.github.com/repos/rightfold/purescript","forks_url":"https://api.github.com/repos/rightfold/purescript/forks","keys_url":"https://api.github.com/repos/rightfold/purescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rightfold/purescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rightfold/purescript/teams","hooks_url":"https://api.github.com/repos/rightfold/purescript/hooks","issue_events_url":"https://api.github.com/repos/rightfold/purescript/issues/events{/number}","events_url":"https://api.github.com/repos/rightfold/purescript/events","assignees_url":"https://api.github.com/repos/rightfold/purescript/assignees{/user}","branches_url":"https://api.github.com/repos/rightfold/purescript/branches{/branch}","tags_url":"https://api.github.com/repos/rightfold/purescript/tags","blobs_url":"https://api.github.com/repos/rightfold/purescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rightfold/purescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rightfold/purescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/rightfold/purescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rightfold/purescript/statuses/{sha}","languages_url":"https://api.github.com/repos/rightfold/purescript/languages","stargazers_url":"https://api.github.com/repos/rightfold/purescript/stargazers","contributors_url":"https://api.github.com/repos/rightfold/purescript/contributors","subscribers_url":"https://api.github.com/repos/rightfold/purescript/subscribers","subscription_url":"https://api.github.com/repos/rightfold/purescript/subscription","commits_url":"https://api.github.com/repos/rightfold/purescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/rightfold/purescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/rightfold/purescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/rightfold/purescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/rightfold/purescript/contents/{+path}","compare_url":"https://api.github.com/repos/rightfold/purescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rightfold/purescript/merges","archive_url":"https://api.github.com/repos/rightfold/purescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rightfold/purescript/downloads","issues_url":"https://api.github.com/repos/rightfold/purescript/issues{/number}","pulls_url":"https://api.github.com/repos/rightfold/purescript/pulls{/number}","milestones_url":"https://api.github.com/repos/rightfold/purescript/milestones{/number}","notifications_url":"https://api.github.com/repos/rightfold/purescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rightfold/purescript/labels{/name}","releases_url":"https://api.github.com/repos/rightfold/purescript/releases{/id}","deployments_url":"https://api.github.com/repos/rightfold/purescript/deployments","created_at":"2016-10-16T11:12:23Z","updated_at":"2016-10-16T11:12:25Z","pushed_at":"2016-10-16T12:23:07Z","git_url":"git://github.com/rightfold/purescript.git","ssh_url":"git@github.com:rightfold/purescript.git","clone_url":"https://github.com/rightfold/purescript.git","svn_url":"https://github.com/rightfold/purescript","homepage":"http://purescript.org","size":7833,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"purescript:master","ref":"master","sha":"c0ec8309666a139b6fb5b9637e1855e430e85b80","user":{"login":"purescript","id":6556677,"avatar_url":"https://avatars.githubusercontent.com/u/6556677?v=3","gravatar_id":"","url":"https://api.github.com/users/purescript","html_url":"https://github.com/purescript","followers_url":"https://api.github.com/users/purescript/followers","following_url":"https://api.github.com/users/purescript/following{/other_user}","gists_url":"https://api.github.com/users/purescript/gists{/gist_id}","starred_url":"https://api.github.com/users/purescript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purescript/subscriptions","organizations_url":"https://api.github.com/users/purescript/orgs","repos_url":"https://api.github.com/users/purescript/repos","events_url":"https://api.github.com/users/purescript/events{/privacy}","received_events_url":"https://api.github.com/users/purescript/received_events","type":"Organization","site_admin":false},"repo":{"id":13206906,"name":"purescript","full_name":"purescript/purescript","owner":{"login":"purescript","id":6556677,"avatar_url":"https://avatars.githubusercontent.com/u/6556677?v=3","gravatar_id":"","url":"https://api.github.com/users/purescript","html_url":"https://github.com/purescript","followers_url":"https://api.github.com/users/purescript/followers","following_url":"https://api.github.com/users/purescript/following{/other_user}","gists_url":"https://api.github.com/users/purescript/gists{/gist_id}","starred_url":"https://api.github.com/users/purescript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purescript/subscriptions","organizations_url":"https://api.github.com/users/purescript/orgs","repos_url":"https://api.github.com/users/purescript/repos","events_url":"https://api.github.com/users/purescript/events{/privacy}","received_events_url":"https://api.github.com/users/purescript/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/purescript/purescript","description":"A small strongly typed language that compiles to Javascript","fork":false,"url":"https://api.github.com/repos/purescript/purescript","forks_url":"https://api.github.com/repos/purescript/purescript/forks","keys_url":"https://api.github.com/repos/purescript/purescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/purescript/purescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/purescript/purescript/teams","hooks_url":"https://api.github.com/repos/purescript/purescript/hooks","issue_events_url":"https://api.github.com/repos/purescript/purescript/issues/events{/number}","events_url":"https://api.github.com/repos/purescript/purescript/events","assignees_url":"https://api.github.com/repos/purescript/purescript/assignees{/user}","branches_url":"https://api.github.com/repos/purescript/purescript/branches{/branch}","tags_url":"https://api.github.com/repos/purescript/purescript/tags","blobs_url":"https://api.github.com/repos/purescript/purescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/purescript/purescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/purescript/purescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/purescript/purescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/purescript/purescript/statuses/{sha}","languages_url":"https://api.github.com/repos/purescript/purescript/languages","stargazers_url":"https://api.github.com/repos/purescript/purescript/stargazers","contributors_url":"https://api.github.com/repos/purescript/purescript/contributors","subscribers_url":"https://api.github.com/repos/purescript/purescript/subscribers","subscription_url":"https://api.github.com/repos/purescript/purescript/subscription","commits_url":"https://api.github.com/repos/purescript/purescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/purescript/purescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/purescript/purescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/purescript/purescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/purescript/purescript/contents/{+path}","compare_url":"https://api.github.com/repos/purescript/purescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/purescript/purescript/merges","archive_url":"https://api.github.com/repos/purescript/purescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/purescript/purescript/downloads","issues_url":"https://api.github.com/repos/purescript/purescript/issues{/number}","pulls_url":"https://api.github.com/repos/purescript/purescript/pulls{/number}","milestones_url":"https://api.github.com/repos/purescript/purescript/milestones{/number}","notifications_url":"https://api.github.com/repos/purescript/purescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/purescript/purescript/labels{/name}","releases_url":"https://api.github.com/repos/purescript/purescript/releases{/id}","deployments_url":"https://api.github.com/repos/purescript/purescript/deployments","created_at":"2013-09-30T05:29:23Z","updated_at":"2016-10-15T11:29:20Z","pushed_at":"2016-10-16T17:37:14Z","git_url":"git://github.com/purescript/purescript.git","ssh_url":"git@github.com:purescript/purescript.git","clone_url":"https://github.com/purescript/purescript.git","svn_url":"https://github.com/purescript/purescript","homepage":"http://purescript.org","size":10766,"stargazers_count":2913,"watchers_count":2913,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":240,"mirror_url":null,"open_issues_count":148,"forks":240,"open_issues":148,"watchers":2913,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/purescript/purescript/pulls/2391"},"html":{"href":"https://github.com/purescript/purescript/pull/2391"},"issue":{"href":"https://api.github.com/repos/purescript/purescript/issues/2391"},"comments":{"href":"https://api.github.com/repos/purescript/purescript/issues/2391/comments"},"review_comments":{"href":"https://api.github.com/repos/purescript/purescript/pulls/2391/comments"},"review_comment":{"href":"https://api.github.com/repos/purescript/purescript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/purescript/purescript/pulls/2391/commits"},"statuses":{"href":"https://api.github.com/repos/purescript/purescript/statuses/4f2959aab1c81136e7b63f51e9beffe6a8052a0c"}}}}
{"actor":{"display_login":"rightfold"}}