{"action":"created","comment":{"url":"https://api.github.com/repos/firedrakeproject/gusto/pulls/comments/70619280","id":70619280,"diff_hunk":"@@ -191,18 +192,30 @@ def apply(self, x_in, x_out):\n \n class EmbeddedDGAdvection(DGAdvection):\n \n-    def __init__(self, state, Vdg, continuity):\n+    def __init__(self, state, V, Vdg=None, continuity=False):","path":"gusto/advection.py","position":15,"original_position":15,"commit_id":"36947dcac2eaaf9c5b63380d2fbc49da01766e51","original_commit_id":"36947dcac2eaaf9c5b63380d2fbc49da01766e51","user":{"login":"wence-","id":1126981,"avatar_url":"https://avatars.githubusercontent.com/u/1126981?v=3","gravatar_id":"","url":"https://api.github.com/users/wence-","html_url":"https://github.com/wence-","followers_url":"https://api.github.com/users/wence-/followers","following_url":"https://api.github.com/users/wence-/following{/other_user}","gists_url":"https://api.github.com/users/wence-/gists{/gist_id}","starred_url":"https://api.github.com/users/wence-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wence-/subscriptions","organizations_url":"https://api.github.com/users/wence-/orgs","repos_url":"https://api.github.com/users/wence-/repos","events_url":"https://api.github.com/users/wence-/events{/privacy}","received_events_url":"https://api.github.com/users/wence-/received_events","type":"User","site_admin":false},"body":"You've changed the constructor signature, but haven't updated the embedded dg advection tests, which still use the old signature.","created_at":"2016-07-13T12:57:22Z","updated_at":"2016-07-13T12:57:22Z","html_url":"https://github.com/firedrakeproject/gusto/pull/51#discussion_r70619280","pull_request_url":"https://api.github.com/repos/firedrakeproject/gusto/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/firedrakeproject/gusto/pulls/comments/70619280"},"html":{"href":"https://github.com/firedrakeproject/gusto/pull/51#discussion_r70619280"},"pull_request":{"href":"https://api.github.com/repos/firedrakeproject/gusto/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/firedrakeproject/gusto/pulls/51","id":76767874,"html_url":"https://github.com/firedrakeproject/gusto/pull/51","diff_url":"https://github.com/firedrakeproject/gusto/pull/51.diff","patch_url":"https://github.com/firedrakeproject/gusto/pull/51.patch","issue_url":"https://api.github.com/repos/firedrakeproject/gusto/issues/51","number":51,"state":"open","locked":false,"title":"3d advection","user":{"login":"colinjcotter","id":6105842,"avatar_url":"https://avatars.githubusercontent.com/u/6105842?v=3","gravatar_id":"","url":"https://api.github.com/users/colinjcotter","html_url":"https://github.com/colinjcotter","followers_url":"https://api.github.com/users/colinjcotter/followers","following_url":"https://api.github.com/users/colinjcotter/following{/other_user}","gists_url":"https://api.github.com/users/colinjcotter/gists{/gist_id}","starred_url":"https://api.github.com/users/colinjcotter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinjcotter/subscriptions","organizations_url":"https://api.github.com/users/colinjcotter/orgs","repos_url":"https://api.github.com/users/colinjcotter/repos","events_url":"https://api.github.com/users/colinjcotter/events{/privacy}","received_events_url":"https://api.github.com/users/colinjcotter/received_events","type":"User","site_admin":false},"body":"Add code to do velocity advection in 3D.\r\n\r\nAlso, automatically build broken spaces for Embedded DG.","created_at":"2016-07-08T15:10:59Z","updated_at":"2016-07-13T12:57:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"013c9748dc586e51067ce5bfda0c4d0d8104f9de","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/firedrakeproject/gusto/pulls/51/commits","review_comments_url":"https://api.github.com/repos/firedrakeproject/gusto/pulls/51/comments","review_comment_url":"https://api.github.com/repos/firedrakeproject/gusto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firedrakeproject/gusto/issues/51/comments","statuses_url":"https://api.github.com/repos/firedrakeproject/gusto/statuses/36947dcac2eaaf9c5b63380d2fbc49da01766e51","head":{"label":"firedrakeproject:3d-advection","ref":"3d-advection","sha":"36947dcac2eaaf9c5b63380d2fbc49da01766e51","user":{"login":"firedrakeproject","id":5558005,"avatar_url":"https://avatars.githubusercontent.com/u/5558005?v=3","gravatar_id":"","url":"https://api.github.com/users/firedrakeproject","html_url":"https://github.com/firedrakeproject","followers_url":"https://api.github.com/users/firedrakeproject/followers","following_url":"https://api.github.com/users/firedrakeproject/following{/other_user}","gists_url":"https://api.github.com/users/firedrakeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/firedrakeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firedrakeproject/subscriptions","organizations_url":"https://api.github.com/users/firedrakeproject/orgs","repos_url":"https://api.github.com/users/firedrakeproject/repos","events_url":"https://api.github.com/users/firedrakeproject/events{/privacy}","received_events_url":"https://api.github.com/users/firedrakeproject/received_events","type":"Organization","site_admin":false},"repo":{"id":49564954,"name":"gusto","full_name":"firedrakeproject/gusto","owner":{"login":"firedrakeproject","id":5558005,"avatar_url":"https://avatars.githubusercontent.com/u/5558005?v=3","gravatar_id":"","url":"https://api.github.com/users/firedrakeproject","html_url":"https://github.com/firedrakeproject","followers_url":"https://api.github.com/users/firedrakeproject/followers","following_url":"https://api.github.com/users/firedrakeproject/following{/other_user}","gists_url":"https://api.github.com/users/firedrakeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/firedrakeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firedrakeproject/subscriptions","organizations_url":"https://api.github.com/users/firedrakeproject/orgs","repos_url":"https://api.github.com/users/firedrakeproject/repos","events_url":"https://api.github.com/users/firedrakeproject/events{/privacy}","received_events_url":"https://api.github.com/users/firedrakeproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firedrakeproject/gusto","description":"Three dimensional atmospheric dynamical core using the Gung Ho numerics.","fork":false,"url":"https://api.github.com/repos/firedrakeproject/gusto","forks_url":"https://api.github.com/repos/firedrakeproject/gusto/forks","keys_url":"https://api.github.com/repos/firedrakeproject/gusto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firedrakeproject/gusto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firedrakeproject/gusto/teams","hooks_url":"https://api.github.com/repos/firedrakeproject/gusto/hooks","issue_events_url":"https://api.github.com/repos/firedrakeproject/gusto/issues/events{/number}","events_url":"https://api.github.com/repos/firedrakeproject/gusto/events","assignees_url":"https://api.github.com/repos/firedrakeproject/gusto/assignees{/user}","branches_url":"https://api.github.com/repos/firedrakeproject/gusto/branches{/branch}","tags_url":"https://api.github.com/repos/firedrakeproject/gusto/tags","blobs_url":"https://api.github.com/repos/firedrakeproject/gusto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firedrakeproject/gusto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firedrakeproject/gusto/git/refs{/sha}","trees_url":"https://api.github.com/repos/firedrakeproject/gusto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firedrakeproject/gusto/statuses/{sha}","languages_url":"https://api.github.com/repos/firedrakeproject/gusto/languages","stargazers_url":"https://api.github.com/repos/firedrakeproject/gusto/stargazers","contributors_url":"https://api.github.com/repos/firedrakeproject/gusto/contributors","subscribers_url":"https://api.github.com/repos/firedrakeproject/gusto/subscribers","subscription_url":"https://api.github.com/repos/firedrakeproject/gusto/subscription","commits_url":"https://api.github.com/repos/firedrakeproject/gusto/commits{/sha}","git_commits_url":"https://api.github.com/repos/firedrakeproject/gusto/git/commits{/sha}","comments_url":"https://api.github.com/repos/firedrakeproject/gusto/comments{/number}","issue_comment_url":"https://api.github.com/repos/firedrakeproject/gusto/issues/comments{/number}","contents_url":"https://api.github.com/repos/firedrakeproject/gusto/contents/{+path}","compare_url":"https://api.github.com/repos/firedrakeproject/gusto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firedrakeproject/gusto/merges","archive_url":"https://api.github.com/repos/firedrakeproject/gusto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firedrakeproject/gusto/downloads","issues_url":"https://api.github.com/repos/firedrakeproject/gusto/issues{/number}","pulls_url":"https://api.github.com/repos/firedrakeproject/gusto/pulls{/number}","milestones_url":"https://api.github.com/repos/firedrakeproject/gusto/milestones{/number}","notifications_url":"https://api.github.com/repos/firedrakeproject/gusto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firedrakeproject/gusto/labels{/name}","releases_url":"https://api.github.com/repos/firedrakeproject/gusto/releases{/id}","deployments_url":"https://api.github.com/repos/firedrakeproject/gusto/deployments","created_at":"2016-01-13T09:51:17Z","updated_at":"2016-06-07T16:09:53Z","pushed_at":"2016-07-12T14:56:28Z","git_url":"git://github.com/firedrakeproject/gusto.git","ssh_url":"git@github.com:firedrakeproject/gusto.git","clone_url":"https://github.com/firedrakeproject/gusto.git","svn_url":"https://github.com/firedrakeproject/gusto","homepage":null,"size":3530,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"firedrakeproject:master","ref":"master","sha":"a702e0f3b12963ac02b3ab87798389504c653b62","user":{"login":"firedrakeproject","id":5558005,"avatar_url":"https://avatars.githubusercontent.com/u/5558005?v=3","gravatar_id":"","url":"https://api.github.com/users/firedrakeproject","html_url":"https://github.com/firedrakeproject","followers_url":"https://api.github.com/users/firedrakeproject/followers","following_url":"https://api.github.com/users/firedrakeproject/following{/other_user}","gists_url":"https://api.github.com/users/firedrakeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/firedrakeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firedrakeproject/subscriptions","organizations_url":"https://api.github.com/users/firedrakeproject/orgs","repos_url":"https://api.github.com/users/firedrakeproject/repos","events_url":"https://api.github.com/users/firedrakeproject/events{/privacy}","received_events_url":"https://api.github.com/users/firedrakeproject/received_events","type":"Organization","site_admin":false},"repo":{"id":49564954,"name":"gusto","full_name":"firedrakeproject/gusto","owner":{"login":"firedrakeproject","id":5558005,"avatar_url":"https://avatars.githubusercontent.com/u/5558005?v=3","gravatar_id":"","url":"https://api.github.com/users/firedrakeproject","html_url":"https://github.com/firedrakeproject","followers_url":"https://api.github.com/users/firedrakeproject/followers","following_url":"https://api.github.com/users/firedrakeproject/following{/other_user}","gists_url":"https://api.github.com/users/firedrakeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/firedrakeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firedrakeproject/subscriptions","organizations_url":"https://api.github.com/users/firedrakeproject/orgs","repos_url":"https://api.github.com/users/firedrakeproject/repos","events_url":"https://api.github.com/users/firedrakeproject/events{/privacy}","received_events_url":"https://api.github.com/users/firedrakeproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firedrakeproject/gusto","description":"Three dimensional atmospheric dynamical core using the Gung Ho numerics.","fork":false,"url":"https://api.github.com/repos/firedrakeproject/gusto","forks_url":"https://api.github.com/repos/firedrakeproject/gusto/forks","keys_url":"https://api.github.com/repos/firedrakeproject/gusto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firedrakeproject/gusto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firedrakeproject/gusto/teams","hooks_url":"https://api.github.com/repos/firedrakeproject/gusto/hooks","issue_events_url":"https://api.github.com/repos/firedrakeproject/gusto/issues/events{/number}","events_url":"https://api.github.com/repos/firedrakeproject/gusto/events","assignees_url":"https://api.github.com/repos/firedrakeproject/gusto/assignees{/user}","branches_url":"https://api.github.com/repos/firedrakeproject/gusto/branches{/branch}","tags_url":"https://api.github.com/repos/firedrakeproject/gusto/tags","blobs_url":"https://api.github.com/repos/firedrakeproject/gusto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firedrakeproject/gusto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firedrakeproject/gusto/git/refs{/sha}","trees_url":"https://api.github.com/repos/firedrakeproject/gusto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firedrakeproject/gusto/statuses/{sha}","languages_url":"https://api.github.com/repos/firedrakeproject/gusto/languages","stargazers_url":"https://api.github.com/repos/firedrakeproject/gusto/stargazers","contributors_url":"https://api.github.com/repos/firedrakeproject/gusto/contributors","subscribers_url":"https://api.github.com/repos/firedrakeproject/gusto/subscribers","subscription_url":"https://api.github.com/repos/firedrakeproject/gusto/subscription","commits_url":"https://api.github.com/repos/firedrakeproject/gusto/commits{/sha}","git_commits_url":"https://api.github.com/repos/firedrakeproject/gusto/git/commits{/sha}","comments_url":"https://api.github.com/repos/firedrakeproject/gusto/comments{/number}","issue_comment_url":"https://api.github.com/repos/firedrakeproject/gusto/issues/comments{/number}","contents_url":"https://api.github.com/repos/firedrakeproject/gusto/contents/{+path}","compare_url":"https://api.github.com/repos/firedrakeproject/gusto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firedrakeproject/gusto/merges","archive_url":"https://api.github.com/repos/firedrakeproject/gusto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firedrakeproject/gusto/downloads","issues_url":"https://api.github.com/repos/firedrakeproject/gusto/issues{/number}","pulls_url":"https://api.github.com/repos/firedrakeproject/gusto/pulls{/number}","milestones_url":"https://api.github.com/repos/firedrakeproject/gusto/milestones{/number}","notifications_url":"https://api.github.com/repos/firedrakeproject/gusto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firedrakeproject/gusto/labels{/name}","releases_url":"https://api.github.com/repos/firedrakeproject/gusto/releases{/id}","deployments_url":"https://api.github.com/repos/firedrakeproject/gusto/deployments","created_at":"2016-01-13T09:51:17Z","updated_at":"2016-06-07T16:09:53Z","pushed_at":"2016-07-12T14:56:28Z","git_url":"git://github.com/firedrakeproject/gusto.git","ssh_url":"git@github.com:firedrakeproject/gusto.git","clone_url":"https://github.com/firedrakeproject/gusto.git","svn_url":"https://github.com/firedrakeproject/gusto","homepage":null,"size":3530,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firedrakeproject/gusto/pulls/51"},"html":{"href":"https://github.com/firedrakeproject/gusto/pull/51"},"issue":{"href":"https://api.github.com/repos/firedrakeproject/gusto/issues/51"},"comments":{"href":"https://api.github.com/repos/firedrakeproject/gusto/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/firedrakeproject/gusto/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/firedrakeproject/gusto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firedrakeproject/gusto/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/firedrakeproject/gusto/statuses/36947dcac2eaaf9c5b63380d2fbc49da01766e51"}}}}
{"actor":{"display_login":"wence-"}}