{"push_id":1265873898,"size":14,"distinct_size":1,"ref":"refs/heads/MSAddBackgroundSpecSnapshotTest","head":"567dba0e2a7c609381c8ce016a6708480e1cc809","before":"c409e797147e1cf96c0f7adc5f025dd39304d526","commits":[{"sha":"971d43ad4dccaa39d82d06b4b9c7cdcfa4eb337b","author":{"name":"Hannah Trosi","email":"400b12511852021009e9475b863c3434b334e777@gmail.com"},"message":"[Build settings] add missing newlines at end of file","distinct":false,"url":"https://api.github.com/repos/maicki/AsyncDisplayKit/commits/971d43ad4dccaa39d82d06b4b9c7cdcfa4eb337b"},{"sha":"cbec803b3187dadcb9d746bdb04c972261f03273","author":{"name":"Michael Schneider","email":"cd900ff15fa86656b8436ef71379ab624e00b44f@users.noreply.github.com"},"message":"Merge pull request #2103 from facebook/newlines\n\n[Build settings] add missing newlines at end of file","distinct":false,"url":"https://api.github.com/repos/maicki/AsyncDisplayKit/commits/cbec803b3187dadcb9d746bdb04c972261f03273"},{"sha":"0bd664f9ed245da7cac493a98d556abb52af9cbe","author":{"name":"Adlai Holler","email":"dc048764da5bc0b869a7271212333a7a1fcd71e0@me.com"},"message":"Remove numberOfSectionsForSupplementaryNodeOfKind: Method (#2102)\n\n* Add unit test to confirm that supplementary items must be contained within actual sections\r\n\r\n* [ASLayoutInspecting] Deprecate collectionView:numberOfSectionsForSupplementaryNodeOfKind:\r\n\r\n* Add another test to dig deeper into UICollectionView","distinct":false,"url":"https://api.github.com/repos/maicki/AsyncDisplayKit/commits/0bd664f9ed245da7cac493a98d556abb52af9cbe"},{"sha":"fa3a988b5439f7a9989dd901fe734e17a5fb4b45","author":{"name":"Adlai Holler","email":"dc048764da5bc0b869a7271212333a7a1fcd71e0@me.com"},"message":"[ASPagerNode] Rename constrainedSizeForNodeAtIndexPath: to constrainedSizeForNodeAtIndex: for consistency (#2097)","distinct":false,"url":"https://api.github.com/repos/maicki/AsyncDisplayKit/commits/fa3a988b5439f7a9989dd901fe734e17a5fb4b45"},{"sha":"69e73065e51f07473d9a74f25e1c857f2390d96a","author":{"name":"Adlai Holler","email":"dc048764da5bc0b869a7271212333a7a1fcd71e0@me.com"},"message":"Avoid accessing itemCountsFromDataSource off-main (#2106)","distinct":false,"url":"https://api.github.com/repos/maicki/AsyncDisplayKit/commits/69e73065e51f07473d9a74f25e1c857f2390d96a"},{"sha":"1951954ba5203131b38ac7d37882668acc546e48","author":{"name":"Yue-Wang-Google","email":"4891a88e0cd8efe016501e1fa65d60de99bc1b4c@google.com"},"message":"remove non unicode char (#2109)\n\nsee https://github.com/facebook/AsyncDisplayKit/issues/2108","distinct":false,"url":"https://api.github.com/repos/maicki/AsyncDisplayKit/commits/1951954ba5203131b38ac7d37882668acc546e48"},{"sha":"a38f3db6b0567e4e8001fbea812ede63d6858d6e","author":{"name":"Yue-Wang-Google","email":"4891a88e0cd8efe016501e1fa65d60de99bc1b4c@google.com"},"message":"set the right attributes for block properties. (#2113)\n\n* set the right attributes for block properties.\r\n\r\n* oops. should remove strong.\r\n\r\n* Update ASImageNode.mm\r\n\r\n* revert to use copy for blocks. See apple documentation below\r\n\r\nhttps://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/WorkingwithBlocks/WorkingwithBlocks.html#//apple_ref/doc/uid/TP40011210-CH8-SW12\r\n\r\n* make the block properties nonatomic.","distinct":false,"url":"https://api.github.com/repos/maicki/AsyncDisplayKit/commits/a38f3db6b0567e4e8001fbea812ede63d6858d6e"},{"sha":"c0be871812d88f0b6f455d4482849481c790bb16","author":{"name":"ricky","email":"74d64f6303f8bef46b38328def5c31e2bfbc8ecb@pinterest.com"},"message":"[ASViewController] Propagate the traits on willTransitionToTraitCollection (#2115)\n\nPreviously we were only propagating the trait collection on `viewWillTransitionToSize` since it is called shortly after `willTransitionToTraitCollection`. However, some important things can happen in that time “shortly after” (like collection view layout). As long as nothing changes from `willTransitionToTraitCollection` to `viewWillTransitionToSize` (which it shouldn’t) the traits will not be re-propagated anyhow.\r\n\r\nAlso make sure to use the `ASEnvironmentTraitCollectionMakeDefault` method when creating new envTraitCollection so the struct isn’t filled with junk.","distinct":false,"url":"https://api.github.com/repos/maicki/AsyncDisplayKit/commits/c0be871812d88f0b6f455d4482849481c790bb16"},{"sha":"873bae2eed446d00fa12169cac739c7729e3af28","author":{"name":"Michal Ziman","email":"d5f63bfe0e0a96192c9cec870b712d26dbcfb855@me.com"},"message":"[ASMapNode] Add custom pin annotation for static maps (#1890)\n\n* Adds possibility to have custom annotation pins on static map. This resolves #1889.\r\n\r\n* Removes wrong example for map annotations and adds some annotations to correct map example. #1889\r\n\r\n* Static map node now uses specific property block to get annotation views.\r\n\r\n* Changes self to strongSelf inside of the snapshotters completion block.\r\n\r\n* MapNode: Adds statement in documentation.\r\n\r\n* MapNode: Block for annotation view/image now returns UIImage and center offset is returned in inout param.\r\n\r\n* MapNode and map example: Fixes from review.\r\n\r\n* MapNode example: Gets image directly from custom annotation, without creating annotation view.","distinct":false,"url":"https://api.github.com/repos/maicki/AsyncDisplayKit/commits/873bae2eed446d00fa12169cac739c7729e3af28"},{"sha":"8edc9fe08febed871eab512a24917764c37ddbb0","author":{"name":"Adlai Holler","email":"dc048764da5bc0b869a7271212333a7a1fcd71e0@me.com"},"message":"Ensure supplementary section count tracks item section count (#2118)","distinct":false,"url":"https://api.github.com/repos/maicki/AsyncDisplayKit/commits/8edc9fe08febed871eab512a24917764c37ddbb0"},{"sha":"b21742c3c9a4a8c46f667152110dac6783ea86b5","author":{"name":"Adlai Holler","email":"dc048764da5bc0b869a7271212333a7a1fcd71e0@me.com"},"message":"[ASCollectionView] Relayout Nodes as Soon as Bounds Changes (#2121)\n\n* Add failing test case for ASCollectionView rotation\r\n\r\n* [ASCollectionView] Relayout nodes immediately on bounds change","distinct":false,"url":"https://api.github.com/repos/maicki/AsyncDisplayKit/commits/b21742c3c9a4a8c46f667152110dac6783ea86b5"},{"sha":"dfe4585cecd2d470807e8e292b27aca37972f639","author":{"name":"Garrett Moon","email":"416cbf73dee2261a8784951a251aee29144a826e@excitedpixel.com"},"message":"Add ability to force the size which an image node is rendered. (#2107)\n\n* Add ability to force the size which an image node is rendered.\r\n\r\n* Add unit tests for forced scaling.\r\n\r\n* Whoops, need results!\r\n\r\n* Round forced scaling.\r\n\r\n* Check size of contents too.\r\n\r\n* Remove unnecessary container node.","distinct":false,"url":"https://api.github.com/repos/maicki/AsyncDisplayKit/commits/dfe4585cecd2d470807e8e292b27aca37972f639"},{"sha":"7099c4fcdcc4f1c861449120e451707d2277f5f9","author":{"name":"Adlai Holler","email":"dc048764da5bc0b869a7271212333a7a1fcd71e0@me.com"},"message":"[ASImageNodeSnapshotTests] Fix issue with forced size test (#2127)","distinct":false,"url":"https://api.github.com/repos/maicki/AsyncDisplayKit/commits/7099c4fcdcc4f1c861449120e451707d2277f5f9"},{"sha":"567dba0e2a7c609381c8ce016a6708480e1cc809","author":{"name":"Michael Schneider","email":"ad7fa4c8198f44345eb27251377d0cdb2208f5c0@gmail.com"},"message":"Add snapshot test for ASBackgroundLayoutSpec","distinct":true,"url":"https://api.github.com/repos/maicki/AsyncDisplayKit/commits/567dba0e2a7c609381c8ce016a6708480e1cc809"}]}
{"actor":{"display_login":"maicki"}}