{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/73533922","id":73533922,"diff_hunk":"@@ -45,11 +46,30 @@ func init() {\n type lifecycle struct {\n \t*admission.Handler\n \tclient             clientset.Interface\n-\tstore              cache.Store\n \timmortalNamespaces sets.String\n+\tnamespaceInformer  framework.SharedIndexInformer\n+\t// forceLiveLookupCache holds a list of entries for namespaces that we have a strong reason to believe are stale in our local cache.\n+\t// if a namespace is in this cache, then we will ignore our local state and always fetch latest from api server.\n+\tforceLiveLookupCache *lru.Cache","path":"plugin/pkg/admission/namespace/lifecycle/admission.go","position":37,"original_position":37,"commit_id":"45862e79b6c1cc4d6cb0933a6bc1f493d845a2bf","original_commit_id":"45862e79b6c1cc4d6cb0933a6bc1f493d845a2bf","user":{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars.githubusercontent.com/u/6233452?v=3","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},"body":"it takes two calls to delete a namespace.  delete 1 -> active to terminating, delete 2 -> gone from store.  my point being that after the first delete, its not gone, just terminating.","created_at":"2016-08-04T14:36:06Z","updated_at":"2016-08-04T14:36:06Z","html_url":"https://github.com/kubernetes/kubernetes/pull/29926#discussion_r73533922","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29926","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/73533922"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/29926#discussion_r73533922"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29926"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29926","id":79776681,"html_url":"https://github.com/kubernetes/kubernetes/pull/29926","diff_url":"https://github.com/kubernetes/kubernetes/pull/29926.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/29926.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/29926","number":29926,"state":"open","locked":false,"title":"Move NamespaceLifecycle to use shared informers","user":{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars.githubusercontent.com/u/6233452?v=3","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},"body":"This was a follow-up to https://github.com/kubernetes/kubernetes/pull/29634\r\n\r\nMoves the `NamespaceLifecycle` plug-in to a shared infomer cache.\r\n\r\n/cc @kubernetes/rh-cluster-infra @deads2k @hodovska ","created_at":"2016-08-02T17:36:39Z","updated_at":"2016-08-04T14:36:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"208fcf22dad5673cb0088b347358976130efe97e","assignee":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"assignees":[{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29926/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29926/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/29926/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/45862e79b6c1cc4d6cb0933a6bc1f493d845a2bf","head":{"label":"derekwaynecarr:ns_lifecycle_informer","ref":"ns_lifecycle_informer","sha":"45862e79b6c1cc4d6cb0933a6bc1f493d845a2bf","user":{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars.githubusercontent.com/u/6233452?v=3","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},"repo":{"id":21397341,"name":"kubernetes","full_name":"derekwaynecarr/kubernetes","owner":{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars.githubusercontent.com/u/6233452?v=3","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/derekwaynecarr/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/derekwaynecarr/kubernetes","forks_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/forks","keys_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/teams","hooks_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/events","assignees_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/tags","blobs_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/languages","stargazers_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/subscription","commits_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/merges","archive_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/downloads","issues_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/derekwaynecarr/kubernetes/deployments","created_at":"2014-07-01T17:56:58Z","updated_at":"2016-03-10T15:33:44Z","pushed_at":"2016-08-03T21:44:12Z","git_url":"git://github.com/derekwaynecarr/kubernetes.git","ssh_url":"git@github.com:derekwaynecarr/kubernetes.git","clone_url":"https://github.com/derekwaynecarr/kubernetes.git","svn_url":"https://github.com/derekwaynecarr/kubernetes","homepage":null,"size":296085,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"e5890d9ea5d9e32682d866bf2b224b33b0ab7a5f","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-08-04T12:49:46Z","pushed_at":"2016-08-04T14:34:25Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":514358,"stargazers_count":15951,"watchers_count":15951,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5052,"mirror_url":null,"open_issues_count":4099,"forks":5052,"open_issues":4099,"watchers":15951,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29926"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/29926"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/29926"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/29926/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29926/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/29926/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/45862e79b6c1cc4d6cb0933a6bc1f493d845a2bf"}}}}
{"actor":{"display_login":"derekwaynecarr"}}