{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/92129235","pull_request_review_id":12637321,"id":92129235,"diff_hunk":"@@ -3301,6 +3301,40 @@ func WaitForDeploymentRollbackCleared(c clientset.Interface, ns, deploymentName\n \treturn nil\n }\n \n+// WatchRecreateDeployment wathces Recreate deployments and ensures no new pods will run at the same time with\n+// old pods.\n+func WatchRecreateDeployment(c clientset.Interface, d *extensions.Deployment) error {\n+\tif d.Spec.Strategy.Type != extensions.RecreateDeploymentStrategyType {\n+\t\treturn fmt.Errorf(\"deployment %q does not use a Recreate strategy: %s\", d.Name, d.Spec.Strategy.Type)\n+\t}\n+\n+\tw, err := c.Extensions().Deployments(d.Namespace).Watch(v1.SingleObject(v1.ObjectMeta{Name: d.Name, ResourceVersion: d.ResourceVersion}))\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\n+\tstatus := d.Status\n+\n+\tcondition := func(event watch.Event) (bool, error) {\n+\t\td := event.Object.(*extensions.Deployment)\n+\t\tstatus = d.Status\n+\n+\t\tif d.Status.UpdatedReplicas > 0 && d.Status.Replicas != d.Status.UpdatedReplicas {\n+\t\t\treturn false, fmt.Errorf(\"deployment %q is running new pods alongisde old pods: %#v\", d.Name, status)","path":"test/e2e/framework/util.go","position":23,"original_position":23,"commit_id":"3f035749c96ed13864a994aa007b29fd8fc36592","original_commit_id":"3f035749c96ed13864a994aa007b29fd8fc36592","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"body":"I would expect that to be a different test scoped to a replica set.","created_at":"2016-12-13T09:40:49Z","updated_at":"2016-12-13T09:40:49Z","html_url":"https://github.com/kubernetes/kubernetes/pull/36748#discussion_r92129235","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/36748","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/92129235"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/36748#discussion_r92129235"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/36748"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/36748","id":93570165,"html_url":"https://github.com/kubernetes/kubernetes/pull/36748","diff_url":"https://github.com/kubernetes/kubernetes/pull/36748.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/36748.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/36748","number":36748,"state":"open","locked":false,"title":"Fix Recreate for Deployments and stop using events in e2e tests","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/kubernetes/kubernetes/issues/36453 by removing events from the deployment tests. The test about events during a Rolling deployment is redundant so I just removed it (we already have another test specifically for Rolling deployments).\r\n\r\nCloses https://github.com/kubernetes/kubernetes/issues/32567 (preferred to use a LIST+WATCH instead of a new status API field for replica sets that would add many more writes to replica sets).\r\n\r\n@kubernetes/deployment \r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/36748)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-11-14T13:55:23Z","updated_at":"2016-12-13T09:40:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"786997af2d816e9b0734c26d44d2116d40abfca0","assignee":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"assignees":[{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/31","html_url":"https://github.com/kubernetes/kubernetes/milestone/31","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/31/labels","id":2130587,"number":31,"title":"v1.6","description":null,"creator":{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"open_issues":217,"closed_issues":106,"state":"open","created_at":"2016-11-12T00:35:38Z","updated_at":"2016-12-13T03:42:35Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/36748/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/36748/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/36748/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/3f035749c96ed13864a994aa007b29fd8fc36592","head":{"label":"kargakis:remove-events-from-deployment-tests","ref":"remove-events-from-deployment-tests","sha":"3f035749c96ed13864a994aa007b29fd8fc36592","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"repo":{"id":33254730,"name":"kubernetes","full_name":"kargakis/kubernetes","owner":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kargakis/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/kargakis/kubernetes","forks_url":"https://api.github.com/repos/kargakis/kubernetes/forks","keys_url":"https://api.github.com/repos/kargakis/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kargakis/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kargakis/kubernetes/teams","hooks_url":"https://api.github.com/repos/kargakis/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kargakis/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kargakis/kubernetes/events","assignees_url":"https://api.github.com/repos/kargakis/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kargakis/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kargakis/kubernetes/tags","blobs_url":"https://api.github.com/repos/kargakis/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kargakis/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kargakis/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kargakis/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kargakis/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kargakis/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kargakis/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kargakis/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kargakis/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kargakis/kubernetes/subscription","commits_url":"https://api.github.com/repos/kargakis/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kargakis/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kargakis/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kargakis/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kargakis/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kargakis/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kargakis/kubernetes/merges","archive_url":"https://api.github.com/repos/kargakis/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kargakis/kubernetes/downloads","issues_url":"https://api.github.com/repos/kargakis/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kargakis/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kargakis/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kargakis/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kargakis/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kargakis/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kargakis/kubernetes/deployments","created_at":"2015-04-01T15:11:37Z","updated_at":"2016-10-28T13:43:40Z","pushed_at":"2016-12-12T19:17:59Z","git_url":"git://github.com/kargakis/kubernetes.git","ssh_url":"git@github.com:kargakis/kubernetes.git","clone_url":"https://github.com/kargakis/kubernetes.git","svn_url":"https://github.com/kargakis/kubernetes","homepage":"http://kubernetes.io","size":367319,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"b6f466ac61f8895ddd758b017bd0bafc288dca5e","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-12-13T09:33:41Z","pushed_at":"2016-12-13T09:35:06Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":665948,"stargazers_count":19130,"watchers_count":19130,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6377,"mirror_url":null,"open_issues_count":5369,"forks":6377,"open_issues":5369,"watchers":19130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/36748"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/36748"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/36748"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/36748/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/36748/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/36748/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/3f035749c96ed13864a994aa007b29fd8fc36592"}}}}
{"actor":{"display_login":"kargakis"}}