{"action":"created","issue":{"url":"https://api.github.com/repos/TryGhost/Ghost-Admin/issues/214","repository_url":"https://api.github.com/repos/TryGhost/Ghost-Admin","labels_url":"https://api.github.com/repos/TryGhost/Ghost-Admin/issues/214/labels{/name}","comments_url":"https://api.github.com/repos/TryGhost/Ghost-Admin/issues/214/comments","events_url":"https://api.github.com/repos/TryGhost/Ghost-Admin/issues/214/events","html_url":"https://github.com/TryGhost/Ghost-Admin/pull/214","id":171928377,"number":214,"title":"✨ validate file uploads against \"accept\" mime-type before uploading","user":{"login":"kevinansfield","id":415,"avatar_url":"https://avatars.githubusercontent.com/u/415?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinansfield","html_url":"https://github.com/kevinansfield","followers_url":"https://api.github.com/users/kevinansfield/followers","following_url":"https://api.github.com/users/kevinansfield/following{/other_user}","gists_url":"https://api.github.com/users/kevinansfield/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinansfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinansfield/subscriptions","organizations_url":"https://api.github.com/users/kevinansfield/orgs","repos_url":"https://api.github.com/users/kevinansfield/repos","events_url":"https://api.github.com/users/kevinansfield/events{/privacy}","received_events_url":"https://api.github.com/users/kevinansfield/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-08-18T15:23:06Z","updated_at":"2016-08-22T07:52:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TryGhost/Ghost-Admin/pulls/214","html_url":"https://github.com/TryGhost/Ghost-Admin/pull/214","diff_url":"https://github.com/TryGhost/Ghost-Admin/pull/214.diff","patch_url":"https://github.com/TryGhost/Ghost-Admin/pull/214.patch"},"body":"closes https://github.com/TryGhost/Ghost/issues/7144\r\n- allow `gh-file-uploader`'s `accept` attr to be specified\r\n- allows a `validate` action to be passed into `gh-image-uploader` and `gh-file-uploader` components that runs after a file is selected and before the upload starts\r\n- adds a default `validate` action to `gh-image-uploader` and `gh-file-uploader` that triggers the normal `UnsupportedFileType` error when the selected file's mime-type does not match the `accept` attribute"},"comment":{"url":"https://api.github.com/repos/TryGhost/Ghost-Admin/issues/comments/241338092","html_url":"https://github.com/TryGhost/Ghost-Admin/pull/214#issuecomment-241338092","issue_url":"https://api.github.com/repos/TryGhost/Ghost-Admin/issues/214","id":241338092,"user":{"login":"kevinansfield","id":415,"avatar_url":"https://avatars.githubusercontent.com/u/415?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinansfield","html_url":"https://github.com/kevinansfield","followers_url":"https://api.github.com/users/kevinansfield/followers","following_url":"https://api.github.com/users/kevinansfield/following{/other_user}","gists_url":"https://api.github.com/users/kevinansfield/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinansfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinansfield/subscriptions","organizations_url":"https://api.github.com/users/kevinansfield/orgs","repos_url":"https://api.github.com/users/kevinansfield/repos","events_url":"https://api.github.com/users/kevinansfield/events{/privacy}","received_events_url":"https://api.github.com/users/kevinansfield/received_events","type":"User","site_admin":false},"created_at":"2016-08-22T07:52:10Z","updated_at":"2016-08-22T07:52:10Z","body":"> I'm thinking the height might need to be changed?\r\n\r\nI've already changed this in the [theme uploads PR](https://github.com/TryGhost/Ghost-Admin/pull/210/files#diff-b2e9dc4e88517fd5bcaa218ac5e1bd66L13) but I need to do some testing to ensure it doesn't have any side-effects in other areas.\r\n\r\n> Also - do we want to do the same for the labs import uploader?\r\n\r\nI've added that although the labs importer is in need of refactoring. Once the uploader components have been refactored it would be good to revisit the labs import to have a proper progress bar and better error styling."}}
{"actor":{"display_login":"kevinansfield"}}