{"action":"created","issue":{"url":"https://api.github.com/repos/ipfs/go-ipfs/issues/2204","labels_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/2204/labels{/name}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/2204/comments","events_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/2204/events","html_url":"https://github.com/ipfs/go-ipfs/pull/2204","id":126832472,"number":2204,"title":"Fix test str contains","user":{"login":"chriscool","id":208954,"avatar_url":"https://avatars.githubusercontent.com/u/208954?v=3","gravatar_id":"","url":"https://api.github.com/users/chriscool","html_url":"https://github.com/chriscool","followers_url":"https://api.github.com/users/chriscool/followers","following_url":"https://api.github.com/users/chriscool/following{/other_user}","gists_url":"https://api.github.com/users/chriscool/gists{/gist_id}","starred_url":"https://api.github.com/users/chriscool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriscool/subscriptions","organizations_url":"https://api.github.com/users/chriscool/orgs","repos_url":"https://api.github.com/users/chriscool/repos","events_url":"https://api.github.com/users/chriscool/events{/privacy}","received_events_url":"https://api.github.com/users/chriscool/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-15T09:05:21Z","updated_at":"2016-01-15T09:29:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/2204","html_url":"https://github.com/ipfs/go-ipfs/pull/2204","diff_url":"https://github.com/ipfs/go-ipfs/pull/2204.diff","patch_url":"https://github.com/ipfs/go-ipfs/pull/2204.patch"},"body":"t0081-repo-pinning.sh looks buggy to me without those 2 fixes.\r\nBecause when we grep for just \"direct\", it matches \"indirect\":\r\n\r\n```\r\n> echo \"indirect\" | grep direct\r\nindirect\r\n> echo \"indirect\" | egrep \"\\bdirect\\b\"\r\n> echo \"direct\" | egrep \"\\bdirect\\b\"\r\ndirect\r\n```\r\n\r\nUnfortunately with those 2 fixes, now some tests are failing. This either means that we have bugs in go-ipfs that were previously hidden or that the tests that fail are wrong.\r\n\r\ncc @whyrusleeping @jbenet "},"comment":{"url":"https://api.github.com/repos/ipfs/go-ipfs/issues/comments/171911969","html_url":"https://github.com/ipfs/go-ipfs/pull/2204#issuecomment-171911969","issue_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/2204","id":171911969,"user":{"login":"chriscool","id":208954,"avatar_url":"https://avatars.githubusercontent.com/u/208954?v=3","gravatar_id":"","url":"https://api.github.com/users/chriscool","html_url":"https://github.com/chriscool","followers_url":"https://api.github.com/users/chriscool/followers","following_url":"https://api.github.com/users/chriscool/following{/other_user}","gists_url":"https://api.github.com/users/chriscool/gists{/gist_id}","starred_url":"https://api.github.com/users/chriscool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriscool/subscriptions","organizations_url":"https://api.github.com/users/chriscool/orgs","repos_url":"https://api.github.com/users/chriscool/repos","events_url":"https://api.github.com/users/chriscool/events{/privacy}","received_events_url":"https://api.github.com/users/chriscool/received_events","type":"User","site_admin":false},"created_at":"2016-01-15T09:29:14Z","updated_at":"2016-01-15T09:29:14Z","body":"Ok, there was a problem with my last patch. The tests should pass now.\r\n"}}