{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/76750945","id":76750945,"diff_hunk":"@@ -36,37 +38,25 @@ private object PoolSlot {\n     final case class ConnectedEagerly(slotIx: Int) extends SlotEvent\n   }\n \n-  private val slotProcessorActorName = SeqActorName(\"SlotProcessor\")\n-\n   /*\n     Stream Setup\n     ============\n \n-    Request-   +-----------+              +-------------+              +-------------+     +------------+\n-    Context    | Slot-     |  List[       |   flatten   |  Processor-  |   doubler   |     | SlotEvent- |  Response-\n-    +--------->| Processor +------------->| (MapConcat) +------------->| (MapConcat) +---->| Split      +------------->\n-               |           |  Processor-  |             |  Out         |             |     |            |  Context\n-               +-----------+  Out]        +-------------+              +-------------+     +-----+------+\n-                                                                                                 | RawSlotEvent\n-                                                                                                 | (to Conductor\n-                                                                                                 |  via slotEventMerge)\n-                                                                                                 v\n+    Request-   +-----------+              +-------------+              +------------+\n+    Context    | Slot-     |  List[       |   flatten   |  Processor-  | SlotEvent- |  Response-\n+    +--------->| Processor +------------->| (MapConcat) +------------->| Split      +------------->","path":"akka-http-core/src/main/scala/akka/http/impl/engine/client/PoolSlot.scala","position":38,"original_position":38,"commit_id":"dc10aab1fa49aa4767bc091be9ff0447d9e48c15","original_commit_id":"dc10aab1fa49aa4767bc091be9ff0447d9e48c15","user":{"login":"ktoso","id":120979,"avatar_url":"https://avatars.githubusercontent.com/u/120979?v=3","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"body":"That's where I was heading btw - we can get rid of the concat easily too, see hints below","created_at":"2016-08-30T08:30:12Z","updated_at":"2016-08-30T08:30:12Z","html_url":"https://github.com/akka/akka/pull/21316#discussion_r76750945","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/21316","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/76750945"},"html":{"href":"https://github.com/akka/akka/pull/21316#discussion_r76750945"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/21316"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/21316","id":83226308,"html_url":"https://github.com/akka/akka/pull/21316","diff_url":"https://github.com/akka/akka/pull/21316.diff","patch_url":"https://github.com/akka/akka/pull/21316.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/21316","number":21316,"state":"open","locked":false,"title":"=htc Refactor PoolSlot to GraphStage to address race conditions #19643","user":{"login":"leachbj","id":123051,"avatar_url":"https://avatars.githubusercontent.com/u/123051?v=3","gravatar_id":"","url":"https://api.github.com/users/leachbj","html_url":"https://github.com/leachbj","followers_url":"https://api.github.com/users/leachbj/followers","following_url":"https://api.github.com/users/leachbj/following{/other_user}","gists_url":"https://api.github.com/users/leachbj/gists{/gist_id}","starred_url":"https://api.github.com/users/leachbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leachbj/subscriptions","organizations_url":"https://api.github.com/users/leachbj/orgs","repos_url":"https://api.github.com/users/leachbj/repos","events_url":"https://api.github.com/users/leachbj/events{/privacy}","received_events_url":"https://api.github.com/users/leachbj/received_events","type":"User","site_admin":false},"body":"The previous implementation had a number of race conditions which\r\ncould result in exceptions or a hung client.","created_at":"2016-08-30T08:12:38Z","updated_at":"2016-08-30T08:30:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76ffb72f150d763f6fecac9cf82f84e3383306d0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/21316/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/21316/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/21316/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/dc10aab1fa49aa4767bc091be9ff0447d9e48c15","head":{"label":"leachbj:20726-poolslot-as-graphstage","ref":"20726-poolslot-as-graphstage","sha":"dc10aab1fa49aa4767bc091be9ff0447d9e48c15","user":{"login":"leachbj","id":123051,"avatar_url":"https://avatars.githubusercontent.com/u/123051?v=3","gravatar_id":"","url":"https://api.github.com/users/leachbj","html_url":"https://github.com/leachbj","followers_url":"https://api.github.com/users/leachbj/followers","following_url":"https://api.github.com/users/leachbj/following{/other_user}","gists_url":"https://api.github.com/users/leachbj/gists{/gist_id}","starred_url":"https://api.github.com/users/leachbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leachbj/subscriptions","organizations_url":"https://api.github.com/users/leachbj/orgs","repos_url":"https://api.github.com/users/leachbj/repos","events_url":"https://api.github.com/users/leachbj/events{/privacy}","received_events_url":"https://api.github.com/users/leachbj/received_events","type":"User","site_admin":false},"repo":{"id":23105606,"name":"akka","full_name":"leachbj/akka","owner":{"login":"leachbj","id":123051,"avatar_url":"https://avatars.githubusercontent.com/u/123051?v=3","gravatar_id":"","url":"https://api.github.com/users/leachbj","html_url":"https://github.com/leachbj","followers_url":"https://api.github.com/users/leachbj/followers","following_url":"https://api.github.com/users/leachbj/following{/other_user}","gists_url":"https://api.github.com/users/leachbj/gists{/gist_id}","starred_url":"https://api.github.com/users/leachbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leachbj/subscriptions","organizations_url":"https://api.github.com/users/leachbj/orgs","repos_url":"https://api.github.com/users/leachbj/repos","events_url":"https://api.github.com/users/leachbj/events{/privacy}","received_events_url":"https://api.github.com/users/leachbj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leachbj/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/leachbj/akka","forks_url":"https://api.github.com/repos/leachbj/akka/forks","keys_url":"https://api.github.com/repos/leachbj/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leachbj/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leachbj/akka/teams","hooks_url":"https://api.github.com/repos/leachbj/akka/hooks","issue_events_url":"https://api.github.com/repos/leachbj/akka/issues/events{/number}","events_url":"https://api.github.com/repos/leachbj/akka/events","assignees_url":"https://api.github.com/repos/leachbj/akka/assignees{/user}","branches_url":"https://api.github.com/repos/leachbj/akka/branches{/branch}","tags_url":"https://api.github.com/repos/leachbj/akka/tags","blobs_url":"https://api.github.com/repos/leachbj/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leachbj/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leachbj/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/leachbj/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leachbj/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/leachbj/akka/languages","stargazers_url":"https://api.github.com/repos/leachbj/akka/stargazers","contributors_url":"https://api.github.com/repos/leachbj/akka/contributors","subscribers_url":"https://api.github.com/repos/leachbj/akka/subscribers","subscription_url":"https://api.github.com/repos/leachbj/akka/subscription","commits_url":"https://api.github.com/repos/leachbj/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/leachbj/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/leachbj/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/leachbj/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/leachbj/akka/contents/{+path}","compare_url":"https://api.github.com/repos/leachbj/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leachbj/akka/merges","archive_url":"https://api.github.com/repos/leachbj/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leachbj/akka/downloads","issues_url":"https://api.github.com/repos/leachbj/akka/issues{/number}","pulls_url":"https://api.github.com/repos/leachbj/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/leachbj/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/leachbj/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leachbj/akka/labels{/name}","releases_url":"https://api.github.com/repos/leachbj/akka/releases{/id}","deployments_url":"https://api.github.com/repos/leachbj/akka/deployments","created_at":"2014-08-19T10:09:31Z","updated_at":"2016-02-28T22:58:01Z","pushed_at":"2016-08-30T08:12:16Z","git_url":"git://github.com/leachbj/akka.git","ssh_url":"git@github.com:leachbj/akka.git","clone_url":"https://github.com/leachbj/akka.git","svn_url":"https://github.com/leachbj/akka","homepage":"http://akka.io","size":185225,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"f760b98e8c7e84dc69aa1badbc8ca3298eff86e4","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka/deployments","created_at":"2009-02-16T12:51:54Z","updated_at":"2016-08-30T03:24:14Z","pushed_at":"2016-08-30T08:13:35Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":228194,"stargazers_count":5951,"watchers_count":5951,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1895,"mirror_url":null,"open_issues_count":726,"forks":1895,"open_issues":726,"watchers":5951,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/21316"},"html":{"href":"https://github.com/akka/akka/pull/21316"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/21316"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/21316/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/21316/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/21316/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/dc10aab1fa49aa4767bc091be9ff0447d9e48c15"}}}}
{"actor":{"display_login":"ktoso"}}