{"action":"created","comment":{"url":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/comments/85545004","pull_request_review_id":6256525,"id":85545004,"diff_hunk":"@@ -1330,9 +1330,17 @@ def createBashrc():\n         lines.append( '[ -z \"$HOME\" ] && export HOME=%s' % os.environ['HOME'] )\n       if 'X509_CERT_DIR' in os.environ:\n         lines.append( 'export X509_CERT_DIR=%s' % os.environ['X509_CERT_DIR'] )\n-      elif not os.path.isdir( \"/etc/grid-security/certificates\" ):\n-        lines.append( \"[[ -d '%s/etc/grid-security/certificates' ]] && export X509_CERT_DIR='%s/etc/grid-security/certificates'\" % ( proPath, proPath ) )\n+        certDir = os.environ['X509_CERT_DIR']\n+      else:\n+        if os.path.isdir( \"/etc/grid-security/certificates\" ):\n+          certDir = os.environ['X509_CERT_DIR']","path":"Core/scripts/dirac-install.py","position":31,"original_position":31,"commit_id":"2e0a5795caf0bb43aaf38bc72fded3121fb01239","original_commit_id":"2e0a5795caf0bb43aaf38bc72fded3121fb01239","user":{"login":"andresailer","id":2115797,"avatar_url":"https://avatars.githubusercontent.com/u/2115797?v=3","gravatar_id":"","url":"https://api.github.com/users/andresailer","html_url":"https://github.com/andresailer","followers_url":"https://api.github.com/users/andresailer/followers","following_url":"https://api.github.com/users/andresailer/following{/other_user}","gists_url":"https://api.github.com/users/andresailer/gists{/gist_id}","starred_url":"https://api.github.com/users/andresailer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresailer/subscriptions","organizations_url":"https://api.github.com/users/andresailer/orgs","repos_url":"https://api.github.com/users/andresailer/repos","events_url":"https://api.github.com/users/andresailer/events{/privacy}","received_events_url":"https://api.github.com/users/andresailer/received_events","type":"User","site_admin":false},"body":"`X509...` will not be in `os.environ` here, because we are in the else. \r\nYou wanted to assign `/etc/grid-sec...` to `certDir`, I think?","created_at":"2016-10-28T14:47:28Z","updated_at":"2016-10-28T14:53:17Z","html_url":"https://github.com/DIRACGrid/DIRAC/pull/3155#discussion_r85545004","pull_request_url":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/3155","_links":{"self":{"href":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/comments/85545004"},"html":{"href":"https://github.com/DIRACGrid/DIRAC/pull/3155#discussion_r85545004"},"pull_request":{"href":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/3155"}}},"pull_request":{"url":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/3155","id":91386208,"html_url":"https://github.com/DIRACGrid/DIRAC/pull/3155","diff_url":"https://github.com/DIRACGrid/DIRAC/pull/3155.diff","patch_url":"https://github.com/DIRACGrid/DIRAC/pull/3155.patch","issue_url":"https://api.github.com/repos/DIRACGrid/DIRAC/issues/3155","number":3155,"state":"open","locked":false,"title":"[v6r16] dirac-install: added check for X509_CERT_DIR","user":{"login":"fstagni","id":785576,"avatar_url":"https://avatars.githubusercontent.com/u/785576?v=3","gravatar_id":"","url":"https://api.github.com/users/fstagni","html_url":"https://github.com/fstagni","followers_url":"https://api.github.com/users/fstagni/followers","following_url":"https://api.github.com/users/fstagni/following{/other_user}","gists_url":"https://api.github.com/users/fstagni/gists{/gist_id}","starred_url":"https://api.github.com/users/fstagni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fstagni/subscriptions","organizations_url":"https://api.github.com/users/fstagni/orgs","repos_url":"https://api.github.com/users/fstagni/repos","events_url":"https://api.github.com/users/fstagni/events{/privacy}","received_events_url":"https://api.github.com/users/fstagni/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-28T13:57:28Z","updated_at":"2016-10-28T14:55:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21ea715e0fef255ead7159bd77eeaf5c5f98de40","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/3155/commits","review_comments_url":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/3155/comments","review_comment_url":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DIRACGrid/DIRAC/issues/3155/comments","statuses_url":"https://api.github.com/repos/DIRACGrid/DIRAC/statuses/2e0a5795caf0bb43aaf38bc72fded3121fb01239","head":{"label":"fstagni:fixForCertLocation","ref":"fixForCertLocation","sha":"2e0a5795caf0bb43aaf38bc72fded3121fb01239","user":{"login":"fstagni","id":785576,"avatar_url":"https://avatars.githubusercontent.com/u/785576?v=3","gravatar_id":"","url":"https://api.github.com/users/fstagni","html_url":"https://github.com/fstagni","followers_url":"https://api.github.com/users/fstagni/followers","following_url":"https://api.github.com/users/fstagni/following{/other_user}","gists_url":"https://api.github.com/users/fstagni/gists{/gist_id}","starred_url":"https://api.github.com/users/fstagni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fstagni/subscriptions","organizations_url":"https://api.github.com/users/fstagni/orgs","repos_url":"https://api.github.com/users/fstagni/repos","events_url":"https://api.github.com/users/fstagni/events{/privacy}","received_events_url":"https://api.github.com/users/fstagni/received_events","type":"User","site_admin":false},"repo":{"id":1742442,"name":"DIRAC","full_name":"fstagni/DIRAC","owner":{"login":"fstagni","id":785576,"avatar_url":"https://avatars.githubusercontent.com/u/785576?v=3","gravatar_id":"","url":"https://api.github.com/users/fstagni","html_url":"https://github.com/fstagni","followers_url":"https://api.github.com/users/fstagni/followers","following_url":"https://api.github.com/users/fstagni/following{/other_user}","gists_url":"https://api.github.com/users/fstagni/gists{/gist_id}","starred_url":"https://api.github.com/users/fstagni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fstagni/subscriptions","organizations_url":"https://api.github.com/users/fstagni/orgs","repos_url":"https://api.github.com/users/fstagni/repos","events_url":"https://api.github.com/users/fstagni/events{/privacy}","received_events_url":"https://api.github.com/users/fstagni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fstagni/DIRAC","description":"DIRAC Grid","fork":true,"url":"https://api.github.com/repos/fstagni/DIRAC","forks_url":"https://api.github.com/repos/fstagni/DIRAC/forks","keys_url":"https://api.github.com/repos/fstagni/DIRAC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fstagni/DIRAC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fstagni/DIRAC/teams","hooks_url":"https://api.github.com/repos/fstagni/DIRAC/hooks","issue_events_url":"https://api.github.com/repos/fstagni/DIRAC/issues/events{/number}","events_url":"https://api.github.com/repos/fstagni/DIRAC/events","assignees_url":"https://api.github.com/repos/fstagni/DIRAC/assignees{/user}","branches_url":"https://api.github.com/repos/fstagni/DIRAC/branches{/branch}","tags_url":"https://api.github.com/repos/fstagni/DIRAC/tags","blobs_url":"https://api.github.com/repos/fstagni/DIRAC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fstagni/DIRAC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fstagni/DIRAC/git/refs{/sha}","trees_url":"https://api.github.com/repos/fstagni/DIRAC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fstagni/DIRAC/statuses/{sha}","languages_url":"https://api.github.com/repos/fstagni/DIRAC/languages","stargazers_url":"https://api.github.com/repos/fstagni/DIRAC/stargazers","contributors_url":"https://api.github.com/repos/fstagni/DIRAC/contributors","subscribers_url":"https://api.github.com/repos/fstagni/DIRAC/subscribers","subscription_url":"https://api.github.com/repos/fstagni/DIRAC/subscription","commits_url":"https://api.github.com/repos/fstagni/DIRAC/commits{/sha}","git_commits_url":"https://api.github.com/repos/fstagni/DIRAC/git/commits{/sha}","comments_url":"https://api.github.com/repos/fstagni/DIRAC/comments{/number}","issue_comment_url":"https://api.github.com/repos/fstagni/DIRAC/issues/comments{/number}","contents_url":"https://api.github.com/repos/fstagni/DIRAC/contents/{+path}","compare_url":"https://api.github.com/repos/fstagni/DIRAC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fstagni/DIRAC/merges","archive_url":"https://api.github.com/repos/fstagni/DIRAC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fstagni/DIRAC/downloads","issues_url":"https://api.github.com/repos/fstagni/DIRAC/issues{/number}","pulls_url":"https://api.github.com/repos/fstagni/DIRAC/pulls{/number}","milestones_url":"https://api.github.com/repos/fstagni/DIRAC/milestones{/number}","notifications_url":"https://api.github.com/repos/fstagni/DIRAC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fstagni/DIRAC/labels{/name}","releases_url":"https://api.github.com/repos/fstagni/DIRAC/releases{/id}","deployments_url":"https://api.github.com/repos/fstagni/DIRAC/deployments","created_at":"2011-05-13T08:21:03Z","updated_at":"2015-12-11T14:05:00Z","pushed_at":"2016-10-28T13:56:35Z","git_url":"git://github.com/fstagni/DIRAC.git","ssh_url":"git@github.com:fstagni/DIRAC.git","clone_url":"https://github.com/fstagni/DIRAC.git","svn_url":"https://github.com/fstagni/DIRAC","homepage":"http://diracgrid.org","size":40922,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"v6r15-fixes-13"}},"base":{"label":"DIRACGrid:rel-v6r16","ref":"rel-v6r16","sha":"b46020fe5dd9d72da3349fd1546f42d0fe7e8dfa","user":{"login":"DIRACGrid","id":694842,"avatar_url":"https://avatars.githubusercontent.com/u/694842?v=3","gravatar_id":"","url":"https://api.github.com/users/DIRACGrid","html_url":"https://github.com/DIRACGrid","followers_url":"https://api.github.com/users/DIRACGrid/followers","following_url":"https://api.github.com/users/DIRACGrid/following{/other_user}","gists_url":"https://api.github.com/users/DIRACGrid/gists{/gist_id}","starred_url":"https://api.github.com/users/DIRACGrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DIRACGrid/subscriptions","organizations_url":"https://api.github.com/users/DIRACGrid/orgs","repos_url":"https://api.github.com/users/DIRACGrid/repos","events_url":"https://api.github.com/users/DIRACGrid/events{/privacy}","received_events_url":"https://api.github.com/users/DIRACGrid/received_events","type":"Organization","site_admin":false},"repo":{"id":1576831,"name":"DIRAC","full_name":"DIRACGrid/DIRAC","owner":{"login":"DIRACGrid","id":694842,"avatar_url":"https://avatars.githubusercontent.com/u/694842?v=3","gravatar_id":"","url":"https://api.github.com/users/DIRACGrid","html_url":"https://github.com/DIRACGrid","followers_url":"https://api.github.com/users/DIRACGrid/followers","following_url":"https://api.github.com/users/DIRACGrid/following{/other_user}","gists_url":"https://api.github.com/users/DIRACGrid/gists{/gist_id}","starred_url":"https://api.github.com/users/DIRACGrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DIRACGrid/subscriptions","organizations_url":"https://api.github.com/users/DIRACGrid/orgs","repos_url":"https://api.github.com/users/DIRACGrid/repos","events_url":"https://api.github.com/users/DIRACGrid/events{/privacy}","received_events_url":"https://api.github.com/users/DIRACGrid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DIRACGrid/DIRAC","description":"DIRAC Grid","fork":false,"url":"https://api.github.com/repos/DIRACGrid/DIRAC","forks_url":"https://api.github.com/repos/DIRACGrid/DIRAC/forks","keys_url":"https://api.github.com/repos/DIRACGrid/DIRAC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DIRACGrid/DIRAC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DIRACGrid/DIRAC/teams","hooks_url":"https://api.github.com/repos/DIRACGrid/DIRAC/hooks","issue_events_url":"https://api.github.com/repos/DIRACGrid/DIRAC/issues/events{/number}","events_url":"https://api.github.com/repos/DIRACGrid/DIRAC/events","assignees_url":"https://api.github.com/repos/DIRACGrid/DIRAC/assignees{/user}","branches_url":"https://api.github.com/repos/DIRACGrid/DIRAC/branches{/branch}","tags_url":"https://api.github.com/repos/DIRACGrid/DIRAC/tags","blobs_url":"https://api.github.com/repos/DIRACGrid/DIRAC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DIRACGrid/DIRAC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DIRACGrid/DIRAC/git/refs{/sha}","trees_url":"https://api.github.com/repos/DIRACGrid/DIRAC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DIRACGrid/DIRAC/statuses/{sha}","languages_url":"https://api.github.com/repos/DIRACGrid/DIRAC/languages","stargazers_url":"https://api.github.com/repos/DIRACGrid/DIRAC/stargazers","contributors_url":"https://api.github.com/repos/DIRACGrid/DIRAC/contributors","subscribers_url":"https://api.github.com/repos/DIRACGrid/DIRAC/subscribers","subscription_url":"https://api.github.com/repos/DIRACGrid/DIRAC/subscription","commits_url":"https://api.github.com/repos/DIRACGrid/DIRAC/commits{/sha}","git_commits_url":"https://api.github.com/repos/DIRACGrid/DIRAC/git/commits{/sha}","comments_url":"https://api.github.com/repos/DIRACGrid/DIRAC/comments{/number}","issue_comment_url":"https://api.github.com/repos/DIRACGrid/DIRAC/issues/comments{/number}","contents_url":"https://api.github.com/repos/DIRACGrid/DIRAC/contents/{+path}","compare_url":"https://api.github.com/repos/DIRACGrid/DIRAC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DIRACGrid/DIRAC/merges","archive_url":"https://api.github.com/repos/DIRACGrid/DIRAC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DIRACGrid/DIRAC/downloads","issues_url":"https://api.github.com/repos/DIRACGrid/DIRAC/issues{/number}","pulls_url":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls{/number}","milestones_url":"https://api.github.com/repos/DIRACGrid/DIRAC/milestones{/number}","notifications_url":"https://api.github.com/repos/DIRACGrid/DIRAC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DIRACGrid/DIRAC/labels{/name}","releases_url":"https://api.github.com/repos/DIRACGrid/DIRAC/releases{/id}","deployments_url":"https://api.github.com/repos/DIRACGrid/DIRAC/deployments","created_at":"2011-04-06T11:47:53Z","updated_at":"2016-10-24T10:57:22Z","pushed_at":"2016-10-28T13:57:28Z","git_url":"git://github.com/DIRACGrid/DIRAC.git","ssh_url":"git@github.com:DIRACGrid/DIRAC.git","clone_url":"https://github.com/DIRACGrid/DIRAC.git","svn_url":"https://github.com/DIRACGrid/DIRAC","homepage":"http://diracgrid.org","size":62497,"stargazers_count":53,"watchers_count":53,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":97,"mirror_url":null,"open_issues_count":104,"forks":97,"open_issues":104,"watchers":53,"default_branch":"integration"}},"_links":{"self":{"href":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/3155"},"html":{"href":"https://github.com/DIRACGrid/DIRAC/pull/3155"},"issue":{"href":"https://api.github.com/repos/DIRACGrid/DIRAC/issues/3155"},"comments":{"href":"https://api.github.com/repos/DIRACGrid/DIRAC/issues/3155/comments"},"review_comments":{"href":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/3155/comments"},"review_comment":{"href":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DIRACGrid/DIRAC/pulls/3155/commits"},"statuses":{"href":"https://api.github.com/repos/DIRACGrid/DIRAC/statuses/2e0a5795caf0bb43aaf38bc72fded3121fb01239"}}}}
{"actor":{"display_login":"andresailer"}}