{"action":"created","comment":{"url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/pulls/comments/89278052","pull_request_review_id":9823935,"id":89278052,"diff_hunk":"@@ -66,19 +75,18 @@ public void write(List<? extends CartAndMessage> items) {\n \n     private void sendRequestToCreateOrder(CartAndMessage cartAndMessage) {\n         final Cart cart = cartAndMessage.getCart();\n-        final String body = SphereJsonUtils.toJsonString(cart.getId());\n \n-        final String bodyEncrypt = encrypt(body);\n-        if (bodyEncrypt == null) {\n+        final String encryptedCartId = encrypt(cart.getId());\n+        if (encryptedCartId == null) {\n             timeStampManager.processingMessageFailed();\n             return;\n         }\n-        final List<NameValuePair> headerList = new ArrayList<NameValuePair>();\n-        headerList.add(NameValuePair.of(HttpHeaders.CONTENT_TYPE, \"text/plain\"));\n-        headerList.add(NameValuePair.of(\"Content-Length\", String.valueOf(bodyEncrypt.length())));\n-        final HttpHeaders httpHeader = HttpHeaders.of(headerList);\n-        final HttpRequestBody httpBody = StringHttpRequestBody.of(bodyEncrypt);\n-        final HttpRequest httpRequest = HttpRequest.of(HttpMethod.POST, urlstring, httpHeader, httpBody);\n+\n+        QueryStringEncoder queryStringEncoder = new QueryStringEncoder(urlstring);","path":"src/main/java/com/commercetools/paymenttoorderprocessor/jobs/actions/OrderCreator.java","position":59,"original_position":59,"commit_id":"b6bfc5d70fb6ffc68bc12fbb5f6eb52d7afbf966","original_commit_id":"df8acf154e310fb43b916173ca5e8ad54bfab5ae","user":{"login":"andrii-kovalenko-ct","id":22023239,"avatar_url":"https://avatars.githubusercontent.com/u/22023239?v=3","gravatar_id":"","url":"https://api.github.com/users/andrii-kovalenko-ct","html_url":"https://github.com/andrii-kovalenko-ct","followers_url":"https://api.github.com/users/andrii-kovalenko-ct/followers","following_url":"https://api.github.com/users/andrii-kovalenko-ct/following{/other_user}","gists_url":"https://api.github.com/users/andrii-kovalenko-ct/gists{/gist_id}","starred_url":"https://api.github.com/users/andrii-kovalenko-ct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrii-kovalenko-ct/subscriptions","organizations_url":"https://api.github.com/users/andrii-kovalenko-ct/orgs","repos_url":"https://api.github.com/users/andrii-kovalenko-ct/repos","events_url":"https://api.github.com/users/andrii-kovalenko-ct/events{/privacy}","received_events_url":"https://api.github.com/users/andrii-kovalenko-ct/received_events","type":"User","site_admin":false},"body":"This is not completely correct:\r\nhere `QueryStringEncoder` is used as a simple URL builder, which handles query arguments building (incapsulating URL encoding step, of course). If i use base64 it will look like this:\r\n\r\n  ```\r\n  QueryStringEncoder queryStringEncoder = new QueryStringEncoder(urlstring);\r\n  queryStringEncoder.addParam(\"encryptedCartId\", new String(Base64.getUrlEncoder().encode(encryptedCartId.getBytes())));\r\n  ```","created_at":"2016-11-23T09:23:32Z","updated_at":"2016-11-23T09:23:32Z","html_url":"https://github.com/commercetools/commercetools-payment-to-order-processor/pull/13#discussion_r89278052","pull_request_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/pulls/comments/89278052"},"html":{"href":"https://github.com/commercetools/commercetools-payment-to-order-processor/pull/13#discussion_r89278052"},"pull_request":{"href":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/pulls/13","id":94847127,"html_url":"https://github.com/commercetools/commercetools-payment-to-order-processor/pull/13","diff_url":"https://github.com/commercetools/commercetools-payment-to-order-processor/pull/13.diff","patch_url":"https://github.com/commercetools/commercetools-payment-to-order-processor/pull/13.patch","issue_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/issues/13","number":13,"state":"open","locked":false,"title":"Development","user":{"login":"andrii-kovalenko-ct","id":22023239,"avatar_url":"https://avatars.githubusercontent.com/u/22023239?v=3","gravatar_id":"","url":"https://api.github.com/users/andrii-kovalenko-ct","html_url":"https://github.com/andrii-kovalenko-ct","followers_url":"https://api.github.com/users/andrii-kovalenko-ct/followers","following_url":"https://api.github.com/users/andrii-kovalenko-ct/following{/other_user}","gists_url":"https://api.github.com/users/andrii-kovalenko-ct/gists{/gist_id}","starred_url":"https://api.github.com/users/andrii-kovalenko-ct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrii-kovalenko-ct/subscriptions","organizations_url":"https://api.github.com/users/andrii-kovalenko-ct/orgs","repos_url":"https://api.github.com/users/andrii-kovalenko-ct/repos","events_url":"https://api.github.com/users/andrii-kovalenko-ct/events{/privacy}","received_events_url":"https://api.github.com/users/andrii-kovalenko-ct/received_events","type":"User","site_admin":false},"body":"@butenkor @mht-dotsource @ahalberkamp \r\nplease review the changes according to changes in the API:\r\nnow create order service should be implemented as GET request with encrypted cart id query argument","created_at":"2016-11-22T16:21:48Z","updated_at":"2016-11-23T09:23:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0282243267945aa14309859aa1b203f127f1b403","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/pulls/13/commits","review_comments_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/pulls/13/comments","review_comment_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/issues/13/comments","statuses_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/statuses/b6bfc5d70fb6ffc68bc12fbb5f6eb52d7afbf966","head":{"label":"commercetools:development","ref":"development","sha":"b6bfc5d70fb6ffc68bc12fbb5f6eb52d7afbf966","user":{"login":"commercetools","id":1084585,"avatar_url":"https://avatars.githubusercontent.com/u/1084585?v=3","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"repo":{"id":63140340,"name":"commercetools-payment-to-order-processor","full_name":"commercetools/commercetools-payment-to-order-processor","owner":{"login":"commercetools","id":1084585,"avatar_url":"https://avatars.githubusercontent.com/u/1084585?v=3","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/commercetools/commercetools-payment-to-order-processor","description":null,"fork":false,"url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor","forks_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/forks","keys_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/teams","hooks_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/hooks","issue_events_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/issues/events{/number}","events_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/events","assignees_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/assignees{/user}","branches_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/branches{/branch}","tags_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/tags","blobs_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/git/refs{/sha}","trees_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/statuses/{sha}","languages_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/languages","stargazers_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/stargazers","contributors_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/contributors","subscribers_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/subscribers","subscription_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/subscription","commits_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/commits{/sha}","git_commits_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/git/commits{/sha}","comments_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/comments{/number}","issue_comment_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/issues/comments{/number}","contents_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/contents/{+path}","compare_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/merges","archive_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/downloads","issues_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/issues{/number}","pulls_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/pulls{/number}","milestones_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/milestones{/number}","notifications_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/labels{/name}","releases_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/releases{/id}","deployments_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/deployments","created_at":"2016-07-12T08:25:32Z","updated_at":"2016-11-10T13:19:13Z","pushed_at":"2016-11-23T08:59:24Z","git_url":"git://github.com/commercetools/commercetools-payment-to-order-processor.git","ssh_url":"git@github.com:commercetools/commercetools-payment-to-order-processor.git","clone_url":"https://github.com/commercetools/commercetools-payment-to-order-processor.git","svn_url":"https://github.com/commercetools/commercetools-payment-to-order-processor","homepage":null,"size":102,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"commercetools:master","ref":"master","sha":"56bf4f8f72dc2f81e92f8273d856dfb31bb5e1fc","user":{"login":"commercetools","id":1084585,"avatar_url":"https://avatars.githubusercontent.com/u/1084585?v=3","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"repo":{"id":63140340,"name":"commercetools-payment-to-order-processor","full_name":"commercetools/commercetools-payment-to-order-processor","owner":{"login":"commercetools","id":1084585,"avatar_url":"https://avatars.githubusercontent.com/u/1084585?v=3","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/commercetools/commercetools-payment-to-order-processor","description":null,"fork":false,"url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor","forks_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/forks","keys_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/teams","hooks_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/hooks","issue_events_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/issues/events{/number}","events_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/events","assignees_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/assignees{/user}","branches_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/branches{/branch}","tags_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/tags","blobs_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/git/refs{/sha}","trees_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/statuses/{sha}","languages_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/languages","stargazers_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/stargazers","contributors_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/contributors","subscribers_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/subscribers","subscription_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/subscription","commits_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/commits{/sha}","git_commits_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/git/commits{/sha}","comments_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/comments{/number}","issue_comment_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/issues/comments{/number}","contents_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/contents/{+path}","compare_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/merges","archive_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/downloads","issues_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/issues{/number}","pulls_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/pulls{/number}","milestones_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/milestones{/number}","notifications_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/labels{/name}","releases_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/releases{/id}","deployments_url":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/deployments","created_at":"2016-07-12T08:25:32Z","updated_at":"2016-11-10T13:19:13Z","pushed_at":"2016-11-23T08:59:24Z","git_url":"git://github.com/commercetools/commercetools-payment-to-order-processor.git","ssh_url":"git@github.com:commercetools/commercetools-payment-to-order-processor.git","clone_url":"https://github.com/commercetools/commercetools-payment-to-order-processor.git","svn_url":"https://github.com/commercetools/commercetools-payment-to-order-processor","homepage":null,"size":102,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/pulls/13"},"html":{"href":"https://github.com/commercetools/commercetools-payment-to-order-processor/pull/13"},"issue":{"href":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/issues/13"},"comments":{"href":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/commercetools/commercetools-payment-to-order-processor/statuses/b6bfc5d70fb6ffc68bc12fbb5f6eb52d7afbf966"}}}}
{"actor":{"display_login":"andrii-kovalenko-ct"}}