{"action":"created","comment":{"url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments/56102551","id":56102551,"diff_hunk":"@@ -308,22 +331,23 @@ __curjoin_init_bloom(WT_SESSION_IMPL *session, WT_CURSOR_JOIN *cjoin,\n \t\t\tif ((ret = c->next(c)) == WT_NOTFOUND)\n \t\t\t\tgoto done;\n \t\t\tWT_ERR(ret);\n-\t\t}\n+\t\t} else\n+\t\t\t/* There should not be any other cases */\n+\t\t\tWT_ASSERT(session, false);","path":"src/cursor/cur_join.c","position":270,"original_position":270,"commit_id":"02e26ac5fea1f8ca7c3f3942f8fc77008f8f0dec","original_commit_id":"02e26ac5fea1f8ca7c3f3942f8fc77008f8f0dec","user":{"login":"michaelcahill","id":1264383,"avatar_url":"https://avatars.githubusercontent.com/u/1264383?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelcahill","html_url":"https://github.com/michaelcahill","followers_url":"https://api.github.com/users/michaelcahill/followers","following_url":"https://api.github.com/users/michaelcahill/following{/other_user}","gists_url":"https://api.github.com/users/michaelcahill/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelcahill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelcahill/subscriptions","organizations_url":"https://api.github.com/users/michaelcahill/orgs","repos_url":"https://api.github.com/users/michaelcahill/repos","events_url":"https://api.github.com/users/michaelcahill/events{/privacy}","received_events_url":"https://api.github.com/users/michaelcahill/received_events","type":"User","site_admin":false},"body":"I would change this to `WT_ERR(__wt_illegal_value(session, NULL));` -- it will generate a better error message if some future change introduces a bug.","created_at":"2016-03-15T01:14:13Z","updated_at":"2016-03-15T01:14:13Z","html_url":"https://github.com/wiredtiger/wiredtiger/pull/2581#discussion_r56102551","pull_request_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/2581","_links":{"self":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments/56102551"},"html":{"href":"https://github.com/wiredtiger/wiredtiger/pull/2581#discussion_r56102551"},"pull_request":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/2581"}}},"pull_request":{"url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/2581","id":62765503,"html_url":"https://github.com/wiredtiger/wiredtiger/pull/2581","diff_url":"https://github.com/wiredtiger/wiredtiger/pull/2581.diff","patch_url":"https://github.com/wiredtiger/wiredtiger/pull/2581.patch","issue_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/2581","number":2581,"state":"open","locked":false,"title":"WT-2447 For cursor joins, avoid main table reads during iteration and bloom initialization","user":{"login":"ddanderson","id":591610,"avatar_url":"https://avatars.githubusercontent.com/u/591610?v=3","gravatar_id":"","url":"https://api.github.com/users/ddanderson","html_url":"https://github.com/ddanderson","followers_url":"https://api.github.com/users/ddanderson/followers","following_url":"https://api.github.com/users/ddanderson/following{/other_user}","gists_url":"https://api.github.com/users/ddanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/ddanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddanderson/subscriptions","organizations_url":"https://api.github.com/users/ddanderson/orgs","repos_url":"https://api.github.com/users/ddanderson/repos","events_url":"https://api.github.com/users/ddanderson/events{/privacy}","received_events_url":"https://api.github.com/users/ddanderson/received_events","type":"User","site_admin":false},"body":"This also reduces main table reads from about 24M of pread data size to about 45K using a slightly modified version of the submitted test case.","created_at":"2016-03-14T15:25:03Z","updated_at":"2016-03-15T01:14:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d88e1ad736ca3d0aa14bff0e1917b9589dc82d1a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/2581/commits","review_comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/2581/comments","review_comment_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/2581/comments","statuses_url":"https://api.github.com/repos/wiredtiger/wiredtiger/statuses/02e26ac5fea1f8ca7c3f3942f8fc77008f8f0dec","head":{"label":"wiredtiger:wt-2447-join-main-reads","ref":"wt-2447-join-main-reads","sha":"02e26ac5fea1f8ca7c3f3942f8fc77008f8f0dec","user":{"login":"wiredtiger","id":1251095,"avatar_url":"https://avatars.githubusercontent.com/u/1251095?v=3","gravatar_id":"","url":"https://api.github.com/users/wiredtiger","html_url":"https://github.com/wiredtiger","followers_url":"https://api.github.com/users/wiredtiger/followers","following_url":"https://api.github.com/users/wiredtiger/following{/other_user}","gists_url":"https://api.github.com/users/wiredtiger/gists{/gist_id}","starred_url":"https://api.github.com/users/wiredtiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiredtiger/subscriptions","organizations_url":"https://api.github.com/users/wiredtiger/orgs","repos_url":"https://api.github.com/users/wiredtiger/repos","events_url":"https://api.github.com/users/wiredtiger/events{/privacy}","received_events_url":"https://api.github.com/users/wiredtiger/received_events","type":"Organization","site_admin":false},"repo":{"id":2944302,"name":"wiredtiger","full_name":"wiredtiger/wiredtiger","owner":{"login":"wiredtiger","id":1251095,"avatar_url":"https://avatars.githubusercontent.com/u/1251095?v=3","gravatar_id":"","url":"https://api.github.com/users/wiredtiger","html_url":"https://github.com/wiredtiger","followers_url":"https://api.github.com/users/wiredtiger/followers","following_url":"https://api.github.com/users/wiredtiger/following{/other_user}","gists_url":"https://api.github.com/users/wiredtiger/gists{/gist_id}","starred_url":"https://api.github.com/users/wiredtiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiredtiger/subscriptions","organizations_url":"https://api.github.com/users/wiredtiger/orgs","repos_url":"https://api.github.com/users/wiredtiger/repos","events_url":"https://api.github.com/users/wiredtiger/events{/privacy}","received_events_url":"https://api.github.com/users/wiredtiger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wiredtiger/wiredtiger","description":"WiredTiger's source tree","fork":false,"url":"https://api.github.com/repos/wiredtiger/wiredtiger","forks_url":"https://api.github.com/repos/wiredtiger/wiredtiger/forks","keys_url":"https://api.github.com/repos/wiredtiger/wiredtiger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wiredtiger/wiredtiger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wiredtiger/wiredtiger/teams","hooks_url":"https://api.github.com/repos/wiredtiger/wiredtiger/hooks","issue_events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/events{/number}","events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/events","assignees_url":"https://api.github.com/repos/wiredtiger/wiredtiger/assignees{/user}","branches_url":"https://api.github.com/repos/wiredtiger/wiredtiger/branches{/branch}","tags_url":"https://api.github.com/repos/wiredtiger/wiredtiger/tags","blobs_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/refs{/sha}","trees_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wiredtiger/wiredtiger/statuses/{sha}","languages_url":"https://api.github.com/repos/wiredtiger/wiredtiger/languages","stargazers_url":"https://api.github.com/repos/wiredtiger/wiredtiger/stargazers","contributors_url":"https://api.github.com/repos/wiredtiger/wiredtiger/contributors","subscribers_url":"https://api.github.com/repos/wiredtiger/wiredtiger/subscribers","subscription_url":"https://api.github.com/repos/wiredtiger/wiredtiger/subscription","commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/commits{/sha}","git_commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/commits{/sha}","comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/comments{/number}","issue_comment_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/comments{/number}","contents_url":"https://api.github.com/repos/wiredtiger/wiredtiger/contents/{+path}","compare_url":"https://api.github.com/repos/wiredtiger/wiredtiger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wiredtiger/wiredtiger/merges","archive_url":"https://api.github.com/repos/wiredtiger/wiredtiger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wiredtiger/wiredtiger/downloads","issues_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues{/number}","pulls_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls{/number}","milestones_url":"https://api.github.com/repos/wiredtiger/wiredtiger/milestones{/number}","notifications_url":"https://api.github.com/repos/wiredtiger/wiredtiger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wiredtiger/wiredtiger/labels{/name}","releases_url":"https://api.github.com/repos/wiredtiger/wiredtiger/releases{/id}","deployments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/deployments","created_at":"2011-12-09T00:43:19Z","updated_at":"2016-03-10T18:59:35Z","pushed_at":"2016-03-15T01:10:26Z","git_url":"git://github.com/wiredtiger/wiredtiger.git","ssh_url":"git@github.com:wiredtiger/wiredtiger.git","clone_url":"https://github.com/wiredtiger/wiredtiger.git","svn_url":"https://github.com/wiredtiger/wiredtiger","homepage":"http://source.wiredtiger.com/","size":82915,"stargazers_count":690,"watchers_count":690,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":122,"mirror_url":null,"open_issues_count":2,"forks":122,"open_issues":2,"watchers":690,"default_branch":"master"}},"base":{"label":"wiredtiger:develop","ref":"develop","sha":"f863e4982cd41924b2138af53d352011760dc135","user":{"login":"wiredtiger","id":1251095,"avatar_url":"https://avatars.githubusercontent.com/u/1251095?v=3","gravatar_id":"","url":"https://api.github.com/users/wiredtiger","html_url":"https://github.com/wiredtiger","followers_url":"https://api.github.com/users/wiredtiger/followers","following_url":"https://api.github.com/users/wiredtiger/following{/other_user}","gists_url":"https://api.github.com/users/wiredtiger/gists{/gist_id}","starred_url":"https://api.github.com/users/wiredtiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiredtiger/subscriptions","organizations_url":"https://api.github.com/users/wiredtiger/orgs","repos_url":"https://api.github.com/users/wiredtiger/repos","events_url":"https://api.github.com/users/wiredtiger/events{/privacy}","received_events_url":"https://api.github.com/users/wiredtiger/received_events","type":"Organization","site_admin":false},"repo":{"id":2944302,"name":"wiredtiger","full_name":"wiredtiger/wiredtiger","owner":{"login":"wiredtiger","id":1251095,"avatar_url":"https://avatars.githubusercontent.com/u/1251095?v=3","gravatar_id":"","url":"https://api.github.com/users/wiredtiger","html_url":"https://github.com/wiredtiger","followers_url":"https://api.github.com/users/wiredtiger/followers","following_url":"https://api.github.com/users/wiredtiger/following{/other_user}","gists_url":"https://api.github.com/users/wiredtiger/gists{/gist_id}","starred_url":"https://api.github.com/users/wiredtiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiredtiger/subscriptions","organizations_url":"https://api.github.com/users/wiredtiger/orgs","repos_url":"https://api.github.com/users/wiredtiger/repos","events_url":"https://api.github.com/users/wiredtiger/events{/privacy}","received_events_url":"https://api.github.com/users/wiredtiger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wiredtiger/wiredtiger","description":"WiredTiger's source tree","fork":false,"url":"https://api.github.com/repos/wiredtiger/wiredtiger","forks_url":"https://api.github.com/repos/wiredtiger/wiredtiger/forks","keys_url":"https://api.github.com/repos/wiredtiger/wiredtiger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wiredtiger/wiredtiger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wiredtiger/wiredtiger/teams","hooks_url":"https://api.github.com/repos/wiredtiger/wiredtiger/hooks","issue_events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/events{/number}","events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/events","assignees_url":"https://api.github.com/repos/wiredtiger/wiredtiger/assignees{/user}","branches_url":"https://api.github.com/repos/wiredtiger/wiredtiger/branches{/branch}","tags_url":"https://api.github.com/repos/wiredtiger/wiredtiger/tags","blobs_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/refs{/sha}","trees_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wiredtiger/wiredtiger/statuses/{sha}","languages_url":"https://api.github.com/repos/wiredtiger/wiredtiger/languages","stargazers_url":"https://api.github.com/repos/wiredtiger/wiredtiger/stargazers","contributors_url":"https://api.github.com/repos/wiredtiger/wiredtiger/contributors","subscribers_url":"https://api.github.com/repos/wiredtiger/wiredtiger/subscribers","subscription_url":"https://api.github.com/repos/wiredtiger/wiredtiger/subscription","commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/commits{/sha}","git_commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/commits{/sha}","comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/comments{/number}","issue_comment_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/comments{/number}","contents_url":"https://api.github.com/repos/wiredtiger/wiredtiger/contents/{+path}","compare_url":"https://api.github.com/repos/wiredtiger/wiredtiger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wiredtiger/wiredtiger/merges","archive_url":"https://api.github.com/repos/wiredtiger/wiredtiger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wiredtiger/wiredtiger/downloads","issues_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues{/number}","pulls_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls{/number}","milestones_url":"https://api.github.com/repos/wiredtiger/wiredtiger/milestones{/number}","notifications_url":"https://api.github.com/repos/wiredtiger/wiredtiger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wiredtiger/wiredtiger/labels{/name}","releases_url":"https://api.github.com/repos/wiredtiger/wiredtiger/releases{/id}","deployments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/deployments","created_at":"2011-12-09T00:43:19Z","updated_at":"2016-03-10T18:59:35Z","pushed_at":"2016-03-15T01:10:26Z","git_url":"git://github.com/wiredtiger/wiredtiger.git","ssh_url":"git@github.com:wiredtiger/wiredtiger.git","clone_url":"https://github.com/wiredtiger/wiredtiger.git","svn_url":"https://github.com/wiredtiger/wiredtiger","homepage":"http://source.wiredtiger.com/","size":82915,"stargazers_count":690,"watchers_count":690,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":122,"mirror_url":null,"open_issues_count":2,"forks":122,"open_issues":2,"watchers":690,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/2581"},"html":{"href":"https://github.com/wiredtiger/wiredtiger/pull/2581"},"issue":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/2581"},"comments":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/2581/comments"},"review_comments":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/2581/comments"},"review_comment":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/2581/commits"},"statuses":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/statuses/02e26ac5fea1f8ca7c3f3942f8fc77008f8f0dec"}}}}