{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/63284976","id":63284976,"diff_hunk":"@@ -33,6 +33,8 @@ type APIServer struct {\n \t*genericapiserver.ServerRunOptions\n \tAllowPrivileged             bool\n \tEventTTL                    time.Duration\n+\tKeystoneConfig              string\n+\tKeystoneAuthMode            string","path":"cmd/kube-apiserver/app/options/options.go","position":5,"original_position":5,"commit_id":"c5955b36b45092706d84183566e3c5c53261d896","original_commit_id":"c5955b36b45092706d84183566e3c5c53261d896","user":{"login":"zhouhaibing089","id":4516999,"avatar_url":"https://avatars.githubusercontent.com/u/4516999?v=3","gravatar_id":"","url":"https://api.github.com/users/zhouhaibing089","html_url":"https://github.com/zhouhaibing089","followers_url":"https://api.github.com/users/zhouhaibing089/followers","following_url":"https://api.github.com/users/zhouhaibing089/following{/other_user}","gists_url":"https://api.github.com/users/zhouhaibing089/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouhaibing089/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouhaibing089/subscriptions","organizations_url":"https://api.github.com/users/zhouhaibing089/orgs","repos_url":"https://api.github.com/users/zhouhaibing089/repos","events_url":"https://api.github.com/users/zhouhaibing089/events{/privacy}","received_events_url":"https://api.github.com/users/zhouhaibing089/received_events","type":"User","site_admin":false},"body":"these two fields have been move to `genericapiserver.ServerRunOptions`, please remove them.","created_at":"2016-05-15T02:02:16Z","updated_at":"2016-05-15T02:02:16Z","html_url":"https://github.com/kubernetes/kubernetes/pull/25391#discussion_r63284976","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25391","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/63284976"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25391#discussion_r63284976"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25391"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25391","id":69440822,"html_url":"https://github.com/kubernetes/kubernetes/pull/25391","diff_url":"https://github.com/kubernetes/kubernetes/pull/25391.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/25391.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25391","number":25391,"state":"open","locked":false,"title":"OpenStack Keystone Token Authentication","user":{"login":"kfox1111","id":1513154,"avatar_url":"https://avatars.githubusercontent.com/u/1513154?v=3","gravatar_id":"","url":"https://api.github.com/users/kfox1111","html_url":"https://github.com/kfox1111","followers_url":"https://api.github.com/users/kfox1111/followers","following_url":"https://api.github.com/users/kfox1111/following{/other_user}","gists_url":"https://api.github.com/users/kfox1111/gists{/gist_id}","starred_url":"https://api.github.com/users/kfox1111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfox1111/subscriptions","organizations_url":"https://api.github.com/users/kfox1111/orgs","repos_url":"https://api.github.com/users/kfox1111/repos","events_url":"https://api.github.com/users/kfox1111/events{/privacy}","received_events_url":"https://api.github.com/users/kfox1111/received_events","type":"User","site_admin":false},"body":"This change modifies the api-server to support validation of\r\nOpenStack Keystone tokens, allowing many different types of\r\nKeystone supported authentication plugins to be used.","created_at":"2016-05-10T02:33:50Z","updated_at":"2016-05-15T02:02:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"785d9e27a7a5a8f85e408291e2a1d7d6c0a887ef","assignee":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25391/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25391/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25391/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/c5955b36b45092706d84183566e3c5c53261d896","head":{"label":"kfox1111:keystonetoken","ref":"keystonetoken","sha":"c5955b36b45092706d84183566e3c5c53261d896","user":{"login":"kfox1111","id":1513154,"avatar_url":"https://avatars.githubusercontent.com/u/1513154?v=3","gravatar_id":"","url":"https://api.github.com/users/kfox1111","html_url":"https://github.com/kfox1111","followers_url":"https://api.github.com/users/kfox1111/followers","following_url":"https://api.github.com/users/kfox1111/following{/other_user}","gists_url":"https://api.github.com/users/kfox1111/gists{/gist_id}","starred_url":"https://api.github.com/users/kfox1111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfox1111/subscriptions","organizations_url":"https://api.github.com/users/kfox1111/orgs","repos_url":"https://api.github.com/users/kfox1111/repos","events_url":"https://api.github.com/users/kfox1111/events{/privacy}","received_events_url":"https://api.github.com/users/kfox1111/received_events","type":"User","site_admin":false},"repo":{"id":58422659,"name":"kubernetes","full_name":"kfox1111/kubernetes","owner":{"login":"kfox1111","id":1513154,"avatar_url":"https://avatars.githubusercontent.com/u/1513154?v=3","gravatar_id":"","url":"https://api.github.com/users/kfox1111","html_url":"https://github.com/kfox1111","followers_url":"https://api.github.com/users/kfox1111/followers","following_url":"https://api.github.com/users/kfox1111/following{/other_user}","gists_url":"https://api.github.com/users/kfox1111/gists{/gist_id}","starred_url":"https://api.github.com/users/kfox1111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfox1111/subscriptions","organizations_url":"https://api.github.com/users/kfox1111/orgs","repos_url":"https://api.github.com/users/kfox1111/repos","events_url":"https://api.github.com/users/kfox1111/events{/privacy}","received_events_url":"https://api.github.com/users/kfox1111/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kfox1111/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/kfox1111/kubernetes","forks_url":"https://api.github.com/repos/kfox1111/kubernetes/forks","keys_url":"https://api.github.com/repos/kfox1111/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kfox1111/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kfox1111/kubernetes/teams","hooks_url":"https://api.github.com/repos/kfox1111/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kfox1111/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kfox1111/kubernetes/events","assignees_url":"https://api.github.com/repos/kfox1111/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kfox1111/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kfox1111/kubernetes/tags","blobs_url":"https://api.github.com/repos/kfox1111/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kfox1111/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kfox1111/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kfox1111/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kfox1111/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kfox1111/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kfox1111/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kfox1111/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kfox1111/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kfox1111/kubernetes/subscription","commits_url":"https://api.github.com/repos/kfox1111/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kfox1111/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kfox1111/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kfox1111/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kfox1111/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kfox1111/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kfox1111/kubernetes/merges","archive_url":"https://api.github.com/repos/kfox1111/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kfox1111/kubernetes/downloads","issues_url":"https://api.github.com/repos/kfox1111/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kfox1111/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kfox1111/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kfox1111/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kfox1111/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kfox1111/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kfox1111/kubernetes/deployments","created_at":"2016-05-10T02:15:02Z","updated_at":"2016-05-10T02:15:16Z","pushed_at":"2016-05-15T00:54:19Z","git_url":"git://github.com/kfox1111/kubernetes.git","ssh_url":"git@github.com:kfox1111/kubernetes.git","clone_url":"https://github.com/kfox1111/kubernetes.git","svn_url":"https://github.com/kfox1111/kubernetes","homepage":"http://kubernetes.io","size":195365,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"5df28fa18d4e97f7ff3096d10e1c6b9a71b718c6","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-05-15T00:29:04Z","pushed_at":"2016-05-15T01:59:47Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":395296,"stargazers_count":14374,"watchers_count":14374,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4322,"mirror_url":null,"open_issues_count":3596,"forks":4322,"open_issues":3596,"watchers":14374,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25391"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25391"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25391"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25391/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25391/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25391/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/c5955b36b45092706d84183566e3c5c53261d896"}}}}