{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/web-ext/issues/507","repository_url":"https://api.github.com/repos/mozilla/web-ext","labels_url":"https://api.github.com/repos/mozilla/web-ext/issues/507/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/web-ext/issues/507/comments","events_url":"https://api.github.com/repos/mozilla/web-ext/issues/507/events","html_url":"https://github.com/mozilla/web-ext/issues/507","id":178028785,"number":507,"title":"automatically generate update manifest for self-hosted updates","user":{"login":"Azeirah","id":4040870,"avatar_url":"https://avatars.githubusercontent.com/u/4040870?v=3","gravatar_id":"","url":"https://api.github.com/users/Azeirah","html_url":"https://github.com/Azeirah","followers_url":"https://api.github.com/users/Azeirah/followers","following_url":"https://api.github.com/users/Azeirah/following{/other_user}","gists_url":"https://api.github.com/users/Azeirah/gists{/gist_id}","starred_url":"https://api.github.com/users/Azeirah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azeirah/subscriptions","organizations_url":"https://api.github.com/users/Azeirah/orgs","repos_url":"https://api.github.com/users/Azeirah/repos","events_url":"https://api.github.com/users/Azeirah/events{/privacy}","received_events_url":"https://api.github.com/users/Azeirah/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/web-ext/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-09-20T10:57:20Z","updated_at":"2016-09-29T00:28:43Z","closed_at":null,"body":"It would be extremely helpful to have a command to generate an updateManifest.json within this web-ext tool, just like how jpm is able to do it. Right now, I'm using a custom script, but I feel it should be part of web-ext.\r\n\r\nIs there any reason why web-ext doesn't automatically generate an updateManifest.json file during the `sign` task like jpm does it?"},"comment":{"url":"https://api.github.com/repos/mozilla/web-ext/issues/comments/250339655","html_url":"https://github.com/mozilla/web-ext/issues/507#issuecomment-250339655","issue_url":"https://api.github.com/repos/mozilla/web-ext/issues/507","id":250339655,"user":{"login":"Azeirah","id":4040870,"avatar_url":"https://avatars.githubusercontent.com/u/4040870?v=3","gravatar_id":"","url":"https://api.github.com/users/Azeirah","html_url":"https://github.com/Azeirah","followers_url":"https://api.github.com/users/Azeirah/followers","following_url":"https://api.github.com/users/Azeirah/following{/other_user}","gists_url":"https://api.github.com/users/Azeirah/gists{/gist_id}","starred_url":"https://api.github.com/users/Azeirah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azeirah/subscriptions","organizations_url":"https://api.github.com/users/Azeirah/orgs","repos_url":"https://api.github.com/users/Azeirah/repos","events_url":"https://api.github.com/users/Azeirah/events{/privacy}","received_events_url":"https://api.github.com/users/Azeirah/received_events","type":"User","site_admin":false},"created_at":"2016-09-29T00:28:43Z","updated_at":"2016-09-29T00:28:43Z","body":"I want to let you know I'm working on it, and am making progress.\r\n\r\n![onpaste 20160929-020239](https://cloud.githubusercontent.com/assets/4040870/18936583/d979d95e-85e8-11e6-8f1b-6ac7704c75c0.png)\r\n\r\nHere's where I'm currently at.\r\n\r\n- [x] src/cmd/sign.js, add function generateNewUpdateManifest(...)\r\n    - [ ] Fetch an updateManifest.json from the location pointed to by manifest.applications.gecko.update_url\r\n    - [ ] Error messages (show the user an error message, and exit with error code)\r\n        - [x] the old, fetched updateManifest.json is invalid\r\n        - [x] unable to fetch updateManifest.json due to connection error\r\n        - [xx] argument passed to --update-link flag is invalid (== is missing `{xpiFileName}`)\r\n        <br>Currently, I've issued error messages for the three above errors, but no exit with error code.<br><br>\r\n        - [ ] More potentially erroneus states?\r\n    - [ ] Warning messages\r\n        - [x] The user passed the --update-link flag, but manifest.json lacks an applications.gecko.update_url property\r\n        - [x] The fetched updateManifest.json had no previous release of an addon with this extension-id. Warn the user that if this should not be the case to check her extension-id\r\n        - [ ] More potential warnings?\r\n- [ ] all code complies to flow\r\n- [ ] all code complies to the linter\r\n- [ ] test cases?\r\n- [x] program.js, add --update-link param to `sign` .command\r\n- [ ] documentation\r\n    - [ ] add description of the --update-link param\r\n    - [ ] add explanation on how to auto-generate updateManifest\r\n\r\nI think it'd be helpful to do a short code-review after I've finished with the core task, so the code can be shaped to fit the codebase better, if you have the time?"}}
{"actor":{"display_login":"Azeirah"}}