{"action":"created","comment":{"url":"https://api.github.com/repos/angular/dgeni-packages/pulls/comments/58600955","id":58600955,"diff_hunk":"@@ -1,13 +1,16 @@\n-module.exports = function(accessTagTransform, trimWhitespaceTransform) {\n-  var name = 'access'\n-  accessTagTransform.addTag(name);\n-  accessTagTransform.addValue('private');\n-  accessTagTransform.addValue('protected');\n-  accessTagTransform.addValue('public');\n-\n+module.exports = function(createDocMessage) {\n+  STANDARD_VALUES = ['private', 'protected', 'public'];\n   return {\n-    name: name,\n-    docProperty: 'access',\n-    transforms: [trimWhitespaceTransform, accessTagTransform]\n+    name: 'access',\n+    transforms: function(doc, tag, value) {\n+      var value = value.trim();\n+      if (STANDARD_VALUES.indexOf(value) !== -1) {","path":"jsdoc/tag-defs/access.js","position":17,"original_position":17,"commit_id":"fa695c8998635402c9224f5f32134785a29ddb1b","original_commit_id":"fa695c8998635402c9224f5f32134785a29ddb1b","user":{"login":"destroyerofbuilds","id":10657293,"avatar_url":"https://avatars.githubusercontent.com/u/10657293?v=3","gravatar_id":"","url":"https://api.github.com/users/destroyerofbuilds","html_url":"https://github.com/destroyerofbuilds","followers_url":"https://api.github.com/users/destroyerofbuilds/followers","following_url":"https://api.github.com/users/destroyerofbuilds/following{/other_user}","gists_url":"https://api.github.com/users/destroyerofbuilds/gists{/gist_id}","starred_url":"https://api.github.com/users/destroyerofbuilds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/destroyerofbuilds/subscriptions","organizations_url":"https://api.github.com/users/destroyerofbuilds/orgs","repos_url":"https://api.github.com/users/destroyerofbuilds/repos","events_url":"https://api.github.com/users/destroyerofbuilds/events{/privacy}","received_events_url":"https://api.github.com/users/destroyerofbuilds/received_events","type":"User","site_admin":false},"body":"Was asking whether we should restrict to just those three values. Is a custom access level valid for JSDoc?","created_at":"2016-04-05T19:32:07Z","updated_at":"2016-04-05T19:32:07Z","html_url":"https://github.com/angular/dgeni-packages/pull/171#discussion_r58600955","pull_request_url":"https://api.github.com/repos/angular/dgeni-packages/pulls/171","_links":{"self":{"href":"https://api.github.com/repos/angular/dgeni-packages/pulls/comments/58600955"},"html":{"href":"https://github.com/angular/dgeni-packages/pull/171#discussion_r58600955"},"pull_request":{"href":"https://api.github.com/repos/angular/dgeni-packages/pulls/171"}}},"pull_request":{"url":"https://api.github.com/repos/angular/dgeni-packages/pulls/171","id":65358201,"html_url":"https://github.com/angular/dgeni-packages/pull/171","diff_url":"https://github.com/angular/dgeni-packages/pull/171.diff","patch_url":"https://github.com/angular/dgeni-packages/pull/171.patch","issue_url":"https://api.github.com/repos/angular/dgeni-packages/issues/171","number":171,"state":"open","locked":false,"title":"fix(jsdoc): access tagdefs should more closely follow jsdoc standards","user":{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars.githubusercontent.com/u/15655?v=3","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"body":"The previous implementation was too constraining for real life uses.\r\nSee https://github.com/angular/dgeni-packages/issues/168\r\n\r\nMoreover, the JSDOC docs indicate that `@private` and friends can contain a description.\r\n\r\nCloses #168\r\nCloses #169\r\nCloses #170","created_at":"2016-04-05T19:12:37Z","updated_at":"2016-04-05T19:32:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular/dgeni-packages/pulls/171/commits","review_comments_url":"https://api.github.com/repos/angular/dgeni-packages/pulls/171/comments","review_comment_url":"https://api.github.com/repos/angular/dgeni-packages/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/dgeni-packages/issues/171/comments","statuses_url":"https://api.github.com/repos/angular/dgeni-packages/statuses/fa695c8998635402c9224f5f32134785a29ddb1b","head":{"label":"angular:access-fix","ref":"access-fix","sha":"fa695c8998635402c9224f5f32134785a29ddb1b","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":16757508,"name":"dgeni-packages","full_name":"angular/dgeni-packages","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/dgeni-packages","description":"A collection of dgeni packages for generating documentation from source code.","fork":false,"url":"https://api.github.com/repos/angular/dgeni-packages","forks_url":"https://api.github.com/repos/angular/dgeni-packages/forks","keys_url":"https://api.github.com/repos/angular/dgeni-packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/dgeni-packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/dgeni-packages/teams","hooks_url":"https://api.github.com/repos/angular/dgeni-packages/hooks","issue_events_url":"https://api.github.com/repos/angular/dgeni-packages/issues/events{/number}","events_url":"https://api.github.com/repos/angular/dgeni-packages/events","assignees_url":"https://api.github.com/repos/angular/dgeni-packages/assignees{/user}","branches_url":"https://api.github.com/repos/angular/dgeni-packages/branches{/branch}","tags_url":"https://api.github.com/repos/angular/dgeni-packages/tags","blobs_url":"https://api.github.com/repos/angular/dgeni-packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/dgeni-packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/dgeni-packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/dgeni-packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/dgeni-packages/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/dgeni-packages/languages","stargazers_url":"https://api.github.com/repos/angular/dgeni-packages/stargazers","contributors_url":"https://api.github.com/repos/angular/dgeni-packages/contributors","subscribers_url":"https://api.github.com/repos/angular/dgeni-packages/subscribers","subscription_url":"https://api.github.com/repos/angular/dgeni-packages/subscription","commits_url":"https://api.github.com/repos/angular/dgeni-packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/dgeni-packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/dgeni-packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/dgeni-packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/dgeni-packages/contents/{+path}","compare_url":"https://api.github.com/repos/angular/dgeni-packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/dgeni-packages/merges","archive_url":"https://api.github.com/repos/angular/dgeni-packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/dgeni-packages/downloads","issues_url":"https://api.github.com/repos/angular/dgeni-packages/issues{/number}","pulls_url":"https://api.github.com/repos/angular/dgeni-packages/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/dgeni-packages/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/dgeni-packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/dgeni-packages/labels{/name}","releases_url":"https://api.github.com/repos/angular/dgeni-packages/releases{/id}","deployments_url":"https://api.github.com/repos/angular/dgeni-packages/deployments","created_at":"2014-02-12T05:52:53Z","updated_at":"2016-04-05T16:35:46Z","pushed_at":"2016-04-05T19:12:38Z","git_url":"git://github.com/angular/dgeni-packages.git","ssh_url":"git@github.com:angular/dgeni-packages.git","clone_url":"https://github.com/angular/dgeni-packages.git","svn_url":"https://github.com/angular/dgeni-packages","homepage":null,"size":1049,"stargazers_count":97,"watchers_count":97,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":73,"mirror_url":null,"open_issues_count":28,"forks":73,"open_issues":28,"watchers":97,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"ab28891aa2c3b5adabc1387ef52c742c3de43e81","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":16757508,"name":"dgeni-packages","full_name":"angular/dgeni-packages","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/dgeni-packages","description":"A collection of dgeni packages for generating documentation from source code.","fork":false,"url":"https://api.github.com/repos/angular/dgeni-packages","forks_url":"https://api.github.com/repos/angular/dgeni-packages/forks","keys_url":"https://api.github.com/repos/angular/dgeni-packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/dgeni-packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/dgeni-packages/teams","hooks_url":"https://api.github.com/repos/angular/dgeni-packages/hooks","issue_events_url":"https://api.github.com/repos/angular/dgeni-packages/issues/events{/number}","events_url":"https://api.github.com/repos/angular/dgeni-packages/events","assignees_url":"https://api.github.com/repos/angular/dgeni-packages/assignees{/user}","branches_url":"https://api.github.com/repos/angular/dgeni-packages/branches{/branch}","tags_url":"https://api.github.com/repos/angular/dgeni-packages/tags","blobs_url":"https://api.github.com/repos/angular/dgeni-packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/dgeni-packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/dgeni-packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/dgeni-packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/dgeni-packages/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/dgeni-packages/languages","stargazers_url":"https://api.github.com/repos/angular/dgeni-packages/stargazers","contributors_url":"https://api.github.com/repos/angular/dgeni-packages/contributors","subscribers_url":"https://api.github.com/repos/angular/dgeni-packages/subscribers","subscription_url":"https://api.github.com/repos/angular/dgeni-packages/subscription","commits_url":"https://api.github.com/repos/angular/dgeni-packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/dgeni-packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/dgeni-packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/dgeni-packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/dgeni-packages/contents/{+path}","compare_url":"https://api.github.com/repos/angular/dgeni-packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/dgeni-packages/merges","archive_url":"https://api.github.com/repos/angular/dgeni-packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/dgeni-packages/downloads","issues_url":"https://api.github.com/repos/angular/dgeni-packages/issues{/number}","pulls_url":"https://api.github.com/repos/angular/dgeni-packages/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/dgeni-packages/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/dgeni-packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/dgeni-packages/labels{/name}","releases_url":"https://api.github.com/repos/angular/dgeni-packages/releases{/id}","deployments_url":"https://api.github.com/repos/angular/dgeni-packages/deployments","created_at":"2014-02-12T05:52:53Z","updated_at":"2016-04-05T16:35:46Z","pushed_at":"2016-04-05T19:12:38Z","git_url":"git://github.com/angular/dgeni-packages.git","ssh_url":"git@github.com:angular/dgeni-packages.git","clone_url":"https://github.com/angular/dgeni-packages.git","svn_url":"https://github.com/angular/dgeni-packages","homepage":null,"size":1049,"stargazers_count":97,"watchers_count":97,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":73,"mirror_url":null,"open_issues_count":28,"forks":73,"open_issues":28,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/dgeni-packages/pulls/171"},"html":{"href":"https://github.com/angular/dgeni-packages/pull/171"},"issue":{"href":"https://api.github.com/repos/angular/dgeni-packages/issues/171"},"comments":{"href":"https://api.github.com/repos/angular/dgeni-packages/issues/171/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/dgeni-packages/pulls/171/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/dgeni-packages/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/dgeni-packages/pulls/171/commits"},"statuses":{"href":"https://api.github.com/repos/angular/dgeni-packages/statuses/fa695c8998635402c9224f5f32134785a29ddb1b"}}}}