{"action":"closed","number":1856,"pull_request":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/1856","id":77151420,"html_url":"https://github.com/eclipse/smarthome/pull/1856","diff_url":"https://github.com/eclipse/smarthome/pull/1856.diff","patch_url":"https://github.com/eclipse/smarthome/pull/1856.patch","issue_url":"https://api.github.com/repos/eclipse/smarthome/issues/1856","number":1856,"state":"closed","locked":false,"title":"Reworked XML bundle processing and thing handler initialization","user":{"login":"kaikreuzer","id":3244965,"avatar_url":"https://avatars.githubusercontent.com/u/3244965?v=3","gravatar_id":"","url":"https://api.github.com/users/kaikreuzer","html_url":"https://github.com/kaikreuzer","followers_url":"https://api.github.com/users/kaikreuzer/followers","following_url":"https://api.github.com/users/kaikreuzer/following{/other_user}","gists_url":"https://api.github.com/users/kaikreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikreuzer/subscriptions","organizations_url":"https://api.github.com/users/kaikreuzer/orgs","repos_url":"https://api.github.com/users/kaikreuzer/repos","events_url":"https://api.github.com/users/kaikreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/kaikreuzer/received_events","type":"User","site_admin":false},"body":"This PR includes a lot of improvements on how unfinished XML loading is recognized.\r\nWhat needs to be made sure though, is that the core.thing.xml bundle is started early. As it is an optional bundle (and in theory there can be solutions not supporting any XML declarations), I didn't want to introduce a hard dependency from core.thing to it, so this needs to be solved through bundle start levels.\r\n\r\nAnother change I made is the check whether a bundle contains resources. It used to check the classpath in order to also regard fragments correctly. Unfortunately, this brought up many false positives, which potentially has quite some bad impact on startup time. Now it is only checked that the bundle contains the according folder (like \"ESH-INF/thing\" or \"ESH-INF/config\"). This means that if a fragment contains files in those folders, the host bundle should at least have an empty folder as well.\r\n\r\nI also remove the accidential dependency from core.xml to core.thing.\r\n\r\nfixes https://github.com/eclipse/smarthome/issues/1796\r\nfixes https://github.com/eclipse/smarthome/issues/1847\r\n\r\nSigned-off-by: Kai Kreuzer <kai@openhab.org>","created_at":"2016-07-12T16:47:04Z","updated_at":"2016-07-13T10:23:09Z","closed_at":"2016-07-13T10:23:09Z","merged_at":"2016-07-13T10:23:09Z","merge_commit_sha":"6c5916cf5430e9d004bd9b3cfd09fd76f502585b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/smarthome/pulls/1856/commits","review_comments_url":"https://api.github.com/repos/eclipse/smarthome/pulls/1856/comments","review_comment_url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/smarthome/issues/1856/comments","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/4cf024262bbb1fcba88f5155463e340b48255cd5","head":{"label":"kaikreuzer:th","ref":"th","sha":"4cf024262bbb1fcba88f5155463e340b48255cd5","user":{"login":"kaikreuzer","id":3244965,"avatar_url":"https://avatars.githubusercontent.com/u/3244965?v=3","gravatar_id":"","url":"https://api.github.com/users/kaikreuzer","html_url":"https://github.com/kaikreuzer","followers_url":"https://api.github.com/users/kaikreuzer/followers","following_url":"https://api.github.com/users/kaikreuzer/following{/other_user}","gists_url":"https://api.github.com/users/kaikreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikreuzer/subscriptions","organizations_url":"https://api.github.com/users/kaikreuzer/orgs","repos_url":"https://api.github.com/users/kaikreuzer/repos","events_url":"https://api.github.com/users/kaikreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/kaikreuzer/received_events","type":"User","site_admin":false},"repo":{"id":15803647,"name":"smarthome","full_name":"kaikreuzer/smarthome","owner":{"login":"kaikreuzer","id":3244965,"avatar_url":"https://avatars.githubusercontent.com/u/3244965?v=3","gravatar_id":"","url":"https://api.github.com/users/kaikreuzer","html_url":"https://github.com/kaikreuzer","followers_url":"https://api.github.com/users/kaikreuzer/followers","following_url":"https://api.github.com/users/kaikreuzer/following{/other_user}","gists_url":"https://api.github.com/users/kaikreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikreuzer/subscriptions","organizations_url":"https://api.github.com/users/kaikreuzer/orgs","repos_url":"https://api.github.com/users/kaikreuzer/repos","events_url":"https://api.github.com/users/kaikreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/kaikreuzer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaikreuzer/smarthome","description":"Eclipse SmartHome project","fork":true,"url":"https://api.github.com/repos/kaikreuzer/smarthome","forks_url":"https://api.github.com/repos/kaikreuzer/smarthome/forks","keys_url":"https://api.github.com/repos/kaikreuzer/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaikreuzer/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaikreuzer/smarthome/teams","hooks_url":"https://api.github.com/repos/kaikreuzer/smarthome/hooks","issue_events_url":"https://api.github.com/repos/kaikreuzer/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/kaikreuzer/smarthome/events","assignees_url":"https://api.github.com/repos/kaikreuzer/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/kaikreuzer/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/kaikreuzer/smarthome/tags","blobs_url":"https://api.github.com/repos/kaikreuzer/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaikreuzer/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaikreuzer/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaikreuzer/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaikreuzer/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/kaikreuzer/smarthome/languages","stargazers_url":"https://api.github.com/repos/kaikreuzer/smarthome/stargazers","contributors_url":"https://api.github.com/repos/kaikreuzer/smarthome/contributors","subscribers_url":"https://api.github.com/repos/kaikreuzer/smarthome/subscribers","subscription_url":"https://api.github.com/repos/kaikreuzer/smarthome/subscription","commits_url":"https://api.github.com/repos/kaikreuzer/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaikreuzer/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaikreuzer/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaikreuzer/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaikreuzer/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/kaikreuzer/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaikreuzer/smarthome/merges","archive_url":"https://api.github.com/repos/kaikreuzer/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaikreuzer/smarthome/downloads","issues_url":"https://api.github.com/repos/kaikreuzer/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/kaikreuzer/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/kaikreuzer/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/kaikreuzer/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaikreuzer/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/kaikreuzer/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/kaikreuzer/smarthome/deployments","created_at":"2014-01-10T16:46:33Z","updated_at":"2016-02-27T18:28:33Z","pushed_at":"2016-07-13T09:10:33Z","git_url":"git://github.com/kaikreuzer/smarthome.git","ssh_url":"git@github.com:kaikreuzer/smarthome.git","clone_url":"https://github.com/kaikreuzer/smarthome.git","svn_url":"https://github.com/kaikreuzer/smarthome","homepage":null,"size":21136,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"c362f8a5cbc5fa997e7f2ec5058eea2fdc419ee0","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":15778981,"name":"smarthome","full_name":"eclipse/smarthome","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/smarthome","description":"Eclipse SmartHome project","fork":false,"url":"https://api.github.com/repos/eclipse/smarthome","forks_url":"https://api.github.com/repos/eclipse/smarthome/forks","keys_url":"https://api.github.com/repos/eclipse/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/smarthome/teams","hooks_url":"https://api.github.com/repos/eclipse/smarthome/hooks","issue_events_url":"https://api.github.com/repos/eclipse/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/smarthome/events","assignees_url":"https://api.github.com/repos/eclipse/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/smarthome/tags","blobs_url":"https://api.github.com/repos/eclipse/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/smarthome/languages","stargazers_url":"https://api.github.com/repos/eclipse/smarthome/stargazers","contributors_url":"https://api.github.com/repos/eclipse/smarthome/contributors","subscribers_url":"https://api.github.com/repos/eclipse/smarthome/subscribers","subscription_url":"https://api.github.com/repos/eclipse/smarthome/subscription","commits_url":"https://api.github.com/repos/eclipse/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/smarthome/merges","archive_url":"https://api.github.com/repos/eclipse/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/smarthome/downloads","issues_url":"https://api.github.com/repos/eclipse/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/smarthome/deployments","created_at":"2014-01-09T20:47:19Z","updated_at":"2016-07-12T12:10:16Z","pushed_at":"2016-07-13T10:23:09Z","git_url":"git://github.com/eclipse/smarthome.git","ssh_url":"git@github.com:eclipse/smarthome.git","clone_url":"https://github.com/eclipse/smarthome.git","svn_url":"https://github.com/eclipse/smarthome","homepage":null,"size":33005,"stargazers_count":322,"watchers_count":322,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":315,"mirror_url":null,"open_issues_count":195,"forks":315,"open_issues":195,"watchers":322,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/1856"},"html":{"href":"https://github.com/eclipse/smarthome/pull/1856"},"issue":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/1856"},"comments":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/1856/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/1856/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/1856/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/smarthome/statuses/4cf024262bbb1fcba88f5155463e340b48255cd5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"maggu2810","id":204670,"avatar_url":"https://avatars.githubusercontent.com/u/204670?v=3","gravatar_id":"","url":"https://api.github.com/users/maggu2810","html_url":"https://github.com/maggu2810","followers_url":"https://api.github.com/users/maggu2810/followers","following_url":"https://api.github.com/users/maggu2810/following{/other_user}","gists_url":"https://api.github.com/users/maggu2810/gists{/gist_id}","starred_url":"https://api.github.com/users/maggu2810/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maggu2810/subscriptions","organizations_url":"https://api.github.com/users/maggu2810/orgs","repos_url":"https://api.github.com/users/maggu2810/repos","events_url":"https://api.github.com/users/maggu2810/events{/privacy}","received_events_url":"https://api.github.com/users/maggu2810/received_events","type":"User","site_admin":false},"comments":12,"review_comments":0,"commits":1,"additions":188,"deletions":152,"changed_files":16}}
{"actor":{"display_login":"maggu2810"}}