{"action":"created","issue":{"url":"https://api.github.com/repos/opendevise/bespoke-prism/issues/7","repository_url":"https://api.github.com/repos/opendevise/bespoke-prism","labels_url":"https://api.github.com/repos/opendevise/bespoke-prism/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/opendevise/bespoke-prism/issues/7/comments","events_url":"https://api.github.com/repos/opendevise/bespoke-prism/issues/7/events","html_url":"https://github.com/opendevise/bespoke-prism/issues/7","id":166841370,"number":7,"title":"Should we move deps into dev deps?","user":{"login":"hsablonniere","id":236342,"avatar_url":"https://avatars.githubusercontent.com/u/236342?v=3","gravatar_id":"","url":"https://api.github.com/users/hsablonniere","html_url":"https://github.com/hsablonniere","followers_url":"https://api.github.com/users/hsablonniere/followers","following_url":"https://api.github.com/users/hsablonniere/following{/other_user}","gists_url":"https://api.github.com/users/hsablonniere/gists{/gist_id}","starred_url":"https://api.github.com/users/hsablonniere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsablonniere/subscriptions","organizations_url":"https://api.github.com/users/hsablonniere/orgs","repos_url":"https://api.github.com/users/hsablonniere/repos","events_url":"https://api.github.com/users/hsablonniere/events{/privacy}","received_events_url":"https://api.github.com/users/hsablonniere/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-21T15:00:45Z","updated_at":"2016-08-15T06:59:53Z","closed_at":null,"body":"The package published on NPM already contains the dependencies like `prism` or `insert-css` bundled in the minified. Maybe we should move all the deps into devDeps?\r\n\r\n@mojavelinux WDYT?"},"comment":{"url":"https://api.github.com/repos/opendevise/bespoke-prism/issues/comments/239740669","html_url":"https://github.com/opendevise/bespoke-prism/issues/7#issuecomment-239740669","issue_url":"https://api.github.com/repos/opendevise/bespoke-prism/issues/7","id":239740669,"user":{"login":"mojavelinux","id":79351,"avatar_url":"https://avatars.githubusercontent.com/u/79351?v=3","gravatar_id":"","url":"https://api.github.com/users/mojavelinux","html_url":"https://github.com/mojavelinux","followers_url":"https://api.github.com/users/mojavelinux/followers","following_url":"https://api.github.com/users/mojavelinux/following{/other_user}","gists_url":"https://api.github.com/users/mojavelinux/gists{/gist_id}","starred_url":"https://api.github.com/users/mojavelinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mojavelinux/subscriptions","organizations_url":"https://api.github.com/users/mojavelinux/orgs","repos_url":"https://api.github.com/users/mojavelinux/repos","events_url":"https://api.github.com/users/mojavelinux/events{/privacy}","received_events_url":"https://api.github.com/users/mojavelinux/received_events","type":"User","site_admin":false},"created_at":"2016-08-15T06:59:53Z","updated_at":"2016-08-15T06:59:53Z","body":"Exactly. According to the Browserify docs, the main field should point to the uncompiled JavaScript at `./lib/bespoke-prism.js`. Browserify then handles the compilation in the user's build script. However, that means any libraries which the module requires must be declared under `dependencies` (or else they have to be declared explicitly in the user's package.json).\r\n\r\nAs it stands now, the dependencies are redundant since the main field points to the compiled (bundled) JavaScript.\r\n\r\n> include the minified `<script>` tag manually with every dependencies bundled in it.\r\n\r\nI was recently alerted to https://npmcdn.com. It encourages you not to put the dist folder in the git repository. Instead, you package it inside the npm module and publish it along with the package. npmcdn then allows you to reference that file through its proxy.\r\n\r\nI find it incredibly annoying to have to check in the dist file for every change to the module, so I think we should stop doing that. The compiled JavaScript file is a build artifact and build artifacts don't belong in the git repository."}}
{"actor":{"display_login":"mojavelinux"}}