{"action":"created","comment":{"url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/comments/83701552","pull_request_review_id":4526516,"id":83701552,"diff_hunk":"@@ -162,13 +175,13 @@ public function generateClass()\n       $options[\\'classmap\\'][$key] = $value;\n     }\n   }' . PHP_EOL;\n-        $source .= '  $options = array_merge(' . var_export($this->config->get('soapClientOptions'), true) . ', $options);' . PHP_EOL;\n+        $source .= '  $options = array_merge(' . $this->adjustArrayNotation(var_export($this->config->get('soapClientOptions'), true)) . ', $options);' . PHP_EOL;","path":"src/Service.php","position":29,"original_position":29,"commit_id":"d4a5da0a542975ef0330e77fcda0f23486e133ee","original_commit_id":"d4a5da0a542975ef0330e77fcda0f23486e133ee","user":{"login":"kasperg","id":73966,"avatar_url":"https://avatars.githubusercontent.com/u/73966?v=3","gravatar_id":"","url":"https://api.github.com/users/kasperg","html_url":"https://github.com/kasperg","followers_url":"https://api.github.com/users/kasperg/followers","following_url":"https://api.github.com/users/kasperg/following{/other_user}","gists_url":"https://api.github.com/users/kasperg/gists{/gist_id}","starred_url":"https://api.github.com/users/kasperg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasperg/subscriptions","organizations_url":"https://api.github.com/users/kasperg/orgs","repos_url":"https://api.github.com/users/kasperg/repos","events_url":"https://api.github.com/users/kasperg/events{/privacy}","received_events_url":"https://api.github.com/users/kasperg/received_events","type":"User","site_admin":false},"body":"Idea/Note: If we care about code style in the generated code `var_export()` is not the optimal solution. We should consider using https://github.com/Riimu/Kit-PHPEncoder or the like.","created_at":"2016-10-17T18:13:41Z","updated_at":"2016-10-17T18:17:27Z","html_url":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator/pull/294#discussion_r83701552","pull_request_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/294","_links":{"self":{"href":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/comments/83701552"},"html":{"href":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator/pull/294#discussion_r83701552"},"pull_request":{"href":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/294"}}},"pull_request":{"url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/294","id":87112593,"html_url":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator/pull/294","diff_url":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator/pull/294.diff","patch_url":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator/pull/294.patch","issue_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/issues/294","number":294,"state":"open","locked":false,"title":"Php 5.4+ array notation","user":{"login":"thomasphansen","id":5396791,"avatar_url":"https://avatars.githubusercontent.com/u/5396791?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasphansen","html_url":"https://github.com/thomasphansen","followers_url":"https://api.github.com/users/thomasphansen/followers","following_url":"https://api.github.com/users/thomasphansen/following{/other_user}","gists_url":"https://api.github.com/users/thomasphansen/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasphansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasphansen/subscriptions","organizations_url":"https://api.github.com/users/thomasphansen/orgs","repos_url":"https://api.github.com/users/thomasphansen/repos","events_url":"https://api.github.com/users/thomasphansen/events{/privacy}","received_events_url":"https://api.github.com/users/thomasphansen/received_events","type":"User","site_admin":false},"body":"This small push will allow wsdl2phpgenerator to render arrays using the bracket notation. I was originally calling it \"php7Arrays\", but since this feature is available since version 5.4, I renamed the configuration option to 'bracketedArrays': when set to true (the default is false, to preserve backward compatibility), all the arrays created inside the Service class will use the new bracket notation.","created_at":"2016-09-28T12:47:29Z","updated_at":"2016-10-17T18:17:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cb54d4b7673e359128d2870d368123a04fe0db4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/294/commits","review_comments_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/294/comments","review_comment_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/issues/294/comments","statuses_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/statuses/d4a5da0a542975ef0330e77fcda0f23486e133ee","head":{"label":"thomasphansen:master","ref":"master","sha":"d4a5da0a542975ef0330e77fcda0f23486e133ee","user":{"login":"thomasphansen","id":5396791,"avatar_url":"https://avatars.githubusercontent.com/u/5396791?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasphansen","html_url":"https://github.com/thomasphansen","followers_url":"https://api.github.com/users/thomasphansen/followers","following_url":"https://api.github.com/users/thomasphansen/following{/other_user}","gists_url":"https://api.github.com/users/thomasphansen/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasphansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasphansen/subscriptions","organizations_url":"https://api.github.com/users/thomasphansen/orgs","repos_url":"https://api.github.com/users/thomasphansen/repos","events_url":"https://api.github.com/users/thomasphansen/events{/privacy}","received_events_url":"https://api.github.com/users/thomasphansen/received_events","type":"User","site_admin":false},"repo":{"id":68908782,"name":"wsdl2phpgenerator","full_name":"thomasphansen/wsdl2phpgenerator","owner":{"login":"thomasphansen","id":5396791,"avatar_url":"https://avatars.githubusercontent.com/u/5396791?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasphansen","html_url":"https://github.com/thomasphansen","followers_url":"https://api.github.com/users/thomasphansen/followers","following_url":"https://api.github.com/users/thomasphansen/following{/other_user}","gists_url":"https://api.github.com/users/thomasphansen/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasphansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasphansen/subscriptions","organizations_url":"https://api.github.com/users/thomasphansen/orgs","repos_url":"https://api.github.com/users/thomasphansen/repos","events_url":"https://api.github.com/users/thomasphansen/events{/privacy}","received_events_url":"https://api.github.com/users/thomasphansen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thomasphansen/wsdl2phpgenerator","description":"Simple utility and class library for generating php classes from a wsdl file.","fork":true,"url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator","forks_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/forks","keys_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/teams","hooks_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/hooks","issue_events_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/issues/events{/number}","events_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/events","assignees_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/assignees{/user}","branches_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/branches{/branch}","tags_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/tags","blobs_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/statuses/{sha}","languages_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/languages","stargazers_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/stargazers","contributors_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/contributors","subscribers_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/subscribers","subscription_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/subscription","commits_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/issues/comments{/number}","contents_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/contents/{+path}","compare_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/merges","archive_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/downloads","issues_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/issues{/number}","pulls_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/pulls{/number}","milestones_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/milestones{/number}","notifications_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/labels{/name}","releases_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/releases{/id}","deployments_url":"https://api.github.com/repos/thomasphansen/wsdl2phpgenerator/deployments","created_at":"2016-09-22T10:02:34Z","updated_at":"2016-09-22T10:02:35Z","pushed_at":"2016-09-28T14:00:58Z","git_url":"git://github.com/thomasphansen/wsdl2phpgenerator.git","ssh_url":"git@github.com:thomasphansen/wsdl2phpgenerator.git","clone_url":"https://github.com/thomasphansen/wsdl2phpgenerator.git","svn_url":"https://github.com/thomasphansen/wsdl2phpgenerator","homepage":"http://wsdl2phpgenerator.github.io/wsdl2phpgenerator","size":3568,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wsdl2phpgenerator:master","ref":"master","sha":"8abda9eb08c97beb8b4ab363cf46e13eb0fda798","user":{"login":"wsdl2phpgenerator","id":5506864,"avatar_url":"https://avatars.githubusercontent.com/u/5506864?v=3","gravatar_id":"","url":"https://api.github.com/users/wsdl2phpgenerator","html_url":"https://github.com/wsdl2phpgenerator","followers_url":"https://api.github.com/users/wsdl2phpgenerator/followers","following_url":"https://api.github.com/users/wsdl2phpgenerator/following{/other_user}","gists_url":"https://api.github.com/users/wsdl2phpgenerator/gists{/gist_id}","starred_url":"https://api.github.com/users/wsdl2phpgenerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsdl2phpgenerator/subscriptions","organizations_url":"https://api.github.com/users/wsdl2phpgenerator/orgs","repos_url":"https://api.github.com/users/wsdl2phpgenerator/repos","events_url":"https://api.github.com/users/wsdl2phpgenerator/events{/privacy}","received_events_url":"https://api.github.com/users/wsdl2phpgenerator/received_events","type":"Organization","site_admin":false},"repo":{"id":502867,"name":"wsdl2phpgenerator","full_name":"wsdl2phpgenerator/wsdl2phpgenerator","owner":{"login":"wsdl2phpgenerator","id":5506864,"avatar_url":"https://avatars.githubusercontent.com/u/5506864?v=3","gravatar_id":"","url":"https://api.github.com/users/wsdl2phpgenerator","html_url":"https://github.com/wsdl2phpgenerator","followers_url":"https://api.github.com/users/wsdl2phpgenerator/followers","following_url":"https://api.github.com/users/wsdl2phpgenerator/following{/other_user}","gists_url":"https://api.github.com/users/wsdl2phpgenerator/gists{/gist_id}","starred_url":"https://api.github.com/users/wsdl2phpgenerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsdl2phpgenerator/subscriptions","organizations_url":"https://api.github.com/users/wsdl2phpgenerator/orgs","repos_url":"https://api.github.com/users/wsdl2phpgenerator/repos","events_url":"https://api.github.com/users/wsdl2phpgenerator/events{/privacy}","received_events_url":"https://api.github.com/users/wsdl2phpgenerator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator","description":"Simple utility and class library for generating php classes from a wsdl file.","fork":false,"url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator","forks_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/forks","keys_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/teams","hooks_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/hooks","issue_events_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/issues/events{/number}","events_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/events","assignees_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/assignees{/user}","branches_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/branches{/branch}","tags_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/tags","blobs_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/git/refs{/sha}","trees_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/statuses/{sha}","languages_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/languages","stargazers_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/stargazers","contributors_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/contributors","subscribers_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/subscribers","subscription_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/subscription","commits_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/commits{/sha}","git_commits_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/git/commits{/sha}","comments_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/comments{/number}","issue_comment_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/issues/comments{/number}","contents_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/contents/{+path}","compare_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/merges","archive_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/downloads","issues_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/issues{/number}","pulls_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls{/number}","milestones_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/milestones{/number}","notifications_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/labels{/name}","releases_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/releases{/id}","deployments_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/deployments","created_at":"2010-02-04T20:54:41Z","updated_at":"2016-10-14T14:13:12Z","pushed_at":"2016-10-14T06:12:57Z","git_url":"git://github.com/wsdl2phpgenerator/wsdl2phpgenerator.git","ssh_url":"git@github.com:wsdl2phpgenerator/wsdl2phpgenerator.git","clone_url":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator.git","svn_url":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator","homepage":"http://wsdl2phpgenerator.github.io/wsdl2phpgenerator","size":4188,"stargazers_count":484,"watchers_count":484,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":158,"mirror_url":null,"open_issues_count":73,"forks":158,"open_issues":73,"watchers":484,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/294"},"html":{"href":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator/pull/294"},"issue":{"href":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/issues/294"},"comments":{"href":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/issues/294/comments"},"review_comments":{"href":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/294/comments"},"review_comment":{"href":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/294/commits"},"statuses":{"href":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/statuses/d4a5da0a542975ef0330e77fcda0f23486e133ee"}}}}
{"actor":{"display_login":"kasperg"}}