{"action":"created","issue":{"url":"https://api.github.com/repos/electron/electron/issues/7993","repository_url":"https://api.github.com/repos/electron/electron","labels_url":"https://api.github.com/repos/electron/electron/issues/7993/labels{/name}","comments_url":"https://api.github.com/repos/electron/electron/issues/7993/comments","events_url":"https://api.github.com/repos/electron/electron/issues/7993/events","html_url":"https://github.com/electron/electron/pull/7993","id":189896847,"number":7993,"title":"Prevent systemPreferences.getUserDefault crash for missing arrays/dictionaries","user":{"login":"kevinsawicki","id":671378,"avatar_url":"https://avatars.githubusercontent.com/u/671378?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinsawicki","html_url":"https://github.com/kevinsawicki","followers_url":"https://api.github.com/users/kevinsawicki/followers","following_url":"https://api.github.com/users/kevinsawicki/following{/other_user}","gists_url":"https://api.github.com/users/kevinsawicki/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinsawicki/subscriptions","organizations_url":"https://api.github.com/users/kevinsawicki/orgs","repos_url":"https://api.github.com/users/kevinsawicki/repos","events_url":"https://api.github.com/users/kevinsawicki/events{/privacy}","received_events_url":"https://api.github.com/users/kevinsawicki/received_events","type":"User","site_admin":true},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-17T00:34:43Z","updated_at":"2016-11-17T00:36:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/electron/electron/pulls/7993","html_url":"https://github.com/electron/electron/pull/7993","diff_url":"https://github.com/electron/electron/pull/7993.diff","patch_url":"https://github.com/electron/electron/pull/7993.patch"},"body":"The `NSArrayToListValue` and `NSDictionaryToDictionaryValue` return null pointers when the given value is null which is the case when the requested user default is not an array or dictionary.\r\n\r\nThis pull requests returns empty array/objects instead of crashing when this happens.\r\n\r\nAlso adds specs for the values returned when the key has no default."},"comment":{"url":"https://api.github.com/repos/electron/electron/issues/comments/261118787","html_url":"https://github.com/electron/electron/pull/7993#issuecomment-261118787","issue_url":"https://api.github.com/repos/electron/electron/issues/7993","id":261118787,"user":{"login":"kevinsawicki","id":671378,"avatar_url":"https://avatars.githubusercontent.com/u/671378?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinsawicki","html_url":"https://github.com/kevinsawicki","followers_url":"https://api.github.com/users/kevinsawicki/followers","following_url":"https://api.github.com/users/kevinsawicki/following{/other_user}","gists_url":"https://api.github.com/users/kevinsawicki/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinsawicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinsawicki/subscriptions","organizations_url":"https://api.github.com/users/kevinsawicki/orgs","repos_url":"https://api.github.com/users/kevinsawicki/repos","events_url":"https://api.github.com/users/kevinsawicki/events{/privacy}","received_events_url":"https://api.github.com/users/kevinsawicki/received_events","type":"User","site_admin":true},"created_at":"2016-11-17T00:36:54Z","updated_at":"2016-11-17T00:36:54Z","body":"> Would it be better to return undefined or null instead?\r\n\r\nI thought about that a bit, it looks like  numbers and booleans return valid values instead of undefined/null when their missing so empty array/object seemed to make it consistent with that."}}
{"actor":{"display_login":"kevinsawicki"}}