{"action":"created","issue":{"url":"https://api.github.com/repos/Wikia/app/issues/11735","repository_url":"https://api.github.com/repos/Wikia/app","labels_url":"https://api.github.com/repos/Wikia/app/issues/11735/labels{/name}","comments_url":"https://api.github.com/repos/Wikia/app/issues/11735/comments","events_url":"https://api.github.com/repos/Wikia/app/issues/11735/events","html_url":"https://github.com/Wikia/app/pull/11735","id":185649971,"number":11735,"title":"SUS-1203: logging in ConsulUrlProvider, sending requests to different phalanx instances while retry","user":{"login":"rybmat","id":1534495,"avatar_url":"https://avatars.githubusercontent.com/u/1534495?v=3","gravatar_id":"","url":"https://api.github.com/users/rybmat","html_url":"https://github.com/rybmat","followers_url":"https://api.github.com/users/rybmat/followers","following_url":"https://api.github.com/users/rybmat/following{/other_user}","gists_url":"https://api.github.com/users/rybmat/gists{/gist_id}","starred_url":"https://api.github.com/users/rybmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rybmat/subscriptions","organizations_url":"https://api.github.com/users/rybmat/orgs","repos_url":"https://api.github.com/users/rybmat/repos","events_url":"https://api.github.com/users/rybmat/events{/privacy}","received_events_url":"https://api.github.com/users/rybmat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-27T12:07:04Z","updated_at":"2016-10-27T12:07:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/11735","html_url":"https://github.com/Wikia/app/pull/11735","diff_url":"https://github.com/Wikia/app/pull/11735.diff","patch_url":"https://github.com/Wikia/app/pull/11735.patch"},"body":"After releasing https://github.com/Wikia/app/pull/11719, it turned out that sometimes url to phalanx instance is not returned from consul. This pull request introduces fetching phalanx address from consul every time when there is a need to send request to phalanx. Additionally logging in ConsulUrlProvider is added\r\n\r\n//cc @macbre @mixth-sense \r\n"},"comment":{"url":"https://api.github.com/repos/Wikia/app/issues/comments/256622971","html_url":"https://github.com/Wikia/app/pull/11735#issuecomment-256622971","issue_url":"https://api.github.com/repos/Wikia/app/issues/11735","id":256622971,"user":{"login":"WikiaTech","id":13279985,"avatar_url":"https://avatars.githubusercontent.com/u/13279985?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiaTech","html_url":"https://github.com/WikiaTech","followers_url":"https://api.github.com/users/WikiaTech/followers","following_url":"https://api.github.com/users/WikiaTech/following{/other_user}","gists_url":"https://api.github.com/users/WikiaTech/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiaTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiaTech/subscriptions","organizations_url":"https://api.github.com/users/WikiaTech/orgs","repos_url":"https://api.github.com/users/WikiaTech/repos","events_url":"https://api.github.com/users/WikiaTech/events{/privacy}","received_events_url":"https://api.github.com/users/WikiaTech/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T12:07:30Z","updated_at":"2016-10-27T12:07:30Z","body":"SonarQube analysis reported 17 issues\n* ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) 5 major\n* ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) 9 minor\n* ![INFO](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-info.png) 3 info\n\nWatch the comments in this conversation to review them.\n\n#### Top 10 extra issues\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [PhalanxService.class.php#L204](https://github.com/Wikia/app/blob/7329010ed4a891a0b807bc91629cefdfd0d75200/extensions/wikia/PhalanxII/services/PhalanxService.class.php#L204): Refactor this code to not nest more than 4 \"if\", \"for\", \"while\", \"switch\" and \"try\" statements. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://10.8.74.32:9000/coding_rules#rule_key=php%3AS134)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [PhalanxService.class.php#L279](https://github.com/Wikia/app/blob/7329010ed4a891a0b807bc91629cefdfd0d75200/extensions/wikia/PhalanxII/services/PhalanxService.class.php#L279): Reduce this \"switch/case\" number of lines from 17 to at most 10, for example by extracting code into function. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://10.8.74.32:9000/coding_rules#rule_key=php%3AS1151)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [PhalanxService.class.php#L286](https://github.com/Wikia/app/blob/7329010ed4a891a0b807bc91629cefdfd0d75200/extensions/wikia/PhalanxII/services/PhalanxService.class.php#L286): Refactor this code to not nest more than 4 \"if\", \"for\", \"while\", \"switch\" and \"try\" statements. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://10.8.74.32:9000/coding_rules#rule_key=php%3AS134)\n1. ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [PhalanxService.class.php#L68](https://github.com/Wikia/app/blob/7329010ed4a891a0b807bc91629cefdfd0d75200/extensions/wikia/PhalanxII/services/PhalanxService.class.php#L68): Define a constant instead of duplicating this literal \"status\" 4 times. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://10.8.74.32:9000/coding_rules#rule_key=php%3AS1192)\n1. ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [PhalanxService.class.php#L97](https://github.com/Wikia/app/blob/7329010ed4a891a0b807bc91629cefdfd0d75200/extensions/wikia/PhalanxII/services/PhalanxService.class.php#L97): Define a constant instead of duplicating this literal \"match\" 4 times. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://10.8.74.32:9000/coding_rules#rule_key=php%3AS1192)\n1. ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [PhalanxService.class.php#L188](https://github.com/Wikia/app/blob/7329010ed4a891a0b807bc91629cefdfd0d75200/extensions/wikia/PhalanxII/services/PhalanxService.class.php#L188): Define a constant instead of duplicating this literal \"exception\" 3 times. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://10.8.74.32:9000/coding_rules#rule_key=php%3AS1192)\n1. ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [PhalanxService.class.php#L241](https://github.com/Wikia/app/blob/7329010ed4a891a0b807bc91629cefdfd0d75200/extensions/wikia/PhalanxII/services/PhalanxService.class.php#L241): Define a constant instead of duplicating this literal \"phalanxUrl\" 3 times. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://10.8.74.32:9000/coding_rules#rule_key=php%3AS1192)\n1. ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [PhalanxService.class.php#L243](https://github.com/Wikia/app/blob/7329010ed4a891a0b807bc91629cefdfd0d75200/extensions/wikia/PhalanxII/services/PhalanxService.class.php#L243): Define a constant instead of duplicating this literal \"tries\" 3 times. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://10.8.74.32:9000/coding_rules#rule_key=php%3AS1192)\n1. ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [PhalanxService.class.php#L274](https://github.com/Wikia/app/blob/7329010ed4a891a0b807bc91629cefdfd0d75200/extensions/wikia/PhalanxII/services/PhalanxService.class.php#L274): Remove the literal \"false\" boolean value. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://10.8.74.32:9000/coding_rules#rule_key=php%3AS1125)\n1. ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [PhalanxService.class.php#L277](https://github.com/Wikia/app/blob/7329010ed4a891a0b807bc91629cefdfd0d75200/extensions/wikia/PhalanxII/services/PhalanxService.class.php#L277): Remove the literal \"false\" boolean value. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://10.8.74.32:9000/coding_rules#rule_key=php%3AS1125)\n"}}
{"actor":{"display_login":"WikiaTech"}}