{"action":"created","issue":{"url":"https://api.github.com/repos/opencontainers/runc/issues/1121","repository_url":"https://api.github.com/repos/opencontainers/runc","labels_url":"https://api.github.com/repos/opencontainers/runc/issues/1121/labels{/name}","comments_url":"https://api.github.com/repos/opencontainers/runc/issues/1121/comments","events_url":"https://api.github.com/repos/opencontainers/runc/issues/1121/events","html_url":"https://github.com/opencontainers/runc/pull/1121","id":183771739,"number":1121,"title":"tests: mask: use test paths rather than /sys","user":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/opencontainers/runc/labels/status/0-triage","name":"status/0-triage","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-18T18:50:46Z","updated_at":"2016-10-18T18:53:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/1121","html_url":"https://github.com/opencontainers/runc/pull/1121","diff_url":"https://github.com/opencontainers/runc/pull/1121.diff","patch_url":"https://github.com/opencontainers/runc/pull/1121.patch"},"body":"In certain circumstances (such as the rootless containers patchset), it\r\nis not possible to test things using /sys/firmware. In addition, we\r\nshould be testing our own functionality rather than testing protection\r\nagainst /sys attacks (for which the system might already have extra\r\nprotections).\r\n\r\nInstead, just make some fake paths in the rootfs that we then mask.\r\nOddly I noticed that one of the errors changed when doing this (because\r\nbefore we tested removing a file from /sys/firmware which is -EPERM). So\r\nthe old test was broken.\r\n\r\nFixes: 53179559a15f5 (\"MaskPaths: support directory\")\r\nFixes: #1068\r\nSigned-off-by: Aleksa Sarai <asarai@suse.de>"},"comment":{"url":"https://api.github.com/repos/opencontainers/runc/issues/comments/254603948","html_url":"https://github.com/opencontainers/runc/pull/1121#issuecomment-254603948","issue_url":"https://api.github.com/repos/opencontainers/runc/issues/1121","id":254603948,"user":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"created_at":"2016-10-18T18:53:54Z","updated_at":"2016-10-18T18:53:54Z","body":"Tests will fail because of #1120."}}
{"actor":{"display_login":"cyphar"}}