{"action":"created","issue":{"url":"https://api.github.com/repos/feedhenry/fh-js-sdk/issues/177","repository_url":"https://api.github.com/repos/feedhenry/fh-js-sdk","labels_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/issues/177/labels{/name}","comments_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/issues/177/comments","events_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/issues/177/events","html_url":"https://github.com/feedhenry/fh-js-sdk/pull/177","id":168007053,"number":177,"title":"remove __fh from body/query (issue #149)","user":{"login":"evanshortiss","id":1303687,"avatar_url":"https://avatars.githubusercontent.com/u/1303687?v=3","gravatar_id":"","url":"https://api.github.com/users/evanshortiss","html_url":"https://github.com/evanshortiss","followers_url":"https://api.github.com/users/evanshortiss/followers","following_url":"https://api.github.com/users/evanshortiss/following{/other_user}","gists_url":"https://api.github.com/users/evanshortiss/gists{/gist_id}","starred_url":"https://api.github.com/users/evanshortiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanshortiss/subscriptions","organizations_url":"https://api.github.com/users/evanshortiss/orgs","repos_url":"https://api.github.com/users/evanshortiss/repos","events_url":"https://api.github.com/users/evanshortiss/events{/privacy}","received_events_url":"https://api.github.com/users/evanshortiss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-28T03:34:38Z","updated_at":"2016-08-05T15:05:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/feedhenry/fh-js-sdk/pulls/177","html_url":"https://github.com/feedhenry/fh-js-sdk/pull/177","diff_url":"https://github.com/feedhenry/fh-js-sdk/pull/177.diff","patch_url":"https://github.com/feedhenry/fh-js-sdk/pull/177.patch"},"body":"This fixes #149 by removing the `__fh` property from req.query and req.body. These values are already in headers so this should be fine 👍 "},"comment":{"url":"https://api.github.com/repos/feedhenry/fh-js-sdk/issues/comments/237875134","html_url":"https://github.com/feedhenry/fh-js-sdk/pull/177#issuecomment-237875134","issue_url":"https://api.github.com/repos/feedhenry/fh-js-sdk/issues/177","id":237875134,"user":{"login":"wei-lee","id":912729,"avatar_url":"https://avatars.githubusercontent.com/u/912729?v=3","gravatar_id":"","url":"https://api.github.com/users/wei-lee","html_url":"https://github.com/wei-lee","followers_url":"https://api.github.com/users/wei-lee/followers","following_url":"https://api.github.com/users/wei-lee/following{/other_user}","gists_url":"https://api.github.com/users/wei-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/wei-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wei-lee/subscriptions","organizations_url":"https://api.github.com/users/wei-lee/orgs","repos_url":"https://api.github.com/users/wei-lee/repos","events_url":"https://api.github.com/users/wei-lee/events{/privacy}","received_events_url":"https://api.github.com/users/wei-lee/received_events","type":"User","site_admin":false},"created_at":"2016-08-05T15:05:20Z","updated_at":"2016-08-05T15:05:20Z","body":"I would love to remove it. I believe the reasons we have it in the request body are:\r\n\r\n1. to work with jsonp. You can set headers for jsonp.\r\n2. to work with IE8. I believe the Cross Domain Request in IE8 doesn't allow setting headers either.\r\n\r\nBasicly it is a hack to work with different XHR in different browsers 3-4 years ago. Today I believe most of the modern browsers don't have those problem anymore, and I would love to remove this code.\r\n\r\nIf it is still a requirement to support jsonp and IE8, perhaps we can at least only add `__fh` part for those 2 scenarios?\r\n\r\n@johnfriz @conoro WDYT?\r\n"}}
{"actor":{"display_login":"wei-lee"}}