{"action":"created","issue":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/1046","repository_url":"https://api.github.com/repos/Homebrew/homebrew-core","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/1046/labels{/name}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/1046/comments","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/1046/events","html_url":"https://github.com/Homebrew/homebrew-core/pull/1046","id":153994090,"number":1046,"title":"h2o 1.7.2","user":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":30,"created_at":"2016-05-10T12:27:58Z","updated_at":"2016-05-17T18:50:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/1046","html_url":"https://github.com/Homebrew/homebrew-core/pull/1046","diff_url":"https://github.com/Homebrew/homebrew-core/pull/1046.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/1046.patch"},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/homebrew-core/blob/master/.github/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [x] Have you built your formula locally prior to submission with `brew install <formula>` (where `<formula>` is the name of the formula you're submitting)?\r\n- [x] Does your submission pass `brew audit --strict --online <formula>` (after doing `brew install <formula>`)?\r\n\r\n-----\r\n\r\nNote that the security fix for LibreSSL upstream didn't impact Homebrew because we don't use the bundled LibreSSL library."},"comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments/219816471","html_url":"https://github.com/Homebrew/homebrew-core/pull/1046#issuecomment-219816471","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/1046","id":219816471,"user":{"login":"ilovezfs","id":5268928,"avatar_url":"https://avatars.githubusercontent.com/u/5268928?v=3","gravatar_id":"","url":"https://api.github.com/users/ilovezfs","html_url":"https://github.com/ilovezfs","followers_url":"https://api.github.com/users/ilovezfs/followers","following_url":"https://api.github.com/users/ilovezfs/following{/other_user}","gists_url":"https://api.github.com/users/ilovezfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ilovezfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilovezfs/subscriptions","organizations_url":"https://api.github.com/users/ilovezfs/orgs","repos_url":"https://api.github.com/users/ilovezfs/repos","events_url":"https://api.github.com/users/ilovezfs/events{/privacy}","received_events_url":"https://api.github.com/users/ilovezfs/received_events","type":"User","site_admin":false},"created_at":"2016-05-17T18:50:21Z","updated_at":"2016-05-17T18:50:21Z","body":"```\r\n    if MacOS::Xcode.without_clt? || (MacOS::Xcode.installed? && MacOS::Xcode.version.to_i >= 7)\r\n      self[\"MACOSX_DEPLOYMENT_TARGET\"] = MacOS.version.to_s\r\n      self[\"SDKROOT\"] = MacOS.sdk_path\r\n    end\r\n```\r\nI'm tempted to change this to\r\n\r\n```\r\n    if MacOS::Xcode.without_clt? || (MacOS::Xcode.installed? && MacOS::Xcode.version.to_i >= 7)\r\n      self[\"MACOSX_DEPLOYMENT_TARGET\"] = MacOS.version.to_s\r\n    end\r\n```\r\nand wait for the other class of bugs to show themselves, which can then be fixed with\r\n```\r\nENV[\"SDKROOT\"] = MacOS.sdk_path\r\n```\r\nat the top of `def install`, and make it opt-in as opposed to opt-out."}}