{"action":"created","comment":{"url":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/comments/81451376","pull_request_review_id":2432613,"id":81451376,"diff_hunk":"@@ -1,9 +1,23 @@\n // Package configenv implements a TransformationProvider that replaces objects on\n // the form: {$env: \"VAR\"} with the value of the environment variable VAR.\n+//\n+// An additional key 'type' may be given as {$env: \"VAR\", type: \"TYPE\"}, which\n+// determines how the environment variable value should be parsed. By default\n+// the TYPE is 'string', but the following types are supported:\n+//   - string, value is return as string (default),\n+//   - number, value is parsed a number,","path":"config/env/transform.go","position":8,"original_position":8,"commit_id":"5cf4d71ad3f313b6102471fb261cd239a35dd53d","original_commit_id":"5cf4d71ad3f313b6102471fb261cd239a35dd53d","user":{"login":"walac","id":611309,"avatar_url":"https://avatars.githubusercontent.com/u/611309?v=3","gravatar_id":"","url":"https://api.github.com/users/walac","html_url":"https://github.com/walac","followers_url":"https://api.github.com/users/walac/followers","following_url":"https://api.github.com/users/walac/following{/other_user}","gists_url":"https://api.github.com/users/walac/gists{/gist_id}","starred_url":"https://api.github.com/users/walac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walac/subscriptions","organizations_url":"https://api.github.com/users/walac/orgs","repos_url":"https://api.github.com/users/walac/repos","events_url":"https://api.github.com/users/walac/events{/privacy}","received_events_url":"https://api.github.com/users/walac/received_events","type":"User","site_admin":false},"body":"I think we should have different types for scalars and integers.","created_at":"2016-10-01T14:49:49Z","updated_at":"2016-10-01T15:01:02Z","html_url":"https://github.com/taskcluster/taskcluster-worker/pull/122#discussion_r81451376","pull_request_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/122","_links":{"self":{"href":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/comments/81451376"},"html":{"href":"https://github.com/taskcluster/taskcluster-worker/pull/122#discussion_r81451376"},"pull_request":{"href":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/122"}}},"pull_request":{"url":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/122","id":87573994,"html_url":"https://github.com/taskcluster/taskcluster-worker/pull/122","diff_url":"https://github.com/taskcluster/taskcluster-worker/pull/122.diff","patch_url":"https://github.com/taskcluster/taskcluster-worker/pull/122.patch","issue_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/issues/122","number":122,"state":"open","locked":false,"title":"Add type support for values loaded from env vars, mainly to support $…","user":{"login":"jonasfj","id":149732,"avatar_url":"https://avatars.githubusercontent.com/u/149732?v=3","gravatar_id":"","url":"https://api.github.com/users/jonasfj","html_url":"https://github.com/jonasfj","followers_url":"https://api.github.com/users/jonasfj/followers","following_url":"https://api.github.com/users/jonasfj/following{/other_user}","gists_url":"https://api.github.com/users/jonasfj/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasfj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasfj/subscriptions","organizations_url":"https://api.github.com/users/jonasfj/orgs","repos_url":"https://api.github.com/users/jonasfj/repos","events_url":"https://api.github.com/users/jonasfj/events{/privacy}","received_events_url":"https://api.github.com/users/jonasfj/received_events","type":"User","site_admin":false},"body":"…PORT","created_at":"2016-09-30T22:08:38Z","updated_at":"2016-10-01T15:01:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8aee29563e1c088844b3f66f8e9597aa2063d5f2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/122/commits","review_comments_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/122/comments","review_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/issues/122/comments","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/statuses/5cf4d71ad3f313b6102471fb261cd239a35dd53d","head":{"label":"taskcluster:typed-env-config","ref":"typed-env-config","sha":"5cf4d71ad3f313b6102471fb261cd239a35dd53d","user":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars.githubusercontent.com/u/6257436?v=3","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"repo":{"id":43515791,"name":"taskcluster-worker","full_name":"taskcluster/taskcluster-worker","owner":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars.githubusercontent.com/u/6257436?v=3","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taskcluster/taskcluster-worker","description":"Primary worker for TaskCluster","fork":false,"url":"https://api.github.com/repos/taskcluster/taskcluster-worker","forks_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/forks","keys_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/teams","hooks_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/hooks","issue_events_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/issues/events{/number}","events_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/events","assignees_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/assignees{/user}","branches_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/branches{/branch}","tags_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/tags","blobs_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/git/refs{/sha}","trees_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/statuses/{sha}","languages_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/languages","stargazers_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/stargazers","contributors_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/contributors","subscribers_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/subscribers","subscription_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/subscription","commits_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/commits{/sha}","git_commits_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/git/commits{/sha}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/comments{/number}","issue_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/issues/comments{/number}","contents_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/contents/{+path}","compare_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/merges","archive_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/downloads","issues_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/issues{/number}","pulls_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls{/number}","milestones_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/milestones{/number}","notifications_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/labels{/name}","releases_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/releases{/id}","deployments_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/deployments","created_at":"2015-10-01T19:15:39Z","updated_at":"2016-09-22T08:20:04Z","pushed_at":"2016-09-30T22:08:38Z","git_url":"git://github.com/taskcluster/taskcluster-worker.git","ssh_url":"git@github.com:taskcluster/taskcluster-worker.git","clone_url":"https://github.com/taskcluster/taskcluster-worker.git","svn_url":"https://github.com/taskcluster/taskcluster-worker","homepage":"https://godoc.org/github.com/taskcluster/taskcluster-worker","size":87867,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":6,"default_branch":"master"}},"base":{"label":"taskcluster:dockerfile-cleanup","ref":"dockerfile-cleanup","sha":"167517b5f1f5ca46de600272d35464df796ee2f9","user":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars.githubusercontent.com/u/6257436?v=3","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"repo":{"id":43515791,"name":"taskcluster-worker","full_name":"taskcluster/taskcluster-worker","owner":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars.githubusercontent.com/u/6257436?v=3","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taskcluster/taskcluster-worker","description":"Primary worker for TaskCluster","fork":false,"url":"https://api.github.com/repos/taskcluster/taskcluster-worker","forks_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/forks","keys_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/teams","hooks_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/hooks","issue_events_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/issues/events{/number}","events_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/events","assignees_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/assignees{/user}","branches_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/branches{/branch}","tags_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/tags","blobs_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/git/refs{/sha}","trees_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/statuses/{sha}","languages_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/languages","stargazers_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/stargazers","contributors_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/contributors","subscribers_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/subscribers","subscription_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/subscription","commits_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/commits{/sha}","git_commits_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/git/commits{/sha}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/comments{/number}","issue_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/issues/comments{/number}","contents_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/contents/{+path}","compare_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/merges","archive_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/downloads","issues_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/issues{/number}","pulls_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls{/number}","milestones_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/milestones{/number}","notifications_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/labels{/name}","releases_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/releases{/id}","deployments_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/deployments","created_at":"2015-10-01T19:15:39Z","updated_at":"2016-09-22T08:20:04Z","pushed_at":"2016-09-30T22:08:38Z","git_url":"git://github.com/taskcluster/taskcluster-worker.git","ssh_url":"git@github.com:taskcluster/taskcluster-worker.git","clone_url":"https://github.com/taskcluster/taskcluster-worker.git","svn_url":"https://github.com/taskcluster/taskcluster-worker","homepage":"https://godoc.org/github.com/taskcluster/taskcluster-worker","size":87867,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/122"},"html":{"href":"https://github.com/taskcluster/taskcluster-worker/pull/122"},"issue":{"href":"https://api.github.com/repos/taskcluster/taskcluster-worker/issues/122"},"comments":{"href":"https://api.github.com/repos/taskcluster/taskcluster-worker/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/taskcluster/taskcluster-worker/statuses/5cf4d71ad3f313b6102471fb261cd239a35dd53d"}}}}
{"actor":{"display_login":"walac"}}