{"action":"created","issue":{"url":"https://api.github.com/repos/holidayextras/temp-extras/issues/1","repository_url":"https://api.github.com/repos/holidayextras/temp-extras","labels_url":"https://api.github.com/repos/holidayextras/temp-extras/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/holidayextras/temp-extras/issues/1/comments","events_url":"https://api.github.com/repos/holidayextras/temp-extras/issues/1/events","html_url":"https://github.com/holidayextras/temp-extras/pull/1","id":123300296,"number":1,"title":"JS changes","user":{"login":"taijuten","id":4288526,"avatar_url":"https://avatars.githubusercontent.com/u/4288526?v=3","gravatar_id":"","url":"https://api.github.com/users/taijuten","html_url":"https://github.com/taijuten","followers_url":"https://api.github.com/users/taijuten/followers","following_url":"https://api.github.com/users/taijuten/following{/other_user}","gists_url":"https://api.github.com/users/taijuten/gists{/gist_id}","starred_url":"https://api.github.com/users/taijuten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taijuten/subscriptions","organizations_url":"https://api.github.com/users/taijuten/orgs","repos_url":"https://api.github.com/users/taijuten/repos","events_url":"https://api.github.com/users/taijuten/events{/privacy}","received_events_url":"https://api.github.com/users/taijuten/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-21T15:36:54Z","updated_at":"2016-05-19T16:24:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/holidayextras/temp-extras/pulls/1","html_url":"https://github.com/holidayextras/temp-extras/pull/1","diff_url":"https://github.com/holidayextras/temp-extras/pull/1.diff","patch_url":"https://github.com/holidayextras/temp-extras/pull/1.patch"},"body":"#### What are the links to relevant tickets?\r\nhttps://hxshortbreaks.atlassian.net/browse/WEB-6553\r\nhttps://hxshortbreaks.atlassian.net/browse/WEB-6608\r\n\r\n#### What does this PR do?\r\nWhilst the tickets relate to more, the scope of this PR is predominantly the main extras JS.\r\nEssentially, this is to streamline the handling of the \"basket\", and to try and pull much of the code into a more object-oriented pattern, which is also testable.\r\n\r\nSome of the legacy code has been left in, as it hasn't needed changing for the functionality, but could do with being merged into the pattern at a later date, for testability.\r\n\r\n#### What functional/unit tests does this PR have?\r\nNone at this time, but it should be far more testable!\r\n\r\n#### How should a developer review this?\r\nWith eyes, but feel free to ask question regarding how things are working, what changes have been made, and code design decisions.\r\n\r\n#### Any background context you want to provide?\r\nThere are still improvements that can be made with this. Some feedback from @kevinhodges was that the basket / hotel / extras should be broken into different \"classes\", rather than one monolithic class as it is currently. However, due to time constraints I don't feel I can spend much more time doing that at this time.\r\n\r\n#### Screenshots (if appropriate)\r\n---\r\n#### Quality checklist (for PR author to complete BEFORE code review):\r\n- [ ] I've checked there is appropriate unit test coverage.\r\n- [ ] I've updated documentation with any changes to procedures.\r\n- [ ] I've checked this work against the requirements of the Jira.\r\n- [ ] This change passes all necessary tests (cross browser, automated or otherwise).\r\n- [ ] I am ready for this to be code reviewed, merged and tested.\r\n\r\n#### Reviewer 1 @sam-cook\r\n- [ ] I agree with the assumptions made in the quality checklist.\r\n- [ ] I’ve witnessed the work behaving as expected.\r\n- [ ] I’ve checked for appropriate test coverage.\r\n- [ ] I’ve checked for coding anti-patterns.\r\n- [ ] I've checked this work against the requirements of the Jira.\r\n- [ ] I don’t believe this work introduces unnecessary technical debt.\r\n- [ ] +1 from me!\r\n\r\n#### Reviewer 2\r\n- [ ] I agree with the assumptions made in the quality checklist.\r\n- [ ] I’ve witnessed the work behaving as expected.\r\n- [ ] I’ve checked for appropriate test coverage.\r\n- [ ] I’ve checked for coding anti-patterns.\r\n- [ ] I've checked this work against the requirements of the Jira.\r\n- [ ] I don’t believe this work introduces unnecessary technical debt.\r\n- [ ] +1 from me!"},"comment":{"url":"https://api.github.com/repos/holidayextras/temp-extras/issues/comments/220377959","html_url":"https://github.com/holidayextras/temp-extras/pull/1#issuecomment-220377959","issue_url":"https://api.github.com/repos/holidayextras/temp-extras/issues/1","id":220377959,"user":{"login":"notABluesSinger","id":6094305,"avatar_url":"https://avatars.githubusercontent.com/u/6094305?v=3","gravatar_id":"","url":"https://api.github.com/users/notABluesSinger","html_url":"https://github.com/notABluesSinger","followers_url":"https://api.github.com/users/notABluesSinger/followers","following_url":"https://api.github.com/users/notABluesSinger/following{/other_user}","gists_url":"https://api.github.com/users/notABluesSinger/gists{/gist_id}","starred_url":"https://api.github.com/users/notABluesSinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notABluesSinger/subscriptions","organizations_url":"https://api.github.com/users/notABluesSinger/orgs","repos_url":"https://api.github.com/users/notABluesSinger/repos","events_url":"https://api.github.com/users/notABluesSinger/events{/privacy}","received_events_url":"https://api.github.com/users/notABluesSinger/received_events","type":"User","site_admin":false},"created_at":"2016-05-19T16:24:50Z","updated_at":"2016-05-19T16:24:50Z","body":"@taijuten do we still need this repo, if not can you close please."}}