{"action":"opened","number":613,"pull_request":{"url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/pulls/613","id":73793816,"html_url":"https://github.com/facebook/facebook-php-sdk-v4/pull/613","diff_url":"https://github.com/facebook/facebook-php-sdk-v4/pull/613.diff","patch_url":"https://github.com/facebook/facebook-php-sdk-v4/pull/613.patch","issue_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/issues/613","number":613,"state":"open","locked":false,"title":"FacebookRedirectLoginHelper - let's not regenerate CSRF token","user":{"login":"KuceraMartin","id":3159068,"avatar_url":"https://avatars.githubusercontent.com/u/3159068?v=3","gravatar_id":"","url":"https://api.github.com/users/KuceraMartin","html_url":"https://github.com/KuceraMartin","followers_url":"https://api.github.com/users/KuceraMartin/followers","following_url":"https://api.github.com/users/KuceraMartin/following{/other_user}","gists_url":"https://api.github.com/users/KuceraMartin/gists{/gist_id}","starred_url":"https://api.github.com/users/KuceraMartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KuceraMartin/subscriptions","organizations_url":"https://api.github.com/users/KuceraMartin/orgs","repos_url":"https://api.github.com/users/KuceraMartin/repos","events_url":"https://api.github.com/users/KuceraMartin/events{/privacy}","received_events_url":"https://api.github.com/users/KuceraMartin/received_events","type":"User","site_admin":false},"body":"When `FacebookRedirectLoginHelper::getLoginUrl()` is called it should first check if a CSRF token (called `state` in the source code) has already been generated and use the existing one if it has.\r\nRight now any time the method is called, a new CSRF token is generated. That means if the method is called more than once, only the last URL will be working which is a problem.\r\n\r\nWhat if the user opens up a webpage in multiple tabs at once? Then he will only be able to use Facebook login in the last tab. And if you forget to put favicon.ico on your website, then he will only be able to use Facebook login in IE :) (see https://github.com/facebook/facebook-php-sdk-v4/issues/583 for details).\r\n\r\n","created_at":"2016-06-14T18:53:00Z","updated_at":"2016-06-14T18:53:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/pulls/613/commits","review_comments_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/pulls/613/comments","review_comment_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/issues/613/comments","statuses_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/statuses/88a4a595093e17b09d03a837aa3cb8630dccef9f","head":{"label":"KuceraMartin:master","ref":"master","sha":"88a4a595093e17b09d03a837aa3cb8630dccef9f","user":{"login":"KuceraMartin","id":3159068,"avatar_url":"https://avatars.githubusercontent.com/u/3159068?v=3","gravatar_id":"","url":"https://api.github.com/users/KuceraMartin","html_url":"https://github.com/KuceraMartin","followers_url":"https://api.github.com/users/KuceraMartin/followers","following_url":"https://api.github.com/users/KuceraMartin/following{/other_user}","gists_url":"https://api.github.com/users/KuceraMartin/gists{/gist_id}","starred_url":"https://api.github.com/users/KuceraMartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KuceraMartin/subscriptions","organizations_url":"https://api.github.com/users/KuceraMartin/orgs","repos_url":"https://api.github.com/users/KuceraMartin/repos","events_url":"https://api.github.com/users/KuceraMartin/events{/privacy}","received_events_url":"https://api.github.com/users/KuceraMartin/received_events","type":"User","site_admin":false},"repo":{"id":61138669,"name":"facebook-php-sdk-v4","full_name":"KuceraMartin/facebook-php-sdk-v4","owner":{"login":"KuceraMartin","id":3159068,"avatar_url":"https://avatars.githubusercontent.com/u/3159068?v=3","gravatar_id":"","url":"https://api.github.com/users/KuceraMartin","html_url":"https://github.com/KuceraMartin","followers_url":"https://api.github.com/users/KuceraMartin/followers","following_url":"https://api.github.com/users/KuceraMartin/following{/other_user}","gists_url":"https://api.github.com/users/KuceraMartin/gists{/gist_id}","starred_url":"https://api.github.com/users/KuceraMartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KuceraMartin/subscriptions","organizations_url":"https://api.github.com/users/KuceraMartin/orgs","repos_url":"https://api.github.com/users/KuceraMartin/repos","events_url":"https://api.github.com/users/KuceraMartin/events{/privacy}","received_events_url":"https://api.github.com/users/KuceraMartin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KuceraMartin/facebook-php-sdk-v4","description":"The Facebook SDK for PHP provides a native interface to the Graph API and Facebook Login.  https://developers.facebook.com/docs/php","fork":true,"url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4","forks_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/forks","keys_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/teams","hooks_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/hooks","issue_events_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/issues/events{/number}","events_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/events","assignees_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/assignees{/user}","branches_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/branches{/branch}","tags_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/tags","blobs_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/git/refs{/sha}","trees_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/statuses/{sha}","languages_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/languages","stargazers_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/stargazers","contributors_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/contributors","subscribers_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/subscribers","subscription_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/subscription","commits_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/commits{/sha}","git_commits_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/git/commits{/sha}","comments_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/comments{/number}","issue_comment_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/issues/comments{/number}","contents_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/contents/{+path}","compare_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/merges","archive_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/downloads","issues_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/issues{/number}","pulls_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/pulls{/number}","milestones_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/milestones{/number}","notifications_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/labels{/name}","releases_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/releases{/id}","deployments_url":"https://api.github.com/repos/KuceraMartin/facebook-php-sdk-v4/deployments","created_at":"2016-06-14T16:31:02Z","updated_at":"2016-06-14T16:31:04Z","pushed_at":"2016-06-14T18:36:19Z","git_url":"git://github.com/KuceraMartin/facebook-php-sdk-v4.git","ssh_url":"git@github.com:KuceraMartin/facebook-php-sdk-v4.git","clone_url":"https://github.com/KuceraMartin/facebook-php-sdk-v4.git","svn_url":"https://github.com/KuceraMartin/facebook-php-sdk-v4","homepage":null,"size":1348,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"c57935ae1230f30bfbf097d88adcff8b8b9b2246","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":18842338,"name":"facebook-php-sdk-v4","full_name":"facebook/facebook-php-sdk-v4","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/facebook-php-sdk-v4","description":"The Facebook SDK for PHP provides a native interface to the Graph API and Facebook Login.  https://developers.facebook.com/docs/php","fork":false,"url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4","forks_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/forks","keys_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/teams","hooks_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/hooks","issue_events_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/events","assignees_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/tags","blobs_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/languages","stargazers_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/stargazers","contributors_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/contributors","subscribers_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/subscribers","subscription_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/subscription","commits_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/merges","archive_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/downloads","issues_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/labels{/name}","releases_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/deployments","created_at":"2014-04-16T14:20:43Z","updated_at":"2016-06-14T08:23:22Z","pushed_at":"2016-06-11T19:12:11Z","git_url":"git://github.com/facebook/facebook-php-sdk-v4.git","ssh_url":"git@github.com:facebook/facebook-php-sdk-v4.git","clone_url":"https://github.com/facebook/facebook-php-sdk-v4.git","svn_url":"https://github.com/facebook/facebook-php-sdk-v4","homepage":null,"size":2215,"stargazers_count":1197,"watchers_count":1197,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":661,"mirror_url":null,"open_issues_count":26,"forks":661,"open_issues":26,"watchers":1197,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/pulls/613"},"html":{"href":"https://github.com/facebook/facebook-php-sdk-v4/pull/613"},"issue":{"href":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/issues/613"},"comments":{"href":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/issues/613/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/pulls/613/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/pulls/613/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/facebook-php-sdk-v4/statuses/88a4a595093e17b09d03a837aa3cb8630dccef9f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"KuceraMartin"}}