{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/36618","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/36618/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/36618/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/36618/events","html_url":"https://github.com/saltstack/salt/pull/36618","id":179612613,"number":36618,"title":"Fix memory leak for 0mq transport in case of TCP DDOS","user":{"login":"onorua","id":407040,"avatar_url":"https://avatars.githubusercontent.com/u/407040?v=3","gravatar_id":"","url":"https://api.github.com/users/onorua","html_url":"https://github.com/onorua","followers_url":"https://api.github.com/users/onorua/followers","following_url":"https://api.github.com/users/onorua/following{/other_user}","gists_url":"https://api.github.com/users/onorua/gists{/gist_id}","starred_url":"https://api.github.com/users/onorua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onorua/subscriptions","organizations_url":"https://api.github.com/users/onorua/orgs","repos_url":"https://api.github.com/users/onorua/repos","events_url":"https://api.github.com/users/onorua/events{/privacy}","received_events_url":"https://api.github.com/users/onorua/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/saltstack/salt/labels/Bugfix%20-%20back-port","name":"Bugfix - back-port","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-09-27T21:01:09Z","updated_at":"2016-09-28T03:56:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/36618","html_url":"https://github.com/saltstack/salt/pull/36618","diff_url":"https://github.com/saltstack/salt/pull/36618.diff","patch_url":"https://github.com/saltstack/salt/pull/36618.patch"},"body":"### What does this PR do?\r\n\r\nIn case anyone is trying to \"DDOS\" zeromq transport with TCP messages,\r\nwe've got ZeroMQPubServerChannel process utilized more than 8GB of RAM.\r\nWith this patch, we have got ZeroMQPubServerChannel stabilized at 300MB\r\nfor > 500 nodes, with no performance penalties. It doesn't affect performance of 0mq minions, as it perform gc.collect only in case of exception.\r\n\r\n### What issues does this PR fix or reference?\r\nhttps://github.com/saltstack/salt/issues/36612\r\n\r\n### Tests written?\r\n\r\nNo"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/250065622","html_url":"https://github.com/saltstack/salt/pull/36618#issuecomment-250065622","issue_url":"https://api.github.com/repos/saltstack/salt/issues/36618","id":250065622,"user":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T03:56:19Z","updated_at":"2016-09-28T03:56:19Z","body":"@onorua I am fine with putting this `gc.collect()` in place for now. If, later on, tests conclude that under normal operation we can remove the the `.enable` and `.disable` then that is even better."}}
{"actor":{"display_login":"cachedout"}}