{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/69698427","id":69698427,"diff_hunk":"@@ -0,0 +1,80 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.flink.util;\n+\n+import org.apache.flink.annotation.PublicEvolving;\n+\n+import java.io.Serializable;\n+import java.util.concurrent.TimeUnit;\n+\n+/**\n+ * Value object that represents time interval\n+ * */\n+@PublicEvolving\n+public final class TimeInterval implements Serializable {","path":"flink-core/src/main/java/org/apache/flink/util/TimeInterval.java","position":30,"original_position":30,"commit_id":"31f9d6335cb25536fe71d4d78ae82a91105dc1a0","original_commit_id":"31f9d6335cb25536fe71d4d78ae82a91105dc1a0","user":{"login":"tillrohrmann","id":5756858,"avatar_url":"https://avatars.githubusercontent.com/u/5756858?v=3","gravatar_id":"","url":"https://api.github.com/users/tillrohrmann","html_url":"https://github.com/tillrohrmann","followers_url":"https://api.github.com/users/tillrohrmann/followers","following_url":"https://api.github.com/users/tillrohrmann/following{/other_user}","gists_url":"https://api.github.com/users/tillrohrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tillrohrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillrohrmann/subscriptions","organizations_url":"https://api.github.com/users/tillrohrmann/orgs","repos_url":"https://api.github.com/users/tillrohrmann/repos","events_url":"https://api.github.com/users/tillrohrmann/events{/privacy}","received_events_url":"https://api.github.com/users/tillrohrmann/received_events","type":"User","site_admin":false},"body":"I like your solution to have a `TimeInterval` class. However, we already have a nearly identical class `Time` in Flink. It is currently contained in the flink-streaming-java module. Thus, in order to not replicate code, I think it would be better to move the `Time` class to flink-core and use it instead of `TimeInterval`. We can move the `org.apache.flink.streaming.api.windowing.time` package to `org.apache.flink.api.common.time`. But then we have to make sure that we update possible references in the documentation to the new location.","created_at":"2016-07-06T09:15:37Z","updated_at":"2016-07-06T09:15:37Z","html_url":"https://github.com/apache/flink/pull/1954#discussion_r69698427","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/1954","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/69698427"},"html":{"href":"https://github.com/apache/flink/pull/1954#discussion_r69698427"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/1954"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/1954","id":68502109,"html_url":"https://github.com/apache/flink/pull/1954","diff_url":"https://github.com/apache/flink/pull/1954.diff","patch_url":"https://github.com/apache/flink/pull/1954.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/1954","number":1954,"state":"open","locked":false,"title":"[FLINK-3190] failure rate restart strategy","user":{"login":"fijolekProjects","id":2931571,"avatar_url":"https://avatars.githubusercontent.com/u/2931571?v=3","gravatar_id":"","url":"https://api.github.com/users/fijolekProjects","html_url":"https://github.com/fijolekProjects","followers_url":"https://api.github.com/users/fijolekProjects/followers","following_url":"https://api.github.com/users/fijolekProjects/following{/other_user}","gists_url":"https://api.github.com/users/fijolekProjects/gists{/gist_id}","starred_url":"https://api.github.com/users/fijolekProjects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fijolekProjects/subscriptions","organizations_url":"https://api.github.com/users/fijolekProjects/orgs","repos_url":"https://api.github.com/users/fijolekProjects/repos","events_url":"https://api.github.com/users/fijolekProjects/events{/privacy}","received_events_url":"https://api.github.com/users/fijolekProjects/received_events","type":"User","site_admin":false},"body":"Failure rate restart strategy - job should only die, if it fails too often in a given time frame","created_at":"2016-05-01T17:50:31Z","updated_at":"2016-07-06T09:15:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe58f6b73f06c9a69639bd9a6145829b152d4387","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/1954/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/1954/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/1954/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/31f9d6335cb25536fe71d4d78ae82a91105dc1a0","head":{"label":"fijolekProjects:FLINK-3190","ref":"FLINK-3190","sha":"31f9d6335cb25536fe71d4d78ae82a91105dc1a0","user":{"login":"fijolekProjects","id":2931571,"avatar_url":"https://avatars.githubusercontent.com/u/2931571?v=3","gravatar_id":"","url":"https://api.github.com/users/fijolekProjects","html_url":"https://github.com/fijolekProjects","followers_url":"https://api.github.com/users/fijolekProjects/followers","following_url":"https://api.github.com/users/fijolekProjects/following{/other_user}","gists_url":"https://api.github.com/users/fijolekProjects/gists{/gist_id}","starred_url":"https://api.github.com/users/fijolekProjects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fijolekProjects/subscriptions","organizations_url":"https://api.github.com/users/fijolekProjects/orgs","repos_url":"https://api.github.com/users/fijolekProjects/repos","events_url":"https://api.github.com/users/fijolekProjects/events{/privacy}","received_events_url":"https://api.github.com/users/fijolekProjects/received_events","type":"User","site_admin":false},"repo":{"id":53171978,"name":"flink","full_name":"fijolekProjects/flink","owner":{"login":"fijolekProjects","id":2931571,"avatar_url":"https://avatars.githubusercontent.com/u/2931571?v=3","gravatar_id":"","url":"https://api.github.com/users/fijolekProjects","html_url":"https://github.com/fijolekProjects","followers_url":"https://api.github.com/users/fijolekProjects/followers","following_url":"https://api.github.com/users/fijolekProjects/following{/other_user}","gists_url":"https://api.github.com/users/fijolekProjects/gists{/gist_id}","starred_url":"https://api.github.com/users/fijolekProjects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fijolekProjects/subscriptions","organizations_url":"https://api.github.com/users/fijolekProjects/orgs","repos_url":"https://api.github.com/users/fijolekProjects/repos","events_url":"https://api.github.com/users/fijolekProjects/events{/privacy}","received_events_url":"https://api.github.com/users/fijolekProjects/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fijolekProjects/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/fijolekProjects/flink","forks_url":"https://api.github.com/repos/fijolekProjects/flink/forks","keys_url":"https://api.github.com/repos/fijolekProjects/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fijolekProjects/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fijolekProjects/flink/teams","hooks_url":"https://api.github.com/repos/fijolekProjects/flink/hooks","issue_events_url":"https://api.github.com/repos/fijolekProjects/flink/issues/events{/number}","events_url":"https://api.github.com/repos/fijolekProjects/flink/events","assignees_url":"https://api.github.com/repos/fijolekProjects/flink/assignees{/user}","branches_url":"https://api.github.com/repos/fijolekProjects/flink/branches{/branch}","tags_url":"https://api.github.com/repos/fijolekProjects/flink/tags","blobs_url":"https://api.github.com/repos/fijolekProjects/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fijolekProjects/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fijolekProjects/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/fijolekProjects/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fijolekProjects/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/fijolekProjects/flink/languages","stargazers_url":"https://api.github.com/repos/fijolekProjects/flink/stargazers","contributors_url":"https://api.github.com/repos/fijolekProjects/flink/contributors","subscribers_url":"https://api.github.com/repos/fijolekProjects/flink/subscribers","subscription_url":"https://api.github.com/repos/fijolekProjects/flink/subscription","commits_url":"https://api.github.com/repos/fijolekProjects/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/fijolekProjects/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/fijolekProjects/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/fijolekProjects/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/fijolekProjects/flink/contents/{+path}","compare_url":"https://api.github.com/repos/fijolekProjects/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fijolekProjects/flink/merges","archive_url":"https://api.github.com/repos/fijolekProjects/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fijolekProjects/flink/downloads","issues_url":"https://api.github.com/repos/fijolekProjects/flink/issues{/number}","pulls_url":"https://api.github.com/repos/fijolekProjects/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/fijolekProjects/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/fijolekProjects/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fijolekProjects/flink/labels{/name}","releases_url":"https://api.github.com/repos/fijolekProjects/flink/releases{/id}","deployments_url":"https://api.github.com/repos/fijolekProjects/flink/deployments","created_at":"2016-03-04T23:24:46Z","updated_at":"2016-03-04T23:25:10Z","pushed_at":"2016-07-04T20:47:41Z","git_url":"git://github.com/fijolekProjects/flink.git","ssh_url":"git@github.com:fijolekProjects/flink.git","clone_url":"https://github.com/fijolekProjects/flink.git","svn_url":"https://github.com/fijolekProjects/flink","homepage":null,"size":89140,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a9fc71d850528b472dee3541ae141e121bfc9b5f","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2016-07-06T06:10:56Z","pushed_at":"2016-07-06T09:04:20Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":121331,"stargazers_count":1408,"watchers_count":1408,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":914,"mirror_url":"git://git.apache.org/flink.git","open_issues_count":109,"forks":914,"open_issues":109,"watchers":1408,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/1954"},"html":{"href":"https://github.com/apache/flink/pull/1954"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/1954"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/1954/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/1954/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/1954/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/31f9d6335cb25536fe71d4d78ae82a91105dc1a0"}}}}
{"actor":{"display_login":"tillrohrmann"}}