{"action":"created","issue":{"url":"https://api.github.com/repos/holidayextras/jsonapi-server/issues/126","repository_url":"https://api.github.com/repos/holidayextras/jsonapi-server","labels_url":"https://api.github.com/repos/holidayextras/jsonapi-server/issues/126/labels{/name}","comments_url":"https://api.github.com/repos/holidayextras/jsonapi-server/issues/126/comments","events_url":"https://api.github.com/repos/holidayextras/jsonapi-server/issues/126/events","html_url":"https://github.com/holidayextras/jsonapi-server/pull/126","id":154871571,"number":126,"title":"Rerouter - Bypass Express on inclusions","user":{"login":"theninj4","id":3055120,"avatar_url":"https://avatars.githubusercontent.com/u/3055120?v=3","gravatar_id":"","url":"https://api.github.com/users/theninj4","html_url":"https://github.com/theninj4","followers_url":"https://api.github.com/users/theninj4/followers","following_url":"https://api.github.com/users/theninj4/following{/other_user}","gists_url":"https://api.github.com/users/theninj4/gists{/gist_id}","starred_url":"https://api.github.com/users/theninj4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theninj4/subscriptions","organizations_url":"https://api.github.com/users/theninj4/orgs","repos_url":"https://api.github.com/users/theninj4/repos","events_url":"https://api.github.com/users/theninj4/events{/privacy}","received_events_url":"https://api.github.com/users/theninj4/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/holidayextras/jsonapi-server/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-05-14T19:35:26Z","updated_at":"2016-05-16T09:04:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/holidayextras/jsonapi-server/pulls/126","html_url":"https://github.com/holidayextras/jsonapi-server/pull/126","diff_url":"https://github.com/holidayextras/jsonapi-server/pull/126.diff","patch_url":"https://github.com/holidayextras/jsonapi-server/pull/126.patch"},"body":"This resolves #119 - All inclusions now use a `rerouter` module to bypass all HTTP routing and jump straight back in on the same infrastructure / NodeJS instance that the request began on.\r\n\r\nThis also means that inclusion's now bypass subsequent `authentication` passes, which I... *think*... is a plus. There'll also be more accurate request logs - all requests will be legitimate customer requests. We'll also be limiting the damage of any requests that might somehow cause us to DOS ourselves via inclusions.\r\n\r\nThe test suite runs ~10% faster, which is also a nice-to-have. Not that it's slow or anything, but it should yield performance benefits in production.\r\n\r\n - [ ] :+1: Pedro\r\n - [ ] :+1: Duncan\r\n - [ ] :+1: Connor"},"comment":{"url":"https://api.github.com/repos/holidayextras/jsonapi-server/issues/comments/219381025","html_url":"https://github.com/holidayextras/jsonapi-server/pull/126#issuecomment-219381025","issue_url":"https://api.github.com/repos/holidayextras/jsonapi-server/issues/126","id":219381025,"user":{"login":"theninj4","id":3055120,"avatar_url":"https://avatars.githubusercontent.com/u/3055120?v=3","gravatar_id":"","url":"https://api.github.com/users/theninj4","html_url":"https://github.com/theninj4","followers_url":"https://api.github.com/users/theninj4/followers","following_url":"https://api.github.com/users/theninj4/following{/other_user}","gists_url":"https://api.github.com/users/theninj4/gists{/gist_id}","starred_url":"https://api.github.com/users/theninj4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theninj4/subscriptions","organizations_url":"https://api.github.com/users/theninj4/orgs","repos_url":"https://api.github.com/users/theninj4/repos","events_url":"https://api.github.com/users/theninj4/events{/privacy}","received_events_url":"https://api.github.com/users/theninj4/received_events","type":"User","site_admin":false},"created_at":"2016-05-16T09:04:32Z","updated_at":"2016-05-16T09:04:32Z","body":"I've just added a new commit to ensure additional properties added within the authentication function are passed through on inclusions."}}