{"action":"created","comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/71112381","id":71112381,"diff_hunk":"@@ -14,24 +14,44 @@\n #include <vector>\n \n #include \"ProcessLib/LocalAssemblerInterface.h\"\n+#include \"NumLib/Extrapolation/ExtrapolatableElement.h\"\n #include \"TESAssemblyParams.h\"\n #include \"TESLocalAssemblerInner-fwd.h\"\n \n-#include \"NumLib/Extrapolation/Extrapolator.h\"\n-\n namespace ProcessLib\n {\n namespace TES\n {\n class TESLocalAssemblerInterface\n     : public ProcessLib::LocalAssemblerInterface,\n-      public NumLib::Extrapolatable<TESIntPtVariables>\n+      public NumLib::ExtrapolatableElement\n {\n public:\n     virtual ~TESLocalAssemblerInterface() = default;\n \n     virtual bool checkBounds(std::vector<double> const& local_x,\n                              std::vector<double> const& local_x_prev_ts) = 0;\n+\n+    virtual std::vector<double> const& getIntPtSolidDensity(\n+        std::vector<double>& /*cache*/) const = 0;\n+\n+    virtual std::vector<double> const& getIntPtLoading(\n+        std::vector<double>& cache) const = 0;\n+\n+    virtual std::vector<double> const& getIntPtReactionDampingFactor(\n+        std::vector<double>& cache) const = 0;\n+\n+    virtual std::vector<double> const& getIntPtReactionRate(\n+        std::vector<double>& /*cache*/) const = 0;","path":"ProcessLib/TES/TESLocalAssembler.h","position":35,"original_position":35,"commit_id":"4439cd1a819ebffea55c377dbd61f78c32547d52","original_commit_id":"4439cd1a819ebffea55c377dbd61f78c32547d52","user":{"login":"chleh","id":10530151,"avatar_url":"https://avatars.githubusercontent.com/u/10530151?v=3","gravatar_id":"","url":"https://api.github.com/users/chleh","html_url":"https://github.com/chleh","followers_url":"https://api.github.com/users/chleh/followers","following_url":"https://api.github.com/users/chleh/following{/other_user}","gists_url":"https://api.github.com/users/chleh/gists{/gist_id}","starred_url":"https://api.github.com/users/chleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chleh/subscriptions","organizations_url":"https://api.github.com/users/chleh/orgs","repos_url":"https://api.github.com/users/chleh/repos","events_url":"https://api.github.com/users/chleh/events{/privacy}","received_events_url":"https://api.github.com/users/chleh/received_events","type":"User","site_admin":false},"body":"It's commented if it's not needed in the implementation.","created_at":"2016-07-18T08:21:38Z","updated_at":"2016-07-18T08:21:38Z","html_url":"https://github.com/ufz/ogs/pull/1309#discussion_r71112381","pull_request_url":"https://api.github.com/repos/ufz/ogs/pulls/1309","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/71112381"},"html":{"href":"https://github.com/ufz/ogs/pull/1309#discussion_r71112381"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1309"}}},"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/1309","id":76262775,"html_url":"https://github.com/ufz/ogs/pull/1309","diff_url":"https://github.com/ufz/ogs/pull/1309.diff","patch_url":"https://github.com/ufz/ogs/pull/1309.patch","issue_url":"https://api.github.com/repos/ufz/ogs/issues/1309","number":1309,"state":"open","locked":false,"title":"Extrapolation moved to base Process","user":{"login":"chleh","id":10530151,"avatar_url":"https://avatars.githubusercontent.com/u/10530151?v=3","gravatar_id":"","url":"https://api.github.com/users/chleh","html_url":"https://github.com/chleh","followers_url":"https://api.github.com/users/chleh/followers","following_url":"https://api.github.com/users/chleh/following{/other_user}","gists_url":"https://api.github.com/users/chleh/gists{/gist_id}","starred_url":"https://api.github.com/users/chleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chleh/subscriptions","organizations_url":"https://api.github.com/users/chleh/orgs","repos_url":"https://api.github.com/users/chleh/repos","events_url":"https://api.github.com/users/chleh/events{/privacy}","received_events_url":"https://api.github.com/users/chleh/received_events","type":"User","site_admin":false},"body":"Follow-up of #1306.\r\n\r\n* Core Extrapolation is now template-free\r\n* there is an adaptor `ExtrapolatableElementCollection` passing information from local assemblers to the `Extrapolator`\r\n* the `Extrapolator` is managed by the base `Process`, now\r\n* there is no per-process enum telling what to extrapolate, anymore\r\n* instead there has to be a member function for each property to be extrapolated.\r\n\r\nThe last point means somewhat more code is required. However, the other points save some code.\r\nThe introduced changes maka a better separation between individual processes and extrapolation. In the future the extrapolation logic maybe can be entirely moved to some output class.","created_at":"2016-07-05T12:07:49Z","updated_at":"2016-07-18T08:21:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf1b3ca0fdb79246999ff52bbdab72cf1e1eddd3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ufz/ogs/pulls/1309/commits","review_comments_url":"https://api.github.com/repos/ufz/ogs/pulls/1309/comments","review_comment_url":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/1309/comments","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/4439cd1a819ebffea55c377dbd61f78c32547d52","head":{"label":"chleh:extrapolation-less-templates","ref":"extrapolation-less-templates","sha":"4439cd1a819ebffea55c377dbd61f78c32547d52","user":{"login":"chleh","id":10530151,"avatar_url":"https://avatars.githubusercontent.com/u/10530151?v=3","gravatar_id":"","url":"https://api.github.com/users/chleh","html_url":"https://github.com/chleh","followers_url":"https://api.github.com/users/chleh/followers","following_url":"https://api.github.com/users/chleh/following{/other_user}","gists_url":"https://api.github.com/users/chleh/gists{/gist_id}","starred_url":"https://api.github.com/users/chleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chleh/subscriptions","organizations_url":"https://api.github.com/users/chleh/orgs","repos_url":"https://api.github.com/users/chleh/repos","events_url":"https://api.github.com/users/chleh/events{/privacy}","received_events_url":"https://api.github.com/users/chleh/received_events","type":"User","site_admin":false},"repo":{"id":40347084,"name":"ogs6","full_name":"chleh/ogs6","owner":{"login":"chleh","id":10530151,"avatar_url":"https://avatars.githubusercontent.com/u/10530151?v=3","gravatar_id":"","url":"https://api.github.com/users/chleh","html_url":"https://github.com/chleh","followers_url":"https://api.github.com/users/chleh/followers","following_url":"https://api.github.com/users/chleh/following{/other_user}","gists_url":"https://api.github.com/users/chleh/gists{/gist_id}","starred_url":"https://api.github.com/users/chleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chleh/subscriptions","organizations_url":"https://api.github.com/users/chleh/orgs","repos_url":"https://api.github.com/users/chleh/repos","events_url":"https://api.github.com/users/chleh/events{/privacy}","received_events_url":"https://api.github.com/users/chleh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chleh/ogs6","description":"Experimental OGS-6 source code","fork":true,"url":"https://api.github.com/repos/chleh/ogs6","forks_url":"https://api.github.com/repos/chleh/ogs6/forks","keys_url":"https://api.github.com/repos/chleh/ogs6/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chleh/ogs6/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chleh/ogs6/teams","hooks_url":"https://api.github.com/repos/chleh/ogs6/hooks","issue_events_url":"https://api.github.com/repos/chleh/ogs6/issues/events{/number}","events_url":"https://api.github.com/repos/chleh/ogs6/events","assignees_url":"https://api.github.com/repos/chleh/ogs6/assignees{/user}","branches_url":"https://api.github.com/repos/chleh/ogs6/branches{/branch}","tags_url":"https://api.github.com/repos/chleh/ogs6/tags","blobs_url":"https://api.github.com/repos/chleh/ogs6/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chleh/ogs6/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chleh/ogs6/git/refs{/sha}","trees_url":"https://api.github.com/repos/chleh/ogs6/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chleh/ogs6/statuses/{sha}","languages_url":"https://api.github.com/repos/chleh/ogs6/languages","stargazers_url":"https://api.github.com/repos/chleh/ogs6/stargazers","contributors_url":"https://api.github.com/repos/chleh/ogs6/contributors","subscribers_url":"https://api.github.com/repos/chleh/ogs6/subscribers","subscription_url":"https://api.github.com/repos/chleh/ogs6/subscription","commits_url":"https://api.github.com/repos/chleh/ogs6/commits{/sha}","git_commits_url":"https://api.github.com/repos/chleh/ogs6/git/commits{/sha}","comments_url":"https://api.github.com/repos/chleh/ogs6/comments{/number}","issue_comment_url":"https://api.github.com/repos/chleh/ogs6/issues/comments{/number}","contents_url":"https://api.github.com/repos/chleh/ogs6/contents/{+path}","compare_url":"https://api.github.com/repos/chleh/ogs6/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chleh/ogs6/merges","archive_url":"https://api.github.com/repos/chleh/ogs6/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chleh/ogs6/downloads","issues_url":"https://api.github.com/repos/chleh/ogs6/issues{/number}","pulls_url":"https://api.github.com/repos/chleh/ogs6/pulls{/number}","milestones_url":"https://api.github.com/repos/chleh/ogs6/milestones{/number}","notifications_url":"https://api.github.com/repos/chleh/ogs6/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chleh/ogs6/labels{/name}","releases_url":"https://api.github.com/repos/chleh/ogs6/releases{/id}","deployments_url":"https://api.github.com/repos/chleh/ogs6/deployments","created_at":"2015-08-07T07:24:24Z","updated_at":"2016-01-14T16:07:04Z","pushed_at":"2016-07-18T08:11:34Z","git_url":"git://github.com/chleh/ogs6.git","ssh_url":"git@github.com:chleh/ogs6.git","clone_url":"https://github.com/chleh/ogs6.git","svn_url":"https://github.com/chleh/ogs6","homepage":"www.opengeosys.org","size":17358,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ufz:master","ref":"master","sha":"f2f2d30b8f3ab6ae84e75fa5b4af162105dbaf64","user":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"repo":{"id":1701384,"name":"ogs","full_name":"ufz/ogs","owner":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufz/ogs","description":"Experimental OGS-6 source code","fork":false,"url":"https://api.github.com/repos/ufz/ogs","forks_url":"https://api.github.com/repos/ufz/ogs/forks","keys_url":"https://api.github.com/repos/ufz/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufz/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufz/ogs/teams","hooks_url":"https://api.github.com/repos/ufz/ogs/hooks","issue_events_url":"https://api.github.com/repos/ufz/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/ufz/ogs/events","assignees_url":"https://api.github.com/repos/ufz/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/ufz/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/ufz/ogs/tags","blobs_url":"https://api.github.com/repos/ufz/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufz/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufz/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufz/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ufz/ogs/languages","stargazers_url":"https://api.github.com/repos/ufz/ogs/stargazers","contributors_url":"https://api.github.com/repos/ufz/ogs/contributors","subscribers_url":"https://api.github.com/repos/ufz/ogs/subscribers","subscription_url":"https://api.github.com/repos/ufz/ogs/subscription","commits_url":"https://api.github.com/repos/ufz/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufz/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufz/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufz/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufz/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/ufz/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufz/ogs/merges","archive_url":"https://api.github.com/repos/ufz/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufz/ogs/downloads","issues_url":"https://api.github.com/repos/ufz/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/ufz/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ufz/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ufz/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufz/ogs/labels{/name}","releases_url":"https://api.github.com/repos/ufz/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/ufz/ogs/deployments","created_at":"2011-05-04T14:09:57Z","updated_at":"2016-04-10T21:29:50Z","pushed_at":"2016-07-18T06:42:14Z","git_url":"git://github.com/ufz/ogs.git","ssh_url":"git@github.com:ufz/ogs.git","clone_url":"https://github.com/ufz/ogs.git","svn_url":"https://github.com/ufz/ogs","homepage":"www.opengeosys.org","size":18770,"stargazers_count":19,"watchers_count":19,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":104,"forks":47,"open_issues":104,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1309"},"html":{"href":"https://github.com/ufz/ogs/pull/1309"},"issue":{"href":"https://api.github.com/repos/ufz/ogs/issues/1309"},"comments":{"href":"https://api.github.com/repos/ufz/ogs/issues/1309/comments"},"review_comments":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1309/comments"},"review_comment":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1309/commits"},"statuses":{"href":"https://api.github.com/repos/ufz/ogs/statuses/4439cd1a819ebffea55c377dbd61f78c32547d52"}}}}
{"actor":{"display_login":"chleh"}}