{"action":"created","issue":{"url":"https://api.github.com/repos/vincentbernat/lldpd/issues/175","repository_url":"https://api.github.com/repos/vincentbernat/lldpd","labels_url":"https://api.github.com/repos/vincentbernat/lldpd/issues/175/labels{/name}","comments_url":"https://api.github.com/repos/vincentbernat/lldpd/issues/175/comments","events_url":"https://api.github.com/repos/vincentbernat/lldpd/issues/175/events","html_url":"https://github.com/vincentbernat/lldpd/pull/175","id":150397541,"number":175,"title":"Make build of unit tests optional","user":{"login":"jonasj76","id":474513,"avatar_url":"https://avatars.githubusercontent.com/u/474513?v=3","gravatar_id":"","url":"https://api.github.com/users/jonasj76","html_url":"https://github.com/jonasj76","followers_url":"https://api.github.com/users/jonasj76/followers","following_url":"https://api.github.com/users/jonasj76/following{/other_user}","gists_url":"https://api.github.com/users/jonasj76/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasj76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasj76/subscriptions","organizations_url":"https://api.github.com/users/jonasj76/orgs","repos_url":"https://api.github.com/users/jonasj76/repos","events_url":"https://api.github.com/users/jonasj76/events{/privacy}","received_events_url":"https://api.github.com/users/jonasj76/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-22T15:17:44Z","updated_at":"2016-04-22T16:10:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vincentbernat/lldpd/pulls/175","html_url":"https://github.com/vincentbernat/lldpd/pull/175","diff_url":"https://github.com/vincentbernat/lldpd/pull/175.diff","patch_url":"https://github.com/vincentbernat/lldpd/pull/175.patch"},"body":"This commit will adds a `configure` option, `{with, without}-unittests` (default: yes),\r\nwhich can be used to disable building the unit tests.\r\n\r\nIn my case, rebuilding `lldpd` often, disabling the build of unit tests shorten the building process a little bit.\r\nI also identified a problem when cross-compiling, if `check` could be found on the host system but not for the target system, the compilation failed due to that `configure` found `check` (on host system) and then tried to use it when building the target system. I might have done something wrong in my setup, but disabling the unit test solved my problem.\r\n"},"comment":{"url":"https://api.github.com/repos/vincentbernat/lldpd/issues/comments/213494589","html_url":"https://github.com/vincentbernat/lldpd/pull/175#issuecomment-213494589","issue_url":"https://api.github.com/repos/vincentbernat/lldpd/issues/175","id":213494589,"user":{"login":"jonasj76","id":474513,"avatar_url":"https://avatars.githubusercontent.com/u/474513?v=3","gravatar_id":"","url":"https://api.github.com/users/jonasj76","html_url":"https://github.com/jonasj76","followers_url":"https://api.github.com/users/jonasj76/followers","following_url":"https://api.github.com/users/jonasj76/following{/other_user}","gists_url":"https://api.github.com/users/jonasj76/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasj76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasj76/subscriptions","organizations_url":"https://api.github.com/users/jonasj76/orgs","repos_url":"https://api.github.com/users/jonasj76/repos","events_url":"https://api.github.com/users/jonasj76/events{/privacy}","received_events_url":"https://api.github.com/users/jonasj76/received_events","type":"User","site_admin":false},"created_at":"2016-04-22T16:10:59Z","updated_at":"2016-04-22T16:10:59Z","body":"Sorry, I was to quick in my assumption. A closer look shows that, as you say, the unit tests are not built.\r\nBut two files in the `tests` directory are built, `common.c` and `decode.c`, where `common.c` are including `check.h`, which in my case does not exists on my cross-compile target system.  "}}