{"action":"closed","issue":{"url":"https://api.github.com/repos/jishi/node-sonos-discovery/issues/93","repository_url":"https://api.github.com/repos/jishi/node-sonos-discovery","labels_url":"https://api.github.com/repos/jishi/node-sonos-discovery/issues/93/labels{/name}","comments_url":"https://api.github.com/repos/jishi/node-sonos-discovery/issues/93/comments","events_url":"https://api.github.com/repos/jishi/node-sonos-discovery/issues/93/events","html_url":"https://github.com/jishi/node-sonos-discovery/issues/93","id":181104705,"number":93,"title":"If local endpoint changes, subscribe will keep failing to reconnect.","user":{"login":"pfiaux","id":1199890,"avatar_url":"https://avatars.githubusercontent.com/u/1199890?v=3","gravatar_id":"","url":"https://api.github.com/users/pfiaux","html_url":"https://github.com/pfiaux","followers_url":"https://api.github.com/users/pfiaux/followers","following_url":"https://api.github.com/users/pfiaux/following{/other_user}","gists_url":"https://api.github.com/users/pfiaux/gists{/gist_id}","starred_url":"https://api.github.com/users/pfiaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfiaux/subscriptions","organizations_url":"https://api.github.com/users/pfiaux/orgs","repos_url":"https://api.github.com/users/pfiaux/repos","events_url":"https://api.github.com/users/pfiaux/events{/privacy}","received_events_url":"https://api.github.com/users/pfiaux/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-10-05T09:27:28Z","updated_at":"2016-11-23T22:59:36Z","closed_at":"2016-11-23T22:59:36Z","body":"If the local end point changes, new ip is given by the router our such the subscribe call will throw a `EADDRNOTAVAIL` error. But since discovery.localEndpoint is only setup on init it will keep failing indefinitely or until restarted.\n\nI fixed this on a legacy branch: https://github.com/pfiaux/node-sonos-discovery/commit/67201ddfcb77594f3e95decfe67e8dd183412b8a\n\nI handled the EADDRNOTAVAIL specifically can updated the localEndpoint in that case. I looked quickly, I could be wrong but it seems like 1.0.0 on master still only does it on init as well:\nhttps://github.com/jishi/node-sonos-discovery/blob/master/lib/SonosSystem.js#L123\n"}}
{"actor":{"display_login":"jishi"}}