{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/79884937","id":79884937,"diff_hunk":"@@ -242,10 +242,30 @@ final class Decimal extends Ordered[Decimal] with Serializable {\n       if (scale < _scale) {\n         // Easier case: we just need to divide our scale down\n         val diff = _scale - scale\n-        val droppedDigits = longVal % POW_10(diff)\n-        longVal /= POW_10(diff)\n-        if (math.abs(droppedDigits) * 2 >= POW_10(diff)) {\n-          longVal += (if (longVal < 0) -1L else 1L)\n+        val pow10diff = POW_10(diff)\n+        // % and / always round to 0\n+        val droppedDigits = longVal % pow10diff\n+        longVal /= pow10diff\n+        roundMode match {\n+          case ROUND_FLOOR =>\n+            if (droppedDigits < 0) {\n+              longVal += -1L\n+            }\n+          case ROUND_CEILING =>\n+            if (droppedDigits > 0) {\n+              longVal += 1L\n+            }\n+          case ROUND_HALF_UP =>\n+            if (math.abs(droppedDigits) * 2 >= pow10diff) {\n+              longVal += (if (longVal < 0) -1L else 1L)","path":"sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala","position":23,"original_position":23,"commit_id":"cf0e445b600baad201062e77651bee3d907b42fd","original_commit_id":"cf0e445b600baad201062e77651bee3d907b42fd","user":{"login":"srinathshankar","id":3208943,"avatar_url":"https://avatars.githubusercontent.com/u/3208943?v=3","gravatar_id":"","url":"https://api.github.com/users/srinathshankar","html_url":"https://github.com/srinathshankar","followers_url":"https://api.github.com/users/srinathshankar/followers","following_url":"https://api.github.com/users/srinathshankar/following{/other_user}","gists_url":"https://api.github.com/users/srinathshankar/gists{/gist_id}","starred_url":"https://api.github.com/users/srinathshankar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srinathshankar/subscriptions","organizations_url":"https://api.github.com/users/srinathshankar/orgs","repos_url":"https://api.github.com/users/srinathshankar/repos","events_url":"https://api.github.com/users/srinathshankar/events{/privacy}","received_events_url":"https://api.github.com/users/srinathshankar/received_events","type":"User","site_admin":false},"body":"Is this correct if longVal is 0, after the division above\r\nWhat happens if you round_half_up -0.6 ? Looks like you may get +1 ?","created_at":"2016-09-21T17:14:28Z","updated_at":"2016-09-21T17:15:24Z","html_url":"https://github.com/apache/spark/pull/15154#discussion_r79884937","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/15154","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/79884937"},"html":{"href":"https://github.com/apache/spark/pull/15154#discussion_r79884937"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/15154"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/15154","id":85876534,"html_url":"https://github.com/apache/spark/pull/15154","diff_url":"https://github.com/apache/spark/pull/15154.diff","patch_url":"https://github.com/apache/spark/pull/15154.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/15154","number":15154,"state":"open","locked":false,"title":"[SPARK-17494] [SQL] changePrecision() on compact decimal should respect rounding mode","user":{"login":"davies","id":40902,"avatar_url":"https://avatars.githubusercontent.com/u/40902?v=3","gravatar_id":"","url":"https://api.github.com/users/davies","html_url":"https://github.com/davies","followers_url":"https://api.github.com/users/davies/followers","following_url":"https://api.github.com/users/davies/following{/other_user}","gists_url":"https://api.github.com/users/davies/gists{/gist_id}","starred_url":"https://api.github.com/users/davies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davies/subscriptions","organizations_url":"https://api.github.com/users/davies/orgs","repos_url":"https://api.github.com/users/davies/repos","events_url":"https://api.github.com/users/davies/events{/privacy}","received_events_url":"https://api.github.com/users/davies/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nFloor()/Ceil() of decimal is implemented using changePrecision() by passing a rounding mode, but the rounding mode is not respected when the decimal is in compact mode (could fit within a Long). \r\n\r\nThis Update the changePrecision() to respect rounding mode, which could be ROUND_FLOOR, ROUND_CEIL, ROUND_HALF_UP, ROUND_HALF_EVEN.\r\n \r\n## How was this patch tested?\r\n\r\nAdded regression tests.\r\n","created_at":"2016-09-19T21:53:07Z","updated_at":"2016-09-21T17:15:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64c793f84c5759c8c218a151bd66a5bb90b40edf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/15154/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/15154/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/15154/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/cf0e445b600baad201062e77651bee3d907b42fd","head":{"label":"davies:decimal_round","ref":"decimal_round","sha":"cf0e445b600baad201062e77651bee3d907b42fd","user":{"login":"davies","id":40902,"avatar_url":"https://avatars.githubusercontent.com/u/40902?v=3","gravatar_id":"","url":"https://api.github.com/users/davies","html_url":"https://github.com/davies","followers_url":"https://api.github.com/users/davies/followers","following_url":"https://api.github.com/users/davies/following{/other_user}","gists_url":"https://api.github.com/users/davies/gists{/gist_id}","starred_url":"https://api.github.com/users/davies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davies/subscriptions","organizations_url":"https://api.github.com/users/davies/orgs","repos_url":"https://api.github.com/users/davies/repos","events_url":"https://api.github.com/users/davies/events{/privacy}","received_events_url":"https://api.github.com/users/davies/received_events","type":"User","site_admin":false},"repo":{"id":21724875,"name":"spark","full_name":"davies/spark","owner":{"login":"davies","id":40902,"avatar_url":"https://avatars.githubusercontent.com/u/40902?v=3","gravatar_id":"","url":"https://api.github.com/users/davies","html_url":"https://github.com/davies","followers_url":"https://api.github.com/users/davies/followers","following_url":"https://api.github.com/users/davies/following{/other_user}","gists_url":"https://api.github.com/users/davies/gists{/gist_id}","starred_url":"https://api.github.com/users/davies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davies/subscriptions","organizations_url":"https://api.github.com/users/davies/orgs","repos_url":"https://api.github.com/users/davies/repos","events_url":"https://api.github.com/users/davies/events{/privacy}","received_events_url":"https://api.github.com/users/davies/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davies/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/davies/spark","forks_url":"https://api.github.com/repos/davies/spark/forks","keys_url":"https://api.github.com/repos/davies/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davies/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davies/spark/teams","hooks_url":"https://api.github.com/repos/davies/spark/hooks","issue_events_url":"https://api.github.com/repos/davies/spark/issues/events{/number}","events_url":"https://api.github.com/repos/davies/spark/events","assignees_url":"https://api.github.com/repos/davies/spark/assignees{/user}","branches_url":"https://api.github.com/repos/davies/spark/branches{/branch}","tags_url":"https://api.github.com/repos/davies/spark/tags","blobs_url":"https://api.github.com/repos/davies/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davies/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davies/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/davies/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davies/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/davies/spark/languages","stargazers_url":"https://api.github.com/repos/davies/spark/stargazers","contributors_url":"https://api.github.com/repos/davies/spark/contributors","subscribers_url":"https://api.github.com/repos/davies/spark/subscribers","subscription_url":"https://api.github.com/repos/davies/spark/subscription","commits_url":"https://api.github.com/repos/davies/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/davies/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/davies/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/davies/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/davies/spark/contents/{+path}","compare_url":"https://api.github.com/repos/davies/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davies/spark/merges","archive_url":"https://api.github.com/repos/davies/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davies/spark/downloads","issues_url":"https://api.github.com/repos/davies/spark/issues{/number}","pulls_url":"https://api.github.com/repos/davies/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/davies/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/davies/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davies/spark/labels{/name}","releases_url":"https://api.github.com/repos/davies/spark/releases{/id}","deployments_url":"https://api.github.com/repos/davies/spark/deployments","created_at":"2014-07-11T06:39:41Z","updated_at":"2016-03-16T14:14:59Z","pushed_at":"2016-09-19T21:46:59Z","git_url":"git://github.com/davies/spark.git","ssh_url":"git@github.com:davies/spark.git","clone_url":"https://github.com/davies/spark.git","svn_url":"https://github.com/davies/spark","homepage":null,"size":189843,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d8104158a922d86dd4f00e50d5d7dddc7b777a21","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-09-21T15:03:28Z","pushed_at":"2016-09-21T16:15:45Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":528340,"stargazers_count":10094,"watchers_count":10094,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9405,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":476,"forks":9405,"open_issues":476,"watchers":10094,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/15154"},"html":{"href":"https://github.com/apache/spark/pull/15154"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/15154"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/15154/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/15154/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/15154/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/cf0e445b600baad201062e77651bee3d907b42fd"}}}}
{"actor":{"display_login":"srinathshankar"}}