{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/34014","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/34014/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/34014/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/34014/events","html_url":"https://github.com/saltstack/salt/pull/34014","id":160280079,"number":34014,"title":"fix launch config creation params","user":{"login":"jnhmcknight","id":6341895,"avatar_url":"https://avatars.githubusercontent.com/u/6341895?v=3","gravatar_id":"","url":"https://api.github.com/users/jnhmcknight","html_url":"https://github.com/jnhmcknight","followers_url":"https://api.github.com/users/jnhmcknight/followers","following_url":"https://api.github.com/users/jnhmcknight/following{/other_user}","gists_url":"https://api.github.com/users/jnhmcknight/gists{/gist_id}","starred_url":"https://api.github.com/users/jnhmcknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnhmcknight/subscriptions","organizations_url":"https://api.github.com/users/jnhmcknight/orgs","repos_url":"https://api.github.com/users/jnhmcknight/repos","events_url":"https://api.github.com/users/jnhmcknight/events{/privacy}","received_events_url":"https://api.github.com/users/jnhmcknight/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-14T20:47:20Z","updated_at":"2016-06-15T16:56:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/34014","html_url":"https://github.com/saltstack/salt/pull/34014","diff_url":"https://github.com/saltstack/salt/pull/34014.diff","patch_url":"https://github.com/saltstack/salt/pull/34014.patch"},"body":"### What does this PR do?\r\nThis fixes an issue where the launch configuration could not be created because it was connecting to the default region instead of the specified region.\r\n\r\n### What issues does this PR fix or reference?\r\nThere was no submitted issue for this. It was an issue that was hit this morning for us and we debugged until it was fixed.\r\n\r\n### Previous Behavior\r\nGiven:\r\n```yaml\r\n    Ensure mylc exists:\r\n      boto_lc.present:\r\n        - name: mylc\r\n        - region: sa-east-1\r\n        - image_id: ami-0b9c9f62\r\n        - profile: myprofile\r\n```\r\nthe state will fail with due to connecting to the wrong region:\r\n```xml\r\n<ErrorResponse xmlns=\"http://autoscaling.amazonaws.com/doc/2011-01-01/\">\r\n  <Error>\r\n    <Type>Sender</Type>\r\n    <Code>ValidationError</Code>\r\n    <Message>AMI ami-0b9c9f62 is invalid: The image id '[ami-0b9c9f62]' does not exist</Message>\r\n  </Error>\r\n  <RequestId>b60ae124-3269-11e6-9c98-016ce5ab63a5</RequestId>\r\n</ErrorResponse>\r\n```\r\nThe arguments to `boto_asg.create_launch_configuration` were taken as positional instead of named, and there were additional arguments to `boto_asg.create_launch_configuration`. This created an inconsistency between argument lists and therefore the specified `region` was getting passed into the `volume_type` argument and consequently the local `region` variable was always `None` for the actual creation of the launch configuration.\r\n\r\n### New Behavior\r\nAll parameters have been named to prevent this error.\r\n\r\n### Tests written?\r\nNo\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/226250476","html_url":"https://github.com/saltstack/salt/pull/34014#issuecomment-226250476","issue_url":"https://api.github.com/repos/saltstack/salt/issues/34014","id":226250476,"user":{"login":"rallytime","id":6547906,"avatar_url":"https://avatars.githubusercontent.com/u/6547906?v=3","gravatar_id":"","url":"https://api.github.com/users/rallytime","html_url":"https://github.com/rallytime","followers_url":"https://api.github.com/users/rallytime/followers","following_url":"https://api.github.com/users/rallytime/following{/other_user}","gists_url":"https://api.github.com/users/rallytime/gists{/gist_id}","starred_url":"https://api.github.com/users/rallytime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rallytime/subscriptions","organizations_url":"https://api.github.com/users/rallytime/orgs","repos_url":"https://api.github.com/users/rallytime/repos","events_url":"https://api.github.com/users/rallytime/events{/privacy}","received_events_url":"https://api.github.com/users/rallytime/received_events","type":"User","site_admin":false},"created_at":"2016-06-15T16:56:55Z","updated_at":"2016-06-15T16:56:55Z","body":"@jnhmcknight Thank you for cleaning this up. This has bitten us in a couple of places in the boto files where positional kwargs are being used instead of explicitly naming them."}}
{"actor":{"display_login":"rallytime"}}