{"action":"created","issue":{"url":"https://api.github.com/repos/ReactiveX/RxJS/issues/1414","repository_url":"https://api.github.com/repos/ReactiveX/RxJS","labels_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/1414/labels{/name}","comments_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/1414/comments","events_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/1414/events","html_url":"https://github.com/ReactiveX/RxJS/pull/1414","id":137736764,"number":1414,"title":"Proposal : type definition test cases","user":{"login":"kwonoj","id":1210596,"avatar_url":"https://avatars.githubusercontent.com/u/1210596?v=3","gravatar_id":"","url":"https://api.github.com/users/kwonoj","html_url":"https://github.com/kwonoj","followers_url":"https://api.github.com/users/kwonoj/followers","following_url":"https://api.github.com/users/kwonoj/following{/other_user}","gists_url":"https://api.github.com/users/kwonoj/gists{/gist_id}","starred_url":"https://api.github.com/users/kwonoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwonoj/subscriptions","organizations_url":"https://api.github.com/users/kwonoj/orgs","repos_url":"https://api.github.com/users/kwonoj/repos","events_url":"https://api.github.com/users/kwonoj/events{/privacy}","received_events_url":"https://api.github.com/users/kwonoj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-02T00:46:49Z","updated_at":"2016-03-09T20:55:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ReactiveX/RxJS/pulls/1414","html_url":"https://github.com/ReactiveX/RxJS/pull/1414","diff_url":"https://github.com/ReactiveX/RxJS/pull/1414.diff","patch_url":"https://github.com/ReactiveX/RxJS/pull/1414.patch"},"body":"Now test cases are migrated in typescript, it is possible to integrate type definition test into existing test case execution environment. This PR is initial proposal of logistics. \r\n\r\nChanges are straightforward, test helper exports interface `type` for type definition assertion actually doesn't do anything but only serves as container of all type definition test. These will be verified via compile time of test cases. \r\n\r\nIn test cases, very bottom of each test contains `type` assertion and list out possible type definition test cases, majorly\r\n- operator input signature accepts parameter as expected\r\n- operator chain, or subscription correctly delivers context of value type `<T>`\r\n- etcs\r\n\r\nintentionwise this is same as #1189 does, only difference is logistics.\r\n\r\n/cc @david-driscoll for visibility also."},"comment":{"url":"https://api.github.com/repos/ReactiveX/RxJS/issues/comments/194503617","html_url":"https://github.com/ReactiveX/RxJS/pull/1414#issuecomment-194503617","issue_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/1414","id":194503617,"user":{"login":"kwonoj","id":1210596,"avatar_url":"https://avatars.githubusercontent.com/u/1210596?v=3","gravatar_id":"","url":"https://api.github.com/users/kwonoj","html_url":"https://github.com/kwonoj","followers_url":"https://api.github.com/users/kwonoj/followers","following_url":"https://api.github.com/users/kwonoj/following{/other_user}","gists_url":"https://api.github.com/users/kwonoj/gists{/gist_id}","starred_url":"https://api.github.com/users/kwonoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwonoj/subscriptions","organizations_url":"https://api.github.com/users/kwonoj/orgs","repos_url":"https://api.github.com/users/kwonoj/repos","events_url":"https://api.github.com/users/kwonoj/events{/privacy}","received_events_url":"https://api.github.com/users/kwonoj/received_events","type":"User","site_admin":false},"created_at":"2016-03-09T20:55:41Z","updated_at":"2016-03-09T20:55:41Z","body":"@david-driscoll , would you able to share opinion this would works for you for type definition test? "}}