{"action":"created","comment":{"url":"https://api.github.com/repos/idaholab/moose/pulls/comments/56360423","id":56360423,"diff_hunk":"@@ -96,32 +96,29 @@ RandomData::updateGenerators()\n   }\n \n   if (_is_nodal)\n-  {\n-    MeshBase::const_node_iterator it = _rd_mesh.getMesh().active_nodes_begin();\n-    MeshBase::const_node_iterator end_it = _rd_mesh.getMesh().active_nodes_end();\n+    updateGeneratorHelper(_rd_mesh.getMesh().active_nodes_begin(), _rd_mesh.getMesh().active_nodes_end());","path":"framework/src/utils/RandomData.C","position":7,"original_position":7,"commit_id":"a20165253410cfe9bfc05d3c3b04e1da92707c03","original_commit_id":"a20165253410cfe9bfc05d3c3b04e1da92707c03","user":{"login":"friedmud","id":870705,"avatar_url":"https://avatars.githubusercontent.com/u/870705?v=3","gravatar_id":"","url":"https://api.github.com/users/friedmud","html_url":"https://github.com/friedmud","followers_url":"https://api.github.com/users/friedmud/followers","following_url":"https://api.github.com/users/friedmud/following{/other_user}","gists_url":"https://api.github.com/users/friedmud/gists{/gist_id}","starred_url":"https://api.github.com/users/friedmud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friedmud/subscriptions","organizations_url":"https://api.github.com/users/friedmud/orgs","repos_url":"https://api.github.com/users/friedmud/repos","events_url":"https://api.github.com/users/friedmud/events{/privacy}","received_events_url":"https://api.github.com/users/friedmud/received_events","type":"User","site_admin":false},"body":"Ummm... then there is no way this can work with ParallelMesh... so the whole thing needs to be redesigned.\r\n\r\nHaving a serial loop over all elements / nodes is bad news anyway.  It should be threaded (which would also preclude this design).","created_at":"2016-03-16T15:57:26Z","updated_at":"2016-03-16T15:57:26Z","html_url":"https://github.com/idaholab/moose/pull/6591#discussion_r56360423","pull_request_url":"https://api.github.com/repos/idaholab/moose/pulls/6591","_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments/56360423"},"html":{"href":"https://github.com/idaholab/moose/pull/6591#discussion_r56360423"},"pull_request":{"href":"https://api.github.com/repos/idaholab/moose/pulls/6591"}}},"pull_request":{"url":"https://api.github.com/repos/idaholab/moose/pulls/6591","id":62978079,"html_url":"https://github.com/idaholab/moose/pull/6591","diff_url":"https://github.com/idaholab/moose/pull/6591.diff","patch_url":"https://github.com/idaholab/moose/pull/6591.patch","issue_url":"https://api.github.com/repos/idaholab/moose/issues/6591","number":6591,"state":"open","locked":false,"title":"Memory optimization for MOOSE PRNG","user":{"login":"permcody","id":3036960,"avatar_url":"https://avatars.githubusercontent.com/u/3036960?v=3","gravatar_id":"","url":"https://api.github.com/users/permcody","html_url":"https://github.com/permcody","followers_url":"https://api.github.com/users/permcody/followers","following_url":"https://api.github.com/users/permcody/following{/other_user}","gists_url":"https://api.github.com/users/permcody/gists{/gist_id}","starred_url":"https://api.github.com/users/permcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/permcody/subscriptions","organizations_url":"https://api.github.com/users/permcody/orgs","repos_url":"https://api.github.com/users/permcody/repos","events_url":"https://api.github.com/users/permcody/events{/privacy}","received_events_url":"https://api.github.com/users/permcody/received_events","type":"User","site_admin":false},"body":"Currently we're storing all generator states per dof\r\nbut we simply don't need to do that. This PR stores\r\nless state reducing memory usage.\r\n\r\n~~Additionally, I'm re-enabling the random test. I believe this may be working again due to recent threading fixes.~~\r\n\r\nrefs #6590, #2088","created_at":"2016-03-15T21:14:34Z","updated_at":"2016-03-16T15:57:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16d073a0361437c586a3904a09c65e2a6fe461b3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/idaholab/moose/pulls/6591/commits","review_comments_url":"https://api.github.com/repos/idaholab/moose/pulls/6591/comments","review_comment_url":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/idaholab/moose/issues/6591/comments","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/a20165253410cfe9bfc05d3c3b04e1da92707c03","head":{"label":"permcody:memory_random","ref":"memory_random","sha":"a20165253410cfe9bfc05d3c3b04e1da92707c03","user":{"login":"permcody","id":3036960,"avatar_url":"https://avatars.githubusercontent.com/u/3036960?v=3","gravatar_id":"","url":"https://api.github.com/users/permcody","html_url":"https://github.com/permcody","followers_url":"https://api.github.com/users/permcody/followers","following_url":"https://api.github.com/users/permcody/following{/other_user}","gists_url":"https://api.github.com/users/permcody/gists{/gist_id}","starred_url":"https://api.github.com/users/permcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/permcody/subscriptions","organizations_url":"https://api.github.com/users/permcody/orgs","repos_url":"https://api.github.com/users/permcody/repos","events_url":"https://api.github.com/users/permcody/events{/privacy}","received_events_url":"https://api.github.com/users/permcody/received_events","type":"User","site_admin":false},"repo":{"id":16853237,"name":"moose","full_name":"permcody/moose","owner":{"login":"permcody","id":3036960,"avatar_url":"https://avatars.githubusercontent.com/u/3036960?v=3","gravatar_id":"","url":"https://api.github.com/users/permcody","html_url":"https://github.com/permcody","followers_url":"https://api.github.com/users/permcody/followers","following_url":"https://api.github.com/users/permcody/following{/other_user}","gists_url":"https://api.github.com/users/permcody/gists{/gist_id}","starred_url":"https://api.github.com/users/permcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/permcody/subscriptions","organizations_url":"https://api.github.com/users/permcody/orgs","repos_url":"https://api.github.com/users/permcody/repos","events_url":"https://api.github.com/users/permcody/events{/privacy}","received_events_url":"https://api.github.com/users/permcody/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/permcody/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":true,"url":"https://api.github.com/repos/permcody/moose","forks_url":"https://api.github.com/repos/permcody/moose/forks","keys_url":"https://api.github.com/repos/permcody/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/permcody/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/permcody/moose/teams","hooks_url":"https://api.github.com/repos/permcody/moose/hooks","issue_events_url":"https://api.github.com/repos/permcody/moose/issues/events{/number}","events_url":"https://api.github.com/repos/permcody/moose/events","assignees_url":"https://api.github.com/repos/permcody/moose/assignees{/user}","branches_url":"https://api.github.com/repos/permcody/moose/branches{/branch}","tags_url":"https://api.github.com/repos/permcody/moose/tags","blobs_url":"https://api.github.com/repos/permcody/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/permcody/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/permcody/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/permcody/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/permcody/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/permcody/moose/languages","stargazers_url":"https://api.github.com/repos/permcody/moose/stargazers","contributors_url":"https://api.github.com/repos/permcody/moose/contributors","subscribers_url":"https://api.github.com/repos/permcody/moose/subscribers","subscription_url":"https://api.github.com/repos/permcody/moose/subscription","commits_url":"https://api.github.com/repos/permcody/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/permcody/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/permcody/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/permcody/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/permcody/moose/contents/{+path}","compare_url":"https://api.github.com/repos/permcody/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/permcody/moose/merges","archive_url":"https://api.github.com/repos/permcody/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/permcody/moose/downloads","issues_url":"https://api.github.com/repos/permcody/moose/issues{/number}","pulls_url":"https://api.github.com/repos/permcody/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/permcody/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/permcody/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/permcody/moose/labels{/name}","releases_url":"https://api.github.com/repos/permcody/moose/releases{/id}","deployments_url":"https://api.github.com/repos/permcody/moose/deployments","created_at":"2014-02-15T00:18:23Z","updated_at":"2015-09-23T17:09:41Z","pushed_at":"2016-03-15T21:55:38Z","git_url":"git://github.com/permcody/moose.git","ssh_url":"git@github.com:permcody/moose.git","clone_url":"https://github.com/permcody/moose.git","svn_url":"https://github.com/permcody/moose","homepage":null,"size":128072,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"idaholab:devel","ref":"devel","sha":"84faeb654c63110c9d9a92f784329c52a558e888","user":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"repo":{"id":16851223,"name":"moose","full_name":"idaholab/moose","owner":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/idaholab/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":false,"url":"https://api.github.com/repos/idaholab/moose","forks_url":"https://api.github.com/repos/idaholab/moose/forks","keys_url":"https://api.github.com/repos/idaholab/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idaholab/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idaholab/moose/teams","hooks_url":"https://api.github.com/repos/idaholab/moose/hooks","issue_events_url":"https://api.github.com/repos/idaholab/moose/issues/events{/number}","events_url":"https://api.github.com/repos/idaholab/moose/events","assignees_url":"https://api.github.com/repos/idaholab/moose/assignees{/user}","branches_url":"https://api.github.com/repos/idaholab/moose/branches{/branch}","tags_url":"https://api.github.com/repos/idaholab/moose/tags","blobs_url":"https://api.github.com/repos/idaholab/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idaholab/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idaholab/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/idaholab/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/idaholab/moose/languages","stargazers_url":"https://api.github.com/repos/idaholab/moose/stargazers","contributors_url":"https://api.github.com/repos/idaholab/moose/contributors","subscribers_url":"https://api.github.com/repos/idaholab/moose/subscribers","subscription_url":"https://api.github.com/repos/idaholab/moose/subscription","commits_url":"https://api.github.com/repos/idaholab/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/idaholab/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/idaholab/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/idaholab/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/idaholab/moose/contents/{+path}","compare_url":"https://api.github.com/repos/idaholab/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idaholab/moose/merges","archive_url":"https://api.github.com/repos/idaholab/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idaholab/moose/downloads","issues_url":"https://api.github.com/repos/idaholab/moose/issues{/number}","pulls_url":"https://api.github.com/repos/idaholab/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/idaholab/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/idaholab/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idaholab/moose/labels{/name}","releases_url":"https://api.github.com/repos/idaholab/moose/releases{/id}","deployments_url":"https://api.github.com/repos/idaholab/moose/deployments","created_at":"2014-02-14T22:26:15Z","updated_at":"2016-03-13T13:05:38Z","pushed_at":"2016-03-16T15:42:23Z","git_url":"git://github.com/idaholab/moose.git","ssh_url":"git@github.com:idaholab/moose.git","clone_url":"https://github.com/idaholab/moose.git","svn_url":"https://github.com/idaholab/moose","homepage":"http://www.mooseframework.org","size":137626,"stargazers_count":140,"watchers_count":140,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":221,"mirror_url":null,"open_issues_count":545,"forks":221,"open_issues":545,"watchers":140,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/6591"},"html":{"href":"https://github.com/idaholab/moose/pull/6591"},"issue":{"href":"https://api.github.com/repos/idaholab/moose/issues/6591"},"comments":{"href":"https://api.github.com/repos/idaholab/moose/issues/6591/comments"},"review_comments":{"href":"https://api.github.com/repos/idaholab/moose/pulls/6591/comments"},"review_comment":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/idaholab/moose/pulls/6591/commits"},"statuses":{"href":"https://api.github.com/repos/idaholab/moose/statuses/a20165253410cfe9bfc05d3c3b04e1da92707c03"}}}}