{"action":"created","issue":{"url":"https://api.github.com/repos/expressjs/express/issues/3055","repository_url":"https://api.github.com/repos/expressjs/express","labels_url":"https://api.github.com/repos/expressjs/express/issues/3055/labels{/name}","comments_url":"https://api.github.com/repos/expressjs/express/issues/3055/comments","events_url":"https://api.github.com/repos/expressjs/express/issues/3055/events","html_url":"https://github.com/expressjs/express/pull/3055","id":171145019,"number":3055,"title":"Fix Issue #2652 concerning V8 decodeURIComponent().","user":{"login":"mykiimike","id":7666506,"avatar_url":"https://avatars.githubusercontent.com/u/7666506?v=3","gravatar_id":"","url":"https://api.github.com/users/mykiimike","html_url":"https://github.com/mykiimike","followers_url":"https://api.github.com/users/mykiimike/followers","following_url":"https://api.github.com/users/mykiimike/following{/other_user}","gists_url":"https://api.github.com/users/mykiimike/gists{/gist_id}","starred_url":"https://api.github.com/users/mykiimike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykiimike/subscriptions","organizations_url":"https://api.github.com/users/mykiimike/orgs","repos_url":"https://api.github.com/users/mykiimike/repos","events_url":"https://api.github.com/users/mykiimike/events{/privacy}","received_events_url":"https://api.github.com/users/mykiimike/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-15T10:22:01Z","updated_at":"2016-08-15T11:07:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/expressjs/express/pulls/3055","html_url":"https://github.com/expressjs/express/pull/3055","diff_url":"https://github.com/expressjs/express/pull/3055.diff","patch_url":"https://github.com/expressjs/express/pull/3055.patch"},"body":"Hi,\r\n\r\nThis Error throwed by V8 Engine using decodeURIComponent() Was Very Disturbing To Me. \r\nIt is easy to reproduce. Just send an URI with gt/lt like (/un/known/route/<%= this what i used %>) in an unknown route and you will get the issue.\r\nThis Could also lead to a DoS issue because I was not able to catch the throwed error then the process goes down and that why i made the modification. \r\nI Replaced the decoding by the Native Nodejs URL Parser.\r\n\r\nCheers\r\nMichael"},"comment":{"url":"https://api.github.com/repos/expressjs/express/issues/comments/239778629","html_url":"https://github.com/expressjs/express/pull/3055#issuecomment-239778629","issue_url":"https://api.github.com/repos/expressjs/express/issues/3055","id":239778629,"user":{"login":"mykiimike","id":7666506,"avatar_url":"https://avatars.githubusercontent.com/u/7666506?v=3","gravatar_id":"","url":"https://api.github.com/users/mykiimike","html_url":"https://github.com/mykiimike","followers_url":"https://api.github.com/users/mykiimike/followers","following_url":"https://api.github.com/users/mykiimike/following{/other_user}","gists_url":"https://api.github.com/users/mykiimike/gists{/gist_id}","starred_url":"https://api.github.com/users/mykiimike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykiimike/subscriptions","organizations_url":"https://api.github.com/users/mykiimike/orgs","repos_url":"https://api.github.com/users/mykiimike/repos","events_url":"https://api.github.com/users/mykiimike/events{/privacy}","received_events_url":"https://api.github.com/users/mykiimike/received_events","type":"User","site_admin":false},"created_at":"2016-08-15T11:07:12Z","updated_at":"2016-08-15T11:07:12Z","body":"@blakeembrey Yes i just catch the real problem. So, yes url.parse() does not make sense. It fixs my problem and create new one. But this stills a problem. Just adding % in the request URI and the express process downs. \r\n\r\nThis is just because express tests must accept % without encoding (%25). It is a strange behavior of decodeURI()-like that does not catch % is an invalid unicode. BUT in the same way you will have problem if you put % followed of a valid unicode that the coder did not except :]. \r\n\r\n@blakeembrey i will look at the error handler\r\n"}}
{"actor":{"display_login":"mykiimike"}}