{"action":"created","issue":{"url":"https://api.github.com/repos/Payum/Payum/issues/609","repository_url":"https://api.github.com/repos/Payum/Payum","labels_url":"https://api.github.com/repos/Payum/Payum/issues/609/labels{/name}","comments_url":"https://api.github.com/repos/Payum/Payum/issues/609/comments","events_url":"https://api.github.com/repos/Payum/Payum/issues/609/events","html_url":"https://github.com/Payum/Payum/issues/609","id":197682656,"number":609,"title":"Reversed and Cancel Reversal statuses","user":{"login":"Great-Antique","id":1128310,"avatar_url":"https://avatars.githubusercontent.com/u/1128310?v=3","gravatar_id":"","url":"https://api.github.com/users/Great-Antique","html_url":"https://github.com/Great-Antique","followers_url":"https://api.github.com/users/Great-Antique/followers","following_url":"https://api.github.com/users/Great-Antique/following{/other_user}","gists_url":"https://api.github.com/users/Great-Antique/gists{/gist_id}","starred_url":"https://api.github.com/users/Great-Antique/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Great-Antique/subscriptions","organizations_url":"https://api.github.com/users/Great-Antique/orgs","repos_url":"https://api.github.com/users/Great-Antique/repos","events_url":"https://api.github.com/users/Great-Antique/events{/privacy}","received_events_url":"https://api.github.com/users/Great-Antique/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-27T10:32:34Z","updated_at":"2016-12-28T11:54:17Z","closed_at":null,"body":"There are some questions about above-mentioned statuses.\r\n\r\n1. Why do we mark Payment as failed if `PAYMENTREQUEST_n_PAYMENTSTATUS` is `Api::PAYMENTSTATUS_CANCELED_REVERSAL`?\r\n\r\nAfaik Payment has transitions `Completed/Processed -> Reversed` and `Reversed -> Canceled-Reversal`. So `Canceled-Reversal` means that Payment is `Completed/Processed` again and as I understand we should mark it as captured but not as failed.\r\n\r\n2. Why don't we process `Reversed` status?\r\nShould we add\r\n* `GetHumanStatus::STATUS_REVERSED` and `GetBinaryStatus::STATUS_REVERSED` constants\r\n* `GetStatusInterface::isReversed()` and `GetStatusInterface::markReversed()` methods\r\n?"},"comment":{"url":"https://api.github.com/repos/Payum/Payum/issues/comments/269467299","html_url":"https://github.com/Payum/Payum/issues/609#issuecomment-269467299","issue_url":"https://api.github.com/repos/Payum/Payum/issues/609","id":269467299,"user":{"login":"makasim","id":143206,"avatar_url":"https://avatars.githubusercontent.com/u/143206?v=3","gravatar_id":"","url":"https://api.github.com/users/makasim","html_url":"https://github.com/makasim","followers_url":"https://api.github.com/users/makasim/followers","following_url":"https://api.github.com/users/makasim/following{/other_user}","gists_url":"https://api.github.com/users/makasim/gists{/gist_id}","starred_url":"https://api.github.com/users/makasim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makasim/subscriptions","organizations_url":"https://api.github.com/users/makasim/orgs","repos_url":"https://api.github.com/users/makasim/repos","events_url":"https://api.github.com/users/makasim/events{/privacy}","received_events_url":"https://api.github.com/users/makasim/received_events","type":"User","site_admin":false},"created_at":"2016-12-28T11:54:17Z","updated_at":"2016-12-28T11:54:17Z","body":"> 1. Why do we mark Payment as failed if PAYMENTREQUEST_n_PAYMENTSTATUS is Api::PAYMENTSTATUS_CANCELED_REVERSAL?\r\n\r\nI am not sure, we have to dig into paypal's doc. As for me `Reversed` sounds like cancelled or failed but not captured.\r\n\r\n> Why don't we process Reversed status?\r\nMissing feature? \r\n\r\n"}}
{"actor":{"display_login":"makasim"}}