{"action":"created","comment":{"url":"https://api.github.com/repos/google/openhtf/pulls/comments/65277746","id":65277746,"diff_hunk":"@@ -339,8 +339,12 @@ def __call__(self, phase_data):\n     kwargs.update(phase_data.plug_manager.ProvidePlugs(\n         (plug.name, plug.cls) for plug in self.plugs if plug.update_kwargs))\n     arg_info = inspect.getargspec(self.func)\n-    if len(arg_info.args) == len(kwargs) and not arg_info.varargs:\n-      # Underlying function has no room for phase_data as an arg. If it expects\n-      # it but miscounted arguments, we'll get another error farther down.\n-      return self.func(**kwargs)\n-    return self.func(phase_data, **kwargs)\n+    arbitrary_args = arg_info.varargs or arg_info.keywords","path":"openhtf/__init__.py","position":null,"original_position":9,"commit_id":"1b2b2181079dd5c3dbc934ea213e1b0c6ac41bca","original_commit_id":"47cf8d66917971e014cd70caa8f237a70f5b1c49","user":{"login":"fahhem","id":306100,"avatar_url":"https://avatars.githubusercontent.com/u/306100?v=3","gravatar_id":"","url":"https://api.github.com/users/fahhem","html_url":"https://github.com/fahhem","followers_url":"https://api.github.com/users/fahhem/followers","following_url":"https://api.github.com/users/fahhem/following{/other_user}","gists_url":"https://api.github.com/users/fahhem/gists{/gist_id}","starred_url":"https://api.github.com/users/fahhem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fahhem/subscriptions","organizations_url":"https://api.github.com/users/fahhem/orgs","repos_url":"https://api.github.com/users/fahhem/repos","events_url":"https://api.github.com/users/fahhem/events{/privacy}","received_events_url":"https://api.github.com/users/fahhem/received_events","type":"User","site_admin":false},"body":"Whoops! Done","created_at":"2016-05-31T22:59:37Z","updated_at":"2016-05-31T22:59:37Z","html_url":"https://github.com/google/openhtf/pull/284#discussion_r65277746","pull_request_url":"https://api.github.com/repos/google/openhtf/pulls/284","_links":{"self":{"href":"https://api.github.com/repos/google/openhtf/pulls/comments/65277746"},"html":{"href":"https://github.com/google/openhtf/pull/284#discussion_r65277746"},"pull_request":{"href":"https://api.github.com/repos/google/openhtf/pulls/284"}}},"pull_request":{"url":"https://api.github.com/repos/google/openhtf/pulls/284","id":71945856,"html_url":"https://github.com/google/openhtf/pull/284","diff_url":"https://github.com/google/openhtf/pull/284.diff","patch_url":"https://github.com/google/openhtf/pull/284.patch","issue_url":"https://api.github.com/repos/google/openhtf/issues/284","number":284,"state":"open","locked":false,"title":"phases can take phase_data in *args or **kwargs","user":{"login":"fahhem","id":306100,"avatar_url":"https://avatars.githubusercontent.com/u/306100?v=3","gravatar_id":"","url":"https://api.github.com/users/fahhem","html_url":"https://github.com/fahhem","followers_url":"https://api.github.com/users/fahhem/followers","following_url":"https://api.github.com/users/fahhem/following{/other_user}","gists_url":"https://api.github.com/users/fahhem/gists{/gist_id}","starred_url":"https://api.github.com/users/fahhem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fahhem/subscriptions","organizations_url":"https://api.github.com/users/fahhem/orgs","repos_url":"https://api.github.com/users/fahhem/repos","events_url":"https://api.github.com/users/fahhem/events{/privacy}","received_events_url":"https://api.github.com/users/fahhem/received_events","type":"User","site_admin":false},"body":"```py\r\ndef Phase(test, **kwargs):\r\n  pass\r\n\r\ngetargspec(Phase) == ArgSpec(args=('test',), varargs=None, keywords='kwargs', defaults=None)\r\n```\r\n\r\nWhich means doing Phase.WithArgs(something=1) makes that phase no longer take the test object, whether it wanted it or not.\r\n\r\nI have an inkling there's a case where this isn't a good idea, but I can't make it do the wrong thing at the moment. ","created_at":"2016-05-31T00:28:11Z","updated_at":"2016-05-31T22:59:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9921f4c672d7f86f5f20e70301b2fbba7fb2e287","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/openhtf/pulls/284/commits","review_comments_url":"https://api.github.com/repos/google/openhtf/pulls/284/comments","review_comment_url":"https://api.github.com/repos/google/openhtf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/openhtf/issues/284/comments","statuses_url":"https://api.github.com/repos/google/openhtf/statuses/1b2b2181079dd5c3dbc934ea213e1b0c6ac41bca","head":{"label":"fahhem:patch-19","ref":"patch-19","sha":"1b2b2181079dd5c3dbc934ea213e1b0c6ac41bca","user":{"login":"fahhem","id":306100,"avatar_url":"https://avatars.githubusercontent.com/u/306100?v=3","gravatar_id":"","url":"https://api.github.com/users/fahhem","html_url":"https://github.com/fahhem","followers_url":"https://api.github.com/users/fahhem/followers","following_url":"https://api.github.com/users/fahhem/following{/other_user}","gists_url":"https://api.github.com/users/fahhem/gists{/gist_id}","starred_url":"https://api.github.com/users/fahhem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fahhem/subscriptions","organizations_url":"https://api.github.com/users/fahhem/orgs","repos_url":"https://api.github.com/users/fahhem/repos","events_url":"https://api.github.com/users/fahhem/events{/privacy}","received_events_url":"https://api.github.com/users/fahhem/received_events","type":"User","site_admin":false},"repo":{"id":41762559,"name":"openhtf","full_name":"fahhem/openhtf","owner":{"login":"fahhem","id":306100,"avatar_url":"https://avatars.githubusercontent.com/u/306100?v=3","gravatar_id":"","url":"https://api.github.com/users/fahhem","html_url":"https://github.com/fahhem","followers_url":"https://api.github.com/users/fahhem/followers","following_url":"https://api.github.com/users/fahhem/following{/other_user}","gists_url":"https://api.github.com/users/fahhem/gists{/gist_id}","starred_url":"https://api.github.com/users/fahhem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fahhem/subscriptions","organizations_url":"https://api.github.com/users/fahhem/orgs","repos_url":"https://api.github.com/users/fahhem/repos","events_url":"https://api.github.com/users/fahhem/events{/privacy}","received_events_url":"https://api.github.com/users/fahhem/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fahhem/openhtf","description":null,"fork":true,"url":"https://api.github.com/repos/fahhem/openhtf","forks_url":"https://api.github.com/repos/fahhem/openhtf/forks","keys_url":"https://api.github.com/repos/fahhem/openhtf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fahhem/openhtf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fahhem/openhtf/teams","hooks_url":"https://api.github.com/repos/fahhem/openhtf/hooks","issue_events_url":"https://api.github.com/repos/fahhem/openhtf/issues/events{/number}","events_url":"https://api.github.com/repos/fahhem/openhtf/events","assignees_url":"https://api.github.com/repos/fahhem/openhtf/assignees{/user}","branches_url":"https://api.github.com/repos/fahhem/openhtf/branches{/branch}","tags_url":"https://api.github.com/repos/fahhem/openhtf/tags","blobs_url":"https://api.github.com/repos/fahhem/openhtf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fahhem/openhtf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fahhem/openhtf/git/refs{/sha}","trees_url":"https://api.github.com/repos/fahhem/openhtf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fahhem/openhtf/statuses/{sha}","languages_url":"https://api.github.com/repos/fahhem/openhtf/languages","stargazers_url":"https://api.github.com/repos/fahhem/openhtf/stargazers","contributors_url":"https://api.github.com/repos/fahhem/openhtf/contributors","subscribers_url":"https://api.github.com/repos/fahhem/openhtf/subscribers","subscription_url":"https://api.github.com/repos/fahhem/openhtf/subscription","commits_url":"https://api.github.com/repos/fahhem/openhtf/commits{/sha}","git_commits_url":"https://api.github.com/repos/fahhem/openhtf/git/commits{/sha}","comments_url":"https://api.github.com/repos/fahhem/openhtf/comments{/number}","issue_comment_url":"https://api.github.com/repos/fahhem/openhtf/issues/comments{/number}","contents_url":"https://api.github.com/repos/fahhem/openhtf/contents/{+path}","compare_url":"https://api.github.com/repos/fahhem/openhtf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fahhem/openhtf/merges","archive_url":"https://api.github.com/repos/fahhem/openhtf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fahhem/openhtf/downloads","issues_url":"https://api.github.com/repos/fahhem/openhtf/issues{/number}","pulls_url":"https://api.github.com/repos/fahhem/openhtf/pulls{/number}","milestones_url":"https://api.github.com/repos/fahhem/openhtf/milestones{/number}","notifications_url":"https://api.github.com/repos/fahhem/openhtf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fahhem/openhtf/labels{/name}","releases_url":"https://api.github.com/repos/fahhem/openhtf/releases{/id}","deployments_url":"https://api.github.com/repos/fahhem/openhtf/deployments","created_at":"2015-09-01T20:48:21Z","updated_at":"2016-01-13T17:54:30Z","pushed_at":"2016-05-31T22:59:04Z","git_url":"git://github.com/fahhem/openhtf.git","ssh_url":"git@github.com:fahhem/openhtf.git","clone_url":"https://github.com/fahhem/openhtf.git","svn_url":"https://github.com/fahhem/openhtf","homepage":null,"size":18720,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"0d86208e40f53b6ab1c45e28fcf3166838b1c23f","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":41519483,"name":"openhtf","full_name":"google/openhtf","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/openhtf","description":null,"fork":false,"url":"https://api.github.com/repos/google/openhtf","forks_url":"https://api.github.com/repos/google/openhtf/forks","keys_url":"https://api.github.com/repos/google/openhtf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/openhtf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/openhtf/teams","hooks_url":"https://api.github.com/repos/google/openhtf/hooks","issue_events_url":"https://api.github.com/repos/google/openhtf/issues/events{/number}","events_url":"https://api.github.com/repos/google/openhtf/events","assignees_url":"https://api.github.com/repos/google/openhtf/assignees{/user}","branches_url":"https://api.github.com/repos/google/openhtf/branches{/branch}","tags_url":"https://api.github.com/repos/google/openhtf/tags","blobs_url":"https://api.github.com/repos/google/openhtf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/openhtf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/openhtf/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/openhtf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/openhtf/statuses/{sha}","languages_url":"https://api.github.com/repos/google/openhtf/languages","stargazers_url":"https://api.github.com/repos/google/openhtf/stargazers","contributors_url":"https://api.github.com/repos/google/openhtf/contributors","subscribers_url":"https://api.github.com/repos/google/openhtf/subscribers","subscription_url":"https://api.github.com/repos/google/openhtf/subscription","commits_url":"https://api.github.com/repos/google/openhtf/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/openhtf/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/openhtf/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/openhtf/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/openhtf/contents/{+path}","compare_url":"https://api.github.com/repos/google/openhtf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/openhtf/merges","archive_url":"https://api.github.com/repos/google/openhtf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/openhtf/downloads","issues_url":"https://api.github.com/repos/google/openhtf/issues{/number}","pulls_url":"https://api.github.com/repos/google/openhtf/pulls{/number}","milestones_url":"https://api.github.com/repos/google/openhtf/milestones{/number}","notifications_url":"https://api.github.com/repos/google/openhtf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/openhtf/labels{/name}","releases_url":"https://api.github.com/repos/google/openhtf/releases{/id}","deployments_url":"https://api.github.com/repos/google/openhtf/deployments","created_at":"2015-08-28T01:14:17Z","updated_at":"2016-05-23T09:29:59Z","pushed_at":"2016-05-31T22:59:05Z","git_url":"git://github.com/google/openhtf.git","ssh_url":"git@github.com:google/openhtf.git","clone_url":"https://github.com/google/openhtf.git","svn_url":"https://github.com/google/openhtf","homepage":null,"size":24896,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":68,"forks":19,"open_issues":68,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/openhtf/pulls/284"},"html":{"href":"https://github.com/google/openhtf/pull/284"},"issue":{"href":"https://api.github.com/repos/google/openhtf/issues/284"},"comments":{"href":"https://api.github.com/repos/google/openhtf/issues/284/comments"},"review_comments":{"href":"https://api.github.com/repos/google/openhtf/pulls/284/comments"},"review_comment":{"href":"https://api.github.com/repos/google/openhtf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/openhtf/pulls/284/commits"},"statuses":{"href":"https://api.github.com/repos/google/openhtf/statuses/1b2b2181079dd5c3dbc934ea213e1b0c6ac41bca"}}}}
{"actor":{"display_login":"fahhem"}}