{"action":"created","issue":{"url":"https://api.github.com/repos/resibots/limbo/issues/154","repository_url":"https://api.github.com/repos/resibots/limbo","labels_url":"https://api.github.com/repos/resibots/limbo/issues/154/labels{/name}","comments_url":"https://api.github.com/repos/resibots/limbo/issues/154/comments","events_url":"https://api.github.com/repos/resibots/limbo/issues/154/events","html_url":"https://github.com/resibots/limbo/pull/154","id":173148655,"number":154,"title":"Fix for #151","user":{"login":"costashatz","id":1283922,"avatar_url":"https://avatars.githubusercontent.com/u/1283922?v=3","gravatar_id":"","url":"https://api.github.com/users/costashatz","html_url":"https://github.com/costashatz","followers_url":"https://api.github.com/users/costashatz/followers","following_url":"https://api.github.com/users/costashatz/following{/other_user}","gists_url":"https://api.github.com/users/costashatz/gists{/gist_id}","starred_url":"https://api.github.com/users/costashatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costashatz/subscriptions","organizations_url":"https://api.github.com/users/costashatz/orgs","repos_url":"https://api.github.com/users/costashatz/repos","events_url":"https://api.github.com/users/costashatz/events{/privacy}","received_events_url":"https://api.github.com/users/costashatz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-25T08:57:59Z","updated_at":"2016-08-25T09:08:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/resibots/limbo/pulls/154","html_url":"https://github.com/resibots/limbo/pull/154","diff_url":"https://github.com/resibots/limbo/pull/154.diff","patch_url":"https://github.com/resibots/limbo/pull/154.patch"},"body":"As discussed in #151, I added a question in the FAQ. Probably it needs some rephrasing..\r\n"},"comment":{"url":"https://api.github.com/repos/resibots/limbo/issues/comments/242324799","html_url":"https://github.com/resibots/limbo/pull/154#issuecomment-242324799","issue_url":"https://api.github.com/repos/resibots/limbo/issues/154","id":242324799,"user":{"login":"costashatz","id":1283922,"avatar_url":"https://avatars.githubusercontent.com/u/1283922?v=3","gravatar_id":"","url":"https://api.github.com/users/costashatz","html_url":"https://github.com/costashatz","followers_url":"https://api.github.com/users/costashatz/followers","following_url":"https://api.github.com/users/costashatz/following{/other_user}","gists_url":"https://api.github.com/users/costashatz/gists{/gist_id}","starred_url":"https://api.github.com/users/costashatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costashatz/subscriptions","organizations_url":"https://api.github.com/users/costashatz/orgs","repos_url":"https://api.github.com/users/costashatz/repos","events_url":"https://api.github.com/users/costashatz/events{/privacy}","received_events_url":"https://api.github.com/users/costashatz/received_events","type":"User","site_admin":false},"created_at":"2016-08-25T09:08:59Z","updated_at":"2016-08-25T09:08:59Z","body":"> Should we add the opposite assertion (for consistency): throw an assert if\r\n> we do not have NoLFOpt but hp_period == -1?\r\n\r\nWe could. But this would go into `BOptimizer` and thus it is not that easy to check the model type. An alternative solution would be to transfer all the HP Optimization to the GP. This would mean that the `hp_period` would be a parameter of the GP model. Then it is easy to create both assertions and I think it could be cleaner for the user. What do you think?"}}
{"actor":{"display_login":"costashatz"}}