{"action":"created","comment":{"url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/pulls/comments/50476202","id":50476202,"diff_hunk":"@@ -224,4 +238,4 @@ def _repeat_fatal_error(self):\n         error = conf.fatal_error_suggestion().format(self._fatal_error)\n         self._logger.error(error)\n         self._ipython_display.send_error(error)\n-        raise ValueError(self._fatal_error)\n+        return self._complete_cell()","path":"remotespark/wrapperkernel/sparkkernelbase.py","position":162,"original_position":154,"commit_id":"14379469e74b4fc5eab906adc3718e571a19364b","original_commit_id":"39478444b5b9d3d5bc31f8f6e4b79fcd84645551","user":{"login":"aggFTW","id":654204,"avatar_url":"https://avatars.githubusercontent.com/u/654204?v=3","gravatar_id":"","url":"https://api.github.com/users/aggFTW","html_url":"https://github.com/aggFTW","followers_url":"https://api.github.com/users/aggFTW/followers","following_url":"https://api.github.com/users/aggFTW/following{/other_user}","gists_url":"https://api.github.com/users/aggFTW/gists{/gist_id}","starred_url":"https://api.github.com/users/aggFTW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aggFTW/subscriptions","organizations_url":"https://api.github.com/users/aggFTW/orgs","repos_url":"https://api.github.com/users/aggFTW/repos","events_url":"https://api.github.com/users/aggFTW/events{/privacy}","received_events_url":"https://api.github.com/users/aggFTW/received_events","type":"User","site_admin":false},"body":"Should we add unit tests?","created_at":"2016-01-21T22:37:50Z","updated_at":"2016-01-21T22:37:50Z","html_url":"https://github.com/jupyter-incubator/sparkmagic/pull/140#discussion_r50476202","pull_request_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/pulls/140","_links":{"self":{"href":"https://api.github.com/repos/jupyter-incubator/sparkmagic/pulls/comments/50476202"},"html":{"href":"https://github.com/jupyter-incubator/sparkmagic/pull/140#discussion_r50476202"},"pull_request":{"href":"https://api.github.com/repos/jupyter-incubator/sparkmagic/pulls/140"}}},"pull_request":{"url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/pulls/140","id":56809805,"html_url":"https://github.com/jupyter-incubator/sparkmagic/pull/140","diff_url":"https://github.com/jupyter-incubator/sparkmagic/pull/140.diff","patch_url":"https://github.com/jupyter-incubator/sparkmagic/pull/140.patch","issue_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/issues/140","number":140,"state":"open","locked":false,"title":"Graceful error handling for wrapper kernels","user":{"login":"msftristew","id":13972471,"avatar_url":"https://avatars.githubusercontent.com/u/13972471?v=3","gravatar_id":"","url":"https://api.github.com/users/msftristew","html_url":"https://github.com/msftristew","followers_url":"https://api.github.com/users/msftristew/followers","following_url":"https://api.github.com/users/msftristew/following{/other_user}","gists_url":"https://api.github.com/users/msftristew/gists{/gist_id}","starred_url":"https://api.github.com/users/msftristew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msftristew/subscriptions","organizations_url":"https://api.github.com/users/msftristew/orgs","repos_url":"https://api.github.com/users/msftristew/repos","events_url":"https://api.github.com/users/msftristew/events{/privacy}","received_events_url":"https://api.github.com/users/msftristew/received_events","type":"User","site_admin":false},"body":"Improve error handling for wrapper kernels, especially for unexpected errors.  Also ensure that cells complete their execution from Jupyter's UI if an error is encountered.\r\n\r\nCloses #138 ","created_at":"2016-01-21T21:11:59Z","updated_at":"2016-01-21T22:37:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f3e8aec0acf22f364b0eb53403cdc1a6cf040f6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/pulls/140/commits","review_comments_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/pulls/140/comments","review_comment_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/issues/140/comments","statuses_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/statuses/14379469e74b4fc5eab906adc3718e571a19364b","head":{"label":"msftristew:gracefulerrors","ref":"gracefulerrors","sha":"14379469e74b4fc5eab906adc3718e571a19364b","user":{"login":"msftristew","id":13972471,"avatar_url":"https://avatars.githubusercontent.com/u/13972471?v=3","gravatar_id":"","url":"https://api.github.com/users/msftristew","html_url":"https://github.com/msftristew","followers_url":"https://api.github.com/users/msftristew/followers","following_url":"https://api.github.com/users/msftristew/following{/other_user}","gists_url":"https://api.github.com/users/msftristew/gists{/gist_id}","starred_url":"https://api.github.com/users/msftristew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msftristew/subscriptions","organizations_url":"https://api.github.com/users/msftristew/orgs","repos_url":"https://api.github.com/users/msftristew/repos","events_url":"https://api.github.com/users/msftristew/events{/privacy}","received_events_url":"https://api.github.com/users/msftristew/received_events","type":"User","site_admin":false},"repo":{"id":46371305,"name":"sparkmagic","full_name":"msftristew/sparkmagic","owner":{"login":"msftristew","id":13972471,"avatar_url":"https://avatars.githubusercontent.com/u/13972471?v=3","gravatar_id":"","url":"https://api.github.com/users/msftristew","html_url":"https://github.com/msftristew","followers_url":"https://api.github.com/users/msftristew/followers","following_url":"https://api.github.com/users/msftristew/following{/other_user}","gists_url":"https://api.github.com/users/msftristew/gists{/gist_id}","starred_url":"https://api.github.com/users/msftristew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msftristew/subscriptions","organizations_url":"https://api.github.com/users/msftristew/orgs","repos_url":"https://api.github.com/users/msftristew/repos","events_url":"https://api.github.com/users/msftristew/events{/privacy}","received_events_url":"https://api.github.com/users/msftristew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msftristew/sparkmagic","description":"IPython magics for working with remote Spark clusters","fork":true,"url":"https://api.github.com/repos/msftristew/sparkmagic","forks_url":"https://api.github.com/repos/msftristew/sparkmagic/forks","keys_url":"https://api.github.com/repos/msftristew/sparkmagic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msftristew/sparkmagic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msftristew/sparkmagic/teams","hooks_url":"https://api.github.com/repos/msftristew/sparkmagic/hooks","issue_events_url":"https://api.github.com/repos/msftristew/sparkmagic/issues/events{/number}","events_url":"https://api.github.com/repos/msftristew/sparkmagic/events","assignees_url":"https://api.github.com/repos/msftristew/sparkmagic/assignees{/user}","branches_url":"https://api.github.com/repos/msftristew/sparkmagic/branches{/branch}","tags_url":"https://api.github.com/repos/msftristew/sparkmagic/tags","blobs_url":"https://api.github.com/repos/msftristew/sparkmagic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msftristew/sparkmagic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msftristew/sparkmagic/git/refs{/sha}","trees_url":"https://api.github.com/repos/msftristew/sparkmagic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msftristew/sparkmagic/statuses/{sha}","languages_url":"https://api.github.com/repos/msftristew/sparkmagic/languages","stargazers_url":"https://api.github.com/repos/msftristew/sparkmagic/stargazers","contributors_url":"https://api.github.com/repos/msftristew/sparkmagic/contributors","subscribers_url":"https://api.github.com/repos/msftristew/sparkmagic/subscribers","subscription_url":"https://api.github.com/repos/msftristew/sparkmagic/subscription","commits_url":"https://api.github.com/repos/msftristew/sparkmagic/commits{/sha}","git_commits_url":"https://api.github.com/repos/msftristew/sparkmagic/git/commits{/sha}","comments_url":"https://api.github.com/repos/msftristew/sparkmagic/comments{/number}","issue_comment_url":"https://api.github.com/repos/msftristew/sparkmagic/issues/comments{/number}","contents_url":"https://api.github.com/repos/msftristew/sparkmagic/contents/{+path}","compare_url":"https://api.github.com/repos/msftristew/sparkmagic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msftristew/sparkmagic/merges","archive_url":"https://api.github.com/repos/msftristew/sparkmagic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msftristew/sparkmagic/downloads","issues_url":"https://api.github.com/repos/msftristew/sparkmagic/issues{/number}","pulls_url":"https://api.github.com/repos/msftristew/sparkmagic/pulls{/number}","milestones_url":"https://api.github.com/repos/msftristew/sparkmagic/milestones{/number}","notifications_url":"https://api.github.com/repos/msftristew/sparkmagic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msftristew/sparkmagic/labels{/name}","releases_url":"https://api.github.com/repos/msftristew/sparkmagic/releases{/id}","created_at":"2015-11-17T19:49:34Z","updated_at":"2016-01-13T00:32:42Z","pushed_at":"2016-01-21T22:33:49Z","git_url":"git://github.com/msftristew/sparkmagic.git","ssh_url":"git@github.com:msftristew/sparkmagic.git","clone_url":"https://github.com/msftristew/sparkmagic.git","svn_url":"https://github.com/msftristew/sparkmagic","homepage":null,"size":394,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupyter-incubator:master","ref":"master","sha":"a48f195a5a5d387b01b9de65d44a575135203aa3","user":{"login":"jupyter-incubator","id":14002361,"avatar_url":"https://avatars.githubusercontent.com/u/14002361?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter-incubator","html_url":"https://github.com/jupyter-incubator","followers_url":"https://api.github.com/users/jupyter-incubator/followers","following_url":"https://api.github.com/users/jupyter-incubator/following{/other_user}","gists_url":"https://api.github.com/users/jupyter-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter-incubator/subscriptions","organizations_url":"https://api.github.com/users/jupyter-incubator/orgs","repos_url":"https://api.github.com/users/jupyter-incubator/repos","events_url":"https://api.github.com/users/jupyter-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":42875585,"name":"sparkmagic","full_name":"jupyter-incubator/sparkmagic","owner":{"login":"jupyter-incubator","id":14002361,"avatar_url":"https://avatars.githubusercontent.com/u/14002361?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter-incubator","html_url":"https://github.com/jupyter-incubator","followers_url":"https://api.github.com/users/jupyter-incubator/followers","following_url":"https://api.github.com/users/jupyter-incubator/following{/other_user}","gists_url":"https://api.github.com/users/jupyter-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter-incubator/subscriptions","organizations_url":"https://api.github.com/users/jupyter-incubator/orgs","repos_url":"https://api.github.com/users/jupyter-incubator/repos","events_url":"https://api.github.com/users/jupyter-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jupyter-incubator/sparkmagic","description":"IPython magics for working with remote Spark clusters","fork":false,"url":"https://api.github.com/repos/jupyter-incubator/sparkmagic","forks_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/forks","keys_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/teams","hooks_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/hooks","issue_events_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/issues/events{/number}","events_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/events","assignees_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/assignees{/user}","branches_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/branches{/branch}","tags_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/tags","blobs_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/languages","stargazers_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/stargazers","contributors_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/contributors","subscribers_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/subscribers","subscription_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/subscription","commits_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/contents/{+path}","compare_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/merges","archive_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/downloads","issues_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/issues{/number}","pulls_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/labels{/name}","releases_url":"https://api.github.com/repos/jupyter-incubator/sparkmagic/releases{/id}","created_at":"2015-09-21T15:35:25Z","updated_at":"2016-01-20T21:57:44Z","pushed_at":"2016-01-21T22:33:49Z","git_url":"git://github.com/jupyter-incubator/sparkmagic.git","ssh_url":"git@github.com:jupyter-incubator/sparkmagic.git","clone_url":"https://github.com/jupyter-incubator/sparkmagic.git","svn_url":"https://github.com/jupyter-incubator/sparkmagic","homepage":null,"size":424,"stargazers_count":30,"watchers_count":30,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":12,"forks":6,"open_issues":12,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyter-incubator/sparkmagic/pulls/140"},"html":{"href":"https://github.com/jupyter-incubator/sparkmagic/pull/140"},"issue":{"href":"https://api.github.com/repos/jupyter-incubator/sparkmagic/issues/140"},"comments":{"href":"https://api.github.com/repos/jupyter-incubator/sparkmagic/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyter-incubator/sparkmagic/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyter-incubator/sparkmagic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyter-incubator/sparkmagic/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/jupyter-incubator/sparkmagic/statuses/14379469e74b4fc5eab906adc3718e571a19364b"}}}}