{"action":"created","comment":{"url":"https://api.github.com/repos/contiv/volplugin/pulls/comments/72368405","id":72368405,"diff_hunk":"@@ -57,3 +64,31 @@ func NewSnapshotDriver(backend string) (storage.SnapshotDriver, error) {\n \n \treturn f()\n }\n+\n+// NewDriver creates a driver based on driverType\n+func NewDriver(backend string, driverType string, mountPath string, do storage.DriverOptions) error {\n+\tif backend != \"\" {\n+\t\tif driverType == CRUD {\n+\t\t\tif curd, err := NewCRUDDriver(backend); err != nil {","path":"storage/backend/backends.go","position":23,"original_position":23,"commit_id":"de036c928b2bc124e2340acbf576bd0cb54d8d2e","original_commit_id":"de036c928b2bc124e2340acbf576bd0cb54d8d2e","user":{"login":"erikh","id":18923,"avatar_url":"https://avatars.githubusercontent.com/u/18923?v=3","gravatar_id":"","url":"https://api.github.com/users/erikh","html_url":"https://github.com/erikh","followers_url":"https://api.github.com/users/erikh/followers","following_url":"https://api.github.com/users/erikh/following{/other_user}","gists_url":"https://api.github.com/users/erikh/gists{/gist_id}","starred_url":"https://api.github.com/users/erikh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikh/subscriptions","organizations_url":"https://api.github.com/users/erikh/orgs","repos_url":"https://api.github.com/users/erikh/repos","events_url":"https://api.github.com/users/erikh/events{/privacy}","received_events_url":"https://api.github.com/users/erikh/received_events","type":"User","site_admin":false},"body":"misspelled `crud`","created_at":"2016-07-27T01:37:48Z","updated_at":"2016-07-27T01:37:48Z","html_url":"https://github.com/contiv/volplugin/pull/366#discussion_r72368405","pull_request_url":"https://api.github.com/repos/contiv/volplugin/pulls/366","_links":{"self":{"href":"https://api.github.com/repos/contiv/volplugin/pulls/comments/72368405"},"html":{"href":"https://github.com/contiv/volplugin/pull/366#discussion_r72368405"},"pull_request":{"href":"https://api.github.com/repos/contiv/volplugin/pulls/366"}}},"pull_request":{"url":"https://api.github.com/repos/contiv/volplugin/pulls/366","id":78890221,"html_url":"https://github.com/contiv/volplugin/pull/366","diff_url":"https://github.com/contiv/volplugin/pull/366.diff","patch_url":"https://github.com/contiv/volplugin/pull/366.patch","issue_url":"https://api.github.com/repos/contiv/volplugin/issues/366","number":366,"state":"open","locked":false,"title":"JSON Validation","user":{"login":"yuva29","id":11082310,"avatar_url":"https://avatars.githubusercontent.com/u/11082310?v=3","gravatar_id":"","url":"https://api.github.com/users/yuva29","html_url":"https://github.com/yuva29","followers_url":"https://api.github.com/users/yuva29/followers","following_url":"https://api.github.com/users/yuva29/following{/other_user}","gists_url":"https://api.github.com/users/yuva29/gists{/gist_id}","starred_url":"https://api.github.com/users/yuva29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuva29/subscriptions","organizations_url":"https://api.github.com/users/yuva29/orgs","repos_url":"https://api.github.com/users/yuva29/repos","events_url":"https://api.github.com/users/yuva29/events{/privacy}","received_events_url":"https://api.github.com/users/yuva29/received_events","type":"User","site_admin":false},"body":"1. This simplifies “Policy” and “Volume” validations using JSON schema\r\n2. Refactor driver creation code (NewDriver)\r\n3. More rules can be added to the schema. Right now, the validation rules are defined based on earlier validation.","created_at":"2016-07-26T17:14:46Z","updated_at":"2016-07-27T01:37:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e1eb40bcf383fe204df42a7f840c9ff8c9a6a40","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/contiv/volplugin/pulls/366/commits","review_comments_url":"https://api.github.com/repos/contiv/volplugin/pulls/366/comments","review_comment_url":"https://api.github.com/repos/contiv/volplugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contiv/volplugin/issues/366/comments","statuses_url":"https://api.github.com/repos/contiv/volplugin/statuses/de036c928b2bc124e2340acbf576bd0cb54d8d2e","head":{"label":"yuva29:validation","ref":"validation","sha":"de036c928b2bc124e2340acbf576bd0cb54d8d2e","user":{"login":"yuva29","id":11082310,"avatar_url":"https://avatars.githubusercontent.com/u/11082310?v=3","gravatar_id":"","url":"https://api.github.com/users/yuva29","html_url":"https://github.com/yuva29","followers_url":"https://api.github.com/users/yuva29/followers","following_url":"https://api.github.com/users/yuva29/following{/other_user}","gists_url":"https://api.github.com/users/yuva29/gists{/gist_id}","starred_url":"https://api.github.com/users/yuva29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuva29/subscriptions","organizations_url":"https://api.github.com/users/yuva29/orgs","repos_url":"https://api.github.com/users/yuva29/repos","events_url":"https://api.github.com/users/yuva29/events{/privacy}","received_events_url":"https://api.github.com/users/yuva29/received_events","type":"User","site_admin":false},"repo":{"id":63454821,"name":"volplugin","full_name":"yuva29/volplugin","owner":{"login":"yuva29","id":11082310,"avatar_url":"https://avatars.githubusercontent.com/u/11082310?v=3","gravatar_id":"","url":"https://api.github.com/users/yuva29","html_url":"https://github.com/yuva29","followers_url":"https://api.github.com/users/yuva29/followers","following_url":"https://api.github.com/users/yuva29/following{/other_user}","gists_url":"https://api.github.com/users/yuva29/gists{/gist_id}","starred_url":"https://api.github.com/users/yuva29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuva29/subscriptions","organizations_url":"https://api.github.com/users/yuva29/orgs","repos_url":"https://api.github.com/users/yuva29/repos","events_url":"https://api.github.com/users/yuva29/events{/privacy}","received_events_url":"https://api.github.com/users/yuva29/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuva29/volplugin","description":"Contiv Storage: Policy backed Clustered Storage (via Ceph or NFS) for Docker","fork":true,"url":"https://api.github.com/repos/yuva29/volplugin","forks_url":"https://api.github.com/repos/yuva29/volplugin/forks","keys_url":"https://api.github.com/repos/yuva29/volplugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuva29/volplugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuva29/volplugin/teams","hooks_url":"https://api.github.com/repos/yuva29/volplugin/hooks","issue_events_url":"https://api.github.com/repos/yuva29/volplugin/issues/events{/number}","events_url":"https://api.github.com/repos/yuva29/volplugin/events","assignees_url":"https://api.github.com/repos/yuva29/volplugin/assignees{/user}","branches_url":"https://api.github.com/repos/yuva29/volplugin/branches{/branch}","tags_url":"https://api.github.com/repos/yuva29/volplugin/tags","blobs_url":"https://api.github.com/repos/yuva29/volplugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuva29/volplugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuva29/volplugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuva29/volplugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuva29/volplugin/statuses/{sha}","languages_url":"https://api.github.com/repos/yuva29/volplugin/languages","stargazers_url":"https://api.github.com/repos/yuva29/volplugin/stargazers","contributors_url":"https://api.github.com/repos/yuva29/volplugin/contributors","subscribers_url":"https://api.github.com/repos/yuva29/volplugin/subscribers","subscription_url":"https://api.github.com/repos/yuva29/volplugin/subscription","commits_url":"https://api.github.com/repos/yuva29/volplugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuva29/volplugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuva29/volplugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuva29/volplugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuva29/volplugin/contents/{+path}","compare_url":"https://api.github.com/repos/yuva29/volplugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuva29/volplugin/merges","archive_url":"https://api.github.com/repos/yuva29/volplugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuva29/volplugin/downloads","issues_url":"https://api.github.com/repos/yuva29/volplugin/issues{/number}","pulls_url":"https://api.github.com/repos/yuva29/volplugin/pulls{/number}","milestones_url":"https://api.github.com/repos/yuva29/volplugin/milestones{/number}","notifications_url":"https://api.github.com/repos/yuva29/volplugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuva29/volplugin/labels{/name}","releases_url":"https://api.github.com/repos/yuva29/volplugin/releases{/id}","deployments_url":"https://api.github.com/repos/yuva29/volplugin/deployments","created_at":"2016-07-15T22:41:15Z","updated_at":"2016-07-15T22:41:16Z","pushed_at":"2016-07-26T22:44:39Z","git_url":"git://github.com/yuva29/volplugin.git","ssh_url":"git@github.com:yuva29/volplugin.git","clone_url":"https://github.com/yuva29/volplugin.git","svn_url":"https://github.com/yuva29/volplugin","homepage":"http://contiv.github.io","size":3304,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"contiv:master","ref":"master","sha":"9e5562da4b711e17b891ec9ccbcc04c677873d37","user":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"repo":{"id":38460040,"name":"volplugin","full_name":"contiv/volplugin","owner":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contiv/volplugin","description":"Contiv Storage: Policy backed Clustered Storage (via Ceph or NFS) for Docker","fork":false,"url":"https://api.github.com/repos/contiv/volplugin","forks_url":"https://api.github.com/repos/contiv/volplugin/forks","keys_url":"https://api.github.com/repos/contiv/volplugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiv/volplugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiv/volplugin/teams","hooks_url":"https://api.github.com/repos/contiv/volplugin/hooks","issue_events_url":"https://api.github.com/repos/contiv/volplugin/issues/events{/number}","events_url":"https://api.github.com/repos/contiv/volplugin/events","assignees_url":"https://api.github.com/repos/contiv/volplugin/assignees{/user}","branches_url":"https://api.github.com/repos/contiv/volplugin/branches{/branch}","tags_url":"https://api.github.com/repos/contiv/volplugin/tags","blobs_url":"https://api.github.com/repos/contiv/volplugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiv/volplugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiv/volplugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiv/volplugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiv/volplugin/statuses/{sha}","languages_url":"https://api.github.com/repos/contiv/volplugin/languages","stargazers_url":"https://api.github.com/repos/contiv/volplugin/stargazers","contributors_url":"https://api.github.com/repos/contiv/volplugin/contributors","subscribers_url":"https://api.github.com/repos/contiv/volplugin/subscribers","subscription_url":"https://api.github.com/repos/contiv/volplugin/subscription","commits_url":"https://api.github.com/repos/contiv/volplugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiv/volplugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiv/volplugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiv/volplugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiv/volplugin/contents/{+path}","compare_url":"https://api.github.com/repos/contiv/volplugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiv/volplugin/merges","archive_url":"https://api.github.com/repos/contiv/volplugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiv/volplugin/downloads","issues_url":"https://api.github.com/repos/contiv/volplugin/issues{/number}","pulls_url":"https://api.github.com/repos/contiv/volplugin/pulls{/number}","milestones_url":"https://api.github.com/repos/contiv/volplugin/milestones{/number}","notifications_url":"https://api.github.com/repos/contiv/volplugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiv/volplugin/labels{/name}","releases_url":"https://api.github.com/repos/contiv/volplugin/releases{/id}","deployments_url":"https://api.github.com/repos/contiv/volplugin/deployments","created_at":"2015-07-02T22:31:53Z","updated_at":"2016-07-21T12:59:41Z","pushed_at":"2016-07-27T01:00:49Z","git_url":"git://github.com/contiv/volplugin.git","ssh_url":"git@github.com:contiv/volplugin.git","clone_url":"https://github.com/contiv/volplugin.git","svn_url":"https://github.com/contiv/volplugin","homepage":"http://contiv.github.io","size":3261,"stargazers_count":128,"watchers_count":128,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":27,"forks":24,"open_issues":27,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contiv/volplugin/pulls/366"},"html":{"href":"https://github.com/contiv/volplugin/pull/366"},"issue":{"href":"https://api.github.com/repos/contiv/volplugin/issues/366"},"comments":{"href":"https://api.github.com/repos/contiv/volplugin/issues/366/comments"},"review_comments":{"href":"https://api.github.com/repos/contiv/volplugin/pulls/366/comments"},"review_comment":{"href":"https://api.github.com/repos/contiv/volplugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contiv/volplugin/pulls/366/commits"},"statuses":{"href":"https://api.github.com/repos/contiv/volplugin/statuses/de036c928b2bc124e2340acbf576bd0cb54d8d2e"}}}}
{"actor":{"display_login":"erikh"}}