{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/74532037","id":74532037,"diff_hunk":"@@ -205,27 +196,38 @@ func (r *repository) AddLocalConfig(location, name, value string) error {\n }\n \n // CloneWithOptions clones a remote git repository to a local directory\n-func (r *repository) CloneWithOptions(location string, url string, opts CloneOptions) error {\n-\targs := []string{\"clone\"}\n-\tif opts.Quiet {\n-\t\targs = append(args, \"--quiet\")\n-\t}\n-\tif opts.Recursive {\n-\t\targs = append(args, \"--recursive\")\n-\t}\n-\tif opts.Shallow {\n-\t\targs = append(args, \"--depth=1\")\n-\t\tr.shallow = true\n+func (r *repository) CloneWithOptions(location string, url string, args ...string) error {\n+\tgitArgs := []string{\"clone\"}\n+\tgitArgs = append(gitArgs, args...)\n+\tgitArgs = append(gitArgs, url)\n+\tgitArgs = append(gitArgs, location)\n+\n+\t// We need to check to see if we're importing reference information, for\n+\t// for error checking later on\n+\tfor _, opt := range gitArgs {\n+\t\tif opt == \"--depth=1\" {","path":"pkg/generate/git/repository.go","position":49,"original_position":49,"commit_id":"5cbc7ea78f3cd5046a5ad429fad551887b65d3ba","original_commit_id":"5cbc7ea78f3cd5046a5ad429fad551887b65d3ba","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"since we're matching between two places, \"--depth=1\" should be defined as a constant so they don't get out of sync in the future.\r\n","created_at":"2016-08-12T01:45:49Z","updated_at":"2016-08-12T01:45:49Z","html_url":"https://github.com/openshift/origin/pull/10366#discussion_r74532037","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/10366","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/74532037"},"html":{"href":"https://github.com/openshift/origin/pull/10366#discussion_r74532037"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/10366"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/10366","id":81039441,"html_url":"https://github.com/openshift/origin/pull/10366","diff_url":"https://github.com/openshift/origin/pull/10366.diff","patch_url":"https://github.com/openshift/origin/pull/10366.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/10366","number":10366,"state":"open","locked":false,"title":"Changes the signature of CloneWithOptions function","user":{"login":"oatmealraisin","id":6402382,"avatar_url":"https://avatars.githubusercontent.com/u/6402382?v=3","gravatar_id":"","url":"https://api.github.com/users/oatmealraisin","html_url":"https://github.com/oatmealraisin","followers_url":"https://api.github.com/users/oatmealraisin/followers","following_url":"https://api.github.com/users/oatmealraisin/following{/other_user}","gists_url":"https://api.github.com/users/oatmealraisin/gists{/gist_id}","starred_url":"https://api.github.com/users/oatmealraisin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oatmealraisin/subscriptions","organizations_url":"https://api.github.com/users/oatmealraisin/orgs","repos_url":"https://api.github.com/users/oatmealraisin/repos","events_url":"https://api.github.com/users/oatmealraisin/events{/privacy}","received_events_url":"https://api.github.com/users/oatmealraisin/received_events","type":"User","site_admin":false},"body":"We change it to a packed string from a boolean struct.  This allows us\r\nto use every option for clone, creating more utility for the package.\r\n\r\n@bparees ptal?  What do you think?","created_at":"2016-08-11T22:06:17Z","updated_at":"2016-08-12T01:45:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06dc5a806fc6f6827acb384b3585eafee3001ee0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/10366/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/10366/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/10366/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/5cbc7ea78f3cd5046a5ad429fad551887b65d3ba","head":{"label":"oatmealraisin:rymurphy/clonerework","ref":"rymurphy/clonerework","sha":"5cbc7ea78f3cd5046a5ad429fad551887b65d3ba","user":{"login":"oatmealraisin","id":6402382,"avatar_url":"https://avatars.githubusercontent.com/u/6402382?v=3","gravatar_id":"","url":"https://api.github.com/users/oatmealraisin","html_url":"https://github.com/oatmealraisin","followers_url":"https://api.github.com/users/oatmealraisin/followers","following_url":"https://api.github.com/users/oatmealraisin/following{/other_user}","gists_url":"https://api.github.com/users/oatmealraisin/gists{/gist_id}","starred_url":"https://api.github.com/users/oatmealraisin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oatmealraisin/subscriptions","organizations_url":"https://api.github.com/users/oatmealraisin/orgs","repos_url":"https://api.github.com/users/oatmealraisin/repos","events_url":"https://api.github.com/users/oatmealraisin/events{/privacy}","received_events_url":"https://api.github.com/users/oatmealraisin/received_events","type":"User","site_admin":false},"repo":{"id":60552506,"name":"origin","full_name":"oatmealraisin/origin","owner":{"login":"oatmealraisin","id":6402382,"avatar_url":"https://avatars.githubusercontent.com/u/6402382?v=3","gravatar_id":"","url":"https://api.github.com/users/oatmealraisin","html_url":"https://github.com/oatmealraisin","followers_url":"https://api.github.com/users/oatmealraisin/followers","following_url":"https://api.github.com/users/oatmealraisin/following{/other_user}","gists_url":"https://api.github.com/users/oatmealraisin/gists{/gist_id}","starred_url":"https://api.github.com/users/oatmealraisin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oatmealraisin/subscriptions","organizations_url":"https://api.github.com/users/oatmealraisin/orgs","repos_url":"https://api.github.com/users/oatmealraisin/repos","events_url":"https://api.github.com/users/oatmealraisin/events{/privacy}","received_events_url":"https://api.github.com/users/oatmealraisin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oatmealraisin/origin","description":"OpenShift - Build, deploy, and manage cloud-native and legacy applications with Kubernetes and Docker","fork":true,"url":"https://api.github.com/repos/oatmealraisin/origin","forks_url":"https://api.github.com/repos/oatmealraisin/origin/forks","keys_url":"https://api.github.com/repos/oatmealraisin/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oatmealraisin/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oatmealraisin/origin/teams","hooks_url":"https://api.github.com/repos/oatmealraisin/origin/hooks","issue_events_url":"https://api.github.com/repos/oatmealraisin/origin/issues/events{/number}","events_url":"https://api.github.com/repos/oatmealraisin/origin/events","assignees_url":"https://api.github.com/repos/oatmealraisin/origin/assignees{/user}","branches_url":"https://api.github.com/repos/oatmealraisin/origin/branches{/branch}","tags_url":"https://api.github.com/repos/oatmealraisin/origin/tags","blobs_url":"https://api.github.com/repos/oatmealraisin/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oatmealraisin/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oatmealraisin/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/oatmealraisin/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oatmealraisin/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/oatmealraisin/origin/languages","stargazers_url":"https://api.github.com/repos/oatmealraisin/origin/stargazers","contributors_url":"https://api.github.com/repos/oatmealraisin/origin/contributors","subscribers_url":"https://api.github.com/repos/oatmealraisin/origin/subscribers","subscription_url":"https://api.github.com/repos/oatmealraisin/origin/subscription","commits_url":"https://api.github.com/repos/oatmealraisin/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/oatmealraisin/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/oatmealraisin/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/oatmealraisin/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/oatmealraisin/origin/contents/{+path}","compare_url":"https://api.github.com/repos/oatmealraisin/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oatmealraisin/origin/merges","archive_url":"https://api.github.com/repos/oatmealraisin/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oatmealraisin/origin/downloads","issues_url":"https://api.github.com/repos/oatmealraisin/origin/issues{/number}","pulls_url":"https://api.github.com/repos/oatmealraisin/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/oatmealraisin/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/oatmealraisin/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oatmealraisin/origin/labels{/name}","releases_url":"https://api.github.com/repos/oatmealraisin/origin/releases{/id}","deployments_url":"https://api.github.com/repos/oatmealraisin/origin/deployments","created_at":"2016-06-06T18:47:57Z","updated_at":"2016-06-06T18:48:05Z","pushed_at":"2016-08-11T22:01:29Z","git_url":"git://github.com/oatmealraisin/origin.git","ssh_url":"git@github.com:oatmealraisin/origin.git","clone_url":"https://github.com/oatmealraisin/origin.git","svn_url":"https://github.com/oatmealraisin/origin","homepage":"http://www.openshift.org","size":312249,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"70adfdf1542bb76f2937b693ca0d2a15bd8b30a7","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-08-11T20:02:37Z","pushed_at":"2016-08-12T01:37:02Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":561284,"stargazers_count":1584,"watchers_count":1584,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":976,"mirror_url":null,"open_issues_count":1085,"forks":976,"open_issues":1085,"watchers":1584,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/10366"},"html":{"href":"https://github.com/openshift/origin/pull/10366"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/10366"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/10366/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/10366/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/10366/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/5cbc7ea78f3cd5046a5ad429fad551887b65d3ba"}}}}
{"actor":{"display_login":"bparees"}}