{"action":"created","comment":{"url":"https://api.github.com/repos/ska-sa/scikits.fitting/pulls/comments/90839879","pull_request_review_id":11353650,"id":90839879,"diff_hunk":"@@ -77,14 +77,17 @@\n from spline import *\n \n \n+logger = logging.getLogger(__name__)\n+\n+\n def _setup_test():\n     \"\"\"Create test() method that will run unit tests via nose.\"\"\"\n     args = ['', '--exe', '-w', __path__[0]]\n     try:\n         import nose as _nose\n     except ImportError:\n         def test():\n-            print('Could not load nose. Unit tests not available.')\n+            logger.warning('Could not load nose. Unit tests not available.')","path":"scikits/fitting/__init__.py","position":33,"original_position":33,"commit_id":"0bfb3db65911706e34b1997314a59bcef0c6cb56","original_commit_id":"0bfb3db65911706e34b1997314a59bcef0c6cb56","user":{"login":"ludwigschwardt","id":392144,"avatar_url":"https://avatars.githubusercontent.com/u/392144?v=3","gravatar_id":"","url":"https://api.github.com/users/ludwigschwardt","html_url":"https://github.com/ludwigschwardt","followers_url":"https://api.github.com/users/ludwigschwardt/followers","following_url":"https://api.github.com/users/ludwigschwardt/following{/other_user}","gists_url":"https://api.github.com/users/ludwigschwardt/gists{/gist_id}","starred_url":"https://api.github.com/users/ludwigschwardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludwigschwardt/subscriptions","organizations_url":"https://api.github.com/users/ludwigschwardt/orgs","repos_url":"https://api.github.com/users/ludwigschwardt/repos","events_url":"https://api.github.com/users/ludwigschwardt/events{/privacy}","received_events_url":"https://api.github.com/users/ludwigschwardt/received_events","type":"User","site_admin":false},"body":"Point taken! Both instances of logging replaced with warnings.warn().","created_at":"2016-12-05T10:43:15Z","updated_at":"2016-12-05T10:43:15Z","html_url":"https://github.com/ska-sa/scikits.fitting/pull/5#discussion_r90839879","pull_request_url":"https://api.github.com/repos/ska-sa/scikits.fitting/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/ska-sa/scikits.fitting/pulls/comments/90839879"},"html":{"href":"https://github.com/ska-sa/scikits.fitting/pull/5#discussion_r90839879"},"pull_request":{"href":"https://api.github.com/repos/ska-sa/scikits.fitting/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/ska-sa/scikits.fitting/pulls/5","id":95901040,"html_url":"https://github.com/ska-sa/scikits.fitting/pull/5","diff_url":"https://github.com/ska-sa/scikits.fitting/pull/5.diff","patch_url":"https://github.com/ska-sa/scikits.fitting/pull/5.patch","issue_url":"https://api.github.com/repos/ska-sa/scikits.fitting/issues/5","number":5,"state":"open","locked":false,"title":"Base Delaunay fitter on scipy.interpolate.griddata","user":{"login":"ludwigschwardt","id":392144,"avatar_url":"https://avatars.githubusercontent.com/u/392144?v=3","gravatar_id":"","url":"https://api.github.com/users/ludwigschwardt","html_url":"https://github.com/ludwigschwardt","followers_url":"https://api.github.com/users/ludwigschwardt/followers","following_url":"https://api.github.com/users/ludwigschwardt/following{/other_user}","gists_url":"https://api.github.com/users/ludwigschwardt/gists{/gist_id}","starred_url":"https://api.github.com/users/ludwigschwardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludwigschwardt/subscriptions","organizations_url":"https://api.github.com/users/ludwigschwardt/orgs","repos_url":"https://api.github.com/users/ludwigschwardt/repos","events_url":"https://api.github.com/users/ludwigschwardt/events{/privacy}","received_events_url":"https://api.github.com/users/ludwigschwardt/received_events","type":"User","site_admin":false},"body":"The old delaunay module is now completely gone, having been deprecated\r\nfor a while. The ideal replacement is `scipy.interpolate.griddata` and its\r\nunderlying classes, which is fast and robust.\r\n\r\nAlso remove Delaunay2DGridFit which serves no real purpose anymore.\r\n","created_at":"2016-11-30T14:27:36Z","updated_at":"2016-12-05T10:43:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1456c8e82393895a56d598a740ac09460556ec7d","assignee":{"login":"bmerry","id":1963944,"avatar_url":"https://avatars.githubusercontent.com/u/1963944?v=3","gravatar_id":"","url":"https://api.github.com/users/bmerry","html_url":"https://github.com/bmerry","followers_url":"https://api.github.com/users/bmerry/followers","following_url":"https://api.github.com/users/bmerry/following{/other_user}","gists_url":"https://api.github.com/users/bmerry/gists{/gist_id}","starred_url":"https://api.github.com/users/bmerry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmerry/subscriptions","organizations_url":"https://api.github.com/users/bmerry/orgs","repos_url":"https://api.github.com/users/bmerry/repos","events_url":"https://api.github.com/users/bmerry/events{/privacy}","received_events_url":"https://api.github.com/users/bmerry/received_events","type":"User","site_admin":false},"assignees":[{"login":"bmerry","id":1963944,"avatar_url":"https://avatars.githubusercontent.com/u/1963944?v=3","gravatar_id":"","url":"https://api.github.com/users/bmerry","html_url":"https://github.com/bmerry","followers_url":"https://api.github.com/users/bmerry/followers","following_url":"https://api.github.com/users/bmerry/following{/other_user}","gists_url":"https://api.github.com/users/bmerry/gists{/gist_id}","starred_url":"https://api.github.com/users/bmerry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmerry/subscriptions","organizations_url":"https://api.github.com/users/bmerry/orgs","repos_url":"https://api.github.com/users/bmerry/repos","events_url":"https://api.github.com/users/bmerry/events{/privacy}","received_events_url":"https://api.github.com/users/bmerry/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ska-sa/scikits.fitting/pulls/5/commits","review_comments_url":"https://api.github.com/repos/ska-sa/scikits.fitting/pulls/5/comments","review_comment_url":"https://api.github.com/repos/ska-sa/scikits.fitting/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ska-sa/scikits.fitting/issues/5/comments","statuses_url":"https://api.github.com/repos/ska-sa/scikits.fitting/statuses/0bfb3db65911706e34b1997314a59bcef0c6cb56","head":{"label":"ska-sa:overhaul-delaunay","ref":"overhaul-delaunay","sha":"0bfb3db65911706e34b1997314a59bcef0c6cb56","user":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":2442593,"name":"scikits.fitting","full_name":"ska-sa/scikits.fitting","owner":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ska-sa/scikits.fitting","description":null,"fork":false,"url":"https://api.github.com/repos/ska-sa/scikits.fitting","forks_url":"https://api.github.com/repos/ska-sa/scikits.fitting/forks","keys_url":"https://api.github.com/repos/ska-sa/scikits.fitting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/scikits.fitting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/scikits.fitting/teams","hooks_url":"https://api.github.com/repos/ska-sa/scikits.fitting/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/scikits.fitting/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/scikits.fitting/events","assignees_url":"https://api.github.com/repos/ska-sa/scikits.fitting/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/scikits.fitting/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/scikits.fitting/tags","blobs_url":"https://api.github.com/repos/ska-sa/scikits.fitting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/scikits.fitting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/scikits.fitting/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/scikits.fitting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/scikits.fitting/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/scikits.fitting/languages","stargazers_url":"https://api.github.com/repos/ska-sa/scikits.fitting/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/scikits.fitting/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/scikits.fitting/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/scikits.fitting/subscription","commits_url":"https://api.github.com/repos/ska-sa/scikits.fitting/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/scikits.fitting/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/scikits.fitting/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/scikits.fitting/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/scikits.fitting/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/scikits.fitting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/scikits.fitting/merges","archive_url":"https://api.github.com/repos/ska-sa/scikits.fitting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/scikits.fitting/downloads","issues_url":"https://api.github.com/repos/ska-sa/scikits.fitting/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/scikits.fitting/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/scikits.fitting/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/scikits.fitting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/scikits.fitting/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/scikits.fitting/releases{/id}","deployments_url":"https://api.github.com/repos/ska-sa/scikits.fitting/deployments","created_at":"2011-09-23T07:28:46Z","updated_at":"2016-11-11T09:38:02Z","pushed_at":"2016-12-01T13:19:41Z","git_url":"git://github.com/ska-sa/scikits.fitting.git","ssh_url":"git@github.com:ska-sa/scikits.fitting.git","clone_url":"https://github.com/ska-sa/scikits.fitting.git","svn_url":"https://github.com/ska-sa/scikits.fitting","homepage":"","size":152,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":9,"default_branch":"master"}},"base":{"label":"ska-sa:master","ref":"master","sha":"dad785be37ace5771d991fe1be0de5bacc038c56","user":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":2442593,"name":"scikits.fitting","full_name":"ska-sa/scikits.fitting","owner":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ska-sa/scikits.fitting","description":null,"fork":false,"url":"https://api.github.com/repos/ska-sa/scikits.fitting","forks_url":"https://api.github.com/repos/ska-sa/scikits.fitting/forks","keys_url":"https://api.github.com/repos/ska-sa/scikits.fitting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/scikits.fitting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/scikits.fitting/teams","hooks_url":"https://api.github.com/repos/ska-sa/scikits.fitting/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/scikits.fitting/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/scikits.fitting/events","assignees_url":"https://api.github.com/repos/ska-sa/scikits.fitting/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/scikits.fitting/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/scikits.fitting/tags","blobs_url":"https://api.github.com/repos/ska-sa/scikits.fitting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/scikits.fitting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/scikits.fitting/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/scikits.fitting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/scikits.fitting/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/scikits.fitting/languages","stargazers_url":"https://api.github.com/repos/ska-sa/scikits.fitting/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/scikits.fitting/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/scikits.fitting/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/scikits.fitting/subscription","commits_url":"https://api.github.com/repos/ska-sa/scikits.fitting/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/scikits.fitting/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/scikits.fitting/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/scikits.fitting/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/scikits.fitting/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/scikits.fitting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/scikits.fitting/merges","archive_url":"https://api.github.com/repos/ska-sa/scikits.fitting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/scikits.fitting/downloads","issues_url":"https://api.github.com/repos/ska-sa/scikits.fitting/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/scikits.fitting/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/scikits.fitting/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/scikits.fitting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/scikits.fitting/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/scikits.fitting/releases{/id}","deployments_url":"https://api.github.com/repos/ska-sa/scikits.fitting/deployments","created_at":"2011-09-23T07:28:46Z","updated_at":"2016-11-11T09:38:02Z","pushed_at":"2016-12-01T13:19:41Z","git_url":"git://github.com/ska-sa/scikits.fitting.git","ssh_url":"git@github.com:ska-sa/scikits.fitting.git","clone_url":"https://github.com/ska-sa/scikits.fitting.git","svn_url":"https://github.com/ska-sa/scikits.fitting","homepage":"","size":152,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ska-sa/scikits.fitting/pulls/5"},"html":{"href":"https://github.com/ska-sa/scikits.fitting/pull/5"},"issue":{"href":"https://api.github.com/repos/ska-sa/scikits.fitting/issues/5"},"comments":{"href":"https://api.github.com/repos/ska-sa/scikits.fitting/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/ska-sa/scikits.fitting/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/ska-sa/scikits.fitting/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ska-sa/scikits.fitting/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/ska-sa/scikits.fitting/statuses/0bfb3db65911706e34b1997314a59bcef0c6cb56"}}}}
{"actor":{"display_login":"ludwigschwardt"}}