{"action":"created","comment":{"url":"https://api.github.com/repos/grzanka/beprof/pulls/comments/53332364","id":53332364,"diff_hunk":"@@ -1,5 +1,6 @@\n from beprof.curve import Curve\n import numpy as np\n+from beprof import functions as f","path":"beprof/profile.py","position":3,"original_position":3,"commit_id":"93cdef423cd4e909145be80307c7373b8638021e","original_commit_id":"93cdef423cd4e909145be80307c7373b8638021e","user":{"login":"grzanka","id":7374733,"avatar_url":"https://avatars.githubusercontent.com/u/7374733?v=3","gravatar_id":"","url":"https://api.github.com/users/grzanka","html_url":"https://github.com/grzanka","followers_url":"https://api.github.com/users/grzanka/followers","following_url":"https://api.github.com/users/grzanka/following{/other_user}","gists_url":"https://api.github.com/users/grzanka/gists{/gist_id}","starred_url":"https://api.github.com/users/grzanka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grzanka/subscriptions","organizations_url":"https://api.github.com/users/grzanka/orgs","repos_url":"https://api.github.com/users/grzanka/repos","events_url":"https://api.github.com/users/grzanka/events{/privacy}","received_events_url":"https://api.github.com/users/grzanka/received_events","type":"User","site_admin":false},"body":"I see some contraction in importing Curve and functions.\r\nFirst one you do using `from x.y import z` and the second one you do using `from x import y as z`. Why ?","created_at":"2016-02-18T15:48:52Z","updated_at":"2016-02-18T15:48:52Z","html_url":"https://github.com/grzanka/beprof/pull/26#discussion_r53332364","pull_request_url":"https://api.github.com/repos/grzanka/beprof/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/grzanka/beprof/pulls/comments/53332364"},"html":{"href":"https://github.com/grzanka/beprof/pull/26#discussion_r53332364"},"pull_request":{"href":"https://api.github.com/repos/grzanka/beprof/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/grzanka/beprof/pulls/26","id":58814346,"html_url":"https://github.com/grzanka/beprof/pull/26","diff_url":"https://github.com/grzanka/beprof/pull/26.diff","patch_url":"https://github.com/grzanka/beprof/pull/26.patch","issue_url":"https://api.github.com/repos/grzanka/beprof/issues/26","number":26,"state":"open","locked":false,"title":"Subtracting curves","user":{"login":"matkrak","id":16837323,"avatar_url":"https://avatars.githubusercontent.com/u/16837323?v=3","gravatar_id":"","url":"https://api.github.com/users/matkrak","html_url":"https://github.com/matkrak","followers_url":"https://api.github.com/users/matkrak/followers","following_url":"https://api.github.com/users/matkrak/following{/other_user}","gists_url":"https://api.github.com/users/matkrak/gists{/gist_id}","starred_url":"https://api.github.com/users/matkrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matkrak/subscriptions","organizations_url":"https://api.github.com/users/matkrak/orgs","repos_url":"https://api.github.com/users/matkrak/repos","events_url":"https://api.github.com/users/matkrak/events{/privacy}","received_events_url":"https://api.github.com/users/matkrak/received_events","type":"User","site_admin":false},"body":"As the description says. First part where user doesn't want to create new object\r\nJust 1 question about it:\r\nI was thinking like this: \r\nIf I call the method of object c1 like `c1.subtract(c2, newobj=False)` I don't want it to change the domain of c1. \r\nThe idea of broadcasting says, that the dimension of the output should be max of dimensions on the input. If you want, I can make it like this, and I absolutely will do this in subtract(c1, c2), but here I decided to solve it like I did.\r\nPlease give me some feedback. I am working on the second part that is more confusing since when creating new object I need to figure out what the domain should be and I need to care about metadata here as well.","created_at":"2016-02-09T21:51:30Z","updated_at":"2016-02-18T15:48:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84c00995a5dacf4a526c581a5f3fc39d34f37070","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/grzanka/beprof/pulls/26/commits","review_comments_url":"https://api.github.com/repos/grzanka/beprof/pulls/26/comments","review_comment_url":"https://api.github.com/repos/grzanka/beprof/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grzanka/beprof/issues/26/comments","statuses_url":"https://api.github.com/repos/grzanka/beprof/statuses/93cdef423cd4e909145be80307c7373b8638021e","head":{"label":"matkrak:subtract","ref":"subtract","sha":"93cdef423cd4e909145be80307c7373b8638021e","user":{"login":"matkrak","id":16837323,"avatar_url":"https://avatars.githubusercontent.com/u/16837323?v=3","gravatar_id":"","url":"https://api.github.com/users/matkrak","html_url":"https://github.com/matkrak","followers_url":"https://api.github.com/users/matkrak/followers","following_url":"https://api.github.com/users/matkrak/following{/other_user}","gists_url":"https://api.github.com/users/matkrak/gists{/gist_id}","starred_url":"https://api.github.com/users/matkrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matkrak/subscriptions","organizations_url":"https://api.github.com/users/matkrak/orgs","repos_url":"https://api.github.com/users/matkrak/repos","events_url":"https://api.github.com/users/matkrak/events{/privacy}","received_events_url":"https://api.github.com/users/matkrak/received_events","type":"User","site_admin":false},"repo":{"id":50577111,"name":"beprof","full_name":"matkrak/beprof","owner":{"login":"matkrak","id":16837323,"avatar_url":"https://avatars.githubusercontent.com/u/16837323?v=3","gravatar_id":"","url":"https://api.github.com/users/matkrak","html_url":"https://github.com/matkrak","followers_url":"https://api.github.com/users/matkrak/followers","following_url":"https://api.github.com/users/matkrak/following{/other_user}","gists_url":"https://api.github.com/users/matkrak/gists{/gist_id}","starred_url":"https://api.github.com/users/matkrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matkrak/subscriptions","organizations_url":"https://api.github.com/users/matkrak/orgs","repos_url":"https://api.github.com/users/matkrak/repos","events_url":"https://api.github.com/users/matkrak/events{/privacy}","received_events_url":"https://api.github.com/users/matkrak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matkrak/beprof","description":"Beam Profile Analysing Tools","fork":true,"url":"https://api.github.com/repos/matkrak/beprof","forks_url":"https://api.github.com/repos/matkrak/beprof/forks","keys_url":"https://api.github.com/repos/matkrak/beprof/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matkrak/beprof/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matkrak/beprof/teams","hooks_url":"https://api.github.com/repos/matkrak/beprof/hooks","issue_events_url":"https://api.github.com/repos/matkrak/beprof/issues/events{/number}","events_url":"https://api.github.com/repos/matkrak/beprof/events","assignees_url":"https://api.github.com/repos/matkrak/beprof/assignees{/user}","branches_url":"https://api.github.com/repos/matkrak/beprof/branches{/branch}","tags_url":"https://api.github.com/repos/matkrak/beprof/tags","blobs_url":"https://api.github.com/repos/matkrak/beprof/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matkrak/beprof/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matkrak/beprof/git/refs{/sha}","trees_url":"https://api.github.com/repos/matkrak/beprof/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matkrak/beprof/statuses/{sha}","languages_url":"https://api.github.com/repos/matkrak/beprof/languages","stargazers_url":"https://api.github.com/repos/matkrak/beprof/stargazers","contributors_url":"https://api.github.com/repos/matkrak/beprof/contributors","subscribers_url":"https://api.github.com/repos/matkrak/beprof/subscribers","subscription_url":"https://api.github.com/repos/matkrak/beprof/subscription","commits_url":"https://api.github.com/repos/matkrak/beprof/commits{/sha}","git_commits_url":"https://api.github.com/repos/matkrak/beprof/git/commits{/sha}","comments_url":"https://api.github.com/repos/matkrak/beprof/comments{/number}","issue_comment_url":"https://api.github.com/repos/matkrak/beprof/issues/comments{/number}","contents_url":"https://api.github.com/repos/matkrak/beprof/contents/{+path}","compare_url":"https://api.github.com/repos/matkrak/beprof/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matkrak/beprof/merges","archive_url":"https://api.github.com/repos/matkrak/beprof/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matkrak/beprof/downloads","issues_url":"https://api.github.com/repos/matkrak/beprof/issues{/number}","pulls_url":"https://api.github.com/repos/matkrak/beprof/pulls{/number}","milestones_url":"https://api.github.com/repos/matkrak/beprof/milestones{/number}","notifications_url":"https://api.github.com/repos/matkrak/beprof/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matkrak/beprof/labels{/name}","releases_url":"https://api.github.com/repos/matkrak/beprof/releases{/id}","deployments_url":"https://api.github.com/repos/matkrak/beprof/deployments","created_at":"2016-01-28T11:03:37Z","updated_at":"2016-01-28T11:03:37Z","pushed_at":"2016-02-18T15:04:45Z","git_url":"git://github.com/matkrak/beprof.git","ssh_url":"git@github.com:matkrak/beprof.git","clone_url":"https://github.com/matkrak/beprof.git","svn_url":"https://github.com/matkrak/beprof","homepage":null,"size":101,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grzanka:master","ref":"master","sha":"bcdae8cdcaa6a29186731842b238ac252b29900e","user":{"login":"grzanka","id":7374733,"avatar_url":"https://avatars.githubusercontent.com/u/7374733?v=3","gravatar_id":"","url":"https://api.github.com/users/grzanka","html_url":"https://github.com/grzanka","followers_url":"https://api.github.com/users/grzanka/followers","following_url":"https://api.github.com/users/grzanka/following{/other_user}","gists_url":"https://api.github.com/users/grzanka/gists{/gist_id}","starred_url":"https://api.github.com/users/grzanka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grzanka/subscriptions","organizations_url":"https://api.github.com/users/grzanka/orgs","repos_url":"https://api.github.com/users/grzanka/repos","events_url":"https://api.github.com/users/grzanka/events{/privacy}","received_events_url":"https://api.github.com/users/grzanka/received_events","type":"User","site_admin":false},"repo":{"id":49129024,"name":"beprof","full_name":"grzanka/beprof","owner":{"login":"grzanka","id":7374733,"avatar_url":"https://avatars.githubusercontent.com/u/7374733?v=3","gravatar_id":"","url":"https://api.github.com/users/grzanka","html_url":"https://github.com/grzanka","followers_url":"https://api.github.com/users/grzanka/followers","following_url":"https://api.github.com/users/grzanka/following{/other_user}","gists_url":"https://api.github.com/users/grzanka/gists{/gist_id}","starred_url":"https://api.github.com/users/grzanka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grzanka/subscriptions","organizations_url":"https://api.github.com/users/grzanka/orgs","repos_url":"https://api.github.com/users/grzanka/repos","events_url":"https://api.github.com/users/grzanka/events{/privacy}","received_events_url":"https://api.github.com/users/grzanka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grzanka/beprof","description":"Beam Profile Analysing Tools","fork":false,"url":"https://api.github.com/repos/grzanka/beprof","forks_url":"https://api.github.com/repos/grzanka/beprof/forks","keys_url":"https://api.github.com/repos/grzanka/beprof/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grzanka/beprof/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grzanka/beprof/teams","hooks_url":"https://api.github.com/repos/grzanka/beprof/hooks","issue_events_url":"https://api.github.com/repos/grzanka/beprof/issues/events{/number}","events_url":"https://api.github.com/repos/grzanka/beprof/events","assignees_url":"https://api.github.com/repos/grzanka/beprof/assignees{/user}","branches_url":"https://api.github.com/repos/grzanka/beprof/branches{/branch}","tags_url":"https://api.github.com/repos/grzanka/beprof/tags","blobs_url":"https://api.github.com/repos/grzanka/beprof/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grzanka/beprof/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grzanka/beprof/git/refs{/sha}","trees_url":"https://api.github.com/repos/grzanka/beprof/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grzanka/beprof/statuses/{sha}","languages_url":"https://api.github.com/repos/grzanka/beprof/languages","stargazers_url":"https://api.github.com/repos/grzanka/beprof/stargazers","contributors_url":"https://api.github.com/repos/grzanka/beprof/contributors","subscribers_url":"https://api.github.com/repos/grzanka/beprof/subscribers","subscription_url":"https://api.github.com/repos/grzanka/beprof/subscription","commits_url":"https://api.github.com/repos/grzanka/beprof/commits{/sha}","git_commits_url":"https://api.github.com/repos/grzanka/beprof/git/commits{/sha}","comments_url":"https://api.github.com/repos/grzanka/beprof/comments{/number}","issue_comment_url":"https://api.github.com/repos/grzanka/beprof/issues/comments{/number}","contents_url":"https://api.github.com/repos/grzanka/beprof/contents/{+path}","compare_url":"https://api.github.com/repos/grzanka/beprof/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grzanka/beprof/merges","archive_url":"https://api.github.com/repos/grzanka/beprof/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grzanka/beprof/downloads","issues_url":"https://api.github.com/repos/grzanka/beprof/issues{/number}","pulls_url":"https://api.github.com/repos/grzanka/beprof/pulls{/number}","milestones_url":"https://api.github.com/repos/grzanka/beprof/milestones{/number}","notifications_url":"https://api.github.com/repos/grzanka/beprof/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grzanka/beprof/labels{/name}","releases_url":"https://api.github.com/repos/grzanka/beprof/releases{/id}","deployments_url":"https://api.github.com/repos/grzanka/beprof/deployments","created_at":"2016-01-06T10:36:02Z","updated_at":"2016-01-19T11:39:37Z","pushed_at":"2016-02-18T15:04:45Z","git_url":"git://github.com/grzanka/beprof.git","ssh_url":"git@github.com:grzanka/beprof.git","clone_url":"https://github.com/grzanka/beprof.git","svn_url":"https://github.com/grzanka/beprof","homepage":null,"size":86,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":17,"forks":1,"open_issues":17,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grzanka/beprof/pulls/26"},"html":{"href":"https://github.com/grzanka/beprof/pull/26"},"issue":{"href":"https://api.github.com/repos/grzanka/beprof/issues/26"},"comments":{"href":"https://api.github.com/repos/grzanka/beprof/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/grzanka/beprof/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/grzanka/beprof/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grzanka/beprof/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/grzanka/beprof/statuses/93cdef423cd4e909145be80307c7373b8638021e"}}}}