{"action":"opened","number":1271,"pull_request":{"url":"https://api.github.com/repos/Netflix/Hystrix/pulls/1271","id":76707687,"html_url":"https://github.com/Netflix/Hystrix/pull/1271","diff_url":"https://github.com/Netflix/Hystrix/pull/1271.diff","patch_url":"https://github.com/Netflix/Hystrix/pull/1271.patch","issue_url":"https://api.github.com/repos/Netflix/Hystrix/issues/1271","number":1271,"state":"open","locked":false,"title":"Fix race condition in HystrixThreadPoolKey.asKey method","user":{"login":"daniilguit","id":231284,"avatar_url":"https://avatars.githubusercontent.com/u/231284?v=3","gravatar_id":"","url":"https://api.github.com/users/daniilguit","html_url":"https://github.com/daniilguit","followers_url":"https://api.github.com/users/daniilguit/followers","following_url":"https://api.github.com/users/daniilguit/following{/other_user}","gists_url":"https://api.github.com/users/daniilguit/gists{/gist_id}","starred_url":"https://api.github.com/users/daniilguit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniilguit/subscriptions","organizations_url":"https://api.github.com/users/daniilguit/orgs","repos_url":"https://api.github.com/users/daniilguit/repos","events_url":"https://api.github.com/users/daniilguit/events{/privacy}","received_events_url":"https://api.github.com/users/daniilguit/received_events","type":"User","site_admin":false},"body":"Fix rare case when this method would return different values for the same key\r\n\r\nThe problem would happen when:\r\n\r\n1. Thread1: No such key when intern.get(name), so k was null\r\n2. Thread1: We would enter if-statement\r\n3. Thread2: Other thread would add key to intern map\r\n4. Thread1: We will not put new key to intern map, but we will return newly created value instead of one stored in map","created_at":"2016-07-08T06:36:11Z","updated_at":"2016-07-08T06:36:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Netflix/Hystrix/pulls/1271/commits","review_comments_url":"https://api.github.com/repos/Netflix/Hystrix/pulls/1271/comments","review_comment_url":"https://api.github.com/repos/Netflix/Hystrix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Netflix/Hystrix/issues/1271/comments","statuses_url":"https://api.github.com/repos/Netflix/Hystrix/statuses/045cef325f35b9fed7711f613c2b84e38a42ca6c","head":{"label":"daniilguit:master","ref":"master","sha":"045cef325f35b9fed7711f613c2b84e38a42ca6c","user":{"login":"daniilguit","id":231284,"avatar_url":"https://avatars.githubusercontent.com/u/231284?v=3","gravatar_id":"","url":"https://api.github.com/users/daniilguit","html_url":"https://github.com/daniilguit","followers_url":"https://api.github.com/users/daniilguit/followers","following_url":"https://api.github.com/users/daniilguit/following{/other_user}","gists_url":"https://api.github.com/users/daniilguit/gists{/gist_id}","starred_url":"https://api.github.com/users/daniilguit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniilguit/subscriptions","organizations_url":"https://api.github.com/users/daniilguit/orgs","repos_url":"https://api.github.com/users/daniilguit/repos","events_url":"https://api.github.com/users/daniilguit/events{/privacy}","received_events_url":"https://api.github.com/users/daniilguit/received_events","type":"User","site_admin":false},"repo":{"id":62801990,"name":"Hystrix","full_name":"daniilguit/Hystrix","owner":{"login":"daniilguit","id":231284,"avatar_url":"https://avatars.githubusercontent.com/u/231284?v=3","gravatar_id":"","url":"https://api.github.com/users/daniilguit","html_url":"https://github.com/daniilguit","followers_url":"https://api.github.com/users/daniilguit/followers","following_url":"https://api.github.com/users/daniilguit/following{/other_user}","gists_url":"https://api.github.com/users/daniilguit/gists{/gist_id}","starred_url":"https://api.github.com/users/daniilguit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniilguit/subscriptions","organizations_url":"https://api.github.com/users/daniilguit/orgs","repos_url":"https://api.github.com/users/daniilguit/repos","events_url":"https://api.github.com/users/daniilguit/events{/privacy}","received_events_url":"https://api.github.com/users/daniilguit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daniilguit/Hystrix","description":"Hystrix is a latency and fault tolerance library designed to isolate points of access to remote systems, services and 3rd party libraries, stop cascading failure and enable resilience in complex distributed systems where failure is inevitable.","fork":true,"url":"https://api.github.com/repos/daniilguit/Hystrix","forks_url":"https://api.github.com/repos/daniilguit/Hystrix/forks","keys_url":"https://api.github.com/repos/daniilguit/Hystrix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daniilguit/Hystrix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daniilguit/Hystrix/teams","hooks_url":"https://api.github.com/repos/daniilguit/Hystrix/hooks","issue_events_url":"https://api.github.com/repos/daniilguit/Hystrix/issues/events{/number}","events_url":"https://api.github.com/repos/daniilguit/Hystrix/events","assignees_url":"https://api.github.com/repos/daniilguit/Hystrix/assignees{/user}","branches_url":"https://api.github.com/repos/daniilguit/Hystrix/branches{/branch}","tags_url":"https://api.github.com/repos/daniilguit/Hystrix/tags","blobs_url":"https://api.github.com/repos/daniilguit/Hystrix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daniilguit/Hystrix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daniilguit/Hystrix/git/refs{/sha}","trees_url":"https://api.github.com/repos/daniilguit/Hystrix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daniilguit/Hystrix/statuses/{sha}","languages_url":"https://api.github.com/repos/daniilguit/Hystrix/languages","stargazers_url":"https://api.github.com/repos/daniilguit/Hystrix/stargazers","contributors_url":"https://api.github.com/repos/daniilguit/Hystrix/contributors","subscribers_url":"https://api.github.com/repos/daniilguit/Hystrix/subscribers","subscription_url":"https://api.github.com/repos/daniilguit/Hystrix/subscription","commits_url":"https://api.github.com/repos/daniilguit/Hystrix/commits{/sha}","git_commits_url":"https://api.github.com/repos/daniilguit/Hystrix/git/commits{/sha}","comments_url":"https://api.github.com/repos/daniilguit/Hystrix/comments{/number}","issue_comment_url":"https://api.github.com/repos/daniilguit/Hystrix/issues/comments{/number}","contents_url":"https://api.github.com/repos/daniilguit/Hystrix/contents/{+path}","compare_url":"https://api.github.com/repos/daniilguit/Hystrix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daniilguit/Hystrix/merges","archive_url":"https://api.github.com/repos/daniilguit/Hystrix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daniilguit/Hystrix/downloads","issues_url":"https://api.github.com/repos/daniilguit/Hystrix/issues{/number}","pulls_url":"https://api.github.com/repos/daniilguit/Hystrix/pulls{/number}","milestones_url":"https://api.github.com/repos/daniilguit/Hystrix/milestones{/number}","notifications_url":"https://api.github.com/repos/daniilguit/Hystrix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daniilguit/Hystrix/labels{/name}","releases_url":"https://api.github.com/repos/daniilguit/Hystrix/releases{/id}","deployments_url":"https://api.github.com/repos/daniilguit/Hystrix/deployments","created_at":"2016-07-07T11:34:12Z","updated_at":"2016-07-07T11:34:18Z","pushed_at":"2016-07-08T06:33:35Z","git_url":"git://github.com/daniilguit/Hystrix.git","ssh_url":"git@github.com:daniilguit/Hystrix.git","clone_url":"https://github.com/daniilguit/Hystrix.git","svn_url":"https://github.com/daniilguit/Hystrix","homepage":"","size":10594,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Netflix:master","ref":"master","sha":"2bea399a7f10efb877207be3d582d3098ea4314f","user":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":6766558,"name":"Hystrix","full_name":"Netflix/Hystrix","owner":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/Hystrix","description":"Hystrix is a latency and fault tolerance library designed to isolate points of access to remote systems, services and 3rd party libraries, stop cascading failure and enable resilience in complex distributed systems where failure is inevitable.","fork":false,"url":"https://api.github.com/repos/Netflix/Hystrix","forks_url":"https://api.github.com/repos/Netflix/Hystrix/forks","keys_url":"https://api.github.com/repos/Netflix/Hystrix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/Hystrix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/Hystrix/teams","hooks_url":"https://api.github.com/repos/Netflix/Hystrix/hooks","issue_events_url":"https://api.github.com/repos/Netflix/Hystrix/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/Hystrix/events","assignees_url":"https://api.github.com/repos/Netflix/Hystrix/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/Hystrix/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/Hystrix/tags","blobs_url":"https://api.github.com/repos/Netflix/Hystrix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/Hystrix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/Hystrix/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/Hystrix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/Hystrix/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/Hystrix/languages","stargazers_url":"https://api.github.com/repos/Netflix/Hystrix/stargazers","contributors_url":"https://api.github.com/repos/Netflix/Hystrix/contributors","subscribers_url":"https://api.github.com/repos/Netflix/Hystrix/subscribers","subscription_url":"https://api.github.com/repos/Netflix/Hystrix/subscription","commits_url":"https://api.github.com/repos/Netflix/Hystrix/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/Hystrix/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/Hystrix/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/Hystrix/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/Hystrix/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/Hystrix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/Hystrix/merges","archive_url":"https://api.github.com/repos/Netflix/Hystrix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/Hystrix/downloads","issues_url":"https://api.github.com/repos/Netflix/Hystrix/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/Hystrix/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/Hystrix/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/Hystrix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/Hystrix/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/Hystrix/releases{/id}","deployments_url":"https://api.github.com/repos/Netflix/Hystrix/deployments","created_at":"2012-11-19T20:14:46Z","updated_at":"2016-07-08T03:43:25Z","pushed_at":"2016-07-07T06:24:48Z","git_url":"git://github.com/Netflix/Hystrix.git","ssh_url":"git@github.com:Netflix/Hystrix.git","clone_url":"https://github.com/Netflix/Hystrix.git","svn_url":"https://github.com/Netflix/Hystrix","homepage":"","size":10594,"stargazers_count":6361,"watchers_count":6361,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1181,"mirror_url":null,"open_issues_count":54,"forks":1181,"open_issues":54,"watchers":6361,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/Hystrix/pulls/1271"},"html":{"href":"https://github.com/Netflix/Hystrix/pull/1271"},"issue":{"href":"https://api.github.com/repos/Netflix/Hystrix/issues/1271"},"comments":{"href":"https://api.github.com/repos/Netflix/Hystrix/issues/1271/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/Hystrix/pulls/1271/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/Hystrix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Netflix/Hystrix/pulls/1271/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/Hystrix/statuses/045cef325f35b9fed7711f613c2b84e38a42ca6c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":8,"changed_files":1}}
{"actor":{"display_login":"daniilguit"}}