{"action":"created","issue":{"url":"https://api.github.com/repos/spring-projects/spring-security/issues/173","repository_url":"https://api.github.com/repos/spring-projects/spring-security","labels_url":"https://api.github.com/repos/spring-projects/spring-security/issues/173/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-security/issues/173/comments","events_url":"https://api.github.com/repos/spring-projects/spring-security/issues/173/events","html_url":"https://github.com/spring-projects/spring-security/pull/173","id":58141773,"number":173,"title":"Introduced new AbstractUsernamePasswordAuthenticationFilter","user":{"login":"marceloverdijk","id":197004,"avatar_url":"https://avatars.githubusercontent.com/u/197004?v=3","gravatar_id":"","url":"https://api.github.com/users/marceloverdijk","html_url":"https://github.com/marceloverdijk","followers_url":"https://api.github.com/users/marceloverdijk/followers","following_url":"https://api.github.com/users/marceloverdijk/following{/other_user}","gists_url":"https://api.github.com/users/marceloverdijk/gists{/gist_id}","starred_url":"https://api.github.com/users/marceloverdijk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marceloverdijk/subscriptions","organizations_url":"https://api.github.com/users/marceloverdijk/orgs","repos_url":"https://api.github.com/users/marceloverdijk/repos","events_url":"https://api.github.com/users/marceloverdijk/events{/privacy}","received_events_url":"https://api.github.com/users/marceloverdijk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/spring-projects/spring-security/labels/Won't%20Fix","name":"Won't Fix","color":"ededed"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2015-02-18T22:49:15Z","updated_at":"2016-09-21T15:55:58Z","closed_at":"2016-09-21T15:55:58Z","pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-security/pulls/173","html_url":"https://github.com/spring-projects/spring-security/pull/173","diff_url":"https://github.com/spring-projects/spring-security/pull/173.diff","patch_url":"https://github.com/spring-projects/spring-security/pull/173.patch"},"body":"I've created a new AbstractUsernamePasswordAuthenticationFilter.\r\nAbstractUsernamePasswordAuthenticationFilter allows more easily custom username/password based authentication scenario's.\r\nImplmenetors can e.g. use form submission data, request headers or a json payload.\r\n\r\nThe existing UsernamePasswordAuthenticationFilter is now extending this new  AbstractUsernamePasswordAuthenticationFilter, but API wise it's unchanged and supports exactly what it does now.\r\n\r\nSo what this AbstractUsernamePasswordAuthenticationFilter provides for me at the end is an easy way to create my custom JsonUsernamePasswordAuthenticationFilter.\r\n\r\nWhat do you think?"},"comment":{"url":"https://api.github.com/repos/spring-projects/spring-security/issues/comments/248656842","html_url":"https://github.com/spring-projects/spring-security/pull/173#issuecomment-248656842","issue_url":"https://api.github.com/repos/spring-projects/spring-security/issues/173","id":248656842,"user":{"login":"rwinch","id":362503,"avatar_url":"https://avatars.githubusercontent.com/u/362503?v=3","gravatar_id":"","url":"https://api.github.com/users/rwinch","html_url":"https://github.com/rwinch","followers_url":"https://api.github.com/users/rwinch/followers","following_url":"https://api.github.com/users/rwinch/following{/other_user}","gists_url":"https://api.github.com/users/rwinch/gists{/gist_id}","starred_url":"https://api.github.com/users/rwinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwinch/subscriptions","organizations_url":"https://api.github.com/users/rwinch/orgs","repos_url":"https://api.github.com/users/rwinch/repos","events_url":"https://api.github.com/users/rwinch/events{/privacy}","received_events_url":"https://api.github.com/users/rwinch/received_events","type":"User","site_admin":false},"created_at":"2016-09-21T15:55:58Z","updated_at":"2016-09-21T15:55:58Z","body":"I'm closing this as won't fix as this doesn't add much value over just extending `UsernamePasswordAuthenticationFilter ` and adds additional noise to the APIs and complicates the object hierarchy."}}
{"actor":{"display_login":"rwinch"}}