{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments/58908487","id":58908487,"diff_hunk":"@@ -0,0 +1,153 @@\n+# Copyright 2015 PerfKitBenchmarker Authors. All rights reserved.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#   http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+\"\"\"Runs the in-memory analytics benchmark of Cloudsuite.\n+\n+More info: http://cloudsuite.ch/inmemoryanalytics/\n+\"\"\"\n+\n+import re\n+\n+from perfkitbenchmarker import configs\n+from perfkitbenchmarker import flags\n+from perfkitbenchmarker import sample\n+\n+flags.DEFINE_string('ima_dataset',\n+                    '/data/ml-latest-small',\n+                    'Dataset to use for training.')\n+flags.DEFINE_string('ima_ratings_file',\n+                    '/data/myratings.csv',\n+                    'Ratings file to give the recommendation for.')\n+FLAGS = flags.FLAGS\n+\n+BENCHMARK_NAME = 'cloudsuite_inmemory_analytics'\n+BENCHMARK_CONFIG = \"\"\"\n+cloudsuite_inmemory_analytics:\n+  description: >\n+    Run Cloudsuite in-memory analytics benchmark. Specify the number of worker\n+    VMs with --num_vms.\n+  vm_groups:\n+    master:\n+      vm_spec: *default_single_core\n+    workers:\n+      vm_spec: *default_single_core\n+      vm_count: 1","path":"perfkitbenchmarker/linux_benchmarks/cloudsuite_inmemory_analytics_benchmark.py","position":45,"original_position":45,"commit_id":"9c0fb309dbacdf8b08a26b058aca515f661ed6c9","original_commit_id":"019a52d783b92128210fee71d3eea755ebd566e5","user":{"login":"skschneider","id":11166925,"avatar_url":"https://avatars.githubusercontent.com/u/11166925?v=3","gravatar_id":"","url":"https://api.github.com/users/skschneider","html_url":"https://github.com/skschneider","followers_url":"https://api.github.com/users/skschneider/followers","following_url":"https://api.github.com/users/skschneider/following{/other_user}","gists_url":"https://api.github.com/users/skschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/skschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skschneider/subscriptions","organizations_url":"https://api.github.com/users/skschneider/orgs","repos_url":"https://api.github.com/users/skschneider/repos","events_url":"https://api.github.com/users/skschneider/events{/privacy}","received_events_url":"https://api.github.com/users/skschneider/received_events","type":"User","site_admin":false},"body":"Makes sense, just confirming that's what you wanted since it looks a bit weird. The master group, which should always have 1 VM, has the vm_count omitted (which functionally is the same as explicitly setting it to 1), while the worker group, which can have one or more VMs, has the vm_count explicitly set to 1 (but can be overridden elsewhere). Functionally, what you have here is fine, but it *looks* like the master group size is nebulous while the workers group size is recommended/fixed.","created_at":"2016-04-07T17:11:06Z","updated_at":"2016-04-07T17:11:06Z","html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/934#discussion_r58908487","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/934","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments/58908487"},"html":{"href":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/934#discussion_r58908487"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/934"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/934","id":65525462,"html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/934","diff_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/934.diff","patch_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/934.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/934","number":934,"state":"open","locked":false,"title":"Cloudsuite: in-memory analytics benchmark","user":{"login":"ivonindza","id":10741487,"avatar_url":"https://avatars.githubusercontent.com/u/10741487?v=3","gravatar_id":"","url":"https://api.github.com/users/ivonindza","html_url":"https://github.com/ivonindza","followers_url":"https://api.github.com/users/ivonindza/followers","following_url":"https://api.github.com/users/ivonindza/following{/other_user}","gists_url":"https://api.github.com/users/ivonindza/gists{/gist_id}","starred_url":"https://api.github.com/users/ivonindza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivonindza/subscriptions","organizations_url":"https://api.github.com/users/ivonindza/orgs","repos_url":"https://api.github.com/users/ivonindza/repos","events_url":"https://api.github.com/users/ivonindza/events{/privacy}","received_events_url":"https://api.github.com/users/ivonindza/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-06T19:51:57Z","updated_at":"2016-04-07T17:11:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4f0c1c706f34aa3b941fb6b7718952c56f0cd78","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/934/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/934/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/934/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/9c0fb309dbacdf8b08a26b058aca515f661ed6c9","head":{"label":"ParsaLab:cloudsuite","ref":"cloudsuite","sha":"9c0fb309dbacdf8b08a26b058aca515f661ed6c9","user":{"login":"ParsaLab","id":16538637,"avatar_url":"https://avatars.githubusercontent.com/u/16538637?v=3","gravatar_id":"","url":"https://api.github.com/users/ParsaLab","html_url":"https://github.com/ParsaLab","followers_url":"https://api.github.com/users/ParsaLab/followers","following_url":"https://api.github.com/users/ParsaLab/following{/other_user}","gists_url":"https://api.github.com/users/ParsaLab/gists{/gist_id}","starred_url":"https://api.github.com/users/ParsaLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParsaLab/subscriptions","organizations_url":"https://api.github.com/users/ParsaLab/orgs","repos_url":"https://api.github.com/users/ParsaLab/repos","events_url":"https://api.github.com/users/ParsaLab/events{/privacy}","received_events_url":"https://api.github.com/users/ParsaLab/received_events","type":"Organization","site_admin":false},"repo":{"id":51399241,"name":"PerfKitBenchmarker","full_name":"ParsaLab/PerfKitBenchmarker","owner":{"login":"ParsaLab","id":16538637,"avatar_url":"https://avatars.githubusercontent.com/u/16538637?v=3","gravatar_id":"","url":"https://api.github.com/users/ParsaLab","html_url":"https://github.com/ParsaLab","followers_url":"https://api.github.com/users/ParsaLab/followers","following_url":"https://api.github.com/users/ParsaLab/following{/other_user}","gists_url":"https://api.github.com/users/ParsaLab/gists{/gist_id}","starred_url":"https://api.github.com/users/ParsaLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParsaLab/subscriptions","organizations_url":"https://api.github.com/users/ParsaLab/orgs","repos_url":"https://api.github.com/users/ParsaLab/repos","events_url":"https://api.github.com/users/ParsaLab/events{/privacy}","received_events_url":"https://api.github.com/users/ParsaLab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ParsaLab/PerfKitBenchmarker","description":"Perfkit Benchmarker contains set of benchmarks to measure and compare cloud offerings. The benchmarks use defaults to reflect what most users will see. PerfKit Benchmarker is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.","fork":true,"url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker","forks_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/forks","keys_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/teams","hooks_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/hooks","issue_events_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/issues/events{/number}","events_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/events","assignees_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/assignees{/user}","branches_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/branches{/branch}","tags_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/tags","blobs_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/statuses/{sha}","languages_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/languages","stargazers_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/stargazers","contributors_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/contributors","subscribers_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/subscribers","subscription_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/subscription","commits_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/contents/{+path}","compare_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/merges","archive_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/downloads","issues_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/issues{/number}","pulls_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/pulls{/number}","milestones_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/milestones{/number}","notifications_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/labels{/name}","releases_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/releases{/id}","deployments_url":"https://api.github.com/repos/ParsaLab/PerfKitBenchmarker/deployments","created_at":"2016-02-09T20:56:10Z","updated_at":"2016-02-09T20:56:12Z","pushed_at":"2016-04-07T11:50:18Z","git_url":"git://github.com/ParsaLab/PerfKitBenchmarker.git","ssh_url":"git@github.com:ParsaLab/PerfKitBenchmarker.git","clone_url":"https://github.com/ParsaLab/PerfKitBenchmarker.git","svn_url":"https://github.com/ParsaLab/PerfKitBenchmarker","homepage":"http://googlecloudplatform.github.io/PerfKitBenchmarker/","size":6980,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"059d2bdd951d4b27b77b0215e3ec8c1866ca25f3","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":21950910,"name":"PerfKitBenchmarker","full_name":"GoogleCloudPlatform/PerfKitBenchmarker","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker","description":"Perfkit Benchmarker contains set of benchmarks to measure and compare cloud offerings. The benchmarks use defaults to reflect what most users will see. PerfKit Benchmarker is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/deployments","created_at":"2014-07-17T17:23:26Z","updated_at":"2016-04-06T05:22:10Z","pushed_at":"2016-04-07T16:39:24Z","git_url":"git://github.com/GoogleCloudPlatform/PerfKitBenchmarker.git","ssh_url":"git@github.com:GoogleCloudPlatform/PerfKitBenchmarker.git","clone_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker.git","svn_url":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker","homepage":"http://googlecloudplatform.github.io/PerfKitBenchmarker/","size":85329,"stargazers_count":618,"watchers_count":618,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":127,"mirror_url":null,"open_issues_count":124,"forks":127,"open_issues":124,"watchers":618,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/934"},"html":{"href":"https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/934"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/934"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/issues/934/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/934/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/pulls/934/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/PerfKitBenchmarker/statuses/9c0fb309dbacdf8b08a26b058aca515f661ed6c9"}}}}