{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/16697","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/16697/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/16697/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/16697/events","html_url":"https://github.com/mantidproject/mantid/pull/16697","id":161668138,"number":16697,"title":" Improve NXcanSAS support","user":{"login":"AntonPiccardoSelg","id":8955784,"avatar_url":"https://avatars.githubusercontent.com/u/8955784?v=3","gravatar_id":"","url":"https://api.github.com/users/AntonPiccardoSelg","html_url":"https://github.com/AntonPiccardoSelg","followers_url":"https://api.github.com/users/AntonPiccardoSelg/followers","following_url":"https://api.github.com/users/AntonPiccardoSelg/following{/other_user}","gists_url":"https://api.github.com/users/AntonPiccardoSelg/gists{/gist_id}","starred_url":"https://api.github.com/users/AntonPiccardoSelg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntonPiccardoSelg/subscriptions","organizations_url":"https://api.github.com/users/AntonPiccardoSelg/orgs","repos_url":"https://api.github.com/users/AntonPiccardoSelg/repos","events_url":"https://api.github.com/users/AntonPiccardoSelg/events{/privacy}","received_events_url":"https://api.github.com/users/AntonPiccardoSelg/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Framework","name":"Component: Framework","color":"009800"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20SANS","name":"Component: SANS","color":"009800"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Science%20Validation","name":"Misc: Science Validation","color":"5319e7"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/State:%20In%20Progress","name":"State: In Progress","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"KarlPalmen","id":1133249,"avatar_url":"https://avatars.githubusercontent.com/u/1133249?v=3","gravatar_id":"","url":"https://api.github.com/users/KarlPalmen","html_url":"https://github.com/KarlPalmen","followers_url":"https://api.github.com/users/KarlPalmen/followers","following_url":"https://api.github.com/users/KarlPalmen/following{/other_user}","gists_url":"https://api.github.com/users/KarlPalmen/gists{/gist_id}","starred_url":"https://api.github.com/users/KarlPalmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarlPalmen/subscriptions","organizations_url":"https://api.github.com/users/KarlPalmen/orgs","repos_url":"https://api.github.com/users/KarlPalmen/repos","events_url":"https://api.github.com/users/KarlPalmen/events{/privacy}","received_events_url":"https://api.github.com/users/KarlPalmen/received_events","type":"User","site_admin":false},"assignees":[{"login":"KarlPalmen","id":1133249,"avatar_url":"https://avatars.githubusercontent.com/u/1133249?v=3","gravatar_id":"","url":"https://api.github.com/users/KarlPalmen","html_url":"https://github.com/KarlPalmen","followers_url":"https://api.github.com/users/KarlPalmen/followers","following_url":"https://api.github.com/users/KarlPalmen/following{/other_user}","gists_url":"https://api.github.com/users/KarlPalmen/gists{/gist_id}","starred_url":"https://api.github.com/users/KarlPalmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarlPalmen/subscriptions","organizations_url":"https://api.github.com/users/KarlPalmen/orgs","repos_url":"https://api.github.com/users/KarlPalmen/repos","events_url":"https://api.github.com/users/KarlPalmen/events{/privacy}","received_events_url":"https://api.github.com/users/KarlPalmen/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/58","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.8","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/58/labels","id":1505614,"number":58,"title":"Release 3.8","description":"","creator":{"login":"granrothge","id":5910574,"avatar_url":"https://avatars.githubusercontent.com/u/5910574?v=3","gravatar_id":"","url":"https://api.github.com/users/granrothge","html_url":"https://github.com/granrothge","followers_url":"https://api.github.com/users/granrothge/followers","following_url":"https://api.github.com/users/granrothge/following{/other_user}","gists_url":"https://api.github.com/users/granrothge/gists{/gist_id}","starred_url":"https://api.github.com/users/granrothge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granrothge/subscriptions","organizations_url":"https://api.github.com/users/granrothge/orgs","repos_url":"https://api.github.com/users/granrothge/repos","events_url":"https://api.github.com/users/granrothge/events{/privacy}","received_events_url":"https://api.github.com/users/granrothge/received_events","type":"User","site_admin":false},"open_issues":626,"closed_issues":244,"state":"open","created_at":"2016-01-13T20:00:53Z","updated_at":"2016-06-30T12:43:45Z","due_on":"2016-10-09T23:00:00Z","closed_at":null},"comments":1,"created_at":"2016-06-22T12:25:45Z","updated_at":"2016-06-30T15:14:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/16697","html_url":"https://github.com/mantidproject/mantid/pull/16697","diff_url":"https://github.com/mantidproject/mantid/pull/16697.diff","patch_url":"https://github.com/mantidproject/mantid/pull/16697.patch"},"body":"This is currently with Stephen King and the CanSAS consortium.\r\n\r\nFixes #16685\r\n\r\nSeveral issues, reported by the CanSAS consortium, were fixed:\r\n\r\n1. Introduce canSAS_class\r\n1. Provide NX_class with equivalent class names. This attribute lives in parallel to the canSAS_class one. Essentially this makes the file format compatible with Nexus and CanSAS\r\n1. Set dates to ISO-8601 format\r\n1. Change the Q_indices attribute to be a int array\r\n1. SDD which is part of the detectors is now a floating point instead of a string\r\n1. change `unit` to `units` \r\n\r\n## For testing\r\n\r\n* The changes will be presented to the CanSAS consortium again, hence we have scientific validation for this.\r\n* Code review. \r\nDoes not have to be in release notes since it is a \"small\" enhancement\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [x] Is the code of an acceptable quality?\r\n- [x] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [x] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/229690387","html_url":"https://github.com/mantidproject/mantid/pull/16697#issuecomment-229690387","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/16697","id":229690387,"user":{"login":"KarlPalmen","id":1133249,"avatar_url":"https://avatars.githubusercontent.com/u/1133249?v=3","gravatar_id":"","url":"https://api.github.com/users/KarlPalmen","html_url":"https://github.com/KarlPalmen","followers_url":"https://api.github.com/users/KarlPalmen/followers","following_url":"https://api.github.com/users/KarlPalmen/following{/other_user}","gists_url":"https://api.github.com/users/KarlPalmen/gists{/gist_id}","starred_url":"https://api.github.com/users/KarlPalmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarlPalmen/subscriptions","organizations_url":"https://api.github.com/users/KarlPalmen/orgs","repos_url":"https://api.github.com/users/KarlPalmen/repos","events_url":"https://api.github.com/users/KarlPalmen/events{/privacy}","received_events_url":"https://api.github.com/users/KarlPalmen/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T15:14:51Z","updated_at":"2016-06-30T15:14:51Z","body":"Code review good :shipit: "}}
{"actor":{"display_login":"KarlPalmen"}}