{"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/avro/pulls/comments/61695928","id":61695928,"diff_hunk":"@@ -119,11 +120,27 @@ def validate(expected_schema, datum):\n       return isinstance(datum, Decimal)\n     return isinstance(datum, str)\n   elif schema_type == 'int':\n-    return ((isinstance(datum, int) or isinstance(datum, long)) \n-            and INT_MIN_VALUE <= datum <= INT_MAX_VALUE)\n+    if hasattr(expected_schema, 'logical_type'):\n+      if expected_schema.logical_type == 'date':\n+        return isinstance(datum, datetime.date)\n+      elif expected_schema.logical_type == 'time-millis':","path":"lang/py/src/avro/io.py","position":17,"original_position":17,"commit_id":"87b824e0e89f86eeeb2936903c0d6225b2743c4a","original_commit_id":"87b824e0e89f86eeeb2936903c0d6225b2743c4a","user":{"login":"premsantosh","id":1332635,"avatar_url":"https://avatars.githubusercontent.com/u/1332635?v=3","gravatar_id":"","url":"https://api.github.com/users/premsantosh","html_url":"https://github.com/premsantosh","followers_url":"https://api.github.com/users/premsantosh/followers","following_url":"https://api.github.com/users/premsantosh/following{/other_user}","gists_url":"https://api.github.com/users/premsantosh/gists{/gist_id}","starred_url":"https://api.github.com/users/premsantosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/premsantosh/subscriptions","organizations_url":"https://api.github.com/users/premsantosh/orgs","repos_url":"https://api.github.com/users/premsantosh/repos","events_url":"https://api.github.com/users/premsantosh/events{/privacy}","received_events_url":"https://api.github.com/users/premsantosh/received_events","type":"User","site_admin":false},"body":"I think it would be better if this was `time_millis`. ","created_at":"2016-05-02T00:21:57Z","updated_at":"2016-05-02T00:21:57Z","html_url":"https://github.com/Yelp/avro/pull/8#discussion_r61695928","pull_request_url":"https://api.github.com/repos/Yelp/avro/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/Yelp/avro/pulls/comments/61695928"},"html":{"href":"https://github.com/Yelp/avro/pull/8#discussion_r61695928"},"pull_request":{"href":"https://api.github.com/repos/Yelp/avro/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/Yelp/avro/pulls/8","id":68481212,"html_url":"https://github.com/Yelp/avro/pull/8","diff_url":"https://github.com/Yelp/avro/pull/8.diff","patch_url":"https://github.com/Yelp/avro/pull/8.patch","issue_url":"https://api.github.com/repos/Yelp/avro/issues/8","number":8,"state":"open","locked":false,"title":"time, date and timestamp support added","user":{"login":"abrarsheikh","id":5113943,"avatar_url":"https://avatars.githubusercontent.com/u/5113943?v=3","gravatar_id":"","url":"https://api.github.com/users/abrarsheikh","html_url":"https://github.com/abrarsheikh","followers_url":"https://api.github.com/users/abrarsheikh/followers","following_url":"https://api.github.com/users/abrarsheikh/following{/other_user}","gists_url":"https://api.github.com/users/abrarsheikh/gists{/gist_id}","starred_url":"https://api.github.com/users/abrarsheikh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrarsheikh/subscriptions","organizations_url":"https://api.github.com/users/abrarsheikh/orgs","repos_url":"https://api.github.com/users/abrarsheikh/repos","events_url":"https://api.github.com/users/abrarsheikh/events{/privacy}","received_events_url":"https://api.github.com/users/abrarsheikh/received_events","type":"User","site_admin":false},"body":"@premsantosh @clin7 ","created_at":"2016-04-30T22:47:03Z","updated_at":"2016-05-02T00:21:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f2b55aaa16f548b4f832fb1799722c86868f24c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/avro/pulls/8/commits","review_comments_url":"https://api.github.com/repos/Yelp/avro/pulls/8/comments","review_comment_url":"https://api.github.com/repos/Yelp/avro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/avro/issues/8/comments","statuses_url":"https://api.github.com/repos/Yelp/avro/statuses/87b824e0e89f86eeeb2936903c0d6225b2743c4a","head":{"label":"abrarsheikh:date_time_ts","ref":"date_time_ts","sha":"87b824e0e89f86eeeb2936903c0d6225b2743c4a","user":{"login":"abrarsheikh","id":5113943,"avatar_url":"https://avatars.githubusercontent.com/u/5113943?v=3","gravatar_id":"","url":"https://api.github.com/users/abrarsheikh","html_url":"https://github.com/abrarsheikh","followers_url":"https://api.github.com/users/abrarsheikh/followers","following_url":"https://api.github.com/users/abrarsheikh/following{/other_user}","gists_url":"https://api.github.com/users/abrarsheikh/gists{/gist_id}","starred_url":"https://api.github.com/users/abrarsheikh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrarsheikh/subscriptions","organizations_url":"https://api.github.com/users/abrarsheikh/orgs","repos_url":"https://api.github.com/users/abrarsheikh/repos","events_url":"https://api.github.com/users/abrarsheikh/events{/privacy}","received_events_url":"https://api.github.com/users/abrarsheikh/received_events","type":"User","site_admin":false},"repo":{"id":57269605,"name":"avro","full_name":"abrarsheikh/avro","owner":{"login":"abrarsheikh","id":5113943,"avatar_url":"https://avatars.githubusercontent.com/u/5113943?v=3","gravatar_id":"","url":"https://api.github.com/users/abrarsheikh","html_url":"https://github.com/abrarsheikh","followers_url":"https://api.github.com/users/abrarsheikh/followers","following_url":"https://api.github.com/users/abrarsheikh/following{/other_user}","gists_url":"https://api.github.com/users/abrarsheikh/gists{/gist_id}","starred_url":"https://api.github.com/users/abrarsheikh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrarsheikh/subscriptions","organizations_url":"https://api.github.com/users/abrarsheikh/orgs","repos_url":"https://api.github.com/users/abrarsheikh/repos","events_url":"https://api.github.com/users/abrarsheikh/events{/privacy}","received_events_url":"https://api.github.com/users/abrarsheikh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abrarsheikh/avro","description":"Mirror of Apache Avro","fork":true,"url":"https://api.github.com/repos/abrarsheikh/avro","forks_url":"https://api.github.com/repos/abrarsheikh/avro/forks","keys_url":"https://api.github.com/repos/abrarsheikh/avro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abrarsheikh/avro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abrarsheikh/avro/teams","hooks_url":"https://api.github.com/repos/abrarsheikh/avro/hooks","issue_events_url":"https://api.github.com/repos/abrarsheikh/avro/issues/events{/number}","events_url":"https://api.github.com/repos/abrarsheikh/avro/events","assignees_url":"https://api.github.com/repos/abrarsheikh/avro/assignees{/user}","branches_url":"https://api.github.com/repos/abrarsheikh/avro/branches{/branch}","tags_url":"https://api.github.com/repos/abrarsheikh/avro/tags","blobs_url":"https://api.github.com/repos/abrarsheikh/avro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abrarsheikh/avro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abrarsheikh/avro/git/refs{/sha}","trees_url":"https://api.github.com/repos/abrarsheikh/avro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abrarsheikh/avro/statuses/{sha}","languages_url":"https://api.github.com/repos/abrarsheikh/avro/languages","stargazers_url":"https://api.github.com/repos/abrarsheikh/avro/stargazers","contributors_url":"https://api.github.com/repos/abrarsheikh/avro/contributors","subscribers_url":"https://api.github.com/repos/abrarsheikh/avro/subscribers","subscription_url":"https://api.github.com/repos/abrarsheikh/avro/subscription","commits_url":"https://api.github.com/repos/abrarsheikh/avro/commits{/sha}","git_commits_url":"https://api.github.com/repos/abrarsheikh/avro/git/commits{/sha}","comments_url":"https://api.github.com/repos/abrarsheikh/avro/comments{/number}","issue_comment_url":"https://api.github.com/repos/abrarsheikh/avro/issues/comments{/number}","contents_url":"https://api.github.com/repos/abrarsheikh/avro/contents/{+path}","compare_url":"https://api.github.com/repos/abrarsheikh/avro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abrarsheikh/avro/merges","archive_url":"https://api.github.com/repos/abrarsheikh/avro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abrarsheikh/avro/downloads","issues_url":"https://api.github.com/repos/abrarsheikh/avro/issues{/number}","pulls_url":"https://api.github.com/repos/abrarsheikh/avro/pulls{/number}","milestones_url":"https://api.github.com/repos/abrarsheikh/avro/milestones{/number}","notifications_url":"https://api.github.com/repos/abrarsheikh/avro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abrarsheikh/avro/labels{/name}","releases_url":"https://api.github.com/repos/abrarsheikh/avro/releases{/id}","deployments_url":"https://api.github.com/repos/abrarsheikh/avro/deployments","created_at":"2016-04-28T03:57:58Z","updated_at":"2016-04-28T03:58:02Z","pushed_at":"2016-04-30T22:45:57Z","git_url":"git://github.com/abrarsheikh/avro.git","ssh_url":"git@github.com:abrarsheikh/avro.git","clone_url":"https://github.com/abrarsheikh/avro.git","svn_url":"https://github.com/abrarsheikh/avro","homepage":null,"size":10014,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Yelp:trunk","ref":"trunk","sha":"5f7b97fcbb79cabf4ed7a7ec5ba8314d06e8a7e5","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":19746560,"name":"avro","full_name":"Yelp/avro","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/avro","description":"Mirror of Apache Avro","fork":true,"url":"https://api.github.com/repos/Yelp/avro","forks_url":"https://api.github.com/repos/Yelp/avro/forks","keys_url":"https://api.github.com/repos/Yelp/avro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/avro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/avro/teams","hooks_url":"https://api.github.com/repos/Yelp/avro/hooks","issue_events_url":"https://api.github.com/repos/Yelp/avro/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/avro/events","assignees_url":"https://api.github.com/repos/Yelp/avro/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/avro/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/avro/tags","blobs_url":"https://api.github.com/repos/Yelp/avro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/avro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/avro/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/avro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/avro/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/avro/languages","stargazers_url":"https://api.github.com/repos/Yelp/avro/stargazers","contributors_url":"https://api.github.com/repos/Yelp/avro/contributors","subscribers_url":"https://api.github.com/repos/Yelp/avro/subscribers","subscription_url":"https://api.github.com/repos/Yelp/avro/subscription","commits_url":"https://api.github.com/repos/Yelp/avro/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/avro/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/avro/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/avro/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/avro/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/avro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/avro/merges","archive_url":"https://api.github.com/repos/Yelp/avro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/avro/downloads","issues_url":"https://api.github.com/repos/Yelp/avro/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/avro/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/avro/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/avro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/avro/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/avro/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/avro/deployments","created_at":"2014-05-13T16:22:03Z","updated_at":"2015-04-13T21:51:40Z","pushed_at":"2016-04-30T22:47:04Z","git_url":"git://github.com/Yelp/avro.git","ssh_url":"git@github.com:Yelp/avro.git","clone_url":"https://github.com/Yelp/avro.git","svn_url":"https://github.com/Yelp/avro","homepage":null,"size":10099,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":2,"default_branch":"branch-1.3"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/avro/pulls/8"},"html":{"href":"https://github.com/Yelp/avro/pull/8"},"issue":{"href":"https://api.github.com/repos/Yelp/avro/issues/8"},"comments":{"href":"https://api.github.com/repos/Yelp/avro/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/avro/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/avro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/avro/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/avro/statuses/87b824e0e89f86eeeb2936903c0d6225b2743c4a"}}}}