{"action":"created","comment":{"url":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments/65268227","id":65268227,"diff_hunk":"@@ -152,7 +160,18 @@ def start_of_new_scope?(child)\n \n         def instance_eval_or_new_call?(child)","path":"lib/rubocop/cop/lint/useless_access_modifier.rb","position":17,"original_position":17,"commit_id":"eb003b1b6212dd29e48901f4211c28e54cab5a6a","original_commit_id":"eb003b1b6212dd29e48901f4211c28e54cab5a6a","user":{"login":"owst","id":117234,"avatar_url":"https://avatars.githubusercontent.com/u/117234?v=3","gravatar_id":"","url":"https://api.github.com/users/owst","html_url":"https://github.com/owst","followers_url":"https://api.github.com/users/owst/followers","following_url":"https://api.github.com/users/owst/following{/other_user}","gists_url":"https://api.github.com/users/owst/gists{/gist_id}","starred_url":"https://api.github.com/users/owst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owst/subscriptions","organizations_url":"https://api.github.com/users/owst/orgs","repos_url":"https://api.github.com/users/owst/repos","events_url":"https://api.github.com/users/owst/events{/privacy}","received_events_url":"https://api.github.com/users/owst/received_events","type":"User","site_admin":false},"body":"Hmm, this method name isn't really correct any more (it probably wasn't quite right when I created it!). Since all these conditions are now essentially \"do we end up calling `{class,module,instance}_eval`\" I wonder if a better name is simply `eval_call?(child)` ","created_at":"2016-05-31T21:42:35Z","updated_at":"2016-05-31T21:42:35Z","html_url":"https://github.com/bbatsov/rubocop/pull/3186#discussion_r65268227","pull_request_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/3186","_links":{"self":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments/65268227"},"html":{"href":"https://github.com/bbatsov/rubocop/pull/3186#discussion_r65268227"},"pull_request":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/3186"}}},"pull_request":{"url":"https://api.github.com/repos/bbatsov/rubocop/pulls/3186","id":72082303,"html_url":"https://github.com/bbatsov/rubocop/pull/3186","diff_url":"https://github.com/bbatsov/rubocop/pull/3186.diff","patch_url":"https://github.com/bbatsov/rubocop/pull/3186.patch","issue_url":"https://api.github.com/repos/bbatsov/rubocop/issues/3186","number":3186,"state":"open","locked":false,"title":"Make UselessAccessModifier ActiveSupport aware","user":{"login":"maxjacobson","id":1421211,"avatar_url":"https://avatars.githubusercontent.com/u/1421211?v=3","gravatar_id":"","url":"https://api.github.com/users/maxjacobson","html_url":"https://github.com/maxjacobson","followers_url":"https://api.github.com/users/maxjacobson/followers","following_url":"https://api.github.com/users/maxjacobson/following{/other_user}","gists_url":"https://api.github.com/users/maxjacobson/gists{/gist_id}","starred_url":"https://api.github.com/users/maxjacobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxjacobson/subscriptions","organizations_url":"https://api.github.com/users/maxjacobson/orgs","repos_url":"https://api.github.com/users/maxjacobson/repos","events_url":"https://api.github.com/users/maxjacobson/events{/privacy}","received_events_url":"https://api.github.com/users/maxjacobson/received_events","type":"User","site_admin":false},"body":"This PR makes the `Lint/UselessAccessModifier` cop aware of some ActiveSupport methods which do some metaprogramming, which makes a scenario where multiple access modifier keywords in one class is useful and not incorrect. This fixes a regression between 0.39 and 0.40 as described in #3136\r\n\r\ncc @owst -- thanks for the tip on how to extend this.\r\n\r\nBefore submitting the PR make sure the following are checked:\r\n\r\n* [x] Wrote [good commit messages][1].\r\n* [x] Used the same coding conventions as the rest of the project.\r\n* [x] Feature branch is up-to-date with `master` (if not - rebase it)\r\n* [x] Squashed related commits together.\r\n* [x] Added tests.\r\n* [x] Added an entry to the [Changelog](../blob/master/CHANGELOG.md) if the new code introduces user-observable changes. See [changelog entry format](../blob/master/CONTRIBUTING.md#changelog-entry-format).\r\n* [x] All tests are passing.\r\n* [x] The new code doesn't generate RuboCop offenses.\r\n* [x] The PR relates to *only* one subject with a clear title\r\n  and description in grammatically correct, complete sentences.\r\n\r\n[1]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html","created_at":"2016-05-31T20:42:31Z","updated_at":"2016-05-31T21:42:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdc828b811aaa52d9d8eace4a4f0117553bedec8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/3186/commits","review_comments_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/3186/comments","review_comment_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/issues/3186/comments","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/eb003b1b6212dd29e48901f4211c28e54cab5a6a","head":{"label":"maxjacobson:useless-access-modifier-active-support-aware","ref":"useless-access-modifier-active-support-aware","sha":"eb003b1b6212dd29e48901f4211c28e54cab5a6a","user":{"login":"maxjacobson","id":1421211,"avatar_url":"https://avatars.githubusercontent.com/u/1421211?v=3","gravatar_id":"","url":"https://api.github.com/users/maxjacobson","html_url":"https://github.com/maxjacobson","followers_url":"https://api.github.com/users/maxjacobson/followers","following_url":"https://api.github.com/users/maxjacobson/following{/other_user}","gists_url":"https://api.github.com/users/maxjacobson/gists{/gist_id}","starred_url":"https://api.github.com/users/maxjacobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxjacobson/subscriptions","organizations_url":"https://api.github.com/users/maxjacobson/orgs","repos_url":"https://api.github.com/users/maxjacobson/repos","events_url":"https://api.github.com/users/maxjacobson/events{/privacy}","received_events_url":"https://api.github.com/users/maxjacobson/received_events","type":"User","site_admin":false},"repo":{"id":60121763,"name":"rubocop","full_name":"maxjacobson/rubocop","owner":{"login":"maxjacobson","id":1421211,"avatar_url":"https://avatars.githubusercontent.com/u/1421211?v=3","gravatar_id":"","url":"https://api.github.com/users/maxjacobson","html_url":"https://github.com/maxjacobson","followers_url":"https://api.github.com/users/maxjacobson/followers","following_url":"https://api.github.com/users/maxjacobson/following{/other_user}","gists_url":"https://api.github.com/users/maxjacobson/gists{/gist_id}","starred_url":"https://api.github.com/users/maxjacobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxjacobson/subscriptions","organizations_url":"https://api.github.com/users/maxjacobson/orgs","repos_url":"https://api.github.com/users/maxjacobson/repos","events_url":"https://api.github.com/users/maxjacobson/events{/privacy}","received_events_url":"https://api.github.com/users/maxjacobson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxjacobson/rubocop","description":"A Ruby static code analyzer, based on the community Ruby style guide.","fork":true,"url":"https://api.github.com/repos/maxjacobson/rubocop","forks_url":"https://api.github.com/repos/maxjacobson/rubocop/forks","keys_url":"https://api.github.com/repos/maxjacobson/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxjacobson/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxjacobson/rubocop/teams","hooks_url":"https://api.github.com/repos/maxjacobson/rubocop/hooks","issue_events_url":"https://api.github.com/repos/maxjacobson/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/maxjacobson/rubocop/events","assignees_url":"https://api.github.com/repos/maxjacobson/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/maxjacobson/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/maxjacobson/rubocop/tags","blobs_url":"https://api.github.com/repos/maxjacobson/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxjacobson/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxjacobson/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxjacobson/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxjacobson/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/maxjacobson/rubocop/languages","stargazers_url":"https://api.github.com/repos/maxjacobson/rubocop/stargazers","contributors_url":"https://api.github.com/repos/maxjacobson/rubocop/contributors","subscribers_url":"https://api.github.com/repos/maxjacobson/rubocop/subscribers","subscription_url":"https://api.github.com/repos/maxjacobson/rubocop/subscription","commits_url":"https://api.github.com/repos/maxjacobson/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxjacobson/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxjacobson/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxjacobson/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxjacobson/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/maxjacobson/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxjacobson/rubocop/merges","archive_url":"https://api.github.com/repos/maxjacobson/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxjacobson/rubocop/downloads","issues_url":"https://api.github.com/repos/maxjacobson/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/maxjacobson/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/maxjacobson/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/maxjacobson/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxjacobson/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/maxjacobson/rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/maxjacobson/rubocop/deployments","created_at":"2016-05-31T20:38:49Z","updated_at":"2016-05-31T20:38:52Z","pushed_at":"2016-05-31T20:44:18Z","git_url":"git://github.com/maxjacobson/rubocop.git","ssh_url":"git@github.com:maxjacobson/rubocop.git","clone_url":"https://github.com/maxjacobson/rubocop.git","svn_url":"https://github.com/maxjacobson/rubocop","homepage":"http://rubocop.readthedocs.io","size":11957,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bbatsov:master","ref":"master","sha":"f46ec0d9537aed4f721b68252ddccd7d42602d9d","user":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars.githubusercontent.com/u/103882?v=3","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"repo":{"id":4095287,"name":"rubocop","full_name":"bbatsov/rubocop","owner":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars.githubusercontent.com/u/103882?v=3","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbatsov/rubocop","description":"A Ruby static code analyzer, based on the community Ruby style guide.","fork":false,"url":"https://api.github.com/repos/bbatsov/rubocop","forks_url":"https://api.github.com/repos/bbatsov/rubocop/forks","keys_url":"https://api.github.com/repos/bbatsov/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbatsov/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbatsov/rubocop/teams","hooks_url":"https://api.github.com/repos/bbatsov/rubocop/hooks","issue_events_url":"https://api.github.com/repos/bbatsov/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/bbatsov/rubocop/events","assignees_url":"https://api.github.com/repos/bbatsov/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/bbatsov/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/bbatsov/rubocop/tags","blobs_url":"https://api.github.com/repos/bbatsov/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbatsov/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbatsov/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbatsov/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/bbatsov/rubocop/languages","stargazers_url":"https://api.github.com/repos/bbatsov/rubocop/stargazers","contributors_url":"https://api.github.com/repos/bbatsov/rubocop/contributors","subscribers_url":"https://api.github.com/repos/bbatsov/rubocop/subscribers","subscription_url":"https://api.github.com/repos/bbatsov/rubocop/subscription","commits_url":"https://api.github.com/repos/bbatsov/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbatsov/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbatsov/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbatsov/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/bbatsov/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbatsov/rubocop/merges","archive_url":"https://api.github.com/repos/bbatsov/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbatsov/rubocop/downloads","issues_url":"https://api.github.com/repos/bbatsov/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/bbatsov/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/bbatsov/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/bbatsov/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbatsov/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/bbatsov/rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/bbatsov/rubocop/deployments","created_at":"2012-04-21T10:09:58Z","updated_at":"2016-05-31T21:21:52Z","pushed_at":"2016-05-31T21:17:17Z","git_url":"git://github.com/bbatsov/rubocop.git","ssh_url":"git@github.com:bbatsov/rubocop.git","clone_url":"https://github.com/bbatsov/rubocop.git","svn_url":"https://github.com/bbatsov/rubocop","homepage":"http://rubocop.readthedocs.io","size":15508,"stargazers_count":6344,"watchers_count":6344,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":862,"mirror_url":null,"open_issues_count":133,"forks":862,"open_issues":133,"watchers":6344,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/3186"},"html":{"href":"https://github.com/bbatsov/rubocop/pull/3186"},"issue":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/3186"},"comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/3186/comments"},"review_comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/3186/comments"},"review_comment":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/3186/commits"},"statuses":{"href":"https://api.github.com/repos/bbatsov/rubocop/statuses/eb003b1b6212dd29e48901f4211c28e54cab5a6a"}}}}
{"actor":{"display_login":"owst"}}