{"action":"created","issue":{"url":"https://api.github.com/repos/Financial-Times/next-front-page/issues/980","repository_url":"https://api.github.com/repos/Financial-Times/next-front-page","labels_url":"https://api.github.com/repos/Financial-Times/next-front-page/issues/980/labels{/name}","comments_url":"https://api.github.com/repos/Financial-Times/next-front-page/issues/980/comments","events_url":"https://api.github.com/repos/Financial-Times/next-front-page/issues/980/events","html_url":"https://github.com/Financial-Times/next-front-page/pull/980","id":171445694,"number":980,"title":"Dictate: Life & Arts layout + position by time of week","user":{"login":"andygout","id":10484515,"avatar_url":"https://avatars.githubusercontent.com/u/10484515?v=3","gravatar_id":"","url":"https://api.github.com/users/andygout","html_url":"https://github.com/andygout","followers_url":"https://api.github.com/users/andygout/followers","following_url":"https://api.github.com/users/andygout/following{/other_user}","gists_url":"https://api.github.com/users/andygout/gists{/gist_id}","starred_url":"https://api.github.com/users/andygout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andygout/subscriptions","organizations_url":"https://api.github.com/users/andygout/orgs","repos_url":"https://api.github.com/users/andygout/repos","events_url":"https://api.github.com/users/andygout/events{/privacy}","received_events_url":"https://api.github.com/users/andygout/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-16T15:32:27Z","updated_at":"2016-08-17T13:33:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Financial-Times/next-front-page/pulls/980","html_url":"https://github.com/Financial-Times/next-front-page/pull/980","diff_url":"https://github.com/Financial-Times/next-front-page/pull/980.diff","patch_url":"https://github.com/Financial-Times/next-front-page/pull/980.patch"},"body":"cc @andygnewman @ironsidevsquincy \r\n\r\nI have positioned the weekend version of the component above Most Popular purely to indicate that it will need to be in a different position to the mid-week version and that this logic needs to be done at this stage; the actual positions are still TBC.\r\n\r\nI seem to be duplicating files and wonder if better to: extract the code that decides if it is the weekend period and use in [`config/pages.js`](https://github.com/Financial-Times/next-front-page/blob/life-arts-component-time-dependent/config/pages.js#L92-L93) to decide the component's position and again in [`config/sections/index.js`](https://github.com/Financial-Times/next-front-page/blob/life-arts-component-time-dependent/config/sections/index.js#L41), giving that `isWeekendPeriod` value via an extra `opts` argument to dictate in a single [`life-and-arts` section file](https://github.com/Financial-Times/next-front-page/blob/life-arts-component-time-dependent/config/sections/life-and-arts-week.js#L5) which of the two `layoutId`s to apply (although it's possible that the two variants will eventually require differing section attributes and therefore separate files).\r\n\r\nOnce merged: \r\n- [ ] Change flag to on/off (currently has variants)."},"comment":{"url":"https://api.github.com/repos/Financial-Times/next-front-page/issues/comments/240412065","html_url":"https://github.com/Financial-Times/next-front-page/pull/980#issuecomment-240412065","issue_url":"https://api.github.com/repos/Financial-Times/next-front-page/issues/980","id":240412065,"user":{"login":"ironsidevsquincy","id":74132,"avatar_url":"https://avatars.githubusercontent.com/u/74132?v=3","gravatar_id":"","url":"https://api.github.com/users/ironsidevsquincy","html_url":"https://github.com/ironsidevsquincy","followers_url":"https://api.github.com/users/ironsidevsquincy/followers","following_url":"https://api.github.com/users/ironsidevsquincy/following{/other_user}","gists_url":"https://api.github.com/users/ironsidevsquincy/gists{/gist_id}","starred_url":"https://api.github.com/users/ironsidevsquincy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironsidevsquincy/subscriptions","organizations_url":"https://api.github.com/users/ironsidevsquincy/orgs","repos_url":"https://api.github.com/users/ironsidevsquincy/repos","events_url":"https://api.github.com/users/ironsidevsquincy/events{/privacy}","received_events_url":"https://api.github.com/users/ironsidevsquincy/received_events","type":"User","site_admin":false},"created_at":"2016-08-17T13:33:52Z","updated_at":"2016-08-17T13:33:52Z","body":"👍 "}}
{"actor":{"display_login":"ironsidevsquincy"}}