{"action":"closed","number":640,"pull_request":{"url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/pulls/640","id":55413063,"html_url":"https://github.com/lucadegasperi/oauth2-server-laravel/pull/640","diff_url":"https://github.com/lucadegasperi/oauth2-server-laravel/pull/640.diff","patch_url":"https://github.com/lucadegasperi/oauth2-server-laravel/pull/640.patch","issue_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/issues/640","number":640,"state":"closed","locked":false,"title":"Fix for lumen 5.2","user":{"login":"tralves","id":2600867,"avatar_url":"https://avatars.githubusercontent.com/u/2600867?v=3","gravatar_id":"","url":"https://api.github.com/users/tralves","html_url":"https://github.com/tralves","followers_url":"https://api.github.com/users/tralves/followers","following_url":"https://api.github.com/users/tralves/following{/other_user}","gists_url":"https://api.github.com/users/tralves/gists{/gist_id}","starred_url":"https://api.github.com/users/tralves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tralves/subscriptions","organizations_url":"https://api.github.com/users/tralves/orgs","repos_url":"https://api.github.com/users/tralves/repos","events_url":"https://api.github.com/users/tralves/events{/privacy}","received_events_url":"https://api.github.com/users/tralves/received_events","type":"User","site_admin":false},"body":"The problem is that in Lumen 5.2 (for some reason) ``Laravel\\Lumen\\Application`` no longer implements ``\\Illuminate\\Contracts\\Foundation\\Application``.\r\n\r\nThis causes the providers ``LucaDegasperi\\OAuth2Server\\OAuth2ServerServiceProvider`` and ``LucaDegasperi\\OAuth2Server\\Storage\\FluentStorageServiceProvider`` to fail, since they expect the ``$app`` to implement that contract.\r\n\r\nIn this PR the type hint ``$app`` var is removed from several functions in the providers and use ``$this->app`` instead, as that is the most common usage.","created_at":"2016-01-08T01:04:02Z","updated_at":"2016-01-13T12:59:28Z","closed_at":"2016-01-13T12:59:28Z","merged_at":null,"merge_commit_sha":"83dd3c0d01365b04659f08621fd7eb07d4820426","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/pulls/640/commits","review_comments_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/pulls/640/comments","review_comment_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/issues/640/comments","statuses_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/statuses/cc333acfb4508a280bde208da599ca91bbac43b7","head":{"label":"tralves:master","ref":"master","sha":"cc333acfb4508a280bde208da599ca91bbac43b7","user":{"login":"tralves","id":2600867,"avatar_url":"https://avatars.githubusercontent.com/u/2600867?v=3","gravatar_id":"","url":"https://api.github.com/users/tralves","html_url":"https://github.com/tralves","followers_url":"https://api.github.com/users/tralves/followers","following_url":"https://api.github.com/users/tralves/following{/other_user}","gists_url":"https://api.github.com/users/tralves/gists{/gist_id}","starred_url":"https://api.github.com/users/tralves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tralves/subscriptions","organizations_url":"https://api.github.com/users/tralves/orgs","repos_url":"https://api.github.com/users/tralves/repos","events_url":"https://api.github.com/users/tralves/events{/privacy}","received_events_url":"https://api.github.com/users/tralves/received_events","type":"User","site_admin":false},"repo":{"id":49238736,"name":"oauth2-server-laravel","full_name":"tralves/oauth2-server-laravel","owner":{"login":"tralves","id":2600867,"avatar_url":"https://avatars.githubusercontent.com/u/2600867?v=3","gravatar_id":"","url":"https://api.github.com/users/tralves","html_url":"https://github.com/tralves","followers_url":"https://api.github.com/users/tralves/followers","following_url":"https://api.github.com/users/tralves/following{/other_user}","gists_url":"https://api.github.com/users/tralves/gists{/gist_id}","starred_url":"https://api.github.com/users/tralves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tralves/subscriptions","organizations_url":"https://api.github.com/users/tralves/orgs","repos_url":"https://api.github.com/users/tralves/repos","events_url":"https://api.github.com/users/tralves/events{/privacy}","received_events_url":"https://api.github.com/users/tralves/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tralves/oauth2-server-laravel","description":"A OAuth 2.0 bridge for Laravel and Lumen https://packagist.org/packages/lucadegasperi/oauth2-server-laravel","fork":true,"url":"https://api.github.com/repos/tralves/oauth2-server-laravel","forks_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/forks","keys_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/teams","hooks_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/hooks","issue_events_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/issues/events{/number}","events_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/events","assignees_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/assignees{/user}","branches_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/branches{/branch}","tags_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/tags","blobs_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/git/refs{/sha}","trees_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/statuses/{sha}","languages_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/languages","stargazers_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/stargazers","contributors_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/contributors","subscribers_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/subscribers","subscription_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/subscription","commits_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/commits{/sha}","git_commits_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/git/commits{/sha}","comments_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/comments{/number}","issue_comment_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/issues/comments{/number}","contents_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/contents/{+path}","compare_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/merges","archive_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/downloads","issues_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/issues{/number}","pulls_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/pulls{/number}","milestones_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/milestones{/number}","notifications_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/labels{/name}","releases_url":"https://api.github.com/repos/tralves/oauth2-server-laravel/releases{/id}","created_at":"2016-01-08T00:11:05Z","updated_at":"2016-01-08T00:11:06Z","pushed_at":"2016-01-08T00:33:00Z","git_url":"git://github.com/tralves/oauth2-server-laravel.git","ssh_url":"git@github.com:tralves/oauth2-server-laravel.git","clone_url":"https://github.com/tralves/oauth2-server-laravel.git","svn_url":"https://github.com/tralves/oauth2-server-laravel","homepage":"","size":657,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lucadegasperi:master","ref":"master","sha":"eed8a11212ace359637f07a614a40be5f36a35ba","user":{"login":"lucadegasperi","id":820687,"avatar_url":"https://avatars.githubusercontent.com/u/820687?v=3","gravatar_id":"","url":"https://api.github.com/users/lucadegasperi","html_url":"https://github.com/lucadegasperi","followers_url":"https://api.github.com/users/lucadegasperi/followers","following_url":"https://api.github.com/users/lucadegasperi/following{/other_user}","gists_url":"https://api.github.com/users/lucadegasperi/gists{/gist_id}","starred_url":"https://api.github.com/users/lucadegasperi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucadegasperi/subscriptions","organizations_url":"https://api.github.com/users/lucadegasperi/orgs","repos_url":"https://api.github.com/users/lucadegasperi/repos","events_url":"https://api.github.com/users/lucadegasperi/events{/privacy}","received_events_url":"https://api.github.com/users/lucadegasperi/received_events","type":"User","site_admin":false},"repo":{"id":13300645,"name":"oauth2-server-laravel","full_name":"lucadegasperi/oauth2-server-laravel","owner":{"login":"lucadegasperi","id":820687,"avatar_url":"https://avatars.githubusercontent.com/u/820687?v=3","gravatar_id":"","url":"https://api.github.com/users/lucadegasperi","html_url":"https://github.com/lucadegasperi","followers_url":"https://api.github.com/users/lucadegasperi/followers","following_url":"https://api.github.com/users/lucadegasperi/following{/other_user}","gists_url":"https://api.github.com/users/lucadegasperi/gists{/gist_id}","starred_url":"https://api.github.com/users/lucadegasperi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucadegasperi/subscriptions","organizations_url":"https://api.github.com/users/lucadegasperi/orgs","repos_url":"https://api.github.com/users/lucadegasperi/repos","events_url":"https://api.github.com/users/lucadegasperi/events{/privacy}","received_events_url":"https://api.github.com/users/lucadegasperi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lucadegasperi/oauth2-server-laravel","description":"An OAuth 2.0 bridge for Laravel and Lumen https://packagist.org/packages/lucadegasperi/oauth2-server-laravel","fork":false,"url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel","forks_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/forks","keys_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/teams","hooks_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/hooks","issue_events_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/issues/events{/number}","events_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/events","assignees_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/assignees{/user}","branches_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/branches{/branch}","tags_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/tags","blobs_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/statuses/{sha}","languages_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/languages","stargazers_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/stargazers","contributors_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/contributors","subscribers_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/subscribers","subscription_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/subscription","commits_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/contents/{+path}","compare_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/merges","archive_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/downloads","issues_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/issues{/number}","pulls_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/pulls{/number}","milestones_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/milestones{/number}","notifications_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/labels{/name}","releases_url":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/releases{/id}","created_at":"2013-10-03T14:35:38Z","updated_at":"2016-01-13T12:59:14Z","pushed_at":"2016-01-13T12:58:54Z","git_url":"git://github.com/lucadegasperi/oauth2-server-laravel.git","ssh_url":"git@github.com:lucadegasperi/oauth2-server-laravel.git","clone_url":"https://github.com/lucadegasperi/oauth2-server-laravel.git","svn_url":"https://github.com/lucadegasperi/oauth2-server-laravel","homepage":"","size":1088,"stargazers_count":1543,"watchers_count":1543,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":349,"mirror_url":null,"open_issues_count":10,"forks":349,"open_issues":10,"watchers":1543,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/pulls/640"},"html":{"href":"https://github.com/lucadegasperi/oauth2-server-laravel/pull/640"},"issue":{"href":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/issues/640"},"comments":{"href":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/issues/640/comments"},"review_comments":{"href":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/pulls/640/comments"},"review_comment":{"href":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/pulls/640/commits"},"statuses":{"href":"https://api.github.com/repos/lucadegasperi/oauth2-server-laravel/statuses/cc333acfb4508a280bde208da599ca91bbac43b7"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":7,"review_comments":0,"commits":1,"additions":39,"deletions":53,"changed_files":2}}