{"action":"created","comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/56310259","id":56310259,"diff_hunk":"@@ -146,21 +174,53 @@ solve(Vector &x)\n \n         // std::cout << \"  J:\\n\" << Eigen::MatrixXd(J) << std::endl;\n \n-        if (!_linear_solver.solve(J, res, minus_delta_x)) {\n+        bool iteration_succeeded = _linear_solver.solve(J, res, minus_delta_x);\n+\n+        if (!iteration_succeeded)\n+        {\n             ERR(\"The linear solver failed.\");\n-            BLAS::axpy(x, -_alpha, minus_delta_x);\n-            success = false;\n+        }\n+        else\n+        {\n+            // TODO could be solved in a better way","path":"NumLib/ODESolver/NonlinearSolver-impl.h","position":127,"original_position":127,"commit_id":"a1fe7a9619572322d8585d3efdf89923f8be131f","original_commit_id":"a1fe7a9619572322d8585d3efdf89923f8be131f","user":{"login":"chleh","id":10530151,"avatar_url":"https://avatars.githubusercontent.com/u/10530151?v=3","gravatar_id":"","url":"https://api.github.com/users/chleh","html_url":"https://github.com/chleh","followers_url":"https://api.github.com/users/chleh/followers","following_url":"https://api.github.com/users/chleh/following{/other_user}","gists_url":"https://api.github.com/users/chleh/gists{/gist_id}","starred_url":"https://api.github.com/users/chleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chleh/subscriptions","organizations_url":"https://api.github.com/users/chleh/orgs","repos_url":"https://api.github.com/users/chleh/repos","events_url":"https://api.github.com/users/chleh/events{/privacy}","received_events_url":"https://api.github.com/users/chleh/received_events","type":"User","site_admin":false},"body":"I suggest to change all TODO tags to \\todo in a separate PR, and then all at once for all of OGS6, if that's important.","created_at":"2016-03-16T10:22:41Z","updated_at":"2016-03-16T10:22:41Z","html_url":"https://github.com/ufz/ogs/pull/1100#discussion_r56310259","pull_request_url":"https://api.github.com/repos/ufz/ogs/pulls/1100","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/56310259"},"html":{"href":"https://github.com/ufz/ogs/pull/1100#discussion_r56310259"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1100"}}},"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/1100","id":62923635,"html_url":"https://github.com/ufz/ogs/pull/1100","diff_url":"https://github.com/ufz/ogs/pull/1100.diff","patch_url":"https://github.com/ufz/ogs/pull/1100.patch","issue_url":"https://api.github.com/repos/ufz/ogs/issues/1100","number":1100,"state":"open","locked":false,"title":"ODESolver: Added pre and post iteration hooks","user":{"login":"chleh","id":10530151,"avatar_url":"https://avatars.githubusercontent.com/u/10530151?v=3","gravatar_id":"","url":"https://api.github.com/users/chleh","html_url":"https://github.com/chleh","followers_url":"https://api.github.com/users/chleh/followers","following_url":"https://api.github.com/users/chleh/following{/other_user}","gists_url":"https://api.github.com/users/chleh/gists{/gist_id}","starred_url":"https://api.github.com/users/chleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chleh/subscriptions","organizations_url":"https://api.github.com/users/chleh/orgs","repos_url":"https://api.github.com/users/chleh/repos","events_url":"https://api.github.com/users/chleh/events{/privacy}","received_events_url":"https://api.github.com/users/chleh/received_events","type":"User","site_admin":false},"body":"Said hooks are called before and after each iteration of the nonlinear solver.\r\n\r\nI need that functionality for TES in order to be able to drop some nonsensible iteration results.","created_at":"2016-03-15T15:23:38Z","updated_at":"2016-03-16T10:22:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53b49763dcc016c1435501f6c4d2751fbc759250","assignee":null,"milestone":{"url":"https://api.github.com/repos/ufz/ogs/milestones/15","html_url":"https://github.com/ufz/ogs/milestones/TES%20Process","labels_url":"https://api.github.com/repos/ufz/ogs/milestones/15/labels","id":1459510,"number":15,"title":"TES Process","description":"","creator":{"login":"chleh","id":10530151,"avatar_url":"https://avatars.githubusercontent.com/u/10530151?v=3","gravatar_id":"","url":"https://api.github.com/users/chleh","html_url":"https://github.com/chleh","followers_url":"https://api.github.com/users/chleh/followers","following_url":"https://api.github.com/users/chleh/following{/other_user}","gists_url":"https://api.github.com/users/chleh/gists{/gist_id}","starred_url":"https://api.github.com/users/chleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chleh/subscriptions","organizations_url":"https://api.github.com/users/chleh/orgs","repos_url":"https://api.github.com/users/chleh/repos","events_url":"https://api.github.com/users/chleh/events{/privacy}","received_events_url":"https://api.github.com/users/chleh/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":11,"state":"open","created_at":"2015-12-14T15:47:32Z","updated_at":"2016-03-16T08:28:42Z","due_on":"2016-03-30T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ufz/ogs/pulls/1100/commits","review_comments_url":"https://api.github.com/repos/ufz/ogs/pulls/1100/comments","review_comment_url":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/1100/comments","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/a1fe7a9619572322d8585d3efdf89923f8be131f","head":{"label":"chleh:pre-post-iter","ref":"pre-post-iter","sha":"a1fe7a9619572322d8585d3efdf89923f8be131f","user":{"login":"chleh","id":10530151,"avatar_url":"https://avatars.githubusercontent.com/u/10530151?v=3","gravatar_id":"","url":"https://api.github.com/users/chleh","html_url":"https://github.com/chleh","followers_url":"https://api.github.com/users/chleh/followers","following_url":"https://api.github.com/users/chleh/following{/other_user}","gists_url":"https://api.github.com/users/chleh/gists{/gist_id}","starred_url":"https://api.github.com/users/chleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chleh/subscriptions","organizations_url":"https://api.github.com/users/chleh/orgs","repos_url":"https://api.github.com/users/chleh/repos","events_url":"https://api.github.com/users/chleh/events{/privacy}","received_events_url":"https://api.github.com/users/chleh/received_events","type":"User","site_admin":false},"repo":{"id":40347084,"name":"ogs6","full_name":"chleh/ogs6","owner":{"login":"chleh","id":10530151,"avatar_url":"https://avatars.githubusercontent.com/u/10530151?v=3","gravatar_id":"","url":"https://api.github.com/users/chleh","html_url":"https://github.com/chleh","followers_url":"https://api.github.com/users/chleh/followers","following_url":"https://api.github.com/users/chleh/following{/other_user}","gists_url":"https://api.github.com/users/chleh/gists{/gist_id}","starred_url":"https://api.github.com/users/chleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chleh/subscriptions","organizations_url":"https://api.github.com/users/chleh/orgs","repos_url":"https://api.github.com/users/chleh/repos","events_url":"https://api.github.com/users/chleh/events{/privacy}","received_events_url":"https://api.github.com/users/chleh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chleh/ogs6","description":"Experimental OGS-6 source code","fork":true,"url":"https://api.github.com/repos/chleh/ogs6","forks_url":"https://api.github.com/repos/chleh/ogs6/forks","keys_url":"https://api.github.com/repos/chleh/ogs6/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chleh/ogs6/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chleh/ogs6/teams","hooks_url":"https://api.github.com/repos/chleh/ogs6/hooks","issue_events_url":"https://api.github.com/repos/chleh/ogs6/issues/events{/number}","events_url":"https://api.github.com/repos/chleh/ogs6/events","assignees_url":"https://api.github.com/repos/chleh/ogs6/assignees{/user}","branches_url":"https://api.github.com/repos/chleh/ogs6/branches{/branch}","tags_url":"https://api.github.com/repos/chleh/ogs6/tags","blobs_url":"https://api.github.com/repos/chleh/ogs6/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chleh/ogs6/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chleh/ogs6/git/refs{/sha}","trees_url":"https://api.github.com/repos/chleh/ogs6/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chleh/ogs6/statuses/{sha}","languages_url":"https://api.github.com/repos/chleh/ogs6/languages","stargazers_url":"https://api.github.com/repos/chleh/ogs6/stargazers","contributors_url":"https://api.github.com/repos/chleh/ogs6/contributors","subscribers_url":"https://api.github.com/repos/chleh/ogs6/subscribers","subscription_url":"https://api.github.com/repos/chleh/ogs6/subscription","commits_url":"https://api.github.com/repos/chleh/ogs6/commits{/sha}","git_commits_url":"https://api.github.com/repos/chleh/ogs6/git/commits{/sha}","comments_url":"https://api.github.com/repos/chleh/ogs6/comments{/number}","issue_comment_url":"https://api.github.com/repos/chleh/ogs6/issues/comments{/number}","contents_url":"https://api.github.com/repos/chleh/ogs6/contents/{+path}","compare_url":"https://api.github.com/repos/chleh/ogs6/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chleh/ogs6/merges","archive_url":"https://api.github.com/repos/chleh/ogs6/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chleh/ogs6/downloads","issues_url":"https://api.github.com/repos/chleh/ogs6/issues{/number}","pulls_url":"https://api.github.com/repos/chleh/ogs6/pulls{/number}","milestones_url":"https://api.github.com/repos/chleh/ogs6/milestones{/number}","notifications_url":"https://api.github.com/repos/chleh/ogs6/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chleh/ogs6/labels{/name}","releases_url":"https://api.github.com/repos/chleh/ogs6/releases{/id}","deployments_url":"https://api.github.com/repos/chleh/ogs6/deployments","created_at":"2015-08-07T07:24:24Z","updated_at":"2016-01-14T16:07:04Z","pushed_at":"2016-03-16T08:28:45Z","git_url":"git://github.com/chleh/ogs6.git","ssh_url":"git@github.com:chleh/ogs6.git","clone_url":"https://github.com/chleh/ogs6.git","svn_url":"https://github.com/chleh/ogs6","homepage":"www.opengeosys.org","size":12466,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ufz:master","ref":"master","sha":"48dd5f75da9bd85b9c050db2666902d9d764ac38","user":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"repo":{"id":1701384,"name":"ogs","full_name":"ufz/ogs","owner":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufz/ogs","description":"Experimental OGS-6 source code","fork":false,"url":"https://api.github.com/repos/ufz/ogs","forks_url":"https://api.github.com/repos/ufz/ogs/forks","keys_url":"https://api.github.com/repos/ufz/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufz/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufz/ogs/teams","hooks_url":"https://api.github.com/repos/ufz/ogs/hooks","issue_events_url":"https://api.github.com/repos/ufz/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/ufz/ogs/events","assignees_url":"https://api.github.com/repos/ufz/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/ufz/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/ufz/ogs/tags","blobs_url":"https://api.github.com/repos/ufz/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufz/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufz/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufz/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ufz/ogs/languages","stargazers_url":"https://api.github.com/repos/ufz/ogs/stargazers","contributors_url":"https://api.github.com/repos/ufz/ogs/contributors","subscribers_url":"https://api.github.com/repos/ufz/ogs/subscribers","subscription_url":"https://api.github.com/repos/ufz/ogs/subscription","commits_url":"https://api.github.com/repos/ufz/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufz/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufz/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufz/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufz/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/ufz/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufz/ogs/merges","archive_url":"https://api.github.com/repos/ufz/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufz/ogs/downloads","issues_url":"https://api.github.com/repos/ufz/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/ufz/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ufz/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ufz/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufz/ogs/labels{/name}","releases_url":"https://api.github.com/repos/ufz/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/ufz/ogs/deployments","created_at":"2011-05-04T14:09:57Z","updated_at":"2015-10-23T03:43:52Z","pushed_at":"2016-03-16T08:58:23Z","git_url":"git://github.com/ufz/ogs.git","ssh_url":"git@github.com:ufz/ogs.git","clone_url":"https://github.com/ufz/ogs.git","svn_url":"https://github.com/ufz/ogs","homepage":"www.opengeosys.org","size":13117,"stargazers_count":18,"watchers_count":18,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":99,"forks":41,"open_issues":99,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1100"},"html":{"href":"https://github.com/ufz/ogs/pull/1100"},"issue":{"href":"https://api.github.com/repos/ufz/ogs/issues/1100"},"comments":{"href":"https://api.github.com/repos/ufz/ogs/issues/1100/comments"},"review_comments":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1100/comments"},"review_comment":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1100/commits"},"statuses":{"href":"https://api.github.com/repos/ufz/ogs/statuses/a1fe7a9619572322d8585d3efdf89923f8be131f"}}}}