{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/59447998","id":59447998,"diff_hunk":"@@ -92,13 +93,7 @@ public int IndexOf(string fieldName)\n                 GenerateLookup();\n             }\n             int index;\n-            object value = _fieldNameLookup[fieldName];\n-            if (null != value)\n-            {\n-                // via case sensitive search, first match with lowest ordinal matches\n-                index = (int)value;\n-            }\n-            else\n+            if(!_fieldNameLookup.TryGetValue(fieldName, out index))","path":"src/Common/src/System/Data/Common/FieldNameLookup.cs","position":43,"original_position":43,"commit_id":"f430fcb8086070a8e6da74bf3210323257d78c5c","original_commit_id":"f430fcb8086070a8e6da74bf3210323257d78c5c","user":{"login":"justinvp","id":710598,"avatar_url":"https://avatars.githubusercontent.com/u/710598?v=3","gravatar_id":"","url":"https://api.github.com/users/justinvp","html_url":"https://github.com/justinvp","followers_url":"https://api.github.com/users/justinvp/followers","following_url":"https://api.github.com/users/justinvp/following{/other_user}","gists_url":"https://api.github.com/users/justinvp/gists{/gist_id}","starred_url":"https://api.github.com/users/justinvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinvp/subscriptions","organizations_url":"https://api.github.com/users/justinvp/orgs","repos_url":"https://api.github.com/users/justinvp/repos","events_url":"https://api.github.com/users/justinvp/events{/privacy}","received_events_url":"https://api.github.com/users/justinvp/received_events","type":"User","site_admin":false},"body":"Nit: there should be a space between `if` and the `(`","created_at":"2016-04-12T20:31:45Z","updated_at":"2016-04-12T20:31:45Z","html_url":"https://github.com/dotnet/corefx/pull/7686#discussion_r59447998","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/7686","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/59447998"},"html":{"href":"https://github.com/dotnet/corefx/pull/7686#discussion_r59447998"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7686"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/7686","id":66217578,"html_url":"https://github.com/dotnet/corefx/pull/7686","diff_url":"https://github.com/dotnet/corefx/pull/7686.diff","patch_url":"https://github.com/dotnet/corefx/pull/7686.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/7686","number":7686,"state":"open","locked":false,"title":"Moving System.Data code which needs to be consumed by Common and SqlClient to Common","user":{"login":"saurabh500","id":1623701,"avatar_url":"https://avatars.githubusercontent.com/u/1623701?v=3","gravatar_id":"","url":"https://api.github.com/users/saurabh500","html_url":"https://github.com/saurabh500","followers_url":"https://api.github.com/users/saurabh500/followers","following_url":"https://api.github.com/users/saurabh500/following{/other_user}","gists_url":"https://api.github.com/users/saurabh500/gists{/gist_id}","starred_url":"https://api.github.com/users/saurabh500/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saurabh500/subscriptions","organizations_url":"https://api.github.com/users/saurabh500/orgs","repos_url":"https://api.github.com/users/saurabh500/repos","events_url":"https://api.github.com/users/saurabh500/events{/privacy}","received_events_url":"https://api.github.com/users/saurabh500/received_events","type":"User","site_admin":false},"body":"The following changes are included. \r\n\r\n1. Moved the FieldNameLookup and Locale related functionality to the Common/src/System/Data \r\n2. Modified the System.Data.SqlClient.csproj to reference the correct files.\r\n3. Changed the FieldNameLookup to use Dictionary instead of Hashtable.\r\n\r\nThe moved classes need to be consumed by System.Data.Common and System.Data.SqlClient. \r\n\r\nThis PR will support the changes which move DbEnumerator to the System.Data.Common and exposes it in the Contracts.","created_at":"2016-04-12T19:55:08Z","updated_at":"2016-04-12T20:31:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d1abeae48dbb62960c3699ae6ed3dee8af4df81","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/7686/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/7686/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/7686/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/f430fcb8086070a8e6da74bf3210323257d78c5c","head":{"label":"saurabh500:movetocommon","ref":"movetocommon","sha":"f430fcb8086070a8e6da74bf3210323257d78c5c","user":{"login":"saurabh500","id":1623701,"avatar_url":"https://avatars.githubusercontent.com/u/1623701?v=3","gravatar_id":"","url":"https://api.github.com/users/saurabh500","html_url":"https://github.com/saurabh500","followers_url":"https://api.github.com/users/saurabh500/followers","following_url":"https://api.github.com/users/saurabh500/following{/other_user}","gists_url":"https://api.github.com/users/saurabh500/gists{/gist_id}","starred_url":"https://api.github.com/users/saurabh500/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saurabh500/subscriptions","organizations_url":"https://api.github.com/users/saurabh500/orgs","repos_url":"https://api.github.com/users/saurabh500/repos","events_url":"https://api.github.com/users/saurabh500/events{/privacy}","received_events_url":"https://api.github.com/users/saurabh500/received_events","type":"User","site_admin":false},"repo":{"id":41459213,"name":"corefx","full_name":"saurabh500/corefx","owner":{"login":"saurabh500","id":1623701,"avatar_url":"https://avatars.githubusercontent.com/u/1623701?v=3","gravatar_id":"","url":"https://api.github.com/users/saurabh500","html_url":"https://github.com/saurabh500","followers_url":"https://api.github.com/users/saurabh500/followers","following_url":"https://api.github.com/users/saurabh500/following{/other_user}","gists_url":"https://api.github.com/users/saurabh500/gists{/gist_id}","starred_url":"https://api.github.com/users/saurabh500/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saurabh500/subscriptions","organizations_url":"https://api.github.com/users/saurabh500/orgs","repos_url":"https://api.github.com/users/saurabh500/repos","events_url":"https://api.github.com/users/saurabh500/events{/privacy}","received_events_url":"https://api.github.com/users/saurabh500/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saurabh500/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/saurabh500/corefx","forks_url":"https://api.github.com/repos/saurabh500/corefx/forks","keys_url":"https://api.github.com/repos/saurabh500/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saurabh500/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saurabh500/corefx/teams","hooks_url":"https://api.github.com/repos/saurabh500/corefx/hooks","issue_events_url":"https://api.github.com/repos/saurabh500/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/saurabh500/corefx/events","assignees_url":"https://api.github.com/repos/saurabh500/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/saurabh500/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/saurabh500/corefx/tags","blobs_url":"https://api.github.com/repos/saurabh500/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saurabh500/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saurabh500/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/saurabh500/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saurabh500/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/saurabh500/corefx/languages","stargazers_url":"https://api.github.com/repos/saurabh500/corefx/stargazers","contributors_url":"https://api.github.com/repos/saurabh500/corefx/contributors","subscribers_url":"https://api.github.com/repos/saurabh500/corefx/subscribers","subscription_url":"https://api.github.com/repos/saurabh500/corefx/subscription","commits_url":"https://api.github.com/repos/saurabh500/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/saurabh500/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/saurabh500/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/saurabh500/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/saurabh500/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/saurabh500/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saurabh500/corefx/merges","archive_url":"https://api.github.com/repos/saurabh500/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saurabh500/corefx/downloads","issues_url":"https://api.github.com/repos/saurabh500/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/saurabh500/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/saurabh500/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/saurabh500/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saurabh500/corefx/labels{/name}","releases_url":"https://api.github.com/repos/saurabh500/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/saurabh500/corefx/deployments","created_at":"2015-08-27T01:41:34Z","updated_at":"2016-01-14T01:51:49Z","pushed_at":"2016-04-12T19:57:29Z","git_url":"git://github.com/saurabh500/corefx.git","ssh_url":"git@github.com:saurabh500/corefx.git","clone_url":"https://github.com/saurabh500/corefx.git","svn_url":"https://github.com/saurabh500/corefx","homepage":"http://dotnet.github.io/core/","size":63506,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"41bf0cdde549f5b5b1ff466116c5c81228e57b5a","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-04-12T20:28:58Z","pushed_at":"2016-04-12T20:18:05Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":86417,"stargazers_count":9486,"watchers_count":9486,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2242,"mirror_url":null,"open_issues_count":948,"forks":2242,"open_issues":948,"watchers":9486,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7686"},"html":{"href":"https://github.com/dotnet/corefx/pull/7686"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/7686"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/7686/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7686/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7686/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/f430fcb8086070a8e6da74bf3210323257d78c5c"}}}}