{"action":"closed","number":623,"pull_request":{"url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/623","id":20563035,"html_url":"https://github.com/rails-api/active_model_serializers/pull/623","diff_url":"https://github.com/rails-api/active_model_serializers/pull/623.diff","patch_url":"https://github.com/rails-api/active_model_serializers/pull/623.patch","issue_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/623","number":623,"state":"closed","locked":false,"title":"Allow ArraySerializer to inherit :each_serializer root","user":{"login":"gauthier-delacroix","id":1533042,"avatar_url":"https://avatars.githubusercontent.com/u/1533042?v=3","gravatar_id":"","url":"https://api.github.com/users/gauthier-delacroix","html_url":"https://github.com/gauthier-delacroix","followers_url":"https://api.github.com/users/gauthier-delacroix/followers","following_url":"https://api.github.com/users/gauthier-delacroix/following{/other_user}","gists_url":"https://api.github.com/users/gauthier-delacroix/gists{/gist_id}","starred_url":"https://api.github.com/users/gauthier-delacroix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauthier-delacroix/subscriptions","organizations_url":"https://api.github.com/users/gauthier-delacroix/orgs","repos_url":"https://api.github.com/users/gauthier-delacroix/repos","events_url":"https://api.github.com/users/gauthier-delacroix/events{/privacy}","received_events_url":"https://api.github.com/users/gauthier-delacroix/received_events","type":"User","site_admin":false},"body":"**This PR replaces #619 as there was too many conflicts after multiple rebases.**\r\n\r\nThis change make ArraySerializer inherit `each_serializer`'s root when no specific root is set.\r\n\r\nI'ts just a way to avoid definig root twice and keep things DRY.\r\n\r\nJSON API now requires the same (plural) root for single resource and collections.","created_at":"2014-09-01T09:45:28Z","updated_at":"2016-03-17T18:10:28Z","closed_at":"2016-03-17T18:10:28Z","merged_at":null,"merge_commit_sha":"f6b3ae9577558c30b207062cf0b36e5664a57632","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/623/commits","review_comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/623/comments","review_comment_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/623/comments","statuses_url":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/b42d2caffd739f0bf015c309d40a29f3bf99419b","head":{"label":"gauthier-delacroix:ArraySerializer_root_inheritance","ref":"ArraySerializer_root_inheritance","sha":"b42d2caffd739f0bf015c309d40a29f3bf99419b","user":{"login":"gauthier-delacroix","id":1533042,"avatar_url":"https://avatars.githubusercontent.com/u/1533042?v=3","gravatar_id":"","url":"https://api.github.com/users/gauthier-delacroix","html_url":"https://github.com/gauthier-delacroix","followers_url":"https://api.github.com/users/gauthier-delacroix/followers","following_url":"https://api.github.com/users/gauthier-delacroix/following{/other_user}","gists_url":"https://api.github.com/users/gauthier-delacroix/gists{/gist_id}","starred_url":"https://api.github.com/users/gauthier-delacroix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauthier-delacroix/subscriptions","organizations_url":"https://api.github.com/users/gauthier-delacroix/orgs","repos_url":"https://api.github.com/users/gauthier-delacroix/repos","events_url":"https://api.github.com/users/gauthier-delacroix/events{/privacy}","received_events_url":"https://api.github.com/users/gauthier-delacroix/received_events","type":"User","site_admin":false},"repo":{"id":23356213,"name":"active_model_serializers","full_name":"gauthier-delacroix/active_model_serializers","owner":{"login":"gauthier-delacroix","id":1533042,"avatar_url":"https://avatars.githubusercontent.com/u/1533042?v=3","gravatar_id":"","url":"https://api.github.com/users/gauthier-delacroix","html_url":"https://github.com/gauthier-delacroix","followers_url":"https://api.github.com/users/gauthier-delacroix/followers","following_url":"https://api.github.com/users/gauthier-delacroix/following{/other_user}","gists_url":"https://api.github.com/users/gauthier-delacroix/gists{/gist_id}","starred_url":"https://api.github.com/users/gauthier-delacroix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauthier-delacroix/subscriptions","organizations_url":"https://api.github.com/users/gauthier-delacroix/orgs","repos_url":"https://api.github.com/users/gauthier-delacroix/repos","events_url":"https://api.github.com/users/gauthier-delacroix/events{/privacy}","received_events_url":"https://api.github.com/users/gauthier-delacroix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gauthier-delacroix/active_model_serializers","description":"ActiveModel::Serializer implementation and Rails hooks","fork":true,"url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers","forks_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/forks","keys_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/teams","hooks_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/hooks","issue_events_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/issues/events{/number}","events_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/events","assignees_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/assignees{/user}","branches_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/branches{/branch}","tags_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/tags","blobs_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/git/refs{/sha}","trees_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/statuses/{sha}","languages_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/languages","stargazers_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/stargazers","contributors_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/contributors","subscribers_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/subscribers","subscription_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/subscription","commits_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/commits{/sha}","git_commits_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/git/commits{/sha}","comments_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/comments{/number}","issue_comment_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/issues/comments{/number}","contents_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/contents/{+path}","compare_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/merges","archive_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/downloads","issues_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/issues{/number}","pulls_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/pulls{/number}","milestones_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/milestones{/number}","notifications_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/labels{/name}","releases_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/releases{/id}","deployments_url":"https://api.github.com/repos/gauthier-delacroix/active_model_serializers/deployments","created_at":"2014-08-26T15:13:25Z","updated_at":"2014-08-25T19:53:43Z","pushed_at":"2014-12-08T12:57:10Z","git_url":"git://github.com/gauthier-delacroix/active_model_serializers.git","ssh_url":"git@github.com:gauthier-delacroix/active_model_serializers.git","clone_url":"https://github.com/gauthier-delacroix/active_model_serializers.git","svn_url":"https://github.com/gauthier-delacroix/active_model_serializers","homepage":"","size":1139,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails-api:0-9-stable","ref":"0-9-stable","sha":"f1c3268a543e00ad8689b36984f43ad0ea8fae8f","user":{"login":"rails-api","id":2820360,"avatar_url":"https://avatars.githubusercontent.com/u/2820360?v=3","gravatar_id":"","url":"https://api.github.com/users/rails-api","html_url":"https://github.com/rails-api","followers_url":"https://api.github.com/users/rails-api/followers","following_url":"https://api.github.com/users/rails-api/following{/other_user}","gists_url":"https://api.github.com/users/rails-api/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-api/subscriptions","organizations_url":"https://api.github.com/users/rails-api/orgs","repos_url":"https://api.github.com/users/rails-api/repos","events_url":"https://api.github.com/users/rails-api/events{/privacy}","received_events_url":"https://api.github.com/users/rails-api/received_events","type":"Organization","site_admin":false},"repo":{"id":2889230,"name":"active_model_serializers","full_name":"rails-api/active_model_serializers","owner":{"login":"rails-api","id":2820360,"avatar_url":"https://avatars.githubusercontent.com/u/2820360?v=3","gravatar_id":"","url":"https://api.github.com/users/rails-api","html_url":"https://github.com/rails-api","followers_url":"https://api.github.com/users/rails-api/followers","following_url":"https://api.github.com/users/rails-api/following{/other_user}","gists_url":"https://api.github.com/users/rails-api/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-api/subscriptions","organizations_url":"https://api.github.com/users/rails-api/orgs","repos_url":"https://api.github.com/users/rails-api/repos","events_url":"https://api.github.com/users/rails-api/events{/privacy}","received_events_url":"https://api.github.com/users/rails-api/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails-api/active_model_serializers","description":"ActiveModel::Serializer implementation and Rails hooks","fork":false,"url":"https://api.github.com/repos/rails-api/active_model_serializers","forks_url":"https://api.github.com/repos/rails-api/active_model_serializers/forks","keys_url":"https://api.github.com/repos/rails-api/active_model_serializers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails-api/active_model_serializers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails-api/active_model_serializers/teams","hooks_url":"https://api.github.com/repos/rails-api/active_model_serializers/hooks","issue_events_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/events{/number}","events_url":"https://api.github.com/repos/rails-api/active_model_serializers/events","assignees_url":"https://api.github.com/repos/rails-api/active_model_serializers/assignees{/user}","branches_url":"https://api.github.com/repos/rails-api/active_model_serializers/branches{/branch}","tags_url":"https://api.github.com/repos/rails-api/active_model_serializers/tags","blobs_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/{sha}","languages_url":"https://api.github.com/repos/rails-api/active_model_serializers/languages","stargazers_url":"https://api.github.com/repos/rails-api/active_model_serializers/stargazers","contributors_url":"https://api.github.com/repos/rails-api/active_model_serializers/contributors","subscribers_url":"https://api.github.com/repos/rails-api/active_model_serializers/subscribers","subscription_url":"https://api.github.com/repos/rails-api/active_model_serializers/subscription","commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails-api/active_model_serializers/contents/{+path}","compare_url":"https://api.github.com/repos/rails-api/active_model_serializers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails-api/active_model_serializers/merges","archive_url":"https://api.github.com/repos/rails-api/active_model_serializers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails-api/active_model_serializers/downloads","issues_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues{/number}","pulls_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls{/number}","milestones_url":"https://api.github.com/repos/rails-api/active_model_serializers/milestones{/number}","notifications_url":"https://api.github.com/repos/rails-api/active_model_serializers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails-api/active_model_serializers/labels{/name}","releases_url":"https://api.github.com/repos/rails-api/active_model_serializers/releases{/id}","deployments_url":"https://api.github.com/repos/rails-api/active_model_serializers/deployments","created_at":"2011-12-01T06:39:26Z","updated_at":"2016-03-17T16:57:16Z","pushed_at":"2016-03-17T16:54:33Z","git_url":"git://github.com/rails-api/active_model_serializers.git","ssh_url":"git@github.com:rails-api/active_model_serializers.git","clone_url":"https://github.com/rails-api/active_model_serializers.git","svn_url":"https://github.com/rails-api/active_model_serializers","homepage":"","size":4188,"stargazers_count":3382,"watchers_count":3382,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":839,"mirror_url":null,"open_issues_count":106,"forks":839,"open_issues":106,"watchers":3382,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/623"},"html":{"href":"https://github.com/rails-api/active_model_serializers/pull/623"},"issue":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/issues/623"},"comments":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/issues/623/comments"},"review_comments":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/623/comments"},"review_comment":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/623/commits"},"statuses":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/b42d2caffd739f0bf015c309d40a29f3bf99419b"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":9,"review_comments":2,"commits":1,"additions":26,"deletions":1,"changed_files":3}}