{"action":"created","comment":{"url":"https://api.github.com/repos/convox/rack/pulls/comments/67379553","id":67379553,"diff_hunk":"@@ -21,7 +22,21 @@ import (\n func BuildList(rw http.ResponseWriter, r *http.Request) *httperr.Error {\n \tapp := mux.Vars(r)[\"app\"]\n \n-\tbuilds, err := provider.BuildList(app)\n+\tl := r.URL.Query().Get(\"limit\")\n+\n+\tvar err error\n+\tvar limit int\n+\n+\tif l == \"\" {","path":"api/controllers/builds.go","position":18,"original_position":18,"commit_id":"e07fd026d444ca32b178a2e782b3f4cce0cfc660","original_commit_id":"e07fd026d444ca32b178a2e782b3f4cce0cfc660","user":{"login":"nzoschke","id":147410,"avatar_url":"https://avatars.githubusercontent.com/u/147410?v=3","gravatar_id":"","url":"https://api.github.com/users/nzoschke","html_url":"https://github.com/nzoschke","followers_url":"https://api.github.com/users/nzoschke/followers","following_url":"https://api.github.com/users/nzoschke/following{/other_user}","gists_url":"https://api.github.com/users/nzoschke/gists{/gist_id}","starred_url":"https://api.github.com/users/nzoschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzoschke/subscriptions","organizations_url":"https://api.github.com/users/nzoschke/orgs","repos_url":"https://api.github.com/users/nzoschke/repos","events_url":"https://api.github.com/users/nzoschke/events{/privacy}","received_events_url":"https://api.github.com/users/nzoschke/received_events","type":"User","site_admin":false},"body":"This API change looks good to me for backwards compatibility.","created_at":"2016-06-16T16:36:06Z","updated_at":"2016-06-16T16:36:06Z","html_url":"https://github.com/convox/rack/pull/773#discussion_r67379553","pull_request_url":"https://api.github.com/repos/convox/rack/pulls/773","_links":{"self":{"href":"https://api.github.com/repos/convox/rack/pulls/comments/67379553"},"html":{"href":"https://github.com/convox/rack/pull/773#discussion_r67379553"},"pull_request":{"href":"https://api.github.com/repos/convox/rack/pulls/773"}}},"pull_request":{"url":"https://api.github.com/repos/convox/rack/pulls/773","id":74089780,"html_url":"https://github.com/convox/rack/pull/773","diff_url":"https://github.com/convox/rack/pull/773.diff","patch_url":"https://github.com/convox/rack/pull/773.patch","issue_url":"https://api.github.com/repos/convox/rack/issues/773","number":773,"state":"open","locked":false,"title":"cleanup old builds after build creation","user":{"login":"awsmsrc","id":994907,"avatar_url":"https://avatars.githubusercontent.com/u/994907?v=3","gravatar_id":"","url":"https://api.github.com/users/awsmsrc","html_url":"https://github.com/awsmsrc","followers_url":"https://api.github.com/users/awsmsrc/followers","following_url":"https://api.github.com/users/awsmsrc/following{/other_user}","gists_url":"https://api.github.com/users/awsmsrc/gists{/gist_id}","starred_url":"https://api.github.com/users/awsmsrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awsmsrc/subscriptions","organizations_url":"https://api.github.com/users/awsmsrc/orgs","repos_url":"https://api.github.com/users/awsmsrc/repos","events_url":"https://api.github.com/users/awsmsrc/events{/privacy}","received_events_url":"https://api.github.com/users/awsmsrc/received_events","type":"User","site_admin":false},"body":"fixes #361 \r\n\r\nThis approach may be too brute force??\r\n\r\n## Release Playbook\r\n- [ ] Rebase against master\r\n- [ ] Release branch ()\r\n- [ ] Pass CI ()\r\n- [ ] Code review\r\n- [ ] Merge into master\r\n- [ ] Release master ()\r\n- [ ] Pass CI ()\r\n- [ ] Update staging rack\r\n- [ ] Edit [Rack release record](https://github.com/convox/rack/releases) and/or update [docs](https://github.com/convox/convox.github.io)\r\n- [ ] Publish release\r\n- [ ] Release CLI\r\n\r\n","created_at":"2016-06-16T14:24:26Z","updated_at":"2016-06-16T16:36:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe7ce563ca612405fbd23024ae69ab31688c901e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/convox/rack/pulls/773/commits","review_comments_url":"https://api.github.com/repos/convox/rack/pulls/773/comments","review_comment_url":"https://api.github.com/repos/convox/rack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/convox/rack/issues/773/comments","statuses_url":"https://api.github.com/repos/convox/rack/statuses/e07fd026d444ca32b178a2e782b3f4cce0cfc660","head":{"label":"convox:brute_force_old_build_cleanup","ref":"brute_force_old_build_cleanup","sha":"e07fd026d444ca32b178a2e782b3f4cce0cfc660","user":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"repo":{"id":42454540,"name":"rack","full_name":"convox/rack","owner":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/convox/rack","description":"Open-source PaaS on AWS","fork":false,"url":"https://api.github.com/repos/convox/rack","forks_url":"https://api.github.com/repos/convox/rack/forks","keys_url":"https://api.github.com/repos/convox/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/convox/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/convox/rack/teams","hooks_url":"https://api.github.com/repos/convox/rack/hooks","issue_events_url":"https://api.github.com/repos/convox/rack/issues/events{/number}","events_url":"https://api.github.com/repos/convox/rack/events","assignees_url":"https://api.github.com/repos/convox/rack/assignees{/user}","branches_url":"https://api.github.com/repos/convox/rack/branches{/branch}","tags_url":"https://api.github.com/repos/convox/rack/tags","blobs_url":"https://api.github.com/repos/convox/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/convox/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/convox/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/convox/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/convox/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/convox/rack/languages","stargazers_url":"https://api.github.com/repos/convox/rack/stargazers","contributors_url":"https://api.github.com/repos/convox/rack/contributors","subscribers_url":"https://api.github.com/repos/convox/rack/subscribers","subscription_url":"https://api.github.com/repos/convox/rack/subscription","commits_url":"https://api.github.com/repos/convox/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/convox/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/convox/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/convox/rack/issues/comments{/number}","contents_url":"https://api.github.com/repos/convox/rack/contents/{+path}","compare_url":"https://api.github.com/repos/convox/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/convox/rack/merges","archive_url":"https://api.github.com/repos/convox/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/convox/rack/downloads","issues_url":"https://api.github.com/repos/convox/rack/issues{/number}","pulls_url":"https://api.github.com/repos/convox/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/convox/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/convox/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/convox/rack/labels{/name}","releases_url":"https://api.github.com/repos/convox/rack/releases{/id}","deployments_url":"https://api.github.com/repos/convox/rack/deployments","created_at":"2015-09-14T14:41:30Z","updated_at":"2016-06-16T14:26:40Z","pushed_at":"2016-06-16T15:47:29Z","git_url":"git://github.com/convox/rack.git","ssh_url":"git@github.com:convox/rack.git","clone_url":"https://github.com/convox/rack.git","svn_url":"https://github.com/convox/rack","homepage":"https://convox.com","size":51407,"stargazers_count":1192,"watchers_count":1192,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":105,"forks":78,"open_issues":105,"watchers":1192,"default_branch":"master"}},"base":{"label":"convox:master","ref":"master","sha":"0c1b1611047102d5dbc7b51077a23d91df339123","user":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"repo":{"id":42454540,"name":"rack","full_name":"convox/rack","owner":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/convox/rack","description":"Open-source PaaS on AWS","fork":false,"url":"https://api.github.com/repos/convox/rack","forks_url":"https://api.github.com/repos/convox/rack/forks","keys_url":"https://api.github.com/repos/convox/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/convox/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/convox/rack/teams","hooks_url":"https://api.github.com/repos/convox/rack/hooks","issue_events_url":"https://api.github.com/repos/convox/rack/issues/events{/number}","events_url":"https://api.github.com/repos/convox/rack/events","assignees_url":"https://api.github.com/repos/convox/rack/assignees{/user}","branches_url":"https://api.github.com/repos/convox/rack/branches{/branch}","tags_url":"https://api.github.com/repos/convox/rack/tags","blobs_url":"https://api.github.com/repos/convox/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/convox/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/convox/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/convox/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/convox/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/convox/rack/languages","stargazers_url":"https://api.github.com/repos/convox/rack/stargazers","contributors_url":"https://api.github.com/repos/convox/rack/contributors","subscribers_url":"https://api.github.com/repos/convox/rack/subscribers","subscription_url":"https://api.github.com/repos/convox/rack/subscription","commits_url":"https://api.github.com/repos/convox/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/convox/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/convox/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/convox/rack/issues/comments{/number}","contents_url":"https://api.github.com/repos/convox/rack/contents/{+path}","compare_url":"https://api.github.com/repos/convox/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/convox/rack/merges","archive_url":"https://api.github.com/repos/convox/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/convox/rack/downloads","issues_url":"https://api.github.com/repos/convox/rack/issues{/number}","pulls_url":"https://api.github.com/repos/convox/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/convox/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/convox/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/convox/rack/labels{/name}","releases_url":"https://api.github.com/repos/convox/rack/releases{/id}","deployments_url":"https://api.github.com/repos/convox/rack/deployments","created_at":"2015-09-14T14:41:30Z","updated_at":"2016-06-16T14:26:40Z","pushed_at":"2016-06-16T15:47:29Z","git_url":"git://github.com/convox/rack.git","ssh_url":"git@github.com:convox/rack.git","clone_url":"https://github.com/convox/rack.git","svn_url":"https://github.com/convox/rack","homepage":"https://convox.com","size":51407,"stargazers_count":1192,"watchers_count":1192,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":105,"forks":78,"open_issues":105,"watchers":1192,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/convox/rack/pulls/773"},"html":{"href":"https://github.com/convox/rack/pull/773"},"issue":{"href":"https://api.github.com/repos/convox/rack/issues/773"},"comments":{"href":"https://api.github.com/repos/convox/rack/issues/773/comments"},"review_comments":{"href":"https://api.github.com/repos/convox/rack/pulls/773/comments"},"review_comment":{"href":"https://api.github.com/repos/convox/rack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/convox/rack/pulls/773/commits"},"statuses":{"href":"https://api.github.com/repos/convox/rack/statuses/e07fd026d444ca32b178a2e782b3f4cce0cfc660"}}}}
{"actor":{"display_login":"nzoschke"}}