{"action":"created","comment":{"url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/pulls/comments/82848610","pull_request_review_id":3726869,"id":82848610,"diff_hunk":"@@ -285,6 +428,20 @@ var diameter: Double {\n }\n ```\n \n+### Final\n+\n+Mark classes `final` when inheritance is not intended. Example:\n+\n+```swift\n+// We don't allow subclassing of an equilateral triangle\n+final class EquilateralTriangle : Triangle {\n+    let sideLength: Int\n+    init(sideLength: Int) {\n+        self.sideLength = sideLength\n+    }\n+}\n+```","path":"README.markdown","position":385,"original_position":385,"commit_id":"76a6fe0fdd128c5d1fe7606d86e5ad67c0184b40","original_commit_id":"f0de8c9a4458aacdbde19748011e1e9cec85104a","user":{"login":"kconner","id":602569,"avatar_url":"https://avatars.githubusercontent.com/u/602569?v=3","gravatar_id":"","url":"https://api.github.com/users/kconner","html_url":"https://github.com/kconner","followers_url":"https://api.github.com/users/kconner/followers","following_url":"https://api.github.com/users/kconner/following{/other_user}","gists_url":"https://api.github.com/users/kconner/gists{/gist_id}","starred_url":"https://api.github.com/users/kconner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kconner/subscriptions","organizations_url":"https://api.github.com/users/kconner/orgs","repos_url":"https://api.github.com/users/kconner/repos","events_url":"https://api.github.com/users/kconner/events{/privacy}","received_events_url":"https://api.github.com/users/kconner/received_events","type":"User","site_admin":false},"body":"And if we haven't mentioned it elsewhere: Make types, methods, and properties `private` whenever possible.","created_at":"2016-10-11T17:42:45Z","updated_at":"2016-10-11T17:42:45Z","html_url":"https://github.com/willowtreeapps/swift-style-guide/pull/19#discussion_r82848610","pull_request_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/willowtreeapps/swift-style-guide/pulls/comments/82848610"},"html":{"href":"https://github.com/willowtreeapps/swift-style-guide/pull/19#discussion_r82848610"},"pull_request":{"href":"https://api.github.com/repos/willowtreeapps/swift-style-guide/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/pulls/19","id":88844302,"html_url":"https://github.com/willowtreeapps/swift-style-guide/pull/19","diff_url":"https://github.com/willowtreeapps/swift-style-guide/pull/19.diff","patch_url":"https://github.com/willowtreeapps/swift-style-guide/pull/19.patch","issue_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/issues/19","number":19,"state":"open","locked":false,"title":"Feature/rw updates","user":{"login":"eriklamanna","id":1109302,"avatar_url":"https://avatars.githubusercontent.com/u/1109302?v=3","gravatar_id":"","url":"https://api.github.com/users/eriklamanna","html_url":"https://github.com/eriklamanna","followers_url":"https://api.github.com/users/eriklamanna/followers","following_url":"https://api.github.com/users/eriklamanna/following{/other_user}","gists_url":"https://api.github.com/users/eriklamanna/gists{/gist_id}","starred_url":"https://api.github.com/users/eriklamanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eriklamanna/subscriptions","organizations_url":"https://api.github.com/users/eriklamanna/orgs","repos_url":"https://api.github.com/users/eriklamanna/repos","events_url":"https://api.github.com/users/eriklamanna/events{/privacy}","received_events_url":"https://api.github.com/users/eriklamanna/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-11T14:35:23Z","updated_at":"2016-10-11T17:42:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"367a066cc8f91f1ee83633ad3b812184f94f86f1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/pulls/19/commits","review_comments_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/pulls/19/comments","review_comment_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/issues/19/comments","statuses_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/statuses/76a6fe0fdd128c5d1fe7606d86e5ad67c0184b40","head":{"label":"willowtreeapps:feature/rw_updates","ref":"feature/rw_updates","sha":"76a6fe0fdd128c5d1fe7606d86e5ad67c0184b40","user":{"login":"willowtreeapps","id":557680,"avatar_url":"https://avatars.githubusercontent.com/u/557680?v=3","gravatar_id":"","url":"https://api.github.com/users/willowtreeapps","html_url":"https://github.com/willowtreeapps","followers_url":"https://api.github.com/users/willowtreeapps/followers","following_url":"https://api.github.com/users/willowtreeapps/following{/other_user}","gists_url":"https://api.github.com/users/willowtreeapps/gists{/gist_id}","starred_url":"https://api.github.com/users/willowtreeapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willowtreeapps/subscriptions","organizations_url":"https://api.github.com/users/willowtreeapps/orgs","repos_url":"https://api.github.com/users/willowtreeapps/repos","events_url":"https://api.github.com/users/willowtreeapps/events{/privacy}","received_events_url":"https://api.github.com/users/willowtreeapps/received_events","type":"Organization","site_admin":false},"repo":{"id":41309953,"name":"swift-style-guide","full_name":"willowtreeapps/swift-style-guide","owner":{"login":"willowtreeapps","id":557680,"avatar_url":"https://avatars.githubusercontent.com/u/557680?v=3","gravatar_id":"","url":"https://api.github.com/users/willowtreeapps","html_url":"https://github.com/willowtreeapps","followers_url":"https://api.github.com/users/willowtreeapps/followers","following_url":"https://api.github.com/users/willowtreeapps/following{/other_user}","gists_url":"https://api.github.com/users/willowtreeapps/gists{/gist_id}","starred_url":"https://api.github.com/users/willowtreeapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willowtreeapps/subscriptions","organizations_url":"https://api.github.com/users/willowtreeapps/orgs","repos_url":"https://api.github.com/users/willowtreeapps/repos","events_url":"https://api.github.com/users/willowtreeapps/events{/privacy}","received_events_url":"https://api.github.com/users/willowtreeapps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/willowtreeapps/swift-style-guide","description":"The official Swift style guide for WillowTree Apps","fork":true,"url":"https://api.github.com/repos/willowtreeapps/swift-style-guide","forks_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/forks","keys_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/teams","hooks_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/hooks","issue_events_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/issues/events{/number}","events_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/events","assignees_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/assignees{/user}","branches_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/branches{/branch}","tags_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/tags","blobs_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/languages","stargazers_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/stargazers","contributors_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/contributors","subscribers_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/subscribers","subscription_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/subscription","commits_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/contents/{+path}","compare_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/merges","archive_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/downloads","issues_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/issues{/number}","pulls_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/labels{/name}","releases_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/releases{/id}","deployments_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/deployments","created_at":"2015-08-24T15:06:51Z","updated_at":"2016-09-28T07:21:03Z","pushed_at":"2016-10-11T17:33:06Z","git_url":"git://github.com/willowtreeapps/swift-style-guide.git","ssh_url":"git@github.com:willowtreeapps/swift-style-guide.git","clone_url":"https://github.com/willowtreeapps/swift-style-guide.git","svn_url":"https://github.com/willowtreeapps/swift-style-guide","homepage":"","size":636,"stargazers_count":6,"watchers_count":6,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":6,"default_branch":"master"}},"base":{"label":"willowtreeapps:master","ref":"master","sha":"da4dc1e5393dfd6e89c897b2d80429748cbe7f0a","user":{"login":"willowtreeapps","id":557680,"avatar_url":"https://avatars.githubusercontent.com/u/557680?v=3","gravatar_id":"","url":"https://api.github.com/users/willowtreeapps","html_url":"https://github.com/willowtreeapps","followers_url":"https://api.github.com/users/willowtreeapps/followers","following_url":"https://api.github.com/users/willowtreeapps/following{/other_user}","gists_url":"https://api.github.com/users/willowtreeapps/gists{/gist_id}","starred_url":"https://api.github.com/users/willowtreeapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willowtreeapps/subscriptions","organizations_url":"https://api.github.com/users/willowtreeapps/orgs","repos_url":"https://api.github.com/users/willowtreeapps/repos","events_url":"https://api.github.com/users/willowtreeapps/events{/privacy}","received_events_url":"https://api.github.com/users/willowtreeapps/received_events","type":"Organization","site_admin":false},"repo":{"id":41309953,"name":"swift-style-guide","full_name":"willowtreeapps/swift-style-guide","owner":{"login":"willowtreeapps","id":557680,"avatar_url":"https://avatars.githubusercontent.com/u/557680?v=3","gravatar_id":"","url":"https://api.github.com/users/willowtreeapps","html_url":"https://github.com/willowtreeapps","followers_url":"https://api.github.com/users/willowtreeapps/followers","following_url":"https://api.github.com/users/willowtreeapps/following{/other_user}","gists_url":"https://api.github.com/users/willowtreeapps/gists{/gist_id}","starred_url":"https://api.github.com/users/willowtreeapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willowtreeapps/subscriptions","organizations_url":"https://api.github.com/users/willowtreeapps/orgs","repos_url":"https://api.github.com/users/willowtreeapps/repos","events_url":"https://api.github.com/users/willowtreeapps/events{/privacy}","received_events_url":"https://api.github.com/users/willowtreeapps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/willowtreeapps/swift-style-guide","description":"The official Swift style guide for WillowTree Apps","fork":true,"url":"https://api.github.com/repos/willowtreeapps/swift-style-guide","forks_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/forks","keys_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/teams","hooks_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/hooks","issue_events_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/issues/events{/number}","events_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/events","assignees_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/assignees{/user}","branches_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/branches{/branch}","tags_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/tags","blobs_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/languages","stargazers_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/stargazers","contributors_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/contributors","subscribers_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/subscribers","subscription_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/subscription","commits_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/contents/{+path}","compare_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/merges","archive_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/downloads","issues_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/issues{/number}","pulls_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/labels{/name}","releases_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/releases{/id}","deployments_url":"https://api.github.com/repos/willowtreeapps/swift-style-guide/deployments","created_at":"2015-08-24T15:06:51Z","updated_at":"2016-09-28T07:21:03Z","pushed_at":"2016-10-11T17:33:06Z","git_url":"git://github.com/willowtreeapps/swift-style-guide.git","ssh_url":"git@github.com:willowtreeapps/swift-style-guide.git","clone_url":"https://github.com/willowtreeapps/swift-style-guide.git","svn_url":"https://github.com/willowtreeapps/swift-style-guide","homepage":"","size":636,"stargazers_count":6,"watchers_count":6,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/willowtreeapps/swift-style-guide/pulls/19"},"html":{"href":"https://github.com/willowtreeapps/swift-style-guide/pull/19"},"issue":{"href":"https://api.github.com/repos/willowtreeapps/swift-style-guide/issues/19"},"comments":{"href":"https://api.github.com/repos/willowtreeapps/swift-style-guide/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/willowtreeapps/swift-style-guide/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/willowtreeapps/swift-style-guide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/willowtreeapps/swift-style-guide/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/willowtreeapps/swift-style-guide/statuses/76a6fe0fdd128c5d1fe7606d86e5ad67c0184b40"}}}}
{"actor":{"display_login":"kconner"}}