{"action":"created","comment":{"url":"https://api.github.com/repos/Manishearth/rust-gc/pulls/comments/76506433","id":76506433,"diff_hunk":"@@ -34,9 +36,7 @@ pub use gc::force_collect;\n ///\n /// See the [module level documentation](./) for more details.\n pub struct Gc<T: Trace + ?Sized + 'static> {\n-    // XXX We can probably take advantage of alignment to store this\n-    root: Cell<bool>,\n-    ptr: Shared<GcBox<T>>,\n+    ptr_root: Cell<NonZero<*const GcBox<T>>>,","path":"gc/src/lib.rs","position":29,"original_position":29,"commit_id":"565364ff85feec47f3a1cc7b278e766f8e8fb962","original_commit_id":"565364ff85feec47f3a1cc7b278e766f8e8fb962","user":{"login":"mystor","id":1261662,"avatar_url":"https://avatars.githubusercontent.com/u/1261662?v=3","gravatar_id":"","url":"https://api.github.com/users/mystor","html_url":"https://github.com/mystor","followers_url":"https://api.github.com/users/mystor/followers","following_url":"https://api.github.com/users/mystor/following{/other_user}","gists_url":"https://api.github.com/users/mystor/gists{/gist_id}","starred_url":"https://api.github.com/users/mystor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mystor/subscriptions","organizations_url":"https://api.github.com/users/mystor/orgs","repos_url":"https://api.github.com/users/mystor/repos","events_url":"https://api.github.com/users/mystor/events{/privacy}","received_events_url":"https://api.github.com/users/mystor/received_events","type":"User","site_admin":false},"body":"We should make sure to also have the PhantomData here that used to be in Shared<T>","created_at":"2016-08-27T00:45:46Z","updated_at":"2016-08-27T00:45:46Z","html_url":"https://github.com/Manishearth/rust-gc/pull/40#discussion_r76506433","pull_request_url":"https://api.github.com/repos/Manishearth/rust-gc/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/Manishearth/rust-gc/pulls/comments/76506433"},"html":{"href":"https://github.com/Manishearth/rust-gc/pull/40#discussion_r76506433"},"pull_request":{"href":"https://api.github.com/repos/Manishearth/rust-gc/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/Manishearth/rust-gc/pulls/40","id":82962038,"html_url":"https://github.com/Manishearth/rust-gc/pull/40","diff_url":"https://github.com/Manishearth/rust-gc/pull/40.diff","patch_url":"https://github.com/Manishearth/rust-gc/pull/40.patch","issue_url":"https://api.github.com/repos/Manishearth/rust-gc/issues/40","number":40,"state":"open","locked":false,"title":"Use alignment to store `Gc`'s rooted flag","user":{"login":"apasel422","id":8644784,"avatar_url":"https://avatars.githubusercontent.com/u/8644784?v=3","gravatar_id":"","url":"https://api.github.com/users/apasel422","html_url":"https://github.com/apasel422","followers_url":"https://api.github.com/users/apasel422/followers","following_url":"https://api.github.com/users/apasel422/following{/other_user}","gists_url":"https://api.github.com/users/apasel422/gists{/gist_id}","starred_url":"https://api.github.com/users/apasel422/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apasel422/subscriptions","organizations_url":"https://api.github.com/users/apasel422/orgs","repos_url":"https://api.github.com/users/apasel422/repos","events_url":"https://api.github.com/users/apasel422/events{/privacy}","received_events_url":"https://api.github.com/users/apasel422/received_events","type":"User","site_admin":false},"body":"Supplants #17","created_at":"2016-08-26T22:18:00Z","updated_at":"2016-08-27T00:45:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b994c41178ed2d395aeeca372c251326fe56821","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Manishearth/rust-gc/pulls/40/commits","review_comments_url":"https://api.github.com/repos/Manishearth/rust-gc/pulls/40/comments","review_comment_url":"https://api.github.com/repos/Manishearth/rust-gc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Manishearth/rust-gc/issues/40/comments","statuses_url":"https://api.github.com/repos/Manishearth/rust-gc/statuses/565364ff85feec47f3a1cc7b278e766f8e8fb962","head":{"label":"apasel422:collapse","ref":"collapse","sha":"565364ff85feec47f3a1cc7b278e766f8e8fb962","user":{"login":"apasel422","id":8644784,"avatar_url":"https://avatars.githubusercontent.com/u/8644784?v=3","gravatar_id":"","url":"https://api.github.com/users/apasel422","html_url":"https://github.com/apasel422","followers_url":"https://api.github.com/users/apasel422/followers","following_url":"https://api.github.com/users/apasel422/following{/other_user}","gists_url":"https://api.github.com/users/apasel422/gists{/gist_id}","starred_url":"https://api.github.com/users/apasel422/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apasel422/subscriptions","organizations_url":"https://api.github.com/users/apasel422/orgs","repos_url":"https://api.github.com/users/apasel422/repos","events_url":"https://api.github.com/users/apasel422/events{/privacy}","received_events_url":"https://api.github.com/users/apasel422/received_events","type":"User","site_admin":false},"repo":{"id":65056185,"name":"rust-gc","full_name":"apasel422/rust-gc","owner":{"login":"apasel422","id":8644784,"avatar_url":"https://avatars.githubusercontent.com/u/8644784?v=3","gravatar_id":"","url":"https://api.github.com/users/apasel422","html_url":"https://github.com/apasel422","followers_url":"https://api.github.com/users/apasel422/followers","following_url":"https://api.github.com/users/apasel422/following{/other_user}","gists_url":"https://api.github.com/users/apasel422/gists{/gist_id}","starred_url":"https://api.github.com/users/apasel422/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apasel422/subscriptions","organizations_url":"https://api.github.com/users/apasel422/orgs","repos_url":"https://api.github.com/users/apasel422/repos","events_url":"https://api.github.com/users/apasel422/events{/privacy}","received_events_url":"https://api.github.com/users/apasel422/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apasel422/rust-gc","description":"Simple tracing (mark and sweep) garbage collector for Rust","fork":true,"url":"https://api.github.com/repos/apasel422/rust-gc","forks_url":"https://api.github.com/repos/apasel422/rust-gc/forks","keys_url":"https://api.github.com/repos/apasel422/rust-gc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apasel422/rust-gc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apasel422/rust-gc/teams","hooks_url":"https://api.github.com/repos/apasel422/rust-gc/hooks","issue_events_url":"https://api.github.com/repos/apasel422/rust-gc/issues/events{/number}","events_url":"https://api.github.com/repos/apasel422/rust-gc/events","assignees_url":"https://api.github.com/repos/apasel422/rust-gc/assignees{/user}","branches_url":"https://api.github.com/repos/apasel422/rust-gc/branches{/branch}","tags_url":"https://api.github.com/repos/apasel422/rust-gc/tags","blobs_url":"https://api.github.com/repos/apasel422/rust-gc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apasel422/rust-gc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apasel422/rust-gc/git/refs{/sha}","trees_url":"https://api.github.com/repos/apasel422/rust-gc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apasel422/rust-gc/statuses/{sha}","languages_url":"https://api.github.com/repos/apasel422/rust-gc/languages","stargazers_url":"https://api.github.com/repos/apasel422/rust-gc/stargazers","contributors_url":"https://api.github.com/repos/apasel422/rust-gc/contributors","subscribers_url":"https://api.github.com/repos/apasel422/rust-gc/subscribers","subscription_url":"https://api.github.com/repos/apasel422/rust-gc/subscription","commits_url":"https://api.github.com/repos/apasel422/rust-gc/commits{/sha}","git_commits_url":"https://api.github.com/repos/apasel422/rust-gc/git/commits{/sha}","comments_url":"https://api.github.com/repos/apasel422/rust-gc/comments{/number}","issue_comment_url":"https://api.github.com/repos/apasel422/rust-gc/issues/comments{/number}","contents_url":"https://api.github.com/repos/apasel422/rust-gc/contents/{+path}","compare_url":"https://api.github.com/repos/apasel422/rust-gc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apasel422/rust-gc/merges","archive_url":"https://api.github.com/repos/apasel422/rust-gc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apasel422/rust-gc/downloads","issues_url":"https://api.github.com/repos/apasel422/rust-gc/issues{/number}","pulls_url":"https://api.github.com/repos/apasel422/rust-gc/pulls{/number}","milestones_url":"https://api.github.com/repos/apasel422/rust-gc/milestones{/number}","notifications_url":"https://api.github.com/repos/apasel422/rust-gc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apasel422/rust-gc/labels{/name}","releases_url":"https://api.github.com/repos/apasel422/rust-gc/releases{/id}","deployments_url":"https://api.github.com/repos/apasel422/rust-gc/deployments","created_at":"2016-08-05T23:55:45Z","updated_at":"2016-08-05T23:55:46Z","pushed_at":"2016-08-26T22:16:53Z","git_url":"git://github.com/apasel422/rust-gc.git","ssh_url":"git@github.com:apasel422/rust-gc.git","clone_url":"https://github.com/apasel422/rust-gc.git","svn_url":"https://github.com/apasel422/rust-gc","homepage":null,"size":678,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Manishearth:master","ref":"master","sha":"d954a704f0199a5b0586ddf88016d2db07851152","user":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"repo":{"id":35750399,"name":"rust-gc","full_name":"Manishearth/rust-gc","owner":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Manishearth/rust-gc","description":"Simple tracing (mark and sweep) garbage collector for Rust","fork":false,"url":"https://api.github.com/repos/Manishearth/rust-gc","forks_url":"https://api.github.com/repos/Manishearth/rust-gc/forks","keys_url":"https://api.github.com/repos/Manishearth/rust-gc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Manishearth/rust-gc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Manishearth/rust-gc/teams","hooks_url":"https://api.github.com/repos/Manishearth/rust-gc/hooks","issue_events_url":"https://api.github.com/repos/Manishearth/rust-gc/issues/events{/number}","events_url":"https://api.github.com/repos/Manishearth/rust-gc/events","assignees_url":"https://api.github.com/repos/Manishearth/rust-gc/assignees{/user}","branches_url":"https://api.github.com/repos/Manishearth/rust-gc/branches{/branch}","tags_url":"https://api.github.com/repos/Manishearth/rust-gc/tags","blobs_url":"https://api.github.com/repos/Manishearth/rust-gc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Manishearth/rust-gc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Manishearth/rust-gc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Manishearth/rust-gc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Manishearth/rust-gc/statuses/{sha}","languages_url":"https://api.github.com/repos/Manishearth/rust-gc/languages","stargazers_url":"https://api.github.com/repos/Manishearth/rust-gc/stargazers","contributors_url":"https://api.github.com/repos/Manishearth/rust-gc/contributors","subscribers_url":"https://api.github.com/repos/Manishearth/rust-gc/subscribers","subscription_url":"https://api.github.com/repos/Manishearth/rust-gc/subscription","commits_url":"https://api.github.com/repos/Manishearth/rust-gc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Manishearth/rust-gc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Manishearth/rust-gc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Manishearth/rust-gc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Manishearth/rust-gc/contents/{+path}","compare_url":"https://api.github.com/repos/Manishearth/rust-gc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Manishearth/rust-gc/merges","archive_url":"https://api.github.com/repos/Manishearth/rust-gc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Manishearth/rust-gc/downloads","issues_url":"https://api.github.com/repos/Manishearth/rust-gc/issues{/number}","pulls_url":"https://api.github.com/repos/Manishearth/rust-gc/pulls{/number}","milestones_url":"https://api.github.com/repos/Manishearth/rust-gc/milestones{/number}","notifications_url":"https://api.github.com/repos/Manishearth/rust-gc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Manishearth/rust-gc/labels{/name}","releases_url":"https://api.github.com/repos/Manishearth/rust-gc/releases{/id}","deployments_url":"https://api.github.com/repos/Manishearth/rust-gc/deployments","created_at":"2015-05-17T03:31:43Z","updated_at":"2016-08-26T21:49:49Z","pushed_at":"2016-08-26T22:18:01Z","git_url":"git://github.com/Manishearth/rust-gc.git","ssh_url":"git@github.com:Manishearth/rust-gc.git","clone_url":"https://github.com/Manishearth/rust-gc.git","svn_url":"https://github.com/Manishearth/rust-gc","homepage":null,"size":650,"stargazers_count":131,"watchers_count":131,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":8,"forks":14,"open_issues":8,"watchers":131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Manishearth/rust-gc/pulls/40"},"html":{"href":"https://github.com/Manishearth/rust-gc/pull/40"},"issue":{"href":"https://api.github.com/repos/Manishearth/rust-gc/issues/40"},"comments":{"href":"https://api.github.com/repos/Manishearth/rust-gc/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/Manishearth/rust-gc/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/Manishearth/rust-gc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Manishearth/rust-gc/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/Manishearth/rust-gc/statuses/565364ff85feec47f3a1cc7b278e766f8e8fb962"}}}}
{"actor":{"display_login":"mystor"}}