{"action":"created","comment":{"url":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments/50735772","id":50735772,"diff_hunk":"@@ -17,7 +17,28 @@\n \n #include <string>\n #include <parquet/parquet.h>\n+#include <stdio.h>\n \n bool GetFileMetadata(const std::string& path, parquet::FileMetaData* metadata);\n \n-#endif\n+class InputFile {","path":"example/example_util.h","position":9,"original_position":9,"commit_id":"766b6a52e6622be9dae0a8d93d237bda9cf064d6","original_commit_id":"766b6a52e6622be9dae0a8d93d237bda9cf064d6","user":{"login":"asandryh","id":9371145,"avatar_url":"https://avatars.githubusercontent.com/u/9371145?v=3","gravatar_id":"","url":"https://api.github.com/users/asandryh","html_url":"https://github.com/asandryh","followers_url":"https://api.github.com/users/asandryh/followers","following_url":"https://api.github.com/users/asandryh/following{/other_user}","gists_url":"https://api.github.com/users/asandryh/gists{/gist_id}","starred_url":"https://api.github.com/users/asandryh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asandryh/subscriptions","organizations_url":"https://api.github.com/users/asandryh/orgs","repos_url":"https://api.github.com/users/asandryh/repos","events_url":"https://api.github.com/users/asandryh/events{/privacy}","received_events_url":"https://api.github.com/users/asandryh/received_events","type":"User","site_admin":false},"body":"This class is redundant now (it came from pull request #18). It is only used in parquet_reader, though, so it's easy to replace it with LocalFile.","created_at":"2016-01-25T18:42:03Z","updated_at":"2016-01-25T18:42:03Z","html_url":"https://github.com/apache/parquet-cpp/pull/22#discussion_r50735772","pull_request_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments/50735772"},"html":{"href":"https://github.com/apache/parquet-cpp/pull/22#discussion_r50735772"},"pull_request":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/apache/parquet-cpp/pulls/22","id":56960069,"html_url":"https://github.com/apache/parquet-cpp/pull/22","diff_url":"https://github.com/apache/parquet-cpp/pull/22.diff","patch_url":"https://github.com/apache/parquet-cpp/pull/22.patch","issue_url":"https://api.github.com/repos/apache/parquet-cpp/issues/22","number":22,"state":"open","locked":false,"title":"PARQUET-433: Add TypedColumnReader template and templatize value decoders","user":{"login":"wesm","id":329591,"avatar_url":"https://avatars.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"body":"Having the physical Parquet types available at compile time opens up many new avenues to simplify the code and make it easier to extend and refactor. Fewer switch statements, and the `type_traits` template pattern (see `parquet/types.h`) lets us associate value types and other stuff with the `parquet::Type` values at compile time. This also makes the decoder classes (especially dictionary encoding) much simpler. We'll reap the same benefits on the encoding / writing paths in the future.\r\n\r\nThis includes #18, #19, and #20, and I will rebase once those patches are completed and merged. ","created_at":"2016-01-23T00:26:40Z","updated_at":"2016-01-25T18:42:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2dda647771d00d7ddab844fb1e05ce82fd814a6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/22/commits","review_comments_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/22/comments","review_comment_url":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/parquet-cpp/issues/22/comments","statuses_url":"https://api.github.com/repos/apache/parquet-cpp/statuses/766b6a52e6622be9dae0a8d93d237bda9cf064d6","head":{"label":"wesm:PARQUET-433","ref":"PARQUET-433","sha":"766b6a52e6622be9dae0a8d93d237bda9cf064d6","user":{"login":"wesm","id":329591,"avatar_url":"https://avatars.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"repo":{"id":48463753,"name":"parquet-cpp","full_name":"wesm/parquet-cpp","owner":{"login":"wesm","id":329591,"avatar_url":"https://avatars.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wesm/parquet-cpp","description":"Mirror of Apache Parquet","fork":true,"url":"https://api.github.com/repos/wesm/parquet-cpp","forks_url":"https://api.github.com/repos/wesm/parquet-cpp/forks","keys_url":"https://api.github.com/repos/wesm/parquet-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wesm/parquet-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wesm/parquet-cpp/teams","hooks_url":"https://api.github.com/repos/wesm/parquet-cpp/hooks","issue_events_url":"https://api.github.com/repos/wesm/parquet-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/wesm/parquet-cpp/events","assignees_url":"https://api.github.com/repos/wesm/parquet-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/wesm/parquet-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/wesm/parquet-cpp/tags","blobs_url":"https://api.github.com/repos/wesm/parquet-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wesm/parquet-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wesm/parquet-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/wesm/parquet-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wesm/parquet-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/wesm/parquet-cpp/languages","stargazers_url":"https://api.github.com/repos/wesm/parquet-cpp/stargazers","contributors_url":"https://api.github.com/repos/wesm/parquet-cpp/contributors","subscribers_url":"https://api.github.com/repos/wesm/parquet-cpp/subscribers","subscription_url":"https://api.github.com/repos/wesm/parquet-cpp/subscription","commits_url":"https://api.github.com/repos/wesm/parquet-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/wesm/parquet-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/wesm/parquet-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/wesm/parquet-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/wesm/parquet-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/wesm/parquet-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wesm/parquet-cpp/merges","archive_url":"https://api.github.com/repos/wesm/parquet-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wesm/parquet-cpp/downloads","issues_url":"https://api.github.com/repos/wesm/parquet-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/wesm/parquet-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/wesm/parquet-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/wesm/parquet-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wesm/parquet-cpp/labels{/name}","releases_url":"https://api.github.com/repos/wesm/parquet-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/wesm/parquet-cpp/deployments","created_at":"2015-12-23T02:08:59Z","updated_at":"2016-01-11T19:24:28Z","pushed_at":"2016-01-25T02:47:35Z","git_url":"git://github.com/wesm/parquet-cpp.git","ssh_url":"git@github.com:wesm/parquet-cpp.git","clone_url":"https://github.com/wesm/parquet-cpp.git","svn_url":"https://github.com/wesm/parquet-cpp","homepage":null,"size":292,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"0149a7afc0de2c62326580b383ca3307b6711a9d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20675634,"name":"parquet-cpp","full_name":"apache/parquet-cpp","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/parquet-cpp","description":"Mirror of Apache Parquet","fork":false,"url":"https://api.github.com/repos/apache/parquet-cpp","forks_url":"https://api.github.com/repos/apache/parquet-cpp/forks","keys_url":"https://api.github.com/repos/apache/parquet-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/parquet-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/parquet-cpp/teams","hooks_url":"https://api.github.com/repos/apache/parquet-cpp/hooks","issue_events_url":"https://api.github.com/repos/apache/parquet-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/apache/parquet-cpp/events","assignees_url":"https://api.github.com/repos/apache/parquet-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/apache/parquet-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/apache/parquet-cpp/tags","blobs_url":"https://api.github.com/repos/apache/parquet-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/parquet-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/parquet-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/parquet-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/parquet-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/parquet-cpp/languages","stargazers_url":"https://api.github.com/repos/apache/parquet-cpp/stargazers","contributors_url":"https://api.github.com/repos/apache/parquet-cpp/contributors","subscribers_url":"https://api.github.com/repos/apache/parquet-cpp/subscribers","subscription_url":"https://api.github.com/repos/apache/parquet-cpp/subscription","commits_url":"https://api.github.com/repos/apache/parquet-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/parquet-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/parquet-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/parquet-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/parquet-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/apache/parquet-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/parquet-cpp/merges","archive_url":"https://api.github.com/repos/apache/parquet-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/parquet-cpp/downloads","issues_url":"https://api.github.com/repos/apache/parquet-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/apache/parquet-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/parquet-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/parquet-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/parquet-cpp/labels{/name}","releases_url":"https://api.github.com/repos/apache/parquet-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/apache/parquet-cpp/deployments","created_at":"2014-06-10T07:00:07Z","updated_at":"2016-01-13T19:35:35Z","pushed_at":"2016-01-25T16:24:24Z","git_url":"git://github.com/apache/parquet-cpp.git","ssh_url":"git@github.com:apache/parquet-cpp.git","clone_url":"https://github.com/apache/parquet-cpp.git","svn_url":"https://github.com/apache/parquet-cpp","homepage":null,"size":314,"stargazers_count":19,"watchers_count":19,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":"git://git.apache.org/parquet-cpp.git","open_issues_count":11,"forks":18,"open_issues":11,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/22"},"html":{"href":"https://github.com/apache/parquet-cpp/pull/22"},"issue":{"href":"https://api.github.com/repos/apache/parquet-cpp/issues/22"},"comments":{"href":"https://api.github.com/repos/apache/parquet-cpp/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/parquet-cpp/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/apache/parquet-cpp/statuses/766b6a52e6622be9dae0a8d93d237bda9cf064d6"}}}}