{"action":"created","issue":{"url":"https://api.github.com/repos/dgrtwo/broom/issues/146","repository_url":"https://api.github.com/repos/dgrtwo/broom","labels_url":"https://api.github.com/repos/dgrtwo/broom/issues/146/labels{/name}","comments_url":"https://api.github.com/repos/dgrtwo/broom/issues/146/comments","events_url":"https://api.github.com/repos/dgrtwo/broom/issues/146/events","html_url":"https://github.com/dgrtwo/broom/issues/146","id":165080716,"number":146,"title":"Testing the 'broom' package","user":{"login":"mbojan","id":636574,"avatar_url":"https://avatars.githubusercontent.com/u/636574?v=3","gravatar_id":"","url":"https://api.github.com/users/mbojan","html_url":"https://github.com/mbojan","followers_url":"https://api.github.com/users/mbojan/followers","following_url":"https://api.github.com/users/mbojan/following{/other_user}","gists_url":"https://api.github.com/users/mbojan/gists{/gist_id}","starred_url":"https://api.github.com/users/mbojan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbojan/subscriptions","organizations_url":"https://api.github.com/users/mbojan/orgs","repos_url":"https://api.github.com/users/mbojan/repos","events_url":"https://api.github.com/users/mbojan/events{/privacy}","received_events_url":"https://api.github.com/users/mbojan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-12T13:29:58Z","updated_at":"2016-07-12T14:40:07Z","closed_at":null,"body":"The package contains almost 100 `tidy` methods for objects that come from a large number of packages. Testing requires installation of all these new packages. This is cumbersome because if I just add yet another `tidy` method it is totally independent of 95% of the rest of the code.\r\n\r\nAs demonstrated by the TravisCI error at this very moment, testing fails because one of the many external packages that provide classes that \"broom\" is `tidy`ing fails to install for one reason or another.\r\n\r\nI think in general it would be useful to be able to switch off selected tests, e.g. for methods that are not being  worked-on. Alternatively, in the long term, it might be worth considering splitting the \"broom\" package into sub-packages. Each sub-package might correspond to a certain external package (e.g. \"broom-survival\" and so on). Broom might then provide definitions for generics `tidy`, `glance`, etc. with the actual methods elsewhere. I am affraid that with the current mode of operation \"broom\" will quickly become unmaintainable...\r\n"},"comment":{"url":"https://api.github.com/repos/dgrtwo/broom/issues/comments/232068467","html_url":"https://github.com/dgrtwo/broom/issues/146#issuecomment-232068467","issue_url":"https://api.github.com/repos/dgrtwo/broom/issues/146","id":232068467,"user":{"login":"dgrtwo","id":994718,"avatar_url":"https://avatars.githubusercontent.com/u/994718?v=3","gravatar_id":"","url":"https://api.github.com/users/dgrtwo","html_url":"https://github.com/dgrtwo","followers_url":"https://api.github.com/users/dgrtwo/followers","following_url":"https://api.github.com/users/dgrtwo/following{/other_user}","gists_url":"https://api.github.com/users/dgrtwo/gists{/gist_id}","starred_url":"https://api.github.com/users/dgrtwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgrtwo/subscriptions","organizations_url":"https://api.github.com/users/dgrtwo/orgs","repos_url":"https://api.github.com/users/dgrtwo/repos","events_url":"https://api.github.com/users/dgrtwo/events{/privacy}","received_events_url":"https://api.github.com/users/dgrtwo/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T14:40:07Z","updated_at":"2016-07-12T14:40:07Z","body":"This is a problem that was faced by the caret package as well [here's some slides on how they addressed it](http://www.slideshare.net/Work-Bench/nobody-knows-what-its-like-to-be-the-bad-man).\r\n\r\nI don't want to turn off tests in general, because tests are one of the few ways we can detect changes in these many packages that cause tidiers to fail. (Our test coverage is already too low). And even if we turned them off using a code switch, we would still have to leave them in Suggests (unless we removed both the tests and example code), at which point they'll be installed anyway.\r\n\r\nThere are two cases where we've begun spreading out tidying methods into other packages: the [tidytext](https://github.com/juliasilge/tidytext) package is where methods for text data (e.g. tm and quanteda) go, and the [biobroom](http://bioconductor.org/packages/release/bioc/html/biobroom.html) package is for Bioconductor objects. In each case someone else is the primary maintainer, which also helps take the strain off me, so I imagine that will be true of others we split off. I'm not entirely sure a package just for survival methods would be worth splitting off but I can imagine other subsets doing so."}}
{"actor":{"display_login":"dgrtwo"}}