{"action":"created","comment":{"url":"https://api.github.com/repos/openthread/openthread/pulls/comments/91336749","pull_request_review_id":11845628,"id":91336749,"diff_hunk":"@@ -3327,34 +3418,93 @@ ThreadError NcpBase::SetPropertyHandler_MAC_RAW_STREAM_ENABLED(uint8_t header, s\n     return errorCode;\n }\n \n+ThreadError NcpBase::SetPropertyHandler_STREAM_RAW(uint8_t header, spinel_prop_key_t key, const uint8_t *value_ptr, uint16_t value_len)\n+{\n+    spinel_ssize_t parsedLength(0);\n+    ThreadError errorCode = kThreadError_None;\n+    RadioPacket packet;","path":"src/ncp/ncp_base.cpp","position":265,"original_position":265,"commit_id":"d07082a489358aa23a09ad66f752c1302228cc7c","original_commit_id":"d07082a489358aa23a09ad66f752c1302228cc7c","user":{"login":"nibanks","id":20663557,"avatar_url":"https://avatars.githubusercontent.com/u/20663557?v=3","gravatar_id":"","url":"https://api.github.com/users/nibanks","html_url":"https://github.com/nibanks","followers_url":"https://api.github.com/users/nibanks/followers","following_url":"https://api.github.com/users/nibanks/following{/other_user}","gists_url":"https://api.github.com/users/nibanks/gists{/gist_id}","starred_url":"https://api.github.com/users/nibanks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nibanks/subscriptions","organizations_url":"https://api.github.com/users/nibanks/orgs","repos_url":"https://api.github.com/users/nibanks/repos","events_url":"https://api.github.com/users/nibanks/events{/privacy}","received_events_url":"https://api.github.com/users/nibanks/received_events","type":"User","site_admin":false},"body":"This should be using `otPlatRadioGetTransmitBuffer` instead of a local buffer.","created_at":"2016-12-07T16:56:47Z","updated_at":"2016-12-07T16:56:47Z","html_url":"https://github.com/openthread/openthread/pull/1004#discussion_r91336749","pull_request_url":"https://api.github.com/repos/openthread/openthread/pulls/1004","_links":{"self":{"href":"https://api.github.com/repos/openthread/openthread/pulls/comments/91336749"},"html":{"href":"https://github.com/openthread/openthread/pull/1004#discussion_r91336749"},"pull_request":{"href":"https://api.github.com/repos/openthread/openthread/pulls/1004"}}},"pull_request":{"url":"https://api.github.com/repos/openthread/openthread/pulls/1004","id":94892482,"html_url":"https://github.com/openthread/openthread/pull/1004","diff_url":"https://github.com/openthread/openthread/pull/1004.diff","patch_url":"https://github.com/openthread/openthread/pull/1004.patch","issue_url":"https://api.github.com/repos/openthread/openthread/issues/1004","number":1004,"state":"open","locked":false,"title":"Refactor Radio Platform","user":{"login":"nibanks","id":20663557,"avatar_url":"https://avatars.githubusercontent.com/u/20663557?v=3","gravatar_id":"","url":"https://api.github.com/users/nibanks","html_url":"https://github.com/nibanks","followers_url":"https://api.github.com/users/nibanks/followers","following_url":"https://api.github.com/users/nibanks/following{/other_user}","gists_url":"https://api.github.com/users/nibanks/gists{/gist_id}","starred_url":"https://api.github.com/users/nibanks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nibanks/subscriptions","organizations_url":"https://api.github.com/users/nibanks/orgs","repos_url":"https://api.github.com/users/nibanks/repos","events_url":"https://api.github.com/users/nibanks/events{/privacy}","received_events_url":"https://api.github.com/users/nibanks/received_events","type":"User","site_admin":false},"body":"Refactor Radio platform receive/transmit callbacks to be dynamically assigned. To be used by NCP to dynamically switch from using OpenThread library to just Radio platform.\r\n\r\nAlso adds functions for NCP to query Radio platform state variables directly.","created_at":"2016-11-22T20:31:35Z","updated_at":"2016-12-07T16:56:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a58eb8dd3fd7a2a8118ac873ce3a7a881798d86","assignee":{"login":"darconeous","id":686678,"avatar_url":"https://avatars.githubusercontent.com/u/686678?v=3","gravatar_id":"","url":"https://api.github.com/users/darconeous","html_url":"https://github.com/darconeous","followers_url":"https://api.github.com/users/darconeous/followers","following_url":"https://api.github.com/users/darconeous/following{/other_user}","gists_url":"https://api.github.com/users/darconeous/gists{/gist_id}","starred_url":"https://api.github.com/users/darconeous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darconeous/subscriptions","organizations_url":"https://api.github.com/users/darconeous/orgs","repos_url":"https://api.github.com/users/darconeous/repos","events_url":"https://api.github.com/users/darconeous/events{/privacy}","received_events_url":"https://api.github.com/users/darconeous/received_events","type":"User","site_admin":false},"assignees":[{"login":"darconeous","id":686678,"avatar_url":"https://avatars.githubusercontent.com/u/686678?v=3","gravatar_id":"","url":"https://api.github.com/users/darconeous","html_url":"https://github.com/darconeous","followers_url":"https://api.github.com/users/darconeous/followers","following_url":"https://api.github.com/users/darconeous/following{/other_user}","gists_url":"https://api.github.com/users/darconeous/gists{/gist_id}","starred_url":"https://api.github.com/users/darconeous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darconeous/subscriptions","organizations_url":"https://api.github.com/users/darconeous/orgs","repos_url":"https://api.github.com/users/darconeous/repos","events_url":"https://api.github.com/users/darconeous/events{/privacy}","received_events_url":"https://api.github.com/users/darconeous/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openthread/openthread/pulls/1004/commits","review_comments_url":"https://api.github.com/repos/openthread/openthread/pulls/1004/comments","review_comment_url":"https://api.github.com/repos/openthread/openthread/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openthread/openthread/issues/1004/comments","statuses_url":"https://api.github.com/repos/openthread/openthread/statuses/d07082a489358aa23a09ad66f752c1302228cc7c","head":{"label":"nibanks:pr/radio-platform","ref":"pr/radio-platform","sha":"d07082a489358aa23a09ad66f752c1302228cc7c","user":{"login":"nibanks","id":20663557,"avatar_url":"https://avatars.githubusercontent.com/u/20663557?v=3","gravatar_id":"","url":"https://api.github.com/users/nibanks","html_url":"https://github.com/nibanks","followers_url":"https://api.github.com/users/nibanks/followers","following_url":"https://api.github.com/users/nibanks/following{/other_user}","gists_url":"https://api.github.com/users/nibanks/gists{/gist_id}","starred_url":"https://api.github.com/users/nibanks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nibanks/subscriptions","organizations_url":"https://api.github.com/users/nibanks/orgs","repos_url":"https://api.github.com/users/nibanks/repos","events_url":"https://api.github.com/users/nibanks/events{/privacy}","received_events_url":"https://api.github.com/users/nibanks/received_events","type":"User","site_admin":false},"repo":{"id":65052520,"name":"openthread","full_name":"nibanks/openthread","owner":{"login":"nibanks","id":20663557,"avatar_url":"https://avatars.githubusercontent.com/u/20663557?v=3","gravatar_id":"","url":"https://api.github.com/users/nibanks","html_url":"https://github.com/nibanks","followers_url":"https://api.github.com/users/nibanks/followers","following_url":"https://api.github.com/users/nibanks/following{/other_user}","gists_url":"https://api.github.com/users/nibanks/gists{/gist_id}","starred_url":"https://api.github.com/users/nibanks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nibanks/subscriptions","organizations_url":"https://api.github.com/users/nibanks/orgs","repos_url":"https://api.github.com/users/nibanks/repos","events_url":"https://api.github.com/users/nibanks/events{/privacy}","received_events_url":"https://api.github.com/users/nibanks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nibanks/openthread","description":"OpenThread released by Nest is an open-source implementation of the Thread networking protocol","fork":true,"url":"https://api.github.com/repos/nibanks/openthread","forks_url":"https://api.github.com/repos/nibanks/openthread/forks","keys_url":"https://api.github.com/repos/nibanks/openthread/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nibanks/openthread/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nibanks/openthread/teams","hooks_url":"https://api.github.com/repos/nibanks/openthread/hooks","issue_events_url":"https://api.github.com/repos/nibanks/openthread/issues/events{/number}","events_url":"https://api.github.com/repos/nibanks/openthread/events","assignees_url":"https://api.github.com/repos/nibanks/openthread/assignees{/user}","branches_url":"https://api.github.com/repos/nibanks/openthread/branches{/branch}","tags_url":"https://api.github.com/repos/nibanks/openthread/tags","blobs_url":"https://api.github.com/repos/nibanks/openthread/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nibanks/openthread/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nibanks/openthread/git/refs{/sha}","trees_url":"https://api.github.com/repos/nibanks/openthread/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nibanks/openthread/statuses/{sha}","languages_url":"https://api.github.com/repos/nibanks/openthread/languages","stargazers_url":"https://api.github.com/repos/nibanks/openthread/stargazers","contributors_url":"https://api.github.com/repos/nibanks/openthread/contributors","subscribers_url":"https://api.github.com/repos/nibanks/openthread/subscribers","subscription_url":"https://api.github.com/repos/nibanks/openthread/subscription","commits_url":"https://api.github.com/repos/nibanks/openthread/commits{/sha}","git_commits_url":"https://api.github.com/repos/nibanks/openthread/git/commits{/sha}","comments_url":"https://api.github.com/repos/nibanks/openthread/comments{/number}","issue_comment_url":"https://api.github.com/repos/nibanks/openthread/issues/comments{/number}","contents_url":"https://api.github.com/repos/nibanks/openthread/contents/{+path}","compare_url":"https://api.github.com/repos/nibanks/openthread/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nibanks/openthread/merges","archive_url":"https://api.github.com/repos/nibanks/openthread/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nibanks/openthread/downloads","issues_url":"https://api.github.com/repos/nibanks/openthread/issues{/number}","pulls_url":"https://api.github.com/repos/nibanks/openthread/pulls{/number}","milestones_url":"https://api.github.com/repos/nibanks/openthread/milestones{/number}","notifications_url":"https://api.github.com/repos/nibanks/openthread/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nibanks/openthread/labels{/name}","releases_url":"https://api.github.com/repos/nibanks/openthread/releases{/id}","deployments_url":"https://api.github.com/repos/nibanks/openthread/deployments","created_at":"2016-08-05T22:20:17Z","updated_at":"2016-11-02T15:52:00Z","pushed_at":"2016-12-06T21:13:15Z","git_url":"git://github.com/nibanks/openthread.git","ssh_url":"git@github.com:nibanks/openthread.git","clone_url":"https://github.com/nibanks/openthread.git","svn_url":"https://github.com/nibanks/openthread","homepage":"","size":277384,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openthread:master","ref":"master","sha":"28fa90b1ce6f3a67f6aa736999032c6e2fc5f257","user":{"login":"openthread","id":16142269,"avatar_url":"https://avatars.githubusercontent.com/u/16142269?v=3","gravatar_id":"","url":"https://api.github.com/users/openthread","html_url":"https://github.com/openthread","followers_url":"https://api.github.com/users/openthread/followers","following_url":"https://api.github.com/users/openthread/following{/other_user}","gists_url":"https://api.github.com/users/openthread/gists{/gist_id}","starred_url":"https://api.github.com/users/openthread/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openthread/subscriptions","organizations_url":"https://api.github.com/users/openthread/orgs","repos_url":"https://api.github.com/users/openthread/repos","events_url":"https://api.github.com/users/openthread/events{/privacy}","received_events_url":"https://api.github.com/users/openthread/received_events","type":"Organization","site_admin":false},"repo":{"id":55808787,"name":"openthread","full_name":"openthread/openthread","owner":{"login":"openthread","id":16142269,"avatar_url":"https://avatars.githubusercontent.com/u/16142269?v=3","gravatar_id":"","url":"https://api.github.com/users/openthread","html_url":"https://github.com/openthread","followers_url":"https://api.github.com/users/openthread/followers","following_url":"https://api.github.com/users/openthread/following{/other_user}","gists_url":"https://api.github.com/users/openthread/gists{/gist_id}","starred_url":"https://api.github.com/users/openthread/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openthread/subscriptions","organizations_url":"https://api.github.com/users/openthread/orgs","repos_url":"https://api.github.com/users/openthread/repos","events_url":"https://api.github.com/users/openthread/events{/privacy}","received_events_url":"https://api.github.com/users/openthread/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openthread/openthread","description":"OpenThread released by Nest is an open-source implementation of the Thread networking protocol","fork":false,"url":"https://api.github.com/repos/openthread/openthread","forks_url":"https://api.github.com/repos/openthread/openthread/forks","keys_url":"https://api.github.com/repos/openthread/openthread/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openthread/openthread/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openthread/openthread/teams","hooks_url":"https://api.github.com/repos/openthread/openthread/hooks","issue_events_url":"https://api.github.com/repos/openthread/openthread/issues/events{/number}","events_url":"https://api.github.com/repos/openthread/openthread/events","assignees_url":"https://api.github.com/repos/openthread/openthread/assignees{/user}","branches_url":"https://api.github.com/repos/openthread/openthread/branches{/branch}","tags_url":"https://api.github.com/repos/openthread/openthread/tags","blobs_url":"https://api.github.com/repos/openthread/openthread/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openthread/openthread/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openthread/openthread/git/refs{/sha}","trees_url":"https://api.github.com/repos/openthread/openthread/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openthread/openthread/statuses/{sha}","languages_url":"https://api.github.com/repos/openthread/openthread/languages","stargazers_url":"https://api.github.com/repos/openthread/openthread/stargazers","contributors_url":"https://api.github.com/repos/openthread/openthread/contributors","subscribers_url":"https://api.github.com/repos/openthread/openthread/subscribers","subscription_url":"https://api.github.com/repos/openthread/openthread/subscription","commits_url":"https://api.github.com/repos/openthread/openthread/commits{/sha}","git_commits_url":"https://api.github.com/repos/openthread/openthread/git/commits{/sha}","comments_url":"https://api.github.com/repos/openthread/openthread/comments{/number}","issue_comment_url":"https://api.github.com/repos/openthread/openthread/issues/comments{/number}","contents_url":"https://api.github.com/repos/openthread/openthread/contents/{+path}","compare_url":"https://api.github.com/repos/openthread/openthread/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openthread/openthread/merges","archive_url":"https://api.github.com/repos/openthread/openthread/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openthread/openthread/downloads","issues_url":"https://api.github.com/repos/openthread/openthread/issues{/number}","pulls_url":"https://api.github.com/repos/openthread/openthread/pulls{/number}","milestones_url":"https://api.github.com/repos/openthread/openthread/milestones{/number}","notifications_url":"https://api.github.com/repos/openthread/openthread/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openthread/openthread/labels{/name}","releases_url":"https://api.github.com/repos/openthread/openthread/releases{/id}","deployments_url":"https://api.github.com/repos/openthread/openthread/deployments","created_at":"2016-04-08T20:47:41Z","updated_at":"2016-12-07T14:18:01Z","pushed_at":"2016-12-07T16:54:43Z","git_url":"git://github.com/openthread/openthread.git","ssh_url":"git@github.com:openthread/openthread.git","clone_url":"https://github.com/openthread/openthread.git","svn_url":"https://github.com/openthread/openthread","homepage":"","size":566040,"stargazers_count":1048,"watchers_count":1048,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":243,"mirror_url":null,"open_issues_count":35,"forks":243,"open_issues":35,"watchers":1048,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openthread/openthread/pulls/1004"},"html":{"href":"https://github.com/openthread/openthread/pull/1004"},"issue":{"href":"https://api.github.com/repos/openthread/openthread/issues/1004"},"comments":{"href":"https://api.github.com/repos/openthread/openthread/issues/1004/comments"},"review_comments":{"href":"https://api.github.com/repos/openthread/openthread/pulls/1004/comments"},"review_comment":{"href":"https://api.github.com/repos/openthread/openthread/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openthread/openthread/pulls/1004/commits"},"statuses":{"href":"https://api.github.com/repos/openthread/openthread/statuses/d07082a489358aa23a09ad66f752c1302228cc7c"}}}}
{"actor":{"display_login":"nibanks"}}