{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments/74648752","id":74648752,"diff_hunk":"@@ -54,6 +54,10 @@ angular.module(\"openshiftConsole\")\n               .value();\n     };\n \n+    var setDependencies = function(service, dependencies) {\n+      _.set(service, ['metadata', 'annotations', DEPENDENCIES], JSON.stringify(dependencies));","path":"app/scripts/services/services.js","position":14,"original_position":14,"commit_id":"02b842752367ccde4a2178a051643dff8ee40ab9","original_commit_id":"02b842752367ccde4a2178a051643dff8ee40ab9","user":{"login":"jwforres","id":1467629,"avatar_url":"https://avatars.githubusercontent.com/u/1467629?v=3","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"body":"when the dependencies array is empty should we remove the annotation completely","created_at":"2016-08-12T19:35:20Z","updated_at":"2016-08-12T19:35:20Z","html_url":"https://github.com/openshift/origin-web-console/pull/360#discussion_r74648752","pull_request_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/360","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments/74648752"},"html":{"href":"https://github.com/openshift/origin-web-console/pull/360#discussion_r74648752"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/360"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/360","id":81159539,"html_url":"https://github.com/openshift/origin-web-console/pull/360","diff_url":"https://github.com/openshift/origin-web-console/pull/360.diff","patch_url":"https://github.com/openshift/origin-web-console/pull/360.patch","issue_url":"https://api.github.com/repos/openshift/origin-web-console/issues/360","number":360,"state":"open","locked":false,"title":"Better service grouping","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"Allow users to add more than one dependent service on the overview and easily remove services from groups.\r\n\r\nLink and unlink buttons:\r\n\r\n![openshift_web_console](https://cloud.githubusercontent.com/assets/1167259/17632405/25a39234-6096-11e6-8b68-06dbbe6b263d.png)\r\n\r\nRemove confirmation dialog:\r\n\r\n![openshift_web_console](https://cloud.githubusercontent.com/assets/1167259/17632416/30307f78-6096-11e6-9593-e6998ca48c08.png)\r\n\r\nLink button for A/B services:\r\n\r\n![openshift_web_console](https://cloud.githubusercontent.com/assets/1167259/17632456/5678fa3e-6096-11e6-8d48-cd0950178aa7.png)\r\n\r\nFixes #103\r\n\r\n@jwforres PTAL","created_at":"2016-08-12T18:09:28Z","updated_at":"2016-08-12T19:35:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f91eb4ddb986de2f89864fdada84740b2ce8873e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/360/commits","review_comments_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/360/comments","review_comment_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/issues/360/comments","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/02b842752367ccde4a2178a051643dff8ee40ab9","head":{"label":"spadgett:overview-service-grouping","ref":"overview-service-grouping","sha":"02b842752367ccde4a2178a051643dff8ee40ab9","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"repo":{"id":58545409,"name":"origin-web-console","full_name":"spadgett/origin-web-console","owner":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spadgett/origin-web-console","description":"","fork":true,"url":"https://api.github.com/repos/spadgett/origin-web-console","forks_url":"https://api.github.com/repos/spadgett/origin-web-console/forks","keys_url":"https://api.github.com/repos/spadgett/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spadgett/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spadgett/origin-web-console/teams","hooks_url":"https://api.github.com/repos/spadgett/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/spadgett/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/spadgett/origin-web-console/events","assignees_url":"https://api.github.com/repos/spadgett/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/spadgett/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/spadgett/origin-web-console/tags","blobs_url":"https://api.github.com/repos/spadgett/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spadgett/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spadgett/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/spadgett/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spadgett/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/spadgett/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/spadgett/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/spadgett/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/spadgett/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/spadgett/origin-web-console/subscription","commits_url":"https://api.github.com/repos/spadgett/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/spadgett/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/spadgett/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/spadgett/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/spadgett/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/spadgett/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spadgett/origin-web-console/merges","archive_url":"https://api.github.com/repos/spadgett/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spadgett/origin-web-console/downloads","issues_url":"https://api.github.com/repos/spadgett/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/spadgett/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/spadgett/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/spadgett/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spadgett/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/spadgett/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/spadgett/origin-web-console/deployments","created_at":"2016-05-11T13:03:37Z","updated_at":"2016-05-11T13:03:40Z","pushed_at":"2016-08-12T19:28:16Z","git_url":"git://github.com/spadgett/origin-web-console.git","ssh_url":"git@github.com:spadgett/origin-web-console.git","clone_url":"https://github.com/spadgett/origin-web-console.git","svn_url":"https://github.com/spadgett/origin-web-console","homepage":null,"size":9663,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"0980e0f552a223a7eba3951a68c9faa6188ef858","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":58488264,"name":"origin-web-console","full_name":"openshift/origin-web-console","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin-web-console","description":"","fork":false,"url":"https://api.github.com/repos/openshift/origin-web-console","forks_url":"https://api.github.com/repos/openshift/origin-web-console/forks","keys_url":"https://api.github.com/repos/openshift/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin-web-console/teams","hooks_url":"https://api.github.com/repos/openshift/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin-web-console/events","assignees_url":"https://api.github.com/repos/openshift/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin-web-console/tags","blobs_url":"https://api.github.com/repos/openshift/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/openshift/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin-web-console/subscription","commits_url":"https://api.github.com/repos/openshift/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin-web-console/merges","archive_url":"https://api.github.com/repos/openshift/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin-web-console/downloads","issues_url":"https://api.github.com/repos/openshift/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin-web-console/deployments","created_at":"2016-05-10T19:31:50Z","updated_at":"2016-08-05T20:43:27Z","pushed_at":"2016-08-12T19:34:33Z","git_url":"git://github.com/openshift/origin-web-console.git","ssh_url":"git@github.com:openshift/origin-web-console.git","clone_url":"https://github.com/openshift/origin-web-console.git","svn_url":"https://github.com/openshift/origin-web-console","homepage":null,"size":10145,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":64,"forks":37,"open_issues":64,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/360"},"html":{"href":"https://github.com/openshift/origin-web-console/pull/360"},"issue":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/360"},"comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/360/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/360/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/360/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin-web-console/statuses/02b842752367ccde4a2178a051643dff8ee40ab9"}}}}
{"actor":{"display_login":"jwforres"}}