{"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/85792785","pull_request_review_id":6487055,"id":85792785,"diff_hunk":"@@ -2729,29 +2690,29 @@ def c_code(self, node, nodename, inp, out, sub):\n             || (CudaNdarray_HOST_DIMS(%(gz)s)[3] !=\n                 CudaNdarray_HOST_DIMS(%(z)s)[3]))\n         {\n+            // init with zeros\n+            // for st larger than ds some pixels in the input will be skipped\n             Py_XDECREF(%(gz)s);\n-            %(gz)s = (CudaNdarray*)CudaNdarray_New();\n-            if ((NULL == %(gz)s)\n-                || CudaNdarray_alloc_contiguous(%(gz)s, 4,\n-                                                CudaNdarray_HOST_DIMS(%(z)s)))\n+            %(gz)s = (CudaNdarray*)CudaNdarray_ZEROS(4, (int*)CudaNdarray_HOST_DIMS(%(z)s));","path":"theano/sandbox/cuda/blas.py","position":346,"original_position":346,"commit_id":"0b6f0585a953c7b7f526b6c74eca8eacddaac72d","original_commit_id":"0b6f0585a953c7b7f526b6c74eca8eacddaac72d","user":{"login":"nouiz","id":180987,"avatar_url":"https://avatars.githubusercontent.com/u/180987?v=3","gravatar_id":"","url":"https://api.github.com/users/nouiz","html_url":"https://github.com/nouiz","followers_url":"https://api.github.com/users/nouiz/followers","following_url":"https://api.github.com/users/nouiz/following{/other_user}","gists_url":"https://api.github.com/users/nouiz/gists{/gist_id}","starred_url":"https://api.github.com/users/nouiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nouiz/subscriptions","organizations_url":"https://api.github.com/users/nouiz/orgs","repos_url":"https://api.github.com/users/nouiz/repos","events_url":"https://api.github.com/users/nouiz/events{/privacy}","received_events_url":"https://api.github.com/users/nouiz/received_events","type":"User","site_admin":false},"body":"idem, call ZEROS only if needed to prevent slowdown compared to current code.","created_at":"2016-10-31T17:44:18Z","updated_at":"2016-10-31T17:46:49Z","html_url":"https://github.com/Theano/Theano/pull/5157#discussion_r85792785","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/5157","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/85792785"},"html":{"href":"https://github.com/Theano/Theano/pull/5157#discussion_r85792785"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5157"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/5157","id":91525824,"html_url":"https://github.com/Theano/Theano/pull/5157","diff_url":"https://github.com/Theano/Theano/pull/5157.diff","patch_url":"https://github.com/Theano/Theano/pull/5157.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/5157","number":5157,"state":"open","locked":false,"title":"Cuda pooling with strides","user":{"login":"aam-at","id":486336,"avatar_url":"https://avatars.githubusercontent.com/u/486336?v=3","gravatar_id":"","url":"https://api.github.com/users/aam-at","html_url":"https://github.com/aam-at","followers_url":"https://api.github.com/users/aam-at/followers","following_url":"https://api.github.com/users/aam-at/following{/other_user}","gists_url":"https://api.github.com/users/aam-at/gists{/gist_id}","starred_url":"https://api.github.com/users/aam-at/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aam-at/subscriptions","organizations_url":"https://api.github.com/users/aam-at/orgs","repos_url":"https://api.github.com/users/aam-at/repos","events_url":"https://api.github.com/users/aam-at/events{/privacy}","received_events_url":"https://api.github.com/users/aam-at/received_events","type":"User","site_admin":false},"body":"Add strides support for cuda pooling.\n","created_at":"2016-10-30T15:52:43Z","updated_at":"2016-10-31T17:46:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88f1984d359e5886292b7288395165411f0c9172","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/5157/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/5157/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/5157/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/0b6f0585a953c7b7f526b6c74eca8eacddaac72d","head":{"label":"aam-at:cuda_pooling_with_strides","ref":"cuda_pooling_with_strides","sha":"0b6f0585a953c7b7f526b6c74eca8eacddaac72d","user":{"login":"aam-at","id":486336,"avatar_url":"https://avatars.githubusercontent.com/u/486336?v=3","gravatar_id":"","url":"https://api.github.com/users/aam-at","html_url":"https://github.com/aam-at","followers_url":"https://api.github.com/users/aam-at/followers","following_url":"https://api.github.com/users/aam-at/following{/other_user}","gists_url":"https://api.github.com/users/aam-at/gists{/gist_id}","starred_url":"https://api.github.com/users/aam-at/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aam-at/subscriptions","organizations_url":"https://api.github.com/users/aam-at/orgs","repos_url":"https://api.github.com/users/aam-at/repos","events_url":"https://api.github.com/users/aam-at/events{/privacy}","received_events_url":"https://api.github.com/users/aam-at/received_events","type":"User","site_admin":false},"repo":{"id":72220883,"name":"Theano","full_name":"aam-at/Theano","owner":{"login":"aam-at","id":486336,"avatar_url":"https://avatars.githubusercontent.com/u/486336?v=3","gravatar_id":"","url":"https://api.github.com/users/aam-at","html_url":"https://github.com/aam-at","followers_url":"https://api.github.com/users/aam-at/followers","following_url":"https://api.github.com/users/aam-at/following{/other_user}","gists_url":"https://api.github.com/users/aam-at/gists{/gist_id}","starred_url":"https://api.github.com/users/aam-at/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aam-at/subscriptions","organizations_url":"https://api.github.com/users/aam-at/orgs","repos_url":"https://api.github.com/users/aam-at/repos","events_url":"https://api.github.com/users/aam-at/events{/privacy}","received_events_url":"https://api.github.com/users/aam-at/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aam-at/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":true,"url":"https://api.github.com/repos/aam-at/Theano","forks_url":"https://api.github.com/repos/aam-at/Theano/forks","keys_url":"https://api.github.com/repos/aam-at/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aam-at/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aam-at/Theano/teams","hooks_url":"https://api.github.com/repos/aam-at/Theano/hooks","issue_events_url":"https://api.github.com/repos/aam-at/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/aam-at/Theano/events","assignees_url":"https://api.github.com/repos/aam-at/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/aam-at/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/aam-at/Theano/tags","blobs_url":"https://api.github.com/repos/aam-at/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aam-at/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aam-at/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/aam-at/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aam-at/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/aam-at/Theano/languages","stargazers_url":"https://api.github.com/repos/aam-at/Theano/stargazers","contributors_url":"https://api.github.com/repos/aam-at/Theano/contributors","subscribers_url":"https://api.github.com/repos/aam-at/Theano/subscribers","subscription_url":"https://api.github.com/repos/aam-at/Theano/subscription","commits_url":"https://api.github.com/repos/aam-at/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/aam-at/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/aam-at/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/aam-at/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/aam-at/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/aam-at/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aam-at/Theano/merges","archive_url":"https://api.github.com/repos/aam-at/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aam-at/Theano/downloads","issues_url":"https://api.github.com/repos/aam-at/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/aam-at/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/aam-at/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/aam-at/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aam-at/Theano/labels{/name}","releases_url":"https://api.github.com/repos/aam-at/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/aam-at/Theano/deployments","created_at":"2016-10-28T15:48:03Z","updated_at":"2016-10-28T15:48:07Z","pushed_at":"2016-10-31T17:42:30Z","git_url":"git://github.com/aam-at/Theano.git","ssh_url":"git@github.com:aam-at/Theano.git","clone_url":"https://github.com/aam-at/Theano.git","svn_url":"https://github.com/aam-at/Theano","homepage":"http://www.deeplearning.net/software/theano","size":60235,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"b69495303b241ac52a8b648f93b689af889025c8","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/Theano/Theano/deployments","created_at":"2011-08-10T03:48:06Z","updated_at":"2016-10-31T15:45:29Z","pushed_at":"2016-10-31T17:42:31Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":79825,"stargazers_count":4876,"watchers_count":4876,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1727,"mirror_url":null,"open_issues_count":738,"forks":1727,"open_issues":738,"watchers":4876,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5157"},"html":{"href":"https://github.com/Theano/Theano/pull/5157"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/5157"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/5157/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5157/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5157/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/0b6f0585a953c7b7f526b6c74eca8eacddaac72d"}}}}
{"actor":{"display_login":"nouiz"}}