{"action":"created","comment":{"url":"https://api.github.com/repos/contiv/netplugin/pulls/comments/52099595","id":52099595,"diff_hunk":"@@ -432,8 +432,8 @@ func (d *OvsDriver) DeleteMaster(node core.ServiceInfo) error {\n \treturn nil\n }\n \n-// AddBgpNeighbors adds bgp neighbor by named identifier\n-func (d *OvsDriver) AddBgpNeighbors(id string) error {\n+// AddBgp adds bgp config by named identifier\n+func (d *OvsDriver) AddBgp(id string) error {","path":"drivers/ovsdriver.go","position":16,"original_position":16,"commit_id":"f9b2b2974f047dcf088305e3768040e0c77f109c","original_commit_id":"f9b2b2974f047dcf088305e3768040e0c77f109c","user":{"login":"jainvipin","id":9005681,"avatar_url":"https://avatars.githubusercontent.com/u/9005681?v=3","gravatar_id":"","url":"https://api.github.com/users/jainvipin","html_url":"https://github.com/jainvipin","followers_url":"https://api.github.com/users/jainvipin/followers","following_url":"https://api.github.com/users/jainvipin/following{/other_user}","gists_url":"https://api.github.com/users/jainvipin/gists{/gist_id}","starred_url":"https://api.github.com/users/jainvipin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jainvipin/subscriptions","organizations_url":"https://api.github.com/users/jainvipin/orgs","repos_url":"https://api.github.com/users/jainvipin/repos","events_url":"https://api.github.com/users/jainvipin/events{/privacy}","received_events_url":"https://api.github.com/users/jainvipin/received_events","type":"User","site_admin":false},"body":"I see; then the question really is if someone uses non ovs (i.e. non ofnet), would we need any part of the protocol server outside (not in ofnet), we can take this discussion offline perhaps as we discuss the changes needed for other drivers.\r\n\r\n> @jainvipin AddBgp would instantiate a protocol server in ofnet only on vlan mode.So we have to pipe it to the right ofnetAgent for this to happen. In addition to this it will create loopback interface, add bgp endpoints etc.","created_at":"2016-02-06T08:16:00Z","updated_at":"2016-02-06T08:16:00Z","html_url":"https://github.com/contiv/netplugin/pull/265#discussion_r52099595","pull_request_url":"https://api.github.com/repos/contiv/netplugin/pulls/265","_links":{"self":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/comments/52099595"},"html":{"href":"https://github.com/contiv/netplugin/pull/265#discussion_r52099595"},"pull_request":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/265"}}},"pull_request":{"url":"https://api.github.com/repos/contiv/netplugin/pulls/265","id":58099046,"html_url":"https://github.com/contiv/netplugin/pull/265","diff_url":"https://github.com/contiv/netplugin/pull/265.diff","patch_url":"https://github.com/contiv/netplugin/pull/265.patch","issue_url":"https://api.github.com/repos/contiv/netplugin/issues/265","number":265,"state":"open","locked":false,"title":"netctl cli to take in router ip ","user":{"login":"abhinandanpb","id":784144,"avatar_url":"https://avatars.githubusercontent.com/u/784144?v=3","gravatar_id":"","url":"https://api.github.com/users/abhinandanpb","html_url":"https://github.com/abhinandanpb","followers_url":"https://api.github.com/users/abhinandanpb/followers","following_url":"https://api.github.com/users/abhinandanpb/following{/other_user}","gists_url":"https://api.github.com/users/abhinandanpb/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinandanpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinandanpb/subscriptions","organizations_url":"https://api.github.com/users/abhinandanpb/orgs","repos_url":"https://api.github.com/users/abhinandanpb/repos","events_url":"https://api.github.com/users/abhinandanpb/events{/privacy}","received_events_url":"https://api.github.com/users/abhinandanpb/received_events","type":"User","site_admin":false},"body":"The changes contain:\r\n1) Changes to netctl cli to take in router ip and as as additional parameters\r\n2) This would mean there is only 1 bgp config cli to be used to configure L3 mode.\r\n3) decoupled bgp server start from netplugin start and tied it to the cli.\r\n4) This wil ensure bgp config can be changed dynamically even after containers come up . \r\n\r\nnew cli  netctl bgp create <hostname> -router-ip=<> -as=<> -neighbor-ip=<> neighbor-as=<>\r\n \r\n","created_at":"2016-02-03T07:05:17Z","updated_at":"2016-02-06T08:16:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"298ce3d45e72f8502cb4ead7f66f1c80e2ab95a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/contiv/netplugin/pulls/265/commits","review_comments_url":"https://api.github.com/repos/contiv/netplugin/pulls/265/comments","review_comment_url":"https://api.github.com/repos/contiv/netplugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contiv/netplugin/issues/265/comments","statuses_url":"https://api.github.com/repos/contiv/netplugin/statuses/f9b2b2974f047dcf088305e3768040e0c77f109c","head":{"label":"abhinandanpb:bgp","ref":"bgp","sha":"f9b2b2974f047dcf088305e3768040e0c77f109c","user":{"login":"abhinandanpb","id":784144,"avatar_url":"https://avatars.githubusercontent.com/u/784144?v=3","gravatar_id":"","url":"https://api.github.com/users/abhinandanpb","html_url":"https://github.com/abhinandanpb","followers_url":"https://api.github.com/users/abhinandanpb/followers","following_url":"https://api.github.com/users/abhinandanpb/following{/other_user}","gists_url":"https://api.github.com/users/abhinandanpb/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinandanpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinandanpb/subscriptions","organizations_url":"https://api.github.com/users/abhinandanpb/orgs","repos_url":"https://api.github.com/users/abhinandanpb/repos","events_url":"https://api.github.com/users/abhinandanpb/events{/privacy}","received_events_url":"https://api.github.com/users/abhinandanpb/received_events","type":"User","site_admin":false},"repo":{"id":41694102,"name":"netplugin","full_name":"abhinandanpb/netplugin","owner":{"login":"abhinandanpb","id":784144,"avatar_url":"https://avatars.githubusercontent.com/u/784144?v=3","gravatar_id":"","url":"https://api.github.com/users/abhinandanpb","html_url":"https://github.com/abhinandanpb","followers_url":"https://api.github.com/users/abhinandanpb/followers","following_url":"https://api.github.com/users/abhinandanpb/following{/other_user}","gists_url":"https://api.github.com/users/abhinandanpb/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinandanpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinandanpb/subscriptions","organizations_url":"https://api.github.com/users/abhinandanpb/orgs","repos_url":"https://api.github.com/users/abhinandanpb/repos","events_url":"https://api.github.com/users/abhinandanpb/events{/privacy}","received_events_url":"https://api.github.com/users/abhinandanpb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abhinandanpb/netplugin","description":"(experimental) network plugin framework for container based environments","fork":true,"url":"https://api.github.com/repos/abhinandanpb/netplugin","forks_url":"https://api.github.com/repos/abhinandanpb/netplugin/forks","keys_url":"https://api.github.com/repos/abhinandanpb/netplugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abhinandanpb/netplugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abhinandanpb/netplugin/teams","hooks_url":"https://api.github.com/repos/abhinandanpb/netplugin/hooks","issue_events_url":"https://api.github.com/repos/abhinandanpb/netplugin/issues/events{/number}","events_url":"https://api.github.com/repos/abhinandanpb/netplugin/events","assignees_url":"https://api.github.com/repos/abhinandanpb/netplugin/assignees{/user}","branches_url":"https://api.github.com/repos/abhinandanpb/netplugin/branches{/branch}","tags_url":"https://api.github.com/repos/abhinandanpb/netplugin/tags","blobs_url":"https://api.github.com/repos/abhinandanpb/netplugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abhinandanpb/netplugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abhinandanpb/netplugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/abhinandanpb/netplugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abhinandanpb/netplugin/statuses/{sha}","languages_url":"https://api.github.com/repos/abhinandanpb/netplugin/languages","stargazers_url":"https://api.github.com/repos/abhinandanpb/netplugin/stargazers","contributors_url":"https://api.github.com/repos/abhinandanpb/netplugin/contributors","subscribers_url":"https://api.github.com/repos/abhinandanpb/netplugin/subscribers","subscription_url":"https://api.github.com/repos/abhinandanpb/netplugin/subscription","commits_url":"https://api.github.com/repos/abhinandanpb/netplugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/abhinandanpb/netplugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/abhinandanpb/netplugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/abhinandanpb/netplugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/abhinandanpb/netplugin/contents/{+path}","compare_url":"https://api.github.com/repos/abhinandanpb/netplugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abhinandanpb/netplugin/merges","archive_url":"https://api.github.com/repos/abhinandanpb/netplugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abhinandanpb/netplugin/downloads","issues_url":"https://api.github.com/repos/abhinandanpb/netplugin/issues{/number}","pulls_url":"https://api.github.com/repos/abhinandanpb/netplugin/pulls{/number}","milestones_url":"https://api.github.com/repos/abhinandanpb/netplugin/milestones{/number}","notifications_url":"https://api.github.com/repos/abhinandanpb/netplugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abhinandanpb/netplugin/labels{/name}","releases_url":"https://api.github.com/repos/abhinandanpb/netplugin/releases{/id}","deployments_url":"https://api.github.com/repos/abhinandanpb/netplugin/deployments","created_at":"2015-08-31T18:51:24Z","updated_at":"2015-08-31T18:51:25Z","pushed_at":"2016-02-06T04:19:37Z","git_url":"git://github.com/abhinandanpb/netplugin.git","ssh_url":"git@github.com:abhinandanpb/netplugin.git","clone_url":"https://github.com/abhinandanpb/netplugin.git","svn_url":"https://github.com/abhinandanpb/netplugin","homepage":"","size":15238,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"contiv:master","ref":"master","sha":"d259c17b8b50c7ccd6b8f710cc420b862d216ea2","user":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"repo":{"id":28353322,"name":"netplugin","full_name":"contiv/netplugin","owner":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contiv/netplugin","description":"Container networking for various use cases","fork":false,"url":"https://api.github.com/repos/contiv/netplugin","forks_url":"https://api.github.com/repos/contiv/netplugin/forks","keys_url":"https://api.github.com/repos/contiv/netplugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiv/netplugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiv/netplugin/teams","hooks_url":"https://api.github.com/repos/contiv/netplugin/hooks","issue_events_url":"https://api.github.com/repos/contiv/netplugin/issues/events{/number}","events_url":"https://api.github.com/repos/contiv/netplugin/events","assignees_url":"https://api.github.com/repos/contiv/netplugin/assignees{/user}","branches_url":"https://api.github.com/repos/contiv/netplugin/branches{/branch}","tags_url":"https://api.github.com/repos/contiv/netplugin/tags","blobs_url":"https://api.github.com/repos/contiv/netplugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiv/netplugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiv/netplugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiv/netplugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiv/netplugin/statuses/{sha}","languages_url":"https://api.github.com/repos/contiv/netplugin/languages","stargazers_url":"https://api.github.com/repos/contiv/netplugin/stargazers","contributors_url":"https://api.github.com/repos/contiv/netplugin/contributors","subscribers_url":"https://api.github.com/repos/contiv/netplugin/subscribers","subscription_url":"https://api.github.com/repos/contiv/netplugin/subscription","commits_url":"https://api.github.com/repos/contiv/netplugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiv/netplugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiv/netplugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiv/netplugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiv/netplugin/contents/{+path}","compare_url":"https://api.github.com/repos/contiv/netplugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiv/netplugin/merges","archive_url":"https://api.github.com/repos/contiv/netplugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiv/netplugin/downloads","issues_url":"https://api.github.com/repos/contiv/netplugin/issues{/number}","pulls_url":"https://api.github.com/repos/contiv/netplugin/pulls{/number}","milestones_url":"https://api.github.com/repos/contiv/netplugin/milestones{/number}","notifications_url":"https://api.github.com/repos/contiv/netplugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiv/netplugin/labels{/name}","releases_url":"https://api.github.com/repos/contiv/netplugin/releases{/id}","deployments_url":"https://api.github.com/repos/contiv/netplugin/deployments","created_at":"2014-12-22T18:45:21Z","updated_at":"2016-02-06T03:22:55Z","pushed_at":"2016-02-06T06:44:14Z","git_url":"git://github.com/contiv/netplugin.git","ssh_url":"git@github.com:contiv/netplugin.git","clone_url":"https://github.com/contiv/netplugin.git","svn_url":"https://github.com/contiv/netplugin","homepage":"","size":14274,"stargazers_count":73,"watchers_count":73,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":49,"forks":34,"open_issues":49,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/265"},"html":{"href":"https://github.com/contiv/netplugin/pull/265"},"issue":{"href":"https://api.github.com/repos/contiv/netplugin/issues/265"},"comments":{"href":"https://api.github.com/repos/contiv/netplugin/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contiv/netplugin/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/contiv/netplugin/statuses/f9b2b2974f047dcf088305e3768040e0c77f109c"}}}}