{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/foreman/issues/4107","repository_url":"https://api.github.com/repos/theforeman/foreman","labels_url":"https://api.github.com/repos/theforeman/foreman/issues/4107/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/4107/comments","events_url":"https://api.github.com/repos/theforeman/foreman/issues/4107/events","html_url":"https://github.com/theforeman/foreman/pull/4107","id":195268119,"number":4107,"title":"refs #17485 - use IP within host's primary subnet","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"labels":[{"id":79040689,"url":"https://api.github.com/repos/theforeman/foreman/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false},{"id":79040085,"url":"https://api.github.com/repos/theforeman/foreman/labels/Not%20yet%20reviewed","name":"Not yet reviewed","color":"009800","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-13T14:32:47Z","updated_at":"2016-12-13T18:26:19Z","closed_at":"2016-12-13T18:26:17Z","pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/4107","html_url":"https://github.com/theforeman/foreman/pull/4107","diff_url":"https://github.com/theforeman/foreman/pull/4107.diff","patch_url":"https://github.com/theforeman/foreman/pull/4107.patch"},"body":"The host factory with the given trait overrides the primary interface's\r\nsubnet, so pass in the subnet being used to prevent the override.\r\n\r\n---\r\n\r\nFixes test failure from edadebee981e41bbcd75bda75e32e122cb3f8b3e on develop (http://ci.theforeman.org/job/test_develop/2555/):\r\n\r\n<pre>\r\nTFTPOrchestrationTest::host with bond interface.test_0001_#setTFTP should provision tftp for all bond child macs (from TFTPOrchestrationTest__host with bond interface) \r\nActiveRecord::RecordInvalid: Validation failed: Ip does not match selected subnet\r\n    test_after_commit (1.1.0) lib/test_after_commit/database_statements.rb:11:in `block in transaction'\r\n    test_after_commit (1.1.0) lib/test_after_commit/database_statements.rb:5:in `transaction'\r\n    test/models/orchestration/tftp_test.rb:154:in `block (2 levels) in &lt;class:TFTPOrchestrationTest>'\r\n    test/models/orchestration/tftp_test.rb:171:in `block (2 levels) in &lt;class:TFTPOrchestrationTest>' (ActiveRecord::RecordInvalid)\r\n/usr/local/rvm/gems/ruby-2.2.5@test_develop-1/gems/activerecord-4.2.7.1/lib/active_record/validations.rb:43    \r\n</pre>"},"comment":{"url":"https://api.github.com/repos/theforeman/foreman/issues/comments/266819918","html_url":"https://github.com/theforeman/foreman/pull/4107#issuecomment-266819918","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/4107","id":266819918,"user":{"login":"dLobatog","id":598891,"avatar_url":"https://avatars.githubusercontent.com/u/598891?v=3","gravatar_id":"","url":"https://api.github.com/users/dLobatog","html_url":"https://github.com/dLobatog","followers_url":"https://api.github.com/users/dLobatog/followers","following_url":"https://api.github.com/users/dLobatog/following{/other_user}","gists_url":"https://api.github.com/users/dLobatog/gists{/gist_id}","starred_url":"https://api.github.com/users/dLobatog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dLobatog/subscriptions","organizations_url":"https://api.github.com/users/dLobatog/orgs","repos_url":"https://api.github.com/users/dLobatog/repos","events_url":"https://api.github.com/users/dLobatog/events{/privacy}","received_events_url":"https://api.github.com/users/dLobatog/received_events","type":"User","site_admin":false},"created_at":"2016-12-13T18:26:19Z","updated_at":"2016-12-13T18:26:19Z","body":"Thanks @domcleal !"}}
{"actor":{"display_login":"dLobatog"}}