{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaDB/MySQL.jl/pulls/comments/83617975","pull_request_review_id":4448933,"id":83617975,"diff_hunk":"@@ -35,13 +35,13 @@ function mysql_connect(host::AbstractString,\n end\n \n \"\"\"\n-    mysql_connect(host::AbstractString, user::AbstractString, passwd::AbstractString, db::AbstractString = \"\"; opts = Dict())\n+    mysql_connect(host::AbstractString, user::AbstractString, passwd::AbstractString, db::AbstractString = \"\"; port::Int64 = 3306, socket::AbstractString = \"/var/run/mysqld/mysqld.sock\", opts = Dict())\n \n Connect to a MySQL database.\n \"\"\"\n-function mysql_connect(host, user, passwd, db=\"\"; opts = Dict())\n-    return mysql_connect(host, user, passwd, db, convert(Cuint, 0),\n-                         convert(Ptr{Cchar}, C_NULL), CLIENT_MULTI_STATEMENTS, opts=opts)\n+function mysql_connect(host, user, passwd, db=\"\"; port=3306, socket=\"/var/run/mysqld/mysqld.sock\", opts = Dict())","path":"src/handy.jl","position":21,"original_position":21,"commit_id":"568e3d7343e068430e1c187649d7b2b06ea68970","original_commit_id":"568e3d7343e068430e1c187649d7b2b06ea68970","user":{"login":"nkottary","id":2999399,"avatar_url":"https://avatars.githubusercontent.com/u/2999399?v=3","gravatar_id":"","url":"https://api.github.com/users/nkottary","html_url":"https://github.com/nkottary","followers_url":"https://api.github.com/users/nkottary/followers","following_url":"https://api.github.com/users/nkottary/following{/other_user}","gists_url":"https://api.github.com/users/nkottary/gists{/gist_id}","starred_url":"https://api.github.com/users/nkottary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkottary/subscriptions","organizations_url":"https://api.github.com/users/nkottary/orgs","repos_url":"https://api.github.com/users/nkottary/repos","events_url":"https://api.github.com/users/nkottary/events{/privacy}","received_events_url":"https://api.github.com/users/nkottary/received_events","type":"User","site_admin":false},"body":"The default value for socket should be a constant defined in consts.jl and the right value set for different OSes using `is_unix`, `is_windows` etc.","created_at":"2016-10-17T10:41:18Z","updated_at":"2016-10-17T10:41:18Z","html_url":"https://github.com/JuliaDB/MySQL.jl/pull/68#discussion_r83617975","pull_request_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/JuliaDB/MySQL.jl/pulls/comments/83617975"},"html":{"href":"https://github.com/JuliaDB/MySQL.jl/pull/68#discussion_r83617975"},"pull_request":{"href":"https://api.github.com/repos/JuliaDB/MySQL.jl/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaDB/MySQL.jl/pulls/68","id":89594138,"html_url":"https://github.com/JuliaDB/MySQL.jl/pull/68","diff_url":"https://github.com/JuliaDB/MySQL.jl/pull/68.diff","patch_url":"https://github.com/JuliaDB/MySQL.jl/pull/68.patch","issue_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/issues/68","number":68,"state":"open","locked":false,"title":"Enhanced connection","user":{"login":"unixime","id":22149863,"avatar_url":"https://avatars.githubusercontent.com/u/22149863?v=3","gravatar_id":"","url":"https://api.github.com/users/unixime","html_url":"https://github.com/unixime","followers_url":"https://api.github.com/users/unixime/followers","following_url":"https://api.github.com/users/unixime/following{/other_user}","gists_url":"https://api.github.com/users/unixime/gists{/gist_id}","starred_url":"https://api.github.com/users/unixime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unixime/subscriptions","organizations_url":"https://api.github.com/users/unixime/orgs","repos_url":"https://api.github.com/users/unixime/repos","events_url":"https://api.github.com/users/unixime/events{/privacy}","received_events_url":"https://api.github.com/users/unixime/received_events","type":"User","site_admin":false},"body":"Added two new optional parameters to mysql_connect :\r\n\r\n- port\r\n\r\n- socket\r\n\r\nNew parameters allow connection using a not standard port ( 3306 ) or a not default socket ( i.e. (/var/mysql/mysql.sock )\r\n\r\nExamples:\r\n\r\n```\r\njulia> conn2 = mysql_connect(\"127.0.0.1\", \"support\", \"support\", \"\", port=3307)\r\nMySQL Handle\r\n------------\r\nHost: 127.0.0.1\r\nUser: support\r\nDB:\r\n```\r\n\r\n```\r\njulia> conn3 = mysql_connect(\"localhost\", \"support\", \"support\", \"\", socket=\"/tmp/mysql-3307.sock\")\r\nMySQL Handle\r\n------------\r\nHost: localhost\r\nUser: support\r\nDB:\r\n```","created_at":"2016-10-17T10:05:20Z","updated_at":"2016-10-17T10:41:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0e4edc3eff2e757439f0ff308c339040c1d4685","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/pulls/68/commits","review_comments_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/pulls/68/comments","review_comment_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/issues/68/comments","statuses_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/statuses/568e3d7343e068430e1c187649d7b2b06ea68970","head":{"label":"unixime:master","ref":"master","sha":"568e3d7343e068430e1c187649d7b2b06ea68970","user":{"login":"unixime","id":22149863,"avatar_url":"https://avatars.githubusercontent.com/u/22149863?v=3","gravatar_id":"","url":"https://api.github.com/users/unixime","html_url":"https://github.com/unixime","followers_url":"https://api.github.com/users/unixime/followers","following_url":"https://api.github.com/users/unixime/following{/other_user}","gists_url":"https://api.github.com/users/unixime/gists{/gist_id}","starred_url":"https://api.github.com/users/unixime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unixime/subscriptions","organizations_url":"https://api.github.com/users/unixime/orgs","repos_url":"https://api.github.com/users/unixime/repos","events_url":"https://api.github.com/users/unixime/events{/privacy}","received_events_url":"https://api.github.com/users/unixime/received_events","type":"User","site_admin":false},"repo":{"id":70799564,"name":"MySQL.jl","full_name":"unixime/MySQL.jl","owner":{"login":"unixime","id":22149863,"avatar_url":"https://avatars.githubusercontent.com/u/22149863?v=3","gravatar_id":"","url":"https://api.github.com/users/unixime","html_url":"https://github.com/unixime","followers_url":"https://api.github.com/users/unixime/followers","following_url":"https://api.github.com/users/unixime/following{/other_user}","gists_url":"https://api.github.com/users/unixime/gists{/gist_id}","starred_url":"https://api.github.com/users/unixime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unixime/subscriptions","organizations_url":"https://api.github.com/users/unixime/orgs","repos_url":"https://api.github.com/users/unixime/repos","events_url":"https://api.github.com/users/unixime/events{/privacy}","received_events_url":"https://api.github.com/users/unixime/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/unixime/MySQL.jl","description":"Access MySQL from Julia","fork":true,"url":"https://api.github.com/repos/unixime/MySQL.jl","forks_url":"https://api.github.com/repos/unixime/MySQL.jl/forks","keys_url":"https://api.github.com/repos/unixime/MySQL.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unixime/MySQL.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unixime/MySQL.jl/teams","hooks_url":"https://api.github.com/repos/unixime/MySQL.jl/hooks","issue_events_url":"https://api.github.com/repos/unixime/MySQL.jl/issues/events{/number}","events_url":"https://api.github.com/repos/unixime/MySQL.jl/events","assignees_url":"https://api.github.com/repos/unixime/MySQL.jl/assignees{/user}","branches_url":"https://api.github.com/repos/unixime/MySQL.jl/branches{/branch}","tags_url":"https://api.github.com/repos/unixime/MySQL.jl/tags","blobs_url":"https://api.github.com/repos/unixime/MySQL.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unixime/MySQL.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unixime/MySQL.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/unixime/MySQL.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unixime/MySQL.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/unixime/MySQL.jl/languages","stargazers_url":"https://api.github.com/repos/unixime/MySQL.jl/stargazers","contributors_url":"https://api.github.com/repos/unixime/MySQL.jl/contributors","subscribers_url":"https://api.github.com/repos/unixime/MySQL.jl/subscribers","subscription_url":"https://api.github.com/repos/unixime/MySQL.jl/subscription","commits_url":"https://api.github.com/repos/unixime/MySQL.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/unixime/MySQL.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/unixime/MySQL.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/unixime/MySQL.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/unixime/MySQL.jl/contents/{+path}","compare_url":"https://api.github.com/repos/unixime/MySQL.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unixime/MySQL.jl/merges","archive_url":"https://api.github.com/repos/unixime/MySQL.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unixime/MySQL.jl/downloads","issues_url":"https://api.github.com/repos/unixime/MySQL.jl/issues{/number}","pulls_url":"https://api.github.com/repos/unixime/MySQL.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/unixime/MySQL.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/unixime/MySQL.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unixime/MySQL.jl/labels{/name}","releases_url":"https://api.github.com/repos/unixime/MySQL.jl/releases{/id}","deployments_url":"https://api.github.com/repos/unixime/MySQL.jl/deployments","created_at":"2016-10-13T11:25:40Z","updated_at":"2016-10-13T11:25:41Z","pushed_at":"2016-10-13T22:18:30Z","git_url":"git://github.com/unixime/MySQL.jl.git","ssh_url":"git@github.com:unixime/MySQL.jl.git","clone_url":"https://github.com/unixime/MySQL.jl.git","svn_url":"https://github.com/unixime/MySQL.jl","homepage":"","size":236,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaDB:master","ref":"master","sha":"641234c79b298e3f1b3b74f051cecf41336d8901","user":{"login":"JuliaDB","id":6539129,"avatar_url":"https://avatars.githubusercontent.com/u/6539129?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaDB","html_url":"https://github.com/JuliaDB","followers_url":"https://api.github.com/users/JuliaDB/followers","following_url":"https://api.github.com/users/JuliaDB/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDB/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDB/subscriptions","organizations_url":"https://api.github.com/users/JuliaDB/orgs","repos_url":"https://api.github.com/users/JuliaDB/repos","events_url":"https://api.github.com/users/JuliaDB/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDB/received_events","type":"Organization","site_admin":false},"repo":{"id":42038383,"name":"MySQL.jl","full_name":"JuliaDB/MySQL.jl","owner":{"login":"JuliaDB","id":6539129,"avatar_url":"https://avatars.githubusercontent.com/u/6539129?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaDB","html_url":"https://github.com/JuliaDB","followers_url":"https://api.github.com/users/JuliaDB/followers","following_url":"https://api.github.com/users/JuliaDB/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDB/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDB/subscriptions","organizations_url":"https://api.github.com/users/JuliaDB/orgs","repos_url":"https://api.github.com/users/JuliaDB/repos","events_url":"https://api.github.com/users/JuliaDB/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaDB/MySQL.jl","description":"Access MySQL from Julia","fork":false,"url":"https://api.github.com/repos/JuliaDB/MySQL.jl","forks_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/forks","keys_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/teams","hooks_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/events","assignees_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/tags","blobs_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/subscription","commits_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/merges","archive_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/downloads","issues_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaDB/MySQL.jl/deployments","created_at":"2015-09-07T07:38:51Z","updated_at":"2016-10-08T21:35:29Z","pushed_at":"2016-10-17T10:05:20Z","git_url":"git://github.com/JuliaDB/MySQL.jl.git","ssh_url":"git@github.com:JuliaDB/MySQL.jl.git","clone_url":"https://github.com/JuliaDB/MySQL.jl.git","svn_url":"https://github.com/JuliaDB/MySQL.jl","homepage":"","size":243,"stargazers_count":17,"watchers_count":17,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":17,"forks":13,"open_issues":17,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaDB/MySQL.jl/pulls/68"},"html":{"href":"https://github.com/JuliaDB/MySQL.jl/pull/68"},"issue":{"href":"https://api.github.com/repos/JuliaDB/MySQL.jl/issues/68"},"comments":{"href":"https://api.github.com/repos/JuliaDB/MySQL.jl/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaDB/MySQL.jl/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaDB/MySQL.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaDB/MySQL.jl/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaDB/MySQL.jl/statuses/568e3d7343e068430e1c187649d7b2b06ea68970"}}}}
{"actor":{"display_login":"nkottary"}}