{"action":"opened","issue":{"url":"https://api.github.com/repos/os-autoinst/openQA/issues/1059","repository_url":"https://api.github.com/repos/os-autoinst/openQA","labels_url":"https://api.github.com/repos/os-autoinst/openQA/issues/1059/labels{/name}","comments_url":"https://api.github.com/repos/os-autoinst/openQA/issues/1059/comments","events_url":"https://api.github.com/repos/os-autoinst/openQA/issues/1059/events","html_url":"https://github.com/os-autoinst/openQA/issues/1059","id":192991017,"number":1059,"title":"Avoid event loop recursion","user":{"login":"kraih","id":30094,"avatar_url":"https://avatars.githubusercontent.com/u/30094?v=3","gravatar_id":"","url":"https://api.github.com/users/kraih","html_url":"https://github.com/kraih","followers_url":"https://api.github.com/users/kraih/followers","following_url":"https://api.github.com/users/kraih/following{/other_user}","gists_url":"https://api.github.com/users/kraih/gists{/gist_id}","starred_url":"https://api.github.com/users/kraih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kraih/subscriptions","organizations_url":"https://api.github.com/users/kraih/orgs","repos_url":"https://api.github.com/users/kraih/repos","events_url":"https://api.github.com/users/kraih/events{/privacy}","received_events_url":"https://api.github.com/users/kraih/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-01T23:23:06Z","updated_at":"2016-12-01T23:23:06Z","closed_at":null,"body":"Opening this issue as a reminder for myself to fix this at some point in the future (or in case someone else has some spare time to take a look).\r\n\r\nThere is a call to `Mojo::IOLoop->singleton->reactor->one_tick` in `OpenQA::Worker::Common`. It is used to emulate a blocking function call, by recursing back into the already running event loop. This might not seem like a big deal, but is actually a rather dangerous anti-pattern. All it takes is a few unfortunately timed events, and the call stack will keep growing until the Perl interpreter explodes (usually a segfault).\r\n\r\nWhat needs to be done here is to rewrite the function with a traditional continuation-passing style API."}}
{"actor":{"display_login":"kraih"}}