{"action":"created","issue":{"url":"https://api.github.com/repos/bharadwaj-raju/WeatherDesk/issues/9","repository_url":"https://api.github.com/repos/bharadwaj-raju/WeatherDesk","labels_url":"https://api.github.com/repos/bharadwaj-raju/WeatherDesk/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/bharadwaj-raju/WeatherDesk/issues/9/comments","events_url":"https://api.github.com/repos/bharadwaj-raju/WeatherDesk/issues/9/events","html_url":"https://github.com/bharadwaj-raju/WeatherDesk/pull/9","id":155863642,"number":9,"title":"Prefer XDG_CURRENT_DESKTOP over DESKTOP_SESSION","user":{"login":"jcowgill","id":1226825,"avatar_url":"https://avatars.githubusercontent.com/u/1226825?v=3","gravatar_id":"","url":"https://api.github.com/users/jcowgill","html_url":"https://github.com/jcowgill","followers_url":"https://api.github.com/users/jcowgill/followers","following_url":"https://api.github.com/users/jcowgill/following{/other_user}","gists_url":"https://api.github.com/users/jcowgill/gists{/gist_id}","starred_url":"https://api.github.com/users/jcowgill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcowgill/subscriptions","organizations_url":"https://api.github.com/users/jcowgill/orgs","repos_url":"https://api.github.com/users/jcowgill/repos","events_url":"https://api.github.com/users/jcowgill/events{/privacy}","received_events_url":"https://api.github.com/users/jcowgill/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-20T00:20:12Z","updated_at":"2016-05-20T00:32:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bharadwaj-raju/WeatherDesk/pulls/9","html_url":"https://github.com/bharadwaj-raju/WeatherDesk/pull/9","diff_url":"https://github.com/bharadwaj-raju/WeatherDesk/pull/9.diff","patch_url":"https://github.com/bharadwaj-raju/WeatherDesk/pull/9.patch"},"body":"`XDG_CURRENT_DESKTOP` is the newer more correct way of detecting the current desktop environment, so it should be preferred over the old `DESKTOP_SESSION` (note session is not the same as desktop environment).\r\n\r\nThis fixes the desktop detection for the \"special\" gnome sessions (like gnome-classic and gnome-wayland). It should also work for any users using custom sessions, although I expect that's fairly uncommon.\r\n\r\nHopefully this doesn't break other environments too much..."},"comment":{"url":"https://api.github.com/repos/bharadwaj-raju/WeatherDesk/issues/comments/220488487","html_url":"https://github.com/bharadwaj-raju/WeatherDesk/pull/9#issuecomment-220488487","issue_url":"https://api.github.com/repos/bharadwaj-raju/WeatherDesk/issues/9","id":220488487,"user":{"login":"bharadwaj-raju","id":15855081,"avatar_url":"https://avatars.githubusercontent.com/u/15855081?v=3","gravatar_id":"","url":"https://api.github.com/users/bharadwaj-raju","html_url":"https://github.com/bharadwaj-raju","followers_url":"https://api.github.com/users/bharadwaj-raju/followers","following_url":"https://api.github.com/users/bharadwaj-raju/following{/other_user}","gists_url":"https://api.github.com/users/bharadwaj-raju/gists{/gist_id}","starred_url":"https://api.github.com/users/bharadwaj-raju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bharadwaj-raju/subscriptions","organizations_url":"https://api.github.com/users/bharadwaj-raju/orgs","repos_url":"https://api.github.com/users/bharadwaj-raju/repos","events_url":"https://api.github.com/users/bharadwaj-raju/events{/privacy}","received_events_url":"https://api.github.com/users/bharadwaj-raju/received_events","type":"User","site_admin":false},"created_at":"2016-05-20T00:32:12Z","updated_at":"2016-05-20T00:32:12Z","body":"I suppose the `if desktop_session in ['gnome' ... ]` should match `gnome-*`, but it doesn't for `cinnamon` in `x-cinnamon`.\r\n\r\nStill, totally agree about the `XDG_CURRENT_DESKTOP` being better. Merging."}}
{"actor":{"display_login":"bharadwaj-raju"}}