{"action":"created","comment":{"url":"https://api.github.com/repos/wso2/mesos-artifacts/pulls/comments/69409483","id":69409483,"diff_hunk":"@@ -139,3 +138,25 @@ function showUsageAndExitDefault() {\n   echoBold \"Ex: ./deploy.sh\"\n   exit 1\n }\n+\n+function deploy_common_service()\n+{\n+  if ! bash ${mesos_artifacts_home}/common/${1}/deploy.sh; then\n+    echoError \"Non-zero exit code returned when deploying ${1}\"\n+    exit 1","path":"common/scripts/base.sh","position":31,"original_position":31,"commit_id":"41322f3cb6c0e1f01dce10a2dedad840f1f51f46","original_commit_id":"41322f3cb6c0e1f01dce10a2dedad840f1f51f46","user":{"login":"ravihansa3000","id":3677916,"avatar_url":"https://avatars.githubusercontent.com/u/3677916?v=3","gravatar_id":"","url":"https://api.github.com/users/ravihansa3000","html_url":"https://github.com/ravihansa3000","followers_url":"https://api.github.com/users/ravihansa3000/followers","following_url":"https://api.github.com/users/ravihansa3000/following{/other_user}","gists_url":"https://api.github.com/users/ravihansa3000/gists{/gist_id}","starred_url":"https://api.github.com/users/ravihansa3000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravihansa3000/subscriptions","organizations_url":"https://api.github.com/users/ravihansa3000/orgs","repos_url":"https://api.github.com/users/ravihansa3000/repos","events_url":"https://api.github.com/users/ravihansa3000/events{/privacy}","received_events_url":"https://api.github.com/users/ravihansa3000/received_events","type":"User","site_admin":false},"body":"@Thanu functions in base.sh only return values. It should not exit which would make it hard to troubleshoot. It should exit from script which is calling this function with a meaningful error msg.","created_at":"2016-07-04T05:29:44Z","updated_at":"2016-07-04T05:29:44Z","html_url":"https://github.com/wso2/mesos-artifacts/pull/8#discussion_r69409483","pull_request_url":"https://api.github.com/repos/wso2/mesos-artifacts/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/wso2/mesos-artifacts/pulls/comments/69409483"},"html":{"href":"https://github.com/wso2/mesos-artifacts/pull/8#discussion_r69409483"},"pull_request":{"href":"https://api.github.com/repos/wso2/mesos-artifacts/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/wso2/mesos-artifacts/pulls/8","id":75848444,"html_url":"https://github.com/wso2/mesos-artifacts/pull/8","diff_url":"https://github.com/wso2/mesos-artifacts/pull/8.diff","patch_url":"https://github.com/wso2/mesos-artifacts/pull/8.patch","issue_url":"https://api.github.com/repos/wso2/mesos-artifacts/issues/8","number":8,"state":"open","locked":false,"title":"Refactoring deploy script","user":{"login":"Thanu","id":1333842,"avatar_url":"https://avatars.githubusercontent.com/u/1333842?v=3","gravatar_id":"","url":"https://api.github.com/users/Thanu","html_url":"https://github.com/Thanu","followers_url":"https://api.github.com/users/Thanu/followers","following_url":"https://api.github.com/users/Thanu/following{/other_user}","gists_url":"https://api.github.com/users/Thanu/gists{/gist_id}","starred_url":"https://api.github.com/users/Thanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thanu/subscriptions","organizations_url":"https://api.github.com/users/Thanu/orgs","repos_url":"https://api.github.com/users/Thanu/repos","events_url":"https://api.github.com/users/Thanu/events{/privacy}","received_events_url":"https://api.github.com/users/Thanu/received_events","type":"User","site_admin":false},"body":"This p/r is to refactor deploy script.","created_at":"2016-06-30T16:15:32Z","updated_at":"2016-07-04T05:29:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdd46a4e956a71c7bd8464e29a681ab77e0feb57","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wso2/mesos-artifacts/pulls/8/commits","review_comments_url":"https://api.github.com/repos/wso2/mesos-artifacts/pulls/8/comments","review_comment_url":"https://api.github.com/repos/wso2/mesos-artifacts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/mesos-artifacts/issues/8/comments","statuses_url":"https://api.github.com/repos/wso2/mesos-artifacts/statuses/41322f3cb6c0e1f01dce10a2dedad840f1f51f46","head":{"label":"Thanu:script-refactoring","ref":"script-refactoring","sha":"41322f3cb6c0e1f01dce10a2dedad840f1f51f46","user":{"login":"Thanu","id":1333842,"avatar_url":"https://avatars.githubusercontent.com/u/1333842?v=3","gravatar_id":"","url":"https://api.github.com/users/Thanu","html_url":"https://github.com/Thanu","followers_url":"https://api.github.com/users/Thanu/followers","following_url":"https://api.github.com/users/Thanu/following{/other_user}","gists_url":"https://api.github.com/users/Thanu/gists{/gist_id}","starred_url":"https://api.github.com/users/Thanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thanu/subscriptions","organizations_url":"https://api.github.com/users/Thanu/orgs","repos_url":"https://api.github.com/users/Thanu/repos","events_url":"https://api.github.com/users/Thanu/events{/privacy}","received_events_url":"https://api.github.com/users/Thanu/received_events","type":"User","site_admin":false},"repo":{"id":60592737,"name":"mesos-artifacts","full_name":"Thanu/mesos-artifacts","owner":{"login":"Thanu","id":1333842,"avatar_url":"https://avatars.githubusercontent.com/u/1333842?v=3","gravatar_id":"","url":"https://api.github.com/users/Thanu","html_url":"https://github.com/Thanu","followers_url":"https://api.github.com/users/Thanu/followers","following_url":"https://api.github.com/users/Thanu/following{/other_user}","gists_url":"https://api.github.com/users/Thanu/gists{/gist_id}","starred_url":"https://api.github.com/users/Thanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thanu/subscriptions","organizations_url":"https://api.github.com/users/Thanu/orgs","repos_url":"https://api.github.com/users/Thanu/repos","events_url":"https://api.github.com/users/Thanu/events{/privacy}","received_events_url":"https://api.github.com/users/Thanu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Thanu/mesos-artifacts","description":"","fork":true,"url":"https://api.github.com/repos/Thanu/mesos-artifacts","forks_url":"https://api.github.com/repos/Thanu/mesos-artifacts/forks","keys_url":"https://api.github.com/repos/Thanu/mesos-artifacts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Thanu/mesos-artifacts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Thanu/mesos-artifacts/teams","hooks_url":"https://api.github.com/repos/Thanu/mesos-artifacts/hooks","issue_events_url":"https://api.github.com/repos/Thanu/mesos-artifacts/issues/events{/number}","events_url":"https://api.github.com/repos/Thanu/mesos-artifacts/events","assignees_url":"https://api.github.com/repos/Thanu/mesos-artifacts/assignees{/user}","branches_url":"https://api.github.com/repos/Thanu/mesos-artifacts/branches{/branch}","tags_url":"https://api.github.com/repos/Thanu/mesos-artifacts/tags","blobs_url":"https://api.github.com/repos/Thanu/mesos-artifacts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Thanu/mesos-artifacts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Thanu/mesos-artifacts/git/refs{/sha}","trees_url":"https://api.github.com/repos/Thanu/mesos-artifacts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Thanu/mesos-artifacts/statuses/{sha}","languages_url":"https://api.github.com/repos/Thanu/mesos-artifacts/languages","stargazers_url":"https://api.github.com/repos/Thanu/mesos-artifacts/stargazers","contributors_url":"https://api.github.com/repos/Thanu/mesos-artifacts/contributors","subscribers_url":"https://api.github.com/repos/Thanu/mesos-artifacts/subscribers","subscription_url":"https://api.github.com/repos/Thanu/mesos-artifacts/subscription","commits_url":"https://api.github.com/repos/Thanu/mesos-artifacts/commits{/sha}","git_commits_url":"https://api.github.com/repos/Thanu/mesos-artifacts/git/commits{/sha}","comments_url":"https://api.github.com/repos/Thanu/mesos-artifacts/comments{/number}","issue_comment_url":"https://api.github.com/repos/Thanu/mesos-artifacts/issues/comments{/number}","contents_url":"https://api.github.com/repos/Thanu/mesos-artifacts/contents/{+path}","compare_url":"https://api.github.com/repos/Thanu/mesos-artifacts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Thanu/mesos-artifacts/merges","archive_url":"https://api.github.com/repos/Thanu/mesos-artifacts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Thanu/mesos-artifacts/downloads","issues_url":"https://api.github.com/repos/Thanu/mesos-artifacts/issues{/number}","pulls_url":"https://api.github.com/repos/Thanu/mesos-artifacts/pulls{/number}","milestones_url":"https://api.github.com/repos/Thanu/mesos-artifacts/milestones{/number}","notifications_url":"https://api.github.com/repos/Thanu/mesos-artifacts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Thanu/mesos-artifacts/labels{/name}","releases_url":"https://api.github.com/repos/Thanu/mesos-artifacts/releases{/id}","deployments_url":"https://api.github.com/repos/Thanu/mesos-artifacts/deployments","created_at":"2016-06-07T07:41:39Z","updated_at":"2016-06-07T07:41:40Z","pushed_at":"2016-07-03T13:03:56Z","git_url":"git://github.com/Thanu/mesos-artifacts.git","ssh_url":"git@github.com:Thanu/mesos-artifacts.git","clone_url":"https://github.com/Thanu/mesos-artifacts.git","svn_url":"https://github.com/Thanu/mesos-artifacts","homepage":null,"size":183,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:master","ref":"master","sha":"904bb3cb4af162e52e58d8e41a8089adc98e3094","user":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":53630030,"name":"mesos-artifacts","full_name":"wso2/mesos-artifacts","owner":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2/mesos-artifacts","description":"","fork":false,"url":"https://api.github.com/repos/wso2/mesos-artifacts","forks_url":"https://api.github.com/repos/wso2/mesos-artifacts/forks","keys_url":"https://api.github.com/repos/wso2/mesos-artifacts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/mesos-artifacts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/mesos-artifacts/teams","hooks_url":"https://api.github.com/repos/wso2/mesos-artifacts/hooks","issue_events_url":"https://api.github.com/repos/wso2/mesos-artifacts/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/mesos-artifacts/events","assignees_url":"https://api.github.com/repos/wso2/mesos-artifacts/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/mesos-artifacts/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/mesos-artifacts/tags","blobs_url":"https://api.github.com/repos/wso2/mesos-artifacts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/mesos-artifacts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/mesos-artifacts/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/mesos-artifacts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/mesos-artifacts/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/mesos-artifacts/languages","stargazers_url":"https://api.github.com/repos/wso2/mesos-artifacts/stargazers","contributors_url":"https://api.github.com/repos/wso2/mesos-artifacts/contributors","subscribers_url":"https://api.github.com/repos/wso2/mesos-artifacts/subscribers","subscription_url":"https://api.github.com/repos/wso2/mesos-artifacts/subscription","commits_url":"https://api.github.com/repos/wso2/mesos-artifacts/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/mesos-artifacts/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/mesos-artifacts/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/mesos-artifacts/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/mesos-artifacts/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/mesos-artifacts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/mesos-artifacts/merges","archive_url":"https://api.github.com/repos/wso2/mesos-artifacts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/mesos-artifacts/downloads","issues_url":"https://api.github.com/repos/wso2/mesos-artifacts/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/mesos-artifacts/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/mesos-artifacts/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/mesos-artifacts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/mesos-artifacts/labels{/name}","releases_url":"https://api.github.com/repos/wso2/mesos-artifacts/releases{/id}","deployments_url":"https://api.github.com/repos/wso2/mesos-artifacts/deployments","created_at":"2016-03-11T01:24:25Z","updated_at":"2016-06-27T11:43:04Z","pushed_at":"2016-07-03T13:03:56Z","git_url":"git://github.com/wso2/mesos-artifacts.git","ssh_url":"git@github.com:wso2/mesos-artifacts.git","clone_url":"https://github.com/wso2/mesos-artifacts.git","svn_url":"https://github.com/wso2/mesos-artifacts","homepage":null,"size":169,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/mesos-artifacts/pulls/8"},"html":{"href":"https://github.com/wso2/mesos-artifacts/pull/8"},"issue":{"href":"https://api.github.com/repos/wso2/mesos-artifacts/issues/8"},"comments":{"href":"https://api.github.com/repos/wso2/mesos-artifacts/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/mesos-artifacts/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/mesos-artifacts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/mesos-artifacts/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/mesos-artifacts/statuses/41322f3cb6c0e1f01dce10a2dedad840f1f51f46"}}}}
{"actor":{"display_login":"ravihansa3000"}}