{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/76122433","id":76122433,"diff_hunk":"@@ -651,6 +651,8 @@ private function writeProperty($zval, $property, $value)\n             // fatal error.\n \n             $object->$property = $value;\n+        } elseif (self::ACCESS_TYPE_NOT_FOUND === $access[self::ACCESS_TYPE]) {\n+            throw new NoSuchPropertyException(sprintf('Could not determine access type for property \"%s\".', $property));\n         } elseif (self::ACCESS_TYPE_MAGIC === $access[self::ACCESS_TYPE]) {","path":"src/Symfony/Component/PropertyAccess/PropertyAccessor.php","position":6,"original_position":6,"commit_id":"5ec27bc68c59c5b96ee495d373def72ff859a689","original_commit_id":"5ec27bc68c59c5b96ee495d373def72ff859a689","user":{"login":"phansys","id":1231441,"avatar_url":"https://avatars.githubusercontent.com/u/1231441?v=3","gravatar_id":"","url":"https://api.github.com/users/phansys","html_url":"https://github.com/phansys","followers_url":"https://api.github.com/users/phansys/followers","following_url":"https://api.github.com/users/phansys/following{/other_user}","gists_url":"https://api.github.com/users/phansys/gists{/gist_id}","starred_url":"https://api.github.com/users/phansys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phansys/subscriptions","organizations_url":"https://api.github.com/users/phansys/orgs","repos_url":"https://api.github.com/users/phansys/repos","events_url":"https://api.github.com/users/phansys/events{/privacy}","received_events_url":"https://api.github.com/users/phansys/received_events","type":"User","site_admin":false},"body":"Very good, finally I get your point. Sorry for the misunderstanding and thank you for the time you took to explain this.","created_at":"2016-08-24T19:27:13Z","updated_at":"2016-08-24T19:27:13Z","html_url":"https://github.com/symfony/symfony/pull/19141#discussion_r76122433","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/19141","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/76122433"},"html":{"href":"https://github.com/symfony/symfony/pull/19141#discussion_r76122433"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19141"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/19141","id":74773069,"html_url":"https://github.com/symfony/symfony/pull/19141","diff_url":"https://github.com/symfony/symfony/pull/19141.diff","patch_url":"https://github.com/symfony/symfony/pull/19141.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/19141","number":19141,"state":"open","locked":false,"title":"Throw less misleading exception when property access not found","user":{"login":"bramtweedegolf","id":6331700,"avatar_url":"https://avatars.githubusercontent.com/u/6331700?v=3","gravatar_id":"","url":"https://api.github.com/users/bramtweedegolf","html_url":"https://github.com/bramtweedegolf","followers_url":"https://api.github.com/users/bramtweedegolf/followers","following_url":"https://api.github.com/users/bramtweedegolf/following{/other_user}","gists_url":"https://api.github.com/users/bramtweedegolf/gists{/gist_id}","starred_url":"https://api.github.com/users/bramtweedegolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bramtweedegolf/subscriptions","organizations_url":"https://api.github.com/users/bramtweedegolf/orgs","repos_url":"https://api.github.com/users/bramtweedegolf/repos","events_url":"https://api.github.com/users/bramtweedegolf/events{/privacy}","received_events_url":"https://api.github.com/users/bramtweedegolf/received_events","type":"User","site_admin":false},"body":"Prevent throwing a NoSuchPropertyException with a somewhat misleading message \"Neither the property \"X\" nor one of the methods \"addX()\"/\"removeX()\", \"setX()\", \"x()\", \"__set()\" or \"__call()\" exist and have public access in class when the access cannot be determined, for instance if the doctrine schema is not up to date. \r\n\r\n| Q             | A\r\n| ------------- | ---\r\n| Branch?       | 3.1 for fixes\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| License       | MIT\r\n\r\n\r\n","created_at":"2016-06-22T12:14:04Z","updated_at":"2016-08-24T19:27:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"165767cfb0c48a30474438003fbca0de46842bfb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/19141/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/19141/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/19141/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/5ec27bc68c59c5b96ee495d373def72ff859a689","head":{"label":"tweedegolf:master","ref":"master","sha":"5ec27bc68c59c5b96ee495d373def72ff859a689","user":{"login":"tweedegolf","id":4540101,"avatar_url":"https://avatars.githubusercontent.com/u/4540101?v=3","gravatar_id":"","url":"https://api.github.com/users/tweedegolf","html_url":"https://github.com/tweedegolf","followers_url":"https://api.github.com/users/tweedegolf/followers","following_url":"https://api.github.com/users/tweedegolf/following{/other_user}","gists_url":"https://api.github.com/users/tweedegolf/gists{/gist_id}","starred_url":"https://api.github.com/users/tweedegolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweedegolf/subscriptions","organizations_url":"https://api.github.com/users/tweedegolf/orgs","repos_url":"https://api.github.com/users/tweedegolf/repos","events_url":"https://api.github.com/users/tweedegolf/events{/privacy}","received_events_url":"https://api.github.com/users/tweedegolf/received_events","type":"Organization","site_admin":false},"repo":{"id":61715897,"name":"symfony","full_name":"tweedegolf/symfony","owner":{"login":"tweedegolf","id":4540101,"avatar_url":"https://avatars.githubusercontent.com/u/4540101?v=3","gravatar_id":"","url":"https://api.github.com/users/tweedegolf","html_url":"https://github.com/tweedegolf","followers_url":"https://api.github.com/users/tweedegolf/followers","following_url":"https://api.github.com/users/tweedegolf/following{/other_user}","gists_url":"https://api.github.com/users/tweedegolf/gists{/gist_id}","starred_url":"https://api.github.com/users/tweedegolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweedegolf/subscriptions","organizations_url":"https://api.github.com/users/tweedegolf/orgs","repos_url":"https://api.github.com/users/tweedegolf/repos","events_url":"https://api.github.com/users/tweedegolf/events{/privacy}","received_events_url":"https://api.github.com/users/tweedegolf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tweedegolf/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/tweedegolf/symfony","forks_url":"https://api.github.com/repos/tweedegolf/symfony/forks","keys_url":"https://api.github.com/repos/tweedegolf/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tweedegolf/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tweedegolf/symfony/teams","hooks_url":"https://api.github.com/repos/tweedegolf/symfony/hooks","issue_events_url":"https://api.github.com/repos/tweedegolf/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/tweedegolf/symfony/events","assignees_url":"https://api.github.com/repos/tweedegolf/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/tweedegolf/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/tweedegolf/symfony/tags","blobs_url":"https://api.github.com/repos/tweedegolf/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tweedegolf/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tweedegolf/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/tweedegolf/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tweedegolf/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/tweedegolf/symfony/languages","stargazers_url":"https://api.github.com/repos/tweedegolf/symfony/stargazers","contributors_url":"https://api.github.com/repos/tweedegolf/symfony/contributors","subscribers_url":"https://api.github.com/repos/tweedegolf/symfony/subscribers","subscription_url":"https://api.github.com/repos/tweedegolf/symfony/subscription","commits_url":"https://api.github.com/repos/tweedegolf/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/tweedegolf/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/tweedegolf/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/tweedegolf/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/tweedegolf/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/tweedegolf/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tweedegolf/symfony/merges","archive_url":"https://api.github.com/repos/tweedegolf/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tweedegolf/symfony/downloads","issues_url":"https://api.github.com/repos/tweedegolf/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/tweedegolf/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/tweedegolf/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/tweedegolf/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tweedegolf/symfony/labels{/name}","releases_url":"https://api.github.com/repos/tweedegolf/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/tweedegolf/symfony/deployments","created_at":"2016-06-22T12:05:47Z","updated_at":"2016-06-22T12:06:04Z","pushed_at":"2016-06-22T12:09:42Z","git_url":"git://github.com/tweedegolf/symfony.git","ssh_url":"git@github.com:tweedegolf/symfony.git","clone_url":"https://github.com/tweedegolf/symfony.git","svn_url":"https://github.com/tweedegolf/symfony","homepage":"symfony.com","size":72825,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"1298ce51cb08b6cf780784056e723fd542db84cc","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-08-24T19:11:31Z","pushed_at":"2016-08-24T18:14:04Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":134748,"stargazers_count":12827,"watchers_count":12827,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4997,"mirror_url":null,"open_issues_count":756,"forks":4997,"open_issues":756,"watchers":12827,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19141"},"html":{"href":"https://github.com/symfony/symfony/pull/19141"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/19141"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/19141/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19141/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19141/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/5ec27bc68c59c5b96ee495d373def72ff859a689"}}}}
{"actor":{"display_login":"phansys"}}