{"action":"created","issue":{"url":"https://api.github.com/repos/librosa/librosa/issues/464","repository_url":"https://api.github.com/repos/librosa/librosa","labels_url":"https://api.github.com/repos/librosa/librosa/issues/464/labels{/name}","comments_url":"https://api.github.com/repos/librosa/librosa/issues/464/comments","events_url":"https://api.github.com/repos/librosa/librosa/issues/464/events","html_url":"https://github.com/librosa/librosa/pull/464","id":193920879,"number":464,"title":"db to/from amplitude and power","user":{"login":"bmcfee","id":1190540,"avatar_url":"https://avatars.githubusercontent.com/u/1190540?v=3","gravatar_id":"","url":"https://api.github.com/users/bmcfee","html_url":"https://github.com/bmcfee","followers_url":"https://api.github.com/users/bmcfee/followers","following_url":"https://api.github.com/users/bmcfee/following{/other_user}","gists_url":"https://api.github.com/users/bmcfee/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcfee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcfee/subscriptions","organizations_url":"https://api.github.com/users/bmcfee/orgs","repos_url":"https://api.github.com/users/bmcfee/repos","events_url":"https://api.github.com/users/bmcfee/events{/privacy}","received_events_url":"https://api.github.com/users/bmcfee/received_events","type":"User","site_admin":false},"labels":[{"id":16995036,"url":"https://api.github.com/repos/librosa/librosa/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":101594894,"url":"https://api.github.com/repos/librosa/librosa/labels/functionality","name":"functionality","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"bmcfee","id":1190540,"avatar_url":"https://avatars.githubusercontent.com/u/1190540?v=3","gravatar_id":"","url":"https://api.github.com/users/bmcfee","html_url":"https://github.com/bmcfee","followers_url":"https://api.github.com/users/bmcfee/followers","following_url":"https://api.github.com/users/bmcfee/following{/other_user}","gists_url":"https://api.github.com/users/bmcfee/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcfee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcfee/subscriptions","organizations_url":"https://api.github.com/users/bmcfee/orgs","repos_url":"https://api.github.com/users/bmcfee/repos","events_url":"https://api.github.com/users/bmcfee/events{/privacy}","received_events_url":"https://api.github.com/users/bmcfee/received_events","type":"User","site_admin":false},"assignees":[{"login":"bmcfee","id":1190540,"avatar_url":"https://avatars.githubusercontent.com/u/1190540?v=3","gravatar_id":"","url":"https://api.github.com/users/bmcfee","html_url":"https://github.com/bmcfee","followers_url":"https://api.github.com/users/bmcfee/followers","following_url":"https://api.github.com/users/bmcfee/following{/other_user}","gists_url":"https://api.github.com/users/bmcfee/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcfee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcfee/subscriptions","organizations_url":"https://api.github.com/users/bmcfee/orgs","repos_url":"https://api.github.com/users/bmcfee/repos","events_url":"https://api.github.com/users/bmcfee/events{/privacy}","received_events_url":"https://api.github.com/users/bmcfee/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/librosa/librosa/milestones/8","html_url":"https://github.com/librosa/librosa/milestones/0.5","labels_url":"https://api.github.com/repos/librosa/librosa/milestones/8/labels","id":949792,"number":8,"title":"0.5","description":null,"creator":{"login":"bmcfee","id":1190540,"avatar_url":"https://avatars.githubusercontent.com/u/1190540?v=3","gravatar_id":"","url":"https://api.github.com/users/bmcfee","html_url":"https://github.com/bmcfee","followers_url":"https://api.github.com/users/bmcfee/followers","following_url":"https://api.github.com/users/bmcfee/following{/other_user}","gists_url":"https://api.github.com/users/bmcfee/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcfee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcfee/subscriptions","organizations_url":"https://api.github.com/users/bmcfee/orgs","repos_url":"https://api.github.com/users/bmcfee/repos","events_url":"https://api.github.com/users/bmcfee/events{/privacy}","received_events_url":"https://api.github.com/users/bmcfee/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":60,"state":"open","created_at":"2015-01-24T18:03:39Z","updated_at":"2016-12-06T23:58:43Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-12-06T23:58:43Z","updated_at":"2016-12-07T15:10:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/librosa/librosa/pulls/464","html_url":"https://github.com/librosa/librosa/pull/464","diff_url":"https://github.com/librosa/librosa/pull/464.diff","patch_url":"https://github.com/librosa/librosa/pull/464.patch"},"body":"This PR implements #421:\r\n\r\n- logamplitude docstrings are slightly improved\r\n- `power_to_db` aliases `logamplitude`\r\n- `db_to_power` provides the inverse mapping\r\n- `amplitude_to_db` is a convenience function to side-step power conversion\r\n- `db_to_amplitude` inverts `amplitude_to_db`\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/librosa/librosa/464)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/librosa/librosa/issues/comments/265472072","html_url":"https://github.com/librosa/librosa/pull/464#issuecomment-265472072","issue_url":"https://api.github.com/repos/librosa/librosa/issues/464","id":265472072,"user":{"login":"dpwe","id":552145,"avatar_url":"https://avatars.githubusercontent.com/u/552145?v=3","gravatar_id":"","url":"https://api.github.com/users/dpwe","html_url":"https://github.com/dpwe","followers_url":"https://api.github.com/users/dpwe/followers","following_url":"https://api.github.com/users/dpwe/following{/other_user}","gists_url":"https://api.github.com/users/dpwe/gists{/gist_id}","starred_url":"https://api.github.com/users/dpwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpwe/subscriptions","organizations_url":"https://api.github.com/users/dpwe/orgs","repos_url":"https://api.github.com/users/dpwe/repos","events_url":"https://api.github.com/users/dpwe/events{/privacy}","received_events_url":"https://api.github.com/users/dpwe/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T15:10:39Z","updated_at":"2016-12-07T15:10:39Z","body":"\n\n\n\nReview status: 0 of 13 files reviewed at latest revision, 15 unresolved discussions.\n\n---\n\n*[librosa/core/spectrum.py, line 609 at r1](https://reviewable.io:443/reviews/librosa/librosa/464#-KYObv1E3oZvFnuEJZlI:-KYOp2Ht7BBUmIZGs83d:b-dzlr81) ([raw file](https://github.com/librosa/librosa/blob/e7169ea0eed2093b2d51aaca733c20381332afbc/librosa/core/spectrum.py#L609)):*\n<details><summary><i>Previously, bmcfee (Brian McFee) wrote…</i></summary><blockquote>\n\nDerp, I think I misread your comment; were you referring to `ref_power` there?\n\nHow about renaming `ref_power` to `ref` (with a deprecation rename so nothing breaks)?\n</blockquote></details>\n\nref works for me.\n\n---\n\n*[librosa/core/spectrum.py, line 621 at r1](https://reviewable.io:443/reviews/librosa/librosa/464#-KYOdGqd795Uw3knHgpe:-KYOpAH_As0IS_giM13h:bfa96e7) ([raw file](https://github.com/librosa/librosa/blob/e7169ea0eed2093b2d51aaca733c20381332afbc/librosa/core/spectrum.py#L621)):*\n<details><summary><i>Previously, bmcfee (Brian McFee) wrote…</i></summary><blockquote>\n\nBut in logamplitude it's not necessarily db.  How about `S_out` here?\n</blockquote></details>\n\nIf it's 10*log10(something), it's better to call it dB, not log power.  10*log10 is not log_S.\n\nS_out is OK, but the 10*log10 *strongly* indicated dB.  I think it's incorrect to say \"it's not necessarily db\".  Sure, it's just math on numbers, but this math only makes sense if the output is in dB.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/librosa/librosa/464)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"dpwe"}}