{"action":"created","issue":{"url":"https://api.github.com/repos/dcos/dcos-ui/issues/1603","repository_url":"https://api.github.com/repos/dcos/dcos-ui","labels_url":"https://api.github.com/repos/dcos/dcos-ui/issues/1603/labels{/name}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/issues/1603/comments","events_url":"https://api.github.com/repos/dcos/dcos-ui/issues/1603/events","html_url":"https://github.com/dcos/dcos-ui/pull/1603","id":195531307,"number":1603,"title":"DCOS-9749: Enable USER network for Mesos runtime","user":{"login":"nLight","id":186223,"avatar_url":"https://avatars.githubusercontent.com/u/186223?v=3","gravatar_id":"","url":"https://api.github.com/users/nLight","html_url":"https://github.com/nLight","followers_url":"https://api.github.com/users/nLight/followers","following_url":"https://api.github.com/users/nLight/following{/other_user}","gists_url":"https://api.github.com/users/nLight/gists{/gist_id}","starred_url":"https://api.github.com/users/nLight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nLight/subscriptions","organizations_url":"https://api.github.com/users/nLight/orgs","repos_url":"https://api.github.com/users/nLight/repos","events_url":"https://api.github.com/users/nLight/events{/privacy}","received_events_url":"https://api.github.com/users/nLight/received_events","type":"User","site_admin":false},"labels":[{"id":360296447,"url":"https://api.github.com/repos/dcos/dcos-ui/labels/hold%20merge","name":"hold merge","color":"097ec6","default":false}],"state":"open","locked":false,"assignee":{"login":"Poltergeist","id":156010,"avatar_url":"https://avatars.githubusercontent.com/u/156010?v=3","gravatar_id":"","url":"https://api.github.com/users/Poltergeist","html_url":"https://github.com/Poltergeist","followers_url":"https://api.github.com/users/Poltergeist/followers","following_url":"https://api.github.com/users/Poltergeist/following{/other_user}","gists_url":"https://api.github.com/users/Poltergeist/gists{/gist_id}","starred_url":"https://api.github.com/users/Poltergeist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Poltergeist/subscriptions","organizations_url":"https://api.github.com/users/Poltergeist/orgs","repos_url":"https://api.github.com/users/Poltergeist/repos","events_url":"https://api.github.com/users/Poltergeist/events{/privacy}","received_events_url":"https://api.github.com/users/Poltergeist/received_events","type":"User","site_admin":false},"assignees":[{"login":"Poltergeist","id":156010,"avatar_url":"https://avatars.githubusercontent.com/u/156010?v=3","gravatar_id":"","url":"https://api.github.com/users/Poltergeist","html_url":"https://github.com/Poltergeist","followers_url":"https://api.github.com/users/Poltergeist/followers","following_url":"https://api.github.com/users/Poltergeist/following{/other_user}","gists_url":"https://api.github.com/users/Poltergeist/gists{/gist_id}","starred_url":"https://api.github.com/users/Poltergeist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Poltergeist/subscriptions","organizations_url":"https://api.github.com/users/Poltergeist/orgs","repos_url":"https://api.github.com/users/Poltergeist/repos","events_url":"https://api.github.com/users/Poltergeist/events{/privacy}","received_events_url":"https://api.github.com/users/Poltergeist/received_events","type":"User","site_admin":false},{"login":"orlandohohmeier","id":647035,"avatar_url":"https://avatars.githubusercontent.com/u/647035?v=3","gravatar_id":"","url":"https://api.github.com/users/orlandohohmeier","html_url":"https://github.com/orlandohohmeier","followers_url":"https://api.github.com/users/orlandohohmeier/followers","following_url":"https://api.github.com/users/orlandohohmeier/following{/other_user}","gists_url":"https://api.github.com/users/orlandohohmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/orlandohohmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlandohohmeier/subscriptions","organizations_url":"https://api.github.com/users/orlandohohmeier/orgs","repos_url":"https://api.github.com/users/orlandohohmeier/repos","events_url":"https://api.github.com/users/orlandohohmeier/events{/privacy}","received_events_url":"https://api.github.com/users/orlandohohmeier/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-12-14T13:31:49Z","updated_at":"2016-12-15T13:49:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dcos/dcos-ui/pulls/1603","html_url":"https://github.com/dcos/dcos-ui/pull/1603","diff_url":"https://github.com/dcos/dcos-ui/pull/1603.diff","patch_url":"https://github.com/dcos/dcos-ui/pull/1603.patch"},"body":"This PR:\r\n* Enables USER network for Mesos runtime, as it turned out to be available.\r\n* Introduces an initial transaction that sets `container.type` to `NONE`. \r\nOtherwise setting the network type would also create a `container` section.\r\n* Fixes a typo/bug handling `groups` section in `ipAddress` properly.\r\n\r\nAs you can see it does 3 things, which could be bad if they weren't closely related, though I still can extract 2 PRs if you insist.\r\n\r\nExample definition:\r\n```JSON\r\n{\r\n  \"id\": \"/mesos-user-network\",\r\n  \"cmd\": \"sleep 1000\",\r\n  \"instances\": 1,\r\n  \"cpus\": 0.1,\r\n  \"mem\": 128,\r\n  \"disk\": 0,\r\n  \"ipAddress\": {\r\n    \"networkName\": \"dcos\"\r\n  }\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/dcos/dcos-ui/issues/comments/267331510","html_url":"https://github.com/dcos/dcos-ui/pull/1603#issuecomment-267331510","issue_url":"https://api.github.com/repos/dcos/dcos-ui/issues/1603","id":267331510,"user":{"login":"nLight","id":186223,"avatar_url":"https://avatars.githubusercontent.com/u/186223?v=3","gravatar_id":"","url":"https://api.github.com/users/nLight","html_url":"https://github.com/nLight","followers_url":"https://api.github.com/users/nLight/followers","following_url":"https://api.github.com/users/nLight/following{/other_user}","gists_url":"https://api.github.com/users/nLight/gists{/gist_id}","starred_url":"https://api.github.com/users/nLight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nLight/subscriptions","organizations_url":"https://api.github.com/users/nLight/orgs","repos_url":"https://api.github.com/users/nLight/repos","events_url":"https://api.github.com/users/nLight/events{/privacy}","received_events_url":"https://api.github.com/users/nLight/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T13:49:57Z","updated_at":"2016-12-15T13:49:57Z","body":"Gotta remove Service Endpoints section, thus `hold merge`"}}
{"actor":{"display_login":"nLight"}}