{"action":"created","comment":{"url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/comments/72690877","id":72690877,"diff_hunk":"@@ -1400,13 +1400,16 @@ function setMediaMaxSize(media) {\n }\n \n function addDragListener({ media, atShiftKey, onStart, onMove }) {\n-\tlet isActive, hasMoved, lastX, lastY;\n+\tlet isActive, isReleased, hasMoved, lastX, lastY;\n \n \tconst handleMove = frameDebounce(e => {\n-\t\tif (!e.movementX && !e.movementY) {\n+\t\tif (\n+\t\t\tprocess.env.BUILD_TARGET !== 'safari' && // Safari lacks e.movement(X|Y)","path":"lib/modules/showImages.js","position":10,"original_position":10,"commit_id":"680f51a5d82c4376dc48eb1b6860de7a78e784c0","original_commit_id":"680f51a5d82c4376dc48eb1b6860de7a78e784c0","user":{"login":"erikdesjardins","id":7673145,"avatar_url":"https://avatars.githubusercontent.com/u/7673145?v=3","gravatar_id":"","url":"https://api.github.com/users/erikdesjardins","html_url":"https://github.com/erikdesjardins","followers_url":"https://api.github.com/users/erikdesjardins/followers","following_url":"https://api.github.com/users/erikdesjardins/following{/other_user}","gists_url":"https://api.github.com/users/erikdesjardins/gists{/gist_id}","starred_url":"https://api.github.com/users/erikdesjardins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikdesjardins/subscriptions","organizations_url":"https://api.github.com/users/erikdesjardins/orgs","repos_url":"https://api.github.com/users/erikdesjardins/repos","events_url":"https://api.github.com/users/erikdesjardins/events{/privacy}","received_events_url":"https://api.github.com/users/erikdesjardins/received_events","type":"User","site_admin":false},"body":"Yeah this prevents a click from opening the image in Safari. May have to add a `mousedown` listener to set the initial `lastX` and `lastY` and use `e.clientX - lastX` instead of `e.movementX`, if that would be equivalent.","created_at":"2016-07-28T19:55:31Z","updated_at":"2016-07-28T19:55:32Z","html_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/3211#discussion_r72690877","pull_request_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/3211","_links":{"self":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/comments/72690877"},"html":{"href":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/3211#discussion_r72690877"},"pull_request":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/3211"}}},"pull_request":{"url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/3211","id":79215491,"html_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/3211","diff_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/3211.diff","patch_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/3211.patch","issue_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/3211","number":3211,"state":"open","locked":false,"title":"showImages addDragListener: Safari compatibility","user":{"login":"larsjohnsen","id":1748521,"avatar_url":"https://avatars.githubusercontent.com/u/1748521?v=3","gravatar_id":"","url":"https://api.github.com/users/larsjohnsen","html_url":"https://github.com/larsjohnsen","followers_url":"https://api.github.com/users/larsjohnsen/followers","following_url":"https://api.github.com/users/larsjohnsen/following{/other_user}","gists_url":"https://api.github.com/users/larsjohnsen/gists{/gist_id}","starred_url":"https://api.github.com/users/larsjohnsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsjohnsen/subscriptions","organizations_url":"https://api.github.com/users/larsjohnsen/orgs","repos_url":"https://api.github.com/users/larsjohnsen/repos","events_url":"https://api.github.com/users/larsjohnsen/events{/privacy}","received_events_url":"https://api.github.com/users/larsjohnsen/received_events","type":"User","site_admin":false},"body":"Safari does not expose `MouseEvent.movementX`, `MouseEvent.movementY`, and `MouseEvent.buttons`, which my implementation required. This provides a workaround in order to make `addDragListener` Safari compatible.\r\n\r\nPlease note that I have not had the opportunity to test this on Safari yet.\r\n\r\nFixes #3209 ","created_at":"2016-07-28T15:20:38Z","updated_at":"2016-07-28T19:55:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0937ee1bd9466441c98ddd860a5a207ff1838805","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/3211/commits","review_comments_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/3211/comments","review_comment_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/3211/comments","statuses_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/statuses/680f51a5d82c4376dc48eb1b6860de7a78e784c0","head":{"label":"larsjohnsen:drag-safari-compatible","ref":"drag-safari-compatible","sha":"680f51a5d82c4376dc48eb1b6860de7a78e784c0","user":{"login":"larsjohnsen","id":1748521,"avatar_url":"https://avatars.githubusercontent.com/u/1748521?v=3","gravatar_id":"","url":"https://api.github.com/users/larsjohnsen","html_url":"https://github.com/larsjohnsen","followers_url":"https://api.github.com/users/larsjohnsen/followers","following_url":"https://api.github.com/users/larsjohnsen/following{/other_user}","gists_url":"https://api.github.com/users/larsjohnsen/gists{/gist_id}","starred_url":"https://api.github.com/users/larsjohnsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsjohnsen/subscriptions","organizations_url":"https://api.github.com/users/larsjohnsen/orgs","repos_url":"https://api.github.com/users/larsjohnsen/repos","events_url":"https://api.github.com/users/larsjohnsen/events{/privacy}","received_events_url":"https://api.github.com/users/larsjohnsen/received_events","type":"User","site_admin":false},"repo":{"id":54233607,"name":"Reddit-Enhancement-Suite","full_name":"larsjohnsen/Reddit-Enhancement-Suite","owner":{"login":"larsjohnsen","id":1748521,"avatar_url":"https://avatars.githubusercontent.com/u/1748521?v=3","gravatar_id":"","url":"https://api.github.com/users/larsjohnsen","html_url":"https://github.com/larsjohnsen","followers_url":"https://api.github.com/users/larsjohnsen/followers","following_url":"https://api.github.com/users/larsjohnsen/following{/other_user}","gists_url":"https://api.github.com/users/larsjohnsen/gists{/gist_id}","starred_url":"https://api.github.com/users/larsjohnsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsjohnsen/subscriptions","organizations_url":"https://api.github.com/users/larsjohnsen/orgs","repos_url":"https://api.github.com/users/larsjohnsen/repos","events_url":"https://api.github.com/users/larsjohnsen/events{/privacy}","received_events_url":"https://api.github.com/users/larsjohnsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/larsjohnsen/Reddit-Enhancement-Suite","description":"Reddit Enhancement Suite","fork":true,"url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite","forks_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/forks","keys_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/teams","hooks_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/hooks","issue_events_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/issues/events{/number}","events_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/events","assignees_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/assignees{/user}","branches_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/branches{/branch}","tags_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/tags","blobs_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/git/refs{/sha}","trees_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/statuses/{sha}","languages_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/languages","stargazers_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/stargazers","contributors_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/contributors","subscribers_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/subscribers","subscription_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/subscription","commits_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/commits{/sha}","git_commits_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/git/commits{/sha}","comments_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/comments{/number}","issue_comment_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/issues/comments{/number}","contents_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/contents/{+path}","compare_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/merges","archive_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/downloads","issues_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/issues{/number}","pulls_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/pulls{/number}","milestones_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/milestones{/number}","notifications_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/labels{/name}","releases_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/releases{/id}","deployments_url":"https://api.github.com/repos/larsjohnsen/Reddit-Enhancement-Suite/deployments","created_at":"2016-03-18T21:52:21Z","updated_at":"2016-05-29T08:23:34Z","pushed_at":"2016-07-28T15:25:26Z","git_url":"git://github.com/larsjohnsen/Reddit-Enhancement-Suite.git","ssh_url":"git@github.com:larsjohnsen/Reddit-Enhancement-Suite.git","clone_url":"https://github.com/larsjohnsen/Reddit-Enhancement-Suite.git","svn_url":"https://github.com/larsjohnsen/Reddit-Enhancement-Suite","homepage":"http://redditenhancementsuite.com","size":23879,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"honestbleeps:master","ref":"master","sha":"841d11c8449bb71085458fcc1c0eb897b40ca0c9","user":{"login":"honestbleeps","id":323763,"avatar_url":"https://avatars.githubusercontent.com/u/323763?v=3","gravatar_id":"","url":"https://api.github.com/users/honestbleeps","html_url":"https://github.com/honestbleeps","followers_url":"https://api.github.com/users/honestbleeps/followers","following_url":"https://api.github.com/users/honestbleeps/following{/other_user}","gists_url":"https://api.github.com/users/honestbleeps/gists{/gist_id}","starred_url":"https://api.github.com/users/honestbleeps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honestbleeps/subscriptions","organizations_url":"https://api.github.com/users/honestbleeps/orgs","repos_url":"https://api.github.com/users/honestbleeps/repos","events_url":"https://api.github.com/users/honestbleeps/events{/privacy}","received_events_url":"https://api.github.com/users/honestbleeps/received_events","type":"User","site_admin":false},"repo":{"id":2688907,"name":"Reddit-Enhancement-Suite","full_name":"honestbleeps/Reddit-Enhancement-Suite","owner":{"login":"honestbleeps","id":323763,"avatar_url":"https://avatars.githubusercontent.com/u/323763?v=3","gravatar_id":"","url":"https://api.github.com/users/honestbleeps","html_url":"https://github.com/honestbleeps","followers_url":"https://api.github.com/users/honestbleeps/followers","following_url":"https://api.github.com/users/honestbleeps/following{/other_user}","gists_url":"https://api.github.com/users/honestbleeps/gists{/gist_id}","starred_url":"https://api.github.com/users/honestbleeps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honestbleeps/subscriptions","organizations_url":"https://api.github.com/users/honestbleeps/orgs","repos_url":"https://api.github.com/users/honestbleeps/repos","events_url":"https://api.github.com/users/honestbleeps/events{/privacy}","received_events_url":"https://api.github.com/users/honestbleeps/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite","description":"Reddit Enhancement Suite","fork":false,"url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite","forks_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/forks","keys_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/teams","hooks_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/hooks","issue_events_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/events{/number}","events_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/events","assignees_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/assignees{/user}","branches_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/branches{/branch}","tags_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/tags","blobs_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/git/refs{/sha}","trees_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/statuses/{sha}","languages_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/languages","stargazers_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/stargazers","contributors_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/contributors","subscribers_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/subscribers","subscription_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/subscription","commits_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/commits{/sha}","git_commits_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/git/commits{/sha}","comments_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/comments{/number}","issue_comment_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/comments{/number}","contents_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/contents/{+path}","compare_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/merges","archive_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/downloads","issues_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues{/number}","pulls_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls{/number}","milestones_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/milestones{/number}","notifications_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/labels{/name}","releases_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/releases{/id}","deployments_url":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/deployments","created_at":"2011-11-01T16:31:51Z","updated_at":"2016-07-28T12:04:31Z","pushed_at":"2016-07-28T15:25:26Z","git_url":"git://github.com/honestbleeps/Reddit-Enhancement-Suite.git","ssh_url":"git@github.com:honestbleeps/Reddit-Enhancement-Suite.git","clone_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite.git","svn_url":"https://github.com/honestbleeps/Reddit-Enhancement-Suite","homepage":"http://redditenhancementsuite.com","size":123999,"stargazers_count":1134,"watchers_count":1134,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":513,"mirror_url":null,"open_issues_count":539,"forks":513,"open_issues":539,"watchers":1134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/3211"},"html":{"href":"https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/3211"},"issue":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/3211"},"comments":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/issues/3211/comments"},"review_comments":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/3211/comments"},"review_comment":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/pulls/3211/commits"},"statuses":{"href":"https://api.github.com/repos/honestbleeps/Reddit-Enhancement-Suite/statuses/680f51a5d82c4376dc48eb1b6860de7a78e784c0"}}}}
{"actor":{"display_login":"erikdesjardins"}}