{"action":"created","comment":{"url":"https://api.github.com/repos/enthought/pyface/pulls/comments/68378797","id":68378797,"diff_hunk":"@@ -348,6 +347,9 @@ def _destroy_state(self, state):\n             if state.menu_bar_manager:\n                 state.menu_bar_manager.destroy()\n             for tool_bar_manager in state.tool_bar_managers:\n+                # FIXME: toolbars were not getting removed, but this isn't the right place for it\n+                pane = self._window_backend.window._aui_manager.GetPane(tool_bar_manager.id)","path":"pyface/tasks/task_window.py","position":13,"original_position":13,"commit_id":"77da84ecbc6d98350f84dc75350edd2794b41479","original_commit_id":"2e77447bad6d0343f27d4a1c8ddb774914f4bc2a","user":{"login":"corranwebster","id":600761,"avatar_url":"https://avatars.githubusercontent.com/u/600761?v=3","gravatar_id":"","url":"https://api.github.com/users/corranwebster","html_url":"https://github.com/corranwebster","followers_url":"https://api.github.com/users/corranwebster/followers","following_url":"https://api.github.com/users/corranwebster/following{/other_user}","gists_url":"https://api.github.com/users/corranwebster/gists{/gist_id}","starred_url":"https://api.github.com/users/corranwebster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corranwebster/subscriptions","organizations_url":"https://api.github.com/users/corranwebster/orgs","repos_url":"https://api.github.com/users/corranwebster/repos","events_url":"https://api.github.com/users/corranwebster/events{/privacy}","received_events_url":"https://api.github.com/users/corranwebster/received_events","type":"User","site_admin":false},"body":"@mdickinson pointed out that this seems to be assuming a Wx backend and will likely break under Qt.","created_at":"2016-06-24T10:08:45Z","updated_at":"2016-06-24T10:08:45Z","html_url":"https://github.com/enthought/pyface/pull/223#discussion_r68378797","pull_request_url":"https://api.github.com/repos/enthought/pyface/pulls/223","_links":{"self":{"href":"https://api.github.com/repos/enthought/pyface/pulls/comments/68378797"},"html":{"href":"https://github.com/enthought/pyface/pull/223#discussion_r68378797"},"pull_request":{"href":"https://api.github.com/repos/enthought/pyface/pulls/223"}}},"pull_request":{"url":"https://api.github.com/repos/enthought/pyface/pulls/223","id":74665088,"html_url":"https://github.com/enthought/pyface/pull/223","diff_url":"https://github.com/enthought/pyface/pull/223.diff","patch_url":"https://github.com/enthought/pyface/pull/223.patch","issue_url":"https://api.github.com/repos/enthought/pyface/issues/223","number":223,"state":"open","locked":false,"title":"Tasks support for wx","user":{"login":"robmcmullen","id":896656,"avatar_url":"https://avatars.githubusercontent.com/u/896656?v=3","gravatar_id":"","url":"https://api.github.com/users/robmcmullen","html_url":"https://github.com/robmcmullen","followers_url":"https://api.github.com/users/robmcmullen/followers","following_url":"https://api.github.com/users/robmcmullen/following{/other_user}","gists_url":"https://api.github.com/users/robmcmullen/gists{/gist_id}","starred_url":"https://api.github.com/users/robmcmullen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robmcmullen/subscriptions","organizations_url":"https://api.github.com/users/robmcmullen/orgs","repos_url":"https://api.github.com/users/robmcmullen/repos","events_url":"https://api.github.com/users/robmcmullen/events{/privacy}","received_events_url":"https://api.github.com/users/robmcmullen/received_events","type":"User","site_admin":false},"body":"Here's my big patch for tasks support for wxPython. It requires wxPython (classic) 3.0.2; wxPython 2.8 is not supported. It uses the wx.lib.agw.aui toolkit for the central pane management and toolbars. The AuiManager class used as the basis for the TaskLayout is not quite as flexible as the Qt layout manager in that AUI can't nest VSplitter and HSplitters arbitrarily deeply; my implementation is limited to 2 levels: either a VSplitter inside an HSplitter or an HSplitter inside a VSplitter.\r\n\r\nI've included a bunch of examples in the examples/tasks/steps directory, which includes a series of small programs that I used to build up tasks support for wx.","created_at":"2016-06-21T18:48:31Z","updated_at":"2016-06-24T10:08:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05e4f19e453a13aece3982bcb0c99df72be654be","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/enthought/pyface/pulls/223/commits","review_comments_url":"https://api.github.com/repos/enthought/pyface/pulls/223/comments","review_comment_url":"https://api.github.com/repos/enthought/pyface/pulls/comments{/number}","comments_url":"https://api.github.com/repos/enthought/pyface/issues/223/comments","statuses_url":"https://api.github.com/repos/enthought/pyface/statuses/77da84ecbc6d98350f84dc75350edd2794b41479","head":{"label":"robmcmullen:robm-wxtasks","ref":"robm-wxtasks","sha":"77da84ecbc6d98350f84dc75350edd2794b41479","user":{"login":"robmcmullen","id":896656,"avatar_url":"https://avatars.githubusercontent.com/u/896656?v=3","gravatar_id":"","url":"https://api.github.com/users/robmcmullen","html_url":"https://github.com/robmcmullen","followers_url":"https://api.github.com/users/robmcmullen/followers","following_url":"https://api.github.com/users/robmcmullen/following{/other_user}","gists_url":"https://api.github.com/users/robmcmullen/gists{/gist_id}","starred_url":"https://api.github.com/users/robmcmullen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robmcmullen/subscriptions","organizations_url":"https://api.github.com/users/robmcmullen/orgs","repos_url":"https://api.github.com/users/robmcmullen/repos","events_url":"https://api.github.com/users/robmcmullen/events{/privacy}","received_events_url":"https://api.github.com/users/robmcmullen/received_events","type":"User","site_admin":false},"repo":{"id":15294202,"name":"pyface","full_name":"robmcmullen/pyface","owner":{"login":"robmcmullen","id":896656,"avatar_url":"https://avatars.githubusercontent.com/u/896656?v=3","gravatar_id":"","url":"https://api.github.com/users/robmcmullen","html_url":"https://github.com/robmcmullen","followers_url":"https://api.github.com/users/robmcmullen/followers","following_url":"https://api.github.com/users/robmcmullen/following{/other_user}","gists_url":"https://api.github.com/users/robmcmullen/gists{/gist_id}","starred_url":"https://api.github.com/users/robmcmullen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robmcmullen/subscriptions","organizations_url":"https://api.github.com/users/robmcmullen/orgs","repos_url":"https://api.github.com/users/robmcmullen/repos","events_url":"https://api.github.com/users/robmcmullen/events{/privacy}","received_events_url":"https://api.github.com/users/robmcmullen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robmcmullen/pyface","description":"","fork":true,"url":"https://api.github.com/repos/robmcmullen/pyface","forks_url":"https://api.github.com/repos/robmcmullen/pyface/forks","keys_url":"https://api.github.com/repos/robmcmullen/pyface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robmcmullen/pyface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robmcmullen/pyface/teams","hooks_url":"https://api.github.com/repos/robmcmullen/pyface/hooks","issue_events_url":"https://api.github.com/repos/robmcmullen/pyface/issues/events{/number}","events_url":"https://api.github.com/repos/robmcmullen/pyface/events","assignees_url":"https://api.github.com/repos/robmcmullen/pyface/assignees{/user}","branches_url":"https://api.github.com/repos/robmcmullen/pyface/branches{/branch}","tags_url":"https://api.github.com/repos/robmcmullen/pyface/tags","blobs_url":"https://api.github.com/repos/robmcmullen/pyface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robmcmullen/pyface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robmcmullen/pyface/git/refs{/sha}","trees_url":"https://api.github.com/repos/robmcmullen/pyface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robmcmullen/pyface/statuses/{sha}","languages_url":"https://api.github.com/repos/robmcmullen/pyface/languages","stargazers_url":"https://api.github.com/repos/robmcmullen/pyface/stargazers","contributors_url":"https://api.github.com/repos/robmcmullen/pyface/contributors","subscribers_url":"https://api.github.com/repos/robmcmullen/pyface/subscribers","subscription_url":"https://api.github.com/repos/robmcmullen/pyface/subscription","commits_url":"https://api.github.com/repos/robmcmullen/pyface/commits{/sha}","git_commits_url":"https://api.github.com/repos/robmcmullen/pyface/git/commits{/sha}","comments_url":"https://api.github.com/repos/robmcmullen/pyface/comments{/number}","issue_comment_url":"https://api.github.com/repos/robmcmullen/pyface/issues/comments{/number}","contents_url":"https://api.github.com/repos/robmcmullen/pyface/contents/{+path}","compare_url":"https://api.github.com/repos/robmcmullen/pyface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robmcmullen/pyface/merges","archive_url":"https://api.github.com/repos/robmcmullen/pyface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robmcmullen/pyface/downloads","issues_url":"https://api.github.com/repos/robmcmullen/pyface/issues{/number}","pulls_url":"https://api.github.com/repos/robmcmullen/pyface/pulls{/number}","milestones_url":"https://api.github.com/repos/robmcmullen/pyface/milestones{/number}","notifications_url":"https://api.github.com/repos/robmcmullen/pyface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robmcmullen/pyface/labels{/name}","releases_url":"https://api.github.com/repos/robmcmullen/pyface/releases{/id}","deployments_url":"https://api.github.com/repos/robmcmullen/pyface/deployments","created_at":"2013-12-18T21:03:19Z","updated_at":"2016-06-12T09:35:41Z","pushed_at":"2016-06-24T01:59:06Z","git_url":"git://github.com/robmcmullen/pyface.git","ssh_url":"git@github.com:robmcmullen/pyface.git","clone_url":"https://github.com/robmcmullen/pyface.git","svn_url":"https://github.com/robmcmullen/pyface","homepage":"","size":13670,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"enthought:master","ref":"master","sha":"d2808b263680309765770efe18e0bcec53a9a6e4","user":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=3","gravatar_id":"","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"repo":{"id":1632976,"name":"pyface","full_name":"enthought/pyface","owner":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=3","gravatar_id":"","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enthought/pyface","description":"pyface: traits-capable windowing framework","fork":false,"url":"https://api.github.com/repos/enthought/pyface","forks_url":"https://api.github.com/repos/enthought/pyface/forks","keys_url":"https://api.github.com/repos/enthought/pyface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enthought/pyface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enthought/pyface/teams","hooks_url":"https://api.github.com/repos/enthought/pyface/hooks","issue_events_url":"https://api.github.com/repos/enthought/pyface/issues/events{/number}","events_url":"https://api.github.com/repos/enthought/pyface/events","assignees_url":"https://api.github.com/repos/enthought/pyface/assignees{/user}","branches_url":"https://api.github.com/repos/enthought/pyface/branches{/branch}","tags_url":"https://api.github.com/repos/enthought/pyface/tags","blobs_url":"https://api.github.com/repos/enthought/pyface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enthought/pyface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enthought/pyface/git/refs{/sha}","trees_url":"https://api.github.com/repos/enthought/pyface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enthought/pyface/statuses/{sha}","languages_url":"https://api.github.com/repos/enthought/pyface/languages","stargazers_url":"https://api.github.com/repos/enthought/pyface/stargazers","contributors_url":"https://api.github.com/repos/enthought/pyface/contributors","subscribers_url":"https://api.github.com/repos/enthought/pyface/subscribers","subscription_url":"https://api.github.com/repos/enthought/pyface/subscription","commits_url":"https://api.github.com/repos/enthought/pyface/commits{/sha}","git_commits_url":"https://api.github.com/repos/enthought/pyface/git/commits{/sha}","comments_url":"https://api.github.com/repos/enthought/pyface/comments{/number}","issue_comment_url":"https://api.github.com/repos/enthought/pyface/issues/comments{/number}","contents_url":"https://api.github.com/repos/enthought/pyface/contents/{+path}","compare_url":"https://api.github.com/repos/enthought/pyface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enthought/pyface/merges","archive_url":"https://api.github.com/repos/enthought/pyface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enthought/pyface/downloads","issues_url":"https://api.github.com/repos/enthought/pyface/issues{/number}","pulls_url":"https://api.github.com/repos/enthought/pyface/pulls{/number}","milestones_url":"https://api.github.com/repos/enthought/pyface/milestones{/number}","notifications_url":"https://api.github.com/repos/enthought/pyface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enthought/pyface/labels{/name}","releases_url":"https://api.github.com/repos/enthought/pyface/releases{/id}","deployments_url":"https://api.github.com/repos/enthought/pyface/deployments","created_at":"2011-04-18T22:32:06Z","updated_at":"2016-06-23T14:36:22Z","pushed_at":"2016-06-24T01:59:07Z","git_url":"git://github.com/enthought/pyface.git","ssh_url":"git@github.com:enthought/pyface.git","clone_url":"https://github.com/enthought/pyface.git","svn_url":"https://github.com/enthought/pyface","homepage":"","size":16225,"stargazers_count":33,"watchers_count":33,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"open_issues_count":39,"forks":24,"open_issues":39,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enthought/pyface/pulls/223"},"html":{"href":"https://github.com/enthought/pyface/pull/223"},"issue":{"href":"https://api.github.com/repos/enthought/pyface/issues/223"},"comments":{"href":"https://api.github.com/repos/enthought/pyface/issues/223/comments"},"review_comments":{"href":"https://api.github.com/repos/enthought/pyface/pulls/223/comments"},"review_comment":{"href":"https://api.github.com/repos/enthought/pyface/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/enthought/pyface/pulls/223/commits"},"statuses":{"href":"https://api.github.com/repos/enthought/pyface/statuses/77da84ecbc6d98350f84dc75350edd2794b41479"}}}}
{"actor":{"display_login":"corranwebster"}}