{"action":"created","comment":{"url":"https://api.github.com/repos/benchflow/analysers/pulls/comments/68751623","id":68751623,"diff_hunk":"@@ -0,0 +1,97 @@\n+import sys\n+import json\n+import io\n+import gzip\n+import uuid\n+import math\n+\n+from datetime import timedelta\n+\n+import numpy as np\n+\n+from pyspark_cassandra import CassandraSparkContext\n+from pyspark_cassandra import RowFormat\n+from pyspark import SparkConf\n+\n+def createQuery(sc, dataRDD, experimentID, trialID):\n+    from commons import computeMode, computeMetrics\n+    \n+    queries = []\n+    \n+    modeRDD = dataRDD.filter(lambda r: r['duration'] != None) \\\n+            .map(lambda r: (r['duration'], 1)) \\\n+            .cache()\n+                   \n+    mode = computeMode(modeRDD)\n+    \n+    data = dataRDD.map(lambda r: r['duration']).collect()\n+    metrics = computeMetrics(data)\n+    \n+    queries.append({\"construct_name\":\"all\", \"construct_type\":\"all\", \"experiment_id\":experimentID, \"trial_id\":trialID, \"construct_duration_mode\":mode[0], \\\n+                    \"construct_duration_mode_freq\":mode[1], \"construct_duration_p90\":metrics[\"p90\"], \"construct_duration_p99\":metrics[\"p99\"], \\\n+                    \"construct_duration_percentiles\":metrics[\"percentiles\"], \\\n+                  \"construct_duration_mean\":metrics[\"mean\"], \"construct_duration_num_data_points\":metrics[\"num_data_points\"], \\\n+                  \"construct_duration_min\":metrics[\"min\"], \"construct_duration_max\":metrics[\"max\"], \"construct_duration_sd\":metrics[\"sd\"], \\\n+                  \"construct_duration_q1\":metrics[\"q1\"], \"construct_duration_q2\":metrics[\"q2\"], \"construct_duration_q3\":metrics[\"q3\"], \"construct_duration_p95\":metrics[\"p95\"], \\\n+                  \"construct_duration_me\":metrics[\"me\"], \"construct_duration_ci095_min\":metrics[\"ci095_min\"], \"construct_duration_ci095_max\":metrics[\"ci095_max\"]})\n+    \n+    constructs = dataRDD.map(lambda a: a[\"construct_name\"]).distinct().collect()","path":"analysers/trials/constructDuration.py","position":null,"original_position":38,"commit_id":"b6eefe28d2bc1cc7a0c93608c37f50f5dd7704c8","original_commit_id":"046b7d881eed1590e5ee2242a455b9f9c0db407d","user":{"login":"Cerfoglg","id":8819678,"avatar_url":"https://avatars.githubusercontent.com/u/8819678?v=3","gravatar_id":"","url":"https://api.github.com/users/Cerfoglg","html_url":"https://github.com/Cerfoglg","followers_url":"https://api.github.com/users/Cerfoglg/followers","following_url":"https://api.github.com/users/Cerfoglg/following{/other_user}","gists_url":"https://api.github.com/users/Cerfoglg/gists{/gist_id}","starred_url":"https://api.github.com/users/Cerfoglg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cerfoglg/subscriptions","organizations_url":"https://api.github.com/users/Cerfoglg/orgs","repos_url":"https://api.github.com/users/Cerfoglg/repos","events_url":"https://api.github.com/users/Cerfoglg/events{/privacy}","received_events_url":"https://api.github.com/users/Cerfoglg/received_events","type":"User","site_admin":false},"body":"@VincenzoFerme The reason why I check afterwards is because I can't save None types to the trial table, as those are part of the Primary Key. I do however want to select processes with type or name as None in the computations either way.\r\n\r\nLeaving a comment in the code about this","created_at":"2016-06-28T13:05:08Z","updated_at":"2016-06-28T13:05:08Z","html_url":"https://github.com/benchflow/analysers/pull/75#discussion_r68751623","pull_request_url":"https://api.github.com/repos/benchflow/analysers/pulls/75","_links":{"self":{"href":"https://api.github.com/repos/benchflow/analysers/pulls/comments/68751623"},"html":{"href":"https://github.com/benchflow/analysers/pull/75#discussion_r68751623"},"pull_request":{"href":"https://api.github.com/repos/benchflow/analysers/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/benchflow/analysers/pulls/75","id":72607736,"html_url":"https://github.com/benchflow/analysers/pull/75","diff_url":"https://github.com/benchflow/analysers/pull/75.diff","patch_url":"https://github.com/benchflow/analysers/pull/75.patch","issue_url":"https://api.github.com/repos/benchflow/analysers/issues/75","number":75,"state":"open","locked":false,"title":"New computations and data","user":{"login":"Cerfoglg","id":8819678,"avatar_url":"https://avatars.githubusercontent.com/u/8819678?v=3","gravatar_id":"","url":"https://api.github.com/users/Cerfoglg","html_url":"https://github.com/Cerfoglg","followers_url":"https://api.github.com/users/Cerfoglg/followers","following_url":"https://api.github.com/users/Cerfoglg/following{/other_user}","gists_url":"https://api.github.com/users/Cerfoglg/gists{/gist_id}","starred_url":"https://api.github.com/users/Cerfoglg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cerfoglg/subscriptions","organizations_url":"https://api.github.com/users/Cerfoglg/orgs","repos_url":"https://api.github.com/users/Cerfoglg/repos","events_url":"https://api.github.com/users/Cerfoglg/events{/privacy}","received_events_url":"https://api.github.com/users/Cerfoglg/received_events","type":"User","site_admin":false},"body":"fixes #69, #68, #67, #62, #53, #47, #27, #22\r\n\r\nTodos:\r\n\r\n- [ ] Split the pull request in more pull requests (perform a new pull request starting from the current state of the code without applying fixes, then commits the fixes mapping them to the comment I left in this pull request):\r\n  - **Commons and Configuration Updates**: `analysers/commons/commons.py`, `analysers/conf/analysers/camunda.analysers.yml`\r\n  - **Experiments Processes Metrics**: all the experiments metrics belonging to processes\r\n  - **Experiments Constructs Metrics**: all the experiments metrics belonging to constructs\r\n  - **Trials Processes Metrics**: all the trials metrics belonging to processes\r\n  - **Trials Constructs Metrics**: all the trials metrics belonging to constructs\r\n- [ ] Map the comment in this pull request to new commits in the new pull requests opened according to the previous point, so that we can track which ones and where are fixed\r\n- [ ] Missing the Faban response times metrics at experiment level\r\n- [ ] Missing the Faban metrics on run info: transformer (duration), experiment (normal statistics on duration, metric_value [keeping the unit], passes [boolean AND])\r\n- [ ] Read commit history and check everything\r\n- [ ] Enable back Cassandra tests\r\n- [ ] Add test for all the functions\r\n- [ ] https://www.codacy.com/app/BenchFlow/analysers/pullRequest?prid=250923\r\n- [ ] https://travis-ci.org/benchflow/analysers/builds/135278743\r\n- [ ] https://github.com/benchflow/collectors/issues/65\r\n- [ ] Where do you compute the percentiles on metrics like the `throughput`?\r\n- [ ] Remove Alluxio from this pull, then perform a new pull just for Alluxio used in the right parts of the code\r\n- [ ] Check that all the metrics we defined are here and correctly computed and tested\r\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65807787%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65807845%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65807871%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65807879%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65813598%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65813797%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65813803%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65813891%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65813896%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65813950%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65813977%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65813989%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814200%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814203%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814204%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814221%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814242%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814429%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814496%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814533%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814542%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814596%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814792%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814794%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814805%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65819003%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65819263%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r67340118%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r67340122%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r67340123%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r67340126%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r67340128%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r67340130%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r67340131%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r67340132%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r67340134%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r67340136%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r67340138%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r67340140%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r67340142%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r67340144%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r67340145%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68120358%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68120375%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68120391%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23issuecomment-227855914%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68437679%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68437692%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68437702%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68437710%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68452105%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68452634%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68453129%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68456543%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68458174%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68458300%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68462536%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68462706%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68462921%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68464014%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68464047%22%2C%20%22https%3A//github.com/benchflow/analysers/pull/75%23issuecomment-228464625%22%5D%2C%20%22comments%22%3A%20%7B%22Pull%203c860d34faa77e7cd75b97356946bffb8e220bcc%20analysers/trials/constructDuration.py%2050%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68453129%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22I%20guess%20this%20part%20should%20be%20before%20the%20computation%20of%20metrics%22%2C%20%22created_at%22%3A%20%222016-06-24T19%3A51%3A51Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/trials/constructDuration.py%3AL1-99%22%7D%2C%20%22Pull%203c860d34faa77e7cd75b97356946bffb8e220bcc%20analysers/experiments/constructDuration.py%2033%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68120358%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22This%20check%20should%20be%20at%20the%20beginning%2C%20what%20happens%20if%20it%20is%20%60Unspecified%60%20for%20the%20computation%20on%20https%3A//github.com/benchflow/analysers/pull/75/files%23diff-dc119ca3b3977aad5d2b2e2434d76438R22%22%2C%20%22created_at%22%3A%20%222016-06-22T19%3A37%3A26Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/experiments/constructDuration.py%3AL1-85%22%7D%2C%20%22Pull%203c860d34faa77e7cd75b97356946bffb8e220bcc%20analysers/trials/throughput.py%2032%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68464014%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22You%20should%20just%20use%20the%20%60execution%20time%60%20and%20the%20%60number%20of%20process%20instance%60%20metrics%2C%20not%20compute%20then%20again%20here%22%2C%20%22created_at%22%3A%20%222016-06-24T21%3A15%3A26Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/trials/throughput.py%3AL39-69%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/experiments/cpu.py%2052%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65813803%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22From%20%60host%60%22%2C%20%22created_at%22%3A%20%222016-06-05T08%3A44%3A23Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222016-06-16T13%3A07%3A35Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/experiments/cpu.py%3AL62-122%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/experiments/executionTime.py%2045%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65813977%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Where%20is%20the%20total%20execution%20time%20independent%20from%20the%20actual%20%60process_definition_id%60%3F%22%2C%20%22created_at%22%3A%20%222016-06-05T08%3A58%3A37Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222016-06-16T13%3A07%3A36Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/experiments/executionTime.py%3AL1-72%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/experiments/executionTime.py%2026%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65813950%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Why%20do%20you%20filter%20twice%3F%20Just%20filter%20one%20and%20cache%20the%20result%20if%20you%20need%20it%20twice%22%2C%20%22created_at%22%3A%20%222016-06-05T08%3A57%3A38Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222016-06-16T13%3A07%3A37Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/experiments/executionTime.py%3AL1-72%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/trials/faban.py%2035%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814496%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Why%20do%20you%20need%20to%20iterate%20over%20%60section%60%20after%20iterating%20over%20%60operation%60%3F%22%2C%20%22created_at%22%3A%20%222016-06-05T09%3A40%3A40Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/trials/faban.py%3AL1-82%22%7D%2C%20%22Pull%203c860d34faa77e7cd75b97356946bffb8e220bcc%20analysers/trials/executionTime.py%2042%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68458300%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Why%20just%20%60None%60%20and%20not%20%60%28None%2C%20None%29%60%3F%22%2C%20%22created_at%22%3A%20%222016-06-24T20%3A32%3A54Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/trials/executionTime.py%3AL1-96%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/trials/cpu.py%206%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814429%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Remove%22%2C%20%22created_at%22%3A%20%222016-06-05T09%3A35%3A59Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/trials/cpu.py%3AL50-68%22%7D%2C%20%22Pull%203c860d34faa77e7cd75b97356946bffb8e220bcc%20analysers/trials/throughput.py%2058%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68464047%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Why%20do%20you%20need%20to%20select%20%60to_ignore%60%3F%22%2C%20%22created_at%22%3A%20%222016-06-24T21%3A15%3A47Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/trials/throughput.py%3AL74-98%22%7D%2C%20%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23issuecomment-227855914%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%40Cerfoglg%20check%20in%20the%20first%20comment%2C%20the%20items%20that%20are%20done%20so%20that%20we%20can%20then%20check%20them%20together.%20I%20checked%20up%20to%20%60analysers/experiments/faban.py%60%20excluded.%22%2C%20%22created_at%22%3A%20%222016-06-22T19%3A47%3A16Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22%40Cerfoglg%20Review%20completed%2C%20all%20the%20comments%20are%20in%20https%3A//github.com/benchflow/analysers/pull/75%23issue-158514448%20%28all%20of%20them%2C%20do%20not%20trust%20the%20%60completed%60%20label%29.%20Most%20of%20the%20times%20I%20left%20a%20comment%20only%20the%20first%20time%20I%20noticed%20something%20to%20improve%2C%20you%20should%20apply%20it%20in%20all%20the%20other%20scripts%20where%20something%20similar%20can%20be%20improved.%20I%20did%20not%20check%20that%20everything%20mentioned%20in%20the%20related%20issues%20is%20actually%20completed%2C%20for%20that%20we%20need%20to%20discuss%20in%20person.%20After%20your%20fix%20all%20of%20them%20ping%20me%20and%20we%20setup%20a%20meeting%20to%20close%20this%20giant%20pull%20request.%22%2C%20%22created_at%22%3A%20%222016-06-24T21%3A19%3A20Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/commons/commons.py%2086%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65807845%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22We%20should%20have%20%60Alluxio%60%20as%20well%20here%22%2C%20%22created_at%22%3A%20%222016-06-04T21%3A23%3A35Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222016-06-16T13%3A07%3A35Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/commons/commons.py%3AL138-177%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/trials/ram.py%206%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814792%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Why%20do%20you%20need%20a%20%60try....catch%60%3F%22%2C%20%22created_at%22%3A%20%222016-06-05T10%3A05%3A25Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/trials/ram.py%3AL15-59%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/trials/constructDuration.py%2038%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814242%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22The%20same%20comments%20as%20per%20%60constructDuration.py%60%2C%20checking%20before%20the%20loop%20for%20%60type%60%20and%20%60construct%60%20that%20are%20%60None%60%22%2C%20%22created_at%22%3A%20%222016-06-05T09%3A22%3A21Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/trials/constructDuration.py%3AL1-98%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/trials/ram.py%2018%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814794%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Where%20do%20you%20define%20%60dataIntegral%60%3F%22%2C%20%22created_at%22%3A%20%222016-06-05T10%3A05%3A38Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/trials/ram.py%3AL15-59%22%7D%2C%20%22Pull%203c860d34faa77e7cd75b97356946bffb8e220bcc%20analysers/experiments/faban.py%20132%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68437679%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Just%20%60map%60%20once%20and%20then%20take%20%60min%60%20and%20%60max%60%22%2C%20%22created_at%22%3A%20%222016-06-24T18%3A06%3A29Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/experiments/faban.py%3AL1-176%22%7D%2C%20%22Pull%203c860d34faa77e7cd75b97356946bffb8e220bcc%20analysers/experiments/faban.py%20159%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68437692%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22This%20should%20be%20passes%20as%20part%20of%20the%20configuration%22%2C%20%22created_at%22%3A%20%222016-06-24T18%3A06%3A33Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/experiments/faban.py%3AL1-176%22%7D%2C%20%22Pull%203c860d34faa77e7cd75b97356946bffb8e220bcc%20analysers/trials/executionTime.py%2026%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68458174%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Assign%20it%20to%20the%20first%20value%20of%20data%20outside%20the%20loop%2C%20then%20loop%20from%20the%20second%20value%20on.%20The%20same%20for%20the%20code%20computing%20%60latest%60%22%2C%20%22created_at%22%3A%20%222016-06-24T20%3A31%3A45Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/trials/executionTime.py%3AL1-96%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/trials/numberOfConstructInstances.py%2015%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814542%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22You%20definitely%20need%20%60Alluxio%60%20because%20you%20apply%20different%20computations%20in%20different%20Script%20over%20the%20same%20data.%22%2C%20%22created_at%22%3A%20%222016-06-05T09%3A44%3A08Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/trials/numberOfConstructInstances.py%3AL1-66%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/experiments/numberOfProcessInstances.py%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814200%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Where%20is%20the%20metric%20for%20all%20the%20process%20instance%3F%22%2C%20%22created_at%22%3A%20%222016-06-05T09%3A18%3A09Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22%40VincenzoFerme%20In%20the%20trial%20tables%20we%20have%20process_definition_id%20%3D%20all%20for%20the%20stats%20on%20all%20process%20instances.%20The%20loop%20in%20this%20function%20will%20work%20on%20that%20too.%5Cr%5Cn%5Cr%5CnThis%20applies%20for%20the%20other%20parts%20you%20pointed%20this%20out%20too%22%2C%20%22created_at%22%3A%20%222016-06-05T15%3A26%3A59Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/8819678%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/Cerfoglg%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222016-06-16T13%3A07%3A39Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/experiments/numberOfProcessInstances.py%3AL18-43%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/experiments/throughput.py%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814221%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Where%20is%20the%20metric%20for%20all%20the%20process%20instance%3F%22%2C%20%22created_at%22%3A%20%222016-06-05T09%3A20%3A23Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222016-06-16T13%3A07%3A37Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/experiments/throughput.py%3AL18-43%22%7D%2C%20%22Pull%203c860d34faa77e7cd75b97356946bffb8e220bcc%20analysers/experiments/numberOfConstructInstances.py%2026%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68437710%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22This%20is%20often%20present%20in%20the%20code%3A%20why%20do%20you%20have%20two%20very%20similar%20%60filter%60%20%2B%20%60map%60%20here%20and%20on%20line%20https%3A//github.com/benchflow/analysers/pull/75/files%23diff-ff083bb8138c0743d316956959d94012R28%3F%22%2C%20%22created_at%22%3A%20%222016-06-24T18%3A06%3A39Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/experiments/numberOfConstructInstances.py%3AL1-81%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/trials/ram.py%2033%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814805%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Remove%22%2C%20%22created_at%22%3A%20%222016-06-05T10%3A06%3A27Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/trials/ram.py%3AL15-59%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/experiments/cpu.py%2089%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65813891%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22From%20%60host%60%22%2C%20%22created_at%22%3A%20%222016-06-05T08%3A52%3A28Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/experiments/cpu.py%3AL62-122%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/experiments/numberOfConstructInstances.py%2023%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65813989%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22The%20same%20comments%20as%20per%20%60constructDuration.py%60%22%2C%20%22created_at%22%3A%20%222016-06-05T08%3A59%3A52Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222016-06-16T13%3A07%3A36Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/experiments/numberOfConstructInstances.py%3AL1-75%22%7D%2C%20%22Pull%203c860d34faa77e7cd75b97356946bffb8e220bcc%20analysers/trials/executionTime.py%2033%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68456543%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22You%20can%20compute%20%60smallest%60%20and%20%60largest%60%20in%20a%20single%20for%22%2C%20%22created_at%22%3A%20%222016-06-24T20%3A19%3A11Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/trials/executionTime.py%3AL1-96%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/commons/commons.py%20104%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65807871%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22You%20should%20store%20both%20the%20test%20statistic%20and%20the%20p-value.%20http%3A//docs.scipy.org/doc/scipy-0.16.0/reference/generated/scipy.stats.levene.html%23scipy.stats.levene%22%2C%20%22created_at%22%3A%20%222016-06-04T21%3A26%3A13Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222016-06-16T13%3A07%3A37Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/commons/commons.py%3AL138-177%22%7D%2C%20%22Pull%203c860d34faa77e7cd75b97356946bffb8e220bcc%20analysers/experiments/executionTime.py%2030%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68120391%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Why%20you%20also%20have%20a%20similar%20operation%20on%20line%20https%3A//github.com/benchflow/analysers/pull/75/files%23diff-d34221bb2ed6e9d12b428bb0b94b721aR28%3F%22%2C%20%22created_at%22%3A%20%222016-06-22T19%3A37%3A38Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/experiments/executionTime.py%3AL1-74%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/trials/processDuration.py%2036%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814596%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Why%20do%20you%20filter%20twice%2C%20in%20two%20different%20ways%3F%22%2C%20%22created_at%22%3A%20%222016-06-05T09%3A49%3A21Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/trials/processDuration.py%3AL13-60%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/experiments/processDuration.py%2020%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814204%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Remove%22%2C%20%22created_at%22%3A%20%222016-06-05T09%3A18%3A40Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222016-06-16T13%3A07%3A35Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/experiments/processDuration.py%3AL14-44%22%7D%2C%20%22Pull%203c860d34faa77e7cd75b97356946bffb8e220bcc%20analysers/trials/numberOfConstructInstances.py%2030%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68462921%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22First%20check%2C%20then%20filter%22%2C%20%22created_at%22%3A%20%222016-06-24T21%3A06%3A50Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/trials/numberOfConstructInstances.py%3AL1-67%22%7D%2C%20%22Pull%203c860d34faa77e7cd75b97356946bffb8e220bcc%20analysers/trials/constructDuration.py%2021%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68452634%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Why%20do%20you%20need%20a%20different%20RDD%20just%20for%20the%20mode%20computation%3F%22%2C%20%22created_at%22%3A%20%222016-06-24T19%3A47%3A58Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/trials/constructDuration.py%3AL1-99%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/commons/commons.py%2094%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65807879%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22If%20you%20have%20at%20least%20two%20samples%2C%20you%20can%20perform%20the%20test.%20Check%20at%20least%20that%20before%20applying%20the%20computation.%22%2C%20%22created_at%22%3A%20%222016-06-04T21%3A27%3A01Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222016-06-16T13%3A07%3A34Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/commons/commons.py%3AL138-177%22%7D%2C%20%22Pull%203c860d34faa77e7cd75b97356946bffb8e220bcc%20analysers/experiments/faban.py%20160%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68437702%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Why%20the%20following%20is%20not%20executed%20in%20different%20%60Threads%60%3F%22%2C%20%22created_at%22%3A%20%222016-06-24T18%3A06%3A36Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/experiments/faban.py%3AL1-176%22%7D%2C%20%22Pull%203c860d34faa77e7cd75b97356946bffb8e220bcc%20analysers/experiments/constructDuration.py%2081%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68120375%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Move%20the%20%60ttl%60%20setting%3A%20%60hours%3D1%60%20in%20the%20STS%20configuration%20file.%22%2C%20%22created_at%22%3A%20%222016-06-22T19%3A37%3A30Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/experiments/constructDuration.py%3AL1-85%22%7D%2C%20%22Pull%203c860d34faa77e7cd75b97356946bffb8e220bcc%20analysers/trials/faban.py%2078%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68462706%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Use%20%60cassandraKeyspace%60%22%2C%20%22created_at%22%3A%20%222016-06-24T21%3A05%3A21Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/trials/faban.py%3AL1-82%22%7D%2C%20%22Pull%203c860d34faa77e7cd75b97356946bffb8e220bcc%20analysers/experiments/ram.py%2057%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68452105%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22This%20is%20already%20set%20as%20parameter%22%2C%20%22created_at%22%3A%20%222016-06-24T19%3A43%3A16Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/experiments/ram.py%3AL62-83%22%7D%2C%20%22Pull%203c860d34faa77e7cd75b97356946bffb8e220bcc%20analysers/trials/faban.py%2033%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r68462536%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Just%20use%20the%20%60host%60%20and%20%60operation%60%20couples%20and%20add%20the%20aggregate%20one%20for%20all%20the%20operations.%22%2C%20%22created_at%22%3A%20%222016-06-24T21%3A04%3A04Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/trials/faban.py%3AL1-82%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/experiments/constructDuration.py%2019%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65813598%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Select%20the%20distinct%20couple%20of%20%60construct_name%60%20AND%20%60construct_type%60%2C%20because%20you%20already%20have%20all%20the%20information%20on%20the%20actual%20existing%20couple%2C%20then%20you%20can%20avoid%20the%20next%20O%28N%5E2%29%20loop%20and%20just%20iterate%20linearly%20over%20the%20couple.%22%2C%20%22created_at%22%3A%20%222016-06-05T08%3A38%3A05Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222016-06-16T13%3A07%3A39Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/experiments/constructDuration.py%3AL1-79%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/experiments/constructDuration.py%2065%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65813797%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22This%20should%20come%20from%20%60Alluxio%60%20as%20well%22%2C%20%22created_at%22%3A%20%222016-06-05T08%3A43%3A17Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222016-06-16T13%3A07%3A38Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/experiments/constructDuration.py%3AL1-79%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/commons/commons.py%2017%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65807787%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Why%20%600%2C%20101%60%3F%22%2C%20%22created_at%22%3A%20%222016-06-04T21%3A18%3A06Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22%40VincenzoFerme%20because%20numpy%20records%20percentiles%20from%200%20to%20100%2C%20so%20we%20miss%20percentile%20100%20without%20doing%20that%20range%22%2C%20%22created_at%22%3A%20%222016-06-05T15%3A11%3A39Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/8819678%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/Cerfoglg%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222016-06-16T13%3A07%3A38Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/commons/commons.py%3AL30-44%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/experiments/processDuration.py%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814203%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Where%20is%20the%20metric%20for%20all%20the%20process%20instance%3F%22%2C%20%22created_at%22%3A%20%222016-06-05T09%3A18%3A30Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222016-06-16T13%3A07%3A38Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/experiments/processDuration.py%3AL14-44%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/trials/numberOfConstructInstances.py%2025%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65814533%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22The%20same%20comments%20as%20per%20%60constructDuration.py%60%2C%20checking%20before%20the%20loop%20for%20%60type%60%20and%20%60construct%60%20that%20are%20%60None%60%22%2C%20%22created_at%22%3A%20%222016-06-05T09%3A43%3A10Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/trials/numberOfConstructInstances.py%3AL1-66%22%7D%2C%20%22Pull%20046b7d881eed1590e5ee2242a455b9f9c0db407d%20analysers/experiments/cpu.py%2093%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/analysers/pull/75%23discussion_r65813896%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22From%20the%20right%20table.%22%2C%20%22created_at%22%3A%20%222016-06-05T08%3A52%3A29Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-complete%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222016-06-16T13%3A07%3A39Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20analysers/experiments/cpu.py%3AL62-122%22%7D%7D%7D'></a>\r\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/experiments/cpu.py 89'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65813891'>File: analysers/experiments/cpu.py:L62-122</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> From `host`\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/trials/constructDuration.py 38'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65814242'>File: analysers/trials/constructDuration.py:L1-98</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> The same comments as per `constructDuration.py`, checking before the loop for `type` and `construct` that are `None`\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/trials/cpu.py 6'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65814429'>File: analysers/trials/cpu.py:L50-68</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Remove\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/trials/faban.py 35'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65814496'>File: analysers/trials/faban.py:L1-82</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Why do you need to iterate over `section` after iterating over `operation`?\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/trials/numberOfConstructInstances.py 25'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65814533'>File: analysers/trials/numberOfConstructInstances.py:L1-66</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> The same comments as per `constructDuration.py`, checking before the loop for `type` and `construct` that are `None`\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/trials/numberOfConstructInstances.py 15'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65814542'>File: analysers/trials/numberOfConstructInstances.py:L1-66</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> You definitely need `Alluxio` because you apply different computations in different Script over the same data.\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/trials/processDuration.py 36'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65814596'>File: analysers/trials/processDuration.py:L13-60</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Why do you filter twice, in two different ways?\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/trials/ram.py 6'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65814792'>File: analysers/trials/ram.py:L15-59</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Why do you need a `try....catch`?\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/trials/ram.py 18'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65814794'>File: analysers/trials/ram.py:L15-59</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Where do you define `dataIntegral`?\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/trials/ram.py 33'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65814805'>File: analysers/trials/ram.py:L15-59</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Remove\r\n- [ ] <a href='#crh-comment-Pull 3c860d34faa77e7cd75b97356946bffb8e220bcc analysers/experiments/constructDuration.py 33'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r68120358'>File: analysers/experiments/constructDuration.py:L1-85</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> This check should be at the beginning, what happens if it is `Unspecified` for the computation on https://github.com/benchflow/analysers/pull/75/files#diff-dc119ca3b3977aad5d2b2e2434d76438R22\r\n- [ ] <a href='#crh-comment-Pull 3c860d34faa77e7cd75b97356946bffb8e220bcc analysers/experiments/constructDuration.py 81'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r68120375'>File: analysers/experiments/constructDuration.py:L1-85</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Move the `ttl` setting: `hours=1` in the STS configuration file.\r\n- [ ] <a href='#crh-comment-Pull 3c860d34faa77e7cd75b97356946bffb8e220bcc analysers/experiments/executionTime.py 30'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r68120391'>File: analysers/experiments/executionTime.py:L1-74</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Why you also have a similar operation on line https://github.com/benchflow/analysers/pull/75/files#diff-d34221bb2ed6e9d12b428bb0b94b721aR28?\r\n- [ ] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#issuecomment-227855914'>General Comment</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> @Cerfoglg check in the first comment, the items that are done so that we can then check them together. I checked up to `analysers/experiments/faban.py` excluded.\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> @Cerfoglg Review completed, all the comments are in https://github.com/benchflow/analysers/pull/75#issue-158514448 (all of them, do not trust the `completed` label). Most of the times I left a comment only the first time I noticed something to improve, you should apply it in all the other scripts where something similar can be improved. I did not check that everything mentioned in the related issues is actually completed, for that we need to discuss in person. After your fix all of them ping me and we setup a meeting to close this giant pull request.\r\n- [ ] <a href='#crh-comment-Pull 3c860d34faa77e7cd75b97356946bffb8e220bcc analysers/experiments/faban.py 132'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r68437679'>File: analysers/experiments/faban.py:L1-176</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Just `map` once and then take `min` and `max`\r\n- [ ] <a href='#crh-comment-Pull 3c860d34faa77e7cd75b97356946bffb8e220bcc analysers/experiments/faban.py 159'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r68437692'>File: analysers/experiments/faban.py:L1-176</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> This should be passes as part of the configuration\r\n- [ ] <a href='#crh-comment-Pull 3c860d34faa77e7cd75b97356946bffb8e220bcc analysers/experiments/faban.py 160'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r68437702'>File: analysers/experiments/faban.py:L1-176</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Why the following is not executed in different `Threads`?\r\n- [ ] <a href='#crh-comment-Pull 3c860d34faa77e7cd75b97356946bffb8e220bcc analysers/experiments/numberOfConstructInstances.py 26'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r68437710'>File: analysers/experiments/numberOfConstructInstances.py:L1-81</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> This is often present in the code: why do you have two very similar `filter` + `map` here and on line https://github.com/benchflow/analysers/pull/75/files#diff-ff083bb8138c0743d316956959d94012R28?\r\n- [ ] <a href='#crh-comment-Pull 3c860d34faa77e7cd75b97356946bffb8e220bcc analysers/experiments/ram.py 57'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r68452105'>File: analysers/experiments/ram.py:L62-83</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> This is already set as parameter\r\n- [ ] <a href='#crh-comment-Pull 3c860d34faa77e7cd75b97356946bffb8e220bcc analysers/trials/constructDuration.py 21'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r68452634'>File: analysers/trials/constructDuration.py:L1-99</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Why do you need a different RDD just for the mode computation?\r\n- [ ] <a href='#crh-comment-Pull 3c860d34faa77e7cd75b97356946bffb8e220bcc analysers/trials/constructDuration.py 50'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r68453129'>File: analysers/trials/constructDuration.py:L1-99</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> I guess this part should be before the computation of metrics\r\n- [ ] <a href='#crh-comment-Pull 3c860d34faa77e7cd75b97356946bffb8e220bcc analysers/trials/executionTime.py 33'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r68456543'>File: analysers/trials/executionTime.py:L1-96</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> You can compute `smallest` and `largest` in a single for\r\n- [ ] <a href='#crh-comment-Pull 3c860d34faa77e7cd75b97356946bffb8e220bcc analysers/trials/executionTime.py 26'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r68458174'>File: analysers/trials/executionTime.py:L1-96</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Assign it to the first value of data outside the loop, then loop from the second value on. The same for the code computing `latest`\r\n- [ ] <a href='#crh-comment-Pull 3c860d34faa77e7cd75b97356946bffb8e220bcc analysers/trials/executionTime.py 42'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r68458300'>File: analysers/trials/executionTime.py:L1-96</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Why just `None` and not `(None, None)`?\r\n- [ ] <a href='#crh-comment-Pull 3c860d34faa77e7cd75b97356946bffb8e220bcc analysers/trials/faban.py 33'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r68462536'>File: analysers/trials/faban.py:L1-82</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Just use the `host` and `operation` couples and add the aggregate one for all the operations.\r\n- [ ] <a href='#crh-comment-Pull 3c860d34faa77e7cd75b97356946bffb8e220bcc analysers/trials/faban.py 78'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r68462706'>File: analysers/trials/faban.py:L1-82</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Use `cassandraKeyspace`\r\n- [ ] <a href='#crh-comment-Pull 3c860d34faa77e7cd75b97356946bffb8e220bcc analysers/trials/numberOfConstructInstances.py 30'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r68462921'>File: analysers/trials/numberOfConstructInstances.py:L1-67</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> First check, then filter\r\n- [ ] <a href='#crh-comment-Pull 3c860d34faa77e7cd75b97356946bffb8e220bcc analysers/trials/throughput.py 32'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r68464014'>File: analysers/trials/throughput.py:L39-69</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> You should just use the `execution time` and the `number of process instance` metrics, not compute then again here\r\n- [ ] <a href='#crh-comment-Pull 3c860d34faa77e7cd75b97356946bffb8e220bcc analysers/trials/throughput.py 58'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r68464047'>File: analysers/trials/throughput.py:L74-98</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Why do you need to select `to_ignore`?\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/commons/commons.py 17'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65807787'>File: analysers/commons/commons.py:L30-44</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Why `0, 101`?\r\n- <a href='https://github.com/Cerfoglg'><img border=0 src='https://avatars.githubusercontent.com/u/8819678?v=3' height=16 width=16'></a> @VincenzoFerme because numpy records percentiles from 0 to 100, so we miss percentile 100 without doing that range\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/commons/commons.py 86'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65807845'>File: analysers/commons/commons.py:L138-177</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> We should have `Alluxio` as well here\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/commons/commons.py 104'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65807871'>File: analysers/commons/commons.py:L138-177</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> You should store both the test statistic and the p-value. http://docs.scipy.org/doc/scipy-0.16.0/reference/generated/scipy.stats.levene.html#scipy.stats.levene\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/commons/commons.py 94'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65807879'>File: analysers/commons/commons.py:L138-177</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> If you have at least two samples, you can perform the test. Check at least that before applying the computation.\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/experiments/constructDuration.py 19'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65813598'>File: analysers/experiments/constructDuration.py:L1-79</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Select the distinct couple of `construct_name` AND `construct_type`, because you already have all the information on the actual existing couple, then you can avoid the next O(N^2) loop and just iterate linearly over the couple.\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/experiments/constructDuration.py 65'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65813797'>File: analysers/experiments/constructDuration.py:L1-79</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> This should come from `Alluxio` as well\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/experiments/cpu.py 52'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65813803'>File: analysers/experiments/cpu.py:L62-122</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> From `host`\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/experiments/cpu.py 93'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65813896'>File: analysers/experiments/cpu.py:L62-122</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> From the right table.\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/experiments/executionTime.py 26'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65813950'>File: analysers/experiments/executionTime.py:L1-72</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Why do you filter twice? Just filter one and cache the result if you need it twice\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/experiments/executionTime.py 45'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65813977'>File: analysers/experiments/executionTime.py:L1-72</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Where is the total execution time independent from the actual `process_definition_id`?\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/experiments/numberOfConstructInstances.py 23'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65813989'>File: analysers/experiments/numberOfConstructInstances.py:L1-75</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> The same comments as per `constructDuration.py`\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/experiments/numberOfProcessInstances.py 1'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65814200'>File: analysers/experiments/numberOfProcessInstances.py:L18-43</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Where is the metric for all the process instance?\r\n- <a href='https://github.com/Cerfoglg'><img border=0 src='https://avatars.githubusercontent.com/u/8819678?v=3' height=16 width=16'></a> @VincenzoFerme In the trial tables we have process_definition_id = all for the stats on all process instances. The loop in this function will work on that too.\r\nThis applies for the other parts you pointed this out too\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/experiments/processDuration.py 1'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65814203'>File: analysers/experiments/processDuration.py:L14-44</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Where is the metric for all the process instance?\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/experiments/processDuration.py 20'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65814204'>File: analysers/experiments/processDuration.py:L14-44</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Remove\r\n- [ ] <a href='#crh-comment-Pull 046b7d881eed1590e5ee2242a455b9f9c0db407d analysers/experiments/throughput.py 1'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/analysers/pull/75#discussion_r65814221'>File: analysers/experiments/throughput.py:L18-43</a></b>\r\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Where is the metric for all the process instance?\r\n\r\n\r\n<a href='https://www.codereviewhub.com/benchflow/analysers/pull/75?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/benchflow/analysers/pull/75?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/benchflow/analysers/pull/75'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\r\n<a href='#crh-end'></a>","created_at":"2016-06-04T17:20:03Z","updated_at":"2016-06-28T13:05:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e28b5930c7a16e739e8e93b3092c6e8811256bfb","assignee":{"login":"Cerfoglg","id":8819678,"avatar_url":"https://avatars.githubusercontent.com/u/8819678?v=3","gravatar_id":"","url":"https://api.github.com/users/Cerfoglg","html_url":"https://github.com/Cerfoglg","followers_url":"https://api.github.com/users/Cerfoglg/followers","following_url":"https://api.github.com/users/Cerfoglg/following{/other_user}","gists_url":"https://api.github.com/users/Cerfoglg/gists{/gist_id}","starred_url":"https://api.github.com/users/Cerfoglg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cerfoglg/subscriptions","organizations_url":"https://api.github.com/users/Cerfoglg/orgs","repos_url":"https://api.github.com/users/Cerfoglg/repos","events_url":"https://api.github.com/users/Cerfoglg/events{/privacy}","received_events_url":"https://api.github.com/users/Cerfoglg/received_events","type":"User","site_admin":false},"assignees":[{"login":"Cerfoglg","id":8819678,"avatar_url":"https://avatars.githubusercontent.com/u/8819678?v=3","gravatar_id":"","url":"https://api.github.com/users/Cerfoglg","html_url":"https://github.com/Cerfoglg","followers_url":"https://api.github.com/users/Cerfoglg/followers","following_url":"https://api.github.com/users/Cerfoglg/following{/other_user}","gists_url":"https://api.github.com/users/Cerfoglg/gists{/gist_id}","starred_url":"https://api.github.com/users/Cerfoglg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cerfoglg/subscriptions","organizations_url":"https://api.github.com/users/Cerfoglg/orgs","repos_url":"https://api.github.com/users/Cerfoglg/repos","events_url":"https://api.github.com/users/Cerfoglg/events{/privacy}","received_events_url":"https://api.github.com/users/Cerfoglg/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/benchflow/analysers/milestones/1","html_url":"https://github.com/benchflow/analysers/milestones/Priorities","labels_url":"https://api.github.com/repos/benchflow/analysers/milestones/1/labels","id":1366592,"number":1,"title":"Priorities","description":"Stuff we must do soon. We never change or rename this milestone.","creator":{"login":"VincenzoFerme","id":7163641,"avatar_url":"https://avatars.githubusercontent.com/u/7163641?v=3","gravatar_id":"","url":"https://api.github.com/users/VincenzoFerme","html_url":"https://github.com/VincenzoFerme","followers_url":"https://api.github.com/users/VincenzoFerme/followers","following_url":"https://api.github.com/users/VincenzoFerme/following{/other_user}","gists_url":"https://api.github.com/users/VincenzoFerme/gists{/gist_id}","starred_url":"https://api.github.com/users/VincenzoFerme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VincenzoFerme/subscriptions","organizations_url":"https://api.github.com/users/VincenzoFerme/orgs","repos_url":"https://api.github.com/users/VincenzoFerme/repos","events_url":"https://api.github.com/users/VincenzoFerme/events{/privacy}","received_events_url":"https://api.github.com/users/VincenzoFerme/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":15,"state":"open","created_at":"2015-10-20T16:13:50Z","updated_at":"2016-06-16T13:57:24Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/benchflow/analysers/pulls/75/commits","review_comments_url":"https://api.github.com/repos/benchflow/analysers/pulls/75/comments","review_comment_url":"https://api.github.com/repos/benchflow/analysers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/benchflow/analysers/issues/75/comments","statuses_url":"https://api.github.com/repos/benchflow/analysers/statuses/b6eefe28d2bc1cc7a0c93608c37f50f5dd7704c8","head":{"label":"Cerfoglg:new-data","ref":"new-data","sha":"b6eefe28d2bc1cc7a0c93608c37f50f5dd7704c8","user":{"login":"Cerfoglg","id":8819678,"avatar_url":"https://avatars.githubusercontent.com/u/8819678?v=3","gravatar_id":"","url":"https://api.github.com/users/Cerfoglg","html_url":"https://github.com/Cerfoglg","followers_url":"https://api.github.com/users/Cerfoglg/followers","following_url":"https://api.github.com/users/Cerfoglg/following{/other_user}","gists_url":"https://api.github.com/users/Cerfoglg/gists{/gist_id}","starred_url":"https://api.github.com/users/Cerfoglg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cerfoglg/subscriptions","organizations_url":"https://api.github.com/users/Cerfoglg/orgs","repos_url":"https://api.github.com/users/Cerfoglg/repos","events_url":"https://api.github.com/users/Cerfoglg/events{/privacy}","received_events_url":"https://api.github.com/users/Cerfoglg/received_events","type":"User","site_admin":false},"repo":{"id":49127867,"name":"analysers","full_name":"Cerfoglg/analysers","owner":{"login":"Cerfoglg","id":8819678,"avatar_url":"https://avatars.githubusercontent.com/u/8819678?v=3","gravatar_id":"","url":"https://api.github.com/users/Cerfoglg","html_url":"https://github.com/Cerfoglg","followers_url":"https://api.github.com/users/Cerfoglg/followers","following_url":"https://api.github.com/users/Cerfoglg/following{/other_user}","gists_url":"https://api.github.com/users/Cerfoglg/gists{/gist_id}","starred_url":"https://api.github.com/users/Cerfoglg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cerfoglg/subscriptions","organizations_url":"https://api.github.com/users/Cerfoglg/orgs","repos_url":"https://api.github.com/users/Cerfoglg/repos","events_url":"https://api.github.com/users/Cerfoglg/events{/privacy}","received_events_url":"https://api.github.com/users/Cerfoglg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Cerfoglg/analysers","description":"Spark scripts utilised to analyse data and compute performance metrics","fork":true,"url":"https://api.github.com/repos/Cerfoglg/analysers","forks_url":"https://api.github.com/repos/Cerfoglg/analysers/forks","keys_url":"https://api.github.com/repos/Cerfoglg/analysers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cerfoglg/analysers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cerfoglg/analysers/teams","hooks_url":"https://api.github.com/repos/Cerfoglg/analysers/hooks","issue_events_url":"https://api.github.com/repos/Cerfoglg/analysers/issues/events{/number}","events_url":"https://api.github.com/repos/Cerfoglg/analysers/events","assignees_url":"https://api.github.com/repos/Cerfoglg/analysers/assignees{/user}","branches_url":"https://api.github.com/repos/Cerfoglg/analysers/branches{/branch}","tags_url":"https://api.github.com/repos/Cerfoglg/analysers/tags","blobs_url":"https://api.github.com/repos/Cerfoglg/analysers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cerfoglg/analysers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cerfoglg/analysers/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cerfoglg/analysers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cerfoglg/analysers/statuses/{sha}","languages_url":"https://api.github.com/repos/Cerfoglg/analysers/languages","stargazers_url":"https://api.github.com/repos/Cerfoglg/analysers/stargazers","contributors_url":"https://api.github.com/repos/Cerfoglg/analysers/contributors","subscribers_url":"https://api.github.com/repos/Cerfoglg/analysers/subscribers","subscription_url":"https://api.github.com/repos/Cerfoglg/analysers/subscription","commits_url":"https://api.github.com/repos/Cerfoglg/analysers/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cerfoglg/analysers/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cerfoglg/analysers/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cerfoglg/analysers/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cerfoglg/analysers/contents/{+path}","compare_url":"https://api.github.com/repos/Cerfoglg/analysers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cerfoglg/analysers/merges","archive_url":"https://api.github.com/repos/Cerfoglg/analysers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cerfoglg/analysers/downloads","issues_url":"https://api.github.com/repos/Cerfoglg/analysers/issues{/number}","pulls_url":"https://api.github.com/repos/Cerfoglg/analysers/pulls{/number}","milestones_url":"https://api.github.com/repos/Cerfoglg/analysers/milestones{/number}","notifications_url":"https://api.github.com/repos/Cerfoglg/analysers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cerfoglg/analysers/labels{/name}","releases_url":"https://api.github.com/repos/Cerfoglg/analysers/releases{/id}","deployments_url":"https://api.github.com/repos/Cerfoglg/analysers/deployments","created_at":"2016-01-06T10:07:54Z","updated_at":"2016-01-11T11:01:56Z","pushed_at":"2016-06-28T13:01:29Z","git_url":"git://github.com/Cerfoglg/analysers.git","ssh_url":"git@github.com:Cerfoglg/analysers.git","clone_url":"https://github.com/Cerfoglg/analysers.git","svn_url":"https://github.com/Cerfoglg/analysers","homepage":null,"size":9433,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"benchflow:dev","ref":"dev","sha":"6385469ffbc7d6d9772d4b585aa15c825268326d","user":{"login":"benchflow","id":11681613,"avatar_url":"https://avatars.githubusercontent.com/u/11681613?v=3","gravatar_id":"","url":"https://api.github.com/users/benchflow","html_url":"https://github.com/benchflow","followers_url":"https://api.github.com/users/benchflow/followers","following_url":"https://api.github.com/users/benchflow/following{/other_user}","gists_url":"https://api.github.com/users/benchflow/gists{/gist_id}","starred_url":"https://api.github.com/users/benchflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benchflow/subscriptions","organizations_url":"https://api.github.com/users/benchflow/orgs","repos_url":"https://api.github.com/users/benchflow/repos","events_url":"https://api.github.com/users/benchflow/events{/privacy}","received_events_url":"https://api.github.com/users/benchflow/received_events","type":"Organization","site_admin":false},"repo":{"id":44318395,"name":"analysers","full_name":"benchflow/analysers","owner":{"login":"benchflow","id":11681613,"avatar_url":"https://avatars.githubusercontent.com/u/11681613?v=3","gravatar_id":"","url":"https://api.github.com/users/benchflow","html_url":"https://github.com/benchflow","followers_url":"https://api.github.com/users/benchflow/followers","following_url":"https://api.github.com/users/benchflow/following{/other_user}","gists_url":"https://api.github.com/users/benchflow/gists{/gist_id}","starred_url":"https://api.github.com/users/benchflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benchflow/subscriptions","organizations_url":"https://api.github.com/users/benchflow/orgs","repos_url":"https://api.github.com/users/benchflow/repos","events_url":"https://api.github.com/users/benchflow/events{/privacy}","received_events_url":"https://api.github.com/users/benchflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/benchflow/analysers","description":"Spark scripts utilised to analyse data and compute performance metrics","fork":false,"url":"https://api.github.com/repos/benchflow/analysers","forks_url":"https://api.github.com/repos/benchflow/analysers/forks","keys_url":"https://api.github.com/repos/benchflow/analysers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benchflow/analysers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benchflow/analysers/teams","hooks_url":"https://api.github.com/repos/benchflow/analysers/hooks","issue_events_url":"https://api.github.com/repos/benchflow/analysers/issues/events{/number}","events_url":"https://api.github.com/repos/benchflow/analysers/events","assignees_url":"https://api.github.com/repos/benchflow/analysers/assignees{/user}","branches_url":"https://api.github.com/repos/benchflow/analysers/branches{/branch}","tags_url":"https://api.github.com/repos/benchflow/analysers/tags","blobs_url":"https://api.github.com/repos/benchflow/analysers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benchflow/analysers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benchflow/analysers/git/refs{/sha}","trees_url":"https://api.github.com/repos/benchflow/analysers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benchflow/analysers/statuses/{sha}","languages_url":"https://api.github.com/repos/benchflow/analysers/languages","stargazers_url":"https://api.github.com/repos/benchflow/analysers/stargazers","contributors_url":"https://api.github.com/repos/benchflow/analysers/contributors","subscribers_url":"https://api.github.com/repos/benchflow/analysers/subscribers","subscription_url":"https://api.github.com/repos/benchflow/analysers/subscription","commits_url":"https://api.github.com/repos/benchflow/analysers/commits{/sha}","git_commits_url":"https://api.github.com/repos/benchflow/analysers/git/commits{/sha}","comments_url":"https://api.github.com/repos/benchflow/analysers/comments{/number}","issue_comment_url":"https://api.github.com/repos/benchflow/analysers/issues/comments{/number}","contents_url":"https://api.github.com/repos/benchflow/analysers/contents/{+path}","compare_url":"https://api.github.com/repos/benchflow/analysers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benchflow/analysers/merges","archive_url":"https://api.github.com/repos/benchflow/analysers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benchflow/analysers/downloads","issues_url":"https://api.github.com/repos/benchflow/analysers/issues{/number}","pulls_url":"https://api.github.com/repos/benchflow/analysers/pulls{/number}","milestones_url":"https://api.github.com/repos/benchflow/analysers/milestones{/number}","notifications_url":"https://api.github.com/repos/benchflow/analysers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benchflow/analysers/labels{/name}","releases_url":"https://api.github.com/repos/benchflow/analysers/releases{/id}","deployments_url":"https://api.github.com/repos/benchflow/analysers/deployments","created_at":"2015-10-15T13:12:56Z","updated_at":"2016-01-11T12:49:19Z","pushed_at":"2016-06-28T13:01:29Z","git_url":"git://github.com/benchflow/analysers.git","ssh_url":"git@github.com:benchflow/analysers.git","clone_url":"https://github.com/benchflow/analysers.git","svn_url":"https://github.com/benchflow/analysers","homepage":null,"size":9407,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":28,"forks":1,"open_issues":28,"watchers":0,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/benchflow/analysers/pulls/75"},"html":{"href":"https://github.com/benchflow/analysers/pull/75"},"issue":{"href":"https://api.github.com/repos/benchflow/analysers/issues/75"},"comments":{"href":"https://api.github.com/repos/benchflow/analysers/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/benchflow/analysers/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/benchflow/analysers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/benchflow/analysers/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/benchflow/analysers/statuses/b6eefe28d2bc1cc7a0c93608c37f50f5dd7704c8"}}}}
{"actor":{"display_login":"Cerfoglg"}}