{"action":"created","comment":{"url":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/comments/52386934","id":52386934,"diff_hunk":"@@ -102,12 +102,20 @@ protected void loadConfig( final ConfigProperties config ) {\n     }\n \n     protected synchronized Keycloak getKeyCloakInstance() {\n-        if (this.keycloak == null) {\n+        if ( null == this.keycloak ) {","path":"uberfire-security/uberfire-security-management/uberfire-security-management-keycloak/src/main/java/org/uberfire/ext/security/management/keycloak/BaseKeyCloakManager.java","position":5,"original_position":5,"commit_id":"679e1b299dc5a67134af0ef2f1e6cee79e95f1ba","original_commit_id":"679e1b299dc5a67134af0ef2f1e6cee79e95f1ba","user":{"login":"romartin","id":4602417,"avatar_url":"https://avatars.githubusercontent.com/u/4602417?v=3","gravatar_id":"","url":"https://api.github.com/users/romartin","html_url":"https://github.com/romartin","followers_url":"https://api.github.com/users/romartin/followers","following_url":"https://api.github.com/users/romartin/following{/other_user}","gists_url":"https://api.github.com/users/romartin/gists{/gist_id}","starred_url":"https://api.github.com/users/romartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romartin/subscriptions","organizations_url":"https://api.github.com/users/romartin/orgs","repos_url":"https://api.github.com/users/romartin/repos","events_url":"https://api.github.com/users/romartin/events{/privacy}","received_events_url":"https://api.github.com/users/romartin/received_events","type":"User","site_admin":false},"body":"will remove the syncronization here yes, does not makes sense. About the notation of the if... just notation, no matter for me to revert it :)","created_at":"2016-02-09T22:43:32Z","updated_at":"2016-02-09T22:43:32Z","html_url":"https://github.com/uberfire/uberfire-extensions/pull/199#discussion_r52386934","pull_request_url":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/199","_links":{"self":{"href":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/comments/52386934"},"html":{"href":"https://github.com/uberfire/uberfire-extensions/pull/199#discussion_r52386934"},"pull_request":{"href":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/199"}}},"pull_request":{"url":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/199","id":58813209,"html_url":"https://github.com/uberfire/uberfire-extensions/pull/199","diff_url":"https://github.com/uberfire/uberfire-extensions/pull/199.diff","patch_url":"https://github.com/uberfire/uberfire-extensions/pull/199.patch","issue_url":"https://api.github.com/repos/uberfire/uberfire-extensions/issues/199","number":199,"state":"open","locked":false,"title":"Keycloak 1.8 integration","user":{"login":"romartin","id":4602417,"avatar_url":"https://avatars.githubusercontent.com/u/4602417?v=3","gravatar_id":"","url":"https://api.github.com/users/romartin","html_url":"https://github.com/romartin","followers_url":"https://api.github.com/users/romartin/followers","following_url":"https://api.github.com/users/romartin/following{/other_user}","gists_url":"https://api.github.com/users/romartin/gists{/gist_id}","starred_url":"https://api.github.com/users/romartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romartin/subscriptions","organizations_url":"https://api.github.com/users/romartin/orgs","repos_url":"https://api.github.com/users/romartin/repos","events_url":"https://api.github.com/users/romartin/events{/privacy}","received_events_url":"https://api.github.com/users/romartin/received_events","type":"User","site_admin":false},"body":"This PR add support for latest Keylocak 1.8.0.Final. This is the PR for 0.8.x branch, as it hurries for the kie 6.3.x build and qe testing.  I will send the PR for master branch in a while.\r\nThanks!","created_at":"2016-02-09T21:42:46Z","updated_at":"2016-02-09T22:43:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14c3bb05072fa6b452f765e38e3b21700e0d60c0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/199/commits","review_comments_url":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/199/comments","review_comment_url":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uberfire/uberfire-extensions/issues/199/comments","statuses_url":"https://api.github.com/repos/uberfire/uberfire-extensions/statuses/679e1b299dc5a67134af0ef2f1e6cee79e95f1ba","head":{"label":"romartin:keycloak-v18-08x","ref":"keycloak-v18-08x","sha":"679e1b299dc5a67134af0ef2f1e6cee79e95f1ba","user":{"login":"romartin","id":4602417,"avatar_url":"https://avatars.githubusercontent.com/u/4602417?v=3","gravatar_id":"","url":"https://api.github.com/users/romartin","html_url":"https://github.com/romartin","followers_url":"https://api.github.com/users/romartin/followers","following_url":"https://api.github.com/users/romartin/following{/other_user}","gists_url":"https://api.github.com/users/romartin/gists{/gist_id}","starred_url":"https://api.github.com/users/romartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romartin/subscriptions","organizations_url":"https://api.github.com/users/romartin/orgs","repos_url":"https://api.github.com/users/romartin/repos","events_url":"https://api.github.com/users/romartin/events{/privacy}","received_events_url":"https://api.github.com/users/romartin/received_events","type":"User","site_admin":false},"repo":{"id":44030280,"name":"uberfire-extensions","full_name":"romartin/uberfire-extensions","owner":{"login":"romartin","id":4602417,"avatar_url":"https://avatars.githubusercontent.com/u/4602417?v=3","gravatar_id":"","url":"https://api.github.com/users/romartin","html_url":"https://github.com/romartin","followers_url":"https://api.github.com/users/romartin/followers","following_url":"https://api.github.com/users/romartin/following{/other_user}","gists_url":"https://api.github.com/users/romartin/gists{/gist_id}","starred_url":"https://api.github.com/users/romartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romartin/subscriptions","organizations_url":"https://api.github.com/users/romartin/orgs","repos_url":"https://api.github.com/users/romartin/repos","events_url":"https://api.github.com/users/romartin/events{/privacy}","received_events_url":"https://api.github.com/users/romartin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/romartin/uberfire-extensions","description":"Generic extensions to the Uberfire framework","fork":true,"url":"https://api.github.com/repos/romartin/uberfire-extensions","forks_url":"https://api.github.com/repos/romartin/uberfire-extensions/forks","keys_url":"https://api.github.com/repos/romartin/uberfire-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romartin/uberfire-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romartin/uberfire-extensions/teams","hooks_url":"https://api.github.com/repos/romartin/uberfire-extensions/hooks","issue_events_url":"https://api.github.com/repos/romartin/uberfire-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/romartin/uberfire-extensions/events","assignees_url":"https://api.github.com/repos/romartin/uberfire-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/romartin/uberfire-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/romartin/uberfire-extensions/tags","blobs_url":"https://api.github.com/repos/romartin/uberfire-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romartin/uberfire-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romartin/uberfire-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/romartin/uberfire-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romartin/uberfire-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/romartin/uberfire-extensions/languages","stargazers_url":"https://api.github.com/repos/romartin/uberfire-extensions/stargazers","contributors_url":"https://api.github.com/repos/romartin/uberfire-extensions/contributors","subscribers_url":"https://api.github.com/repos/romartin/uberfire-extensions/subscribers","subscription_url":"https://api.github.com/repos/romartin/uberfire-extensions/subscription","commits_url":"https://api.github.com/repos/romartin/uberfire-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/romartin/uberfire-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/romartin/uberfire-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/romartin/uberfire-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/romartin/uberfire-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/romartin/uberfire-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romartin/uberfire-extensions/merges","archive_url":"https://api.github.com/repos/romartin/uberfire-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romartin/uberfire-extensions/downloads","issues_url":"https://api.github.com/repos/romartin/uberfire-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/romartin/uberfire-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/romartin/uberfire-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/romartin/uberfire-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romartin/uberfire-extensions/labels{/name}","releases_url":"https://api.github.com/repos/romartin/uberfire-extensions/releases{/id}","deployments_url":"https://api.github.com/repos/romartin/uberfire-extensions/deployments","created_at":"2015-10-10T22:11:01Z","updated_at":"2016-01-14T23:49:31Z","pushed_at":"2016-02-09T21:39:22Z","git_url":"git://github.com/romartin/uberfire-extensions.git","ssh_url":"git@github.com:romartin/uberfire-extensions.git","clone_url":"https://github.com/romartin/uberfire-extensions.git","svn_url":"https://github.com/romartin/uberfire-extensions","homepage":null,"size":6607,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"uberfire:0.8.x","ref":"0.8.x","sha":"f604c142719621a482b5297f302c3fda313f09c4","user":{"login":"uberfire","id":5167699,"avatar_url":"https://avatars.githubusercontent.com/u/5167699?v=3","gravatar_id":"","url":"https://api.github.com/users/uberfire","html_url":"https://github.com/uberfire","followers_url":"https://api.github.com/users/uberfire/followers","following_url":"https://api.github.com/users/uberfire/following{/other_user}","gists_url":"https://api.github.com/users/uberfire/gists{/gist_id}","starred_url":"https://api.github.com/users/uberfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uberfire/subscriptions","organizations_url":"https://api.github.com/users/uberfire/orgs","repos_url":"https://api.github.com/users/uberfire/repos","events_url":"https://api.github.com/users/uberfire/events{/privacy}","received_events_url":"https://api.github.com/users/uberfire/received_events","type":"Organization","site_admin":false},"repo":{"id":26430285,"name":"uberfire-extensions","full_name":"uberfire/uberfire-extensions","owner":{"login":"uberfire","id":5167699,"avatar_url":"https://avatars.githubusercontent.com/u/5167699?v=3","gravatar_id":"","url":"https://api.github.com/users/uberfire","html_url":"https://github.com/uberfire","followers_url":"https://api.github.com/users/uberfire/followers","following_url":"https://api.github.com/users/uberfire/following{/other_user}","gists_url":"https://api.github.com/users/uberfire/gists{/gist_id}","starred_url":"https://api.github.com/users/uberfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uberfire/subscriptions","organizations_url":"https://api.github.com/users/uberfire/orgs","repos_url":"https://api.github.com/users/uberfire/repos","events_url":"https://api.github.com/users/uberfire/events{/privacy}","received_events_url":"https://api.github.com/users/uberfire/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uberfire/uberfire-extensions","description":"Generic extensions to the Uberfire framework","fork":false,"url":"https://api.github.com/repos/uberfire/uberfire-extensions","forks_url":"https://api.github.com/repos/uberfire/uberfire-extensions/forks","keys_url":"https://api.github.com/repos/uberfire/uberfire-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uberfire/uberfire-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uberfire/uberfire-extensions/teams","hooks_url":"https://api.github.com/repos/uberfire/uberfire-extensions/hooks","issue_events_url":"https://api.github.com/repos/uberfire/uberfire-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/uberfire/uberfire-extensions/events","assignees_url":"https://api.github.com/repos/uberfire/uberfire-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/uberfire/uberfire-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/uberfire/uberfire-extensions/tags","blobs_url":"https://api.github.com/repos/uberfire/uberfire-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uberfire/uberfire-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uberfire/uberfire-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/uberfire/uberfire-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uberfire/uberfire-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/uberfire/uberfire-extensions/languages","stargazers_url":"https://api.github.com/repos/uberfire/uberfire-extensions/stargazers","contributors_url":"https://api.github.com/repos/uberfire/uberfire-extensions/contributors","subscribers_url":"https://api.github.com/repos/uberfire/uberfire-extensions/subscribers","subscription_url":"https://api.github.com/repos/uberfire/uberfire-extensions/subscription","commits_url":"https://api.github.com/repos/uberfire/uberfire-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/uberfire/uberfire-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/uberfire/uberfire-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/uberfire/uberfire-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/uberfire/uberfire-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/uberfire/uberfire-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uberfire/uberfire-extensions/merges","archive_url":"https://api.github.com/repos/uberfire/uberfire-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uberfire/uberfire-extensions/downloads","issues_url":"https://api.github.com/repos/uberfire/uberfire-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/uberfire/uberfire-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/uberfire/uberfire-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uberfire/uberfire-extensions/labels{/name}","releases_url":"https://api.github.com/repos/uberfire/uberfire-extensions/releases{/id}","deployments_url":"https://api.github.com/repos/uberfire/uberfire-extensions/deployments","created_at":"2014-11-10T09:42:01Z","updated_at":"2016-01-11T12:55:56Z","pushed_at":"2016-02-09T21:42:48Z","git_url":"git://github.com/uberfire/uberfire-extensions.git","ssh_url":"git@github.com:uberfire/uberfire-extensions.git","clone_url":"https://github.com/uberfire/uberfire-extensions.git","svn_url":"https://github.com/uberfire/uberfire-extensions","homepage":null,"size":6182,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":1,"forks":29,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/199"},"html":{"href":"https://github.com/uberfire/uberfire-extensions/pull/199"},"issue":{"href":"https://api.github.com/repos/uberfire/uberfire-extensions/issues/199"},"comments":{"href":"https://api.github.com/repos/uberfire/uberfire-extensions/issues/199/comments"},"review_comments":{"href":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/199/comments"},"review_comment":{"href":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uberfire/uberfire-extensions/pulls/199/commits"},"statuses":{"href":"https://api.github.com/repos/uberfire/uberfire-extensions/statuses/679e1b299dc5a67134af0ef2f1e6cee79e95f1ba"}}}}