{"action":"created","issue":{"url":"https://api.github.com/repos/Alecrim/AlecrimCoreData/issues/143","repository_url":"https://api.github.com/repos/Alecrim/AlecrimCoreData","labels_url":"https://api.github.com/repos/Alecrim/AlecrimCoreData/issues/143/labels{/name}","comments_url":"https://api.github.com/repos/Alecrim/AlecrimCoreData/issues/143/comments","events_url":"https://api.github.com/repos/Alecrim/AlecrimCoreData/issues/143/events","html_url":"https://github.com/Alecrim/AlecrimCoreData/issues/143","id":160562570,"number":143,"title":"Suggestion: Filter on FetchRequestController should not perform fetch","user":{"login":"AnthonyMDev","id":6243461,"avatar_url":"https://avatars.githubusercontent.com/u/6243461?v=3","gravatar_id":"","url":"https://api.github.com/users/AnthonyMDev","html_url":"https://github.com/AnthonyMDev","followers_url":"https://api.github.com/users/AnthonyMDev/followers","following_url":"https://api.github.com/users/AnthonyMDev/following{/other_user}","gists_url":"https://api.github.com/users/AnthonyMDev/gists{/gist_id}","starred_url":"https://api.github.com/users/AnthonyMDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnthonyMDev/subscriptions","organizations_url":"https://api.github.com/users/AnthonyMDev/orgs","repos_url":"https://api.github.com/users/AnthonyMDev/repos","events_url":"https://api.github.com/users/AnthonyMDev/events{/privacy}","received_events_url":"https://api.github.com/users/AnthonyMDev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-16T02:06:31Z","updated_at":"2016-06-16T04:31:13Z","closed_at":null,"body":"I'd like to suggest that the `filter(predicateClosure:)` function on `FetchRequestController` should not automatically perform the fetch again. \r\n\r\nI have two reasons for this:\r\n\r\n1. Initializing the `FetchRequestController` with a fetch request does not perform the fetch. The user would assume that adding a filter would have the same effect. The user already knows they must call `performFetch()` in one case. We should keep this consistent.\r\n\r\n2. I have a use case in which I would like to add multiple new filters to my `FetchRequestController` simultaneously. Currently, it is performing the fetch multiple times unnecessarily. To get around that, I'm having to create my `NSPredicate` manually and then use the `refreshWithPredicate(_: keepOriginalPredicate:)` method.\r\n\r\nThoughts?"},"comment":{"url":"https://api.github.com/repos/Alecrim/AlecrimCoreData/issues/comments/226385780","html_url":"https://github.com/Alecrim/AlecrimCoreData/issues/143#issuecomment-226385780","issue_url":"https://api.github.com/repos/Alecrim/AlecrimCoreData/issues/143","id":226385780,"user":{"login":"vmartinelli","id":1707194,"avatar_url":"https://avatars.githubusercontent.com/u/1707194?v=3","gravatar_id":"","url":"https://api.github.com/users/vmartinelli","html_url":"https://github.com/vmartinelli","followers_url":"https://api.github.com/users/vmartinelli/followers","following_url":"https://api.github.com/users/vmartinelli/following{/other_user}","gists_url":"https://api.github.com/users/vmartinelli/gists{/gist_id}","starred_url":"https://api.github.com/users/vmartinelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmartinelli/subscriptions","organizations_url":"https://api.github.com/users/vmartinelli/orgs","repos_url":"https://api.github.com/users/vmartinelli/repos","events_url":"https://api.github.com/users/vmartinelli/events{/privacy}","received_events_url":"https://api.github.com/users/vmartinelli/received_events","type":"User","site_admin":false},"created_at":"2016-06-16T04:31:13Z","updated_at":"2016-06-16T04:31:13Z","body":"About all the filter related issues, I think it will be better to always have an option to performFetch or not, or remove the “auto fetching” and let the user decide where she/he wants to perform the fetch. Also it would be nice to think about the `FetchRequestController` will fit to the new Core Data features from now."}}
{"actor":{"display_login":"vmartinelli"}}