{"action":"created","comment":{"url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/pulls/comments/77461475","id":77461475,"diff_hunk":"@@ -40,6 +38,15 @@ public void Dispose()\n                 // Leave as it was before testing...\n             }\n         }\n+        \n+\t    static IList<DynamicTableEntity> TableQueryTakeDynamic(CloudTable table, int takeCount)\n+\t    {\n+            var queryToken = new TableContinuationToken();\n+            var executeTask = table.ExecuteQuerySegmentedAsync(new TableQuery().Take(takeCount), queryToken);\n+\t        return executeTask.Result.Results;\n+\t    }\n+\n+\t    const int WaitTimeoutMilliseconds = 2000;\n \n         [Fact]\n \t\tpublic void WhenALoggerWritesToTheSinkItIsRetrievableFromTheTableWithProperties()","path":"test/Serilog.Sinks.AzureTableStorageWithProperties.Tests/AzureTableStorageWithPropertiesSinkTests.cs","position":24,"original_position":24,"commit_id":"7cb62aca0f6cfc02f0437a9d119068a0dcb3ad6a","original_commit_id":"7cb62aca0f6cfc02f0437a9d119068a0dcb3ad6a","user":{"login":"robdmoore","id":573791,"avatar_url":"https://avatars.githubusercontent.com/u/573791?v=3","gravatar_id":"","url":"https://api.github.com/users/robdmoore","html_url":"https://github.com/robdmoore","followers_url":"https://api.github.com/users/robdmoore/followers","following_url":"https://api.github.com/users/robdmoore/following{/other_user}","gists_url":"https://api.github.com/users/robdmoore/gists{/gist_id}","starred_url":"https://api.github.com/users/robdmoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robdmoore/subscriptions","organizations_url":"https://api.github.com/users/robdmoore/orgs","repos_url":"https://api.github.com/users/robdmoore/repos","events_url":"https://api.github.com/users/robdmoore/events{/privacy}","received_events_url":"https://api.github.com/users/robdmoore/received_events","type":"User","site_admin":false},"body":"We should be able to make the tests async too so we can use await","created_at":"2016-09-05T00:26:42Z","updated_at":"2016-09-05T00:26:42Z","html_url":"https://github.com/serilog/serilog-sinks-azuretablestorage/pull/17#discussion_r77461475","pull_request_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/pulls/comments/77461475"},"html":{"href":"https://github.com/serilog/serilog-sinks-azuretablestorage/pull/17#discussion_r77461475"},"pull_request":{"href":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/pulls/17","id":83877962,"html_url":"https://github.com/serilog/serilog-sinks-azuretablestorage/pull/17","diff_url":"https://github.com/serilog/serilog-sinks-azuretablestorage/pull/17.diff","patch_url":"https://github.com/serilog/serilog-sinks-azuretablestorage/pull/17.patch","issue_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/issues/17","number":17,"state":"open","locked":false,"title":"Support `netstandard1.3` using WindowsAzure.Storage 7.2.0","user":{"login":"adamchester","id":570470,"avatar_url":"https://avatars.githubusercontent.com/u/570470?v=3","gravatar_id":"","url":"https://api.github.com/users/adamchester","html_url":"https://github.com/adamchester","followers_url":"https://api.github.com/users/adamchester/followers","following_url":"https://api.github.com/users/adamchester/following{/other_user}","gists_url":"https://api.github.com/users/adamchester/gists{/gist_id}","starred_url":"https://api.github.com/users/adamchester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamchester/subscriptions","organizations_url":"https://api.github.com/users/adamchester/orgs","repos_url":"https://api.github.com/users/adamchester/repos","events_url":"https://api.github.com/users/adamchester/events{/privacy}","received_events_url":"https://api.github.com/users/adamchester/received_events","type":"User","site_admin":false},"body":"We have to use the async APIs now, because that's all that is available in the `WindowsAzure.Storage` 7.2.0.\r\n\r\nThe easiest thing to do here is to immediately await the tasks, keeping compatibility with the synchronous nature of previous versions of the sink.\r\n\r\nP.s. I still need to cleanup the tabbing and spacing and add an editorconfig :cry: ","created_at":"2016-09-02T23:46:03Z","updated_at":"2016-09-05T00:26:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b507c158ed7cba57e073b85ab64146abd3746c12","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/pulls/17/commits","review_comments_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/pulls/17/comments","review_comment_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/issues/17/comments","statuses_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/statuses/7cb62aca0f6cfc02f0437a9d119068a0dcb3ad6a","head":{"label":"adamchester:netstandard-support","ref":"netstandard-support","sha":"7cb62aca0f6cfc02f0437a9d119068a0dcb3ad6a","user":{"login":"adamchester","id":570470,"avatar_url":"https://avatars.githubusercontent.com/u/570470?v=3","gravatar_id":"","url":"https://api.github.com/users/adamchester","html_url":"https://github.com/adamchester","followers_url":"https://api.github.com/users/adamchester/followers","following_url":"https://api.github.com/users/adamchester/following{/other_user}","gists_url":"https://api.github.com/users/adamchester/gists{/gist_id}","starred_url":"https://api.github.com/users/adamchester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamchester/subscriptions","organizations_url":"https://api.github.com/users/adamchester/orgs","repos_url":"https://api.github.com/users/adamchester/repos","events_url":"https://api.github.com/users/adamchester/events{/privacy}","received_events_url":"https://api.github.com/users/adamchester/received_events","type":"User","site_admin":false},"repo":{"id":59966455,"name":"serilog-sinks-azuretablestorage","full_name":"adamchester/serilog-sinks-azuretablestorage","owner":{"login":"adamchester","id":570470,"avatar_url":"https://avatars.githubusercontent.com/u/570470?v=3","gravatar_id":"","url":"https://api.github.com/users/adamchester","html_url":"https://github.com/adamchester","followers_url":"https://api.github.com/users/adamchester/followers","following_url":"https://api.github.com/users/adamchester/following{/other_user}","gists_url":"https://api.github.com/users/adamchester/gists{/gist_id}","starred_url":"https://api.github.com/users/adamchester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamchester/subscriptions","organizations_url":"https://api.github.com/users/adamchester/orgs","repos_url":"https://api.github.com/users/adamchester/repos","events_url":"https://api.github.com/users/adamchester/events{/privacy}","received_events_url":"https://api.github.com/users/adamchester/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adamchester/serilog-sinks-azuretablestorage","description":"A Serilog sink that writes events to Azure Table Storage","fork":true,"url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage","forks_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/forks","keys_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/teams","hooks_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/hooks","issue_events_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/issues/events{/number}","events_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/events","assignees_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/assignees{/user}","branches_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/branches{/branch}","tags_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/tags","blobs_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/statuses/{sha}","languages_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/languages","stargazers_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/stargazers","contributors_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/contributors","subscribers_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/subscribers","subscription_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/subscription","commits_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/contents/{+path}","compare_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/merges","archive_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/downloads","issues_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/issues{/number}","pulls_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/pulls{/number}","milestones_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/milestones{/number}","notifications_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/labels{/name}","releases_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/releases{/id}","deployments_url":"https://api.github.com/repos/adamchester/serilog-sinks-azuretablestorage/deployments","created_at":"2016-05-29T22:24:17Z","updated_at":"2016-05-29T22:24:18Z","pushed_at":"2016-09-02T23:43:12Z","git_url":"git://github.com/adamchester/serilog-sinks-azuretablestorage.git","ssh_url":"git@github.com:adamchester/serilog-sinks-azuretablestorage.git","clone_url":"https://github.com/adamchester/serilog-sinks-azuretablestorage.git","svn_url":"https://github.com/adamchester/serilog-sinks-azuretablestorage","homepage":null,"size":55,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"serilog:dev","ref":"dev","sha":"164f20f977099a1f59e90a0ce6fb82654dc07120","user":{"login":"serilog","id":5691010,"avatar_url":"https://avatars.githubusercontent.com/u/5691010?v=3","gravatar_id":"","url":"https://api.github.com/users/serilog","html_url":"https://github.com/serilog","followers_url":"https://api.github.com/users/serilog/followers","following_url":"https://api.github.com/users/serilog/following{/other_user}","gists_url":"https://api.github.com/users/serilog/gists{/gist_id}","starred_url":"https://api.github.com/users/serilog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serilog/subscriptions","organizations_url":"https://api.github.com/users/serilog/orgs","repos_url":"https://api.github.com/users/serilog/repos","events_url":"https://api.github.com/users/serilog/events{/privacy}","received_events_url":"https://api.github.com/users/serilog/received_events","type":"Organization","site_admin":false},"repo":{"id":31184480,"name":"serilog-sinks-azuretablestorage","full_name":"serilog/serilog-sinks-azuretablestorage","owner":{"login":"serilog","id":5691010,"avatar_url":"https://avatars.githubusercontent.com/u/5691010?v=3","gravatar_id":"","url":"https://api.github.com/users/serilog","html_url":"https://github.com/serilog","followers_url":"https://api.github.com/users/serilog/followers","following_url":"https://api.github.com/users/serilog/following{/other_user}","gists_url":"https://api.github.com/users/serilog/gists{/gist_id}","starred_url":"https://api.github.com/users/serilog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serilog/subscriptions","organizations_url":"https://api.github.com/users/serilog/orgs","repos_url":"https://api.github.com/users/serilog/repos","events_url":"https://api.github.com/users/serilog/events{/privacy}","received_events_url":"https://api.github.com/users/serilog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serilog/serilog-sinks-azuretablestorage","description":"A Serilog sink that writes events to Azure Table Storage","fork":false,"url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage","forks_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/forks","keys_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/teams","hooks_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/hooks","issue_events_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/issues/events{/number}","events_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/events","assignees_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/assignees{/user}","branches_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/branches{/branch}","tags_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/tags","blobs_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/git/refs{/sha}","trees_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/statuses/{sha}","languages_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/languages","stargazers_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/stargazers","contributors_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/contributors","subscribers_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/subscribers","subscription_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/subscription","commits_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/commits{/sha}","git_commits_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/git/commits{/sha}","comments_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/comments{/number}","issue_comment_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/issues/comments{/number}","contents_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/contents/{+path}","compare_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/merges","archive_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/downloads","issues_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/issues{/number}","pulls_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/pulls{/number}","milestones_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/milestones{/number}","notifications_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/labels{/name}","releases_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/releases{/id}","deployments_url":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/deployments","created_at":"2015-02-22T22:45:23Z","updated_at":"2016-04-19T19:21:21Z","pushed_at":"2016-09-02T23:46:03Z","git_url":"git://github.com/serilog/serilog-sinks-azuretablestorage.git","ssh_url":"git@github.com:serilog/serilog-sinks-azuretablestorage.git","clone_url":"https://github.com/serilog/serilog-sinks-azuretablestorage.git","svn_url":"https://github.com/serilog/serilog-sinks-azuretablestorage","homepage":null,"size":61,"stargazers_count":4,"watchers_count":4,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":10,"forks":12,"open_issues":10,"watchers":4,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/pulls/17"},"html":{"href":"https://github.com/serilog/serilog-sinks-azuretablestorage/pull/17"},"issue":{"href":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/issues/17"},"comments":{"href":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/serilog/serilog-sinks-azuretablestorage/statuses/7cb62aca0f6cfc02f0437a9d119068a0dcb3ad6a"}}}}
{"actor":{"display_login":"robdmoore"}}