{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/86577873","pull_request_review_id":7231186,"id":86577873,"diff_hunk":"@@ -87,38 +89,43 @@ func ScaleUp(unschedulablePods []*kube_api.Pod, nodes []*kube_api.Node, cloudPro\n \t\tfor _, pod := range unschedulablePods {\n \t\t\terr = predicateChecker.CheckPredicates(pod, nodeInfo)\n \t\t\tif err == nil {\n-\t\t\t\tgroupHelpsSomePods = true\n-\t\t\t\toption.estimator.Add(pod)\n+\t\t\t\toption.pods = append(option.pods, pod)\n \t\t\t} else {\n \t\t\t\tglog.V(2).Infof(\"Scale-up predicate failed: %v\", err)\n \t\t\t\tpodsRemainUnshedulable[pod] = struct{}{}\n \t\t\t}\n \t\t}\n-\t\tif groupHelpsSomePods {\n+\t\tif len(option.pods) > 0 {\n+\t\t\tif estimatorName == BinpackingEstimatorName {\n+\t\t\t\taggresiveEstimator := estimator.NewBinpackingNodeEstimator(predicateChecker)\n+\t\t\t\toption.nodeCount = aggresiveEstimator.Estimate(option.pods, nodeInfo)\n+\t\t\t} else if estimatorName == BasicEstimatorName {\n+\t\t\t\tsafeEstimator := estimator.NewBasicNodeEstimator()","path":"cluster-autoscaler/scale_up.go","position":49,"original_position":49,"commit_id":"3744923bd40ac8fed72a3d9832860dad0ad494a1","original_commit_id":"3744923bd40ac8fed72a3d9832860dad0ad494a1","user":{"login":"mwielgus","id":11994812,"avatar_url":"https://avatars.githubusercontent.com/u/11994812?v=3","gravatar_id":"","url":"https://api.github.com/users/mwielgus","html_url":"https://github.com/mwielgus","followers_url":"https://api.github.com/users/mwielgus/followers","following_url":"https://api.github.com/users/mwielgus/following{/other_user}","gists_url":"https://api.github.com/users/mwielgus/gists{/gist_id}","starred_url":"https://api.github.com/users/mwielgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwielgus/subscriptions","organizations_url":"https://api.github.com/users/mwielgus/orgs","repos_url":"https://api.github.com/users/mwielgus/repos","events_url":"https://api.github.com/users/mwielgus/events{/privacy}","received_events_url":"https://api.github.com/users/mwielgus/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2016-11-04T16:05:53Z","updated_at":"2016-11-04T16:05:59Z","html_url":"https://github.com/kubernetes/contrib/pull/1850#discussion_r86577873","pull_request_url":"https://api.github.com/repos/kubernetes/contrib/pulls/1850","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/86577873"},"html":{"href":"https://github.com/kubernetes/contrib/pull/1850#discussion_r86577873"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/1850"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/1850","id":88462141,"html_url":"https://github.com/kubernetes/contrib/pull/1850","diff_url":"https://github.com/kubernetes/contrib/pull/1850.diff","patch_url":"https://github.com/kubernetes/contrib/pull/1850.patch","issue_url":"https://api.github.com/repos/kubernetes/contrib/issues/1850","number":1850,"state":"open","locked":false,"title":"Cluster-autoscaler: Add a flag to enable more aggressive new node count nt estimation via binpacking estimator","user":{"login":"mwielgus","id":11994812,"avatar_url":"https://avatars.githubusercontent.com/u/11994812?v=3","gravatar_id":"","url":"https://api.github.com/users/mwielgus","html_url":"https://github.com/mwielgus","followers_url":"https://api.github.com/users/mwielgus/followers","following_url":"https://api.github.com/users/mwielgus/following{/other_user}","gists_url":"https://api.github.com/users/mwielgus/gists{/gist_id}","starred_url":"https://api.github.com/users/mwielgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwielgus/subscriptions","organizations_url":"https://api.github.com/users/mwielgus/orgs","repos_url":"https://api.github.com/users/mwielgus/repos","events_url":"https://api.github.com/users/mwielgus/events{/privacy}","received_events_url":"https://api.github.com/users/mwielgus/received_events","type":"User","site_admin":false},"body":"Binpacking estimator was added here: #1741\n\ncc: @piosz @fgrzadkowski\n\n<!-- Reviewable:start -->\n---\n\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/contrib/1850)\n\n<!-- Reviewable:end -->\n","created_at":"2016-10-07T15:46:29Z","updated_at":"2016-11-04T16:05:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26d01ee377edc0274b79f4d9fe11a7ee34633c78","assignee":{"login":"fgrzadkowski","id":10820726,"avatar_url":"https://avatars.githubusercontent.com/u/10820726?v=3","gravatar_id":"","url":"https://api.github.com/users/fgrzadkowski","html_url":"https://github.com/fgrzadkowski","followers_url":"https://api.github.com/users/fgrzadkowski/followers","following_url":"https://api.github.com/users/fgrzadkowski/following{/other_user}","gists_url":"https://api.github.com/users/fgrzadkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/fgrzadkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgrzadkowski/subscriptions","organizations_url":"https://api.github.com/users/fgrzadkowski/orgs","repos_url":"https://api.github.com/users/fgrzadkowski/repos","events_url":"https://api.github.com/users/fgrzadkowski/events{/privacy}","received_events_url":"https://api.github.com/users/fgrzadkowski/received_events","type":"User","site_admin":false},"assignees":[{"login":"fgrzadkowski","id":10820726,"avatar_url":"https://avatars.githubusercontent.com/u/10820726?v=3","gravatar_id":"","url":"https://api.github.com/users/fgrzadkowski","html_url":"https://github.com/fgrzadkowski","followers_url":"https://api.github.com/users/fgrzadkowski/followers","following_url":"https://api.github.com/users/fgrzadkowski/following{/other_user}","gists_url":"https://api.github.com/users/fgrzadkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/fgrzadkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgrzadkowski/subscriptions","organizations_url":"https://api.github.com/users/fgrzadkowski/orgs","repos_url":"https://api.github.com/users/fgrzadkowski/repos","events_url":"https://api.github.com/users/fgrzadkowski/events{/privacy}","received_events_url":"https://api.github.com/users/fgrzadkowski/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/contrib/pulls/1850/commits","review_comments_url":"https://api.github.com/repos/kubernetes/contrib/pulls/1850/comments","review_comment_url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/contrib/issues/1850/comments","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/3744923bd40ac8fed72a3d9832860dad0ad494a1","head":{"label":"mwielgus:enable-aggressive-estimation-flag","ref":"enable-aggressive-estimation-flag","sha":"3744923bd40ac8fed72a3d9832860dad0ad494a1","user":{"login":"mwielgus","id":11994812,"avatar_url":"https://avatars.githubusercontent.com/u/11994812?v=3","gravatar_id":"","url":"https://api.github.com/users/mwielgus","html_url":"https://github.com/mwielgus","followers_url":"https://api.github.com/users/mwielgus/followers","following_url":"https://api.github.com/users/mwielgus/following{/other_user}","gists_url":"https://api.github.com/users/mwielgus/gists{/gist_id}","starred_url":"https://api.github.com/users/mwielgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwielgus/subscriptions","organizations_url":"https://api.github.com/users/mwielgus/orgs","repos_url":"https://api.github.com/users/mwielgus/repos","events_url":"https://api.github.com/users/mwielgus/events{/privacy}","received_events_url":"https://api.github.com/users/mwielgus/received_events","type":"User","site_admin":false},"repo":{"id":56583152,"name":"contrib","full_name":"mwielgus/contrib","owner":{"login":"mwielgus","id":11994812,"avatar_url":"https://avatars.githubusercontent.com/u/11994812?v=3","gravatar_id":"","url":"https://api.github.com/users/mwielgus","html_url":"https://github.com/mwielgus","followers_url":"https://api.github.com/users/mwielgus/followers","following_url":"https://api.github.com/users/mwielgus/following{/other_user}","gists_url":"https://api.github.com/users/mwielgus/gists{/gist_id}","starred_url":"https://api.github.com/users/mwielgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwielgus/subscriptions","organizations_url":"https://api.github.com/users/mwielgus/orgs","repos_url":"https://api.github.com/users/mwielgus/repos","events_url":"https://api.github.com/users/mwielgus/events{/privacy}","received_events_url":"https://api.github.com/users/mwielgus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwielgus/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.","fork":true,"url":"https://api.github.com/repos/mwielgus/contrib","forks_url":"https://api.github.com/repos/mwielgus/contrib/forks","keys_url":"https://api.github.com/repos/mwielgus/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwielgus/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwielgus/contrib/teams","hooks_url":"https://api.github.com/repos/mwielgus/contrib/hooks","issue_events_url":"https://api.github.com/repos/mwielgus/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/mwielgus/contrib/events","assignees_url":"https://api.github.com/repos/mwielgus/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/mwielgus/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/mwielgus/contrib/tags","blobs_url":"https://api.github.com/repos/mwielgus/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwielgus/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwielgus/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwielgus/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwielgus/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/mwielgus/contrib/languages","stargazers_url":"https://api.github.com/repos/mwielgus/contrib/stargazers","contributors_url":"https://api.github.com/repos/mwielgus/contrib/contributors","subscribers_url":"https://api.github.com/repos/mwielgus/contrib/subscribers","subscription_url":"https://api.github.com/repos/mwielgus/contrib/subscription","commits_url":"https://api.github.com/repos/mwielgus/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwielgus/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwielgus/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwielgus/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwielgus/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/mwielgus/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwielgus/contrib/merges","archive_url":"https://api.github.com/repos/mwielgus/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwielgus/contrib/downloads","issues_url":"https://api.github.com/repos/mwielgus/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/mwielgus/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/mwielgus/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/mwielgus/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwielgus/contrib/labels{/name}","releases_url":"https://api.github.com/repos/mwielgus/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/mwielgus/contrib/deployments","created_at":"2016-04-19T09:23:15Z","updated_at":"2016-04-19T09:23:18Z","pushed_at":"2016-10-31T15:01:12Z","git_url":"git://github.com/mwielgus/contrib.git","ssh_url":"git@github.com:mwielgus/contrib.git","clone_url":"https://github.com/mwielgus/contrib.git","svn_url":"https://github.com/mwielgus/contrib","homepage":"","size":36784,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"42c63b2babd229e70b99568db6ccfb1508bb68cf","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":40686014,"name":"contrib","full_name":"kubernetes/contrib","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core. Consider creating a new repo instead.","fork":false,"url":"https://api.github.com/repos/kubernetes/contrib","forks_url":"https://api.github.com/repos/kubernetes/contrib/forks","keys_url":"https://api.github.com/repos/kubernetes/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/contrib/teams","hooks_url":"https://api.github.com/repos/kubernetes/contrib/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/contrib/events","assignees_url":"https://api.github.com/repos/kubernetes/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/contrib/tags","blobs_url":"https://api.github.com/repos/kubernetes/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/contrib/languages","stargazers_url":"https://api.github.com/repos/kubernetes/contrib/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/contrib/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/contrib/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/contrib/subscription","commits_url":"https://api.github.com/repos/kubernetes/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/contrib/merges","archive_url":"https://api.github.com/repos/kubernetes/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/contrib/downloads","issues_url":"https://api.github.com/repos/kubernetes/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/contrib/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/contrib/deployments","created_at":"2015-08-13T23:18:26Z","updated_at":"2016-11-04T09:18:42Z","pushed_at":"2016-11-04T14:24:41Z","git_url":"git://github.com/kubernetes/contrib.git","ssh_url":"git@github.com:kubernetes/contrib.git","clone_url":"https://github.com/kubernetes/contrib.git","svn_url":"https://github.com/kubernetes/contrib","homepage":"","size":89416,"stargazers_count":604,"watchers_count":604,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":597,"mirror_url":null,"open_issues_count":374,"forks":597,"open_issues":374,"watchers":604,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/1850"},"html":{"href":"https://github.com/kubernetes/contrib/pull/1850"},"issue":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/1850"},"comments":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/1850/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/1850/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/1850/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/contrib/statuses/3744923bd40ac8fed72a3d9832860dad0ad494a1"}}}}
{"actor":{"display_login":"mwielgus"}}