{"action":"created","comment":{"url":"https://api.github.com/repos/dhlab-basel/Knora/pulls/comments/91072633","pull_request_review_id":11582364,"id":91072633,"diff_hunk":"@@ -76,6 +77,10 @@ class StandoffResponderV1 extends ResponderV1 {\n       */\n     private def createMappingV1(xml: String, userProfile: UserProfileV1): Future[CreateMappingResponseV1] = {\n \n+        // http://stackoverflow.com/questions/7087353/can-a-scala-for-loop-modify-variables-outside-its-scope\n+        // FIXME Ben, I am so ugly and non functional style","path":"webapi/src/main/scala/org/knora/webapi/responders/v1/StandoffResponderV1.scala","position":null,"original_position":19,"commit_id":"b64e6e4f7df337e2a60be12baa05e6a6f82e8a33","original_commit_id":"b64e6e4f7df337e2a60be12baa05e6a6f82e8a33","user":{"login":"benjamingeer","id":558389,"avatar_url":"https://avatars.githubusercontent.com/u/558389?v=3","gravatar_id":"","url":"https://api.github.com/users/benjamingeer","html_url":"https://github.com/benjamingeer","followers_url":"https://api.github.com/users/benjamingeer/followers","following_url":"https://api.github.com/users/benjamingeer/following{/other_user}","gists_url":"https://api.github.com/users/benjamingeer/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamingeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamingeer/subscriptions","organizations_url":"https://api.github.com/users/benjamingeer/orgs","repos_url":"https://api.github.com/users/benjamingeer/repos","events_url":"https://api.github.com/users/benjamingeer/events{/privacy}","received_events_url":"https://api.github.com/users/benjamingeer/received_events","type":"User","site_admin":false},"body":"What would be wrong with using `andThen`? I don't see any code written twice in the resources responder.","created_at":"2016-12-06T13:02:59Z","updated_at":"2016-12-06T13:02:59Z","html_url":"https://github.com/dhlab-basel/Knora/pull/319#discussion_r91072633","pull_request_url":"https://api.github.com/repos/dhlab-basel/Knora/pulls/319","_links":{"self":{"href":"https://api.github.com/repos/dhlab-basel/Knora/pulls/comments/91072633"},"html":{"href":"https://github.com/dhlab-basel/Knora/pull/319#discussion_r91072633"},"pull_request":{"href":"https://api.github.com/repos/dhlab-basel/Knora/pulls/319"}}},"pull_request":{"url":"https://api.github.com/repos/dhlab-basel/Knora/pulls/319","id":93332114,"html_url":"https://github.com/dhlab-basel/Knora/pull/319","diff_url":"https://github.com/dhlab-basel/Knora/pull/319.diff","patch_url":"https://github.com/dhlab-basel/Knora/pull/319.patch","issue_url":"https://api.github.com/repos/dhlab-basel/Knora/issues/319","number":319,"state":"open","locked":false,"title":"Wip/standoff util","user":{"login":"tobiasschweizer","id":6000023,"avatar_url":"https://avatars.githubusercontent.com/u/6000023?v=3","gravatar_id":"","url":"https://api.github.com/users/tobiasschweizer","html_url":"https://github.com/tobiasschweizer","followers_url":"https://api.github.com/users/tobiasschweizer/followers","following_url":"https://api.github.com/users/tobiasschweizer/following{/other_user}","gists_url":"https://api.github.com/users/tobiasschweizer/gists{/gist_id}","starred_url":"https://api.github.com/users/tobiasschweizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobiasschweizer/subscriptions","organizations_url":"https://api.github.com/users/tobiasschweizer/orgs","repos_url":"https://api.github.com/users/tobiasschweizer/repos","events_url":"https://api.github.com/users/tobiasschweizer/events{/privacy}","received_events_url":"https://api.github.com/users/tobiasschweizer/received_events","type":"User","site_admin":false},"body":"Add handling for XML to standoff conversion","created_at":"2016-11-11T13:29:08Z","updated_at":"2016-12-06T13:02:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63e1232f6c3530c23223274090d5898fc7e9418e","assignee":{"login":"tobiasschweizer","id":6000023,"avatar_url":"https://avatars.githubusercontent.com/u/6000023?v=3","gravatar_id":"","url":"https://api.github.com/users/tobiasschweizer","html_url":"https://github.com/tobiasschweizer","followers_url":"https://api.github.com/users/tobiasschweizer/followers","following_url":"https://api.github.com/users/tobiasschweizer/following{/other_user}","gists_url":"https://api.github.com/users/tobiasschweizer/gists{/gist_id}","starred_url":"https://api.github.com/users/tobiasschweizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobiasschweizer/subscriptions","organizations_url":"https://api.github.com/users/tobiasschweizer/orgs","repos_url":"https://api.github.com/users/tobiasschweizer/repos","events_url":"https://api.github.com/users/tobiasschweizer/events{/privacy}","received_events_url":"https://api.github.com/users/tobiasschweizer/received_events","type":"User","site_admin":false},"assignees":[{"login":"tobiasschweizer","id":6000023,"avatar_url":"https://avatars.githubusercontent.com/u/6000023?v=3","gravatar_id":"","url":"https://api.github.com/users/tobiasschweizer","html_url":"https://github.com/tobiasschweizer","followers_url":"https://api.github.com/users/tobiasschweizer/followers","following_url":"https://api.github.com/users/tobiasschweizer/following{/other_user}","gists_url":"https://api.github.com/users/tobiasschweizer/gists{/gist_id}","starred_url":"https://api.github.com/users/tobiasschweizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobiasschweizer/subscriptions","organizations_url":"https://api.github.com/users/tobiasschweizer/orgs","repos_url":"https://api.github.com/users/tobiasschweizer/repos","events_url":"https://api.github.com/users/tobiasschweizer/events{/privacy}","received_events_url":"https://api.github.com/users/tobiasschweizer/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dhlab-basel/Knora/pulls/319/commits","review_comments_url":"https://api.github.com/repos/dhlab-basel/Knora/pulls/319/comments","review_comment_url":"https://api.github.com/repos/dhlab-basel/Knora/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dhlab-basel/Knora/issues/319/comments","statuses_url":"https://api.github.com/repos/dhlab-basel/Knora/statuses/b64e6e4f7df337e2a60be12baa05e6a6f82e8a33","head":{"label":"dhlab-basel:wip/standoffUtil","ref":"wip/standoffUtil","sha":"b64e6e4f7df337e2a60be12baa05e6a6f82e8a33","user":{"login":"dhlab-basel","id":16879914,"avatar_url":"https://avatars.githubusercontent.com/u/16879914?v=3","gravatar_id":"","url":"https://api.github.com/users/dhlab-basel","html_url":"https://github.com/dhlab-basel","followers_url":"https://api.github.com/users/dhlab-basel/followers","following_url":"https://api.github.com/users/dhlab-basel/following{/other_user}","gists_url":"https://api.github.com/users/dhlab-basel/gists{/gist_id}","starred_url":"https://api.github.com/users/dhlab-basel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhlab-basel/subscriptions","organizations_url":"https://api.github.com/users/dhlab-basel/orgs","repos_url":"https://api.github.com/users/dhlab-basel/repos","events_url":"https://api.github.com/users/dhlab-basel/events{/privacy}","received_events_url":"https://api.github.com/users/dhlab-basel/received_events","type":"Organization","site_admin":false},"repo":{"id":47264649,"name":"Knora","full_name":"dhlab-basel/Knora","owner":{"login":"dhlab-basel","id":16879914,"avatar_url":"https://avatars.githubusercontent.com/u/16879914?v=3","gravatar_id":"","url":"https://api.github.com/users/dhlab-basel","html_url":"https://github.com/dhlab-basel","followers_url":"https://api.github.com/users/dhlab-basel/followers","following_url":"https://api.github.com/users/dhlab-basel/following{/other_user}","gists_url":"https://api.github.com/users/dhlab-basel/gists{/gist_id}","starred_url":"https://api.github.com/users/dhlab-basel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhlab-basel/subscriptions","organizations_url":"https://api.github.com/users/dhlab-basel/orgs","repos_url":"https://api.github.com/users/dhlab-basel/repos","events_url":"https://api.github.com/users/dhlab-basel/events{/privacy}","received_events_url":"https://api.github.com/users/dhlab-basel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dhlab-basel/Knora","description":"Knowledge Organization, Representation, and Annotation","fork":false,"url":"https://api.github.com/repos/dhlab-basel/Knora","forks_url":"https://api.github.com/repos/dhlab-basel/Knora/forks","keys_url":"https://api.github.com/repos/dhlab-basel/Knora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhlab-basel/Knora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhlab-basel/Knora/teams","hooks_url":"https://api.github.com/repos/dhlab-basel/Knora/hooks","issue_events_url":"https://api.github.com/repos/dhlab-basel/Knora/issues/events{/number}","events_url":"https://api.github.com/repos/dhlab-basel/Knora/events","assignees_url":"https://api.github.com/repos/dhlab-basel/Knora/assignees{/user}","branches_url":"https://api.github.com/repos/dhlab-basel/Knora/branches{/branch}","tags_url":"https://api.github.com/repos/dhlab-basel/Knora/tags","blobs_url":"https://api.github.com/repos/dhlab-basel/Knora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhlab-basel/Knora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhlab-basel/Knora/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhlab-basel/Knora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhlab-basel/Knora/statuses/{sha}","languages_url":"https://api.github.com/repos/dhlab-basel/Knora/languages","stargazers_url":"https://api.github.com/repos/dhlab-basel/Knora/stargazers","contributors_url":"https://api.github.com/repos/dhlab-basel/Knora/contributors","subscribers_url":"https://api.github.com/repos/dhlab-basel/Knora/subscribers","subscription_url":"https://api.github.com/repos/dhlab-basel/Knora/subscription","commits_url":"https://api.github.com/repos/dhlab-basel/Knora/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhlab-basel/Knora/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhlab-basel/Knora/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhlab-basel/Knora/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhlab-basel/Knora/contents/{+path}","compare_url":"https://api.github.com/repos/dhlab-basel/Knora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhlab-basel/Knora/merges","archive_url":"https://api.github.com/repos/dhlab-basel/Knora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhlab-basel/Knora/downloads","issues_url":"https://api.github.com/repos/dhlab-basel/Knora/issues{/number}","pulls_url":"https://api.github.com/repos/dhlab-basel/Knora/pulls{/number}","milestones_url":"https://api.github.com/repos/dhlab-basel/Knora/milestones{/number}","notifications_url":"https://api.github.com/repos/dhlab-basel/Knora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhlab-basel/Knora/labels{/name}","releases_url":"https://api.github.com/repos/dhlab-basel/Knora/releases{/id}","deployments_url":"https://api.github.com/repos/dhlab-basel/Knora/deployments","created_at":"2015-12-02T14:00:26Z","updated_at":"2016-11-15T00:58:10Z","pushed_at":"2016-12-06T11:56:41Z","git_url":"git://github.com/dhlab-basel/Knora.git","ssh_url":"git@github.com:dhlab-basel/Knora.git","clone_url":"https://github.com/dhlab-basel/Knora.git","svn_url":"https://github.com/dhlab-basel/Knora","homepage":"http://knora.org","size":248759,"stargazers_count":7,"watchers_count":7,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":124,"forks":5,"open_issues":124,"watchers":7,"default_branch":"develop"}},"base":{"label":"dhlab-basel:develop","ref":"develop","sha":"3d7176bd7eb8fe498cef73a34462e36512d0c385","user":{"login":"dhlab-basel","id":16879914,"avatar_url":"https://avatars.githubusercontent.com/u/16879914?v=3","gravatar_id":"","url":"https://api.github.com/users/dhlab-basel","html_url":"https://github.com/dhlab-basel","followers_url":"https://api.github.com/users/dhlab-basel/followers","following_url":"https://api.github.com/users/dhlab-basel/following{/other_user}","gists_url":"https://api.github.com/users/dhlab-basel/gists{/gist_id}","starred_url":"https://api.github.com/users/dhlab-basel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhlab-basel/subscriptions","organizations_url":"https://api.github.com/users/dhlab-basel/orgs","repos_url":"https://api.github.com/users/dhlab-basel/repos","events_url":"https://api.github.com/users/dhlab-basel/events{/privacy}","received_events_url":"https://api.github.com/users/dhlab-basel/received_events","type":"Organization","site_admin":false},"repo":{"id":47264649,"name":"Knora","full_name":"dhlab-basel/Knora","owner":{"login":"dhlab-basel","id":16879914,"avatar_url":"https://avatars.githubusercontent.com/u/16879914?v=3","gravatar_id":"","url":"https://api.github.com/users/dhlab-basel","html_url":"https://github.com/dhlab-basel","followers_url":"https://api.github.com/users/dhlab-basel/followers","following_url":"https://api.github.com/users/dhlab-basel/following{/other_user}","gists_url":"https://api.github.com/users/dhlab-basel/gists{/gist_id}","starred_url":"https://api.github.com/users/dhlab-basel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhlab-basel/subscriptions","organizations_url":"https://api.github.com/users/dhlab-basel/orgs","repos_url":"https://api.github.com/users/dhlab-basel/repos","events_url":"https://api.github.com/users/dhlab-basel/events{/privacy}","received_events_url":"https://api.github.com/users/dhlab-basel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dhlab-basel/Knora","description":"Knowledge Organization, Representation, and Annotation","fork":false,"url":"https://api.github.com/repos/dhlab-basel/Knora","forks_url":"https://api.github.com/repos/dhlab-basel/Knora/forks","keys_url":"https://api.github.com/repos/dhlab-basel/Knora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhlab-basel/Knora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhlab-basel/Knora/teams","hooks_url":"https://api.github.com/repos/dhlab-basel/Knora/hooks","issue_events_url":"https://api.github.com/repos/dhlab-basel/Knora/issues/events{/number}","events_url":"https://api.github.com/repos/dhlab-basel/Knora/events","assignees_url":"https://api.github.com/repos/dhlab-basel/Knora/assignees{/user}","branches_url":"https://api.github.com/repos/dhlab-basel/Knora/branches{/branch}","tags_url":"https://api.github.com/repos/dhlab-basel/Knora/tags","blobs_url":"https://api.github.com/repos/dhlab-basel/Knora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhlab-basel/Knora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhlab-basel/Knora/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhlab-basel/Knora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhlab-basel/Knora/statuses/{sha}","languages_url":"https://api.github.com/repos/dhlab-basel/Knora/languages","stargazers_url":"https://api.github.com/repos/dhlab-basel/Knora/stargazers","contributors_url":"https://api.github.com/repos/dhlab-basel/Knora/contributors","subscribers_url":"https://api.github.com/repos/dhlab-basel/Knora/subscribers","subscription_url":"https://api.github.com/repos/dhlab-basel/Knora/subscription","commits_url":"https://api.github.com/repos/dhlab-basel/Knora/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhlab-basel/Knora/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhlab-basel/Knora/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhlab-basel/Knora/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhlab-basel/Knora/contents/{+path}","compare_url":"https://api.github.com/repos/dhlab-basel/Knora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhlab-basel/Knora/merges","archive_url":"https://api.github.com/repos/dhlab-basel/Knora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhlab-basel/Knora/downloads","issues_url":"https://api.github.com/repos/dhlab-basel/Knora/issues{/number}","pulls_url":"https://api.github.com/repos/dhlab-basel/Knora/pulls{/number}","milestones_url":"https://api.github.com/repos/dhlab-basel/Knora/milestones{/number}","notifications_url":"https://api.github.com/repos/dhlab-basel/Knora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhlab-basel/Knora/labels{/name}","releases_url":"https://api.github.com/repos/dhlab-basel/Knora/releases{/id}","deployments_url":"https://api.github.com/repos/dhlab-basel/Knora/deployments","created_at":"2015-12-02T14:00:26Z","updated_at":"2016-11-15T00:58:10Z","pushed_at":"2016-12-06T11:56:41Z","git_url":"git://github.com/dhlab-basel/Knora.git","ssh_url":"git@github.com:dhlab-basel/Knora.git","clone_url":"https://github.com/dhlab-basel/Knora.git","svn_url":"https://github.com/dhlab-basel/Knora","homepage":"http://knora.org","size":248759,"stargazers_count":7,"watchers_count":7,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":124,"forks":5,"open_issues":124,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/dhlab-basel/Knora/pulls/319"},"html":{"href":"https://github.com/dhlab-basel/Knora/pull/319"},"issue":{"href":"https://api.github.com/repos/dhlab-basel/Knora/issues/319"},"comments":{"href":"https://api.github.com/repos/dhlab-basel/Knora/issues/319/comments"},"review_comments":{"href":"https://api.github.com/repos/dhlab-basel/Knora/pulls/319/comments"},"review_comment":{"href":"https://api.github.com/repos/dhlab-basel/Knora/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dhlab-basel/Knora/pulls/319/commits"},"statuses":{"href":"https://api.github.com/repos/dhlab-basel/Knora/statuses/b64e6e4f7df337e2a60be12baa05e6a6f82e8a33"}}}}
{"actor":{"display_login":"benjamingeer"}}