{"action":"created","issue":{"url":"https://api.github.com/repos/visiblevc/wordpress-starter/issues/40","repository_url":"https://api.github.com/repos/visiblevc/wordpress-starter","labels_url":"https://api.github.com/repos/visiblevc/wordpress-starter/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/visiblevc/wordpress-starter/issues/40/comments","events_url":"https://api.github.com/repos/visiblevc/wordpress-starter/issues/40/events","html_url":"https://github.com/visiblevc/wordpress-starter/pull/40","id":178403759,"number":40,"title":"Various changes","user":{"login":"dsifford","id":5240018,"avatar_url":"https://avatars.githubusercontent.com/u/5240018?v=3","gravatar_id":"","url":"https://api.github.com/users/dsifford","html_url":"https://github.com/dsifford","followers_url":"https://api.github.com/users/dsifford/followers","following_url":"https://api.github.com/users/dsifford/following{/other_user}","gists_url":"https://api.github.com/users/dsifford/gists{/gist_id}","starred_url":"https://api.github.com/users/dsifford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsifford/subscriptions","organizations_url":"https://api.github.com/users/dsifford/orgs","repos_url":"https://api.github.com/users/dsifford/repos","events_url":"https://api.github.com/users/dsifford/events{/privacy}","received_events_url":"https://api.github.com/users/dsifford/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2016-09-21T16:51:52Z","updated_at":"2016-10-18T19:04:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/visiblevc/wordpress-starter/pulls/40","html_url":"https://github.com/visiblevc/wordpress-starter/pull/40","diff_url":"https://github.com/visiblevc/wordpress-starter/pull/40.diff","patch_url":"https://github.com/visiblevc/wordpress-starter/pull/40.patch"},"body":"I was meaning to update this for a little while. Finally got around to it. Feel free to tear this apart.\r\n\r\n### Changes:\r\n- Broke apart run.sh into separate functions.\r\n- Add new URL plugin format which allows for better checking after\r\ninitial build.\r\n- Add `VERBOSE` environment variable option which allows the build to\r\nrun verbosely if one chooses.\r\n- Prettier logging.\r\n- Add `--activate` after plugin installs so that all plugins start out\r\nactivated.\r\n- Suppress warning for cases where /data directory isn't volumed\r\n- Correct for missing trailing commas in PLUGINS and THEMES\r\n- Activate, but don't install, locally volumed plugins\r\n\r\n### BREAKING CHANGE\r\n\r\nYou are now required to explicitly mention all plugins and themes you depend on in the compose file, **including locally volumed plugins/themes!**\r\n\r\nThe format for locally volumed plugins/themes is `[local]my-plugin-slug` and `[local]my-theme-slug` (slug is the directory name by convention). \r\n\r\nThis is required so that the build can still be aware that you need those when it goes in to look for orphaned plugins/themes. \r\n\r\nWithout adding this to your docker-compose file, the build will think your volumed files are orphaned and it will delete them.... Full stop.... Repeat... _will delete them_.\r\n\r\n\r\n### Example:\r\n```yml\r\nversion: '2'\r\nservices:\r\n    wordpress:\r\n        image: dsifford/wordpress:apache-next\r\n        volumes:\r\n            # Database\r\n            - ./data:/data\r\n            # Plugins\r\n            - ./wp-content/plugins/my-plugin-one:/app/wp-content/plugins/my-plugin-one\r\n            - ./wp-content/plugins/my-plugin-two:/app/wp-content/plugins/my-plugin-two\r\n            # Themes\r\n            - ./wp-content/themes/my-theme:/app/wp-content/themes/my-theme\r\n        environment:\r\n            DB_NAME: wordpress\r\n            DB_PASS: root\r\n            DB_USER: root\r\n            PLUGINS: >-\r\n                akismet,\r\n                [local]my-plugin-one,\r\n                [local]my-plugin-two,\r\n            THEMES: >-\r\n                [local]my-theme,\r\n    db:\r\n        image: mariadb:10\r\n        expose:\r\n            - \"3306\"\r\n        environment:\r\n            MYSQL_ROOT_PASSWORD: root\r\n        volumes:\r\n            - data:/var/lib/mysql\r\n```"},"comment":{"url":"https://api.github.com/repos/visiblevc/wordpress-starter/issues/comments/254606901","html_url":"https://github.com/visiblevc/wordpress-starter/pull/40#issuecomment-254606901","issue_url":"https://api.github.com/repos/visiblevc/wordpress-starter/issues/40","id":254606901,"user":{"login":"dsifford","id":5240018,"avatar_url":"https://avatars.githubusercontent.com/u/5240018?v=3","gravatar_id":"","url":"https://api.github.com/users/dsifford","html_url":"https://github.com/dsifford","followers_url":"https://api.github.com/users/dsifford/followers","following_url":"https://api.github.com/users/dsifford/following{/other_user}","gists_url":"https://api.github.com/users/dsifford/gists{/gist_id}","starred_url":"https://api.github.com/users/dsifford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsifford/subscriptions","organizations_url":"https://api.github.com/users/dsifford/orgs","repos_url":"https://api.github.com/users/dsifford/repos","events_url":"https://api.github.com/users/dsifford/events{/privacy}","received_events_url":"https://api.github.com/users/dsifford/received_events","type":"User","site_admin":false},"created_at":"2016-10-18T19:04:12Z","updated_at":"2016-10-18T19:04:12Z","body":"Ah, I see.. yeah that's probably why you had issues. \r\n\r\nThe `VERBOSE` flag is supposed to only be set to `'true'` if you need it. Otherwise, leave it out. Setting it to `'false'` in compose sets the actual implementation of `VERBOSE` in `run.sh` to a string, which will always evaluate to true. "}}
{"actor":{"display_login":"dsifford"}}