{"push_id":1219606899,"size":9,"distinct_size":1,"ref":"refs/heads/ppc-for-2.8","head":"58d2d4fa7e4a5dadb45a45748b2d3bdfaa834338","before":"62b2aab047f1504a1170f688b63824e75d625fbb","commits":[{"sha":"00f3cc657be8d154e928eaaafb5ff1fca75b35ee","author":{"name":"Igor Mammedov","email":"a1a18e400440964c54d5631ddb40ab196f72af9d@redhat.com"},"message":"exec: reduce CONFIG_USER_ONLY ifdeffenery\n\nSigned-off-by: Igor Mammedov <imammedo@redhat.com>\nReviewed-by: David Gibson <david@gibson.dropbear.id.au>","distinct":false,"url":"https://api.github.com/repos/dgibson/qemu/commits/00f3cc657be8d154e928eaaafb5ff1fca75b35ee"},{"sha":"50a2ae9a4c57aa66e51e4ad0202830092cbb6b87","author":{"name":"Igor Mammedov","email":"a1a18e400440964c54d5631ddb40ab196f72af9d@redhat.com"},"message":"exec: don't use cpu_index to detect if cpu_exec_init()'s been called for cpu\n\nInstead use QTAIL's tqe_prev field to detect if cpu's been\nplaced in list by cpu_exec_init() which is always set if\nQTAIL element is in list.\n\nFixes SIGSEGV on failure path in case cpu_index is assigned\nby board and cpu.relalize() fails before cpu_exec_init() is called.\n\nIn follow up patches, cpu_index will be assigned by boards that\nsupport cpu hot(un)plug and need stable cpu_index that doesn't\ndepend on order cpus are created/removed.\n\nSigned-off-by: Igor Mammedov <imammedo@redhat.com>\nReported-by: David Gibson <david@gibson.dropbear.id.au>","distinct":false,"url":"https://api.github.com/repos/dgibson/qemu/commits/50a2ae9a4c57aa66e51e4ad0202830092cbb6b87"},{"sha":"1880006a6dbe2061a0f2cf86cce5dc4d6dc43aa4","author":{"name":"Igor Mammedov","email":"a1a18e400440964c54d5631ddb40ab196f72af9d@redhat.com"},"message":"exec: set cpu_index only if it's not been explictly set\n\nit keeps the legacy behavior for all users that doesn't care\nabout stable cpu_index value, but would allow boards that\nwould support device_add/device_del to set stable cpu_index\nthat won't depend on order in which cpus are created/destroyed.\n\nWhile at that simplify cpu_get_free_index() as cpu_index\ngenerated by USER_ONLY and softmmu variants is the same\nsince none of the users support cpu-remove so far, except\nof not yet released spapr/x86 device_add/delr, which\nwill be altered by follow up patches to set stable\ncpu_index manually.\n\nSigned-off-by: Igor Mammedov <imammedo@redhat.com>\nReviewed-by: David Gibson <david@gibson.dropbear.id.au>","distinct":false,"url":"https://api.github.com/repos/dgibson/qemu/commits/1880006a6dbe2061a0f2cf86cce5dc4d6dc43aa4"},{"sha":"e0f33fefbbda241dd4c212049f993eea90aee627","author":{"name":"Igor Mammedov","email":"a1a18e400440964c54d5631ddb40ab196f72af9d@redhat.com"},"message":"qdev: fix object reference leak in case device.realize() fails\n\nIf device doesn't have parent assined before its realize\nis called, device_set_realized() will implicitly set parent\nto '/machine/unattached'.\n\nHowever device_set_realized() may fail after that point at\nseveral other points leaving not realized object dangling\nin '/machine/unattached' and as result caller of\n\n  obj = object_new()\n    obj->ref == 1\n  object_property_set_bool(obj,..., true, \"realized\",...)\n    obj->ref == 2\n  if (fail)\n      object_unref(obj);\n      obj->ref == 1\n\nwill get object leak instead of expected object destruction.\n\nFix it by making device_set_realized() to cleanup after itself\nin case of failure.\n\nSigned-off-by: Igor Mammedov <imammedo@redhat.com>\nReviewed-by: David Gibson <david@gibson.dropbear.id.au>","distinct":false,"url":"https://api.github.com/repos/dgibson/qemu/commits/e0f33fefbbda241dd4c212049f993eea90aee627"},{"sha":"b639bbe8eab25c0bb0315d5bfa56366ccee57385","author":{"name":"Igor Mammedov","email":"a1a18e400440964c54d5631ddb40ab196f72af9d@redhat.com"},"message":"pc: init CPUState->cpu_index with index in possible_cpus[]\n\nIt will enshure that cpu_index for a given cpu stays the same\nregardless of the order cpus has been created/deleted.\n\nNo compat code is needed as for initial cpus index in\npossible_cpus[] matches cpu_index that's been auto-allocated\nin cpu_exec_init().\n\nTha same applies for hotplug with cpu-add command if cpus are\nadded sequentially in increasing order as 'id' matches cpu_index.\n\nIf cpu-add had been used for creating out-of-order cpus,\nthat created unmigratable instance since it were not possible\nto start target with the same cpu_index using old way\nof migrating instance with hotplugged cpus:\n\n* source QEMU with CLI (-smp 1,maxcpus=3 and cpu-add id=2)\n  following set of cpu_index is allocated [0, 1] with\n  apics set [0, 2] respectivelly\n* target QEMU is started with CLI -smp 2,maxcpus=3\n  resulting in set of cpu_index [0, 1] but with\n  set of apics [0, 1] wich doesn't match source.\n\nSo we don't need compat code in this case as it's never worked\nand newelly added device_add support would use stable cpu_index\nset by machine to begin with, so it won't have above limitation\nand source QEMU could be migrated to destination regardless\nof the order cpus were created.\n\nSigned-off-by: Igor Mammedov <imammedo@redhat.com>\nReviewed-by: David Gibson <david@gibson.dropbear.id.au>\nReviewed-by: Michael S. Tsirkin <mst@redhat.com>","distinct":false,"url":"https://api.github.com/repos/dgibson/qemu/commits/b639bbe8eab25c0bb0315d5bfa56366ccee57385"},{"sha":"cfb6fa545b29740999ccc0c347bb19ed0c8af028","author":{"name":"Igor Mammedov","email":"a1a18e400440964c54d5631ddb40ab196f72af9d@redhat.com"},"message":"Revert \"pc: Enforce adding CPUs contiguously and removing them in opposite order\"\n\nThis reverts commit 4da7faaeb0c7dd3f7f233165d336c878f78fd1eb.\n\nHowever since commit:\n  pc: init CPUState->cpu_index with index in possible_cpus[]\ncpu_index is stable regardless of the order cpus were created\nand QEMU instance stays migratable always so limitation added\nby 4da7faaeb could be safely removed.\n\nSigned-off-by: Igor Mammedov <imammedo@redhat.com>\nReviewed-by: Michael S. Tsirkin <mst@redhat.com>","distinct":false,"url":"https://api.github.com/repos/dgibson/qemu/commits/cfb6fa545b29740999ccc0c347bb19ed0c8af028"},{"sha":"02985c56e491910ef71112fdf42135274cc8013e","author":{"name":"Igor Mammedov","email":"a1a18e400440964c54d5631ddb40ab196f72af9d@redhat.com"},"message":"spapr: init CPUState->cpu_index with index relative to core-id\n\nIt will enshure that cpu_index for a given cpu stays the same\nregardless of the order cpus has been created/deleted and so\nit would be possible to migrate QEMU instance with out of order\ncreated CPU.\n\nSigned-off-by: Igor Mammedov <imammedo@redhat.com>\nSigned-off-by: David Gibson <david@gibson.dropbear.id.au>","distinct":false,"url":"https://api.github.com/repos/dgibson/qemu/commits/02985c56e491910ef71112fdf42135274cc8013e"},{"sha":"6966d3f49a66297ffa4ea1d2d23bb208f427c1d2","author":{"name":"David Gibson","email":"d8099b0f90e53c29d29eb12a7a3caa5af4f12681@gibson.dropbear.id.au"},"message":"Revert \"spapr: Ensure CPU cores are added contiguously and removed in LIFO order\"\n\nThis reverts commit 5cbc64de25973e9129c5a7897734a06ac64b9aff.\n\nNow that we have stable cpu_index values for pseries-2.7 (and future)\nmachine types, we can now safely allow hotplug and unplug in any order.\n\nConflicts:\n\thw/ppc/spapr_cpu_core.c\n\nSome conflicts on revert due to some small changes in the inserted\ncode since the original commit.\n\nSigned-off-by: David Gibson <david@gibson.dropbear.id.au>","distinct":false,"url":"https://api.github.com/repos/dgibson/qemu/commits/6966d3f49a66297ffa4ea1d2d23bb208f427c1d2"},{"sha":"58d2d4fa7e4a5dadb45a45748b2d3bdfaa834338","author":{"name":"Greg Kurz","email":"5aa6caa8211c90ed0e5aca6f39d105d45c081d73@kaod.org"},"message":"xics_kvm: drop extra checking of kernel_xics_fd\n\nWe abort a few lines above if kernel_xics_fd == -1.\n\nThis is only code cleanup.\n\nSigned-off-by: Greg Kurz <groug@kaod.org>\nSigned-off-by: David Gibson <david@gibson.dropbear.id.au>","distinct":true,"url":"https://api.github.com/repos/dgibson/qemu/commits/58d2d4fa7e4a5dadb45a45748b2d3bdfaa834338"}]}
{"actor":{"display_login":"dgibson"}}