{"action":"created","comment":{"url":"https://api.github.com/repos/meshlink/meshlink/pulls/comments/79041685","id":79041685,"diff_hunk":"@@ -282,10 +314,15 @@ bool id_h(meshlink_handle_t *mesh, connection_t *c, const char *request) {\n \n \t\tc->status.invitation = true;\n \t\tchar *mykey = ecdsa_get_base64_public_key(mesh->invitation_key);\n-\t\tif(!mykey)\n+\t\tif(!mykey) {\n+\t\t\tlogger(mesh, MESHLINK_ERROR, \"Failed to retrieve invitation key\\n\");\n \t\t\treturn false;\n-\t\tif(0 != send_request(mesh, c, \"%d %s\", ACK, mykey))\n+\t\t}\n+\t\tint err = send_request(mesh, c, \"%d %s\", ACK, mykey);\n+\t\tif(err) {\n+\t\t\tlogger(mesh, MESHLINK_ERROR, \"id_h send_request failed with %d\\n\", err);\n \t\t\treturn false;\n+\t\t}\n \t\tfree(mykey);","path":"src/protocol_auth.c","position":122,"original_position":122,"commit_id":"e96891bc25333a3cc07f50a7a14a88e5a739d682","original_commit_id":"e96891bc25333a3cc07f50a7a14a88e5a739d682","user":{"login":"a-krebs","id":1214472,"avatar_url":"https://avatars.githubusercontent.com/u/1214472?v=3","gravatar_id":"","url":"https://api.github.com/users/a-krebs","html_url":"https://github.com/a-krebs","followers_url":"https://api.github.com/users/a-krebs/followers","following_url":"https://api.github.com/users/a-krebs/following{/other_user}","gists_url":"https://api.github.com/users/a-krebs/gists{/gist_id}","starred_url":"https://api.github.com/users/a-krebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-krebs/subscriptions","organizations_url":"https://api.github.com/users/a-krebs/orgs","repos_url":"https://api.github.com/users/a-krebs/repos","events_url":"https://api.github.com/users/a-krebs/events{/privacy}","received_events_url":"https://api.github.com/users/a-krebs/received_events","type":"User","site_admin":false},"body":"Memory leak, in the old code too. `free(mykey)` before returning.","created_at":"2016-09-15T19:21:50Z","updated_at":"2016-09-15T19:21:51Z","html_url":"https://github.com/meshlink/meshlink/pull/43#discussion_r79041685","pull_request_url":"https://api.github.com/repos/meshlink/meshlink/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/meshlink/meshlink/pulls/comments/79041685"},"html":{"href":"https://github.com/meshlink/meshlink/pull/43#discussion_r79041685"},"pull_request":{"href":"https://api.github.com/repos/meshlink/meshlink/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/meshlink/meshlink/pulls/43","id":85317315,"html_url":"https://github.com/meshlink/meshlink/pull/43","diff_url":"https://github.com/meshlink/meshlink/pull/43.diff","patch_url":"https://github.com/meshlink/meshlink/pull/43.patch","issue_url":"https://api.github.com/repos/meshlink/meshlink/issues/43","number":43,"state":"open","locked":false,"title":"Feature error logging","user":{"login":"everHannes","id":9902721,"avatar_url":"https://avatars.githubusercontent.com/u/9902721?v=3","gravatar_id":"","url":"https://api.github.com/users/everHannes","html_url":"https://github.com/everHannes","followers_url":"https://api.github.com/users/everHannes/followers","following_url":"https://api.github.com/users/everHannes/following{/other_user}","gists_url":"https://api.github.com/users/everHannes/gists{/gist_id}","starred_url":"https://api.github.com/users/everHannes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everHannes/subscriptions","organizations_url":"https://api.github.com/users/everHannes/orgs","repos_url":"https://api.github.com/users/everHannes/repos","events_url":"https://api.github.com/users/everHannes/events{/privacy}","received_events_url":"https://api.github.com/users/everHannes/received_events","type":"User","site_admin":false},"body":"adds more send / recv error logging","created_at":"2016-09-14T22:31:09Z","updated_at":"2016-09-15T19:21:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7643615215ed896408f2ee70f38df042a8b029bc","assignee":{"login":"a-krebs","id":1214472,"avatar_url":"https://avatars.githubusercontent.com/u/1214472?v=3","gravatar_id":"","url":"https://api.github.com/users/a-krebs","html_url":"https://github.com/a-krebs","followers_url":"https://api.github.com/users/a-krebs/followers","following_url":"https://api.github.com/users/a-krebs/following{/other_user}","gists_url":"https://api.github.com/users/a-krebs/gists{/gist_id}","starred_url":"https://api.github.com/users/a-krebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-krebs/subscriptions","organizations_url":"https://api.github.com/users/a-krebs/orgs","repos_url":"https://api.github.com/users/a-krebs/repos","events_url":"https://api.github.com/users/a-krebs/events{/privacy}","received_events_url":"https://api.github.com/users/a-krebs/received_events","type":"User","site_admin":false},"assignees":[{"login":"a-krebs","id":1214472,"avatar_url":"https://avatars.githubusercontent.com/u/1214472?v=3","gravatar_id":"","url":"https://api.github.com/users/a-krebs","html_url":"https://github.com/a-krebs","followers_url":"https://api.github.com/users/a-krebs/followers","following_url":"https://api.github.com/users/a-krebs/following{/other_user}","gists_url":"https://api.github.com/users/a-krebs/gists{/gist_id}","starred_url":"https://api.github.com/users/a-krebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-krebs/subscriptions","organizations_url":"https://api.github.com/users/a-krebs/orgs","repos_url":"https://api.github.com/users/a-krebs/repos","events_url":"https://api.github.com/users/a-krebs/events{/privacy}","received_events_url":"https://api.github.com/users/a-krebs/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/meshlink/meshlink/pulls/43/commits","review_comments_url":"https://api.github.com/repos/meshlink/meshlink/pulls/43/comments","review_comment_url":"https://api.github.com/repos/meshlink/meshlink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meshlink/meshlink/issues/43/comments","statuses_url":"https://api.github.com/repos/meshlink/meshlink/statuses/e96891bc25333a3cc07f50a7a14a88e5a739d682","head":{"label":"meshlink:feature/error_logging","ref":"feature/error_logging","sha":"e96891bc25333a3cc07f50a7a14a88e5a739d682","user":{"login":"meshlink","id":13501647,"avatar_url":"https://avatars.githubusercontent.com/u/13501647?v=3","gravatar_id":"","url":"https://api.github.com/users/meshlink","html_url":"https://github.com/meshlink","followers_url":"https://api.github.com/users/meshlink/followers","following_url":"https://api.github.com/users/meshlink/following{/other_user}","gists_url":"https://api.github.com/users/meshlink/gists{/gist_id}","starred_url":"https://api.github.com/users/meshlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meshlink/subscriptions","organizations_url":"https://api.github.com/users/meshlink/orgs","repos_url":"https://api.github.com/users/meshlink/repos","events_url":"https://api.github.com/users/meshlink/events{/privacy}","received_events_url":"https://api.github.com/users/meshlink/received_events","type":"Organization","site_admin":false},"repo":{"id":39792823,"name":"meshlink","full_name":"meshlink/meshlink","owner":{"login":"meshlink","id":13501647,"avatar_url":"https://avatars.githubusercontent.com/u/13501647?v=3","gravatar_id":"","url":"https://api.github.com/users/meshlink","html_url":"https://github.com/meshlink","followers_url":"https://api.github.com/users/meshlink/followers","following_url":"https://api.github.com/users/meshlink/following{/other_user}","gists_url":"https://api.github.com/users/meshlink/gists{/gist_id}","starred_url":"https://api.github.com/users/meshlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meshlink/subscriptions","organizations_url":"https://api.github.com/users/meshlink/orgs","repos_url":"https://api.github.com/users/meshlink/repos","events_url":"https://api.github.com/users/meshlink/events{/privacy}","received_events_url":"https://api.github.com/users/meshlink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meshlink/meshlink","description":"","fork":false,"url":"https://api.github.com/repos/meshlink/meshlink","forks_url":"https://api.github.com/repos/meshlink/meshlink/forks","keys_url":"https://api.github.com/repos/meshlink/meshlink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meshlink/meshlink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meshlink/meshlink/teams","hooks_url":"https://api.github.com/repos/meshlink/meshlink/hooks","issue_events_url":"https://api.github.com/repos/meshlink/meshlink/issues/events{/number}","events_url":"https://api.github.com/repos/meshlink/meshlink/events","assignees_url":"https://api.github.com/repos/meshlink/meshlink/assignees{/user}","branches_url":"https://api.github.com/repos/meshlink/meshlink/branches{/branch}","tags_url":"https://api.github.com/repos/meshlink/meshlink/tags","blobs_url":"https://api.github.com/repos/meshlink/meshlink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meshlink/meshlink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meshlink/meshlink/git/refs{/sha}","trees_url":"https://api.github.com/repos/meshlink/meshlink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meshlink/meshlink/statuses/{sha}","languages_url":"https://api.github.com/repos/meshlink/meshlink/languages","stargazers_url":"https://api.github.com/repos/meshlink/meshlink/stargazers","contributors_url":"https://api.github.com/repos/meshlink/meshlink/contributors","subscribers_url":"https://api.github.com/repos/meshlink/meshlink/subscribers","subscription_url":"https://api.github.com/repos/meshlink/meshlink/subscription","commits_url":"https://api.github.com/repos/meshlink/meshlink/commits{/sha}","git_commits_url":"https://api.github.com/repos/meshlink/meshlink/git/commits{/sha}","comments_url":"https://api.github.com/repos/meshlink/meshlink/comments{/number}","issue_comment_url":"https://api.github.com/repos/meshlink/meshlink/issues/comments{/number}","contents_url":"https://api.github.com/repos/meshlink/meshlink/contents/{+path}","compare_url":"https://api.github.com/repos/meshlink/meshlink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meshlink/meshlink/merges","archive_url":"https://api.github.com/repos/meshlink/meshlink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meshlink/meshlink/downloads","issues_url":"https://api.github.com/repos/meshlink/meshlink/issues{/number}","pulls_url":"https://api.github.com/repos/meshlink/meshlink/pulls{/number}","milestones_url":"https://api.github.com/repos/meshlink/meshlink/milestones{/number}","notifications_url":"https://api.github.com/repos/meshlink/meshlink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meshlink/meshlink/labels{/name}","releases_url":"https://api.github.com/repos/meshlink/meshlink/releases{/id}","deployments_url":"https://api.github.com/repos/meshlink/meshlink/deployments","created_at":"2015-07-27T19:11:57Z","updated_at":"2016-02-17T18:30:10Z","pushed_at":"2016-09-15T16:15:50Z","git_url":"git://github.com/meshlink/meshlink.git","ssh_url":"git@github.com:meshlink/meshlink.git","clone_url":"https://github.com/meshlink/meshlink.git","svn_url":"https://github.com/meshlink/meshlink","homepage":null,"size":3707,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":1,"default_branch":"everbase"}},"base":{"label":"meshlink:everbase","ref":"everbase","sha":"1f40fbfca59a52ec4f42ebad445301fb38b2df7e","user":{"login":"meshlink","id":13501647,"avatar_url":"https://avatars.githubusercontent.com/u/13501647?v=3","gravatar_id":"","url":"https://api.github.com/users/meshlink","html_url":"https://github.com/meshlink","followers_url":"https://api.github.com/users/meshlink/followers","following_url":"https://api.github.com/users/meshlink/following{/other_user}","gists_url":"https://api.github.com/users/meshlink/gists{/gist_id}","starred_url":"https://api.github.com/users/meshlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meshlink/subscriptions","organizations_url":"https://api.github.com/users/meshlink/orgs","repos_url":"https://api.github.com/users/meshlink/repos","events_url":"https://api.github.com/users/meshlink/events{/privacy}","received_events_url":"https://api.github.com/users/meshlink/received_events","type":"Organization","site_admin":false},"repo":{"id":39792823,"name":"meshlink","full_name":"meshlink/meshlink","owner":{"login":"meshlink","id":13501647,"avatar_url":"https://avatars.githubusercontent.com/u/13501647?v=3","gravatar_id":"","url":"https://api.github.com/users/meshlink","html_url":"https://github.com/meshlink","followers_url":"https://api.github.com/users/meshlink/followers","following_url":"https://api.github.com/users/meshlink/following{/other_user}","gists_url":"https://api.github.com/users/meshlink/gists{/gist_id}","starred_url":"https://api.github.com/users/meshlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meshlink/subscriptions","organizations_url":"https://api.github.com/users/meshlink/orgs","repos_url":"https://api.github.com/users/meshlink/repos","events_url":"https://api.github.com/users/meshlink/events{/privacy}","received_events_url":"https://api.github.com/users/meshlink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meshlink/meshlink","description":"","fork":false,"url":"https://api.github.com/repos/meshlink/meshlink","forks_url":"https://api.github.com/repos/meshlink/meshlink/forks","keys_url":"https://api.github.com/repos/meshlink/meshlink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meshlink/meshlink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meshlink/meshlink/teams","hooks_url":"https://api.github.com/repos/meshlink/meshlink/hooks","issue_events_url":"https://api.github.com/repos/meshlink/meshlink/issues/events{/number}","events_url":"https://api.github.com/repos/meshlink/meshlink/events","assignees_url":"https://api.github.com/repos/meshlink/meshlink/assignees{/user}","branches_url":"https://api.github.com/repos/meshlink/meshlink/branches{/branch}","tags_url":"https://api.github.com/repos/meshlink/meshlink/tags","blobs_url":"https://api.github.com/repos/meshlink/meshlink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meshlink/meshlink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meshlink/meshlink/git/refs{/sha}","trees_url":"https://api.github.com/repos/meshlink/meshlink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meshlink/meshlink/statuses/{sha}","languages_url":"https://api.github.com/repos/meshlink/meshlink/languages","stargazers_url":"https://api.github.com/repos/meshlink/meshlink/stargazers","contributors_url":"https://api.github.com/repos/meshlink/meshlink/contributors","subscribers_url":"https://api.github.com/repos/meshlink/meshlink/subscribers","subscription_url":"https://api.github.com/repos/meshlink/meshlink/subscription","commits_url":"https://api.github.com/repos/meshlink/meshlink/commits{/sha}","git_commits_url":"https://api.github.com/repos/meshlink/meshlink/git/commits{/sha}","comments_url":"https://api.github.com/repos/meshlink/meshlink/comments{/number}","issue_comment_url":"https://api.github.com/repos/meshlink/meshlink/issues/comments{/number}","contents_url":"https://api.github.com/repos/meshlink/meshlink/contents/{+path}","compare_url":"https://api.github.com/repos/meshlink/meshlink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meshlink/meshlink/merges","archive_url":"https://api.github.com/repos/meshlink/meshlink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meshlink/meshlink/downloads","issues_url":"https://api.github.com/repos/meshlink/meshlink/issues{/number}","pulls_url":"https://api.github.com/repos/meshlink/meshlink/pulls{/number}","milestones_url":"https://api.github.com/repos/meshlink/meshlink/milestones{/number}","notifications_url":"https://api.github.com/repos/meshlink/meshlink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meshlink/meshlink/labels{/name}","releases_url":"https://api.github.com/repos/meshlink/meshlink/releases{/id}","deployments_url":"https://api.github.com/repos/meshlink/meshlink/deployments","created_at":"2015-07-27T19:11:57Z","updated_at":"2016-02-17T18:30:10Z","pushed_at":"2016-09-15T16:15:50Z","git_url":"git://github.com/meshlink/meshlink.git","ssh_url":"git@github.com:meshlink/meshlink.git","clone_url":"https://github.com/meshlink/meshlink.git","svn_url":"https://github.com/meshlink/meshlink","homepage":null,"size":3707,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":1,"default_branch":"everbase"}},"_links":{"self":{"href":"https://api.github.com/repos/meshlink/meshlink/pulls/43"},"html":{"href":"https://github.com/meshlink/meshlink/pull/43"},"issue":{"href":"https://api.github.com/repos/meshlink/meshlink/issues/43"},"comments":{"href":"https://api.github.com/repos/meshlink/meshlink/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/meshlink/meshlink/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/meshlink/meshlink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meshlink/meshlink/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/meshlink/meshlink/statuses/e96891bc25333a3cc07f50a7a14a88e5a739d682"}}}}
{"actor":{"display_login":"a-krebs"}}