{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/89576075","pull_request_review_id":10121058,"id":89576075,"diff_hunk":"@@ -0,0 +1,84 @@\n+class Clickhouse < Formula\n+  desc \"is an open-source column-oriented database management system.\"\n+  homepage \"https://clickhouse.yandex/\"\n+  url \"https://github.com/yandex/ClickHouse/archive/v1.1.54074-stable.tar.gz\"\n+  version \"1.1.54074\"\n+  sha256 \"5e1d0b825828381c5c081d2af3da73eb35ea2a986b4df606b0990e57e96ddc28\"\n+  head \"https://github.com/yandex/ClickHouse.git\"\n+\n+  devel do\n+    url \"https://github.com/yandex/ClickHouse/archive/v1.1.54078-testing.tar.gz\"\n+    version \"1.1.54078\"\n+    sha256 \"3fdb1b7b2e5b51700777d116fad753e3f3371b981e2d35c9cea5c39845b40ad1\"\n+  end\n+\n+  depends_on \"cmake\" => :build\n+  depends_on \"gcc\" => :build\n+\n+  # We have to force some env vars here to force boost to be built from source\n+  ENV[\"HOMEBREW_CC\"] = \"gcc-6\"\n+  ENV[\"HOMEBREW_LD\"] = \"gcc-6\"\n+  ENV[\"HOMEBREW_CXX\"] = \"g++-6\"\n+  ENV[\"HOMEBREW_BUILD_FROM_SOURCE\"] = \"1\"\n+\n+  depends_on \"boost\" => :build\n+\n+  ENV[\"HOMEBREW_BUILD_FROM_SOURCE\"] = \"0\"\n+\n+  depends_on \"icu4c\" => :build\n+  depends_on \"mysql\" => :build\n+  depends_on \"openssl\" => :build\n+  depends_on \"unixodbc\" => :build\n+  depends_on \"glib\" => :build\n+  depends_on \"libtool\" => :build\n+  depends_on \"gettext\" => :build\n+  depends_on \"readline\" => :recommended\n+\n+  def install\n+    ENV[\"DISABLE_MONGODB\"] = \"1\"\n+\n+    # Hardcode the version assignment since there's no git repository\n+    inreplace \"libs/libcommon/src/get_revision_lib.sh\", /git.*\\n.*/, \"echo \" + version.to_s[-5..-1]","path":"Formula/clickhouse.rb","position":41,"original_position":41,"commit_id":"e989f860663c59955b3463905943050e0be24edf","original_commit_id":"e989f860663c59955b3463905943050e0be24edf","user":{"login":"MikeMcQuaid","id":125011,"avatar_url":"https://avatars.githubusercontent.com/u/125011?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeMcQuaid","html_url":"https://github.com/MikeMcQuaid","followers_url":"https://api.github.com/users/MikeMcQuaid/followers","following_url":"https://api.github.com/users/MikeMcQuaid/following{/other_user}","gists_url":"https://api.github.com/users/MikeMcQuaid/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeMcQuaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeMcQuaid/subscriptions","organizations_url":"https://api.github.com/users/MikeMcQuaid/orgs","repos_url":"https://api.github.com/users/MikeMcQuaid/repos","events_url":"https://api.github.com/users/MikeMcQuaid/events{/privacy}","received_events_url":"https://api.github.com/users/MikeMcQuaid/received_events","type":"User","site_admin":true},"body":"Use a Git checkout instead of patching.","created_at":"2016-11-25T08:04:13Z","updated_at":"2016-11-25T08:06:05Z","html_url":"https://github.com/Homebrew/homebrew-core/pull/7222#discussion_r89576075","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/7222","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/89576075"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/7222#discussion_r89576075"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/7222"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/7222","id":95257533,"html_url":"https://github.com/Homebrew/homebrew-core/pull/7222","diff_url":"https://github.com/Homebrew/homebrew-core/pull/7222.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/7222.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/7222","number":7222,"state":"open","locked":false,"title":"clickhouse 1.1.54074 (new formula)","user":{"login":"hatarist","id":2741725,"avatar_url":"https://avatars.githubusercontent.com/u/2741725?v=3","gravatar_id":"","url":"https://api.github.com/users/hatarist","html_url":"https://github.com/hatarist","followers_url":"https://api.github.com/users/hatarist/followers","following_url":"https://api.github.com/users/hatarist/following{/other_user}","gists_url":"https://api.github.com/users/hatarist/gists{/gist_id}","starred_url":"https://api.github.com/users/hatarist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatarist/subscriptions","organizations_url":"https://api.github.com/users/hatarist/orgs","repos_url":"https://api.github.com/users/hatarist/repos","events_url":"https://api.github.com/users/hatarist/events{/privacy}","received_events_url":"https://api.github.com/users/hatarist/received_events","type":"User","site_admin":false},"body":"- [v] Have you followed the [guidelines for contributing](https://github.com/Homebrew/homebrew-core/blob/master/CONTRIBUTING.md)?\r\n- [v] Have you checked that there aren't other open [pull requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [v] Have you built your formula locally with `brew install --build-from-source <formula>`, where `<formula>` is the name of the formula you're submitting?\r\n- [v] Does your build pass `brew audit --strict <formula>` (after doing `brew install <formula>`)?\r\n\r\n-----\r\n\r\nHere's an OS X build guide: https://github.com/yandex/ClickHouse/blob/master/doc/build_osx.md\r\nIn short, we have to recompile boost using gcc-6, hence the `HOMEBREW_CC`/`HOMEBREW_BUILD_FROM_SOURCE` overriding before `depends_on \"boost\"`.\r\n","created_at":"2016-11-25T06:54:19Z","updated_at":"2016-11-25T08:06:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7922b31a5556499188cfa21da1ed458029d47da","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/7222/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/7222/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/7222/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/e989f860663c59955b3463905943050e0be24edf","head":{"label":"hatarist:clickhouse","ref":"clickhouse","sha":"e989f860663c59955b3463905943050e0be24edf","user":{"login":"hatarist","id":2741725,"avatar_url":"https://avatars.githubusercontent.com/u/2741725?v=3","gravatar_id":"","url":"https://api.github.com/users/hatarist","html_url":"https://github.com/hatarist","followers_url":"https://api.github.com/users/hatarist/followers","following_url":"https://api.github.com/users/hatarist/following{/other_user}","gists_url":"https://api.github.com/users/hatarist/gists{/gist_id}","starred_url":"https://api.github.com/users/hatarist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatarist/subscriptions","organizations_url":"https://api.github.com/users/hatarist/orgs","repos_url":"https://api.github.com/users/hatarist/repos","events_url":"https://api.github.com/users/hatarist/events{/privacy}","received_events_url":"https://api.github.com/users/hatarist/received_events","type":"User","site_admin":false},"repo":{"id":74725954,"name":"homebrew-core","full_name":"hatarist/homebrew-core","owner":{"login":"hatarist","id":2741725,"avatar_url":"https://avatars.githubusercontent.com/u/2741725?v=3","gravatar_id":"","url":"https://api.github.com/users/hatarist","html_url":"https://github.com/hatarist","followers_url":"https://api.github.com/users/hatarist/followers","following_url":"https://api.github.com/users/hatarist/following{/other_user}","gists_url":"https://api.github.com/users/hatarist/gists{/gist_id}","starred_url":"https://api.github.com/users/hatarist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatarist/subscriptions","organizations_url":"https://api.github.com/users/hatarist/orgs","repos_url":"https://api.github.com/users/hatarist/repos","events_url":"https://api.github.com/users/hatarist/events{/privacy}","received_events_url":"https://api.github.com/users/hatarist/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hatarist/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":true,"url":"https://api.github.com/repos/hatarist/homebrew-core","forks_url":"https://api.github.com/repos/hatarist/homebrew-core/forks","keys_url":"https://api.github.com/repos/hatarist/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hatarist/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hatarist/homebrew-core/teams","hooks_url":"https://api.github.com/repos/hatarist/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/hatarist/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/hatarist/homebrew-core/events","assignees_url":"https://api.github.com/repos/hatarist/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/hatarist/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/hatarist/homebrew-core/tags","blobs_url":"https://api.github.com/repos/hatarist/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hatarist/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hatarist/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/hatarist/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hatarist/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/hatarist/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/hatarist/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/hatarist/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/hatarist/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/hatarist/homebrew-core/subscription","commits_url":"https://api.github.com/repos/hatarist/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/hatarist/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/hatarist/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/hatarist/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/hatarist/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/hatarist/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hatarist/homebrew-core/merges","archive_url":"https://api.github.com/repos/hatarist/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hatarist/homebrew-core/downloads","issues_url":"https://api.github.com/repos/hatarist/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/hatarist/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/hatarist/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/hatarist/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hatarist/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/hatarist/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/hatarist/homebrew-core/deployments","created_at":"2016-11-25T04:38:06Z","updated_at":"2016-11-25T04:38:24Z","pushed_at":"2016-11-25T06:53:16Z","git_url":"git://github.com/hatarist/homebrew-core.git","ssh_url":"git@github.com:hatarist/homebrew-core.git","clone_url":"https://github.com/hatarist/homebrew-core.git","svn_url":"https://github.com/hatarist/homebrew-core","homepage":"http://brew.sh","size":97386,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"fa0bfe1444e54f07f0632e4fcc2d457cc004e8da","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":52855516,"name":"homebrew-core","full_name":"Homebrew/homebrew-core","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-core","forks_url":"https://api.github.com/repos/Homebrew/homebrew-core/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-core/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-core/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-core/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-core/deployments","created_at":"2016-03-01T06:58:36Z","updated_at":"2016-11-24T22:21:20Z","pushed_at":"2016-11-25T07:01:15Z","git_url":"git://github.com/Homebrew/homebrew-core.git","ssh_url":"git@github.com:Homebrew/homebrew-core.git","clone_url":"https://github.com/Homebrew/homebrew-core.git","svn_url":"https://github.com/Homebrew/homebrew-core","homepage":"http://brew.sh","size":174533,"stargazers_count":1052,"watchers_count":1052,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1790,"mirror_url":null,"open_issues_count":140,"forks":1790,"open_issues":140,"watchers":1052,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/7222"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/7222"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/7222"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/7222/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/7222/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/7222/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/e989f860663c59955b3463905943050e0be24edf"}}}}
{"actor":{"display_login":"MikeMcQuaid"}}