{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/javascript/pulls/comments/59271502","id":59271502,"diff_hunk":"@@ -0,0 +1,84 @@\n+// see https://github.com/wix/eslint-plugin-lodash\n+\n+module.exports = {\n+  // Possible errors\n+\n+  // Use or avoid thisArg for Lodash method callbacks, depending on major version.\n+  'callback-binding': 'warn',\n+  // Use value returned from collection methods properly.\n+  'collection-method-value': 'warn',\n+  // Always return a value in iteratees of Lodash collection methods that aren't forEach.\n+  'collection-return': 'error',\n+  // Do not use .value() on chains that have already ended (e.g. with max() or reduce()) (fixable)\n+  'no-double-unwrap': 'error',\n+  // Do not use superfluous arguments on Lodash methods with a specified arity.\n+  'no-extra-args': 'error',\n+  // Prevent chaining without evaluation via value() or non-chainable methods like max().\n+  'unwrap': 'error',","path":"packages/eslint-plugin-shopify/lib/config/rules/lodash.js","position":17,"original_position":17,"commit_id":"f8a9ff351532da41e7ec3a85cb4df45bf11dee95","original_commit_id":"f8a9ff351532da41e7ec3a85cb4df45bf11dee95","user":{"login":"lemonmade","id":3012583,"avatar_url":"https://avatars.githubusercontent.com/u/3012583?v=3","gravatar_id":"","url":"https://api.github.com/users/lemonmade","html_url":"https://github.com/lemonmade","followers_url":"https://api.github.com/users/lemonmade/followers","following_url":"https://api.github.com/users/lemonmade/following{/other_user}","gists_url":"https://api.github.com/users/lemonmade/gists{/gist_id}","starred_url":"https://api.github.com/users/lemonmade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemonmade/subscriptions","organizations_url":"https://api.github.com/users/lemonmade/orgs","repos_url":"https://api.github.com/users/lemonmade/repos","events_url":"https://api.github.com/users/lemonmade/events{/privacy}","received_events_url":"https://api.github.com/users/lemonmade/received_events","type":"User","site_admin":false},"body":"I haven't seen places we do too much of this, do you know if we do?","created_at":"2016-04-11T20:05:32Z","updated_at":"2016-04-11T20:05:32Z","html_url":"https://github.com/Shopify/javascript/pull/33#discussion_r59271502","pull_request_url":"https://api.github.com/repos/Shopify/javascript/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/Shopify/javascript/pulls/comments/59271502"},"html":{"href":"https://github.com/Shopify/javascript/pull/33#discussion_r59271502"},"pull_request":{"href":"https://api.github.com/repos/Shopify/javascript/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/javascript/pulls/33","id":66048881,"html_url":"https://github.com/Shopify/javascript/pull/33","diff_url":"https://github.com/Shopify/javascript/pull/33.diff","patch_url":"https://github.com/Shopify/javascript/pull/33.patch","issue_url":"https://api.github.com/repos/Shopify/javascript/issues/33","number":33,"state":"open","locked":false,"title":"Adds lodash plugin","user":{"login":"lemonmade","id":3012583,"avatar_url":"https://avatars.githubusercontent.com/u/3012583?v=3","gravatar_id":"","url":"https://api.github.com/users/lemonmade","html_url":"https://github.com/lemonmade","followers_url":"https://api.github.com/users/lemonmade/followers","following_url":"https://api.github.com/users/lemonmade/following{/other_user}","gists_url":"https://api.github.com/users/lemonmade/gists{/gist_id}","starred_url":"https://api.github.com/users/lemonmade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemonmade/subscriptions","organizations_url":"https://api.github.com/users/lemonmade/orgs","repos_url":"https://api.github.com/users/lemonmade/repos","events_url":"https://api.github.com/users/lemonmade/events{/privacy}","received_events_url":"https://api.github.com/users/lemonmade/received_events","type":"User","site_admin":false},"body":"This PR fixes #11 by adding `eslint-plugin-lodash` for lodash-specific linting rules. I've used lodash a fair bit but I would definitely love feedback on this one — I feel like this might be something that different projects do differently, and my opinions might not match those of the team on some of these things. You can see all the rules here: https://github.com/wix/eslint-plugin-lodash, though I've included the \"summary\" description of each rule above the rule itself.\r\n\r\ncc/ @Shopify/fed @DrewMartin @owilliams ","created_at":"2016-04-11T19:31:32Z","updated_at":"2016-04-11T20:05:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3710a08e1ae1088b48c956ab2cf7bc7c6050f78","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/javascript/pulls/33/commits","review_comments_url":"https://api.github.com/repos/Shopify/javascript/pulls/33/comments","review_comment_url":"https://api.github.com/repos/Shopify/javascript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/javascript/issues/33/comments","statuses_url":"https://api.github.com/repos/Shopify/javascript/statuses/f8a9ff351532da41e7ec3a85cb4df45bf11dee95","head":{"label":"Shopify:add-lodash-plugin","ref":"add-lodash-plugin","sha":"f8a9ff351532da41e7ec3a85cb4df45bf11dee95","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":49887169,"name":"javascript","full_name":"Shopify/javascript","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/javascript","description":"The home for all things JavaScript at Shopify.","fork":false,"url":"https://api.github.com/repos/Shopify/javascript","forks_url":"https://api.github.com/repos/Shopify/javascript/forks","keys_url":"https://api.github.com/repos/Shopify/javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/javascript/teams","hooks_url":"https://api.github.com/repos/Shopify/javascript/hooks","issue_events_url":"https://api.github.com/repos/Shopify/javascript/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/javascript/events","assignees_url":"https://api.github.com/repos/Shopify/javascript/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/javascript/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/javascript/tags","blobs_url":"https://api.github.com/repos/Shopify/javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/javascript/languages","stargazers_url":"https://api.github.com/repos/Shopify/javascript/stargazers","contributors_url":"https://api.github.com/repos/Shopify/javascript/contributors","subscribers_url":"https://api.github.com/repos/Shopify/javascript/subscribers","subscription_url":"https://api.github.com/repos/Shopify/javascript/subscription","commits_url":"https://api.github.com/repos/Shopify/javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/javascript/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/javascript/merges","archive_url":"https://api.github.com/repos/Shopify/javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/javascript/downloads","issues_url":"https://api.github.com/repos/Shopify/javascript/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/javascript/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/javascript/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/javascript/deployments","created_at":"2016-01-18T15:54:37Z","updated_at":"2016-04-10T08:21:15Z","pushed_at":"2016-04-11T19:31:33Z","git_url":"git://github.com/Shopify/javascript.git","ssh_url":"git@github.com:Shopify/javascript.git","clone_url":"https://github.com/Shopify/javascript.git","svn_url":"https://github.com/Shopify/javascript","homepage":null,"size":227,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":15,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"2f56b4fff9c119494bded8751a11b7de1b53dea6","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":49887169,"name":"javascript","full_name":"Shopify/javascript","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/javascript","description":"The home for all things JavaScript at Shopify.","fork":false,"url":"https://api.github.com/repos/Shopify/javascript","forks_url":"https://api.github.com/repos/Shopify/javascript/forks","keys_url":"https://api.github.com/repos/Shopify/javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/javascript/teams","hooks_url":"https://api.github.com/repos/Shopify/javascript/hooks","issue_events_url":"https://api.github.com/repos/Shopify/javascript/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/javascript/events","assignees_url":"https://api.github.com/repos/Shopify/javascript/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/javascript/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/javascript/tags","blobs_url":"https://api.github.com/repos/Shopify/javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/javascript/languages","stargazers_url":"https://api.github.com/repos/Shopify/javascript/stargazers","contributors_url":"https://api.github.com/repos/Shopify/javascript/contributors","subscribers_url":"https://api.github.com/repos/Shopify/javascript/subscribers","subscription_url":"https://api.github.com/repos/Shopify/javascript/subscription","commits_url":"https://api.github.com/repos/Shopify/javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/javascript/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/javascript/merges","archive_url":"https://api.github.com/repos/Shopify/javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/javascript/downloads","issues_url":"https://api.github.com/repos/Shopify/javascript/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/javascript/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/javascript/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/javascript/deployments","created_at":"2016-01-18T15:54:37Z","updated_at":"2016-04-10T08:21:15Z","pushed_at":"2016-04-11T19:31:33Z","git_url":"git://github.com/Shopify/javascript.git","ssh_url":"git@github.com:Shopify/javascript.git","clone_url":"https://github.com/Shopify/javascript.git","svn_url":"https://github.com/Shopify/javascript","homepage":null,"size":227,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/javascript/pulls/33"},"html":{"href":"https://github.com/Shopify/javascript/pull/33"},"issue":{"href":"https://api.github.com/repos/Shopify/javascript/issues/33"},"comments":{"href":"https://api.github.com/repos/Shopify/javascript/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/javascript/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/javascript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/javascript/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/javascript/statuses/f8a9ff351532da41e7ec3a85cb4df45bf11dee95"}}}}