{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/50398180","id":50398180,"diff_hunk":"@@ -74,22 +74,22 @@\n  * we don't leak {@link com.hazelcast.spi.impl.operationservice.impl.OperationServiceImpl} to the outside.\n  */\n public class NodeEngineImpl implements NodeEngine {\n+    protected final ILogger logger;\n+    protected final EventServiceImpl eventService;\n+    protected final OperationServiceImpl operationService;\n+    protected final ServiceManagerImpl serviceManager;\n+    protected final WanReplicationService wanReplicationService;","path":"hazelcast/src/main/java/com/hazelcast/spi/impl/NodeEngineImpl.java","position":8,"original_position":8,"commit_id":"62241486797c6fa40f1cb70f4bef42748364bd79","original_commit_id":"62241486797c6fa40f1cb70f4bef42748364bd79","user":{"login":"eminn","id":378108,"avatar_url":"https://avatars.githubusercontent.com/u/378108?v=3","gravatar_id":"","url":"https://api.github.com/users/eminn","html_url":"https://github.com/eminn","followers_url":"https://api.github.com/users/eminn/followers","following_url":"https://api.github.com/users/eminn/following{/other_user}","gists_url":"https://api.github.com/users/eminn/gists{/gist_id}","starred_url":"https://api.github.com/users/eminn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eminn/subscriptions","organizations_url":"https://api.github.com/users/eminn/orgs","repos_url":"https://api.github.com/users/eminn/repos","events_url":"https://api.github.com/users/eminn/events{/privacy}","received_events_url":"https://api.github.com/users/eminn/received_events","type":"User","site_admin":false},"body":"Do we really need to make these fields protected ? ","created_at":"2016-01-21T13:11:44Z","updated_at":"2016-01-21T13:11:44Z","html_url":"https://github.com/hazelcast/hazelcast/pull/7077#discussion_r50398180","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7077","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/50398180"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/7077#discussion_r50398180"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7077"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7077","id":53722387,"html_url":"https://github.com/hazelcast/hazelcast/pull/7077","diff_url":"https://github.com/hazelcast/hazelcast/pull/7077.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/7077.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/7077","number":7077,"state":"open","locked":false,"title":"Changes required for integration with Hazelcast Jet","user":{"login":"toktarev","id":4003874,"avatar_url":"https://avatars.githubusercontent.com/u/4003874?v=3","gravatar_id":"","url":"https://api.github.com/users/toktarev","html_url":"https://github.com/toktarev","followers_url":"https://api.github.com/users/toktarev/followers","following_url":"https://api.github.com/users/toktarev/following{/other_user}","gists_url":"https://api.github.com/users/toktarev/gists{/gist_id}","starred_url":"https://api.github.com/users/toktarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toktarev/subscriptions","organizations_url":"https://api.github.com/users/toktarev/orgs","repos_url":"https://api.github.com/users/toktarev/repos","events_url":"https://api.github.com/users/toktarev/events{/privacy}","received_events_url":"https://api.github.com/users/toktarev/received_events","type":"User","site_admin":false},"body":"Changes\r\nHazelcast Server\r\n\r\n1) Introduced interface CustomServiceConfig.\r\n   It let us to add custom configs for each external service.\r\n2) HazelcastInstanceFactory has been customized. It let  us to create custom instances of HazelcastInstanceFactory adding them to META-INF/services\r\nBy default DefaultHazelcastInstanceFactory will be used.\r\n\r\n3) HazelcastInstanceImpl and have been extended.\r\nNow it is possible to inherit from these classes.\r\n\r\n\r\nHazelcast Client\r\n\r\n1) Introduced interface HazelcastClientFactory to create custom instances of HazelcastClientInstanceImpl\r\n\r\n2) CodeGeneratorMessageTaskFactory has been customized\r\nAdded opportunity to generate Tasks from Jet component: JetMessageTaskFactoryImpl.\r\n\r\n3) TemplateConstants - added JET_TEMPLATE_ID = 26.\r\n\r\n4) Opportunity to work with many MessageTaskFactory instances\r\nIntroduced method createMessageTaskFactories in NodeExtension.\r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2015-12-15T15:59:30Z","updated_at":"2016-01-21T13:11:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6b0a704138257711881fea5e7dc2ac9ef25c105","assignee":null,"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/70","html_url":"https://github.com/hazelcast/hazelcast/milestones/3.7","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/70/labels","id":1346433,"number":70,"title":"3.7","description":"","creator":{"login":"pveentjer","id":105243,"avatar_url":"https://avatars.githubusercontent.com/u/105243?v=3","gravatar_id":"","url":"https://api.github.com/users/pveentjer","html_url":"https://github.com/pveentjer","followers_url":"https://api.github.com/users/pveentjer/followers","following_url":"https://api.github.com/users/pveentjer/following{/other_user}","gists_url":"https://api.github.com/users/pveentjer/gists{/gist_id}","starred_url":"https://api.github.com/users/pveentjer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pveentjer/subscriptions","organizations_url":"https://api.github.com/users/pveentjer/orgs","repos_url":"https://api.github.com/users/pveentjer/repos","events_url":"https://api.github.com/users/pveentjer/events{/privacy}","received_events_url":"https://api.github.com/users/pveentjer/received_events","type":"User","site_admin":false},"open_issues":153,"closed_issues":12,"state":"open","created_at":"2015-10-09T12:16:13Z","updated_at":"2016-01-21T12:48:50Z","due_on":"2016-02-29T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7077/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7077/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/7077/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/62241486797c6fa40f1cb70f4bef42748364bd79","head":{"label":"toktarev:master","ref":"master","sha":"62241486797c6fa40f1cb70f4bef42748364bd79","user":{"login":"toktarev","id":4003874,"avatar_url":"https://avatars.githubusercontent.com/u/4003874?v=3","gravatar_id":"","url":"https://api.github.com/users/toktarev","html_url":"https://github.com/toktarev","followers_url":"https://api.github.com/users/toktarev/followers","following_url":"https://api.github.com/users/toktarev/following{/other_user}","gists_url":"https://api.github.com/users/toktarev/gists{/gist_id}","starred_url":"https://api.github.com/users/toktarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toktarev/subscriptions","organizations_url":"https://api.github.com/users/toktarev/orgs","repos_url":"https://api.github.com/users/toktarev/repos","events_url":"https://api.github.com/users/toktarev/events{/privacy}","received_events_url":"https://api.github.com/users/toktarev/received_events","type":"User","site_admin":false},"repo":{"id":48052188,"name":"hazelcast","full_name":"toktarev/hazelcast","owner":{"login":"toktarev","id":4003874,"avatar_url":"https://avatars.githubusercontent.com/u/4003874?v=3","gravatar_id":"","url":"https://api.github.com/users/toktarev","html_url":"https://github.com/toktarev","followers_url":"https://api.github.com/users/toktarev/followers","following_url":"https://api.github.com/users/toktarev/following{/other_user}","gists_url":"https://api.github.com/users/toktarev/gists{/gist_id}","starred_url":"https://api.github.com/users/toktarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toktarev/subscriptions","organizations_url":"https://api.github.com/users/toktarev/orgs","repos_url":"https://api.github.com/users/toktarev/repos","events_url":"https://api.github.com/users/toktarev/events{/privacy}","received_events_url":"https://api.github.com/users/toktarev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toktarev/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/toktarev/hazelcast","forks_url":"https://api.github.com/repos/toktarev/hazelcast/forks","keys_url":"https://api.github.com/repos/toktarev/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toktarev/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toktarev/hazelcast/teams","hooks_url":"https://api.github.com/repos/toktarev/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/toktarev/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/toktarev/hazelcast/events","assignees_url":"https://api.github.com/repos/toktarev/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/toktarev/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/toktarev/hazelcast/tags","blobs_url":"https://api.github.com/repos/toktarev/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toktarev/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toktarev/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/toktarev/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toktarev/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/toktarev/hazelcast/languages","stargazers_url":"https://api.github.com/repos/toktarev/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/toktarev/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/toktarev/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/toktarev/hazelcast/subscription","commits_url":"https://api.github.com/repos/toktarev/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/toktarev/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/toktarev/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/toktarev/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/toktarev/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/toktarev/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toktarev/hazelcast/merges","archive_url":"https://api.github.com/repos/toktarev/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toktarev/hazelcast/downloads","issues_url":"https://api.github.com/repos/toktarev/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/toktarev/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/toktarev/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/toktarev/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toktarev/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/toktarev/hazelcast/releases{/id}","created_at":"2015-12-15T15:37:57Z","updated_at":"2016-01-20T13:56:52Z","pushed_at":"2016-01-21T10:34:09Z","git_url":"git://github.com/toktarev/hazelcast.git","ssh_url":"git@github.com:toktarev/hazelcast.git","clone_url":"https://github.com/toktarev/hazelcast.git","svn_url":"https://github.com/toktarev/hazelcast","homepage":"www.hazelcast.com","size":84255,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"42865bc35a873d4ebed9340e68c8cdde486f5017","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","created_at":"2012-03-21T12:25:18Z","updated_at":"2016-01-21T01:03:31Z","pushed_at":"2016-01-21T12:48:50Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":96324,"stargazers_count":1382,"watchers_count":1382,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":682,"mirror_url":null,"open_issues_count":526,"forks":682,"open_issues":526,"watchers":1382,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7077"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/7077"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/7077"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/7077/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7077/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7077/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/62241486797c6fa40f1cb70f4bef42748364bd79"}}}}