{"action":"created","comment":{"url":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/comments/89085193","pull_request_review_id":9634391,"id":89085193,"diff_hunk":"@@ -679,9 +728,22 @@ Public Class ucrGeom\n         clsgeom_point.AddAesParameter(\"fill\", strIncludedDataTypes:={\"factor\", \"numeric\"})\r\n         clsgeom_point.AddAesParameter(\"shape\", strIncludedDataTypes:={\"factor\"})\r\n         clsgeom_point.AddAesParameter(\"size\", strIncludedDataTypes:={\"factor\", \"numeric\"})\r\n-        clsgeom_point.AddAesParameter(\"stroke\")\r\n-        'adding layer parameters\r\n-        clsgeom_point.AddLayerParameter(\"position\", \"list\", Chr(34) & \"identity\" & Chr(34), lstParameterStrings:={Chr(34) & \"identity\" & Chr(34), Chr(34) & \"jitter\" & Chr(34)})\r\n+        clsgeom_point.AddAesParameter(\"stroke\", strIncludedDataTypes:={\"factor\", \"numeric\"})\r\n+        'Adding layer parameters\r\n+        'Geom_poitn Parameters\r\n+\r\n+        'Global Layer parameters\r\n+        clsgeom_point.AddLayerParameter(\"position\", \"list\", Chr(34) & \"identity\" & Chr(34), lstParameterStrings:={Chr(34) & \"stack\" & Chr(34), Chr(34) & \"dodge\" & Chr(34), Chr(34) & \"identity\" & Chr(34), Chr(34) & \"jitter\" & Chr(34), Chr(34) & \"fill\" & Chr(34)})\r\n+        clsgeom_point.AddLayerParameter(\"stat\", \"list\", Chr(34) & \"identity\" & Chr(34), lstParameterStrings:={Chr(34) & \"identity\" & Chr(34), Chr(34) & \"count\" & Chr(34), Chr(34) & \"ecdf\" & Chr(34), Chr(34) & \"sum\" & Chr(34), Chr(34) & \"summary\" & Chr(34), Chr(34) & \"unique\" & Chr(34)}) 'Warning, stat count cannot be used with y aesthetic !!!\r\n+        clsgeom_point.AddLayerParameter(\"show.legend\", \"list\", \"NA\", lstParameterStrings:={\"NA\", \"TRUE\", \"FALSE\"})\r","path":"instat/ucrGeom.vb","position":194,"original_position":194,"commit_id":"b0f9d6c00c776c479cbf0973a3cb3475bd059484","original_commit_id":"b0f9d6c00c776c479cbf0973a3cb3475bd059484","user":{"login":"dannyparsons","id":11214914,"avatar_url":"https://avatars.githubusercontent.com/u/11214914?v=3","gravatar_id":"","url":"https://api.github.com/users/dannyparsons","html_url":"https://github.com/dannyparsons","followers_url":"https://api.github.com/users/dannyparsons/followers","following_url":"https://api.github.com/users/dannyparsons/following{/other_user}","gists_url":"https://api.github.com/users/dannyparsons/gists{/gist_id}","starred_url":"https://api.github.com/users/dannyparsons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannyparsons/subscriptions","organizations_url":"https://api.github.com/users/dannyparsons/orgs","repos_url":"https://api.github.com/users/dannyparsons/repos","events_url":"https://api.github.com/users/dannyparsons/events{/privacy}","received_events_url":"https://api.github.com/users/dannyparsons/received_events","type":"User","site_admin":false},"body":"Of course NA is also a sensible default, because it's the R default, so not saying TRUE must be the default, but there is a case that TRUE is also a sensible choice.","created_at":"2016-11-22T10:33:03Z","updated_at":"2016-11-22T10:33:03Z","html_url":"https://github.com/africanmathsinitiative/Instat/pull/2286#discussion_r89085193","pull_request_url":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/2286","_links":{"self":{"href":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/comments/89085193"},"html":{"href":"https://github.com/africanmathsinitiative/Instat/pull/2286#discussion_r89085193"},"pull_request":{"href":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/2286"}}},"pull_request":{"url":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/2286","id":93969197,"html_url":"https://github.com/africanmathsinitiative/Instat/pull/2286","diff_url":"https://github.com/africanmathsinitiative/Instat/pull/2286.diff","patch_url":"https://github.com/africanmathsinitiative/Instat/pull/2286.patch","issue_url":"https://api.github.com/repos/africanmathsinitiative/Instat/issues/2286","number":2286,"state":"closed","locked":false,"title":"Ucr geom","user":{"login":"FrancoisJRenaud","id":22272110,"avatar_url":"https://avatars.githubusercontent.com/u/22272110?v=3","gravatar_id":"","url":"https://api.github.com/users/FrancoisJRenaud","html_url":"https://github.com/FrancoisJRenaud","followers_url":"https://api.github.com/users/FrancoisJRenaud/followers","following_url":"https://api.github.com/users/FrancoisJRenaud/following{/other_user}","gists_url":"https://api.github.com/users/FrancoisJRenaud/gists{/gist_id}","starred_url":"https://api.github.com/users/FrancoisJRenaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrancoisJRenaud/subscriptions","organizations_url":"https://api.github.com/users/FrancoisJRenaud/orgs","repos_url":"https://api.github.com/users/FrancoisJRenaud/repos","events_url":"https://api.github.com/users/FrancoisJRenaud/events{/privacy}","received_events_url":"https://api.github.com/users/FrancoisJRenaud/received_events","type":"User","site_admin":false},"body":"geom editing. In progress","created_at":"2016-11-16T13:51:28Z","updated_at":"2016-11-22T10:33:03Z","closed_at":"2016-11-22T08:48:12Z","merged_at":"2016-11-22T08:48:12Z","merge_commit_sha":"2af5a9f328c00ee3d6b195f9be5024ed58e9d1b8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/2286/commits","review_comments_url":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/2286/comments","review_comment_url":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/africanmathsinitiative/Instat/issues/2286/comments","statuses_url":"https://api.github.com/repos/africanmathsinitiative/Instat/statuses/b0f9d6c00c776c479cbf0973a3cb3475bd059484","head":{"label":"FrancoisJRenaud:ucrGeom","ref":"ucrGeom","sha":"b0f9d6c00c776c479cbf0973a3cb3475bd059484","user":{"login":"FrancoisJRenaud","id":22272110,"avatar_url":"https://avatars.githubusercontent.com/u/22272110?v=3","gravatar_id":"","url":"https://api.github.com/users/FrancoisJRenaud","html_url":"https://github.com/FrancoisJRenaud","followers_url":"https://api.github.com/users/FrancoisJRenaud/followers","following_url":"https://api.github.com/users/FrancoisJRenaud/following{/other_user}","gists_url":"https://api.github.com/users/FrancoisJRenaud/gists{/gist_id}","starred_url":"https://api.github.com/users/FrancoisJRenaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrancoisJRenaud/subscriptions","organizations_url":"https://api.github.com/users/FrancoisJRenaud/orgs","repos_url":"https://api.github.com/users/FrancoisJRenaud/repos","events_url":"https://api.github.com/users/FrancoisJRenaud/events{/privacy}","received_events_url":"https://api.github.com/users/FrancoisJRenaud/received_events","type":"User","site_admin":false},"repo":{"id":69454888,"name":"Instat","full_name":"FrancoisJRenaud/Instat","owner":{"login":"FrancoisJRenaud","id":22272110,"avatar_url":"https://avatars.githubusercontent.com/u/22272110?v=3","gravatar_id":"","url":"https://api.github.com/users/FrancoisJRenaud","html_url":"https://github.com/FrancoisJRenaud","followers_url":"https://api.github.com/users/FrancoisJRenaud/followers","following_url":"https://api.github.com/users/FrancoisJRenaud/following{/other_user}","gists_url":"https://api.github.com/users/FrancoisJRenaud/gists{/gist_id}","starred_url":"https://api.github.com/users/FrancoisJRenaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrancoisJRenaud/subscriptions","organizations_url":"https://api.github.com/users/FrancoisJRenaud/orgs","repos_url":"https://api.github.com/users/FrancoisJRenaud/repos","events_url":"https://api.github.com/users/FrancoisJRenaud/events{/privacy}","received_events_url":"https://api.github.com/users/FrancoisJRenaud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FrancoisJRenaud/Instat","description":"Development of the new version of Instat","fork":true,"url":"https://api.github.com/repos/FrancoisJRenaud/Instat","forks_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/forks","keys_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/teams","hooks_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/hooks","issue_events_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/issues/events{/number}","events_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/events","assignees_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/assignees{/user}","branches_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/branches{/branch}","tags_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/tags","blobs_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/git/refs{/sha}","trees_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/statuses/{sha}","languages_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/languages","stargazers_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/stargazers","contributors_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/contributors","subscribers_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/subscribers","subscription_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/subscription","commits_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/commits{/sha}","git_commits_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/git/commits{/sha}","comments_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/comments{/number}","issue_comment_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/issues/comments{/number}","contents_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/contents/{+path}","compare_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/merges","archive_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/downloads","issues_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/issues{/number}","pulls_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/pulls{/number}","milestones_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/milestones{/number}","notifications_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/labels{/name}","releases_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/releases{/id}","deployments_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/deployments","created_at":"2016-09-28T11:02:38Z","updated_at":"2016-09-28T11:02:42Z","pushed_at":"2016-11-22T09:48:31Z","git_url":"git://github.com/FrancoisJRenaud/Instat.git","ssh_url":"git@github.com:FrancoisJRenaud/Instat.git","clone_url":"https://github.com/FrancoisJRenaud/Instat.git","svn_url":"https://github.com/FrancoisJRenaud/Instat","homepage":null,"size":567592,"stargazers_count":0,"watchers_count":0,"language":"Visual Basic","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"africanmathsinitiative:master","ref":"master","sha":"efd3c7d0ca5abdf4ec10dbb4e0502895f4deb52c","user":{"login":"africanmathsinitiative","id":13917566,"avatar_url":"https://avatars.githubusercontent.com/u/13917566?v=3","gravatar_id":"","url":"https://api.github.com/users/africanmathsinitiative","html_url":"https://github.com/africanmathsinitiative","followers_url":"https://api.github.com/users/africanmathsinitiative/followers","following_url":"https://api.github.com/users/africanmathsinitiative/following{/other_user}","gists_url":"https://api.github.com/users/africanmathsinitiative/gists{/gist_id}","starred_url":"https://api.github.com/users/africanmathsinitiative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/africanmathsinitiative/subscriptions","organizations_url":"https://api.github.com/users/africanmathsinitiative/orgs","repos_url":"https://api.github.com/users/africanmathsinitiative/repos","events_url":"https://api.github.com/users/africanmathsinitiative/events{/privacy}","received_events_url":"https://api.github.com/users/africanmathsinitiative/received_events","type":"Organization","site_admin":false},"repo":{"id":44009238,"name":"Instat","full_name":"africanmathsinitiative/Instat","owner":{"login":"africanmathsinitiative","id":13917566,"avatar_url":"https://avatars.githubusercontent.com/u/13917566?v=3","gravatar_id":"","url":"https://api.github.com/users/africanmathsinitiative","html_url":"https://github.com/africanmathsinitiative","followers_url":"https://api.github.com/users/africanmathsinitiative/followers","following_url":"https://api.github.com/users/africanmathsinitiative/following{/other_user}","gists_url":"https://api.github.com/users/africanmathsinitiative/gists{/gist_id}","starred_url":"https://api.github.com/users/africanmathsinitiative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/africanmathsinitiative/subscriptions","organizations_url":"https://api.github.com/users/africanmathsinitiative/orgs","repos_url":"https://api.github.com/users/africanmathsinitiative/repos","events_url":"https://api.github.com/users/africanmathsinitiative/events{/privacy}","received_events_url":"https://api.github.com/users/africanmathsinitiative/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/africanmathsinitiative/Instat","description":"A statistics software package powered by R","fork":false,"url":"https://api.github.com/repos/africanmathsinitiative/Instat","forks_url":"https://api.github.com/repos/africanmathsinitiative/Instat/forks","keys_url":"https://api.github.com/repos/africanmathsinitiative/Instat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/africanmathsinitiative/Instat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/africanmathsinitiative/Instat/teams","hooks_url":"https://api.github.com/repos/africanmathsinitiative/Instat/hooks","issue_events_url":"https://api.github.com/repos/africanmathsinitiative/Instat/issues/events{/number}","events_url":"https://api.github.com/repos/africanmathsinitiative/Instat/events","assignees_url":"https://api.github.com/repos/africanmathsinitiative/Instat/assignees{/user}","branches_url":"https://api.github.com/repos/africanmathsinitiative/Instat/branches{/branch}","tags_url":"https://api.github.com/repos/africanmathsinitiative/Instat/tags","blobs_url":"https://api.github.com/repos/africanmathsinitiative/Instat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/africanmathsinitiative/Instat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/africanmathsinitiative/Instat/git/refs{/sha}","trees_url":"https://api.github.com/repos/africanmathsinitiative/Instat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/africanmathsinitiative/Instat/statuses/{sha}","languages_url":"https://api.github.com/repos/africanmathsinitiative/Instat/languages","stargazers_url":"https://api.github.com/repos/africanmathsinitiative/Instat/stargazers","contributors_url":"https://api.github.com/repos/africanmathsinitiative/Instat/contributors","subscribers_url":"https://api.github.com/repos/africanmathsinitiative/Instat/subscribers","subscription_url":"https://api.github.com/repos/africanmathsinitiative/Instat/subscription","commits_url":"https://api.github.com/repos/africanmathsinitiative/Instat/commits{/sha}","git_commits_url":"https://api.github.com/repos/africanmathsinitiative/Instat/git/commits{/sha}","comments_url":"https://api.github.com/repos/africanmathsinitiative/Instat/comments{/number}","issue_comment_url":"https://api.github.com/repos/africanmathsinitiative/Instat/issues/comments{/number}","contents_url":"https://api.github.com/repos/africanmathsinitiative/Instat/contents/{+path}","compare_url":"https://api.github.com/repos/africanmathsinitiative/Instat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/africanmathsinitiative/Instat/merges","archive_url":"https://api.github.com/repos/africanmathsinitiative/Instat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/africanmathsinitiative/Instat/downloads","issues_url":"https://api.github.com/repos/africanmathsinitiative/Instat/issues{/number}","pulls_url":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls{/number}","milestones_url":"https://api.github.com/repos/africanmathsinitiative/Instat/milestones{/number}","notifications_url":"https://api.github.com/repos/africanmathsinitiative/Instat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/africanmathsinitiative/Instat/labels{/name}","releases_url":"https://api.github.com/repos/africanmathsinitiative/Instat/releases{/id}","deployments_url":"https://api.github.com/repos/africanmathsinitiative/Instat/deployments","created_at":"2015-10-10T12:10:32Z","updated_at":"2016-11-07T13:22:48Z","pushed_at":"2016-11-22T09:59:10Z","git_url":"git://github.com/africanmathsinitiative/Instat.git","ssh_url":"git@github.com:africanmathsinitiative/Instat.git","clone_url":"https://github.com/africanmathsinitiative/Instat.git","svn_url":"https://github.com/africanmathsinitiative/Instat","homepage":"https://chuffed.org/project/africandatainitiative","size":570088,"stargazers_count":2,"watchers_count":2,"language":"Visual Basic","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":133,"forks":19,"open_issues":133,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/2286"},"html":{"href":"https://github.com/africanmathsinitiative/Instat/pull/2286"},"issue":{"href":"https://api.github.com/repos/africanmathsinitiative/Instat/issues/2286"},"comments":{"href":"https://api.github.com/repos/africanmathsinitiative/Instat/issues/2286/comments"},"review_comments":{"href":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/2286/comments"},"review_comment":{"href":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/2286/commits"},"statuses":{"href":"https://api.github.com/repos/africanmathsinitiative/Instat/statuses/b0f9d6c00c776c479cbf0973a3cb3475bd059484"}}}}
{"actor":{"display_login":"dannyparsons"}}