{"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/terraform/pulls/comments/80882766","pull_request_review_id":1903550,"id":80882766,"diff_hunk":"@@ -622,12 +623,19 @@ func flattenOptions(list []*rds.Option) []map[string]interface{} {\n \t\t\t\tr[\"db_security_group_memberships\"] = dbs\n \t\t\t}\n \t\t\tif i.OptionSettings != nil {\n+\t\t\t\tspew.Sdump(\"Options HERE %s\", i.OptionSettings)\n \t\t\t\tsettings := make([]map[string]interface{}, 0, len(i.OptionSettings))\n \t\t\t\tfor _, j := range i.OptionSettings {\n-\t\t\t\t\tsettings = append(settings, map[string]interface{}{\n-\t\t\t\t\t\t\"name\":  *j.Name,\n-\t\t\t\t\t\t\"value\": *j.Value,\n-\t\t\t\t\t})\n+\t\t\t\t\tspew.Sdump(\"Option HERE %s\", j)","path":"builtin/providers/aws/structure.go","position":null,"original_position":19,"commit_id":"df8ca94093cf3523559ee4d2f66288ddd377a6a9","original_commit_id":"4f6ae5d995fefb1fd6c71d2548da3d32251aa935","user":{"login":"stack72","id":227823,"avatar_url":"https://avatars.githubusercontent.com/u/227823?v=3","gravatar_id":"","url":"https://api.github.com/users/stack72","html_url":"https://github.com/stack72","followers_url":"https://api.github.com/users/stack72/followers","following_url":"https://api.github.com/users/stack72/following{/other_user}","gists_url":"https://api.github.com/users/stack72/gists{/gist_id}","starred_url":"https://api.github.com/users/stack72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stack72/subscriptions","organizations_url":"https://api.github.com/users/stack72/orgs","repos_url":"https://api.github.com/users/stack72/repos","events_url":"https://api.github.com/users/stack72/events{/privacy}","received_events_url":"https://api.github.com/users/stack72/received_events","type":"User","site_admin":false},"body":"And that is the perfect reason why we send PRs for review :) Removed now so will merge on green","created_at":"2016-09-28T10:07:15Z","updated_at":"2016-09-28T10:07:15Z","html_url":"https://github.com/hashicorp/terraform/pull/9052#discussion_r80882766","pull_request_url":"https://api.github.com/repos/hashicorp/terraform/pulls/9052","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/comments/80882766"},"html":{"href":"https://github.com/hashicorp/terraform/pull/9052#discussion_r80882766"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/9052"}}},"pull_request":{"url":"https://api.github.com/repos/hashicorp/terraform/pulls/9052","id":86738918,"html_url":"https://github.com/hashicorp/terraform/pull/9052","diff_url":"https://github.com/hashicorp/terraform/pull/9052.diff","patch_url":"https://github.com/hashicorp/terraform/pull/9052.patch","issue_url":"https://api.github.com/repos/hashicorp/terraform/issues/9052","number":9052,"state":"open","locked":false,"title":"provider/aws: aws_db_option_group flattenOptions failing due to missing values","user":{"login":"stack72","id":227823,"avatar_url":"https://avatars.githubusercontent.com/u/227823?v=3","gravatar_id":"","url":"https://api.github.com/users/stack72","html_url":"https://github.com/stack72","followers_url":"https://api.github.com/users/stack72/followers","following_url":"https://api.github.com/users/stack72/following{/other_user}","gists_url":"https://api.github.com/users/stack72/gists{/gist_id}","starred_url":"https://api.github.com/users/stack72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stack72/subscriptions","organizations_url":"https://api.github.com/users/stack72/orgs","repos_url":"https://api.github.com/users/stack72/repos","events_url":"https://api.github.com/users/stack72/events{/privacy}","received_events_url":"https://api.github.com/users/stack72/received_events","type":"User","site_admin":false},"body":"Fixes #8332\r\n\r\nNot all option_group parameters have values. For example, when you\r\nenable the MariaDB option_group, some of the settings have empty values\r\n(see screenshot)\r\n\r\nThis PR adds a safety net on reading those values back to the statefile\r\n\r\n```\r\n% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSDBOptionGroup_'\r\n==> Checking that code complies with gofmt requirements...\r\ngo generate $(go list ./... | grep -v /terraform/vendor/)\r\n2016/09/26 13:55:21 Generated command/internal_plugin_list.go\r\nTF_ACC=1 go test ./builtin/providers/aws -v\r\n-run=TestAccAWSDBOptionGroup_ -timeout 120m\r\n=== RUN   TestAccAWSDBOptionGroup_importBasic\r\n--- PASS: TestAccAWSDBOptionGroup_importBasic (20.12s)\r\n=== RUN   TestAccAWSDBOptionGroup_basic\r\n--- PASS: TestAccAWSDBOptionGroup_basic (18.45s)\r\n=== RUN   TestAccAWSDBOptionGroup_basicDestroyWithInstance\r\n--- PASS: TestAccAWSDBOptionGroup_basicDestroyWithInstance (597.90s)\r\n=== RUN   TestAccAWSDBOptionGroup_OptionSettings\r\n--- PASS: TestAccAWSDBOptionGroup_OptionSettings (33.27s)\r\n=== RUN   TestAccAWSDBOptionGroup_sqlServerOptionsUpdate\r\n--- PASS: TestAccAWSDBOptionGroup_sqlServerOptionsUpdate (33.39s)\r\n=== RUN   TestAccAWSDBOptionGroup_multipleOptions\r\n--- PASS: TestAccAWSDBOptionGroup_multipleOptions (19.87s)\r\nPASS\r\nok      github.com/hashicorp/terraform/builtin/providers/aws    723.037s\r\n```\r\n\r\n<img width=\"1204\" alt=\"screen shot 2016-09-26 at 13 56 19\" src=\"https://cloud.githubusercontent.com/assets/227823/18835388/c57aec4c-83f2-11e6-9e0c-d2065df4c63b.png\">\r\n","created_at":"2016-09-26T13:08:35Z","updated_at":"2016-09-28T10:07:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2734ace77b9777e1c920232e9fb0deb8ddecc34c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/terraform/pulls/9052/commits","review_comments_url":"https://api.github.com/repos/hashicorp/terraform/pulls/9052/comments","review_comment_url":"https://api.github.com/repos/hashicorp/terraform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/terraform/issues/9052/comments","statuses_url":"https://api.github.com/repos/hashicorp/terraform/statuses/df8ca94093cf3523559ee4d2f66288ddd377a6a9","head":{"label":"hashicorp:b-aws-rds-option-group","ref":"b-aws-rds-option-group","sha":"df8ca94093cf3523559ee4d2f66288ddd377a6a9","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":17728164,"name":"terraform","full_name":"hashicorp/terraform","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/terraform","description":"Terraform is a tool for building, changing, and combining infrastructure safely and efficiently.","fork":false,"url":"https://api.github.com/repos/hashicorp/terraform","forks_url":"https://api.github.com/repos/hashicorp/terraform/forks","keys_url":"https://api.github.com/repos/hashicorp/terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/terraform/teams","hooks_url":"https://api.github.com/repos/hashicorp/terraform/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/terraform/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/terraform/events","assignees_url":"https://api.github.com/repos/hashicorp/terraform/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/terraform/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/terraform/tags","blobs_url":"https://api.github.com/repos/hashicorp/terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/terraform/languages","stargazers_url":"https://api.github.com/repos/hashicorp/terraform/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/terraform/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/terraform/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/terraform/subscription","commits_url":"https://api.github.com/repos/hashicorp/terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/terraform/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/terraform/merges","archive_url":"https://api.github.com/repos/hashicorp/terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/terraform/downloads","issues_url":"https://api.github.com/repos/hashicorp/terraform/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/terraform/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/terraform/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/terraform/deployments","created_at":"2014-03-13T22:25:48Z","updated_at":"2016-09-28T08:22:12Z","pushed_at":"2016-09-28T10:06:52Z","git_url":"git://github.com/hashicorp/terraform.git","ssh_url":"git@github.com:hashicorp/terraform.git","clone_url":"https://github.com/hashicorp/terraform.git","svn_url":"https://github.com/hashicorp/terraform","homepage":"https://www.terraform.io/","size":122733,"stargazers_count":5781,"watchers_count":5781,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1941,"mirror_url":null,"open_issues_count":1654,"forks":1941,"open_issues":1654,"watchers":5781,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"52761701e11888c8412667203268a6a34f034304","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":17728164,"name":"terraform","full_name":"hashicorp/terraform","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/terraform","description":"Terraform is a tool for building, changing, and combining infrastructure safely and efficiently.","fork":false,"url":"https://api.github.com/repos/hashicorp/terraform","forks_url":"https://api.github.com/repos/hashicorp/terraform/forks","keys_url":"https://api.github.com/repos/hashicorp/terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/terraform/teams","hooks_url":"https://api.github.com/repos/hashicorp/terraform/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/terraform/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/terraform/events","assignees_url":"https://api.github.com/repos/hashicorp/terraform/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/terraform/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/terraform/tags","blobs_url":"https://api.github.com/repos/hashicorp/terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/terraform/languages","stargazers_url":"https://api.github.com/repos/hashicorp/terraform/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/terraform/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/terraform/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/terraform/subscription","commits_url":"https://api.github.com/repos/hashicorp/terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/terraform/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/terraform/merges","archive_url":"https://api.github.com/repos/hashicorp/terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/terraform/downloads","issues_url":"https://api.github.com/repos/hashicorp/terraform/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/terraform/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/terraform/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/terraform/deployments","created_at":"2014-03-13T22:25:48Z","updated_at":"2016-09-28T08:22:12Z","pushed_at":"2016-09-28T10:06:52Z","git_url":"git://github.com/hashicorp/terraform.git","ssh_url":"git@github.com:hashicorp/terraform.git","clone_url":"https://github.com/hashicorp/terraform.git","svn_url":"https://github.com/hashicorp/terraform","homepage":"https://www.terraform.io/","size":122733,"stargazers_count":5781,"watchers_count":5781,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1941,"mirror_url":null,"open_issues_count":1654,"forks":1941,"open_issues":1654,"watchers":5781,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/9052"},"html":{"href":"https://github.com/hashicorp/terraform/pull/9052"},"issue":{"href":"https://api.github.com/repos/hashicorp/terraform/issues/9052"},"comments":{"href":"https://api.github.com/repos/hashicorp/terraform/issues/9052/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/9052/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/9052/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/terraform/statuses/df8ca94093cf3523559ee4d2f66288ddd377a6a9"}}}}
{"actor":{"display_login":"stack72"}}