{"action":"created","issue":{"url":"https://api.github.com/repos/minetest/minetest_game/issues/1284","repository_url":"https://api.github.com/repos/minetest/minetest_game","labels_url":"https://api.github.com/repos/minetest/minetest_game/issues/1284/labels{/name}","comments_url":"https://api.github.com/repos/minetest/minetest_game/issues/1284/comments","events_url":"https://api.github.com/repos/minetest/minetest_game/issues/1284/events","html_url":"https://github.com/minetest/minetest_game/pull/1284","id":176229343,"number":1284,"title":"Allow buckets to trigger the on_punch of entities and nodes","user":{"login":"Ferk","id":193426,"avatar_url":"https://avatars.githubusercontent.com/u/193426?v=3","gravatar_id":"","url":"https://api.github.com/users/Ferk","html_url":"https://github.com/Ferk","followers_url":"https://api.github.com/users/Ferk/followers","following_url":"https://api.github.com/users/Ferk/following{/other_user}","gists_url":"https://api.github.com/users/Ferk/gists{/gist_id}","starred_url":"https://api.github.com/users/Ferk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ferk/subscriptions","organizations_url":"https://api.github.com/users/Ferk/orgs","repos_url":"https://api.github.com/users/Ferk/repos","events_url":"https://api.github.com/users/Ferk/events{/privacy}","received_events_url":"https://api.github.com/users/Ferk/received_events","type":"User","site_admin":false},"labels":[{"id":335383759,"url":"https://api.github.com/repos/minetest/minetest_game/labels/%3E=%20Two%20approvals","name":">= Two approvals","color":"bfd4f2","default":false},{"id":111871497,"url":"https://api.github.com/repos/minetest/minetest_game/labels/Feature%20request","name":"Feature request","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2016-09-11T08:07:36Z","updated_at":"2016-10-27T19:38:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/minetest/minetest_game/pulls/1284","html_url":"https://github.com/minetest/minetest_game/pull/1284","diff_url":"https://github.com/minetest/minetest_game/pull/1284.diff","patch_url":"https://github.com/minetest/minetest_game/pull/1284.patch"},"body":"This is a follow up on #1032, which was closed.\r\nIn addition this PR also triggers a punch when it's an entity the one pointed.\r\n\r\nThe purpose of this is to allow mods to be able to interact (e.g. fill up) with an empty bucket when it's used to punch a node that's not a liquid source or when punching a custom entity (like milking a cow, see #673)."},"comment":{"url":"https://api.github.com/repos/minetest/minetest_game/issues/comments/256747201","html_url":"https://github.com/minetest/minetest_game/pull/1284#issuecomment-256747201","issue_url":"https://api.github.com/repos/minetest/minetest_game/issues/1284","id":256747201,"user":{"login":"Wuzzy2","id":1675853,"avatar_url":"https://avatars.githubusercontent.com/u/1675853?v=3","gravatar_id":"","url":"https://api.github.com/users/Wuzzy2","html_url":"https://github.com/Wuzzy2","followers_url":"https://api.github.com/users/Wuzzy2/followers","following_url":"https://api.github.com/users/Wuzzy2/following{/other_user}","gists_url":"https://api.github.com/users/Wuzzy2/gists{/gist_id}","starred_url":"https://api.github.com/users/Wuzzy2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wuzzy2/subscriptions","organizations_url":"https://api.github.com/users/Wuzzy2/orgs","repos_url":"https://api.github.com/users/Wuzzy2/repos","events_url":"https://api.github.com/users/Wuzzy2/events{/privacy}","received_events_url":"https://api.github.com/users/Wuzzy2/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T19:38:11Z","updated_at":"2016-10-27T19:38:11Z","body":"OK, just make it simple, please, and answer these questions:\r\n\r\n* What does the player have to do *exactly* to trigger the callback?\r\n* Which callback function *exactly* is called?\r\n\r\nAnswer these two questions and you know what to write into the docs.\r\n\r\nFinally, for quality assurance: Are you sure this callback function can not be `nil`?"}}
{"actor":{"display_login":"Wuzzy2"}}