{"action":"created","issue":{"url":"https://api.github.com/repos/NathanWalker/angular2-seed-advanced/issues/247","repository_url":"https://api.github.com/repos/NathanWalker/angular2-seed-advanced","labels_url":"https://api.github.com/repos/NathanWalker/angular2-seed-advanced/issues/247/labels{/name}","comments_url":"https://api.github.com/repos/NathanWalker/angular2-seed-advanced/issues/247/comments","events_url":"https://api.github.com/repos/NathanWalker/angular2-seed-advanced/issues/247/events","html_url":"https://github.com/NathanWalker/angular2-seed-advanced/pull/247","id":179266982,"number":247,"title":"feat: PageWrapService and PageComponent-decorator","user":{"login":"m-abs","id":1348705,"avatar_url":"https://avatars.githubusercontent.com/u/1348705?v=3","gravatar_id":"","url":"https://api.github.com/users/m-abs","html_url":"https://github.com/m-abs","followers_url":"https://api.github.com/users/m-abs/followers","following_url":"https://api.github.com/users/m-abs/following{/other_user}","gists_url":"https://api.github.com/users/m-abs/gists{/gist_id}","starred_url":"https://api.github.com/users/m-abs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-abs/subscriptions","organizations_url":"https://api.github.com/users/m-abs/orgs","repos_url":"https://api.github.com/users/m-abs/repos","events_url":"https://api.github.com/users/m-abs/events{/privacy}","received_events_url":"https://api.github.com/users/m-abs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-09-26T15:52:19Z","updated_at":"2016-09-28T20:05:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NathanWalker/angular2-seed-advanced/pulls/247","html_url":"https://github.com/NathanWalker/angular2-seed-advanced/pull/247","diff_url":"https://github.com/NathanWalker/angular2-seed-advanced/pull/247.diff","patch_url":"https://github.com/NathanWalker/angular2-seed-advanced/pull/247.patch"},"body":"* Adds the `PageComponent` Decoraator that injects the new class PageWrapService\r\n* Adds `PageWrapService` and `TNSPageWrapService` for getting the page-object\r\n  for the current page, which is injected by Angular Native's `page-router-outlet`\r\n\r\nI've removed the `customDecoratorMetadata.directives` from `DecoratorUtils` since after `NgModule` was introducted the `@Component`-decorator no longer takes an `directives`-array.\r\nI've replaced it with an `providers`-array, since `NgModule` makes providers implicitly singleton and we need the current page-object created and injected by Angular Native's `page-router-outlet`.\r\n\r\nI'm not sure about adding the PageWrapService to the `Config`-class and replacing it at boottime in {N}, but I couldn't figure out a better way to do it."},"comment":{"url":"https://api.github.com/repos/NathanWalker/angular2-seed-advanced/issues/comments/250283819","html_url":"https://github.com/NathanWalker/angular2-seed-advanced/pull/247#issuecomment-250283819","issue_url":"https://api.github.com/repos/NathanWalker/angular2-seed-advanced/issues/247","id":250283819,"user":{"login":"STHanlon","id":22506904,"avatar_url":"https://avatars.githubusercontent.com/u/22506904?v=3","gravatar_id":"","url":"https://api.github.com/users/STHanlon","html_url":"https://github.com/STHanlon","followers_url":"https://api.github.com/users/STHanlon/followers","following_url":"https://api.github.com/users/STHanlon/following{/other_user}","gists_url":"https://api.github.com/users/STHanlon/gists{/gist_id}","starred_url":"https://api.github.com/users/STHanlon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STHanlon/subscriptions","organizations_url":"https://api.github.com/users/STHanlon/orgs","repos_url":"https://api.github.com/users/STHanlon/repos","events_url":"https://api.github.com/users/STHanlon/events{/privacy}","received_events_url":"https://api.github.com/users/STHanlon/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T20:05:57Z","updated_at":"2016-09-28T20:05:57Z","body":"@NathanWalker  Not sure if it helps - but I gave the \"Page in the token via useFactory\" a try. After injection into a component, the page object is undefined.\r\n\r\nBut - I really like the idea of using OpaqueTokens. Just need to figure out how to get the right Page object. All these hoops just to hide the ActionBar!"}}
{"actor":{"display_login":"STHanlon"}}