{"action":"created","issue":{"url":"https://api.github.com/repos/chobie/jira-api-restclient/issues/108","repository_url":"https://api.github.com/repos/chobie/jira-api-restclient","labels_url":"https://api.github.com/repos/chobie/jira-api-restclient/issues/108/labels{/name}","comments_url":"https://api.github.com/repos/chobie/jira-api-restclient/issues/108/comments","events_url":"https://api.github.com/repos/chobie/jira-api-restclient/issues/108/events","html_url":"https://github.com/chobie/jira-api-restclient/pull/108","id":162681571,"number":108,"title":"Maximal test coverage for \"ClientInterface\" implementing classes","user":{"login":"aik099","id":1277526,"avatar_url":"https://avatars.githubusercontent.com/u/1277526?v=3","gravatar_id":"","url":"https://api.github.com/users/aik099","html_url":"https://github.com/aik099","followers_url":"https://api.github.com/users/aik099/followers","following_url":"https://api.github.com/users/aik099/following{/other_user}","gists_url":"https://api.github.com/users/aik099/gists{/gist_id}","starred_url":"https://api.github.com/users/aik099/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aik099/subscriptions","organizations_url":"https://api.github.com/users/aik099/orgs","repos_url":"https://api.github.com/users/aik099/repos","events_url":"https://api.github.com/users/aik099/events{/privacy}","received_events_url":"https://api.github.com/users/aik099/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-06-28T13:08:26Z","updated_at":"2016-07-01T06:33:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chobie/jira-api-restclient/pulls/108","html_url":"https://github.com/chobie/jira-api-restclient/pull/108","diff_url":"https://github.com/chobie/jira-api-restclient/pull/108.diff","patch_url":"https://github.com/chobie/jira-api-restclient/pull/108.patch"},"body":"Problems solved:\r\n\r\n* check check for non-array `$data` parameter during `GET` request value in `CurlClient` class was made after it was passed into `http_build_query` function call and that caused a notice\r\n* no check was made for `$data` being an array during `GET` request in `PHPClient`\r\n* the `PHPClient` wasn't sending correct `Content-Type` header, when making `GET` request\r\n* support for `DELETE` calls in `CurlClient` (from #76)\r\n* support for `DELETE` calls in `PHPClient`\r\n* file uploads via `CurlClient` were not working in PHP < 5.5 and HHVM (regression introduced in 96ab84e74ca8472ce8d88673742fe39230ccefeb)\r\n* file uploads via `CurlClient` were not working in PHP > 7.0 (regression introduced in 048d96d2052f92d70ea025bc6bbe0e121337d399)\r\n* the `PHPClient` was throwing different exceptions, then `CurlClient` for same HTTP responses\r\n\r\nProblems not solved:\r\n\r\n* `PHPClient` test that is getting HTTP 201 and HTTP 204 responses on HHVM 3.6.6 (Travis CI version) is failing for unknown reason. Locally I've tried on HHVM 3.13.1 and it works. I'm guessing this is HHVM bug.\r\n* Not sure how to write test that would emulate communication error.\r\n* Not sure how to write where test was no communication error, but somehow response is NULL.\r\n\r\nAlso related to #100."},"comment":{"url":"https://api.github.com/repos/chobie/jira-api-restclient/issues/comments/229865513","html_url":"https://github.com/chobie/jira-api-restclient/pull/108#issuecomment-229865513","issue_url":"https://api.github.com/repos/chobie/jira-api-restclient/issues/108","id":229865513,"user":{"login":"aik099","id":1277526,"avatar_url":"https://avatars.githubusercontent.com/u/1277526?v=3","gravatar_id":"","url":"https://api.github.com/users/aik099","html_url":"https://github.com/aik099","followers_url":"https://api.github.com/users/aik099/followers","following_url":"https://api.github.com/users/aik099/following{/other_user}","gists_url":"https://api.github.com/users/aik099/gists{/gist_id}","starred_url":"https://api.github.com/users/aik099/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aik099/subscriptions","organizations_url":"https://api.github.com/users/aik099/orgs","repos_url":"https://api.github.com/users/aik099/repos","events_url":"https://api.github.com/users/aik099/events{/privacy}","received_events_url":"https://api.github.com/users/aik099/received_events","type":"User","site_admin":false},"created_at":"2016-07-01T06:33:00Z","updated_at":"2016-07-01T06:33:00Z","body":"@jpastoor , ready for review."}}
{"actor":{"display_login":"aik099"}}