{"action":"created","comment":{"url":"https://api.github.com/repos/jupyter/notebook/pulls/comments/51633609","id":51633609,"diff_hunk":"@@ -299,118 +355,300 @@ def _config_file_name_default(self):\n     def install_extensions(self):\n         if len(self.extra_args)>1:\n             raise ValueError(\"only one nbextension allowed at a time.  Call multiple times to install multiple extensions.\")\n-        install_nbextension(self.extra_args[0],\n-            overwrite=self.overwrite,\n-            symlink=self.symlink,\n-            verbose=self.verbose,\n-            user=self.user,\n-            prefix=self.prefix,\n-            destination=self.destination,\n-            nbextensions_dir=self.nbextensions_dir,\n+        if self.python:","path":"notebook/nbextensions.py","position":321,"original_position":321,"commit_id":"bb50a2182f8d9cb1cebee008173822c5bee69944","original_commit_id":"bb50a2182f8d9cb1cebee008173822c5bee69944","user":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"body":"these duplicate blocks can be removed by making the function a variable:\r\n\r\n```python\r\ninstall = install_nbextension_python if self.python else install_nbextension\r\n```","created_at":"2016-02-02T20:56:54Z","updated_at":"2016-02-02T20:56:54Z","html_url":"https://github.com/jupyter/notebook/pull/879#discussion_r51633609","pull_request_url":"https://api.github.com/repos/jupyter/notebook/pulls/879","_links":{"self":{"href":"https://api.github.com/repos/jupyter/notebook/pulls/comments/51633609"},"html":{"href":"https://github.com/jupyter/notebook/pull/879#discussion_r51633609"},"pull_request":{"href":"https://api.github.com/repos/jupyter/notebook/pulls/879"}}},"pull_request":{"url":"https://api.github.com/repos/jupyter/notebook/pulls/879","id":53939745,"html_url":"https://github.com/jupyter/notebook/pull/879","diff_url":"https://github.com/jupyter/notebook/pull/879.diff","patch_url":"https://github.com/jupyter/notebook/pull/879.patch","issue_url":"https://api.github.com/repos/jupyter/notebook/issues/879","number":879,"state":"open","locked":false,"title":"[WIP] Adding prototype nbextensions argument to NotebookApp","user":{"login":"ellisonbg","id":27600,"avatar_url":"https://avatars.githubusercontent.com/u/27600?v=3","gravatar_id":"","url":"https://api.github.com/users/ellisonbg","html_url":"https://github.com/ellisonbg","followers_url":"https://api.github.com/users/ellisonbg/followers","following_url":"https://api.github.com/users/ellisonbg/following{/other_user}","gists_url":"https://api.github.com/users/ellisonbg/gists{/gist_id}","starred_url":"https://api.github.com/users/ellisonbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellisonbg/subscriptions","organizations_url":"https://api.github.com/users/ellisonbg/orgs","repos_url":"https://api.github.com/users/ellisonbg/repos","events_url":"https://api.github.com/users/ellisonbg/events{/privacy}","received_events_url":"https://api.github.com/users/ellisonbg/received_events","type":"User","site_admin":false},"body":"This is working draft exploring the feasibility of the first part of the work described in #878 \r\n\r\nSo far this does:\r\n\r\n* Adds an `nbextensions` config traitlet to the main `NotebookApp`.\r\n* Adds logic to the templates and handlers to json serialize that list, put it into the template and get it into a location that `main.js` could access it.\r\n\r\n","created_at":"2015-12-17T06:34:37Z","updated_at":"2016-02-02T20:56:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c8b1318728d605d5cc32ff470a0796fdb33a001","assignee":null,"milestone":{"url":"https://api.github.com/repos/jupyter/notebook/milestones/7","html_url":"https://github.com/jupyter/notebook/milestones/4.2","labels_url":"https://api.github.com/repos/jupyter/notebook/milestones/7/labels","id":1308320,"number":7,"title":"4.2","description":"","creator":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"open_issues":48,"closed_issues":14,"state":"open","created_at":"2015-09-16T11:58:11Z","updated_at":"2016-02-02T20:43:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jupyter/notebook/pulls/879/commits","review_comments_url":"https://api.github.com/repos/jupyter/notebook/pulls/879/comments","review_comment_url":"https://api.github.com/repos/jupyter/notebook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyter/notebook/issues/879/comments","statuses_url":"https://api.github.com/repos/jupyter/notebook/statuses/bb50a2182f8d9cb1cebee008173822c5bee69944","head":{"label":"ellisonbg:nbext-pain","ref":"nbext-pain","sha":"bb50a2182f8d9cb1cebee008173822c5bee69944","user":{"login":"ellisonbg","id":27600,"avatar_url":"https://avatars.githubusercontent.com/u/27600?v=3","gravatar_id":"","url":"https://api.github.com/users/ellisonbg","html_url":"https://github.com/ellisonbg","followers_url":"https://api.github.com/users/ellisonbg/followers","following_url":"https://api.github.com/users/ellisonbg/following{/other_user}","gists_url":"https://api.github.com/users/ellisonbg/gists{/gist_id}","starred_url":"https://api.github.com/users/ellisonbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellisonbg/subscriptions","organizations_url":"https://api.github.com/users/ellisonbg/orgs","repos_url":"https://api.github.com/users/ellisonbg/repos","events_url":"https://api.github.com/users/ellisonbg/events{/privacy}","received_events_url":"https://api.github.com/users/ellisonbg/received_events","type":"User","site_admin":false},"repo":{"id":37481177,"name":"notebook","full_name":"ellisonbg/notebook","owner":{"login":"ellisonbg","id":27600,"avatar_url":"https://avatars.githubusercontent.com/u/27600?v=3","gravatar_id":"","url":"https://api.github.com/users/ellisonbg","html_url":"https://github.com/ellisonbg","followers_url":"https://api.github.com/users/ellisonbg/followers","following_url":"https://api.github.com/users/ellisonbg/following{/other_user}","gists_url":"https://api.github.com/users/ellisonbg/gists{/gist_id}","starred_url":"https://api.github.com/users/ellisonbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellisonbg/subscriptions","organizations_url":"https://api.github.com/users/ellisonbg/orgs","repos_url":"https://api.github.com/users/ellisonbg/repos","events_url":"https://api.github.com/users/ellisonbg/events{/privacy}","received_events_url":"https://api.github.com/users/ellisonbg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ellisonbg/notebook","description":"Jupyter Interactive Notebook","fork":true,"url":"https://api.github.com/repos/ellisonbg/notebook","forks_url":"https://api.github.com/repos/ellisonbg/notebook/forks","keys_url":"https://api.github.com/repos/ellisonbg/notebook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ellisonbg/notebook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ellisonbg/notebook/teams","hooks_url":"https://api.github.com/repos/ellisonbg/notebook/hooks","issue_events_url":"https://api.github.com/repos/ellisonbg/notebook/issues/events{/number}","events_url":"https://api.github.com/repos/ellisonbg/notebook/events","assignees_url":"https://api.github.com/repos/ellisonbg/notebook/assignees{/user}","branches_url":"https://api.github.com/repos/ellisonbg/notebook/branches{/branch}","tags_url":"https://api.github.com/repos/ellisonbg/notebook/tags","blobs_url":"https://api.github.com/repos/ellisonbg/notebook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ellisonbg/notebook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ellisonbg/notebook/git/refs{/sha}","trees_url":"https://api.github.com/repos/ellisonbg/notebook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ellisonbg/notebook/statuses/{sha}","languages_url":"https://api.github.com/repos/ellisonbg/notebook/languages","stargazers_url":"https://api.github.com/repos/ellisonbg/notebook/stargazers","contributors_url":"https://api.github.com/repos/ellisonbg/notebook/contributors","subscribers_url":"https://api.github.com/repos/ellisonbg/notebook/subscribers","subscription_url":"https://api.github.com/repos/ellisonbg/notebook/subscription","commits_url":"https://api.github.com/repos/ellisonbg/notebook/commits{/sha}","git_commits_url":"https://api.github.com/repos/ellisonbg/notebook/git/commits{/sha}","comments_url":"https://api.github.com/repos/ellisonbg/notebook/comments{/number}","issue_comment_url":"https://api.github.com/repos/ellisonbg/notebook/issues/comments{/number}","contents_url":"https://api.github.com/repos/ellisonbg/notebook/contents/{+path}","compare_url":"https://api.github.com/repos/ellisonbg/notebook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ellisonbg/notebook/merges","archive_url":"https://api.github.com/repos/ellisonbg/notebook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ellisonbg/notebook/downloads","issues_url":"https://api.github.com/repos/ellisonbg/notebook/issues{/number}","pulls_url":"https://api.github.com/repos/ellisonbg/notebook/pulls{/number}","milestones_url":"https://api.github.com/repos/ellisonbg/notebook/milestones{/number}","notifications_url":"https://api.github.com/repos/ellisonbg/notebook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ellisonbg/notebook/labels{/name}","releases_url":"https://api.github.com/repos/ellisonbg/notebook/releases{/id}","deployments_url":"https://api.github.com/repos/ellisonbg/notebook/deployments","created_at":"2015-06-15T17:50:53Z","updated_at":"2015-06-15T17:50:54Z","pushed_at":"2016-01-05T06:26:08Z","git_url":"git://github.com/ellisonbg/notebook.git","ssh_url":"git@github.com:ellisonbg/notebook.git","clone_url":"https://github.com/ellisonbg/notebook.git","svn_url":"https://github.com/ellisonbg/notebook","homepage":null,"size":17340,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupyter:master","ref":"master","sha":"dc3dae96b6badccd467b0a4f93a32a038b9573b0","user":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"repo":{"id":33653601,"name":"notebook","full_name":"jupyter/notebook","owner":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jupyter/notebook","description":"Jupyter Interactive Notebook","fork":false,"url":"https://api.github.com/repos/jupyter/notebook","forks_url":"https://api.github.com/repos/jupyter/notebook/forks","keys_url":"https://api.github.com/repos/jupyter/notebook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyter/notebook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyter/notebook/teams","hooks_url":"https://api.github.com/repos/jupyter/notebook/hooks","issue_events_url":"https://api.github.com/repos/jupyter/notebook/issues/events{/number}","events_url":"https://api.github.com/repos/jupyter/notebook/events","assignees_url":"https://api.github.com/repos/jupyter/notebook/assignees{/user}","branches_url":"https://api.github.com/repos/jupyter/notebook/branches{/branch}","tags_url":"https://api.github.com/repos/jupyter/notebook/tags","blobs_url":"https://api.github.com/repos/jupyter/notebook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyter/notebook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyter/notebook/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyter/notebook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyter/notebook/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyter/notebook/languages","stargazers_url":"https://api.github.com/repos/jupyter/notebook/stargazers","contributors_url":"https://api.github.com/repos/jupyter/notebook/contributors","subscribers_url":"https://api.github.com/repos/jupyter/notebook/subscribers","subscription_url":"https://api.github.com/repos/jupyter/notebook/subscription","commits_url":"https://api.github.com/repos/jupyter/notebook/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyter/notebook/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyter/notebook/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyter/notebook/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyter/notebook/contents/{+path}","compare_url":"https://api.github.com/repos/jupyter/notebook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyter/notebook/merges","archive_url":"https://api.github.com/repos/jupyter/notebook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyter/notebook/downloads","issues_url":"https://api.github.com/repos/jupyter/notebook/issues{/number}","pulls_url":"https://api.github.com/repos/jupyter/notebook/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyter/notebook/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyter/notebook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyter/notebook/labels{/name}","releases_url":"https://api.github.com/repos/jupyter/notebook/releases{/id}","deployments_url":"https://api.github.com/repos/jupyter/notebook/deployments","created_at":"2015-04-09T06:58:03Z","updated_at":"2016-02-02T20:20:52Z","pushed_at":"2016-02-02T19:39:45Z","git_url":"git://github.com/jupyter/notebook.git","ssh_url":"git@github.com:jupyter/notebook.git","clone_url":"https://github.com/jupyter/notebook.git","svn_url":"https://github.com/jupyter/notebook","homepage":"https://jupyter-notebook.readthedocs.org/","size":24615,"stargazers_count":718,"watchers_count":718,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":215,"mirror_url":null,"open_issues_count":240,"forks":215,"open_issues":240,"watchers":718,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyter/notebook/pulls/879"},"html":{"href":"https://github.com/jupyter/notebook/pull/879"},"issue":{"href":"https://api.github.com/repos/jupyter/notebook/issues/879"},"comments":{"href":"https://api.github.com/repos/jupyter/notebook/issues/879/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyter/notebook/pulls/879/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyter/notebook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyter/notebook/pulls/879/commits"},"statuses":{"href":"https://api.github.com/repos/jupyter/notebook/statuses/bb50a2182f8d9cb1cebee008173822c5bee69944"}}}}