{"action":"created","comment":{"url":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/comments/52829094","id":52829094,"diff_hunk":"@@ -78,18 +78,28 @@ function getWorker() {\n  * @return {Promise<String>}      encrypted ASCII armored message\n  * @static\n  */\n-function encryptMessage(keys, text) {\n+function encryptMessage(keys, text, encoding) {\n   if (!keys.length) {\n     keys = [keys];\n   }\n \n+  if (encoding === undefined) {\n+    encoding = 'utf8';\n+  }\n+\n   if (asyncProxy) {\n-    return asyncProxy.encryptMessage(keys, text);\n+    return asyncProxy.encryptMessage(keys, text, encoding);","path":"src/openpgp.js","position":16,"original_position":16,"commit_id":"6bac31a257d46f8cb6ed2d7279915b3ebf92e146","original_commit_id":"6bac31a257d46f8cb6ed2d7279915b3ebf92e146","user":{"login":"tanx","id":1374174,"avatar_url":"https://avatars.githubusercontent.com/u/1374174?v=3","gravatar_id":"","url":"https://api.github.com/users/tanx","html_url":"https://github.com/tanx","followers_url":"https://api.github.com/users/tanx/followers","following_url":"https://api.github.com/users/tanx/following{/other_user}","gists_url":"https://api.github.com/users/tanx/gists{/gist_id}","starred_url":"https://api.github.com/users/tanx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanx/subscriptions","organizations_url":"https://api.github.com/users/tanx/orgs","repos_url":"https://api.github.com/users/tanx/repos","events_url":"https://api.github.com/users/tanx/events{/privacy}","received_events_url":"https://api.github.com/users/tanx/received_events","type":"User","site_admin":false},"body":"AsyncProxy now uses the generic `delegate()` function on master.","created_at":"2016-02-13T15:18:37Z","updated_at":"2016-02-13T15:18:37Z","html_url":"https://github.com/openpgpjs/openpgpjs/pull/321#discussion_r52829094","pull_request_url":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/321","_links":{"self":{"href":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/comments/52829094"},"html":{"href":"https://github.com/openpgpjs/openpgpjs/pull/321#discussion_r52829094"},"pull_request":{"href":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/321"}}},"pull_request":{"url":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/321","id":36135229,"html_url":"https://github.com/openpgpjs/openpgpjs/pull/321","diff_url":"https://github.com/openpgpjs/openpgpjs/pull/321.diff","patch_url":"https://github.com/openpgpjs/openpgpjs/pull/321.patch","issue_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/321","number":321,"state":"open","locked":false,"title":"Implement steaming encryption","user":{"login":"evilaliv3","id":217034,"avatar_url":"https://avatars.githubusercontent.com/u/217034?v=3","gravatar_id":"","url":"https://api.github.com/users/evilaliv3","html_url":"https://github.com/evilaliv3","followers_url":"https://api.github.com/users/evilaliv3/followers","following_url":"https://api.github.com/users/evilaliv3/following{/other_user}","gists_url":"https://api.github.com/users/evilaliv3/gists{/gist_id}","starred_url":"https://api.github.com/users/evilaliv3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilaliv3/subscriptions","organizations_url":"https://api.github.com/users/evilaliv3/orgs","repos_url":"https://api.github.com/users/evilaliv3/repos","events_url":"https://api.github.com/users/evilaliv3/events{/privacy}","received_events_url":"https://api.github.com/users/evilaliv3/received_events","type":"User","site_admin":false},"body":"This pull requests supersedes @hellais https://github.com/openpgpjs/openpgpjs/pull/306.\r\n\r\nIn relation to that one it:\r\n- removes the deterministic key generation part that will be evenutally provided in a separated pull request;\r\n- uses stream opts.objectMode = true; to make the patch compatible with Browsers/Phantomjs;\r\n- adds unittests towards all encryption algos:  tripledes, cast5, blowfish, aes128, aes192, aes256, twofish;\r\n- adds unittests for both integregrity protexted modes: true/false.","created_at":"2015-05-25T11:57:32Z","updated_at":"2016-02-13T15:18:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10f540359f48aa385e45357e27b02b7b242074d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/321/commits","review_comments_url":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/321/comments","review_comment_url":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/321/comments","statuses_url":"https://api.github.com/repos/openpgpjs/openpgpjs/statuses/6bac31a257d46f8cb6ed2d7279915b3ebf92e146","head":{"label":"evilaliv3:feature/streaming","ref":"feature/streaming","sha":"6bac31a257d46f8cb6ed2d7279915b3ebf92e146","user":{"login":"evilaliv3","id":217034,"avatar_url":"https://avatars.githubusercontent.com/u/217034?v=3","gravatar_id":"","url":"https://api.github.com/users/evilaliv3","html_url":"https://github.com/evilaliv3","followers_url":"https://api.github.com/users/evilaliv3/followers","following_url":"https://api.github.com/users/evilaliv3/following{/other_user}","gists_url":"https://api.github.com/users/evilaliv3/gists{/gist_id}","starred_url":"https://api.github.com/users/evilaliv3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilaliv3/subscriptions","organizations_url":"https://api.github.com/users/evilaliv3/orgs","repos_url":"https://api.github.com/users/evilaliv3/repos","events_url":"https://api.github.com/users/evilaliv3/events{/privacy}","received_events_url":"https://api.github.com/users/evilaliv3/received_events","type":"User","site_admin":false},"repo":{"id":35090702,"name":"openpgpjs","full_name":"evilaliv3/openpgpjs","owner":{"login":"evilaliv3","id":217034,"avatar_url":"https://avatars.githubusercontent.com/u/217034?v=3","gravatar_id":"","url":"https://api.github.com/users/evilaliv3","html_url":"https://github.com/evilaliv3","followers_url":"https://api.github.com/users/evilaliv3/followers","following_url":"https://api.github.com/users/evilaliv3/following{/other_user}","gists_url":"https://api.github.com/users/evilaliv3/gists{/gist_id}","starred_url":"https://api.github.com/users/evilaliv3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evilaliv3/subscriptions","organizations_url":"https://api.github.com/users/evilaliv3/orgs","repos_url":"https://api.github.com/users/evilaliv3/repos","events_url":"https://api.github.com/users/evilaliv3/events{/privacy}","received_events_url":"https://api.github.com/users/evilaliv3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evilaliv3/openpgpjs","description":"OpenPGP implementation for JavaScript","fork":true,"url":"https://api.github.com/repos/evilaliv3/openpgpjs","forks_url":"https://api.github.com/repos/evilaliv3/openpgpjs/forks","keys_url":"https://api.github.com/repos/evilaliv3/openpgpjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evilaliv3/openpgpjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evilaliv3/openpgpjs/teams","hooks_url":"https://api.github.com/repos/evilaliv3/openpgpjs/hooks","issue_events_url":"https://api.github.com/repos/evilaliv3/openpgpjs/issues/events{/number}","events_url":"https://api.github.com/repos/evilaliv3/openpgpjs/events","assignees_url":"https://api.github.com/repos/evilaliv3/openpgpjs/assignees{/user}","branches_url":"https://api.github.com/repos/evilaliv3/openpgpjs/branches{/branch}","tags_url":"https://api.github.com/repos/evilaliv3/openpgpjs/tags","blobs_url":"https://api.github.com/repos/evilaliv3/openpgpjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evilaliv3/openpgpjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evilaliv3/openpgpjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/evilaliv3/openpgpjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evilaliv3/openpgpjs/statuses/{sha}","languages_url":"https://api.github.com/repos/evilaliv3/openpgpjs/languages","stargazers_url":"https://api.github.com/repos/evilaliv3/openpgpjs/stargazers","contributors_url":"https://api.github.com/repos/evilaliv3/openpgpjs/contributors","subscribers_url":"https://api.github.com/repos/evilaliv3/openpgpjs/subscribers","subscription_url":"https://api.github.com/repos/evilaliv3/openpgpjs/subscription","commits_url":"https://api.github.com/repos/evilaliv3/openpgpjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/evilaliv3/openpgpjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/evilaliv3/openpgpjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/evilaliv3/openpgpjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/evilaliv3/openpgpjs/contents/{+path}","compare_url":"https://api.github.com/repos/evilaliv3/openpgpjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evilaliv3/openpgpjs/merges","archive_url":"https://api.github.com/repos/evilaliv3/openpgpjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evilaliv3/openpgpjs/downloads","issues_url":"https://api.github.com/repos/evilaliv3/openpgpjs/issues{/number}","pulls_url":"https://api.github.com/repos/evilaliv3/openpgpjs/pulls{/number}","milestones_url":"https://api.github.com/repos/evilaliv3/openpgpjs/milestones{/number}","notifications_url":"https://api.github.com/repos/evilaliv3/openpgpjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evilaliv3/openpgpjs/labels{/name}","releases_url":"https://api.github.com/repos/evilaliv3/openpgpjs/releases{/id}","deployments_url":"https://api.github.com/repos/evilaliv3/openpgpjs/deployments","created_at":"2015-05-05T09:37:53Z","updated_at":"2016-02-11T12:47:39Z","pushed_at":"2016-02-11T13:09:57Z","git_url":"git://github.com/evilaliv3/openpgpjs.git","ssh_url":"git@github.com:evilaliv3/openpgpjs.git","clone_url":"https://github.com/evilaliv3/openpgpjs.git","svn_url":"https://github.com/evilaliv3/openpgpjs","homepage":"http://openpgpjs.org","size":18792,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openpgpjs:master","ref":"master","sha":"6c4e0ed6a01b20aaab641f6a93262973b638569c","user":{"login":"openpgpjs","id":1206249,"avatar_url":"https://avatars.githubusercontent.com/u/1206249?v=3","gravatar_id":"","url":"https://api.github.com/users/openpgpjs","html_url":"https://github.com/openpgpjs","followers_url":"https://api.github.com/users/openpgpjs/followers","following_url":"https://api.github.com/users/openpgpjs/following{/other_user}","gists_url":"https://api.github.com/users/openpgpjs/gists{/gist_id}","starred_url":"https://api.github.com/users/openpgpjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openpgpjs/subscriptions","organizations_url":"https://api.github.com/users/openpgpjs/orgs","repos_url":"https://api.github.com/users/openpgpjs/repos","events_url":"https://api.github.com/users/openpgpjs/events{/privacy}","received_events_url":"https://api.github.com/users/openpgpjs/received_events","type":"Organization","site_admin":false},"repo":{"id":2765899,"name":"openpgpjs","full_name":"openpgpjs/openpgpjs","owner":{"login":"openpgpjs","id":1206249,"avatar_url":"https://avatars.githubusercontent.com/u/1206249?v=3","gravatar_id":"","url":"https://api.github.com/users/openpgpjs","html_url":"https://github.com/openpgpjs","followers_url":"https://api.github.com/users/openpgpjs/followers","following_url":"https://api.github.com/users/openpgpjs/following{/other_user}","gists_url":"https://api.github.com/users/openpgpjs/gists{/gist_id}","starred_url":"https://api.github.com/users/openpgpjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openpgpjs/subscriptions","organizations_url":"https://api.github.com/users/openpgpjs/orgs","repos_url":"https://api.github.com/users/openpgpjs/repos","events_url":"https://api.github.com/users/openpgpjs/events{/privacy}","received_events_url":"https://api.github.com/users/openpgpjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openpgpjs/openpgpjs","description":"OpenPGP implementation for JavaScript","fork":false,"url":"https://api.github.com/repos/openpgpjs/openpgpjs","forks_url":"https://api.github.com/repos/openpgpjs/openpgpjs/forks","keys_url":"https://api.github.com/repos/openpgpjs/openpgpjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openpgpjs/openpgpjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openpgpjs/openpgpjs/teams","hooks_url":"https://api.github.com/repos/openpgpjs/openpgpjs/hooks","issue_events_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/events{/number}","events_url":"https://api.github.com/repos/openpgpjs/openpgpjs/events","assignees_url":"https://api.github.com/repos/openpgpjs/openpgpjs/assignees{/user}","branches_url":"https://api.github.com/repos/openpgpjs/openpgpjs/branches{/branch}","tags_url":"https://api.github.com/repos/openpgpjs/openpgpjs/tags","blobs_url":"https://api.github.com/repos/openpgpjs/openpgpjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openpgpjs/openpgpjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openpgpjs/openpgpjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openpgpjs/openpgpjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openpgpjs/openpgpjs/statuses/{sha}","languages_url":"https://api.github.com/repos/openpgpjs/openpgpjs/languages","stargazers_url":"https://api.github.com/repos/openpgpjs/openpgpjs/stargazers","contributors_url":"https://api.github.com/repos/openpgpjs/openpgpjs/contributors","subscribers_url":"https://api.github.com/repos/openpgpjs/openpgpjs/subscribers","subscription_url":"https://api.github.com/repos/openpgpjs/openpgpjs/subscription","commits_url":"https://api.github.com/repos/openpgpjs/openpgpjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openpgpjs/openpgpjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openpgpjs/openpgpjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openpgpjs/openpgpjs/contents/{+path}","compare_url":"https://api.github.com/repos/openpgpjs/openpgpjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openpgpjs/openpgpjs/merges","archive_url":"https://api.github.com/repos/openpgpjs/openpgpjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openpgpjs/openpgpjs/downloads","issues_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues{/number}","pulls_url":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls{/number}","milestones_url":"https://api.github.com/repos/openpgpjs/openpgpjs/milestones{/number}","notifications_url":"https://api.github.com/repos/openpgpjs/openpgpjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openpgpjs/openpgpjs/labels{/name}","releases_url":"https://api.github.com/repos/openpgpjs/openpgpjs/releases{/id}","deployments_url":"https://api.github.com/repos/openpgpjs/openpgpjs/deployments","created_at":"2011-11-13T10:36:43Z","updated_at":"2016-02-12T22:37:22Z","pushed_at":"2016-02-13T10:11:57Z","git_url":"git://github.com/openpgpjs/openpgpjs.git","ssh_url":"git@github.com:openpgpjs/openpgpjs.git","clone_url":"https://github.com/openpgpjs/openpgpjs.git","svn_url":"https://github.com/openpgpjs/openpgpjs","homepage":"http://openpgpjs.org","size":22350,"stargazers_count":1798,"watchers_count":1798,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":246,"mirror_url":null,"open_issues_count":92,"forks":246,"open_issues":92,"watchers":1798,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/321"},"html":{"href":"https://github.com/openpgpjs/openpgpjs/pull/321"},"issue":{"href":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/321"},"comments":{"href":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/321/comments"},"review_comments":{"href":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/321/comments"},"review_comment":{"href":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openpgpjs/openpgpjs/pulls/321/commits"},"statuses":{"href":"https://api.github.com/repos/openpgpjs/openpgpjs/statuses/6bac31a257d46f8cb6ed2d7279915b3ebf92e146"}}}}