{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/71674351","id":71674351,"diff_hunk":"@@ -250,9 +247,10 @@ public KernelTransactionImplementation( StatementOperationParts operations,\n     /**\n      * Reset this transaction to a vanilla state, turning it into a logically new transaction.\n      */\n-    public KernelTransactionImplementation initialize( long lastCommittedTx, long lastTimeStamp )\n+    public KernelTransactionImplementation initialize( long lastCommittedTx, long lastTimeStamp,\n+            StatementLocks statementLocks )","path":"community/kernel/src/main/java/org/neo4j/kernel/impl/api/KernelTransactionImplementation.java","position":47,"original_position":47,"commit_id":"820e1a01e5141514fd0e9a31d1eac9ea980afc48","original_commit_id":"820e1a01e5141514fd0e9a31d1eac9ea980afc48","user":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars.githubusercontent.com/u/12656787?v=3","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"body":"i think we should not pass `statementLocks` here, we should pass all required params through constructor and build them ourselves","created_at":"2016-07-21T09:30:00Z","updated_at":"2016-07-21T09:30:00Z","html_url":"https://github.com/neo4j/neo4j/pull/7545#discussion_r71674351","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/7545","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/71674351"},"html":{"href":"https://github.com/neo4j/neo4j/pull/7545#discussion_r71674351"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/7545"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/7545","id":76909297,"html_url":"https://github.com/neo4j/neo4j/pull/7545","diff_url":"https://github.com/neo4j/neo4j/pull/7545.diff","patch_url":"https://github.com/neo4j/neo4j/pull/7545.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/7545","number":7545,"state":"open","locked":false,"title":"Acquiring locks are deferred to commit time.","user":{"login":"burqen","id":5220077,"avatar_url":"https://avatars.githubusercontent.com/u/5220077?v=3","gravatar_id":"","url":"https://api.github.com/users/burqen","html_url":"https://github.com/burqen","followers_url":"https://api.github.com/users/burqen/followers","following_url":"https://api.github.com/users/burqen/following{/other_user}","gists_url":"https://api.github.com/users/burqen/gists{/gist_id}","starred_url":"https://api.github.com/users/burqen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burqen/subscriptions","organizations_url":"https://api.github.com/users/burqen/orgs","repos_url":"https://api.github.com/users/burqen/repos","events_url":"https://api.github.com/users/burqen/events{/privacy}","received_events_url":"https://api.github.com/users/burqen/received_events","type":"User","site_admin":false},"body":"Introducing setting _deferred_locking_, off by default.\r\n\r\nWe separate between optimistic and pessimistic locking:\r\n\r\n**Optimistic locking**\r\nAcquire locks triggered by some write or read event through the `Statement` cake.\r\nInstead of grabbing those locks we only remind what resources we want to lock and then acquire the them right before commit. \r\n\r\n**Pessimistic locking**\r\nLocks grabbed explicitly by the user or grabbed on master by a slave. Those locks are taken immediately. \r\n\r\n**Note**\r\nGrabbing locks just before commit guards for store inconsistencies but not logical inconsistencies. \r\n\r\n**Warning**\r\nThis feature should not be used. Most of all code in Neo4j is assumed to be executed under some sort of lock, exclusive or shared. This commit makes that assumption false and there has not been enough investigation to foresee what consequences that will have for transaction execution. These problems are still in the unknown but there are also known, purposely undocumented, problems.","created_at":"2016-07-11T07:21:42Z","updated_at":"2016-07-21T09:30:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85ec7dc93df7ac7b71299abebd7c473dd2b53291","assignee":{"login":"tinwelint","id":187292,"avatar_url":"https://avatars.githubusercontent.com/u/187292?v=3","gravatar_id":"","url":"https://api.github.com/users/tinwelint","html_url":"https://github.com/tinwelint","followers_url":"https://api.github.com/users/tinwelint/followers","following_url":"https://api.github.com/users/tinwelint/following{/other_user}","gists_url":"https://api.github.com/users/tinwelint/gists{/gist_id}","starred_url":"https://api.github.com/users/tinwelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinwelint/subscriptions","organizations_url":"https://api.github.com/users/tinwelint/orgs","repos_url":"https://api.github.com/users/tinwelint/repos","events_url":"https://api.github.com/users/tinwelint/events{/privacy}","received_events_url":"https://api.github.com/users/tinwelint/received_events","type":"User","site_admin":false},"assignees":[{"login":"tinwelint","id":187292,"avatar_url":"https://avatars.githubusercontent.com/u/187292?v=3","gravatar_id":"","url":"https://api.github.com/users/tinwelint","html_url":"https://github.com/tinwelint","followers_url":"https://api.github.com/users/tinwelint/followers","following_url":"https://api.github.com/users/tinwelint/following{/other_user}","gists_url":"https://api.github.com/users/tinwelint/gists{/gist_id}","starred_url":"https://api.github.com/users/tinwelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinwelint/subscriptions","organizations_url":"https://api.github.com/users/tinwelint/orgs","repos_url":"https://api.github.com/users/tinwelint/repos","events_url":"https://api.github.com/users/tinwelint/events{/privacy}","received_events_url":"https://api.github.com/users/tinwelint/received_events","type":"User","site_admin":false},{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars.githubusercontent.com/u/12656787?v=3","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/7545/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/7545/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/7545/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/820e1a01e5141514fd0e9a31d1eac9ea980afc48","head":{"label":"burqen:2.3-deferring-locks-try-rebase","ref":"2.3-deferring-locks-try-rebase","sha":"820e1a01e5141514fd0e9a31d1eac9ea980afc48","user":{"login":"burqen","id":5220077,"avatar_url":"https://avatars.githubusercontent.com/u/5220077?v=3","gravatar_id":"","url":"https://api.github.com/users/burqen","html_url":"https://github.com/burqen","followers_url":"https://api.github.com/users/burqen/followers","following_url":"https://api.github.com/users/burqen/following{/other_user}","gists_url":"https://api.github.com/users/burqen/gists{/gist_id}","starred_url":"https://api.github.com/users/burqen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burqen/subscriptions","organizations_url":"https://api.github.com/users/burqen/orgs","repos_url":"https://api.github.com/users/burqen/repos","events_url":"https://api.github.com/users/burqen/events{/privacy}","received_events_url":"https://api.github.com/users/burqen/received_events","type":"User","site_admin":false},"repo":{"id":34265921,"name":"neo4j","full_name":"burqen/neo4j","owner":{"login":"burqen","id":5220077,"avatar_url":"https://avatars.githubusercontent.com/u/5220077?v=3","gravatar_id":"","url":"https://api.github.com/users/burqen","html_url":"https://github.com/burqen","followers_url":"https://api.github.com/users/burqen/followers","following_url":"https://api.github.com/users/burqen/following{/other_user}","gists_url":"https://api.github.com/users/burqen/gists{/gist_id}","starred_url":"https://api.github.com/users/burqen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burqen/subscriptions","organizations_url":"https://api.github.com/users/burqen/orgs","repos_url":"https://api.github.com/users/burqen/repos","events_url":"https://api.github.com/users/burqen/events{/privacy}","received_events_url":"https://api.github.com/users/burqen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/burqen/neo4j","description":"Graphs for Everyone","fork":true,"url":"https://api.github.com/repos/burqen/neo4j","forks_url":"https://api.github.com/repos/burqen/neo4j/forks","keys_url":"https://api.github.com/repos/burqen/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/burqen/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/burqen/neo4j/teams","hooks_url":"https://api.github.com/repos/burqen/neo4j/hooks","issue_events_url":"https://api.github.com/repos/burqen/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/burqen/neo4j/events","assignees_url":"https://api.github.com/repos/burqen/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/burqen/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/burqen/neo4j/tags","blobs_url":"https://api.github.com/repos/burqen/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/burqen/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/burqen/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/burqen/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/burqen/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/burqen/neo4j/languages","stargazers_url":"https://api.github.com/repos/burqen/neo4j/stargazers","contributors_url":"https://api.github.com/repos/burqen/neo4j/contributors","subscribers_url":"https://api.github.com/repos/burqen/neo4j/subscribers","subscription_url":"https://api.github.com/repos/burqen/neo4j/subscription","commits_url":"https://api.github.com/repos/burqen/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/burqen/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/burqen/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/burqen/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/burqen/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/burqen/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/burqen/neo4j/merges","archive_url":"https://api.github.com/repos/burqen/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/burqen/neo4j/downloads","issues_url":"https://api.github.com/repos/burqen/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/burqen/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/burqen/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/burqen/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/burqen/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/burqen/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/burqen/neo4j/deployments","created_at":"2015-04-20T14:38:51Z","updated_at":"2015-04-20T14:39:14Z","pushed_at":"2016-07-21T09:22:10Z","git_url":"git://github.com/burqen/neo4j.git","ssh_url":"git@github.com:burqen/neo4j.git","clone_url":"https://github.com/burqen/neo4j.git","svn_url":"https://github.com/burqen/neo4j","homepage":"http://neo4j.com","size":327817,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.3"}},"base":{"label":"neo4j:2.3","ref":"2.3","sha":"3a5ff58957e60f6c645491a44280576991239eb5","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2016-07-20T22:57:23Z","pushed_at":"2016-07-21T09:22:12Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":372069,"stargazers_count":2810,"watchers_count":2810,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":949,"mirror_url":null,"open_issues_count":386,"forks":949,"open_issues":386,"watchers":2810,"default_branch":"3.1"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/7545"},"html":{"href":"https://github.com/neo4j/neo4j/pull/7545"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/7545"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/7545/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/7545/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/7545/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/820e1a01e5141514fd0e9a31d1eac9ea980afc48"}}}}
{"actor":{"display_login":"MishaDemianenko"}}