{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/comments/52278391","id":52278391,"diff_hunk":"@@ -20,10 +20,19 @@ end\n \n dequeue!(s::Queue) = shift!(s.store)\n \n-function iter{T}(q::Queue{T})\n+# Iterators\n+\n+start(q::Queue) = start(q.store)\n+next(q::Queue, s) = next(q.store, s)\n+done(q::Queue, s) = done(q.store, s)\n+\n+reverse_iter(q::Queue) = reverse_iter(q.store)\n+\n+\n+function iter{T}(s::Stack{T})\n     a = T[]\n-    for i in q.store\n-        push!(a,i)\n+    for i in s.store\n+        unshift!(a,i)","path":"src/queue.jl","position":19,"original_position":19,"commit_id":"0051452896cd3eb8b27753dd2d1b6a54f1603caf","original_commit_id":"0051452896cd3eb8b27753dd2d1b6a54f1603caf","user":{"login":"kmsquire","id":223250,"avatar_url":"https://avatars.githubusercontent.com/u/223250?v=3","gravatar_id":"","url":"https://api.github.com/users/kmsquire","html_url":"https://github.com/kmsquire","followers_url":"https://api.github.com/users/kmsquire/followers","following_url":"https://api.github.com/users/kmsquire/following{/other_user}","gists_url":"https://api.github.com/users/kmsquire/gists{/gist_id}","starred_url":"https://api.github.com/users/kmsquire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmsquire/subscriptions","organizations_url":"https://api.github.com/users/kmsquire/orgs","repos_url":"https://api.github.com/users/kmsquire/repos","events_url":"https://api.github.com/users/kmsquire/events{/privacy}","received_events_url":"https://api.github.com/users/kmsquire/received_events","type":"User","site_admin":false},"body":"I think you forgot to remove this function.  (Also not sure why the type was changed to `Stack`.)","created_at":"2016-02-09T08:28:45Z","updated_at":"2016-02-09T08:28:45Z","html_url":"https://github.com/JuliaLang/DataStructures.jl/pull/171#discussion_r52278391","pull_request_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/171","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/comments/52278391"},"html":{"href":"https://github.com/JuliaLang/DataStructures.jl/pull/171#discussion_r52278391"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/171"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/171","id":56415090,"html_url":"https://github.com/JuliaLang/DataStructures.jl/pull/171","diff_url":"https://github.com/JuliaLang/DataStructures.jl/pull/171.diff","patch_url":"https://github.com/JuliaLang/DataStructures.jl/pull/171.patch","issue_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/issues/171","number":171,"state":"open","locked":false,"title":"use standard iterator for Stack + Queue Fixes #116","user":{"login":"rawls238","id":1596135,"avatar_url":"https://avatars.githubusercontent.com/u/1596135?v=3","gravatar_id":"","url":"https://api.github.com/users/rawls238","html_url":"https://github.com/rawls238","followers_url":"https://api.github.com/users/rawls238/followers","following_url":"https://api.github.com/users/rawls238/following{/other_user}","gists_url":"https://api.github.com/users/rawls238/gists{/gist_id}","starred_url":"https://api.github.com/users/rawls238/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rawls238/subscriptions","organizations_url":"https://api.github.com/users/rawls238/orgs","repos_url":"https://api.github.com/users/rawls238/repos","events_url":"https://api.github.com/users/rawls238/events{/privacy}","received_events_url":"https://api.github.com/users/rawls238/received_events","type":"User","site_admin":false},"body":"@kmsquire\r\n\r\nThis moves the iterator for stack and queue to conform to iterators such as those in https://github.com/JuliaLang/Iterators.jl\r\n\r\nIt effectively just calls down and utilizes the iterator for `Deque`","created_at":"2016-01-19T02:39:23Z","updated_at":"2016-02-09T08:28:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37f6ebe0c135cd6d15548a44e9d0b34f508700bf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/171/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/171/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/issues/171/comments","statuses_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/statuses/0051452896cd3eb8b27753dd2d1b6a54f1603caf","head":{"label":"rawls238:guy_standard_iterator_queue_stack","ref":"guy_standard_iterator_queue_stack","sha":"0051452896cd3eb8b27753dd2d1b6a54f1603caf","user":{"login":"rawls238","id":1596135,"avatar_url":"https://avatars.githubusercontent.com/u/1596135?v=3","gravatar_id":"","url":"https://api.github.com/users/rawls238","html_url":"https://github.com/rawls238","followers_url":"https://api.github.com/users/rawls238/followers","following_url":"https://api.github.com/users/rawls238/following{/other_user}","gists_url":"https://api.github.com/users/rawls238/gists{/gist_id}","starred_url":"https://api.github.com/users/rawls238/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rawls238/subscriptions","organizations_url":"https://api.github.com/users/rawls238/orgs","repos_url":"https://api.github.com/users/rawls238/repos","events_url":"https://api.github.com/users/rawls238/events{/privacy}","received_events_url":"https://api.github.com/users/rawls238/received_events","type":"User","site_admin":false},"repo":{"id":49388029,"name":"DataStructures.jl","full_name":"rawls238/DataStructures.jl","owner":{"login":"rawls238","id":1596135,"avatar_url":"https://avatars.githubusercontent.com/u/1596135?v=3","gravatar_id":"","url":"https://api.github.com/users/rawls238","html_url":"https://github.com/rawls238","followers_url":"https://api.github.com/users/rawls238/followers","following_url":"https://api.github.com/users/rawls238/following{/other_user}","gists_url":"https://api.github.com/users/rawls238/gists{/gist_id}","starred_url":"https://api.github.com/users/rawls238/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rawls238/subscriptions","organizations_url":"https://api.github.com/users/rawls238/orgs","repos_url":"https://api.github.com/users/rawls238/repos","events_url":"https://api.github.com/users/rawls238/events{/privacy}","received_events_url":"https://api.github.com/users/rawls238/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rawls238/DataStructures.jl","description":"Julia implementation of Data structures","fork":true,"url":"https://api.github.com/repos/rawls238/DataStructures.jl","forks_url":"https://api.github.com/repos/rawls238/DataStructures.jl/forks","keys_url":"https://api.github.com/repos/rawls238/DataStructures.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rawls238/DataStructures.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rawls238/DataStructures.jl/teams","hooks_url":"https://api.github.com/repos/rawls238/DataStructures.jl/hooks","issue_events_url":"https://api.github.com/repos/rawls238/DataStructures.jl/issues/events{/number}","events_url":"https://api.github.com/repos/rawls238/DataStructures.jl/events","assignees_url":"https://api.github.com/repos/rawls238/DataStructures.jl/assignees{/user}","branches_url":"https://api.github.com/repos/rawls238/DataStructures.jl/branches{/branch}","tags_url":"https://api.github.com/repos/rawls238/DataStructures.jl/tags","blobs_url":"https://api.github.com/repos/rawls238/DataStructures.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rawls238/DataStructures.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rawls238/DataStructures.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/rawls238/DataStructures.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rawls238/DataStructures.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/rawls238/DataStructures.jl/languages","stargazers_url":"https://api.github.com/repos/rawls238/DataStructures.jl/stargazers","contributors_url":"https://api.github.com/repos/rawls238/DataStructures.jl/contributors","subscribers_url":"https://api.github.com/repos/rawls238/DataStructures.jl/subscribers","subscription_url":"https://api.github.com/repos/rawls238/DataStructures.jl/subscription","commits_url":"https://api.github.com/repos/rawls238/DataStructures.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/rawls238/DataStructures.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/rawls238/DataStructures.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/rawls238/DataStructures.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/rawls238/DataStructures.jl/contents/{+path}","compare_url":"https://api.github.com/repos/rawls238/DataStructures.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rawls238/DataStructures.jl/merges","archive_url":"https://api.github.com/repos/rawls238/DataStructures.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rawls238/DataStructures.jl/downloads","issues_url":"https://api.github.com/repos/rawls238/DataStructures.jl/issues{/number}","pulls_url":"https://api.github.com/repos/rawls238/DataStructures.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/rawls238/DataStructures.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/rawls238/DataStructures.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rawls238/DataStructures.jl/labels{/name}","releases_url":"https://api.github.com/repos/rawls238/DataStructures.jl/releases{/id}","deployments_url":"https://api.github.com/repos/rawls238/DataStructures.jl/deployments","created_at":"2016-01-10T22:15:34Z","updated_at":"2016-01-19T02:40:38Z","pushed_at":"2016-02-09T02:42:35Z","git_url":"git://github.com/rawls238/DataStructures.jl.git","ssh_url":"git@github.com:rawls238/DataStructures.jl.git","clone_url":"https://github.com/rawls238/DataStructures.jl.git","svn_url":"https://github.com/rawls238/DataStructures.jl","homepage":"","size":419,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"c6ca7c00d8d0eccf6183a238def88e913e9eb9bf","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":8756512,"name":"DataStructures.jl","full_name":"JuliaLang/DataStructures.jl","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/DataStructures.jl","description":"Julia implementation of Data structures","fork":false,"url":"https://api.github.com/repos/JuliaLang/DataStructures.jl","forks_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/forks","keys_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/teams","hooks_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/events","assignees_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/tags","blobs_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/subscription","commits_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/merges","archive_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/downloads","issues_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/DataStructures.jl/deployments","created_at":"2013-03-13T16:28:14Z","updated_at":"2016-02-09T01:48:50Z","pushed_at":"2016-02-09T02:42:35Z","git_url":"git://github.com/JuliaLang/DataStructures.jl.git","ssh_url":"git@github.com:JuliaLang/DataStructures.jl.git","clone_url":"https://github.com/JuliaLang/DataStructures.jl.git","svn_url":"https://github.com/JuliaLang/DataStructures.jl","homepage":"","size":1132,"stargazers_count":76,"watchers_count":76,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":26,"forks":54,"open_issues":26,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/171"},"html":{"href":"https://github.com/JuliaLang/DataStructures.jl/pull/171"},"issue":{"href":"https://api.github.com/repos/JuliaLang/DataStructures.jl/issues/171"},"comments":{"href":"https://api.github.com/repos/JuliaLang/DataStructures.jl/issues/171/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/171/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/DataStructures.jl/pulls/171/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/DataStructures.jl/statuses/0051452896cd3eb8b27753dd2d1b6a54f1603caf"}}}}