{"action":"created","comment":{"url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments/57452271","id":57452271,"diff_hunk":"@@ -499,13 +475,11 @@ def default_mtu\n     end\n \n     def speed\n-      config_get('interface', 'speed', name: @name)\n+      val = config_get('interface', 'speed', name: @name)\n+      val == 'auto' ? val : val.to_i","path":"lib/cisco_node_utils/interface.rb","position":46,"original_position":46,"commit_id":"c521e5033f31732294baaf59fc7835cd6c07777a","original_commit_id":"c521e5033f31732294baaf59fc7835cd6c07777a","user":{"login":"robert-w-gries","id":7546625,"avatar_url":"https://avatars.githubusercontent.com/u/7546625?v=3","gravatar_id":"","url":"https://api.github.com/users/robert-w-gries","html_url":"https://github.com/robert-w-gries","followers_url":"https://api.github.com/users/robert-w-gries/followers","following_url":"https://api.github.com/users/robert-w-gries/following{/other_user}","gists_url":"https://api.github.com/users/robert-w-gries/gists{/gist_id}","starred_url":"https://api.github.com/users/robert-w-gries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert-w-gries/subscriptions","organizations_url":"https://api.github.com/users/robert-w-gries/orgs","repos_url":"https://api.github.com/users/robert-w-gries/repos","events_url":"https://api.github.com/users/robert-w-gries/events{/privacy}","received_events_url":"https://api.github.com/users/robert-w-gries/received_events","type":"User","site_admin":false},"body":"Yes, `val == nil` is a problem that I thought I handled by adding `return val if val.nil?` but I guess I forgot to commit it.\r\n\r\nIt made sense to me to treat `speed` as an integer where applicable, but if you don't think it adds value I can get rid of it.  I also thought it would help in the puppet layer if we wanted to specify integers.","created_at":"2016-03-25T15:07:36Z","updated_at":"2016-03-25T15:07:36Z","html_url":"https://github.com/cisco/cisco-network-node-utils/pull/316#discussion_r57452271","pull_request_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/316","_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments/57452271"},"html":{"href":"https://github.com/cisco/cisco-network-node-utils/pull/316#discussion_r57452271"},"pull_request":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/316"}}},"pull_request":{"url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/316","id":64092420,"html_url":"https://github.com/cisco/cisco-network-node-utils/pull/316","diff_url":"https://github.com/cisco/cisco-network-node-utils/pull/316.diff","patch_url":"https://github.com/cisco/cisco-network-node-utils/pull/316.patch","issue_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/316","number":316,"state":"open","locked":false,"title":"Feature/interface test all plats","user":{"login":"robert-w-gries","id":7546625,"avatar_url":"https://avatars.githubusercontent.com/u/7546625?v=3","gravatar_id":"","url":"https://api.github.com/users/robert-w-gries","html_url":"https://github.com/robert-w-gries","followers_url":"https://api.github.com/users/robert-w-gries/followers","following_url":"https://api.github.com/users/robert-w-gries/following{/other_user}","gists_url":"https://api.github.com/users/robert-w-gries/gists{/gist_id}","starred_url":"https://api.github.com/users/robert-w-gries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert-w-gries/subscriptions","organizations_url":"https://api.github.com/users/robert-w-gries/orgs","repos_url":"https://api.github.com/users/robert-w-gries/repos","events_url":"https://api.github.com/users/robert-w-gries/events{/privacy}","received_events_url":"https://api.github.com/users/robert-w-gries/received_events","type":"User","site_admin":false},"body":"## Changes\r\n\r\n1. Specify `@http.use_ssl = false` to avoid EOFError from `net/protocol`\r\n  * Note: still seeing EOFError error on n3k-52 (C3064) but it may be resolved by reload\r\n1. Added C3064, C3132, and C3172 as valid product ids in YAML\r\n1. Refactored speed tests to properly test valid values\r\n1. Refactored product id code in `command_reference` to reduce overhead of adding platforms\r\n1. Moved `feature-set fex` to feature provider\r\n\r\n## Test Results\r\n\r\n|                           | N3k     | N5k   | N6k   | N7k   | N8k | N9k I2  | N9k I3 | XR          |\r\n|---------------------------|---------|-------|-------|-------|-----|---------|--------|-------------|\r\n| test_interface            | 1 F <br>1 S | ✅     | ✅     | ✅     | ✅  | 1 F <br>1 S | 2 F    | ✅           |\r\n| test_interface_switchport | ✅       | ✅ <br>3 S | ✅ <br>3 S | ✅ <br>3 S | ✅  | ✅       | ✅      | ✅ <br>24 S      |\r\n| test_interface_svi        | ✅       | ✅ <br>4 S | ✅ <br>4 S | ✅     | ✅  | ✅       | ✅      | ✅ <br>Skipped |\r\n\r\n## Failures\r\n\r\n### N3k / N9k I2\r\n\r\n* Known issue with vlan interfaces not updating ip configuration\r\n\r\n```bash\r\n  1) Failure:\r\nTestInterface#test_interface_ipv4_all_interfaces [/home/robgrie/cisco-network-node-utils/tests/test_interface.rb:337]:\r\nExpected /^\\s+ip address 9.7.1.1\\/15$/ to match output of '\"show run interface vlan45 all | no-more\"':\r\nshow run interface vlan45 all | no-more\r\n```\r\n\r\n### N8k\r\n\r\n* All failures are due to the node reporting as a N9k switch\r\n\r\n### N9k I3\r\n\r\n* Known issue where `negotiate auto` error is not raised by switch","created_at":"2016-03-24T20:17:16Z","updated_at":"2016-03-25T15:07:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01a2b08cc1222d0355dd5c5f757197bc3d171205","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/316/commits","review_comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/316/comments","review_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/316/comments","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/c521e5033f31732294baaf59fc7835cd6c07777a","head":{"label":"robert-w-gries:feature/interface-test-all-plats","ref":"feature/interface-test-all-plats","sha":"c521e5033f31732294baaf59fc7835cd6c07777a","user":{"login":"robert-w-gries","id":7546625,"avatar_url":"https://avatars.githubusercontent.com/u/7546625?v=3","gravatar_id":"","url":"https://api.github.com/users/robert-w-gries","html_url":"https://github.com/robert-w-gries","followers_url":"https://api.github.com/users/robert-w-gries/followers","following_url":"https://api.github.com/users/robert-w-gries/following{/other_user}","gists_url":"https://api.github.com/users/robert-w-gries/gists{/gist_id}","starred_url":"https://api.github.com/users/robert-w-gries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert-w-gries/subscriptions","organizations_url":"https://api.github.com/users/robert-w-gries/orgs","repos_url":"https://api.github.com/users/robert-w-gries/repos","events_url":"https://api.github.com/users/robert-w-gries/events{/privacy}","received_events_url":"https://api.github.com/users/robert-w-gries/received_events","type":"User","site_admin":false},"repo":{"id":43569483,"name":"cisco-network-node-utils","full_name":"robert-w-gries/cisco-network-node-utils","owner":{"login":"robert-w-gries","id":7546625,"avatar_url":"https://avatars.githubusercontent.com/u/7546625?v=3","gravatar_id":"","url":"https://api.github.com/users/robert-w-gries","html_url":"https://github.com/robert-w-gries","followers_url":"https://api.github.com/users/robert-w-gries/followers","following_url":"https://api.github.com/users/robert-w-gries/following{/other_user}","gists_url":"https://api.github.com/users/robert-w-gries/gists{/gist_id}","starred_url":"https://api.github.com/users/robert-w-gries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert-w-gries/subscriptions","organizations_url":"https://api.github.com/users/robert-w-gries/orgs","repos_url":"https://api.github.com/users/robert-w-gries/repos","events_url":"https://api.github.com/users/robert-w-gries/events{/privacy}","received_events_url":"https://api.github.com/users/robert-w-gries/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robert-w-gries/cisco-network-node-utils","description":"","fork":true,"url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils","forks_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/releases{/id}","deployments_url":"https://api.github.com/repos/robert-w-gries/cisco-network-node-utils/deployments","created_at":"2015-10-02T18:32:11Z","updated_at":"2016-03-11T19:18:09Z","pushed_at":"2016-03-24T19:18:45Z","git_url":"git://github.com/robert-w-gries/cisco-network-node-utils.git","ssh_url":"git@github.com:robert-w-gries/cisco-network-node-utils.git","clone_url":"https://github.com/robert-w-gries/cisco-network-node-utils.git","svn_url":"https://github.com/robert-w-gries/cisco-network-node-utils","homepage":null,"size":3313,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"cisco:develop","ref":"develop","sha":"80630a2607249d41794f361071e9ab3383a71833","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":39565196,"name":"cisco-network-node-utils","full_name":"cisco/cisco-network-node-utils","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/cisco-network-node-utils","description":"","fork":false,"url":"https://api.github.com/repos/cisco/cisco-network-node-utils","forks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/releases{/id}","deployments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/deployments","created_at":"2015-07-23T12:07:39Z","updated_at":"2016-02-01T19:00:12Z","pushed_at":"2016-03-25T01:52:31Z","git_url":"git://github.com/cisco/cisco-network-node-utils.git","ssh_url":"git@github.com:cisco/cisco-network-node-utils.git","clone_url":"https://github.com/cisco/cisco-network-node-utils.git","svn_url":"https://github.com/cisco/cisco-network-node-utils","homepage":null,"size":4518,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":7,"forks":34,"open_issues":7,"watchers":9,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/316"},"html":{"href":"https://github.com/cisco/cisco-network-node-utils/pull/316"},"issue":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/316"},"comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/316/comments"},"review_comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/316/comments"},"review_comment":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/316/commits"},"statuses":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/c521e5033f31732294baaf59fc7835cd6c07777a"}}}}