{"action":"created","comment":{"url":"https://api.github.com/repos/electronicarts/EASTL/pulls/comments/55629486","id":55629486,"diff_hunk":"@@ -2,11 +2,27 @@\n # Copyright (C) Electronic Arts Inc.  All rights reserved.\n #-------------------------------------------------------------------------------------------\n cmake_minimum_required(VERSION 3.1)\n+project(EASTL CXX)\n+\n+#-------------------------------------------------------------------------------------------\n+# Sub-projects\n+#-------------------------------------------------------------------------------------------\n+add_subdirectory(test/packages/EAAssert)\n+add_subdirectory(test/packages/EABase)\n+add_subdirectory(test/packages/EAStdC)\n+add_subdirectory(test/packages/EAMain)\n+add_subdirectory(test/packages/EATest)\n+add_subdirectory(test/packages/EAThread)\n+\n+add_subdirectory(benchmark)","path":"CMakeLists.txt","position":16,"original_position":16,"commit_id":"ee5a947a663cc385b65587a2dae990222564a565","original_commit_id":"57fd96b0a4e9c33a31a20a407fbd69743033a233","user":{"login":"rparolin","id":1320845,"avatar_url":"https://avatars.githubusercontent.com/u/1320845?v=3","gravatar_id":"","url":"https://api.github.com/users/rparolin","html_url":"https://github.com/rparolin","followers_url":"https://api.github.com/users/rparolin/followers","following_url":"https://api.github.com/users/rparolin/following{/other_user}","gists_url":"https://api.github.com/users/rparolin/gists{/gist_id}","starred_url":"https://api.github.com/users/rparolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rparolin/subscriptions","organizations_url":"https://api.github.com/users/rparolin/orgs","repos_url":"https://api.github.com/users/rparolin/repos","events_url":"https://api.github.com/users/rparolin/events{/privacy}","received_events_url":"https://api.github.com/users/rparolin/received_events","type":"User","site_admin":false},"body":"It's a breaking change to any using the library.  I'd be willing to do that if this is more inline with what most C++ libraries do.  I don't want to be constantly changing the build scripts back and forth.\r\nThat being said, that using options would make scripting the build / running of the benchmarks/unit tests would be easier (not require directory hopping).\r\n\r\n","created_at":"2016-03-10T03:20:35Z","updated_at":"2016-03-10T03:20:35Z","html_url":"https://github.com/electronicarts/EASTL/pull/32#discussion_r55629486","pull_request_url":"https://api.github.com/repos/electronicarts/EASTL/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/electronicarts/EASTL/pulls/comments/55629486"},"html":{"href":"https://github.com/electronicarts/EASTL/pull/32#discussion_r55629486"},"pull_request":{"href":"https://api.github.com/repos/electronicarts/EASTL/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/electronicarts/EASTL/pulls/32","id":61848754,"html_url":"https://github.com/electronicarts/EASTL/pull/32","diff_url":"https://github.com/electronicarts/EASTL/pull/32.diff","patch_url":"https://github.com/electronicarts/EASTL/pull/32.patch","issue_url":"https://api.github.com/repos/electronicarts/EASTL/issues/32","number":32,"state":"open","locked":false,"title":"CMake restructuring","user":{"login":"pzychotic","id":1724400,"avatar_url":"https://avatars.githubusercontent.com/u/1724400?v=3","gravatar_id":"","url":"https://api.github.com/users/pzychotic","html_url":"https://github.com/pzychotic","followers_url":"https://api.github.com/users/pzychotic/followers","following_url":"https://api.github.com/users/pzychotic/following{/other_user}","gists_url":"https://api.github.com/users/pzychotic/gists{/gist_id}","starred_url":"https://api.github.com/users/pzychotic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pzychotic/subscriptions","organizations_url":"https://api.github.com/users/pzychotic/orgs","repos_url":"https://api.github.com/users/pzychotic/repos","events_url":"https://api.github.com/users/pzychotic/events{/privacy}","received_events_url":"https://api.github.com/users/pzychotic/received_events","type":"User","site_admin":false},"body":"I changed the CMake files so everything can be build from the top-level CMake, as probably most people would expect. This also removes some awkward references from the test and benchmark directories to its parent directory. And it also eliminates the use of undocumented CMake command line options to get the tests and benchmark work from its respective sub-directories.\r\nI also put a workround in place to have all the source and header files show in IDE projects, that makes it a lot easier to work on the whole project and all its dependencies.\r\n\r\nTell me what you think of it or if this is going too far.","created_at":"2016-03-06T17:30:55Z","updated_at":"2016-03-10T03:20:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aee5ce048065807417e72069a9515679ed7610d4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/electronicarts/EASTL/pulls/32/commits","review_comments_url":"https://api.github.com/repos/electronicarts/EASTL/pulls/32/comments","review_comment_url":"https://api.github.com/repos/electronicarts/EASTL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electronicarts/EASTL/issues/32/comments","statuses_url":"https://api.github.com/repos/electronicarts/EASTL/statuses/ee5a947a663cc385b65587a2dae990222564a565","head":{"label":"pzychotic:cmake","ref":"cmake","sha":"ee5a947a663cc385b65587a2dae990222564a565","user":{"login":"pzychotic","id":1724400,"avatar_url":"https://avatars.githubusercontent.com/u/1724400?v=3","gravatar_id":"","url":"https://api.github.com/users/pzychotic","html_url":"https://github.com/pzychotic","followers_url":"https://api.github.com/users/pzychotic/followers","following_url":"https://api.github.com/users/pzychotic/following{/other_user}","gists_url":"https://api.github.com/users/pzychotic/gists{/gist_id}","starred_url":"https://api.github.com/users/pzychotic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pzychotic/subscriptions","organizations_url":"https://api.github.com/users/pzychotic/orgs","repos_url":"https://api.github.com/users/pzychotic/repos","events_url":"https://api.github.com/users/pzychotic/events{/privacy}","received_events_url":"https://api.github.com/users/pzychotic/received_events","type":"User","site_admin":false},"repo":{"id":53207409,"name":"EASTL","full_name":"pzychotic/EASTL","owner":{"login":"pzychotic","id":1724400,"avatar_url":"https://avatars.githubusercontent.com/u/1724400?v=3","gravatar_id":"","url":"https://api.github.com/users/pzychotic","html_url":"https://github.com/pzychotic","followers_url":"https://api.github.com/users/pzychotic/followers","following_url":"https://api.github.com/users/pzychotic/following{/other_user}","gists_url":"https://api.github.com/users/pzychotic/gists{/gist_id}","starred_url":"https://api.github.com/users/pzychotic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pzychotic/subscriptions","organizations_url":"https://api.github.com/users/pzychotic/orgs","repos_url":"https://api.github.com/users/pzychotic/repos","events_url":"https://api.github.com/users/pzychotic/events{/privacy}","received_events_url":"https://api.github.com/users/pzychotic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pzychotic/EASTL","description":"EASTL stands for Electronic Arts Standard Template Library.  It is an extensive and robust implementation that has an emphasis on high performance.","fork":true,"url":"https://api.github.com/repos/pzychotic/EASTL","forks_url":"https://api.github.com/repos/pzychotic/EASTL/forks","keys_url":"https://api.github.com/repos/pzychotic/EASTL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pzychotic/EASTL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pzychotic/EASTL/teams","hooks_url":"https://api.github.com/repos/pzychotic/EASTL/hooks","issue_events_url":"https://api.github.com/repos/pzychotic/EASTL/issues/events{/number}","events_url":"https://api.github.com/repos/pzychotic/EASTL/events","assignees_url":"https://api.github.com/repos/pzychotic/EASTL/assignees{/user}","branches_url":"https://api.github.com/repos/pzychotic/EASTL/branches{/branch}","tags_url":"https://api.github.com/repos/pzychotic/EASTL/tags","blobs_url":"https://api.github.com/repos/pzychotic/EASTL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pzychotic/EASTL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pzychotic/EASTL/git/refs{/sha}","trees_url":"https://api.github.com/repos/pzychotic/EASTL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pzychotic/EASTL/statuses/{sha}","languages_url":"https://api.github.com/repos/pzychotic/EASTL/languages","stargazers_url":"https://api.github.com/repos/pzychotic/EASTL/stargazers","contributors_url":"https://api.github.com/repos/pzychotic/EASTL/contributors","subscribers_url":"https://api.github.com/repos/pzychotic/EASTL/subscribers","subscription_url":"https://api.github.com/repos/pzychotic/EASTL/subscription","commits_url":"https://api.github.com/repos/pzychotic/EASTL/commits{/sha}","git_commits_url":"https://api.github.com/repos/pzychotic/EASTL/git/commits{/sha}","comments_url":"https://api.github.com/repos/pzychotic/EASTL/comments{/number}","issue_comment_url":"https://api.github.com/repos/pzychotic/EASTL/issues/comments{/number}","contents_url":"https://api.github.com/repos/pzychotic/EASTL/contents/{+path}","compare_url":"https://api.github.com/repos/pzychotic/EASTL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pzychotic/EASTL/merges","archive_url":"https://api.github.com/repos/pzychotic/EASTL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pzychotic/EASTL/downloads","issues_url":"https://api.github.com/repos/pzychotic/EASTL/issues{/number}","pulls_url":"https://api.github.com/repos/pzychotic/EASTL/pulls{/number}","milestones_url":"https://api.github.com/repos/pzychotic/EASTL/milestones{/number}","notifications_url":"https://api.github.com/repos/pzychotic/EASTL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pzychotic/EASTL/labels{/name}","releases_url":"https://api.github.com/repos/pzychotic/EASTL/releases{/id}","deployments_url":"https://api.github.com/repos/pzychotic/EASTL/deployments","created_at":"2016-03-05T15:13:34Z","updated_at":"2016-03-05T15:13:35Z","pushed_at":"2016-03-09T20:13:18Z","git_url":"git://github.com/pzychotic/EASTL.git","ssh_url":"git@github.com:pzychotic/EASTL.git","clone_url":"https://github.com/pzychotic/EASTL.git","svn_url":"https://github.com/pzychotic/EASTL","homepage":"","size":1198,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"electronicarts:master","ref":"master","sha":"ef2dac0531b3cb2cc2a1ff68e5507adfb2579fbf","user":{"login":"electronicarts","id":1637638,"avatar_url":"https://avatars.githubusercontent.com/u/1637638?v=3","gravatar_id":"","url":"https://api.github.com/users/electronicarts","html_url":"https://github.com/electronicarts","followers_url":"https://api.github.com/users/electronicarts/followers","following_url":"https://api.github.com/users/electronicarts/following{/other_user}","gists_url":"https://api.github.com/users/electronicarts/gists{/gist_id}","starred_url":"https://api.github.com/users/electronicarts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electronicarts/subscriptions","organizations_url":"https://api.github.com/users/electronicarts/orgs","repos_url":"https://api.github.com/users/electronicarts/repos","events_url":"https://api.github.com/users/electronicarts/events{/privacy}","received_events_url":"https://api.github.com/users/electronicarts/received_events","type":"Organization","site_admin":false},"repo":{"id":48068902,"name":"EASTL","full_name":"electronicarts/EASTL","owner":{"login":"electronicarts","id":1637638,"avatar_url":"https://avatars.githubusercontent.com/u/1637638?v=3","gravatar_id":"","url":"https://api.github.com/users/electronicarts","html_url":"https://github.com/electronicarts","followers_url":"https://api.github.com/users/electronicarts/followers","following_url":"https://api.github.com/users/electronicarts/following{/other_user}","gists_url":"https://api.github.com/users/electronicarts/gists{/gist_id}","starred_url":"https://api.github.com/users/electronicarts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electronicarts/subscriptions","organizations_url":"https://api.github.com/users/electronicarts/orgs","repos_url":"https://api.github.com/users/electronicarts/repos","events_url":"https://api.github.com/users/electronicarts/events{/privacy}","received_events_url":"https://api.github.com/users/electronicarts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/electronicarts/EASTL","description":"EASTL stands for Electronic Arts Standard Template Library.  It is an extensive and robust implementation that has an emphasis on high performance.","fork":false,"url":"https://api.github.com/repos/electronicarts/EASTL","forks_url":"https://api.github.com/repos/electronicarts/EASTL/forks","keys_url":"https://api.github.com/repos/electronicarts/EASTL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electronicarts/EASTL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electronicarts/EASTL/teams","hooks_url":"https://api.github.com/repos/electronicarts/EASTL/hooks","issue_events_url":"https://api.github.com/repos/electronicarts/EASTL/issues/events{/number}","events_url":"https://api.github.com/repos/electronicarts/EASTL/events","assignees_url":"https://api.github.com/repos/electronicarts/EASTL/assignees{/user}","branches_url":"https://api.github.com/repos/electronicarts/EASTL/branches{/branch}","tags_url":"https://api.github.com/repos/electronicarts/EASTL/tags","blobs_url":"https://api.github.com/repos/electronicarts/EASTL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electronicarts/EASTL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electronicarts/EASTL/git/refs{/sha}","trees_url":"https://api.github.com/repos/electronicarts/EASTL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electronicarts/EASTL/statuses/{sha}","languages_url":"https://api.github.com/repos/electronicarts/EASTL/languages","stargazers_url":"https://api.github.com/repos/electronicarts/EASTL/stargazers","contributors_url":"https://api.github.com/repos/electronicarts/EASTL/contributors","subscribers_url":"https://api.github.com/repos/electronicarts/EASTL/subscribers","subscription_url":"https://api.github.com/repos/electronicarts/EASTL/subscription","commits_url":"https://api.github.com/repos/electronicarts/EASTL/commits{/sha}","git_commits_url":"https://api.github.com/repos/electronicarts/EASTL/git/commits{/sha}","comments_url":"https://api.github.com/repos/electronicarts/EASTL/comments{/number}","issue_comment_url":"https://api.github.com/repos/electronicarts/EASTL/issues/comments{/number}","contents_url":"https://api.github.com/repos/electronicarts/EASTL/contents/{+path}","compare_url":"https://api.github.com/repos/electronicarts/EASTL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electronicarts/EASTL/merges","archive_url":"https://api.github.com/repos/electronicarts/EASTL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electronicarts/EASTL/downloads","issues_url":"https://api.github.com/repos/electronicarts/EASTL/issues{/number}","pulls_url":"https://api.github.com/repos/electronicarts/EASTL/pulls{/number}","milestones_url":"https://api.github.com/repos/electronicarts/EASTL/milestones{/number}","notifications_url":"https://api.github.com/repos/electronicarts/EASTL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electronicarts/EASTL/labels{/name}","releases_url":"https://api.github.com/repos/electronicarts/EASTL/releases{/id}","deployments_url":"https://api.github.com/repos/electronicarts/EASTL/deployments","created_at":"2015-12-15T21:04:13Z","updated_at":"2016-03-10T01:50:20Z","pushed_at":"2016-03-09T20:13:19Z","git_url":"git://github.com/electronicarts/EASTL.git","ssh_url":"git@github.com:electronicarts/EASTL.git","clone_url":"https://github.com/electronicarts/EASTL.git","svn_url":"https://github.com/electronicarts/EASTL","homepage":"","size":1328,"stargazers_count":1883,"watchers_count":1883,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":129,"mirror_url":null,"open_issues_count":3,"forks":129,"open_issues":3,"watchers":1883,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electronicarts/EASTL/pulls/32"},"html":{"href":"https://github.com/electronicarts/EASTL/pull/32"},"issue":{"href":"https://api.github.com/repos/electronicarts/EASTL/issues/32"},"comments":{"href":"https://api.github.com/repos/electronicarts/EASTL/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/electronicarts/EASTL/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/electronicarts/EASTL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electronicarts/EASTL/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/electronicarts/EASTL/statuses/ee5a947a663cc385b65587a2dae990222564a565"}}}}