{"action":"created","issue":{"url":"https://api.github.com/repos/ClusterLabs/pacemaker/issues/880","labels_url":"https://api.github.com/repos/ClusterLabs/pacemaker/issues/880/labels{/name}","comments_url":"https://api.github.com/repos/ClusterLabs/pacemaker/issues/880/comments","events_url":"https://api.github.com/repos/ClusterLabs/pacemaker/issues/880/events","html_url":"https://github.com/ClusterLabs/pacemaker/pull/880","id":125380500,"number":880,"title":"Fix: header == NULL when parsing compressed message","user":{"login":"Werkov","id":630751,"avatar_url":"https://avatars.githubusercontent.com/u/630751?v=3","gravatar_id":"","url":"https://api.github.com/users/Werkov","html_url":"https://github.com/Werkov","followers_url":"https://api.github.com/users/Werkov/followers","following_url":"https://api.github.com/users/Werkov/following{/other_user}","gists_url":"https://api.github.com/users/Werkov/gists{/gist_id}","starred_url":"https://api.github.com/users/Werkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Werkov/subscriptions","organizations_url":"https://api.github.com/users/Werkov/orgs","repos_url":"https://api.github.com/users/Werkov/repos","events_url":"https://api.github.com/users/Werkov/events{/privacy}","received_events_url":"https://api.github.com/users/Werkov/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-07T11:56:41Z","updated_at":"2016-01-07T16:21:37Z","closed_at":"2016-01-07T16:12:04Z","pull_request":{"url":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/880","html_url":"https://github.com/ClusterLabs/pacemaker/pull/880","diff_url":"https://github.com/ClusterLabs/pacemaker/pull/880.diff","patch_url":"https://github.com/ClusterLabs/pacemaker/pull/880.patch"},"body":"(I wanted to report it as an issue, however, it seems to be disabled on Github, so proposing a little fixup.)\r\n\r\nWhen parsing a compressed message, message header is reloaded from the\r\nuncompressed buffer. However, because remote->buffer_offset is zeroed\r\nprior that, it'll consider the buffer already processed and return NULL.\r\nZeoring remote->buffer_offset after header retrieval should remedy this.\r\n\r\nAFAICS, the decompression branch is not used so this perhaps is not an\r\nissue in the real world."},"comment":{"url":"https://api.github.com/repos/ClusterLabs/pacemaker/issues/comments/169713727","html_url":"https://github.com/ClusterLabs/pacemaker/pull/880#issuecomment-169713727","issue_url":"https://api.github.com/repos/ClusterLabs/pacemaker/issues/880","id":169713727,"user":{"login":"Werkov","id":630751,"avatar_url":"https://avatars.githubusercontent.com/u/630751?v=3","gravatar_id":"","url":"https://api.github.com/users/Werkov","html_url":"https://github.com/Werkov","followers_url":"https://api.github.com/users/Werkov/followers","following_url":"https://api.github.com/users/Werkov/following{/other_user}","gists_url":"https://api.github.com/users/Werkov/gists{/gist_id}","starred_url":"https://api.github.com/users/Werkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Werkov/subscriptions","organizations_url":"https://api.github.com/users/Werkov/orgs","repos_url":"https://api.github.com/users/Werkov/repos","events_url":"https://api.github.com/users/Werkov/events{/privacy}","received_events_url":"https://api.github.com/users/Werkov/received_events","type":"User","site_admin":false},"created_at":"2016-01-07T16:21:37Z","updated_at":"2016-01-07T16:21:37Z","body":"Does it sound like I used a static analysis tool? :-) I came across it accidentally, when I suspected that a single request to cib can be processed multiple times. This hasn't been the problem though."}}