{"action":"closed","number":201,"pull_request":{"url":"https://api.github.com/repos/stevedonovan/Penlight/pulls/201","id":72715997,"html_url":"https://github.com/stevedonovan/Penlight/pull/201","diff_url":"https://github.com/stevedonovan/Penlight/pull/201.diff","patch_url":"https://github.com/stevedonovan/Penlight/pull/201.patch","issue_url":"https://api.github.com/repos/stevedonovan/Penlight/issues/201","number":201,"state":"closed","locked":false,"title":"utils.executeex() fails on Windows with MSVC14","user":{"login":"cwalther","id":234094,"avatar_url":"https://avatars.githubusercontent.com/u/234094?v=3","gravatar_id":"","url":"https://api.github.com/users/cwalther","html_url":"https://github.com/cwalther","followers_url":"https://api.github.com/users/cwalther/followers","following_url":"https://api.github.com/users/cwalther/following{/other_user}","gists_url":"https://api.github.com/users/cwalther/gists{/gist_id}","starred_url":"https://api.github.com/users/cwalther/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwalther/subscriptions","organizations_url":"https://api.github.com/users/cwalther/orgs","repos_url":"https://api.github.com/users/cwalther/repos","events_url":"https://api.github.com/users/cwalther/events{/privacy}","received_events_url":"https://api.github.com/users/cwalther/received_events","type":"User","site_admin":false},"body":"When Lua is compiled with MSVC14 (Visual Studio 2015), utils.executeex() always fails with “The filename, directory name, or volume label syntax is incorrect”. This is because on that C runtime library, os.tmpname() returns a full path (something like “C:\\Users\\Walther\\AppData\\Local\\Temp\\s290.2”) and the code that prepends the value of the TEMP environment variable in an attempt to deal with the output of older C runtime libraries (something like “\\s558.2” on MSVC10, I didn’t try any others) creates an invalid path due to the ‘:’ in the duplicated drive letter.\r\n\r\nBoth cases are observed on the same Windows 7 system with Lua 5.2.3.\r\n\r\nThe attached commit detects the full path and skips the workaround, making the function work on both versions.\r\n\r\nProbably related to #187 but I didn’t check in detail.","created_at":"2016-06-06T14:13:10Z","updated_at":"2016-07-20T13:14:50Z","closed_at":"2016-07-20T13:14:50Z","merged_at":"2016-07-20T13:14:50Z","merge_commit_sha":"bbdd4396d171ca180eb54881363a2d6d91136b63","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/stevedonovan/Penlight/pulls/201/commits","review_comments_url":"https://api.github.com/repos/stevedonovan/Penlight/pulls/201/comments","review_comment_url":"https://api.github.com/repos/stevedonovan/Penlight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stevedonovan/Penlight/issues/201/comments","statuses_url":"https://api.github.com/repos/stevedonovan/Penlight/statuses/e45cf59a63e90830914b8663b3d1c0da73bc3978","head":{"label":"cwalther:executeex","ref":"executeex","sha":"e45cf59a63e90830914b8663b3d1c0da73bc3978","user":{"login":"cwalther","id":234094,"avatar_url":"https://avatars.githubusercontent.com/u/234094?v=3","gravatar_id":"","url":"https://api.github.com/users/cwalther","html_url":"https://github.com/cwalther","followers_url":"https://api.github.com/users/cwalther/followers","following_url":"https://api.github.com/users/cwalther/following{/other_user}","gists_url":"https://api.github.com/users/cwalther/gists{/gist_id}","starred_url":"https://api.github.com/users/cwalther/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwalther/subscriptions","organizations_url":"https://api.github.com/users/cwalther/orgs","repos_url":"https://api.github.com/users/cwalther/repos","events_url":"https://api.github.com/users/cwalther/events{/privacy}","received_events_url":"https://api.github.com/users/cwalther/received_events","type":"User","site_admin":false},"repo":{"id":60533098,"name":"Penlight","full_name":"cwalther/Penlight","owner":{"login":"cwalther","id":234094,"avatar_url":"https://avatars.githubusercontent.com/u/234094?v=3","gravatar_id":"","url":"https://api.github.com/users/cwalther","html_url":"https://github.com/cwalther","followers_url":"https://api.github.com/users/cwalther/followers","following_url":"https://api.github.com/users/cwalther/following{/other_user}","gists_url":"https://api.github.com/users/cwalther/gists{/gist_id}","starred_url":"https://api.github.com/users/cwalther/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwalther/subscriptions","organizations_url":"https://api.github.com/users/cwalther/orgs","repos_url":"https://api.github.com/users/cwalther/repos","events_url":"https://api.github.com/users/cwalther/events{/privacy}","received_events_url":"https://api.github.com/users/cwalther/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cwalther/Penlight","description":"A set of pure Lua libraries focusing on input data handling (such as reading configuration files), functional programming (such as map, reduce, placeholder expressions,etc), and OS path management.  Much of the functionality is inspired by the Python standard libraries.","fork":true,"url":"https://api.github.com/repos/cwalther/Penlight","forks_url":"https://api.github.com/repos/cwalther/Penlight/forks","keys_url":"https://api.github.com/repos/cwalther/Penlight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cwalther/Penlight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cwalther/Penlight/teams","hooks_url":"https://api.github.com/repos/cwalther/Penlight/hooks","issue_events_url":"https://api.github.com/repos/cwalther/Penlight/issues/events{/number}","events_url":"https://api.github.com/repos/cwalther/Penlight/events","assignees_url":"https://api.github.com/repos/cwalther/Penlight/assignees{/user}","branches_url":"https://api.github.com/repos/cwalther/Penlight/branches{/branch}","tags_url":"https://api.github.com/repos/cwalther/Penlight/tags","blobs_url":"https://api.github.com/repos/cwalther/Penlight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cwalther/Penlight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cwalther/Penlight/git/refs{/sha}","trees_url":"https://api.github.com/repos/cwalther/Penlight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cwalther/Penlight/statuses/{sha}","languages_url":"https://api.github.com/repos/cwalther/Penlight/languages","stargazers_url":"https://api.github.com/repos/cwalther/Penlight/stargazers","contributors_url":"https://api.github.com/repos/cwalther/Penlight/contributors","subscribers_url":"https://api.github.com/repos/cwalther/Penlight/subscribers","subscription_url":"https://api.github.com/repos/cwalther/Penlight/subscription","commits_url":"https://api.github.com/repos/cwalther/Penlight/commits{/sha}","git_commits_url":"https://api.github.com/repos/cwalther/Penlight/git/commits{/sha}","comments_url":"https://api.github.com/repos/cwalther/Penlight/comments{/number}","issue_comment_url":"https://api.github.com/repos/cwalther/Penlight/issues/comments{/number}","contents_url":"https://api.github.com/repos/cwalther/Penlight/contents/{+path}","compare_url":"https://api.github.com/repos/cwalther/Penlight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cwalther/Penlight/merges","archive_url":"https://api.github.com/repos/cwalther/Penlight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cwalther/Penlight/downloads","issues_url":"https://api.github.com/repos/cwalther/Penlight/issues{/number}","pulls_url":"https://api.github.com/repos/cwalther/Penlight/pulls{/number}","milestones_url":"https://api.github.com/repos/cwalther/Penlight/milestones{/number}","notifications_url":"https://api.github.com/repos/cwalther/Penlight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cwalther/Penlight/labels{/name}","releases_url":"https://api.github.com/repos/cwalther/Penlight/releases{/id}","deployments_url":"https://api.github.com/repos/cwalther/Penlight/deployments","created_at":"2016-06-06T14:09:07Z","updated_at":"2016-06-06T14:09:09Z","pushed_at":"2016-06-06T14:10:29Z","git_url":"git://github.com/cwalther/Penlight.git","ssh_url":"git@github.com:cwalther/Penlight.git","clone_url":"https://github.com/cwalther/Penlight.git","svn_url":"https://github.com/cwalther/Penlight","homepage":"http://stevedonovan.github.com/Penlight/","size":1325,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stevedonovan:master","ref":"master","sha":"16d149338af9efc910528641c5240c5641aeb8db","user":{"login":"stevedonovan","id":218893,"avatar_url":"https://avatars.githubusercontent.com/u/218893?v=3","gravatar_id":"","url":"https://api.github.com/users/stevedonovan","html_url":"https://github.com/stevedonovan","followers_url":"https://api.github.com/users/stevedonovan/followers","following_url":"https://api.github.com/users/stevedonovan/following{/other_user}","gists_url":"https://api.github.com/users/stevedonovan/gists{/gist_id}","starred_url":"https://api.github.com/users/stevedonovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevedonovan/subscriptions","organizations_url":"https://api.github.com/users/stevedonovan/orgs","repos_url":"https://api.github.com/users/stevedonovan/repos","events_url":"https://api.github.com/users/stevedonovan/events{/privacy}","received_events_url":"https://api.github.com/users/stevedonovan/received_events","type":"User","site_admin":false},"repo":{"id":553803,"name":"Penlight","full_name":"stevedonovan/Penlight","owner":{"login":"stevedonovan","id":218893,"avatar_url":"https://avatars.githubusercontent.com/u/218893?v=3","gravatar_id":"","url":"https://api.github.com/users/stevedonovan","html_url":"https://github.com/stevedonovan","followers_url":"https://api.github.com/users/stevedonovan/followers","following_url":"https://api.github.com/users/stevedonovan/following{/other_user}","gists_url":"https://api.github.com/users/stevedonovan/gists{/gist_id}","starred_url":"https://api.github.com/users/stevedonovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevedonovan/subscriptions","organizations_url":"https://api.github.com/users/stevedonovan/orgs","repos_url":"https://api.github.com/users/stevedonovan/repos","events_url":"https://api.github.com/users/stevedonovan/events{/privacy}","received_events_url":"https://api.github.com/users/stevedonovan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevedonovan/Penlight","description":"A set of pure Lua libraries focusing on input data handling (such as reading configuration files), functional programming (such as map, reduce, placeholder expressions,etc), and OS path management.  Much of the functionality is inspired by the Python standard libraries.","fork":false,"url":"https://api.github.com/repos/stevedonovan/Penlight","forks_url":"https://api.github.com/repos/stevedonovan/Penlight/forks","keys_url":"https://api.github.com/repos/stevedonovan/Penlight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevedonovan/Penlight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevedonovan/Penlight/teams","hooks_url":"https://api.github.com/repos/stevedonovan/Penlight/hooks","issue_events_url":"https://api.github.com/repos/stevedonovan/Penlight/issues/events{/number}","events_url":"https://api.github.com/repos/stevedonovan/Penlight/events","assignees_url":"https://api.github.com/repos/stevedonovan/Penlight/assignees{/user}","branches_url":"https://api.github.com/repos/stevedonovan/Penlight/branches{/branch}","tags_url":"https://api.github.com/repos/stevedonovan/Penlight/tags","blobs_url":"https://api.github.com/repos/stevedonovan/Penlight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevedonovan/Penlight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevedonovan/Penlight/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevedonovan/Penlight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevedonovan/Penlight/statuses/{sha}","languages_url":"https://api.github.com/repos/stevedonovan/Penlight/languages","stargazers_url":"https://api.github.com/repos/stevedonovan/Penlight/stargazers","contributors_url":"https://api.github.com/repos/stevedonovan/Penlight/contributors","subscribers_url":"https://api.github.com/repos/stevedonovan/Penlight/subscribers","subscription_url":"https://api.github.com/repos/stevedonovan/Penlight/subscription","commits_url":"https://api.github.com/repos/stevedonovan/Penlight/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevedonovan/Penlight/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevedonovan/Penlight/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevedonovan/Penlight/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevedonovan/Penlight/contents/{+path}","compare_url":"https://api.github.com/repos/stevedonovan/Penlight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevedonovan/Penlight/merges","archive_url":"https://api.github.com/repos/stevedonovan/Penlight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevedonovan/Penlight/downloads","issues_url":"https://api.github.com/repos/stevedonovan/Penlight/issues{/number}","pulls_url":"https://api.github.com/repos/stevedonovan/Penlight/pulls{/number}","milestones_url":"https://api.github.com/repos/stevedonovan/Penlight/milestones{/number}","notifications_url":"https://api.github.com/repos/stevedonovan/Penlight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevedonovan/Penlight/labels{/name}","releases_url":"https://api.github.com/repos/stevedonovan/Penlight/releases{/id}","deployments_url":"https://api.github.com/repos/stevedonovan/Penlight/deployments","created_at":"2010-03-09T07:43:52Z","updated_at":"2016-07-12T20:27:31Z","pushed_at":"2016-07-20T13:14:50Z","git_url":"git://github.com/stevedonovan/Penlight.git","ssh_url":"git@github.com:stevedonovan/Penlight.git","clone_url":"https://github.com/stevedonovan/Penlight.git","svn_url":"https://github.com/stevedonovan/Penlight","homepage":"http://stevedonovan.github.com/Penlight/","size":1692,"stargazers_count":563,"watchers_count":563,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":102,"mirror_url":null,"open_issues_count":58,"forks":102,"open_issues":58,"watchers":563,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stevedonovan/Penlight/pulls/201"},"html":{"href":"https://github.com/stevedonovan/Penlight/pull/201"},"issue":{"href":"https://api.github.com/repos/stevedonovan/Penlight/issues/201"},"comments":{"href":"https://api.github.com/repos/stevedonovan/Penlight/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/stevedonovan/Penlight/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/stevedonovan/Penlight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stevedonovan/Penlight/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/stevedonovan/Penlight/statuses/e45cf59a63e90830914b8663b3d1c0da73bc3978"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"stevedonovan","id":218893,"avatar_url":"https://avatars.githubusercontent.com/u/218893?v=3","gravatar_id":"","url":"https://api.github.com/users/stevedonovan","html_url":"https://github.com/stevedonovan","followers_url":"https://api.github.com/users/stevedonovan/followers","following_url":"https://api.github.com/users/stevedonovan/following{/other_user}","gists_url":"https://api.github.com/users/stevedonovan/gists{/gist_id}","starred_url":"https://api.github.com/users/stevedonovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevedonovan/subscriptions","organizations_url":"https://api.github.com/users/stevedonovan/orgs","repos_url":"https://api.github.com/users/stevedonovan/repos","events_url":"https://api.github.com/users/stevedonovan/events{/privacy}","received_events_url":"https://api.github.com/users/stevedonovan/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"stevedonovan"}}