{"action":"closed","number":33,"pull_request":{"url":"https://api.github.com/repos/materialsproject/custodian/pulls/33","id":78543093,"html_url":"https://github.com/materialsproject/custodian/pull/33","diff_url":"https://github.com/materialsproject/custodian/pull/33.diff","patch_url":"https://github.com/materialsproject/custodian/pull/33.patch","issue_url":"https://api.github.com/repos/materialsproject/custodian/issues/33","number":33,"state":"closed","locked":false,"title":"Also call terminate function in natural terminations","user":{"login":"xhqu1981","id":4646623,"avatar_url":"https://avatars.githubusercontent.com/u/4646623?v=3","gravatar_id":"","url":"https://api.github.com/users/xhqu1981","html_url":"https://github.com/xhqu1981","followers_url":"https://api.github.com/users/xhqu1981/followers","following_url":"https://api.github.com/users/xhqu1981/following{/other_user}","gists_url":"https://api.github.com/users/xhqu1981/gists{/gist_id}","starred_url":"https://api.github.com/users/xhqu1981/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhqu1981/subscriptions","organizations_url":"https://api.github.com/users/xhqu1981/orgs","repos_url":"https://api.github.com/users/xhqu1981/repos","events_url":"https://api.github.com/users/xhqu1981/events{/privacy}","received_events_url":"https://api.github.com/users/xhqu1981/received_events","type":"User","site_admin":false},"body":"I added terminate() to natural termination path. This is helpful when VASP is naturally terminated. If there is an error, e.g. segmentation fault, the resources also tends to not be released. Please be noted that it will add an additional 10 seconds sleep to wait for the resources to be release. This commit only affects custodian run with custom terminate function.","created_at":"2016-07-22T21:30:14Z","updated_at":"2016-07-22T22:13:58Z","closed_at":"2016-07-22T22:13:58Z","merged_at":null,"merge_commit_sha":"24a42ea43e98d0010ff89d7b43868b4f25b8a3ea","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/materialsproject/custodian/pulls/33/commits","review_comments_url":"https://api.github.com/repos/materialsproject/custodian/pulls/33/comments","review_comment_url":"https://api.github.com/repos/materialsproject/custodian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/materialsproject/custodian/issues/33/comments","statuses_url":"https://api.github.com/repos/materialsproject/custodian/statuses/de31a23fb225d4db495b8f62cddf5365e5c4b1be","head":{"label":"xhqu1981:master","ref":"master","sha":"de31a23fb225d4db495b8f62cddf5365e5c4b1be","user":{"login":"xhqu1981","id":4646623,"avatar_url":"https://avatars.githubusercontent.com/u/4646623?v=3","gravatar_id":"","url":"https://api.github.com/users/xhqu1981","html_url":"https://github.com/xhqu1981","followers_url":"https://api.github.com/users/xhqu1981/followers","following_url":"https://api.github.com/users/xhqu1981/following{/other_user}","gists_url":"https://api.github.com/users/xhqu1981/gists{/gist_id}","starred_url":"https://api.github.com/users/xhqu1981/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhqu1981/subscriptions","organizations_url":"https://api.github.com/users/xhqu1981/orgs","repos_url":"https://api.github.com/users/xhqu1981/repos","events_url":"https://api.github.com/users/xhqu1981/events{/privacy}","received_events_url":"https://api.github.com/users/xhqu1981/received_events","type":"User","site_admin":false},"repo":{"id":55637663,"name":"custodian","full_name":"xhqu1981/custodian","owner":{"login":"xhqu1981","id":4646623,"avatar_url":"https://avatars.githubusercontent.com/u/4646623?v=3","gravatar_id":"","url":"https://api.github.com/users/xhqu1981","html_url":"https://github.com/xhqu1981","followers_url":"https://api.github.com/users/xhqu1981/followers","following_url":"https://api.github.com/users/xhqu1981/following{/other_user}","gists_url":"https://api.github.com/users/xhqu1981/gists{/gist_id}","starred_url":"https://api.github.com/users/xhqu1981/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhqu1981/subscriptions","organizations_url":"https://api.github.com/users/xhqu1981/orgs","repos_url":"https://api.github.com/users/xhqu1981/repos","events_url":"https://api.github.com/users/xhqu1981/events{/privacy}","received_events_url":"https://api.github.com/users/xhqu1981/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xhqu1981/custodian","description":"A simple, robust and flexible just-in-time job management framework in Python.","fork":true,"url":"https://api.github.com/repos/xhqu1981/custodian","forks_url":"https://api.github.com/repos/xhqu1981/custodian/forks","keys_url":"https://api.github.com/repos/xhqu1981/custodian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xhqu1981/custodian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xhqu1981/custodian/teams","hooks_url":"https://api.github.com/repos/xhqu1981/custodian/hooks","issue_events_url":"https://api.github.com/repos/xhqu1981/custodian/issues/events{/number}","events_url":"https://api.github.com/repos/xhqu1981/custodian/events","assignees_url":"https://api.github.com/repos/xhqu1981/custodian/assignees{/user}","branches_url":"https://api.github.com/repos/xhqu1981/custodian/branches{/branch}","tags_url":"https://api.github.com/repos/xhqu1981/custodian/tags","blobs_url":"https://api.github.com/repos/xhqu1981/custodian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xhqu1981/custodian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xhqu1981/custodian/git/refs{/sha}","trees_url":"https://api.github.com/repos/xhqu1981/custodian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xhqu1981/custodian/statuses/{sha}","languages_url":"https://api.github.com/repos/xhqu1981/custodian/languages","stargazers_url":"https://api.github.com/repos/xhqu1981/custodian/stargazers","contributors_url":"https://api.github.com/repos/xhqu1981/custodian/contributors","subscribers_url":"https://api.github.com/repos/xhqu1981/custodian/subscribers","subscription_url":"https://api.github.com/repos/xhqu1981/custodian/subscription","commits_url":"https://api.github.com/repos/xhqu1981/custodian/commits{/sha}","git_commits_url":"https://api.github.com/repos/xhqu1981/custodian/git/commits{/sha}","comments_url":"https://api.github.com/repos/xhqu1981/custodian/comments{/number}","issue_comment_url":"https://api.github.com/repos/xhqu1981/custodian/issues/comments{/number}","contents_url":"https://api.github.com/repos/xhqu1981/custodian/contents/{+path}","compare_url":"https://api.github.com/repos/xhqu1981/custodian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xhqu1981/custodian/merges","archive_url":"https://api.github.com/repos/xhqu1981/custodian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xhqu1981/custodian/downloads","issues_url":"https://api.github.com/repos/xhqu1981/custodian/issues{/number}","pulls_url":"https://api.github.com/repos/xhqu1981/custodian/pulls{/number}","milestones_url":"https://api.github.com/repos/xhqu1981/custodian/milestones{/number}","notifications_url":"https://api.github.com/repos/xhqu1981/custodian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xhqu1981/custodian/labels{/name}","releases_url":"https://api.github.com/repos/xhqu1981/custodian/releases{/id}","deployments_url":"https://api.github.com/repos/xhqu1981/custodian/deployments","created_at":"2016-04-06T20:17:51Z","updated_at":"2016-04-06T20:17:54Z","pushed_at":"2016-07-22T22:11:28Z","git_url":"git://github.com/xhqu1981/custodian.git","ssh_url":"git@github.com:xhqu1981/custodian.git","clone_url":"https://github.com/xhqu1981/custodian.git","svn_url":"https://github.com/xhqu1981/custodian","homepage":"","size":14261,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"materialsproject:master","ref":"master","sha":"f29d2d4af6d02cd3782b441257336b388f5de588","user":{"login":"materialsproject","id":867057,"avatar_url":"https://avatars.githubusercontent.com/u/867057?v=3","gravatar_id":"","url":"https://api.github.com/users/materialsproject","html_url":"https://github.com/materialsproject","followers_url":"https://api.github.com/users/materialsproject/followers","following_url":"https://api.github.com/users/materialsproject/following{/other_user}","gists_url":"https://api.github.com/users/materialsproject/gists{/gist_id}","starred_url":"https://api.github.com/users/materialsproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/materialsproject/subscriptions","organizations_url":"https://api.github.com/users/materialsproject/orgs","repos_url":"https://api.github.com/users/materialsproject/repos","events_url":"https://api.github.com/users/materialsproject/events{/privacy}","received_events_url":"https://api.github.com/users/materialsproject/received_events","type":"Organization","site_admin":false},"repo":{"id":8013467,"name":"custodian","full_name":"materialsproject/custodian","owner":{"login":"materialsproject","id":867057,"avatar_url":"https://avatars.githubusercontent.com/u/867057?v=3","gravatar_id":"","url":"https://api.github.com/users/materialsproject","html_url":"https://github.com/materialsproject","followers_url":"https://api.github.com/users/materialsproject/followers","following_url":"https://api.github.com/users/materialsproject/following{/other_user}","gists_url":"https://api.github.com/users/materialsproject/gists{/gist_id}","starred_url":"https://api.github.com/users/materialsproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/materialsproject/subscriptions","organizations_url":"https://api.github.com/users/materialsproject/orgs","repos_url":"https://api.github.com/users/materialsproject/repos","events_url":"https://api.github.com/users/materialsproject/events{/privacy}","received_events_url":"https://api.github.com/users/materialsproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/materialsproject/custodian","description":"A simple, robust and flexible just-in-time job management framework in Python.","fork":false,"url":"https://api.github.com/repos/materialsproject/custodian","forks_url":"https://api.github.com/repos/materialsproject/custodian/forks","keys_url":"https://api.github.com/repos/materialsproject/custodian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/materialsproject/custodian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/materialsproject/custodian/teams","hooks_url":"https://api.github.com/repos/materialsproject/custodian/hooks","issue_events_url":"https://api.github.com/repos/materialsproject/custodian/issues/events{/number}","events_url":"https://api.github.com/repos/materialsproject/custodian/events","assignees_url":"https://api.github.com/repos/materialsproject/custodian/assignees{/user}","branches_url":"https://api.github.com/repos/materialsproject/custodian/branches{/branch}","tags_url":"https://api.github.com/repos/materialsproject/custodian/tags","blobs_url":"https://api.github.com/repos/materialsproject/custodian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/materialsproject/custodian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/materialsproject/custodian/git/refs{/sha}","trees_url":"https://api.github.com/repos/materialsproject/custodian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/materialsproject/custodian/statuses/{sha}","languages_url":"https://api.github.com/repos/materialsproject/custodian/languages","stargazers_url":"https://api.github.com/repos/materialsproject/custodian/stargazers","contributors_url":"https://api.github.com/repos/materialsproject/custodian/contributors","subscribers_url":"https://api.github.com/repos/materialsproject/custodian/subscribers","subscription_url":"https://api.github.com/repos/materialsproject/custodian/subscription","commits_url":"https://api.github.com/repos/materialsproject/custodian/commits{/sha}","git_commits_url":"https://api.github.com/repos/materialsproject/custodian/git/commits{/sha}","comments_url":"https://api.github.com/repos/materialsproject/custodian/comments{/number}","issue_comment_url":"https://api.github.com/repos/materialsproject/custodian/issues/comments{/number}","contents_url":"https://api.github.com/repos/materialsproject/custodian/contents/{+path}","compare_url":"https://api.github.com/repos/materialsproject/custodian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/materialsproject/custodian/merges","archive_url":"https://api.github.com/repos/materialsproject/custodian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/materialsproject/custodian/downloads","issues_url":"https://api.github.com/repos/materialsproject/custodian/issues{/number}","pulls_url":"https://api.github.com/repos/materialsproject/custodian/pulls{/number}","milestones_url":"https://api.github.com/repos/materialsproject/custodian/milestones{/number}","notifications_url":"https://api.github.com/repos/materialsproject/custodian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/materialsproject/custodian/labels{/name}","releases_url":"https://api.github.com/repos/materialsproject/custodian/releases{/id}","deployments_url":"https://api.github.com/repos/materialsproject/custodian/deployments","created_at":"2013-02-04T18:33:16Z","updated_at":"2016-07-07T02:09:06Z","pushed_at":"2016-07-22T22:11:29Z","git_url":"git://github.com/materialsproject/custodian.git","ssh_url":"git@github.com:materialsproject/custodian.git","clone_url":"https://github.com/materialsproject/custodian.git","svn_url":"https://github.com/materialsproject/custodian","homepage":"","size":15731,"stargazers_count":15,"watchers_count":15,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":2,"forks":25,"open_issues":2,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/materialsproject/custodian/pulls/33"},"html":{"href":"https://github.com/materialsproject/custodian/pull/33"},"issue":{"href":"https://api.github.com/repos/materialsproject/custodian/issues/33"},"comments":{"href":"https://api.github.com/repos/materialsproject/custodian/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/materialsproject/custodian/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/materialsproject/custodian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/materialsproject/custodian/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/materialsproject/custodian/statuses/de31a23fb225d4db495b8f62cddf5365e5c4b1be"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":15,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"xhqu1981"}}