{"action":"created","issue":{"url":"https://api.github.com/repos/jethrocarr/pupistry/issues/12","labels_url":"https://api.github.com/repos/jethrocarr/pupistry/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/jethrocarr/pupistry/issues/12/comments","events_url":"https://api.github.com/repos/jethrocarr/pupistry/issues/12/events","html_url":"https://github.com/jethrocarr/pupistry/issues/12","id":126953356,"number":12,"title":"Support puppet configuration via environment.conf","user":{"login":"ljohnston","id":361524,"avatar_url":"https://avatars.githubusercontent.com/u/361524?v=3","gravatar_id":"","url":"https://api.github.com/users/ljohnston","html_url":"https://github.com/ljohnston","followers_url":"https://api.github.com/users/ljohnston/followers","following_url":"https://api.github.com/users/ljohnston/following{/other_user}","gists_url":"https://api.github.com/users/ljohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/ljohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljohnston/subscriptions","organizations_url":"https://api.github.com/users/ljohnston/orgs","repos_url":"https://api.github.com/users/ljohnston/repos","events_url":"https://api.github.com/users/ljohnston/events{/privacy}","received_events_url":"https://api.github.com/users/ljohnston/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-01-15T20:33:36Z","updated_at":"2016-01-16T21:41:52Z","closed_at":null,"body":"Currently, agent.rb specifies puppet configuration (e.g. modulepath) via command-line switches, which override anything that may be specified in environment.conf. Not sure how it would work exactly, but it seems it would be nice if environment.conf config settings were honored.\r\n\r\nThanks,\r\nLance"},"comment":{"url":"https://api.github.com/repos/jethrocarr/pupistry/issues/comments/172259976","html_url":"https://github.com/jethrocarr/pupistry/issues/12#issuecomment-172259976","issue_url":"https://api.github.com/repos/jethrocarr/pupistry/issues/12","id":172259976,"user":{"login":"jethrocarr","id":622282,"avatar_url":"https://avatars.githubusercontent.com/u/622282?v=3","gravatar_id":"","url":"https://api.github.com/users/jethrocarr","html_url":"https://github.com/jethrocarr","followers_url":"https://api.github.com/users/jethrocarr/followers","following_url":"https://api.github.com/users/jethrocarr/following{/other_user}","gists_url":"https://api.github.com/users/jethrocarr/gists{/gist_id}","starred_url":"https://api.github.com/users/jethrocarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jethrocarr/subscriptions","organizations_url":"https://api.github.com/users/jethrocarr/orgs","repos_url":"https://api.github.com/users/jethrocarr/repos","events_url":"https://api.github.com/users/jethrocarr/events{/privacy}","received_events_url":"https://api.github.com/users/jethrocarr/received_events","type":"User","site_admin":false},"created_at":"2016-01-16T21:41:52Z","updated_at":"2016-01-16T21:41:52Z","body":"hi Lance,\r\n\r\nYeah so the modules directory won't work due to the r10k workflow, not much can change about that one. Given what you're trying to do, using environment.conf does sound reasonable.\r\n\r\nThe way you'd need to fix it is to amend `pupistry/lib/pupistry/agent.rb` and write some logic that checks if an `environment.conf` exists in `#{$config['agent']['puppetcode']}/#{environment}` and if so, load and parse it and suck out values to either be merged or replace the ones Pupistry is setting.\r\n\r\nIf you want to have a go and send me a PR, happy to review and merge if it doesn't break anything for people not using `environment.conf` files.\r\n\r\nregards,\r\nJethro"}}