{"action":"created","issue":{"url":"https://api.github.com/repos/dronekit/dronekit-python/issues/566","repository_url":"https://api.github.com/repos/dronekit/dronekit-python","labels_url":"https://api.github.com/repos/dronekit/dronekit-python/issues/566/labels{/name}","comments_url":"https://api.github.com/repos/dronekit/dronekit-python/issues/566/comments","events_url":"https://api.github.com/repos/dronekit/dronekit-python/issues/566/events","html_url":"https://github.com/dronekit/dronekit-python/pull/566","id":134544726,"number":566,"title":"Create setter functions rather than setting attributes directly","user":{"login":"hamishwillee","id":5368500,"avatar_url":"https://avatars.githubusercontent.com/u/5368500?v=3","gravatar_id":"","url":"https://api.github.com/users/hamishwillee","html_url":"https://github.com/hamishwillee","followers_url":"https://api.github.com/users/hamishwillee/followers","following_url":"https://api.github.com/users/hamishwillee/following{/other_user}","gists_url":"https://api.github.com/users/hamishwillee/gists{/gist_id}","starred_url":"https://api.github.com/users/hamishwillee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamishwillee/subscriptions","organizations_url":"https://api.github.com/users/hamishwillee/orgs","repos_url":"https://api.github.com/users/hamishwillee/repos","events_url":"https://api.github.com/users/hamishwillee/events{/privacy}","received_events_url":"https://api.github.com/users/hamishwillee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2016-02-18T10:53:14Z","updated_at":"2016-04-26T02:36:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dronekit/dronekit-python/pulls/566","html_url":"https://github.com/dronekit/dronekit-python/pull/566","diff_url":"https://github.com/dronekit/dronekit-python/pull/566.diff","patch_url":"https://github.com/dronekit/dronekit-python/pull/566.patch"},"body":"This adds setter functions for mode, armed, home_location, airspeed and groundspeed attributes and adds documentation to mark the old attributes as deprecated.\r\n\r\nThe reason for this change is that the attribute setters have unexpected behaviour (for users) - specifically, setting the value of these attributes does not change the value immediately and may or may not work.\r\n\r\nBy adding appropriately named setter functions we make it clear that the messages may or may not be received and we've added waiting versions that will make best effort to verify the success of the message. \r\n\r\nOverall these methods are safer and easier than the attributes, and reduce the amount of code that  developers need to write. \r\n\r\nThe attribute setters will be removed in a future version.\r\n"},"comment":{"url":"https://api.github.com/repos/dronekit/dronekit-python/issues/comments/214589444","html_url":"https://github.com/dronekit/dronekit-python/pull/566#issuecomment-214589444","issue_url":"https://api.github.com/repos/dronekit/dronekit-python/issues/566","id":214589444,"user":{"login":"hamishwillee","id":5368500,"avatar_url":"https://avatars.githubusercontent.com/u/5368500?v=3","gravatar_id":"","url":"https://api.github.com/users/hamishwillee","html_url":"https://github.com/hamishwillee","followers_url":"https://api.github.com/users/hamishwillee/followers","following_url":"https://api.github.com/users/hamishwillee/following{/other_user}","gists_url":"https://api.github.com/users/hamishwillee/gists{/gist_id}","starred_url":"https://api.github.com/users/hamishwillee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamishwillee/subscriptions","organizations_url":"https://api.github.com/users/hamishwillee/orgs","repos_url":"https://api.github.com/users/hamishwillee/repos","events_url":"https://api.github.com/users/hamishwillee/events{/privacy}","received_events_url":"https://api.github.com/users/hamishwillee/received_events","type":"User","site_admin":false},"created_at":"2016-04-26T02:36:37Z","updated_at":"2016-04-26T02:36:37Z","body":"@mrpollo @peterbarker Any chance to review and merge? I'm not keen to re-merge these changes yet again."}}