{"action":"created","issue":{"url":"https://api.github.com/repos/acemod/ACE3/issues/4064","repository_url":"https://api.github.com/repos/acemod/ACE3","labels_url":"https://api.github.com/repos/acemod/ACE3/issues/4064/labels{/name}","comments_url":"https://api.github.com/repos/acemod/ACE3/issues/4064/comments","events_url":"https://api.github.com/repos/acemod/ACE3/issues/4064/events","html_url":"https://github.com/acemod/ACE3/pull/4064","id":164284634,"number":4064,"title":"Medical rewrite","user":{"login":"Glowbal","id":5007509,"avatar_url":"https://avatars.githubusercontent.com/u/5007509?v=3","gravatar_id":"","url":"https://api.github.com/users/Glowbal","html_url":"https://github.com/Glowbal","followers_url":"https://api.github.com/users/Glowbal/followers","following_url":"https://api.github.com/users/Glowbal/following{/other_user}","gists_url":"https://api.github.com/users/Glowbal/gists{/gist_id}","starred_url":"https://api.github.com/users/Glowbal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Glowbal/subscriptions","organizations_url":"https://api.github.com/users/Glowbal/orgs","repos_url":"https://api.github.com/users/Glowbal/repos","events_url":"https://api.github.com/users/Glowbal/events{/privacy}","received_events_url":"https://api.github.com/users/Glowbal/received_events","type":"User","site_admin":false},"labels":[{"id":309067128,"url":"https://api.github.com/repos/acemod/ACE3/labels/Focus%20Feature","name":"Focus Feature","color":"006b75","default":false},{"id":164934045,"url":"https://api.github.com/repos/acemod/ACE3/labels/WIP","name":"WIP","color":"fad8c7","default":false}],"state":"open","locked":true,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/acemod/ACE3/milestones/23","html_url":"https://github.com/acemod/ACE3/milestones/3.9.0","labels_url":"https://api.github.com/repos/acemod/ACE3/milestones/23/labels","id":2056296,"number":23,"title":"3.9.0","description":"","creator":{"login":"Glowbal","id":5007509,"avatar_url":"https://avatars.githubusercontent.com/u/5007509?v=3","gravatar_id":"","url":"https://api.github.com/users/Glowbal","html_url":"https://github.com/Glowbal","followers_url":"https://api.github.com/users/Glowbal/followers","following_url":"https://api.github.com/users/Glowbal/following{/other_user}","gists_url":"https://api.github.com/users/Glowbal/gists{/gist_id}","starred_url":"https://api.github.com/users/Glowbal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Glowbal/subscriptions","organizations_url":"https://api.github.com/users/Glowbal/orgs","repos_url":"https://api.github.com/users/Glowbal/repos","events_url":"https://api.github.com/users/Glowbal/events{/privacy}","received_events_url":"https://api.github.com/users/Glowbal/received_events","type":"User","site_admin":false},"open_issues":74,"closed_issues":30,"state":"open","created_at":"2016-10-08T10:42:41Z","updated_at":"2016-11-13T01:41:05Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2016-07-07T11:08:27Z","updated_at":"2016-11-13T16:22:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/acemod/ACE3/pulls/4064","html_url":"https://github.com/acemod/ACE3/pull/4064","diff_url":"https://github.com/acemod/ACE3/pull/4064.diff","patch_url":"https://github.com/acemod/ACE3/pull/4064.patch"},"body":"### Rationale\n\nThe medical component is one of our most used and obvious features. At the moment, the size and complexity of this component is large and it is quite an obstacle for other devs and contributors to contribute to medical. \n\nThere are also a few issues with medical it self, where we have some underlaying issues and high maintance code, as well as some long outstanding issues (revive and prevent instant death being the obvious ones). \n\nThis rewrite aims to address both these topics.\n### Focus\n\nThe rewrite focus on the following:\n- Split up the medical component into seperate smaller logical components.\n- Combine the basic and advanced medical systems into one\n- Remove any inconsistencies within the code\n- A lot of the medical code has not been updated when BI introduced new script commands. The rewrite will address this as well.\n### Design\n#### Component diagram\n\n![pasted image at 2016_06_30 15_18](https://cloud.githubusercontent.com/assets/5007509/16651299/5af41f04-4443-11e6-83e0-7c3e413379e9.png)\n#### State Machine\n\nThe new medical rewrite will apply the medical state diagram for handling unit vitals and other tasks.\n\n![pasted image at 2016_06_30 14_54](https://cloud.githubusercontent.com/assets/5007509/16651304/62eb6e2e-4443-11e6-832a-5ca54b154307.png)\n### Backwards compatability\n\nI will try to maintain backwards compatability as much as possible, but because I am redesigning a lot of the parts within medical, this will not be 100% possible. Once the rewrite is done, we should list all functions that have changed.\n\nSettings will also change, but this will probably work out well if we switch to the CBA settings framework anyway.\n"},"comment":{"url":"https://api.github.com/repos/acemod/ACE3/issues/comments/260195810","html_url":"https://github.com/acemod/ACE3/pull/4064#issuecomment-260195810","issue_url":"https://api.github.com/repos/acemod/ACE3/issues/4064","id":260195810,"user":{"login":"SilentSpike","id":5459452,"avatar_url":"https://avatars.githubusercontent.com/u/5459452?v=3","gravatar_id":"","url":"https://api.github.com/users/SilentSpike","html_url":"https://github.com/SilentSpike","followers_url":"https://api.github.com/users/SilentSpike/followers","following_url":"https://api.github.com/users/SilentSpike/following{/other_user}","gists_url":"https://api.github.com/users/SilentSpike/gists{/gist_id}","starred_url":"https://api.github.com/users/SilentSpike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SilentSpike/subscriptions","organizations_url":"https://api.github.com/users/SilentSpike/orgs","repos_url":"https://api.github.com/users/SilentSpike/repos","events_url":"https://api.github.com/users/SilentSpike/events{/privacy}","received_events_url":"https://api.github.com/users/SilentSpike/received_events","type":"User","site_admin":false},"created_at":"2016-11-13T16:22:09Z","updated_at":"2016-11-13T16:22:09Z","body":"So, I'm confused by something:\r\n\r\n`(CBA_missionTime - _startTime) > (GVAR(maximumCardiacArrestTime) * 60)`\r\n\r\nIf this is the condition for death in cardiac arrest, surely it should be named `minimumCardiacArrestTime`? (I ran into this while in the process of implementing a setting of that name to replace `enableInstantDeath`)"}}
{"actor":{"display_login":"SilentSpike"}}