{"push_id":1456561411,"size":1,"distinct_size":1,"ref":"refs/heads/5.0.fb","head":"314828c973268ed5a77fbfecbdf8387b269179e3","before":"8a6d7a349a2158cef65f051cce9740885113783a","commits":[{"sha":"314828c973268ed5a77fbfecbdf8387b269179e3","author":{"name":"Mike Kolupaev","email":"6376bfc718a20bfd521bac178a9c687edd3f390a@fb.com"},"message":"Fixed a crash in debug build in flush_job.cc\n\nSummary:\nIt was doing `&range_del_iters[0]` on an empty vector. Even though the resulting pointer is never dereferenced, it's still bad for two reasons:\n* the practical reason: it crashes with `std::out_of_range` exception in our debug build,\n* the \"C++ standard lawyer\" reason: it's undefined behavior because, in `std::vector` implementation, it probably \"dereferences\" a null pointer, which is invalid even though it doesn't actually read the pointed memory, just converts a pointer into a reference (and then flush_job.cc converts it back to pointer); nullptr references are undefined behavior.\nCloses https://github.com/facebook/rocksdb/pull/1612\n\nDifferential Revision: D4265625\n\nPulled By: al13n321\n\nfbshipit-source-id: db26fb9","distinct":true,"url":"https://api.github.com/repos/facebook/rocksdb/commits/314828c973268ed5a77fbfecbdf8387b269179e3"}]}
{"actor":{"display_login":"yiwu-arbug"}}