{"action":"reopened","number":14907,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14907","id":67587262,"html_url":"https://github.com/NixOS/nixpkgs/pull/14907","diff_url":"https://github.com/NixOS/nixpkgs/pull/14907.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/14907.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/14907","number":14907,"state":"open","locked":false,"title":"setup.sh: substitute uses only valid bash names","user":{"login":"Profpatsch","id":3153638,"avatar_url":"https://avatars.githubusercontent.com/u/3153638?v=3","gravatar_id":"","url":"https://api.github.com/users/Profpatsch","html_url":"https://github.com/Profpatsch","followers_url":"https://api.github.com/users/Profpatsch/followers","following_url":"https://api.github.com/users/Profpatsch/following{/other_user}","gists_url":"https://api.github.com/users/Profpatsch/gists{/gist_id}","starred_url":"https://api.github.com/users/Profpatsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Profpatsch/subscriptions","organizations_url":"https://api.github.com/users/Profpatsch/orgs","repos_url":"https://api.github.com/users/Profpatsch/repos","events_url":"https://api.github.com/users/Profpatsch/events{/privacy}","received_events_url":"https://api.github.com/users/Profpatsch/received_events","type":"User","site_admin":false},"body":"bash variable names may only contain alphanumeric ASCII-symbols and _,\r\nand must not start with a number. Nix expression attribute names however\r\nmight contain nearly every character (in particular spaces and dashes).\r\n\r\nPreviously, a substitution that was not a valid bash name would be\r\nexpanded to an empty string. This commit introduce a check that throws\r\na (hopefully) helpful error when a wrong name is used in a substitution.\r\nThat was discovered by chexxor when it happened to me in a substitution.\r\n\r\nAdditionally, substituteAll previously filtered out all environment\r\nvariables starting with an uppercase letter. That increased the number\r\nof silently(!) ignored envvars (and nix attributes) even further.\r\nBecause it was quite arbitrary, it is removed.\r\n\r\n\r\nThis will trigger a mass rebuild.","created_at":"2016-04-22T23:45:40Z","updated_at":"2016-05-12T02:00:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e29d118eb40e69e8c25a9d77f62310466bd064e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14907/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14907/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/14907/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/a2d38bc7fc271ca5452ec3fd057bca3f737aa9ae","head":{"label":"Profpatsch:setup-bash-names","ref":"setup-bash-names","sha":"a2d38bc7fc271ca5452ec3fd057bca3f737aa9ae","user":{"login":"Profpatsch","id":3153638,"avatar_url":"https://avatars.githubusercontent.com/u/3153638?v=3","gravatar_id":"","url":"https://api.github.com/users/Profpatsch","html_url":"https://github.com/Profpatsch","followers_url":"https://api.github.com/users/Profpatsch/followers","following_url":"https://api.github.com/users/Profpatsch/following{/other_user}","gists_url":"https://api.github.com/users/Profpatsch/gists{/gist_id}","starred_url":"https://api.github.com/users/Profpatsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Profpatsch/subscriptions","organizations_url":"https://api.github.com/users/Profpatsch/orgs","repos_url":"https://api.github.com/users/Profpatsch/repos","events_url":"https://api.github.com/users/Profpatsch/events{/privacy}","received_events_url":"https://api.github.com/users/Profpatsch/received_events","type":"User","site_admin":false},"repo":{"id":29098746,"name":"nixpkgs","full_name":"Profpatsch/nixpkgs","owner":{"login":"Profpatsch","id":3153638,"avatar_url":"https://avatars.githubusercontent.com/u/3153638?v=3","gravatar_id":"","url":"https://api.github.com/users/Profpatsch","html_url":"https://github.com/Profpatsch","followers_url":"https://api.github.com/users/Profpatsch/followers","following_url":"https://api.github.com/users/Profpatsch/following{/other_user}","gists_url":"https://api.github.com/users/Profpatsch/gists{/gist_id}","starred_url":"https://api.github.com/users/Profpatsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Profpatsch/subscriptions","organizations_url":"https://api.github.com/users/Profpatsch/orgs","repos_url":"https://api.github.com/users/Profpatsch/repos","events_url":"https://api.github.com/users/Profpatsch/events{/privacy}","received_events_url":"https://api.github.com/users/Profpatsch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Profpatsch/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/Profpatsch/nixpkgs","forks_url":"https://api.github.com/repos/Profpatsch/nixpkgs/forks","keys_url":"https://api.github.com/repos/Profpatsch/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Profpatsch/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Profpatsch/nixpkgs/teams","hooks_url":"https://api.github.com/repos/Profpatsch/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/Profpatsch/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/Profpatsch/nixpkgs/events","assignees_url":"https://api.github.com/repos/Profpatsch/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/Profpatsch/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/Profpatsch/nixpkgs/tags","blobs_url":"https://api.github.com/repos/Profpatsch/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Profpatsch/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Profpatsch/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Profpatsch/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Profpatsch/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/Profpatsch/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/Profpatsch/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/Profpatsch/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/Profpatsch/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/Profpatsch/nixpkgs/subscription","commits_url":"https://api.github.com/repos/Profpatsch/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Profpatsch/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Profpatsch/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Profpatsch/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Profpatsch/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/Profpatsch/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Profpatsch/nixpkgs/merges","archive_url":"https://api.github.com/repos/Profpatsch/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Profpatsch/nixpkgs/downloads","issues_url":"https://api.github.com/repos/Profpatsch/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/Profpatsch/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/Profpatsch/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/Profpatsch/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Profpatsch/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/Profpatsch/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/Profpatsch/nixpkgs/deployments","created_at":"2015-01-11T17:00:42Z","updated_at":"2016-02-08T23:17:30Z","pushed_at":"2016-05-07T11:11:28Z","git_url":"git://github.com/Profpatsch/nixpkgs.git","ssh_url":"git@github.com:Profpatsch/nixpkgs.git","clone_url":"https://github.com/Profpatsch/nixpkgs.git","svn_url":"https://github.com/Profpatsch/nixpkgs","homepage":null,"size":329901,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"7f32a05baac41ca5472bb9bcc0b1d0ea7f48d7bb","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2016-05-10T11:17:43Z","pushed_at":"2016-05-12T01:45:56Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":536771,"stargazers_count":1085,"watchers_count":1085,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1392,"mirror_url":null,"open_issues_count":1337,"forks":1392,"open_issues":1337,"watchers":1085,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14907"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/14907"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/14907"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/14907/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14907/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14907/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/a2d38bc7fc271ca5452ec3fd057bca3f737aa9ae"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":68,"review_comments":0,"commits":2,"additions":17,"deletions":2,"changed_files":3}}