{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-native/pulls/comments/87310742","pull_request_review_id":7928555,"id":87310742,"diff_hunk":"@@ -188,13 +188,14 @@ var ListView = React.createClass({\n     /**\n      * (sectionData, sectionID) => renderable\n      *\n-     * If provided, a sticky header is rendered for this section.  The sticky\n-     * behavior means that it will scroll with the content at the top of the\n-     * section until it reaches the top of the screen, at which point it will\n-     * stick to the top until it is pushed off the screen by the next section\n-     * header.\n+     * If provided, a sticky header / footer is rendered for this section.\n+     * The sticky behavior means that it will scroll with the content at the\n+     * top or bottom of the section until it reaches the edge of the screen, at\n+     * which point it will stick to the top / bottom until it is pushed off\n+     * the screen by the next section header / footer.","path":"Libraries/CustomComponents/ListView/ListView.js","position":13,"original_position":13,"commit_id":"c9796c680947dca5b0b6255b33fe5a6ca1f0dbfa","original_commit_id":"c9796c680947dca5b0b6255b33fe5a6ca1f0dbfa","user":{"login":"hramos","id":165856,"avatar_url":"https://avatars.githubusercontent.com/u/165856?v=3","gravatar_id":"","url":"https://api.github.com/users/hramos","html_url":"https://github.com/hramos","followers_url":"https://api.github.com/users/hramos/followers","following_url":"https://api.github.com/users/hramos/following{/other_user}","gists_url":"https://api.github.com/users/hramos/gists{/gist_id}","starred_url":"https://api.github.com/users/hramos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hramos/subscriptions","organizations_url":"https://api.github.com/users/hramos/orgs","repos_url":"https://api.github.com/users/hramos/repos","events_url":"https://api.github.com/users/hramos/events{/privacy}","received_events_url":"https://api.github.com/users/hramos/received_events","type":"User","site_admin":false},"body":"FWIW I think it's fine to just add a second note to renderSectionFooter and make the edits there, rather than combine the two methods.","created_at":"2016-11-10T00:54:53Z","updated_at":"2016-11-10T00:54:53Z","html_url":"https://github.com/facebook/react-native/pull/9400#discussion_r87310742","pull_request_url":"https://api.github.com/repos/facebook/react-native/pulls/9400","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments/87310742"},"html":{"href":"https://github.com/facebook/react-native/pull/9400#discussion_r87310742"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-native/pulls/9400"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/9400","id":81252116,"html_url":"https://github.com/facebook/react-native/pull/9400","diff_url":"https://github.com/facebook/react-native/pull/9400.diff","patch_url":"https://github.com/facebook/react-native/pull/9400.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/9400","number":9400,"state":"open","locked":false,"title":"Listview section footers","user":{"login":"benthewhite","id":2536520,"avatar_url":"https://avatars.githubusercontent.com/u/2536520?v=3","gravatar_id":"","url":"https://api.github.com/users/benthewhite","html_url":"https://github.com/benthewhite","followers_url":"https://api.github.com/users/benthewhite/followers","following_url":"https://api.github.com/users/benthewhite/following{/other_user}","gists_url":"https://api.github.com/users/benthewhite/gists{/gist_id}","starred_url":"https://api.github.com/users/benthewhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benthewhite/subscriptions","organizations_url":"https://api.github.com/users/benthewhite/orgs","repos_url":"https://api.github.com/users/benthewhite/repos","events_url":"https://api.github.com/users/benthewhite/events{/privacy}","received_events_url":"https://api.github.com/users/benthewhite/received_events","type":"User","site_admin":false},"body":"**Summary**\n\nThis PR adds a `renderSectionFooter` prop to the ListView allowing section footers to be rendered in much the same way the section header is. The potential benefits for this component are much the same as a sectionHeader but for my specific use case allows an inverted ListView (via something like https://github.com/exponentjs/react-native-invertible-scroll-view) to have section \"headers\" that are actually the rendered footers (see https://github.com/exponentjs/react-native-invertible-scroll-view/issues/8).\n\nRendering a section footer was mentioned in https://github.com/facebook/react-native/issues/7994 and has a product pain at https://productpains.com/post/react-native/listview-section-footer\n\nMost of the code is identical to rendering `sectionHeaders` but with the logic correct to being pushed off the bottom of the screen rather than the top. Currently it uses the same ListViewDataSource functions as `sectionHeaders` for determining necessary updates.\n\n**Test plan**\nI have added a section footer to the ListViewPagingExample that demonstrates this working.\n","created_at":"2016-08-14T19:29:59Z","updated_at":"2016-11-10T00:54:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"179cb49f5ee88bfd4de7c0fa7c32000f32a85ae1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/9400/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/9400/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/9400/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/c9796c680947dca5b0b6255b33fe5a6ca1f0dbfa","head":{"label":"benthewhite:listview-section-footers","ref":"listview-section-footers","sha":"c9796c680947dca5b0b6255b33fe5a6ca1f0dbfa","user":{"login":"benthewhite","id":2536520,"avatar_url":"https://avatars.githubusercontent.com/u/2536520?v=3","gravatar_id":"","url":"https://api.github.com/users/benthewhite","html_url":"https://github.com/benthewhite","followers_url":"https://api.github.com/users/benthewhite/followers","following_url":"https://api.github.com/users/benthewhite/following{/other_user}","gists_url":"https://api.github.com/users/benthewhite/gists{/gist_id}","starred_url":"https://api.github.com/users/benthewhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benthewhite/subscriptions","organizations_url":"https://api.github.com/users/benthewhite/orgs","repos_url":"https://api.github.com/users/benthewhite/repos","events_url":"https://api.github.com/users/benthewhite/events{/privacy}","received_events_url":"https://api.github.com/users/benthewhite/received_events","type":"User","site_admin":false},"repo":{"id":65681750,"name":"react-native","full_name":"benthewhite/react-native","owner":{"login":"benthewhite","id":2536520,"avatar_url":"https://avatars.githubusercontent.com/u/2536520?v=3","gravatar_id":"","url":"https://api.github.com/users/benthewhite","html_url":"https://github.com/benthewhite","followers_url":"https://api.github.com/users/benthewhite/followers","following_url":"https://api.github.com/users/benthewhite/following{/other_user}","gists_url":"https://api.github.com/users/benthewhite/gists{/gist_id}","starred_url":"https://api.github.com/users/benthewhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benthewhite/subscriptions","organizations_url":"https://api.github.com/users/benthewhite/orgs","repos_url":"https://api.github.com/users/benthewhite/repos","events_url":"https://api.github.com/users/benthewhite/events{/privacy}","received_events_url":"https://api.github.com/users/benthewhite/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benthewhite/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/benthewhite/react-native","forks_url":"https://api.github.com/repos/benthewhite/react-native/forks","keys_url":"https://api.github.com/repos/benthewhite/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benthewhite/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benthewhite/react-native/teams","hooks_url":"https://api.github.com/repos/benthewhite/react-native/hooks","issue_events_url":"https://api.github.com/repos/benthewhite/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/benthewhite/react-native/events","assignees_url":"https://api.github.com/repos/benthewhite/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/benthewhite/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/benthewhite/react-native/tags","blobs_url":"https://api.github.com/repos/benthewhite/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benthewhite/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benthewhite/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/benthewhite/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benthewhite/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/benthewhite/react-native/languages","stargazers_url":"https://api.github.com/repos/benthewhite/react-native/stargazers","contributors_url":"https://api.github.com/repos/benthewhite/react-native/contributors","subscribers_url":"https://api.github.com/repos/benthewhite/react-native/subscribers","subscription_url":"https://api.github.com/repos/benthewhite/react-native/subscription","commits_url":"https://api.github.com/repos/benthewhite/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/benthewhite/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/benthewhite/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/benthewhite/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/benthewhite/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/benthewhite/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benthewhite/react-native/merges","archive_url":"https://api.github.com/repos/benthewhite/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benthewhite/react-native/downloads","issues_url":"https://api.github.com/repos/benthewhite/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/benthewhite/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/benthewhite/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/benthewhite/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benthewhite/react-native/labels{/name}","releases_url":"https://api.github.com/repos/benthewhite/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/benthewhite/react-native/deployments","created_at":"2016-08-14T18:57:58Z","updated_at":"2016-08-14T18:58:06Z","pushed_at":"2016-08-15T08:30:21Z","git_url":"git://github.com/benthewhite/react-native.git","ssh_url":"git@github.com:benthewhite/react-native.git","clone_url":"https://github.com/benthewhite/react-native.git","svn_url":"https://github.com/benthewhite/react-native","homepage":"http://facebook.github.io/react-native/","size":79199,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"d6003677159d1f68bfa6c91c64b6acc008b36834","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-11-10T00:33:33Z","pushed_at":"2016-11-10T00:37:00Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":153792,"stargazers_count":40157,"watchers_count":40157,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9043,"mirror_url":null,"open_issues_count":979,"forks":9043,"open_issues":979,"watchers":40157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/9400"},"html":{"href":"https://github.com/facebook/react-native/pull/9400"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/9400"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/9400/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/9400/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/9400/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/c9796c680947dca5b0b6255b33fe5a6ca1f0dbfa"}}}}
{"actor":{"display_login":"hramos"}}