{"action":"created","comment":{"url":"https://api.github.com/repos/inliniac/suricata/pulls/comments/60225662","id":60225662,"diff_hunk":"@@ -1388,14 +1569,188 @@ frame size: TPACKET_ALIGN(snaplen + TPACKET_ALIGN(TPACKET_ALIGN(tp_hdrlen) + siz\n     return 1;\n }\n \n+#ifdef HAVE_TPACKET_V3\n+static int AFPComputeRingParamsV3(AFPThreadVars *ptv)\n+{\n+    ptv->req3.tp_block_size = ptv->block_size;\n+    ptv->req3.tp_frame_size = 2048;\n+    int frames_per_block = ptv->req3.tp_block_size / ptv->req3.tp_frame_size;\n+    if (frames_per_block == 0) {\n+        SCLogInfo(\"frame size to big\");","path":"src/source-af-packet.c","position":530,"original_position":530,"commit_id":"6bdd89215c19606522651f641f6cc43e233ba2c9","original_commit_id":"6bdd89215c19606522651f641f6cc43e233ba2c9","user":{"login":"regit","id":308616,"avatar_url":"https://avatars.githubusercontent.com/u/308616?v=3","gravatar_id":"","url":"https://api.github.com/users/regit","html_url":"https://github.com/regit","followers_url":"https://api.github.com/users/regit/followers","following_url":"https://api.github.com/users/regit/following{/other_user}","gists_url":"https://api.github.com/users/regit/gists{/gist_id}","starred_url":"https://api.github.com/users/regit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regit/subscriptions","organizations_url":"https://api.github.com/users/regit/orgs","repos_url":"https://api.github.com/users/regit/repos","events_url":"https://api.github.com/users/regit/events{/privacy}","received_events_url":"https://api.github.com/users/regit/received_events","type":"User","site_admin":false},"body":"Right.","created_at":"2016-04-19T13:01:21Z","updated_at":"2016-04-19T13:01:21Z","html_url":"https://github.com/inliniac/suricata/pull/2018#discussion_r60225662","pull_request_url":"https://api.github.com/repos/inliniac/suricata/pulls/2018","_links":{"self":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/comments/60225662"},"html":{"href":"https://github.com/inliniac/suricata/pull/2018#discussion_r60225662"},"pull_request":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/2018"}}},"pull_request":{"url":"https://api.github.com/repos/inliniac/suricata/pulls/2018","id":66850101,"html_url":"https://github.com/inliniac/suricata/pull/2018","diff_url":"https://github.com/inliniac/suricata/pull/2018.diff","patch_url":"https://github.com/inliniac/suricata/pull/2018.patch","issue_url":"https://api.github.com/repos/inliniac/suricata/issues/2018","number":2018,"state":"open","locked":false,"title":"Tpacket v3 6","user":{"login":"regit","id":308616,"avatar_url":"https://avatars.githubusercontent.com/u/308616?v=3","gravatar_id":"","url":"https://api.github.com/users/regit","html_url":"https://github.com/regit","followers_url":"https://api.github.com/users/regit/followers","following_url":"https://api.github.com/users/regit/following{/other_user}","gists_url":"https://api.github.com/users/regit/gists{/gist_id}","starred_url":"https://api.github.com/users/regit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regit/subscriptions","organizations_url":"https://api.github.com/users/regit/orgs","repos_url":"https://api.github.com/users/regit/repos","events_url":"https://api.github.com/users/regit/events{/privacy}","received_events_url":"https://api.github.com/users/regit/received_events","type":"User","site_admin":false},"body":"Address comments made on #2015.\r\n\r\nPR builds:\r\n- PR regit: https://buildbot.openinfosecfoundation.org/builders/regit/builds/162\r\n- PR regit-pcap: https://buildbot.openinfosecfoundation.org/builders/regit-pcap/builds/158","created_at":"2016-04-18T13:08:49Z","updated_at":"2016-04-19T13:01:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c6254349026976c303ef36163ba2765c0208086","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/inliniac/suricata/pulls/2018/commits","review_comments_url":"https://api.github.com/repos/inliniac/suricata/pulls/2018/comments","review_comment_url":"https://api.github.com/repos/inliniac/suricata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inliniac/suricata/issues/2018/comments","statuses_url":"https://api.github.com/repos/inliniac/suricata/statuses/6bdd89215c19606522651f641f6cc43e233ba2c9","head":{"label":"regit:tpacket_v3-6","ref":"tpacket_v3-6","sha":"6bdd89215c19606522651f641f6cc43e233ba2c9","user":{"login":"regit","id":308616,"avatar_url":"https://avatars.githubusercontent.com/u/308616?v=3","gravatar_id":"","url":"https://api.github.com/users/regit","html_url":"https://github.com/regit","followers_url":"https://api.github.com/users/regit/followers","following_url":"https://api.github.com/users/regit/following{/other_user}","gists_url":"https://api.github.com/users/regit/gists{/gist_id}","starred_url":"https://api.github.com/users/regit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regit/subscriptions","organizations_url":"https://api.github.com/users/regit/orgs","repos_url":"https://api.github.com/users/regit/repos","events_url":"https://api.github.com/users/regit/events{/privacy}","received_events_url":"https://api.github.com/users/regit/received_events","type":"User","site_admin":false},"repo":{"id":5410368,"name":"suricata","full_name":"regit/suricata","owner":{"login":"regit","id":308616,"avatar_url":"https://avatars.githubusercontent.com/u/308616?v=3","gravatar_id":"","url":"https://api.github.com/users/regit","html_url":"https://github.com/regit","followers_url":"https://api.github.com/users/regit/followers","following_url":"https://api.github.com/users/regit/following{/other_user}","gists_url":"https://api.github.com/users/regit/gists{/gist_id}","starred_url":"https://api.github.com/users/regit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regit/subscriptions","organizations_url":"https://api.github.com/users/regit/orgs","repos_url":"https://api.github.com/users/regit/repos","events_url":"https://api.github.com/users/regit/events{/privacy}","received_events_url":"https://api.github.com/users/regit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/regit/suricata","description":"My personal development tree for Suricata.","fork":true,"url":"https://api.github.com/repos/regit/suricata","forks_url":"https://api.github.com/repos/regit/suricata/forks","keys_url":"https://api.github.com/repos/regit/suricata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/regit/suricata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/regit/suricata/teams","hooks_url":"https://api.github.com/repos/regit/suricata/hooks","issue_events_url":"https://api.github.com/repos/regit/suricata/issues/events{/number}","events_url":"https://api.github.com/repos/regit/suricata/events","assignees_url":"https://api.github.com/repos/regit/suricata/assignees{/user}","branches_url":"https://api.github.com/repos/regit/suricata/branches{/branch}","tags_url":"https://api.github.com/repos/regit/suricata/tags","blobs_url":"https://api.github.com/repos/regit/suricata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/regit/suricata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/regit/suricata/git/refs{/sha}","trees_url":"https://api.github.com/repos/regit/suricata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/regit/suricata/statuses/{sha}","languages_url":"https://api.github.com/repos/regit/suricata/languages","stargazers_url":"https://api.github.com/repos/regit/suricata/stargazers","contributors_url":"https://api.github.com/repos/regit/suricata/contributors","subscribers_url":"https://api.github.com/repos/regit/suricata/subscribers","subscription_url":"https://api.github.com/repos/regit/suricata/subscription","commits_url":"https://api.github.com/repos/regit/suricata/commits{/sha}","git_commits_url":"https://api.github.com/repos/regit/suricata/git/commits{/sha}","comments_url":"https://api.github.com/repos/regit/suricata/comments{/number}","issue_comment_url":"https://api.github.com/repos/regit/suricata/issues/comments{/number}","contents_url":"https://api.github.com/repos/regit/suricata/contents/{+path}","compare_url":"https://api.github.com/repos/regit/suricata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/regit/suricata/merges","archive_url":"https://api.github.com/repos/regit/suricata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/regit/suricata/downloads","issues_url":"https://api.github.com/repos/regit/suricata/issues{/number}","pulls_url":"https://api.github.com/repos/regit/suricata/pulls{/number}","milestones_url":"https://api.github.com/repos/regit/suricata/milestones{/number}","notifications_url":"https://api.github.com/repos/regit/suricata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/regit/suricata/labels{/name}","releases_url":"https://api.github.com/repos/regit/suricata/releases{/id}","deployments_url":"https://api.github.com/repos/regit/suricata/deployments","created_at":"2012-08-14T08:45:02Z","updated_at":"2016-04-11T00:50:36Z","pushed_at":"2016-04-18T12:36:01Z","git_url":"git://github.com/regit/suricata.git","ssh_url":"git@github.com:regit/suricata.git","clone_url":"https://github.com/regit/suricata.git","svn_url":"https://github.com/regit/suricata","homepage":"","size":41212,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":0,"forks":13,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inliniac:master","ref":"master","sha":"3f16ebe4762775e4d11c2d63d0153643016e4012","user":{"login":"inliniac","id":719366,"avatar_url":"https://avatars.githubusercontent.com/u/719366?v=3","gravatar_id":"","url":"https://api.github.com/users/inliniac","html_url":"https://github.com/inliniac","followers_url":"https://api.github.com/users/inliniac/followers","following_url":"https://api.github.com/users/inliniac/following{/other_user}","gists_url":"https://api.github.com/users/inliniac/gists{/gist_id}","starred_url":"https://api.github.com/users/inliniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inliniac/subscriptions","organizations_url":"https://api.github.com/users/inliniac/orgs","repos_url":"https://api.github.com/users/inliniac/repos","events_url":"https://api.github.com/users/inliniac/events{/privacy}","received_events_url":"https://api.github.com/users/inliniac/received_events","type":"User","site_admin":false},"repo":{"id":5410234,"name":"suricata","full_name":"inliniac/suricata","owner":{"login":"inliniac","id":719366,"avatar_url":"https://avatars.githubusercontent.com/u/719366?v=3","gravatar_id":"","url":"https://api.github.com/users/inliniac","html_url":"https://github.com/inliniac","followers_url":"https://api.github.com/users/inliniac/followers","following_url":"https://api.github.com/users/inliniac/following{/other_user}","gists_url":"https://api.github.com/users/inliniac/gists{/gist_id}","starred_url":"https://api.github.com/users/inliniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inliniac/subscriptions","organizations_url":"https://api.github.com/users/inliniac/orgs","repos_url":"https://api.github.com/users/inliniac/repos","events_url":"https://api.github.com/users/inliniac/events{/privacy}","received_events_url":"https://api.github.com/users/inliniac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/inliniac/suricata","description":"Mirror of the official OISF Suricata git repository","fork":false,"url":"https://api.github.com/repos/inliniac/suricata","forks_url":"https://api.github.com/repos/inliniac/suricata/forks","keys_url":"https://api.github.com/repos/inliniac/suricata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inliniac/suricata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inliniac/suricata/teams","hooks_url":"https://api.github.com/repos/inliniac/suricata/hooks","issue_events_url":"https://api.github.com/repos/inliniac/suricata/issues/events{/number}","events_url":"https://api.github.com/repos/inliniac/suricata/events","assignees_url":"https://api.github.com/repos/inliniac/suricata/assignees{/user}","branches_url":"https://api.github.com/repos/inliniac/suricata/branches{/branch}","tags_url":"https://api.github.com/repos/inliniac/suricata/tags","blobs_url":"https://api.github.com/repos/inliniac/suricata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inliniac/suricata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inliniac/suricata/git/refs{/sha}","trees_url":"https://api.github.com/repos/inliniac/suricata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inliniac/suricata/statuses/{sha}","languages_url":"https://api.github.com/repos/inliniac/suricata/languages","stargazers_url":"https://api.github.com/repos/inliniac/suricata/stargazers","contributors_url":"https://api.github.com/repos/inliniac/suricata/contributors","subscribers_url":"https://api.github.com/repos/inliniac/suricata/subscribers","subscription_url":"https://api.github.com/repos/inliniac/suricata/subscription","commits_url":"https://api.github.com/repos/inliniac/suricata/commits{/sha}","git_commits_url":"https://api.github.com/repos/inliniac/suricata/git/commits{/sha}","comments_url":"https://api.github.com/repos/inliniac/suricata/comments{/number}","issue_comment_url":"https://api.github.com/repos/inliniac/suricata/issues/comments{/number}","contents_url":"https://api.github.com/repos/inliniac/suricata/contents/{+path}","compare_url":"https://api.github.com/repos/inliniac/suricata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inliniac/suricata/merges","archive_url":"https://api.github.com/repos/inliniac/suricata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inliniac/suricata/downloads","issues_url":"https://api.github.com/repos/inliniac/suricata/issues{/number}","pulls_url":"https://api.github.com/repos/inliniac/suricata/pulls{/number}","milestones_url":"https://api.github.com/repos/inliniac/suricata/milestones{/number}","notifications_url":"https://api.github.com/repos/inliniac/suricata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inliniac/suricata/labels{/name}","releases_url":"https://api.github.com/repos/inliniac/suricata/releases{/id}","deployments_url":"https://api.github.com/repos/inliniac/suricata/deployments","created_at":"2012-08-14T08:30:06Z","updated_at":"2016-04-10T05:27:14Z","pushed_at":"2016-04-18T13:08:49Z","git_url":"git://github.com/inliniac/suricata.git","ssh_url":"git@github.com:inliniac/suricata.git","clone_url":"https://github.com/inliniac/suricata.git","svn_url":"https://github.com/inliniac/suricata","homepage":"http://suricata-ids.org/","size":59056,"stargazers_count":258,"watchers_count":258,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":235,"mirror_url":null,"open_issues_count":24,"forks":235,"open_issues":24,"watchers":258,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/2018"},"html":{"href":"https://github.com/inliniac/suricata/pull/2018"},"issue":{"href":"https://api.github.com/repos/inliniac/suricata/issues/2018"},"comments":{"href":"https://api.github.com/repos/inliniac/suricata/issues/2018/comments"},"review_comments":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/2018/comments"},"review_comment":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/2018/commits"},"statuses":{"href":"https://api.github.com/repos/inliniac/suricata/statuses/6bdd89215c19606522651f641f6cc43e233ba2c9"}}}}