{"action":"opened","number":3452,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/3452","id":77011968,"html_url":"https://github.com/apple/swift/pull/3452","diff_url":"https://github.com/apple/swift/pull/3452.diff","patch_url":"https://github.com/apple/swift/pull/3452.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/3452","number":3452,"state":"open","locked":false,"title":"[stdlib] Remove _StringCore from UTF8View.Index","user":{"login":"natecook1000","id":7053374,"avatar_url":"https://avatars.githubusercontent.com/u/7053374?v=3","gravatar_id":"","url":"https://api.github.com/users/natecook1000","html_url":"https://github.com/natecook1000","followers_url":"https://api.github.com/users/natecook1000/followers","following_url":"https://api.github.com/users/natecook1000/following{/other_user}","gists_url":"https://api.github.com/users/natecook1000/gists{/gist_id}","starred_url":"https://api.github.com/users/natecook1000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natecook1000/subscriptions","organizations_url":"https://api.github.com/users/natecook1000/orgs","repos_url":"https://api.github.com/users/natecook1000/repos","events_url":"https://api.github.com/users/natecook1000/events{/privacy}","received_events_url":"https://api.github.com/users/natecook1000/received_events","type":"User","site_admin":false},"body":"<!-- Please complete this template before creating the pull request. -->\r\n#### What's in this pull request?\r\nThis removes the `_core` property from `UTF8View.Index` instances. I don't think this will reduce as many unnecessary copies as the same change on `UnicodeScalarView.Index` since `UT8View` isn't mutable, but simplifying the index should be a net plus. This also fixes the `Comparable` conformance of the index and adds a test that string view indices are comparable in ascending order. (This isn't currently the case for the `utf8` view.)\r\n\r\n#### Resolved bug number: n/a\r\n<!-- If this pull request resolves any bugs from Swift bug tracker -->\r\n\r\n* * * *\r\n\r\n<!-- This selection should only be completed by Swift admin -->\r\nBefore merging this pull request to apple/swift repository:\r\n- [ ] Test pull request on Swift continuous integration.\r\n\r\n<details>\r\n  <summary>Triggering Swift CI</summary>\r\n\r\nThe swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:\r\n\r\n**Smoke Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please smoke test\r\n        All supported platforms     | @swift-ci Please smoke test and merge\r\n        OS X platform               | @swift-ci Please smoke test OS X platform\r\n        Linux platform              | @swift-ci Please smoke test Linux platform\r\n\r\n**Validation Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please test\r\n        All supported platforms     | @swift-ci Please test and merge\r\n        OS X platform               | @swift-ci Please test OS X platform\r\n        OS X platform               | @swift-ci Please benchmark\r\n        Linux platform              | @swift-ci Please test Linux platform\r\n\r\n\r\n**Lint Testing**\r\n\r\n        Language     | Comment\r\n        ------------ | -------------\r\n        Python       | @swift-ci Please Python lint\r\n\r\nNote: Only members of the Apple organization can trigger swift-ci.\r\n</details>\r\n<!-- Thank you for your contribution to Swift! -->","created_at":"2016-07-11T19:48:56Z","updated_at":"2016-07-11T19:48:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/3452/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/3452/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/3452/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/6f2023f6916bb6b6ea21894075d920733c91fb80","head":{"label":"natecook1000:nc-utf8index-nocore","ref":"nc-utf8index-nocore","sha":"6f2023f6916bb6b6ea21894075d920733c91fb80","user":{"login":"natecook1000","id":7053374,"avatar_url":"https://avatars.githubusercontent.com/u/7053374?v=3","gravatar_id":"","url":"https://api.github.com/users/natecook1000","html_url":"https://github.com/natecook1000","followers_url":"https://api.github.com/users/natecook1000/followers","following_url":"https://api.github.com/users/natecook1000/following{/other_user}","gists_url":"https://api.github.com/users/natecook1000/gists{/gist_id}","starred_url":"https://api.github.com/users/natecook1000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natecook1000/subscriptions","organizations_url":"https://api.github.com/users/natecook1000/orgs","repos_url":"https://api.github.com/users/natecook1000/repos","events_url":"https://api.github.com/users/natecook1000/events{/privacy}","received_events_url":"https://api.github.com/users/natecook1000/received_events","type":"User","site_admin":false},"repo":{"id":47363293,"name":"swift","full_name":"natecook1000/swift","owner":{"login":"natecook1000","id":7053374,"avatar_url":"https://avatars.githubusercontent.com/u/7053374?v=3","gravatar_id":"","url":"https://api.github.com/users/natecook1000","html_url":"https://github.com/natecook1000","followers_url":"https://api.github.com/users/natecook1000/followers","following_url":"https://api.github.com/users/natecook1000/following{/other_user}","gists_url":"https://api.github.com/users/natecook1000/gists{/gist_id}","starred_url":"https://api.github.com/users/natecook1000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natecook1000/subscriptions","organizations_url":"https://api.github.com/users/natecook1000/orgs","repos_url":"https://api.github.com/users/natecook1000/repos","events_url":"https://api.github.com/users/natecook1000/events{/privacy}","received_events_url":"https://api.github.com/users/natecook1000/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/natecook1000/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/natecook1000/swift","forks_url":"https://api.github.com/repos/natecook1000/swift/forks","keys_url":"https://api.github.com/repos/natecook1000/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natecook1000/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natecook1000/swift/teams","hooks_url":"https://api.github.com/repos/natecook1000/swift/hooks","issue_events_url":"https://api.github.com/repos/natecook1000/swift/issues/events{/number}","events_url":"https://api.github.com/repos/natecook1000/swift/events","assignees_url":"https://api.github.com/repos/natecook1000/swift/assignees{/user}","branches_url":"https://api.github.com/repos/natecook1000/swift/branches{/branch}","tags_url":"https://api.github.com/repos/natecook1000/swift/tags","blobs_url":"https://api.github.com/repos/natecook1000/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natecook1000/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natecook1000/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/natecook1000/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natecook1000/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/natecook1000/swift/languages","stargazers_url":"https://api.github.com/repos/natecook1000/swift/stargazers","contributors_url":"https://api.github.com/repos/natecook1000/swift/contributors","subscribers_url":"https://api.github.com/repos/natecook1000/swift/subscribers","subscription_url":"https://api.github.com/repos/natecook1000/swift/subscription","commits_url":"https://api.github.com/repos/natecook1000/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/natecook1000/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/natecook1000/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/natecook1000/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/natecook1000/swift/contents/{+path}","compare_url":"https://api.github.com/repos/natecook1000/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natecook1000/swift/merges","archive_url":"https://api.github.com/repos/natecook1000/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natecook1000/swift/downloads","issues_url":"https://api.github.com/repos/natecook1000/swift/issues{/number}","pulls_url":"https://api.github.com/repos/natecook1000/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/natecook1000/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/natecook1000/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natecook1000/swift/labels{/name}","releases_url":"https://api.github.com/repos/natecook1000/swift/releases{/id}","deployments_url":"https://api.github.com/repos/natecook1000/swift/deployments","created_at":"2015-12-03T21:55:37Z","updated_at":"2016-01-19T22:00:10Z","pushed_at":"2016-07-11T19:44:49Z","git_url":"git://github.com/natecook1000/swift.git","ssh_url":"git@github.com:natecook1000/swift.git","clone_url":"https://github.com/natecook1000/swift.git","svn_url":"https://github.com/natecook1000/swift","homepage":"","size":101483,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"cd59716c783d69e7f8462062cad0f2a40f33e727","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-07-11T18:04:20Z","pushed_at":"2016-07-11T19:38:17Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":160204,"stargazers_count":32248,"watchers_count":32248,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4470,"mirror_url":null,"open_issues_count":94,"forks":4470,"open_issues":94,"watchers":32248,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/3452"},"html":{"href":"https://github.com/apple/swift/pull/3452"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/3452"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/3452/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/3452/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/3452/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/6f2023f6916bb6b6ea21894075d920733c91fb80"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":79,"deletions":31,"changed_files":4}}
{"actor":{"display_login":"natecook1000"}}