{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/pulls/comments/83687092","pull_request_review_id":4514431,"id":83687092,"diff_hunk":"@@ -622,8 +624,8 @@ void ValidateRetryPolicyCustom()\n         {\n             // Rebuild connection string with a nonexistent entity.\n             var conSettings = new EventHubsConnectionStringBuilder(this.connectionString);","path":"test/Microsoft.Azure.EventHubs.UnitTests/EventHubClientTests.cs","position":19,"original_position":19,"commit_id":"9e21ace942536252cc37f020f6558d95c1b9481c","original_commit_id":"9e21ace942536252cc37f020f6558d95c1b9481c","user":{"login":"serkantkaraca","id":16924470,"avatar_url":"https://avatars.githubusercontent.com/u/16924470?v=3","gravatar_id":"","url":"https://api.github.com/users/serkantkaraca","html_url":"https://github.com/serkantkaraca","followers_url":"https://api.github.com/users/serkantkaraca/followers","following_url":"https://api.github.com/users/serkantkaraca/following{/other_user}","gists_url":"https://api.github.com/users/serkantkaraca/gists{/gist_id}","starred_url":"https://api.github.com/users/serkantkaraca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serkantkaraca/subscriptions","organizations_url":"https://api.github.com/users/serkantkaraca/orgs","repos_url":"https://api.github.com/users/serkantkaraca/repos","events_url":"https://api.github.com/users/serkantkaraca/events{/privacy}","received_events_url":"https://api.github.com/users/serkantkaraca/received_events","type":"User","site_admin":false},"body":"Good catch!\r\n\r\n---\r\nIn reply to: [83526893](https://github.com/Azure/azure-event-hubs-dotnet/pull/22#discussion_r83526893) [](ancestors = 83526893)","created_at":"2016-10-17T16:57:07Z","updated_at":"2016-10-17T16:57:07Z","html_url":"https://github.com/Azure/azure-event-hubs-dotnet/pull/22#discussion_r83687092","pull_request_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/pulls/comments/83687092"},"html":{"href":"https://github.com/Azure/azure-event-hubs-dotnet/pull/22#discussion_r83687092"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/pulls/22","id":89438530,"html_url":"https://github.com/Azure/azure-event-hubs-dotnet/pull/22","diff_url":"https://github.com/Azure/azure-event-hubs-dotnet/pull/22.diff","patch_url":"https://github.com/Azure/azure-event-hubs-dotnet/pull/22.patch","issue_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/issues/22","number":22,"state":"open","locked":false,"title":"Fix eph unit tests and exception contract","user":{"login":"serkantkaraca","id":16924470,"avatar_url":"https://avatars.githubusercontent.com/u/16924470?v=3","gravatar_id":"","url":"https://api.github.com/users/serkantkaraca","html_url":"https://github.com/serkantkaraca","followers_url":"https://api.github.com/users/serkantkaraca/followers","following_url":"https://api.github.com/users/serkantkaraca/following{/other_user}","gists_url":"https://api.github.com/users/serkantkaraca/gists{/gist_id}","starred_url":"https://api.github.com/users/serkantkaraca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serkantkaraca/subscriptions","organizations_url":"https://api.github.com/users/serkantkaraca/orgs","repos_url":"https://api.github.com/users/serkantkaraca/repos","events_url":"https://api.github.com/users/serkantkaraca/events{/privacy}","received_events_url":"https://api.github.com/users/serkantkaraca/received_events","type":"User","site_admin":false},"body":"- EPH tests to unregister the active hosts at the end of the run otherwise existing hosts keep interfering with next tests. This is addressing the issue tracked by https://github.com/Azure/azure-event-hubs-dotnet/issues/21\r\n- Improving exception contrat to handle nonexistent consumer group case.","created_at":"2016-10-14T19:11:00Z","updated_at":"2016-10-17T16:57:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17fc4ea0241be88b06549fa3882b24f501c09ce2","assignee":{"login":"hmlam","id":1750079,"avatar_url":"https://avatars.githubusercontent.com/u/1750079?v=3","gravatar_id":"","url":"https://api.github.com/users/hmlam","html_url":"https://github.com/hmlam","followers_url":"https://api.github.com/users/hmlam/followers","following_url":"https://api.github.com/users/hmlam/following{/other_user}","gists_url":"https://api.github.com/users/hmlam/gists{/gist_id}","starred_url":"https://api.github.com/users/hmlam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmlam/subscriptions","organizations_url":"https://api.github.com/users/hmlam/orgs","repos_url":"https://api.github.com/users/hmlam/repos","events_url":"https://api.github.com/users/hmlam/events{/privacy}","received_events_url":"https://api.github.com/users/hmlam/received_events","type":"User","site_admin":false},"assignees":[{"login":"hmlam","id":1750079,"avatar_url":"https://avatars.githubusercontent.com/u/1750079?v=3","gravatar_id":"","url":"https://api.github.com/users/hmlam","html_url":"https://github.com/hmlam","followers_url":"https://api.github.com/users/hmlam/followers","following_url":"https://api.github.com/users/hmlam/following{/other_user}","gists_url":"https://api.github.com/users/hmlam/gists{/gist_id}","starred_url":"https://api.github.com/users/hmlam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmlam/subscriptions","organizations_url":"https://api.github.com/users/hmlam/orgs","repos_url":"https://api.github.com/users/hmlam/repos","events_url":"https://api.github.com/users/hmlam/events{/privacy}","received_events_url":"https://api.github.com/users/hmlam/received_events","type":"User","site_admin":false},{"login":"jtaubensee","id":8162917,"avatar_url":"https://avatars.githubusercontent.com/u/8162917?v=3","gravatar_id":"","url":"https://api.github.com/users/jtaubensee","html_url":"https://github.com/jtaubensee","followers_url":"https://api.github.com/users/jtaubensee/followers","following_url":"https://api.github.com/users/jtaubensee/following{/other_user}","gists_url":"https://api.github.com/users/jtaubensee/gists{/gist_id}","starred_url":"https://api.github.com/users/jtaubensee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtaubensee/subscriptions","organizations_url":"https://api.github.com/users/jtaubensee/orgs","repos_url":"https://api.github.com/users/jtaubensee/repos","events_url":"https://api.github.com/users/jtaubensee/events{/privacy}","received_events_url":"https://api.github.com/users/jtaubensee/received_events","type":"User","site_admin":false},{"login":"sjkwak","id":8718605,"avatar_url":"https://avatars.githubusercontent.com/u/8718605?v=3","gravatar_id":"","url":"https://api.github.com/users/sjkwak","html_url":"https://github.com/sjkwak","followers_url":"https://api.github.com/users/sjkwak/followers","following_url":"https://api.github.com/users/sjkwak/following{/other_user}","gists_url":"https://api.github.com/users/sjkwak/gists{/gist_id}","starred_url":"https://api.github.com/users/sjkwak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjkwak/subscriptions","organizations_url":"https://api.github.com/users/sjkwak/orgs","repos_url":"https://api.github.com/users/sjkwak/repos","events_url":"https://api.github.com/users/sjkwak/events{/privacy}","received_events_url":"https://api.github.com/users/sjkwak/received_events","type":"User","site_admin":false},{"login":"serkantkaraca","id":16924470,"avatar_url":"https://avatars.githubusercontent.com/u/16924470?v=3","gravatar_id":"","url":"https://api.github.com/users/serkantkaraca","html_url":"https://github.com/serkantkaraca","followers_url":"https://api.github.com/users/serkantkaraca/followers","following_url":"https://api.github.com/users/serkantkaraca/following{/other_user}","gists_url":"https://api.github.com/users/serkantkaraca/gists{/gist_id}","starred_url":"https://api.github.com/users/serkantkaraca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serkantkaraca/subscriptions","organizations_url":"https://api.github.com/users/serkantkaraca/orgs","repos_url":"https://api.github.com/users/serkantkaraca/repos","events_url":"https://api.github.com/users/serkantkaraca/events{/privacy}","received_events_url":"https://api.github.com/users/serkantkaraca/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/pulls/22/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/pulls/22/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/issues/22/comments","statuses_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/statuses/9e21ace942536252cc37f020f6558d95c1b9481c","head":{"label":"Azure:FixEphUnitTestsAndExceptionContract","ref":"FixEphUnitTestsAndExceptionContract","sha":"9e21ace942536252cc37f020f6558d95c1b9481c","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":68422935,"name":"azure-event-hubs-dotnet","full_name":"Azure/azure-event-hubs-dotnet","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-event-hubs-dotnet","description":".NET Standard client library for Azure Event Hubs","fork":false,"url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet","forks_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/forks","keys_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/teams","hooks_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/events","assignees_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/tags","blobs_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/subscription","commits_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/merges","archive_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/downloads","issues_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/deployments","created_at":"2016-09-17T00:21:00Z","updated_at":"2016-10-16T18:52:25Z","pushed_at":"2016-10-15T07:09:11Z","git_url":"git://github.com/Azure/azure-event-hubs-dotnet.git","ssh_url":"git@github.com:Azure/azure-event-hubs-dotnet.git","clone_url":"https://github.com/Azure/azure-event-hubs-dotnet.git","svn_url":"https://github.com/Azure/azure-event-hubs-dotnet","homepage":"https://azure.microsoft.com/services/event-hubs","size":267,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":7,"forks":3,"open_issues":7,"watchers":3,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"dc5dcad7470da0961c0f2b7d743039c8e9b639c5","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":68422935,"name":"azure-event-hubs-dotnet","full_name":"Azure/azure-event-hubs-dotnet","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-event-hubs-dotnet","description":".NET Standard client library for Azure Event Hubs","fork":false,"url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet","forks_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/forks","keys_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/teams","hooks_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/events","assignees_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/tags","blobs_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/subscription","commits_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/merges","archive_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/downloads","issues_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/deployments","created_at":"2016-09-17T00:21:00Z","updated_at":"2016-10-16T18:52:25Z","pushed_at":"2016-10-15T07:09:11Z","git_url":"git://github.com/Azure/azure-event-hubs-dotnet.git","ssh_url":"git@github.com:Azure/azure-event-hubs-dotnet.git","clone_url":"https://github.com/Azure/azure-event-hubs-dotnet.git","svn_url":"https://github.com/Azure/azure-event-hubs-dotnet","homepage":"https://azure.microsoft.com/services/event-hubs","size":267,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":7,"forks":3,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/pulls/22"},"html":{"href":"https://github.com/Azure/azure-event-hubs-dotnet/pull/22"},"issue":{"href":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/issues/22"},"comments":{"href":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-event-hubs-dotnet/statuses/9e21ace942536252cc37f020f6558d95c1b9481c"}}}}
{"actor":{"display_login":"serkantkaraca"}}