{"action":"opened","number":960,"pull_request":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/960","id":82845551,"html_url":"https://github.com/Microsoft/msbuild/pull/960","diff_url":"https://github.com/Microsoft/msbuild/pull/960.diff","patch_url":"https://github.com/Microsoft/msbuild/pull/960.patch","issue_url":"https://api.github.com/repos/Microsoft/msbuild/issues/960","number":960,"state":"open","locked":false,"title":"Drop another unnecessary if","user":{"login":"BBosman","id":5115488,"avatar_url":"https://avatars.githubusercontent.com/u/5115488?v=3","gravatar_id":"","url":"https://api.github.com/users/BBosman","html_url":"https://github.com/BBosman","followers_url":"https://api.github.com/users/BBosman/followers","following_url":"https://api.github.com/users/BBosman/following{/other_user}","gists_url":"https://api.github.com/users/BBosman/gists{/gist_id}","starred_url":"https://api.github.com/users/BBosman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBosman/subscriptions","organizations_url":"https://api.github.com/users/BBosman/orgs","repos_url":"https://api.github.com/users/BBosman/repos","events_url":"https://api.github.com/users/BBosman/events{/privacy}","received_events_url":"https://api.github.com/users/BBosman/received_events","type":"User","site_admin":false},"body":"Another unnecessary `if`.\r\n\r\nThe `if (isQuotedTransform)` on line 255, combined with the `continue` on line 265 ensures `!isQuotedTransform` will always evaluate to `true`.\r\n\r\nThe `if (functionCapture != null)` on line 270, combined with  the `continue` on line 278 ensures `functionCapture == null` will always evaluate to `true`.\r\n\r\nTherefore this `if`-statement will always evaluate to `true`, making it unnecessary.\r\n\r\nThe same applies to the second instance.","created_at":"2016-08-26T07:49:05Z","updated_at":"2016-08-26T07:49:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/960/commits","review_comments_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/960/comments","review_comment_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/issues/960/comments","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/3ca16cf1cabfe56fbb654fd58e8449705826986c","head":{"label":"BBosman:anotherif","ref":"anotherif","sha":"3ca16cf1cabfe56fbb654fd58e8449705826986c","user":{"login":"BBosman","id":5115488,"avatar_url":"https://avatars.githubusercontent.com/u/5115488?v=3","gravatar_id":"","url":"https://api.github.com/users/BBosman","html_url":"https://github.com/BBosman","followers_url":"https://api.github.com/users/BBosman/followers","following_url":"https://api.github.com/users/BBosman/following{/other_user}","gists_url":"https://api.github.com/users/BBosman/gists{/gist_id}","starred_url":"https://api.github.com/users/BBosman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBosman/subscriptions","organizations_url":"https://api.github.com/users/BBosman/orgs","repos_url":"https://api.github.com/users/BBosman/repos","events_url":"https://api.github.com/users/BBosman/events{/privacy}","received_events_url":"https://api.github.com/users/BBosman/received_events","type":"User","site_admin":false},"repo":{"id":66562055,"name":"msbuild","full_name":"BBosman/msbuild","owner":{"login":"BBosman","id":5115488,"avatar_url":"https://avatars.githubusercontent.com/u/5115488?v=3","gravatar_id":"","url":"https://api.github.com/users/BBosman","html_url":"https://github.com/BBosman","followers_url":"https://api.github.com/users/BBosman/followers","following_url":"https://api.github.com/users/BBosman/following{/other_user}","gists_url":"https://api.github.com/users/BBosman/gists{/gist_id}","starred_url":"https://api.github.com/users/BBosman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBosman/subscriptions","organizations_url":"https://api.github.com/users/BBosman/orgs","repos_url":"https://api.github.com/users/BBosman/repos","events_url":"https://api.github.com/users/BBosman/events{/privacy}","received_events_url":"https://api.github.com/users/BBosman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BBosman/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":true,"url":"https://api.github.com/repos/BBosman/msbuild","forks_url":"https://api.github.com/repos/BBosman/msbuild/forks","keys_url":"https://api.github.com/repos/BBosman/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BBosman/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BBosman/msbuild/teams","hooks_url":"https://api.github.com/repos/BBosman/msbuild/hooks","issue_events_url":"https://api.github.com/repos/BBosman/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/BBosman/msbuild/events","assignees_url":"https://api.github.com/repos/BBosman/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/BBosman/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/BBosman/msbuild/tags","blobs_url":"https://api.github.com/repos/BBosman/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BBosman/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BBosman/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/BBosman/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BBosman/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/BBosman/msbuild/languages","stargazers_url":"https://api.github.com/repos/BBosman/msbuild/stargazers","contributors_url":"https://api.github.com/repos/BBosman/msbuild/contributors","subscribers_url":"https://api.github.com/repos/BBosman/msbuild/subscribers","subscription_url":"https://api.github.com/repos/BBosman/msbuild/subscription","commits_url":"https://api.github.com/repos/BBosman/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/BBosman/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/BBosman/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/BBosman/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/BBosman/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/BBosman/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BBosman/msbuild/merges","archive_url":"https://api.github.com/repos/BBosman/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BBosman/msbuild/downloads","issues_url":"https://api.github.com/repos/BBosman/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/BBosman/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/BBosman/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/BBosman/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BBosman/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/BBosman/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/BBosman/msbuild/deployments","created_at":"2016-08-25T13:52:50Z","updated_at":"2016-08-25T13:52:56Z","pushed_at":"2016-08-26T07:44:04Z","git_url":"git://github.com/BBosman/msbuild.git","ssh_url":"git@github.com:BBosman/msbuild.git","clone_url":"https://github.com/BBosman/msbuild.git","svn_url":"https://github.com/BBosman/msbuild","homepage":null,"size":12622,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"8d741829185c63ab191fb3a867efff1a857e3ab8","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":32051890,"name":"msbuild","full_name":"Microsoft/msbuild","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":false,"url":"https://api.github.com/repos/Microsoft/msbuild","forks_url":"https://api.github.com/repos/Microsoft/msbuild/forks","keys_url":"https://api.github.com/repos/Microsoft/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/msbuild/teams","hooks_url":"https://api.github.com/repos/Microsoft/msbuild/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/msbuild/events","assignees_url":"https://api.github.com/repos/Microsoft/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/msbuild/tags","blobs_url":"https://api.github.com/repos/Microsoft/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/msbuild/languages","stargazers_url":"https://api.github.com/repos/Microsoft/msbuild/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/msbuild/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/msbuild/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/msbuild/subscription","commits_url":"https://api.github.com/repos/Microsoft/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/msbuild/merges","archive_url":"https://api.github.com/repos/Microsoft/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/msbuild/downloads","issues_url":"https://api.github.com/repos/Microsoft/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/msbuild/deployments","created_at":"2015-03-12T02:04:46Z","updated_at":"2016-08-26T06:51:04Z","pushed_at":"2016-08-26T07:49:05Z","git_url":"git://github.com/Microsoft/msbuild.git","ssh_url":"git@github.com:Microsoft/msbuild.git","clone_url":"https://github.com/Microsoft/msbuild.git","svn_url":"https://github.com/Microsoft/msbuild","homepage":null,"size":15459,"stargazers_count":2696,"watchers_count":2696,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":536,"mirror_url":null,"open_issues_count":294,"forks":536,"open_issues":294,"watchers":2696,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/960"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/960"},"issue":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/960"},"comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/960/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/960/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/960/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/msbuild/statuses/3ca16cf1cabfe56fbb654fd58e8449705826986c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":10,"changed_files":1}}
{"actor":{"display_login":"BBosman"}}