{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/237","repository_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy","labels_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/237/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/237/comments","events_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/237/events","html_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/237","id":150025207,"number":237,"title":"Add check for params dhcp_subnets","user":{"login":"andrei693","id":18531667,"avatar_url":"https://avatars.githubusercontent.com/u/18531667?v=3","gravatar_id":"","url":"https://api.github.com/users/andrei693","html_url":"https://github.com/andrei693","followers_url":"https://api.github.com/users/andrei693/followers","following_url":"https://api.github.com/users/andrei693/following{/other_user}","gists_url":"https://api.github.com/users/andrei693/gists{/gist_id}","starred_url":"https://api.github.com/users/andrei693/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrei693/subscriptions","organizations_url":"https://api.github.com/users/andrei693/orgs","repos_url":"https://api.github.com/users/andrei693/repos","events_url":"https://api.github.com/users/andrei693/events{/privacy}","received_events_url":"https://api.github.com/users/andrei693/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-04-21T09:55:01Z","updated_at":"2016-04-21T13:00:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/237","html_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/237","diff_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/237.diff","patch_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/237.patch"},"body":"Add new variable in params dhcp_subnets\r\nUse validate_re to do a basic check if the IP addresses/masks are numbers\r\nSet dhcp_subnets accordingly via template dhcp.yml.erb\r\nFixes GH-109"},"comment":{"url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/comments/212907008","html_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/237#issuecomment-212907008","issue_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/237","id":212907008,"user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"created_at":"2016-04-21T13:00:59Z","updated_at":"2016-04-21T13:00:59Z","body":"The PR doesn't appear to be rebased, GitHub reports it still conflicts.  All of the commits should also be squashed to a single commit.\r\n\r\nI think I'd still prefer to pass an array of subnets into the parameter rather than a comma-separated string."}}