{"action":"created","comment":{"url":"https://api.github.com/repos/OCA/account-financial-tools/pulls/comments/62469516","id":62469516,"diff_hunk":"@@ -0,0 +1,22 @@\n+# -*- coding: utf-8 -*-\n+# Author: Damien Crier\n+# Copyright 2016 Camptocamp SA\n+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).\n+from openerp import models, api, _, exceptions\n+\n+\n+class DateRange(models.Model):\n+    _inherit = 'date.range'\n+\n+    @api.multi\n+    def unlink(self):\n+        \"\"\"\n+        Cannot delete a date_range of type 'fiscal_year'\n+        \"\"\"","path":"account_fiscal_year/models/date_range.py","position":15,"original_position":15,"commit_id":"073f324dfe64d6759ff6f6e5d7f484b8dbcc9f17","original_commit_id":"073f324dfe64d6759ff6f6e5d7f484b8dbcc9f17","user":{"login":"sbidoul","id":692075,"avatar_url":"https://avatars.githubusercontent.com/u/692075?v=3","gravatar_id":"","url":"https://api.github.com/users/sbidoul","html_url":"https://github.com/sbidoul","followers_url":"https://api.github.com/users/sbidoul/followers","following_url":"https://api.github.com/users/sbidoul/following{/other_user}","gists_url":"https://api.github.com/users/sbidoul/gists{/gist_id}","starred_url":"https://api.github.com/users/sbidoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbidoul/subscriptions","organizations_url":"https://api.github.com/users/sbidoul/orgs","repos_url":"https://api.github.com/users/sbidoul/repos","events_url":"https://api.github.com/users/sbidoul/events{/privacy}","received_events_url":"https://api.github.com/users/sbidoul/received_events","type":"User","site_admin":false},"body":"I would *not* forbid deletion of date.range. Should that become necessary on some specific contexts it can be done with a record rule.\r\n\r\nOn the contrary, preventing deletion of date.range.type is necessary for preserving correct behaviour of the module.","created_at":"2016-05-09T09:11:24Z","updated_at":"2016-05-09T09:11:24Z","html_url":"https://github.com/OCA/account-financial-tools/pull/378#discussion_r62469516","pull_request_url":"https://api.github.com/repos/OCA/account-financial-tools/pulls/378","_links":{"self":{"href":"https://api.github.com/repos/OCA/account-financial-tools/pulls/comments/62469516"},"html":{"href":"https://github.com/OCA/account-financial-tools/pull/378#discussion_r62469516"},"pull_request":{"href":"https://api.github.com/repos/OCA/account-financial-tools/pulls/378"}}},"pull_request":{"url":"https://api.github.com/repos/OCA/account-financial-tools/pulls/378","id":68878397,"html_url":"https://github.com/OCA/account-financial-tools/pull/378","diff_url":"https://github.com/OCA/account-financial-tools/pull/378.diff","patch_url":"https://github.com/OCA/account-financial-tools/pull/378.patch","issue_url":"https://api.github.com/repos/OCA/account-financial-tools/issues/378","number":378,"state":"open","locked":false,"title":"9.0 account fiscal year","user":{"login":"damdam-s","id":8102312,"avatar_url":"https://avatars.githubusercontent.com/u/8102312?v=3","gravatar_id":"","url":"https://api.github.com/users/damdam-s","html_url":"https://github.com/damdam-s","followers_url":"https://api.github.com/users/damdam-s/followers","following_url":"https://api.github.com/users/damdam-s/following{/other_user}","gists_url":"https://api.github.com/users/damdam-s/gists{/gist_id}","starred_url":"https://api.github.com/users/damdam-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damdam-s/subscriptions","organizations_url":"https://api.github.com/users/damdam-s/orgs","repos_url":"https://api.github.com/users/damdam-s/repos","events_url":"https://api.github.com/users/damdam-s/events{/privacy}","received_events_url":"https://api.github.com/users/damdam-s/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-04T15:08:39Z","updated_at":"2016-05-09T09:11:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1ddfe95bd9260ff374a3df323f138788b588179","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OCA/account-financial-tools/pulls/378/commits","review_comments_url":"https://api.github.com/repos/OCA/account-financial-tools/pulls/378/comments","review_comment_url":"https://api.github.com/repos/OCA/account-financial-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/account-financial-tools/issues/378/comments","statuses_url":"https://api.github.com/repos/OCA/account-financial-tools/statuses/073f324dfe64d6759ff6f6e5d7f484b8dbcc9f17","head":{"label":"damdam-s:9.0-account_fiscal_year","ref":"9.0-account_fiscal_year","sha":"073f324dfe64d6759ff6f6e5d7f484b8dbcc9f17","user":{"login":"damdam-s","id":8102312,"avatar_url":"https://avatars.githubusercontent.com/u/8102312?v=3","gravatar_id":"","url":"https://api.github.com/users/damdam-s","html_url":"https://github.com/damdam-s","followers_url":"https://api.github.com/users/damdam-s/followers","following_url":"https://api.github.com/users/damdam-s/following{/other_user}","gists_url":"https://api.github.com/users/damdam-s/gists{/gist_id}","starred_url":"https://api.github.com/users/damdam-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damdam-s/subscriptions","organizations_url":"https://api.github.com/users/damdam-s/orgs","repos_url":"https://api.github.com/users/damdam-s/repos","events_url":"https://api.github.com/users/damdam-s/events{/privacy}","received_events_url":"https://api.github.com/users/damdam-s/received_events","type":"User","site_admin":false},"repo":{"id":36507139,"name":"account-financial-tools","full_name":"damdam-s/account-financial-tools","owner":{"login":"damdam-s","id":8102312,"avatar_url":"https://avatars.githubusercontent.com/u/8102312?v=3","gravatar_id":"","url":"https://api.github.com/users/damdam-s","html_url":"https://github.com/damdam-s","followers_url":"https://api.github.com/users/damdam-s/followers","following_url":"https://api.github.com/users/damdam-s/following{/other_user}","gists_url":"https://api.github.com/users/damdam-s/gists{/gist_id}","starred_url":"https://api.github.com/users/damdam-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damdam-s/subscriptions","organizations_url":"https://api.github.com/users/damdam-s/orgs","repos_url":"https://api.github.com/users/damdam-s/repos","events_url":"https://api.github.com/users/damdam-s/events{/privacy}","received_events_url":"https://api.github.com/users/damdam-s/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/damdam-s/account-financial-tools","description":"Odoo Accountant Financial Tools and Utils","fork":true,"url":"https://api.github.com/repos/damdam-s/account-financial-tools","forks_url":"https://api.github.com/repos/damdam-s/account-financial-tools/forks","keys_url":"https://api.github.com/repos/damdam-s/account-financial-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/damdam-s/account-financial-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/damdam-s/account-financial-tools/teams","hooks_url":"https://api.github.com/repos/damdam-s/account-financial-tools/hooks","issue_events_url":"https://api.github.com/repos/damdam-s/account-financial-tools/issues/events{/number}","events_url":"https://api.github.com/repos/damdam-s/account-financial-tools/events","assignees_url":"https://api.github.com/repos/damdam-s/account-financial-tools/assignees{/user}","branches_url":"https://api.github.com/repos/damdam-s/account-financial-tools/branches{/branch}","tags_url":"https://api.github.com/repos/damdam-s/account-financial-tools/tags","blobs_url":"https://api.github.com/repos/damdam-s/account-financial-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/damdam-s/account-financial-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/damdam-s/account-financial-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/damdam-s/account-financial-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/damdam-s/account-financial-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/damdam-s/account-financial-tools/languages","stargazers_url":"https://api.github.com/repos/damdam-s/account-financial-tools/stargazers","contributors_url":"https://api.github.com/repos/damdam-s/account-financial-tools/contributors","subscribers_url":"https://api.github.com/repos/damdam-s/account-financial-tools/subscribers","subscription_url":"https://api.github.com/repos/damdam-s/account-financial-tools/subscription","commits_url":"https://api.github.com/repos/damdam-s/account-financial-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/damdam-s/account-financial-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/damdam-s/account-financial-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/damdam-s/account-financial-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/damdam-s/account-financial-tools/contents/{+path}","compare_url":"https://api.github.com/repos/damdam-s/account-financial-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/damdam-s/account-financial-tools/merges","archive_url":"https://api.github.com/repos/damdam-s/account-financial-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/damdam-s/account-financial-tools/downloads","issues_url":"https://api.github.com/repos/damdam-s/account-financial-tools/issues{/number}","pulls_url":"https://api.github.com/repos/damdam-s/account-financial-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/damdam-s/account-financial-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/damdam-s/account-financial-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/damdam-s/account-financial-tools/labels{/name}","releases_url":"https://api.github.com/repos/damdam-s/account-financial-tools/releases{/id}","deployments_url":"https://api.github.com/repos/damdam-s/account-financial-tools/deployments","created_at":"2015-05-29T13:50:58Z","updated_at":"2015-05-29T13:50:59Z","pushed_at":"2016-05-09T08:55:15Z","git_url":"git://github.com/damdam-s/account-financial-tools.git","ssh_url":"git@github.com:damdam-s/account-financial-tools.git","clone_url":"https://github.com/damdam-s/account-financial-tools.git","svn_url":"https://github.com/damdam-s/account-financial-tools","homepage":"","size":5495,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"8.0"}},"base":{"label":"OCA:9.0","ref":"9.0","sha":"d9a47e0faf4c3f000d9ff6f9b42be628bafa90ef","user":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":20881761,"name":"account-financial-tools","full_name":"OCA/account-financial-tools","owner":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/account-financial-tools","description":"Odoo Accountant Financial Tools and Utils","fork":false,"url":"https://api.github.com/repos/OCA/account-financial-tools","forks_url":"https://api.github.com/repos/OCA/account-financial-tools/forks","keys_url":"https://api.github.com/repos/OCA/account-financial-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/account-financial-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/account-financial-tools/teams","hooks_url":"https://api.github.com/repos/OCA/account-financial-tools/hooks","issue_events_url":"https://api.github.com/repos/OCA/account-financial-tools/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/account-financial-tools/events","assignees_url":"https://api.github.com/repos/OCA/account-financial-tools/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/account-financial-tools/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/account-financial-tools/tags","blobs_url":"https://api.github.com/repos/OCA/account-financial-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/account-financial-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/account-financial-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/account-financial-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/account-financial-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/account-financial-tools/languages","stargazers_url":"https://api.github.com/repos/OCA/account-financial-tools/stargazers","contributors_url":"https://api.github.com/repos/OCA/account-financial-tools/contributors","subscribers_url":"https://api.github.com/repos/OCA/account-financial-tools/subscribers","subscription_url":"https://api.github.com/repos/OCA/account-financial-tools/subscription","commits_url":"https://api.github.com/repos/OCA/account-financial-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/account-financial-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/account-financial-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/account-financial-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/account-financial-tools/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/account-financial-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/account-financial-tools/merges","archive_url":"https://api.github.com/repos/OCA/account-financial-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/account-financial-tools/downloads","issues_url":"https://api.github.com/repos/OCA/account-financial-tools/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/account-financial-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/account-financial-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/account-financial-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/account-financial-tools/labels{/name}","releases_url":"https://api.github.com/repos/OCA/account-financial-tools/releases{/id}","deployments_url":"https://api.github.com/repos/OCA/account-financial-tools/deployments","created_at":"2014-06-16T10:58:57Z","updated_at":"2016-04-08T11:59:54Z","pushed_at":"2016-05-09T08:55:16Z","git_url":"git://github.com/OCA/account-financial-tools.git","ssh_url":"git@github.com:OCA/account-financial-tools.git","clone_url":"https://github.com/OCA/account-financial-tools.git","svn_url":"https://github.com/OCA/account-financial-tools","homepage":"","size":10907,"stargazers_count":41,"watchers_count":41,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":148,"mirror_url":null,"open_issues_count":85,"forks":148,"open_issues":85,"watchers":41,"default_branch":"9.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/account-financial-tools/pulls/378"},"html":{"href":"https://github.com/OCA/account-financial-tools/pull/378"},"issue":{"href":"https://api.github.com/repos/OCA/account-financial-tools/issues/378"},"comments":{"href":"https://api.github.com/repos/OCA/account-financial-tools/issues/378/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/account-financial-tools/pulls/378/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/account-financial-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/account-financial-tools/pulls/378/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/account-financial-tools/statuses/073f324dfe64d6759ff6f6e5d7f484b8dbcc9f17"}}}}