{"action":"created","comment":{"url":"https://api.github.com/repos/deis/controller/pulls/comments/58247890","id":58247890,"diff_hunk":"@@ -528,7 +542,7 @@ def run(self, namespace, name, image, entrypoint, command, **kwargs):\n             error(response, 'create Pod in Namespace \"{}\"', namespace)\n \n         data = ''\n-        duration = 30\n+        duration = 120","path":"rootfs/scheduler/__init__.py","position":46,"original_position":46,"commit_id":"362f970a35fb069bc5d845f2f325013a4172bd72","original_commit_id":"362f970a35fb069bc5d845f2f325013a4172bd72","user":{"login":"slack","id":28873,"avatar_url":"https://avatars.githubusercontent.com/u/28873?v=3","gravatar_id":"","url":"https://api.github.com/users/slack","html_url":"https://github.com/slack","followers_url":"https://api.github.com/users/slack/followers","following_url":"https://api.github.com/users/slack/following{/other_user}","gists_url":"https://api.github.com/users/slack/gists{/gist_id}","starred_url":"https://api.github.com/users/slack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slack/subscriptions","organizations_url":"https://api.github.com/users/slack/orgs","repos_url":"https://api.github.com/users/slack/repos","events_url":"https://api.github.com/users/slack/events{/privacy}","received_events_url":"https://api.github.com/users/slack/received_events","type":"User","site_admin":false},"body":"Unrelated?","created_at":"2016-04-01T18:32:34Z","updated_at":"2016-04-01T18:32:34Z","html_url":"https://github.com/deis/controller/pull/587#discussion_r58247890","pull_request_url":"https://api.github.com/repos/deis/controller/pulls/587","_links":{"self":{"href":"https://api.github.com/repos/deis/controller/pulls/comments/58247890"},"html":{"href":"https://github.com/deis/controller/pull/587#discussion_r58247890"},"pull_request":{"href":"https://api.github.com/repos/deis/controller/pulls/587"}}},"pull_request":{"url":"https://api.github.com/repos/deis/controller/pulls/587","id":64844839,"html_url":"https://github.com/deis/controller/pull/587","diff_url":"https://github.com/deis/controller/pull/587.diff","patch_url":"https://github.com/deis/controller/pull/587.patch","issue_url":"https://api.github.com/repos/deis/controller/issues/587","number":587,"state":"open","locked":false,"title":"feat(scheduler): store env vars as secrets in k8s and map them in the RC","user":{"login":"helgi","id":70530,"avatar_url":"https://avatars.githubusercontent.com/u/70530?v=3","gravatar_id":"","url":"https://api.github.com/users/helgi","html_url":"https://github.com/helgi","followers_url":"https://api.github.com/users/helgi/followers","following_url":"https://api.github.com/users/helgi/following{/other_user}","gists_url":"https://api.github.com/users/helgi/gists{/gist_id}","starred_url":"https://api.github.com/users/helgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helgi/subscriptions","organizations_url":"https://api.github.com/users/helgi/orgs","repos_url":"https://api.github.com/users/helgi/repos","events_url":"https://api.github.com/users/helgi/events{/privacy}","received_events_url":"https://api.github.com/users/helgi/received_events","type":"User","site_admin":false},"body":"This provides more security around sensitive information and lets k8s admins put more controls in place on who can update what\r\n\r\nWent with a secret per release instead of a secret per app that we keep updating. Thoughts on that?\r\n\r\nCloses #299","created_at":"2016-03-31T19:27:52Z","updated_at":"2016-04-01T18:32:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f3dffe8bb1489e408732c81ff04c570f3f80bea","assignee":{"login":"helgi","id":70530,"avatar_url":"https://avatars.githubusercontent.com/u/70530?v=3","gravatar_id":"","url":"https://api.github.com/users/helgi","html_url":"https://github.com/helgi","followers_url":"https://api.github.com/users/helgi/followers","following_url":"https://api.github.com/users/helgi/following{/other_user}","gists_url":"https://api.github.com/users/helgi/gists{/gist_id}","starred_url":"https://api.github.com/users/helgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helgi/subscriptions","organizations_url":"https://api.github.com/users/helgi/orgs","repos_url":"https://api.github.com/users/helgi/repos","events_url":"https://api.github.com/users/helgi/events{/privacy}","received_events_url":"https://api.github.com/users/helgi/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/deis/controller/milestones/4","html_url":"https://github.com/deis/controller/milestones/v2.0-rc1","labels_url":"https://api.github.com/repos/deis/controller/milestones/4/labels","id":1598259,"number":4,"title":"v2.0-rc1","description":null,"creator":{"login":"technosophos","id":89193,"avatar_url":"https://avatars.githubusercontent.com/u/89193?v=3","gravatar_id":"","url":"https://api.github.com/users/technosophos","html_url":"https://github.com/technosophos","followers_url":"https://api.github.com/users/technosophos/followers","following_url":"https://api.github.com/users/technosophos/following{/other_user}","gists_url":"https://api.github.com/users/technosophos/gists{/gist_id}","starred_url":"https://api.github.com/users/technosophos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technosophos/subscriptions","organizations_url":"https://api.github.com/users/technosophos/orgs","repos_url":"https://api.github.com/users/technosophos/repos","events_url":"https://api.github.com/users/technosophos/events{/privacy}","received_events_url":"https://api.github.com/users/technosophos/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":39,"state":"open","created_at":"2016-02-22T21:13:36Z","updated_at":"2016-04-01T00:40:27Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/deis/controller/pulls/587/commits","review_comments_url":"https://api.github.com/repos/deis/controller/pulls/587/comments","review_comment_url":"https://api.github.com/repos/deis/controller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deis/controller/issues/587/comments","statuses_url":"https://api.github.com/repos/deis/controller/statuses/362f970a35fb069bc5d845f2f325013a4172bd72","head":{"label":"helgi:env_as_secrets","ref":"env_as_secrets","sha":"362f970a35fb069bc5d845f2f325013a4172bd72","user":{"login":"helgi","id":70530,"avatar_url":"https://avatars.githubusercontent.com/u/70530?v=3","gravatar_id":"","url":"https://api.github.com/users/helgi","html_url":"https://github.com/helgi","followers_url":"https://api.github.com/users/helgi/followers","following_url":"https://api.github.com/users/helgi/following{/other_user}","gists_url":"https://api.github.com/users/helgi/gists{/gist_id}","starred_url":"https://api.github.com/users/helgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helgi/subscriptions","organizations_url":"https://api.github.com/users/helgi/orgs","repos_url":"https://api.github.com/users/helgi/repos","events_url":"https://api.github.com/users/helgi/events{/privacy}","received_events_url":"https://api.github.com/users/helgi/received_events","type":"User","site_admin":false},"repo":{"id":47214840,"name":"controller","full_name":"helgi/controller","owner":{"login":"helgi","id":70530,"avatar_url":"https://avatars.githubusercontent.com/u/70530?v=3","gravatar_id":"","url":"https://api.github.com/users/helgi","html_url":"https://github.com/helgi","followers_url":"https://api.github.com/users/helgi/followers","following_url":"https://api.github.com/users/helgi/following{/other_user}","gists_url":"https://api.github.com/users/helgi/gists{/gist_id}","starred_url":"https://api.github.com/users/helgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helgi/subscriptions","organizations_url":"https://api.github.com/users/helgi/orgs","repos_url":"https://api.github.com/users/helgi/repos","events_url":"https://api.github.com/users/helgi/events{/privacy}","received_events_url":"https://api.github.com/users/helgi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/helgi/controller","description":"PaaS workflow controller and client for Deis v2","fork":true,"url":"https://api.github.com/repos/helgi/controller","forks_url":"https://api.github.com/repos/helgi/controller/forks","keys_url":"https://api.github.com/repos/helgi/controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helgi/controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helgi/controller/teams","hooks_url":"https://api.github.com/repos/helgi/controller/hooks","issue_events_url":"https://api.github.com/repos/helgi/controller/issues/events{/number}","events_url":"https://api.github.com/repos/helgi/controller/events","assignees_url":"https://api.github.com/repos/helgi/controller/assignees{/user}","branches_url":"https://api.github.com/repos/helgi/controller/branches{/branch}","tags_url":"https://api.github.com/repos/helgi/controller/tags","blobs_url":"https://api.github.com/repos/helgi/controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helgi/controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helgi/controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/helgi/controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helgi/controller/statuses/{sha}","languages_url":"https://api.github.com/repos/helgi/controller/languages","stargazers_url":"https://api.github.com/repos/helgi/controller/stargazers","contributors_url":"https://api.github.com/repos/helgi/controller/contributors","subscribers_url":"https://api.github.com/repos/helgi/controller/subscribers","subscription_url":"https://api.github.com/repos/helgi/controller/subscription","commits_url":"https://api.github.com/repos/helgi/controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/helgi/controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/helgi/controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/helgi/controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/helgi/controller/contents/{+path}","compare_url":"https://api.github.com/repos/helgi/controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helgi/controller/merges","archive_url":"https://api.github.com/repos/helgi/controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helgi/controller/downloads","issues_url":"https://api.github.com/repos/helgi/controller/issues{/number}","pulls_url":"https://api.github.com/repos/helgi/controller/pulls{/number}","milestones_url":"https://api.github.com/repos/helgi/controller/milestones{/number}","notifications_url":"https://api.github.com/repos/helgi/controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helgi/controller/labels{/name}","releases_url":"https://api.github.com/repos/helgi/controller/releases{/id}","deployments_url":"https://api.github.com/repos/helgi/controller/deployments","created_at":"2015-12-01T20:16:13Z","updated_at":"2016-03-16T17:43:06Z","pushed_at":"2016-04-01T17:28:21Z","git_url":"git://github.com/helgi/controller.git","ssh_url":"git@github.com:helgi/controller.git","clone_url":"https://github.com/helgi/controller.git","svn_url":"https://github.com/helgi/controller","homepage":"http://deis.io","size":15410,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deis:master","ref":"master","sha":"3fe88f8495bf5a17a66aff39e2f5e68d7a1acac1","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":45704630,"name":"controller","full_name":"deis/controller","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/controller","description":"Deis Workflow Controller (API)","fork":false,"url":"https://api.github.com/repos/deis/controller","forks_url":"https://api.github.com/repos/deis/controller/forks","keys_url":"https://api.github.com/repos/deis/controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/controller/teams","hooks_url":"https://api.github.com/repos/deis/controller/hooks","issue_events_url":"https://api.github.com/repos/deis/controller/issues/events{/number}","events_url":"https://api.github.com/repos/deis/controller/events","assignees_url":"https://api.github.com/repos/deis/controller/assignees{/user}","branches_url":"https://api.github.com/repos/deis/controller/branches{/branch}","tags_url":"https://api.github.com/repos/deis/controller/tags","blobs_url":"https://api.github.com/repos/deis/controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/controller/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/controller/languages","stargazers_url":"https://api.github.com/repos/deis/controller/stargazers","contributors_url":"https://api.github.com/repos/deis/controller/contributors","subscribers_url":"https://api.github.com/repos/deis/controller/subscribers","subscription_url":"https://api.github.com/repos/deis/controller/subscription","commits_url":"https://api.github.com/repos/deis/controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/deis/controller/contents/{+path}","compare_url":"https://api.github.com/repos/deis/controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/controller/merges","archive_url":"https://api.github.com/repos/deis/controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/controller/downloads","issues_url":"https://api.github.com/repos/deis/controller/issues{/number}","pulls_url":"https://api.github.com/repos/deis/controller/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/controller/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/controller/labels{/name}","releases_url":"https://api.github.com/repos/deis/controller/releases{/id}","deployments_url":"https://api.github.com/repos/deis/controller/deployments","created_at":"2015-11-06T20:06:05Z","updated_at":"2016-03-31T18:59:08Z","pushed_at":"2016-04-01T17:28:22Z","git_url":"git://github.com/deis/controller.git","ssh_url":"git@github.com:deis/controller.git","clone_url":"https://github.com/deis/controller.git","svn_url":"https://github.com/deis/controller","homepage":"https://deis.com","size":16385,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":59,"forks":22,"open_issues":59,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/controller/pulls/587"},"html":{"href":"https://github.com/deis/controller/pull/587"},"issue":{"href":"https://api.github.com/repos/deis/controller/issues/587"},"comments":{"href":"https://api.github.com/repos/deis/controller/issues/587/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/controller/pulls/587/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/controller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deis/controller/pulls/587/commits"},"statuses":{"href":"https://api.github.com/repos/deis/controller/statuses/362f970a35fb069bc5d845f2f325013a4172bd72"}}}}