{"action":"created","comment":{"url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments/74819892","id":74819892,"diff_hunk":"@@ -2898,12 +2900,22 @@ class PlannerSpec extends quasar.QuasarSpecification with ScalaCheck with Compil\n             IgnoreId)))\n     }\n \n+    \"plan simple join with sharded inputs\" in {\n+      val query = \"select zips2.city from zips join zips2 on zips._id = zips2._id\"\n+      plan0(query,\n+        MongoQueryModel.`3.2`,\n+        c => Map(\n+          collection(\"db\", \"zips\") -> CollectionStatistics(10, 100, true),\n+          collection(\"db\", \"zips2\") -> CollectionStatistics(15, 150, true)).get(c)) must_==\n+        plan2_6(query)\n+    }\n+","path":"mongodb/src/test/scala/quasar/physical/mongodb/planner.scala","position":1215,"original_position":1215,"commit_id":"24186cae2ff50e2a4014c29dcfd9268ea36a4831","original_commit_id":"24186cae2ff50e2a4014c29dcfd9268ea36a4831","user":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?v=3","gravatar_id":"","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"body":"I'll add a test. I don't think this approach is super great, but it's better than nothing and I do think we need _some_ test of that code path.","created_at":"2016-08-15T19:34:10Z","updated_at":"2016-08-15T19:34:10Z","html_url":"https://github.com/quasar-analytics/quasar/pull/1361#discussion_r74819892","pull_request_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1361","_links":{"self":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments/74819892"},"html":{"href":"https://github.com/quasar-analytics/quasar/pull/1361#discussion_r74819892"},"pull_request":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1361"}}},"pull_request":{"url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1361","id":81254484,"html_url":"https://github.com/quasar-analytics/quasar/pull/1361","diff_url":"https://github.com/quasar-analytics/quasar/pull/1361.diff","patch_url":"https://github.com/quasar-analytics/quasar/pull/1361.patch","issue_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/1361","number":1361,"state":"open","locked":false,"title":"[#1284] fall back to map-reduce when source collections are sharded or cross-DB","user":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?v=3","gravatar_id":"","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-14T21:09:25Z","updated_at":"2016-08-15T19:34:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c006a04248b9a2539bda20de557c822ccfacfb0","assignee":{"login":"wemrysi","id":32185,"avatar_url":"https://avatars.githubusercontent.com/u/32185?v=3","gravatar_id":"","url":"https://api.github.com/users/wemrysi","html_url":"https://github.com/wemrysi","followers_url":"https://api.github.com/users/wemrysi/followers","following_url":"https://api.github.com/users/wemrysi/following{/other_user}","gists_url":"https://api.github.com/users/wemrysi/gists{/gist_id}","starred_url":"https://api.github.com/users/wemrysi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wemrysi/subscriptions","organizations_url":"https://api.github.com/users/wemrysi/orgs","repos_url":"https://api.github.com/users/wemrysi/repos","events_url":"https://api.github.com/users/wemrysi/events{/privacy}","received_events_url":"https://api.github.com/users/wemrysi/received_events","type":"User","site_admin":false},"assignees":[{"login":"wemrysi","id":32185,"avatar_url":"https://avatars.githubusercontent.com/u/32185?v=3","gravatar_id":"","url":"https://api.github.com/users/wemrysi","html_url":"https://github.com/wemrysi","followers_url":"https://api.github.com/users/wemrysi/followers","following_url":"https://api.github.com/users/wemrysi/following{/other_user}","gists_url":"https://api.github.com/users/wemrysi/gists{/gist_id}","starred_url":"https://api.github.com/users/wemrysi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wemrysi/subscriptions","organizations_url":"https://api.github.com/users/wemrysi/orgs","repos_url":"https://api.github.com/users/wemrysi/repos","events_url":"https://api.github.com/users/wemrysi/events{/privacy}","received_events_url":"https://api.github.com/users/wemrysi/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1361/commits","review_comments_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1361/comments","review_comment_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/1361/comments","statuses_url":"https://api.github.com/repos/quasar-analytics/quasar/statuses/24186cae2ff50e2a4014c29dcfd9268ea36a4831","head":{"label":"mossprescott:join-preconditions","ref":"join-preconditions","sha":"24186cae2ff50e2a4014c29dcfd9268ea36a4831","user":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?v=3","gravatar_id":"","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"repo":{"id":21178367,"name":"quasar","full_name":"mossprescott/quasar","owner":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?v=3","gravatar_id":"","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mossprescott/quasar","description":"The engine for SlamData","fork":true,"url":"https://api.github.com/repos/mossprescott/quasar","forks_url":"https://api.github.com/repos/mossprescott/quasar/forks","keys_url":"https://api.github.com/repos/mossprescott/quasar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mossprescott/quasar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mossprescott/quasar/teams","hooks_url":"https://api.github.com/repos/mossprescott/quasar/hooks","issue_events_url":"https://api.github.com/repos/mossprescott/quasar/issues/events{/number}","events_url":"https://api.github.com/repos/mossprescott/quasar/events","assignees_url":"https://api.github.com/repos/mossprescott/quasar/assignees{/user}","branches_url":"https://api.github.com/repos/mossprescott/quasar/branches{/branch}","tags_url":"https://api.github.com/repos/mossprescott/quasar/tags","blobs_url":"https://api.github.com/repos/mossprescott/quasar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mossprescott/quasar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mossprescott/quasar/git/refs{/sha}","trees_url":"https://api.github.com/repos/mossprescott/quasar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mossprescott/quasar/statuses/{sha}","languages_url":"https://api.github.com/repos/mossprescott/quasar/languages","stargazers_url":"https://api.github.com/repos/mossprescott/quasar/stargazers","contributors_url":"https://api.github.com/repos/mossprescott/quasar/contributors","subscribers_url":"https://api.github.com/repos/mossprescott/quasar/subscribers","subscription_url":"https://api.github.com/repos/mossprescott/quasar/subscription","commits_url":"https://api.github.com/repos/mossprescott/quasar/commits{/sha}","git_commits_url":"https://api.github.com/repos/mossprescott/quasar/git/commits{/sha}","comments_url":"https://api.github.com/repos/mossprescott/quasar/comments{/number}","issue_comment_url":"https://api.github.com/repos/mossprescott/quasar/issues/comments{/number}","contents_url":"https://api.github.com/repos/mossprescott/quasar/contents/{+path}","compare_url":"https://api.github.com/repos/mossprescott/quasar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mossprescott/quasar/merges","archive_url":"https://api.github.com/repos/mossprescott/quasar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mossprescott/quasar/downloads","issues_url":"https://api.github.com/repos/mossprescott/quasar/issues{/number}","pulls_url":"https://api.github.com/repos/mossprescott/quasar/pulls{/number}","milestones_url":"https://api.github.com/repos/mossprescott/quasar/milestones{/number}","notifications_url":"https://api.github.com/repos/mossprescott/quasar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mossprescott/quasar/labels{/name}","releases_url":"https://api.github.com/repos/mossprescott/quasar/releases{/id}","deployments_url":"https://api.github.com/repos/mossprescott/quasar/deployments","created_at":"2014-06-24T19:43:22Z","updated_at":"2015-09-14T21:35:18Z","pushed_at":"2016-08-14T21:07:14Z","git_url":"git://github.com/mossprescott/quasar.git","ssh_url":"git@github.com:mossprescott/quasar.git","clone_url":"https://github.com/mossprescott/quasar.git","svn_url":"https://github.com/mossprescott/quasar","homepage":null,"size":12722,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CHECK-UPSTREAM-REPO"}},"base":{"label":"quasar-analytics:master","ref":"master","sha":"08ae170f6518a0ccfb5b5b99c72c6acd0bb40d54","user":{"login":"quasar-analytics","id":15095906,"avatar_url":"https://avatars.githubusercontent.com/u/15095906?v=3","gravatar_id":"","url":"https://api.github.com/users/quasar-analytics","html_url":"https://github.com/quasar-analytics","followers_url":"https://api.github.com/users/quasar-analytics/followers","following_url":"https://api.github.com/users/quasar-analytics/following{/other_user}","gists_url":"https://api.github.com/users/quasar-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/quasar-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quasar-analytics/subscriptions","organizations_url":"https://api.github.com/users/quasar-analytics/orgs","repos_url":"https://api.github.com/users/quasar-analytics/repos","events_url":"https://api.github.com/users/quasar-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/quasar-analytics/received_events","type":"Organization","site_admin":false},"repo":{"id":16515058,"name":"quasar","full_name":"quasar-analytics/quasar","owner":{"login":"quasar-analytics","id":15095906,"avatar_url":"https://avatars.githubusercontent.com/u/15095906?v=3","gravatar_id":"","url":"https://api.github.com/users/quasar-analytics","html_url":"https://github.com/quasar-analytics","followers_url":"https://api.github.com/users/quasar-analytics/followers","following_url":"https://api.github.com/users/quasar-analytics/following{/other_user}","gists_url":"https://api.github.com/users/quasar-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/quasar-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quasar-analytics/subscriptions","organizations_url":"https://api.github.com/users/quasar-analytics/orgs","repos_url":"https://api.github.com/users/quasar-analytics/repos","events_url":"https://api.github.com/users/quasar-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/quasar-analytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quasar-analytics/quasar","description":"A NoSQL analytics engine that embraces post-relational analytics and pushes computation to the data.","fork":false,"url":"https://api.github.com/repos/quasar-analytics/quasar","forks_url":"https://api.github.com/repos/quasar-analytics/quasar/forks","keys_url":"https://api.github.com/repos/quasar-analytics/quasar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quasar-analytics/quasar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quasar-analytics/quasar/teams","hooks_url":"https://api.github.com/repos/quasar-analytics/quasar/hooks","issue_events_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/events{/number}","events_url":"https://api.github.com/repos/quasar-analytics/quasar/events","assignees_url":"https://api.github.com/repos/quasar-analytics/quasar/assignees{/user}","branches_url":"https://api.github.com/repos/quasar-analytics/quasar/branches{/branch}","tags_url":"https://api.github.com/repos/quasar-analytics/quasar/tags","blobs_url":"https://api.github.com/repos/quasar-analytics/quasar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quasar-analytics/quasar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quasar-analytics/quasar/git/refs{/sha}","trees_url":"https://api.github.com/repos/quasar-analytics/quasar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quasar-analytics/quasar/statuses/{sha}","languages_url":"https://api.github.com/repos/quasar-analytics/quasar/languages","stargazers_url":"https://api.github.com/repos/quasar-analytics/quasar/stargazers","contributors_url":"https://api.github.com/repos/quasar-analytics/quasar/contributors","subscribers_url":"https://api.github.com/repos/quasar-analytics/quasar/subscribers","subscription_url":"https://api.github.com/repos/quasar-analytics/quasar/subscription","commits_url":"https://api.github.com/repos/quasar-analytics/quasar/commits{/sha}","git_commits_url":"https://api.github.com/repos/quasar-analytics/quasar/git/commits{/sha}","comments_url":"https://api.github.com/repos/quasar-analytics/quasar/comments{/number}","issue_comment_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/comments{/number}","contents_url":"https://api.github.com/repos/quasar-analytics/quasar/contents/{+path}","compare_url":"https://api.github.com/repos/quasar-analytics/quasar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quasar-analytics/quasar/merges","archive_url":"https://api.github.com/repos/quasar-analytics/quasar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quasar-analytics/quasar/downloads","issues_url":"https://api.github.com/repos/quasar-analytics/quasar/issues{/number}","pulls_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls{/number}","milestones_url":"https://api.github.com/repos/quasar-analytics/quasar/milestones{/number}","notifications_url":"https://api.github.com/repos/quasar-analytics/quasar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quasar-analytics/quasar/labels{/name}","releases_url":"https://api.github.com/repos/quasar-analytics/quasar/releases{/id}","deployments_url":"https://api.github.com/repos/quasar-analytics/quasar/deployments","created_at":"2014-02-04T15:01:27Z","updated_at":"2016-08-15T13:52:11Z","pushed_at":"2016-08-15T19:26:28Z","git_url":"git://github.com/quasar-analytics/quasar.git","ssh_url":"git@github.com:quasar-analytics/quasar.git","clone_url":"https://github.com/quasar-analytics/quasar.git","svn_url":"https://github.com/quasar-analytics/quasar","homepage":"http://quasar-analytics.org","size":15657,"stargazers_count":289,"watchers_count":289,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":64,"forks":49,"open_issues":64,"watchers":289,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1361"},"html":{"href":"https://github.com/quasar-analytics/quasar/pull/1361"},"issue":{"href":"https://api.github.com/repos/quasar-analytics/quasar/issues/1361"},"comments":{"href":"https://api.github.com/repos/quasar-analytics/quasar/issues/1361/comments"},"review_comments":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1361/comments"},"review_comment":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1361/commits"},"statuses":{"href":"https://api.github.com/repos/quasar-analytics/quasar/statuses/24186cae2ff50e2a4014c29dcfd9268ea36a4831"}}}}
{"actor":{"display_login":"mossprescott"}}