{"action":"closed","number":9,"pull_request":{"url":"https://api.github.com/repos/raleighgreen/fretArt/pulls/9","id":91096320,"html_url":"https://github.com/raleighgreen/fretArt/pull/9","diff_url":"https://github.com/raleighgreen/fretArt/pull/9.diff","patch_url":"https://github.com/raleighgreen/fretArt/pull/9.patch","issue_url":"https://api.github.com/repos/raleighgreen/fretArt/issues/9","number":9,"state":"closed","locked":false,"title":"Seperate files","user":{"login":"raleighgreen","id":566390,"avatar_url":"https://avatars.githubusercontent.com/u/566390?v=3","gravatar_id":"","url":"https://api.github.com/users/raleighgreen","html_url":"https://github.com/raleighgreen","followers_url":"https://api.github.com/users/raleighgreen/followers","following_url":"https://api.github.com/users/raleighgreen/following{/other_user}","gists_url":"https://api.github.com/users/raleighgreen/gists{/gist_id}","starred_url":"https://api.github.com/users/raleighgreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raleighgreen/subscriptions","organizations_url":"https://api.github.com/users/raleighgreen/orgs","repos_url":"https://api.github.com/users/raleighgreen/repos","events_url":"https://api.github.com/users/raleighgreen/events{/privacy}","received_events_url":"https://api.github.com/users/raleighgreen/received_events","type":"User","site_admin":false},"body":"Hi Kevin,\r\n\r\nI have some progress (or rather a roadblock of sorts) to report that I've reached today.\r\n\r\nI set out to troubleshoot why the app wasn't displaying properly after splitting `fretboard.js` into separate files during yesterdays meeting. I think I was able to narrow down the problem. The issue cropped up as soon as `this.displayWithColor` is moved out of the `Fret()` constructor and is instead attached to the prototype. Specifically, I believe it has to do with `this.noteClickedColor` inside of `Fret.prototype.displayWithColor` always staying false. I was able to get `Fret.prototype.clicked` working fine, but for some reason,  `Fret.prototype.displayWithColor` won't work no matter what I try and the notes just show up as blue.\r\n\r\nHope you don't mind my asking - I definitely don't mean to overload you with help questions having already sent you the dot/line diagram earlier today, but after working on this for a number of hours and not making any headway I figure it best to run this one by you before moving on. \r\n\r\nDo you have any ideas as to why `Fret.prototype.displayWithColor` isn't working?\r\n\r\nP.S. `this.displayWithColor()` used to be called just this.display(). I changed the name because the color coding in Atom seemed to indicate that display() was a built in P5 method, and I just didn't want to run the risk of using a restricted keyword of any sort. Hope that's ok.\r\n\r\nP.P.S. The more I think about the color code split happening at the current key rather than at E, the more I realize that that is indeed the way to go without a doubt! Thanks for that suggestion. My inclination is to go with that.","created_at":"2016-10-26T21:54:28Z","updated_at":"2016-10-27T14:42:56Z","closed_at":"2016-10-27T14:42:56Z","merged_at":null,"merge_commit_sha":"0a2f3612d733a09501827687d9688d7c03945794","assignee":{"login":"kmcgillivray","id":5005357,"avatar_url":"https://avatars.githubusercontent.com/u/5005357?v=3","gravatar_id":"","url":"https://api.github.com/users/kmcgillivray","html_url":"https://github.com/kmcgillivray","followers_url":"https://api.github.com/users/kmcgillivray/followers","following_url":"https://api.github.com/users/kmcgillivray/following{/other_user}","gists_url":"https://api.github.com/users/kmcgillivray/gists{/gist_id}","starred_url":"https://api.github.com/users/kmcgillivray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmcgillivray/subscriptions","organizations_url":"https://api.github.com/users/kmcgillivray/orgs","repos_url":"https://api.github.com/users/kmcgillivray/repos","events_url":"https://api.github.com/users/kmcgillivray/events{/privacy}","received_events_url":"https://api.github.com/users/kmcgillivray/received_events","type":"User","site_admin":false},"assignees":[{"login":"kmcgillivray","id":5005357,"avatar_url":"https://avatars.githubusercontent.com/u/5005357?v=3","gravatar_id":"","url":"https://api.github.com/users/kmcgillivray","html_url":"https://github.com/kmcgillivray","followers_url":"https://api.github.com/users/kmcgillivray/followers","following_url":"https://api.github.com/users/kmcgillivray/following{/other_user}","gists_url":"https://api.github.com/users/kmcgillivray/gists{/gist_id}","starred_url":"https://api.github.com/users/kmcgillivray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmcgillivray/subscriptions","organizations_url":"https://api.github.com/users/kmcgillivray/orgs","repos_url":"https://api.github.com/users/kmcgillivray/repos","events_url":"https://api.github.com/users/kmcgillivray/events{/privacy}","received_events_url":"https://api.github.com/users/kmcgillivray/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/raleighgreen/fretArt/pulls/9/commits","review_comments_url":"https://api.github.com/repos/raleighgreen/fretArt/pulls/9/comments","review_comment_url":"https://api.github.com/repos/raleighgreen/fretArt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/raleighgreen/fretArt/issues/9/comments","statuses_url":"https://api.github.com/repos/raleighgreen/fretArt/statuses/213c0834b1f3ab9bd0fca4bff81864e445bef597","head":{"label":"raleighgreen:seperate-files","ref":"seperate-files","sha":"213c0834b1f3ab9bd0fca4bff81864e445bef597","user":{"login":"raleighgreen","id":566390,"avatar_url":"https://avatars.githubusercontent.com/u/566390?v=3","gravatar_id":"","url":"https://api.github.com/users/raleighgreen","html_url":"https://github.com/raleighgreen","followers_url":"https://api.github.com/users/raleighgreen/followers","following_url":"https://api.github.com/users/raleighgreen/following{/other_user}","gists_url":"https://api.github.com/users/raleighgreen/gists{/gist_id}","starred_url":"https://api.github.com/users/raleighgreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raleighgreen/subscriptions","organizations_url":"https://api.github.com/users/raleighgreen/orgs","repos_url":"https://api.github.com/users/raleighgreen/repos","events_url":"https://api.github.com/users/raleighgreen/events{/privacy}","received_events_url":"https://api.github.com/users/raleighgreen/received_events","type":"User","site_admin":false},"repo":{"id":67807074,"name":"fretArt","full_name":"raleighgreen/fretArt","owner":{"login":"raleighgreen","id":566390,"avatar_url":"https://avatars.githubusercontent.com/u/566390?v=3","gravatar_id":"","url":"https://api.github.com/users/raleighgreen","html_url":"https://github.com/raleighgreen","followers_url":"https://api.github.com/users/raleighgreen/followers","following_url":"https://api.github.com/users/raleighgreen/following{/other_user}","gists_url":"https://api.github.com/users/raleighgreen/gists{/gist_id}","starred_url":"https://api.github.com/users/raleighgreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raleighgreen/subscriptions","organizations_url":"https://api.github.com/users/raleighgreen/orgs","repos_url":"https://api.github.com/users/raleighgreen/repos","events_url":"https://api.github.com/users/raleighgreen/events{/privacy}","received_events_url":"https://api.github.com/users/raleighgreen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/raleighgreen/fretArt","description":null,"fork":false,"url":"https://api.github.com/repos/raleighgreen/fretArt","forks_url":"https://api.github.com/repos/raleighgreen/fretArt/forks","keys_url":"https://api.github.com/repos/raleighgreen/fretArt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raleighgreen/fretArt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raleighgreen/fretArt/teams","hooks_url":"https://api.github.com/repos/raleighgreen/fretArt/hooks","issue_events_url":"https://api.github.com/repos/raleighgreen/fretArt/issues/events{/number}","events_url":"https://api.github.com/repos/raleighgreen/fretArt/events","assignees_url":"https://api.github.com/repos/raleighgreen/fretArt/assignees{/user}","branches_url":"https://api.github.com/repos/raleighgreen/fretArt/branches{/branch}","tags_url":"https://api.github.com/repos/raleighgreen/fretArt/tags","blobs_url":"https://api.github.com/repos/raleighgreen/fretArt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raleighgreen/fretArt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raleighgreen/fretArt/git/refs{/sha}","trees_url":"https://api.github.com/repos/raleighgreen/fretArt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raleighgreen/fretArt/statuses/{sha}","languages_url":"https://api.github.com/repos/raleighgreen/fretArt/languages","stargazers_url":"https://api.github.com/repos/raleighgreen/fretArt/stargazers","contributors_url":"https://api.github.com/repos/raleighgreen/fretArt/contributors","subscribers_url":"https://api.github.com/repos/raleighgreen/fretArt/subscribers","subscription_url":"https://api.github.com/repos/raleighgreen/fretArt/subscription","commits_url":"https://api.github.com/repos/raleighgreen/fretArt/commits{/sha}","git_commits_url":"https://api.github.com/repos/raleighgreen/fretArt/git/commits{/sha}","comments_url":"https://api.github.com/repos/raleighgreen/fretArt/comments{/number}","issue_comment_url":"https://api.github.com/repos/raleighgreen/fretArt/issues/comments{/number}","contents_url":"https://api.github.com/repos/raleighgreen/fretArt/contents/{+path}","compare_url":"https://api.github.com/repos/raleighgreen/fretArt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raleighgreen/fretArt/merges","archive_url":"https://api.github.com/repos/raleighgreen/fretArt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raleighgreen/fretArt/downloads","issues_url":"https://api.github.com/repos/raleighgreen/fretArt/issues{/number}","pulls_url":"https://api.github.com/repos/raleighgreen/fretArt/pulls{/number}","milestones_url":"https://api.github.com/repos/raleighgreen/fretArt/milestones{/number}","notifications_url":"https://api.github.com/repos/raleighgreen/fretArt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raleighgreen/fretArt/labels{/name}","releases_url":"https://api.github.com/repos/raleighgreen/fretArt/releases{/id}","deployments_url":"https://api.github.com/repos/raleighgreen/fretArt/deployments","created_at":"2016-09-09T14:45:16Z","updated_at":"2016-09-09T14:48:39Z","pushed_at":"2016-10-27T14:41:57Z","git_url":"git://github.com/raleighgreen/fretArt.git","ssh_url":"git@github.com:raleighgreen/fretArt.git","clone_url":"https://github.com/raleighgreen/fretArt.git","svn_url":"https://github.com/raleighgreen/fretArt","homepage":null,"size":2385,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"raleighgreen:master","ref":"master","sha":"6996c87ce7e24c57442ed0e0ecbebe49338937ea","user":{"login":"raleighgreen","id":566390,"avatar_url":"https://avatars.githubusercontent.com/u/566390?v=3","gravatar_id":"","url":"https://api.github.com/users/raleighgreen","html_url":"https://github.com/raleighgreen","followers_url":"https://api.github.com/users/raleighgreen/followers","following_url":"https://api.github.com/users/raleighgreen/following{/other_user}","gists_url":"https://api.github.com/users/raleighgreen/gists{/gist_id}","starred_url":"https://api.github.com/users/raleighgreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raleighgreen/subscriptions","organizations_url":"https://api.github.com/users/raleighgreen/orgs","repos_url":"https://api.github.com/users/raleighgreen/repos","events_url":"https://api.github.com/users/raleighgreen/events{/privacy}","received_events_url":"https://api.github.com/users/raleighgreen/received_events","type":"User","site_admin":false},"repo":{"id":67807074,"name":"fretArt","full_name":"raleighgreen/fretArt","owner":{"login":"raleighgreen","id":566390,"avatar_url":"https://avatars.githubusercontent.com/u/566390?v=3","gravatar_id":"","url":"https://api.github.com/users/raleighgreen","html_url":"https://github.com/raleighgreen","followers_url":"https://api.github.com/users/raleighgreen/followers","following_url":"https://api.github.com/users/raleighgreen/following{/other_user}","gists_url":"https://api.github.com/users/raleighgreen/gists{/gist_id}","starred_url":"https://api.github.com/users/raleighgreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raleighgreen/subscriptions","organizations_url":"https://api.github.com/users/raleighgreen/orgs","repos_url":"https://api.github.com/users/raleighgreen/repos","events_url":"https://api.github.com/users/raleighgreen/events{/privacy}","received_events_url":"https://api.github.com/users/raleighgreen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/raleighgreen/fretArt","description":null,"fork":false,"url":"https://api.github.com/repos/raleighgreen/fretArt","forks_url":"https://api.github.com/repos/raleighgreen/fretArt/forks","keys_url":"https://api.github.com/repos/raleighgreen/fretArt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raleighgreen/fretArt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raleighgreen/fretArt/teams","hooks_url":"https://api.github.com/repos/raleighgreen/fretArt/hooks","issue_events_url":"https://api.github.com/repos/raleighgreen/fretArt/issues/events{/number}","events_url":"https://api.github.com/repos/raleighgreen/fretArt/events","assignees_url":"https://api.github.com/repos/raleighgreen/fretArt/assignees{/user}","branches_url":"https://api.github.com/repos/raleighgreen/fretArt/branches{/branch}","tags_url":"https://api.github.com/repos/raleighgreen/fretArt/tags","blobs_url":"https://api.github.com/repos/raleighgreen/fretArt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raleighgreen/fretArt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raleighgreen/fretArt/git/refs{/sha}","trees_url":"https://api.github.com/repos/raleighgreen/fretArt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raleighgreen/fretArt/statuses/{sha}","languages_url":"https://api.github.com/repos/raleighgreen/fretArt/languages","stargazers_url":"https://api.github.com/repos/raleighgreen/fretArt/stargazers","contributors_url":"https://api.github.com/repos/raleighgreen/fretArt/contributors","subscribers_url":"https://api.github.com/repos/raleighgreen/fretArt/subscribers","subscription_url":"https://api.github.com/repos/raleighgreen/fretArt/subscription","commits_url":"https://api.github.com/repos/raleighgreen/fretArt/commits{/sha}","git_commits_url":"https://api.github.com/repos/raleighgreen/fretArt/git/commits{/sha}","comments_url":"https://api.github.com/repos/raleighgreen/fretArt/comments{/number}","issue_comment_url":"https://api.github.com/repos/raleighgreen/fretArt/issues/comments{/number}","contents_url":"https://api.github.com/repos/raleighgreen/fretArt/contents/{+path}","compare_url":"https://api.github.com/repos/raleighgreen/fretArt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raleighgreen/fretArt/merges","archive_url":"https://api.github.com/repos/raleighgreen/fretArt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raleighgreen/fretArt/downloads","issues_url":"https://api.github.com/repos/raleighgreen/fretArt/issues{/number}","pulls_url":"https://api.github.com/repos/raleighgreen/fretArt/pulls{/number}","milestones_url":"https://api.github.com/repos/raleighgreen/fretArt/milestones{/number}","notifications_url":"https://api.github.com/repos/raleighgreen/fretArt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raleighgreen/fretArt/labels{/name}","releases_url":"https://api.github.com/repos/raleighgreen/fretArt/releases{/id}","deployments_url":"https://api.github.com/repos/raleighgreen/fretArt/deployments","created_at":"2016-09-09T14:45:16Z","updated_at":"2016-09-09T14:48:39Z","pushed_at":"2016-10-27T14:41:57Z","git_url":"git://github.com/raleighgreen/fretArt.git","ssh_url":"git@github.com:raleighgreen/fretArt.git","clone_url":"https://github.com/raleighgreen/fretArt.git","svn_url":"https://github.com/raleighgreen/fretArt","homepage":null,"size":2385,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/raleighgreen/fretArt/pulls/9"},"html":{"href":"https://github.com/raleighgreen/fretArt/pull/9"},"issue":{"href":"https://api.github.com/repos/raleighgreen/fretArt/issues/9"},"comments":{"href":"https://api.github.com/repos/raleighgreen/fretArt/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/raleighgreen/fretArt/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/raleighgreen/fretArt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/raleighgreen/fretArt/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/raleighgreen/fretArt/statuses/213c0834b1f3ab9bd0fca4bff81864e445bef597"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":319,"deletions":359,"changed_files":8}}
{"actor":{"display_login":"raleighgreen"}}