{"action":"created","issue":{"url":"https://api.github.com/repos/guysoft/OctoPi/issues/114","labels_url":"https://api.github.com/repos/guysoft/OctoPi/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/guysoft/OctoPi/issues/114/comments","events_url":"https://api.github.com/repos/guysoft/OctoPi/issues/114/events","html_url":"https://github.com/guysoft/OctoPi/pull/114","id":89090746,"number":114,"title":"Added wrapper script for git for sudo","user":{"login":"foosel","id":83657,"avatar_url":"https://avatars.githubusercontent.com/u/83657?v=3","gravatar_id":"","url":"https://api.github.com/users/foosel","html_url":"https://github.com/foosel","followers_url":"https://api.github.com/users/foosel/followers","following_url":"https://api.github.com/users/foosel/following{/other_user}","gists_url":"https://api.github.com/users/foosel/gists{/gist_id}","starred_url":"https://api.github.com/users/foosel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foosel/subscriptions","organizations_url":"https://api.github.com/users/foosel/orgs","repos_url":"https://api.github.com/users/foosel/repos","events_url":"https://api.github.com/users/foosel/events{/privacy}","received_events_url":"https://api.github.com/users/foosel/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-17T18:28:12Z","updated_at":"2016-01-24T21:03:19Z","closed_at":"2015-06-19T17:30:09Z","pull_request":{"url":"https://api.github.com/repos/guysoft/OctoPi/pulls/114","html_url":"https://github.com/guysoft/OctoPi/pull/114","diff_url":"https://github.com/guysoft/OctoPi/pull/114.diff","patch_url":"https://github.com/guysoft/OctoPi/pull/114.patch"},"body":"This will be found first when executing sudo git and checks whether\r\nit is running with super user privileges and if so refuses to do\r\nthat and instead just prints a friendly message to please run git\r\nwithout sudo.\r\n\r\nReason: Apparently users tend to do a \"sudo git pull\" when updating\r\nOctoPrint, effectively screwing up their permissions in the process\r\nand then running into problems later on. This should hopefully act\r\nas an educational measure to stop this from happening."},"comment":{"url":"https://api.github.com/repos/guysoft/OctoPi/issues/comments/174341465","html_url":"https://github.com/guysoft/OctoPi/pull/114#issuecomment-174341465","issue_url":"https://api.github.com/repos/guysoft/OctoPi/issues/114","id":174341465,"user":{"login":"foosel","id":83657,"avatar_url":"https://avatars.githubusercontent.com/u/83657?v=3","gravatar_id":"","url":"https://api.github.com/users/foosel","html_url":"https://github.com/foosel","followers_url":"https://api.github.com/users/foosel/followers","following_url":"https://api.github.com/users/foosel/following{/other_user}","gists_url":"https://api.github.com/users/foosel/gists{/gist_id}","starred_url":"https://api.github.com/users/foosel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foosel/subscriptions","organizations_url":"https://api.github.com/users/foosel/orgs","repos_url":"https://api.github.com/users/foosel/repos","events_url":"https://api.github.com/users/foosel/events{/privacy}","received_events_url":"https://api.github.com/users/foosel/received_events","type":"User","site_admin":false},"created_at":"2016-01-24T21:03:18Z","updated_at":"2016-01-24T21:03:18Z","body":"First of all: why does installing ffmpeg (which btw is already included on OctoPi as part of the avconv package) need sudo git?\r\n\r\nAnd secondly: yes, it does limit the user. But I'd rather add another script to remove that wrapper script by users who know what they are doing (\"reenable-sudo\") than having to cope with endless \"my installation is broken after I used sudo for everything although all instructions explicitly say to not to do that\" support requests, which was what was going on before this change was added. Btw, people still do that even though current versions of OctoPrint update themselves. \r\n\r\nIf you know what you are doing, you can just remove the wrapper script from your installation. It is really just a script earlier in the path than the installed git binary. Or become root. Or use the full path to the git binary. "}}