{"action":"created","comment":{"url":"https://api.github.com/repos/poparteu/openMVG/pulls/comments/74123059","id":74123059,"diff_hunk":"@@ -421,10 +422,11 @@ CCTagLocalizer::~CCTagLocalizer()\n // subposes is n-1 as we consider the first camera as the main camera and the \n // reference frame of the grid\n bool CCTagLocalizer::localizeRig(const std::vector<image::Image<unsigned char> > & vec_imageGrey,\n-                              const LocalizerParameters *parameters,\n-                              std::vector<cameras::Pinhole_Intrinsic_Radial_K3 > &vec_queryIntrinsics,\n-                              const std::vector<geometry::Pose3 > &vec_subPoses,\n-                              geometry::Pose3 &rigPose)\n+                                 const LocalizerParameters *parameters,\n+                                 std::vector<cameras::Pinhole_Intrinsic_Radial_K3 > &vec_queryIntrinsics,\n+                                 const std::vector<geometry::Pose3 > &vec_subPoses,\n+                                 geometry::Pose3 &rigPose,","path":"src/openMVG/localization/CCTagLocalizer.cpp","position":null,"original_position":19,"commit_id":"175960ebce740b8414e3f58948595a181d8f3c7b","original_commit_id":"175960ebce740b8414e3f58948595a181d8f3c7b","user":{"login":"fabiencastan","id":153585,"avatar_url":"https://avatars.githubusercontent.com/u/153585?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiencastan","html_url":"https://github.com/fabiencastan","followers_url":"https://api.github.com/users/fabiencastan/followers","following_url":"https://api.github.com/users/fabiencastan/following{/other_user}","gists_url":"https://api.github.com/users/fabiencastan/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiencastan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiencastan/subscriptions","organizations_url":"https://api.github.com/users/fabiencastan/orgs","repos_url":"https://api.github.com/users/fabiencastan/repos","events_url":"https://api.github.com/users/fabiencastan/events{/privacy}","received_events_url":"https://api.github.com/users/fabiencastan/received_events","type":"User","site_admin":false},"body":"LocalizationResults already include poses, isn't it?","created_at":"2016-08-09T18:58:27Z","updated_at":"2016-08-09T18:58:27Z","html_url":"https://github.com/poparteu/openMVG/pull/190#discussion_r74123059","pull_request_url":"https://api.github.com/repos/poparteu/openMVG/pulls/190","_links":{"self":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/comments/74123059"},"html":{"href":"https://github.com/poparteu/openMVG/pull/190#discussion_r74123059"},"pull_request":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/190"}}},"pull_request":{"url":"https://api.github.com/repos/poparteu/openMVG/pulls/190","id":78712450,"html_url":"https://github.com/poparteu/openMVG/pull/190","diff_url":"https://github.com/poparteu/openMVG/pull/190.diff","patch_url":"https://github.com/poparteu/openMVG/pull/190.patch","issue_url":"https://api.github.com/repos/poparteu/openMVG/issues/190","number":190,"state":"open","locked":false,"title":"Add openGV support for rig localization","user":{"login":"simogasp","id":1331744,"avatar_url":"https://avatars.githubusercontent.com/u/1331744?v=3","gravatar_id":"","url":"https://api.github.com/users/simogasp","html_url":"https://github.com/simogasp","followers_url":"https://api.github.com/users/simogasp/followers","following_url":"https://api.github.com/users/simogasp/following{/other_user}","gists_url":"https://api.github.com/users/simogasp/gists{/gist_id}","starred_url":"https://api.github.com/users/simogasp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simogasp/subscriptions","organizations_url":"https://api.github.com/users/simogasp/orgs","repos_url":"https://api.github.com/users/simogasp/repos","events_url":"https://api.github.com/users/simogasp/events{/privacy}","received_events_url":"https://api.github.com/users/simogasp/received_events","type":"User","site_admin":false},"body":"* [x] added OpenGV dependency\r\n* [x] added localizeRig() implementation for all *Localizers\r\n* [x] added unity tests\r\n* [x] added travis rule to build and cache OpenGV\r\n* [x] added `LocalizationResult` as output of `localizeRig()` connected to poparteu/openMVG#208\r\n\r\n\r\nconnected to poparteu/openMVG#93","created_at":"2016-07-25T16:33:37Z","updated_at":"2016-08-09T18:58:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b829bff8f17fc03b79e989145a1ae8e5e1e55495","assignee":{"login":"fabiencastan","id":153585,"avatar_url":"https://avatars.githubusercontent.com/u/153585?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiencastan","html_url":"https://github.com/fabiencastan","followers_url":"https://api.github.com/users/fabiencastan/followers","following_url":"https://api.github.com/users/fabiencastan/following{/other_user}","gists_url":"https://api.github.com/users/fabiencastan/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiencastan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiencastan/subscriptions","organizations_url":"https://api.github.com/users/fabiencastan/orgs","repos_url":"https://api.github.com/users/fabiencastan/repos","events_url":"https://api.github.com/users/fabiencastan/events{/privacy}","received_events_url":"https://api.github.com/users/fabiencastan/received_events","type":"User","site_admin":false},"assignees":[{"login":"fabiencastan","id":153585,"avatar_url":"https://avatars.githubusercontent.com/u/153585?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiencastan","html_url":"https://github.com/fabiencastan","followers_url":"https://api.github.com/users/fabiencastan/followers","following_url":"https://api.github.com/users/fabiencastan/following{/other_user}","gists_url":"https://api.github.com/users/fabiencastan/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiencastan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiencastan/subscriptions","organizations_url":"https://api.github.com/users/fabiencastan/orgs","repos_url":"https://api.github.com/users/fabiencastan/repos","events_url":"https://api.github.com/users/fabiencastan/events{/privacy}","received_events_url":"https://api.github.com/users/fabiencastan/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/poparteu/openMVG/milestones/14","html_url":"https://github.com/poparteu/openMVG/milestones/2016_08","labels_url":"https://api.github.com/repos/poparteu/openMVG/milestones/14/labels","id":1812937,"number":14,"title":"2016_08","description":"","creator":{"login":"simogasp","id":1331744,"avatar_url":"https://avatars.githubusercontent.com/u/1331744?v=3","gravatar_id":"","url":"https://api.github.com/users/simogasp","html_url":"https://github.com/simogasp","followers_url":"https://api.github.com/users/simogasp/followers","following_url":"https://api.github.com/users/simogasp/following{/other_user}","gists_url":"https://api.github.com/users/simogasp/gists{/gist_id}","starred_url":"https://api.github.com/users/simogasp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simogasp/subscriptions","organizations_url":"https://api.github.com/users/simogasp/orgs","repos_url":"https://api.github.com/users/simogasp/repos","events_url":"https://api.github.com/users/simogasp/events{/privacy}","received_events_url":"https://api.github.com/users/simogasp/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":3,"state":"open","created_at":"2016-06-07T08:43:54Z","updated_at":"2016-08-09T13:26:09Z","due_on":"2016-08-31T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/poparteu/openMVG/pulls/190/commits","review_comments_url":"https://api.github.com/repos/poparteu/openMVG/pulls/190/comments","review_comment_url":"https://api.github.com/repos/poparteu/openMVG/pulls/comments{/number}","comments_url":"https://api.github.com/repos/poparteu/openMVG/issues/190/comments","statuses_url":"https://api.github.com/repos/poparteu/openMVG/statuses/175960ebce740b8414e3f58948595a181d8f3c7b","head":{"label":"poparteu:popart_opengv","ref":"popart_opengv","sha":"175960ebce740b8414e3f58948595a181d8f3c7b","user":{"login":"poparteu","id":9333123,"avatar_url":"https://avatars.githubusercontent.com/u/9333123?v=3","gravatar_id":"","url":"https://api.github.com/users/poparteu","html_url":"https://github.com/poparteu","followers_url":"https://api.github.com/users/poparteu/followers","following_url":"https://api.github.com/users/poparteu/following{/other_user}","gists_url":"https://api.github.com/users/poparteu/gists{/gist_id}","starred_url":"https://api.github.com/users/poparteu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poparteu/subscriptions","organizations_url":"https://api.github.com/users/poparteu/orgs","repos_url":"https://api.github.com/users/poparteu/repos","events_url":"https://api.github.com/users/poparteu/events{/privacy}","received_events_url":"https://api.github.com/users/poparteu/received_events","type":"Organization","site_admin":false},"repo":{"id":28635894,"name":"openMVG","full_name":"poparteu/openMVG","owner":{"login":"poparteu","id":9333123,"avatar_url":"https://avatars.githubusercontent.com/u/9333123?v=3","gravatar_id":"","url":"https://api.github.com/users/poparteu","html_url":"https://github.com/poparteu","followers_url":"https://api.github.com/users/poparteu/followers","following_url":"https://api.github.com/users/poparteu/following{/other_user}","gists_url":"https://api.github.com/users/poparteu/gists{/gist_id}","starred_url":"https://api.github.com/users/poparteu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poparteu/subscriptions","organizations_url":"https://api.github.com/users/poparteu/orgs","repos_url":"https://api.github.com/users/poparteu/repos","events_url":"https://api.github.com/users/poparteu/events{/privacy}","received_events_url":"https://api.github.com/users/poparteu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/poparteu/openMVG","description":"open Multiple View Geometry library. Basis for 3D computer vision and Structure from Motion.","fork":true,"url":"https://api.github.com/repos/poparteu/openMVG","forks_url":"https://api.github.com/repos/poparteu/openMVG/forks","keys_url":"https://api.github.com/repos/poparteu/openMVG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poparteu/openMVG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poparteu/openMVG/teams","hooks_url":"https://api.github.com/repos/poparteu/openMVG/hooks","issue_events_url":"https://api.github.com/repos/poparteu/openMVG/issues/events{/number}","events_url":"https://api.github.com/repos/poparteu/openMVG/events","assignees_url":"https://api.github.com/repos/poparteu/openMVG/assignees{/user}","branches_url":"https://api.github.com/repos/poparteu/openMVG/branches{/branch}","tags_url":"https://api.github.com/repos/poparteu/openMVG/tags","blobs_url":"https://api.github.com/repos/poparteu/openMVG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poparteu/openMVG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poparteu/openMVG/git/refs{/sha}","trees_url":"https://api.github.com/repos/poparteu/openMVG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poparteu/openMVG/statuses/{sha}","languages_url":"https://api.github.com/repos/poparteu/openMVG/languages","stargazers_url":"https://api.github.com/repos/poparteu/openMVG/stargazers","contributors_url":"https://api.github.com/repos/poparteu/openMVG/contributors","subscribers_url":"https://api.github.com/repos/poparteu/openMVG/subscribers","subscription_url":"https://api.github.com/repos/poparteu/openMVG/subscription","commits_url":"https://api.github.com/repos/poparteu/openMVG/commits{/sha}","git_commits_url":"https://api.github.com/repos/poparteu/openMVG/git/commits{/sha}","comments_url":"https://api.github.com/repos/poparteu/openMVG/comments{/number}","issue_comment_url":"https://api.github.com/repos/poparteu/openMVG/issues/comments{/number}","contents_url":"https://api.github.com/repos/poparteu/openMVG/contents/{+path}","compare_url":"https://api.github.com/repos/poparteu/openMVG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poparteu/openMVG/merges","archive_url":"https://api.github.com/repos/poparteu/openMVG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poparteu/openMVG/downloads","issues_url":"https://api.github.com/repos/poparteu/openMVG/issues{/number}","pulls_url":"https://api.github.com/repos/poparteu/openMVG/pulls{/number}","milestones_url":"https://api.github.com/repos/poparteu/openMVG/milestones{/number}","notifications_url":"https://api.github.com/repos/poparteu/openMVG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poparteu/openMVG/labels{/name}","releases_url":"https://api.github.com/repos/poparteu/openMVG/releases{/id}","deployments_url":"https://api.github.com/repos/poparteu/openMVG/deployments","created_at":"2014-12-30T15:39:27Z","updated_at":"2016-07-14T17:32:10Z","pushed_at":"2016-08-09T16:07:23Z","git_url":"git://github.com/poparteu/openMVG.git","ssh_url":"git@github.com:poparteu/openMVG.git","clone_url":"https://github.com/poparteu/openMVG.git","svn_url":"https://github.com/poparteu/openMVG","homepage":"","size":24900,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":55,"forks":2,"open_issues":55,"watchers":2,"default_branch":"popart_develop"}},"base":{"label":"poparteu:popart_develop","ref":"popart_develop","sha":"312c067013bf373fff52697eba102e27a9a2f556","user":{"login":"poparteu","id":9333123,"avatar_url":"https://avatars.githubusercontent.com/u/9333123?v=3","gravatar_id":"","url":"https://api.github.com/users/poparteu","html_url":"https://github.com/poparteu","followers_url":"https://api.github.com/users/poparteu/followers","following_url":"https://api.github.com/users/poparteu/following{/other_user}","gists_url":"https://api.github.com/users/poparteu/gists{/gist_id}","starred_url":"https://api.github.com/users/poparteu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poparteu/subscriptions","organizations_url":"https://api.github.com/users/poparteu/orgs","repos_url":"https://api.github.com/users/poparteu/repos","events_url":"https://api.github.com/users/poparteu/events{/privacy}","received_events_url":"https://api.github.com/users/poparteu/received_events","type":"Organization","site_admin":false},"repo":{"id":28635894,"name":"openMVG","full_name":"poparteu/openMVG","owner":{"login":"poparteu","id":9333123,"avatar_url":"https://avatars.githubusercontent.com/u/9333123?v=3","gravatar_id":"","url":"https://api.github.com/users/poparteu","html_url":"https://github.com/poparteu","followers_url":"https://api.github.com/users/poparteu/followers","following_url":"https://api.github.com/users/poparteu/following{/other_user}","gists_url":"https://api.github.com/users/poparteu/gists{/gist_id}","starred_url":"https://api.github.com/users/poparteu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poparteu/subscriptions","organizations_url":"https://api.github.com/users/poparteu/orgs","repos_url":"https://api.github.com/users/poparteu/repos","events_url":"https://api.github.com/users/poparteu/events{/privacy}","received_events_url":"https://api.github.com/users/poparteu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/poparteu/openMVG","description":"open Multiple View Geometry library. Basis for 3D computer vision and Structure from Motion.","fork":true,"url":"https://api.github.com/repos/poparteu/openMVG","forks_url":"https://api.github.com/repos/poparteu/openMVG/forks","keys_url":"https://api.github.com/repos/poparteu/openMVG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poparteu/openMVG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poparteu/openMVG/teams","hooks_url":"https://api.github.com/repos/poparteu/openMVG/hooks","issue_events_url":"https://api.github.com/repos/poparteu/openMVG/issues/events{/number}","events_url":"https://api.github.com/repos/poparteu/openMVG/events","assignees_url":"https://api.github.com/repos/poparteu/openMVG/assignees{/user}","branches_url":"https://api.github.com/repos/poparteu/openMVG/branches{/branch}","tags_url":"https://api.github.com/repos/poparteu/openMVG/tags","blobs_url":"https://api.github.com/repos/poparteu/openMVG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poparteu/openMVG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poparteu/openMVG/git/refs{/sha}","trees_url":"https://api.github.com/repos/poparteu/openMVG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poparteu/openMVG/statuses/{sha}","languages_url":"https://api.github.com/repos/poparteu/openMVG/languages","stargazers_url":"https://api.github.com/repos/poparteu/openMVG/stargazers","contributors_url":"https://api.github.com/repos/poparteu/openMVG/contributors","subscribers_url":"https://api.github.com/repos/poparteu/openMVG/subscribers","subscription_url":"https://api.github.com/repos/poparteu/openMVG/subscription","commits_url":"https://api.github.com/repos/poparteu/openMVG/commits{/sha}","git_commits_url":"https://api.github.com/repos/poparteu/openMVG/git/commits{/sha}","comments_url":"https://api.github.com/repos/poparteu/openMVG/comments{/number}","issue_comment_url":"https://api.github.com/repos/poparteu/openMVG/issues/comments{/number}","contents_url":"https://api.github.com/repos/poparteu/openMVG/contents/{+path}","compare_url":"https://api.github.com/repos/poparteu/openMVG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poparteu/openMVG/merges","archive_url":"https://api.github.com/repos/poparteu/openMVG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poparteu/openMVG/downloads","issues_url":"https://api.github.com/repos/poparteu/openMVG/issues{/number}","pulls_url":"https://api.github.com/repos/poparteu/openMVG/pulls{/number}","milestones_url":"https://api.github.com/repos/poparteu/openMVG/milestones{/number}","notifications_url":"https://api.github.com/repos/poparteu/openMVG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poparteu/openMVG/labels{/name}","releases_url":"https://api.github.com/repos/poparteu/openMVG/releases{/id}","deployments_url":"https://api.github.com/repos/poparteu/openMVG/deployments","created_at":"2014-12-30T15:39:27Z","updated_at":"2016-07-14T17:32:10Z","pushed_at":"2016-08-09T16:07:23Z","git_url":"git://github.com/poparteu/openMVG.git","ssh_url":"git@github.com:poparteu/openMVG.git","clone_url":"https://github.com/poparteu/openMVG.git","svn_url":"https://github.com/poparteu/openMVG","homepage":"","size":24900,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":55,"forks":2,"open_issues":55,"watchers":2,"default_branch":"popart_develop"}},"_links":{"self":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/190"},"html":{"href":"https://github.com/poparteu/openMVG/pull/190"},"issue":{"href":"https://api.github.com/repos/poparteu/openMVG/issues/190"},"comments":{"href":"https://api.github.com/repos/poparteu/openMVG/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/poparteu/openMVG/statuses/175960ebce740b8414e3f58948595a181d8f3c7b"}}}}
{"actor":{"display_login":"fabiencastan"}}