{"action":"created","comment":{"url":"https://api.github.com/repos/HubSpot/Blazar/pulls/comments/80280631","id":80280631,"diff_hunk":"@@ -3,29 +3,15 @@\n import static org.assertj.core.api.Assertions.fail;\n \n import org.junit.After;\n-import org.junit.BeforeClass;\n-import org.slf4j.Logger;\n-import org.slf4j.LoggerFactory;\n \n-import com.google.inject.Guice;\n-import com.hubspot.blazar.test.base.service.BlazarTestBase;\n+import com.google.inject.Inject;\n+import com.hubspot.blazar.test.base.service.DatabaseBackedTest;\n \n-public class BlazarServiceTestBase extends BlazarTestBase {\n-  private static final Logger LOG = LoggerFactory.getLogger(BlazarServiceTestBase.class);\n-\n-  @BeforeClass\n-  public static void setup() throws Exception {\n-    synchronized (injector) {\n-      if (injector.get() == null) {\n-        injector.set(Guice.createInjector(new BlazarServiceTestModule()));\n-        runSql(\"schema.sql\");\n-      }\n-    }\n-  }\n+public class BlazarServiceTestBase extends DatabaseBackedTest {\n \n   @After\n-  public void cleanup() throws Exception {\n-    runSql(\"schema.sql\");\n+  @Inject\n+  public void checkEventBusExceptions() throws Exception {","path":"BlazarService/src/test/java/com/hubspot/blazar/BlazarServiceTestBase.java","position":31,"original_position":31,"commit_id":"6999028f340183153df489c0a084eb6592c8ecc5","original_commit_id":"6999028f340183153df489c0a084eb6592c8ecc5","user":{"login":"jonathanwgoodwin","id":3247956,"avatar_url":"https://avatars.githubusercontent.com/u/3247956?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanwgoodwin","html_url":"https://github.com/jonathanwgoodwin","followers_url":"https://api.github.com/users/jonathanwgoodwin/followers","following_url":"https://api.github.com/users/jonathanwgoodwin/following{/other_user}","gists_url":"https://api.github.com/users/jonathanwgoodwin/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanwgoodwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanwgoodwin/subscriptions","organizations_url":"https://api.github.com/users/jonathanwgoodwin/orgs","repos_url":"https://api.github.com/users/jonathanwgoodwin/repos","events_url":"https://api.github.com/users/jonathanwgoodwin/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanwgoodwin/received_events","type":"User","site_admin":false},"body":"All the service layer tests use the event bus.","created_at":"2016-09-23T16:41:36Z","updated_at":"2016-09-23T16:41:36Z","html_url":"https://github.com/HubSpot/Blazar/pull/245#discussion_r80280631","pull_request_url":"https://api.github.com/repos/HubSpot/Blazar/pulls/245","_links":{"self":{"href":"https://api.github.com/repos/HubSpot/Blazar/pulls/comments/80280631"},"html":{"href":"https://github.com/HubSpot/Blazar/pull/245#discussion_r80280631"},"pull_request":{"href":"https://api.github.com/repos/HubSpot/Blazar/pulls/245"}}},"pull_request":{"url":"https://api.github.com/repos/HubSpot/Blazar/pulls/245","id":85614576,"html_url":"https://github.com/HubSpot/Blazar/pull/245","diff_url":"https://github.com/HubSpot/Blazar/pull/245.diff","patch_url":"https://github.com/HubSpot/Blazar/pull/245.patch","issue_url":"https://api.github.com/repos/HubSpot/Blazar/issues/245","number":245,"state":"open","locked":false,"title":"Hikari + embdedded mysql","user":{"login":"jonathanwgoodwin","id":3247956,"avatar_url":"https://avatars.githubusercontent.com/u/3247956?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanwgoodwin","html_url":"https://github.com/jonathanwgoodwin","followers_url":"https://api.github.com/users/jonathanwgoodwin/followers","following_url":"https://api.github.com/users/jonathanwgoodwin/following{/other_user}","gists_url":"https://api.github.com/users/jonathanwgoodwin/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanwgoodwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanwgoodwin/subscriptions","organizations_url":"https://api.github.com/users/jonathanwgoodwin/orgs","repos_url":"https://api.github.com/users/jonathanwgoodwin/repos","events_url":"https://api.github.com/users/jonathanwgoodwin/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanwgoodwin/received_events","type":"User","site_admin":false},"body":"This PR attempts to replace the `h2` database we were using before with embedded mysql.\r\n\r\nCurrently this works for the Data module but something is up with the service module tests.\r\nThere are Multiple mysqls being started, which I think is leading to the test queries running against different a one than the schema resulting in errors finding tables in the tests.\r\n\r\nCC: @gchomatas ","created_at":"2016-09-16T17:59:22Z","updated_at":"2016-09-23T16:41:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51bd3cb81317cb84332bd7502c8de1fe99167750","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/HubSpot/Blazar/pulls/245/commits","review_comments_url":"https://api.github.com/repos/HubSpot/Blazar/pulls/245/comments","review_comment_url":"https://api.github.com/repos/HubSpot/Blazar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HubSpot/Blazar/issues/245/comments","statuses_url":"https://api.github.com/repos/HubSpot/Blazar/statuses/6999028f340183153df489c0a084eb6592c8ecc5","head":{"label":"HubSpot:hikari","ref":"hikari","sha":"6999028f340183153df489c0a084eb6592c8ecc5","user":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"repo":{"id":38639709,"name":"Blazar","full_name":"HubSpot/Blazar","owner":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HubSpot/Blazar","description":"An out-of-this world build system!","fork":false,"url":"https://api.github.com/repos/HubSpot/Blazar","forks_url":"https://api.github.com/repos/HubSpot/Blazar/forks","keys_url":"https://api.github.com/repos/HubSpot/Blazar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HubSpot/Blazar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HubSpot/Blazar/teams","hooks_url":"https://api.github.com/repos/HubSpot/Blazar/hooks","issue_events_url":"https://api.github.com/repos/HubSpot/Blazar/issues/events{/number}","events_url":"https://api.github.com/repos/HubSpot/Blazar/events","assignees_url":"https://api.github.com/repos/HubSpot/Blazar/assignees{/user}","branches_url":"https://api.github.com/repos/HubSpot/Blazar/branches{/branch}","tags_url":"https://api.github.com/repos/HubSpot/Blazar/tags","blobs_url":"https://api.github.com/repos/HubSpot/Blazar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HubSpot/Blazar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HubSpot/Blazar/git/refs{/sha}","trees_url":"https://api.github.com/repos/HubSpot/Blazar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HubSpot/Blazar/statuses/{sha}","languages_url":"https://api.github.com/repos/HubSpot/Blazar/languages","stargazers_url":"https://api.github.com/repos/HubSpot/Blazar/stargazers","contributors_url":"https://api.github.com/repos/HubSpot/Blazar/contributors","subscribers_url":"https://api.github.com/repos/HubSpot/Blazar/subscribers","subscription_url":"https://api.github.com/repos/HubSpot/Blazar/subscription","commits_url":"https://api.github.com/repos/HubSpot/Blazar/commits{/sha}","git_commits_url":"https://api.github.com/repos/HubSpot/Blazar/git/commits{/sha}","comments_url":"https://api.github.com/repos/HubSpot/Blazar/comments{/number}","issue_comment_url":"https://api.github.com/repos/HubSpot/Blazar/issues/comments{/number}","contents_url":"https://api.github.com/repos/HubSpot/Blazar/contents/{+path}","compare_url":"https://api.github.com/repos/HubSpot/Blazar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HubSpot/Blazar/merges","archive_url":"https://api.github.com/repos/HubSpot/Blazar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HubSpot/Blazar/downloads","issues_url":"https://api.github.com/repos/HubSpot/Blazar/issues{/number}","pulls_url":"https://api.github.com/repos/HubSpot/Blazar/pulls{/number}","milestones_url":"https://api.github.com/repos/HubSpot/Blazar/milestones{/number}","notifications_url":"https://api.github.com/repos/HubSpot/Blazar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HubSpot/Blazar/labels{/name}","releases_url":"https://api.github.com/repos/HubSpot/Blazar/releases{/id}","deployments_url":"https://api.github.com/repos/HubSpot/Blazar/deployments","created_at":"2015-07-06T18:59:45Z","updated_at":"2016-09-19T08:53:35Z","pushed_at":"2016-09-23T15:47:42Z","git_url":"git://github.com/HubSpot/Blazar.git","ssh_url":"git@github.com:HubSpot/Blazar.git","clone_url":"https://github.com/HubSpot/Blazar.git","svn_url":"https://github.com/HubSpot/Blazar","homepage":null,"size":3790,"stargazers_count":49,"watchers_count":49,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":49,"default_branch":"master"}},"base":{"label":"HubSpot:master","ref":"master","sha":"90ca7ab2425b89b89df97445780ec77e72ca57d5","user":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"repo":{"id":38639709,"name":"Blazar","full_name":"HubSpot/Blazar","owner":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HubSpot/Blazar","description":"An out-of-this world build system!","fork":false,"url":"https://api.github.com/repos/HubSpot/Blazar","forks_url":"https://api.github.com/repos/HubSpot/Blazar/forks","keys_url":"https://api.github.com/repos/HubSpot/Blazar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HubSpot/Blazar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HubSpot/Blazar/teams","hooks_url":"https://api.github.com/repos/HubSpot/Blazar/hooks","issue_events_url":"https://api.github.com/repos/HubSpot/Blazar/issues/events{/number}","events_url":"https://api.github.com/repos/HubSpot/Blazar/events","assignees_url":"https://api.github.com/repos/HubSpot/Blazar/assignees{/user}","branches_url":"https://api.github.com/repos/HubSpot/Blazar/branches{/branch}","tags_url":"https://api.github.com/repos/HubSpot/Blazar/tags","blobs_url":"https://api.github.com/repos/HubSpot/Blazar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HubSpot/Blazar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HubSpot/Blazar/git/refs{/sha}","trees_url":"https://api.github.com/repos/HubSpot/Blazar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HubSpot/Blazar/statuses/{sha}","languages_url":"https://api.github.com/repos/HubSpot/Blazar/languages","stargazers_url":"https://api.github.com/repos/HubSpot/Blazar/stargazers","contributors_url":"https://api.github.com/repos/HubSpot/Blazar/contributors","subscribers_url":"https://api.github.com/repos/HubSpot/Blazar/subscribers","subscription_url":"https://api.github.com/repos/HubSpot/Blazar/subscription","commits_url":"https://api.github.com/repos/HubSpot/Blazar/commits{/sha}","git_commits_url":"https://api.github.com/repos/HubSpot/Blazar/git/commits{/sha}","comments_url":"https://api.github.com/repos/HubSpot/Blazar/comments{/number}","issue_comment_url":"https://api.github.com/repos/HubSpot/Blazar/issues/comments{/number}","contents_url":"https://api.github.com/repos/HubSpot/Blazar/contents/{+path}","compare_url":"https://api.github.com/repos/HubSpot/Blazar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HubSpot/Blazar/merges","archive_url":"https://api.github.com/repos/HubSpot/Blazar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HubSpot/Blazar/downloads","issues_url":"https://api.github.com/repos/HubSpot/Blazar/issues{/number}","pulls_url":"https://api.github.com/repos/HubSpot/Blazar/pulls{/number}","milestones_url":"https://api.github.com/repos/HubSpot/Blazar/milestones{/number}","notifications_url":"https://api.github.com/repos/HubSpot/Blazar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HubSpot/Blazar/labels{/name}","releases_url":"https://api.github.com/repos/HubSpot/Blazar/releases{/id}","deployments_url":"https://api.github.com/repos/HubSpot/Blazar/deployments","created_at":"2015-07-06T18:59:45Z","updated_at":"2016-09-19T08:53:35Z","pushed_at":"2016-09-23T15:47:42Z","git_url":"git://github.com/HubSpot/Blazar.git","ssh_url":"git@github.com:HubSpot/Blazar.git","clone_url":"https://github.com/HubSpot/Blazar.git","svn_url":"https://github.com/HubSpot/Blazar","homepage":null,"size":3790,"stargazers_count":49,"watchers_count":49,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HubSpot/Blazar/pulls/245"},"html":{"href":"https://github.com/HubSpot/Blazar/pull/245"},"issue":{"href":"https://api.github.com/repos/HubSpot/Blazar/issues/245"},"comments":{"href":"https://api.github.com/repos/HubSpot/Blazar/issues/245/comments"},"review_comments":{"href":"https://api.github.com/repos/HubSpot/Blazar/pulls/245/comments"},"review_comment":{"href":"https://api.github.com/repos/HubSpot/Blazar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HubSpot/Blazar/pulls/245/commits"},"statuses":{"href":"https://api.github.com/repos/HubSpot/Blazar/statuses/6999028f340183153df489c0a084eb6592c8ecc5"}}}}
{"actor":{"display_login":"jonathanwgoodwin"}}