{"action":"created","issue":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/7351","repository_url":"https://api.github.com/repos/syl20bnr/spacemacs","labels_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/7351/labels{/name}","comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/7351/comments","events_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/7351/events","html_url":"https://github.com/syl20bnr/spacemacs/pull/7351","id":182043472,"number":7351,"title":"Fix usage of gorename on symlinked projects","user":{"login":"grncdr","id":82634,"avatar_url":"https://avatars.githubusercontent.com/u/82634?v=3","gravatar_id":"","url":"https://api.github.com/users/grncdr","html_url":"https://github.com/grncdr","followers_url":"https://api.github.com/users/grncdr/followers","following_url":"https://api.github.com/users/grncdr/following{/other_user}","gists_url":"https://api.github.com/users/grncdr/gists{/gist_id}","starred_url":"https://api.github.com/users/grncdr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grncdr/subscriptions","organizations_url":"https://api.github.com/users/grncdr/orgs","repos_url":"https://api.github.com/users/grncdr/repos","events_url":"https://api.github.com/users/grncdr/events{/privacy}","received_events_url":"https://api.github.com/users/grncdr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-10T15:24:50Z","updated_at":"2016-10-10T16:36:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/7351","html_url":"https://github.com/syl20bnr/spacemacs/pull/7351","diff_url":"https://github.com/syl20bnr/spacemacs/pull/7351.diff","patch_url":"https://github.com/syl20bnr/spacemacs/pull/7351.patch"},"body":"I often work on Go projects under a symlink, e.g. ~/Code/project points to\r\n$GOPATH/src/github.com/grncdr/...\r\n\r\nThis works fine 99% of the time, but gorename doesn't follow symlinks in order\r\nto get the \"truename\" of a file, so it will complain about\r\n~/Code/project/somefile.go not belonging to any package. This fixes that\r\nsituation by ensuring that gorename is only passed the true filename."},"comment":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/comments/252673643","html_url":"https://github.com/syl20bnr/spacemacs/pull/7351#issuecomment-252673643","issue_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/7351","id":252673643,"user":{"login":"d12frosted","id":6507913,"avatar_url":"https://avatars.githubusercontent.com/u/6507913?v=3","gravatar_id":"","url":"https://api.github.com/users/d12frosted","html_url":"https://github.com/d12frosted","followers_url":"https://api.github.com/users/d12frosted/followers","following_url":"https://api.github.com/users/d12frosted/following{/other_user}","gists_url":"https://api.github.com/users/d12frosted/gists{/gist_id}","starred_url":"https://api.github.com/users/d12frosted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d12frosted/subscriptions","organizations_url":"https://api.github.com/users/d12frosted/orgs","repos_url":"https://api.github.com/users/d12frosted/repos","events_url":"https://api.github.com/users/d12frosted/events{/privacy}","received_events_url":"https://api.github.com/users/d12frosted/received_events","type":"User","site_admin":false},"created_at":"2016-10-10T16:36:40Z","updated_at":"2016-10-10T16:36:40Z","body":"Haha. The same. I even had a thought that someone brouhgt some gore into\nSpacemacs.\n\nP. S. Sorry for the oftop. I like the change.\n\nOn Monday, 10 October 2016, Eivind Fonn <notifications@github.com> wrote:\n\n> Just a comment. I always read this is as gore-name.\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/syl20bnr/spacemacs/pull/7351#issuecomment-252672680>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AGNNiT1KhNs_KN_6rrjQAcGtpeNqZxmYks5qymirgaJpZM4KSr-W>\n> .\n>\n\n\n-- \nCheers,\nBoris\n"}}
{"actor":{"display_login":"d12frosted"}}