{"action":"created","issue":{"url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/1541","repository_url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL","labels_url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/1541/labels{/name}","comments_url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/1541/comments","events_url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/1541/events","html_url":"https://github.com/LoneGazebo/Community-Patch-DLL/issues/1541","id":145660599,"number":1541,"title":"Normalizing Corporations and making them more moddable","user":{"login":"mwhiter","id":4925402,"avatar_url":"https://avatars.githubusercontent.com/u/4925402?v=3","gravatar_id":"","url":"https://api.github.com/users/mwhiter","html_url":"https://github.com/mwhiter","followers_url":"https://api.github.com/users/mwhiter/followers","following_url":"https://api.github.com/users/mwhiter/following{/other_user}","gists_url":"https://api.github.com/users/mwhiter/gists{/gist_id}","starred_url":"https://api.github.com/users/mwhiter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwhiter/subscriptions","organizations_url":"https://api.github.com/users/mwhiter/orgs","repos_url":"https://api.github.com/users/mwhiter/repos","events_url":"https://api.github.com/users/mwhiter/events{/privacy}","received_events_url":"https://api.github.com/users/mwhiter/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/labels/Feature%20request","name":"Feature request","color":"0052cc"},{"url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/labels/Putmalk's%20Demesne","name":"Putmalk's Demesne","color":"fad8c7"}],"state":"open","locked":false,"assignee":{"login":"mwhiter","id":4925402,"avatar_url":"https://avatars.githubusercontent.com/u/4925402?v=3","gravatar_id":"","url":"https://api.github.com/users/mwhiter","html_url":"https://github.com/mwhiter","followers_url":"https://api.github.com/users/mwhiter/followers","following_url":"https://api.github.com/users/mwhiter/following{/other_user}","gists_url":"https://api.github.com/users/mwhiter/gists{/gist_id}","starred_url":"https://api.github.com/users/mwhiter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwhiter/subscriptions","organizations_url":"https://api.github.com/users/mwhiter/orgs","repos_url":"https://api.github.com/users/mwhiter/repos","events_url":"https://api.github.com/users/mwhiter/events{/privacy}","received_events_url":"https://api.github.com/users/mwhiter/received_events","type":"User","site_admin":false},"milestone":null,"comments":46,"created_at":"2016-04-04T11:43:35Z","updated_at":"2016-04-18T22:58:44Z","closed_at":null,"body":"Hey. Just pitching this idea to see what you think. Right now Corporations are rather denormalized and very coupled with buildings, and I'd like a way to denormalize them. Here is example code to show you what I mean:\r\n\r\n```\r\n CREATE TABLE IF NOT EXISTS Corporations\r\n (\r\n \tID\t\t\t\t\t\tinteger \tAUTO_INCREMENT PRIMARY KEY\t\t\t\t\t\t\t\t\t\t\t,\r\n \tType\t\t\t\t\ttext\t\tNOT NULL UNIQUE\t\t\t\t\t\t\t\t\t\t\t\t\t\t,\r\n \tDescription\t\t\t\ttext\t\tDEFAULT NULL\t\t\t\tREFERENCES Language_en_US(Tag)\t\t\t,\r\n \tHeadquartersBuilding\ttext\t\tDEFAULT NULL\t\t\t\tREFERENCES Buildings(Type)\t\t\t\t,\r\n \tOfficeBuilding\t\t\ttext\t\tDEFAULT NULL\t\t\t\tREFERENCES Buildings(Type)\t\t\t\t,\r\n \tFranchiseBuilding\t\ttext\t\tDEFAULT NULL\t\t\t\tREFERENCES Buildings(Type)\t\t\t\t,\r\n \tPortraitIndex\t\t\tinteger\t\tDEFAULT -1\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t,\r\n> \tIconAtlas\t\t\t\ttext\t\tDEFAULT NULL\t\t\t\tREFERENCES IconTextureAtlases(Atlas)\r\n );\r\n \r\n <Corporations>\r\n \t<Row>\r\n \t\t<ID>0</ID>\t\t\t\t\t\r\n \t\t<Type>CORPORATION_TRADER_SIDS</Type>\t\t\t\t\r\n \t\t<Description>TXT_KEY_CORPORATION_TRADER_SIDS</Description>\r\n \t\t<HeadquartersBuilding>BUILDING_TRADER_SIDS_HQ</HeadquartersBuilding>\r\n \t\t<OfficeBuilding>BUILDING_TRADER_SIDS</OfficeBuilding>\t\r\n \t\t<FranchiseBuilding>BUILDING_TRADER_SIDS_FRANCHISE</FranchiseBuilding>\r\n \t\t<PortraitIndex>1</PortraitIndex>\r\n \t\t<IconAtlas>CORP_ATLAS</IconAtlas>\r\n \t</Row>\r\n</Corporations>\r\n```\r\n\r\nThis is work I'd do after the Corp Overview is done and reconciled. This will make it easier to manage and mod.\r\n\r\nThoughts?"},"comment":{"url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/comments/211620505","html_url":"https://github.com/LoneGazebo/Community-Patch-DLL/issues/1541#issuecomment-211620505","issue_url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/1541","id":211620505,"user":{"login":"mwhiter","id":4925402,"avatar_url":"https://avatars.githubusercontent.com/u/4925402?v=3","gravatar_id":"","url":"https://api.github.com/users/mwhiter","html_url":"https://github.com/mwhiter","followers_url":"https://api.github.com/users/mwhiter/followers","following_url":"https://api.github.com/users/mwhiter/following{/other_user}","gists_url":"https://api.github.com/users/mwhiter/gists{/gist_id}","starred_url":"https://api.github.com/users/mwhiter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwhiter/subscriptions","organizations_url":"https://api.github.com/users/mwhiter/orgs","repos_url":"https://api.github.com/users/mwhiter/repos","events_url":"https://api.github.com/users/mwhiter/events{/privacy}","received_events_url":"https://api.github.com/users/mwhiter/received_events","type":"User","site_admin":false},"created_at":"2016-04-18T22:58:44Z","updated_at":"2016-04-18T22:58:44Z","body":"![image](https://cloud.githubusercontent.com/assets/4925402/14622377/7a889baa-0597-11e6-89f3-a02499093d2a.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/4925402/14622378/827ef2aa-0597-11e6-9be6-127318510b7b.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/4925402/14622384/91a6805e-0597-11e6-9bd5-bb41df157202.png)\r\n"}}