{"action":"created","comment":{"url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/comments/72845383","id":72845383,"diff_hunk":"@@ -73,9 +74,11 @@ class InstitutionsHttpApiSpec extends WordSpec with MustMatchers with ScalatestR\n       }\n       Get(\"/institutions/12345/filings/xxxx\") ~> institutionsRoutes ~> check {\n         status mustBe StatusCodes.NotFound\n+        responseAs[ErrorResponse] mustBe ErrorResponse(404, \"xxxx filing not found for institution 12345\", \"institutions/12345/filings/xxxx\")\n       }\n       Get(\"/institutions/xxxxx/filings/2017\") ~> institutionsRoutes ~> check {\n         status mustBe StatusCodes.NotFound\n+        responseAs[ErrorResponse] mustBe ErrorResponse(404, \"2017 filing not found for institution xxxxx\", \"institutions/xxxxx/filings/2017\")","path":"api/src/test/scala/hmda/api/http/InstitutionsHttpApiSpec.scala","position":16,"original_position":16,"commit_id":"449cf9811b3ab86a4af37fffb29fe3d97af0ad62","original_commit_id":"449cf9811b3ab86a4af37fffb29fe3d97af0ad62","user":{"login":"kgudel","id":13244336,"avatar_url":"https://avatars.githubusercontent.com/u/13244336?v=3","gravatar_id":"","url":"https://api.github.com/users/kgudel","html_url":"https://github.com/kgudel","followers_url":"https://api.github.com/users/kgudel/followers","following_url":"https://api.github.com/users/kgudel/following{/other_user}","gists_url":"https://api.github.com/users/kgudel/gists{/gist_id}","starred_url":"https://api.github.com/users/kgudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgudel/subscriptions","organizations_url":"https://api.github.com/users/kgudel/orgs","repos_url":"https://api.github.com/users/kgudel/repos","events_url":"https://api.github.com/users/kgudel/events{/privacy}","received_events_url":"https://api.github.com/users/kgudel/received_events","type":"User","site_admin":false},"body":"This would require adding more logic to the api which is not in the scope of this pr. It probably should be ticketed though.","created_at":"2016-07-29T19:08:40Z","updated_at":"2016-07-29T19:08:40Z","html_url":"https://github.com/cfpb/hmda-platform/pull/466#discussion_r72845383","pull_request_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/466","_links":{"self":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/comments/72845383"},"html":{"href":"https://github.com/cfpb/hmda-platform/pull/466#discussion_r72845383"},"pull_request":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/466"}}},"pull_request":{"url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/466","id":79390788,"html_url":"https://github.com/cfpb/hmda-platform/pull/466","diff_url":"https://github.com/cfpb/hmda-platform/pull/466.diff","patch_url":"https://github.com/cfpb/hmda-platform/pull/466.patch","issue_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/466","number":466,"state":"open","locked":false,"title":"Stripped down standard error response","user":{"login":"kgudel","id":13244336,"avatar_url":"https://avatars.githubusercontent.com/u/13244336?v=3","gravatar_id":"","url":"https://api.github.com/users/kgudel","html_url":"https://github.com/kgudel","followers_url":"https://api.github.com/users/kgudel/followers","following_url":"https://api.github.com/users/kgudel/following{/other_user}","gists_url":"https://api.github.com/users/kgudel/gists{/gist_id}","starred_url":"https://api.github.com/users/kgudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgudel/subscriptions","organizations_url":"https://api.github.com/users/kgudel/orgs","repos_url":"https://api.github.com/users/kgudel/repos","events_url":"https://api.github.com/users/kgudel/events{/privacy}","received_events_url":"https://api.github.com/users/kgudel/received_events","type":"User","site_admin":false},"body":"Create an error response object and protocol to convert it into json and use that in place of only return status codes.\r\n\r\nCloses #433 ","created_at":"2016-07-29T16:57:54Z","updated_at":"2016-07-29T19:08:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75c2c6c33f658bd63eea88cedd5869d0a6c75066","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/466/commits","review_comments_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/466/comments","review_comment_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/466/comments","statuses_url":"https://api.github.com/repos/cfpb/hmda-platform/statuses/449cf9811b3ab86a4af37fffb29fe3d97af0ad62","head":{"label":"kgudel:standardErrorResponse","ref":"standardErrorResponse","sha":"449cf9811b3ab86a4af37fffb29fe3d97af0ad62","user":{"login":"kgudel","id":13244336,"avatar_url":"https://avatars.githubusercontent.com/u/13244336?v=3","gravatar_id":"","url":"https://api.github.com/users/kgudel","html_url":"https://github.com/kgudel","followers_url":"https://api.github.com/users/kgudel/followers","following_url":"https://api.github.com/users/kgudel/following{/other_user}","gists_url":"https://api.github.com/users/kgudel/gists{/gist_id}","starred_url":"https://api.github.com/users/kgudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgudel/subscriptions","organizations_url":"https://api.github.com/users/kgudel/orgs","repos_url":"https://api.github.com/users/kgudel/repos","events_url":"https://api.github.com/users/kgudel/events{/privacy}","received_events_url":"https://api.github.com/users/kgudel/received_events","type":"User","site_admin":false},"repo":{"id":57915203,"name":"hmda-platform","full_name":"kgudel/hmda-platform","owner":{"login":"kgudel","id":13244336,"avatar_url":"https://avatars.githubusercontent.com/u/13244336?v=3","gravatar_id":"","url":"https://api.github.com/users/kgudel","html_url":"https://github.com/kgudel","followers_url":"https://api.github.com/users/kgudel/followers","following_url":"https://api.github.com/users/kgudel/following{/other_user}","gists_url":"https://api.github.com/users/kgudel/gists{/gist_id}","starred_url":"https://api.github.com/users/kgudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgudel/subscriptions","organizations_url":"https://api.github.com/users/kgudel/orgs","repos_url":"https://api.github.com/users/kgudel/repos","events_url":"https://api.github.com/users/kgudel/events{/privacy}","received_events_url":"https://api.github.com/users/kgudel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kgudel/hmda-platform","description":"","fork":true,"url":"https://api.github.com/repos/kgudel/hmda-platform","forks_url":"https://api.github.com/repos/kgudel/hmda-platform/forks","keys_url":"https://api.github.com/repos/kgudel/hmda-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kgudel/hmda-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kgudel/hmda-platform/teams","hooks_url":"https://api.github.com/repos/kgudel/hmda-platform/hooks","issue_events_url":"https://api.github.com/repos/kgudel/hmda-platform/issues/events{/number}","events_url":"https://api.github.com/repos/kgudel/hmda-platform/events","assignees_url":"https://api.github.com/repos/kgudel/hmda-platform/assignees{/user}","branches_url":"https://api.github.com/repos/kgudel/hmda-platform/branches{/branch}","tags_url":"https://api.github.com/repos/kgudel/hmda-platform/tags","blobs_url":"https://api.github.com/repos/kgudel/hmda-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kgudel/hmda-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kgudel/hmda-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/kgudel/hmda-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kgudel/hmda-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/kgudel/hmda-platform/languages","stargazers_url":"https://api.github.com/repos/kgudel/hmda-platform/stargazers","contributors_url":"https://api.github.com/repos/kgudel/hmda-platform/contributors","subscribers_url":"https://api.github.com/repos/kgudel/hmda-platform/subscribers","subscription_url":"https://api.github.com/repos/kgudel/hmda-platform/subscription","commits_url":"https://api.github.com/repos/kgudel/hmda-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/kgudel/hmda-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/kgudel/hmda-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/kgudel/hmda-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/kgudel/hmda-platform/contents/{+path}","compare_url":"https://api.github.com/repos/kgudel/hmda-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kgudel/hmda-platform/merges","archive_url":"https://api.github.com/repos/kgudel/hmda-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kgudel/hmda-platform/downloads","issues_url":"https://api.github.com/repos/kgudel/hmda-platform/issues{/number}","pulls_url":"https://api.github.com/repos/kgudel/hmda-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/kgudel/hmda-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/kgudel/hmda-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kgudel/hmda-platform/labels{/name}","releases_url":"https://api.github.com/repos/kgudel/hmda-platform/releases{/id}","deployments_url":"https://api.github.com/repos/kgudel/hmda-platform/deployments","created_at":"2016-05-02T19:22:32Z","updated_at":"2016-05-02T19:22:35Z","pushed_at":"2016-07-29T17:47:23Z","git_url":"git://github.com/kgudel/hmda-platform.git","ssh_url":"git@github.com:kgudel/hmda-platform.git","clone_url":"https://github.com/kgudel/hmda-platform.git","svn_url":"https://github.com/kgudel/hmda-platform","homepage":"","size":4459,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cfpb:master","ref":"master","sha":"9003eecb1af1256d7279855a654a505cc0b6d15d","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":50141662,"name":"hmda-platform","full_name":"cfpb/hmda-platform","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/hmda-platform","description":"","fork":false,"url":"https://api.github.com/repos/cfpb/hmda-platform","forks_url":"https://api.github.com/repos/cfpb/hmda-platform/forks","keys_url":"https://api.github.com/repos/cfpb/hmda-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/hmda-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/hmda-platform/teams","hooks_url":"https://api.github.com/repos/cfpb/hmda-platform/hooks","issue_events_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/hmda-platform/events","assignees_url":"https://api.github.com/repos/cfpb/hmda-platform/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/hmda-platform/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/hmda-platform/tags","blobs_url":"https://api.github.com/repos/cfpb/hmda-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/hmda-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/hmda-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/hmda-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/hmda-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/hmda-platform/languages","stargazers_url":"https://api.github.com/repos/cfpb/hmda-platform/stargazers","contributors_url":"https://api.github.com/repos/cfpb/hmda-platform/contributors","subscribers_url":"https://api.github.com/repos/cfpb/hmda-platform/subscribers","subscription_url":"https://api.github.com/repos/cfpb/hmda-platform/subscription","commits_url":"https://api.github.com/repos/cfpb/hmda-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/hmda-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/hmda-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/hmda-platform/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/hmda-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/hmda-platform/merges","archive_url":"https://api.github.com/repos/cfpb/hmda-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/hmda-platform/downloads","issues_url":"https://api.github.com/repos/cfpb/hmda-platform/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/hmda-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/hmda-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/hmda-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/hmda-platform/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/hmda-platform/releases{/id}","deployments_url":"https://api.github.com/repos/cfpb/hmda-platform/deployments","created_at":"2016-01-21T22:39:17Z","updated_at":"2016-07-26T17:51:40Z","pushed_at":"2016-07-29T18:48:09Z","git_url":"git://github.com/cfpb/hmda-platform.git","ssh_url":"git@github.com:cfpb/hmda-platform.git","clone_url":"https://github.com/cfpb/hmda-platform.git","svn_url":"https://github.com/cfpb/hmda-platform","homepage":"","size":5982,"stargazers_count":4,"watchers_count":4,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":115,"forks":9,"open_issues":115,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/466"},"html":{"href":"https://github.com/cfpb/hmda-platform/pull/466"},"issue":{"href":"https://api.github.com/repos/cfpb/hmda-platform/issues/466"},"comments":{"href":"https://api.github.com/repos/cfpb/hmda-platform/issues/466/comments"},"review_comments":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/466/comments"},"review_comment":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfpb/hmda-platform/pulls/466/commits"},"statuses":{"href":"https://api.github.com/repos/cfpb/hmda-platform/statuses/449cf9811b3ab86a4af37fffb29fe3d97af0ad62"}}}}
{"actor":{"display_login":"kgudel"}}