{"action":"created","issue":{"url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/2262","labels_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/2262/labels{/name}","comments_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/2262/comments","events_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/2262/events","html_url":"https://github.com/letsencrypt/letsencrypt/pull/2262","id":128213080,"number":2262,"title":"No conflicting declarations","user":{"login":"olabini","id":6158,"avatar_url":"https://avatars.githubusercontent.com/u/6158?v=3","gravatar_id":"","url":"https://api.github.com/users/olabini","html_url":"https://github.com/olabini","followers_url":"https://api.github.com/users/olabini/followers","following_url":"https://api.github.com/users/olabini/following{/other_user}","gists_url":"https://api.github.com/users/olabini/gists{/gist_id}","starred_url":"https://api.github.com/users/olabini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olabini/subscriptions","organizations_url":"https://api.github.com/users/olabini/orgs","repos_url":"https://api.github.com/users/olabini/repos","events_url":"https://api.github.com/users/olabini/events{/privacy}","received_events_url":"https://api.github.com/users/olabini/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/letsencrypt/letsencrypt/labels/nginx","name":"nginx","color":"eb6420"},{"url":"https://api.github.com/repos/letsencrypt/letsencrypt/labels/security%20enhancements","name":"security enhancements","color":"ffb8f0"},{"url":"https://api.github.com/repos/letsencrypt/letsencrypt/labels/ui%20/%20ux","name":"ui / ux","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-22T18:20:04Z","updated_at":"2016-01-22T21:48:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/2262","html_url":"https://github.com/letsencrypt/letsencrypt/pull/2262","diff_url":"https://github.com/letsencrypt/letsencrypt/pull/2262.diff","patch_url":"https://github.com/letsencrypt/letsencrypt/pull/2262.patch"},"body":"\r\n\r\nThis pull request does two things - it stops using the options-ssl-nginx.conf and instead reads it and adds the declarations directly. The reason for doing this is to stop potential conflicting declarations, and make it easier to deal with other requirements, such as providing the possibility of upgrading cipher suites.\r\n\r\nIt also changes the name of the session cache used. That means that even if an ssl_session_cache is defined at the http{} level, this cache will not conflict with it.\r\n\r\nThis should fix #574, #921 and #1743\r\n"},"comment":{"url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/comments/174063236","html_url":"https://github.com/letsencrypt/letsencrypt/pull/2262#issuecomment-174063236","issue_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/2262","id":174063236,"user":{"login":"pde","id":479213,"avatar_url":"https://avatars.githubusercontent.com/u/479213?v=3","gravatar_id":"","url":"https://api.github.com/users/pde","html_url":"https://github.com/pde","followers_url":"https://api.github.com/users/pde/followers","following_url":"https://api.github.com/users/pde/following{/other_user}","gists_url":"https://api.github.com/users/pde/gists{/gist_id}","starred_url":"https://api.github.com/users/pde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pde/subscriptions","organizations_url":"https://api.github.com/users/pde/orgs","repos_url":"https://api.github.com/users/pde/repos","events_url":"https://api.github.com/users/pde/events{/privacy}","received_events_url":"https://api.github.com/users/pde/received_events","type":"User","site_admin":false},"created_at":"2016-01-22T21:48:52Z","updated_at":"2016-01-22T21:48:52Z","body":"The other option to consider is commenting out existing conflicting declarations, but continuing to keep our options in a separate file, so that people can see where they came from and we can update the file under appropriate circumstances."}}