{"action":"created","comment":{"url":"https://api.github.com/repos/react-component/slider/pulls/comments/70910230","id":70910230,"diff_hunk":"@@ -337,16 +337,20 @@ class Slider extends React.Component {\n     const lowerOffset = this.calcOffset(lowerBound);\n \n     const handleClassName = prefixCls + '-handle';\n+\n+    const upperClassName = handleClassName + ' ' + handleClassName + '-upper';\n+    const lowerClassName = handleClassName + ' ' + handleClassName + '-lower';\n+\n     const isNoTip = (step === null) || (tipFormatter === null);\n \n-    const upper = cloneElement(customHandle, { className: handleClassName,\n-        noTip: isNoTip, tipTransitionName: tipTransitionName, tipFormatter: tipFormatter,\n+    const upper = cloneElement(customHandle, { className: upperClassName,\n+        noTip: isNoTip, tipTransitionName: tipTransitionName, tipFormatter: tipFormatter, upperHandle: true, lowerHandle: false,","path":"src/Slider.jsx","position":13,"original_position":13,"commit_id":"7753ae1826b80e6b0c8717259fb00c8e4d743207","original_commit_id":"7753ae1826b80e6b0c8717259fb00c8e4d743207","user":{"login":"benjycui","id":3580607,"avatar_url":"https://avatars.githubusercontent.com/u/3580607?v=3","gravatar_id":"","url":"https://api.github.com/users/benjycui","html_url":"https://github.com/benjycui","followers_url":"https://api.github.com/users/benjycui/followers","following_url":"https://api.github.com/users/benjycui/following{/other_user}","gists_url":"https://api.github.com/users/benjycui/gists{/gist_id}","starred_url":"https://api.github.com/users/benjycui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjycui/subscriptions","organizations_url":"https://api.github.com/users/benjycui/orgs","repos_url":"https://api.github.com/users/benjycui/repos","events_url":"https://api.github.com/users/benjycui/events{/privacy}","received_events_url":"https://api.github.com/users/benjycui/received_events","type":"User","site_admin":false},"body":"`className` is enough, just remove `upperHandle` and `lowerHandle` to simplify code.","created_at":"2016-07-15T01:30:06Z","updated_at":"2016-07-15T01:30:06Z","html_url":"https://github.com/react-component/slider/pull/118#discussion_r70910230","pull_request_url":"https://api.github.com/repos/react-component/slider/pulls/118","_links":{"self":{"href":"https://api.github.com/repos/react-component/slider/pulls/comments/70910230"},"html":{"href":"https://github.com/react-component/slider/pull/118#discussion_r70910230"},"pull_request":{"href":"https://api.github.com/repos/react-component/slider/pulls/118"}}},"pull_request":{"url":"https://api.github.com/repos/react-component/slider/pulls/118","id":77482132,"html_url":"https://github.com/react-component/slider/pull/118","diff_url":"https://github.com/react-component/slider/pull/118.diff","patch_url":"https://github.com/react-component/slider/pull/118.patch","issue_url":"https://api.github.com/repos/react-component/slider/issues/118","number":118,"state":"open","locked":false,"title":"Identify upper/lower range handles","user":{"login":"miskreant","id":294747,"avatar_url":"https://avatars.githubusercontent.com/u/294747?v=3","gravatar_id":"","url":"https://api.github.com/users/miskreant","html_url":"https://github.com/miskreant","followers_url":"https://api.github.com/users/miskreant/followers","following_url":"https://api.github.com/users/miskreant/following{/other_user}","gists_url":"https://api.github.com/users/miskreant/gists{/gist_id}","starred_url":"https://api.github.com/users/miskreant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miskreant/subscriptions","organizations_url":"https://api.github.com/users/miskreant/orgs","repos_url":"https://api.github.com/users/miskreant/repos","events_url":"https://api.github.com/users/miskreant/events{/privacy}","received_events_url":"https://api.github.com/users/miskreant/received_events","type":"User","site_admin":false},"body":"Extend the handle classNames, and provide props so that\r\nupper/lower handles are easily distinguishable in CSS & React.","created_at":"2016-07-14T16:05:00Z","updated_at":"2016-07-15T01:30:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6acb79818c2cf3fd505d9e27127b058f2de5287c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/react-component/slider/pulls/118/commits","review_comments_url":"https://api.github.com/repos/react-component/slider/pulls/118/comments","review_comment_url":"https://api.github.com/repos/react-component/slider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/react-component/slider/issues/118/comments","statuses_url":"https://api.github.com/repos/react-component/slider/statuses/7753ae1826b80e6b0c8717259fb00c8e4d743207","head":{"label":"miskreant:identifyHandles","ref":"identifyHandles","sha":"7753ae1826b80e6b0c8717259fb00c8e4d743207","user":{"login":"miskreant","id":294747,"avatar_url":"https://avatars.githubusercontent.com/u/294747?v=3","gravatar_id":"","url":"https://api.github.com/users/miskreant","html_url":"https://github.com/miskreant","followers_url":"https://api.github.com/users/miskreant/followers","following_url":"https://api.github.com/users/miskreant/following{/other_user}","gists_url":"https://api.github.com/users/miskreant/gists{/gist_id}","starred_url":"https://api.github.com/users/miskreant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miskreant/subscriptions","organizations_url":"https://api.github.com/users/miskreant/orgs","repos_url":"https://api.github.com/users/miskreant/repos","events_url":"https://api.github.com/users/miskreant/events{/privacy}","received_events_url":"https://api.github.com/users/miskreant/received_events","type":"User","site_admin":false},"repo":{"id":62829794,"name":"rc-slider","full_name":"miskreant/rc-slider","owner":{"login":"miskreant","id":294747,"avatar_url":"https://avatars.githubusercontent.com/u/294747?v=3","gravatar_id":"","url":"https://api.github.com/users/miskreant","html_url":"https://github.com/miskreant","followers_url":"https://api.github.com/users/miskreant/followers","following_url":"https://api.github.com/users/miskreant/following{/other_user}","gists_url":"https://api.github.com/users/miskreant/gists{/gist_id}","starred_url":"https://api.github.com/users/miskreant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miskreant/subscriptions","organizations_url":"https://api.github.com/users/miskreant/orgs","repos_url":"https://api.github.com/users/miskreant/repos","events_url":"https://api.github.com/users/miskreant/events{/privacy}","received_events_url":"https://api.github.com/users/miskreant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miskreant/rc-slider","description":"React Slider","fork":true,"url":"https://api.github.com/repos/miskreant/rc-slider","forks_url":"https://api.github.com/repos/miskreant/rc-slider/forks","keys_url":"https://api.github.com/repos/miskreant/rc-slider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miskreant/rc-slider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miskreant/rc-slider/teams","hooks_url":"https://api.github.com/repos/miskreant/rc-slider/hooks","issue_events_url":"https://api.github.com/repos/miskreant/rc-slider/issues/events{/number}","events_url":"https://api.github.com/repos/miskreant/rc-slider/events","assignees_url":"https://api.github.com/repos/miskreant/rc-slider/assignees{/user}","branches_url":"https://api.github.com/repos/miskreant/rc-slider/branches{/branch}","tags_url":"https://api.github.com/repos/miskreant/rc-slider/tags","blobs_url":"https://api.github.com/repos/miskreant/rc-slider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miskreant/rc-slider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miskreant/rc-slider/git/refs{/sha}","trees_url":"https://api.github.com/repos/miskreant/rc-slider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miskreant/rc-slider/statuses/{sha}","languages_url":"https://api.github.com/repos/miskreant/rc-slider/languages","stargazers_url":"https://api.github.com/repos/miskreant/rc-slider/stargazers","contributors_url":"https://api.github.com/repos/miskreant/rc-slider/contributors","subscribers_url":"https://api.github.com/repos/miskreant/rc-slider/subscribers","subscription_url":"https://api.github.com/repos/miskreant/rc-slider/subscription","commits_url":"https://api.github.com/repos/miskreant/rc-slider/commits{/sha}","git_commits_url":"https://api.github.com/repos/miskreant/rc-slider/git/commits{/sha}","comments_url":"https://api.github.com/repos/miskreant/rc-slider/comments{/number}","issue_comment_url":"https://api.github.com/repos/miskreant/rc-slider/issues/comments{/number}","contents_url":"https://api.github.com/repos/miskreant/rc-slider/contents/{+path}","compare_url":"https://api.github.com/repos/miskreant/rc-slider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miskreant/rc-slider/merges","archive_url":"https://api.github.com/repos/miskreant/rc-slider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miskreant/rc-slider/downloads","issues_url":"https://api.github.com/repos/miskreant/rc-slider/issues{/number}","pulls_url":"https://api.github.com/repos/miskreant/rc-slider/pulls{/number}","milestones_url":"https://api.github.com/repos/miskreant/rc-slider/milestones{/number}","notifications_url":"https://api.github.com/repos/miskreant/rc-slider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miskreant/rc-slider/labels{/name}","releases_url":"https://api.github.com/repos/miskreant/rc-slider/releases{/id}","deployments_url":"https://api.github.com/repos/miskreant/rc-slider/deployments","created_at":"2016-07-07T18:34:08Z","updated_at":"2016-07-07T18:34:35Z","pushed_at":"2016-07-14T16:02:58Z","git_url":"git://github.com/miskreant/rc-slider.git","ssh_url":"git@github.com:miskreant/rc-slider.git","clone_url":"https://github.com/miskreant/rc-slider.git","svn_url":"https://github.com/miskreant/rc-slider","homepage":"http://react-component.github.io/slider/","size":1888,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"react-component:master","ref":"master","sha":"80d4ee479403b5f8210d235813628b588ef1b89a","user":{"login":"react-component","id":9441414,"avatar_url":"https://avatars.githubusercontent.com/u/9441414?v=3","gravatar_id":"","url":"https://api.github.com/users/react-component","html_url":"https://github.com/react-component","followers_url":"https://api.github.com/users/react-component/followers","following_url":"https://api.github.com/users/react-component/following{/other_user}","gists_url":"https://api.github.com/users/react-component/gists{/gist_id}","starred_url":"https://api.github.com/users/react-component/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-component/subscriptions","organizations_url":"https://api.github.com/users/react-component/orgs","repos_url":"https://api.github.com/users/react-component/repos","events_url":"https://api.github.com/users/react-component/events{/privacy}","received_events_url":"https://api.github.com/users/react-component/received_events","type":"Organization","site_admin":false},"repo":{"id":34197461,"name":"slider","full_name":"react-component/slider","owner":{"login":"react-component","id":9441414,"avatar_url":"https://avatars.githubusercontent.com/u/9441414?v=3","gravatar_id":"","url":"https://api.github.com/users/react-component","html_url":"https://github.com/react-component","followers_url":"https://api.github.com/users/react-component/followers","following_url":"https://api.github.com/users/react-component/following{/other_user}","gists_url":"https://api.github.com/users/react-component/gists{/gist_id}","starred_url":"https://api.github.com/users/react-component/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-component/subscriptions","organizations_url":"https://api.github.com/users/react-component/orgs","repos_url":"https://api.github.com/users/react-component/repos","events_url":"https://api.github.com/users/react-component/events{/privacy}","received_events_url":"https://api.github.com/users/react-component/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/react-component/slider","description":"React Slider","fork":false,"url":"https://api.github.com/repos/react-component/slider","forks_url":"https://api.github.com/repos/react-component/slider/forks","keys_url":"https://api.github.com/repos/react-component/slider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/react-component/slider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/react-component/slider/teams","hooks_url":"https://api.github.com/repos/react-component/slider/hooks","issue_events_url":"https://api.github.com/repos/react-component/slider/issues/events{/number}","events_url":"https://api.github.com/repos/react-component/slider/events","assignees_url":"https://api.github.com/repos/react-component/slider/assignees{/user}","branches_url":"https://api.github.com/repos/react-component/slider/branches{/branch}","tags_url":"https://api.github.com/repos/react-component/slider/tags","blobs_url":"https://api.github.com/repos/react-component/slider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/react-component/slider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/react-component/slider/git/refs{/sha}","trees_url":"https://api.github.com/repos/react-component/slider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/react-component/slider/statuses/{sha}","languages_url":"https://api.github.com/repos/react-component/slider/languages","stargazers_url":"https://api.github.com/repos/react-component/slider/stargazers","contributors_url":"https://api.github.com/repos/react-component/slider/contributors","subscribers_url":"https://api.github.com/repos/react-component/slider/subscribers","subscription_url":"https://api.github.com/repos/react-component/slider/subscription","commits_url":"https://api.github.com/repos/react-component/slider/commits{/sha}","git_commits_url":"https://api.github.com/repos/react-component/slider/git/commits{/sha}","comments_url":"https://api.github.com/repos/react-component/slider/comments{/number}","issue_comment_url":"https://api.github.com/repos/react-component/slider/issues/comments{/number}","contents_url":"https://api.github.com/repos/react-component/slider/contents/{+path}","compare_url":"https://api.github.com/repos/react-component/slider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/react-component/slider/merges","archive_url":"https://api.github.com/repos/react-component/slider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/react-component/slider/downloads","issues_url":"https://api.github.com/repos/react-component/slider/issues{/number}","pulls_url":"https://api.github.com/repos/react-component/slider/pulls{/number}","milestones_url":"https://api.github.com/repos/react-component/slider/milestones{/number}","notifications_url":"https://api.github.com/repos/react-component/slider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/react-component/slider/labels{/name}","releases_url":"https://api.github.com/repos/react-component/slider/releases{/id}","deployments_url":"https://api.github.com/repos/react-component/slider/deployments","created_at":"2015-04-19T07:30:44Z","updated_at":"2016-07-14T22:45:22Z","pushed_at":"2016-07-14T16:05:00Z","git_url":"git://github.com/react-component/slider.git","ssh_url":"git@github.com:react-component/slider.git","clone_url":"https://github.com/react-component/slider.git","svn_url":"https://github.com/react-component/slider","homepage":"http://react-component.github.io/slider/","size":2073,"stargazers_count":250,"watchers_count":250,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":82,"mirror_url":null,"open_issues_count":2,"forks":82,"open_issues":2,"watchers":250,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/react-component/slider/pulls/118"},"html":{"href":"https://github.com/react-component/slider/pull/118"},"issue":{"href":"https://api.github.com/repos/react-component/slider/issues/118"},"comments":{"href":"https://api.github.com/repos/react-component/slider/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/react-component/slider/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/react-component/slider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/react-component/slider/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/react-component/slider/statuses/7753ae1826b80e6b0c8717259fb00c8e4d743207"}}}}
{"actor":{"display_login":"benjycui"}}