{"action":"created","issue":{"url":"https://api.github.com/repos/realm/realm-android-adapters/issues/39","repository_url":"https://api.github.com/repos/realm/realm-android-adapters","labels_url":"https://api.github.com/repos/realm/realm-android-adapters/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/realm/realm-android-adapters/issues/39/comments","events_url":"https://api.github.com/repos/realm/realm-android-adapters/issues/39/events","html_url":"https://github.com/realm/realm-android-adapters/pull/39","id":156856260,"number":39,"title":"use supportAnnotations","user":{"login":"larsgrefer","id":6069961,"avatar_url":"https://avatars.githubusercontent.com/u/6069961?v=3","gravatar_id":"","url":"https://api.github.com/users/larsgrefer","html_url":"https://github.com/larsgrefer","followers_url":"https://api.github.com/users/larsgrefer/followers","following_url":"https://api.github.com/users/larsgrefer/following{/other_user}","gists_url":"https://api.github.com/users/larsgrefer/gists{/gist_id}","starred_url":"https://api.github.com/users/larsgrefer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsgrefer/subscriptions","organizations_url":"https://api.github.com/users/larsgrefer/orgs","repos_url":"https://api.github.com/users/larsgrefer/repos","events_url":"https://api.github.com/users/larsgrefer/events{/privacy}","received_events_url":"https://api.github.com/users/larsgrefer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/realm/realm-android-adapters/labels/S:Review","name":"S:Review","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-25T21:37:19Z","updated_at":"2016-05-26T12:30:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/realm/realm-android-adapters/pulls/39","html_url":"https://github.com/realm/realm-android-adapters/pull/39","diff_url":"https://github.com/realm/realm-android-adapters/pull/39.diff","patch_url":"https://github.com/realm/realm-android-adapters/pull/39.patch"},"body":"Add the android support-annotations to the public api.\r\n\r\nThe annotations are hints for the IDE so it can show warnings"},"comment":{"url":"https://api.github.com/repos/realm/realm-android-adapters/issues/comments/221857529","html_url":"https://github.com/realm/realm-android-adapters/pull/39#issuecomment-221857529","issue_url":"https://api.github.com/repos/realm/realm-android-adapters/issues/39","id":221857529,"user":{"login":"spl","id":54900,"avatar_url":"https://avatars.githubusercontent.com/u/54900?v=3","gravatar_id":"","url":"https://api.github.com/users/spl","html_url":"https://github.com/spl","followers_url":"https://api.github.com/users/spl/followers","following_url":"https://api.github.com/users/spl/following{/other_user}","gists_url":"https://api.github.com/users/spl/gists{/gist_id}","starred_url":"https://api.github.com/users/spl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spl/subscriptions","organizations_url":"https://api.github.com/users/spl/orgs","repos_url":"https://api.github.com/users/spl/repos","events_url":"https://api.github.com/users/spl/events{/privacy}","received_events_url":"https://api.github.com/users/spl/received_events","type":"User","site_admin":false},"created_at":"2016-05-26T12:30:48Z","updated_at":"2016-05-26T12:30:48Z","body":"I've just started using Realm Java and `realm-android-adapters`, and I would love to see `@Nullable` and `@NonNull` annotations. I've already cloned `realm-android-adapters` while I'm trying it out and added them myself.\r\n\r\nI concur with @cmelchior on not having `@CheckResult` annotations everywhere. Google's first example, `String.trim()`, is something that could perform a not-insignificant amount of work that shouldn't be wasted. Whereas, one might expect it to be a mutable operations, the `@CheckResult` annotation would help one realize it is not.  With `getCount()`, `getItem()`, etc., however, the work is not significant and a well-established naming convention for accessors dictates that these are immutable.\r\n\r\nIn my code, I added `@Nullable` to the `Context context` parameter. Once you have that, Android Studio suggests that you remove the `if (context == null)` check. However, since not everybody may use the annotations, you probably want to leave that in. In which case, you can add `//noinspection ConstantConditions` to that statement."}}
{"actor":{"display_login":"spl"}}