{"action":"created","issue":{"url":"https://api.github.com/repos/mathquill/mathquill/issues/629","repository_url":"https://api.github.com/repos/mathquill/mathquill","labels_url":"https://api.github.com/repos/mathquill/mathquill/issues/629/labels{/name}","comments_url":"https://api.github.com/repos/mathquill/mathquill/issues/629/comments","events_url":"https://api.github.com/repos/mathquill/mathquill/issues/629/events","html_url":"https://github.com/mathquill/mathquill/pull/629","id":153073994,"number":629,"title":"Pin pjs to less >=3.1.0 <5.0.0","user":{"login":"jwmerrill","id":48409,"avatar_url":"https://avatars.githubusercontent.com/u/48409?v=3","gravatar_id":"","url":"https://api.github.com/users/jwmerrill","html_url":"https://github.com/jwmerrill","followers_url":"https://api.github.com/users/jwmerrill/followers","following_url":"https://api.github.com/users/jwmerrill/following{/other_user}","gists_url":"https://api.github.com/users/jwmerrill/gists{/gist_id}","starred_url":"https://api.github.com/users/jwmerrill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwmerrill/subscriptions","organizations_url":"https://api.github.com/users/jwmerrill/orgs","repos_url":"https://api.github.com/users/jwmerrill/repos","events_url":"https://api.github.com/users/jwmerrill/events{/privacy}","received_events_url":"https://api.github.com/users/jwmerrill/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2016-05-04T17:45:57Z","updated_at":"2016-05-05T00:16:56Z","closed_at":"2016-05-04T18:04:59Z","pull_request":{"url":"https://api.github.com/repos/mathquill/mathquill/pulls/629","html_url":"https://github.com/mathquill/mathquill/pull/629","diff_url":"https://github.com/mathquill/mathquill/pull/629.diff","patch_url":"https://github.com/mathquill/mathquill/pull/629.patch"},"body":"PJs 5.0.0+ is currently incompatible with MathQuill.\r\n\r\nPJs 5.0.0 introduced a new behavior for this.constructor(...) in order\r\nto be compatible with coffeescript classes. The new behavior means\r\nthat, if you don't use `new` when you call `this.constructor`, the\r\nobject returned from the constructor is an alias of `this` instead of a new object.\r\n\r\nThis behavior interacts badly with MathQuill's use of PJs to subclass\r\njQuery, and jQuery's use of `this.constructor` inside `pushStack`:\r\n\r\nhttps://github.com/jquery/jquery/blob/305f193aa57014dc7d8fa0739a3fefd47166cd44/src/core.js#L72-L84"},"comment":{"url":"https://api.github.com/repos/mathquill/mathquill/issues/comments/217045083","html_url":"https://github.com/mathquill/mathquill/pull/629#issuecomment-217045083","issue_url":"https://api.github.com/repos/mathquill/mathquill/issues/629","id":217045083,"user":{"login":"laughinghan","id":225809,"avatar_url":"https://avatars.githubusercontent.com/u/225809?v=3","gravatar_id":"","url":"https://api.github.com/users/laughinghan","html_url":"https://github.com/laughinghan","followers_url":"https://api.github.com/users/laughinghan/followers","following_url":"https://api.github.com/users/laughinghan/following{/other_user}","gists_url":"https://api.github.com/users/laughinghan/gists{/gist_id}","starred_url":"https://api.github.com/users/laughinghan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laughinghan/subscriptions","organizations_url":"https://api.github.com/users/laughinghan/orgs","repos_url":"https://api.github.com/users/laughinghan/repos","events_url":"https://api.github.com/users/laughinghan/events{/privacy}","received_events_url":"https://api.github.com/users/laughinghan/received_events","type":"User","site_admin":false},"created_at":"2016-05-05T00:16:56Z","updated_at":"2016-05-05T00:16:56Z","body":"Actually, everything sucks, the ES6 subclass of jQuery isn't \"well-behaved\", in that if you try to instantiate the subclass, you instead get a jQuery object that isn't an instance of the subclass (I updated the example). Maybe this isn't a solveable problem."}}