{"action":"opened","number":320,"pull_request":{"url":"https://api.github.com/repos/tstack/lnav/pulls/320","id":68962419,"html_url":"https://github.com/tstack/lnav/pull/320","diff_url":"https://github.com/tstack/lnav/pull/320.diff","patch_url":"https://github.com/tstack/lnav/pull/320.patch","issue_url":"https://api.github.com/repos/tstack/lnav/issues/320","number":320,"state":"open","locked":false,"title":"[secure-mode] Disallow ATTACH statements completely.","user":{"login":"sureshsundriyal","id":247110,"avatar_url":"https://avatars.githubusercontent.com/u/247110?v=3","gravatar_id":"","url":"https://api.github.com/users/sureshsundriyal","html_url":"https://github.com/sureshsundriyal","followers_url":"https://api.github.com/users/sureshsundriyal/followers","following_url":"https://api.github.com/users/sureshsundriyal/following{/other_user}","gists_url":"https://api.github.com/users/sureshsundriyal/gists{/gist_id}","starred_url":"https://api.github.com/users/sureshsundriyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sureshsundriyal/subscriptions","organizations_url":"https://api.github.com/users/sureshsundriyal/orgs","repos_url":"https://api.github.com/users/sureshsundriyal/repos","events_url":"https://api.github.com/users/sureshsundriyal/events{/privacy}","received_events_url":"https://api.github.com/users/sureshsundriyal/received_events","type":"User","site_admin":false},"body":"The code to handle in-memory db exceptions is hideous and unreliable,\r\ngiven the fact that SQLite does not expose much in terms of getting the\r\ncurrent value and the methods to check the compile time options can\r\nthemselves be disabled by a compile=time option in SQLite.\r\n\r\nThere really isn't much use for in-memory databases and if someone\r\nreally needs it, they can always choose to run in normal mode, so just\r\nremove the extra code.","created_at":"2016-05-05T03:27:35Z","updated_at":"2016-05-05T03:27:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tstack/lnav/pulls/320/commits","review_comments_url":"https://api.github.com/repos/tstack/lnav/pulls/320/comments","review_comment_url":"https://api.github.com/repos/tstack/lnav/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tstack/lnav/issues/320/comments","statuses_url":"https://api.github.com/repos/tstack/lnav/statuses/6663740c5ef72765d3f870fe16cf346afbc2073c","head":{"label":"sureshsundriyal:db-attach","ref":"db-attach","sha":"6663740c5ef72765d3f870fe16cf346afbc2073c","user":{"login":"sureshsundriyal","id":247110,"avatar_url":"https://avatars.githubusercontent.com/u/247110?v=3","gravatar_id":"","url":"https://api.github.com/users/sureshsundriyal","html_url":"https://github.com/sureshsundriyal","followers_url":"https://api.github.com/users/sureshsundriyal/followers","following_url":"https://api.github.com/users/sureshsundriyal/following{/other_user}","gists_url":"https://api.github.com/users/sureshsundriyal/gists{/gist_id}","starred_url":"https://api.github.com/users/sureshsundriyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sureshsundriyal/subscriptions","organizations_url":"https://api.github.com/users/sureshsundriyal/orgs","repos_url":"https://api.github.com/users/sureshsundriyal/repos","events_url":"https://api.github.com/users/sureshsundriyal/events{/privacy}","received_events_url":"https://api.github.com/users/sureshsundriyal/received_events","type":"User","site_admin":false},"repo":{"id":35467475,"name":"lnav","full_name":"sureshsundriyal/lnav","owner":{"login":"sureshsundriyal","id":247110,"avatar_url":"https://avatars.githubusercontent.com/u/247110?v=3","gravatar_id":"","url":"https://api.github.com/users/sureshsundriyal","html_url":"https://github.com/sureshsundriyal","followers_url":"https://api.github.com/users/sureshsundriyal/followers","following_url":"https://api.github.com/users/sureshsundriyal/following{/other_user}","gists_url":"https://api.github.com/users/sureshsundriyal/gists{/gist_id}","starred_url":"https://api.github.com/users/sureshsundriyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sureshsundriyal/subscriptions","organizations_url":"https://api.github.com/users/sureshsundriyal/orgs","repos_url":"https://api.github.com/users/sureshsundriyal/repos","events_url":"https://api.github.com/users/sureshsundriyal/events{/privacy}","received_events_url":"https://api.github.com/users/sureshsundriyal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sureshsundriyal/lnav","description":"Log file navigator","fork":true,"url":"https://api.github.com/repos/sureshsundriyal/lnav","forks_url":"https://api.github.com/repos/sureshsundriyal/lnav/forks","keys_url":"https://api.github.com/repos/sureshsundriyal/lnav/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sureshsundriyal/lnav/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sureshsundriyal/lnav/teams","hooks_url":"https://api.github.com/repos/sureshsundriyal/lnav/hooks","issue_events_url":"https://api.github.com/repos/sureshsundriyal/lnav/issues/events{/number}","events_url":"https://api.github.com/repos/sureshsundriyal/lnav/events","assignees_url":"https://api.github.com/repos/sureshsundriyal/lnav/assignees{/user}","branches_url":"https://api.github.com/repos/sureshsundriyal/lnav/branches{/branch}","tags_url":"https://api.github.com/repos/sureshsundriyal/lnav/tags","blobs_url":"https://api.github.com/repos/sureshsundriyal/lnav/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sureshsundriyal/lnav/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sureshsundriyal/lnav/git/refs{/sha}","trees_url":"https://api.github.com/repos/sureshsundriyal/lnav/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sureshsundriyal/lnav/statuses/{sha}","languages_url":"https://api.github.com/repos/sureshsundriyal/lnav/languages","stargazers_url":"https://api.github.com/repos/sureshsundriyal/lnav/stargazers","contributors_url":"https://api.github.com/repos/sureshsundriyal/lnav/contributors","subscribers_url":"https://api.github.com/repos/sureshsundriyal/lnav/subscribers","subscription_url":"https://api.github.com/repos/sureshsundriyal/lnav/subscription","commits_url":"https://api.github.com/repos/sureshsundriyal/lnav/commits{/sha}","git_commits_url":"https://api.github.com/repos/sureshsundriyal/lnav/git/commits{/sha}","comments_url":"https://api.github.com/repos/sureshsundriyal/lnav/comments{/number}","issue_comment_url":"https://api.github.com/repos/sureshsundriyal/lnav/issues/comments{/number}","contents_url":"https://api.github.com/repos/sureshsundriyal/lnav/contents/{+path}","compare_url":"https://api.github.com/repos/sureshsundriyal/lnav/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sureshsundriyal/lnav/merges","archive_url":"https://api.github.com/repos/sureshsundriyal/lnav/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sureshsundriyal/lnav/downloads","issues_url":"https://api.github.com/repos/sureshsundriyal/lnav/issues{/number}","pulls_url":"https://api.github.com/repos/sureshsundriyal/lnav/pulls{/number}","milestones_url":"https://api.github.com/repos/sureshsundriyal/lnav/milestones{/number}","notifications_url":"https://api.github.com/repos/sureshsundriyal/lnav/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sureshsundriyal/lnav/labels{/name}","releases_url":"https://api.github.com/repos/sureshsundriyal/lnav/releases{/id}","deployments_url":"https://api.github.com/repos/sureshsundriyal/lnav/deployments","created_at":"2015-05-12T04:49:43Z","updated_at":"2016-04-23T02:38:07Z","pushed_at":"2016-05-05T03:26:19Z","git_url":"git://github.com/sureshsundriyal/lnav.git","ssh_url":"git@github.com:sureshsundriyal/lnav.git","clone_url":"https://github.com/sureshsundriyal/lnav.git","svn_url":"https://github.com/sureshsundriyal/lnav","homepage":"http://lnav.org","size":7425,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tstack:master","ref":"master","sha":"a81db3f41d82689b8d4ba8beccaaea81ad37cd02","user":{"login":"tstack","id":107532,"avatar_url":"https://avatars.githubusercontent.com/u/107532?v=3","gravatar_id":"","url":"https://api.github.com/users/tstack","html_url":"https://github.com/tstack","followers_url":"https://api.github.com/users/tstack/followers","following_url":"https://api.github.com/users/tstack/following{/other_user}","gists_url":"https://api.github.com/users/tstack/gists{/gist_id}","starred_url":"https://api.github.com/users/tstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tstack/subscriptions","organizations_url":"https://api.github.com/users/tstack/orgs","repos_url":"https://api.github.com/users/tstack/repos","events_url":"https://api.github.com/users/tstack/events{/privacy}","received_events_url":"https://api.github.com/users/tstack/received_events","type":"User","site_admin":false},"repo":{"id":306147,"name":"lnav","full_name":"tstack/lnav","owner":{"login":"tstack","id":107532,"avatar_url":"https://avatars.githubusercontent.com/u/107532?v=3","gravatar_id":"","url":"https://api.github.com/users/tstack","html_url":"https://github.com/tstack","followers_url":"https://api.github.com/users/tstack/followers","following_url":"https://api.github.com/users/tstack/following{/other_user}","gists_url":"https://api.github.com/users/tstack/gists{/gist_id}","starred_url":"https://api.github.com/users/tstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tstack/subscriptions","organizations_url":"https://api.github.com/users/tstack/orgs","repos_url":"https://api.github.com/users/tstack/repos","events_url":"https://api.github.com/users/tstack/events{/privacy}","received_events_url":"https://api.github.com/users/tstack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tstack/lnav","description":"Log file navigator","fork":false,"url":"https://api.github.com/repos/tstack/lnav","forks_url":"https://api.github.com/repos/tstack/lnav/forks","keys_url":"https://api.github.com/repos/tstack/lnav/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tstack/lnav/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tstack/lnav/teams","hooks_url":"https://api.github.com/repos/tstack/lnav/hooks","issue_events_url":"https://api.github.com/repos/tstack/lnav/issues/events{/number}","events_url":"https://api.github.com/repos/tstack/lnav/events","assignees_url":"https://api.github.com/repos/tstack/lnav/assignees{/user}","branches_url":"https://api.github.com/repos/tstack/lnav/branches{/branch}","tags_url":"https://api.github.com/repos/tstack/lnav/tags","blobs_url":"https://api.github.com/repos/tstack/lnav/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tstack/lnav/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tstack/lnav/git/refs{/sha}","trees_url":"https://api.github.com/repos/tstack/lnav/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tstack/lnav/statuses/{sha}","languages_url":"https://api.github.com/repos/tstack/lnav/languages","stargazers_url":"https://api.github.com/repos/tstack/lnav/stargazers","contributors_url":"https://api.github.com/repos/tstack/lnav/contributors","subscribers_url":"https://api.github.com/repos/tstack/lnav/subscribers","subscription_url":"https://api.github.com/repos/tstack/lnav/subscription","commits_url":"https://api.github.com/repos/tstack/lnav/commits{/sha}","git_commits_url":"https://api.github.com/repos/tstack/lnav/git/commits{/sha}","comments_url":"https://api.github.com/repos/tstack/lnav/comments{/number}","issue_comment_url":"https://api.github.com/repos/tstack/lnav/issues/comments{/number}","contents_url":"https://api.github.com/repos/tstack/lnav/contents/{+path}","compare_url":"https://api.github.com/repos/tstack/lnav/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tstack/lnav/merges","archive_url":"https://api.github.com/repos/tstack/lnav/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tstack/lnav/downloads","issues_url":"https://api.github.com/repos/tstack/lnav/issues{/number}","pulls_url":"https://api.github.com/repos/tstack/lnav/pulls{/number}","milestones_url":"https://api.github.com/repos/tstack/lnav/milestones{/number}","notifications_url":"https://api.github.com/repos/tstack/lnav/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tstack/lnav/labels{/name}","releases_url":"https://api.github.com/repos/tstack/lnav/releases{/id}","deployments_url":"https://api.github.com/repos/tstack/lnav/deployments","created_at":"2009-09-14T01:02:02Z","updated_at":"2016-05-05T00:56:06Z","pushed_at":"2016-05-04T04:31:55Z","git_url":"git://github.com/tstack/lnav.git","ssh_url":"git@github.com:tstack/lnav.git","clone_url":"https://github.com/tstack/lnav.git","svn_url":"https://github.com/tstack/lnav","homepage":"http://lnav.org","size":7920,"stargazers_count":1048,"watchers_count":1048,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":56,"mirror_url":null,"open_issues_count":69,"forks":56,"open_issues":69,"watchers":1048,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tstack/lnav/pulls/320"},"html":{"href":"https://github.com/tstack/lnav/pull/320"},"issue":{"href":"https://api.github.com/repos/tstack/lnav/issues/320"},"comments":{"href":"https://api.github.com/repos/tstack/lnav/issues/320/comments"},"review_comments":{"href":"https://api.github.com/repos/tstack/lnav/pulls/320/comments"},"review_comment":{"href":"https://api.github.com/repos/tstack/lnav/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tstack/lnav/pulls/320/commits"},"statuses":{"href":"https://api.github.com/repos/tstack/lnav/statuses/6663740c5ef72765d3f870fe16cf346afbc2073c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":61,"changed_files":3}}