{"push_id":1196135905,"size":94,"distinct_size":94,"ref":"refs/heads/windows","head":"05981ca7a6573b011fe2d8cf350719dafade8b90","before":"e0254dc3df46f90cf2379b1a4495afb3c76b50ea","commits":[{"sha":"fb31bd3806c56b467dbaaf4dba26aaff4224fdc6","author":{"name":"sfan5","email":"7f05c09edde52b325cf9b1bece62a8643e005758@live.de"},"message":"Continue with 0.4.14-dev","distinct":true,"url":"https://api.github.com/repos/adrido/minetest/commits/fb31bd3806c56b467dbaaf4dba26aaff4224fdc6"},{"sha":"01a784bd11d833724fdf826d805429d3a6f7b1f5","author":{"name":"paramat","email":"9b4eb521d8212ef3c3b52db098473f6cccc50e90@virginmedia.com"},"message":"Documentation: Remove incorrect and excessive mapgen flags text","distinct":true,"url":"https://api.github.com/repos/adrido/minetest/commits/01a784bd11d833724fdf826d805429d3a6f7b1f5"},{"sha":"7a828de1bc658938243c0ddf85b7aab7a1087ccd","author":{"name":"est31","email":"df618117d4d8f2211ac641d6959cb1e7788125dd@outlook.com"},"message":"Android: enable parallelism for main target too\n\nThis adds to the changes that commit\n\n98d16e0d9a945f5f48462c05f26ae4bde2db5731 \"Android: Tell make about sub-makes to speed up build\"\n\ndid, and enables parallel builds for minetest\nitself as well.","distinct":true,"url":"https://api.github.com/repos/adrido/minetest/commits/7a828de1bc658938243c0ddf85b7aab7a1087ccd"},{"sha":"decbd396df0855f0a356c836cf7c0c5b133964cf","author":{"name":"sfan5","email":"7f05c09edde52b325cf9b1bece62a8643e005758@live.de"},"message":"Really fix ncurses lookup on Arch Linux\n\nCommit 27ee8d8943080a5dd735c9faa47c726604bafdff forgot to add the paths\nwithout ncursesw/ to the find_path() call","distinct":true,"url":"https://api.github.com/repos/adrido/minetest/commits/decbd396df0855f0a356c836cf7c0c5b133964cf"},{"sha":"143401451c457da5079b2970fe260acea45bd85a","author":{"name":"Loic Blot","email":"7c44d3d67ab8622788ce532cbeb027bae411bf5c@unix-experience.fr"},"message":"DB::loadBlock copy removal & DB backend cleanup\n* Remove the copy from db::loadBlock by using a pointer to the destination\n* cleanup db backend, the child backend doesn't have to set their functions as virtual","distinct":true,"url":"https://api.github.com/repos/adrido/minetest/commits/143401451c457da5079b2970fe260acea45bd85a"},{"sha":"8b940c005fd13db4e611ec49bc44881048b42cf7","author":{"name":"Wayward One","email":"3d6c81aa3263e37f60cb204163ac33070ddd5d4f@gmail.com"},"message":"Add on_punchnode callback","distinct":true,"url":"https://api.github.com/repos/adrido/minetest/commits/8b940c005fd13db4e611ec49bc44881048b42cf7"},{"sha":"8ba6d9f227398d2004d1fe7ae095f5e342dc6d7b","author":{"name":"nerzhul","email":"7c44d3d67ab8622788ce532cbeb027bae411bf5c@unix-experience.fr"},"message":"Implement DatabaseException for databases","distinct":true,"url":"https://api.github.com/repos/adrido/minetest/commits/8ba6d9f227398d2004d1fe7ae095f5e342dc6d7b"},{"sha":"88acda02567d586820867059718cac551dc7a58b","author":{"name":"Craig Robbins","email":"290c74159f5e7fd084b58eb1507741237e592228@gmail.com"},"message":"Fix tooltip height for versions of irrlicht < 1.8.2\n\nVersion 1.8.2 of irrlicht changed the way that IGUIStaticText::getTextHeight() works and since that release properly deals with newlines.\n\nFrom irrlicht changes.txt for 1.8.2, \"IGUIStaticText::getTextHeight returns now the correct height for texts with newlines even WordWrap is not set.\"","distinct":true,"url":"https://api.github.com/repos/adrido/minetest/commits/88acda02567d586820867059718cac551dc7a58b"},{"sha":"643ac9dd7aa1852b24348d853e82aa267dade789","author":{"name":"paramat","email":"9b4eb521d8212ef3c3b52db098473f6cccc50e90@virginmedia.com"},"message":"Item entities: Don't show description as infotext\n\nPartially reverts #3547\nInfotext remains optional for objects, empty by default","distinct":true,"url":"https://api.github.com/repos/adrido/minetest/commits/643ac9dd7aa1852b24348d853e82aa267dade789"},{"sha":"0f184d77c871b564b773b7fb81e7a3f16a197813","author":{"name":"HybridDog","email":"9329ef46ac68a49157734a5aad8117c3d26f45c0@web.de"},"message":"Gitignore: ignore idea and ninja files","distinct":true,"url":"https://api.github.com/repos/adrido/minetest/commits/0f184d77c871b564b773b7fb81e7a3f16a197813"},{"sha":"ce42ff9cf74ebb8d4b68bc78c95e90ea3db02b78","author":{"name":"Loic Blot","email":"7c44d3d67ab8622788ce532cbeb027bae411bf5c@unix-experience.fr"},"message":"Implement a PostgreSQL backend","distinct":true,"url":"https://api.github.com/repos/adrido/minetest/commits/ce42ff9cf74ebb8d4b68bc78c95e90ea3db02b78"},{"sha":"f64a6259b2b5e79103cfd4bc151304e6da39bca9","author":{"name":"Loic Blot","email":"7c44d3d67ab8622788ce532cbeb027bae411bf5c@unix-experience.fr"},"message":"Fix a m_camera not used warning fix pointed by clang","distinct":true,"url":"https://api.github.com/repos/adrido/minetest/commits/f64a6259b2b5e79103cfd4bc151304e6da39bca9"},{"sha":"423d8c1b0d3841f6ce9756ab0d6b2e10408fc89b","author":{"name":"est31","email":"df618117d4d8f2211ac641d6959cb1e7788125dd@outlook.com"},"message":"Tolerate packet reordering in the early init process\n\nFixes a bug where packet reordering made the server give the\nclient two peer ids instead of one. This in turn confused\nreliable packet sending and made connecting to the server fail.\n\nThe client usually sends three packets at init: one \"dummy\"\npacket consisting of two 0 bytes, and the init packet as well as\nits legacy counterpart. The last one can be turned off since commit\naf30183124d40a969040d7de4b3a487feec466e4, but this is of lower\nrelevance for the bug. The relevant part here is that network\npacket reorder (which is a normal occurence) can make the packets\nreach the server in different order.\n\nIf reorder puts the dummy packet further behind, the following\nwould happen before the patch:\n\n1. The server will get one of the init packets on channel 1 and\n   assign the client a peer id, as the packet will have zero as\n   peer id.\n\n2. The server sends a CONTROLTYPE_SET_PEER_ID packet to inform\n   the client of the peer id.\n\n3. The next packet from the client will contain the peer id set by\n   the server.\n\n4. The server sets the m_has_sent_with_id member for the client's\n   peer structure to true.\n\n5. Now the dummy packet arrives. It has a peer id of zero, therefore\n   the server searches whether it already has a peer id for the\n   address the packet was sent from. The search fails because\n   m_has_sent_with_id was set to true and the server only searched\n   for peers with m_has_sent_with_id set to false.\n\n6. In a working setup, the server would assign the dummy packet to\n   the correct peer id. However the server instead now assigns a\n   second peer id and peer structure to the peer, and assign the\n   packet to that new peer.\n\n7. In order to inform the peer of its peer id, the server sends a\n   CONTROLTYPE_SET_PEER_ID command packet, reliably, to the peer.\n   This packet uses the new peer id.\n\n8. The client sends an ack to that packet, not with the new peer id\n   but with the peer id sent in 2.\n\n9. This packet reaches the server, but it drops the ACK as the peer\n   id does not map to any un-ACK-ed packets with that seqnum. The\n   same time, the server still waits for an ACK with the new peer\n   id, which of course won't come. This causes the server to\n   periodically re-try sending that packet, and the client ACKing it\n   each time.\n\nSteps 7-9 cause annoyances and erroneous output, but don't cause\nthe connection failure itself.\nThe actual mistake that causes the connection failure happens in 6:\nThe server does not assign the dummy packet to the correct peer, but\nto a newly created one.\nTherefore, all further packets sent by the client on channel 0 are\nnow buffered by the server as it waits for the dummy packet to reach\nthe peer, which of course doesn't happen as the server assigned\nthat packet to the second peer it created for the client.\nThis makes the connection code indefinitely buffer the\nTOSERVER_CLIENT_READY packet, not passing it to higher level code,\nwhich stalls the continuation of the further init process\nindefinitely and causes the actual bug.\n\nMaybe this can be caused by reordered init packets as well, the only\nstudied case was where network has reliably reordered the dummy\npacket to get sent after the init packets.\n\nThe patch fixes the bug by not ignoring peers where\nm_has_sent_with_id has been set anymore. The other changes of the\npatch are just cleanups of unused methods and fields and additional\nexplanatory comments.\n\nOne could think of alternate ways to fix the bug:\n\n* The client could simply take the new peer id and continue\n  communicating with that. This is however worse than the fix as\n  it requires the peer id set command to be sent reliably (which\n  currently happens, but it cant be changed anymore). Also, such a\n  change would require both server and client to be patched in order\n  for the bug to be fixed, as right now the client ignores peer id\n  set commands after the peer id is different from\n  PEER_ID_INEXISTENT and the server requires modification too to\n  change the peer id internally.\n  And, most importantly, right now we guarantee higher level server\n  code that the peer id for a certain peer does not change. This\n  guarantee would have to be broken, and it would require much\n  larger changes to the server than this patch means.\n\n* One could stop sending the dummy packet. One may be unsure whether\n  this is a good idea, as the meaning of the dummy packet is not\n  known (it might be there for something important), and as it is\n  possible that the init packets may cause this problem as well\n  (although it may be possible too that they can't cause this).\n\nThanks to @auouymous who had originally reported this bug and who\nhas helped patiently in finding its cause.","distinct":true,"url":"https://api.github.com/repos/adrido/minetest/commits/423d8c1b0d3841f6ce9756ab0d6b2e10408fc89b"},{"sha":"725edc78b214f8ffa5494ed846755083295c3feb","author":{"name":"Ekdohibs","email":"9a68b6e9365468090846aebe78e8bee8d014c7f9@laposte.net"},"message":"Move updateTextures and fillTileAttribs to ContentFeatures","distinct":true,"url":"https://api.github.com/repos/adrido/minetest/commits/725edc78b214f8ffa5494ed846755083295c3feb"},{"sha":"22f78ea38e415c40ef445786b77788a40f4ddac3","author":{"name":"Craig Robbins","email":"290c74159f5e7fd084b58eb1507741237e592228@gmail.com"},"message":"Fix irrlicht version checking macro for tooltip_height calculation","distinct":true,"url":"https://api.github.com/repos/adrido/minetest/commits/22f78ea38e415c40ef445786b77788a40f4ddac3"},{"sha":"ef100f12a1346f7bfd2a05dc606cb22e97179c02","author":{"name":"ShadowNinja","email":"1e2a44ee05c66d369a674014b147625b6467a27a@minetest.net"},"message":"Fix rollback.txt migration\n\nBroken by b1965ac20922e3722392114bd63a22b403dcbe98.\nThis also prepares the begin and commit statements only once.","distinct":true,"url":"https://api.github.com/repos/adrido/minetest/commits/ef100f12a1346f7bfd2a05dc606cb22e97179c02"},{"sha":"fa6b21a15b415cd82dce6896b94a5341b7dd76f0","author":{"name":"est31","email":"df618117d4d8f2211ac641d6959cb1e7788125dd@outlook.com"},"message":"Tell irrlicht if we handle a key or not.\n\nWe can remove the function in MtNativeActivity now\nas it serves precisely that purpose: to tell irrlicht\nthat we handled the esc key.\n\nTODO for later:\n * Perhaps try to find a more performant container than KeyList","distinct":true,"url":"https://api.github.com/repos/adrido/minetest/commits/fa6b21a15b415cd82dce6896b94a5341b7dd76f0"},{"sha":"76f485647983ebd7eb4c3abbca0869d13f76920b","author":{"name":"kwolekr","email":"3e52e8ffcf9b074bd0a4b76d6c8b0114d330acec@minetest.net"},"message":"Move biome calculation to BiomeGen\n\nBiomeGen defines an interface that, given a set of BiomeParams, computes biomes\nfor a given area using the algorithm implemented by that specific BiomeGen.\nThis abstracts away the old system where each mapgen supplied the noises\nrequired for biome generation.","distinct":true,"url":"https://api.github.com/repos/adrido/minetest/commits/76f485647983ebd7eb4c3abbca0869d13f76920b"},{"sha":"87bc39dca733a2cc805bc1071794c4d5d7937115","author":{"name":"kwolekr","email":"3e52e8ffcf9b074bd0a4b76d6c8b0114d330acec@minetest.net"},"message":"Mapgen: Combine generateBiomes, dustTopNodes, and generateCaves\n\nThis commit condenses the above methods into a single implementation used by\nV7, V5, Flat, Fractal, and Valleys mapgens and introduces MapgenBasic.","distinct":true,"url":"https://api.github.com/repos/adrido/minetest/commits/87bc39dca733a2cc805bc1071794c4d5d7937115"},{"sha":"9b5c492be57945c2df63e84ce8dbf057f45b2754","author":{"name":"kwolekr","email":"3e52e8ffcf9b074bd0a4b76d6c8b0114d330acec@minetest.net"},"message":"Fix MgStoneType and BiomeType enum names","distinct":true,"url":"https://api.github.com/repos/adrido/minetest/commits/9b5c492be57945c2df63e84ce8dbf057f45b2754"}]}
{"actor":{"display_login":"adrido"}}