{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/comments/91902496","pull_request_review_id":12410136,"id":91902496,"diff_hunk":"@@ -34,7 +34,24 @@\n   $postrun_command     = undef\n   $dns_alt_names       = []\n   $use_srv_records     = false\n-  $srv_domain          = $::domain\n+\n+  # On versions < 3.7.5 there was no defined function as such strict variables cannot be used\n+  # On verisons < 4.0.0 and >= 3.5.0 the facts hash was optional disabled by default, on version < 3.5.0 the facts hash did not exist\n+  # In some edge cases 'domain' fact may be not defined\n+  if versioncmp($::puppetversion, '3.7.5') < 0 {\n+    $srv_domain = $::domain\n+  } elsif versioncmp($::puppetversion, '4.0.0') >= 0 {","path":"manifests/params.pp","position":11,"original_position":11,"commit_id":"193a2b3f983c4eb112f23189fb0a03e4ca0671d0","original_commit_id":"193a2b3f983c4eb112f23189fb0a03e4ca0671d0","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"body":"Is this block necessary? The `defined('$::domain')` test should work for 4 too.","created_at":"2016-12-12T08:42:20Z","updated_at":"2016-12-12T08:42:20Z","html_url":"https://github.com/theforeman/puppet-puppet/pull/467#discussion_r91902496","pull_request_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/467","_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/comments/91902496"},"html":{"href":"https://github.com/theforeman/puppet-puppet/pull/467#discussion_r91902496"},"pull_request":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/467"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/467","id":97447621,"html_url":"https://github.com/theforeman/puppet-puppet/pull/467","diff_url":"https://github.com/theforeman/puppet-puppet/pull/467.diff","patch_url":"https://github.com/theforeman/puppet-puppet/pull/467.patch","issue_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/467","number":467,"state":"open","locked":false,"title":"addressing use cases where $::domain fact is null","user":{"login":"james-powis","id":2318207,"avatar_url":"https://avatars.githubusercontent.com/u/2318207?v=3","gravatar_id":"","url":"https://api.github.com/users/james-powis","html_url":"https://github.com/james-powis","followers_url":"https://api.github.com/users/james-powis/followers","following_url":"https://api.github.com/users/james-powis/following{/other_user}","gists_url":"https://api.github.com/users/james-powis/gists{/gist_id}","starred_url":"https://api.github.com/users/james-powis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-powis/subscriptions","organizations_url":"https://api.github.com/users/james-powis/orgs","repos_url":"https://api.github.com/users/james-powis/repos","events_url":"https://api.github.com/users/james-powis/events{/privacy}","received_events_url":"https://api.github.com/users/james-powis/received_events","type":"User","site_admin":false},"body":"Ref: #465 \r\n\r\nSome times it is possible for the domain fact to be null\r\nthese changes address such an instance, sometimes...\r\n\r\nOn puppet version > 3.5.0 and < 4.0.0 the facts hash was disabled by\r\ndefault.\r\n\r\nOn puppet version < 3.7.5 due to the absence of a defined function we\r\nhope\r\nfor the best and insist that strict variables is disabled.\r\n\r\nOn puppet version >= 4.0.0 we have a facts hash available by default for\r\neval such as `if $facts['domain'] == nul` so leverage that to determine\r\npresence. This sufficiently prevents the warning messages when strict\r\nvariables is disabled, (and prevents compile errors when enabled).\r\n\r\nLastly the \"momma bear\" versions < 4.0.0 (where facts hash is enabled by\r\ndefault) and > 3.7.4 (where the facts hash is present but not enabled by\r\ndefault), and defined function is present and functional. It is still\r\nbelieved that this\r\nchange does not allow for $::domain to be unset in facts and strict vars\r\nenabled... Unfortunately there is ABSOLUTELY no way to fix this...\r\nfortunately puppet 3.x.x goes end of life at end of month...","created_at":"2016-12-11T03:58:21Z","updated_at":"2016-12-12T08:42:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f96334b1285d5fdce81accc1912d3f3716e297fd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/467/commits","review_comments_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/467/comments","review_comment_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/467/comments","statuses_url":"https://api.github.com/repos/theforeman/puppet-puppet/statuses/193a2b3f983c4eb112f23189fb0a03e4ca0671d0","head":{"label":"james-powis:465_fix_null_facts","ref":"465_fix_null_facts","sha":"193a2b3f983c4eb112f23189fb0a03e4ca0671d0","user":{"login":"james-powis","id":2318207,"avatar_url":"https://avatars.githubusercontent.com/u/2318207?v=3","gravatar_id":"","url":"https://api.github.com/users/james-powis","html_url":"https://github.com/james-powis","followers_url":"https://api.github.com/users/james-powis/followers","following_url":"https://api.github.com/users/james-powis/following{/other_user}","gists_url":"https://api.github.com/users/james-powis/gists{/gist_id}","starred_url":"https://api.github.com/users/james-powis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-powis/subscriptions","organizations_url":"https://api.github.com/users/james-powis/orgs","repos_url":"https://api.github.com/users/james-powis/repos","events_url":"https://api.github.com/users/james-powis/events{/privacy}","received_events_url":"https://api.github.com/users/james-powis/received_events","type":"User","site_admin":false},"repo":{"id":75347595,"name":"puppet-puppet","full_name":"james-powis/puppet-puppet","owner":{"login":"james-powis","id":2318207,"avatar_url":"https://avatars.githubusercontent.com/u/2318207?v=3","gravatar_id":"","url":"https://api.github.com/users/james-powis","html_url":"https://github.com/james-powis","followers_url":"https://api.github.com/users/james-powis/followers","following_url":"https://api.github.com/users/james-powis/following{/other_user}","gists_url":"https://api.github.com/users/james-powis/gists{/gist_id}","starred_url":"https://api.github.com/users/james-powis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james-powis/subscriptions","organizations_url":"https://api.github.com/users/james-powis/orgs","repos_url":"https://api.github.com/users/james-powis/repos","events_url":"https://api.github.com/users/james-powis/events{/privacy}","received_events_url":"https://api.github.com/users/james-powis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/james-powis/puppet-puppet","description":"Puppet module for Puppet client and server","fork":true,"url":"https://api.github.com/repos/james-powis/puppet-puppet","forks_url":"https://api.github.com/repos/james-powis/puppet-puppet/forks","keys_url":"https://api.github.com/repos/james-powis/puppet-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/james-powis/puppet-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/james-powis/puppet-puppet/teams","hooks_url":"https://api.github.com/repos/james-powis/puppet-puppet/hooks","issue_events_url":"https://api.github.com/repos/james-powis/puppet-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/james-powis/puppet-puppet/events","assignees_url":"https://api.github.com/repos/james-powis/puppet-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/james-powis/puppet-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/james-powis/puppet-puppet/tags","blobs_url":"https://api.github.com/repos/james-powis/puppet-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/james-powis/puppet-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/james-powis/puppet-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/james-powis/puppet-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/james-powis/puppet-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/james-powis/puppet-puppet/languages","stargazers_url":"https://api.github.com/repos/james-powis/puppet-puppet/stargazers","contributors_url":"https://api.github.com/repos/james-powis/puppet-puppet/contributors","subscribers_url":"https://api.github.com/repos/james-powis/puppet-puppet/subscribers","subscription_url":"https://api.github.com/repos/james-powis/puppet-puppet/subscription","commits_url":"https://api.github.com/repos/james-powis/puppet-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/james-powis/puppet-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/james-powis/puppet-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/james-powis/puppet-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/james-powis/puppet-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/james-powis/puppet-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/james-powis/puppet-puppet/merges","archive_url":"https://api.github.com/repos/james-powis/puppet-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/james-powis/puppet-puppet/downloads","issues_url":"https://api.github.com/repos/james-powis/puppet-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/james-powis/puppet-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/james-powis/puppet-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/james-powis/puppet-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/james-powis/puppet-puppet/labels{/name}","releases_url":"https://api.github.com/repos/james-powis/puppet-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/james-powis/puppet-puppet/deployments","created_at":"2016-12-02T01:14:45Z","updated_at":"2016-12-02T01:14:47Z","pushed_at":"2016-12-12T00:28:22Z","git_url":"git://github.com/james-powis/puppet-puppet.git","ssh_url":"git@github.com:james-powis/puppet-puppet.git","clone_url":"https://github.com/james-powis/puppet-puppet.git","svn_url":"https://github.com/james-powis/puppet-puppet","homepage":"","size":937,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:master","ref":"master","sha":"3e90793358901dd93f218ec762977a1d79710aa6","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":3449635,"name":"puppet-puppet","full_name":"theforeman/puppet-puppet","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/puppet-puppet","description":"Puppet module for Puppet client and server","fork":false,"url":"https://api.github.com/repos/theforeman/puppet-puppet","forks_url":"https://api.github.com/repos/theforeman/puppet-puppet/forks","keys_url":"https://api.github.com/repos/theforeman/puppet-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/puppet-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/puppet-puppet/teams","hooks_url":"https://api.github.com/repos/theforeman/puppet-puppet/hooks","issue_events_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/puppet-puppet/events","assignees_url":"https://api.github.com/repos/theforeman/puppet-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/puppet-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/puppet-puppet/tags","blobs_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/puppet-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/puppet-puppet/languages","stargazers_url":"https://api.github.com/repos/theforeman/puppet-puppet/stargazers","contributors_url":"https://api.github.com/repos/theforeman/puppet-puppet/contributors","subscribers_url":"https://api.github.com/repos/theforeman/puppet-puppet/subscribers","subscription_url":"https://api.github.com/repos/theforeman/puppet-puppet/subscription","commits_url":"https://api.github.com/repos/theforeman/puppet-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/puppet-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/puppet-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/puppet-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/puppet-puppet/merges","archive_url":"https://api.github.com/repos/theforeman/puppet-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/puppet-puppet/downloads","issues_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/puppet-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/puppet-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/puppet-puppet/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/puppet-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/puppet-puppet/deployments","created_at":"2012-02-15T13:23:34Z","updated_at":"2016-11-18T18:12:53Z","pushed_at":"2016-12-12T00:38:51Z","git_url":"git://github.com/theforeman/puppet-puppet.git","ssh_url":"git@github.com:theforeman/puppet-puppet.git","clone_url":"https://github.com/theforeman/puppet-puppet.git","svn_url":"https://github.com/theforeman/puppet-puppet","homepage":"","size":1349,"stargazers_count":59,"watchers_count":59,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":158,"mirror_url":null,"open_issues_count":16,"forks":158,"open_issues":16,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/467"},"html":{"href":"https://github.com/theforeman/puppet-puppet/pull/467"},"issue":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/issues/467"},"comments":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/issues/467/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/467/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/467/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/statuses/193a2b3f983c4eb112f23189fb0a03e4ca0671d0"}}}}
{"actor":{"display_login":"domcleal"}}