{"action":"created","issue":{"url":"https://api.github.com/repos/kirjs/ng2-codelab/issues/42","repository_url":"https://api.github.com/repos/kirjs/ng2-codelab","labels_url":"https://api.github.com/repos/kirjs/ng2-codelab/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/kirjs/ng2-codelab/issues/42/comments","events_url":"https://api.github.com/repos/kirjs/ng2-codelab/issues/42/events","html_url":"https://github.com/kirjs/ng2-codelab/pull/42","id":193551302,"number":42,"title":"Feature/autoruncontrol","user":{"login":"momoadeli","id":3706255,"avatar_url":"https://avatars.githubusercontent.com/u/3706255?v=3","gravatar_id":"","url":"https://api.github.com/users/momoadeli","html_url":"https://github.com/momoadeli","followers_url":"https://api.github.com/users/momoadeli/followers","following_url":"https://api.github.com/users/momoadeli/following{/other_user}","gists_url":"https://api.github.com/users/momoadeli/gists{/gist_id}","starred_url":"https://api.github.com/users/momoadeli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/momoadeli/subscriptions","organizations_url":"https://api.github.com/users/momoadeli/orgs","repos_url":"https://api.github.com/users/momoadeli/repos","events_url":"https://api.github.com/users/momoadeli/events{/privacy}","received_events_url":"https://api.github.com/users/momoadeli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-05T16:53:05Z","updated_at":"2016-12-05T20:32:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kirjs/ng2-codelab/pulls/42","html_url":"https://github.com/kirjs/ng2-codelab/pull/42","diff_url":"https://github.com/kirjs/ng2-codelab/pull/42.diff","patch_url":"https://github.com/kirjs/ng2-codelab/pull/42.patch"},"body":"**_(replaces previous pull request.  removed majority of comments --left a couple of suggested todo's--and also removed git references to #9 (altho you seemed to have merged) . Also, screenshots below.)_**\r\n\r\nKirill, here is a draft of a working autorun ON/OFF functionality. Please feedback before I move further (cleanup, redundancies, etc)--I want to make sure I leave this in a state that you above all are comfortable with for obvious reasons. BTW, there are no 3d party libs (removed bootstrap). A few quick items:\r\n\r\n1. There are a few ways autorun ON/OFF could be implemented. Currently I have a 'decoupled' autoruncontrol.component.ts) which @Outputs its 'state' via OnAutorunChange to its parent exercise.component.ts.. After your feedback, instead of the emitted (@Output), I would like to enhance this where the parent can pass through an (@Input) method to this component to use for 'run-click' which I believe is a cleaner pattern.\r\n1A: Needless to say, the autorunner has a 'toggler' The proper[ActionType.TOGGLE_AUTORUN] method has been added to the reducers.service.ts.\r\n2. exercise.component.ts: Here I've added a (@Output)OnAutorunChange which is triggered by autorun.component.ts similar to (@Output)onCodeChange which is triggered by its editors.components.ts child. Both, one way or another, eventually, execute a `this.state.updateCode(changedFile`) which is handled by the `state.service.ts`.\r\n3. I've tried to follow your current styles and patterns with the other knick-knack code I've added to build this here and there.\r\n4. I'm not a UI designer, so let me know if you're comfortable with the autoruncontrol.component.ts look and feel. There are different ways this can be done too.\r\n\r\nLooking forward to feedback. Talk soon!\r\n\r\n![screen shot 2016-12-05 at 12 15 02 pm](https://cloud.githubusercontent.com/assets/3706255/20894736/99ed82d2-bae4-11e6-85ba-765c4fd9b680.png)\r\n![screen shot 2016-12-05 at 12 19 17 pm](https://cloud.githubusercontent.com/assets/3706255/20894877/22337386-bae5-11e6-9570-147b6d5f4092.png)\r\n\r\n![screen shot 2016-12-05 at 12 15 20 pm](https://cloud.githubusercontent.com/assets/3706255/20894737/99ee084c-bae4-11e6-8273-58c741f05f11.png)\r\n"},"comment":{"url":"https://api.github.com/repos/kirjs/ng2-codelab/issues/comments/264968521","html_url":"https://github.com/kirjs/ng2-codelab/pull/42#issuecomment-264968521","issue_url":"https://api.github.com/repos/kirjs/ng2-codelab/issues/42","id":264968521,"user":{"login":"momoadeli","id":3706255,"avatar_url":"https://avatars.githubusercontent.com/u/3706255?v=3","gravatar_id":"","url":"https://api.github.com/users/momoadeli","html_url":"https://github.com/momoadeli","followers_url":"https://api.github.com/users/momoadeli/followers","following_url":"https://api.github.com/users/momoadeli/following{/other_user}","gists_url":"https://api.github.com/users/momoadeli/gists{/gist_id}","starred_url":"https://api.github.com/users/momoadeli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/momoadeli/subscriptions","organizations_url":"https://api.github.com/users/momoadeli/orgs","repos_url":"https://api.github.com/users/momoadeli/repos","events_url":"https://api.github.com/users/momoadeli/events{/privacy}","received_events_url":"https://api.github.com/users/momoadeli/received_events","type":"User","site_admin":false},"created_at":"2016-12-05T20:32:49Z","updated_at":"2016-12-05T20:32:49Z","body":"@kirjs ,please feel free to merge mine in (I might slow you down otherwise). I'll update my fork accordingly (although still not sure why I'm seeing my fork behind your repo already--ergo the previous 'spec' code I removed from my branch). I'm going to continue with improvements. Meanwhile, I'll scan the other issues to see if I can add a hand other places if that's ok with you...:)"}}
{"actor":{"display_login":"momoadeli"}}