{"action":"created","comment":{"url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/pulls/comments/66946574","id":66946574,"diff_hunk":"@@ -27,16 +27,16 @@ class PluginMediaStreamRenderer : NSObject, RTCEAGLVideoViewDelegate {\n \t\t// It's placed over the elementView.\n \t\tself.videoView = RTCEAGLVideoView()\n \n-\t\tself.webView.addSubview(self.elementView)\n-\t\tself.webView.bringSubviewToFront(self.elementView)\n-\n \t\tself.elementView.userInteractionEnabled = false\n \t\tself.elementView.hidden = true\n-\t\tself.elementView.backgroundColor = UIColor.blackColor()\n+\t\tself.elementView.backgroundColor = UIColor.clearColor()","path":"src/PluginMediaStreamRenderer.swift","position":10,"original_position":10,"commit_id":"68797951f199452413f0cd907089fca759eea915","original_commit_id":"68797951f199452413f0cd907089fca759eea915","user":{"login":"ibc","id":16191,"avatar_url":"https://avatars.githubusercontent.com/u/16191?v=3","gravatar_id":"","url":"https://api.github.com/users/ibc","html_url":"https://github.com/ibc","followers_url":"https://api.github.com/users/ibc/followers","following_url":"https://api.github.com/users/ibc/following{/other_user}","gists_url":"https://api.github.com/users/ibc/gists{/gist_id}","starred_url":"https://api.github.com/users/ibc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibc/subscriptions","organizations_url":"https://api.github.com/users/ibc/orgs","repos_url":"https://api.github.com/users/ibc/repos","events_url":"https://api.github.com/users/ibc/events{/privacy}","received_events_url":"https://api.github.com/users/ibc/received_events","type":"User","site_admin":false},"body":"Why don't you let the video view to be black when no video is rendered (as a common video element)?","created_at":"2016-06-14T10:38:35Z","updated_at":"2016-06-14T10:38:35Z","html_url":"https://github.com/eface2face/cordova-plugin-iosrtc/pull/179#discussion_r66946574","pull_request_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/pulls/179","_links":{"self":{"href":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/pulls/comments/66946574"},"html":{"href":"https://github.com/eface2face/cordova-plugin-iosrtc/pull/179#discussion_r66946574"},"pull_request":{"href":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/pulls/179"}}},"pull_request":{"url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/pulls/179","id":73402548,"html_url":"https://github.com/eface2face/cordova-plugin-iosrtc/pull/179","diff_url":"https://github.com/eface2face/cordova-plugin-iosrtc/pull/179.diff","patch_url":"https://github.com/eface2face/cordova-plugin-iosrtc/pull/179.patch","issue_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/issues/179","number":179,"state":"open","locked":false,"title":"Fix positioning video elements using z-index","user":{"login":"saghul","id":317464,"avatar_url":"https://avatars.githubusercontent.com/u/317464?v=3","gravatar_id":"","url":"https://api.github.com/users/saghul","html_url":"https://github.com/saghul","followers_url":"https://api.github.com/users/saghul/followers","following_url":"https://api.github.com/users/saghul/following{/other_user}","gists_url":"https://api.github.com/users/saghul/gists{/gist_id}","starred_url":"https://api.github.com/users/saghul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghul/subscriptions","organizations_url":"https://api.github.com/users/saghul/orgs","repos_url":"https://api.github.com/users/saghul/repos","events_url":"https://api.github.com/users/saghul/events{/privacy}","received_events_url":"https://api.github.com/users/saghul/received_events","type":"User","site_admin":false},"body":"Instead of adding the video element view as a su-view of the WebView,\r\nadd it as a subview of it's superview. This puts the WebView and the\r\nvideo views at the same level (aka, they are siblings) and the layer's\r\nzPosition is considered amongst siblings.\r\n\r\nSince an ASCII diagram is worth a thousand images, this is the layout\r\nbefore this patch:\r\n\r\n~~~~\r\n+-------------------------------+\r\n|           superview           |\r\n+-------------------------------+\r\n+-------------------------------+\r\n|            WebView            |\r\n+-------------------------------+\r\n+--------------+ +--------------+\r\n|  videoView1  | |  videoView2  |\r\n+--------------+ +--------------+\r\n~~~~\r\n\r\nAnd after:\r\n\r\n~~~~\r\n+---------------------------------------+\r\n|                superview              |\r\n+---------------------------------------+\r\n+---------+ +------------+ +------------+\r\n| WebView | | videoView1 | | videoView2 |\r\n+---------+ +------------+ +------------+\r\n~~~~\r\n\r\nThis makes it possible to order videos \"behind\" the WebView, which this\r\npatch makes transparent, and thus have HTML elements on top of the video\r\nviews.\r\n\r\nProps to @1N50MN14 for writing a first version of (what became) this patch.\r\n\r\nSupersedes: https://github.com/eface2face/cordova-plugin-iosrtc/pull/98","created_at":"2016-06-10T16:44:30Z","updated_at":"2016-06-14T10:38:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5eb2dcb1a9867ea975f49002c2aab9a85584deb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/pulls/179/commits","review_comments_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/pulls/179/comments","review_comment_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/issues/179/comments","statuses_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/statuses/68797951f199452413f0cd907089fca759eea915","head":{"label":"saghul:stacked-uiview","ref":"stacked-uiview","sha":"68797951f199452413f0cd907089fca759eea915","user":{"login":"saghul","id":317464,"avatar_url":"https://avatars.githubusercontent.com/u/317464?v=3","gravatar_id":"","url":"https://api.github.com/users/saghul","html_url":"https://github.com/saghul","followers_url":"https://api.github.com/users/saghul/followers","following_url":"https://api.github.com/users/saghul/following{/other_user}","gists_url":"https://api.github.com/users/saghul/gists{/gist_id}","starred_url":"https://api.github.com/users/saghul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghul/subscriptions","organizations_url":"https://api.github.com/users/saghul/orgs","repos_url":"https://api.github.com/users/saghul/repos","events_url":"https://api.github.com/users/saghul/events{/privacy}","received_events_url":"https://api.github.com/users/saghul/received_events","type":"User","site_admin":false},"repo":{"id":42661926,"name":"cordova-plugin-iosrtc","full_name":"saghul/cordova-plugin-iosrtc","owner":{"login":"saghul","id":317464,"avatar_url":"https://avatars.githubusercontent.com/u/317464?v=3","gravatar_id":"","url":"https://api.github.com/users/saghul","html_url":"https://github.com/saghul","followers_url":"https://api.github.com/users/saghul/followers","following_url":"https://api.github.com/users/saghul/following{/other_user}","gists_url":"https://api.github.com/users/saghul/gists{/gist_id}","starred_url":"https://api.github.com/users/saghul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghul/subscriptions","organizations_url":"https://api.github.com/users/saghul/orgs","repos_url":"https://api.github.com/users/saghul/repos","events_url":"https://api.github.com/users/saghul/events{/privacy}","received_events_url":"https://api.github.com/users/saghul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saghul/cordova-plugin-iosrtc","description":"Cordova iOS plugin exposing the full WebRTC W3C JavaScript APIs","fork":true,"url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc","forks_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/forks","keys_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/teams","hooks_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/hooks","issue_events_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/issues/events{/number}","events_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/events","assignees_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/assignees{/user}","branches_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/branches{/branch}","tags_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/tags","blobs_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/statuses/{sha}","languages_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/languages","stargazers_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/stargazers","contributors_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/contributors","subscribers_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/subscribers","subscription_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/subscription","commits_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/issues/comments{/number}","contents_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/contents/{+path}","compare_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/merges","archive_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/downloads","issues_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/issues{/number}","pulls_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/pulls{/number}","milestones_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/milestones{/number}","notifications_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/labels{/name}","releases_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/releases{/id}","deployments_url":"https://api.github.com/repos/saghul/cordova-plugin-iosrtc/deployments","created_at":"2015-09-17T14:45:12Z","updated_at":"2015-09-17T14:45:13Z","pushed_at":"2016-06-10T16:42:46Z","git_url":"git://github.com/saghul/cordova-plugin-iosrtc.git","ssh_url":"git@github.com:saghul/cordova-plugin-iosrtc.git","clone_url":"https://github.com/saghul/cordova-plugin-iosrtc.git","svn_url":"https://github.com/saghul/cordova-plugin-iosrtc","homepage":null,"size":136838,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eface2face:master","ref":"master","sha":"25a694491742a98b1676cbf36ff854dd78133835","user":{"login":"eface2face","id":10630478,"avatar_url":"https://avatars.githubusercontent.com/u/10630478?v=3","gravatar_id":"","url":"https://api.github.com/users/eface2face","html_url":"https://github.com/eface2face","followers_url":"https://api.github.com/users/eface2face/followers","following_url":"https://api.github.com/users/eface2face/following{/other_user}","gists_url":"https://api.github.com/users/eface2face/gists{/gist_id}","starred_url":"https://api.github.com/users/eface2face/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eface2face/subscriptions","organizations_url":"https://api.github.com/users/eface2face/orgs","repos_url":"https://api.github.com/users/eface2face/repos","events_url":"https://api.github.com/users/eface2face/events{/privacy}","received_events_url":"https://api.github.com/users/eface2face/received_events","type":"Organization","site_admin":false},"repo":{"id":35824902,"name":"cordova-plugin-iosrtc","full_name":"eface2face/cordova-plugin-iosrtc","owner":{"login":"eface2face","id":10630478,"avatar_url":"https://avatars.githubusercontent.com/u/10630478?v=3","gravatar_id":"","url":"https://api.github.com/users/eface2face","html_url":"https://github.com/eface2face","followers_url":"https://api.github.com/users/eface2face/followers","following_url":"https://api.github.com/users/eface2face/following{/other_user}","gists_url":"https://api.github.com/users/eface2face/gists{/gist_id}","starred_url":"https://api.github.com/users/eface2face/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eface2face/subscriptions","organizations_url":"https://api.github.com/users/eface2face/orgs","repos_url":"https://api.github.com/users/eface2face/repos","events_url":"https://api.github.com/users/eface2face/events{/privacy}","received_events_url":"https://api.github.com/users/eface2face/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eface2face/cordova-plugin-iosrtc","description":"Cordova iOS plugin exposing the full WebRTC W3C JavaScript APIs","fork":false,"url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc","forks_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/forks","keys_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/teams","hooks_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/hooks","issue_events_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/issues/events{/number}","events_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/events","assignees_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/assignees{/user}","branches_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/branches{/branch}","tags_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/tags","blobs_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/statuses/{sha}","languages_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/languages","stargazers_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/stargazers","contributors_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/contributors","subscribers_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/subscribers","subscription_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/subscription","commits_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/issues/comments{/number}","contents_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/contents/{+path}","compare_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/merges","archive_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/downloads","issues_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/issues{/number}","pulls_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/pulls{/number}","milestones_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/milestones{/number}","notifications_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/labels{/name}","releases_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/releases{/id}","deployments_url":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/deployments","created_at":"2015-05-18T15:09:19Z","updated_at":"2016-06-08T19:09:28Z","pushed_at":"2016-06-10T16:44:30Z","git_url":"git://github.com/eface2face/cordova-plugin-iosrtc.git","ssh_url":"git@github.com:eface2face/cordova-plugin-iosrtc.git","clone_url":"https://github.com/eface2face/cordova-plugin-iosrtc.git","svn_url":"https://github.com/eface2face/cordova-plugin-iosrtc","homepage":null,"size":136861,"stargazers_count":243,"watchers_count":243,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":89,"mirror_url":null,"open_issues_count":14,"forks":89,"open_issues":14,"watchers":243,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/pulls/179"},"html":{"href":"https://github.com/eface2face/cordova-plugin-iosrtc/pull/179"},"issue":{"href":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/issues/179"},"comments":{"href":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/eface2face/cordova-plugin-iosrtc/statuses/68797951f199452413f0cd907089fca759eea915"}}}}
{"actor":{"display_login":"ibc"}}