{"action":"created","issue":{"url":"https://api.github.com/repos/google/cadvisor/issues/1062","labels_url":"https://api.github.com/repos/google/cadvisor/issues/1062/labels{/name}","comments_url":"https://api.github.com/repos/google/cadvisor/issues/1062/comments","events_url":"https://api.github.com/repos/google/cadvisor/issues/1062/events","html_url":"https://github.com/google/cadvisor/issues/1062","id":127259152,"number":1062,"title":"Incorrect handling of docker container cgroup","user":{"login":"dqminh","id":62707,"avatar_url":"https://avatars.githubusercontent.com/u/62707?v=3","gravatar_id":"","url":"https://api.github.com/users/dqminh","html_url":"https://github.com/dqminh","followers_url":"https://api.github.com/users/dqminh/followers","following_url":"https://api.github.com/users/dqminh/following{/other_user}","gists_url":"https://api.github.com/users/dqminh/gists{/gist_id}","starred_url":"https://api.github.com/users/dqminh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dqminh/subscriptions","organizations_url":"https://api.github.com/users/dqminh/orgs","repos_url":"https://api.github.com/users/dqminh/repos","events_url":"https://api.github.com/users/dqminh/events{/privacy}","received_events_url":"https://api.github.com/users/dqminh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-18T16:14:21Z","updated_at":"2016-01-19T18:50:16Z","closed_at":null,"body":"cadvisor seems to mishandling the containers cgroup in a systemd host ( at least with 1.10-dev ). Given a host that has the following cgroup layout\r\n\r\n```\r\n/sys/fs/cgroup\r\n-> /cpu\r\n  -> /docker\r\n    -> /2eedaaf84987b9297c012a2acb2aa114029b924d3216562653affba409f16333\r\n  -> /system.slice\r\n-> /systemd\r\n```\r\n\r\nThis is the layout created when we are on a systemd host, but use the fs cgroup and set cgroup-parent to docker, and is the default setting. This setup will make `UseSystemd` returns true, while containers are actually in a different cgroup, so we miss the docker container data.\r\n\r\nPerhaps we should just remove `UseSystemd` as running on a systemd host doesnt mean that it uses the systemd cgroup approach, or maybe docker should tell us which cgroup driver it is using via /info so we can check for it in `UseSystemd`\r\n\r\nping @vishh \r\n"},"comment":{"url":"https://api.github.com/repos/google/cadvisor/issues/comments/172949240","html_url":"https://github.com/google/cadvisor/issues/1062#issuecomment-172949240","issue_url":"https://api.github.com/repos/google/cadvisor/issues/1062","id":172949240,"user":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"created_at":"2016-01-19T18:50:16Z","updated_at":"2016-01-19T18:50:16Z","body":"We added a flag recently to disable systemd assumption. IIRC, the flag was\n`--nosystemd=true`.\n\nOn Mon, Jan 18, 2016 at 8:14 AM, Daniel, Dao Quang Minh <\nnotifications@github.com> wrote:\n\n> cadvisor seems to mishandling the containers cgroup in a systemd host ( at\n> least with 1.10-dev ). Given a host that has the following cgroup layout\n>\n> /sys/fs/cgroup\n> -> /cpu\n>   -> /docker\n>     -> /2eedaaf84987b9297c012a2acb2aa114029b924d3216562653affba409f16333\n>   -> /system.slice\n> -> /systemd\n>\n> This is the layout created when we are on a systemd host, but use the fs\n> cgroup and set cgroup-parent to docker, and is the default setting. This\n> setup will make UseSystemd returns true, while containers are actually in\n> a different cgroup, so we miss the docker container data.\n>\n> Perhaps we should just remove UseSystemd as running on a systemd host\n> doesnt mean that it uses the systemd cgroup approach, or maybe docker\n> should tell us which cgroup driver it is using via /info so we can check\n> for it in UseSystemd\n>\n> ping @vishh <https://github.com/vishh>\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/google/cadvisor/issues/1062>.\n>\n"}}