{"action":"created","issue":{"url":"https://api.github.com/repos/mhirdes/go_maps_ext/issues/14","repository_url":"https://api.github.com/repos/mhirdes/go_maps_ext","labels_url":"https://api.github.com/repos/mhirdes/go_maps_ext/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/mhirdes/go_maps_ext/issues/14/comments","events_url":"https://api.github.com/repos/mhirdes/go_maps_ext/issues/14/events","html_url":"https://github.com/mhirdes/go_maps_ext/pull/14","id":158334544,"number":14,"title":"Object oriented Javascript","user":{"login":"cundd","id":743122,"avatar_url":"https://avatars.githubusercontent.com/u/743122?v=3","gravatar_id":"","url":"https://api.github.com/users/cundd","html_url":"https://github.com/cundd","followers_url":"https://api.github.com/users/cundd/followers","following_url":"https://api.github.com/users/cundd/following{/other_user}","gists_url":"https://api.github.com/users/cundd/gists{/gist_id}","starred_url":"https://api.github.com/users/cundd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cundd/subscriptions","organizations_url":"https://api.github.com/users/cundd/orgs","repos_url":"https://api.github.com/users/cundd/repos","events_url":"https://api.github.com/users/cundd/events{/privacy}","received_events_url":"https://api.github.com/users/cundd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-06-03T10:10:15Z","updated_at":"2016-06-27T13:41:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mhirdes/go_maps_ext/pulls/14","html_url":"https://github.com/mhirdes/go_maps_ext/pull/14","diff_url":"https://github.com/mhirdes/go_maps_ext/pull/14.diff","patch_url":"https://github.com/mhirdes/go_maps_ext/pull/14.patch"},"body":"I tried to transform the Javascript into OOP style. The benefits are a clearer separation of the code's aspects and structure. \r\n\r\nAnother big point is the ability to access the Javascript object through `$('#map').data('gomapsextcontroller')`, which allows external extensions to modify the map (e.g. focus a marker, change the selected categories)."},"comment":{"url":"https://api.github.com/repos/mhirdes/go_maps_ext/issues/comments/228748663","html_url":"https://github.com/mhirdes/go_maps_ext/pull/14#issuecomment-228748663","issue_url":"https://api.github.com/repos/mhirdes/go_maps_ext/issues/14","id":228748663,"user":{"login":"mhirdes","id":915162,"avatar_url":"https://avatars.githubusercontent.com/u/915162?v=3","gravatar_id":"","url":"https://api.github.com/users/mhirdes","html_url":"https://github.com/mhirdes","followers_url":"https://api.github.com/users/mhirdes/followers","following_url":"https://api.github.com/users/mhirdes/following{/other_user}","gists_url":"https://api.github.com/users/mhirdes/gists{/gist_id}","starred_url":"https://api.github.com/users/mhirdes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhirdes/subscriptions","organizations_url":"https://api.github.com/users/mhirdes/orgs","repos_url":"https://api.github.com/users/mhirdes/repos","events_url":"https://api.github.com/users/mhirdes/events{/privacy}","received_events_url":"https://api.github.com/users/mhirdes/received_events","type":"User","site_admin":false},"created_at":"2016-06-27T13:41:59Z","updated_at":"2016-06-27T13:41:59Z","body":"Please check https://github.com/mhirdes/go_maps_ext/tree/iresults-feature/oop-javascript I had problems with the checkbox selection by categories. To throw an error I deleted, because the length of the array could be zero. And I deleted the string type check, because the selection didn't work. Maybe you can take a look into the branch. If you aggree I would merge the branche with the master."}}
{"actor":{"display_login":"mhirdes"}}