{"action":"created","comment":{"url":"https://api.github.com/repos/briansmith/ring/pulls/comments/60446450","id":60446450,"diff_hunk":"@@ -121,6 +121,11 @@ def format_entries():\n             %(sources)s\"\"\"\n \n def format_entry(os, target, compiler, rust, mode):\n+    if os == \"linux\" and compiler == \"gcc-5\" and rust == \"nightly\" and mode == \"DEBUG\":","path":"mk/update-travis-yml.py","position":13,"original_position":13,"commit_id":"b204d6a4723a743ec762a1942a6765d11a6dcc89","original_commit_id":"ec7949b1fba0b24ff4180ef7332738c4c133f81a","user":{"login":"pietro","id":238200,"avatar_url":"https://avatars.githubusercontent.com/u/238200?v=3","gravatar_id":"","url":"https://api.github.com/users/pietro","html_url":"https://github.com/pietro","followers_url":"https://api.github.com/users/pietro/followers","following_url":"https://api.github.com/users/pietro/following{/other_user}","gists_url":"https://api.github.com/users/pietro/gists{/gist_id}","starred_url":"https://api.github.com/users/pietro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pietro/subscriptions","organizations_url":"https://api.github.com/users/pietro/orgs","repos_url":"https://api.github.com/users/pietro/repos","events_url":"https://api.github.com/users/pietro/events{/privacy}","received_events_url":"https://api.github.com/users/pietro/received_events","type":"User","site_admin":false},"body":"I picked nightly because passing `-C link-dead-code` to rustc using RUSTFLAGS currently only works on beta and nightly. I can change to stable and it will start working when the next release happens. Until then coverage tracing won't be as accurate.\r\n\r\nI picked gcc-5 as an example. I wanted to run kcov on just one build. Should I do it on all of them?\r\n\r\nThe debug symbols are needed for coverage tracking. Should I change the release builds to add them too on this pr?","created_at":"2016-04-20T16:54:51Z","updated_at":"2016-04-20T16:54:51Z","html_url":"https://github.com/briansmith/ring/pull/167#discussion_r60446450","pull_request_url":"https://api.github.com/repos/briansmith/ring/pulls/167","_links":{"self":{"href":"https://api.github.com/repos/briansmith/ring/pulls/comments/60446450"},"html":{"href":"https://github.com/briansmith/ring/pull/167#discussion_r60446450"},"pull_request":{"href":"https://api.github.com/repos/briansmith/ring/pulls/167"}}},"pull_request":{"url":"https://api.github.com/repos/briansmith/ring/pulls/167","id":67082066,"html_url":"https://github.com/briansmith/ring/pull/167","diff_url":"https://github.com/briansmith/ring/pull/167.diff","patch_url":"https://github.com/briansmith/ring/pull/167.patch","issue_url":"https://api.github.com/repos/briansmith/ring/issues/167","number":167,"state":"open","locked":false,"title":"Build kcov on travis and send reports to coveralls.","user":{"login":"pietro","id":238200,"avatar_url":"https://avatars.githubusercontent.com/u/238200?v=3","gravatar_id":"","url":"https://api.github.com/users/pietro","html_url":"https://github.com/pietro","followers_url":"https://api.github.com/users/pietro/followers","following_url":"https://api.github.com/users/pietro/following{/other_user}","gists_url":"https://api.github.com/users/pietro/gists{/gist_id}","starred_url":"https://api.github.com/users/pietro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pietro/subscriptions","organizations_url":"https://api.github.com/users/pietro/orgs","repos_url":"https://api.github.com/users/pietro/repos","events_url":"https://api.github.com/users/pietro/events{/privacy}","received_events_url":"https://api.github.com/users/pietro/received_events","type":"User","site_admin":false},"body":"Only tracking coverage for X86 and X86_64 Linux as discussed on #132.","created_at":"2016-04-19T20:14:58Z","updated_at":"2016-04-20T16:54:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32effcf6a0e1f749b8e5b8023d7070cf646f44b1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/briansmith/ring/pulls/167/commits","review_comments_url":"https://api.github.com/repos/briansmith/ring/pulls/167/comments","review_comment_url":"https://api.github.com/repos/briansmith/ring/pulls/comments{/number}","comments_url":"https://api.github.com/repos/briansmith/ring/issues/167/comments","statuses_url":"https://api.github.com/repos/briansmith/ring/statuses/b204d6a4723a743ec762a1942a6765d11a6dcc89","head":{"label":"pietro:kcov","ref":"kcov","sha":"b204d6a4723a743ec762a1942a6765d11a6dcc89","user":{"login":"pietro","id":238200,"avatar_url":"https://avatars.githubusercontent.com/u/238200?v=3","gravatar_id":"","url":"https://api.github.com/users/pietro","html_url":"https://github.com/pietro","followers_url":"https://api.github.com/users/pietro/followers","following_url":"https://api.github.com/users/pietro/following{/other_user}","gists_url":"https://api.github.com/users/pietro/gists{/gist_id}","starred_url":"https://api.github.com/users/pietro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pietro/subscriptions","organizations_url":"https://api.github.com/users/pietro/orgs","repos_url":"https://api.github.com/users/pietro/repos","events_url":"https://api.github.com/users/pietro/events{/privacy}","received_events_url":"https://api.github.com/users/pietro/received_events","type":"User","site_admin":false},"repo":{"id":55642722,"name":"ring","full_name":"pietro/ring","owner":{"login":"pietro","id":238200,"avatar_url":"https://avatars.githubusercontent.com/u/238200?v=3","gravatar_id":"","url":"https://api.github.com/users/pietro","html_url":"https://github.com/pietro","followers_url":"https://api.github.com/users/pietro/followers","following_url":"https://api.github.com/users/pietro/following{/other_user}","gists_url":"https://api.github.com/users/pietro/gists{/gist_id}","starred_url":"https://api.github.com/users/pietro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pietro/subscriptions","organizations_url":"https://api.github.com/users/pietro/orgs","repos_url":"https://api.github.com/users/pietro/repos","events_url":"https://api.github.com/users/pietro/events{/privacy}","received_events_url":"https://api.github.com/users/pietro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pietro/ring","description":"Safe, fast, small crypto using Rust & BoringSSL's cryptography primitives.","fork":true,"url":"https://api.github.com/repos/pietro/ring","forks_url":"https://api.github.com/repos/pietro/ring/forks","keys_url":"https://api.github.com/repos/pietro/ring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pietro/ring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pietro/ring/teams","hooks_url":"https://api.github.com/repos/pietro/ring/hooks","issue_events_url":"https://api.github.com/repos/pietro/ring/issues/events{/number}","events_url":"https://api.github.com/repos/pietro/ring/events","assignees_url":"https://api.github.com/repos/pietro/ring/assignees{/user}","branches_url":"https://api.github.com/repos/pietro/ring/branches{/branch}","tags_url":"https://api.github.com/repos/pietro/ring/tags","blobs_url":"https://api.github.com/repos/pietro/ring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pietro/ring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pietro/ring/git/refs{/sha}","trees_url":"https://api.github.com/repos/pietro/ring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pietro/ring/statuses/{sha}","languages_url":"https://api.github.com/repos/pietro/ring/languages","stargazers_url":"https://api.github.com/repos/pietro/ring/stargazers","contributors_url":"https://api.github.com/repos/pietro/ring/contributors","subscribers_url":"https://api.github.com/repos/pietro/ring/subscribers","subscription_url":"https://api.github.com/repos/pietro/ring/subscription","commits_url":"https://api.github.com/repos/pietro/ring/commits{/sha}","git_commits_url":"https://api.github.com/repos/pietro/ring/git/commits{/sha}","comments_url":"https://api.github.com/repos/pietro/ring/comments{/number}","issue_comment_url":"https://api.github.com/repos/pietro/ring/issues/comments{/number}","contents_url":"https://api.github.com/repos/pietro/ring/contents/{+path}","compare_url":"https://api.github.com/repos/pietro/ring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pietro/ring/merges","archive_url":"https://api.github.com/repos/pietro/ring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pietro/ring/downloads","issues_url":"https://api.github.com/repos/pietro/ring/issues{/number}","pulls_url":"https://api.github.com/repos/pietro/ring/pulls{/number}","milestones_url":"https://api.github.com/repos/pietro/ring/milestones{/number}","notifications_url":"https://api.github.com/repos/pietro/ring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pietro/ring/labels{/name}","releases_url":"https://api.github.com/repos/pietro/ring/releases{/id}","deployments_url":"https://api.github.com/repos/pietro/ring/deployments","created_at":"2016-04-06T21:45:39Z","updated_at":"2016-04-06T21:45:41Z","pushed_at":"2016-04-20T01:40:34Z","git_url":"git://github.com/pietro/ring.git","ssh_url":"git@github.com:pietro/ring.git","clone_url":"https://github.com/pietro/ring.git","svn_url":"https://github.com/pietro/ring","homepage":"https://briansmith.org/rustdoc/ring/","size":19141,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"briansmith:master","ref":"master","sha":"14d1666eee9253a7ab2b98eda3305303f9748205","user":{"login":"briansmith","id":16816,"avatar_url":"https://avatars.githubusercontent.com/u/16816?v=3","gravatar_id":"","url":"https://api.github.com/users/briansmith","html_url":"https://github.com/briansmith","followers_url":"https://api.github.com/users/briansmith/followers","following_url":"https://api.github.com/users/briansmith/following{/other_user}","gists_url":"https://api.github.com/users/briansmith/gists{/gist_id}","starred_url":"https://api.github.com/users/briansmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansmith/subscriptions","organizations_url":"https://api.github.com/users/briansmith/orgs","repos_url":"https://api.github.com/users/briansmith/repos","events_url":"https://api.github.com/users/briansmith/events{/privacy}","received_events_url":"https://api.github.com/users/briansmith/received_events","type":"User","site_admin":false},"repo":{"id":39527318,"name":"ring","full_name":"briansmith/ring","owner":{"login":"briansmith","id":16816,"avatar_url":"https://avatars.githubusercontent.com/u/16816?v=3","gravatar_id":"","url":"https://api.github.com/users/briansmith","html_url":"https://github.com/briansmith","followers_url":"https://api.github.com/users/briansmith/followers","following_url":"https://api.github.com/users/briansmith/following{/other_user}","gists_url":"https://api.github.com/users/briansmith/gists{/gist_id}","starred_url":"https://api.github.com/users/briansmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansmith/subscriptions","organizations_url":"https://api.github.com/users/briansmith/orgs","repos_url":"https://api.github.com/users/briansmith/repos","events_url":"https://api.github.com/users/briansmith/events{/privacy}","received_events_url":"https://api.github.com/users/briansmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/briansmith/ring","description":"Safe, fast, small crypto using Rust & BoringSSL's cryptography primitives.","fork":false,"url":"https://api.github.com/repos/briansmith/ring","forks_url":"https://api.github.com/repos/briansmith/ring/forks","keys_url":"https://api.github.com/repos/briansmith/ring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/briansmith/ring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/briansmith/ring/teams","hooks_url":"https://api.github.com/repos/briansmith/ring/hooks","issue_events_url":"https://api.github.com/repos/briansmith/ring/issues/events{/number}","events_url":"https://api.github.com/repos/briansmith/ring/events","assignees_url":"https://api.github.com/repos/briansmith/ring/assignees{/user}","branches_url":"https://api.github.com/repos/briansmith/ring/branches{/branch}","tags_url":"https://api.github.com/repos/briansmith/ring/tags","blobs_url":"https://api.github.com/repos/briansmith/ring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/briansmith/ring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/briansmith/ring/git/refs{/sha}","trees_url":"https://api.github.com/repos/briansmith/ring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/briansmith/ring/statuses/{sha}","languages_url":"https://api.github.com/repos/briansmith/ring/languages","stargazers_url":"https://api.github.com/repos/briansmith/ring/stargazers","contributors_url":"https://api.github.com/repos/briansmith/ring/contributors","subscribers_url":"https://api.github.com/repos/briansmith/ring/subscribers","subscription_url":"https://api.github.com/repos/briansmith/ring/subscription","commits_url":"https://api.github.com/repos/briansmith/ring/commits{/sha}","git_commits_url":"https://api.github.com/repos/briansmith/ring/git/commits{/sha}","comments_url":"https://api.github.com/repos/briansmith/ring/comments{/number}","issue_comment_url":"https://api.github.com/repos/briansmith/ring/issues/comments{/number}","contents_url":"https://api.github.com/repos/briansmith/ring/contents/{+path}","compare_url":"https://api.github.com/repos/briansmith/ring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/briansmith/ring/merges","archive_url":"https://api.github.com/repos/briansmith/ring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/briansmith/ring/downloads","issues_url":"https://api.github.com/repos/briansmith/ring/issues{/number}","pulls_url":"https://api.github.com/repos/briansmith/ring/pulls{/number}","milestones_url":"https://api.github.com/repos/briansmith/ring/milestones{/number}","notifications_url":"https://api.github.com/repos/briansmith/ring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/briansmith/ring/labels{/name}","releases_url":"https://api.github.com/repos/briansmith/ring/releases{/id}","deployments_url":"https://api.github.com/repos/briansmith/ring/deployments","created_at":"2015-07-22T19:57:40Z","updated_at":"2016-04-14T23:49:34Z","pushed_at":"2016-04-19T20:14:58Z","git_url":"git://github.com/briansmith/ring.git","ssh_url":"git@github.com:briansmith/ring.git","clone_url":"https://github.com/briansmith/ring.git","svn_url":"https://github.com/briansmith/ring","homepage":"https://briansmith.org/rustdoc/ring/","size":19269,"stargazers_count":129,"watchers_count":129,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":101,"forks":11,"open_issues":101,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/briansmith/ring/pulls/167"},"html":{"href":"https://github.com/briansmith/ring/pull/167"},"issue":{"href":"https://api.github.com/repos/briansmith/ring/issues/167"},"comments":{"href":"https://api.github.com/repos/briansmith/ring/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/briansmith/ring/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/briansmith/ring/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/briansmith/ring/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/briansmith/ring/statuses/b204d6a4723a743ec762a1942a6765d11a6dcc89"}}}}