{"action":"created","comment":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/60856494","id":60856494,"diff_hunk":"@@ -0,0 +1,174 @@\n+// Copyright (c) 2015 Intel Corporation. All rights reserved.","path":"runtime/browser/xwalk_presentation_service_delegate.cc","position":1,"original_position":1,"commit_id":"be9c18c5e065e709f8be595c787bbf5f79a703f5","original_commit_id":"be9c18c5e065e709f8be595c787bbf5f79a703f5","user":{"login":"halton","id":433218,"avatar_url":"https://avatars.githubusercontent.com/u/433218?v=3","gravatar_id":"","url":"https://api.github.com/users/halton","html_url":"https://github.com/halton","followers_url":"https://api.github.com/users/halton/followers","following_url":"https://api.github.com/users/halton/following{/other_user}","gists_url":"https://api.github.com/users/halton/gists{/gist_id}","starred_url":"https://api.github.com/users/halton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halton/subscriptions","organizations_url":"https://api.github.com/users/halton/orgs","repos_url":"https://api.github.com/users/halton/repos","events_url":"https://api.github.com/users/halton/events{/privacy}","received_events_url":"https://api.github.com/users/halton/received_events","type":"User","site_admin":false},"body":"nit, 2016","created_at":"2016-04-25T01:34:57Z","updated_at":"2016-04-25T01:34:57Z","html_url":"https://github.com/crosswalk-project/crosswalk/pull/3666#discussion_r60856494","pull_request_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3666","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/60856494"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/3666#discussion_r60856494"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3666"}}},"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3666","id":67331899,"html_url":"https://github.com/crosswalk-project/crosswalk/pull/3666","diff_url":"https://github.com/crosswalk-project/crosswalk/pull/3666.diff","patch_url":"https://github.com/crosswalk-project/crosswalk/pull/3666.patch","issue_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3666","number":3666,"state":"open","locked":false,"title":"[XWALK-6262] Refactor to remove duplicated code after Presentation AP…","user":{"login":"kenny-y","id":3302320,"avatar_url":"https://avatars.githubusercontent.com/u/3302320?v=3","gravatar_id":"","url":"https://api.github.com/users/kenny-y","html_url":"https://github.com/kenny-y","followers_url":"https://api.github.com/users/kenny-y/followers","following_url":"https://api.github.com/users/kenny-y/following{/other_user}","gists_url":"https://api.github.com/users/kenny-y/gists{/gist_id}","starred_url":"https://api.github.com/users/kenny-y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenny-y/subscriptions","organizations_url":"https://api.github.com/users/kenny-y/orgs","repos_url":"https://api.github.com/users/kenny-y/repos","events_url":"https://api.github.com/users/kenny-y/events{/privacy}","received_events_url":"https://api.github.com/users/kenny-y/received_events","type":"User","site_admin":false},"body":"Refactor to remove duplicated code after Presentation API is re-implemented on Android\r\n\r\nThis is a leftover task of XWALK-4646.\r\n\r\nPrior to XWALK-4646, there was the impl. of W3C presentation API for Windows platform. It was Windows only impl at that time.\r\n\r\nAfter some experiment, there was a common subset identified in source code between Android & Windows platform impl., but considering the fact that XWALK-4646 was in high priority (P1 blocker) at that time, and I was unable to obtain a Windows box to test the modified behavior on Windows, I made a decision to copy the common code and modify part of it to Android-specific source code.\r\n\r\nAfter XWALK-4646 is resolved, this XWALK-6262 was opened to track the leftover task, which is to share the common code between Windows & Android platform.\r\n\r\nThis task was delayed due to Chromium 49 rebase (change of content interface that we're relying on and behavior slightly), and also delayed a couple of weeks due to my IDF'16 trip.\r\n\r\nNow this task is finally done.\r\n\r\nNOTE: Github reported a conflict of auto-merge in my previous PR attempt. So I verified the success of auto-merge in my just-forked master branch and here I'm sending PR again.","created_at":"2016-04-21T10:35:53Z","updated_at":"2016-04-25T01:34:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5926971ff12bb990bb6e87105f20a63bd94f54d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3666/commits","review_comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3666/comments","review_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3666/comments","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/be9c18c5e065e709f8be595c787bbf5f79a703f5","head":{"label":"kenny-y:presentation-refactoring-with-inherence","ref":"presentation-refactoring-with-inherence","sha":"be9c18c5e065e709f8be595c787bbf5f79a703f5","user":{"login":"kenny-y","id":3302320,"avatar_url":"https://avatars.githubusercontent.com/u/3302320?v=3","gravatar_id":"","url":"https://api.github.com/users/kenny-y","html_url":"https://github.com/kenny-y","followers_url":"https://api.github.com/users/kenny-y/followers","following_url":"https://api.github.com/users/kenny-y/following{/other_user}","gists_url":"https://api.github.com/users/kenny-y/gists{/gist_id}","starred_url":"https://api.github.com/users/kenny-y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenny-y/subscriptions","organizations_url":"https://api.github.com/users/kenny-y/orgs","repos_url":"https://api.github.com/users/kenny-y/repos","events_url":"https://api.github.com/users/kenny-y/events{/privacy}","received_events_url":"https://api.github.com/users/kenny-y/received_events","type":"User","site_admin":false},"repo":{"id":56764782,"name":"crosswalk","full_name":"kenny-y/crosswalk","owner":{"login":"kenny-y","id":3302320,"avatar_url":"https://avatars.githubusercontent.com/u/3302320?v=3","gravatar_id":"","url":"https://api.github.com/users/kenny-y","html_url":"https://github.com/kenny-y","followers_url":"https://api.github.com/users/kenny-y/followers","following_url":"https://api.github.com/users/kenny-y/following{/other_user}","gists_url":"https://api.github.com/users/kenny-y/gists{/gist_id}","starred_url":"https://api.github.com/users/kenny-y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenny-y/subscriptions","organizations_url":"https://api.github.com/users/kenny-y/orgs","repos_url":"https://api.github.com/users/kenny-y/repos","events_url":"https://api.github.com/users/kenny-y/events{/privacy}","received_events_url":"https://api.github.com/users/kenny-y/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kenny-y/crosswalk","description":"","fork":true,"url":"https://api.github.com/repos/kenny-y/crosswalk","forks_url":"https://api.github.com/repos/kenny-y/crosswalk/forks","keys_url":"https://api.github.com/repos/kenny-y/crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kenny-y/crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kenny-y/crosswalk/teams","hooks_url":"https://api.github.com/repos/kenny-y/crosswalk/hooks","issue_events_url":"https://api.github.com/repos/kenny-y/crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/kenny-y/crosswalk/events","assignees_url":"https://api.github.com/repos/kenny-y/crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/kenny-y/crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/kenny-y/crosswalk/tags","blobs_url":"https://api.github.com/repos/kenny-y/crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kenny-y/crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kenny-y/crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/kenny-y/crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kenny-y/crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/kenny-y/crosswalk/languages","stargazers_url":"https://api.github.com/repos/kenny-y/crosswalk/stargazers","contributors_url":"https://api.github.com/repos/kenny-y/crosswalk/contributors","subscribers_url":"https://api.github.com/repos/kenny-y/crosswalk/subscribers","subscription_url":"https://api.github.com/repos/kenny-y/crosswalk/subscription","commits_url":"https://api.github.com/repos/kenny-y/crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/kenny-y/crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/kenny-y/crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/kenny-y/crosswalk/issues/comments{/number}","contents_url":"https://api.github.com/repos/kenny-y/crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/kenny-y/crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kenny-y/crosswalk/merges","archive_url":"https://api.github.com/repos/kenny-y/crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kenny-y/crosswalk/downloads","issues_url":"https://api.github.com/repos/kenny-y/crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/kenny-y/crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/kenny-y/crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/kenny-y/crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kenny-y/crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/kenny-y/crosswalk/releases{/id}","deployments_url":"https://api.github.com/repos/kenny-y/crosswalk/deployments","created_at":"2016-04-21T10:27:57Z","updated_at":"2016-04-21T10:28:00Z","pushed_at":"2016-04-22T14:47:16Z","git_url":"git://github.com/kenny-y/crosswalk.git","ssh_url":"git@github.com:kenny-y/crosswalk.git","clone_url":"https://github.com/kenny-y/crosswalk.git","svn_url":"https://github.com/kenny-y/crosswalk","homepage":"https://crosswalk-project.org/","size":16395,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crosswalk-project:master","ref":"master","sha":"3335c674d9876f030add7bd2742dc30b717b371a","user":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"repo":{"id":9207280,"name":"crosswalk","full_name":"crosswalk-project/crosswalk","owner":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crosswalk-project/crosswalk","description":"","fork":false,"url":"https://api.github.com/repos/crosswalk-project/crosswalk","forks_url":"https://api.github.com/repos/crosswalk-project/crosswalk/forks","keys_url":"https://api.github.com/repos/crosswalk-project/crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crosswalk-project/crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crosswalk-project/crosswalk/teams","hooks_url":"https://api.github.com/repos/crosswalk-project/crosswalk/hooks","issue_events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/events","assignees_url":"https://api.github.com/repos/crosswalk-project/crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/crosswalk-project/crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk/tags","blobs_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/crosswalk-project/crosswalk/languages","stargazers_url":"https://api.github.com/repos/crosswalk-project/crosswalk/stargazers","contributors_url":"https://api.github.com/repos/crosswalk-project/crosswalk/contributors","subscribers_url":"https://api.github.com/repos/crosswalk-project/crosswalk/subscribers","subscription_url":"https://api.github.com/repos/crosswalk-project/crosswalk/subscription","commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/comments{/number}","contents_url":"https://api.github.com/repos/crosswalk-project/crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/crosswalk-project/crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crosswalk-project/crosswalk/merges","archive_url":"https://api.github.com/repos/crosswalk-project/crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crosswalk-project/crosswalk/downloads","issues_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/crosswalk-project/crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/crosswalk-project/crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crosswalk-project/crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/crosswalk-project/crosswalk/releases{/id}","deployments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/deployments","created_at":"2013-04-03T23:30:12Z","updated_at":"2016-04-24T17:47:15Z","pushed_at":"2016-04-23T01:29:33Z","git_url":"git://github.com/crosswalk-project/crosswalk.git","ssh_url":"git@github.com:crosswalk-project/crosswalk.git","clone_url":"https://github.com/crosswalk-project/crosswalk.git","svn_url":"https://github.com/crosswalk-project/crosswalk","homepage":"https://crosswalk-project.org/","size":124472,"stargazers_count":1364,"watchers_count":1364,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":360,"mirror_url":null,"open_issues_count":103,"forks":360,"open_issues":103,"watchers":1364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3666"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/3666"},"issue":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3666"},"comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/3666/comments"},"review_comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3666/comments"},"review_comment":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/3666/commits"},"statuses":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/be9c18c5e065e709f8be595c787bbf5f79a703f5"}}}}