{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/92488615","pull_request_review_id":13005331,"id":92488615,"diff_hunk":"@@ -294,11 +306,13 @@ public synchronized void start() {\n         log.debug(\"Starting Kafka Stream process\");\n \n         if (state == KafkaStreams.State.CREATED) {\n-            for (final StreamThread thread : threads)\n-                thread.start();\n-\n             setState(KafkaStreams.State.RUNNING);\n \n+            for (final StreamThread thread : threads) {","path":"streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java","position":64,"original_position":56,"commit_id":"7a1a36aca1b140c6b14e9dff5f28105cae47b399","original_commit_id":"67afcf855af702b4aedafc8f403b7ac5cb82e080","user":{"login":"enothereska","id":14234336,"avatar_url":"https://avatars.githubusercontent.com/u/14234336?v=3","gravatar_id":"","url":"https://api.github.com/users/enothereska","html_url":"https://github.com/enothereska","followers_url":"https://api.github.com/users/enothereska/followers","following_url":"https://api.github.com/users/enothereska/following{/other_user}","gists_url":"https://api.github.com/users/enothereska/gists{/gist_id}","starred_url":"https://api.github.com/users/enothereska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enothereska/subscriptions","organizations_url":"https://api.github.com/users/enothereska/orgs","repos_url":"https://api.github.com/users/enothereska/repos","events_url":"https://api.github.com/users/enothereska/events{/privacy}","received_events_url":"https://api.github.com/users/enothereska/received_events","type":"User","site_admin":false},"body":"@mjsax we'll have to disagree on this one.","created_at":"2016-12-14T21:04:52Z","updated_at":"2016-12-14T21:04:52Z","html_url":"https://github.com/apache/kafka/pull/2252#discussion_r92488615","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/2252","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/92488615"},"html":{"href":"https://github.com/apache/kafka/pull/2252#discussion_r92488615"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/2252"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/2252","id":97833036,"html_url":"https://github.com/apache/kafka/pull/2252","diff_url":"https://github.com/apache/kafka/pull/2252.diff","patch_url":"https://github.com/apache/kafka/pull/2252.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/2252","number":2252,"state":"open","locked":false,"title":"HOTFIX: fix state transition stuck on rebalance","user":{"login":"enothereska","id":14234336,"avatar_url":"https://avatars.githubusercontent.com/u/14234336?v=3","gravatar_id":"","url":"https://api.github.com/users/enothereska","html_url":"https://github.com/enothereska","followers_url":"https://api.github.com/users/enothereska/followers","following_url":"https://api.github.com/users/enothereska/following{/other_user}","gists_url":"https://api.github.com/users/enothereska/gists{/gist_id}","starred_url":"https://api.github.com/users/enothereska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enothereska/subscriptions","organizations_url":"https://api.github.com/users/enothereska/orgs","repos_url":"https://api.github.com/users/enothereska/repos","events_url":"https://api.github.com/users/enothereska/events{/privacy}","received_events_url":"https://api.github.com/users/enothereska/received_events","type":"User","site_admin":false},"body":"This fixes a problem where the Kafka instance state transition gets stuck on rebalance (Thanks to @dguy for pointing out). Also adjusts the test in QueryableStateIntegration test.","created_at":"2016-12-13T20:52:27Z","updated_at":"2016-12-14T21:04:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6212075a9259bf41d23609aad85f6e56b86b15d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/2252/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/2252/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/2252/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/7a1a36aca1b140c6b14e9dff5f28105cae47b399","head":{"label":"enothereska:hotfix_state_never_running","ref":"hotfix_state_never_running","sha":"7a1a36aca1b140c6b14e9dff5f28105cae47b399","user":{"login":"enothereska","id":14234336,"avatar_url":"https://avatars.githubusercontent.com/u/14234336?v=3","gravatar_id":"","url":"https://api.github.com/users/enothereska","html_url":"https://github.com/enothereska","followers_url":"https://api.github.com/users/enothereska/followers","following_url":"https://api.github.com/users/enothereska/following{/other_user}","gists_url":"https://api.github.com/users/enothereska/gists{/gist_id}","starred_url":"https://api.github.com/users/enothereska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enothereska/subscriptions","organizations_url":"https://api.github.com/users/enothereska/orgs","repos_url":"https://api.github.com/users/enothereska/repos","events_url":"https://api.github.com/users/enothereska/events{/privacy}","received_events_url":"https://api.github.com/users/enothereska/received_events","type":"User","site_admin":false},"repo":{"id":44994140,"name":"kafka","full_name":"enothereska/kafka","owner":{"login":"enothereska","id":14234336,"avatar_url":"https://avatars.githubusercontent.com/u/14234336?v=3","gravatar_id":"","url":"https://api.github.com/users/enothereska","html_url":"https://github.com/enothereska","followers_url":"https://api.github.com/users/enothereska/followers","following_url":"https://api.github.com/users/enothereska/following{/other_user}","gists_url":"https://api.github.com/users/enothereska/gists{/gist_id}","starred_url":"https://api.github.com/users/enothereska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enothereska/subscriptions","organizations_url":"https://api.github.com/users/enothereska/orgs","repos_url":"https://api.github.com/users/enothereska/repos","events_url":"https://api.github.com/users/enothereska/events{/privacy}","received_events_url":"https://api.github.com/users/enothereska/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/enothereska/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/enothereska/kafka","forks_url":"https://api.github.com/repos/enothereska/kafka/forks","keys_url":"https://api.github.com/repos/enothereska/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enothereska/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enothereska/kafka/teams","hooks_url":"https://api.github.com/repos/enothereska/kafka/hooks","issue_events_url":"https://api.github.com/repos/enothereska/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/enothereska/kafka/events","assignees_url":"https://api.github.com/repos/enothereska/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/enothereska/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/enothereska/kafka/tags","blobs_url":"https://api.github.com/repos/enothereska/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enothereska/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enothereska/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/enothereska/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enothereska/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/enothereska/kafka/languages","stargazers_url":"https://api.github.com/repos/enothereska/kafka/stargazers","contributors_url":"https://api.github.com/repos/enothereska/kafka/contributors","subscribers_url":"https://api.github.com/repos/enothereska/kafka/subscribers","subscription_url":"https://api.github.com/repos/enothereska/kafka/subscription","commits_url":"https://api.github.com/repos/enothereska/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/enothereska/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/enothereska/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/enothereska/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/enothereska/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/enothereska/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enothereska/kafka/merges","archive_url":"https://api.github.com/repos/enothereska/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enothereska/kafka/downloads","issues_url":"https://api.github.com/repos/enothereska/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/enothereska/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/enothereska/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/enothereska/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enothereska/kafka/labels{/name}","releases_url":"https://api.github.com/repos/enothereska/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/enothereska/kafka/deployments","created_at":"2015-10-26T20:08:13Z","updated_at":"2016-01-28T16:05:20Z","pushed_at":"2016-12-14T21:03:54Z","git_url":"git://github.com/enothereska/kafka.git","ssh_url":"git@github.com:enothereska/kafka.git","clone_url":"https://github.com/enothereska/kafka.git","svn_url":"https://github.com/enothereska/kafka","homepage":null,"size":36859,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"53428694a624a1956cb8fa3a6a674638f9b09816","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-12-14T14:31:29Z","pushed_at":"2016-12-14T21:01:57Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":37637,"stargazers_count":4273,"watchers_count":4273,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2665,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":307,"forks":2665,"open_issues":307,"watchers":4273,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/2252"},"html":{"href":"https://github.com/apache/kafka/pull/2252"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/2252"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/2252/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/2252/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/2252/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/7a1a36aca1b140c6b14e9dff5f28105cae47b399"}}}}
{"actor":{"display_login":"enothereska"}}