{"action":"created","comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/69546283","id":69546283,"diff_hunk":"@@ -0,0 +1,107 @@\n+/*\n+ * Copyright (c) 2016, Ford Motor Company\n+ * All rights reserved.\n+ *\n+ * Redistribution and use in source and binary forms, with or without\n+ * modification, are permitted provided that the following conditions are met:\n+ *\n+ * Redistributions of source code must retain the above copyright notice, this\n+ * list of conditions and the following disclaimer.\n+ *\n+ * Redistributions in binary form must reproduce the above copyright notice,\n+ * this list of conditions and the following\n+ * disclaimer in the documentation and/or other materials provided with the\n+ * distribution.\n+ *\n+ * Neither the name of the Ford Motor Company nor the names of its contributors\n+ * may be used to endorse or promote products derived from this software\n+ * without specific prior written permission.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE\n+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR\n+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF\n+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS\n+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN\n+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)\n+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE\n+ * POSSIBILITY OF SUCH DAMAGE.\n+ */\n+\n+#include \"gtest/gtest.h\"\n+#include \"utils/shared_ptr.h\"\n+#include \"smart_objects/smart_object.h\"\n+#include \"application_manager/smart_object_keys.h\"\n+#include \"application_manager/commands/commands_test.h\"\n+#include \"application_manager/commands/command.h\"\n+#include \"hmi/request_to_hmi.h\"\n+#include \"hmi/vi_get_vehicle_type_request.h\"\n+#include \"hmi/vi_is_ready_request.h\"\n+#include \"hmi/vi_read_did_request.h\"\n+#include \"hmi/vi_subscribe_vehicle_data_request.h\"\n+\n+namespace test {\n+namespace components {\n+namespace commands_test {\n+namespace hmi_commands_test {\n+\n+using ::testing::_;\n+using ::testing::Types;\n+using ::testing::NotNull;\n+\n+using ::utils::SharedPtr;\n+\n+namespace commands = ::application_manager::commands;\n+using commands::MessageSharedPtr;\n+\n+class RequestToHMITest : public CommandsTest<CommandsTestMocks::kIsNice> {};\n+\n+TEST_F(RequestToHMITest, BasicMethodsOverloads_SUCCESS) {\n+  SharedPtr<commands::RequestToHMI> command(\n+      CreateCommand<commands::RequestToHMI>());\n+\n+  // Current implementation always return `true`\n+  EXPECT_TRUE(command->CleanUp());\n+  EXPECT_TRUE(command->Init());\n+  EXPECT_NO_THROW(command->Run());","path":"src/components/application_manager/test/commands/hmi/simple_requests_to_hmi_test.cc","position":null,"original_position":68,"commit_id":"8907a0dee981f9ec7230ef49428ea3ed7e3371ce","original_commit_id":"18c2f3b33b854179b961871ab92987f4ad1b0c68","user":{"login":"LevchenkoS","id":18613689,"avatar_url":"https://avatars.githubusercontent.com/u/18613689?v=3","gravatar_id":"","url":"https://api.github.com/users/LevchenkoS","html_url":"https://github.com/LevchenkoS","followers_url":"https://api.github.com/users/LevchenkoS/followers","following_url":"https://api.github.com/users/LevchenkoS/following{/other_user}","gists_url":"https://api.github.com/users/LevchenkoS/gists{/gist_id}","starred_url":"https://api.github.com/users/LevchenkoS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LevchenkoS/subscriptions","organizations_url":"https://api.github.com/users/LevchenkoS/orgs","repos_url":"https://api.github.com/users/LevchenkoS/repos","events_url":"https://api.github.com/users/LevchenkoS/events{/privacy}","received_events_url":"https://api.github.com/users/LevchenkoS/received_events","type":"User","site_admin":false},"body":"@vlantonov, fixed in 8907a0d.","created_at":"2016-07-05T11:19:35Z","updated_at":"2016-07-05T11:19:35Z","html_url":"https://github.com/smartdevicelink/sdl_core/pull/671#discussion_r69546283","pull_request_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/671","_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/69546283"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/671#discussion_r69546283"},"pull_request":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/671"}}},"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/671","id":76244880,"html_url":"https://github.com/smartdevicelink/sdl_core/pull/671","diff_url":"https://github.com/smartdevicelink/sdl_core/pull/671.diff","patch_url":"https://github.com/smartdevicelink/sdl_core/pull/671.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/671","number":671,"state":"open","locked":false,"title":"Cover HMI commands with Unit Tests. Part 14","user":{"login":"LevchenkoS","id":18613689,"avatar_url":"https://avatars.githubusercontent.com/u/18613689?v=3","gravatar_id":"","url":"https://api.github.com/users/LevchenkoS","html_url":"https://github.com/LevchenkoS","followers_url":"https://api.github.com/users/LevchenkoS/followers","following_url":"https://api.github.com/users/LevchenkoS/following{/other_user}","gists_url":"https://api.github.com/users/LevchenkoS/gists{/gist_id}","starred_url":"https://api.github.com/users/LevchenkoS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LevchenkoS/subscriptions","organizations_url":"https://api.github.com/users/LevchenkoS/orgs","repos_url":"https://api.github.com/users/LevchenkoS/repos","events_url":"https://api.github.com/users/LevchenkoS/events{/privacy}","received_events_url":"https://api.github.com/users/LevchenkoS/received_events","type":"User","site_admin":false},"body":"Has been covered:\r\n- `RequestToHMI`;\r\n- `ResponseFromHMI`;\r\n- `VIIsReadDIDRequest`;\r\n- `VIReadDIDResponse`;\r\n- `VIIsReadyRequest`;\r\n- `VIIsReadyResponse`;\r\n- `VIGetVehicleTypeRequest`;\r\n- `VIGetVehicleTypeResponse`;\r\n- `VISubscribeVehicleDataRequest`;\r\n- `VISubscribeVehicleDataResponse`.\r\n\r\nRelated to: [APPLINK-25908](https://adc.luxoft.com/jira/browse/APPLINK-25908)\r\n\r\n@AByzhynar, @okozlovlux, @Kozoriz, @LuxoftAKutsan, @vlantonov, @wolfylambova22, please review.","created_at":"2016-07-05T09:43:02Z","updated_at":"2016-07-05T11:19:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bca050b8601e7a7a1a7674a12369590420f1f2eb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/671/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/671/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/671/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/8907a0dee981f9ec7230ef49428ea3ed7e3371ce","head":{"label":"LevchenkoS:feature/Cover_HMI_commands_with_Unit_Tests_Part_14","ref":"feature/Cover_HMI_commands_with_Unit_Tests_Part_14","sha":"8907a0dee981f9ec7230ef49428ea3ed7e3371ce","user":{"login":"LevchenkoS","id":18613689,"avatar_url":"https://avatars.githubusercontent.com/u/18613689?v=3","gravatar_id":"","url":"https://api.github.com/users/LevchenkoS","html_url":"https://github.com/LevchenkoS","followers_url":"https://api.github.com/users/LevchenkoS/followers","following_url":"https://api.github.com/users/LevchenkoS/following{/other_user}","gists_url":"https://api.github.com/users/LevchenkoS/gists{/gist_id}","starred_url":"https://api.github.com/users/LevchenkoS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LevchenkoS/subscriptions","organizations_url":"https://api.github.com/users/LevchenkoS/orgs","repos_url":"https://api.github.com/users/LevchenkoS/repos","events_url":"https://api.github.com/users/LevchenkoS/events{/privacy}","received_events_url":"https://api.github.com/users/LevchenkoS/received_events","type":"User","site_admin":false},"repo":{"id":60253278,"name":"sdl_core","full_name":"LevchenkoS/sdl_core","owner":{"login":"LevchenkoS","id":18613689,"avatar_url":"https://avatars.githubusercontent.com/u/18613689?v=3","gravatar_id":"","url":"https://api.github.com/users/LevchenkoS","html_url":"https://github.com/LevchenkoS","followers_url":"https://api.github.com/users/LevchenkoS/followers","following_url":"https://api.github.com/users/LevchenkoS/following{/other_user}","gists_url":"https://api.github.com/users/LevchenkoS/gists{/gist_id}","starred_url":"https://api.github.com/users/LevchenkoS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LevchenkoS/subscriptions","organizations_url":"https://api.github.com/users/LevchenkoS/orgs","repos_url":"https://api.github.com/users/LevchenkoS/repos","events_url":"https://api.github.com/users/LevchenkoS/events{/privacy}","received_events_url":"https://api.github.com/users/LevchenkoS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LevchenkoS/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":true,"url":"https://api.github.com/repos/LevchenkoS/sdl_core","forks_url":"https://api.github.com/repos/LevchenkoS/sdl_core/forks","keys_url":"https://api.github.com/repos/LevchenkoS/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LevchenkoS/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LevchenkoS/sdl_core/teams","hooks_url":"https://api.github.com/repos/LevchenkoS/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/LevchenkoS/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/LevchenkoS/sdl_core/events","assignees_url":"https://api.github.com/repos/LevchenkoS/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/LevchenkoS/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/LevchenkoS/sdl_core/tags","blobs_url":"https://api.github.com/repos/LevchenkoS/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LevchenkoS/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LevchenkoS/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/LevchenkoS/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LevchenkoS/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/LevchenkoS/sdl_core/languages","stargazers_url":"https://api.github.com/repos/LevchenkoS/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/LevchenkoS/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/LevchenkoS/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/LevchenkoS/sdl_core/subscription","commits_url":"https://api.github.com/repos/LevchenkoS/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/LevchenkoS/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/LevchenkoS/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/LevchenkoS/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/LevchenkoS/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/LevchenkoS/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LevchenkoS/sdl_core/merges","archive_url":"https://api.github.com/repos/LevchenkoS/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LevchenkoS/sdl_core/downloads","issues_url":"https://api.github.com/repos/LevchenkoS/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/LevchenkoS/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/LevchenkoS/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/LevchenkoS/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LevchenkoS/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/LevchenkoS/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/LevchenkoS/sdl_core/deployments","created_at":"2016-06-02T10:01:36Z","updated_at":"2016-06-02T10:01:45Z","pushed_at":"2016-07-05T11:18:33Z","git_url":"git://github.com/LevchenkoS/sdl_core.git","ssh_url":"git@github.com:LevchenkoS/sdl_core.git","clone_url":"https://github.com/LevchenkoS/sdl_core.git","svn_url":"https://github.com/LevchenkoS/sdl_core","homepage":"","size":174776,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smartdevicelink:develop","ref":"develop","sha":"2887ceddd3d4342d7431e26727e72b8d20559708","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24724170,"name":"sdl_core","full_name":"smartdevicelink/sdl_core","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_core","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_core/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_core/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_core/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_core/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/deployments","created_at":"2014-10-02T15:16:26Z","updated_at":"2016-07-05T06:33:45Z","pushed_at":"2016-07-05T11:18:34Z","git_url":"git://github.com/smartdevicelink/sdl_core.git","ssh_url":"git@github.com:smartdevicelink/sdl_core.git","clone_url":"https://github.com/smartdevicelink/sdl_core.git","svn_url":"https://github.com/smartdevicelink/sdl_core","homepage":"","size":308756,"stargazers_count":73,"watchers_count":73,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"open_issues_count":93,"forks":81,"open_issues":93,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/671"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/671"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/671"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/671/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/671/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/671/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/8907a0dee981f9ec7230ef49428ea3ed7e3371ce"}}}}
{"actor":{"display_login":"LevchenkoS"}}