{"action":"closed","issue":{"url":"https://api.github.com/repos/Homebrew/brew/issues/226","repository_url":"https://api.github.com/repos/Homebrew/brew","labels_url":"https://api.github.com/repos/Homebrew/brew/issues/226/labels{/name}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/226/comments","events_url":"https://api.github.com/repos/Homebrew/brew/issues/226/events","html_url":"https://github.com/Homebrew/brew/issues/226","id":153797464,"number":226,"title":"Setting JAVA_HOME to the default Java changes functionality of Maven","user":{"login":"datalogics-kam","id":89971,"avatar_url":"https://avatars.githubusercontent.com/u/89971?v=3","gravatar_id":"","url":"https://api.github.com/users/datalogics-kam","html_url":"https://github.com/datalogics-kam","followers_url":"https://api.github.com/users/datalogics-kam/followers","following_url":"https://api.github.com/users/datalogics-kam/following{/other_user}","gists_url":"https://api.github.com/users/datalogics-kam/gists{/gist_id}","starred_url":"https://api.github.com/users/datalogics-kam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datalogics-kam/subscriptions","organizations_url":"https://api.github.com/users/datalogics-kam/orgs","repos_url":"https://api.github.com/users/datalogics-kam/repos","events_url":"https://api.github.com/users/datalogics-kam/events{/privacy}","received_events_url":"https://api.github.com/users/datalogics-kam/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-05-09T15:02:56Z","updated_at":"2016-05-24T14:28:27Z","closed_at":"2016-05-24T14:28:27Z","body":"### Bug reports:\r\n\r\nSomething for your consideration/discussion:\r\n\r\n``JAVA_HOME`` being unset is a useful state. The Homebrew glue script for Maven says:\r\n\r\n```bash\r\n#!/bin/bash\r\nJAVA_HOME=\"${JAVA_HOME:-$(/usr/libexec/java_home)}\" exec \"/usr/local/Cellar/maven/3.3.9/libexec/bin/mvn\" \"$@\"\r\n```\r\n\r\nThis removes two layers of functionality:\r\n\r\n- The ``mvn`` shell script already has code to figure out where Java is, including Darwin-specific code. But first it runs ``/etc/mavenrc`` and ``~/.mavenrc``\r\n- My ``~/.mavenrc`` doesn't work the way it used to: I have mine set up to say something like \"If this shell doesn't have ``JAVA_HOME`` set, and I'm on a Mac, use 1.7\"\r\n\r\nI know there's probably a _reason_ why Homebrew sets ``JAVA_HOME`` to the default, even if I don't understand it. It kind of confuses me, because if JAVA_HOME isn't set, then won't Java-based commands just use the default anyway?\r\n\r\nAt least for Maven, it seems redundant to put that in there. It also means that Maven-in-Homebrew doesn't function like just downloading Maven from Apache and putting it into the path, or like Maven does when I use the same dotfiles on, say, Linux.\r\n\r\nI can work around it, so this isn't urgent or anything. But it does explain a mystery for me.\r\n\r\n> We will consider your request but it may be closed if it's something we're not actively planning to work on.\r\n\r\nAs I said, I seek understanding, and this is only feedback. If it's really important that it work this way, I'll work around it.\r\n\r\nThanks for Homebrew; it's been quite useful to me."}}
{"actor":{"display_login":"UniqMartin"}}