{"action":"created","issue":{"url":"https://api.github.com/repos/chmorgan/packetnet/issues/13","repository_url":"https://api.github.com/repos/chmorgan/packetnet","labels_url":"https://api.github.com/repos/chmorgan/packetnet/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/chmorgan/packetnet/issues/13/comments","events_url":"https://api.github.com/repos/chmorgan/packetnet/issues/13/events","html_url":"https://github.com/chmorgan/packetnet/pull/13","id":195155371,"number":13,"title":"Cameron pr","user":{"login":"cameron-elliott","id":868689,"avatar_url":"https://avatars.githubusercontent.com/u/868689?v=3","gravatar_id":"","url":"https://api.github.com/users/cameron-elliott","html_url":"https://github.com/cameron-elliott","followers_url":"https://api.github.com/users/cameron-elliott/followers","following_url":"https://api.github.com/users/cameron-elliott/following{/other_user}","gists_url":"https://api.github.com/users/cameron-elliott/gists{/gist_id}","starred_url":"https://api.github.com/users/cameron-elliott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cameron-elliott/subscriptions","organizations_url":"https://api.github.com/users/cameron-elliott/orgs","repos_url":"https://api.github.com/users/cameron-elliott/repos","events_url":"https://api.github.com/users/cameron-elliott/events{/privacy}","received_events_url":"https://api.github.com/users/cameron-elliott/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-13T03:59:48Z","updated_at":"2016-12-15T20:36:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chmorgan/packetnet/pulls/13","html_url":"https://github.com/chmorgan/packetnet/pull/13","diff_url":"https://github.com/chmorgan/packetnet/pull/13.diff","patch_url":"https://github.com/chmorgan/packetnet/pull/13.patch"},"body":"I have made the following changes:\r\n- created both an Ipv4 and Ipv6 icmp pcap file with raw link layer from the previous ethernet link layer pcaps to support the unit tests\r\n- Upgraded NUnit from 2.4.x to version 2.6.3 so it can support TestCaseAttribute\r\n- Modified the ipv4 and ipv6 Icmp tests so they will test both ethernet pcap files and raw pcap files.\r\n- Fixed an issue in the code of the original PR, resolving a bug.\r\n- Added some explanatory text to how IPv4 vs IPv6 is detected since Raw lacks headers\r\n"},"comment":{"url":"https://api.github.com/repos/chmorgan/packetnet/issues/comments/267437135","html_url":"https://github.com/chmorgan/packetnet/pull/13#issuecomment-267437135","issue_url":"https://api.github.com/repos/chmorgan/packetnet/issues/13","id":267437135,"user":{"login":"chmorgan","id":1211904,"avatar_url":"https://avatars.githubusercontent.com/u/1211904?v=3","gravatar_id":"","url":"https://api.github.com/users/chmorgan","html_url":"https://github.com/chmorgan","followers_url":"https://api.github.com/users/chmorgan/followers","following_url":"https://api.github.com/users/chmorgan/following{/other_user}","gists_url":"https://api.github.com/users/chmorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/chmorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chmorgan/subscriptions","organizations_url":"https://api.github.com/users/chmorgan/orgs","repos_url":"https://api.github.com/users/chmorgan/repos","events_url":"https://api.github.com/users/chmorgan/events{/privacy}","received_events_url":"https://api.github.com/users/chmorgan/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T20:36:38Z","updated_at":"2016-12-15T20:36:38Z","body":"@cameron-elliott I think either approach works for me. It does seem separate from this pull request so a separate pull request probably makes the most sense."}}
{"actor":{"display_login":"chmorgan"}}