{"action":"created","issue":{"url":"https://api.github.com/repos/UW-Hydro/VIC/issues/211","repository_url":"https://api.github.com/repos/UW-Hydro/VIC","labels_url":"https://api.github.com/repos/UW-Hydro/VIC/issues/211/labels{/name}","comments_url":"https://api.github.com/repos/UW-Hydro/VIC/issues/211/comments","events_url":"https://api.github.com/repos/UW-Hydro/VIC/issues/211/events","html_url":"https://github.com/UW-Hydro/VIC/issues/211","id":73481583,"number":211,"title":"Specify netCDF variable names in global config file","user":{"login":"jhamman","id":2443309,"avatar_url":"https://avatars.githubusercontent.com/u/2443309?v=3","gravatar_id":"","url":"https://api.github.com/users/jhamman","html_url":"https://github.com/jhamman","followers_url":"https://api.github.com/users/jhamman/followers","following_url":"https://api.github.com/users/jhamman/following{/other_user}","gists_url":"https://api.github.com/users/jhamman/gists{/gist_id}","starred_url":"https://api.github.com/users/jhamman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhamman/subscriptions","organizations_url":"https://api.github.com/users/jhamman/orgs","repos_url":"https://api.github.com/users/jhamman/repos","events_url":"https://api.github.com/users/jhamman/events{/privacy}","received_events_url":"https://api.github.com/users/jhamman/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/UW-Hydro/VIC/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/UW-Hydro/VIC/labels/image%20driver","name":"image driver","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/UW-Hydro/VIC/milestones/2","html_url":"https://github.com/UW-Hydro/VIC/milestones/5.0","labels_url":"https://api.github.com/repos/UW-Hydro/VIC/milestones/2/labels","id":391482,"number":2,"title":"5.0","description":"VIC code reorganization, image mode driver with MPI.  No science changes from VIC.4.2 ","creator":{"login":"jhamman","id":2443309,"avatar_url":"https://avatars.githubusercontent.com/u/2443309?v=3","gravatar_id":"","url":"https://api.github.com/users/jhamman","html_url":"https://github.com/jhamman","followers_url":"https://api.github.com/users/jhamman/followers","following_url":"https://api.github.com/users/jhamman/following{/other_user}","gists_url":"https://api.github.com/users/jhamman/gists{/gist_id}","starred_url":"https://api.github.com/users/jhamman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhamman/subscriptions","organizations_url":"https://api.github.com/users/jhamman/orgs","repos_url":"https://api.github.com/users/jhamman/repos","events_url":"https://api.github.com/users/jhamman/events{/privacy}","received_events_url":"https://api.github.com/users/jhamman/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":86,"state":"open","created_at":"2013-07-31T19:03:06Z","updated_at":"2016-02-19T04:19:34Z","due_on":"2015-12-11T08:00:00Z","closed_at":null},"comments":10,"created_at":"2015-05-06T01:24:48Z","updated_at":"2016-02-19T12:55:52Z","closed_at":null,"body":"In the current image mode driver, we have hard coded the variable names for forcing variables, domain variables, and parameter variables.  This includes netCDF dimension names.  As I have just moved to a new test case, I've had to modify these hard coded variable names, for example:\r\n```diff\r\n-    global_domain->n_nx = get_nc_dimension(nc_name, \"ni\");\r\n-    global_domain->n_ny = get_nc_dimension(nc_name, \"nj\");\r\n+    global_domain->n_nx = get_nc_dimension(nc_name, \"lon\");\r\n+    global_domain->n_ny = get_nc_dimension(nc_name, \"lat\");\r\n-    get_nc_field_int(nc_name, \"run_cell\", d2start, d2count, run);\r\n+    get_nc_field_int(nc_name, \"mask\", d2start, d2count, run);\r\n-    get_nc_field_double(nc_name, \"xc\",\r\n+    get_nc_field_double(nc_name, \"lon\",\r\n-    get_nc_field_double(nc_name, \"yc\",\r\n+    get_nc_field_double(nc_name, \"lat\",\r\n```\r\n\r\nWould it make sense to add these field names to the global parameter file?  This is probably most important for the dimension names and for the forcing variables.  Parameter variables and domain file variables are mostly fixed and I don't think we need to provide too much flexibility in that way.  \r\n\r\n@bartnijssen - The changes in the above diff were required to run the Stehekin example after the commits in #210."},"comment":{"url":"https://api.github.com/repos/UW-Hydro/VIC/issues/comments/186204094","html_url":"https://github.com/UW-Hydro/VIC/issues/211#issuecomment-186204094","issue_url":"https://api.github.com/repos/UW-Hydro/VIC/issues/211","id":186204094,"user":{"login":"wietsefranssen","id":13525266,"avatar_url":"https://avatars.githubusercontent.com/u/13525266?v=3","gravatar_id":"","url":"https://api.github.com/users/wietsefranssen","html_url":"https://github.com/wietsefranssen","followers_url":"https://api.github.com/users/wietsefranssen/followers","following_url":"https://api.github.com/users/wietsefranssen/following{/other_user}","gists_url":"https://api.github.com/users/wietsefranssen/gists{/gist_id}","starred_url":"https://api.github.com/users/wietsefranssen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wietsefranssen/subscriptions","organizations_url":"https://api.github.com/users/wietsefranssen/orgs","repos_url":"https://api.github.com/users/wietsefranssen/repos","events_url":"https://api.github.com/users/wietsefranssen/events{/privacy}","received_events_url":"https://api.github.com/users/wietsefranssen/received_events","type":"User","site_admin":false},"created_at":"2016-02-19T12:55:52Z","updated_at":"2016-02-19T12:55:52Z","body":"`FORCE_TYPE <var_identifier> <nc_var_name>`looks good for me too"}}