{"action":"created","comment":{"url":"https://api.github.com/repos/linetools/linetools/pulls/comments/71073281","id":71073281,"diff_hunk":"@@ -280,7 +307,100 @@ def set_lines(self, verbose=True, use_cache=True, use_ISM_table=True):\n         self._data = tmp_tab\n         CACHE['data'][key] = self._data\n \n-    def subset_lines(self, subset, sort=False, reset_data=False, verbose=False):\n+    def set_extra_columns_to_datatable(self, abundance_type='solar', ion_correction='none'):\n+        \"\"\"Sets new convenient columns to the self._data QTable.\n+        These include:\n+            - `ion_name` : HI, CIII, CIV, etc\n+            - `log(w*f)` : np.log10(wrest * fosc)  # in np.log10(AA)\n+            - `abundance` : given by [`none`, `solar`]\n+            - `ion_correction` : [`none`]\n+            - `rel_strength` : log(w*f) + abundance + ion_correction\n+\n+        This function is only implemented for the following lists: HI, ISM, EUV, Strong\n+\n+        \"\"\"\n+        good_linelists = ['HI', 'ISM', 'EUV', 'Strong']\n+        if self.list not in good_linelists:","path":"linetools/lists/linelist.py","position":86,"original_position":86,"commit_id":"bef86c02dac1c9aeaf5a124245e37cf898ce7918","original_commit_id":"bef86c02dac1c9aeaf5a124245e37cf898ce7918","user":{"login":"profxj","id":3998093,"avatar_url":"https://avatars.githubusercontent.com/u/3998093?v=3","gravatar_id":"","url":"https://api.github.com/users/profxj","html_url":"https://github.com/profxj","followers_url":"https://api.github.com/users/profxj/followers","following_url":"https://api.github.com/users/profxj/following{/other_user}","gists_url":"https://api.github.com/users/profxj/gists{/gist_id}","starred_url":"https://api.github.com/users/profxj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/profxj/subscriptions","organizations_url":"https://api.github.com/users/profxj/orgs","repos_url":"https://api.github.com/users/profxj/repos","events_url":"https://api.github.com/users/profxj/events{/privacy}","received_events_url":"https://api.github.com/users/profxj/received_events","type":"User","site_admin":false},"body":"If you don't use good_linelists below then combine 322 and 323","created_at":"2016-07-16T23:18:00Z","updated_at":"2016-07-16T23:18:00Z","html_url":"https://github.com/linetools/linetools/pull/251#discussion_r71073281","pull_request_url":"https://api.github.com/repos/linetools/linetools/pulls/251","_links":{"self":{"href":"https://api.github.com/repos/linetools/linetools/pulls/comments/71073281"},"html":{"href":"https://github.com/linetools/linetools/pull/251#discussion_r71073281"},"pull_request":{"href":"https://api.github.com/repos/linetools/linetools/pulls/251"}}},"pull_request":{"url":"https://api.github.com/repos/linetools/linetools/pulls/251","id":77716531,"html_url":"https://github.com/linetools/linetools/pull/251","diff_url":"https://github.com/linetools/linetools/pull/251.diff","patch_url":"https://github.com/linetools/linetools/pull/251.patch","issue_url":"https://api.github.com/repos/linetools/linetools/issues/251","number":251,"state":"open","locked":false,"title":"LineList: new definitions to handle sorting the underlying LineList data.","user":{"login":"ntejos","id":2862340,"avatar_url":"https://avatars.githubusercontent.com/u/2862340?v=3","gravatar_id":"","url":"https://api.github.com/users/ntejos","html_url":"https://github.com/ntejos","followers_url":"https://api.github.com/users/ntejos/followers","following_url":"https://api.github.com/users/ntejos/following{/other_user}","gists_url":"https://api.github.com/users/ntejos/gists{/gist_id}","starred_url":"https://api.github.com/users/ntejos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntejos/subscriptions","organizations_url":"https://api.github.com/users/ntejos/orgs","repos_url":"https://api.github.com/users/ntejos/repos","events_url":"https://api.github.com/users/ntejos/events{/privacy}","received_events_url":"https://api.github.com/users/ntejos/received_events","type":"User","site_admin":false},"body":"- Convenient new columns added: log(w*f), abundance, ion_correction, ion_name.\r\n- Sorting method\r\n- available_transitions(): `n_max` keyword parameter removed as it probed not be useful.","created_at":"2016-07-16T18:42:27Z","updated_at":"2016-07-16T23:18:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d4752b7e8044d1a233f2a71c7a58f8b87d70153","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/linetools/linetools/pulls/251/commits","review_comments_url":"https://api.github.com/repos/linetools/linetools/pulls/251/comments","review_comment_url":"https://api.github.com/repos/linetools/linetools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linetools/linetools/issues/251/comments","statuses_url":"https://api.github.com/repos/linetools/linetools/statuses/bef86c02dac1c9aeaf5a124245e37cf898ce7918","head":{"label":"linetools:linelist","ref":"linelist","sha":"bef86c02dac1c9aeaf5a124245e37cf898ce7918","user":{"login":"linetools","id":12589255,"avatar_url":"https://avatars.githubusercontent.com/u/12589255?v=3","gravatar_id":"","url":"https://api.github.com/users/linetools","html_url":"https://github.com/linetools","followers_url":"https://api.github.com/users/linetools/followers","following_url":"https://api.github.com/users/linetools/following{/other_user}","gists_url":"https://api.github.com/users/linetools/gists{/gist_id}","starred_url":"https://api.github.com/users/linetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linetools/subscriptions","organizations_url":"https://api.github.com/users/linetools/orgs","repos_url":"https://api.github.com/users/linetools/repos","events_url":"https://api.github.com/users/linetools/events{/privacy}","received_events_url":"https://api.github.com/users/linetools/received_events","type":"Organization","site_admin":false},"repo":{"id":36200517,"name":"linetools","full_name":"linetools/linetools","owner":{"login":"linetools","id":12589255,"avatar_url":"https://avatars.githubusercontent.com/u/12589255?v=3","gravatar_id":"","url":"https://api.github.com/users/linetools","html_url":"https://github.com/linetools","followers_url":"https://api.github.com/users/linetools/followers","following_url":"https://api.github.com/users/linetools/following{/other_user}","gists_url":"https://api.github.com/users/linetools/gists{/gist_id}","starred_url":"https://api.github.com/users/linetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linetools/subscriptions","organizations_url":"https://api.github.com/users/linetools/orgs","repos_url":"https://api.github.com/users/linetools/repos","events_url":"https://api.github.com/users/linetools/events{/privacy}","received_events_url":"https://api.github.com/users/linetools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linetools/linetools","description":"A package for the analysis of 1d astronomical spectra, especially quasar and galaxy spectra.","fork":false,"url":"https://api.github.com/repos/linetools/linetools","forks_url":"https://api.github.com/repos/linetools/linetools/forks","keys_url":"https://api.github.com/repos/linetools/linetools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linetools/linetools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linetools/linetools/teams","hooks_url":"https://api.github.com/repos/linetools/linetools/hooks","issue_events_url":"https://api.github.com/repos/linetools/linetools/issues/events{/number}","events_url":"https://api.github.com/repos/linetools/linetools/events","assignees_url":"https://api.github.com/repos/linetools/linetools/assignees{/user}","branches_url":"https://api.github.com/repos/linetools/linetools/branches{/branch}","tags_url":"https://api.github.com/repos/linetools/linetools/tags","blobs_url":"https://api.github.com/repos/linetools/linetools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linetools/linetools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linetools/linetools/git/refs{/sha}","trees_url":"https://api.github.com/repos/linetools/linetools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linetools/linetools/statuses/{sha}","languages_url":"https://api.github.com/repos/linetools/linetools/languages","stargazers_url":"https://api.github.com/repos/linetools/linetools/stargazers","contributors_url":"https://api.github.com/repos/linetools/linetools/contributors","subscribers_url":"https://api.github.com/repos/linetools/linetools/subscribers","subscription_url":"https://api.github.com/repos/linetools/linetools/subscription","commits_url":"https://api.github.com/repos/linetools/linetools/commits{/sha}","git_commits_url":"https://api.github.com/repos/linetools/linetools/git/commits{/sha}","comments_url":"https://api.github.com/repos/linetools/linetools/comments{/number}","issue_comment_url":"https://api.github.com/repos/linetools/linetools/issues/comments{/number}","contents_url":"https://api.github.com/repos/linetools/linetools/contents/{+path}","compare_url":"https://api.github.com/repos/linetools/linetools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linetools/linetools/merges","archive_url":"https://api.github.com/repos/linetools/linetools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linetools/linetools/downloads","issues_url":"https://api.github.com/repos/linetools/linetools/issues{/number}","pulls_url":"https://api.github.com/repos/linetools/linetools/pulls{/number}","milestones_url":"https://api.github.com/repos/linetools/linetools/milestones{/number}","notifications_url":"https://api.github.com/repos/linetools/linetools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linetools/linetools/labels{/name}","releases_url":"https://api.github.com/repos/linetools/linetools/releases{/id}","deployments_url":"https://api.github.com/repos/linetools/linetools/deployments","created_at":"2015-05-25T00:15:17Z","updated_at":"2016-07-11T15:56:13Z","pushed_at":"2016-07-16T23:14:41Z","git_url":"git://github.com/linetools/linetools.git","ssh_url":"git@github.com:linetools/linetools.git","clone_url":"https://github.com/linetools/linetools.git","svn_url":"https://github.com/linetools/linetools","homepage":"","size":28630,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":13,"forks":8,"open_issues":13,"watchers":6,"default_branch":"master"}},"base":{"label":"linetools:master","ref":"master","sha":"74defa2b582db4ade6430cbe43c4162180e3d7dd","user":{"login":"linetools","id":12589255,"avatar_url":"https://avatars.githubusercontent.com/u/12589255?v=3","gravatar_id":"","url":"https://api.github.com/users/linetools","html_url":"https://github.com/linetools","followers_url":"https://api.github.com/users/linetools/followers","following_url":"https://api.github.com/users/linetools/following{/other_user}","gists_url":"https://api.github.com/users/linetools/gists{/gist_id}","starred_url":"https://api.github.com/users/linetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linetools/subscriptions","organizations_url":"https://api.github.com/users/linetools/orgs","repos_url":"https://api.github.com/users/linetools/repos","events_url":"https://api.github.com/users/linetools/events{/privacy}","received_events_url":"https://api.github.com/users/linetools/received_events","type":"Organization","site_admin":false},"repo":{"id":36200517,"name":"linetools","full_name":"linetools/linetools","owner":{"login":"linetools","id":12589255,"avatar_url":"https://avatars.githubusercontent.com/u/12589255?v=3","gravatar_id":"","url":"https://api.github.com/users/linetools","html_url":"https://github.com/linetools","followers_url":"https://api.github.com/users/linetools/followers","following_url":"https://api.github.com/users/linetools/following{/other_user}","gists_url":"https://api.github.com/users/linetools/gists{/gist_id}","starred_url":"https://api.github.com/users/linetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linetools/subscriptions","organizations_url":"https://api.github.com/users/linetools/orgs","repos_url":"https://api.github.com/users/linetools/repos","events_url":"https://api.github.com/users/linetools/events{/privacy}","received_events_url":"https://api.github.com/users/linetools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linetools/linetools","description":"A package for the analysis of 1d astronomical spectra, especially quasar and galaxy spectra.","fork":false,"url":"https://api.github.com/repos/linetools/linetools","forks_url":"https://api.github.com/repos/linetools/linetools/forks","keys_url":"https://api.github.com/repos/linetools/linetools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linetools/linetools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linetools/linetools/teams","hooks_url":"https://api.github.com/repos/linetools/linetools/hooks","issue_events_url":"https://api.github.com/repos/linetools/linetools/issues/events{/number}","events_url":"https://api.github.com/repos/linetools/linetools/events","assignees_url":"https://api.github.com/repos/linetools/linetools/assignees{/user}","branches_url":"https://api.github.com/repos/linetools/linetools/branches{/branch}","tags_url":"https://api.github.com/repos/linetools/linetools/tags","blobs_url":"https://api.github.com/repos/linetools/linetools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linetools/linetools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linetools/linetools/git/refs{/sha}","trees_url":"https://api.github.com/repos/linetools/linetools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linetools/linetools/statuses/{sha}","languages_url":"https://api.github.com/repos/linetools/linetools/languages","stargazers_url":"https://api.github.com/repos/linetools/linetools/stargazers","contributors_url":"https://api.github.com/repos/linetools/linetools/contributors","subscribers_url":"https://api.github.com/repos/linetools/linetools/subscribers","subscription_url":"https://api.github.com/repos/linetools/linetools/subscription","commits_url":"https://api.github.com/repos/linetools/linetools/commits{/sha}","git_commits_url":"https://api.github.com/repos/linetools/linetools/git/commits{/sha}","comments_url":"https://api.github.com/repos/linetools/linetools/comments{/number}","issue_comment_url":"https://api.github.com/repos/linetools/linetools/issues/comments{/number}","contents_url":"https://api.github.com/repos/linetools/linetools/contents/{+path}","compare_url":"https://api.github.com/repos/linetools/linetools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linetools/linetools/merges","archive_url":"https://api.github.com/repos/linetools/linetools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linetools/linetools/downloads","issues_url":"https://api.github.com/repos/linetools/linetools/issues{/number}","pulls_url":"https://api.github.com/repos/linetools/linetools/pulls{/number}","milestones_url":"https://api.github.com/repos/linetools/linetools/milestones{/number}","notifications_url":"https://api.github.com/repos/linetools/linetools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linetools/linetools/labels{/name}","releases_url":"https://api.github.com/repos/linetools/linetools/releases{/id}","deployments_url":"https://api.github.com/repos/linetools/linetools/deployments","created_at":"2015-05-25T00:15:17Z","updated_at":"2016-07-11T15:56:13Z","pushed_at":"2016-07-16T23:14:41Z","git_url":"git://github.com/linetools/linetools.git","ssh_url":"git@github.com:linetools/linetools.git","clone_url":"https://github.com/linetools/linetools.git","svn_url":"https://github.com/linetools/linetools","homepage":"","size":28630,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":13,"forks":8,"open_issues":13,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linetools/linetools/pulls/251"},"html":{"href":"https://github.com/linetools/linetools/pull/251"},"issue":{"href":"https://api.github.com/repos/linetools/linetools/issues/251"},"comments":{"href":"https://api.github.com/repos/linetools/linetools/issues/251/comments"},"review_comments":{"href":"https://api.github.com/repos/linetools/linetools/pulls/251/comments"},"review_comment":{"href":"https://api.github.com/repos/linetools/linetools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linetools/linetools/pulls/251/commits"},"statuses":{"href":"https://api.github.com/repos/linetools/linetools/statuses/bef86c02dac1c9aeaf5a124245e37cf898ce7918"}}}}
{"actor":{"display_login":"profxj"}}