{"action":"created","issue":{"url":"https://api.github.com/repos/SilverThings/SilverWare/issues/49","repository_url":"https://api.github.com/repos/SilverThings/SilverWare","labels_url":"https://api.github.com/repos/SilverThings/SilverWare/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/SilverThings/SilverWare/issues/49/comments","events_url":"https://api.github.com/repos/SilverThings/SilverWare/issues/49/events","html_url":"https://github.com/SilverThings/SilverWare/pull/49","id":173609512,"number":49,"title":"Change bean-discovery-mode from 'all' to 'annotated'","user":{"login":"livthomas","id":2910853,"avatar_url":"https://avatars.githubusercontent.com/u/2910853?v=3","gravatar_id":"","url":"https://api.github.com/users/livthomas","html_url":"https://github.com/livthomas","followers_url":"https://api.github.com/users/livthomas/followers","following_url":"https://api.github.com/users/livthomas/following{/other_user}","gists_url":"https://api.github.com/users/livthomas/gists{/gist_id}","starred_url":"https://api.github.com/users/livthomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livthomas/subscriptions","organizations_url":"https://api.github.com/users/livthomas/orgs","repos_url":"https://api.github.com/users/livthomas/repos","events_url":"https://api.github.com/users/livthomas/events{/privacy}","received_events_url":"https://api.github.com/users/livthomas/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/SilverThings/SilverWare/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"marvec","id":625319,"avatar_url":"https://avatars.githubusercontent.com/u/625319?v=3","gravatar_id":"","url":"https://api.github.com/users/marvec","html_url":"https://github.com/marvec","followers_url":"https://api.github.com/users/marvec/followers","following_url":"https://api.github.com/users/marvec/following{/other_user}","gists_url":"https://api.github.com/users/marvec/gists{/gist_id}","starred_url":"https://api.github.com/users/marvec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marvec/subscriptions","organizations_url":"https://api.github.com/users/marvec/orgs","repos_url":"https://api.github.com/users/marvec/repos","events_url":"https://api.github.com/users/marvec/events{/privacy}","received_events_url":"https://api.github.com/users/marvec/received_events","type":"User","site_admin":false},"assignees":[{"login":"marvec","id":625319,"avatar_url":"https://avatars.githubusercontent.com/u/625319?v=3","gravatar_id":"","url":"https://api.github.com/users/marvec","html_url":"https://github.com/marvec","followers_url":"https://api.github.com/users/marvec/followers","following_url":"https://api.github.com/users/marvec/following{/other_user}","gists_url":"https://api.github.com/users/marvec/gists{/gist_id}","starred_url":"https://api.github.com/users/marvec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marvec/subscriptions","organizations_url":"https://api.github.com/users/marvec/orgs","repos_url":"https://api.github.com/users/marvec/repos","events_url":"https://api.github.com/users/marvec/events{/privacy}","received_events_url":"https://api.github.com/users/marvec/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-08-27T18:40:26Z","updated_at":"2016-09-04T18:37:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SilverThings/SilverWare/pulls/49","html_url":"https://github.com/SilverThings/SilverWare/pull/49","diff_url":"https://github.com/SilverThings/SilverWare/pull/49.diff","patch_url":"https://github.com/SilverThings/SilverWare/pull/49.patch"},"body":"I have changed CDI bean-discovery-mode from 'all' to 'annotated'. This prevents classes with no-argument constructor from becoming a managed bean unless they have a bean defining annotation (see [Weld documentation](http://docs.jboss.org/weld/reference/latest-master/en-US/html/environments.html#_implicit_bean_archive_support_2) for more details). There are some examples of such classes in `cdi-microservice-provider` module which were accidentally managed by container."},"comment":{"url":"https://api.github.com/repos/SilverThings/SilverWare/issues/comments/244621067","html_url":"https://github.com/SilverThings/SilverWare/pull/49#issuecomment-244621067","issue_url":"https://api.github.com/repos/SilverThings/SilverWare/issues/49","id":244621067,"user":{"login":"marvec","id":625319,"avatar_url":"https://avatars.githubusercontent.com/u/625319?v=3","gravatar_id":"","url":"https://api.github.com/users/marvec","html_url":"https://github.com/marvec","followers_url":"https://api.github.com/users/marvec/followers","following_url":"https://api.github.com/users/marvec/following{/other_user}","gists_url":"https://api.github.com/users/marvec/gists{/gist_id}","starred_url":"https://api.github.com/users/marvec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marvec/subscriptions","organizations_url":"https://api.github.com/users/marvec/orgs","repos_url":"https://api.github.com/users/marvec/repos","events_url":"https://api.github.com/users/marvec/events{/privacy}","received_events_url":"https://api.github.com/users/marvec/received_events","type":"User","site_admin":false},"created_at":"2016-09-04T18:37:36Z","updated_at":"2016-09-04T18:37:36Z","body":"Ahoj, this seems reasonable. I am just wondering what classes get managed? AFAIK when I was debugging the bean discovery, I did not notice anything else than what I already annotated. The prevention of managing other beans was using separate lib directory with all jars. In a shaded jars we struggled with problems like Guava using CDI annotations for its own purpose."}}
{"actor":{"display_login":"marvec"}}