{"action":"created","comment":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/comments/57531768","id":57531768,"diff_hunk":"@@ -15,83 +15,103 @@ const Menu = React.createClass({\n \n   propTypes: {\n     /**\n-     * If true, the menu will apply transitions when added it\n-     * gets added to the DOM. In order for transitions to\n-     * work, wrap the menu inside a ReactTransitionGroup.\n+     * If true, the menu will apply transitions when it\n+     * is added to the DOM. In order for transitions to\n+     * work, wrap the menu inside a `ReactTransitionGroup`.\n      */\n     animated: deprecated(React.PropTypes.bool, 'Instead, use a [Popover](/#/components/popover).'),\n \n     /**\n-     * If true, the width will automatically be\n-     * set according to the items inside the menu\n-     * using the proper keyline increment.\n+     * If true, the width of the menu will automatically be\n+     * set according to the widths of its children,\n+     * using proper keyline increments (64px for desktop,\n+     * 56px otherwise).\n      */\n     autoWidth: React.PropTypes.bool,\n \n     /**\n-     * Children for the Menu. Usually MenuItems.\n+     * The content of the menu. This is usually used to pass `MenuItem`\n+     * elements.\n      */\n     children: React.PropTypes.node,\n \n     /**\n-     * Indicates if the menu should render with compact desktop styles.\n+     * If true, the menu item will render with compact desktop styles.\n      */\n     desktop: React.PropTypes.bool,\n \n     /**\n-     * Disable the auto focus feature.\n+     * If true, the menu will not be auto-focused.\n      */\n     disableAutoFocus: React.PropTypes.bool,\n \n     /**\n-     * True if this item should be focused by the keyboard initially.\n+     * If true, the menu will be keyboard-focused initially.\n      */\n     initiallyKeyboardFocused: React.PropTypes.bool,\n \n     /**\n-     * The style object to use to override underlying list style.\n+     * Override the inline-styles of the underlying `List` element.\n      */\n     listStyle: React.PropTypes.object,\n \n     /**\n-     * The maxHeight of the menu in pixels. If\n-     * specified, the menu will scroll if larger than the maxHeight.\n+     * The maximum height of the menu in pixels. If specified,\n+     * the menu will be scrollable if it's taller than the provided\n+     * height.\n      */\n     maxHeight: React.PropTypes.number,\n \n     /**\n-     * If true, the value can be an array and allow the menu to be a multi-select.\n+     * If true, `value` must be an array and the menu will support\n+     * multiple selections.\n      */\n     multiple: React.PropTypes.bool,\n \n     /**\n-     * Fired when a menu item is touchTapped and the menu item\n-     * value is not equal to the current menu value.\n+     * Callback function fired when a menu item with `value` not\n+     * equal to the current `value` of the menu is touch-tapped.\n+     *\n+     * @param {object} event TouchTap event targeting the menu item.\n+     * @param {any}  value If `multiple` is true, the menu's `value`\n+     * array with either the menu item's `value` added (if\n+     * it wasn't already selected) or omitted (if it was already selected).\n+     * Otherwise, the `value` of the menu item.\n      */\n     onChange: React.PropTypes.func,\n \n     /**\n-     * Fired when an Esc key is keyed down.\n+     * Callback function fired when the Esc key is pressed and the menu\n+     * is focused.\n+     *\n+     * @param {object} event `keydown` event targeting the menu.\n      */\n     onEscKeyDown: React.PropTypes.func,\n \n     /**\n-     * Fired when a menu item is touchTapped.\n+     * Callback function fired when a menu item is touch-tapped.","path":"src/Menu/Menu.js","position":96,"original_position":96,"commit_id":"885d633938a0ee0f42f8217fbc7250fdb0a434f3","original_commit_id":"c23d895c31866304e2b07f685746dfacd0911a97","user":{"login":"mbrookes","id":357702,"avatar_url":"https://avatars.githubusercontent.com/u/357702?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrookes","html_url":"https://github.com/mbrookes","followers_url":"https://api.github.com/users/mbrookes/followers","following_url":"https://api.github.com/users/mbrookes/following{/other_user}","gists_url":"https://api.github.com/users/mbrookes/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrookes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrookes/subscriptions","organizations_url":"https://api.github.com/users/mbrookes/orgs","repos_url":"https://api.github.com/users/mbrookes/repos","events_url":"https://api.github.com/users/mbrookes/events{/privacy}","received_events_url":"https://api.github.com/users/mbrookes/received_events","type":"User","site_admin":false},"body":"> I thought it was important to distinguish it from just a touch event.\r\n\r\nbut \"'touch-tapped\" doesn't mention clicked :smile: \r\n\r\n\"is tapped or touched\" is the same words, but in English.\r\n\r\nperhaps \"is tapped or clicked\" wold be better, but in any case, if it's consistent, that's the main thing. (If nothing else it make search and replace later easier. :smile:)","created_at":"2016-03-27T17:09:27Z","updated_at":"2016-03-27T17:09:27Z","html_url":"https://github.com/callemall/material-ui/pull/3821#discussion_r57531768","pull_request_url":"https://api.github.com/repos/callemall/material-ui/pulls/3821","_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments/57531768"},"html":{"href":"https://github.com/callemall/material-ui/pull/3821#discussion_r57531768"},"pull_request":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/3821"}}},"pull_request":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/3821","id":64263759,"html_url":"https://github.com/callemall/material-ui/pull/3821","diff_url":"https://github.com/callemall/material-ui/pull/3821.diff","patch_url":"https://github.com/callemall/material-ui/pull/3821.patch","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/3821","number":3821,"state":"open","locked":false,"title":"[Menu, MenuItem] Add callback signatures to docs; improve other props.","user":{"login":"theosherry","id":8320854,"avatar_url":"https://avatars.githubusercontent.com/u/8320854?v=3","gravatar_id":"","url":"https://api.github.com/users/theosherry","html_url":"https://github.com/theosherry","followers_url":"https://api.github.com/users/theosherry/followers","following_url":"https://api.github.com/users/theosherry/following{/other_user}","gists_url":"https://api.github.com/users/theosherry/gists{/gist_id}","starred_url":"https://api.github.com/users/theosherry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theosherry/subscriptions","organizations_url":"https://api.github.com/users/theosherry/orgs","repos_url":"https://api.github.com/users/theosherry/repos","events_url":"https://api.github.com/users/theosherry/events{/privacy}","received_events_url":"https://api.github.com/users/theosherry/received_events","type":"User","site_admin":false},"body":"<!-- Thanks so much for your PR, your contribution is appreciated! -->\r\n\r\n- [x] PR has tests / docs demo, and is linted.\r\n- [x] Commit and PR titles begin with [ComponentName], and are in imperative form: \"[Component] Fix leaky abstraction\".\r\n- [ ] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).\r\n\r\nHey, a bigger one for #3096.\r\n\r\nI added the `primaryText` prop to `MenuItem`.\r\n\r\nI'm not sure what's going on with the `openDirection` prop of `Menu`.  It seems like it would just be used with `IconMenu`s, but it's not even used there.  Maybe it should be deprecated?\r\n\r\n","created_at":"2016-03-27T11:52:53Z","updated_at":"2016-03-27T17:09:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"010de1b09c452e3b9a25471541c96a6f7ae09ce6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/callemall/material-ui/pulls/3821/commits","review_comments_url":"https://api.github.com/repos/callemall/material-ui/pulls/3821/comments","review_comment_url":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/3821/comments","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/885d633938a0ee0f42f8217fbc7250fdb0a434f3","head":{"label":"theosherry:Menu_docs","ref":"Menu_docs","sha":"885d633938a0ee0f42f8217fbc7250fdb0a434f3","user":{"login":"theosherry","id":8320854,"avatar_url":"https://avatars.githubusercontent.com/u/8320854?v=3","gravatar_id":"","url":"https://api.github.com/users/theosherry","html_url":"https://github.com/theosherry","followers_url":"https://api.github.com/users/theosherry/followers","following_url":"https://api.github.com/users/theosherry/following{/other_user}","gists_url":"https://api.github.com/users/theosherry/gists{/gist_id}","starred_url":"https://api.github.com/users/theosherry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theosherry/subscriptions","organizations_url":"https://api.github.com/users/theosherry/orgs","repos_url":"https://api.github.com/users/theosherry/repos","events_url":"https://api.github.com/users/theosherry/events{/privacy}","received_events_url":"https://api.github.com/users/theosherry/received_events","type":"User","site_admin":false},"repo":{"id":51014954,"name":"material-ui","full_name":"theosherry/material-ui","owner":{"login":"theosherry","id":8320854,"avatar_url":"https://avatars.githubusercontent.com/u/8320854?v=3","gravatar_id":"","url":"https://api.github.com/users/theosherry","html_url":"https://github.com/theosherry","followers_url":"https://api.github.com/users/theosherry/followers","following_url":"https://api.github.com/users/theosherry/following{/other_user}","gists_url":"https://api.github.com/users/theosherry/gists{/gist_id}","starred_url":"https://api.github.com/users/theosherry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theosherry/subscriptions","organizations_url":"https://api.github.com/users/theosherry/orgs","repos_url":"https://api.github.com/users/theosherry/repos","events_url":"https://api.github.com/users/theosherry/events{/privacy}","received_events_url":"https://api.github.com/users/theosherry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/theosherry/material-ui","description":"React Components that Implement Google's Material Design.","fork":true,"url":"https://api.github.com/repos/theosherry/material-ui","forks_url":"https://api.github.com/repos/theosherry/material-ui/forks","keys_url":"https://api.github.com/repos/theosherry/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theosherry/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theosherry/material-ui/teams","hooks_url":"https://api.github.com/repos/theosherry/material-ui/hooks","issue_events_url":"https://api.github.com/repos/theosherry/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/theosherry/material-ui/events","assignees_url":"https://api.github.com/repos/theosherry/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/theosherry/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/theosherry/material-ui/tags","blobs_url":"https://api.github.com/repos/theosherry/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theosherry/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theosherry/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/theosherry/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theosherry/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/theosherry/material-ui/languages","stargazers_url":"https://api.github.com/repos/theosherry/material-ui/stargazers","contributors_url":"https://api.github.com/repos/theosherry/material-ui/contributors","subscribers_url":"https://api.github.com/repos/theosherry/material-ui/subscribers","subscription_url":"https://api.github.com/repos/theosherry/material-ui/subscription","commits_url":"https://api.github.com/repos/theosherry/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/theosherry/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/theosherry/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/theosherry/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/theosherry/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/theosherry/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theosherry/material-ui/merges","archive_url":"https://api.github.com/repos/theosherry/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theosherry/material-ui/downloads","issues_url":"https://api.github.com/repos/theosherry/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/theosherry/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/theosherry/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/theosherry/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theosherry/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/theosherry/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/theosherry/material-ui/deployments","created_at":"2016-02-03T16:55:45Z","updated_at":"2016-02-03T16:55:46Z","pushed_at":"2016-03-27T14:05:33Z","git_url":"git://github.com/theosherry/material-ui.git","ssh_url":"git@github.com:theosherry/material-ui.git","clone_url":"https://github.com/theosherry/material-ui.git","svn_url":"https://github.com/theosherry/material-ui","homepage":"http://www.material-ui.com","size":48819,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"callemall:master","ref":"master","sha":"3b239d25c1ce396ed505ea98d224e3bf097d21cf","user":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"repo":{"id":23083156,"name":"material-ui","full_name":"callemall/material-ui","owner":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callemall/material-ui","description":"React Components that Implement Google's Material Design.","fork":false,"url":"https://api.github.com/repos/callemall/material-ui","forks_url":"https://api.github.com/repos/callemall/material-ui/forks","keys_url":"https://api.github.com/repos/callemall/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callemall/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callemall/material-ui/teams","hooks_url":"https://api.github.com/repos/callemall/material-ui/hooks","issue_events_url":"https://api.github.com/repos/callemall/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/callemall/material-ui/events","assignees_url":"https://api.github.com/repos/callemall/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/callemall/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/callemall/material-ui/tags","blobs_url":"https://api.github.com/repos/callemall/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callemall/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callemall/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/callemall/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/callemall/material-ui/languages","stargazers_url":"https://api.github.com/repos/callemall/material-ui/stargazers","contributors_url":"https://api.github.com/repos/callemall/material-ui/contributors","subscribers_url":"https://api.github.com/repos/callemall/material-ui/subscribers","subscription_url":"https://api.github.com/repos/callemall/material-ui/subscription","commits_url":"https://api.github.com/repos/callemall/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/callemall/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/callemall/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/callemall/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/callemall/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/callemall/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callemall/material-ui/merges","archive_url":"https://api.github.com/repos/callemall/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callemall/material-ui/downloads","issues_url":"https://api.github.com/repos/callemall/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/callemall/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/callemall/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/callemall/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callemall/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/callemall/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/callemall/material-ui/deployments","created_at":"2014-08-18T19:11:54Z","updated_at":"2016-03-27T16:07:18Z","pushed_at":"2016-03-27T16:09:39Z","git_url":"git://github.com/callemall/material-ui.git","ssh_url":"git@github.com:callemall/material-ui.git","clone_url":"https://github.com/callemall/material-ui.git","svn_url":"https://github.com/callemall/material-ui","homepage":"http://www.material-ui.com","size":63220,"stargazers_count":14843,"watchers_count":14843,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2536,"mirror_url":null,"open_issues_count":575,"forks":2536,"open_issues":575,"watchers":14843,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/3821"},"html":{"href":"https://github.com/callemall/material-ui/pull/3821"},"issue":{"href":"https://api.github.com/repos/callemall/material-ui/issues/3821"},"comments":{"href":"https://api.github.com/repos/callemall/material-ui/issues/3821/comments"},"review_comments":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/3821/comments"},"review_comment":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/3821/commits"},"statuses":{"href":"https://api.github.com/repos/callemall/material-ui/statuses/885d633938a0ee0f42f8217fbc7250fdb0a434f3"}}}}