{"action":"closed","number":18523,"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18523","id":98524906,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/18523","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/18523.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/18523.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18523","number":18523,"state":"closed","locked":false,"title":"Handle Quests.IgnoreAutoAccept in the post-processing phase of quest …","user":{"login":"adeutscher","id":2055500,"avatar_url":"https://avatars.githubusercontent.com/u/2055500?v=3","gravatar_id":"","url":"https://api.github.com/users/adeutscher","html_url":"https://github.com/adeutscher","followers_url":"https://api.github.com/users/adeutscher/followers","following_url":"https://api.github.com/users/adeutscher/following{/other_user}","gists_url":"https://api.github.com/users/adeutscher/gists{/gist_id}","starred_url":"https://api.github.com/users/adeutscher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adeutscher/subscriptions","organizations_url":"https://api.github.com/users/adeutscher/orgs","repos_url":"https://api.github.com/users/adeutscher/repos","events_url":"https://api.github.com/users/adeutscher/events{/privacy}","received_events_url":"https://api.github.com/users/adeutscher/received_events","type":"User","site_admin":false},"body":"**Changes proposed:**\r\n\r\n- During post-processing in `ObjectMgr::LoadQuests` when quests are loaded from the database, remove the `QUEST_FLAGS_AUTO_ACCEPT` flag if we are dealing with an auto-accept quest and `Quests.IgnoreAutoAccept` is set to True (1) in `worldserver.conf`\r\n-  Change `Quest::IsAutoAccept` to only check the `Quest` object's flag, as the post-processing addition should make the configuration check here redundant.\r\n\r\n**Target branch(es):** 3.3.5\r\n\r\n**Issues addressed:** Closes #17403\r\n\r\n**Tests performed:** (Does it build, tested in-game, etc.)\r\n\r\nBuilt and tested in game.\r\n\r\n- When `Quests.IgnoreAutoAccept` is set to ***0***, the quest is accepted the moment that the dialog comes up, which is consistent with how things were before this PR. I don't think that this is entirely Blizzlike, but that's a hiccup for another issue.\r\n- When `Quests.IgnoreAutoAccept` is set to ***1***, the quest now appears in the quest log after the \"Accept\" button is pressed. Previously, the quest dialog would disappear but no quest would be accepted.","created_at":"2016-12-19T08:36:06Z","updated_at":"2016-12-19T09:26:39Z","closed_at":"2016-12-19T09:26:39Z","merged_at":null,"merge_commit_sha":"8a90591f39c025600c03952576747bdbae4abb61","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18523/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18523/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18523/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/6cf48507986d545bbacf3546e1d95e2c44c8812f","head":{"label":"adeutscher:issue-17403-autoaccept-hiccups","ref":"issue-17403-autoaccept-hiccups","sha":"6cf48507986d545bbacf3546e1d95e2c44c8812f","user":{"login":"adeutscher","id":2055500,"avatar_url":"https://avatars.githubusercontent.com/u/2055500?v=3","gravatar_id":"","url":"https://api.github.com/users/adeutscher","html_url":"https://github.com/adeutscher","followers_url":"https://api.github.com/users/adeutscher/followers","following_url":"https://api.github.com/users/adeutscher/following{/other_user}","gists_url":"https://api.github.com/users/adeutscher/gists{/gist_id}","starred_url":"https://api.github.com/users/adeutscher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adeutscher/subscriptions","organizations_url":"https://api.github.com/users/adeutscher/orgs","repos_url":"https://api.github.com/users/adeutscher/repos","events_url":"https://api.github.com/users/adeutscher/events{/privacy}","received_events_url":"https://api.github.com/users/adeutscher/received_events","type":"User","site_admin":false},"repo":{"id":55185065,"name":"TrinityCore","full_name":"adeutscher/TrinityCore","owner":{"login":"adeutscher","id":2055500,"avatar_url":"https://avatars.githubusercontent.com/u/2055500?v=3","gravatar_id":"","url":"https://api.github.com/users/adeutscher","html_url":"https://github.com/adeutscher","followers_url":"https://api.github.com/users/adeutscher/followers","following_url":"https://api.github.com/users/adeutscher/following{/other_user}","gists_url":"https://api.github.com/users/adeutscher/gists{/gist_id}","starred_url":"https://api.github.com/users/adeutscher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adeutscher/subscriptions","organizations_url":"https://api.github.com/users/adeutscher/orgs","repos_url":"https://api.github.com/users/adeutscher/repos","events_url":"https://api.github.com/users/adeutscher/events{/privacy}","received_events_url":"https://api.github.com/users/adeutscher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adeutscher/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/adeutscher/TrinityCore","forks_url":"https://api.github.com/repos/adeutscher/TrinityCore/forks","keys_url":"https://api.github.com/repos/adeutscher/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adeutscher/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adeutscher/TrinityCore/teams","hooks_url":"https://api.github.com/repos/adeutscher/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/adeutscher/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/adeutscher/TrinityCore/events","assignees_url":"https://api.github.com/repos/adeutscher/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/adeutscher/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/adeutscher/TrinityCore/tags","blobs_url":"https://api.github.com/repos/adeutscher/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adeutscher/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adeutscher/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/adeutscher/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adeutscher/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/adeutscher/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/adeutscher/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/adeutscher/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/adeutscher/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/adeutscher/TrinityCore/subscription","commits_url":"https://api.github.com/repos/adeutscher/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/adeutscher/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/adeutscher/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/adeutscher/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/adeutscher/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/adeutscher/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adeutscher/TrinityCore/merges","archive_url":"https://api.github.com/repos/adeutscher/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adeutscher/TrinityCore/downloads","issues_url":"https://api.github.com/repos/adeutscher/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/adeutscher/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/adeutscher/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/adeutscher/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adeutscher/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/adeutscher/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/adeutscher/TrinityCore/deployments","created_at":"2016-03-31T21:46:36Z","updated_at":"2016-03-31T21:46:52Z","pushed_at":"2016-12-19T09:20:08Z","git_url":"git://github.com/adeutscher/TrinityCore.git","ssh_url":"git@github.com:adeutscher/TrinityCore.git","clone_url":"https://github.com/adeutscher/TrinityCore.git","svn_url":"https://github.com/adeutscher/TrinityCore","homepage":"http://www.trinitycore.org","size":367120,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"6.x"}},"base":{"label":"TrinityCore:3.3.5","ref":"3.3.5","sha":"85c68d634663028f2b60748eca469838d431f74b","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/deployments","created_at":"2010-12-28T23:40:07Z","updated_at":"2016-12-19T09:25:19Z","pushed_at":"2016-12-19T09:22:58Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":394581,"stargazers_count":3567,"watchers_count":3567,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3620,"mirror_url":null,"open_issues_count":1276,"forks":3620,"open_issues":1276,"watchers":3567,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18523"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/18523"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18523"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18523/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18523/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18523/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/6cf48507986d545bbacf3546e1d95e2c44c8812f"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":5,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"adeutscher"}}