{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/source-to-image/pulls/comments/58893653","id":58893653,"diff_hunk":"@@ -735,10 +735,10 @@ func equalArrayContents(a []string, b []string) bool {\n \n func TestGenerateConfigEnv(t *testing.T) {\n \trh := newFakeSTI(&FakeSTI{})\n-\ttestEnv := map[string]string{\n-\t\t\"Key1\": \"Value1\",\n-\t\t\"Key2\": \"Value2\",\n-\t\t\"Key3\": \"Value3\",\n+\ttestEnv := api.EnvironmentList{\n+\t\t{Name: \"Key1\", Value: \"Value1\"},\n+\t\t{Name: \"Key2\", Value: \"Value2\"},\n+\t\t{Name: \"Key3\", Value: \"Value3\"},","path":"pkg/build/strategies/sti/sti_test.go","position":11,"original_position":11,"commit_id":"aea49660c413f90e0fb051cc9e97e018cce1a7c6","original_commit_id":"aea49660c413f90e0fb051cc9e97e018cce1a7c6","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"add a value that contains a comma, and a value that contains an =\r\n","created_at":"2016-04-07T15:38:38Z","updated_at":"2016-04-07T15:38:38Z","html_url":"https://github.com/openshift/source-to-image/pull/463#discussion_r58893653","pull_request_url":"https://api.github.com/repos/openshift/source-to-image/pulls/463","_links":{"self":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/comments/58893653"},"html":{"href":"https://github.com/openshift/source-to-image/pull/463#discussion_r58893653"},"pull_request":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/463"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/source-to-image/pulls/463","id":65607084,"html_url":"https://github.com/openshift/source-to-image/pull/463","diff_url":"https://github.com/openshift/source-to-image/pull/463.diff","patch_url":"https://github.com/openshift/source-to-image/pull/463.patch","issue_url":"https://api.github.com/repos/openshift/source-to-image/issues/463","number":463,"state":"open","locked":false,"title":"Use cobra for parsing multiple env variables","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"body":"Fixes: https://github.com/openshift/source-to-image/issues/417\r\n\r\n@bparees this one is tricky :-) Basically, you can specify a multiple environment variables, by providing multiple `-e FOO=BAR` flags. The syntax we supported before was that you can use something like: `-e FOO=BAR,TEST=FOO`. \r\n\r\nSo this is introducing a backward incompatible change. I wonder if we want to make it backward compatible (basically do additional string.Split() in the `Set()` function) or leave it as this (which is consistent with other flags).","created_at":"2016-04-07T10:27:47Z","updated_at":"2016-04-07T15:38:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa532246cd834f01f3fe618b432adf4d91fdc0eb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/source-to-image/pulls/463/commits","review_comments_url":"https://api.github.com/repos/openshift/source-to-image/pulls/463/comments","review_comment_url":"https://api.github.com/repos/openshift/source-to-image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/source-to-image/issues/463/comments","statuses_url":"https://api.github.com/repos/openshift/source-to-image/statuses/aea49660c413f90e0fb051cc9e97e018cce1a7c6","head":{"label":"mfojtik:env","ref":"env","sha":"aea49660c413f90e0fb051cc9e97e018cce1a7c6","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"repo":{"id":26119317,"name":"source-to-image","full_name":"mfojtik/source-to-image","owner":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfojtik/source-to-image","description":"A tool for building/building artifacts from source and injecting into docker images","fork":true,"url":"https://api.github.com/repos/mfojtik/source-to-image","forks_url":"https://api.github.com/repos/mfojtik/source-to-image/forks","keys_url":"https://api.github.com/repos/mfojtik/source-to-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfojtik/source-to-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfojtik/source-to-image/teams","hooks_url":"https://api.github.com/repos/mfojtik/source-to-image/hooks","issue_events_url":"https://api.github.com/repos/mfojtik/source-to-image/issues/events{/number}","events_url":"https://api.github.com/repos/mfojtik/source-to-image/events","assignees_url":"https://api.github.com/repos/mfojtik/source-to-image/assignees{/user}","branches_url":"https://api.github.com/repos/mfojtik/source-to-image/branches{/branch}","tags_url":"https://api.github.com/repos/mfojtik/source-to-image/tags","blobs_url":"https://api.github.com/repos/mfojtik/source-to-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfojtik/source-to-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfojtik/source-to-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfojtik/source-to-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfojtik/source-to-image/statuses/{sha}","languages_url":"https://api.github.com/repos/mfojtik/source-to-image/languages","stargazers_url":"https://api.github.com/repos/mfojtik/source-to-image/stargazers","contributors_url":"https://api.github.com/repos/mfojtik/source-to-image/contributors","subscribers_url":"https://api.github.com/repos/mfojtik/source-to-image/subscribers","subscription_url":"https://api.github.com/repos/mfojtik/source-to-image/subscription","commits_url":"https://api.github.com/repos/mfojtik/source-to-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfojtik/source-to-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfojtik/source-to-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfojtik/source-to-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfojtik/source-to-image/contents/{+path}","compare_url":"https://api.github.com/repos/mfojtik/source-to-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfojtik/source-to-image/merges","archive_url":"https://api.github.com/repos/mfojtik/source-to-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfojtik/source-to-image/downloads","issues_url":"https://api.github.com/repos/mfojtik/source-to-image/issues{/number}","pulls_url":"https://api.github.com/repos/mfojtik/source-to-image/pulls{/number}","milestones_url":"https://api.github.com/repos/mfojtik/source-to-image/milestones{/number}","notifications_url":"https://api.github.com/repos/mfojtik/source-to-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfojtik/source-to-image/labels{/name}","releases_url":"https://api.github.com/repos/mfojtik/source-to-image/releases{/id}","deployments_url":"https://api.github.com/repos/mfojtik/source-to-image/deployments","created_at":"2014-11-03T13:18:28Z","updated_at":"2016-01-12T09:37:57Z","pushed_at":"2016-04-07T15:04:40Z","git_url":"git://github.com/mfojtik/source-to-image.git","ssh_url":"git@github.com:mfojtik/source-to-image.git","clone_url":"https://github.com/mfojtik/source-to-image.git","svn_url":"https://github.com/mfojtik/source-to-image","homepage":"","size":2795,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"79dfe89e9db0245918ba935c654ced14a1f86bed","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":16323162,"name":"source-to-image","full_name":"openshift/source-to-image","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/source-to-image","description":"A tool for building/building artifacts from source and injecting into docker images","fork":false,"url":"https://api.github.com/repos/openshift/source-to-image","forks_url":"https://api.github.com/repos/openshift/source-to-image/forks","keys_url":"https://api.github.com/repos/openshift/source-to-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/source-to-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/source-to-image/teams","hooks_url":"https://api.github.com/repos/openshift/source-to-image/hooks","issue_events_url":"https://api.github.com/repos/openshift/source-to-image/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/source-to-image/events","assignees_url":"https://api.github.com/repos/openshift/source-to-image/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/source-to-image/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/source-to-image/tags","blobs_url":"https://api.github.com/repos/openshift/source-to-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/source-to-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/source-to-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/source-to-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/source-to-image/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/source-to-image/languages","stargazers_url":"https://api.github.com/repos/openshift/source-to-image/stargazers","contributors_url":"https://api.github.com/repos/openshift/source-to-image/contributors","subscribers_url":"https://api.github.com/repos/openshift/source-to-image/subscribers","subscription_url":"https://api.github.com/repos/openshift/source-to-image/subscription","commits_url":"https://api.github.com/repos/openshift/source-to-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/source-to-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/source-to-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/source-to-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/source-to-image/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/source-to-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/source-to-image/merges","archive_url":"https://api.github.com/repos/openshift/source-to-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/source-to-image/downloads","issues_url":"https://api.github.com/repos/openshift/source-to-image/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/source-to-image/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/source-to-image/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/source-to-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/source-to-image/labels{/name}","releases_url":"https://api.github.com/repos/openshift/source-to-image/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/source-to-image/deployments","created_at":"2014-01-28T19:32:40Z","updated_at":"2016-04-07T09:17:07Z","pushed_at":"2016-04-07T15:04:41Z","git_url":"git://github.com/openshift/source-to-image.git","ssh_url":"git@github.com:openshift/source-to-image.git","clone_url":"https://github.com/openshift/source-to-image.git","svn_url":"https://github.com/openshift/source-to-image","homepage":"","size":2415,"stargazers_count":213,"watchers_count":213,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":98,"mirror_url":null,"open_issues_count":21,"forks":98,"open_issues":21,"watchers":213,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/463"},"html":{"href":"https://github.com/openshift/source-to-image/pull/463"},"issue":{"href":"https://api.github.com/repos/openshift/source-to-image/issues/463"},"comments":{"href":"https://api.github.com/repos/openshift/source-to-image/issues/463/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/463/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/463/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/source-to-image/statuses/aea49660c413f90e0fb051cc9e97e018cce1a7c6"}}}}