{"action":"created","comment":{"url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments/58988068","id":58988068,"diff_hunk":"@@ -317,6 +317,56 @@ def disable_xray_lines(self):\n         \"\"\"\n         for component in self._active_xray_lines:\n             component.active = False\n+    def fit(self, fitter='mpfit', method='ls', grad=False,","path":"hyperspy/models/edsmodel.py","position":4,"original_position":4,"commit_id":"341ed0a5dbe75b1811bf2d089b283e073beba80d","original_commit_id":"341ed0a5dbe75b1811bf2d089b283e073beba80d","user":{"login":"francisco-dlp","id":989719,"avatar_url":"https://avatars.githubusercontent.com/u/989719?v=3","gravatar_id":"","url":"https://api.github.com/users/francisco-dlp","html_url":"https://github.com/francisco-dlp","followers_url":"https://api.github.com/users/francisco-dlp/followers","following_url":"https://api.github.com/users/francisco-dlp/following{/other_user}","gists_url":"https://api.github.com/users/francisco-dlp/gists{/gist_id}","starred_url":"https://api.github.com/users/francisco-dlp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francisco-dlp/subscriptions","organizations_url":"https://api.github.com/users/francisco-dlp/orgs","repos_url":"https://api.github.com/users/francisco-dlp/repos","events_url":"https://api.github.com/users/francisco-dlp/events{/privacy}","received_events_url":"https://api.github.com/users/francisco-dlp/received_events","type":"User","site_admin":false},"body":"If all the components of the model have components with the gradients defined (`Gaussian` does), we may consider setting `grad=True` as this should speed things up.","created_at":"2016-04-08T07:18:01Z","updated_at":"2016-04-08T07:18:01Z","html_url":"https://github.com/hyperspy/hyperspy/pull/946#discussion_r58988068","pull_request_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/946","_links":{"self":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments/58988068"},"html":{"href":"https://github.com/hyperspy/hyperspy/pull/946#discussion_r58988068"},"pull_request":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/946"}}},"pull_request":{"url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/946","id":65665032,"html_url":"https://github.com/hyperspy/hyperspy/pull/946","diff_url":"https://github.com/hyperspy/hyperspy/pull/946.diff","patch_url":"https://github.com/hyperspy/hyperspy/pull/946.patch","issue_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/946","number":946,"state":"open","locked":false,"title":"ENH: Force EDS Model to be positive by default","user":{"login":"dnjohnstone","id":10629656,"avatar_url":"https://avatars.githubusercontent.com/u/10629656?v=3","gravatar_id":"","url":"https://api.github.com/users/dnjohnstone","html_url":"https://github.com/dnjohnstone","followers_url":"https://api.github.com/users/dnjohnstone/followers","following_url":"https://api.github.com/users/dnjohnstone/following{/other_user}","gists_url":"https://api.github.com/users/dnjohnstone/gists{/gist_id}","starred_url":"https://api.github.com/users/dnjohnstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnjohnstone/subscriptions","organizations_url":"https://api.github.com/users/dnjohnstone/orgs","repos_url":"https://api.github.com/users/dnjohnstone/repos","events_url":"https://api.github.com/users/dnjohnstone/events{/privacy}","received_events_url":"https://api.github.com/users/dnjohnstone/received_events","type":"User","site_admin":false},"body":"To address #884 ","created_at":"2016-04-07T17:04:36Z","updated_at":"2016-04-08T07:18:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68d5977742498e66dac517735c85751f68ed9a9d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/946/commits","review_comments_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/946/comments","review_comment_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/946/comments","statuses_url":"https://api.github.com/repos/hyperspy/hyperspy/statuses/341ed0a5dbe75b1811bf2d089b283e073beba80d","head":{"label":"dnjohnstone:ENH_ForcePositiveEDXModel","ref":"ENH_ForcePositiveEDXModel","sha":"341ed0a5dbe75b1811bf2d089b283e073beba80d","user":{"login":"dnjohnstone","id":10629656,"avatar_url":"https://avatars.githubusercontent.com/u/10629656?v=3","gravatar_id":"","url":"https://api.github.com/users/dnjohnstone","html_url":"https://github.com/dnjohnstone","followers_url":"https://api.github.com/users/dnjohnstone/followers","following_url":"https://api.github.com/users/dnjohnstone/following{/other_user}","gists_url":"https://api.github.com/users/dnjohnstone/gists{/gist_id}","starred_url":"https://api.github.com/users/dnjohnstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnjohnstone/subscriptions","organizations_url":"https://api.github.com/users/dnjohnstone/orgs","repos_url":"https://api.github.com/users/dnjohnstone/repos","events_url":"https://api.github.com/users/dnjohnstone/events{/privacy}","received_events_url":"https://api.github.com/users/dnjohnstone/received_events","type":"User","site_admin":false},"repo":{"id":29680132,"name":"hyperspy","full_name":"dnjohnstone/hyperspy","owner":{"login":"dnjohnstone","id":10629656,"avatar_url":"https://avatars.githubusercontent.com/u/10629656?v=3","gravatar_id":"","url":"https://api.github.com/users/dnjohnstone","html_url":"https://github.com/dnjohnstone","followers_url":"https://api.github.com/users/dnjohnstone/followers","following_url":"https://api.github.com/users/dnjohnstone/following{/other_user}","gists_url":"https://api.github.com/users/dnjohnstone/gists{/gist_id}","starred_url":"https://api.github.com/users/dnjohnstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnjohnstone/subscriptions","organizations_url":"https://api.github.com/users/dnjohnstone/orgs","repos_url":"https://api.github.com/users/dnjohnstone/repos","events_url":"https://api.github.com/users/dnjohnstone/events{/privacy}","received_events_url":"https://api.github.com/users/dnjohnstone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dnjohnstone/hyperspy","description":"Multidimensional data analysis","fork":true,"url":"https://api.github.com/repos/dnjohnstone/hyperspy","forks_url":"https://api.github.com/repos/dnjohnstone/hyperspy/forks","keys_url":"https://api.github.com/repos/dnjohnstone/hyperspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnjohnstone/hyperspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnjohnstone/hyperspy/teams","hooks_url":"https://api.github.com/repos/dnjohnstone/hyperspy/hooks","issue_events_url":"https://api.github.com/repos/dnjohnstone/hyperspy/issues/events{/number}","events_url":"https://api.github.com/repos/dnjohnstone/hyperspy/events","assignees_url":"https://api.github.com/repos/dnjohnstone/hyperspy/assignees{/user}","branches_url":"https://api.github.com/repos/dnjohnstone/hyperspy/branches{/branch}","tags_url":"https://api.github.com/repos/dnjohnstone/hyperspy/tags","blobs_url":"https://api.github.com/repos/dnjohnstone/hyperspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnjohnstone/hyperspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnjohnstone/hyperspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnjohnstone/hyperspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnjohnstone/hyperspy/statuses/{sha}","languages_url":"https://api.github.com/repos/dnjohnstone/hyperspy/languages","stargazers_url":"https://api.github.com/repos/dnjohnstone/hyperspy/stargazers","contributors_url":"https://api.github.com/repos/dnjohnstone/hyperspy/contributors","subscribers_url":"https://api.github.com/repos/dnjohnstone/hyperspy/subscribers","subscription_url":"https://api.github.com/repos/dnjohnstone/hyperspy/subscription","commits_url":"https://api.github.com/repos/dnjohnstone/hyperspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnjohnstone/hyperspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnjohnstone/hyperspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnjohnstone/hyperspy/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnjohnstone/hyperspy/contents/{+path}","compare_url":"https://api.github.com/repos/dnjohnstone/hyperspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnjohnstone/hyperspy/merges","archive_url":"https://api.github.com/repos/dnjohnstone/hyperspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnjohnstone/hyperspy/downloads","issues_url":"https://api.github.com/repos/dnjohnstone/hyperspy/issues{/number}","pulls_url":"https://api.github.com/repos/dnjohnstone/hyperspy/pulls{/number}","milestones_url":"https://api.github.com/repos/dnjohnstone/hyperspy/milestones{/number}","notifications_url":"https://api.github.com/repos/dnjohnstone/hyperspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnjohnstone/hyperspy/labels{/name}","releases_url":"https://api.github.com/repos/dnjohnstone/hyperspy/releases{/id}","deployments_url":"https://api.github.com/repos/dnjohnstone/hyperspy/deployments","created_at":"2015-01-22T13:34:00Z","updated_at":"2016-01-19T10:20:12Z","pushed_at":"2016-04-07T17:03:29Z","git_url":"git://github.com/dnjohnstone/hyperspy.git","ssh_url":"git@github.com:dnjohnstone/hyperspy.git","clone_url":"https://github.com/dnjohnstone/hyperspy.git","svn_url":"https://github.com/dnjohnstone/hyperspy","homepage":"http://www.hyperspy.org","size":77211,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperspy:master","ref":"master","sha":"9336e19723ea13f6678d1e0c0f9a92cc00861746","user":{"login":"hyperspy","id":989756,"avatar_url":"https://avatars.githubusercontent.com/u/989756?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperspy","html_url":"https://github.com/hyperspy","followers_url":"https://api.github.com/users/hyperspy/followers","following_url":"https://api.github.com/users/hyperspy/following{/other_user}","gists_url":"https://api.github.com/users/hyperspy/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperspy/subscriptions","organizations_url":"https://api.github.com/users/hyperspy/orgs","repos_url":"https://api.github.com/users/hyperspy/repos","events_url":"https://api.github.com/users/hyperspy/events{/privacy}","received_events_url":"https://api.github.com/users/hyperspy/received_events","type":"Organization","site_admin":false},"repo":{"id":2233998,"name":"hyperspy","full_name":"hyperspy/hyperspy","owner":{"login":"hyperspy","id":989756,"avatar_url":"https://avatars.githubusercontent.com/u/989756?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperspy","html_url":"https://github.com/hyperspy","followers_url":"https://api.github.com/users/hyperspy/followers","following_url":"https://api.github.com/users/hyperspy/following{/other_user}","gists_url":"https://api.github.com/users/hyperspy/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperspy/subscriptions","organizations_url":"https://api.github.com/users/hyperspy/orgs","repos_url":"https://api.github.com/users/hyperspy/repos","events_url":"https://api.github.com/users/hyperspy/events{/privacy}","received_events_url":"https://api.github.com/users/hyperspy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperspy/hyperspy","description":"Multidimensional data analysis","fork":false,"url":"https://api.github.com/repos/hyperspy/hyperspy","forks_url":"https://api.github.com/repos/hyperspy/hyperspy/forks","keys_url":"https://api.github.com/repos/hyperspy/hyperspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperspy/hyperspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperspy/hyperspy/teams","hooks_url":"https://api.github.com/repos/hyperspy/hyperspy/hooks","issue_events_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/events{/number}","events_url":"https://api.github.com/repos/hyperspy/hyperspy/events","assignees_url":"https://api.github.com/repos/hyperspy/hyperspy/assignees{/user}","branches_url":"https://api.github.com/repos/hyperspy/hyperspy/branches{/branch}","tags_url":"https://api.github.com/repos/hyperspy/hyperspy/tags","blobs_url":"https://api.github.com/repos/hyperspy/hyperspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperspy/hyperspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperspy/hyperspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperspy/hyperspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperspy/hyperspy/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperspy/hyperspy/languages","stargazers_url":"https://api.github.com/repos/hyperspy/hyperspy/stargazers","contributors_url":"https://api.github.com/repos/hyperspy/hyperspy/contributors","subscribers_url":"https://api.github.com/repos/hyperspy/hyperspy/subscribers","subscription_url":"https://api.github.com/repos/hyperspy/hyperspy/subscription","commits_url":"https://api.github.com/repos/hyperspy/hyperspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperspy/hyperspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperspy/hyperspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperspy/hyperspy/contents/{+path}","compare_url":"https://api.github.com/repos/hyperspy/hyperspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperspy/hyperspy/merges","archive_url":"https://api.github.com/repos/hyperspy/hyperspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperspy/hyperspy/downloads","issues_url":"https://api.github.com/repos/hyperspy/hyperspy/issues{/number}","pulls_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperspy/hyperspy/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperspy/hyperspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperspy/hyperspy/labels{/name}","releases_url":"https://api.github.com/repos/hyperspy/hyperspy/releases{/id}","deployments_url":"https://api.github.com/repos/hyperspy/hyperspy/deployments","created_at":"2011-08-19T13:14:36Z","updated_at":"2016-02-03T08:59:10Z","pushed_at":"2016-04-07T20:02:02Z","git_url":"git://github.com/hyperspy/hyperspy.git","ssh_url":"git@github.com:hyperspy/hyperspy.git","clone_url":"https://github.com/hyperspy/hyperspy.git","svn_url":"https://github.com/hyperspy/hyperspy","homepage":"http://www.hyperspy.org","size":87213,"stargazers_count":52,"watchers_count":52,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":144,"forks":41,"open_issues":144,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/946"},"html":{"href":"https://github.com/hyperspy/hyperspy/pull/946"},"issue":{"href":"https://api.github.com/repos/hyperspy/hyperspy/issues/946"},"comments":{"href":"https://api.github.com/repos/hyperspy/hyperspy/issues/946/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/946/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/946/commits"},"statuses":{"href":"https://api.github.com/repos/hyperspy/hyperspy/statuses/341ed0a5dbe75b1811bf2d089b283e073beba80d"}}}}