{"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/acquia/waterwheel/pulls/28","id":79851119,"html_url":"https://github.com/acquia/waterwheel/pull/28","diff_url":"https://github.com/acquia/waterwheel/pull/28.diff","patch_url":"https://github.com/acquia/waterwheel/pull/28.patch","issue_url":"https://api.github.com/repos/acquia/waterwheel/issues/28","number":28,"state":"closed","locked":false,"title":"Prepublish build","user":{"login":"infiniteluke","id":1127238,"avatar_url":"https://avatars.githubusercontent.com/u/1127238?v=3","gravatar_id":"","url":"https://api.github.com/users/infiniteluke","html_url":"https://github.com/infiniteluke","followers_url":"https://api.github.com/users/infiniteluke/followers","following_url":"https://api.github.com/users/infiniteluke/following{/other_user}","gists_url":"https://api.github.com/users/infiniteluke/gists{/gist_id}","starred_url":"https://api.github.com/users/infiniteluke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infiniteluke/subscriptions","organizations_url":"https://api.github.com/users/infiniteluke/orgs","repos_url":"https://api.github.com/users/infiniteluke/repos","events_url":"https://api.github.com/users/infiniteluke/events{/privacy}","received_events_url":"https://api.github.com/users/infiniteluke/received_events","type":"User","site_admin":false},"body":"Turns out acquia/waterwheel/pull/21 with `prepublish` was the right approach after all. \r\n\r\nFrom acquia/waterwheel/pull/21\r\n> Npm provides a prepublish script that allows commands to be run before publishing and upon a local npm i. I suggest adding the build command so that browser users can import dist/waterwheel.js without requiring the manual npm run build. .npmignore is required since dist/waterwheel.js is explicitly ignored in .gitignore (which prepublish falls back to).\r\n\r\nAddresses acquia/waterwheel/issues/27","created_at":"2016-08-03T05:45:16Z","updated_at":"2016-08-03T14:44:33Z","closed_at":"2016-08-03T14:44:33Z","merged_at":null,"merge_commit_sha":"14193fe0b6bcb24b662ab51bafae37971b713843","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/acquia/waterwheel/pulls/28/commits","review_comments_url":"https://api.github.com/repos/acquia/waterwheel/pulls/28/comments","review_comment_url":"https://api.github.com/repos/acquia/waterwheel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/acquia/waterwheel/issues/28/comments","statuses_url":"https://api.github.com/repos/acquia/waterwheel/statuses/df4787db7225efafb6c9c8be342322dc882f3cde","head":{"label":"infiniteluke:prepublish-build","ref":"prepublish-build","sha":"df4787db7225efafb6c9c8be342322dc882f3cde","user":{"login":"infiniteluke","id":1127238,"avatar_url":"https://avatars.githubusercontent.com/u/1127238?v=3","gravatar_id":"","url":"https://api.github.com/users/infiniteluke","html_url":"https://github.com/infiniteluke","followers_url":"https://api.github.com/users/infiniteluke/followers","following_url":"https://api.github.com/users/infiniteluke/following{/other_user}","gists_url":"https://api.github.com/users/infiniteluke/gists{/gist_id}","starred_url":"https://api.github.com/users/infiniteluke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infiniteluke/subscriptions","organizations_url":"https://api.github.com/users/infiniteluke/orgs","repos_url":"https://api.github.com/users/infiniteluke/repos","events_url":"https://api.github.com/users/infiniteluke/events{/privacy}","received_events_url":"https://api.github.com/users/infiniteluke/received_events","type":"User","site_admin":false},"repo":{"id":64037633,"name":"waterwheel","full_name":"infiniteluke/waterwheel","owner":{"login":"infiniteluke","id":1127238,"avatar_url":"https://avatars.githubusercontent.com/u/1127238?v=3","gravatar_id":"","url":"https://api.github.com/users/infiniteluke","html_url":"https://github.com/infiniteluke","followers_url":"https://api.github.com/users/infiniteluke/followers","following_url":"https://api.github.com/users/infiniteluke/following{/other_user}","gists_url":"https://api.github.com/users/infiniteluke/gists{/gist_id}","starred_url":"https://api.github.com/users/infiniteluke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infiniteluke/subscriptions","organizations_url":"https://api.github.com/users/infiniteluke/orgs","repos_url":"https://api.github.com/users/infiniteluke/repos","events_url":"https://api.github.com/users/infiniteluke/events{/privacy}","received_events_url":"https://api.github.com/users/infiniteluke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/infiniteluke/waterwheel","description":"A generic JavaScript helper library to query and manipulate Drupal 8 via core REST","fork":true,"url":"https://api.github.com/repos/infiniteluke/waterwheel","forks_url":"https://api.github.com/repos/infiniteluke/waterwheel/forks","keys_url":"https://api.github.com/repos/infiniteluke/waterwheel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infiniteluke/waterwheel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infiniteluke/waterwheel/teams","hooks_url":"https://api.github.com/repos/infiniteluke/waterwheel/hooks","issue_events_url":"https://api.github.com/repos/infiniteluke/waterwheel/issues/events{/number}","events_url":"https://api.github.com/repos/infiniteluke/waterwheel/events","assignees_url":"https://api.github.com/repos/infiniteluke/waterwheel/assignees{/user}","branches_url":"https://api.github.com/repos/infiniteluke/waterwheel/branches{/branch}","tags_url":"https://api.github.com/repos/infiniteluke/waterwheel/tags","blobs_url":"https://api.github.com/repos/infiniteluke/waterwheel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infiniteluke/waterwheel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infiniteluke/waterwheel/git/refs{/sha}","trees_url":"https://api.github.com/repos/infiniteluke/waterwheel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infiniteluke/waterwheel/statuses/{sha}","languages_url":"https://api.github.com/repos/infiniteluke/waterwheel/languages","stargazers_url":"https://api.github.com/repos/infiniteluke/waterwheel/stargazers","contributors_url":"https://api.github.com/repos/infiniteluke/waterwheel/contributors","subscribers_url":"https://api.github.com/repos/infiniteluke/waterwheel/subscribers","subscription_url":"https://api.github.com/repos/infiniteluke/waterwheel/subscription","commits_url":"https://api.github.com/repos/infiniteluke/waterwheel/commits{/sha}","git_commits_url":"https://api.github.com/repos/infiniteluke/waterwheel/git/commits{/sha}","comments_url":"https://api.github.com/repos/infiniteluke/waterwheel/comments{/number}","issue_comment_url":"https://api.github.com/repos/infiniteluke/waterwheel/issues/comments{/number}","contents_url":"https://api.github.com/repos/infiniteluke/waterwheel/contents/{+path}","compare_url":"https://api.github.com/repos/infiniteluke/waterwheel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infiniteluke/waterwheel/merges","archive_url":"https://api.github.com/repos/infiniteluke/waterwheel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infiniteluke/waterwheel/downloads","issues_url":"https://api.github.com/repos/infiniteluke/waterwheel/issues{/number}","pulls_url":"https://api.github.com/repos/infiniteluke/waterwheel/pulls{/number}","milestones_url":"https://api.github.com/repos/infiniteluke/waterwheel/milestones{/number}","notifications_url":"https://api.github.com/repos/infiniteluke/waterwheel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infiniteluke/waterwheel/labels{/name}","releases_url":"https://api.github.com/repos/infiniteluke/waterwheel/releases{/id}","deployments_url":"https://api.github.com/repos/infiniteluke/waterwheel/deployments","created_at":"2016-07-23T21:56:26Z","updated_at":"2016-07-23T21:56:27Z","pushed_at":"2016-08-03T05:45:09Z","git_url":"git://github.com/infiniteluke/waterwheel.git","ssh_url":"git@github.com:infiniteluke/waterwheel.git","clone_url":"https://github.com/infiniteluke/waterwheel.git","svn_url":"https://github.com/infiniteluke/waterwheel","homepage":"https://github.com/acquia/waterwheel","size":102,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.6.0"}},"base":{"label":"acquia:0.7.0","ref":"0.7.0","sha":"82031f066683a2229cbecaae662534031d5b8f5e","user":{"login":"acquia","id":514789,"avatar_url":"https://avatars.githubusercontent.com/u/514789?v=3","gravatar_id":"","url":"https://api.github.com/users/acquia","html_url":"https://github.com/acquia","followers_url":"https://api.github.com/users/acquia/followers","following_url":"https://api.github.com/users/acquia/following{/other_user}","gists_url":"https://api.github.com/users/acquia/gists{/gist_id}","starred_url":"https://api.github.com/users/acquia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquia/subscriptions","organizations_url":"https://api.github.com/users/acquia/orgs","repos_url":"https://api.github.com/users/acquia/repos","events_url":"https://api.github.com/users/acquia/events{/privacy}","received_events_url":"https://api.github.com/users/acquia/received_events","type":"Organization","site_admin":false},"repo":{"id":59674985,"name":"waterwheel","full_name":"acquia/waterwheel","owner":{"login":"acquia","id":514789,"avatar_url":"https://avatars.githubusercontent.com/u/514789?v=3","gravatar_id":"","url":"https://api.github.com/users/acquia","html_url":"https://github.com/acquia","followers_url":"https://api.github.com/users/acquia/followers","following_url":"https://api.github.com/users/acquia/following{/other_user}","gists_url":"https://api.github.com/users/acquia/gists{/gist_id}","starred_url":"https://api.github.com/users/acquia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquia/subscriptions","organizations_url":"https://api.github.com/users/acquia/orgs","repos_url":"https://api.github.com/users/acquia/repos","events_url":"https://api.github.com/users/acquia/events{/privacy}","received_events_url":"https://api.github.com/users/acquia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acquia/waterwheel","description":"A generic JavaScript helper library to query and manipulate Drupal 8 via core REST","fork":false,"url":"https://api.github.com/repos/acquia/waterwheel","forks_url":"https://api.github.com/repos/acquia/waterwheel/forks","keys_url":"https://api.github.com/repos/acquia/waterwheel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acquia/waterwheel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acquia/waterwheel/teams","hooks_url":"https://api.github.com/repos/acquia/waterwheel/hooks","issue_events_url":"https://api.github.com/repos/acquia/waterwheel/issues/events{/number}","events_url":"https://api.github.com/repos/acquia/waterwheel/events","assignees_url":"https://api.github.com/repos/acquia/waterwheel/assignees{/user}","branches_url":"https://api.github.com/repos/acquia/waterwheel/branches{/branch}","tags_url":"https://api.github.com/repos/acquia/waterwheel/tags","blobs_url":"https://api.github.com/repos/acquia/waterwheel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acquia/waterwheel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acquia/waterwheel/git/refs{/sha}","trees_url":"https://api.github.com/repos/acquia/waterwheel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acquia/waterwheel/statuses/{sha}","languages_url":"https://api.github.com/repos/acquia/waterwheel/languages","stargazers_url":"https://api.github.com/repos/acquia/waterwheel/stargazers","contributors_url":"https://api.github.com/repos/acquia/waterwheel/contributors","subscribers_url":"https://api.github.com/repos/acquia/waterwheel/subscribers","subscription_url":"https://api.github.com/repos/acquia/waterwheel/subscription","commits_url":"https://api.github.com/repos/acquia/waterwheel/commits{/sha}","git_commits_url":"https://api.github.com/repos/acquia/waterwheel/git/commits{/sha}","comments_url":"https://api.github.com/repos/acquia/waterwheel/comments{/number}","issue_comment_url":"https://api.github.com/repos/acquia/waterwheel/issues/comments{/number}","contents_url":"https://api.github.com/repos/acquia/waterwheel/contents/{+path}","compare_url":"https://api.github.com/repos/acquia/waterwheel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acquia/waterwheel/merges","archive_url":"https://api.github.com/repos/acquia/waterwheel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acquia/waterwheel/downloads","issues_url":"https://api.github.com/repos/acquia/waterwheel/issues{/number}","pulls_url":"https://api.github.com/repos/acquia/waterwheel/pulls{/number}","milestones_url":"https://api.github.com/repos/acquia/waterwheel/milestones{/number}","notifications_url":"https://api.github.com/repos/acquia/waterwheel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acquia/waterwheel/labels{/name}","releases_url":"https://api.github.com/repos/acquia/waterwheel/releases{/id}","deployments_url":"https://api.github.com/repos/acquia/waterwheel/deployments","created_at":"2016-05-25T15:28:05Z","updated_at":"2016-07-26T21:45:08Z","pushed_at":"2016-08-03T05:45:16Z","git_url":"git://github.com/acquia/waterwheel.git","ssh_url":"git@github.com:acquia/waterwheel.git","clone_url":"https://github.com/acquia/waterwheel.git","svn_url":"https://github.com/acquia/waterwheel","homepage":"https://github.com/acquia/waterwheel","size":113,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/acquia/waterwheel/pulls/28"},"html":{"href":"https://github.com/acquia/waterwheel/pull/28"},"issue":{"href":"https://api.github.com/repos/acquia/waterwheel/issues/28"},"comments":{"href":"https://api.github.com/repos/acquia/waterwheel/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/acquia/waterwheel/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/acquia/waterwheel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/acquia/waterwheel/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/acquia/waterwheel/statuses/df4787db7225efafb6c9c8be342322dc882f3cde"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":4,"additions":5,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"infiniteluke"}}