{"action":"created","issue":{"url":"https://api.github.com/repos/n-riesco/ijavascript/issues/84","repository_url":"https://api.github.com/repos/n-riesco/ijavascript","labels_url":"https://api.github.com/repos/n-riesco/ijavascript/issues/84/labels{/name}","comments_url":"https://api.github.com/repos/n-riesco/ijavascript/issues/84/comments","events_url":"https://api.github.com/repos/n-riesco/ijavascript/issues/84/events","html_url":"https://github.com/n-riesco/ijavascript/pull/84","id":180474468,"number":84,"title":"feat(bin): provide ijskernel as bin","user":{"login":"rgbkrk","id":836375,"avatar_url":"https://avatars.githubusercontent.com/u/836375?v=3","gravatar_id":"","url":"https://api.github.com/users/rgbkrk","html_url":"https://github.com/rgbkrk","followers_url":"https://api.github.com/users/rgbkrk/followers","following_url":"https://api.github.com/users/rgbkrk/following{/other_user}","gists_url":"https://api.github.com/users/rgbkrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rgbkrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgbkrk/subscriptions","organizations_url":"https://api.github.com/users/rgbkrk/orgs","repos_url":"https://api.github.com/users/rgbkrk/repos","events_url":"https://api.github.com/users/rgbkrk/events{/privacy}","received_events_url":"https://api.github.com/users/rgbkrk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-10-01T19:18:31Z","updated_at":"2016-11-10T09:51:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/n-riesco/ijavascript/pulls/84","html_url":"https://github.com/n-riesco/ijavascript/pull/84","diff_url":"https://github.com/n-riesco/ijavascript/pull/84.diff","patch_url":"https://github.com/n-riesco/ijavascript/pull/84.patch"},"body":"This makes it so that `ijskernel` can be used directly as a bin script, which makes my local kernel.json _much_ easier to work with when I'm changing node versions:\n\n``` json\n{\n  \"argv\": [\n    \"ijskernel\",\n    \"{connection_file}\",\n    \"--protocol=5.0\"\n  ],\n  \"display_name\": \"Javascript (Node.js)\",\n  \"language\": \"javascript\"\n}\n```\n\nFor me, this makes #67 much easier to deal with. _Now_, every time I upgrade node with `nvm`, I globally install `ijavascript` again and it _just works_ because it's not reliant on a hardcoded path to my node version + the library location.\n\nOn windows, the kernelspec is:\n\n``` json\n{\n  \"argv\": [\n    \"ijskernel.cmd\",\n    \"{connection_file}\",\n    \"--protocol=5.0\"\n  ],\n  \"display_name\": \"Javascript (Node.js)\",\n  \"language\": \"javascript\"\n}\n```\n\n/cc @thisgeek @c22 \n"},"comment":{"url":"https://api.github.com/repos/n-riesco/ijavascript/issues/comments/259646901","html_url":"https://github.com/n-riesco/ijavascript/pull/84#issuecomment-259646901","issue_url":"https://api.github.com/repos/n-riesco/ijavascript/issues/84","id":259646901,"user":{"login":"n-riesco","id":6199391,"avatar_url":"https://avatars.githubusercontent.com/u/6199391?v=3","gravatar_id":"","url":"https://api.github.com/users/n-riesco","html_url":"https://github.com/n-riesco","followers_url":"https://api.github.com/users/n-riesco/followers","following_url":"https://api.github.com/users/n-riesco/following{/other_user}","gists_url":"https://api.github.com/users/n-riesco/gists{/gist_id}","starred_url":"https://api.github.com/users/n-riesco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n-riesco/subscriptions","organizations_url":"https://api.github.com/users/n-riesco/orgs","repos_url":"https://api.github.com/users/n-riesco/repos","events_url":"https://api.github.com/users/n-riesco/events{/privacy}","received_events_url":"https://api.github.com/users/n-riesco/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T09:51:06Z","updated_at":"2016-11-10T09:51:06Z","body":"@rgbkrk To be clear, I'm not opposed to merging this PR. I'm only trying to avoid regressions.\r\n\r\nAfter some more thought, I don't think overloading the meaning of `--ijs-install=global` is a good a idea, because installing a kernel spec globally doesn't ensure the kernel binary has also been installed globally.\r\n\r\nThis is what I'm planning to do:\r\n\r\n1. Merge this PR.\r\n\r\n2. Revert 44c074\r\n\r\n3. Introduce the flag `--ijs-spec-path=[none|full]`. Since in README.md I'm recommending a global installation (`sudo npm install -g ijavascript`) and thus `--ijs-spec-path=none` should work, I'm planning to use `none` as a default.\r\n\r\nBefore I publish a new release, I'd like to hear any arguments against using `--ijs-spec-path=none` as a default.\r\n\r\nAt the moment, these are the only arguments I've thought of:\r\n\r\n- `--ijs-spec-path=none` doesn't work for local installations (i.e. `npm install ijavascript`)\r\n\r\n- `--ijs-spec-path=full` requires the re-installation of IJavascript's kernel spec (i.e. re-running `ijs`), whenever the location of `node` changes.\r\n"}}
{"actor":{"display_login":"n-riesco"}}