{"action":"created","issue":{"url":"https://api.github.com/repos/OpenBuildings/spiderling/issues/23","repository_url":"https://api.github.com/repos/OpenBuildings/spiderling","labels_url":"https://api.github.com/repos/OpenBuildings/spiderling/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/OpenBuildings/spiderling/issues/23/comments","events_url":"https://api.github.com/repos/OpenBuildings/spiderling/issues/23/events","html_url":"https://github.com/OpenBuildings/spiderling/issues/23","id":175205881,"number":23,"title":"Phantom Driver doesn't work","user":{"login":"MatneX","id":2006020,"avatar_url":"https://avatars.githubusercontent.com/u/2006020?v=3","gravatar_id":"","url":"https://api.github.com/users/MatneX","html_url":"https://github.com/MatneX","followers_url":"https://api.github.com/users/MatneX/followers","following_url":"https://api.github.com/users/MatneX/following{/other_user}","gists_url":"https://api.github.com/users/MatneX/gists{/gist_id}","starred_url":"https://api.github.com/users/MatneX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatneX/subscriptions","organizations_url":"https://api.github.com/users/MatneX/orgs","repos_url":"https://api.github.com/users/MatneX/repos","events_url":"https://api.github.com/users/MatneX/events{/privacy}","received_events_url":"https://api.github.com/users/MatneX/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/OpenBuildings/spiderling/labels/support","name":"support","color":"fad8c7"}],"state":"open","locked":false,"assignee":{"login":"EZarkov","id":7592650,"avatar_url":"https://avatars.githubusercontent.com/u/7592650?v=3","gravatar_id":"","url":"https://api.github.com/users/EZarkov","html_url":"https://github.com/EZarkov","followers_url":"https://api.github.com/users/EZarkov/followers","following_url":"https://api.github.com/users/EZarkov/following{/other_user}","gists_url":"https://api.github.com/users/EZarkov/gists{/gist_id}","starred_url":"https://api.github.com/users/EZarkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EZarkov/subscriptions","organizations_url":"https://api.github.com/users/EZarkov/orgs","repos_url":"https://api.github.com/users/EZarkov/repos","events_url":"https://api.github.com/users/EZarkov/events{/privacy}","received_events_url":"https://api.github.com/users/EZarkov/received_events","type":"User","site_admin":false},"assignees":[{"login":"EZarkov","id":7592650,"avatar_url":"https://avatars.githubusercontent.com/u/7592650?v=3","gravatar_id":"","url":"https://api.github.com/users/EZarkov","html_url":"https://github.com/EZarkov","followers_url":"https://api.github.com/users/EZarkov/followers","following_url":"https://api.github.com/users/EZarkov/following{/other_user}","gists_url":"https://api.github.com/users/EZarkov/gists{/gist_id}","starred_url":"https://api.github.com/users/EZarkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EZarkov/subscriptions","organizations_url":"https://api.github.com/users/EZarkov/orgs","repos_url":"https://api.github.com/users/EZarkov/repos","events_url":"https://api.github.com/users/EZarkov/events{/privacy}","received_events_url":"https://api.github.com/users/EZarkov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2016-09-06T09:52:27Z","updated_at":"2016-09-19T13:07:33Z","closed_at":null,"body":"First off all, the use of PhantomInstaller is good. But if you use this, why the driver doesn't  use it ???\r\n\r\nSolution:\r\nAdd to **public static function command** the following Lines:\r\n$binDir = '';\r\ntry {\r\n// try to use the phantominstaller binary\r\n$binDir = \\PhantomInstaller\\PhantomBinary::DIR.DIRECTORY_SEPARATOR;\r\n} catch (Exception $e) {\r\n}\r\nreturn $binDir.\"phantomjs --ignore-ssl-errors=true {$file} {$port} {$additional}\";\r\n\r\nThe next Problem is, the driver will lose the custom Port. So when i set the Port like you did in your example, it will be used for the first port/connection tests, but not for the last ones.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/OpenBuildings/spiderling/issues/comments/247987893","html_url":"https://github.com/OpenBuildings/spiderling/issues/23#issuecomment-247987893","issue_url":"https://api.github.com/repos/OpenBuildings/spiderling/issues/23","id":247987893,"user":{"login":"hkdobrev","id":506129,"avatar_url":"https://avatars.githubusercontent.com/u/506129?v=3","gravatar_id":"","url":"https://api.github.com/users/hkdobrev","html_url":"https://github.com/hkdobrev","followers_url":"https://api.github.com/users/hkdobrev/followers","following_url":"https://api.github.com/users/hkdobrev/following{/other_user}","gists_url":"https://api.github.com/users/hkdobrev/gists{/gist_id}","starred_url":"https://api.github.com/users/hkdobrev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkdobrev/subscriptions","organizations_url":"https://api.github.com/users/hkdobrev/orgs","repos_url":"https://api.github.com/users/hkdobrev/repos","events_url":"https://api.github.com/users/hkdobrev/events{/privacy}","received_events_url":"https://api.github.com/users/hkdobrev/received_events","type":"User","site_admin":false},"created_at":"2016-09-19T13:07:33Z","updated_at":"2016-09-19T13:07:33Z","body":"@halfer Thanks for the insight.\r\n\r\nActually @MatneX makes a valid point. The PhantomJS binary should be configurable. We are actually working on a simple new configuration which could be used to define a custom path to the binary.\r\n\r\n@EZarkov is working on that and should submit a PR in the next few days."}}
{"actor":{"display_login":"hkdobrev"}}