{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/81429457","pull_request_review_id":2412967,"id":81429457,"diff_hunk":"@@ -141,31 +141,19 @@\n           BeforeTargets=\"TestAllProjects\"\n           Condition=\"$(MSBuildProjectName.EndsWith('.Tests'))\">\n \n-    <PropertyGroup>\n-      <TestTFMSupportSet>$(FilterToTestTFM)</TestTFMSupportSet>\n-      <TestTFMSupportSet Condition=\"'$(FilterToTestTFM)'=='netcoreapp1.1'\">$(TestTFMSupportSet)|netcoreapp1.0</TestTFMSupportSet>\n-      <TestTFMSupportSet Condition=\"'$(FilterToTestTFM)'=='net461'\">$(TestTFMSupportSet)|net46</TestTFMSupportSet>\n-      <TestTFMSupportSet Condition=\"'$(FilterToTestTFM)'=='net462'\">$(TestTFMSupportSet)|net461|net46</TestTFMSupportSet>\n-      <TestTFMSupportSet Condition=\"'$(FilterToTestTFM)'=='net463'\">$(TestTFMSupportSet)|net462|net461|net46</TestTFMSupportSet>\n-    </PropertyGroup>\n-\n     <ItemGroup>\n       <Project>\n-        <!-- default to netcoreapp1.0.0 if TestTFMs aren't set on the project -->\n-        <TestTFMs Condition=\"'%(Project.TestTFMs)'==''\">netcoreapp1.0</TestTFMs>\n+        <!-- default to netcoreapp1.1 if TestTFMs aren't set on the project -->\n+        <TestTFMs Condition=\"'%(Project.TestTFMs)'==''\">netcoreapp1.1</TestTFMs>","path":"dir.traversal.targets","position":17,"original_position":17,"commit_id":"7fe9193a2fb1252e237a3d03b4fed77757ef04e7","original_commit_id":"7fe9193a2fb1252e237a3d03b4fed77757ef04e7","user":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":"Actually we might want to think about this one a little more (especially in cases where people actually set it at the commandline and it isn't the default) but I do still think it might make since to share a common property for the default. Perhaps we should create an independent \"DefaultTestTFM\" property and use that as the default in all these places. ","created_at":"2016-09-30T22:35:50Z","updated_at":"2016-09-30T22:35:50Z","html_url":"https://github.com/dotnet/corefx/pull/12241#discussion_r81429457","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/12241","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/81429457"},"html":{"href":"https://github.com/dotnet/corefx/pull/12241#discussion_r81429457"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/12241"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/12241","id":87535506,"html_url":"https://github.com/dotnet/corefx/pull/12241","diff_url":"https://github.com/dotnet/corefx/pull/12241.diff","patch_url":"https://github.com/dotnet/corefx/pull/12241.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/12241","number":12241,"state":"open","locked":false,"title":"Changing test projects to default to netcoreapp1.1 instead of netcoreapp1.0","user":{"login":"joperezr","id":13854455,"avatar_url":"https://avatars.githubusercontent.com/u/13854455?v=3","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"body":"Fixes #12129 \r\n\r\nThis change will make it such that netcoreapp1.1 will be the new default TestTFM for all projects, and it will also now only run the netcoreapp1.1 tests as part of the regular CI. One more thing I did with this change, is to make all of the test .csprojs to also default their nuget target moniker to netstandard1.7 if they were testing API that is specific to that framework, and I did this so that now all three (tests, refs, and impls) will have the same behavior and default to netstandard1.7 and x-compile only to older frameworks.\r\n\r\ncc: @weshaggard @ericstj @danmosemsft @stephentoub @karajas ","created_at":"2016-09-30T17:38:27Z","updated_at":"2016-09-30T22:35:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"695926077afcfd74026f1126795d94f1ec8fef6a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/12241/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/12241/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/12241/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/7fe9193a2fb1252e237a3d03b4fed77757ef04e7","head":{"label":"joperezr:DefaultToNetcoreapp11","ref":"DefaultToNetcoreapp11","sha":"7fe9193a2fb1252e237a3d03b4fed77757ef04e7","user":{"login":"joperezr","id":13854455,"avatar_url":"https://avatars.githubusercontent.com/u/13854455?v=3","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"repo":{"id":41888057,"name":"corefx","full_name":"joperezr/corefx","owner":{"login":"joperezr","id":13854455,"avatar_url":"https://avatars.githubusercontent.com/u/13854455?v=3","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joperezr/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/joperezr/corefx","forks_url":"https://api.github.com/repos/joperezr/corefx/forks","keys_url":"https://api.github.com/repos/joperezr/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joperezr/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joperezr/corefx/teams","hooks_url":"https://api.github.com/repos/joperezr/corefx/hooks","issue_events_url":"https://api.github.com/repos/joperezr/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/joperezr/corefx/events","assignees_url":"https://api.github.com/repos/joperezr/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/joperezr/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/joperezr/corefx/tags","blobs_url":"https://api.github.com/repos/joperezr/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joperezr/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joperezr/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/joperezr/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joperezr/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/joperezr/corefx/languages","stargazers_url":"https://api.github.com/repos/joperezr/corefx/stargazers","contributors_url":"https://api.github.com/repos/joperezr/corefx/contributors","subscribers_url":"https://api.github.com/repos/joperezr/corefx/subscribers","subscription_url":"https://api.github.com/repos/joperezr/corefx/subscription","commits_url":"https://api.github.com/repos/joperezr/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/joperezr/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/joperezr/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/joperezr/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/joperezr/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/joperezr/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joperezr/corefx/merges","archive_url":"https://api.github.com/repos/joperezr/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joperezr/corefx/downloads","issues_url":"https://api.github.com/repos/joperezr/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/joperezr/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/joperezr/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/joperezr/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joperezr/corefx/labels{/name}","releases_url":"https://api.github.com/repos/joperezr/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/joperezr/corefx/deployments","created_at":"2015-09-03T23:06:38Z","updated_at":"2016-01-12T19:38:17Z","pushed_at":"2016-09-30T22:35:17Z","git_url":"git://github.com/joperezr/corefx.git","ssh_url":"git@github.com:joperezr/corefx.git","clone_url":"https://github.com/joperezr/corefx.git","svn_url":"https://github.com/joperezr/corefx","homepage":"http://dotnet.github.io/core/","size":99708,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"5155f8e6032850e12bebd9c27a745c7c931020f9","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-09-30T21:53:52Z","pushed_at":"2016-09-30T22:24:55Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":145759,"stargazers_count":10584,"watchers_count":10584,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2646,"mirror_url":null,"open_issues_count":1531,"forks":2646,"open_issues":1531,"watchers":10584,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/12241"},"html":{"href":"https://github.com/dotnet/corefx/pull/12241"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/12241"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/12241/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/12241/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/12241/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/7fe9193a2fb1252e237a3d03b4fed77757ef04e7"}}}}
{"actor":{"display_login":"weshaggard"}}