{"action":"created","comment":{"url":"https://api.github.com/repos/internap/netman/pulls/comments/69490937","id":69490937,"diff_hunk":"@@ -215,15 +215,20 @@ def set_access_mode(self, interface_id):\n         if len(update_attributes) > 0:\n             update = Update()\n             update.add_interface(interface_update(interface_id, \"0\", update_attributes))\n-\n-            self._push(update)\n+            try:","path":"netman/adapters/switches/juniper/base.py","position":6,"original_position":6,"commit_id":"b0d47bc59e2a100e87436291e7b8c7135213ff0c","original_commit_id":"b0d47bc59e2a100e87436291e7b8c7135213ff0c","user":{"login":"lindycoder","id":12926519,"avatar_url":"https://avatars.githubusercontent.com/u/12926519?v=3","gravatar_id":"","url":"https://api.github.com/users/lindycoder","html_url":"https://github.com/lindycoder","followers_url":"https://api.github.com/users/lindycoder/followers","following_url":"https://api.github.com/users/lindycoder/following{/other_user}","gists_url":"https://api.github.com/users/lindycoder/gists{/gist_id}","starred_url":"https://api.github.com/users/lindycoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindycoder/subscriptions","organizations_url":"https://api.github.com/users/lindycoder/orgs","repos_url":"https://api.github.com/users/lindycoder/repos","events_url":"https://api.github.com/users/lindycoder/events{/privacy}","received_events_url":"https://api.github.com/users/lindycoder/received_events","type":"User","site_admin":false},"body":"can you put this try except in a _push_interface_update that would always handle the interface not found error?","created_at":"2016-07-04T20:53:54Z","updated_at":"2016-07-04T20:53:54Z","html_url":"https://github.com/internap/netman/pull/154#discussion_r69490937","pull_request_url":"https://api.github.com/repos/internap/netman/pulls/154","_links":{"self":{"href":"https://api.github.com/repos/internap/netman/pulls/comments/69490937"},"html":{"href":"https://github.com/internap/netman/pull/154#discussion_r69490937"},"pull_request":{"href":"https://api.github.com/repos/internap/netman/pulls/154"}}},"pull_request":{"url":"https://api.github.com/repos/internap/netman/pulls/154","id":76198219,"html_url":"https://github.com/internap/netman/pull/154","diff_url":"https://github.com/internap/netman/pull/154.diff","patch_url":"https://github.com/internap/netman/pull/154.patch","issue_url":"https://api.github.com/repos/internap/netman/issues/154","number":154,"state":"open","locked":false,"title":"Juniper methods support defaulted interfaces","user":{"login":"fbouliane","id":1572444,"avatar_url":"https://avatars.githubusercontent.com/u/1572444?v=3","gravatar_id":"","url":"https://api.github.com/users/fbouliane","html_url":"https://github.com/fbouliane","followers_url":"https://api.github.com/users/fbouliane/followers","following_url":"https://api.github.com/users/fbouliane/following{/other_user}","gists_url":"https://api.github.com/users/fbouliane/gists{/gist_id}","starred_url":"https://api.github.com/users/fbouliane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbouliane/subscriptions","organizations_url":"https://api.github.com/users/fbouliane/orgs","repos_url":"https://api.github.com/users/fbouliane/repos","events_url":"https://api.github.com/users/fbouliane/events{/privacy}","received_events_url":"https://api.github.com/users/fbouliane/received_events","type":"User","site_admin":false},"body":"The behavior of juniper switches when the configuration is default\r\nis to return no configuration node when querying. The new fake switches\r\n1.0.29 introduce this change of behavior. This prepares the terrain for\r\nthis new version.\r\n\r\nAdd test so netman supports default configuration on all methods.\r\nAdd test so netman still raises on Unknown interface on a per-method\r\nbasis.","created_at":"2016-07-04T20:26:00Z","updated_at":"2016-07-04T20:53:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a08b0d16e76538198203a74799e0d9af04e1b899","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/internap/netman/pulls/154/commits","review_comments_url":"https://api.github.com/repos/internap/netman/pulls/154/comments","review_comment_url":"https://api.github.com/repos/internap/netman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/internap/netman/issues/154/comments","statuses_url":"https://api.github.com/repos/internap/netman/statuses/b0d47bc59e2a100e87436291e7b8c7135213ff0c","head":{"label":"fbouliane:use-latest-fake-switches-default-configuration","ref":"use-latest-fake-switches-default-configuration","sha":"b0d47bc59e2a100e87436291e7b8c7135213ff0c","user":{"login":"fbouliane","id":1572444,"avatar_url":"https://avatars.githubusercontent.com/u/1572444?v=3","gravatar_id":"","url":"https://api.github.com/users/fbouliane","html_url":"https://github.com/fbouliane","followers_url":"https://api.github.com/users/fbouliane/followers","following_url":"https://api.github.com/users/fbouliane/following{/other_user}","gists_url":"https://api.github.com/users/fbouliane/gists{/gist_id}","starred_url":"https://api.github.com/users/fbouliane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbouliane/subscriptions","organizations_url":"https://api.github.com/users/fbouliane/orgs","repos_url":"https://api.github.com/users/fbouliane/repos","events_url":"https://api.github.com/users/fbouliane/events{/privacy}","received_events_url":"https://api.github.com/users/fbouliane/received_events","type":"User","site_admin":false},"repo":{"id":50590327,"name":"netman","full_name":"fbouliane/netman","owner":{"login":"fbouliane","id":1572444,"avatar_url":"https://avatars.githubusercontent.com/u/1572444?v=3","gravatar_id":"","url":"https://api.github.com/users/fbouliane","html_url":"https://github.com/fbouliane","followers_url":"https://api.github.com/users/fbouliane/followers","following_url":"https://api.github.com/users/fbouliane/following{/other_user}","gists_url":"https://api.github.com/users/fbouliane/gists{/gist_id}","starred_url":"https://api.github.com/users/fbouliane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbouliane/subscriptions","organizations_url":"https://api.github.com/users/fbouliane/orgs","repos_url":"https://api.github.com/users/fbouliane/repos","events_url":"https://api.github.com/users/fbouliane/events{/privacy}","received_events_url":"https://api.github.com/users/fbouliane/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fbouliane/netman","description":"A unified REST API to provide vendor-agnostic network automation","fork":true,"url":"https://api.github.com/repos/fbouliane/netman","forks_url":"https://api.github.com/repos/fbouliane/netman/forks","keys_url":"https://api.github.com/repos/fbouliane/netman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fbouliane/netman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fbouliane/netman/teams","hooks_url":"https://api.github.com/repos/fbouliane/netman/hooks","issue_events_url":"https://api.github.com/repos/fbouliane/netman/issues/events{/number}","events_url":"https://api.github.com/repos/fbouliane/netman/events","assignees_url":"https://api.github.com/repos/fbouliane/netman/assignees{/user}","branches_url":"https://api.github.com/repos/fbouliane/netman/branches{/branch}","tags_url":"https://api.github.com/repos/fbouliane/netman/tags","blobs_url":"https://api.github.com/repos/fbouliane/netman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fbouliane/netman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fbouliane/netman/git/refs{/sha}","trees_url":"https://api.github.com/repos/fbouliane/netman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fbouliane/netman/statuses/{sha}","languages_url":"https://api.github.com/repos/fbouliane/netman/languages","stargazers_url":"https://api.github.com/repos/fbouliane/netman/stargazers","contributors_url":"https://api.github.com/repos/fbouliane/netman/contributors","subscribers_url":"https://api.github.com/repos/fbouliane/netman/subscribers","subscription_url":"https://api.github.com/repos/fbouliane/netman/subscription","commits_url":"https://api.github.com/repos/fbouliane/netman/commits{/sha}","git_commits_url":"https://api.github.com/repos/fbouliane/netman/git/commits{/sha}","comments_url":"https://api.github.com/repos/fbouliane/netman/comments{/number}","issue_comment_url":"https://api.github.com/repos/fbouliane/netman/issues/comments{/number}","contents_url":"https://api.github.com/repos/fbouliane/netman/contents/{+path}","compare_url":"https://api.github.com/repos/fbouliane/netman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fbouliane/netman/merges","archive_url":"https://api.github.com/repos/fbouliane/netman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fbouliane/netman/downloads","issues_url":"https://api.github.com/repos/fbouliane/netman/issues{/number}","pulls_url":"https://api.github.com/repos/fbouliane/netman/pulls{/number}","milestones_url":"https://api.github.com/repos/fbouliane/netman/milestones{/number}","notifications_url":"https://api.github.com/repos/fbouliane/netman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fbouliane/netman/labels{/name}","releases_url":"https://api.github.com/repos/fbouliane/netman/releases{/id}","deployments_url":"https://api.github.com/repos/fbouliane/netman/deployments","created_at":"2016-01-28T14:58:36Z","updated_at":"2016-01-28T14:58:38Z","pushed_at":"2016-07-04T20:48:14Z","git_url":"git://github.com/fbouliane/netman.git","ssh_url":"git@github.com:fbouliane/netman.git","clone_url":"https://github.com/fbouliane/netman.git","svn_url":"https://github.com/fbouliane/netman","homepage":null,"size":903,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"internap:master","ref":"master","sha":"c0d9e6a4ad710b1f62a40f88dd032e09be655db5","user":{"login":"internap","id":13888621,"avatar_url":"https://avatars.githubusercontent.com/u/13888621?v=3","gravatar_id":"","url":"https://api.github.com/users/internap","html_url":"https://github.com/internap","followers_url":"https://api.github.com/users/internap/followers","following_url":"https://api.github.com/users/internap/following{/other_user}","gists_url":"https://api.github.com/users/internap/gists{/gist_id}","starred_url":"https://api.github.com/users/internap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/internap/subscriptions","organizations_url":"https://api.github.com/users/internap/orgs","repos_url":"https://api.github.com/users/internap/repos","events_url":"https://api.github.com/users/internap/events{/privacy}","received_events_url":"https://api.github.com/users/internap/received_events","type":"Organization","site_admin":false},"repo":{"id":42546590,"name":"netman","full_name":"internap/netman","owner":{"login":"internap","id":13888621,"avatar_url":"https://avatars.githubusercontent.com/u/13888621?v=3","gravatar_id":"","url":"https://api.github.com/users/internap","html_url":"https://github.com/internap","followers_url":"https://api.github.com/users/internap/followers","following_url":"https://api.github.com/users/internap/following{/other_user}","gists_url":"https://api.github.com/users/internap/gists{/gist_id}","starred_url":"https://api.github.com/users/internap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/internap/subscriptions","organizations_url":"https://api.github.com/users/internap/orgs","repos_url":"https://api.github.com/users/internap/repos","events_url":"https://api.github.com/users/internap/events{/privacy}","received_events_url":"https://api.github.com/users/internap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/internap/netman","description":"A unified REST API to provide vendor-agnostic network automation","fork":false,"url":"https://api.github.com/repos/internap/netman","forks_url":"https://api.github.com/repos/internap/netman/forks","keys_url":"https://api.github.com/repos/internap/netman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/internap/netman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/internap/netman/teams","hooks_url":"https://api.github.com/repos/internap/netman/hooks","issue_events_url":"https://api.github.com/repos/internap/netman/issues/events{/number}","events_url":"https://api.github.com/repos/internap/netman/events","assignees_url":"https://api.github.com/repos/internap/netman/assignees{/user}","branches_url":"https://api.github.com/repos/internap/netman/branches{/branch}","tags_url":"https://api.github.com/repos/internap/netman/tags","blobs_url":"https://api.github.com/repos/internap/netman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/internap/netman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/internap/netman/git/refs{/sha}","trees_url":"https://api.github.com/repos/internap/netman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/internap/netman/statuses/{sha}","languages_url":"https://api.github.com/repos/internap/netman/languages","stargazers_url":"https://api.github.com/repos/internap/netman/stargazers","contributors_url":"https://api.github.com/repos/internap/netman/contributors","subscribers_url":"https://api.github.com/repos/internap/netman/subscribers","subscription_url":"https://api.github.com/repos/internap/netman/subscription","commits_url":"https://api.github.com/repos/internap/netman/commits{/sha}","git_commits_url":"https://api.github.com/repos/internap/netman/git/commits{/sha}","comments_url":"https://api.github.com/repos/internap/netman/comments{/number}","issue_comment_url":"https://api.github.com/repos/internap/netman/issues/comments{/number}","contents_url":"https://api.github.com/repos/internap/netman/contents/{+path}","compare_url":"https://api.github.com/repos/internap/netman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/internap/netman/merges","archive_url":"https://api.github.com/repos/internap/netman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/internap/netman/downloads","issues_url":"https://api.github.com/repos/internap/netman/issues{/number}","pulls_url":"https://api.github.com/repos/internap/netman/pulls{/number}","milestones_url":"https://api.github.com/repos/internap/netman/milestones{/number}","notifications_url":"https://api.github.com/repos/internap/netman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/internap/netman/labels{/name}","releases_url":"https://api.github.com/repos/internap/netman/releases{/id}","deployments_url":"https://api.github.com/repos/internap/netman/deployments","created_at":"2015-09-15T21:06:05Z","updated_at":"2016-06-19T22:32:19Z","pushed_at":"2016-07-04T20:48:15Z","git_url":"git://github.com/internap/netman.git","ssh_url":"git@github.com:internap/netman.git","clone_url":"https://github.com/internap/netman.git","svn_url":"https://github.com/internap/netman","homepage":null,"size":933,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":15,"forks":10,"open_issues":15,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/internap/netman/pulls/154"},"html":{"href":"https://github.com/internap/netman/pull/154"},"issue":{"href":"https://api.github.com/repos/internap/netman/issues/154"},"comments":{"href":"https://api.github.com/repos/internap/netman/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/internap/netman/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/internap/netman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/internap/netman/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/internap/netman/statuses/b0d47bc59e2a100e87436291e7b8c7135213ff0c"}}}}
{"actor":{"display_login":"lindycoder"}}