{"action":"created","comment":{"url":"https://api.github.com/repos/opencobra/COBRA.jl/pulls/comments/92984721","pull_request_review_id":13505065,"id":92984721,"diff_hunk":"@@ -250,7 +253,7 @@ for s = 0:2\n     @test floor(minimum(minFlux)) == -33.0\n     @test floor(norm(maxFlux))    == 1427.0\n     @test floor(norm(minFlux))    == 93.0\n-    @test abs((model.c' * minFlux)[1] - optSol) < 1e-9\n+    @test abs((model.c' * minFlux)[1] - optPercentage/100.0 * optSol) < 1e-6","path":"test/p_all.jl","position":null,"original_position":19,"commit_id":"f0ccfc46d962164180a5e6a003fc2d62405a3156","original_commit_id":"ba42f9e848b54a4f109cd911d7e0fa69f769233f","user":{"login":"laurentheirendt","id":20812112,"avatar_url":"https://avatars.githubusercontent.com/u/20812112?v=3","gravatar_id":"","url":"https://api.github.com/users/laurentheirendt","html_url":"https://github.com/laurentheirendt","followers_url":"https://api.github.com/users/laurentheirendt/followers","following_url":"https://api.github.com/users/laurentheirendt/following{/other_user}","gists_url":"https://api.github.com/users/laurentheirendt/gists{/gist_id}","starred_url":"https://api.github.com/users/laurentheirendt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurentheirendt/subscriptions","organizations_url":"https://api.github.com/users/laurentheirendt/orgs","repos_url":"https://api.github.com/users/laurentheirendt/repos","events_url":"https://api.github.com/users/laurentheirendt/events{/privacy}","received_events_url":"https://api.github.com/users/laurentheirendt/received_events","type":"User","site_admin":false},"body":"Fixed. Thanks @syarra .","created_at":"2016-12-19T08:19:03Z","updated_at":"2016-12-19T08:19:04Z","html_url":"https://github.com/opencobra/COBRA.jl/pull/7#discussion_r92984721","pull_request_url":"https://api.github.com/repos/opencobra/COBRA.jl/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/opencobra/COBRA.jl/pulls/comments/92984721"},"html":{"href":"https://github.com/opencobra/COBRA.jl/pull/7#discussion_r92984721"},"pull_request":{"href":"https://api.github.com/repos/opencobra/COBRA.jl/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/opencobra/COBRA.jl/pulls/7","id":98486130,"html_url":"https://github.com/opencobra/COBRA.jl/pull/7","diff_url":"https://github.com/opencobra/COBRA.jl/pull/7.diff","patch_url":"https://github.com/opencobra/COBRA.jl/pull/7.patch","issue_url":"https://api.github.com/repos/opencobra/COBRA.jl/issues/7","number":7,"state":"open","locked":false,"title":"Improvements and bugfixes overall","user":{"login":"laurentheirendt","id":20812112,"avatar_url":"https://avatars.githubusercontent.com/u/20812112?v=3","gravatar_id":"","url":"https://api.github.com/users/laurentheirendt","html_url":"https://github.com/laurentheirendt","followers_url":"https://api.github.com/users/laurentheirendt/followers","following_url":"https://api.github.com/users/laurentheirendt/following{/other_user}","gists_url":"https://api.github.com/users/laurentheirendt/gists{/gist_id}","starred_url":"https://api.github.com/users/laurentheirendt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurentheirendt/subscriptions","organizations_url":"https://api.github.com/users/laurentheirendt/orgs","repos_url":"https://api.github.com/users/laurentheirendt/repos","events_url":"https://api.github.com/users/laurentheirendt/events{/privacy}","received_events_url":"https://api.github.com/users/laurentheirendt/received_events","type":"User","site_admin":false},"body":"**Major changes**\r\n\r\n- Saving a file to a specific location (+ documentation)\r\n- Documentation improvement for `configuration.md`\r\n- Improvements to `connect.jl`:\r\n    + Testing the SSH connection before actually connecting nodes\r\n    + Documentation additions\r\n\r\n**Minor changes**\r\n\r\n- Return argument of `preFBA` changed to original value `FBAobj`, not the `optPercentage` multiplied value\r\n- Fixing a minor bug in inequalities when building the model (tested with large-scale coupled models)\r\n- Minor style changes overall\r\n\r\n**Note**: `codecov` throws errors, as some packages on Travis cannot be correctly built.\r\n\r\n*Tested on `Linux` and `macOS` on Julia `0.5` and `0.6`. CI integrated version.*","created_at":"2016-12-18T20:25:20Z","updated_at":"2016-12-19T08:19:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"827c858565a1fa629a09aa052f3ef12c82cdeaad","assignee":{"login":"syarra","id":816318,"avatar_url":"https://avatars.githubusercontent.com/u/816318?v=3","gravatar_id":"","url":"https://api.github.com/users/syarra","html_url":"https://github.com/syarra","followers_url":"https://api.github.com/users/syarra/followers","following_url":"https://api.github.com/users/syarra/following{/other_user}","gists_url":"https://api.github.com/users/syarra/gists{/gist_id}","starred_url":"https://api.github.com/users/syarra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syarra/subscriptions","organizations_url":"https://api.github.com/users/syarra/orgs","repos_url":"https://api.github.com/users/syarra/repos","events_url":"https://api.github.com/users/syarra/events{/privacy}","received_events_url":"https://api.github.com/users/syarra/received_events","type":"User","site_admin":false},"assignees":[{"login":"syarra","id":816318,"avatar_url":"https://avatars.githubusercontent.com/u/816318?v=3","gravatar_id":"","url":"https://api.github.com/users/syarra","html_url":"https://github.com/syarra","followers_url":"https://api.github.com/users/syarra/followers","following_url":"https://api.github.com/users/syarra/following{/other_user}","gists_url":"https://api.github.com/users/syarra/gists{/gist_id}","starred_url":"https://api.github.com/users/syarra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syarra/subscriptions","organizations_url":"https://api.github.com/users/syarra/orgs","repos_url":"https://api.github.com/users/syarra/repos","events_url":"https://api.github.com/users/syarra/events{/privacy}","received_events_url":"https://api.github.com/users/syarra/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/opencobra/COBRA.jl/pulls/7/commits","review_comments_url":"https://api.github.com/repos/opencobra/COBRA.jl/pulls/7/comments","review_comment_url":"https://api.github.com/repos/opencobra/COBRA.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencobra/COBRA.jl/issues/7/comments","statuses_url":"https://api.github.com/repos/opencobra/COBRA.jl/statuses/f0ccfc46d962164180a5e6a003fc2d62405a3156","head":{"label":"opencobra:develop","ref":"develop","sha":"f0ccfc46d962164180a5e6a003fc2d62405a3156","user":{"login":"opencobra","id":2708410,"avatar_url":"https://avatars.githubusercontent.com/u/2708410?v=3","gravatar_id":"","url":"https://api.github.com/users/opencobra","html_url":"https://github.com/opencobra","followers_url":"https://api.github.com/users/opencobra/followers","following_url":"https://api.github.com/users/opencobra/following{/other_user}","gists_url":"https://api.github.com/users/opencobra/gists{/gist_id}","starred_url":"https://api.github.com/users/opencobra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencobra/subscriptions","organizations_url":"https://api.github.com/users/opencobra/orgs","repos_url":"https://api.github.com/users/opencobra/repos","events_url":"https://api.github.com/users/opencobra/events{/privacy}","received_events_url":"https://api.github.com/users/opencobra/received_events","type":"Organization","site_admin":false},"repo":{"id":71868850,"name":"COBRA.jl","full_name":"opencobra/COBRA.jl","owner":{"login":"opencobra","id":2708410,"avatar_url":"https://avatars.githubusercontent.com/u/2708410?v=3","gravatar_id":"","url":"https://api.github.com/users/opencobra","html_url":"https://github.com/opencobra","followers_url":"https://api.github.com/users/opencobra/followers","following_url":"https://api.github.com/users/opencobra/following{/other_user}","gists_url":"https://api.github.com/users/opencobra/gists{/gist_id}","starred_url":"https://api.github.com/users/opencobra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencobra/subscriptions","organizations_url":"https://api.github.com/users/opencobra/orgs","repos_url":"https://api.github.com/users/opencobra/repos","events_url":"https://api.github.com/users/opencobra/events{/privacy}","received_events_url":"https://api.github.com/users/opencobra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencobra/COBRA.jl","description":"High-level, high-performance, constraint-based reconstruction and analysis in Julia","fork":false,"url":"https://api.github.com/repos/opencobra/COBRA.jl","forks_url":"https://api.github.com/repos/opencobra/COBRA.jl/forks","keys_url":"https://api.github.com/repos/opencobra/COBRA.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencobra/COBRA.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencobra/COBRA.jl/teams","hooks_url":"https://api.github.com/repos/opencobra/COBRA.jl/hooks","issue_events_url":"https://api.github.com/repos/opencobra/COBRA.jl/issues/events{/number}","events_url":"https://api.github.com/repos/opencobra/COBRA.jl/events","assignees_url":"https://api.github.com/repos/opencobra/COBRA.jl/assignees{/user}","branches_url":"https://api.github.com/repos/opencobra/COBRA.jl/branches{/branch}","tags_url":"https://api.github.com/repos/opencobra/COBRA.jl/tags","blobs_url":"https://api.github.com/repos/opencobra/COBRA.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencobra/COBRA.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencobra/COBRA.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencobra/COBRA.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencobra/COBRA.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/opencobra/COBRA.jl/languages","stargazers_url":"https://api.github.com/repos/opencobra/COBRA.jl/stargazers","contributors_url":"https://api.github.com/repos/opencobra/COBRA.jl/contributors","subscribers_url":"https://api.github.com/repos/opencobra/COBRA.jl/subscribers","subscription_url":"https://api.github.com/repos/opencobra/COBRA.jl/subscription","commits_url":"https://api.github.com/repos/opencobra/COBRA.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencobra/COBRA.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencobra/COBRA.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencobra/COBRA.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencobra/COBRA.jl/contents/{+path}","compare_url":"https://api.github.com/repos/opencobra/COBRA.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencobra/COBRA.jl/merges","archive_url":"https://api.github.com/repos/opencobra/COBRA.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencobra/COBRA.jl/downloads","issues_url":"https://api.github.com/repos/opencobra/COBRA.jl/issues{/number}","pulls_url":"https://api.github.com/repos/opencobra/COBRA.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/opencobra/COBRA.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/opencobra/COBRA.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencobra/COBRA.jl/labels{/name}","releases_url":"https://api.github.com/repos/opencobra/COBRA.jl/releases{/id}","deployments_url":"https://api.github.com/repos/opencobra/COBRA.jl/deployments","created_at":"2016-10-25T07:02:19Z","updated_at":"2016-12-06T00:29:31Z","pushed_at":"2016-12-19T08:18:49Z","git_url":"git://github.com/opencobra/COBRA.jl.git","ssh_url":"git@github.com:opencobra/COBRA.jl.git","clone_url":"https://github.com/opencobra/COBRA.jl.git","svn_url":"https://github.com/opencobra/COBRA.jl","homepage":"https://opencobra.github.io/COBRA.jl","size":329,"stargazers_count":7,"watchers_count":7,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":7,"default_branch":"master"}},"base":{"label":"opencobra:master","ref":"master","sha":"5e736d5fdd4c4efeb553abda3f207715c6204efe","user":{"login":"opencobra","id":2708410,"avatar_url":"https://avatars.githubusercontent.com/u/2708410?v=3","gravatar_id":"","url":"https://api.github.com/users/opencobra","html_url":"https://github.com/opencobra","followers_url":"https://api.github.com/users/opencobra/followers","following_url":"https://api.github.com/users/opencobra/following{/other_user}","gists_url":"https://api.github.com/users/opencobra/gists{/gist_id}","starred_url":"https://api.github.com/users/opencobra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencobra/subscriptions","organizations_url":"https://api.github.com/users/opencobra/orgs","repos_url":"https://api.github.com/users/opencobra/repos","events_url":"https://api.github.com/users/opencobra/events{/privacy}","received_events_url":"https://api.github.com/users/opencobra/received_events","type":"Organization","site_admin":false},"repo":{"id":71868850,"name":"COBRA.jl","full_name":"opencobra/COBRA.jl","owner":{"login":"opencobra","id":2708410,"avatar_url":"https://avatars.githubusercontent.com/u/2708410?v=3","gravatar_id":"","url":"https://api.github.com/users/opencobra","html_url":"https://github.com/opencobra","followers_url":"https://api.github.com/users/opencobra/followers","following_url":"https://api.github.com/users/opencobra/following{/other_user}","gists_url":"https://api.github.com/users/opencobra/gists{/gist_id}","starred_url":"https://api.github.com/users/opencobra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencobra/subscriptions","organizations_url":"https://api.github.com/users/opencobra/orgs","repos_url":"https://api.github.com/users/opencobra/repos","events_url":"https://api.github.com/users/opencobra/events{/privacy}","received_events_url":"https://api.github.com/users/opencobra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencobra/COBRA.jl","description":"High-level, high-performance, constraint-based reconstruction and analysis in Julia","fork":false,"url":"https://api.github.com/repos/opencobra/COBRA.jl","forks_url":"https://api.github.com/repos/opencobra/COBRA.jl/forks","keys_url":"https://api.github.com/repos/opencobra/COBRA.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencobra/COBRA.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencobra/COBRA.jl/teams","hooks_url":"https://api.github.com/repos/opencobra/COBRA.jl/hooks","issue_events_url":"https://api.github.com/repos/opencobra/COBRA.jl/issues/events{/number}","events_url":"https://api.github.com/repos/opencobra/COBRA.jl/events","assignees_url":"https://api.github.com/repos/opencobra/COBRA.jl/assignees{/user}","branches_url":"https://api.github.com/repos/opencobra/COBRA.jl/branches{/branch}","tags_url":"https://api.github.com/repos/opencobra/COBRA.jl/tags","blobs_url":"https://api.github.com/repos/opencobra/COBRA.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencobra/COBRA.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencobra/COBRA.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencobra/COBRA.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencobra/COBRA.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/opencobra/COBRA.jl/languages","stargazers_url":"https://api.github.com/repos/opencobra/COBRA.jl/stargazers","contributors_url":"https://api.github.com/repos/opencobra/COBRA.jl/contributors","subscribers_url":"https://api.github.com/repos/opencobra/COBRA.jl/subscribers","subscription_url":"https://api.github.com/repos/opencobra/COBRA.jl/subscription","commits_url":"https://api.github.com/repos/opencobra/COBRA.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencobra/COBRA.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencobra/COBRA.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencobra/COBRA.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencobra/COBRA.jl/contents/{+path}","compare_url":"https://api.github.com/repos/opencobra/COBRA.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencobra/COBRA.jl/merges","archive_url":"https://api.github.com/repos/opencobra/COBRA.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencobra/COBRA.jl/downloads","issues_url":"https://api.github.com/repos/opencobra/COBRA.jl/issues{/number}","pulls_url":"https://api.github.com/repos/opencobra/COBRA.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/opencobra/COBRA.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/opencobra/COBRA.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencobra/COBRA.jl/labels{/name}","releases_url":"https://api.github.com/repos/opencobra/COBRA.jl/releases{/id}","deployments_url":"https://api.github.com/repos/opencobra/COBRA.jl/deployments","created_at":"2016-10-25T07:02:19Z","updated_at":"2016-12-06T00:29:31Z","pushed_at":"2016-12-19T08:18:49Z","git_url":"git://github.com/opencobra/COBRA.jl.git","ssh_url":"git@github.com:opencobra/COBRA.jl.git","clone_url":"https://github.com/opencobra/COBRA.jl.git","svn_url":"https://github.com/opencobra/COBRA.jl","homepage":"https://opencobra.github.io/COBRA.jl","size":329,"stargazers_count":7,"watchers_count":7,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencobra/COBRA.jl/pulls/7"},"html":{"href":"https://github.com/opencobra/COBRA.jl/pull/7"},"issue":{"href":"https://api.github.com/repos/opencobra/COBRA.jl/issues/7"},"comments":{"href":"https://api.github.com/repos/opencobra/COBRA.jl/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/opencobra/COBRA.jl/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/opencobra/COBRA.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencobra/COBRA.jl/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/opencobra/COBRA.jl/statuses/f0ccfc46d962164180a5e6a003fc2d62405a3156"}}}}
{"actor":{"display_login":"laurentheirendt"}}