{"action":"created","issue":{"url":"https://api.github.com/repos/gotwarlost/istanbul/issues/638","repository_url":"https://api.github.com/repos/gotwarlost/istanbul","labels_url":"https://api.github.com/repos/gotwarlost/istanbul/issues/638/labels{/name}","comments_url":"https://api.github.com/repos/gotwarlost/istanbul/issues/638/comments","events_url":"https://api.github.com/repos/gotwarlost/istanbul/issues/638/events","html_url":"https://github.com/gotwarlost/istanbul/issues/638","id":158184578,"number":638,"title":"Deprecate fileset","user":{"login":"mklabs","id":113832,"avatar_url":"https://avatars.githubusercontent.com/u/113832?v=3","gravatar_id":"","url":"https://api.github.com/users/mklabs","html_url":"https://github.com/mklabs","followers_url":"https://api.github.com/users/mklabs/followers","following_url":"https://api.github.com/users/mklabs/following{/other_user}","gists_url":"https://api.github.com/users/mklabs/gists{/gist_id}","starred_url":"https://api.github.com/users/mklabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mklabs/subscriptions","organizations_url":"https://api.github.com/users/mklabs/orgs","repos_url":"https://api.github.com/users/mklabs/repos","events_url":"https://api.github.com/users/mklabs/events{/privacy}","received_events_url":"https://api.github.com/users/mklabs/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-06-02T16:31:00Z","updated_at":"2016-07-10T15:01:14Z","closed_at":"2016-07-09T05:39:24Z","body":"Hi!\r\n\r\nI'm opening this issue to start a thread on the possibility to deprecate https://github.com/mklabs/node-fileset\r\n\r\nI recently merged a pending PR from @isaacs (mklabs/node-fileset#22), which\r\n\r\n> may or may not be a breaking change from fileset's pov. ([changelog](https://github.com/mklabs/node-fileset/blob/master/CHANGELOG.md#100-2016-06-01))\r\n\r\nto quote Isaacs. So I bumped filset to a major 1.0 version which should save you from any trouble.\r\n\r\n---\r\n\r\nI really really appreciate that you choose to rely on it and build istanbul on top of it. But, to be honest, fileset is a package I wrote a long time ago and never really used it. I always either used just glob with the ignore pattern or redone the filtering on top of globs results before glob 5.\r\n\r\nI'm considering deprecating the package in favour of newer, better similar packages like @sindresorhus https://github.com/sindresorhus/globby, or simply glob itself with the `options.ignore` patterns.\r\n\r\nThis should help with performance (as the minimatch ignore is done internally by glob, avoiding one costly glob call on all ignore patterns) and issues like #556 \r\n\r\nI can maybe help in the migration process by opening a PR to switch from fileset to globby, or just glob's with `options.ignore`.\r\n\r\nLet me know :)\r\n\r\nThanks for building Istanbul."},"comment":{"url":"https://api.github.com/repos/gotwarlost/istanbul/issues/comments/231593416","html_url":"https://github.com/gotwarlost/istanbul/issues/638#issuecomment-231593416","issue_url":"https://api.github.com/repos/gotwarlost/istanbul/issues/638","id":231593416,"user":{"login":"lo1tuma","id":169170,"avatar_url":"https://avatars.githubusercontent.com/u/169170?v=3","gravatar_id":"","url":"https://api.github.com/users/lo1tuma","html_url":"https://github.com/lo1tuma","followers_url":"https://api.github.com/users/lo1tuma/followers","following_url":"https://api.github.com/users/lo1tuma/following{/other_user}","gists_url":"https://api.github.com/users/lo1tuma/gists{/gist_id}","starred_url":"https://api.github.com/users/lo1tuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lo1tuma/subscriptions","organizations_url":"https://api.github.com/users/lo1tuma/orgs","repos_url":"https://api.github.com/users/lo1tuma/repos","events_url":"https://api.github.com/users/lo1tuma/events{/privacy}","received_events_url":"https://api.github.com/users/lo1tuma/received_events","type":"User","site_admin":false},"created_at":"2016-07-10T15:01:14Z","updated_at":"2016-07-10T15:01:14Z","body":"@mklabs Actually fileset is still a dependency of istanbul. There is an open PR #648 which would replace fileset by glob but it hasn’t been merged yet. So this issue still remains."}}
{"actor":{"display_login":"lo1tuma"}}