{"action":"created","comment":{"url":"https://api.github.com/repos/uber/deck.gl/pulls/comments/84820829","pull_request_review_id":5573376,"id":84820829,"diff_hunk":"@@ -98,10 +110,17 @@ export default class ScatterplotLayer extends Layer {\n         })\n       ),\n       geometry: new Geometry({\n-        drawMode: 'TRIANGLE_FAN',\n+        drawMode: drawMode || 'TRIANGLE_FAN',\n         positions: new Float32Array(positions)\n       }),\n-      isInstanced: true\n+      isInstanced: true,\n+      onBeforeRender() {","path":"src/layers/core/scatterplot-layer/scatterplot-layer.js","position":47,"original_position":47,"commit_id":"5589be58abb124bce3d1750fc7e07f2c5f3b625e","original_commit_id":"5589be58abb124bce3d1750fc7e07f2c5f3b625e","user":{"login":"ibgreen","id":7025232,"avatar_url":"https://avatars.githubusercontent.com/u/7025232?v=3","gravatar_id":"","url":"https://api.github.com/users/ibgreen","html_url":"https://github.com/ibgreen","followers_url":"https://api.github.com/users/ibgreen/followers","following_url":"https://api.github.com/users/ibgreen/following{/other_user}","gists_url":"https://api.github.com/users/ibgreen/gists{/gist_id}","starred_url":"https://api.github.com/users/ibgreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibgreen/subscriptions","organizations_url":"https://api.github.com/users/ibgreen/orgs","repos_url":"https://api.github.com/users/ibgreen/repos","events_url":"https://api.github.com/users/ibgreen/events{/privacy}","received_events_url":"https://api.github.com/users/ibgreen/received_events","type":"User","site_admin":false},"body":"In deck.gl v3 it is possible to override Layer.draw(). That enables cleaner handling of gl parameters compared to setting state and using callbacks on the model\r\n See [ArcLayer](https://github.com/uber/deck.gl/blob/dev/src/layers/core/arc-layer/arc-layer.js#L70).","created_at":"2016-10-25T02:22:35Z","updated_at":"2016-10-25T02:22:35Z","html_url":"https://github.com/uber/deck.gl/pull/130#discussion_r84820829","pull_request_url":"https://api.github.com/repos/uber/deck.gl/pulls/130","_links":{"self":{"href":"https://api.github.com/repos/uber/deck.gl/pulls/comments/84820829"},"html":{"href":"https://github.com/uber/deck.gl/pull/130#discussion_r84820829"},"pull_request":{"href":"https://api.github.com/repos/uber/deck.gl/pulls/130"}}},"pull_request":{"url":"https://api.github.com/repos/uber/deck.gl/pulls/130","id":90726360,"html_url":"https://github.com/uber/deck.gl/pull/130","diff_url":"https://github.com/uber/deck.gl/pull/130.diff","patch_url":"https://github.com/uber/deck.gl/pull/130.patch","issue_url":"https://api.github.com/repos/uber/deck.gl/issues/130","number":130,"state":"open","locked":false,"title":"Add outline to scatterplot","user":{"login":"mcnuttandrew","id":6854312,"avatar_url":"https://avatars.githubusercontent.com/u/6854312?v=3","gravatar_id":"","url":"https://api.github.com/users/mcnuttandrew","html_url":"https://github.com/mcnuttandrew","followers_url":"https://api.github.com/users/mcnuttandrew/followers","following_url":"https://api.github.com/users/mcnuttandrew/following{/other_user}","gists_url":"https://api.github.com/users/mcnuttandrew/gists{/gist_id}","starred_url":"https://api.github.com/users/mcnuttandrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcnuttandrew/subscriptions","organizations_url":"https://api.github.com/users/mcnuttandrew/orgs","repos_url":"https://api.github.com/users/mcnuttandrew/repos","events_url":"https://api.github.com/users/mcnuttandrew/events{/privacy}","received_events_url":"https://api.github.com/users/mcnuttandrew/received_events","type":"User","site_admin":false},"body":"<img width=\"1378\" alt=\"screen shot 2016-10-24 at 4 50 23 pm\" src=\"https://cloud.githubusercontent.com/assets/6854312/19670489/7b1ffe86-9a1c-11e6-8631-6bcd9ec2e5f9.png\">\r\n\r\n\r\nAdd outline to scatterplot in response to #55 ","created_at":"2016-10-25T02:03:54Z","updated_at":"2016-10-25T02:32:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"997c692b9824940d4106e6e53ebf073a6c78cea5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/deck.gl/pulls/130/commits","review_comments_url":"https://api.github.com/repos/uber/deck.gl/pulls/130/comments","review_comment_url":"https://api.github.com/repos/uber/deck.gl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/deck.gl/issues/130/comments","statuses_url":"https://api.github.com/repos/uber/deck.gl/statuses/5589be58abb124bce3d1750fc7e07f2c5f3b625e","head":{"label":"mcnuttandrew:scatterplot-outline","ref":"scatterplot-outline","sha":"5589be58abb124bce3d1750fc7e07f2c5f3b625e","user":{"login":"mcnuttandrew","id":6854312,"avatar_url":"https://avatars.githubusercontent.com/u/6854312?v=3","gravatar_id":"","url":"https://api.github.com/users/mcnuttandrew","html_url":"https://github.com/mcnuttandrew","followers_url":"https://api.github.com/users/mcnuttandrew/followers","following_url":"https://api.github.com/users/mcnuttandrew/following{/other_user}","gists_url":"https://api.github.com/users/mcnuttandrew/gists{/gist_id}","starred_url":"https://api.github.com/users/mcnuttandrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcnuttandrew/subscriptions","organizations_url":"https://api.github.com/users/mcnuttandrew/orgs","repos_url":"https://api.github.com/users/mcnuttandrew/repos","events_url":"https://api.github.com/users/mcnuttandrew/events{/privacy}","received_events_url":"https://api.github.com/users/mcnuttandrew/received_events","type":"User","site_admin":false},"repo":{"id":71846941,"name":"deck.gl","full_name":"mcnuttandrew/deck.gl","owner":{"login":"mcnuttandrew","id":6854312,"avatar_url":"https://avatars.githubusercontent.com/u/6854312?v=3","gravatar_id":"","url":"https://api.github.com/users/mcnuttandrew","html_url":"https://github.com/mcnuttandrew","followers_url":"https://api.github.com/users/mcnuttandrew/followers","following_url":"https://api.github.com/users/mcnuttandrew/following{/other_user}","gists_url":"https://api.github.com/users/mcnuttandrew/gists{/gist_id}","starred_url":"https://api.github.com/users/mcnuttandrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcnuttandrew/subscriptions","organizations_url":"https://api.github.com/users/mcnuttandrew/orgs","repos_url":"https://api.github.com/users/mcnuttandrew/repos","events_url":"https://api.github.com/users/mcnuttandrew/events{/privacy}","received_events_url":"https://api.github.com/users/mcnuttandrew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcnuttandrew/deck.gl","description":"A WebGL overlay suite","fork":true,"url":"https://api.github.com/repos/mcnuttandrew/deck.gl","forks_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/forks","keys_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/teams","hooks_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/hooks","issue_events_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/issues/events{/number}","events_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/events","assignees_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/assignees{/user}","branches_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/branches{/branch}","tags_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/tags","blobs_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/statuses/{sha}","languages_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/languages","stargazers_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/stargazers","contributors_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/contributors","subscribers_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/subscribers","subscription_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/subscription","commits_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/contents/{+path}","compare_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/merges","archive_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/downloads","issues_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/issues{/number}","pulls_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/pulls{/number}","milestones_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/milestones{/number}","notifications_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/labels{/name}","releases_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/releases{/id}","deployments_url":"https://api.github.com/repos/mcnuttandrew/deck.gl/deployments","created_at":"2016-10-25T01:20:53Z","updated_at":"2016-10-25T01:20:54Z","pushed_at":"2016-10-25T02:05:13Z","git_url":"git://github.com/mcnuttandrew/deck.gl.git","ssh_url":"git@github.com:mcnuttandrew/deck.gl.git","clone_url":"https://github.com/mcnuttandrew/deck.gl.git","svn_url":"https://github.com/mcnuttandrew/deck.gl","homepage":"","size":14340,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uber:dev","ref":"dev","sha":"4db9528022b48f4cfa46330f5002a0be6edb0ab7","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":48030204,"name":"deck.gl","full_name":"uber/deck.gl","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/deck.gl","description":"A WebGL overlay suite","fork":false,"url":"https://api.github.com/repos/uber/deck.gl","forks_url":"https://api.github.com/repos/uber/deck.gl/forks","keys_url":"https://api.github.com/repos/uber/deck.gl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/deck.gl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/deck.gl/teams","hooks_url":"https://api.github.com/repos/uber/deck.gl/hooks","issue_events_url":"https://api.github.com/repos/uber/deck.gl/issues/events{/number}","events_url":"https://api.github.com/repos/uber/deck.gl/events","assignees_url":"https://api.github.com/repos/uber/deck.gl/assignees{/user}","branches_url":"https://api.github.com/repos/uber/deck.gl/branches{/branch}","tags_url":"https://api.github.com/repos/uber/deck.gl/tags","blobs_url":"https://api.github.com/repos/uber/deck.gl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/deck.gl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/deck.gl/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/deck.gl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/deck.gl/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/deck.gl/languages","stargazers_url":"https://api.github.com/repos/uber/deck.gl/stargazers","contributors_url":"https://api.github.com/repos/uber/deck.gl/contributors","subscribers_url":"https://api.github.com/repos/uber/deck.gl/subscribers","subscription_url":"https://api.github.com/repos/uber/deck.gl/subscription","commits_url":"https://api.github.com/repos/uber/deck.gl/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/deck.gl/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/deck.gl/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/deck.gl/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/deck.gl/contents/{+path}","compare_url":"https://api.github.com/repos/uber/deck.gl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/deck.gl/merges","archive_url":"https://api.github.com/repos/uber/deck.gl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/deck.gl/downloads","issues_url":"https://api.github.com/repos/uber/deck.gl/issues{/number}","pulls_url":"https://api.github.com/repos/uber/deck.gl/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/deck.gl/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/deck.gl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/deck.gl/labels{/name}","releases_url":"https://api.github.com/repos/uber/deck.gl/releases{/id}","deployments_url":"https://api.github.com/repos/uber/deck.gl/deployments","created_at":"2015-12-15T08:38:29Z","updated_at":"2016-10-21T01:27:21Z","pushed_at":"2016-10-25T02:05:13Z","git_url":"git://github.com/uber/deck.gl.git","ssh_url":"git@github.com:uber/deck.gl.git","clone_url":"https://github.com/uber/deck.gl.git","svn_url":"https://github.com/uber/deck.gl","homepage":"","size":14340,"stargazers_count":286,"watchers_count":286,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":14,"forks":24,"open_issues":14,"watchers":286,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/deck.gl/pulls/130"},"html":{"href":"https://github.com/uber/deck.gl/pull/130"},"issue":{"href":"https://api.github.com/repos/uber/deck.gl/issues/130"},"comments":{"href":"https://api.github.com/repos/uber/deck.gl/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/deck.gl/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/deck.gl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/deck.gl/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/uber/deck.gl/statuses/5589be58abb124bce3d1750fc7e07f2c5f3b625e"}}}}
{"actor":{"display_login":"ibgreen"}}