{"action":"closed","issue":{"url":"https://api.github.com/repos/puniverse/quasar/issues/162","repository_url":"https://api.github.com/repos/puniverse/quasar","labels_url":"https://api.github.com/repos/puniverse/quasar/issues/162/labels{/name}","comments_url":"https://api.github.com/repos/puniverse/quasar/issues/162/comments","events_url":"https://api.github.com/repos/puniverse/quasar/issues/162/events","html_url":"https://github.com/puniverse/quasar/issues/162","id":134352518,"number":162,"title":"Instrument calls to CompletableFuture","user":{"login":"stepancheg","id":28969,"avatar_url":"https://avatars.githubusercontent.com/u/28969?v=3","gravatar_id":"","url":"https://api.github.com/users/stepancheg","html_url":"https://github.com/stepancheg","followers_url":"https://api.github.com/users/stepancheg/followers","following_url":"https://api.github.com/users/stepancheg/following{/other_user}","gists_url":"https://api.github.com/users/stepancheg/gists{/gist_id}","starred_url":"https://api.github.com/users/stepancheg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stepancheg/subscriptions","organizations_url":"https://api.github.com/users/stepancheg/orgs","repos_url":"https://api.github.com/users/stepancheg/repos","events_url":"https://api.github.com/users/stepancheg/events{/privacy}","received_events_url":"https://api.github.com/users/stepancheg/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-02-17T17:53:01Z","updated_at":"2016-02-21T17:48:11Z","closed_at":"2016-02-21T17:48:11Z","body":"Currently fiber calls to `CompletableFuture.get()` are not instrumented, you need to use `AsyncCompletionStage.get()`.\r\n\r\nMy request is unconditionally instrument calls to `CompetableFuture.get()` (by simply replacing them with `AsyncCompletionStage.get()`).\r\n\r\nIt is needed for two reason:\r\n\r\n* it makes code safer (it won't hang if someone acdidentally forgets to use `AsyncCompletionStage`)\r\n* it makes instrumentation friendlier to libraries that do not need quasar dependency\r\n\r\nThis issue is related to #161."}}