{"action":"created","comment":{"url":"https://api.github.com/repos/quartznet/quartznet/pulls/comments/61292610","id":61292610,"diff_hunk":"@@ -3485,7 +3485,11 @@ private static void CheckNotZombied(ConnectionAndTransactionHolder cth)\n \n             if (cth.Transaction != null && cth.Transaction.Connection == null)\n             {\n-                throw new DataException(\"Transaction not connected, or was disconnected\");\n+                // TODO (NetCore Port): I think keeping the exception type consistent between desktop and Core versions of Quartz\n+                //                      is more important than keeping the desktop one consistent between the previous version and this one.\n+                //                      It's not an obvious call, though, so may be worth discussing.\n+                // throw new DataException(\"Transaction not connected, or was disconnected\");\n+                throw new InvalidOperationException(\"Transaction not connected, or was disconnected\");","path":"src/Quartz/Impl/AdoJobStore/JobStoreSupport.cs","position":9,"original_position":9,"commit_id":"85e54cd6d385d18087bbbed9f8839f6e2cde46fb","original_commit_id":"85e54cd6d385d18087bbbed9f8839f6e2cde46fb","user":{"login":"lahma","id":171892,"avatar_url":"https://avatars.githubusercontent.com/u/171892?v=3","gravatar_id":"","url":"https://api.github.com/users/lahma","html_url":"https://github.com/lahma","followers_url":"https://api.github.com/users/lahma/followers","following_url":"https://api.github.com/users/lahma/following{/other_user}","gists_url":"https://api.github.com/users/lahma/gists{/gist_id}","starred_url":"https://api.github.com/users/lahma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lahma/subscriptions","organizations_url":"https://api.github.com/users/lahma/orgs","repos_url":"https://api.github.com/users/lahma/repos","events_url":"https://api.github.com/users/lahma/events{/privacy}","received_events_url":"https://api.github.com/users/lahma/received_events","type":"User","site_admin":false},"body":"this is so rare case that we can probably just change this, things are pretty broken at this stage when this exception is thrown","created_at":"2016-04-27T16:40:56Z","updated_at":"2016-04-27T16:40:56Z","html_url":"https://github.com/quartznet/quartznet/pull/359#discussion_r61292610","pull_request_url":"https://api.github.com/repos/quartznet/quartznet/pulls/359","_links":{"self":{"href":"https://api.github.com/repos/quartznet/quartznet/pulls/comments/61292610"},"html":{"href":"https://github.com/quartznet/quartznet/pull/359#discussion_r61292610"},"pull_request":{"href":"https://api.github.com/repos/quartznet/quartznet/pulls/359"}}},"pull_request":{"url":"https://api.github.com/repos/quartznet/quartznet/pulls/359","id":68080122,"html_url":"https://github.com/quartznet/quartznet/pull/359","diff_url":"https://github.com/quartznet/quartznet/pull/359.diff","patch_url":"https://github.com/quartznet/quartznet/pull/359.patch","issue_url":"https://api.github.com/repos/quartznet/quartznet/issues/359","number":359,"state":"open","locked":false,"title":"NET Core support","user":{"login":"lahma","id":171892,"avatar_url":"https://avatars.githubusercontent.com/u/171892?v=3","gravatar_id":"","url":"https://api.github.com/users/lahma","html_url":"https://github.com/lahma","followers_url":"https://api.github.com/users/lahma/followers","following_url":"https://api.github.com/users/lahma/following{/other_user}","gists_url":"https://api.github.com/users/lahma/gists{/gist_id}","starred_url":"https://api.github.com/users/lahma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lahma/subscriptions","organizations_url":"https://api.github.com/users/lahma/orgs","repos_url":"https://api.github.com/users/lahma/repos","events_url":"https://api.github.com/users/lahma/events{/privacy}","received_events_url":"https://api.github.com/users/lahma/received_events","type":"User","site_admin":false},"body":"Changes against v3 branch that enable use against upcoming NET Core.","created_at":"2016-04-27T16:05:23Z","updated_at":"2016-04-27T16:40:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c09de06ff8a4a6a31f0bc72f68ef0f5c83826d7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/quartznet/quartznet/pulls/359/commits","review_comments_url":"https://api.github.com/repos/quartznet/quartznet/pulls/359/comments","review_comment_url":"https://api.github.com/repos/quartznet/quartznet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quartznet/quartznet/issues/359/comments","statuses_url":"https://api.github.com/repos/quartznet/quartznet/statuses/85e54cd6d385d18087bbbed9f8839f6e2cde46fb","head":{"label":"mjrousos:NetCore-Rebased","ref":"NetCore-Rebased","sha":"85e54cd6d385d18087bbbed9f8839f6e2cde46fb","user":{"login":"mjrousos","id":10077254,"avatar_url":"https://avatars.githubusercontent.com/u/10077254?v=3","gravatar_id":"","url":"https://api.github.com/users/mjrousos","html_url":"https://github.com/mjrousos","followers_url":"https://api.github.com/users/mjrousos/followers","following_url":"https://api.github.com/users/mjrousos/following{/other_user}","gists_url":"https://api.github.com/users/mjrousos/gists{/gist_id}","starred_url":"https://api.github.com/users/mjrousos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjrousos/subscriptions","organizations_url":"https://api.github.com/users/mjrousos/orgs","repos_url":"https://api.github.com/users/mjrousos/repos","events_url":"https://api.github.com/users/mjrousos/events{/privacy}","received_events_url":"https://api.github.com/users/mjrousos/received_events","type":"User","site_admin":false},"repo":{"id":53510700,"name":"quartznet","full_name":"mjrousos/quartznet","owner":{"login":"mjrousos","id":10077254,"avatar_url":"https://avatars.githubusercontent.com/u/10077254?v=3","gravatar_id":"","url":"https://api.github.com/users/mjrousos","html_url":"https://github.com/mjrousos","followers_url":"https://api.github.com/users/mjrousos/followers","following_url":"https://api.github.com/users/mjrousos/following{/other_user}","gists_url":"https://api.github.com/users/mjrousos/gists{/gist_id}","starred_url":"https://api.github.com/users/mjrousos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjrousos/subscriptions","organizations_url":"https://api.github.com/users/mjrousos/orgs","repos_url":"https://api.github.com/users/mjrousos/repos","events_url":"https://api.github.com/users/mjrousos/events{/privacy}","received_events_url":"https://api.github.com/users/mjrousos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjrousos/quartznet","description":"Quartz Enterprise Scheduler .NET","fork":true,"url":"https://api.github.com/repos/mjrousos/quartznet","forks_url":"https://api.github.com/repos/mjrousos/quartznet/forks","keys_url":"https://api.github.com/repos/mjrousos/quartznet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjrousos/quartznet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjrousos/quartznet/teams","hooks_url":"https://api.github.com/repos/mjrousos/quartznet/hooks","issue_events_url":"https://api.github.com/repos/mjrousos/quartznet/issues/events{/number}","events_url":"https://api.github.com/repos/mjrousos/quartznet/events","assignees_url":"https://api.github.com/repos/mjrousos/quartznet/assignees{/user}","branches_url":"https://api.github.com/repos/mjrousos/quartznet/branches{/branch}","tags_url":"https://api.github.com/repos/mjrousos/quartznet/tags","blobs_url":"https://api.github.com/repos/mjrousos/quartznet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjrousos/quartznet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjrousos/quartznet/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjrousos/quartznet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjrousos/quartznet/statuses/{sha}","languages_url":"https://api.github.com/repos/mjrousos/quartznet/languages","stargazers_url":"https://api.github.com/repos/mjrousos/quartznet/stargazers","contributors_url":"https://api.github.com/repos/mjrousos/quartznet/contributors","subscribers_url":"https://api.github.com/repos/mjrousos/quartznet/subscribers","subscription_url":"https://api.github.com/repos/mjrousos/quartznet/subscription","commits_url":"https://api.github.com/repos/mjrousos/quartznet/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjrousos/quartznet/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjrousos/quartznet/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjrousos/quartznet/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjrousos/quartznet/contents/{+path}","compare_url":"https://api.github.com/repos/mjrousos/quartznet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjrousos/quartznet/merges","archive_url":"https://api.github.com/repos/mjrousos/quartznet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjrousos/quartznet/downloads","issues_url":"https://api.github.com/repos/mjrousos/quartznet/issues{/number}","pulls_url":"https://api.github.com/repos/mjrousos/quartznet/pulls{/number}","milestones_url":"https://api.github.com/repos/mjrousos/quartznet/milestones{/number}","notifications_url":"https://api.github.com/repos/mjrousos/quartznet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjrousos/quartznet/labels{/name}","releases_url":"https://api.github.com/repos/mjrousos/quartznet/releases{/id}","deployments_url":"https://api.github.com/repos/mjrousos/quartznet/deployments","created_at":"2016-03-09T15:53:50Z","updated_at":"2016-03-09T15:53:52Z","pushed_at":"2016-04-27T15:34:27Z","git_url":"git://github.com/mjrousos/quartznet.git","ssh_url":"git@github.com:mjrousos/quartznet.git","clone_url":"https://github.com/mjrousos/quartznet.git","svn_url":"https://github.com/mjrousos/quartznet","homepage":"http://www.quartz-scheduler.net/","size":20431,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"quartznet:quartznet-3","ref":"quartznet-3","sha":"2d51b9396239bf8c5d5b122b18a307022b451f92","user":{"login":"quartznet","id":685655,"avatar_url":"https://avatars.githubusercontent.com/u/685655?v=3","gravatar_id":"","url":"https://api.github.com/users/quartznet","html_url":"https://github.com/quartznet","followers_url":"https://api.github.com/users/quartznet/followers","following_url":"https://api.github.com/users/quartznet/following{/other_user}","gists_url":"https://api.github.com/users/quartznet/gists{/gist_id}","starred_url":"https://api.github.com/users/quartznet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quartznet/subscriptions","organizations_url":"https://api.github.com/users/quartznet/orgs","repos_url":"https://api.github.com/users/quartznet/repos","events_url":"https://api.github.com/users/quartznet/events{/privacy}","received_events_url":"https://api.github.com/users/quartznet/received_events","type":"Organization","site_admin":false},"repo":{"id":1208824,"name":"quartznet","full_name":"quartznet/quartznet","owner":{"login":"quartznet","id":685655,"avatar_url":"https://avatars.githubusercontent.com/u/685655?v=3","gravatar_id":"","url":"https://api.github.com/users/quartznet","html_url":"https://github.com/quartznet","followers_url":"https://api.github.com/users/quartznet/followers","following_url":"https://api.github.com/users/quartznet/following{/other_user}","gists_url":"https://api.github.com/users/quartznet/gists{/gist_id}","starred_url":"https://api.github.com/users/quartznet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quartznet/subscriptions","organizations_url":"https://api.github.com/users/quartznet/orgs","repos_url":"https://api.github.com/users/quartznet/repos","events_url":"https://api.github.com/users/quartznet/events{/privacy}","received_events_url":"https://api.github.com/users/quartznet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quartznet/quartznet","description":"Quartz Enterprise Scheduler .NET","fork":false,"url":"https://api.github.com/repos/quartznet/quartznet","forks_url":"https://api.github.com/repos/quartznet/quartznet/forks","keys_url":"https://api.github.com/repos/quartznet/quartznet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quartznet/quartznet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quartznet/quartznet/teams","hooks_url":"https://api.github.com/repos/quartznet/quartznet/hooks","issue_events_url":"https://api.github.com/repos/quartznet/quartznet/issues/events{/number}","events_url":"https://api.github.com/repos/quartznet/quartznet/events","assignees_url":"https://api.github.com/repos/quartznet/quartznet/assignees{/user}","branches_url":"https://api.github.com/repos/quartznet/quartznet/branches{/branch}","tags_url":"https://api.github.com/repos/quartznet/quartznet/tags","blobs_url":"https://api.github.com/repos/quartznet/quartznet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quartznet/quartznet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quartznet/quartznet/git/refs{/sha}","trees_url":"https://api.github.com/repos/quartznet/quartznet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quartznet/quartznet/statuses/{sha}","languages_url":"https://api.github.com/repos/quartznet/quartznet/languages","stargazers_url":"https://api.github.com/repos/quartznet/quartznet/stargazers","contributors_url":"https://api.github.com/repos/quartznet/quartznet/contributors","subscribers_url":"https://api.github.com/repos/quartznet/quartznet/subscribers","subscription_url":"https://api.github.com/repos/quartznet/quartznet/subscription","commits_url":"https://api.github.com/repos/quartznet/quartznet/commits{/sha}","git_commits_url":"https://api.github.com/repos/quartznet/quartznet/git/commits{/sha}","comments_url":"https://api.github.com/repos/quartznet/quartznet/comments{/number}","issue_comment_url":"https://api.github.com/repos/quartznet/quartznet/issues/comments{/number}","contents_url":"https://api.github.com/repos/quartznet/quartznet/contents/{+path}","compare_url":"https://api.github.com/repos/quartznet/quartznet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quartznet/quartznet/merges","archive_url":"https://api.github.com/repos/quartznet/quartznet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quartznet/quartznet/downloads","issues_url":"https://api.github.com/repos/quartznet/quartznet/issues{/number}","pulls_url":"https://api.github.com/repos/quartznet/quartznet/pulls{/number}","milestones_url":"https://api.github.com/repos/quartznet/quartznet/milestones{/number}","notifications_url":"https://api.github.com/repos/quartznet/quartznet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quartznet/quartznet/labels{/name}","releases_url":"https://api.github.com/repos/quartznet/quartznet/releases{/id}","deployments_url":"https://api.github.com/repos/quartznet/quartznet/deployments","created_at":"2010-12-30T16:29:27Z","updated_at":"2016-04-27T02:48:13Z","pushed_at":"2016-04-27T16:05:23Z","git_url":"git://github.com/quartznet/quartznet.git","ssh_url":"git@github.com:quartznet/quartznet.git","clone_url":"https://github.com/quartznet/quartznet.git","svn_url":"https://github.com/quartznet/quartznet","homepage":"http://www.quartz-scheduler.net/","size":20201,"stargazers_count":1288,"watchers_count":1288,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":432,"mirror_url":null,"open_issues_count":62,"forks":432,"open_issues":62,"watchers":1288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quartznet/quartznet/pulls/359"},"html":{"href":"https://github.com/quartznet/quartznet/pull/359"},"issue":{"href":"https://api.github.com/repos/quartznet/quartznet/issues/359"},"comments":{"href":"https://api.github.com/repos/quartznet/quartznet/issues/359/comments"},"review_comments":{"href":"https://api.github.com/repos/quartznet/quartznet/pulls/359/comments"},"review_comment":{"href":"https://api.github.com/repos/quartznet/quartznet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quartznet/quartznet/pulls/359/commits"},"statuses":{"href":"https://api.github.com/repos/quartznet/quartznet/statuses/85e54cd6d385d18087bbbed9f8839f6e2cde46fb"}}}}