{"action":"created","comment":{"url":"https://api.github.com/repos/OCA/l10n-romania/pulls/comments/84423695","pull_request_review_id":5203321,"id":84423695,"diff_hunk":"@@ -0,0 +1,18 @@\n+# -*- coding: utf-8 -*-\n+# ©  2016 Forest and Biomass Services Romania\n+# See README.rst file on addons root folder for license details\n+\n+from openerp.addons.account_bank_statement_import.tests import (\n+    TestStatementFile)\n+\n+\n+class TestImport(TestStatementFile):\n+    \"\"\"Run test to import MT940 ING import.\"\"\"\n+\n+    def test_statement_import(self):\n+        \"\"\"Test correct creation of single statement.\"\"\"\n+        self._test_statement_import(\n+            'l10n_ro_account_bank_statement_import_mt940_brd', 'test-brd.940',\n+            '00138/1',\n+            start_balance=3885.24, end_balance=3671.88\n+        )","path":"l10n_ro_account_bank_statement_import_mt940_brd/tests/test_import_bank_statement.py","position":18,"original_position":18,"commit_id":"3fd65d94ca48215514319f388b10fe1216b347e4","original_commit_id":"3fd65d94ca48215514319f388b10fe1216b347e4","user":{"login":"pedrobaeza","id":7165771,"avatar_url":"https://avatars.githubusercontent.com/u/7165771?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrobaeza","html_url":"https://github.com/pedrobaeza","followers_url":"https://api.github.com/users/pedrobaeza/followers","following_url":"https://api.github.com/users/pedrobaeza/following{/other_user}","gists_url":"https://api.github.com/users/pedrobaeza/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrobaeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrobaeza/subscriptions","organizations_url":"https://api.github.com/users/pedrobaeza/orgs","repos_url":"https://api.github.com/users/pedrobaeza/repos","events_url":"https://api.github.com/users/pedrobaeza/events{/privacy}","received_events_url":"https://api.github.com/users/pedrobaeza/received_events","type":"User","site_admin":false},"body":"You should make at least basic assert like the number of lines read, and some comparison between hardcoded amounts versus read amounts.","created_at":"2016-10-21T06:15:16Z","updated_at":"2016-10-21T06:15:16Z","html_url":"https://github.com/OCA/l10n-romania/pull/10#discussion_r84423695","pull_request_url":"https://api.github.com/repos/OCA/l10n-romania/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/OCA/l10n-romania/pulls/comments/84423695"},"html":{"href":"https://github.com/OCA/l10n-romania/pull/10#discussion_r84423695"},"pull_request":{"href":"https://api.github.com/repos/OCA/l10n-romania/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/OCA/l10n-romania/pulls/10","id":74559763,"html_url":"https://github.com/OCA/l10n-romania/pull/10","diff_url":"https://github.com/OCA/l10n-romania/pull/10.diff","patch_url":"https://github.com/OCA/l10n-romania/pull/10.patch","issue_url":"https://api.github.com/repos/OCA/l10n-romania/issues/10","number":10,"state":"open","locked":false,"title":"Add module for import BRD MT940bank statements.","user":{"login":"feketemihai","id":7651755,"avatar_url":"https://avatars.githubusercontent.com/u/7651755?v=3","gravatar_id":"","url":"https://api.github.com/users/feketemihai","html_url":"https://github.com/feketemihai","followers_url":"https://api.github.com/users/feketemihai/followers","following_url":"https://api.github.com/users/feketemihai/following{/other_user}","gists_url":"https://api.github.com/users/feketemihai/gists{/gist_id}","starred_url":"https://api.github.com/users/feketemihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feketemihai/subscriptions","organizations_url":"https://api.github.com/users/feketemihai/orgs","repos_url":"https://api.github.com/users/feketemihai/repos","events_url":"https://api.github.com/users/feketemihai/events{/privacy}","received_events_url":"https://api.github.com/users/feketemihai/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-21T06:54:18Z","updated_at":"2016-10-21T06:15:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfc4c76d3e1e4dfecc4bb6f4c84b2267d0221508","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/OCA/l10n-romania/milestones/2","html_url":"https://github.com/OCA/l10n-romania/milestones/8.0","labels_url":"https://api.github.com/repos/OCA/l10n-romania/milestones/2/labels","id":1443527,"number":2,"title":"8.0","description":"","creator":{"login":"feketemihai","id":7651755,"avatar_url":"https://avatars.githubusercontent.com/u/7651755?v=3","gravatar_id":"","url":"https://api.github.com/users/feketemihai","html_url":"https://github.com/feketemihai","followers_url":"https://api.github.com/users/feketemihai/followers","following_url":"https://api.github.com/users/feketemihai/following{/other_user}","gists_url":"https://api.github.com/users/feketemihai/gists{/gist_id}","starred_url":"https://api.github.com/users/feketemihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feketemihai/subscriptions","organizations_url":"https://api.github.com/users/feketemihai/orgs","repos_url":"https://api.github.com/users/feketemihai/repos","events_url":"https://api.github.com/users/feketemihai/events{/privacy}","received_events_url":"https://api.github.com/users/feketemihai/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":5,"state":"open","created_at":"2015-12-04T07:45:22Z","updated_at":"2016-06-22T07:39:51Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/OCA/l10n-romania/pulls/10/commits","review_comments_url":"https://api.github.com/repos/OCA/l10n-romania/pulls/10/comments","review_comment_url":"https://api.github.com/repos/OCA/l10n-romania/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/l10n-romania/issues/10/comments","statuses_url":"https://api.github.com/repos/OCA/l10n-romania/statuses/3fd65d94ca48215514319f388b10fe1216b347e4","head":{"label":"feketemihai:brd_statement_import","ref":"brd_statement_import","sha":"3fd65d94ca48215514319f388b10fe1216b347e4","user":{"login":"feketemihai","id":7651755,"avatar_url":"https://avatars.githubusercontent.com/u/7651755?v=3","gravatar_id":"","url":"https://api.github.com/users/feketemihai","html_url":"https://github.com/feketemihai","followers_url":"https://api.github.com/users/feketemihai/followers","following_url":"https://api.github.com/users/feketemihai/following{/other_user}","gists_url":"https://api.github.com/users/feketemihai/gists{/gist_id}","starred_url":"https://api.github.com/users/feketemihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feketemihai/subscriptions","organizations_url":"https://api.github.com/users/feketemihai/orgs","repos_url":"https://api.github.com/users/feketemihai/repos","events_url":"https://api.github.com/users/feketemihai/events{/privacy}","received_events_url":"https://api.github.com/users/feketemihai/received_events","type":"User","site_admin":false},"repo":{"id":47309613,"name":"l10n-romania-1","full_name":"feketemihai/l10n-romania-1","owner":{"login":"feketemihai","id":7651755,"avatar_url":"https://avatars.githubusercontent.com/u/7651755?v=3","gravatar_id":"","url":"https://api.github.com/users/feketemihai","html_url":"https://github.com/feketemihai","followers_url":"https://api.github.com/users/feketemihai/followers","following_url":"https://api.github.com/users/feketemihai/following{/other_user}","gists_url":"https://api.github.com/users/feketemihai/gists{/gist_id}","starred_url":"https://api.github.com/users/feketemihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feketemihai/subscriptions","organizations_url":"https://api.github.com/users/feketemihai/orgs","repos_url":"https://api.github.com/users/feketemihai/repos","events_url":"https://api.github.com/users/feketemihai/events{/privacy}","received_events_url":"https://api.github.com/users/feketemihai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/feketemihai/l10n-romania-1","description":"Romanian Localization for Odoo","fork":true,"url":"https://api.github.com/repos/feketemihai/l10n-romania-1","forks_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/forks","keys_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/teams","hooks_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/hooks","issue_events_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/issues/events{/number}","events_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/events","assignees_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/assignees{/user}","branches_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/branches{/branch}","tags_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/tags","blobs_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/statuses/{sha}","languages_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/languages","stargazers_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/stargazers","contributors_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/contributors","subscribers_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/subscribers","subscription_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/subscription","commits_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/contents/{+path}","compare_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/merges","archive_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/downloads","issues_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/issues{/number}","pulls_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/pulls{/number}","milestones_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/milestones{/number}","notifications_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/labels{/name}","releases_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/releases{/id}","deployments_url":"https://api.github.com/repos/feketemihai/l10n-romania-1/deployments","created_at":"2015-12-03T05:13:27Z","updated_at":"2015-04-01T10:54:48Z","pushed_at":"2016-06-27T05:45:09Z","git_url":"git://github.com/feketemihai/l10n-romania-1.git","ssh_url":"git@github.com:feketemihai/l10n-romania-1.git","clone_url":"https://github.com/feketemihai/l10n-romania-1.git","svn_url":"https://github.com/feketemihai/l10n-romania-1","homepage":null,"size":2537,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"9.0"}},"base":{"label":"OCA:8.0","ref":"8.0","sha":"36799da279d39d05eedd9598669ef091292a00e2","user":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":32791976,"name":"l10n-romania","full_name":"OCA/l10n-romania","owner":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/l10n-romania","description":"Romanian Localization for Odoo","fork":false,"url":"https://api.github.com/repos/OCA/l10n-romania","forks_url":"https://api.github.com/repos/OCA/l10n-romania/forks","keys_url":"https://api.github.com/repos/OCA/l10n-romania/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/l10n-romania/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/l10n-romania/teams","hooks_url":"https://api.github.com/repos/OCA/l10n-romania/hooks","issue_events_url":"https://api.github.com/repos/OCA/l10n-romania/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/l10n-romania/events","assignees_url":"https://api.github.com/repos/OCA/l10n-romania/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/l10n-romania/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/l10n-romania/tags","blobs_url":"https://api.github.com/repos/OCA/l10n-romania/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/l10n-romania/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/l10n-romania/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/l10n-romania/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/l10n-romania/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/l10n-romania/languages","stargazers_url":"https://api.github.com/repos/OCA/l10n-romania/stargazers","contributors_url":"https://api.github.com/repos/OCA/l10n-romania/contributors","subscribers_url":"https://api.github.com/repos/OCA/l10n-romania/subscribers","subscription_url":"https://api.github.com/repos/OCA/l10n-romania/subscription","commits_url":"https://api.github.com/repos/OCA/l10n-romania/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/l10n-romania/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/l10n-romania/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/l10n-romania/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/l10n-romania/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/l10n-romania/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/l10n-romania/merges","archive_url":"https://api.github.com/repos/OCA/l10n-romania/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/l10n-romania/downloads","issues_url":"https://api.github.com/repos/OCA/l10n-romania/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/l10n-romania/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/l10n-romania/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/l10n-romania/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/l10n-romania/labels{/name}","releases_url":"https://api.github.com/repos/OCA/l10n-romania/releases{/id}","deployments_url":"https://api.github.com/repos/OCA/l10n-romania/deployments","created_at":"2015-03-24T10:34:55Z","updated_at":"2016-04-14T02:45:06Z","pushed_at":"2016-10-08T17:34:34Z","git_url":"git://github.com/OCA/l10n-romania.git","ssh_url":"git@github.com:OCA/l10n-romania.git","clone_url":"https://github.com/OCA/l10n-romania.git","svn_url":"https://github.com/OCA/l10n-romania","homepage":null,"size":2556,"stargazers_count":2,"watchers_count":2,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":2,"default_branch":"10.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/l10n-romania/pulls/10"},"html":{"href":"https://github.com/OCA/l10n-romania/pull/10"},"issue":{"href":"https://api.github.com/repos/OCA/l10n-romania/issues/10"},"comments":{"href":"https://api.github.com/repos/OCA/l10n-romania/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/l10n-romania/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/l10n-romania/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/l10n-romania/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/l10n-romania/statuses/3fd65d94ca48215514319f388b10fe1216b347e4"}}}}
{"actor":{"display_login":"pedrobaeza"}}