{"action":"closed","issue":{"url":"https://api.github.com/repos/Jumpscale/jumpscale_core8/issues/257","repository_url":"https://api.github.com/repos/Jumpscale/jumpscale_core8","labels_url":"https://api.github.com/repos/Jumpscale/jumpscale_core8/issues/257/labels{/name}","comments_url":"https://api.github.com/repos/Jumpscale/jumpscale_core8/issues/257/comments","events_url":"https://api.github.com/repos/Jumpscale/jumpscale_core8/issues/257/events","html_url":"https://github.com/Jumpscale/jumpscale_core8/issues/257","id":157782175,"number":257,"title":"ActionDecorator unittest fails","user":{"login":"ahussein","id":60262,"avatar_url":"https://avatars.githubusercontent.com/u/60262?v=3","gravatar_id":"","url":"https://api.github.com/users/ahussein","html_url":"https://github.com/ahussein","followers_url":"https://api.github.com/users/ahussein/followers","following_url":"https://api.github.com/users/ahussein/following{/other_user}","gists_url":"https://api.github.com/users/ahussein/gists{/gist_id}","starred_url":"https://api.github.com/users/ahussein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahussein/subscriptions","organizations_url":"https://api.github.com/users/ahussein/orgs","repos_url":"https://api.github.com/users/ahussein/repos","events_url":"https://api.github.com/users/ahussein/events{/privacy}","received_events_url":"https://api.github.com/users/ahussein/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Jumpscale/jumpscale_core8/labels/state_inprogress","name":"state_inprogress","color":"c2e0c6"}],"state":"closed","locked":false,"assignee":{"login":"xmonader","id":64129,"avatar_url":"https://avatars.githubusercontent.com/u/64129?v=3","gravatar_id":"","url":"https://api.github.com/users/xmonader","html_url":"https://github.com/xmonader","followers_url":"https://api.github.com/users/xmonader/followers","following_url":"https://api.github.com/users/xmonader/following{/other_user}","gists_url":"https://api.github.com/users/xmonader/gists{/gist_id}","starred_url":"https://api.github.com/users/xmonader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmonader/subscriptions","organizations_url":"https://api.github.com/users/xmonader/orgs","repos_url":"https://api.github.com/users/xmonader/repos","events_url":"https://api.github.com/users/xmonader/events{/privacy}","received_events_url":"https://api.github.com/users/xmonader/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2016-05-31T22:10:21Z","updated_at":"2016-06-07T14:13:11Z","closed_at":"2016-06-07T14:13:11Z","body":"First attempt to write unittests for JumpScale.tools.cuisine.ActionDecorator showed a bug when passing action flag as False\r\ncheck the test case in https://github.com/Jumpscale/jumpscale_core8/blob/tools_unittests/tests/tools/cuisine/TestActionDecorator.py\r\n\r\nresult of running the tests:\r\n\r\n```\r\nroot@697e6b49fda1:/opt/jumpscale8# nosetests tests/\r\nE.\r\n======================================================================\r\nERROR: Test call a decorated action\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/opt/jumpscale8/tests/tools/cuisine/TestActionDecorator.py\", line 51, in test_call_actoindecorator\r\n    action()\r\n  File \"/opt/jumpscale8/lib/JumpScale/tools/cuisine/ActionDecorator.py\", line 20, in wrapper\r\n    cuisine=args[0].cuisine\r\nIndexError: tuple index out of range\r\n\r\n----------------------------------------------------------------------\r\nRan 2 tests in 0.001s\r\n\r\nFAILED (errors=1)\r\nroot@697e6b49fda1:/opt/jumpscale8# \r\n```\r\n\r\nif the action flag is set to False then the code should not expect there will be an cuisine object in the argument list of the function.\r\n"}}
{"actor":{"display_login":"rkhamis"}}