{"action":"closed","number":175,"pull_request":{"url":"https://api.github.com/repos/bluss/rust-ndarray/pulls/175","id":64516960,"html_url":"https://github.com/bluss/rust-ndarray/pull/175","diff_url":"https://github.com/bluss/rust-ndarray/pull/175.diff","patch_url":"https://github.com/bluss/rust-ndarray/pull/175.patch","issue_url":"https://api.github.com/repos/bluss/rust-ndarray/issues/175","number":175,"state":"closed","locked":false,"title":"Depend on crate matrixmultiply for f32, f64 matrix multiplication","user":{"login":"bluss","id":3209739,"avatar_url":"https://avatars.githubusercontent.com/u/3209739?v=3","gravatar_id":"","url":"https://api.github.com/users/bluss","html_url":"https://github.com/bluss","followers_url":"https://api.github.com/users/bluss/followers","following_url":"https://api.github.com/users/bluss/following{/other_user}","gists_url":"https://api.github.com/users/bluss/gists{/gist_id}","starred_url":"https://api.github.com/users/bluss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluss/subscriptions","organizations_url":"https://api.github.com/users/bluss/orgs","repos_url":"https://api.github.com/users/bluss/repos","events_url":"https://api.github.com/users/bluss/events{/privacy}","received_events_url":"https://api.github.com/users/bluss/received_events","type":"User","site_admin":false},"body":"The crate matrixmultiply (written by me) uses a solid approach to matrix\r\nmultiplication for floats. It is so far in plain rust and outperforms\r\nnaive multiplication by a ton.\r\n\r\nSee result of using matrixmultiply instead of the naive algorithm,\r\nhere for a 64 by 64 matrix multiplication, f32.\r\n\r\n```\r\nname               before ns/iter  after ns/iter    diff ns/iter   diff %\r\nmat_mul_f32::m064  258,969         31,093               -227,876  -87.99%\r\n```\r\n\r\nAnother benefit of matrixmultiply is that it supports our general striding scheme. That means it's a good fallback even if we use OpenBLAS for example (which does not handle general strides, i.e where both strides are != 1).\r\n\r\n\r\n(Also added more benchmarks and tests.)","created_at":"2016-03-29T19:06:38Z","updated_at":"2016-03-29T20:58:25Z","closed_at":"2016-03-29T20:58:25Z","merged_at":"2016-03-29T20:58:25Z","merge_commit_sha":"5cc4b8af87ad03dd10ba69665fb8ee40d2ac3896","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bluss/rust-ndarray/pulls/175/commits","review_comments_url":"https://api.github.com/repos/bluss/rust-ndarray/pulls/175/comments","review_comment_url":"https://api.github.com/repos/bluss/rust-ndarray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bluss/rust-ndarray/issues/175/comments","statuses_url":"https://api.github.com/repos/bluss/rust-ndarray/statuses/aa52622621fbc56123c84543ec9c1f4099b286b6","head":{"label":"bluss:matrixmultiply","ref":"matrixmultiply","sha":"aa52622621fbc56123c84543ec9c1f4099b286b6","user":{"login":"bluss","id":3209739,"avatar_url":"https://avatars.githubusercontent.com/u/3209739?v=3","gravatar_id":"","url":"https://api.github.com/users/bluss","html_url":"https://github.com/bluss","followers_url":"https://api.github.com/users/bluss/followers","following_url":"https://api.github.com/users/bluss/following{/other_user}","gists_url":"https://api.github.com/users/bluss/gists{/gist_id}","starred_url":"https://api.github.com/users/bluss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluss/subscriptions","organizations_url":"https://api.github.com/users/bluss/orgs","repos_url":"https://api.github.com/users/bluss/repos","events_url":"https://api.github.com/users/bluss/events{/privacy}","received_events_url":"https://api.github.com/users/bluss/received_events","type":"User","site_admin":false},"repo":{"id":22598813,"name":"rust-ndarray","full_name":"bluss/rust-ndarray","owner":{"login":"bluss","id":3209739,"avatar_url":"https://avatars.githubusercontent.com/u/3209739?v=3","gravatar_id":"","url":"https://api.github.com/users/bluss","html_url":"https://github.com/bluss","followers_url":"https://api.github.com/users/bluss/followers","following_url":"https://api.github.com/users/bluss/following{/other_user}","gists_url":"https://api.github.com/users/bluss/gists{/gist_id}","starred_url":"https://api.github.com/users/bluss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluss/subscriptions","organizations_url":"https://api.github.com/users/bluss/orgs","repos_url":"https://api.github.com/users/bluss/repos","events_url":"https://api.github.com/users/bluss/events{/privacy}","received_events_url":"https://api.github.com/users/bluss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bluss/rust-ndarray","description":"ndarray: an N-dimensional array with array views, multidimensional slicing, and efficient operations","fork":false,"url":"https://api.github.com/repos/bluss/rust-ndarray","forks_url":"https://api.github.com/repos/bluss/rust-ndarray/forks","keys_url":"https://api.github.com/repos/bluss/rust-ndarray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bluss/rust-ndarray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bluss/rust-ndarray/teams","hooks_url":"https://api.github.com/repos/bluss/rust-ndarray/hooks","issue_events_url":"https://api.github.com/repos/bluss/rust-ndarray/issues/events{/number}","events_url":"https://api.github.com/repos/bluss/rust-ndarray/events","assignees_url":"https://api.github.com/repos/bluss/rust-ndarray/assignees{/user}","branches_url":"https://api.github.com/repos/bluss/rust-ndarray/branches{/branch}","tags_url":"https://api.github.com/repos/bluss/rust-ndarray/tags","blobs_url":"https://api.github.com/repos/bluss/rust-ndarray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bluss/rust-ndarray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bluss/rust-ndarray/git/refs{/sha}","trees_url":"https://api.github.com/repos/bluss/rust-ndarray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bluss/rust-ndarray/statuses/{sha}","languages_url":"https://api.github.com/repos/bluss/rust-ndarray/languages","stargazers_url":"https://api.github.com/repos/bluss/rust-ndarray/stargazers","contributors_url":"https://api.github.com/repos/bluss/rust-ndarray/contributors","subscribers_url":"https://api.github.com/repos/bluss/rust-ndarray/subscribers","subscription_url":"https://api.github.com/repos/bluss/rust-ndarray/subscription","commits_url":"https://api.github.com/repos/bluss/rust-ndarray/commits{/sha}","git_commits_url":"https://api.github.com/repos/bluss/rust-ndarray/git/commits{/sha}","comments_url":"https://api.github.com/repos/bluss/rust-ndarray/comments{/number}","issue_comment_url":"https://api.github.com/repos/bluss/rust-ndarray/issues/comments{/number}","contents_url":"https://api.github.com/repos/bluss/rust-ndarray/contents/{+path}","compare_url":"https://api.github.com/repos/bluss/rust-ndarray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bluss/rust-ndarray/merges","archive_url":"https://api.github.com/repos/bluss/rust-ndarray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bluss/rust-ndarray/downloads","issues_url":"https://api.github.com/repos/bluss/rust-ndarray/issues{/number}","pulls_url":"https://api.github.com/repos/bluss/rust-ndarray/pulls{/number}","milestones_url":"https://api.github.com/repos/bluss/rust-ndarray/milestones{/number}","notifications_url":"https://api.github.com/repos/bluss/rust-ndarray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bluss/rust-ndarray/labels{/name}","releases_url":"https://api.github.com/repos/bluss/rust-ndarray/releases{/id}","deployments_url":"https://api.github.com/repos/bluss/rust-ndarray/deployments","created_at":"2014-08-04T09:27:53Z","updated_at":"2016-03-29T18:17:51Z","pushed_at":"2016-03-29T20:58:25Z","git_url":"git://github.com/bluss/rust-ndarray.git","ssh_url":"git@github.com:bluss/rust-ndarray.git","clone_url":"https://github.com/bluss/rust-ndarray.git","svn_url":"https://github.com/bluss/rust-ndarray","homepage":"https://bluss.github.io/rust-ndarray/","size":2152,"stargazers_count":102,"watchers_count":102,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":37,"forks":16,"open_issues":37,"watchers":102,"default_branch":"master"}},"base":{"label":"bluss:master","ref":"master","sha":"4e64505ad4e048a20ffc8a95b7fc7f7f1787f254","user":{"login":"bluss","id":3209739,"avatar_url":"https://avatars.githubusercontent.com/u/3209739?v=3","gravatar_id":"","url":"https://api.github.com/users/bluss","html_url":"https://github.com/bluss","followers_url":"https://api.github.com/users/bluss/followers","following_url":"https://api.github.com/users/bluss/following{/other_user}","gists_url":"https://api.github.com/users/bluss/gists{/gist_id}","starred_url":"https://api.github.com/users/bluss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluss/subscriptions","organizations_url":"https://api.github.com/users/bluss/orgs","repos_url":"https://api.github.com/users/bluss/repos","events_url":"https://api.github.com/users/bluss/events{/privacy}","received_events_url":"https://api.github.com/users/bluss/received_events","type":"User","site_admin":false},"repo":{"id":22598813,"name":"rust-ndarray","full_name":"bluss/rust-ndarray","owner":{"login":"bluss","id":3209739,"avatar_url":"https://avatars.githubusercontent.com/u/3209739?v=3","gravatar_id":"","url":"https://api.github.com/users/bluss","html_url":"https://github.com/bluss","followers_url":"https://api.github.com/users/bluss/followers","following_url":"https://api.github.com/users/bluss/following{/other_user}","gists_url":"https://api.github.com/users/bluss/gists{/gist_id}","starred_url":"https://api.github.com/users/bluss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluss/subscriptions","organizations_url":"https://api.github.com/users/bluss/orgs","repos_url":"https://api.github.com/users/bluss/repos","events_url":"https://api.github.com/users/bluss/events{/privacy}","received_events_url":"https://api.github.com/users/bluss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bluss/rust-ndarray","description":"ndarray: an N-dimensional array with array views, multidimensional slicing, and efficient operations","fork":false,"url":"https://api.github.com/repos/bluss/rust-ndarray","forks_url":"https://api.github.com/repos/bluss/rust-ndarray/forks","keys_url":"https://api.github.com/repos/bluss/rust-ndarray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bluss/rust-ndarray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bluss/rust-ndarray/teams","hooks_url":"https://api.github.com/repos/bluss/rust-ndarray/hooks","issue_events_url":"https://api.github.com/repos/bluss/rust-ndarray/issues/events{/number}","events_url":"https://api.github.com/repos/bluss/rust-ndarray/events","assignees_url":"https://api.github.com/repos/bluss/rust-ndarray/assignees{/user}","branches_url":"https://api.github.com/repos/bluss/rust-ndarray/branches{/branch}","tags_url":"https://api.github.com/repos/bluss/rust-ndarray/tags","blobs_url":"https://api.github.com/repos/bluss/rust-ndarray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bluss/rust-ndarray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bluss/rust-ndarray/git/refs{/sha}","trees_url":"https://api.github.com/repos/bluss/rust-ndarray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bluss/rust-ndarray/statuses/{sha}","languages_url":"https://api.github.com/repos/bluss/rust-ndarray/languages","stargazers_url":"https://api.github.com/repos/bluss/rust-ndarray/stargazers","contributors_url":"https://api.github.com/repos/bluss/rust-ndarray/contributors","subscribers_url":"https://api.github.com/repos/bluss/rust-ndarray/subscribers","subscription_url":"https://api.github.com/repos/bluss/rust-ndarray/subscription","commits_url":"https://api.github.com/repos/bluss/rust-ndarray/commits{/sha}","git_commits_url":"https://api.github.com/repos/bluss/rust-ndarray/git/commits{/sha}","comments_url":"https://api.github.com/repos/bluss/rust-ndarray/comments{/number}","issue_comment_url":"https://api.github.com/repos/bluss/rust-ndarray/issues/comments{/number}","contents_url":"https://api.github.com/repos/bluss/rust-ndarray/contents/{+path}","compare_url":"https://api.github.com/repos/bluss/rust-ndarray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bluss/rust-ndarray/merges","archive_url":"https://api.github.com/repos/bluss/rust-ndarray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bluss/rust-ndarray/downloads","issues_url":"https://api.github.com/repos/bluss/rust-ndarray/issues{/number}","pulls_url":"https://api.github.com/repos/bluss/rust-ndarray/pulls{/number}","milestones_url":"https://api.github.com/repos/bluss/rust-ndarray/milestones{/number}","notifications_url":"https://api.github.com/repos/bluss/rust-ndarray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bluss/rust-ndarray/labels{/name}","releases_url":"https://api.github.com/repos/bluss/rust-ndarray/releases{/id}","deployments_url":"https://api.github.com/repos/bluss/rust-ndarray/deployments","created_at":"2014-08-04T09:27:53Z","updated_at":"2016-03-29T18:17:51Z","pushed_at":"2016-03-29T20:58:25Z","git_url":"git://github.com/bluss/rust-ndarray.git","ssh_url":"git@github.com:bluss/rust-ndarray.git","clone_url":"https://github.com/bluss/rust-ndarray.git","svn_url":"https://github.com/bluss/rust-ndarray","homepage":"https://bluss.github.io/rust-ndarray/","size":2152,"stargazers_count":102,"watchers_count":102,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":37,"forks":16,"open_issues":37,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bluss/rust-ndarray/pulls/175"},"html":{"href":"https://github.com/bluss/rust-ndarray/pull/175"},"issue":{"href":"https://api.github.com/repos/bluss/rust-ndarray/issues/175"},"comments":{"href":"https://api.github.com/repos/bluss/rust-ndarray/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/bluss/rust-ndarray/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/bluss/rust-ndarray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bluss/rust-ndarray/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/bluss/rust-ndarray/statuses/aa52622621fbc56123c84543ec9c1f4099b286b6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bluss","id":3209739,"avatar_url":"https://avatars.githubusercontent.com/u/3209739?v=3","gravatar_id":"","url":"https://api.github.com/users/bluss","html_url":"https://github.com/bluss","followers_url":"https://api.github.com/users/bluss/followers","following_url":"https://api.github.com/users/bluss/following{/other_user}","gists_url":"https://api.github.com/users/bluss/gists{/gist_id}","starred_url":"https://api.github.com/users/bluss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluss/subscriptions","organizations_url":"https://api.github.com/users/bluss/orgs","repos_url":"https://api.github.com/users/bluss/repos","events_url":"https://api.github.com/users/bluss/events{/privacy}","received_events_url":"https://api.github.com/users/bluss/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":9,"additions":160,"deletions":28,"changed_files":6}}