{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/comments/89364890","pull_request_review_id":9909767,"id":89364890,"diff_hunk":"@@ -0,0 +1,125 @@\n+﻿// Copyright 2016 Google Inc. All Rights Reserved.\n+// \n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+// \n+//     http://www.apache.org/licenses/LICENSE-2.0\n+// \n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+using Moq;\n+using System.Collections.Generic;\n+using System.Diagnostics;\n+using System.IO;\n+using System.Reflection;\n+using System.Text.RegularExpressions;\n+using System.Web;\n+using Xunit;\n+\n+namespace Google.Devtools.AspNet.Tests.CloudTrace\n+{\n+    public class LabelsTest\n+    {\n+        [Fact]\n+        public void FromHttpRequestWrapper()\n+        {\n+            HttpRequest request = new HttpRequest(\"name\", \"https://google.com\", \"\");\n+            Mock<HttpRequestWrapper> mockWrapper = new Mock<HttpRequestWrapper>(request);","path":"apis/Google.Devtools.AspNet/Google.Devtools.AspNet.Tests/CloudTrace/LabelsTest.cs","position":32,"original_position":32,"commit_id":"83597bc264721b149fc3acdea57062deb291b854","original_commit_id":"83597bc264721b149fc3acdea57062deb291b854","user":{"login":"jskeet","id":17011,"avatar_url":"https://avatars.githubusercontent.com/u/17011?v=3","gravatar_id":"","url":"https://api.github.com/users/jskeet","html_url":"https://github.com/jskeet","followers_url":"https://api.github.com/users/jskeet/followers","following_url":"https://api.github.com/users/jskeet/following{/other_user}","gists_url":"https://api.github.com/users/jskeet/gists{/gist_id}","starred_url":"https://api.github.com/users/jskeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskeet/subscriptions","organizations_url":"https://api.github.com/users/jskeet/orgs","repos_url":"https://api.github.com/users/jskeet/repos","events_url":"https://api.github.com/users/jskeet/events{/privacy}","received_events_url":"https://api.github.com/users/jskeet/received_events","type":"User","site_admin":false},"body":"Why not just call `new HttpRequestWrapper(request)` and make sure the request has the information we need? I think it's cleaner not to use mocks unless we care about the interaction side (or have to for another reason).","created_at":"2016-11-23T17:35:12Z","updated_at":"2016-11-23T17:35:12Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/570#discussion_r89364890","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/570","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/comments/89364890"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/570#discussion_r89364890"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/570"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/570","id":95047199,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/570","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/570.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/570.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/570","number":570,"state":"open","locked":false,"title":"Unit tests for the Trace Instrumentation Library","user":{"login":"iantalarico","id":5264734,"avatar_url":"https://avatars.githubusercontent.com/u/5264734?v=3","gravatar_id":"","url":"https://api.github.com/users/iantalarico","html_url":"https://github.com/iantalarico","followers_url":"https://api.github.com/users/iantalarico/followers","following_url":"https://api.github.com/users/iantalarico/following{/other_user}","gists_url":"https://api.github.com/users/iantalarico/gists{/gist_id}","starred_url":"https://api.github.com/users/iantalarico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iantalarico/subscriptions","organizations_url":"https://api.github.com/users/iantalarico/orgs","repos_url":"https://api.github.com/users/iantalarico/repos","events_url":"https://api.github.com/users/iantalarico/events{/privacy}","received_events_url":"https://api.github.com/users/iantalarico/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-23T17:24:51Z","updated_at":"2016-11-23T17:50:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76133d77b6eebd42c04e812084e7c52b245282e8","assignee":{"login":"jskeet","id":17011,"avatar_url":"https://avatars.githubusercontent.com/u/17011?v=3","gravatar_id":"","url":"https://api.github.com/users/jskeet","html_url":"https://github.com/jskeet","followers_url":"https://api.github.com/users/jskeet/followers","following_url":"https://api.github.com/users/jskeet/following{/other_user}","gists_url":"https://api.github.com/users/jskeet/gists{/gist_id}","starred_url":"https://api.github.com/users/jskeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskeet/subscriptions","organizations_url":"https://api.github.com/users/jskeet/orgs","repos_url":"https://api.github.com/users/jskeet/repos","events_url":"https://api.github.com/users/jskeet/events{/privacy}","received_events_url":"https://api.github.com/users/jskeet/received_events","type":"User","site_admin":false},"assignees":[{"login":"jskeet","id":17011,"avatar_url":"https://avatars.githubusercontent.com/u/17011?v=3","gravatar_id":"","url":"https://api.github.com/users/jskeet","html_url":"https://github.com/jskeet","followers_url":"https://api.github.com/users/jskeet/followers","following_url":"https://api.github.com/users/jskeet/following{/other_user}","gists_url":"https://api.github.com/users/jskeet/gists{/gist_id}","starred_url":"https://api.github.com/users/jskeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskeet/subscriptions","organizations_url":"https://api.github.com/users/jskeet/orgs","repos_url":"https://api.github.com/users/jskeet/repos","events_url":"https://api.github.com/users/jskeet/events{/privacy}","received_events_url":"https://api.github.com/users/jskeet/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/570/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/570/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/570/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/statuses/83597bc264721b149fc3acdea57062deb291b854","head":{"label":"iantalarico:trace-tests","ref":"trace-tests","sha":"83597bc264721b149fc3acdea57062deb291b854","user":{"login":"iantalarico","id":5264734,"avatar_url":"https://avatars.githubusercontent.com/u/5264734?v=3","gravatar_id":"","url":"https://api.github.com/users/iantalarico","html_url":"https://github.com/iantalarico","followers_url":"https://api.github.com/users/iantalarico/followers","following_url":"https://api.github.com/users/iantalarico/following{/other_user}","gists_url":"https://api.github.com/users/iantalarico/gists{/gist_id}","starred_url":"https://api.github.com/users/iantalarico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iantalarico/subscriptions","organizations_url":"https://api.github.com/users/iantalarico/orgs","repos_url":"https://api.github.com/users/iantalarico/repos","events_url":"https://api.github.com/users/iantalarico/events{/privacy}","received_events_url":"https://api.github.com/users/iantalarico/received_events","type":"User","site_admin":false},"repo":{"id":70508946,"name":"google-cloud-dotnet","full_name":"iantalarico/google-cloud-dotnet","owner":{"login":"iantalarico","id":5264734,"avatar_url":"https://avatars.githubusercontent.com/u/5264734?v=3","gravatar_id":"","url":"https://api.github.com/users/iantalarico","html_url":"https://github.com/iantalarico","followers_url":"https://api.github.com/users/iantalarico/followers","following_url":"https://api.github.com/users/iantalarico/following{/other_user}","gists_url":"https://api.github.com/users/iantalarico/gists{/gist_id}","starred_url":"https://api.github.com/users/iantalarico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iantalarico/subscriptions","organizations_url":"https://api.github.com/users/iantalarico/orgs","repos_url":"https://api.github.com/users/iantalarico/repos","events_url":"https://api.github.com/users/iantalarico/events{/privacy}","received_events_url":"https://api.github.com/users/iantalarico/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iantalarico/google-cloud-dotnet","description":"Google Cloud Client Library for .NET","fork":true,"url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet","forks_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/forks","keys_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/teams","hooks_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/hooks","issue_events_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/events","assignees_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/tags","blobs_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/languages","stargazers_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/stargazers","contributors_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/contributors","subscribers_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/subscribers","subscription_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/subscription","commits_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/merges","archive_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/downloads","issues_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/iantalarico/google-cloud-dotnet/deployments","created_at":"2016-10-10T16:52:40Z","updated_at":"2016-10-10T16:52:42Z","pushed_at":"2016-11-23T17:47:42Z","git_url":"git://github.com/iantalarico/google-cloud-dotnet.git","ssh_url":"git@github.com:iantalarico/google-cloud-dotnet.git","clone_url":"https://github.com/iantalarico/google-cloud-dotnet.git","svn_url":"https://github.com/iantalarico/google-cloud-dotnet","homepage":"https://googlecloudplatform.github.io/google-cloud-dotnet/","size":9443,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"9cb8f36536c61c047410d6b16ff085ef761b887e","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":35877412,"name":"google-cloud-dotnet","full_name":"GoogleCloudPlatform/google-cloud-dotnet","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet","description":"Google Cloud Client Library for .NET","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/deployments","created_at":"2015-05-19T11:14:02Z","updated_at":"2016-11-13T02:07:04Z","pushed_at":"2016-11-23T17:38:18Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-dotnet.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-dotnet.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet","homepage":"https://googlecloudplatform.github.io/google-cloud-dotnet/","size":12691,"stargazers_count":55,"watchers_count":55,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"open_issues_count":51,"forks":26,"open_issues":51,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/570"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/570"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/570"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/570/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/570/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/570/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/statuses/83597bc264721b149fc3acdea57062deb291b854"}}}}
{"actor":{"display_login":"jskeet"}}