{"action":"created","comment":{"url":"https://api.github.com/repos/square/sqldelight/pulls/comments/65820580","id":65820580,"diff_hunk":"@@ -185,6 +185,50 @@\n   @NonNull\n   HockeyPlayer.Position position();\n \n+  interface Select_allModel {\n+    HockeyPlayerModel hockey_player();\n+\n+    TeamModel team();\n+  }\n+\n+  interface For_teamModel {\n+    HockeyPlayerModel hockey_player();\n+\n+    TeamModel team();\n+  }\n+\n+  interface Subquery_joinModel {\n+    long _id();\n+\n+    int age();\n+  }\n+\n+  interface Select_expressionModel {\n+    String first_name();\n+\n+    long count();\n+  }\n+\n+  interface Expression_subqueryModel {\n+    HockeyPlayerModel hockey_player();\n+\n+    long size();\n+  }\n+\n+  interface Some_joinModel {\n+    HockeyPlayerModel hockey_player();\n+\n+    TeamModel team();\n+  }\n+\n+  interface With_queryModel {","path":"sqldelight-gradle-plugin/src/test/fixtures/well-formed-selects/expected/com/sample/HockeyPlayerModel.java","position":40,"original_position":40,"commit_id":"ada4e048e3e98b5608d6deb3f561d1decd96bacb","original_commit_id":"ada4e048e3e98b5608d6deb3f561d1decd96bacb","user":{"login":"AlecStrong","id":1675456,"avatar_url":"https://avatars.githubusercontent.com/u/1675456?v=3","gravatar_id":"","url":"https://api.github.com/users/AlecStrong","html_url":"https://github.com/AlecStrong","followers_url":"https://api.github.com/users/AlecStrong/followers","following_url":"https://api.github.com/users/AlecStrong/following{/other_user}","gists_url":"https://api.github.com/users/AlecStrong/gists{/gist_id}","starred_url":"https://api.github.com/users/AlecStrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlecStrong/subscriptions","organizations_url":"https://api.github.com/users/AlecStrong/orgs","repos_url":"https://api.github.com/users/AlecStrong/repos","events_url":"https://api.github.com/users/AlecStrong/events{/privacy}","received_events_url":"https://api.github.com/users/AlecStrong/received_events","type":"User","site_admin":false},"body":"I'm a bit more in favour of leaving the casing as camel for the string constants","created_at":"2016-06-05T17:01:10Z","updated_at":"2016-06-05T17:01:10Z","html_url":"https://github.com/square/sqldelight/pull/312#discussion_r65820580","pull_request_url":"https://api.github.com/repos/square/sqldelight/pulls/312","_links":{"self":{"href":"https://api.github.com/repos/square/sqldelight/pulls/comments/65820580"},"html":{"href":"https://github.com/square/sqldelight/pull/312#discussion_r65820580"},"pull_request":{"href":"https://api.github.com/repos/square/sqldelight/pulls/312"}}},"pull_request":{"url":"https://api.github.com/repos/square/sqldelight/pulls/312","id":72633166,"html_url":"https://github.com/square/sqldelight/pull/312","diff_url":"https://github.com/square/sqldelight/pull/312.diff","patch_url":"https://github.com/square/sqldelight/pull/312.patch","issue_url":"https://api.github.com/repos/square/sqldelight/issues/312","number":312,"state":"closed","locked":false,"title":"Generate mapper interfaces for queries","user":{"login":"AlecStrong","id":1675456,"avatar_url":"https://avatars.githubusercontent.com/u/1675456?v=3","gravatar_id":"","url":"https://api.github.com/users/AlecStrong","html_url":"https://github.com/AlecStrong","followers_url":"https://api.github.com/users/AlecStrong/followers","following_url":"https://api.github.com/users/AlecStrong/following{/other_user}","gists_url":"https://api.github.com/users/AlecStrong/gists{/gist_id}","starred_url":"https://api.github.com/users/AlecStrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlecStrong/subscriptions","organizations_url":"https://api.github.com/users/AlecStrong/orgs","repos_url":"https://api.github.com/users/AlecStrong/repos","events_url":"https://api.github.com/users/AlecStrong/events{/privacy}","received_events_url":"https://api.github.com/users/AlecStrong/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-05T16:05:35Z","updated_at":"2016-06-05T17:01:10Z","closed_at":"2016-06-05T16:55:32Z","merged_at":"2016-06-05T16:55:32Z","merge_commit_sha":"8639a627808bbe5e80e32c5670a997d83c3bab65","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/square/sqldelight/pulls/312/commits","review_comments_url":"https://api.github.com/repos/square/sqldelight/pulls/312/comments","review_comment_url":"https://api.github.com/repos/square/sqldelight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/square/sqldelight/issues/312/comments","statuses_url":"https://api.github.com/repos/square/sqldelight/statuses/ada4e048e3e98b5608d6deb3f561d1decd96bacb","head":{"label":"square:alec/mapper_interfaces","ref":"alec/mapper_interfaces","sha":"ada4e048e3e98b5608d6deb3f561d1decd96bacb","user":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":44677680,"name":"sqldelight","full_name":"square/sqldelight","owner":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/sqldelight","description":"Generates Java models from CREATE TABLE statements.","fork":false,"url":"https://api.github.com/repos/square/sqldelight","forks_url":"https://api.github.com/repos/square/sqldelight/forks","keys_url":"https://api.github.com/repos/square/sqldelight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/sqldelight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/sqldelight/teams","hooks_url":"https://api.github.com/repos/square/sqldelight/hooks","issue_events_url":"https://api.github.com/repos/square/sqldelight/issues/events{/number}","events_url":"https://api.github.com/repos/square/sqldelight/events","assignees_url":"https://api.github.com/repos/square/sqldelight/assignees{/user}","branches_url":"https://api.github.com/repos/square/sqldelight/branches{/branch}","tags_url":"https://api.github.com/repos/square/sqldelight/tags","blobs_url":"https://api.github.com/repos/square/sqldelight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/sqldelight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/sqldelight/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/sqldelight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/sqldelight/statuses/{sha}","languages_url":"https://api.github.com/repos/square/sqldelight/languages","stargazers_url":"https://api.github.com/repos/square/sqldelight/stargazers","contributors_url":"https://api.github.com/repos/square/sqldelight/contributors","subscribers_url":"https://api.github.com/repos/square/sqldelight/subscribers","subscription_url":"https://api.github.com/repos/square/sqldelight/subscription","commits_url":"https://api.github.com/repos/square/sqldelight/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/sqldelight/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/sqldelight/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/sqldelight/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/sqldelight/contents/{+path}","compare_url":"https://api.github.com/repos/square/sqldelight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/sqldelight/merges","archive_url":"https://api.github.com/repos/square/sqldelight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/sqldelight/downloads","issues_url":"https://api.github.com/repos/square/sqldelight/issues{/number}","pulls_url":"https://api.github.com/repos/square/sqldelight/pulls{/number}","milestones_url":"https://api.github.com/repos/square/sqldelight/milestones{/number}","notifications_url":"https://api.github.com/repos/square/sqldelight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/sqldelight/labels{/name}","releases_url":"https://api.github.com/repos/square/sqldelight/releases{/id}","deployments_url":"https://api.github.com/repos/square/sqldelight/deployments","created_at":"2015-10-21T13:21:18Z","updated_at":"2016-06-04T19:21:17Z","pushed_at":"2016-06-05T16:55:33Z","git_url":"git://github.com/square/sqldelight.git","ssh_url":"git@github.com:square/sqldelight.git","clone_url":"https://github.com/square/sqldelight.git","svn_url":"https://github.com/square/sqldelight","homepage":"","size":35067,"stargazers_count":692,"watchers_count":692,"language":"Kotlin","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":43,"mirror_url":null,"open_issues_count":30,"forks":43,"open_issues":30,"watchers":692,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"88beb5200ee62c2d27b6df05864059f2b1bac3bd","user":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":44677680,"name":"sqldelight","full_name":"square/sqldelight","owner":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/sqldelight","description":"Generates Java models from CREATE TABLE statements.","fork":false,"url":"https://api.github.com/repos/square/sqldelight","forks_url":"https://api.github.com/repos/square/sqldelight/forks","keys_url":"https://api.github.com/repos/square/sqldelight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/sqldelight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/sqldelight/teams","hooks_url":"https://api.github.com/repos/square/sqldelight/hooks","issue_events_url":"https://api.github.com/repos/square/sqldelight/issues/events{/number}","events_url":"https://api.github.com/repos/square/sqldelight/events","assignees_url":"https://api.github.com/repos/square/sqldelight/assignees{/user}","branches_url":"https://api.github.com/repos/square/sqldelight/branches{/branch}","tags_url":"https://api.github.com/repos/square/sqldelight/tags","blobs_url":"https://api.github.com/repos/square/sqldelight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/sqldelight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/sqldelight/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/sqldelight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/sqldelight/statuses/{sha}","languages_url":"https://api.github.com/repos/square/sqldelight/languages","stargazers_url":"https://api.github.com/repos/square/sqldelight/stargazers","contributors_url":"https://api.github.com/repos/square/sqldelight/contributors","subscribers_url":"https://api.github.com/repos/square/sqldelight/subscribers","subscription_url":"https://api.github.com/repos/square/sqldelight/subscription","commits_url":"https://api.github.com/repos/square/sqldelight/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/sqldelight/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/sqldelight/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/sqldelight/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/sqldelight/contents/{+path}","compare_url":"https://api.github.com/repos/square/sqldelight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/sqldelight/merges","archive_url":"https://api.github.com/repos/square/sqldelight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/sqldelight/downloads","issues_url":"https://api.github.com/repos/square/sqldelight/issues{/number}","pulls_url":"https://api.github.com/repos/square/sqldelight/pulls{/number}","milestones_url":"https://api.github.com/repos/square/sqldelight/milestones{/number}","notifications_url":"https://api.github.com/repos/square/sqldelight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/sqldelight/labels{/name}","releases_url":"https://api.github.com/repos/square/sqldelight/releases{/id}","deployments_url":"https://api.github.com/repos/square/sqldelight/deployments","created_at":"2015-10-21T13:21:18Z","updated_at":"2016-06-04T19:21:17Z","pushed_at":"2016-06-05T16:55:33Z","git_url":"git://github.com/square/sqldelight.git","ssh_url":"git@github.com:square/sqldelight.git","clone_url":"https://github.com/square/sqldelight.git","svn_url":"https://github.com/square/sqldelight","homepage":"","size":35067,"stargazers_count":692,"watchers_count":692,"language":"Kotlin","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":43,"mirror_url":null,"open_issues_count":30,"forks":43,"open_issues":30,"watchers":692,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/sqldelight/pulls/312"},"html":{"href":"https://github.com/square/sqldelight/pull/312"},"issue":{"href":"https://api.github.com/repos/square/sqldelight/issues/312"},"comments":{"href":"https://api.github.com/repos/square/sqldelight/issues/312/comments"},"review_comments":{"href":"https://api.github.com/repos/square/sqldelight/pulls/312/comments"},"review_comment":{"href":"https://api.github.com/repos/square/sqldelight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/square/sqldelight/pulls/312/commits"},"statuses":{"href":"https://api.github.com/repos/square/sqldelight/statuses/ada4e048e3e98b5608d6deb3f561d1decd96bacb"}}}}
{"actor":{"display_login":"AlecStrong"}}