{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/cli/pulls/comments/83758720","pull_request_review_id":4580903,"id":83758720,"diff_hunk":"@@ -165,6 +167,29 @@ private void CleanExistingPackageReferences(ProjectRootElement outputMSBuildProj\n             }\n         }\n \n+        private void AutoInjectImplicitProjectJsonAssemblyReferences(NuGetFramework framework, List<ProjectLibraryDependency> packageDependencies)\n+        {\n+            if (framework?.IsDesktop() ?? false)\n+            {\n+                InjectAssemblyReferenceIfNotPresent(\"System\", packageDependencies);\n+                if (framework.Version >= new Version(4, 0))","path":"src/Microsoft.DotNet.ProjectJsonMigration/Rules/MigratePackageDependenciesAndToolsRule.cs","position":35,"original_position":35,"commit_id":"1ef0103b8c241ffb390e1b3b213bb94a8f38fc55","original_commit_id":"1ef0103b8c241ffb390e1b3b213bb94a8f38fc55","user":{"login":"jgoshi","id":19478941,"avatar_url":"https://avatars.githubusercontent.com/u/19478941?v=3","gravatar_id":"","url":"https://api.github.com/users/jgoshi","html_url":"https://github.com/jgoshi","followers_url":"https://api.github.com/users/jgoshi/followers","following_url":"https://api.github.com/users/jgoshi/following{/other_user}","gists_url":"https://api.github.com/users/jgoshi/gists{/gist_id}","starred_url":"https://api.github.com/users/jgoshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgoshi/subscriptions","organizations_url":"https://api.github.com/users/jgoshi/orgs","repos_url":"https://api.github.com/users/jgoshi/repos","events_url":"https://api.github.com/users/jgoshi/events{/privacy}","received_events_url":"https://api.github.com/users/jgoshi/received_events","type":"User","site_admin":false},"body":"@livarcocc I don't think it needs to be. It won't change (will always be there as a prereq for including Microsoft.CSharp). Unless for stylistic reasons you want it? Then where should I define this constant?","created_at":"2016-10-17T23:51:05Z","updated_at":"2016-10-17T23:51:05Z","html_url":"https://github.com/dotnet/cli/pull/4398#discussion_r83758720","pull_request_url":"https://api.github.com/repos/dotnet/cli/pulls/4398","_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments/83758720"},"html":{"href":"https://github.com/dotnet/cli/pull/4398#discussion_r83758720"},"pull_request":{"href":"https://api.github.com/repos/dotnet/cli/pulls/4398"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/cli/pulls/4398","id":89253784,"html_url":"https://github.com/dotnet/cli/pull/4398","diff_url":"https://github.com/dotnet/cli/pull/4398.diff","patch_url":"https://github.com/dotnet/cli/pull/4398.patch","issue_url":"https://api.github.com/repos/dotnet/cli/issues/4398","number":4398,"state":"open","locked":false,"title":"https://github.com/dotnet/cli/issues/4351","user":{"login":"jgoshi","id":19478941,"avatar_url":"https://avatars.githubusercontent.com/u/19478941?v=3","gravatar_id":"","url":"https://api.github.com/users/jgoshi","html_url":"https://github.com/jgoshi","followers_url":"https://api.github.com/users/jgoshi/followers","following_url":"https://api.github.com/users/jgoshi/following{/other_user}","gists_url":"https://api.github.com/users/jgoshi/gists{/gist_id}","starred_url":"https://api.github.com/users/jgoshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgoshi/subscriptions","organizations_url":"https://api.github.com/users/jgoshi/orgs","repos_url":"https://api.github.com/users/jgoshi/repos","events_url":"https://api.github.com/users/jgoshi/events{/privacy}","received_events_url":"https://api.github.com/users/jgoshi/received_events","type":"User","site_admin":false},"body":"Auto add referenced assemblies for desktop migration. Adds the same ones\r\nthat the build for project.json does.","created_at":"2016-10-13T18:12:31Z","updated_at":"2016-10-17T23:51:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"924b75e3bbb655fff306b66f62d18f5d81cf410b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/cli/pulls/4398/commits","review_comments_url":"https://api.github.com/repos/dotnet/cli/pulls/4398/comments","review_comment_url":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/cli/issues/4398/comments","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/1ef0103b8c241ffb390e1b3b213bb94a8f38fc55","head":{"label":"dotnet:dev/jgoshi/issue4351","ref":"dev/jgoshi/issue4351","sha":"1ef0103b8c241ffb390e1b3b213bb94a8f38fc55","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":43568107,"name":"cli","full_name":"dotnet/cli","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":false,"url":"https://api.github.com/repos/dotnet/cli","forks_url":"https://api.github.com/repos/dotnet/cli/forks","keys_url":"https://api.github.com/repos/dotnet/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/cli/teams","hooks_url":"https://api.github.com/repos/dotnet/cli/hooks","issue_events_url":"https://api.github.com/repos/dotnet/cli/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/cli/events","assignees_url":"https://api.github.com/repos/dotnet/cli/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/cli/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/cli/tags","blobs_url":"https://api.github.com/repos/dotnet/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/cli/languages","stargazers_url":"https://api.github.com/repos/dotnet/cli/stargazers","contributors_url":"https://api.github.com/repos/dotnet/cli/contributors","subscribers_url":"https://api.github.com/repos/dotnet/cli/subscribers","subscription_url":"https://api.github.com/repos/dotnet/cli/subscription","commits_url":"https://api.github.com/repos/dotnet/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/cli/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/cli/merges","archive_url":"https://api.github.com/repos/dotnet/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/cli/downloads","issues_url":"https://api.github.com/repos/dotnet/cli/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/cli/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/cli/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/cli/deployments","created_at":"2015-10-02T18:03:15Z","updated_at":"2016-10-17T23:24:13Z","pushed_at":"2016-10-17T23:50:24Z","git_url":"git://github.com/dotnet/cli.git","ssh_url":"git@github.com:dotnet/cli.git","clone_url":"https://github.com/dotnet/cli.git","svn_url":"https://github.com/dotnet/cli","homepage":"https://docs.microsoft.com/dotnet/ ","size":121436,"stargazers_count":1486,"watchers_count":1486,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":382,"mirror_url":null,"open_issues_count":773,"forks":382,"open_issues":773,"watchers":1486,"default_branch":"rel/1.0.0"}},"base":{"label":"dotnet:rel/1.0.0","ref":"rel/1.0.0","sha":"a97d44eded9b3c16927deee864e703bbd019b9e0","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":43568107,"name":"cli","full_name":"dotnet/cli","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":false,"url":"https://api.github.com/repos/dotnet/cli","forks_url":"https://api.github.com/repos/dotnet/cli/forks","keys_url":"https://api.github.com/repos/dotnet/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/cli/teams","hooks_url":"https://api.github.com/repos/dotnet/cli/hooks","issue_events_url":"https://api.github.com/repos/dotnet/cli/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/cli/events","assignees_url":"https://api.github.com/repos/dotnet/cli/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/cli/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/cli/tags","blobs_url":"https://api.github.com/repos/dotnet/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/cli/languages","stargazers_url":"https://api.github.com/repos/dotnet/cli/stargazers","contributors_url":"https://api.github.com/repos/dotnet/cli/contributors","subscribers_url":"https://api.github.com/repos/dotnet/cli/subscribers","subscription_url":"https://api.github.com/repos/dotnet/cli/subscription","commits_url":"https://api.github.com/repos/dotnet/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/cli/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/cli/merges","archive_url":"https://api.github.com/repos/dotnet/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/cli/downloads","issues_url":"https://api.github.com/repos/dotnet/cli/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/cli/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/cli/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/cli/deployments","created_at":"2015-10-02T18:03:15Z","updated_at":"2016-10-17T23:24:13Z","pushed_at":"2016-10-17T23:50:24Z","git_url":"git://github.com/dotnet/cli.git","ssh_url":"git@github.com:dotnet/cli.git","clone_url":"https://github.com/dotnet/cli.git","svn_url":"https://github.com/dotnet/cli","homepage":"https://docs.microsoft.com/dotnet/ ","size":121436,"stargazers_count":1486,"watchers_count":1486,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":382,"mirror_url":null,"open_issues_count":773,"forks":382,"open_issues":773,"watchers":1486,"default_branch":"rel/1.0.0"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/4398"},"html":{"href":"https://github.com/dotnet/cli/pull/4398"},"issue":{"href":"https://api.github.com/repos/dotnet/cli/issues/4398"},"comments":{"href":"https://api.github.com/repos/dotnet/cli/issues/4398/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/cli/pulls/4398/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/cli/pulls/4398/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/cli/statuses/1ef0103b8c241ffb390e1b3b213bb94a8f38fc55"}}}}
{"actor":{"display_login":"jgoshi"}}