{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments/71530858","id":71530858,"diff_hunk":"@@ -0,0 +1,98 @@\n+<ng-form name=\"persistentVolumeClaimForm\">\n+  <fieldset ng-disabled=\"routingDisabled\">\n+\n+    <!-- Name -->\n+    <div ng-show=\"showNameInput\" class=\"form-group\">\n+      <label for=\"claim-name\" class=\"required\">Name</label>\n+      <!-- regex, maxlength from k8s.io/kubernetes/pkg/util/validation/validation.go -->\n+      <input\n+        id=\"claim-name\"\n+        class=\"form-control\"\n+        type=\"text\"\n+        name=\"name\"\n+        ng-model=\"claim.name\"\n+        ng-required=\"showNameInput\"\n+        ng-pattern=\"/^[a-z0-9]([-a-z0-9]*[a-z0-9])?$/\"\n+        ng-maxlength=\"63\"\n+        ng-minlength=\"2\"\n+        placeholder=\"my-claim-name\"\n+        select-on-focus\n+        autocorrect=\"off\"\n+        autocapitalize=\"off\"\n+        spellcheck=\"false\"\n+        aria-describedby=\"claim-name-help\">\n+      <div>\n+        <span id=\"claim-name-help\" class=\"help-block\">A unique name for the storage claim within the project.</span>\n+      </div>\n+      <div class=\"has-error\" ng-show=\"persistentVolumeClaimForm.name.$error.pattern && persistentVolumeClaimForm.name.$touched && !routingDisabled\">\n+        <span class=\"help-block\">\n+          Claim names may only contain lower-case letters, numbers, and dashes.\n+          They may not start or end with a dash.\n+        </span>\n+      </div>\n+    </div>\n+\n+    <div class=\"form-group\" >\n+      <label class=\"required\">Access Mode</label><br/>\n+      <!--modes = { 'RWX':'Read/Write Many', 'RWO':'Read/Write Once', 'ROX':'Read-Only Many' };-->\n+      <div class=\"radio\" ng-app ng-init=\"claim.accessModes=ReadWriteOnce\">\n+        <!--<div ng-init=\"claim.accessModes=ReadWriteOnce\" />-->\n+\n+\n+        <label class=\"radio-inline\">\n+          <fieldset>\n+            <input type=\"radio\" name=\"accessModes\" ng-model=\"claim.accessModes\" value=\"ReadWriteOnce\" aria-describedby=\"service-help\" ng-checked=\"true\" >\n+            Single User (RWO)\n+          </fieldset>\n+        </label>\n+\n+        <label class=\"radio-inline\">\n+          <fieldset><input type=\"radio\" id=\"accessModes\" name=\"accessModes\" ng-model=\"claim.accessModes\" value=\"ReadWriteMany\" aria-describedby=\"service-help\" >\n+            Shared Access (RWX)\n+          </fieldset>\n+        </label>\n+\n+        <label class=\"radio-inline\">\n+          <fieldset>\n+            <input type=\"radio\" name=\"accessModes\" ng-model=\"claim.accessModes\" value=\"ReadOnlyMany\" aria-describedby=\"service-help\">\n+            Read Only (ROX)\n+          </fieldset>\n+        </label>\n+\n+      </div>\n+      <div>\n+        <span id=\"service-help\" class=\"help-block\">Accessibility permissions to the mounted volume.</span>\n+      </div>\n+    </div>\n+\n+    <!-- capacity -->\n+    <div class=\"form-group\">\n+      <label for=\"capacity\" class=\"required\">Capacity</label>\n+      <!-- regex, maxlength from k8s.io/kubernetes/pkg/util/validation/validation.go -->\n+      <input\n+        id=\"capacity\"\n+        class=\"form-control\"\n+        type=\"text\"\n+        name=\"capacity\"\n+        required\n+        ng-model=\"claim.capacity\"\n+        ng-pattern=\"/^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*)$/\"\n+        ng-maxlength=\"253\"","path":"app/views/directives/osc-persistent-volume-claim.html","position":80,"original_position":80,"commit_id":"7e28b3e1330c953d9f77af4dc61380252fe95427","original_commit_id":"7e28b3e1330c953d9f77af4dc61380252fe95427","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"I don't think capacity has a maxlength.","created_at":"2016-07-20T14:07:28Z","updated_at":"2016-07-20T14:07:28Z","html_url":"https://github.com/openshift/origin-web-console/pull/189#discussion_r71530858","pull_request_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/189","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments/71530858"},"html":{"href":"https://github.com/openshift/origin-web-console/pull/189#discussion_r71530858"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/189"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/189","id":77893975,"html_url":"https://github.com/openshift/origin-web-console/pull/189","diff_url":"https://github.com/openshift/origin-web-console/pull/189.diff","patch_url":"https://github.com/openshift/origin-web-console/pull/189.patch","issue_url":"https://api.github.com/repos/openshift/origin-web-console/issues/189","number":189,"state":"open","locked":false,"title":"Create persistent volume claim form on console","user":{"login":"zherman0","id":18728857,"avatar_url":"https://avatars.githubusercontent.com/u/18728857?v=3","gravatar_id":"","url":"https://api.github.com/users/zherman0","html_url":"https://github.com/zherman0","followers_url":"https://api.github.com/users/zherman0/followers","following_url":"https://api.github.com/users/zherman0/following{/other_user}","gists_url":"https://api.github.com/users/zherman0/gists{/gist_id}","starred_url":"https://api.github.com/users/zherman0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zherman0/subscriptions","organizations_url":"https://api.github.com/users/zherman0/orgs","repos_url":"https://api.github.com/users/zherman0/repos","events_url":"https://api.github.com/users/zherman0/events{/privacy}","received_events_url":"https://api.github.com/users/zherman0/received_events","type":"User","site_admin":false},"body":"This adds a new request button to the storage page that allows users to request a very simple storage claim.  The new form currently only allows for 3 basic inputs, which are sufficient to create a new PVC.\r\n@jwforres @erinboyd ","created_at":"2016-07-18T23:03:13Z","updated_at":"2016-07-20T14:07:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4359a7cb8f4903612747a660021fdd9cfc98244b","assignee":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"assignees":[{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/189/commits","review_comments_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/189/comments","review_comment_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/issues/189/comments","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/7e28b3e1330c953d9f77af4dc61380252fe95427","head":{"label":"zherman0:claimCreateForm","ref":"claimCreateForm","sha":"7e28b3e1330c953d9f77af4dc61380252fe95427","user":{"login":"zherman0","id":18728857,"avatar_url":"https://avatars.githubusercontent.com/u/18728857?v=3","gravatar_id":"","url":"https://api.github.com/users/zherman0","html_url":"https://github.com/zherman0","followers_url":"https://api.github.com/users/zherman0/followers","following_url":"https://api.github.com/users/zherman0/following{/other_user}","gists_url":"https://api.github.com/users/zherman0/gists{/gist_id}","starred_url":"https://api.github.com/users/zherman0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zherman0/subscriptions","organizations_url":"https://api.github.com/users/zherman0/orgs","repos_url":"https://api.github.com/users/zherman0/repos","events_url":"https://api.github.com/users/zherman0/events{/privacy}","received_events_url":"https://api.github.com/users/zherman0/received_events","type":"User","site_admin":false},"repo":{"id":60214955,"name":"origin-web-console","full_name":"zherman0/origin-web-console","owner":{"login":"zherman0","id":18728857,"avatar_url":"https://avatars.githubusercontent.com/u/18728857?v=3","gravatar_id":"","url":"https://api.github.com/users/zherman0","html_url":"https://github.com/zherman0","followers_url":"https://api.github.com/users/zherman0/followers","following_url":"https://api.github.com/users/zherman0/following{/other_user}","gists_url":"https://api.github.com/users/zherman0/gists{/gist_id}","starred_url":"https://api.github.com/users/zherman0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zherman0/subscriptions","organizations_url":"https://api.github.com/users/zherman0/orgs","repos_url":"https://api.github.com/users/zherman0/repos","events_url":"https://api.github.com/users/zherman0/events{/privacy}","received_events_url":"https://api.github.com/users/zherman0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zherman0/origin-web-console","description":"Zac's changes for the Origin Web Console","fork":true,"url":"https://api.github.com/repos/zherman0/origin-web-console","forks_url":"https://api.github.com/repos/zherman0/origin-web-console/forks","keys_url":"https://api.github.com/repos/zherman0/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zherman0/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zherman0/origin-web-console/teams","hooks_url":"https://api.github.com/repos/zherman0/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/zherman0/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/zherman0/origin-web-console/events","assignees_url":"https://api.github.com/repos/zherman0/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/zherman0/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/zherman0/origin-web-console/tags","blobs_url":"https://api.github.com/repos/zherman0/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zherman0/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zherman0/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/zherman0/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zherman0/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/zherman0/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/zherman0/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/zherman0/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/zherman0/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/zherman0/origin-web-console/subscription","commits_url":"https://api.github.com/repos/zherman0/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/zherman0/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/zherman0/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/zherman0/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/zherman0/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/zherman0/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zherman0/origin-web-console/merges","archive_url":"https://api.github.com/repos/zherman0/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zherman0/origin-web-console/downloads","issues_url":"https://api.github.com/repos/zherman0/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/zherman0/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/zherman0/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/zherman0/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zherman0/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/zherman0/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/zherman0/origin-web-console/deployments","created_at":"2016-06-01T22:27:42Z","updated_at":"2016-06-14T20:30:30Z","pushed_at":"2016-07-19T23:05:45Z","git_url":"git://github.com/zherman0/origin-web-console.git","ssh_url":"git@github.com:zherman0/origin-web-console.git","clone_url":"https://github.com/zherman0/origin-web-console.git","svn_url":"https://github.com/zherman0/origin-web-console","homepage":"","size":7641,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"bad6254aed5b173baf6e01f1a86ef4f47b4e15d4","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":58488264,"name":"origin-web-console","full_name":"openshift/origin-web-console","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin-web-console","description":"","fork":false,"url":"https://api.github.com/repos/openshift/origin-web-console","forks_url":"https://api.github.com/repos/openshift/origin-web-console/forks","keys_url":"https://api.github.com/repos/openshift/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin-web-console/teams","hooks_url":"https://api.github.com/repos/openshift/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin-web-console/events","assignees_url":"https://api.github.com/repos/openshift/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin-web-console/tags","blobs_url":"https://api.github.com/repos/openshift/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/openshift/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin-web-console/subscription","commits_url":"https://api.github.com/repos/openshift/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin-web-console/merges","archive_url":"https://api.github.com/repos/openshift/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin-web-console/downloads","issues_url":"https://api.github.com/repos/openshift/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin-web-console/deployments","created_at":"2016-05-10T19:31:50Z","updated_at":"2016-06-20T16:37:07Z","pushed_at":"2016-07-20T14:04:30Z","git_url":"git://github.com/openshift/origin-web-console.git","ssh_url":"git@github.com:openshift/origin-web-console.git","clone_url":"https://github.com/openshift/origin-web-console.git","svn_url":"https://github.com/openshift/origin-web-console","homepage":null,"size":8573,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":37,"forks":28,"open_issues":37,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/189"},"html":{"href":"https://github.com/openshift/origin-web-console/pull/189"},"issue":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/189"},"comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin-web-console/statuses/7e28b3e1330c953d9f77af4dc61380252fe95427"}}}}
{"actor":{"display_login":"spadgett"}}