{"action":"created","comment":{"url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/comments/87939791","pull_request_review_id":8529585,"id":87939791,"diff_hunk":"@@ -16,15 +18,18 @@ try {\n try {\n \trequire.resolve('sockjs');\n } catch (e) {\n-\tlet command = 'npm install --production';\n-\tconsole.log('Installing dependencies: `' + command + '`...');\n-\trequire('child_process').spawnSync('sh', ['-c', command], {stdio: 'inherit'});\n+\tconsole.log('Installing dependencies...');\n+\tspawnSync('npm', ['install', '--production'], {stdio: 'inherit', shell: true});\n }\n \n-// start the server\n+// Start the server\n \n let port;\n if (process.argv[2]) {\n \tport = parseInt(process.argv[2]); // eslint-disable-line radix\n }\n-require('./app').listen(port);\n+\n+// Bootstrap manually to ensure any dependencies that were just installed can\n+// be found when running on Windows\n+\n+require('module')._load('./app', module, false).listen(port);","path":"pokemon-showdown","position":32,"original_position":32,"commit_id":"28e8f706a59e9ed918d2b77661009163a62592e8","original_commit_id":"28e8f706a59e9ed918d2b77661009163a62592e8","user":{"login":"Morfent","id":6477435,"avatar_url":"https://avatars.githubusercontent.com/u/6477435?v=3","gravatar_id":"","url":"https://api.github.com/users/Morfent","html_url":"https://github.com/Morfent","followers_url":"https://api.github.com/users/Morfent/followers","following_url":"https://api.github.com/users/Morfent/following{/other_user}","gists_url":"https://api.github.com/users/Morfent/gists{/gist_id}","starred_url":"https://api.github.com/users/Morfent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morfent/subscriptions","organizations_url":"https://api.github.com/users/Morfent/orgs","repos_url":"https://api.github.com/users/Morfent/repos","events_url":"https://api.github.com/users/Morfent/events{/privacy}","received_events_url":"https://api.github.com/users/Morfent/received_events","type":"User","site_admin":false},"body":"Documented? Not exactly. Stable? It should be, since require calls little more than this internally unless the module loaded is the main one, and app.js isn't in this case. For whatever reason, loading app.js normally just doesn't work normally on Windows in this one scenario.","created_at":"2016-11-15T02:58:13Z","updated_at":"2016-11-15T02:58:14Z","html_url":"https://github.com/Zarel/Pokemon-Showdown/pull/2889#discussion_r87939791","pull_request_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/2889","_links":{"self":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/comments/87939791"},"html":{"href":"https://github.com/Zarel/Pokemon-Showdown/pull/2889#discussion_r87939791"},"pull_request":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/2889"}}},"pull_request":{"url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/2889","id":93429549,"html_url":"https://github.com/Zarel/Pokemon-Showdown/pull/2889","diff_url":"https://github.com/Zarel/Pokemon-Showdown/pull/2889.diff","patch_url":"https://github.com/Zarel/Pokemon-Showdown/pull/2889.patch","issue_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/2889","number":2889,"state":"open","locked":false,"title":"Make the launch script compatible with Windows","user":{"login":"Morfent","id":6477435,"avatar_url":"https://avatars.githubusercontent.com/u/6477435?v=3","gravatar_id":"","url":"https://api.github.com/users/Morfent","html_url":"https://github.com/Morfent","followers_url":"https://api.github.com/users/Morfent/followers","following_url":"https://api.github.com/users/Morfent/following{/other_user}","gists_url":"https://api.github.com/users/Morfent/gists{/gist_id}","starred_url":"https://api.github.com/users/Morfent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morfent/subscriptions","organizations_url":"https://api.github.com/users/Morfent/orgs","repos_url":"https://api.github.com/users/Morfent/repos","events_url":"https://api.github.com/users/Morfent/events{/privacy}","received_events_url":"https://api.github.com/users/Morfent/received_events","type":"User","site_admin":false},"body":"Will be needed for dealing with Go's dependencies in the sockets.js\r\nrewrite.","created_at":"2016-11-12T05:58:16Z","updated_at":"2016-11-15T02:58:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b409851bfbaa737d7ba46327e76fa39aeb138647","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/2889/commits","review_comments_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/2889/comments","review_comment_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/2889/comments","statuses_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/statuses/28e8f706a59e9ed918d2b77661009163a62592e8","head":{"label":"Morfent:make","ref":"make","sha":"28e8f706a59e9ed918d2b77661009163a62592e8","user":{"login":"Morfent","id":6477435,"avatar_url":"https://avatars.githubusercontent.com/u/6477435?v=3","gravatar_id":"","url":"https://api.github.com/users/Morfent","html_url":"https://github.com/Morfent","followers_url":"https://api.github.com/users/Morfent/followers","following_url":"https://api.github.com/users/Morfent/following{/other_user}","gists_url":"https://api.github.com/users/Morfent/gists{/gist_id}","starred_url":"https://api.github.com/users/Morfent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morfent/subscriptions","organizations_url":"https://api.github.com/users/Morfent/orgs","repos_url":"https://api.github.com/users/Morfent/repos","events_url":"https://api.github.com/users/Morfent/events{/privacy}","received_events_url":"https://api.github.com/users/Morfent/received_events","type":"User","site_admin":false},"repo":{"id":43088955,"name":"Pokemon-Showdown","full_name":"Morfent/Pokemon-Showdown","owner":{"login":"Morfent","id":6477435,"avatar_url":"https://avatars.githubusercontent.com/u/6477435?v=3","gravatar_id":"","url":"https://api.github.com/users/Morfent","html_url":"https://github.com/Morfent","followers_url":"https://api.github.com/users/Morfent/followers","following_url":"https://api.github.com/users/Morfent/following{/other_user}","gists_url":"https://api.github.com/users/Morfent/gists{/gist_id}","starred_url":"https://api.github.com/users/Morfent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morfent/subscriptions","organizations_url":"https://api.github.com/users/Morfent/orgs","repos_url":"https://api.github.com/users/Morfent/repos","events_url":"https://api.github.com/users/Morfent/events{/privacy}","received_events_url":"https://api.github.com/users/Morfent/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Morfent/Pokemon-Showdown","description":"Pokémon battle simulator.","fork":true,"url":"https://api.github.com/repos/Morfent/Pokemon-Showdown","forks_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/forks","keys_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/teams","hooks_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/hooks","issue_events_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/issues/events{/number}","events_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/events","assignees_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/assignees{/user}","branches_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/branches{/branch}","tags_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/tags","blobs_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/statuses/{sha}","languages_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/languages","stargazers_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/stargazers","contributors_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/contributors","subscribers_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/subscribers","subscription_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/subscription","commits_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/issues/comments{/number}","contents_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/contents/{+path}","compare_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/merges","archive_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/downloads","issues_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/issues{/number}","pulls_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/pulls{/number}","milestones_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/milestones{/number}","notifications_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/labels{/name}","releases_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/releases{/id}","deployments_url":"https://api.github.com/repos/Morfent/Pokemon-Showdown/deployments","created_at":"2015-09-24T19:42:35Z","updated_at":"2016-05-25T17:23:44Z","pushed_at":"2016-11-13T02:38:18Z","git_url":"git://github.com/Morfent/Pokemon-Showdown.git","ssh_url":"git@github.com:Morfent/Pokemon-Showdown.git","clone_url":"https://github.com/Morfent/Pokemon-Showdown.git","svn_url":"https://github.com/Morfent/Pokemon-Showdown","homepage":"http://pokemonshowdown.com","size":42767,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Zarel:master","ref":"master","sha":"d42108259e9457045c073c3e8805bbe98afec361","user":{"login":"Zarel","id":551184,"avatar_url":"https://avatars.githubusercontent.com/u/551184?v=3","gravatar_id":"","url":"https://api.github.com/users/Zarel","html_url":"https://github.com/Zarel","followers_url":"https://api.github.com/users/Zarel/followers","following_url":"https://api.github.com/users/Zarel/following{/other_user}","gists_url":"https://api.github.com/users/Zarel/gists{/gist_id}","starred_url":"https://api.github.com/users/Zarel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zarel/subscriptions","organizations_url":"https://api.github.com/users/Zarel/orgs","repos_url":"https://api.github.com/users/Zarel/repos","events_url":"https://api.github.com/users/Zarel/events{/privacy}","received_events_url":"https://api.github.com/users/Zarel/received_events","type":"User","site_admin":false},"repo":{"id":3038446,"name":"Pokemon-Showdown","full_name":"Zarel/Pokemon-Showdown","owner":{"login":"Zarel","id":551184,"avatar_url":"https://avatars.githubusercontent.com/u/551184?v=3","gravatar_id":"","url":"https://api.github.com/users/Zarel","html_url":"https://github.com/Zarel","followers_url":"https://api.github.com/users/Zarel/followers","following_url":"https://api.github.com/users/Zarel/following{/other_user}","gists_url":"https://api.github.com/users/Zarel/gists{/gist_id}","starred_url":"https://api.github.com/users/Zarel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zarel/subscriptions","organizations_url":"https://api.github.com/users/Zarel/orgs","repos_url":"https://api.github.com/users/Zarel/repos","events_url":"https://api.github.com/users/Zarel/events{/privacy}","received_events_url":"https://api.github.com/users/Zarel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zarel/Pokemon-Showdown","description":"Pokémon battle simulator.","fork":false,"url":"https://api.github.com/repos/Zarel/Pokemon-Showdown","forks_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/forks","keys_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/teams","hooks_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/hooks","issue_events_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/events{/number}","events_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/events","assignees_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/assignees{/user}","branches_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/branches{/branch}","tags_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/tags","blobs_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/statuses/{sha}","languages_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/languages","stargazers_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/stargazers","contributors_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/contributors","subscribers_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/subscribers","subscription_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/subscription","commits_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/contents/{+path}","compare_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/merges","archive_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/downloads","issues_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues{/number}","pulls_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls{/number}","milestones_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/milestones{/number}","notifications_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/labels{/name}","releases_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/releases{/id}","deployments_url":"https://api.github.com/repos/Zarel/Pokemon-Showdown/deployments","created_at":"2011-12-23T04:52:33Z","updated_at":"2016-11-12T15:50:00Z","pushed_at":"2016-11-15T02:47:42Z","git_url":"git://github.com/Zarel/Pokemon-Showdown.git","ssh_url":"git@github.com:Zarel/Pokemon-Showdown.git","clone_url":"https://github.com/Zarel/Pokemon-Showdown.git","svn_url":"https://github.com/Zarel/Pokemon-Showdown","homepage":"http://pokemonshowdown.com","size":82573,"stargazers_count":1006,"watchers_count":1006,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1057,"mirror_url":null,"open_issues_count":42,"forks":1057,"open_issues":42,"watchers":1006,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/2889"},"html":{"href":"https://github.com/Zarel/Pokemon-Showdown/pull/2889"},"issue":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/2889"},"comments":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/issues/2889/comments"},"review_comments":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/2889/comments"},"review_comment":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/pulls/2889/commits"},"statuses":{"href":"https://api.github.com/repos/Zarel/Pokemon-Showdown/statuses/28e8f706a59e9ed918d2b77661009163a62592e8"}}}}
{"actor":{"display_login":"Morfent"}}