{"action":"closed","number":8,"pull_request":{"url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/pulls/8","id":62998751,"html_url":"https://github.com/washo4evr/Socket.io-v1.x-Library/pull/8","diff_url":"https://github.com/washo4evr/Socket.io-v1.x-Library/pull/8.diff","patch_url":"https://github.com/washo4evr/Socket.io-v1.x-Library/pull/8.patch","issue_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/issues/8","number":8,"state":"closed","locked":false,"title":"Adding include directives to allow for a user to never touch the library","user":{"login":"funkyguy4000","id":2363497,"avatar_url":"https://avatars.githubusercontent.com/u/2363497?v=3","gravatar_id":"","url":"https://api.github.com/users/funkyguy4000","html_url":"https://github.com/funkyguy4000","followers_url":"https://api.github.com/users/funkyguy4000/followers","following_url":"https://api.github.com/users/funkyguy4000/following{/other_user}","gists_url":"https://api.github.com/users/funkyguy4000/gists{/gist_id}","starred_url":"https://api.github.com/users/funkyguy4000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/funkyguy4000/subscriptions","organizations_url":"https://api.github.com/users/funkyguy4000/orgs","repos_url":"https://api.github.com/users/funkyguy4000/repos","events_url":"https://api.github.com/users/funkyguy4000/events{/privacy}","received_events_url":"https://api.github.com/users/funkyguy4000/received_events","type":"User","site_admin":false},"body":"It is much more user-friendly for the end developer to have a simple #define interface to this file to set it up in their application rather than having them edit the main header file.  \r\n\r\nUsing this interface is very simple, if they are using the ESP8266 their setup would look like:\r\n```\r\n    #define ESP8266\r\n    #include \"SocketIOClient.h\"\r\n```\r\n\r\nor for the W5100\r\n```\r\n    #define W5100\r\n    #include \"SocketIOClient.h\"\r\n```\r\n\r\nand lastly the ENC28J60\r\n```\r\n    #define ENC28J60\r\n    #include \"SocketIOClient.h\"\r\n```\r\n\r\nShould the user not define any of these, the compilation will fail with an error reminding them that they need to define this in their file which is much more straight forward than having to hunt the libraries header file down and editing that.  It also address a degree of confidence that they know what they're doing. \r\n\r\nNow for you, the library developer, should you support more interfaces in the future, all you need to do is add : \r\n```\r\n    #ifdef <new interface>\r\n    #include <new interface.h>\r\n    #endif \r\n```\r\n\r\nand then you also need to append the new interfaces definition onto the `#ifndef` above the `#error` definitions like so:\r\n```\r\n    #ifndef W5100 || ENC28J60 || ESP8266 || <your new interface>\r\n    #error etc.....\r\n    #endif\r\n```\r\n\r\nHope this helps! \r\n","created_at":"2016-03-16T00:34:20Z","updated_at":"2016-04-25T00:26:24Z","closed_at":"2016-04-25T00:26:24Z","merged_at":null,"merge_commit_sha":"63639c103283557f2a0142940dd06416d073c023","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/pulls/8/commits","review_comments_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/pulls/8/comments","review_comment_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/issues/8/comments","statuses_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/statuses/73c597c71e08031d5b8e54f9b11d0c49494df539","head":{"label":"funkyguy4000:master","ref":"master","sha":"73c597c71e08031d5b8e54f9b11d0c49494df539","user":{"login":"funkyguy4000","id":2363497,"avatar_url":"https://avatars.githubusercontent.com/u/2363497?v=3","gravatar_id":"","url":"https://api.github.com/users/funkyguy4000","html_url":"https://github.com/funkyguy4000","followers_url":"https://api.github.com/users/funkyguy4000/followers","following_url":"https://api.github.com/users/funkyguy4000/following{/other_user}","gists_url":"https://api.github.com/users/funkyguy4000/gists{/gist_id}","starred_url":"https://api.github.com/users/funkyguy4000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/funkyguy4000/subscriptions","organizations_url":"https://api.github.com/users/funkyguy4000/orgs","repos_url":"https://api.github.com/users/funkyguy4000/repos","events_url":"https://api.github.com/users/funkyguy4000/events{/privacy}","received_events_url":"https://api.github.com/users/funkyguy4000/received_events","type":"User","site_admin":false},"repo":{"id":53987782,"name":"Socket.io-v1.x-Library","full_name":"funkyguy4000/Socket.io-v1.x-Library","owner":{"login":"funkyguy4000","id":2363497,"avatar_url":"https://avatars.githubusercontent.com/u/2363497?v=3","gravatar_id":"","url":"https://api.github.com/users/funkyguy4000","html_url":"https://github.com/funkyguy4000","followers_url":"https://api.github.com/users/funkyguy4000/followers","following_url":"https://api.github.com/users/funkyguy4000/following{/other_user}","gists_url":"https://api.github.com/users/funkyguy4000/gists{/gist_id}","starred_url":"https://api.github.com/users/funkyguy4000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/funkyguy4000/subscriptions","organizations_url":"https://api.github.com/users/funkyguy4000/orgs","repos_url":"https://api.github.com/users/funkyguy4000/repos","events_url":"https://api.github.com/users/funkyguy4000/events{/privacy}","received_events_url":"https://api.github.com/users/funkyguy4000/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/funkyguy4000/Socket.io-v1.x-Library","description":"Socket.io Library for Arduino","fork":true,"url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library","forks_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/forks","keys_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/teams","hooks_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/hooks","issue_events_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/issues/events{/number}","events_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/events","assignees_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/assignees{/user}","branches_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/branches{/branch}","tags_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/tags","blobs_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/git/refs{/sha}","trees_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/statuses/{sha}","languages_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/languages","stargazers_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/stargazers","contributors_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/contributors","subscribers_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/subscribers","subscription_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/subscription","commits_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/commits{/sha}","git_commits_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/git/commits{/sha}","comments_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/comments{/number}","issue_comment_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/issues/comments{/number}","contents_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/contents/{+path}","compare_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/merges","archive_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/downloads","issues_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/issues{/number}","pulls_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/pulls{/number}","milestones_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/milestones{/number}","notifications_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/labels{/name}","releases_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/releases{/id}","deployments_url":"https://api.github.com/repos/funkyguy4000/Socket.io-v1.x-Library/deployments","created_at":"2016-03-16T00:15:35Z","updated_at":"2016-03-16T00:15:35Z","pushed_at":"2016-03-16T15:00:16Z","git_url":"git://github.com/funkyguy4000/Socket.io-v1.x-Library.git","ssh_url":"git@github.com:funkyguy4000/Socket.io-v1.x-Library.git","clone_url":"https://github.com/funkyguy4000/Socket.io-v1.x-Library.git","svn_url":"https://github.com/funkyguy4000/Socket.io-v1.x-Library","homepage":null,"size":24,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"washo4evr:master","ref":"master","sha":"72c15e7e3f643dab374ed3e1fe007718c3aff9e6","user":{"login":"washo4evr","id":10562229,"avatar_url":"https://avatars.githubusercontent.com/u/10562229?v=3","gravatar_id":"","url":"https://api.github.com/users/washo4evr","html_url":"https://github.com/washo4evr","followers_url":"https://api.github.com/users/washo4evr/followers","following_url":"https://api.github.com/users/washo4evr/following{/other_user}","gists_url":"https://api.github.com/users/washo4evr/gists{/gist_id}","starred_url":"https://api.github.com/users/washo4evr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/washo4evr/subscriptions","organizations_url":"https://api.github.com/users/washo4evr/orgs","repos_url":"https://api.github.com/users/washo4evr/repos","events_url":"https://api.github.com/users/washo4evr/events{/privacy}","received_events_url":"https://api.github.com/users/washo4evr/received_events","type":"User","site_admin":false},"repo":{"id":43565404,"name":"Socket.io-v1.x-Library","full_name":"washo4evr/Socket.io-v1.x-Library","owner":{"login":"washo4evr","id":10562229,"avatar_url":"https://avatars.githubusercontent.com/u/10562229?v=3","gravatar_id":"","url":"https://api.github.com/users/washo4evr","html_url":"https://github.com/washo4evr","followers_url":"https://api.github.com/users/washo4evr/followers","following_url":"https://api.github.com/users/washo4evr/following{/other_user}","gists_url":"https://api.github.com/users/washo4evr/gists{/gist_id}","starred_url":"https://api.github.com/users/washo4evr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/washo4evr/subscriptions","organizations_url":"https://api.github.com/users/washo4evr/orgs","repos_url":"https://api.github.com/users/washo4evr/repos","events_url":"https://api.github.com/users/washo4evr/events{/privacy}","received_events_url":"https://api.github.com/users/washo4evr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/washo4evr/Socket.io-v1.x-Library","description":"Socket.io Library for Arduino","fork":false,"url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library","forks_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/forks","keys_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/teams","hooks_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/hooks","issue_events_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/issues/events{/number}","events_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/events","assignees_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/assignees{/user}","branches_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/branches{/branch}","tags_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/tags","blobs_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/git/refs{/sha}","trees_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/statuses/{sha}","languages_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/languages","stargazers_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/stargazers","contributors_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/contributors","subscribers_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/subscribers","subscription_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/subscription","commits_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/commits{/sha}","git_commits_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/git/commits{/sha}","comments_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/comments{/number}","issue_comment_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/issues/comments{/number}","contents_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/contents/{+path}","compare_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/merges","archive_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/downloads","issues_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/issues{/number}","pulls_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/pulls{/number}","milestones_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/milestones{/number}","notifications_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/labels{/name}","releases_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/releases{/id}","deployments_url":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/deployments","created_at":"2015-10-02T17:03:05Z","updated_at":"2016-04-04T07:38:07Z","pushed_at":"2016-04-06T03:43:35Z","git_url":"git://github.com/washo4evr/Socket.io-v1.x-Library.git","ssh_url":"git@github.com:washo4evr/Socket.io-v1.x-Library.git","clone_url":"https://github.com/washo4evr/Socket.io-v1.x-Library.git","svn_url":"https://github.com/washo4evr/Socket.io-v1.x-Library","homepage":null,"size":28,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":6,"forks":5,"open_issues":6,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/pulls/8"},"html":{"href":"https://github.com/washo4evr/Socket.io-v1.x-Library/pull/8"},"issue":{"href":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/issues/8"},"comments":{"href":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/washo4evr/Socket.io-v1.x-Library/statuses/73c597c71e08031d5b8e54f9b11d0c49494df539"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"commits":4,"additions":33,"deletions":5,"changed_files":2}}