{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/15252","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/15252/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/15252/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/15252/events","html_url":"https://github.com/NixOS/nixpkgs/pull/15252","id":153343702,"number":15252,"title":"llvm_38: update hashes and fix on darwin","user":{"login":"acowley","id":124545,"avatar_url":"https://avatars.githubusercontent.com/u/124545?v=3","gravatar_id":"","url":"https://api.github.com/users/acowley","html_url":"https://github.com/acowley","followers_url":"https://api.github.com/users/acowley/followers","following_url":"https://api.github.com/users/acowley/following{/other_user}","gists_url":"https://api.github.com/users/acowley/gists{/gist_id}","starred_url":"https://api.github.com/users/acowley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acowley/subscriptions","organizations_url":"https://api.github.com/users/acowley/orgs","repos_url":"https://api.github.com/users/acowley/repos","events_url":"https://api.github.com/users/acowley/events{/privacy}","received_events_url":"https://api.github.com/users/acowley/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20darwin","name":"6.topic: darwin","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-05-05T22:49:17Z","updated_at":"2016-05-07T15:16:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/15252","html_url":"https://github.com/NixOS/nixpkgs/pull/15252","diff_url":"https://github.com/NixOS/nixpkgs/pull/15252.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/15252.patch"},"body":"###### Things done\r\n\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [x] OS X\r\n   - [ ] Linux\r\n\r\n\r\n---\r\n\r\n\r\nThe hashes for libc++ and libc++abi were wrong.\r\n\r\nThere was also an incompatibility with nixpkgs on darwin which is now\r\nweakly worked around: the \"os_trace\" macro changed definition in the OS\r\nX development SDK since version 10.9 as used by nixpkgs. LLVM 3.8 uses\r\nthe new version, which I am temporarily replacing with a printf on\r\ndarwin as it is only used in one minor location.\r\n\r\nCloses #14542 "},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/217643614","html_url":"https://github.com/NixOS/nixpkgs/pull/15252#issuecomment-217643614","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/15252","id":217643614,"user":{"login":"acowley","id":124545,"avatar_url":"https://avatars.githubusercontent.com/u/124545?v=3","gravatar_id":"","url":"https://api.github.com/users/acowley","html_url":"https://github.com/acowley","followers_url":"https://api.github.com/users/acowley/followers","following_url":"https://api.github.com/users/acowley/following{/other_user}","gists_url":"https://api.github.com/users/acowley/gists{/gist_id}","starred_url":"https://api.github.com/users/acowley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acowley/subscriptions","organizations_url":"https://api.github.com/users/acowley/orgs","repos_url":"https://api.github.com/users/acowley/repos","events_url":"https://api.github.com/users/acowley/events{/privacy}","received_events_url":"https://api.github.com/users/acowley/received_events","type":"User","site_admin":false},"created_at":"2016-05-07T15:16:36Z","updated_at":"2016-05-07T15:16:36Z","body":"I did it this way because it seems to only be a problem for 3.8. Would putting a self version check guarding that patch in the generic `llvm.nix` be better?"}}