{"action":"created","comment":{"url":"https://api.github.com/repos/serilog/serilog/pulls/comments/64192090","id":64192090,"diff_hunk":"@@ -29,6 +29,8 @@ namespace Serilog.Core\n     /// </summary>\n     public sealed class Logger : ILogger, ILogEventSink, IDisposable\n     {\n+        static readonly object[] NoPropertyValues = new object[0];","path":"src/Serilog/Core/Logger.cs","position":4,"original_position":4,"commit_id":"19e2a0732b0c4c3fa9bf307e3b7acfa16ce14469","original_commit_id":"19e2a0732b0c4c3fa9bf307e3b7acfa16ce14469","user":{"login":"nblumhardt","id":342712,"avatar_url":"https://avatars.githubusercontent.com/u/342712?v=3","gravatar_id":"","url":"https://api.github.com/users/nblumhardt","html_url":"https://github.com/nblumhardt","followers_url":"https://api.github.com/users/nblumhardt/followers","following_url":"https://api.github.com/users/nblumhardt/following{/other_user}","gists_url":"https://api.github.com/users/nblumhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/nblumhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nblumhardt/subscriptions","organizations_url":"https://api.github.com/users/nblumhardt/orgs","repos_url":"https://api.github.com/users/nblumhardt/repos","events_url":"https://api.github.com/users/nblumhardt/events{/privacy}","received_events_url":"https://api.github.com/users/nblumhardt/received_events","type":"User","site_admin":false},"body":"4.6+ :-) Thought about it but didn't seem worth the `#if` noise.","created_at":"2016-05-23T09:24:26Z","updated_at":"2016-05-23T09:24:26Z","html_url":"https://github.com/serilog/serilog/pull/752#discussion_r64192090","pull_request_url":"https://api.github.com/repos/serilog/serilog/pulls/752","_links":{"self":{"href":"https://api.github.com/repos/serilog/serilog/pulls/comments/64192090"},"html":{"href":"https://github.com/serilog/serilog/pull/752#discussion_r64192090"},"pull_request":{"href":"https://api.github.com/repos/serilog/serilog/pulls/752"}}},"pull_request":{"url":"https://api.github.com/repos/serilog/serilog/pulls/752","id":71002866,"html_url":"https://github.com/serilog/serilog/pull/752","diff_url":"https://github.com/serilog/serilog/pull/752.diff","patch_url":"https://github.com/serilog/serilog/pull/752.patch","issue_url":"https://api.github.com/repos/serilog/serilog/issues/752","number":752,"state":"open","locked":false,"title":"Add allocation-saving generic overloads to ILogger","user":{"login":"nblumhardt","id":342712,"avatar_url":"https://avatars.githubusercontent.com/u/342712?v=3","gravatar_id":"","url":"https://api.github.com/users/nblumhardt","html_url":"https://github.com/nblumhardt","followers_url":"https://api.github.com/users/nblumhardt/followers","following_url":"https://api.github.com/users/nblumhardt/following{/other_user}","gists_url":"https://api.github.com/users/nblumhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/nblumhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nblumhardt/subscriptions","organizations_url":"https://api.github.com/users/nblumhardt/orgs","repos_url":"https://api.github.com/users/nblumhardt/repos","events_url":"https://api.github.com/users/nblumhardt/events{/privacy}","received_events_url":"https://api.github.com/users/nblumhardt/received_events","type":"User","site_admin":false},"body":"#585 \r\n\r\n## Breaking change\r\n\r\nAdds many methods to ILogger.\r\n\r\n## Description\r\n\r\nRemoves one `params` array allocation per call, and potentially one boxing allocation per argument, for all `ILogger` methods of three or fewer parameters when logging for that level is off.\r\n\r\n```csharp\r\n            var logger = new LoggerConfiguration()\r\n                .WriteTo.Sink(new DelegatingSink(e => { }))\r\n                .CreateLogger();\r\n\r\n            var sw = System.Diagnostics.Stopwatch.StartNew();\r\n\r\n            for (var i = 0; i < 10000000; ++i)\r\n            {\r\n                logger.Debug(\"Iteration {I}\", i);\r\n            }\r\n\r\n            Console.WriteLine(sw.Elapsed);\r\n```\r\n\r\nBefore: 0.153 seconds; after: 0.016 seconds.\r\n\r\n\r\nNotes:\r\n\r\nRidiculously large and tedious change, needs another pair of eyes on it :-)","created_at":"2016-05-23T04:11:55Z","updated_at":"2016-05-23T09:24:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f067766e724b9e29d5e2c7c5401e9424477f9fdb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/serilog/serilog/pulls/752/commits","review_comments_url":"https://api.github.com/repos/serilog/serilog/pulls/752/comments","review_comment_url":"https://api.github.com/repos/serilog/serilog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serilog/serilog/issues/752/comments","statuses_url":"https://api.github.com/repos/serilog/serilog/statuses/19e2a0732b0c4c3fa9bf307e3b7acfa16ce14469","head":{"label":"nblumhardt:f-loggergenerics","ref":"f-loggergenerics","sha":"19e2a0732b0c4c3fa9bf307e3b7acfa16ce14469","user":{"login":"nblumhardt","id":342712,"avatar_url":"https://avatars.githubusercontent.com/u/342712?v=3","gravatar_id":"","url":"https://api.github.com/users/nblumhardt","html_url":"https://github.com/nblumhardt","followers_url":"https://api.github.com/users/nblumhardt/followers","following_url":"https://api.github.com/users/nblumhardt/following{/other_user}","gists_url":"https://api.github.com/users/nblumhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/nblumhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nblumhardt/subscriptions","organizations_url":"https://api.github.com/users/nblumhardt/orgs","repos_url":"https://api.github.com/users/nblumhardt/repos","events_url":"https://api.github.com/users/nblumhardt/events{/privacy}","received_events_url":"https://api.github.com/users/nblumhardt/received_events","type":"User","site_admin":false},"repo":{"id":47938475,"name":"serilog","full_name":"nblumhardt/serilog","owner":{"login":"nblumhardt","id":342712,"avatar_url":"https://avatars.githubusercontent.com/u/342712?v=3","gravatar_id":"","url":"https://api.github.com/users/nblumhardt","html_url":"https://github.com/nblumhardt","followers_url":"https://api.github.com/users/nblumhardt/followers","following_url":"https://api.github.com/users/nblumhardt/following{/other_user}","gists_url":"https://api.github.com/users/nblumhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/nblumhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nblumhardt/subscriptions","organizations_url":"https://api.github.com/users/nblumhardt/orgs","repos_url":"https://api.github.com/users/nblumhardt/repos","events_url":"https://api.github.com/users/nblumhardt/events{/privacy}","received_events_url":"https://api.github.com/users/nblumhardt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nblumhardt/serilog","description":"Simple .NET logging with fully-structured events","fork":true,"url":"https://api.github.com/repos/nblumhardt/serilog","forks_url":"https://api.github.com/repos/nblumhardt/serilog/forks","keys_url":"https://api.github.com/repos/nblumhardt/serilog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nblumhardt/serilog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nblumhardt/serilog/teams","hooks_url":"https://api.github.com/repos/nblumhardt/serilog/hooks","issue_events_url":"https://api.github.com/repos/nblumhardt/serilog/issues/events{/number}","events_url":"https://api.github.com/repos/nblumhardt/serilog/events","assignees_url":"https://api.github.com/repos/nblumhardt/serilog/assignees{/user}","branches_url":"https://api.github.com/repos/nblumhardt/serilog/branches{/branch}","tags_url":"https://api.github.com/repos/nblumhardt/serilog/tags","blobs_url":"https://api.github.com/repos/nblumhardt/serilog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nblumhardt/serilog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nblumhardt/serilog/git/refs{/sha}","trees_url":"https://api.github.com/repos/nblumhardt/serilog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nblumhardt/serilog/statuses/{sha}","languages_url":"https://api.github.com/repos/nblumhardt/serilog/languages","stargazers_url":"https://api.github.com/repos/nblumhardt/serilog/stargazers","contributors_url":"https://api.github.com/repos/nblumhardt/serilog/contributors","subscribers_url":"https://api.github.com/repos/nblumhardt/serilog/subscribers","subscription_url":"https://api.github.com/repos/nblumhardt/serilog/subscription","commits_url":"https://api.github.com/repos/nblumhardt/serilog/commits{/sha}","git_commits_url":"https://api.github.com/repos/nblumhardt/serilog/git/commits{/sha}","comments_url":"https://api.github.com/repos/nblumhardt/serilog/comments{/number}","issue_comment_url":"https://api.github.com/repos/nblumhardt/serilog/issues/comments{/number}","contents_url":"https://api.github.com/repos/nblumhardt/serilog/contents/{+path}","compare_url":"https://api.github.com/repos/nblumhardt/serilog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nblumhardt/serilog/merges","archive_url":"https://api.github.com/repos/nblumhardt/serilog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nblumhardt/serilog/downloads","issues_url":"https://api.github.com/repos/nblumhardt/serilog/issues{/number}","pulls_url":"https://api.github.com/repos/nblumhardt/serilog/pulls{/number}","milestones_url":"https://api.github.com/repos/nblumhardt/serilog/milestones{/number}","notifications_url":"https://api.github.com/repos/nblumhardt/serilog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nblumhardt/serilog/labels{/name}","releases_url":"https://api.github.com/repos/nblumhardt/serilog/releases{/id}","deployments_url":"https://api.github.com/repos/nblumhardt/serilog/deployments","created_at":"2015-12-13T22:10:07Z","updated_at":"2016-02-09T03:16:06Z","pushed_at":"2016-05-23T04:09:16Z","git_url":"git://github.com/nblumhardt/serilog.git","ssh_url":"git@github.com:nblumhardt/serilog.git","clone_url":"https://github.com/nblumhardt/serilog.git","svn_url":"https://github.com/nblumhardt/serilog","homepage":"http://serilog.net","size":74817,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"serilog:dev","ref":"dev","sha":"eacdf648f2803ec4accea4f0abb6808587db5b3a","user":{"login":"serilog","id":5691010,"avatar_url":"https://avatars.githubusercontent.com/u/5691010?v=3","gravatar_id":"","url":"https://api.github.com/users/serilog","html_url":"https://github.com/serilog","followers_url":"https://api.github.com/users/serilog/followers","following_url":"https://api.github.com/users/serilog/following{/other_user}","gists_url":"https://api.github.com/users/serilog/gists{/gist_id}","starred_url":"https://api.github.com/users/serilog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serilog/subscriptions","organizations_url":"https://api.github.com/users/serilog/orgs","repos_url":"https://api.github.com/users/serilog/repos","events_url":"https://api.github.com/users/serilog/events{/privacy}","received_events_url":"https://api.github.com/users/serilog/received_events","type":"Organization","site_admin":false},"repo":{"id":8198511,"name":"serilog","full_name":"serilog/serilog","owner":{"login":"serilog","id":5691010,"avatar_url":"https://avatars.githubusercontent.com/u/5691010?v=3","gravatar_id":"","url":"https://api.github.com/users/serilog","html_url":"https://github.com/serilog","followers_url":"https://api.github.com/users/serilog/followers","following_url":"https://api.github.com/users/serilog/following{/other_user}","gists_url":"https://api.github.com/users/serilog/gists{/gist_id}","starred_url":"https://api.github.com/users/serilog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serilog/subscriptions","organizations_url":"https://api.github.com/users/serilog/orgs","repos_url":"https://api.github.com/users/serilog/repos","events_url":"https://api.github.com/users/serilog/events{/privacy}","received_events_url":"https://api.github.com/users/serilog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serilog/serilog","description":"Simple .NET logging with fully-structured events","fork":false,"url":"https://api.github.com/repos/serilog/serilog","forks_url":"https://api.github.com/repos/serilog/serilog/forks","keys_url":"https://api.github.com/repos/serilog/serilog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serilog/serilog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serilog/serilog/teams","hooks_url":"https://api.github.com/repos/serilog/serilog/hooks","issue_events_url":"https://api.github.com/repos/serilog/serilog/issues/events{/number}","events_url":"https://api.github.com/repos/serilog/serilog/events","assignees_url":"https://api.github.com/repos/serilog/serilog/assignees{/user}","branches_url":"https://api.github.com/repos/serilog/serilog/branches{/branch}","tags_url":"https://api.github.com/repos/serilog/serilog/tags","blobs_url":"https://api.github.com/repos/serilog/serilog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serilog/serilog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serilog/serilog/git/refs{/sha}","trees_url":"https://api.github.com/repos/serilog/serilog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serilog/serilog/statuses/{sha}","languages_url":"https://api.github.com/repos/serilog/serilog/languages","stargazers_url":"https://api.github.com/repos/serilog/serilog/stargazers","contributors_url":"https://api.github.com/repos/serilog/serilog/contributors","subscribers_url":"https://api.github.com/repos/serilog/serilog/subscribers","subscription_url":"https://api.github.com/repos/serilog/serilog/subscription","commits_url":"https://api.github.com/repos/serilog/serilog/commits{/sha}","git_commits_url":"https://api.github.com/repos/serilog/serilog/git/commits{/sha}","comments_url":"https://api.github.com/repos/serilog/serilog/comments{/number}","issue_comment_url":"https://api.github.com/repos/serilog/serilog/issues/comments{/number}","contents_url":"https://api.github.com/repos/serilog/serilog/contents/{+path}","compare_url":"https://api.github.com/repos/serilog/serilog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serilog/serilog/merges","archive_url":"https://api.github.com/repos/serilog/serilog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serilog/serilog/downloads","issues_url":"https://api.github.com/repos/serilog/serilog/issues{/number}","pulls_url":"https://api.github.com/repos/serilog/serilog/pulls{/number}","milestones_url":"https://api.github.com/repos/serilog/serilog/milestones{/number}","notifications_url":"https://api.github.com/repos/serilog/serilog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serilog/serilog/labels{/name}","releases_url":"https://api.github.com/repos/serilog/serilog/releases{/id}","deployments_url":"https://api.github.com/repos/serilog/serilog/deployments","created_at":"2013-02-14T11:44:03Z","updated_at":"2016-05-23T07:11:28Z","pushed_at":"2016-05-23T04:11:55Z","git_url":"git://github.com/serilog/serilog.git","ssh_url":"git@github.com:serilog/serilog.git","clone_url":"https://github.com/serilog/serilog.git","svn_url":"https://github.com/serilog/serilog","homepage":"http://serilog.net","size":92774,"stargazers_count":811,"watchers_count":811,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":258,"mirror_url":null,"open_issues_count":22,"forks":258,"open_issues":22,"watchers":811,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/serilog/serilog/pulls/752"},"html":{"href":"https://github.com/serilog/serilog/pull/752"},"issue":{"href":"https://api.github.com/repos/serilog/serilog/issues/752"},"comments":{"href":"https://api.github.com/repos/serilog/serilog/issues/752/comments"},"review_comments":{"href":"https://api.github.com/repos/serilog/serilog/pulls/752/comments"},"review_comment":{"href":"https://api.github.com/repos/serilog/serilog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serilog/serilog/pulls/752/commits"},"statuses":{"href":"https://api.github.com/repos/serilog/serilog/statuses/19e2a0732b0c4c3fa9bf307e3b7acfa16ce14469"}}}}
{"actor":{"display_login":"nblumhardt"}}