{"action":"created","comment":{"url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/comments/65885395","id":65885395,"diff_hunk":"@@ -101,14 +101,14 @@ export class SearchInput extends Component {\n       value,\n       mouseInMenu: false,\n       keySelectedIndex: -1,\n-      items: [],\n+      dropped: false,\n     };\n   }\n \n   async search(value) {\n     const {getHints} = this.props;\n-    const items = await getHints(value);\n-    this.setState({items});\n+    this.setState({dropped: true});","path":"gulp/src/common/ui/SearchInput.js","position":null,"original_position":41,"commit_id":"2b695b0032d48aa9b8f1d59b31a796880676fce9","original_commit_id":"853766f3b40ece83c29f85436e0324d15abfc6ad","user":{"login":"aspidites","id":93686,"avatar_url":"https://avatars.githubusercontent.com/u/93686?v=3","gravatar_id":"","url":"https://api.github.com/users/aspidites","html_url":"https://github.com/aspidites","followers_url":"https://api.github.com/users/aspidites/followers","following_url":"https://api.github.com/users/aspidites/following{/other_user}","gists_url":"https://api.github.com/users/aspidites/gists{/gist_id}","starred_url":"https://api.github.com/users/aspidites/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspidites/subscriptions","organizations_url":"https://api.github.com/users/aspidites/orgs","repos_url":"https://api.github.com/users/aspidites/repos","events_url":"https://api.github.com/users/aspidites/events{/privacy}","received_events_url":"https://api.github.com/users/aspidites/received_events","type":"User","site_admin":false},"body":"I read the FAQ entry you linked to. What I read from your comment is that managing component-level state isn't possible. What I'm reading from that FAQ is that it isn't exactly expected that you be able to. I'll probably fork this and play with it, but I'd suspect that you either needn't have component-level state, or that app state is the composition of all child states (as it happens in Elm (from which Redux is derived) and Pux (which is arguably what Redux wanted to be).","created_at":"2016-06-06T13:02:42Z","updated_at":"2016-06-06T13:02:42Z","html_url":"https://github.com/DirectEmployers/MyJobs/pull/2346#discussion_r65885395","pull_request_url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/2346","_links":{"self":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/comments/65885395"},"html":{"href":"https://github.com/DirectEmployers/MyJobs/pull/2346#discussion_r65885395"},"pull_request":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/2346"}}},"pull_request":{"url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/2346","id":71622077,"html_url":"https://github.com/DirectEmployers/MyJobs/pull/2346","diff_url":"https://github.com/DirectEmployers/MyJobs/pull/2346.diff","patch_url":"https://github.com/DirectEmployers/MyJobs/pull/2346.patch","issue_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/2346","number":2346,"state":"open","locked":false,"title":"Deploy redux in preparation for foreign tags","user":{"login":"darrint","id":108186,"avatar_url":"https://avatars.githubusercontent.com/u/108186?v=3","gravatar_id":"","url":"https://api.github.com/users/darrint","html_url":"https://github.com/darrint","followers_url":"https://api.github.com/users/darrint/followers","following_url":"https://api.github.com/users/darrint/following{/other_user}","gists_url":"https://api.github.com/users/darrint/gists{/gist_id}","starred_url":"https://api.github.com/users/darrint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrint/subscriptions","organizations_url":"https://api.github.com/users/darrint/orgs","repos_url":"https://api.github.com/users/darrint/repos","events_url":"https://api.github.com/users/darrint/events{/privacy}","received_events_url":"https://api.github.com/users/darrint/received_events","type":"User","site_admin":false},"body":"## Status\r\n\r\n* Filtering works. Including hairy behavior with field hints being dependent on each other.\r\n* Running reports and history don't work. At this point run and the associated report list stuff should be trivial to implement. History is still tricky so I'm going to try to touch it as little as possible for this ticket.\r\n* Export and Preview haven't been touched.\r\n* I still need to update the JS style guide as there's a lot of conventions we follow that we haven't documented. \r\n\r\n## Review Suggestions\r\n\r\n* Understand how redux apps look. If you haven't done a basic tutorial yet, now is a good time.\r\n* Understand how redux apps handle async actions. What I have here is very close to: http://redux.js.org/docs/advanced/AsyncActions.html\r\n* Look at `report-state-reducer.js`, its actions, and its unit tests. This is the basic filtering logic.\r\n* Look at `compound-actions.js` this is where all the hairy stuff is handled. A lot of hacks stuffed into arbitrary spots in the UI code are now here and unit tested.\r\n  * The unit test for `doFilterUpdatesWithDependencies` is a lot hairier than I'd like.\r\n* Look at `WizardFilterCityState.jsx` as an example of the kinds of simplifications I did as a result of this work.\r\n  * `getHints` no longer returns a value. It just causes props to refresh.\r\n  * Currently selected values are just passed in as props.\r\n* Look at `WizardFilterMultiSelect.jsx` where the DANGER comment is gone. That is being handled (and unit tested) in `doFilterUpdatesWithDependencies`. The potential looping problem is gone.\r\n* `SetUpReport.jsx` won't get much shorter until I attack the history modifying parts of the app and eliminate `ReportFinder`. I don't want to do that in this ticket.\r\n\r\n## Guidance Requested\r\n\r\n* Looking for critique.\r\n","created_at":"2016-05-26T20:49:21Z","updated_at":"2016-06-06T13:02:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbe61cb628b279326bcf506e6acb1454282c0b63","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/2346/commits","review_comments_url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/2346/comments","review_comment_url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/2346/comments","statuses_url":"https://api.github.com/repos/DirectEmployers/MyJobs/statuses/2b695b0032d48aa9b8f1d59b31a796880676fce9","head":{"label":"DirectEmployers:pd-2307--foreign-tags","ref":"pd-2307--foreign-tags","sha":"2b695b0032d48aa9b8f1d59b31a796880676fce9","user":{"login":"DirectEmployers","id":381171,"avatar_url":"https://avatars.githubusercontent.com/u/381171?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectEmployers","html_url":"https://github.com/DirectEmployers","followers_url":"https://api.github.com/users/DirectEmployers/followers","following_url":"https://api.github.com/users/DirectEmployers/following{/other_user}","gists_url":"https://api.github.com/users/DirectEmployers/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectEmployers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectEmployers/subscriptions","organizations_url":"https://api.github.com/users/DirectEmployers/orgs","repos_url":"https://api.github.com/users/DirectEmployers/repos","events_url":"https://api.github.com/users/DirectEmployers/events{/privacy}","received_events_url":"https://api.github.com/users/DirectEmployers/received_events","type":"Organization","site_admin":false},"repo":{"id":2867982,"name":"MyJobs","full_name":"DirectEmployers/MyJobs","owner":{"login":"DirectEmployers","id":381171,"avatar_url":"https://avatars.githubusercontent.com/u/381171?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectEmployers","html_url":"https://github.com/DirectEmployers","followers_url":"https://api.github.com/users/DirectEmployers/followers","following_url":"https://api.github.com/users/DirectEmployers/following{/other_user}","gists_url":"https://api.github.com/users/DirectEmployers/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectEmployers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectEmployers/subscriptions","organizations_url":"https://api.github.com/users/DirectEmployers/orgs","repos_url":"https://api.github.com/users/DirectEmployers/repos","events_url":"https://api.github.com/users/DirectEmployers/events{/privacy}","received_events_url":"https://api.github.com/users/DirectEmployers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DirectEmployers/MyJobs","description":"Multi-user website designed to assist job seekers in their search for employment","fork":false,"url":"https://api.github.com/repos/DirectEmployers/MyJobs","forks_url":"https://api.github.com/repos/DirectEmployers/MyJobs/forks","keys_url":"https://api.github.com/repos/DirectEmployers/MyJobs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DirectEmployers/MyJobs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DirectEmployers/MyJobs/teams","hooks_url":"https://api.github.com/repos/DirectEmployers/MyJobs/hooks","issue_events_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/events{/number}","events_url":"https://api.github.com/repos/DirectEmployers/MyJobs/events","assignees_url":"https://api.github.com/repos/DirectEmployers/MyJobs/assignees{/user}","branches_url":"https://api.github.com/repos/DirectEmployers/MyJobs/branches{/branch}","tags_url":"https://api.github.com/repos/DirectEmployers/MyJobs/tags","blobs_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/refs{/sha}","trees_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DirectEmployers/MyJobs/statuses/{sha}","languages_url":"https://api.github.com/repos/DirectEmployers/MyJobs/languages","stargazers_url":"https://api.github.com/repos/DirectEmployers/MyJobs/stargazers","contributors_url":"https://api.github.com/repos/DirectEmployers/MyJobs/contributors","subscribers_url":"https://api.github.com/repos/DirectEmployers/MyJobs/subscribers","subscription_url":"https://api.github.com/repos/DirectEmployers/MyJobs/subscription","commits_url":"https://api.github.com/repos/DirectEmployers/MyJobs/commits{/sha}","git_commits_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/commits{/sha}","comments_url":"https://api.github.com/repos/DirectEmployers/MyJobs/comments{/number}","issue_comment_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/comments{/number}","contents_url":"https://api.github.com/repos/DirectEmployers/MyJobs/contents/{+path}","compare_url":"https://api.github.com/repos/DirectEmployers/MyJobs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DirectEmployers/MyJobs/merges","archive_url":"https://api.github.com/repos/DirectEmployers/MyJobs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DirectEmployers/MyJobs/downloads","issues_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues{/number}","pulls_url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls{/number}","milestones_url":"https://api.github.com/repos/DirectEmployers/MyJobs/milestones{/number}","notifications_url":"https://api.github.com/repos/DirectEmployers/MyJobs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DirectEmployers/MyJobs/labels{/name}","releases_url":"https://api.github.com/repos/DirectEmployers/MyJobs/releases{/id}","deployments_url":"https://api.github.com/repos/DirectEmployers/MyJobs/deployments","created_at":"2011-11-28T15:22:36Z","updated_at":"2016-04-05T20:47:26Z","pushed_at":"2016-06-06T12:07:00Z","git_url":"git://github.com/DirectEmployers/MyJobs.git","ssh_url":"git@github.com:DirectEmployers/MyJobs.git","clone_url":"https://github.com/DirectEmployers/MyJobs.git","svn_url":"https://github.com/DirectEmployers/MyJobs","homepage":"http://my.jobs","size":34760,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":5,"forks":11,"open_issues":5,"watchers":8,"default_branch":"quality-control"}},"base":{"label":"DirectEmployers:quality-control","ref":"quality-control","sha":"f2bad74123f841f4ef50e6cf53123ba0a78209f3","user":{"login":"DirectEmployers","id":381171,"avatar_url":"https://avatars.githubusercontent.com/u/381171?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectEmployers","html_url":"https://github.com/DirectEmployers","followers_url":"https://api.github.com/users/DirectEmployers/followers","following_url":"https://api.github.com/users/DirectEmployers/following{/other_user}","gists_url":"https://api.github.com/users/DirectEmployers/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectEmployers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectEmployers/subscriptions","organizations_url":"https://api.github.com/users/DirectEmployers/orgs","repos_url":"https://api.github.com/users/DirectEmployers/repos","events_url":"https://api.github.com/users/DirectEmployers/events{/privacy}","received_events_url":"https://api.github.com/users/DirectEmployers/received_events","type":"Organization","site_admin":false},"repo":{"id":2867982,"name":"MyJobs","full_name":"DirectEmployers/MyJobs","owner":{"login":"DirectEmployers","id":381171,"avatar_url":"https://avatars.githubusercontent.com/u/381171?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectEmployers","html_url":"https://github.com/DirectEmployers","followers_url":"https://api.github.com/users/DirectEmployers/followers","following_url":"https://api.github.com/users/DirectEmployers/following{/other_user}","gists_url":"https://api.github.com/users/DirectEmployers/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectEmployers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectEmployers/subscriptions","organizations_url":"https://api.github.com/users/DirectEmployers/orgs","repos_url":"https://api.github.com/users/DirectEmployers/repos","events_url":"https://api.github.com/users/DirectEmployers/events{/privacy}","received_events_url":"https://api.github.com/users/DirectEmployers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DirectEmployers/MyJobs","description":"Multi-user website designed to assist job seekers in their search for employment","fork":false,"url":"https://api.github.com/repos/DirectEmployers/MyJobs","forks_url":"https://api.github.com/repos/DirectEmployers/MyJobs/forks","keys_url":"https://api.github.com/repos/DirectEmployers/MyJobs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DirectEmployers/MyJobs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DirectEmployers/MyJobs/teams","hooks_url":"https://api.github.com/repos/DirectEmployers/MyJobs/hooks","issue_events_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/events{/number}","events_url":"https://api.github.com/repos/DirectEmployers/MyJobs/events","assignees_url":"https://api.github.com/repos/DirectEmployers/MyJobs/assignees{/user}","branches_url":"https://api.github.com/repos/DirectEmployers/MyJobs/branches{/branch}","tags_url":"https://api.github.com/repos/DirectEmployers/MyJobs/tags","blobs_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/refs{/sha}","trees_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DirectEmployers/MyJobs/statuses/{sha}","languages_url":"https://api.github.com/repos/DirectEmployers/MyJobs/languages","stargazers_url":"https://api.github.com/repos/DirectEmployers/MyJobs/stargazers","contributors_url":"https://api.github.com/repos/DirectEmployers/MyJobs/contributors","subscribers_url":"https://api.github.com/repos/DirectEmployers/MyJobs/subscribers","subscription_url":"https://api.github.com/repos/DirectEmployers/MyJobs/subscription","commits_url":"https://api.github.com/repos/DirectEmployers/MyJobs/commits{/sha}","git_commits_url":"https://api.github.com/repos/DirectEmployers/MyJobs/git/commits{/sha}","comments_url":"https://api.github.com/repos/DirectEmployers/MyJobs/comments{/number}","issue_comment_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/comments{/number}","contents_url":"https://api.github.com/repos/DirectEmployers/MyJobs/contents/{+path}","compare_url":"https://api.github.com/repos/DirectEmployers/MyJobs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DirectEmployers/MyJobs/merges","archive_url":"https://api.github.com/repos/DirectEmployers/MyJobs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DirectEmployers/MyJobs/downloads","issues_url":"https://api.github.com/repos/DirectEmployers/MyJobs/issues{/number}","pulls_url":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls{/number}","milestones_url":"https://api.github.com/repos/DirectEmployers/MyJobs/milestones{/number}","notifications_url":"https://api.github.com/repos/DirectEmployers/MyJobs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DirectEmployers/MyJobs/labels{/name}","releases_url":"https://api.github.com/repos/DirectEmployers/MyJobs/releases{/id}","deployments_url":"https://api.github.com/repos/DirectEmployers/MyJobs/deployments","created_at":"2011-11-28T15:22:36Z","updated_at":"2016-04-05T20:47:26Z","pushed_at":"2016-06-06T12:07:00Z","git_url":"git://github.com/DirectEmployers/MyJobs.git","ssh_url":"git@github.com:DirectEmployers/MyJobs.git","clone_url":"https://github.com/DirectEmployers/MyJobs.git","svn_url":"https://github.com/DirectEmployers/MyJobs","homepage":"http://my.jobs","size":34760,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":5,"forks":11,"open_issues":5,"watchers":8,"default_branch":"quality-control"}},"_links":{"self":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/2346"},"html":{"href":"https://github.com/DirectEmployers/MyJobs/pull/2346"},"issue":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/2346"},"comments":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/issues/2346/comments"},"review_comments":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/2346/comments"},"review_comment":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/pulls/2346/commits"},"statuses":{"href":"https://api.github.com/repos/DirectEmployers/MyJobs/statuses/2b695b0032d48aa9b8f1d59b31a796880676fce9"}}}}
{"actor":{"display_login":"aspidites"}}