{"action":"closed","issue":{"url":"https://api.github.com/repos/thelia/thelia/issues/2226","repository_url":"https://api.github.com/repos/thelia/thelia","labels_url":"https://api.github.com/repos/thelia/thelia/issues/2226/labels{/name}","comments_url":"https://api.github.com/repos/thelia/thelia/issues/2226/comments","events_url":"https://api.github.com/repos/thelia/thelia/issues/2226/events","html_url":"https://github.com/thelia/thelia/issues/2226","id":168039335,"number":2226,"title":"Bad parsing of web version in db update script","user":{"login":"sb-relaxt-at","id":7354968,"avatar_url":"https://avatars.githubusercontent.com/u/7354968?v=3","gravatar_id":"","url":"https://api.github.com/users/sb-relaxt-at","html_url":"https://github.com/sb-relaxt-at","followers_url":"https://api.github.com/users/sb-relaxt-at/followers","following_url":"https://api.github.com/users/sb-relaxt-at/following{/other_user}","gists_url":"https://api.github.com/users/sb-relaxt-at/gists{/gist_id}","starred_url":"https://api.github.com/users/sb-relaxt-at/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sb-relaxt-at/subscriptions","organizations_url":"https://api.github.com/users/sb-relaxt-at/orgs","repos_url":"https://api.github.com/users/sb-relaxt-at/repos","events_url":"https://api.github.com/users/sb-relaxt-at/events{/privacy}","received_events_url":"https://api.github.com/users/sb-relaxt-at/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-28T08:21:37Z","updated_at":"2016-09-14T08:51:29Z","closed_at":"2016-09-14T08:51:29Z","body":"When retrieving the latest version by querying http://thelia.net/version.php in [Update#getWebVersion](https://github.com/thelia/thelia/blob/master/core/lib/Thelia/Install/Update.php#L590), there is a trailing line break in the result. Therefore the update script believes, that the installed version is not the current stable release. There should be some sanitizing of the retrieved version information, at least the following is required in Update#getWebVersion: \r\n\r\n`$res = trim($res)`"}}
{"actor":{"display_login":"bibich"}}