{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/comments/70089350","id":70089350,"diff_hunk":"@@ -57,8 +58,18 @@\n  */\n public class GitHubPushTrigger extends Trigger<Job<?, ?>> implements GitHubTrigger {\n \n+    private Secret sharedSecret;\n+\n     @DataBoundConstructor\n-    public GitHubPushTrigger() {","path":"src/main/java/com/cloudbees/jenkins/GitHubPushTrigger.java","position":36,"original_position":36,"commit_id":"7d2857d158e20e7666643796c7f60c7e02844dd6","original_commit_id":"7d2857d158e20e7666643796c7f60c7e02844dd6","user":{"login":"KostyaSha","id":231611,"avatar_url":"https://avatars.githubusercontent.com/u/231611?v=3","gravatar_id":"","url":"https://api.github.com/users/KostyaSha","html_url":"https://github.com/KostyaSha","followers_url":"https://api.github.com/users/KostyaSha/followers","following_url":"https://api.github.com/users/KostyaSha/following{/other_user}","gists_url":"https://api.github.com/users/KostyaSha/gists{/gist_id}","starred_url":"https://api.github.com/users/KostyaSha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KostyaSha/subscriptions","organizations_url":"https://api.github.com/users/KostyaSha/orgs","repos_url":"https://api.github.com/users/KostyaSha/repos","events_url":"https://api.github.com/users/KostyaSha/events{/privacy}","received_events_url":"https://api.github.com/users/KostyaSha/received_events","type":"User","site_admin":false},"body":"breaks backward compatibility","created_at":"2016-07-08T15:10:07Z","updated_at":"2016-07-08T15:10:07Z","html_url":"https://github.com/jenkinsci/github-plugin/pull/129#discussion_r70089350","pull_request_url":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/129","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/comments/70089350"},"html":{"href":"https://github.com/jenkinsci/github-plugin/pull/129#discussion_r70089350"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/129"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/129","id":76764681,"html_url":"https://github.com/jenkinsci/github-plugin/pull/129","diff_url":"https://github.com/jenkinsci/github-plugin/pull/129.diff","patch_url":"https://github.com/jenkinsci/github-plugin/pull/129.patch","issue_url":"https://api.github.com/repos/jenkinsci/github-plugin/issues/129","number":129,"state":"open","locked":false,"title":"[JENKINS-33974] Payload verification using shared secrets","user":{"login":"martinmine","id":2211729,"avatar_url":"https://avatars.githubusercontent.com/u/2211729?v=3","gravatar_id":"","url":"https://api.github.com/users/martinmine","html_url":"https://github.com/martinmine","followers_url":"https://api.github.com/users/martinmine/followers","following_url":"https://api.github.com/users/martinmine/following{/other_user}","gists_url":"https://api.github.com/users/martinmine/gists{/gist_id}","starred_url":"https://api.github.com/users/martinmine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinmine/subscriptions","organizations_url":"https://api.github.com/users/martinmine/orgs","repos_url":"https://api.github.com/users/martinmine/repos","events_url":"https://api.github.com/users/martinmine/events{/privacy}","received_events_url":"https://api.github.com/users/martinmine/received_events","type":"User","site_admin":false},"body":"This pull requests adds the support for verification of payloads from GitHub using SHA1 HMAC digest of payloads. Users are able to configure project-specific secrets and global secrets being used across all projects. When hooks are automatically set up, they receive a generated secret. \r\nThis pull request solves issue [JENKINS-33974](https://issues.jenkins-ci.org/browse/JENKINS-33974?jql=project%20%3D%20JENKINS%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20Reopened)%20AND%20component%20%3D%20%27github-plugin%27).\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/jenkinsci/github-plugin/129)\n<!-- Reviewable:end -->\n","created_at":"2016-07-08T14:50:32Z","updated_at":"2016-07-08T15:10:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8630b2758064abbe5482c7257443f379b048831d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/129/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/129/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/github-plugin/issues/129/comments","statuses_url":"https://api.github.com/repos/jenkinsci/github-plugin/statuses/7d2857d158e20e7666643796c7f60c7e02844dd6","head":{"label":"martinmine:master","ref":"master","sha":"7d2857d158e20e7666643796c7f60c7e02844dd6","user":{"login":"martinmine","id":2211729,"avatar_url":"https://avatars.githubusercontent.com/u/2211729?v=3","gravatar_id":"","url":"https://api.github.com/users/martinmine","html_url":"https://github.com/martinmine","followers_url":"https://api.github.com/users/martinmine/followers","following_url":"https://api.github.com/users/martinmine/following{/other_user}","gists_url":"https://api.github.com/users/martinmine/gists{/gist_id}","starred_url":"https://api.github.com/users/martinmine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinmine/subscriptions","organizations_url":"https://api.github.com/users/martinmine/orgs","repos_url":"https://api.github.com/users/martinmine/repos","events_url":"https://api.github.com/users/martinmine/events{/privacy}","received_events_url":"https://api.github.com/users/martinmine/received_events","type":"User","site_admin":false},"repo":{"id":62307258,"name":"github-plugin","full_name":"martinmine/github-plugin","owner":{"login":"martinmine","id":2211729,"avatar_url":"https://avatars.githubusercontent.com/u/2211729?v=3","gravatar_id":"","url":"https://api.github.com/users/martinmine","html_url":"https://github.com/martinmine","followers_url":"https://api.github.com/users/martinmine/followers","following_url":"https://api.github.com/users/martinmine/following{/other_user}","gists_url":"https://api.github.com/users/martinmine/gists{/gist_id}","starred_url":"https://api.github.com/users/martinmine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinmine/subscriptions","organizations_url":"https://api.github.com/users/martinmine/orgs","repos_url":"https://api.github.com/users/martinmine/repos","events_url":"https://api.github.com/users/martinmine/events{/privacy}","received_events_url":"https://api.github.com/users/martinmine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinmine/github-plugin","description":"Jenkins GitHub plugin","fork":true,"url":"https://api.github.com/repos/martinmine/github-plugin","forks_url":"https://api.github.com/repos/martinmine/github-plugin/forks","keys_url":"https://api.github.com/repos/martinmine/github-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinmine/github-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinmine/github-plugin/teams","hooks_url":"https://api.github.com/repos/martinmine/github-plugin/hooks","issue_events_url":"https://api.github.com/repos/martinmine/github-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/martinmine/github-plugin/events","assignees_url":"https://api.github.com/repos/martinmine/github-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/martinmine/github-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/martinmine/github-plugin/tags","blobs_url":"https://api.github.com/repos/martinmine/github-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinmine/github-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinmine/github-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinmine/github-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinmine/github-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/martinmine/github-plugin/languages","stargazers_url":"https://api.github.com/repos/martinmine/github-plugin/stargazers","contributors_url":"https://api.github.com/repos/martinmine/github-plugin/contributors","subscribers_url":"https://api.github.com/repos/martinmine/github-plugin/subscribers","subscription_url":"https://api.github.com/repos/martinmine/github-plugin/subscription","commits_url":"https://api.github.com/repos/martinmine/github-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinmine/github-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinmine/github-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinmine/github-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinmine/github-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/martinmine/github-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinmine/github-plugin/merges","archive_url":"https://api.github.com/repos/martinmine/github-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinmine/github-plugin/downloads","issues_url":"https://api.github.com/repos/martinmine/github-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/martinmine/github-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/martinmine/github-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/martinmine/github-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinmine/github-plugin/labels{/name}","releases_url":"https://api.github.com/repos/martinmine/github-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/martinmine/github-plugin/deployments","created_at":"2016-06-30T12:01:59Z","updated_at":"2016-06-30T12:02:00Z","pushed_at":"2016-07-08T14:28:57Z","git_url":"git://github.com/martinmine/github-plugin.git","ssh_url":"git@github.com:martinmine/github-plugin.git","clone_url":"https://github.com/martinmine/github-plugin.git","svn_url":"https://github.com/martinmine/github-plugin","homepage":"http://wiki.jenkins-ci.org/display/JENKINS/Github+Plugin","size":727,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"e9caf00f01508e35b744ebe0dd9985c84b0d9469","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1163555,"name":"github-plugin","full_name":"jenkinsci/github-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/github-plugin","description":"Jenkins GitHub plugin","fork":false,"url":"https://api.github.com/repos/jenkinsci/github-plugin","forks_url":"https://api.github.com/repos/jenkinsci/github-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/github-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/github-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/github-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/github-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/github-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/github-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/github-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/github-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/github-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/github-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/github-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/github-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/github-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/github-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/github-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/github-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/github-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/github-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/github-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/github-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/github-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/github-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/github-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/github-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/github-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/github-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/github-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/github-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/github-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/github-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/github-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/github-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/github-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/github-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/github-plugin/deployments","created_at":"2010-12-13T05:35:14Z","updated_at":"2016-07-06T18:45:16Z","pushed_at":"2016-07-08T14:50:37Z","git_url":"git://github.com/jenkinsci/github-plugin.git","ssh_url":"git@github.com:jenkinsci/github-plugin.git","clone_url":"https://github.com/jenkinsci/github-plugin.git","svn_url":"https://github.com/jenkinsci/github-plugin","homepage":"http://wiki.jenkins-ci.org/display/JENKINS/Github+Plugin","size":1138,"stargazers_count":154,"watchers_count":154,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":222,"mirror_url":null,"open_issues_count":5,"forks":222,"open_issues":5,"watchers":154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/129"},"html":{"href":"https://github.com/jenkinsci/github-plugin/pull/129"},"issue":{"href":"https://api.github.com/repos/jenkinsci/github-plugin/issues/129"},"comments":{"href":"https://api.github.com/repos/jenkinsci/github-plugin/issues/129/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/129/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/github-plugin/pulls/129/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/github-plugin/statuses/7d2857d158e20e7666643796c7f60c7e02844dd6"}}}}
{"actor":{"display_login":"KostyaSha"}}