{"action":"created","issue":{"url":"https://api.github.com/repos/Ahmed-Ali/Cucumberish/issues/38","repository_url":"https://api.github.com/repos/Ahmed-Ali/Cucumberish","labels_url":"https://api.github.com/repos/Ahmed-Ali/Cucumberish/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/Ahmed-Ali/Cucumberish/issues/38/comments","events_url":"https://api.github.com/repos/Ahmed-Ali/Cucumberish/issues/38/events","html_url":"https://github.com/Ahmed-Ali/Cucumberish/pull/38","id":197273163,"number":38,"title":"Report failure in beforeStartHook","user":{"login":"brentleyjones","id":158658,"avatar_url":"https://avatars.githubusercontent.com/u/158658?v=3","gravatar_id":"","url":"https://api.github.com/users/brentleyjones","html_url":"https://github.com/brentleyjones","followers_url":"https://api.github.com/users/brentleyjones/followers","following_url":"https://api.github.com/users/brentleyjones/following{/other_user}","gists_url":"https://api.github.com/users/brentleyjones/gists{/gist_id}","starred_url":"https://api.github.com/users/brentleyjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentleyjones/subscriptions","organizations_url":"https://api.github.com/users/brentleyjones/orgs","repos_url":"https://api.github.com/users/brentleyjones/repos","events_url":"https://api.github.com/users/brentleyjones/events{/privacy}","received_events_url":"https://api.github.com/users/brentleyjones/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-22T21:46:30Z","updated_at":"2016-12-22T22:42:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Ahmed-Ali/Cucumberish/pulls/38","html_url":"https://github.com/Ahmed-Ali/Cucumberish/pull/38","diff_url":"https://github.com/Ahmed-Ali/Cucumberish/pull/38.diff","patch_url":"https://github.com/Ahmed-Ali/Cucumberish/pull/38.patch"},"body":"Currently an assertion failure in any of the hooks will throw an exception and not report a test failure. This change makes them all report test failures (except after finish, which I'll speak to).\r\n\r\nOf importance is that if the beforeStartHook fails it will fail all of the scenarios. This is useful since you will normally setup preconditions needed for the rest of your tests in that hook.\r\n\r\nThe afterFinishHook is not handled the same way, for a couple reasons:\r\n- It's after all of your scenarios, so if they all passed we don't want a test failure\r\n- I don't know what to do if you have a failure there. Not crashing would probably be nice. I don't use this feature though, so I'm not the best one to ask\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Ahmed-Ali/Cucumberish/issues/comments/268906963","html_url":"https://github.com/Ahmed-Ali/Cucumberish/pull/38#issuecomment-268906963","issue_url":"https://api.github.com/repos/Ahmed-Ali/Cucumberish/issues/38","id":268906963,"user":{"login":"brentleyjones","id":158658,"avatar_url":"https://avatars.githubusercontent.com/u/158658?v=3","gravatar_id":"","url":"https://api.github.com/users/brentleyjones","html_url":"https://github.com/brentleyjones","followers_url":"https://api.github.com/users/brentleyjones/followers","following_url":"https://api.github.com/users/brentleyjones/following{/other_user}","gists_url":"https://api.github.com/users/brentleyjones/gists{/gist_id}","starred_url":"https://api.github.com/users/brentleyjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentleyjones/subscriptions","organizations_url":"https://api.github.com/users/brentleyjones/orgs","repos_url":"https://api.github.com/users/brentleyjones/repos","events_url":"https://api.github.com/users/brentleyjones/events{/privacy}","received_events_url":"https://api.github.com/users/brentleyjones/received_events","type":"User","site_admin":false},"created_at":"2016-12-22T22:42:06Z","updated_at":"2016-12-22T22:42:06Z","body":"No problem. Have a good holiday if you are celebrating. We can work with forks for a while."}}
{"actor":{"display_login":"brentleyjones"}}