{"action":"closed","number":607,"pull_request":{"url":"https://api.github.com/repos/os-autoinst/openQA/pulls/607","id":62325198,"html_url":"https://github.com/os-autoinst/openQA/pull/607","diff_url":"https://github.com/os-autoinst/openQA/pull/607.diff","patch_url":"https://github.com/os-autoinst/openQA/pull/607.patch","issue_url":"https://api.github.com/repos/os-autoinst/openQA/issues/607","number":607,"state":"closed","locked":false,"title":"limit_assets: never remove assets for scheduled/running jobs","user":{"login":"AdamWill","id":916551,"avatar_url":"https://avatars.githubusercontent.com/u/916551?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamWill","html_url":"https://github.com/AdamWill","followers_url":"https://api.github.com/users/AdamWill/followers","following_url":"https://api.github.com/users/AdamWill/following{/other_user}","gists_url":"https://api.github.com/users/AdamWill/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamWill/subscriptions","organizations_url":"https://api.github.com/users/AdamWill/orgs","repos_url":"https://api.github.com/users/AdamWill/repos","events_url":"https://api.github.com/users/AdamWill/events{/privacy}","received_events_url":"https://api.github.com/users/AdamWill/received_events","type":"User","site_admin":false},"body":"I'm not at all sure this is correct, but I *think* it may be\r\nneeded. AFAICS, limit_assets does not do anything at present\r\nto avoid removing assets associated with pending jobs, and I\r\nthink it should, so it doesn't 'clean up' a generated HDD\r\nwhile a job is still queued up expecting to use it, for e.g.\r\n\r\nPlease do have someone familiar with this code check this over\r\nand make sure a) it's needed and b) it works right.","created_at":"2016-03-10T01:21:25Z","updated_at":"2016-03-10T23:12:21Z","closed_at":"2016-03-10T23:12:21Z","merged_at":null,"merge_commit_sha":"c9752659e59be22d5b5669e7cb5cafee3dacc047","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/607/commits","review_comments_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/607/comments","review_comment_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/os-autoinst/openQA/issues/607/comments","statuses_url":"https://api.github.com/repos/os-autoinst/openQA/statuses/8c239cabcb4248680000ee261e6c90857a2eaf88","head":{"label":"AdamWill:safe-asset-clean","ref":"safe-asset-clean","sha":"8c239cabcb4248680000ee261e6c90857a2eaf88","user":{"login":"AdamWill","id":916551,"avatar_url":"https://avatars.githubusercontent.com/u/916551?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamWill","html_url":"https://github.com/AdamWill","followers_url":"https://api.github.com/users/AdamWill/followers","following_url":"https://api.github.com/users/AdamWill/following{/other_user}","gists_url":"https://api.github.com/users/AdamWill/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamWill/subscriptions","organizations_url":"https://api.github.com/users/AdamWill/orgs","repos_url":"https://api.github.com/users/AdamWill/repos","events_url":"https://api.github.com/users/AdamWill/events{/privacy}","received_events_url":"https://api.github.com/users/AdamWill/received_events","type":"User","site_admin":false},"repo":{"id":31450875,"name":"openQA","full_name":"AdamWill/openQA","owner":{"login":"AdamWill","id":916551,"avatar_url":"https://avatars.githubusercontent.com/u/916551?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamWill","html_url":"https://github.com/AdamWill","followers_url":"https://api.github.com/users/AdamWill/followers","following_url":"https://api.github.com/users/AdamWill/following{/other_user}","gists_url":"https://api.github.com/users/AdamWill/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamWill/subscriptions","organizations_url":"https://api.github.com/users/AdamWill/orgs","repos_url":"https://api.github.com/users/AdamWill/repos","events_url":"https://api.github.com/users/AdamWill/events{/privacy}","received_events_url":"https://api.github.com/users/AdamWill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AdamWill/openQA","description":"openQA web-frontend, scheduler and tools","fork":true,"url":"https://api.github.com/repos/AdamWill/openQA","forks_url":"https://api.github.com/repos/AdamWill/openQA/forks","keys_url":"https://api.github.com/repos/AdamWill/openQA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AdamWill/openQA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AdamWill/openQA/teams","hooks_url":"https://api.github.com/repos/AdamWill/openQA/hooks","issue_events_url":"https://api.github.com/repos/AdamWill/openQA/issues/events{/number}","events_url":"https://api.github.com/repos/AdamWill/openQA/events","assignees_url":"https://api.github.com/repos/AdamWill/openQA/assignees{/user}","branches_url":"https://api.github.com/repos/AdamWill/openQA/branches{/branch}","tags_url":"https://api.github.com/repos/AdamWill/openQA/tags","blobs_url":"https://api.github.com/repos/AdamWill/openQA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AdamWill/openQA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AdamWill/openQA/git/refs{/sha}","trees_url":"https://api.github.com/repos/AdamWill/openQA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AdamWill/openQA/statuses/{sha}","languages_url":"https://api.github.com/repos/AdamWill/openQA/languages","stargazers_url":"https://api.github.com/repos/AdamWill/openQA/stargazers","contributors_url":"https://api.github.com/repos/AdamWill/openQA/contributors","subscribers_url":"https://api.github.com/repos/AdamWill/openQA/subscribers","subscription_url":"https://api.github.com/repos/AdamWill/openQA/subscription","commits_url":"https://api.github.com/repos/AdamWill/openQA/commits{/sha}","git_commits_url":"https://api.github.com/repos/AdamWill/openQA/git/commits{/sha}","comments_url":"https://api.github.com/repos/AdamWill/openQA/comments{/number}","issue_comment_url":"https://api.github.com/repos/AdamWill/openQA/issues/comments{/number}","contents_url":"https://api.github.com/repos/AdamWill/openQA/contents/{+path}","compare_url":"https://api.github.com/repos/AdamWill/openQA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AdamWill/openQA/merges","archive_url":"https://api.github.com/repos/AdamWill/openQA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AdamWill/openQA/downloads","issues_url":"https://api.github.com/repos/AdamWill/openQA/issues{/number}","pulls_url":"https://api.github.com/repos/AdamWill/openQA/pulls{/number}","milestones_url":"https://api.github.com/repos/AdamWill/openQA/milestones{/number}","notifications_url":"https://api.github.com/repos/AdamWill/openQA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AdamWill/openQA/labels{/name}","releases_url":"https://api.github.com/repos/AdamWill/openQA/releases{/id}","deployments_url":"https://api.github.com/repos/AdamWill/openQA/deployments","created_at":"2015-02-28T04:25:25Z","updated_at":"2016-01-14T20:53:49Z","pushed_at":"2016-03-10T22:53:42Z","git_url":"git://github.com/AdamWill/openQA.git","ssh_url":"git@github.com:AdamWill/openQA.git","clone_url":"https://github.com/AdamWill/openQA.git","svn_url":"https://github.com/AdamWill/openQA","homepage":"http://openqa.opensuse.org/","size":14202,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"os-autoinst:master","ref":"master","sha":"51f9f9c53ef641d2d3bd6621a44309762fdb36c1","user":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars.githubusercontent.com/u/6918706?v=3","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"repo":{"id":20883829,"name":"openQA","full_name":"os-autoinst/openQA","owner":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars.githubusercontent.com/u/6918706?v=3","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/os-autoinst/openQA","description":"openQA web-frontend, scheduler and tools","fork":false,"url":"https://api.github.com/repos/os-autoinst/openQA","forks_url":"https://api.github.com/repos/os-autoinst/openQA/forks","keys_url":"https://api.github.com/repos/os-autoinst/openQA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/os-autoinst/openQA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/os-autoinst/openQA/teams","hooks_url":"https://api.github.com/repos/os-autoinst/openQA/hooks","issue_events_url":"https://api.github.com/repos/os-autoinst/openQA/issues/events{/number}","events_url":"https://api.github.com/repos/os-autoinst/openQA/events","assignees_url":"https://api.github.com/repos/os-autoinst/openQA/assignees{/user}","branches_url":"https://api.github.com/repos/os-autoinst/openQA/branches{/branch}","tags_url":"https://api.github.com/repos/os-autoinst/openQA/tags","blobs_url":"https://api.github.com/repos/os-autoinst/openQA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/os-autoinst/openQA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/os-autoinst/openQA/git/refs{/sha}","trees_url":"https://api.github.com/repos/os-autoinst/openQA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/os-autoinst/openQA/statuses/{sha}","languages_url":"https://api.github.com/repos/os-autoinst/openQA/languages","stargazers_url":"https://api.github.com/repos/os-autoinst/openQA/stargazers","contributors_url":"https://api.github.com/repos/os-autoinst/openQA/contributors","subscribers_url":"https://api.github.com/repos/os-autoinst/openQA/subscribers","subscription_url":"https://api.github.com/repos/os-autoinst/openQA/subscription","commits_url":"https://api.github.com/repos/os-autoinst/openQA/commits{/sha}","git_commits_url":"https://api.github.com/repos/os-autoinst/openQA/git/commits{/sha}","comments_url":"https://api.github.com/repos/os-autoinst/openQA/comments{/number}","issue_comment_url":"https://api.github.com/repos/os-autoinst/openQA/issues/comments{/number}","contents_url":"https://api.github.com/repos/os-autoinst/openQA/contents/{+path}","compare_url":"https://api.github.com/repos/os-autoinst/openQA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/os-autoinst/openQA/merges","archive_url":"https://api.github.com/repos/os-autoinst/openQA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/os-autoinst/openQA/downloads","issues_url":"https://api.github.com/repos/os-autoinst/openQA/issues{/number}","pulls_url":"https://api.github.com/repos/os-autoinst/openQA/pulls{/number}","milestones_url":"https://api.github.com/repos/os-autoinst/openQA/milestones{/number}","notifications_url":"https://api.github.com/repos/os-autoinst/openQA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/os-autoinst/openQA/labels{/name}","releases_url":"https://api.github.com/repos/os-autoinst/openQA/releases{/id}","deployments_url":"https://api.github.com/repos/os-autoinst/openQA/deployments","created_at":"2014-06-16T12:23:22Z","updated_at":"2016-03-09T10:23:30Z","pushed_at":"2016-03-10T22:53:43Z","git_url":"git://github.com/os-autoinst/openQA.git","ssh_url":"git@github.com:os-autoinst/openQA.git","clone_url":"https://github.com/os-autoinst/openQA.git","svn_url":"https://github.com/os-autoinst/openQA","homepage":"http://openqa.opensuse.org/","size":15389,"stargazers_count":46,"watchers_count":46,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":40,"mirror_url":null,"open_issues_count":18,"forks":40,"open_issues":18,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/607"},"html":{"href":"https://github.com/os-autoinst/openQA/pull/607"},"issue":{"href":"https://api.github.com/repos/os-autoinst/openQA/issues/607"},"comments":{"href":"https://api.github.com/repos/os-autoinst/openQA/issues/607/comments"},"review_comments":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/607/comments"},"review_comment":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/607/commits"},"statuses":{"href":"https://api.github.com/repos/os-autoinst/openQA/statuses/8c239cabcb4248680000ee261e6c90857a2eaf88"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":0,"commits":1,"additions":11,"deletions":1,"changed_files":1}}