{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/55955088","id":55955088,"diff_hunk":"@@ -192,6 +191,11 @@ def inv(trig):\n                 invs += Union(*[imageset(Lambda(n, L(g)), S.Integers) for g in g_ys])\n             return _invert_real(f.args[0], invs, symbol)\n \n+    if (isinstance(a,log) for a in f.args):\n+        f_tmp = logcombine(f , force = True)\n+        if isinstance(f_tmp,log):\n+            invs = E**(list(g_ys)[0])\n+            return _invert_real(simplify(f_tmp.args[0]), FiniteSet(invs), symbol)","path":"sympy/solvers/solveset.py","position":41,"original_position":41,"commit_id":"ba4e73077b99315c31debf5256baf3f159d5dea2","original_commit_id":"ba4e73077b99315c31debf5256baf3f159d5dea2","user":{"login":"Shekharrajak","id":5774448,"avatar_url":"https://avatars.githubusercontent.com/u/5774448?v=3","gravatar_id":"","url":"https://api.github.com/users/Shekharrajak","html_url":"https://github.com/Shekharrajak","followers_url":"https://api.github.com/users/Shekharrajak/followers","following_url":"https://api.github.com/users/Shekharrajak/following{/other_user}","gists_url":"https://api.github.com/users/Shekharrajak/gists{/gist_id}","starred_url":"https://api.github.com/users/Shekharrajak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shekharrajak/subscriptions","organizations_url":"https://api.github.com/users/Shekharrajak/orgs","repos_url":"https://api.github.com/users/Shekharrajak/repos","events_url":"https://api.github.com/users/Shekharrajak/events{/privacy}","received_events_url":"https://api.github.com/users/Shekharrajak/received_events","type":"User","site_admin":false},"body":"Actual problem was if we pass without simplifying in `_invert_real` then because of multiple operators it won't go inside the particular `if` condition and return unsolved.\r\nThere are some more cases where if we pass simplified expression then `_invert` can give answer for example [this testcase](https://github.com/sympy/sympy/blob/master/sympy/solvers/tests/test_solveset.py#L602) ","created_at":"2016-03-14T04:27:05Z","updated_at":"2016-03-14T04:27:05Z","html_url":"https://github.com/sympy/sympy/pull/10733#discussion_r55955088","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/10733","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/55955088"},"html":{"href":"https://github.com/sympy/sympy/pull/10733#discussion_r55955088"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/10733"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/10733","id":61797825,"html_url":"https://github.com/sympy/sympy/pull/10733","diff_url":"https://github.com/sympy/sympy/pull/10733.diff","patch_url":"https://github.com/sympy/sympy/pull/10733.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/10733","number":10733,"state":"open","locked":false,"title":"better _solve_trig, _invert method.","user":{"login":"Shekharrajak","id":5774448,"avatar_url":"https://avatars.githubusercontent.com/u/5774448?v=3","gravatar_id":"","url":"https://api.github.com/users/Shekharrajak","html_url":"https://github.com/Shekharrajak","followers_url":"https://api.github.com/users/Shekharrajak/followers","following_url":"https://api.github.com/users/Shekharrajak/following{/other_user}","gists_url":"https://api.github.com/users/Shekharrajak/gists{/gist_id}","starred_url":"https://api.github.com/users/Shekharrajak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shekharrajak/subscriptions","organizations_url":"https://api.github.com/users/Shekharrajak/orgs","repos_url":"https://api.github.com/users/Shekharrajak/repos","events_url":"https://api.github.com/users/Shekharrajak/events{/privacy}","received_events_url":"https://api.github.com/users/Shekharrajak/received_events","type":"User","site_admin":false},"body":"Rewriting \r\nhttps://github.com/sympy/sympy/pull/10552 and\r\nhttps://github.com/sympy/sympy/pull/10482 in effective way with additional changes.\r\n\r\n\r\n- [x]  rewrite #10552 done\r\n- [x]  Fixes #10671 \r\n- [x]  Fixes #7914 \r\n- [x]  Fixes #9531 #9606\r\n- [x] Fixes #9824\r\n- [x] Fixes https://github.com/sympy/sympy/issues/10426\r\n- [x]  Fixes [XFAIL test_solve_trig_simplified ](https://github.com/sympy/sympy/pull/10733/files#diff-85baa04bbf4e1dfd9128782738e45424R724)\r\n- [x]  Fixes [XFAIL test_solve_trig_abs](https://github.com/sympy/sympy/pull/10733/files#diff-85baa04bbf4e1dfd9128782738e45424R752)\r\n- [x]  Fixes [XFAIL test_uselogcombine](https://github.com/sympy/sympy/pull/10733/files#diff-85baa04bbf4e1dfd9128782738e45424R547) and [this](https://github.com/sympy/sympy/pull/10733/files#diff-85baa04bbf4e1dfd9128782738e45424R537)\r\n- [x]  [Now Sympy can solve trig equation without converting them into exp form and unsolvable conditionSet will be in the form of trig function, not in complicated exp form](https://github.com/sympy/sympy/pull/10733/files#diff-eec0422923e8f100745c015cd8fdd6cfR396)\r\n\r\nTODO\r\n\r\n- [x] test_solve_lambert\r\n- [ ] test_conditionset_equality\r\n- [ ] test_issue_pow\r\n- [ ] test_solve_only_exp_2\r\n\r\nBelow fixes is in #10764\r\notherwise it will be difficult for review and for me as well.\r\n\r\n- [x] Fixes https://github.com/sympy/sympy/issues/10217\r\n- [x] Fixes [XFAIL testcases of Hyperbolic Functions](https://github.com/sympy/sympy/pull/10764/files#diff-85baa04bbf4e1dfd9128782738e45424R577)\r\n\r\nI am trying to make changes, whatever I was thinking since last month.","created_at":"2016-03-05T02:36:19Z","updated_at":"2016-03-14T04:27:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"707b9ebf3f67733809c69b112fa1d8c4fffacb26","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/10733/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/10733/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/10733/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/ba4e73077b99315c31debf5256baf3f159d5dea2","head":{"label":"Shekharrajak:solveset_trig","ref":"solveset_trig","sha":"ba4e73077b99315c31debf5256baf3f159d5dea2","user":{"login":"Shekharrajak","id":5774448,"avatar_url":"https://avatars.githubusercontent.com/u/5774448?v=3","gravatar_id":"","url":"https://api.github.com/users/Shekharrajak","html_url":"https://github.com/Shekharrajak","followers_url":"https://api.github.com/users/Shekharrajak/followers","following_url":"https://api.github.com/users/Shekharrajak/following{/other_user}","gists_url":"https://api.github.com/users/Shekharrajak/gists{/gist_id}","starred_url":"https://api.github.com/users/Shekharrajak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shekharrajak/subscriptions","organizations_url":"https://api.github.com/users/Shekharrajak/orgs","repos_url":"https://api.github.com/users/Shekharrajak/repos","events_url":"https://api.github.com/users/Shekharrajak/events{/privacy}","received_events_url":"https://api.github.com/users/Shekharrajak/received_events","type":"User","site_admin":false},"repo":{"id":42365606,"name":"sympy","full_name":"Shekharrajak/sympy","owner":{"login":"Shekharrajak","id":5774448,"avatar_url":"https://avatars.githubusercontent.com/u/5774448?v=3","gravatar_id":"","url":"https://api.github.com/users/Shekharrajak","html_url":"https://github.com/Shekharrajak","followers_url":"https://api.github.com/users/Shekharrajak/followers","following_url":"https://api.github.com/users/Shekharrajak/following{/other_user}","gists_url":"https://api.github.com/users/Shekharrajak/gists{/gist_id}","starred_url":"https://api.github.com/users/Shekharrajak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shekharrajak/subscriptions","organizations_url":"https://api.github.com/users/Shekharrajak/orgs","repos_url":"https://api.github.com/users/Shekharrajak/repos","events_url":"https://api.github.com/users/Shekharrajak/events{/privacy}","received_events_url":"https://api.github.com/users/Shekharrajak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Shekharrajak/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/Shekharrajak/sympy","forks_url":"https://api.github.com/repos/Shekharrajak/sympy/forks","keys_url":"https://api.github.com/repos/Shekharrajak/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shekharrajak/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shekharrajak/sympy/teams","hooks_url":"https://api.github.com/repos/Shekharrajak/sympy/hooks","issue_events_url":"https://api.github.com/repos/Shekharrajak/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/Shekharrajak/sympy/events","assignees_url":"https://api.github.com/repos/Shekharrajak/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/Shekharrajak/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/Shekharrajak/sympy/tags","blobs_url":"https://api.github.com/repos/Shekharrajak/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shekharrajak/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shekharrajak/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shekharrajak/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shekharrajak/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/Shekharrajak/sympy/languages","stargazers_url":"https://api.github.com/repos/Shekharrajak/sympy/stargazers","contributors_url":"https://api.github.com/repos/Shekharrajak/sympy/contributors","subscribers_url":"https://api.github.com/repos/Shekharrajak/sympy/subscribers","subscription_url":"https://api.github.com/repos/Shekharrajak/sympy/subscription","commits_url":"https://api.github.com/repos/Shekharrajak/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shekharrajak/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shekharrajak/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shekharrajak/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shekharrajak/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/Shekharrajak/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shekharrajak/sympy/merges","archive_url":"https://api.github.com/repos/Shekharrajak/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shekharrajak/sympy/downloads","issues_url":"https://api.github.com/repos/Shekharrajak/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/Shekharrajak/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/Shekharrajak/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/Shekharrajak/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shekharrajak/sympy/labels{/name}","releases_url":"https://api.github.com/repos/Shekharrajak/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/Shekharrajak/sympy/deployments","created_at":"2015-09-12T17:09:44Z","updated_at":"2016-02-09T11:08:45Z","pushed_at":"2016-03-13T08:49:34Z","git_url":"git://github.com/Shekharrajak/sympy.git","ssh_url":"git@github.com:Shekharrajak/sympy.git","clone_url":"https://github.com/Shekharrajak/sympy.git","svn_url":"https://github.com/Shekharrajak/sympy","homepage":"http://sympy.org/","size":75588,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"7e2c5280fd12994b952d599b19d5e5be14629918","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/sympy/sympy/deployments","created_at":"2010-04-30T20:37:14Z","updated_at":"2016-03-14T00:57:33Z","pushed_at":"2016-03-14T03:04:12Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":105668,"stargazers_count":2712,"watchers_count":2712,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1401,"mirror_url":null,"open_issues_count":2231,"forks":1401,"open_issues":2231,"watchers":2712,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/10733"},"html":{"href":"https://github.com/sympy/sympy/pull/10733"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/10733"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/10733/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/10733/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/10733/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/ba4e73077b99315c31debf5256baf3f159d5dea2"}}}}