{"action":"closed","number":81,"pull_request":{"url":"https://api.github.com/repos/mvel/mvel/pulls/81","id":55886633,"html_url":"https://github.com/mvel/mvel/pull/81","diff_url":"https://github.com/mvel/mvel/pull/81.diff","patch_url":"https://github.com/mvel/mvel/pull/81.patch","issue_url":"https://api.github.com/repos/mvel/mvel/issues/81","number":81,"state":"closed","locked":false,"title":"Fix case with overloaded methods.","user":{"login":"mkostrze","id":16683552,"avatar_url":"https://avatars.githubusercontent.com/u/16683552?v=3","gravatar_id":"","url":"https://api.github.com/users/mkostrze","html_url":"https://github.com/mkostrze","followers_url":"https://api.github.com/users/mkostrze/followers","following_url":"https://api.github.com/users/mkostrze/following{/other_user}","gists_url":"https://api.github.com/users/mkostrze/gists{/gist_id}","starred_url":"https://api.github.com/users/mkostrze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkostrze/subscriptions","organizations_url":"https://api.github.com/users/mkostrze/orgs","repos_url":"https://api.github.com/users/mkostrze/repos","events_url":"https://api.github.com/users/mkostrze/events{/privacy}","received_events_url":"https://api.github.com/users/mkostrze/received_events","type":"User","site_admin":false},"body":"I found a case when ParseTools.getExactMatch function doesn't return proper method. Test case attached and the logic flaw there is pretty obvious (when iterating through the arguments it should make sure they are all equal and not return null on first difference because there may be a better overloaded method)\r\n\r\nI found this being a root cause of a production problem I had when this method was called from a getWidenedTarget after an IllegalAccessException in PropertyAccessor.getMethod. The exception was thrown correctly (the method in the class was marked as package private so it wasn't visible indeed) but the handling failed due to above getExactMatch problem.\r\n\r\n","created_at":"2016-01-13T11:42:32Z","updated_at":"2016-01-21T13:41:01Z","closed_at":"2016-01-21T13:41:01Z","merged_at":"2016-01-21T13:41:01Z","merge_commit_sha":"5236c522dec19ce63edbd4ac2bbf866df7771f76","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mvel/mvel/pulls/81/commits","review_comments_url":"https://api.github.com/repos/mvel/mvel/pulls/81/comments","review_comment_url":"https://api.github.com/repos/mvel/mvel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mvel/mvel/issues/81/comments","statuses_url":"https://api.github.com/repos/mvel/mvel/statuses/08e4dd65bb0e4603c09658e43646eb39c52dc990","head":{"label":"mkostrze:master","ref":"master","sha":"08e4dd65bb0e4603c09658e43646eb39c52dc990","user":{"login":"mkostrze","id":16683552,"avatar_url":"https://avatars.githubusercontent.com/u/16683552?v=3","gravatar_id":"","url":"https://api.github.com/users/mkostrze","html_url":"https://github.com/mkostrze","followers_url":"https://api.github.com/users/mkostrze/followers","following_url":"https://api.github.com/users/mkostrze/following{/other_user}","gists_url":"https://api.github.com/users/mkostrze/gists{/gist_id}","starred_url":"https://api.github.com/users/mkostrze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkostrze/subscriptions","organizations_url":"https://api.github.com/users/mkostrze/orgs","repos_url":"https://api.github.com/users/mkostrze/repos","events_url":"https://api.github.com/users/mkostrze/events{/privacy}","received_events_url":"https://api.github.com/users/mkostrze/received_events","type":"User","site_admin":false},"repo":{"id":49568831,"name":"mvel","full_name":"mkostrze/mvel","owner":{"login":"mkostrze","id":16683552,"avatar_url":"https://avatars.githubusercontent.com/u/16683552?v=3","gravatar_id":"","url":"https://api.github.com/users/mkostrze","html_url":"https://github.com/mkostrze","followers_url":"https://api.github.com/users/mkostrze/followers","following_url":"https://api.github.com/users/mkostrze/following{/other_user}","gists_url":"https://api.github.com/users/mkostrze/gists{/gist_id}","starred_url":"https://api.github.com/users/mkostrze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkostrze/subscriptions","organizations_url":"https://api.github.com/users/mkostrze/orgs","repos_url":"https://api.github.com/users/mkostrze/repos","events_url":"https://api.github.com/users/mkostrze/events{/privacy}","received_events_url":"https://api.github.com/users/mkostrze/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkostrze/mvel","description":"MVEL (MVFLEX Expression Language)","fork":true,"url":"https://api.github.com/repos/mkostrze/mvel","forks_url":"https://api.github.com/repos/mkostrze/mvel/forks","keys_url":"https://api.github.com/repos/mkostrze/mvel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkostrze/mvel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkostrze/mvel/teams","hooks_url":"https://api.github.com/repos/mkostrze/mvel/hooks","issue_events_url":"https://api.github.com/repos/mkostrze/mvel/issues/events{/number}","events_url":"https://api.github.com/repos/mkostrze/mvel/events","assignees_url":"https://api.github.com/repos/mkostrze/mvel/assignees{/user}","branches_url":"https://api.github.com/repos/mkostrze/mvel/branches{/branch}","tags_url":"https://api.github.com/repos/mkostrze/mvel/tags","blobs_url":"https://api.github.com/repos/mkostrze/mvel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkostrze/mvel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkostrze/mvel/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkostrze/mvel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkostrze/mvel/statuses/{sha}","languages_url":"https://api.github.com/repos/mkostrze/mvel/languages","stargazers_url":"https://api.github.com/repos/mkostrze/mvel/stargazers","contributors_url":"https://api.github.com/repos/mkostrze/mvel/contributors","subscribers_url":"https://api.github.com/repos/mkostrze/mvel/subscribers","subscription_url":"https://api.github.com/repos/mkostrze/mvel/subscription","commits_url":"https://api.github.com/repos/mkostrze/mvel/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkostrze/mvel/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkostrze/mvel/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkostrze/mvel/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkostrze/mvel/contents/{+path}","compare_url":"https://api.github.com/repos/mkostrze/mvel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkostrze/mvel/merges","archive_url":"https://api.github.com/repos/mkostrze/mvel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkostrze/mvel/downloads","issues_url":"https://api.github.com/repos/mkostrze/mvel/issues{/number}","pulls_url":"https://api.github.com/repos/mkostrze/mvel/pulls{/number}","milestones_url":"https://api.github.com/repos/mkostrze/mvel/milestones{/number}","notifications_url":"https://api.github.com/repos/mkostrze/mvel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkostrze/mvel/labels{/name}","releases_url":"https://api.github.com/repos/mkostrze/mvel/releases{/id}","created_at":"2016-01-13T11:09:30Z","updated_at":"2016-01-13T11:09:32Z","pushed_at":"2016-01-13T11:36:06Z","git_url":"git://github.com/mkostrze/mvel.git","ssh_url":"git@github.com:mkostrze/mvel.git","clone_url":"https://github.com/mkostrze/mvel.git","svn_url":"https://github.com/mkostrze/mvel","homepage":"https://en.wikisource.org/wiki/MVEL_Language_Guide","size":16090,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mvel:master","ref":"master","sha":"fc78fd18f41149f389edca064e494ca7b48baf4e","user":{"login":"mvel","id":776419,"avatar_url":"https://avatars.githubusercontent.com/u/776419?v=3","gravatar_id":"","url":"https://api.github.com/users/mvel","html_url":"https://github.com/mvel","followers_url":"https://api.github.com/users/mvel/followers","following_url":"https://api.github.com/users/mvel/following{/other_user}","gists_url":"https://api.github.com/users/mvel/gists{/gist_id}","starred_url":"https://api.github.com/users/mvel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvel/subscriptions","organizations_url":"https://api.github.com/users/mvel/orgs","repos_url":"https://api.github.com/users/mvel/repos","events_url":"https://api.github.com/users/mvel/events{/privacy}","received_events_url":"https://api.github.com/users/mvel/received_events","type":"Organization","site_admin":false},"repo":{"id":1761998,"name":"mvel","full_name":"mvel/mvel","owner":{"login":"mvel","id":776419,"avatar_url":"https://avatars.githubusercontent.com/u/776419?v=3","gravatar_id":"","url":"https://api.github.com/users/mvel","html_url":"https://github.com/mvel","followers_url":"https://api.github.com/users/mvel/followers","following_url":"https://api.github.com/users/mvel/following{/other_user}","gists_url":"https://api.github.com/users/mvel/gists{/gist_id}","starred_url":"https://api.github.com/users/mvel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvel/subscriptions","organizations_url":"https://api.github.com/users/mvel/orgs","repos_url":"https://api.github.com/users/mvel/repos","events_url":"https://api.github.com/users/mvel/events{/privacy}","received_events_url":"https://api.github.com/users/mvel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mvel/mvel","description":"MVEL (MVFLEX Expression Language)","fork":false,"url":"https://api.github.com/repos/mvel/mvel","forks_url":"https://api.github.com/repos/mvel/mvel/forks","keys_url":"https://api.github.com/repos/mvel/mvel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mvel/mvel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mvel/mvel/teams","hooks_url":"https://api.github.com/repos/mvel/mvel/hooks","issue_events_url":"https://api.github.com/repos/mvel/mvel/issues/events{/number}","events_url":"https://api.github.com/repos/mvel/mvel/events","assignees_url":"https://api.github.com/repos/mvel/mvel/assignees{/user}","branches_url":"https://api.github.com/repos/mvel/mvel/branches{/branch}","tags_url":"https://api.github.com/repos/mvel/mvel/tags","blobs_url":"https://api.github.com/repos/mvel/mvel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mvel/mvel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mvel/mvel/git/refs{/sha}","trees_url":"https://api.github.com/repos/mvel/mvel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mvel/mvel/statuses/{sha}","languages_url":"https://api.github.com/repos/mvel/mvel/languages","stargazers_url":"https://api.github.com/repos/mvel/mvel/stargazers","contributors_url":"https://api.github.com/repos/mvel/mvel/contributors","subscribers_url":"https://api.github.com/repos/mvel/mvel/subscribers","subscription_url":"https://api.github.com/repos/mvel/mvel/subscription","commits_url":"https://api.github.com/repos/mvel/mvel/commits{/sha}","git_commits_url":"https://api.github.com/repos/mvel/mvel/git/commits{/sha}","comments_url":"https://api.github.com/repos/mvel/mvel/comments{/number}","issue_comment_url":"https://api.github.com/repos/mvel/mvel/issues/comments{/number}","contents_url":"https://api.github.com/repos/mvel/mvel/contents/{+path}","compare_url":"https://api.github.com/repos/mvel/mvel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mvel/mvel/merges","archive_url":"https://api.github.com/repos/mvel/mvel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mvel/mvel/downloads","issues_url":"https://api.github.com/repos/mvel/mvel/issues{/number}","pulls_url":"https://api.github.com/repos/mvel/mvel/pulls{/number}","milestones_url":"https://api.github.com/repos/mvel/mvel/milestones{/number}","notifications_url":"https://api.github.com/repos/mvel/mvel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mvel/mvel/labels{/name}","releases_url":"https://api.github.com/repos/mvel/mvel/releases{/id}","created_at":"2011-05-17T17:59:38Z","updated_at":"2016-01-19T09:04:55Z","pushed_at":"2016-01-21T13:41:00Z","git_url":"git://github.com/mvel/mvel.git","ssh_url":"git@github.com:mvel/mvel.git","clone_url":"https://github.com/mvel/mvel.git","svn_url":"https://github.com/mvel/mvel","homepage":"https://en.wikisource.org/wiki/MVEL_Language_Guide","size":18220,"stargazers_count":227,"watchers_count":227,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":6,"forks":95,"open_issues":6,"watchers":227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mvel/mvel/pulls/81"},"html":{"href":"https://github.com/mvel/mvel/pull/81"},"issue":{"href":"https://api.github.com/repos/mvel/mvel/issues/81"},"comments":{"href":"https://api.github.com/repos/mvel/mvel/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/mvel/mvel/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/mvel/mvel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mvel/mvel/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/mvel/mvel/statuses/08e4dd65bb0e4603c09658e43646eb39c52dc990"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mariofusco","id":372781,"avatar_url":"https://avatars.githubusercontent.com/u/372781?v=3","gravatar_id":"","url":"https://api.github.com/users/mariofusco","html_url":"https://github.com/mariofusco","followers_url":"https://api.github.com/users/mariofusco/followers","following_url":"https://api.github.com/users/mariofusco/following{/other_user}","gists_url":"https://api.github.com/users/mariofusco/gists{/gist_id}","starred_url":"https://api.github.com/users/mariofusco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariofusco/subscriptions","organizations_url":"https://api.github.com/users/mariofusco/orgs","repos_url":"https://api.github.com/users/mariofusco/repos","events_url":"https://api.github.com/users/mariofusco/events{/privacy}","received_events_url":"https://api.github.com/users/mariofusco/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":41,"deletions":2,"changed_files":4}}