{"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/paasta/pulls/comments/55566384","id":55566384,"diff_hunk":"@@ -227,7 +227,7 @@ def get_autoscaling_params(self):\n         default_params = {\n             'method': 'default',\n         }\n-        return self.config_dict.get('autoscaling', default_params)","path":"paasta_tools/marathon_tools.py","position":4,"original_position":4,"commit_id":"287c1d092551a3002f848d0ab5144ed65b9f4d86","original_commit_id":"287c1d092551a3002f848d0ab5144ed65b9f4d86","user":{"login":"solarkennedy","id":370205,"avatar_url":"https://avatars.githubusercontent.com/u/370205?v=3","gravatar_id":"","url":"https://api.github.com/users/solarkennedy","html_url":"https://github.com/solarkennedy","followers_url":"https://api.github.com/users/solarkennedy/followers","following_url":"https://api.github.com/users/solarkennedy/following{/other_user}","gists_url":"https://api.github.com/users/solarkennedy/gists{/gist_id}","starred_url":"https://api.github.com/users/solarkennedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarkennedy/subscriptions","organizations_url":"https://api.github.com/users/solarkennedy/orgs","repos_url":"https://api.github.com/users/solarkennedy/repos","events_url":"https://api.github.com/users/solarkennedy/events{/privacy}","received_events_url":"https://api.github.com/users/solarkennedy/received_events","type":"User","site_admin":false},"body":"meh. shipit","created_at":"2016-03-09T18:41:19Z","updated_at":"2016-03-09T18:41:19Z","html_url":"https://github.com/Yelp/paasta/pull/308#discussion_r55566384","pull_request_url":"https://api.github.com/repos/Yelp/paasta/pulls/308","_links":{"self":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/comments/55566384"},"html":{"href":"https://github.com/Yelp/paasta/pull/308#discussion_r55566384"},"pull_request":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/308"}}},"pull_request":{"url":"https://api.github.com/repos/Yelp/paasta/pulls/308","id":62156139,"html_url":"https://github.com/Yelp/paasta/pull/308","diff_url":"https://github.com/Yelp/paasta/pull/308.diff","patch_url":"https://github.com/Yelp/paasta/pull/308.patch","issue_url":"https://api.github.com/repos/Yelp/paasta/issues/308","number":308,"state":"open","locked":false,"title":"fixed the default autoscaling config args","user":{"login":"mjksmith","id":2931921,"avatar_url":"https://avatars.githubusercontent.com/u/2931921?v=3","gravatar_id":"","url":"https://api.github.com/users/mjksmith","html_url":"https://github.com/mjksmith","followers_url":"https://api.github.com/users/mjksmith/followers","following_url":"https://api.github.com/users/mjksmith/following{/other_user}","gists_url":"https://api.github.com/users/mjksmith/gists{/gist_id}","starred_url":"https://api.github.com/users/mjksmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjksmith/subscriptions","organizations_url":"https://api.github.com/users/mjksmith/orgs","repos_url":"https://api.github.com/users/mjksmith/repos","events_url":"https://api.github.com/users/mjksmith/events{/privacy}","received_events_url":"https://api.github.com/users/mjksmith/received_events","type":"User","site_admin":false},"body":"`self.config_dict.get('autoscaling', default_params)` doesn't work if `'autoscaling'` is only a partial dict -- e.g. there are two default params and `'autoscaling'` only contains one of them.","created_at":"2016-03-08T23:37:10Z","updated_at":"2016-03-09T18:41:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c16d1c4e520f4f8f08bf4e927b9cebd727f00d3","assignee":{"login":"mjksmith","id":2931921,"avatar_url":"https://avatars.githubusercontent.com/u/2931921?v=3","gravatar_id":"","url":"https://api.github.com/users/mjksmith","html_url":"https://github.com/mjksmith","followers_url":"https://api.github.com/users/mjksmith/followers","following_url":"https://api.github.com/users/mjksmith/following{/other_user}","gists_url":"https://api.github.com/users/mjksmith/gists{/gist_id}","starred_url":"https://api.github.com/users/mjksmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjksmith/subscriptions","organizations_url":"https://api.github.com/users/mjksmith/orgs","repos_url":"https://api.github.com/users/mjksmith/repos","events_url":"https://api.github.com/users/mjksmith/events{/privacy}","received_events_url":"https://api.github.com/users/mjksmith/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/paasta/pulls/308/commits","review_comments_url":"https://api.github.com/repos/Yelp/paasta/pulls/308/comments","review_comment_url":"https://api.github.com/repos/Yelp/paasta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/paasta/issues/308/comments","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/287c1d092551a3002f848d0ab5144ed65b9f4d86","head":{"label":"Yelp:fix_autoscaling_config_dict","ref":"fix_autoscaling_config_dict","sha":"287c1d092551a3002f848d0ab5144ed65b9f4d86","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":44998824,"name":"paasta","full_name":"Yelp/paasta","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/paasta","description":"An open, distributed platform as a service","fork":false,"url":"https://api.github.com/repos/Yelp/paasta","forks_url":"https://api.github.com/repos/Yelp/paasta/forks","keys_url":"https://api.github.com/repos/Yelp/paasta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/paasta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/paasta/teams","hooks_url":"https://api.github.com/repos/Yelp/paasta/hooks","issue_events_url":"https://api.github.com/repos/Yelp/paasta/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/paasta/events","assignees_url":"https://api.github.com/repos/Yelp/paasta/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/paasta/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/paasta/tags","blobs_url":"https://api.github.com/repos/Yelp/paasta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/paasta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/paasta/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/paasta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/paasta/languages","stargazers_url":"https://api.github.com/repos/Yelp/paasta/stargazers","contributors_url":"https://api.github.com/repos/Yelp/paasta/contributors","subscribers_url":"https://api.github.com/repos/Yelp/paasta/subscribers","subscription_url":"https://api.github.com/repos/Yelp/paasta/subscription","commits_url":"https://api.github.com/repos/Yelp/paasta/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/paasta/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/paasta/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/paasta/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/paasta/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/paasta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/paasta/merges","archive_url":"https://api.github.com/repos/Yelp/paasta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/paasta/downloads","issues_url":"https://api.github.com/repos/Yelp/paasta/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/paasta/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/paasta/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/paasta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/paasta/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/paasta/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/paasta/deployments","created_at":"2015-10-26T21:35:53Z","updated_at":"2016-03-09T01:09:49Z","pushed_at":"2016-03-09T17:33:03Z","git_url":"git://github.com/Yelp/paasta.git","ssh_url":"git@github.com:Yelp/paasta.git","clone_url":"https://github.com/Yelp/paasta.git","svn_url":"https://github.com/Yelp/paasta","homepage":"","size":7243,"stargazers_count":758,"watchers_count":758,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":24,"forks":61,"open_issues":24,"watchers":758,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"a30b846d55d45edecb4afaf5fb771f5e65e692ec","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":44998824,"name":"paasta","full_name":"Yelp/paasta","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/paasta","description":"An open, distributed platform as a service","fork":false,"url":"https://api.github.com/repos/Yelp/paasta","forks_url":"https://api.github.com/repos/Yelp/paasta/forks","keys_url":"https://api.github.com/repos/Yelp/paasta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/paasta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/paasta/teams","hooks_url":"https://api.github.com/repos/Yelp/paasta/hooks","issue_events_url":"https://api.github.com/repos/Yelp/paasta/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/paasta/events","assignees_url":"https://api.github.com/repos/Yelp/paasta/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/paasta/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/paasta/tags","blobs_url":"https://api.github.com/repos/Yelp/paasta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/paasta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/paasta/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/paasta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/paasta/languages","stargazers_url":"https://api.github.com/repos/Yelp/paasta/stargazers","contributors_url":"https://api.github.com/repos/Yelp/paasta/contributors","subscribers_url":"https://api.github.com/repos/Yelp/paasta/subscribers","subscription_url":"https://api.github.com/repos/Yelp/paasta/subscription","commits_url":"https://api.github.com/repos/Yelp/paasta/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/paasta/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/paasta/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/paasta/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/paasta/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/paasta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/paasta/merges","archive_url":"https://api.github.com/repos/Yelp/paasta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/paasta/downloads","issues_url":"https://api.github.com/repos/Yelp/paasta/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/paasta/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/paasta/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/paasta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/paasta/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/paasta/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/paasta/deployments","created_at":"2015-10-26T21:35:53Z","updated_at":"2016-03-09T01:09:49Z","pushed_at":"2016-03-09T17:33:03Z","git_url":"git://github.com/Yelp/paasta.git","ssh_url":"git@github.com:Yelp/paasta.git","clone_url":"https://github.com/Yelp/paasta.git","svn_url":"https://github.com/Yelp/paasta","homepage":"","size":7243,"stargazers_count":758,"watchers_count":758,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":24,"forks":61,"open_issues":24,"watchers":758,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/308"},"html":{"href":"https://github.com/Yelp/paasta/pull/308"},"issue":{"href":"https://api.github.com/repos/Yelp/paasta/issues/308"},"comments":{"href":"https://api.github.com/repos/Yelp/paasta/issues/308/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/308/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/308/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/paasta/statuses/287c1d092551a3002f848d0ab5144ed65b9f4d86"}}}}