{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/8882","repository_url":"https://api.github.com/repos/highfidelity/hifi","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/8882/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/8882/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/8882/events","html_url":"https://github.com/highfidelity/hifi/pull/8882","id":184578112,"number":8882,"title":"Heartbeats need to happen while waiting for sandbox","user":{"login":"davidkelly","id":1072532,"avatar_url":"https://avatars.githubusercontent.com/u/1072532?v=3","gravatar_id":"","url":"https://api.github.com/users/davidkelly","html_url":"https://github.com/davidkelly","followers_url":"https://api.github.com/users/davidkelly/followers","following_url":"https://api.github.com/users/davidkelly/following{/other_user}","gists_url":"https://api.github.com/users/davidkelly/gists{/gist_id}","starred_url":"https://api.github.com/users/davidkelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidkelly/subscriptions","organizations_url":"https://api.github.com/users/davidkelly/orgs","repos_url":"https://api.github.com/users/davidkelly/repos","events_url":"https://api.github.com/users/davidkelly/events{/privacy}","received_events_url":"https://api.github.com/users/davidkelly/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-21T21:52:20Z","updated_at":"2016-10-21T22:06:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/8882","html_url":"https://github.com/highfidelity/hifi/pull/8882","diff_url":"https://github.com/highfidelity/hifi/pull/8882.diff","patch_url":"https://github.com/highfidelity/hifi/pull/8882.patch"},"body":"We can only know if sandbox is up by waiting for the http request to\r\nsucceed or fail.  In the common case (fail since it isn't up yet), we\r\nhave to wait until a connect timeout in http.  Seems that is a couple\r\nseconds, and in that time we really upset the deadlock watchdog thread\r\nsince it keeps a moving average of heartbeat times.\r\n\r\nSimple solution, updateHeartbeat while waiting, and right before we\r\nstart.\r\n\r\n\r\n# Test Plan\r\n(1) start interface.  Just interface.  You should not see a constant stream of deadlock warnings in the logs of the form:\r\n`[10/21 09:50:33] [DEBUG] [hifi.interface.deadlock] DEADLOCK WATCHDOG WARNING: lastHeartbeatAge: 4001673 elapsedMovingAverage: 0 PREVIOUS maxElapsed: 3001433 NEW maxElapsed: 4001673 ** NEW MAX ELAPSED ** maxElapsedAverage: 0 samples: 0\r\n...`\r\n(2) do the same, but have sandbox started (perhaps run from steam by copying interface.exe over there).  You should observe happy logs as above.\r\n(3) 🍻 "},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/255476899","html_url":"https://github.com/highfidelity/hifi/pull/8882#issuecomment-255476899","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/8882","id":255476899,"user":{"login":"hifi-gustavo","id":4554450,"avatar_url":"https://avatars.githubusercontent.com/u/4554450?v=3","gravatar_id":"","url":"https://api.github.com/users/hifi-gustavo","html_url":"https://github.com/hifi-gustavo","followers_url":"https://api.github.com/users/hifi-gustavo/followers","following_url":"https://api.github.com/users/hifi-gustavo/following{/other_user}","gists_url":"https://api.github.com/users/hifi-gustavo/gists{/gist_id}","starred_url":"https://api.github.com/users/hifi-gustavo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hifi-gustavo/subscriptions","organizations_url":"https://api.github.com/users/hifi-gustavo/orgs","repos_url":"https://api.github.com/users/hifi-gustavo/repos","events_url":"https://api.github.com/users/hifi-gustavo/events{/privacy}","received_events_url":"https://api.github.com/users/hifi-gustavo/received_events","type":"User","site_admin":false},"created_at":"2016-10-21T22:06:48Z","updated_at":"2016-10-21T22:06:48Z","body":"Build console output for commit: aa31d3d8cc4fae27d51d2d1a7270ed356c18ced8 available at: https://gist.github.com/71145dbc09d17ff3c7625390fd340361<br/><br/>Installers available for download at: <br/>Windows: http://cachefly.highfidelity.com/HighFidelity-Beta-PR8882-aa31d3d.exe<br/>OS X: http://cachefly.highfidelity.com/HighFidelity-Beta-PR8882-aa31d3d.dmg"}}
{"actor":{"display_login":"hifi-gustavo"}}