{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-ntp-client/pulls/comments/90608107","pull_request_review_id":11126432,"id":90608107,"diff_hunk":"@@ -90,20 +90,12 @@ def raw\n \n   private\n \n-    def fix_keys\n-      fix_collection_keys(data.data)\n-      data.data.each do |entry|\n-        if entry[:value].is_a?(AugeasTreeValue)\n-          fix_collection_keys(entry[:value].tree.data)\n-        end\n-      end\n-    end\n-\n-    def fix_collection_keys(entries)\n-      entries.each do |entry|\n+    def fix_keys(tree)\n+      tree.data.each do |entry|\n         if COLLECTION_KEYS.include?(entry[:key])\n-          entry[:key] += \"[]\" unless entry[:key] =~ /.*\\[\\]$/\n+          entry[:key] << \"[]\" unless entry[:key].end_with?(\"[]\")","path":"src/lib/cfa/ntp_conf.rb","position":null,"original_position":28,"commit_id":"d89a9bd1d6607fa4bfda68eccbc850597e5cee85","original_commit_id":"c3119b60b1ae0d1adebcea61c33482e6b89dc3b3","user":{"login":"joseivanlopez","id":1112304,"avatar_url":"https://avatars.githubusercontent.com/u/1112304?v=3","gravatar_id":"","url":"https://api.github.com/users/joseivanlopez","html_url":"https://github.com/joseivanlopez","followers_url":"https://api.github.com/users/joseivanlopez/followers","following_url":"https://api.github.com/users/joseivanlopez/following{/other_user}","gists_url":"https://api.github.com/users/joseivanlopez/gists{/gist_id}","starred_url":"https://api.github.com/users/joseivanlopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseivanlopez/subscriptions","organizations_url":"https://api.github.com/users/joseivanlopez/orgs","repos_url":"https://api.github.com/users/joseivanlopez/repos","events_url":"https://api.github.com/users/joseivanlopez/events{/privacy}","received_events_url":"https://api.github.com/users/joseivanlopez/received_events","type":"User","site_admin":false},"body":"Yes, your are right. I correct it.","created_at":"2016-12-02T09:12:58Z","updated_at":"2016-12-02T09:12:58Z","html_url":"https://github.com/yast/yast-ntp-client/pull/65#discussion_r90608107","pull_request_url":"https://api.github.com/repos/yast/yast-ntp-client/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-ntp-client/pulls/comments/90608107"},"html":{"href":"https://github.com/yast/yast-ntp-client/pull/65#discussion_r90608107"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-ntp-client/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-ntp-client/pulls/65","id":95486402,"html_url":"https://github.com/yast/yast-ntp-client/pull/65","diff_url":"https://github.com/yast/yast-ntp-client/pull/65.diff","patch_url":"https://github.com/yast/yast-ntp-client/pull/65.patch","issue_url":"https://api.github.com/repos/yast/yast-ntp-client/issues/65","number":65,"state":"open","locked":false,"title":"CFA model for ntp conf WIP","user":{"login":"joseivanlopez","id":1112304,"avatar_url":"https://avatars.githubusercontent.com/u/1112304?v=3","gravatar_id":"","url":"https://api.github.com/users/joseivanlopez","html_url":"https://github.com/joseivanlopez","followers_url":"https://api.github.com/users/joseivanlopez/followers","following_url":"https://api.github.com/users/joseivanlopez/following{/other_user}","gists_url":"https://api.github.com/users/joseivanlopez/gists{/gist_id}","starred_url":"https://api.github.com/users/joseivanlopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseivanlopez/subscriptions","organizations_url":"https://api.github.com/users/joseivanlopez/orgs","repos_url":"https://api.github.com/users/joseivanlopez/repos","events_url":"https://api.github.com/users/joseivanlopez/events{/privacy}","received_events_url":"https://api.github.com/users/joseivanlopez/received_events","type":"User","site_admin":false},"body":"CFA model for ntp conf file","created_at":"2016-11-28T12:03:48Z","updated_at":"2016-12-02T09:12:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71a822f9126e1d7f51f9ff76e332e812d2f42456","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-ntp-client/pulls/65/commits","review_comments_url":"https://api.github.com/repos/yast/yast-ntp-client/pulls/65/comments","review_comment_url":"https://api.github.com/repos/yast/yast-ntp-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-ntp-client/issues/65/comments","statuses_url":"https://api.github.com/repos/yast/yast-ntp-client/statuses/d89a9bd1d6607fa4bfda68eccbc850597e5cee85","head":{"label":"joseivanlopez:cfa","ref":"cfa","sha":"d89a9bd1d6607fa4bfda68eccbc850597e5cee85","user":{"login":"joseivanlopez","id":1112304,"avatar_url":"https://avatars.githubusercontent.com/u/1112304?v=3","gravatar_id":"","url":"https://api.github.com/users/joseivanlopez","html_url":"https://github.com/joseivanlopez","followers_url":"https://api.github.com/users/joseivanlopez/followers","following_url":"https://api.github.com/users/joseivanlopez/following{/other_user}","gists_url":"https://api.github.com/users/joseivanlopez/gists{/gist_id}","starred_url":"https://api.github.com/users/joseivanlopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseivanlopez/subscriptions","organizations_url":"https://api.github.com/users/joseivanlopez/orgs","repos_url":"https://api.github.com/users/joseivanlopez/repos","events_url":"https://api.github.com/users/joseivanlopez/events{/privacy}","received_events_url":"https://api.github.com/users/joseivanlopez/received_events","type":"User","site_admin":false},"repo":{"id":74682965,"name":"yast-ntp-client","full_name":"joseivanlopez/yast-ntp-client","owner":{"login":"joseivanlopez","id":1112304,"avatar_url":"https://avatars.githubusercontent.com/u/1112304?v=3","gravatar_id":"","url":"https://api.github.com/users/joseivanlopez","html_url":"https://github.com/joseivanlopez","followers_url":"https://api.github.com/users/joseivanlopez/followers","following_url":"https://api.github.com/users/joseivanlopez/following{/other_user}","gists_url":"https://api.github.com/users/joseivanlopez/gists{/gist_id}","starred_url":"https://api.github.com/users/joseivanlopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseivanlopez/subscriptions","organizations_url":"https://api.github.com/users/joseivanlopez/orgs","repos_url":"https://api.github.com/users/joseivanlopez/repos","events_url":"https://api.github.com/users/joseivanlopez/events{/privacy}","received_events_url":"https://api.github.com/users/joseivanlopez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joseivanlopez/yast-ntp-client","description":"YaST module ntp-client","fork":true,"url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client","forks_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/forks","keys_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/teams","hooks_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/hooks","issue_events_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/issues/events{/number}","events_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/events","assignees_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/assignees{/user}","branches_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/branches{/branch}","tags_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/tags","blobs_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/languages","stargazers_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/stargazers","contributors_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/contributors","subscribers_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/subscribers","subscription_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/subscription","commits_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/contents/{+path}","compare_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/merges","archive_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/downloads","issues_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/issues{/number}","pulls_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/labels{/name}","releases_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/releases{/id}","deployments_url":"https://api.github.com/repos/joseivanlopez/yast-ntp-client/deployments","created_at":"2016-11-24T15:00:52Z","updated_at":"2016-11-24T15:00:54Z","pushed_at":"2016-12-01T21:43:26Z","git_url":"git://github.com/joseivanlopez/yast-ntp-client.git","ssh_url":"git@github.com:joseivanlopez/yast-ntp-client.git","clone_url":"https://github.com/joseivanlopez/yast-ntp-client.git","svn_url":"https://github.com/joseivanlopez/yast-ntp-client","homepage":"http://en.opensuse.org/Portal:YaST","size":955,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"a468d0fff60d32653d4ee72ea0ee4060afc49b2c","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368165,"name":"yast-ntp-client","full_name":"yast/yast-ntp-client","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-ntp-client","description":"YaST module ntp-client","fork":false,"url":"https://api.github.com/repos/yast/yast-ntp-client","forks_url":"https://api.github.com/repos/yast/yast-ntp-client/forks","keys_url":"https://api.github.com/repos/yast/yast-ntp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-ntp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-ntp-client/teams","hooks_url":"https://api.github.com/repos/yast/yast-ntp-client/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-ntp-client/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-ntp-client/events","assignees_url":"https://api.github.com/repos/yast/yast-ntp-client/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-ntp-client/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-ntp-client/tags","blobs_url":"https://api.github.com/repos/yast/yast-ntp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-ntp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-ntp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-ntp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-ntp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-ntp-client/languages","stargazers_url":"https://api.github.com/repos/yast/yast-ntp-client/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-ntp-client/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-ntp-client/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-ntp-client/subscription","commits_url":"https://api.github.com/repos/yast/yast-ntp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-ntp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-ntp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-ntp-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-ntp-client/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-ntp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-ntp-client/merges","archive_url":"https://api.github.com/repos/yast/yast-ntp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-ntp-client/downloads","issues_url":"https://api.github.com/repos/yast/yast-ntp-client/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-ntp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-ntp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-ntp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-ntp-client/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-ntp-client/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-ntp-client/deployments","created_at":"2012-05-18T10:25:00Z","updated_at":"2016-11-24T15:00:32Z","pushed_at":"2016-12-01T21:43:26Z","git_url":"git://github.com/yast/yast-ntp-client.git","ssh_url":"git@github.com:yast/yast-ntp-client.git","clone_url":"https://github.com/yast/yast-ntp-client.git","svn_url":"https://github.com/yast/yast-ntp-client","homepage":"http://en.opensuse.org/Portal:YaST","size":1256,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":1,"forks":14,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-ntp-client/pulls/65"},"html":{"href":"https://github.com/yast/yast-ntp-client/pull/65"},"issue":{"href":"https://api.github.com/repos/yast/yast-ntp-client/issues/65"},"comments":{"href":"https://api.github.com/repos/yast/yast-ntp-client/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-ntp-client/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-ntp-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-ntp-client/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-ntp-client/statuses/d89a9bd1d6607fa4bfda68eccbc850597e5cee85"}}}}
{"actor":{"display_login":"joseivanlopez"}}