{"action":"created","issue":{"url":"https://api.github.com/repos/PrismLibrary/Prism/issues/817","repository_url":"https://api.github.com/repos/PrismLibrary/Prism","labels_url":"https://api.github.com/repos/PrismLibrary/Prism/issues/817/labels{/name}","comments_url":"https://api.github.com/repos/PrismLibrary/Prism/issues/817/comments","events_url":"https://api.github.com/repos/PrismLibrary/Prism/issues/817/events","html_url":"https://github.com/PrismLibrary/Prism/issues/817","id":184723246,"number":817,"title":"OnPropertyChanged without a parameter name should fire the event with an empty string","user":{"login":"hardcodet","id":873009,"avatar_url":"https://avatars.githubusercontent.com/u/873009?v=3","gravatar_id":"","url":"https://api.github.com/users/hardcodet","html_url":"https://github.com/hardcodet","followers_url":"https://api.github.com/users/hardcodet/followers","following_url":"https://api.github.com/users/hardcodet/following{/other_user}","gists_url":"https://api.github.com/users/hardcodet/gists{/gist_id}","starred_url":"https://api.github.com/users/hardcodet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardcodet/subscriptions","organizations_url":"https://api.github.com/users/hardcodet/orgs","repos_url":"https://api.github.com/users/hardcodet/repos","events_url":"https://api.github.com/users/hardcodet/events{/privacy}","received_events_url":"https://api.github.com/users/hardcodet/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-10-23T23:21:24Z","updated_at":"2016-10-24T15:41:07Z","closed_at":"2016-10-24T15:09:46Z","body":"### Package info\r\n\r\n- Platform: Xamarin Forms -> Android\r\n- Prism version: 6.2.0\r\n- Xamarin version (if applicable): Latest\r\n\r\n### Repro steps\r\n\r\nI want to refresh all bindings on my view firing a single property change event. The VM base class gives me the OnPropertyChanged method with a default parameter (value == null) for that.\r\n\r\n                Model = ride;\r\n                TimeWindowModel = new TimeWindowModel(ride.DepartureTimeWindow);\r\n                OnPropertyChanged();\r\n\r\nThis doesn't do anything though, because the property changed event seems to require an empty string. I can of course submit the string as a parameter. This works:\r\n\r\n                Model = ride;\r\n                TimeWindowModel = new TimeWindowModel(ride.DepartureTimeWindow);\r\n                OnPropertyChanged(String.Empty);\r\n\r\nHowever, R# (rightfully) complains here, because you attributed the property name parameter with the CallerMemberName attribute.\r\n\r\nSuggested fix: Make the default parameter value to an empty string, or fire the event with an empty string if your receive a null parameter. Using null doesn't do anything."},"comment":{"url":"https://api.github.com/repos/PrismLibrary/Prism/issues/comments/255777998","html_url":"https://github.com/PrismLibrary/Prism/issues/817#issuecomment-255777998","issue_url":"https://api.github.com/repos/PrismLibrary/Prism/issues/817","id":255777998,"user":{"login":"brianlagunas","id":835562,"avatar_url":"https://avatars.githubusercontent.com/u/835562?v=3","gravatar_id":"","url":"https://api.github.com/users/brianlagunas","html_url":"https://github.com/brianlagunas","followers_url":"https://api.github.com/users/brianlagunas/followers","following_url":"https://api.github.com/users/brianlagunas/following{/other_user}","gists_url":"https://api.github.com/users/brianlagunas/gists{/gist_id}","starred_url":"https://api.github.com/users/brianlagunas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianlagunas/subscriptions","organizations_url":"https://api.github.com/users/brianlagunas/orgs","repos_url":"https://api.github.com/users/brianlagunas/repos","events_url":"https://api.github.com/users/brianlagunas/events{/privacy}","received_events_url":"https://api.github.com/users/brianlagunas/received_events","type":"User","site_admin":false},"created_at":"2016-10-24T15:41:07Z","updated_at":"2016-10-24T15:41:07Z","body":"> R# rightfully complains about the call with an explicit value\r\n\r\nI disagree with this statement.  R# has this behavior completely wrong.  The reason a method has the CallerMemberNameAttribute is to pass default caller information and this signature requires an optional parameter.  This optional parameter allows you to override the caller information, which is to be an expected capability of a method with this attribute."}}
{"actor":{"display_login":"brianlagunas"}}