{"action":"created","issue":{"url":"https://api.github.com/repos/uWebSockets/uWebSockets/issues/229","repository_url":"https://api.github.com/repos/uWebSockets/uWebSockets","labels_url":"https://api.github.com/repos/uWebSockets/uWebSockets/issues/229/labels{/name}","comments_url":"https://api.github.com/repos/uWebSockets/uWebSockets/issues/229/comments","events_url":"https://api.github.com/repos/uWebSockets/uWebSockets/issues/229/events","html_url":"https://github.com/uWebSockets/uWebSockets/issues/229","id":173935907,"number":229,"title":"memory leak in Server::acceptHandler ?","user":{"login":"KrishnaPG","id":4610831,"avatar_url":"https://avatars.githubusercontent.com/u/4610831?v=3","gravatar_id":"","url":"https://api.github.com/users/KrishnaPG","html_url":"https://github.com/KrishnaPG","followers_url":"https://api.github.com/users/KrishnaPG/followers","following_url":"https://api.github.com/users/KrishnaPG/following{/other_user}","gists_url":"https://api.github.com/users/KrishnaPG/gists{/gist_id}","starred_url":"https://api.github.com/users/KrishnaPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrishnaPG/subscriptions","organizations_url":"https://api.github.com/users/KrishnaPG/orgs","repos_url":"https://api.github.com/users/KrishnaPG/repos","events_url":"https://api.github.com/users/KrishnaPG/events{/privacy}","received_events_url":"https://api.github.com/users/KrishnaPG/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-30T05:55:31Z","updated_at":"2016-08-30T14:06:40Z","closed_at":null,"body":"At https://github.com/uWebSockets/uWebSockets/blob/master/src/Server.cpp#L58 ?\r\n\r\nThe ` new HTTPSocket` is potentially leaking the object"},"comment":{"url":"https://api.github.com/repos/uWebSockets/uWebSockets/issues/comments/243450223","html_url":"https://github.com/uWebSockets/uWebSockets/issues/229#issuecomment-243450223","issue_url":"https://api.github.com/repos/uWebSockets/uWebSockets/issues/229","id":243450223,"user":{"login":"KrishnaPG","id":4610831,"avatar_url":"https://avatars.githubusercontent.com/u/4610831?v=3","gravatar_id":"","url":"https://api.github.com/users/KrishnaPG","html_url":"https://github.com/KrishnaPG","followers_url":"https://api.github.com/users/KrishnaPG/followers","following_url":"https://api.github.com/users/KrishnaPG/following{/other_user}","gists_url":"https://api.github.com/users/KrishnaPG/gists{/gist_id}","starred_url":"https://api.github.com/users/KrishnaPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrishnaPG/subscriptions","organizations_url":"https://api.github.com/users/KrishnaPG/orgs","repos_url":"https://api.github.com/users/KrishnaPG/repos","events_url":"https://api.github.com/users/KrishnaPG/events{/privacy}","received_events_url":"https://api.github.com/users/KrishnaPG/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T14:06:40Z","updated_at":"2016-08-30T14:06:40Z","body":"Another quick question: [this line](https://github.com/uWebSockets/uWebSockets/blob/master/src/HTTPSocket.cpp#L118) has below code\r\n````\r\nlength = recv(fd, httpData->server->recvBuffer, Server::LARGE_BUFFER_SIZE, 0);\r\n````\r\nGiven that there is only sever object and multiple `HTTPSocket` client objects doing the `recv` at the same time, will this not result in multiple receives trying to read into same buffer?"}}
{"actor":{"display_login":"KrishnaPG"}}