{"action":"created","comment":{"url":"https://api.github.com/repos/babel/babylon/pulls/comments/82959264","pull_request_review_id":3829001,"id":82959264,"diff_hunk":"@@ -1052,9 +1055,10 @@ export default function (instance) {\n   instance.extend(\"parseObjPropValue\", function (inner) {\n     return function (prop) {\n       if (prop.variance) {\n-        this.unexpected(prop.variance.start);\n+        this.unexpected(prop.start);","path":"src/plugins/flow.js","position":null,"original_position":79,"commit_id":"0651e0a029d6eff234fc1d7ae9e0dcabfea333f2","original_commit_id":"0651e0a029d6eff234fc1d7ae9e0dcabfea333f2","user":{"login":"danez","id":231804,"avatar_url":"https://avatars.githubusercontent.com/u/231804?v=3","gravatar_id":"","url":"https://api.github.com/users/danez","html_url":"https://github.com/danez","followers_url":"https://api.github.com/users/danez/followers","following_url":"https://api.github.com/users/danez/following{/other_user}","gists_url":"https://api.github.com/users/danez/gists{/gist_id}","starred_url":"https://api.github.com/users/danez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danez/subscriptions","organizations_url":"https://api.github.com/users/danez/orgs","repos_url":"https://api.github.com/users/danez/repos","events_url":"https://api.github.com/users/danez/events{/privacy}","received_events_url":"https://api.github.com/users/danez/received_events","type":"User","site_admin":false},"body":"Should this be `prop.variancePos`","created_at":"2016-10-12T08:40:05Z","updated_at":"2016-10-12T08:42:49Z","html_url":"https://github.com/babel/babylon/pull/161#discussion_r82959264","pull_request_url":"https://api.github.com/repos/babel/babylon/pulls/161","_links":{"self":{"href":"https://api.github.com/repos/babel/babylon/pulls/comments/82959264"},"html":{"href":"https://github.com/babel/babylon/pull/161#discussion_r82959264"},"pull_request":{"href":"https://api.github.com/repos/babel/babylon/pulls/161"}}},"pull_request":{"url":"https://api.github.com/repos/babel/babylon/pulls/161","id":88524699,"html_url":"https://github.com/babel/babylon/pull/161","diff_url":"https://github.com/babel/babylon/pull/161.diff","patch_url":"https://github.com/babel/babylon/pull/161.patch","issue_url":"https://api.github.com/repos/babel/babylon/issues/161","number":161,"state":"open","locked":false,"title":"Property variance type annotations for Flow plugin","user":{"login":"samwgoldman","id":254842,"avatar_url":"https://avatars.githubusercontent.com/u/254842?v=3","gravatar_id":"","url":"https://api.github.com/users/samwgoldman","html_url":"https://github.com/samwgoldman","followers_url":"https://api.github.com/users/samwgoldman/followers","following_url":"https://api.github.com/users/samwgoldman/following{/other_user}","gists_url":"https://api.github.com/users/samwgoldman/gists{/gist_id}","starred_url":"https://api.github.com/users/samwgoldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samwgoldman/subscriptions","organizations_url":"https://api.github.com/users/samwgoldman/orgs","repos_url":"https://api.github.com/users/samwgoldman/repos","events_url":"https://api.github.com/users/samwgoldman/events{/privacy}","received_events_url":"https://api.github.com/users/samwgoldman/received_events","type":"User","site_admin":false},"body":"Non-method properties and indexers of object types, declare class, and\r\ninterfaces can be \"positive\" or \"negative.\" Class fields, but again not\r\nmethods, can also have variance.\r\n\r\nThis PR generalizes the variance annotations for type parameters into a\r\nnew node type, and reuses that node for those properties.\r\n\r\nThe code for object types is reused for interfaces and declare classes.\r\nThe changes there are straightfoward.\r\n\r\nThe code for class fields is reused for object literals, which do not\r\nsupport variance annotations (currently). This code is a bit sketchy,\r\nbecause we always parse variance annotations in the `parsePropertyName`\r\nextension, then error in a the subsequent parse phase for object\r\nliterals (`parseObjPropValue`) or class methods (`parseClassMethod`).","created_at":"2016-10-07T23:56:43Z","updated_at":"2016-10-12T08:42:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81ccfce7eecee41e66176ea266cf9cd82a5a4ceb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/babel/babylon/pulls/161/commits","review_comments_url":"https://api.github.com/repos/babel/babylon/pulls/161/comments","review_comment_url":"https://api.github.com/repos/babel/babylon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/babel/babylon/issues/161/comments","statuses_url":"https://api.github.com/repos/babel/babylon/statuses/0651e0a029d6eff234fc1d7ae9e0dcabfea333f2","head":{"label":"samwgoldman:property-variance","ref":"property-variance","sha":"0651e0a029d6eff234fc1d7ae9e0dcabfea333f2","user":{"login":"samwgoldman","id":254842,"avatar_url":"https://avatars.githubusercontent.com/u/254842?v=3","gravatar_id":"","url":"https://api.github.com/users/samwgoldman","html_url":"https://github.com/samwgoldman","followers_url":"https://api.github.com/users/samwgoldman/followers","following_url":"https://api.github.com/users/samwgoldman/following{/other_user}","gists_url":"https://api.github.com/users/samwgoldman/gists{/gist_id}","starred_url":"https://api.github.com/users/samwgoldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samwgoldman/subscriptions","organizations_url":"https://api.github.com/users/samwgoldman/orgs","repos_url":"https://api.github.com/users/samwgoldman/repos","events_url":"https://api.github.com/users/samwgoldman/events{/privacy}","received_events_url":"https://api.github.com/users/samwgoldman/received_events","type":"User","site_admin":false},"repo":{"id":70290825,"name":"babylon","full_name":"samwgoldman/babylon","owner":{"login":"samwgoldman","id":254842,"avatar_url":"https://avatars.githubusercontent.com/u/254842?v=3","gravatar_id":"","url":"https://api.github.com/users/samwgoldman","html_url":"https://github.com/samwgoldman","followers_url":"https://api.github.com/users/samwgoldman/followers","following_url":"https://api.github.com/users/samwgoldman/following{/other_user}","gists_url":"https://api.github.com/users/samwgoldman/gists{/gist_id}","starred_url":"https://api.github.com/users/samwgoldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samwgoldman/subscriptions","organizations_url":"https://api.github.com/users/samwgoldman/orgs","repos_url":"https://api.github.com/users/samwgoldman/repos","events_url":"https://api.github.com/users/samwgoldman/events{/privacy}","received_events_url":"https://api.github.com/users/samwgoldman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samwgoldman/babylon","description":":page_with_curl: A JavaScript parser","fork":true,"url":"https://api.github.com/repos/samwgoldman/babylon","forks_url":"https://api.github.com/repos/samwgoldman/babylon/forks","keys_url":"https://api.github.com/repos/samwgoldman/babylon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samwgoldman/babylon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samwgoldman/babylon/teams","hooks_url":"https://api.github.com/repos/samwgoldman/babylon/hooks","issue_events_url":"https://api.github.com/repos/samwgoldman/babylon/issues/events{/number}","events_url":"https://api.github.com/repos/samwgoldman/babylon/events","assignees_url":"https://api.github.com/repos/samwgoldman/babylon/assignees{/user}","branches_url":"https://api.github.com/repos/samwgoldman/babylon/branches{/branch}","tags_url":"https://api.github.com/repos/samwgoldman/babylon/tags","blobs_url":"https://api.github.com/repos/samwgoldman/babylon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samwgoldman/babylon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samwgoldman/babylon/git/refs{/sha}","trees_url":"https://api.github.com/repos/samwgoldman/babylon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samwgoldman/babylon/statuses/{sha}","languages_url":"https://api.github.com/repos/samwgoldman/babylon/languages","stargazers_url":"https://api.github.com/repos/samwgoldman/babylon/stargazers","contributors_url":"https://api.github.com/repos/samwgoldman/babylon/contributors","subscribers_url":"https://api.github.com/repos/samwgoldman/babylon/subscribers","subscription_url":"https://api.github.com/repos/samwgoldman/babylon/subscription","commits_url":"https://api.github.com/repos/samwgoldman/babylon/commits{/sha}","git_commits_url":"https://api.github.com/repos/samwgoldman/babylon/git/commits{/sha}","comments_url":"https://api.github.com/repos/samwgoldman/babylon/comments{/number}","issue_comment_url":"https://api.github.com/repos/samwgoldman/babylon/issues/comments{/number}","contents_url":"https://api.github.com/repos/samwgoldman/babylon/contents/{+path}","compare_url":"https://api.github.com/repos/samwgoldman/babylon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samwgoldman/babylon/merges","archive_url":"https://api.github.com/repos/samwgoldman/babylon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samwgoldman/babylon/downloads","issues_url":"https://api.github.com/repos/samwgoldman/babylon/issues{/number}","pulls_url":"https://api.github.com/repos/samwgoldman/babylon/pulls{/number}","milestones_url":"https://api.github.com/repos/samwgoldman/babylon/milestones{/number}","notifications_url":"https://api.github.com/repos/samwgoldman/babylon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samwgoldman/babylon/labels{/name}","releases_url":"https://api.github.com/repos/samwgoldman/babylon/releases{/id}","deployments_url":"https://api.github.com/repos/samwgoldman/babylon/deployments","created_at":"2016-10-07T23:55:49Z","updated_at":"2016-10-07T23:55:51Z","pushed_at":"2016-10-11T00:07:21Z","git_url":"git://github.com/samwgoldman/babylon.git","ssh_url":"git@github.com:samwgoldman/babylon.git","clone_url":"https://github.com/samwgoldman/babylon.git","svn_url":"https://github.com/samwgoldman/babylon","homepage":"","size":6644,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"babel:master","ref":"master","sha":"2697bfd8204f4a380bb9961e45f28ff6d1fbd220","user":{"login":"babel","id":9637642,"avatar_url":"https://avatars.githubusercontent.com/u/9637642?v=3","gravatar_id":"","url":"https://api.github.com/users/babel","html_url":"https://github.com/babel","followers_url":"https://api.github.com/users/babel/followers","following_url":"https://api.github.com/users/babel/following{/other_user}","gists_url":"https://api.github.com/users/babel/gists{/gist_id}","starred_url":"https://api.github.com/users/babel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babel/subscriptions","organizations_url":"https://api.github.com/users/babel/orgs","repos_url":"https://api.github.com/users/babel/repos","events_url":"https://api.github.com/users/babel/events{/privacy}","received_events_url":"https://api.github.com/users/babel/received_events","type":"Organization","site_admin":false},"repo":{"id":53558755,"name":"babylon","full_name":"babel/babylon","owner":{"login":"babel","id":9637642,"avatar_url":"https://avatars.githubusercontent.com/u/9637642?v=3","gravatar_id":"","url":"https://api.github.com/users/babel","html_url":"https://github.com/babel","followers_url":"https://api.github.com/users/babel/followers","following_url":"https://api.github.com/users/babel/following{/other_user}","gists_url":"https://api.github.com/users/babel/gists{/gist_id}","starred_url":"https://api.github.com/users/babel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babel/subscriptions","organizations_url":"https://api.github.com/users/babel/orgs","repos_url":"https://api.github.com/users/babel/repos","events_url":"https://api.github.com/users/babel/events{/privacy}","received_events_url":"https://api.github.com/users/babel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/babel/babylon","description":":page_with_curl: A JavaScript parser","fork":false,"url":"https://api.github.com/repos/babel/babylon","forks_url":"https://api.github.com/repos/babel/babylon/forks","keys_url":"https://api.github.com/repos/babel/babylon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/babel/babylon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/babel/babylon/teams","hooks_url":"https://api.github.com/repos/babel/babylon/hooks","issue_events_url":"https://api.github.com/repos/babel/babylon/issues/events{/number}","events_url":"https://api.github.com/repos/babel/babylon/events","assignees_url":"https://api.github.com/repos/babel/babylon/assignees{/user}","branches_url":"https://api.github.com/repos/babel/babylon/branches{/branch}","tags_url":"https://api.github.com/repos/babel/babylon/tags","blobs_url":"https://api.github.com/repos/babel/babylon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/babel/babylon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/babel/babylon/git/refs{/sha}","trees_url":"https://api.github.com/repos/babel/babylon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/babel/babylon/statuses/{sha}","languages_url":"https://api.github.com/repos/babel/babylon/languages","stargazers_url":"https://api.github.com/repos/babel/babylon/stargazers","contributors_url":"https://api.github.com/repos/babel/babylon/contributors","subscribers_url":"https://api.github.com/repos/babel/babylon/subscribers","subscription_url":"https://api.github.com/repos/babel/babylon/subscription","commits_url":"https://api.github.com/repos/babel/babylon/commits{/sha}","git_commits_url":"https://api.github.com/repos/babel/babylon/git/commits{/sha}","comments_url":"https://api.github.com/repos/babel/babylon/comments{/number}","issue_comment_url":"https://api.github.com/repos/babel/babylon/issues/comments{/number}","contents_url":"https://api.github.com/repos/babel/babylon/contents/{+path}","compare_url":"https://api.github.com/repos/babel/babylon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/babel/babylon/merges","archive_url":"https://api.github.com/repos/babel/babylon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/babel/babylon/downloads","issues_url":"https://api.github.com/repos/babel/babylon/issues{/number}","pulls_url":"https://api.github.com/repos/babel/babylon/pulls{/number}","milestones_url":"https://api.github.com/repos/babel/babylon/milestones{/number}","notifications_url":"https://api.github.com/repos/babel/babylon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/babel/babylon/labels{/name}","releases_url":"https://api.github.com/repos/babel/babylon/releases{/id}","deployments_url":"https://api.github.com/repos/babel/babylon/deployments","created_at":"2016-03-10T05:49:43Z","updated_at":"2016-10-11T13:41:11Z","pushed_at":"2016-10-11T02:37:45Z","git_url":"git://github.com/babel/babylon.git","ssh_url":"git@github.com:babel/babylon.git","clone_url":"https://github.com/babel/babylon.git","svn_url":"https://github.com/babel/babylon","homepage":"","size":7254,"stargazers_count":495,"watchers_count":495,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":34,"forks":60,"open_issues":34,"watchers":495,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/babel/babylon/pulls/161"},"html":{"href":"https://github.com/babel/babylon/pull/161"},"issue":{"href":"https://api.github.com/repos/babel/babylon/issues/161"},"comments":{"href":"https://api.github.com/repos/babel/babylon/issues/161/comments"},"review_comments":{"href":"https://api.github.com/repos/babel/babylon/pulls/161/comments"},"review_comment":{"href":"https://api.github.com/repos/babel/babylon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/babel/babylon/pulls/161/commits"},"statuses":{"href":"https://api.github.com/repos/babel/babylon/statuses/0651e0a029d6eff234fc1d7ae9e0dcabfea333f2"}}}}
{"actor":{"display_login":"danez"}}