{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/71040326","id":71040326,"diff_hunk":"@@ -49,6 +49,44 @@ def self.deliver_queue(args, options = {})\n     end\n   end\n \n+  def self.deliver_synchronous(args)\n+    log_header = \"MIQ(#{name}.deliver_synchronous)\"","path":"lib/miq_automation_engine/engine/miq_ae_engine.rb","position":5,"original_position":5,"commit_id":"50ca7cf48a556a69ac6d3b7299800b2609affc48","original_commit_id":"50ca7cf48a556a69ac6d3b7299800b2609affc48","user":{"login":"gmcculloug","id":2591569,"avatar_url":"https://avatars.githubusercontent.com/u/2591569?v=3","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false},"body":"Remove `log_header` and use `_log` instead of `$log`","created_at":"2016-07-15T21:01:29Z","updated_at":"2016-07-15T21:01:29Z","html_url":"https://github.com/ManageIQ/manageiq/pull/9860#discussion_r71040326","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9860","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/71040326"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/9860#discussion_r71040326"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9860"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9860","id":77672476,"html_url":"https://github.com/ManageIQ/manageiq/pull/9860","diff_url":"https://github.com/ManageIQ/manageiq/pull/9860.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/9860.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9860","number":9860,"state":"open","locked":false,"title":"Send Dialog field requests to Automate via the Queue","user":{"login":"mkanoor","id":6452699,"avatar_url":"https://avatars.githubusercontent.com/u/6452699?v=3","gravatar_id":"","url":"https://api.github.com/users/mkanoor","html_url":"https://github.com/mkanoor","followers_url":"https://api.github.com/users/mkanoor/followers","following_url":"https://api.github.com/users/mkanoor/following{/other_user}","gists_url":"https://api.github.com/users/mkanoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mkanoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkanoor/subscriptions","organizations_url":"https://api.github.com/users/mkanoor/orgs","repos_url":"https://api.github.com/users/mkanoor/repos","events_url":"https://api.github.com/users/mkanoor/events{/privacy}","received_events_url":"https://api.github.com/users/mkanoor/received_events","type":"User","site_admin":false},"body":"Purpose or Intent\r\n-----------------\r\n> With Rails 5 and PUMA we are getting concurrent requests into the Automate engine from Dialogs with dynamic fields. Automate engine uses DRb to launch methods, with concurrent requests we could get a race condition where one method is starting and the other one is ending. Since DRb uses class methods to start_service and stop_service, we might terminate incorrect methods causing \"Connection Refused\" ECONNREFUSED errors.\r\nTo resolve this issue instead of running concurrent requests into the same process we are routing the Automate calls via the Queue. This will cause the performance issues since it is not a direct call since each request would be run in a separate process. \r\n\r\n\r\nLinks\r\n-----\r\n> * https://bugzilla.redhat.com/show_bug.cgi?id=1354054\r\n> * http://talk.manageiq.org/t/errno-econnrefused-connection-refused-with-multiple-refresh-listeners/1392/4\r\n\r\n\r\nSteps for Testing/QA\r\n--------------------\r\n> Difficult to create the race condition\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1354054\r\n\r\nInstead of directly calling Automate from Dialogs send the\r\nrequest over the queue.","created_at":"2016-07-15T20:19:42Z","updated_at":"2016-07-15T21:01:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab0269349d95453f21e666d48b5f06708280ba30","assignee":{"login":"gmcculloug","id":2591569,"avatar_url":"https://avatars.githubusercontent.com/u/2591569?v=3","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false},"assignees":[{"login":"gmcculloug","id":2591569,"avatar_url":"https://avatars.githubusercontent.com/u/2591569?v=3","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9860/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9860/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9860/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/50ca7cf48a556a69ac6d3b7299800b2609affc48","head":{"label":"mkanoor:bugzilla_1354054","ref":"bugzilla_1354054","sha":"50ca7cf48a556a69ac6d3b7299800b2609affc48","user":{"login":"mkanoor","id":6452699,"avatar_url":"https://avatars.githubusercontent.com/u/6452699?v=3","gravatar_id":"","url":"https://api.github.com/users/mkanoor","html_url":"https://github.com/mkanoor","followers_url":"https://api.github.com/users/mkanoor/followers","following_url":"https://api.github.com/users/mkanoor/following{/other_user}","gists_url":"https://api.github.com/users/mkanoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mkanoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkanoor/subscriptions","organizations_url":"https://api.github.com/users/mkanoor/orgs","repos_url":"https://api.github.com/users/mkanoor/repos","events_url":"https://api.github.com/users/mkanoor/events{/privacy}","received_events_url":"https://api.github.com/users/mkanoor/received_events","type":"User","site_admin":false},"repo":{"id":20886443,"name":"manageiq","full_name":"mkanoor/manageiq","owner":{"login":"mkanoor","id":6452699,"avatar_url":"https://avatars.githubusercontent.com/u/6452699?v=3","gravatar_id":"","url":"https://api.github.com/users/mkanoor","html_url":"https://github.com/mkanoor","followers_url":"https://api.github.com/users/mkanoor/followers","following_url":"https://api.github.com/users/mkanoor/following{/other_user}","gists_url":"https://api.github.com/users/mkanoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mkanoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkanoor/subscriptions","organizations_url":"https://api.github.com/users/mkanoor/orgs","repos_url":"https://api.github.com/users/mkanoor/repos","events_url":"https://api.github.com/users/mkanoor/events{/privacy}","received_events_url":"https://api.github.com/users/mkanoor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkanoor/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/mkanoor/manageiq","forks_url":"https://api.github.com/repos/mkanoor/manageiq/forks","keys_url":"https://api.github.com/repos/mkanoor/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkanoor/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkanoor/manageiq/teams","hooks_url":"https://api.github.com/repos/mkanoor/manageiq/hooks","issue_events_url":"https://api.github.com/repos/mkanoor/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/mkanoor/manageiq/events","assignees_url":"https://api.github.com/repos/mkanoor/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/mkanoor/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/mkanoor/manageiq/tags","blobs_url":"https://api.github.com/repos/mkanoor/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkanoor/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkanoor/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkanoor/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkanoor/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/mkanoor/manageiq/languages","stargazers_url":"https://api.github.com/repos/mkanoor/manageiq/stargazers","contributors_url":"https://api.github.com/repos/mkanoor/manageiq/contributors","subscribers_url":"https://api.github.com/repos/mkanoor/manageiq/subscribers","subscription_url":"https://api.github.com/repos/mkanoor/manageiq/subscription","commits_url":"https://api.github.com/repos/mkanoor/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkanoor/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkanoor/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkanoor/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkanoor/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/mkanoor/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkanoor/manageiq/merges","archive_url":"https://api.github.com/repos/mkanoor/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkanoor/manageiq/downloads","issues_url":"https://api.github.com/repos/mkanoor/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/mkanoor/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/mkanoor/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/mkanoor/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkanoor/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/mkanoor/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/mkanoor/manageiq/deployments","created_at":"2014-06-16T13:48:03Z","updated_at":"2016-01-11T16:28:23Z","pushed_at":"2016-07-15T20:57:42Z","git_url":"git://github.com/mkanoor/manageiq.git","ssh_url":"git@github.com:mkanoor/manageiq.git","clone_url":"https://github.com/mkanoor/manageiq.git","svn_url":"https://github.com/mkanoor/manageiq","homepage":null,"size":135376,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"e8ffc03982c5a142c0ee24046a1e5035175b39a2","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-07-13T16:26:10Z","pushed_at":"2016-07-15T20:53:07Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":177233,"stargazers_count":299,"watchers_count":299,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":323,"mirror_url":null,"open_issues_count":736,"forks":323,"open_issues":736,"watchers":299,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9860"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/9860"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/9860"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/9860/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9860/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9860/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/50ca7cf48a556a69ac6d3b7299800b2609affc48"}}}}
{"actor":{"display_login":"gmcculloug"}}