{"action":"created","issue":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/290","repository_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/290/labels{/name}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/290/comments","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/290/events","html_url":"https://github.com/spring-cloud/spring-cloud-sleuth/issues/290","id":156885488,"number":290,"title":"Feign external url span details missing","user":{"login":"singram","id":337349,"avatar_url":"https://avatars.githubusercontent.com/u/337349?v=3","gravatar_id":"","url":"https://api.github.com/users/singram","html_url":"https://github.com/singram","followers_url":"https://api.github.com/users/singram/followers","following_url":"https://api.github.com/users/singram/following{/other_user}","gists_url":"https://api.github.com/users/singram/gists{/gist_id}","starred_url":"https://api.github.com/users/singram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singram/subscriptions","organizations_url":"https://api.github.com/users/singram/orgs","repos_url":"https://api.github.com/users/singram/repos","events_url":"https://api.github.com/users/singram/events{/privacy}","received_events_url":"https://api.github.com/users/singram/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-26T01:34:04Z","updated_at":"2016-05-26T10:48:43Z","closed_at":null,"body":"When using feign to call an external url.  eg.\r\n```\r\n@FeignClient(name = \"swapi-service\", url = \"http://swapi.co/api/\")\r\npublic interface SwapiService {\r\n  @RequestMapping(method = RequestMethod.GET, value = \"/people/{personId}\")\r\n  ResponseEntity<SwapiPerson> getPerson(@RequestHeader(value=\"User-Agent\", defaultValue=\"curl/7.45.0\") String userAgent, @PathVariable(\"personId\") long personId);\r\n}\r\n```\r\nDetails such as \r\n-   http.host\r\n-   http.method\r\n-   http.path\r\n-   http.url\r\n\r\nAre not captured on the span and visible in Zipkin, as shown in other examples such as those found here. http://brewery-zipkin-server.cfapps.io/traces/38efdb9a8861a00a?serviceName=brewing\r\n\r\nUsing\r\n- Spring-boot => 1.3.5.Release\r\n- Spring-cloud => Brixton.Release\r\n"},"comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/comments/221838806","html_url":"https://github.com/spring-cloud/spring-cloud-sleuth/issues/290#issuecomment-221838806","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/290","id":221838806,"user":{"login":"marcingrzejszczak","id":3297437,"avatar_url":"https://avatars.githubusercontent.com/u/3297437?v=3","gravatar_id":"","url":"https://api.github.com/users/marcingrzejszczak","html_url":"https://github.com/marcingrzejszczak","followers_url":"https://api.github.com/users/marcingrzejszczak/followers","following_url":"https://api.github.com/users/marcingrzejszczak/following{/other_user}","gists_url":"https://api.github.com/users/marcingrzejszczak/gists{/gist_id}","starred_url":"https://api.github.com/users/marcingrzejszczak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcingrzejszczak/subscriptions","organizations_url":"https://api.github.com/users/marcingrzejszczak/orgs","repos_url":"https://api.github.com/users/marcingrzejszczak/repos","events_url":"https://api.github.com/users/marcingrzejszczak/events{/privacy}","received_events_url":"https://api.github.com/users/marcingrzejszczak/received_events","type":"User","site_admin":false},"created_at":"2016-05-26T10:48:43Z","updated_at":"2016-05-26T10:48:43Z","body":"CC @adriancole - this is what we were discussing on Gitter. If we have both apps instrumented (client + server) then once the server side creates the span it adds the details. Whereas when we have a case where we call an external service then we lose those tag information."}}
{"actor":{"display_login":"marcingrzejszczak"}}