{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/9850","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/9850/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/9850/comments","events_url":"https://api.github.com/repos/servo/servo/issues/9850/events","html_url":"https://github.com/servo/servo/pull/9850","id":138033677,"number":9850,"title":"Set response.body Asynchronously In Fetch","user":{"login":"nikkisquared","id":7886109,"avatar_url":"https://avatars.githubusercontent.com/u/7886109?v=3","gravatar_id":"","url":"https://api.github.com/users/nikkisquared","html_url":"https://github.com/nikkisquared","followers_url":"https://api.github.com/users/nikkisquared/followers","following_url":"https://api.github.com/users/nikkisquared/following{/other_user}","gists_url":"https://api.github.com/users/nikkisquared/gists{/gist_id}","starred_url":"https://api.github.com/users/nikkisquared/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikkisquared/subscriptions","organizations_url":"https://api.github.com/users/nikkisquared/orgs","repos_url":"https://api.github.com/users/nikkisquared/repos","events_url":"https://api.github.com/users/nikkisquared/events{/privacy}","received_events_url":"https://api.github.com/users/nikkisquared/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2016-03-03T00:17:11Z","updated_at":"2016-03-07T22:27:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/9850","html_url":"https://github.com/servo/servo/pull/9850","diff_url":"https://github.com/servo/servo/pull/9850.diff","patch_url":"https://github.com/servo/servo/pull/9850.patch"},"body":"Following having finished making Fetch asynchronous, response.body should be set asynchronously, since it's the major goal of calling Fetch. So far, I've made the body wrapped in Arc<Mutex<>>, and I've wrapped a new thread around the part where it's set. I've also discovered that the fetch_async function makes step 8 of Main Fetch obsolete, and I've commented it appropriately.\r\n\r\nI'm currently having a hard time with the thread for setting response.body, though. @jdm suggested I have the body set continually, block by block, but my implementation for that runs so slow that I can't finish running my fetch test suite in reasonable time. @KiChjang pointed out that a lot of the lag is due to how response.body currently stores everything inside a Vec. Changing the storage container seems to be both necessary and beyond the scope of the time I have to work on this.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/9850)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/193484402","html_url":"https://github.com/servo/servo/pull/9850#issuecomment-193484402","issue_url":"https://api.github.com/repos/servo/servo/issues/9850","id":193484402,"user":{"login":"bors-servo","id":4368172,"avatar_url":"https://avatars.githubusercontent.com/u/4368172?v=3","gravatar_id":"","url":"https://api.github.com/users/bors-servo","html_url":"https://github.com/bors-servo","followers_url":"https://api.github.com/users/bors-servo/followers","following_url":"https://api.github.com/users/bors-servo/following{/other_user}","gists_url":"https://api.github.com/users/bors-servo/gists{/gist_id}","starred_url":"https://api.github.com/users/bors-servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors-servo/subscriptions","organizations_url":"https://api.github.com/users/bors-servo/orgs","repos_url":"https://api.github.com/users/bors-servo/repos","events_url":"https://api.github.com/users/bors-servo/events{/privacy}","received_events_url":"https://api.github.com/users/bors-servo/received_events","type":"User","site_admin":false},"created_at":"2016-03-07T22:27:14Z","updated_at":"2016-03-07T22:27:14Z","body":":pushpin: Commit b187985 has been approved by `jdm`\n\n<!-- @bors-servo r=jdm b187985e4967c2ccb6c951a68b7c0916caa16bb4 -->"}}