{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/17476","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/17476/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/17476/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/17476/events","html_url":"https://github.com/mantidproject/mantid/pull/17476","id":176577799,"number":17476,"title":"Re #17475 Updated instrument definitions","user":{"login":"PranavBahuguna","id":10980962,"avatar_url":"https://avatars.githubusercontent.com/u/10980962?v=3","gravatar_id":"","url":"https://api.github.com/users/PranavBahuguna","html_url":"https://github.com/PranavBahuguna","followers_url":"https://api.github.com/users/PranavBahuguna/followers","following_url":"https://api.github.com/users/PranavBahuguna/following{/other_user}","gists_url":"https://api.github.com/users/PranavBahuguna/gists{/gist_id}","starred_url":"https://api.github.com/users/PranavBahuguna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PranavBahuguna/subscriptions","organizations_url":"https://api.github.com/users/PranavBahuguna/orgs","repos_url":"https://api.github.com/users/PranavBahuguna/repos","events_url":"https://api.github.com/users/PranavBahuguna/events{/privacy}","received_events_url":"https://api.github.com/users/PranavBahuguna/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Reflectometry","name":"Component: Reflectometry","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"raquelalvarezbanos","id":8956985,"avatar_url":"https://avatars.githubusercontent.com/u/8956985?v=3","gravatar_id":"","url":"https://api.github.com/users/raquelalvarezbanos","html_url":"https://github.com/raquelalvarezbanos","followers_url":"https://api.github.com/users/raquelalvarezbanos/followers","following_url":"https://api.github.com/users/raquelalvarezbanos/following{/other_user}","gists_url":"https://api.github.com/users/raquelalvarezbanos/gists{/gist_id}","starred_url":"https://api.github.com/users/raquelalvarezbanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raquelalvarezbanos/subscriptions","organizations_url":"https://api.github.com/users/raquelalvarezbanos/orgs","repos_url":"https://api.github.com/users/raquelalvarezbanos/repos","events_url":"https://api.github.com/users/raquelalvarezbanos/events{/privacy}","received_events_url":"https://api.github.com/users/raquelalvarezbanos/received_events","type":"User","site_admin":false},"assignees":[{"login":"raquelalvarezbanos","id":8956985,"avatar_url":"https://avatars.githubusercontent.com/u/8956985?v=3","gravatar_id":"","url":"https://api.github.com/users/raquelalvarezbanos","html_url":"https://github.com/raquelalvarezbanos","followers_url":"https://api.github.com/users/raquelalvarezbanos/followers","following_url":"https://api.github.com/users/raquelalvarezbanos/following{/other_user}","gists_url":"https://api.github.com/users/raquelalvarezbanos/gists{/gist_id}","starred_url":"https://api.github.com/users/raquelalvarezbanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raquelalvarezbanos/subscriptions","organizations_url":"https://api.github.com/users/raquelalvarezbanos/orgs","repos_url":"https://api.github.com/users/raquelalvarezbanos/repos","events_url":"https://api.github.com/users/raquelalvarezbanos/events{/privacy}","received_events_url":"https://api.github.com/users/raquelalvarezbanos/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/58","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.8","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/58/labels","id":1505614,"number":58,"title":"Release 3.8","description":"Code Freeze: 16-Sep-2016\r\nDeveloper & Unscripted Testing: 16-Sep-2016 to 20-Sep-2016\r\nBeta test: 20-Sep-2016 to 04-Oct-2016\r\nRelease Date: 10-Oct-2016","creator":{"login":"granrothge","id":5910574,"avatar_url":"https://avatars.githubusercontent.com/u/5910574?v=3","gravatar_id":"","url":"https://api.github.com/users/granrothge","html_url":"https://github.com/granrothge","followers_url":"https://api.github.com/users/granrothge/followers","following_url":"https://api.github.com/users/granrothge/following{/other_user}","gists_url":"https://api.github.com/users/granrothge/gists{/gist_id}","starred_url":"https://api.github.com/users/granrothge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granrothge/subscriptions","organizations_url":"https://api.github.com/users/granrothge/orgs","repos_url":"https://api.github.com/users/granrothge/repos","events_url":"https://api.github.com/users/granrothge/events{/privacy}","received_events_url":"https://api.github.com/users/granrothge/received_events","type":"User","site_admin":false},"open_issues":685,"closed_issues":818,"state":"open","created_at":"2016-01-13T20:00:53Z","updated_at":"2016-09-13T18:16:34Z","due_on":"2016-10-10T00:00:00Z","closed_at":null},"comments":0,"created_at":"2016-09-13T08:13:28Z","updated_at":"2016-09-13T18:48:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/17476","html_url":"https://github.com/mantidproject/mantid/pull/17476","diff_url":"https://github.com/mantidproject/mantid/pull/17476.diff","patch_url":"https://github.com/mantidproject/mantid/pull/17476.patch"},"body":"This pull request updates the instrument definitions for POLREF that are required to be shipped for the next Mantid install. As stated in the issue it fixes, this fixes a few issues and maintains some semblance of backwards data reduction compatibility.\r\n\r\nRelease notes have been updated.\r\n\r\nFixes #17475.\r\n\r\n**To test:**\r\n\r\nSimply ensure that the instrument definition files have been updated correctly.\r\n\r\n<!-- RELEASE NOTES\r\nEither edit the file in docs/source/release/... and it will be in your pull request or state\r\n*Does not need to be in the release notes.*\r\n-->\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [ ] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [x] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/246783620","html_url":"https://github.com/mantidproject/mantid/pull/17476#issuecomment-246783620","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/17476","id":246783620,"user":{"login":"raquelalvarezbanos","id":8956985,"avatar_url":"https://avatars.githubusercontent.com/u/8956985?v=3","gravatar_id":"","url":"https://api.github.com/users/raquelalvarezbanos","html_url":"https://github.com/raquelalvarezbanos","followers_url":"https://api.github.com/users/raquelalvarezbanos/followers","following_url":"https://api.github.com/users/raquelalvarezbanos/following{/other_user}","gists_url":"https://api.github.com/users/raquelalvarezbanos/gists{/gist_id}","starred_url":"https://api.github.com/users/raquelalvarezbanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raquelalvarezbanos/subscriptions","organizations_url":"https://api.github.com/users/raquelalvarezbanos/orgs","repos_url":"https://api.github.com/users/raquelalvarezbanos/repos","events_url":"https://api.github.com/users/raquelalvarezbanos/events{/privacy}","received_events_url":"https://api.github.com/users/raquelalvarezbanos/received_events","type":"User","site_admin":false},"created_at":"2016-09-13T18:48:05Z","updated_at":"2016-09-13T18:48:05Z","body":"The new IDFs were provided by instrument scientists. I've just checked that Mantid is picking the right file.\r\n\r\n:shipit: "}}
{"actor":{"display_login":"raquelalvarezbanos"}}