{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/72858408","id":72858408,"diff_hunk":"@@ -58,8 +58,7 @@ private static void VerifyCertificates0(byte[] encodedMessage)\n             Assert.Equal(0, certs.Count);\n         }\n \n-        [Fact]\n-        [ActiveIssue(3334, PlatformID.AnyUnix)]\n+        [ConditionalFact(nameof(SupportsKeyAgreementCerts))]","path":"src/System.Security.Cryptography.Pkcs/tests/EnvelopedCms/CertificateTests.cs","position":6,"original_position":6,"commit_id":"f5dce9addd1d8ee6ddb07d340757ee31dab973b8","original_commit_id":"f5dce9addd1d8ee6ddb07d340757ee31dab973b8","user":{"login":"bartonjs","id":10642668,"avatar_url":"https://avatars.githubusercontent.com/u/10642668?v=3","gravatar_id":"","url":"https://api.github.com/users/bartonjs","html_url":"https://github.com/bartonjs","followers_url":"https://api.github.com/users/bartonjs/followers","following_url":"https://api.github.com/users/bartonjs/following{/other_user}","gists_url":"https://api.github.com/users/bartonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bartonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartonjs/subscriptions","organizations_url":"https://api.github.com/users/bartonjs/orgs","repos_url":"https://api.github.com/users/bartonjs/repos","events_url":"https://api.github.com/users/bartonjs/events{/privacy}","received_events_url":"https://api.github.com/users/bartonjs/received_events","type":"User","site_admin":false},"body":"Or just rename it, like in the next file.","created_at":"2016-07-29T20:50:59Z","updated_at":"2016-07-29T20:50:59Z","html_url":"https://github.com/dotnet/corefx/pull/10433#discussion_r72858408","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/10433","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/72858408"},"html":{"href":"https://github.com/dotnet/corefx/pull/10433#discussion_r72858408"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/10433"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/10433","id":79412618,"html_url":"https://github.com/dotnet/corefx/pull/10433","diff_url":"https://github.com/dotnet/corefx/pull/10433.diff","patch_url":"https://github.com/dotnet/corefx/pull/10433.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/10433","number":10433,"state":"open","locked":false,"title":"Turned tests that use KeyAgreement certs or add OriginatorCerts into ConditionalFacts in EnvelopedCms","user":{"login":"hoyosjs","id":19413848,"avatar_url":"https://avatars.githubusercontent.com/u/19413848?v=3","gravatar_id":"","url":"https://api.github.com/users/hoyosjs","html_url":"https://github.com/hoyosjs","followers_url":"https://api.github.com/users/hoyosjs/followers","following_url":"https://api.github.com/users/hoyosjs/following{/other_user}","gists_url":"https://api.github.com/users/hoyosjs/gists{/gist_id}","starred_url":"https://api.github.com/users/hoyosjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoyosjs/subscriptions","organizations_url":"https://api.github.com/users/hoyosjs/orgs","repos_url":"https://api.github.com/users/hoyosjs/repos","events_url":"https://api.github.com/users/hoyosjs/events{/privacy}","received_events_url":"https://api.github.com/users/hoyosjs/received_events","type":"User","site_admin":false},"body":"As KeyAgreement certs can't be used for encryption or decryption on the\r\ncurrent implementation of EnvelopedCms for Unix, the tests were turned\r\ninto conditional facts and tests were added to ensure that the Unix\r\nimplementation throws a PlatformNotSupportedException.\r\n\r\nSimilarly tests that added originator certificates were made\r\nConditionalFacts as OpenSSL doesn't support adding these and a test was\r\nadded to ensure that the Unix implementation throws a\r\nPlatformNotSupportedException.\r\n\r\n@bartonjs @weshaggard ","created_at":"2016-07-29T19:39:51Z","updated_at":"2016-07-29T20:50:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ae340841ee7a106546a772286b59f4c27bbfd91","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/10433/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/10433/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/10433/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/f5dce9addd1d8ee6ddb07d340757ee31dab973b8","head":{"label":"hoyosjs:UnixConditionalKeyAgreement","ref":"UnixConditionalKeyAgreement","sha":"f5dce9addd1d8ee6ddb07d340757ee31dab973b8","user":{"login":"hoyosjs","id":19413848,"avatar_url":"https://avatars.githubusercontent.com/u/19413848?v=3","gravatar_id":"","url":"https://api.github.com/users/hoyosjs","html_url":"https://github.com/hoyosjs","followers_url":"https://api.github.com/users/hoyosjs/followers","following_url":"https://api.github.com/users/hoyosjs/following{/other_user}","gists_url":"https://api.github.com/users/hoyosjs/gists{/gist_id}","starred_url":"https://api.github.com/users/hoyosjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoyosjs/subscriptions","organizations_url":"https://api.github.com/users/hoyosjs/orgs","repos_url":"https://api.github.com/users/hoyosjs/repos","events_url":"https://api.github.com/users/hoyosjs/events{/privacy}","received_events_url":"https://api.github.com/users/hoyosjs/received_events","type":"User","site_admin":false},"repo":{"id":59331716,"name":"corefx","full_name":"hoyosjs/corefx","owner":{"login":"hoyosjs","id":19413848,"avatar_url":"https://avatars.githubusercontent.com/u/19413848?v=3","gravatar_id":"","url":"https://api.github.com/users/hoyosjs","html_url":"https://github.com/hoyosjs","followers_url":"https://api.github.com/users/hoyosjs/followers","following_url":"https://api.github.com/users/hoyosjs/following{/other_user}","gists_url":"https://api.github.com/users/hoyosjs/gists{/gist_id}","starred_url":"https://api.github.com/users/hoyosjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoyosjs/subscriptions","organizations_url":"https://api.github.com/users/hoyosjs/orgs","repos_url":"https://api.github.com/users/hoyosjs/repos","events_url":"https://api.github.com/users/hoyosjs/events{/privacy}","received_events_url":"https://api.github.com/users/hoyosjs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hoyosjs/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/hoyosjs/corefx","forks_url":"https://api.github.com/repos/hoyosjs/corefx/forks","keys_url":"https://api.github.com/repos/hoyosjs/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoyosjs/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoyosjs/corefx/teams","hooks_url":"https://api.github.com/repos/hoyosjs/corefx/hooks","issue_events_url":"https://api.github.com/repos/hoyosjs/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/hoyosjs/corefx/events","assignees_url":"https://api.github.com/repos/hoyosjs/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/hoyosjs/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/hoyosjs/corefx/tags","blobs_url":"https://api.github.com/repos/hoyosjs/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoyosjs/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoyosjs/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoyosjs/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoyosjs/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/hoyosjs/corefx/languages","stargazers_url":"https://api.github.com/repos/hoyosjs/corefx/stargazers","contributors_url":"https://api.github.com/repos/hoyosjs/corefx/contributors","subscribers_url":"https://api.github.com/repos/hoyosjs/corefx/subscribers","subscription_url":"https://api.github.com/repos/hoyosjs/corefx/subscription","commits_url":"https://api.github.com/repos/hoyosjs/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoyosjs/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoyosjs/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoyosjs/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/hoyosjs/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/hoyosjs/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoyosjs/corefx/merges","archive_url":"https://api.github.com/repos/hoyosjs/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoyosjs/corefx/downloads","issues_url":"https://api.github.com/repos/hoyosjs/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/hoyosjs/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/hoyosjs/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/hoyosjs/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoyosjs/corefx/labels{/name}","releases_url":"https://api.github.com/repos/hoyosjs/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/hoyosjs/corefx/deployments","created_at":"2016-05-20T23:17:45Z","updated_at":"2016-05-20T23:18:09Z","pushed_at":"2016-07-29T20:47:14Z","git_url":"git://github.com/hoyosjs/corefx.git","ssh_url":"git@github.com:hoyosjs/corefx.git","clone_url":"https://github.com/hoyosjs/corefx.git","svn_url":"https://github.com/hoyosjs/corefx","homepage":"http://dotnet.github.io/","size":75472,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:dev/cms_unix","ref":"dev/cms_unix","sha":"3579ef40e9c7d783c2352f35298a02b5c94905e6","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-07-29T17:04:43Z","pushed_at":"2016-07-29T20:48:49Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":123169,"stargazers_count":10301,"watchers_count":10301,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2516,"mirror_url":null,"open_issues_count":1198,"forks":2516,"open_issues":1198,"watchers":10301,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/10433"},"html":{"href":"https://github.com/dotnet/corefx/pull/10433"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/10433"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/10433/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/10433/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/10433/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/f5dce9addd1d8ee6ddb07d340757ee31dab973b8"}}}}
{"actor":{"display_login":"bartonjs"}}