{"action":"created","issue":{"url":"https://api.github.com/repos/tc39/test262/issues/686","repository_url":"https://api.github.com/repos/tc39/test262","labels_url":"https://api.github.com/repos/tc39/test262/issues/686/labels{/name}","comments_url":"https://api.github.com/repos/tc39/test262/issues/686/comments","events_url":"https://api.github.com/repos/tc39/test262/issues/686/events","html_url":"https://github.com/tc39/test262/issues/686","id":161771711,"number":686,"title":"Incorrect tests: built-ins/DataView/prototype/setFloat*/toindex-byteoffset.js","user":{"login":"bakkot","id":1653598,"avatar_url":"https://avatars.githubusercontent.com/u/1653598?v=3","gravatar_id":"","url":"https://api.github.com/users/bakkot","html_url":"https://github.com/bakkot","followers_url":"https://api.github.com/users/bakkot/followers","following_url":"https://api.github.com/users/bakkot/following{/other_user}","gists_url":"https://api.github.com/users/bakkot/gists{/gist_id}","starred_url":"https://api.github.com/users/bakkot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakkot/subscriptions","organizations_url":"https://api.github.com/users/bakkot/orgs","repos_url":"https://api.github.com/users/bakkot/repos","events_url":"https://api.github.com/users/bakkot/events{/privacy}","received_events_url":"https://api.github.com/users/bakkot/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-22T19:58:10Z","updated_at":"2016-06-22T20:58:10Z","closed_at":null,"body":"The following tests assert in their final section that calling `dataview.setFloat32()` and `setFloat64` (i.e., with no arguments) sets index 0 to value 0. However, the value is being set coerced to a number with `ToNumber` (in step 5 of [24.2.1.2](https://tc39.github.io/ecma262/#sec-setviewvalue)), which casts `undefined` to `NaN`, not to 0. Hence, while the missing first argument to `setFloat32` treated as 0, the missing second argument is treated as `NaN`.\r\n\r\nThe last line of each of these tests should instead be something like\r\n```js\r\nsample.setFloat32(0, 7);\r\nsample.setFloat32();\r\nassert.sameValue(sample.getFloat32(0), NaN, \"no arg\");\r\n```\r\n\r\nThis affects the following tests:\r\n[1](https://github.com/tc39/test262/tree/master/test/built-ins/DataView/prototype/setFloat32/toindex-byteoffset.js), [2](https://github.com/tc39/test262/tree/master/test/built-ins/DataView/prototype/setFloat64/toindex-byteoffset.js).\r\n"},"comment":{"url":"https://api.github.com/repos/tc39/test262/issues/comments/227874319","html_url":"https://github.com/tc39/test262/issues/686#issuecomment-227874319","issue_url":"https://api.github.com/repos/tc39/test262/issues/686","id":227874319,"user":{"login":"leobalter","id":301201,"avatar_url":"https://avatars.githubusercontent.com/u/301201?v=3","gravatar_id":"","url":"https://api.github.com/users/leobalter","html_url":"https://github.com/leobalter","followers_url":"https://api.github.com/users/leobalter/followers","following_url":"https://api.github.com/users/leobalter/following{/other_user}","gists_url":"https://api.github.com/users/leobalter/gists{/gist_id}","starred_url":"https://api.github.com/users/leobalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leobalter/subscriptions","organizations_url":"https://api.github.com/users/leobalter/orgs","repos_url":"https://api.github.com/users/leobalter/repos","events_url":"https://api.github.com/users/leobalter/events{/privacy}","received_events_url":"https://api.github.com/users/leobalter/received_events","type":"User","site_admin":false},"created_at":"2016-06-22T20:58:10Z","updated_at":"2016-06-22T20:58:10Z","body":"You're right, thanks!"}}
{"actor":{"display_login":"leobalter"}}