{"action":"created","comment":{"url":"https://api.github.com/repos/jupyter/configurable-http-proxy/pulls/comments/57831090","id":57831090,"diff_hunk":"@@ -174,6 +175,7 @@ ConfigurableProxy.prototype.add_route = function (path, data) {\n     this.routes[path] = data;\n     this.trie.add(path, data);\n     this.update_last_activity(path);\n+    this.statsd.increment('route.add', 1);","path":"lib/configproxy.js","position":null,"original_position":59,"commit_id":"ba1146072749ea109923fb5aa09925a6f0a95dab","original_commit_id":"b01a56115d4c21b1efe9f04a98285a75deeba1bc","user":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"body":"This is causing the failing tests. CHP can be instantiated as a library via js API, in which case the bin script isn't involved.","created_at":"2016-03-30T02:51:53Z","updated_at":"2016-03-30T02:51:53Z","html_url":"https://github.com/jupyter/configurable-http-proxy/pull/51#discussion_r57831090","pull_request_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/jupyter/configurable-http-proxy/pulls/comments/57831090"},"html":{"href":"https://github.com/jupyter/configurable-http-proxy/pull/51#discussion_r57831090"},"pull_request":{"href":"https://api.github.com/repos/jupyter/configurable-http-proxy/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/jupyter/configurable-http-proxy/pulls/51","id":64417467,"html_url":"https://github.com/jupyter/configurable-http-proxy/pull/51","diff_url":"https://github.com/jupyter/configurable-http-proxy/pull/51.diff","patch_url":"https://github.com/jupyter/configurable-http-proxy/pull/51.patch","issue_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/issues/51","number":51,"state":"open","locked":false,"title":"Add basic statsd metrics","user":{"login":"yuvipanda","id":30430,"avatar_url":"https://avatars.githubusercontent.com/u/30430?v=3","gravatar_id":"","url":"https://api.github.com/users/yuvipanda","html_url":"https://github.com/yuvipanda","followers_url":"https://api.github.com/users/yuvipanda/followers","following_url":"https://api.github.com/users/yuvipanda/following{/other_user}","gists_url":"https://api.github.com/users/yuvipanda/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvipanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvipanda/subscriptions","organizations_url":"https://api.github.com/users/yuvipanda/orgs","repos_url":"https://api.github.com/users/yuvipanda/repos","events_url":"https://api.github.com/users/yuvipanda/events{/privacy}","received_events_url":"https://api.github.com/users/yuvipanda/received_events","type":"User","site_admin":false},"body":"- Sends very basic statsd metrics to a configurable endpoint\r\n- When statsd is not configured, nothing happens.","created_at":"2016-03-29T06:03:30Z","updated_at":"2016-03-30T02:51:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6d96c56ac2910d7e59c76024c2231d8a0756a41","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/pulls/51/commits","review_comments_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/pulls/51/comments","review_comment_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/issues/51/comments","statuses_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/statuses/ba1146072749ea109923fb5aa09925a6f0a95dab","head":{"label":"yuvipanda:statsd","ref":"statsd","sha":"ba1146072749ea109923fb5aa09925a6f0a95dab","user":{"login":"yuvipanda","id":30430,"avatar_url":"https://avatars.githubusercontent.com/u/30430?v=3","gravatar_id":"","url":"https://api.github.com/users/yuvipanda","html_url":"https://github.com/yuvipanda","followers_url":"https://api.github.com/users/yuvipanda/followers","following_url":"https://api.github.com/users/yuvipanda/following{/other_user}","gists_url":"https://api.github.com/users/yuvipanda/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvipanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvipanda/subscriptions","organizations_url":"https://api.github.com/users/yuvipanda/orgs","repos_url":"https://api.github.com/users/yuvipanda/repos","events_url":"https://api.github.com/users/yuvipanda/events{/privacy}","received_events_url":"https://api.github.com/users/yuvipanda/received_events","type":"User","site_admin":false},"repo":{"id":47256206,"name":"configurable-http-proxy","full_name":"yuvipanda/configurable-http-proxy","owner":{"login":"yuvipanda","id":30430,"avatar_url":"https://avatars.githubusercontent.com/u/30430?v=3","gravatar_id":"","url":"https://api.github.com/users/yuvipanda","html_url":"https://github.com/yuvipanda","followers_url":"https://api.github.com/users/yuvipanda/followers","following_url":"https://api.github.com/users/yuvipanda/following{/other_user}","gists_url":"https://api.github.com/users/yuvipanda/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvipanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvipanda/subscriptions","organizations_url":"https://api.github.com/users/yuvipanda/orgs","repos_url":"https://api.github.com/users/yuvipanda/repos","events_url":"https://api.github.com/users/yuvipanda/events{/privacy}","received_events_url":"https://api.github.com/users/yuvipanda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuvipanda/configurable-http-proxy","description":"node-http-proxy plus a REST API","fork":true,"url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy","forks_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/forks","keys_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/teams","hooks_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/hooks","issue_events_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/events","assignees_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/tags","blobs_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/languages","stargazers_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/stargazers","contributors_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/contributors","subscribers_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/subscribers","subscription_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/subscription","commits_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/merges","archive_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/downloads","issues_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/labels{/name}","releases_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/yuvipanda/configurable-http-proxy/deployments","created_at":"2015-12-02T11:16:59Z","updated_at":"2015-12-02T11:17:00Z","pushed_at":"2016-03-30T02:41:32Z","git_url":"git://github.com/yuvipanda/configurable-http-proxy.git","ssh_url":"git@github.com:yuvipanda/configurable-http-proxy.git","clone_url":"https://github.com/yuvipanda/configurable-http-proxy.git","svn_url":"https://github.com/yuvipanda/configurable-http-proxy","homepage":null,"size":185,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupyter:master","ref":"master","sha":"390227d3167d753a6421162b57272cc80a769b05","user":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"repo":{"id":23330903,"name":"configurable-http-proxy","full_name":"jupyter/configurable-http-proxy","owner":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jupyter/configurable-http-proxy","description":"node-http-proxy plus a REST API","fork":false,"url":"https://api.github.com/repos/jupyter/configurable-http-proxy","forks_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/forks","keys_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/teams","hooks_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/hooks","issue_events_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/events","assignees_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/tags","blobs_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/languages","stargazers_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/stargazers","contributors_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/contributors","subscribers_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/subscribers","subscription_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/subscription","commits_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/merges","archive_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/downloads","issues_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/labels{/name}","releases_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/jupyter/configurable-http-proxy/deployments","created_at":"2014-08-25T22:28:59Z","updated_at":"2016-03-16T22:41:31Z","pushed_at":"2016-03-30T02:41:33Z","git_url":"git://github.com/jupyter/configurable-http-proxy.git","ssh_url":"git@github.com:jupyter/configurable-http-proxy.git","clone_url":"https://github.com/jupyter/configurable-http-proxy.git","svn_url":"https://github.com/jupyter/configurable-http-proxy","homepage":null,"size":248,"stargazers_count":37,"watchers_count":37,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":3,"forks":31,"open_issues":3,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyter/configurable-http-proxy/pulls/51"},"html":{"href":"https://github.com/jupyter/configurable-http-proxy/pull/51"},"issue":{"href":"https://api.github.com/repos/jupyter/configurable-http-proxy/issues/51"},"comments":{"href":"https://api.github.com/repos/jupyter/configurable-http-proxy/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyter/configurable-http-proxy/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyter/configurable-http-proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyter/configurable-http-proxy/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/jupyter/configurable-http-proxy/statuses/ba1146072749ea109923fb5aa09925a6f0a95dab"}}}}