{"action":"created","issue":{"url":"https://api.github.com/repos/Slicer/Slicer/issues/592","repository_url":"https://api.github.com/repos/Slicer/Slicer","labels_url":"https://api.github.com/repos/Slicer/Slicer/issues/592/labels{/name}","comments_url":"https://api.github.com/repos/Slicer/Slicer/issues/592/comments","events_url":"https://api.github.com/repos/Slicer/Slicer/issues/592/events","html_url":"https://github.com/Slicer/Slicer/pull/592","id":180523680,"number":592,"title":"ENH: adding CloudLasso selection editor effect","user":{"login":"Punzo","id":7985338,"avatar_url":"https://avatars.githubusercontent.com/u/7985338?v=3","gravatar_id":"","url":"https://api.github.com/users/Punzo","html_url":"https://github.com/Punzo","followers_url":"https://api.github.com/users/Punzo/followers","following_url":"https://api.github.com/users/Punzo/following{/other_user}","gists_url":"https://api.github.com/users/Punzo/gists{/gist_id}","starred_url":"https://api.github.com/users/Punzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Punzo/subscriptions","organizations_url":"https://api.github.com/users/Punzo/orgs","repos_url":"https://api.github.com/users/Punzo/repos","events_url":"https://api.github.com/users/Punzo/events{/privacy}","received_events_url":"https://api.github.com/users/Punzo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Slicer/Slicer/labels/feature","name":"feature","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":25,"created_at":"2016-10-02T17:30:22Z","updated_at":"2016-10-14T14:01:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Slicer/Slicer/pulls/592","html_url":"https://github.com/Slicer/Slicer/pull/592","diff_url":"https://github.com/Slicer/Slicer/pull/592.diff","patch_url":"https://github.com/Slicer/Slicer/pull/592.patch"},"body":"Finally I had some time to finish my Slicer Summer project week. @lassoan @cpinter @pieper @jcfr , may you kindly review it? It will be great, if you will also have time for testing it.\r\n\r\nA video showing it: https://youtu.be/v6x3uPuLxzM\r\n\r\n(perfomance on my laptop with GTX860M are ok, but not always interactive; on my gaming station with GTX970 are always interactive).\r\n\r\nThere is still a small TO DO in line 722 of qSlicerSegmentEditorCloudLassoEffect.cxx, relative to a a rather small bug (please read the long comment in the code). However, I haven't a lot residual time to dedicate to this project, so for the moment I'll leave the bug (@lassoan if you have any idea how to fix it fast, I'll be more than glad to do it).\r\n\r\nThanks,\r\nDavide.\r\n"},"comment":{"url":"https://api.github.com/repos/Slicer/Slicer/issues/comments/253807986","html_url":"https://github.com/Slicer/Slicer/pull/592#issuecomment-253807986","issue_url":"https://api.github.com/repos/Slicer/Slicer/issues/592","id":253807986,"user":{"login":"fedorov","id":313942,"avatar_url":"https://avatars.githubusercontent.com/u/313942?v=3","gravatar_id":"","url":"https://api.github.com/users/fedorov","html_url":"https://github.com/fedorov","followers_url":"https://api.github.com/users/fedorov/followers","following_url":"https://api.github.com/users/fedorov/following{/other_user}","gists_url":"https://api.github.com/users/fedorov/gists{/gist_id}","starred_url":"https://api.github.com/users/fedorov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedorov/subscriptions","organizations_url":"https://api.github.com/users/fedorov/orgs","repos_url":"https://api.github.com/users/fedorov/repos","events_url":"https://api.github.com/users/fedorov/events{/privacy}","received_events_url":"https://api.github.com/users/fedorov/received_events","type":"User","site_admin":false},"created_at":"2016-10-14T14:01:35Z","updated_at":"2016-10-14T14:01:35Z","body":"@lassoan if we add units, it makes sense to add a quantity attribute at the same time. The example I referenced earlier in https://github.com/Slicer/Slicer/pull/592#issuecomment-252913866 and also this one https://github.com/QIICR/dcmqi/blob/master/doc/pm-example.json#L9-L12 show how it can be using DICOM concepts.\r\n\r\nI also think this discussion diverged a lot from the topic of the request. Should we make a Labs page? Although the advantage of our current approach is that we can have a discussion, unlike in wiki."}}
{"actor":{"display_login":"fedorov"}}