{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/comments/60494595","id":60494595,"diff_hunk":"@@ -20,27 +17,27 @@ namespace Microsoft.Azure.WebJobs.Extensions.Tests.Extensions.DocumentDB\n     public class DocumentDBUtilityTests\n     {\n         [Fact]\n-        public async Task ExecuteAndIgnoreStatusCode_Ignores_SpecifiedStatusCode()\n+        public async Task RetryAsync_Ignores_SpecifiedStatusCode()\n         {\n             // Arrange\n             string testString = \"Method called!\";\n             string s = null;\n             var ex = DocumentDBTestUtility.CreateDocumentClientException(HttpStatusCode.Conflict);\n \n             // Act\n-            await DocumentDBUtility.ExecuteAndIgnoreStatusCodeAsync(HttpStatusCode.Conflict, () =>\n+            await DocumentDBUtility.RetryAsync<object>(() =>\n             {\n                 s = testString;\n                 throw ex;\n-            });\n+            }, 0, HttpStatusCode.Conflict, HttpStatusCode.NotFound);\n \n             // Assert\n             Assert.Equal(testString, s);\n             // The fact that it doesn't throw proves that it was ignored\n         }\n \n         [Fact]\n-        public async Task ExecuteAndIgnoreStatusCode_DoesNotIgnore_OtherStatusCodes()\n+        public async Task RetryAsync_DoesNotIgnore_OtherStatusCodes()","path":"test/WebJobs.Extensions.Tests/Extensions/DocumentDB/DocumentDBUtilityTests.cs","position":42,"original_position":42,"commit_id":"a5efd1d83a81d442165ce46d7b0ee383ae7fba08","original_commit_id":"a5efd1d83a81d442165ce46d7b0ee383ae7fba08","user":{"login":"brettsam","id":1089915,"avatar_url":"https://avatars.githubusercontent.com/u/1089915?v=3","gravatar_id":"","url":"https://api.github.com/users/brettsam","html_url":"https://github.com/brettsam","followers_url":"https://api.github.com/users/brettsam/followers","following_url":"https://api.github.com/users/brettsam/following{/other_user}","gists_url":"https://api.github.com/users/brettsam/gists{/gist_id}","starred_url":"https://api.github.com/users/brettsam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettsam/subscriptions","organizations_url":"https://api.github.com/users/brettsam/orgs","repos_url":"https://api.github.com/users/brettsam/repos","events_url":"https://api.github.com/users/brettsam/events{/privacy}","received_events_url":"https://api.github.com/users/brettsam/received_events","type":"User","site_admin":false},"body":"Good point. I've added a test for null.\r\n\r\n---\r\nIn reply to: [60487790](https://github.com/Azure/azure-webjobs-sdk-extensions/pull/83#discussion_r60487790) [](ancestors = 60487790)","created_at":"2016-04-20T21:53:57Z","updated_at":"2016-04-20T21:53:57Z","html_url":"https://github.com/Azure/azure-webjobs-sdk-extensions/pull/83#discussion_r60494595","pull_request_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/comments/60494595"},"html":{"href":"https://github.com/Azure/azure-webjobs-sdk-extensions/pull/83#discussion_r60494595"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/83","id":67246133,"html_url":"https://github.com/Azure/azure-webjobs-sdk-extensions/pull/83","diff_url":"https://github.com/Azure/azure-webjobs-sdk-extensions/pull/83.diff","patch_url":"https://github.com/Azure/azure-webjobs-sdk-extensions/pull/83.patch","issue_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/issues/83","number":83,"state":"open","locked":false,"title":"DocDB: moving create to AsyncCollector; improving create logic","user":{"login":"brettsam","id":1089915,"avatar_url":"https://avatars.githubusercontent.com/u/1089915?v=3","gravatar_id":"","url":"https://api.github.com/users/brettsam","html_url":"https://github.com/brettsam","followers_url":"https://api.github.com/users/brettsam/followers","following_url":"https://api.github.com/users/brettsam/following{/other_user}","gists_url":"https://api.github.com/users/brettsam/gists{/gist_id}","starred_url":"https://api.github.com/users/brettsam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettsam/subscriptions","organizations_url":"https://api.github.com/users/brettsam/orgs","repos_url":"https://api.github.com/users/brettsam/repos","events_url":"https://api.github.com/users/brettsam/events{/privacy}","received_events_url":"https://api.github.com/users/brettsam/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-20T19:41:21Z","updated_at":"2016-04-20T21:53:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5af382dd58912d9ea75515f2d18cfd9bb0ebb08b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/83/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/83/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/issues/83/comments","statuses_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/statuses/a5efd1d83a81d442165ce46d7b0ee383ae7fba08","head":{"label":"brettsam:create","ref":"create","sha":"a5efd1d83a81d442165ce46d7b0ee383ae7fba08","user":{"login":"brettsam","id":1089915,"avatar_url":"https://avatars.githubusercontent.com/u/1089915?v=3","gravatar_id":"","url":"https://api.github.com/users/brettsam","html_url":"https://github.com/brettsam","followers_url":"https://api.github.com/users/brettsam/followers","following_url":"https://api.github.com/users/brettsam/following{/other_user}","gists_url":"https://api.github.com/users/brettsam/gists{/gist_id}","starred_url":"https://api.github.com/users/brettsam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettsam/subscriptions","organizations_url":"https://api.github.com/users/brettsam/orgs","repos_url":"https://api.github.com/users/brettsam/repos","events_url":"https://api.github.com/users/brettsam/events{/privacy}","received_events_url":"https://api.github.com/users/brettsam/received_events","type":"User","site_admin":false},"repo":{"id":52908361,"name":"azure-webjobs-sdk-extensions","full_name":"brettsam/azure-webjobs-sdk-extensions","owner":{"login":"brettsam","id":1089915,"avatar_url":"https://avatars.githubusercontent.com/u/1089915?v=3","gravatar_id":"","url":"https://api.github.com/users/brettsam","html_url":"https://github.com/brettsam","followers_url":"https://api.github.com/users/brettsam/followers","following_url":"https://api.github.com/users/brettsam/following{/other_user}","gists_url":"https://api.github.com/users/brettsam/gists{/gist_id}","starred_url":"https://api.github.com/users/brettsam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettsam/subscriptions","organizations_url":"https://api.github.com/users/brettsam/orgs","repos_url":"https://api.github.com/users/brettsam/repos","events_url":"https://api.github.com/users/brettsam/events{/privacy}","received_events_url":"https://api.github.com/users/brettsam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brettsam/azure-webjobs-sdk-extensions","description":"Azure WebJobs SDK Extensions","fork":true,"url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions","forks_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/forks","keys_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/teams","hooks_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/hooks","issue_events_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/events","assignees_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/tags","blobs_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/languages","stargazers_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/stargazers","contributors_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/contributors","subscribers_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/subscribers","subscription_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/subscription","commits_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/merges","archive_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/downloads","issues_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/labels{/name}","releases_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/releases{/id}","deployments_url":"https://api.github.com/repos/brettsam/azure-webjobs-sdk-extensions/deployments","created_at":"2016-03-01T20:41:38Z","updated_at":"2016-03-01T20:41:39Z","pushed_at":"2016-04-20T19:49:21Z","git_url":"git://github.com/brettsam/azure-webjobs-sdk-extensions.git","ssh_url":"git@github.com:brettsam/azure-webjobs-sdk-extensions.git","clone_url":"https://github.com/brettsam/azure-webjobs-sdk-extensions.git","svn_url":"https://github.com/brettsam/azure-webjobs-sdk-extensions","homepage":"","size":981,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"38a8eada5a00711e67e1cfa062c0b2e2d8345a1a","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":36027231,"name":"azure-webjobs-sdk-extensions","full_name":"Azure/azure-webjobs-sdk-extensions","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-webjobs-sdk-extensions","description":"Azure WebJobs SDK Extensions","fork":false,"url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions","forks_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/forks","keys_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/teams","hooks_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/events","assignees_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/tags","blobs_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/subscription","commits_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/merges","archive_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/downloads","issues_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/deployments","created_at":"2015-05-21T17:28:25Z","updated_at":"2016-04-14T21:10:14Z","pushed_at":"2016-04-20T19:49:21Z","git_url":"git://github.com/Azure/azure-webjobs-sdk-extensions.git","ssh_url":"git@github.com:Azure/azure-webjobs-sdk-extensions.git","clone_url":"https://github.com/Azure/azure-webjobs-sdk-extensions.git","svn_url":"https://github.com/Azure/azure-webjobs-sdk-extensions","homepage":"","size":1105,"stargazers_count":46,"watchers_count":46,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":26,"forks":22,"open_issues":26,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/83"},"html":{"href":"https://github.com/Azure/azure-webjobs-sdk-extensions/pull/83"},"issue":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/issues/83"},"comments":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk-extensions/statuses/a5efd1d83a81d442165ce46d7b0ee383ae7fba08"}}}}