{"action":"created","comment":{"url":"https://api.github.com/repos/stellar/go-stellar-base/pulls/comments/57339906","id":57339906,"diff_hunk":"@@ -34,3 +34,45 @@ func ExampleTransactionBuilder() {\n \tfmt.Printf(\"tx base64: %s\", txeB64)\n \t// Output: tx base64: AAAAADZY/nWY0gx6beMpf4S8Ur0qHsjA8fbFtBzBx1cbQzHwAAAAZAAAAAAAAAABAAAAAAAAAAAAAAABAAAAAAAAAAEAAAAALSRpLtCLv2eboZlEiHDSGR6Hb+zZL92fbSdNpObeE0EAAAAAAAAAAB3NZQAAAAAAAAAAARtDMfAAAABA2oIeQxoJl53RMRWFeLB865zcky39f2gf2PmUubCuJYccEePRSrTC8QQrMOgGwD8a6oe8dgltvezdDsmmXBPyBw==\n }\n+\n+// ExamplePathPayment creates and signs a simple transaction with PathPayment operation, and then\n+// encodes it into a base64 string capable of being submitted to stellar-core.\n+func ExamplePathPayment() {","path":"build/main_test.go","position":16,"original_position":16,"commit_id":"575ca5517d84ed6ef66e5c136d1f6739da1e415c","original_commit_id":"575ca5517d84ed6ef66e5c136d1f6739da1e415c","user":{"login":"nullstyle","id":366,"avatar_url":"https://avatars.githubusercontent.com/u/366?v=3","gravatar_id":"","url":"https://api.github.com/users/nullstyle","html_url":"https://github.com/nullstyle","followers_url":"https://api.github.com/users/nullstyle/followers","following_url":"https://api.github.com/users/nullstyle/following{/other_user}","gists_url":"https://api.github.com/users/nullstyle/gists{/gist_id}","starred_url":"https://api.github.com/users/nullstyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nullstyle/subscriptions","organizations_url":"https://api.github.com/users/nullstyle/orgs","repos_url":"https://api.github.com/users/nullstyle/repos","events_url":"https://api.github.com/users/nullstyle/events{/privacy}","received_events_url":"https://api.github.com/users/nullstyle/received_events","type":"User","site_admin":false},"body":"Notice that there is no separate `PathPayment` mutator.  Instead, I use the normal `Payment` mutator and it knows that when I start provided path payment specific mutators that it should build a PathPaymentOp instead.  This allows the end developer to not care whether to pick one or the other.  The system will just use the most appropriate operation.\r\n\r\nIMO, this is consistent with how we expose non-native payments in the higher level SDKs...  We paint over some of the specifics to give a simpler external interface.  For example, js-sdk's `Asset` doesn't differentiate between alphanum4 and alphanum12 assets... it will just transparently use the correct one based upon the code supplied.","created_at":"2016-03-24T15:59:27Z","updated_at":"2016-03-24T15:59:27Z","html_url":"https://github.com/stellar/go-stellar-base/pull/20#discussion_r57339906","pull_request_url":"https://api.github.com/repos/stellar/go-stellar-base/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/stellar/go-stellar-base/pulls/comments/57339906"},"html":{"href":"https://github.com/stellar/go-stellar-base/pull/20#discussion_r57339906"},"pull_request":{"href":"https://api.github.com/repos/stellar/go-stellar-base/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/stellar/go-stellar-base/pulls/20","id":64036067,"html_url":"https://github.com/stellar/go-stellar-base/pull/20","diff_url":"https://github.com/stellar/go-stellar-base/pull/20.diff","patch_url":"https://github.com/stellar/go-stellar-base/pull/20.patch","issue_url":"https://api.github.com/repos/stellar/go-stellar-base/issues/20","number":20,"state":"open","locked":false,"title":"PathPayment","user":{"login":"bartekn","id":464938,"avatar_url":"https://avatars.githubusercontent.com/u/464938?v=3","gravatar_id":"","url":"https://api.github.com/users/bartekn","html_url":"https://github.com/bartekn","followers_url":"https://api.github.com/users/bartekn/followers","following_url":"https://api.github.com/users/bartekn/following{/other_user}","gists_url":"https://api.github.com/users/bartekn/gists{/gist_id}","starred_url":"https://api.github.com/users/bartekn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartekn/subscriptions","organizations_url":"https://api.github.com/users/bartekn/orgs","repos_url":"https://api.github.com/users/bartekn/repos","events_url":"https://api.github.com/users/bartekn/events{/privacy}","received_events_url":"https://api.github.com/users/bartekn/received_events","type":"User","site_admin":false},"body":"This PR adds PathPayment operation mutators. Check [`ExamplePathPayment` function](https://github.com/stellar/go-stellar-base/pull/20/files#diff-b0bd7cdedee15ec71276b9561bda7cbc).\r\n","created_at":"2016-03-24T13:49:56Z","updated_at":"2016-03-24T15:59:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8aa6a59702396fd6f7f466ac64632870ec30a11d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/stellar/go-stellar-base/pulls/20/commits","review_comments_url":"https://api.github.com/repos/stellar/go-stellar-base/pulls/20/comments","review_comment_url":"https://api.github.com/repos/stellar/go-stellar-base/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stellar/go-stellar-base/issues/20/comments","statuses_url":"https://api.github.com/repos/stellar/go-stellar-base/statuses/575ca5517d84ed6ef66e5c136d1f6739da1e415c","head":{"label":"stellar:path-payment","ref":"path-payment","sha":"575ca5517d84ed6ef66e5c136d1f6739da1e415c","user":{"login":"stellar","id":7386716,"avatar_url":"https://avatars.githubusercontent.com/u/7386716?v=3","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"repo":{"id":33701405,"name":"go-stellar-base","full_name":"stellar/go-stellar-base","owner":{"login":"stellar","id":7386716,"avatar_url":"https://avatars.githubusercontent.com/u/7386716?v=3","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stellar/go-stellar-base","description":"The stellar-base library is the lowest-level stellar helper library. It consists of classes to read, write, hash, and sign the xdr structures that are used in stellard. It doesn't assume you are talking to horizon.","fork":false,"url":"https://api.github.com/repos/stellar/go-stellar-base","forks_url":"https://api.github.com/repos/stellar/go-stellar-base/forks","keys_url":"https://api.github.com/repos/stellar/go-stellar-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stellar/go-stellar-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stellar/go-stellar-base/teams","hooks_url":"https://api.github.com/repos/stellar/go-stellar-base/hooks","issue_events_url":"https://api.github.com/repos/stellar/go-stellar-base/issues/events{/number}","events_url":"https://api.github.com/repos/stellar/go-stellar-base/events","assignees_url":"https://api.github.com/repos/stellar/go-stellar-base/assignees{/user}","branches_url":"https://api.github.com/repos/stellar/go-stellar-base/branches{/branch}","tags_url":"https://api.github.com/repos/stellar/go-stellar-base/tags","blobs_url":"https://api.github.com/repos/stellar/go-stellar-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stellar/go-stellar-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stellar/go-stellar-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/stellar/go-stellar-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stellar/go-stellar-base/statuses/{sha}","languages_url":"https://api.github.com/repos/stellar/go-stellar-base/languages","stargazers_url":"https://api.github.com/repos/stellar/go-stellar-base/stargazers","contributors_url":"https://api.github.com/repos/stellar/go-stellar-base/contributors","subscribers_url":"https://api.github.com/repos/stellar/go-stellar-base/subscribers","subscription_url":"https://api.github.com/repos/stellar/go-stellar-base/subscription","commits_url":"https://api.github.com/repos/stellar/go-stellar-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/stellar/go-stellar-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/stellar/go-stellar-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/stellar/go-stellar-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/stellar/go-stellar-base/contents/{+path}","compare_url":"https://api.github.com/repos/stellar/go-stellar-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stellar/go-stellar-base/merges","archive_url":"https://api.github.com/repos/stellar/go-stellar-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stellar/go-stellar-base/downloads","issues_url":"https://api.github.com/repos/stellar/go-stellar-base/issues{/number}","pulls_url":"https://api.github.com/repos/stellar/go-stellar-base/pulls{/number}","milestones_url":"https://api.github.com/repos/stellar/go-stellar-base/milestones{/number}","notifications_url":"https://api.github.com/repos/stellar/go-stellar-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stellar/go-stellar-base/labels{/name}","releases_url":"https://api.github.com/repos/stellar/go-stellar-base/releases{/id}","deployments_url":"https://api.github.com/repos/stellar/go-stellar-base/deployments","created_at":"2015-04-10T01:21:20Z","updated_at":"2016-02-22T19:57:00Z","pushed_at":"2016-03-24T13:49:57Z","git_url":"git://github.com/stellar/go-stellar-base.git","ssh_url":"git@github.com:stellar/go-stellar-base.git","clone_url":"https://github.com/stellar/go-stellar-base.git","svn_url":"https://github.com/stellar/go-stellar-base","homepage":"","size":276,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":4,"forks":6,"open_issues":4,"watchers":4,"default_branch":"master"}},"base":{"label":"stellar:master","ref":"master","sha":"cce568ae84d4c9149ca687e5df3209918645ebf6","user":{"login":"stellar","id":7386716,"avatar_url":"https://avatars.githubusercontent.com/u/7386716?v=3","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"repo":{"id":33701405,"name":"go-stellar-base","full_name":"stellar/go-stellar-base","owner":{"login":"stellar","id":7386716,"avatar_url":"https://avatars.githubusercontent.com/u/7386716?v=3","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stellar/go-stellar-base","description":"The stellar-base library is the lowest-level stellar helper library. It consists of classes to read, write, hash, and sign the xdr structures that are used in stellard. It doesn't assume you are talking to horizon.","fork":false,"url":"https://api.github.com/repos/stellar/go-stellar-base","forks_url":"https://api.github.com/repos/stellar/go-stellar-base/forks","keys_url":"https://api.github.com/repos/stellar/go-stellar-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stellar/go-stellar-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stellar/go-stellar-base/teams","hooks_url":"https://api.github.com/repos/stellar/go-stellar-base/hooks","issue_events_url":"https://api.github.com/repos/stellar/go-stellar-base/issues/events{/number}","events_url":"https://api.github.com/repos/stellar/go-stellar-base/events","assignees_url":"https://api.github.com/repos/stellar/go-stellar-base/assignees{/user}","branches_url":"https://api.github.com/repos/stellar/go-stellar-base/branches{/branch}","tags_url":"https://api.github.com/repos/stellar/go-stellar-base/tags","blobs_url":"https://api.github.com/repos/stellar/go-stellar-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stellar/go-stellar-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stellar/go-stellar-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/stellar/go-stellar-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stellar/go-stellar-base/statuses/{sha}","languages_url":"https://api.github.com/repos/stellar/go-stellar-base/languages","stargazers_url":"https://api.github.com/repos/stellar/go-stellar-base/stargazers","contributors_url":"https://api.github.com/repos/stellar/go-stellar-base/contributors","subscribers_url":"https://api.github.com/repos/stellar/go-stellar-base/subscribers","subscription_url":"https://api.github.com/repos/stellar/go-stellar-base/subscription","commits_url":"https://api.github.com/repos/stellar/go-stellar-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/stellar/go-stellar-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/stellar/go-stellar-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/stellar/go-stellar-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/stellar/go-stellar-base/contents/{+path}","compare_url":"https://api.github.com/repos/stellar/go-stellar-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stellar/go-stellar-base/merges","archive_url":"https://api.github.com/repos/stellar/go-stellar-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stellar/go-stellar-base/downloads","issues_url":"https://api.github.com/repos/stellar/go-stellar-base/issues{/number}","pulls_url":"https://api.github.com/repos/stellar/go-stellar-base/pulls{/number}","milestones_url":"https://api.github.com/repos/stellar/go-stellar-base/milestones{/number}","notifications_url":"https://api.github.com/repos/stellar/go-stellar-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stellar/go-stellar-base/labels{/name}","releases_url":"https://api.github.com/repos/stellar/go-stellar-base/releases{/id}","deployments_url":"https://api.github.com/repos/stellar/go-stellar-base/deployments","created_at":"2015-04-10T01:21:20Z","updated_at":"2016-02-22T19:57:00Z","pushed_at":"2016-03-24T13:49:57Z","git_url":"git://github.com/stellar/go-stellar-base.git","ssh_url":"git@github.com:stellar/go-stellar-base.git","clone_url":"https://github.com/stellar/go-stellar-base.git","svn_url":"https://github.com/stellar/go-stellar-base","homepage":"","size":276,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":4,"forks":6,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stellar/go-stellar-base/pulls/20"},"html":{"href":"https://github.com/stellar/go-stellar-base/pull/20"},"issue":{"href":"https://api.github.com/repos/stellar/go-stellar-base/issues/20"},"comments":{"href":"https://api.github.com/repos/stellar/go-stellar-base/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/stellar/go-stellar-base/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/stellar/go-stellar-base/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stellar/go-stellar-base/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/stellar/go-stellar-base/statuses/575ca5517d84ed6ef66e5c136d1f6739da1e415c"}}}}