{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/75562645","id":75562645,"diff_hunk":"@@ -0,0 +1,50 @@\n+---\n+images:\n+  containervm-density1:\n+    image: e2e-node-containervm-v20160321-image","path":"test/e2e_node/jenkins/benchmark/benchmark-config.yaml","position":4,"original_position":4,"commit_id":"37a414c1dab98cc3e6c69d370c41bb96e1fe9b2a","original_commit_id":"37a414c1dab98cc3e6c69d370c41bb96e1fe9b2a","user":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"body":"Shouldn't image here be \"containervm-v20160321-image\"? Isn't \"e2e-node-containervm-v20160321-image\" is the node name created by node-e2e for image of \"containervm-v20160321-image\"?","created_at":"2016-08-19T22:55:32Z","updated_at":"2016-08-19T22:55:32Z","html_url":"https://github.com/kubernetes/kubernetes/pull/31039#discussion_r75562645","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31039","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/75562645"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/31039#discussion_r75562645"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31039"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31039","id":82055961,"html_url":"https://github.com/kubernetes/kubernetes/pull/31039","diff_url":"https://github.com/kubernetes/kubernetes/pull/31039.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/31039.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/31039","number":31039,"state":"open","locked":false,"title":"Add benchmark to jenkins","user":{"login":"coufon","id":11655397,"avatar_url":"https://avatars.githubusercontent.com/u/11655397?v=3","gravatar_id":"","url":"https://api.github.com/users/coufon","html_url":"https://github.com/coufon","followers_url":"https://api.github.com/users/coufon/followers","following_url":"https://api.github.com/users/coufon/following{/other_user}","gists_url":"https://api.github.com/users/coufon/gists{/gist_id}","starred_url":"https://api.github.com/users/coufon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coufon/subscriptions","organizations_url":"https://api.github.com/users/coufon/orgs","repos_url":"https://api.github.com/users/coufon/repos","events_url":"https://api.github.com/users/coufon/events{/privacy}","received_events_url":"https://api.github.com/users/coufon/received_events","type":"User","site_admin":false},"body":"This PR contains the following changes:\r\n\r\n1. Add more tests in density benchmark test;\r\n2. Add the peak value (100%) in latency and CPU usage statistic data;\r\n3. Move the Ginkgo focus flag from e2e_remote.go to run_e2e.go;\r\n4. Support running benchmark in run_e2e.go. The benchmark configuration file is an extension of image configuration. Each item requires additional GCE machine type (e.g. n1-standard-1, default value will be used if empty) and test names (Ginkgo focus regex strings). A test item is regarded as benchmark if the tests field is non-empty.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/31039)\n<!-- Reviewable:end -->\n","created_at":"2016-08-19T22:43:50Z","updated_at":"2016-08-19T22:55:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c002dfcf31e134aad4d8940e4a462e31b08c8783","assignee":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"assignees":[{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/22","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.4","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/22/labels","id":1777384,"number":22,"title":"v1.4","description":"https://github.com/kubernetes/features/blob/master/release-1.4/Release-1.4.md","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":237,"closed_issues":261,"state":"open","created_at":"2016-05-19T18:50:19Z","updated_at":"2016-08-19T22:51:51Z","due_on":"2016-09-15T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31039/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31039/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/31039/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/37a414c1dab98cc3e6c69d370c41bb96e1fe9b2a","head":{"label":"coufon:add_benchmark_to_jenkins","ref":"add_benchmark_to_jenkins","sha":"37a414c1dab98cc3e6c69d370c41bb96e1fe9b2a","user":{"login":"coufon","id":11655397,"avatar_url":"https://avatars.githubusercontent.com/u/11655397?v=3","gravatar_id":"","url":"https://api.github.com/users/coufon","html_url":"https://github.com/coufon","followers_url":"https://api.github.com/users/coufon/followers","following_url":"https://api.github.com/users/coufon/following{/other_user}","gists_url":"https://api.github.com/users/coufon/gists{/gist_id}","starred_url":"https://api.github.com/users/coufon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coufon/subscriptions","organizations_url":"https://api.github.com/users/coufon/orgs","repos_url":"https://api.github.com/users/coufon/repos","events_url":"https://api.github.com/users/coufon/events{/privacy}","received_events_url":"https://api.github.com/users/coufon/received_events","type":"User","site_admin":false},"repo":{"id":61249591,"name":"kubernetes","full_name":"coufon/kubernetes","owner":{"login":"coufon","id":11655397,"avatar_url":"https://avatars.githubusercontent.com/u/11655397?v=3","gravatar_id":"","url":"https://api.github.com/users/coufon","html_url":"https://github.com/coufon","followers_url":"https://api.github.com/users/coufon/followers","following_url":"https://api.github.com/users/coufon/following{/other_user}","gists_url":"https://api.github.com/users/coufon/gists{/gist_id}","starred_url":"https://api.github.com/users/coufon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coufon/subscriptions","organizations_url":"https://api.github.com/users/coufon/orgs","repos_url":"https://api.github.com/users/coufon/repos","events_url":"https://api.github.com/users/coufon/events{/privacy}","received_events_url":"https://api.github.com/users/coufon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coufon/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/coufon/kubernetes","forks_url":"https://api.github.com/repos/coufon/kubernetes/forks","keys_url":"https://api.github.com/repos/coufon/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coufon/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coufon/kubernetes/teams","hooks_url":"https://api.github.com/repos/coufon/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/coufon/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/coufon/kubernetes/events","assignees_url":"https://api.github.com/repos/coufon/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/coufon/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/coufon/kubernetes/tags","blobs_url":"https://api.github.com/repos/coufon/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coufon/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coufon/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/coufon/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coufon/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/coufon/kubernetes/languages","stargazers_url":"https://api.github.com/repos/coufon/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/coufon/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/coufon/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/coufon/kubernetes/subscription","commits_url":"https://api.github.com/repos/coufon/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/coufon/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/coufon/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/coufon/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/coufon/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/coufon/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coufon/kubernetes/merges","archive_url":"https://api.github.com/repos/coufon/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coufon/kubernetes/downloads","issues_url":"https://api.github.com/repos/coufon/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/coufon/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/coufon/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/coufon/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coufon/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/coufon/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/coufon/kubernetes/deployments","created_at":"2016-06-16T00:19:36Z","updated_at":"2016-06-16T00:19:53Z","pushed_at":"2016-08-19T22:47:17Z","git_url":"git://github.com/coufon/kubernetes.git","ssh_url":"git@github.com:coufon/kubernetes.git","clone_url":"https://github.com/coufon/kubernetes.git","svn_url":"https://github.com/coufon/kubernetes","homepage":"http://kubernetes.io","size":314383,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"9bc8240f1a5f91a9f4afcbea2214f45fa1a1c43b","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-08-19T20:16:47Z","pushed_at":"2016-08-19T22:53:15Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":534089,"stargazers_count":16212,"watchers_count":16212,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5200,"mirror_url":null,"open_issues_count":4259,"forks":5200,"open_issues":4259,"watchers":16212,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31039"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/31039"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/31039"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/31039/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31039/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31039/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/37a414c1dab98cc3e6c69d370c41bb96e1fe9b2a"}}}}
{"actor":{"display_login":"dchen1107"}}