{"action":"created","comment":{"url":"https://api.github.com/repos/socrata-platform/tileserver/pulls/comments/86643764","pull_request_review_id":7295286,"id":86643764,"diff_hunk":"@@ -117,7 +145,8 @@ object GeoProvider {\n     // The correct way to fix this would be to implement pagination and render\n     // features ~50k at a time in the carto-renderer and then stitch those\n     // images together.\n-    params + selectParam + whereParam + groupParam - styleKey - overscanKey - mondaraKey\n+    val parameters = params + selectParam + whereParam + groupParam\n+    parameters - styleKey - overscanKey -  rangedColumnKey - rangedColorMinKey -rangedColorMaxKey - mondaraKey","path":"src/main/scala/com.socrata.tileserver/util/GeoProvider.scala","position":81,"original_position":81,"commit_id":"d6581b1d7d17442b837809afadbe97f62baa9787","original_commit_id":"d6581b1d7d17442b837809afadbe97f62baa9787","user":{"login":"kaidamasaki","id":8909021,"avatar_url":"https://avatars.githubusercontent.com/u/8909021?v=3","gravatar_id":"","url":"https://api.github.com/users/kaidamasaki","html_url":"https://github.com/kaidamasaki","followers_url":"https://api.github.com/users/kaidamasaki/followers","following_url":"https://api.github.com/users/kaidamasaki/following{/other_user}","gists_url":"https://api.github.com/users/kaidamasaki/gists{/gist_id}","starred_url":"https://api.github.com/users/kaidamasaki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaidamasaki/subscriptions","organizations_url":"https://api.github.com/users/kaidamasaki/orgs","repos_url":"https://api.github.com/users/kaidamasaki/repos","events_url":"https://api.github.com/users/kaidamasaki/events{/privacy}","received_events_url":"https://api.github.com/users/kaidamasaki/received_events","type":"User","site_admin":false},"body":"Same missing space here.","created_at":"2016-11-04T22:30:52Z","updated_at":"2016-11-04T22:30:52Z","html_url":"https://github.com/socrata-platform/tileserver/pull/70#discussion_r86643764","pull_request_url":"https://api.github.com/repos/socrata-platform/tileserver/pulls/70","_links":{"self":{"href":"https://api.github.com/repos/socrata-platform/tileserver/pulls/comments/86643764"},"html":{"href":"https://github.com/socrata-platform/tileserver/pull/70#discussion_r86643764"},"pull_request":{"href":"https://api.github.com/repos/socrata-platform/tileserver/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/socrata-platform/tileserver/pulls/70","id":92417748,"html_url":"https://github.com/socrata-platform/tileserver/pull/70","diff_url":"https://github.com/socrata-platform/tileserver/pull/70.diff","patch_url":"https://github.com/socrata-platform/tileserver/pull/70.patch","issue_url":"https://api.github.com/repos/socrata-platform/tileserver/issues/70","number":70,"state":"open","locked":false,"title":"Khjrtbrg trey/add color scale","user":{"login":"NathalieKaligirwa","id":13209087,"avatar_url":"https://avatars.githubusercontent.com/u/13209087?v=3","gravatar_id":"","url":"https://api.github.com/users/NathalieKaligirwa","html_url":"https://github.com/NathalieKaligirwa","followers_url":"https://api.github.com/users/NathalieKaligirwa/followers","following_url":"https://api.github.com/users/NathalieKaligirwa/following{/other_user}","gists_url":"https://api.github.com/users/NathalieKaligirwa/gists{/gist_id}","starred_url":"https://api.github.com/users/NathalieKaligirwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NathalieKaligirwa/subscriptions","organizations_url":"https://api.github.com/users/NathalieKaligirwa/orgs","repos_url":"https://api.github.com/users/NathalieKaligirwa/repos","events_url":"https://api.github.com/users/NathalieKaligirwa/events{/privacy}","received_events_url":"https://api.github.com/users/NathalieKaligirwa/received_events","type":"User","site_admin":false},"body":"**using an attribute from the same dataset**\r\n\r\n1. FE sends\r\n```$ranged-color-min=...// min hex color \r\n$ranged-color-max=...//max hex color\r\n$ranged-column=... // column to use from the feature\r\n```\r\n2. If both of these are set, Tileserver gets min and max from BE\r\n\r\n3. Then Tileserver assembles the CartoCSS for the specified attribute and appends the new CartoCSS to any provided styles before passing the styles off to CartoRenderer\r\n\r\n**Notes:** \r\n*using an attribute from another dataset (using a computed column)* :point_left: probably not going to get to this during this hackweek, just thinking ahead\r\n1. FE sends\r\n```$ranged-colors=... // array of hex colors\r\n$ranged-column=... // computed column from dataset to use\r\n$ranged-dataset=... // dataset containing the computed column\r\n$ranged-aggregation-function=... // function to compute the value for each polygon\r\n```\r\n2. If all of these are set, Tileserver gets min and max for the computed column (using `$ranged-column` and `$ranged-dataset`) from BE, calculates the computed value (using `$ranged-aggregation-function`) and adds it as an attribute for each polygon\r\n\r\n3. Then Tileserver assembles the CartoCSS for that attribute and appends the new CartoCSS to any provided styles before passing the styles off to CartoRenderer","created_at":"2016-11-04T21:20:23Z","updated_at":"2016-11-04T22:30:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/socrata-platform/tileserver/pulls/70/commits","review_comments_url":"https://api.github.com/repos/socrata-platform/tileserver/pulls/70/comments","review_comment_url":"https://api.github.com/repos/socrata-platform/tileserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/socrata-platform/tileserver/issues/70/comments","statuses_url":"https://api.github.com/repos/socrata-platform/tileserver/statuses/d6581b1d7d17442b837809afadbe97f62baa9787","head":{"label":"socrata-platform:khjrtbrg-trey/add-color-scale","ref":"khjrtbrg-trey/add-color-scale","sha":"d6581b1d7d17442b837809afadbe97f62baa9787","user":{"login":"socrata-platform","id":12076358,"avatar_url":"https://avatars.githubusercontent.com/u/12076358?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata-platform","html_url":"https://github.com/socrata-platform","followers_url":"https://api.github.com/users/socrata-platform/followers","following_url":"https://api.github.com/users/socrata-platform/following{/other_user}","gists_url":"https://api.github.com/users/socrata-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata-platform/subscriptions","organizations_url":"https://api.github.com/users/socrata-platform/orgs","repos_url":"https://api.github.com/users/socrata-platform/repos","events_url":"https://api.github.com/users/socrata-platform/events{/privacy}","received_events_url":"https://api.github.com/users/socrata-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":26341552,"name":"tileserver","full_name":"socrata-platform/tileserver","owner":{"login":"socrata-platform","id":12076358,"avatar_url":"https://avatars.githubusercontent.com/u/12076358?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata-platform","html_url":"https://github.com/socrata-platform","followers_url":"https://api.github.com/users/socrata-platform/followers","following_url":"https://api.github.com/users/socrata-platform/following{/other_user}","gists_url":"https://api.github.com/users/socrata-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata-platform/subscriptions","organizations_url":"https://api.github.com/users/socrata-platform/orgs","repos_url":"https://api.github.com/users/socrata-platform/repos","events_url":"https://api.github.com/users/socrata-platform/events{/privacy}","received_events_url":"https://api.github.com/users/socrata-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socrata-platform/tileserver","description":null,"fork":false,"url":"https://api.github.com/repos/socrata-platform/tileserver","forks_url":"https://api.github.com/repos/socrata-platform/tileserver/forks","keys_url":"https://api.github.com/repos/socrata-platform/tileserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socrata-platform/tileserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socrata-platform/tileserver/teams","hooks_url":"https://api.github.com/repos/socrata-platform/tileserver/hooks","issue_events_url":"https://api.github.com/repos/socrata-platform/tileserver/issues/events{/number}","events_url":"https://api.github.com/repos/socrata-platform/tileserver/events","assignees_url":"https://api.github.com/repos/socrata-platform/tileserver/assignees{/user}","branches_url":"https://api.github.com/repos/socrata-platform/tileserver/branches{/branch}","tags_url":"https://api.github.com/repos/socrata-platform/tileserver/tags","blobs_url":"https://api.github.com/repos/socrata-platform/tileserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socrata-platform/tileserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socrata-platform/tileserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/socrata-platform/tileserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socrata-platform/tileserver/statuses/{sha}","languages_url":"https://api.github.com/repos/socrata-platform/tileserver/languages","stargazers_url":"https://api.github.com/repos/socrata-platform/tileserver/stargazers","contributors_url":"https://api.github.com/repos/socrata-platform/tileserver/contributors","subscribers_url":"https://api.github.com/repos/socrata-platform/tileserver/subscribers","subscription_url":"https://api.github.com/repos/socrata-platform/tileserver/subscription","commits_url":"https://api.github.com/repos/socrata-platform/tileserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/socrata-platform/tileserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/socrata-platform/tileserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/socrata-platform/tileserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/socrata-platform/tileserver/contents/{+path}","compare_url":"https://api.github.com/repos/socrata-platform/tileserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socrata-platform/tileserver/merges","archive_url":"https://api.github.com/repos/socrata-platform/tileserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socrata-platform/tileserver/downloads","issues_url":"https://api.github.com/repos/socrata-platform/tileserver/issues{/number}","pulls_url":"https://api.github.com/repos/socrata-platform/tileserver/pulls{/number}","milestones_url":"https://api.github.com/repos/socrata-platform/tileserver/milestones{/number}","notifications_url":"https://api.github.com/repos/socrata-platform/tileserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socrata-platform/tileserver/labels{/name}","releases_url":"https://api.github.com/repos/socrata-platform/tileserver/releases{/id}","deployments_url":"https://api.github.com/repos/socrata-platform/tileserver/deployments","created_at":"2014-11-07T22:44:46Z","updated_at":"2016-10-26T21:32:55Z","pushed_at":"2016-11-04T22:05:32Z","git_url":"git://github.com/socrata-platform/tileserver.git","ssh_url":"git@github.com:socrata-platform/tileserver.git","clone_url":"https://github.com/socrata-platform/tileserver.git","svn_url":"https://github.com/socrata-platform/tileserver","homepage":null,"size":594,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"socrata-platform:master","ref":"master","sha":"496992443d8061eb8b2d07beb49a8527c53b5f40","user":{"login":"socrata-platform","id":12076358,"avatar_url":"https://avatars.githubusercontent.com/u/12076358?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata-platform","html_url":"https://github.com/socrata-platform","followers_url":"https://api.github.com/users/socrata-platform/followers","following_url":"https://api.github.com/users/socrata-platform/following{/other_user}","gists_url":"https://api.github.com/users/socrata-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata-platform/subscriptions","organizations_url":"https://api.github.com/users/socrata-platform/orgs","repos_url":"https://api.github.com/users/socrata-platform/repos","events_url":"https://api.github.com/users/socrata-platform/events{/privacy}","received_events_url":"https://api.github.com/users/socrata-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":26341552,"name":"tileserver","full_name":"socrata-platform/tileserver","owner":{"login":"socrata-platform","id":12076358,"avatar_url":"https://avatars.githubusercontent.com/u/12076358?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata-platform","html_url":"https://github.com/socrata-platform","followers_url":"https://api.github.com/users/socrata-platform/followers","following_url":"https://api.github.com/users/socrata-platform/following{/other_user}","gists_url":"https://api.github.com/users/socrata-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata-platform/subscriptions","organizations_url":"https://api.github.com/users/socrata-platform/orgs","repos_url":"https://api.github.com/users/socrata-platform/repos","events_url":"https://api.github.com/users/socrata-platform/events{/privacy}","received_events_url":"https://api.github.com/users/socrata-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socrata-platform/tileserver","description":null,"fork":false,"url":"https://api.github.com/repos/socrata-platform/tileserver","forks_url":"https://api.github.com/repos/socrata-platform/tileserver/forks","keys_url":"https://api.github.com/repos/socrata-platform/tileserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socrata-platform/tileserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socrata-platform/tileserver/teams","hooks_url":"https://api.github.com/repos/socrata-platform/tileserver/hooks","issue_events_url":"https://api.github.com/repos/socrata-platform/tileserver/issues/events{/number}","events_url":"https://api.github.com/repos/socrata-platform/tileserver/events","assignees_url":"https://api.github.com/repos/socrata-platform/tileserver/assignees{/user}","branches_url":"https://api.github.com/repos/socrata-platform/tileserver/branches{/branch}","tags_url":"https://api.github.com/repos/socrata-platform/tileserver/tags","blobs_url":"https://api.github.com/repos/socrata-platform/tileserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socrata-platform/tileserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socrata-platform/tileserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/socrata-platform/tileserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socrata-platform/tileserver/statuses/{sha}","languages_url":"https://api.github.com/repos/socrata-platform/tileserver/languages","stargazers_url":"https://api.github.com/repos/socrata-platform/tileserver/stargazers","contributors_url":"https://api.github.com/repos/socrata-platform/tileserver/contributors","subscribers_url":"https://api.github.com/repos/socrata-platform/tileserver/subscribers","subscription_url":"https://api.github.com/repos/socrata-platform/tileserver/subscription","commits_url":"https://api.github.com/repos/socrata-platform/tileserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/socrata-platform/tileserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/socrata-platform/tileserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/socrata-platform/tileserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/socrata-platform/tileserver/contents/{+path}","compare_url":"https://api.github.com/repos/socrata-platform/tileserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socrata-platform/tileserver/merges","archive_url":"https://api.github.com/repos/socrata-platform/tileserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socrata-platform/tileserver/downloads","issues_url":"https://api.github.com/repos/socrata-platform/tileserver/issues{/number}","pulls_url":"https://api.github.com/repos/socrata-platform/tileserver/pulls{/number}","milestones_url":"https://api.github.com/repos/socrata-platform/tileserver/milestones{/number}","notifications_url":"https://api.github.com/repos/socrata-platform/tileserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socrata-platform/tileserver/labels{/name}","releases_url":"https://api.github.com/repos/socrata-platform/tileserver/releases{/id}","deployments_url":"https://api.github.com/repos/socrata-platform/tileserver/deployments","created_at":"2014-11-07T22:44:46Z","updated_at":"2016-10-26T21:32:55Z","pushed_at":"2016-11-04T22:05:32Z","git_url":"git://github.com/socrata-platform/tileserver.git","ssh_url":"git@github.com:socrata-platform/tileserver.git","clone_url":"https://github.com/socrata-platform/tileserver.git","svn_url":"https://github.com/socrata-platform/tileserver","homepage":null,"size":594,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/socrata-platform/tileserver/pulls/70"},"html":{"href":"https://github.com/socrata-platform/tileserver/pull/70"},"issue":{"href":"https://api.github.com/repos/socrata-platform/tileserver/issues/70"},"comments":{"href":"https://api.github.com/repos/socrata-platform/tileserver/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/socrata-platform/tileserver/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/socrata-platform/tileserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/socrata-platform/tileserver/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/socrata-platform/tileserver/statuses/d6581b1d7d17442b837809afadbe97f62baa9787"}}}}
{"actor":{"display_login":"kaidamasaki"}}