{"action":"created","comment":{"url":"https://api.github.com/repos/ubilabs/node-geobatch/pulls/comments/69883394","id":69883394,"diff_hunk":"@@ -1,4 +1,7 @@\n export default {\n   maxQueriesPerSecond: 50,\n-  minQueriesPerSecond: 1\n+  minQueriesPerSecond: 1,\n+  defaultQueriesPerSecond: 35,","path":"src/defaults.js","position":5,"original_position":5,"commit_id":"6d35c524cd74a4df282f22e734f5b34309e35d28","original_commit_id":"6d35c524cd74a4df282f22e734f5b34309e35d28","user":{"login":"Caerostris","id":728967,"avatar_url":"https://avatars.githubusercontent.com/u/728967?v=3","gravatar_id":"","url":"https://api.github.com/users/Caerostris","html_url":"https://github.com/Caerostris","followers_url":"https://api.github.com/users/Caerostris/followers","following_url":"https://api.github.com/users/Caerostris/following{/other_user}","gists_url":"https://api.github.com/users/Caerostris/gists{/gist_id}","starred_url":"https://api.github.com/users/Caerostris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caerostris/subscriptions","organizations_url":"https://api.github.com/users/Caerostris/orgs","repos_url":"https://api.github.com/users/Caerostris/repos","events_url":"https://api.github.com/users/Caerostris/events{/privacy}","received_events_url":"https://api.github.com/users/Caerostris/received_events","type":"User","site_admin":false},"body":"Ah, right, you mean why the default is 35 and not 50?","created_at":"2016-07-07T10:18:25Z","updated_at":"2016-07-07T10:18:25Z","html_url":"https://github.com/ubilabs/node-geobatch/pull/12#discussion_r69883394","pull_request_url":"https://api.github.com/repos/ubilabs/node-geobatch/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/ubilabs/node-geobatch/pulls/comments/69883394"},"html":{"href":"https://github.com/ubilabs/node-geobatch/pull/12#discussion_r69883394"},"pull_request":{"href":"https://api.github.com/repos/ubilabs/node-geobatch/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/ubilabs/node-geobatch/pulls/12","id":75656781,"html_url":"https://github.com/ubilabs/node-geobatch/pull/12","diff_url":"https://github.com/ubilabs/node-geobatch/pull/12.diff","patch_url":"https://github.com/ubilabs/node-geobatch/pull/12.patch","issue_url":"https://api.github.com/repos/ubilabs/node-geobatch/issues/12","number":12,"state":"open","locked":false,"title":"feat(geocoder): implement parallel processing to leverage full QPS","user":{"login":"Caerostris","id":728967,"avatar_url":"https://avatars.githubusercontent.com/u/728967?v=3","gravatar_id":"","url":"https://api.github.com/users/Caerostris","html_url":"https://github.com/Caerostris","followers_url":"https://api.github.com/users/Caerostris/followers","following_url":"https://api.github.com/users/Caerostris/following{/other_user}","gists_url":"https://api.github.com/users/Caerostris/gists{/gist_id}","starred_url":"https://api.github.com/users/Caerostris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caerostris/subscriptions","organizations_url":"https://api.github.com/users/Caerostris/orgs","repos_url":"https://api.github.com/users/Caerostris/repos","events_url":"https://api.github.com/users/Caerostris/events{/privacy}","received_events_url":"https://api.github.com/users/Caerostris/received_events","type":"User","site_admin":false},"body":"This PR implements parallel processing for the batch geocoder, and thereby increases the effective QPS significantly.\r\nThe implementation of the parallel transform stream has been adapted from [parallel-transform](https://www.npmjs.com/package/parallel-transform) (MIT license).\r\nThe parallel transform code has been re-written in ES6, and was changed to provide an inheritance-based API.\r\nIt might be better to move `parallelTransform.js` into a separate npm package.\r\nI will add test cases & documentation for `parallelTransform.js` if it withstands an initial review.","created_at":"2016-06-29T14:21:01Z","updated_at":"2016-07-07T10:18:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19c02ce2007bcdfd4049ccd20f3ccfa2c812af9b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ubilabs/node-geobatch/pulls/12/commits","review_comments_url":"https://api.github.com/repos/ubilabs/node-geobatch/pulls/12/comments","review_comment_url":"https://api.github.com/repos/ubilabs/node-geobatch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ubilabs/node-geobatch/issues/12/comments","statuses_url":"https://api.github.com/repos/ubilabs/node-geobatch/statuses/6d35c524cd74a4df282f22e734f5b34309e35d28","head":{"label":"Caerostris:performance","ref":"performance","sha":"6d35c524cd74a4df282f22e734f5b34309e35d28","user":{"login":"Caerostris","id":728967,"avatar_url":"https://avatars.githubusercontent.com/u/728967?v=3","gravatar_id":"","url":"https://api.github.com/users/Caerostris","html_url":"https://github.com/Caerostris","followers_url":"https://api.github.com/users/Caerostris/followers","following_url":"https://api.github.com/users/Caerostris/following{/other_user}","gists_url":"https://api.github.com/users/Caerostris/gists{/gist_id}","starred_url":"https://api.github.com/users/Caerostris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caerostris/subscriptions","organizations_url":"https://api.github.com/users/Caerostris/orgs","repos_url":"https://api.github.com/users/Caerostris/repos","events_url":"https://api.github.com/users/Caerostris/events{/privacy}","received_events_url":"https://api.github.com/users/Caerostris/received_events","type":"User","site_admin":false},"repo":{"id":60681433,"name":"node-geobatch","full_name":"Caerostris/node-geobatch","owner":{"login":"Caerostris","id":728967,"avatar_url":"https://avatars.githubusercontent.com/u/728967?v=3","gravatar_id":"","url":"https://api.github.com/users/Caerostris","html_url":"https://github.com/Caerostris","followers_url":"https://api.github.com/users/Caerostris/followers","following_url":"https://api.github.com/users/Caerostris/following{/other_user}","gists_url":"https://api.github.com/users/Caerostris/gists{/gist_id}","starred_url":"https://api.github.com/users/Caerostris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caerostris/subscriptions","organizations_url":"https://api.github.com/users/Caerostris/orgs","repos_url":"https://api.github.com/users/Caerostris/repos","events_url":"https://api.github.com/users/Caerostris/events{/privacy}","received_events_url":"https://api.github.com/users/Caerostris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Caerostris/node-geobatch","description":"Batch geocode addresses from multiple sources.","fork":true,"url":"https://api.github.com/repos/Caerostris/node-geobatch","forks_url":"https://api.github.com/repos/Caerostris/node-geobatch/forks","keys_url":"https://api.github.com/repos/Caerostris/node-geobatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Caerostris/node-geobatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Caerostris/node-geobatch/teams","hooks_url":"https://api.github.com/repos/Caerostris/node-geobatch/hooks","issue_events_url":"https://api.github.com/repos/Caerostris/node-geobatch/issues/events{/number}","events_url":"https://api.github.com/repos/Caerostris/node-geobatch/events","assignees_url":"https://api.github.com/repos/Caerostris/node-geobatch/assignees{/user}","branches_url":"https://api.github.com/repos/Caerostris/node-geobatch/branches{/branch}","tags_url":"https://api.github.com/repos/Caerostris/node-geobatch/tags","blobs_url":"https://api.github.com/repos/Caerostris/node-geobatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Caerostris/node-geobatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Caerostris/node-geobatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/Caerostris/node-geobatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Caerostris/node-geobatch/statuses/{sha}","languages_url":"https://api.github.com/repos/Caerostris/node-geobatch/languages","stargazers_url":"https://api.github.com/repos/Caerostris/node-geobatch/stargazers","contributors_url":"https://api.github.com/repos/Caerostris/node-geobatch/contributors","subscribers_url":"https://api.github.com/repos/Caerostris/node-geobatch/subscribers","subscription_url":"https://api.github.com/repos/Caerostris/node-geobatch/subscription","commits_url":"https://api.github.com/repos/Caerostris/node-geobatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/Caerostris/node-geobatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/Caerostris/node-geobatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/Caerostris/node-geobatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/Caerostris/node-geobatch/contents/{+path}","compare_url":"https://api.github.com/repos/Caerostris/node-geobatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Caerostris/node-geobatch/merges","archive_url":"https://api.github.com/repos/Caerostris/node-geobatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Caerostris/node-geobatch/downloads","issues_url":"https://api.github.com/repos/Caerostris/node-geobatch/issues{/number}","pulls_url":"https://api.github.com/repos/Caerostris/node-geobatch/pulls{/number}","milestones_url":"https://api.github.com/repos/Caerostris/node-geobatch/milestones{/number}","notifications_url":"https://api.github.com/repos/Caerostris/node-geobatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Caerostris/node-geobatch/labels{/name}","releases_url":"https://api.github.com/repos/Caerostris/node-geobatch/releases{/id}","deployments_url":"https://api.github.com/repos/Caerostris/node-geobatch/deployments","created_at":"2016-06-08T08:25:04Z","updated_at":"2016-06-08T08:25:05Z","pushed_at":"2016-07-07T10:02:03Z","git_url":"git://github.com/Caerostris/node-geobatch.git","ssh_url":"git@github.com:Caerostris/node-geobatch.git","clone_url":"https://github.com/Caerostris/node-geobatch.git","svn_url":"https://github.com/Caerostris/node-geobatch","homepage":null,"size":111,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ubilabs:master","ref":"master","sha":"c45e0bfb8b1b132b4ba334dc652b4386bf71d444","user":{"login":"ubilabs","id":50165,"avatar_url":"https://avatars.githubusercontent.com/u/50165?v=3","gravatar_id":"","url":"https://api.github.com/users/ubilabs","html_url":"https://github.com/ubilabs","followers_url":"https://api.github.com/users/ubilabs/followers","following_url":"https://api.github.com/users/ubilabs/following{/other_user}","gists_url":"https://api.github.com/users/ubilabs/gists{/gist_id}","starred_url":"https://api.github.com/users/ubilabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubilabs/subscriptions","organizations_url":"https://api.github.com/users/ubilabs/orgs","repos_url":"https://api.github.com/users/ubilabs/repos","events_url":"https://api.github.com/users/ubilabs/events{/privacy}","received_events_url":"https://api.github.com/users/ubilabs/received_events","type":"Organization","site_admin":false},"repo":{"id":31547189,"name":"node-geobatch","full_name":"ubilabs/node-geobatch","owner":{"login":"ubilabs","id":50165,"avatar_url":"https://avatars.githubusercontent.com/u/50165?v=3","gravatar_id":"","url":"https://api.github.com/users/ubilabs","html_url":"https://github.com/ubilabs","followers_url":"https://api.github.com/users/ubilabs/followers","following_url":"https://api.github.com/users/ubilabs/following{/other_user}","gists_url":"https://api.github.com/users/ubilabs/gists{/gist_id}","starred_url":"https://api.github.com/users/ubilabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubilabs/subscriptions","organizations_url":"https://api.github.com/users/ubilabs/orgs","repos_url":"https://api.github.com/users/ubilabs/repos","events_url":"https://api.github.com/users/ubilabs/events{/privacy}","received_events_url":"https://api.github.com/users/ubilabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubilabs/node-geobatch","description":"Batch geocode addresses from multiple sources.","fork":false,"url":"https://api.github.com/repos/ubilabs/node-geobatch","forks_url":"https://api.github.com/repos/ubilabs/node-geobatch/forks","keys_url":"https://api.github.com/repos/ubilabs/node-geobatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubilabs/node-geobatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubilabs/node-geobatch/teams","hooks_url":"https://api.github.com/repos/ubilabs/node-geobatch/hooks","issue_events_url":"https://api.github.com/repos/ubilabs/node-geobatch/issues/events{/number}","events_url":"https://api.github.com/repos/ubilabs/node-geobatch/events","assignees_url":"https://api.github.com/repos/ubilabs/node-geobatch/assignees{/user}","branches_url":"https://api.github.com/repos/ubilabs/node-geobatch/branches{/branch}","tags_url":"https://api.github.com/repos/ubilabs/node-geobatch/tags","blobs_url":"https://api.github.com/repos/ubilabs/node-geobatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubilabs/node-geobatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubilabs/node-geobatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubilabs/node-geobatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubilabs/node-geobatch/statuses/{sha}","languages_url":"https://api.github.com/repos/ubilabs/node-geobatch/languages","stargazers_url":"https://api.github.com/repos/ubilabs/node-geobatch/stargazers","contributors_url":"https://api.github.com/repos/ubilabs/node-geobatch/contributors","subscribers_url":"https://api.github.com/repos/ubilabs/node-geobatch/subscribers","subscription_url":"https://api.github.com/repos/ubilabs/node-geobatch/subscription","commits_url":"https://api.github.com/repos/ubilabs/node-geobatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubilabs/node-geobatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubilabs/node-geobatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubilabs/node-geobatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubilabs/node-geobatch/contents/{+path}","compare_url":"https://api.github.com/repos/ubilabs/node-geobatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubilabs/node-geobatch/merges","archive_url":"https://api.github.com/repos/ubilabs/node-geobatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubilabs/node-geobatch/downloads","issues_url":"https://api.github.com/repos/ubilabs/node-geobatch/issues{/number}","pulls_url":"https://api.github.com/repos/ubilabs/node-geobatch/pulls{/number}","milestones_url":"https://api.github.com/repos/ubilabs/node-geobatch/milestones{/number}","notifications_url":"https://api.github.com/repos/ubilabs/node-geobatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubilabs/node-geobatch/labels{/name}","releases_url":"https://api.github.com/repos/ubilabs/node-geobatch/releases{/id}","deployments_url":"https://api.github.com/repos/ubilabs/node-geobatch/deployments","created_at":"2015-03-02T15:32:58Z","updated_at":"2016-06-24T13:57:04Z","pushed_at":"2016-07-07T10:02:03Z","git_url":"git://github.com/ubilabs/node-geobatch.git","ssh_url":"git@github.com:ubilabs/node-geobatch.git","clone_url":"https://github.com/ubilabs/node-geobatch.git","svn_url":"https://github.com/ubilabs/node-geobatch","homepage":null,"size":114,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ubilabs/node-geobatch/pulls/12"},"html":{"href":"https://github.com/ubilabs/node-geobatch/pull/12"},"issue":{"href":"https://api.github.com/repos/ubilabs/node-geobatch/issues/12"},"comments":{"href":"https://api.github.com/repos/ubilabs/node-geobatch/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/ubilabs/node-geobatch/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/ubilabs/node-geobatch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ubilabs/node-geobatch/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/ubilabs/node-geobatch/statuses/6d35c524cd74a4df282f22e734f5b34309e35d28"}}}}
{"actor":{"display_login":"Caerostris"}}