{"action":"created","comment":{"url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/comments/70256761","id":70256761,"diff_hunk":"@@ -39,28 +38,40 @@ class RouteGuardFactory implements FactoryInterface, MutableCreationOptionsInter\n     /**\n      * {@inheritDoc}\n      */\n-    public function setCreationOptions(array $options)\n+    public function __construct(array $options = [])\n     {\n         $this->options = $options;\n     }\n \n     /**\n-     * {@inheritDoc}\n+     * @param ContainerInterface $container\n      * @return RouteGuard\n      */\n-    public function createService(ServiceLocatorInterface $serviceLocator)\n+    public function __invoke(ContainerInterface $container)\n     {\n-        $parentLocator = $serviceLocator->getServiceLocator();\n+        if (! method_exists($container, 'build')) { // servicemanager v3","path":"src/ZfcRbac/Factory/RouteGuardFactory.php","position":38,"original_position":38,"commit_id":"aab9b711f5dcb920e790b576b48b4e0ff51aeafd","original_commit_id":"aab9b711f5dcb920e790b576b48b4e0ff51aeafd","user":{"login":"prolic","id":394428,"avatar_url":"https://avatars.githubusercontent.com/u/394428?v=3","gravatar_id":"","url":"https://api.github.com/users/prolic","html_url":"https://github.com/prolic","followers_url":"https://api.github.com/users/prolic/followers","following_url":"https://api.github.com/users/prolic/following{/other_user}","gists_url":"https://api.github.com/users/prolic/gists{/gist_id}","starred_url":"https://api.github.com/users/prolic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prolic/subscriptions","organizations_url":"https://api.github.com/users/prolic/orgs","repos_url":"https://api.github.com/users/prolic/repos","events_url":"https://api.github.com/users/prolic/events{/privacy}","received_events_url":"https://api.github.com/users/prolic/received_events","type":"User","site_admin":false},"body":"good idea.","created_at":"2016-07-11T13:29:40Z","updated_at":"2016-07-11T13:29:41Z","html_url":"https://github.com/ZF-Commons/zfc-rbac/pull/335#discussion_r70256761","pull_request_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/335","_links":{"self":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/comments/70256761"},"html":{"href":"https://github.com/ZF-Commons/zfc-rbac/pull/335#discussion_r70256761"},"pull_request":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/335"}}},"pull_request":{"url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/335","id":74914982,"html_url":"https://github.com/ZF-Commons/zfc-rbac/pull/335","diff_url":"https://github.com/ZF-Commons/zfc-rbac/pull/335.diff","patch_url":"https://github.com/ZF-Commons/zfc-rbac/pull/335.patch","issue_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/issues/335","number":335,"state":"open","locked":false,"title":"allow zf3","user":{"login":"prolic","id":394428,"avatar_url":"https://avatars.githubusercontent.com/u/394428?v=3","gravatar_id":"","url":"https://api.github.com/users/prolic","html_url":"https://github.com/prolic","followers_url":"https://api.github.com/users/prolic/followers","following_url":"https://api.github.com/users/prolic/following{/other_user}","gists_url":"https://api.github.com/users/prolic/gists{/gist_id}","starred_url":"https://api.github.com/users/prolic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prolic/subscriptions","organizations_url":"https://api.github.com/users/prolic/orgs","repos_url":"https://api.github.com/users/prolic/repos","events_url":"https://api.github.com/users/prolic/events{/privacy}","received_events_url":"https://api.github.com/users/prolic/received_events","type":"User","site_admin":false},"body":"* Allow Zend-MVC 3.0 in composer\r\n* Allow Zend-Servicemanager 3.0 in composer\r\n* Allow Zend\\Eventmanager 3.0 in composer\r\n* Update to ZendDeveloperTools 1.1 in composer\r\n* Update to DoctrineModule 1.1 in composer\r\n* Update to DoctrineORMModule 0.11 in composer\r\n* drop support of PHP 5.4 & 5.5\r\n* allow PHP 7","created_at":"2016-06-23T08:33:16Z","updated_at":"2016-07-11T13:29:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdded71c017e10629466a41b6a1804dd481cf778","assignee":{"login":"danizord","id":1850941,"avatar_url":"https://avatars.githubusercontent.com/u/1850941?v=3","gravatar_id":"","url":"https://api.github.com/users/danizord","html_url":"https://github.com/danizord","followers_url":"https://api.github.com/users/danizord/followers","following_url":"https://api.github.com/users/danizord/following{/other_user}","gists_url":"https://api.github.com/users/danizord/gists{/gist_id}","starred_url":"https://api.github.com/users/danizord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danizord/subscriptions","organizations_url":"https://api.github.com/users/danizord/orgs","repos_url":"https://api.github.com/users/danizord/repos","events_url":"https://api.github.com/users/danizord/events{/privacy}","received_events_url":"https://api.github.com/users/danizord/received_events","type":"User","site_admin":false},"assignees":[{"login":"danizord","id":1850941,"avatar_url":"https://avatars.githubusercontent.com/u/1850941?v=3","gravatar_id":"","url":"https://api.github.com/users/danizord","html_url":"https://github.com/danizord","followers_url":"https://api.github.com/users/danizord/followers","following_url":"https://api.github.com/users/danizord/following{/other_user}","gists_url":"https://api.github.com/users/danizord/gists{/gist_id}","starred_url":"https://api.github.com/users/danizord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danizord/subscriptions","organizations_url":"https://api.github.com/users/danizord/orgs","repos_url":"https://api.github.com/users/danizord/repos","events_url":"https://api.github.com/users/danizord/events{/privacy}","received_events_url":"https://api.github.com/users/danizord/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/335/commits","review_comments_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/335/comments","review_comment_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/issues/335/comments","statuses_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/statuses/aab9b711f5dcb920e790b576b48b4e0ff51aeafd","head":{"label":"prolic:zf3","ref":"zf3","sha":"aab9b711f5dcb920e790b576b48b4e0ff51aeafd","user":{"login":"prolic","id":394428,"avatar_url":"https://avatars.githubusercontent.com/u/394428?v=3","gravatar_id":"","url":"https://api.github.com/users/prolic","html_url":"https://github.com/prolic","followers_url":"https://api.github.com/users/prolic/followers","following_url":"https://api.github.com/users/prolic/following{/other_user}","gists_url":"https://api.github.com/users/prolic/gists{/gist_id}","starred_url":"https://api.github.com/users/prolic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prolic/subscriptions","organizations_url":"https://api.github.com/users/prolic/orgs","repos_url":"https://api.github.com/users/prolic/repos","events_url":"https://api.github.com/users/prolic/events{/privacy}","received_events_url":"https://api.github.com/users/prolic/received_events","type":"User","site_admin":false},"repo":{"id":61787540,"name":"zfc-rbac","full_name":"prolic/zfc-rbac","owner":{"login":"prolic","id":394428,"avatar_url":"https://avatars.githubusercontent.com/u/394428?v=3","gravatar_id":"","url":"https://api.github.com/users/prolic","html_url":"https://github.com/prolic","followers_url":"https://api.github.com/users/prolic/followers","following_url":"https://api.github.com/users/prolic/following{/other_user}","gists_url":"https://api.github.com/users/prolic/gists{/gist_id}","starred_url":"https://api.github.com/users/prolic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prolic/subscriptions","organizations_url":"https://api.github.com/users/prolic/orgs","repos_url":"https://api.github.com/users/prolic/repos","events_url":"https://api.github.com/users/prolic/events{/privacy}","received_events_url":"https://api.github.com/users/prolic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prolic/zfc-rbac","description":"Role-based access control module to provide additional features on top of Zend\\Permissions\\Rbac","fork":true,"url":"https://api.github.com/repos/prolic/zfc-rbac","forks_url":"https://api.github.com/repos/prolic/zfc-rbac/forks","keys_url":"https://api.github.com/repos/prolic/zfc-rbac/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prolic/zfc-rbac/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prolic/zfc-rbac/teams","hooks_url":"https://api.github.com/repos/prolic/zfc-rbac/hooks","issue_events_url":"https://api.github.com/repos/prolic/zfc-rbac/issues/events{/number}","events_url":"https://api.github.com/repos/prolic/zfc-rbac/events","assignees_url":"https://api.github.com/repos/prolic/zfc-rbac/assignees{/user}","branches_url":"https://api.github.com/repos/prolic/zfc-rbac/branches{/branch}","tags_url":"https://api.github.com/repos/prolic/zfc-rbac/tags","blobs_url":"https://api.github.com/repos/prolic/zfc-rbac/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prolic/zfc-rbac/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prolic/zfc-rbac/git/refs{/sha}","trees_url":"https://api.github.com/repos/prolic/zfc-rbac/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prolic/zfc-rbac/statuses/{sha}","languages_url":"https://api.github.com/repos/prolic/zfc-rbac/languages","stargazers_url":"https://api.github.com/repos/prolic/zfc-rbac/stargazers","contributors_url":"https://api.github.com/repos/prolic/zfc-rbac/contributors","subscribers_url":"https://api.github.com/repos/prolic/zfc-rbac/subscribers","subscription_url":"https://api.github.com/repos/prolic/zfc-rbac/subscription","commits_url":"https://api.github.com/repos/prolic/zfc-rbac/commits{/sha}","git_commits_url":"https://api.github.com/repos/prolic/zfc-rbac/git/commits{/sha}","comments_url":"https://api.github.com/repos/prolic/zfc-rbac/comments{/number}","issue_comment_url":"https://api.github.com/repos/prolic/zfc-rbac/issues/comments{/number}","contents_url":"https://api.github.com/repos/prolic/zfc-rbac/contents/{+path}","compare_url":"https://api.github.com/repos/prolic/zfc-rbac/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prolic/zfc-rbac/merges","archive_url":"https://api.github.com/repos/prolic/zfc-rbac/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prolic/zfc-rbac/downloads","issues_url":"https://api.github.com/repos/prolic/zfc-rbac/issues{/number}","pulls_url":"https://api.github.com/repos/prolic/zfc-rbac/pulls{/number}","milestones_url":"https://api.github.com/repos/prolic/zfc-rbac/milestones{/number}","notifications_url":"https://api.github.com/repos/prolic/zfc-rbac/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prolic/zfc-rbac/labels{/name}","releases_url":"https://api.github.com/repos/prolic/zfc-rbac/releases{/id}","deployments_url":"https://api.github.com/repos/prolic/zfc-rbac/deployments","created_at":"2016-06-23T08:16:05Z","updated_at":"2016-06-23T08:16:06Z","pushed_at":"2016-07-08T14:54:07Z","git_url":"git://github.com/prolic/zfc-rbac.git","ssh_url":"git@github.com:prolic/zfc-rbac.git","clone_url":"https://github.com/prolic/zfc-rbac.git","svn_url":"https://github.com/prolic/zfc-rbac","homepage":"","size":1349,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ZF-Commons:master","ref":"master","sha":"4937bc4c5a86eed62323d5baf221fda3d9eb1c71","user":{"login":"ZF-Commons","id":1313211,"avatar_url":"https://avatars.githubusercontent.com/u/1313211?v=3","gravatar_id":"","url":"https://api.github.com/users/ZF-Commons","html_url":"https://github.com/ZF-Commons","followers_url":"https://api.github.com/users/ZF-Commons/followers","following_url":"https://api.github.com/users/ZF-Commons/following{/other_user}","gists_url":"https://api.github.com/users/ZF-Commons/gists{/gist_id}","starred_url":"https://api.github.com/users/ZF-Commons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZF-Commons/subscriptions","organizations_url":"https://api.github.com/users/ZF-Commons/orgs","repos_url":"https://api.github.com/users/ZF-Commons/repos","events_url":"https://api.github.com/users/ZF-Commons/events{/privacy}","received_events_url":"https://api.github.com/users/ZF-Commons/received_events","type":"Organization","site_admin":false},"repo":{"id":6282379,"name":"zfc-rbac","full_name":"ZF-Commons/zfc-rbac","owner":{"login":"ZF-Commons","id":1313211,"avatar_url":"https://avatars.githubusercontent.com/u/1313211?v=3","gravatar_id":"","url":"https://api.github.com/users/ZF-Commons","html_url":"https://github.com/ZF-Commons","followers_url":"https://api.github.com/users/ZF-Commons/followers","following_url":"https://api.github.com/users/ZF-Commons/following{/other_user}","gists_url":"https://api.github.com/users/ZF-Commons/gists{/gist_id}","starred_url":"https://api.github.com/users/ZF-Commons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZF-Commons/subscriptions","organizations_url":"https://api.github.com/users/ZF-Commons/orgs","repos_url":"https://api.github.com/users/ZF-Commons/repos","events_url":"https://api.github.com/users/ZF-Commons/events{/privacy}","received_events_url":"https://api.github.com/users/ZF-Commons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ZF-Commons/zfc-rbac","description":"Role-based access control module to provide additional features on top of Zend\\Permissions\\Rbac","fork":false,"url":"https://api.github.com/repos/ZF-Commons/zfc-rbac","forks_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/forks","keys_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/teams","hooks_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/hooks","issue_events_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/issues/events{/number}","events_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/events","assignees_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/assignees{/user}","branches_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/branches{/branch}","tags_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/tags","blobs_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/statuses/{sha}","languages_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/languages","stargazers_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/stargazers","contributors_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/contributors","subscribers_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/subscribers","subscription_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/subscription","commits_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/contents/{+path}","compare_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/merges","archive_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/downloads","issues_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/issues{/number}","pulls_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls{/number}","milestones_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/milestones{/number}","notifications_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/labels{/name}","releases_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/releases{/id}","deployments_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/deployments","created_at":"2012-10-18T17:07:13Z","updated_at":"2016-07-05T22:47:26Z","pushed_at":"2016-07-08T14:54:08Z","git_url":"git://github.com/ZF-Commons/zfc-rbac.git","ssh_url":"git@github.com:ZF-Commons/zfc-rbac.git","clone_url":"https://github.com/ZF-Commons/zfc-rbac.git","svn_url":"https://github.com/ZF-Commons/zfc-rbac","homepage":"","size":1487,"stargazers_count":172,"watchers_count":172,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":116,"mirror_url":null,"open_issues_count":32,"forks":116,"open_issues":32,"watchers":172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/335"},"html":{"href":"https://github.com/ZF-Commons/zfc-rbac/pull/335"},"issue":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/issues/335"},"comments":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/issues/335/comments"},"review_comments":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/335/comments"},"review_comment":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/335/commits"},"statuses":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/statuses/aab9b711f5dcb920e790b576b48b4e0ff51aeafd"}}}}
{"actor":{"display_login":"prolic"}}