{"action":"created","comment":{"url":"https://api.github.com/repos/spotify/helios/pulls/comments/92716068","pull_request_review_id":13237477,"id":92716068,"diff_hunk":"@@ -150,7 +150,7 @@ public JobValidator(final boolean shouldValidateJobHash,\n         errors.add(\"Volume path is not absolute: \" + path);\n         continue;\n       }\n-      if (!isNullOrEmpty(source) && !source.startsWith(\"/\")) {\n+      if (isNullOrEmpty(source) && !source.startsWith(\"/\")) {","path":"helios-client/src/main/java/com/spotify/helios/common/JobValidator.java","position":5,"original_position":5,"commit_id":"6f47ce9a6a82da579cf4bc5e81dea8ff8ae63cf2","original_commit_id":"6f47ce9a6a82da579cf4bc5e81dea8ff8ae63cf2","user":{"login":"rohansingh","id":615175,"avatar_url":"https://avatars.githubusercontent.com/u/615175?v=3","gravatar_id":"","url":"https://api.github.com/users/rohansingh","html_url":"https://github.com/rohansingh","followers_url":"https://api.github.com/users/rohansingh/followers","following_url":"https://api.github.com/users/rohansingh/following{/other_user}","gists_url":"https://api.github.com/users/rohansingh/gists{/gist_id}","starred_url":"https://api.github.com/users/rohansingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohansingh/subscriptions","organizations_url":"https://api.github.com/users/rohansingh/orgs","repos_url":"https://api.github.com/users/rohansingh/repos","events_url":"https://api.github.com/users/rohansingh/events{/privacy}","received_events_url":"https://api.github.com/users/rohansingh/received_events","type":"User","site_admin":false},"body":"Are you sure this logic wasn't correct before? Wouldn't this now throw an NPE if `source` is null?","created_at":"2016-12-15T22:40:19Z","updated_at":"2016-12-15T22:40:19Z","html_url":"https://github.com/spotify/helios/pull/1044#discussion_r92716068","pull_request_url":"https://api.github.com/repos/spotify/helios/pulls/1044","_links":{"self":{"href":"https://api.github.com/repos/spotify/helios/pulls/comments/92716068"},"html":{"href":"https://github.com/spotify/helios/pull/1044#discussion_r92716068"},"pull_request":{"href":"https://api.github.com/repos/spotify/helios/pulls/1044"}}},"pull_request":{"url":"https://api.github.com/repos/spotify/helios/pulls/1044","id":98189477,"html_url":"https://github.com/spotify/helios/pull/1044","diff_url":"https://github.com/spotify/helios/pull/1044.diff","patch_url":"https://github.com/spotify/helios/pull/1044.patch","issue_url":"https://api.github.com/repos/spotify/helios/issues/1044","number":1044,"state":"open","locked":false,"title":"Fixed check for volume source being null or empty","user":{"login":"piccobit","id":5782817,"avatar_url":"https://avatars.githubusercontent.com/u/5782817?v=3","gravatar_id":"","url":"https://api.github.com/users/piccobit","html_url":"https://github.com/piccobit","followers_url":"https://api.github.com/users/piccobit/followers","following_url":"https://api.github.com/users/piccobit/following{/other_user}","gists_url":"https://api.github.com/users/piccobit/gists{/gist_id}","starred_url":"https://api.github.com/users/piccobit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piccobit/subscriptions","organizations_url":"https://api.github.com/users/piccobit/orgs","repos_url":"https://api.github.com/users/piccobit/repos","events_url":"https://api.github.com/users/piccobit/events{/privacy}","received_events_url":"https://api.github.com/users/piccobit/received_events","type":"User","site_admin":false},"body":"This bug was hidden by the second condition which is normally always false and was only discovered when I disabled the second condition to allow the usage of named volumes which don't start with a '/'.","created_at":"2016-12-15T16:56:59Z","updated_at":"2016-12-15T22:40:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae3793e65c4da5a3e17869b09ee6530aca8f790c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spotify/helios/pulls/1044/commits","review_comments_url":"https://api.github.com/repos/spotify/helios/pulls/1044/comments","review_comment_url":"https://api.github.com/repos/spotify/helios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spotify/helios/issues/1044/comments","statuses_url":"https://api.github.com/repos/spotify/helios/statuses/6f47ce9a6a82da579cf4bc5e81dea8ff8ae63cf2","head":{"label":"piccobit:master","ref":"master","sha":"6f47ce9a6a82da579cf4bc5e81dea8ff8ae63cf2","user":{"login":"piccobit","id":5782817,"avatar_url":"https://avatars.githubusercontent.com/u/5782817?v=3","gravatar_id":"","url":"https://api.github.com/users/piccobit","html_url":"https://github.com/piccobit","followers_url":"https://api.github.com/users/piccobit/followers","following_url":"https://api.github.com/users/piccobit/following{/other_user}","gists_url":"https://api.github.com/users/piccobit/gists{/gist_id}","starred_url":"https://api.github.com/users/piccobit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piccobit/subscriptions","organizations_url":"https://api.github.com/users/piccobit/orgs","repos_url":"https://api.github.com/users/piccobit/repos","events_url":"https://api.github.com/users/piccobit/events{/privacy}","received_events_url":"https://api.github.com/users/piccobit/received_events","type":"User","site_admin":false},"repo":{"id":76577808,"name":"helios","full_name":"piccobit/helios","owner":{"login":"piccobit","id":5782817,"avatar_url":"https://avatars.githubusercontent.com/u/5782817?v=3","gravatar_id":"","url":"https://api.github.com/users/piccobit","html_url":"https://github.com/piccobit","followers_url":"https://api.github.com/users/piccobit/followers","following_url":"https://api.github.com/users/piccobit/following{/other_user}","gists_url":"https://api.github.com/users/piccobit/gists{/gist_id}","starred_url":"https://api.github.com/users/piccobit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piccobit/subscriptions","organizations_url":"https://api.github.com/users/piccobit/orgs","repos_url":"https://api.github.com/users/piccobit/repos","events_url":"https://api.github.com/users/piccobit/events{/privacy}","received_events_url":"https://api.github.com/users/piccobit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/piccobit/helios","description":"Docker container orchestration platform","fork":true,"url":"https://api.github.com/repos/piccobit/helios","forks_url":"https://api.github.com/repos/piccobit/helios/forks","keys_url":"https://api.github.com/repos/piccobit/helios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/piccobit/helios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/piccobit/helios/teams","hooks_url":"https://api.github.com/repos/piccobit/helios/hooks","issue_events_url":"https://api.github.com/repos/piccobit/helios/issues/events{/number}","events_url":"https://api.github.com/repos/piccobit/helios/events","assignees_url":"https://api.github.com/repos/piccobit/helios/assignees{/user}","branches_url":"https://api.github.com/repos/piccobit/helios/branches{/branch}","tags_url":"https://api.github.com/repos/piccobit/helios/tags","blobs_url":"https://api.github.com/repos/piccobit/helios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/piccobit/helios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/piccobit/helios/git/refs{/sha}","trees_url":"https://api.github.com/repos/piccobit/helios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/piccobit/helios/statuses/{sha}","languages_url":"https://api.github.com/repos/piccobit/helios/languages","stargazers_url":"https://api.github.com/repos/piccobit/helios/stargazers","contributors_url":"https://api.github.com/repos/piccobit/helios/contributors","subscribers_url":"https://api.github.com/repos/piccobit/helios/subscribers","subscription_url":"https://api.github.com/repos/piccobit/helios/subscription","commits_url":"https://api.github.com/repos/piccobit/helios/commits{/sha}","git_commits_url":"https://api.github.com/repos/piccobit/helios/git/commits{/sha}","comments_url":"https://api.github.com/repos/piccobit/helios/comments{/number}","issue_comment_url":"https://api.github.com/repos/piccobit/helios/issues/comments{/number}","contents_url":"https://api.github.com/repos/piccobit/helios/contents/{+path}","compare_url":"https://api.github.com/repos/piccobit/helios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/piccobit/helios/merges","archive_url":"https://api.github.com/repos/piccobit/helios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/piccobit/helios/downloads","issues_url":"https://api.github.com/repos/piccobit/helios/issues{/number}","pulls_url":"https://api.github.com/repos/piccobit/helios/pulls{/number}","milestones_url":"https://api.github.com/repos/piccobit/helios/milestones{/number}","notifications_url":"https://api.github.com/repos/piccobit/helios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/piccobit/helios/labels{/name}","releases_url":"https://api.github.com/repos/piccobit/helios/releases{/id}","deployments_url":"https://api.github.com/repos/piccobit/helios/deployments","created_at":"2016-12-15T16:44:06Z","updated_at":"2016-12-15T16:44:09Z","pushed_at":"2016-12-15T16:53:34Z","git_url":"git://github.com/piccobit/helios.git","ssh_url":"git@github.com:piccobit/helios.git","clone_url":"https://github.com/piccobit/helios.git","svn_url":"https://github.com/piccobit/helios","homepage":null,"size":7069,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spotify:master","ref":"master","sha":"049d2858a1247f200b1a980ec4f7c9d59c42d97f","user":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":20171642,"name":"helios","full_name":"spotify/helios","owner":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/helios","description":"Docker container orchestration platform","fork":false,"url":"https://api.github.com/repos/spotify/helios","forks_url":"https://api.github.com/repos/spotify/helios/forks","keys_url":"https://api.github.com/repos/spotify/helios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/helios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/helios/teams","hooks_url":"https://api.github.com/repos/spotify/helios/hooks","issue_events_url":"https://api.github.com/repos/spotify/helios/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/helios/events","assignees_url":"https://api.github.com/repos/spotify/helios/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/helios/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/helios/tags","blobs_url":"https://api.github.com/repos/spotify/helios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/helios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/helios/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/helios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/helios/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/helios/languages","stargazers_url":"https://api.github.com/repos/spotify/helios/stargazers","contributors_url":"https://api.github.com/repos/spotify/helios/contributors","subscribers_url":"https://api.github.com/repos/spotify/helios/subscribers","subscription_url":"https://api.github.com/repos/spotify/helios/subscription","commits_url":"https://api.github.com/repos/spotify/helios/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/helios/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/helios/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/helios/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/helios/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/helios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/helios/merges","archive_url":"https://api.github.com/repos/spotify/helios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/helios/downloads","issues_url":"https://api.github.com/repos/spotify/helios/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/helios/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/helios/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/helios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/helios/labels{/name}","releases_url":"https://api.github.com/repos/spotify/helios/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/helios/deployments","created_at":"2014-05-26T02:29:06Z","updated_at":"2016-12-15T18:53:09Z","pushed_at":"2016-12-15T16:56:59Z","git_url":"git://github.com/spotify/helios.git","ssh_url":"git@github.com:spotify/helios.git","clone_url":"https://github.com/spotify/helios.git","svn_url":"https://github.com/spotify/helios","homepage":null,"size":7068,"stargazers_count":1627,"watchers_count":1627,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":148,"mirror_url":null,"open_issues_count":28,"forks":148,"open_issues":28,"watchers":1627,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spotify/helios/pulls/1044"},"html":{"href":"https://github.com/spotify/helios/pull/1044"},"issue":{"href":"https://api.github.com/repos/spotify/helios/issues/1044"},"comments":{"href":"https://api.github.com/repos/spotify/helios/issues/1044/comments"},"review_comments":{"href":"https://api.github.com/repos/spotify/helios/pulls/1044/comments"},"review_comment":{"href":"https://api.github.com/repos/spotify/helios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spotify/helios/pulls/1044/commits"},"statuses":{"href":"https://api.github.com/repos/spotify/helios/statuses/6f47ce9a6a82da579cf4bc5e81dea8ff8ae63cf2"}}}}
{"actor":{"display_login":"rohansingh"}}