{"action":"created","comment":{"url":"https://api.github.com/repos/vtex-apps/login/pulls/comments/65094077","id":65094077,"diff_hunk":"@@ -23,21 +23,21 @@ class Login extends React.Component {\n     setTimeout(() => LoginActions.verifyLogin());\n   }\n \n+\n   onChange = (LoginStore) => {\n-    const logged = LoginStore.get('logged');\n-    const error = LoginStore.get('error');\n+    let logged = LoginStore.get('logged');\n+    let error = LoginStore.get('error');\n+    let isLoginOpen = this.state.isLoginOpen;\n+    if (logged){\n+      isLoginOpen = false;\n+      error = '';\n+    }\n     if (logged != this.state.logged || error != this.state.error){","path":"src/components/Login/Login.js","position":15,"original_position":15,"commit_id":"f29e21e68340b3e0f0bf3f889331a18cb9bf2aab","original_commit_id":"f29e21e68340b3e0f0bf3f889331a18cb9bf2aab","user":{"login":"tamorim","id":5040487,"avatar_url":"https://avatars.githubusercontent.com/u/5040487?v=3","gravatar_id":"","url":"https://api.github.com/users/tamorim","html_url":"https://github.com/tamorim","followers_url":"https://api.github.com/users/tamorim/followers","following_url":"https://api.github.com/users/tamorim/following{/other_user}","gists_url":"https://api.github.com/users/tamorim/gists{/gist_id}","starred_url":"https://api.github.com/users/tamorim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamorim/subscriptions","organizations_url":"https://api.github.com/users/tamorim/orgs","repos_url":"https://api.github.com/users/tamorim/repos","events_url":"https://api.github.com/users/tamorim/events{/privacy}","received_events_url":"https://api.github.com/users/tamorim/received_events","type":"User","site_admin":false},"body":"@gkozlowaski Always use strict equality operatos, `===` and `!==`.","created_at":"2016-05-30T17:17:37Z","updated_at":"2016-05-30T17:17:37Z","html_url":"https://github.com/vtex-apps/login/pull/3#discussion_r65094077","pull_request_url":"https://api.github.com/repos/vtex-apps/login/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/vtex-apps/login/pulls/comments/65094077"},"html":{"href":"https://github.com/vtex-apps/login/pull/3#discussion_r65094077"},"pull_request":{"href":"https://api.github.com/repos/vtex-apps/login/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/vtex-apps/login/pulls/3","id":71766978,"html_url":"https://github.com/vtex-apps/login/pull/3","diff_url":"https://github.com/vtex-apps/login/pull/3.diff","patch_url":"https://github.com/vtex-apps/login/pull/3.patch","issue_url":"https://api.github.com/repos/vtex-apps/login/issues/3","number":3,"state":"open","locked":false,"title":"Implement login by access key","user":{"login":"gkozlowaski","id":5442132,"avatar_url":"https://avatars.githubusercontent.com/u/5442132?v=3","gravatar_id":"","url":"https://api.github.com/users/gkozlowaski","html_url":"https://github.com/gkozlowaski","followers_url":"https://api.github.com/users/gkozlowaski/followers","following_url":"https://api.github.com/users/gkozlowaski/following{/other_user}","gists_url":"https://api.github.com/users/gkozlowaski/gists{/gist_id}","starred_url":"https://api.github.com/users/gkozlowaski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkozlowaski/subscriptions","organizations_url":"https://api.github.com/users/gkozlowaski/orgs","repos_url":"https://api.github.com/users/gkozlowaski/repos","events_url":"https://api.github.com/users/gkozlowaski/events{/privacy}","received_events_url":"https://api.github.com/users/gkozlowaski/received_events","type":"User","site_admin":false},"body":"Removed login by email and password since most of the costumers didn't had a password in the first place, and implemented login by access key.\r\nThis is just a temporary fix for login, while the new vtex id ui isn't ready.","created_at":"2016-05-27T20:14:37Z","updated_at":"2016-05-30T17:17:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"447f59eef62363ddb42f666b16564e7058aa258b","assignee":{"login":"tamorim","id":5040487,"avatar_url":"https://avatars.githubusercontent.com/u/5040487?v=3","gravatar_id":"","url":"https://api.github.com/users/tamorim","html_url":"https://github.com/tamorim","followers_url":"https://api.github.com/users/tamorim/followers","following_url":"https://api.github.com/users/tamorim/following{/other_user}","gists_url":"https://api.github.com/users/tamorim/gists{/gist_id}","starred_url":"https://api.github.com/users/tamorim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamorim/subscriptions","organizations_url":"https://api.github.com/users/tamorim/orgs","repos_url":"https://api.github.com/users/tamorim/repos","events_url":"https://api.github.com/users/tamorim/events{/privacy}","received_events_url":"https://api.github.com/users/tamorim/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/vtex-apps/login/pulls/3/commits","review_comments_url":"https://api.github.com/repos/vtex-apps/login/pulls/3/comments","review_comment_url":"https://api.github.com/repos/vtex-apps/login/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vtex-apps/login/issues/3/comments","statuses_url":"https://api.github.com/repos/vtex-apps/login/statuses/f29e21e68340b3e0f0bf3f889331a18cb9bf2aab","head":{"label":"vtex-apps:feature/access-key","ref":"feature/access-key","sha":"f29e21e68340b3e0f0bf3f889331a18cb9bf2aab","user":{"login":"vtex-apps","id":12614072,"avatar_url":"https://avatars.githubusercontent.com/u/12614072?v=3","gravatar_id":"","url":"https://api.github.com/users/vtex-apps","html_url":"https://github.com/vtex-apps","followers_url":"https://api.github.com/users/vtex-apps/followers","following_url":"https://api.github.com/users/vtex-apps/following{/other_user}","gists_url":"https://api.github.com/users/vtex-apps/gists{/gist_id}","starred_url":"https://api.github.com/users/vtex-apps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtex-apps/subscriptions","organizations_url":"https://api.github.com/users/vtex-apps/orgs","repos_url":"https://api.github.com/users/vtex-apps/repos","events_url":"https://api.github.com/users/vtex-apps/events{/privacy}","received_events_url":"https://api.github.com/users/vtex-apps/received_events","type":"Organization","site_admin":false},"repo":{"id":57252484,"name":"login","full_name":"vtex-apps/login","owner":{"login":"vtex-apps","id":12614072,"avatar_url":"https://avatars.githubusercontent.com/u/12614072?v=3","gravatar_id":"","url":"https://api.github.com/users/vtex-apps","html_url":"https://github.com/vtex-apps","followers_url":"https://api.github.com/users/vtex-apps/followers","following_url":"https://api.github.com/users/vtex-apps/following{/other_user}","gists_url":"https://api.github.com/users/vtex-apps/gists{/gist_id}","starred_url":"https://api.github.com/users/vtex-apps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtex-apps/subscriptions","organizations_url":"https://api.github.com/users/vtex-apps/orgs","repos_url":"https://api.github.com/users/vtex-apps/repos","events_url":"https://api.github.com/users/vtex-apps/events{/privacy}","received_events_url":"https://api.github.com/users/vtex-apps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vtex-apps/login","description":"Login component","fork":false,"url":"https://api.github.com/repos/vtex-apps/login","forks_url":"https://api.github.com/repos/vtex-apps/login/forks","keys_url":"https://api.github.com/repos/vtex-apps/login/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vtex-apps/login/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vtex-apps/login/teams","hooks_url":"https://api.github.com/repos/vtex-apps/login/hooks","issue_events_url":"https://api.github.com/repos/vtex-apps/login/issues/events{/number}","events_url":"https://api.github.com/repos/vtex-apps/login/events","assignees_url":"https://api.github.com/repos/vtex-apps/login/assignees{/user}","branches_url":"https://api.github.com/repos/vtex-apps/login/branches{/branch}","tags_url":"https://api.github.com/repos/vtex-apps/login/tags","blobs_url":"https://api.github.com/repos/vtex-apps/login/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vtex-apps/login/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vtex-apps/login/git/refs{/sha}","trees_url":"https://api.github.com/repos/vtex-apps/login/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vtex-apps/login/statuses/{sha}","languages_url":"https://api.github.com/repos/vtex-apps/login/languages","stargazers_url":"https://api.github.com/repos/vtex-apps/login/stargazers","contributors_url":"https://api.github.com/repos/vtex-apps/login/contributors","subscribers_url":"https://api.github.com/repos/vtex-apps/login/subscribers","subscription_url":"https://api.github.com/repos/vtex-apps/login/subscription","commits_url":"https://api.github.com/repos/vtex-apps/login/commits{/sha}","git_commits_url":"https://api.github.com/repos/vtex-apps/login/git/commits{/sha}","comments_url":"https://api.github.com/repos/vtex-apps/login/comments{/number}","issue_comment_url":"https://api.github.com/repos/vtex-apps/login/issues/comments{/number}","contents_url":"https://api.github.com/repos/vtex-apps/login/contents/{+path}","compare_url":"https://api.github.com/repos/vtex-apps/login/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vtex-apps/login/merges","archive_url":"https://api.github.com/repos/vtex-apps/login/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vtex-apps/login/downloads","issues_url":"https://api.github.com/repos/vtex-apps/login/issues{/number}","pulls_url":"https://api.github.com/repos/vtex-apps/login/pulls{/number}","milestones_url":"https://api.github.com/repos/vtex-apps/login/milestones{/number}","notifications_url":"https://api.github.com/repos/vtex-apps/login/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vtex-apps/login/labels{/name}","releases_url":"https://api.github.com/repos/vtex-apps/login/releases{/id}","deployments_url":"https://api.github.com/repos/vtex-apps/login/deployments","created_at":"2016-04-27T22:16:42Z","updated_at":"2016-04-27T22:28:13Z","pushed_at":"2016-05-27T20:14:37Z","git_url":"git://github.com/vtex-apps/login.git","ssh_url":"git@github.com:vtex-apps/login.git","clone_url":"https://github.com/vtex-apps/login.git","svn_url":"https://github.com/vtex-apps/login","homepage":null,"size":25,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"vtex-apps:master","ref":"master","sha":"25f9b56024e501cbdc132fbafd4ddc339b9fe330","user":{"login":"vtex-apps","id":12614072,"avatar_url":"https://avatars.githubusercontent.com/u/12614072?v=3","gravatar_id":"","url":"https://api.github.com/users/vtex-apps","html_url":"https://github.com/vtex-apps","followers_url":"https://api.github.com/users/vtex-apps/followers","following_url":"https://api.github.com/users/vtex-apps/following{/other_user}","gists_url":"https://api.github.com/users/vtex-apps/gists{/gist_id}","starred_url":"https://api.github.com/users/vtex-apps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtex-apps/subscriptions","organizations_url":"https://api.github.com/users/vtex-apps/orgs","repos_url":"https://api.github.com/users/vtex-apps/repos","events_url":"https://api.github.com/users/vtex-apps/events{/privacy}","received_events_url":"https://api.github.com/users/vtex-apps/received_events","type":"Organization","site_admin":false},"repo":{"id":57252484,"name":"login","full_name":"vtex-apps/login","owner":{"login":"vtex-apps","id":12614072,"avatar_url":"https://avatars.githubusercontent.com/u/12614072?v=3","gravatar_id":"","url":"https://api.github.com/users/vtex-apps","html_url":"https://github.com/vtex-apps","followers_url":"https://api.github.com/users/vtex-apps/followers","following_url":"https://api.github.com/users/vtex-apps/following{/other_user}","gists_url":"https://api.github.com/users/vtex-apps/gists{/gist_id}","starred_url":"https://api.github.com/users/vtex-apps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtex-apps/subscriptions","organizations_url":"https://api.github.com/users/vtex-apps/orgs","repos_url":"https://api.github.com/users/vtex-apps/repos","events_url":"https://api.github.com/users/vtex-apps/events{/privacy}","received_events_url":"https://api.github.com/users/vtex-apps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vtex-apps/login","description":"Login component","fork":false,"url":"https://api.github.com/repos/vtex-apps/login","forks_url":"https://api.github.com/repos/vtex-apps/login/forks","keys_url":"https://api.github.com/repos/vtex-apps/login/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vtex-apps/login/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vtex-apps/login/teams","hooks_url":"https://api.github.com/repos/vtex-apps/login/hooks","issue_events_url":"https://api.github.com/repos/vtex-apps/login/issues/events{/number}","events_url":"https://api.github.com/repos/vtex-apps/login/events","assignees_url":"https://api.github.com/repos/vtex-apps/login/assignees{/user}","branches_url":"https://api.github.com/repos/vtex-apps/login/branches{/branch}","tags_url":"https://api.github.com/repos/vtex-apps/login/tags","blobs_url":"https://api.github.com/repos/vtex-apps/login/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vtex-apps/login/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vtex-apps/login/git/refs{/sha}","trees_url":"https://api.github.com/repos/vtex-apps/login/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vtex-apps/login/statuses/{sha}","languages_url":"https://api.github.com/repos/vtex-apps/login/languages","stargazers_url":"https://api.github.com/repos/vtex-apps/login/stargazers","contributors_url":"https://api.github.com/repos/vtex-apps/login/contributors","subscribers_url":"https://api.github.com/repos/vtex-apps/login/subscribers","subscription_url":"https://api.github.com/repos/vtex-apps/login/subscription","commits_url":"https://api.github.com/repos/vtex-apps/login/commits{/sha}","git_commits_url":"https://api.github.com/repos/vtex-apps/login/git/commits{/sha}","comments_url":"https://api.github.com/repos/vtex-apps/login/comments{/number}","issue_comment_url":"https://api.github.com/repos/vtex-apps/login/issues/comments{/number}","contents_url":"https://api.github.com/repos/vtex-apps/login/contents/{+path}","compare_url":"https://api.github.com/repos/vtex-apps/login/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vtex-apps/login/merges","archive_url":"https://api.github.com/repos/vtex-apps/login/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vtex-apps/login/downloads","issues_url":"https://api.github.com/repos/vtex-apps/login/issues{/number}","pulls_url":"https://api.github.com/repos/vtex-apps/login/pulls{/number}","milestones_url":"https://api.github.com/repos/vtex-apps/login/milestones{/number}","notifications_url":"https://api.github.com/repos/vtex-apps/login/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vtex-apps/login/labels{/name}","releases_url":"https://api.github.com/repos/vtex-apps/login/releases{/id}","deployments_url":"https://api.github.com/repos/vtex-apps/login/deployments","created_at":"2016-04-27T22:16:42Z","updated_at":"2016-04-27T22:28:13Z","pushed_at":"2016-05-27T20:14:37Z","git_url":"git://github.com/vtex-apps/login.git","ssh_url":"git@github.com:vtex-apps/login.git","clone_url":"https://github.com/vtex-apps/login.git","svn_url":"https://github.com/vtex-apps/login","homepage":null,"size":25,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vtex-apps/login/pulls/3"},"html":{"href":"https://github.com/vtex-apps/login/pull/3"},"issue":{"href":"https://api.github.com/repos/vtex-apps/login/issues/3"},"comments":{"href":"https://api.github.com/repos/vtex-apps/login/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/vtex-apps/login/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/vtex-apps/login/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vtex-apps/login/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/vtex-apps/login/statuses/f29e21e68340b3e0f0bf3f889331a18cb9bf2aab"}}}}
{"actor":{"display_login":"tamorim"}}