{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/63135985","id":63135985,"diff_hunk":"@@ -0,0 +1,956 @@\n+/*\n+Copyright 2015 The Kubernetes Authors All rights reserved.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package service\n+\n+import (\n+\t\"fmt\"\n+\t\"sort\"\n+\t\"sync\"\n+\t\"time\"\n+\n+\t\"reflect\"\n+\n+\t\"github.com/golang/glog\"\n+\t\"k8s.io/kubernetes/pkg/api\"\n+\t\"k8s.io/kubernetes/pkg/api/v1\"\n+\t\"k8s.io/kubernetes/pkg/api/errors\"\n+\tcache \"k8s.io/kubernetes/pkg/client/cache\"\n+\tfederationcache \"k8s.io/kubernetes/federation/client/cache\"\n+\tclientset \"k8s.io/kubernetes/pkg/client/clientset_generated/release_1_3\"\n+\tfederationclientset \"k8s.io/kubernetes/federation/client/clientset_generated/federation_release_1_3\"\n+\t\"k8s.io/kubernetes/pkg/client/record\"\n+\t\"k8s.io/kubernetes/pkg/cloudprovider\"\n+\t\"k8s.io/kubernetes/pkg/controller\"\n+\t\"k8s.io/kubernetes/pkg/controller/framework\"\n+\tpkg_runtime \"k8s.io/kubernetes/pkg/runtime\"\n+\t\"k8s.io/kubernetes/pkg/util/runtime\"\n+\t\"k8s.io/kubernetes/pkg/util/workqueue\"\n+\n+\t\"k8s.io/kubernetes/pkg/watch\"\n+\t\"k8s.io/kubernetes/pkg/util/wait\"\n+\t\"k8s.io/kubernetes/federation/apis/federation/v1alpha1\"\n+\t\"k8s.io/kubernetes/federation/pkg/dnsprovider\"\n+\t\"k8s.io/kubernetes/federation/pkg/dnsprovider/rrstype\"\n+\t\"k8s.io/kubernetes/pkg/util/sets\"\n+\t\"k8s.io/kubernetes/pkg/api/unversioned\"\n+\t\"k8s.io/kubernetes/pkg/conversion\"\n+)\n+\n+const (\n+\n+\tserviceHashLabelName = \"service-spec-hash\"\n+\tserviceSyncPeriod = 30 * time.Second\n+\tclusterSyncPeriod = 100 * time.Second\n+// How long to wait before retrying the processing of a service change.\n+// If this changes, the sleep in hack/jenkins/e2e.sh before downing a cluster\n+// should be changed appropriately.\n+\tminRetryDelay = 5 * time.Second\n+\tmaxRetryDelay = 300 * time.Second\n+\n+\tclientRetryCount    = 5\n+\tclientRetryInterval = 5 * time.Second\n+\n+\tretryable    = true\n+\tnotRetryable = false\n+\n+\tdoNotRetry = time.Duration(0)\n+\n+\tUserAgentName = \"Federation-Service-Controller\"\n+\tKubeAPIQPS    = 20.0\n+\tKubeAPIBurst  = 30\n+)\n+\n+type cachedService struct {\n+\n+\t//release_1_3 client returns v1 service\n+\tlastState *v1.Service\n+\t// The state as successfully applied to the load balancer\n+\tappliedState *v1.Service\n+\n+\t// Ensures only one goroutine can operate on this service at any given time.\n+\tmu sync.Mutex\n+\n+\t// Controls error back-off\n+\tlastRetryDelay time.Duration\n+}\n+\n+type serviceCache struct {\n+\tmu         sync.Mutex // protects serviceMap\n+\tserviceMap map[string]*cachedService\n+}\n+\n+type ServiceController struct {\n+\tdns                dnsprovider.Interface\n+\tknownClusterSet    sets.String\n+\t//we need two clientsets to talk to federation apiserver now, federationClient talks to cluster","path":"federation/pkg/controller/service/servicecontroller.go","position":99,"original_position":99,"commit_id":"7401226d3cb8451664672c4092084e1b4f6f4f3f","original_commit_id":"7401226d3cb8451664672c4092084e1b4f6f4f3f","user":{"login":"mfanjie","id":16643108,"avatar_url":"https://avatars.githubusercontent.com/u/16643108?v=3","gravatar_id":"","url":"https://api.github.com/users/mfanjie","html_url":"https://github.com/mfanjie","followers_url":"https://api.github.com/users/mfanjie/followers","following_url":"https://api.github.com/users/mfanjie/following{/other_user}","gists_url":"https://api.github.com/users/mfanjie/gists{/gist_id}","starred_url":"https://api.github.com/users/mfanjie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfanjie/subscriptions","organizations_url":"https://api.github.com/users/mfanjie/orgs","repos_url":"https://api.github.com/users/mfanjie/repos","events_url":"https://api.github.com/users/mfanjie/events{/privacy}","received_events_url":"https://api.github.com/users/mfanjie/received_events","type":"User","site_admin":false},"body":"This comment can be removed now, it was a todo action for me when service api is not added to federationClient.","created_at":"2016-05-13T05:52:11Z","updated_at":"2016-05-13T05:52:11Z","html_url":"https://github.com/kubernetes/kubernetes/pull/25517#discussion_r63135985","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25517","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/63135985"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25517#discussion_r63135985"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25517"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25517","id":69765296,"html_url":"https://github.com/kubernetes/kubernetes/pull/25517","diff_url":"https://github.com/kubernetes/kubernetes/pull/25517.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/25517.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25517","number":25517,"state":"open","locked":false,"title":"[WIP]Fed service controller","user":{"login":"mfanjie","id":16643108,"avatar_url":"https://avatars.githubusercontent.com/u/16643108?v=3","gravatar_id":"","url":"https://api.github.com/users/mfanjie","html_url":"https://github.com/mfanjie","followers_url":"https://api.github.com/users/mfanjie/followers","following_url":"https://api.github.com/users/mfanjie/following{/other_user}","gists_url":"https://api.github.com/users/mfanjie/gists{/gist_id}","starred_url":"https://api.github.com/users/mfanjie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfanjie/subscriptions","organizations_url":"https://api.github.com/users/mfanjie/orgs","repos_url":"https://api.github.com/users/mfanjie/repos","events_url":"https://api.github.com/users/mfanjie/events{/privacy}","received_events_url":"https://api.github.com/users/mfanjie/received_events","type":"User","site_admin":false},"body":"The code is based on Nikhil's latest clientset PR.\r\nThere are still lot of things to go.\r\n1. separate the logic of service creation and dns entry written.\r\nwhen watching the federation apiserver, if there is new service creation or update, the action is to create service in underlying k8s cluster, but do not create dns info.\r\n2. list and watch all underlying k8s clusters for service. if LB info is created, then create dns info\r\n3. generate random name when create k8s service to avoid name conflict.\r\n4. add logic to support service label based on hash, and use the labels to link federation service and k8s services.\r\n5. cluster add path.\r\n6. partial failure handling\r\n\r\n@quinton-hoole ","created_at":"2016-05-12T00:55:40Z","updated_at":"2016-05-13T05:52:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25517/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25517/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25517/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/7401226d3cb8451664672c4092084e1b4f6f4f3f","head":{"label":"mfanjie:fed-service-controller","ref":"fed-service-controller","sha":"7401226d3cb8451664672c4092084e1b4f6f4f3f","user":{"login":"mfanjie","id":16643108,"avatar_url":"https://avatars.githubusercontent.com/u/16643108?v=3","gravatar_id":"","url":"https://api.github.com/users/mfanjie","html_url":"https://github.com/mfanjie","followers_url":"https://api.github.com/users/mfanjie/followers","following_url":"https://api.github.com/users/mfanjie/following{/other_user}","gists_url":"https://api.github.com/users/mfanjie/gists{/gist_id}","starred_url":"https://api.github.com/users/mfanjie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfanjie/subscriptions","organizations_url":"https://api.github.com/users/mfanjie/orgs","repos_url":"https://api.github.com/users/mfanjie/repos","events_url":"https://api.github.com/users/mfanjie/events{/privacy}","received_events_url":"https://api.github.com/users/mfanjie/received_events","type":"User","site_admin":false},"repo":{"id":52251497,"name":"kubernetes","full_name":"mfanjie/kubernetes","owner":{"login":"mfanjie","id":16643108,"avatar_url":"https://avatars.githubusercontent.com/u/16643108?v=3","gravatar_id":"","url":"https://api.github.com/users/mfanjie","html_url":"https://github.com/mfanjie","followers_url":"https://api.github.com/users/mfanjie/followers","following_url":"https://api.github.com/users/mfanjie/following{/other_user}","gists_url":"https://api.github.com/users/mfanjie/gists{/gist_id}","starred_url":"https://api.github.com/users/mfanjie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfanjie/subscriptions","organizations_url":"https://api.github.com/users/mfanjie/orgs","repos_url":"https://api.github.com/users/mfanjie/repos","events_url":"https://api.github.com/users/mfanjie/events{/privacy}","received_events_url":"https://api.github.com/users/mfanjie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfanjie/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/mfanjie/kubernetes","forks_url":"https://api.github.com/repos/mfanjie/kubernetes/forks","keys_url":"https://api.github.com/repos/mfanjie/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfanjie/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfanjie/kubernetes/teams","hooks_url":"https://api.github.com/repos/mfanjie/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/mfanjie/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/mfanjie/kubernetes/events","assignees_url":"https://api.github.com/repos/mfanjie/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/mfanjie/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/mfanjie/kubernetes/tags","blobs_url":"https://api.github.com/repos/mfanjie/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfanjie/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfanjie/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfanjie/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfanjie/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/mfanjie/kubernetes/languages","stargazers_url":"https://api.github.com/repos/mfanjie/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/mfanjie/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/mfanjie/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/mfanjie/kubernetes/subscription","commits_url":"https://api.github.com/repos/mfanjie/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfanjie/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfanjie/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfanjie/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfanjie/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/mfanjie/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfanjie/kubernetes/merges","archive_url":"https://api.github.com/repos/mfanjie/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfanjie/kubernetes/downloads","issues_url":"https://api.github.com/repos/mfanjie/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/mfanjie/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/mfanjie/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/mfanjie/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfanjie/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/mfanjie/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/mfanjie/kubernetes/deployments","created_at":"2016-02-22T06:18:44Z","updated_at":"2016-02-22T06:18:55Z","pushed_at":"2016-05-12T09:04:20Z","git_url":"git://github.com/mfanjie/kubernetes.git","ssh_url":"git@github.com:mfanjie/kubernetes.git","clone_url":"https://github.com/mfanjie/kubernetes.git","svn_url":"https://github.com/mfanjie/kubernetes","homepage":"http://kubernetes.io","size":191842,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"2706df102b21929b10ceff6c6941b4defd729651","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-05-13T05:04:55Z","pushed_at":"2016-05-13T05:50:22Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":394260,"stargazers_count":14349,"watchers_count":14349,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4310,"mirror_url":null,"open_issues_count":3608,"forks":4310,"open_issues":3608,"watchers":14349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25517"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25517"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25517"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25517/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25517/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25517/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/7401226d3cb8451664672c4092084e1b4f6f4f3f"}}}}