{"action":"created","comment":{"url":"https://api.github.com/repos/willowtreeapps/swifter/pulls/comments/57521935","id":57521935,"diff_hunk":"@@ -80,7 +80,7 @@ public class Socket: Hashable, Equatable {\n         return Socket(socketFileDescriptor: socketFileDescriptor)\n     }\n     \n-    private let socketFileDescriptor: Int32\n+    public let socketFileDescriptor: Int32","path":"Sources/Socket.swift","position":5,"original_position":5,"commit_id":"c3fb2b9add542f6fb517f3583902f69e3f672442","original_commit_id":"c3fb2b9add542f6fb517f3583902f69e3f672442","user":{"login":"mbaranowski","id":1215620,"avatar_url":"https://avatars.githubusercontent.com/u/1215620?v=3","gravatar_id":"","url":"https://api.github.com/users/mbaranowski","html_url":"https://github.com/mbaranowski","followers_url":"https://api.github.com/users/mbaranowski/followers","following_url":"https://api.github.com/users/mbaranowski/following{/other_user}","gists_url":"https://api.github.com/users/mbaranowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mbaranowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbaranowski/subscriptions","organizations_url":"https://api.github.com/users/mbaranowski/orgs","repos_url":"https://api.github.com/users/mbaranowski/repos","events_url":"https://api.github.com/users/mbaranowski/events{/privacy}","received_events_url":"https://api.github.com/users/mbaranowski/received_events","type":"User","site_admin":false},"body":"`Socket.release` closes this socket, and as far as I can leaves a \"dangling\" socketFileDescriptor that is useless.\r\nOne solution is to change this to mutable and track socket state. Specifically this could be: \r\n`public private(set) var socketFileDescriptor: Int32`\r\nand release becomes:\r\n```\r\npublic func release() {\r\n        Socket.release(self.socketFileDescriptor)\r\n        self.socketFileDescriptor = -1\r\n}\r\n```","created_at":"2016-03-27T01:30:12Z","updated_at":"2016-03-27T01:30:12Z","html_url":"https://github.com/willowtreeapps/swifter/pull/1#discussion_r57521935","pull_request_url":"https://api.github.com/repos/willowtreeapps/swifter/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/willowtreeapps/swifter/pulls/comments/57521935"},"html":{"href":"https://github.com/willowtreeapps/swifter/pull/1#discussion_r57521935"},"pull_request":{"href":"https://api.github.com/repos/willowtreeapps/swifter/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/willowtreeapps/swifter/pulls/1","id":63714899,"html_url":"https://github.com/willowtreeapps/swifter/pull/1","diff_url":"https://github.com/willowtreeapps/swifter/pull/1.diff","patch_url":"https://github.com/willowtreeapps/swifter/pull/1.patch","issue_url":"https://api.github.com/repos/willowtreeapps/swifter/issues/1","number":1,"state":"open","locked":false,"title":"Grant Extensions Access to Sockets","user":{"login":"mikerunnals","id":12500309,"avatar_url":"https://avatars.githubusercontent.com/u/12500309?v=3","gravatar_id":"","url":"https://api.github.com/users/mikerunnals","html_url":"https://github.com/mikerunnals","followers_url":"https://api.github.com/users/mikerunnals/followers","following_url":"https://api.github.com/users/mikerunnals/following{/other_user}","gists_url":"https://api.github.com/users/mikerunnals/gists{/gist_id}","starred_url":"https://api.github.com/users/mikerunnals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikerunnals/subscriptions","organizations_url":"https://api.github.com/users/mikerunnals/orgs","repos_url":"https://api.github.com/users/mikerunnals/repos","events_url":"https://api.github.com/users/mikerunnals/events{/privacy}","received_events_url":"https://api.github.com/users/mikerunnals/received_events","type":"User","site_admin":false},"body":"and convenience functions.","created_at":"2016-03-22T12:55:35Z","updated_at":"2016-03-27T01:30:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9f4773e841a885dc947a5070b1132437679e3e2","assignee":{"login":"mbaranowski","id":1215620,"avatar_url":"https://avatars.githubusercontent.com/u/1215620?v=3","gravatar_id":"","url":"https://api.github.com/users/mbaranowski","html_url":"https://github.com/mbaranowski","followers_url":"https://api.github.com/users/mbaranowski/followers","following_url":"https://api.github.com/users/mbaranowski/following{/other_user}","gists_url":"https://api.github.com/users/mbaranowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mbaranowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbaranowski/subscriptions","organizations_url":"https://api.github.com/users/mbaranowski/orgs","repos_url":"https://api.github.com/users/mbaranowski/repos","events_url":"https://api.github.com/users/mbaranowski/events{/privacy}","received_events_url":"https://api.github.com/users/mbaranowski/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/willowtreeapps/swifter/pulls/1/commits","review_comments_url":"https://api.github.com/repos/willowtreeapps/swifter/pulls/1/comments","review_comment_url":"https://api.github.com/repos/willowtreeapps/swifter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/willowtreeapps/swifter/issues/1/comments","statuses_url":"https://api.github.com/repos/willowtreeapps/swifter/statuses/c3fb2b9add542f6fb517f3583902f69e3f672442","head":{"label":"willowtreeapps:feature/elevate-access","ref":"feature/elevate-access","sha":"c3fb2b9add542f6fb517f3583902f69e3f672442","user":{"login":"willowtreeapps","id":557680,"avatar_url":"https://avatars.githubusercontent.com/u/557680?v=3","gravatar_id":"","url":"https://api.github.com/users/willowtreeapps","html_url":"https://github.com/willowtreeapps","followers_url":"https://api.github.com/users/willowtreeapps/followers","following_url":"https://api.github.com/users/willowtreeapps/following{/other_user}","gists_url":"https://api.github.com/users/willowtreeapps/gists{/gist_id}","starred_url":"https://api.github.com/users/willowtreeapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willowtreeapps/subscriptions","organizations_url":"https://api.github.com/users/willowtreeapps/orgs","repos_url":"https://api.github.com/users/willowtreeapps/repos","events_url":"https://api.github.com/users/willowtreeapps/events{/privacy}","received_events_url":"https://api.github.com/users/willowtreeapps/received_events","type":"Organization","site_admin":false},"repo":{"id":53978203,"name":"swifter","full_name":"willowtreeapps/swifter","owner":{"login":"willowtreeapps","id":557680,"avatar_url":"https://avatars.githubusercontent.com/u/557680?v=3","gravatar_id":"","url":"https://api.github.com/users/willowtreeapps","html_url":"https://github.com/willowtreeapps","followers_url":"https://api.github.com/users/willowtreeapps/followers","following_url":"https://api.github.com/users/willowtreeapps/following{/other_user}","gists_url":"https://api.github.com/users/willowtreeapps/gists{/gist_id}","starred_url":"https://api.github.com/users/willowtreeapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willowtreeapps/subscriptions","organizations_url":"https://api.github.com/users/willowtreeapps/orgs","repos_url":"https://api.github.com/users/willowtreeapps/repos","events_url":"https://api.github.com/users/willowtreeapps/events{/privacy}","received_events_url":"https://api.github.com/users/willowtreeapps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/willowtreeapps/swifter","description":"Tiny http server engine written in Swift programming language.","fork":true,"url":"https://api.github.com/repos/willowtreeapps/swifter","forks_url":"https://api.github.com/repos/willowtreeapps/swifter/forks","keys_url":"https://api.github.com/repos/willowtreeapps/swifter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willowtreeapps/swifter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willowtreeapps/swifter/teams","hooks_url":"https://api.github.com/repos/willowtreeapps/swifter/hooks","issue_events_url":"https://api.github.com/repos/willowtreeapps/swifter/issues/events{/number}","events_url":"https://api.github.com/repos/willowtreeapps/swifter/events","assignees_url":"https://api.github.com/repos/willowtreeapps/swifter/assignees{/user}","branches_url":"https://api.github.com/repos/willowtreeapps/swifter/branches{/branch}","tags_url":"https://api.github.com/repos/willowtreeapps/swifter/tags","blobs_url":"https://api.github.com/repos/willowtreeapps/swifter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willowtreeapps/swifter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willowtreeapps/swifter/git/refs{/sha}","trees_url":"https://api.github.com/repos/willowtreeapps/swifter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willowtreeapps/swifter/statuses/{sha}","languages_url":"https://api.github.com/repos/willowtreeapps/swifter/languages","stargazers_url":"https://api.github.com/repos/willowtreeapps/swifter/stargazers","contributors_url":"https://api.github.com/repos/willowtreeapps/swifter/contributors","subscribers_url":"https://api.github.com/repos/willowtreeapps/swifter/subscribers","subscription_url":"https://api.github.com/repos/willowtreeapps/swifter/subscription","commits_url":"https://api.github.com/repos/willowtreeapps/swifter/commits{/sha}","git_commits_url":"https://api.github.com/repos/willowtreeapps/swifter/git/commits{/sha}","comments_url":"https://api.github.com/repos/willowtreeapps/swifter/comments{/number}","issue_comment_url":"https://api.github.com/repos/willowtreeapps/swifter/issues/comments{/number}","contents_url":"https://api.github.com/repos/willowtreeapps/swifter/contents/{+path}","compare_url":"https://api.github.com/repos/willowtreeapps/swifter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willowtreeapps/swifter/merges","archive_url":"https://api.github.com/repos/willowtreeapps/swifter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willowtreeapps/swifter/downloads","issues_url":"https://api.github.com/repos/willowtreeapps/swifter/issues{/number}","pulls_url":"https://api.github.com/repos/willowtreeapps/swifter/pulls{/number}","milestones_url":"https://api.github.com/repos/willowtreeapps/swifter/milestones{/number}","notifications_url":"https://api.github.com/repos/willowtreeapps/swifter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willowtreeapps/swifter/labels{/name}","releases_url":"https://api.github.com/repos/willowtreeapps/swifter/releases{/id}","deployments_url":"https://api.github.com/repos/willowtreeapps/swifter/deployments","created_at":"2016-03-15T21:00:40Z","updated_at":"2016-03-15T21:00:42Z","pushed_at":"2016-03-22T14:02:19Z","git_url":"git://github.com/willowtreeapps/swifter.git","ssh_url":"git@github.com:willowtreeapps/swifter.git","clone_url":"https://github.com/willowtreeapps/swifter.git","svn_url":"https://github.com/willowtreeapps/swifter","homepage":null,"size":10815,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"willowtreeapps:release-1.1.2-x","ref":"release-1.1.2-x","sha":"0c31226a0ba248d14cbd133e73f4b43ef98cc8d0","user":{"login":"willowtreeapps","id":557680,"avatar_url":"https://avatars.githubusercontent.com/u/557680?v=3","gravatar_id":"","url":"https://api.github.com/users/willowtreeapps","html_url":"https://github.com/willowtreeapps","followers_url":"https://api.github.com/users/willowtreeapps/followers","following_url":"https://api.github.com/users/willowtreeapps/following{/other_user}","gists_url":"https://api.github.com/users/willowtreeapps/gists{/gist_id}","starred_url":"https://api.github.com/users/willowtreeapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willowtreeapps/subscriptions","organizations_url":"https://api.github.com/users/willowtreeapps/orgs","repos_url":"https://api.github.com/users/willowtreeapps/repos","events_url":"https://api.github.com/users/willowtreeapps/events{/privacy}","received_events_url":"https://api.github.com/users/willowtreeapps/received_events","type":"Organization","site_admin":false},"repo":{"id":53978203,"name":"swifter","full_name":"willowtreeapps/swifter","owner":{"login":"willowtreeapps","id":557680,"avatar_url":"https://avatars.githubusercontent.com/u/557680?v=3","gravatar_id":"","url":"https://api.github.com/users/willowtreeapps","html_url":"https://github.com/willowtreeapps","followers_url":"https://api.github.com/users/willowtreeapps/followers","following_url":"https://api.github.com/users/willowtreeapps/following{/other_user}","gists_url":"https://api.github.com/users/willowtreeapps/gists{/gist_id}","starred_url":"https://api.github.com/users/willowtreeapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willowtreeapps/subscriptions","organizations_url":"https://api.github.com/users/willowtreeapps/orgs","repos_url":"https://api.github.com/users/willowtreeapps/repos","events_url":"https://api.github.com/users/willowtreeapps/events{/privacy}","received_events_url":"https://api.github.com/users/willowtreeapps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/willowtreeapps/swifter","description":"Tiny http server engine written in Swift programming language.","fork":true,"url":"https://api.github.com/repos/willowtreeapps/swifter","forks_url":"https://api.github.com/repos/willowtreeapps/swifter/forks","keys_url":"https://api.github.com/repos/willowtreeapps/swifter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willowtreeapps/swifter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willowtreeapps/swifter/teams","hooks_url":"https://api.github.com/repos/willowtreeapps/swifter/hooks","issue_events_url":"https://api.github.com/repos/willowtreeapps/swifter/issues/events{/number}","events_url":"https://api.github.com/repos/willowtreeapps/swifter/events","assignees_url":"https://api.github.com/repos/willowtreeapps/swifter/assignees{/user}","branches_url":"https://api.github.com/repos/willowtreeapps/swifter/branches{/branch}","tags_url":"https://api.github.com/repos/willowtreeapps/swifter/tags","blobs_url":"https://api.github.com/repos/willowtreeapps/swifter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willowtreeapps/swifter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willowtreeapps/swifter/git/refs{/sha}","trees_url":"https://api.github.com/repos/willowtreeapps/swifter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willowtreeapps/swifter/statuses/{sha}","languages_url":"https://api.github.com/repos/willowtreeapps/swifter/languages","stargazers_url":"https://api.github.com/repos/willowtreeapps/swifter/stargazers","contributors_url":"https://api.github.com/repos/willowtreeapps/swifter/contributors","subscribers_url":"https://api.github.com/repos/willowtreeapps/swifter/subscribers","subscription_url":"https://api.github.com/repos/willowtreeapps/swifter/subscription","commits_url":"https://api.github.com/repos/willowtreeapps/swifter/commits{/sha}","git_commits_url":"https://api.github.com/repos/willowtreeapps/swifter/git/commits{/sha}","comments_url":"https://api.github.com/repos/willowtreeapps/swifter/comments{/number}","issue_comment_url":"https://api.github.com/repos/willowtreeapps/swifter/issues/comments{/number}","contents_url":"https://api.github.com/repos/willowtreeapps/swifter/contents/{+path}","compare_url":"https://api.github.com/repos/willowtreeapps/swifter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willowtreeapps/swifter/merges","archive_url":"https://api.github.com/repos/willowtreeapps/swifter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willowtreeapps/swifter/downloads","issues_url":"https://api.github.com/repos/willowtreeapps/swifter/issues{/number}","pulls_url":"https://api.github.com/repos/willowtreeapps/swifter/pulls{/number}","milestones_url":"https://api.github.com/repos/willowtreeapps/swifter/milestones{/number}","notifications_url":"https://api.github.com/repos/willowtreeapps/swifter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willowtreeapps/swifter/labels{/name}","releases_url":"https://api.github.com/repos/willowtreeapps/swifter/releases{/id}","deployments_url":"https://api.github.com/repos/willowtreeapps/swifter/deployments","created_at":"2016-03-15T21:00:40Z","updated_at":"2016-03-15T21:00:42Z","pushed_at":"2016-03-22T14:02:19Z","git_url":"git://github.com/willowtreeapps/swifter.git","ssh_url":"git@github.com:willowtreeapps/swifter.git","clone_url":"https://github.com/willowtreeapps/swifter.git","svn_url":"https://github.com/willowtreeapps/swifter","homepage":null,"size":10815,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/willowtreeapps/swifter/pulls/1"},"html":{"href":"https://github.com/willowtreeapps/swifter/pull/1"},"issue":{"href":"https://api.github.com/repos/willowtreeapps/swifter/issues/1"},"comments":{"href":"https://api.github.com/repos/willowtreeapps/swifter/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/willowtreeapps/swifter/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/willowtreeapps/swifter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/willowtreeapps/swifter/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/willowtreeapps/swifter/statuses/c3fb2b9add542f6fb517f3583902f69e3f672442"}}}}