{"action":"created","issue":{"url":"https://api.github.com/repos/swimlane/angular2-data-table/issues/149","repository_url":"https://api.github.com/repos/swimlane/angular2-data-table","labels_url":"https://api.github.com/repos/swimlane/angular2-data-table/issues/149/labels{/name}","comments_url":"https://api.github.com/repos/swimlane/angular2-data-table/issues/149/comments","events_url":"https://api.github.com/repos/swimlane/angular2-data-table/issues/149/events","html_url":"https://github.com/swimlane/angular2-data-table/issues/149","id":179429942,"number":149,"title":"Performance optimizations","user":{"login":"jtomaszewski","id":1862580,"avatar_url":"https://avatars.githubusercontent.com/u/1862580?v=3","gravatar_id":"","url":"https://api.github.com/users/jtomaszewski","html_url":"https://github.com/jtomaszewski","followers_url":"https://api.github.com/users/jtomaszewski/followers","following_url":"https://api.github.com/users/jtomaszewski/following{/other_user}","gists_url":"https://api.github.com/users/jtomaszewski/gists{/gist_id}","starred_url":"https://api.github.com/users/jtomaszewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtomaszewski/subscriptions","organizations_url":"https://api.github.com/users/jtomaszewski/orgs","repos_url":"https://api.github.com/users/jtomaszewski/repos","events_url":"https://api.github.com/users/jtomaszewski/events{/privacy}","received_events_url":"https://api.github.com/users/jtomaszewski/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/swimlane/angular2-data-table/labels/In%20Discussion","name":"In Discussion","color":"bfdadc"},{"url":"https://api.github.com/repos/swimlane/angular2-data-table/labels/Suggestion","name":"Suggestion","color":"c5def5"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-27T08:38:10Z","updated_at":"2016-09-28T13:50:28Z","closed_at":"2016-09-28T12:15:17Z","body":"Is the angular2-data-table optimized when it comes to performance?\r\n\r\nI didn't get to see through all the code, but after a quick glimpse:\r\n\r\n- we could add a `trackBy` option to `*ngFor=\"let row of rows; let i = index;\"` in `Body` component's template\r\n- components like `BodyCell`, `BodyRow` should propably be dependant only on Inputs and use `ChangeDetectionStrategy.OnPush`\r\n- components like `Body` propably could also use `ChangeDetectionStrategy.OnPush`, but as it's currently heavily dependant on `StateService`, we would need to add some rxjs observables to that or something.\r\n\r\nWhat do you guys think? Maybe I could help a bit with that."},"comment":{"url":"https://api.github.com/repos/swimlane/angular2-data-table/issues/comments/250172032","html_url":"https://github.com/swimlane/angular2-data-table/issues/149#issuecomment-250172032","issue_url":"https://api.github.com/repos/swimlane/angular2-data-table/issues/149","id":250172032,"user":{"login":"jtomaszewski","id":1862580,"avatar_url":"https://avatars.githubusercontent.com/u/1862580?v=3","gravatar_id":"","url":"https://api.github.com/users/jtomaszewski","html_url":"https://github.com/jtomaszewski","followers_url":"https://api.github.com/users/jtomaszewski/followers","following_url":"https://api.github.com/users/jtomaszewski/following{/other_user}","gists_url":"https://api.github.com/users/jtomaszewski/gists{/gist_id}","starred_url":"https://api.github.com/users/jtomaszewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtomaszewski/subscriptions","organizations_url":"https://api.github.com/users/jtomaszewski/orgs","repos_url":"https://api.github.com/users/jtomaszewski/repos","events_url":"https://api.github.com/users/jtomaszewski/events{/privacy}","received_events_url":"https://api.github.com/users/jtomaszewski/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T13:50:28Z","updated_at":"2016-09-28T13:50:28Z","body":"Hey, why did you close it? ;] \r\n\r\nThere's still some commits here that can be merged:\r\n- https://github.com/jtomaszewski/angular2-data-table/commit/8658afe39b440b9583c5537954e1778475f12a21\r\n- https://github.com/jtomaszewski/angular2-data-table/commit/9b87bef41492a470c467be6c92e211e97f33bda3\r\n- https://github.com/jtomaszewski/angular2-data-table/commit/b63bc30de4d6c5578371e212b4cb3acccfaaa86d\r\n- https://github.com/jtomaszewski/angular2-data-table/commit/16d2652d5036ee770924ef998c2e0b631f11e4a6\r\n\r\nShould I do sepearte PRs for all of them?"}}
{"actor":{"display_login":"jtomaszewski"}}