{"action":"opened","number":341,"pull_request":{"url":"https://api.github.com/repos/videogular/videogular2/pulls/341","id":99648199,"html_url":"https://github.com/videogular/videogular2/pull/341","diff_url":"https://github.com/videogular/videogular2/pull/341.diff","patch_url":"https://github.com/videogular/videogular2/pull/341.patch","issue_url":"https://api.github.com/repos/videogular/videogular2/issues/341","number":341,"state":"open","locked":false,"title":"refactor(rxjs): Import operators individually from rxjs for tree-shaking","user":{"login":"jskrzypek","id":1513265,"avatar_url":"https://avatars.githubusercontent.com/u/1513265?v=3","gravatar_id":"","url":"https://api.github.com/users/jskrzypek","html_url":"https://github.com/jskrzypek","followers_url":"https://api.github.com/users/jskrzypek/followers","following_url":"https://api.github.com/users/jskrzypek/following{/other_user}","gists_url":"https://api.github.com/users/jskrzypek/gists{/gist_id}","starred_url":"https://api.github.com/users/jskrzypek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskrzypek/subscriptions","organizations_url":"https://api.github.com/users/jskrzypek/orgs","repos_url":"https://api.github.com/users/jskrzypek/repos","events_url":"https://api.github.com/users/jskrzypek/events{/privacy}","received_events_url":"https://api.github.com/users/jskrzypek/received_events","type":"User","site_admin":false},"body":"### Rationale\r\nImporting directly from the rxjs class modules, e.g. `'rxjs/Observable'`, and then patching imports\r\nfor only the used operator modules, e.g. `'rxjs/add/observable/fromEvent'`, avoids using the omnibus\r\n`'rxjs/Rx'` module and makes it easier for consumers to tree-shake their bundles correctly with\r\ntools like rollup & webpack. More information is avaiable in the\r\n[rxjs readme](https://github.com/ReactiveX/rxjs#installation-and-usage) as well as in\r\n[rxjs#1888](https://github.com/ReactiveX/rxjs/issues/1888).\r\n\r\n### Description\r\n * Changed the `import` statements that pointed to `'rxjs'` (src/core/vg-media/vg-media.d.ts) and\r\n   `'rxjs/Rx'` (in src/core/vg-cue-points/vg-cue-points.ts, src/core/vg-cue-points/vg-cue-points.spec.ts)\r\n   to import directly from `'rxjs/Subscription'`/`'rxjs/Observer'` and `'rxjs/Observable'` (respectively).\r\n * Added operator patch `import` statements (i.e. `import 'rxjs/add/observable/fromEvent';` and\r\n   `import 'rxjs/add/observable/combineLatest';`) to every file where `Observable.fromEvent()` and\r\n   `Observable.combineLatest()` are being called (`Observable.create()` is defined in `'rxjs/Observable'`\r\n   and does not need patching).","created_at":"2016-12-29T12:02:42Z","updated_at":"2016-12-29T12:02:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/videogular/videogular2/pulls/341/commits","review_comments_url":"https://api.github.com/repos/videogular/videogular2/pulls/341/comments","review_comment_url":"https://api.github.com/repos/videogular/videogular2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videogular/videogular2/issues/341/comments","statuses_url":"https://api.github.com/repos/videogular/videogular2/statuses/8604e70bb7a90f98aa7762c4e5c9956ef43199a1","head":{"label":"jskrzypek:fix-rxjs-import","ref":"fix-rxjs-import","sha":"8604e70bb7a90f98aa7762c4e5c9956ef43199a1","user":{"login":"jskrzypek","id":1513265,"avatar_url":"https://avatars.githubusercontent.com/u/1513265?v=3","gravatar_id":"","url":"https://api.github.com/users/jskrzypek","html_url":"https://github.com/jskrzypek","followers_url":"https://api.github.com/users/jskrzypek/followers","following_url":"https://api.github.com/users/jskrzypek/following{/other_user}","gists_url":"https://api.github.com/users/jskrzypek/gists{/gist_id}","starred_url":"https://api.github.com/users/jskrzypek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskrzypek/subscriptions","organizations_url":"https://api.github.com/users/jskrzypek/orgs","repos_url":"https://api.github.com/users/jskrzypek/repos","events_url":"https://api.github.com/users/jskrzypek/events{/privacy}","received_events_url":"https://api.github.com/users/jskrzypek/received_events","type":"User","site_admin":false},"repo":{"id":77608587,"name":"videogular2","full_name":"jskrzypek/videogular2","owner":{"login":"jskrzypek","id":1513265,"avatar_url":"https://avatars.githubusercontent.com/u/1513265?v=3","gravatar_id":"","url":"https://api.github.com/users/jskrzypek","html_url":"https://github.com/jskrzypek","followers_url":"https://api.github.com/users/jskrzypek/followers","following_url":"https://api.github.com/users/jskrzypek/following{/other_user}","gists_url":"https://api.github.com/users/jskrzypek/gists{/gist_id}","starred_url":"https://api.github.com/users/jskrzypek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskrzypek/subscriptions","organizations_url":"https://api.github.com/users/jskrzypek/orgs","repos_url":"https://api.github.com/users/jskrzypek/repos","events_url":"https://api.github.com/users/jskrzypek/events{/privacy}","received_events_url":"https://api.github.com/users/jskrzypek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jskrzypek/videogular2","description":"The HTML5 video player for Angular 2","fork":true,"url":"https://api.github.com/repos/jskrzypek/videogular2","forks_url":"https://api.github.com/repos/jskrzypek/videogular2/forks","keys_url":"https://api.github.com/repos/jskrzypek/videogular2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jskrzypek/videogular2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jskrzypek/videogular2/teams","hooks_url":"https://api.github.com/repos/jskrzypek/videogular2/hooks","issue_events_url":"https://api.github.com/repos/jskrzypek/videogular2/issues/events{/number}","events_url":"https://api.github.com/repos/jskrzypek/videogular2/events","assignees_url":"https://api.github.com/repos/jskrzypek/videogular2/assignees{/user}","branches_url":"https://api.github.com/repos/jskrzypek/videogular2/branches{/branch}","tags_url":"https://api.github.com/repos/jskrzypek/videogular2/tags","blobs_url":"https://api.github.com/repos/jskrzypek/videogular2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jskrzypek/videogular2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jskrzypek/videogular2/git/refs{/sha}","trees_url":"https://api.github.com/repos/jskrzypek/videogular2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jskrzypek/videogular2/statuses/{sha}","languages_url":"https://api.github.com/repos/jskrzypek/videogular2/languages","stargazers_url":"https://api.github.com/repos/jskrzypek/videogular2/stargazers","contributors_url":"https://api.github.com/repos/jskrzypek/videogular2/contributors","subscribers_url":"https://api.github.com/repos/jskrzypek/videogular2/subscribers","subscription_url":"https://api.github.com/repos/jskrzypek/videogular2/subscription","commits_url":"https://api.github.com/repos/jskrzypek/videogular2/commits{/sha}","git_commits_url":"https://api.github.com/repos/jskrzypek/videogular2/git/commits{/sha}","comments_url":"https://api.github.com/repos/jskrzypek/videogular2/comments{/number}","issue_comment_url":"https://api.github.com/repos/jskrzypek/videogular2/issues/comments{/number}","contents_url":"https://api.github.com/repos/jskrzypek/videogular2/contents/{+path}","compare_url":"https://api.github.com/repos/jskrzypek/videogular2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jskrzypek/videogular2/merges","archive_url":"https://api.github.com/repos/jskrzypek/videogular2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jskrzypek/videogular2/downloads","issues_url":"https://api.github.com/repos/jskrzypek/videogular2/issues{/number}","pulls_url":"https://api.github.com/repos/jskrzypek/videogular2/pulls{/number}","milestones_url":"https://api.github.com/repos/jskrzypek/videogular2/milestones{/number}","notifications_url":"https://api.github.com/repos/jskrzypek/videogular2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jskrzypek/videogular2/labels{/name}","releases_url":"https://api.github.com/repos/jskrzypek/videogular2/releases{/id}","deployments_url":"https://api.github.com/repos/jskrzypek/videogular2/deployments","created_at":"2016-12-29T11:49:07Z","updated_at":"2016-12-29T11:49:09Z","pushed_at":"2016-12-29T11:57:47Z","git_url":"git://github.com/jskrzypek/videogular2.git","ssh_url":"git@github.com:jskrzypek/videogular2.git","clone_url":"https://github.com/jskrzypek/videogular2.git","svn_url":"https://github.com/jskrzypek/videogular2","homepage":null,"size":1683,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"videogular:master","ref":"master","sha":"eaed99f3f7b92cfa40b4f6c34e6496c69c8a588a","user":{"login":"videogular","id":15369882,"avatar_url":"https://avatars.githubusercontent.com/u/15369882?v=3","gravatar_id":"","url":"https://api.github.com/users/videogular","html_url":"https://github.com/videogular","followers_url":"https://api.github.com/users/videogular/followers","following_url":"https://api.github.com/users/videogular/following{/other_user}","gists_url":"https://api.github.com/users/videogular/gists{/gist_id}","starred_url":"https://api.github.com/users/videogular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videogular/subscriptions","organizations_url":"https://api.github.com/users/videogular/orgs","repos_url":"https://api.github.com/users/videogular/repos","events_url":"https://api.github.com/users/videogular/events{/privacy}","received_events_url":"https://api.github.com/users/videogular/received_events","type":"Organization","site_admin":false},"repo":{"id":45143245,"name":"videogular2","full_name":"videogular/videogular2","owner":{"login":"videogular","id":15369882,"avatar_url":"https://avatars.githubusercontent.com/u/15369882?v=3","gravatar_id":"","url":"https://api.github.com/users/videogular","html_url":"https://github.com/videogular","followers_url":"https://api.github.com/users/videogular/followers","following_url":"https://api.github.com/users/videogular/following{/other_user}","gists_url":"https://api.github.com/users/videogular/gists{/gist_id}","starred_url":"https://api.github.com/users/videogular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videogular/subscriptions","organizations_url":"https://api.github.com/users/videogular/orgs","repos_url":"https://api.github.com/users/videogular/repos","events_url":"https://api.github.com/users/videogular/events{/privacy}","received_events_url":"https://api.github.com/users/videogular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videogular/videogular2","description":"The HTML5 video player for Angular 2","fork":false,"url":"https://api.github.com/repos/videogular/videogular2","forks_url":"https://api.github.com/repos/videogular/videogular2/forks","keys_url":"https://api.github.com/repos/videogular/videogular2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videogular/videogular2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videogular/videogular2/teams","hooks_url":"https://api.github.com/repos/videogular/videogular2/hooks","issue_events_url":"https://api.github.com/repos/videogular/videogular2/issues/events{/number}","events_url":"https://api.github.com/repos/videogular/videogular2/events","assignees_url":"https://api.github.com/repos/videogular/videogular2/assignees{/user}","branches_url":"https://api.github.com/repos/videogular/videogular2/branches{/branch}","tags_url":"https://api.github.com/repos/videogular/videogular2/tags","blobs_url":"https://api.github.com/repos/videogular/videogular2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videogular/videogular2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videogular/videogular2/git/refs{/sha}","trees_url":"https://api.github.com/repos/videogular/videogular2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videogular/videogular2/statuses/{sha}","languages_url":"https://api.github.com/repos/videogular/videogular2/languages","stargazers_url":"https://api.github.com/repos/videogular/videogular2/stargazers","contributors_url":"https://api.github.com/repos/videogular/videogular2/contributors","subscribers_url":"https://api.github.com/repos/videogular/videogular2/subscribers","subscription_url":"https://api.github.com/repos/videogular/videogular2/subscription","commits_url":"https://api.github.com/repos/videogular/videogular2/commits{/sha}","git_commits_url":"https://api.github.com/repos/videogular/videogular2/git/commits{/sha}","comments_url":"https://api.github.com/repos/videogular/videogular2/comments{/number}","issue_comment_url":"https://api.github.com/repos/videogular/videogular2/issues/comments{/number}","contents_url":"https://api.github.com/repos/videogular/videogular2/contents/{+path}","compare_url":"https://api.github.com/repos/videogular/videogular2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videogular/videogular2/merges","archive_url":"https://api.github.com/repos/videogular/videogular2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videogular/videogular2/downloads","issues_url":"https://api.github.com/repos/videogular/videogular2/issues{/number}","pulls_url":"https://api.github.com/repos/videogular/videogular2/pulls{/number}","milestones_url":"https://api.github.com/repos/videogular/videogular2/milestones{/number}","notifications_url":"https://api.github.com/repos/videogular/videogular2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videogular/videogular2/labels{/name}","releases_url":"https://api.github.com/repos/videogular/videogular2/releases{/id}","deployments_url":"https://api.github.com/repos/videogular/videogular2/deployments","created_at":"2015-10-28T21:35:14Z","updated_at":"2016-12-22T06:30:05Z","pushed_at":"2016-12-27T16:17:02Z","git_url":"git://github.com/videogular/videogular2.git","ssh_url":"git@github.com:videogular/videogular2.git","clone_url":"https://github.com/videogular/videogular2.git","svn_url":"https://github.com/videogular/videogular2","homepage":null,"size":1683,"stargazers_count":87,"watchers_count":87,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":28,"forks":24,"open_issues":28,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videogular/videogular2/pulls/341"},"html":{"href":"https://github.com/videogular/videogular2/pull/341"},"issue":{"href":"https://api.github.com/repos/videogular/videogular2/issues/341"},"comments":{"href":"https://api.github.com/repos/videogular/videogular2/issues/341/comments"},"review_comments":{"href":"https://api.github.com/repos/videogular/videogular2/pulls/341/comments"},"review_comment":{"href":"https://api.github.com/repos/videogular/videogular2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videogular/videogular2/pulls/341/commits"},"statuses":{"href":"https://api.github.com/repos/videogular/videogular2/statuses/8604e70bb7a90f98aa7762c4e5c9956ef43199a1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":15,"deletions":3,"changed_files":5}}
{"actor":{"display_login":"jskrzypek"}}