{"action":"opened","number":1358,"pull_request":{"url":"https://api.github.com/repos/tmpvar/jsdom/pulls/1358","id":56408209,"html_url":"https://github.com/tmpvar/jsdom/pull/1358","diff_url":"https://github.com/tmpvar/jsdom/pull/1358.diff","patch_url":"https://github.com/tmpvar/jsdom/pull/1358.patch","issue_url":"https://api.github.com/repos/tmpvar/jsdom/issues/1358","number":1358,"state":"open","locked":false,"title":"Implement and use adoptNode","user":{"login":"dmethvin","id":157858,"avatar_url":"https://avatars.githubusercontent.com/u/157858?v=3","gravatar_id":"","url":"https://api.github.com/users/dmethvin","html_url":"https://github.com/dmethvin","followers_url":"https://api.github.com/users/dmethvin/followers","following_url":"https://api.github.com/users/dmethvin/following{/other_user}","gists_url":"https://api.github.com/users/dmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmethvin/subscriptions","organizations_url":"https://api.github.com/users/dmethvin/orgs","repos_url":"https://api.github.com/users/dmethvin/repos","events_url":"https://api.github.com/users/dmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/dmethvin/received_events","type":"User","site_admin":false},"body":"Still a WIP at this point. It's passing all tests including the basic adoptNode tests as added but there are no tests yet that use the auto adoption steps. I see some in level3/core.js but that file as a whole can't be run. What's the best way to add tests? Should I write fresh ones for to-upstream, or instead try to rescue the ones in core.js somehow?","created_at":"2016-01-19T00:39:41Z","updated_at":"2016-01-19T00:39:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tmpvar/jsdom/pulls/1358/commits","review_comments_url":"https://api.github.com/repos/tmpvar/jsdom/pulls/1358/comments","review_comment_url":"https://api.github.com/repos/tmpvar/jsdom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tmpvar/jsdom/issues/1358/comments","statuses_url":"https://api.github.com/repos/tmpvar/jsdom/statuses/c33a870a9d245e09fb458f751ceef469447931e2","head":{"label":"dmethvin:717-adoptNode","ref":"717-adoptNode","sha":"c33a870a9d245e09fb458f751ceef469447931e2","user":{"login":"dmethvin","id":157858,"avatar_url":"https://avatars.githubusercontent.com/u/157858?v=3","gravatar_id":"","url":"https://api.github.com/users/dmethvin","html_url":"https://github.com/dmethvin","followers_url":"https://api.github.com/users/dmethvin/followers","following_url":"https://api.github.com/users/dmethvin/following{/other_user}","gists_url":"https://api.github.com/users/dmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmethvin/subscriptions","organizations_url":"https://api.github.com/users/dmethvin/orgs","repos_url":"https://api.github.com/users/dmethvin/repos","events_url":"https://api.github.com/users/dmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/dmethvin/received_events","type":"User","site_admin":false},"repo":{"id":49914487,"name":"jsdom","full_name":"dmethvin/jsdom","owner":{"login":"dmethvin","id":157858,"avatar_url":"https://avatars.githubusercontent.com/u/157858?v=3","gravatar_id":"","url":"https://api.github.com/users/dmethvin","html_url":"https://github.com/dmethvin","followers_url":"https://api.github.com/users/dmethvin/followers","following_url":"https://api.github.com/users/dmethvin/following{/other_user}","gists_url":"https://api.github.com/users/dmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmethvin/subscriptions","organizations_url":"https://api.github.com/users/dmethvin/orgs","repos_url":"https://api.github.com/users/dmethvin/repos","events_url":"https://api.github.com/users/dmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/dmethvin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmethvin/jsdom","description":"A JavaScript implementation of the WHATWG DOM and HTML standards, for use with node.js","fork":true,"url":"https://api.github.com/repos/dmethvin/jsdom","forks_url":"https://api.github.com/repos/dmethvin/jsdom/forks","keys_url":"https://api.github.com/repos/dmethvin/jsdom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmethvin/jsdom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmethvin/jsdom/teams","hooks_url":"https://api.github.com/repos/dmethvin/jsdom/hooks","issue_events_url":"https://api.github.com/repos/dmethvin/jsdom/issues/events{/number}","events_url":"https://api.github.com/repos/dmethvin/jsdom/events","assignees_url":"https://api.github.com/repos/dmethvin/jsdom/assignees{/user}","branches_url":"https://api.github.com/repos/dmethvin/jsdom/branches{/branch}","tags_url":"https://api.github.com/repos/dmethvin/jsdom/tags","blobs_url":"https://api.github.com/repos/dmethvin/jsdom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmethvin/jsdom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmethvin/jsdom/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmethvin/jsdom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmethvin/jsdom/statuses/{sha}","languages_url":"https://api.github.com/repos/dmethvin/jsdom/languages","stargazers_url":"https://api.github.com/repos/dmethvin/jsdom/stargazers","contributors_url":"https://api.github.com/repos/dmethvin/jsdom/contributors","subscribers_url":"https://api.github.com/repos/dmethvin/jsdom/subscribers","subscription_url":"https://api.github.com/repos/dmethvin/jsdom/subscription","commits_url":"https://api.github.com/repos/dmethvin/jsdom/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmethvin/jsdom/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmethvin/jsdom/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmethvin/jsdom/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmethvin/jsdom/contents/{+path}","compare_url":"https://api.github.com/repos/dmethvin/jsdom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmethvin/jsdom/merges","archive_url":"https://api.github.com/repos/dmethvin/jsdom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmethvin/jsdom/downloads","issues_url":"https://api.github.com/repos/dmethvin/jsdom/issues{/number}","pulls_url":"https://api.github.com/repos/dmethvin/jsdom/pulls{/number}","milestones_url":"https://api.github.com/repos/dmethvin/jsdom/milestones{/number}","notifications_url":"https://api.github.com/repos/dmethvin/jsdom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmethvin/jsdom/labels{/name}","releases_url":"https://api.github.com/repos/dmethvin/jsdom/releases{/id}","created_at":"2016-01-19T00:19:27Z","updated_at":"2016-01-19T00:19:29Z","pushed_at":"2016-01-19T00:31:14Z","git_url":"git://github.com/dmethvin/jsdom.git","ssh_url":"git@github.com:dmethvin/jsdom.git","clone_url":"https://github.com/dmethvin/jsdom.git","svn_url":"https://github.com/dmethvin/jsdom","homepage":"","size":10578,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tmpvar:master","ref":"master","sha":"ac321fc52adb15a938c071afc5bca86e49b1584f","user":{"login":"tmpvar","id":46673,"avatar_url":"https://avatars.githubusercontent.com/u/46673?v=3","gravatar_id":"","url":"https://api.github.com/users/tmpvar","html_url":"https://github.com/tmpvar","followers_url":"https://api.github.com/users/tmpvar/followers","following_url":"https://api.github.com/users/tmpvar/following{/other_user}","gists_url":"https://api.github.com/users/tmpvar/gists{/gist_id}","starred_url":"https://api.github.com/users/tmpvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmpvar/subscriptions","organizations_url":"https://api.github.com/users/tmpvar/orgs","repos_url":"https://api.github.com/users/tmpvar/repos","events_url":"https://api.github.com/users/tmpvar/events{/privacy}","received_events_url":"https://api.github.com/users/tmpvar/received_events","type":"User","site_admin":false},"repo":{"id":478584,"name":"jsdom","full_name":"tmpvar/jsdom","owner":{"login":"tmpvar","id":46673,"avatar_url":"https://avatars.githubusercontent.com/u/46673?v=3","gravatar_id":"","url":"https://api.github.com/users/tmpvar","html_url":"https://github.com/tmpvar","followers_url":"https://api.github.com/users/tmpvar/followers","following_url":"https://api.github.com/users/tmpvar/following{/other_user}","gists_url":"https://api.github.com/users/tmpvar/gists{/gist_id}","starred_url":"https://api.github.com/users/tmpvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmpvar/subscriptions","organizations_url":"https://api.github.com/users/tmpvar/orgs","repos_url":"https://api.github.com/users/tmpvar/repos","events_url":"https://api.github.com/users/tmpvar/events{/privacy}","received_events_url":"https://api.github.com/users/tmpvar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmpvar/jsdom","description":"A JavaScript implementation of the WHATWG DOM and HTML standards, for use with node.js","fork":false,"url":"https://api.github.com/repos/tmpvar/jsdom","forks_url":"https://api.github.com/repos/tmpvar/jsdom/forks","keys_url":"https://api.github.com/repos/tmpvar/jsdom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmpvar/jsdom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmpvar/jsdom/teams","hooks_url":"https://api.github.com/repos/tmpvar/jsdom/hooks","issue_events_url":"https://api.github.com/repos/tmpvar/jsdom/issues/events{/number}","events_url":"https://api.github.com/repos/tmpvar/jsdom/events","assignees_url":"https://api.github.com/repos/tmpvar/jsdom/assignees{/user}","branches_url":"https://api.github.com/repos/tmpvar/jsdom/branches{/branch}","tags_url":"https://api.github.com/repos/tmpvar/jsdom/tags","blobs_url":"https://api.github.com/repos/tmpvar/jsdom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmpvar/jsdom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmpvar/jsdom/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmpvar/jsdom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmpvar/jsdom/statuses/{sha}","languages_url":"https://api.github.com/repos/tmpvar/jsdom/languages","stargazers_url":"https://api.github.com/repos/tmpvar/jsdom/stargazers","contributors_url":"https://api.github.com/repos/tmpvar/jsdom/contributors","subscribers_url":"https://api.github.com/repos/tmpvar/jsdom/subscribers","subscription_url":"https://api.github.com/repos/tmpvar/jsdom/subscription","commits_url":"https://api.github.com/repos/tmpvar/jsdom/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmpvar/jsdom/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmpvar/jsdom/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmpvar/jsdom/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmpvar/jsdom/contents/{+path}","compare_url":"https://api.github.com/repos/tmpvar/jsdom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmpvar/jsdom/merges","archive_url":"https://api.github.com/repos/tmpvar/jsdom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmpvar/jsdom/downloads","issues_url":"https://api.github.com/repos/tmpvar/jsdom/issues{/number}","pulls_url":"https://api.github.com/repos/tmpvar/jsdom/pulls{/number}","milestones_url":"https://api.github.com/repos/tmpvar/jsdom/milestones{/number}","notifications_url":"https://api.github.com/repos/tmpvar/jsdom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmpvar/jsdom/labels{/name}","releases_url":"https://api.github.com/repos/tmpvar/jsdom/releases{/id}","created_at":"2010-01-19T06:55:19Z","updated_at":"2016-01-18T20:20:55Z","pushed_at":"2016-01-19T00:36:31Z","git_url":"git://github.com/tmpvar/jsdom.git","ssh_url":"git@github.com:tmpvar/jsdom.git","clone_url":"https://github.com/tmpvar/jsdom.git","svn_url":"https://github.com/tmpvar/jsdom","homepage":"","size":12349,"stargazers_count":5247,"watchers_count":5247,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":588,"mirror_url":null,"open_issues_count":121,"forks":588,"open_issues":121,"watchers":5247,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/1358"},"html":{"href":"https://github.com/tmpvar/jsdom/pull/1358"},"issue":{"href":"https://api.github.com/repos/tmpvar/jsdom/issues/1358"},"comments":{"href":"https://api.github.com/repos/tmpvar/jsdom/issues/1358/comments"},"review_comments":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/1358/comments"},"review_comment":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/1358/commits"},"statuses":{"href":"https://api.github.com/repos/tmpvar/jsdom/statuses/c33a870a9d245e09fb458f751ceef469447931e2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":29,"deletions":1,"changed_files":4}}