{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/53303144","id":53303144,"diff_hunk":"@@ -0,0 +1,89 @@\n+package akka.http.javadsl.server","path":"akka-http/src/main/scala/akka/http/javadsl/server/Rejections.scala","position":4,"original_position":1,"commit_id":"fb7186c2973fbcab9156ecaf054c9b1c7f603d98","original_commit_id":"12035cc5c2932c63b86a3e70001323500659498a","user":{"login":"jypma","id":483519,"avatar_url":"https://avatars.githubusercontent.com/u/483519?v=3","gravatar_id":"","url":"https://api.github.com/users/jypma","html_url":"https://github.com/jypma","followers_url":"https://api.github.com/users/jypma/followers","following_url":"https://api.github.com/users/jypma/following{/other_user}","gists_url":"https://api.github.com/users/jypma/gists{/gist_id}","starred_url":"https://api.github.com/users/jypma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jypma/subscriptions","organizations_url":"https://api.github.com/users/jypma/orgs","repos_url":"https://api.github.com/users/jypma/repos","events_url":"https://api.github.com/users/jypma/events{/privacy}","received_events_url":"https://api.github.com/users/jypma/received_events","type":"User","site_admin":false},"body":"added.","created_at":"2016-02-18T11:39:37Z","updated_at":"2016-02-18T11:39:37Z","html_url":"https://github.com/akka/akka/pull/19632#discussion_r53303144","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/19632","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/53303144"},"html":{"href":"https://github.com/akka/akka/pull/19632#discussion_r53303144"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/19632"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/19632","id":57372433,"html_url":"https://github.com/akka/akka/pull/19632","diff_url":"https://github.com/akka/akka/pull/19632.diff","patch_url":"https://github.com/akka/akka/pull/19632.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/19632","number":19632,"state":"open","locked":false,"title":"WIP #18919 Align Java HTTP server DSL with Scala","user":{"login":"jypma","id":483519,"avatar_url":"https://avatars.githubusercontent.com/u/483519?v=3","gravatar_id":"","url":"https://api.github.com/users/jypma","html_url":"https://github.com/jypma","followers_url":"https://api.github.com/users/jypma/followers","following_url":"https://api.github.com/users/jypma/following{/other_user}","gists_url":"https://api.github.com/users/jypma/gists{/gist_id}","starred_url":"https://api.github.com/users/jypma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jypma/subscriptions","organizations_url":"https://api.github.com/users/jypma/orgs","repos_url":"https://api.github.com/users/jypma/repos","events_url":"https://api.github.com/users/jypma/events{/privacy}","received_events_url":"https://api.github.com/users/jypma/received_events","type":"User","site_admin":false},"body":"This replaces the Java HTTP server DSL with a Java-8 centric one which exposes all scala DSL concepts to be usable from Java, including custom directives, (un)marshallers, rejections, headers, and type safety for path and query parameters. \r\n\r\nImplemented according to the direction agreed upon with @ktoso in https://github.com/akka/akka/issues/18919 . The class `JavaRouteTest` demoes the Java DSL's capabilities, and runs successfully currently (if you move the other test code out of the way).\r\n\r\nList of things to be done (somewhat in order):\r\n- [X] Migrated extra directives: `FileAndResourceDirectives`, `CodingDirectives`,`CookieDirectives`,`MiscDirectives`,  `HostDirectives`, `SchemeDirectives`\r\n- [X] Migrate the existing tests in `akka-http-tests` once the DSL direction is agreed \r\n- [ ] _(in progress)_ Fix compile errors in `akka-docs`\r\n- [ ] Fill in the missing directives that haven't been migrated yet (they're currently commented out): `CacheConditionDirectives`,  `RangeDirectives`,  `WebSocketDirectives`\r\n- [ ] Discuss how to resolve the introduced `TODO` and `FIXME` markers\r\n- [ ] Discuss whether to replace the current Java `RouteTestKit` (which has its own implementation different from the scala `RouteTestKit`) with a [wrapper](https://github.com/jypma/scala-japi/blob/master/akkaStreamsTest/src/main/scala/com/tradeshift/scalajapi/akka/route/RouteTestKit.scala) that delegates and re-uses the scala one.\r\n- [ ] Update textual documentation in `akka-docs`\r\n- [x] MUST: Add `FormFieldDirectives`\r\n- [x] MUST: Add `SecurityDirectives`, possibly Java-model a bit of the related classesupon\r\n- [ ] COULD: Add `DebuggingDirectives`, `FileUploadDirectives`, `RespondWithDirectives`\r\n","created_at":"2016-01-27T15:09:38Z","updated_at":"2016-02-18T11:39:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53459c8ac55e03c09c1a1d082d06fe9d41690e15","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/19632/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/19632/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/19632/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/fb7186c2973fbcab9156ecaf054c9b1c7f603d98","head":{"label":"jypma:java-http-server-dsl","ref":"java-http-server-dsl","sha":"fb7186c2973fbcab9156ecaf054c9b1c7f603d98","user":{"login":"jypma","id":483519,"avatar_url":"https://avatars.githubusercontent.com/u/483519?v=3","gravatar_id":"","url":"https://api.github.com/users/jypma","html_url":"https://github.com/jypma","followers_url":"https://api.github.com/users/jypma/followers","following_url":"https://api.github.com/users/jypma/following{/other_user}","gists_url":"https://api.github.com/users/jypma/gists{/gist_id}","starred_url":"https://api.github.com/users/jypma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jypma/subscriptions","organizations_url":"https://api.github.com/users/jypma/orgs","repos_url":"https://api.github.com/users/jypma/repos","events_url":"https://api.github.com/users/jypma/events{/privacy}","received_events_url":"https://api.github.com/users/jypma/received_events","type":"User","site_admin":false},"repo":{"id":5583654,"name":"akka","full_name":"jypma/akka","owner":{"login":"jypma","id":483519,"avatar_url":"https://avatars.githubusercontent.com/u/483519?v=3","gravatar_id":"","url":"https://api.github.com/users/jypma","html_url":"https://github.com/jypma","followers_url":"https://api.github.com/users/jypma/followers","following_url":"https://api.github.com/users/jypma/following{/other_user}","gists_url":"https://api.github.com/users/jypma/gists{/gist_id}","starred_url":"https://api.github.com/users/jypma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jypma/subscriptions","organizations_url":"https://api.github.com/users/jypma/orgs","repos_url":"https://api.github.com/users/jypma/repos","events_url":"https://api.github.com/users/jypma/events{/privacy}","received_events_url":"https://api.github.com/users/jypma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jypma/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/jypma/akka","forks_url":"https://api.github.com/repos/jypma/akka/forks","keys_url":"https://api.github.com/repos/jypma/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jypma/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jypma/akka/teams","hooks_url":"https://api.github.com/repos/jypma/akka/hooks","issue_events_url":"https://api.github.com/repos/jypma/akka/issues/events{/number}","events_url":"https://api.github.com/repos/jypma/akka/events","assignees_url":"https://api.github.com/repos/jypma/akka/assignees{/user}","branches_url":"https://api.github.com/repos/jypma/akka/branches{/branch}","tags_url":"https://api.github.com/repos/jypma/akka/tags","blobs_url":"https://api.github.com/repos/jypma/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jypma/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jypma/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/jypma/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jypma/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/jypma/akka/languages","stargazers_url":"https://api.github.com/repos/jypma/akka/stargazers","contributors_url":"https://api.github.com/repos/jypma/akka/contributors","subscribers_url":"https://api.github.com/repos/jypma/akka/subscribers","subscription_url":"https://api.github.com/repos/jypma/akka/subscription","commits_url":"https://api.github.com/repos/jypma/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/jypma/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/jypma/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/jypma/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/jypma/akka/contents/{+path}","compare_url":"https://api.github.com/repos/jypma/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jypma/akka/merges","archive_url":"https://api.github.com/repos/jypma/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jypma/akka/downloads","issues_url":"https://api.github.com/repos/jypma/akka/issues{/number}","pulls_url":"https://api.github.com/repos/jypma/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/jypma/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/jypma/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jypma/akka/labels{/name}","releases_url":"https://api.github.com/repos/jypma/akka/releases{/id}","deployments_url":"https://api.github.com/repos/jypma/akka/deployments","created_at":"2012-08-28T09:28:44Z","updated_at":"2013-01-12T00:06:30Z","pushed_at":"2016-02-18T11:07:27Z","git_url":"git://github.com/jypma/akka.git","ssh_url":"git@github.com:jypma/akka.git","clone_url":"https://github.com/jypma/akka.git","svn_url":"https://github.com/jypma/akka","homepage":"http://akka.io","size":171856,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"1200ff2df3dde4b563f1384691ef5e570bbffaa5","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka/deployments","created_at":"2009-02-16T12:51:54Z","updated_at":"2016-02-18T08:04:05Z","pushed_at":"2016-02-18T11:07:29Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":184465,"stargazers_count":5108,"watchers_count":5108,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1567,"mirror_url":null,"open_issues_count":855,"forks":1567,"open_issues":855,"watchers":5108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/19632"},"html":{"href":"https://github.com/akka/akka/pull/19632"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/19632"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/19632/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/19632/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/19632/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/fb7186c2973fbcab9156ecaf054c9b1c7f603d98"}}}}