{"action":"created","issue":{"url":"https://api.github.com/repos/ufz/ogs/issues/1104","repository_url":"https://api.github.com/repos/ufz/ogs","labels_url":"https://api.github.com/repos/ufz/ogs/issues/1104/labels{/name}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/1104/comments","events_url":"https://api.github.com/repos/ufz/ogs/issues/1104/events","html_url":"https://github.com/ufz/ogs/pull/1104","id":141242598,"number":1104,"title":"Cleanup and mem leak fixing","user":{"login":"TomFischer","id":800065,"avatar_url":"https://avatars.githubusercontent.com/u/800065?v=3","gravatar_id":"","url":"https://api.github.com/users/TomFischer","html_url":"https://github.com/TomFischer","followers_url":"https://api.github.com/users/TomFischer/followers","following_url":"https://api.github.com/users/TomFischer/following{/other_user}","gists_url":"https://api.github.com/users/TomFischer/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFischer/subscriptions","organizations_url":"https://api.github.com/users/TomFischer/orgs","repos_url":"https://api.github.com/users/TomFischer/repos","events_url":"https://api.github.com/users/TomFischer/events{/privacy}","received_events_url":"https://api.github.com/users/TomFischer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ufz/ogs/labels/rebase%20and%20merge","name":"rebase and merge","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-03-16T11:18:11Z","updated_at":"2016-03-18T17:35:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/1104","html_url":"https://github.com/ufz/ogs/pull/1104","diff_url":"https://github.com/ufz/ogs/pull/1104.diff","patch_url":"https://github.com/ufz/ogs/pull/1104.patch"},"body":"[GeoLib]\r\n - QuadTree: correction of destructor fixes mem leaks  \r\n\r\n[FileIO]\r\n- Initial implementation of destructor for\r\n  * GMSHInterface\r\n  * GMSHPolygonTree\r\n"},"comment":{"url":"https://api.github.com/repos/ufz/ogs/issues/comments/198464958","html_url":"https://github.com/ufz/ogs/pull/1104#issuecomment-198464958","issue_url":"https://api.github.com/repos/ufz/ogs/issues/1104","id":198464958,"user":{"login":"TomFischer","id":800065,"avatar_url":"https://avatars.githubusercontent.com/u/800065?v=3","gravatar_id":"","url":"https://api.github.com/users/TomFischer","html_url":"https://github.com/TomFischer","followers_url":"https://api.github.com/users/TomFischer/followers","following_url":"https://api.github.com/users/TomFischer/following{/other_user}","gists_url":"https://api.github.com/users/TomFischer/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFischer/subscriptions","organizations_url":"https://api.github.com/users/TomFischer/orgs","repos_url":"https://api.github.com/users/TomFischer/repos","events_url":"https://api.github.com/users/TomFischer/events{/privacy}","received_events_url":"https://api.github.com/users/TomFischer/received_events","type":"User","site_admin":false},"created_at":"2016-03-18T17:35:54Z","updated_at":"2016-03-18T17:35:54Z","body":"> Looks good, though I'd have tried to use unique_ptr's instead of dtor's deletes.\r\n\r\n- I tried to use `std::unique_ptr` with `GMSHInterface::_mesh_density_strategy`. Unfortunately  the `GMSHInterface::_mesh_density_strategy` is handed over to `GMSHPolygonTree`. Maybe a bigger re-design is necessary.\r\n- The `_node_polygon` that is deleted in the destructor of `GMSHPolygonTree`. `GMSHPolygonTree` is derived from `SimplePolygonTree` and `_node_polygon` is a member from `SimplePolygonTree`. But `SimplePolygonTree` should not take responsibility to remove the `_node_polygon`. At the moment I don't see that `unique_ptr` is useful here."}}