{"action":"opened","issue":{"url":"https://api.github.com/repos/flauc/angular2-notifications/issues/96","repository_url":"https://api.github.com/repos/flauc/angular2-notifications","labels_url":"https://api.github.com/repos/flauc/angular2-notifications/issues/96/labels{/name}","comments_url":"https://api.github.com/repos/flauc/angular2-notifications/issues/96/comments","events_url":"https://api.github.com/repos/flauc/angular2-notifications/issues/96/events","html_url":"https://github.com/flauc/angular2-notifications/issues/96","id":186542437,"number":96,"title":"PushNotification close() does not work","user":{"login":"MennoVS","id":14075774,"avatar_url":"https://avatars.githubusercontent.com/u/14075774?v=3","gravatar_id":"","url":"https://api.github.com/users/MennoVS","html_url":"https://github.com/MennoVS","followers_url":"https://api.github.com/users/MennoVS/followers","following_url":"https://api.github.com/users/MennoVS/following{/other_user}","gists_url":"https://api.github.com/users/MennoVS/gists{/gist_id}","starred_url":"https://api.github.com/users/MennoVS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MennoVS/subscriptions","organizations_url":"https://api.github.com/users/MennoVS/orgs","repos_url":"https://api.github.com/users/MennoVS/repos","events_url":"https://api.github.com/users/MennoVS/events{/privacy}","received_events_url":"https://api.github.com/users/MennoVS/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-01T14:07:56Z","updated_at":"2016-11-01T14:07:56Z","closed_at":null,"body":"The close function on the Notification class was overwritten/wrapped to call obs.complete().\r\nHowever I cannot get the notification to close, it doesn't throw any errors either.\r\nIf I remove that code, the notification closes and Notification.onclose is called, in turn calling obs.complete().\r\n\r\nCurrent implementation:\r\n```\r\nn.onclose = () => obs.complete();\r\nn.close = () => {\r\n    n.close.bind(n);\r\n    obs.complete();\r\n};\r\n```\r\n\r\nSuggested fix:\r\n```\r\nn.onclose = () => obs.complete();\r\n// n.close = () => {\r\n//     n.close.bind(n);\r\n//     obs.complete();\r\n// };\r\n```\r\n\r\nIf anyone has a better idea please let me know, else I'll make a PR."}}
{"actor":{"display_login":"MennoVS"}}