{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10276","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10276/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10276/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10276/events","html_url":"https://github.com/ManageIQ/manageiq/pull/10276","id":169585641,"number":10276,"title":"[WIP] Generic toolbar button with disable","user":{"login":"PanSpagetka","id":9535558,"avatar_url":"https://avatars.githubusercontent.com/u/9535558?v=3","gravatar_id":"","url":"https://api.github.com/users/PanSpagetka","html_url":"https://github.com/PanSpagetka","followers_url":"https://api.github.com/users/PanSpagetka/followers","following_url":"https://api.github.com/users/PanSpagetka/following{/other_user}","gists_url":"https://api.github.com/users/PanSpagetka/gists{/gist_id}","starred_url":"https://api.github.com/users/PanSpagetka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PanSpagetka/subscriptions","organizations_url":"https://api.github.com/users/PanSpagetka/orgs","repos_url":"https://api.github.com/users/PanSpagetka/repos","events_url":"https://api.github.com/users/PanSpagetka/events{/privacy}","received_events_url":"https://api.github.com/users/PanSpagetka/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/refactoring","name":"refactoring","color":"fbca04"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/wip","name":"wip","color":"eeeeee"}],"state":"open","locked":false,"assignee":{"login":"dclarizio","id":3433754,"avatar_url":"https://avatars.githubusercontent.com/u/3433754?v=3","gravatar_id":"","url":"https://api.github.com/users/dclarizio","html_url":"https://github.com/dclarizio","followers_url":"https://api.github.com/users/dclarizio/followers","following_url":"https://api.github.com/users/dclarizio/following{/other_user}","gists_url":"https://api.github.com/users/dclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/dclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dclarizio/subscriptions","organizations_url":"https://api.github.com/users/dclarizio/orgs","repos_url":"https://api.github.com/users/dclarizio/repos","events_url":"https://api.github.com/users/dclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/dclarizio/received_events","type":"User","site_admin":false},"assignees":[{"login":"dclarizio","id":3433754,"avatar_url":"https://avatars.githubusercontent.com/u/3433754?v=3","gravatar_id":"","url":"https://api.github.com/users/dclarizio","html_url":"https://github.com/dclarizio","followers_url":"https://api.github.com/users/dclarizio/followers","following_url":"https://api.github.com/users/dclarizio/following{/other_user}","gists_url":"https://api.github.com/users/dclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/dclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dclarizio/subscriptions","organizations_url":"https://api.github.com/users/dclarizio/orgs","repos_url":"https://api.github.com/users/dclarizio/repos","events_url":"https://api.github.com/users/dclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/dclarizio/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-08-05T11:16:46Z","updated_at":"2016-08-09T10:52:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10276","html_url":"https://github.com/ManageIQ/manageiq/pull/10276","diff_url":"https://github.com/ManageIQ/manageiq/pull/10276.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/10276.patch"},"body":"Purpose or Intent\r\n-----------------\r\nBecause during refactoring toolbar buttons, that some of them share pattern. So they dont we dont need separate class for every toolbar button. In this PR i created `GenericFeatureButtonWithDisable` class for second common pattern.\r\n\r\nIn this pattern we are checking if feature is available for this record and this button should be disabled.\r\n\r\nParent issue: #6259\r\nRelated issue: #6554\r\nPivotal Tracker: https://www.pivotaltracker.com/story/show/126786879\r\n"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/238519257","html_url":"https://github.com/ManageIQ/manageiq/pull/10276#issuecomment-238519257","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10276","id":238519257,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-08-09T10:52:24Z","updated_at":"2016-08-09T10:52:24Z","body":"<rubocop />Checked commits https://github.com/PanSpagetka/manageiq/compare/da7de92316f33592dcab424a4af63b0b6308f76c~...897f7f19ebbc281c82ca7b29c8d7eb3e1b5cfcb9 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n3 files checked, 2 offenses detected\n\n**app/helpers/application_helper/button/generic_feature_button_with_disable.rb**\n- [ ] :exclamation: - [Line 9](https://github.com/PanSpagetka/manageiq/blob/897f7f19ebbc281c82ca7b29c8d7eb3e1b5cfcb9/app/helpers/application_helper/button/generic_feature_button_with_disable.rb#L9), Col 5 - [Style/DoubleNegation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/DoubleNegation) - Avoid the use of double negation (`!!`).\n- [ ] :grey_exclamation: - [Line 1](https://github.com/PanSpagetka/manageiq/blob/897f7f19ebbc281c82ca7b29c8d7eb3e1b5cfcb9/app/helpers/application_helper/button/generic_feature_button_with_disable.rb#L1), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [121/120]\n"}}
{"actor":{"display_login":"miq-bot"}}