{"action":"created","issue":{"url":"https://api.github.com/repos/mlr-org/mlrMBO/issues/219","repository_url":"https://api.github.com/repos/mlr-org/mlrMBO","labels_url":"https://api.github.com/repos/mlr-org/mlrMBO/issues/219/labels{/name}","comments_url":"https://api.github.com/repos/mlr-org/mlrMBO/issues/219/comments","events_url":"https://api.github.com/repos/mlr-org/mlrMBO/issues/219/events","html_url":"https://github.com/mlr-org/mlrMBO/pull/219","id":153721971,"number":219,"title":"noisy and minimize should be set before checkLeaner","user":{"login":"ja-thomas","id":7561944,"avatar_url":"https://avatars.githubusercontent.com/u/7561944?v=3","gravatar_id":"","url":"https://api.github.com/users/ja-thomas","html_url":"https://github.com/ja-thomas","followers_url":"https://api.github.com/users/ja-thomas/followers","following_url":"https://api.github.com/users/ja-thomas/following{/other_user}","gists_url":"https://api.github.com/users/ja-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/ja-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ja-thomas/subscriptions","organizations_url":"https://api.github.com/users/ja-thomas/orgs","repos_url":"https://api.github.com/users/ja-thomas/repos","events_url":"https://api.github.com/users/ja-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/ja-thomas/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-09T07:59:06Z","updated_at":"2016-05-11T07:19:54Z","closed_at":"2016-05-10T12:33:02Z","pull_request":{"url":"https://api.github.com/repos/mlr-org/mlrMBO/pulls/219","html_url":"https://github.com/mlr-org/mlrMBO/pull/219","diff_url":"https://github.com/mlr-org/mlrMBO/pull/219.diff","patch_url":"https://github.com/mlr-org/mlrMBO/pull/219.patch"},"body":"If `noisy` and `minimize` aren't set in the control object before `checkLeaner`, it will throw an error.\r\n\r\nNow `exampleRun` seems to work"},"comment":{"url":"https://api.github.com/repos/mlr-org/mlrMBO/issues/comments/218381382","html_url":"https://github.com/mlr-org/mlrMBO/pull/219#issuecomment-218381382","issue_url":"https://api.github.com/repos/mlr-org/mlrMBO/issues/219","id":218381382,"user":{"login":"berndbischl","id":1225974,"avatar_url":"https://avatars.githubusercontent.com/u/1225974?v=3","gravatar_id":"","url":"https://api.github.com/users/berndbischl","html_url":"https://github.com/berndbischl","followers_url":"https://api.github.com/users/berndbischl/followers","following_url":"https://api.github.com/users/berndbischl/following{/other_user}","gists_url":"https://api.github.com/users/berndbischl/gists{/gist_id}","starred_url":"https://api.github.com/users/berndbischl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berndbischl/subscriptions","organizations_url":"https://api.github.com/users/berndbischl/orgs","repos_url":"https://api.github.com/users/berndbischl/repos","events_url":"https://api.github.com/users/berndbischl/events{/privacy}","received_events_url":"https://api.github.com/users/berndbischl/received_events","type":"User","site_admin":false},"created_at":"2016-05-11T07:19:54Z","updated_at":"2016-05-11T07:19:54Z","body":"the problem is that, noisy and minimize are (now) indeed properties of the smoof function.\r\n\r\nbut when @jakobbossek made these changes it was too hard, to completely remove these from the control object. so we agreed to have them still in there. its bad style and can be refactored later.\r\n\r\nBUT: Why, if you guys have detected a bug, dont you add a unit test? And why does the reviewer merge this, without exactly saying this.....?\r\n"}}