{"action":"closed","number":216,"pull_request":{"url":"https://api.github.com/repos/code-corps/code-corps-phoenix/pulls/216","id":85478162,"html_url":"https://github.com/code-corps/code-corps-phoenix/pull/216","diff_url":"https://github.com/code-corps/code-corps-phoenix/pull/216.diff","patch_url":"https://github.com/code-corps/code-corps-phoenix/pull/216.patch","issue_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/issues/216","number":216,"state":"closed","locked":false,"title":"Several fixes to make onboarding and some other features work properly.","user":{"login":"begedin","id":1925540,"avatar_url":"https://avatars.githubusercontent.com/u/1925540?v=3","gravatar_id":"","url":"https://api.github.com/users/begedin","html_url":"https://github.com/begedin","followers_url":"https://api.github.com/users/begedin/followers","following_url":"https://api.github.com/users/begedin/following{/other_user}","gists_url":"https://api.github.com/users/begedin/gists{/gist_id}","starred_url":"https://api.github.com/users/begedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/begedin/subscriptions","organizations_url":"https://api.github.com/users/begedin/orgs","repos_url":"https://api.github.com/users/begedin/repos","events_url":"https://api.github.com/users/begedin/events{/privacy}","received_events_url":"https://api.github.com/users/begedin/received_events","type":"User","site_admin":false},"body":"- UserRoleController was missing index and show endpoints. I added those, but we still need to add tests\r\n- Added routes to support above actions\r\n- Added has_many user-skills to skill view, but I'm not absolutely sure we need that. The ember behavior on the skill onboarding page is weird. We should look into making it simpler.\r\n- Fixed fitlering of emails for unauthenticated user. This was an issue introduced by me today. I was under the impression that conn will get a \"current_user\" assign when authenticated, but the current user is actually assigned to the \"data\" key. I changed the method signature in UserView, but we need to update associated tests and add a test on the user controller, best under the show group, to ensure an authenticated user will get an email. Apparently, the view test wasn't enough.\r\n- **Very important** - Made it so our pipeline always loads the current user if a token is present. The endpoints that do explicitly require authentication should still support requests from authenticated users.\r\n\r\n* [ ] Add tests for UserRoleController #index and #show. Use UserSkillController as example\r\n* [ ] Look into making ember behavior on the skill onboarding page simpler\r\n* [x] Update broken tests on the user view\r\n* [x] Add test for UserController.show, where, when authenticated, the response has the email field properly populated.","created_at":"2016-09-15T20:52:40Z","updated_at":"2016-09-16T22:05:37Z","closed_at":"2016-09-16T22:05:37Z","merged_at":"2016-09-16T22:05:37Z","merge_commit_sha":"9068937a5267f66e49d0419050f29fd1ac219090","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/pulls/216/commits","review_comments_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/pulls/216/comments","review_comment_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/issues/216/comments","statuses_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/statuses/218d166023ab1ed076c64ad465b4468788a5318b","head":{"label":"code-corps:misc-fixes","ref":"misc-fixes","sha":"218d166023ab1ed076c64ad465b4468788a5318b","user":{"login":"code-corps","id":12991115,"avatar_url":"https://avatars.githubusercontent.com/u/12991115?v=3","gravatar_id":"","url":"https://api.github.com/users/code-corps","html_url":"https://github.com/code-corps","followers_url":"https://api.github.com/users/code-corps/followers","following_url":"https://api.github.com/users/code-corps/following{/other_user}","gists_url":"https://api.github.com/users/code-corps/gists{/gist_id}","starred_url":"https://api.github.com/users/code-corps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-corps/subscriptions","organizations_url":"https://api.github.com/users/code-corps/orgs","repos_url":"https://api.github.com/users/code-corps/repos","events_url":"https://api.github.com/users/code-corps/events{/privacy}","received_events_url":"https://api.github.com/users/code-corps/received_events","type":"Organization","site_admin":false},"repo":{"id":63497734,"name":"code-corps-phoenix","full_name":"code-corps/code-corps-phoenix","owner":{"login":"code-corps","id":12991115,"avatar_url":"https://avatars.githubusercontent.com/u/12991115?v=3","gravatar_id":"","url":"https://api.github.com/users/code-corps","html_url":"https://github.com/code-corps","followers_url":"https://api.github.com/users/code-corps/followers","following_url":"https://api.github.com/users/code-corps/following{/other_user}","gists_url":"https://api.github.com/users/code-corps/gists{/gist_id}","starred_url":"https://api.github.com/users/code-corps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-corps/subscriptions","organizations_url":"https://api.github.com/users/code-corps/orgs","repos_url":"https://api.github.com/users/code-corps/repos","events_url":"https://api.github.com/users/code-corps/events{/privacy}","received_events_url":"https://api.github.com/users/code-corps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/code-corps/code-corps-phoenix","description":"Phoenix API for the Code Corps platform.","fork":false,"url":"https://api.github.com/repos/code-corps/code-corps-phoenix","forks_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/forks","keys_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/teams","hooks_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/hooks","issue_events_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/events","assignees_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/tags","blobs_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/languages","stargazers_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/stargazers","contributors_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/contributors","subscribers_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/subscribers","subscription_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/subscription","commits_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/merges","archive_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/downloads","issues_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/labels{/name}","releases_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/releases{/id}","deployments_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/deployments","created_at":"2016-07-16T18:49:25Z","updated_at":"2016-09-15T19:09:47Z","pushed_at":"2016-09-16T22:05:37Z","git_url":"git://github.com/code-corps/code-corps-phoenix.git","ssh_url":"git@github.com:code-corps/code-corps-phoenix.git","clone_url":"https://github.com/code-corps/code-corps-phoenix.git","svn_url":"https://github.com/code-corps/code-corps-phoenix","homepage":null,"size":415,"stargazers_count":16,"watchers_count":16,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":55,"forks":6,"open_issues":55,"watchers":16,"default_branch":"develop"}},"base":{"label":"code-corps:develop","ref":"develop","sha":"738c50a01831265a14659649f57ad22314c9262e","user":{"login":"code-corps","id":12991115,"avatar_url":"https://avatars.githubusercontent.com/u/12991115?v=3","gravatar_id":"","url":"https://api.github.com/users/code-corps","html_url":"https://github.com/code-corps","followers_url":"https://api.github.com/users/code-corps/followers","following_url":"https://api.github.com/users/code-corps/following{/other_user}","gists_url":"https://api.github.com/users/code-corps/gists{/gist_id}","starred_url":"https://api.github.com/users/code-corps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-corps/subscriptions","organizations_url":"https://api.github.com/users/code-corps/orgs","repos_url":"https://api.github.com/users/code-corps/repos","events_url":"https://api.github.com/users/code-corps/events{/privacy}","received_events_url":"https://api.github.com/users/code-corps/received_events","type":"Organization","site_admin":false},"repo":{"id":63497734,"name":"code-corps-phoenix","full_name":"code-corps/code-corps-phoenix","owner":{"login":"code-corps","id":12991115,"avatar_url":"https://avatars.githubusercontent.com/u/12991115?v=3","gravatar_id":"","url":"https://api.github.com/users/code-corps","html_url":"https://github.com/code-corps","followers_url":"https://api.github.com/users/code-corps/followers","following_url":"https://api.github.com/users/code-corps/following{/other_user}","gists_url":"https://api.github.com/users/code-corps/gists{/gist_id}","starred_url":"https://api.github.com/users/code-corps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-corps/subscriptions","organizations_url":"https://api.github.com/users/code-corps/orgs","repos_url":"https://api.github.com/users/code-corps/repos","events_url":"https://api.github.com/users/code-corps/events{/privacy}","received_events_url":"https://api.github.com/users/code-corps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/code-corps/code-corps-phoenix","description":"Phoenix API for the Code Corps platform.","fork":false,"url":"https://api.github.com/repos/code-corps/code-corps-phoenix","forks_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/forks","keys_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/teams","hooks_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/hooks","issue_events_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/events","assignees_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/tags","blobs_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/languages","stargazers_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/stargazers","contributors_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/contributors","subscribers_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/subscribers","subscription_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/subscription","commits_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/merges","archive_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/downloads","issues_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/labels{/name}","releases_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/releases{/id}","deployments_url":"https://api.github.com/repos/code-corps/code-corps-phoenix/deployments","created_at":"2016-07-16T18:49:25Z","updated_at":"2016-09-15T19:09:47Z","pushed_at":"2016-09-16T22:05:37Z","git_url":"git://github.com/code-corps/code-corps-phoenix.git","ssh_url":"git@github.com:code-corps/code-corps-phoenix.git","clone_url":"https://github.com/code-corps/code-corps-phoenix.git","svn_url":"https://github.com/code-corps/code-corps-phoenix","homepage":null,"size":415,"stargazers_count":16,"watchers_count":16,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":55,"forks":6,"open_issues":55,"watchers":16,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/code-corps/code-corps-phoenix/pulls/216"},"html":{"href":"https://github.com/code-corps/code-corps-phoenix/pull/216"},"issue":{"href":"https://api.github.com/repos/code-corps/code-corps-phoenix/issues/216"},"comments":{"href":"https://api.github.com/repos/code-corps/code-corps-phoenix/issues/216/comments"},"review_comments":{"href":"https://api.github.com/repos/code-corps/code-corps-phoenix/pulls/216/comments"},"review_comment":{"href":"https://api.github.com/repos/code-corps/code-corps-phoenix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/code-corps/code-corps-phoenix/pulls/216/commits"},"statuses":{"href":"https://api.github.com/repos/code-corps/code-corps-phoenix/statuses/218d166023ab1ed076c64ad465b4468788a5318b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"JoshSmith","id":321667,"avatar_url":"https://avatars.githubusercontent.com/u/321667?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshSmith","html_url":"https://github.com/JoshSmith","followers_url":"https://api.github.com/users/JoshSmith/followers","following_url":"https://api.github.com/users/JoshSmith/following{/other_user}","gists_url":"https://api.github.com/users/JoshSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshSmith/subscriptions","organizations_url":"https://api.github.com/users/JoshSmith/orgs","repos_url":"https://api.github.com/users/JoshSmith/repos","events_url":"https://api.github.com/users/JoshSmith/events{/privacy}","received_events_url":"https://api.github.com/users/JoshSmith/received_events","type":"User","site_admin":false},"comments":2,"review_comments":1,"commits":1,"additions":40,"deletions":28,"changed_files":10}}
{"actor":{"display_login":"JoshSmith"}}