{"action":"created","comment":{"url":"https://api.github.com/repos/ocaml/opam-repository/pulls/comments/90220710","pull_request_review_id":10741780,"id":90220710,"diff_hunk":"@@ -0,0 +1,20 @@\n+opam-version: \"1.2\"\n+maintainer: \"Etienne Millon <etienne@cryptosense.com>\"\n+author: \"Etienne Millon <etienne@cryptosense.com>\"\n+homepage: \"http://gmplib.org/\"\n+bug-reports: \"https://github.com/ocaml/opam-repository/issues\"\n+dev-repo: \"https://github.com/ocaml/opam-repository.git\"\n+license: \"GPL\"\n+build: [\n+  [\"sh\" \"-exc\" \"cc -c $CFLAGS -I/usr/local/include test.c\"]\n+]\n+depexts: [\n+  [[\"debian\"] [\"libgmp-dev\"]]\n+  [[\"ubuntu\"] [\"libgmp-dev\"]]\n+  [[\"osx\" \"homebrew\"] [\"gmp\"]]\n+  [[\"centos\"] [\"gmp\" \"gmp-devel\"]]\n+  [[\"fedora\"] [\"gmp\" \"gmp-devel\"]]\n+  [[\"openbsd\"] [\"gmp\"]]\n+  [[\"freebsd\"] [\"gmp\"]]\n+  [[\"alpine\"] [\"gmp-dev\"]]\n+]","path":"packages/conf-gmp-powm-sec/conf-gmp-powm-sec.1/opam","position":20,"original_position":20,"commit_id":"bc4e6cbe5c2f1ff0b30d44fa847182d81cc30ffe","original_commit_id":"bc4e6cbe5c2f1ff0b30d44fa847182d81cc30ffe","user":{"login":"avsm","id":53164,"avatar_url":"https://avatars.githubusercontent.com/u/53164?v=3","gravatar_id":"","url":"https://api.github.com/users/avsm","html_url":"https://github.com/avsm","followers_url":"https://api.github.com/users/avsm/followers","following_url":"https://api.github.com/users/avsm/following{/other_user}","gists_url":"https://api.github.com/users/avsm/gists{/gist_id}","starred_url":"https://api.github.com/users/avsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avsm/subscriptions","organizations_url":"https://api.github.com/users/avsm/orgs","repos_url":"https://api.github.com/users/avsm/repos","events_url":"https://api.github.com/users/avsm/events{/privacy}","received_events_url":"https://api.github.com/users/avsm/received_events","type":"User","site_admin":false},"body":"Can this just depend on `conf-gmp` so that we do not repeat the depexts?","created_at":"2016-11-30T12:12:04Z","updated_at":"2016-11-30T12:12:47Z","html_url":"https://github.com/ocaml/opam-repository/pull/7954#discussion_r90220710","pull_request_url":"https://api.github.com/repos/ocaml/opam-repository/pulls/7954","_links":{"self":{"href":"https://api.github.com/repos/ocaml/opam-repository/pulls/comments/90220710"},"html":{"href":"https://github.com/ocaml/opam-repository/pull/7954#discussion_r90220710"},"pull_request":{"href":"https://api.github.com/repos/ocaml/opam-repository/pulls/7954"}}},"pull_request":{"url":"https://api.github.com/repos/ocaml/opam-repository/pulls/7954","id":95729236,"html_url":"https://github.com/ocaml/opam-repository/pull/7954","diff_url":"https://github.com/ocaml/opam-repository/pull/7954.diff","patch_url":"https://github.com/ocaml/opam-repository/pull/7954.patch","issue_url":"https://api.github.com/repos/ocaml/opam-repository/issues/7954","number":7954,"state":"open","locked":false,"title":"Add conf-gmp-powm-sec","user":{"login":"emillon","id":496345,"avatar_url":"https://avatars.githubusercontent.com/u/496345?v=3","gravatar_id":"","url":"https://api.github.com/users/emillon","html_url":"https://github.com/emillon","followers_url":"https://api.github.com/users/emillon/followers","following_url":"https://api.github.com/users/emillon/following{/other_user}","gists_url":"https://api.github.com/users/emillon/gists{/gist_id}","starred_url":"https://api.github.com/users/emillon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emillon/subscriptions","organizations_url":"https://api.github.com/users/emillon/orgs","repos_url":"https://api.github.com/users/emillon/repos","events_url":"https://api.github.com/users/emillon/events{/privacy}","received_events_url":"https://api.github.com/users/emillon/received_events","type":"User","site_admin":false},"body":"This adds a conf-gmp-powm-sec package that checks that the GMP library installed supports `mpz_powm_sec`, a function to perform modular exponentiation in constant time. `cryptokit.1.11` relies on this function being available in its RSA implementation (through `zarith`), or otherwise fails at runtime.\r\n\r\ncc @avsm @xavierleroy that's the followup we discussed in #7892.\r\n\r\nThanks!","created_at":"2016-11-29T16:42:03Z","updated_at":"2016-11-30T12:12:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f59a1ba1e1d7d41f2d2a26e70eb8139a34199f78","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/opam-repository/pulls/7954/commits","review_comments_url":"https://api.github.com/repos/ocaml/opam-repository/pulls/7954/comments","review_comment_url":"https://api.github.com/repos/ocaml/opam-repository/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/opam-repository/issues/7954/comments","statuses_url":"https://api.github.com/repos/ocaml/opam-repository/statuses/bc4e6cbe5c2f1ff0b30d44fa847182d81cc30ffe","head":{"label":"emillon:cryptokit-gmp","ref":"cryptokit-gmp","sha":"bc4e6cbe5c2f1ff0b30d44fa847182d81cc30ffe","user":{"login":"emillon","id":496345,"avatar_url":"https://avatars.githubusercontent.com/u/496345?v=3","gravatar_id":"","url":"https://api.github.com/users/emillon","html_url":"https://github.com/emillon","followers_url":"https://api.github.com/users/emillon/followers","following_url":"https://api.github.com/users/emillon/following{/other_user}","gists_url":"https://api.github.com/users/emillon/gists{/gist_id}","starred_url":"https://api.github.com/users/emillon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emillon/subscriptions","organizations_url":"https://api.github.com/users/emillon/orgs","repos_url":"https://api.github.com/users/emillon/repos","events_url":"https://api.github.com/users/emillon/events{/privacy}","received_events_url":"https://api.github.com/users/emillon/received_events","type":"User","site_admin":false},"repo":{"id":40113888,"name":"opam-repository","full_name":"emillon/opam-repository","owner":{"login":"emillon","id":496345,"avatar_url":"https://avatars.githubusercontent.com/u/496345?v=3","gravatar_id":"","url":"https://api.github.com/users/emillon","html_url":"https://github.com/emillon","followers_url":"https://api.github.com/users/emillon/followers","following_url":"https://api.github.com/users/emillon/following{/other_user}","gists_url":"https://api.github.com/users/emillon/gists{/gist_id}","starred_url":"https://api.github.com/users/emillon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emillon/subscriptions","organizations_url":"https://api.github.com/users/emillon/orgs","repos_url":"https://api.github.com/users/emillon/repos","events_url":"https://api.github.com/users/emillon/events{/privacy}","received_events_url":"https://api.github.com/users/emillon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emillon/opam-repository","description":"Main public package repository for OPAM, the source package manager of OCaml.","fork":true,"url":"https://api.github.com/repos/emillon/opam-repository","forks_url":"https://api.github.com/repos/emillon/opam-repository/forks","keys_url":"https://api.github.com/repos/emillon/opam-repository/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emillon/opam-repository/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emillon/opam-repository/teams","hooks_url":"https://api.github.com/repos/emillon/opam-repository/hooks","issue_events_url":"https://api.github.com/repos/emillon/opam-repository/issues/events{/number}","events_url":"https://api.github.com/repos/emillon/opam-repository/events","assignees_url":"https://api.github.com/repos/emillon/opam-repository/assignees{/user}","branches_url":"https://api.github.com/repos/emillon/opam-repository/branches{/branch}","tags_url":"https://api.github.com/repos/emillon/opam-repository/tags","blobs_url":"https://api.github.com/repos/emillon/opam-repository/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emillon/opam-repository/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emillon/opam-repository/git/refs{/sha}","trees_url":"https://api.github.com/repos/emillon/opam-repository/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emillon/opam-repository/statuses/{sha}","languages_url":"https://api.github.com/repos/emillon/opam-repository/languages","stargazers_url":"https://api.github.com/repos/emillon/opam-repository/stargazers","contributors_url":"https://api.github.com/repos/emillon/opam-repository/contributors","subscribers_url":"https://api.github.com/repos/emillon/opam-repository/subscribers","subscription_url":"https://api.github.com/repos/emillon/opam-repository/subscription","commits_url":"https://api.github.com/repos/emillon/opam-repository/commits{/sha}","git_commits_url":"https://api.github.com/repos/emillon/opam-repository/git/commits{/sha}","comments_url":"https://api.github.com/repos/emillon/opam-repository/comments{/number}","issue_comment_url":"https://api.github.com/repos/emillon/opam-repository/issues/comments{/number}","contents_url":"https://api.github.com/repos/emillon/opam-repository/contents/{+path}","compare_url":"https://api.github.com/repos/emillon/opam-repository/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emillon/opam-repository/merges","archive_url":"https://api.github.com/repos/emillon/opam-repository/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emillon/opam-repository/downloads","issues_url":"https://api.github.com/repos/emillon/opam-repository/issues{/number}","pulls_url":"https://api.github.com/repos/emillon/opam-repository/pulls{/number}","milestones_url":"https://api.github.com/repos/emillon/opam-repository/milestones{/number}","notifications_url":"https://api.github.com/repos/emillon/opam-repository/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emillon/opam-repository/labels{/name}","releases_url":"https://api.github.com/repos/emillon/opam-repository/releases{/id}","deployments_url":"https://api.github.com/repos/emillon/opam-repository/deployments","created_at":"2015-08-03T08:29:22Z","updated_at":"2016-06-15T15:31:43Z","pushed_at":"2016-11-29T16:34:26Z","git_url":"git://github.com/emillon/opam-repository.git","ssh_url":"git@github.com:emillon/opam-repository.git","clone_url":"https://github.com/emillon/opam-repository.git","svn_url":"https://github.com/emillon/opam-repository","homepage":"opam.ocaml.org","size":25908,"stargazers_count":1,"watchers_count":1,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ocaml:master","ref":"master","sha":"d5afb4410565fc6f3da8c6fcbc1d7e6b1a25202e","user":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":4508653,"name":"opam-repository","full_name":"ocaml/opam-repository","owner":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/opam-repository","description":"Main public package repository for OPAM, the source package manager of OCaml.","fork":false,"url":"https://api.github.com/repos/ocaml/opam-repository","forks_url":"https://api.github.com/repos/ocaml/opam-repository/forks","keys_url":"https://api.github.com/repos/ocaml/opam-repository/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/opam-repository/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/opam-repository/teams","hooks_url":"https://api.github.com/repos/ocaml/opam-repository/hooks","issue_events_url":"https://api.github.com/repos/ocaml/opam-repository/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/opam-repository/events","assignees_url":"https://api.github.com/repos/ocaml/opam-repository/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/opam-repository/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/opam-repository/tags","blobs_url":"https://api.github.com/repos/ocaml/opam-repository/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/opam-repository/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/opam-repository/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/opam-repository/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/opam-repository/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/opam-repository/languages","stargazers_url":"https://api.github.com/repos/ocaml/opam-repository/stargazers","contributors_url":"https://api.github.com/repos/ocaml/opam-repository/contributors","subscribers_url":"https://api.github.com/repos/ocaml/opam-repository/subscribers","subscription_url":"https://api.github.com/repos/ocaml/opam-repository/subscription","commits_url":"https://api.github.com/repos/ocaml/opam-repository/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/opam-repository/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/opam-repository/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/opam-repository/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/opam-repository/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/opam-repository/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/opam-repository/merges","archive_url":"https://api.github.com/repos/ocaml/opam-repository/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/opam-repository/downloads","issues_url":"https://api.github.com/repos/ocaml/opam-repository/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/opam-repository/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/opam-repository/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/opam-repository/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/opam-repository/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/opam-repository/releases{/id}","deployments_url":"https://api.github.com/repos/ocaml/opam-repository/deployments","created_at":"2012-05-31T14:25:57Z","updated_at":"2016-11-15T21:05:09Z","pushed_at":"2016-11-30T11:53:50Z","git_url":"git://github.com/ocaml/opam-repository.git","ssh_url":"git@github.com:ocaml/opam-repository.git","clone_url":"https://github.com/ocaml/opam-repository.git","svn_url":"https://github.com/ocaml/opam-repository","homepage":"https://opam.ocaml.org","size":35397,"stargazers_count":166,"watchers_count":166,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":385,"mirror_url":null,"open_issues_count":85,"forks":385,"open_issues":85,"watchers":166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/opam-repository/pulls/7954"},"html":{"href":"https://github.com/ocaml/opam-repository/pull/7954"},"issue":{"href":"https://api.github.com/repos/ocaml/opam-repository/issues/7954"},"comments":{"href":"https://api.github.com/repos/ocaml/opam-repository/issues/7954/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/opam-repository/pulls/7954/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/opam-repository/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/opam-repository/pulls/7954/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/opam-repository/statuses/bc4e6cbe5c2f1ff0b30d44fa847182d81cc30ffe"}}}}
{"actor":{"display_login":"avsm"}}