{"action":"created","issue":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/802","repository_url":"https://api.github.com/repos/vufind-org/vufind","labels_url":"https://api.github.com/repos/vufind-org/vufind/issues/802/labels{/name}","comments_url":"https://api.github.com/repos/vufind-org/vufind/issues/802/comments","events_url":"https://api.github.com/repos/vufind-org/vufind/issues/802/events","html_url":"https://github.com/vufind-org/vufind/pull/802","id":178640129,"number":802,"title":"Form attribute support","user":{"login":"crhallberg","id":451107,"avatar_url":"https://avatars.githubusercontent.com/u/451107?v=3","gravatar_id":"","url":"https://api.github.com/users/crhallberg","html_url":"https://github.com/crhallberg","followers_url":"https://api.github.com/users/crhallberg/followers","following_url":"https://api.github.com/users/crhallberg/following{/other_user}","gists_url":"https://api.github.com/users/crhallberg/gists{/gist_id}","starred_url":"https://api.github.com/users/crhallberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crhallberg/subscriptions","organizations_url":"https://api.github.com/users/crhallberg/orgs","repos_url":"https://api.github.com/users/crhallberg/repos","events_url":"https://api.github.com/users/crhallberg/events{/privacy}","received_events_url":"https://api.github.com/users/crhallberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-22T15:21:21Z","updated_at":"2016-09-26T16:10:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vufind-org/vufind/pulls/802","html_url":"https://github.com/vufind-org/vufind/pull/802","diff_url":"https://github.com/vufind-org/vufind/pull/802.diff","patch_url":"https://github.com/vufind-org/vufind/pull/802.patch"},"body":"Add support for the [`form=\"id\"` attribute on input elements](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input#attr-form). This new feature is then applied to [remove the hack](https://github.com/vufind-org/vufind/pull/802/files#diff-8c13fdc465a565f98bde2c279226f8f8L69) that allowed us to use forms within forms for embedded records.\r\n\r\nUnfortunately, IE removed support from conditional loading after IE 9. This means we need to load the [polyfill](https://github.com/vufind-org/vufind/pull/802/files#diff-5) for all browsers and skip the logic addition for those that [support it](http://caniuse.com/#feat=form-attribute). The asset pipeline makes this negligible for production performance.\r\n\r\n- [x] IE testing\r\n- [x] Fix polyfill"},"comment":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/comments/249616877","html_url":"https://github.com/vufind-org/vufind/pull/802#issuecomment-249616877","issue_url":"https://api.github.com/repos/vufind-org/vufind/issues/802","id":249616877,"user":{"login":"demiankatz","id":309069,"avatar_url":"https://avatars.githubusercontent.com/u/309069?v=3","gravatar_id":"","url":"https://api.github.com/users/demiankatz","html_url":"https://github.com/demiankatz","followers_url":"https://api.github.com/users/demiankatz/followers","following_url":"https://api.github.com/users/demiankatz/following{/other_user}","gists_url":"https://api.github.com/users/demiankatz/gists{/gist_id}","starred_url":"https://api.github.com/users/demiankatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demiankatz/subscriptions","organizations_url":"https://api.github.com/users/demiankatz/orgs","repos_url":"https://api.github.com/users/demiankatz/repos","events_url":"https://api.github.com/users/demiankatz/events{/privacy}","received_events_url":"https://api.github.com/users/demiankatz/received_events","type":"User","site_admin":false},"created_at":"2016-09-26T16:10:44Z","updated_at":"2016-09-26T16:10:44Z","body":"I can't seem to add items to my cart in Firefox 49 when using this branch."}}
{"actor":{"display_login":"demiankatz"}}