{"action":"created","issue":{"url":"https://api.github.com/repos/lightstep/lightstep-tracer-java/issues/19","repository_url":"https://api.github.com/repos/lightstep/lightstep-tracer-java","labels_url":"https://api.github.com/repos/lightstep/lightstep-tracer-java/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/lightstep/lightstep-tracer-java/issues/19/comments","events_url":"https://api.github.com/repos/lightstep/lightstep-tracer-java/issues/19/events","html_url":"https://github.com/lightstep/lightstep-tracer-java/pull/19","id":165951210,"number":19,"title":"Add inject and extract for TextMap","user":{"login":"bensigelman","id":2251553,"avatar_url":"https://avatars.githubusercontent.com/u/2251553?v=3","gravatar_id":"","url":"https://api.github.com/users/bensigelman","html_url":"https://github.com/bensigelman","followers_url":"https://api.github.com/users/bensigelman/followers","following_url":"https://api.github.com/users/bensigelman/following{/other_user}","gists_url":"https://api.github.com/users/bensigelman/gists{/gist_id}","starred_url":"https://api.github.com/users/bensigelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bensigelman/subscriptions","organizations_url":"https://api.github.com/users/bensigelman/orgs","repos_url":"https://api.github.com/users/bensigelman/repos","events_url":"https://api.github.com/users/bensigelman/events{/privacy}","received_events_url":"https://api.github.com/users/bensigelman/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-07-16T22:52:45Z","updated_at":"2016-07-17T21:30:04Z","closed_at":"2016-07-17T20:32:27Z","pull_request":{"url":"https://api.github.com/repos/lightstep/lightstep-tracer-java/pulls/19","html_url":"https://github.com/lightstep/lightstep-tracer-java/pull/19","diff_url":"https://github.com/lightstep/lightstep-tracer-java/pull/19.diff","patch_url":"https://github.com/lightstep/lightstep-tracer-java/pull/19.patch"},"body":"Manual tests happened; automated tests did not.\r\n\r\n@bcronin I didn't see a place to add automated tests for the `common/` code, so I decided to wait for instructions about how to do so before adding such things. Or should I just add them on the JRE side and leave it at that?\r\n\r\nManual testing did reveal one important bug (I'll point it out)."},"comment":{"url":"https://api.github.com/repos/lightstep/lightstep-tracer-java/issues/comments/233205320","html_url":"https://github.com/lightstep/lightstep-tracer-java/pull/19#issuecomment-233205320","issue_url":"https://api.github.com/repos/lightstep/lightstep-tracer-java/issues/19","id":233205320,"user":{"login":"bcronin","id":432893,"avatar_url":"https://avatars.githubusercontent.com/u/432893?v=3","gravatar_id":"","url":"https://api.github.com/users/bcronin","html_url":"https://github.com/bcronin","followers_url":"https://api.github.com/users/bcronin/followers","following_url":"https://api.github.com/users/bcronin/following{/other_user}","gists_url":"https://api.github.com/users/bcronin/gists{/gist_id}","starred_url":"https://api.github.com/users/bcronin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcronin/subscriptions","organizations_url":"https://api.github.com/users/bcronin/orgs","repos_url":"https://api.github.com/users/bcronin/repos","events_url":"https://api.github.com/users/bcronin/events{/privacy}","received_events_url":"https://api.github.com/users/bcronin/received_events","type":"User","site_admin":false},"created_at":"2016-07-17T21:30:04Z","updated_at":"2016-07-17T21:30:04Z","body":"The `common/` directory doesn't build directly to anything, so that's correct that adding tests to the JRE build is easiest."}}
{"actor":{"display_login":"bcronin"}}