{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/leshan/pulls/comments/70404021","id":70404021,"diff_hunk":"@@ -192,7 +188,12 @@ public void onError(String clientEndpoint, String requestTicket, Exception excep\n         };\n     }\n \n-    private void processResponse(String clientEndpoint, String requestTicket, final LwM2mResponse response) {\n+    private QueuedRequestImpl newQueueRequestEntity(String endpoint, DownlinkRequest<LwM2mResponse> request,","path":"leshan-server-core/src/main/java/org/eclipse/leshan/server/queue/impl/QueuedRequestSender.java","position":48,"original_position":48,"commit_id":"8b5044dc833a86290948b6bd089e44e800490b17","original_commit_id":"8b5044dc833a86290948b6bd089e44e800490b17","user":{"login":"sbernard31","id":840294,"avatar_url":"https://avatars.githubusercontent.com/u/840294?v=3","gravatar_id":"","url":"https://api.github.com/users/sbernard31","html_url":"https://github.com/sbernard31","followers_url":"https://api.github.com/users/sbernard31/followers","following_url":"https://api.github.com/users/sbernard31/following{/other_user}","gists_url":"https://api.github.com/users/sbernard31/gists{/gist_id}","starred_url":"https://api.github.com/users/sbernard31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbernard31/subscriptions","organizations_url":"https://api.github.com/users/sbernard31/orgs","repos_url":"https://api.github.com/users/sbernard31/repos","events_url":"https://api.github.com/users/sbernard31/events{/privacy}","received_events_url":"https://api.github.com/users/sbernard31/received_events","type":"User","site_admin":false},"body":"I think this method could be removed.","created_at":"2016-07-12T09:21:43Z","updated_at":"2016-07-12T09:21:43Z","html_url":"https://github.com/eclipse/leshan/pull/152#discussion_r70404021","pull_request_url":"https://api.github.com/repos/eclipse/leshan/pulls/152","_links":{"self":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/comments/70404021"},"html":{"href":"https://github.com/eclipse/leshan/pull/152#discussion_r70404021"},"pull_request":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/leshan/pulls/152","id":76443373,"html_url":"https://github.com/eclipse/leshan/pull/152","diff_url":"https://github.com/eclipse/leshan/pull/152.diff","patch_url":"https://github.com/eclipse/leshan/pull/152.patch","issue_url":"https://api.github.com/repos/eclipse/leshan/issues/152","number":152,"state":"open","locked":false,"title":"Cluster ready Queue Mode","user":{"login":"balsmn","id":17613889,"avatar_url":"https://avatars.githubusercontent.com/u/17613889?v=3","gravatar_id":"","url":"https://api.github.com/users/balsmn","html_url":"https://github.com/balsmn","followers_url":"https://api.github.com/users/balsmn/followers","following_url":"https://api.github.com/users/balsmn/following{/other_user}","gists_url":"https://api.github.com/users/balsmn/gists{/gist_id}","starred_url":"https://api.github.com/users/balsmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balsmn/subscriptions","organizations_url":"https://api.github.com/users/balsmn/orgs","repos_url":"https://api.github.com/users/balsmn/repos","events_url":"https://api.github.com/users/balsmn/events{/privacy}","received_events_url":"https://api.github.com/users/balsmn/received_events","type":"User","site_admin":false},"body":"This PR aims to implement the the new send API (with RequestTicket) for QueueMode.\r\n\r\n## LwM2mRequestSender\r\n\r\nThe new `LwM2mRequestSender `is a listener based instead of callbacks. Callbacks are not cluster friendly. All the previous send methods using callbacks are marked deprecated. It also has two new methods to add/remove `ResponseListener`. A `ResponseListener `gets notified when a response or error response is received from a LWM2M client. Each request and its response is correlated by means of a RequestTicket.\r\n\r\nThere is now a concrete implementation `LwM2mRequestSenderImpl `of the `LwM2mRequestSender `interface which is aware of the client binding mode and delegates the call to either to a `QueuedRequestSender `or to a `CaliforniumLwM2mRequestSender`. `LwM2mRequestSenderImpl `not only processes requests but also invokes `ResponseListener `based on clients binding mode. \r\n\r\n## QueuedRequestSender\r\n\r\n`QueuedRequestSender `doesn't implement the deprecated methods of `LwM2mRequestSender `and is also not aware of clients binding mode. This responsiblity is now moved to `LwM2mRequestSenderImpl `as described above.\r\n\r\nSigned-off-by: Bala Azhagappan <balasubramanian.azhagappan@bosch-si.com>","created_at":"2016-07-06T14:39:09Z","updated_at":"2016-07-12T09:21:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1aad4c6d31c3e542b3dccc77ebfd14eadbb118cb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/leshan/pulls/152/commits","review_comments_url":"https://api.github.com/repos/eclipse/leshan/pulls/152/comments","review_comment_url":"https://api.github.com/repos/eclipse/leshan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/leshan/issues/152/comments","statuses_url":"https://api.github.com/repos/eclipse/leshan/statuses/8b5044dc833a86290948b6bd089e44e800490b17","head":{"label":"bsinno:cluster_queue_mode","ref":"cluster_queue_mode","sha":"8b5044dc833a86290948b6bd089e44e800490b17","user":{"login":"bsinno","id":9215699,"avatar_url":"https://avatars.githubusercontent.com/u/9215699?v=3","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"repo":{"id":33526125,"name":"leshan","full_name":"bsinno/leshan","owner":{"login":"bsinno","id":9215699,"avatar_url":"https://avatars.githubusercontent.com/u/9215699?v=3","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bsinno/leshan","description":"Leshan is an OMA Lightweight M2M (LWM2M) implementation in Java.","fork":true,"url":"https://api.github.com/repos/bsinno/leshan","forks_url":"https://api.github.com/repos/bsinno/leshan/forks","keys_url":"https://api.github.com/repos/bsinno/leshan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsinno/leshan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsinno/leshan/teams","hooks_url":"https://api.github.com/repos/bsinno/leshan/hooks","issue_events_url":"https://api.github.com/repos/bsinno/leshan/issues/events{/number}","events_url":"https://api.github.com/repos/bsinno/leshan/events","assignees_url":"https://api.github.com/repos/bsinno/leshan/assignees{/user}","branches_url":"https://api.github.com/repos/bsinno/leshan/branches{/branch}","tags_url":"https://api.github.com/repos/bsinno/leshan/tags","blobs_url":"https://api.github.com/repos/bsinno/leshan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsinno/leshan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsinno/leshan/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsinno/leshan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsinno/leshan/statuses/{sha}","languages_url":"https://api.github.com/repos/bsinno/leshan/languages","stargazers_url":"https://api.github.com/repos/bsinno/leshan/stargazers","contributors_url":"https://api.github.com/repos/bsinno/leshan/contributors","subscribers_url":"https://api.github.com/repos/bsinno/leshan/subscribers","subscription_url":"https://api.github.com/repos/bsinno/leshan/subscription","commits_url":"https://api.github.com/repos/bsinno/leshan/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsinno/leshan/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsinno/leshan/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsinno/leshan/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsinno/leshan/contents/{+path}","compare_url":"https://api.github.com/repos/bsinno/leshan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsinno/leshan/merges","archive_url":"https://api.github.com/repos/bsinno/leshan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsinno/leshan/downloads","issues_url":"https://api.github.com/repos/bsinno/leshan/issues{/number}","pulls_url":"https://api.github.com/repos/bsinno/leshan/pulls{/number}","milestones_url":"https://api.github.com/repos/bsinno/leshan/milestones{/number}","notifications_url":"https://api.github.com/repos/bsinno/leshan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsinno/leshan/labels{/name}","releases_url":"https://api.github.com/repos/bsinno/leshan/releases{/id}","deployments_url":"https://api.github.com/repos/bsinno/leshan/deployments","created_at":"2015-04-07T06:27:49Z","updated_at":"2016-01-11T23:22:17Z","pushed_at":"2016-07-06T14:39:02Z","git_url":"git://github.com/bsinno/leshan.git","ssh_url":"git@github.com:bsinno/leshan.git","clone_url":"https://github.com/bsinno/leshan.git","svn_url":"https://github.com/bsinno/leshan","homepage":null,"size":2262,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:cluster_queue_mode","ref":"cluster_queue_mode","sha":"ebe6ac473d0e821bffe3d3c59d5c649d2332448a","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":30419413,"name":"leshan","full_name":"eclipse/leshan","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/leshan","description":"Leshan is an OMA Lightweight M2M (LWM2M) implementation in Java.","fork":false,"url":"https://api.github.com/repos/eclipse/leshan","forks_url":"https://api.github.com/repos/eclipse/leshan/forks","keys_url":"https://api.github.com/repos/eclipse/leshan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/leshan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/leshan/teams","hooks_url":"https://api.github.com/repos/eclipse/leshan/hooks","issue_events_url":"https://api.github.com/repos/eclipse/leshan/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/leshan/events","assignees_url":"https://api.github.com/repos/eclipse/leshan/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/leshan/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/leshan/tags","blobs_url":"https://api.github.com/repos/eclipse/leshan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/leshan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/leshan/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/leshan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/leshan/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/leshan/languages","stargazers_url":"https://api.github.com/repos/eclipse/leshan/stargazers","contributors_url":"https://api.github.com/repos/eclipse/leshan/contributors","subscribers_url":"https://api.github.com/repos/eclipse/leshan/subscribers","subscription_url":"https://api.github.com/repos/eclipse/leshan/subscription","commits_url":"https://api.github.com/repos/eclipse/leshan/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/leshan/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/leshan/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/leshan/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/leshan/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/leshan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/leshan/merges","archive_url":"https://api.github.com/repos/eclipse/leshan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/leshan/downloads","issues_url":"https://api.github.com/repos/eclipse/leshan/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/leshan/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/leshan/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/leshan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/leshan/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/leshan/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/leshan/deployments","created_at":"2015-02-06T15:44:24Z","updated_at":"2016-07-09T17:42:29Z","pushed_at":"2016-07-08T15:26:10Z","git_url":"git://github.com/eclipse/leshan.git","ssh_url":"git@github.com:eclipse/leshan.git","clone_url":"https://github.com/eclipse/leshan.git","svn_url":"https://github.com/eclipse/leshan","homepage":null,"size":3286,"stargazers_count":94,"watchers_count":94,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":11,"forks":79,"open_issues":11,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/152"},"html":{"href":"https://github.com/eclipse/leshan/pull/152"},"issue":{"href":"https://api.github.com/repos/eclipse/leshan/issues/152"},"comments":{"href":"https://api.github.com/repos/eclipse/leshan/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/leshan/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/leshan/statuses/8b5044dc833a86290948b6bd089e44e800490b17"}}}}
{"actor":{"display_login":"sbernard31"}}