{"action":"closed","number":137,"pull_request":{"url":"https://api.github.com/repos/Kitware/candela/pulls/137","id":67620474,"html_url":"https://github.com/Kitware/candela/pull/137","diff_url":"https://github.com/Kitware/candela/pull/137.diff","patch_url":"https://github.com/Kitware/candela/pull/137.patch","issue_url":"https://api.github.com/repos/Kitware/candela/issues/137","number":137,"state":"closed","locked":false,"title":"Promises and other cleanup","user":{"login":"jeffbaumes","id":81305,"avatar_url":"https://avatars.githubusercontent.com/u/81305?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffbaumes","html_url":"https://github.com/jeffbaumes","followers_url":"https://api.github.com/users/jeffbaumes/followers","following_url":"https://api.github.com/users/jeffbaumes/following{/other_user}","gists_url":"https://api.github.com/users/jeffbaumes/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffbaumes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffbaumes/subscriptions","organizations_url":"https://api.github.com/users/jeffbaumes/orgs","repos_url":"https://api.github.com/users/jeffbaumes/repos","events_url":"https://api.github.com/users/jeffbaumes/events{/privacy}","received_events_url":"https://api.github.com/users/jeffbaumes/received_events","type":"User","site_admin":false},"body":"A set of fixes / features:\r\n\r\n* `tests.bundle.js` was not correctly excluding the image tests during unit testing, which caused a Phantom error and not all tests were run. This is now fixed.\r\n* VisComponent now stores the second constructor argument in `this.options` for convenience for subclasses.\r\n* The Vega util is no longer an old-style pseudoclass with a state, since our components now can track state. Instead it is a single `parseChart` function that returns the Vega chart as a promise after translating the spec template and rendering it with Vega.\r\n* Now all the Vega-based charts have the correct superclass (yay)\r\n* Fixed up the Vega unit tests to import as `vega` instead of `vcharts`. Now hardly any vestiges of `vcharts` in the codebase.","created_at":"2016-04-23T22:19:01Z","updated_at":"2016-05-02T16:28:50Z","closed_at":"2016-05-02T16:28:50Z","merged_at":"2016-05-02T16:28:50Z","merge_commit_sha":"c04940ebf91d89d1eb620a9ed951a7f76c831df0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Kitware/candela/pulls/137/commits","review_comments_url":"https://api.github.com/repos/Kitware/candela/pulls/137/comments","review_comment_url":"https://api.github.com/repos/Kitware/candela/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kitware/candela/issues/137/comments","statuses_url":"https://api.github.com/repos/Kitware/candela/statuses/c04940ebf91d89d1eb620a9ed951a7f76c831df0","head":{"label":"Kitware:promises","ref":"promises","sha":"c04940ebf91d89d1eb620a9ed951a7f76c831df0","user":{"login":"Kitware","id":87549,"avatar_url":"https://avatars.githubusercontent.com/u/87549?v=3","gravatar_id":"","url":"https://api.github.com/users/Kitware","html_url":"https://github.com/Kitware","followers_url":"https://api.github.com/users/Kitware/followers","following_url":"https://api.github.com/users/Kitware/following{/other_user}","gists_url":"https://api.github.com/users/Kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/Kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kitware/subscriptions","organizations_url":"https://api.github.com/users/Kitware/orgs","repos_url":"https://api.github.com/users/Kitware/repos","events_url":"https://api.github.com/users/Kitware/events{/privacy}","received_events_url":"https://api.github.com/users/Kitware/received_events","type":"Organization","site_admin":false},"repo":{"id":52388867,"name":"candela","full_name":"Kitware/candela","owner":{"login":"Kitware","id":87549,"avatar_url":"https://avatars.githubusercontent.com/u/87549?v=3","gravatar_id":"","url":"https://api.github.com/users/Kitware","html_url":"https://github.com/Kitware","followers_url":"https://api.github.com/users/Kitware/followers","following_url":"https://api.github.com/users/Kitware/following{/other_user}","gists_url":"https://api.github.com/users/Kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/Kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kitware/subscriptions","organizations_url":"https://api.github.com/users/Kitware/orgs","repos_url":"https://api.github.com/users/Kitware/repos","events_url":"https://api.github.com/users/Kitware/events{/privacy}","received_events_url":"https://api.github.com/users/Kitware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kitware/candela","description":"Visualization components for the web","fork":false,"url":"https://api.github.com/repos/Kitware/candela","forks_url":"https://api.github.com/repos/Kitware/candela/forks","keys_url":"https://api.github.com/repos/Kitware/candela/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kitware/candela/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kitware/candela/teams","hooks_url":"https://api.github.com/repos/Kitware/candela/hooks","issue_events_url":"https://api.github.com/repos/Kitware/candela/issues/events{/number}","events_url":"https://api.github.com/repos/Kitware/candela/events","assignees_url":"https://api.github.com/repos/Kitware/candela/assignees{/user}","branches_url":"https://api.github.com/repos/Kitware/candela/branches{/branch}","tags_url":"https://api.github.com/repos/Kitware/candela/tags","blobs_url":"https://api.github.com/repos/Kitware/candela/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kitware/candela/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kitware/candela/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kitware/candela/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kitware/candela/statuses/{sha}","languages_url":"https://api.github.com/repos/Kitware/candela/languages","stargazers_url":"https://api.github.com/repos/Kitware/candela/stargazers","contributors_url":"https://api.github.com/repos/Kitware/candela/contributors","subscribers_url":"https://api.github.com/repos/Kitware/candela/subscribers","subscription_url":"https://api.github.com/repos/Kitware/candela/subscription","commits_url":"https://api.github.com/repos/Kitware/candela/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kitware/candela/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kitware/candela/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kitware/candela/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kitware/candela/contents/{+path}","compare_url":"https://api.github.com/repos/Kitware/candela/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kitware/candela/merges","archive_url":"https://api.github.com/repos/Kitware/candela/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kitware/candela/downloads","issues_url":"https://api.github.com/repos/Kitware/candela/issues{/number}","pulls_url":"https://api.github.com/repos/Kitware/candela/pulls{/number}","milestones_url":"https://api.github.com/repos/Kitware/candela/milestones{/number}","notifications_url":"https://api.github.com/repos/Kitware/candela/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kitware/candela/labels{/name}","releases_url":"https://api.github.com/repos/Kitware/candela/releases{/id}","deployments_url":"https://api.github.com/repos/Kitware/candela/deployments","created_at":"2016-02-23T20:20:58Z","updated_at":"2016-04-15T02:10:35Z","pushed_at":"2016-05-02T16:28:50Z","git_url":"git://github.com/Kitware/candela.git","ssh_url":"git@github.com:Kitware/candela.git","clone_url":"https://github.com/Kitware/candela.git","svn_url":"https://github.com/Kitware/candela","homepage":null,"size":9576,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":29,"forks":3,"open_issues":29,"watchers":2,"default_branch":"master"}},"base":{"label":"Kitware:master","ref":"master","sha":"dc0a1b2b436e82490148f7e86dbd1d2a1bd85f2f","user":{"login":"Kitware","id":87549,"avatar_url":"https://avatars.githubusercontent.com/u/87549?v=3","gravatar_id":"","url":"https://api.github.com/users/Kitware","html_url":"https://github.com/Kitware","followers_url":"https://api.github.com/users/Kitware/followers","following_url":"https://api.github.com/users/Kitware/following{/other_user}","gists_url":"https://api.github.com/users/Kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/Kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kitware/subscriptions","organizations_url":"https://api.github.com/users/Kitware/orgs","repos_url":"https://api.github.com/users/Kitware/repos","events_url":"https://api.github.com/users/Kitware/events{/privacy}","received_events_url":"https://api.github.com/users/Kitware/received_events","type":"Organization","site_admin":false},"repo":{"id":52388867,"name":"candela","full_name":"Kitware/candela","owner":{"login":"Kitware","id":87549,"avatar_url":"https://avatars.githubusercontent.com/u/87549?v=3","gravatar_id":"","url":"https://api.github.com/users/Kitware","html_url":"https://github.com/Kitware","followers_url":"https://api.github.com/users/Kitware/followers","following_url":"https://api.github.com/users/Kitware/following{/other_user}","gists_url":"https://api.github.com/users/Kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/Kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kitware/subscriptions","organizations_url":"https://api.github.com/users/Kitware/orgs","repos_url":"https://api.github.com/users/Kitware/repos","events_url":"https://api.github.com/users/Kitware/events{/privacy}","received_events_url":"https://api.github.com/users/Kitware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kitware/candela","description":"Visualization components for the web","fork":false,"url":"https://api.github.com/repos/Kitware/candela","forks_url":"https://api.github.com/repos/Kitware/candela/forks","keys_url":"https://api.github.com/repos/Kitware/candela/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kitware/candela/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kitware/candela/teams","hooks_url":"https://api.github.com/repos/Kitware/candela/hooks","issue_events_url":"https://api.github.com/repos/Kitware/candela/issues/events{/number}","events_url":"https://api.github.com/repos/Kitware/candela/events","assignees_url":"https://api.github.com/repos/Kitware/candela/assignees{/user}","branches_url":"https://api.github.com/repos/Kitware/candela/branches{/branch}","tags_url":"https://api.github.com/repos/Kitware/candela/tags","blobs_url":"https://api.github.com/repos/Kitware/candela/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kitware/candela/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kitware/candela/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kitware/candela/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kitware/candela/statuses/{sha}","languages_url":"https://api.github.com/repos/Kitware/candela/languages","stargazers_url":"https://api.github.com/repos/Kitware/candela/stargazers","contributors_url":"https://api.github.com/repos/Kitware/candela/contributors","subscribers_url":"https://api.github.com/repos/Kitware/candela/subscribers","subscription_url":"https://api.github.com/repos/Kitware/candela/subscription","commits_url":"https://api.github.com/repos/Kitware/candela/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kitware/candela/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kitware/candela/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kitware/candela/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kitware/candela/contents/{+path}","compare_url":"https://api.github.com/repos/Kitware/candela/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kitware/candela/merges","archive_url":"https://api.github.com/repos/Kitware/candela/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kitware/candela/downloads","issues_url":"https://api.github.com/repos/Kitware/candela/issues{/number}","pulls_url":"https://api.github.com/repos/Kitware/candela/pulls{/number}","milestones_url":"https://api.github.com/repos/Kitware/candela/milestones{/number}","notifications_url":"https://api.github.com/repos/Kitware/candela/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kitware/candela/labels{/name}","releases_url":"https://api.github.com/repos/Kitware/candela/releases{/id}","deployments_url":"https://api.github.com/repos/Kitware/candela/deployments","created_at":"2016-02-23T20:20:58Z","updated_at":"2016-04-15T02:10:35Z","pushed_at":"2016-05-02T16:28:50Z","git_url":"git://github.com/Kitware/candela.git","ssh_url":"git@github.com:Kitware/candela.git","clone_url":"https://github.com/Kitware/candela.git","svn_url":"https://github.com/Kitware/candela","homepage":null,"size":9576,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":29,"forks":3,"open_issues":29,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kitware/candela/pulls/137"},"html":{"href":"https://github.com/Kitware/candela/pull/137"},"issue":{"href":"https://api.github.com/repos/Kitware/candela/issues/137"},"comments":{"href":"https://api.github.com/repos/Kitware/candela/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/Kitware/candela/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/Kitware/candela/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kitware/candela/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/Kitware/candela/statuses/c04940ebf91d89d1eb620a9ed951a7f76c831df0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ronichoudhury","id":2903332,"avatar_url":"https://avatars.githubusercontent.com/u/2903332?v=3","gravatar_id":"","url":"https://api.github.com/users/ronichoudhury","html_url":"https://github.com/ronichoudhury","followers_url":"https://api.github.com/users/ronichoudhury/followers","following_url":"https://api.github.com/users/ronichoudhury/following{/other_user}","gists_url":"https://api.github.com/users/ronichoudhury/gists{/gist_id}","starred_url":"https://api.github.com/users/ronichoudhury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronichoudhury/subscriptions","organizations_url":"https://api.github.com/users/ronichoudhury/orgs","repos_url":"https://api.github.com/users/ronichoudhury/repos","events_url":"https://api.github.com/users/ronichoudhury/events{/privacy}","received_events_url":"https://api.github.com/users/ronichoudhury/received_events","type":"User","site_admin":false},"comments":6,"review_comments":3,"commits":31,"additions":274,"deletions":235,"changed_files":48}}