{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/64182066","id":64182066,"diff_hunk":"@@ -0,0 +1,65 @@\n+package daemon\n+\n+import (\n+\t\"github.com/docker/docker/opts\"\n+\tflag \"github.com/docker/docker/pkg/mflag\"\n+\t\"net\"\n+)\n+\n+var (\n+\tdefaultPidFile = \"/var/run/docker.pid\"\n+\tdefaultGraph   = \"/var/lib/docker\"\n+\tdefaultExec    = \"zones\"\n+)\n+\n+// Config defines the configuration of a docker daemon.\n+// These are the configuration settings that you pass\n+// to the docker daemon when you launch it with say: `docker -d -e lxc`\n+type Config struct {\n+\tCommonConfig\n+\n+\t// Fields below here are platform specific.\n+\tExecRoot string `json:\"exec-root,omitempty\"`\n+}\n+\n+// bridgeConfig stores all the bridge driver specific\n+// configuration.\n+type bridgeConfig struct {","path":"daemon/config_solaris.go","position":27,"original_position":27,"commit_id":"1613127539456acd4b8ae637b71175852fa6e6d9","original_commit_id":"1613127539456acd4b8ae637b71175852fa6e6d9","user":{"login":"amitkris","id":16695007,"avatar_url":"https://avatars.githubusercontent.com/u/16695007?v=3","gravatar_id":"","url":"https://api.github.com/users/amitkris","html_url":"https://github.com/amitkris","followers_url":"https://api.github.com/users/amitkris/followers","following_url":"https://api.github.com/users/amitkris/following{/other_user}","gists_url":"https://api.github.com/users/amitkris/gists{/gist_id}","starred_url":"https://api.github.com/users/amitkris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitkris/subscriptions","organizations_url":"https://api.github.com/users/amitkris/orgs","repos_url":"https://api.github.com/users/amitkris/repos","events_url":"https://api.github.com/users/amitkris/events{/privacy}","received_events_url":"https://api.github.com/users/amitkris/received_events","type":"User","site_admin":false},"body":"After you pointed this out I realized that some of the elements in bridgeConfig are yet to be evaluated for Solaris. Given this I've stubbed out bridgeConfig to exclude all platform specific elements for now. If bridgeConfig looks the same as now after they're added back I'll definitely create the bridge_config_unix.go file.","created_at":"2016-05-23T08:03:55Z","updated_at":"2016-05-23T08:03:55Z","html_url":"https://github.com/docker/docker/pull/22091#discussion_r64182066","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/22091","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/64182066"},"html":{"href":"https://github.com/docker/docker/pull/22091#discussion_r64182066"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/22091"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/22091","id":66727965,"html_url":"https://github.com/docker/docker/pull/22091","diff_url":"https://github.com/docker/docker/pull/22091.diff","patch_url":"https://github.com/docker/docker/pull/22091.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/22091","number":22091,"state":"open","locked":false,"title":"Get the Docker Engine to build clean on Solaris","user":{"login":"amitkris","id":16695007,"avatar_url":"https://avatars.githubusercontent.com/u/16695007?v=3","gravatar_id":"","url":"https://api.github.com/users/amitkris","html_url":"https://github.com/amitkris","followers_url":"https://api.github.com/users/amitkris/followers","following_url":"https://api.github.com/users/amitkris/following{/other_user}","gists_url":"https://api.github.com/users/amitkris/gists{/gist_id}","starred_url":"https://api.github.com/users/amitkris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitkris/subscriptions","organizations_url":"https://api.github.com/users/amitkris/orgs","repos_url":"https://api.github.com/users/amitkris/repos","events_url":"https://api.github.com/users/amitkris/events{/privacy}","received_events_url":"https://api.github.com/users/amitkris/received_events","type":"User","site_admin":false},"body":"This PR will enable the Docker Engine to build clean on Solaris.\r\nThis is part of the effort towards a native port of Docker on Solaris.\r\n\r\nThis PR has dependencies in various stages of completion (and therefore WIP until they're merged and vendored). \r\nThe code changes that are a part of this PR are stable and open to review.\r\n\r\nTODO:\r\n\r\n- [x] #22080 : This adds support for the pkg/term package specifically on Solaris. It was done separately as it is a dependency for libnetwork and containerd.\r\n\r\n- [x] #22088 : fsnotify is a dependency. Solaris build clean support has been integrated into it and is available in v1.2.11. This PR will uprev fsnotify in the Engine.\r\n\r\n- [x] libnetwork: Revendoring under review #22582 \r\n\r\n- [x] godbus/dbus: Solaris support merged. Awaiting next version to revendor.\r\n\r\n- [x] go-zfs : Merged. Vendoring pending.\r\n\r\n\r\nSigned-off-by: Amit Krishnan <krish.amit@gmail.com>","created_at":"2016-04-16T04:50:56Z","updated_at":"2016-05-23T08:03:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5636292ae48a7c7bca60db640a13b00373d6f12","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/22091/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/22091/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/22091/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/1613127539456acd4b8ae637b71175852fa6e6d9","head":{"label":"amitkris:build_solaris","ref":"build_solaris","sha":"1613127539456acd4b8ae637b71175852fa6e6d9","user":{"login":"amitkris","id":16695007,"avatar_url":"https://avatars.githubusercontent.com/u/16695007?v=3","gravatar_id":"","url":"https://api.github.com/users/amitkris","html_url":"https://github.com/amitkris","followers_url":"https://api.github.com/users/amitkris/followers","following_url":"https://api.github.com/users/amitkris/following{/other_user}","gists_url":"https://api.github.com/users/amitkris/gists{/gist_id}","starred_url":"https://api.github.com/users/amitkris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitkris/subscriptions","organizations_url":"https://api.github.com/users/amitkris/orgs","repos_url":"https://api.github.com/users/amitkris/repos","events_url":"https://api.github.com/users/amitkris/events{/privacy}","received_events_url":"https://api.github.com/users/amitkris/received_events","type":"User","site_admin":false},"repo":{"id":50963345,"name":"docker","full_name":"amitkris/docker","owner":{"login":"amitkris","id":16695007,"avatar_url":"https://avatars.githubusercontent.com/u/16695007?v=3","gravatar_id":"","url":"https://api.github.com/users/amitkris","html_url":"https://github.com/amitkris","followers_url":"https://api.github.com/users/amitkris/followers","following_url":"https://api.github.com/users/amitkris/following{/other_user}","gists_url":"https://api.github.com/users/amitkris/gists{/gist_id}","starred_url":"https://api.github.com/users/amitkris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amitkris/subscriptions","organizations_url":"https://api.github.com/users/amitkris/orgs","repos_url":"https://api.github.com/users/amitkris/repos","events_url":"https://api.github.com/users/amitkris/events{/privacy}","received_events_url":"https://api.github.com/users/amitkris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amitkris/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/amitkris/docker","forks_url":"https://api.github.com/repos/amitkris/docker/forks","keys_url":"https://api.github.com/repos/amitkris/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amitkris/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amitkris/docker/teams","hooks_url":"https://api.github.com/repos/amitkris/docker/hooks","issue_events_url":"https://api.github.com/repos/amitkris/docker/issues/events{/number}","events_url":"https://api.github.com/repos/amitkris/docker/events","assignees_url":"https://api.github.com/repos/amitkris/docker/assignees{/user}","branches_url":"https://api.github.com/repos/amitkris/docker/branches{/branch}","tags_url":"https://api.github.com/repos/amitkris/docker/tags","blobs_url":"https://api.github.com/repos/amitkris/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amitkris/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amitkris/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/amitkris/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amitkris/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/amitkris/docker/languages","stargazers_url":"https://api.github.com/repos/amitkris/docker/stargazers","contributors_url":"https://api.github.com/repos/amitkris/docker/contributors","subscribers_url":"https://api.github.com/repos/amitkris/docker/subscribers","subscription_url":"https://api.github.com/repos/amitkris/docker/subscription","commits_url":"https://api.github.com/repos/amitkris/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/amitkris/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/amitkris/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/amitkris/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/amitkris/docker/contents/{+path}","compare_url":"https://api.github.com/repos/amitkris/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amitkris/docker/merges","archive_url":"https://api.github.com/repos/amitkris/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amitkris/docker/downloads","issues_url":"https://api.github.com/repos/amitkris/docker/issues{/number}","pulls_url":"https://api.github.com/repos/amitkris/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/amitkris/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/amitkris/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amitkris/docker/labels{/name}","releases_url":"https://api.github.com/repos/amitkris/docker/releases{/id}","deployments_url":"https://api.github.com/repos/amitkris/docker/deployments","created_at":"2016-02-03T00:55:32Z","updated_at":"2016-02-03T00:55:43Z","pushed_at":"2016-05-18T17:43:45Z","git_url":"git://github.com/amitkris/docker.git","ssh_url":"git@github.com:amitkris/docker.git","clone_url":"https://github.com/amitkris/docker.git","svn_url":"https://github.com/amitkris/docker","homepage":"http://www.docker.com","size":89574,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"af705ca0ae1af735661ae464cb53d93a890450e7","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-05-23T07:55:06Z","pushed_at":"2016-05-23T08:02:34Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":193625,"stargazers_count":31439,"watchers_count":31439,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8958,"mirror_url":null,"open_issues_count":1621,"forks":8958,"open_issues":1621,"watchers":31439,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/22091"},"html":{"href":"https://github.com/docker/docker/pull/22091"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/22091"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/22091/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/22091/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/22091/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/1613127539456acd4b8ae637b71175852fa6e6d9"}}}}
{"actor":{"display_login":"amitkris"}}