{"action":"created","issue":{"url":"https://api.github.com/repos/BD2KGenomics/toil/issues/1047","repository_url":"https://api.github.com/repos/BD2KGenomics/toil","labels_url":"https://api.github.com/repos/BD2KGenomics/toil/issues/1047/labels{/name}","comments_url":"https://api.github.com/repos/BD2KGenomics/toil/issues/1047/comments","events_url":"https://api.github.com/repos/BD2KGenomics/toil/issues/1047/events","html_url":"https://github.com/BD2KGenomics/toil/pull/1047","id":164276858,"number":1047,"title":"Fix harbinger file deletion race condition (resolves #1046)","user":{"login":"arkal","id":11653944,"avatar_url":"https://avatars.githubusercontent.com/u/11653944?v=3","gravatar_id":"","url":"https://api.github.com/users/arkal","html_url":"https://github.com/arkal","followers_url":"https://api.github.com/users/arkal/followers","following_url":"https://api.github.com/users/arkal/following{/other_user}","gists_url":"https://api.github.com/users/arkal/gists{/gist_id}","starred_url":"https://api.github.com/users/arkal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arkal/subscriptions","organizations_url":"https://api.github.com/users/arkal/orgs","repos_url":"https://api.github.com/users/arkal/repos","events_url":"https://api.github.com/users/arkal/events{/privacy}","received_events_url":"https://api.github.com/users/arkal/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/BD2KGenomics/toil/labels/caching","name":"caching","color":"bfe5bf"},{"url":"https://api.github.com/repos/BD2KGenomics/toil/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/BD2KGenomics/toil/labels/needs%20work","name":"needs work","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-07-07T10:21:19Z","updated_at":"2016-07-08T03:19:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/BD2KGenomics/toil/pulls/1047","html_url":"https://github.com/BD2KGenomics/toil/pull/1047","diff_url":"https://github.com/BD2KGenomics/toil/pull/1047.diff","patch_url":"https://github.com/BD2KGenomics/toil/pull/1047.patch"},"body":"resolves #1046\r\n\r\nHarbinger file deletion now occurs only with the cache lock held."},"comment":{"url":"https://api.github.com/repos/BD2KGenomics/toil/issues/comments/231265990","html_url":"https://github.com/BD2KGenomics/toil/pull/1047#issuecomment-231265990","issue_url":"https://api.github.com/repos/BD2KGenomics/toil/issues/1047","id":231265990,"user":{"login":"hannes-ucsc","id":5143256,"avatar_url":"https://avatars.githubusercontent.com/u/5143256?v=3","gravatar_id":"","url":"https://api.github.com/users/hannes-ucsc","html_url":"https://github.com/hannes-ucsc","followers_url":"https://api.github.com/users/hannes-ucsc/followers","following_url":"https://api.github.com/users/hannes-ucsc/following{/other_user}","gists_url":"https://api.github.com/users/hannes-ucsc/gists{/gist_id}","starred_url":"https://api.github.com/users/hannes-ucsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannes-ucsc/subscriptions","organizations_url":"https://api.github.com/users/hannes-ucsc/orgs","repos_url":"https://api.github.com/users/hannes-ucsc/repos","events_url":"https://api.github.com/users/hannes-ucsc/events{/privacy}","received_events_url":"https://api.github.com/users/hannes-ucsc/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T03:19:10Z","updated_at":"2016-07-08T03:19:10Z","body":"Not true. You added PID checking, which adds complexity and the need for logging that otherwise adds no value.\r\n\r\nIf you never release the lock after determining that the harbinger file needs to be acted upon, none of those races can occur. If a quick-and-dirty fix doesn't guarantee that, and instead requires PID checking—which I doubt, BTW—then we need to implement reentrant locking as a clean solution."}}
{"actor":{"display_login":"hannes-ucsc"}}