{"action":"closed","number":3436,"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/3436","id":82371154,"html_url":"https://github.com/mono/mono/pull/3436","diff_url":"https://github.com/mono/mono/pull/3436.diff","patch_url":"https://github.com/mono/mono/pull/3436.patch","issue_url":"https://api.github.com/repos/mono/mono/issues/3436","number":3436,"state":"closed","locked":false,"title":"Path.CleanPath() does not always replace AltDirectorySeparatorChar","user":{"login":"ntherning","id":135765,"avatar_url":"https://avatars.githubusercontent.com/u/135765?v=3","gravatar_id":"","url":"https://api.github.com/users/ntherning","html_url":"https://github.com/ntherning","followers_url":"https://api.github.com/users/ntherning/followers","following_url":"https://api.github.com/users/ntherning/following{/other_user}","gists_url":"https://api.github.com/users/ntherning/gists{/gist_id}","starred_url":"https://api.github.com/users/ntherning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntherning/subscriptions","organizations_url":"https://api.github.com/users/ntherning/orgs","repos_url":"https://api.github.com/users/ntherning/repos","events_url":"https://api.github.com/users/ntherning/events{/privacy}","received_events_url":"https://api.github.com/users/ntherning/received_events","type":"User","site_admin":false},"body":"If `sub == 0`, i.e. there are no repeated separators, this method just returns the input string. On Windows, where `DirectorySeparatorChar` (\\\\) is different from `AltDirectorySeparatorChar` (/), this means that the call\r\n\r\n```c#\r\n    Path.GetDirectoryName (\"foo/bar/dingus\")\r\n```\r\n\r\nwon't return \"foo\\bar\" as .NET would but rather returns \"foo/bar\".\r\n\r\nThis patch makes sure the '/' -> '\\' conversion is run when `AltDirectorySeparatorChar` characters have been seen in the input string, even if `sub == 0`.\r\n\r\nPathTest.GetDirectoryName() triggered this bug.","created_at":"2016-08-23T14:05:31Z","updated_at":"2016-08-24T11:17:24Z","closed_at":"2016-08-24T11:17:24Z","merged_at":"2016-08-24T11:17:24Z","merge_commit_sha":"11fb0e399f3b9efae2ef1d67090042c5a0c1bf9a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mono/mono/pulls/3436/commits","review_comments_url":"https://api.github.com/repos/mono/mono/pulls/3436/comments","review_comment_url":"https://api.github.com/repos/mono/mono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/mono/issues/3436/comments","statuses_url":"https://api.github.com/repos/mono/mono/statuses/3b1ebefb7b2c5ee32ecdf98ed4d8a3a821e66bc1","head":{"label":"ntherning:fix-alt-dir-separator-not-replaced-in-Path.CleanPath","ref":"fix-alt-dir-separator-not-replaced-in-Path.CleanPath","sha":"3b1ebefb7b2c5ee32ecdf98ed4d8a3a821e66bc1","user":{"login":"ntherning","id":135765,"avatar_url":"https://avatars.githubusercontent.com/u/135765?v=3","gravatar_id":"","url":"https://api.github.com/users/ntherning","html_url":"https://github.com/ntherning","followers_url":"https://api.github.com/users/ntherning/followers","following_url":"https://api.github.com/users/ntherning/following{/other_user}","gists_url":"https://api.github.com/users/ntherning/gists{/gist_id}","starred_url":"https://api.github.com/users/ntherning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntherning/subscriptions","organizations_url":"https://api.github.com/users/ntherning/orgs","repos_url":"https://api.github.com/users/ntherning/repos","events_url":"https://api.github.com/users/ntherning/events{/privacy}","received_events_url":"https://api.github.com/users/ntherning/received_events","type":"User","site_admin":false},"repo":{"id":53493195,"name":"mono","full_name":"ntherning/mono","owner":{"login":"ntherning","id":135765,"avatar_url":"https://avatars.githubusercontent.com/u/135765?v=3","gravatar_id":"","url":"https://api.github.com/users/ntherning","html_url":"https://github.com/ntherning","followers_url":"https://api.github.com/users/ntherning/followers","following_url":"https://api.github.com/users/ntherning/following{/other_user}","gists_url":"https://api.github.com/users/ntherning/gists{/gist_id}","starred_url":"https://api.github.com/users/ntherning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntherning/subscriptions","organizations_url":"https://api.github.com/users/ntherning/orgs","repos_url":"https://api.github.com/users/ntherning/repos","events_url":"https://api.github.com/users/ntherning/events{/privacy}","received_events_url":"https://api.github.com/users/ntherning/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ntherning/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":true,"url":"https://api.github.com/repos/ntherning/mono","forks_url":"https://api.github.com/repos/ntherning/mono/forks","keys_url":"https://api.github.com/repos/ntherning/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ntherning/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ntherning/mono/teams","hooks_url":"https://api.github.com/repos/ntherning/mono/hooks","issue_events_url":"https://api.github.com/repos/ntherning/mono/issues/events{/number}","events_url":"https://api.github.com/repos/ntherning/mono/events","assignees_url":"https://api.github.com/repos/ntherning/mono/assignees{/user}","branches_url":"https://api.github.com/repos/ntherning/mono/branches{/branch}","tags_url":"https://api.github.com/repos/ntherning/mono/tags","blobs_url":"https://api.github.com/repos/ntherning/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ntherning/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ntherning/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/ntherning/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ntherning/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/ntherning/mono/languages","stargazers_url":"https://api.github.com/repos/ntherning/mono/stargazers","contributors_url":"https://api.github.com/repos/ntherning/mono/contributors","subscribers_url":"https://api.github.com/repos/ntherning/mono/subscribers","subscription_url":"https://api.github.com/repos/ntherning/mono/subscription","commits_url":"https://api.github.com/repos/ntherning/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/ntherning/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/ntherning/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/ntherning/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/ntherning/mono/contents/{+path}","compare_url":"https://api.github.com/repos/ntherning/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ntherning/mono/merges","archive_url":"https://api.github.com/repos/ntherning/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ntherning/mono/downloads","issues_url":"https://api.github.com/repos/ntherning/mono/issues{/number}","pulls_url":"https://api.github.com/repos/ntherning/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/ntherning/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/ntherning/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ntherning/mono/labels{/name}","releases_url":"https://api.github.com/repos/ntherning/mono/releases{/id}","deployments_url":"https://api.github.com/repos/ntherning/mono/deployments","created_at":"2016-03-09T11:42:37Z","updated_at":"2016-03-09T11:43:56Z","pushed_at":"2016-08-24T09:23:13Z","git_url":"git://github.com/ntherning/mono.git","ssh_url":"git@github.com:ntherning/mono.git","clone_url":"https://github.com/ntherning/mono.git","svn_url":"https://github.com/ntherning/mono","homepage":"http://www.mono-project.com/","size":411634,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"5adec5a68aa412153e00116e8f3236bd32eb8dff","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791611,"name":"mono","full_name":"mono/mono","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":false,"url":"https://api.github.com/repos/mono/mono","forks_url":"https://api.github.com/repos/mono/mono/forks","keys_url":"https://api.github.com/repos/mono/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono/teams","hooks_url":"https://api.github.com/repos/mono/mono/hooks","issue_events_url":"https://api.github.com/repos/mono/mono/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono/events","assignees_url":"https://api.github.com/repos/mono/mono/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono/tags","blobs_url":"https://api.github.com/repos/mono/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono/languages","stargazers_url":"https://api.github.com/repos/mono/mono/stargazers","contributors_url":"https://api.github.com/repos/mono/mono/contributors","subscribers_url":"https://api.github.com/repos/mono/mono/subscribers","subscription_url":"https://api.github.com/repos/mono/mono/subscription","commits_url":"https://api.github.com/repos/mono/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono/merges","archive_url":"https://api.github.com/repos/mono/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono/downloads","issues_url":"https://api.github.com/repos/mono/mono/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono/releases{/id}","deployments_url":"https://api.github.com/repos/mono/mono/deployments","created_at":"2010-07-22T18:06:36Z","updated_at":"2016-08-24T06:39:11Z","pushed_at":"2016-08-24T11:17:24Z","git_url":"git://github.com/mono/mono.git","ssh_url":"git@github.com:mono/mono.git","clone_url":"https://github.com/mono/mono.git","svn_url":"https://github.com/mono/mono","homepage":"http://www.mono-project.com/","size":498507,"stargazers_count":4829,"watchers_count":4829,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2302,"mirror_url":null,"open_issues_count":129,"forks":2302,"open_issues":129,"watchers":4829,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/3436"},"html":{"href":"https://github.com/mono/mono/pull/3436"},"issue":{"href":"https://api.github.com/repos/mono/mono/issues/3436"},"comments":{"href":"https://api.github.com/repos/mono/mono/issues/3436/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/mono/pulls/3436/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/mono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/mono/pulls/3436/commits"},"statuses":{"href":"https://api.github.com/repos/mono/mono/statuses/3b1ebefb7b2c5ee32ecdf98ed4d8a3a821e66bc1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"marek-safar","id":250852,"avatar_url":"https://avatars.githubusercontent.com/u/250852?v=3","gravatar_id":"","url":"https://api.github.com/users/marek-safar","html_url":"https://github.com/marek-safar","followers_url":"https://api.github.com/users/marek-safar/followers","following_url":"https://api.github.com/users/marek-safar/following{/other_user}","gists_url":"https://api.github.com/users/marek-safar/gists{/gist_id}","starred_url":"https://api.github.com/users/marek-safar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marek-safar/subscriptions","organizations_url":"https://api.github.com/users/marek-safar/orgs","repos_url":"https://api.github.com/users/marek-safar/repos","events_url":"https://api.github.com/users/marek-safar/events{/privacy}","received_events_url":"https://api.github.com/users/marek-safar/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":11,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"marek-safar"}}