{"action":"created","comment":{"url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/pulls/comments/65631329","id":65631329,"diff_hunk":"@@ -72,6 +72,9 @@ def get_client_data(self, *, json_format=True):\n         }\n         return json.dumps(data) if json_format else data\n \n+    # other classes shouldn't know Client class inner implementation\n+    # that's why you should use this method instead of just calling\n+    # client.bought_tickets.append(ticket)","path":"solutions/eager_zebra.py","position":6,"original_position":6,"commit_id":"d98baeaf3cf756ef536f4752f4369799caff7836","original_commit_id":"d98baeaf3cf756ef536f4752f4369799caff7836","user":{"login":"Glenpl","id":10248509,"avatar_url":"https://avatars.githubusercontent.com/u/10248509?v=3","gravatar_id":"","url":"https://api.github.com/users/Glenpl","html_url":"https://github.com/Glenpl","followers_url":"https://api.github.com/users/Glenpl/followers","following_url":"https://api.github.com/users/Glenpl/following{/other_user}","gists_url":"https://api.github.com/users/Glenpl/gists{/gist_id}","starred_url":"https://api.github.com/users/Glenpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Glenpl/subscriptions","organizations_url":"https://api.github.com/users/Glenpl/orgs","repos_url":"https://api.github.com/users/Glenpl/repos","events_url":"https://api.github.com/users/Glenpl/events{/privacy}","received_events_url":"https://api.github.com/users/Glenpl/received_events","type":"User","site_admin":false},"body":"@KaczuH No, it's not a typo - it's one of the nicest python 3 features :) \r\nhttps://www.python.org/dev/peps/pep-3102/\r\n\r\nYou're right - since these classes are so simple and they have just a few member fields to be serialized it's best to keep it as simple (and explicit) as possible - I came to the same conclusion as you did.","created_at":"2016-06-02T22:39:11Z","updated_at":"2016-06-02T22:39:11Z","html_url":"https://github.com/trurl-it/junior_dev_recruitment/pull/24#discussion_r65631329","pull_request_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/pulls/comments/65631329"},"html":{"href":"https://github.com/trurl-it/junior_dev_recruitment/pull/24#discussion_r65631329"},"pull_request":{"href":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/pulls/24","id":72407638,"html_url":"https://github.com/trurl-it/junior_dev_recruitment/pull/24","diff_url":"https://github.com/trurl-it/junior_dev_recruitment/pull/24.diff","patch_url":"https://github.com/trurl-it/junior_dev_recruitment/pull/24.patch","issue_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/issues/24","number":24,"state":"closed","locked":false,"title":"added some comments, reorganized client and ticket tests","user":{"login":"Glenpl","id":10248509,"avatar_url":"https://avatars.githubusercontent.com/u/10248509?v=3","gravatar_id":"","url":"https://api.github.com/users/Glenpl","html_url":"https://github.com/Glenpl","followers_url":"https://api.github.com/users/Glenpl/followers","following_url":"https://api.github.com/users/Glenpl/following{/other_user}","gists_url":"https://api.github.com/users/Glenpl/gists{/gist_id}","starred_url":"https://api.github.com/users/Glenpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Glenpl/subscriptions","organizations_url":"https://api.github.com/users/Glenpl/orgs","repos_url":"https://api.github.com/users/Glenpl/repos","events_url":"https://api.github.com/users/Glenpl/events{/privacy}","received_events_url":"https://api.github.com/users/Glenpl/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-02T19:58:03Z","updated_at":"2016-06-02T22:39:11Z","closed_at":"2016-06-02T20:49:27Z","merged_at":"2016-06-02T20:49:27Z","merge_commit_sha":"e77391f472edb37b263b671fc4a61bca4409cc5a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/pulls/24/commits","review_comments_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/pulls/24/comments","review_comment_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/issues/24/comments","statuses_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/statuses/d98baeaf3cf756ef536f4752f4369799caff7836","head":{"label":"Glenpl:eager_zebra","ref":"eager_zebra","sha":"d98baeaf3cf756ef536f4752f4369799caff7836","user":{"login":"Glenpl","id":10248509,"avatar_url":"https://avatars.githubusercontent.com/u/10248509?v=3","gravatar_id":"","url":"https://api.github.com/users/Glenpl","html_url":"https://github.com/Glenpl","followers_url":"https://api.github.com/users/Glenpl/followers","following_url":"https://api.github.com/users/Glenpl/following{/other_user}","gists_url":"https://api.github.com/users/Glenpl/gists{/gist_id}","starred_url":"https://api.github.com/users/Glenpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Glenpl/subscriptions","organizations_url":"https://api.github.com/users/Glenpl/orgs","repos_url":"https://api.github.com/users/Glenpl/repos","events_url":"https://api.github.com/users/Glenpl/events{/privacy}","received_events_url":"https://api.github.com/users/Glenpl/received_events","type":"User","site_admin":false},"repo":{"id":60103684,"name":"junior_dev_recruitment","full_name":"Glenpl/junior_dev_recruitment","owner":{"login":"Glenpl","id":10248509,"avatar_url":"https://avatars.githubusercontent.com/u/10248509?v=3","gravatar_id":"","url":"https://api.github.com/users/Glenpl","html_url":"https://github.com/Glenpl","followers_url":"https://api.github.com/users/Glenpl/followers","following_url":"https://api.github.com/users/Glenpl/following{/other_user}","gists_url":"https://api.github.com/users/Glenpl/gists{/gist_id}","starred_url":"https://api.github.com/users/Glenpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Glenpl/subscriptions","organizations_url":"https://api.github.com/users/Glenpl/orgs","repos_url":"https://api.github.com/users/Glenpl/repos","events_url":"https://api.github.com/users/Glenpl/events{/privacy}","received_events_url":"https://api.github.com/users/Glenpl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Glenpl/junior_dev_recruitment","description":"Task and description for junior dev recruitment","fork":true,"url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment","forks_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/forks","keys_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/teams","hooks_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/hooks","issue_events_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/issues/events{/number}","events_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/events","assignees_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/assignees{/user}","branches_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/branches{/branch}","tags_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/tags","blobs_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/git/refs{/sha}","trees_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/statuses/{sha}","languages_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/languages","stargazers_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/stargazers","contributors_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/contributors","subscribers_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/subscribers","subscription_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/subscription","commits_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/commits{/sha}","git_commits_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/git/commits{/sha}","comments_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/comments{/number}","issue_comment_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/issues/comments{/number}","contents_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/contents/{+path}","compare_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/merges","archive_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/downloads","issues_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/issues{/number}","pulls_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/pulls{/number}","milestones_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/milestones{/number}","notifications_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/labels{/name}","releases_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/releases{/id}","deployments_url":"https://api.github.com/repos/Glenpl/junior_dev_recruitment/deployments","created_at":"2016-05-31T15:58:34Z","updated_at":"2016-05-31T15:58:35Z","pushed_at":"2016-06-02T19:56:31Z","git_url":"git://github.com/Glenpl/junior_dev_recruitment.git","ssh_url":"git@github.com:Glenpl/junior_dev_recruitment.git","clone_url":"https://github.com/Glenpl/junior_dev_recruitment.git","svn_url":"https://github.com/Glenpl/junior_dev_recruitment","homepage":"","size":103,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"trurl-it:master","ref":"master","sha":"888219df3c1549947b1e418b16de028d303672ad","user":{"login":"trurl-it","id":17888590,"avatar_url":"https://avatars.githubusercontent.com/u/17888590?v=3","gravatar_id":"","url":"https://api.github.com/users/trurl-it","html_url":"https://github.com/trurl-it","followers_url":"https://api.github.com/users/trurl-it/followers","following_url":"https://api.github.com/users/trurl-it/following{/other_user}","gists_url":"https://api.github.com/users/trurl-it/gists{/gist_id}","starred_url":"https://api.github.com/users/trurl-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trurl-it/subscriptions","organizations_url":"https://api.github.com/users/trurl-it/orgs","repos_url":"https://api.github.com/users/trurl-it/repos","events_url":"https://api.github.com/users/trurl-it/events{/privacy}","received_events_url":"https://api.github.com/users/trurl-it/received_events","type":"Organization","site_admin":false},"repo":{"id":59961633,"name":"junior_dev_recruitment","full_name":"trurl-it/junior_dev_recruitment","owner":{"login":"trurl-it","id":17888590,"avatar_url":"https://avatars.githubusercontent.com/u/17888590?v=3","gravatar_id":"","url":"https://api.github.com/users/trurl-it","html_url":"https://github.com/trurl-it","followers_url":"https://api.github.com/users/trurl-it/followers","following_url":"https://api.github.com/users/trurl-it/following{/other_user}","gists_url":"https://api.github.com/users/trurl-it/gists{/gist_id}","starred_url":"https://api.github.com/users/trurl-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trurl-it/subscriptions","organizations_url":"https://api.github.com/users/trurl-it/orgs","repos_url":"https://api.github.com/users/trurl-it/repos","events_url":"https://api.github.com/users/trurl-it/events{/privacy}","received_events_url":"https://api.github.com/users/trurl-it/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trurl-it/junior_dev_recruitment","description":"Task and description for junior dev recruitment","fork":false,"url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment","forks_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/forks","keys_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/teams","hooks_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/hooks","issue_events_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/issues/events{/number}","events_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/events","assignees_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/assignees{/user}","branches_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/branches{/branch}","tags_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/tags","blobs_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/git/refs{/sha}","trees_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/statuses/{sha}","languages_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/languages","stargazers_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/stargazers","contributors_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/contributors","subscribers_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/subscribers","subscription_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/subscription","commits_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/commits{/sha}","git_commits_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/git/commits{/sha}","comments_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/comments{/number}","issue_comment_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/issues/comments{/number}","contents_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/contents/{+path}","compare_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/merges","archive_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/downloads","issues_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/issues{/number}","pulls_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/pulls{/number}","milestones_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/milestones{/number}","notifications_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/labels{/name}","releases_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/releases{/id}","deployments_url":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/deployments","created_at":"2016-05-29T20:07:17Z","updated_at":"2016-05-29T20:55:43Z","pushed_at":"2016-06-02T22:37:45Z","git_url":"git://github.com/trurl-it/junior_dev_recruitment.git","ssh_url":"git@github.com:trurl-it/junior_dev_recruitment.git","clone_url":"https://github.com/trurl-it/junior_dev_recruitment.git","svn_url":"https://github.com/trurl-it/junior_dev_recruitment","homepage":"","size":137,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":1,"forks":23,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/pulls/24"},"html":{"href":"https://github.com/trurl-it/junior_dev_recruitment/pull/24"},"issue":{"href":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/issues/24"},"comments":{"href":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/trurl-it/junior_dev_recruitment/statuses/d98baeaf3cf756ef536f4752f4369799caff7836"}}}}
{"actor":{"display_login":"Glenpl"}}