{"action":"created","comment":{"url":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/comments/61087553","id":61087553,"diff_hunk":"@@ -895,6 +905,25 @@ PointDataLeafNode<T, Log2Dim>::memUsage() const\n     return BaseLeaf::memUsage() + mAttributeSet->memUsage();\n }\n \n+\n+////////////////////////////////////////\n+\n+\n+template <typename PointDataTreeT>\n+inline void\n+makeDescriptorUnique(PointDataTreeT& tree)\n+{\n+    typename PointDataTreeT::LeafIter leafIter = tree.beginLeaf();\n+    if (!leafIter)  return;\n+\n+    const AttributeSet::Descriptor& descriptor = leafIter->attributeSet().descriptor();\n+    AttributeSet::Descriptor::Ptr newDescriptor(new AttributeSet::Descriptor(descriptor));\n+    for (; leafIter; ++leafIter) {\n+        leafIter->renameAttributes(descriptor, newDescriptor);","path":"openvdb_points/tools/PointDataGrid.h","position":35,"original_position":35,"commit_id":"116663ea00c45c70b1b30c9402bd7fda209f3efd","original_commit_id":"116663ea00c45c70b1b30c9402bd7fda209f3efd","user":{"login":"Idclip","id":4256455,"avatar_url":"https://avatars.githubusercontent.com/u/4256455?v=3","gravatar_id":"","url":"https://api.github.com/users/Idclip","html_url":"https://github.com/Idclip","followers_url":"https://api.github.com/users/Idclip/followers","following_url":"https://api.github.com/users/Idclip/following{/other_user}","gists_url":"https://api.github.com/users/Idclip/gists{/gist_id}","starred_url":"https://api.github.com/users/Idclip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Idclip/subscriptions","organizations_url":"https://api.github.com/users/Idclip/orgs","repos_url":"https://api.github.com/users/Idclip/repos","events_url":"https://api.github.com/users/Idclip/events{/privacy}","received_events_url":"https://api.github.com/users/Idclip/received_events","type":"User","site_admin":false},"body":"Hmm looking at what renameAttributes is doing (replacing the descriptor), maybe the function call should be a bit more accurate on the PointDataGrid/AttributeSet? The free function in PointAttribute.h renameAttribute/s() makes sense, but maybe these can call through to something along the lines of \"replaceDescriptor()\", as the descriptor holds a lot more information that just attribute names.","created_at":"2016-04-26T13:47:03Z","updated_at":"2016-04-26T13:47:03Z","html_url":"https://github.com/dneg/openvdb_points_dev/pull/31#discussion_r61087553","pull_request_url":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/comments/61087553"},"html":{"href":"https://github.com/dneg/openvdb_points_dev/pull/31#discussion_r61087553"},"pull_request":{"href":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/31","id":67559994,"html_url":"https://github.com/dneg/openvdb_points_dev/pull/31","diff_url":"https://github.com/dneg/openvdb_points_dev/pull/31.diff","patch_url":"https://github.com/dneg/openvdb_points_dev/pull/31.patch","issue_url":"https://api.github.com/repos/dneg/openvdb_points_dev/issues/31","number":31,"state":"open","locked":false,"title":"Descriptor Fixes","user":{"login":"danrbailey","id":5251654,"avatar_url":"https://avatars.githubusercontent.com/u/5251654?v=3","gravatar_id":"","url":"https://api.github.com/users/danrbailey","html_url":"https://github.com/danrbailey","followers_url":"https://api.github.com/users/danrbailey/followers","following_url":"https://api.github.com/users/danrbailey/following{/other_user}","gists_url":"https://api.github.com/users/danrbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/danrbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrbailey/subscriptions","organizations_url":"https://api.github.com/users/danrbailey/orgs","repos_url":"https://api.github.com/users/danrbailey/repos","events_url":"https://api.github.com/users/danrbailey/events{/privacy}","received_events_url":"https://api.github.com/users/danrbailey/received_events","type":"User","site_admin":false},"body":"* Add in some missing group map comparisons to the Descriptor comparison methods.\r\n* Make sure that group names can only contain alpha-numeric or underscore characters\r\n* Add a makeDescriptorUnique(tree) method that makes sure a PointDataTree's Descriptor is not shared with another PointDataTree\r\n* Fix an issue where operations that only modify the group map use makeDescriptorUnique() to deep-copy it first","created_at":"2016-04-22T19:20:49Z","updated_at":"2016-04-26T13:47:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a79e8b0fc4330ffc78e7a2a1f4d764bdb7fd69de","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/31/commits","review_comments_url":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/31/comments","review_comment_url":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dneg/openvdb_points_dev/issues/31/comments","statuses_url":"https://api.github.com/repos/dneg/openvdb_points_dev/statuses/116663ea00c45c70b1b30c9402bd7fda209f3efd","head":{"label":"dneg:descriptorfixes","ref":"descriptorfixes","sha":"116663ea00c45c70b1b30c9402bd7fda209f3efd","user":{"login":"dneg","id":5524887,"avatar_url":"https://avatars.githubusercontent.com/u/5524887?v=3","gravatar_id":"","url":"https://api.github.com/users/dneg","html_url":"https://github.com/dneg","followers_url":"https://api.github.com/users/dneg/followers","following_url":"https://api.github.com/users/dneg/following{/other_user}","gists_url":"https://api.github.com/users/dneg/gists{/gist_id}","starred_url":"https://api.github.com/users/dneg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneg/subscriptions","organizations_url":"https://api.github.com/users/dneg/orgs","repos_url":"https://api.github.com/users/dneg/repos","events_url":"https://api.github.com/users/dneg/events{/privacy}","received_events_url":"https://api.github.com/users/dneg/received_events","type":"Organization","site_admin":false},"repo":{"id":35619792,"name":"openvdb_points_dev","full_name":"dneg/openvdb_points_dev","owner":{"login":"dneg","id":5524887,"avatar_url":"https://avatars.githubusercontent.com/u/5524887?v=3","gravatar_id":"","url":"https://api.github.com/users/dneg","html_url":"https://github.com/dneg","followers_url":"https://api.github.com/users/dneg/followers","following_url":"https://api.github.com/users/dneg/following{/other_user}","gists_url":"https://api.github.com/users/dneg/gists{/gist_id}","starred_url":"https://api.github.com/users/dneg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneg/subscriptions","organizations_url":"https://api.github.com/users/dneg/orgs","repos_url":"https://api.github.com/users/dneg/repos","events_url":"https://api.github.com/users/dneg/events{/privacy}","received_events_url":"https://api.github.com/users/dneg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dneg/openvdb_points_dev","description":"OpenVDB Points Development Repository","fork":false,"url":"https://api.github.com/repos/dneg/openvdb_points_dev","forks_url":"https://api.github.com/repos/dneg/openvdb_points_dev/forks","keys_url":"https://api.github.com/repos/dneg/openvdb_points_dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dneg/openvdb_points_dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dneg/openvdb_points_dev/teams","hooks_url":"https://api.github.com/repos/dneg/openvdb_points_dev/hooks","issue_events_url":"https://api.github.com/repos/dneg/openvdb_points_dev/issues/events{/number}","events_url":"https://api.github.com/repos/dneg/openvdb_points_dev/events","assignees_url":"https://api.github.com/repos/dneg/openvdb_points_dev/assignees{/user}","branches_url":"https://api.github.com/repos/dneg/openvdb_points_dev/branches{/branch}","tags_url":"https://api.github.com/repos/dneg/openvdb_points_dev/tags","blobs_url":"https://api.github.com/repos/dneg/openvdb_points_dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dneg/openvdb_points_dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dneg/openvdb_points_dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/dneg/openvdb_points_dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dneg/openvdb_points_dev/statuses/{sha}","languages_url":"https://api.github.com/repos/dneg/openvdb_points_dev/languages","stargazers_url":"https://api.github.com/repos/dneg/openvdb_points_dev/stargazers","contributors_url":"https://api.github.com/repos/dneg/openvdb_points_dev/contributors","subscribers_url":"https://api.github.com/repos/dneg/openvdb_points_dev/subscribers","subscription_url":"https://api.github.com/repos/dneg/openvdb_points_dev/subscription","commits_url":"https://api.github.com/repos/dneg/openvdb_points_dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/dneg/openvdb_points_dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/dneg/openvdb_points_dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/dneg/openvdb_points_dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/dneg/openvdb_points_dev/contents/{+path}","compare_url":"https://api.github.com/repos/dneg/openvdb_points_dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dneg/openvdb_points_dev/merges","archive_url":"https://api.github.com/repos/dneg/openvdb_points_dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dneg/openvdb_points_dev/downloads","issues_url":"https://api.github.com/repos/dneg/openvdb_points_dev/issues{/number}","pulls_url":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls{/number}","milestones_url":"https://api.github.com/repos/dneg/openvdb_points_dev/milestones{/number}","notifications_url":"https://api.github.com/repos/dneg/openvdb_points_dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dneg/openvdb_points_dev/labels{/name}","releases_url":"https://api.github.com/repos/dneg/openvdb_points_dev/releases{/id}","deployments_url":"https://api.github.com/repos/dneg/openvdb_points_dev/deployments","created_at":"2015-05-14T15:38:43Z","updated_at":"2016-04-14T10:01:17Z","pushed_at":"2016-04-25T07:43:46Z","git_url":"git://github.com/dneg/openvdb_points_dev.git","ssh_url":"git@github.com:dneg/openvdb_points_dev.git","clone_url":"https://github.com/dneg/openvdb_points_dev.git","svn_url":"https://github.com/dneg/openvdb_points_dev","homepage":"","size":1519,"stargazers_count":23,"watchers_count":23,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":3,"forks":11,"open_issues":3,"watchers":23,"default_branch":"master"}},"base":{"label":"dneg:master","ref":"master","sha":"727e08e31c18ca25ea36c4c71e1c12e7c85b6a31","user":{"login":"dneg","id":5524887,"avatar_url":"https://avatars.githubusercontent.com/u/5524887?v=3","gravatar_id":"","url":"https://api.github.com/users/dneg","html_url":"https://github.com/dneg","followers_url":"https://api.github.com/users/dneg/followers","following_url":"https://api.github.com/users/dneg/following{/other_user}","gists_url":"https://api.github.com/users/dneg/gists{/gist_id}","starred_url":"https://api.github.com/users/dneg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneg/subscriptions","organizations_url":"https://api.github.com/users/dneg/orgs","repos_url":"https://api.github.com/users/dneg/repos","events_url":"https://api.github.com/users/dneg/events{/privacy}","received_events_url":"https://api.github.com/users/dneg/received_events","type":"Organization","site_admin":false},"repo":{"id":35619792,"name":"openvdb_points_dev","full_name":"dneg/openvdb_points_dev","owner":{"login":"dneg","id":5524887,"avatar_url":"https://avatars.githubusercontent.com/u/5524887?v=3","gravatar_id":"","url":"https://api.github.com/users/dneg","html_url":"https://github.com/dneg","followers_url":"https://api.github.com/users/dneg/followers","following_url":"https://api.github.com/users/dneg/following{/other_user}","gists_url":"https://api.github.com/users/dneg/gists{/gist_id}","starred_url":"https://api.github.com/users/dneg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneg/subscriptions","organizations_url":"https://api.github.com/users/dneg/orgs","repos_url":"https://api.github.com/users/dneg/repos","events_url":"https://api.github.com/users/dneg/events{/privacy}","received_events_url":"https://api.github.com/users/dneg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dneg/openvdb_points_dev","description":"OpenVDB Points Development Repository","fork":false,"url":"https://api.github.com/repos/dneg/openvdb_points_dev","forks_url":"https://api.github.com/repos/dneg/openvdb_points_dev/forks","keys_url":"https://api.github.com/repos/dneg/openvdb_points_dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dneg/openvdb_points_dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dneg/openvdb_points_dev/teams","hooks_url":"https://api.github.com/repos/dneg/openvdb_points_dev/hooks","issue_events_url":"https://api.github.com/repos/dneg/openvdb_points_dev/issues/events{/number}","events_url":"https://api.github.com/repos/dneg/openvdb_points_dev/events","assignees_url":"https://api.github.com/repos/dneg/openvdb_points_dev/assignees{/user}","branches_url":"https://api.github.com/repos/dneg/openvdb_points_dev/branches{/branch}","tags_url":"https://api.github.com/repos/dneg/openvdb_points_dev/tags","blobs_url":"https://api.github.com/repos/dneg/openvdb_points_dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dneg/openvdb_points_dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dneg/openvdb_points_dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/dneg/openvdb_points_dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dneg/openvdb_points_dev/statuses/{sha}","languages_url":"https://api.github.com/repos/dneg/openvdb_points_dev/languages","stargazers_url":"https://api.github.com/repos/dneg/openvdb_points_dev/stargazers","contributors_url":"https://api.github.com/repos/dneg/openvdb_points_dev/contributors","subscribers_url":"https://api.github.com/repos/dneg/openvdb_points_dev/subscribers","subscription_url":"https://api.github.com/repos/dneg/openvdb_points_dev/subscription","commits_url":"https://api.github.com/repos/dneg/openvdb_points_dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/dneg/openvdb_points_dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/dneg/openvdb_points_dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/dneg/openvdb_points_dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/dneg/openvdb_points_dev/contents/{+path}","compare_url":"https://api.github.com/repos/dneg/openvdb_points_dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dneg/openvdb_points_dev/merges","archive_url":"https://api.github.com/repos/dneg/openvdb_points_dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dneg/openvdb_points_dev/downloads","issues_url":"https://api.github.com/repos/dneg/openvdb_points_dev/issues{/number}","pulls_url":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls{/number}","milestones_url":"https://api.github.com/repos/dneg/openvdb_points_dev/milestones{/number}","notifications_url":"https://api.github.com/repos/dneg/openvdb_points_dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dneg/openvdb_points_dev/labels{/name}","releases_url":"https://api.github.com/repos/dneg/openvdb_points_dev/releases{/id}","deployments_url":"https://api.github.com/repos/dneg/openvdb_points_dev/deployments","created_at":"2015-05-14T15:38:43Z","updated_at":"2016-04-14T10:01:17Z","pushed_at":"2016-04-25T07:43:46Z","git_url":"git://github.com/dneg/openvdb_points_dev.git","ssh_url":"git@github.com:dneg/openvdb_points_dev.git","clone_url":"https://github.com/dneg/openvdb_points_dev.git","svn_url":"https://github.com/dneg/openvdb_points_dev","homepage":"","size":1519,"stargazers_count":23,"watchers_count":23,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":3,"forks":11,"open_issues":3,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/31"},"html":{"href":"https://github.com/dneg/openvdb_points_dev/pull/31"},"issue":{"href":"https://api.github.com/repos/dneg/openvdb_points_dev/issues/31"},"comments":{"href":"https://api.github.com/repos/dneg/openvdb_points_dev/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dneg/openvdb_points_dev/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/dneg/openvdb_points_dev/statuses/116663ea00c45c70b1b30c9402bd7fda209f3efd"}}}}