{"action":"closed","number":1986,"pull_request":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1986","id":97618704,"html_url":"https://github.com/cBioPortal/cbioportal/pull/1986","diff_url":"https://github.com/cBioPortal/cbioportal/pull/1986.diff","patch_url":"https://github.com/cBioPortal/cbioportal/pull/1986.patch","issue_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1986","number":1986,"state":"closed","locked":false,"title":"Fix hotspot annotation bug","user":{"login":"adamabeshouse","id":636232,"avatar_url":"https://avatars.githubusercontent.com/u/636232?v=3","gravatar_id":"","url":"https://api.github.com/users/adamabeshouse","html_url":"https://github.com/adamabeshouse","followers_url":"https://api.github.com/users/adamabeshouse/followers","following_url":"https://api.github.com/users/adamabeshouse/following{/other_user}","gists_url":"https://api.github.com/users/adamabeshouse/gists{/gist_id}","starred_url":"https://api.github.com/users/adamabeshouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamabeshouse/subscriptions","organizations_url":"https://api.github.com/users/adamabeshouse/orgs","repos_url":"https://api.github.com/users/adamabeshouse/repos","events_url":"https://api.github.com/users/adamabeshouse/events{/privacy}","received_events_url":"https://api.github.com/users/adamabeshouse/received_events","type":"User","site_admin":false},"body":"# What? Why?\r\nFixes https://github.com/cBioPortal/cbioportal/issues/1984\r\n\r\nJavascript array sort apparently does a string comparison by default, even when sorting numbers, so an explicit numerical comparator has been added. This fixes the issue where some hotspot mutations were not being annotated as such.\r\n\r\n# Checks\r\n- [x] Runs on Heroku.\r\n- [x] Follows [7 rules of great commit messages](http://chris.beams.io/posts/git-commit/). For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid [merge commits, use rebase instead.](http://nathanleclaire.com/blog/2014/09/14/dont-be-scared-of-git-rebase/)\r\n- [x] Follows the [Google Style Guide](https://github.com/google/styleguide).\r\n- [x] Make sure your commit messages end with a Signed-off-by string (this line\r\n  can be automatically added by git if you run the `git-commit` command with\r\n  the `-s` option)\r\n- [x] If this is a feature, the PR is to rc. If this is a bug fix, the PR is to\r\n  hotfix.\r\n\r\n# Any screenshots or GIFs?\r\n![image](https://cloud.githubusercontent.com/assets/636232/21113681/838c1df2-c078-11e6-8223-5506a92889cf.png)\r\n\r\n\r\n# Notify reviewers\r\n@cBioPortal/frontend \r\n@schultzn ","created_at":"2016-12-12T19:39:01Z","updated_at":"2016-12-13T20:04:30Z","closed_at":"2016-12-13T20:04:30Z","merged_at":"2016-12-13T20:04:30Z","merge_commit_sha":"af147d32380339b8cc7dc09f6e9ee311ffabb128","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/milestones/25","html_url":"https://github.com/cBioPortal/cbioportal/milestone/25","labels_url":"https://api.github.com/repos/cBioPortal/cbioportal/milestones/25/labels","id":2144212,"number":25,"title":"1.3.3","description":"","creator":{"login":"jjgao","id":840895,"avatar_url":"https://avatars.githubusercontent.com/u/840895?v=3","gravatar_id":"","url":"https://api.github.com/users/jjgao","html_url":"https://github.com/jjgao","followers_url":"https://api.github.com/users/jjgao/followers","following_url":"https://api.github.com/users/jjgao/following{/other_user}","gists_url":"https://api.github.com/users/jjgao/gists{/gist_id}","starred_url":"https://api.github.com/users/jjgao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjgao/subscriptions","organizations_url":"https://api.github.com/users/jjgao/orgs","repos_url":"https://api.github.com/users/jjgao/repos","events_url":"https://api.github.com/users/jjgao/events{/privacy}","received_events_url":"https://api.github.com/users/jjgao/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":17,"state":"open","created_at":"2016-11-18T14:11:45Z","updated_at":"2016-12-13T20:04:30Z","due_on":"2016-11-30T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1986/commits","review_comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1986/comments","review_comment_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1986/comments","statuses_url":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/2a873575f735ba2a5ba1d71f3bd124ffda6efc5d","head":{"label":"adamabeshouse:hotfix-fix-hotspots-not-showing","ref":"hotfix-fix-hotspots-not-showing","sha":"2a873575f735ba2a5ba1d71f3bd124ffda6efc5d","user":{"login":"adamabeshouse","id":636232,"avatar_url":"https://avatars.githubusercontent.com/u/636232?v=3","gravatar_id":"","url":"https://api.github.com/users/adamabeshouse","html_url":"https://github.com/adamabeshouse","followers_url":"https://api.github.com/users/adamabeshouse/followers","following_url":"https://api.github.com/users/adamabeshouse/following{/other_user}","gists_url":"https://api.github.com/users/adamabeshouse/gists{/gist_id}","starred_url":"https://api.github.com/users/adamabeshouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamabeshouse/subscriptions","organizations_url":"https://api.github.com/users/adamabeshouse/orgs","repos_url":"https://api.github.com/users/adamabeshouse/repos","events_url":"https://api.github.com/users/adamabeshouse/events{/privacy}","received_events_url":"https://api.github.com/users/adamabeshouse/received_events","type":"User","site_admin":false},"repo":{"id":36766094,"name":"cbioportal","full_name":"adamabeshouse/cbioportal","owner":{"login":"adamabeshouse","id":636232,"avatar_url":"https://avatars.githubusercontent.com/u/636232?v=3","gravatar_id":"","url":"https://api.github.com/users/adamabeshouse","html_url":"https://github.com/adamabeshouse","followers_url":"https://api.github.com/users/adamabeshouse/followers","following_url":"https://api.github.com/users/adamabeshouse/following{/other_user}","gists_url":"https://api.github.com/users/adamabeshouse/gists{/gist_id}","starred_url":"https://api.github.com/users/adamabeshouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamabeshouse/subscriptions","organizations_url":"https://api.github.com/users/adamabeshouse/orgs","repos_url":"https://api.github.com/users/adamabeshouse/repos","events_url":"https://api.github.com/users/adamabeshouse/events{/privacy}","received_events_url":"https://api.github.com/users/adamabeshouse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adamabeshouse/cbioportal","description":null,"fork":true,"url":"https://api.github.com/repos/adamabeshouse/cbioportal","forks_url":"https://api.github.com/repos/adamabeshouse/cbioportal/forks","keys_url":"https://api.github.com/repos/adamabeshouse/cbioportal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamabeshouse/cbioportal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamabeshouse/cbioportal/teams","hooks_url":"https://api.github.com/repos/adamabeshouse/cbioportal/hooks","issue_events_url":"https://api.github.com/repos/adamabeshouse/cbioportal/issues/events{/number}","events_url":"https://api.github.com/repos/adamabeshouse/cbioportal/events","assignees_url":"https://api.github.com/repos/adamabeshouse/cbioportal/assignees{/user}","branches_url":"https://api.github.com/repos/adamabeshouse/cbioportal/branches{/branch}","tags_url":"https://api.github.com/repos/adamabeshouse/cbioportal/tags","blobs_url":"https://api.github.com/repos/adamabeshouse/cbioportal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamabeshouse/cbioportal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamabeshouse/cbioportal/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamabeshouse/cbioportal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamabeshouse/cbioportal/statuses/{sha}","languages_url":"https://api.github.com/repos/adamabeshouse/cbioportal/languages","stargazers_url":"https://api.github.com/repos/adamabeshouse/cbioportal/stargazers","contributors_url":"https://api.github.com/repos/adamabeshouse/cbioportal/contributors","subscribers_url":"https://api.github.com/repos/adamabeshouse/cbioportal/subscribers","subscription_url":"https://api.github.com/repos/adamabeshouse/cbioportal/subscription","commits_url":"https://api.github.com/repos/adamabeshouse/cbioportal/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamabeshouse/cbioportal/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamabeshouse/cbioportal/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamabeshouse/cbioportal/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamabeshouse/cbioportal/contents/{+path}","compare_url":"https://api.github.com/repos/adamabeshouse/cbioportal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamabeshouse/cbioportal/merges","archive_url":"https://api.github.com/repos/adamabeshouse/cbioportal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamabeshouse/cbioportal/downloads","issues_url":"https://api.github.com/repos/adamabeshouse/cbioportal/issues{/number}","pulls_url":"https://api.github.com/repos/adamabeshouse/cbioportal/pulls{/number}","milestones_url":"https://api.github.com/repos/adamabeshouse/cbioportal/milestones{/number}","notifications_url":"https://api.github.com/repos/adamabeshouse/cbioportal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamabeshouse/cbioportal/labels{/name}","releases_url":"https://api.github.com/repos/adamabeshouse/cbioportal/releases{/id}","deployments_url":"https://api.github.com/repos/adamabeshouse/cbioportal/deployments","created_at":"2015-06-02T22:42:43Z","updated_at":"2016-02-23T02:11:05Z","pushed_at":"2016-12-12T19:34:18Z","git_url":"git://github.com/adamabeshouse/cbioportal.git","ssh_url":"git@github.com:adamabeshouse/cbioportal.git","clone_url":"https://github.com/adamabeshouse/cbioportal.git","svn_url":"https://github.com/adamabeshouse/cbioportal","homepage":null,"size":205821,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cBioPortal:hotfix","ref":"hotfix","sha":"e4a44addbf160c5527f4b047bb1ee9f8a49115b7","user":{"login":"cBioPortal","id":9876251,"avatar_url":"https://avatars.githubusercontent.com/u/9876251?v=3","gravatar_id":"","url":"https://api.github.com/users/cBioPortal","html_url":"https://github.com/cBioPortal","followers_url":"https://api.github.com/users/cBioPortal/followers","following_url":"https://api.github.com/users/cBioPortal/following{/other_user}","gists_url":"https://api.github.com/users/cBioPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/cBioPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cBioPortal/subscriptions","organizations_url":"https://api.github.com/users/cBioPortal/orgs","repos_url":"https://api.github.com/users/cBioPortal/repos","events_url":"https://api.github.com/users/cBioPortal/events{/privacy}","received_events_url":"https://api.github.com/users/cBioPortal/received_events","type":"Organization","site_admin":false},"repo":{"id":32481543,"name":"cbioportal","full_name":"cBioPortal/cbioportal","owner":{"login":"cBioPortal","id":9876251,"avatar_url":"https://avatars.githubusercontent.com/u/9876251?v=3","gravatar_id":"","url":"https://api.github.com/users/cBioPortal","html_url":"https://github.com/cBioPortal","followers_url":"https://api.github.com/users/cBioPortal/followers","following_url":"https://api.github.com/users/cBioPortal/following{/other_user}","gists_url":"https://api.github.com/users/cBioPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/cBioPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cBioPortal/subscriptions","organizations_url":"https://api.github.com/users/cBioPortal/orgs","repos_url":"https://api.github.com/users/cBioPortal/repos","events_url":"https://api.github.com/users/cBioPortal/events{/privacy}","received_events_url":"https://api.github.com/users/cBioPortal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cBioPortal/cbioportal","description":"cBioPortal for Cancer Genomics","fork":false,"url":"https://api.github.com/repos/cBioPortal/cbioportal","forks_url":"https://api.github.com/repos/cBioPortal/cbioportal/forks","keys_url":"https://api.github.com/repos/cBioPortal/cbioportal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cBioPortal/cbioportal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cBioPortal/cbioportal/teams","hooks_url":"https://api.github.com/repos/cBioPortal/cbioportal/hooks","issue_events_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/events{/number}","events_url":"https://api.github.com/repos/cBioPortal/cbioportal/events","assignees_url":"https://api.github.com/repos/cBioPortal/cbioportal/assignees{/user}","branches_url":"https://api.github.com/repos/cBioPortal/cbioportal/branches{/branch}","tags_url":"https://api.github.com/repos/cBioPortal/cbioportal/tags","blobs_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/refs{/sha}","trees_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/{sha}","languages_url":"https://api.github.com/repos/cBioPortal/cbioportal/languages","stargazers_url":"https://api.github.com/repos/cBioPortal/cbioportal/stargazers","contributors_url":"https://api.github.com/repos/cBioPortal/cbioportal/contributors","subscribers_url":"https://api.github.com/repos/cBioPortal/cbioportal/subscribers","subscription_url":"https://api.github.com/repos/cBioPortal/cbioportal/subscription","commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/commits{/sha}","git_commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/commits{/sha}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/comments{/number}","issue_comment_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/comments{/number}","contents_url":"https://api.github.com/repos/cBioPortal/cbioportal/contents/{+path}","compare_url":"https://api.github.com/repos/cBioPortal/cbioportal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cBioPortal/cbioportal/merges","archive_url":"https://api.github.com/repos/cBioPortal/cbioportal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cBioPortal/cbioportal/downloads","issues_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues{/number}","pulls_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls{/number}","milestones_url":"https://api.github.com/repos/cBioPortal/cbioportal/milestones{/number}","notifications_url":"https://api.github.com/repos/cBioPortal/cbioportal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cBioPortal/cbioportal/labels{/name}","releases_url":"https://api.github.com/repos/cBioPortal/cbioportal/releases{/id}","deployments_url":"https://api.github.com/repos/cBioPortal/cbioportal/deployments","created_at":"2015-03-18T20:09:09Z","updated_at":"2016-11-28T20:25:37Z","pushed_at":"2016-12-13T20:04:30Z","git_url":"git://github.com/cBioPortal/cbioportal.git","ssh_url":"git@github.com:cBioPortal/cbioportal.git","clone_url":"https://github.com/cBioPortal/cbioportal.git","svn_url":"https://github.com/cBioPortal/cbioportal","homepage":"http://cbioportal.org","size":273483,"stargazers_count":80,"watchers_count":80,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":115,"mirror_url":null,"open_issues_count":356,"forks":115,"open_issues":356,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1986"},"html":{"href":"https://github.com/cBioPortal/cbioportal/pull/1986"},"issue":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1986"},"comments":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1986/comments"},"review_comments":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1986/comments"},"review_comment":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1986/commits"},"statuses":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/2a873575f735ba2a5ba1d71f3bd124ffda6efc5d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jjgao","id":840895,"avatar_url":"https://avatars.githubusercontent.com/u/840895?v=3","gravatar_id":"","url":"https://api.github.com/users/jjgao","html_url":"https://github.com/jjgao","followers_url":"https://api.github.com/users/jjgao/followers","following_url":"https://api.github.com/users/jjgao/following{/other_user}","gists_url":"https://api.github.com/users/jjgao/gists{/gist_id}","starred_url":"https://api.github.com/users/jjgao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjgao/subscriptions","organizations_url":"https://api.github.com/users/jjgao/orgs","repos_url":"https://api.github.com/users/jjgao/repos","events_url":"https://api.github.com/users/jjgao/events{/privacy}","received_events_url":"https://api.github.com/users/jjgao/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":11,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"jjgao"}}