{"action":"closed","number":128,"pull_request":{"url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/pulls/128","id":92629021,"html_url":"https://github.com/pburtchaell/redux-promise-middleware/pull/128","diff_url":"https://github.com/pburtchaell/redux-promise-middleware/pull/128.diff","patch_url":"https://github.com/pburtchaell/redux-promise-middleware/pull/128.patch","issue_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/issues/128","number":128,"state":"closed","locked":false,"title":"Fix handling of falsy data and meta","user":{"login":"joshkel","id":476338,"avatar_url":"https://avatars.githubusercontent.com/u/476338?v=3","gravatar_id":"","url":"https://api.github.com/users/joshkel","html_url":"https://github.com/joshkel","followers_url":"https://api.github.com/users/joshkel/followers","following_url":"https://api.github.com/users/joshkel/following{/other_user}","gists_url":"https://api.github.com/users/joshkel/gists{/gist_id}","starred_url":"https://api.github.com/users/joshkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshkel/subscriptions","organizations_url":"https://api.github.com/users/joshkel/orgs","repos_url":"https://api.github.com/users/joshkel/repos","events_url":"https://api.github.com/users/joshkel/events{/privacy}","received_events_url":"https://api.github.com/users/joshkel/received_events","type":"User","site_admin":false},"body":"Falsy data (e.g., `data: 0`) and falsy meta properties aren't preserved by the middleware, even though FSA allows payload and meta to be anything, due to the use of `!!data` and `!!meta`.  This commit fixes this by changing the handling to a more restrictive `!== undefined`.","created_at":"2016-11-07T17:37:42Z","updated_at":"2016-11-29T16:27:12Z","closed_at":"2016-11-29T16:27:12Z","merged_at":"2016-11-29T16:27:12Z","merge_commit_sha":"555d83bf11d9afc5891079e164992870b6aae529","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/pulls/128/commits","review_comments_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/pulls/128/comments","review_comment_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/issues/128/comments","statuses_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/statuses/8dd67dfc260e0542752acf231fd2c4d221d503e7","head":{"label":"joshkel:falsy-data","ref":"falsy-data","sha":"8dd67dfc260e0542752acf231fd2c4d221d503e7","user":{"login":"joshkel","id":476338,"avatar_url":"https://avatars.githubusercontent.com/u/476338?v=3","gravatar_id":"","url":"https://api.github.com/users/joshkel","html_url":"https://github.com/joshkel","followers_url":"https://api.github.com/users/joshkel/followers","following_url":"https://api.github.com/users/joshkel/following{/other_user}","gists_url":"https://api.github.com/users/joshkel/gists{/gist_id}","starred_url":"https://api.github.com/users/joshkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshkel/subscriptions","organizations_url":"https://api.github.com/users/joshkel/orgs","repos_url":"https://api.github.com/users/joshkel/repos","events_url":"https://api.github.com/users/joshkel/events{/privacy}","received_events_url":"https://api.github.com/users/joshkel/received_events","type":"User","site_admin":false},"repo":{"id":73103586,"name":"redux-promise-middleware","full_name":"joshkel/redux-promise-middleware","owner":{"login":"joshkel","id":476338,"avatar_url":"https://avatars.githubusercontent.com/u/476338?v=3","gravatar_id":"","url":"https://api.github.com/users/joshkel","html_url":"https://github.com/joshkel","followers_url":"https://api.github.com/users/joshkel/followers","following_url":"https://api.github.com/users/joshkel/following{/other_user}","gists_url":"https://api.github.com/users/joshkel/gists{/gist_id}","starred_url":"https://api.github.com/users/joshkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshkel/subscriptions","organizations_url":"https://api.github.com/users/joshkel/orgs","repos_url":"https://api.github.com/users/joshkel/repos","events_url":"https://api.github.com/users/joshkel/events{/privacy}","received_events_url":"https://api.github.com/users/joshkel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joshkel/redux-promise-middleware","description":"Redux middleware for resolving and rejecting promises with conditional optimistic updates","fork":true,"url":"https://api.github.com/repos/joshkel/redux-promise-middleware","forks_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/forks","keys_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/teams","hooks_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/hooks","issue_events_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/issues/events{/number}","events_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/events","assignees_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/assignees{/user}","branches_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/branches{/branch}","tags_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/tags","blobs_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/statuses/{sha}","languages_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/languages","stargazers_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/stargazers","contributors_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/contributors","subscribers_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/subscribers","subscription_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/subscription","commits_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/contents/{+path}","compare_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/merges","archive_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/downloads","issues_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/issues{/number}","pulls_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/pulls{/number}","milestones_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/milestones{/number}","notifications_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/labels{/name}","releases_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/releases{/id}","deployments_url":"https://api.github.com/repos/joshkel/redux-promise-middleware/deployments","created_at":"2016-11-07T17:28:23Z","updated_at":"2016-11-07T17:28:25Z","pushed_at":"2016-11-28T04:10:18Z","git_url":"git://github.com/joshkel/redux-promise-middleware.git","ssh_url":"git@github.com:joshkel/redux-promise-middleware.git","clone_url":"https://github.com/joshkel/redux-promise-middleware.git","svn_url":"https://github.com/joshkel/redux-promise-middleware","homepage":"","size":196,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pburtchaell:master","ref":"master","sha":"b0ce079c07190e5f8b0c970db3392ac40d56d6f8","user":{"login":"pburtchaell","id":3857324,"avatar_url":"https://avatars.githubusercontent.com/u/3857324?v=3","gravatar_id":"","url":"https://api.github.com/users/pburtchaell","html_url":"https://github.com/pburtchaell","followers_url":"https://api.github.com/users/pburtchaell/followers","following_url":"https://api.github.com/users/pburtchaell/following{/other_user}","gists_url":"https://api.github.com/users/pburtchaell/gists{/gist_id}","starred_url":"https://api.github.com/users/pburtchaell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pburtchaell/subscriptions","organizations_url":"https://api.github.com/users/pburtchaell/orgs","repos_url":"https://api.github.com/users/pburtchaell/repos","events_url":"https://api.github.com/users/pburtchaell/events{/privacy}","received_events_url":"https://api.github.com/users/pburtchaell/received_events","type":"User","site_admin":false},"repo":{"id":38990306,"name":"redux-promise-middleware","full_name":"pburtchaell/redux-promise-middleware","owner":{"login":"pburtchaell","id":3857324,"avatar_url":"https://avatars.githubusercontent.com/u/3857324?v=3","gravatar_id":"","url":"https://api.github.com/users/pburtchaell","html_url":"https://github.com/pburtchaell","followers_url":"https://api.github.com/users/pburtchaell/followers","following_url":"https://api.github.com/users/pburtchaell/following{/other_user}","gists_url":"https://api.github.com/users/pburtchaell/gists{/gist_id}","starred_url":"https://api.github.com/users/pburtchaell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pburtchaell/subscriptions","organizations_url":"https://api.github.com/users/pburtchaell/orgs","repos_url":"https://api.github.com/users/pburtchaell/repos","events_url":"https://api.github.com/users/pburtchaell/events{/privacy}","received_events_url":"https://api.github.com/users/pburtchaell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pburtchaell/redux-promise-middleware","description":"Redux middleware for resolving and rejecting promises with conditional optimistic updates","fork":false,"url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware","forks_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/forks","keys_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/teams","hooks_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/hooks","issue_events_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/issues/events{/number}","events_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/events","assignees_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/assignees{/user}","branches_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/branches{/branch}","tags_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/tags","blobs_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/git/refs{/sha}","trees_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/statuses/{sha}","languages_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/languages","stargazers_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/stargazers","contributors_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/contributors","subscribers_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/subscribers","subscription_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/subscription","commits_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/commits{/sha}","git_commits_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/git/commits{/sha}","comments_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/comments{/number}","issue_comment_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/issues/comments{/number}","contents_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/contents/{+path}","compare_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/merges","archive_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/downloads","issues_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/issues{/number}","pulls_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/pulls{/number}","milestones_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/milestones{/number}","notifications_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/labels{/name}","releases_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/releases{/id}","deployments_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/deployments","created_at":"2015-07-13T03:55:34Z","updated_at":"2016-11-29T16:08:35Z","pushed_at":"2016-11-29T16:27:13Z","git_url":"git://github.com/pburtchaell/redux-promise-middleware.git","ssh_url":"git@github.com:pburtchaell/redux-promise-middleware.git","clone_url":"https://github.com/pburtchaell/redux-promise-middleware.git","svn_url":"https://github.com/pburtchaell/redux-promise-middleware","homepage":"","size":288,"stargazers_count":634,"watchers_count":634,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":4,"forks":68,"open_issues":4,"watchers":634,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/pulls/128"},"html":{"href":"https://github.com/pburtchaell/redux-promise-middleware/pull/128"},"issue":{"href":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/issues/128"},"comments":{"href":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/statuses/8dd67dfc260e0542752acf231fd2c4d221d503e7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pburtchaell","id":3857324,"avatar_url":"https://avatars.githubusercontent.com/u/3857324?v=3","gravatar_id":"","url":"https://api.github.com/users/pburtchaell","html_url":"https://github.com/pburtchaell","followers_url":"https://api.github.com/users/pburtchaell/followers","following_url":"https://api.github.com/users/pburtchaell/following{/other_user}","gists_url":"https://api.github.com/users/pburtchaell/gists{/gist_id}","starred_url":"https://api.github.com/users/pburtchaell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pburtchaell/subscriptions","organizations_url":"https://api.github.com/users/pburtchaell/orgs","repos_url":"https://api.github.com/users/pburtchaell/repos","events_url":"https://api.github.com/users/pburtchaell/events{/privacy}","received_events_url":"https://api.github.com/users/pburtchaell/received_events","type":"User","site_admin":false},"comments":7,"review_comments":3,"commits":2,"additions":30,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"pburtchaell"}}