{"push_id":1398544827,"size":4,"distinct_size":4,"ref":"refs/heads/no-let-in-loops","head":"d1d337926b3b4a9c1eb1b431addc9f2fc4b3e104","before":"7b2d24f97c065e96ac0824704c33cb24ee9af263","commits":[{"sha":"d7b9f361df1f28ddd12dcc636270100b05f2a559","author":{"name":"Myles Borins","email":"fa4104c2f7906211d344e192a32afbfd5705deb7@us.ibm.com"},"message":"lib: remove let from for loops\n\nThis is a known de-opt. It may not be 100% necessary in all cases but it\nseems like a decent enough idea to avoid it.\n\nRef: https://github.com/nodejs/node/pull/9553\nPR-URL: https://github.com/nodejs/node/pull/8873\nReviewed-By: Brian White <mscdex@mscdex.net>\nReviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>\nReviewed-By: Johan Bergström <bugs@bergstroem.nu>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>","distinct":true,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/d7b9f361df1f28ddd12dcc636270100b05f2a559"},{"sha":"c25eb61194360cd7d4dd49beb2a993410fda2073","author":{"name":"Anna Henningsen","email":"6ab69d5d0413b53c075e34a831dd9f590ea00ac1@addaleax.net"},"message":"streams: fix regression in `unpipe()`\n\nSince 2e568d9 there is a bug where unpiping a stream\nfrom a readable stream that has `_readableState.pipesCount > 1`\nwill cause it to remove the first stream in the\n`_.readableState.pipes` array no matter where in the list the\n`dest` stream was.\n\nThis patch corrects that problem.\n\nRef: https://github.com/nodejs/node/pull/9553\nPR-URL: https://github.com/nodejs/node/pull/9171\nFixes: https://github.com/nodejs/node/issues/9170\nReviewed-By: Evan Lucas <evanlucas@me.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Matteo Collina <matteo.collina@gmail.com>\nReviewed-By: Myles Borins <myles.borins@gmail.com>","distinct":true,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/c25eb61194360cd7d4dd49beb2a993410fda2073"},{"sha":"a1d7201df3f4825df4c36bb8b948a508f0869015","author":{"name":"Niels Nielsen","email":"49ca49a8341c4b8217285575174ce60a9fa81538@protectwise.com"},"message":"test: add regression test for `unpipe()`\n\nSince 2e568d9 there is a bug where unpiping a stream\nfrom a readable stream that has `_readableState.pipesCount > 1`\nwill cause it to remove the first stream in the\n`_.readableState.pipes` array no matter where in the list the\n`dest` stream was.\n\nRef: https://github.com/nodejs/node/pull/9553\nPR-URL: https://github.com/nodejs/node/pull/9171\nReviewed-By: Evan Lucas <evanlucas@me.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Matteo Collina <matteo.collina@gmail.com>\nReviewed-By: Myles Borins <myles.borins@gmail.com>","distinct":true,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/a1d7201df3f4825df4c36bb8b948a508f0869015"},{"sha":"d1d337926b3b4a9c1eb1b431addc9f2fc4b3e104","author":{"name":"jessicaquynh","email":"329bced5fac3171f6bb864ab94da4d9e56bf2cb0@gmail.com"},"message":"tools: avoid let in for loops\n\nThis adds a new ESLint tool to check for let\ndeclarations within the for, forIn, forOf expressions.\n\nFixes: https://github.com/nodejs/node/issues/9045\nRef: https://github.com/nodejs/node/pull/9553\nRef: https://github.com/nodejs/node/pull/8873\nPR-URL: https://github.com/nodejs/node/pull/9049\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Myles Borins <myles.borins@gmail.com>\nReviewed-By: Teddy Katz <teddy.katz@gmail.com>\nReviewed-By: Prince John Wesley <princejohnwesley@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/d1d337926b3b4a9c1eb1b431addc9f2fc4b3e104"}]}
{"actor":{"display_login":"TheAlphaNerd"}}