{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/73805659","id":73805659,"diff_hunk":"@@ -408,7 +408,9 @@ export function getDataParamsFromAttributes(element, opt_computeParamNameFunc) {\n   const params = Object.create(null);\n   for (let i = 0; i < attributes.length; i++) {\n     const attr = attributes[i];\n-    const matches = attr.name.match(/^data-param-(.+)/);\n+    const attrName = attr.name;\n+    const matches = attrName.match(/^data-param-(.+)/) ||\n+      attrName.match(/^data-vars-(.+)/);\n     if (matches) {\n       const param = dashToCamelCase(matches[1]);","path":"src/dom.js","position":null,"original_position":9,"commit_id":"46e9f19cb86e52e88cbf212b415a2902d425e562","original_commit_id":"e23ae67faf1b18f85bc8f22776fc2b5b45c58801","user":{"login":"rajkumarsrk","id":691176,"avatar_url":"https://avatars.githubusercontent.com/u/691176?v=3","gravatar_id":"","url":"https://api.github.com/users/rajkumarsrk","html_url":"https://github.com/rajkumarsrk","followers_url":"https://api.github.com/users/rajkumarsrk/followers","following_url":"https://api.github.com/users/rajkumarsrk/following{/other_user}","gists_url":"https://api.github.com/users/rajkumarsrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rajkumarsrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajkumarsrk/subscriptions","organizations_url":"https://api.github.com/users/rajkumarsrk/orgs","repos_url":"https://api.github.com/users/rajkumarsrk/repos","events_url":"https://api.github.com/users/rajkumarsrk/events{/privacy}","received_events_url":"https://api.github.com/users/rajkumarsrk/received_events","type":"User","site_admin":false},"body":"@avimehta Updated to use dataset","created_at":"2016-08-07T17:15:43Z","updated_at":"2016-08-07T17:15:43Z","html_url":"https://github.com/ampproject/amphtml/pull/4072#discussion_r73805659","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/4072","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/73805659"},"html":{"href":"https://github.com/ampproject/amphtml/pull/4072#discussion_r73805659"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4072"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/4072","id":77509203,"html_url":"https://github.com/ampproject/amphtml/pull/4072","diff_url":"https://github.com/ampproject/amphtml/pull/4072.diff","patch_url":"https://github.com/ampproject/amphtml/pull/4072.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/4072","number":4072,"state":"open","locked":false,"title":"Added element-level overrides for variables for amp-analytics","user":{"login":"rajkumarsrk","id":691176,"avatar_url":"https://avatars.githubusercontent.com/u/691176?v=3","gravatar_id":"","url":"https://api.github.com/users/rajkumarsrk","html_url":"https://github.com/rajkumarsrk","followers_url":"https://api.github.com/users/rajkumarsrk/followers","following_url":"https://api.github.com/users/rajkumarsrk/following{/other_user}","gists_url":"https://api.github.com/users/rajkumarsrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rajkumarsrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajkumarsrk/subscriptions","organizations_url":"https://api.github.com/users/rajkumarsrk/orgs","repos_url":"https://api.github.com/users/rajkumarsrk/repos","events_url":"https://api.github.com/users/rajkumarsrk/events{/privacy}","received_events_url":"https://api.github.com/users/rajkumarsrk/received_events","type":"User","site_admin":false},"body":"Adding element level overrides for amp-analytics variable based on the discussion that we had\r\nhttps://github.com/ampproject/amphtml/issues/1298#issuecomment-226036199.\r\nPlease review it and let me know your feedback\r\n\r\n@avimehta @cramforce Could you suggest best place where I can update the documentation for this.\r\nI was thinking to add it here\r\nhttps://github.com/ampproject/amphtml/blob/master/extensions/amp-analytics/amp-analytics.md#vars. But will wait for you inputs\r\n","created_at":"2016-07-14T19:11:53Z","updated_at":"2016-08-07T17:15:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4f9fb0886f1e477281c32ce0f13e5ec403b581f","assignee":{"login":"avimehta","id":179359,"avatar_url":"https://avatars.githubusercontent.com/u/179359?v=3","gravatar_id":"","url":"https://api.github.com/users/avimehta","html_url":"https://github.com/avimehta","followers_url":"https://api.github.com/users/avimehta/followers","following_url":"https://api.github.com/users/avimehta/following{/other_user}","gists_url":"https://api.github.com/users/avimehta/gists{/gist_id}","starred_url":"https://api.github.com/users/avimehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avimehta/subscriptions","organizations_url":"https://api.github.com/users/avimehta/orgs","repos_url":"https://api.github.com/users/avimehta/repos","events_url":"https://api.github.com/users/avimehta/events{/privacy}","received_events_url":"https://api.github.com/users/avimehta/received_events","type":"User","site_admin":false},"assignees":[{"login":"avimehta","id":179359,"avatar_url":"https://avatars.githubusercontent.com/u/179359?v=3","gravatar_id":"","url":"https://api.github.com/users/avimehta","html_url":"https://github.com/avimehta","followers_url":"https://api.github.com/users/avimehta/followers","following_url":"https://api.github.com/users/avimehta/following{/other_user}","gists_url":"https://api.github.com/users/avimehta/gists{/gist_id}","starred_url":"https://api.github.com/users/avimehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avimehta/subscriptions","organizations_url":"https://api.github.com/users/avimehta/orgs","repos_url":"https://api.github.com/users/avimehta/repos","events_url":"https://api.github.com/users/avimehta/events{/privacy}","received_events_url":"https://api.github.com/users/avimehta/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/4072/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/4072/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/4072/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/46e9f19cb86e52e88cbf212b415a2902d425e562","head":{"label":"rajkumarsrk:master","ref":"master","sha":"46e9f19cb86e52e88cbf212b415a2902d425e562","user":{"login":"rajkumarsrk","id":691176,"avatar_url":"https://avatars.githubusercontent.com/u/691176?v=3","gravatar_id":"","url":"https://api.github.com/users/rajkumarsrk","html_url":"https://github.com/rajkumarsrk","followers_url":"https://api.github.com/users/rajkumarsrk/followers","following_url":"https://api.github.com/users/rajkumarsrk/following{/other_user}","gists_url":"https://api.github.com/users/rajkumarsrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rajkumarsrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajkumarsrk/subscriptions","organizations_url":"https://api.github.com/users/rajkumarsrk/orgs","repos_url":"https://api.github.com/users/rajkumarsrk/repos","events_url":"https://api.github.com/users/rajkumarsrk/events{/privacy}","received_events_url":"https://api.github.com/users/rajkumarsrk/received_events","type":"User","site_admin":false},"repo":{"id":59454536,"name":"amphtml","full_name":"rajkumarsrk/amphtml","owner":{"login":"rajkumarsrk","id":691176,"avatar_url":"https://avatars.githubusercontent.com/u/691176?v=3","gravatar_id":"","url":"https://api.github.com/users/rajkumarsrk","html_url":"https://github.com/rajkumarsrk","followers_url":"https://api.github.com/users/rajkumarsrk/followers","following_url":"https://api.github.com/users/rajkumarsrk/following{/other_user}","gists_url":"https://api.github.com/users/rajkumarsrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rajkumarsrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajkumarsrk/subscriptions","organizations_url":"https://api.github.com/users/rajkumarsrk/orgs","repos_url":"https://api.github.com/users/rajkumarsrk/repos","events_url":"https://api.github.com/users/rajkumarsrk/events{/privacy}","received_events_url":"https://api.github.com/users/rajkumarsrk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rajkumarsrk/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/rajkumarsrk/amphtml","forks_url":"https://api.github.com/repos/rajkumarsrk/amphtml/forks","keys_url":"https://api.github.com/repos/rajkumarsrk/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rajkumarsrk/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rajkumarsrk/amphtml/teams","hooks_url":"https://api.github.com/repos/rajkumarsrk/amphtml/hooks","issue_events_url":"https://api.github.com/repos/rajkumarsrk/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/rajkumarsrk/amphtml/events","assignees_url":"https://api.github.com/repos/rajkumarsrk/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/rajkumarsrk/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/rajkumarsrk/amphtml/tags","blobs_url":"https://api.github.com/repos/rajkumarsrk/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rajkumarsrk/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rajkumarsrk/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/rajkumarsrk/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rajkumarsrk/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/rajkumarsrk/amphtml/languages","stargazers_url":"https://api.github.com/repos/rajkumarsrk/amphtml/stargazers","contributors_url":"https://api.github.com/repos/rajkumarsrk/amphtml/contributors","subscribers_url":"https://api.github.com/repos/rajkumarsrk/amphtml/subscribers","subscription_url":"https://api.github.com/repos/rajkumarsrk/amphtml/subscription","commits_url":"https://api.github.com/repos/rajkumarsrk/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/rajkumarsrk/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/rajkumarsrk/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/rajkumarsrk/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/rajkumarsrk/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/rajkumarsrk/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rajkumarsrk/amphtml/merges","archive_url":"https://api.github.com/repos/rajkumarsrk/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rajkumarsrk/amphtml/downloads","issues_url":"https://api.github.com/repos/rajkumarsrk/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/rajkumarsrk/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/rajkumarsrk/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/rajkumarsrk/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rajkumarsrk/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/rajkumarsrk/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/rajkumarsrk/amphtml/deployments","created_at":"2016-05-23T05:34:01Z","updated_at":"2016-05-23T05:34:05Z","pushed_at":"2016-08-07T05:33:51Z","git_url":"git://github.com/rajkumarsrk/amphtml.git","ssh_url":"git@github.com:rajkumarsrk/amphtml.git","clone_url":"https://github.com/rajkumarsrk/amphtml.git","svn_url":"https://github.com/rajkumarsrk/amphtml","homepage":"https://ampproject.org","size":128152,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"2eac42a6670a2084100d6c6fd8f16e8cdc6eb91a","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2016-08-07T13:35:53Z","pushed_at":"2016-08-07T05:33:52Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":139242,"stargazers_count":8112,"watchers_count":8112,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1170,"mirror_url":null,"open_issues_count":674,"forks":1170,"open_issues":674,"watchers":8112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4072"},"html":{"href":"https://github.com/ampproject/amphtml/pull/4072"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/4072"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/4072/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4072/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4072/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/46e9f19cb86e52e88cbf212b415a2902d425e562"}}}}
{"actor":{"display_login":"rajkumarsrk"}}