{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/72464272","id":72464272,"diff_hunk":"@@ -75,6 +71,15 @@ func main() {\n \tlog.SetFlags(log.LstdFlags | log.Lshortfile)\n \tflag.Parse()\n \n+\tcwd, err := os.Getwd()\n+\tif err != nil {\n+\t\tlog.Fatalf(\"Could not get pwd: %v\", err)\n+\t}\n+\tacwd, _ := filepath.Abs(cwd)","path":"hack/e2e.go","position":81,"original_position":81,"commit_id":"ff4ba951867b30fb9d0bb210c5afac7fd7b9f24f","original_commit_id":"ff4ba951867b30fb9d0bb210c5afac7fd7b9f24f","user":{"login":"fejta","id":940341,"avatar_url":"https://avatars.githubusercontent.com/u/940341?v=3","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"body":"Checking `err`","created_at":"2016-07-27T15:39:33Z","updated_at":"2016-07-27T15:39:33Z","html_url":"https://github.com/kubernetes/kubernetes/pull/28575#discussion_r72464272","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28575","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/72464272"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/28575#discussion_r72464272"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28575"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28575","id":76537110,"html_url":"https://github.com/kubernetes/kubernetes/pull/28575","diff_url":"https://github.com/kubernetes/kubernetes/pull/28575.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/28575.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28575","number":28575,"state":"open","locked":false,"title":"Move kubemark, skew, upgrade, leak logic into hack/e2e.go","user":{"login":"fejta","id":940341,"avatar_url":"https://avatars.githubusercontent.com/u/940341?v=3","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"body":"And move out of the `e2e_runner.sh`\r\nAlso make `start-kubemark.sh` automatically find `kubernetes-server-linux-amd64.tar.gz` instead of depending on a `RUN_FROM_DISTRO` env var\r\n\r\n@gmarek can you review the kubemark-related changes?\r\n@zmerlynn are you the right person to review upgrade changes?\r\n\r\n@spxtr take a look at the overall `e2e.go` changes.\r\n\r\nPS: LGTM with a comment, do not add the label\r\n\r\nThis is for https://github.com/kubernetes/kubernetes/issues/21843 and https://github.com/kubernetes/test-infra/pull/250","created_at":"2016-07-07T04:15:40Z","updated_at":"2016-07-27T15:39:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52de6d75b0885828c6c2fb320e07c8be4e51905b","assignee":{"login":"gmarek","id":1703842,"avatar_url":"https://avatars.githubusercontent.com/u/1703842?v=3","gravatar_id":"","url":"https://api.github.com/users/gmarek","html_url":"https://github.com/gmarek","followers_url":"https://api.github.com/users/gmarek/followers","following_url":"https://api.github.com/users/gmarek/following{/other_user}","gists_url":"https://api.github.com/users/gmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/gmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmarek/subscriptions","organizations_url":"https://api.github.com/users/gmarek/orgs","repos_url":"https://api.github.com/users/gmarek/repos","events_url":"https://api.github.com/users/gmarek/events{/privacy}","received_events_url":"https://api.github.com/users/gmarek/received_events","type":"User","site_admin":false},"assignees":[{"login":"gmarek","id":1703842,"avatar_url":"https://avatars.githubusercontent.com/u/1703842?v=3","gravatar_id":"","url":"https://api.github.com/users/gmarek","html_url":"https://github.com/gmarek","followers_url":"https://api.github.com/users/gmarek/followers","following_url":"https://api.github.com/users/gmarek/following{/other_user}","gists_url":"https://api.github.com/users/gmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/gmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmarek/subscriptions","organizations_url":"https://api.github.com/users/gmarek/orgs","repos_url":"https://api.github.com/users/gmarek/repos","events_url":"https://api.github.com/users/gmarek/events{/privacy}","received_events_url":"https://api.github.com/users/gmarek/received_events","type":"User","site_admin":false},{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false},{"login":"spxtr","id":7368979,"avatar_url":"https://avatars.githubusercontent.com/u/7368979?v=3","gravatar_id":"","url":"https://api.github.com/users/spxtr","html_url":"https://github.com/spxtr","followers_url":"https://api.github.com/users/spxtr/followers","following_url":"https://api.github.com/users/spxtr/following{/other_user}","gists_url":"https://api.github.com/users/spxtr/gists{/gist_id}","starred_url":"https://api.github.com/users/spxtr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spxtr/subscriptions","organizations_url":"https://api.github.com/users/spxtr/orgs","repos_url":"https://api.github.com/users/spxtr/repos","events_url":"https://api.github.com/users/spxtr/events{/privacy}","received_events_url":"https://api.github.com/users/spxtr/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28575/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28575/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28575/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ff4ba951867b30fb9d0bb210c5afac7fd7b9f24f","head":{"label":"fejta:check-resources","ref":"check-resources","sha":"ff4ba951867b30fb9d0bb210c5afac7fd7b9f24f","user":{"login":"fejta","id":940341,"avatar_url":"https://avatars.githubusercontent.com/u/940341?v=3","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"repo":{"id":45314479,"name":"kubernetes","full_name":"fejta/kubernetes","owner":{"login":"fejta","id":940341,"avatar_url":"https://avatars.githubusercontent.com/u/940341?v=3","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fejta/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/fejta/kubernetes","forks_url":"https://api.github.com/repos/fejta/kubernetes/forks","keys_url":"https://api.github.com/repos/fejta/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fejta/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fejta/kubernetes/teams","hooks_url":"https://api.github.com/repos/fejta/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/fejta/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/fejta/kubernetes/events","assignees_url":"https://api.github.com/repos/fejta/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/fejta/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/fejta/kubernetes/tags","blobs_url":"https://api.github.com/repos/fejta/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fejta/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fejta/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/fejta/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fejta/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/fejta/kubernetes/languages","stargazers_url":"https://api.github.com/repos/fejta/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/fejta/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/fejta/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/fejta/kubernetes/subscription","commits_url":"https://api.github.com/repos/fejta/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/fejta/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/fejta/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/fejta/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/fejta/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/fejta/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fejta/kubernetes/merges","archive_url":"https://api.github.com/repos/fejta/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fejta/kubernetes/downloads","issues_url":"https://api.github.com/repos/fejta/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/fejta/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/fejta/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/fejta/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fejta/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/fejta/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/fejta/kubernetes/deployments","created_at":"2015-10-31T19:04:21Z","updated_at":"2016-03-01T04:34:12Z","pushed_at":"2016-07-27T15:31:08Z","git_url":"git://github.com/fejta/kubernetes.git","ssh_url":"git@github.com:fejta/kubernetes.git","clone_url":"https://github.com/fejta/kubernetes.git","svn_url":"https://github.com/fejta/kubernetes","homepage":"http://kubernetes.io","size":278196,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"5fe54ac9efda3b2bc15b01f49412be69ad07a8a6","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-07-27T15:27:43Z","pushed_at":"2016-07-27T15:28:13Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":513311,"stargazers_count":15793,"watchers_count":15793,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4991,"mirror_url":null,"open_issues_count":4037,"forks":4991,"open_issues":4037,"watchers":15793,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28575"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/28575"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/28575"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/28575/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28575/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28575/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ff4ba951867b30fb9d0bb210c5afac7fd7b9f24f"}}}}
{"actor":{"display_login":"fejta"}}