{"action":"created","comment":{"url":"https://api.github.com/repos/deis/jenkins-jobs/pulls/comments/76458440","id":76458440,"diff_hunk":"@@ -129,20 +130,28 @@ import utilities.StatusUpdater\n       if (isPR) { // update commit with pending status while tests run\n         shell StatusUpdater.updateStatus(\n           commitStatus: 'pending', repoName: '${COMPONENT_REPO}', commitSHA: '${ACTUAL_COMMIT}', description: 'Running e2e tests...')\n+\n+        setupHelmcEnv = new File(\"${WORKSPACE}/bash/scripts/setup_helmc_environment.sh\").text\n+        setupHelmcEnv += \"\"\"\n+          mkdir -p ${defaults.tmpPath}\n+          setup-helmc-env >> ${defaults.envFile}","path":"jobs/workflow_test.groovy","position":16,"original_position":16,"commit_id":"dc4cee535bac1c98a6acc7fd0860929afac58df1","original_commit_id":"dc4cee535bac1c98a6acc7fd0860929afac58df1","user":{"login":"sgoings","id":123755,"avatar_url":"https://avatars.githubusercontent.com/u/123755?v=3","gravatar_id":"","url":"https://api.github.com/users/sgoings","html_url":"https://github.com/sgoings","followers_url":"https://api.github.com/users/sgoings/followers","following_url":"https://api.github.com/users/sgoings/following{/other_user}","gists_url":"https://api.github.com/users/sgoings/gists{/gist_id}","starred_url":"https://api.github.com/users/sgoings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgoings/subscriptions","organizations_url":"https://api.github.com/users/sgoings/orgs","repos_url":"https://api.github.com/users/sgoings/repos","events_url":"https://api.github.com/users/sgoings/events{/privacy}","received_events_url":"https://api.github.com/users/sgoings/received_events","type":"User","site_admin":false},"body":"Why is this behavior \"append\" now?","created_at":"2016-08-26T17:43:15Z","updated_at":"2016-08-26T17:43:15Z","html_url":"https://github.com/deis/jenkins-jobs/pull/215#discussion_r76458440","pull_request_url":"https://api.github.com/repos/deis/jenkins-jobs/pulls/215","_links":{"self":{"href":"https://api.github.com/repos/deis/jenkins-jobs/pulls/comments/76458440"},"html":{"href":"https://github.com/deis/jenkins-jobs/pull/215#discussion_r76458440"},"pull_request":{"href":"https://api.github.com/repos/deis/jenkins-jobs/pulls/215"}}},"pull_request":{"url":"https://api.github.com/repos/deis/jenkins-jobs/pulls/215","id":82631177,"html_url":"https://github.com/deis/jenkins-jobs/pull/215","diff_url":"https://github.com/deis/jenkins-jobs/pull/215.diff","patch_url":"https://github.com/deis/jenkins-jobs/pull/215.patch","issue_url":"https://api.github.com/repos/deis/jenkins-jobs/issues/215","number":215,"state":"open","locked":false,"title":"feat(*): enable requiring a deis/charts commit","user":{"login":"vdice","id":9322017,"avatar_url":"https://avatars.githubusercontent.com/u/9322017?v=3","gravatar_id":"","url":"https://api.github.com/users/vdice","html_url":"https://github.com/vdice","followers_url":"https://api.github.com/users/vdice/followers","following_url":"https://api.github.com/users/vdice/following{/other_user}","gists_url":"https://api.github.com/users/vdice/gists{/gist_id}","starred_url":"https://api.github.com/users/vdice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdice/subscriptions","organizations_url":"https://api.github.com/users/vdice/orgs","repos_url":"https://api.github.com/users/vdice/repos","events_url":"https://api.github.com/users/vdice/events{/privacy}","received_events_url":"https://api.github.com/users/vdice/received_events","type":"User","site_admin":false},"body":"We already are set up to parse a required PR in any deis repo\r\nprovided it is mentioned in the git commit body, e.g. `Requires deis/<repo>#<pr_number>`\r\n\r\n(Previously, we only actually performed subsequent logic if it was a Workflow component repo.)\r\n\r\nThis sets us up so that we can perform logic if the required PR is in the (presumably forked) deis/charts repo.  \r\n\r\nThis logic consists of determining the appropriate repo clone url alongside the charts commit sha and passing this info down do the downstream e2e job so that it can set up its local helmc instance appropriately, before fetching charts.\r\n\r\nCloses https://github.com/deis/jenkins-jobs/issues/151\r\n\r\nTODO: manually test the added logic in this PR by:\r\n - [x] running the branch through Jenkins to be sure it parses correctly\r\n - [x] create a `workflow-test`-clone with logic hingeing off `CHARTS_SHA`\r\n - [x] issuing a test pr in a Workflow component repo requiring a PR in charts, with this logic running on Jenkins\r\n - [ ] delete https://ci.deis.io/job/require-charts-pr-seed-job/ once this is merged","created_at":"2016-08-24T22:51:48Z","updated_at":"2016-08-26T17:43:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4f31796f25d13c2a0b0904ca7732bb2ae4081f5","assignee":{"login":"vdice","id":9322017,"avatar_url":"https://avatars.githubusercontent.com/u/9322017?v=3","gravatar_id":"","url":"https://api.github.com/users/vdice","html_url":"https://github.com/vdice","followers_url":"https://api.github.com/users/vdice/followers","following_url":"https://api.github.com/users/vdice/following{/other_user}","gists_url":"https://api.github.com/users/vdice/gists{/gist_id}","starred_url":"https://api.github.com/users/vdice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdice/subscriptions","organizations_url":"https://api.github.com/users/vdice/orgs","repos_url":"https://api.github.com/users/vdice/repos","events_url":"https://api.github.com/users/vdice/events{/privacy}","received_events_url":"https://api.github.com/users/vdice/received_events","type":"User","site_admin":false},"assignees":[{"login":"vdice","id":9322017,"avatar_url":"https://avatars.githubusercontent.com/u/9322017?v=3","gravatar_id":"","url":"https://api.github.com/users/vdice","html_url":"https://github.com/vdice","followers_url":"https://api.github.com/users/vdice/followers","following_url":"https://api.github.com/users/vdice/following{/other_user}","gists_url":"https://api.github.com/users/vdice/gists{/gist_id}","starred_url":"https://api.github.com/users/vdice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdice/subscriptions","organizations_url":"https://api.github.com/users/vdice/orgs","repos_url":"https://api.github.com/users/vdice/repos","events_url":"https://api.github.com/users/vdice/events{/privacy}","received_events_url":"https://api.github.com/users/vdice/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/deis/jenkins-jobs/milestones/13","html_url":"https://github.com/deis/jenkins-jobs/milestones/v2.5","labels_url":"https://api.github.com/repos/deis/jenkins-jobs/milestones/13/labels","id":1922046,"number":13,"title":"v2.5","description":null,"creator":{"login":"deis-admin","id":12703824,"avatar_url":"https://avatars.githubusercontent.com/u/12703824?v=3","gravatar_id":"","url":"https://api.github.com/users/deis-admin","html_url":"https://github.com/deis-admin","followers_url":"https://api.github.com/users/deis-admin/followers","following_url":"https://api.github.com/users/deis-admin/following{/other_user}","gists_url":"https://api.github.com/users/deis-admin/gists{/gist_id}","starred_url":"https://api.github.com/users/deis-admin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis-admin/subscriptions","organizations_url":"https://api.github.com/users/deis-admin/orgs","repos_url":"https://api.github.com/users/deis-admin/repos","events_url":"https://api.github.com/users/deis-admin/events{/privacy}","received_events_url":"https://api.github.com/users/deis-admin/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":8,"state":"open","created_at":"2016-08-03T21:42:01Z","updated_at":"2016-08-26T17:37:46Z","due_on":"2016-08-30T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/deis/jenkins-jobs/pulls/215/commits","review_comments_url":"https://api.github.com/repos/deis/jenkins-jobs/pulls/215/comments","review_comment_url":"https://api.github.com/repos/deis/jenkins-jobs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deis/jenkins-jobs/issues/215/comments","statuses_url":"https://api.github.com/repos/deis/jenkins-jobs/statuses/dc4cee535bac1c98a6acc7fd0860929afac58df1","head":{"label":"vdice:enable-charts-pr-requires","ref":"enable-charts-pr-requires","sha":"dc4cee535bac1c98a6acc7fd0860929afac58df1","user":{"login":"vdice","id":9322017,"avatar_url":"https://avatars.githubusercontent.com/u/9322017?v=3","gravatar_id":"","url":"https://api.github.com/users/vdice","html_url":"https://github.com/vdice","followers_url":"https://api.github.com/users/vdice/followers","following_url":"https://api.github.com/users/vdice/following{/other_user}","gists_url":"https://api.github.com/users/vdice/gists{/gist_id}","starred_url":"https://api.github.com/users/vdice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdice/subscriptions","organizations_url":"https://api.github.com/users/vdice/orgs","repos_url":"https://api.github.com/users/vdice/repos","events_url":"https://api.github.com/users/vdice/events{/privacy}","received_events_url":"https://api.github.com/users/vdice/received_events","type":"User","site_admin":false},"repo":{"id":54910512,"name":"jenkins-jobs","full_name":"vdice/jenkins-jobs","owner":{"login":"vdice","id":9322017,"avatar_url":"https://avatars.githubusercontent.com/u/9322017?v=3","gravatar_id":"","url":"https://api.github.com/users/vdice","html_url":"https://github.com/vdice","followers_url":"https://api.github.com/users/vdice/followers","following_url":"https://api.github.com/users/vdice/following{/other_user}","gists_url":"https://api.github.com/users/vdice/gists{/gist_id}","starred_url":"https://api.github.com/users/vdice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdice/subscriptions","organizations_url":"https://api.github.com/users/vdice/orgs","repos_url":"https://api.github.com/users/vdice/repos","events_url":"https://api.github.com/users/vdice/events{/privacy}","received_events_url":"https://api.github.com/users/vdice/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vdice/jenkins-jobs","description":"DSL representations of Jenkins jobs for Deis","fork":true,"url":"https://api.github.com/repos/vdice/jenkins-jobs","forks_url":"https://api.github.com/repos/vdice/jenkins-jobs/forks","keys_url":"https://api.github.com/repos/vdice/jenkins-jobs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdice/jenkins-jobs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdice/jenkins-jobs/teams","hooks_url":"https://api.github.com/repos/vdice/jenkins-jobs/hooks","issue_events_url":"https://api.github.com/repos/vdice/jenkins-jobs/issues/events{/number}","events_url":"https://api.github.com/repos/vdice/jenkins-jobs/events","assignees_url":"https://api.github.com/repos/vdice/jenkins-jobs/assignees{/user}","branches_url":"https://api.github.com/repos/vdice/jenkins-jobs/branches{/branch}","tags_url":"https://api.github.com/repos/vdice/jenkins-jobs/tags","blobs_url":"https://api.github.com/repos/vdice/jenkins-jobs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdice/jenkins-jobs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdice/jenkins-jobs/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdice/jenkins-jobs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdice/jenkins-jobs/statuses/{sha}","languages_url":"https://api.github.com/repos/vdice/jenkins-jobs/languages","stargazers_url":"https://api.github.com/repos/vdice/jenkins-jobs/stargazers","contributors_url":"https://api.github.com/repos/vdice/jenkins-jobs/contributors","subscribers_url":"https://api.github.com/repos/vdice/jenkins-jobs/subscribers","subscription_url":"https://api.github.com/repos/vdice/jenkins-jobs/subscription","commits_url":"https://api.github.com/repos/vdice/jenkins-jobs/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdice/jenkins-jobs/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdice/jenkins-jobs/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdice/jenkins-jobs/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdice/jenkins-jobs/contents/{+path}","compare_url":"https://api.github.com/repos/vdice/jenkins-jobs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdice/jenkins-jobs/merges","archive_url":"https://api.github.com/repos/vdice/jenkins-jobs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdice/jenkins-jobs/downloads","issues_url":"https://api.github.com/repos/vdice/jenkins-jobs/issues{/number}","pulls_url":"https://api.github.com/repos/vdice/jenkins-jobs/pulls{/number}","milestones_url":"https://api.github.com/repos/vdice/jenkins-jobs/milestones{/number}","notifications_url":"https://api.github.com/repos/vdice/jenkins-jobs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdice/jenkins-jobs/labels{/name}","releases_url":"https://api.github.com/repos/vdice/jenkins-jobs/releases{/id}","deployments_url":"https://api.github.com/repos/vdice/jenkins-jobs/deployments","created_at":"2016-03-28T17:35:10Z","updated_at":"2016-03-28T17:35:12Z","pushed_at":"2016-08-26T17:42:53Z","git_url":"git://github.com/vdice/jenkins-jobs.git","ssh_url":"git@github.com:vdice/jenkins-jobs.git","clone_url":"https://github.com/vdice/jenkins-jobs.git","svn_url":"https://github.com/vdice/jenkins-jobs","homepage":null,"size":256,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deis:master","ref":"master","sha":"6cfd3dd27bf66be11ab6886491cff12776cfc3eb","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":54904267,"name":"jenkins-jobs","full_name":"deis/jenkins-jobs","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/jenkins-jobs","description":"DSL representations of Jenkins jobs for Deis","fork":false,"url":"https://api.github.com/repos/deis/jenkins-jobs","forks_url":"https://api.github.com/repos/deis/jenkins-jobs/forks","keys_url":"https://api.github.com/repos/deis/jenkins-jobs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/jenkins-jobs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/jenkins-jobs/teams","hooks_url":"https://api.github.com/repos/deis/jenkins-jobs/hooks","issue_events_url":"https://api.github.com/repos/deis/jenkins-jobs/issues/events{/number}","events_url":"https://api.github.com/repos/deis/jenkins-jobs/events","assignees_url":"https://api.github.com/repos/deis/jenkins-jobs/assignees{/user}","branches_url":"https://api.github.com/repos/deis/jenkins-jobs/branches{/branch}","tags_url":"https://api.github.com/repos/deis/jenkins-jobs/tags","blobs_url":"https://api.github.com/repos/deis/jenkins-jobs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/jenkins-jobs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/jenkins-jobs/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/jenkins-jobs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/jenkins-jobs/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/jenkins-jobs/languages","stargazers_url":"https://api.github.com/repos/deis/jenkins-jobs/stargazers","contributors_url":"https://api.github.com/repos/deis/jenkins-jobs/contributors","subscribers_url":"https://api.github.com/repos/deis/jenkins-jobs/subscribers","subscription_url":"https://api.github.com/repos/deis/jenkins-jobs/subscription","commits_url":"https://api.github.com/repos/deis/jenkins-jobs/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/jenkins-jobs/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/jenkins-jobs/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/jenkins-jobs/issues/comments{/number}","contents_url":"https://api.github.com/repos/deis/jenkins-jobs/contents/{+path}","compare_url":"https://api.github.com/repos/deis/jenkins-jobs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/jenkins-jobs/merges","archive_url":"https://api.github.com/repos/deis/jenkins-jobs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/jenkins-jobs/downloads","issues_url":"https://api.github.com/repos/deis/jenkins-jobs/issues{/number}","pulls_url":"https://api.github.com/repos/deis/jenkins-jobs/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/jenkins-jobs/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/jenkins-jobs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/jenkins-jobs/labels{/name}","releases_url":"https://api.github.com/repos/deis/jenkins-jobs/releases{/id}","deployments_url":"https://api.github.com/repos/deis/jenkins-jobs/deployments","created_at":"2016-03-28T16:02:28Z","updated_at":"2016-06-10T19:46:25Z","pushed_at":"2016-08-26T17:37:46Z","git_url":"git://github.com/deis/jenkins-jobs.git","ssh_url":"git@github.com:deis/jenkins-jobs.git","clone_url":"https://github.com/deis/jenkins-jobs.git","svn_url":"https://github.com/deis/jenkins-jobs","homepage":null,"size":202,"stargazers_count":4,"watchers_count":4,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":31,"forks":11,"open_issues":31,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/jenkins-jobs/pulls/215"},"html":{"href":"https://github.com/deis/jenkins-jobs/pull/215"},"issue":{"href":"https://api.github.com/repos/deis/jenkins-jobs/issues/215"},"comments":{"href":"https://api.github.com/repos/deis/jenkins-jobs/issues/215/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/jenkins-jobs/pulls/215/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/jenkins-jobs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deis/jenkins-jobs/pulls/215/commits"},"statuses":{"href":"https://api.github.com/repos/deis/jenkins-jobs/statuses/dc4cee535bac1c98a6acc7fd0860929afac58df1"}}}}
{"actor":{"display_login":"sgoings"}}