{"action":"created","issue":{"url":"https://api.github.com/repos/monero-project/kovri/issues/238","repository_url":"https://api.github.com/repos/monero-project/kovri","labels_url":"https://api.github.com/repos/monero-project/kovri/issues/238/labels{/name}","comments_url":"https://api.github.com/repos/monero-project/kovri/issues/238/comments","events_url":"https://api.github.com/repos/monero-project/kovri/issues/238/events","html_url":"https://github.com/monero-project/kovri/issues/238","id":165904094,"number":238,"title":"Clarify coding style deviations from the Google style","user":{"login":"rakhimov","id":3354921,"avatar_url":"https://avatars.githubusercontent.com/u/3354921?v=3","gravatar_id":"","url":"https://api.github.com/users/rakhimov","html_url":"https://github.com/rakhimov","followers_url":"https://api.github.com/users/rakhimov/followers","following_url":"https://api.github.com/users/rakhimov/following{/other_user}","gists_url":"https://api.github.com/users/rakhimov/gists{/gist_id}","starred_url":"https://api.github.com/users/rakhimov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakhimov/subscriptions","organizations_url":"https://api.github.com/users/rakhimov/orgs","repos_url":"https://api.github.com/users/rakhimov/repos","events_url":"https://api.github.com/users/rakhimov/events{/privacy}","received_events_url":"https://api.github.com/users/rakhimov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-16T02:23:34Z","updated_at":"2016-07-16T02:40:43Z","closed_at":null,"body":"**By submitting this issue, I confirm the following:**\r\n\r\n- I have read and understood the [contributor guide](https://github.com/monero-project/kovri/blob/master/doc/CONTRIBUTING.md).\r\n- I have checked that the issue I am reporting can be replicated or that the feature I am suggesting is not present.\r\n- I have checked opened or recently closed [pull requests](https://github.com/monero-project/kovri/pulls) for existing solutions/implementations to my issue/suggestion.\r\n\r\n*Place an X inside the bracket to confirm*\r\n- [x] I confirm.\r\n\r\n---\r\nFrom an outsider perspective with some experience with the Google style code,\r\nI observe some common non-Google style conventions in the Kovri code.\r\n(always breaking function parameters and arguments,\r\n no more than one statement on one line,\r\n unaligned multi-argument breaks,\r\n one-space indentation in class declaration,\r\n filenames and extensions (cpp vs. cc), etc.)\r\n\r\nSince the codebase in the style transition state,\r\nit is not clear which conventions are here to stay.\r\n\r\nIt would be nice to have the style differences clarified in the contributor documentation.\r\nIn addition, the clang-format [options](http://clang.llvm.org/docs/ClangFormatStyleOptions.html)\r\nneeds to be modified to leverage the automated tools for this tedious task."},"comment":{"url":"https://api.github.com/repos/monero-project/kovri/issues/comments/233104055","html_url":"https://github.com/monero-project/kovri/issues/238#issuecomment-233104055","issue_url":"https://api.github.com/repos/monero-project/kovri/issues/238","id":233104055,"user":{"login":"anonimal","id":12156341,"avatar_url":"https://avatars.githubusercontent.com/u/12156341?v=3","gravatar_id":"","url":"https://api.github.com/users/anonimal","html_url":"https://github.com/anonimal","followers_url":"https://api.github.com/users/anonimal/followers","following_url":"https://api.github.com/users/anonimal/following{/other_user}","gists_url":"https://api.github.com/users/anonimal/gists{/gist_id}","starred_url":"https://api.github.com/users/anonimal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anonimal/subscriptions","organizations_url":"https://api.github.com/users/anonimal/orgs","repos_url":"https://api.github.com/users/anonimal/repos","events_url":"https://api.github.com/users/anonimal/events{/privacy}","received_events_url":"https://api.github.com/users/anonimal/received_events","type":"User","site_admin":false},"created_at":"2016-07-16T02:40:43Z","updated_at":"2016-07-16T02:40:43Z","body":"When we started the project we decided to adhere to Google's style but only within reason since doing a complete guide refactor was not reasonable nor did we like certain conventions proposed by Google.\r\n\r\nMany of the differences you've mentioned appear to be covered in our [style guide](https://github.com/monero-project/kovri/blob/master/doc/STYLE.md) (also, IIRC, one-space ident for class declarations are caught by cpplint).\r\n\r\nIf you take a look at some of our newer code (like [here](https://github.com/EinMByte/kovri/pull/1) for example), you can get a feel for logic and consistency of style. There's not much to it actually but we do welcome any clang format options or uncrustify config if that makes things easier. \r\n\r\nWe also welcome any thoughts on how we can improve the [style guide's](https://github.com/monero-project/kovri/blob/master/doc/STYLE.md) language for consistency."}}
{"actor":{"display_login":"anonimal"}}