{"action":"created","issue":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/402","repository_url":"https://api.github.com/repos/greenplum-db/gpdb","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/402/labels{/name}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/402/comments","events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/402/events","html_url":"https://github.com/greenplum-db/gpdb/pull/402","id":134667976,"number":402,"title":"Couple of fixes","user":{"login":"ashwinstar","id":11396815,"avatar_url":"https://avatars.githubusercontent.com/u/11396815?v=3","gravatar_id":"","url":"https://api.github.com/users/ashwinstar","html_url":"https://github.com/ashwinstar","followers_url":"https://api.github.com/users/ashwinstar/followers","following_url":"https://api.github.com/users/ashwinstar/following{/other_user}","gists_url":"https://api.github.com/users/ashwinstar/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwinstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwinstar/subscriptions","organizations_url":"https://api.github.com/users/ashwinstar/orgs","repos_url":"https://api.github.com/users/ashwinstar/repos","events_url":"https://api.github.com/users/ashwinstar/events{/privacy}","received_events_url":"https://api.github.com/users/ashwinstar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-02-18T19:13:36Z","updated_at":"2016-02-18T21:31:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/402","html_url":"https://github.com/greenplum-db/gpdb/pull/402","diff_url":"https://github.com/greenplum-db/gpdb/pull/402.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/402.patch"},"body":"1] Found during code browsing, can avoid allocating separate memory for vpinfo, use just pointer. Not big of a problem but better to avoid.\r\n2] Coverity issue to include null terminator."},"comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments/185931234","html_url":"https://github.com/greenplum-db/gpdb/pull/402#issuecomment-185931234","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/402","id":185931234,"user":{"login":"ashwinstar","id":11396815,"avatar_url":"https://avatars.githubusercontent.com/u/11396815?v=3","gravatar_id":"","url":"https://api.github.com/users/ashwinstar","html_url":"https://github.com/ashwinstar","followers_url":"https://api.github.com/users/ashwinstar/followers","following_url":"https://api.github.com/users/ashwinstar/following{/other_user}","gists_url":"https://api.github.com/users/ashwinstar/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwinstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwinstar/subscriptions","organizations_url":"https://api.github.com/users/ashwinstar/orgs","repos_url":"https://api.github.com/users/ashwinstar/repos","events_url":"https://api.github.com/users/ashwinstar/events{/privacy}","received_events_url":"https://api.github.com/users/ashwinstar/received_events","type":"User","site_admin":false},"created_at":"2016-02-18T21:31:55Z","updated_at":"2016-02-18T21:31:55Z","body":"On Thu, Feb 18, 2016 at 11:49 AM, Heikki Linnakangas <\nnotifications@github.com> wrote:\n\n> On 18/02/16 21:41, Ashwin Agrawal wrote:\n> > On Thu, Feb 18, 2016 at 11:24 AM, Heikki Linnakangas <\n> > notifications@github.com> wrote:\n> >\n> >>\n> >>\n> >> On 18 February 2016 21:13:37 EET, Ashwin Agrawal <\n> notifications@github.com>\n> >> wrote:\n> >>> 2] Coverity issue to include null terminator.\n> >>\n> >> Is the fix for that a change in on-disk format? Was the byte guaranteed\n> to\n> >> be 0 before too?\n> >>\n> > Yes, it was guaranteed to be zero before due to memset.\n>\n> Ok, cool.\n>\n> > Plus, with 5.0 it doesn't matter as upgrade path will be different.\n>\n> Yeah, but would still be good to avoid unnecessary changes, just in case\n> we decide to write a binary upgrade tool in the future, or some\n> additional tools that peek into on-disk files. (This particular\n> difference would've been pretty inconsequential for such tools anyway,\n> though)\n\n\nAgree, but this file is more like clog, xlog, logs which shouldn't be\nincluded in binary diffs we are coding for upgrade.\nIts gets created if not present first time.\n"}}