{"action":"opened","number":19,"pull_request":{"url":"https://api.github.com/repos/mlenser/roll20/pulls/19","id":65170658,"html_url":"https://github.com/mlenser/roll20/pull/19","diff_url":"https://github.com/mlenser/roll20/pull/19.diff","patch_url":"https://github.com/mlenser/roll20/pull/19.patch","issue_url":"https://api.github.com/repos/mlenser/roll20/issues/19","number":19,"state":"open","locked":false,"title":"Changes to make JSON loading more friendly and robust.","user":{"login":"symposion","id":625085,"avatar_url":"https://avatars.githubusercontent.com/u/625085?v=3","gravatar_id":"","url":"https://api.github.com/users/symposion","html_url":"https://github.com/symposion","followers_url":"https://api.github.com/users/symposion/followers","following_url":"https://api.github.com/users/symposion/following{/other_user}","gists_url":"https://api.github.com/users/symposion/gists{/gist_id}","starred_url":"https://api.github.com/users/symposion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symposion/subscriptions","organizations_url":"https://api.github.com/users/symposion/orgs","repos_url":"https://api.github.com/users/symposion/repos","events_url":"https://api.github.com/users/symposion/events{/privacy}","received_events_url":"https://api.github.com/users/symposion/received_events","type":"User","site_admin":false},"body":"Hi Mark,\r\n\r\nSo I've done some reworking of my script to make JSON loading more robust and have made some minor tweaks to the JSON as a result. I now validate the loaded JSON against some of the same patterns that the text parser uses to check the MM text - I've found a few errors and inconsistencies in the JSON as a result. Additionally, the script now supports your patching system internally, so any JSON files with the patch property set will edit the existing spells in the same way you achieved through your gulp script. I've removed the patching code from the gulp file since it's not needed any more.\r\n\r\nI've also removed the fifthSpells/fifthMonsters variables now, and changed the gulp script to produce code to register the objects directly with the script.\r\n\r\nI'm hoping that this should be the last change to the layout - otherwise I think it will just be additive bits for FX etc.","created_at":"2016-04-04T16:06:32Z","updated_at":"2016-04-04T16:06:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mlenser/roll20/pulls/19/commits","review_comments_url":"https://api.github.com/repos/mlenser/roll20/pulls/19/comments","review_comment_url":"https://api.github.com/repos/mlenser/roll20/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mlenser/roll20/issues/19/comments","statuses_url":"https://api.github.com/repos/mlenser/roll20/statuses/1eb1b3fd24e6f846c00a93160ffc62c6c6d98528","head":{"label":"symposion:new-json-loading","ref":"new-json-loading","sha":"1eb1b3fd24e6f846c00a93160ffc62c6c6d98528","user":{"login":"symposion","id":625085,"avatar_url":"https://avatars.githubusercontent.com/u/625085?v=3","gravatar_id":"","url":"https://api.github.com/users/symposion","html_url":"https://github.com/symposion","followers_url":"https://api.github.com/users/symposion/followers","following_url":"https://api.github.com/users/symposion/following{/other_user}","gists_url":"https://api.github.com/users/symposion/gists{/gist_id}","starred_url":"https://api.github.com/users/symposion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symposion/subscriptions","organizations_url":"https://api.github.com/users/symposion/orgs","repos_url":"https://api.github.com/users/symposion/repos","events_url":"https://api.github.com/users/symposion/events{/privacy}","received_events_url":"https://api.github.com/users/symposion/received_events","type":"User","site_admin":false},"repo":{"id":54372183,"name":"roll20","full_name":"symposion/roll20","owner":{"login":"symposion","id":625085,"avatar_url":"https://avatars.githubusercontent.com/u/625085?v=3","gravatar_id":"","url":"https://api.github.com/users/symposion","html_url":"https://github.com/symposion","followers_url":"https://api.github.com/users/symposion/followers","following_url":"https://api.github.com/users/symposion/following{/other_user}","gists_url":"https://api.github.com/users/symposion/gists{/gist_id}","starred_url":"https://api.github.com/users/symposion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symposion/subscriptions","organizations_url":"https://api.github.com/users/symposion/orgs","repos_url":"https://api.github.com/users/symposion/repos","events_url":"https://api.github.com/users/symposion/events{/privacy}","received_events_url":"https://api.github.com/users/symposion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/symposion/roll20","description":"Scripts and other assorted things for roll20","fork":true,"url":"https://api.github.com/repos/symposion/roll20","forks_url":"https://api.github.com/repos/symposion/roll20/forks","keys_url":"https://api.github.com/repos/symposion/roll20/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symposion/roll20/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symposion/roll20/teams","hooks_url":"https://api.github.com/repos/symposion/roll20/hooks","issue_events_url":"https://api.github.com/repos/symposion/roll20/issues/events{/number}","events_url":"https://api.github.com/repos/symposion/roll20/events","assignees_url":"https://api.github.com/repos/symposion/roll20/assignees{/user}","branches_url":"https://api.github.com/repos/symposion/roll20/branches{/branch}","tags_url":"https://api.github.com/repos/symposion/roll20/tags","blobs_url":"https://api.github.com/repos/symposion/roll20/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symposion/roll20/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symposion/roll20/git/refs{/sha}","trees_url":"https://api.github.com/repos/symposion/roll20/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symposion/roll20/statuses/{sha}","languages_url":"https://api.github.com/repos/symposion/roll20/languages","stargazers_url":"https://api.github.com/repos/symposion/roll20/stargazers","contributors_url":"https://api.github.com/repos/symposion/roll20/contributors","subscribers_url":"https://api.github.com/repos/symposion/roll20/subscribers","subscription_url":"https://api.github.com/repos/symposion/roll20/subscription","commits_url":"https://api.github.com/repos/symposion/roll20/commits{/sha}","git_commits_url":"https://api.github.com/repos/symposion/roll20/git/commits{/sha}","comments_url":"https://api.github.com/repos/symposion/roll20/comments{/number}","issue_comment_url":"https://api.github.com/repos/symposion/roll20/issues/comments{/number}","contents_url":"https://api.github.com/repos/symposion/roll20/contents/{+path}","compare_url":"https://api.github.com/repos/symposion/roll20/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symposion/roll20/merges","archive_url":"https://api.github.com/repos/symposion/roll20/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symposion/roll20/downloads","issues_url":"https://api.github.com/repos/symposion/roll20/issues{/number}","pulls_url":"https://api.github.com/repos/symposion/roll20/pulls{/number}","milestones_url":"https://api.github.com/repos/symposion/roll20/milestones{/number}","notifications_url":"https://api.github.com/repos/symposion/roll20/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symposion/roll20/labels{/name}","releases_url":"https://api.github.com/repos/symposion/roll20/releases{/id}","deployments_url":"https://api.github.com/repos/symposion/roll20/deployments","created_at":"2016-03-21T08:34:57Z","updated_at":"2016-03-21T08:34:58Z","pushed_at":"2016-04-04T15:58:28Z","git_url":"git://github.com/symposion/roll20.git","ssh_url":"git@github.com:symposion/roll20.git","clone_url":"https://github.com/symposion/roll20.git","svn_url":"https://github.com/symposion/roll20","homepage":null,"size":3982,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mlenser:master","ref":"master","sha":"6b5491002a16ac9b8da0c50f2890e625d6b75226","user":{"login":"mlenser","id":235857,"avatar_url":"https://avatars.githubusercontent.com/u/235857?v=3","gravatar_id":"","url":"https://api.github.com/users/mlenser","html_url":"https://github.com/mlenser","followers_url":"https://api.github.com/users/mlenser/followers","following_url":"https://api.github.com/users/mlenser/following{/other_user}","gists_url":"https://api.github.com/users/mlenser/gists{/gist_id}","starred_url":"https://api.github.com/users/mlenser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlenser/subscriptions","organizations_url":"https://api.github.com/users/mlenser/orgs","repos_url":"https://api.github.com/users/mlenser/repos","events_url":"https://api.github.com/users/mlenser/events{/privacy}","received_events_url":"https://api.github.com/users/mlenser/received_events","type":"User","site_admin":false},"repo":{"id":33323278,"name":"roll20","full_name":"mlenser/roll20","owner":{"login":"mlenser","id":235857,"avatar_url":"https://avatars.githubusercontent.com/u/235857?v=3","gravatar_id":"","url":"https://api.github.com/users/mlenser","html_url":"https://github.com/mlenser","followers_url":"https://api.github.com/users/mlenser/followers","following_url":"https://api.github.com/users/mlenser/following{/other_user}","gists_url":"https://api.github.com/users/mlenser/gists{/gist_id}","starred_url":"https://api.github.com/users/mlenser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlenser/subscriptions","organizations_url":"https://api.github.com/users/mlenser/orgs","repos_url":"https://api.github.com/users/mlenser/repos","events_url":"https://api.github.com/users/mlenser/events{/privacy}","received_events_url":"https://api.github.com/users/mlenser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mlenser/roll20","description":"Scripts and other assorted things for roll20","fork":false,"url":"https://api.github.com/repos/mlenser/roll20","forks_url":"https://api.github.com/repos/mlenser/roll20/forks","keys_url":"https://api.github.com/repos/mlenser/roll20/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlenser/roll20/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlenser/roll20/teams","hooks_url":"https://api.github.com/repos/mlenser/roll20/hooks","issue_events_url":"https://api.github.com/repos/mlenser/roll20/issues/events{/number}","events_url":"https://api.github.com/repos/mlenser/roll20/events","assignees_url":"https://api.github.com/repos/mlenser/roll20/assignees{/user}","branches_url":"https://api.github.com/repos/mlenser/roll20/branches{/branch}","tags_url":"https://api.github.com/repos/mlenser/roll20/tags","blobs_url":"https://api.github.com/repos/mlenser/roll20/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlenser/roll20/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlenser/roll20/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlenser/roll20/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlenser/roll20/statuses/{sha}","languages_url":"https://api.github.com/repos/mlenser/roll20/languages","stargazers_url":"https://api.github.com/repos/mlenser/roll20/stargazers","contributors_url":"https://api.github.com/repos/mlenser/roll20/contributors","subscribers_url":"https://api.github.com/repos/mlenser/roll20/subscribers","subscription_url":"https://api.github.com/repos/mlenser/roll20/subscription","commits_url":"https://api.github.com/repos/mlenser/roll20/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlenser/roll20/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlenser/roll20/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlenser/roll20/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlenser/roll20/contents/{+path}","compare_url":"https://api.github.com/repos/mlenser/roll20/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlenser/roll20/merges","archive_url":"https://api.github.com/repos/mlenser/roll20/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlenser/roll20/downloads","issues_url":"https://api.github.com/repos/mlenser/roll20/issues{/number}","pulls_url":"https://api.github.com/repos/mlenser/roll20/pulls{/number}","milestones_url":"https://api.github.com/repos/mlenser/roll20/milestones{/number}","notifications_url":"https://api.github.com/repos/mlenser/roll20/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlenser/roll20/labels{/name}","releases_url":"https://api.github.com/repos/mlenser/roll20/releases{/id}","deployments_url":"https://api.github.com/repos/mlenser/roll20/deployments","created_at":"2015-04-02T17:52:10Z","updated_at":"2016-03-30T16:51:19Z","pushed_at":"2016-04-03T21:15:07Z","git_url":"git://github.com/mlenser/roll20.git","ssh_url":"git@github.com:mlenser/roll20.git","clone_url":"https://github.com/mlenser/roll20.git","svn_url":"https://github.com/mlenser/roll20","homepage":null,"size":3259,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":1,"forks":11,"open_issues":1,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mlenser/roll20/pulls/19"},"html":{"href":"https://github.com/mlenser/roll20/pull/19"},"issue":{"href":"https://api.github.com/repos/mlenser/roll20/issues/19"},"comments":{"href":"https://api.github.com/repos/mlenser/roll20/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/mlenser/roll20/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/mlenser/roll20/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mlenser/roll20/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/mlenser/roll20/statuses/1eb1b3fd24e6f846c00a93160ffc62c6c6d98528"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":37543,"deletions":37549,"changed_files":14}}