{"action":"closed","number":4440,"pull_request":{"url":"https://api.github.com/repos/sequelize/sequelize/pulls/4440","id":44295795,"html_url":"https://github.com/sequelize/sequelize/pull/4440","diff_url":"https://github.com/sequelize/sequelize/pull/4440.diff","patch_url":"https://github.com/sequelize/sequelize/pull/4440.patch","issue_url":"https://api.github.com/repos/sequelize/sequelize/issues/4440","number":4440,"state":"closed","locked":false,"title":"always need to join data when hasJoin is true not matter what options…","user":{"login":"pentium100","id":27917,"avatar_url":"https://avatars.githubusercontent.com/u/27917?v=3","gravatar_id":"","url":"https://api.github.com/users/pentium100","html_url":"https://github.com/pentium100","followers_url":"https://api.github.com/users/pentium100/followers","following_url":"https://api.github.com/users/pentium100/following{/other_user}","gists_url":"https://api.github.com/users/pentium100/gists{/gist_id}","starred_url":"https://api.github.com/users/pentium100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentium100/subscriptions","organizations_url":"https://api.github.com/users/pentium100/orgs","repos_url":"https://api.github.com/users/pentium100/repos","events_url":"https://api.github.com/users/pentium100/events{/privacy}","received_events_url":"https://api.github.com/users/pentium100/received_events","type":"User","site_admin":false},"body":"In handleSelectQuery , we always need to join data when hasJoin is true.\r\nnot matter the options.raw setting. ","created_at":"2015-09-06T05:07:57Z","updated_at":"2016-04-14T20:05:41Z","closed_at":"2016-04-14T20:05:41Z","merged_at":null,"merge_commit_sha":"7c9bcb188c13988c98e582239fd1b668990b3249","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sequelize/sequelize/pulls/4440/commits","review_comments_url":"https://api.github.com/repos/sequelize/sequelize/pulls/4440/comments","review_comment_url":"https://api.github.com/repos/sequelize/sequelize/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sequelize/sequelize/issues/4440/comments","statuses_url":"https://api.github.com/repos/sequelize/sequelize/statuses/54c2b7236645b67ba9c65f77796e86cfe8e30409","head":{"label":"pentium100:fix-query-options-raw","ref":"fix-query-options-raw","sha":"54c2b7236645b67ba9c65f77796e86cfe8e30409","user":{"login":"pentium100","id":27917,"avatar_url":"https://avatars.githubusercontent.com/u/27917?v=3","gravatar_id":"","url":"https://api.github.com/users/pentium100","html_url":"https://github.com/pentium100","followers_url":"https://api.github.com/users/pentium100/followers","following_url":"https://api.github.com/users/pentium100/following{/other_user}","gists_url":"https://api.github.com/users/pentium100/gists{/gist_id}","starred_url":"https://api.github.com/users/pentium100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentium100/subscriptions","organizations_url":"https://api.github.com/users/pentium100/orgs","repos_url":"https://api.github.com/users/pentium100/repos","events_url":"https://api.github.com/users/pentium100/events{/privacy}","received_events_url":"https://api.github.com/users/pentium100/received_events","type":"User","site_admin":false},"repo":{"id":41986619,"name":"sequelize","full_name":"pentium100/sequelize","owner":{"login":"pentium100","id":27917,"avatar_url":"https://avatars.githubusercontent.com/u/27917?v=3","gravatar_id":"","url":"https://api.github.com/users/pentium100","html_url":"https://github.com/pentium100","followers_url":"https://api.github.com/users/pentium100/followers","following_url":"https://api.github.com/users/pentium100/following{/other_user}","gists_url":"https://api.github.com/users/pentium100/gists{/gist_id}","starred_url":"https://api.github.com/users/pentium100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentium100/subscriptions","organizations_url":"https://api.github.com/users/pentium100/orgs","repos_url":"https://api.github.com/users/pentium100/repos","events_url":"https://api.github.com/users/pentium100/events{/privacy}","received_events_url":"https://api.github.com/users/pentium100/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pentium100/sequelize","description":"Sequelize is an easy-to-use multi sql dialect ORM for Node.js & io.js. It currently supports MySQL, MariaDB, SQLite, PostgreSQL and MSSQL.","fork":true,"url":"https://api.github.com/repos/pentium100/sequelize","forks_url":"https://api.github.com/repos/pentium100/sequelize/forks","keys_url":"https://api.github.com/repos/pentium100/sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pentium100/sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pentium100/sequelize/teams","hooks_url":"https://api.github.com/repos/pentium100/sequelize/hooks","issue_events_url":"https://api.github.com/repos/pentium100/sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/pentium100/sequelize/events","assignees_url":"https://api.github.com/repos/pentium100/sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/pentium100/sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/pentium100/sequelize/tags","blobs_url":"https://api.github.com/repos/pentium100/sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pentium100/sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pentium100/sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/pentium100/sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pentium100/sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/pentium100/sequelize/languages","stargazers_url":"https://api.github.com/repos/pentium100/sequelize/stargazers","contributors_url":"https://api.github.com/repos/pentium100/sequelize/contributors","subscribers_url":"https://api.github.com/repos/pentium100/sequelize/subscribers","subscription_url":"https://api.github.com/repos/pentium100/sequelize/subscription","commits_url":"https://api.github.com/repos/pentium100/sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/pentium100/sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/pentium100/sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/pentium100/sequelize/issues/comments{/number}","contents_url":"https://api.github.com/repos/pentium100/sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/pentium100/sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pentium100/sequelize/merges","archive_url":"https://api.github.com/repos/pentium100/sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pentium100/sequelize/downloads","issues_url":"https://api.github.com/repos/pentium100/sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/pentium100/sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/pentium100/sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/pentium100/sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pentium100/sequelize/labels{/name}","releases_url":"https://api.github.com/repos/pentium100/sequelize/releases{/id}","deployments_url":"https://api.github.com/repos/pentium100/sequelize/deployments","created_at":"2015-09-06T04:13:58Z","updated_at":"2015-09-06T04:14:00Z","pushed_at":"2015-09-06T05:05:07Z","git_url":"git://github.com/pentium100/sequelize.git","ssh_url":"git@github.com:pentium100/sequelize.git","clone_url":"https://github.com/pentium100/sequelize.git","svn_url":"https://github.com/pentium100/sequelize","homepage":"http://sequelizejs.com","size":15578,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sequelize:master","ref":"master","sha":"b8e0f378833acd445515f028f131a0be2930adc6","user":{"login":"sequelize","id":3591786,"avatar_url":"https://avatars.githubusercontent.com/u/3591786?v=3","gravatar_id":"","url":"https://api.github.com/users/sequelize","html_url":"https://github.com/sequelize","followers_url":"https://api.github.com/users/sequelize/followers","following_url":"https://api.github.com/users/sequelize/following{/other_user}","gists_url":"https://api.github.com/users/sequelize/gists{/gist_id}","starred_url":"https://api.github.com/users/sequelize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequelize/subscriptions","organizations_url":"https://api.github.com/users/sequelize/orgs","repos_url":"https://api.github.com/users/sequelize/repos","events_url":"https://api.github.com/users/sequelize/events{/privacy}","received_events_url":"https://api.github.com/users/sequelize/received_events","type":"Organization","site_admin":false},"repo":{"id":790359,"name":"sequelize","full_name":"sequelize/sequelize","owner":{"login":"sequelize","id":3591786,"avatar_url":"https://avatars.githubusercontent.com/u/3591786?v=3","gravatar_id":"","url":"https://api.github.com/users/sequelize","html_url":"https://github.com/sequelize","followers_url":"https://api.github.com/users/sequelize/followers","following_url":"https://api.github.com/users/sequelize/following{/other_user}","gists_url":"https://api.github.com/users/sequelize/gists{/gist_id}","starred_url":"https://api.github.com/users/sequelize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequelize/subscriptions","organizations_url":"https://api.github.com/users/sequelize/orgs","repos_url":"https://api.github.com/users/sequelize/repos","events_url":"https://api.github.com/users/sequelize/events{/privacy}","received_events_url":"https://api.github.com/users/sequelize/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sequelize/sequelize","description":"Sequelize is an easy-to-use multi sql dialect ORM for Node.js & io.js. It currently supports MySQL, MariaDB, SQLite, PostgreSQL and MSSQL.","fork":false,"url":"https://api.github.com/repos/sequelize/sequelize","forks_url":"https://api.github.com/repos/sequelize/sequelize/forks","keys_url":"https://api.github.com/repos/sequelize/sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sequelize/sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sequelize/sequelize/teams","hooks_url":"https://api.github.com/repos/sequelize/sequelize/hooks","issue_events_url":"https://api.github.com/repos/sequelize/sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/sequelize/sequelize/events","assignees_url":"https://api.github.com/repos/sequelize/sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/sequelize/sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/sequelize/sequelize/tags","blobs_url":"https://api.github.com/repos/sequelize/sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sequelize/sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sequelize/sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/sequelize/sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sequelize/sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/sequelize/sequelize/languages","stargazers_url":"https://api.github.com/repos/sequelize/sequelize/stargazers","contributors_url":"https://api.github.com/repos/sequelize/sequelize/contributors","subscribers_url":"https://api.github.com/repos/sequelize/sequelize/subscribers","subscription_url":"https://api.github.com/repos/sequelize/sequelize/subscription","commits_url":"https://api.github.com/repos/sequelize/sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/sequelize/sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/sequelize/sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/sequelize/sequelize/issues/comments{/number}","contents_url":"https://api.github.com/repos/sequelize/sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/sequelize/sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sequelize/sequelize/merges","archive_url":"https://api.github.com/repos/sequelize/sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sequelize/sequelize/downloads","issues_url":"https://api.github.com/repos/sequelize/sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/sequelize/sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/sequelize/sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/sequelize/sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sequelize/sequelize/labels{/name}","releases_url":"https://api.github.com/repos/sequelize/sequelize/releases{/id}","deployments_url":"https://api.github.com/repos/sequelize/sequelize/deployments","created_at":"2010-07-22T07:11:11Z","updated_at":"2016-04-14T17:28:46Z","pushed_at":"2016-04-14T19:50:58Z","git_url":"git://github.com/sequelize/sequelize.git","ssh_url":"git@github.com:sequelize/sequelize.git","clone_url":"https://github.com/sequelize/sequelize.git","svn_url":"https://github.com/sequelize/sequelize","homepage":"http://sequelizejs.com","size":53277,"stargazers_count":6244,"watchers_count":6244,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1321,"mirror_url":null,"open_issues_count":702,"forks":1321,"open_issues":702,"watchers":6244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/4440"},"html":{"href":"https://github.com/sequelize/sequelize/pull/4440"},"issue":{"href":"https://api.github.com/repos/sequelize/sequelize/issues/4440"},"comments":{"href":"https://api.github.com/repos/sequelize/sequelize/issues/4440/comments"},"review_comments":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/4440/comments"},"review_comment":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/4440/commits"},"statuses":{"href":"https://api.github.com/repos/sequelize/sequelize/statuses/54c2b7236645b67ba9c65f77796e86cfe8e30409"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":10,"deletions":8,"changed_files":1}}