{"action":"created","comment":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments/48843503","id":48843503,"diff_hunk":"@@ -257,7 +257,7 @@ var StudyViewProxy = (function() {\n                 }else {\n                     var cnaLength = obtainDataObject.arr.length;\n                     for(var i = 0; i < cnaLength; i++) {\n-                        if(obtainDataObject.arr[i]['MUTATION_COUNT']) {\n+                        if(!_.isUndefined(obtainDataObject.arr[i]['MUTATION_COUNT'])) {","path":"portal/src/main/webapp/js/src/study-view/data/StudyViewProxy.js","position":14,"original_position":14,"commit_id":"ca215a1197cf728da1154e236e0aec93d3d07c3b","original_commit_id":"ca215a1197cf728da1154e236e0aec93d3d07c3b","user":{"login":"pieterlukasse","id":2900303,"avatar_url":"https://avatars.githubusercontent.com/u/2900303?v=3","gravatar_id":"","url":"https://api.github.com/users/pieterlukasse","html_url":"https://github.com/pieterlukasse","followers_url":"https://api.github.com/users/pieterlukasse/followers","following_url":"https://api.github.com/users/pieterlukasse/following{/other_user}","gists_url":"https://api.github.com/users/pieterlukasse/gists{/gist_id}","starred_url":"https://api.github.com/users/pieterlukasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pieterlukasse/subscriptions","organizations_url":"https://api.github.com/users/pieterlukasse/orgs","repos_url":"https://api.github.com/users/pieterlukasse/repos","events_url":"https://api.github.com/users/pieterlukasse/events{/privacy}","received_events_url":"https://api.github.com/users/pieterlukasse/received_events","type":"User","site_admin":false},"body":"In line 258, should variable be called cnaLength or something like mutationLength? \r\n\r\nI would also advocate for keeping the same style in referring to attributes, so either ['MUTATION_COUNT'] OR .MUTATION_COUNT. Now you use both mixed up in this and next line.","created_at":"2016-01-05T13:20:32Z","updated_at":"2016-01-05T13:20:32Z","html_url":"https://github.com/cBioPortal/cbioportal/pull/706#discussion_r48843503","pull_request_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/706","_links":{"self":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments/48843503"},"html":{"href":"https://github.com/cBioPortal/cbioportal/pull/706#discussion_r48843503"},"pull_request":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/706"}}},"pull_request":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/706","id":55019801,"html_url":"https://github.com/cBioPortal/cbioportal/pull/706","diff_url":"https://github.com/cBioPortal/cbioportal/pull/706.diff","patch_url":"https://github.com/cBioPortal/cbioportal/pull/706.patch","issue_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/706","number":706,"state":"open","locked":false,"title":"Keep code style consistent - related to #639","user":{"login":"zhx828","id":5400599,"avatar_url":"https://avatars.githubusercontent.com/u/5400599?v=3","gravatar_id":"","url":"https://api.github.com/users/zhx828","html_url":"https://github.com/zhx828","followers_url":"https://api.github.com/users/zhx828/followers","following_url":"https://api.github.com/users/zhx828/following{/other_user}","gists_url":"https://api.github.com/users/zhx828/gists{/gist_id}","starred_url":"https://api.github.com/users/zhx828/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhx828/subscriptions","organizations_url":"https://api.github.com/users/zhx828/orgs","repos_url":"https://api.github.com/users/zhx828/repos","events_url":"https://api.github.com/users/zhx828/events{/privacy}","received_events_url":"https://api.github.com/users/zhx828/received_events","type":"User","site_admin":false},"body":"To keep consistency, use underscore in if condition. @pieterlukasse could you review?","created_at":"2016-01-04T20:44:36Z","updated_at":"2016-01-05T13:20:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8011acad2e769f52f004c3e77604f1bfd4b56f53","assignee":{"login":"aderidder","id":9414840,"avatar_url":"https://avatars.githubusercontent.com/u/9414840?v=3","gravatar_id":"","url":"https://api.github.com/users/aderidder","html_url":"https://github.com/aderidder","followers_url":"https://api.github.com/users/aderidder/followers","following_url":"https://api.github.com/users/aderidder/following{/other_user}","gists_url":"https://api.github.com/users/aderidder/gists{/gist_id}","starred_url":"https://api.github.com/users/aderidder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aderidder/subscriptions","organizations_url":"https://api.github.com/users/aderidder/orgs","repos_url":"https://api.github.com/users/aderidder/repos","events_url":"https://api.github.com/users/aderidder/events{/privacy}","received_events_url":"https://api.github.com/users/aderidder/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/milestones/8","html_url":"https://github.com/cBioPortal/cbioportal/milestones/1.0.2","labels_url":"https://api.github.com/repos/cBioPortal/cbioportal/milestones/8/labels","id":1476126,"number":8,"title":"1.0.2","description":"","creator":{"login":"jjgao","id":840895,"avatar_url":"https://avatars.githubusercontent.com/u/840895?v=3","gravatar_id":"","url":"https://api.github.com/users/jjgao","html_url":"https://github.com/jjgao","followers_url":"https://api.github.com/users/jjgao/followers","following_url":"https://api.github.com/users/jjgao/following{/other_user}","gists_url":"https://api.github.com/users/jjgao/gists{/gist_id}","starred_url":"https://api.github.com/users/jjgao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjgao/subscriptions","organizations_url":"https://api.github.com/users/jjgao/orgs","repos_url":"https://api.github.com/users/jjgao/repos","events_url":"https://api.github.com/users/jjgao/events{/privacy}","received_events_url":"https://api.github.com/users/jjgao/received_events","type":"User","site_admin":false},"open_issues":34,"closed_issues":0,"state":"open","created_at":"2015-12-28T17:22:07Z","updated_at":"2016-01-04T20:44:36Z","due_on":"2016-01-12T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/706/commits","review_comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/706/comments","review_comment_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/706/comments","statuses_url":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/ca215a1197cf728da1154e236e0aec93d3d07c3b","head":{"label":"zhx828:modify_560","ref":"modify_560","sha":"ca215a1197cf728da1154e236e0aec93d3d07c3b","user":{"login":"zhx828","id":5400599,"avatar_url":"https://avatars.githubusercontent.com/u/5400599?v=3","gravatar_id":"","url":"https://api.github.com/users/zhx828","html_url":"https://github.com/zhx828","followers_url":"https://api.github.com/users/zhx828/followers","following_url":"https://api.github.com/users/zhx828/following{/other_user}","gists_url":"https://api.github.com/users/zhx828/gists{/gist_id}","starred_url":"https://api.github.com/users/zhx828/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhx828/subscriptions","organizations_url":"https://api.github.com/users/zhx828/orgs","repos_url":"https://api.github.com/users/zhx828/repos","events_url":"https://api.github.com/users/zhx828/events{/privacy}","received_events_url":"https://api.github.com/users/zhx828/received_events","type":"User","site_admin":false},"repo":{"id":38316203,"name":"cbioportal","full_name":"zhx828/cbioportal","owner":{"login":"zhx828","id":5400599,"avatar_url":"https://avatars.githubusercontent.com/u/5400599?v=3","gravatar_id":"","url":"https://api.github.com/users/zhx828","html_url":"https://github.com/zhx828","followers_url":"https://api.github.com/users/zhx828/followers","following_url":"https://api.github.com/users/zhx828/following{/other_user}","gists_url":"https://api.github.com/users/zhx828/gists{/gist_id}","starred_url":"https://api.github.com/users/zhx828/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhx828/subscriptions","organizations_url":"https://api.github.com/users/zhx828/orgs","repos_url":"https://api.github.com/users/zhx828/repos","events_url":"https://api.github.com/users/zhx828/events{/privacy}","received_events_url":"https://api.github.com/users/zhx828/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhx828/cbioportal","description":"","fork":true,"url":"https://api.github.com/repos/zhx828/cbioportal","forks_url":"https://api.github.com/repos/zhx828/cbioportal/forks","keys_url":"https://api.github.com/repos/zhx828/cbioportal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhx828/cbioportal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhx828/cbioportal/teams","hooks_url":"https://api.github.com/repos/zhx828/cbioportal/hooks","issue_events_url":"https://api.github.com/repos/zhx828/cbioportal/issues/events{/number}","events_url":"https://api.github.com/repos/zhx828/cbioportal/events","assignees_url":"https://api.github.com/repos/zhx828/cbioportal/assignees{/user}","branches_url":"https://api.github.com/repos/zhx828/cbioportal/branches{/branch}","tags_url":"https://api.github.com/repos/zhx828/cbioportal/tags","blobs_url":"https://api.github.com/repos/zhx828/cbioportal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhx828/cbioportal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhx828/cbioportal/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhx828/cbioportal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhx828/cbioportal/statuses/{sha}","languages_url":"https://api.github.com/repos/zhx828/cbioportal/languages","stargazers_url":"https://api.github.com/repos/zhx828/cbioportal/stargazers","contributors_url":"https://api.github.com/repos/zhx828/cbioportal/contributors","subscribers_url":"https://api.github.com/repos/zhx828/cbioportal/subscribers","subscription_url":"https://api.github.com/repos/zhx828/cbioportal/subscription","commits_url":"https://api.github.com/repos/zhx828/cbioportal/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhx828/cbioportal/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhx828/cbioportal/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhx828/cbioportal/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhx828/cbioportal/contents/{+path}","compare_url":"https://api.github.com/repos/zhx828/cbioportal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhx828/cbioportal/merges","archive_url":"https://api.github.com/repos/zhx828/cbioportal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhx828/cbioportal/downloads","issues_url":"https://api.github.com/repos/zhx828/cbioportal/issues{/number}","pulls_url":"https://api.github.com/repos/zhx828/cbioportal/pulls{/number}","milestones_url":"https://api.github.com/repos/zhx828/cbioportal/milestones{/number}","notifications_url":"https://api.github.com/repos/zhx828/cbioportal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhx828/cbioportal/labels{/name}","releases_url":"https://api.github.com/repos/zhx828/cbioportal/releases{/id}","created_at":"2015-06-30T15:09:09Z","updated_at":"2015-06-30T15:09:16Z","pushed_at":"2016-01-04T23:44:10Z","git_url":"git://github.com/zhx828/cbioportal.git","ssh_url":"git@github.com:zhx828/cbioportal.git","clone_url":"https://github.com/zhx828/cbioportal.git","svn_url":"https://github.com/zhx828/cbioportal","homepage":null,"size":148614,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cBioPortal:hotfix","ref":"hotfix","sha":"f4910ebaa899ae48c46d8a493b4d03b6759ea3bd","user":{"login":"cBioPortal","id":9876251,"avatar_url":"https://avatars.githubusercontent.com/u/9876251?v=3","gravatar_id":"","url":"https://api.github.com/users/cBioPortal","html_url":"https://github.com/cBioPortal","followers_url":"https://api.github.com/users/cBioPortal/followers","following_url":"https://api.github.com/users/cBioPortal/following{/other_user}","gists_url":"https://api.github.com/users/cBioPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/cBioPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cBioPortal/subscriptions","organizations_url":"https://api.github.com/users/cBioPortal/orgs","repos_url":"https://api.github.com/users/cBioPortal/repos","events_url":"https://api.github.com/users/cBioPortal/events{/privacy}","received_events_url":"https://api.github.com/users/cBioPortal/received_events","type":"Organization","site_admin":false},"repo":{"id":32481543,"name":"cbioportal","full_name":"cBioPortal/cbioportal","owner":{"login":"cBioPortal","id":9876251,"avatar_url":"https://avatars.githubusercontent.com/u/9876251?v=3","gravatar_id":"","url":"https://api.github.com/users/cBioPortal","html_url":"https://github.com/cBioPortal","followers_url":"https://api.github.com/users/cBioPortal/followers","following_url":"https://api.github.com/users/cBioPortal/following{/other_user}","gists_url":"https://api.github.com/users/cBioPortal/gists{/gist_id}","starred_url":"https://api.github.com/users/cBioPortal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cBioPortal/subscriptions","organizations_url":"https://api.github.com/users/cBioPortal/orgs","repos_url":"https://api.github.com/users/cBioPortal/repos","events_url":"https://api.github.com/users/cBioPortal/events{/privacy}","received_events_url":"https://api.github.com/users/cBioPortal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cBioPortal/cbioportal","description":"","fork":false,"url":"https://api.github.com/repos/cBioPortal/cbioportal","forks_url":"https://api.github.com/repos/cBioPortal/cbioportal/forks","keys_url":"https://api.github.com/repos/cBioPortal/cbioportal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cBioPortal/cbioportal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cBioPortal/cbioportal/teams","hooks_url":"https://api.github.com/repos/cBioPortal/cbioportal/hooks","issue_events_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/events{/number}","events_url":"https://api.github.com/repos/cBioPortal/cbioportal/events","assignees_url":"https://api.github.com/repos/cBioPortal/cbioportal/assignees{/user}","branches_url":"https://api.github.com/repos/cBioPortal/cbioportal/branches{/branch}","tags_url":"https://api.github.com/repos/cBioPortal/cbioportal/tags","blobs_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/refs{/sha}","trees_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/{sha}","languages_url":"https://api.github.com/repos/cBioPortal/cbioportal/languages","stargazers_url":"https://api.github.com/repos/cBioPortal/cbioportal/stargazers","contributors_url":"https://api.github.com/repos/cBioPortal/cbioportal/contributors","subscribers_url":"https://api.github.com/repos/cBioPortal/cbioportal/subscribers","subscription_url":"https://api.github.com/repos/cBioPortal/cbioportal/subscription","commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/commits{/sha}","git_commits_url":"https://api.github.com/repos/cBioPortal/cbioportal/git/commits{/sha}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/comments{/number}","issue_comment_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/comments{/number}","contents_url":"https://api.github.com/repos/cBioPortal/cbioportal/contents/{+path}","compare_url":"https://api.github.com/repos/cBioPortal/cbioportal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cBioPortal/cbioportal/merges","archive_url":"https://api.github.com/repos/cBioPortal/cbioportal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cBioPortal/cbioportal/downloads","issues_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues{/number}","pulls_url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls{/number}","milestones_url":"https://api.github.com/repos/cBioPortal/cbioportal/milestones{/number}","notifications_url":"https://api.github.com/repos/cBioPortal/cbioportal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cBioPortal/cbioportal/labels{/name}","releases_url":"https://api.github.com/repos/cBioPortal/cbioportal/releases{/id}","created_at":"2015-03-18T20:09:09Z","updated_at":"2015-12-04T10:47:25Z","pushed_at":"2016-01-05T11:57:09Z","git_url":"git://github.com/cBioPortal/cbioportal.git","ssh_url":"git@github.com:cBioPortal/cbioportal.git","clone_url":"https://github.com/cBioPortal/cbioportal.git","svn_url":"https://github.com/cBioPortal/cbioportal","homepage":null,"size":172536,"stargazers_count":36,"watchers_count":36,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":46,"mirror_url":null,"open_issues_count":130,"forks":46,"open_issues":130,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/706"},"html":{"href":"https://github.com/cBioPortal/cbioportal/pull/706"},"issue":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/issues/706"},"comments":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/issues/706/comments"},"review_comments":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/706/comments"},"review_comment":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/706/commits"},"statuses":{"href":"https://api.github.com/repos/cBioPortal/cbioportal/statuses/ca215a1197cf728da1154e236e0aec93d3d07c3b"}}}}