{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/SocketRocket/issues/429","repository_url":"https://api.github.com/repos/facebook/SocketRocket","labels_url":"https://api.github.com/repos/facebook/SocketRocket/issues/429/labels{/name}","comments_url":"https://api.github.com/repos/facebook/SocketRocket/issues/429/comments","events_url":"https://api.github.com/repos/facebook/SocketRocket/issues/429/events","html_url":"https://github.com/facebook/SocketRocket/pull/429","id":162965014,"number":429,"title":"Pluggable, more flexible, security policies.","user":{"login":"michaelkirk","id":217057,"avatar_url":"https://avatars.githubusercontent.com/u/217057?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelkirk","html_url":"https://github.com/michaelkirk","followers_url":"https://api.github.com/users/michaelkirk/followers","following_url":"https://api.github.com/users/michaelkirk/following{/other_user}","gists_url":"https://api.github.com/users/michaelkirk/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelkirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelkirk/subscriptions","organizations_url":"https://api.github.com/users/michaelkirk/orgs","repos_url":"https://api.github.com/users/michaelkirk/repos","events_url":"https://api.github.com/users/michaelkirk/events{/privacy}","received_events_url":"https://api.github.com/users/michaelkirk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/SocketRocket/labels/CLA%20Signed","name":"CLA Signed","color":"ededed"},{"url":"https://api.github.com/repos/facebook/SocketRocket/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"nlutsenko","id":606991,"avatar_url":"https://avatars.githubusercontent.com/u/606991?v=3","gravatar_id":"","url":"https://api.github.com/users/nlutsenko","html_url":"https://github.com/nlutsenko","followers_url":"https://api.github.com/users/nlutsenko/followers","following_url":"https://api.github.com/users/nlutsenko/following{/other_user}","gists_url":"https://api.github.com/users/nlutsenko/gists{/gist_id}","starred_url":"https://api.github.com/users/nlutsenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlutsenko/subscriptions","organizations_url":"https://api.github.com/users/nlutsenko/orgs","repos_url":"https://api.github.com/users/nlutsenko/repos","events_url":"https://api.github.com/users/nlutsenko/events{/privacy}","received_events_url":"https://api.github.com/users/nlutsenko/received_events","type":"User","site_admin":false},"assignees":[{"login":"nlutsenko","id":606991,"avatar_url":"https://avatars.githubusercontent.com/u/606991?v=3","gravatar_id":"","url":"https://api.github.com/users/nlutsenko","html_url":"https://github.com/nlutsenko","followers_url":"https://api.github.com/users/nlutsenko/followers","following_url":"https://api.github.com/users/nlutsenko/following{/other_user}","gists_url":"https://api.github.com/users/nlutsenko/gists{/gist_id}","starred_url":"https://api.github.com/users/nlutsenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlutsenko/subscriptions","organizations_url":"https://api.github.com/users/nlutsenko/orgs","repos_url":"https://api.github.com/users/nlutsenko/repos","events_url":"https://api.github.com/users/nlutsenko/events{/privacy}","received_events_url":"https://api.github.com/users/nlutsenko/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2016-06-29T16:05:08Z","updated_at":"2016-06-30T21:28:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/SocketRocket/pulls/429","html_url":"https://github.com/facebook/SocketRocket/pull/429","diff_url":"https://github.com/facebook/SocketRocket/pull/429.diff","patch_url":"https://github.com/facebook/SocketRocket/pull/429.patch"},"body":"### Motiviation\r\n\r\nExtract @fredericjacobs' CertificateVerifier concept with @nlutsenko's\r\nSRSecurityOptions into a pluggable SRSecurityPolicy protocol\r\n\r\nThis retains existing SSL configuration code paths, while allowing users\r\nmore flexibility to specify their own security policy. It's intended\r\nthat you're able to subclass an `AFSecurityPolicy` that conforms to the\r\n`<SRSecurityPolicy>` protocol to share policy between websocket and\r\nconventional requests.\r\n\r\nInspired by original \"Require TLS 1.2 & enable pinning\" pull request by\r\nFrederic Jacobs (@fredericjacobs) at: https://github.com/facebook/SocketRocket/pull/274/files\r\n\r\n### TODO\r\n\r\nThere are a couple things in particular that were kind of quick hacks, but wanted to get some feedback on the approach:\r\n\r\n- [ ] Testing\r\n- [X] I added a synchronized block in didConnect. Maybe we can refactor so this isn't reached at so many different points\r\n- [x] Should SecurityPolicyBuilder be public?\r\n- [X] Are you OK with defaulting to TLS 1.2 *only*?\r\n- [X] ~~Implement no-encryption debug~~\r\n"},"comment":{"url":"https://api.github.com/repos/facebook/SocketRocket/issues/comments/229794270","html_url":"https://github.com/facebook/SocketRocket/pull/429#issuecomment-229794270","issue_url":"https://api.github.com/repos/facebook/SocketRocket/issues/429","id":229794270,"user":{"login":"nlutsenko","id":606991,"avatar_url":"https://avatars.githubusercontent.com/u/606991?v=3","gravatar_id":"","url":"https://api.github.com/users/nlutsenko","html_url":"https://github.com/nlutsenko","followers_url":"https://api.github.com/users/nlutsenko/followers","following_url":"https://api.github.com/users/nlutsenko/following{/other_user}","gists_url":"https://api.github.com/users/nlutsenko/gists{/gist_id}","starred_url":"https://api.github.com/users/nlutsenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlutsenko/subscriptions","organizations_url":"https://api.github.com/users/nlutsenko/orgs","repos_url":"https://api.github.com/users/nlutsenko/repos","events_url":"https://api.github.com/users/nlutsenko/events{/privacy}","received_events_url":"https://api.github.com/users/nlutsenko/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T21:28:25Z","updated_at":"2016-06-30T21:28:25Z","body":"A single question about nullability there... I suspect you are getting a warning there?"}}
{"actor":{"display_login":"nlutsenko"}}