{"push_id":1208076077,"size":15,"distinct_size":15,"ref":"refs/heads/isaac-source","head":"bfd5ba5e544bd290c3ee42f2f15b6ad6403c96c2","before":"250527046785cab409c055fe957114ea51421824","commits":[{"sha":"9e58a39794fce99954f17451aa04fa8151d0e698","author":{"name":"Marek Cirkos","email":"6213002287e51e2d71bd010705b02a7de0a945e7@fb.com"},"message":"Improved screenshot test\n\nSummary: Improved tests by Decoding data and checking if contains valid image.\n\nReviewed By: nqmtuan\n\nDifferential Revision: D3528336\n\nfbshipit-source-id: f22e7293c784522f86a87c91b2e4574e58fa90e9","distinct":true,"url":"https://api.github.com/repos/imurchie/WebDriverAgent/commits/9e58a39794fce99954f17451aa04fa8151d0e698"},{"sha":"6e15fe661493df123ca01fc72782a02b23268c5b","author":{"name":"Marek Cirkos","email":"6213002287e51e2d71bd010705b02a7de0a945e7@fb.com"},"message":"Fix typing for Xcode beta 2\n\nSummary: Apple killed API we where using so switching to antoher one.\n\nReviewed By: lawrencelomax\n\nDifferential Revision: D3534209\n\nfbshipit-source-id: c8d70cab7d222a0bd2503a6a6f7c2bb4eb60efd0","distinct":true,"url":"https://api.github.com/repos/imurchie/WebDriverAgent/commits/6e15fe661493df123ca01fc72782a02b23268c5b"},{"sha":"6816e09583c46655e7b7650df84641c64b2b5fdf","author":{"name":"Marek Cirkos","email":"6213002287e51e2d71bd010705b02a7de0a945e7@fb.com"},"message":"Add missing Nullability annotations\n\nSummary: They will help us test our assumptions with analyser\n\nReviewed By: lawrencelomax\n\nDifferential Revision: D3534461\n\nfbshipit-source-id: f20f5d5fef9fb016ae8bc1e4781273aa0aeae9a5","distinct":true,"url":"https://api.github.com/repos/imurchie/WebDriverAgent/commits/6816e09583c46655e7b7650df84641c64b2b5fdf"},{"sha":"2ed10a77cea79c99056554224a5ac4a9d59e3150","author":{"name":"Marek Cirkos","email":"6213002287e51e2d71bd010705b02a7de0a945e7@fb.com"},"message":"Fix fb_placeApplicationProxy\n\nSummary:\nIt is rare, but possible that `currentProcess` is `nil` when we try to wrap it in to proxy object and gets set later.\nChanged approach to obeserve any `currentProcess` changes and wrap it then. We ignore wrapping `nil` and already wrapped objects.\n\nReviewed By: lawrencelomax\n\nDifferential Revision: D3534296\n\nfbshipit-source-id: c677f57d17bc9897fb38891379b82ea6a6157d69","distinct":true,"url":"https://api.github.com/repos/imurchie/WebDriverAgent/commits/2ed10a77cea79c99056554224a5ac4a9d59e3150"},{"sha":"9a488a2f86333d9f4e7619109e6f0e838948fe5c","author":{"name":"Marek Cirkos","email":"6213002287e51e2d71bd010705b02a7de0a945e7@fb.com"},"message":"Added FBConfiguration tests\n\nSummary: Added some basic FBConfiguration tests\n\nReviewed By: lawrencelomax\n\nDifferential Revision: D3542400\n\nfbshipit-source-id: abd52ecd4c87b9871d41973795e223094327c17a","distinct":true,"url":"https://api.github.com/repos/imurchie/WebDriverAgent/commits/9a488a2f86333d9f4e7619109e6f0e838948fe5c"},{"sha":"b3b5c708d86d05aa96b772e458e105a463a6d49a","author":{"name":"陈恒捷","email":"7dfe302f094b319a337ba1872e3ff12290d8b37a@alibaba-inc.com"},"message":"Fix inspector's cannot render hightlight node on screenshot issue.\n\nSummary:\nI found that that there are codes for highlighting selected nodes on screenshot, but it do not work. After debug I found it's caused by using wrong attribute name in rect.\n\nAfter fix, elements of selected nodes in tree would be highlighted on screenshot like below:\n![image](https://cloud.githubusercontent.com/assets/2800797/16760994/d1971df8-4850-11e6-871a-acf5d1fb736d.png)\n\nAlso, I change the css a little bit to make the highlight more obvious.\nCloses https://github.com/facebook/WebDriverAgent/pull/201\n\nDifferential Revision: D3548744\n\nPulled By: marekcirkos\n\nfbshipit-source-id: 4fc631c7abfa351a2da7cdb8d5a91ffc76d83ca0","distinct":true,"url":"https://api.github.com/repos/imurchie/WebDriverAgent/commits/b3b5c708d86d05aa96b772e458e105a463a6d49a"},{"sha":"8e4f4a6c1661d39a55dae3463f087c5ab33a2028","author":{"name":"Marek Cirkos","email":"6213002287e51e2d71bd010705b02a7de0a945e7@fb.com"},"message":"Replace XCTouchGesture with XCSynthesizedEventRecord\n\nSummary: It looks like in Xcode beta-2 `XCTouchGesture` has been removed so replaced it with `XCSynthesizedEventRecord` that exists in both iOS versions.\n\nReviewed By: migchez\n\nDifferential Revision: D3534208\n\nfbshipit-source-id: edb912382de2c91f2f125458b5023562b980e467","distinct":true,"url":"https://api.github.com/repos/imurchie/WebDriverAgent/commits/8e4f4a6c1661d39a55dae3463f087c5ab33a2028"},{"sha":"9bfb4c6bc59c71a3a522af02418c99dae4ada6dd","author":{"name":"Marek Cirkos","email":"6213002287e51e2d71bd010705b02a7de0a945e7@fb.com"},"message":"Removing FBApplication as observer.\n\nSummary: Making sure that we remove ourself as observers when process is being terminated.\n\nReviewed By: lawrencelomax\n\nDifferential Revision: D3548848\n\nfbshipit-source-id: d16d95f56df36cb795e03d8a9a16ca2aea760e94","distinct":true,"url":"https://api.github.com/repos/imurchie/WebDriverAgent/commits/9bfb4c6bc59c71a3a522af02418c99dae4ada6dd"},{"sha":"32997f2afe934fa5fe405ac2659038d7e40d052e","author":{"name":"陈恒捷","email":"7dfe302f094b319a337ba1872e3ff12290d8b37a@alibaba-inc.com"},"message":"Fix inspector's cannot render highlight node on screenshot issue.\n\nSummary:\nIn inspector, it may highlight nodes that out of bound like below:\n\n![image](https://cloud.githubusercontent.com/assets/2800797/16828755/57bcf8ce-49c5-11e6-9aec-612becebbdb0.png)\n\nIt may confuse user since it's not on the screenshot.\n\nAfter fix, these nodes would never be highlighted.\nCloses https://github.com/facebook/WebDriverAgent/pull/202\n\nDifferential Revision: D3561466\n\nPulled By: marekcirkos\n\nfbshipit-source-id: 476022b2a0057081addafb73e1f4fe9376e4f94c","distinct":true,"url":"https://api.github.com/repos/imurchie/WebDriverAgent/commits/32997f2afe934fa5fe405ac2659038d7e40d052e"},{"sha":"6a1f18537240698f7b0fb97e4864a3d866025802","author":{"name":"Marek Cirkos","email":"6213002287e51e2d71bd010705b02a7de0a945e7@fb.com"},"message":"Caching Springbaord application\n\nSummary:\nWe fetch Springboard application everytime we want to query system alerts, which happens everytime we query elements, meaning pretty often.\nWe can save some time by caching it.\n\nReviewed By: lawrencelomax\n\nDifferential Revision: D3570135\n\nfbshipit-source-id: 30e3a8df2b5c4bb0f1364724b7c539293a05e314","distinct":true,"url":"https://api.github.com/repos/imurchie/WebDriverAgent/commits/6a1f18537240698f7b0fb97e4864a3d866025802"},{"sha":"040d99249a2ec65787c47a81a006737db9c053ad","author":{"name":"Marek Cirkos","email":"6213002287e51e2d71bd010705b02a7de0a945e7@fb.com"},"message":"Made XCUIApplicationHelperTests non-device specific\n\nSummary:\nDifferent devices (iPad vs iPhone) on different iOS version have different icons on second SpringBoard screen. Changed tests to go to first screen instead to validate icon detection, which is much more reliable cross devices and iOS versions.\nCloses https://github.com/facebook/WebDriverAgent/pull/206\n\nReviewed By: lawrencelomax\n\nDifferential Revision: D3577034\n\nPulled By: marekcirkos\n\nfbshipit-source-id: bb40b981e41a5cf723b9db30ccf7af210da3bd42","distinct":true,"url":"https://api.github.com/repos/imurchie/WebDriverAgent/commits/040d99249a2ec65787c47a81a006737db9c053ad"},{"sha":"dc418655ed6cef280af560e6b488c625ce53fef4","author":{"name":"Marek Cirkos","email":"6213002287e51e2d71bd010705b02a7de0a945e7@fb.com"},"message":"Made FBScrollingTests non-device specific\n\nSummary:\nDifferent devices have different screen sizes which means we can't relay on certain elements being visible after single scroll. Better approach would be checking visibility of 'starting' elements before and after scroll, plus check for visibility of any cell.\nCloses https://github.com/facebook/WebDriverAgent/pull/205\n\nReviewed By: lawrencelomax\n\nDifferential Revision: D3577038\n\nPulled By: marekcirkos\n\nfbshipit-source-id: 35c1baa396b052d89e18732093f6e758765ba43a","distinct":true,"url":"https://api.github.com/repos/imurchie/WebDriverAgent/commits/dc418655ed6cef280af560e6b488c625ce53fef4"},{"sha":"1e1aa822760a84b27741e13a1e41a4ce201e21ec","author":{"name":"Marek Cirkos","email":"6213002287e51e2d71bd010705b02a7de0a945e7@fb.com"},"message":"Added WDA as dependency when building unit tests\n\nSummary:\nCurrently we compile tested classes as part of UintTests bundle. It would be much better to build WDA as dependency and link it for testing.\n\nCloses https://github.com/facebook/WebDriverAgent/pull/208\n\nReviewed By: lawrencelomax\n\nDifferential Revision: D3577421\n\nPulled By: marekcirkos\n\nfbshipit-source-id: ff159fbfc7bf8c234c13f2fb00ca4150ee49c4f1","distinct":true,"url":"https://api.github.com/repos/imurchie/WebDriverAgent/commits/1e1aa822760a84b27741e13a1e41a4ce201e21ec"},{"sha":"c1f949bac3d8d5b3b4ae4d088648cbb27ab97d3c","author":{"name":"Marek Cirkos","email":"6213002287e51e2d71bd010705b02a7de0a945e7@fb.com"},"message":"Fixed Application handling\n\nSummary:\nApparently creating new `XCUIApplication` elements everytime we want to attach to process with given process id will break Apple's application monitoring system.\nThis is beacuse creating `XCUIApplication` will create new `XCUIApplicationProcess` elements that register with `XCApplicationMonitor`. Problem is in fact that monitor will rememeber only last `XCUIApplicationProcess` for given PID and will not notify other elements.\nTo prevent that from happening we need to guard against creating new `XCUIApplication` for given PID and cache them.\n\nReviewed By: lawrencelomax\n\nDifferential Revision: D3570195\n\nfbshipit-source-id: 155ce2d8718e7f32667eb82a169225ff1f77842a","distinct":true,"url":"https://api.github.com/repos/imurchie/WebDriverAgent/commits/c1f949bac3d8d5b3b4ae4d088648cbb27ab97d3c"},{"sha":"bfd5ba5e544bd290c3ee42f2f15b6ad6403c96c2","author":{"name":"Isaac Murchie","email":"1a257caa768a1f00ec88befcc5d5a7a9c8c0fa65@saucelabs.com"},"message":"Add GET /source endpoint as per spec","distinct":true,"url":"https://api.github.com/repos/imurchie/WebDriverAgent/commits/bfd5ba5e544bd290c3ee42f2f15b6ad6403c96c2"}]}
{"actor":{"display_login":"imurchie"}}