{"action":"closed","number":2376,"pull_request":{"url":"https://api.github.com/repos/gogits/gogs/pulls/2376","id":55568964,"html_url":"https://github.com/gogits/gogs/pull/2376","diff_url":"https://github.com/gogits/gogs/pull/2376.diff","patch_url":"https://github.com/gogits/gogs/pull/2376.patch","issue_url":"https://api.github.com/repos/gogits/gogs/issues/2376","number":2376,"state":"closed","locked":false,"title":"Conditional StartTLS elevation based on UseSSL","user":{"login":"vilppuvuorinen","id":8420095,"avatar_url":"https://avatars.githubusercontent.com/u/8420095?v=3","gravatar_id":"","url":"https://api.github.com/users/vilppuvuorinen","html_url":"https://github.com/vilppuvuorinen","followers_url":"https://api.github.com/users/vilppuvuorinen/followers","following_url":"https://api.github.com/users/vilppuvuorinen/following{/other_user}","gists_url":"https://api.github.com/users/vilppuvuorinen/gists{/gist_id}","starred_url":"https://api.github.com/users/vilppuvuorinen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilppuvuorinen/subscriptions","organizations_url":"https://api.github.com/users/vilppuvuorinen/orgs","repos_url":"https://api.github.com/users/vilppuvuorinen/repos","events_url":"https://api.github.com/users/vilppuvuorinen/events{/privacy}","received_events_url":"https://api.github.com/users/vilppuvuorinen/received_events","type":"User","site_admin":false},"body":"StartTLS workaround similar to Openshift. Would fix #1666 and #1894.\r\n\r\nI have been able to test this locally using `LDAP (simple auth)` authentication type. #2349 made the testing an absolute pain though.\r\n\r\nOther changes:\r\n\r\n* Migration to prevent breaking existing installations. UseSSL==true `ldap` authentications will jump to using `StartTLS` if no actions are taken to prevent it.\r\n* Documentation updates\r\n* UI field name updates ","created_at":"2016-01-10T16:56:47Z","updated_at":"2016-07-07T23:25:59Z","closed_at":"2016-07-07T23:25:59Z","merged_at":null,"merge_commit_sha":"8cf201f8dd4b89dc3312051b2e2c27bd1c0e7412","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gogits/gogs/pulls/2376/commits","review_comments_url":"https://api.github.com/repos/gogits/gogs/pulls/2376/comments","review_comment_url":"https://api.github.com/repos/gogits/gogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gogits/gogs/issues/2376/comments","statuses_url":"https://api.github.com/repos/gogits/gogs/statuses/3ad58d2b1e3387512ca5084afda25086d6536d09","head":{"label":"vilppuvuorinen:starttls-ldap","ref":"starttls-ldap","sha":"3ad58d2b1e3387512ca5084afda25086d6536d09","user":{"login":"vilppuvuorinen","id":8420095,"avatar_url":"https://avatars.githubusercontent.com/u/8420095?v=3","gravatar_id":"","url":"https://api.github.com/users/vilppuvuorinen","html_url":"https://github.com/vilppuvuorinen","followers_url":"https://api.github.com/users/vilppuvuorinen/followers","following_url":"https://api.github.com/users/vilppuvuorinen/following{/other_user}","gists_url":"https://api.github.com/users/vilppuvuorinen/gists{/gist_id}","starred_url":"https://api.github.com/users/vilppuvuorinen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilppuvuorinen/subscriptions","organizations_url":"https://api.github.com/users/vilppuvuorinen/orgs","repos_url":"https://api.github.com/users/vilppuvuorinen/repos","events_url":"https://api.github.com/users/vilppuvuorinen/events{/privacy}","received_events_url":"https://api.github.com/users/vilppuvuorinen/received_events","type":"User","site_admin":false},"repo":{"id":49316354,"name":"gogs","full_name":"vilppuvuorinen/gogs","owner":{"login":"vilppuvuorinen","id":8420095,"avatar_url":"https://avatars.githubusercontent.com/u/8420095?v=3","gravatar_id":"","url":"https://api.github.com/users/vilppuvuorinen","html_url":"https://github.com/vilppuvuorinen","followers_url":"https://api.github.com/users/vilppuvuorinen/followers","following_url":"https://api.github.com/users/vilppuvuorinen/following{/other_user}","gists_url":"https://api.github.com/users/vilppuvuorinen/gists{/gist_id}","starred_url":"https://api.github.com/users/vilppuvuorinen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilppuvuorinen/subscriptions","organizations_url":"https://api.github.com/users/vilppuvuorinen/orgs","repos_url":"https://api.github.com/users/vilppuvuorinen/repos","events_url":"https://api.github.com/users/vilppuvuorinen/events{/privacy}","received_events_url":"https://api.github.com/users/vilppuvuorinen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vilppuvuorinen/gogs","description":"Gogs (Go Git Service) is a painless self-hosted Git service.","fork":true,"url":"https://api.github.com/repos/vilppuvuorinen/gogs","forks_url":"https://api.github.com/repos/vilppuvuorinen/gogs/forks","keys_url":"https://api.github.com/repos/vilppuvuorinen/gogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vilppuvuorinen/gogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vilppuvuorinen/gogs/teams","hooks_url":"https://api.github.com/repos/vilppuvuorinen/gogs/hooks","issue_events_url":"https://api.github.com/repos/vilppuvuorinen/gogs/issues/events{/number}","events_url":"https://api.github.com/repos/vilppuvuorinen/gogs/events","assignees_url":"https://api.github.com/repos/vilppuvuorinen/gogs/assignees{/user}","branches_url":"https://api.github.com/repos/vilppuvuorinen/gogs/branches{/branch}","tags_url":"https://api.github.com/repos/vilppuvuorinen/gogs/tags","blobs_url":"https://api.github.com/repos/vilppuvuorinen/gogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vilppuvuorinen/gogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vilppuvuorinen/gogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/vilppuvuorinen/gogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vilppuvuorinen/gogs/statuses/{sha}","languages_url":"https://api.github.com/repos/vilppuvuorinen/gogs/languages","stargazers_url":"https://api.github.com/repos/vilppuvuorinen/gogs/stargazers","contributors_url":"https://api.github.com/repos/vilppuvuorinen/gogs/contributors","subscribers_url":"https://api.github.com/repos/vilppuvuorinen/gogs/subscribers","subscription_url":"https://api.github.com/repos/vilppuvuorinen/gogs/subscription","commits_url":"https://api.github.com/repos/vilppuvuorinen/gogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/vilppuvuorinen/gogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/vilppuvuorinen/gogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/vilppuvuorinen/gogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/vilppuvuorinen/gogs/contents/{+path}","compare_url":"https://api.github.com/repos/vilppuvuorinen/gogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vilppuvuorinen/gogs/merges","archive_url":"https://api.github.com/repos/vilppuvuorinen/gogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vilppuvuorinen/gogs/downloads","issues_url":"https://api.github.com/repos/vilppuvuorinen/gogs/issues{/number}","pulls_url":"https://api.github.com/repos/vilppuvuorinen/gogs/pulls{/number}","milestones_url":"https://api.github.com/repos/vilppuvuorinen/gogs/milestones{/number}","notifications_url":"https://api.github.com/repos/vilppuvuorinen/gogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vilppuvuorinen/gogs/labels{/name}","releases_url":"https://api.github.com/repos/vilppuvuorinen/gogs/releases{/id}","deployments_url":"https://api.github.com/repos/vilppuvuorinen/gogs/deployments","created_at":"2016-01-09T08:08:38Z","updated_at":"2016-01-09T08:08:40Z","pushed_at":"2016-01-10T16:45:15Z","git_url":"git://github.com/vilppuvuorinen/gogs.git","ssh_url":"git@github.com:vilppuvuorinen/gogs.git","clone_url":"https://github.com/vilppuvuorinen/gogs.git","svn_url":"https://github.com/vilppuvuorinen/gogs","homepage":"https://gogs.io","size":39928,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gogits:develop","ref":"develop","sha":"fbf43c31e552abaf5b71a59a28881438f1194745","user":{"login":"gogits","id":6656686,"avatar_url":"https://avatars.githubusercontent.com/u/6656686?v=3","gravatar_id":"","url":"https://api.github.com/users/gogits","html_url":"https://github.com/gogits","followers_url":"https://api.github.com/users/gogits/followers","following_url":"https://api.github.com/users/gogits/following{/other_user}","gists_url":"https://api.github.com/users/gogits/gists{/gist_id}","starred_url":"https://api.github.com/users/gogits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gogits/subscriptions","organizations_url":"https://api.github.com/users/gogits/orgs","repos_url":"https://api.github.com/users/gogits/repos","events_url":"https://api.github.com/users/gogits/events{/privacy}","received_events_url":"https://api.github.com/users/gogits/received_events","type":"Organization","site_admin":false},"repo":{"id":16752620,"name":"gogs","full_name":"gogits/gogs","owner":{"login":"gogits","id":6656686,"avatar_url":"https://avatars.githubusercontent.com/u/6656686?v=3","gravatar_id":"","url":"https://api.github.com/users/gogits","html_url":"https://github.com/gogits","followers_url":"https://api.github.com/users/gogits/followers","following_url":"https://api.github.com/users/gogits/following{/other_user}","gists_url":"https://api.github.com/users/gogits/gists{/gist_id}","starred_url":"https://api.github.com/users/gogits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gogits/subscriptions","organizations_url":"https://api.github.com/users/gogits/orgs","repos_url":"https://api.github.com/users/gogits/repos","events_url":"https://api.github.com/users/gogits/events{/privacy}","received_events_url":"https://api.github.com/users/gogits/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gogits/gogs","description":"Gogs (Go Git Service) is a painless self-hosted Git service.","fork":false,"url":"https://api.github.com/repos/gogits/gogs","forks_url":"https://api.github.com/repos/gogits/gogs/forks","keys_url":"https://api.github.com/repos/gogits/gogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gogits/gogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gogits/gogs/teams","hooks_url":"https://api.github.com/repos/gogits/gogs/hooks","issue_events_url":"https://api.github.com/repos/gogits/gogs/issues/events{/number}","events_url":"https://api.github.com/repos/gogits/gogs/events","assignees_url":"https://api.github.com/repos/gogits/gogs/assignees{/user}","branches_url":"https://api.github.com/repos/gogits/gogs/branches{/branch}","tags_url":"https://api.github.com/repos/gogits/gogs/tags","blobs_url":"https://api.github.com/repos/gogits/gogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gogits/gogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gogits/gogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/gogits/gogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gogits/gogs/statuses/{sha}","languages_url":"https://api.github.com/repos/gogits/gogs/languages","stargazers_url":"https://api.github.com/repos/gogits/gogs/stargazers","contributors_url":"https://api.github.com/repos/gogits/gogs/contributors","subscribers_url":"https://api.github.com/repos/gogits/gogs/subscribers","subscription_url":"https://api.github.com/repos/gogits/gogs/subscription","commits_url":"https://api.github.com/repos/gogits/gogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/gogits/gogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/gogits/gogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/gogits/gogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/gogits/gogs/contents/{+path}","compare_url":"https://api.github.com/repos/gogits/gogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gogits/gogs/merges","archive_url":"https://api.github.com/repos/gogits/gogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gogits/gogs/downloads","issues_url":"https://api.github.com/repos/gogits/gogs/issues{/number}","pulls_url":"https://api.github.com/repos/gogits/gogs/pulls{/number}","milestones_url":"https://api.github.com/repos/gogits/gogs/milestones{/number}","notifications_url":"https://api.github.com/repos/gogits/gogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gogits/gogs/labels{/name}","releases_url":"https://api.github.com/repos/gogits/gogs/releases{/id}","deployments_url":"https://api.github.com/repos/gogits/gogs/deployments","created_at":"2014-02-12T01:57:08Z","updated_at":"2016-07-07T20:13:13Z","pushed_at":"2016-07-07T23:25:27Z","git_url":"git://github.com/gogits/gogs.git","ssh_url":"git@github.com:gogits/gogs.git","clone_url":"https://github.com/gogits/gogs.git","svn_url":"https://github.com/gogits/gogs","homepage":"https://gogs.io","size":72692,"stargazers_count":14464,"watchers_count":14464,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1508,"mirror_url":null,"open_issues_count":467,"forks":1508,"open_issues":467,"watchers":14464,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gogits/gogs/pulls/2376"},"html":{"href":"https://github.com/gogits/gogs/pull/2376"},"issue":{"href":"https://api.github.com/repos/gogits/gogs/issues/2376"},"comments":{"href":"https://api.github.com/repos/gogits/gogs/issues/2376/comments"},"review_comments":{"href":"https://api.github.com/repos/gogits/gogs/pulls/2376/comments"},"review_comment":{"href":"https://api.github.com/repos/gogits/gogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gogits/gogs/pulls/2376/commits"},"statuses":{"href":"https://api.github.com/repos/gogits/gogs/statuses/3ad58d2b1e3387512ca5084afda25086d6536d09"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":20,"review_comments":0,"commits":1,"additions":17,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"Unknwon"}}