{"action":"created","issue":{"url":"https://api.github.com/repos/matplotlib/matplotlib/issues/6407","repository_url":"https://api.github.com/repos/matplotlib/matplotlib","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/6407/labels{/name}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/6407/comments","events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/6407/events","html_url":"https://github.com/matplotlib/matplotlib/pull/6407","id":154365386,"number":6407,"title":"adding default toggled state for toggle tools","user":{"login":"fariza","id":1490153,"avatar_url":"https://avatars.githubusercontent.com/u/1490153?v=3","gravatar_id":"","url":"https://api.github.com/users/fariza","html_url":"https://github.com/fariza","followers_url":"https://api.github.com/users/fariza/followers","following_url":"https://api.github.com/users/fariza/following{/other_user}","gists_url":"https://api.github.com/users/fariza/gists{/gist_id}","starred_url":"https://api.github.com/users/fariza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fariza/subscriptions","organizations_url":"https://api.github.com/users/fariza/orgs","repos_url":"https://api.github.com/users/fariza/repos","events_url":"https://api.github.com/users/fariza/events{/privacy}","received_events_url":"https://api.github.com/users/fariza/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/12","html_url":"https://github.com/matplotlib/matplotlib/milestones/2.1%20(next%20point%20release)","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/12/labels","id":534144,"number":12,"title":"2.1 (next point release)","description":"Next feature release.\r\n\r\nBig ticket items:\r\n\r\n - MEP 22/27\r\n - traitlets","creator":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":532,"closed_issues":449,"state":"open","created_at":"2014-01-13T03:21:09Z","updated_at":"2016-08-16T04:31:07Z","due_on":null,"closed_at":null},"comments":12,"created_at":"2016-05-11T23:27:33Z","updated_at":"2016-08-16T21:12:21Z","closed_at":"2016-08-08T15:47:56Z","pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/6407","html_url":"https://github.com/matplotlib/matplotlib/pull/6407","diff_url":"https://github.com/matplotlib/matplotlib/pull/6407.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/6407.patch"},"body":"So far toggle tools start their life in the **untoggled** state, most of the time this is what we want but sometimes it is desirable to initialize a ToogleTool in a **toggled** state without firing the `tool_trigger_xxx` event\r\n\r\nWith the changes in this PR, the initial state can be changed by class attribute during Tool definition `default_toggle = True` or at the moment of adding the tool to the Toolmanager `toolmanager.add_tool('Name', ToolCls, toggle=True)`"},"comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments/240240558","html_url":"https://github.com/matplotlib/matplotlib/pull/6407#issuecomment-240240558","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/6407","id":240240558,"user":{"login":"WeatherGod","id":291576,"avatar_url":"https://avatars.githubusercontent.com/u/291576?v=3","gravatar_id":"","url":"https://api.github.com/users/WeatherGod","html_url":"https://github.com/WeatherGod","followers_url":"https://api.github.com/users/WeatherGod/followers","following_url":"https://api.github.com/users/WeatherGod/following{/other_user}","gists_url":"https://api.github.com/users/WeatherGod/gists{/gist_id}","starred_url":"https://api.github.com/users/WeatherGod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WeatherGod/subscriptions","organizations_url":"https://api.github.com/users/WeatherGod/orgs","repos_url":"https://api.github.com/users/WeatherGod/repos","events_url":"https://api.github.com/users/WeatherGod/events{/privacy}","received_events_url":"https://api.github.com/users/WeatherGod/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T21:12:21Z","updated_at":"2016-08-16T21:12:21Z","body":"@fariza, I just noticed that this PR was self-merged. I don't want to make a huge deal about it, as these changes are non-controversial and there was a lack of responses to the PR. The matplotlib organization does not enforce a ban on self-merges, but it is highly discouraged. We don't enforce such a ban because there are emergency situations where it is the correct thing to do (getting TravisCI happy again because pyparsing put out a bad release is an example).\r\n\r\nWhat I would suggest you do next time you get a lack of responses to your PR is to ping the PR. If you still don't get responses, then raise the issue on the gitter chat room or on the mailing list. The lack of responses could simply be due to vacation schedules or other things going on.\r\n\r\nAs for this PR, if I had actually spent time reviewing it at the time (sorry for not doing so), I would have asked for some tests, if it was possible. The coverage went down because of this PR, which is less than ideal. If tests are possible, then could you please create a PR to include them, please?"}}
{"actor":{"display_login":"WeatherGod"}}