{"action":"created","comment":{"url":"https://api.github.com/repos/ethcore/parity/pulls/comments/93646356","pull_request_review_id":14178544,"id":93646356,"diff_hunk":"@@ -0,0 +1,73 @@\n+// Copyright 2015, 2016 Parity Technologies (UK) Ltd.\n+// This file is part of Parity.\n+\n+// Parity is free software: you can redistribute it and/or modify\n+// it under the terms of the GNU General Public License as published by\n+// the Free Software Foundation, either version 3 of the License, or\n+// (at your option) any later version.\n+\n+// Parity is distributed in the hope that it will be useful,\n+// but WITHOUT ANY WARRANTY; without even the implied warranty of\n+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+// GNU General Public License for more details.\n+\n+// You should have received a copy of the GNU General Public License\n+// along with Parity.  If not, see <http://www.gnu.org/licenses/>.\n+\n+import { api } from '../parity.js';\n+import postTx from '../util/post-tx';\n+\n+export const start = (action, name, address) => ({ type: `reverse ${action} start`, name, address });\n+\n+export const success = (action) => ({ type: `reverse ${action} success` });\n+\n+export const fail = (action) => ({ type: `reverse ${action} error` });\n+\n+export const propose = (name, address) => (dispatch, getState) => {\n+  const state = getState();\n+  const account = state.accounts.selected;\n+  const contract = state.contract;\n+  if (!contract || !account) return;\n+  name = name.toLowerCase();\n+\n+  const proposeReverse = contract.functions.find((f) => f.name === 'proposeReverse');\n+\n+  dispatch(start('propose', name, address));\n+  postTx(api, proposeReverse, {\n+    from: account.address\n+  }, [\n+    name,\n+    address\n+  ])\n+    .then((txHash) => {\n+      dispatch(success('propose'));\n+    }).catch((err) => {\n+      console.error(`could not propose reverse ${name} for address ${address}`);\n+      if (err) console.error(err.stack);\n+      dispatch(fail('propose'));\n+    });\n+};\n+\n+export const confirm = (name) => (dispatch, getState) => {\n+  const state = getState();\n+  const account = state.accounts.selected;\n+  const contract = state.contract;\n+  if (!contract || !account) return;\n+  name = name.toLowerCase();\n+\n+  const confirmReverse = contract.functions.find((f) => f.name === 'confirmReverse');\n+\n+  dispatch(start('confirm', name));\n+  postTx(api, confirmReverse, {\n+    from: account.address\n+  }, [\n+    name\n+  ])\n+    .then((txHash) => {\n+      dispatch(success('confirm'));\n+    }).catch((err) => {","path":"js/src/dapps/registry/Reverse/actions.js","position":68,"original_position":68,"commit_id":"187a1c21772cb0587595553e0c0e71eae9c23d47","original_commit_id":"187a1c21772cb0587595553e0c0e71eae9c23d47","user":{"login":"jacogr","id":1424473,"avatar_url":"https://avatars.githubusercontent.com/u/1424473?v=3","gravatar_id":"","url":"https://api.github.com/users/jacogr","html_url":"https://github.com/jacogr","followers_url":"https://api.github.com/users/jacogr/followers","following_url":"https://api.github.com/users/jacogr/following{/other_user}","gists_url":"https://api.github.com/users/jacogr/gists{/gist_id}","starred_url":"https://api.github.com/users/jacogr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacogr/subscriptions","organizations_url":"https://api.github.com/users/jacogr/orgs","repos_url":"https://api.github.com/users/jacogr/repos","events_url":"https://api.github.com/users/jacogr/events{/privacy}","received_events_url":"https://api.github.com/users/jacogr/received_events","type":"User","site_admin":false},"body":"As per rest of codebase, .catch on next line","created_at":"2016-12-22T15:50:19Z","updated_at":"2016-12-22T15:50:20Z","html_url":"https://github.com/ethcore/parity/pull/3933#discussion_r93646356","pull_request_url":"https://api.github.com/repos/ethcore/parity/pulls/3933","_links":{"self":{"href":"https://api.github.com/repos/ethcore/parity/pulls/comments/93646356"},"html":{"href":"https://github.com/ethcore/parity/pull/3933#discussion_r93646356"},"pull_request":{"href":"https://api.github.com/repos/ethcore/parity/pulls/3933"}}},"pull_request":{"url":"https://api.github.com/repos/ethcore/parity/pulls/3933","id":98949552,"html_url":"https://github.com/ethcore/parity/pull/3933","diff_url":"https://github.com/ethcore/parity/pull/3933.diff","patch_url":"https://github.com/ethcore/parity/pull/3933.patch","issue_url":"https://api.github.com/repos/ethcore/parity/issues/3933","number":3933,"state":"open","locked":false,"title":"registry dapp: cleanup, support reverse entries","user":{"login":"derhuerst","id":5072613,"avatar_url":"https://avatars.githubusercontent.com/u/5072613?v=3","gravatar_id":"","url":"https://api.github.com/users/derhuerst","html_url":"https://github.com/derhuerst","followers_url":"https://api.github.com/users/derhuerst/followers","following_url":"https://api.github.com/users/derhuerst/following{/other_user}","gists_url":"https://api.github.com/users/derhuerst/gists{/gist_id}","starred_url":"https://api.github.com/users/derhuerst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derhuerst/subscriptions","organizations_url":"https://api.github.com/users/derhuerst/orgs","repos_url":"https://api.github.com/users/derhuerst/repos","events_url":"https://api.github.com/users/derhuerst/events{/privacy}","received_events_url":"https://api.github.com/users/derhuerst/received_events","type":"User","site_admin":false},"body":"Fixes #3098, with the exception of `removeReverse`.\r\n\r\nWork in progress, not happy with the actions & reducers boilerplate. Also the captions in the UI are not very helpful.","created_at":"2016-12-21T15:13:24Z","updated_at":"2016-12-22T15:50:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de419f03d4bda05d88a8f28830568214d1ba106a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethcore/parity/pulls/3933/commits","review_comments_url":"https://api.github.com/repos/ethcore/parity/pulls/3933/comments","review_comment_url":"https://api.github.com/repos/ethcore/parity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethcore/parity/issues/3933/comments","statuses_url":"https://api.github.com/repos/ethcore/parity/statuses/187a1c21772cb0587595553e0c0e71eae9c23d47","head":{"label":"ethcore:jr-registry-reverse","ref":"jr-registry-reverse","sha":"187a1c21772cb0587595553e0c0e71eae9c23d47","user":{"login":"ethcore","id":14176906,"avatar_url":"https://avatars.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/ethcore","html_url":"https://github.com/ethcore","followers_url":"https://api.github.com/users/ethcore/followers","following_url":"https://api.github.com/users/ethcore/following{/other_user}","gists_url":"https://api.github.com/users/ethcore/gists{/gist_id}","starred_url":"https://api.github.com/users/ethcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethcore/subscriptions","organizations_url":"https://api.github.com/users/ethcore/orgs","repos_url":"https://api.github.com/users/ethcore/repos","events_url":"https://api.github.com/users/ethcore/events{/privacy}","received_events_url":"https://api.github.com/users/ethcore/received_events","type":"Organization","site_admin":false},"repo":{"id":46714939,"name":"parity","full_name":"ethcore/parity","owner":{"login":"ethcore","id":14176906,"avatar_url":"https://avatars.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/ethcore","html_url":"https://github.com/ethcore","followers_url":"https://api.github.com/users/ethcore/followers","following_url":"https://api.github.com/users/ethcore/following{/other_user}","gists_url":"https://api.github.com/users/ethcore/gists{/gist_id}","starred_url":"https://api.github.com/users/ethcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethcore/subscriptions","organizations_url":"https://api.github.com/users/ethcore/orgs","repos_url":"https://api.github.com/users/ethcore/repos","events_url":"https://api.github.com/users/ethcore/events{/privacy}","received_events_url":"https://api.github.com/users/ethcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethcore/parity","description":"Fast, light, robust Ethereum implementation","fork":false,"url":"https://api.github.com/repos/ethcore/parity","forks_url":"https://api.github.com/repos/ethcore/parity/forks","keys_url":"https://api.github.com/repos/ethcore/parity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethcore/parity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethcore/parity/teams","hooks_url":"https://api.github.com/repos/ethcore/parity/hooks","issue_events_url":"https://api.github.com/repos/ethcore/parity/issues/events{/number}","events_url":"https://api.github.com/repos/ethcore/parity/events","assignees_url":"https://api.github.com/repos/ethcore/parity/assignees{/user}","branches_url":"https://api.github.com/repos/ethcore/parity/branches{/branch}","tags_url":"https://api.github.com/repos/ethcore/parity/tags","blobs_url":"https://api.github.com/repos/ethcore/parity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethcore/parity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethcore/parity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethcore/parity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethcore/parity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethcore/parity/languages","stargazers_url":"https://api.github.com/repos/ethcore/parity/stargazers","contributors_url":"https://api.github.com/repos/ethcore/parity/contributors","subscribers_url":"https://api.github.com/repos/ethcore/parity/subscribers","subscription_url":"https://api.github.com/repos/ethcore/parity/subscription","commits_url":"https://api.github.com/repos/ethcore/parity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethcore/parity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethcore/parity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethcore/parity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethcore/parity/contents/{+path}","compare_url":"https://api.github.com/repos/ethcore/parity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethcore/parity/merges","archive_url":"https://api.github.com/repos/ethcore/parity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethcore/parity/downloads","issues_url":"https://api.github.com/repos/ethcore/parity/issues{/number}","pulls_url":"https://api.github.com/repos/ethcore/parity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethcore/parity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethcore/parity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethcore/parity/labels{/name}","releases_url":"https://api.github.com/repos/ethcore/parity/releases{/id}","deployments_url":"https://api.github.com/repos/ethcore/parity/deployments","created_at":"2015-11-23T11:07:32Z","updated_at":"2016-12-19T22:21:57Z","pushed_at":"2016-12-22T15:42:04Z","git_url":"git://github.com/ethcore/parity.git","ssh_url":"git@github.com:ethcore/parity.git","clone_url":"https://github.com/ethcore/parity.git","svn_url":"https://github.com/ethcore/parity","homepage":"","size":78082,"stargazers_count":717,"watchers_count":717,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":140,"mirror_url":null,"open_issues_count":304,"forks":140,"open_issues":304,"watchers":717,"default_branch":"master"}},"base":{"label":"ethcore:master","ref":"master","sha":"be75cbfaaa36cbf5ee80d585d40896dfd72a1f8e","user":{"login":"ethcore","id":14176906,"avatar_url":"https://avatars.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/ethcore","html_url":"https://github.com/ethcore","followers_url":"https://api.github.com/users/ethcore/followers","following_url":"https://api.github.com/users/ethcore/following{/other_user}","gists_url":"https://api.github.com/users/ethcore/gists{/gist_id}","starred_url":"https://api.github.com/users/ethcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethcore/subscriptions","organizations_url":"https://api.github.com/users/ethcore/orgs","repos_url":"https://api.github.com/users/ethcore/repos","events_url":"https://api.github.com/users/ethcore/events{/privacy}","received_events_url":"https://api.github.com/users/ethcore/received_events","type":"Organization","site_admin":false},"repo":{"id":46714939,"name":"parity","full_name":"ethcore/parity","owner":{"login":"ethcore","id":14176906,"avatar_url":"https://avatars.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/ethcore","html_url":"https://github.com/ethcore","followers_url":"https://api.github.com/users/ethcore/followers","following_url":"https://api.github.com/users/ethcore/following{/other_user}","gists_url":"https://api.github.com/users/ethcore/gists{/gist_id}","starred_url":"https://api.github.com/users/ethcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethcore/subscriptions","organizations_url":"https://api.github.com/users/ethcore/orgs","repos_url":"https://api.github.com/users/ethcore/repos","events_url":"https://api.github.com/users/ethcore/events{/privacy}","received_events_url":"https://api.github.com/users/ethcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethcore/parity","description":"Fast, light, robust Ethereum implementation","fork":false,"url":"https://api.github.com/repos/ethcore/parity","forks_url":"https://api.github.com/repos/ethcore/parity/forks","keys_url":"https://api.github.com/repos/ethcore/parity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethcore/parity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethcore/parity/teams","hooks_url":"https://api.github.com/repos/ethcore/parity/hooks","issue_events_url":"https://api.github.com/repos/ethcore/parity/issues/events{/number}","events_url":"https://api.github.com/repos/ethcore/parity/events","assignees_url":"https://api.github.com/repos/ethcore/parity/assignees{/user}","branches_url":"https://api.github.com/repos/ethcore/parity/branches{/branch}","tags_url":"https://api.github.com/repos/ethcore/parity/tags","blobs_url":"https://api.github.com/repos/ethcore/parity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethcore/parity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethcore/parity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethcore/parity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethcore/parity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethcore/parity/languages","stargazers_url":"https://api.github.com/repos/ethcore/parity/stargazers","contributors_url":"https://api.github.com/repos/ethcore/parity/contributors","subscribers_url":"https://api.github.com/repos/ethcore/parity/subscribers","subscription_url":"https://api.github.com/repos/ethcore/parity/subscription","commits_url":"https://api.github.com/repos/ethcore/parity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethcore/parity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethcore/parity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethcore/parity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethcore/parity/contents/{+path}","compare_url":"https://api.github.com/repos/ethcore/parity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethcore/parity/merges","archive_url":"https://api.github.com/repos/ethcore/parity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethcore/parity/downloads","issues_url":"https://api.github.com/repos/ethcore/parity/issues{/number}","pulls_url":"https://api.github.com/repos/ethcore/parity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethcore/parity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethcore/parity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethcore/parity/labels{/name}","releases_url":"https://api.github.com/repos/ethcore/parity/releases{/id}","deployments_url":"https://api.github.com/repos/ethcore/parity/deployments","created_at":"2015-11-23T11:07:32Z","updated_at":"2016-12-19T22:21:57Z","pushed_at":"2016-12-22T15:42:04Z","git_url":"git://github.com/ethcore/parity.git","ssh_url":"git@github.com:ethcore/parity.git","clone_url":"https://github.com/ethcore/parity.git","svn_url":"https://github.com/ethcore/parity","homepage":"","size":78082,"stargazers_count":717,"watchers_count":717,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":140,"mirror_url":null,"open_issues_count":304,"forks":140,"open_issues":304,"watchers":717,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethcore/parity/pulls/3933"},"html":{"href":"https://github.com/ethcore/parity/pull/3933"},"issue":{"href":"https://api.github.com/repos/ethcore/parity/issues/3933"},"comments":{"href":"https://api.github.com/repos/ethcore/parity/issues/3933/comments"},"review_comments":{"href":"https://api.github.com/repos/ethcore/parity/pulls/3933/comments"},"review_comment":{"href":"https://api.github.com/repos/ethcore/parity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethcore/parity/pulls/3933/commits"},"statuses":{"href":"https://api.github.com/repos/ethcore/parity/statuses/187a1c21772cb0587595553e0c0e71eae9c23d47"}}}}
{"actor":{"display_login":"jacogr"}}