{"action":"opened","number":979,"pull_request":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/979","id":91402549,"html_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/979","diff_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/979.diff","patch_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/979.patch","issue_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/979","number":979,"state":"open","locked":false,"title":"fix(pagination): better protect against invalid inputs","user":{"login":"maxokorokov","id":8074436,"avatar_url":"https://avatars.githubusercontent.com/u/8074436?v=3","gravatar_id":"","url":"https://api.github.com/users/maxokorokov","html_url":"https://github.com/maxokorokov","followers_url":"https://api.github.com/users/maxokorokov/followers","following_url":"https://api.github.com/users/maxokorokov/following{/other_user}","gists_url":"https://api.github.com/users/maxokorokov/gists{/gist_id}","starred_url":"https://api.github.com/users/maxokorokov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxokorokov/subscriptions","organizations_url":"https://api.github.com/users/maxokorokov/orgs","repos_url":"https://api.github.com/users/maxokorokov/repos","events_url":"https://api.github.com/users/maxokorokov/events{/privacy}","received_events_url":"https://api.github.com/users/maxokorokov/received_events","type":"User","site_admin":false},"body":"Second attempt to improve situation with pagination invalid inputs (related to #898)\r\n\r\n- Added tests for edge cases for `collectionSize`, `page`, `maxSize` and `pageSize` to see the pagination behaviour\r\n- Cleaned up `ngOnChanges`\r\n- Essentially the main change is:\r\n\r\n```ts\r\nif (!isNumber(this.pageCount)) {\r\n  this.pageCount = 0;\r\n}\r\n```","created_at":"2016-10-28T15:31:08Z","updated_at":"2016-10-28T15:31:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/979/commits","review_comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/979/comments","review_comment_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/979/comments","statuses_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/statuses/93f5902f72bc4e8c1b0a5bbc85dffedaf89c35c8","head":{"label":"maxokorokov:pagination_invalid_inputs","ref":"pagination_invalid_inputs","sha":"93f5902f72bc4e8c1b0a5bbc85dffedaf89c35c8","user":{"login":"maxokorokov","id":8074436,"avatar_url":"https://avatars.githubusercontent.com/u/8074436?v=3","gravatar_id":"","url":"https://api.github.com/users/maxokorokov","html_url":"https://github.com/maxokorokov","followers_url":"https://api.github.com/users/maxokorokov/followers","following_url":"https://api.github.com/users/maxokorokov/following{/other_user}","gists_url":"https://api.github.com/users/maxokorokov/gists{/gist_id}","starred_url":"https://api.github.com/users/maxokorokov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxokorokov/subscriptions","organizations_url":"https://api.github.com/users/maxokorokov/orgs","repos_url":"https://api.github.com/users/maxokorokov/repos","events_url":"https://api.github.com/users/maxokorokov/events{/privacy}","received_events_url":"https://api.github.com/users/maxokorokov/received_events","type":"User","site_admin":false},"repo":{"id":56863546,"name":"core","full_name":"maxokorokov/core","owner":{"login":"maxokorokov","id":8074436,"avatar_url":"https://avatars.githubusercontent.com/u/8074436?v=3","gravatar_id":"","url":"https://api.github.com/users/maxokorokov","html_url":"https://github.com/maxokorokov","followers_url":"https://api.github.com/users/maxokorokov/followers","following_url":"https://api.github.com/users/maxokorokov/following{/other_user}","gists_url":"https://api.github.com/users/maxokorokov/gists{/gist_id}","starred_url":"https://api.github.com/users/maxokorokov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxokorokov/subscriptions","organizations_url":"https://api.github.com/users/maxokorokov/orgs","repos_url":"https://api.github.com/users/maxokorokov/repos","events_url":"https://api.github.com/users/maxokorokov/events{/privacy}","received_events_url":"https://api.github.com/users/maxokorokov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxokorokov/core","description":"Angular 2 powered Bootstrap","fork":true,"url":"https://api.github.com/repos/maxokorokov/core","forks_url":"https://api.github.com/repos/maxokorokov/core/forks","keys_url":"https://api.github.com/repos/maxokorokov/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxokorokov/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxokorokov/core/teams","hooks_url":"https://api.github.com/repos/maxokorokov/core/hooks","issue_events_url":"https://api.github.com/repos/maxokorokov/core/issues/events{/number}","events_url":"https://api.github.com/repos/maxokorokov/core/events","assignees_url":"https://api.github.com/repos/maxokorokov/core/assignees{/user}","branches_url":"https://api.github.com/repos/maxokorokov/core/branches{/branch}","tags_url":"https://api.github.com/repos/maxokorokov/core/tags","blobs_url":"https://api.github.com/repos/maxokorokov/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxokorokov/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxokorokov/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxokorokov/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxokorokov/core/statuses/{sha}","languages_url":"https://api.github.com/repos/maxokorokov/core/languages","stargazers_url":"https://api.github.com/repos/maxokorokov/core/stargazers","contributors_url":"https://api.github.com/repos/maxokorokov/core/contributors","subscribers_url":"https://api.github.com/repos/maxokorokov/core/subscribers","subscription_url":"https://api.github.com/repos/maxokorokov/core/subscription","commits_url":"https://api.github.com/repos/maxokorokov/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxokorokov/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxokorokov/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxokorokov/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxokorokov/core/contents/{+path}","compare_url":"https://api.github.com/repos/maxokorokov/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxokorokov/core/merges","archive_url":"https://api.github.com/repos/maxokorokov/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxokorokov/core/downloads","issues_url":"https://api.github.com/repos/maxokorokov/core/issues{/number}","pulls_url":"https://api.github.com/repos/maxokorokov/core/pulls{/number}","milestones_url":"https://api.github.com/repos/maxokorokov/core/milestones{/number}","notifications_url":"https://api.github.com/repos/maxokorokov/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxokorokov/core/labels{/name}","releases_url":"https://api.github.com/repos/maxokorokov/core/releases{/id}","deployments_url":"https://api.github.com/repos/maxokorokov/core/deployments","created_at":"2016-04-22T14:59:57Z","updated_at":"2016-04-22T14:59:57Z","pushed_at":"2016-10-28T15:24:29Z","git_url":"git://github.com/maxokorokov/core.git","ssh_url":"git@github.com:maxokorokov/core.git","clone_url":"https://github.com/maxokorokov/core.git","svn_url":"https://github.com/maxokorokov/core","homepage":null,"size":1194,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ng-bootstrap:master","ref":"master","sha":"2bb896c0f615c308f3896808a2edff597621dd38","user":{"login":"ng-bootstrap","id":14283866,"avatar_url":"https://avatars.githubusercontent.com/u/14283866?v=3","gravatar_id":"","url":"https://api.github.com/users/ng-bootstrap","html_url":"https://github.com/ng-bootstrap","followers_url":"https://api.github.com/users/ng-bootstrap/followers","following_url":"https://api.github.com/users/ng-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/ng-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/ng-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ng-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/ng-bootstrap/orgs","repos_url":"https://api.github.com/users/ng-bootstrap/repos","events_url":"https://api.github.com/users/ng-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/ng-bootstrap/received_events","type":"Organization","site_admin":false},"repo":{"id":42481664,"name":"ng-bootstrap","full_name":"ng-bootstrap/ng-bootstrap","owner":{"login":"ng-bootstrap","id":14283866,"avatar_url":"https://avatars.githubusercontent.com/u/14283866?v=3","gravatar_id":"","url":"https://api.github.com/users/ng-bootstrap","html_url":"https://github.com/ng-bootstrap","followers_url":"https://api.github.com/users/ng-bootstrap/followers","following_url":"https://api.github.com/users/ng-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/ng-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/ng-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ng-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/ng-bootstrap/orgs","repos_url":"https://api.github.com/users/ng-bootstrap/repos","events_url":"https://api.github.com/users/ng-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/ng-bootstrap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ng-bootstrap/ng-bootstrap","description":"Angular 2 powered Bootstrap","fork":false,"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap","forks_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/forks","keys_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/teams","hooks_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/events","assignees_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/tags","blobs_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/languages","stargazers_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/subscription","commits_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/merges","archive_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/downloads","issues_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/releases{/id}","deployments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/deployments","created_at":"2015-09-14T22:55:53Z","updated_at":"2016-10-28T14:28:28Z","pushed_at":"2016-10-28T14:36:20Z","git_url":"git://github.com/ng-bootstrap/ng-bootstrap.git","ssh_url":"git@github.com:ng-bootstrap/ng-bootstrap.git","clone_url":"https://github.com/ng-bootstrap/ng-bootstrap.git","svn_url":"https://github.com/ng-bootstrap/ng-bootstrap","homepage":"https://ng-bootstrap.github.io","size":1923,"stargazers_count":1346,"watchers_count":1346,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":205,"mirror_url":null,"open_issues_count":61,"forks":205,"open_issues":61,"watchers":1346,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/979"},"html":{"href":"https://github.com/ng-bootstrap/ng-bootstrap/pull/979"},"issue":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/979"},"comments":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/979/comments"},"review_comments":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/979/comments"},"review_comment":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/979/commits"},"statuses":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/statuses/93f5902f72bc4e8c1b0a5bbc85dffedaf89c35c8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":118,"deletions":36,"changed_files":2}}
{"actor":{"display_login":"maxokorokov"}}