{"action":"created","comment":{"url":"https://api.github.com/repos/onelogin/python3-saml/pulls/comments/62343658","id":62343658,"diff_hunk":"@@ -51,7 +51,7 @@ def testParseRemote(self):\n \n         data = OneLogin_Saml2_IdPMetadataParser.parse_remote('https://www.testshib.org/metadata/testshib-providers.xml')\n         self.assertTrue(data is not None and data is not {})\n-        expected_data = {'sp': {'NameIDFormat': 'urn:mace:shibboleth:1.0:nameIdentifier'}, 'idp': {'singleSignOnService': {'url': 'https://idp.testshib.org/idp/profile/SAML2/Redirect/SSO'}, 'entityId': 'https://idp.testshib.org/idp/shibboleth'}}\n+        expected_data = {'sp': {'NameIDFormat': 'urn:mace:shibboleth:1.0:nameIdentifier'}, 'idp': {'singleSignOnService': {'url': 'https://idp.testshib.org/idp/profile/SAML2/Redirect/SSO', 'binding': 'urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect'}, 'entityId': 'https://idp.testshib.org/idp/shibboleth'}}\n         self.assertEqual(expected_data, data)\n \n     def testParse(self):","path":"tests/src/OneLogin/saml2_tests/idp_metadata_parser_test.py","position":8,"original_position":8,"commit_id":"c052be9cec3dda5bf081811835c93c0a3f3010d1","original_commit_id":"c052be9cec3dda5bf081811835c93c0a3f3010d1","user":{"login":"pitbulk","id":600897,"avatar_url":"https://avatars.githubusercontent.com/u/600897?v=3","gravatar_id":"","url":"https://api.github.com/users/pitbulk","html_url":"https://github.com/pitbulk","followers_url":"https://api.github.com/users/pitbulk/followers","following_url":"https://api.github.com/users/pitbulk/following{/other_user}","gists_url":"https://api.github.com/users/pitbulk/gists{/gist_id}","starred_url":"https://api.github.com/users/pitbulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitbulk/subscriptions","organizations_url":"https://api.github.com/users/pitbulk/orgs","repos_url":"https://api.github.com/users/pitbulk/repos","events_url":"https://api.github.com/users/pitbulk/events{/privacy}","received_events_url":"https://api.github.com/users/pitbulk/received_events","type":"User","site_admin":false},"body":"You can add different IdP metadata endpoints to the test suits and try to parse them.\r\nI'm ok with the test that check the settings merge. I want to cover all the \"parse\" scenarios.\r\n\r\nIdP metadata with various SSO endpoints and try to extract offering different binding and see if the extracted value works.\r\n\r\nSame for SLO endpoints (taking in mind that SLO endpoint is not required in a metadata XML)","created_at":"2016-05-06T15:14:59Z","updated_at":"2016-05-06T15:14:59Z","html_url":"https://github.com/onelogin/python3-saml/pull/21#discussion_r62343658","pull_request_url":"https://api.github.com/repos/onelogin/python3-saml/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/onelogin/python3-saml/pulls/comments/62343658"},"html":{"href":"https://github.com/onelogin/python3-saml/pull/21#discussion_r62343658"},"pull_request":{"href":"https://api.github.com/repos/onelogin/python3-saml/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/onelogin/python3-saml/pulls/21","id":69156824,"html_url":"https://github.com/onelogin/python3-saml/pull/21","diff_url":"https://github.com/onelogin/python3-saml/pull/21.diff","patch_url":"https://github.com/onelogin/python3-saml/pull/21.patch","issue_url":"https://api.github.com/repos/onelogin/python3-saml/issues/21","number":21,"state":"open","locked":false,"title":"IdP metadata parser/merger adjustments","user":{"login":"jgehrcke","id":265630,"avatar_url":"https://avatars.githubusercontent.com/u/265630?v=3","gravatar_id":"","url":"https://api.github.com/users/jgehrcke","html_url":"https://github.com/jgehrcke","followers_url":"https://api.github.com/users/jgehrcke/followers","following_url":"https://api.github.com/users/jgehrcke/following{/other_user}","gists_url":"https://api.github.com/users/jgehrcke/gists{/gist_id}","starred_url":"https://api.github.com/users/jgehrcke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgehrcke/subscriptions","organizations_url":"https://api.github.com/users/jgehrcke/orgs","repos_url":"https://api.github.com/users/jgehrcke/repos","events_url":"https://api.github.com/users/jgehrcke/events{/privacy}","received_events_url":"https://api.github.com/users/jgehrcke/received_events","type":"User","site_admin":false},"body":"This tackles the following issues:\r\n* https://github.com/onelogin/python3-saml/issues/17\r\n* https://github.com/onelogin/python3-saml/issues/18\r\n* https://github.com/onelogin/python3-saml/issues/19\r\n* https://github.com/onelogin/python3-saml/issues/20\r\n\r\n@pitbulk I hope these are good for you :-) While I needed to touch the tests quite a lot, this new behavior should still be backwards-compatible.","created_at":"2016-05-06T14:15:09Z","updated_at":"2016-05-06T15:14:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e9b3b04a6cf7a3f3ab7caa68e7912c2853d2cf5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/onelogin/python3-saml/pulls/21/commits","review_comments_url":"https://api.github.com/repos/onelogin/python3-saml/pulls/21/comments","review_comment_url":"https://api.github.com/repos/onelogin/python3-saml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onelogin/python3-saml/issues/21/comments","statuses_url":"https://api.github.com/repos/onelogin/python3-saml/statuses/c052be9cec3dda5bf081811835c93c0a3f3010d1","head":{"label":"jgehrcke:jp/fixparser2","ref":"jp/fixparser2","sha":"c052be9cec3dda5bf081811835c93c0a3f3010d1","user":{"login":"jgehrcke","id":265630,"avatar_url":"https://avatars.githubusercontent.com/u/265630?v=3","gravatar_id":"","url":"https://api.github.com/users/jgehrcke","html_url":"https://github.com/jgehrcke","followers_url":"https://api.github.com/users/jgehrcke/followers","following_url":"https://api.github.com/users/jgehrcke/following{/other_user}","gists_url":"https://api.github.com/users/jgehrcke/gists{/gist_id}","starred_url":"https://api.github.com/users/jgehrcke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgehrcke/subscriptions","organizations_url":"https://api.github.com/users/jgehrcke/orgs","repos_url":"https://api.github.com/users/jgehrcke/repos","events_url":"https://api.github.com/users/jgehrcke/events{/privacy}","received_events_url":"https://api.github.com/users/jgehrcke/received_events","type":"User","site_admin":false},"repo":{"id":57305896,"name":"python3-saml","full_name":"jgehrcke/python3-saml","owner":{"login":"jgehrcke","id":265630,"avatar_url":"https://avatars.githubusercontent.com/u/265630?v=3","gravatar_id":"","url":"https://api.github.com/users/jgehrcke","html_url":"https://github.com/jgehrcke","followers_url":"https://api.github.com/users/jgehrcke/followers","following_url":"https://api.github.com/users/jgehrcke/following{/other_user}","gists_url":"https://api.github.com/users/jgehrcke/gists{/gist_id}","starred_url":"https://api.github.com/users/jgehrcke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgehrcke/subscriptions","organizations_url":"https://api.github.com/users/jgehrcke/orgs","repos_url":"https://api.github.com/users/jgehrcke/repos","events_url":"https://api.github.com/users/jgehrcke/events{/privacy}","received_events_url":"https://api.github.com/users/jgehrcke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgehrcke/python3-saml","description":"","fork":true,"url":"https://api.github.com/repos/jgehrcke/python3-saml","forks_url":"https://api.github.com/repos/jgehrcke/python3-saml/forks","keys_url":"https://api.github.com/repos/jgehrcke/python3-saml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgehrcke/python3-saml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgehrcke/python3-saml/teams","hooks_url":"https://api.github.com/repos/jgehrcke/python3-saml/hooks","issue_events_url":"https://api.github.com/repos/jgehrcke/python3-saml/issues/events{/number}","events_url":"https://api.github.com/repos/jgehrcke/python3-saml/events","assignees_url":"https://api.github.com/repos/jgehrcke/python3-saml/assignees{/user}","branches_url":"https://api.github.com/repos/jgehrcke/python3-saml/branches{/branch}","tags_url":"https://api.github.com/repos/jgehrcke/python3-saml/tags","blobs_url":"https://api.github.com/repos/jgehrcke/python3-saml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgehrcke/python3-saml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgehrcke/python3-saml/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgehrcke/python3-saml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgehrcke/python3-saml/statuses/{sha}","languages_url":"https://api.github.com/repos/jgehrcke/python3-saml/languages","stargazers_url":"https://api.github.com/repos/jgehrcke/python3-saml/stargazers","contributors_url":"https://api.github.com/repos/jgehrcke/python3-saml/contributors","subscribers_url":"https://api.github.com/repos/jgehrcke/python3-saml/subscribers","subscription_url":"https://api.github.com/repos/jgehrcke/python3-saml/subscription","commits_url":"https://api.github.com/repos/jgehrcke/python3-saml/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgehrcke/python3-saml/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgehrcke/python3-saml/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgehrcke/python3-saml/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgehrcke/python3-saml/contents/{+path}","compare_url":"https://api.github.com/repos/jgehrcke/python3-saml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgehrcke/python3-saml/merges","archive_url":"https://api.github.com/repos/jgehrcke/python3-saml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgehrcke/python3-saml/downloads","issues_url":"https://api.github.com/repos/jgehrcke/python3-saml/issues{/number}","pulls_url":"https://api.github.com/repos/jgehrcke/python3-saml/pulls{/number}","milestones_url":"https://api.github.com/repos/jgehrcke/python3-saml/milestones{/number}","notifications_url":"https://api.github.com/repos/jgehrcke/python3-saml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgehrcke/python3-saml/labels{/name}","releases_url":"https://api.github.com/repos/jgehrcke/python3-saml/releases{/id}","deployments_url":"https://api.github.com/repos/jgehrcke/python3-saml/deployments","created_at":"2016-04-28T13:56:14Z","updated_at":"2016-04-28T13:56:15Z","pushed_at":"2016-05-06T14:13:53Z","git_url":"git://github.com/jgehrcke/python3-saml.git","ssh_url":"git@github.com:jgehrcke/python3-saml.git","clone_url":"https://github.com/jgehrcke/python3-saml.git","svn_url":"https://github.com/jgehrcke/python3-saml","homepage":null,"size":786,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"onelogin:master","ref":"master","sha":"43ff77816a7182d5d4fa970eb0b247808f975e9c","user":{"login":"onelogin","id":263373,"avatar_url":"https://avatars.githubusercontent.com/u/263373?v=3","gravatar_id":"","url":"https://api.github.com/users/onelogin","html_url":"https://github.com/onelogin","followers_url":"https://api.github.com/users/onelogin/followers","following_url":"https://api.github.com/users/onelogin/following{/other_user}","gists_url":"https://api.github.com/users/onelogin/gists{/gist_id}","starred_url":"https://api.github.com/users/onelogin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onelogin/subscriptions","organizations_url":"https://api.github.com/users/onelogin/orgs","repos_url":"https://api.github.com/users/onelogin/repos","events_url":"https://api.github.com/users/onelogin/events{/privacy}","received_events_url":"https://api.github.com/users/onelogin/received_events","type":"Organization","site_admin":false},"repo":{"id":40724726,"name":"python3-saml","full_name":"onelogin/python3-saml","owner":{"login":"onelogin","id":263373,"avatar_url":"https://avatars.githubusercontent.com/u/263373?v=3","gravatar_id":"","url":"https://api.github.com/users/onelogin","html_url":"https://github.com/onelogin","followers_url":"https://api.github.com/users/onelogin/followers","following_url":"https://api.github.com/users/onelogin/following{/other_user}","gists_url":"https://api.github.com/users/onelogin/gists{/gist_id}","starred_url":"https://api.github.com/users/onelogin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onelogin/subscriptions","organizations_url":"https://api.github.com/users/onelogin/orgs","repos_url":"https://api.github.com/users/onelogin/repos","events_url":"https://api.github.com/users/onelogin/events{/privacy}","received_events_url":"https://api.github.com/users/onelogin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onelogin/python3-saml","description":"","fork":false,"url":"https://api.github.com/repos/onelogin/python3-saml","forks_url":"https://api.github.com/repos/onelogin/python3-saml/forks","keys_url":"https://api.github.com/repos/onelogin/python3-saml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onelogin/python3-saml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onelogin/python3-saml/teams","hooks_url":"https://api.github.com/repos/onelogin/python3-saml/hooks","issue_events_url":"https://api.github.com/repos/onelogin/python3-saml/issues/events{/number}","events_url":"https://api.github.com/repos/onelogin/python3-saml/events","assignees_url":"https://api.github.com/repos/onelogin/python3-saml/assignees{/user}","branches_url":"https://api.github.com/repos/onelogin/python3-saml/branches{/branch}","tags_url":"https://api.github.com/repos/onelogin/python3-saml/tags","blobs_url":"https://api.github.com/repos/onelogin/python3-saml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onelogin/python3-saml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onelogin/python3-saml/git/refs{/sha}","trees_url":"https://api.github.com/repos/onelogin/python3-saml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onelogin/python3-saml/statuses/{sha}","languages_url":"https://api.github.com/repos/onelogin/python3-saml/languages","stargazers_url":"https://api.github.com/repos/onelogin/python3-saml/stargazers","contributors_url":"https://api.github.com/repos/onelogin/python3-saml/contributors","subscribers_url":"https://api.github.com/repos/onelogin/python3-saml/subscribers","subscription_url":"https://api.github.com/repos/onelogin/python3-saml/subscription","commits_url":"https://api.github.com/repos/onelogin/python3-saml/commits{/sha}","git_commits_url":"https://api.github.com/repos/onelogin/python3-saml/git/commits{/sha}","comments_url":"https://api.github.com/repos/onelogin/python3-saml/comments{/number}","issue_comment_url":"https://api.github.com/repos/onelogin/python3-saml/issues/comments{/number}","contents_url":"https://api.github.com/repos/onelogin/python3-saml/contents/{+path}","compare_url":"https://api.github.com/repos/onelogin/python3-saml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onelogin/python3-saml/merges","archive_url":"https://api.github.com/repos/onelogin/python3-saml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onelogin/python3-saml/downloads","issues_url":"https://api.github.com/repos/onelogin/python3-saml/issues{/number}","pulls_url":"https://api.github.com/repos/onelogin/python3-saml/pulls{/number}","milestones_url":"https://api.github.com/repos/onelogin/python3-saml/milestones{/number}","notifications_url":"https://api.github.com/repos/onelogin/python3-saml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onelogin/python3-saml/labels{/name}","releases_url":"https://api.github.com/repos/onelogin/python3-saml/releases{/id}","deployments_url":"https://api.github.com/repos/onelogin/python3-saml/deployments","created_at":"2015-08-14T16:24:22Z","updated_at":"2016-05-03T12:22:27Z","pushed_at":"2016-05-06T14:15:09Z","git_url":"git://github.com/onelogin/python3-saml.git","ssh_url":"git@github.com:onelogin/python3-saml.git","clone_url":"https://github.com/onelogin/python3-saml.git","svn_url":"https://github.com/onelogin/python3-saml","homepage":null,"size":780,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":5,"forks":11,"open_issues":5,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onelogin/python3-saml/pulls/21"},"html":{"href":"https://github.com/onelogin/python3-saml/pull/21"},"issue":{"href":"https://api.github.com/repos/onelogin/python3-saml/issues/21"},"comments":{"href":"https://api.github.com/repos/onelogin/python3-saml/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/onelogin/python3-saml/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/onelogin/python3-saml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onelogin/python3-saml/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/onelogin/python3-saml/statuses/c052be9cec3dda5bf081811835c93c0a3f3010d1"}}}}