{"action":"closed","number":12792,"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/12792","id":93206019,"html_url":"https://github.com/angular/angular/pull/12792","diff_url":"https://github.com/angular/angular/pull/12792.diff","patch_url":"https://github.com/angular/angular/pull/12792.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/12792","number":12792,"state":"closed","locked":false,"title":"refactor(compiler): add `span` to `TemplateBinding`","user":{"login":"chuckjaz","id":372013,"avatar_url":"https://avatars.githubusercontent.com/u/372013?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckjaz","html_url":"https://github.com/chuckjaz","followers_url":"https://api.github.com/users/chuckjaz/followers","following_url":"https://api.github.com/users/chuckjaz/following{/other_user}","gists_url":"https://api.github.com/users/chuckjaz/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckjaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckjaz/subscriptions","organizations_url":"https://api.github.com/users/chuckjaz/orgs","repos_url":"https://api.github.com/users/chuckjaz/repos","events_url":"https://api.github.com/users/chuckjaz/events{/privacy}","received_events_url":"https://api.github.com/users/chuckjaz/received_events","type":"User","site_admin":false},"body":"**What kind of change does this PR introduce?** (check one with \"x\")\r\n```\r\n[x] Refactoring (no functional changes, no api changes)\r\n```\r\n\r\n**What is the current behavior?** (You can also link to an open issue here)\r\n\r\nThe internal type `TemplateBinding` does have a `span` making it difficult to determine where the expressions are in the source string.\r\n\r\n**What is the new behavior?**\r\n\r\nThe `TemplateBinding` type has a `span`.\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n\r\n**Other information**:\r\n\r\nfix(compiler): corrected error location for implicit templates expressions","created_at":"2016-11-10T18:35:51Z","updated_at":"2016-11-10T21:15:10Z","closed_at":"2016-11-10T21:15:09Z","merged_at":"2016-11-10T21:15:09Z","merge_commit_sha":"c3c0e2e2a20efd1417d9286cd8922635220f7b4e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/12792/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/12792/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/12792/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/02f431be74b373e621feb095359ac84d09251f25","head":{"label":"chuckjaz:ls-binding-span","ref":"ls-binding-span","sha":"02f431be74b373e621feb095359ac84d09251f25","user":{"login":"chuckjaz","id":372013,"avatar_url":"https://avatars.githubusercontent.com/u/372013?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckjaz","html_url":"https://github.com/chuckjaz","followers_url":"https://api.github.com/users/chuckjaz/followers","following_url":"https://api.github.com/users/chuckjaz/following{/other_user}","gists_url":"https://api.github.com/users/chuckjaz/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckjaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckjaz/subscriptions","organizations_url":"https://api.github.com/users/chuckjaz/orgs","repos_url":"https://api.github.com/users/chuckjaz/repos","events_url":"https://api.github.com/users/chuckjaz/events{/privacy}","received_events_url":"https://api.github.com/users/chuckjaz/received_events","type":"User","site_admin":false},"repo":{"id":50690962,"name":"angular","full_name":"chuckjaz/angular","owner":{"login":"chuckjaz","id":372013,"avatar_url":"https://avatars.githubusercontent.com/u/372013?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckjaz","html_url":"https://github.com/chuckjaz","followers_url":"https://api.github.com/users/chuckjaz/followers","following_url":"https://api.github.com/users/chuckjaz/following{/other_user}","gists_url":"https://api.github.com/users/chuckjaz/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckjaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckjaz/subscriptions","organizations_url":"https://api.github.com/users/chuckjaz/orgs","repos_url":"https://api.github.com/users/chuckjaz/repos","events_url":"https://api.github.com/users/chuckjaz/events{/privacy}","received_events_url":"https://api.github.com/users/chuckjaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chuckjaz/angular","description":null,"fork":true,"url":"https://api.github.com/repos/chuckjaz/angular","forks_url":"https://api.github.com/repos/chuckjaz/angular/forks","keys_url":"https://api.github.com/repos/chuckjaz/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chuckjaz/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chuckjaz/angular/teams","hooks_url":"https://api.github.com/repos/chuckjaz/angular/hooks","issue_events_url":"https://api.github.com/repos/chuckjaz/angular/issues/events{/number}","events_url":"https://api.github.com/repos/chuckjaz/angular/events","assignees_url":"https://api.github.com/repos/chuckjaz/angular/assignees{/user}","branches_url":"https://api.github.com/repos/chuckjaz/angular/branches{/branch}","tags_url":"https://api.github.com/repos/chuckjaz/angular/tags","blobs_url":"https://api.github.com/repos/chuckjaz/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chuckjaz/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chuckjaz/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/chuckjaz/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chuckjaz/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/chuckjaz/angular/languages","stargazers_url":"https://api.github.com/repos/chuckjaz/angular/stargazers","contributors_url":"https://api.github.com/repos/chuckjaz/angular/contributors","subscribers_url":"https://api.github.com/repos/chuckjaz/angular/subscribers","subscription_url":"https://api.github.com/repos/chuckjaz/angular/subscription","commits_url":"https://api.github.com/repos/chuckjaz/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/chuckjaz/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/chuckjaz/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/chuckjaz/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/chuckjaz/angular/contents/{+path}","compare_url":"https://api.github.com/repos/chuckjaz/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chuckjaz/angular/merges","archive_url":"https://api.github.com/repos/chuckjaz/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chuckjaz/angular/downloads","issues_url":"https://api.github.com/repos/chuckjaz/angular/issues{/number}","pulls_url":"https://api.github.com/repos/chuckjaz/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/chuckjaz/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/chuckjaz/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chuckjaz/angular/labels{/name}","releases_url":"https://api.github.com/repos/chuckjaz/angular/releases{/id}","deployments_url":"https://api.github.com/repos/chuckjaz/angular/deployments","created_at":"2016-01-29T21:00:52Z","updated_at":"2016-01-29T21:01:07Z","pushed_at":"2016-11-10T19:52:18Z","git_url":"git://github.com/chuckjaz/angular.git","ssh_url":"git@github.com:chuckjaz/angular.git","clone_url":"https://github.com/chuckjaz/angular.git","svn_url":"https://github.com/chuckjaz/angular","homepage":"https://angular.io","size":146970,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"7cab30f85dd778ff4a26a4ca8c57ca24db17b81f","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":null,"fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2016-11-10T21:04:05Z","pushed_at":"2016-11-10T21:15:10Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":650448,"stargazers_count":18027,"watchers_count":18027,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4580,"mirror_url":null,"open_issues_count":888,"forks":4580,"open_issues":888,"watchers":18027,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/12792"},"html":{"href":"https://github.com/angular/angular/pull/12792"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/12792"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/12792/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/12792/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/12792/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/02f431be74b373e621feb095359ac84d09251f25"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"comments":0,"review_comments":6,"commits":1,"additions":63,"deletions":19,"changed_files":6}}
{"actor":{"display_login":"vicb"}}