{"action":"created","comment":{"url":"https://api.github.com/repos/rhtconsulting/rhc-ose/pulls/comments/60631342","id":60631342,"diff_hunk":"@@ -12,6 +12,33 @@ openstack_key_name=\"\"\n #openshift_openstack_master_storage_size: 10\n #openshift_openstack_node_storage_size: 10\n \n+#env_id=\n+rhc_ose_inv_dest=.\n+rhc_ose_cluster_method=native\n+rhc_ose_cluster_public_hostname=public.hostname.com\n+rhc_ose_cluster_hostname=hostname.com\n+#rhc_ose_ssh_user=root\n+#rhc_ose_identity_provider=htpasswd\n+deployment_type=openshift-enterprise\n+\n+#Openshift Components\n+rhc_ose_enable_efk=true                  #If E-F-K logging stack should be deployed","path":"rhc-ose-ansible/inventory/ose-provision","position":14,"original_position":14,"commit_id":"d99bab594a4712ccf77d3f8f46756491f05f9864","original_commit_id":"d99bab594a4712ccf77d3f8f46756491f05f9864","user":{"login":"etsauer","id":4500758,"avatar_url":"https://avatars.githubusercontent.com/u/4500758?v=3","gravatar_id":"","url":"https://api.github.com/users/etsauer","html_url":"https://github.com/etsauer","followers_url":"https://api.github.com/users/etsauer/followers","following_url":"https://api.github.com/users/etsauer/following{/other_user}","gists_url":"https://api.github.com/users/etsauer/gists{/gist_id}","starred_url":"https://api.github.com/users/etsauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etsauer/subscriptions","organizations_url":"https://api.github.com/users/etsauer/orgs","repos_url":"https://api.github.com/users/etsauer/repos","events_url":"https://api.github.com/users/etsauer/events{/privacy}","received_events_url":"https://api.github.com/users/etsauer/received_events","type":"User","site_admin":false},"body":"can we just use the standard vars from openshift-ansible for this? i.e. https://github.com/openshift/openshift-ansible/tree/master/playbooks/adhoc/metrics_setup","created_at":"2016-04-21T18:25:02Z","updated_at":"2016-04-21T18:25:02Z","html_url":"https://github.com/rhtconsulting/rhc-ose/pull/155#discussion_r60631342","pull_request_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/pulls/155","_links":{"self":{"href":"https://api.github.com/repos/rhtconsulting/rhc-ose/pulls/comments/60631342"},"html":{"href":"https://github.com/rhtconsulting/rhc-ose/pull/155#discussion_r60631342"},"pull_request":{"href":"https://api.github.com/repos/rhtconsulting/rhc-ose/pulls/155"}}},"pull_request":{"url":"https://api.github.com/repos/rhtconsulting/rhc-ose/pulls/155","id":67398559,"html_url":"https://github.com/rhtconsulting/rhc-ose/pull/155","diff_url":"https://github.com/rhtconsulting/rhc-ose/pull/155.diff","patch_url":"https://github.com/rhtconsulting/rhc-ose/pull/155.patch","issue_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/issues/155","number":155,"state":"open","locked":false,"title":"openshift components playbook","user":{"login":"JayKayy","id":4761608,"avatar_url":"https://avatars.githubusercontent.com/u/4761608?v=3","gravatar_id":"","url":"https://api.github.com/users/JayKayy","html_url":"https://github.com/JayKayy","followers_url":"https://api.github.com/users/JayKayy/followers","following_url":"https://api.github.com/users/JayKayy/following{/other_user}","gists_url":"https://api.github.com/users/JayKayy/gists{/gist_id}","starred_url":"https://api.github.com/users/JayKayy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayKayy/subscriptions","organizations_url":"https://api.github.com/users/JayKayy/orgs","repos_url":"https://api.github.com/users/JayKayy/repos","events_url":"https://api.github.com/users/JayKayy/events{/privacy}","received_events_url":"https://api.github.com/users/JayKayy/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nAdds a playbook to tie in optional metrics and logging OSE components.(Other roles can be added in the future). This also adds all the necessary varibales for logging and metrics to the ose-provision inventory file\r\n\r\n#### How should this be manually tested?\r\nThis is simply a 5-line playbook that conditionally ties in two already tested roles from openshift-ansible repo\r\n\r\n#### Is there a relevant Issue open for this?\r\nN/A\r\n\r\n#### Who would you like to review this?\r\n/cc @etsauer  @oybed @sabre1041 ","created_at":"2016-04-21T18:15:18Z","updated_at":"2016-04-21T18:25:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/pulls/155/commits","review_comments_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/pulls/155/comments","review_comment_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/issues/155/comments","statuses_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/statuses/d99bab594a4712ccf77d3f8f46756491f05f9864","head":{"label":"JayKayy:openshift-components","ref":"openshift-components","sha":"d99bab594a4712ccf77d3f8f46756491f05f9864","user":{"login":"JayKayy","id":4761608,"avatar_url":"https://avatars.githubusercontent.com/u/4761608?v=3","gravatar_id":"","url":"https://api.github.com/users/JayKayy","html_url":"https://github.com/JayKayy","followers_url":"https://api.github.com/users/JayKayy/followers","following_url":"https://api.github.com/users/JayKayy/following{/other_user}","gists_url":"https://api.github.com/users/JayKayy/gists{/gist_id}","starred_url":"https://api.github.com/users/JayKayy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayKayy/subscriptions","organizations_url":"https://api.github.com/users/JayKayy/orgs","repos_url":"https://api.github.com/users/JayKayy/repos","events_url":"https://api.github.com/users/JayKayy/events{/privacy}","received_events_url":"https://api.github.com/users/JayKayy/received_events","type":"User","site_admin":false},"repo":{"id":52292911,"name":"rhc-ose","full_name":"JayKayy/rhc-ose","owner":{"login":"JayKayy","id":4761608,"avatar_url":"https://avatars.githubusercontent.com/u/4761608?v=3","gravatar_id":"","url":"https://api.github.com/users/JayKayy","html_url":"https://github.com/JayKayy","followers_url":"https://api.github.com/users/JayKayy/followers","following_url":"https://api.github.com/users/JayKayy/following{/other_user}","gists_url":"https://api.github.com/users/JayKayy/gists{/gist_id}","starred_url":"https://api.github.com/users/JayKayy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayKayy/subscriptions","organizations_url":"https://api.github.com/users/JayKayy/orgs","repos_url":"https://api.github.com/users/JayKayy/repos","events_url":"https://api.github.com/users/JayKayy/events{/privacy}","received_events_url":"https://api.github.com/users/JayKayy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JayKayy/rhc-ose","description":"OpenShift Automation and Utilities by Red Hat Consulting","fork":true,"url":"https://api.github.com/repos/JayKayy/rhc-ose","forks_url":"https://api.github.com/repos/JayKayy/rhc-ose/forks","keys_url":"https://api.github.com/repos/JayKayy/rhc-ose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JayKayy/rhc-ose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JayKayy/rhc-ose/teams","hooks_url":"https://api.github.com/repos/JayKayy/rhc-ose/hooks","issue_events_url":"https://api.github.com/repos/JayKayy/rhc-ose/issues/events{/number}","events_url":"https://api.github.com/repos/JayKayy/rhc-ose/events","assignees_url":"https://api.github.com/repos/JayKayy/rhc-ose/assignees{/user}","branches_url":"https://api.github.com/repos/JayKayy/rhc-ose/branches{/branch}","tags_url":"https://api.github.com/repos/JayKayy/rhc-ose/tags","blobs_url":"https://api.github.com/repos/JayKayy/rhc-ose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JayKayy/rhc-ose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JayKayy/rhc-ose/git/refs{/sha}","trees_url":"https://api.github.com/repos/JayKayy/rhc-ose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JayKayy/rhc-ose/statuses/{sha}","languages_url":"https://api.github.com/repos/JayKayy/rhc-ose/languages","stargazers_url":"https://api.github.com/repos/JayKayy/rhc-ose/stargazers","contributors_url":"https://api.github.com/repos/JayKayy/rhc-ose/contributors","subscribers_url":"https://api.github.com/repos/JayKayy/rhc-ose/subscribers","subscription_url":"https://api.github.com/repos/JayKayy/rhc-ose/subscription","commits_url":"https://api.github.com/repos/JayKayy/rhc-ose/commits{/sha}","git_commits_url":"https://api.github.com/repos/JayKayy/rhc-ose/git/commits{/sha}","comments_url":"https://api.github.com/repos/JayKayy/rhc-ose/comments{/number}","issue_comment_url":"https://api.github.com/repos/JayKayy/rhc-ose/issues/comments{/number}","contents_url":"https://api.github.com/repos/JayKayy/rhc-ose/contents/{+path}","compare_url":"https://api.github.com/repos/JayKayy/rhc-ose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JayKayy/rhc-ose/merges","archive_url":"https://api.github.com/repos/JayKayy/rhc-ose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JayKayy/rhc-ose/downloads","issues_url":"https://api.github.com/repos/JayKayy/rhc-ose/issues{/number}","pulls_url":"https://api.github.com/repos/JayKayy/rhc-ose/pulls{/number}","milestones_url":"https://api.github.com/repos/JayKayy/rhc-ose/milestones{/number}","notifications_url":"https://api.github.com/repos/JayKayy/rhc-ose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JayKayy/rhc-ose/labels{/name}","releases_url":"https://api.github.com/repos/JayKayy/rhc-ose/releases{/id}","deployments_url":"https://api.github.com/repos/JayKayy/rhc-ose/deployments","created_at":"2016-02-22T17:51:39Z","updated_at":"2016-02-22T17:51:40Z","pushed_at":"2016-04-21T18:12:08Z","git_url":"git://github.com/JayKayy/rhc-ose.git","ssh_url":"git@github.com:JayKayy/rhc-ose.git","clone_url":"https://github.com/JayKayy/rhc-ose.git","svn_url":"https://github.com/JayKayy/rhc-ose","homepage":null,"size":11142,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"openshift-enterprise-3"}},"base":{"label":"rhtconsulting:openshift-enterprise-3","ref":"openshift-enterprise-3","sha":"c9108b7bfeabab8f88ecc00ab25e97d4a4d4bf41","user":{"login":"rhtconsulting","id":11352795,"avatar_url":"https://avatars.githubusercontent.com/u/11352795?v=3","gravatar_id":"","url":"https://api.github.com/users/rhtconsulting","html_url":"https://github.com/rhtconsulting","followers_url":"https://api.github.com/users/rhtconsulting/followers","following_url":"https://api.github.com/users/rhtconsulting/following{/other_user}","gists_url":"https://api.github.com/users/rhtconsulting/gists{/gist_id}","starred_url":"https://api.github.com/users/rhtconsulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhtconsulting/subscriptions","organizations_url":"https://api.github.com/users/rhtconsulting/orgs","repos_url":"https://api.github.com/users/rhtconsulting/repos","events_url":"https://api.github.com/users/rhtconsulting/events{/privacy}","received_events_url":"https://api.github.com/users/rhtconsulting/received_events","type":"Organization","site_admin":false},"repo":{"id":41885529,"name":"rhc-ose","full_name":"rhtconsulting/rhc-ose","owner":{"login":"rhtconsulting","id":11352795,"avatar_url":"https://avatars.githubusercontent.com/u/11352795?v=3","gravatar_id":"","url":"https://api.github.com/users/rhtconsulting","html_url":"https://github.com/rhtconsulting","followers_url":"https://api.github.com/users/rhtconsulting/followers","following_url":"https://api.github.com/users/rhtconsulting/following{/other_user}","gists_url":"https://api.github.com/users/rhtconsulting/gists{/gist_id}","starred_url":"https://api.github.com/users/rhtconsulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhtconsulting/subscriptions","organizations_url":"https://api.github.com/users/rhtconsulting/orgs","repos_url":"https://api.github.com/users/rhtconsulting/repos","events_url":"https://api.github.com/users/rhtconsulting/events{/privacy}","received_events_url":"https://api.github.com/users/rhtconsulting/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rhtconsulting/rhc-ose","description":"OpenShift Automation and Utilities by Red Hat Consulting","fork":false,"url":"https://api.github.com/repos/rhtconsulting/rhc-ose","forks_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/forks","keys_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/teams","hooks_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/hooks","issue_events_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/issues/events{/number}","events_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/events","assignees_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/assignees{/user}","branches_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/branches{/branch}","tags_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/tags","blobs_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/statuses/{sha}","languages_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/languages","stargazers_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/stargazers","contributors_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/contributors","subscribers_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/subscribers","subscription_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/subscription","commits_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/contents/{+path}","compare_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/merges","archive_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/downloads","issues_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/issues{/number}","pulls_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/pulls{/number}","milestones_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/milestones{/number}","notifications_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/labels{/name}","releases_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/releases{/id}","deployments_url":"https://api.github.com/repos/rhtconsulting/rhc-ose/deployments","created_at":"2015-09-03T21:49:55Z","updated_at":"2016-03-18T10:14:16Z","pushed_at":"2016-04-21T18:15:18Z","git_url":"git://github.com/rhtconsulting/rhc-ose.git","ssh_url":"git@github.com:rhtconsulting/rhc-ose.git","clone_url":"https://github.com/rhtconsulting/rhc-ose.git","svn_url":"https://github.com/rhtconsulting/rhc-ose","homepage":null,"size":11188,"stargazers_count":11,"watchers_count":11,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":26,"forks":19,"open_issues":26,"watchers":11,"default_branch":"openshift-enterprise-3"}},"_links":{"self":{"href":"https://api.github.com/repos/rhtconsulting/rhc-ose/pulls/155"},"html":{"href":"https://github.com/rhtconsulting/rhc-ose/pull/155"},"issue":{"href":"https://api.github.com/repos/rhtconsulting/rhc-ose/issues/155"},"comments":{"href":"https://api.github.com/repos/rhtconsulting/rhc-ose/issues/155/comments"},"review_comments":{"href":"https://api.github.com/repos/rhtconsulting/rhc-ose/pulls/155/comments"},"review_comment":{"href":"https://api.github.com/repos/rhtconsulting/rhc-ose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rhtconsulting/rhc-ose/pulls/155/commits"},"statuses":{"href":"https://api.github.com/repos/rhtconsulting/rhc-ose/statuses/d99bab594a4712ccf77d3f8f46756491f05f9864"}}}}