{"action":"opened","number":2317,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/2317","id":71574503,"html_url":"https://github.com/ansible/ansible-modules-extras/pull/2317","diff_url":"https://github.com/ansible/ansible-modules-extras/pull/2317.diff","patch_url":"https://github.com/ansible/ansible-modules-extras/pull/2317.patch","issue_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/2317","number":2317,"state":"open","locked":false,"title":"added s3 download support to maven module","user":{"login":"gedl","id":5488974,"avatar_url":"https://avatars.githubusercontent.com/u/5488974?v=3","gravatar_id":"","url":"https://api.github.com/users/gedl","html_url":"https://github.com/gedl","followers_url":"https://api.github.com/users/gedl/followers","following_url":"https://api.github.com/users/gedl/following{/other_user}","gists_url":"https://api.github.com/users/gedl/gists{/gist_id}","starred_url":"https://api.github.com/users/gedl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gedl/subscriptions","organizations_url":"https://api.github.com/users/gedl/orgs","repos_url":"https://api.github.com/users/gedl/repos","events_url":"https://api.github.com/users/gedl/events{/privacy}","received_events_url":"https://api.github.com/users/gedl/received_events","type":"User","site_admin":false},"body":"##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Feature Pull Request\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the plugin/module/task  -->\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.1.0\r\n  config file = \r\n  configured module search path = Default w/o overrides\r\n```\r\n\r\n##### SUMMARY\r\nAdded S3 support for maven_artifact \r\nRe-used all http fetch logic. The S3 supported was added through means of generating a temporary HTTP download, that is passed to the pre-existing HTTP get flow\r\nNo changes in the command output or existing behaviour. The new S3 download behaviour is exactly the same as the pre-existing one.\r\n\r\n(I messed up with the previous pull request)\r\n\r\n* Example configuration:\r\n```\r\n- hosts: localhost\r\n  tasks:\r\n    - name: download artifact if absent\r\n      maven_artifact:\r\n        group_id: com.something.somethingelse\r\n        artifact_id: myartifact\r\n        version: \"latest\"\r\n        dest: \"/tmp\"\r\n        repository_url: \"s3://<redacted>.s3.amazonaws.com/dev\"\r\n        aws_secret_key: <redacted>\r\n        aws_secret_access_key: <redacted>\r\n        extension: war\r\n      register: artifact\r\n    - debug: var=artifact\r\n```\r\n\r\n* Result (artifact already existed locally)\r\n```\r\nok: [localhost] => {\r\n    \"artifact\": {\r\n        \"changed\": false, \r\n        \"dest\": \"/tmp/myartifact-latest.war\", \r\n        \"gid\": 0, \r\n        \"group\": \"wheel\", \r\n        \"mode\": \"0600\", \r\n        \"owner\": \"gluiz\", \r\n        \"size\": 98637847, \r\n        \"state\": \"file\", \r\n        \"uid\": 502\r\n    }\r\n}\r\n```\r\n\r\n* Result (artifact did not exist locally)\r\n```\r\nok: [localhost] => {\r\n    \"artifact\": {\r\n        \"artifact_id\": \"myartifact\", \r\n        \"changed\": true, \r\n        \"classifier\": null, \r\n        \"dest\": \"/tmp/myartifact-latest.war\", \r\n        \"extension\": \"war\", \r\n        \"gid\": 0, \r\n        \"group\": \"wheel\", \r\n        \"group_id\":  com.something.somethingelse\", \r\n        \"mode\": \"0600\", \r\n        \"owner\": \"gluiz\", \r\n        \"repository_url\":  \"s3://<redacted>.s3.amazonaws.com/dev\", \r\n        \"size\": 98637847, \r\n        \"state\": \"file\", \r\n        \"uid\": 502, \r\n        \"version\": \"latest\"\r\n    }\r\n}\r\n```","created_at":"2016-05-26T15:21:24Z","updated_at":"2016-05-26T15:21:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/2317/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/2317/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/2317/comments","statuses_url":"https://api.github.com/repos/ansible/ansible-modules-extras/statuses/467b0ad274eecd381bf9567817c5b00b67a2c3d1","head":{"label":"gedl:maven-s3-download","ref":"maven-s3-download","sha":"467b0ad274eecd381bf9567817c5b00b67a2c3d1","user":{"login":"gedl","id":5488974,"avatar_url":"https://avatars.githubusercontent.com/u/5488974?v=3","gravatar_id":"","url":"https://api.github.com/users/gedl","html_url":"https://github.com/gedl","followers_url":"https://api.github.com/users/gedl/followers","following_url":"https://api.github.com/users/gedl/following{/other_user}","gists_url":"https://api.github.com/users/gedl/gists{/gist_id}","starred_url":"https://api.github.com/users/gedl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gedl/subscriptions","organizations_url":"https://api.github.com/users/gedl/orgs","repos_url":"https://api.github.com/users/gedl/repos","events_url":"https://api.github.com/users/gedl/events{/privacy}","received_events_url":"https://api.github.com/users/gedl/received_events","type":"User","site_admin":false},"repo":{"id":57221943,"name":"ansible-modules-extras","full_name":"gedl/ansible-modules-extras","owner":{"login":"gedl","id":5488974,"avatar_url":"https://avatars.githubusercontent.com/u/5488974?v=3","gravatar_id":"","url":"https://api.github.com/users/gedl","html_url":"https://github.com/gedl","followers_url":"https://api.github.com/users/gedl/followers","following_url":"https://api.github.com/users/gedl/following{/other_user}","gists_url":"https://api.github.com/users/gedl/gists{/gist_id}","starred_url":"https://api.github.com/users/gedl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gedl/subscriptions","organizations_url":"https://api.github.com/users/gedl/orgs","repos_url":"https://api.github.com/users/gedl/repos","events_url":"https://api.github.com/users/gedl/events{/privacy}","received_events_url":"https://api.github.com/users/gedl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gedl/ansible-modules-extras","description":"Ansible extra modules - these modules ship with ansible","fork":true,"url":"https://api.github.com/repos/gedl/ansible-modules-extras","forks_url":"https://api.github.com/repos/gedl/ansible-modules-extras/forks","keys_url":"https://api.github.com/repos/gedl/ansible-modules-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gedl/ansible-modules-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gedl/ansible-modules-extras/teams","hooks_url":"https://api.github.com/repos/gedl/ansible-modules-extras/hooks","issue_events_url":"https://api.github.com/repos/gedl/ansible-modules-extras/issues/events{/number}","events_url":"https://api.github.com/repos/gedl/ansible-modules-extras/events","assignees_url":"https://api.github.com/repos/gedl/ansible-modules-extras/assignees{/user}","branches_url":"https://api.github.com/repos/gedl/ansible-modules-extras/branches{/branch}","tags_url":"https://api.github.com/repos/gedl/ansible-modules-extras/tags","blobs_url":"https://api.github.com/repos/gedl/ansible-modules-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gedl/ansible-modules-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gedl/ansible-modules-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/gedl/ansible-modules-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gedl/ansible-modules-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/gedl/ansible-modules-extras/languages","stargazers_url":"https://api.github.com/repos/gedl/ansible-modules-extras/stargazers","contributors_url":"https://api.github.com/repos/gedl/ansible-modules-extras/contributors","subscribers_url":"https://api.github.com/repos/gedl/ansible-modules-extras/subscribers","subscription_url":"https://api.github.com/repos/gedl/ansible-modules-extras/subscription","commits_url":"https://api.github.com/repos/gedl/ansible-modules-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/gedl/ansible-modules-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/gedl/ansible-modules-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/gedl/ansible-modules-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/gedl/ansible-modules-extras/contents/{+path}","compare_url":"https://api.github.com/repos/gedl/ansible-modules-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gedl/ansible-modules-extras/merges","archive_url":"https://api.github.com/repos/gedl/ansible-modules-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gedl/ansible-modules-extras/downloads","issues_url":"https://api.github.com/repos/gedl/ansible-modules-extras/issues{/number}","pulls_url":"https://api.github.com/repos/gedl/ansible-modules-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/gedl/ansible-modules-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/gedl/ansible-modules-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gedl/ansible-modules-extras/labels{/name}","releases_url":"https://api.github.com/repos/gedl/ansible-modules-extras/releases{/id}","deployments_url":"https://api.github.com/repos/gedl/ansible-modules-extras/deployments","created_at":"2016-04-27T14:54:33Z","updated_at":"2016-04-27T14:54:38Z","pushed_at":"2016-05-26T15:19:30Z","git_url":"git://github.com/gedl/ansible-modules-extras.git","ssh_url":"git@github.com:gedl/ansible-modules-extras.git","clone_url":"https://github.com/gedl/ansible-modules-extras.git","svn_url":"https://github.com/gedl/ansible-modules-extras","homepage":"","size":7399,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"1ea51b2f99138c88bd32bfcb63c2ec8f9174787b","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":24474138,"name":"ansible-modules-extras","full_name":"ansible/ansible-modules-extras","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible-modules-extras","description":"Ansible extra modules - these modules ship with ansible","fork":false,"url":"https://api.github.com/repos/ansible/ansible-modules-extras","forks_url":"https://api.github.com/repos/ansible/ansible-modules-extras/forks","keys_url":"https://api.github.com/repos/ansible/ansible-modules-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible-modules-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible-modules-extras/teams","hooks_url":"https://api.github.com/repos/ansible/ansible-modules-extras/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible-modules-extras/events","assignees_url":"https://api.github.com/repos/ansible/ansible-modules-extras/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible-modules-extras/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible-modules-extras/tags","blobs_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible-modules-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible-modules-extras/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible-modules-extras/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible-modules-extras/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible-modules-extras/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible-modules-extras/subscription","commits_url":"https://api.github.com/repos/ansible/ansible-modules-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible-modules-extras/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible-modules-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible-modules-extras/merges","archive_url":"https://api.github.com/repos/ansible/ansible-modules-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible-modules-extras/downloads","issues_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible-modules-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible-modules-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible-modules-extras/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/deployments","created_at":"2014-09-25T20:28:42Z","updated_at":"2016-05-25T00:09:22Z","pushed_at":"2016-05-26T15:21:24Z","git_url":"git://github.com/ansible/ansible-modules-extras.git","ssh_url":"git@github.com:ansible/ansible-modules-extras.git","clone_url":"https://github.com/ansible/ansible-modules-extras.git","svn_url":"https://github.com/ansible/ansible-modules-extras","homepage":"","size":14422,"stargazers_count":593,"watchers_count":593,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1225,"mirror_url":null,"open_issues_count":597,"forks":1225,"open_issues":597,"watchers":593,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/2317"},"html":{"href":"https://github.com/ansible/ansible-modules-extras/pull/2317"},"issue":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/2317"},"comments":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/2317/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/2317/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/2317/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/statuses/467b0ad274eecd381bf9567817c5b00b67a2c3d1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":33,"deletions":8,"changed_files":1}}
{"actor":{"display_login":"gedl"}}