{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/juice/issues/223","repository_url":"https://api.github.com/repos/Automattic/juice","labels_url":"https://api.github.com/repos/Automattic/juice/issues/223/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/juice/issues/223/comments","events_url":"https://api.github.com/repos/Automattic/juice/issues/223/events","html_url":"https://github.com/Automattic/juice/pull/223","id":162777626,"number":223,"title":"Refactored code to better \"isolate\" cheerio dependency and enable jquery usage","user":{"login":"bago","id":173498,"avatar_url":"https://avatars.githubusercontent.com/u/173498?v=3","gravatar_id":"","url":"https://api.github.com/users/bago","html_url":"https://github.com/bago","followers_url":"https://api.github.com/users/bago/followers","following_url":"https://api.github.com/users/bago/following{/other_user}","gists_url":"https://api.github.com/users/bago/gists{/gist_id}","starred_url":"https://api.github.com/users/bago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bago/subscriptions","organizations_url":"https://api.github.com/users/bago/orgs","repos_url":"https://api.github.com/users/bago/repos","events_url":"https://api.github.com/users/bago/events{/privacy}","received_events_url":"https://api.github.com/users/bago/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-28T20:20:43Z","updated_at":"2016-06-28T20:30:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/juice/pulls/223","html_url":"https://github.com/Automattic/juice/pull/223","diff_url":"https://github.com/Automattic/juice/pull/223.diff","patch_url":"https://github.com/Automattic/juice/pull/223.patch"},"body":"This is better reviewed as a commit-by-commit changes because a lot of code has been moved between files (from utils.js to cheerio.js and from client.js to lib/inline.js).\r\n\r\nRefactoring let me isolate cheerio so that one can include \"lib/inline.js\" and use core juice features without including cheerio.\r\n\r\nThe real \"changes\" are the use of \".attr('data-embed')\" instead of \".attribs['data-embed']\" and the introdution of a \"options.styleAttributeName\" to change the attribute when the inline styles are read/written."},"comment":{"url":"https://api.github.com/repos/Automattic/juice/issues/comments/229173182","html_url":"https://github.com/Automattic/juice/pull/223#issuecomment-229173182","issue_url":"https://api.github.com/repos/Automattic/juice/issues/223","id":229173182,"user":{"login":"bago","id":173498,"avatar_url":"https://avatars.githubusercontent.com/u/173498?v=3","gravatar_id":"","url":"https://api.github.com/users/bago","html_url":"https://github.com/bago","followers_url":"https://api.github.com/users/bago/followers","following_url":"https://api.github.com/users/bago/following{/other_user}","gists_url":"https://api.github.com/users/bago/gists{/gist_id}","starred_url":"https://api.github.com/users/bago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bago/subscriptions","organizations_url":"https://api.github.com/users/bago/orgs","repos_url":"https://api.github.com/users/bago/repos","events_url":"https://api.github.com/users/bago/events{/privacy}","received_events_url":"https://api.github.com/users/bago/received_events","type":"User","site_admin":false},"created_at":"2016-06-28T20:30:16Z","updated_at":"2016-06-28T20:30:16Z","body":"Please note that the only real change I need in order to integrate with Mosaico is https://github.com/Automattic/juice/pull/223/commits/96ec50ab48ca32dcab40056764fd787367a8b304 \r\n\r\nThe other tasks make it only easier and cleaner to do that and I don't have to create \"subtle\" tricks in order to avoid cheerio being included.\r\n\r\nNow I'm starting to work on Mosaico side and this branch, so to see if this really work as I expect."}}
{"actor":{"display_login":"bago"}}