{"action":"created","comment":{"url":"https://api.github.com/repos/milesburton/finatra/pulls/comments/87470656","pull_request_review_id":8083159,"id":87470656,"diff_hunk":"@@ -404,6 +404,21 @@ post(\"/users\") { request: MyPostRequest =>\n \n For more examples, see the [ResponseBuilderTest](https://github.com/twitter/finatra/blob/develop/http/src/test/scala/com/twitter/finatra/http/tests/response/ResponseBuilderTest.scala).\n \n+When building more complex responses where the subject is a Future[T] you may map the result of a Future to your ResponseBuilder composition. For example:\n+\n+```scala\n+get(\"/users\") { request =>\n+  ...\n+  val userList = Future { List(\"Paul\", \"Scott\") }\n+  \n+  userList.map(users=>\n+    response\n+    .ok(users)","path":"doc/src/octopress/source/user-guide/build-new-http-server/controller.markdown","position":13,"original_position":13,"commit_id":"71b7d7423978a8642ce858d66fec0b38720e79a4","original_commit_id":"71b7d7423978a8642ce858d66fec0b38720e79a4","user":{"login":"AlexITC","id":4218436,"avatar_url":"https://avatars.githubusercontent.com/u/4218436?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexITC","html_url":"https://github.com/AlexITC","followers_url":"https://api.github.com/users/AlexITC/followers","following_url":"https://api.github.com/users/AlexITC/following{/other_user}","gists_url":"https://api.github.com/users/AlexITC/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexITC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexITC/subscriptions","organizations_url":"https://api.github.com/users/AlexITC/orgs","repos_url":"https://api.github.com/users/AlexITC/repos","events_url":"https://api.github.com/users/AlexITC/events{/privacy}","received_events_url":"https://api.github.com/users/AlexITC/received_events","type":"User","site_admin":false},"body":"did you meant 'userList'?","created_at":"2016-11-10T19:42:29Z","updated_at":"2016-11-10T19:42:29Z","html_url":"https://github.com/milesburton/finatra/pull/1#discussion_r87470656","pull_request_url":"https://api.github.com/repos/milesburton/finatra/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/milesburton/finatra/pulls/comments/87470656"},"html":{"href":"https://github.com/milesburton/finatra/pull/1#discussion_r87470656"},"pull_request":{"href":"https://api.github.com/repos/milesburton/finatra/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/milesburton/finatra/pulls/1","id":93155652,"html_url":"https://github.com/milesburton/finatra/pull/1","diff_url":"https://github.com/milesburton/finatra/pull/1.diff","patch_url":"https://github.com/milesburton/finatra/pull/1.patch","issue_url":"https://api.github.com/repos/milesburton/finatra/issues/1","number":1,"state":"closed","locked":false,"title":"Update controller.markdown","user":{"login":"milesburton","id":1205171,"avatar_url":"https://avatars.githubusercontent.com/u/1205171?v=3","gravatar_id":"","url":"https://api.github.com/users/milesburton","html_url":"https://github.com/milesburton","followers_url":"https://api.github.com/users/milesburton/followers","following_url":"https://api.github.com/users/milesburton/following{/other_user}","gists_url":"https://api.github.com/users/milesburton/gists{/gist_id}","starred_url":"https://api.github.com/users/milesburton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milesburton/subscriptions","organizations_url":"https://api.github.com/users/milesburton/orgs","repos_url":"https://api.github.com/users/milesburton/repos","events_url":"https://api.github.com/users/milesburton/events{/privacy}","received_events_url":"https://api.github.com/users/milesburton/received_events","type":"User","site_admin":false},"body":"Problem\r\n\r\nMissing detail on the use of Futures with the ResponseBuilder\r\n\r\nSolution\r\n\r\nAdd more detail to remove ambiguity within documentation\r\n\r\nResult\r\n\r\nAdded additional section to highlight use of ResponseBuilder with Future[T]","created_at":"2016-11-10T14:02:02Z","updated_at":"2016-11-10T19:42:29Z","closed_at":"2016-11-10T18:35:02Z","merged_at":null,"merge_commit_sha":"2740a7c4ddae2486b61cc81793d50aa8c3eb1559","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/milesburton/finatra/pulls/1/commits","review_comments_url":"https://api.github.com/repos/milesburton/finatra/pulls/1/comments","review_comment_url":"https://api.github.com/repos/milesburton/finatra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/milesburton/finatra/issues/1/comments","statuses_url":"https://api.github.com/repos/milesburton/finatra/statuses/71b7d7423978a8642ce858d66fec0b38720e79a4","head":{"label":"milesburton:milesburton-patch-1-1","ref":"milesburton-patch-1-1","sha":"71b7d7423978a8642ce858d66fec0b38720e79a4","user":{"login":"milesburton","id":1205171,"avatar_url":"https://avatars.githubusercontent.com/u/1205171?v=3","gravatar_id":"","url":"https://api.github.com/users/milesburton","html_url":"https://github.com/milesburton","followers_url":"https://api.github.com/users/milesburton/followers","following_url":"https://api.github.com/users/milesburton/following{/other_user}","gists_url":"https://api.github.com/users/milesburton/gists{/gist_id}","starred_url":"https://api.github.com/users/milesburton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milesburton/subscriptions","organizations_url":"https://api.github.com/users/milesburton/orgs","repos_url":"https://api.github.com/users/milesburton/repos","events_url":"https://api.github.com/users/milesburton/events{/privacy}","received_events_url":"https://api.github.com/users/milesburton/received_events","type":"User","site_admin":false},"repo":{"id":73386023,"name":"finatra","full_name":"milesburton/finatra","owner":{"login":"milesburton","id":1205171,"avatar_url":"https://avatars.githubusercontent.com/u/1205171?v=3","gravatar_id":"","url":"https://api.github.com/users/milesburton","html_url":"https://github.com/milesburton","followers_url":"https://api.github.com/users/milesburton/followers","following_url":"https://api.github.com/users/milesburton/following{/other_user}","gists_url":"https://api.github.com/users/milesburton/gists{/gist_id}","starred_url":"https://api.github.com/users/milesburton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milesburton/subscriptions","organizations_url":"https://api.github.com/users/milesburton/orgs","repos_url":"https://api.github.com/users/milesburton/repos","events_url":"https://api.github.com/users/milesburton/events{/privacy}","received_events_url":"https://api.github.com/users/milesburton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/milesburton/finatra","description":"Fast, testable, Scala services built on Twitter-Server and Finagle","fork":true,"url":"https://api.github.com/repos/milesburton/finatra","forks_url":"https://api.github.com/repos/milesburton/finatra/forks","keys_url":"https://api.github.com/repos/milesburton/finatra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/milesburton/finatra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/milesburton/finatra/teams","hooks_url":"https://api.github.com/repos/milesburton/finatra/hooks","issue_events_url":"https://api.github.com/repos/milesburton/finatra/issues/events{/number}","events_url":"https://api.github.com/repos/milesburton/finatra/events","assignees_url":"https://api.github.com/repos/milesburton/finatra/assignees{/user}","branches_url":"https://api.github.com/repos/milesburton/finatra/branches{/branch}","tags_url":"https://api.github.com/repos/milesburton/finatra/tags","blobs_url":"https://api.github.com/repos/milesburton/finatra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/milesburton/finatra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/milesburton/finatra/git/refs{/sha}","trees_url":"https://api.github.com/repos/milesburton/finatra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/milesburton/finatra/statuses/{sha}","languages_url":"https://api.github.com/repos/milesburton/finatra/languages","stargazers_url":"https://api.github.com/repos/milesburton/finatra/stargazers","contributors_url":"https://api.github.com/repos/milesburton/finatra/contributors","subscribers_url":"https://api.github.com/repos/milesburton/finatra/subscribers","subscription_url":"https://api.github.com/repos/milesburton/finatra/subscription","commits_url":"https://api.github.com/repos/milesburton/finatra/commits{/sha}","git_commits_url":"https://api.github.com/repos/milesburton/finatra/git/commits{/sha}","comments_url":"https://api.github.com/repos/milesburton/finatra/comments{/number}","issue_comment_url":"https://api.github.com/repos/milesburton/finatra/issues/comments{/number}","contents_url":"https://api.github.com/repos/milesburton/finatra/contents/{+path}","compare_url":"https://api.github.com/repos/milesburton/finatra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/milesburton/finatra/merges","archive_url":"https://api.github.com/repos/milesburton/finatra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/milesburton/finatra/downloads","issues_url":"https://api.github.com/repos/milesburton/finatra/issues{/number}","pulls_url":"https://api.github.com/repos/milesburton/finatra/pulls{/number}","milestones_url":"https://api.github.com/repos/milesburton/finatra/milestones{/number}","notifications_url":"https://api.github.com/repos/milesburton/finatra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/milesburton/finatra/labels{/name}","releases_url":"https://api.github.com/repos/milesburton/finatra/releases{/id}","deployments_url":"https://api.github.com/repos/milesburton/finatra/deployments","created_at":"2016-11-10T13:45:32Z","updated_at":"2016-11-10T13:45:39Z","pushed_at":"2016-11-10T14:02:03Z","git_url":"git://github.com/milesburton/finatra.git","ssh_url":"git@github.com:milesburton/finatra.git","clone_url":"https://github.com/milesburton/finatra.git","svn_url":"https://github.com/milesburton/finatra","homepage":"https://twitter.github.io/finatra/","size":9472,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"milesburton:develop","ref":"develop","sha":"9f36b0f4716d3cad266f1efe09dca7cb305ff606","user":{"login":"milesburton","id":1205171,"avatar_url":"https://avatars.githubusercontent.com/u/1205171?v=3","gravatar_id":"","url":"https://api.github.com/users/milesburton","html_url":"https://github.com/milesburton","followers_url":"https://api.github.com/users/milesburton/followers","following_url":"https://api.github.com/users/milesburton/following{/other_user}","gists_url":"https://api.github.com/users/milesburton/gists{/gist_id}","starred_url":"https://api.github.com/users/milesburton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milesburton/subscriptions","organizations_url":"https://api.github.com/users/milesburton/orgs","repos_url":"https://api.github.com/users/milesburton/repos","events_url":"https://api.github.com/users/milesburton/events{/privacy}","received_events_url":"https://api.github.com/users/milesburton/received_events","type":"User","site_admin":false},"repo":{"id":73386023,"name":"finatra","full_name":"milesburton/finatra","owner":{"login":"milesburton","id":1205171,"avatar_url":"https://avatars.githubusercontent.com/u/1205171?v=3","gravatar_id":"","url":"https://api.github.com/users/milesburton","html_url":"https://github.com/milesburton","followers_url":"https://api.github.com/users/milesburton/followers","following_url":"https://api.github.com/users/milesburton/following{/other_user}","gists_url":"https://api.github.com/users/milesburton/gists{/gist_id}","starred_url":"https://api.github.com/users/milesburton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milesburton/subscriptions","organizations_url":"https://api.github.com/users/milesburton/orgs","repos_url":"https://api.github.com/users/milesburton/repos","events_url":"https://api.github.com/users/milesburton/events{/privacy}","received_events_url":"https://api.github.com/users/milesburton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/milesburton/finatra","description":"Fast, testable, Scala services built on Twitter-Server and Finagle","fork":true,"url":"https://api.github.com/repos/milesburton/finatra","forks_url":"https://api.github.com/repos/milesburton/finatra/forks","keys_url":"https://api.github.com/repos/milesburton/finatra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/milesburton/finatra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/milesburton/finatra/teams","hooks_url":"https://api.github.com/repos/milesburton/finatra/hooks","issue_events_url":"https://api.github.com/repos/milesburton/finatra/issues/events{/number}","events_url":"https://api.github.com/repos/milesburton/finatra/events","assignees_url":"https://api.github.com/repos/milesburton/finatra/assignees{/user}","branches_url":"https://api.github.com/repos/milesburton/finatra/branches{/branch}","tags_url":"https://api.github.com/repos/milesburton/finatra/tags","blobs_url":"https://api.github.com/repos/milesburton/finatra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/milesburton/finatra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/milesburton/finatra/git/refs{/sha}","trees_url":"https://api.github.com/repos/milesburton/finatra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/milesburton/finatra/statuses/{sha}","languages_url":"https://api.github.com/repos/milesburton/finatra/languages","stargazers_url":"https://api.github.com/repos/milesburton/finatra/stargazers","contributors_url":"https://api.github.com/repos/milesburton/finatra/contributors","subscribers_url":"https://api.github.com/repos/milesburton/finatra/subscribers","subscription_url":"https://api.github.com/repos/milesburton/finatra/subscription","commits_url":"https://api.github.com/repos/milesburton/finatra/commits{/sha}","git_commits_url":"https://api.github.com/repos/milesburton/finatra/git/commits{/sha}","comments_url":"https://api.github.com/repos/milesburton/finatra/comments{/number}","issue_comment_url":"https://api.github.com/repos/milesburton/finatra/issues/comments{/number}","contents_url":"https://api.github.com/repos/milesburton/finatra/contents/{+path}","compare_url":"https://api.github.com/repos/milesburton/finatra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/milesburton/finatra/merges","archive_url":"https://api.github.com/repos/milesburton/finatra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/milesburton/finatra/downloads","issues_url":"https://api.github.com/repos/milesburton/finatra/issues{/number}","pulls_url":"https://api.github.com/repos/milesburton/finatra/pulls{/number}","milestones_url":"https://api.github.com/repos/milesburton/finatra/milestones{/number}","notifications_url":"https://api.github.com/repos/milesburton/finatra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/milesburton/finatra/labels{/name}","releases_url":"https://api.github.com/repos/milesburton/finatra/releases{/id}","deployments_url":"https://api.github.com/repos/milesburton/finatra/deployments","created_at":"2016-11-10T13:45:32Z","updated_at":"2016-11-10T13:45:39Z","pushed_at":"2016-11-10T14:02:03Z","git_url":"git://github.com/milesburton/finatra.git","ssh_url":"git@github.com:milesburton/finatra.git","clone_url":"https://github.com/milesburton/finatra.git","svn_url":"https://github.com/milesburton/finatra","homepage":"https://twitter.github.io/finatra/","size":9472,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/milesburton/finatra/pulls/1"},"html":{"href":"https://github.com/milesburton/finatra/pull/1"},"issue":{"href":"https://api.github.com/repos/milesburton/finatra/issues/1"},"comments":{"href":"https://api.github.com/repos/milesburton/finatra/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/milesburton/finatra/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/milesburton/finatra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/milesburton/finatra/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/milesburton/finatra/statuses/71b7d7423978a8642ce858d66fec0b38720e79a4"}}}}
{"actor":{"display_login":"AlexITC"}}