{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang-nursery/bitflags/pulls/comments/60839074","id":60839074,"diff_hunk":"@@ -452,12 +453,19 @@ macro_rules! bitflags {\n             }\n         }\n \n+        impl $crate::__core::iter::Extend<$BitFlags> for $BitFlags {\n+            fn extend<T: $crate::__core::iter::IntoIterator<Item=$BitFlags>>(&mut self, iterator: T) {\n+                for item in iterator {\n+                    self.insert(item)\n+                }\n+            }\n+        }\n+\n         impl $crate::__core::iter::FromIterator<$BitFlags> for $BitFlags {\n+            #[inline]","path":"src/lib.rs","position":25,"original_position":25,"commit_id":"96d6457e082f202827759103372ad2434dc8fc1c","original_commit_id":"96d6457e082f202827759103372ad2434dc8fc1c","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"It should be fine to remove this `#[inline]` because the function is already generic which will inline it elsewhere anyway","created_at":"2016-04-24T05:05:04Z","updated_at":"2016-04-24T05:05:04Z","html_url":"https://github.com/rust-lang-nursery/bitflags/pull/49#discussion_r60839074","pull_request_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/bitflags/pulls/comments/60839074"},"html":{"href":"https://github.com/rust-lang-nursery/bitflags/pull/49#discussion_r60839074"},"pull_request":{"href":"https://api.github.com/repos/rust-lang-nursery/bitflags/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang-nursery/bitflags/pulls/49","id":67612689,"html_url":"https://github.com/rust-lang-nursery/bitflags/pull/49","diff_url":"https://github.com/rust-lang-nursery/bitflags/pull/49.diff","patch_url":"https://github.com/rust-lang-nursery/bitflags/pull/49.patch","issue_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/issues/49","number":49,"state":"open","locked":false,"title":"Implement Extend for bitflags","user":{"login":"kamalmarhubi","id":50936,"avatar_url":"https://avatars.githubusercontent.com/u/50936?v=3","gravatar_id":"","url":"https://api.github.com/users/kamalmarhubi","html_url":"https://github.com/kamalmarhubi","followers_url":"https://api.github.com/users/kamalmarhubi/followers","following_url":"https://api.github.com/users/kamalmarhubi/following{/other_user}","gists_url":"https://api.github.com/users/kamalmarhubi/gists{/gist_id}","starred_url":"https://api.github.com/users/kamalmarhubi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamalmarhubi/subscriptions","organizations_url":"https://api.github.com/users/kamalmarhubi/orgs","repos_url":"https://api.github.com/users/kamalmarhubi/repos","events_url":"https://api.github.com/users/kamalmarhubi/events{/privacy}","received_events_url":"https://api.github.com/users/kamalmarhubi/received_events","type":"User","site_admin":false},"body":"This commit adds an `Extend` impl, and redefines the `FromIterator` impl\r\nto use it.","created_at":"2016-04-23T17:19:48Z","updated_at":"2016-04-24T05:05:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b197bf30d8e4a7a3d8daec644ebf47f97454972","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/pulls/49/commits","review_comments_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/pulls/49/comments","review_comment_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/issues/49/comments","statuses_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/statuses/96d6457e082f202827759103372ad2434dc8fc1c","head":{"label":"kamalmarhubi:impl-extend","ref":"impl-extend","sha":"96d6457e082f202827759103372ad2434dc8fc1c","user":{"login":"kamalmarhubi","id":50936,"avatar_url":"https://avatars.githubusercontent.com/u/50936?v=3","gravatar_id":"","url":"https://api.github.com/users/kamalmarhubi","html_url":"https://github.com/kamalmarhubi","followers_url":"https://api.github.com/users/kamalmarhubi/followers","following_url":"https://api.github.com/users/kamalmarhubi/following{/other_user}","gists_url":"https://api.github.com/users/kamalmarhubi/gists{/gist_id}","starred_url":"https://api.github.com/users/kamalmarhubi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamalmarhubi/subscriptions","organizations_url":"https://api.github.com/users/kamalmarhubi/orgs","repos_url":"https://api.github.com/users/kamalmarhubi/repos","events_url":"https://api.github.com/users/kamalmarhubi/events{/privacy}","received_events_url":"https://api.github.com/users/kamalmarhubi/received_events","type":"User","site_admin":false},"repo":{"id":56931369,"name":"bitflags","full_name":"kamalmarhubi/bitflags","owner":{"login":"kamalmarhubi","id":50936,"avatar_url":"https://avatars.githubusercontent.com/u/50936?v=3","gravatar_id":"","url":"https://api.github.com/users/kamalmarhubi","html_url":"https://github.com/kamalmarhubi","followers_url":"https://api.github.com/users/kamalmarhubi/followers","following_url":"https://api.github.com/users/kamalmarhubi/following{/other_user}","gists_url":"https://api.github.com/users/kamalmarhubi/gists{/gist_id}","starred_url":"https://api.github.com/users/kamalmarhubi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamalmarhubi/subscriptions","organizations_url":"https://api.github.com/users/kamalmarhubi/orgs","repos_url":"https://api.github.com/users/kamalmarhubi/repos","events_url":"https://api.github.com/users/kamalmarhubi/events{/privacy}","received_events_url":"https://api.github.com/users/kamalmarhubi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kamalmarhubi/bitflags","description":"","fork":true,"url":"https://api.github.com/repos/kamalmarhubi/bitflags","forks_url":"https://api.github.com/repos/kamalmarhubi/bitflags/forks","keys_url":"https://api.github.com/repos/kamalmarhubi/bitflags/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kamalmarhubi/bitflags/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kamalmarhubi/bitflags/teams","hooks_url":"https://api.github.com/repos/kamalmarhubi/bitflags/hooks","issue_events_url":"https://api.github.com/repos/kamalmarhubi/bitflags/issues/events{/number}","events_url":"https://api.github.com/repos/kamalmarhubi/bitflags/events","assignees_url":"https://api.github.com/repos/kamalmarhubi/bitflags/assignees{/user}","branches_url":"https://api.github.com/repos/kamalmarhubi/bitflags/branches{/branch}","tags_url":"https://api.github.com/repos/kamalmarhubi/bitflags/tags","blobs_url":"https://api.github.com/repos/kamalmarhubi/bitflags/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kamalmarhubi/bitflags/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kamalmarhubi/bitflags/git/refs{/sha}","trees_url":"https://api.github.com/repos/kamalmarhubi/bitflags/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kamalmarhubi/bitflags/statuses/{sha}","languages_url":"https://api.github.com/repos/kamalmarhubi/bitflags/languages","stargazers_url":"https://api.github.com/repos/kamalmarhubi/bitflags/stargazers","contributors_url":"https://api.github.com/repos/kamalmarhubi/bitflags/contributors","subscribers_url":"https://api.github.com/repos/kamalmarhubi/bitflags/subscribers","subscription_url":"https://api.github.com/repos/kamalmarhubi/bitflags/subscription","commits_url":"https://api.github.com/repos/kamalmarhubi/bitflags/commits{/sha}","git_commits_url":"https://api.github.com/repos/kamalmarhubi/bitflags/git/commits{/sha}","comments_url":"https://api.github.com/repos/kamalmarhubi/bitflags/comments{/number}","issue_comment_url":"https://api.github.com/repos/kamalmarhubi/bitflags/issues/comments{/number}","contents_url":"https://api.github.com/repos/kamalmarhubi/bitflags/contents/{+path}","compare_url":"https://api.github.com/repos/kamalmarhubi/bitflags/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kamalmarhubi/bitflags/merges","archive_url":"https://api.github.com/repos/kamalmarhubi/bitflags/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kamalmarhubi/bitflags/downloads","issues_url":"https://api.github.com/repos/kamalmarhubi/bitflags/issues{/number}","pulls_url":"https://api.github.com/repos/kamalmarhubi/bitflags/pulls{/number}","milestones_url":"https://api.github.com/repos/kamalmarhubi/bitflags/milestones{/number}","notifications_url":"https://api.github.com/repos/kamalmarhubi/bitflags/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kamalmarhubi/bitflags/labels{/name}","releases_url":"https://api.github.com/repos/kamalmarhubi/bitflags/releases{/id}","deployments_url":"https://api.github.com/repos/kamalmarhubi/bitflags/deployments","created_at":"2016-04-23T17:18:00Z","updated_at":"2016-04-23T17:18:01Z","pushed_at":"2016-04-23T17:26:54Z","git_url":"git://github.com/kamalmarhubi/bitflags.git","ssh_url":"git@github.com:kamalmarhubi/bitflags.git","clone_url":"https://github.com/kamalmarhubi/bitflags.git","svn_url":"https://github.com/kamalmarhubi/bitflags","homepage":null,"size":1190,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang-nursery:master","ref":"master","sha":"e832a7ecd33364093293937eac08c762fbd773ac","user":{"login":"rust-lang-nursery","id":14631425,"avatar_url":"https://avatars.githubusercontent.com/u/14631425?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"repo":{"id":29287955,"name":"bitflags","full_name":"rust-lang-nursery/bitflags","owner":{"login":"rust-lang-nursery","id":14631425,"avatar_url":"https://avatars.githubusercontent.com/u/14631425?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang-nursery/bitflags","description":"","fork":false,"url":"https://api.github.com/repos/rust-lang-nursery/bitflags","forks_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/forks","keys_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/teams","hooks_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/hooks","issue_events_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/events","assignees_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/tags","blobs_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/languages","stargazers_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/stargazers","contributors_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/contributors","subscribers_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/subscribers","subscription_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/subscription","commits_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/merges","archive_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/downloads","issues_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang-nursery/bitflags/deployments","created_at":"2015-01-15T08:30:44Z","updated_at":"2016-03-11T10:46:22Z","pushed_at":"2016-04-23T17:26:55Z","git_url":"git://github.com/rust-lang-nursery/bitflags.git","ssh_url":"git@github.com:rust-lang-nursery/bitflags.git","clone_url":"https://github.com/rust-lang-nursery/bitflags.git","svn_url":"https://github.com/rust-lang-nursery/bitflags","homepage":null,"size":1208,"stargazers_count":14,"watchers_count":14,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22,"mirror_url":null,"open_issues_count":11,"forks":22,"open_issues":11,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/bitflags/pulls/49"},"html":{"href":"https://github.com/rust-lang-nursery/bitflags/pull/49"},"issue":{"href":"https://api.github.com/repos/rust-lang-nursery/bitflags/issues/49"},"comments":{"href":"https://api.github.com/repos/rust-lang-nursery/bitflags/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang-nursery/bitflags/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang-nursery/bitflags/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang-nursery/bitflags/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang-nursery/bitflags/statuses/96d6457e082f202827759103372ad2434dc8fc1c"}}}}