{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/79475402","id":79475402,"diff_hunk":"@@ -383,6 +390,7 @@ public synchronized void close() {\n         if (!open) {\n             return;\n         }\n+        log.trace(\"Closing store {}\", name);","path":"streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java","position":39,"original_position":39,"commit_id":"fc39f86b4eab9ab512021cffed95006cf5df9ec2","original_commit_id":"fc39f86b4eab9ab512021cffed95006cf5df9ec2","user":{"login":"guozhangwang","id":10729597,"avatar_url":"https://avatars.githubusercontent.com/u/10729597?v=3","gravatar_id":"","url":"https://api.github.com/users/guozhangwang","html_url":"https://github.com/guozhangwang","followers_url":"https://api.github.com/users/guozhangwang/followers","following_url":"https://api.github.com/users/guozhangwang/following{/other_user}","gists_url":"https://api.github.com/users/guozhangwang/gists{/gist_id}","starred_url":"https://api.github.com/users/guozhangwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guozhangwang/subscriptions","organizations_url":"https://api.github.com/users/guozhangwang/orgs","repos_url":"https://api.github.com/users/guozhangwang/repos","events_url":"https://api.github.com/users/guozhangwang/events{/privacy}","received_events_url":"https://api.github.com/users/guozhangwang/received_events","type":"User","site_admin":false},"body":"Similarly, I'd rather log it in the caller function where we could have more context logged (e.g. which thread, which task, is closing this store). And currently since it is only called in `StateStoreManager` which is already logging this event as `log.debug(\"task [{}} Closing storage engine {}\", taskId, entry.getKey());` I think we do not need here.","created_at":"2016-09-19T19:57:23Z","updated_at":"2016-09-19T19:57:29Z","html_url":"https://github.com/apache/kafka/pull/1882#discussion_r79475402","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/1882","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/79475402"},"html":{"href":"https://github.com/apache/kafka/pull/1882#discussion_r79475402"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/1882"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/1882","id":85833689,"html_url":"https://github.com/apache/kafka/pull/1882","diff_url":"https://github.com/apache/kafka/pull/1882.diff","patch_url":"https://github.com/apache/kafka/pull/1882.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/1882","number":1882,"state":"open","locked":false,"title":"MINOR: some trace logging for streams debugging","user":{"login":"norwood","id":2636399,"avatar_url":"https://avatars.githubusercontent.com/u/2636399?v=3","gravatar_id":"","url":"https://api.github.com/users/norwood","html_url":"https://github.com/norwood","followers_url":"https://api.github.com/users/norwood/followers","following_url":"https://api.github.com/users/norwood/following{/other_user}","gists_url":"https://api.github.com/users/norwood/gists{/gist_id}","starred_url":"https://api.github.com/users/norwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norwood/subscriptions","organizations_url":"https://api.github.com/users/norwood/orgs","repos_url":"https://api.github.com/users/norwood/repos","events_url":"https://api.github.com/users/norwood/events{/privacy}","received_events_url":"https://api.github.com/users/norwood/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-19T17:16:51Z","updated_at":"2016-09-19T19:57:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68435bab4de78cd18c90ad671d5f40cd81ce2cf5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/1882/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/1882/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/1882/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/fc39f86b4eab9ab512021cffed95006cf5df9ec2","head":{"label":"norwood:streams-logging","ref":"streams-logging","sha":"fc39f86b4eab9ab512021cffed95006cf5df9ec2","user":{"login":"norwood","id":2636399,"avatar_url":"https://avatars.githubusercontent.com/u/2636399?v=3","gravatar_id":"","url":"https://api.github.com/users/norwood","html_url":"https://github.com/norwood","followers_url":"https://api.github.com/users/norwood/followers","following_url":"https://api.github.com/users/norwood/following{/other_user}","gists_url":"https://api.github.com/users/norwood/gists{/gist_id}","starred_url":"https://api.github.com/users/norwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norwood/subscriptions","organizations_url":"https://api.github.com/users/norwood/orgs","repos_url":"https://api.github.com/users/norwood/repos","events_url":"https://api.github.com/users/norwood/events{/privacy}","received_events_url":"https://api.github.com/users/norwood/received_events","type":"User","site_admin":false},"repo":{"id":55249246,"name":"kafka","full_name":"norwood/kafka","owner":{"login":"norwood","id":2636399,"avatar_url":"https://avatars.githubusercontent.com/u/2636399?v=3","gravatar_id":"","url":"https://api.github.com/users/norwood","html_url":"https://github.com/norwood","followers_url":"https://api.github.com/users/norwood/followers","following_url":"https://api.github.com/users/norwood/following{/other_user}","gists_url":"https://api.github.com/users/norwood/gists{/gist_id}","starred_url":"https://api.github.com/users/norwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norwood/subscriptions","organizations_url":"https://api.github.com/users/norwood/orgs","repos_url":"https://api.github.com/users/norwood/repos","events_url":"https://api.github.com/users/norwood/events{/privacy}","received_events_url":"https://api.github.com/users/norwood/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/norwood/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/norwood/kafka","forks_url":"https://api.github.com/repos/norwood/kafka/forks","keys_url":"https://api.github.com/repos/norwood/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/norwood/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/norwood/kafka/teams","hooks_url":"https://api.github.com/repos/norwood/kafka/hooks","issue_events_url":"https://api.github.com/repos/norwood/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/norwood/kafka/events","assignees_url":"https://api.github.com/repos/norwood/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/norwood/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/norwood/kafka/tags","blobs_url":"https://api.github.com/repos/norwood/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/norwood/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/norwood/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/norwood/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/norwood/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/norwood/kafka/languages","stargazers_url":"https://api.github.com/repos/norwood/kafka/stargazers","contributors_url":"https://api.github.com/repos/norwood/kafka/contributors","subscribers_url":"https://api.github.com/repos/norwood/kafka/subscribers","subscription_url":"https://api.github.com/repos/norwood/kafka/subscription","commits_url":"https://api.github.com/repos/norwood/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/norwood/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/norwood/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/norwood/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/norwood/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/norwood/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/norwood/kafka/merges","archive_url":"https://api.github.com/repos/norwood/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/norwood/kafka/downloads","issues_url":"https://api.github.com/repos/norwood/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/norwood/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/norwood/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/norwood/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/norwood/kafka/labels{/name}","releases_url":"https://api.github.com/repos/norwood/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/norwood/kafka/deployments","created_at":"2016-04-01T17:12:41Z","updated_at":"2016-04-01T17:12:45Z","pushed_at":"2016-09-19T17:16:21Z","git_url":"git://github.com/norwood/kafka.git","ssh_url":"git@github.com:norwood/kafka.git","clone_url":"https://github.com/norwood/kafka.git","svn_url":"https://github.com/norwood/kafka","homepage":null,"size":33667,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"d9206500bf2f99ce93f6ad64c7a89483100b3b5f","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-09-19T19:55:31Z","pushed_at":"2016-09-19T19:50:13Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":49161,"stargazers_count":3790,"watchers_count":3790,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2354,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":252,"forks":2354,"open_issues":252,"watchers":3790,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/1882"},"html":{"href":"https://github.com/apache/kafka/pull/1882"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/1882"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/1882/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/1882/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/1882/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/fc39f86b4eab9ab512021cffed95006cf5df9ec2"}}}}
{"actor":{"display_login":"guozhangwang"}}