{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/12832","repository_url":"https://api.github.com/repos/edx/edx-platform","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/12832/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/12832/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/12832/events","html_url":"https://github.com/edx/edx-platform/pull/12832","id":161873201,"number":12832,"title":"Enable discussion forums on CCX courses.","user":{"login":"mtyaka","id":32585,"avatar_url":"https://avatars.githubusercontent.com/u/32585?v=3","gravatar_id":"","url":"https://api.github.com/users/mtyaka","html_url":"https://github.com/mtyaka","followers_url":"https://api.github.com/users/mtyaka/followers","following_url":"https://api.github.com/users/mtyaka/following{/other_user}","gists_url":"https://api.github.com/users/mtyaka/gists{/gist_id}","starred_url":"https://api.github.com/users/mtyaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtyaka/subscriptions","organizations_url":"https://api.github.com/users/mtyaka/orgs","repos_url":"https://api.github.com/users/mtyaka/repos","events_url":"https://api.github.com/users/mtyaka/events{/privacy}","received_events_url":"https://api.github.com/users/mtyaka/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/edx/edx-platform/labels/open-source-contribution","name":"open-source-contribution","color":"bfe5bf"},{"url":"https://api.github.com/repos/edx/edx-platform/labels/waiting%20on%20author","name":"waiting on author","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2016-06-23T09:02:49Z","updated_at":"2016-07-12T06:59:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/12832","html_url":"https://github.com/edx/edx-platform/pull/12832","diff_url":"https://github.com/edx/edx-platform/pull/12832.diff","patch_url":"https://github.com/edx/edx-platform/pull/12832.patch"},"body":"Enable discussion forums on CCX courses.\r\n\r\n**JIRA tickets**: https://openedx.atlassian.net/browse/OSPR-1321\r\n\r\n**Discussions**: In the CCX meeting at the Open edX Conference on June 17, it was mentioned that it has now been generally agreed that \"the right approach\" is to restrict discussions in CCX courses to the CCX course (no sharing of discussions with the parent course or other CCX instances). This was something that was previously up for debate, and the lack of direction is part of why discussions on CCX courses have been disabled until now.\r\n\r\n**Dependencies**: None\r\n\r\n**Sandbox URL (LMS)**: http://pr12832.sandbox.opencraft.hosting/\r\n**Sandbox URL (Studio)**: http://studio-pr12832.sandbox.opencraft.hosting/\r\n\r\n**Partner information**: 3rd party-hosted open edX instance\r\n\r\n**Testing instructions**:\r\n\r\n1. Follow [the instructions to create a CCX course](http://edx.readthedocs.io/projects/open-edx-building-and-running-a-course/en/latest/set_up_course/custom_courses.html).\r\n2. Go to the new CCX course and verify that the \"Discussion\" tab is visible.\r\n3. Go to the \"Discussion\" tab and verify posting a message works.\r\n4. Go to the \"Discussion\" tab of parent course. Verify that the post created in the CCX course is not visible.\r\n5. Make a new post in the parent course.\r\n6. Navigate back to the \"Discussion\" tab of CCX course and verify that the new post from parent course is not visible.\r\n7. Go to the Studio and add a unit with inline discussion to the course.\r\n8. Go to the parent course in the LMS and post a message in the inline discussion\r\n9. Go to the CCX course and ensure that the post from parent course is not visible. Make a post from the CCX course.\r\n10. Go back to the parent course and ensure that the post from CCX is not visible.\r\n\r\n**Author notes and concerns**:\r\n\r\nI don't think the discussion component uses any pathways that will behave differently for a CCX course compared to a normal course, but it would still be good to do a load test. Would somebody at edX be able to help us with that?\r\n\r\n**Reviewers**\r\n- [x] @itsjeyd \r\n- [ ] edX reviewer[s] TBD\r\n\r\n**Settings**\r\n```yaml\r\nEDXAPP_FEATURES:\r\n  ALLOW_ALL_ADVANCED_COMPONENTS: true\r\n  ENABLE_DISCUSSION_SERVICE: true\r\n  ENABLE_DJANGO_ADMIN_SITE: true\r\n  REQUIRE_COURSE_EMAIL_AUTH: false\r\n  CUSTOM_COURSES_EDX: true\r\n```"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/231953996","html_url":"https://github.com/edx/edx-platform/pull/12832#issuecomment-231953996","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/12832","id":231953996,"user":{"login":"bradenmacdonald","id":945577,"avatar_url":"https://avatars.githubusercontent.com/u/945577?v=3","gravatar_id":"","url":"https://api.github.com/users/bradenmacdonald","html_url":"https://github.com/bradenmacdonald","followers_url":"https://api.github.com/users/bradenmacdonald/followers","following_url":"https://api.github.com/users/bradenmacdonald/following{/other_user}","gists_url":"https://api.github.com/users/bradenmacdonald/gists{/gist_id}","starred_url":"https://api.github.com/users/bradenmacdonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradenmacdonald/subscriptions","organizations_url":"https://api.github.com/users/bradenmacdonald/orgs","repos_url":"https://api.github.com/users/bradenmacdonald/repos","events_url":"https://api.github.com/users/bradenmacdonald/events{/privacy}","received_events_url":"https://api.github.com/users/bradenmacdonald/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T06:59:38Z","updated_at":"2016-07-12T06:59:38Z","body":"@robrap @ormsbee  Good points. I'm good with this approach: \"I believe it's safer to go with the approach that course-scoped fields still inherit from parent course to CCX, make CCX smart enough to override the forum course-scoped fields\""}}
{"actor":{"display_login":"bradenmacdonald"}}