{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/55136964","id":55136964,"diff_hunk":"@@ -0,0 +1,16 @@\n+-include ../../Makefile.include\n+\n+VERSION.TXT := $(XBMCROOT)/version.txt\n+APP_NAME=$(shell awk '/APP_NAME/ {print tolower($$2)}' $(VERSION.TXT))\n+\n+all: $(XBMCROOT)/lib$(APP_NAME).so\n+\n+$(XBMCROOT)/lib$(APP_NAME).so:","path":"tools/depends/target/cmakebuildsys/Makefile","position":8,"original_position":8,"commit_id":"61fe826fd1f9d12cf312117b1ecfaa79710f0483","original_commit_id":"61fe826fd1f9d12cf312117b1ecfaa79710f0483","user":{"login":"fetzerch","id":1133994,"avatar_url":"https://avatars.githubusercontent.com/u/1133994?v=3","gravatar_id":"","url":"https://api.github.com/users/fetzerch","html_url":"https://github.com/fetzerch","followers_url":"https://api.github.com/users/fetzerch/followers","following_url":"https://api.github.com/users/fetzerch/following{/other_user}","gists_url":"https://api.github.com/users/fetzerch/gists{/gist_id}","starred_url":"https://api.github.com/users/fetzerch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fetzerch/subscriptions","organizations_url":"https://api.github.com/users/fetzerch/orgs","repos_url":"https://api.github.com/users/fetzerch/repos","events_url":"https://api.github.com/users/fetzerch/events{/privacy}","received_events_url":"https://api.github.com/users/fetzerch/received_events","type":"User","site_admin":false},"body":"Ah true, do you have a suggestion how it should be done? Depending on what CMake generator we use it might generate different output. (with GNU Makefiles we build ./kodi.bin but with Xcode it builds it in a Debug/Release subfolder. Could we just make it a phony target?","created_at":"2016-03-06T11:05:53Z","updated_at":"2016-03-06T11:05:53Z","html_url":"https://github.com/xbmc/xbmc/pull/9271#discussion_r55136964","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/9271","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/55136964"},"html":{"href":"https://github.com/xbmc/xbmc/pull/9271#discussion_r55136964"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9271"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/9271","id":61812697,"html_url":"https://github.com/xbmc/xbmc/pull/9271","diff_url":"https://github.com/xbmc/xbmc/pull/9271.diff","patch_url":"https://github.com/xbmc/xbmc/pull/9271.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/9271","number":9271,"state":"open","locked":false,"title":"[cmake] Fixes / IOS / Jenkins","user":{"login":"fetzerch","id":1133994,"avatar_url":"https://avatars.githubusercontent.com/u/1133994?v=3","gravatar_id":"","url":"https://api.github.com/users/fetzerch","html_url":"https://github.com/fetzerch","followers_url":"https://api.github.com/users/fetzerch/followers","following_url":"https://api.github.com/users/fetzerch/following{/other_user}","gists_url":"https://api.github.com/users/fetzerch/gists{/gist_id}","starred_url":"https://api.github.com/users/fetzerch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fetzerch/subscriptions","organizations_url":"https://api.github.com/users/fetzerch/orgs","repos_url":"https://api.github.com/users/fetzerch/repos","events_url":"https://api.github.com/users/fetzerch/events{/privacy}","received_events_url":"https://api.github.com/users/fetzerch/received_events","type":"User","site_admin":false},"body":"This contains the CMake work of the previous week. Even though the topics are unrelated, the commits are dependent, so for simplicity I'd prefer to push it together (unless you want me to split).\r\n\r\n- First 3 commits are just build fixes (ping @wsnipex to avoid that we do duplicate work)\r\n- Most of the commits are related to building kodi.bin on IOS. Note that this is untested as packaging is still missing.\r\n- Last commits add a CMAKE_BUILD option to the buildscripts used by Jenkins. We can now build kodi.bin/exe on Jenkins for Linux, Rbpi, OSX, IOS, Android Arm and Android X86 (That might be interesting for @MartijnKaijser)\r\n\r\n@Memphiz:\r\n- Could you add a CMAKE_BUILD parameter to Jenkins so that I can drop the last commit.\r\n- You might also be interested in reviewing 7de0e0b\r\n- Do you have any idea how to fix the IOS build on jenkins (http://jenkins.kodi.tv/job/IOS/6755/consoleFull)? Maybe @wsnipex knows as it's dvdnav related. Unfortunately I can't reproduce that error locally so I'm stuck here.\r\n\r\nAnyone with windows batch scripting skills interested in adding CMake support to the windows build script used by Jenkins? Maybe @afedchin or @AchimTuran? :)","created_at":"2016-03-05T13:58:05Z","updated_at":"2016-03-06T11:05:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f25afb9e0d3a229dbc3f719c36e72f7b3b93e63","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/9271/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/9271/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/9271/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/61fe826fd1f9d12cf312117b1ecfaa79710f0483","head":{"label":"fetzerch:cmake_jenkins","ref":"cmake_jenkins","sha":"61fe826fd1f9d12cf312117b1ecfaa79710f0483","user":{"login":"fetzerch","id":1133994,"avatar_url":"https://avatars.githubusercontent.com/u/1133994?v=3","gravatar_id":"","url":"https://api.github.com/users/fetzerch","html_url":"https://github.com/fetzerch","followers_url":"https://api.github.com/users/fetzerch/followers","following_url":"https://api.github.com/users/fetzerch/following{/other_user}","gists_url":"https://api.github.com/users/fetzerch/gists{/gist_id}","starred_url":"https://api.github.com/users/fetzerch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fetzerch/subscriptions","organizations_url":"https://api.github.com/users/fetzerch/orgs","repos_url":"https://api.github.com/users/fetzerch/repos","events_url":"https://api.github.com/users/fetzerch/events{/privacy}","received_events_url":"https://api.github.com/users/fetzerch/received_events","type":"User","site_admin":false},"repo":{"id":2594230,"name":"xbmc","full_name":"fetzerch/xbmc","owner":{"login":"fetzerch","id":1133994,"avatar_url":"https://avatars.githubusercontent.com/u/1133994?v=3","gravatar_id":"","url":"https://api.github.com/users/fetzerch","html_url":"https://github.com/fetzerch","followers_url":"https://api.github.com/users/fetzerch/followers","following_url":"https://api.github.com/users/fetzerch/following{/other_user}","gists_url":"https://api.github.com/users/fetzerch/gists{/gist_id}","starred_url":"https://api.github.com/users/fetzerch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fetzerch/subscriptions","organizations_url":"https://api.github.com/users/fetzerch/orgs","repos_url":"https://api.github.com/users/fetzerch/repos","events_url":"https://api.github.com/users/fetzerch/events{/privacy}","received_events_url":"https://api.github.com/users/fetzerch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fetzerch/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/fetzerch/xbmc","forks_url":"https://api.github.com/repos/fetzerch/xbmc/forks","keys_url":"https://api.github.com/repos/fetzerch/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fetzerch/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fetzerch/xbmc/teams","hooks_url":"https://api.github.com/repos/fetzerch/xbmc/hooks","issue_events_url":"https://api.github.com/repos/fetzerch/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/fetzerch/xbmc/events","assignees_url":"https://api.github.com/repos/fetzerch/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/fetzerch/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/fetzerch/xbmc/tags","blobs_url":"https://api.github.com/repos/fetzerch/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fetzerch/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fetzerch/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/fetzerch/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fetzerch/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/fetzerch/xbmc/languages","stargazers_url":"https://api.github.com/repos/fetzerch/xbmc/stargazers","contributors_url":"https://api.github.com/repos/fetzerch/xbmc/contributors","subscribers_url":"https://api.github.com/repos/fetzerch/xbmc/subscribers","subscription_url":"https://api.github.com/repos/fetzerch/xbmc/subscription","commits_url":"https://api.github.com/repos/fetzerch/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/fetzerch/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/fetzerch/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/fetzerch/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/fetzerch/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/fetzerch/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fetzerch/xbmc/merges","archive_url":"https://api.github.com/repos/fetzerch/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fetzerch/xbmc/downloads","issues_url":"https://api.github.com/repos/fetzerch/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/fetzerch/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/fetzerch/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/fetzerch/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fetzerch/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/fetzerch/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/fetzerch/xbmc/deployments","created_at":"2011-10-17T19:26:07Z","updated_at":"2013-12-10T20:34:31Z","pushed_at":"2016-03-05T17:04:27Z","git_url":"git://github.com/fetzerch/xbmc.git","ssh_url":"git@github.com:fetzerch/xbmc.git","clone_url":"https://github.com/fetzerch/xbmc.git","svn_url":"https://github.com/fetzerch/xbmc","homepage":"http://xbmc.org","size":529523,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"3698addd61eb1a47c8dd6f757dce68b20cc69c6f","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2016-03-06T10:15:04Z","pushed_at":"2016-03-06T10:45:32Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1731141,"stargazers_count":4570,"watchers_count":4570,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3365,"mirror_url":null,"open_issues_count":221,"forks":3365,"open_issues":221,"watchers":4570,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9271"},"html":{"href":"https://github.com/xbmc/xbmc/pull/9271"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/9271"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/9271/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9271/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9271/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/61fe826fd1f9d12cf312117b1ecfaa79710f0483"}}}}