{"action":"created","comment":{"url":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/comments/85318346","pull_request_review_id":6040311,"id":85318346,"diff_hunk":"@@ -226,6 +226,17 @@ surprising how many false assumptions programmers continue to make about them.\n     information. Unless a piece of user-supplied data has actually been verified\n     to be a phone number, it should be stored as-is as entered by the user.\n \n+1.  **Phone numbers are numbers**\n+\n+    Never try to store phone numbers as an int or any other kind of numeric\n+    data type. You can't do arithmetic on them, and while 007, 07 and 7 are the\n+    same number they are not necessarily the same phone number - in some\n+    countries a leading 0 is significant and forms part of the number itself\n+    (see A leading zero in numbers formatted for domestic usage can always be\n+    discarded when dialing from abroad). Moreover, a phone number may contain","path":"FALSEHOODS.md","position":11,"original_position":11,"commit_id":"f2ff872896b06c195eb00f8ed41c59be149dde1a","original_commit_id":"f2ff872896b06c195eb00f8ed41c59be149dde1a","user":{"login":"DrHyde","id":216826,"avatar_url":"https://avatars.githubusercontent.com/u/216826?v=3","gravatar_id":"","url":"https://api.github.com/users/DrHyde","html_url":"https://github.com/DrHyde","followers_url":"https://api.github.com/users/DrHyde/followers","following_url":"https://api.github.com/users/DrHyde/following{/other_user}","gists_url":"https://api.github.com/users/DrHyde/gists{/gist_id}","starred_url":"https://api.github.com/users/DrHyde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrHyde/subscriptions","organizations_url":"https://api.github.com/users/DrHyde/orgs","repos_url":"https://api.github.com/users/DrHyde/repos","events_url":"https://api.github.com/users/DrHyde/events{/privacy}","received_events_url":"https://api.github.com/users/DrHyde/received_events","type":"User","site_admin":false},"body":"Makes sense. There's one other (see blahblahblah) in the file so I'll italicize that too.","created_at":"2016-10-27T11:35:04Z","updated_at":"2016-10-27T11:35:04Z","html_url":"https://github.com/googlei18n/libphonenumber/pull/1391#discussion_r85318346","pull_request_url":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/1391","_links":{"self":{"href":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/comments/85318346"},"html":{"href":"https://github.com/googlei18n/libphonenumber/pull/1391#discussion_r85318346"},"pull_request":{"href":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/1391"}}},"pull_request":{"url":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/1391","id":89894870,"html_url":"https://github.com/googlei18n/libphonenumber/pull/1391","diff_url":"https://github.com/googlei18n/libphonenumber/pull/1391.diff","patch_url":"https://github.com/googlei18n/libphonenumber/pull/1391.patch","issue_url":"https://api.github.com/repos/googlei18n/libphonenumber/issues/1391","number":1391,"state":"open","locked":false,"title":"add an extra falsehood: that phone numbers are numbers","user":{"login":"DrHyde","id":216826,"avatar_url":"https://avatars.githubusercontent.com/u/216826?v=3","gravatar_id":"","url":"https://api.github.com/users/DrHyde","html_url":"https://github.com/DrHyde","followers_url":"https://api.github.com/users/DrHyde/followers","following_url":"https://api.github.com/users/DrHyde/following{/other_user}","gists_url":"https://api.github.com/users/DrHyde/gists{/gist_id}","starred_url":"https://api.github.com/users/DrHyde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrHyde/subscriptions","organizations_url":"https://api.github.com/users/DrHyde/orgs","repos_url":"https://api.github.com/users/DrHyde/repos","events_url":"https://api.github.com/users/DrHyde/events{/privacy}","received_events_url":"https://api.github.com/users/DrHyde/received_events","type":"User","site_admin":false},"body":"Oh god the data corruption horror that I have had to deal with when people forgot this.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/googlei18n/libphonenumber/1391)\n<!-- Reviewable:end -->\n","created_at":"2016-10-18T20:43:18Z","updated_at":"2016-10-27T11:35:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59b812a2a80a15060865991d367a33c5334fd40a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/1391/commits","review_comments_url":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/1391/comments","review_comment_url":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlei18n/libphonenumber/issues/1391/comments","statuses_url":"https://api.github.com/repos/googlei18n/libphonenumber/statuses/f2ff872896b06c195eb00f8ed41c59be149dde1a","head":{"label":"DrHyde:master","ref":"master","sha":"f2ff872896b06c195eb00f8ed41c59be149dde1a","user":{"login":"DrHyde","id":216826,"avatar_url":"https://avatars.githubusercontent.com/u/216826?v=3","gravatar_id":"","url":"https://api.github.com/users/DrHyde","html_url":"https://github.com/DrHyde","followers_url":"https://api.github.com/users/DrHyde/followers","following_url":"https://api.github.com/users/DrHyde/following{/other_user}","gists_url":"https://api.github.com/users/DrHyde/gists{/gist_id}","starred_url":"https://api.github.com/users/DrHyde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrHyde/subscriptions","organizations_url":"https://api.github.com/users/DrHyde/orgs","repos_url":"https://api.github.com/users/DrHyde/repos","events_url":"https://api.github.com/users/DrHyde/events{/privacy}","received_events_url":"https://api.github.com/users/DrHyde/received_events","type":"User","site_admin":false},"repo":{"id":71288803,"name":"libphonenumber","full_name":"DrHyde/libphonenumber","owner":{"login":"DrHyde","id":216826,"avatar_url":"https://avatars.githubusercontent.com/u/216826?v=3","gravatar_id":"","url":"https://api.github.com/users/DrHyde","html_url":"https://github.com/DrHyde","followers_url":"https://api.github.com/users/DrHyde/followers","following_url":"https://api.github.com/users/DrHyde/following{/other_user}","gists_url":"https://api.github.com/users/DrHyde/gists{/gist_id}","starred_url":"https://api.github.com/users/DrHyde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrHyde/subscriptions","organizations_url":"https://api.github.com/users/DrHyde/orgs","repos_url":"https://api.github.com/users/DrHyde/repos","events_url":"https://api.github.com/users/DrHyde/events{/privacy}","received_events_url":"https://api.github.com/users/DrHyde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DrHyde/libphonenumber","description":"Google's common Java, C++ and JavaScript library for parsing, formatting, and validating international phone numbers.","fork":true,"url":"https://api.github.com/repos/DrHyde/libphonenumber","forks_url":"https://api.github.com/repos/DrHyde/libphonenumber/forks","keys_url":"https://api.github.com/repos/DrHyde/libphonenumber/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DrHyde/libphonenumber/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DrHyde/libphonenumber/teams","hooks_url":"https://api.github.com/repos/DrHyde/libphonenumber/hooks","issue_events_url":"https://api.github.com/repos/DrHyde/libphonenumber/issues/events{/number}","events_url":"https://api.github.com/repos/DrHyde/libphonenumber/events","assignees_url":"https://api.github.com/repos/DrHyde/libphonenumber/assignees{/user}","branches_url":"https://api.github.com/repos/DrHyde/libphonenumber/branches{/branch}","tags_url":"https://api.github.com/repos/DrHyde/libphonenumber/tags","blobs_url":"https://api.github.com/repos/DrHyde/libphonenumber/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DrHyde/libphonenumber/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DrHyde/libphonenumber/git/refs{/sha}","trees_url":"https://api.github.com/repos/DrHyde/libphonenumber/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DrHyde/libphonenumber/statuses/{sha}","languages_url":"https://api.github.com/repos/DrHyde/libphonenumber/languages","stargazers_url":"https://api.github.com/repos/DrHyde/libphonenumber/stargazers","contributors_url":"https://api.github.com/repos/DrHyde/libphonenumber/contributors","subscribers_url":"https://api.github.com/repos/DrHyde/libphonenumber/subscribers","subscription_url":"https://api.github.com/repos/DrHyde/libphonenumber/subscription","commits_url":"https://api.github.com/repos/DrHyde/libphonenumber/commits{/sha}","git_commits_url":"https://api.github.com/repos/DrHyde/libphonenumber/git/commits{/sha}","comments_url":"https://api.github.com/repos/DrHyde/libphonenumber/comments{/number}","issue_comment_url":"https://api.github.com/repos/DrHyde/libphonenumber/issues/comments{/number}","contents_url":"https://api.github.com/repos/DrHyde/libphonenumber/contents/{+path}","compare_url":"https://api.github.com/repos/DrHyde/libphonenumber/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DrHyde/libphonenumber/merges","archive_url":"https://api.github.com/repos/DrHyde/libphonenumber/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DrHyde/libphonenumber/downloads","issues_url":"https://api.github.com/repos/DrHyde/libphonenumber/issues{/number}","pulls_url":"https://api.github.com/repos/DrHyde/libphonenumber/pulls{/number}","milestones_url":"https://api.github.com/repos/DrHyde/libphonenumber/milestones{/number}","notifications_url":"https://api.github.com/repos/DrHyde/libphonenumber/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DrHyde/libphonenumber/labels{/name}","releases_url":"https://api.github.com/repos/DrHyde/libphonenumber/releases{/id}","deployments_url":"https://api.github.com/repos/DrHyde/libphonenumber/deployments","created_at":"2016-10-18T20:32:15Z","updated_at":"2016-10-18T20:32:17Z","pushed_at":"2016-10-26T16:30:19Z","git_url":"git://github.com/DrHyde/libphonenumber.git","ssh_url":"git@github.com:DrHyde/libphonenumber.git","clone_url":"https://github.com/DrHyde/libphonenumber.git","svn_url":"https://github.com/DrHyde/libphonenumber","homepage":"","size":59636,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlei18n:master","ref":"master","sha":"211b7531c6f0c38e661066a86782d8edc81fa777","user":{"login":"googlei18n","id":5503833,"avatar_url":"https://avatars.githubusercontent.com/u/5503833?v=3","gravatar_id":"","url":"https://api.github.com/users/googlei18n","html_url":"https://github.com/googlei18n","followers_url":"https://api.github.com/users/googlei18n/followers","following_url":"https://api.github.com/users/googlei18n/following{/other_user}","gists_url":"https://api.github.com/users/googlei18n/gists{/gist_id}","starred_url":"https://api.github.com/users/googlei18n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlei18n/subscriptions","organizations_url":"https://api.github.com/users/googlei18n/orgs","repos_url":"https://api.github.com/users/googlei18n/repos","events_url":"https://api.github.com/users/googlei18n/events{/privacy}","received_events_url":"https://api.github.com/users/googlei18n/received_events","type":"Organization","site_admin":false},"repo":{"id":27500243,"name":"libphonenumber","full_name":"googlei18n/libphonenumber","owner":{"login":"googlei18n","id":5503833,"avatar_url":"https://avatars.githubusercontent.com/u/5503833?v=3","gravatar_id":"","url":"https://api.github.com/users/googlei18n","html_url":"https://github.com/googlei18n","followers_url":"https://api.github.com/users/googlei18n/followers","following_url":"https://api.github.com/users/googlei18n/following{/other_user}","gists_url":"https://api.github.com/users/googlei18n/gists{/gist_id}","starred_url":"https://api.github.com/users/googlei18n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlei18n/subscriptions","organizations_url":"https://api.github.com/users/googlei18n/orgs","repos_url":"https://api.github.com/users/googlei18n/repos","events_url":"https://api.github.com/users/googlei18n/events{/privacy}","received_events_url":"https://api.github.com/users/googlei18n/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlei18n/libphonenumber","description":"Google's common Java, C++ and JavaScript library for parsing, formatting, and validating international phone numbers.","fork":false,"url":"https://api.github.com/repos/googlei18n/libphonenumber","forks_url":"https://api.github.com/repos/googlei18n/libphonenumber/forks","keys_url":"https://api.github.com/repos/googlei18n/libphonenumber/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlei18n/libphonenumber/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlei18n/libphonenumber/teams","hooks_url":"https://api.github.com/repos/googlei18n/libphonenumber/hooks","issue_events_url":"https://api.github.com/repos/googlei18n/libphonenumber/issues/events{/number}","events_url":"https://api.github.com/repos/googlei18n/libphonenumber/events","assignees_url":"https://api.github.com/repos/googlei18n/libphonenumber/assignees{/user}","branches_url":"https://api.github.com/repos/googlei18n/libphonenumber/branches{/branch}","tags_url":"https://api.github.com/repos/googlei18n/libphonenumber/tags","blobs_url":"https://api.github.com/repos/googlei18n/libphonenumber/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlei18n/libphonenumber/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlei18n/libphonenumber/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlei18n/libphonenumber/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlei18n/libphonenumber/statuses/{sha}","languages_url":"https://api.github.com/repos/googlei18n/libphonenumber/languages","stargazers_url":"https://api.github.com/repos/googlei18n/libphonenumber/stargazers","contributors_url":"https://api.github.com/repos/googlei18n/libphonenumber/contributors","subscribers_url":"https://api.github.com/repos/googlei18n/libphonenumber/subscribers","subscription_url":"https://api.github.com/repos/googlei18n/libphonenumber/subscription","commits_url":"https://api.github.com/repos/googlei18n/libphonenumber/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlei18n/libphonenumber/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlei18n/libphonenumber/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlei18n/libphonenumber/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlei18n/libphonenumber/contents/{+path}","compare_url":"https://api.github.com/repos/googlei18n/libphonenumber/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlei18n/libphonenumber/merges","archive_url":"https://api.github.com/repos/googlei18n/libphonenumber/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlei18n/libphonenumber/downloads","issues_url":"https://api.github.com/repos/googlei18n/libphonenumber/issues{/number}","pulls_url":"https://api.github.com/repos/googlei18n/libphonenumber/pulls{/number}","milestones_url":"https://api.github.com/repos/googlei18n/libphonenumber/milestones{/number}","notifications_url":"https://api.github.com/repos/googlei18n/libphonenumber/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlei18n/libphonenumber/labels{/name}","releases_url":"https://api.github.com/repos/googlei18n/libphonenumber/releases{/id}","deployments_url":"https://api.github.com/repos/googlei18n/libphonenumber/deployments","created_at":"2014-12-03T18:02:17Z","updated_at":"2016-10-27T07:57:00Z","pushed_at":"2016-10-27T09:51:04Z","git_url":"git://github.com/googlei18n/libphonenumber.git","ssh_url":"git@github.com:googlei18n/libphonenumber.git","clone_url":"https://github.com/googlei18n/libphonenumber.git","svn_url":"https://github.com/googlei18n/libphonenumber","homepage":"","size":73810,"stargazers_count":4193,"watchers_count":4193,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":529,"mirror_url":null,"open_issues_count":131,"forks":529,"open_issues":131,"watchers":4193,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/1391"},"html":{"href":"https://github.com/googlei18n/libphonenumber/pull/1391"},"issue":{"href":"https://api.github.com/repos/googlei18n/libphonenumber/issues/1391"},"comments":{"href":"https://api.github.com/repos/googlei18n/libphonenumber/issues/1391/comments"},"review_comments":{"href":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/1391/comments"},"review_comment":{"href":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlei18n/libphonenumber/pulls/1391/commits"},"statuses":{"href":"https://api.github.com/repos/googlei18n/libphonenumber/statuses/f2ff872896b06c195eb00f8ed41c59be149dde1a"}}}}
{"actor":{"display_login":"DrHyde"}}