{"action":"created","issue":{"url":"https://api.github.com/repos/ARMmbed/core-util/issues/77","repository_url":"https://api.github.com/repos/ARMmbed/core-util","labels_url":"https://api.github.com/repos/ARMmbed/core-util/issues/77/labels{/name}","comments_url":"https://api.github.com/repos/ARMmbed/core-util/issues/77/comments","events_url":"https://api.github.com/repos/ARMmbed/core-util/issues/77/events","html_url":"https://github.com/ARMmbed/core-util/pull/77","id":134931989,"number":77,"title":"Fix CriticalSection lock for nrf51 targets.","user":{"login":"pan-","id":409941,"avatar_url":"https://avatars.githubusercontent.com/u/409941?v=3","gravatar_id":"","url":"https://api.github.com/users/pan-","html_url":"https://github.com/pan-","followers_url":"https://api.github.com/users/pan-/followers","following_url":"https://api.github.com/users/pan-/following{/other_user}","gists_url":"https://api.github.com/users/pan-/gists{/gist_id}","starred_url":"https://api.github.com/users/pan-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pan-/subscriptions","organizations_url":"https://api.github.com/users/pan-/orgs","repos_url":"https://api.github.com/users/pan-/repos","events_url":"https://api.github.com/users/pan-/events{/privacy}","received_events_url":"https://api.github.com/users/pan-/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-19T17:55:58Z","updated_at":"2016-02-19T17:58:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ARMmbed/core-util/pulls/77","html_url":"https://github.com/ARMmbed/core-util/pull/77","diff_url":"https://github.com/ARMmbed/core-util/pull/77.diff","patch_url":"https://github.com/ARMmbed/core-util/pull/77.patch"},"body":"The previous implementation of CriticalSectionLock for nrf51 was only\r\nrelying to softdevice primitives sd_nvic_critical_region_enter and\r\nsd_nvic_critical_region_exit .\r\nIf the soft device is not enabled, these functions have no effect. This\r\nmeans that CriticalSectionLock was not locking anything if the softdevice\r\nwas not enabled.\r\n\r\nThis fix allow the usage of CriticalSectionLock, even if the softdevice is\r\nnot enabled. If the softdevice is not enabled, all irq are disabled until\r\nthe destruction of the lock.\r\n\r\nThis PR should be merged with: https://github.com/ARMmbed/mbed-hal-nrf51822-mcu/pull/48"},"comment":{"url":"https://api.github.com/repos/ARMmbed/core-util/issues/comments/186332592","html_url":"https://github.com/ARMmbed/core-util/pull/77#issuecomment-186332592","issue_url":"https://api.github.com/repos/ARMmbed/core-util/issues/77","id":186332592,"user":{"login":"pan-","id":409941,"avatar_url":"https://avatars.githubusercontent.com/u/409941?v=3","gravatar_id":"","url":"https://api.github.com/users/pan-","html_url":"https://github.com/pan-","followers_url":"https://api.github.com/users/pan-/followers","following_url":"https://api.github.com/users/pan-/following{/other_user}","gists_url":"https://api.github.com/users/pan-/gists{/gist_id}","starred_url":"https://api.github.com/users/pan-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pan-/subscriptions","organizations_url":"https://api.github.com/users/pan-/orgs","repos_url":"https://api.github.com/users/pan-/repos","events_url":"https://api.github.com/users/pan-/events{/privacy}","received_events_url":"https://api.github.com/users/pan-/received_events","type":"User","site_admin":false},"created_at":"2016-02-19T17:58:06Z","updated_at":"2016-02-19T17:58:06Z","body":"@rgrover @0xc0170 could you review this please ?"}}