{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/comments/52240623","id":52240623,"diff_hunk":"@@ -403,5 +311,29 @@ class Token\n \tstatic char const m_tokenType[NUM_TOKENS];\n };\n \n+class ElementaryTypeNameToken\n+{\n+public:\n+\tElementaryTypeNameToken(Token::Value token, std::string const& description)\n+\t{\n+\t\tsolAssert(isElementaryTypeName(token, description), \"\");\n+\t\tstd::tie(m_name, M, N) = setTypes(token, description);\n+\t\ttok = token;\n+\t}\n+\t\n+\tstd::string toString(bool const& tokValue = false) const& { return tokValue ? Token::toString(tok) : m_name; }","path":"libsolidity/parsing/Token.h","position":136,"original_position":136,"commit_id":"2155f5fc78f5517a9050656a7f25eea0821be8f6","original_commit_id":"2155f5fc78f5517a9050656a7f25eea0821be8f6","user":{"login":"chriseth","id":9073706,"avatar_url":"https://avatars.githubusercontent.com/u/9073706?v=3","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false},"body":"no `&` for the function itself (this is the windows build error)","created_at":"2016-02-08T22:51:53Z","updated_at":"2016-02-08T22:51:53Z","html_url":"https://github.com/ethereum/solidity/pull/389#discussion_r52240623","pull_request_url":"https://api.github.com/repos/ethereum/solidity/pulls/389","_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments/52240623"},"html":{"href":"https://github.com/ethereum/solidity/pull/389#discussion_r52240623"},"pull_request":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/389"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/389","id":58671687,"html_url":"https://github.com/ethereum/solidity/pull/389","diff_url":"https://github.com/ethereum/solidity/pull/389.diff","patch_url":"https://github.com/ethereum/solidity/pull/389.patch","issue_url":"https://api.github.com/repos/ethereum/solidity/issues/389","number":389,"state":"open","locked":false,"title":"Redefined token list with Elementary Type Name Token","user":{"login":"VoR0220","id":7756785,"avatar_url":"https://avatars.githubusercontent.com/u/7756785?v=3","gravatar_id":"","url":"https://api.github.com/users/VoR0220","html_url":"https://github.com/VoR0220","followers_url":"https://api.github.com/users/VoR0220/followers","following_url":"https://api.github.com/users/VoR0220/following{/other_user}","gists_url":"https://api.github.com/users/VoR0220/gists{/gist_id}","starred_url":"https://api.github.com/users/VoR0220/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoR0220/subscriptions","organizations_url":"https://api.github.com/users/VoR0220/orgs","repos_url":"https://api.github.com/users/VoR0220/repos","events_url":"https://api.github.com/users/VoR0220/events{/privacy}","received_events_url":"https://api.github.com/users/VoR0220/received_events","type":"User","site_admin":false},"body":"This is the prep step before we go and develop the fixed and ufixed data types. All the preliminary steps are accounted for. ","created_at":"2016-02-08T21:44:58Z","updated_at":"2016-02-08T22:51:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74647638bfbf18ebc38d5dd8b892cc7b9bba5272","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/solidity/pulls/389/commits","review_comments_url":"https://api.github.com/repos/ethereum/solidity/pulls/389/comments","review_comment_url":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/solidity/issues/389/comments","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/2155f5fc78f5517a9050656a7f25eea0821be8f6","head":{"label":"VoR0220:elementaryTypeToken","ref":"elementaryTypeToken","sha":"2155f5fc78f5517a9050656a7f25eea0821be8f6","user":{"login":"VoR0220","id":7756785,"avatar_url":"https://avatars.githubusercontent.com/u/7756785?v=3","gravatar_id":"","url":"https://api.github.com/users/VoR0220","html_url":"https://github.com/VoR0220","followers_url":"https://api.github.com/users/VoR0220/followers","following_url":"https://api.github.com/users/VoR0220/following{/other_user}","gists_url":"https://api.github.com/users/VoR0220/gists{/gist_id}","starred_url":"https://api.github.com/users/VoR0220/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoR0220/subscriptions","organizations_url":"https://api.github.com/users/VoR0220/orgs","repos_url":"https://api.github.com/users/VoR0220/repos","events_url":"https://api.github.com/users/VoR0220/events{/privacy}","received_events_url":"https://api.github.com/users/VoR0220/received_events","type":"User","site_admin":false},"repo":{"id":47712924,"name":"solidity","full_name":"VoR0220/solidity","owner":{"login":"VoR0220","id":7756785,"avatar_url":"https://avatars.githubusercontent.com/u/7756785?v=3","gravatar_id":"","url":"https://api.github.com/users/VoR0220","html_url":"https://github.com/VoR0220","followers_url":"https://api.github.com/users/VoR0220/followers","following_url":"https://api.github.com/users/VoR0220/following{/other_user}","gists_url":"https://api.github.com/users/VoR0220/gists{/gist_id}","starred_url":"https://api.github.com/users/VoR0220/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoR0220/subscriptions","organizations_url":"https://api.github.com/users/VoR0220/orgs","repos_url":"https://api.github.com/users/VoR0220/repos","events_url":"https://api.github.com/users/VoR0220/events{/privacy}","received_events_url":"https://api.github.com/users/VoR0220/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VoR0220/solidity","description":"The Solidity Contract-Oriented Programming Language","fork":true,"url":"https://api.github.com/repos/VoR0220/solidity","forks_url":"https://api.github.com/repos/VoR0220/solidity/forks","keys_url":"https://api.github.com/repos/VoR0220/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoR0220/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoR0220/solidity/teams","hooks_url":"https://api.github.com/repos/VoR0220/solidity/hooks","issue_events_url":"https://api.github.com/repos/VoR0220/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/VoR0220/solidity/events","assignees_url":"https://api.github.com/repos/VoR0220/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/VoR0220/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/VoR0220/solidity/tags","blobs_url":"https://api.github.com/repos/VoR0220/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoR0220/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoR0220/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoR0220/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoR0220/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/VoR0220/solidity/languages","stargazers_url":"https://api.github.com/repos/VoR0220/solidity/stargazers","contributors_url":"https://api.github.com/repos/VoR0220/solidity/contributors","subscribers_url":"https://api.github.com/repos/VoR0220/solidity/subscribers","subscription_url":"https://api.github.com/repos/VoR0220/solidity/subscription","commits_url":"https://api.github.com/repos/VoR0220/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoR0220/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoR0220/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoR0220/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoR0220/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/VoR0220/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoR0220/solidity/merges","archive_url":"https://api.github.com/repos/VoR0220/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoR0220/solidity/downloads","issues_url":"https://api.github.com/repos/VoR0220/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/VoR0220/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/VoR0220/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/VoR0220/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoR0220/solidity/labels{/name}","releases_url":"https://api.github.com/repos/VoR0220/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/VoR0220/solidity/deployments","created_at":"2015-12-09T19:11:37Z","updated_at":"2016-01-11T03:36:48Z","pushed_at":"2016-02-08T22:36:11Z","git_url":"git://github.com/VoR0220/solidity.git","ssh_url":"git@github.com:VoR0220/solidity.git","clone_url":"https://github.com/VoR0220/solidity.git","svn_url":"https://github.com/VoR0220/solidity","homepage":"","size":7530,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"fad2d4df222f3fc306eda84a6a3842955541f9d0","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"name":"solidity","full_name":"ethereum/solidity","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/solidity","description":"The Solidity Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2016-02-08T19:01:30Z","pushed_at":"2016-02-08T22:36:11Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"git@github.com:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"","size":9272,"stargazers_count":73,"watchers_count":73,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":46,"mirror_url":null,"open_issues_count":43,"forks":46,"open_issues":43,"watchers":73,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/389"},"html":{"href":"https://github.com/ethereum/solidity/pull/389"},"issue":{"href":"https://api.github.com/repos/ethereum/solidity/issues/389"},"comments":{"href":"https://api.github.com/repos/ethereum/solidity/issues/389/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/389/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/389/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/solidity/statuses/2155f5fc78f5517a9050656a7f25eea0821be8f6"}}}}