{"action":"created","comment":{"url":"https://api.github.com/repos/bcwaldon/farva/pulls/comments/64278669","id":64278669,"diff_hunk":"@@ -41,3 +43,24 @@ type Endpoint struct {\n \tIP   string\n \tPort int\n }\n+\n+type Aliases struct {\n+\tData map[string]string\n+}\n+\n+// Generates a list of aliases for a given ingress name and namespace.\n+func (a *Aliases) Collect(name string, ns string) []string {","path":"pkg/gateway/servicemap.go","position":35,"original_position":35,"commit_id":"a5b4cdd75559fbf22bd00442dfc112062de6b938","original_commit_id":"a5b4cdd75559fbf22bd00442dfc112062de6b938","user":{"login":"bcwaldon","id":548759,"avatar_url":"https://avatars.githubusercontent.com/u/548759?v=3","gravatar_id":"","url":"https://api.github.com/users/bcwaldon","html_url":"https://github.com/bcwaldon","followers_url":"https://api.github.com/users/bcwaldon/followers","following_url":"https://api.github.com/users/bcwaldon/following{/other_user}","gists_url":"https://api.github.com/users/bcwaldon/gists{/gist_id}","starred_url":"https://api.github.com/users/bcwaldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcwaldon/subscriptions","organizations_url":"https://api.github.com/users/bcwaldon/orgs","repos_url":"https://api.github.com/users/bcwaldon/repos","events_url":"https://api.github.com/users/bcwaldon/events{/privacy}","received_events_url":"https://api.github.com/users/bcwaldon/received_events","type":"User","site_admin":false},"body":"A more accurate name here may be `FilterByIngress`","created_at":"2016-05-23T20:00:23Z","updated_at":"2016-05-23T20:00:23Z","html_url":"https://github.com/bcwaldon/farva/pull/13#discussion_r64278669","pull_request_url":"https://api.github.com/repos/bcwaldon/farva/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/bcwaldon/farva/pulls/comments/64278669"},"html":{"href":"https://github.com/bcwaldon/farva/pull/13#discussion_r64278669"},"pull_request":{"href":"https://api.github.com/repos/bcwaldon/farva/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/bcwaldon/farva/pulls/13","id":71099823,"html_url":"https://github.com/bcwaldon/farva/pull/13","diff_url":"https://github.com/bcwaldon/farva/pull/13.diff","patch_url":"https://github.com/bcwaldon/farva/pull/13.patch","issue_url":"https://api.github.com/repos/bcwaldon/farva/issues/13","number":13,"state":"open","locked":false,"title":"Use a ConfigMap to generate vanity url.","user":{"login":"jacobstr","id":70507,"avatar_url":"https://avatars.githubusercontent.com/u/70507?v=3","gravatar_id":"","url":"https://api.github.com/users/jacobstr","html_url":"https://github.com/jacobstr","followers_url":"https://api.github.com/users/jacobstr/followers","following_url":"https://api.github.com/users/jacobstr/following{/other_user}","gists_url":"https://api.github.com/users/jacobstr/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobstr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobstr/subscriptions","organizations_url":"https://api.github.com/users/jacobstr/orgs","repos_url":"https://api.github.com/users/jacobstr/repos","events_url":"https://api.github.com/users/jacobstr/events{/privacy}","received_events_url":"https://api.github.com/users/jacobstr/received_events","type":"User","site_admin":false},"body":"This commit adds support for using a Kubernetes ConfigMap to populate\r\nserver_name aliases for a given ingress Name and Namespace. The config map name\r\nis hard coded to `FarvaVanityUrls`. The expected format is:\r\n\r\n\t\t\"app.vanity.com\": \"ing1.ns1\"\r\n\r\nWhere `app.vanity.com` is the vanity name we want to expose and \"ing1.ns1\"\r\ncorresponds to a name of \"ing1\" and namespace of \"ns1\".\r\n\r\nMultiple vanity urls can be created for a ingress single name and namespace.\r\n","created_at":"2016-05-23T18:39:44Z","updated_at":"2016-05-23T20:00:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74f3f3888df53d13184abbcb581f2671d66b5440","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bcwaldon/farva/pulls/13/commits","review_comments_url":"https://api.github.com/repos/bcwaldon/farva/pulls/13/comments","review_comment_url":"https://api.github.com/repos/bcwaldon/farva/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bcwaldon/farva/issues/13/comments","statuses_url":"https://api.github.com/repos/bcwaldon/farva/statuses/a5b4cdd75559fbf22bd00442dfc112062de6b938","head":{"label":"bcwaldon:vanity-urls","ref":"vanity-urls","sha":"a5b4cdd75559fbf22bd00442dfc112062de6b938","user":{"login":"bcwaldon","id":548759,"avatar_url":"https://avatars.githubusercontent.com/u/548759?v=3","gravatar_id":"","url":"https://api.github.com/users/bcwaldon","html_url":"https://github.com/bcwaldon","followers_url":"https://api.github.com/users/bcwaldon/followers","following_url":"https://api.github.com/users/bcwaldon/following{/other_user}","gists_url":"https://api.github.com/users/bcwaldon/gists{/gist_id}","starred_url":"https://api.github.com/users/bcwaldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcwaldon/subscriptions","organizations_url":"https://api.github.com/users/bcwaldon/orgs","repos_url":"https://api.github.com/users/bcwaldon/repos","events_url":"https://api.github.com/users/bcwaldon/events{/privacy}","received_events_url":"https://api.github.com/users/bcwaldon/received_events","type":"User","site_admin":false},"repo":{"id":58416417,"name":"farva","full_name":"bcwaldon/farva","owner":{"login":"bcwaldon","id":548759,"avatar_url":"https://avatars.githubusercontent.com/u/548759?v=3","gravatar_id":"","url":"https://api.github.com/users/bcwaldon","html_url":"https://github.com/bcwaldon","followers_url":"https://api.github.com/users/bcwaldon/followers","following_url":"https://api.github.com/users/bcwaldon/following{/other_user}","gists_url":"https://api.github.com/users/bcwaldon/gists{/gist_id}","starred_url":"https://api.github.com/users/bcwaldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcwaldon/subscriptions","organizations_url":"https://api.github.com/users/bcwaldon/orgs","repos_url":"https://api.github.com/users/bcwaldon/repos","events_url":"https://api.github.com/users/bcwaldon/events{/privacy}","received_events_url":"https://api.github.com/users/bcwaldon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bcwaldon/farva","description":"","fork":false,"url":"https://api.github.com/repos/bcwaldon/farva","forks_url":"https://api.github.com/repos/bcwaldon/farva/forks","keys_url":"https://api.github.com/repos/bcwaldon/farva/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcwaldon/farva/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcwaldon/farva/teams","hooks_url":"https://api.github.com/repos/bcwaldon/farva/hooks","issue_events_url":"https://api.github.com/repos/bcwaldon/farva/issues/events{/number}","events_url":"https://api.github.com/repos/bcwaldon/farva/events","assignees_url":"https://api.github.com/repos/bcwaldon/farva/assignees{/user}","branches_url":"https://api.github.com/repos/bcwaldon/farva/branches{/branch}","tags_url":"https://api.github.com/repos/bcwaldon/farva/tags","blobs_url":"https://api.github.com/repos/bcwaldon/farva/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcwaldon/farva/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcwaldon/farva/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcwaldon/farva/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcwaldon/farva/statuses/{sha}","languages_url":"https://api.github.com/repos/bcwaldon/farva/languages","stargazers_url":"https://api.github.com/repos/bcwaldon/farva/stargazers","contributors_url":"https://api.github.com/repos/bcwaldon/farva/contributors","subscribers_url":"https://api.github.com/repos/bcwaldon/farva/subscribers","subscription_url":"https://api.github.com/repos/bcwaldon/farva/subscription","commits_url":"https://api.github.com/repos/bcwaldon/farva/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcwaldon/farva/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcwaldon/farva/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcwaldon/farva/issues/comments{/number}","contents_url":"https://api.github.com/repos/bcwaldon/farva/contents/{+path}","compare_url":"https://api.github.com/repos/bcwaldon/farva/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcwaldon/farva/merges","archive_url":"https://api.github.com/repos/bcwaldon/farva/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcwaldon/farva/downloads","issues_url":"https://api.github.com/repos/bcwaldon/farva/issues{/number}","pulls_url":"https://api.github.com/repos/bcwaldon/farva/pulls{/number}","milestones_url":"https://api.github.com/repos/bcwaldon/farva/milestones{/number}","notifications_url":"https://api.github.com/repos/bcwaldon/farva/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcwaldon/farva/labels{/name}","releases_url":"https://api.github.com/repos/bcwaldon/farva/releases{/id}","deployments_url":"https://api.github.com/repos/bcwaldon/farva/deployments","created_at":"2016-05-10T00:09:00Z","updated_at":"2016-05-10T03:10:22Z","pushed_at":"2016-05-23T19:55:31Z","git_url":"git://github.com/bcwaldon/farva.git","ssh_url":"git@github.com:bcwaldon/farva.git","clone_url":"https://github.com/bcwaldon/farva.git","svn_url":"https://github.com/bcwaldon/farva","homepage":null,"size":1615,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"bcwaldon:master","ref":"master","sha":"0093c236e4e6f751bb5d5b10af484062323d74bc","user":{"login":"bcwaldon","id":548759,"avatar_url":"https://avatars.githubusercontent.com/u/548759?v=3","gravatar_id":"","url":"https://api.github.com/users/bcwaldon","html_url":"https://github.com/bcwaldon","followers_url":"https://api.github.com/users/bcwaldon/followers","following_url":"https://api.github.com/users/bcwaldon/following{/other_user}","gists_url":"https://api.github.com/users/bcwaldon/gists{/gist_id}","starred_url":"https://api.github.com/users/bcwaldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcwaldon/subscriptions","organizations_url":"https://api.github.com/users/bcwaldon/orgs","repos_url":"https://api.github.com/users/bcwaldon/repos","events_url":"https://api.github.com/users/bcwaldon/events{/privacy}","received_events_url":"https://api.github.com/users/bcwaldon/received_events","type":"User","site_admin":false},"repo":{"id":58416417,"name":"farva","full_name":"bcwaldon/farva","owner":{"login":"bcwaldon","id":548759,"avatar_url":"https://avatars.githubusercontent.com/u/548759?v=3","gravatar_id":"","url":"https://api.github.com/users/bcwaldon","html_url":"https://github.com/bcwaldon","followers_url":"https://api.github.com/users/bcwaldon/followers","following_url":"https://api.github.com/users/bcwaldon/following{/other_user}","gists_url":"https://api.github.com/users/bcwaldon/gists{/gist_id}","starred_url":"https://api.github.com/users/bcwaldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcwaldon/subscriptions","organizations_url":"https://api.github.com/users/bcwaldon/orgs","repos_url":"https://api.github.com/users/bcwaldon/repos","events_url":"https://api.github.com/users/bcwaldon/events{/privacy}","received_events_url":"https://api.github.com/users/bcwaldon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bcwaldon/farva","description":"","fork":false,"url":"https://api.github.com/repos/bcwaldon/farva","forks_url":"https://api.github.com/repos/bcwaldon/farva/forks","keys_url":"https://api.github.com/repos/bcwaldon/farva/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcwaldon/farva/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcwaldon/farva/teams","hooks_url":"https://api.github.com/repos/bcwaldon/farva/hooks","issue_events_url":"https://api.github.com/repos/bcwaldon/farva/issues/events{/number}","events_url":"https://api.github.com/repos/bcwaldon/farva/events","assignees_url":"https://api.github.com/repos/bcwaldon/farva/assignees{/user}","branches_url":"https://api.github.com/repos/bcwaldon/farva/branches{/branch}","tags_url":"https://api.github.com/repos/bcwaldon/farva/tags","blobs_url":"https://api.github.com/repos/bcwaldon/farva/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcwaldon/farva/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcwaldon/farva/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcwaldon/farva/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcwaldon/farva/statuses/{sha}","languages_url":"https://api.github.com/repos/bcwaldon/farva/languages","stargazers_url":"https://api.github.com/repos/bcwaldon/farva/stargazers","contributors_url":"https://api.github.com/repos/bcwaldon/farva/contributors","subscribers_url":"https://api.github.com/repos/bcwaldon/farva/subscribers","subscription_url":"https://api.github.com/repos/bcwaldon/farva/subscription","commits_url":"https://api.github.com/repos/bcwaldon/farva/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcwaldon/farva/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcwaldon/farva/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcwaldon/farva/issues/comments{/number}","contents_url":"https://api.github.com/repos/bcwaldon/farva/contents/{+path}","compare_url":"https://api.github.com/repos/bcwaldon/farva/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcwaldon/farva/merges","archive_url":"https://api.github.com/repos/bcwaldon/farva/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcwaldon/farva/downloads","issues_url":"https://api.github.com/repos/bcwaldon/farva/issues{/number}","pulls_url":"https://api.github.com/repos/bcwaldon/farva/pulls{/number}","milestones_url":"https://api.github.com/repos/bcwaldon/farva/milestones{/number}","notifications_url":"https://api.github.com/repos/bcwaldon/farva/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcwaldon/farva/labels{/name}","releases_url":"https://api.github.com/repos/bcwaldon/farva/releases{/id}","deployments_url":"https://api.github.com/repos/bcwaldon/farva/deployments","created_at":"2016-05-10T00:09:00Z","updated_at":"2016-05-10T03:10:22Z","pushed_at":"2016-05-23T19:55:31Z","git_url":"git://github.com/bcwaldon/farva.git","ssh_url":"git@github.com:bcwaldon/farva.git","clone_url":"https://github.com/bcwaldon/farva.git","svn_url":"https://github.com/bcwaldon/farva","homepage":null,"size":1615,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bcwaldon/farva/pulls/13"},"html":{"href":"https://github.com/bcwaldon/farva/pull/13"},"issue":{"href":"https://api.github.com/repos/bcwaldon/farva/issues/13"},"comments":{"href":"https://api.github.com/repos/bcwaldon/farva/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/bcwaldon/farva/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/bcwaldon/farva/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bcwaldon/farva/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/bcwaldon/farva/statuses/a5b4cdd75559fbf22bd00442dfc112062de6b938"}}}}
{"actor":{"display_login":"bcwaldon"}}