{"action":"created","comment":{"url":"https://api.github.com/repos/MontclairRobotics/Sprocket/pulls/comments/94198125","pull_request_review_id":14729197,"id":94198125,"diff_hunk":"@@ -1,53 +1,60 @@\n package org.montclairrobotics.sprocket.control;\n \n-import edu.wpi.first.wpilibj.Joystick;\n+import org.montclairrobotics.sprocket.drive.DriveTrainTarget;\n import org.montclairrobotics.sprocket.drive.MotorInputType;\n-import org.montclairrobotics.sprocket.drive.DriveTrainInput;\n+import org.montclairrobotics.sprocket.geometry.Angle;\n import org.montclairrobotics.sprocket.geometry.Degrees;\n import org.montclairrobotics.sprocket.geometry.Inch;\n import org.montclairrobotics.sprocket.geometry.Polar;\n import org.montclairrobotics.sprocket.geometry.Vector;\n+import org.montclairrobotics.sprocket.geometry.XY;\n+import org.montclairrobotics.sprocket.pipeline.Step;\n+\n+import edu.wpi.first.wpilibj.Joystick;\n \n-public class ArcadeDriveInput extends DriveTrainInput {\n+public class ArcadeDriveInput implements Step<DriveTrainTarget> {","path":"src/org/montclairrobotics/sprocket/control/ArcadeDriveInput.java","position":18,"original_position":18,"commit_id":"8e9e6ec840c0d1f7123714d36377036b9d09f121","original_commit_id":"8e9e6ec840c0d1f7123714d36377036b9d09f121","user":{"login":"jackhymowitz","id":16405629,"avatar_url":"https://avatars.githubusercontent.com/u/16405629?v=3","gravatar_id":"","url":"https://api.github.com/users/jackhymowitz","html_url":"https://github.com/jackhymowitz","followers_url":"https://api.github.com/users/jackhymowitz/followers","following_url":"https://api.github.com/users/jackhymowitz/following{/other_user}","gists_url":"https://api.github.com/users/jackhymowitz/gists{/gist_id}","starred_url":"https://api.github.com/users/jackhymowitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackhymowitz/subscriptions","organizations_url":"https://api.github.com/users/jackhymowitz/orgs","repos_url":"https://api.github.com/users/jackhymowitz/repos","events_url":"https://api.github.com/users/jackhymowitz/events{/privacy}","received_events_url":"https://api.github.com/users/jackhymowitz/received_events","type":"User","site_admin":false},"body":"No. (an arbitrary decision, and it is simpler that way).","created_at":"2016-12-30T02:18:21Z","updated_at":"2016-12-30T02:18:21Z","html_url":"https://github.com/MontclairRobotics/Sprocket/pull/36#discussion_r94198125","pull_request_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/MontclairRobotics/Sprocket/pulls/comments/94198125"},"html":{"href":"https://github.com/MontclairRobotics/Sprocket/pull/36#discussion_r94198125"},"pull_request":{"href":"https://api.github.com/repos/MontclairRobotics/Sprocket/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/MontclairRobotics/Sprocket/pulls/36","id":99590469,"html_url":"https://github.com/MontclairRobotics/Sprocket/pull/36","diff_url":"https://github.com/MontclairRobotics/Sprocket/pull/36.diff","patch_url":"https://github.com/MontclairRobotics/Sprocket/pull/36.patch","issue_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/issues/36","number":36,"state":"open","locked":false,"title":"Jack pipelines PR BY JACK","user":{"login":"jackhymowitz","id":16405629,"avatar_url":"https://avatars.githubusercontent.com/u/16405629?v=3","gravatar_id":"","url":"https://api.github.com/users/jackhymowitz","html_url":"https://github.com/jackhymowitz","followers_url":"https://api.github.com/users/jackhymowitz/followers","following_url":"https://api.github.com/users/jackhymowitz/following{/other_user}","gists_url":"https://api.github.com/users/jackhymowitz/gists{/gist_id}","starred_url":"https://api.github.com/users/jackhymowitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackhymowitz/subscriptions","organizations_url":"https://api.github.com/users/jackhymowitz/orgs","repos_url":"https://api.github.com/users/jackhymowitz/repos","events_url":"https://api.github.com/users/jackhymowitz/events{/privacy}","received_events_url":"https://api.github.com/users/jackhymowitz/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-28T20:40:52Z","updated_at":"2016-12-30T02:18:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/pulls/36/commits","review_comments_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/pulls/36/comments","review_comment_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/issues/36/comments","statuses_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/statuses/8e9e6ec840c0d1f7123714d36377036b9d09f121","head":{"label":"MontclairRobotics:jack-pipelines","ref":"jack-pipelines","sha":"8e9e6ec840c0d1f7123714d36377036b9d09f121","user":{"login":"MontclairRobotics","id":10872088,"avatar_url":"https://avatars.githubusercontent.com/u/10872088?v=3","gravatar_id":"","url":"https://api.github.com/users/MontclairRobotics","html_url":"https://github.com/MontclairRobotics","followers_url":"https://api.github.com/users/MontclairRobotics/followers","following_url":"https://api.github.com/users/MontclairRobotics/following{/other_user}","gists_url":"https://api.github.com/users/MontclairRobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/MontclairRobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MontclairRobotics/subscriptions","organizations_url":"https://api.github.com/users/MontclairRobotics/orgs","repos_url":"https://api.github.com/users/MontclairRobotics/repos","events_url":"https://api.github.com/users/MontclairRobotics/events{/privacy}","received_events_url":"https://api.github.com/users/MontclairRobotics/received_events","type":"Organization","site_admin":false},"repo":{"id":55789404,"name":"Sprocket","full_name":"MontclairRobotics/Sprocket","owner":{"login":"MontclairRobotics","id":10872088,"avatar_url":"https://avatars.githubusercontent.com/u/10872088?v=3","gravatar_id":"","url":"https://api.github.com/users/MontclairRobotics","html_url":"https://github.com/MontclairRobotics","followers_url":"https://api.github.com/users/MontclairRobotics/followers","following_url":"https://api.github.com/users/MontclairRobotics/following{/other_user}","gists_url":"https://api.github.com/users/MontclairRobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/MontclairRobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MontclairRobotics/subscriptions","organizations_url":"https://api.github.com/users/MontclairRobotics/orgs","repos_url":"https://api.github.com/users/MontclairRobotics/repos","events_url":"https://api.github.com/users/MontclairRobotics/events{/privacy}","received_events_url":"https://api.github.com/users/MontclairRobotics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MontclairRobotics/Sprocket","description":"An FRC Robot framework","fork":false,"url":"https://api.github.com/repos/MontclairRobotics/Sprocket","forks_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/forks","keys_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/teams","hooks_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/hooks","issue_events_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/issues/events{/number}","events_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/events","assignees_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/assignees{/user}","branches_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/branches{/branch}","tags_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/tags","blobs_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/statuses/{sha}","languages_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/languages","stargazers_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/stargazers","contributors_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/contributors","subscribers_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/subscribers","subscription_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/subscription","commits_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/issues/comments{/number}","contents_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/contents/{+path}","compare_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/merges","archive_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/downloads","issues_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/issues{/number}","pulls_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/pulls{/number}","milestones_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/milestones{/number}","notifications_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/labels{/name}","releases_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/releases{/id}","deployments_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/deployments","created_at":"2016-04-08T15:28:19Z","updated_at":"2016-11-05T17:40:40Z","pushed_at":"2016-12-29T19:54:43Z","git_url":"git://github.com/MontclairRobotics/Sprocket.git","ssh_url":"git@github.com:MontclairRobotics/Sprocket.git","clone_url":"https://github.com/MontclairRobotics/Sprocket.git","svn_url":"https://github.com/MontclairRobotics/Sprocket","homepage":null,"size":376,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"MontclairRobotics:master","ref":"master","sha":"9a1bae957ff8cfd90703ac57ee9800205e29c594","user":{"login":"MontclairRobotics","id":10872088,"avatar_url":"https://avatars.githubusercontent.com/u/10872088?v=3","gravatar_id":"","url":"https://api.github.com/users/MontclairRobotics","html_url":"https://github.com/MontclairRobotics","followers_url":"https://api.github.com/users/MontclairRobotics/followers","following_url":"https://api.github.com/users/MontclairRobotics/following{/other_user}","gists_url":"https://api.github.com/users/MontclairRobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/MontclairRobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MontclairRobotics/subscriptions","organizations_url":"https://api.github.com/users/MontclairRobotics/orgs","repos_url":"https://api.github.com/users/MontclairRobotics/repos","events_url":"https://api.github.com/users/MontclairRobotics/events{/privacy}","received_events_url":"https://api.github.com/users/MontclairRobotics/received_events","type":"Organization","site_admin":false},"repo":{"id":55789404,"name":"Sprocket","full_name":"MontclairRobotics/Sprocket","owner":{"login":"MontclairRobotics","id":10872088,"avatar_url":"https://avatars.githubusercontent.com/u/10872088?v=3","gravatar_id":"","url":"https://api.github.com/users/MontclairRobotics","html_url":"https://github.com/MontclairRobotics","followers_url":"https://api.github.com/users/MontclairRobotics/followers","following_url":"https://api.github.com/users/MontclairRobotics/following{/other_user}","gists_url":"https://api.github.com/users/MontclairRobotics/gists{/gist_id}","starred_url":"https://api.github.com/users/MontclairRobotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MontclairRobotics/subscriptions","organizations_url":"https://api.github.com/users/MontclairRobotics/orgs","repos_url":"https://api.github.com/users/MontclairRobotics/repos","events_url":"https://api.github.com/users/MontclairRobotics/events{/privacy}","received_events_url":"https://api.github.com/users/MontclairRobotics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MontclairRobotics/Sprocket","description":"An FRC Robot framework","fork":false,"url":"https://api.github.com/repos/MontclairRobotics/Sprocket","forks_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/forks","keys_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/teams","hooks_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/hooks","issue_events_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/issues/events{/number}","events_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/events","assignees_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/assignees{/user}","branches_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/branches{/branch}","tags_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/tags","blobs_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/statuses/{sha}","languages_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/languages","stargazers_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/stargazers","contributors_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/contributors","subscribers_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/subscribers","subscription_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/subscription","commits_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/issues/comments{/number}","contents_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/contents/{+path}","compare_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/merges","archive_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/downloads","issues_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/issues{/number}","pulls_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/pulls{/number}","milestones_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/milestones{/number}","notifications_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/labels{/name}","releases_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/releases{/id}","deployments_url":"https://api.github.com/repos/MontclairRobotics/Sprocket/deployments","created_at":"2016-04-08T15:28:19Z","updated_at":"2016-11-05T17:40:40Z","pushed_at":"2016-12-29T19:54:43Z","git_url":"git://github.com/MontclairRobotics/Sprocket.git","ssh_url":"git@github.com:MontclairRobotics/Sprocket.git","clone_url":"https://github.com/MontclairRobotics/Sprocket.git","svn_url":"https://github.com/MontclairRobotics/Sprocket","homepage":null,"size":376,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MontclairRobotics/Sprocket/pulls/36"},"html":{"href":"https://github.com/MontclairRobotics/Sprocket/pull/36"},"issue":{"href":"https://api.github.com/repos/MontclairRobotics/Sprocket/issues/36"},"comments":{"href":"https://api.github.com/repos/MontclairRobotics/Sprocket/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/MontclairRobotics/Sprocket/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/MontclairRobotics/Sprocket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MontclairRobotics/Sprocket/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/MontclairRobotics/Sprocket/statuses/8e9e6ec840c0d1f7123714d36377036b9d09f121"}}}}
{"actor":{"display_login":"jackhymowitz"}}