{"action":"created","issue":{"url":"https://api.github.com/repos/zaproxy/zaproxy/issues/3053","repository_url":"https://api.github.com/repos/zaproxy/zaproxy","labels_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/3053/labels{/name}","comments_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/3053/comments","events_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/3053/events","html_url":"https://github.com/zaproxy/zaproxy/pull/3053","id":193834622,"number":3053,"title":"Tweak log message in URLCanonicalizer","user":{"login":"thc202","id":4639210,"avatar_url":"https://avatars.githubusercontent.com/u/4639210?v=3","gravatar_id":"","url":"https://api.github.com/users/thc202","html_url":"https://github.com/thc202","followers_url":"https://api.github.com/users/thc202/followers","following_url":"https://api.github.com/users/thc202/following{/other_user}","gists_url":"https://api.github.com/users/thc202/gists{/gist_id}","starred_url":"https://api.github.com/users/thc202/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thc202/subscriptions","organizations_url":"https://api.github.com/users/thc202/orgs","repos_url":"https://api.github.com/users/thc202/repos","events_url":"https://api.github.com/users/thc202/events{/privacy}","received_events_url":"https://api.github.com/users/thc202/received_events","type":"User","site_admin":false},"labels":[{"id":220063776,"url":"https://api.github.com/repos/zaproxy/zaproxy/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":241925461,"url":"https://api.github.com/repos/zaproxy/zaproxy/labels/minor","name":"minor","color":"fef2c0","default":false},{"id":220421415,"url":"https://api.github.com/repos/zaproxy/zaproxy/labels/Usability","name":"Usability","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/zaproxy/zaproxy/milestones/2","html_url":"https://github.com/zaproxy/zaproxy/milestone/2","labels_url":"https://api.github.com/repos/zaproxy/zaproxy/milestones/2/labels","id":1808570,"number":2,"title":"2.6.0","description":"Enhancements and bug fixes expected to be included in the next main release.","creator":{"login":"thc202","id":4639210,"avatar_url":"https://avatars.githubusercontent.com/u/4639210?v=3","gravatar_id":"","url":"https://api.github.com/users/thc202","html_url":"https://github.com/thc202","followers_url":"https://api.github.com/users/thc202/followers","following_url":"https://api.github.com/users/thc202/following{/other_user}","gists_url":"https://api.github.com/users/thc202/gists{/gist_id}","starred_url":"https://api.github.com/users/thc202/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thc202/subscriptions","organizations_url":"https://api.github.com/users/thc202/orgs","repos_url":"https://api.github.com/users/thc202/repos","events_url":"https://api.github.com/users/thc202/events{/privacy}","received_events_url":"https://api.github.com/users/thc202/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":138,"state":"open","created_at":"2016-06-04T18:06:28Z","updated_at":"2016-12-07T19:08:32Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-12-06T17:28:46Z","updated_at":"2016-12-08T22:28:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/3053","html_url":"https://github.com/zaproxy/zaproxy/pull/3053","diff_url":"https://github.com/zaproxy/zaproxy/pull/3053.diff","patch_url":"https://github.com/zaproxy/zaproxy/pull/3053.patch"},"body":"Change a log message to include the URL that is being processed, also\r\nchange to return immediately if the the URL is not valid after logging\r\nthe problem (instead of throwing an exception, which would be caught\r\n(and logged) in the same method)."},"comment":{"url":"https://api.github.com/repos/zaproxy/zaproxy/issues/comments/265874964","html_url":"https://github.com/zaproxy/zaproxy/pull/3053#issuecomment-265874964","issue_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/3053","id":265874964,"user":{"login":"thc202","id":4639210,"avatar_url":"https://avatars.githubusercontent.com/u/4639210?v=3","gravatar_id":"","url":"https://api.github.com/users/thc202","html_url":"https://github.com/thc202","followers_url":"https://api.github.com/users/thc202/followers","following_url":"https://api.github.com/users/thc202/following{/other_user}","gists_url":"https://api.github.com/users/thc202/gists{/gist_id}","starred_url":"https://api.github.com/users/thc202/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thc202/subscriptions","organizations_url":"https://api.github.com/users/thc202/orgs","repos_url":"https://api.github.com/users/thc202/repos","events_url":"https://api.github.com/users/thc202/events{/privacy}","received_events_url":"https://api.github.com/users/thc202/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T22:28:13Z","updated_at":"2016-12-08T22:28:13Z","body":"I think warning is useful, the spider should be able to resolve all URLs correctly and it's good to know when they are not (e.g. in the case it's an issue in the extraction of the URLs #2898). Maybe it should (also) be shown to the user? Spider tab?\r\nAt the moment the class is only used by spider related classes, so the behaviour of the callers would end up being the same (\"warn and return\"). If we plan to use it in other places we should probably extract it to other package and remove some of the spider related logic (e.g. strip of session parameters and other \"cleaning\" methods)."}}
{"actor":{"display_login":"thc202"}}