{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/toolkit/pulls/comments/82092848","pull_request_review_id":3024422,"id":82092848,"diff_hunk":"@@ -668,9 +668,9 @@ public class LibraryServiceTest {\n     List<BookName> names = Arrays.asList(namesElement);\n     List<ShelfName> shelves = new ArrayList<>();\n \n-    PagedListResponse<FindRelatedBooksRequest, FindRelatedBooksResponse, BookName> pagedListResponse = api.findRelatedBooks(names, shelves);\n+    FindRelatedBooksPagedResponse pagedListResponse = api.findRelatedBooks(names, shelves);\n \n-    List<BookName> resources = Lists.newArrayList(pagedListResponse.iterateAllElements());\n+    List<String> resources = Lists.newArrayList(pagedListResponse.iterateAllElements());","path":"src/test/java/com/google/api/codegen/testdata/java_test_library.baseline","position":35,"original_position":35,"commit_id":"bf6544ca6b860faba2073b60b7551c78ab852a6c","original_commit_id":"bf6544ca6b860faba2073b60b7551c78ab852a6c","user":{"login":"garrettjonesgoogle","id":13341017,"avatar_url":"https://avatars.githubusercontent.com/u/13341017?v=3","gravatar_id":"","url":"https://api.github.com/users/garrettjonesgoogle","html_url":"https://github.com/garrettjonesgoogle","followers_url":"https://api.github.com/users/garrettjonesgoogle/followers","following_url":"https://api.github.com/users/garrettjonesgoogle/following{/other_user}","gists_url":"https://api.github.com/users/garrettjonesgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettjonesgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettjonesgoogle/subscriptions","organizations_url":"https://api.github.com/users/garrettjonesgoogle/orgs","repos_url":"https://api.github.com/users/garrettjonesgoogle/repos","events_url":"https://api.github.com/users/garrettjonesgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/garrettjonesgoogle/received_events","type":"User","site_admin":false},"body":"What happened to the `BookName` type here?","created_at":"2016-10-05T23:32:54Z","updated_at":"2016-10-05T23:32:54Z","html_url":"https://github.com/googleapis/toolkit/pull/578#discussion_r82092848","pull_request_url":"https://api.github.com/repos/googleapis/toolkit/pulls/578","_links":{"self":{"href":"https://api.github.com/repos/googleapis/toolkit/pulls/comments/82092848"},"html":{"href":"https://github.com/googleapis/toolkit/pull/578#discussion_r82092848"},"pull_request":{"href":"https://api.github.com/repos/googleapis/toolkit/pulls/578"}}},"pull_request":{"url":"https://api.github.com/repos/googleapis/toolkit/pulls/578","id":88150739,"html_url":"https://github.com/googleapis/toolkit/pull/578","diff_url":"https://github.com/googleapis/toolkit/pull/578.diff","patch_url":"https://github.com/googleapis/toolkit/pull/578.patch","issue_url":"https://api.github.com/repos/googleapis/toolkit/issues/578","number":578,"state":"open","locked":false,"title":"WIP: Support generation of paged response classes","user":{"login":"michaelbausor","id":14846209,"avatar_url":"https://avatars.githubusercontent.com/u/14846209?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelbausor","html_url":"https://github.com/michaelbausor","followers_url":"https://api.github.com/users/michaelbausor/followers","following_url":"https://api.github.com/users/michaelbausor/following{/other_user}","gists_url":"https://api.github.com/users/michaelbausor/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelbausor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelbausor/subscriptions","organizations_url":"https://api.github.com/users/michaelbausor/orgs","repos_url":"https://api.github.com/users/michaelbausor/repos","events_url":"https://api.github.com/users/michaelbausor/events{/privacy}","received_events_url":"https://api.github.com/users/michaelbausor/received_events","type":"User","site_admin":false},"body":"This is a WIP that can hopefully be simplified further. It adds support for generated page response types, with methods to iterate elements as resource names.","created_at":"2016-10-05T20:28:23Z","updated_at":"2016-10-05T23:34:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34c109928c4f93fdd0fa429934989d2d8ad0b00c","assignee":{"login":"shinfan","id":1514780,"avatar_url":"https://avatars.githubusercontent.com/u/1514780?v=3","gravatar_id":"","url":"https://api.github.com/users/shinfan","html_url":"https://github.com/shinfan","followers_url":"https://api.github.com/users/shinfan/followers","following_url":"https://api.github.com/users/shinfan/following{/other_user}","gists_url":"https://api.github.com/users/shinfan/gists{/gist_id}","starred_url":"https://api.github.com/users/shinfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinfan/subscriptions","organizations_url":"https://api.github.com/users/shinfan/orgs","repos_url":"https://api.github.com/users/shinfan/repos","events_url":"https://api.github.com/users/shinfan/events{/privacy}","received_events_url":"https://api.github.com/users/shinfan/received_events","type":"User","site_admin":false},"assignees":[{"login":"shinfan","id":1514780,"avatar_url":"https://avatars.githubusercontent.com/u/1514780?v=3","gravatar_id":"","url":"https://api.github.com/users/shinfan","html_url":"https://github.com/shinfan","followers_url":"https://api.github.com/users/shinfan/followers","following_url":"https://api.github.com/users/shinfan/following{/other_user}","gists_url":"https://api.github.com/users/shinfan/gists{/gist_id}","starred_url":"https://api.github.com/users/shinfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinfan/subscriptions","organizations_url":"https://api.github.com/users/shinfan/orgs","repos_url":"https://api.github.com/users/shinfan/repos","events_url":"https://api.github.com/users/shinfan/events{/privacy}","received_events_url":"https://api.github.com/users/shinfan/received_events","type":"User","site_admin":false},{"login":"garrettjonesgoogle","id":13341017,"avatar_url":"https://avatars.githubusercontent.com/u/13341017?v=3","gravatar_id":"","url":"https://api.github.com/users/garrettjonesgoogle","html_url":"https://github.com/garrettjonesgoogle","followers_url":"https://api.github.com/users/garrettjonesgoogle/followers","following_url":"https://api.github.com/users/garrettjonesgoogle/following{/other_user}","gists_url":"https://api.github.com/users/garrettjonesgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettjonesgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettjonesgoogle/subscriptions","organizations_url":"https://api.github.com/users/garrettjonesgoogle/orgs","repos_url":"https://api.github.com/users/garrettjonesgoogle/repos","events_url":"https://api.github.com/users/garrettjonesgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/garrettjonesgoogle/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/toolkit/pulls/578/commits","review_comments_url":"https://api.github.com/repos/googleapis/toolkit/pulls/578/comments","review_comment_url":"https://api.github.com/repos/googleapis/toolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/toolkit/issues/578/comments","statuses_url":"https://api.github.com/repos/googleapis/toolkit/statuses/bf6544ca6b860faba2073b60b7551c78ab852a6c","head":{"label":"michaelbausor:pagedlistresponse-minimal","ref":"pagedlistresponse-minimal","sha":"bf6544ca6b860faba2073b60b7551c78ab852a6c","user":{"login":"michaelbausor","id":14846209,"avatar_url":"https://avatars.githubusercontent.com/u/14846209?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelbausor","html_url":"https://github.com/michaelbausor","followers_url":"https://api.github.com/users/michaelbausor/followers","following_url":"https://api.github.com/users/michaelbausor/following{/other_user}","gists_url":"https://api.github.com/users/michaelbausor/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelbausor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelbausor/subscriptions","organizations_url":"https://api.github.com/users/michaelbausor/orgs","repos_url":"https://api.github.com/users/michaelbausor/repos","events_url":"https://api.github.com/users/michaelbausor/events{/privacy}","received_events_url":"https://api.github.com/users/michaelbausor/received_events","type":"User","site_admin":false},"repo":{"id":56789127,"name":"toolkit","full_name":"michaelbausor/toolkit","owner":{"login":"michaelbausor","id":14846209,"avatar_url":"https://avatars.githubusercontent.com/u/14846209?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelbausor","html_url":"https://github.com/michaelbausor","followers_url":"https://api.github.com/users/michaelbausor/followers","following_url":"https://api.github.com/users/michaelbausor/following{/other_user}","gists_url":"https://api.github.com/users/michaelbausor/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelbausor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelbausor/subscriptions","organizations_url":"https://api.github.com/users/michaelbausor/orgs","repos_url":"https://api.github.com/users/michaelbausor/repos","events_url":"https://api.github.com/users/michaelbausor/events{/privacy}","received_events_url":"https://api.github.com/users/michaelbausor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michaelbausor/toolkit","description":"","fork":true,"url":"https://api.github.com/repos/michaelbausor/toolkit","forks_url":"https://api.github.com/repos/michaelbausor/toolkit/forks","keys_url":"https://api.github.com/repos/michaelbausor/toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaelbausor/toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaelbausor/toolkit/teams","hooks_url":"https://api.github.com/repos/michaelbausor/toolkit/hooks","issue_events_url":"https://api.github.com/repos/michaelbausor/toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/michaelbausor/toolkit/events","assignees_url":"https://api.github.com/repos/michaelbausor/toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/michaelbausor/toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/michaelbausor/toolkit/tags","blobs_url":"https://api.github.com/repos/michaelbausor/toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaelbausor/toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaelbausor/toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaelbausor/toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaelbausor/toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/michaelbausor/toolkit/languages","stargazers_url":"https://api.github.com/repos/michaelbausor/toolkit/stargazers","contributors_url":"https://api.github.com/repos/michaelbausor/toolkit/contributors","subscribers_url":"https://api.github.com/repos/michaelbausor/toolkit/subscribers","subscription_url":"https://api.github.com/repos/michaelbausor/toolkit/subscription","commits_url":"https://api.github.com/repos/michaelbausor/toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaelbausor/toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaelbausor/toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaelbausor/toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaelbausor/toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/michaelbausor/toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaelbausor/toolkit/merges","archive_url":"https://api.github.com/repos/michaelbausor/toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaelbausor/toolkit/downloads","issues_url":"https://api.github.com/repos/michaelbausor/toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/michaelbausor/toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/michaelbausor/toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/michaelbausor/toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaelbausor/toolkit/labels{/name}","releases_url":"https://api.github.com/repos/michaelbausor/toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/michaelbausor/toolkit/deployments","created_at":"2016-04-21T16:25:21Z","updated_at":"2016-05-02T21:37:28Z","pushed_at":"2016-10-05T23:20:45Z","git_url":"git://github.com/michaelbausor/toolkit.git","ssh_url":"git@github.com:michaelbausor/toolkit.git","clone_url":"https://github.com/michaelbausor/toolkit.git","svn_url":"https://github.com/michaelbausor/toolkit","homepage":null,"size":8615,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"28a0dfa6bae6873ec885110e333deef39347d7ad","user":{"login":"googleapis","id":16785467,"avatar_url":"https://avatars.githubusercontent.com/u/16785467?v=3","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":56533838,"name":"toolkit","full_name":"googleapis/toolkit","owner":{"login":"googleapis","id":16785467,"avatar_url":"https://avatars.githubusercontent.com/u/16785467?v=3","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googleapis/toolkit","description":"","fork":false,"url":"https://api.github.com/repos/googleapis/toolkit","forks_url":"https://api.github.com/repos/googleapis/toolkit/forks","keys_url":"https://api.github.com/repos/googleapis/toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/toolkit/teams","hooks_url":"https://api.github.com/repos/googleapis/toolkit/hooks","issue_events_url":"https://api.github.com/repos/googleapis/toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/toolkit/events","assignees_url":"https://api.github.com/repos/googleapis/toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/toolkit/tags","blobs_url":"https://api.github.com/repos/googleapis/toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/toolkit/languages","stargazers_url":"https://api.github.com/repos/googleapis/toolkit/stargazers","contributors_url":"https://api.github.com/repos/googleapis/toolkit/contributors","subscribers_url":"https://api.github.com/repos/googleapis/toolkit/subscribers","subscription_url":"https://api.github.com/repos/googleapis/toolkit/subscription","commits_url":"https://api.github.com/repos/googleapis/toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/toolkit/merges","archive_url":"https://api.github.com/repos/googleapis/toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/toolkit/downloads","issues_url":"https://api.github.com/repos/googleapis/toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/toolkit/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/toolkit/deployments","created_at":"2016-04-18T18:58:04Z","updated_at":"2016-09-14T00:32:47Z","pushed_at":"2016-10-05T23:20:46Z","git_url":"git://github.com/googleapis/toolkit.git","ssh_url":"git@github.com:googleapis/toolkit.git","clone_url":"https://github.com/googleapis/toolkit.git","svn_url":"https://github.com/googleapis/toolkit","homepage":null,"size":12821,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":76,"forks":20,"open_issues":76,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/toolkit/pulls/578"},"html":{"href":"https://github.com/googleapis/toolkit/pull/578"},"issue":{"href":"https://api.github.com/repos/googleapis/toolkit/issues/578"},"comments":{"href":"https://api.github.com/repos/googleapis/toolkit/issues/578/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/toolkit/pulls/578/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/toolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/toolkit/pulls/578/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/toolkit/statuses/bf6544ca6b860faba2073b60b7551c78ab852a6c"}}}}
{"actor":{"display_login":"garrettjonesgoogle"}}