{"action":"created","comment":{"url":"https://api.github.com/repos/dmsimard/ara/pulls/comments/64239251","id":64239251,"diff_hunk":"@@ -254,3 +245,13 @@ def v2_playbook_on_include(self, included_file):\n         for host in included_file._hosts:\n             LOG.debug('log include file for host %s', host)\n             self.log_task(IncludeResult(host, included_file._filename), 'ok')\n+\n+if __name__ == '__main__':","path":"ara/callback/log_ara.py","position":174,"original_position":174,"commit_id":"205a206a22c2575edd48ccc650465c3fa32adc74","original_commit_id":"205a206a22c2575edd48ccc650465c3fa32adc74","user":{"login":"dmsimard","id":1291204,"avatar_url":"https://avatars.githubusercontent.com/u/1291204?v=3","gravatar_id":"","url":"https://api.github.com/users/dmsimard","html_url":"https://github.com/dmsimard","followers_url":"https://api.github.com/users/dmsimard/followers","following_url":"https://api.github.com/users/dmsimard/following{/other_user}","gists_url":"https://api.github.com/users/dmsimard/gists{/gist_id}","starred_url":"https://api.github.com/users/dmsimard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmsimard/subscriptions","organizations_url":"https://api.github.com/users/dmsimard/orgs","repos_url":"https://api.github.com/users/dmsimard/repos","events_url":"https://api.github.com/users/dmsimard/events{/privacy}","received_events_url":"https://api.github.com/users/dmsimard/received_events","type":"User","site_admin":false},"body":"This should probably be removed or moved elsewhere as discussed","created_at":"2016-05-23T15:17:07Z","updated_at":"2016-05-23T15:17:07Z","html_url":"https://github.com/dmsimard/ara/pull/51#discussion_r64239251","pull_request_url":"https://api.github.com/repos/dmsimard/ara/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/dmsimard/ara/pulls/comments/64239251"},"html":{"href":"https://github.com/dmsimard/ara/pull/51#discussion_r64239251"},"pull_request":{"href":"https://api.github.com/repos/dmsimard/ara/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/dmsimard/ara/pulls/51","id":71069347,"html_url":"https://github.com/dmsimard/ara/pull/51","diff_url":"https://github.com/dmsimard/ara/pull/51.diff","patch_url":"https://github.com/dmsimard/ara/pull/51.patch","issue_url":"https://api.github.com/repos/dmsimard/ara/issues/51","number":51,"state":"open","locked":false,"title":"refactor ara following some flask best practices","user":{"login":"larsks","id":82622,"avatar_url":"https://avatars.githubusercontent.com/u/82622?v=3","gravatar_id":"","url":"https://api.github.com/users/larsks","html_url":"https://github.com/larsks","followers_url":"https://api.github.com/users/larsks/followers","following_url":"https://api.github.com/users/larsks/following{/other_user}","gists_url":"https://api.github.com/users/larsks/gists{/gist_id}","starred_url":"https://api.github.com/users/larsks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsks/subscriptions","organizations_url":"https://api.github.com/users/larsks/orgs","repos_url":"https://api.github.com/users/larsks/repos","events_url":"https://api.github.com/users/larsks/events{/privacy}","received_events_url":"https://api.github.com/users/larsks/received_events","type":"User","site_admin":false},"body":"This commit refactors substantial chunks of ara's code:\n\n- views.py is split up into multiple modules, and we use flask\n  blueprints to avoid exposing the global app object to every module.\n\n- all initialization happens in ara.webapp, which I've attempted to\n  to make easy to manage as we add news views, filters, or other\n  features.\n\n- application configuration is now handled in a standard flask section\n  (by using `app.config.from_object` and the existing `ara.config`\n  module), with options for providing additional configuration via an\n  argument to `create_app` or via an environment variable pointing at\n  a Python file.\n\n- The `playbook_host` view is gone, replaced with `playbook_results`,\n  which can filter by either host or status or both via query\n  parameters.\n\n- Sorting has been moved from the views back into the controller\n\n- The per-method decorator in the callback has been replaced by a\n  metaclass that ensures we commit after each method.\n\n- ara-manage has learned about the \"createall\" and \"dropall\" commands\n  for explicitly creating or removing database tables.","created_at":"2016-05-23T14:22:00Z","updated_at":"2016-05-23T15:17:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2dbf1779cd0f0e21335209b30386ca24ecf17397","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dmsimard/ara/pulls/51/commits","review_comments_url":"https://api.github.com/repos/dmsimard/ara/pulls/51/comments","review_comment_url":"https://api.github.com/repos/dmsimard/ara/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmsimard/ara/issues/51/comments","statuses_url":"https://api.github.com/repos/dmsimard/ara/statuses/205a206a22c2575edd48ccc650465c3fa32adc74","head":{"label":"larsks:feature/the-great-reconfiguration","ref":"feature/the-great-reconfiguration","sha":"205a206a22c2575edd48ccc650465c3fa32adc74","user":{"login":"larsks","id":82622,"avatar_url":"https://avatars.githubusercontent.com/u/82622?v=3","gravatar_id":"","url":"https://api.github.com/users/larsks","html_url":"https://github.com/larsks","followers_url":"https://api.github.com/users/larsks/followers","following_url":"https://api.github.com/users/larsks/following{/other_user}","gists_url":"https://api.github.com/users/larsks/gists{/gist_id}","starred_url":"https://api.github.com/users/larsks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsks/subscriptions","organizations_url":"https://api.github.com/users/larsks/orgs","repos_url":"https://api.github.com/users/larsks/repos","events_url":"https://api.github.com/users/larsks/events{/privacy}","received_events_url":"https://api.github.com/users/larsks/received_events","type":"User","site_admin":false},"repo":{"id":58513542,"name":"ara","full_name":"larsks/ara","owner":{"login":"larsks","id":82622,"avatar_url":"https://avatars.githubusercontent.com/u/82622?v=3","gravatar_id":"","url":"https://api.github.com/users/larsks","html_url":"https://github.com/larsks","followers_url":"https://api.github.com/users/larsks/followers","following_url":"https://api.github.com/users/larsks/following{/other_user}","gists_url":"https://api.github.com/users/larsks/gists{/gist_id}","starred_url":"https://api.github.com/users/larsks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsks/subscriptions","organizations_url":"https://api.github.com/users/larsks/orgs","repos_url":"https://api.github.com/users/larsks/repos","events_url":"https://api.github.com/users/larsks/events{/privacy}","received_events_url":"https://api.github.com/users/larsks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/larsks/ara","description":"ARA - Ansible Run Analysis","fork":true,"url":"https://api.github.com/repos/larsks/ara","forks_url":"https://api.github.com/repos/larsks/ara/forks","keys_url":"https://api.github.com/repos/larsks/ara/keys{/key_id}","collaborators_url":"https://api.github.com/repos/larsks/ara/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/larsks/ara/teams","hooks_url":"https://api.github.com/repos/larsks/ara/hooks","issue_events_url":"https://api.github.com/repos/larsks/ara/issues/events{/number}","events_url":"https://api.github.com/repos/larsks/ara/events","assignees_url":"https://api.github.com/repos/larsks/ara/assignees{/user}","branches_url":"https://api.github.com/repos/larsks/ara/branches{/branch}","tags_url":"https://api.github.com/repos/larsks/ara/tags","blobs_url":"https://api.github.com/repos/larsks/ara/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/larsks/ara/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/larsks/ara/git/refs{/sha}","trees_url":"https://api.github.com/repos/larsks/ara/git/trees{/sha}","statuses_url":"https://api.github.com/repos/larsks/ara/statuses/{sha}","languages_url":"https://api.github.com/repos/larsks/ara/languages","stargazers_url":"https://api.github.com/repos/larsks/ara/stargazers","contributors_url":"https://api.github.com/repos/larsks/ara/contributors","subscribers_url":"https://api.github.com/repos/larsks/ara/subscribers","subscription_url":"https://api.github.com/repos/larsks/ara/subscription","commits_url":"https://api.github.com/repos/larsks/ara/commits{/sha}","git_commits_url":"https://api.github.com/repos/larsks/ara/git/commits{/sha}","comments_url":"https://api.github.com/repos/larsks/ara/comments{/number}","issue_comment_url":"https://api.github.com/repos/larsks/ara/issues/comments{/number}","contents_url":"https://api.github.com/repos/larsks/ara/contents/{+path}","compare_url":"https://api.github.com/repos/larsks/ara/compare/{base}...{head}","merges_url":"https://api.github.com/repos/larsks/ara/merges","archive_url":"https://api.github.com/repos/larsks/ara/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/larsks/ara/downloads","issues_url":"https://api.github.com/repos/larsks/ara/issues{/number}","pulls_url":"https://api.github.com/repos/larsks/ara/pulls{/number}","milestones_url":"https://api.github.com/repos/larsks/ara/milestones{/number}","notifications_url":"https://api.github.com/repos/larsks/ara/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/larsks/ara/labels{/name}","releases_url":"https://api.github.com/repos/larsks/ara/releases{/id}","deployments_url":"https://api.github.com/repos/larsks/ara/deployments","created_at":"2016-05-11T04:10:03Z","updated_at":"2016-05-11T04:10:04Z","pushed_at":"2016-05-23T13:59:44Z","git_url":"git://github.com/larsks/ara.git","ssh_url":"git@github.com:larsks/ara.git","clone_url":"https://github.com/larsks/ara.git","svn_url":"https://github.com/larsks/ara","homepage":"","size":905,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dmsimard:master","ref":"master","sha":"1bb7d6ddffea98d2ee3a4cce1bd527358964b38e","user":{"login":"dmsimard","id":1291204,"avatar_url":"https://avatars.githubusercontent.com/u/1291204?v=3","gravatar_id":"","url":"https://api.github.com/users/dmsimard","html_url":"https://github.com/dmsimard","followers_url":"https://api.github.com/users/dmsimard/followers","following_url":"https://api.github.com/users/dmsimard/following{/other_user}","gists_url":"https://api.github.com/users/dmsimard/gists{/gist_id}","starred_url":"https://api.github.com/users/dmsimard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmsimard/subscriptions","organizations_url":"https://api.github.com/users/dmsimard/orgs","repos_url":"https://api.github.com/users/dmsimard/repos","events_url":"https://api.github.com/users/dmsimard/events{/privacy}","received_events_url":"https://api.github.com/users/dmsimard/received_events","type":"User","site_admin":false},"repo":{"id":58235533,"name":"ara","full_name":"dmsimard/ara","owner":{"login":"dmsimard","id":1291204,"avatar_url":"https://avatars.githubusercontent.com/u/1291204?v=3","gravatar_id":"","url":"https://api.github.com/users/dmsimard","html_url":"https://github.com/dmsimard","followers_url":"https://api.github.com/users/dmsimard/followers","following_url":"https://api.github.com/users/dmsimard/following{/other_user}","gists_url":"https://api.github.com/users/dmsimard/gists{/gist_id}","starred_url":"https://api.github.com/users/dmsimard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmsimard/subscriptions","organizations_url":"https://api.github.com/users/dmsimard/orgs","repos_url":"https://api.github.com/users/dmsimard/repos","events_url":"https://api.github.com/users/dmsimard/events{/privacy}","received_events_url":"https://api.github.com/users/dmsimard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmsimard/ara","description":"ARA - Ansible Run Analysis","fork":false,"url":"https://api.github.com/repos/dmsimard/ara","forks_url":"https://api.github.com/repos/dmsimard/ara/forks","keys_url":"https://api.github.com/repos/dmsimard/ara/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmsimard/ara/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmsimard/ara/teams","hooks_url":"https://api.github.com/repos/dmsimard/ara/hooks","issue_events_url":"https://api.github.com/repos/dmsimard/ara/issues/events{/number}","events_url":"https://api.github.com/repos/dmsimard/ara/events","assignees_url":"https://api.github.com/repos/dmsimard/ara/assignees{/user}","branches_url":"https://api.github.com/repos/dmsimard/ara/branches{/branch}","tags_url":"https://api.github.com/repos/dmsimard/ara/tags","blobs_url":"https://api.github.com/repos/dmsimard/ara/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmsimard/ara/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmsimard/ara/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmsimard/ara/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmsimard/ara/statuses/{sha}","languages_url":"https://api.github.com/repos/dmsimard/ara/languages","stargazers_url":"https://api.github.com/repos/dmsimard/ara/stargazers","contributors_url":"https://api.github.com/repos/dmsimard/ara/contributors","subscribers_url":"https://api.github.com/repos/dmsimard/ara/subscribers","subscription_url":"https://api.github.com/repos/dmsimard/ara/subscription","commits_url":"https://api.github.com/repos/dmsimard/ara/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmsimard/ara/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmsimard/ara/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmsimard/ara/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmsimard/ara/contents/{+path}","compare_url":"https://api.github.com/repos/dmsimard/ara/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmsimard/ara/merges","archive_url":"https://api.github.com/repos/dmsimard/ara/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmsimard/ara/downloads","issues_url":"https://api.github.com/repos/dmsimard/ara/issues{/number}","pulls_url":"https://api.github.com/repos/dmsimard/ara/pulls{/number}","milestones_url":"https://api.github.com/repos/dmsimard/ara/milestones{/number}","notifications_url":"https://api.github.com/repos/dmsimard/ara/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmsimard/ara/labels{/name}","releases_url":"https://api.github.com/repos/dmsimard/ara/releases{/id}","deployments_url":"https://api.github.com/repos/dmsimard/ara/deployments","created_at":"2016-05-06T21:20:24Z","updated_at":"2016-05-23T14:12:00Z","pushed_at":"2016-05-23T14:22:44Z","git_url":"git://github.com/dmsimard/ara.git","ssh_url":"git@github.com:dmsimard/ara.git","clone_url":"https://github.com/dmsimard/ara.git","svn_url":"https://github.com/dmsimard/ara","homepage":"","size":892,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":12,"forks":1,"open_issues":12,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmsimard/ara/pulls/51"},"html":{"href":"https://github.com/dmsimard/ara/pull/51"},"issue":{"href":"https://api.github.com/repos/dmsimard/ara/issues/51"},"comments":{"href":"https://api.github.com/repos/dmsimard/ara/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/dmsimard/ara/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/dmsimard/ara/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmsimard/ara/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/dmsimard/ara/statuses/205a206a22c2575edd48ccc650465c3fa32adc74"}}}}
{"actor":{"display_login":"dmsimard"}}