{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/58034166","id":58034166,"diff_hunk":"@@ -71,7 +71,12 @@ public function getProxyFactoryCode(Definition $definition, $id)\n             $instantiation .= \" \\$this->services['$id'] =\";\n         }\n \n-        $methodName = 'get'.Container::camelize($id).'Service';\n+        if (func_num_args() >= 3) {\n+            $methodName = func_get_arg(2);","path":"src/Symfony/Bridge/ProxyManager/LazyProxy/PhpDumper/ProxyDumper.php","position":6,"original_position":6,"commit_id":"795399a02bc68e404179c9f7ee7624715f1667b8","original_commit_id":"795399a02bc68e404179c9f7ee7624715f1667b8","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"hmm, actually no. It would break BC for people extending the class. so forget it.","created_at":"2016-03-31T10:45:12Z","updated_at":"2016-03-31T10:45:12Z","html_url":"https://github.com/symfony/symfony/pull/18167#discussion_r58034166","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/18167","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/58034166"},"html":{"href":"https://github.com/symfony/symfony/pull/18167#discussion_r58034166"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18167"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/18167","id":62803756,"html_url":"https://github.com/symfony/symfony/pull/18167","diff_url":"https://github.com/symfony/symfony/pull/18167.diff","patch_url":"https://github.com/symfony/symfony/pull/18167.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/18167","number":18167,"state":"open","locked":false,"title":"[DependencyInjection] Fix a limitation of the PhpDumper","user":{"login":"Ener-Getick","id":6871899,"avatar_url":"https://avatars.githubusercontent.com/u/6871899?v=3","gravatar_id":"","url":"https://api.github.com/users/Ener-Getick","html_url":"https://github.com/Ener-Getick","followers_url":"https://api.github.com/users/Ener-Getick/followers","following_url":"https://api.github.com/users/Ener-Getick/following{/other_user}","gists_url":"https://api.github.com/users/Ener-Getick/gists{/gist_id}","starred_url":"https://api.github.com/users/Ener-Getick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ener-Getick/subscriptions","organizations_url":"https://api.github.com/users/Ener-Getick/orgs","repos_url":"https://api.github.com/users/Ener-Getick/repos","events_url":"https://api.github.com/users/Ener-Getick/events{/privacy}","received_events_url":"https://api.github.com/users/Ener-Getick/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | yes\r\n| Tests pass?   | yes\r\n| Fixed tickets | https://github.com/symfony/symfony/issues/17801\r\n| License       | MIT\r\n| Doc PR        | \r\n\r\nThe ``PhpDumper`` cannot currently dump several services' id containing characters unsupported by php.\r\nThis PR tries to solve this issue by removing the unsupported characters and by sufixing their camelized association to avoid conflicts.\r\n","created_at":"2016-03-14T19:29:04Z","updated_at":"2016-03-31T10:45:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d45b84a04c846a4ab205bfdcb2a0a3cbffc627f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/18167/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/18167/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/18167/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/795399a02bc68e404179c9f7ee7624715f1667b8","head":{"label":"Ener-Getick:DUMPER","ref":"DUMPER","sha":"795399a02bc68e404179c9f7ee7624715f1667b8","user":{"login":"Ener-Getick","id":6871899,"avatar_url":"https://avatars.githubusercontent.com/u/6871899?v=3","gravatar_id":"","url":"https://api.github.com/users/Ener-Getick","html_url":"https://github.com/Ener-Getick","followers_url":"https://api.github.com/users/Ener-Getick/followers","following_url":"https://api.github.com/users/Ener-Getick/following{/other_user}","gists_url":"https://api.github.com/users/Ener-Getick/gists{/gist_id}","starred_url":"https://api.github.com/users/Ener-Getick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ener-Getick/subscriptions","organizations_url":"https://api.github.com/users/Ener-Getick/orgs","repos_url":"https://api.github.com/users/Ener-Getick/repos","events_url":"https://api.github.com/users/Ener-Getick/events{/privacy}","received_events_url":"https://api.github.com/users/Ener-Getick/received_events","type":"User","site_admin":false},"repo":{"id":47275948,"name":"symfony","full_name":"Ener-Getick/symfony","owner":{"login":"Ener-Getick","id":6871899,"avatar_url":"https://avatars.githubusercontent.com/u/6871899?v=3","gravatar_id":"","url":"https://api.github.com/users/Ener-Getick","html_url":"https://github.com/Ener-Getick","followers_url":"https://api.github.com/users/Ener-Getick/followers","following_url":"https://api.github.com/users/Ener-Getick/following{/other_user}","gists_url":"https://api.github.com/users/Ener-Getick/gists{/gist_id}","starred_url":"https://api.github.com/users/Ener-Getick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ener-Getick/subscriptions","organizations_url":"https://api.github.com/users/Ener-Getick/orgs","repos_url":"https://api.github.com/users/Ener-Getick/repos","events_url":"https://api.github.com/users/Ener-Getick/events{/privacy}","received_events_url":"https://api.github.com/users/Ener-Getick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ener-Getick/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/Ener-Getick/symfony","forks_url":"https://api.github.com/repos/Ener-Getick/symfony/forks","keys_url":"https://api.github.com/repos/Ener-Getick/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ener-Getick/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ener-Getick/symfony/teams","hooks_url":"https://api.github.com/repos/Ener-Getick/symfony/hooks","issue_events_url":"https://api.github.com/repos/Ener-Getick/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/Ener-Getick/symfony/events","assignees_url":"https://api.github.com/repos/Ener-Getick/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/Ener-Getick/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/Ener-Getick/symfony/tags","blobs_url":"https://api.github.com/repos/Ener-Getick/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ener-Getick/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ener-Getick/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ener-Getick/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ener-Getick/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/Ener-Getick/symfony/languages","stargazers_url":"https://api.github.com/repos/Ener-Getick/symfony/stargazers","contributors_url":"https://api.github.com/repos/Ener-Getick/symfony/contributors","subscribers_url":"https://api.github.com/repos/Ener-Getick/symfony/subscribers","subscription_url":"https://api.github.com/repos/Ener-Getick/symfony/subscription","commits_url":"https://api.github.com/repos/Ener-Getick/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ener-Getick/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ener-Getick/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ener-Getick/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ener-Getick/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/Ener-Getick/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ener-Getick/symfony/merges","archive_url":"https://api.github.com/repos/Ener-Getick/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ener-Getick/symfony/downloads","issues_url":"https://api.github.com/repos/Ener-Getick/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/Ener-Getick/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/Ener-Getick/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/Ener-Getick/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ener-Getick/symfony/labels{/name}","releases_url":"https://api.github.com/repos/Ener-Getick/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/Ener-Getick/symfony/deployments","created_at":"2015-12-02T17:11:04Z","updated_at":"2016-03-29T17:14:37Z","pushed_at":"2016-03-30T11:28:18Z","git_url":"git://github.com/Ener-Getick/symfony.git","ssh_url":"git@github.com:Ener-Getick/symfony.git","clone_url":"https://github.com/Ener-Getick/symfony.git","svn_url":"https://github.com/Ener-Getick/symfony","homepage":"symfony.com","size":69957,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"FQCN"}},"base":{"label":"symfony:master","ref":"master","sha":"83ebf97df3a65199ce9ee218d176758104f2ac23","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-03-31T06:16:15Z","pushed_at":"2016-03-31T10:37:15Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":105372,"stargazers_count":12038,"watchers_count":12038,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4731,"mirror_url":null,"open_issues_count":709,"forks":4731,"open_issues":709,"watchers":12038,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18167"},"html":{"href":"https://github.com/symfony/symfony/pull/18167"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/18167"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/18167/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18167/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/18167/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/795399a02bc68e404179c9f7ee7624715f1667b8"}}}}