{"action":"created","issue":{"url":"https://api.github.com/repos/popcodeorg/popcode/issues/209","repository_url":"https://api.github.com/repos/popcodeorg/popcode","labels_url":"https://api.github.com/repos/popcodeorg/popcode/issues/209/labels{/name}","comments_url":"https://api.github.com/repos/popcodeorg/popcode/issues/209/comments","events_url":"https://api.github.com/repos/popcodeorg/popcode/issues/209/events","html_url":"https://github.com/popcodeorg/popcode/pull/209","id":183298068,"number":209,"title":"Graceful handling of closed gist windows","user":{"login":"outoftime","id":14214,"avatar_url":"https://avatars.githubusercontent.com/u/14214?v=3","gravatar_id":"","url":"https://api.github.com/users/outoftime","html_url":"https://github.com/outoftime","followers_url":"https://api.github.com/users/outoftime/followers","following_url":"https://api.github.com/users/outoftime/following{/other_user}","gists_url":"https://api.github.com/users/outoftime/gists{/gist_id}","starred_url":"https://api.github.com/users/outoftime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/outoftime/subscriptions","organizations_url":"https://api.github.com/users/outoftime/orgs","repos_url":"https://api.github.com/users/outoftime/repos","events_url":"https://api.github.com/users/outoftime/events{/privacy}","received_events_url":"https://api.github.com/users/outoftime/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-16T22:58:25Z","updated_at":"2016-10-17T02:43:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/popcodeorg/popcode/pulls/209","html_url":"https://github.com/popcodeorg/popcode/pull/209","diff_url":"https://github.com/popcodeorg/popcode/pull/209.diff","patch_url":"https://github.com/popcodeorg/popcode/pull/209.patch"},"body":"If the gist export takes a long time, the student may close the window before it completes (or fails). We want to handle this gracefully:\n\n* If the export completes and the student has closed the window, we display an application error instructing the student to try again.\n* If the export fails and the student has closed the window, we don’t try to close the window again.\n\nAlso used this as an opportunity to move the meat of the gist export logic out of the `Dashboard` and into the `Workspace`, since the latter as the view controller should take care of (or delegate to the action creators) pretty much anything interesting.\n\nThrew in another small fix which is to always open a new tab for the exported gist, rather than reusing the same tab for successive exports (which is 100% confusing).\n\nFinally, I noticed that there was a pretty useless `_handleNewProject` method on `Dashboard`, which does nothing more than wrap the `onNewProject` prop the `Dashboard` is given, so I unrolled that."},"comment":{"url":"https://api.github.com/repos/popcodeorg/popcode/issues/comments/254100220","html_url":"https://github.com/popcodeorg/popcode/pull/209#issuecomment-254100220","issue_url":"https://api.github.com/repos/popcodeorg/popcode/issues/209","id":254100220,"user":{"login":"alexpelan","id":817402,"avatar_url":"https://avatars.githubusercontent.com/u/817402?v=3","gravatar_id":"","url":"https://api.github.com/users/alexpelan","html_url":"https://github.com/alexpelan","followers_url":"https://api.github.com/users/alexpelan/followers","following_url":"https://api.github.com/users/alexpelan/following{/other_user}","gists_url":"https://api.github.com/users/alexpelan/gists{/gist_id}","starred_url":"https://api.github.com/users/alexpelan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexpelan/subscriptions","organizations_url":"https://api.github.com/users/alexpelan/orgs","repos_url":"https://api.github.com/users/alexpelan/repos","events_url":"https://api.github.com/users/alexpelan/events{/privacy}","received_events_url":"https://api.github.com/users/alexpelan/received_events","type":"User","site_admin":false},"created_at":"2016-10-17T02:43:54Z","updated_at":"2016-10-17T02:43:54Z","body":"Yeah, there's nothing in the popcode console. And I can't do anything with\nthe tab that opens, it basically insta-closes\n\nOn Sun, Oct 16, 2016 at 10:37 PM, Mat Brown <notifications@github.com>\nwrote:\n\n> @alexpelan <https://github.com/alexpelan> wait, it’s auto-closing even on\n> what should be a successful export!? definitely not doing that for me—is\n> there an error/uncaught rejection in the console?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/popcodeorg/popcode/pull/209#issuecomment-254099476>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAx4-t2Lh5jM8m5vCcOy45thRmhF_mNiks5q0t9fgaJpZM4KYHQS>\n> .\n>\n"}}
{"actor":{"display_login":"alexpelan"}}