{"action":"closed","number":40,"pull_request":{"url":"https://api.github.com/repos/matryer/bitbar/pulls/40","id":55069576,"html_url":"https://github.com/matryer/bitbar/pull/40","diff_url":"https://github.com/matryer/bitbar/pull/40.diff","patch_url":"https://github.com/matryer/bitbar/pull/40.patch","issue_url":"https://api.github.com/repos/matryer/bitbar/issues/40","number":40,"state":"closed","locked":false,"title":"Additional features (refresh keyword, better parameter passing, terminal window bug fix)","user":{"login":"jcaille","id":2685236,"avatar_url":"https://avatars.githubusercontent.com/u/2685236?v=3","gravatar_id":"","url":"https://api.github.com/users/jcaille","html_url":"https://github.com/jcaille","followers_url":"https://api.github.com/users/jcaille/followers","following_url":"https://api.github.com/users/jcaille/following{/other_user}","gists_url":"https://api.github.com/users/jcaille/gists{/gist_id}","starred_url":"https://api.github.com/users/jcaille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcaille/subscriptions","organizations_url":"https://api.github.com/users/jcaille/orgs","repos_url":"https://api.github.com/users/jcaille/repos","events_url":"https://api.github.com/users/jcaille/events{/privacy}","received_events_url":"https://api.github.com/users/jcaille/received_events","type":"User","site_admin":false},"body":"Hi !\r\n\r\nI'm really interested in this project, and have added a few features that I needed for a few scripts\r\n\r\n## Refresh keyword\r\nAdding the keyword `refresh` after the `|` adds an action to the menu item. Upon clicking this button, the plugin will be refreshed immediately.\r\n\r\n## Better parameter passing\r\nThe logic for parsing the parameter string felt a bit weak and prevented passing path containing spaces (or including small bash scripts inline)\r\n\r\nI've refactored the way parameters are scanned using an NSScanner, which should be a bit more legible and robust. The legacy behaviour is kept, but this kind of lines are now possible\r\n\r\n`Say something | bash=\"say Hello world\"`\r\n`Say something else | bash:'say Goodbye moon;exit' terminal=true`\r\n\r\n## Terminal window management\r\n\r\nLaunching a `bash` script by clicking a button failed when the frontmost terminal window was already running. I've changed the AppleScript to make sure to run the script in a new terminal window if `terminal=true`.\r\nWe might also include a keyword to close this window if the script returned a `no error (0)` status code\r\n\r\nLet me know if you'd prefer multiple pull request","created_at":"2016-01-05T09:23:22Z","updated_at":"2016-01-05T12:47:41Z","closed_at":"2016-01-05T12:47:41Z","merged_at":null,"merge_commit_sha":"f05f74b66899a124d0f243292dd75ba8d087778c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/matryer/bitbar/pulls/40/commits","review_comments_url":"https://api.github.com/repos/matryer/bitbar/pulls/40/comments","review_comment_url":"https://api.github.com/repos/matryer/bitbar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matryer/bitbar/issues/40/comments","statuses_url":"https://api.github.com/repos/matryer/bitbar/statuses/1b2bc162a85d187e81644cb1ebdbe942844d1e27","head":{"label":"jcaille:master","ref":"master","sha":"1b2bc162a85d187e81644cb1ebdbe942844d1e27","user":{"login":"jcaille","id":2685236,"avatar_url":"https://avatars.githubusercontent.com/u/2685236?v=3","gravatar_id":"","url":"https://api.github.com/users/jcaille","html_url":"https://github.com/jcaille","followers_url":"https://api.github.com/users/jcaille/followers","following_url":"https://api.github.com/users/jcaille/following{/other_user}","gists_url":"https://api.github.com/users/jcaille/gists{/gist_id}","starred_url":"https://api.github.com/users/jcaille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcaille/subscriptions","organizations_url":"https://api.github.com/users/jcaille/orgs","repos_url":"https://api.github.com/users/jcaille/repos","events_url":"https://api.github.com/users/jcaille/events{/privacy}","received_events_url":"https://api.github.com/users/jcaille/received_events","type":"User","site_admin":false},"repo":{"id":48750413,"name":"bitbar","full_name":"jcaille/bitbar","owner":{"login":"jcaille","id":2685236,"avatar_url":"https://avatars.githubusercontent.com/u/2685236?v=3","gravatar_id":"","url":"https://api.github.com/users/jcaille","html_url":"https://github.com/jcaille","followers_url":"https://api.github.com/users/jcaille/followers","following_url":"https://api.github.com/users/jcaille/following{/other_user}","gists_url":"https://api.github.com/users/jcaille/gists{/gist_id}","starred_url":"https://api.github.com/users/jcaille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcaille/subscriptions","organizations_url":"https://api.github.com/users/jcaille/orgs","repos_url":"https://api.github.com/users/jcaille/repos","events_url":"https://api.github.com/users/jcaille/events{/privacy}","received_events_url":"https://api.github.com/users/jcaille/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcaille/bitbar","description":"Free app to put the output from any script in your Mac OS X Menu Bar","fork":true,"url":"https://api.github.com/repos/jcaille/bitbar","forks_url":"https://api.github.com/repos/jcaille/bitbar/forks","keys_url":"https://api.github.com/repos/jcaille/bitbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcaille/bitbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcaille/bitbar/teams","hooks_url":"https://api.github.com/repos/jcaille/bitbar/hooks","issue_events_url":"https://api.github.com/repos/jcaille/bitbar/issues/events{/number}","events_url":"https://api.github.com/repos/jcaille/bitbar/events","assignees_url":"https://api.github.com/repos/jcaille/bitbar/assignees{/user}","branches_url":"https://api.github.com/repos/jcaille/bitbar/branches{/branch}","tags_url":"https://api.github.com/repos/jcaille/bitbar/tags","blobs_url":"https://api.github.com/repos/jcaille/bitbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcaille/bitbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcaille/bitbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcaille/bitbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcaille/bitbar/statuses/{sha}","languages_url":"https://api.github.com/repos/jcaille/bitbar/languages","stargazers_url":"https://api.github.com/repos/jcaille/bitbar/stargazers","contributors_url":"https://api.github.com/repos/jcaille/bitbar/contributors","subscribers_url":"https://api.github.com/repos/jcaille/bitbar/subscribers","subscription_url":"https://api.github.com/repos/jcaille/bitbar/subscription","commits_url":"https://api.github.com/repos/jcaille/bitbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcaille/bitbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcaille/bitbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcaille/bitbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcaille/bitbar/contents/{+path}","compare_url":"https://api.github.com/repos/jcaille/bitbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcaille/bitbar/merges","archive_url":"https://api.github.com/repos/jcaille/bitbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcaille/bitbar/downloads","issues_url":"https://api.github.com/repos/jcaille/bitbar/issues{/number}","pulls_url":"https://api.github.com/repos/jcaille/bitbar/pulls{/number}","milestones_url":"https://api.github.com/repos/jcaille/bitbar/milestones{/number}","notifications_url":"https://api.github.com/repos/jcaille/bitbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcaille/bitbar/labels{/name}","releases_url":"https://api.github.com/repos/jcaille/bitbar/releases{/id}","created_at":"2015-12-29T14:11:00Z","updated_at":"2015-12-29T14:11:01Z","pushed_at":"2016-01-05T12:47:20Z","git_url":"git://github.com/jcaille/bitbar.git","ssh_url":"git@github.com:jcaille/bitbar.git","clone_url":"https://github.com/jcaille/bitbar.git","svn_url":"https://github.com/jcaille/bitbar","homepage":"","size":2717,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matryer:master","ref":"master","sha":"a1fc7c7888be407b47ad0c3e4771b1886734e2f9","user":{"login":"matryer","id":101659,"avatar_url":"https://avatars.githubusercontent.com/u/101659?v=3","gravatar_id":"","url":"https://api.github.com/users/matryer","html_url":"https://github.com/matryer","followers_url":"https://api.github.com/users/matryer/followers","following_url":"https://api.github.com/users/matryer/following{/other_user}","gists_url":"https://api.github.com/users/matryer/gists{/gist_id}","starred_url":"https://api.github.com/users/matryer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matryer/subscriptions","organizations_url":"https://api.github.com/users/matryer/orgs","repos_url":"https://api.github.com/users/matryer/repos","events_url":"https://api.github.com/users/matryer/events{/privacy}","received_events_url":"https://api.github.com/users/matryer/received_events","type":"User","site_admin":false},"repo":{"id":14376285,"name":"bitbar","full_name":"matryer/bitbar","owner":{"login":"matryer","id":101659,"avatar_url":"https://avatars.githubusercontent.com/u/101659?v=3","gravatar_id":"","url":"https://api.github.com/users/matryer","html_url":"https://github.com/matryer","followers_url":"https://api.github.com/users/matryer/followers","following_url":"https://api.github.com/users/matryer/following{/other_user}","gists_url":"https://api.github.com/users/matryer/gists{/gist_id}","starred_url":"https://api.github.com/users/matryer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matryer/subscriptions","organizations_url":"https://api.github.com/users/matryer/orgs","repos_url":"https://api.github.com/users/matryer/repos","events_url":"https://api.github.com/users/matryer/events{/privacy}","received_events_url":"https://api.github.com/users/matryer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matryer/bitbar","description":"Free app to put the output from any script in your Mac OS X Menu Bar","fork":false,"url":"https://api.github.com/repos/matryer/bitbar","forks_url":"https://api.github.com/repos/matryer/bitbar/forks","keys_url":"https://api.github.com/repos/matryer/bitbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matryer/bitbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matryer/bitbar/teams","hooks_url":"https://api.github.com/repos/matryer/bitbar/hooks","issue_events_url":"https://api.github.com/repos/matryer/bitbar/issues/events{/number}","events_url":"https://api.github.com/repos/matryer/bitbar/events","assignees_url":"https://api.github.com/repos/matryer/bitbar/assignees{/user}","branches_url":"https://api.github.com/repos/matryer/bitbar/branches{/branch}","tags_url":"https://api.github.com/repos/matryer/bitbar/tags","blobs_url":"https://api.github.com/repos/matryer/bitbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matryer/bitbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matryer/bitbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/matryer/bitbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matryer/bitbar/statuses/{sha}","languages_url":"https://api.github.com/repos/matryer/bitbar/languages","stargazers_url":"https://api.github.com/repos/matryer/bitbar/stargazers","contributors_url":"https://api.github.com/repos/matryer/bitbar/contributors","subscribers_url":"https://api.github.com/repos/matryer/bitbar/subscribers","subscription_url":"https://api.github.com/repos/matryer/bitbar/subscription","commits_url":"https://api.github.com/repos/matryer/bitbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/matryer/bitbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/matryer/bitbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/matryer/bitbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/matryer/bitbar/contents/{+path}","compare_url":"https://api.github.com/repos/matryer/bitbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matryer/bitbar/merges","archive_url":"https://api.github.com/repos/matryer/bitbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matryer/bitbar/downloads","issues_url":"https://api.github.com/repos/matryer/bitbar/issues{/number}","pulls_url":"https://api.github.com/repos/matryer/bitbar/pulls{/number}","milestones_url":"https://api.github.com/repos/matryer/bitbar/milestones{/number}","notifications_url":"https://api.github.com/repos/matryer/bitbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matryer/bitbar/labels{/name}","releases_url":"https://api.github.com/repos/matryer/bitbar/releases{/id}","created_at":"2013-11-13T21:00:12Z","updated_at":"2016-01-05T12:47:34Z","pushed_at":"2016-01-05T12:30:46Z","git_url":"git://github.com/matryer/bitbar.git","ssh_url":"git@github.com:matryer/bitbar.git","clone_url":"https://github.com/matryer/bitbar.git","svn_url":"https://github.com/matryer/bitbar","homepage":"","size":2701,"stargazers_count":1481,"watchers_count":1481,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":15,"forks":53,"open_issues":15,"watchers":1481,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matryer/bitbar/pulls/40"},"html":{"href":"https://github.com/matryer/bitbar/pull/40"},"issue":{"href":"https://api.github.com/repos/matryer/bitbar/issues/40"},"comments":{"href":"https://api.github.com/repos/matryer/bitbar/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/matryer/bitbar/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/matryer/bitbar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matryer/bitbar/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/matryer/bitbar/statuses/1b2bc162a85d187e81644cb1ebdbe942844d1e27"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":6,"additions":63,"deletions":40,"changed_files":4}}