{"action":"created","comment":{"url":"https://api.github.com/repos/redhat-cip/skydive/pulls/comments/52820577","id":52820577,"diff_hunk":"@@ -161,6 +160,47 @@ func TestSFlowAgent(t *testing.T) {\n \n \t\t/* FIXME (nplanel) remove this Sleep when agent.FlushFlowTable() exist */\n \t\ttime.Sleep(2 * time.Second)\n-\t\tts.Validate(t, &trace)\n+\t\tpcapTraceValidate(t, ts.GetFlows(), &trace)\n+\t}\n+}\n+\n+func TestSFlowProbPath(t *testing.T) {\n+\thostname, err := os.Hostname()\n+\tif err != nil {\n+\t\tt.Fatal(err.Error())\n+\t}\n+\n+\tts := NewTestStorage()\n+\n+\tagent, analyzer := helper.StartAgentAndAnalyzerWithConfig(t, confAgentAnalyzer, ts)\n+\tdefer agent.Stop()\n+\tdefer analyzer.Stop()\n+\n+\ttime.Sleep(2 * time.Second)\n+\tsetupCmds := []helper.Cmd{\n+\t\t{\"ovs-vsctl add-br br-sflow\", true},\n+\t\t{\"ovs-vsctl add-port br-sflow sflow-intf1 -- set interface sflow-intf1 type=internal\", true},\n+\t\t{\"ip address add 169.254.33.33/24 dev sflow-intf1\", true},\n+\t\t{\"ip link set sflow-intf1 up\", true},\n+\t\t{\"ping -c 10 -I sflow-intf1 169.254.33.34\", false},","path":"tests/sflow_test.go","position":125,"original_position":125,"commit_id":"16dc64fab3c4c132347ecd2a2e8b7ce29d794b59","original_commit_id":"16dc64fab3c4c132347ecd2a2e8b7ce29d794b59","user":{"login":"nplanel","id":334425,"avatar_url":"https://avatars.githubusercontent.com/u/334425?v=3","gravatar_id":"","url":"https://api.github.com/users/nplanel","html_url":"https://github.com/nplanel","followers_url":"https://api.github.com/users/nplanel/followers","following_url":"https://api.github.com/users/nplanel/following{/other_user}","gists_url":"https://api.github.com/users/nplanel/gists{/gist_id}","starred_url":"https://api.github.com/users/nplanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nplanel/subscriptions","organizations_url":"https://api.github.com/users/nplanel/orgs","repos_url":"https://api.github.com/users/nplanel/repos","events_url":"https://api.github.com/users/nplanel/events{/privacy}","received_events_url":"https://api.github.com/users/nplanel/received_events","type":"User","site_admin":false},"body":"may add a fake mac for .34 via arp -s, before the ping, this will generate icmp that we can test via f.LayersPath","created_at":"2016-02-13T01:54:58Z","updated_at":"2016-02-13T01:54:58Z","html_url":"https://github.com/redhat-cip/skydive/pull/63#discussion_r52820577","pull_request_url":"https://api.github.com/repos/redhat-cip/skydive/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/redhat-cip/skydive/pulls/comments/52820577"},"html":{"href":"https://github.com/redhat-cip/skydive/pull/63#discussion_r52820577"},"pull_request":{"href":"https://api.github.com/repos/redhat-cip/skydive/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/redhat-cip/skydive/pulls/63","id":59049998,"html_url":"https://github.com/redhat-cip/skydive/pull/63","diff_url":"https://github.com/redhat-cip/skydive/pull/63.diff","patch_url":"https://github.com/redhat-cip/skydive/pull/63.patch","issue_url":"https://api.github.com/repos/redhat-cip/skydive/issues/63","number":63,"state":"open","locked":false,"title":"Fix probePath mapping, refactor test helpers add functional test","user":{"login":"safchain","id":2663912,"avatar_url":"https://avatars.githubusercontent.com/u/2663912?v=3","gravatar_id":"","url":"https://api.github.com/users/safchain","html_url":"https://github.com/safchain","followers_url":"https://api.github.com/users/safchain/followers","following_url":"https://api.github.com/users/safchain/following{/other_user}","gists_url":"https://api.github.com/users/safchain/gists{/gist_id}","starred_url":"https://api.github.com/users/safchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safchain/subscriptions","organizations_url":"https://api.github.com/users/safchain/orgs","repos_url":"https://api.github.com/users/safchain/repos","events_url":"https://api.github.com/users/safchain/events{/privacy}","received_events_url":"https://api.github.com/users/safchain/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-11T15:50:49Z","updated_at":"2016-02-13T01:54:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6c48b0e331ae627de8d6402f0e3340c45c603e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/redhat-cip/skydive/pulls/63/commits","review_comments_url":"https://api.github.com/repos/redhat-cip/skydive/pulls/63/comments","review_comment_url":"https://api.github.com/repos/redhat-cip/skydive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redhat-cip/skydive/issues/63/comments","statuses_url":"https://api.github.com/repos/redhat-cip/skydive/statuses/16dc64fab3c4c132347ecd2a2e8b7ce29d794b59","head":{"label":"safchain:mapping_fix","ref":"mapping_fix","sha":"16dc64fab3c4c132347ecd2a2e8b7ce29d794b59","user":{"login":"safchain","id":2663912,"avatar_url":"https://avatars.githubusercontent.com/u/2663912?v=3","gravatar_id":"","url":"https://api.github.com/users/safchain","html_url":"https://github.com/safchain","followers_url":"https://api.github.com/users/safchain/followers","following_url":"https://api.github.com/users/safchain/following{/other_user}","gists_url":"https://api.github.com/users/safchain/gists{/gist_id}","starred_url":"https://api.github.com/users/safchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safchain/subscriptions","organizations_url":"https://api.github.com/users/safchain/orgs","repos_url":"https://api.github.com/users/safchain/repos","events_url":"https://api.github.com/users/safchain/events{/privacy}","received_events_url":"https://api.github.com/users/safchain/received_events","type":"User","site_admin":false},"repo":{"id":44610204,"name":"skydive","full_name":"safchain/skydive","owner":{"login":"safchain","id":2663912,"avatar_url":"https://avatars.githubusercontent.com/u/2663912?v=3","gravatar_id":"","url":"https://api.github.com/users/safchain","html_url":"https://github.com/safchain","followers_url":"https://api.github.com/users/safchain/followers","following_url":"https://api.github.com/users/safchain/following{/other_user}","gists_url":"https://api.github.com/users/safchain/gists{/gist_id}","starred_url":"https://api.github.com/users/safchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safchain/subscriptions","organizations_url":"https://api.github.com/users/safchain/orgs","repos_url":"https://api.github.com/users/safchain/repos","events_url":"https://api.github.com/users/safchain/events{/privacy}","received_events_url":"https://api.github.com/users/safchain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/safchain/skydive","description":"","fork":true,"url":"https://api.github.com/repos/safchain/skydive","forks_url":"https://api.github.com/repos/safchain/skydive/forks","keys_url":"https://api.github.com/repos/safchain/skydive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/safchain/skydive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/safchain/skydive/teams","hooks_url":"https://api.github.com/repos/safchain/skydive/hooks","issue_events_url":"https://api.github.com/repos/safchain/skydive/issues/events{/number}","events_url":"https://api.github.com/repos/safchain/skydive/events","assignees_url":"https://api.github.com/repos/safchain/skydive/assignees{/user}","branches_url":"https://api.github.com/repos/safchain/skydive/branches{/branch}","tags_url":"https://api.github.com/repos/safchain/skydive/tags","blobs_url":"https://api.github.com/repos/safchain/skydive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/safchain/skydive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/safchain/skydive/git/refs{/sha}","trees_url":"https://api.github.com/repos/safchain/skydive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/safchain/skydive/statuses/{sha}","languages_url":"https://api.github.com/repos/safchain/skydive/languages","stargazers_url":"https://api.github.com/repos/safchain/skydive/stargazers","contributors_url":"https://api.github.com/repos/safchain/skydive/contributors","subscribers_url":"https://api.github.com/repos/safchain/skydive/subscribers","subscription_url":"https://api.github.com/repos/safchain/skydive/subscription","commits_url":"https://api.github.com/repos/safchain/skydive/commits{/sha}","git_commits_url":"https://api.github.com/repos/safchain/skydive/git/commits{/sha}","comments_url":"https://api.github.com/repos/safchain/skydive/comments{/number}","issue_comment_url":"https://api.github.com/repos/safchain/skydive/issues/comments{/number}","contents_url":"https://api.github.com/repos/safchain/skydive/contents/{+path}","compare_url":"https://api.github.com/repos/safchain/skydive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/safchain/skydive/merges","archive_url":"https://api.github.com/repos/safchain/skydive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/safchain/skydive/downloads","issues_url":"https://api.github.com/repos/safchain/skydive/issues{/number}","pulls_url":"https://api.github.com/repos/safchain/skydive/pulls{/number}","milestones_url":"https://api.github.com/repos/safchain/skydive/milestones{/number}","notifications_url":"https://api.github.com/repos/safchain/skydive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/safchain/skydive/labels{/name}","releases_url":"https://api.github.com/repos/safchain/skydive/releases{/id}","deployments_url":"https://api.github.com/repos/safchain/skydive/deployments","created_at":"2015-10-20T14:02:30Z","updated_at":"2015-10-20T15:26:09Z","pushed_at":"2016-02-12T22:55:26Z","git_url":"git://github.com/safchain/skydive.git","ssh_url":"git@github.com:safchain/skydive.git","clone_url":"https://github.com/safchain/skydive.git","svn_url":"https://github.com/safchain/skydive","homepage":null,"size":2036,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"redhat-cip:master","ref":"master","sha":"eaf54aad02fbb57647596f2ac73814d19a71ac07","user":{"login":"redhat-cip","id":1607795,"avatar_url":"https://avatars.githubusercontent.com/u/1607795?v=3","gravatar_id":"","url":"https://api.github.com/users/redhat-cip","html_url":"https://github.com/redhat-cip","followers_url":"https://api.github.com/users/redhat-cip/followers","following_url":"https://api.github.com/users/redhat-cip/following{/other_user}","gists_url":"https://api.github.com/users/redhat-cip/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-cip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-cip/subscriptions","organizations_url":"https://api.github.com/users/redhat-cip/orgs","repos_url":"https://api.github.com/users/redhat-cip/repos","events_url":"https://api.github.com/users/redhat-cip/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-cip/received_events","type":"Organization","site_admin":false},"repo":{"id":44610195,"name":"skydive","full_name":"redhat-cip/skydive","owner":{"login":"redhat-cip","id":1607795,"avatar_url":"https://avatars.githubusercontent.com/u/1607795?v=3","gravatar_id":"","url":"https://api.github.com/users/redhat-cip","html_url":"https://github.com/redhat-cip","followers_url":"https://api.github.com/users/redhat-cip/followers","following_url":"https://api.github.com/users/redhat-cip/following{/other_user}","gists_url":"https://api.github.com/users/redhat-cip/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-cip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-cip/subscriptions","organizations_url":"https://api.github.com/users/redhat-cip/orgs","repos_url":"https://api.github.com/users/redhat-cip/repos","events_url":"https://api.github.com/users/redhat-cip/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-cip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redhat-cip/skydive","description":"An open source real-time network topology and protocols analyzer","fork":false,"url":"https://api.github.com/repos/redhat-cip/skydive","forks_url":"https://api.github.com/repos/redhat-cip/skydive/forks","keys_url":"https://api.github.com/repos/redhat-cip/skydive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redhat-cip/skydive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redhat-cip/skydive/teams","hooks_url":"https://api.github.com/repos/redhat-cip/skydive/hooks","issue_events_url":"https://api.github.com/repos/redhat-cip/skydive/issues/events{/number}","events_url":"https://api.github.com/repos/redhat-cip/skydive/events","assignees_url":"https://api.github.com/repos/redhat-cip/skydive/assignees{/user}","branches_url":"https://api.github.com/repos/redhat-cip/skydive/branches{/branch}","tags_url":"https://api.github.com/repos/redhat-cip/skydive/tags","blobs_url":"https://api.github.com/repos/redhat-cip/skydive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redhat-cip/skydive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redhat-cip/skydive/git/refs{/sha}","trees_url":"https://api.github.com/repos/redhat-cip/skydive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redhat-cip/skydive/statuses/{sha}","languages_url":"https://api.github.com/repos/redhat-cip/skydive/languages","stargazers_url":"https://api.github.com/repos/redhat-cip/skydive/stargazers","contributors_url":"https://api.github.com/repos/redhat-cip/skydive/contributors","subscribers_url":"https://api.github.com/repos/redhat-cip/skydive/subscribers","subscription_url":"https://api.github.com/repos/redhat-cip/skydive/subscription","commits_url":"https://api.github.com/repos/redhat-cip/skydive/commits{/sha}","git_commits_url":"https://api.github.com/repos/redhat-cip/skydive/git/commits{/sha}","comments_url":"https://api.github.com/repos/redhat-cip/skydive/comments{/number}","issue_comment_url":"https://api.github.com/repos/redhat-cip/skydive/issues/comments{/number}","contents_url":"https://api.github.com/repos/redhat-cip/skydive/contents/{+path}","compare_url":"https://api.github.com/repos/redhat-cip/skydive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redhat-cip/skydive/merges","archive_url":"https://api.github.com/repos/redhat-cip/skydive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redhat-cip/skydive/downloads","issues_url":"https://api.github.com/repos/redhat-cip/skydive/issues{/number}","pulls_url":"https://api.github.com/repos/redhat-cip/skydive/pulls{/number}","milestones_url":"https://api.github.com/repos/redhat-cip/skydive/milestones{/number}","notifications_url":"https://api.github.com/repos/redhat-cip/skydive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redhat-cip/skydive/labels{/name}","releases_url":"https://api.github.com/repos/redhat-cip/skydive/releases{/id}","deployments_url":"https://api.github.com/repos/redhat-cip/skydive/deployments","created_at":"2015-10-20T14:02:21Z","updated_at":"2016-02-06T23:16:46Z","pushed_at":"2016-02-12T22:55:26Z","git_url":"git://github.com/redhat-cip/skydive.git","ssh_url":"git@github.com:redhat-cip/skydive.git","clone_url":"https://github.com/redhat-cip/skydive.git","svn_url":"https://github.com/redhat-cip/skydive","homepage":"","size":2155,"stargazers_count":19,"watchers_count":19,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":7,"forks":6,"open_issues":7,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redhat-cip/skydive/pulls/63"},"html":{"href":"https://github.com/redhat-cip/skydive/pull/63"},"issue":{"href":"https://api.github.com/repos/redhat-cip/skydive/issues/63"},"comments":{"href":"https://api.github.com/repos/redhat-cip/skydive/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/redhat-cip/skydive/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/redhat-cip/skydive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redhat-cip/skydive/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/redhat-cip/skydive/statuses/16dc64fab3c4c132347ecd2a2e8b7ce29d794b59"}}}}