{"action":"created","issue":{"url":"https://api.github.com/repos/namshi/jose/issues/85","repository_url":"https://api.github.com/repos/namshi/jose","labels_url":"https://api.github.com/repos/namshi/jose/issues/85/labels{/name}","comments_url":"https://api.github.com/repos/namshi/jose/issues/85/comments","events_url":"https://api.github.com/repos/namshi/jose/issues/85/events","html_url":"https://github.com/namshi/jose/pull/85","id":137247336,"number":85,"title":"Signature fix","user":{"login":"stuartm","id":475492,"avatar_url":"https://avatars.githubusercontent.com/u/475492?v=3","gravatar_id":"","url":"https://api.github.com/users/stuartm","html_url":"https://github.com/stuartm","followers_url":"https://api.github.com/users/stuartm/followers","following_url":"https://api.github.com/users/stuartm/following{/other_user}","gists_url":"https://api.github.com/users/stuartm/gists{/gist_id}","starred_url":"https://api.github.com/users/stuartm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuartm/subscriptions","organizations_url":"https://api.github.com/users/stuartm/orgs","repos_url":"https://api.github.com/users/stuartm/repos","events_url":"https://api.github.com/users/stuartm/events{/privacy}","received_events_url":"https://api.github.com/users/stuartm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-02-29T12:59:52Z","updated_at":"2016-03-31T09:05:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/namshi/jose/pulls/85","html_url":"https://github.com/namshi/jose/pull/85","diff_url":"https://github.com/namshi/jose/pull/85.diff","patch_url":"https://github.com/namshi/jose/pull/85.patch"},"body":"This fixes signature creation, the presently generated signature doesn't comply with the RFC and is rejected by other applications/libraries. The reason is that the signature is base64 encoded as a string instead of a hexidecimal representation of octets.\r\n\r\nConvert signature to binary before base64 encode results in the expected signature as verified against the example in RFC 7515 and the http://jwt.io debugger.\r\n\r\nResults may be validated with:\r\n`echo -n \"base64_encoded_header.base64_encoded_payload\"  | openssl dgst -sha256 -hmac \"your_secret\" -binary | base64 | tr -- '+=/' '- _'`"},"comment":{"url":"https://api.github.com/repos/namshi/jose/issues/comments/203835207","html_url":"https://github.com/namshi/jose/pull/85#issuecomment-203835207","issue_url":"https://api.github.com/repos/namshi/jose/issues/85","id":203835207,"user":{"login":"stuartm","id":475492,"avatar_url":"https://avatars.githubusercontent.com/u/475492?v=3","gravatar_id":"","url":"https://api.github.com/users/stuartm","html_url":"https://github.com/stuartm","followers_url":"https://api.github.com/users/stuartm/followers","following_url":"https://api.github.com/users/stuartm/following{/other_user}","gists_url":"https://api.github.com/users/stuartm/gists{/gist_id}","starred_url":"https://api.github.com/users/stuartm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuartm/subscriptions","organizations_url":"https://api.github.com/users/stuartm/orgs","repos_url":"https://api.github.com/users/stuartm/repos","events_url":"https://api.github.com/users/stuartm/events{/privacy}","received_events_url":"https://api.github.com/users/stuartm/received_events","type":"User","site_admin":false},"created_at":"2016-03-31T09:05:43Z","updated_at":"2016-03-31T09:05:43Z","body":"Sorry, work has been really crazy. I'll make time tonight to sort this out."}}