{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/fbthrift/pulls/comments/76707957","id":76707957,"diff_hunk":"@@ -173,7 +173,7 @@ libthriftprotocol_la_SOURCES = Version.cpp \\\n                                protocol/SimpleJSONProtocol.cpp \\\n                                protocol/VirtualProtocol.cpp\n \n-libthriftprotocol_la_LIBADD = $(FOLLY_LIBS) $(BOOST_SYSTEM_LIB)\n+libthriftprotocol_la_LIBADD = $(FOLLY_LIBS) $(BOOST_SYSTEM_LIB) -ldouble-conversion","path":"thrift/lib/cpp2/Makefile.am","position":null,"original_position":5,"commit_id":"9d71e37c8c71fe6485f6e6cfc99eb2b549c9c877","original_commit_id":"b10347382e7215cf25386efccbb6c60aa94d127a","user":{"login":"seanfarley","id":20887,"avatar_url":"https://avatars.githubusercontent.com/u/20887?v=3","gravatar_id":"","url":"https://api.github.com/users/seanfarley","html_url":"https://github.com/seanfarley","followers_url":"https://api.github.com/users/seanfarley/followers","following_url":"https://api.github.com/users/seanfarley/following{/other_user}","gists_url":"https://api.github.com/users/seanfarley/gists{/gist_id}","starred_url":"https://api.github.com/users/seanfarley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanfarley/subscriptions","organizations_url":"https://api.github.com/users/seanfarley/orgs","repos_url":"https://api.github.com/users/seanfarley/repos","events_url":"https://api.github.com/users/seanfarley/events{/privacy}","received_events_url":"https://api.github.com/users/seanfarley/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2016-08-29T23:39:19Z","updated_at":"2016-08-29T23:39:19Z","html_url":"https://github.com/facebook/fbthrift/pull/172#discussion_r76707957","pull_request_url":"https://api.github.com/repos/facebook/fbthrift/pulls/172","_links":{"self":{"href":"https://api.github.com/repos/facebook/fbthrift/pulls/comments/76707957"},"html":{"href":"https://github.com/facebook/fbthrift/pull/172#discussion_r76707957"},"pull_request":{"href":"https://api.github.com/repos/facebook/fbthrift/pulls/172"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/fbthrift/pulls/172","id":83030613,"html_url":"https://github.com/facebook/fbthrift/pull/172","diff_url":"https://github.com/facebook/fbthrift/pull/172.diff","patch_url":"https://github.com/facebook/fbthrift/pull/172.patch","issue_url":"https://api.github.com/repos/facebook/fbthrift/issues/172","number":172,"state":"open","locked":false,"title":"Fix macos build","user":{"login":"seanfarley","id":20887,"avatar_url":"https://avatars.githubusercontent.com/u/20887?v=3","gravatar_id":"","url":"https://api.github.com/users/seanfarley","html_url":"https://github.com/seanfarley","followers_url":"https://api.github.com/users/seanfarley/followers","following_url":"https://api.github.com/users/seanfarley/following{/other_user}","gists_url":"https://api.github.com/users/seanfarley/gists{/gist_id}","starred_url":"https://api.github.com/users/seanfarley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanfarley/subscriptions","organizations_url":"https://api.github.com/users/seanfarley/orgs","repos_url":"https://api.github.com/users/seanfarley/repos","events_url":"https://api.github.com/users/seanfarley/events{/privacy}","received_events_url":"https://api.github.com/users/seanfarley/received_events","type":"User","site_admin":false},"body":"At the suggestion of @wez, I'm contributing back some of my work to get fbthrift to build on macOS. These are the minimum set of changes I could find to have the familiar `./configure && make install` work.\r\n\r\nMost of these changes are fairly straight-forward: improve the usage of autotools. The biggest change is renaming `thrift/lib/cpp/thrift_config.h` to `thrift/lib/cpp/thrift_config.h.in`. This change is transparent for autoconf users but I have no idea how this will affect whatever tools you use internally at Facebook.\r\n\r\nAll in all, I was able to get fbthrift building through macports which I can push up later.","created_at":"2016-08-28T23:18:01Z","updated_at":"2016-08-29T23:39:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f10181ac715340e4b44667edf8bb71a00062ef77","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/fbthrift/pulls/172/commits","review_comments_url":"https://api.github.com/repos/facebook/fbthrift/pulls/172/comments","review_comment_url":"https://api.github.com/repos/facebook/fbthrift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/fbthrift/issues/172/comments","statuses_url":"https://api.github.com/repos/facebook/fbthrift/statuses/9d71e37c8c71fe6485f6e6cfc99eb2b549c9c877","head":{"label":"seanfarley:fix-macos-build","ref":"fix-macos-build","sha":"9d71e37c8c71fe6485f6e6cfc99eb2b549c9c877","user":{"login":"seanfarley","id":20887,"avatar_url":"https://avatars.githubusercontent.com/u/20887?v=3","gravatar_id":"","url":"https://api.github.com/users/seanfarley","html_url":"https://github.com/seanfarley","followers_url":"https://api.github.com/users/seanfarley/followers","following_url":"https://api.github.com/users/seanfarley/following{/other_user}","gists_url":"https://api.github.com/users/seanfarley/gists{/gist_id}","starred_url":"https://api.github.com/users/seanfarley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanfarley/subscriptions","organizations_url":"https://api.github.com/users/seanfarley/orgs","repos_url":"https://api.github.com/users/seanfarley/repos","events_url":"https://api.github.com/users/seanfarley/events{/privacy}","received_events_url":"https://api.github.com/users/seanfarley/received_events","type":"User","site_admin":false},"repo":{"id":66507870,"name":"fbthrift","full_name":"seanfarley/fbthrift","owner":{"login":"seanfarley","id":20887,"avatar_url":"https://avatars.githubusercontent.com/u/20887?v=3","gravatar_id":"","url":"https://api.github.com/users/seanfarley","html_url":"https://github.com/seanfarley","followers_url":"https://api.github.com/users/seanfarley/followers","following_url":"https://api.github.com/users/seanfarley/following{/other_user}","gists_url":"https://api.github.com/users/seanfarley/gists{/gist_id}","starred_url":"https://api.github.com/users/seanfarley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanfarley/subscriptions","organizations_url":"https://api.github.com/users/seanfarley/orgs","repos_url":"https://api.github.com/users/seanfarley/repos","events_url":"https://api.github.com/users/seanfarley/events{/privacy}","received_events_url":"https://api.github.com/users/seanfarley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seanfarley/fbthrift","description":"Facebook's branch of Apache Thrift, including a new C++ server.","fork":true,"url":"https://api.github.com/repos/seanfarley/fbthrift","forks_url":"https://api.github.com/repos/seanfarley/fbthrift/forks","keys_url":"https://api.github.com/repos/seanfarley/fbthrift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seanfarley/fbthrift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seanfarley/fbthrift/teams","hooks_url":"https://api.github.com/repos/seanfarley/fbthrift/hooks","issue_events_url":"https://api.github.com/repos/seanfarley/fbthrift/issues/events{/number}","events_url":"https://api.github.com/repos/seanfarley/fbthrift/events","assignees_url":"https://api.github.com/repos/seanfarley/fbthrift/assignees{/user}","branches_url":"https://api.github.com/repos/seanfarley/fbthrift/branches{/branch}","tags_url":"https://api.github.com/repos/seanfarley/fbthrift/tags","blobs_url":"https://api.github.com/repos/seanfarley/fbthrift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seanfarley/fbthrift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seanfarley/fbthrift/git/refs{/sha}","trees_url":"https://api.github.com/repos/seanfarley/fbthrift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seanfarley/fbthrift/statuses/{sha}","languages_url":"https://api.github.com/repos/seanfarley/fbthrift/languages","stargazers_url":"https://api.github.com/repos/seanfarley/fbthrift/stargazers","contributors_url":"https://api.github.com/repos/seanfarley/fbthrift/contributors","subscribers_url":"https://api.github.com/repos/seanfarley/fbthrift/subscribers","subscription_url":"https://api.github.com/repos/seanfarley/fbthrift/subscription","commits_url":"https://api.github.com/repos/seanfarley/fbthrift/commits{/sha}","git_commits_url":"https://api.github.com/repos/seanfarley/fbthrift/git/commits{/sha}","comments_url":"https://api.github.com/repos/seanfarley/fbthrift/comments{/number}","issue_comment_url":"https://api.github.com/repos/seanfarley/fbthrift/issues/comments{/number}","contents_url":"https://api.github.com/repos/seanfarley/fbthrift/contents/{+path}","compare_url":"https://api.github.com/repos/seanfarley/fbthrift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seanfarley/fbthrift/merges","archive_url":"https://api.github.com/repos/seanfarley/fbthrift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seanfarley/fbthrift/downloads","issues_url":"https://api.github.com/repos/seanfarley/fbthrift/issues{/number}","pulls_url":"https://api.github.com/repos/seanfarley/fbthrift/pulls{/number}","milestones_url":"https://api.github.com/repos/seanfarley/fbthrift/milestones{/number}","notifications_url":"https://api.github.com/repos/seanfarley/fbthrift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seanfarley/fbthrift/labels{/name}","releases_url":"https://api.github.com/repos/seanfarley/fbthrift/releases{/id}","deployments_url":"https://api.github.com/repos/seanfarley/fbthrift/deployments","created_at":"2016-08-24T23:49:02Z","updated_at":"2016-08-24T23:49:10Z","pushed_at":"2016-08-28T23:04:40Z","git_url":"git://github.com/seanfarley/fbthrift.git","ssh_url":"git@github.com:seanfarley/fbthrift.git","clone_url":"https://github.com/seanfarley/fbthrift.git","svn_url":"https://github.com/seanfarley/fbthrift","homepage":"","size":13003,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"a7d2b6646fe241aaa7e7fd5943307033f069a21d","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":11131631,"name":"fbthrift","full_name":"facebook/fbthrift","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/fbthrift","description":"Facebook's branch of Apache Thrift, including a new C++ server.","fork":false,"url":"https://api.github.com/repos/facebook/fbthrift","forks_url":"https://api.github.com/repos/facebook/fbthrift/forks","keys_url":"https://api.github.com/repos/facebook/fbthrift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/fbthrift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/fbthrift/teams","hooks_url":"https://api.github.com/repos/facebook/fbthrift/hooks","issue_events_url":"https://api.github.com/repos/facebook/fbthrift/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/fbthrift/events","assignees_url":"https://api.github.com/repos/facebook/fbthrift/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/fbthrift/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/fbthrift/tags","blobs_url":"https://api.github.com/repos/facebook/fbthrift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/fbthrift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/fbthrift/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/fbthrift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/fbthrift/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/fbthrift/languages","stargazers_url":"https://api.github.com/repos/facebook/fbthrift/stargazers","contributors_url":"https://api.github.com/repos/facebook/fbthrift/contributors","subscribers_url":"https://api.github.com/repos/facebook/fbthrift/subscribers","subscription_url":"https://api.github.com/repos/facebook/fbthrift/subscription","commits_url":"https://api.github.com/repos/facebook/fbthrift/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/fbthrift/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/fbthrift/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/fbthrift/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/fbthrift/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/fbthrift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/fbthrift/merges","archive_url":"https://api.github.com/repos/facebook/fbthrift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/fbthrift/downloads","issues_url":"https://api.github.com/repos/facebook/fbthrift/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/fbthrift/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/fbthrift/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/fbthrift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/fbthrift/labels{/name}","releases_url":"https://api.github.com/repos/facebook/fbthrift/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/fbthrift/deployments","created_at":"2013-07-02T18:15:51Z","updated_at":"2016-08-29T13:30:24Z","pushed_at":"2016-08-29T21:15:23Z","git_url":"git://github.com/facebook/fbthrift.git","ssh_url":"git@github.com:facebook/fbthrift.git","clone_url":"https://github.com/facebook/fbthrift.git","svn_url":"https://github.com/facebook/fbthrift","homepage":"","size":13839,"stargazers_count":807,"watchers_count":807,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":231,"mirror_url":null,"open_issues_count":41,"forks":231,"open_issues":41,"watchers":807,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/fbthrift/pulls/172"},"html":{"href":"https://github.com/facebook/fbthrift/pull/172"},"issue":{"href":"https://api.github.com/repos/facebook/fbthrift/issues/172"},"comments":{"href":"https://api.github.com/repos/facebook/fbthrift/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/fbthrift/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/fbthrift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/fbthrift/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/fbthrift/statuses/9d71e37c8c71fe6485f6e6cfc99eb2b549c9c877"}}}}
{"actor":{"display_login":"seanfarley"}}