{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/record_store/pulls/comments/73319460","id":73319460,"diff_hunk":"@@ -251,5 +270,10 @@ def zones_modified\n \n       modified_zones\n     end\n+\n+    def validate_format","path":"lib/record_store/cli.rb","position":48,"original_position":48,"commit_id":"b317627c86d6fc5992e6ea1ddd49a8515a014e3c","original_commit_id":"b317627c86d6fc5992e6ea1ddd49a8515a014e3c","user":{"login":"es","id":2137369,"avatar_url":"https://avatars.githubusercontent.com/u/2137369?v=3","gravatar_id":"","url":"https://api.github.com/users/es","html_url":"https://github.com/es","followers_url":"https://api.github.com/users/es/followers","following_url":"https://api.github.com/users/es/following{/other_user}","gists_url":"https://api.github.com/users/es/gists{/gist_id}","starred_url":"https://api.github.com/users/es/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/es/subscriptions","organizations_url":"https://api.github.com/users/es/orgs","repos_url":"https://api.github.com/users/es/repos","events_url":"https://api.github.com/users/es/events{/privacy}","received_events_url":"https://api.github.com/users/es/received_events","type":"User","site_admin":false},"body":"`validate_format` should have a different name since it's returning the format.","created_at":"2016-08-03T11:05:43Z","updated_at":"2016-08-03T11:05:43Z","html_url":"https://github.com/Shopify/record_store/pull/10#discussion_r73319460","pull_request_url":"https://api.github.com/repos/Shopify/record_store/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/Shopify/record_store/pulls/comments/73319460"},"html":{"href":"https://github.com/Shopify/record_store/pull/10#discussion_r73319460"},"pull_request":{"href":"https://api.github.com/repos/Shopify/record_store/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/record_store/pulls/10","id":76439754,"html_url":"https://github.com/Shopify/record_store/pull/10","diff_url":"https://github.com/Shopify/record_store/pull/10.diff","patch_url":"https://github.com/Shopify/record_store/pull/10.patch","issue_url":"https://api.github.com/repos/Shopify/record_store/issues/10","number":10,"state":"open","locked":false,"title":"Handle zones as directories","user":{"login":"etiennebarrie","id":3535,"avatar_url":"https://avatars.githubusercontent.com/u/3535?v=3","gravatar_id":"","url":"https://api.github.com/users/etiennebarrie","html_url":"https://github.com/etiennebarrie","followers_url":"https://api.github.com/users/etiennebarrie/followers","following_url":"https://api.github.com/users/etiennebarrie/following{/other_user}","gists_url":"https://api.github.com/users/etiennebarrie/gists{/gist_id}","starred_url":"https://api.github.com/users/etiennebarrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etiennebarrie/subscriptions","organizations_url":"https://api.github.com/users/etiennebarrie/orgs","repos_url":"https://api.github.com/users/etiennebarrie/repos","events_url":"https://api.github.com/users/etiennebarrie/events{/privacy}","received_events_url":"https://api.github.com/users/etiennebarrie/received_events","type":"User","site_admin":false},"body":"To make it easier to script committing changes to DNS records, we thought it would be easier if zones were broken up a bit into different files sitting in a directory.\r\n\r\nI added support for records in separate files, but keeping all records in the zone file is still supported.\r\n\r\n~~I moved to a directory with a file for the config and different files for the records.~~\r\n\r\n* the zone file is still there, but records can be additionally stored in other files under a directory named after the zone (e.g. same as the zone file, except it's a directory and doesn't end in `.yml`)\r\n* records are grouped into YAML files by FQDN and record type, which means there still can be multiple records inside a YAML file, but I think it makes sense\r\n* no special case for wildcard domains, so there can be file names starting with `*`, I don't think it's a problem though.\r\n* the previous layout is still supported, but zones are downloaded using the new layout\r\n* I also added a way to \"lint\" a zone (all zones by default), which is somewhat similar to the existing `record-store sort` command, to help move from the single file zone to the new layout. LMK if you have a better name.\r\n* ~~the config file is named `config.yml` but I'm thinking we should rename it `_config.yml` so that it sits at the top of the directory.~~\r\n","created_at":"2016-07-06T14:17:53Z","updated_at":"2016-08-03T11:05:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e121b74ea09a54b386eadc0943b905457f0d357","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/record_store/pulls/10/commits","review_comments_url":"https://api.github.com/repos/Shopify/record_store/pulls/10/comments","review_comment_url":"https://api.github.com/repos/Shopify/record_store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/record_store/issues/10/comments","statuses_url":"https://api.github.com/repos/Shopify/record_store/statuses/b317627c86d6fc5992e6ea1ddd49a8515a014e3c","head":{"label":"Shopify:zone-dir","ref":"zone-dir","sha":"b317627c86d6fc5992e6ea1ddd49a8515a014e3c","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":62681657,"name":"record_store","full_name":"Shopify/record_store","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/record_store","description":"Manage DNS through a git-based workflow","fork":false,"url":"https://api.github.com/repos/Shopify/record_store","forks_url":"https://api.github.com/repos/Shopify/record_store/forks","keys_url":"https://api.github.com/repos/Shopify/record_store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/record_store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/record_store/teams","hooks_url":"https://api.github.com/repos/Shopify/record_store/hooks","issue_events_url":"https://api.github.com/repos/Shopify/record_store/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/record_store/events","assignees_url":"https://api.github.com/repos/Shopify/record_store/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/record_store/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/record_store/tags","blobs_url":"https://api.github.com/repos/Shopify/record_store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/record_store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/record_store/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/record_store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/record_store/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/record_store/languages","stargazers_url":"https://api.github.com/repos/Shopify/record_store/stargazers","contributors_url":"https://api.github.com/repos/Shopify/record_store/contributors","subscribers_url":"https://api.github.com/repos/Shopify/record_store/subscribers","subscription_url":"https://api.github.com/repos/Shopify/record_store/subscription","commits_url":"https://api.github.com/repos/Shopify/record_store/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/record_store/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/record_store/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/record_store/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/record_store/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/record_store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/record_store/merges","archive_url":"https://api.github.com/repos/Shopify/record_store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/record_store/downloads","issues_url":"https://api.github.com/repos/Shopify/record_store/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/record_store/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/record_store/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/record_store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/record_store/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/record_store/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/record_store/deployments","created_at":"2016-07-06T01:33:20Z","updated_at":"2016-07-27T04:22:13Z","pushed_at":"2016-07-27T15:43:14Z","git_url":"git://github.com/Shopify/record_store.git","ssh_url":"git@github.com:Shopify/record_store.git","clone_url":"https://github.com/Shopify/record_store.git","svn_url":"https://github.com/Shopify/record_store","homepage":null,"size":75,"stargazers_count":14,"watchers_count":14,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":9,"forks":1,"open_issues":9,"watchers":14,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"e7e8da139291c4de0e0bd6914836e080532f38c5","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":62681657,"name":"record_store","full_name":"Shopify/record_store","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/record_store","description":"Manage DNS through a git-based workflow","fork":false,"url":"https://api.github.com/repos/Shopify/record_store","forks_url":"https://api.github.com/repos/Shopify/record_store/forks","keys_url":"https://api.github.com/repos/Shopify/record_store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/record_store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/record_store/teams","hooks_url":"https://api.github.com/repos/Shopify/record_store/hooks","issue_events_url":"https://api.github.com/repos/Shopify/record_store/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/record_store/events","assignees_url":"https://api.github.com/repos/Shopify/record_store/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/record_store/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/record_store/tags","blobs_url":"https://api.github.com/repos/Shopify/record_store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/record_store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/record_store/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/record_store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/record_store/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/record_store/languages","stargazers_url":"https://api.github.com/repos/Shopify/record_store/stargazers","contributors_url":"https://api.github.com/repos/Shopify/record_store/contributors","subscribers_url":"https://api.github.com/repos/Shopify/record_store/subscribers","subscription_url":"https://api.github.com/repos/Shopify/record_store/subscription","commits_url":"https://api.github.com/repos/Shopify/record_store/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/record_store/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/record_store/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/record_store/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/record_store/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/record_store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/record_store/merges","archive_url":"https://api.github.com/repos/Shopify/record_store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/record_store/downloads","issues_url":"https://api.github.com/repos/Shopify/record_store/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/record_store/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/record_store/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/record_store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/record_store/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/record_store/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/record_store/deployments","created_at":"2016-07-06T01:33:20Z","updated_at":"2016-07-27T04:22:13Z","pushed_at":"2016-07-27T15:43:14Z","git_url":"git://github.com/Shopify/record_store.git","ssh_url":"git@github.com:Shopify/record_store.git","clone_url":"https://github.com/Shopify/record_store.git","svn_url":"https://github.com/Shopify/record_store","homepage":null,"size":75,"stargazers_count":14,"watchers_count":14,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":9,"forks":1,"open_issues":9,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/record_store/pulls/10"},"html":{"href":"https://github.com/Shopify/record_store/pull/10"},"issue":{"href":"https://api.github.com/repos/Shopify/record_store/issues/10"},"comments":{"href":"https://api.github.com/repos/Shopify/record_store/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/record_store/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/record_store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/record_store/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/record_store/statuses/b317627c86d6fc5992e6ea1ddd49a8515a014e3c"}}}}
{"actor":{"display_login":"es"}}