{"action":"created","comment":{"url":"https://api.github.com/repos/stan-dev/math/pulls/comments/61451166","id":61451166,"diff_hunk":"@@ -1,4 +1,5 @@\n #include <stan/math/mix/scal.hpp>\n+#include <stan/math/mix/mat.hpp>","path":"test/unit/math/mix/scal/fun/Phi_approx_test.cpp","position":2,"original_position":2,"commit_id":"0f1241c1ae53d24f815a298819702c87b958ca77","original_commit_id":"0f1241c1ae53d24f815a298819702c87b958ca77","user":{"login":"bob-carpenter","id":3383807,"avatar_url":"https://avatars.githubusercontent.com/u/3383807?v=3","gravatar_id":"","url":"https://api.github.com/users/bob-carpenter","html_url":"https://github.com/bob-carpenter","followers_url":"https://api.github.com/users/bob-carpenter/followers","following_url":"https://api.github.com/users/bob-carpenter/following{/other_user}","gists_url":"https://api.github.com/users/bob-carpenter/gists{/gist_id}","starred_url":"https://api.github.com/users/bob-carpenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bob-carpenter/subscriptions","organizations_url":"https://api.github.com/users/bob-carpenter/orgs","repos_url":"https://api.github.com/users/bob-carpenter/repos","events_url":"https://api.github.com/users/bob-carpenter/events{/privacy}","received_events_url":"https://api.github.com/users/bob-carpenter/received_events","type":"User","site_admin":false},"body":"Thanks for going through all the includes!\n\n- Bob\n\n> On Apr 27, 2016, at 6:30 PM, Daniel Lee <notifications@github.com> wrote:\n> \n> In test/unit/math/mix/scal/fun/Phi_approx_test.cpp:\n> \n> > @@ -1,4 +1,5 @@\n> >  #include <stan/math/mix/scal.hpp>\n> > +#include <stan/math/mix/mat.hpp>\n> \n> this shouldn't include a mix header.\n> \n> —\n> You are receiving this because you commented.\n> Reply to this email directly or view it on GitHub\n> \n\n","created_at":"2016-04-28T15:43:27Z","updated_at":"2016-04-28T15:43:27Z","html_url":"https://github.com/stan-dev/math/pull/276#discussion_r61451166","pull_request_url":"https://api.github.com/repos/stan-dev/math/pulls/276","_links":{"self":{"href":"https://api.github.com/repos/stan-dev/math/pulls/comments/61451166"},"html":{"href":"https://github.com/stan-dev/math/pull/276#discussion_r61451166"},"pull_request":{"href":"https://api.github.com/repos/stan-dev/math/pulls/276"}}},"pull_request":{"url":"https://api.github.com/repos/stan-dev/math/pulls/276","id":64972584,"html_url":"https://github.com/stan-dev/math/pull/276","diff_url":"https://github.com/stan-dev/math/pull/276.diff","patch_url":"https://github.com/stan-dev/math/pull/276.patch","issue_url":"https://api.github.com/repos/stan-dev/math/issues/276","number":276,"state":"open","locked":false,"title":"Feature/issue 202 vectorize all","user":{"login":"rayleigh","id":534737,"avatar_url":"https://avatars.githubusercontent.com/u/534737?v=3","gravatar_id":"","url":"https://api.github.com/users/rayleigh","html_url":"https://github.com/rayleigh","followers_url":"https://api.github.com/users/rayleigh/followers","following_url":"https://api.github.com/users/rayleigh/following{/other_user}","gists_url":"https://api.github.com/users/rayleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/rayleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rayleigh/subscriptions","organizations_url":"https://api.github.com/users/rayleigh/orgs","repos_url":"https://api.github.com/users/rayleigh/repos","events_url":"https://api.github.com/users/rayleigh/events{/privacy}","received_events_url":"https://api.github.com/users/rayleigh/received_events","type":"User","site_admin":false},"body":"#### Submisison Checklist\r\n\r\n- [x] Run unit tests: `./runTests.py test/unit`\r\n- [x] Run cpplint: `make cpplint`\r\n- [x] Declare copyright holder and open-source license: see below\r\n\r\n#### Summary:\r\nVectorization of unary functions and tests of these vectorizations\r\n\r\n#### Intended Effect:\r\nThis will add vectorized unary functions and their tests.\r\n\r\n#### How to Verify:\r\nRun unit tests\r\n\r\n#### Side Effects:\r\nUpdated the existing testing vectorizing framework to skip tests if the expected value and test value are both NaN. The example function foo_fun now returns NaN for 0.\r\n\r\nAdded the appropriate `apply_scalar_unary` function to `stan/math/prim/mat.hpp`, `stan/math/rev/mat.hpp`, and `stan/math/fwd/mat.hpp`. All tests in `stan/math/mix/scal/fun` and `test/unit/math/mix/scal/prob/normal_test.cpp` were updated to include `stan/math/mix/mat.hpp` so that they wouldn't error out.  \r\n\r\n#### Documentation:\r\nI have documented the code of the vectorized functions, but I don't think it's fully user-facing yet.\r\n\r\n#### Reviewer Suggestions: \r\n\r\n#### Copyright and Licensing\r\n\r\nPlease list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):\r\nRayleigh\r\n\r\nBy submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:\r\n- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)\r\n- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)\r\n","created_at":"2016-04-01T16:45:37Z","updated_at":"2016-04-28T15:43:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"601a9888ef553f0c255e9efcd08b68e2705c8caa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/stan-dev/math/pulls/276/commits","review_comments_url":"https://api.github.com/repos/stan-dev/math/pulls/276/comments","review_comment_url":"https://api.github.com/repos/stan-dev/math/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stan-dev/math/issues/276/comments","statuses_url":"https://api.github.com/repos/stan-dev/math/statuses/0f1241c1ae53d24f815a298819702c87b958ca77","head":{"label":"stan-dev:feature/issue-202-vectorize-all","ref":"feature/issue-202-vectorize-all","sha":"0f1241c1ae53d24f815a298819702c87b958ca77","user":{"login":"stan-dev","id":3374820,"avatar_url":"https://avatars.githubusercontent.com/u/3374820?v=3","gravatar_id":"","url":"https://api.github.com/users/stan-dev","html_url":"https://github.com/stan-dev","followers_url":"https://api.github.com/users/stan-dev/followers","following_url":"https://api.github.com/users/stan-dev/following{/other_user}","gists_url":"https://api.github.com/users/stan-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/stan-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stan-dev/subscriptions","organizations_url":"https://api.github.com/users/stan-dev/orgs","repos_url":"https://api.github.com/users/stan-dev/repos","events_url":"https://api.github.com/users/stan-dev/events{/privacy}","received_events_url":"https://api.github.com/users/stan-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":38388440,"name":"math","full_name":"stan-dev/math","owner":{"login":"stan-dev","id":3374820,"avatar_url":"https://avatars.githubusercontent.com/u/3374820?v=3","gravatar_id":"","url":"https://api.github.com/users/stan-dev","html_url":"https://github.com/stan-dev","followers_url":"https://api.github.com/users/stan-dev/followers","following_url":"https://api.github.com/users/stan-dev/following{/other_user}","gists_url":"https://api.github.com/users/stan-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/stan-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stan-dev/subscriptions","organizations_url":"https://api.github.com/users/stan-dev/orgs","repos_url":"https://api.github.com/users/stan-dev/repos","events_url":"https://api.github.com/users/stan-dev/events{/privacy}","received_events_url":"https://api.github.com/users/stan-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stan-dev/math","description":"Stan Math Library","fork":false,"url":"https://api.github.com/repos/stan-dev/math","forks_url":"https://api.github.com/repos/stan-dev/math/forks","keys_url":"https://api.github.com/repos/stan-dev/math/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stan-dev/math/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stan-dev/math/teams","hooks_url":"https://api.github.com/repos/stan-dev/math/hooks","issue_events_url":"https://api.github.com/repos/stan-dev/math/issues/events{/number}","events_url":"https://api.github.com/repos/stan-dev/math/events","assignees_url":"https://api.github.com/repos/stan-dev/math/assignees{/user}","branches_url":"https://api.github.com/repos/stan-dev/math/branches{/branch}","tags_url":"https://api.github.com/repos/stan-dev/math/tags","blobs_url":"https://api.github.com/repos/stan-dev/math/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stan-dev/math/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stan-dev/math/git/refs{/sha}","trees_url":"https://api.github.com/repos/stan-dev/math/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stan-dev/math/statuses/{sha}","languages_url":"https://api.github.com/repos/stan-dev/math/languages","stargazers_url":"https://api.github.com/repos/stan-dev/math/stargazers","contributors_url":"https://api.github.com/repos/stan-dev/math/contributors","subscribers_url":"https://api.github.com/repos/stan-dev/math/subscribers","subscription_url":"https://api.github.com/repos/stan-dev/math/subscription","commits_url":"https://api.github.com/repos/stan-dev/math/commits{/sha}","git_commits_url":"https://api.github.com/repos/stan-dev/math/git/commits{/sha}","comments_url":"https://api.github.com/repos/stan-dev/math/comments{/number}","issue_comment_url":"https://api.github.com/repos/stan-dev/math/issues/comments{/number}","contents_url":"https://api.github.com/repos/stan-dev/math/contents/{+path}","compare_url":"https://api.github.com/repos/stan-dev/math/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stan-dev/math/merges","archive_url":"https://api.github.com/repos/stan-dev/math/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stan-dev/math/downloads","issues_url":"https://api.github.com/repos/stan-dev/math/issues{/number}","pulls_url":"https://api.github.com/repos/stan-dev/math/pulls{/number}","milestones_url":"https://api.github.com/repos/stan-dev/math/milestones{/number}","notifications_url":"https://api.github.com/repos/stan-dev/math/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stan-dev/math/labels{/name}","releases_url":"https://api.github.com/repos/stan-dev/math/releases{/id}","deployments_url":"https://api.github.com/repos/stan-dev/math/deployments","created_at":"2015-07-01T18:40:54Z","updated_at":"2016-03-28T05:13:51Z","pushed_at":"2016-04-28T14:01:30Z","git_url":"git://github.com/stan-dev/math.git","ssh_url":"git@github.com:stan-dev/math.git","clone_url":"https://github.com/stan-dev/math.git","svn_url":"https://github.com/stan-dev/math","homepage":null,"size":216269,"stargazers_count":50,"watchers_count":50,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":106,"forks":12,"open_issues":106,"watchers":50,"default_branch":"develop"}},"base":{"label":"stan-dev:develop","ref":"develop","sha":"369e62d6e806877a40d7a5a7a925e22ac4e39938","user":{"login":"stan-dev","id":3374820,"avatar_url":"https://avatars.githubusercontent.com/u/3374820?v=3","gravatar_id":"","url":"https://api.github.com/users/stan-dev","html_url":"https://github.com/stan-dev","followers_url":"https://api.github.com/users/stan-dev/followers","following_url":"https://api.github.com/users/stan-dev/following{/other_user}","gists_url":"https://api.github.com/users/stan-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/stan-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stan-dev/subscriptions","organizations_url":"https://api.github.com/users/stan-dev/orgs","repos_url":"https://api.github.com/users/stan-dev/repos","events_url":"https://api.github.com/users/stan-dev/events{/privacy}","received_events_url":"https://api.github.com/users/stan-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":38388440,"name":"math","full_name":"stan-dev/math","owner":{"login":"stan-dev","id":3374820,"avatar_url":"https://avatars.githubusercontent.com/u/3374820?v=3","gravatar_id":"","url":"https://api.github.com/users/stan-dev","html_url":"https://github.com/stan-dev","followers_url":"https://api.github.com/users/stan-dev/followers","following_url":"https://api.github.com/users/stan-dev/following{/other_user}","gists_url":"https://api.github.com/users/stan-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/stan-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stan-dev/subscriptions","organizations_url":"https://api.github.com/users/stan-dev/orgs","repos_url":"https://api.github.com/users/stan-dev/repos","events_url":"https://api.github.com/users/stan-dev/events{/privacy}","received_events_url":"https://api.github.com/users/stan-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stan-dev/math","description":"Stan Math Library","fork":false,"url":"https://api.github.com/repos/stan-dev/math","forks_url":"https://api.github.com/repos/stan-dev/math/forks","keys_url":"https://api.github.com/repos/stan-dev/math/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stan-dev/math/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stan-dev/math/teams","hooks_url":"https://api.github.com/repos/stan-dev/math/hooks","issue_events_url":"https://api.github.com/repos/stan-dev/math/issues/events{/number}","events_url":"https://api.github.com/repos/stan-dev/math/events","assignees_url":"https://api.github.com/repos/stan-dev/math/assignees{/user}","branches_url":"https://api.github.com/repos/stan-dev/math/branches{/branch}","tags_url":"https://api.github.com/repos/stan-dev/math/tags","blobs_url":"https://api.github.com/repos/stan-dev/math/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stan-dev/math/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stan-dev/math/git/refs{/sha}","trees_url":"https://api.github.com/repos/stan-dev/math/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stan-dev/math/statuses/{sha}","languages_url":"https://api.github.com/repos/stan-dev/math/languages","stargazers_url":"https://api.github.com/repos/stan-dev/math/stargazers","contributors_url":"https://api.github.com/repos/stan-dev/math/contributors","subscribers_url":"https://api.github.com/repos/stan-dev/math/subscribers","subscription_url":"https://api.github.com/repos/stan-dev/math/subscription","commits_url":"https://api.github.com/repos/stan-dev/math/commits{/sha}","git_commits_url":"https://api.github.com/repos/stan-dev/math/git/commits{/sha}","comments_url":"https://api.github.com/repos/stan-dev/math/comments{/number}","issue_comment_url":"https://api.github.com/repos/stan-dev/math/issues/comments{/number}","contents_url":"https://api.github.com/repos/stan-dev/math/contents/{+path}","compare_url":"https://api.github.com/repos/stan-dev/math/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stan-dev/math/merges","archive_url":"https://api.github.com/repos/stan-dev/math/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stan-dev/math/downloads","issues_url":"https://api.github.com/repos/stan-dev/math/issues{/number}","pulls_url":"https://api.github.com/repos/stan-dev/math/pulls{/number}","milestones_url":"https://api.github.com/repos/stan-dev/math/milestones{/number}","notifications_url":"https://api.github.com/repos/stan-dev/math/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stan-dev/math/labels{/name}","releases_url":"https://api.github.com/repos/stan-dev/math/releases{/id}","deployments_url":"https://api.github.com/repos/stan-dev/math/deployments","created_at":"2015-07-01T18:40:54Z","updated_at":"2016-03-28T05:13:51Z","pushed_at":"2016-04-28T14:01:30Z","git_url":"git://github.com/stan-dev/math.git","ssh_url":"git@github.com:stan-dev/math.git","clone_url":"https://github.com/stan-dev/math.git","svn_url":"https://github.com/stan-dev/math","homepage":null,"size":216269,"stargazers_count":50,"watchers_count":50,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":106,"forks":12,"open_issues":106,"watchers":50,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/stan-dev/math/pulls/276"},"html":{"href":"https://github.com/stan-dev/math/pull/276"},"issue":{"href":"https://api.github.com/repos/stan-dev/math/issues/276"},"comments":{"href":"https://api.github.com/repos/stan-dev/math/issues/276/comments"},"review_comments":{"href":"https://api.github.com/repos/stan-dev/math/pulls/276/comments"},"review_comment":{"href":"https://api.github.com/repos/stan-dev/math/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stan-dev/math/pulls/276/commits"},"statuses":{"href":"https://api.github.com/repos/stan-dev/math/statuses/0f1241c1ae53d24f815a298819702c87b958ca77"}}}}