{"action":"created","issue":{"url":"https://api.github.com/repos/ChandraCXC/iris/issues/310","repository_url":"https://api.github.com/repos/ChandraCXC/iris","labels_url":"https://api.github.com/repos/ChandraCXC/iris/issues/310/labels{/name}","comments_url":"https://api.github.com/repos/ChandraCXC/iris/issues/310/comments","events_url":"https://api.github.com/repos/ChandraCXC/iris/issues/310/events","html_url":"https://github.com/ChandraCXC/iris/pull/310","id":166163699,"number":310,"title":"Fix fitting tool bugs","user":{"login":"olaurino","id":5692321,"avatar_url":"https://avatars.githubusercontent.com/u/5692321?v=3","gravatar_id":"","url":"https://api.github.com/users/olaurino","html_url":"https://github.com/olaurino","followers_url":"https://api.github.com/users/olaurino/followers","following_url":"https://api.github.com/users/olaurino/following{/other_user}","gists_url":"https://api.github.com/users/olaurino/gists{/gist_id}","starred_url":"https://api.github.com/users/olaurino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olaurino/subscriptions","organizations_url":"https://api.github.com/users/olaurino/orgs","repos_url":"https://api.github.com/users/olaurino/repos","events_url":"https://api.github.com/users/olaurino/events{/privacy}","received_events_url":"https://api.github.com/users/olaurino/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ChandraCXC/iris/labels/2%20-%20Working","name":"2 - Working","color":"CCCCCC"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-07-18T18:43:44Z","updated_at":"2016-07-22T16:05:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ChandraCXC/iris/pulls/310","html_url":"https://github.com/ChandraCXC/iris/pull/310","diff_url":"https://github.com/ChandraCXC/iris/pull/310.diff","patch_url":"https://github.com/ChandraCXC/iris/pull/310.patch"},"body":"This PR fixes three issues with the fitting tool:\r\n\r\n * chandracxc/iris-dev#91 - the sigma label now updates when the confidence is calculated. A potential issue here is that the confidence calculation must be performed and succeed for sherpa-samp to return the percentage value corresponding to the user's input. An improvement would be to perform the calculation in java on the fly.\r\n\r\n * chandracxc/iris-dev#99 - confidence now seems to properly work. Results are consistent with the ones in Iris 2.1. The problem in the previous code was that the SAMP configuration was not properly built, and unfortunately sherpa-samp does not much in terms of error handlind.\r\n\r\n * chandracxc/iris-dev#92 - introduced gridbag layout in GUI to try and fix some OSX issues. Not all issues are resolved, but this is an improvement.\r\n\r\n * chandracxc/iris-dev#90 - the fit and confidence calculations are now performed asynchronously (not in the EDT)."},"comment":{"url":"https://api.github.com/repos/ChandraCXC/iris/issues/comments/234585237","html_url":"https://github.com/ChandraCXC/iris/pull/310#issuecomment-234585237","issue_url":"https://api.github.com/repos/ChandraCXC/iris/issues/310","id":234585237,"user":{"login":"olaurino","id":5692321,"avatar_url":"https://avatars.githubusercontent.com/u/5692321?v=3","gravatar_id":"","url":"https://api.github.com/users/olaurino","html_url":"https://github.com/olaurino","followers_url":"https://api.github.com/users/olaurino/followers","following_url":"https://api.github.com/users/olaurino/following{/other_user}","gists_url":"https://api.github.com/users/olaurino/gists{/gist_id}","starred_url":"https://api.github.com/users/olaurino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olaurino/subscriptions","organizations_url":"https://api.github.com/users/olaurino/orgs","repos_url":"https://api.github.com/users/olaurino/repos","events_url":"https://api.github.com/users/olaurino/events{/privacy}","received_events_url":"https://api.github.com/users/olaurino/received_events","type":"User","site_admin":false},"created_at":"2016-07-22T16:05:45Z","updated_at":"2016-07-22T16:05:45Z","body":"Rebasing, original tip was at cb89af9."}}
{"actor":{"display_login":"olaurino"}}