{"action":"created","issue":{"url":"https://api.github.com/repos/FEMR/femr/issues/546","repository_url":"https://api.github.com/repos/FEMR/femr","labels_url":"https://api.github.com/repos/FEMR/femr/issues/546/labels{/name}","comments_url":"https://api.github.com/repos/FEMR/femr/issues/546/comments","events_url":"https://api.github.com/repos/FEMR/femr/issues/546/events","html_url":"https://github.com/FEMR/femr/pull/546","id":183303750,"number":546,"title":"Changes made to address FEMR-157 - Optional Phone Number Record","user":{"login":"Thraxus","id":8251163,"avatar_url":"https://avatars.githubusercontent.com/u/8251163?v=3","gravatar_id":"","url":"https://api.github.com/users/Thraxus","html_url":"https://github.com/Thraxus","followers_url":"https://api.github.com/users/Thraxus/followers","following_url":"https://api.github.com/users/Thraxus/following{/other_user}","gists_url":"https://api.github.com/users/Thraxus/gists{/gist_id}","starred_url":"https://api.github.com/users/Thraxus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thraxus/subscriptions","organizations_url":"https://api.github.com/users/Thraxus/orgs","repos_url":"https://api.github.com/users/Thraxus/repos","events_url":"https://api.github.com/users/Thraxus/events{/privacy}","received_events_url":"https://api.github.com/users/Thraxus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-10-17T00:34:45Z","updated_at":"2016-10-27T11:19:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/FEMR/femr/pulls/546","html_url":"https://github.com/FEMR/femr/pull/546","diff_url":"https://github.com/FEMR/femr/pull/546.diff","patch_url":"https://github.com/FEMR/femr/pull/546.patch"},"body":"Full change log available upon request (below is pretty telling though!)."},"comment":{"url":"https://api.github.com/repos/FEMR/femr/issues/comments/256614526","html_url":"https://github.com/FEMR/femr/pull/546#issuecomment-256614526","issue_url":"https://api.github.com/repos/FEMR/femr/issues/546","id":256614526,"user":{"login":"Thraxus","id":8251163,"avatar_url":"https://avatars.githubusercontent.com/u/8251163?v=3","gravatar_id":"","url":"https://api.github.com/users/Thraxus","html_url":"https://github.com/Thraxus","followers_url":"https://api.github.com/users/Thraxus/followers","following_url":"https://api.github.com/users/Thraxus/following{/other_user}","gists_url":"https://api.github.com/users/Thraxus/gists{/gist_id}","starred_url":"https://api.github.com/users/Thraxus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thraxus/subscriptions","organizations_url":"https://api.github.com/users/Thraxus/orgs","repos_url":"https://api.github.com/users/Thraxus/repos","events_url":"https://api.github.com/users/Thraxus/events{/privacy}","received_events_url":"https://api.github.com/users/Thraxus/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T11:19:51Z","updated_at":"2016-10-27T11:19:51Z","body":"The conversation we had with Kevin last week explicitly covered limiting what people can use the field for. \r\n\r\nLike I said way back in the beginning, I'm all for leaving it a text field - I don't believe saving one key press to swap to a tel field is/was that important. So if this change was just for that reason, I'd argue against the necessity of the required code changes given the new information. However, since the decision was also based on the field contents, the changes will need to be made. \r\n\r\nI have some ideas how to do it, and editing the js is one of them. The changes I will end up making all depend on how robust of a system to put in place. If I decide on just some regex validation, js will work fine. To upgrade the system as a whole and add missing functionality will do the system a greater service in the long run though. It's a decision that needs to be made with more information than I have available right now. I'll start looking into it tonight and let this thread know my thoughts before committing to anything. "}}
{"actor":{"display_login":"Thraxus"}}