{"action":"closed","number":11204,"pull_request":{"url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/11204","id":79464467,"html_url":"https://github.com/d3athrow/vgstation13/pull/11204","diff_url":"https://github.com/d3athrow/vgstation13/pull/11204.diff","patch_url":"https://github.com/d3athrow/vgstation13/pull/11204.patch","issue_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/11204","number":11204,"state":"closed","locked":false,"title":"Ports TG's instrument system and guitar","user":{"login":"JustSumBody","id":19365096,"avatar_url":"https://avatars.githubusercontent.com/u/19365096?v=3","gravatar_id":"","url":"https://api.github.com/users/JustSumBody","html_url":"https://github.com/JustSumBody","followers_url":"https://api.github.com/users/JustSumBody/followers","following_url":"https://api.github.com/users/JustSumBody/following{/other_user}","gists_url":"https://api.github.com/users/JustSumBody/gists{/gist_id}","starred_url":"https://api.github.com/users/JustSumBody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustSumBody/subscriptions","organizations_url":"https://api.github.com/users/JustSumBody/orgs","repos_url":"https://api.github.com/users/JustSumBody/repos","events_url":"https://api.github.com/users/JustSumBody/events{/privacy}","received_events_url":"https://api.github.com/users/JustSumBody/received_events","type":"User","site_admin":false},"body":"<!--\r\nPull requests must be atomic.  Change one set of related things at a time.  Bundling sucks for everyone.\r\nThis means, primarily, that you shouldn't fix bugs and add content in the same PR. When we mean 'bundling', we mean making one PR for multiple, unrelated changes.\r\n\r\nTest your changes.  PRs that do not compile will not be accepted.\r\nTesting your changes locally is incredibly important. If you break the serb we will be very upset with you.\r\n\r\nLarge changes require discussion.  If you're doing a large, game-changing modification, or a new layout for something, discussion with the community is required as of 26/6/2014.  Map and sprite changes require pictures of before and after.  MAINTAINERS ARE NOT IMMUNE TO THIS.  GET YOUR ASS IN IRC.\r\n\r\nMerging your own PRs is considered bad practice, as it generally means you bypass peer review, which is a core part of how we develop.\r\n\r\nIt is also suggested that you hop into irc.rizon.net #vgstation to discuss your changes, or if you need help.\r\n-->\r\nContinuing where Unid left off in #5442\r\nTo be honest he had most of the leg work done already, all that was really left was cleaning up the sound files and changing the violin/piano pathing in virtually every place it came up.\r\nSo we're moving to a new system that is flat based: rather than having duplicate sound files such as F#/Gb we just have the Gb file and the proc will send F# to Gb because music theory. It also eliminates reduntant files such as E# and directs them to Fn because why would you ever write an E# you animal.\r\n~~Couldn't find the inhand sprite for the guitar from his original PR though, searching for icons is hard. I'll look a bit harder/bug someone else to make one if I can't find it.~~\r\nAlso of note: The guitar is limited in range. While the other instruments have a full range spanning nine octaves, the guitar is limited from the 3rd octave to the 6th or something like that I'm not that good at music. If you try to play something too high or low it just doesn't play.\r\n\"Tested\" moderately\r\nSprite:\r\n![image](https://cloud.githubusercontent.com/assets/19365096/17276976/bca561b6-5705-11e6-8580-8a1245cfc0c3.png)\r\n\r\nFOUND THE IN HANDS:\r\n![image](https://cloud.githubusercontent.com/assets/19365096/17276970/931fa432-5705-11e6-91fc-5e6c0f3d2614.png)\r\n![image](https://cloud.githubusercontent.com/assets/19365096/17276973/a8bd2508-5705-11e6-904b-080134c15260.png)\r\nIt's hard to get good ingame screens of the different views because of that whole layering thing, but you should get the idea\r\nedit: Oh there it is, my /tg/ branch was outdated so I didn't see the guitar\r\nnow with video https://www.youtube.com/watch?v=HAWBF-G4CJM","created_at":"2016-07-30T18:31:46Z","updated_at":"2016-08-04T03:14:05Z","closed_at":"2016-08-04T03:14:04Z","merged_at":"2016-08-04T03:14:04Z","merge_commit_sha":"167acc3a960936ab657eeff79a1acedf9cda8755","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/11204/commits","review_comments_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/11204/comments","review_comment_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments{/number}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/11204/comments","statuses_url":"https://api.github.com/repos/d3athrow/vgstation13/statuses/d81f96be2d2f69e99a6fe83cd4534ca976f12311","head":{"label":"JustSumBody:InstrumentPort","ref":"InstrumentPort","sha":"d81f96be2d2f69e99a6fe83cd4534ca976f12311","user":{"login":"JustSumBody","id":19365096,"avatar_url":"https://avatars.githubusercontent.com/u/19365096?v=3","gravatar_id":"","url":"https://api.github.com/users/JustSumBody","html_url":"https://github.com/JustSumBody","followers_url":"https://api.github.com/users/JustSumBody/followers","following_url":"https://api.github.com/users/JustSumBody/following{/other_user}","gists_url":"https://api.github.com/users/JustSumBody/gists{/gist_id}","starred_url":"https://api.github.com/users/JustSumBody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustSumBody/subscriptions","organizations_url":"https://api.github.com/users/JustSumBody/orgs","repos_url":"https://api.github.com/users/JustSumBody/repos","events_url":"https://api.github.com/users/JustSumBody/events{/privacy}","received_events_url":"https://api.github.com/users/JustSumBody/received_events","type":"User","site_admin":false},"repo":{"id":61069490,"name":"vgstation13","full_name":"JustSumBody/vgstation13","owner":{"login":"JustSumBody","id":19365096,"avatar_url":"https://avatars.githubusercontent.com/u/19365096?v=3","gravatar_id":"","url":"https://api.github.com/users/JustSumBody","html_url":"https://github.com/JustSumBody","followers_url":"https://api.github.com/users/JustSumBody/followers","following_url":"https://api.github.com/users/JustSumBody/following{/other_user}","gists_url":"https://api.github.com/users/JustSumBody/gists{/gist_id}","starred_url":"https://api.github.com/users/JustSumBody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustSumBody/subscriptions","organizations_url":"https://api.github.com/users/JustSumBody/orgs","repos_url":"https://api.github.com/users/JustSumBody/repos","events_url":"https://api.github.com/users/JustSumBody/events{/privacy}","received_events_url":"https://api.github.com/users/JustSumBody/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JustSumBody/vgstation13","description":"Butts","fork":true,"url":"https://api.github.com/repos/JustSumBody/vgstation13","forks_url":"https://api.github.com/repos/JustSumBody/vgstation13/forks","keys_url":"https://api.github.com/repos/JustSumBody/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JustSumBody/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JustSumBody/vgstation13/teams","hooks_url":"https://api.github.com/repos/JustSumBody/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/JustSumBody/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/JustSumBody/vgstation13/events","assignees_url":"https://api.github.com/repos/JustSumBody/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/JustSumBody/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/JustSumBody/vgstation13/tags","blobs_url":"https://api.github.com/repos/JustSumBody/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JustSumBody/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JustSumBody/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/JustSumBody/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JustSumBody/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/JustSumBody/vgstation13/languages","stargazers_url":"https://api.github.com/repos/JustSumBody/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/JustSumBody/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/JustSumBody/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/JustSumBody/vgstation13/subscription","commits_url":"https://api.github.com/repos/JustSumBody/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/JustSumBody/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/JustSumBody/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/JustSumBody/vgstation13/issues/comments{/number}","contents_url":"https://api.github.com/repos/JustSumBody/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/JustSumBody/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JustSumBody/vgstation13/merges","archive_url":"https://api.github.com/repos/JustSumBody/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JustSumBody/vgstation13/downloads","issues_url":"https://api.github.com/repos/JustSumBody/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/JustSumBody/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/JustSumBody/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/JustSumBody/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JustSumBody/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/JustSumBody/vgstation13/releases{/id}","deployments_url":"https://api.github.com/repos/JustSumBody/vgstation13/deployments","created_at":"2016-06-13T21:03:15Z","updated_at":"2016-07-07T15:47:34Z","pushed_at":"2016-08-03T01:43:34Z","git_url":"git://github.com/JustSumBody/vgstation13.git","ssh_url":"git@github.com:JustSumBody/vgstation13.git","clone_url":"https://github.com/JustSumBody/vgstation13.git","svn_url":"https://github.com/JustSumBody/vgstation13","homepage":"","size":896770,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"Bleeding-Edge"}},"base":{"label":"d3athrow:Bleeding-Edge","ref":"Bleeding-Edge","sha":"401e613f021b88f60203af30195cd7ca139c8fe1","user":{"login":"d3athrow","id":706947,"avatar_url":"https://avatars.githubusercontent.com/u/706947?v=3","gravatar_id":"","url":"https://api.github.com/users/d3athrow","html_url":"https://github.com/d3athrow","followers_url":"https://api.github.com/users/d3athrow/followers","following_url":"https://api.github.com/users/d3athrow/following{/other_user}","gists_url":"https://api.github.com/users/d3athrow/gists{/gist_id}","starred_url":"https://api.github.com/users/d3athrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3athrow/subscriptions","organizations_url":"https://api.github.com/users/d3athrow/orgs","repos_url":"https://api.github.com/users/d3athrow/repos","events_url":"https://api.github.com/users/d3athrow/events{/privacy}","received_events_url":"https://api.github.com/users/d3athrow/received_events","type":"User","site_admin":false},"repo":{"id":10441188,"name":"vgstation13","full_name":"d3athrow/vgstation13","owner":{"login":"d3athrow","id":706947,"avatar_url":"https://avatars.githubusercontent.com/u/706947?v=3","gravatar_id":"","url":"https://api.github.com/users/d3athrow","html_url":"https://github.com/d3athrow","followers_url":"https://api.github.com/users/d3athrow/followers","following_url":"https://api.github.com/users/d3athrow/following{/other_user}","gists_url":"https://api.github.com/users/d3athrow/gists{/gist_id}","starred_url":"https://api.github.com/users/d3athrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3athrow/subscriptions","organizations_url":"https://api.github.com/users/d3athrow/orgs","repos_url":"https://api.github.com/users/d3athrow/repos","events_url":"https://api.github.com/users/d3athrow/events{/privacy}","received_events_url":"https://api.github.com/users/d3athrow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d3athrow/vgstation13","description":"Butts","fork":false,"url":"https://api.github.com/repos/d3athrow/vgstation13","forks_url":"https://api.github.com/repos/d3athrow/vgstation13/forks","keys_url":"https://api.github.com/repos/d3athrow/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3athrow/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3athrow/vgstation13/teams","hooks_url":"https://api.github.com/repos/d3athrow/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/d3athrow/vgstation13/events","assignees_url":"https://api.github.com/repos/d3athrow/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/d3athrow/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/d3athrow/vgstation13/tags","blobs_url":"https://api.github.com/repos/d3athrow/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3athrow/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3athrow/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3athrow/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3athrow/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/d3athrow/vgstation13/languages","stargazers_url":"https://api.github.com/repos/d3athrow/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/d3athrow/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/d3athrow/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/d3athrow/vgstation13/subscription","commits_url":"https://api.github.com/repos/d3athrow/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3athrow/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/comments{/number}","contents_url":"https://api.github.com/repos/d3athrow/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/d3athrow/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3athrow/vgstation13/merges","archive_url":"https://api.github.com/repos/d3athrow/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3athrow/vgstation13/downloads","issues_url":"https://api.github.com/repos/d3athrow/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/d3athrow/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/d3athrow/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3athrow/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/d3athrow/vgstation13/releases{/id}","deployments_url":"https://api.github.com/repos/d3athrow/vgstation13/deployments","created_at":"2013-06-02T19:39:54Z","updated_at":"2016-07-29T17:17:12Z","pushed_at":"2016-08-04T03:14:04Z","git_url":"git://github.com/d3athrow/vgstation13.git","ssh_url":"git@github.com:d3athrow/vgstation13.git","clone_url":"https://github.com/d3athrow/vgstation13.git","svn_url":"https://github.com/d3athrow/vgstation13","homepage":"","size":1200607,"stargazers_count":86,"watchers_count":86,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":277,"mirror_url":null,"open_issues_count":1815,"forks":277,"open_issues":1815,"watchers":86,"default_branch":"Bleeding-Edge"}},"_links":{"self":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/11204"},"html":{"href":"https://github.com/d3athrow/vgstation13/pull/11204"},"issue":{"href":"https://api.github.com/repos/d3athrow/vgstation13/issues/11204"},"comments":{"href":"https://api.github.com/repos/d3athrow/vgstation13/issues/11204/comments"},"review_comments":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/11204/comments"},"review_comment":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/11204/commits"},"statuses":{"href":"https://api.github.com/repos/d3athrow/vgstation13/statuses/d81f96be2d2f69e99a6fe83cd4534ca976f12311"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"clusterfack","id":8516830,"avatar_url":"https://avatars.githubusercontent.com/u/8516830?v=3","gravatar_id":"","url":"https://api.github.com/users/clusterfack","html_url":"https://github.com/clusterfack","followers_url":"https://api.github.com/users/clusterfack/followers","following_url":"https://api.github.com/users/clusterfack/following{/other_user}","gists_url":"https://api.github.com/users/clusterfack/gists{/gist_id}","starred_url":"https://api.github.com/users/clusterfack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clusterfack/subscriptions","organizations_url":"https://api.github.com/users/clusterfack/orgs","repos_url":"https://api.github.com/users/clusterfack/repos","events_url":"https://api.github.com/users/clusterfack/events{/privacy}","received_events_url":"https://api.github.com/users/clusterfack/received_events","type":"User","site_admin":false},"comments":4,"review_comments":6,"commits":13,"additions":408,"deletions":817,"changed_files":215}}
{"actor":{"display_login":"clusterfack"}}