{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astropy/pulls/comments/72817582","id":72817582,"diff_hunk":"@@ -223,6 +223,24 @@ def _unitstr(self):\n                            for component in self.components]))\n         return unitstr\n \n+    def __eq__(self, other):","path":"astropy/coordinates/representation.py","position":4,"original_position":4,"commit_id":"92f42af1864227c122b61286585e5ffcedfb36f1","original_commit_id":"92f42af1864227c122b61286585e5ffcedfb36f1","user":{"login":"mhvk","id":2789820,"avatar_url":"https://avatars.githubusercontent.com/u/2789820?v=3","gravatar_id":"","url":"https://api.github.com/users/mhvk","html_url":"https://github.com/mhvk","followers_url":"https://api.github.com/users/mhvk/followers","following_url":"https://api.github.com/users/mhvk/following{/other_user}","gists_url":"https://api.github.com/users/mhvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mhvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhvk/subscriptions","organizations_url":"https://api.github.com/users/mhvk/orgs","repos_url":"https://api.github.com/users/mhvk/repos","events_url":"https://api.github.com/users/mhvk/events{/privacy}","received_events_url":"https://api.github.com/users/mhvk/received_events","type":"User","site_admin":false},"body":"Just to be sure: do we really need this? I ask in part because I think a representation is more like an array, and if I compared two instances, I would thus expect to get an array of bool back.","created_at":"2016-07-29T16:07:06Z","updated_at":"2016-07-29T16:07:06Z","html_url":"https://github.com/astropy/astropy/pull/5207#discussion_r72817582","pull_request_url":"https://api.github.com/repos/astropy/astropy/pulls/5207","_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments/72817582"},"html":{"href":"https://github.com/astropy/astropy/pull/5207#discussion_r72817582"},"pull_request":{"href":"https://api.github.com/repos/astropy/astropy/pulls/5207"}}},"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/5207","id":79225115,"html_url":"https://github.com/astropy/astropy/pull/5207","diff_url":"https://github.com/astropy/astropy/pull/5207.diff","patch_url":"https://github.com/astropy/astropy/pull/5207.patch","issue_url":"https://api.github.com/repos/astropy/astropy/issues/5207","number":5207,"state":"open","locked":false,"title":"Add CartesianRepresentationFrameAttribute to GCRS and PrecessedGeocentric frames","user":{"login":"StuartLittlefair","id":4570807,"avatar_url":"https://avatars.githubusercontent.com/u/4570807?v=3","gravatar_id":"","url":"https://api.github.com/users/StuartLittlefair","html_url":"https://github.com/StuartLittlefair","followers_url":"https://api.github.com/users/StuartLittlefair/followers","following_url":"https://api.github.com/users/StuartLittlefair/following{/other_user}","gists_url":"https://api.github.com/users/StuartLittlefair/gists{/gist_id}","starred_url":"https://api.github.com/users/StuartLittlefair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StuartLittlefair/subscriptions","organizations_url":"https://api.github.com/users/StuartLittlefair/orgs","repos_url":"https://api.github.com/users/StuartLittlefair/repos","events_url":"https://api.github.com/users/StuartLittlefair/events{/privacy}","received_events_url":"https://api.github.com/users/StuartLittlefair/received_events","type":"User","site_admin":false},"body":"This PR fixes #4926, and is a replacement for #5196.\r\n\r\nAs @mhvk mentioned on the latter PR, it would be much more logical for the ```obsgeoloc``` and ```obsgeovel``` attributes to be ```CartesianRepresentations```. \r\n\r\nI was initially reluctant, but I realised that you can be flexible about what types of values initialise these attributes so that (3, ...) or (..., 3) shaped ```Quantities``` are allowed, as well as ```CartesianRepresentations``` themselves. This means the code changes are minimal, and anyone who sets these attributes in their code will find their code still works. \r\n\r\n","created_at":"2016-07-28T16:15:46Z","updated_at":"2016-07-29T16:07:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a07dc6581b703179f67f5a9d0ee19ec69a87ff2","assignee":{"login":"mhvk","id":2789820,"avatar_url":"https://avatars.githubusercontent.com/u/2789820?v=3","gravatar_id":"","url":"https://api.github.com/users/mhvk","html_url":"https://github.com/mhvk","followers_url":"https://api.github.com/users/mhvk/followers","following_url":"https://api.github.com/users/mhvk/following{/other_user}","gists_url":"https://api.github.com/users/mhvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mhvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhvk/subscriptions","organizations_url":"https://api.github.com/users/mhvk/orgs","repos_url":"https://api.github.com/users/mhvk/repos","events_url":"https://api.github.com/users/mhvk/events{/privacy}","received_events_url":"https://api.github.com/users/mhvk/received_events","type":"User","site_admin":false},"assignees":[{"login":"mhvk","id":2789820,"avatar_url":"https://avatars.githubusercontent.com/u/2789820?v=3","gravatar_id":"","url":"https://api.github.com/users/mhvk","html_url":"https://github.com/mhvk","followers_url":"https://api.github.com/users/mhvk/followers","following_url":"https://api.github.com/users/mhvk/following{/other_user}","gists_url":"https://api.github.com/users/mhvk/gists{/gist_id}","starred_url":"https://api.github.com/users/mhvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhvk/subscriptions","organizations_url":"https://api.github.com/users/mhvk/orgs","repos_url":"https://api.github.com/users/mhvk/repos","events_url":"https://api.github.com/users/mhvk/events{/privacy}","received_events_url":"https://api.github.com/users/mhvk/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/astropy/astropy/milestones/41","html_url":"https://github.com/astropy/astropy/milestones/v1.2.2","labels_url":"https://api.github.com/repos/astropy/astropy/milestones/41/labels","id":1847447,"number":41,"title":"v1.2.2","description":"","creator":{"login":"astrofrog","id":314716,"avatar_url":"https://avatars.githubusercontent.com/u/314716?v=3","gravatar_id":"","url":"https://api.github.com/users/astrofrog","html_url":"https://github.com/astrofrog","followers_url":"https://api.github.com/users/astrofrog/followers","following_url":"https://api.github.com/users/astrofrog/following{/other_user}","gists_url":"https://api.github.com/users/astrofrog/gists{/gist_id}","starred_url":"https://api.github.com/users/astrofrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astrofrog/subscriptions","organizations_url":"https://api.github.com/users/astrofrog/orgs","repos_url":"https://api.github.com/users/astrofrog/repos","events_url":"https://api.github.com/users/astrofrog/events{/privacy}","received_events_url":"https://api.github.com/users/astrofrog/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":11,"state":"open","created_at":"2016-06-24T16:24:28Z","updated_at":"2016-07-28T16:54:44Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/astropy/astropy/pulls/5207/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy/pulls/5207/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/5207/comments","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/92f42af1864227c122b61286585e5ffcedfb36f1","head":{"label":"StuartLittlefair:gcrs_ndims2","ref":"gcrs_ndims2","sha":"92f42af1864227c122b61286585e5ffcedfb36f1","user":{"login":"StuartLittlefair","id":4570807,"avatar_url":"https://avatars.githubusercontent.com/u/4570807?v=3","gravatar_id":"","url":"https://api.github.com/users/StuartLittlefair","html_url":"https://github.com/StuartLittlefair","followers_url":"https://api.github.com/users/StuartLittlefair/followers","following_url":"https://api.github.com/users/StuartLittlefair/following{/other_user}","gists_url":"https://api.github.com/users/StuartLittlefair/gists{/gist_id}","starred_url":"https://api.github.com/users/StuartLittlefair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StuartLittlefair/subscriptions","organizations_url":"https://api.github.com/users/StuartLittlefair/orgs","repos_url":"https://api.github.com/users/StuartLittlefair/repos","events_url":"https://api.github.com/users/StuartLittlefair/events{/privacy}","received_events_url":"https://api.github.com/users/StuartLittlefair/received_events","type":"User","site_admin":false},"repo":{"id":34852236,"name":"astropy","full_name":"StuartLittlefair/astropy","owner":{"login":"StuartLittlefair","id":4570807,"avatar_url":"https://avatars.githubusercontent.com/u/4570807?v=3","gravatar_id":"","url":"https://api.github.com/users/StuartLittlefair","html_url":"https://github.com/StuartLittlefair","followers_url":"https://api.github.com/users/StuartLittlefair/followers","following_url":"https://api.github.com/users/StuartLittlefair/following{/other_user}","gists_url":"https://api.github.com/users/StuartLittlefair/gists{/gist_id}","starred_url":"https://api.github.com/users/StuartLittlefair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StuartLittlefair/subscriptions","organizations_url":"https://api.github.com/users/StuartLittlefair/orgs","repos_url":"https://api.github.com/users/StuartLittlefair/repos","events_url":"https://api.github.com/users/StuartLittlefair/events{/privacy}","received_events_url":"https://api.github.com/users/StuartLittlefair/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/StuartLittlefair/astropy","description":"Repository for the Astropy core package","fork":true,"url":"https://api.github.com/repos/StuartLittlefair/astropy","forks_url":"https://api.github.com/repos/StuartLittlefair/astropy/forks","keys_url":"https://api.github.com/repos/StuartLittlefair/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StuartLittlefair/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StuartLittlefair/astropy/teams","hooks_url":"https://api.github.com/repos/StuartLittlefair/astropy/hooks","issue_events_url":"https://api.github.com/repos/StuartLittlefair/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/StuartLittlefair/astropy/events","assignees_url":"https://api.github.com/repos/StuartLittlefair/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/StuartLittlefair/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/StuartLittlefair/astropy/tags","blobs_url":"https://api.github.com/repos/StuartLittlefair/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StuartLittlefair/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StuartLittlefair/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/StuartLittlefair/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StuartLittlefair/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/StuartLittlefair/astropy/languages","stargazers_url":"https://api.github.com/repos/StuartLittlefair/astropy/stargazers","contributors_url":"https://api.github.com/repos/StuartLittlefair/astropy/contributors","subscribers_url":"https://api.github.com/repos/StuartLittlefair/astropy/subscribers","subscription_url":"https://api.github.com/repos/StuartLittlefair/astropy/subscription","commits_url":"https://api.github.com/repos/StuartLittlefair/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/StuartLittlefair/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/StuartLittlefair/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/StuartLittlefair/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/StuartLittlefair/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/StuartLittlefair/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StuartLittlefair/astropy/merges","archive_url":"https://api.github.com/repos/StuartLittlefair/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StuartLittlefair/astropy/downloads","issues_url":"https://api.github.com/repos/StuartLittlefair/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/StuartLittlefair/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/StuartLittlefair/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/StuartLittlefair/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StuartLittlefair/astropy/labels{/name}","releases_url":"https://api.github.com/repos/StuartLittlefair/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/StuartLittlefair/astropy/deployments","created_at":"2015-04-30T12:02:25Z","updated_at":"2016-04-25T08:51:05Z","pushed_at":"2016-07-29T14:57:29Z","git_url":"git://github.com/StuartLittlefair/astropy.git","ssh_url":"git@github.com:StuartLittlefair/astropy.git","clone_url":"https://github.com/StuartLittlefair/astropy.git","svn_url":"https://github.com/StuartLittlefair/astropy","homepage":"www.astropy.org","size":45900,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"e8f6c7d2787577c8b01e4fbf765c7600701044ea","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":2081289,"name":"astropy","full_name":"astropy/astropy","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astropy","description":"Repository for the Astropy core package","fork":false,"url":"https://api.github.com/repos/astropy/astropy","forks_url":"https://api.github.com/repos/astropy/astropy/forks","keys_url":"https://api.github.com/repos/astropy/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy/teams","hooks_url":"https://api.github.com/repos/astropy/astropy/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy/events","assignees_url":"https://api.github.com/repos/astropy/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy/tags","blobs_url":"https://api.github.com/repos/astropy/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy/subscription","commits_url":"https://api.github.com/repos/astropy/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy/merges","archive_url":"https://api.github.com/repos/astropy/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy/downloads","issues_url":"https://api.github.com/repos/astropy/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/astropy/deployments","created_at":"2011-07-21T01:33:49Z","updated_at":"2016-07-27T19:52:26Z","pushed_at":"2016-07-29T12:55:40Z","git_url":"git://github.com/astropy/astropy.git","ssh_url":"git@github.com:astropy/astropy.git","clone_url":"https://github.com/astropy/astropy.git","svn_url":"https://github.com/astropy/astropy","homepage":"www.astropy.org","size":68187,"stargazers_count":907,"watchers_count":907,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":576,"mirror_url":null,"open_issues_count":758,"forks":576,"open_issues":758,"watchers":907,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/5207"},"html":{"href":"https://github.com/astropy/astropy/pull/5207"},"issue":{"href":"https://api.github.com/repos/astropy/astropy/issues/5207"},"comments":{"href":"https://api.github.com/repos/astropy/astropy/issues/5207/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy/pulls/5207/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy/pulls/5207/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy/statuses/92f42af1864227c122b61286585e5ffcedfb36f1"}}}}
{"actor":{"display_login":"mhvk"}}