{"action":"closed","number":223,"pull_request":{"url":"https://api.github.com/repos/sfbrigade/brigadehub/pulls/223","id":67123166,"html_url":"https://github.com/sfbrigade/brigadehub/pull/223","diff_url":"https://github.com/sfbrigade/brigadehub/pull/223.diff","patch_url":"https://github.com/sfbrigade/brigadehub/pull/223.patch","issue_url":"https://api.github.com/repos/sfbrigade/brigadehub/issues/223","number":223,"state":"closed","locked":false,"title":"Custom nav links, elevating github auths","user":{"login":"therebelrobot","id":679178,"avatar_url":"https://avatars.githubusercontent.com/u/679178?v=3","gravatar_id":"","url":"https://api.github.com/users/therebelrobot","html_url":"https://github.com/therebelrobot","followers_url":"https://api.github.com/users/therebelrobot/followers","following_url":"https://api.github.com/users/therebelrobot/following{/other_user}","gists_url":"https://api.github.com/users/therebelrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/therebelrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therebelrobot/subscriptions","organizations_url":"https://api.github.com/users/therebelrobot/orgs","repos_url":"https://api.github.com/users/therebelrobot/repos","events_url":"https://api.github.com/users/therebelrobot/events{/privacy}","received_events_url":"https://api.github.com/users/therebelrobot/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nAdds the ability to add custom navigation links. Also adds elevating github auths.\r\n\r\n#### Added\r\n\r\n- Custom external navigation links\r\n- form in manage brigade to add new link (still not entirely functioning, will take another look tomorrow)\r\n- middleware for authentication, checking user roles and checking github scopes available\r\n- controller to elevate github scopes if needed\r\n\r\n#### Changed\r\n\r\n- Routes: now are specifying allowed roles and needed github scopes\r\n- Header: styling and format changes to account dropdown:\r\n  - ![](https://i.imgur.com/wllAbgf.png)\r\n\r\n### Relevant Open Issues\r\n\r\n- #221 \r\n\r\n### Existing PRs with overlapping scope\r\n\r\n- #209\r\n\r\n### Checklist\r\n\r\n- [x] This Pull Request template has actually been modified with relevant data ;)\r\n- [x] This PR passes Linting tests (see below)\r\n- [ ] This PR does not contain merge conflicts with `edge` (see below)\r\n- [x] This PR does not contain:\r\n  - Additional Dependencies in `package.json` that are not used\r\n  - Frontend JS in Jade templates (unless absolutely necessary)\r\n  - Any functionality which depends on frontend JS being enabled (unless already discussed as a team)\r\n- [x] This PR, if overlapping with another open PR in scope, has been tested with those code changes and verified to play nice with it\r\n","created_at":"2016-04-20T03:26:09Z","updated_at":"2016-04-21T15:46:31Z","closed_at":"2016-04-21T15:46:31Z","merged_at":"2016-04-21T15:46:31Z","merge_commit_sha":"818ecc15a9a22a1febd6c756143e7bf060f8b9a3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sfbrigade/brigadehub/pulls/223/commits","review_comments_url":"https://api.github.com/repos/sfbrigade/brigadehub/pulls/223/comments","review_comment_url":"https://api.github.com/repos/sfbrigade/brigadehub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sfbrigade/brigadehub/issues/223/comments","statuses_url":"https://api.github.com/repos/sfbrigade/brigadehub/statuses/b8fcd605c46179d773b51c5625a48c7471dee446","head":{"label":"sfbrigade:feature/custom-nav","ref":"feature/custom-nav","sha":"b8fcd605c46179d773b51c5625a48c7471dee446","user":{"login":"sfbrigade","id":3926630,"avatar_url":"https://avatars.githubusercontent.com/u/3926630?v=3","gravatar_id":"","url":"https://api.github.com/users/sfbrigade","html_url":"https://github.com/sfbrigade","followers_url":"https://api.github.com/users/sfbrigade/followers","following_url":"https://api.github.com/users/sfbrigade/following{/other_user}","gists_url":"https://api.github.com/users/sfbrigade/gists{/gist_id}","starred_url":"https://api.github.com/users/sfbrigade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfbrigade/subscriptions","organizations_url":"https://api.github.com/users/sfbrigade/orgs","repos_url":"https://api.github.com/users/sfbrigade/repos","events_url":"https://api.github.com/users/sfbrigade/events{/privacy}","received_events_url":"https://api.github.com/users/sfbrigade/received_events","type":"Organization","site_admin":false},"repo":{"id":50059179,"name":"brigadehub","full_name":"sfbrigade/brigadehub","owner":{"login":"sfbrigade","id":3926630,"avatar_url":"https://avatars.githubusercontent.com/u/3926630?v=3","gravatar_id":"","url":"https://api.github.com/users/sfbrigade","html_url":"https://github.com/sfbrigade","followers_url":"https://api.github.com/users/sfbrigade/followers","following_url":"https://api.github.com/users/sfbrigade/following{/other_user}","gists_url":"https://api.github.com/users/sfbrigade/gists{/gist_id}","starred_url":"https://api.github.com/users/sfbrigade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfbrigade/subscriptions","organizations_url":"https://api.github.com/users/sfbrigade/orgs","repos_url":"https://api.github.com/users/sfbrigade/repos","events_url":"https://api.github.com/users/sfbrigade/events{/privacy}","received_events_url":"https://api.github.com/users/sfbrigade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sfbrigade/brigadehub","description":"Simplify your CfA brigade's website maintenance","fork":false,"url":"https://api.github.com/repos/sfbrigade/brigadehub","forks_url":"https://api.github.com/repos/sfbrigade/brigadehub/forks","keys_url":"https://api.github.com/repos/sfbrigade/brigadehub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sfbrigade/brigadehub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sfbrigade/brigadehub/teams","hooks_url":"https://api.github.com/repos/sfbrigade/brigadehub/hooks","issue_events_url":"https://api.github.com/repos/sfbrigade/brigadehub/issues/events{/number}","events_url":"https://api.github.com/repos/sfbrigade/brigadehub/events","assignees_url":"https://api.github.com/repos/sfbrigade/brigadehub/assignees{/user}","branches_url":"https://api.github.com/repos/sfbrigade/brigadehub/branches{/branch}","tags_url":"https://api.github.com/repos/sfbrigade/brigadehub/tags","blobs_url":"https://api.github.com/repos/sfbrigade/brigadehub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sfbrigade/brigadehub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sfbrigade/brigadehub/git/refs{/sha}","trees_url":"https://api.github.com/repos/sfbrigade/brigadehub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sfbrigade/brigadehub/statuses/{sha}","languages_url":"https://api.github.com/repos/sfbrigade/brigadehub/languages","stargazers_url":"https://api.github.com/repos/sfbrigade/brigadehub/stargazers","contributors_url":"https://api.github.com/repos/sfbrigade/brigadehub/contributors","subscribers_url":"https://api.github.com/repos/sfbrigade/brigadehub/subscribers","subscription_url":"https://api.github.com/repos/sfbrigade/brigadehub/subscription","commits_url":"https://api.github.com/repos/sfbrigade/brigadehub/commits{/sha}","git_commits_url":"https://api.github.com/repos/sfbrigade/brigadehub/git/commits{/sha}","comments_url":"https://api.github.com/repos/sfbrigade/brigadehub/comments{/number}","issue_comment_url":"https://api.github.com/repos/sfbrigade/brigadehub/issues/comments{/number}","contents_url":"https://api.github.com/repos/sfbrigade/brigadehub/contents/{+path}","compare_url":"https://api.github.com/repos/sfbrigade/brigadehub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sfbrigade/brigadehub/merges","archive_url":"https://api.github.com/repos/sfbrigade/brigadehub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sfbrigade/brigadehub/downloads","issues_url":"https://api.github.com/repos/sfbrigade/brigadehub/issues{/number}","pulls_url":"https://api.github.com/repos/sfbrigade/brigadehub/pulls{/number}","milestones_url":"https://api.github.com/repos/sfbrigade/brigadehub/milestones{/number}","notifications_url":"https://api.github.com/repos/sfbrigade/brigadehub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sfbrigade/brigadehub/labels{/name}","releases_url":"https://api.github.com/repos/sfbrigade/brigadehub/releases{/id}","deployments_url":"https://api.github.com/repos/sfbrigade/brigadehub/deployments","created_at":"2016-01-20T20:46:26Z","updated_at":"2016-04-18T15:32:23Z","pushed_at":"2016-04-21T15:46:32Z","git_url":"git://github.com/sfbrigade/brigadehub.git","ssh_url":"git@github.com:sfbrigade/brigadehub.git","clone_url":"https://github.com/sfbrigade/brigadehub.git","svn_url":"https://github.com/sfbrigade/brigadehub","homepage":"http://brigadehub.herokuapp.com/","size":36342,"stargazers_count":14,"watchers_count":14,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":68,"forks":8,"open_issues":68,"watchers":14,"default_branch":"edge"}},"base":{"label":"sfbrigade:edge","ref":"edge","sha":"8a1553986f19a61b94358d63881999c0fba17906","user":{"login":"sfbrigade","id":3926630,"avatar_url":"https://avatars.githubusercontent.com/u/3926630?v=3","gravatar_id":"","url":"https://api.github.com/users/sfbrigade","html_url":"https://github.com/sfbrigade","followers_url":"https://api.github.com/users/sfbrigade/followers","following_url":"https://api.github.com/users/sfbrigade/following{/other_user}","gists_url":"https://api.github.com/users/sfbrigade/gists{/gist_id}","starred_url":"https://api.github.com/users/sfbrigade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfbrigade/subscriptions","organizations_url":"https://api.github.com/users/sfbrigade/orgs","repos_url":"https://api.github.com/users/sfbrigade/repos","events_url":"https://api.github.com/users/sfbrigade/events{/privacy}","received_events_url":"https://api.github.com/users/sfbrigade/received_events","type":"Organization","site_admin":false},"repo":{"id":50059179,"name":"brigadehub","full_name":"sfbrigade/brigadehub","owner":{"login":"sfbrigade","id":3926630,"avatar_url":"https://avatars.githubusercontent.com/u/3926630?v=3","gravatar_id":"","url":"https://api.github.com/users/sfbrigade","html_url":"https://github.com/sfbrigade","followers_url":"https://api.github.com/users/sfbrigade/followers","following_url":"https://api.github.com/users/sfbrigade/following{/other_user}","gists_url":"https://api.github.com/users/sfbrigade/gists{/gist_id}","starred_url":"https://api.github.com/users/sfbrigade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfbrigade/subscriptions","organizations_url":"https://api.github.com/users/sfbrigade/orgs","repos_url":"https://api.github.com/users/sfbrigade/repos","events_url":"https://api.github.com/users/sfbrigade/events{/privacy}","received_events_url":"https://api.github.com/users/sfbrigade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sfbrigade/brigadehub","description":"Simplify your CfA brigade's website maintenance","fork":false,"url":"https://api.github.com/repos/sfbrigade/brigadehub","forks_url":"https://api.github.com/repos/sfbrigade/brigadehub/forks","keys_url":"https://api.github.com/repos/sfbrigade/brigadehub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sfbrigade/brigadehub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sfbrigade/brigadehub/teams","hooks_url":"https://api.github.com/repos/sfbrigade/brigadehub/hooks","issue_events_url":"https://api.github.com/repos/sfbrigade/brigadehub/issues/events{/number}","events_url":"https://api.github.com/repos/sfbrigade/brigadehub/events","assignees_url":"https://api.github.com/repos/sfbrigade/brigadehub/assignees{/user}","branches_url":"https://api.github.com/repos/sfbrigade/brigadehub/branches{/branch}","tags_url":"https://api.github.com/repos/sfbrigade/brigadehub/tags","blobs_url":"https://api.github.com/repos/sfbrigade/brigadehub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sfbrigade/brigadehub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sfbrigade/brigadehub/git/refs{/sha}","trees_url":"https://api.github.com/repos/sfbrigade/brigadehub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sfbrigade/brigadehub/statuses/{sha}","languages_url":"https://api.github.com/repos/sfbrigade/brigadehub/languages","stargazers_url":"https://api.github.com/repos/sfbrigade/brigadehub/stargazers","contributors_url":"https://api.github.com/repos/sfbrigade/brigadehub/contributors","subscribers_url":"https://api.github.com/repos/sfbrigade/brigadehub/subscribers","subscription_url":"https://api.github.com/repos/sfbrigade/brigadehub/subscription","commits_url":"https://api.github.com/repos/sfbrigade/brigadehub/commits{/sha}","git_commits_url":"https://api.github.com/repos/sfbrigade/brigadehub/git/commits{/sha}","comments_url":"https://api.github.com/repos/sfbrigade/brigadehub/comments{/number}","issue_comment_url":"https://api.github.com/repos/sfbrigade/brigadehub/issues/comments{/number}","contents_url":"https://api.github.com/repos/sfbrigade/brigadehub/contents/{+path}","compare_url":"https://api.github.com/repos/sfbrigade/brigadehub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sfbrigade/brigadehub/merges","archive_url":"https://api.github.com/repos/sfbrigade/brigadehub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sfbrigade/brigadehub/downloads","issues_url":"https://api.github.com/repos/sfbrigade/brigadehub/issues{/number}","pulls_url":"https://api.github.com/repos/sfbrigade/brigadehub/pulls{/number}","milestones_url":"https://api.github.com/repos/sfbrigade/brigadehub/milestones{/number}","notifications_url":"https://api.github.com/repos/sfbrigade/brigadehub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sfbrigade/brigadehub/labels{/name}","releases_url":"https://api.github.com/repos/sfbrigade/brigadehub/releases{/id}","deployments_url":"https://api.github.com/repos/sfbrigade/brigadehub/deployments","created_at":"2016-01-20T20:46:26Z","updated_at":"2016-04-18T15:32:23Z","pushed_at":"2016-04-21T15:46:32Z","git_url":"git://github.com/sfbrigade/brigadehub.git","ssh_url":"git@github.com:sfbrigade/brigadehub.git","clone_url":"https://github.com/sfbrigade/brigadehub.git","svn_url":"https://github.com/sfbrigade/brigadehub","homepage":"http://brigadehub.herokuapp.com/","size":36342,"stargazers_count":14,"watchers_count":14,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":68,"forks":8,"open_issues":68,"watchers":14,"default_branch":"edge"}},"_links":{"self":{"href":"https://api.github.com/repos/sfbrigade/brigadehub/pulls/223"},"html":{"href":"https://github.com/sfbrigade/brigadehub/pull/223"},"issue":{"href":"https://api.github.com/repos/sfbrigade/brigadehub/issues/223"},"comments":{"href":"https://api.github.com/repos/sfbrigade/brigadehub/issues/223/comments"},"review_comments":{"href":"https://api.github.com/repos/sfbrigade/brigadehub/pulls/223/comments"},"review_comment":{"href":"https://api.github.com/repos/sfbrigade/brigadehub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sfbrigade/brigadehub/pulls/223/commits"},"statuses":{"href":"https://api.github.com/repos/sfbrigade/brigadehub/statuses/b8fcd605c46179d773b51c5625a48c7471dee446"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"therebelrobot","id":679178,"avatar_url":"https://avatars.githubusercontent.com/u/679178?v=3","gravatar_id":"","url":"https://api.github.com/users/therebelrobot","html_url":"https://github.com/therebelrobot","followers_url":"https://api.github.com/users/therebelrobot/followers","following_url":"https://api.github.com/users/therebelrobot/following{/other_user}","gists_url":"https://api.github.com/users/therebelrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/therebelrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therebelrobot/subscriptions","organizations_url":"https://api.github.com/users/therebelrobot/orgs","repos_url":"https://api.github.com/users/therebelrobot/repos","events_url":"https://api.github.com/users/therebelrobot/events{/privacy}","received_events_url":"https://api.github.com/users/therebelrobot/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":4,"additions":374,"deletions":116,"changed_files":11}}