{"action":"created","comment":{"url":"https://api.github.com/repos/idris-lang/Idris-dev/pulls/comments/71337917","id":71337917,"diff_hunk":"@@ -706,8 +704,7 @@ elabClause info opts (cnum, PClause fc fname lhs_in_as withs rhs_in_as wherebloc\n \n         mapM_ (\\(n, _) -> addIBC (IBCDef n)) def''\n \n-        when (not (null def')) $ do\n-           mapM_ defer_totcheck (map (\\x -> (fc, fst x)) def'')\n+        when (not (null def')) $ mapM_ defer_totcheck (map (\\x -> (fc, fst x)) def'')","path":"src/Idris/Elab/Clause.hs","position":26,"original_position":26,"commit_id":"4aedad931584b53a59f1739d0f8593103262aa4a","original_commit_id":"4aedad931584b53a59f1739d0f8593103262aa4a","user":{"login":"david-christiansen","id":115330,"avatar_url":"https://avatars.githubusercontent.com/u/115330?v=3","gravatar_id":"","url":"https://api.github.com/users/david-christiansen","html_url":"https://github.com/david-christiansen","followers_url":"https://api.github.com/users/david-christiansen/followers","following_url":"https://api.github.com/users/david-christiansen/following{/other_user}","gists_url":"https://api.github.com/users/david-christiansen/gists{/gist_id}","starred_url":"https://api.github.com/users/david-christiansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-christiansen/subscriptions","organizations_url":"https://api.github.com/users/david-christiansen/orgs","repos_url":"https://api.github.com/users/david-christiansen/repos","events_url":"https://api.github.com/users/david-christiansen/events{/privacy}","received_events_url":"https://api.github.com/users/david-christiansen/received_events","type":"User","site_admin":false},"body":"It's good to get rid of \"do\" here, but I still think the part after the \"$\" should be indented on the next line, because that looks more like the imperative control structure that \"when\" encodes.","created_at":"2016-07-19T13:31:44Z","updated_at":"2016-07-19T13:31:44Z","html_url":"https://github.com/idris-lang/Idris-dev/pull/3274#discussion_r71337917","pull_request_url":"https://api.github.com/repos/idris-lang/Idris-dev/pulls/3274","_links":{"self":{"href":"https://api.github.com/repos/idris-lang/Idris-dev/pulls/comments/71337917"},"html":{"href":"https://github.com/idris-lang/Idris-dev/pull/3274#discussion_r71337917"},"pull_request":{"href":"https://api.github.com/repos/idris-lang/Idris-dev/pulls/3274"}}},"pull_request":{"url":"https://api.github.com/repos/idris-lang/Idris-dev/pulls/3274","id":77942704,"html_url":"https://github.com/idris-lang/Idris-dev/pull/3274","diff_url":"https://github.com/idris-lang/Idris-dev/pull/3274.diff","patch_url":"https://github.com/idris-lang/Idris-dev/pull/3274.patch","issue_url":"https://api.github.com/repos/idris-lang/Idris-dev/issues/3274","number":3274,"state":"open","locked":false,"title":"HLint Inspired Code Cleanup 'Redundant Do'","user":{"login":"jfdm","id":331273,"avatar_url":"https://avatars.githubusercontent.com/u/331273?v=3","gravatar_id":"","url":"https://api.github.com/users/jfdm","html_url":"https://github.com/jfdm","followers_url":"https://api.github.com/users/jfdm/followers","following_url":"https://api.github.com/users/jfdm/following{/other_user}","gists_url":"https://api.github.com/users/jfdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jfdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfdm/subscriptions","organizations_url":"https://api.github.com/users/jfdm/orgs","repos_url":"https://api.github.com/users/jfdm/repos","events_url":"https://api.github.com/users/jfdm/events{/privacy}","received_events_url":"https://api.github.com/users/jfdm/received_events","type":"User","site_admin":false},"body":"Where code clarity is not hindered HLint's raising of 'Redundant do\"\r\nhas been addressed.\r\n\r\nOther formatting improvements have been made in some functions.","created_at":"2016-07-19T09:17:51Z","updated_at":"2016-07-19T13:31:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97568505af6158fab72766620a377c6e26e4d2e2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/idris-lang/Idris-dev/pulls/3274/commits","review_comments_url":"https://api.github.com/repos/idris-lang/Idris-dev/pulls/3274/comments","review_comment_url":"https://api.github.com/repos/idris-lang/Idris-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/idris-lang/Idris-dev/issues/3274/comments","statuses_url":"https://api.github.com/repos/idris-lang/Idris-dev/statuses/4aedad931584b53a59f1739d0f8593103262aa4a","head":{"label":"jfdm:more-hlint-fixes","ref":"more-hlint-fixes","sha":"4aedad931584b53a59f1739d0f8593103262aa4a","user":{"login":"jfdm","id":331273,"avatar_url":"https://avatars.githubusercontent.com/u/331273?v=3","gravatar_id":"","url":"https://api.github.com/users/jfdm","html_url":"https://github.com/jfdm","followers_url":"https://api.github.com/users/jfdm/followers","following_url":"https://api.github.com/users/jfdm/following{/other_user}","gists_url":"https://api.github.com/users/jfdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jfdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfdm/subscriptions","organizations_url":"https://api.github.com/users/jfdm/orgs","repos_url":"https://api.github.com/users/jfdm/repos","events_url":"https://api.github.com/users/jfdm/events{/privacy}","received_events_url":"https://api.github.com/users/jfdm/received_events","type":"User","site_admin":false},"repo":{"id":33959315,"name":"Idris-dev","full_name":"jfdm/Idris-dev","owner":{"login":"jfdm","id":331273,"avatar_url":"https://avatars.githubusercontent.com/u/331273?v=3","gravatar_id":"","url":"https://api.github.com/users/jfdm","html_url":"https://github.com/jfdm","followers_url":"https://api.github.com/users/jfdm/followers","following_url":"https://api.github.com/users/jfdm/following{/other_user}","gists_url":"https://api.github.com/users/jfdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jfdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfdm/subscriptions","organizations_url":"https://api.github.com/users/jfdm/orgs","repos_url":"https://api.github.com/users/jfdm/repos","events_url":"https://api.github.com/users/jfdm/events{/privacy}","received_events_url":"https://api.github.com/users/jfdm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jfdm/Idris-dev","description":"A Dependently Typed Functional Programming Language","fork":true,"url":"https://api.github.com/repos/jfdm/Idris-dev","forks_url":"https://api.github.com/repos/jfdm/Idris-dev/forks","keys_url":"https://api.github.com/repos/jfdm/Idris-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jfdm/Idris-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jfdm/Idris-dev/teams","hooks_url":"https://api.github.com/repos/jfdm/Idris-dev/hooks","issue_events_url":"https://api.github.com/repos/jfdm/Idris-dev/issues/events{/number}","events_url":"https://api.github.com/repos/jfdm/Idris-dev/events","assignees_url":"https://api.github.com/repos/jfdm/Idris-dev/assignees{/user}","branches_url":"https://api.github.com/repos/jfdm/Idris-dev/branches{/branch}","tags_url":"https://api.github.com/repos/jfdm/Idris-dev/tags","blobs_url":"https://api.github.com/repos/jfdm/Idris-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jfdm/Idris-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jfdm/Idris-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/jfdm/Idris-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jfdm/Idris-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/jfdm/Idris-dev/languages","stargazers_url":"https://api.github.com/repos/jfdm/Idris-dev/stargazers","contributors_url":"https://api.github.com/repos/jfdm/Idris-dev/contributors","subscribers_url":"https://api.github.com/repos/jfdm/Idris-dev/subscribers","subscription_url":"https://api.github.com/repos/jfdm/Idris-dev/subscription","commits_url":"https://api.github.com/repos/jfdm/Idris-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/jfdm/Idris-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/jfdm/Idris-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/jfdm/Idris-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/jfdm/Idris-dev/contents/{+path}","compare_url":"https://api.github.com/repos/jfdm/Idris-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jfdm/Idris-dev/merges","archive_url":"https://api.github.com/repos/jfdm/Idris-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jfdm/Idris-dev/downloads","issues_url":"https://api.github.com/repos/jfdm/Idris-dev/issues{/number}","pulls_url":"https://api.github.com/repos/jfdm/Idris-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/jfdm/Idris-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/jfdm/Idris-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jfdm/Idris-dev/labels{/name}","releases_url":"https://api.github.com/repos/jfdm/Idris-dev/releases{/id}","deployments_url":"https://api.github.com/repos/jfdm/Idris-dev/deployments","created_at":"2015-04-14T22:00:45Z","updated_at":"2016-01-26T13:18:22Z","pushed_at":"2016-07-19T09:22:20Z","git_url":"git://github.com/jfdm/Idris-dev.git","ssh_url":"git@github.com:jfdm/Idris-dev.git","clone_url":"https://github.com/jfdm/Idris-dev.git","svn_url":"https://github.com/jfdm/Idris-dev","homepage":"http://idris-lang.org","size":33722,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"idris-lang:master","ref":"master","sha":"95c92972be549bf87dc1d108983ee4164ae4f2fe","user":{"login":"idris-lang","id":5552910,"avatar_url":"https://avatars.githubusercontent.com/u/5552910?v=3","gravatar_id":"","url":"https://api.github.com/users/idris-lang","html_url":"https://github.com/idris-lang","followers_url":"https://api.github.com/users/idris-lang/followers","following_url":"https://api.github.com/users/idris-lang/following{/other_user}","gists_url":"https://api.github.com/users/idris-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/idris-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idris-lang/subscriptions","organizations_url":"https://api.github.com/users/idris-lang/orgs","repos_url":"https://api.github.com/users/idris-lang/repos","events_url":"https://api.github.com/users/idris-lang/events{/privacy}","received_events_url":"https://api.github.com/users/idris-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":2386778,"name":"Idris-dev","full_name":"idris-lang/Idris-dev","owner":{"login":"idris-lang","id":5552910,"avatar_url":"https://avatars.githubusercontent.com/u/5552910?v=3","gravatar_id":"","url":"https://api.github.com/users/idris-lang","html_url":"https://github.com/idris-lang","followers_url":"https://api.github.com/users/idris-lang/followers","following_url":"https://api.github.com/users/idris-lang/following{/other_user}","gists_url":"https://api.github.com/users/idris-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/idris-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idris-lang/subscriptions","organizations_url":"https://api.github.com/users/idris-lang/orgs","repos_url":"https://api.github.com/users/idris-lang/repos","events_url":"https://api.github.com/users/idris-lang/events{/privacy}","received_events_url":"https://api.github.com/users/idris-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/idris-lang/Idris-dev","description":"A Dependently Typed Functional Programming Language","fork":false,"url":"https://api.github.com/repos/idris-lang/Idris-dev","forks_url":"https://api.github.com/repos/idris-lang/Idris-dev/forks","keys_url":"https://api.github.com/repos/idris-lang/Idris-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idris-lang/Idris-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idris-lang/Idris-dev/teams","hooks_url":"https://api.github.com/repos/idris-lang/Idris-dev/hooks","issue_events_url":"https://api.github.com/repos/idris-lang/Idris-dev/issues/events{/number}","events_url":"https://api.github.com/repos/idris-lang/Idris-dev/events","assignees_url":"https://api.github.com/repos/idris-lang/Idris-dev/assignees{/user}","branches_url":"https://api.github.com/repos/idris-lang/Idris-dev/branches{/branch}","tags_url":"https://api.github.com/repos/idris-lang/Idris-dev/tags","blobs_url":"https://api.github.com/repos/idris-lang/Idris-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idris-lang/Idris-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idris-lang/Idris-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/idris-lang/Idris-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idris-lang/Idris-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/idris-lang/Idris-dev/languages","stargazers_url":"https://api.github.com/repos/idris-lang/Idris-dev/stargazers","contributors_url":"https://api.github.com/repos/idris-lang/Idris-dev/contributors","subscribers_url":"https://api.github.com/repos/idris-lang/Idris-dev/subscribers","subscription_url":"https://api.github.com/repos/idris-lang/Idris-dev/subscription","commits_url":"https://api.github.com/repos/idris-lang/Idris-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/idris-lang/Idris-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/idris-lang/Idris-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/idris-lang/Idris-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/idris-lang/Idris-dev/contents/{+path}","compare_url":"https://api.github.com/repos/idris-lang/Idris-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idris-lang/Idris-dev/merges","archive_url":"https://api.github.com/repos/idris-lang/Idris-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idris-lang/Idris-dev/downloads","issues_url":"https://api.github.com/repos/idris-lang/Idris-dev/issues{/number}","pulls_url":"https://api.github.com/repos/idris-lang/Idris-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/idris-lang/Idris-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/idris-lang/Idris-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idris-lang/Idris-dev/labels{/name}","releases_url":"https://api.github.com/repos/idris-lang/Idris-dev/releases{/id}","deployments_url":"https://api.github.com/repos/idris-lang/Idris-dev/deployments","created_at":"2011-09-14T16:55:49Z","updated_at":"2016-07-17T18:02:43Z","pushed_at":"2016-07-19T09:17:51Z","git_url":"git://github.com/idris-lang/Idris-dev.git","ssh_url":"git@github.com:idris-lang/Idris-dev.git","clone_url":"https://github.com/idris-lang/Idris-dev.git","svn_url":"https://github.com/idris-lang/Idris-dev","homepage":"http://idris-lang.org","size":35091,"stargazers_count":1273,"watchers_count":1273,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":342,"mirror_url":null,"open_issues_count":357,"forks":342,"open_issues":357,"watchers":1273,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/idris-lang/Idris-dev/pulls/3274"},"html":{"href":"https://github.com/idris-lang/Idris-dev/pull/3274"},"issue":{"href":"https://api.github.com/repos/idris-lang/Idris-dev/issues/3274"},"comments":{"href":"https://api.github.com/repos/idris-lang/Idris-dev/issues/3274/comments"},"review_comments":{"href":"https://api.github.com/repos/idris-lang/Idris-dev/pulls/3274/comments"},"review_comment":{"href":"https://api.github.com/repos/idris-lang/Idris-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/idris-lang/Idris-dev/pulls/3274/commits"},"statuses":{"href":"https://api.github.com/repos/idris-lang/Idris-dev/statuses/4aedad931584b53a59f1739d0f8593103262aa4a"}}}}
{"actor":{"display_login":"david-christiansen"}}