{"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/90619962","pull_request_review_id":11138321,"id":90619962,"diff_hunk":"@@ -726,21 +727,39 @@ int do_ssl3_write(SSL *s, int type, const unsigned char *buf,\n         align = (size_t)SSL3_BUFFER_get_buf(wb) + 2 * SSL3_RT_HEADER_LENGTH;\n         align = SSL3_ALIGN_PAYLOAD - 1 - ((align - 1) % SSL3_ALIGN_PAYLOAD);\n #endif\n-        outbuf[0] = SSL3_BUFFER_get_buf(wb) + align;\n         SSL3_BUFFER_set_offset(wb, align);\n+        if (!WPACKET_init_static_len(&pkt[0], SSL3_BUFFER_get_buf(wb),","path":"ssl/record/rec_layer_s3.c","position":25,"original_position":25,"commit_id":"f8ea45255b9a2f491ec4bcdafa94ddf9e74e3d4d","original_commit_id":"f8ea45255b9a2f491ec4bcdafa94ddf9e74e3d4d","user":{"login":"mattcaswell","id":7422273,"avatar_url":"https://avatars.githubusercontent.com/u/7422273?v=3","gravatar_id":"","url":"https://api.github.com/users/mattcaswell","html_url":"https://github.com/mattcaswell","followers_url":"https://api.github.com/users/mattcaswell/followers","following_url":"https://api.github.com/users/mattcaswell/following{/other_user}","gists_url":"https://api.github.com/users/mattcaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattcaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattcaswell/subscriptions","organizations_url":"https://api.github.com/users/mattcaswell/orgs","repos_url":"https://api.github.com/users/mattcaswell/repos","events_url":"https://api.github.com/users/mattcaswell/events{/privacy}","received_events_url":"https://api.github.com/users/mattcaswell/received_events","type":"User","site_admin":false},"body":"Yes they are the same, but in my mind it makes it a lot clearer that you are referring to a single entity and not the array as a whole. Especially when you mix it in scenarios where on other lines we refer to a single entity which is not at index 0. I dislike the inconsistency.","created_at":"2016-12-02T10:35:14Z","updated_at":"2016-12-02T10:35:14Z","html_url":"https://github.com/openssl/openssl/pull/1975#discussion_r90619962","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/1975","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/90619962"},"html":{"href":"https://github.com/openssl/openssl/pull/1975#discussion_r90619962"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1975"}}},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/1975","id":94658788,"html_url":"https://github.com/openssl/openssl/pull/1975","diff_url":"https://github.com/openssl/openssl/pull/1975.diff","patch_url":"https://github.com/openssl/openssl/pull/1975.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/1975","number":1975,"state":"open","locked":false,"title":"TLSv1.3: Record Construction","user":{"login":"mattcaswell","id":7422273,"avatar_url":"https://avatars.githubusercontent.com/u/7422273?v=3","gravatar_id":"","url":"https://api.github.com/users/mattcaswell","html_url":"https://github.com/mattcaswell","followers_url":"https://api.github.com/users/mattcaswell/followers","following_url":"https://api.github.com/users/mattcaswell/following{/other_user}","gists_url":"https://api.github.com/users/mattcaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattcaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattcaswell/subscriptions","organizations_url":"https://api.github.com/users/mattcaswell/orgs","repos_url":"https://api.github.com/users/mattcaswell/repos","events_url":"https://api.github.com/users/mattcaswell/events{/privacy}","received_events_url":"https://api.github.com/users/mattcaswell/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nContributors guide: https://github.com/openssl/openssl/blob/master/CONTRIBUTING\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n- [x] tests are added or updated\r\n- [x] CLA is signed\r\n\r\n##### Description of change\r\n<!-- Provide a description of the changes.\r\n\r\nIf it fixes a github issue, add Fixes #XXXX.\r\n-->\r\nThis modifies the record layer to use TLSv1.3 record construction. I also updated various parts of the record layer to use PACKET/WPACKET.\r\n","created_at":"2016-11-21T17:20:03Z","updated_at":"2016-12-02T10:35:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9d7730060b62e9132a191760c40c609a1c22847","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/1975/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/1975/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/1975/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/f8ea45255b9a2f491ec4bcdafa94ddf9e74e3d4d","head":{"label":"mattcaswell:tls1_3-record-construct","ref":"tls1_3-record-construct","sha":"f8ea45255b9a2f491ec4bcdafa94ddf9e74e3d4d","user":{"login":"mattcaswell","id":7422273,"avatar_url":"https://avatars.githubusercontent.com/u/7422273?v=3","gravatar_id":"","url":"https://api.github.com/users/mattcaswell","html_url":"https://github.com/mattcaswell","followers_url":"https://api.github.com/users/mattcaswell/followers","following_url":"https://api.github.com/users/mattcaswell/following{/other_user}","gists_url":"https://api.github.com/users/mattcaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattcaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattcaswell/subscriptions","organizations_url":"https://api.github.com/users/mattcaswell/orgs","repos_url":"https://api.github.com/users/mattcaswell/repos","events_url":"https://api.github.com/users/mattcaswell/events{/privacy}","received_events_url":"https://api.github.com/users/mattcaswell/received_events","type":"User","site_admin":false},"repo":{"id":26978010,"name":"openssl","full_name":"mattcaswell/openssl","owner":{"login":"mattcaswell","id":7422273,"avatar_url":"https://avatars.githubusercontent.com/u/7422273?v=3","gravatar_id":"","url":"https://api.github.com/users/mattcaswell","html_url":"https://github.com/mattcaswell","followers_url":"https://api.github.com/users/mattcaswell/followers","following_url":"https://api.github.com/users/mattcaswell/following{/other_user}","gists_url":"https://api.github.com/users/mattcaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattcaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattcaswell/subscriptions","organizations_url":"https://api.github.com/users/mattcaswell/orgs","repos_url":"https://api.github.com/users/mattcaswell/repos","events_url":"https://api.github.com/users/mattcaswell/events{/privacy}","received_events_url":"https://api.github.com/users/mattcaswell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattcaswell/openssl","description":null,"fork":true,"url":"https://api.github.com/repos/mattcaswell/openssl","forks_url":"https://api.github.com/repos/mattcaswell/openssl/forks","keys_url":"https://api.github.com/repos/mattcaswell/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattcaswell/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattcaswell/openssl/teams","hooks_url":"https://api.github.com/repos/mattcaswell/openssl/hooks","issue_events_url":"https://api.github.com/repos/mattcaswell/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/mattcaswell/openssl/events","assignees_url":"https://api.github.com/repos/mattcaswell/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/mattcaswell/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/mattcaswell/openssl/tags","blobs_url":"https://api.github.com/repos/mattcaswell/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattcaswell/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattcaswell/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattcaswell/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattcaswell/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/mattcaswell/openssl/languages","stargazers_url":"https://api.github.com/repos/mattcaswell/openssl/stargazers","contributors_url":"https://api.github.com/repos/mattcaswell/openssl/contributors","subscribers_url":"https://api.github.com/repos/mattcaswell/openssl/subscribers","subscription_url":"https://api.github.com/repos/mattcaswell/openssl/subscription","commits_url":"https://api.github.com/repos/mattcaswell/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattcaswell/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattcaswell/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattcaswell/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattcaswell/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/mattcaswell/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattcaswell/openssl/merges","archive_url":"https://api.github.com/repos/mattcaswell/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattcaswell/openssl/downloads","issues_url":"https://api.github.com/repos/mattcaswell/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/mattcaswell/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/mattcaswell/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/mattcaswell/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattcaswell/openssl/labels{/name}","releases_url":"https://api.github.com/repos/mattcaswell/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/mattcaswell/openssl/deployments","created_at":"2014-11-21T21:09:59Z","updated_at":"2016-08-01T05:48:34Z","pushed_at":"2016-12-02T10:19:17Z","git_url":"git://github.com/mattcaswell/openssl.git","ssh_url":"git@github.com:mattcaswell/openssl.git","clone_url":"https://github.com/mattcaswell/openssl.git","svn_url":"https://github.com/mattcaswell/openssl","homepage":null,"size":116427,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"bcd62c2512dd031cc524d058494aadebaaf1fc4c","user":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2016-12-02T10:17:56Z","pushed_at":"2016-12-02T10:19:18Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":127593,"stargazers_count":3676,"watchers_count":3676,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2032,"mirror_url":null,"open_issues_count":223,"forks":2032,"open_issues":223,"watchers":3676,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1975"},"html":{"href":"https://github.com/openssl/openssl/pull/1975"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/1975"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/1975/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1975/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1975/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/f8ea45255b9a2f491ec4bcdafa94ddf9e74e3d4d"}}}}
{"actor":{"display_login":"mattcaswell"}}