{"action":"created","issue":{"url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/202","repository_url":"https://api.github.com/repos/se-edu/addressbook-level4","labels_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/202/labels{/name}","comments_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/202/comments","events_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/202/events","html_url":"https://github.com/se-edu/addressbook-level4/pull/202","id":194451106,"number":202,"title":"Users can delete multiple persons in one shot","user":{"login":"cheec","id":19281995,"avatar_url":"https://avatars.githubusercontent.com/u/19281995?v=3","gravatar_id":"","url":"https://api.github.com/users/cheec","html_url":"https://github.com/cheec","followers_url":"https://api.github.com/users/cheec/followers","following_url":"https://api.github.com/users/cheec/following{/other_user}","gists_url":"https://api.github.com/users/cheec/gists{/gist_id}","starred_url":"https://api.github.com/users/cheec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheec/subscriptions","organizations_url":"https://api.github.com/users/cheec/orgs","repos_url":"https://api.github.com/users/cheec/repos","events_url":"https://api.github.com/users/cheec/events{/privacy}","received_events_url":"https://api.github.com/users/cheec/received_events","type":"User","site_admin":false},"labels":[{"id":456150598,"url":"https://api.github.com/repos/se-edu/addressbook-level4/labels/s.ToMerge","name":"s.ToMerge","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":{"login":"YijinL","id":7914712,"avatar_url":"https://avatars.githubusercontent.com/u/7914712?v=3","gravatar_id":"","url":"https://api.github.com/users/YijinL","html_url":"https://github.com/YijinL","followers_url":"https://api.github.com/users/YijinL/followers","following_url":"https://api.github.com/users/YijinL/following{/other_user}","gists_url":"https://api.github.com/users/YijinL/gists{/gist_id}","starred_url":"https://api.github.com/users/YijinL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YijinL/subscriptions","organizations_url":"https://api.github.com/users/YijinL/orgs","repos_url":"https://api.github.com/users/YijinL/repos","events_url":"https://api.github.com/users/YijinL/events{/privacy}","received_events_url":"https://api.github.com/users/YijinL/received_events","type":"User","site_admin":false},"assignees":[{"login":"YijinL","id":7914712,"avatar_url":"https://avatars.githubusercontent.com/u/7914712?v=3","gravatar_id":"","url":"https://api.github.com/users/YijinL","html_url":"https://github.com/YijinL","followers_url":"https://api.github.com/users/YijinL/followers","following_url":"https://api.github.com/users/YijinL/following{/other_user}","gists_url":"https://api.github.com/users/YijinL/gists{/gist_id}","starred_url":"https://api.github.com/users/YijinL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YijinL/subscriptions","organizations_url":"https://api.github.com/users/YijinL/orgs","repos_url":"https://api.github.com/users/YijinL/repos","events_url":"https://api.github.com/users/YijinL/events{/privacy}","received_events_url":"https://api.github.com/users/YijinL/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2016-12-08T21:37:21Z","updated_at":"2016-12-16T13:57:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/se-edu/addressbook-level4/pulls/202","html_url":"https://github.com/se-edu/addressbook-level4/pull/202","diff_url":"https://github.com/se-edu/addressbook-level4/pull/202.diff","patch_url":"https://github.com/se-edu/addressbook-level4/pull/202.patch"},"body":"Fixes #140 \r\nImplement multiple deleting \r\n* Users can now delete multiple persons in a single command\r\n* Users must seperate multiple indices with at least a single whitespace\r\n* Users can also specify a range indicator '-' for range deleting\r\n* Overlapping ranges are also handled appropriately\r\n* Indices specified in ranges do not need to be in ascending order\r\n* Indices cannot exceed list size\r\n\r\nExamples: \r\n* `delete 5 1 7 10-16` deletes persons 1, 5, 7, 10 to 16\r\n* `delete 1 1 1 1 1` deletes person 1\r\n* `delete 5-1 1-5 1 2 3 4 5` deletes persons 1 to 5\r\n* `delete 1-3 2-5 1-10` deletes persons 1 to 10\r\n* `delete 6-1` delete persons 1 to 6\r\n\r\nThis PR contains major changes pertinent to:\r\n* `Parser` - add new helper methods to parse arguments above\r\n* `DeleteCommand` - implement above functionality\r\n* `DeleteCommandTest` - add some GUI tests\r\n* `LogicManagerTest` - delete command tests added/updated\r\n* `StringUtilTest` - added tests for new helper method `StringUtil::toIndexedListString` \r\n* `ListUtil` - create utility class holding methods relevant to lists\r\n* `CollectionUtil` - fixed and refactored the otherwise not functioning `CollectionUtil::assertNoNullElements`\r\n    * I'm guessing no one found this out because of the lack of `CollectionUtil` tests, time to open a new issue I think ;^)\r\n* Docs - update UG to match new functionality \r\n\r\n![ss](https://cloud.githubusercontent.com/assets/19281995/21054825/1abf3f4e-be6a-11e6-98bc-c0c0179187b6.png)\r\n"},"comment":{"url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/comments/267599325","html_url":"https://github.com/se-edu/addressbook-level4/pull/202#issuecomment-267599325","issue_url":"https://api.github.com/repos/se-edu/addressbook-level4/issues/202","id":267599325,"user":{"login":"YijinL","id":7914712,"avatar_url":"https://avatars.githubusercontent.com/u/7914712?v=3","gravatar_id":"","url":"https://api.github.com/users/YijinL","html_url":"https://github.com/YijinL","followers_url":"https://api.github.com/users/YijinL/followers","following_url":"https://api.github.com/users/YijinL/following{/other_user}","gists_url":"https://api.github.com/users/YijinL/gists{/gist_id}","starred_url":"https://api.github.com/users/YijinL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YijinL/subscriptions","organizations_url":"https://api.github.com/users/YijinL/orgs","repos_url":"https://api.github.com/users/YijinL/repos","events_url":"https://api.github.com/users/YijinL/events{/privacy}","received_events_url":"https://api.github.com/users/YijinL/received_events","type":"User","site_admin":false},"created_at":"2016-12-16T13:57:55Z","updated_at":"2016-12-16T13:57:55Z","body":"@cheec looks pretty good\r\nNext time if you rebase please add a brief overview of new changes as a PR comment, because it feels inefficient to look through all changes again :P\r\nOr don't rebase and we can use github's 'see changes since last review' feature."}}
{"actor":{"display_login":"YijinL"}}