{"action":"created","comment":{"url":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/comments/50932893","id":50932893,"diff_hunk":"@@ -48,6 +49,20 @@ passport.use(new HTTPSignatureStrategy(\n       })\n   }))\n \n+passport.use(new ClientCertStrategy((userName, info, done) => {\n+  if (!config.auth.client_certificates_enabled) {\n+    return done(new UnauthorizedError('Unsupported authentication method'))\n+  }\n+\n+  Account.findByName(userName)\n+    .then(function (userObj) {\n+      if (!userObj || userObj.is_disabled || userObj.fingerprint !== info.fingerprint) {","path":"src/services/auth.js","position":19,"original_position":19,"commit_id":"5a9e9cd0fa7311c43be72c15d532d0fb1f2c46ed","original_commit_id":"5a9e9cd0fa7311c43be72c15d532d0fb1f2c46ed","user":{"login":"clark800","id":1238722,"avatar_url":"https://avatars.githubusercontent.com/u/1238722?v=3","gravatar_id":"","url":"https://api.github.com/users/clark800","html_url":"https://github.com/clark800","followers_url":"https://api.github.com/users/clark800/followers","following_url":"https://api.github.com/users/clark800/following{/other_user}","gists_url":"https://api.github.com/users/clark800/gists{/gist_id}","starred_url":"https://api.github.com/users/clark800/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clark800/subscriptions","organizations_url":"https://api.github.com/users/clark800/orgs","repos_url":"https://api.github.com/users/clark800/repos","events_url":"https://api.github.com/users/clark800/events{/privacy}","received_events_url":"https://api.github.com/users/clark800/received_events","type":"User","site_admin":false},"body":"> I think we could only use one authentication method at a time.\r\n\r\nI don't understand. The username is the same regardless of authentication method. If it's the fingerprint, then what happens to a user who doesn't use client certs?","created_at":"2016-01-27T02:06:46Z","updated_at":"2016-01-27T02:06:46Z","html_url":"https://github.com/interledger/five-bells-ledger/pull/125#discussion_r50932893","pull_request_url":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/125","_links":{"self":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/comments/50932893"},"html":{"href":"https://github.com/interledger/five-bells-ledger/pull/125#discussion_r50932893"},"pull_request":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/125"}}},"pull_request":{"url":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/125","id":57288028,"html_url":"https://github.com/interledger/five-bells-ledger/pull/125","diff_url":"https://github.com/interledger/five-bells-ledger/pull/125.diff","patch_url":"https://github.com/interledger/five-bells-ledger/pull/125.patch","issue_url":"https://api.github.com/repos/interledger/five-bells-ledger/issues/125","number":125,"state":"open","locked":false,"title":"Initial implementation for client certificate authentication","user":{"login":"lumberj","id":1812196,"avatar_url":"https://avatars.githubusercontent.com/u/1812196?v=3","gravatar_id":"","url":"https://api.github.com/users/lumberj","html_url":"https://github.com/lumberj","followers_url":"https://api.github.com/users/lumberj/followers","following_url":"https://api.github.com/users/lumberj/following{/other_user}","gists_url":"https://api.github.com/users/lumberj/gists{/gist_id}","starred_url":"https://api.github.com/users/lumberj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumberj/subscriptions","organizations_url":"https://api.github.com/users/lumberj/orgs","repos_url":"https://api.github.com/users/lumberj/repos","events_url":"https://api.github.com/users/lumberj/events{/privacy}","received_events_url":"https://api.github.com/users/lumberj/received_events","type":"User","site_admin":false},"body":"Depends on:\r\n\r\nhttps://github.com/interledger/five-bells-shared/pull/50\r\nhttps://github.com/interledger/five-bells-shared/pull/52\r\n\r\nWorking example:\r\n\r\nServer\r\n```diff\r\n   _makeRouter () {\r\n     const router = new Router()\r\n-    router.get('/health', health.getResource)\r\n+\r\n+    router.get('/health',\r\n+        passport.authenticate(['client-cert']),\r\n+        health.getResource)\r\n\r\n```\r\n\r\nClient\r\n```js\r\nvar fs = require('fs');\r\nvar https = require('https');\r\n\r\nvar options = {\r\n  hostname: 'localhost',\r\n  port: 3000,\r\n  path: '/health',\r\n  method: 'GET',\r\n  key: fs.readFileSync('client1-key.pem'),\r\n  cert: fs.readFileSync('client1-crt.pem'),\r\n  ca: fs.readFileSync('ca-crt.pem') // Trust the test servers self-signed cert\r\n};\r\n\r\nvar req = https.request(options, function(res) {\r\n  res.on('data', function(data) {\r\n    process.stdout.write(data);\r\n  });\r\n});\r\nreq.end();\r\n```","created_at":"2016-01-26T23:07:13Z","updated_at":"2016-01-27T02:06:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e03c80442807528ba0d495b9e2f2ddf1f738dd7","assignee":{"login":"clark800","id":1238722,"avatar_url":"https://avatars.githubusercontent.com/u/1238722?v=3","gravatar_id":"","url":"https://api.github.com/users/clark800","html_url":"https://github.com/clark800","followers_url":"https://api.github.com/users/clark800/followers","following_url":"https://api.github.com/users/clark800/following{/other_user}","gists_url":"https://api.github.com/users/clark800/gists{/gist_id}","starred_url":"https://api.github.com/users/clark800/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clark800/subscriptions","organizations_url":"https://api.github.com/users/clark800/orgs","repos_url":"https://api.github.com/users/clark800/repos","events_url":"https://api.github.com/users/clark800/events{/privacy}","received_events_url":"https://api.github.com/users/clark800/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/125/commits","review_comments_url":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/125/comments","review_comment_url":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/interledger/five-bells-ledger/issues/125/comments","statuses_url":"https://api.github.com/repos/interledger/five-bells-ledger/statuses/5a9e9cd0fa7311c43be72c15d532d0fb1f2c46ed","head":{"label":"lumberj:client-certs","ref":"client-certs","sha":"5a9e9cd0fa7311c43be72c15d532d0fb1f2c46ed","user":{"login":"lumberj","id":1812196,"avatar_url":"https://avatars.githubusercontent.com/u/1812196?v=3","gravatar_id":"","url":"https://api.github.com/users/lumberj","html_url":"https://github.com/lumberj","followers_url":"https://api.github.com/users/lumberj/followers","following_url":"https://api.github.com/users/lumberj/following{/other_user}","gists_url":"https://api.github.com/users/lumberj/gists{/gist_id}","starred_url":"https://api.github.com/users/lumberj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumberj/subscriptions","organizations_url":"https://api.github.com/users/lumberj/orgs","repos_url":"https://api.github.com/users/lumberj/repos","events_url":"https://api.github.com/users/lumberj/events{/privacy}","received_events_url":"https://api.github.com/users/lumberj/received_events","type":"User","site_admin":false},"repo":{"id":49240165,"name":"five-bells-ledger","full_name":"lumberj/five-bells-ledger","owner":{"login":"lumberj","id":1812196,"avatar_url":"https://avatars.githubusercontent.com/u/1812196?v=3","gravatar_id":"","url":"https://api.github.com/users/lumberj","html_url":"https://github.com/lumberj","followers_url":"https://api.github.com/users/lumberj/followers","following_url":"https://api.github.com/users/lumberj/following{/other_user}","gists_url":"https://api.github.com/users/lumberj/gists{/gist_id}","starred_url":"https://api.github.com/users/lumberj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lumberj/subscriptions","organizations_url":"https://api.github.com/users/lumberj/orgs","repos_url":"https://api.github.com/users/lumberj/repos","events_url":"https://api.github.com/users/lumberj/events{/privacy}","received_events_url":"https://api.github.com/users/lumberj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lumberj/five-bells-ledger","description":"An implementation of the Five Bells ledger interface.","fork":true,"url":"https://api.github.com/repos/lumberj/five-bells-ledger","forks_url":"https://api.github.com/repos/lumberj/five-bells-ledger/forks","keys_url":"https://api.github.com/repos/lumberj/five-bells-ledger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lumberj/five-bells-ledger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lumberj/five-bells-ledger/teams","hooks_url":"https://api.github.com/repos/lumberj/five-bells-ledger/hooks","issue_events_url":"https://api.github.com/repos/lumberj/five-bells-ledger/issues/events{/number}","events_url":"https://api.github.com/repos/lumberj/five-bells-ledger/events","assignees_url":"https://api.github.com/repos/lumberj/five-bells-ledger/assignees{/user}","branches_url":"https://api.github.com/repos/lumberj/five-bells-ledger/branches{/branch}","tags_url":"https://api.github.com/repos/lumberj/five-bells-ledger/tags","blobs_url":"https://api.github.com/repos/lumberj/five-bells-ledger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lumberj/five-bells-ledger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lumberj/five-bells-ledger/git/refs{/sha}","trees_url":"https://api.github.com/repos/lumberj/five-bells-ledger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lumberj/five-bells-ledger/statuses/{sha}","languages_url":"https://api.github.com/repos/lumberj/five-bells-ledger/languages","stargazers_url":"https://api.github.com/repos/lumberj/five-bells-ledger/stargazers","contributors_url":"https://api.github.com/repos/lumberj/five-bells-ledger/contributors","subscribers_url":"https://api.github.com/repos/lumberj/five-bells-ledger/subscribers","subscription_url":"https://api.github.com/repos/lumberj/five-bells-ledger/subscription","commits_url":"https://api.github.com/repos/lumberj/five-bells-ledger/commits{/sha}","git_commits_url":"https://api.github.com/repos/lumberj/five-bells-ledger/git/commits{/sha}","comments_url":"https://api.github.com/repos/lumberj/five-bells-ledger/comments{/number}","issue_comment_url":"https://api.github.com/repos/lumberj/five-bells-ledger/issues/comments{/number}","contents_url":"https://api.github.com/repos/lumberj/five-bells-ledger/contents/{+path}","compare_url":"https://api.github.com/repos/lumberj/five-bells-ledger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lumberj/five-bells-ledger/merges","archive_url":"https://api.github.com/repos/lumberj/five-bells-ledger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lumberj/five-bells-ledger/downloads","issues_url":"https://api.github.com/repos/lumberj/five-bells-ledger/issues{/number}","pulls_url":"https://api.github.com/repos/lumberj/five-bells-ledger/pulls{/number}","milestones_url":"https://api.github.com/repos/lumberj/five-bells-ledger/milestones{/number}","notifications_url":"https://api.github.com/repos/lumberj/five-bells-ledger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lumberj/five-bells-ledger/labels{/name}","releases_url":"https://api.github.com/repos/lumberj/five-bells-ledger/releases{/id}","deployments_url":"https://api.github.com/repos/lumberj/five-bells-ledger/deployments","created_at":"2016-01-08T00:53:53Z","updated_at":"2016-01-08T00:53:54Z","pushed_at":"2016-01-26T23:09:04Z","git_url":"git://github.com/lumberj/five-bells-ledger.git","ssh_url":"git@github.com:lumberj/five-bells-ledger.git","clone_url":"https://github.com/lumberj/five-bells-ledger.git","svn_url":"https://github.com/lumberj/five-bells-ledger","homepage":null,"size":632,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"interledger:master","ref":"master","sha":"c8b943705164b5fbb21462deac40ea14456bc228","user":{"login":"interledger","id":14062960,"avatar_url":"https://avatars.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"repo":{"id":30608771,"name":"five-bells-ledger","full_name":"interledger/five-bells-ledger","owner":{"login":"interledger","id":14062960,"avatar_url":"https://avatars.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interledger/five-bells-ledger","description":"An implementation of the Five Bells ledger interface.","fork":false,"url":"https://api.github.com/repos/interledger/five-bells-ledger","forks_url":"https://api.github.com/repos/interledger/five-bells-ledger/forks","keys_url":"https://api.github.com/repos/interledger/five-bells-ledger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interledger/five-bells-ledger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interledger/five-bells-ledger/teams","hooks_url":"https://api.github.com/repos/interledger/five-bells-ledger/hooks","issue_events_url":"https://api.github.com/repos/interledger/five-bells-ledger/issues/events{/number}","events_url":"https://api.github.com/repos/interledger/five-bells-ledger/events","assignees_url":"https://api.github.com/repos/interledger/five-bells-ledger/assignees{/user}","branches_url":"https://api.github.com/repos/interledger/five-bells-ledger/branches{/branch}","tags_url":"https://api.github.com/repos/interledger/five-bells-ledger/tags","blobs_url":"https://api.github.com/repos/interledger/five-bells-ledger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interledger/five-bells-ledger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interledger/five-bells-ledger/git/refs{/sha}","trees_url":"https://api.github.com/repos/interledger/five-bells-ledger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interledger/five-bells-ledger/statuses/{sha}","languages_url":"https://api.github.com/repos/interledger/five-bells-ledger/languages","stargazers_url":"https://api.github.com/repos/interledger/five-bells-ledger/stargazers","contributors_url":"https://api.github.com/repos/interledger/five-bells-ledger/contributors","subscribers_url":"https://api.github.com/repos/interledger/five-bells-ledger/subscribers","subscription_url":"https://api.github.com/repos/interledger/five-bells-ledger/subscription","commits_url":"https://api.github.com/repos/interledger/five-bells-ledger/commits{/sha}","git_commits_url":"https://api.github.com/repos/interledger/five-bells-ledger/git/commits{/sha}","comments_url":"https://api.github.com/repos/interledger/five-bells-ledger/comments{/number}","issue_comment_url":"https://api.github.com/repos/interledger/five-bells-ledger/issues/comments{/number}","contents_url":"https://api.github.com/repos/interledger/five-bells-ledger/contents/{+path}","compare_url":"https://api.github.com/repos/interledger/five-bells-ledger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interledger/five-bells-ledger/merges","archive_url":"https://api.github.com/repos/interledger/five-bells-ledger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interledger/five-bells-ledger/downloads","issues_url":"https://api.github.com/repos/interledger/five-bells-ledger/issues{/number}","pulls_url":"https://api.github.com/repos/interledger/five-bells-ledger/pulls{/number}","milestones_url":"https://api.github.com/repos/interledger/five-bells-ledger/milestones{/number}","notifications_url":"https://api.github.com/repos/interledger/five-bells-ledger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interledger/five-bells-ledger/labels{/name}","releases_url":"https://api.github.com/repos/interledger/five-bells-ledger/releases{/id}","deployments_url":"https://api.github.com/repos/interledger/five-bells-ledger/deployments","created_at":"2015-02-10T18:59:20Z","updated_at":"2016-01-25T22:20:18Z","pushed_at":"2016-01-26T23:09:04Z","git_url":"git://github.com/interledger/five-bells-ledger.git","ssh_url":"git@github.com:interledger/five-bells-ledger.git","clone_url":"https://github.com/interledger/five-bells-ledger.git","svn_url":"https://github.com/interledger/five-bells-ledger","homepage":null,"size":653,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":16,"forks":6,"open_issues":16,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/125"},"html":{"href":"https://github.com/interledger/five-bells-ledger/pull/125"},"issue":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/issues/125"},"comments":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/issues/125/comments"},"review_comments":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/125/comments"},"review_comment":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/pulls/125/commits"},"statuses":{"href":"https://api.github.com/repos/interledger/five-bells-ledger/statuses/5a9e9cd0fa7311c43be72c15d532d0fb1f2c46ed"}}}}