{"action":"created","issue":{"url":"https://api.github.com/repos/apache/flink/issues/2572","repository_url":"https://api.github.com/repos/apache/flink","labels_url":"https://api.github.com/repos/apache/flink/issues/2572/labels{/name}","comments_url":"https://api.github.com/repos/apache/flink/issues/2572/comments","events_url":"https://api.github.com/repos/apache/flink/issues/2572/events","html_url":"https://github.com/apache/flink/pull/2572","id":180088405,"number":2572,"title":"[FLINK-4552] Refactor WindowOperator/Trigger Tests","user":{"login":"aljoscha","id":68551,"avatar_url":"https://avatars.githubusercontent.com/u/68551?v=3","gravatar_id":"","url":"https://api.github.com/users/aljoscha","html_url":"https://github.com/aljoscha","followers_url":"https://api.github.com/users/aljoscha/followers","following_url":"https://api.github.com/users/aljoscha/following{/other_user}","gists_url":"https://api.github.com/users/aljoscha/gists{/gist_id}","starred_url":"https://api.github.com/users/aljoscha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljoscha/subscriptions","organizations_url":"https://api.github.com/users/aljoscha/orgs","repos_url":"https://api.github.com/users/aljoscha/repos","events_url":"https://api.github.com/users/aljoscha/events{/privacy}","received_events_url":"https://api.github.com/users/aljoscha/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-29T15:51:47Z","updated_at":"2016-10-28T09:44:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/2572","html_url":"https://github.com/apache/flink/pull/2572","diff_url":"https://github.com/apache/flink/pull/2572.diff","patch_url":"https://github.com/apache/flink/pull/2572.patch"},"body":"This builds on #2570 \r\n\r\nBefore, tests for WindowOperator, WindowAssigner, Trigger and WindowFunction\r\nwere all conflated in WindowOperatorTest. All of these tested that a\r\ncertain combination of a Trigger, WindowAssigner and WindowFunction produce\r\nthe expected output.\r\n\r\nThis change modularizes these tests and spreads them out across multiple\r\nfiles. For example, one per trigger/window assigner.\r\n\r\nThe new WindowOperatorTest tests verify that the interaction between\r\nWindowOperator and the various other parts works as expected, that the\r\ncorrect methods on Trigger and WindowFunction are called at the expected\r\ntime and that snapshotting, timers, cleanup etc. work correctly. These tests\r\nalso verify that the different state types and WindowFunctions work correctly.\r\n\r\nFor trigger tests this introduces TriggerTestHarness. This can be used\r\nto inject elements into Triggers they fire at the correct times. The\r\nactual output of the WindowFunction is not important for these tests.\r\nThe new tests also make sure that triggers correctly clean up state and timers.\r\n\r\nWindowAssigner tests verify the behaviour of window assigners in isolation.\r\nThey also test, for example, whether offset parameter of time-based windows\r\nwork correctly.\r\n\r\nR: @StephanEwen @StefanRRichter @kl0u for review"},"comment":{"url":"https://api.github.com/repos/apache/flink/issues/comments/256879938","html_url":"https://github.com/apache/flink/pull/2572#issuecomment-256879938","issue_url":"https://api.github.com/repos/apache/flink/issues/2572","id":256879938,"user":{"login":"aljoscha","id":68551,"avatar_url":"https://avatars.githubusercontent.com/u/68551?v=3","gravatar_id":"","url":"https://api.github.com/users/aljoscha","html_url":"https://github.com/aljoscha","followers_url":"https://api.github.com/users/aljoscha/followers","following_url":"https://api.github.com/users/aljoscha/following{/other_user}","gists_url":"https://api.github.com/users/aljoscha/gists{/gist_id}","starred_url":"https://api.github.com/users/aljoscha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljoscha/subscriptions","organizations_url":"https://api.github.com/users/aljoscha/orgs","repos_url":"https://api.github.com/users/aljoscha/repos","events_url":"https://api.github.com/users/aljoscha/events{/privacy}","received_events_url":"https://api.github.com/users/aljoscha/received_events","type":"User","site_admin":false},"created_at":"2016-10-28T09:44:17Z","updated_at":"2016-10-28T09:44:17Z","body":"Thanks for your review, @StefanRRichter! You found some areas where this can be improved.\r\n\r\nI'm not yet sure whether parameterisation for processing-time/event-time can be done without obscuring what the test actually does to much but I'll try and come up with something."}}
{"actor":{"display_login":"aljoscha"}}