{"action":"closed","number":8626,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/8626","id":85673357,"html_url":"https://github.com/nodejs/node/pull/8626","diff_url":"https://github.com/nodejs/node/pull/8626.diff","patch_url":"https://github.com/nodejs/node/pull/8626.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/8626","number":8626,"state":"closed","locked":false,"title":"udp/stream: use MaybeStackBuffers to manage buffer memory management","user":{"login":"pkiddie","id":153413,"avatar_url":"https://avatars.githubusercontent.com/u/153413?v=3","gravatar_id":"","url":"https://api.github.com/users/pkiddie","html_url":"https://github.com/pkiddie","followers_url":"https://api.github.com/users/pkiddie/followers","following_url":"https://api.github.com/users/pkiddie/following{/other_user}","gists_url":"https://api.github.com/users/pkiddie/gists{/gist_id}","starred_url":"https://api.github.com/users/pkiddie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkiddie/subscriptions","organizations_url":"https://api.github.com/users/pkiddie/orgs","repos_url":"https://api.github.com/users/pkiddie/repos","events_url":"https://api.github.com/users/pkiddie/events{/privacy}","received_events_url":"https://api.github.com/users/pkiddie/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n`udp`\r\n`stream`\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\nThe `uv_buf_t bufs_[16]` lines could be `MaybeStackBuffer`s; as https://github.com/nodejs/code-and-learn/issues/56","created_at":"2016-09-17T12:37:11Z","updated_at":"2016-09-20T17:03:39Z","closed_at":"2016-09-20T17:03:39Z","merged_at":null,"merge_commit_sha":"dc9a0b38f14b9c0da68cd524a8ca6babd4cf82b8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/8626/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/8626/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/8626/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/535ebac285fda0e557d7d3aa4241a45534b0e880","head":{"label":"pkiddie:use_maybestackbuffers","ref":"use_maybestackbuffers","sha":"535ebac285fda0e557d7d3aa4241a45534b0e880","user":{"login":"pkiddie","id":153413,"avatar_url":"https://avatars.githubusercontent.com/u/153413?v=3","gravatar_id":"","url":"https://api.github.com/users/pkiddie","html_url":"https://github.com/pkiddie","followers_url":"https://api.github.com/users/pkiddie/followers","following_url":"https://api.github.com/users/pkiddie/following{/other_user}","gists_url":"https://api.github.com/users/pkiddie/gists{/gist_id}","starred_url":"https://api.github.com/users/pkiddie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkiddie/subscriptions","organizations_url":"https://api.github.com/users/pkiddie/orgs","repos_url":"https://api.github.com/users/pkiddie/repos","events_url":"https://api.github.com/users/pkiddie/events{/privacy}","received_events_url":"https://api.github.com/users/pkiddie/received_events","type":"User","site_admin":false},"repo":{"id":68438275,"name":"node","full_name":"pkiddie/node","owner":{"login":"pkiddie","id":153413,"avatar_url":"https://avatars.githubusercontent.com/u/153413?v=3","gravatar_id":"","url":"https://api.github.com/users/pkiddie","html_url":"https://github.com/pkiddie","followers_url":"https://api.github.com/users/pkiddie/followers","following_url":"https://api.github.com/users/pkiddie/following{/other_user}","gists_url":"https://api.github.com/users/pkiddie/gists{/gist_id}","starred_url":"https://api.github.com/users/pkiddie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkiddie/subscriptions","organizations_url":"https://api.github.com/users/pkiddie/orgs","repos_url":"https://api.github.com/users/pkiddie/repos","events_url":"https://api.github.com/users/pkiddie/events{/privacy}","received_events_url":"https://api.github.com/users/pkiddie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pkiddie/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/pkiddie/node","forks_url":"https://api.github.com/repos/pkiddie/node/forks","keys_url":"https://api.github.com/repos/pkiddie/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkiddie/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkiddie/node/teams","hooks_url":"https://api.github.com/repos/pkiddie/node/hooks","issue_events_url":"https://api.github.com/repos/pkiddie/node/issues/events{/number}","events_url":"https://api.github.com/repos/pkiddie/node/events","assignees_url":"https://api.github.com/repos/pkiddie/node/assignees{/user}","branches_url":"https://api.github.com/repos/pkiddie/node/branches{/branch}","tags_url":"https://api.github.com/repos/pkiddie/node/tags","blobs_url":"https://api.github.com/repos/pkiddie/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkiddie/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkiddie/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkiddie/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkiddie/node/statuses/{sha}","languages_url":"https://api.github.com/repos/pkiddie/node/languages","stargazers_url":"https://api.github.com/repos/pkiddie/node/stargazers","contributors_url":"https://api.github.com/repos/pkiddie/node/contributors","subscribers_url":"https://api.github.com/repos/pkiddie/node/subscribers","subscription_url":"https://api.github.com/repos/pkiddie/node/subscription","commits_url":"https://api.github.com/repos/pkiddie/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkiddie/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkiddie/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkiddie/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkiddie/node/contents/{+path}","compare_url":"https://api.github.com/repos/pkiddie/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkiddie/node/merges","archive_url":"https://api.github.com/repos/pkiddie/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkiddie/node/downloads","issues_url":"https://api.github.com/repos/pkiddie/node/issues{/number}","pulls_url":"https://api.github.com/repos/pkiddie/node/pulls{/number}","milestones_url":"https://api.github.com/repos/pkiddie/node/milestones{/number}","notifications_url":"https://api.github.com/repos/pkiddie/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkiddie/node/labels{/name}","releases_url":"https://api.github.com/repos/pkiddie/node/releases{/id}","deployments_url":"https://api.github.com/repos/pkiddie/node/deployments","created_at":"2016-09-17T07:27:22Z","updated_at":"2016-09-17T07:27:42Z","pushed_at":"2016-09-17T17:03:37Z","git_url":"git://github.com/pkiddie/node.git","ssh_url":"git@github.com:pkiddie/node.git","clone_url":"https://github.com/pkiddie/node.git","svn_url":"https://github.com/pkiddie/node","homepage":"https://nodejs.org","size":227290,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"c1e47ed8c883afba3c240e89d763a28a57ec1373","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-09-20T16:37:35Z","pushed_at":"2016-09-20T17:02:41Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":300726,"stargazers_count":26865,"watchers_count":26865,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4318,"mirror_url":null,"open_issues_count":830,"forks":4318,"open_issues":830,"watchers":26865,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/8626"},"html":{"href":"https://github.com/nodejs/node/pull/8626"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/8626"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/8626/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/8626/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/8626/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/535ebac285fda0e557d7d3aa4241a45534b0e880"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":5,"review_comments":5,"commits":3,"additions":4,"deletions":22,"changed_files":2}}
{"actor":{"display_login":"addaleax"}}