{"action":"opened","number":116,"pull_request":{"url":"https://api.github.com/repos/feathersjs/generator-feathers/pulls/116","id":66744575,"html_url":"https://github.com/feathersjs/generator-feathers/pull/116","diff_url":"https://github.com/feathersjs/generator-feathers/pull/116.diff","patch_url":"https://github.com/feathersjs/generator-feathers/pull/116.patch","issue_url":"https://api.github.com/repos/feathersjs/generator-feathers/issues/116","number":116,"state":"open","locked":false,"title":"Pass fewer arrow functions to Mocha. feathersjs/feathers#297","user":{"login":"wkw","id":1691220,"avatar_url":"https://avatars.githubusercontent.com/u/1691220?v=3","gravatar_id":"","url":"https://api.github.com/users/wkw","html_url":"https://github.com/wkw","followers_url":"https://api.github.com/users/wkw/followers","following_url":"https://api.github.com/users/wkw/following{/other_user}","gists_url":"https://api.github.com/users/wkw/gists{/gist_id}","starred_url":"https://api.github.com/users/wkw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkw/subscriptions","organizations_url":"https://api.github.com/users/wkw/orgs","repos_url":"https://api.github.com/users/wkw/repos","events_url":"https://api.github.com/users/wkw/events{/privacy}","received_events_url":"https://api.github.com/users/wkw/received_events","type":"User","site_admin":false},"body":"This PR addresses an issue I had trying to increase the timeout of a test, which wouldn't work due to the generated test passing arrow functions to mocha. From mocha docs:\r\n\r\n>Passing arrow functions to Mocha is discouraged. Their lexical binding of the this value makes them unable to access the Mocha context, and statements like this.timeout(1000); will not work inside an arrow function.\r\n\r\n[https://mochajs.org/#arrow-functions](https://mochajs.org/#arrow-functions).\r\n\r\nI did not replace every arrow function in the test templates, as some of them seemed like they would never cause any issues. Also added notes to the README describing how to make changes to and test the generators via `npm link` (many people will likely already know this, I did not.)\r\n","created_at":"2016-04-16T17:39:15Z","updated_at":"2016-04-16T17:39:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/feathersjs/generator-feathers/pulls/116/commits","review_comments_url":"https://api.github.com/repos/feathersjs/generator-feathers/pulls/116/comments","review_comment_url":"https://api.github.com/repos/feathersjs/generator-feathers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/feathersjs/generator-feathers/issues/116/comments","statuses_url":"https://api.github.com/repos/feathersjs/generator-feathers/statuses/e778c5f01df049ee3479c3b99c51a9164ced3a8c","head":{"label":"wkw:mocha-fewer-arrow-funcs","ref":"mocha-fewer-arrow-funcs","sha":"e778c5f01df049ee3479c3b99c51a9164ced3a8c","user":{"login":"wkw","id":1691220,"avatar_url":"https://avatars.githubusercontent.com/u/1691220?v=3","gravatar_id":"","url":"https://api.github.com/users/wkw","html_url":"https://github.com/wkw","followers_url":"https://api.github.com/users/wkw/followers","following_url":"https://api.github.com/users/wkw/following{/other_user}","gists_url":"https://api.github.com/users/wkw/gists{/gist_id}","starred_url":"https://api.github.com/users/wkw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkw/subscriptions","organizations_url":"https://api.github.com/users/wkw/orgs","repos_url":"https://api.github.com/users/wkw/repos","events_url":"https://api.github.com/users/wkw/events{/privacy}","received_events_url":"https://api.github.com/users/wkw/received_events","type":"User","site_admin":false},"repo":{"id":56074957,"name":"generator-feathers","full_name":"wkw/generator-feathers","owner":{"login":"wkw","id":1691220,"avatar_url":"https://avatars.githubusercontent.com/u/1691220?v=3","gravatar_id":"","url":"https://api.github.com/users/wkw","html_url":"https://github.com/wkw","followers_url":"https://api.github.com/users/wkw/followers","following_url":"https://api.github.com/users/wkw/following{/other_user}","gists_url":"https://api.github.com/users/wkw/gists{/gist_id}","starred_url":"https://api.github.com/users/wkw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkw/subscriptions","organizations_url":"https://api.github.com/users/wkw/orgs","repos_url":"https://api.github.com/users/wkw/repos","events_url":"https://api.github.com/users/wkw/events{/privacy}","received_events_url":"https://api.github.com/users/wkw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wkw/generator-feathers","description":"A Yeoman generator for a Feathers application","fork":true,"url":"https://api.github.com/repos/wkw/generator-feathers","forks_url":"https://api.github.com/repos/wkw/generator-feathers/forks","keys_url":"https://api.github.com/repos/wkw/generator-feathers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wkw/generator-feathers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wkw/generator-feathers/teams","hooks_url":"https://api.github.com/repos/wkw/generator-feathers/hooks","issue_events_url":"https://api.github.com/repos/wkw/generator-feathers/issues/events{/number}","events_url":"https://api.github.com/repos/wkw/generator-feathers/events","assignees_url":"https://api.github.com/repos/wkw/generator-feathers/assignees{/user}","branches_url":"https://api.github.com/repos/wkw/generator-feathers/branches{/branch}","tags_url":"https://api.github.com/repos/wkw/generator-feathers/tags","blobs_url":"https://api.github.com/repos/wkw/generator-feathers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wkw/generator-feathers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wkw/generator-feathers/git/refs{/sha}","trees_url":"https://api.github.com/repos/wkw/generator-feathers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wkw/generator-feathers/statuses/{sha}","languages_url":"https://api.github.com/repos/wkw/generator-feathers/languages","stargazers_url":"https://api.github.com/repos/wkw/generator-feathers/stargazers","contributors_url":"https://api.github.com/repos/wkw/generator-feathers/contributors","subscribers_url":"https://api.github.com/repos/wkw/generator-feathers/subscribers","subscription_url":"https://api.github.com/repos/wkw/generator-feathers/subscription","commits_url":"https://api.github.com/repos/wkw/generator-feathers/commits{/sha}","git_commits_url":"https://api.github.com/repos/wkw/generator-feathers/git/commits{/sha}","comments_url":"https://api.github.com/repos/wkw/generator-feathers/comments{/number}","issue_comment_url":"https://api.github.com/repos/wkw/generator-feathers/issues/comments{/number}","contents_url":"https://api.github.com/repos/wkw/generator-feathers/contents/{+path}","compare_url":"https://api.github.com/repos/wkw/generator-feathers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wkw/generator-feathers/merges","archive_url":"https://api.github.com/repos/wkw/generator-feathers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wkw/generator-feathers/downloads","issues_url":"https://api.github.com/repos/wkw/generator-feathers/issues{/number}","pulls_url":"https://api.github.com/repos/wkw/generator-feathers/pulls{/number}","milestones_url":"https://api.github.com/repos/wkw/generator-feathers/milestones{/number}","notifications_url":"https://api.github.com/repos/wkw/generator-feathers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wkw/generator-feathers/labels{/name}","releases_url":"https://api.github.com/repos/wkw/generator-feathers/releases{/id}","deployments_url":"https://api.github.com/repos/wkw/generator-feathers/deployments","created_at":"2016-04-12T15:24:09Z","updated_at":"2016-04-12T15:24:10Z","pushed_at":"2016-04-16T17:33:34Z","git_url":"git://github.com/wkw/generator-feathers.git","ssh_url":"git@github.com:wkw/generator-feathers.git","clone_url":"https://github.com/wkw/generator-feathers.git","svn_url":"https://github.com/wkw/generator-feathers","homepage":null,"size":208,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"feathersjs:master","ref":"master","sha":"6e27eb8c6b0bcef197f1fcc235c937d9fc8252d6","user":{"login":"feathersjs","id":5321853,"avatar_url":"https://avatars.githubusercontent.com/u/5321853?v=3","gravatar_id":"","url":"https://api.github.com/users/feathersjs","html_url":"https://github.com/feathersjs","followers_url":"https://api.github.com/users/feathersjs/followers","following_url":"https://api.github.com/users/feathersjs/following{/other_user}","gists_url":"https://api.github.com/users/feathersjs/gists{/gist_id}","starred_url":"https://api.github.com/users/feathersjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feathersjs/subscriptions","organizations_url":"https://api.github.com/users/feathersjs/orgs","repos_url":"https://api.github.com/users/feathersjs/repos","events_url":"https://api.github.com/users/feathersjs/events{/privacy}","received_events_url":"https://api.github.com/users/feathersjs/received_events","type":"Organization","site_admin":false},"repo":{"id":44891313,"name":"generator-feathers","full_name":"feathersjs/generator-feathers","owner":{"login":"feathersjs","id":5321853,"avatar_url":"https://avatars.githubusercontent.com/u/5321853?v=3","gravatar_id":"","url":"https://api.github.com/users/feathersjs","html_url":"https://github.com/feathersjs","followers_url":"https://api.github.com/users/feathersjs/followers","following_url":"https://api.github.com/users/feathersjs/following{/other_user}","gists_url":"https://api.github.com/users/feathersjs/gists{/gist_id}","starred_url":"https://api.github.com/users/feathersjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feathersjs/subscriptions","organizations_url":"https://api.github.com/users/feathersjs/orgs","repos_url":"https://api.github.com/users/feathersjs/repos","events_url":"https://api.github.com/users/feathersjs/events{/privacy}","received_events_url":"https://api.github.com/users/feathersjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/feathersjs/generator-feathers","description":"A Yeoman generator for a Feathers application","fork":false,"url":"https://api.github.com/repos/feathersjs/generator-feathers","forks_url":"https://api.github.com/repos/feathersjs/generator-feathers/forks","keys_url":"https://api.github.com/repos/feathersjs/generator-feathers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feathersjs/generator-feathers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feathersjs/generator-feathers/teams","hooks_url":"https://api.github.com/repos/feathersjs/generator-feathers/hooks","issue_events_url":"https://api.github.com/repos/feathersjs/generator-feathers/issues/events{/number}","events_url":"https://api.github.com/repos/feathersjs/generator-feathers/events","assignees_url":"https://api.github.com/repos/feathersjs/generator-feathers/assignees{/user}","branches_url":"https://api.github.com/repos/feathersjs/generator-feathers/branches{/branch}","tags_url":"https://api.github.com/repos/feathersjs/generator-feathers/tags","blobs_url":"https://api.github.com/repos/feathersjs/generator-feathers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feathersjs/generator-feathers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feathersjs/generator-feathers/git/refs{/sha}","trees_url":"https://api.github.com/repos/feathersjs/generator-feathers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feathersjs/generator-feathers/statuses/{sha}","languages_url":"https://api.github.com/repos/feathersjs/generator-feathers/languages","stargazers_url":"https://api.github.com/repos/feathersjs/generator-feathers/stargazers","contributors_url":"https://api.github.com/repos/feathersjs/generator-feathers/contributors","subscribers_url":"https://api.github.com/repos/feathersjs/generator-feathers/subscribers","subscription_url":"https://api.github.com/repos/feathersjs/generator-feathers/subscription","commits_url":"https://api.github.com/repos/feathersjs/generator-feathers/commits{/sha}","git_commits_url":"https://api.github.com/repos/feathersjs/generator-feathers/git/commits{/sha}","comments_url":"https://api.github.com/repos/feathersjs/generator-feathers/comments{/number}","issue_comment_url":"https://api.github.com/repos/feathersjs/generator-feathers/issues/comments{/number}","contents_url":"https://api.github.com/repos/feathersjs/generator-feathers/contents/{+path}","compare_url":"https://api.github.com/repos/feathersjs/generator-feathers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feathersjs/generator-feathers/merges","archive_url":"https://api.github.com/repos/feathersjs/generator-feathers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feathersjs/generator-feathers/downloads","issues_url":"https://api.github.com/repos/feathersjs/generator-feathers/issues{/number}","pulls_url":"https://api.github.com/repos/feathersjs/generator-feathers/pulls{/number}","milestones_url":"https://api.github.com/repos/feathersjs/generator-feathers/milestones{/number}","notifications_url":"https://api.github.com/repos/feathersjs/generator-feathers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feathersjs/generator-feathers/labels{/name}","releases_url":"https://api.github.com/repos/feathersjs/generator-feathers/releases{/id}","deployments_url":"https://api.github.com/repos/feathersjs/generator-feathers/deployments","created_at":"2015-10-25T01:02:54Z","updated_at":"2016-04-15T10:04:18Z","pushed_at":"2016-04-15T03:16:04Z","git_url":"git://github.com/feathersjs/generator-feathers.git","ssh_url":"git@github.com:feathersjs/generator-feathers.git","clone_url":"https://github.com/feathersjs/generator-feathers.git","svn_url":"https://github.com/feathersjs/generator-feathers","homepage":null,"size":215,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":13,"forks":17,"open_issues":13,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/feathersjs/generator-feathers/pulls/116"},"html":{"href":"https://github.com/feathersjs/generator-feathers/pull/116"},"issue":{"href":"https://api.github.com/repos/feathersjs/generator-feathers/issues/116"},"comments":{"href":"https://api.github.com/repos/feathersjs/generator-feathers/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/feathersjs/generator-feathers/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/feathersjs/generator-feathers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/feathersjs/generator-feathers/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/feathersjs/generator-feathers/statuses/e778c5f01df049ee3479c3b99c51a9164ced3a8c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":29,"deletions":19,"changed_files":5}}