{"action":"created","issue":{"url":"https://api.github.com/repos/danielgindi/Charts/issues/1291","repository_url":"https://api.github.com/repos/danielgindi/Charts","labels_url":"https://api.github.com/repos/danielgindi/Charts/issues/1291/labels{/name}","comments_url":"https://api.github.com/repos/danielgindi/Charts/issues/1291/comments","events_url":"https://api.github.com/repos/danielgindi/Charts/issues/1291/events","html_url":"https://github.com/danielgindi/Charts/issues/1291","id":169507854,"number":1291,"title":"Swift 2.3 & 3.0 support: news, issues, PRs and state","user":{"login":"liuxuan30","id":4375169,"avatar_url":"https://avatars.githubusercontent.com/u/4375169?v=3","gravatar_id":"","url":"https://api.github.com/users/liuxuan30","html_url":"https://github.com/liuxuan30","followers_url":"https://api.github.com/users/liuxuan30/followers","following_url":"https://api.github.com/users/liuxuan30/following{/other_user}","gists_url":"https://api.github.com/users/liuxuan30/gists{/gist_id}","starred_url":"https://api.github.com/users/liuxuan30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liuxuan30/subscriptions","organizations_url":"https://api.github.com/users/liuxuan30/orgs","repos_url":"https://api.github.com/users/liuxuan30/repos","events_url":"https://api.github.com/users/liuxuan30/events{/privacy}","received_events_url":"https://api.github.com/users/liuxuan30/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/danielgindi/Charts/labels/a%20work%20in%20progress","name":"a work in progress","color":"fad8c7"},{"url":"https://api.github.com/repos/danielgindi/Charts/labels/discussion","name":"discussion","color":"2d9e11"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":39,"created_at":"2016-08-05T01:06:27Z","updated_at":"2016-09-18T09:36:21Z","closed_at":null,"body":"Using this thread to list the current news, issues, PRs, and state for swift 3.0 support. This post will be updated accordingly.\r\n\r\nAs Xcode beta 4 comes out, there are even more changes(#1290), seems it's much easier to convert the library after swift 3.0 released once and for all, than continuous merging from beta 1 to beta N and finally merge into master.\r\n\r\nXcode beta 6 has even more changes based on beta 4.. But thanks to @acegreen, we now on beta 6 now.\r\n\r\nTherefore, I am thinking the current Swift 2.3 and 3.0 branches are just for everyone to test their apps with iOS 10 beta. Thanks for everyone who commits into 2.3 and 3.0 branch.\r\n\r\n## What branch to use?\r\nSwift 2.3 + Charts 2.2.5 -> Chart2.2.5-Swift2.3 branch\r\nSwift 3.0 + Charts 2.2.5 -> Swift-3.0 branch\r\nSwift 2.3 + Charts 3.0 feature ready -> Swift-2.3 branch\r\nSwift 3.0 + Charts 3.0 feature ready -> *Wait until it's finished*\r\n\r\n## Progress\r\nSwift-3.0 branch is based on Charts 2.2.5; has some fixes for OS X demo on Xcode 8 GM\r\nSwift-2.3 branch is sync with master(Chart v3.0 feature ready) 5e020a8f8489a8c71c2387f3334aab5fb64f2fe3 for iOS 10/macOS + Charts 3.0 on Xcode beta 6, works fine on Xcode 8 GM\r\nChart2.2.5-Swift2.3 branch is based on Chart 2.2.5 release and converted to Swift 2.3 on Xcode beta 6 works fine on Xcode 8 GM\r\n\r\n## Open issues  (up to Xcode 8 GM):\r\n#1421 linear line chart has additional line segments wile zooming in (PR #1420)\r\n\r\n#1269: Realm swift 3.0 support is blocked due to Xcode 8 beta 3 & 4 swift compiler bug \r\nThis seems a compiler bug pending to fix. Anyone relies one Realm have to wait until this bug has been fixed. Please use Swift 2.3 to test iOS 10. Now, the code is ready (PR #1414), but pending a swift 3 Realm framework to test.\r\n\r\n#1171: I found this PR removed `isDrawValuesEnabled` and other similar protocol methods prefixed with 'is', that's why #1295 is removing 'is' from the function name... Watch out\r\n\r\n### function inconsistency:\r\nSeeing different signatures for same API on macOS and iOS, such as:\r\n>NSFont:\r\nclass func systemFontSize()\r\nUIFont:\r\nclass var systemFontSize: CGFloat { get }\r\n\r\nNSParagraphStyle\r\n>NSParagraphStyle:\r\non macOS, it's:\r\nclass func default() -> NSParagraphStyle\r\non iOS, it's:\r\nclass var default: NSParagraphStyle { get }\r\n\r\nI have filed a bug 27731357 on radar. If they intended to do so, we have to wrap it.. again\r\n\r\n## Pull requests:\r\n### Swift 3.0\r\n#1414 is merged for Realm extension issue, still need Realm to release Swift 3.0 branch to make the framework compile.\r\n#1378 is merged for migrating `public` to `open` ([SE-1107](https://github.com/apple/swift-evolution/blob/master/proposals/0117-non-public-subclassable-by-default.md))\r\n#1342 is meged for Xcode beta 6\r\n#1294, #1295 is merged for Xcode beta 4, including project settings, ChartsRealm, ChartsDemo\r\n> If you remove all Realm related files and code, you should be able to launch ChartsDemo with Xcode beta 4 now.\r\n\r\n#1290 is merged for Xcode beta 4\r\n#1266 is merged via #1296 due to conflicts (RunLoopMode changes)\r\n### Swift 2.3\r\n#1389 is merged for Xcode beta 6 + Charts v3.0 code in master, at 5e020a8f8489a8c71c2387f3334aab5fb64f2fe3\r\n#1281 is merged for Xcode beta 4\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/danielgindi/Charts/issues/comments/247837515","html_url":"https://github.com/danielgindi/Charts/issues/1291#issuecomment-247837515","issue_url":"https://api.github.com/repos/danielgindi/Charts/issues/1291","id":247837515,"user":{"login":"danielgindi","id":366926,"avatar_url":"https://avatars.githubusercontent.com/u/366926?v=3","gravatar_id":"","url":"https://api.github.com/users/danielgindi","html_url":"https://github.com/danielgindi","followers_url":"https://api.github.com/users/danielgindi/followers","following_url":"https://api.github.com/users/danielgindi/following{/other_user}","gists_url":"https://api.github.com/users/danielgindi/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgindi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgindi/subscriptions","organizations_url":"https://api.github.com/users/danielgindi/orgs","repos_url":"https://api.github.com/users/danielgindi/repos","events_url":"https://api.github.com/users/danielgindi/events{/privacy}","received_events_url":"https://api.github.com/users/danielgindi/received_events","type":"User","site_admin":false},"created_at":"2016-09-18T09:36:21Z","updated_at":"2016-09-18T09:36:21Z","body":"Did you take a look at `master`? That's after correctly converting everything to Swift 3.0 :-)\r\nDidn't see any bugs resulting from the conversion - but will be happy to hear your feedback!"}}
{"actor":{"display_login":"danielgindi"}}