{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1953","repository_url":"https://api.github.com/repos/Microsoft/visualfsharp","labels_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1953/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1953/comments","events_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1953/events","html_url":"https://github.com/Microsoft/visualfsharp/issues/1953","id":193876089,"number":1953,"title":"Move sigdata and optdata into FSharp.Core","user":{"login":"praeclarum","id":323548,"avatar_url":"https://avatars.githubusercontent.com/u/323548?v=3","gravatar_id":"","url":"https://api.github.com/users/praeclarum","html_url":"https://github.com/praeclarum","followers_url":"https://api.github.com/users/praeclarum/followers","following_url":"https://api.github.com/users/praeclarum/following{/other_user}","gists_url":"https://api.github.com/users/praeclarum/gists{/gist_id}","starred_url":"https://api.github.com/users/praeclarum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praeclarum/subscriptions","organizations_url":"https://api.github.com/users/praeclarum/orgs","repos_url":"https://api.github.com/users/praeclarum/repos","events_url":"https://api.github.com/users/praeclarum/events{/privacy}","received_events_url":"https://api.github.com/users/praeclarum/received_events","type":"User","site_admin":false},"labels":[{"id":165684213,"url":"https://api.github.com/repos/Microsoft/visualfsharp/labels/discussion","name":"discussion","color":"fbca04","default":false},{"id":167832407,"url":"https://api.github.com/repos/Microsoft/visualfsharp/labels/Feature%20Request","name":"Feature Request","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-12-06T20:31:00Z","updated_at":"2016-12-06T23:17:00Z","closed_at":null,"body":"Currently, `FSharp.Core`'s sigdata and optdata are not stored in `FSharp.Core`. Instead they are put in parallel files to core.\r\n\r\nI would like to suggest moving those files into `FSharp.Core.dll`.\r\n\r\n### Past Rationale\r\n\r\n> DLL size on small profile devices was the only justification. But old compilers require them separate\r\n> [@dsyme](https://twitter.com/dsyme/status/806229188818698240)\r\n\r\nCurrent file sizes on iOS are:\r\n\r\n    1526272 Dec  1 08:07 FSharp.Core.dll\r\n     326778 Dec  1 08:07 FSharp.Core.dll.mdb\r\n     429831 Dec  1 08:07 FSharp.Core.optdata\r\n     556780 Dec  1 08:07 FSharp.Core.sigdata\r\n     704019 Dec  1 08:07 FSharp.Core.xml\r\n\r\nThat puts this data around 1 MB in size.\r\n\r\n### Reason for Change\r\n\r\nTo make using FSharp.Core more reliable.\r\n\r\nCurrently we have to\r\n\r\n1. Remember to bring these two extra files along with the assembly\r\n2. Work to make sure we don't use the wrong metadata\r\n\r\nI don't believe the perceived benefit of smaller mobile apps outweighs the mistakes made when using FSharp.Core.\r\n\r\nThank you for considering this!\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/comments/265304449","html_url":"https://github.com/Microsoft/visualfsharp/issues/1953#issuecomment-265304449","issue_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1953","id":265304449,"user":{"login":"KevinRansom","id":5175830,"avatar_url":"https://avatars.githubusercontent.com/u/5175830?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinRansom","html_url":"https://github.com/KevinRansom","followers_url":"https://api.github.com/users/KevinRansom/followers","following_url":"https://api.github.com/users/KevinRansom/following{/other_user}","gists_url":"https://api.github.com/users/KevinRansom/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinRansom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinRansom/subscriptions","organizations_url":"https://api.github.com/users/KevinRansom/orgs","repos_url":"https://api.github.com/users/KevinRansom/repos","events_url":"https://api.github.com/users/KevinRansom/events{/privacy}","received_events_url":"https://api.github.com/users/KevinRansom/received_events","type":"User","site_admin":false},"created_at":"2016-12-06T23:17:00Z","updated_at":"2016-12-06T23:17:00Z","body":"@rojepp. \r\n\r\nI believe:\r\n  .optdata contains data that improves cross module inlining optimization scenarios and \r\n  .sigdata contains F# compiler specific metadata, descriptions of the types and functions that is lost by the compilation into dotnet assemblies.\r\n\r\n@7sharp9:\r\n  I guess deploying and loading into memory a 2.5 MB FSharp.Core.dll rather than a 1.5 MB FSharp.Core.dll is consider a waste of time and memory, when they are only useful in compilation scenarios.  But they don't have to be external ... they just are .... for the reasons already enumerated.\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"KevinRansom"}}