{"action":"closed","number":15354,"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/15354","id":61685702,"html_url":"https://github.com/JuliaLang/julia/pull/15354","diff_url":"https://github.com/JuliaLang/julia/pull/15354.diff","patch_url":"https://github.com/JuliaLang/julia/pull/15354.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/15354","number":15354,"state":"closed","locked":false,"title":"Add tests for SubArrays in test/linalg/bunchkaufman.jl","user":{"login":"pkofod","id":8431156,"avatar_url":"https://avatars.githubusercontent.com/u/8431156?v=3","gravatar_id":"","url":"https://api.github.com/users/pkofod","html_url":"https://github.com/pkofod","followers_url":"https://api.github.com/users/pkofod/followers","following_url":"https://api.github.com/users/pkofod/following{/other_user}","gists_url":"https://api.github.com/users/pkofod/gists{/gist_id}","starred_url":"https://api.github.com/users/pkofod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkofod/subscriptions","organizations_url":"https://api.github.com/users/pkofod/orgs","repos_url":"https://api.github.com/users/pkofod/repos","events_url":"https://api.github.com/users/pkofod/events{/privacy}","received_events_url":"https://api.github.com/users/pkofod/received_events","type":"User","site_admin":false},"body":"- Added tests for `linalg/bunchkaufman.jl`. Found tiny dispatch bug, as `factorize` didn't dispatch properly for `SubArray`s (changed `Matrix` -> `StridedMatrix`).\r\n- Moved two matrix calculations in `svd.jl`.\r\n- Added tests for `givens.jl`. Again, at loop over `Array` and `SubArray`, here for the matrix `A`, and vector `x`. `SubArray`s seem to pass just fine.","created_at":"2016-03-04T09:21:05Z","updated_at":"2016-03-07T20:09:13Z","closed_at":"2016-03-07T20:09:13Z","merged_at":"2016-03-07T20:09:13Z","merge_commit_sha":"92506451d9ee247f1a9f5bf9af467121ef5e8e65","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/15354/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/15354/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/15354/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/fde21d363180a7c629b5492dba75e0e6235b3385","head":{"label":"pkofod:pkm/SubArrays","ref":"pkm/SubArrays","sha":"fde21d363180a7c629b5492dba75e0e6235b3385","user":{"login":"pkofod","id":8431156,"avatar_url":"https://avatars.githubusercontent.com/u/8431156?v=3","gravatar_id":"","url":"https://api.github.com/users/pkofod","html_url":"https://github.com/pkofod","followers_url":"https://api.github.com/users/pkofod/followers","following_url":"https://api.github.com/users/pkofod/following{/other_user}","gists_url":"https://api.github.com/users/pkofod/gists{/gist_id}","starred_url":"https://api.github.com/users/pkofod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkofod/subscriptions","organizations_url":"https://api.github.com/users/pkofod/orgs","repos_url":"https://api.github.com/users/pkofod/repos","events_url":"https://api.github.com/users/pkofod/events{/privacy}","received_events_url":"https://api.github.com/users/pkofod/received_events","type":"User","site_admin":false},"repo":{"id":52199877,"name":"julia","full_name":"pkofod/julia","owner":{"login":"pkofod","id":8431156,"avatar_url":"https://avatars.githubusercontent.com/u/8431156?v=3","gravatar_id":"","url":"https://api.github.com/users/pkofod","html_url":"https://github.com/pkofod","followers_url":"https://api.github.com/users/pkofod/followers","following_url":"https://api.github.com/users/pkofod/following{/other_user}","gists_url":"https://api.github.com/users/pkofod/gists{/gist_id}","starred_url":"https://api.github.com/users/pkofod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkofod/subscriptions","organizations_url":"https://api.github.com/users/pkofod/orgs","repos_url":"https://api.github.com/users/pkofod/repos","events_url":"https://api.github.com/users/pkofod/events{/privacy}","received_events_url":"https://api.github.com/users/pkofod/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pkofod/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/pkofod/julia","forks_url":"https://api.github.com/repos/pkofod/julia/forks","keys_url":"https://api.github.com/repos/pkofod/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkofod/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkofod/julia/teams","hooks_url":"https://api.github.com/repos/pkofod/julia/hooks","issue_events_url":"https://api.github.com/repos/pkofod/julia/issues/events{/number}","events_url":"https://api.github.com/repos/pkofod/julia/events","assignees_url":"https://api.github.com/repos/pkofod/julia/assignees{/user}","branches_url":"https://api.github.com/repos/pkofod/julia/branches{/branch}","tags_url":"https://api.github.com/repos/pkofod/julia/tags","blobs_url":"https://api.github.com/repos/pkofod/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkofod/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkofod/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkofod/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkofod/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/pkofod/julia/languages","stargazers_url":"https://api.github.com/repos/pkofod/julia/stargazers","contributors_url":"https://api.github.com/repos/pkofod/julia/contributors","subscribers_url":"https://api.github.com/repos/pkofod/julia/subscribers","subscription_url":"https://api.github.com/repos/pkofod/julia/subscription","commits_url":"https://api.github.com/repos/pkofod/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkofod/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkofod/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkofod/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkofod/julia/contents/{+path}","compare_url":"https://api.github.com/repos/pkofod/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkofod/julia/merges","archive_url":"https://api.github.com/repos/pkofod/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkofod/julia/downloads","issues_url":"https://api.github.com/repos/pkofod/julia/issues{/number}","pulls_url":"https://api.github.com/repos/pkofod/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/pkofod/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/pkofod/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkofod/julia/labels{/name}","releases_url":"https://api.github.com/repos/pkofod/julia/releases{/id}","deployments_url":"https://api.github.com/repos/pkofod/julia/deployments","created_at":"2016-02-21T09:43:57Z","updated_at":"2016-02-21T09:44:04Z","pushed_at":"2016-03-06T12:00:55Z","git_url":"git://github.com/pkofod/julia.git","ssh_url":"git@github.com:pkofod/julia.git","clone_url":"https://github.com/pkofod/julia.git","svn_url":"https://github.com/pkofod/julia","homepage":"http://julialang.org/","size":100046,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"8a7eac2a9046bd72ff2f649594b9d3fe97ca3d03","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2016-03-07T16:44:42Z","pushed_at":"2016-03-07T20:09:13Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":124018,"stargazers_count":6804,"watchers_count":6804,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1546,"mirror_url":null,"open_issues_count":1687,"forks":1546,"open_issues":1687,"watchers":6804,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/15354"},"html":{"href":"https://github.com/JuliaLang/julia/pull/15354"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/15354"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/15354/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/15354/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/15354/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/fde21d363180a7c629b5492dba75e0e6235b3385"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"andreasnoack","id":505001,"avatar_url":"https://avatars.githubusercontent.com/u/505001?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasnoack","html_url":"https://github.com/andreasnoack","followers_url":"https://api.github.com/users/andreasnoack/followers","following_url":"https://api.github.com/users/andreasnoack/following{/other_user}","gists_url":"https://api.github.com/users/andreasnoack/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasnoack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasnoack/subscriptions","organizations_url":"https://api.github.com/users/andreasnoack/orgs","repos_url":"https://api.github.com/users/andreasnoack/repos","events_url":"https://api.github.com/users/andreasnoack/events{/privacy}","received_events_url":"https://api.github.com/users/andreasnoack/received_events","type":"User","site_admin":false},"comments":11,"review_comments":3,"commits":3,"additions":116,"deletions":77,"changed_files":5}}