{"action":"created","issue":{"url":"https://api.github.com/repos/mconf/mconf-web/issues/862","repository_url":"https://api.github.com/repos/mconf/mconf-web","labels_url":"https://api.github.com/repos/mconf/mconf-web/issues/862/labels{/name}","comments_url":"https://api.github.com/repos/mconf/mconf-web/issues/862/comments","events_url":"https://api.github.com/repos/mconf/mconf-web/issues/862/events","html_url":"https://github.com/mconf/mconf-web/pull/862","id":157971968,"number":862,"title":"Fix how recent activities are created for meetings","user":{"login":"daronco","id":498566,"avatar_url":"https://avatars.githubusercontent.com/u/498566?v=3","gravatar_id":"","url":"https://api.github.com/users/daronco","html_url":"https://github.com/daronco","followers_url":"https://api.github.com/users/daronco/followers","following_url":"https://api.github.com/users/daronco/following{/other_user}","gists_url":"https://api.github.com/users/daronco/gists{/gist_id}","starred_url":"https://api.github.com/users/daronco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daronco/subscriptions","organizations_url":"https://api.github.com/users/daronco/orgs","repos_url":"https://api.github.com/users/daronco/repos","events_url":"https://api.github.com/users/daronco/events{/privacy}","received_events_url":"https://api.github.com/users/daronco/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-01T18:11:36Z","updated_at":"2016-06-01T20:19:39Z","closed_at":"2016-06-01T20:19:29Z","pull_request":{"url":"https://api.github.com/repos/mconf/mconf-web/pulls/862","html_url":"https://github.com/mconf/mconf-web/pull/862","diff_url":"https://github.com/mconf/mconf-web/pull/862.diff","patch_url":"https://github.com/mconf/mconf-web/pull/862.patch"},"body":"One error is that it was trying to get information from the controller, but since meetings are usually created from models/workers, the controller would be nil. This fixes issue #861.\r\n\r\nThere were tests to make sure the RA was correct, but they would always pass if running after controller tests, and that's why the error was not detected before.\r\n\r\nUpdating the gem public_activity fixed the conflicts in the tests. With the update, also disabled recent activity creation by default for all tests (expect on features and workers), which improves performance a bit. Now tests that require activities have to require them explicitly."},"comment":{"url":"https://api.github.com/repos/mconf/mconf-web/issues/comments/223112258","html_url":"https://github.com/mconf/mconf-web/pull/862#issuecomment-223112258","issue_url":"https://api.github.com/repos/mconf/mconf-web/issues/862","id":223112258,"user":{"login":"daronco","id":498566,"avatar_url":"https://avatars.githubusercontent.com/u/498566?v=3","gravatar_id":"","url":"https://api.github.com/users/daronco","html_url":"https://github.com/daronco","followers_url":"https://api.github.com/users/daronco/followers","following_url":"https://api.github.com/users/daronco/following{/other_user}","gists_url":"https://api.github.com/users/daronco/gists{/gist_id}","starred_url":"https://api.github.com/users/daronco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daronco/subscriptions","organizations_url":"https://api.github.com/users/daronco/orgs","repos_url":"https://api.github.com/users/daronco/repos","events_url":"https://api.github.com/users/daronco/events{/privacy}","received_events_url":"https://api.github.com/users/daronco/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T20:19:39Z","updated_at":"2016-06-01T20:19:39Z","body":"Closes #861."}}
{"actor":{"display_login":"daronco"}}