{"action":"created","comment":{"url":"https://api.github.com/repos/edx/ecommerce/pulls/comments/49736679","id":49736679,"diff_hunk":"@@ -251,6 +251,6 @@\n ENROLLMENT_FULFILLMENT_TIMEOUT = 7\n \n # Coupon code length\n-VOUCHER_CODE_LENGTH = 8\n+VOUCHER_CODE_LENGTH = 12","path":"ecommerce/settings/_oscar.py","position":5,"original_position":5,"commit_id":"e21bf42825dfa87c0ec76c2d50d1597e5e5bb242","original_commit_id":"e21bf42825dfa87c0ec76c2d50d1597e5e5bb242","user":{"login":"mjfrey","id":2236013,"avatar_url":"https://avatars.githubusercontent.com/u/2236013?v=3","gravatar_id":"","url":"https://api.github.com/users/mjfrey","html_url":"https://github.com/mjfrey","followers_url":"https://api.github.com/users/mjfrey/followers","following_url":"https://api.github.com/users/mjfrey/following{/other_user}","gists_url":"https://api.github.com/users/mjfrey/gists{/gist_id}","starred_url":"https://api.github.com/users/mjfrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjfrey/subscriptions","organizations_url":"https://api.github.com/users/mjfrey/orgs","repos_url":"https://api.github.com/users/mjfrey/repos","events_url":"https://api.github.com/users/mjfrey/events{/privacy}","received_events_url":"https://api.github.com/users/mjfrey/received_events","type":"User","site_admin":false},"body":"I went with 12 since we can nicely present this XXXX-XXXX-XXXX.  But if we feel strongly about increasing the length I am ok with it.","created_at":"2016-01-14T15:08:27Z","updated_at":"2016-01-14T15:08:27Z","html_url":"https://github.com/edx/ecommerce/pull/500#discussion_r49736679","pull_request_url":"https://api.github.com/repos/edx/ecommerce/pulls/500","_links":{"self":{"href":"https://api.github.com/repos/edx/ecommerce/pulls/comments/49736679"},"html":{"href":"https://github.com/edx/ecommerce/pull/500#discussion_r49736679"},"pull_request":{"href":"https://api.github.com/repos/edx/ecommerce/pulls/500"}}},"pull_request":{"url":"https://api.github.com/repos/edx/ecommerce/pulls/500","id":55954431,"html_url":"https://github.com/edx/ecommerce/pull/500","diff_url":"https://github.com/edx/ecommerce/pull/500.diff","patch_url":"https://github.com/edx/ecommerce/pull/500.patch","issue_url":"https://api.github.com/repos/edx/ecommerce/issues/500","number":500,"state":"open","locked":false,"title":"New logic to generate coupon code","user":{"login":"mjfrey","id":2236013,"avatar_url":"https://avatars.githubusercontent.com/u/2236013?v=3","gravatar_id":"","url":"https://api.github.com/users/mjfrey","html_url":"https://github.com/mjfrey","followers_url":"https://api.github.com/users/mjfrey/followers","following_url":"https://api.github.com/users/mjfrey/following{/other_user}","gists_url":"https://api.github.com/users/mjfrey/gists{/gist_id}","starred_url":"https://api.github.com/users/mjfrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjfrey/subscriptions","organizations_url":"https://api.github.com/users/mjfrey/orgs","repos_url":"https://api.github.com/users/mjfrey/repos","events_url":"https://api.github.com/users/mjfrey/events{/privacy}","received_events_url":"https://api.github.com/users/mjfrey/received_events","type":"User","site_admin":false},"body":"Increase code length to 12\r\nBase on UUID and hash","created_at":"2016-01-13T20:56:59Z","updated_at":"2016-01-14T15:08:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd424150be2a620306f1cf7090aafb5df9c03719","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/ecommerce/pulls/500/commits","review_comments_url":"https://api.github.com/repos/edx/ecommerce/pulls/500/comments","review_comment_url":"https://api.github.com/repos/edx/ecommerce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/ecommerce/issues/500/comments","statuses_url":"https://api.github.com/repos/edx/ecommerce/statuses/e21bf42825dfa87c0ec76c2d50d1597e5e5bb242","head":{"label":"edx:coupons/SOL-1566","ref":"coupons/SOL-1566","sha":"e21bf42825dfa87c0ec76c2d50d1597e5e5bb242","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":30175039,"name":"ecommerce","full_name":"edx/ecommerce","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/ecommerce","description":"Django application used to manage edX's product catalog and handle orders for those products","fork":false,"url":"https://api.github.com/repos/edx/ecommerce","forks_url":"https://api.github.com/repos/edx/ecommerce/forks","keys_url":"https://api.github.com/repos/edx/ecommerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/ecommerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/ecommerce/teams","hooks_url":"https://api.github.com/repos/edx/ecommerce/hooks","issue_events_url":"https://api.github.com/repos/edx/ecommerce/issues/events{/number}","events_url":"https://api.github.com/repos/edx/ecommerce/events","assignees_url":"https://api.github.com/repos/edx/ecommerce/assignees{/user}","branches_url":"https://api.github.com/repos/edx/ecommerce/branches{/branch}","tags_url":"https://api.github.com/repos/edx/ecommerce/tags","blobs_url":"https://api.github.com/repos/edx/ecommerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/ecommerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/ecommerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/ecommerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/ecommerce/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/ecommerce/languages","stargazers_url":"https://api.github.com/repos/edx/ecommerce/stargazers","contributors_url":"https://api.github.com/repos/edx/ecommerce/contributors","subscribers_url":"https://api.github.com/repos/edx/ecommerce/subscribers","subscription_url":"https://api.github.com/repos/edx/ecommerce/subscription","commits_url":"https://api.github.com/repos/edx/ecommerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/ecommerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/ecommerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/ecommerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/ecommerce/contents/{+path}","compare_url":"https://api.github.com/repos/edx/ecommerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/ecommerce/merges","archive_url":"https://api.github.com/repos/edx/ecommerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/ecommerce/downloads","issues_url":"https://api.github.com/repos/edx/ecommerce/issues{/number}","pulls_url":"https://api.github.com/repos/edx/ecommerce/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/ecommerce/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/ecommerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/ecommerce/labels{/name}","releases_url":"https://api.github.com/repos/edx/ecommerce/releases{/id}","created_at":"2015-02-02T06:55:15Z","updated_at":"2016-01-11T13:30:08Z","pushed_at":"2016-01-14T15:08:14Z","git_url":"git://github.com/edx/ecommerce.git","ssh_url":"git@github.com:edx/ecommerce.git","clone_url":"https://github.com/edx/ecommerce.git","svn_url":"https://github.com/edx/ecommerce","homepage":"http://open-edx-ecommerce-guide.readthedocs.org","size":8755,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":9,"forks":24,"open_issues":9,"watchers":18,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"ac3851ba8caa7cdc3842637403bcbac6103bff14","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":30175039,"name":"ecommerce","full_name":"edx/ecommerce","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/ecommerce","description":"Django application used to manage edX's product catalog and handle orders for those products","fork":false,"url":"https://api.github.com/repos/edx/ecommerce","forks_url":"https://api.github.com/repos/edx/ecommerce/forks","keys_url":"https://api.github.com/repos/edx/ecommerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/ecommerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/ecommerce/teams","hooks_url":"https://api.github.com/repos/edx/ecommerce/hooks","issue_events_url":"https://api.github.com/repos/edx/ecommerce/issues/events{/number}","events_url":"https://api.github.com/repos/edx/ecommerce/events","assignees_url":"https://api.github.com/repos/edx/ecommerce/assignees{/user}","branches_url":"https://api.github.com/repos/edx/ecommerce/branches{/branch}","tags_url":"https://api.github.com/repos/edx/ecommerce/tags","blobs_url":"https://api.github.com/repos/edx/ecommerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/ecommerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/ecommerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/ecommerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/ecommerce/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/ecommerce/languages","stargazers_url":"https://api.github.com/repos/edx/ecommerce/stargazers","contributors_url":"https://api.github.com/repos/edx/ecommerce/contributors","subscribers_url":"https://api.github.com/repos/edx/ecommerce/subscribers","subscription_url":"https://api.github.com/repos/edx/ecommerce/subscription","commits_url":"https://api.github.com/repos/edx/ecommerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/ecommerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/ecommerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/ecommerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/ecommerce/contents/{+path}","compare_url":"https://api.github.com/repos/edx/ecommerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/ecommerce/merges","archive_url":"https://api.github.com/repos/edx/ecommerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/ecommerce/downloads","issues_url":"https://api.github.com/repos/edx/ecommerce/issues{/number}","pulls_url":"https://api.github.com/repos/edx/ecommerce/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/ecommerce/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/ecommerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/ecommerce/labels{/name}","releases_url":"https://api.github.com/repos/edx/ecommerce/releases{/id}","created_at":"2015-02-02T06:55:15Z","updated_at":"2016-01-11T13:30:08Z","pushed_at":"2016-01-14T15:08:14Z","git_url":"git://github.com/edx/ecommerce.git","ssh_url":"git@github.com:edx/ecommerce.git","clone_url":"https://github.com/edx/ecommerce.git","svn_url":"https://github.com/edx/ecommerce","homepage":"http://open-edx-ecommerce-guide.readthedocs.org","size":8755,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":9,"forks":24,"open_issues":9,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/ecommerce/pulls/500"},"html":{"href":"https://github.com/edx/ecommerce/pull/500"},"issue":{"href":"https://api.github.com/repos/edx/ecommerce/issues/500"},"comments":{"href":"https://api.github.com/repos/edx/ecommerce/issues/500/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/ecommerce/pulls/500/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/ecommerce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/ecommerce/pulls/500/commits"},"statuses":{"href":"https://api.github.com/repos/edx/ecommerce/statuses/e21bf42825dfa87c0ec76c2d50d1597e5e5bb242"}}}}