{"action":"created","comment":{"url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/pulls/comments/80742719","pull_request_review_id":1777306,"id":80742719,"diff_hunk":"@@ -22,6 +22,10 @@ module TestConvert\n     convert(UInt8, v2)\n     convert(UInt8, v3)\n \n+    @test get(v1) == 1","path":"test/05_convert.jl","position":4,"original_position":4,"commit_id":"3901ccc1673ce6c2242e66de2f21ca20225e15e8","original_commit_id":"3901ccc1673ce6c2242e66de2f21ca20225e15e8","user":{"login":"nalimilan","id":1120448,"avatar_url":"https://avatars.githubusercontent.com/u/1120448?v=3","gravatar_id":"","url":"https://api.github.com/users/nalimilan","html_url":"https://github.com/nalimilan","followers_url":"https://api.github.com/users/nalimilan/followers","following_url":"https://api.github.com/users/nalimilan/following{/other_user}","gists_url":"https://api.github.com/users/nalimilan/gists{/gist_id}","starred_url":"https://api.github.com/users/nalimilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalimilan/subscriptions","organizations_url":"https://api.github.com/users/nalimilan/orgs","repos_url":"https://api.github.com/users/nalimilan/repos","events_url":"https://api.github.com/users/nalimilan/events{/privacy}","received_events_url":"https://api.github.com/users/nalimilan/received_events","type":"User","site_admin":false},"body":"Use `===` as in other places: this allows testing for type equality, which is always a good thing in tests.","created_at":"2016-09-27T17:04:03Z","updated_at":"2016-09-27T17:04:04Z","html_url":"https://github.com/nalimilan/CategoricalArrays.jl/pull/21#discussion_r80742719","pull_request_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/pulls/comments/80742719"},"html":{"href":"https://github.com/nalimilan/CategoricalArrays.jl/pull/21#discussion_r80742719"},"pull_request":{"href":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/pulls/21","id":86839059,"html_url":"https://github.com/nalimilan/CategoricalArrays.jl/pull/21","diff_url":"https://github.com/nalimilan/CategoricalArrays.jl/pull/21.diff","patch_url":"https://github.com/nalimilan/CategoricalArrays.jl/pull/21.patch","issue_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/issues/21","number":21,"state":"open","locked":false,"title":"get(x::CategoricalValue)","user":{"login":"gustafsson","id":184952,"avatar_url":"https://avatars.githubusercontent.com/u/184952?v=3","gravatar_id":"","url":"https://api.github.com/users/gustafsson","html_url":"https://github.com/gustafsson","followers_url":"https://api.github.com/users/gustafsson/followers","following_url":"https://api.github.com/users/gustafsson/following{/other_user}","gists_url":"https://api.github.com/users/gustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/gustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustafsson/subscriptions","organizations_url":"https://api.github.com/users/gustafsson/orgs","repos_url":"https://api.github.com/users/gustafsson/repos","events_url":"https://api.github.com/users/gustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/gustafsson/received_events","type":"User","site_admin":false},"body":"`Base.get` accessor to extract the value of a category.\r\n\r\nI preferred `value` at first but when I think about it I rather not export such a generic name. And `get` is used by both Nullable and Dict so I guess we follow some sort of convention if we use the same method name here.\r\n\r\n```\r\n> ca = CategoricalArray([\"a\",\"b\"]);\r\n> get(ca[1])\r\n\"a\"\r\n> nca = NullableCategoricalArray([\"a\",\"b\"]);\r\n> get(get(nca[1]))\r\n\"a\"\r\n```","created_at":"2016-09-26T23:40:19Z","updated_at":"2016-09-27T17:04:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d40057eb2dadfbe09fcc1b9d8a95e8c7d6ba1635","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/pulls/21/commits","review_comments_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/pulls/21/comments","review_comment_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/issues/21/comments","statuses_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/statuses/3901ccc1673ce6c2242e66de2f21ca20225e15e8","head":{"label":"gustafsson:get_categoricalvalue","ref":"get_categoricalvalue","sha":"3901ccc1673ce6c2242e66de2f21ca20225e15e8","user":{"login":"gustafsson","id":184952,"avatar_url":"https://avatars.githubusercontent.com/u/184952?v=3","gravatar_id":"","url":"https://api.github.com/users/gustafsson","html_url":"https://github.com/gustafsson","followers_url":"https://api.github.com/users/gustafsson/followers","following_url":"https://api.github.com/users/gustafsson/following{/other_user}","gists_url":"https://api.github.com/users/gustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/gustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustafsson/subscriptions","organizations_url":"https://api.github.com/users/gustafsson/orgs","repos_url":"https://api.github.com/users/gustafsson/repos","events_url":"https://api.github.com/users/gustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/gustafsson/received_events","type":"User","site_admin":false},"repo":{"id":68463418,"name":"CategoricalArrays.jl","full_name":"gustafsson/CategoricalArrays.jl","owner":{"login":"gustafsson","id":184952,"avatar_url":"https://avatars.githubusercontent.com/u/184952?v=3","gravatar_id":"","url":"https://api.github.com/users/gustafsson","html_url":"https://github.com/gustafsson","followers_url":"https://api.github.com/users/gustafsson/followers","following_url":"https://api.github.com/users/gustafsson/following{/other_user}","gists_url":"https://api.github.com/users/gustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/gustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustafsson/subscriptions","organizations_url":"https://api.github.com/users/gustafsson/orgs","repos_url":"https://api.github.com/users/gustafsson/repos","events_url":"https://api.github.com/users/gustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/gustafsson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gustafsson/CategoricalArrays.jl","description":"Arrays for working with categorical data (both nominal and ordinal) in Julia","fork":true,"url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl","forks_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/forks","keys_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/teams","hooks_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/hooks","issue_events_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/issues/events{/number}","events_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/events","assignees_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/assignees{/user}","branches_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/branches{/branch}","tags_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/tags","blobs_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/languages","stargazers_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/stargazers","contributors_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/contributors","subscribers_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/subscribers","subscription_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/subscription","commits_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/contents/{+path}","compare_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/merges","archive_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/downloads","issues_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/issues{/number}","pulls_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/labels{/name}","releases_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/releases{/id}","deployments_url":"https://api.github.com/repos/gustafsson/CategoricalArrays.jl/deployments","created_at":"2016-09-17T16:19:52Z","updated_at":"2016-09-17T16:19:53Z","pushed_at":"2016-09-27T16:15:20Z","git_url":"git://github.com/gustafsson/CategoricalArrays.jl.git","ssh_url":"git@github.com:gustafsson/CategoricalArrays.jl.git","clone_url":"https://github.com/gustafsson/CategoricalArrays.jl.git","svn_url":"https://github.com/gustafsson/CategoricalArrays.jl","homepage":"","size":148,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nalimilan:master","ref":"master","sha":"3b687af067e1f8f094d1c4ad0ee344dc144ad922","user":{"login":"nalimilan","id":1120448,"avatar_url":"https://avatars.githubusercontent.com/u/1120448?v=3","gravatar_id":"","url":"https://api.github.com/users/nalimilan","html_url":"https://github.com/nalimilan","followers_url":"https://api.github.com/users/nalimilan/followers","following_url":"https://api.github.com/users/nalimilan/following{/other_user}","gists_url":"https://api.github.com/users/nalimilan/gists{/gist_id}","starred_url":"https://api.github.com/users/nalimilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalimilan/subscriptions","organizations_url":"https://api.github.com/users/nalimilan/orgs","repos_url":"https://api.github.com/users/nalimilan/repos","events_url":"https://api.github.com/users/nalimilan/events{/privacy}","received_events_url":"https://api.github.com/users/nalimilan/received_events","type":"User","site_admin":false},"repo":{"id":58399306,"name":"CategoricalArrays.jl","full_name":"nalimilan/CategoricalArrays.jl","owner":{"login":"nalimilan","id":1120448,"avatar_url":"https://avatars.githubusercontent.com/u/1120448?v=3","gravatar_id":"","url":"https://api.github.com/users/nalimilan","html_url":"https://github.com/nalimilan","followers_url":"https://api.github.com/users/nalimilan/followers","following_url":"https://api.github.com/users/nalimilan/following{/other_user}","gists_url":"https://api.github.com/users/nalimilan/gists{/gist_id}","starred_url":"https://api.github.com/users/nalimilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalimilan/subscriptions","organizations_url":"https://api.github.com/users/nalimilan/orgs","repos_url":"https://api.github.com/users/nalimilan/repos","events_url":"https://api.github.com/users/nalimilan/events{/privacy}","received_events_url":"https://api.github.com/users/nalimilan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nalimilan/CategoricalArrays.jl","description":"Arrays for working with categorical data (both nominal and ordinal) in Julia","fork":true,"url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl","forks_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/forks","keys_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/teams","hooks_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/hooks","issue_events_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/issues/events{/number}","events_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/events","assignees_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/assignees{/user}","branches_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/branches{/branch}","tags_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/tags","blobs_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/languages","stargazers_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/stargazers","contributors_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/contributors","subscribers_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/subscribers","subscription_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/subscription","commits_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/contents/{+path}","compare_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/merges","archive_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/downloads","issues_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/issues{/number}","pulls_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/labels{/name}","releases_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/releases{/id}","deployments_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/deployments","created_at":"2016-05-09T18:36:12Z","updated_at":"2016-08-30T13:02:01Z","pushed_at":"2016-09-27T16:15:20Z","git_url":"git://github.com/nalimilan/CategoricalArrays.jl.git","ssh_url":"git@github.com:nalimilan/CategoricalArrays.jl.git","clone_url":"https://github.com/nalimilan/CategoricalArrays.jl.git","svn_url":"https://github.com/nalimilan/CategoricalArrays.jl","homepage":"","size":173,"stargazers_count":5,"watchers_count":5,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":7,"forks":4,"open_issues":7,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/pulls/21"},"html":{"href":"https://github.com/nalimilan/CategoricalArrays.jl/pull/21"},"issue":{"href":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/issues/21"},"comments":{"href":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/statuses/3901ccc1673ce6c2242e66de2f21ca20225e15e8"}}}}
{"actor":{"display_login":"nalimilan"}}