{"action":"created","comment":{"url":"https://api.github.com/repos/CESARBR/knot-protocol-source/pulls/comments/77804215","id":77804215,"diff_hunk":"@@ -87,40 +87,34 @@ typedef struct __attribute__ ((packed)) {\n \tuint8_t\t\t\tpayload_len;\n } knot_msg_header;\n \n-typedef struct __attribute__ ((packed)) {\n-\tuint8_t\t\t\tsensor_id;\t// App defined sensor id \n-\tuint8_t\t\t\tunit;\t\t// KNOT_UNIT_* \n-\tuint8_t\t\t\tvalue_type;\t// KNOT_VALUE_TYPE_* (int, float, bool, raw)\n-} knot_data_header;\n-","path":"src/knot_protocol.h","position":null,"original_position":9,"commit_id":"70ac7c4d874a043b71ca602436141819c28389e5","original_commit_id":"6500ffb2f720574e433351335e72a5480bd966df","user":{"login":"cktakahasi","id":89566,"avatar_url":"https://avatars.githubusercontent.com/u/89566?v=3","gravatar_id":"","url":"https://api.github.com/users/cktakahasi","html_url":"https://github.com/cktakahasi","followers_url":"https://api.github.com/users/cktakahasi/followers","following_url":"https://api.github.com/users/cktakahasi/following{/other_user}","gists_url":"https://api.github.com/users/cktakahasi/gists{/gist_id}","starred_url":"https://api.github.com/users/cktakahasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cktakahasi/subscriptions","organizations_url":"https://api.github.com/users/cktakahasi/orgs","repos_url":"https://api.github.com/users/cktakahasi/repos","events_url":"https://api.github.com/users/cktakahasi/events{/privacy}","received_events_url":"https://api.github.com/users/cktakahasi/received_events","type":"User","site_admin":false},"body":"All these changes will break GW code. Can you please split this patchset and send both series together? (changes at protocol & GW) ","created_at":"2016-09-07T11:28:54Z","updated_at":"2016-09-07T11:28:54Z","html_url":"https://github.com/CESARBR/knot-protocol-source/pull/1#discussion_r77804215","pull_request_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/CESARBR/knot-protocol-source/pulls/comments/77804215"},"html":{"href":"https://github.com/CESARBR/knot-protocol-source/pull/1#discussion_r77804215"},"pull_request":{"href":"https://api.github.com/repos/CESARBR/knot-protocol-source/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/CESARBR/knot-protocol-source/pulls/1","id":84166285,"html_url":"https://github.com/CESARBR/knot-protocol-source/pull/1","diff_url":"https://github.com/CESARBR/knot-protocol-source/pull/1.diff","patch_url":"https://github.com/CESARBR/knot-protocol-source/pull/1.patch","issue_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/issues/1","number":1,"state":"open","locked":false,"title":"Refactor on KNoT Protocol library","user":{"login":"tgfb","id":1085519,"avatar_url":"https://avatars.githubusercontent.com/u/1085519?v=3","gravatar_id":"","url":"https://api.github.com/users/tgfb","html_url":"https://github.com/tgfb","followers_url":"https://api.github.com/users/tgfb/followers","following_url":"https://api.github.com/users/tgfb/following{/other_user}","gists_url":"https://api.github.com/users/tgfb/gists{/gist_id}","starred_url":"https://api.github.com/users/tgfb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgfb/subscriptions","organizations_url":"https://api.github.com/users/tgfb/orgs","repos_url":"https://api.github.com/users/tgfb/repos","events_url":"https://api.github.com/users/tgfb/events{/privacy}","received_events_url":"https://api.github.com/users/tgfb/received_events","type":"User","site_admin":false},"body":"Changes:\r\n - Removed unused files\r\n - Change some file names\r\n - Update README\r\n - Refactor on data and schema structures\r\n - Refactor on event flags","created_at":"2016-09-06T17:49:27Z","updated_at":"2016-09-07T11:28:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28062a06b63d273e493142e8bcd776482136648e","assignee":{"login":"tgfb","id":1085519,"avatar_url":"https://avatars.githubusercontent.com/u/1085519?v=3","gravatar_id":"","url":"https://api.github.com/users/tgfb","html_url":"https://github.com/tgfb","followers_url":"https://api.github.com/users/tgfb/followers","following_url":"https://api.github.com/users/tgfb/following{/other_user}","gists_url":"https://api.github.com/users/tgfb/gists{/gist_id}","starred_url":"https://api.github.com/users/tgfb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgfb/subscriptions","organizations_url":"https://api.github.com/users/tgfb/orgs","repos_url":"https://api.github.com/users/tgfb/repos","events_url":"https://api.github.com/users/tgfb/events{/privacy}","received_events_url":"https://api.github.com/users/tgfb/received_events","type":"User","site_admin":false},"assignees":[{"login":"tgfb","id":1085519,"avatar_url":"https://avatars.githubusercontent.com/u/1085519?v=3","gravatar_id":"","url":"https://api.github.com/users/tgfb","html_url":"https://github.com/tgfb","followers_url":"https://api.github.com/users/tgfb/followers","following_url":"https://api.github.com/users/tgfb/following{/other_user}","gists_url":"https://api.github.com/users/tgfb/gists{/gist_id}","starred_url":"https://api.github.com/users/tgfb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgfb/subscriptions","organizations_url":"https://api.github.com/users/tgfb/orgs","repos_url":"https://api.github.com/users/tgfb/repos","events_url":"https://api.github.com/users/tgfb/events{/privacy}","received_events_url":"https://api.github.com/users/tgfb/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/pulls/1/commits","review_comments_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/pulls/1/comments","review_comment_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/issues/1/comments","statuses_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/statuses/70ac7c4d874a043b71ca602436141819c28389e5","head":{"label":"CESARBR:devel_tgfb_KNOT-205","ref":"devel_tgfb_KNOT-205","sha":"70ac7c4d874a043b71ca602436141819c28389e5","user":{"login":"CESARBR","id":7859691,"avatar_url":"https://avatars.githubusercontent.com/u/7859691?v=3","gravatar_id":"","url":"https://api.github.com/users/CESARBR","html_url":"https://github.com/CESARBR","followers_url":"https://api.github.com/users/CESARBR/followers","following_url":"https://api.github.com/users/CESARBR/following{/other_user}","gists_url":"https://api.github.com/users/CESARBR/gists{/gist_id}","starred_url":"https://api.github.com/users/CESARBR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CESARBR/subscriptions","organizations_url":"https://api.github.com/users/CESARBR/orgs","repos_url":"https://api.github.com/users/CESARBR/repos","events_url":"https://api.github.com/users/CESARBR/events{/privacy}","received_events_url":"https://api.github.com/users/CESARBR/received_events","type":"Organization","site_admin":false},"repo":{"id":65824342,"name":"knot-protocol-source","full_name":"CESARBR/knot-protocol-source","owner":{"login":"CESARBR","id":7859691,"avatar_url":"https://avatars.githubusercontent.com/u/7859691?v=3","gravatar_id":"","url":"https://api.github.com/users/CESARBR","html_url":"https://github.com/CESARBR","followers_url":"https://api.github.com/users/CESARBR/followers","following_url":"https://api.github.com/users/CESARBR/following{/other_user}","gists_url":"https://api.github.com/users/CESARBR/gists{/gist_id}","starred_url":"https://api.github.com/users/CESARBR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CESARBR/subscriptions","organizations_url":"https://api.github.com/users/CESARBR/orgs","repos_url":"https://api.github.com/users/CESARBR/repos","events_url":"https://api.github.com/users/CESARBR/events{/privacy}","received_events_url":"https://api.github.com/users/CESARBR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CESARBR/knot-protocol-source","description":"KNOT protocol library is a lightweight C library built to use minimal CPU and memory resources.","fork":false,"url":"https://api.github.com/repos/CESARBR/knot-protocol-source","forks_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/forks","keys_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/teams","hooks_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/hooks","issue_events_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/issues/events{/number}","events_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/events","assignees_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/assignees{/user}","branches_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/branches{/branch}","tags_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/tags","blobs_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/git/refs{/sha}","trees_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/statuses/{sha}","languages_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/languages","stargazers_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/stargazers","contributors_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/contributors","subscribers_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/subscribers","subscription_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/subscription","commits_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/commits{/sha}","git_commits_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/git/commits{/sha}","comments_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/comments{/number}","issue_comment_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/issues/comments{/number}","contents_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/contents/{+path}","compare_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/merges","archive_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/downloads","issues_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/issues{/number}","pulls_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/pulls{/number}","milestones_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/milestones{/number}","notifications_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/labels{/name}","releases_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/releases{/id}","deployments_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/deployments","created_at":"2016-08-16T13:52:02Z","updated_at":"2016-08-18T18:43:50Z","pushed_at":"2016-09-06T17:53:50Z","git_url":"git://github.com/CESARBR/knot-protocol-source.git","ssh_url":"git@github.com:CESARBR/knot-protocol-source.git","clone_url":"https://github.com/CESARBR/knot-protocol-source.git","svn_url":"https://github.com/CESARBR/knot-protocol-source","homepage":null,"size":89,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"CESARBR:master","ref":"master","sha":"832f0f270d15edbcbaa732d67b1303d8cbcb06de","user":{"login":"CESARBR","id":7859691,"avatar_url":"https://avatars.githubusercontent.com/u/7859691?v=3","gravatar_id":"","url":"https://api.github.com/users/CESARBR","html_url":"https://github.com/CESARBR","followers_url":"https://api.github.com/users/CESARBR/followers","following_url":"https://api.github.com/users/CESARBR/following{/other_user}","gists_url":"https://api.github.com/users/CESARBR/gists{/gist_id}","starred_url":"https://api.github.com/users/CESARBR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CESARBR/subscriptions","organizations_url":"https://api.github.com/users/CESARBR/orgs","repos_url":"https://api.github.com/users/CESARBR/repos","events_url":"https://api.github.com/users/CESARBR/events{/privacy}","received_events_url":"https://api.github.com/users/CESARBR/received_events","type":"Organization","site_admin":false},"repo":{"id":65824342,"name":"knot-protocol-source","full_name":"CESARBR/knot-protocol-source","owner":{"login":"CESARBR","id":7859691,"avatar_url":"https://avatars.githubusercontent.com/u/7859691?v=3","gravatar_id":"","url":"https://api.github.com/users/CESARBR","html_url":"https://github.com/CESARBR","followers_url":"https://api.github.com/users/CESARBR/followers","following_url":"https://api.github.com/users/CESARBR/following{/other_user}","gists_url":"https://api.github.com/users/CESARBR/gists{/gist_id}","starred_url":"https://api.github.com/users/CESARBR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CESARBR/subscriptions","organizations_url":"https://api.github.com/users/CESARBR/orgs","repos_url":"https://api.github.com/users/CESARBR/repos","events_url":"https://api.github.com/users/CESARBR/events{/privacy}","received_events_url":"https://api.github.com/users/CESARBR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CESARBR/knot-protocol-source","description":"KNOT protocol library is a lightweight C library built to use minimal CPU and memory resources.","fork":false,"url":"https://api.github.com/repos/CESARBR/knot-protocol-source","forks_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/forks","keys_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/teams","hooks_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/hooks","issue_events_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/issues/events{/number}","events_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/events","assignees_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/assignees{/user}","branches_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/branches{/branch}","tags_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/tags","blobs_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/git/refs{/sha}","trees_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/statuses/{sha}","languages_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/languages","stargazers_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/stargazers","contributors_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/contributors","subscribers_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/subscribers","subscription_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/subscription","commits_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/commits{/sha}","git_commits_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/git/commits{/sha}","comments_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/comments{/number}","issue_comment_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/issues/comments{/number}","contents_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/contents/{+path}","compare_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/merges","archive_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/downloads","issues_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/issues{/number}","pulls_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/pulls{/number}","milestones_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/milestones{/number}","notifications_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/labels{/name}","releases_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/releases{/id}","deployments_url":"https://api.github.com/repos/CESARBR/knot-protocol-source/deployments","created_at":"2016-08-16T13:52:02Z","updated_at":"2016-08-18T18:43:50Z","pushed_at":"2016-09-06T17:53:50Z","git_url":"git://github.com/CESARBR/knot-protocol-source.git","ssh_url":"git@github.com:CESARBR/knot-protocol-source.git","clone_url":"https://github.com/CESARBR/knot-protocol-source.git","svn_url":"https://github.com/CESARBR/knot-protocol-source","homepage":null,"size":89,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CESARBR/knot-protocol-source/pulls/1"},"html":{"href":"https://github.com/CESARBR/knot-protocol-source/pull/1"},"issue":{"href":"https://api.github.com/repos/CESARBR/knot-protocol-source/issues/1"},"comments":{"href":"https://api.github.com/repos/CESARBR/knot-protocol-source/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/CESARBR/knot-protocol-source/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/CESARBR/knot-protocol-source/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CESARBR/knot-protocol-source/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/CESARBR/knot-protocol-source/statuses/70ac7c4d874a043b71ca602436141819c28389e5"}}}}
{"actor":{"display_login":"cktakahasi"}}