{"action":"created","comment":{"url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/pulls/comments/81805744","pull_request_review_id":2758930,"id":81805744,"diff_hunk":"@@ -91,7 +91,15 @@ examples), as you are just coding in C++, but there are some rules:\n */\n \n \n+// Some gcc versions on some platforms seem to have max_align_t missing from","path":"src/liboslexec/llvm_ops.cpp","position":4,"original_position":4,"commit_id":"078666c2b079eb87ebfc109d7dd31af698192452","original_commit_id":"078666c2b079eb87ebfc109d7dd31af698192452","user":{"login":"fpsunflower","id":578593,"avatar_url":"https://avatars.githubusercontent.com/u/578593?v=3","gravatar_id":"","url":"https://api.github.com/users/fpsunflower","html_url":"https://github.com/fpsunflower","followers_url":"https://api.github.com/users/fpsunflower/followers","following_url":"https://api.github.com/users/fpsunflower/following{/other_user}","gists_url":"https://api.github.com/users/fpsunflower/gists{/gist_id}","starred_url":"https://api.github.com/users/fpsunflower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpsunflower/subscriptions","organizations_url":"https://api.github.com/users/fpsunflower/orgs","repos_url":"https://api.github.com/users/fpsunflower/repos","events_url":"https://api.github.com/users/fpsunflower/events{/privacy}","received_events_url":"https://api.github.com/users/fpsunflower/received_events","type":"User","site_admin":false},"body":"Makes sense. LGTM!","created_at":"2016-10-04T17:08:27Z","updated_at":"2016-10-04T17:08:27Z","html_url":"https://github.com/imageworks/OpenShadingLanguage/pull/674#discussion_r81805744","pull_request_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/pulls/674","_links":{"self":{"href":"https://api.github.com/repos/imageworks/OpenShadingLanguage/pulls/comments/81805744"},"html":{"href":"https://github.com/imageworks/OpenShadingLanguage/pull/674#discussion_r81805744"},"pull_request":{"href":"https://api.github.com/repos/imageworks/OpenShadingLanguage/pulls/674"}}},"pull_request":{"url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/pulls/674","id":87575905,"html_url":"https://github.com/imageworks/OpenShadingLanguage/pull/674","diff_url":"https://github.com/imageworks/OpenShadingLanguage/pull/674.diff","patch_url":"https://github.com/imageworks/OpenShadingLanguage/pull/674.patch","issue_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/issues/674","number":674,"state":"open","locked":false,"title":"Be sure to propagate C++ standard flags to the compilation of llvm_ops.cpp","user":{"login":"lgritz","id":504179,"avatar_url":"https://avatars.githubusercontent.com/u/504179?v=3","gravatar_id":"","url":"https://api.github.com/users/lgritz","html_url":"https://github.com/lgritz","followers_url":"https://api.github.com/users/lgritz/followers","following_url":"https://api.github.com/users/lgritz/following{/other_user}","gists_url":"https://api.github.com/users/lgritz/gists{/gist_id}","starred_url":"https://api.github.com/users/lgritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgritz/subscriptions","organizations_url":"https://api.github.com/users/lgritz/orgs","repos_url":"https://api.github.com/users/lgritz/repos","events_url":"https://api.github.com/users/lgritz/events{/privacy}","received_events_url":"https://api.github.com/users/lgritz/received_events","type":"User","site_admin":false},"body":"We weren't properly transferring --std=c++11 from the directives to compile OSL's implementation, to the command line that compiles the llvm bitcode from llvm_ops.cpp. They should match.\r\n\r\nThis doesn't change any of the default for whether we use C++11, it just correctly uses the same version of the standard when comping llvm_ops.cpp as the rest of the software.\r\n\r\nThis mimics the way we propagate the -m flags (for SSE, AVX, etc.) to the compilation of the bitcode.\r\n","created_at":"2016-09-30T22:26:57Z","updated_at":"2016-10-04T17:08:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9e122dca648f3800cd00913c2043cb66e6495db","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/pulls/674/commits","review_comments_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/pulls/674/comments","review_comment_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/issues/674/comments","statuses_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/statuses/078666c2b079eb87ebfc109d7dd31af698192452","head":{"label":"lgritz:lg-cpp11","ref":"lg-cpp11","sha":"078666c2b079eb87ebfc109d7dd31af698192452","user":{"login":"lgritz","id":504179,"avatar_url":"https://avatars.githubusercontent.com/u/504179?v=3","gravatar_id":"","url":"https://api.github.com/users/lgritz","html_url":"https://github.com/lgritz","followers_url":"https://api.github.com/users/lgritz/followers","following_url":"https://api.github.com/users/lgritz/following{/other_user}","gists_url":"https://api.github.com/users/lgritz/gists{/gist_id}","starred_url":"https://api.github.com/users/lgritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgritz/subscriptions","organizations_url":"https://api.github.com/users/lgritz/orgs","repos_url":"https://api.github.com/users/lgritz/repos","events_url":"https://api.github.com/users/lgritz/events{/privacy}","received_events_url":"https://api.github.com/users/lgritz/received_events","type":"User","site_admin":false},"repo":{"id":1462077,"name":"OpenShadingLanguage","full_name":"lgritz/OpenShadingLanguage","owner":{"login":"lgritz","id":504179,"avatar_url":"https://avatars.githubusercontent.com/u/504179?v=3","gravatar_id":"","url":"https://api.github.com/users/lgritz","html_url":"https://github.com/lgritz","followers_url":"https://api.github.com/users/lgritz/followers","following_url":"https://api.github.com/users/lgritz/following{/other_user}","gists_url":"https://api.github.com/users/lgritz/gists{/gist_id}","starred_url":"https://api.github.com/users/lgritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgritz/subscriptions","organizations_url":"https://api.github.com/users/lgritz/orgs","repos_url":"https://api.github.com/users/lgritz/repos","events_url":"https://api.github.com/users/lgritz/events{/privacy}","received_events_url":"https://api.github.com/users/lgritz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lgritz/OpenShadingLanguage","description":"Advanced shading language for production GI renderers","fork":true,"url":"https://api.github.com/repos/lgritz/OpenShadingLanguage","forks_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/forks","keys_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/teams","hooks_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/hooks","issue_events_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/issues/events{/number}","events_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/events","assignees_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/assignees{/user}","branches_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/branches{/branch}","tags_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/tags","blobs_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/git/refs{/sha}","trees_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/statuses/{sha}","languages_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/languages","stargazers_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/stargazers","contributors_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/contributors","subscribers_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/subscribers","subscription_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/subscription","commits_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/commits{/sha}","git_commits_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/git/commits{/sha}","comments_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/comments{/number}","issue_comment_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/issues/comments{/number}","contents_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/contents/{+path}","compare_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/merges","archive_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/downloads","issues_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/issues{/number}","pulls_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/pulls{/number}","milestones_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/milestones{/number}","notifications_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/labels{/name}","releases_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/releases{/id}","deployments_url":"https://api.github.com/repos/lgritz/OpenShadingLanguage/deployments","created_at":"2011-03-10T03:35:03Z","updated_at":"2016-08-23T16:38:26Z","pushed_at":"2016-10-04T17:08:23Z","git_url":"git://github.com/lgritz/OpenShadingLanguage.git","ssh_url":"git@github.com:lgritz/OpenShadingLanguage.git","clone_url":"https://github.com/lgritz/OpenShadingLanguage.git","svn_url":"https://github.com/lgritz/OpenShadingLanguage","homepage":"","size":154076,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":7,"default_branch":"master"}},"base":{"label":"imageworks:master","ref":"master","sha":"67fad2b960cd0a82dc797f04809a853478b90b1f","user":{"login":"imageworks","id":320618,"avatar_url":"https://avatars.githubusercontent.com/u/320618?v=3","gravatar_id":"","url":"https://api.github.com/users/imageworks","html_url":"https://github.com/imageworks","followers_url":"https://api.github.com/users/imageworks/followers","following_url":"https://api.github.com/users/imageworks/following{/other_user}","gists_url":"https://api.github.com/users/imageworks/gists{/gist_id}","starred_url":"https://api.github.com/users/imageworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imageworks/subscriptions","organizations_url":"https://api.github.com/users/imageworks/orgs","repos_url":"https://api.github.com/users/imageworks/repos","events_url":"https://api.github.com/users/imageworks/events{/privacy}","received_events_url":"https://api.github.com/users/imageworks/received_events","type":"Organization","site_admin":false},"repo":{"id":1461954,"name":"OpenShadingLanguage","full_name":"imageworks/OpenShadingLanguage","owner":{"login":"imageworks","id":320618,"avatar_url":"https://avatars.githubusercontent.com/u/320618?v=3","gravatar_id":"","url":"https://api.github.com/users/imageworks","html_url":"https://github.com/imageworks","followers_url":"https://api.github.com/users/imageworks/followers","following_url":"https://api.github.com/users/imageworks/following{/other_user}","gists_url":"https://api.github.com/users/imageworks/gists{/gist_id}","starred_url":"https://api.github.com/users/imageworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imageworks/subscriptions","organizations_url":"https://api.github.com/users/imageworks/orgs","repos_url":"https://api.github.com/users/imageworks/repos","events_url":"https://api.github.com/users/imageworks/events{/privacy}","received_events_url":"https://api.github.com/users/imageworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/imageworks/OpenShadingLanguage","description":"Advanced shading language for production GI renderers","fork":false,"url":"https://api.github.com/repos/imageworks/OpenShadingLanguage","forks_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/forks","keys_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/teams","hooks_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/hooks","issue_events_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/issues/events{/number}","events_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/events","assignees_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/assignees{/user}","branches_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/branches{/branch}","tags_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/tags","blobs_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/git/refs{/sha}","trees_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/statuses/{sha}","languages_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/languages","stargazers_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/stargazers","contributors_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/contributors","subscribers_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/subscribers","subscription_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/subscription","commits_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/commits{/sha}","git_commits_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/git/commits{/sha}","comments_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/comments{/number}","issue_comment_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/issues/comments{/number}","contents_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/contents/{+path}","compare_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/merges","archive_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/downloads","issues_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/issues{/number}","pulls_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/pulls{/number}","milestones_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/milestones{/number}","notifications_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/labels{/name}","releases_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/releases{/id}","deployments_url":"https://api.github.com/repos/imageworks/OpenShadingLanguage/deployments","created_at":"2011-03-10T02:44:05Z","updated_at":"2016-10-02T19:17:20Z","pushed_at":"2016-10-03T23:27:29Z","git_url":"git://github.com/imageworks/OpenShadingLanguage.git","ssh_url":"git@github.com:imageworks/OpenShadingLanguage.git","clone_url":"https://github.com/imageworks/OpenShadingLanguage.git","svn_url":"https://github.com/imageworks/OpenShadingLanguage","homepage":"","size":156130,"stargazers_count":490,"watchers_count":490,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":135,"mirror_url":null,"open_issues_count":41,"forks":135,"open_issues":41,"watchers":490,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/imageworks/OpenShadingLanguage/pulls/674"},"html":{"href":"https://github.com/imageworks/OpenShadingLanguage/pull/674"},"issue":{"href":"https://api.github.com/repos/imageworks/OpenShadingLanguage/issues/674"},"comments":{"href":"https://api.github.com/repos/imageworks/OpenShadingLanguage/issues/674/comments"},"review_comments":{"href":"https://api.github.com/repos/imageworks/OpenShadingLanguage/pulls/674/comments"},"review_comment":{"href":"https://api.github.com/repos/imageworks/OpenShadingLanguage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/imageworks/OpenShadingLanguage/pulls/674/commits"},"statuses":{"href":"https://api.github.com/repos/imageworks/OpenShadingLanguage/statuses/078666c2b079eb87ebfc109d7dd31af698192452"}}}}
{"actor":{"display_login":"fpsunflower"}}