{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/72361966","id":72361966,"diff_hunk":"@@ -149,7 +205,20 @@ public MethodSignatureEncoder(BlobBuilder builder, bool hasVarArgs)\n             HasVarArgs = hasVarArgs;\n         }\n \n-        public void Parameters(int parameterCount, out ReturnTypeEncoder returnType, out ParametersEncoder parameters)\n+        /// <summary>\n+        /// Encodes return type and parameters.\n+        /// \n+        /// Returns a pair of encoders that must be used in the order they appear in the tuple:\n+        /// first <see cref=\"ReturnTypeEncoder\"/> to encode the return type,\n+        /// then <see cref=\"ParametersEncoder\"/> to encode the actual parameters.\n+        /// </summary>\n+        /// <param name=\"parameterCount\">Number of parameters.</param>\n+        /// <returns>\n+        /// Returns a pair of encoders that must be used in the order they appear in the tuple:\n+        /// first <see cref=\"ReturnTypeEncoder\"/> to encode the return type,\n+        /// then <see cref=\"ParametersEncoder\"/> to encode the actual parameters.\n+        /// </returns>","path":"src/System.Reflection.Metadata/src/System/Reflection/Metadata/Ecma335/Encoding/BlobEncoders.cs","position":163,"original_position":163,"commit_id":"8ebc73e92a8525f3a73c9f0728af1f02004fe855","original_commit_id":"8ebc73e92a8525f3a73c9f0728af1f02004fe855","user":{"login":"tmat","id":41759,"avatar_url":"https://avatars.githubusercontent.com/u/41759?v=3","gravatar_id":"","url":"https://api.github.com/users/tmat","html_url":"https://github.com/tmat","followers_url":"https://api.github.com/users/tmat/followers","following_url":"https://api.github.com/users/tmat/following{/other_user}","gists_url":"https://api.github.com/users/tmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmat/subscriptions","organizations_url":"https://api.github.com/users/tmat/orgs","repos_url":"https://api.github.com/users/tmat/repos","events_url":"https://api.github.com/users/tmat/events{/privacy}","received_events_url":"https://api.github.com/users/tmat/received_events","type":"User","site_admin":false},"body":"I guess we don't need the ```<returns>```. I'll remove them.","created_at":"2016-07-27T00:19:39Z","updated_at":"2016-07-27T00:19:39Z","html_url":"https://github.com/dotnet/corefx/pull/9505#discussion_r72361966","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/9505","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/72361966"},"html":{"href":"https://github.com/dotnet/corefx/pull/9505#discussion_r72361966"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/9505"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/9505","id":74272420,"html_url":"https://github.com/dotnet/corefx/pull/9505","diff_url":"https://github.com/dotnet/corefx/pull/9505.diff","patch_url":"https://github.com/dotnet/corefx/pull/9505.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/9505","number":9505,"state":"open","locked":false,"title":"Use tuples in APIs that return multiple values instead of out parameters","user":{"login":"tmat","id":41759,"avatar_url":"https://avatars.githubusercontent.com/u/41759?v=3","gravatar_id":"","url":"https://api.github.com/users/tmat","html_url":"https://github.com/tmat","followers_url":"https://api.github.com/users/tmat/followers","following_url":"https://api.github.com/users/tmat/following{/other_user}","gists_url":"https://api.github.com/users/tmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmat/subscriptions","organizations_url":"https://api.github.com/users/tmat/orgs","repos_url":"https://api.github.com/users/tmat/repos","events_url":"https://api.github.com/users/tmat/events{/privacy}","received_events_url":"https://api.github.com/users/tmat/received_events","type":"User","site_admin":false},"body":"[Work in progress]\r\n\r\nBuild failure currently expected. Need to wait for CoreFX package baseline to move past version rc4-24217-03","created_at":"2016-06-17T16:49:38Z","updated_at":"2016-07-27T00:19:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c09be4d14fb9815849974a6394a6d1f04a42799f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/9505/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/9505/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/9505/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/8ebc73e92a8525f3a73c9f0728af1f02004fe855","head":{"label":"tmat:Tuples","ref":"Tuples","sha":"8ebc73e92a8525f3a73c9f0728af1f02004fe855","user":{"login":"tmat","id":41759,"avatar_url":"https://avatars.githubusercontent.com/u/41759?v=3","gravatar_id":"","url":"https://api.github.com/users/tmat","html_url":"https://github.com/tmat","followers_url":"https://api.github.com/users/tmat/followers","following_url":"https://api.github.com/users/tmat/following{/other_user}","gists_url":"https://api.github.com/users/tmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmat/subscriptions","organizations_url":"https://api.github.com/users/tmat/orgs","repos_url":"https://api.github.com/users/tmat/repos","events_url":"https://api.github.com/users/tmat/events{/privacy}","received_events_url":"https://api.github.com/users/tmat/received_events","type":"User","site_admin":false},"repo":{"id":33101159,"name":"corefx","full_name":"tmat/corefx","owner":{"login":"tmat","id":41759,"avatar_url":"https://avatars.githubusercontent.com/u/41759?v=3","gravatar_id":"","url":"https://api.github.com/users/tmat","html_url":"https://github.com/tmat","followers_url":"https://api.github.com/users/tmat/followers","following_url":"https://api.github.com/users/tmat/following{/other_user}","gists_url":"https://api.github.com/users/tmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmat/subscriptions","organizations_url":"https://api.github.com/users/tmat/orgs","repos_url":"https://api.github.com/users/tmat/repos","events_url":"https://api.github.com/users/tmat/events{/privacy}","received_events_url":"https://api.github.com/users/tmat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmat/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/tmat/corefx","forks_url":"https://api.github.com/repos/tmat/corefx/forks","keys_url":"https://api.github.com/repos/tmat/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmat/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmat/corefx/teams","hooks_url":"https://api.github.com/repos/tmat/corefx/hooks","issue_events_url":"https://api.github.com/repos/tmat/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/tmat/corefx/events","assignees_url":"https://api.github.com/repos/tmat/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/tmat/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/tmat/corefx/tags","blobs_url":"https://api.github.com/repos/tmat/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmat/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmat/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmat/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmat/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/tmat/corefx/languages","stargazers_url":"https://api.github.com/repos/tmat/corefx/stargazers","contributors_url":"https://api.github.com/repos/tmat/corefx/contributors","subscribers_url":"https://api.github.com/repos/tmat/corefx/subscribers","subscription_url":"https://api.github.com/repos/tmat/corefx/subscription","commits_url":"https://api.github.com/repos/tmat/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmat/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmat/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmat/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmat/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/tmat/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmat/corefx/merges","archive_url":"https://api.github.com/repos/tmat/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmat/corefx/downloads","issues_url":"https://api.github.com/repos/tmat/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/tmat/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/tmat/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/tmat/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmat/corefx/labels{/name}","releases_url":"https://api.github.com/repos/tmat/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/tmat/corefx/deployments","created_at":"2015-03-30T03:23:20Z","updated_at":"2016-02-09T00:35:08Z","pushed_at":"2016-07-26T23:48:19Z","git_url":"git://github.com/tmat/corefx.git","ssh_url":"git@github.com:tmat/corefx.git","clone_url":"https://github.com/tmat/corefx.git","svn_url":"https://github.com/tmat/corefx","homepage":"","size":76201,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"4145b96e46c76d46b910c0536c05956f91d9d5e0","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-07-26T21:21:45Z","pushed_at":"2016-07-26T23:48:20Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":122229,"stargazers_count":10288,"watchers_count":10288,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2508,"mirror_url":null,"open_issues_count":1179,"forks":2508,"open_issues":1179,"watchers":10288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/9505"},"html":{"href":"https://github.com/dotnet/corefx/pull/9505"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/9505"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/9505/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/9505/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/9505/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/8ebc73e92a8525f3a73c9f0728af1f02004fe855"}}}}
{"actor":{"display_login":"tmat"}}