{"action":"created","comment":{"url":"https://api.github.com/repos/raiden-network/raiden/pulls/comments/90890642","pull_request_review_id":11403506,"id":90890642,"diff_hunk":"@@ -262,8 +266,77 @@ def test_closewithouttransfer_settle(deposit, settle_timeout, tester_state,\n     assert tester_token.balanceOf(nettingchannel.address, sender=privatekey1) == 0\n \n \n-def test_closesingle_settle(deposit, settle_timeout, tester_channels,\n-                            tester_state, tester_events, tester_token):\n+@pytest.mark.parametrize('both_participants_deposit', [False])\n+@pytest.mark.parametrize('deposit', [100])\n+def test_closewithouttransfer_badalice(\n+        deposit,\n+        settle_timeout,\n+        tester_state,\n+        tester_events,\n+        tester_channels,\n+        tester_token):\n+    privatekeyA_raw, privatekeyB_raw, nettingchannel, channelAB, channelBA = tester_channels[0]\n+    privatekeyA = PrivateKey(privatekeyA_raw, ctx=GLOBAL_CTX, raw=True)\n+    privatekeyB = PrivateKey(privatekeyB_raw, ctx=GLOBAL_CTX, raw=True)\n+    addressA = privatekey_to_address(privatekeyA_raw)\n+    addressB = privatekey_to_address(privatekeyB_raw)\n+\n+    initial_balanceA = tester_token.balanceOf(addressA, sender=privatekeyA_raw)\n+    initial_balanceB = tester_token.balanceOf(addressB, sender=privatekeyB_raw)\n+\n+    transfer_amount = 50\n+    AB_Transfer0 = channelAB.create_directtransfer(\n+        transfer_amount,\n+        1  # TODO: fill in identifier\n+    )\n+    AB_Transfer0.sign(privatekeyA, addressA)\n+    channelAB.register_transfer(AB_Transfer0)\n+    channelBA.register_transfer(AB_Transfer0)\n+\n+    transfer_amount = 40\n+    BA_Transfer0 = channelBA.create_directtransfer(\n+        transfer_amount,\n+        1  # TODO: fill in identifier\n+    )\n+    BA_Transfer0.sign(privatekeyB, addressB)\n+    channelAB.register_transfer(BA_Transfer0)\n+    channelBA.register_transfer(BA_Transfer0)\n+    BA_Transfer0_data = str(BA_Transfer0.packed().data)\n+\n+    transfer_amount = 90\n+    AB_Transfer1 = channelAB.create_directtransfer(\n+        transfer_amount,\n+        1  # TODO: fill in identifier\n+    )\n+    AB_Transfer1.sign(privatekeyA, addressA)\n+    channelAB.register_transfer(AB_Transfer1)\n+    channelBA.register_transfer(AB_Transfer1)\n+    AB_Transfer1_data = str(AB_Transfer1.packed().data)\n+\n+    nettingchannel.closeWithoutTransfer(sender=privatekeyA_raw)\n+\n+    nettingchannel.updateTransfer(\n+        AB_Transfer1_data,\n+        BA_Transfer0_data,","path":"raiden/tests/smart_contracts/test_netting_channel.py","position":116,"original_position":116,"commit_id":"d1e9f6ac618554e0265507c5175870e6719095f5","original_commit_id":"d1e9f6ac618554e0265507c5175870e6719095f5","user":{"login":"konradkonrad","id":3705643,"avatar_url":"https://avatars.githubusercontent.com/u/3705643?v=3","gravatar_id":"","url":"https://api.github.com/users/konradkonrad","html_url":"https://github.com/konradkonrad","followers_url":"https://api.github.com/users/konradkonrad/followers","following_url":"https://api.github.com/users/konradkonrad/following{/other_user}","gists_url":"https://api.github.com/users/konradkonrad/gists{/gist_id}","starred_url":"https://api.github.com/users/konradkonrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konradkonrad/subscriptions","organizations_url":"https://api.github.com/users/konradkonrad/orgs","repos_url":"https://api.github.com/users/konradkonrad/repos","events_url":"https://api.github.com/users/konradkonrad/events{/privacy}","received_events_url":"https://api.github.com/users/konradkonrad/received_events","type":"User","site_admin":false},"body":"note, that `privatekeyB_raw` / `B` could post any transfer here, which may regress/stall the dispute process indefinitely if both parties do that.","created_at":"2016-12-05T15:45:43Z","updated_at":"2016-12-05T15:47:16Z","html_url":"https://github.com/raiden-network/raiden/pull/276#discussion_r90890642","pull_request_url":"https://api.github.com/repos/raiden-network/raiden/pulls/276","_links":{"self":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/comments/90890642"},"html":{"href":"https://github.com/raiden-network/raiden/pull/276#discussion_r90890642"},"pull_request":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/276"}}},"pull_request":{"url":"https://api.github.com/repos/raiden-network/raiden/pulls/276","id":96100685,"html_url":"https://github.com/raiden-network/raiden/pull/276","diff_url":"https://github.com/raiden-network/raiden/pull/276.diff","patch_url":"https://github.com/raiden-network/raiden/pull/276.patch","issue_url":"https://api.github.com/repos/raiden-network/raiden/issues/276","number":276,"state":"open","locked":false,"title":"Allow closing of a channel without a Raiden Transfer","user":{"login":"LefterisJP","id":1658405,"avatar_url":"https://avatars.githubusercontent.com/u/1658405?v=3","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-01T14:41:11Z","updated_at":"2016-12-05T15:47:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2703849936edc16bcbb7d3f096fe404f4e3bd3b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/raiden-network/raiden/pulls/276/commits","review_comments_url":"https://api.github.com/repos/raiden-network/raiden/pulls/276/comments","review_comment_url":"https://api.github.com/repos/raiden-network/raiden/pulls/comments{/number}","comments_url":"https://api.github.com/repos/raiden-network/raiden/issues/276/comments","statuses_url":"https://api.github.com/repos/raiden-network/raiden/statuses/d1e9f6ac618554e0265507c5175870e6719095f5","head":{"label":"LefterisJP:close_without_transfer","ref":"close_without_transfer","sha":"d1e9f6ac618554e0265507c5175870e6719095f5","user":{"login":"LefterisJP","id":1658405,"avatar_url":"https://avatars.githubusercontent.com/u/1658405?v=3","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"repo":{"id":69238217,"name":"raiden","full_name":"LefterisJP/raiden","owner":{"login":"LefterisJP","id":1658405,"avatar_url":"https://avatars.githubusercontent.com/u/1658405?v=3","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LefterisJP/raiden","description":"Raiden Network","fork":true,"url":"https://api.github.com/repos/LefterisJP/raiden","forks_url":"https://api.github.com/repos/LefterisJP/raiden/forks","keys_url":"https://api.github.com/repos/LefterisJP/raiden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LefterisJP/raiden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LefterisJP/raiden/teams","hooks_url":"https://api.github.com/repos/LefterisJP/raiden/hooks","issue_events_url":"https://api.github.com/repos/LefterisJP/raiden/issues/events{/number}","events_url":"https://api.github.com/repos/LefterisJP/raiden/events","assignees_url":"https://api.github.com/repos/LefterisJP/raiden/assignees{/user}","branches_url":"https://api.github.com/repos/LefterisJP/raiden/branches{/branch}","tags_url":"https://api.github.com/repos/LefterisJP/raiden/tags","blobs_url":"https://api.github.com/repos/LefterisJP/raiden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LefterisJP/raiden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LefterisJP/raiden/git/refs{/sha}","trees_url":"https://api.github.com/repos/LefterisJP/raiden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LefterisJP/raiden/statuses/{sha}","languages_url":"https://api.github.com/repos/LefterisJP/raiden/languages","stargazers_url":"https://api.github.com/repos/LefterisJP/raiden/stargazers","contributors_url":"https://api.github.com/repos/LefterisJP/raiden/contributors","subscribers_url":"https://api.github.com/repos/LefterisJP/raiden/subscribers","subscription_url":"https://api.github.com/repos/LefterisJP/raiden/subscription","commits_url":"https://api.github.com/repos/LefterisJP/raiden/commits{/sha}","git_commits_url":"https://api.github.com/repos/LefterisJP/raiden/git/commits{/sha}","comments_url":"https://api.github.com/repos/LefterisJP/raiden/comments{/number}","issue_comment_url":"https://api.github.com/repos/LefterisJP/raiden/issues/comments{/number}","contents_url":"https://api.github.com/repos/LefterisJP/raiden/contents/{+path}","compare_url":"https://api.github.com/repos/LefterisJP/raiden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LefterisJP/raiden/merges","archive_url":"https://api.github.com/repos/LefterisJP/raiden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LefterisJP/raiden/downloads","issues_url":"https://api.github.com/repos/LefterisJP/raiden/issues{/number}","pulls_url":"https://api.github.com/repos/LefterisJP/raiden/pulls{/number}","milestones_url":"https://api.github.com/repos/LefterisJP/raiden/milestones{/number}","notifications_url":"https://api.github.com/repos/LefterisJP/raiden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LefterisJP/raiden/labels{/name}","releases_url":"https://api.github.com/repos/LefterisJP/raiden/releases{/id}","deployments_url":"https://api.github.com/repos/LefterisJP/raiden/deployments","created_at":"2016-09-26T10:14:16Z","updated_at":"2016-09-26T10:14:18Z","pushed_at":"2016-12-05T14:50:36Z","git_url":"git://github.com/LefterisJP/raiden.git","ssh_url":"git@github.com:LefterisJP/raiden.git","clone_url":"https://github.com/LefterisJP/raiden.git","svn_url":"https://github.com/LefterisJP/raiden","homepage":null,"size":2108,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"raiden-network:master","ref":"master","sha":"6a3b40ea4c2be26c2548013074bbbb43b591c6cf","user":{"login":"raiden-network","id":19666847,"avatar_url":"https://avatars.githubusercontent.com/u/19666847?v=3","gravatar_id":"","url":"https://api.github.com/users/raiden-network","html_url":"https://github.com/raiden-network","followers_url":"https://api.github.com/users/raiden-network/followers","following_url":"https://api.github.com/users/raiden-network/following{/other_user}","gists_url":"https://api.github.com/users/raiden-network/gists{/gist_id}","starred_url":"https://api.github.com/users/raiden-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raiden-network/subscriptions","organizations_url":"https://api.github.com/users/raiden-network/orgs","repos_url":"https://api.github.com/users/raiden-network/repos","events_url":"https://api.github.com/users/raiden-network/events{/privacy}","received_events_url":"https://api.github.com/users/raiden-network/received_events","type":"Organization","site_admin":false},"repo":{"id":50646767,"name":"raiden","full_name":"raiden-network/raiden","owner":{"login":"raiden-network","id":19666847,"avatar_url":"https://avatars.githubusercontent.com/u/19666847?v=3","gravatar_id":"","url":"https://api.github.com/users/raiden-network","html_url":"https://github.com/raiden-network","followers_url":"https://api.github.com/users/raiden-network/followers","following_url":"https://api.github.com/users/raiden-network/following{/other_user}","gists_url":"https://api.github.com/users/raiden-network/gists{/gist_id}","starred_url":"https://api.github.com/users/raiden-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raiden-network/subscriptions","organizations_url":"https://api.github.com/users/raiden-network/orgs","repos_url":"https://api.github.com/users/raiden-network/repos","events_url":"https://api.github.com/users/raiden-network/events{/privacy}","received_events_url":"https://api.github.com/users/raiden-network/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/raiden-network/raiden","description":"Raiden Network","fork":false,"url":"https://api.github.com/repos/raiden-network/raiden","forks_url":"https://api.github.com/repos/raiden-network/raiden/forks","keys_url":"https://api.github.com/repos/raiden-network/raiden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raiden-network/raiden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raiden-network/raiden/teams","hooks_url":"https://api.github.com/repos/raiden-network/raiden/hooks","issue_events_url":"https://api.github.com/repos/raiden-network/raiden/issues/events{/number}","events_url":"https://api.github.com/repos/raiden-network/raiden/events","assignees_url":"https://api.github.com/repos/raiden-network/raiden/assignees{/user}","branches_url":"https://api.github.com/repos/raiden-network/raiden/branches{/branch}","tags_url":"https://api.github.com/repos/raiden-network/raiden/tags","blobs_url":"https://api.github.com/repos/raiden-network/raiden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raiden-network/raiden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raiden-network/raiden/git/refs{/sha}","trees_url":"https://api.github.com/repos/raiden-network/raiden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raiden-network/raiden/statuses/{sha}","languages_url":"https://api.github.com/repos/raiden-network/raiden/languages","stargazers_url":"https://api.github.com/repos/raiden-network/raiden/stargazers","contributors_url":"https://api.github.com/repos/raiden-network/raiden/contributors","subscribers_url":"https://api.github.com/repos/raiden-network/raiden/subscribers","subscription_url":"https://api.github.com/repos/raiden-network/raiden/subscription","commits_url":"https://api.github.com/repos/raiden-network/raiden/commits{/sha}","git_commits_url":"https://api.github.com/repos/raiden-network/raiden/git/commits{/sha}","comments_url":"https://api.github.com/repos/raiden-network/raiden/comments{/number}","issue_comment_url":"https://api.github.com/repos/raiden-network/raiden/issues/comments{/number}","contents_url":"https://api.github.com/repos/raiden-network/raiden/contents/{+path}","compare_url":"https://api.github.com/repos/raiden-network/raiden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raiden-network/raiden/merges","archive_url":"https://api.github.com/repos/raiden-network/raiden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raiden-network/raiden/downloads","issues_url":"https://api.github.com/repos/raiden-network/raiden/issues{/number}","pulls_url":"https://api.github.com/repos/raiden-network/raiden/pulls{/number}","milestones_url":"https://api.github.com/repos/raiden-network/raiden/milestones{/number}","notifications_url":"https://api.github.com/repos/raiden-network/raiden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raiden-network/raiden/labels{/name}","releases_url":"https://api.github.com/repos/raiden-network/raiden/releases{/id}","deployments_url":"https://api.github.com/repos/raiden-network/raiden/deployments","created_at":"2016-01-29T07:40:47Z","updated_at":"2016-12-04T20:45:08Z","pushed_at":"2016-12-05T14:50:37Z","git_url":"git://github.com/raiden-network/raiden.git","ssh_url":"git@github.com:raiden-network/raiden.git","clone_url":"https://github.com/raiden-network/raiden.git","svn_url":"https://github.com/raiden-network/raiden","homepage":null,"size":2396,"stargazers_count":162,"watchers_count":162,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"open_issues_count":91,"forks":31,"open_issues":91,"watchers":162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/276"},"html":{"href":"https://github.com/raiden-network/raiden/pull/276"},"issue":{"href":"https://api.github.com/repos/raiden-network/raiden/issues/276"},"comments":{"href":"https://api.github.com/repos/raiden-network/raiden/issues/276/comments"},"review_comments":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/276/comments"},"review_comment":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/276/commits"},"statuses":{"href":"https://api.github.com/repos/raiden-network/raiden/statuses/d1e9f6ac618554e0265507c5175870e6719095f5"}}}}
{"actor":{"display_login":"konradkonrad"}}