{"action":"created","comment":{"url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/comments/59471481","id":59471481,"diff_hunk":"@@ -13,9 +13,29 @@ type WrapErrorFunc func(error) interface{}\n type Transporter interface {\n \tgetDispatcher() (dispatcher, error)\n \tgetReceiver() (receiver, error)\n+\n+\t// Done returns a channel that's closed when incoming packets\n+\t// have finished processing, either due to an error or the\n+\t// underlying connection being closed. Successive calls to\n+\t// Done return the same value. This is safe to call before\n+\t// incoming packets have started processing (i.e., before\n+\t// Run() or RunAsync() has been called).\n+\tDone() <-chan struct{}\n+\n+\t// Err returns a non-nil error value after Done is closed.\n+\t// After Done is closed, successive calls to Err return the\n+\t// same value.\n+\tErr() error\n+\n+\t// IsConnected returns false when incoming packets have\n+\t// finished processing. This is exactly equivalent to checking\n+\t// if Done() is closed.\n+\t//\n+\t// TODO: Use a better name.\n+\tIsConnected() bool","path":"transport.go","position":23,"original_position":23,"commit_id":"f426622b36205ce660d5ace80b12a8b0aa9679cd","original_commit_id":"f426622b36205ce660d5ace80b12a8b0aa9679cd","user":{"login":"akalin-keybase","id":13270622,"avatar_url":"https://avatars.githubusercontent.com/u/13270622?v=3","gravatar_id":"","url":"https://api.github.com/users/akalin-keybase","html_url":"https://github.com/akalin-keybase","followers_url":"https://api.github.com/users/akalin-keybase/followers","following_url":"https://api.github.com/users/akalin-keybase/following{/other_user}","gists_url":"https://api.github.com/users/akalin-keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/akalin-keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akalin-keybase/subscriptions","organizations_url":"https://api.github.com/users/akalin-keybase/orgs","repos_url":"https://api.github.com/users/akalin-keybase/repos","events_url":"https://api.github.com/users/akalin-keybase/events{/privacy}","received_events_url":"https://api.github.com/users/akalin-keybase/received_events","type":"User","site_admin":false},"body":"I'm not wild about IsConnected() anymore, since 'connected' seems different from 'stopped processing incoming packets'. But I'll fix this later to minimize churn.","created_at":"2016-04-12T23:25:42Z","updated_at":"2016-04-12T23:25:42Z","html_url":"https://github.com/keybase/go-framed-msgpack-rpc/pull/76#discussion_r59471481","pull_request_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/76","_links":{"self":{"href":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/comments/59471481"},"html":{"href":"https://github.com/keybase/go-framed-msgpack-rpc/pull/76#discussion_r59471481"},"pull_request":{"href":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/76"}}},"pull_request":{"url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/76","id":66244222,"html_url":"https://github.com/keybase/go-framed-msgpack-rpc/pull/76","diff_url":"https://github.com/keybase/go-framed-msgpack-rpc/pull/76.diff","patch_url":"https://github.com/keybase/go-framed-msgpack-rpc/pull/76.patch","issue_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/issues/76","number":76,"state":"open","locked":false,"title":"Add Done() and Err() methods to Transport","user":{"login":"akalin-keybase","id":13270622,"avatar_url":"https://avatars.githubusercontent.com/u/13270622?v=3","gravatar_id":"","url":"https://api.github.com/users/akalin-keybase","html_url":"https://github.com/akalin-keybase","followers_url":"https://api.github.com/users/akalin-keybase/followers","following_url":"https://api.github.com/users/akalin-keybase/following{/other_user}","gists_url":"https://api.github.com/users/akalin-keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/akalin-keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akalin-keybase/subscriptions","organizations_url":"https://api.github.com/users/akalin-keybase/orgs","repos_url":"https://api.github.com/users/akalin-keybase/repos","events_url":"https://api.github.com/users/akalin-keybase/events{/privacy}","received_events_url":"https://api.github.com/users/akalin-keybase/received_events","type":"User","site_admin":false},"body":"This is a better replacement for\nAddCloseListener() than checking the return\nvalue of Run() or RunAsync(), which is also\nhard to get right.","created_at":"2016-04-12T23:23:02Z","updated_at":"2016-04-12T23:25:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b251f942ae0c21540dcc7ae280adfd9bd616aea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/76/commits","review_comments_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/76/comments","review_comment_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/issues/76/comments","statuses_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/statuses/f426622b36205ce660d5ace80b12a8b0aa9679cd","head":{"label":"keybase:transport-done","ref":"transport-done","sha":"f426622b36205ce660d5ace80b12a8b0aa9679cd","user":{"login":"keybase","id":5400834,"avatar_url":"https://avatars.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":43102191,"name":"go-framed-msgpack-rpc","full_name":"keybase/go-framed-msgpack-rpc","owner":{"login":"keybase","id":5400834,"avatar_url":"https://avatars.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keybase/go-framed-msgpack-rpc","description":"Framed RPC for go","fork":true,"url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc","forks_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/forks","keys_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/teams","hooks_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/hooks","issue_events_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/events","assignees_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/tags","blobs_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/languages","stargazers_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/stargazers","contributors_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/contributors","subscribers_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/subscribers","subscription_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/subscription","commits_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/merges","archive_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/downloads","issues_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/labels{/name}","releases_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/deployments","created_at":"2015-09-25T01:19:58Z","updated_at":"2016-01-12T18:54:09Z","pushed_at":"2016-04-12T23:23:03Z","git_url":"git://github.com/keybase/go-framed-msgpack-rpc.git","ssh_url":"git@github.com:keybase/go-framed-msgpack-rpc.git","clone_url":"https://github.com/keybase/go-framed-msgpack-rpc.git","svn_url":"https://github.com/keybase/go-framed-msgpack-rpc","homepage":null,"size":488,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"keybase:master","ref":"master","sha":"426337ec4817432e79453710902dd85f62a375b8","user":{"login":"keybase","id":5400834,"avatar_url":"https://avatars.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":43102191,"name":"go-framed-msgpack-rpc","full_name":"keybase/go-framed-msgpack-rpc","owner":{"login":"keybase","id":5400834,"avatar_url":"https://avatars.githubusercontent.com/u/5400834?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keybase/go-framed-msgpack-rpc","description":"Framed RPC for go","fork":true,"url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc","forks_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/forks","keys_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/teams","hooks_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/hooks","issue_events_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/events","assignees_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/tags","blobs_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/languages","stargazers_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/stargazers","contributors_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/contributors","subscribers_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/subscribers","subscription_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/subscription","commits_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/merges","archive_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/downloads","issues_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/labels{/name}","releases_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/deployments","created_at":"2015-09-25T01:19:58Z","updated_at":"2016-01-12T18:54:09Z","pushed_at":"2016-04-12T23:23:03Z","git_url":"git://github.com/keybase/go-framed-msgpack-rpc.git","ssh_url":"git@github.com:keybase/go-framed-msgpack-rpc.git","clone_url":"https://github.com/keybase/go-framed-msgpack-rpc.git","svn_url":"https://github.com/keybase/go-framed-msgpack-rpc","homepage":null,"size":488,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/76"},"html":{"href":"https://github.com/keybase/go-framed-msgpack-rpc/pull/76"},"issue":{"href":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/issues/76"},"comments":{"href":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/statuses/f426622b36205ce660d5ace80b12a8b0aa9679cd"}}}}