{"action":"created","comment":{"url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/comments/68463215","id":68463215,"diff_hunk":"@@ -655,7 +656,16 @@ public void setDefaultTTL(int defaultTTL) {\n                         .doOnNext(i -> insertedDataPointEvents.onNext(metric)))\n                 .doOnNext(meter::mark);\n \n-        Observable<Integer> indexUpdates = dataAccess.updateMetricsIndex(metrics)\n+        Observable<Metric<T>> updateIdxMetrics = metrics.filter(metric -> {","path":"core/metrics-core-service/src/main/java/org/hawkular/metrics/core/service/MetricsServiceImpl.java","position":75,"original_position":75,"commit_id":"72e022deb798b087d9cd0e7789c620b89b9bd3be","original_commit_id":"72e022deb798b087d9cd0e7789c620b89b9bd3be","user":{"login":"jsanda","id":168121,"avatar_url":"https://avatars.githubusercontent.com/u/168121?v=3","gravatar_id":"","url":"https://api.github.com/users/jsanda","html_url":"https://github.com/jsanda","followers_url":"https://api.github.com/users/jsanda/followers","following_url":"https://api.github.com/users/jsanda/following{/other_user}","gists_url":"https://api.github.com/users/jsanda/gists{/gist_id}","starred_url":"https://api.github.com/users/jsanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsanda/subscriptions","organizations_url":"https://api.github.com/users/jsanda/orgs","repos_url":"https://api.github.com/users/jsanda/repos","events_url":"https://api.github.com/users/jsanda/events{/privacy}","received_events_url":"https://api.github.com/users/jsanda/received_events","type":"User","site_admin":false},"body":"All of the index related work can/should be done out of band. We want to treat as an async, background task. This means a couple key changes. I would change the return statement from \r\n\r\n```return updates.mergeWith(indexUpdates)```\r\n\r\nto just\r\n\r\n```return updates```\r\n\r\nAnd then we will need to subscribe to ```indexUpdates`` (or whatever index related observables we're dealing with) separately so that the work does get performed.","created_at":"2016-06-24T21:09:23Z","updated_at":"2016-06-24T21:09:23Z","html_url":"https://github.com/hawkular/hawkular-metrics/pull/523#discussion_r68463215","pull_request_url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/523","_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/comments/68463215"},"html":{"href":"https://github.com/hawkular/hawkular-metrics/pull/523#discussion_r68463215"},"pull_request":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/523"}}},"pull_request":{"url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/523","id":75158955,"html_url":"https://github.com/hawkular/hawkular-metrics/pull/523","diff_url":"https://github.com/hawkular/hawkular-metrics/pull/523.diff","patch_url":"https://github.com/hawkular/hawkular-metrics/pull/523.patch","issue_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/523","number":523,"state":"open","locked":false,"title":"[HWKMETRICS-422] Add metrics index caches to avoid updating the metri…","user":{"login":"stefannegrea","id":3912943,"avatar_url":"https://avatars.githubusercontent.com/u/3912943?v=3","gravatar_id":"","url":"https://api.github.com/users/stefannegrea","html_url":"https://github.com/stefannegrea","followers_url":"https://api.github.com/users/stefannegrea/followers","following_url":"https://api.github.com/users/stefannegrea/following{/other_user}","gists_url":"https://api.github.com/users/stefannegrea/gists{/gist_id}","starred_url":"https://api.github.com/users/stefannegrea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefannegrea/subscriptions","organizations_url":"https://api.github.com/users/stefannegrea/orgs","repos_url":"https://api.github.com/users/stefannegrea/repos","events_url":"https://api.github.com/users/stefannegrea/events{/privacy}","received_events_url":"https://api.github.com/users/stefannegrea/received_events","type":"User","site_admin":false},"body":"…cs index if it was recently update. The max cache size in 20k items with automatica eviction of 1 hour since last read.","created_at":"2016-06-24T19:04:23Z","updated_at":"2016-06-24T21:09:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58edf3d27e853e254d106c6d5d163dadc71cabb4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/523/commits","review_comments_url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/523/comments","review_comment_url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/523/comments","statuses_url":"https://api.github.com/repos/hawkular/hawkular-metrics/statuses/72e022deb798b087d9cd0e7789c620b89b9bd3be","head":{"label":"hawkular:HWKMETRICS-422","ref":"HWKMETRICS-422","sha":"72e022deb798b087d9cd0e7789c620b89b9bd3be","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":17705626,"name":"hawkular-metrics","full_name":"hawkular/hawkular-metrics","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-metrics","description":"Time Series Metrics Engine based on Cassandra","fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-metrics","forks_url":"https://api.github.com/repos/hawkular/hawkular-metrics/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-metrics/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-metrics/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-metrics/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-metrics/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-metrics/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-metrics/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-metrics/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-metrics/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-metrics/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-metrics/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-metrics/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-metrics/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-metrics/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-metrics/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-metrics/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-metrics/releases{/id}","deployments_url":"https://api.github.com/repos/hawkular/hawkular-metrics/deployments","created_at":"2014-03-13T10:07:30Z","updated_at":"2016-06-22T06:57:49Z","pushed_at":"2016-06-24T19:45:26Z","git_url":"git://github.com/hawkular/hawkular-metrics.git","ssh_url":"git@github.com:hawkular/hawkular-metrics.git","clone_url":"https://github.com/hawkular/hawkular-metrics.git","svn_url":"https://github.com/hawkular/hawkular-metrics","homepage":"","size":17192,"stargazers_count":92,"watchers_count":92,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":13,"forks":47,"open_issues":13,"watchers":92,"default_branch":"master"}},"base":{"label":"hawkular:master","ref":"master","sha":"c141952c1775aabc7a1b2cb5edca2f4308fa4109","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":17705626,"name":"hawkular-metrics","full_name":"hawkular/hawkular-metrics","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-metrics","description":"Time Series Metrics Engine based on Cassandra","fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-metrics","forks_url":"https://api.github.com/repos/hawkular/hawkular-metrics/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-metrics/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-metrics/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-metrics/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-metrics/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-metrics/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-metrics/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-metrics/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-metrics/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-metrics/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-metrics/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-metrics/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-metrics/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-metrics/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-metrics/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-metrics/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-metrics/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-metrics/releases{/id}","deployments_url":"https://api.github.com/repos/hawkular/hawkular-metrics/deployments","created_at":"2014-03-13T10:07:30Z","updated_at":"2016-06-22T06:57:49Z","pushed_at":"2016-06-24T19:45:26Z","git_url":"git://github.com/hawkular/hawkular-metrics.git","ssh_url":"git@github.com:hawkular/hawkular-metrics.git","clone_url":"https://github.com/hawkular/hawkular-metrics.git","svn_url":"https://github.com/hawkular/hawkular-metrics","homepage":"","size":17192,"stargazers_count":92,"watchers_count":92,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":13,"forks":47,"open_issues":13,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/523"},"html":{"href":"https://github.com/hawkular/hawkular-metrics/pull/523"},"issue":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/523"},"comments":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/issues/523/comments"},"review_comments":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/523/comments"},"review_comment":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/pulls/523/commits"},"statuses":{"href":"https://api.github.com/repos/hawkular/hawkular-metrics/statuses/72e022deb798b087d9cd0e7789c620b89b9bd3be"}}}}
{"actor":{"display_login":"jsanda"}}