{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/83321863","pull_request_review_id":4174418,"id":83321863,"diff_hunk":"@@ -33,32 +33,75 @@\n <maml:uri /></dev:type>\n <dev:defaultValue>None</dev:defaultValue>\n </command:parameter>\n-<command:parameter required=\"false\" variableLength=\"true\" globbing=\"false\" pipelineInput=\"False\" position=\"named\" aliases=\"none\"><maml:name>ApplicationId</maml:name>\n-<maml:Description><maml:para>SPN\n+<command:parameter required=\"false\" variableLength=\"true\" globbing=\"false\" pipelineInput=\"False\" position=\"named\" aliases=\"none\"><maml:name>Environment</maml:name>","path":"src/ResourceManager/Profile/Commands.Profile/Microsoft.Azure.Commands.Profile.dll-Help.xml","position":24,"original_position":24,"commit_id":"ef96857354968eb0d7f4b36c5fa0cec6b6263180","original_commit_id":"ef96857354968eb0d7f4b36c5fa0cec6b6263180","user":{"login":"markcowl","id":1054056,"avatar_url":"https://avatars.githubusercontent.com/u/1054056?v=3","gravatar_id":"","url":"https://api.github.com/users/markcowl","html_url":"https://github.com/markcowl","followers_url":"https://api.github.com/users/markcowl/followers","following_url":"https://api.github.com/users/markcowl/following{/other_user}","gists_url":"https://api.github.com/users/markcowl/gists{/gist_id}","starred_url":"https://api.github.com/users/markcowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markcowl/subscriptions","organizations_url":"https://api.github.com/users/markcowl/orgs","repos_url":"https://api.github.com/users/markcowl/repos","events_url":"https://api.github.com/users/markcowl/events{/privacy}","received_events_url":"https://api.github.com/users/markcowl/received_events","type":"User","site_admin":false},"body":"We should mark this parameter as deprecated in the code of the cmdlet.  Can you add the obsolete attribute to this parameter in the cmdlet code??.  Can you put a note here that this parameter is only for backward compatibility and users shoudl use EnvironmentName instead?","created_at":"2016-10-13T22:02:03Z","updated_at":"2016-10-13T22:07:01Z","html_url":"https://github.com/Azure/azure-powershell/pull/3064#discussion_r83321863","pull_request_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/3064","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/83321863"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/3064#discussion_r83321863"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/3064"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/3064","id":88923332,"html_url":"https://github.com/Azure/azure-powershell/pull/3064","diff_url":"https://github.com/Azure/azure-powershell/pull/3064.diff","patch_url":"https://github.com/Azure/azure-powershell/pull/3064.patch","issue_url":"https://api.github.com/repos/Azure/azure-powershell/issues/3064","number":3064,"state":"open","locked":false,"title":"Update Profile help using platyPSHelp module","user":{"login":"cormacpayne","id":4462409,"avatar_url":"https://avatars.githubusercontent.com/u/4462409?v=3","gravatar_id":"","url":"https://api.github.com/users/cormacpayne","html_url":"https://github.com/cormacpayne","followers_url":"https://api.github.com/users/cormacpayne/followers","following_url":"https://api.github.com/users/cormacpayne/following{/other_user}","gists_url":"https://api.github.com/users/cormacpayne/gists{/gist_id}","starred_url":"https://api.github.com/users/cormacpayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cormacpayne/subscriptions","organizations_url":"https://api.github.com/users/cormacpayne/orgs","repos_url":"https://api.github.com/users/cormacpayne/repos","events_url":"https://api.github.com/users/cormacpayne/events{/privacy}","received_events_url":"https://api.github.com/users/cormacpayne/received_events","type":"User","site_admin":false},"body":"Fix for issue https://github.com/Azure/azure-powershell/issues/3061\r\n\r\n- Add missing help for Profile cmdlets\r\n    - Use `Validate-ServiceMarkdownHelp` to determine cmdlets missing help\r\n- Update `Add-AzureRmAccount` help with changes made in PR https://github.com/Azure/azure-powershell/pull/3042\r\n- Generate MAML so it includes changes made to markdown\r\n- Add extra check for missing parameter descriptions in `Validate-ServiceMarkdownHelp`\r\n\r\n---\r\n\r\nThis checklist is used to make sure that common issues in a pull request are covered by the creator. You can find a more complete discussion of PowerShell cmdlet best practices [here](https://msdn.microsoft.com/en-us/library/dd878270(v=vs.85).aspx).\r\n\r\nBelow in **Overall Changes**, check off the boxes that apply to your PR. For the categories that you did not check off, you can remove them from this body. Within each of the categories that you did select, make sure that you can check off **all** of the boxes. \r\n\r\nFor information on cleaning up the commits in your pull request, click [here](../documentation/cleaning-up-commits.md).\r\n\r\n## Overall Changes \r\n- [x] [**MANDATORY** - General changes](#general)\r\n- [x] [**MANDATORY** - Add/remove/edit test(s)](#tests)\r\n\r\n### General\r\n- [x] Title of the PR is clear and informative\r\n- [x] There are a small number of commits that each have an informative message\r\n- [x] If it applies, references the bug/issue that the PR fixes\r\n- [x] All files have the Microsoft copyright header\r\n- [x] Cmdlets refer to management libraries through nuget references - no dlls are checked in\r\n- [x] The PR does not introduce breaking changes (unless a major version change occurs in the assembly and module)\r\n\r\n### Tests\r\n- [x] PR includes test coverage for the included changes\r\n- [x] Tests must use xunit, and should either use Moq to mock management client calls, or use the scenario test framework\r\n- [x] PowerShell scripts used in tests must not use hard-coded values for location\r\n- [x] PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for existing resources\r\n- [x] Tests should not use App.config files for settings\r\n- [x] Tests should use the built-in PowerShell functions for generating random names when unique names are necessary - this will store names in the test recording\r\n- [x] Tests should use Start-Sleep to pause rather than Thread.Sleep","created_at":"2016-10-11T22:32:13Z","updated_at":"2016-10-13T22:07:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2015339dcf93736dd88cc811d3f97a225f502c7f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/3064/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/3064/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/issues/3064/comments","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/ef96857354968eb0d7f4b36c5fa0cec6b6263180","head":{"label":"cormacpayne:profile-help","ref":"profile-help","sha":"ef96857354968eb0d7f4b36c5fa0cec6b6263180","user":{"login":"cormacpayne","id":4462409,"avatar_url":"https://avatars.githubusercontent.com/u/4462409?v=3","gravatar_id":"","url":"https://api.github.com/users/cormacpayne","html_url":"https://github.com/cormacpayne","followers_url":"https://api.github.com/users/cormacpayne/followers","following_url":"https://api.github.com/users/cormacpayne/following{/other_user}","gists_url":"https://api.github.com/users/cormacpayne/gists{/gist_id}","starred_url":"https://api.github.com/users/cormacpayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cormacpayne/subscriptions","organizations_url":"https://api.github.com/users/cormacpayne/orgs","repos_url":"https://api.github.com/users/cormacpayne/repos","events_url":"https://api.github.com/users/cormacpayne/events{/privacy}","received_events_url":"https://api.github.com/users/cormacpayne/received_events","type":"User","site_admin":false},"repo":{"id":64254912,"name":"azure-powershell","full_name":"cormacpayne/azure-powershell","owner":{"login":"cormacpayne","id":4462409,"avatar_url":"https://avatars.githubusercontent.com/u/4462409?v=3","gravatar_id":"","url":"https://api.github.com/users/cormacpayne","html_url":"https://github.com/cormacpayne","followers_url":"https://api.github.com/users/cormacpayne/followers","following_url":"https://api.github.com/users/cormacpayne/following{/other_user}","gists_url":"https://api.github.com/users/cormacpayne/gists{/gist_id}","starred_url":"https://api.github.com/users/cormacpayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cormacpayne/subscriptions","organizations_url":"https://api.github.com/users/cormacpayne/orgs","repos_url":"https://api.github.com/users/cormacpayne/repos","events_url":"https://api.github.com/users/cormacpayne/events{/privacy}","received_events_url":"https://api.github.com/users/cormacpayne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cormacpayne/azure-powershell","description":"Microsoft Azure PowerShell","fork":true,"url":"https://api.github.com/repos/cormacpayne/azure-powershell","forks_url":"https://api.github.com/repos/cormacpayne/azure-powershell/forks","keys_url":"https://api.github.com/repos/cormacpayne/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cormacpayne/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cormacpayne/azure-powershell/teams","hooks_url":"https://api.github.com/repos/cormacpayne/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/cormacpayne/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/cormacpayne/azure-powershell/events","assignees_url":"https://api.github.com/repos/cormacpayne/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/cormacpayne/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/cormacpayne/azure-powershell/tags","blobs_url":"https://api.github.com/repos/cormacpayne/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cormacpayne/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cormacpayne/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/cormacpayne/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cormacpayne/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/cormacpayne/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/cormacpayne/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/cormacpayne/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/cormacpayne/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/cormacpayne/azure-powershell/subscription","commits_url":"https://api.github.com/repos/cormacpayne/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/cormacpayne/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/cormacpayne/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/cormacpayne/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/cormacpayne/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/cormacpayne/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cormacpayne/azure-powershell/merges","archive_url":"https://api.github.com/repos/cormacpayne/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cormacpayne/azure-powershell/downloads","issues_url":"https://api.github.com/repos/cormacpayne/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/cormacpayne/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/cormacpayne/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/cormacpayne/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cormacpayne/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/cormacpayne/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/cormacpayne/azure-powershell/deployments","created_at":"2016-07-26T21:09:37Z","updated_at":"2016-07-26T21:10:06Z","pushed_at":"2016-10-12T18:37:53Z","git_url":"git://github.com/cormacpayne/azure-powershell.git","ssh_url":"git@github.com:cormacpayne/azure-powershell.git","clone_url":"https://github.com/cormacpayne/azure-powershell.git","svn_url":"https://github.com/cormacpayne/azure-powershell","homepage":null,"size":218494,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Azure:dev","ref":"dev","sha":"7c632060885c08388a2a4a927e1bd87bcb3037b2","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":23891194,"name":"azure-powershell","full_name":"Azure/azure-powershell","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-powershell","description":"Microsoft Azure PowerShell","fork":false,"url":"https://api.github.com/repos/Azure/azure-powershell","forks_url":"https://api.github.com/repos/Azure/azure-powershell/forks","keys_url":"https://api.github.com/repos/Azure/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-powershell/teams","hooks_url":"https://api.github.com/repos/Azure/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-powershell/events","assignees_url":"https://api.github.com/repos/Azure/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-powershell/tags","blobs_url":"https://api.github.com/repos/Azure/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-powershell/subscription","commits_url":"https://api.github.com/repos/Azure/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-powershell/merges","archive_url":"https://api.github.com/repos/Azure/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-powershell/downloads","issues_url":"https://api.github.com/repos/Azure/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-powershell/deployments","created_at":"2014-09-10T20:35:18Z","updated_at":"2016-10-13T10:37:09Z","pushed_at":"2016-10-13T21:59:33Z","git_url":"git://github.com/Azure/azure-powershell.git","ssh_url":"git@github.com:Azure/azure-powershell.git","clone_url":"https://github.com/Azure/azure-powershell.git","svn_url":"https://github.com/Azure/azure-powershell","homepage":null,"size":325167,"stargazers_count":561,"watchers_count":561,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":535,"mirror_url":null,"open_issues_count":469,"forks":535,"open_issues":469,"watchers":561,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/3064"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/3064"},"issue":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/3064"},"comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/3064/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/3064/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/3064/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-powershell/statuses/ef96857354968eb0d7f4b36c5fa0cec6b6263180"}}}}
{"actor":{"display_login":"markcowl"}}