{"action":"created","issue":{"url":"https://api.github.com/repos/adventuregamestudio/ags/issues/349","repository_url":"https://api.github.com/repos/adventuregamestudio/ags","labels_url":"https://api.github.com/repos/adventuregamestudio/ags/issues/349/labels{/name}","comments_url":"https://api.github.com/repos/adventuregamestudio/ags/issues/349/comments","events_url":"https://api.github.com/repos/adventuregamestudio/ags/issues/349/events","html_url":"https://github.com/adventuregamestudio/ags/pull/349","id":171113110,"number":349,"title":"Moved stdtr1compat to a header file","user":{"login":"monkey0506","id":1878864,"avatar_url":"https://avatars.githubusercontent.com/u/1878864?v=3","gravatar_id":"","url":"https://api.github.com/users/monkey0506","html_url":"https://github.com/monkey0506","followers_url":"https://api.github.com/users/monkey0506/followers","following_url":"https://api.github.com/users/monkey0506/following{/other_user}","gists_url":"https://api.github.com/users/monkey0506/gists{/gist_id}","starred_url":"https://api.github.com/users/monkey0506/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monkey0506/subscriptions","organizations_url":"https://api.github.com/users/monkey0506/orgs","repos_url":"https://api.github.com/users/monkey0506/repos","events_url":"https://api.github.com/users/monkey0506/events{/privacy}","received_events_url":"https://api.github.com/users/monkey0506/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-15T06:01:26Z","updated_at":"2016-08-15T06:46:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/adventuregamestudio/ags/pulls/349","html_url":"https://github.com/adventuregamestudio/ags/pull/349","diff_url":"https://github.com/adventuregamestudio/ags/pull/349.diff","patch_url":"https://github.com/adventuregamestudio/ags/pull/349.patch"},"body":"Also checks for VS2015, which is the earliest version of Visual Studio which doesn't need the TR1 namespace for these headers (AFAICT)."},"comment":{"url":"https://api.github.com/repos/adventuregamestudio/ags/issues/comments/239739003","html_url":"https://github.com/adventuregamestudio/ags/pull/349#issuecomment-239739003","issue_url":"https://api.github.com/repos/adventuregamestudio/ags/issues/349","id":239739003,"user":{"login":"monkey0506","id":1878864,"avatar_url":"https://avatars.githubusercontent.com/u/1878864?v=3","gravatar_id":"","url":"https://api.github.com/users/monkey0506","html_url":"https://github.com/monkey0506","followers_url":"https://api.github.com/users/monkey0506/followers","following_url":"https://api.github.com/users/monkey0506/following{/other_user}","gists_url":"https://api.github.com/users/monkey0506/gists{/gist_id}","starred_url":"https://api.github.com/users/monkey0506/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monkey0506/subscriptions","organizations_url":"https://api.github.com/users/monkey0506/orgs","repos_url":"https://api.github.com/users/monkey0506/repos","events_url":"https://api.github.com/users/monkey0506/events{/privacy}","received_events_url":"https://api.github.com/users/monkey0506/received_events","type":"User","site_admin":false},"created_at":"2016-08-15T06:46:03Z","updated_at":"2016-08-15T06:46:03Z","body":"I would argue that this header removes complications and makes the code more readable. I also don't believe there are any plans to move away from VS2008 as the default Windows compiler in the near future, unless that has changed due to @ivan-mogilko stripping the pre-compiled libs. In any case, I think keeping the option open of compiling without C++11 as a strict enforcement is preferable for some (and Microsoft has refused thus far to implement the entire C++11 standard). Other files may also wish to include similar headers before the project files are migrated to a newer Visual Studio, and I think it would be best to not redefine \"stdtr1compat\" in every single file that needs it."}}
{"actor":{"display_login":"monkey0506"}}