{"action":"created","issue":{"url":"https://api.github.com/repos/apache/lucenenet/issues/189","repository_url":"https://api.github.com/repos/apache/lucenenet","labels_url":"https://api.github.com/repos/apache/lucenenet/issues/189/labels{/name}","comments_url":"https://api.github.com/repos/apache/lucenenet/issues/189/comments","events_url":"https://api.github.com/repos/apache/lucenenet/issues/189/events","html_url":"https://github.com/apache/lucenenet/pull/189","id":180455815,"number":189,"title":"Fixed 24 Failing Analaysis Tests + Completed CharArraySet/CharArrayMap Implementation","user":{"login":"NightOwl888","id":1538288,"avatar_url":"https://avatars.githubusercontent.com/u/1538288?v=3","gravatar_id":"","url":"https://api.github.com/users/NightOwl888","html_url":"https://github.com/NightOwl888","followers_url":"https://api.github.com/users/NightOwl888/followers","following_url":"https://api.github.com/users/NightOwl888/following{/other_user}","gists_url":"https://api.github.com/users/NightOwl888/gists{/gist_id}","starred_url":"https://api.github.com/users/NightOwl888/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NightOwl888/subscriptions","organizations_url":"https://api.github.com/users/NightOwl888/orgs","repos_url":"https://api.github.com/users/NightOwl888/repos","events_url":"https://api.github.com/users/NightOwl888/events{/privacy}","received_events_url":"https://api.github.com/users/NightOwl888/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-10-01T13:11:01Z","updated_at":"2016-10-02T14:57:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/lucenenet/pulls/189","html_url":"https://github.com/apache/lucenenet/pull/189","diff_url":"https://github.com/apache/lucenenet/pull/189.diff","patch_url":"https://github.com/apache/lucenenet/pull/189.patch"},"body":"This fixes the 23 Analysis tests that were failing all of the time, and 1 test that was failing about 10% of the time.\r\n\r\n> NOTE: This includes the commits from #185.\r\n\r\nAlso, the CharArraySet and CharArrayMap classes were refactored:\r\n\r\n1. An `ICharArrayMap` interface was introduced to allow CharArraySet to hold a reference to CharArrayMap without knowing its generic type.\r\n2. A `MapValue` class was introduced to emulate Java's ability to put an `object()` instance into a generic type, whose only purpose is to make the value non-null (since null has a special meaning and default(TValue) would break the null check anyway if we were dealing with value types).\r\n3. A `ValueCollection` class and `ValueEnumerator` class were introduced to house the logic that converts the `MapValue` to a real value, and to override the `ToString()` method to output the correct representation of the data for the tests.\r\n4. A similar `KeyCollection` and `KeyEnumerator` were introduced to break the infinite recursion between CharArraySet/CharArrayMap without consuming RAM.\r\n5. Overloads were created for all main methods of CharArrayMap and CharArraySet for `char[]`, `ICharSequence`, `string` and `object`. \r\n6. Extension methods were created for the main methods for string-able value types, converting them to strings automatically using the invariant culture.\r\n7. The generic closing type of CharArrayMap and CharArraySet was changed from object to string (similar to how it was done in Lucene.Net 3.0.3).\r\n8. Added a `CharArrayMap` class to house the static methods and public classes of `CharArrayMap<TValue>` so they can be accessed without specifying a generic class type for CharArrayMap (`CharArrayMap.Copy(x)` rather than `CharArrayMap<object>.Copy(x)`).\r\n\r\n> NOTE: I know this looks a lot like a .NET 1.0 type with all of the overloads, but I ran some experiments and determined that it is 11x - 17x faster to do have several overloads than to have a single overload (whether it is generic or object) that checks the type and takes the appropriate action."},"comment":{"url":"https://api.github.com/repos/apache/lucenenet/issues/comments/250975448","html_url":"https://github.com/apache/lucenenet/pull/189#issuecomment-250975448","issue_url":"https://api.github.com/repos/apache/lucenenet/issues/189","id":250975448,"user":{"login":"NightOwl888","id":1538288,"avatar_url":"https://avatars.githubusercontent.com/u/1538288?v=3","gravatar_id":"","url":"https://api.github.com/users/NightOwl888","html_url":"https://github.com/NightOwl888","followers_url":"https://api.github.com/users/NightOwl888/followers","following_url":"https://api.github.com/users/NightOwl888/following{/other_user}","gists_url":"https://api.github.com/users/NightOwl888/gists{/gist_id}","starred_url":"https://api.github.com/users/NightOwl888/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NightOwl888/subscriptions","organizations_url":"https://api.github.com/users/NightOwl888/orgs","repos_url":"https://api.github.com/users/NightOwl888/repos","events_url":"https://api.github.com/users/NightOwl888/events{/privacy}","received_events_url":"https://api.github.com/users/NightOwl888/received_events","type":"User","site_admin":false},"created_at":"2016-10-02T14:57:44Z","updated_at":"2016-10-02T14:57:44Z","body":"Nope, I have permissions issues:\r\n\r\n```\r\nF:\\Projects\\lucenenet>git push upstream master\r\nEnter passphrase for key '/c/Users/Shad/.ssh/id_rsa':\r\nERROR: Sorry, but @apache has blocked access to SSH keys created by some third-party applications. Your key was created before GitHub tracked keys created by applications, so we need your help.\r\n\r\nIf you personally created this key, you can approve it at:\r\n\r\n  https://github.com/settings/ssh/audit/3046281/policy\r\n\r\nOtherwise, please upload a new key:\r\n\r\n  https://github.com/settings/ssh\r\n\r\nFingerprint: 87:d3:f4:6f:df:78:25:86:fa:cf:20:1a:bc:50:56:ab\r\n\r\n[EPOLICYKEYAGE]\r\n\r\nfatal: Could not read from remote repository.\r\n\r\nPlease make sure you have the correct access rights\r\nand the repository exists.\r\n\r\n```\r\n\r\nSo I went to the URL and approved the SSH key and then...\r\n\r\n```\r\nF:\\Projects\\lucenenet>git push upstream master\r\nEnter passphrase for key '/c/Users/Shad/.ssh/id_rsa':\r\nERROR: Permission to apache/lucenenet.git denied to NightOwl888.\r\nfatal: Could not read from remote repository.\r\n\r\nPlease make sure you have the correct access rights\r\nand the repository exists.\r\n\r\n```\r\n\r\nI am pushing to the GitHub repo (mirror). When I tried to push to the Apache repo, I got:\r\n\r\n```\r\nF:\\Projects\\lucenenet>git push apache master\r\nfatal: remote error: access denied or repository not exported: /lucenenet.git\r\n```"}}
{"actor":{"display_login":"NightOwl888"}}