{"action":"created","comment":{"url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/pulls/comments/83946366","pull_request_review_id":4756571,"id":83946366,"diff_hunk":"@@ -1,6 +1,36 @@\n+/*\n+* NodeJS 4.x:\n+* * Supports CommonJS module/require\n+* * Does not support import/export\n+* * Does not support JSX (a browser-targeted feature)\n+* * Does not support destructuring or spread operators\n+*/\n module.exports = {\n   env: {\n     node: true\n   },\n-  rules: {}\n+  parserOptions: {\n+    ecmaFeatures: {\n+      globalReturn: false,\n+      jsx: false,\n+      experimentalObjectRestSpread: false\n+    },\n+    sourceType: 'script'\n+  },\n+  rules: {\n+    'arrow-body-style': 0,\n+    'block-spacing': [1, 'always'],","path":"rules/node.js","position":23,"original_position":23,"commit_id":"65945da90c8342ce6c59c0227ec7a085bfafa34e","original_commit_id":"e275927fb6e125733148f175801db9d0e1ff58f2","user":{"login":"jmanero-r7","id":8549280,"avatar_url":"https://avatars.githubusercontent.com/u/8549280?v=3","gravatar_id":"","url":"https://api.github.com/users/jmanero-r7","html_url":"https://github.com/jmanero-r7","followers_url":"https://api.github.com/users/jmanero-r7/followers","following_url":"https://api.github.com/users/jmanero-r7/following{/other_user}","gists_url":"https://api.github.com/users/jmanero-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/jmanero-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmanero-r7/subscriptions","organizations_url":"https://api.github.com/users/jmanero-r7/orgs","repos_url":"https://api.github.com/users/jmanero-r7/repos","events_url":"https://api.github.com/users/jmanero-r7/events{/privacy}","received_events_url":"https://api.github.com/users/jmanero-r7/received_events","type":"User","site_admin":false},"body":"Can you drop a link to the guide spec for this? I found https://github.com/rapid7/javascript-style-guide#18.11, which is 👍 , but I couldn't find anything about block-spacing.\r\n\r\nThis rule applies specifically to blocks (not Objects), and I think it's actually superseded by https://github.com/rapid7/javascript-style-guide#16.1, which disallows braces for single-line blocks.","created_at":"2016-10-18T20:43:20Z","updated_at":"2016-10-18T20:43:20Z","html_url":"https://github.com/rapid7/eslint-config-rapid7/pull/8#discussion_r83946366","pull_request_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/rapid7/eslint-config-rapid7/pulls/comments/83946366"},"html":{"href":"https://github.com/rapid7/eslint-config-rapid7/pull/8#discussion_r83946366"},"pull_request":{"href":"https://api.github.com/repos/rapid7/eslint-config-rapid7/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/pulls/8","id":89860341,"html_url":"https://github.com/rapid7/eslint-config-rapid7/pull/8","diff_url":"https://github.com/rapid7/eslint-config-rapid7/pull/8.diff","patch_url":"https://github.com/rapid7/eslint-config-rapid7/pull/8.patch","issue_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/issues/8","number":8,"state":"open","locked":false,"title":"Node rules","user":{"login":"jmanero-r7","id":8549280,"avatar_url":"https://avatars.githubusercontent.com/u/8549280?v=3","gravatar_id":"","url":"https://api.github.com/users/jmanero-r7","html_url":"https://github.com/jmanero-r7","followers_url":"https://api.github.com/users/jmanero-r7/followers","following_url":"https://api.github.com/users/jmanero-r7/following{/other_user}","gists_url":"https://api.github.com/users/jmanero-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/jmanero-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmanero-r7/subscriptions","organizations_url":"https://api.github.com/users/jmanero-r7/orgs","repos_url":"https://api.github.com/users/jmanero-r7/repos","events_url":"https://api.github.com/users/jmanero-r7/events{/privacy}","received_events_url":"https://api.github.com/users/jmanero-r7/received_events","type":"User","site_admin":false},"body":"* Remove JSX profile and disallow JSX\r\n* Set sourceType to script. NodeJS 4.x does not support import/export module definition\r\n* Do not require braces for one-line arrow functions, do require space inside of braces\r\n* Require 2-space indentation, UNIX line-breaks, and normalized whitespace\r\n* Require global strict mode everywhere\r\n* Require JSDoc for all functions, methods, and classes\r\n","created_at":"2016-10-18T17:17:26Z","updated_at":"2016-10-18T20:43:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de8f593bae724138e6076e3e2089679ea8d34d7c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/pulls/8/commits","review_comments_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/pulls/8/comments","review_comment_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/issues/8/comments","statuses_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/statuses/65945da90c8342ce6c59c0227ec7a085bfafa34e","head":{"label":"rapid7:node-rules","ref":"node-rules","sha":"65945da90c8342ce6c59c0227ec7a085bfafa34e","user":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"repo":{"id":58001676,"name":"eslint-config-rapid7","full_name":"rapid7/eslint-config-rapid7","owner":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rapid7/eslint-config-rapid7","description":null,"fork":false,"url":"https://api.github.com/repos/rapid7/eslint-config-rapid7","forks_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/forks","keys_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/teams","hooks_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/hooks","issue_events_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/issues/events{/number}","events_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/events","assignees_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/assignees{/user}","branches_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/branches{/branch}","tags_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/tags","blobs_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/statuses/{sha}","languages_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/languages","stargazers_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/stargazers","contributors_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/contributors","subscribers_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/subscribers","subscription_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/subscription","commits_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/contents/{+path}","compare_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/merges","archive_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/downloads","issues_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/issues{/number}","pulls_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/pulls{/number}","milestones_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/milestones{/number}","notifications_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/labels{/name}","releases_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/releases{/id}","deployments_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/deployments","created_at":"2016-05-03T21:06:43Z","updated_at":"2016-05-03T21:07:11Z","pushed_at":"2016-10-18T17:17:26Z","git_url":"git://github.com/rapid7/eslint-config-rapid7.git","ssh_url":"git@github.com:rapid7/eslint-config-rapid7.git","clone_url":"https://github.com/rapid7/eslint-config-rapid7.git","svn_url":"https://github.com/rapid7/eslint-config-rapid7","homepage":null,"size":43,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"rapid7:master","ref":"master","sha":"ca5a65dfd775bbddf422b32bb67fd7f55c8340c8","user":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"repo":{"id":58001676,"name":"eslint-config-rapid7","full_name":"rapid7/eslint-config-rapid7","owner":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rapid7/eslint-config-rapid7","description":null,"fork":false,"url":"https://api.github.com/repos/rapid7/eslint-config-rapid7","forks_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/forks","keys_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/teams","hooks_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/hooks","issue_events_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/issues/events{/number}","events_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/events","assignees_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/assignees{/user}","branches_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/branches{/branch}","tags_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/tags","blobs_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/statuses/{sha}","languages_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/languages","stargazers_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/stargazers","contributors_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/contributors","subscribers_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/subscribers","subscription_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/subscription","commits_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/contents/{+path}","compare_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/merges","archive_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/downloads","issues_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/issues{/number}","pulls_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/pulls{/number}","milestones_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/milestones{/number}","notifications_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/labels{/name}","releases_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/releases{/id}","deployments_url":"https://api.github.com/repos/rapid7/eslint-config-rapid7/deployments","created_at":"2016-05-03T21:06:43Z","updated_at":"2016-05-03T21:07:11Z","pushed_at":"2016-10-18T17:17:26Z","git_url":"git://github.com/rapid7/eslint-config-rapid7.git","ssh_url":"git@github.com:rapid7/eslint-config-rapid7.git","clone_url":"https://github.com/rapid7/eslint-config-rapid7.git","svn_url":"https://github.com/rapid7/eslint-config-rapid7","homepage":null,"size":43,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rapid7/eslint-config-rapid7/pulls/8"},"html":{"href":"https://github.com/rapid7/eslint-config-rapid7/pull/8"},"issue":{"href":"https://api.github.com/repos/rapid7/eslint-config-rapid7/issues/8"},"comments":{"href":"https://api.github.com/repos/rapid7/eslint-config-rapid7/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/rapid7/eslint-config-rapid7/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/rapid7/eslint-config-rapid7/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rapid7/eslint-config-rapid7/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/rapid7/eslint-config-rapid7/statuses/65945da90c8342ce6c59c0227ec7a085bfafa34e"}}}}
{"actor":{"display_login":"jmanero-r7"}}