{"action":"created","comment":{"url":"https://api.github.com/repos/whatwg/html/pulls/comments/83581150","pull_request_review_id":4415224,"id":83581150,"diff_hunk":"@@ -82129,6 +82163,21 @@ State: &lt;OUTPUT NAME=I>1&lt;/OUTPUT> &lt;INPUT VALUE=\"Increment\" TYPE=BUTTON O\n    and unset <var>request</var>'s <span>omit-<code>Origin</code>-header flag</span>.</p></li>\n \n    <li>\n+    <p>Create a new <span>environment</span> <var>reservedEnvironment</var>, and set its <span","path":"source","position":140,"original_position":147,"commit_id":"71eb8fa955aa7c6e4a2c5c6e96f258c78d159fe2","original_commit_id":"383e682f69054b23afeebe14116f9c27f2694ac1","user":{"login":"jungkees","id":1331169,"avatar_url":"https://avatars.githubusercontent.com/u/1331169?v=3","gravatar_id":"","url":"https://api.github.com/users/jungkees","html_url":"https://github.com/jungkees","followers_url":"https://api.github.com/users/jungkees/followers","following_url":"https://api.github.com/users/jungkees/following{/other_user}","gists_url":"https://api.github.com/users/jungkees/gists{/gist_id}","starred_url":"https://api.github.com/users/jungkees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jungkees/subscriptions","organizations_url":"https://api.github.com/users/jungkees/orgs","repos_url":"https://api.github.com/users/jungkees/repos","events_url":"https://api.github.com/users/jungkees/events{/privacy}","received_events_url":"https://api.github.com/users/jungkees/received_events","type":"User","site_admin":false},"body":"Addressed this comment: set the fields in the relevant steps instead of defining/calling an algorithm.","created_at":"2016-10-17T05:56:33Z","updated_at":"2016-10-17T05:56:33Z","html_url":"https://github.com/whatwg/html/pull/1776#discussion_r83581150","pull_request_url":"https://api.github.com/repos/whatwg/html/pulls/1776","_links":{"self":{"href":"https://api.github.com/repos/whatwg/html/pulls/comments/83581150"},"html":{"href":"https://github.com/whatwg/html/pull/1776#discussion_r83581150"},"pull_request":{"href":"https://api.github.com/repos/whatwg/html/pulls/1776"}}},"pull_request":{"url":"https://api.github.com/repos/whatwg/html/pulls/1776","id":85035175,"html_url":"https://github.com/whatwg/html/pull/1776","diff_url":"https://github.com/whatwg/html/pull/1776.diff","patch_url":"https://github.com/whatwg/html/pull/1776.patch","issue_url":"https://api.github.com/repos/whatwg/html/issues/1776","number":1776,"state":"open","locked":false,"title":"Improve navigate for service worker hooks","user":{"login":"jungkees","id":1331169,"avatar_url":"https://avatars.githubusercontent.com/u/1331169?v=3","gravatar_id":"","url":"https://api.github.com/users/jungkees","html_url":"https://github.com/jungkees","followers_url":"https://api.github.com/users/jungkees/followers","following_url":"https://api.github.com/users/jungkees/following{/other_user}","gists_url":"https://api.github.com/users/jungkees/gists{/gist_id}","starred_url":"https://api.github.com/users/jungkees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jungkees/subscriptions","organizations_url":"https://api.github.com/users/jungkees/orgs","repos_url":"https://api.github.com/users/jungkees/repos","events_url":"https://api.github.com/users/jungkees/events{/privacy}","received_events_url":"https://api.github.com/users/jungkees/received_events","type":"User","site_admin":false},"body":"Improve navigate for service worker hooks\r\n    \r\nBefore this patch, we didn't have a concept that holds reserved\r\nclient's information referenced from a service worker during a\r\nnavigation (more precisely before the actual global object and its\r\nrelevant environment settings object for the resulting resource is\r\ncreated).\r\n\r\nThis patch defines an \"environment\" concept (a supertype object of an\r\nenvironment settings object) that has its id, creation URL and target\r\nbrowsing context such that service workers' FetchEvent hanlder can\r\nreference this client information before the corresponding environmet\r\nsetings object is actually created.\r\n\r\nThe changes include:\r\n - Create an environment (a reserved client) during a navigation\r\n - Set request's reserved client id such that fetch (and Handle Fetch)\r\n can use it\r\n - Set request's target client id such that fetch (and Handle Fetch)\r\n can use it\r\n - Add Window object's active worker internal slot\r\n - Add WorkerGlobalObject's active worker internal slot\r\n - Add \"match service worker registration\" logic to attach controller\r\n\r\nRelated issue: https://github.com/w3c/ServiceWorker/issues/870\r\nCall flow: https://github.com/w3c/ServiceWorker/issues/870#issuecomment-241341776\r\nExpected behavior: https://github.com/w3c/ServiceWorker/issues/870#issuecomment-245559217\r\nRelated changes:\r\n - SW (WIP): https://github.com/w3c/ServiceWorker/commit/70baa6bac49d18b3a75364202ae56e98fe0a64a1\r\n - Fetch: https://github.com/whatwg/fetch/pull/383","created_at":"2016-09-13T12:03:29Z","updated_at":"2016-10-17T05:56:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"318eedbb08ea15841697fbed49f24177078d7a31","assignee":{"login":"jungkees","id":1331169,"avatar_url":"https://avatars.githubusercontent.com/u/1331169?v=3","gravatar_id":"","url":"https://api.github.com/users/jungkees","html_url":"https://github.com/jungkees","followers_url":"https://api.github.com/users/jungkees/followers","following_url":"https://api.github.com/users/jungkees/following{/other_user}","gists_url":"https://api.github.com/users/jungkees/gists{/gist_id}","starred_url":"https://api.github.com/users/jungkees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jungkees/subscriptions","organizations_url":"https://api.github.com/users/jungkees/orgs","repos_url":"https://api.github.com/users/jungkees/repos","events_url":"https://api.github.com/users/jungkees/events{/privacy}","received_events_url":"https://api.github.com/users/jungkees/received_events","type":"User","site_admin":false},"assignees":[{"login":"jungkees","id":1331169,"avatar_url":"https://avatars.githubusercontent.com/u/1331169?v=3","gravatar_id":"","url":"https://api.github.com/users/jungkees","html_url":"https://github.com/jungkees","followers_url":"https://api.github.com/users/jungkees/followers","following_url":"https://api.github.com/users/jungkees/following{/other_user}","gists_url":"https://api.github.com/users/jungkees/gists{/gist_id}","starred_url":"https://api.github.com/users/jungkees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jungkees/subscriptions","organizations_url":"https://api.github.com/users/jungkees/orgs","repos_url":"https://api.github.com/users/jungkees/repos","events_url":"https://api.github.com/users/jungkees/events{/privacy}","received_events_url":"https://api.github.com/users/jungkees/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/whatwg/html/pulls/1776/commits","review_comments_url":"https://api.github.com/repos/whatwg/html/pulls/1776/comments","review_comment_url":"https://api.github.com/repos/whatwg/html/pulls/comments{/number}","comments_url":"https://api.github.com/repos/whatwg/html/issues/1776/comments","statuses_url":"https://api.github.com/repos/whatwg/html/statuses/71eb8fa955aa7c6e4a2c5c6e96f258c78d159fe2","head":{"label":"jungkees:navigate-fix","ref":"navigate-fix","sha":"71eb8fa955aa7c6e4a2c5c6e96f258c78d159fe2","user":{"login":"jungkees","id":1331169,"avatar_url":"https://avatars.githubusercontent.com/u/1331169?v=3","gravatar_id":"","url":"https://api.github.com/users/jungkees","html_url":"https://github.com/jungkees","followers_url":"https://api.github.com/users/jungkees/followers","following_url":"https://api.github.com/users/jungkees/following{/other_user}","gists_url":"https://api.github.com/users/jungkees/gists{/gist_id}","starred_url":"https://api.github.com/users/jungkees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jungkees/subscriptions","organizations_url":"https://api.github.com/users/jungkees/orgs","repos_url":"https://api.github.com/users/jungkees/repos","events_url":"https://api.github.com/users/jungkees/events{/privacy}","received_events_url":"https://api.github.com/users/jungkees/received_events","type":"User","site_admin":false},"repo":{"id":41722188,"name":"html","full_name":"jungkees/html","owner":{"login":"jungkees","id":1331169,"avatar_url":"https://avatars.githubusercontent.com/u/1331169?v=3","gravatar_id":"","url":"https://api.github.com/users/jungkees","html_url":"https://github.com/jungkees","followers_url":"https://api.github.com/users/jungkees/followers","following_url":"https://api.github.com/users/jungkees/following{/other_user}","gists_url":"https://api.github.com/users/jungkees/gists{/gist_id}","starred_url":"https://api.github.com/users/jungkees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jungkees/subscriptions","organizations_url":"https://api.github.com/users/jungkees/orgs","repos_url":"https://api.github.com/users/jungkees/repos","events_url":"https://api.github.com/users/jungkees/events{/privacy}","received_events_url":"https://api.github.com/users/jungkees/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jungkees/html","description":"HTML Standard","fork":true,"url":"https://api.github.com/repos/jungkees/html","forks_url":"https://api.github.com/repos/jungkees/html/forks","keys_url":"https://api.github.com/repos/jungkees/html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jungkees/html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jungkees/html/teams","hooks_url":"https://api.github.com/repos/jungkees/html/hooks","issue_events_url":"https://api.github.com/repos/jungkees/html/issues/events{/number}","events_url":"https://api.github.com/repos/jungkees/html/events","assignees_url":"https://api.github.com/repos/jungkees/html/assignees{/user}","branches_url":"https://api.github.com/repos/jungkees/html/branches{/branch}","tags_url":"https://api.github.com/repos/jungkees/html/tags","blobs_url":"https://api.github.com/repos/jungkees/html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jungkees/html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jungkees/html/git/refs{/sha}","trees_url":"https://api.github.com/repos/jungkees/html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jungkees/html/statuses/{sha}","languages_url":"https://api.github.com/repos/jungkees/html/languages","stargazers_url":"https://api.github.com/repos/jungkees/html/stargazers","contributors_url":"https://api.github.com/repos/jungkees/html/contributors","subscribers_url":"https://api.github.com/repos/jungkees/html/subscribers","subscription_url":"https://api.github.com/repos/jungkees/html/subscription","commits_url":"https://api.github.com/repos/jungkees/html/commits{/sha}","git_commits_url":"https://api.github.com/repos/jungkees/html/git/commits{/sha}","comments_url":"https://api.github.com/repos/jungkees/html/comments{/number}","issue_comment_url":"https://api.github.com/repos/jungkees/html/issues/comments{/number}","contents_url":"https://api.github.com/repos/jungkees/html/contents/{+path}","compare_url":"https://api.github.com/repos/jungkees/html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jungkees/html/merges","archive_url":"https://api.github.com/repos/jungkees/html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jungkees/html/downloads","issues_url":"https://api.github.com/repos/jungkees/html/issues{/number}","pulls_url":"https://api.github.com/repos/jungkees/html/pulls{/number}","milestones_url":"https://api.github.com/repos/jungkees/html/milestones{/number}","notifications_url":"https://api.github.com/repos/jungkees/html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jungkees/html/labels{/name}","releases_url":"https://api.github.com/repos/jungkees/html/releases{/id}","deployments_url":"https://api.github.com/repos/jungkees/html/deployments","created_at":"2015-09-01T06:53:29Z","updated_at":"2016-04-25T11:14:44Z","pushed_at":"2016-10-17T05:47:20Z","git_url":"git://github.com/jungkees/html.git","ssh_url":"git@github.com:jungkees/html.git","clone_url":"https://github.com/jungkees/html.git","svn_url":"https://github.com/jungkees/html","homepage":"https://html.spec.whatwg.org/multipage/","size":132358,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"whatwg:master","ref":"master","sha":"adafe995c6d4f5f6df0497a534d31e51043b6750","user":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars.githubusercontent.com/u/2226336?v=3","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"repo":{"id":11969507,"name":"html","full_name":"whatwg/html","owner":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars.githubusercontent.com/u/2226336?v=3","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/whatwg/html","description":"HTML Standard","fork":false,"url":"https://api.github.com/repos/whatwg/html","forks_url":"https://api.github.com/repos/whatwg/html/forks","keys_url":"https://api.github.com/repos/whatwg/html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whatwg/html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whatwg/html/teams","hooks_url":"https://api.github.com/repos/whatwg/html/hooks","issue_events_url":"https://api.github.com/repos/whatwg/html/issues/events{/number}","events_url":"https://api.github.com/repos/whatwg/html/events","assignees_url":"https://api.github.com/repos/whatwg/html/assignees{/user}","branches_url":"https://api.github.com/repos/whatwg/html/branches{/branch}","tags_url":"https://api.github.com/repos/whatwg/html/tags","blobs_url":"https://api.github.com/repos/whatwg/html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whatwg/html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whatwg/html/git/refs{/sha}","trees_url":"https://api.github.com/repos/whatwg/html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whatwg/html/statuses/{sha}","languages_url":"https://api.github.com/repos/whatwg/html/languages","stargazers_url":"https://api.github.com/repos/whatwg/html/stargazers","contributors_url":"https://api.github.com/repos/whatwg/html/contributors","subscribers_url":"https://api.github.com/repos/whatwg/html/subscribers","subscription_url":"https://api.github.com/repos/whatwg/html/subscription","commits_url":"https://api.github.com/repos/whatwg/html/commits{/sha}","git_commits_url":"https://api.github.com/repos/whatwg/html/git/commits{/sha}","comments_url":"https://api.github.com/repos/whatwg/html/comments{/number}","issue_comment_url":"https://api.github.com/repos/whatwg/html/issues/comments{/number}","contents_url":"https://api.github.com/repos/whatwg/html/contents/{+path}","compare_url":"https://api.github.com/repos/whatwg/html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whatwg/html/merges","archive_url":"https://api.github.com/repos/whatwg/html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whatwg/html/downloads","issues_url":"https://api.github.com/repos/whatwg/html/issues{/number}","pulls_url":"https://api.github.com/repos/whatwg/html/pulls{/number}","milestones_url":"https://api.github.com/repos/whatwg/html/milestones{/number}","notifications_url":"https://api.github.com/repos/whatwg/html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whatwg/html/labels{/name}","releases_url":"https://api.github.com/repos/whatwg/html/releases{/id}","deployments_url":"https://api.github.com/repos/whatwg/html/deployments","created_at":"2013-08-08T06:26:07Z","updated_at":"2016-10-16T20:24:45Z","pushed_at":"2016-10-17T05:47:22Z","git_url":"git://github.com/whatwg/html.git","ssh_url":"git@github.com:whatwg/html.git","clone_url":"https://github.com/whatwg/html.git","svn_url":"https://github.com/whatwg/html","homepage":"https://html.spec.whatwg.org/multipage/","size":144463,"stargazers_count":832,"watchers_count":832,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":209,"mirror_url":null,"open_issues_count":369,"forks":209,"open_issues":369,"watchers":832,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/whatwg/html/pulls/1776"},"html":{"href":"https://github.com/whatwg/html/pull/1776"},"issue":{"href":"https://api.github.com/repos/whatwg/html/issues/1776"},"comments":{"href":"https://api.github.com/repos/whatwg/html/issues/1776/comments"},"review_comments":{"href":"https://api.github.com/repos/whatwg/html/pulls/1776/comments"},"review_comment":{"href":"https://api.github.com/repos/whatwg/html/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/whatwg/html/pulls/1776/commits"},"statuses":{"href":"https://api.github.com/repos/whatwg/html/statuses/71eb8fa955aa7c6e4a2c5c6e96f258c78d159fe2"}}}}
{"actor":{"display_login":"jungkees"}}