{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/comments/56798424","id":56798424,"diff_hunk":"@@ -364,8 +249,8 @@ object WorkflowDescriptor {\n   private val writeDisabled = disabledMessage(\"Write to Cache\", \"WILL NOT be cached\")\n   private val readDisabled = disabledMessage(\"Read from Cache\", \"WILL ALL be executed\")\n \n-  private def configCallCaching(conf: Config) = lookupBooleanWithDefault(conf, \"call-caching\", \"enabled\", DefaultCallCachingValue)\n-  private def lookupDockerHash(conf: Config) = lookupBooleanWithDefault(conf, \"call-caching\", \"lookup-docker-hash\", DefaultLookupDockerHash)\n+  def configCallCaching(conf: Config) = lookupBooleanWithDefault(conf, \"call-caching\", \"enabled\", DefaultCallCachingValue)\n+  def lookupDockerHash(conf: Config) = lookupBooleanWithDefault(conf, \"call-caching\", \"lookup-docker-hash\", DefaultLookupDockerHash)","path":"engine/src/main/scala/cromwell/engine/WorkflowDescriptor.scala","position":170,"original_position":170,"commit_id":"e701fca4d979f71a5377a13014f54d62bb975842","original_commit_id":"e701fca4d979f71a5377a13014f54d62bb975842","user":{"login":"gauravs90","id":13227423,"avatar_url":"https://avatars.githubusercontent.com/u/13227423?v=3","gravatar_id":"","url":"https://api.github.com/users/gauravs90","html_url":"https://github.com/gauravs90","followers_url":"https://api.github.com/users/gauravs90/followers","following_url":"https://api.github.com/users/gauravs90/following{/other_user}","gists_url":"https://api.github.com/users/gauravs90/gists{/gist_id}","starred_url":"https://api.github.com/users/gauravs90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauravs90/subscriptions","organizations_url":"https://api.github.com/users/gauravs90/orgs","repos_url":"https://api.github.com/users/gauravs90/repos","events_url":"https://api.github.com/users/gauravs90/events{/privacy}","received_events_url":"https://api.github.com/users/gauravs90/received_events","type":"User","site_admin":false},"body":"I am thinking to move this methods to the `MaterializeWorkflowDescriptorActor` (where they are being actually called). Please let me know if anyone thinks otherwise.","created_at":"2016-03-21T09:48:34Z","updated_at":"2016-03-21T09:48:34Z","html_url":"https://github.com/broadinstitute/cromwell/pull/582#discussion_r56798424","pull_request_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/582","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/comments/56798424"},"html":{"href":"https://github.com/broadinstitute/cromwell/pull/582#discussion_r56798424"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/582"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/582","id":63180958,"html_url":"https://github.com/broadinstitute/cromwell/pull/582","diff_url":"https://github.com/broadinstitute/cromwell/pull/582.diff","patch_url":"https://github.com/broadinstitute/cromwell/pull/582.patch","issue_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/582","number":582,"state":"open","locked":false,"title":"Creating WorkflowDescriptor after validation in WorkflowManagerActor. Closes #544.","user":{"login":"gauravs90","id":13227423,"avatar_url":"https://avatars.githubusercontent.com/u/13227423?v=3","gravatar_id":"","url":"https://api.github.com/users/gauravs90","html_url":"https://github.com/gauravs90","followers_url":"https://api.github.com/users/gauravs90/followers","following_url":"https://api.github.com/users/gauravs90/following{/other_user}","gists_url":"https://api.github.com/users/gauravs90/gists{/gist_id}","starred_url":"https://api.github.com/users/gauravs90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauravs90/subscriptions","organizations_url":"https://api.github.com/users/gauravs90/orgs","repos_url":"https://api.github.com/users/gauravs90/repos","events_url":"https://api.github.com/users/gauravs90/events{/privacy}","received_events_url":"https://api.github.com/users/gauravs90/received_events","type":"User","site_admin":false},"body":"Solves #544. (Might also close #568 #569 #570 )\r\nIntentions: \r\n1.) Make the erstwhile `ValidateActor` (now `MaterializeWorkflowDescriptorActor`) central to instantiating the `WorkflowDescriptor` which does so only after all validations succeed. In essence, workflow submissions now go via this route.\r\n2.) Clean up validation code from `WorkflowDescriptor.scala` (All of that code comes to the above actor)\r\n3.) WorkflowDescriptor should (ideally) be just a case class. Change relevant files where the constructors were being called (quite a lot ~3-liner changes) \r\n\r\n","created_at":"2016-03-17T07:01:21Z","updated_at":"2016-03-21T09:48:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2edbdfa860678729bbc12387bad0fd37f37d3c8d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/582/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/582/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/582/comments","statuses_url":"https://api.github.com/repos/broadinstitute/cromwell/statuses/e701fca4d979f71a5377a13014f54d62bb975842","head":{"label":"broadinstitute:gks-lazy-wfdesc#544","ref":"gks-lazy-wfdesc#544","sha":"e701fca4d979f71a5377a13014f54d62bb975842","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":34136406,"name":"cromwell","full_name":"broadinstitute/cromwell","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/cromwell","description":"Workflow Execution Engine using WDL","fork":false,"url":"https://api.github.com/repos/broadinstitute/cromwell","forks_url":"https://api.github.com/repos/broadinstitute/cromwell/forks","keys_url":"https://api.github.com/repos/broadinstitute/cromwell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/cromwell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/cromwell/teams","hooks_url":"https://api.github.com/repos/broadinstitute/cromwell/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/cromwell/events","assignees_url":"https://api.github.com/repos/broadinstitute/cromwell/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/cromwell/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/cromwell/tags","blobs_url":"https://api.github.com/repos/broadinstitute/cromwell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/cromwell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/cromwell/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/cromwell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/cromwell/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/cromwell/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/cromwell/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/cromwell/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/cromwell/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/cromwell/subscription","commits_url":"https://api.github.com/repos/broadinstitute/cromwell/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/cromwell/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/cromwell/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/cromwell/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/cromwell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/cromwell/merges","archive_url":"https://api.github.com/repos/broadinstitute/cromwell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/cromwell/downloads","issues_url":"https://api.github.com/repos/broadinstitute/cromwell/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/cromwell/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/cromwell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/cromwell/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/cromwell/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/cromwell/deployments","created_at":"2015-04-17T19:39:36Z","updated_at":"2016-03-17T20:09:43Z","pushed_at":"2016-03-21T09:20:23Z","git_url":"git://github.com/broadinstitute/cromwell.git","ssh_url":"git@github.com:broadinstitute/cromwell.git","clone_url":"https://github.com/broadinstitute/cromwell.git","svn_url":"https://github.com/broadinstitute/cromwell","homepage":"","size":5865,"stargazers_count":42,"watchers_count":42,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":38,"forks":11,"open_issues":38,"watchers":42,"default_branch":"develop"}},"base":{"label":"broadinstitute:develop","ref":"develop","sha":"284ba819c2073069e41b47ae4571e676cb9eb9ba","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":34136406,"name":"cromwell","full_name":"broadinstitute/cromwell","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/cromwell","description":"Workflow Execution Engine using WDL","fork":false,"url":"https://api.github.com/repos/broadinstitute/cromwell","forks_url":"https://api.github.com/repos/broadinstitute/cromwell/forks","keys_url":"https://api.github.com/repos/broadinstitute/cromwell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/cromwell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/cromwell/teams","hooks_url":"https://api.github.com/repos/broadinstitute/cromwell/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/cromwell/events","assignees_url":"https://api.github.com/repos/broadinstitute/cromwell/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/cromwell/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/cromwell/tags","blobs_url":"https://api.github.com/repos/broadinstitute/cromwell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/cromwell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/cromwell/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/cromwell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/cromwell/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/cromwell/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/cromwell/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/cromwell/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/cromwell/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/cromwell/subscription","commits_url":"https://api.github.com/repos/broadinstitute/cromwell/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/cromwell/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/cromwell/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/cromwell/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/cromwell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/cromwell/merges","archive_url":"https://api.github.com/repos/broadinstitute/cromwell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/cromwell/downloads","issues_url":"https://api.github.com/repos/broadinstitute/cromwell/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/cromwell/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/cromwell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/cromwell/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/cromwell/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/cromwell/deployments","created_at":"2015-04-17T19:39:36Z","updated_at":"2016-03-17T20:09:43Z","pushed_at":"2016-03-21T09:20:23Z","git_url":"git://github.com/broadinstitute/cromwell.git","ssh_url":"git@github.com:broadinstitute/cromwell.git","clone_url":"https://github.com/broadinstitute/cromwell.git","svn_url":"https://github.com/broadinstitute/cromwell","homepage":"","size":5865,"stargazers_count":42,"watchers_count":42,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":38,"forks":11,"open_issues":38,"watchers":42,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/582"},"html":{"href":"https://github.com/broadinstitute/cromwell/pull/582"},"issue":{"href":"https://api.github.com/repos/broadinstitute/cromwell/issues/582"},"comments":{"href":"https://api.github.com/repos/broadinstitute/cromwell/issues/582/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/582/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/582/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/cromwell/statuses/e701fca4d979f71a5377a13014f54d62bb975842"}}}}