{"action":"created","comment":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/89231783","pull_request_review_id":9779490,"id":89231783,"diff_hunk":"@@ -460,7 +460,7 @@ void block_cache::cache_hit(cached_piece_entry* p, void* requester, bool volatil\n \t// move into L2 (frequently used)\n \tm_lru[p->cache_state].erase(p);\n \tm_lru[target_queue].push_back(p);\n-\tp->cache_state = target_queue;\n+\tp->cache_state = std::uint16_t(target_queue);","path":"src/block_cache.cpp","position":5,"original_position":5,"commit_id":"c398b86169c6893dd08708f520da0b97edac8b2f","original_commit_id":"c398b86169c6893dd08708f520da0b97edac8b2f","user":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"body":"it seems ``target_queue`` should have the right type here.. maybe it should even be an enum class","created_at":"2016-11-22T23:19:20Z","updated_at":"2016-11-22T23:19:20Z","html_url":"https://github.com/arvidn/libtorrent/pull/1349#discussion_r89231783","pull_request_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1349","_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/89231783"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/1349#discussion_r89231783"},"pull_request":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1349"}}},"pull_request":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1349","id":94870050,"html_url":"https://github.com/arvidn/libtorrent/pull/1349","diff_url":"https://github.com/arvidn/libtorrent/pull/1349.diff","patch_url":"https://github.com/arvidn/libtorrent/pull/1349.patch","issue_url":"https://api.github.com/repos/arvidn/libtorrent/issues/1349","number":1349,"state":"open","locked":false,"title":"more integral type conversion warning fixes, now only needs shorten-64-to-32","user":{"login":"aldenml","id":143813,"avatar_url":"https://avatars.githubusercontent.com/u/143813?v=3","gravatar_id":"","url":"https://api.github.com/users/aldenml","html_url":"https://github.com/aldenml","followers_url":"https://api.github.com/users/aldenml/followers","following_url":"https://api.github.com/users/aldenml/following{/other_user}","gists_url":"https://api.github.com/users/aldenml/gists{/gist_id}","starred_url":"https://api.github.com/users/aldenml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldenml/subscriptions","organizations_url":"https://api.github.com/users/aldenml/orgs","repos_url":"https://api.github.com/users/aldenml/repos","events_url":"https://api.github.com/users/aldenml/events{/privacy}","received_events_url":"https://api.github.com/users/aldenml/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-22T18:20:51Z","updated_at":"2016-11-22T23:19:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e80379e2404b31e92e1391f70e1f40bdfb5861d7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1349/commits","review_comments_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1349/comments","review_comment_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/issues/1349/comments","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/c398b86169c6893dd08708f520da0b97edac8b2f","head":{"label":"aldenml:more-conversion-warnings-1.2","ref":"more-conversion-warnings-1.2","sha":"c398b86169c6893dd08708f520da0b97edac8b2f","user":{"login":"aldenml","id":143813,"avatar_url":"https://avatars.githubusercontent.com/u/143813?v=3","gravatar_id":"","url":"https://api.github.com/users/aldenml","html_url":"https://github.com/aldenml","followers_url":"https://api.github.com/users/aldenml/followers","following_url":"https://api.github.com/users/aldenml/following{/other_user}","gists_url":"https://api.github.com/users/aldenml/gists{/gist_id}","starred_url":"https://api.github.com/users/aldenml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldenml/subscriptions","organizations_url":"https://api.github.com/users/aldenml/orgs","repos_url":"https://api.github.com/users/aldenml/repos","events_url":"https://api.github.com/users/aldenml/events{/privacy}","received_events_url":"https://api.github.com/users/aldenml/received_events","type":"User","site_admin":false},"repo":{"id":37677407,"name":"libtorrent","full_name":"aldenml/libtorrent","owner":{"login":"aldenml","id":143813,"avatar_url":"https://avatars.githubusercontent.com/u/143813?v=3","gravatar_id":"","url":"https://api.github.com/users/aldenml","html_url":"https://github.com/aldenml","followers_url":"https://api.github.com/users/aldenml/followers","following_url":"https://api.github.com/users/aldenml/following{/other_user}","gists_url":"https://api.github.com/users/aldenml/gists{/gist_id}","starred_url":"https://api.github.com/users/aldenml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldenml/subscriptions","organizations_url":"https://api.github.com/users/aldenml/orgs","repos_url":"https://api.github.com/users/aldenml/repos","events_url":"https://api.github.com/users/aldenml/events{/privacy}","received_events_url":"https://api.github.com/users/aldenml/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aldenml/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":true,"url":"https://api.github.com/repos/aldenml/libtorrent","forks_url":"https://api.github.com/repos/aldenml/libtorrent/forks","keys_url":"https://api.github.com/repos/aldenml/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aldenml/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aldenml/libtorrent/teams","hooks_url":"https://api.github.com/repos/aldenml/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/aldenml/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/aldenml/libtorrent/events","assignees_url":"https://api.github.com/repos/aldenml/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/aldenml/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/aldenml/libtorrent/tags","blobs_url":"https://api.github.com/repos/aldenml/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aldenml/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aldenml/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/aldenml/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aldenml/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/aldenml/libtorrent/languages","stargazers_url":"https://api.github.com/repos/aldenml/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/aldenml/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/aldenml/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/aldenml/libtorrent/subscription","commits_url":"https://api.github.com/repos/aldenml/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/aldenml/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/aldenml/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/aldenml/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/aldenml/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/aldenml/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aldenml/libtorrent/merges","archive_url":"https://api.github.com/repos/aldenml/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aldenml/libtorrent/downloads","issues_url":"https://api.github.com/repos/aldenml/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/aldenml/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/aldenml/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/aldenml/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aldenml/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/aldenml/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/aldenml/libtorrent/deployments","created_at":"2015-06-18T18:31:58Z","updated_at":"2016-01-11T13:58:25Z","pushed_at":"2016-11-22T21:14:59Z","git_url":"git://github.com/aldenml/libtorrent.git","ssh_url":"git@github.com:aldenml/libtorrent.git","clone_url":"https://github.com/aldenml/libtorrent.git","svn_url":"https://github.com/aldenml/libtorrent","homepage":"http://libtorrent.org","size":43438,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arvidn:master","ref":"master","sha":"86251adb1b2f53bb2f5a14f64b411804a6392880","user":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"repo":{"id":36781769,"name":"libtorrent","full_name":"arvidn/libtorrent","owner":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arvidn/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":false,"url":"https://api.github.com/repos/arvidn/libtorrent","forks_url":"https://api.github.com/repos/arvidn/libtorrent/forks","keys_url":"https://api.github.com/repos/arvidn/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arvidn/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arvidn/libtorrent/teams","hooks_url":"https://api.github.com/repos/arvidn/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/arvidn/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/arvidn/libtorrent/events","assignees_url":"https://api.github.com/repos/arvidn/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/arvidn/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/arvidn/libtorrent/tags","blobs_url":"https://api.github.com/repos/arvidn/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arvidn/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arvidn/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/arvidn/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/arvidn/libtorrent/languages","stargazers_url":"https://api.github.com/repos/arvidn/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/arvidn/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/arvidn/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/arvidn/libtorrent/subscription","commits_url":"https://api.github.com/repos/arvidn/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/arvidn/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/arvidn/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/arvidn/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/arvidn/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arvidn/libtorrent/merges","archive_url":"https://api.github.com/repos/arvidn/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arvidn/libtorrent/downloads","issues_url":"https://api.github.com/repos/arvidn/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/arvidn/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/arvidn/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/arvidn/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arvidn/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/arvidn/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/arvidn/libtorrent/deployments","created_at":"2015-06-03T05:22:03Z","updated_at":"2016-11-22T19:34:25Z","pushed_at":"2016-11-22T21:15:00Z","git_url":"git://github.com/arvidn/libtorrent.git","ssh_url":"git@github.com:arvidn/libtorrent.git","clone_url":"https://github.com/arvidn/libtorrent.git","svn_url":"https://github.com/arvidn/libtorrent","homepage":"http://libtorrent.org","size":76615,"stargazers_count":593,"watchers_count":593,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":192,"mirror_url":null,"open_issues_count":81,"forks":192,"open_issues":81,"watchers":593,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1349"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/1349"},"issue":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/1349"},"comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/1349/comments"},"review_comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1349/comments"},"review_comment":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1349/commits"},"statuses":{"href":"https://api.github.com/repos/arvidn/libtorrent/statuses/c398b86169c6893dd08708f520da0b97edac8b2f"}}}}
{"actor":{"display_login":"arvidn"}}