{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments/56395762","id":56395762,"diff_hunk":"@@ -110,7 +126,8 @@ private void mergeItems(String type, Collection<CacheData> items) {\n         int skippedWrites = 0;\n \n         final Map<String, byte[]> hashes = getHashes(type, items);\n-        final Map<byte[], byte[]> updatedHashes = new HashMap<>();\n+\n+        final NavigableMap<byte[], byte[]> updatedHashes = new TreeMap<>(new ByteArrayComparator());","path":"cats/cats-redis/src/main/java/com/netflix/spinnaker/cats/redis/cache/RedisCache.java","position":129,"original_position":129,"commit_id":"3d5393948b45b57ef3286b69b0d53888f36eb191","original_commit_id":"3d5393948b45b57ef3286b69b0d53888f36eb191","user":{"login":"cfieber","id":301292,"avatar_url":"https://avatars.githubusercontent.com/u/301292?v=3","gravatar_id":"","url":"https://api.github.com/users/cfieber","html_url":"https://github.com/cfieber","followers_url":"https://api.github.com/users/cfieber/followers","following_url":"https://api.github.com/users/cfieber/following{/other_user}","gists_url":"https://api.github.com/users/cfieber/gists{/gist_id}","starred_url":"https://api.github.com/users/cfieber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfieber/subscriptions","organizations_url":"https://api.github.com/users/cfieber/orgs","repos_url":"https://api.github.com/users/cfieber/repos","events_url":"https://api.github.com/users/cfieber/events{/privacy}","received_events_url":"https://api.github.com/users/cfieber/received_events","type":"User","site_admin":false},"body":"Needed this sorted in order to be able to partition hmsets","created_at":"2016-03-16T19:04:49Z","updated_at":"2016-03-16T19:04:49Z","html_url":"https://github.com/spinnaker/clouddriver/pull/432#discussion_r56395762","pull_request_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/432","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments/56395762"},"html":{"href":"https://github.com/spinnaker/clouddriver/pull/432#discussion_r56395762"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/432"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/432","id":63107007,"html_url":"https://github.com/spinnaker/clouddriver/pull/432","diff_url":"https://github.com/spinnaker/clouddriver/pull/432.diff","patch_url":"https://github.com/spinnaker/clouddriver/pull/432.patch","issue_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/432","number":432,"state":"open","locked":false,"title":"Configurable partitioning for caching redis interactions.","user":{"login":"cfieber","id":301292,"avatar_url":"https://avatars.githubusercontent.com/u/301292?v=3","gravatar_id":"","url":"https://api.github.com/users/cfieber","html_url":"https://github.com/cfieber","followers_url":"https://api.github.com/users/cfieber/followers","following_url":"https://api.github.com/users/cfieber/following{/other_user}","gists_url":"https://api.github.com/users/cfieber/gists{/gist_id}","starred_url":"https://api.github.com/users/cfieber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfieber/subscriptions","organizations_url":"https://api.github.com/users/cfieber/orgs","repos_url":"https://api.github.com/users/cfieber/repos","events_url":"https://api.github.com/users/cfieber/events{/privacy}","received_events_url":"https://api.github.com/users/cfieber/received_events","type":"User","site_admin":false},"body":"Reworks redis caching configuration into a bindable bean and config prop's it under caching.redis.\r\n\r\nDon't merge yet, still doing some manual validation.\r\n\r\ncc: @ajordens @anotherchrisberry ","created_at":"2016-03-16T17:46:36Z","updated_at":"2016-03-16T19:04:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8583cf18f7c2441d6e58949fb2c85e84016d08f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/432/commits","review_comments_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/432/comments","review_comment_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/432/comments","statuses_url":"https://api.github.com/repos/spinnaker/clouddriver/statuses/3d5393948b45b57ef3286b69b0d53888f36eb191","head":{"label":"cfieber:redis_options_partition_allthethings","ref":"redis_options_partition_allthethings","sha":"3d5393948b45b57ef3286b69b0d53888f36eb191","user":{"login":"cfieber","id":301292,"avatar_url":"https://avatars.githubusercontent.com/u/301292?v=3","gravatar_id":"","url":"https://api.github.com/users/cfieber","html_url":"https://github.com/cfieber","followers_url":"https://api.github.com/users/cfieber/followers","following_url":"https://api.github.com/users/cfieber/following{/other_user}","gists_url":"https://api.github.com/users/cfieber/gists{/gist_id}","starred_url":"https://api.github.com/users/cfieber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfieber/subscriptions","organizations_url":"https://api.github.com/users/cfieber/orgs","repos_url":"https://api.github.com/users/cfieber/repos","events_url":"https://api.github.com/users/cfieber/events{/privacy}","received_events_url":"https://api.github.com/users/cfieber/received_events","type":"User","site_admin":false},"repo":{"id":46648365,"name":"clouddriver","full_name":"cfieber/clouddriver","owner":{"login":"cfieber","id":301292,"avatar_url":"https://avatars.githubusercontent.com/u/301292?v=3","gravatar_id":"","url":"https://api.github.com/users/cfieber","html_url":"https://github.com/cfieber","followers_url":"https://api.github.com/users/cfieber/followers","following_url":"https://api.github.com/users/cfieber/following{/other_user}","gists_url":"https://api.github.com/users/cfieber/gists{/gist_id}","starred_url":"https://api.github.com/users/cfieber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfieber/subscriptions","organizations_url":"https://api.github.com/users/cfieber/orgs","repos_url":"https://api.github.com/users/cfieber/repos","events_url":"https://api.github.com/users/cfieber/events{/privacy}","received_events_url":"https://api.github.com/users/cfieber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cfieber/clouddriver","description":"read and write operations across cloud providers","fork":true,"url":"https://api.github.com/repos/cfieber/clouddriver","forks_url":"https://api.github.com/repos/cfieber/clouddriver/forks","keys_url":"https://api.github.com/repos/cfieber/clouddriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfieber/clouddriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfieber/clouddriver/teams","hooks_url":"https://api.github.com/repos/cfieber/clouddriver/hooks","issue_events_url":"https://api.github.com/repos/cfieber/clouddriver/issues/events{/number}","events_url":"https://api.github.com/repos/cfieber/clouddriver/events","assignees_url":"https://api.github.com/repos/cfieber/clouddriver/assignees{/user}","branches_url":"https://api.github.com/repos/cfieber/clouddriver/branches{/branch}","tags_url":"https://api.github.com/repos/cfieber/clouddriver/tags","blobs_url":"https://api.github.com/repos/cfieber/clouddriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfieber/clouddriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfieber/clouddriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfieber/clouddriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfieber/clouddriver/statuses/{sha}","languages_url":"https://api.github.com/repos/cfieber/clouddriver/languages","stargazers_url":"https://api.github.com/repos/cfieber/clouddriver/stargazers","contributors_url":"https://api.github.com/repos/cfieber/clouddriver/contributors","subscribers_url":"https://api.github.com/repos/cfieber/clouddriver/subscribers","subscription_url":"https://api.github.com/repos/cfieber/clouddriver/subscription","commits_url":"https://api.github.com/repos/cfieber/clouddriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfieber/clouddriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfieber/clouddriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfieber/clouddriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfieber/clouddriver/contents/{+path}","compare_url":"https://api.github.com/repos/cfieber/clouddriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfieber/clouddriver/merges","archive_url":"https://api.github.com/repos/cfieber/clouddriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfieber/clouddriver/downloads","issues_url":"https://api.github.com/repos/cfieber/clouddriver/issues{/number}","pulls_url":"https://api.github.com/repos/cfieber/clouddriver/pulls{/number}","milestones_url":"https://api.github.com/repos/cfieber/clouddriver/milestones{/number}","notifications_url":"https://api.github.com/repos/cfieber/clouddriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfieber/clouddriver/labels{/name}","releases_url":"https://api.github.com/repos/cfieber/clouddriver/releases{/id}","deployments_url":"https://api.github.com/repos/cfieber/clouddriver/deployments","created_at":"2015-11-22T05:50:56Z","updated_at":"2016-01-21T19:30:30Z","pushed_at":"2016-03-16T17:45:09Z","git_url":"git://github.com/cfieber/clouddriver.git","ssh_url":"git@github.com:cfieber/clouddriver.git","clone_url":"https://github.com/cfieber/clouddriver.git","svn_url":"https://github.com/cfieber/clouddriver","homepage":null,"size":25133,"stargazers_count":1,"watchers_count":1,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"4be2377b33d64a169ffcaf65df8a77dbfd7367a6","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":37556951,"name":"clouddriver","full_name":"spinnaker/clouddriver","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/clouddriver","description":"read and write operations across cloud providers","fork":false,"url":"https://api.github.com/repos/spinnaker/clouddriver","forks_url":"https://api.github.com/repos/spinnaker/clouddriver/forks","keys_url":"https://api.github.com/repos/spinnaker/clouddriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/clouddriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/clouddriver/teams","hooks_url":"https://api.github.com/repos/spinnaker/clouddriver/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/clouddriver/events","assignees_url":"https://api.github.com/repos/spinnaker/clouddriver/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/clouddriver/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/clouddriver/tags","blobs_url":"https://api.github.com/repos/spinnaker/clouddriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/clouddriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/clouddriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/clouddriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/clouddriver/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/clouddriver/languages","stargazers_url":"https://api.github.com/repos/spinnaker/clouddriver/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/clouddriver/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/clouddriver/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/clouddriver/subscription","commits_url":"https://api.github.com/repos/spinnaker/clouddriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/clouddriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/clouddriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/clouddriver/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/clouddriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/clouddriver/merges","archive_url":"https://api.github.com/repos/spinnaker/clouddriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/clouddriver/downloads","issues_url":"https://api.github.com/repos/spinnaker/clouddriver/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/clouddriver/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/clouddriver/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/clouddriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/clouddriver/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/clouddriver/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/clouddriver/deployments","created_at":"2015-06-16T21:26:02Z","updated_at":"2016-03-15T17:08:06Z","pushed_at":"2016-03-16T18:42:14Z","git_url":"git://github.com/spinnaker/clouddriver.git","ssh_url":"git@github.com:spinnaker/clouddriver.git","clone_url":"https://github.com/spinnaker/clouddriver.git","svn_url":"https://github.com/spinnaker/clouddriver","homepage":null,"size":27216,"stargazers_count":38,"watchers_count":38,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":8,"forks":43,"open_issues":8,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/432"},"html":{"href":"https://github.com/spinnaker/clouddriver/pull/432"},"issue":{"href":"https://api.github.com/repos/spinnaker/clouddriver/issues/432"},"comments":{"href":"https://api.github.com/repos/spinnaker/clouddriver/issues/432/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/432/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/clouddriver/pulls/432/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/clouddriver/statuses/3d5393948b45b57ef3286b69b0d53888f36eb191"}}}}