{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/91949350","pull_request_review_id":12458008,"id":91949350,"diff_hunk":"@@ -1038,6 +1059,13 @@ class SparkContext(config: SparkConf) extends Logging {\n    * operation will create many references to the same object.\n    * If you plan to directly cache, sort, or aggregate Hadoop writable objects, you should first\n    * copy them using a `map` function.\n+   * @param path directory to the input data files, the path can be comma separated paths\n+   * as a list of inputs\n+   * @param minPartitions suggested minimum number of partitions for the resulting RDD\n+   * @param km implicitly found Class of the key associated with the `fm` implicit parameter","path":"core/src/main/scala/org/apache/spark/SparkContext.scala","position":117,"original_position":117,"commit_id":"dc0509c0be81a187536795b74fad7c32fae98b25","original_commit_id":"dc0509c0be81a187536795b74fad7c32fae98b25","user":{"login":"Mironor","id":480103,"avatar_url":"https://avatars.githubusercontent.com/u/480103?v=3","gravatar_id":"","url":"https://api.github.com/users/Mironor","html_url":"https://github.com/Mironor","followers_url":"https://api.github.com/users/Mironor/followers","following_url":"https://api.github.com/users/Mironor/following{/other_user}","gists_url":"https://api.github.com/users/Mironor/gists{/gist_id}","starred_url":"https://api.github.com/users/Mironor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mironor/subscriptions","organizations_url":"https://api.github.com/users/Mironor/orgs","repos_url":"https://api.github.com/users/Mironor/repos","events_url":"https://api.github.com/users/Mironor/events{/privacy}","received_events_url":"https://api.github.com/users/Mironor/received_events","type":"User","site_admin":false},"body":"I ran `build/sbt unidoc` as described [here](https://github.com/apache/spark/blob/master/docs/README.md)\r\nI got this output:\r\n```\r\n[info] 100 warnings\r\n[info] Main Java API documentation successful.\r\n```\r\nSearching `/SparkContext.scala` through warnings didn't yield any results. So I guess it's fine.\r\n\r\nThis is how it looks in Scaladoc: [https://i.imgsafe.org/ea9b9e32bb.png](https://i.imgsafe.org/ea9b9e32bb.png)\r\n\r\nScala's Scaladocs [do contain](http://www.scala-lang.org/api/current/scala/collection/immutable/List.html#sorted[B>:A](implicitord:scala.math.Ordering[B]):Repr) implicit parameters descriptions, otherwise it would be hard to understand method's signature.\r\n\r\nI hope this answers your questions, it's up to you to tell me if you want them removed or not.","created_at":"2016-12-12T13:50:15Z","updated_at":"2016-12-12T13:50:15Z","html_url":"https://github.com/apache/spark/pull/16137#discussion_r91949350","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/16137","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/91949350"},"html":{"href":"https://github.com/apache/spark/pull/16137#discussion_r91949350"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/16137"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/16137","id":96441384,"html_url":"https://github.com/apache/spark/pull/16137","diff_url":"https://github.com/apache/spark/pull/16137.diff","patch_url":"https://github.com/apache/spark/pull/16137.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/16137","number":16137,"state":"open","locked":false,"title":"[SPARK-18708][CORE] Improvement/improve docs in spark context file","user":{"login":"Mironor","id":480103,"avatar_url":"https://avatars.githubusercontent.com/u/480103?v=3","gravatar_id":"","url":"https://api.github.com/users/Mironor","html_url":"https://github.com/Mironor","followers_url":"https://api.github.com/users/Mironor/followers","following_url":"https://api.github.com/users/Mironor/following{/other_user}","gists_url":"https://api.github.com/users/Mironor/gists{/gist_id}","starred_url":"https://api.github.com/users/Mironor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mironor/subscriptions","organizations_url":"https://api.github.com/users/Mironor/orgs","repos_url":"https://api.github.com/users/Mironor/repos","events_url":"https://api.github.com/users/Mironor/events{/privacy}","received_events_url":"https://api.github.com/users/Mironor/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nSparkContext.scala was created a long time ago and contains several types of Scaladocs/Javadocs mixed together. Public methods/fields should have a Scaladoc that is formatted in the same way everywhere. This pull request also adds scaladoc to methods/fields that did not have it before.\r\n\r\n## How was this patch tested?\r\n\r\nNo actual code was modified, only comments.\r\n\r\nPlease review http://spark.apache.org/contributing.html before opening a pull request.\r\n","created_at":"2016-12-04T18:35:27Z","updated_at":"2016-12-12T13:50:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"143245492a28886e3c754d77ceee892e1be0fa1b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/16137/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/16137/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/16137/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/dc0509c0be81a187536795b74fad7c32fae98b25","head":{"label":"Mironor:improvement/improve-docs-in-spark-context-file","ref":"improvement/improve-docs-in-spark-context-file","sha":"dc0509c0be81a187536795b74fad7c32fae98b25","user":{"login":"Mironor","id":480103,"avatar_url":"https://avatars.githubusercontent.com/u/480103?v=3","gravatar_id":"","url":"https://api.github.com/users/Mironor","html_url":"https://github.com/Mironor","followers_url":"https://api.github.com/users/Mironor/followers","following_url":"https://api.github.com/users/Mironor/following{/other_user}","gists_url":"https://api.github.com/users/Mironor/gists{/gist_id}","starred_url":"https://api.github.com/users/Mironor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mironor/subscriptions","organizations_url":"https://api.github.com/users/Mironor/orgs","repos_url":"https://api.github.com/users/Mironor/repos","events_url":"https://api.github.com/users/Mironor/events{/privacy}","received_events_url":"https://api.github.com/users/Mironor/received_events","type":"User","site_admin":false},"repo":{"id":73049432,"name":"spark","full_name":"Mironor/spark","owner":{"login":"Mironor","id":480103,"avatar_url":"https://avatars.githubusercontent.com/u/480103?v=3","gravatar_id":"","url":"https://api.github.com/users/Mironor","html_url":"https://github.com/Mironor","followers_url":"https://api.github.com/users/Mironor/followers","following_url":"https://api.github.com/users/Mironor/following{/other_user}","gists_url":"https://api.github.com/users/Mironor/gists{/gist_id}","starred_url":"https://api.github.com/users/Mironor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mironor/subscriptions","organizations_url":"https://api.github.com/users/Mironor/orgs","repos_url":"https://api.github.com/users/Mironor/repos","events_url":"https://api.github.com/users/Mironor/events{/privacy}","received_events_url":"https://api.github.com/users/Mironor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mironor/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/Mironor/spark","forks_url":"https://api.github.com/repos/Mironor/spark/forks","keys_url":"https://api.github.com/repos/Mironor/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mironor/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mironor/spark/teams","hooks_url":"https://api.github.com/repos/Mironor/spark/hooks","issue_events_url":"https://api.github.com/repos/Mironor/spark/issues/events{/number}","events_url":"https://api.github.com/repos/Mironor/spark/events","assignees_url":"https://api.github.com/repos/Mironor/spark/assignees{/user}","branches_url":"https://api.github.com/repos/Mironor/spark/branches{/branch}","tags_url":"https://api.github.com/repos/Mironor/spark/tags","blobs_url":"https://api.github.com/repos/Mironor/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mironor/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mironor/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mironor/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mironor/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/Mironor/spark/languages","stargazers_url":"https://api.github.com/repos/Mironor/spark/stargazers","contributors_url":"https://api.github.com/repos/Mironor/spark/contributors","subscribers_url":"https://api.github.com/repos/Mironor/spark/subscribers","subscription_url":"https://api.github.com/repos/Mironor/spark/subscription","commits_url":"https://api.github.com/repos/Mironor/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mironor/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mironor/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mironor/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mironor/spark/contents/{+path}","compare_url":"https://api.github.com/repos/Mironor/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mironor/spark/merges","archive_url":"https://api.github.com/repos/Mironor/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mironor/spark/downloads","issues_url":"https://api.github.com/repos/Mironor/spark/issues{/number}","pulls_url":"https://api.github.com/repos/Mironor/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/Mironor/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/Mironor/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mironor/spark/labels{/name}","releases_url":"https://api.github.com/repos/Mironor/spark/releases{/id}","deployments_url":"https://api.github.com/repos/Mironor/spark/deployments","created_at":"2016-11-07T06:39:56Z","updated_at":"2016-11-07T06:40:20Z","pushed_at":"2016-12-12T09:00:41Z","git_url":"git://github.com/Mironor/spark.git","ssh_url":"git@github.com:Mironor/spark.git","clone_url":"https://github.com/Mironor/spark.git","svn_url":"https://github.com/Mironor/spark","homepage":null,"size":256584,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"83a42897ae90d84a54373db386a985e3e2d5903a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-12-12T13:10:19Z","pushed_at":"2016-12-12T13:43:43Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":622003,"stargazers_count":11046,"watchers_count":11046,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10348,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":448,"forks":10348,"open_issues":448,"watchers":11046,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/16137"},"html":{"href":"https://github.com/apache/spark/pull/16137"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/16137"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/16137/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/16137/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/16137/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/dc0509c0be81a187536795b74fad7c32fae98b25"}}}}
{"actor":{"display_login":"Mironor"}}