{"action":"created","comment":{"url":"https://api.github.com/repos/edx/configuration/pulls/comments/51316314","id":51316314,"diff_hunk":"@@ -115,6 +115,8 @@ EDXAPP_VIDEO_CDN_URLS:\n \n EDXAPP_CREDIT_HELP_LINK_URL: \"\"\n \n+EDXAPP_PARTNER_SUPPORT_EMAIL: 'partner@example.com'","path":"playbooks/roles/edxapp/defaults/main.yml","position":4,"original_position":4,"commit_id":"f25fcdd566c485a5b770a2c7e8b36018d0c0d305","original_commit_id":"f25fcdd566c485a5b770a2c7e8b36018d0c0d305","user":{"login":"stvstnfrd","id":7300975,"avatar_url":"https://avatars.githubusercontent.com/u/7300975?v=3","gravatar_id":"","url":"https://api.github.com/users/stvstnfrd","html_url":"https://github.com/stvstnfrd","followers_url":"https://api.github.com/users/stvstnfrd/followers","following_url":"https://api.github.com/users/stvstnfrd/following{/other_user}","gists_url":"https://api.github.com/users/stvstnfrd/gists{/gist_id}","starred_url":"https://api.github.com/users/stvstnfrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stvstnfrd/subscriptions","organizations_url":"https://api.github.com/users/stvstnfrd/orgs","repos_url":"https://api.github.com/users/stvstnfrd/repos","events_url":"https://api.github.com/users/stvstnfrd/events{/privacy}","received_events_url":"https://api.github.com/users/stvstnfrd/received_events","type":"User","site_admin":false},"body":"Actually, looking at how this is used in platform, I don't think this is what we want. Platform code enables this if the key is present, disables it otherwise.\r\n\r\nPerhaps a better approach would be to default to `None` in configuration and then update platform to check for a Truthy value, instead of presence of the key?","created_at":"2016-01-29T21:11:39Z","updated_at":"2016-01-29T21:11:39Z","html_url":"https://github.com/edx/configuration/pull/2743#discussion_r51316314","pull_request_url":"https://api.github.com/repos/edx/configuration/pulls/2743","_links":{"self":{"href":"https://api.github.com/repos/edx/configuration/pulls/comments/51316314"},"html":{"href":"https://github.com/edx/configuration/pull/2743#discussion_r51316314"},"pull_request":{"href":"https://api.github.com/repos/edx/configuration/pulls/2743"}}},"pull_request":{"url":"https://api.github.com/repos/edx/configuration/pulls/2743","id":57702189,"html_url":"https://github.com/edx/configuration/pull/2743","diff_url":"https://github.com/edx/configuration/pull/2743.diff","patch_url":"https://github.com/edx/configuration/pull/2743.patch","issue_url":"https://api.github.com/repos/edx/configuration/issues/2743","number":2743,"state":"open","locked":false,"title":"Add PARTNER_SUPPORT_EMAIL in default FEATURES","user":{"login":"caesar2164","id":3364609,"avatar_url":"https://avatars.githubusercontent.com/u/3364609?v=3","gravatar_id":"","url":"https://api.github.com/users/caesar2164","html_url":"https://github.com/caesar2164","followers_url":"https://api.github.com/users/caesar2164/followers","following_url":"https://api.github.com/users/caesar2164/following{/other_user}","gists_url":"https://api.github.com/users/caesar2164/gists{/gist_id}","starred_url":"https://api.github.com/users/caesar2164/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesar2164/subscriptions","organizations_url":"https://api.github.com/users/caesar2164/orgs","repos_url":"https://api.github.com/users/caesar2164/repos","events_url":"https://api.github.com/users/caesar2164/events{/privacy}","received_events_url":"https://api.github.com/users/caesar2164/received_events","type":"User","site_admin":false},"body":"PARTNER_SUPPORT_EMAIL gets used to display contact email for Studio support","created_at":"2016-01-29T21:01:37Z","updated_at":"2016-01-29T21:11:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a8d3431059eeda3a6c86198dd126bbecafbf96b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/configuration/pulls/2743/commits","review_comments_url":"https://api.github.com/repos/edx/configuration/pulls/2743/comments","review_comment_url":"https://api.github.com/repos/edx/configuration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/configuration/issues/2743/comments","statuses_url":"https://api.github.com/repos/edx/configuration/statuses/f25fcdd566c485a5b770a2c7e8b36018d0c0d305","head":{"label":"Stanford-Online:giulio/add-partner-support-email-upstream","ref":"giulio/add-partner-support-email-upstream","sha":"f25fcdd566c485a5b770a2c7e8b36018d0c0d305","user":{"login":"Stanford-Online","id":2159497,"avatar_url":"https://avatars.githubusercontent.com/u/2159497?v=3","gravatar_id":"","url":"https://api.github.com/users/Stanford-Online","html_url":"https://github.com/Stanford-Online","followers_url":"https://api.github.com/users/Stanford-Online/followers","following_url":"https://api.github.com/users/Stanford-Online/following{/other_user}","gists_url":"https://api.github.com/users/Stanford-Online/gists{/gist_id}","starred_url":"https://api.github.com/users/Stanford-Online/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stanford-Online/subscriptions","organizations_url":"https://api.github.com/users/Stanford-Online/orgs","repos_url":"https://api.github.com/users/Stanford-Online/repos","events_url":"https://api.github.com/users/Stanford-Online/events{/privacy}","received_events_url":"https://api.github.com/users/Stanford-Online/received_events","type":"Organization","site_admin":false},"repo":{"id":20904958,"name":"configuration","full_name":"Stanford-Online/configuration","owner":{"login":"Stanford-Online","id":2159497,"avatar_url":"https://avatars.githubusercontent.com/u/2159497?v=3","gravatar_id":"","url":"https://api.github.com/users/Stanford-Online","html_url":"https://github.com/Stanford-Online","followers_url":"https://api.github.com/users/Stanford-Online/followers","following_url":"https://api.github.com/users/Stanford-Online/following{/other_user}","gists_url":"https://api.github.com/users/Stanford-Online/gists{/gist_id}","starred_url":"https://api.github.com/users/Stanford-Online/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stanford-Online/subscriptions","organizations_url":"https://api.github.com/users/Stanford-Online/orgs","repos_url":"https://api.github.com/users/Stanford-Online/repos","events_url":"https://api.github.com/users/Stanford-Online/events{/privacy}","received_events_url":"https://api.github.com/users/Stanford-Online/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Stanford-Online/configuration","description":"a simple, but flexible, way for anyone to stand up an instance of the edX platform that is fully configured and ready-to-go","fork":true,"url":"https://api.github.com/repos/Stanford-Online/configuration","forks_url":"https://api.github.com/repos/Stanford-Online/configuration/forks","keys_url":"https://api.github.com/repos/Stanford-Online/configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Stanford-Online/configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Stanford-Online/configuration/teams","hooks_url":"https://api.github.com/repos/Stanford-Online/configuration/hooks","issue_events_url":"https://api.github.com/repos/Stanford-Online/configuration/issues/events{/number}","events_url":"https://api.github.com/repos/Stanford-Online/configuration/events","assignees_url":"https://api.github.com/repos/Stanford-Online/configuration/assignees{/user}","branches_url":"https://api.github.com/repos/Stanford-Online/configuration/branches{/branch}","tags_url":"https://api.github.com/repos/Stanford-Online/configuration/tags","blobs_url":"https://api.github.com/repos/Stanford-Online/configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Stanford-Online/configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Stanford-Online/configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/Stanford-Online/configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Stanford-Online/configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/Stanford-Online/configuration/languages","stargazers_url":"https://api.github.com/repos/Stanford-Online/configuration/stargazers","contributors_url":"https://api.github.com/repos/Stanford-Online/configuration/contributors","subscribers_url":"https://api.github.com/repos/Stanford-Online/configuration/subscribers","subscription_url":"https://api.github.com/repos/Stanford-Online/configuration/subscription","commits_url":"https://api.github.com/repos/Stanford-Online/configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/Stanford-Online/configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/Stanford-Online/configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/Stanford-Online/configuration/issues/comments{/number}","contents_url":"https://api.github.com/repos/Stanford-Online/configuration/contents/{+path}","compare_url":"https://api.github.com/repos/Stanford-Online/configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Stanford-Online/configuration/merges","archive_url":"https://api.github.com/repos/Stanford-Online/configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Stanford-Online/configuration/downloads","issues_url":"https://api.github.com/repos/Stanford-Online/configuration/issues{/number}","pulls_url":"https://api.github.com/repos/Stanford-Online/configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/Stanford-Online/configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/Stanford-Online/configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Stanford-Online/configuration/labels{/name}","releases_url":"https://api.github.com/repos/Stanford-Online/configuration/releases{/id}","deployments_url":"https://api.github.com/repos/Stanford-Online/configuration/deployments","created_at":"2014-06-17T00:24:26Z","updated_at":"2016-01-13T21:14:11Z","pushed_at":"2016-01-29T21:03:33Z","git_url":"git://github.com/Stanford-Online/configuration.git","ssh_url":"git@github.com:Stanford-Online/configuration.git","clone_url":"https://github.com/Stanford-Online/configuration.git","svn_url":"https://github.com/Stanford-Online/configuration","homepage":"","size":9227,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"30bac9d91d5175306de7edf6713883f044dc2009","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":9478219,"name":"configuration","full_name":"edx/configuration","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/configuration","description":"a simple, but flexible, way for anyone to stand up an instance of the edX platform that is fully configured and ready-to-go","fork":false,"url":"https://api.github.com/repos/edx/configuration","forks_url":"https://api.github.com/repos/edx/configuration/forks","keys_url":"https://api.github.com/repos/edx/configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/configuration/teams","hooks_url":"https://api.github.com/repos/edx/configuration/hooks","issue_events_url":"https://api.github.com/repos/edx/configuration/issues/events{/number}","events_url":"https://api.github.com/repos/edx/configuration/events","assignees_url":"https://api.github.com/repos/edx/configuration/assignees{/user}","branches_url":"https://api.github.com/repos/edx/configuration/branches{/branch}","tags_url":"https://api.github.com/repos/edx/configuration/tags","blobs_url":"https://api.github.com/repos/edx/configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/configuration/languages","stargazers_url":"https://api.github.com/repos/edx/configuration/stargazers","contributors_url":"https://api.github.com/repos/edx/configuration/contributors","subscribers_url":"https://api.github.com/repos/edx/configuration/subscribers","subscription_url":"https://api.github.com/repos/edx/configuration/subscription","commits_url":"https://api.github.com/repos/edx/configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/configuration/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/configuration/contents/{+path}","compare_url":"https://api.github.com/repos/edx/configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/configuration/merges","archive_url":"https://api.github.com/repos/edx/configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/configuration/downloads","issues_url":"https://api.github.com/repos/edx/configuration/issues{/number}","pulls_url":"https://api.github.com/repos/edx/configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/configuration/labels{/name}","releases_url":"https://api.github.com/repos/edx/configuration/releases{/id}","deployments_url":"https://api.github.com/repos/edx/configuration/deployments","created_at":"2013-04-16T17:23:42Z","updated_at":"2016-01-27T15:25:33Z","pushed_at":"2016-01-29T21:03:33Z","git_url":"git://github.com/edx/configuration.git","ssh_url":"git@github.com:edx/configuration.git","clone_url":"https://github.com/edx/configuration.git","svn_url":"https://github.com/edx/configuration","homepage":"","size":10596,"stargazers_count":480,"watchers_count":480,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":441,"mirror_url":null,"open_issues_count":114,"forks":441,"open_issues":114,"watchers":480,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/configuration/pulls/2743"},"html":{"href":"https://github.com/edx/configuration/pull/2743"},"issue":{"href":"https://api.github.com/repos/edx/configuration/issues/2743"},"comments":{"href":"https://api.github.com/repos/edx/configuration/issues/2743/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/configuration/pulls/2743/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/configuration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/configuration/pulls/2743/commits"},"statuses":{"href":"https://api.github.com/repos/edx/configuration/statuses/f25fcdd566c485a5b770a2c7e8b36018d0c0d305"}}}}