{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/comments/93338979","pull_request_review_id":13864640,"id":93338979,"diff_hunk":"@@ -73,19 +84,28 @@ func main() {\n \tusage := fmt.Sprintf(`%s.\n \n   Usage:\n-  %s [--no-publish --sources=<sources> --label-whitelist=<pattern>]\n+  %s [--sources=<sources>] [--resource-types=<rtypes>]\n+\t    [--label-whitelist=<pattern>] [--resource-whitelist=<pattern>]\n+      [--no-publish]","path":"main.go","position":52,"original_position":52,"commit_id":"c9bdc8cc8c5173298d10318305240831156407dd","original_commit_id":"c9bdc8cc8c5173298d10318305240831156407dd","user":{"login":"ConnorDoyle","id":379372,"avatar_url":"https://avatars.githubusercontent.com/u/379372?v=3","gravatar_id":"","url":"https://api.github.com/users/ConnorDoyle","html_url":"https://github.com/ConnorDoyle","followers_url":"https://api.github.com/users/ConnorDoyle/followers","following_url":"https://api.github.com/users/ConnorDoyle/following{/other_user}","gists_url":"https://api.github.com/users/ConnorDoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnorDoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnorDoyle/subscriptions","organizations_url":"https://api.github.com/users/ConnorDoyle/orgs","repos_url":"https://api.github.com/users/ConnorDoyle/repos","events_url":"https://api.github.com/users/ConnorDoyle/events{/privacy}","received_events_url":"https://api.github.com/users/ConnorDoyle/received_events","type":"User","site_admin":false},"body":"Looks like the go plugin for my editor may have snuck in some tabs, will fix","created_at":"2016-12-20T22:26:58Z","updated_at":"2016-12-20T22:26:59Z","html_url":"https://github.com/kubernetes-incubator/node-feature-discovery/pull/61#discussion_r93338979","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/comments/93338979"},"html":{"href":"https://github.com/kubernetes-incubator/node-feature-discovery/pull/61#discussion_r93338979"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/61","id":97648751,"html_url":"https://github.com/kubernetes-incubator/node-feature-discovery/pull/61","diff_url":"https://github.com/kubernetes-incubator/node-feature-discovery/pull/61.diff","patch_url":"https://github.com/kubernetes-incubator/node-feature-discovery/pull/61.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/issues/61","number":61,"state":"open","locked":false,"title":"[WIP] Implemented opaque resource discovery.","user":{"login":"ConnorDoyle","id":379372,"avatar_url":"https://avatars.githubusercontent.com/u/379372?v=3","gravatar_id":"","url":"https://api.github.com/users/ConnorDoyle","html_url":"https://github.com/ConnorDoyle","followers_url":"https://api.github.com/users/ConnorDoyle/followers","following_url":"https://api.github.com/users/ConnorDoyle/following{/other_user}","gists_url":"https://api.github.com/users/ConnorDoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnorDoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnorDoyle/subscriptions","organizations_url":"https://api.github.com/users/ConnorDoyle/orgs","repos_url":"https://api.github.com/users/ConnorDoyle/repos","events_url":"https://api.github.com/users/ConnorDoyle/events{/privacy}","received_events_url":"https://api.github.com/users/ConnorDoyle/received_events","type":"User","site_admin":false},"body":"This is just a sketch of the feature so far.\r\n\r\nIt's missing:\r\n\r\n- [ ] Alignment w/ resource management roadmap\r\n- [ ] Testing\r\n- [ ] Docs","created_at":"2016-12-12T22:35:44Z","updated_at":"2016-12-20T22:26:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e50e2aeef45fa3d894169eb658b551b52f839bf9","assignee":{"login":"balajismaniam","id":4707353,"avatar_url":"https://avatars.githubusercontent.com/u/4707353?v=3","gravatar_id":"","url":"https://api.github.com/users/balajismaniam","html_url":"https://github.com/balajismaniam","followers_url":"https://api.github.com/users/balajismaniam/followers","following_url":"https://api.github.com/users/balajismaniam/following{/other_user}","gists_url":"https://api.github.com/users/balajismaniam/gists{/gist_id}","starred_url":"https://api.github.com/users/balajismaniam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balajismaniam/subscriptions","organizations_url":"https://api.github.com/users/balajismaniam/orgs","repos_url":"https://api.github.com/users/balajismaniam/repos","events_url":"https://api.github.com/users/balajismaniam/events{/privacy}","received_events_url":"https://api.github.com/users/balajismaniam/received_events","type":"User","site_admin":false},"assignees":[{"login":"balajismaniam","id":4707353,"avatar_url":"https://avatars.githubusercontent.com/u/4707353?v=3","gravatar_id":"","url":"https://api.github.com/users/balajismaniam","html_url":"https://github.com/balajismaniam","followers_url":"https://api.github.com/users/balajismaniam/followers","following_url":"https://api.github.com/users/balajismaniam/following{/other_user}","gists_url":"https://api.github.com/users/balajismaniam/gists{/gist_id}","starred_url":"https://api.github.com/users/balajismaniam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balajismaniam/subscriptions","organizations_url":"https://api.github.com/users/balajismaniam/orgs","repos_url":"https://api.github.com/users/balajismaniam/repos","events_url":"https://api.github.com/users/balajismaniam/events{/privacy}","received_events_url":"https://api.github.com/users/balajismaniam/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/61/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/61/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/issues/61/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/statuses/c9bdc8cc8c5173298d10318305240831156407dd","head":{"label":"ConnorDoyle:discover-oir","ref":"discover-oir","sha":"c9bdc8cc8c5173298d10318305240831156407dd","user":{"login":"ConnorDoyle","id":379372,"avatar_url":"https://avatars.githubusercontent.com/u/379372?v=3","gravatar_id":"","url":"https://api.github.com/users/ConnorDoyle","html_url":"https://github.com/ConnorDoyle","followers_url":"https://api.github.com/users/ConnorDoyle/followers","following_url":"https://api.github.com/users/ConnorDoyle/following{/other_user}","gists_url":"https://api.github.com/users/ConnorDoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnorDoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnorDoyle/subscriptions","organizations_url":"https://api.github.com/users/ConnorDoyle/orgs","repos_url":"https://api.github.com/users/ConnorDoyle/repos","events_url":"https://api.github.com/users/ConnorDoyle/events{/privacy}","received_events_url":"https://api.github.com/users/ConnorDoyle/received_events","type":"User","site_admin":false},"repo":{"id":66910035,"name":"node-feature-discovery","full_name":"ConnorDoyle/node-feature-discovery","owner":{"login":"ConnorDoyle","id":379372,"avatar_url":"https://avatars.githubusercontent.com/u/379372?v=3","gravatar_id":"","url":"https://api.github.com/users/ConnorDoyle","html_url":"https://github.com/ConnorDoyle","followers_url":"https://api.github.com/users/ConnorDoyle/followers","following_url":"https://api.github.com/users/ConnorDoyle/following{/other_user}","gists_url":"https://api.github.com/users/ConnorDoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnorDoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnorDoyle/subscriptions","organizations_url":"https://api.github.com/users/ConnorDoyle/orgs","repos_url":"https://api.github.com/users/ConnorDoyle/repos","events_url":"https://api.github.com/users/ConnorDoyle/events{/privacy}","received_events_url":"https://api.github.com/users/ConnorDoyle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ConnorDoyle/node-feature-discovery","description":"Node feature discovery for Kubernetes","fork":true,"url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery","forks_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/forks","keys_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/teams","hooks_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/hooks","issue_events_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/issues/events{/number}","events_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/events","assignees_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/assignees{/user}","branches_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/branches{/branch}","tags_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/tags","blobs_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/git/refs{/sha}","trees_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/statuses/{sha}","languages_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/languages","stargazers_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/stargazers","contributors_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/contributors","subscribers_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/subscribers","subscription_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/subscription","commits_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/commits{/sha}","git_commits_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/git/commits{/sha}","comments_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/comments{/number}","issue_comment_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/issues/comments{/number}","contents_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/contents/{+path}","compare_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/merges","archive_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/downloads","issues_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/issues{/number}","pulls_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/pulls{/number}","milestones_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/milestones{/number}","notifications_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/labels{/name}","releases_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/releases{/id}","deployments_url":"https://api.github.com/repos/ConnorDoyle/node-feature-discovery/deployments","created_at":"2016-08-30T05:38:44Z","updated_at":"2016-08-31T00:29:20Z","pushed_at":"2016-12-12T22:48:41Z","git_url":"git://github.com/ConnorDoyle/node-feature-discovery.git","ssh_url":"git@github.com:ConnorDoyle/node-feature-discovery.git","clone_url":"https://github.com/ConnorDoyle/node-feature-discovery.git","svn_url":"https://github.com/ConnorDoyle/node-feature-discovery","homepage":"","size":74364,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:discover-opaque-resources","ref":"discover-opaque-resources","sha":"675d8aa24a7336906a9cc1f710fc9275a734a7d5","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":63999998,"name":"node-feature-discovery","full_name":"kubernetes-incubator/node-feature-discovery","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/node-feature-discovery","description":"Node feature discovery for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery","forks_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/deployments","created_at":"2016-07-23T05:07:52Z","updated_at":"2016-12-17T14:37:51Z","pushed_at":"2016-12-19T22:46:23Z","git_url":"git://github.com/kubernetes-incubator/node-feature-discovery.git","ssh_url":"git@github.com:kubernetes-incubator/node-feature-discovery.git","clone_url":"https://github.com/kubernetes-incubator/node-feature-discovery.git","svn_url":"https://github.com/kubernetes-incubator/node-feature-discovery","homepage":"","size":74372,"stargazers_count":34,"watchers_count":34,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":13,"forks":10,"open_issues":13,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/61"},"html":{"href":"https://github.com/kubernetes-incubator/node-feature-discovery/pull/61"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/issues/61"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/node-feature-discovery/statuses/c9bdc8cc8c5173298d10318305240831156407dd"}}}}
{"actor":{"display_login":"ConnorDoyle"}}