{"action":"created","comment":{"url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/pulls/comments/71821541","id":71821541,"diff_hunk":"@@ -102,11 +102,11 @@ L.Measurable = L.Editable.extend({\n             var latlng, latlngs = e.layer._defaultShape();\n             for (var i = 0; i < latlngs.length; i++) {\n                 latlng = latlngs[i];\n-                latlng.__vertex.hideLabel();\n+                latlng.__vertex.closeTooltip();\n             }\n             if (latlng && latlng.__vertex) {\n                 var length = L.GeoUtil.lineLength(map, e.layer._defaultShape());\n-                latlng.__vertex.bindLabel(L.GeoUtil.readableDistance(length, this.getMeasureUnit()), {noHide: true}).showLabel();\n+                latlng.__vertex.bindTooltip(L.GeoUtil.readableDistance(length, this.getMeasureUnit()), {permanent: true}).openTooltip();","path":"Leaflet.Measurable.js","position":10,"original_position":10,"commit_id":"b7b76523c7a34d0124a672dc85bcb7ac76586b47","original_commit_id":"b7b76523c7a34d0124a672dc85bcb7ac76586b47","user":{"login":"brandonxiang","id":12969424,"avatar_url":"https://avatars.githubusercontent.com/u/12969424?v=3","gravatar_id":"","url":"https://api.github.com/users/brandonxiang","html_url":"https://github.com/brandonxiang","followers_url":"https://api.github.com/users/brandonxiang/followers","following_url":"https://api.github.com/users/brandonxiang/following{/other_user}","gists_url":"https://api.github.com/users/brandonxiang/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonxiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonxiang/subscriptions","organizations_url":"https://api.github.com/users/brandonxiang/orgs","repos_url":"https://api.github.com/users/brandonxiang/repos","events_url":"https://api.github.com/users/brandonxiang/events{/privacy}","received_events_url":"https://api.github.com/users/brandonxiang/received_events","type":"User","site_admin":false},"body":"I remove `openTooltip` in the next pr.","created_at":"2016-07-22T03:11:10Z","updated_at":"2016-07-22T03:11:10Z","html_url":"https://github.com/umap-project/Leaflet.Measurable/pull/2#discussion_r71821541","pull_request_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/umap-project/Leaflet.Measurable/pulls/comments/71821541"},"html":{"href":"https://github.com/umap-project/Leaflet.Measurable/pull/2#discussion_r71821541"},"pull_request":{"href":"https://api.github.com/repos/umap-project/Leaflet.Measurable/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/pulls/2","id":78416442,"html_url":"https://github.com/umap-project/Leaflet.Measurable/pull/2","diff_url":"https://github.com/umap-project/Leaflet.Measurable/pull/2.diff","patch_url":"https://github.com/umap-project/Leaflet.Measurable/pull/2.patch","issue_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/issues/2","number":2,"state":"open","locked":false,"title":"Update L.label to Leaflet 1.0.0-rc.2 L.Tooltip","user":{"login":"brandonxiang","id":12969424,"avatar_url":"https://avatars.githubusercontent.com/u/12969424?v=3","gravatar_id":"","url":"https://api.github.com/users/brandonxiang","html_url":"https://github.com/brandonxiang","followers_url":"https://api.github.com/users/brandonxiang/followers","following_url":"https://api.github.com/users/brandonxiang/following{/other_user}","gists_url":"https://api.github.com/users/brandonxiang/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonxiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonxiang/subscriptions","organizations_url":"https://api.github.com/users/brandonxiang/orgs","repos_url":"https://api.github.com/users/brandonxiang/repos","events_url":"https://api.github.com/users/brandonxiang/events{/privacy}","received_events_url":"https://api.github.com/users/brandonxiang/received_events","type":"User","site_admin":false},"body":"When I used L.storage, I found that the measure function is not available. Therefore, I checked out L.Measureable. \r\n\r\nI dont know its dependencies.  I tested it with leaflet 0.7.7, L.editable 0.6.2 and L.label 0.2.1, and it does not work. Then, I tested it with leaflet 1.0.0-beta2, L.editable 0.7.0-beta1 and L.label 0.2.1, and also it fails.\r\n\r\nFinally, I try to use 1.0.0-rc2 with L.Tooltip to replace L.label, and add a `examples/index.html` for testing.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/12969424/17044937/38710d7e-4ff7-11e6-80e0-291f8c8519dd.png)\r\n  ","created_at":"2016-07-22T02:31:11Z","updated_at":"2016-07-22T03:11:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b081632260a3193d9d68e8927b5ba22dbcba613","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/pulls/2/commits","review_comments_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/pulls/2/comments","review_comment_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/issues/2/comments","statuses_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/statuses/b7b76523c7a34d0124a672dc85bcb7ac76586b47","head":{"label":"brandonxiang:master","ref":"master","sha":"b7b76523c7a34d0124a672dc85bcb7ac76586b47","user":{"login":"brandonxiang","id":12969424,"avatar_url":"https://avatars.githubusercontent.com/u/12969424?v=3","gravatar_id":"","url":"https://api.github.com/users/brandonxiang","html_url":"https://github.com/brandonxiang","followers_url":"https://api.github.com/users/brandonxiang/followers","following_url":"https://api.github.com/users/brandonxiang/following{/other_user}","gists_url":"https://api.github.com/users/brandonxiang/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonxiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonxiang/subscriptions","organizations_url":"https://api.github.com/users/brandonxiang/orgs","repos_url":"https://api.github.com/users/brandonxiang/repos","events_url":"https://api.github.com/users/brandonxiang/events{/privacy}","received_events_url":"https://api.github.com/users/brandonxiang/received_events","type":"User","site_admin":false},"repo":{"id":63848421,"name":"Leaflet.Measurable","full_name":"brandonxiang/Leaflet.Measurable","owner":{"login":"brandonxiang","id":12969424,"avatar_url":"https://avatars.githubusercontent.com/u/12969424?v=3","gravatar_id":"","url":"https://api.github.com/users/brandonxiang","html_url":"https://github.com/brandonxiang","followers_url":"https://api.github.com/users/brandonxiang/followers","following_url":"https://api.github.com/users/brandonxiang/following{/other_user}","gists_url":"https://api.github.com/users/brandonxiang/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonxiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonxiang/subscriptions","organizations_url":"https://api.github.com/users/brandonxiang/orgs","repos_url":"https://api.github.com/users/brandonxiang/repos","events_url":"https://api.github.com/users/brandonxiang/events{/privacy}","received_events_url":"https://api.github.com/users/brandonxiang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brandonxiang/Leaflet.Measurable","description":"Measure control for Leaflet made with Leaflet.Editable","fork":true,"url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable","forks_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/forks","keys_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/teams","hooks_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/hooks","issue_events_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/issues/events{/number}","events_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/events","assignees_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/assignees{/user}","branches_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/branches{/branch}","tags_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/tags","blobs_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/git/refs{/sha}","trees_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/statuses/{sha}","languages_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/languages","stargazers_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/stargazers","contributors_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/contributors","subscribers_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/subscribers","subscription_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/subscription","commits_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/commits{/sha}","git_commits_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/git/commits{/sha}","comments_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/comments{/number}","issue_comment_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/issues/comments{/number}","contents_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/contents/{+path}","compare_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/merges","archive_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/downloads","issues_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/issues{/number}","pulls_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/pulls{/number}","milestones_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/milestones{/number}","notifications_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/labels{/name}","releases_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/releases{/id}","deployments_url":"https://api.github.com/repos/brandonxiang/Leaflet.Measurable/deployments","created_at":"2016-07-21T07:47:22Z","updated_at":"2016-07-21T07:47:23Z","pushed_at":"2016-07-22T02:25:54Z","git_url":"git://github.com/brandonxiang/Leaflet.Measurable.git","ssh_url":"git@github.com:brandonxiang/Leaflet.Measurable.git","clone_url":"https://github.com/brandonxiang/Leaflet.Measurable.git","svn_url":"https://github.com/brandonxiang/Leaflet.Measurable","homepage":null,"size":1,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"umap-project:master","ref":"master","sha":"2726f16f9c3e41f89c9af336ef08275f6aa8a119","user":{"login":"umap-project","id":13612629,"avatar_url":"https://avatars.githubusercontent.com/u/13612629?v=3","gravatar_id":"","url":"https://api.github.com/users/umap-project","html_url":"https://github.com/umap-project","followers_url":"https://api.github.com/users/umap-project/followers","following_url":"https://api.github.com/users/umap-project/following{/other_user}","gists_url":"https://api.github.com/users/umap-project/gists{/gist_id}","starred_url":"https://api.github.com/users/umap-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umap-project/subscriptions","organizations_url":"https://api.github.com/users/umap-project/orgs","repos_url":"https://api.github.com/users/umap-project/repos","events_url":"https://api.github.com/users/umap-project/events{/privacy}","received_events_url":"https://api.github.com/users/umap-project/received_events","type":"Organization","site_admin":false},"repo":{"id":41584645,"name":"Leaflet.Measurable","full_name":"umap-project/Leaflet.Measurable","owner":{"login":"umap-project","id":13612629,"avatar_url":"https://avatars.githubusercontent.com/u/13612629?v=3","gravatar_id":"","url":"https://api.github.com/users/umap-project","html_url":"https://github.com/umap-project","followers_url":"https://api.github.com/users/umap-project/followers","following_url":"https://api.github.com/users/umap-project/following{/other_user}","gists_url":"https://api.github.com/users/umap-project/gists{/gist_id}","starred_url":"https://api.github.com/users/umap-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umap-project/subscriptions","organizations_url":"https://api.github.com/users/umap-project/orgs","repos_url":"https://api.github.com/users/umap-project/repos","events_url":"https://api.github.com/users/umap-project/events{/privacy}","received_events_url":"https://api.github.com/users/umap-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/umap-project/Leaflet.Measurable","description":"Measure control for Leaflet made with Leaflet.Editable","fork":false,"url":"https://api.github.com/repos/umap-project/Leaflet.Measurable","forks_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/forks","keys_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/teams","hooks_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/hooks","issue_events_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/issues/events{/number}","events_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/events","assignees_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/assignees{/user}","branches_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/branches{/branch}","tags_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/tags","blobs_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/git/refs{/sha}","trees_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/statuses/{sha}","languages_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/languages","stargazers_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/stargazers","contributors_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/contributors","subscribers_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/subscribers","subscription_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/subscription","commits_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/commits{/sha}","git_commits_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/git/commits{/sha}","comments_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/comments{/number}","issue_comment_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/issues/comments{/number}","contents_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/contents/{+path}","compare_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/merges","archive_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/downloads","issues_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/issues{/number}","pulls_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/pulls{/number}","milestones_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/milestones{/number}","notifications_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/labels{/name}","releases_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/releases{/id}","deployments_url":"https://api.github.com/repos/umap-project/Leaflet.Measurable/deployments","created_at":"2015-08-29T07:22:17Z","updated_at":"2016-07-19T12:53:09Z","pushed_at":"2016-07-22T02:31:11Z","git_url":"git://github.com/umap-project/Leaflet.Measurable.git","ssh_url":"git@github.com:umap-project/Leaflet.Measurable.git","clone_url":"https://github.com/umap-project/Leaflet.Measurable.git","svn_url":"https://github.com/umap-project/Leaflet.Measurable","homepage":null,"size":1,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/umap-project/Leaflet.Measurable/pulls/2"},"html":{"href":"https://github.com/umap-project/Leaflet.Measurable/pull/2"},"issue":{"href":"https://api.github.com/repos/umap-project/Leaflet.Measurable/issues/2"},"comments":{"href":"https://api.github.com/repos/umap-project/Leaflet.Measurable/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/umap-project/Leaflet.Measurable/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/umap-project/Leaflet.Measurable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/umap-project/Leaflet.Measurable/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/umap-project/Leaflet.Measurable/statuses/b7b76523c7a34d0124a672dc85bcb7ac76586b47"}}}}
{"actor":{"display_login":"brandonxiang"}}