{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/manifest/pulls/comments/94027104","pull_request_review_id":14557009,"id":94027104,"diff_hunk":"@@ -2816,6 +2931,181 @@ <h3 id=\"applying\">\n     </section>\n     <section>\n       <h2>\n+        The serviceworker object and its members\n+      </h2>\n+      <p>\n+        A <dfn>serviceworker object</dfn> represents a service worker\n+        registration for the web application.\n+      </p>\n+      <section>\n+        <h3>\n+          <code>src</code> member\n+        </h3>\n+        <p>\n+          The <dfn data-lt=\"serviceworker-src\"><code>src</code> member</dfn> of a\n+          <a>serviceworker object</a> is a <a>URL</a> representing a\n+          service worker.\n+        </p>\n+        <p>\n+          The <dfn>steps for processing the <code>src</code> member of a\n+          service worker</dfn> are given by the following algorithm. The algorithm takes\n+          a <a>serviceworker object</a> <var>registration</var>, and a <a>URL</a> <var>manifest\n+          URL</var>, which is the <a>URL</a> from which the\n+          <var>manifest</var> was fetched. This algorithm will return a\n+          <a>URL</a> or <code>undefined</code>.\n+        </p>\n+        <ol>\n+          <li>Let <var>value</var> be the result of calling the\n+          <a>[[\\GetOwnProperty]]</a> internal method of <var>registration</var>\n+          passing \" <code>src</code>\" as the argument.\n+          </li>\n+          <li>Let <var>type</var> be <a>Type</a>(<var>value</var>).\n+          </li>\n+          <li>If <var>type</var> is not \"string\", then:\n+            <ol>\n+              <li>If <var>type</var> is not \"<code>undefined</code>\", issue a\n+              developer warning that the type is unsupported.\n+              </li>\n+              <li>Return <code>undefined</code>.\n+              </li>\n+            </ol>\n+          </li>\n+          <li>If <a>Trim</a>(value) is the empty string, then return\n+          <code>undefined</code>.\n+          </li>\n+          <li>Otherwise, <a>parse</a> <var>value</var> using <var>manifest\n+          URL</var> as the base URL and return the result.\n+          </li>\n+        </ol>\n+      </section>\n+      <section>\n+        <h3>\n+          <code>scope</code> member\n+        </h3>\n+        <p>\n+          The <dfn data-lt=\"serviceworker-scope\"><code>scope</code> member</dfn> of a\n+          <a>serviceworker object</a> is the service worker's associated\n+          <a href=\"https://w3c.github.io/ServiceWorker/#dfn-scope-url\">scope URL</a>.\n+        </p>\n+        <p>\n+          The <dfn>steps for processing the <code>scope</code> member of a\n+          service worker</dfn> are given by the following algorithm. The algorithm takes\n+          a <a>serviceworker object</a> <var>registration</var>, and a <a>URL</a> <var>manifest\n+          URL</var>, which is the <a>URL</a> from which the\n+          <var>manifest</var> was fetched. This algorithm will return a\n+          <a>URL</a> or <code>undefined</code>.\n+        </p>\n+        <ol>\n+          <li>Let <var>value</var> be the result of calling the\n+          <a>[[\\GetOwnProperty]]</a> internal method of <var>registration</var>\n+          passing \"<code>scope</code>\" as the argument.\n+          </li>\n+          <li>Let <var>type</var> be <a>Type</a>(<var>value</var>).\n+          </li>\n+          <li>If <var>type</var> is not \"string\", then:\n+            <ol>\n+              <li>If <var>type</var> is not \"<code>undefined</code>\", issue a\n+              developer warning that the type is unsupported and\n+              return <code>undefined</code>.\n+              </li>\n+              <li>Return <code>null</code>.\n+              </li>\n+            </ol>\n+          </li>\n+          <li>If <a>Trim</a>(value) is the empty string, then return\n+          <code>undefined</code>.\n+          </li>\n+          <li>Otherwise, <a>parse</a> <var>value</var> using <var>manifest\n+          URL</var> as the base URL and return the result.\n+          </li>\n+        </ol>\n+      </section>\n+      <section>\n+        <h3>\n+          <code>type</code> member\n+        </h3>\n+        <p>\n+          The <dfn data-lt=\"serviceworker-type\"><code>type</code> member</dfn> of a\n+          <a>serviceworker object</a> is the service worker's\n+          <a href=\"https://html.spec.whatwg.org/multipage/workers.html#workertype\">worker type</a>.\n+        </p>\n+        <p>\n+          The <dfn>steps for processing the <code>type</code> member of a\n+          service worker</dfn> are given by the following algorithm. The algorithm takes\n+          a <a>serviceworker object</a> <var>registration</var>, and a <a>URL</a> <var>manifest\n+          URL</var>, which is the <a>URL</a> from which the\n+          <var>manifest</var> was fetched. This algorithm will return a\n+          string.\n+        </p>\n+        <ol>\n+          <li>Let <var>value</var> be the result of calling the\n+          <a>[[\\GetOwnProperty]]</a> internal method of <var>registration</var>\n+          passing \" <code>type</code>\" as the argument.\n+          </li>\n+          <li>Let <var>type</var> be <a>Type</a>(<var>value</var>).\n+          </li>\n+          <li>If <var>type</var> is not \"string\", then:\n+            <ol>\n+              <li>If <var>type</var> is not \"<code>undefined</code>\", issue a\n+              developer warning that the type is unsupported and\n+              return <code>undefined</code>.\n+              </li>\n+              <li>Return <code>\"classic\"</code>.\n+              </li>\n+            </ol>\n+          </li>\n+          <li>If <a>Trim</a>(value) is the empty string, then:\n+            <ol>\n+              <li>Issue a developer warning that the type is unsupported.","path":"index.html","position":285,"original_position":285,"commit_id":"4fc48b18183689d615b07678779e1fb8ffd4a7c3","original_commit_id":"4fc48b18183689d615b07678779e1fb8ffd4a7c3","user":{"login":"kenchris","id":1101339,"avatar_url":"https://avatars.githubusercontent.com/u/1101339?v=3","gravatar_id":"","url":"https://api.github.com/users/kenchris","html_url":"https://github.com/kenchris","followers_url":"https://api.github.com/users/kenchris/followers","following_url":"https://api.github.com/users/kenchris/following{/other_user}","gists_url":"https://api.github.com/users/kenchris/gists{/gist_id}","starred_url":"https://api.github.com/users/kenchris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenchris/subscriptions","organizations_url":"https://api.github.com/users/kenchris/orgs","repos_url":"https://api.github.com/users/kenchris/repos","events_url":"https://api.github.com/users/kenchris/events{/privacy}","received_events_url":"https://api.github.com/users/kenchris/received_events","type":"User","site_admin":false},"body":"That is how it works for Link element. What do you think @jungkees ?","created_at":"2016-12-28T12:25:18Z","updated_at":"2016-12-28T12:25:18Z","html_url":"https://github.com/w3c/manifest/pull/507#discussion_r94027104","pull_request_url":"https://api.github.com/repos/w3c/manifest/pulls/507","_links":{"self":{"href":"https://api.github.com/repos/w3c/manifest/pulls/comments/94027104"},"html":{"href":"https://github.com/w3c/manifest/pull/507#discussion_r94027104"},"pull_request":{"href":"https://api.github.com/repos/w3c/manifest/pulls/507"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/manifest/pulls/507","id":90213420,"html_url":"https://github.com/w3c/manifest/pull/507","diff_url":"https://github.com/w3c/manifest/pull/507.diff","patch_url":"https://github.com/w3c/manifest/pull/507.patch","issue_url":"https://api.github.com/repos/w3c/manifest/issues/507","number":507,"state":"open","locked":false,"title":"Add support for 'serviceworkers' member","user":{"login":"kenchris","id":1101339,"avatar_url":"https://avatars.githubusercontent.com/u/1101339?v=3","gravatar_id":"","url":"https://api.github.com/users/kenchris","html_url":"https://github.com/kenchris","followers_url":"https://api.github.com/users/kenchris/followers","following_url":"https://api.github.com/users/kenchris/following{/other_user}","gists_url":"https://api.github.com/users/kenchris/gists{/gist_id}","starred_url":"https://api.github.com/users/kenchris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenchris/subscriptions","organizations_url":"https://api.github.com/users/kenchris/orgs","repos_url":"https://api.github.com/users/kenchris/repos","events_url":"https://api.github.com/users/kenchris/events{/privacy}","received_events_url":"https://api.github.com/users/kenchris/received_events","type":"User","site_admin":false},"body":"First attempt at fixing #161\n\nWhere do we add the actual registration steps?\n","created_at":"2016-10-20T14:36:28Z","updated_at":"2016-12-28T12:25:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2be073b3d537470ebe3d1684edba8f27e3b83ed7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/manifest/pulls/507/commits","review_comments_url":"https://api.github.com/repos/w3c/manifest/pulls/507/comments","review_comment_url":"https://api.github.com/repos/w3c/manifest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/manifest/issues/507/comments","statuses_url":"https://api.github.com/repos/w3c/manifest/statuses/4fc48b18183689d615b07678779e1fb8ffd4a7c3","head":{"label":"kenchris:sw-member","ref":"sw-member","sha":"4fc48b18183689d615b07678779e1fb8ffd4a7c3","user":{"login":"kenchris","id":1101339,"avatar_url":"https://avatars.githubusercontent.com/u/1101339?v=3","gravatar_id":"","url":"https://api.github.com/users/kenchris","html_url":"https://github.com/kenchris","followers_url":"https://api.github.com/users/kenchris/followers","following_url":"https://api.github.com/users/kenchris/following{/other_user}","gists_url":"https://api.github.com/users/kenchris/gists{/gist_id}","starred_url":"https://api.github.com/users/kenchris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenchris/subscriptions","organizations_url":"https://api.github.com/users/kenchris/orgs","repos_url":"https://api.github.com/users/kenchris/repos","events_url":"https://api.github.com/users/kenchris/events{/privacy}","received_events_url":"https://api.github.com/users/kenchris/received_events","type":"User","site_admin":false},"repo":{"id":16946808,"name":"manifest","full_name":"kenchris/manifest","owner":{"login":"kenchris","id":1101339,"avatar_url":"https://avatars.githubusercontent.com/u/1101339?v=3","gravatar_id":"","url":"https://api.github.com/users/kenchris","html_url":"https://github.com/kenchris","followers_url":"https://api.github.com/users/kenchris/followers","following_url":"https://api.github.com/users/kenchris/following{/other_user}","gists_url":"https://api.github.com/users/kenchris/gists{/gist_id}","starred_url":"https://api.github.com/users/kenchris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenchris/subscriptions","organizations_url":"https://api.github.com/users/kenchris/orgs","repos_url":"https://api.github.com/users/kenchris/repos","events_url":"https://api.github.com/users/kenchris/events{/privacy}","received_events_url":"https://api.github.com/users/kenchris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kenchris/manifest","description":"Manifest for hosted web apps and packaged apps","fork":true,"url":"https://api.github.com/repos/kenchris/manifest","forks_url":"https://api.github.com/repos/kenchris/manifest/forks","keys_url":"https://api.github.com/repos/kenchris/manifest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kenchris/manifest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kenchris/manifest/teams","hooks_url":"https://api.github.com/repos/kenchris/manifest/hooks","issue_events_url":"https://api.github.com/repos/kenchris/manifest/issues/events{/number}","events_url":"https://api.github.com/repos/kenchris/manifest/events","assignees_url":"https://api.github.com/repos/kenchris/manifest/assignees{/user}","branches_url":"https://api.github.com/repos/kenchris/manifest/branches{/branch}","tags_url":"https://api.github.com/repos/kenchris/manifest/tags","blobs_url":"https://api.github.com/repos/kenchris/manifest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kenchris/manifest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kenchris/manifest/git/refs{/sha}","trees_url":"https://api.github.com/repos/kenchris/manifest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kenchris/manifest/statuses/{sha}","languages_url":"https://api.github.com/repos/kenchris/manifest/languages","stargazers_url":"https://api.github.com/repos/kenchris/manifest/stargazers","contributors_url":"https://api.github.com/repos/kenchris/manifest/contributors","subscribers_url":"https://api.github.com/repos/kenchris/manifest/subscribers","subscription_url":"https://api.github.com/repos/kenchris/manifest/subscription","commits_url":"https://api.github.com/repos/kenchris/manifest/commits{/sha}","git_commits_url":"https://api.github.com/repos/kenchris/manifest/git/commits{/sha}","comments_url":"https://api.github.com/repos/kenchris/manifest/comments{/number}","issue_comment_url":"https://api.github.com/repos/kenchris/manifest/issues/comments{/number}","contents_url":"https://api.github.com/repos/kenchris/manifest/contents/{+path}","compare_url":"https://api.github.com/repos/kenchris/manifest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kenchris/manifest/merges","archive_url":"https://api.github.com/repos/kenchris/manifest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kenchris/manifest/downloads","issues_url":"https://api.github.com/repos/kenchris/manifest/issues{/number}","pulls_url":"https://api.github.com/repos/kenchris/manifest/pulls{/number}","milestones_url":"https://api.github.com/repos/kenchris/manifest/milestones{/number}","notifications_url":"https://api.github.com/repos/kenchris/manifest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kenchris/manifest/labels{/name}","releases_url":"https://api.github.com/repos/kenchris/manifest/releases{/id}","deployments_url":"https://api.github.com/repos/kenchris/manifest/deployments","created_at":"2014-02-18T11:31:14Z","updated_at":"2014-05-14T09:08:49Z","pushed_at":"2016-12-15T16:00:41Z","git_url":"git://github.com/kenchris/manifest.git","ssh_url":"git@github.com:kenchris/manifest.git","clone_url":"https://github.com/kenchris/manifest.git","svn_url":"https://github.com/kenchris/manifest","homepage":null,"size":1282,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"gh-pages"}},"base":{"label":"w3c:gh-pages","ref":"gh-pages","sha":"72f33128e2000850f3dd2a2fd562d42a54cc972e","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":9549221,"name":"manifest","full_name":"w3c/manifest","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/manifest","description":"Manifest for web apps","fork":false,"url":"https://api.github.com/repos/w3c/manifest","forks_url":"https://api.github.com/repos/w3c/manifest/forks","keys_url":"https://api.github.com/repos/w3c/manifest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/manifest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/manifest/teams","hooks_url":"https://api.github.com/repos/w3c/manifest/hooks","issue_events_url":"https://api.github.com/repos/w3c/manifest/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/manifest/events","assignees_url":"https://api.github.com/repos/w3c/manifest/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/manifest/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/manifest/tags","blobs_url":"https://api.github.com/repos/w3c/manifest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/manifest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/manifest/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/manifest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/manifest/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/manifest/languages","stargazers_url":"https://api.github.com/repos/w3c/manifest/stargazers","contributors_url":"https://api.github.com/repos/w3c/manifest/contributors","subscribers_url":"https://api.github.com/repos/w3c/manifest/subscribers","subscription_url":"https://api.github.com/repos/w3c/manifest/subscription","commits_url":"https://api.github.com/repos/w3c/manifest/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/manifest/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/manifest/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/manifest/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/manifest/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/manifest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/manifest/merges","archive_url":"https://api.github.com/repos/w3c/manifest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/manifest/downloads","issues_url":"https://api.github.com/repos/w3c/manifest/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/manifest/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/manifest/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/manifest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/manifest/labels{/name}","releases_url":"https://api.github.com/repos/w3c/manifest/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/manifest/deployments","created_at":"2013-04-19T16:07:37Z","updated_at":"2016-12-25T15:18:15Z","pushed_at":"2016-12-15T16:00:42Z","git_url":"git://github.com/w3c/manifest.git","ssh_url":"git@github.com:w3c/manifest.git","clone_url":"https://github.com/w3c/manifest.git","svn_url":"https://github.com/w3c/manifest","homepage":"https://www.w3.org/TR/appmanifest/","size":1736,"stargazers_count":219,"watchers_count":219,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":50,"mirror_url":null,"open_issues_count":32,"forks":50,"open_issues":32,"watchers":219,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/manifest/pulls/507"},"html":{"href":"https://github.com/w3c/manifest/pull/507"},"issue":{"href":"https://api.github.com/repos/w3c/manifest/issues/507"},"comments":{"href":"https://api.github.com/repos/w3c/manifest/issues/507/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/manifest/pulls/507/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/manifest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/manifest/pulls/507/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/manifest/statuses/4fc48b18183689d615b07678779e1fb8ffd4a7c3"}}}}
{"actor":{"display_login":"kenchris"}}