{"action":"created","comment":{"url":"https://api.github.com/repos/kaqu/PuzzleGenerals/pulls/comments/53228304","id":53228304,"diff_hunk":"@@ -34,24 +34,21 @@\n \n     public void pickUnitToHand(PGUnitContainer unitContainer, PGUnitContainer hand) throws PGIncorrectUnitLocationException {\n         PGUnit unit = unitContainer.getContainedUnit();\n-        hand.setContainedUnit(unit);","path":"src/pl/kaqu/pg/engine/gamearea/behaviour/dispatcher/PGMoveDispatcher.java","position":4,"original_position":4,"commit_id":"e388b329059f84ac36addb3597632018863aa185","original_commit_id":"e388b329059f84ac36addb3597632018863aa185","user":{"login":"kaqu","id":5401764,"avatar_url":"https://avatars.githubusercontent.com/u/5401764?v=3","gravatar_id":"","url":"https://api.github.com/users/kaqu","html_url":"https://github.com/kaqu","followers_url":"https://api.github.com/users/kaqu/followers","following_url":"https://api.github.com/users/kaqu/following{/other_user}","gists_url":"https://api.github.com/users/kaqu/gists{/gist_id}","starred_url":"https://api.github.com/users/kaqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaqu/subscriptions","organizations_url":"https://api.github.com/users/kaqu/orgs","repos_url":"https://api.github.com/users/kaqu/repos","events_url":"https://api.github.com/users/kaqu/events{/privacy}","received_events_url":"https://api.github.com/users/kaqu/received_events","type":"User","site_admin":false},"body":"isn't needed to notify hand container that it got something?","created_at":"2016-02-17T20:44:29Z","updated_at":"2016-02-17T20:44:29Z","html_url":"https://github.com/kaqu/PuzzleGenerals/pull/12#discussion_r53228304","pull_request_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/kaqu/PuzzleGenerals/pulls/comments/53228304"},"html":{"href":"https://github.com/kaqu/PuzzleGenerals/pull/12#discussion_r53228304"},"pull_request":{"href":"https://api.github.com/repos/kaqu/PuzzleGenerals/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/kaqu/PuzzleGenerals/pulls/12","id":59661194,"html_url":"https://github.com/kaqu/PuzzleGenerals/pull/12","diff_url":"https://github.com/kaqu/PuzzleGenerals/pull/12.diff","patch_url":"https://github.com/kaqu/PuzzleGenerals/pull/12.patch","issue_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/issues/12","number":12,"state":"open","locked":false,"title":"Minor changes and some tests","user":{"login":"ljkania","id":7061422,"avatar_url":"https://avatars.githubusercontent.com/u/7061422?v=3","gravatar_id":"","url":"https://api.github.com/users/ljkania","html_url":"https://github.com/ljkania","followers_url":"https://api.github.com/users/ljkania/followers","following_url":"https://api.github.com/users/ljkania/following{/other_user}","gists_url":"https://api.github.com/users/ljkania/gists{/gist_id}","starred_url":"https://api.github.com/users/ljkania/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljkania/subscriptions","organizations_url":"https://api.github.com/users/ljkania/orgs","repos_url":"https://api.github.com/users/ljkania/repos","events_url":"https://api.github.com/users/ljkania/events{/privacy}","received_events_url":"https://api.github.com/users/ljkania/received_events","type":"User","site_admin":false},"body":"I added some tests for PGPlayerArea. During coding them there was a several things that appeared to be able to work better with different logic approach. The most important of them is changing locations of PGUnits. Now when You set new location for unit all previous PGUnitContainers are set to null and all observable field deletes this unit from observer list. Also all new PGUnitContainers contained unit are set to this particular one automatically. This solution is better since we have connection of type \"many-to-one\" here so it is much easier to change containers for unit and then simply update data.","created_at":"2016-02-17T15:37:00Z","updated_at":"2016-02-17T20:44:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61257b42ce7e70b75719690dba4c04acdae5df8f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/pulls/12/commits","review_comments_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/pulls/12/comments","review_comment_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/issues/12/comments","statuses_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/statuses/e388b329059f84ac36addb3597632018863aa185","head":{"label":"ljkania:master","ref":"master","sha":"e388b329059f84ac36addb3597632018863aa185","user":{"login":"ljkania","id":7061422,"avatar_url":"https://avatars.githubusercontent.com/u/7061422?v=3","gravatar_id":"","url":"https://api.github.com/users/ljkania","html_url":"https://github.com/ljkania","followers_url":"https://api.github.com/users/ljkania/followers","following_url":"https://api.github.com/users/ljkania/following{/other_user}","gists_url":"https://api.github.com/users/ljkania/gists{/gist_id}","starred_url":"https://api.github.com/users/ljkania/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljkania/subscriptions","organizations_url":"https://api.github.com/users/ljkania/orgs","repos_url":"https://api.github.com/users/ljkania/repos","events_url":"https://api.github.com/users/ljkania/events{/privacy}","received_events_url":"https://api.github.com/users/ljkania/received_events","type":"User","site_admin":false},"repo":{"id":51585588,"name":"PuzzleGenerals","full_name":"ljkania/PuzzleGenerals","owner":{"login":"ljkania","id":7061422,"avatar_url":"https://avatars.githubusercontent.com/u/7061422?v=3","gravatar_id":"","url":"https://api.github.com/users/ljkania","html_url":"https://github.com/ljkania","followers_url":"https://api.github.com/users/ljkania/followers","following_url":"https://api.github.com/users/ljkania/following{/other_user}","gists_url":"https://api.github.com/users/ljkania/gists{/gist_id}","starred_url":"https://api.github.com/users/ljkania/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljkania/subscriptions","organizations_url":"https://api.github.com/users/ljkania/orgs","repos_url":"https://api.github.com/users/ljkania/repos","events_url":"https://api.github.com/users/ljkania/events{/privacy}","received_events_url":"https://api.github.com/users/ljkania/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ljkania/PuzzleGenerals","description":"","fork":true,"url":"https://api.github.com/repos/ljkania/PuzzleGenerals","forks_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/forks","keys_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/teams","hooks_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/hooks","issue_events_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/issues/events{/number}","events_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/events","assignees_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/assignees{/user}","branches_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/branches{/branch}","tags_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/tags","blobs_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/git/refs{/sha}","trees_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/statuses/{sha}","languages_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/languages","stargazers_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/stargazers","contributors_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/contributors","subscribers_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/subscribers","subscription_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/subscription","commits_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/commits{/sha}","git_commits_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/git/commits{/sha}","comments_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/comments{/number}","issue_comment_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/issues/comments{/number}","contents_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/contents/{+path}","compare_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/merges","archive_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/downloads","issues_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/issues{/number}","pulls_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/pulls{/number}","milestones_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/milestones{/number}","notifications_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/labels{/name}","releases_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/releases{/id}","deployments_url":"https://api.github.com/repos/ljkania/PuzzleGenerals/deployments","created_at":"2016-02-12T12:15:57Z","updated_at":"2016-02-12T12:15:57Z","pushed_at":"2016-02-17T15:29:00Z","git_url":"git://github.com/ljkania/PuzzleGenerals.git","ssh_url":"git@github.com:ljkania/PuzzleGenerals.git","clone_url":"https://github.com/ljkania/PuzzleGenerals.git","svn_url":"https://github.com/ljkania/PuzzleGenerals","homepage":null,"size":109,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kaqu:master","ref":"master","sha":"79c4b385ce021b85ddf84a09f505f44b9dd0b613","user":{"login":"kaqu","id":5401764,"avatar_url":"https://avatars.githubusercontent.com/u/5401764?v=3","gravatar_id":"","url":"https://api.github.com/users/kaqu","html_url":"https://github.com/kaqu","followers_url":"https://api.github.com/users/kaqu/followers","following_url":"https://api.github.com/users/kaqu/following{/other_user}","gists_url":"https://api.github.com/users/kaqu/gists{/gist_id}","starred_url":"https://api.github.com/users/kaqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaqu/subscriptions","organizations_url":"https://api.github.com/users/kaqu/orgs","repos_url":"https://api.github.com/users/kaqu/repos","events_url":"https://api.github.com/users/kaqu/events{/privacy}","received_events_url":"https://api.github.com/users/kaqu/received_events","type":"User","site_admin":false},"repo":{"id":48906617,"name":"PuzzleGenerals","full_name":"kaqu/PuzzleGenerals","owner":{"login":"kaqu","id":5401764,"avatar_url":"https://avatars.githubusercontent.com/u/5401764?v=3","gravatar_id":"","url":"https://api.github.com/users/kaqu","html_url":"https://github.com/kaqu","followers_url":"https://api.github.com/users/kaqu/followers","following_url":"https://api.github.com/users/kaqu/following{/other_user}","gists_url":"https://api.github.com/users/kaqu/gists{/gist_id}","starred_url":"https://api.github.com/users/kaqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaqu/subscriptions","organizations_url":"https://api.github.com/users/kaqu/orgs","repos_url":"https://api.github.com/users/kaqu/repos","events_url":"https://api.github.com/users/kaqu/events{/privacy}","received_events_url":"https://api.github.com/users/kaqu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaqu/PuzzleGenerals","description":"","fork":false,"url":"https://api.github.com/repos/kaqu/PuzzleGenerals","forks_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/forks","keys_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/teams","hooks_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/hooks","issue_events_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/issues/events{/number}","events_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/events","assignees_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/assignees{/user}","branches_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/branches{/branch}","tags_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/tags","blobs_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/statuses/{sha}","languages_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/languages","stargazers_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/stargazers","contributors_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/contributors","subscribers_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/subscribers","subscription_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/subscription","commits_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/contents/{+path}","compare_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/merges","archive_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/downloads","issues_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/issues{/number}","pulls_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/pulls{/number}","milestones_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/milestones{/number}","notifications_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/labels{/name}","releases_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/releases{/id}","deployments_url":"https://api.github.com/repos/kaqu/PuzzleGenerals/deployments","created_at":"2016-01-02T10:45:26Z","updated_at":"2016-02-14T11:41:24Z","pushed_at":"2016-02-17T15:37:00Z","git_url":"git://github.com/kaqu/PuzzleGenerals.git","ssh_url":"git@github.com:kaqu/PuzzleGenerals.git","clone_url":"https://github.com/kaqu/PuzzleGenerals.git","svn_url":"https://github.com/kaqu/PuzzleGenerals","homepage":null,"size":92,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":9,"forks":2,"open_issues":9,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaqu/PuzzleGenerals/pulls/12"},"html":{"href":"https://github.com/kaqu/PuzzleGenerals/pull/12"},"issue":{"href":"https://api.github.com/repos/kaqu/PuzzleGenerals/issues/12"},"comments":{"href":"https://api.github.com/repos/kaqu/PuzzleGenerals/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/kaqu/PuzzleGenerals/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/kaqu/PuzzleGenerals/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaqu/PuzzleGenerals/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/kaqu/PuzzleGenerals/statuses/e388b329059f84ac36addb3597632018863aa185"}}}}