{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/93196566","pull_request_review_id":13717865,"id":93196566,"diff_hunk":"@@ -5,21 +5,23 @@\n \n #include \"waveformmark.h\"\n \n-WaveformMark::WaveformMark(int hotCue)\n+WaveformMark::WaveformMark( const QString& group,\n+                            const QDomNode& node,\n+                            const SkinContext& context,\n+                            const WaveformSignalColors& signalColors,\n+                            int hotCue,\n+                            QString item)\n     : m_iHotCue(hotCue) {\n-}\n-\n-void WaveformMark::reset(int hotCue) {\n-    WaveformMark(hotCue).swap(*this);\n-}\n-\n-void WaveformMark::setup(const QString& group, const QDomNode& node,\n-                         const SkinContext& context,\n-                         const WaveformSignalColors& signalColors) {\n-    QString item = context.selectString(node, \"Control\");\n+    if(item == \"\")","path":"src/waveform/renderers/waveformmark.cpp","position":22,"original_position":22,"commit_id":"f2056dcf21073ccef07293498d7091571cc29cd0","original_commit_id":"f2056dcf21073ccef07293498d7091571cc29cd0","user":{"login":"daschuer","id":1777442,"avatar_url":"https://avatars.githubusercontent.com/u/1777442?v=3","gravatar_id":"","url":"https://api.github.com/users/daschuer","html_url":"https://github.com/daschuer","followers_url":"https://api.github.com/users/daschuer/followers","following_url":"https://api.github.com/users/daschuer/following{/other_user}","gists_url":"https://api.github.com/users/daschuer/gists{/gist_id}","starred_url":"https://api.github.com/users/daschuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschuer/subscriptions","organizations_url":"https://api.github.com/users/daschuer/orgs","repos_url":"https://api.github.com/users/daschuer/repos","events_url":"https://api.github.com/users/daschuer/events{/privacy}","received_events_url":"https://api.github.com/users/daschuer/received_events","type":"User","site_admin":false},"body":"You van use isEmpty() here as well. ","created_at":"2016-12-20T09:18:07Z","updated_at":"2016-12-20T09:18:07Z","html_url":"https://github.com/mixxxdj/mixxx/pull/1074#discussion_r93196566","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1074","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/93196566"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/1074#discussion_r93196566"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1074"}}},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1074","id":97743884,"html_url":"https://github.com/mixxxdj/mixxx/pull/1074","diff_url":"https://github.com/mixxxdj/mixxx/pull/1074.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/1074.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1074","number":1074,"state":"open","locked":false,"title":"To add the support of the destructor","user":{"login":"nimitbhardwaj","id":15214129,"avatar_url":"https://avatars.githubusercontent.com/u/15214129?v=3","gravatar_id":"","url":"https://api.github.com/users/nimitbhardwaj","html_url":"https://github.com/nimitbhardwaj","followers_url":"https://api.github.com/users/nimitbhardwaj/followers","following_url":"https://api.github.com/users/nimitbhardwaj/following{/other_user}","gists_url":"https://api.github.com/users/nimitbhardwaj/gists{/gist_id}","starred_url":"https://api.github.com/users/nimitbhardwaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimitbhardwaj/subscriptions","organizations_url":"https://api.github.com/users/nimitbhardwaj/orgs","repos_url":"https://api.github.com/users/nimitbhardwaj/repos","events_url":"https://api.github.com/users/nimitbhardwaj/events{/privacy}","received_events_url":"https://api.github.com/users/nimitbhardwaj/received_events","type":"User","site_admin":false},"body":"Added destructor, converted the public reset and clear function to private and added the destructor support, reference https://bugs.launchpad.net/mixxx/+bug/1624398\r\n\r\nSoon constructor code will be made, till now, if any bug or error plz tell will be added","created_at":"2016-12-13T12:44:21Z","updated_at":"2016-12-20T09:18:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab8ed64a24889bd0569b8f41151d07832f506e9a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1074/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1074/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1074/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/f2056dcf21073ccef07293498d7091571cc29cd0","head":{"label":"nimitbhardwaj:bhardwajBranch","ref":"bhardwajBranch","sha":"f2056dcf21073ccef07293498d7091571cc29cd0","user":{"login":"nimitbhardwaj","id":15214129,"avatar_url":"https://avatars.githubusercontent.com/u/15214129?v=3","gravatar_id":"","url":"https://api.github.com/users/nimitbhardwaj","html_url":"https://github.com/nimitbhardwaj","followers_url":"https://api.github.com/users/nimitbhardwaj/followers","following_url":"https://api.github.com/users/nimitbhardwaj/following{/other_user}","gists_url":"https://api.github.com/users/nimitbhardwaj/gists{/gist_id}","starred_url":"https://api.github.com/users/nimitbhardwaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimitbhardwaj/subscriptions","organizations_url":"https://api.github.com/users/nimitbhardwaj/orgs","repos_url":"https://api.github.com/users/nimitbhardwaj/repos","events_url":"https://api.github.com/users/nimitbhardwaj/events{/privacy}","received_events_url":"https://api.github.com/users/nimitbhardwaj/received_events","type":"User","site_admin":false},"repo":{"id":76262975,"name":"mixxx","full_name":"nimitbhardwaj/mixxx","owner":{"login":"nimitbhardwaj","id":15214129,"avatar_url":"https://avatars.githubusercontent.com/u/15214129?v=3","gravatar_id":"","url":"https://api.github.com/users/nimitbhardwaj","html_url":"https://github.com/nimitbhardwaj","followers_url":"https://api.github.com/users/nimitbhardwaj/followers","following_url":"https://api.github.com/users/nimitbhardwaj/following{/other_user}","gists_url":"https://api.github.com/users/nimitbhardwaj/gists{/gist_id}","starred_url":"https://api.github.com/users/nimitbhardwaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimitbhardwaj/subscriptions","organizations_url":"https://api.github.com/users/nimitbhardwaj/orgs","repos_url":"https://api.github.com/users/nimitbhardwaj/repos","events_url":"https://api.github.com/users/nimitbhardwaj/events{/privacy}","received_events_url":"https://api.github.com/users/nimitbhardwaj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nimitbhardwaj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":true,"url":"https://api.github.com/repos/nimitbhardwaj/mixxx","forks_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/forks","keys_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/teams","hooks_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/events","assignees_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/tags","blobs_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/languages","stargazers_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/subscription","commits_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/merges","archive_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/downloads","issues_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/nimitbhardwaj/mixxx/deployments","created_at":"2016-12-12T14:18:24Z","updated_at":"2016-12-12T14:18:43Z","pushed_at":"2016-12-20T09:05:23Z","git_url":"git://github.com/nimitbhardwaj/mixxx.git","ssh_url":"git@github.com:nimitbhardwaj/mixxx.git","clone_url":"https://github.com/nimitbhardwaj/mixxx.git","svn_url":"https://github.com/nimitbhardwaj/mixxx","homepage":"http://mixxx.org","size":260906,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mixxxdj:master","ref":"master","sha":"5b0b6e7408c62c0d29dfbe57e535940ae5977535","user":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"name":"mixxx","full_name":"mixxxdj/mixxx","owner":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/mixxxdj/mixxx/deployments","created_at":"2013-05-17T15:14:38Z","updated_at":"2016-12-19T16:58:02Z","pushed_at":"2016-12-20T09:05:25Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":260886,"stargazers_count":634,"watchers_count":634,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":376,"mirror_url":null,"open_issues_count":77,"forks":376,"open_issues":77,"watchers":634,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1074"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/1074"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/1074"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/1074/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1074/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1074/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/f2056dcf21073ccef07293498d7091571cc29cd0"}}}}
{"actor":{"display_login":"daschuer"}}