{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/comments/48757552","id":48757552,"diff_hunk":"@@ -0,0 +1,32 @@\n+//\n+//  MSURLSettings.h\n+//  MicrosoftAzureMobile\n+//\n+//  Created by Damien Pontifex on 4/01/2016.\n+//  Copyright © 2016 Windows Azure. All rights reserved.\n+//\n+\n+#import <Foundation/Foundation.h>\n+\n+@interface MSURLSettings : NSObject","path":"sdk/src/MSURLSettings.h","position":11,"original_position":11,"commit_id":"7773a0f8b7cba13738d2c0d7d06911df0f0acf65","original_commit_id":"7773a0f8b7cba13738d2c0d7d06911df0f0acf65","user":{"login":"phvannor","id":3979343,"avatar_url":"https://avatars.githubusercontent.com/u/3979343?v=3","gravatar_id":"","url":"https://api.github.com/users/phvannor","html_url":"https://github.com/phvannor","followers_url":"https://api.github.com/users/phvannor/followers","following_url":"https://api.github.com/users/phvannor/following{/other_user}","gists_url":"https://api.github.com/users/phvannor/gists{/gist_id}","starred_url":"https://api.github.com/users/phvannor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phvannor/subscriptions","organizations_url":"https://api.github.com/users/phvannor/orgs","repos_url":"https://api.github.com/users/phvannor/repos","events_url":"https://api.github.com/users/phvannor/events{/privacy}","received_events_url":"https://api.github.com/users/phvannor/received_events","type":"User","site_admin":false},"body":"this slightly contradicts the new setting we added for login path overrides, as it would now properly belong here, but login's use of URLs is more complex and needs revamped per another issue, so maybe can you just add a TODO: Look at login to the header?  ","created_at":"2016-01-04T17:46:03Z","updated_at":"2016-01-04T17:46:03Z","html_url":"https://github.com/Azure/azure-mobile-apps-ios-client/pull/42#discussion_r48757552","pull_request_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/comments/48757552"},"html":{"href":"https://github.com/Azure/azure-mobile-apps-ios-client/pull/42#discussion_r48757552"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/42","id":54947892,"html_url":"https://github.com/Azure/azure-mobile-apps-ios-client/pull/42","diff_url":"https://github.com/Azure/azure-mobile-apps-ios-client/pull/42.diff","patch_url":"https://github.com/Azure/azure-mobile-apps-ios-client/pull/42.patch","issue_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/issues/42","number":42,"state":"open","locked":false,"title":"URL customisation by using custom settings object","user":{"login":"damienpontifex","id":1321276,"avatar_url":"https://avatars.githubusercontent.com/u/1321276?v=3","gravatar_id":"","url":"https://api.github.com/users/damienpontifex","html_url":"https://github.com/damienpontifex","followers_url":"https://api.github.com/users/damienpontifex/followers","following_url":"https://api.github.com/users/damienpontifex/following{/other_user}","gists_url":"https://api.github.com/users/damienpontifex/gists{/gist_id}","starred_url":"https://api.github.com/users/damienpontifex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienpontifex/subscriptions","organizations_url":"https://api.github.com/users/damienpontifex/orgs","repos_url":"https://api.github.com/users/damienpontifex/repos","events_url":"https://api.github.com/users/damienpontifex/events{/privacy}","received_events_url":"https://api.github.com/users/damienpontifex/received_events","type":"User","site_admin":false},"body":"Utilizing a shared url settings object allows the user to customise the endpoints which the table and custom api actions request against. \r\n\r\nThis follows the same patter as the `MSPullSettings` class, but due to the nature that `MSURLBuilder` generates the URLs utilising class methods and adding a url settings object to all pull/push etc methods would require a lot of extra interface methods to avoid breaking changes.\r\n\r\nThe idea would be that the `MSURLSettings` would be customised on application start by a a developer.","created_at":"2016-01-04T06:58:35Z","updated_at":"2016-01-04T17:46:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88227dbbef6d6600062db67703524a7325aa4aeb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/42/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/42/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/issues/42/comments","statuses_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/statuses/7773a0f8b7cba13738d2c0d7d06911df0f0acf65","head":{"label":"damienpontifex:custom-endpoints","ref":"custom-endpoints","sha":"7773a0f8b7cba13738d2c0d7d06911df0f0acf65","user":{"login":"damienpontifex","id":1321276,"avatar_url":"https://avatars.githubusercontent.com/u/1321276?v=3","gravatar_id":"","url":"https://api.github.com/users/damienpontifex","html_url":"https://github.com/damienpontifex","followers_url":"https://api.github.com/users/damienpontifex/followers","following_url":"https://api.github.com/users/damienpontifex/following{/other_user}","gists_url":"https://api.github.com/users/damienpontifex/gists{/gist_id}","starred_url":"https://api.github.com/users/damienpontifex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienpontifex/subscriptions","organizations_url":"https://api.github.com/users/damienpontifex/orgs","repos_url":"https://api.github.com/users/damienpontifex/repos","events_url":"https://api.github.com/users/damienpontifex/events{/privacy}","received_events_url":"https://api.github.com/users/damienpontifex/received_events","type":"User","site_admin":false},"repo":{"id":46203694,"name":"azure-mobile-apps-ios-client","full_name":"damienpontifex/azure-mobile-apps-ios-client","owner":{"login":"damienpontifex","id":1321276,"avatar_url":"https://avatars.githubusercontent.com/u/1321276?v=3","gravatar_id":"","url":"https://api.github.com/users/damienpontifex","html_url":"https://github.com/damienpontifex","followers_url":"https://api.github.com/users/damienpontifex/followers","following_url":"https://api.github.com/users/damienpontifex/following{/other_user}","gists_url":"https://api.github.com/users/damienpontifex/gists{/gist_id}","starred_url":"https://api.github.com/users/damienpontifex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienpontifex/subscriptions","organizations_url":"https://api.github.com/users/damienpontifex/orgs","repos_url":"https://api.github.com/users/damienpontifex/repos","events_url":"https://api.github.com/users/damienpontifex/events{/privacy}","received_events_url":"https://api.github.com/users/damienpontifex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/damienpontifex/azure-mobile-apps-ios-client","description":"iOS Client SDK for Azure Mobile Apps","fork":true,"url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client","forks_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/forks","keys_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/teams","hooks_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/hooks","issue_events_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/issues/events{/number}","events_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/events","assignees_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/assignees{/user}","branches_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/branches{/branch}","tags_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/tags","blobs_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/statuses/{sha}","languages_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/languages","stargazers_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/stargazers","contributors_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/contributors","subscribers_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/subscribers","subscription_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/subscription","commits_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/contents/{+path}","compare_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/merges","archive_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/downloads","issues_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/issues{/number}","pulls_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/pulls{/number}","milestones_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/milestones{/number}","notifications_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/labels{/name}","releases_url":"https://api.github.com/repos/damienpontifex/azure-mobile-apps-ios-client/releases{/id}","created_at":"2015-11-15T04:06:21Z","updated_at":"2015-11-15T04:06:23Z","pushed_at":"2016-01-04T06:53:49Z","git_url":"git://github.com/damienpontifex/azure-mobile-apps-ios-client.git","ssh_url":"git@github.com:damienpontifex/azure-mobile-apps-ios-client.git","clone_url":"https://github.com/damienpontifex/azure-mobile-apps-ios-client.git","svn_url":"https://github.com/damienpontifex/azure-mobile-apps-ios-client","homepage":null,"size":3336,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"bfa4cdde0645fe6bfaa48c4733ddd0f853d89b7a","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":45963582,"name":"azure-mobile-apps-ios-client","full_name":"Azure/azure-mobile-apps-ios-client","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-mobile-apps-ios-client","description":"iOS Client SDK for Azure Mobile Apps","fork":false,"url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client","forks_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/forks","keys_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/teams","hooks_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/events","assignees_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/tags","blobs_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/subscription","commits_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/merges","archive_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/downloads","issues_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/releases{/id}","created_at":"2015-11-11T06:17:48Z","updated_at":"2015-11-15T04:06:17Z","pushed_at":"2016-01-04T06:58:35Z","git_url":"git://github.com/Azure/azure-mobile-apps-ios-client.git","ssh_url":"git@github.com:Azure/azure-mobile-apps-ios-client.git","clone_url":"https://github.com/Azure/azure-mobile-apps-ios-client.git","svn_url":"https://github.com/Azure/azure-mobile-apps-ios-client","homepage":null,"size":3351,"stargazers_count":2,"watchers_count":2,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":21,"forks":4,"open_issues":21,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/42"},"html":{"href":"https://github.com/Azure/azure-mobile-apps-ios-client/pull/42"},"issue":{"href":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/issues/42"},"comments":{"href":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-mobile-apps-ios-client/statuses/7773a0f8b7cba13738d2c0d7d06911df0f0acf65"}}}}