{"action":"created","comment":{"url":"https://api.github.com/repos/makersacademy/airport_challenge/pulls/comments/81560439","pull_request_review_id":2531297,"id":81560439,"diff_hunk":"@@ -88,3 +88,68 @@ Finally, don’t overcomplicate things. This task isn’t as hard as it may seem\n * **Submit a pull request early.**  There are various checks that happen automatically when you send a pull request.  **Fix these issues if you can**.  Green is good.\n \n * Finally, please submit a pull request before Monday at 9am with your solution or partial solution.  However much or little amount of code you wrote please please please submit a pull request before Monday at 9am.\n+\n+Solution\n+--------\n+Using Rspec and TDD principles, I modelled the solution with classes for Airport, Plane and Weather. All instance variables remain private since it is unnecessary for the other classes to have access to them. I approached each user story one at a time, testing edge cases where necessary (e.g. planes cannot land/take off if already landed/airborne; an airport should release a specific plane at take off; an airport can only instruct a plane to take off if the plane is at the airport).\n+\n+**Assumptions:** Planes are airborne when initialized.\n+\n+**Generating random weather:** ```srand(1)``` is used in weather_spec.rb to seed a sequence of repeatable pseudo-random numbers between 1 and 5 that could be reused with each run of the rspec tests. Number 5 was used to denote stormy weather; all other numbers denote sunny weather. Random weather is generated by ```#current_weather```, which is called before each plane lands or takes off.","path":"README.md","position":17,"original_position":17,"commit_id":"4ed3198a4a8bd7c3420b6d7c6f06d45eb1c4ba6a","original_commit_id":"4ed3198a4a8bd7c3420b6d7c6f06d45eb1c4ba6a","user":{"login":"maryrosecook","id":2716,"avatar_url":"https://avatars.githubusercontent.com/u/2716?v=3","gravatar_id":"","url":"https://api.github.com/users/maryrosecook","html_url":"https://github.com/maryrosecook","followers_url":"https://api.github.com/users/maryrosecook/followers","following_url":"https://api.github.com/users/maryrosecook/following{/other_user}","gists_url":"https://api.github.com/users/maryrosecook/gists{/gist_id}","starred_url":"https://api.github.com/users/maryrosecook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maryrosecook/subscriptions","organizations_url":"https://api.github.com/users/maryrosecook/orgs","repos_url":"https://api.github.com/users/maryrosecook/repos","events_url":"https://api.github.com/users/maryrosecook/events{/privacy}","received_events_url":"https://api.github.com/users/maryrosecook/received_events","type":"User","site_admin":false},"body":"Nice!","created_at":"2016-10-03T14:25:13Z","updated_at":"2016-10-03T14:25:13Z","html_url":"https://github.com/makersacademy/airport_challenge/pull/585#discussion_r81560439","pull_request_url":"https://api.github.com/repos/makersacademy/airport_challenge/pulls/585","_links":{"self":{"href":"https://api.github.com/repos/makersacademy/airport_challenge/pulls/comments/81560439"},"html":{"href":"https://github.com/makersacademy/airport_challenge/pull/585#discussion_r81560439"},"pull_request":{"href":"https://api.github.com/repos/makersacademy/airport_challenge/pulls/585"}}},"pull_request":{"url":"https://api.github.com/repos/makersacademy/airport_challenge/pulls/585","id":87652691,"html_url":"https://github.com/makersacademy/airport_challenge/pull/585","diff_url":"https://github.com/makersacademy/airport_challenge/pull/585.diff","patch_url":"https://github.com/makersacademy/airport_challenge/pull/585.patch","issue_url":"https://api.github.com/repos/makersacademy/airport_challenge/issues/585","number":585,"state":"open","locked":false,"title":"Submit solution","user":{"login":"lauraweston","id":18118521,"avatar_url":"https://avatars.githubusercontent.com/u/18118521?v=3","gravatar_id":"","url":"https://api.github.com/users/lauraweston","html_url":"https://github.com/lauraweston","followers_url":"https://api.github.com/users/lauraweston/followers","following_url":"https://api.github.com/users/lauraweston/following{/other_user}","gists_url":"https://api.github.com/users/lauraweston/gists{/gist_id}","starred_url":"https://api.github.com/users/lauraweston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lauraweston/subscriptions","organizations_url":"https://api.github.com/users/lauraweston/orgs","repos_url":"https://api.github.com/users/lauraweston/repos","events_url":"https://api.github.com/users/lauraweston/events{/privacy}","received_events_url":"https://api.github.com/users/lauraweston/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-03T00:36:59Z","updated_at":"2016-10-03T14:25:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf22d6f74d84259d3a03cae4c80cde708911a860","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/makersacademy/airport_challenge/pulls/585/commits","review_comments_url":"https://api.github.com/repos/makersacademy/airport_challenge/pulls/585/comments","review_comment_url":"https://api.github.com/repos/makersacademy/airport_challenge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/makersacademy/airport_challenge/issues/585/comments","statuses_url":"https://api.github.com/repos/makersacademy/airport_challenge/statuses/4ed3198a4a8bd7c3420b6d7c6f06d45eb1c4ba6a","head":{"label":"lauraweston:master","ref":"master","sha":"4ed3198a4a8bd7c3420b6d7c6f06d45eb1c4ba6a","user":{"login":"lauraweston","id":18118521,"avatar_url":"https://avatars.githubusercontent.com/u/18118521?v=3","gravatar_id":"","url":"https://api.github.com/users/lauraweston","html_url":"https://github.com/lauraweston","followers_url":"https://api.github.com/users/lauraweston/followers","following_url":"https://api.github.com/users/lauraweston/following{/other_user}","gists_url":"https://api.github.com/users/lauraweston/gists{/gist_id}","starred_url":"https://api.github.com/users/lauraweston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lauraweston/subscriptions","organizations_url":"https://api.github.com/users/lauraweston/orgs","repos_url":"https://api.github.com/users/lauraweston/repos","events_url":"https://api.github.com/users/lauraweston/events{/privacy}","received_events_url":"https://api.github.com/users/lauraweston/received_events","type":"User","site_admin":false},"repo":{"id":69758576,"name":"airport_challenge","full_name":"lauraweston/airport_challenge","owner":{"login":"lauraweston","id":18118521,"avatar_url":"https://avatars.githubusercontent.com/u/18118521?v=3","gravatar_id":"","url":"https://api.github.com/users/lauraweston","html_url":"https://github.com/lauraweston","followers_url":"https://api.github.com/users/lauraweston/followers","following_url":"https://api.github.com/users/lauraweston/following{/other_user}","gists_url":"https://api.github.com/users/lauraweston/gists{/gist_id}","starred_url":"https://api.github.com/users/lauraweston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lauraweston/subscriptions","organizations_url":"https://api.github.com/users/lauraweston/orgs","repos_url":"https://api.github.com/users/lauraweston/repos","events_url":"https://api.github.com/users/lauraweston/events{/privacy}","received_events_url":"https://api.github.com/users/lauraweston/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lauraweston/airport_challenge","description":"Fly!","fork":true,"url":"https://api.github.com/repos/lauraweston/airport_challenge","forks_url":"https://api.github.com/repos/lauraweston/airport_challenge/forks","keys_url":"https://api.github.com/repos/lauraweston/airport_challenge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lauraweston/airport_challenge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lauraweston/airport_challenge/teams","hooks_url":"https://api.github.com/repos/lauraweston/airport_challenge/hooks","issue_events_url":"https://api.github.com/repos/lauraweston/airport_challenge/issues/events{/number}","events_url":"https://api.github.com/repos/lauraweston/airport_challenge/events","assignees_url":"https://api.github.com/repos/lauraweston/airport_challenge/assignees{/user}","branches_url":"https://api.github.com/repos/lauraweston/airport_challenge/branches{/branch}","tags_url":"https://api.github.com/repos/lauraweston/airport_challenge/tags","blobs_url":"https://api.github.com/repos/lauraweston/airport_challenge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lauraweston/airport_challenge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lauraweston/airport_challenge/git/refs{/sha}","trees_url":"https://api.github.com/repos/lauraweston/airport_challenge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lauraweston/airport_challenge/statuses/{sha}","languages_url":"https://api.github.com/repos/lauraweston/airport_challenge/languages","stargazers_url":"https://api.github.com/repos/lauraweston/airport_challenge/stargazers","contributors_url":"https://api.github.com/repos/lauraweston/airport_challenge/contributors","subscribers_url":"https://api.github.com/repos/lauraweston/airport_challenge/subscribers","subscription_url":"https://api.github.com/repos/lauraweston/airport_challenge/subscription","commits_url":"https://api.github.com/repos/lauraweston/airport_challenge/commits{/sha}","git_commits_url":"https://api.github.com/repos/lauraweston/airport_challenge/git/commits{/sha}","comments_url":"https://api.github.com/repos/lauraweston/airport_challenge/comments{/number}","issue_comment_url":"https://api.github.com/repos/lauraweston/airport_challenge/issues/comments{/number}","contents_url":"https://api.github.com/repos/lauraweston/airport_challenge/contents/{+path}","compare_url":"https://api.github.com/repos/lauraweston/airport_challenge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lauraweston/airport_challenge/merges","archive_url":"https://api.github.com/repos/lauraweston/airport_challenge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lauraweston/airport_challenge/downloads","issues_url":"https://api.github.com/repos/lauraweston/airport_challenge/issues{/number}","pulls_url":"https://api.github.com/repos/lauraweston/airport_challenge/pulls{/number}","milestones_url":"https://api.github.com/repos/lauraweston/airport_challenge/milestones{/number}","notifications_url":"https://api.github.com/repos/lauraweston/airport_challenge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lauraweston/airport_challenge/labels{/name}","releases_url":"https://api.github.com/repos/lauraweston/airport_challenge/releases{/id}","deployments_url":"https://api.github.com/repos/lauraweston/airport_challenge/deployments","created_at":"2016-10-01T19:22:14Z","updated_at":"2016-10-01T19:22:16Z","pushed_at":"2016-10-03T01:18:40Z","git_url":"git://github.com/lauraweston/airport_challenge.git","ssh_url":"git@github.com:lauraweston/airport_challenge.git","clone_url":"https://github.com/lauraweston/airport_challenge.git","svn_url":"https://github.com/lauraweston/airport_challenge","homepage":"","size":130,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"makersacademy:master","ref":"master","sha":"260e84a7f2ec1fe5e3257ebcf1509ce99e75ce89","user":{"login":"makersacademy","id":3636186,"avatar_url":"https://avatars.githubusercontent.com/u/3636186?v=3","gravatar_id":"","url":"https://api.github.com/users/makersacademy","html_url":"https://github.com/makersacademy","followers_url":"https://api.github.com/users/makersacademy/followers","following_url":"https://api.github.com/users/makersacademy/following{/other_user}","gists_url":"https://api.github.com/users/makersacademy/gists{/gist_id}","starred_url":"https://api.github.com/users/makersacademy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makersacademy/subscriptions","organizations_url":"https://api.github.com/users/makersacademy/orgs","repos_url":"https://api.github.com/users/makersacademy/repos","events_url":"https://api.github.com/users/makersacademy/events{/privacy}","received_events_url":"https://api.github.com/users/makersacademy/received_events","type":"Organization","site_admin":false},"repo":{"id":27074983,"name":"airport_challenge","full_name":"makersacademy/airport_challenge","owner":{"login":"makersacademy","id":3636186,"avatar_url":"https://avatars.githubusercontent.com/u/3636186?v=3","gravatar_id":"","url":"https://api.github.com/users/makersacademy","html_url":"https://github.com/makersacademy","followers_url":"https://api.github.com/users/makersacademy/followers","following_url":"https://api.github.com/users/makersacademy/following{/other_user}","gists_url":"https://api.github.com/users/makersacademy/gists{/gist_id}","starred_url":"https://api.github.com/users/makersacademy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makersacademy/subscriptions","organizations_url":"https://api.github.com/users/makersacademy/orgs","repos_url":"https://api.github.com/users/makersacademy/repos","events_url":"https://api.github.com/users/makersacademy/events{/privacy}","received_events_url":"https://api.github.com/users/makersacademy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/makersacademy/airport_challenge","description":"Fly!","fork":false,"url":"https://api.github.com/repos/makersacademy/airport_challenge","forks_url":"https://api.github.com/repos/makersacademy/airport_challenge/forks","keys_url":"https://api.github.com/repos/makersacademy/airport_challenge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/makersacademy/airport_challenge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/makersacademy/airport_challenge/teams","hooks_url":"https://api.github.com/repos/makersacademy/airport_challenge/hooks","issue_events_url":"https://api.github.com/repos/makersacademy/airport_challenge/issues/events{/number}","events_url":"https://api.github.com/repos/makersacademy/airport_challenge/events","assignees_url":"https://api.github.com/repos/makersacademy/airport_challenge/assignees{/user}","branches_url":"https://api.github.com/repos/makersacademy/airport_challenge/branches{/branch}","tags_url":"https://api.github.com/repos/makersacademy/airport_challenge/tags","blobs_url":"https://api.github.com/repos/makersacademy/airport_challenge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/makersacademy/airport_challenge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/makersacademy/airport_challenge/git/refs{/sha}","trees_url":"https://api.github.com/repos/makersacademy/airport_challenge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/makersacademy/airport_challenge/statuses/{sha}","languages_url":"https://api.github.com/repos/makersacademy/airport_challenge/languages","stargazers_url":"https://api.github.com/repos/makersacademy/airport_challenge/stargazers","contributors_url":"https://api.github.com/repos/makersacademy/airport_challenge/contributors","subscribers_url":"https://api.github.com/repos/makersacademy/airport_challenge/subscribers","subscription_url":"https://api.github.com/repos/makersacademy/airport_challenge/subscription","commits_url":"https://api.github.com/repos/makersacademy/airport_challenge/commits{/sha}","git_commits_url":"https://api.github.com/repos/makersacademy/airport_challenge/git/commits{/sha}","comments_url":"https://api.github.com/repos/makersacademy/airport_challenge/comments{/number}","issue_comment_url":"https://api.github.com/repos/makersacademy/airport_challenge/issues/comments{/number}","contents_url":"https://api.github.com/repos/makersacademy/airport_challenge/contents/{+path}","compare_url":"https://api.github.com/repos/makersacademy/airport_challenge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/makersacademy/airport_challenge/merges","archive_url":"https://api.github.com/repos/makersacademy/airport_challenge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/makersacademy/airport_challenge/downloads","issues_url":"https://api.github.com/repos/makersacademy/airport_challenge/issues{/number}","pulls_url":"https://api.github.com/repos/makersacademy/airport_challenge/pulls{/number}","milestones_url":"https://api.github.com/repos/makersacademy/airport_challenge/milestones{/number}","notifications_url":"https://api.github.com/repos/makersacademy/airport_challenge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/makersacademy/airport_challenge/labels{/name}","releases_url":"https://api.github.com/repos/makersacademy/airport_challenge/releases{/id}","deployments_url":"https://api.github.com/repos/makersacademy/airport_challenge/deployments","created_at":"2014-11-24T12:30:39Z","updated_at":"2016-10-03T12:44:00Z","pushed_at":"2016-10-03T13:52:00Z","git_url":"git://github.com/makersacademy/airport_challenge.git","ssh_url":"git@github.com:makersacademy/airport_challenge.git","clone_url":"https://github.com/makersacademy/airport_challenge.git","svn_url":"https://github.com/makersacademy/airport_challenge","homepage":"","size":27016,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":522,"mirror_url":null,"open_issues_count":185,"forks":522,"open_issues":185,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/makersacademy/airport_challenge/pulls/585"},"html":{"href":"https://github.com/makersacademy/airport_challenge/pull/585"},"issue":{"href":"https://api.github.com/repos/makersacademy/airport_challenge/issues/585"},"comments":{"href":"https://api.github.com/repos/makersacademy/airport_challenge/issues/585/comments"},"review_comments":{"href":"https://api.github.com/repos/makersacademy/airport_challenge/pulls/585/comments"},"review_comment":{"href":"https://api.github.com/repos/makersacademy/airport_challenge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/makersacademy/airport_challenge/pulls/585/commits"},"statuses":{"href":"https://api.github.com/repos/makersacademy/airport_challenge/statuses/4ed3198a4a8bd7c3420b6d7c6f06d45eb1c4ba6a"}}}}
{"actor":{"display_login":"maryrosecook"}}