{"action":"closed","number":42,"pull_request":{"url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/pulls/42","id":85214185,"html_url":"https://github.com/saltstack-formulas/tomcat-formula/pull/42","diff_url":"https://github.com/saltstack-formulas/tomcat-formula/pull/42.diff","patch_url":"https://github.com/saltstack-formulas/tomcat-formula/pull/42.patch","issue_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/issues/42","number":42,"state":"closed","locked":false,"title":"Allow specifiying multiple connectors in server.xml","user":{"login":"javierbertoli","id":242396,"avatar_url":"https://avatars.githubusercontent.com/u/242396?v=3","gravatar_id":"","url":"https://api.github.com/users/javierbertoli","html_url":"https://github.com/javierbertoli","followers_url":"https://api.github.com/users/javierbertoli/followers","following_url":"https://api.github.com/users/javierbertoli/following{/other_user}","gists_url":"https://api.github.com/users/javierbertoli/gists{/gist_id}","starred_url":"https://api.github.com/users/javierbertoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierbertoli/subscriptions","organizations_url":"https://api.github.com/users/javierbertoli/orgs","repos_url":"https://api.github.com/users/javierbertoli/repos","events_url":"https://api.github.com/users/javierbertoli/events{/privacy}","received_events_url":"https://api.github.com/users/javierbertoli/received_events","type":"User","site_admin":false},"body":"`connectors`, in the `server.xml` file might be specified multiple times. The way it was declared, was allowing only one specification of it. Modified it to be a dict following the same logic as `sites`. This change is backward incompatible, as requires to reformat the `connector` -> `connectors` entry in the pillar.\r\n\r\nModified the defaults to be empty, so the default entries in `server.xml` are used (which, ideally, should be the same as in a default installation). Otherwise, those never were used.\r\n\r\nFixed tests and README, to match these new changes.","created_at":"2016-09-14T11:56:56Z","updated_at":"2016-09-14T16:33:00Z","closed_at":"2016-09-14T16:33:00Z","merged_at":"2016-09-14T16:33:00Z","merge_commit_sha":"18767135c0d9f4686f9d52051510fb4a37e809f5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/pulls/42/commits","review_comments_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/pulls/42/comments","review_comment_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/issues/42/comments","statuses_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/statuses/797cea5cb53f97011f6772c77fa0305152d7db99","head":{"label":"netmanagers:master","ref":"master","sha":"797cea5cb53f97011f6772c77fa0305152d7db99","user":{"login":"netmanagers","id":3914531,"avatar_url":"https://avatars.githubusercontent.com/u/3914531?v=3","gravatar_id":"","url":"https://api.github.com/users/netmanagers","html_url":"https://github.com/netmanagers","followers_url":"https://api.github.com/users/netmanagers/followers","following_url":"https://api.github.com/users/netmanagers/following{/other_user}","gists_url":"https://api.github.com/users/netmanagers/gists{/gist_id}","starred_url":"https://api.github.com/users/netmanagers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netmanagers/subscriptions","organizations_url":"https://api.github.com/users/netmanagers/orgs","repos_url":"https://api.github.com/users/netmanagers/repos","events_url":"https://api.github.com/users/netmanagers/events{/privacy}","received_events_url":"https://api.github.com/users/netmanagers/received_events","type":"Organization","site_admin":false},"repo":{"id":65509920,"name":"tomcat-formula","full_name":"netmanagers/tomcat-formula","owner":{"login":"netmanagers","id":3914531,"avatar_url":"https://avatars.githubusercontent.com/u/3914531?v=3","gravatar_id":"","url":"https://api.github.com/users/netmanagers","html_url":"https://github.com/netmanagers","followers_url":"https://api.github.com/users/netmanagers/followers","following_url":"https://api.github.com/users/netmanagers/following{/other_user}","gists_url":"https://api.github.com/users/netmanagers/gists{/gist_id}","starred_url":"https://api.github.com/users/netmanagers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netmanagers/subscriptions","organizations_url":"https://api.github.com/users/netmanagers/orgs","repos_url":"https://api.github.com/users/netmanagers/repos","events_url":"https://api.github.com/users/netmanagers/events{/privacy}","received_events_url":"https://api.github.com/users/netmanagers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netmanagers/tomcat-formula","description":null,"fork":true,"url":"https://api.github.com/repos/netmanagers/tomcat-formula","forks_url":"https://api.github.com/repos/netmanagers/tomcat-formula/forks","keys_url":"https://api.github.com/repos/netmanagers/tomcat-formula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netmanagers/tomcat-formula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netmanagers/tomcat-formula/teams","hooks_url":"https://api.github.com/repos/netmanagers/tomcat-formula/hooks","issue_events_url":"https://api.github.com/repos/netmanagers/tomcat-formula/issues/events{/number}","events_url":"https://api.github.com/repos/netmanagers/tomcat-formula/events","assignees_url":"https://api.github.com/repos/netmanagers/tomcat-formula/assignees{/user}","branches_url":"https://api.github.com/repos/netmanagers/tomcat-formula/branches{/branch}","tags_url":"https://api.github.com/repos/netmanagers/tomcat-formula/tags","blobs_url":"https://api.github.com/repos/netmanagers/tomcat-formula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netmanagers/tomcat-formula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netmanagers/tomcat-formula/git/refs{/sha}","trees_url":"https://api.github.com/repos/netmanagers/tomcat-formula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netmanagers/tomcat-formula/statuses/{sha}","languages_url":"https://api.github.com/repos/netmanagers/tomcat-formula/languages","stargazers_url":"https://api.github.com/repos/netmanagers/tomcat-formula/stargazers","contributors_url":"https://api.github.com/repos/netmanagers/tomcat-formula/contributors","subscribers_url":"https://api.github.com/repos/netmanagers/tomcat-formula/subscribers","subscription_url":"https://api.github.com/repos/netmanagers/tomcat-formula/subscription","commits_url":"https://api.github.com/repos/netmanagers/tomcat-formula/commits{/sha}","git_commits_url":"https://api.github.com/repos/netmanagers/tomcat-formula/git/commits{/sha}","comments_url":"https://api.github.com/repos/netmanagers/tomcat-formula/comments{/number}","issue_comment_url":"https://api.github.com/repos/netmanagers/tomcat-formula/issues/comments{/number}","contents_url":"https://api.github.com/repos/netmanagers/tomcat-formula/contents/{+path}","compare_url":"https://api.github.com/repos/netmanagers/tomcat-formula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netmanagers/tomcat-formula/merges","archive_url":"https://api.github.com/repos/netmanagers/tomcat-formula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netmanagers/tomcat-formula/downloads","issues_url":"https://api.github.com/repos/netmanagers/tomcat-formula/issues{/number}","pulls_url":"https://api.github.com/repos/netmanagers/tomcat-formula/pulls{/number}","milestones_url":"https://api.github.com/repos/netmanagers/tomcat-formula/milestones{/number}","notifications_url":"https://api.github.com/repos/netmanagers/tomcat-formula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netmanagers/tomcat-formula/labels{/name}","releases_url":"https://api.github.com/repos/netmanagers/tomcat-formula/releases{/id}","deployments_url":"https://api.github.com/repos/netmanagers/tomcat-formula/deployments","created_at":"2016-08-12T00:13:14Z","updated_at":"2016-08-18T02:15:23Z","pushed_at":"2016-09-14T10:08:08Z","git_url":"git://github.com/netmanagers/tomcat-formula.git","ssh_url":"git@github.com:netmanagers/tomcat-formula.git","clone_url":"https://github.com/netmanagers/tomcat-formula.git","svn_url":"https://github.com/netmanagers/tomcat-formula","homepage":"http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html","size":98,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"saltstack-formulas:master","ref":"master","sha":"183456e3825a7bf255a4a728794de140e4018a2e","user":{"login":"saltstack-formulas","id":4683350,"avatar_url":"https://avatars.githubusercontent.com/u/4683350?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack-formulas","html_url":"https://github.com/saltstack-formulas","followers_url":"https://api.github.com/users/saltstack-formulas/followers","following_url":"https://api.github.com/users/saltstack-formulas/following{/other_user}","gists_url":"https://api.github.com/users/saltstack-formulas/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack-formulas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack-formulas/subscriptions","organizations_url":"https://api.github.com/users/saltstack-formulas/orgs","repos_url":"https://api.github.com/users/saltstack-formulas/repos","events_url":"https://api.github.com/users/saltstack-formulas/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack-formulas/received_events","type":"Organization","site_admin":false},"repo":{"id":10653588,"name":"tomcat-formula","full_name":"saltstack-formulas/tomcat-formula","owner":{"login":"saltstack-formulas","id":4683350,"avatar_url":"https://avatars.githubusercontent.com/u/4683350?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack-formulas","html_url":"https://github.com/saltstack-formulas","followers_url":"https://api.github.com/users/saltstack-formulas/followers","following_url":"https://api.github.com/users/saltstack-formulas/following{/other_user}","gists_url":"https://api.github.com/users/saltstack-formulas/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack-formulas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack-formulas/subscriptions","organizations_url":"https://api.github.com/users/saltstack-formulas/orgs","repos_url":"https://api.github.com/users/saltstack-formulas/repos","events_url":"https://api.github.com/users/saltstack-formulas/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack-formulas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack-formulas/tomcat-formula","description":"","fork":false,"url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula","forks_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/forks","keys_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/teams","hooks_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/hooks","issue_events_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/events","assignees_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/tags","blobs_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/languages","stargazers_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/stargazers","contributors_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/contributors","subscribers_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/subscribers","subscription_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/subscription","commits_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/merges","archive_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/downloads","issues_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/labels{/name}","releases_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/deployments","created_at":"2013-06-12T22:15:22Z","updated_at":"2016-08-18T11:08:14Z","pushed_at":"2016-09-14T16:33:00Z","git_url":"git://github.com/saltstack-formulas/tomcat-formula.git","ssh_url":"git@github.com:saltstack-formulas/tomcat-formula.git","clone_url":"https://github.com/saltstack-formulas/tomcat-formula.git","svn_url":"https://github.com/saltstack-formulas/tomcat-formula","homepage":"http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html","size":99,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":1,"forks":61,"open_issues":1,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/pulls/42"},"html":{"href":"https://github.com/saltstack-formulas/tomcat-formula/pull/42"},"issue":{"href":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/issues/42"},"comments":{"href":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack-formulas/tomcat-formula/statuses/797cea5cb53f97011f6772c77fa0305152d7db99"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gravyboat","id":1396878,"avatar_url":"https://avatars.githubusercontent.com/u/1396878?v=3","gravatar_id":"","url":"https://api.github.com/users/gravyboat","html_url":"https://github.com/gravyboat","followers_url":"https://api.github.com/users/gravyboat/followers","following_url":"https://api.github.com/users/gravyboat/following{/other_user}","gists_url":"https://api.github.com/users/gravyboat/gists{/gist_id}","starred_url":"https://api.github.com/users/gravyboat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravyboat/subscriptions","organizations_url":"https://api.github.com/users/gravyboat/orgs","repos_url":"https://api.github.com/users/gravyboat/repos","events_url":"https://api.github.com/users/gravyboat/events{/privacy}","received_events_url":"https://api.github.com/users/gravyboat/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":48,"deletions":50,"changed_files":8}}
{"actor":{"display_login":"gravyboat"}}