{"action":"created","issue":{"url":"https://api.github.com/repos/LightTable/LightTable/issues/1973","repository_url":"https://api.github.com/repos/LightTable/LightTable","labels_url":"https://api.github.com/repos/LightTable/LightTable/issues/1973/labels{/name}","comments_url":"https://api.github.com/repos/LightTable/LightTable/issues/1973/comments","events_url":"https://api.github.com/repos/LightTable/LightTable/issues/1973/events","html_url":"https://github.com/LightTable/LightTable/issues/1973","id":105945462,"number":1973,"title":"Update ClojureScript","user":{"login":"cldwalker","id":11994,"avatar_url":"https://avatars.githubusercontent.com/u/11994?v=3","gravatar_id":"","url":"https://api.github.com/users/cldwalker","html_url":"https://github.com/cldwalker","followers_url":"https://api.github.com/users/cldwalker/followers","following_url":"https://api.github.com/users/cldwalker/following{/other_user}","gists_url":"https://api.github.com/users/cldwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/cldwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cldwalker/subscriptions","organizations_url":"https://api.github.com/users/cldwalker/orgs","repos_url":"https://api.github.com/users/cldwalker/repos","events_url":"https://api.github.com/users/cldwalker/events{/privacy}","received_events_url":"https://api.github.com/users/cldwalker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/LightTable/LightTable/milestones/15","html_url":"https://github.com/LightTable/LightTable/milestones/0.9.0","labels_url":"https://api.github.com/repos/LightTable/LightTable/milestones/15/labels","id":1300467,"number":15,"title":"0.9.0","description":"Feature work, refactor and other misc issues in the near future","creator":{"login":"cldwalker","id":11994,"avatar_url":"https://avatars.githubusercontent.com/u/11994?v=3","gravatar_id":"","url":"https://api.github.com/users/cldwalker","html_url":"https://github.com/cldwalker","followers_url":"https://api.github.com/users/cldwalker/followers","following_url":"https://api.github.com/users/cldwalker/following{/other_user}","gists_url":"https://api.github.com/users/cldwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/cldwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cldwalker/subscriptions","organizations_url":"https://api.github.com/users/cldwalker/orgs","repos_url":"https://api.github.com/users/cldwalker/repos","events_url":"https://api.github.com/users/cldwalker/events{/privacy}","received_events_url":"https://api.github.com/users/cldwalker/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":3,"state":"open","created_at":"2015-09-11T05:11:11Z","updated_at":"2016-01-12T06:28:15Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2015-09-11T05:05:28Z","updated_at":"2016-08-31T12:32:27Z","closed_at":null,"body":"Updating ClojureScript is important because it's preventing us from using cljs.test (#1647) and having a modern ClojureScript for plugin authors and to encourage more contributors  ~~and more importantly from evaling in modern clj/cljs projects (LightTable/Clojure#52)~~. \r\n\r\nIt is likely that the remaining items will require one monolithic branch. We can't partially upgrade cljs on master as master needs to be fully working. Here is a running list of known todos needed to update cljs:\r\n\r\n* [x] Remove uses of `lt.util.cljs/clj->js` and `lt.util.cljs/js->clj` and rely on the fns of the same name that come with clojurescript\r\n* [x] Fix all compilation warnings that show up on latest `lein cljsbuild`. Known warnings to fix include missing requires and prefix JSON e.g. js/JSON\r\n* [x] Ability to recompile cljsDeps.js after a cljs upgrade with one command [like this](https://github.com/BenjaminVanRyseghem/LightTable/commit/e2fffcc9d7e58ddaf48fa58cfaeb3f263136956f)\r\n* [ ] Upgrade to latest cljs and lein-cljsbuild. This is easy to do now that #2072 is in\r\n* [ ] Recompile cljsDeps.js for upgraded cljs: `lein cljsbuild once cljsdeps`\r\n* [ ] Make sure extend-types that occur on core classes are updated - [see cljs.cljs](https://github.com/LightTable/LightTable/blob/master/src/lt/util/cljs.cljs)\r\n* [ ] Fix Clojure(Script) eval. Does not work for to be investigated reasons\r\n* [ ] Fix threading issue when starting LT: `arguments$ is not defined`. See https://github.com/BenjaminVanRyseghem/LightTable/commit/4e647f8d8aae6dd5c0b0fbeecbffdfd6bbec8a6c for an attempted fix\r\n    * I think fixing this will fix the file navigator/opener\r\n* [ ] Fix erratic printing with `prn`. Trying to prn a LT object sometimes doesn't show up\r\n* May need to use fetch's master for https://github.com/LightTable/fetch/pull/17\r\n* Anything else?\r\n\r\n~~Note that upgrading cljs is being attempted in #1952 and was last attempted by Chris in 8e73f59891c45f73a1b985fed69795d1061a8ecf.~~ For this upgrade to be considered successful, the branch must pass our [QA checklist](https://github.com/LightTable/LightTable/wiki/QA-Checklist)\r\n\r\nOnce this is done, see #1991 for follow work to be done"},"comment":{"url":"https://api.github.com/repos/LightTable/LightTable/issues/comments/243749396","html_url":"https://github.com/LightTable/LightTable/issues/1973#issuecomment-243749396","issue_url":"https://api.github.com/repos/LightTable/LightTable/issues/1973","id":243749396,"user":{"login":"cldwalker","id":11994,"avatar_url":"https://avatars.githubusercontent.com/u/11994?v=3","gravatar_id":"","url":"https://api.github.com/users/cldwalker","html_url":"https://github.com/cldwalker","followers_url":"https://api.github.com/users/cldwalker/followers","following_url":"https://api.github.com/users/cldwalker/following{/other_user}","gists_url":"https://api.github.com/users/cldwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/cldwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cldwalker/subscriptions","organizations_url":"https://api.github.com/users/cldwalker/orgs","repos_url":"https://api.github.com/users/cldwalker/repos","events_url":"https://api.github.com/users/cldwalker/events{/privacy}","received_events_url":"https://api.github.com/users/cldwalker/received_events","type":"User","site_admin":false},"created_at":"2016-08-31T12:32:27Z","updated_at":"2016-08-31T12:32:27Z","body":"@sbauer322 Hi. This means you'll need to familiarize yourself with core protocols in cljs.cljs e.g. IFn and ensure they are being implemented correctly w/ a modern clojurescript. Then you should understand how these extensions are used and verify none of them are behaving differently enough to cause bugs. Fwiw, none of the core team has written these extensions"}}
{"actor":{"display_login":"cldwalker"}}