{"action":"created","issue":{"url":"https://api.github.com/repos/jekyll/jekyll-assets/issues/285","repository_url":"https://api.github.com/repos/jekyll/jekyll-assets","labels_url":"https://api.github.com/repos/jekyll/jekyll-assets/issues/285/labels{/name}","comments_url":"https://api.github.com/repos/jekyll/jekyll-assets/issues/285/comments","events_url":"https://api.github.com/repos/jekyll/jekyll-assets/issues/285/events","html_url":"https://github.com/jekyll/jekyll-assets/pull/285","id":156067784,"number":285,"title":"Add missing leading space to key-only attributes","user":{"login":"razor-x","id":721372,"avatar_url":"https://avatars.githubusercontent.com/u/721372?v=3","gravatar_id":"","url":"https://api.github.com/users/razor-x","html_url":"https://github.com/razor-x","followers_url":"https://api.github.com/users/razor-x/followers","following_url":"https://api.github.com/users/razor-x/following{/other_user}","gists_url":"https://api.github.com/users/razor-x/gists{/gist_id}","starred_url":"https://api.github.com/users/razor-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/razor-x/subscriptions","organizations_url":"https://api.github.com/users/razor-x/orgs","repos_url":"https://api.github.com/users/razor-x/repos","events_url":"https://api.github.com/users/razor-x/events{/privacy}","received_events_url":"https://api.github.com/users/razor-x/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jekyll/jekyll-assets/labels/bug","name":"bug","color":"e11d21"},{"url":"https://api.github.com/repos/jekyll/jekyll-assets/labels/cant-reproduce","name":"cant-reproduce","color":"fbca04"},{"url":"https://api.github.com/repos/jekyll/jekyll-assets/labels/pending-feedback","name":"pending-feedback","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-20T23:18:57Z","updated_at":"2016-05-21T01:21:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jekyll/jekyll-assets/pulls/285","html_url":"https://github.com/jekyll/jekyll-assets/pull/285","diff_url":"https://github.com/jekyll/jekyll-assets/pull/285.diff","patch_url":"https://github.com/jekyll/jekyll-assets/pull/285.patch"},"body":"HTML linter got upset. For example, using\r\n\r\n```\r\n{% javascript app.js async %}\r\n```\r\n\r\nBefore:\r\n\r\n```\r\n<script type=\"text/javascript\" src=\"/assets/app.js\"async></script>\r\n```\r\n\r\nAfter:\r\n\r\n```\r\n<script type=\"text/javascript\" src=\"/assets/app.js\" async></script>\r\n```\r\n\r\nThis is consistent with how the other attributes are rendered."},"comment":{"url":"https://api.github.com/repos/jekyll/jekyll-assets/issues/comments/220750812","html_url":"https://github.com/jekyll/jekyll-assets/pull/285#issuecomment-220750812","issue_url":"https://api.github.com/repos/jekyll/jekyll-assets/issues/285","id":220750812,"user":{"login":"razor-x","id":721372,"avatar_url":"https://avatars.githubusercontent.com/u/721372?v=3","gravatar_id":"","url":"https://api.github.com/users/razor-x","html_url":"https://github.com/razor-x","followers_url":"https://api.github.com/users/razor-x/followers","following_url":"https://api.github.com/users/razor-x/following{/other_user}","gists_url":"https://api.github.com/users/razor-x/gists{/gist_id}","starred_url":"https://api.github.com/users/razor-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/razor-x/subscriptions","organizations_url":"https://api.github.com/users/razor-x/orgs","repos_url":"https://api.github.com/users/razor-x/repos","events_url":"https://api.github.com/users/razor-x/events{/privacy}","received_events_url":"https://api.github.com/users/razor-x/received_events","type":"User","site_admin":false},"created_at":"2016-05-21T01:21:36Z","updated_at":"2016-05-21T01:21:36Z","body":"I was actually looking for where to write a test for it, but that method doesn't have an existing test, and none of the parser tests check the full html tag string output (as far as I can tell).\r\n\r\nI can reproduce it off master by adding this to the fixture: https://github.com/rxfork/jekyll-assets/commit/e54d7011703131f607e07fab579990ad040cb3ef\r\n\r\n```\r\n  <head>\r\n    {% javascript bundle async %}\r\n    {% javascript bundle id:1 async %}\r\n    ...\r\n  </head>\r\n```\r\n\r\nNote that you were already using `%( #{key}=\"#{val}\")` for the other case, which clearly adds the leading space. So it should be added to the key-only case for consistency. "}}
{"actor":{"display_login":"razor-x"}}