{"action":"created","comment":{"url":"https://api.github.com/repos/tananaev/traccar/pulls/comments/71684241","id":71684241,"diff_hunk":"@@ -145,6 +156,24 @@ Ext.define('Traccar.controller.Root', {\n                             }\n                         }\n                         text = Strings.eventCommandResult + ': ' + text;\n+                    } else if (array[i].type === 'alarm' && data.positions) {\n+                        alarmKey = 'alarm';\n+                        text = Strings[alarmKey];\n+                        if (typeof text === 'undefined') {","path":"web/app/controller/Root.js","position":43,"original_position":43,"commit_id":"2e7987b5df7611299aa76bcc9eca3424ce31d204","original_commit_id":"2e7987b5df7611299aa76bcc9eca3424ce31d204","user":{"login":"tananaev","id":1161863,"avatar_url":"https://avatars.githubusercontent.com/u/1161863?v=3","gravatar_id":"","url":"https://api.github.com/users/tananaev","html_url":"https://github.com/tananaev","followers_url":"https://api.github.com/users/tananaev/followers","following_url":"https://api.github.com/users/tananaev/following{/other_user}","gists_url":"https://api.github.com/users/tananaev/gists{/gist_id}","starred_url":"https://api.github.com/users/tananaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tananaev/subscriptions","organizations_url":"https://api.github.com/users/tananaev/orgs","repos_url":"https://api.github.com/users/tananaev/repos","events_url":"https://api.github.com/users/tananaev/events{/privacy}","received_events_url":"https://api.github.com/users/tananaev/received_events","type":"User","site_admin":false},"body":"Just use `if (text)` instead.","created_at":"2016-07-21T10:48:51Z","updated_at":"2016-07-21T10:48:51Z","html_url":"https://github.com/tananaev/traccar/pull/2104#discussion_r71684241","pull_request_url":"https://api.github.com/repos/tananaev/traccar/pulls/2104","_links":{"self":{"href":"https://api.github.com/repos/tananaev/traccar/pulls/comments/71684241"},"html":{"href":"https://github.com/tananaev/traccar/pull/2104#discussion_r71684241"},"pull_request":{"href":"https://api.github.com/repos/tananaev/traccar/pulls/2104"}}},"pull_request":{"url":"https://api.github.com/repos/tananaev/traccar/pulls/2104","id":77116272,"html_url":"https://github.com/tananaev/traccar/pull/2104","diff_url":"https://github.com/tananaev/traccar/pull/2104.diff","patch_url":"https://github.com/tananaev/traccar/pull/2104.patch","issue_url":"https://api.github.com/repos/tananaev/traccar/issues/2104","number":2104,"state":"open","locked":false,"title":"Added support for Alarm notifications & positions history cleaner & show alarms in report & Mute button & unlock UI files (for windows)","user":{"login":"ninioe","id":8347415,"avatar_url":"https://avatars.githubusercontent.com/u/8347415?v=3","gravatar_id":"","url":"https://api.github.com/users/ninioe","html_url":"https://github.com/ninioe","followers_url":"https://api.github.com/users/ninioe/followers","following_url":"https://api.github.com/users/ninioe/following{/other_user}","gists_url":"https://api.github.com/users/ninioe/gists{/gist_id}","starred_url":"https://api.github.com/users/ninioe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninioe/subscriptions","organizations_url":"https://api.github.com/users/ninioe/orgs","repos_url":"https://api.github.com/users/ninioe/repos","events_url":"https://api.github.com/users/ninioe/events{/privacy}","received_events_url":"https://api.github.com/users/ninioe/received_events","type":"User","site_admin":false},"body":"1. added support for Alarm and Alarm Type in popup and also in history\r\nrecords. can be muted with a toggle button in the UI\r\n2. added a timer to clear positions history once a day. the default is\r\nto save positions history for 7 days if not defined in the configuration\r\nfile.\r\n3. prevent the lock of the UI files (js, html, css, etc..) for wondows\r\ndevelopers in debug mode. It's easier to do changes to the UI without\r\nstopping the app each time.\r\n4. tools: added support in test-generator.py to simulate Alert, also\r\nadded minify.bat file to compile new js files for the UI using sencha\r\nSDK for windows developers","created_at":"2016-07-12T13:05:35Z","updated_at":"2016-07-21T10:48:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52569e942dc20aa391bfed9026d1055aa8c0af3d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tananaev/traccar/pulls/2104/commits","review_comments_url":"https://api.github.com/repos/tananaev/traccar/pulls/2104/comments","review_comment_url":"https://api.github.com/repos/tananaev/traccar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tananaev/traccar/issues/2104/comments","statuses_url":"https://api.github.com/repos/tananaev/traccar/statuses/2e7987b5df7611299aa76bcc9eca3424ce31d204","head":{"label":"ninioe:master","ref":"master","sha":"2e7987b5df7611299aa76bcc9eca3424ce31d204","user":{"login":"ninioe","id":8347415,"avatar_url":"https://avatars.githubusercontent.com/u/8347415?v=3","gravatar_id":"","url":"https://api.github.com/users/ninioe","html_url":"https://github.com/ninioe","followers_url":"https://api.github.com/users/ninioe/followers","following_url":"https://api.github.com/users/ninioe/following{/other_user}","gists_url":"https://api.github.com/users/ninioe/gists{/gist_id}","starred_url":"https://api.github.com/users/ninioe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninioe/subscriptions","organizations_url":"https://api.github.com/users/ninioe/orgs","repos_url":"https://api.github.com/users/ninioe/repos","events_url":"https://api.github.com/users/ninioe/events{/privacy}","received_events_url":"https://api.github.com/users/ninioe/received_events","type":"User","site_admin":false},"repo":{"id":63135504,"name":"traccar","full_name":"ninioe/traccar","owner":{"login":"ninioe","id":8347415,"avatar_url":"https://avatars.githubusercontent.com/u/8347415?v=3","gravatar_id":"","url":"https://api.github.com/users/ninioe","html_url":"https://github.com/ninioe","followers_url":"https://api.github.com/users/ninioe/followers","following_url":"https://api.github.com/users/ninioe/following{/other_user}","gists_url":"https://api.github.com/users/ninioe/gists{/gist_id}","starred_url":"https://api.github.com/users/ninioe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninioe/subscriptions","organizations_url":"https://api.github.com/users/ninioe/orgs","repos_url":"https://api.github.com/users/ninioe/repos","events_url":"https://api.github.com/users/ninioe/events{/privacy}","received_events_url":"https://api.github.com/users/ninioe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ninioe/traccar","description":"Traccar GPS Tracking System","fork":true,"url":"https://api.github.com/repos/ninioe/traccar","forks_url":"https://api.github.com/repos/ninioe/traccar/forks","keys_url":"https://api.github.com/repos/ninioe/traccar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ninioe/traccar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ninioe/traccar/teams","hooks_url":"https://api.github.com/repos/ninioe/traccar/hooks","issue_events_url":"https://api.github.com/repos/ninioe/traccar/issues/events{/number}","events_url":"https://api.github.com/repos/ninioe/traccar/events","assignees_url":"https://api.github.com/repos/ninioe/traccar/assignees{/user}","branches_url":"https://api.github.com/repos/ninioe/traccar/branches{/branch}","tags_url":"https://api.github.com/repos/ninioe/traccar/tags","blobs_url":"https://api.github.com/repos/ninioe/traccar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ninioe/traccar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ninioe/traccar/git/refs{/sha}","trees_url":"https://api.github.com/repos/ninioe/traccar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ninioe/traccar/statuses/{sha}","languages_url":"https://api.github.com/repos/ninioe/traccar/languages","stargazers_url":"https://api.github.com/repos/ninioe/traccar/stargazers","contributors_url":"https://api.github.com/repos/ninioe/traccar/contributors","subscribers_url":"https://api.github.com/repos/ninioe/traccar/subscribers","subscription_url":"https://api.github.com/repos/ninioe/traccar/subscription","commits_url":"https://api.github.com/repos/ninioe/traccar/commits{/sha}","git_commits_url":"https://api.github.com/repos/ninioe/traccar/git/commits{/sha}","comments_url":"https://api.github.com/repos/ninioe/traccar/comments{/number}","issue_comment_url":"https://api.github.com/repos/ninioe/traccar/issues/comments{/number}","contents_url":"https://api.github.com/repos/ninioe/traccar/contents/{+path}","compare_url":"https://api.github.com/repos/ninioe/traccar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ninioe/traccar/merges","archive_url":"https://api.github.com/repos/ninioe/traccar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ninioe/traccar/downloads","issues_url":"https://api.github.com/repos/ninioe/traccar/issues{/number}","pulls_url":"https://api.github.com/repos/ninioe/traccar/pulls{/number}","milestones_url":"https://api.github.com/repos/ninioe/traccar/milestones{/number}","notifications_url":"https://api.github.com/repos/ninioe/traccar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ninioe/traccar/labels{/name}","releases_url":"https://api.github.com/repos/ninioe/traccar/releases{/id}","deployments_url":"https://api.github.com/repos/ninioe/traccar/deployments","created_at":"2016-07-12T07:14:53Z","updated_at":"2016-07-12T07:14:55Z","pushed_at":"2016-07-21T04:58:54Z","git_url":"git://github.com/ninioe/traccar.git","ssh_url":"git@github.com:ninioe/traccar.git","clone_url":"https://github.com/ninioe/traccar.git","svn_url":"https://github.com/ninioe/traccar","homepage":"https://www.traccar.org","size":7086,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tananaev:master","ref":"master","sha":"00e2f8a3575855a8b863e245005b8f83b3314bfb","user":{"login":"tananaev","id":1161863,"avatar_url":"https://avatars.githubusercontent.com/u/1161863?v=3","gravatar_id":"","url":"https://api.github.com/users/tananaev","html_url":"https://github.com/tananaev","followers_url":"https://api.github.com/users/tananaev/followers","following_url":"https://api.github.com/users/tananaev/following{/other_user}","gists_url":"https://api.github.com/users/tananaev/gists{/gist_id}","starred_url":"https://api.github.com/users/tananaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tananaev/subscriptions","organizations_url":"https://api.github.com/users/tananaev/orgs","repos_url":"https://api.github.com/users/tananaev/repos","events_url":"https://api.github.com/users/tananaev/events{/privacy}","received_events_url":"https://api.github.com/users/tananaev/received_events","type":"User","site_admin":false},"repo":{"id":4038949,"name":"traccar","full_name":"tananaev/traccar","owner":{"login":"tananaev","id":1161863,"avatar_url":"https://avatars.githubusercontent.com/u/1161863?v=3","gravatar_id":"","url":"https://api.github.com/users/tananaev","html_url":"https://github.com/tananaev","followers_url":"https://api.github.com/users/tananaev/followers","following_url":"https://api.github.com/users/tananaev/following{/other_user}","gists_url":"https://api.github.com/users/tananaev/gists{/gist_id}","starred_url":"https://api.github.com/users/tananaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tananaev/subscriptions","organizations_url":"https://api.github.com/users/tananaev/orgs","repos_url":"https://api.github.com/users/tananaev/repos","events_url":"https://api.github.com/users/tananaev/events{/privacy}","received_events_url":"https://api.github.com/users/tananaev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tananaev/traccar","description":"Traccar GPS Tracking System","fork":false,"url":"https://api.github.com/repos/tananaev/traccar","forks_url":"https://api.github.com/repos/tananaev/traccar/forks","keys_url":"https://api.github.com/repos/tananaev/traccar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tananaev/traccar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tananaev/traccar/teams","hooks_url":"https://api.github.com/repos/tananaev/traccar/hooks","issue_events_url":"https://api.github.com/repos/tananaev/traccar/issues/events{/number}","events_url":"https://api.github.com/repos/tananaev/traccar/events","assignees_url":"https://api.github.com/repos/tananaev/traccar/assignees{/user}","branches_url":"https://api.github.com/repos/tananaev/traccar/branches{/branch}","tags_url":"https://api.github.com/repos/tananaev/traccar/tags","blobs_url":"https://api.github.com/repos/tananaev/traccar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tananaev/traccar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tananaev/traccar/git/refs{/sha}","trees_url":"https://api.github.com/repos/tananaev/traccar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tananaev/traccar/statuses/{sha}","languages_url":"https://api.github.com/repos/tananaev/traccar/languages","stargazers_url":"https://api.github.com/repos/tananaev/traccar/stargazers","contributors_url":"https://api.github.com/repos/tananaev/traccar/contributors","subscribers_url":"https://api.github.com/repos/tananaev/traccar/subscribers","subscription_url":"https://api.github.com/repos/tananaev/traccar/subscription","commits_url":"https://api.github.com/repos/tananaev/traccar/commits{/sha}","git_commits_url":"https://api.github.com/repos/tananaev/traccar/git/commits{/sha}","comments_url":"https://api.github.com/repos/tananaev/traccar/comments{/number}","issue_comment_url":"https://api.github.com/repos/tananaev/traccar/issues/comments{/number}","contents_url":"https://api.github.com/repos/tananaev/traccar/contents/{+path}","compare_url":"https://api.github.com/repos/tananaev/traccar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tananaev/traccar/merges","archive_url":"https://api.github.com/repos/tananaev/traccar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tananaev/traccar/downloads","issues_url":"https://api.github.com/repos/tananaev/traccar/issues{/number}","pulls_url":"https://api.github.com/repos/tananaev/traccar/pulls{/number}","milestones_url":"https://api.github.com/repos/tananaev/traccar/milestones{/number}","notifications_url":"https://api.github.com/repos/tananaev/traccar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tananaev/traccar/labels{/name}","releases_url":"https://api.github.com/repos/tananaev/traccar/releases{/id}","deployments_url":"https://api.github.com/repos/tananaev/traccar/deployments","created_at":"2012-04-16T08:33:49Z","updated_at":"2016-07-19T17:37:26Z","pushed_at":"2016-07-21T05:22:53Z","git_url":"git://github.com/tananaev/traccar.git","ssh_url":"git@github.com:tananaev/traccar.git","clone_url":"https://github.com/tananaev/traccar.git","svn_url":"https://github.com/tananaev/traccar","homepage":"https://www.traccar.org","size":8624,"stargazers_count":638,"watchers_count":638,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":574,"mirror_url":null,"open_issues_count":859,"forks":574,"open_issues":859,"watchers":638,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tananaev/traccar/pulls/2104"},"html":{"href":"https://github.com/tananaev/traccar/pull/2104"},"issue":{"href":"https://api.github.com/repos/tananaev/traccar/issues/2104"},"comments":{"href":"https://api.github.com/repos/tananaev/traccar/issues/2104/comments"},"review_comments":{"href":"https://api.github.com/repos/tananaev/traccar/pulls/2104/comments"},"review_comment":{"href":"https://api.github.com/repos/tananaev/traccar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tananaev/traccar/pulls/2104/commits"},"statuses":{"href":"https://api.github.com/repos/tananaev/traccar/statuses/2e7987b5df7611299aa76bcc9eca3424ce31d204"}}}}
{"actor":{"display_login":"tananaev"}}