{"action":"created","comment":{"url":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments/88439275","pull_request_review_id":9011751,"id":88439275,"diff_hunk":"@@ -24,5 +24,6 @@\n     my $schema = shift;\n \n     # now we're done\n-    $schema->resultset(\"JobSettings\")->search({key => {-in => [qw/DISTRI VERSION FLAVOR ARCH MACHINE BUILD TEST/]}})->delete;\n+    $schema->resultset(\"JobSettings\")->search({key => {-in => [qw/DISTRI VERSION FLAVOR ARCH MACHINE BUILD TEST/]}})\n+      ->delete;","path":"dbicdh/_common/upgrade/38-39/004-drop-settings.pl","position":6,"original_position":6,"commit_id":"7ad3c3067d25a43da8859e26cc991cd9e9fe13f1","original_commit_id":"7ad3c3067d25a43da8859e26cc991cd9e9fe13f1","user":{"login":"kraih","id":30094,"avatar_url":"https://avatars.githubusercontent.com/u/30094?v=3","gravatar_id":"","url":"https://api.github.com/users/kraih","html_url":"https://github.com/kraih","followers_url":"https://api.github.com/users/kraih/followers","following_url":"https://api.github.com/users/kraih/following{/other_user}","gists_url":"https://api.github.com/users/kraih/gists{/gist_id}","starred_url":"https://api.github.com/users/kraih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kraih/subscriptions","organizations_url":"https://api.github.com/users/kraih/orgs","repos_url":"https://api.github.com/users/kraih/repos","events_url":"https://api.github.com/users/kraih/events{/privacy}","received_events_url":"https://api.github.com/users/kraih/received_events","type":"User","site_admin":false},"body":"I think it's fine.","created_at":"2016-11-17T12:06:44Z","updated_at":"2016-11-17T12:06:44Z","html_url":"https://github.com/os-autoinst/openQA/pull/1017#discussion_r88439275","pull_request_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1017","_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments/88439275"},"html":{"href":"https://github.com/os-autoinst/openQA/pull/1017#discussion_r88439275"},"pull_request":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1017"}}},"pull_request":{"url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1017","id":94138563,"html_url":"https://github.com/os-autoinst/openQA/pull/1017","diff_url":"https://github.com/os-autoinst/openQA/pull/1017.diff","patch_url":"https://github.com/os-autoinst/openQA/pull/1017.patch","issue_url":"https://api.github.com/repos/os-autoinst/openQA/issues/1017","number":1017,"state":"open","locked":false,"title":"Add a 120 column limit to .perltidyrc","user":{"login":"kraih","id":30094,"avatar_url":"https://avatars.githubusercontent.com/u/30094?v=3","gravatar_id":"","url":"https://api.github.com/users/kraih","html_url":"https://github.com/kraih","followers_url":"https://api.github.com/users/kraih/followers","following_url":"https://api.github.com/users/kraih/following{/other_user}","gists_url":"https://api.github.com/users/kraih/gists{/gist_id}","starred_url":"https://api.github.com/users/kraih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kraih/subscriptions","organizations_url":"https://api.github.com/users/kraih/orgs","repos_url":"https://api.github.com/users/kraih/repos","events_url":"https://api.github.com/users/kraih/events{/privacy}","received_events_url":"https://api.github.com/users/kraih/received_events","type":"User","site_admin":false},"body":"It used to be necessary to hide code like this from perltidy, because it would get folded into unreadable 500 column lines.\r\n```perl\r\n   #<<< do not let perltidy touch this\r\n   $self->render(json =>\r\n                { JobTemplates =>\r\n                    [map { { id => $_->id,\r\n                             prio => $_->prio,\r\n                             group_name => $_->group ? $_->group->name : '',\r\n                             product => {id => $_->product_id,\r\n                                         arch => $_->product->arch,\r\n                                         distri => $_->product->distri,\r\n                                         flavor => $_->product->flavor,\r\n                                         group => $_->product->mediagroup,\r\n                                         version => $_->product->version},\r\n                             machine => {id => $_->machine_id,\r\n                                         name => $_->machine ? $_->machine->name : ''},\r\n                             test_suite => {id => $_->test_suite_id,\r\n                                            name => $_->test_suite->name}}\r\n            } @templates\r\n           ]\r\n         });\r\n   #>>>\r\n```\r\nThat could be avoided by adding a 120 column limit to the `.perltidyrc`.","created_at":"2016-11-17T10:19:47Z","updated_at":"2016-11-17T12:06:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ed8e64884ab9b83a4bf4f33701e37b6b98f2fb6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1017/commits","review_comments_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1017/comments","review_comment_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/os-autoinst/openQA/issues/1017/comments","statuses_url":"https://api.github.com/repos/os-autoinst/openQA/statuses/7ad3c3067d25a43da8859e26cc991cd9e9fe13f1","head":{"label":"kraih:120columns","ref":"120columns","sha":"7ad3c3067d25a43da8859e26cc991cd9e9fe13f1","user":{"login":"kraih","id":30094,"avatar_url":"https://avatars.githubusercontent.com/u/30094?v=3","gravatar_id":"","url":"https://api.github.com/users/kraih","html_url":"https://github.com/kraih","followers_url":"https://api.github.com/users/kraih/followers","following_url":"https://api.github.com/users/kraih/following{/other_user}","gists_url":"https://api.github.com/users/kraih/gists{/gist_id}","starred_url":"https://api.github.com/users/kraih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kraih/subscriptions","organizations_url":"https://api.github.com/users/kraih/orgs","repos_url":"https://api.github.com/users/kraih/repos","events_url":"https://api.github.com/users/kraih/events{/privacy}","received_events_url":"https://api.github.com/users/kraih/received_events","type":"User","site_admin":false},"repo":{"id":73183208,"name":"openQA","full_name":"kraih/openQA","owner":{"login":"kraih","id":30094,"avatar_url":"https://avatars.githubusercontent.com/u/30094?v=3","gravatar_id":"","url":"https://api.github.com/users/kraih","html_url":"https://github.com/kraih","followers_url":"https://api.github.com/users/kraih/followers","following_url":"https://api.github.com/users/kraih/following{/other_user}","gists_url":"https://api.github.com/users/kraih/gists{/gist_id}","starred_url":"https://api.github.com/users/kraih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kraih/subscriptions","organizations_url":"https://api.github.com/users/kraih/orgs","repos_url":"https://api.github.com/users/kraih/repos","events_url":"https://api.github.com/users/kraih/events{/privacy}","received_events_url":"https://api.github.com/users/kraih/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kraih/openQA","description":"openQA web-frontend, scheduler and tools","fork":true,"url":"https://api.github.com/repos/kraih/openQA","forks_url":"https://api.github.com/repos/kraih/openQA/forks","keys_url":"https://api.github.com/repos/kraih/openQA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kraih/openQA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kraih/openQA/teams","hooks_url":"https://api.github.com/repos/kraih/openQA/hooks","issue_events_url":"https://api.github.com/repos/kraih/openQA/issues/events{/number}","events_url":"https://api.github.com/repos/kraih/openQA/events","assignees_url":"https://api.github.com/repos/kraih/openQA/assignees{/user}","branches_url":"https://api.github.com/repos/kraih/openQA/branches{/branch}","tags_url":"https://api.github.com/repos/kraih/openQA/tags","blobs_url":"https://api.github.com/repos/kraih/openQA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kraih/openQA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kraih/openQA/git/refs{/sha}","trees_url":"https://api.github.com/repos/kraih/openQA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kraih/openQA/statuses/{sha}","languages_url":"https://api.github.com/repos/kraih/openQA/languages","stargazers_url":"https://api.github.com/repos/kraih/openQA/stargazers","contributors_url":"https://api.github.com/repos/kraih/openQA/contributors","subscribers_url":"https://api.github.com/repos/kraih/openQA/subscribers","subscription_url":"https://api.github.com/repos/kraih/openQA/subscription","commits_url":"https://api.github.com/repos/kraih/openQA/commits{/sha}","git_commits_url":"https://api.github.com/repos/kraih/openQA/git/commits{/sha}","comments_url":"https://api.github.com/repos/kraih/openQA/comments{/number}","issue_comment_url":"https://api.github.com/repos/kraih/openQA/issues/comments{/number}","contents_url":"https://api.github.com/repos/kraih/openQA/contents/{+path}","compare_url":"https://api.github.com/repos/kraih/openQA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kraih/openQA/merges","archive_url":"https://api.github.com/repos/kraih/openQA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kraih/openQA/downloads","issues_url":"https://api.github.com/repos/kraih/openQA/issues{/number}","pulls_url":"https://api.github.com/repos/kraih/openQA/pulls{/number}","milestones_url":"https://api.github.com/repos/kraih/openQA/milestones{/number}","notifications_url":"https://api.github.com/repos/kraih/openQA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kraih/openQA/labels{/name}","releases_url":"https://api.github.com/repos/kraih/openQA/releases{/id}","deployments_url":"https://api.github.com/repos/kraih/openQA/deployments","created_at":"2016-11-08T12:20:12Z","updated_at":"2016-11-08T12:20:15Z","pushed_at":"2016-11-17T10:40:19Z","git_url":"git://github.com/kraih/openQA.git","ssh_url":"git@github.com:kraih/openQA.git","clone_url":"https://github.com/kraih/openQA.git","svn_url":"https://github.com/kraih/openQA","homepage":"http://openqa.opensuse.org/","size":15989,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"os-autoinst:master","ref":"master","sha":"7aa3c4792c26e4ba64112c0835183902a173d359","user":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars.githubusercontent.com/u/6918706?v=3","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"repo":{"id":20883829,"name":"openQA","full_name":"os-autoinst/openQA","owner":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars.githubusercontent.com/u/6918706?v=3","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/os-autoinst/openQA","description":"openQA web-frontend, scheduler and tools","fork":false,"url":"https://api.github.com/repos/os-autoinst/openQA","forks_url":"https://api.github.com/repos/os-autoinst/openQA/forks","keys_url":"https://api.github.com/repos/os-autoinst/openQA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/os-autoinst/openQA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/os-autoinst/openQA/teams","hooks_url":"https://api.github.com/repos/os-autoinst/openQA/hooks","issue_events_url":"https://api.github.com/repos/os-autoinst/openQA/issues/events{/number}","events_url":"https://api.github.com/repos/os-autoinst/openQA/events","assignees_url":"https://api.github.com/repos/os-autoinst/openQA/assignees{/user}","branches_url":"https://api.github.com/repos/os-autoinst/openQA/branches{/branch}","tags_url":"https://api.github.com/repos/os-autoinst/openQA/tags","blobs_url":"https://api.github.com/repos/os-autoinst/openQA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/os-autoinst/openQA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/os-autoinst/openQA/git/refs{/sha}","trees_url":"https://api.github.com/repos/os-autoinst/openQA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/os-autoinst/openQA/statuses/{sha}","languages_url":"https://api.github.com/repos/os-autoinst/openQA/languages","stargazers_url":"https://api.github.com/repos/os-autoinst/openQA/stargazers","contributors_url":"https://api.github.com/repos/os-autoinst/openQA/contributors","subscribers_url":"https://api.github.com/repos/os-autoinst/openQA/subscribers","subscription_url":"https://api.github.com/repos/os-autoinst/openQA/subscription","commits_url":"https://api.github.com/repos/os-autoinst/openQA/commits{/sha}","git_commits_url":"https://api.github.com/repos/os-autoinst/openQA/git/commits{/sha}","comments_url":"https://api.github.com/repos/os-autoinst/openQA/comments{/number}","issue_comment_url":"https://api.github.com/repos/os-autoinst/openQA/issues/comments{/number}","contents_url":"https://api.github.com/repos/os-autoinst/openQA/contents/{+path}","compare_url":"https://api.github.com/repos/os-autoinst/openQA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/os-autoinst/openQA/merges","archive_url":"https://api.github.com/repos/os-autoinst/openQA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/os-autoinst/openQA/downloads","issues_url":"https://api.github.com/repos/os-autoinst/openQA/issues{/number}","pulls_url":"https://api.github.com/repos/os-autoinst/openQA/pulls{/number}","milestones_url":"https://api.github.com/repos/os-autoinst/openQA/milestones{/number}","notifications_url":"https://api.github.com/repos/os-autoinst/openQA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/os-autoinst/openQA/labels{/name}","releases_url":"https://api.github.com/repos/os-autoinst/openQA/releases{/id}","deployments_url":"https://api.github.com/repos/os-autoinst/openQA/deployments","created_at":"2014-06-16T12:23:22Z","updated_at":"2016-11-16T19:43:39Z","pushed_at":"2016-11-17T11:54:01Z","git_url":"git://github.com/os-autoinst/openQA.git","ssh_url":"git@github.com:os-autoinst/openQA.git","clone_url":"https://github.com/os-autoinst/openQA.git","svn_url":"https://github.com/os-autoinst/openQA","homepage":"http://openqa.opensuse.org/","size":17324,"stargazers_count":73,"watchers_count":73,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":57,"mirror_url":null,"open_issues_count":21,"forks":57,"open_issues":21,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1017"},"html":{"href":"https://github.com/os-autoinst/openQA/pull/1017"},"issue":{"href":"https://api.github.com/repos/os-autoinst/openQA/issues/1017"},"comments":{"href":"https://api.github.com/repos/os-autoinst/openQA/issues/1017/comments"},"review_comments":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1017/comments"},"review_comment":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1017/commits"},"statuses":{"href":"https://api.github.com/repos/os-autoinst/openQA/statuses/7ad3c3067d25a43da8859e26cc991cd9e9fe13f1"}}}}
{"actor":{"display_login":"kraih"}}