{"action":"closed","number":365,"pull_request":{"url":"https://api.github.com/repos/plumatic/schema/pulls/365","id":78024108,"html_url":"https://github.com/plumatic/schema/pull/365","diff_url":"https://github.com/plumatic/schema/pull/365.diff","patch_url":"https://github.com/plumatic/schema/pull/365.patch","issue_url":"https://api.github.com/repos/plumatic/schema/issues/365","number":365,"state":"closed","locked":false,"title":"Allow custom fn validation","user":{"login":"gfredericks","id":135443,"avatar_url":"https://avatars.githubusercontent.com/u/135443?v=3","gravatar_id":"","url":"https://api.github.com/users/gfredericks","html_url":"https://github.com/gfredericks","followers_url":"https://api.github.com/users/gfredericks/followers","following_url":"https://api.github.com/users/gfredericks/following{/other_user}","gists_url":"https://api.github.com/users/gfredericks/gists{/gist_id}","starred_url":"https://api.github.com/users/gfredericks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfredericks/subscriptions","organizations_url":"https://api.github.com/users/gfredericks/orgs","repos_url":"https://api.github.com/users/gfredericks/repos","events_url":"https://api.github.com/users/gfredericks/events{/privacy}","received_events_url":"https://api.github.com/users/gfredericks/received_events","type":"User","site_admin":false},"body":"this is a proof-of-concept for being able to customize the fn-validation logic (by setting `use-fn-validation` to a function), which lets you implement things like:\r\n\r\n1. soft runtime checks that only log warnings (or something) on schema failures\r\n2. soft runtime checks that only happen a small percentage of the time to minimize the performance cost\r\n\r\nI'd be happy to tweak, add tests, etc. if this is a desired feature.\r\n\r\nThe main use case for this for me is when retrofitting schemas on a legacy project, it's nice to be able to deploy the schemas to production to get feedback about their correctness without causing exceptions to be thrown.","created_at":"2016-07-19T18:19:46Z","updated_at":"2016-07-22T17:16:56Z","closed_at":"2016-07-22T17:16:56Z","merged_at":"2016-07-22T17:16:56Z","merge_commit_sha":"611ce44ac31e7ff0d965d2cda114982fcdd6b174","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/plumatic/schema/pulls/365/commits","review_comments_url":"https://api.github.com/repos/plumatic/schema/pulls/365/comments","review_comment_url":"https://api.github.com/repos/plumatic/schema/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plumatic/schema/issues/365/comments","statuses_url":"https://api.github.com/repos/plumatic/schema/statuses/78cf0d21b8886ee2000e28b83b5027c4ae842a17","head":{"label":"gfredericks:custom-fn-validation","ref":"custom-fn-validation","sha":"78cf0d21b8886ee2000e28b83b5027c4ae842a17","user":{"login":"gfredericks","id":135443,"avatar_url":"https://avatars.githubusercontent.com/u/135443?v=3","gravatar_id":"","url":"https://api.github.com/users/gfredericks","html_url":"https://github.com/gfredericks","followers_url":"https://api.github.com/users/gfredericks/followers","following_url":"https://api.github.com/users/gfredericks/following{/other_user}","gists_url":"https://api.github.com/users/gfredericks/gists{/gist_id}","starred_url":"https://api.github.com/users/gfredericks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfredericks/subscriptions","organizations_url":"https://api.github.com/users/gfredericks/orgs","repos_url":"https://api.github.com/users/gfredericks/repos","events_url":"https://api.github.com/users/gfredericks/events{/privacy}","received_events_url":"https://api.github.com/users/gfredericks/received_events","type":"User","site_admin":false},"repo":{"id":37215666,"name":"schema","full_name":"gfredericks/schema","owner":{"login":"gfredericks","id":135443,"avatar_url":"https://avatars.githubusercontent.com/u/135443?v=3","gravatar_id":"","url":"https://api.github.com/users/gfredericks","html_url":"https://github.com/gfredericks","followers_url":"https://api.github.com/users/gfredericks/followers","following_url":"https://api.github.com/users/gfredericks/following{/other_user}","gists_url":"https://api.github.com/users/gfredericks/gists{/gist_id}","starred_url":"https://api.github.com/users/gfredericks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfredericks/subscriptions","organizations_url":"https://api.github.com/users/gfredericks/orgs","repos_url":"https://api.github.com/users/gfredericks/repos","events_url":"https://api.github.com/users/gfredericks/events{/privacy}","received_events_url":"https://api.github.com/users/gfredericks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gfredericks/schema","description":"Clojure(Script) library for declarative data description and validation","fork":true,"url":"https://api.github.com/repos/gfredericks/schema","forks_url":"https://api.github.com/repos/gfredericks/schema/forks","keys_url":"https://api.github.com/repos/gfredericks/schema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gfredericks/schema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gfredericks/schema/teams","hooks_url":"https://api.github.com/repos/gfredericks/schema/hooks","issue_events_url":"https://api.github.com/repos/gfredericks/schema/issues/events{/number}","events_url":"https://api.github.com/repos/gfredericks/schema/events","assignees_url":"https://api.github.com/repos/gfredericks/schema/assignees{/user}","branches_url":"https://api.github.com/repos/gfredericks/schema/branches{/branch}","tags_url":"https://api.github.com/repos/gfredericks/schema/tags","blobs_url":"https://api.github.com/repos/gfredericks/schema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gfredericks/schema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gfredericks/schema/git/refs{/sha}","trees_url":"https://api.github.com/repos/gfredericks/schema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gfredericks/schema/statuses/{sha}","languages_url":"https://api.github.com/repos/gfredericks/schema/languages","stargazers_url":"https://api.github.com/repos/gfredericks/schema/stargazers","contributors_url":"https://api.github.com/repos/gfredericks/schema/contributors","subscribers_url":"https://api.github.com/repos/gfredericks/schema/subscribers","subscription_url":"https://api.github.com/repos/gfredericks/schema/subscription","commits_url":"https://api.github.com/repos/gfredericks/schema/commits{/sha}","git_commits_url":"https://api.github.com/repos/gfredericks/schema/git/commits{/sha}","comments_url":"https://api.github.com/repos/gfredericks/schema/comments{/number}","issue_comment_url":"https://api.github.com/repos/gfredericks/schema/issues/comments{/number}","contents_url":"https://api.github.com/repos/gfredericks/schema/contents/{+path}","compare_url":"https://api.github.com/repos/gfredericks/schema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gfredericks/schema/merges","archive_url":"https://api.github.com/repos/gfredericks/schema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gfredericks/schema/downloads","issues_url":"https://api.github.com/repos/gfredericks/schema/issues{/number}","pulls_url":"https://api.github.com/repos/gfredericks/schema/pulls{/number}","milestones_url":"https://api.github.com/repos/gfredericks/schema/milestones{/number}","notifications_url":"https://api.github.com/repos/gfredericks/schema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gfredericks/schema/labels{/name}","releases_url":"https://api.github.com/repos/gfredericks/schema/releases{/id}","deployments_url":"https://api.github.com/repos/gfredericks/schema/deployments","created_at":"2015-06-10T18:41:50Z","updated_at":"2015-06-10T18:41:50Z","pushed_at":"2016-07-22T15:37:29Z","git_url":"git://github.com/gfredericks/schema.git","ssh_url":"git@github.com:gfredericks/schema.git","clone_url":"https://github.com/gfredericks/schema.git","svn_url":"https://github.com/gfredericks/schema","homepage":"","size":1315,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"plumatic:master","ref":"master","sha":"8f3dfddbf9ce03e1dbee236799712152d939ac9f","user":{"login":"plumatic","id":1073038,"avatar_url":"https://avatars.githubusercontent.com/u/1073038?v=3","gravatar_id":"","url":"https://api.github.com/users/plumatic","html_url":"https://github.com/plumatic","followers_url":"https://api.github.com/users/plumatic/followers","following_url":"https://api.github.com/users/plumatic/following{/other_user}","gists_url":"https://api.github.com/users/plumatic/gists{/gist_id}","starred_url":"https://api.github.com/users/plumatic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plumatic/subscriptions","organizations_url":"https://api.github.com/users/plumatic/orgs","repos_url":"https://api.github.com/users/plumatic/repos","events_url":"https://api.github.com/users/plumatic/events{/privacy}","received_events_url":"https://api.github.com/users/plumatic/received_events","type":"Organization","site_admin":false},"repo":{"id":11594840,"name":"schema","full_name":"plumatic/schema","owner":{"login":"plumatic","id":1073038,"avatar_url":"https://avatars.githubusercontent.com/u/1073038?v=3","gravatar_id":"","url":"https://api.github.com/users/plumatic","html_url":"https://github.com/plumatic","followers_url":"https://api.github.com/users/plumatic/followers","following_url":"https://api.github.com/users/plumatic/following{/other_user}","gists_url":"https://api.github.com/users/plumatic/gists{/gist_id}","starred_url":"https://api.github.com/users/plumatic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plumatic/subscriptions","organizations_url":"https://api.github.com/users/plumatic/orgs","repos_url":"https://api.github.com/users/plumatic/repos","events_url":"https://api.github.com/users/plumatic/events{/privacy}","received_events_url":"https://api.github.com/users/plumatic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plumatic/schema","description":"Clojure(Script) library for declarative data description and validation","fork":false,"url":"https://api.github.com/repos/plumatic/schema","forks_url":"https://api.github.com/repos/plumatic/schema/forks","keys_url":"https://api.github.com/repos/plumatic/schema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plumatic/schema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plumatic/schema/teams","hooks_url":"https://api.github.com/repos/plumatic/schema/hooks","issue_events_url":"https://api.github.com/repos/plumatic/schema/issues/events{/number}","events_url":"https://api.github.com/repos/plumatic/schema/events","assignees_url":"https://api.github.com/repos/plumatic/schema/assignees{/user}","branches_url":"https://api.github.com/repos/plumatic/schema/branches{/branch}","tags_url":"https://api.github.com/repos/plumatic/schema/tags","blobs_url":"https://api.github.com/repos/plumatic/schema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plumatic/schema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plumatic/schema/git/refs{/sha}","trees_url":"https://api.github.com/repos/plumatic/schema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plumatic/schema/statuses/{sha}","languages_url":"https://api.github.com/repos/plumatic/schema/languages","stargazers_url":"https://api.github.com/repos/plumatic/schema/stargazers","contributors_url":"https://api.github.com/repos/plumatic/schema/contributors","subscribers_url":"https://api.github.com/repos/plumatic/schema/subscribers","subscription_url":"https://api.github.com/repos/plumatic/schema/subscription","commits_url":"https://api.github.com/repos/plumatic/schema/commits{/sha}","git_commits_url":"https://api.github.com/repos/plumatic/schema/git/commits{/sha}","comments_url":"https://api.github.com/repos/plumatic/schema/comments{/number}","issue_comment_url":"https://api.github.com/repos/plumatic/schema/issues/comments{/number}","contents_url":"https://api.github.com/repos/plumatic/schema/contents/{+path}","compare_url":"https://api.github.com/repos/plumatic/schema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plumatic/schema/merges","archive_url":"https://api.github.com/repos/plumatic/schema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plumatic/schema/downloads","issues_url":"https://api.github.com/repos/plumatic/schema/issues{/number}","pulls_url":"https://api.github.com/repos/plumatic/schema/pulls{/number}","milestones_url":"https://api.github.com/repos/plumatic/schema/milestones{/number}","notifications_url":"https://api.github.com/repos/plumatic/schema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plumatic/schema/labels{/name}","releases_url":"https://api.github.com/repos/plumatic/schema/releases{/id}","deployments_url":"https://api.github.com/repos/plumatic/schema/deployments","created_at":"2013-07-22T23:26:46Z","updated_at":"2016-07-22T17:10:56Z","pushed_at":"2016-07-22T17:16:57Z","git_url":"git://github.com/plumatic/schema.git","ssh_url":"git@github.com:plumatic/schema.git","clone_url":"https://github.com/plumatic/schema.git","svn_url":"https://github.com/plumatic/schema","homepage":"","size":1678,"stargazers_count":1616,"watchers_count":1616,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":186,"mirror_url":null,"open_issues_count":15,"forks":186,"open_issues":15,"watchers":1616,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plumatic/schema/pulls/365"},"html":{"href":"https://github.com/plumatic/schema/pull/365"},"issue":{"href":"https://api.github.com/repos/plumatic/schema/issues/365"},"comments":{"href":"https://api.github.com/repos/plumatic/schema/issues/365/comments"},"review_comments":{"href":"https://api.github.com/repos/plumatic/schema/pulls/365/comments"},"review_comment":{"href":"https://api.github.com/repos/plumatic/schema/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plumatic/schema/pulls/365/commits"},"statuses":{"href":"https://api.github.com/repos/plumatic/schema/statuses/78cf0d21b8886ee2000e28b83b5027c4ae842a17"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"w01fe","id":135078,"avatar_url":"https://avatars.githubusercontent.com/u/135078?v=3","gravatar_id":"","url":"https://api.github.com/users/w01fe","html_url":"https://github.com/w01fe","followers_url":"https://api.github.com/users/w01fe/followers","following_url":"https://api.github.com/users/w01fe/following{/other_user}","gists_url":"https://api.github.com/users/w01fe/gists{/gist_id}","starred_url":"https://api.github.com/users/w01fe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w01fe/subscriptions","organizations_url":"https://api.github.com/users/w01fe/orgs","repos_url":"https://api.github.com/users/w01fe/repos","events_url":"https://api.github.com/users/w01fe/events{/privacy}","received_events_url":"https://api.github.com/users/w01fe/received_events","type":"User","site_admin":false},"comments":15,"review_comments":0,"commits":1,"additions":54,"deletions":8,"changed_files":3}}
{"actor":{"display_login":"w01fe"}}