{"action":"created","comment":{"url":"https://api.github.com/repos/InfraSIM/infrasim-compute/pulls/comments/80690928","pull_request_review_id":1730258,"id":80690928,"diff_hunk":"@@ -165,3 +166,40 @@ def test_qemu_local_user(self):\n         print lines\n         ssh.close()\n         assert \"admin\" in lines\n+\n+    def test_smbios_data(self):\n+        ssh = paramiko.SSHClient()\n+        ssh.set_missing_host_key_policy(paramiko.AutoAddPolicy())\n+        ssh.connect(\"127.0.0.1\", port=2222, username=\"root\", password=\"root\",timeout=10)\n+        stdin, stdout, stderr = ssh.exec_command(\"dmidecode -t1\")\n+        while not stdout.channel.exit_status_ready():\n+            pass\n+\n+        lines = stdout.channel.recv(2048)\n+        print lines\n+\n+        ssh.close()\n+        with open(\"test.yml\", \"r\") as yml_file:\n+            self.conf= yaml.load(yml_file)\n+\n+        if self.conf[\"type\"] == \"quanta_d51\":\n+            assert \"Manufacturer: Quanta Computer Inc\" in lines\n+            assert \"Product Name: D51B-2U (dual 10G LoM)\" in lines\n+        if self.conf[\"type\"] == \"quanta_t41\":\n+            assert \"Manufacturer: QuantaPlex Computer Inc\" in lines\n+            assert \"Product Name: QuantaPlex T41S-2U\" in lines\n+        if self.conf[\"type\"] == \"dell_c6320\":\n+            assert \"Manufacturer: Dell Inc\" in lines\n+            assert \"Product Name: PowerEdge C6320\" in lines\n+        if self.conf[\"type\"] == \"dell_r630\":\n+            assert \"Manufacturer: Dell Inc\" in lines\n+            assert \"Product Name: PowerEdge R630\" in lines\n+        if self.conf[\"type\"] == \"s2600kp\":\n+            assert \"Manufacturer: EMC\" in lines\n+            assert \"Product Name: S2600KP\" in lines\n+        if self.conf[\"type\"] == \"s2600tp\":\n+            assert \"Manufacturer: EMC\" in lines\n+            assert \"Product Name: S2600TP\" in lines\n+        if self.conf[\"type\"] == \"s2600wtt\":\n+            assert \"Manufacturer: EMC\" in lines\n+            assert \"Product Name: S2600WTT\" in lines","path":"test/functional/test_ipmi_kcs.py","position":57,"original_position":57,"commit_id":"3743b9b184588e8c91a14747fc3c13222066dd37","original_commit_id":"3743b9b184588e8c91a14747fc3c13222066dd37","user":{"login":"turtle-fly","id":3271116,"avatar_url":"https://avatars.githubusercontent.com/u/3271116?v=3","gravatar_id":"","url":"https://api.github.com/users/turtle-fly","html_url":"https://github.com/turtle-fly","followers_url":"https://api.github.com/users/turtle-fly/followers","following_url":"https://api.github.com/users/turtle-fly/following{/other_user}","gists_url":"https://api.github.com/users/turtle-fly/gists{/gist_id}","starred_url":"https://api.github.com/users/turtle-fly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turtle-fly/subscriptions","organizations_url":"https://api.github.com/users/turtle-fly/orgs","repos_url":"https://api.github.com/users/turtle-fly/repos","events_url":"https://api.github.com/users/turtle-fly/events{/privacy}","received_events_url":"https://api.github.com/users/turtle-fly/received_events","type":"User","site_admin":false},"body":"@JuneZhou19 , test.yml always host the type as \"quanta_d51\" by default, so you can keep one node type instead of 7.\r\nTake coverage on several node type into consideration, I suggest adding test with node type changed, by doing so, you can easily add another test once we support other nodes. ","created_at":"2016-09-27T13:27:34Z","updated_at":"2016-09-27T13:27:35Z","html_url":"https://github.com/InfraSIM/infrasim-compute/pull/103#discussion_r80690928","pull_request_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/pulls/103","_links":{"self":{"href":"https://api.github.com/repos/InfraSIM/infrasim-compute/pulls/comments/80690928"},"html":{"href":"https://github.com/InfraSIM/infrasim-compute/pull/103#discussion_r80690928"},"pull_request":{"href":"https://api.github.com/repos/InfraSIM/infrasim-compute/pulls/103"}}},"pull_request":{"url":"https://api.github.com/repos/InfraSIM/infrasim-compute/pulls/103","id":86864245,"html_url":"https://github.com/InfraSIM/infrasim-compute/pull/103","diff_url":"https://github.com/InfraSIM/infrasim-compute/pull/103.diff","patch_url":"https://github.com/InfraSIM/infrasim-compute/pull/103.patch","issue_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/issues/103","number":103,"state":"open","locked":false,"title":"Add test for SMBIOS data verification.","user":{"login":"JuneZhou19","id":16203645,"avatar_url":"https://avatars.githubusercontent.com/u/16203645?v=3","gravatar_id":"","url":"https://api.github.com/users/JuneZhou19","html_url":"https://github.com/JuneZhou19","followers_url":"https://api.github.com/users/JuneZhou19/followers","following_url":"https://api.github.com/users/JuneZhou19/following{/other_user}","gists_url":"https://api.github.com/users/JuneZhou19/gists{/gist_id}","starred_url":"https://api.github.com/users/JuneZhou19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuneZhou19/subscriptions","organizations_url":"https://api.github.com/users/JuneZhou19/orgs","repos_url":"https://api.github.com/users/JuneZhou19/repos","events_url":"https://api.github.com/users/JuneZhou19/events{/privacy}","received_events_url":"https://api.github.com/users/JuneZhou19/received_events","type":"User","site_admin":false},"body":"@MarkMa001 @fub2 @turtle-fly @XiaowenJiang @xiar ","created_at":"2016-09-27T05:28:09Z","updated_at":"2016-09-27T13:27:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"536fe4d2b8e18d7a55bdda82a00be26386119be5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/pulls/103/commits","review_comments_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/pulls/103/comments","review_comment_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/pulls/comments{/number}","comments_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/issues/103/comments","statuses_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/statuses/3743b9b184588e8c91a14747fc3c13222066dd37","head":{"label":"JuneZhou19:master","ref":"master","sha":"3743b9b184588e8c91a14747fc3c13222066dd37","user":{"login":"JuneZhou19","id":16203645,"avatar_url":"https://avatars.githubusercontent.com/u/16203645?v=3","gravatar_id":"","url":"https://api.github.com/users/JuneZhou19","html_url":"https://github.com/JuneZhou19","followers_url":"https://api.github.com/users/JuneZhou19/followers","following_url":"https://api.github.com/users/JuneZhou19/following{/other_user}","gists_url":"https://api.github.com/users/JuneZhou19/gists{/gist_id}","starred_url":"https://api.github.com/users/JuneZhou19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuneZhou19/subscriptions","organizations_url":"https://api.github.com/users/JuneZhou19/orgs","repos_url":"https://api.github.com/users/JuneZhou19/repos","events_url":"https://api.github.com/users/JuneZhou19/events{/privacy}","received_events_url":"https://api.github.com/users/JuneZhou19/received_events","type":"User","site_admin":false},"repo":{"id":61280249,"name":"infrasim-compute","full_name":"JuneZhou19/infrasim-compute","owner":{"login":"JuneZhou19","id":16203645,"avatar_url":"https://avatars.githubusercontent.com/u/16203645?v=3","gravatar_id":"","url":"https://api.github.com/users/JuneZhou19","html_url":"https://github.com/JuneZhou19","followers_url":"https://api.github.com/users/JuneZhou19/followers","following_url":"https://api.github.com/users/JuneZhou19/following{/other_user}","gists_url":"https://api.github.com/users/JuneZhou19/gists{/gist_id}","starred_url":"https://api.github.com/users/JuneZhou19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuneZhou19/subscriptions","organizations_url":"https://api.github.com/users/JuneZhou19/orgs","repos_url":"https://api.github.com/users/JuneZhou19/repos","events_url":"https://api.github.com/users/JuneZhou19/events{/privacy}","received_events_url":"https://api.github.com/users/JuneZhou19/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JuneZhou19/infrasim-compute","description":"","fork":true,"url":"https://api.github.com/repos/JuneZhou19/infrasim-compute","forks_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/forks","keys_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/teams","hooks_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/hooks","issue_events_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/issues/events{/number}","events_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/events","assignees_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/assignees{/user}","branches_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/branches{/branch}","tags_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/tags","blobs_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/statuses/{sha}","languages_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/languages","stargazers_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/stargazers","contributors_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/contributors","subscribers_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/subscribers","subscription_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/subscription","commits_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/contents/{+path}","compare_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/merges","archive_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/downloads","issues_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/issues{/number}","pulls_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/pulls{/number}","milestones_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/milestones{/number}","notifications_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/labels{/name}","releases_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/releases{/id}","deployments_url":"https://api.github.com/repos/JuneZhou19/infrasim-compute/deployments","created_at":"2016-06-16T09:32:34Z","updated_at":"2016-06-16T09:32:35Z","pushed_at":"2016-09-27T05:26:37Z","git_url":"git://github.com/JuneZhou19/infrasim-compute.git","ssh_url":"git@github.com:JuneZhou19/infrasim-compute.git","clone_url":"https://github.com/JuneZhou19/infrasim-compute.git","svn_url":"https://github.com/JuneZhou19/infrasim-compute","homepage":null,"size":19370,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"InfraSIM:master","ref":"master","sha":"2928ee0acc378596d1ac0bccac351c7125d622ef","user":{"login":"InfraSIM","id":15829902,"avatar_url":"https://avatars.githubusercontent.com/u/15829902?v=3","gravatar_id":"","url":"https://api.github.com/users/InfraSIM","html_url":"https://github.com/InfraSIM","followers_url":"https://api.github.com/users/InfraSIM/followers","following_url":"https://api.github.com/users/InfraSIM/following{/other_user}","gists_url":"https://api.github.com/users/InfraSIM/gists{/gist_id}","starred_url":"https://api.github.com/users/InfraSIM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InfraSIM/subscriptions","organizations_url":"https://api.github.com/users/InfraSIM/orgs","repos_url":"https://api.github.com/users/InfraSIM/repos","events_url":"https://api.github.com/users/InfraSIM/events{/privacy}","received_events_url":"https://api.github.com/users/InfraSIM/received_events","type":"Organization","site_admin":false},"repo":{"id":60502320,"name":"infrasim-compute","full_name":"InfraSIM/infrasim-compute","owner":{"login":"InfraSIM","id":15829902,"avatar_url":"https://avatars.githubusercontent.com/u/15829902?v=3","gravatar_id":"","url":"https://api.github.com/users/InfraSIM","html_url":"https://github.com/InfraSIM","followers_url":"https://api.github.com/users/InfraSIM/followers","following_url":"https://api.github.com/users/InfraSIM/following{/other_user}","gists_url":"https://api.github.com/users/InfraSIM/gists{/gist_id}","starred_url":"https://api.github.com/users/InfraSIM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InfraSIM/subscriptions","organizations_url":"https://api.github.com/users/InfraSIM/orgs","repos_url":"https://api.github.com/users/InfraSIM/repos","events_url":"https://api.github.com/users/InfraSIM/events{/privacy}","received_events_url":"https://api.github.com/users/InfraSIM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/InfraSIM/infrasim-compute","description":"","fork":false,"url":"https://api.github.com/repos/InfraSIM/infrasim-compute","forks_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/forks","keys_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/keys{/key_id}","collaborators_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/teams","hooks_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/hooks","issue_events_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/issues/events{/number}","events_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/events","assignees_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/assignees{/user}","branches_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/branches{/branch}","tags_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/tags","blobs_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/git/refs{/sha}","trees_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/git/trees{/sha}","statuses_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/statuses/{sha}","languages_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/languages","stargazers_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/stargazers","contributors_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/contributors","subscribers_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/subscribers","subscription_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/subscription","commits_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/commits{/sha}","git_commits_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/git/commits{/sha}","comments_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/comments{/number}","issue_comment_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/issues/comments{/number}","contents_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/contents/{+path}","compare_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/compare/{base}...{head}","merges_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/merges","archive_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/downloads","issues_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/issues{/number}","pulls_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/pulls{/number}","milestones_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/milestones{/number}","notifications_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/labels{/name}","releases_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/releases{/id}","deployments_url":"https://api.github.com/repos/InfraSIM/infrasim-compute/deployments","created_at":"2016-06-06T06:01:41Z","updated_at":"2016-09-12T02:45:58Z","pushed_at":"2016-09-27T09:36:44Z","git_url":"git://github.com/InfraSIM/infrasim-compute.git","ssh_url":"git@github.com:InfraSIM/infrasim-compute.git","clone_url":"https://github.com/InfraSIM/infrasim-compute.git","svn_url":"https://github.com/InfraSIM/infrasim-compute","homepage":null,"size":19406,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":4,"forks":11,"open_issues":4,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/InfraSIM/infrasim-compute/pulls/103"},"html":{"href":"https://github.com/InfraSIM/infrasim-compute/pull/103"},"issue":{"href":"https://api.github.com/repos/InfraSIM/infrasim-compute/issues/103"},"comments":{"href":"https://api.github.com/repos/InfraSIM/infrasim-compute/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/InfraSIM/infrasim-compute/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/InfraSIM/infrasim-compute/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/InfraSIM/infrasim-compute/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/InfraSIM/infrasim-compute/statuses/3743b9b184588e8c91a14747fc3c13222066dd37"}}}}
{"actor":{"display_login":"turtle-fly"}}