{"action":"closed","number":34,"pull_request":{"url":"https://api.github.com/repos/libretro/nestopia/pulls/34","id":91503184,"html_url":"https://github.com/libretro/nestopia/pull/34","diff_url":"https://github.com/libretro/nestopia/pull/34.diff","patch_url":"https://github.com/libretro/nestopia/pull/34.patch","issue_url":"https://api.github.com/repos/libretro/nestopia/issues/34","number":34,"state":"closed","locked":false,"title":"Fix mismatched name against info","user":{"login":"lasers","id":852504,"avatar_url":"https://avatars.githubusercontent.com/u/852504?v=3","gravatar_id":"","url":"https://api.github.com/users/lasers","html_url":"https://github.com/lasers","followers_url":"https://api.github.com/users/lasers/followers","following_url":"https://api.github.com/users/lasers/following{/other_user}","gists_url":"https://api.github.com/users/lasers/gists{/gist_id}","starred_url":"https://api.github.com/users/lasers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasers/subscriptions","organizations_url":"https://api.github.com/users/lasers/orgs","repos_url":"https://api.github.com/users/lasers/repos","events_url":"https://api.github.com/users/lasers/events{/privacy}","received_events_url":"https://api.github.com/users/lasers/received_events","type":"User","site_admin":false},"body":"As of right now, the information does not match.\n\nThe  file `nestopia_libretro.info` contains this.\n\n```\ndisplay_name = \"NES / Famicom (Nestopia UE)\"\nauthors = \"Martin Freij|R. Belmont|R. Danbrook\"\nsupported_extensions = \"nes|fds\"\ncorename = \"Nestopia UE\"\nmanufacturer = \"Nintendo\"\ncategories = \"Emulator\"\nsystemname = \"Nintendo Entertainment System\"\ndatabase = \"Nintendo - Nintendo Entertainment System|Nintendo - Famicom Disk System\"\nlicense = \"GPLv2\"\npermissions = \"\"\ndisplay_version = \"v1.47-WIP\"\nsupports_no_game = \"false\"\nfirmware_count = 1\nfirmware0_desc = \"disksys.rom (Famicom Disk System BIOS)\"\nfirmware0_path = \"disksys.rom\"\nfirmware0_opt = \"false\"\nnotes = \"Suggested md5sum:|CA30B50F880EB660A320674ED365EF7A = disksys.rom\"\n```\n\nThis file will change from `Nestopia` to `Nestopia UE` as a corename to match the file. This can upset users as they will find their folders switching from Nestopia to Nestopia UE.\n\nI looked for this because to use per-core override, the corename inside *.info should be used to set up directories (config, saves, etc)... so I did that.\n\nThe Nestopia/Nestopia UE naming caught my attention as everything would keep making Nestopia instead of Nestopia UE.\n\nWe could fix nestopia_libretro.info instead? It just wouldn't be Nestopia UE accurate. \n\n_(Lot of trailing whitespaces everywhere. The only change is on line 279.)_\n","created_at":"2016-10-29T21:52:37Z","updated_at":"2016-11-01T00:21:51Z","closed_at":"2016-11-01T00:21:51Z","merged_at":null,"merge_commit_sha":"93d6e99bcc40362624a3fd5807c7a47e410100d3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/libretro/nestopia/pulls/34/commits","review_comments_url":"https://api.github.com/repos/libretro/nestopia/pulls/34/comments","review_comment_url":"https://api.github.com/repos/libretro/nestopia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libretro/nestopia/issues/34/comments","statuses_url":"https://api.github.com/repos/libretro/nestopia/statuses/44679d9b8281811cfbeaff40496ed48f4a41fd83","head":{"label":"lasers:master","ref":"master","sha":"44679d9b8281811cfbeaff40496ed48f4a41fd83","user":{"login":"lasers","id":852504,"avatar_url":"https://avatars.githubusercontent.com/u/852504?v=3","gravatar_id":"","url":"https://api.github.com/users/lasers","html_url":"https://github.com/lasers","followers_url":"https://api.github.com/users/lasers/followers","following_url":"https://api.github.com/users/lasers/following{/other_user}","gists_url":"https://api.github.com/users/lasers/gists{/gist_id}","starred_url":"https://api.github.com/users/lasers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasers/subscriptions","organizations_url":"https://api.github.com/users/lasers/orgs","repos_url":"https://api.github.com/users/lasers/repos","events_url":"https://api.github.com/users/lasers/events{/privacy}","received_events_url":"https://api.github.com/users/lasers/received_events","type":"User","site_admin":false},"repo":{"id":72310511,"name":"nestopia","full_name":"lasers/nestopia","owner":{"login":"lasers","id":852504,"avatar_url":"https://avatars.githubusercontent.com/u/852504?v=3","gravatar_id":"","url":"https://api.github.com/users/lasers","html_url":"https://github.com/lasers","followers_url":"https://api.github.com/users/lasers/followers","following_url":"https://api.github.com/users/lasers/following{/other_user}","gists_url":"https://api.github.com/users/lasers/gists{/gist_id}","starred_url":"https://api.github.com/users/lasers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasers/subscriptions","organizations_url":"https://api.github.com/users/lasers/orgs","repos_url":"https://api.github.com/users/lasers/repos","events_url":"https://api.github.com/users/lasers/events{/privacy}","received_events_url":"https://api.github.com/users/lasers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lasers/nestopia","description":"Enhanced version of Nestopia for Linux, BSD, and Windows","fork":true,"url":"https://api.github.com/repos/lasers/nestopia","forks_url":"https://api.github.com/repos/lasers/nestopia/forks","keys_url":"https://api.github.com/repos/lasers/nestopia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lasers/nestopia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lasers/nestopia/teams","hooks_url":"https://api.github.com/repos/lasers/nestopia/hooks","issue_events_url":"https://api.github.com/repos/lasers/nestopia/issues/events{/number}","events_url":"https://api.github.com/repos/lasers/nestopia/events","assignees_url":"https://api.github.com/repos/lasers/nestopia/assignees{/user}","branches_url":"https://api.github.com/repos/lasers/nestopia/branches{/branch}","tags_url":"https://api.github.com/repos/lasers/nestopia/tags","blobs_url":"https://api.github.com/repos/lasers/nestopia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lasers/nestopia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lasers/nestopia/git/refs{/sha}","trees_url":"https://api.github.com/repos/lasers/nestopia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lasers/nestopia/statuses/{sha}","languages_url":"https://api.github.com/repos/lasers/nestopia/languages","stargazers_url":"https://api.github.com/repos/lasers/nestopia/stargazers","contributors_url":"https://api.github.com/repos/lasers/nestopia/contributors","subscribers_url":"https://api.github.com/repos/lasers/nestopia/subscribers","subscription_url":"https://api.github.com/repos/lasers/nestopia/subscription","commits_url":"https://api.github.com/repos/lasers/nestopia/commits{/sha}","git_commits_url":"https://api.github.com/repos/lasers/nestopia/git/commits{/sha}","comments_url":"https://api.github.com/repos/lasers/nestopia/comments{/number}","issue_comment_url":"https://api.github.com/repos/lasers/nestopia/issues/comments{/number}","contents_url":"https://api.github.com/repos/lasers/nestopia/contents/{+path}","compare_url":"https://api.github.com/repos/lasers/nestopia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lasers/nestopia/merges","archive_url":"https://api.github.com/repos/lasers/nestopia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lasers/nestopia/downloads","issues_url":"https://api.github.com/repos/lasers/nestopia/issues{/number}","pulls_url":"https://api.github.com/repos/lasers/nestopia/pulls{/number}","milestones_url":"https://api.github.com/repos/lasers/nestopia/milestones{/number}","notifications_url":"https://api.github.com/repos/lasers/nestopia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lasers/nestopia/labels{/name}","releases_url":"https://api.github.com/repos/lasers/nestopia/releases{/id}","deployments_url":"https://api.github.com/repos/lasers/nestopia/deployments","created_at":"2016-10-29T21:30:41Z","updated_at":"2016-10-29T21:30:43Z","pushed_at":"2016-10-29T21:33:42Z","git_url":"git://github.com/lasers/nestopia.git","ssh_url":"git@github.com:lasers/nestopia.git","clone_url":"https://github.com/lasers/nestopia.git","svn_url":"https://github.com/lasers/nestopia","homepage":"","size":4164,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libretro:master","ref":"master","sha":"b66580aebbe770b02447511d2361479200198e86","user":{"login":"libretro","id":1812827,"avatar_url":"https://avatars.githubusercontent.com/u/1812827?v=3","gravatar_id":"","url":"https://api.github.com/users/libretro","html_url":"https://github.com/libretro","followers_url":"https://api.github.com/users/libretro/followers","following_url":"https://api.github.com/users/libretro/following{/other_user}","gists_url":"https://api.github.com/users/libretro/gists{/gist_id}","starred_url":"https://api.github.com/users/libretro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libretro/subscriptions","organizations_url":"https://api.github.com/users/libretro/orgs","repos_url":"https://api.github.com/users/libretro/repos","events_url":"https://api.github.com/users/libretro/events{/privacy}","received_events_url":"https://api.github.com/users/libretro/received_events","type":"Organization","site_admin":false},"repo":{"id":7528546,"name":"nestopia","full_name":"libretro/nestopia","owner":{"login":"libretro","id":1812827,"avatar_url":"https://avatars.githubusercontent.com/u/1812827?v=3","gravatar_id":"","url":"https://api.github.com/users/libretro","html_url":"https://github.com/libretro","followers_url":"https://api.github.com/users/libretro/followers","following_url":"https://api.github.com/users/libretro/following{/other_user}","gists_url":"https://api.github.com/users/libretro/gists{/gist_id}","starred_url":"https://api.github.com/users/libretro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libretro/subscriptions","organizations_url":"https://api.github.com/users/libretro/orgs","repos_url":"https://api.github.com/users/libretro/repos","events_url":"https://api.github.com/users/libretro/events{/privacy}","received_events_url":"https://api.github.com/users/libretro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libretro/nestopia","description":"Enhanced version of Nestopia for Linux, BSD, and Windows","fork":true,"url":"https://api.github.com/repos/libretro/nestopia","forks_url":"https://api.github.com/repos/libretro/nestopia/forks","keys_url":"https://api.github.com/repos/libretro/nestopia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libretro/nestopia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libretro/nestopia/teams","hooks_url":"https://api.github.com/repos/libretro/nestopia/hooks","issue_events_url":"https://api.github.com/repos/libretro/nestopia/issues/events{/number}","events_url":"https://api.github.com/repos/libretro/nestopia/events","assignees_url":"https://api.github.com/repos/libretro/nestopia/assignees{/user}","branches_url":"https://api.github.com/repos/libretro/nestopia/branches{/branch}","tags_url":"https://api.github.com/repos/libretro/nestopia/tags","blobs_url":"https://api.github.com/repos/libretro/nestopia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libretro/nestopia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libretro/nestopia/git/refs{/sha}","trees_url":"https://api.github.com/repos/libretro/nestopia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libretro/nestopia/statuses/{sha}","languages_url":"https://api.github.com/repos/libretro/nestopia/languages","stargazers_url":"https://api.github.com/repos/libretro/nestopia/stargazers","contributors_url":"https://api.github.com/repos/libretro/nestopia/contributors","subscribers_url":"https://api.github.com/repos/libretro/nestopia/subscribers","subscription_url":"https://api.github.com/repos/libretro/nestopia/subscription","commits_url":"https://api.github.com/repos/libretro/nestopia/commits{/sha}","git_commits_url":"https://api.github.com/repos/libretro/nestopia/git/commits{/sha}","comments_url":"https://api.github.com/repos/libretro/nestopia/comments{/number}","issue_comment_url":"https://api.github.com/repos/libretro/nestopia/issues/comments{/number}","contents_url":"https://api.github.com/repos/libretro/nestopia/contents/{+path}","compare_url":"https://api.github.com/repos/libretro/nestopia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libretro/nestopia/merges","archive_url":"https://api.github.com/repos/libretro/nestopia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libretro/nestopia/downloads","issues_url":"https://api.github.com/repos/libretro/nestopia/issues{/number}","pulls_url":"https://api.github.com/repos/libretro/nestopia/pulls{/number}","milestones_url":"https://api.github.com/repos/libretro/nestopia/milestones{/number}","notifications_url":"https://api.github.com/repos/libretro/nestopia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libretro/nestopia/labels{/name}","releases_url":"https://api.github.com/repos/libretro/nestopia/releases{/id}","deployments_url":"https://api.github.com/repos/libretro/nestopia/deployments","created_at":"2013-01-09T20:39:30Z","updated_at":"2016-10-25T19:47:36Z","pushed_at":"2016-10-29T21:52:37Z","git_url":"git://github.com/libretro/nestopia.git","ssh_url":"git@github.com:libretro/nestopia.git","clone_url":"https://github.com/libretro/nestopia.git","svn_url":"https://github.com/libretro/nestopia","homepage":"","size":4381,"stargazers_count":17,"watchers_count":17,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":2,"forks":13,"open_issues":2,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libretro/nestopia/pulls/34"},"html":{"href":"https://github.com/libretro/nestopia/pull/34"},"issue":{"href":"https://api.github.com/repos/libretro/nestopia/issues/34"},"comments":{"href":"https://api.github.com/repos/libretro/nestopia/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/libretro/nestopia/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/libretro/nestopia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libretro/nestopia/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/libretro/nestopia/statuses/44679d9b8281811cfbeaff40496ed48f4a41fd83"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":40,"deletions":40,"changed_files":1}}
{"actor":{"display_login":"rdanbrook"}}