{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/1154","labels_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/1154/labels{/name}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/1154/comments","events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/1154/events","html_url":"https://github.com/Azure/azure-quickstart-templates/issues/1154","id":129288027,"number":1154,"title":"Possible error in vm-disk-utils.sh","user":{"login":"DhruvKumar","id":770598,"avatar_url":"https://avatars.githubusercontent.com/u/770598?v=3","gravatar_id":"","url":"https://api.github.com/users/DhruvKumar","html_url":"https://github.com/DhruvKumar","followers_url":"https://api.github.com/users/DhruvKumar/followers","following_url":"https://api.github.com/users/DhruvKumar/following{/other_user}","gists_url":"https://api.github.com/users/DhruvKumar/gists{/gist_id}","starred_url":"https://api.github.com/users/DhruvKumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DhruvKumar/subscriptions","organizations_url":"https://api.github.com/users/DhruvKumar/orgs","repos_url":"https://api.github.com/users/DhruvKumar/repos","events_url":"https://api.github.com/users/DhruvKumar/events{/privacy}","received_events_url":"https://api.github.com/users/DhruvKumar/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-27T22:17:13Z","updated_at":"2016-01-28T20:54:26Z","closed_at":null,"body":"The vm-disk-utils.sh provided by Ubuntu is excellent. But I think there's an error in this function since the way `echo` is being used looks circumspect:\r\n\r\n```\r\ndo_partition() {\r\n# This function creates one (1) primary partition on the\r\n# disk, using all available space\r\n    _disk=${1}\r\n    _type=${2}\r\n    if [ -z \"${_type}\" ]; then\r\n        # default to Linux partition type (ie, ext3/ext4/xfs)\r\n        _type=83\r\n    fi\r\n    echo \"n\r\np\r\n1\r\nt\r\n${_type}\r\nw\"| fdisk \"${_disk}\"\r\n```\r\nhttps://github.com/Azure/azure-quickstart-templates/blob/master/shared_scripts/ubuntu/vm-disk-utils-0.1.sh#L189-L196"},"comment":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/comments/176411274","html_url":"https://github.com/Azure/azure-quickstart-templates/issues/1154#issuecomment-176411274","issue_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/1154","id":176411274,"user":{"login":"trentmswanson","id":1594373,"avatar_url":"https://avatars.githubusercontent.com/u/1594373?v=3","gravatar_id":"","url":"https://api.github.com/users/trentmswanson","html_url":"https://github.com/trentmswanson","followers_url":"https://api.github.com/users/trentmswanson/followers","following_url":"https://api.github.com/users/trentmswanson/following{/other_user}","gists_url":"https://api.github.com/users/trentmswanson/gists{/gist_id}","starred_url":"https://api.github.com/users/trentmswanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trentmswanson/subscriptions","organizations_url":"https://api.github.com/users/trentmswanson/orgs","repos_url":"https://api.github.com/users/trentmswanson/repos","events_url":"https://api.github.com/users/trentmswanson/events{/privacy}","received_events_url":"https://api.github.com/users/trentmswanson/received_events","type":"User","site_admin":false},"created_at":"2016-01-28T20:54:26Z","updated_at":"2016-01-28T20:54:26Z","body":"Thanks @DhruvKumar \r\n\r\nI guess I don't see the problem. I see a few different ways this could be implemented, but how it's currently implemented should and does work.  I hesitate to change it now, unless there's a problems.\r\n\r\n-Trent"}}