{"action":"created","issue":{"url":"https://api.github.com/repos/upscaletech/finocial/issues/7","repository_url":"https://api.github.com/repos/upscaletech/finocial","labels_url":"https://api.github.com/repos/upscaletech/finocial/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/upscaletech/finocial/issues/7/comments","events_url":"https://api.github.com/repos/upscaletech/finocial/issues/7/events","html_url":"https://github.com/upscaletech/finocial/issues/7","id":179760230,"number":7,"title":"Add More Fields in API Input and Output","user":{"login":"maektwain","id":8274610,"avatar_url":"https://avatars.githubusercontent.com/u/8274610?v=3","gravatar_id":"","url":"https://api.github.com/users/maektwain","html_url":"https://github.com/maektwain","followers_url":"https://api.github.com/users/maektwain/followers","following_url":"https://api.github.com/users/maektwain/following{/other_user}","gists_url":"https://api.github.com/users/maektwain/gists{/gist_id}","starred_url":"https://api.github.com/users/maektwain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maektwain/subscriptions","organizations_url":"https://api.github.com/users/maektwain/orgs","repos_url":"https://api.github.com/users/maektwain/repos","events_url":"https://api.github.com/users/maektwain/events{/privacy}","received_events_url":"https://api.github.com/users/maektwain/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/upscaletech/finocial/labels/task","name":"task","color":"1d76db"}],"state":"open","locked":false,"assignee":{"login":"gandharv-pantelwar","id":20488587,"avatar_url":"https://avatars.githubusercontent.com/u/20488587?v=3","gravatar_id":"","url":"https://api.github.com/users/gandharv-pantelwar","html_url":"https://github.com/gandharv-pantelwar","followers_url":"https://api.github.com/users/gandharv-pantelwar/followers","following_url":"https://api.github.com/users/gandharv-pantelwar/following{/other_user}","gists_url":"https://api.github.com/users/gandharv-pantelwar/gists{/gist_id}","starred_url":"https://api.github.com/users/gandharv-pantelwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gandharv-pantelwar/subscriptions","organizations_url":"https://api.github.com/users/gandharv-pantelwar/orgs","repos_url":"https://api.github.com/users/gandharv-pantelwar/repos","events_url":"https://api.github.com/users/gandharv-pantelwar/events{/privacy}","received_events_url":"https://api.github.com/users/gandharv-pantelwar/received_events","type":"User","site_admin":false},"assignees":[{"login":"gandharv-pantelwar","id":20488587,"avatar_url":"https://avatars.githubusercontent.com/u/20488587?v=3","gravatar_id":"","url":"https://api.github.com/users/gandharv-pantelwar","html_url":"https://github.com/gandharv-pantelwar","followers_url":"https://api.github.com/users/gandharv-pantelwar/followers","following_url":"https://api.github.com/users/gandharv-pantelwar/following{/other_user}","gists_url":"https://api.github.com/users/gandharv-pantelwar/gists{/gist_id}","starred_url":"https://api.github.com/users/gandharv-pantelwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gandharv-pantelwar/subscriptions","organizations_url":"https://api.github.com/users/gandharv-pantelwar/orgs","repos_url":"https://api.github.com/users/gandharv-pantelwar/repos","events_url":"https://api.github.com/users/gandharv-pantelwar/events{/privacy}","received_events_url":"https://api.github.com/users/gandharv-pantelwar/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/upscaletech/finocial/milestones/1","html_url":"https://github.com/upscaletech/finocial/milestones/VERSION%201.ALPHA","labels_url":"https://api.github.com/repos/upscaletech/finocial/milestones/1/labels","id":1885075,"number":1,"title":"VERSION 1.ALPHA","description":"","creator":{"login":"maektwain","id":8274610,"avatar_url":"https://avatars.githubusercontent.com/u/8274610?v=3","gravatar_id":"","url":"https://api.github.com/users/maektwain","html_url":"https://github.com/maektwain","followers_url":"https://api.github.com/users/maektwain/followers","following_url":"https://api.github.com/users/maektwain/following{/other_user}","gists_url":"https://api.github.com/users/maektwain/gists{/gist_id}","starred_url":"https://api.github.com/users/maektwain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maektwain/subscriptions","organizations_url":"https://api.github.com/users/maektwain/orgs","repos_url":"https://api.github.com/users/maektwain/repos","events_url":"https://api.github.com/users/maektwain/events{/privacy}","received_events_url":"https://api.github.com/users/maektwain/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":0,"state":"open","created_at":"2016-07-15T08:21:27Z","updated_at":"2016-09-28T12:35:20Z","due_on":"2016-07-18T18:30:00Z","closed_at":null},"comments":2,"created_at":"2016-09-28T12:35:20Z","updated_at":"2016-10-06T11:36:20Z","closed_at":null,"body":"\r\nRight now in the /clients api when creating the JSON format is sent as below \r\n\r\n``` json\r\n{\r\n\t\"officeId\": 1,\r\n\t\"firstname\": \"Petra\",\r\n\t\"lastname\": \"Yton\",\r\n\t\"externalId\": \"786YYH7\",\r\n\t\"dateFormat\": \"dd MMMM yyyy\",\r\n\t\"locale\": \"en\",\r\n\t\"active\": true,\r\n\t\"activationDate\": \"04 March 2009\",\r\n    \"submittedOnDate\":\"04 March 2009\",\r\n    \"savingsProductId\" : 4\r\n}\r\n```\r\n\r\nWe need to add more mandatory fields which are required in the client creating process \r\n\r\nPlease add more dataTypes such as follow \r\n\r\nfatherName : String \r\n\r\nValidations Required \r\n\r\nPlease make sure that this field is validated on null characters or empty string \r\n\r\nSo when Sending an JSON Input it should be like this \r\n\r\nRequest Type: `POST /clients`\r\n``` json\r\n{\r\n\t\"officeId\": 1,\r\n\t\"firstname\": \"Petra\",\r\n\t\"lastname\": \"Yton\",\r\n        \"fathername\":\"Tetra Yton\",\r\n\t\"externalId\": \"786YYH7\",\r\n\t\"dateFormat\": \"dd MMMM yyyy\",\r\n\t\"locale\": \"en\",\r\n\t\"active\": true,\r\n\t\"activationDate\": \"04 March 2009\",\r\n    \"submittedOnDate\":\"04 March 2009\",\r\n    \"savingsProductId\" : 4\r\n}\r\n```\r\n\r\nAnd When You get a single client you should be able to fetch data in this format\r\nRequest Type: `GET /clients/1`\r\n\r\n``` json\r\n{\r\n  \"id\": 1,\r\n  \"accountNo\": \"000000001\",\r\n  \"status\": {\r\n    \"id\": 300,\r\n    \"code\": \"clientStatusType.active\",\r\n    \"value\": \"Active\"\r\n  },\r\n  \"subStatus\": {\r\n    \"active\": false,\r\n    \"mandatory\": false\r\n  },\r\n  \"active\": true,\r\n  \"activationDate\": [\r\n    2014,\r\n    3,\r\n    7\r\n  ],\r\n  \"firstname\": \"Smith\",\r\n  \"lastname\": \"R\",\r\n  \"fathername\":\"Samsonith R\",\r\n  \"displayName\": \"Smith R\",\r\n  \"gender\": {\r\n    \"active\": false,\r\n    \"mandatory\": false\r\n  },\r\n  \"clientType\": {\r\n    \"active\": false,\r\n    \"mandatory\": false\r\n  },\r\n  \"clientClassification\": {\r\n    \"active\": false,\r\n    \"mandatory\": false\r\n  },\r\n  \"officeId\": 1,\r\n  \"officeName\": \"Head Office\",\r\n  \"staffId\": 1,\r\n  \"staffName\": \"A, Aliya\",\r\n  \"timeline\": {\r\n    \"submittedOnDate\": [\r\n      2010,\r\n      1,\r\n      1\r\n    ],\r\n    \"submittedByUsername\": \"mifos\",\r\n    \"submittedByFirstname\": \"App\",\r\n    \"submittedByLastname\": \"Administrator\",\r\n    \"activatedOnDate\": [\r\n      2014,\r\n      3,\r\n      7\r\n    ],\r\n    \"activatedByUsername\": \"mifos\",\r\n    \"activatedByFirstname\": \"App\",\r\n    \"activatedByLastname\": \"Administrator\"\r\n  },\r\n  \"groups\": [],\r\n  \"clientNonPersonDetails\": {\r\n    \"constitution\": {\r\n      \"active\": false,\r\n      \"mandatory\": false\r\n    },\r\n    \"mainBusinessLine\": {\r\n      \"active\": false,\r\n      \"mandatory\": false\r\n    }\r\n  }\r\n}\r\n```\r\n\r\nLets get the conversation started \r\n"},"comment":{"url":"https://api.github.com/repos/upscaletech/finocial/issues/comments/251937415","html_url":"https://github.com/upscaletech/finocial/issues/7#issuecomment-251937415","issue_url":"https://api.github.com/repos/upscaletech/finocial/issues/7","id":251937415,"user":{"login":"maektwain","id":8274610,"avatar_url":"https://avatars.githubusercontent.com/u/8274610?v=3","gravatar_id":"","url":"https://api.github.com/users/maektwain","html_url":"https://github.com/maektwain","followers_url":"https://api.github.com/users/maektwain/followers","following_url":"https://api.github.com/users/maektwain/following{/other_user}","gists_url":"https://api.github.com/users/maektwain/gists{/gist_id}","starred_url":"https://api.github.com/users/maektwain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maektwain/subscriptions","organizations_url":"https://api.github.com/users/maektwain/orgs","repos_url":"https://api.github.com/users/maektwain/repos","events_url":"https://api.github.com/users/maektwain/events{/privacy}","received_events_url":"https://api.github.com/users/maektwain/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T11:36:20Z","updated_at":"2016-10-06T11:36:20Z","body":"@gandharv-pantelwar What is the status ? "}}
{"actor":{"display_login":"maektwain"}}