{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/59405519","id":59405519,"diff_hunk":"@@ -1,201 +1,77 @@\n class Libstfl < Formula\n   desc \"Library implementing a curses-based widget set for terminals\"\n   homepage \"http://www.clifford.at/stfl/\"\n-  url \"http://www.clifford.at/stfl/stfl-0.22.tar.gz\"\n-  sha256 \"2dddafd331e61ad04baf1251ccecb3a69feaf99880dd75155be8423c1cc55418\"\n+  url \"http://www.clifford.at/stfl/stfl-0.24.tar.gz\"\n+  sha256 \"d4a7aa181a475aaf8a8914a8ccb2a7ff28919d4c8c0f8a061e17a0c36869c090\"\n \n   bottle do\n     cellar :any\n     revision 1\n-    sha256 \"98c3c02654f076427f5243913d027029cd4607642d3c212833c21c97d0093ea0\" => :el_capitan\n     sha256 \"8ca63ef8c7776df77eda7a327b2e4a9d413992c08605e7922a7b82f560be618a\" => :yosemite\n     sha256 \"9a0b5e72c534ca6bc3e1ba2fbafb384719e5df9663ff4b507936afebfde16272\" => :mavericks\n     sha256 \"f30b9c76dbd4d31b7860b8ed8c0c8024f820624880db32b00d1804d38e9e6808\" => :mountain_lion\n   end\n \n-  depends_on :python => :optional\n-  depends_on \"swig\" => :build\n+  option \"without-perl\", \"Build without Perl support\"\n \n-  patch :DATA\n+  depends_on :python => :recommended\n+  depends_on :ruby => [\"1.8\", :recommended]\n+  depends_on \"swig\" => :build if build.with?(\"python\") || build.with?(\"ruby\") || build.with?(\"perl\")\n \n   def install\n-    args = [\"CC=#{ENV.cc} -pthread\", \"prefix=#{prefix}\"]\n+    ENV.append \"LDLIBS\", \"-liconv\"\n+    ENV.append \"CFLAGS\", \"-undefined dynamic_lookup\" if build.with? \"python\"\n+    ENV.append \"LIBS\", \"-lncurses -liconv\"\n+    ENV.append \"LIBS\", \"-lruby\" if build.with? \"ruby\"\n \n-    args << \"FOUND_RUBY = 0\" unless MacOS::CLT.installed? || MacOS.version >= :mavericks\n+    %w[\n+      stfl.pc.in\n+      perl5/Makefile.PL\n+      ruby/Makefile.snippet\n+    ].each do |f|\n+      inreplace f, \"ncursesw\", \"ncurses\"\n+    end\n+\n+    inreplace \"stfl_internals.h\", \"ncursesw/ncurses.h\", \"ncurses.h\"\n+\n+    inreplace \"Makefile\" do |s|\n+      s.gsub! \"ncursesw\", \"ncurses\"\n+      s.gsub! \"-Wl,-soname,$(SONAME)\", \"-Wl\"\n+      s.gsub! \"libstfl.so.$(VERSION)\", \"libstfl.$(VERSION).dylib\"\n+      s.gsub! \"libstfl.so\", \"libstfl.dylib\"\n+      s.gsub! \"include perl5/Makefile.snippet\", \"\" if build.without? \"perl\"\n+      s.gsub! \"include python/Makefile.snippet\", \"\" if build.without? \"python\"","path":"Formula/libstfl.rb","position":51,"original_position":51,"commit_id":"6238f3f467b2be22d9fcfa742145e25d94f8056a","original_commit_id":"6238f3f467b2be22d9fcfa742145e25d94f8056a","user":{"login":"tdsmith","id":173889,"avatar_url":"https://avatars.githubusercontent.com/u/173889?v=3","gravatar_id":"","url":"https://api.github.com/users/tdsmith","html_url":"https://github.com/tdsmith","followers_url":"https://api.github.com/users/tdsmith/followers","following_url":"https://api.github.com/users/tdsmith/following{/other_user}","gists_url":"https://api.github.com/users/tdsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/tdsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdsmith/subscriptions","organizations_url":"https://api.github.com/users/tdsmith/orgs","repos_url":"https://api.github.com/users/tdsmith/repos","events_url":"https://api.github.com/users/tdsmith/events{/privacy}","received_events_url":"https://api.github.com/users/tdsmith/received_events","type":"User","site_admin":false},"body":"Gotcha :+1: ","created_at":"2016-04-12T16:17:00Z","updated_at":"2016-04-12T16:17:00Z","html_url":"https://github.com/Homebrew/homebrew-core/pull/250#discussion_r59405519","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/250","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/59405519"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/250#discussion_r59405519"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/250"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/250","id":66183291,"html_url":"https://github.com/Homebrew/homebrew-core/pull/250","diff_url":"https://github.com/Homebrew/homebrew-core/pull/250.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/250.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/250","number":250,"state":"open","locked":false,"title":"libstfl 0.24","user":{"login":"ilovezfs","id":5268928,"avatar_url":"https://avatars.githubusercontent.com/u/5268928?v=3","gravatar_id":"","url":"https://api.github.com/users/ilovezfs","html_url":"https://github.com/ilovezfs","followers_url":"https://api.github.com/users/ilovezfs/followers","following_url":"https://api.github.com/users/ilovezfs/following{/other_user}","gists_url":"https://api.github.com/users/ilovezfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ilovezfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilovezfs/subscriptions","organizations_url":"https://api.github.com/users/ilovezfs/orgs","repos_url":"https://api.github.com/users/ilovezfs/repos","events_url":"https://api.github.com/users/ilovezfs/events{/privacy}","received_events_url":"https://api.github.com/users/ilovezfs/received_events","type":"User","site_admin":false},"body":"- Remove the patch, and use string replacement instead\n- Fix the following build failure:\n    Undefined symbols for architecture x86_64:\n      \"_rb_data_object_alloc\", referenced from:\n          _Init_stfl in stfl_wrap.o\n          __wrap_stfl_form_allocate in stfl_wrap.o\n          _SWIG_Ruby_NewPointerObj in stfl_wrap.o\n\nCloses Homebrew/legacy-homebrew#48930.","created_at":"2016-04-12T15:59:53Z","updated_at":"2016-04-12T16:17:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e49947aacf6e7413b94a76458825639256f7032","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/250/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/250/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/250/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/6238f3f467b2be22d9fcfa742145e25d94f8056a","head":{"label":"ilovezfs:libstfl-0.24","ref":"libstfl-0.24","sha":"6238f3f467b2be22d9fcfa742145e25d94f8056a","user":{"login":"ilovezfs","id":5268928,"avatar_url":"https://avatars.githubusercontent.com/u/5268928?v=3","gravatar_id":"","url":"https://api.github.com/users/ilovezfs","html_url":"https://github.com/ilovezfs","followers_url":"https://api.github.com/users/ilovezfs/followers","following_url":"https://api.github.com/users/ilovezfs/following{/other_user}","gists_url":"https://api.github.com/users/ilovezfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ilovezfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilovezfs/subscriptions","organizations_url":"https://api.github.com/users/ilovezfs/orgs","repos_url":"https://api.github.com/users/ilovezfs/repos","events_url":"https://api.github.com/users/ilovezfs/events{/privacy}","received_events_url":"https://api.github.com/users/ilovezfs/received_events","type":"User","site_admin":false},"repo":{"id":55388441,"name":"homebrew-core","full_name":"ilovezfs/homebrew-core","owner":{"login":"ilovezfs","id":5268928,"avatar_url":"https://avatars.githubusercontent.com/u/5268928?v=3","gravatar_id":"","url":"https://api.github.com/users/ilovezfs","html_url":"https://github.com/ilovezfs","followers_url":"https://api.github.com/users/ilovezfs/followers","following_url":"https://api.github.com/users/ilovezfs/following{/other_user}","gists_url":"https://api.github.com/users/ilovezfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ilovezfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilovezfs/subscriptions","organizations_url":"https://api.github.com/users/ilovezfs/orgs","repos_url":"https://api.github.com/users/ilovezfs/repos","events_url":"https://api.github.com/users/ilovezfs/events{/privacy}","received_events_url":"https://api.github.com/users/ilovezfs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ilovezfs/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":true,"url":"https://api.github.com/repos/ilovezfs/homebrew-core","forks_url":"https://api.github.com/repos/ilovezfs/homebrew-core/forks","keys_url":"https://api.github.com/repos/ilovezfs/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilovezfs/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilovezfs/homebrew-core/teams","hooks_url":"https://api.github.com/repos/ilovezfs/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/ilovezfs/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/ilovezfs/homebrew-core/events","assignees_url":"https://api.github.com/repos/ilovezfs/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/ilovezfs/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/ilovezfs/homebrew-core/tags","blobs_url":"https://api.github.com/repos/ilovezfs/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilovezfs/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilovezfs/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilovezfs/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilovezfs/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/ilovezfs/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/ilovezfs/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/ilovezfs/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/ilovezfs/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/ilovezfs/homebrew-core/subscription","commits_url":"https://api.github.com/repos/ilovezfs/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilovezfs/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilovezfs/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilovezfs/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ilovezfs/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/ilovezfs/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilovezfs/homebrew-core/merges","archive_url":"https://api.github.com/repos/ilovezfs/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilovezfs/homebrew-core/downloads","issues_url":"https://api.github.com/repos/ilovezfs/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/ilovezfs/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/ilovezfs/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/ilovezfs/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilovezfs/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/ilovezfs/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/ilovezfs/homebrew-core/deployments","created_at":"2016-04-04T05:59:03Z","updated_at":"2016-04-04T05:59:16Z","pushed_at":"2016-04-12T15:59:41Z","git_url":"git://github.com/ilovezfs/homebrew-core.git","ssh_url":"git@github.com:ilovezfs/homebrew-core.git","clone_url":"https://github.com/ilovezfs/homebrew-core.git","svn_url":"https://github.com/ilovezfs/homebrew-core","homepage":"http://brew.sh","size":56507,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"47bc875cca112624971b9323c2fda614c01d7ff3","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":52855516,"name":"homebrew-core","full_name":"Homebrew/homebrew-core","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-core","forks_url":"https://api.github.com/repos/Homebrew/homebrew-core/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-core/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-core/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-core/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-core/deployments","created_at":"2016-03-01T06:58:36Z","updated_at":"2016-04-12T16:13:58Z","pushed_at":"2016-04-12T15:59:54Z","git_url":"git://github.com/Homebrew/homebrew-core.git","ssh_url":"git@github.com:Homebrew/homebrew-core.git","clone_url":"https://github.com/Homebrew/homebrew-core.git","svn_url":"https://github.com/Homebrew/homebrew-core","homepage":"http://brew.sh","size":56626,"stargazers_count":145,"watchers_count":145,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":166,"mirror_url":null,"open_issues_count":31,"forks":166,"open_issues":31,"watchers":145,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/250"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/250"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/250"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/250/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/250/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/250/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/6238f3f467b2be22d9fcfa742145e25d94f8056a"}}}}