{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/71903968","id":71903968,"diff_hunk":"@@ -454,11 +454,11 @@ private function resolveServices($value)\n             $value = array_map(array($this, 'resolveServices'), $value);\n         } elseif (is_string($value) &&  0 === strpos($value, '@=')) {\n             return new Expression(substr($value, 2));\n-        } elseif (is_string($value) &&  0 === strpos($value, '@')) {\n-            if (0 === strpos($value, '@@')) {\n+        } elseif (is_string($value) && $value[0] && '@' === $value[0]) {\n+            if ('@' === $value[1]) {\n                 $value = substr($value, 1);\n                 $invalidBehavior = null;","path":"src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php","position":18,"original_position":18,"commit_id":"abcb935561e32b4793463ffc991b5f7410e8b654","original_commit_id":"abcb935561e32b4793463ffc991b5f7410e8b654","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"Rather than using ``$invalidBehavior = null`` to decide later that it is not a reference (and which will still remove the ``=`` at the end of the escaped string, which is a bug), I would rather use `` return substr($value, 1);`` here, to split things outside the handling of references","created_at":"2016-07-22T16:08:56Z","updated_at":"2016-07-22T16:08:56Z","html_url":"https://github.com/symfony/symfony/pull/19404#discussion_r71903968","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/19404","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/71903968"},"html":{"href":"https://github.com/symfony/symfony/pull/19404#discussion_r71903968"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19404"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/19404","id":78479130,"html_url":"https://github.com/symfony/symfony/pull/19404","diff_url":"https://github.com/symfony/symfony/pull/19404.diff","patch_url":"https://github.com/symfony/symfony/pull/19404.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/19404","number":19404,"state":"open","locked":false,"title":"Cleanups and improvements","user":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | -\r\n| License       | MIT\r\n| Doc PR        | -\r\n\r\nThis PR contains some improvements suggested by @jpauli:\r\n\r\n* Added missing type-hints\r\n* Optimized some code to avoid function calls and unnecessary recursions\r\n","created_at":"2016-07-22T13:44:22Z","updated_at":"2016-07-22T16:08:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4729693cce4dab7938da55e748dd171f59c659cc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/19404/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/19404/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/19404/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/abcb935561e32b4793463ffc991b5f7410e8b654","head":{"label":"javiereguiluz:misc_patches","ref":"misc_patches","sha":"abcb935561e32b4793463ffc991b5f7410e8b654","user":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"repo":{"id":15188086,"name":"symfony","full_name":"javiereguiluz/symfony","owner":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/javiereguiluz/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/javiereguiluz/symfony","forks_url":"https://api.github.com/repos/javiereguiluz/symfony/forks","keys_url":"https://api.github.com/repos/javiereguiluz/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javiereguiluz/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javiereguiluz/symfony/teams","hooks_url":"https://api.github.com/repos/javiereguiluz/symfony/hooks","issue_events_url":"https://api.github.com/repos/javiereguiluz/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/javiereguiluz/symfony/events","assignees_url":"https://api.github.com/repos/javiereguiluz/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/javiereguiluz/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/javiereguiluz/symfony/tags","blobs_url":"https://api.github.com/repos/javiereguiluz/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javiereguiluz/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javiereguiluz/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/javiereguiluz/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javiereguiluz/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/javiereguiluz/symfony/languages","stargazers_url":"https://api.github.com/repos/javiereguiluz/symfony/stargazers","contributors_url":"https://api.github.com/repos/javiereguiluz/symfony/contributors","subscribers_url":"https://api.github.com/repos/javiereguiluz/symfony/subscribers","subscription_url":"https://api.github.com/repos/javiereguiluz/symfony/subscription","commits_url":"https://api.github.com/repos/javiereguiluz/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/javiereguiluz/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/javiereguiluz/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/javiereguiluz/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/javiereguiluz/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/javiereguiluz/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javiereguiluz/symfony/merges","archive_url":"https://api.github.com/repos/javiereguiluz/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javiereguiluz/symfony/downloads","issues_url":"https://api.github.com/repos/javiereguiluz/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/javiereguiluz/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/javiereguiluz/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/javiereguiluz/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javiereguiluz/symfony/labels{/name}","releases_url":"https://api.github.com/repos/javiereguiluz/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/javiereguiluz/symfony/deployments","created_at":"2013-12-14T15:54:02Z","updated_at":"2015-11-05T11:38:17Z","pushed_at":"2016-07-22T15:52:15Z","git_url":"git://github.com/javiereguiluz/symfony.git","ssh_url":"git@github.com:javiereguiluz/symfony.git","clone_url":"https://github.com/javiereguiluz/symfony.git","svn_url":"https://github.com/javiereguiluz/symfony","homepage":"symfony.com","size":74257,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"695549fddee4a135bbb3b736b09509084b3e2b9e","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-07-22T15:04:27Z","pushed_at":"2016-07-22T15:58:33Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":135144,"stargazers_count":12668,"watchers_count":12668,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4942,"mirror_url":null,"open_issues_count":699,"forks":4942,"open_issues":699,"watchers":12668,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19404"},"html":{"href":"https://github.com/symfony/symfony/pull/19404"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/19404"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/19404/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19404/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19404/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/abcb935561e32b4793463ffc991b5f7410e8b654"}}}}
{"actor":{"display_login":"stof"}}