{"comment":{"url":"https://api.github.com/repos/plone/plone.api/comments/15788776","html_url":"https://github.com/plone/plone.api/commit/5c85218b70c35bbdf95e7d8b3245a70c6d4815c8#commitcomment-15788776","id":15788776,"user":{"login":"gforcada","id":1155680,"avatar_url":"https://avatars.githubusercontent.com/u/1155680?v=3","gravatar_id":"","url":"https://api.github.com/users/gforcada","html_url":"https://github.com/gforcada","followers_url":"https://api.github.com/users/gforcada/followers","following_url":"https://api.github.com/users/gforcada/following{/other_user}","gists_url":"https://api.github.com/users/gforcada/gists{/gist_id}","starred_url":"https://api.github.com/users/gforcada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gforcada/subscriptions","organizations_url":"https://api.github.com/users/gforcada/orgs","repos_url":"https://api.github.com/users/gforcada/repos","events_url":"https://api.github.com/users/gforcada/events{/privacy}","received_events_url":"https://api.github.com/users/gforcada/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"5c85218b70c35bbdf95e7d8b3245a70c6d4815c8","created_at":"2016-01-31T23:57:05Z","updated_at":"2016-01-31T23:57:05Z","body":"@mauritsvanrees Jenkins CI reporting about code analysis\nSee the full report here: http://jenkins.plone.org/job/package-plone.api/17//violations\n```\nERROR: /home/jenkins/workspace/package-plone.api@2/src/plone/api/content.py Imports are incorrectly sorted.\nsrc/plone/api/content.py:0:1: I001 found unsorted imports\nsrc/plone/api/content.py:98:13: Q000 Remove bad quotes.\nsrc/plone/api/content.py:99:13: Q000 Remove bad quotes.\nsrc/plone/api/content.py:100:13: Q000 Remove bad quotes.\nsrc/plone/api/content.py:268:1: C901 'delete' is too complex (15)\nsrc/plone/api/content.py:300:25: Q000 Remove bad quotes.\nsrc/plone/api/content.py:322:25: Q000 Remove bad quotes.\nsrc/plone/api/content.py:360:1: C901 '_wf_transitions_for' is too complex (12)\nsrc/plone/api/content.py:454:17: Q000 Remove bad quotes.\nsrc/plone/api/content.py:455:17: Q000 Remove bad quotes.\nsrc/plone/api/content.py:482:17: Q000 Remove bad quotes.\nsrc/plone/api/content.py:521:13: Q000 Remove bad quotes.\nsrc/plone/api/content.py:522:13: Q000 Remove bad quotes.\nERROR: /home/jenkins/workspace/package-plone.api@2/src/plone/api/env.py Imports are incorrectly sorted.\nsrc/plone/api/env.py:0:1: I001 found unsorted imports\nERROR: /home/jenkins/workspace/package-plone.api@2/src/plone/api/portal.py Imports are incorrectly sorted.\nsrc/plone/api/portal.py:0:1: I001 found unsorted imports\nsrc/plone/api/portal.py:65:9: Q000 Remove bad quotes.\nsrc/plone/api/portal.py:66:9: Q000 Remove bad quotes.\nsrc/plone/api/portal.py:67:9: Q000 Remove bad quotes.\nsrc/plone/api/portal.py:113:13: Q000 Remove bad quotes.\nsrc/plone/api/portal.py:114:13: Q000 Remove bad quotes.\nsrc/plone/api/portal.py:272:17: Q000 Remove bad quotes.\nsrc/plone/api/portal.py:273:17: Q000 Remove bad quotes.\nERROR: /home/jenkins/workspace/package-plone.api@2/src/plone/api/user.py Imports are incorrectly sorted.\nsrc/plone/api/user.py:0:1: I001 found unsorted imports\nsrc/plone/api/user.py:70:13: Q000 Remove bad quotes.\nsrc/plone/api/user.py:71:13: Q000 Remove bad quotes.\nsrc/plone/api/user.py:357:37: Q000 Remove bad quotes.\nsrc/plone/api/user.py:400:37: Q000 Remove bad quotes.\nsrc/plone/api/validation.py:20:13: Q000 Remove bad quotes.\nsrc/plone/api/validation.py:21:13: Q000 Remove bad quotes.\nsrc/plone/api/validation.py:22:32: Q000 Remove bad quotes.\nsrc/plone/api/validation.py:66:21: Q000 Remove bad quotes.\nsrc/plone/api/validation.py:67:25: Q000 Remove bad quotes.\nsrc/plone/api/validation.py:96:21: Q000 Remove bad quotes.\nsrc/plone/api/validation.py:97:25: Q000 Remove bad quotes.\nsrc/plone/api/validation.py:127:21: Q000 Remove bad quotes.\nsrc/plone/api/validation.py:128:21: Q000 Remove bad quotes.\nsrc/plone/api/validation.py:128:45: Q000 Remove bad quotes.\nERROR: /home/jenkins/workspace/package-plone.api@2/src/plone/api/tests/base.py Imports are incorrectly sorted.\nsrc/plone/api/tests/base.py:0:1: I001 found unsorted imports\nsrc/plone/api/tests/base.py:32:47: Q000 Remove bad quotes.\nsrc/plone/api/tests/base.py:60:28: Q000 Remove bad quotes.\nsrc/plone/api/tests/base.py:62:28: Q000 Remove bad quotes.\nERROR: /home/jenkins/workspace/package-plone.api@2/src/plone/api/tests/test_content.py Imports are incorrectly sorted.\nsrc/plone/api/tests/test_content.py:0:1: I001 found unsorted imports\nsrc/plone/api/tests/test_content.py:137:13: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_content.py:271:37: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_content.py:879:13: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_content.py:880:13: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_content.py:881:13: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_content.py:1015:17: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_content.py:1024:13: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_content.py:1025:13: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_content.py:1026:13: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_content.py:1027:13: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_content.py:1028:13: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_content.py:1029:13: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_content.py:1030:13: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_content.py:1031:13: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_content.py:1032:13: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_content.py:1033:13: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_content.py:1034:13: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_content.py:1035:13: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_content.py:1036:13: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_content.py:1037:13: Q000 Remove bad quotes.\nERROR: /home/jenkins/workspace/package-plone.api@2/src/plone/api/tests/test_doctests.py Imports are incorrectly sorted.\nsrc/plone/api/tests/test_doctests.py:0:1: I001 found unsorted imports\nsrc/plone/api/tests/test_doctests.py:120:13: T001 print statement found.\nERROR: /home/jenkins/workspace/package-plone.api@2/src/plone/api/tests/test_env.py Imports are incorrectly sorted.\nsrc/plone/api/tests/test_env.py:0:1: I001 found unsorted imports\nsrc/plone/api/tests/test_env.py:30:14: D001 found declarePublic replace it with AccessControl.ClassSecurityInfo.public\nsrc/plone/api/tests/test_env.py:31:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected\nsrc/plone/api/tests/test_env.py:32:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected\nsrc/plone/api/tests/test_env.py:33:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected\nsrc/plone/api/tests/test_env.py:34:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private\nERROR: /home/jenkins/workspace/package-plone.api@2/src/plone/api/tests/test_group.py Imports are incorrectly sorted.\nsrc/plone/api/tests/test_group.py:0:1: I001 found unsorted imports\nERROR: /home/jenkins/workspace/package-plone.api@2/src/plone/api/tests/test_portal.py Imports are incorrectly sorted.\nsrc/plone/api/tests/test_portal.py:0:1: I001 found unsorted imports\nsrc/plone/api/tests/test_portal.py:42:16: P002 found \"hasattr\", consider replacing it\nsrc/plone/api/tests/test_portal.py:106:41: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:106:57: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:144:13: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:145:13: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:175:22: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:185:22: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:194:23: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:195:20: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:196:21: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:210:23: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:211:21: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:232:27: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:233:24: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:234:25: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:253:23: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:254:21: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:260:9: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:270:23: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:271:21: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:280:9: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:292:23: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:293:21: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:317:27: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:318:24: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:319:25: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:326:23: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:327:20: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:328:21: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:505:44: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:516:44: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_portal.py:525:44: Q000 Remove bad quotes.\nERROR: /home/jenkins/workspace/package-plone.api@2/src/plone/api/tests/test_user.py Imports are incorrectly sorted.\nsrc/plone/api/tests/test_user.py:0:1: I001 found unsorted imports\nsrc/plone/api/tests/test_user.py:641:20: Q000 Remove bad quotes.\nsrc/plone/api/tests/test_validation.py:37:14: D001 found assertEquals replace it with assertEqual\nsrc/plone/api/tests/test_validation.py:40:14: D001 found assertEquals replace it with assertEqual\nsrc/plone/api/tests/test_validation.py:65:14: D001 found assertEquals replace it with assertEqual\nsrc/plone/api/tests/test_validation.py:70:14: D001 found assertEquals replace it with assertEqual\nsrc/plone/api/tests/test_validation.py:74:14: D001 found assertEquals replace it with assertEqual\nsrc/plone/api/tests/test_validation.py:79:14: D001 found assertEquals replace it with assertEqual\nsrc/plone/api/tests/test_validation.py:84:14: D001 found assertEquals replace it with assertEqual\nsrc/plone/api/tests/test_validation.py:91:14: D001 found assertEquals replace it with assertEqual\nsrc/plone/api/tests/test_validation.py:98:14: D001 found assertEquals replace it with assertEqual\nsrc/plone/api/tests/test_validation.py:123:14: D001 found assertEquals replace it with assertEqual\nsrc/plone/api/tests/test_validation.py:124:14: D001 found assertEquals replace it with assertEqual\nsrc/plone/api/tests/test_validation.py:131:14: D001 found assertEquals replace it with assertEqual\nsrc/plone/api/tests/test_validation.py:132:14: D001 found assertEquals replace it with assertEqual\nsrc/plone/api/tests/test_validation.py:133:14: D001 found assertEquals replace it with assertEqual\nsrc/plone/api/tests/test_validation.py:159:14: D001 found assertEquals replace it with assertEqual\nsrc/plone/api/tests/test_validation.py:160:14: D001 found assertEquals replace it with assertEqual\nsrc/plone/api/tests/test_validation.py:165:14: D001 found assertEquals replace it with assertEqual\nsrc/plone/api/tests/test_validation.py:166:14: D001 found assertEquals replace it with assertEqual\nsrc/plone/api/tests/test_validation.py:167:14: D001 found assertEquals replace it with assertEqual\n```\nYou can run that yourself using buildout.coredev ``experimental/qa.cfg`` config file."}}