{"action":"created","comment":{"url":"https://api.github.com/repos/bundler/bundler/pulls/comments/75745737","id":75745737,"diff_hunk":"@@ -112,6 +112,35 @@ def gem_skeleton_assertions(gem_name)\n     end\n   end\n \n+  context \"README.md\" do\n+    let(:gem_name) { \"test_gem\" }\n+    let(:generated_gem) { Bundler::GemHelper.new(bundled_app(gem_name).to_s) }\n+\n+    context \"git config user.name present\" do\n+      before do\n+        execute_bundle_gem(gem_name)\n+      end\n+\n+      it \"contribute URL set to git username\" do\n+        expect(bundled_app(\"test_gem/README.md\").read).not_to include(\"[USERNAME]\")\n+      end\n+    end\n+\n+    context \"git config user.name is absent\" do\n+      before do\n+        `git config --unset user.name`","path":"spec/commands/newgem_spec.rb","position":20,"original_position":20,"commit_id":"7f29df5f8508b1767bb3c6ce3a849b96aa367f29","original_commit_id":"7f29df5f8508b1767bb3c6ce3a849b96aa367f29","user":{"login":"segiddins","id":1946610,"avatar_url":"https://avatars.githubusercontent.com/u/1946610?v=3","gravatar_id":"","url":"https://api.github.com/users/segiddins","html_url":"https://github.com/segiddins","followers_url":"https://api.github.com/users/segiddins/followers","following_url":"https://api.github.com/users/segiddins/following{/other_user}","gists_url":"https://api.github.com/users/segiddins/gists{/gist_id}","starred_url":"https://api.github.com/users/segiddins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segiddins/subscriptions","organizations_url":"https://api.github.com/users/segiddins/orgs","repos_url":"https://api.github.com/users/segiddins/repos","events_url":"https://api.github.com/users/segiddins/events{/privacy}","received_events_url":"https://api.github.com/users/segiddins/received_events","type":"User","site_admin":false},"body":"👍 cool!","created_at":"2016-08-22T19:51:01Z","updated_at":"2016-08-22T19:51:01Z","html_url":"https://github.com/bundler/bundler/pull/4898#discussion_r75745737","pull_request_url":"https://api.github.com/repos/bundler/bundler/pulls/4898","_links":{"self":{"href":"https://api.github.com/repos/bundler/bundler/pulls/comments/75745737"},"html":{"href":"https://github.com/bundler/bundler/pull/4898#discussion_r75745737"},"pull_request":{"href":"https://api.github.com/repos/bundler/bundler/pulls/4898"}}},"pull_request":{"url":"https://api.github.com/repos/bundler/bundler/pulls/4898","id":82036733,"html_url":"https://github.com/bundler/bundler/pull/4898","diff_url":"https://github.com/bundler/bundler/pull/4898.diff","patch_url":"https://github.com/bundler/bundler/pull/4898.patch","issue_url":"https://api.github.com/repos/bundler/bundler/issues/4898","number":4898,"state":"open","locked":false,"title":"Fill in git username to the generated gem's contributing section of README.md","user":{"login":"JuanitoFatas","id":1000669,"avatar_url":"https://avatars.githubusercontent.com/u/1000669?v=3","gravatar_id":"","url":"https://api.github.com/users/JuanitoFatas","html_url":"https://github.com/JuanitoFatas","followers_url":"https://api.github.com/users/JuanitoFatas/followers","following_url":"https://api.github.com/users/JuanitoFatas/following{/other_user}","gists_url":"https://api.github.com/users/JuanitoFatas/gists{/gist_id}","starred_url":"https://api.github.com/users/JuanitoFatas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuanitoFatas/subscriptions","organizations_url":"https://api.github.com/users/JuanitoFatas/orgs","repos_url":"https://api.github.com/users/JuanitoFatas/repos","events_url":"https://api.github.com/users/JuanitoFatas/events{/privacy}","received_events_url":"https://api.github.com/users/JuanitoFatas/received_events","type":"User","site_admin":false},"body":"This Pull Request changes the GitHub URL in the Contributing section of README.md from generated gem (e.g. `bundle gem foo`).\r\n\r\nWhy:\r\n\r\nI found myself change `[USERNAME]` to my git username so many times and I also help [some](https://github.com/suzuki86/rhymer/pull/1/files) [people](https://github.com/fastly/blockbuster/pull/12/files) [fix](https://github.com/abookyun/taiwan_validator/pull/2/files) [this](https://github.com/mkhairi/materialize-sass/pull/62/files).\r\n\r\nSo I think this should be filled when new gem is generated. When git username not set, falls back to `[USERNAME]`.\r\n\r\nI don't really know how to make tests DRY, please advise, thank you.\r\n","created_at":"2016-08-19T19:56:38Z","updated_at":"2016-08-22T19:51:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3881347c66595b395e19b552eb7af1d22ae867f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bundler/bundler/pulls/4898/commits","review_comments_url":"https://api.github.com/repos/bundler/bundler/pulls/4898/comments","review_comment_url":"https://api.github.com/repos/bundler/bundler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bundler/bundler/issues/4898/comments","statuses_url":"https://api.github.com/repos/bundler/bundler/statuses/7f29df5f8508b1767bb3c6ce3a849b96aa367f29","head":{"label":"JuanitoFatas:feature/generated-readme-github-url","ref":"feature/generated-readme-github-url","sha":"7f29df5f8508b1767bb3c6ce3a849b96aa367f29","user":{"login":"JuanitoFatas","id":1000669,"avatar_url":"https://avatars.githubusercontent.com/u/1000669?v=3","gravatar_id":"","url":"https://api.github.com/users/JuanitoFatas","html_url":"https://github.com/JuanitoFatas","followers_url":"https://api.github.com/users/JuanitoFatas/followers","following_url":"https://api.github.com/users/JuanitoFatas/following{/other_user}","gists_url":"https://api.github.com/users/JuanitoFatas/gists{/gist_id}","starred_url":"https://api.github.com/users/JuanitoFatas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuanitoFatas/subscriptions","organizations_url":"https://api.github.com/users/JuanitoFatas/orgs","repos_url":"https://api.github.com/users/JuanitoFatas/repos","events_url":"https://api.github.com/users/JuanitoFatas/events{/privacy}","received_events_url":"https://api.github.com/users/JuanitoFatas/received_events","type":"User","site_admin":false},"repo":{"id":12221750,"name":"bundler","full_name":"JuanitoFatas/bundler","owner":{"login":"JuanitoFatas","id":1000669,"avatar_url":"https://avatars.githubusercontent.com/u/1000669?v=3","gravatar_id":"","url":"https://api.github.com/users/JuanitoFatas","html_url":"https://github.com/JuanitoFatas","followers_url":"https://api.github.com/users/JuanitoFatas/followers","following_url":"https://api.github.com/users/JuanitoFatas/following{/other_user}","gists_url":"https://api.github.com/users/JuanitoFatas/gists{/gist_id}","starred_url":"https://api.github.com/users/JuanitoFatas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuanitoFatas/subscriptions","organizations_url":"https://api.github.com/users/JuanitoFatas/orgs","repos_url":"https://api.github.com/users/JuanitoFatas/repos","events_url":"https://api.github.com/users/JuanitoFatas/events{/privacy}","received_events_url":"https://api.github.com/users/JuanitoFatas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JuanitoFatas/bundler","description":"Manage your application's gem dependencies with less pain","fork":true,"url":"https://api.github.com/repos/JuanitoFatas/bundler","forks_url":"https://api.github.com/repos/JuanitoFatas/bundler/forks","keys_url":"https://api.github.com/repos/JuanitoFatas/bundler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuanitoFatas/bundler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuanitoFatas/bundler/teams","hooks_url":"https://api.github.com/repos/JuanitoFatas/bundler/hooks","issue_events_url":"https://api.github.com/repos/JuanitoFatas/bundler/issues/events{/number}","events_url":"https://api.github.com/repos/JuanitoFatas/bundler/events","assignees_url":"https://api.github.com/repos/JuanitoFatas/bundler/assignees{/user}","branches_url":"https://api.github.com/repos/JuanitoFatas/bundler/branches{/branch}","tags_url":"https://api.github.com/repos/JuanitoFatas/bundler/tags","blobs_url":"https://api.github.com/repos/JuanitoFatas/bundler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuanitoFatas/bundler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuanitoFatas/bundler/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuanitoFatas/bundler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuanitoFatas/bundler/statuses/{sha}","languages_url":"https://api.github.com/repos/JuanitoFatas/bundler/languages","stargazers_url":"https://api.github.com/repos/JuanitoFatas/bundler/stargazers","contributors_url":"https://api.github.com/repos/JuanitoFatas/bundler/contributors","subscribers_url":"https://api.github.com/repos/JuanitoFatas/bundler/subscribers","subscription_url":"https://api.github.com/repos/JuanitoFatas/bundler/subscription","commits_url":"https://api.github.com/repos/JuanitoFatas/bundler/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuanitoFatas/bundler/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuanitoFatas/bundler/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuanitoFatas/bundler/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuanitoFatas/bundler/contents/{+path}","compare_url":"https://api.github.com/repos/JuanitoFatas/bundler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuanitoFatas/bundler/merges","archive_url":"https://api.github.com/repos/JuanitoFatas/bundler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuanitoFatas/bundler/downloads","issues_url":"https://api.github.com/repos/JuanitoFatas/bundler/issues{/number}","pulls_url":"https://api.github.com/repos/JuanitoFatas/bundler/pulls{/number}","milestones_url":"https://api.github.com/repos/JuanitoFatas/bundler/milestones{/number}","notifications_url":"https://api.github.com/repos/JuanitoFatas/bundler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuanitoFatas/bundler/labels{/name}","releases_url":"https://api.github.com/repos/JuanitoFatas/bundler/releases{/id}","deployments_url":"https://api.github.com/repos/JuanitoFatas/bundler/deployments","created_at":"2013-08-19T16:36:59Z","updated_at":"2014-05-13T18:01:25Z","pushed_at":"2016-08-19T19:52:13Z","git_url":"git://github.com/JuanitoFatas/bundler.git","ssh_url":"git@github.com:JuanitoFatas/bundler.git","clone_url":"https://github.com/JuanitoFatas/bundler.git","svn_url":"https://github.com/JuanitoFatas/bundler","homepage":"http://gembundler.com","size":14112,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bundler:master","ref":"master","sha":"54ff7a4fb827ec36d5cac2fac843993f28b19077","user":{"login":"bundler","id":1137638,"avatar_url":"https://avatars.githubusercontent.com/u/1137638?v=3","gravatar_id":"","url":"https://api.github.com/users/bundler","html_url":"https://github.com/bundler","followers_url":"https://api.github.com/users/bundler/followers","following_url":"https://api.github.com/users/bundler/following{/other_user}","gists_url":"https://api.github.com/users/bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bundler/subscriptions","organizations_url":"https://api.github.com/users/bundler/orgs","repos_url":"https://api.github.com/users/bundler/repos","events_url":"https://api.github.com/users/bundler/events{/privacy}","received_events_url":"https://api.github.com/users/bundler/received_events","type":"Organization","site_admin":false},"repo":{"id":488514,"name":"bundler","full_name":"bundler/bundler","owner":{"login":"bundler","id":1137638,"avatar_url":"https://avatars.githubusercontent.com/u/1137638?v=3","gravatar_id":"","url":"https://api.github.com/users/bundler","html_url":"https://github.com/bundler","followers_url":"https://api.github.com/users/bundler/followers","following_url":"https://api.github.com/users/bundler/following{/other_user}","gists_url":"https://api.github.com/users/bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bundler/subscriptions","organizations_url":"https://api.github.com/users/bundler/orgs","repos_url":"https://api.github.com/users/bundler/repos","events_url":"https://api.github.com/users/bundler/events{/privacy}","received_events_url":"https://api.github.com/users/bundler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bundler/bundler","description":"Manage your application's gem dependencies with less pain","fork":false,"url":"https://api.github.com/repos/bundler/bundler","forks_url":"https://api.github.com/repos/bundler/bundler/forks","keys_url":"https://api.github.com/repos/bundler/bundler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bundler/bundler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bundler/bundler/teams","hooks_url":"https://api.github.com/repos/bundler/bundler/hooks","issue_events_url":"https://api.github.com/repos/bundler/bundler/issues/events{/number}","events_url":"https://api.github.com/repos/bundler/bundler/events","assignees_url":"https://api.github.com/repos/bundler/bundler/assignees{/user}","branches_url":"https://api.github.com/repos/bundler/bundler/branches{/branch}","tags_url":"https://api.github.com/repos/bundler/bundler/tags","blobs_url":"https://api.github.com/repos/bundler/bundler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bundler/bundler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bundler/bundler/git/refs{/sha}","trees_url":"https://api.github.com/repos/bundler/bundler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bundler/bundler/statuses/{sha}","languages_url":"https://api.github.com/repos/bundler/bundler/languages","stargazers_url":"https://api.github.com/repos/bundler/bundler/stargazers","contributors_url":"https://api.github.com/repos/bundler/bundler/contributors","subscribers_url":"https://api.github.com/repos/bundler/bundler/subscribers","subscription_url":"https://api.github.com/repos/bundler/bundler/subscription","commits_url":"https://api.github.com/repos/bundler/bundler/commits{/sha}","git_commits_url":"https://api.github.com/repos/bundler/bundler/git/commits{/sha}","comments_url":"https://api.github.com/repos/bundler/bundler/comments{/number}","issue_comment_url":"https://api.github.com/repos/bundler/bundler/issues/comments{/number}","contents_url":"https://api.github.com/repos/bundler/bundler/contents/{+path}","compare_url":"https://api.github.com/repos/bundler/bundler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bundler/bundler/merges","archive_url":"https://api.github.com/repos/bundler/bundler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bundler/bundler/downloads","issues_url":"https://api.github.com/repos/bundler/bundler/issues{/number}","pulls_url":"https://api.github.com/repos/bundler/bundler/pulls{/number}","milestones_url":"https://api.github.com/repos/bundler/bundler/milestones{/number}","notifications_url":"https://api.github.com/repos/bundler/bundler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bundler/bundler/labels{/name}","releases_url":"https://api.github.com/repos/bundler/bundler/releases{/id}","deployments_url":"https://api.github.com/repos/bundler/bundler/deployments","created_at":"2010-01-26T00:46:38Z","updated_at":"2016-08-22T17:28:21Z","pushed_at":"2016-08-22T17:46:19Z","git_url":"git://github.com/bundler/bundler.git","ssh_url":"git@github.com:bundler/bundler.git","clone_url":"https://github.com/bundler/bundler.git","svn_url":"https://github.com/bundler/bundler","homepage":"https://bundler.io","size":27103,"stargazers_count":3473,"watchers_count":3473,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1608,"mirror_url":null,"open_issues_count":200,"forks":1608,"open_issues":200,"watchers":3473,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bundler/bundler/pulls/4898"},"html":{"href":"https://github.com/bundler/bundler/pull/4898"},"issue":{"href":"https://api.github.com/repos/bundler/bundler/issues/4898"},"comments":{"href":"https://api.github.com/repos/bundler/bundler/issues/4898/comments"},"review_comments":{"href":"https://api.github.com/repos/bundler/bundler/pulls/4898/comments"},"review_comment":{"href":"https://api.github.com/repos/bundler/bundler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bundler/bundler/pulls/4898/commits"},"statuses":{"href":"https://api.github.com/repos/bundler/bundler/statuses/7f29df5f8508b1767bb3c6ce3a849b96aa367f29"}}}}
{"actor":{"display_login":"segiddins"}}