{"action":"closed","number":8343,"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/8343","id":85864817,"html_url":"https://github.com/elastic/kibana/pull/8343","diff_url":"https://github.com/elastic/kibana/pull/8343.diff","patch_url":"https://github.com/elastic/kibana/pull/8343.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/8343","number":8343,"state":"closed","locked":false,"title":"Report useful error message when sessionStorage is unavailable","user":{"login":"Stacey-Gammon","id":16563603,"avatar_url":"https://avatars.githubusercontent.com/u/16563603?v=3","gravatar_id":"","url":"https://api.github.com/users/Stacey-Gammon","html_url":"https://github.com/Stacey-Gammon","followers_url":"https://api.github.com/users/Stacey-Gammon/followers","following_url":"https://api.github.com/users/Stacey-Gammon/following{/other_user}","gists_url":"https://api.github.com/users/Stacey-Gammon/gists{/gist_id}","starred_url":"https://api.github.com/users/Stacey-Gammon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stacey-Gammon/subscriptions","organizations_url":"https://api.github.com/users/Stacey-Gammon/orgs","repos_url":"https://api.github.com/users/Stacey-Gammon/repos","events_url":"https://api.github.com/users/Stacey-Gammon/events{/privacy}","received_events_url":"https://api.github.com/users/Stacey-Gammon/received_events","type":"User","site_admin":false},"body":"Report a clearer error message when sessionStorage access is denied by Safari due to private browsing mode.  I went with the suggested solution in [8063](https://github.com/elastic/kibana/issues/8063) but opted to do a single check on load rather than wrap all .setItems in try/catches.\r\n\r\n![safariprivatemodeerr](https://cloud.githubusercontent.com/assets/16563603/18648119/3b618a36-7e87-11e6-8872-f49cd8ab0e0c.png)\r\n\r\nFixes #8036 \r\n","created_at":"2016-09-19T20:37:28Z","updated_at":"2016-09-19T20:49:34Z","closed_at":"2016-09-19T20:49:34Z","merged_at":"2016-09-19T20:49:34Z","merge_commit_sha":"5ce2148ff140291c092341ff038212161aed525d","assignee":{"login":"spalger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false},"assignees":[{"login":"spalger","id":1329312,"avatar_url":"https://avatars.githubusercontent.com/u/1329312?v=3","gravatar_id":"","url":"https://api.github.com/users/spalger","html_url":"https://github.com/spalger","followers_url":"https://api.github.com/users/spalger/followers","following_url":"https://api.github.com/users/spalger/following{/other_user}","gists_url":"https://api.github.com/users/spalger/gists{/gist_id}","starred_url":"https://api.github.com/users/spalger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalger/subscriptions","organizations_url":"https://api.github.com/users/spalger/orgs","repos_url":"https://api.github.com/users/spalger/repos","events_url":"https://api.github.com/users/spalger/events{/privacy}","received_events_url":"https://api.github.com/users/spalger/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/8343/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/8343/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/8343/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/36e298d95706290de73d4e860da0ba7eca2c55ae","head":{"label":"Stacey-Gammon:bug/8063/no-safari-crash","ref":"bug/8063/no-safari-crash","sha":"36e298d95706290de73d4e860da0ba7eca2c55ae","user":{"login":"Stacey-Gammon","id":16563603,"avatar_url":"https://avatars.githubusercontent.com/u/16563603?v=3","gravatar_id":"","url":"https://api.github.com/users/Stacey-Gammon","html_url":"https://github.com/Stacey-Gammon","followers_url":"https://api.github.com/users/Stacey-Gammon/followers","following_url":"https://api.github.com/users/Stacey-Gammon/following{/other_user}","gists_url":"https://api.github.com/users/Stacey-Gammon/gists{/gist_id}","starred_url":"https://api.github.com/users/Stacey-Gammon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stacey-Gammon/subscriptions","organizations_url":"https://api.github.com/users/Stacey-Gammon/orgs","repos_url":"https://api.github.com/users/Stacey-Gammon/repos","events_url":"https://api.github.com/users/Stacey-Gammon/events{/privacy}","received_events_url":"https://api.github.com/users/Stacey-Gammon/received_events","type":"User","site_admin":false},"repo":{"id":68325068,"name":"kibana","full_name":"Stacey-Gammon/kibana","owner":{"login":"Stacey-Gammon","id":16563603,"avatar_url":"https://avatars.githubusercontent.com/u/16563603?v=3","gravatar_id":"","url":"https://api.github.com/users/Stacey-Gammon","html_url":"https://github.com/Stacey-Gammon","followers_url":"https://api.github.com/users/Stacey-Gammon/followers","following_url":"https://api.github.com/users/Stacey-Gammon/following{/other_user}","gists_url":"https://api.github.com/users/Stacey-Gammon/gists{/gist_id}","starred_url":"https://api.github.com/users/Stacey-Gammon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stacey-Gammon/subscriptions","organizations_url":"https://api.github.com/users/Stacey-Gammon/orgs","repos_url":"https://api.github.com/users/Stacey-Gammon/repos","events_url":"https://api.github.com/users/Stacey-Gammon/events{/privacy}","received_events_url":"https://api.github.com/users/Stacey-Gammon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Stacey-Gammon/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/Stacey-Gammon/kibana","forks_url":"https://api.github.com/repos/Stacey-Gammon/kibana/forks","keys_url":"https://api.github.com/repos/Stacey-Gammon/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Stacey-Gammon/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Stacey-Gammon/kibana/teams","hooks_url":"https://api.github.com/repos/Stacey-Gammon/kibana/hooks","issue_events_url":"https://api.github.com/repos/Stacey-Gammon/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/Stacey-Gammon/kibana/events","assignees_url":"https://api.github.com/repos/Stacey-Gammon/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/Stacey-Gammon/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/Stacey-Gammon/kibana/tags","blobs_url":"https://api.github.com/repos/Stacey-Gammon/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Stacey-Gammon/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Stacey-Gammon/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/Stacey-Gammon/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Stacey-Gammon/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/Stacey-Gammon/kibana/languages","stargazers_url":"https://api.github.com/repos/Stacey-Gammon/kibana/stargazers","contributors_url":"https://api.github.com/repos/Stacey-Gammon/kibana/contributors","subscribers_url":"https://api.github.com/repos/Stacey-Gammon/kibana/subscribers","subscription_url":"https://api.github.com/repos/Stacey-Gammon/kibana/subscription","commits_url":"https://api.github.com/repos/Stacey-Gammon/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/Stacey-Gammon/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/Stacey-Gammon/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/Stacey-Gammon/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/Stacey-Gammon/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/Stacey-Gammon/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Stacey-Gammon/kibana/merges","archive_url":"https://api.github.com/repos/Stacey-Gammon/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Stacey-Gammon/kibana/downloads","issues_url":"https://api.github.com/repos/Stacey-Gammon/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/Stacey-Gammon/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/Stacey-Gammon/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/Stacey-Gammon/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Stacey-Gammon/kibana/labels{/name}","releases_url":"https://api.github.com/repos/Stacey-Gammon/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/Stacey-Gammon/kibana/deployments","created_at":"2016-09-15T19:33:24Z","updated_at":"2016-09-15T19:33:30Z","pushed_at":"2016-09-19T20:35:56Z","git_url":"git://github.com/Stacey-Gammon/kibana.git","ssh_url":"git@github.com:Stacey-Gammon/kibana.git","clone_url":"https://github.com/Stacey-Gammon/kibana.git","svn_url":"https://github.com/Stacey-Gammon/kibana","homepage":"https://www.elastic.co/products/kibana","size":217849,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"3b03ec37bec5ac5b9e6445b811008cd6ef8eb0fa","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2016-09-19T17:03:10Z","pushed_at":"2016-09-19T20:49:34Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":264385,"stargazers_count":6017,"watchers_count":6017,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2204,"mirror_url":null,"open_issues_count":1183,"forks":2204,"open_issues":1183,"watchers":6017,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/8343"},"html":{"href":"https://github.com/elastic/kibana/pull/8343"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/8343"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/8343/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/8343/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/8343/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/36e298d95706290de73d4e860da0ba7eca2c55ae"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Stacey-Gammon","id":16563603,"avatar_url":"https://avatars.githubusercontent.com/u/16563603?v=3","gravatar_id":"","url":"https://api.github.com/users/Stacey-Gammon","html_url":"https://github.com/Stacey-Gammon","followers_url":"https://api.github.com/users/Stacey-Gammon/followers","following_url":"https://api.github.com/users/Stacey-Gammon/following{/other_user}","gists_url":"https://api.github.com/users/Stacey-Gammon/gists{/gist_id}","starred_url":"https://api.github.com/users/Stacey-Gammon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stacey-Gammon/subscriptions","organizations_url":"https://api.github.com/users/Stacey-Gammon/orgs","repos_url":"https://api.github.com/users/Stacey-Gammon/repos","events_url":"https://api.github.com/users/Stacey-Gammon/events{/privacy}","received_events_url":"https://api.github.com/users/Stacey-Gammon/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":4,"additions":11,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"Stacey-Gammon"}}