{"action":"created","issue":{"url":"https://api.github.com/repos/phst/lualatex-math/issues/17","repository_url":"https://api.github.com/repos/phst/lualatex-math","labels_url":"https://api.github.com/repos/phst/lualatex-math/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/phst/lualatex-math/issues/17/comments","events_url":"https://api.github.com/repos/phst/lualatex-math/issues/17/events","html_url":"https://github.com/phst/lualatex-math/issues/17","id":138499303,"number":17,"title":"avoid patching  \\resetMathstrut@  for recent amsmath.","user":{"login":"davidcarlisle","id":1268738,"avatar_url":"https://avatars.githubusercontent.com/u/1268738?v=3","gravatar_id":"","url":"https://api.github.com/users/davidcarlisle","html_url":"https://github.com/davidcarlisle","followers_url":"https://api.github.com/users/davidcarlisle/followers","following_url":"https://api.github.com/users/davidcarlisle/following{/other_user}","gists_url":"https://api.github.com/users/davidcarlisle/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcarlisle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcarlisle/subscriptions","organizations_url":"https://api.github.com/users/davidcarlisle/orgs","repos_url":"https://api.github.com/users/davidcarlisle/repos","events_url":"https://api.github.com/users/davidcarlisle/events{/privacy}","received_events_url":"https://api.github.com/users/davidcarlisle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2016-03-04T15:14:31Z","updated_at":"2016-03-08T13:29:16Z","closed_at":null,"body":"amsmath 2.15 (for luatex 0.87+)\r\n\r\ndevelopment builds of luatex always report \\Umathchar in \\meaning strings even if the token was defined with \\mathchar, this broke several places where amsmath queried \\meaning.\r\n\r\namsmath 2.15 hopefully addresses that and has some basic knowledge of \\umathchar in other places (eg mathchar and Umathchar tokens should be treated the same by \\dots now)\r\n\r\nHowever in order to make it load at all i needed to fix the sdt@minus and mathstrut tests to be luatex/xetex aware.\r\n\r\nThe end result is that you now get\r\n\r\n```\r\n*************************************************\r\n* lualatex-math warning: \"wrong-meaning\"\r\n* \r\n* I've expected \\resetMathstrut@ to have the meaning\r\n* macro:->\\setbox \\z@ \\hbox {\\mathchardef \\@tempa \\mathcode `\\(\\relax \\def\r\n* \\@tempb ##1\"##2##3{\\the \\textfont \"##3\\char \"}\\expandafter \\@tempb \\meaning\r\n* \\@tempa \\relax }\\ht \\Mathstrutbox@ \\ht \\z@ \\dp \\Mathstrutbox@ \\dp \\z@ ,\r\n* but it has the meaning\r\n* macro:->\\begingroup \\Umathcharnumdef \\@tempa \\Umathcodenum `\\(\\relax \\def\r\n* \\@tempb ##1\"##2\"##3\"##4\\relax {\\endgroup \\ht \\Mathstrutbox@ =\\fontcharht\r\n* \\textfont \"##3 \"##4\\relax \\dp \\Mathstrutbox@ =\\fontchardp \\textfont \"##3\r\n* \"##4\\relax } \\expandafter \\@tempb \\meaning \\@tempa \\relax .\r\n*************************************************\r\n```\r\n\r\nPerhaps the simplest thing to do would be to check if it is the original version and if so, patch, and if not, silently do nothing and hope that the updated version is OK?\r\n\r\nMore generally hope to make amsmath work \"out of the box\" with luatex and xetex so there may be further places where patching fails if there are updates during texlive 2016 testing. If you have any particular things you think we should definitely update, then  comments on amsmath welcome! (LaTeX3 project has taken over maintenance of amsmath from the AMS)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/phst/lualatex-math/issues/comments/193784551","html_url":"https://github.com/phst/lualatex-math/issues/17#issuecomment-193784551","issue_url":"https://api.github.com/repos/phst/lualatex-math/issues/17","id":193784551,"user":{"login":"jfbu","id":2589111,"avatar_url":"https://avatars.githubusercontent.com/u/2589111?v=3","gravatar_id":"","url":"https://api.github.com/users/jfbu","html_url":"https://github.com/jfbu","followers_url":"https://api.github.com/users/jfbu/followers","following_url":"https://api.github.com/users/jfbu/following{/other_user}","gists_url":"https://api.github.com/users/jfbu/gists{/gist_id}","starred_url":"https://api.github.com/users/jfbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfbu/subscriptions","organizations_url":"https://api.github.com/users/jfbu/orgs","repos_url":"https://api.github.com/users/jfbu/repos","events_url":"https://api.github.com/users/jfbu/events{/privacy}","received_events_url":"https://api.github.com/users/jfbu/received_events","type":"User","site_admin":false},"created_at":"2016-03-08T13:29:16Z","updated_at":"2016-03-08T13:29:16Z","body":"@davidcarlisle I have been witness to some or your exchanges with Hans `;-)` on luatex mailing list... but indeed can only deduce there were quite a few changes and back-changes, as I don't follow really what happens on luatex side.\r\n\r\nregarding `\\newmcodes@` I understand topmost priority is maintaining identical compilation for legacy documents; but I was thinking that for new engines, in case for example the minus sign has an extended mathcode, perhaps then it would make sense to re-think what `\\newmcodes@` does. In particular it hard-codes font family `0` for some symbols such as `*` when used in operator names. But myself I have not given any serious thought about it apart from doing `\\let\\newmcodes@\\relax` in `mathastext.sty` as I was too lazy (I was to improve it but don't have had the time to devote to this) and it was not really of my resort."}}