{"action":"created","issue":{"url":"https://api.github.com/repos/kentcdodds/p-s/issues/34","repository_url":"https://api.github.com/repos/kentcdodds/p-s","labels_url":"https://api.github.com/repos/kentcdodds/p-s/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/kentcdodds/p-s/issues/34/comments","events_url":"https://api.github.com/repos/kentcdodds/p-s/issues/34/events","html_url":"https://github.com/kentcdodds/p-s/pull/34","id":165552326,"number":34,"title":"[wip] Add End-2-End tests for CLI","user":{"login":"nkbt","id":175264,"avatar_url":"https://avatars.githubusercontent.com/u/175264?v=3","gravatar_id":"","url":"https://api.github.com/users/nkbt","html_url":"https://github.com/nkbt","followers_url":"https://api.github.com/users/nkbt/followers","following_url":"https://api.github.com/users/nkbt/following{/other_user}","gists_url":"https://api.github.com/users/nkbt/gists{/gist_id}","starred_url":"https://api.github.com/users/nkbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkbt/subscriptions","organizations_url":"https://api.github.com/users/nkbt/orgs","repos_url":"https://api.github.com/users/nkbt/repos","events_url":"https://api.github.com/users/nkbt/events{/privacy}","received_events_url":"https://api.github.com/users/nkbt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-07-14T12:40:21Z","updated_at":"2016-08-29T16:41:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kentcdodds/p-s/pulls/34","html_url":"https://github.com/kentcdodds/p-s/pull/34","diff_url":"https://github.com/kentcdodds/p-s/pull/34.diff","patch_url":"https://github.com/kentcdodds/p-s/pull/34.patch"},"body":"Fixes #31 \r\n\r\n**What**:\r\n- [x] Added `cli-tester`\r\n- [x] Windows/OSX compatible tests\r\n- [x] Add test for running `p-s` without any arguments\r\n- [x] Add test for running with config file but without any arguments\r\n- [ ] More tests\r\n\r\n<!-- Why are these changes necessary? -->\r\n**Why**:\r\nMake sure that expected behavior is not broken with different updates\r\n\r\n\r\nThis is WIP, so later will rewrite commit messages, fix code style, etc.\r\n\r\nSome of used functions may be abstracted, though I think it is ok to keep them with tests, closer to context.\r\n\r\nWould be great to have some more common usecases to test. Maybe another 2-3 to play with. Then anyone could be able to add more tests when new functionality is added.\r\n\r\nFeel free to object any of decisions made, let me know what looks good, what is not so.\r\n\r\nCheers!"},"comment":{"url":"https://api.github.com/repos/kentcdodds/p-s/issues/comments/243179655","html_url":"https://github.com/kentcdodds/p-s/pull/34#issuecomment-243179655","issue_url":"https://api.github.com/repos/kentcdodds/p-s/issues/34","id":243179655,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2016-08-29T16:41:04Z","updated_at":"2016-08-29T16:41:04Z","body":"## [Current coverage](https://codecov.io/gh/kentcdodds/p-s/pull/34?src=pr) is 100% (diff: 100%)\n> Merging [#34](https://codecov.io/gh/kentcdodds/p-s/pull/34?src=pr) into [master](https://codecov.io/gh/kentcdodds/p-s/branch/master?src=pr) will not change coverage\n\n```diff\n@@           master   #34   diff @@\n===================================\n  Files          11    11          \n  Lines         217   217          \n  Methods         0     0          \n  Messages        0     0          \n  Branches        0     0          \n===================================\n  Hits          217   217          \n  Misses          0     0          \n  Partials        0     0          \n```\n\n> Powered by [Codecov](https://codecov.io?src=pr). Last update [d07f678...75d1746](https://codecov.io/gh/kentcdodds/p-s/compare/d07f6788d5341779448b8f912e0c6a3f23fbc9cc...75d17469dbf6134d95e262841c5641b6a93c2c00?src=pr)"}}
{"actor":{"display_login":"codecov-io"}}