{"action":"created","comment":{"url":"https://api.github.com/repos/apache/hadoop/pulls/comments/77864635","id":77864635,"diff_hunk":"@@ -45,16 +45,19 @@\n import org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerApplicationAttempt;\n import org.apache.hadoop.yarn.util.resource.Resources;\n \n+import static org.apache.hadoop.yarn.util.resource.Resources.none;\n+\n @Private\n @Unstable\n public class FSLeafQueue extends FSQueue {\n   private static final Log LOG = LogFactory.getLog(\n       FSLeafQueue.class.getName());\n+  private FairScheduler scheduler;","path":"hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSLeafQueue.java","position":11,"original_position":11,"commit_id":"63804f783cc398479be6f9fe69e9db8ea9279047","original_commit_id":"63804f783cc398479be6f9fe69e9db8ea9279047","user":{"login":"templedf","id":651386,"avatar_url":"https://avatars.githubusercontent.com/u/651386?v=3","gravatar_id":"","url":"https://api.github.com/users/templedf","html_url":"https://github.com/templedf","followers_url":"https://api.github.com/users/templedf/followers","following_url":"https://api.github.com/users/templedf/following{/other_user}","gists_url":"https://api.github.com/users/templedf/gists{/gist_id}","starred_url":"https://api.github.com/users/templedf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/templedf/subscriptions","organizations_url":"https://api.github.com/users/templedf/orgs","repos_url":"https://api.github.com/users/templedf/repos","events_url":"https://api.github.com/users/templedf/events{/privacy}","received_events_url":"https://api.github.com/users/templedf/received_events","type":"User","site_admin":false},"body":"Maybe put the scheduler into the context?","created_at":"2016-09-07T17:07:16Z","updated_at":"2016-09-07T17:07:16Z","html_url":"https://github.com/apache/hadoop/pull/124#discussion_r77864635","pull_request_url":"https://api.github.com/repos/apache/hadoop/pulls/124","_links":{"self":{"href":"https://api.github.com/repos/apache/hadoop/pulls/comments/77864635"},"html":{"href":"https://github.com/apache/hadoop/pull/124#discussion_r77864635"},"pull_request":{"href":"https://api.github.com/repos/apache/hadoop/pulls/124"}}},"pull_request":{"url":"https://api.github.com/repos/apache/hadoop/pulls/124","id":83528880,"html_url":"https://github.com/apache/hadoop/pull/124","diff_url":"https://github.com/apache/hadoop/pull/124.diff","patch_url":"https://github.com/apache/hadoop/pull/124.patch","issue_url":"https://api.github.com/repos/apache/hadoop/issues/124","number":124,"state":"open","locked":false,"title":"YARN-5605. Preempt containers (all on one node) to meet the requirement of starved applications.","user":{"login":"kambatla","id":648114,"avatar_url":"https://avatars.githubusercontent.com/u/648114?v=3","gravatar_id":"","url":"https://api.github.com/users/kambatla","html_url":"https://github.com/kambatla","followers_url":"https://api.github.com/users/kambatla/followers","following_url":"https://api.github.com/users/kambatla/following{/other_user}","gists_url":"https://api.github.com/users/kambatla/gists{/gist_id}","starred_url":"https://api.github.com/users/kambatla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kambatla/subscriptions","organizations_url":"https://api.github.com/users/kambatla/orgs","repos_url":"https://api.github.com/users/kambatla/repos","events_url":"https://api.github.com/users/kambatla/events{/privacy}","received_events_url":"https://api.github.com/users/kambatla/received_events","type":"User","site_admin":false},"body":"- Remove existing preemption code.\r\n- Deleted preemption tests, to be reinstated later.\r\n- Identify starved applications in the update thread when preemption is enabled.\r\n- For each starved application, identify containers to be preempted on a single node to make room for this request.\r\n- Preempt these containers after necessary warning.","created_at":"2016-08-31T21:02:20Z","updated_at":"2016-09-07T17:07:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09d7f053862fb8b8de1555680462b505df3e347f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/hadoop/pulls/124/commits","review_comments_url":"https://api.github.com/repos/apache/hadoop/pulls/124/comments","review_comment_url":"https://api.github.com/repos/apache/hadoop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/hadoop/issues/124/comments","statuses_url":"https://api.github.com/repos/apache/hadoop/statuses/63804f783cc398479be6f9fe69e9db8ea9279047","head":{"label":"kambatla:yarn-5065","ref":"yarn-5065","sha":"63804f783cc398479be6f9fe69e9db8ea9279047","user":{"login":"kambatla","id":648114,"avatar_url":"https://avatars.githubusercontent.com/u/648114?v=3","gravatar_id":"","url":"https://api.github.com/users/kambatla","html_url":"https://github.com/kambatla","followers_url":"https://api.github.com/users/kambatla/followers","following_url":"https://api.github.com/users/kambatla/following{/other_user}","gists_url":"https://api.github.com/users/kambatla/gists{/gist_id}","starred_url":"https://api.github.com/users/kambatla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kambatla/subscriptions","organizations_url":"https://api.github.com/users/kambatla/orgs","repos_url":"https://api.github.com/users/kambatla/repos","events_url":"https://api.github.com/users/kambatla/events{/privacy}","received_events_url":"https://api.github.com/users/kambatla/received_events","type":"User","site_admin":false},"repo":{"id":67072960,"name":"hadoop","full_name":"kambatla/hadoop","owner":{"login":"kambatla","id":648114,"avatar_url":"https://avatars.githubusercontent.com/u/648114?v=3","gravatar_id":"","url":"https://api.github.com/users/kambatla","html_url":"https://github.com/kambatla","followers_url":"https://api.github.com/users/kambatla/followers","following_url":"https://api.github.com/users/kambatla/following{/other_user}","gists_url":"https://api.github.com/users/kambatla/gists{/gist_id}","starred_url":"https://api.github.com/users/kambatla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kambatla/subscriptions","organizations_url":"https://api.github.com/users/kambatla/orgs","repos_url":"https://api.github.com/users/kambatla/repos","events_url":"https://api.github.com/users/kambatla/events{/privacy}","received_events_url":"https://api.github.com/users/kambatla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kambatla/hadoop","description":"Mirror of Apache Hadoop","fork":true,"url":"https://api.github.com/repos/kambatla/hadoop","forks_url":"https://api.github.com/repos/kambatla/hadoop/forks","keys_url":"https://api.github.com/repos/kambatla/hadoop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kambatla/hadoop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kambatla/hadoop/teams","hooks_url":"https://api.github.com/repos/kambatla/hadoop/hooks","issue_events_url":"https://api.github.com/repos/kambatla/hadoop/issues/events{/number}","events_url":"https://api.github.com/repos/kambatla/hadoop/events","assignees_url":"https://api.github.com/repos/kambatla/hadoop/assignees{/user}","branches_url":"https://api.github.com/repos/kambatla/hadoop/branches{/branch}","tags_url":"https://api.github.com/repos/kambatla/hadoop/tags","blobs_url":"https://api.github.com/repos/kambatla/hadoop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kambatla/hadoop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kambatla/hadoop/git/refs{/sha}","trees_url":"https://api.github.com/repos/kambatla/hadoop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kambatla/hadoop/statuses/{sha}","languages_url":"https://api.github.com/repos/kambatla/hadoop/languages","stargazers_url":"https://api.github.com/repos/kambatla/hadoop/stargazers","contributors_url":"https://api.github.com/repos/kambatla/hadoop/contributors","subscribers_url":"https://api.github.com/repos/kambatla/hadoop/subscribers","subscription_url":"https://api.github.com/repos/kambatla/hadoop/subscription","commits_url":"https://api.github.com/repos/kambatla/hadoop/commits{/sha}","git_commits_url":"https://api.github.com/repos/kambatla/hadoop/git/commits{/sha}","comments_url":"https://api.github.com/repos/kambatla/hadoop/comments{/number}","issue_comment_url":"https://api.github.com/repos/kambatla/hadoop/issues/comments{/number}","contents_url":"https://api.github.com/repos/kambatla/hadoop/contents/{+path}","compare_url":"https://api.github.com/repos/kambatla/hadoop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kambatla/hadoop/merges","archive_url":"https://api.github.com/repos/kambatla/hadoop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kambatla/hadoop/downloads","issues_url":"https://api.github.com/repos/kambatla/hadoop/issues{/number}","pulls_url":"https://api.github.com/repos/kambatla/hadoop/pulls{/number}","milestones_url":"https://api.github.com/repos/kambatla/hadoop/milestones{/number}","notifications_url":"https://api.github.com/repos/kambatla/hadoop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kambatla/hadoop/labels{/name}","releases_url":"https://api.github.com/repos/kambatla/hadoop/releases{/id}","deployments_url":"https://api.github.com/repos/kambatla/hadoop/deployments","created_at":"2016-08-31T20:57:08Z","updated_at":"2016-08-31T20:57:48Z","pushed_at":"2016-08-31T21:00:32Z","git_url":"git://github.com/kambatla/hadoop.git","ssh_url":"git@github.com:kambatla/hadoop.git","clone_url":"https://github.com/kambatla/hadoop.git","svn_url":"https://github.com/kambatla/hadoop","homepage":null,"size":354177,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"01721dd88ee532d20eda841254437da4dfd69db5","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":23418517,"name":"hadoop","full_name":"apache/hadoop","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/hadoop","description":"Mirror of Apache Hadoop","fork":false,"url":"https://api.github.com/repos/apache/hadoop","forks_url":"https://api.github.com/repos/apache/hadoop/forks","keys_url":"https://api.github.com/repos/apache/hadoop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/hadoop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/hadoop/teams","hooks_url":"https://api.github.com/repos/apache/hadoop/hooks","issue_events_url":"https://api.github.com/repos/apache/hadoop/issues/events{/number}","events_url":"https://api.github.com/repos/apache/hadoop/events","assignees_url":"https://api.github.com/repos/apache/hadoop/assignees{/user}","branches_url":"https://api.github.com/repos/apache/hadoop/branches{/branch}","tags_url":"https://api.github.com/repos/apache/hadoop/tags","blobs_url":"https://api.github.com/repos/apache/hadoop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/hadoop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/hadoop/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/hadoop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/hadoop/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/hadoop/languages","stargazers_url":"https://api.github.com/repos/apache/hadoop/stargazers","contributors_url":"https://api.github.com/repos/apache/hadoop/contributors","subscribers_url":"https://api.github.com/repos/apache/hadoop/subscribers","subscription_url":"https://api.github.com/repos/apache/hadoop/subscription","commits_url":"https://api.github.com/repos/apache/hadoop/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/hadoop/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/hadoop/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/hadoop/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/hadoop/contents/{+path}","compare_url":"https://api.github.com/repos/apache/hadoop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/hadoop/merges","archive_url":"https://api.github.com/repos/apache/hadoop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/hadoop/downloads","issues_url":"https://api.github.com/repos/apache/hadoop/issues{/number}","pulls_url":"https://api.github.com/repos/apache/hadoop/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/hadoop/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/hadoop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/hadoop/labels{/name}","releases_url":"https://api.github.com/repos/apache/hadoop/releases{/id}","deployments_url":"https://api.github.com/repos/apache/hadoop/deployments","created_at":"2014-08-28T07:00:08Z","updated_at":"2016-09-07T13:40:07Z","pushed_at":"2016-09-07T14:53:34Z","git_url":"git://github.com/apache/hadoop.git","ssh_url":"git@github.com:apache/hadoop.git","clone_url":"https://github.com/apache/hadoop.git","svn_url":"https://github.com/apache/hadoop","homepage":null,"size":409712,"stargazers_count":2285,"watchers_count":2285,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2306,"mirror_url":"git://git.apache.org/hadoop.git","open_issues_count":57,"forks":2306,"open_issues":57,"watchers":2285,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/hadoop/pulls/124"},"html":{"href":"https://github.com/apache/hadoop/pull/124"},"issue":{"href":"https://api.github.com/repos/apache/hadoop/issues/124"},"comments":{"href":"https://api.github.com/repos/apache/hadoop/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/hadoop/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/hadoop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/hadoop/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/apache/hadoop/statuses/63804f783cc398479be6f9fe69e9db8ea9279047"}}}}
{"actor":{"display_login":"templedf"}}