{"action":"created","comment":{"url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/comments/77551995","id":77551995,"diff_hunk":"@@ -117,33 +117,33 @@ public function isGranted($identity, $permission, $context = null)\n         }\n \n         if ($this->hasAssertion($permission)) {\n-            return $this->assert($this->assertions[(string) $permission], $identity, $context);\n+            return $this->assert($this->assertions[(string) $permission], $permission, $identity, $context);","path":"src/Service/AuthorizationService.php","position":5,"original_position":5,"commit_id":"0328e4fa687ce2b6b1f3131f29105cc24611431b","original_commit_id":"0328e4fa687ce2b6b1f3131f29105cc24611431b","user":{"login":"basz","id":143068,"avatar_url":"https://avatars.githubusercontent.com/u/143068?v=3","gravatar_id":"","url":"https://api.github.com/users/basz","html_url":"https://github.com/basz","followers_url":"https://api.github.com/users/basz/followers","following_url":"https://api.github.com/users/basz/following{/other_user}","gists_url":"https://api.github.com/users/basz/gists{/gist_id}","starred_url":"https://api.github.com/users/basz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basz/subscriptions","organizations_url":"https://api.github.com/users/basz/orgs","repos_url":"https://api.github.com/users/basz/repos","events_url":"https://api.github.com/users/basz/events{/privacy}","received_events_url":"https://api.github.com/users/basz/received_events","type":"User","site_admin":false},"body":":-) can I do anything to help you get unconfused?","created_at":"2016-09-05T19:27:42Z","updated_at":"2016-09-05T19:27:42Z","html_url":"https://github.com/ZF-Commons/zfc-rbac/pull/344#discussion_r77551995","pull_request_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/344","_links":{"self":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/comments/77551995"},"html":{"href":"https://github.com/ZF-Commons/zfc-rbac/pull/344#discussion_r77551995"},"pull_request":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/344"}}},"pull_request":{"url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/344","id":83931768,"html_url":"https://github.com/ZF-Commons/zfc-rbac/pull/344","diff_url":"https://github.com/ZF-Commons/zfc-rbac/pull/344.diff","patch_url":"https://github.com/ZF-Commons/zfc-rbac/pull/344.patch","issue_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/issues/344","number":344,"state":"open","locked":false,"title":"Change/pass permission as param to assertions","user":{"login":"basz","id":143068,"avatar_url":"https://avatars.githubusercontent.com/u/143068?v=3","gravatar_id":"","url":"https://api.github.com/users/basz","html_url":"https://github.com/basz","followers_url":"https://api.github.com/users/basz/followers","following_url":"https://api.github.com/users/basz/following{/other_user}","gists_url":"https://api.github.com/users/basz/gists{/gist_id}","starred_url":"https://api.github.com/users/basz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basz/subscriptions","organizations_url":"https://api.github.com/users/basz/orgs","repos_url":"https://api.github.com/users/basz/repos","events_url":"https://api.github.com/users/basz/events{/privacy}","received_events_url":"https://api.github.com/users/basz/received_events","type":"User","site_admin":false},"body":"As proposed this PR passes the requested permission name to the Assertion::assert method, so the assertion can assert based on that information.\r\n\r\nNote: based on an PR #342 that is also a proposal. To avoid merge conflicts please review/merge that one first.","created_at":"2016-09-04T19:33:23Z","updated_at":"2016-09-05T19:27:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b5f67520ce8ba3a4542e8b543679e9d646aa359","assignee":{"login":"bakura10","id":1198915,"avatar_url":"https://avatars.githubusercontent.com/u/1198915?v=3","gravatar_id":"","url":"https://api.github.com/users/bakura10","html_url":"https://github.com/bakura10","followers_url":"https://api.github.com/users/bakura10/followers","following_url":"https://api.github.com/users/bakura10/following{/other_user}","gists_url":"https://api.github.com/users/bakura10/gists{/gist_id}","starred_url":"https://api.github.com/users/bakura10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakura10/subscriptions","organizations_url":"https://api.github.com/users/bakura10/orgs","repos_url":"https://api.github.com/users/bakura10/repos","events_url":"https://api.github.com/users/bakura10/events{/privacy}","received_events_url":"https://api.github.com/users/bakura10/received_events","type":"User","site_admin":false},"assignees":[{"login":"bakura10","id":1198915,"avatar_url":"https://avatars.githubusercontent.com/u/1198915?v=3","gravatar_id":"","url":"https://api.github.com/users/bakura10","html_url":"https://github.com/bakura10","followers_url":"https://api.github.com/users/bakura10/followers","following_url":"https://api.github.com/users/bakura10/following{/other_user}","gists_url":"https://api.github.com/users/bakura10/gists{/gist_id}","starred_url":"https://api.github.com/users/bakura10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakura10/subscriptions","organizations_url":"https://api.github.com/users/bakura10/orgs","repos_url":"https://api.github.com/users/bakura10/repos","events_url":"https://api.github.com/users/bakura10/events{/privacy}","received_events_url":"https://api.github.com/users/bakura10/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/344/commits","review_comments_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/344/comments","review_comment_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/issues/344/comments","statuses_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/statuses/0328e4fa687ce2b6b1f3131f29105cc24611431b","head":{"label":"basz:change/pass-permission-as-param-to-assertions","ref":"change/pass-permission-as-param-to-assertions","sha":"0328e4fa687ce2b6b1f3131f29105cc24611431b","user":{"login":"basz","id":143068,"avatar_url":"https://avatars.githubusercontent.com/u/143068?v=3","gravatar_id":"","url":"https://api.github.com/users/basz","html_url":"https://github.com/basz","followers_url":"https://api.github.com/users/basz/followers","following_url":"https://api.github.com/users/basz/following{/other_user}","gists_url":"https://api.github.com/users/basz/gists{/gist_id}","starred_url":"https://api.github.com/users/basz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basz/subscriptions","organizations_url":"https://api.github.com/users/basz/orgs","repos_url":"https://api.github.com/users/basz/repos","events_url":"https://api.github.com/users/basz/events{/privacy}","received_events_url":"https://api.github.com/users/basz/received_events","type":"User","site_admin":false},"repo":{"id":45913952,"name":"zfc-rbac","full_name":"basz/zfc-rbac","owner":{"login":"basz","id":143068,"avatar_url":"https://avatars.githubusercontent.com/u/143068?v=3","gravatar_id":"","url":"https://api.github.com/users/basz","html_url":"https://github.com/basz","followers_url":"https://api.github.com/users/basz/followers","following_url":"https://api.github.com/users/basz/following{/other_user}","gists_url":"https://api.github.com/users/basz/gists{/gist_id}","starred_url":"https://api.github.com/users/basz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basz/subscriptions","organizations_url":"https://api.github.com/users/basz/orgs","repos_url":"https://api.github.com/users/basz/repos","events_url":"https://api.github.com/users/basz/events{/privacy}","received_events_url":"https://api.github.com/users/basz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/basz/zfc-rbac","description":"Role-based access control module to provide additional features on top of Zend\\Permissions\\Rbac","fork":true,"url":"https://api.github.com/repos/basz/zfc-rbac","forks_url":"https://api.github.com/repos/basz/zfc-rbac/forks","keys_url":"https://api.github.com/repos/basz/zfc-rbac/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basz/zfc-rbac/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basz/zfc-rbac/teams","hooks_url":"https://api.github.com/repos/basz/zfc-rbac/hooks","issue_events_url":"https://api.github.com/repos/basz/zfc-rbac/issues/events{/number}","events_url":"https://api.github.com/repos/basz/zfc-rbac/events","assignees_url":"https://api.github.com/repos/basz/zfc-rbac/assignees{/user}","branches_url":"https://api.github.com/repos/basz/zfc-rbac/branches{/branch}","tags_url":"https://api.github.com/repos/basz/zfc-rbac/tags","blobs_url":"https://api.github.com/repos/basz/zfc-rbac/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basz/zfc-rbac/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basz/zfc-rbac/git/refs{/sha}","trees_url":"https://api.github.com/repos/basz/zfc-rbac/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basz/zfc-rbac/statuses/{sha}","languages_url":"https://api.github.com/repos/basz/zfc-rbac/languages","stargazers_url":"https://api.github.com/repos/basz/zfc-rbac/stargazers","contributors_url":"https://api.github.com/repos/basz/zfc-rbac/contributors","subscribers_url":"https://api.github.com/repos/basz/zfc-rbac/subscribers","subscription_url":"https://api.github.com/repos/basz/zfc-rbac/subscription","commits_url":"https://api.github.com/repos/basz/zfc-rbac/commits{/sha}","git_commits_url":"https://api.github.com/repos/basz/zfc-rbac/git/commits{/sha}","comments_url":"https://api.github.com/repos/basz/zfc-rbac/comments{/number}","issue_comment_url":"https://api.github.com/repos/basz/zfc-rbac/issues/comments{/number}","contents_url":"https://api.github.com/repos/basz/zfc-rbac/contents/{+path}","compare_url":"https://api.github.com/repos/basz/zfc-rbac/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basz/zfc-rbac/merges","archive_url":"https://api.github.com/repos/basz/zfc-rbac/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basz/zfc-rbac/downloads","issues_url":"https://api.github.com/repos/basz/zfc-rbac/issues{/number}","pulls_url":"https://api.github.com/repos/basz/zfc-rbac/pulls{/number}","milestones_url":"https://api.github.com/repos/basz/zfc-rbac/milestones{/number}","notifications_url":"https://api.github.com/repos/basz/zfc-rbac/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basz/zfc-rbac/labels{/name}","releases_url":"https://api.github.com/repos/basz/zfc-rbac/releases{/id}","deployments_url":"https://api.github.com/repos/basz/zfc-rbac/deployments","created_at":"2015-11-10T13:36:10Z","updated_at":"2016-08-29T12:24:43Z","pushed_at":"2016-09-05T18:56:55Z","git_url":"git://github.com/basz/zfc-rbac.git","ssh_url":"git@github.com:basz/zfc-rbac.git","clone_url":"https://github.com/basz/zfc-rbac.git","svn_url":"https://github.com/basz/zfc-rbac","homepage":"","size":1435,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ZF-Commons:develop","ref":"develop","sha":"7f4d0d856e8d08df9517b806160227891c499117","user":{"login":"ZF-Commons","id":1313211,"avatar_url":"https://avatars.githubusercontent.com/u/1313211?v=3","gravatar_id":"","url":"https://api.github.com/users/ZF-Commons","html_url":"https://github.com/ZF-Commons","followers_url":"https://api.github.com/users/ZF-Commons/followers","following_url":"https://api.github.com/users/ZF-Commons/following{/other_user}","gists_url":"https://api.github.com/users/ZF-Commons/gists{/gist_id}","starred_url":"https://api.github.com/users/ZF-Commons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZF-Commons/subscriptions","organizations_url":"https://api.github.com/users/ZF-Commons/orgs","repos_url":"https://api.github.com/users/ZF-Commons/repos","events_url":"https://api.github.com/users/ZF-Commons/events{/privacy}","received_events_url":"https://api.github.com/users/ZF-Commons/received_events","type":"Organization","site_admin":false},"repo":{"id":6282379,"name":"zfc-rbac","full_name":"ZF-Commons/zfc-rbac","owner":{"login":"ZF-Commons","id":1313211,"avatar_url":"https://avatars.githubusercontent.com/u/1313211?v=3","gravatar_id":"","url":"https://api.github.com/users/ZF-Commons","html_url":"https://github.com/ZF-Commons","followers_url":"https://api.github.com/users/ZF-Commons/followers","following_url":"https://api.github.com/users/ZF-Commons/following{/other_user}","gists_url":"https://api.github.com/users/ZF-Commons/gists{/gist_id}","starred_url":"https://api.github.com/users/ZF-Commons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZF-Commons/subscriptions","organizations_url":"https://api.github.com/users/ZF-Commons/orgs","repos_url":"https://api.github.com/users/ZF-Commons/repos","events_url":"https://api.github.com/users/ZF-Commons/events{/privacy}","received_events_url":"https://api.github.com/users/ZF-Commons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ZF-Commons/zfc-rbac","description":"Role-based access control module to provide additional features on top of Zend\\Permissions\\Rbac","fork":false,"url":"https://api.github.com/repos/ZF-Commons/zfc-rbac","forks_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/forks","keys_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/teams","hooks_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/hooks","issue_events_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/issues/events{/number}","events_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/events","assignees_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/assignees{/user}","branches_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/branches{/branch}","tags_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/tags","blobs_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/statuses/{sha}","languages_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/languages","stargazers_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/stargazers","contributors_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/contributors","subscribers_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/subscribers","subscription_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/subscription","commits_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/contents/{+path}","compare_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/merges","archive_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/downloads","issues_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/issues{/number}","pulls_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls{/number}","milestones_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/milestones{/number}","notifications_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/labels{/name}","releases_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/releases{/id}","deployments_url":"https://api.github.com/repos/ZF-Commons/zfc-rbac/deployments","created_at":"2012-10-18T17:07:13Z","updated_at":"2016-08-29T21:22:43Z","pushed_at":"2016-09-05T16:43:16Z","git_url":"git://github.com/ZF-Commons/zfc-rbac.git","ssh_url":"git@github.com:ZF-Commons/zfc-rbac.git","clone_url":"https://github.com/ZF-Commons/zfc-rbac.git","svn_url":"https://github.com/ZF-Commons/zfc-rbac","homepage":"","size":1599,"stargazers_count":173,"watchers_count":173,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"open_issues_count":27,"forks":121,"open_issues":27,"watchers":173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/344"},"html":{"href":"https://github.com/ZF-Commons/zfc-rbac/pull/344"},"issue":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/issues/344"},"comments":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/issues/344/comments"},"review_comments":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/344/comments"},"review_comment":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/pulls/344/commits"},"statuses":{"href":"https://api.github.com/repos/ZF-Commons/zfc-rbac/statuses/0328e4fa687ce2b6b1f3131f29105cc24611431b"}}}}
{"actor":{"display_login":"basz"}}