{"action":"closed","number":1020,"pull_request":{"url":"https://api.github.com/repos/avocado-framework/avocado/pulls/1020","id":59331299,"html_url":"https://github.com/avocado-framework/avocado/pull/1020","diff_url":"https://github.com/avocado-framework/avocado/pull/1020.diff","patch_url":"https://github.com/avocado-framework/avocado/pull/1020.patch","issue_url":"https://api.github.com/repos/avocado-framework/avocado/issues/1020","number":1020,"state":"closed","locked":false,"title":"Safe Loader: a second, more abstract and reusable implementation [v1]","user":{"login":"clebergnu","id":447178,"avatar_url":"https://avatars.githubusercontent.com/u/447178?v=3","gravatar_id":"","url":"https://api.github.com/users/clebergnu","html_url":"https://github.com/clebergnu","followers_url":"https://api.github.com/users/clebergnu/followers","following_url":"https://api.github.com/users/clebergnu/following{/other_user}","gists_url":"https://api.github.com/users/clebergnu/gists{/gist_id}","starred_url":"https://api.github.com/users/clebergnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clebergnu/subscriptions","organizations_url":"https://api.github.com/users/clebergnu/orgs","repos_url":"https://api.github.com/users/clebergnu/repos","events_url":"https://api.github.com/users/clebergnu/events{/privacy}","received_events_url":"https://api.github.com/users/clebergnu/received_events","type":"User","site_admin":false},"body":"When the safe(r) test loader mechanism was introduced in the `avocado.core.loader` module, it was written specifically to address Avocado's own needs (that is, `avocado.Test` based test classes).\r\n\r\nNow, we want to:\r\n\r\n * Allow the safe test loader to be optional, that is, allow the user to run `$ avocado list --unsafe` or similar\r\n * Increase the scope of tests that can be run by Avocado, and that includes standard Python unittests\r\n\r\nThe first step is to abstract and isolate the original safe loader code, which is done and this PR in the form of the  `avocado.core.safeloader` module. Then, as a PoC, we deliver a contrib script that makes use of this new module and finds unittests on Python source code files.\r\n\r\nThis brings us to an interesting situation, where, although not without flaws or limitations, Avocado can test itself, which was one of the original goals of the project. A sample session / command line would look like this:\r\n\r\n```    \r\n$ cd avocado/selftests/unit\r\n$ avocado run `../../contrib/avocado-find-unittests *.py | xargs` --external-runner '/usr/bin/python -m unittest'\r\n```\r\n\r\nThis has been put into a developer friendly target called `selfcheck`, so a developer can run:\r\n\r\n```\r\n$ make selfcheck\r\n...\r\nJOB ID     : 4eca6695394ff7741943c6713c1ac2529845c53d\r\nJOB LOG    : /home/cleber/avocado/job-results/job-2016-02-15T05.44-4eca669/job.log\r\nTESTS      : 293\r\n (1/293) selftests.unit.test_archive.ArchiveTest.test_zip_dir: PASS (0.17 s)\r\n (2/293) selftests.unit.test_archive.ArchiveTest.test_zip_file: PASS (0.18 s)\r\n...\r\n (292/293) selftests.functional.test_wrapper.WrapperTest.test_both_wrappers: PASS (1.38 s)\r\n (293/293) selftests.doc.test_doc_build.DocBuildTest.test_build_docs: PASS (0.21 s)\r\nRESULTS    : PASS 293 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0\r\nJOB HTML   : /home/cleber/avocado/job-results/job-2016-02-15T05.44-4eca669/html/results.html\r\nTIME       : 249.21 s\r\nselftests/check_tmp_dirs\r\nNo temporary avocado dirs lying around in /tmp\r\n```\r\n\r\nThe CI jobs on Travis have also been modified to be run on Avocado itself.\r\n\r\n---\r\n\r\nChanges from v0:\r\n   * Contrib script module path handling suggestions by @ldoktor \r\n   * Unittest fixes\r\n   * Addition of the Makefile selfcheck target\r\n   * Changes to Travis CI configuration","created_at":"2016-02-15T08:06:13Z","updated_at":"2016-02-22T12:19:02Z","closed_at":"2016-02-22T12:19:02Z","merged_at":null,"merge_commit_sha":"91f5f952096176ab09dbe2d20bdc83da1026b7ba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/avocado-framework/avocado/pulls/1020/commits","review_comments_url":"https://api.github.com/repos/avocado-framework/avocado/pulls/1020/comments","review_comment_url":"https://api.github.com/repos/avocado-framework/avocado/pulls/comments{/number}","comments_url":"https://api.github.com/repos/avocado-framework/avocado/issues/1020/comments","statuses_url":"https://api.github.com/repos/avocado-framework/avocado/statuses/725de588eb831050a2dee2af9a1e4f1b47fbf02c","head":{"label":"clebergnu:safeloader_v1","ref":"safeloader_v1","sha":"725de588eb831050a2dee2af9a1e4f1b47fbf02c","user":{"login":"clebergnu","id":447178,"avatar_url":"https://avatars.githubusercontent.com/u/447178?v=3","gravatar_id":"","url":"https://api.github.com/users/clebergnu","html_url":"https://github.com/clebergnu","followers_url":"https://api.github.com/users/clebergnu/followers","following_url":"https://api.github.com/users/clebergnu/following{/other_user}","gists_url":"https://api.github.com/users/clebergnu/gists{/gist_id}","starred_url":"https://api.github.com/users/clebergnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clebergnu/subscriptions","organizations_url":"https://api.github.com/users/clebergnu/orgs","repos_url":"https://api.github.com/users/clebergnu/repos","events_url":"https://api.github.com/users/clebergnu/events{/privacy}","received_events_url":"https://api.github.com/users/clebergnu/received_events","type":"User","site_admin":false},"repo":{"id":17944017,"name":"avocado","full_name":"clebergnu/avocado","owner":{"login":"clebergnu","id":447178,"avatar_url":"https://avatars.githubusercontent.com/u/447178?v=3","gravatar_id":"","url":"https://api.github.com/users/clebergnu","html_url":"https://github.com/clebergnu","followers_url":"https://api.github.com/users/clebergnu/followers","following_url":"https://api.github.com/users/clebergnu/following{/other_user}","gists_url":"https://api.github.com/users/clebergnu/gists{/gist_id}","starred_url":"https://api.github.com/users/clebergnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clebergnu/subscriptions","organizations_url":"https://api.github.com/users/clebergnu/orgs","repos_url":"https://api.github.com/users/clebergnu/repos","events_url":"https://api.github.com/users/clebergnu/events{/privacy}","received_events_url":"https://api.github.com/users/clebergnu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clebergnu/avocado","description":"Avocado Test Runner","fork":true,"url":"https://api.github.com/repos/clebergnu/avocado","forks_url":"https://api.github.com/repos/clebergnu/avocado/forks","keys_url":"https://api.github.com/repos/clebergnu/avocado/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clebergnu/avocado/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clebergnu/avocado/teams","hooks_url":"https://api.github.com/repos/clebergnu/avocado/hooks","issue_events_url":"https://api.github.com/repos/clebergnu/avocado/issues/events{/number}","events_url":"https://api.github.com/repos/clebergnu/avocado/events","assignees_url":"https://api.github.com/repos/clebergnu/avocado/assignees{/user}","branches_url":"https://api.github.com/repos/clebergnu/avocado/branches{/branch}","tags_url":"https://api.github.com/repos/clebergnu/avocado/tags","blobs_url":"https://api.github.com/repos/clebergnu/avocado/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clebergnu/avocado/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clebergnu/avocado/git/refs{/sha}","trees_url":"https://api.github.com/repos/clebergnu/avocado/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clebergnu/avocado/statuses/{sha}","languages_url":"https://api.github.com/repos/clebergnu/avocado/languages","stargazers_url":"https://api.github.com/repos/clebergnu/avocado/stargazers","contributors_url":"https://api.github.com/repos/clebergnu/avocado/contributors","subscribers_url":"https://api.github.com/repos/clebergnu/avocado/subscribers","subscription_url":"https://api.github.com/repos/clebergnu/avocado/subscription","commits_url":"https://api.github.com/repos/clebergnu/avocado/commits{/sha}","git_commits_url":"https://api.github.com/repos/clebergnu/avocado/git/commits{/sha}","comments_url":"https://api.github.com/repos/clebergnu/avocado/comments{/number}","issue_comment_url":"https://api.github.com/repos/clebergnu/avocado/issues/comments{/number}","contents_url":"https://api.github.com/repos/clebergnu/avocado/contents/{+path}","compare_url":"https://api.github.com/repos/clebergnu/avocado/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clebergnu/avocado/merges","archive_url":"https://api.github.com/repos/clebergnu/avocado/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clebergnu/avocado/downloads","issues_url":"https://api.github.com/repos/clebergnu/avocado/issues{/number}","pulls_url":"https://api.github.com/repos/clebergnu/avocado/pulls{/number}","milestones_url":"https://api.github.com/repos/clebergnu/avocado/milestones{/number}","notifications_url":"https://api.github.com/repos/clebergnu/avocado/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clebergnu/avocado/labels{/name}","releases_url":"https://api.github.com/repos/clebergnu/avocado/releases{/id}","deployments_url":"https://api.github.com/repos/clebergnu/avocado/deployments","created_at":"2014-03-20T13:42:05Z","updated_at":"2014-05-02T20:36:30Z","pushed_at":"2016-02-22T12:17:09Z","git_url":"git://github.com/clebergnu/avocado.git","ssh_url":"git@github.com:clebergnu/avocado.git","clone_url":"https://github.com/clebergnu/avocado.git","svn_url":"https://github.com/clebergnu/avocado","homepage":"","size":8284,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"avocado-framework:master","ref":"master","sha":"5638de02077e57861baef839717fb5354f07f73b","user":{"login":"avocado-framework","id":7245719,"avatar_url":"https://avatars.githubusercontent.com/u/7245719?v=3","gravatar_id":"","url":"https://api.github.com/users/avocado-framework","html_url":"https://github.com/avocado-framework","followers_url":"https://api.github.com/users/avocado-framework/followers","following_url":"https://api.github.com/users/avocado-framework/following{/other_user}","gists_url":"https://api.github.com/users/avocado-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/avocado-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avocado-framework/subscriptions","organizations_url":"https://api.github.com/users/avocado-framework/orgs","repos_url":"https://api.github.com/users/avocado-framework/repos","events_url":"https://api.github.com/users/avocado-framework/events{/privacy}","received_events_url":"https://api.github.com/users/avocado-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":17449498,"name":"avocado","full_name":"avocado-framework/avocado","owner":{"login":"avocado-framework","id":7245719,"avatar_url":"https://avatars.githubusercontent.com/u/7245719?v=3","gravatar_id":"","url":"https://api.github.com/users/avocado-framework","html_url":"https://github.com/avocado-framework","followers_url":"https://api.github.com/users/avocado-framework/followers","following_url":"https://api.github.com/users/avocado-framework/following{/other_user}","gists_url":"https://api.github.com/users/avocado-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/avocado-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avocado-framework/subscriptions","organizations_url":"https://api.github.com/users/avocado-framework/orgs","repos_url":"https://api.github.com/users/avocado-framework/repos","events_url":"https://api.github.com/users/avocado-framework/events{/privacy}","received_events_url":"https://api.github.com/users/avocado-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/avocado-framework/avocado","description":"Avocado Test Framework","fork":false,"url":"https://api.github.com/repos/avocado-framework/avocado","forks_url":"https://api.github.com/repos/avocado-framework/avocado/forks","keys_url":"https://api.github.com/repos/avocado-framework/avocado/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avocado-framework/avocado/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avocado-framework/avocado/teams","hooks_url":"https://api.github.com/repos/avocado-framework/avocado/hooks","issue_events_url":"https://api.github.com/repos/avocado-framework/avocado/issues/events{/number}","events_url":"https://api.github.com/repos/avocado-framework/avocado/events","assignees_url":"https://api.github.com/repos/avocado-framework/avocado/assignees{/user}","branches_url":"https://api.github.com/repos/avocado-framework/avocado/branches{/branch}","tags_url":"https://api.github.com/repos/avocado-framework/avocado/tags","blobs_url":"https://api.github.com/repos/avocado-framework/avocado/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avocado-framework/avocado/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avocado-framework/avocado/git/refs{/sha}","trees_url":"https://api.github.com/repos/avocado-framework/avocado/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avocado-framework/avocado/statuses/{sha}","languages_url":"https://api.github.com/repos/avocado-framework/avocado/languages","stargazers_url":"https://api.github.com/repos/avocado-framework/avocado/stargazers","contributors_url":"https://api.github.com/repos/avocado-framework/avocado/contributors","subscribers_url":"https://api.github.com/repos/avocado-framework/avocado/subscribers","subscription_url":"https://api.github.com/repos/avocado-framework/avocado/subscription","commits_url":"https://api.github.com/repos/avocado-framework/avocado/commits{/sha}","git_commits_url":"https://api.github.com/repos/avocado-framework/avocado/git/commits{/sha}","comments_url":"https://api.github.com/repos/avocado-framework/avocado/comments{/number}","issue_comment_url":"https://api.github.com/repos/avocado-framework/avocado/issues/comments{/number}","contents_url":"https://api.github.com/repos/avocado-framework/avocado/contents/{+path}","compare_url":"https://api.github.com/repos/avocado-framework/avocado/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avocado-framework/avocado/merges","archive_url":"https://api.github.com/repos/avocado-framework/avocado/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avocado-framework/avocado/downloads","issues_url":"https://api.github.com/repos/avocado-framework/avocado/issues{/number}","pulls_url":"https://api.github.com/repos/avocado-framework/avocado/pulls{/number}","milestones_url":"https://api.github.com/repos/avocado-framework/avocado/milestones{/number}","notifications_url":"https://api.github.com/repos/avocado-framework/avocado/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avocado-framework/avocado/labels{/name}","releases_url":"https://api.github.com/repos/avocado-framework/avocado/releases{/id}","deployments_url":"https://api.github.com/repos/avocado-framework/avocado/deployments","created_at":"2014-03-05T17:52:27Z","updated_at":"2016-02-06T10:40:43Z","pushed_at":"2016-02-22T12:18:50Z","git_url":"git://github.com/avocado-framework/avocado.git","ssh_url":"git@github.com:avocado-framework/avocado.git","clone_url":"https://github.com/avocado-framework/avocado.git","svn_url":"https://github.com/avocado-framework/avocado","homepage":"http://avocado-framework.github.io/","size":12808,"stargazers_count":30,"watchers_count":30,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":21,"forks":37,"open_issues":21,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/avocado-framework/avocado/pulls/1020"},"html":{"href":"https://github.com/avocado-framework/avocado/pull/1020"},"issue":{"href":"https://api.github.com/repos/avocado-framework/avocado/issues/1020"},"comments":{"href":"https://api.github.com/repos/avocado-framework/avocado/issues/1020/comments"},"review_comments":{"href":"https://api.github.com/repos/avocado-framework/avocado/pulls/1020/comments"},"review_comment":{"href":"https://api.github.com/repos/avocado-framework/avocado/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/avocado-framework/avocado/pulls/1020/commits"},"statuses":{"href":"https://api.github.com/repos/avocado-framework/avocado/statuses/725de588eb831050a2dee2af9a1e4f1b47fbf02c"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"commits":8,"additions":428,"deletions":127,"changed_files":12}}