{"action":"created","comment":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/53752181","id":53752181,"diff_hunk":"@@ -48,35 +49,35 @@ extern (C++) Expression eval_sin(Loc loc, FuncDeclaration fd, Expressions* argum\n {\n     Expression arg0 = (*arguments)[0];\n     assert(arg0.op == TOKfloat64);\n-    return new RealExp(loc, sinl(arg0.toReal()), arg0.type);\n+    return new RealExp(loc, TargetReal.sin(arg0.toReal()), arg0.type);","path":"src/builtin.d","position":13,"original_position":13,"commit_id":"6c0198449c48e06312bc429fa6c6aca72e59d0a7","original_commit_id":"6c0198449c48e06312bc429fa6c6aca72e59d0a7","user":{"login":"kinke","id":1889215,"avatar_url":"https://avatars.githubusercontent.com/u/1889215?v=3","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"body":"And once again, that's where we disagree. I see no advantage by moving these helpers back to `Port`, see my arguments before. They **only** depend on the `real_t` type and don't just take and return one (they should actually be considered `pure`).","created_at":"2016-02-23T09:02:40Z","updated_at":"2016-02-23T09:02:40Z","html_url":"https://github.com/D-Programming-Language/dmd/pull/5471#discussion_r53752181","pull_request_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5471","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/53752181"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/5471#discussion_r53752181"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5471"}}},"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5471","id":60099292,"html_url":"https://github.com/D-Programming-Language/dmd/pull/5471","diff_url":"https://github.com/D-Programming-Language/dmd/pull/5471.diff","patch_url":"https://github.com/D-Programming-Language/dmd/pull/5471.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/5471","number":5471,"state":"open","locked":false,"title":"Prepare for cross-compilability by using real_t as target real type","user":{"login":"kinke","id":1889215,"avatar_url":"https://avatars.githubusercontent.com/u/1889215?v=3","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"body":"And by removing the `longdouble` alias.\r\n\r\nAlso extract the `real_t` stuff from `ddmd.root.port` into its own module, `ddmd.root.real_t`. Cross-compilers (GDC, LDC in the near future) should only have to re-implement that module, including a custom `real_t` type implementing any desired target `real` precision in software.\r\n\r\nAlso includes some clean-ups, refactorings and renamings.","created_at":"2016-02-21T19:04:44Z","updated_at":"2016-02-23T09:02:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e1cd168d069e9a5335cf6794d4b53bea27ed98b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5471/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5471/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/5471/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/6c0198449c48e06312bc429fa6c6aca72e59d0a7","head":{"label":"kinke:real_t","ref":"real_t","sha":"6c0198449c48e06312bc429fa6c6aca72e59d0a7","user":{"login":"kinke","id":1889215,"avatar_url":"https://avatars.githubusercontent.com/u/1889215?v=3","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"repo":{"id":33406286,"name":"dmd","full_name":"kinke/dmd","owner":{"login":"kinke","id":1889215,"avatar_url":"https://avatars.githubusercontent.com/u/1889215?v=3","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kinke/dmd","description":"dmd D Programming Language compiler","fork":true,"url":"https://api.github.com/repos/kinke/dmd","forks_url":"https://api.github.com/repos/kinke/dmd/forks","keys_url":"https://api.github.com/repos/kinke/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinke/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinke/dmd/teams","hooks_url":"https://api.github.com/repos/kinke/dmd/hooks","issue_events_url":"https://api.github.com/repos/kinke/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/kinke/dmd/events","assignees_url":"https://api.github.com/repos/kinke/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/kinke/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/kinke/dmd/tags","blobs_url":"https://api.github.com/repos/kinke/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinke/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinke/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinke/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinke/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/kinke/dmd/languages","stargazers_url":"https://api.github.com/repos/kinke/dmd/stargazers","contributors_url":"https://api.github.com/repos/kinke/dmd/contributors","subscribers_url":"https://api.github.com/repos/kinke/dmd/subscribers","subscription_url":"https://api.github.com/repos/kinke/dmd/subscription","commits_url":"https://api.github.com/repos/kinke/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinke/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinke/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinke/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinke/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/kinke/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinke/dmd/merges","archive_url":"https://api.github.com/repos/kinke/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinke/dmd/downloads","issues_url":"https://api.github.com/repos/kinke/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/kinke/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/kinke/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/kinke/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinke/dmd/labels{/name}","releases_url":"https://api.github.com/repos/kinke/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/kinke/dmd/deployments","created_at":"2015-04-04T13:25:19Z","updated_at":"2015-04-26T13:46:15Z","pushed_at":"2016-02-22T20:14:04Z","git_url":"git://github.com/kinke/dmd.git","ssh_url":"git@github.com:kinke/dmd.git","clone_url":"https://github.com/kinke/dmd.git","svn_url":"https://github.com/kinke/dmd","homepage":"dlang.org","size":63031,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"3002a9683619957ce0d3f1379f99970f1664d087","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257070,"name":"dmd","full_name":"D-Programming-Language/dmd","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/dmd","description":"dmd D Programming Language compiler","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/dmd","forks_url":"https://api.github.com/repos/D-Programming-Language/dmd/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/dmd/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/dmd/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/dmd/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/dmd/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/dmd/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/dmd/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/dmd/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/dmd/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/dmd/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/D-Programming-Language/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/dmd/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/dmd/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/dmd/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/D-Programming-Language/dmd/deployments","created_at":"2011-01-15T06:53:53Z","updated_at":"2016-02-22T14:12:45Z","pushed_at":"2016-02-23T08:52:53Z","git_url":"git://github.com/D-Programming-Language/dmd.git","ssh_url":"git@github.com:D-Programming-Language/dmd.git","clone_url":"https://github.com/D-Programming-Language/dmd.git","svn_url":"https://github.com/D-Programming-Language/dmd","homepage":"dlang.org","size":85375,"stargazers_count":1186,"watchers_count":1186,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":358,"mirror_url":null,"open_issues_count":139,"forks":358,"open_issues":139,"watchers":1186,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5471"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/5471"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/issues/5471"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/issues/5471/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5471/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5471/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/6c0198449c48e06312bc429fa6c6aca72e59d0a7"}}}}