{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10624","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10624/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10624/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10624/events","html_url":"https://github.com/cockroachdb/cockroach/pull/10624","id":188676635,"number":10624,"title":"storage: replace TestStoreRangeDownReplicate with TestReplicateQueueD…","user":{"login":"vivekmenezes","id":11774212,"avatar_url":"https://avatars.githubusercontent.com/u/11774212?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekmenezes","html_url":"https://github.com/vivekmenezes","followers_url":"https://api.github.com/users/vivekmenezes/followers","following_url":"https://api.github.com/users/vivekmenezes/following{/other_user}","gists_url":"https://api.github.com/users/vivekmenezes/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekmenezes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekmenezes/subscriptions","organizations_url":"https://api.github.com/users/vivekmenezes/orgs","repos_url":"https://api.github.com/users/vivekmenezes/repos","events_url":"https://api.github.com/users/vivekmenezes/events{/privacy}","received_events_url":"https://api.github.com/users/vivekmenezes/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"assignees":[{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false}],"milestone":null,"comments":24,"created_at":"2016-11-11T03:24:45Z","updated_at":"2016-11-22T17:04:38Z","closed_at":"2016-11-22T15:30:50Z","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10624","html_url":"https://github.com/cockroachdb/cockroach/pull/10624","diff_url":"https://github.com/cockroachdb/cockroach/pull/10624.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/10624.patch"},"body":"…ownReplicate\r\n\r\nThe new test tests the down replication functionality using TestCluster.\r\n\r\nfixes #10536 fixes #10171 fixes #9603\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/10624)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/262300381","html_url":"https://github.com/cockroachdb/cockroach/pull/10624#issuecomment-262300381","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10624","id":262300381,"user":{"login":"vivekmenezes","id":11774212,"avatar_url":"https://avatars.githubusercontent.com/u/11774212?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekmenezes","html_url":"https://github.com/vivekmenezes","followers_url":"https://api.github.com/users/vivekmenezes/followers","following_url":"https://api.github.com/users/vivekmenezes/following{/other_user}","gists_url":"https://api.github.com/users/vivekmenezes/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekmenezes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekmenezes/subscriptions","organizations_url":"https://api.github.com/users/vivekmenezes/orgs","repos_url":"https://api.github.com/users/vivekmenezes/repos","events_url":"https://api.github.com/users/vivekmenezes/events{/privacy}","received_events_url":"https://api.github.com/users/vivekmenezes/received_events","type":"User","site_admin":false},"created_at":"2016-11-22T17:04:37Z","updated_at":"2016-11-22T17:04:37Z","body":"https://github.com/cockroachdb/cockroach/issues/10172 is still open and is\nthe same symptom as what you are seeing\n\nI'm not opposed to putting the test back if you'd like.\n\n\nOn Tue, Nov 22, 2016 at 11:28 AM Tamir Duberstein <notifications@github.com>\nwrote:\n\n> Merging this seems really really not kosher to me. Of the three issues\n> originally detected in this test, #10171\n> <https://github.com/cockroachdb/cockroach/issues/10171> and #9603\n> <https://github.com/cockroachdb/cockroach/issues/9603> were likely fixed\n> by #10728 <https://github.com/cockroachdb/cockroach/pull/10728> and #10875\n> <https://github.com/cockroachdb/cockroach/pull/10875> respectively. And\n> yet, neither of those fixes were actually checked and verified before\n> closing the associated issues.\n>\n> The final failure, #10536\n> <https://github.com/cockroachdb/cockroach/issues/10536>, remains\n> reproducible immediately before this merge, and I don't see any reason to\n> believe that rewriting the test from multiTestContext to TestCluster would\n> have a positive effect on its correctness or robustness. Worse yet, no such\n> improvement or rationale is detailed in this change.\n>\n> Finally, another running TestStoreRangeDownReplicate immediately before\n> this merge produces a new failure:\n>\n> $ make stress STRESSFLAGS='-p 100 -stderr -maxfails 1' PKG=./pkg/storage TESTS=TestStoreRangeDownReplicategithub.com/cockroachdb/cockroach/pkg/storagegithub.com/cockroachdb/cockroach/pkg/storage_test\n> testmain\n> 229 runs so far, 0 failures, over 5s\n> 486 runs so far, 0 failures, over 10s\n> 740 runs so far, 0 failures, over 15s\n> 1008 runs so far, 0 failures, over 20s\n> 1270 runs so far, 0 failures, over 25s\n> 1532 runs so far, 0 failures, over 30s\n> 1790 runs so far, 0 failures, over 35s\n> 2047 runs so far, 0 failures, over 40s\n> 2301 runs so far, 0 failures, over 45s\n> 2557 runs so far, 0 failures, over 50s\n> 2814 runs so far, 0 failures, over 55s\n> 3063 runs so far, 0 failures, over 1m0s\n> 3302 runs so far, 0 failures, over 1m5s\n> 3556 runs so far, 0 failures, over 1m10s\n> 3794 runs so far, 0 failures, over 1m15s\n> 4044 runs so far, 0 failures, over 1m20s\n> 4298 runs so far, 0 failures, over 1m25s\n>\n> --- FAIL: TestStoreRangeDownReplicate (1.84s)\n> \tclient_raft_test.go:1170: storage/replica_command.go:2455: split at key \"m\" failed: result is ambiguous (may have succeeded at failing replica)\n> FAIL\n>\n>\n> ERROR: exit status 1\n>\n> 4418 runs completed, 1 failures, over 1m28s\n> FAIL\n> Makefile:138: recipe for target 'stress' failed\n> make: *** [stress] Error 1\n>\n> Once again, it's not clear to me how rewriting this test fixes anything.\n>\n> It is important to give these issues the proper diligence. If we decide to\n> deprioritize them, that's fine, but closing them as \"fixed\" without the\n> proper investigation is not OK.\n>\n> —\n> You are receiving this because you modified the open/close state.\n>\n>\n> Reply to this email directly, view it on GitHub\n> <https://github.com/cockroachdb/cockroach/pull/10624#issuecomment-262289614>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ALOpBExsUwigtLBS2GzveQAy0kbd6sguks5rAxg-gaJpZM4KvY7h>\n> .\n>\n"}}
{"actor":{"display_login":"vivekmenezes"}}