{"action":"created","comment":{"url":"https://api.github.com/repos/electron-userland/electron-packager/pulls/comments/58325103","id":58325103,"diff_hunk":"@@ -6,14 +6,21 @@ var series = require('run-series')\n var config = require('./config.json')\n var util = require('./util')\n \n-// Download all Electron distributions before running tests to avoid timing out due to network speed\n+// Download all Electron distributions before running tests to avoid timing out due to network speed.\n+// Most tests run with the config.json version, but we have a special test (in mac.js) for 0.37.4.\n series([\n   function (cb) {\n     console.log('Calling electron-download before running tests...')\n     util.downloadAll(config.version, cb)\n   }, function (cb) {\n+    console.log('Calling electron-download 0.37.4 before running tests...')\n+    util.downloadAll('0.37.4', cb)","path":"test/index.js","position":13,"original_position":13,"commit_id":"1d023947a826eb2a44106ad0bbe253d24f7642d5","original_commit_id":"1d023947a826eb2a44106ad0bbe253d24f7642d5","user":{"login":"malept","id":11417,"avatar_url":"https://avatars.githubusercontent.com/u/11417?v=3","gravatar_id":"","url":"https://api.github.com/users/malept","html_url":"https://github.com/malept","followers_url":"https://api.github.com/users/malept/followers","following_url":"https://api.github.com/users/malept/following{/other_user}","gists_url":"https://api.github.com/users/malept/gists{/gist_id}","starred_url":"https://api.github.com/users/malept/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malept/subscriptions","organizations_url":"https://api.github.com/users/malept/orgs","repos_url":"https://api.github.com/users/malept/repos","events_url":"https://api.github.com/users/malept/events{/privacy}","received_events_url":"https://api.github.com/users/malept/received_events","type":"User","site_admin":false},"body":"It doesn't need to download Electron zips for 0.37.4, just the OSX ones.","created_at":"2016-04-04T03:06:15Z","updated_at":"2016-04-04T03:06:15Z","html_url":"https://github.com/electron-userland/electron-packager/pull/301#discussion_r58325103","pull_request_url":"https://api.github.com/repos/electron-userland/electron-packager/pulls/301","_links":{"self":{"href":"https://api.github.com/repos/electron-userland/electron-packager/pulls/comments/58325103"},"html":{"href":"https://github.com/electron-userland/electron-packager/pull/301#discussion_r58325103"},"pull_request":{"href":"https://api.github.com/repos/electron-userland/electron-packager/pulls/301"}}},"pull_request":{"url":"https://api.github.com/repos/electron-userland/electron-packager/pulls/301","id":65076536,"html_url":"https://github.com/electron-userland/electron-packager/pull/301","diff_url":"https://github.com/electron-userland/electron-packager/pull/301.diff","patch_url":"https://github.com/electron-userland/electron-packager/pull/301.patch","issue_url":"https://api.github.com/repos/electron-userland/electron-packager/issues/301","number":301,"state":"open","locked":false,"title":"Fix for issue 300: --icon option does not work under Electron 0.37.4","user":{"login":"erkyrath","id":65666,"avatar_url":"https://avatars.githubusercontent.com/u/65666?v=3","gravatar_id":"","url":"https://api.github.com/users/erkyrath","html_url":"https://github.com/erkyrath","followers_url":"https://api.github.com/users/erkyrath/followers","following_url":"https://api.github.com/users/erkyrath/following{/other_user}","gists_url":"https://api.github.com/users/erkyrath/gists{/gist_id}","starred_url":"https://api.github.com/users/erkyrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erkyrath/subscriptions","organizations_url":"https://api.github.com/users/erkyrath/orgs","repos_url":"https://api.github.com/users/erkyrath/repos","events_url":"https://api.github.com/users/erkyrath/events{/privacy}","received_events_url":"https://api.github.com/users/erkyrath/received_events","type":"User","site_admin":false},"body":"https://github.com/electron-userland/electron-packager/issues/300\r\n\r\nThis is an easy fix. It writes the icon to the filename defined in CFBundleIconFile, so it will work in Electron 0.37.4 as well as earlier versions.\r\n\r\nSince the test/config.json specifies \"0.35.6\", there's no way to test this fix directly. Is that okay, or should we figure out how to test both configurations? (If so, how?)\r\n","created_at":"2016-04-03T18:45:11Z","updated_at":"2016-04-04T03:06:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe6a91f8b7659a09b5ed6d9136fc3d33adb28245","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/electron-userland/electron-packager/pulls/301/commits","review_comments_url":"https://api.github.com/repos/electron-userland/electron-packager/pulls/301/comments","review_comment_url":"https://api.github.com/repos/electron-userland/electron-packager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron-userland/electron-packager/issues/301/comments","statuses_url":"https://api.github.com/repos/electron-userland/electron-packager/statuses/1d023947a826eb2a44106ad0bbe253d24f7642d5","head":{"label":"erkyrath:issue-300-iconname","ref":"issue-300-iconname","sha":"1d023947a826eb2a44106ad0bbe253d24f7642d5","user":{"login":"erkyrath","id":65666,"avatar_url":"https://avatars.githubusercontent.com/u/65666?v=3","gravatar_id":"","url":"https://api.github.com/users/erkyrath","html_url":"https://github.com/erkyrath","followers_url":"https://api.github.com/users/erkyrath/followers","following_url":"https://api.github.com/users/erkyrath/following{/other_user}","gists_url":"https://api.github.com/users/erkyrath/gists{/gist_id}","starred_url":"https://api.github.com/users/erkyrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erkyrath/subscriptions","organizations_url":"https://api.github.com/users/erkyrath/orgs","repos_url":"https://api.github.com/users/erkyrath/repos","events_url":"https://api.github.com/users/erkyrath/events{/privacy}","received_events_url":"https://api.github.com/users/erkyrath/received_events","type":"User","site_admin":false},"repo":{"id":51054181,"name":"electron-packager","full_name":"erkyrath/electron-packager","owner":{"login":"erkyrath","id":65666,"avatar_url":"https://avatars.githubusercontent.com/u/65666?v=3","gravatar_id":"","url":"https://api.github.com/users/erkyrath","html_url":"https://github.com/erkyrath","followers_url":"https://api.github.com/users/erkyrath/followers","following_url":"https://api.github.com/users/erkyrath/following{/other_user}","gists_url":"https://api.github.com/users/erkyrath/gists{/gist_id}","starred_url":"https://api.github.com/users/erkyrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erkyrath/subscriptions","organizations_url":"https://api.github.com/users/erkyrath/orgs","repos_url":"https://api.github.com/users/erkyrath/repos","events_url":"https://api.github.com/users/erkyrath/events{/privacy}","received_events_url":"https://api.github.com/users/erkyrath/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erkyrath/electron-packager","description":"Package and distribute your Electron app in OS executables (.app, .exe etc) via JS or CLI. Maintained by the community","fork":true,"url":"https://api.github.com/repos/erkyrath/electron-packager","forks_url":"https://api.github.com/repos/erkyrath/electron-packager/forks","keys_url":"https://api.github.com/repos/erkyrath/electron-packager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erkyrath/electron-packager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erkyrath/electron-packager/teams","hooks_url":"https://api.github.com/repos/erkyrath/electron-packager/hooks","issue_events_url":"https://api.github.com/repos/erkyrath/electron-packager/issues/events{/number}","events_url":"https://api.github.com/repos/erkyrath/electron-packager/events","assignees_url":"https://api.github.com/repos/erkyrath/electron-packager/assignees{/user}","branches_url":"https://api.github.com/repos/erkyrath/electron-packager/branches{/branch}","tags_url":"https://api.github.com/repos/erkyrath/electron-packager/tags","blobs_url":"https://api.github.com/repos/erkyrath/electron-packager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erkyrath/electron-packager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erkyrath/electron-packager/git/refs{/sha}","trees_url":"https://api.github.com/repos/erkyrath/electron-packager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erkyrath/electron-packager/statuses/{sha}","languages_url":"https://api.github.com/repos/erkyrath/electron-packager/languages","stargazers_url":"https://api.github.com/repos/erkyrath/electron-packager/stargazers","contributors_url":"https://api.github.com/repos/erkyrath/electron-packager/contributors","subscribers_url":"https://api.github.com/repos/erkyrath/electron-packager/subscribers","subscription_url":"https://api.github.com/repos/erkyrath/electron-packager/subscription","commits_url":"https://api.github.com/repos/erkyrath/electron-packager/commits{/sha}","git_commits_url":"https://api.github.com/repos/erkyrath/electron-packager/git/commits{/sha}","comments_url":"https://api.github.com/repos/erkyrath/electron-packager/comments{/number}","issue_comment_url":"https://api.github.com/repos/erkyrath/electron-packager/issues/comments{/number}","contents_url":"https://api.github.com/repos/erkyrath/electron-packager/contents/{+path}","compare_url":"https://api.github.com/repos/erkyrath/electron-packager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erkyrath/electron-packager/merges","archive_url":"https://api.github.com/repos/erkyrath/electron-packager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erkyrath/electron-packager/downloads","issues_url":"https://api.github.com/repos/erkyrath/electron-packager/issues{/number}","pulls_url":"https://api.github.com/repos/erkyrath/electron-packager/pulls{/number}","milestones_url":"https://api.github.com/repos/erkyrath/electron-packager/milestones{/number}","notifications_url":"https://api.github.com/repos/erkyrath/electron-packager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erkyrath/electron-packager/labels{/name}","releases_url":"https://api.github.com/repos/erkyrath/electron-packager/releases{/id}","deployments_url":"https://api.github.com/repos/erkyrath/electron-packager/deployments","created_at":"2016-02-04T05:24:40Z","updated_at":"2016-02-04T05:24:41Z","pushed_at":"2016-04-04T00:54:47Z","git_url":"git://github.com/erkyrath/electron-packager.git","ssh_url":"git@github.com:erkyrath/electron-packager.git","clone_url":"https://github.com/erkyrath/electron-packager.git","svn_url":"https://github.com/erkyrath/electron-packager","homepage":"https://www.npmjs.com/package/electron-packager","size":331,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"electron-userland:master","ref":"master","sha":"f3f8357a45643d68a1ae30b70e4ff53fb0283e78","user":{"login":"electron-userland","id":17519142,"avatar_url":"https://avatars.githubusercontent.com/u/17519142?v=3","gravatar_id":"","url":"https://api.github.com/users/electron-userland","html_url":"https://github.com/electron-userland","followers_url":"https://api.github.com/users/electron-userland/followers","following_url":"https://api.github.com/users/electron-userland/following{/other_user}","gists_url":"https://api.github.com/users/electron-userland/gists{/gist_id}","starred_url":"https://api.github.com/users/electron-userland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron-userland/subscriptions","organizations_url":"https://api.github.com/users/electron-userland/orgs","repos_url":"https://api.github.com/users/electron-userland/repos","events_url":"https://api.github.com/users/electron-userland/events{/privacy}","received_events_url":"https://api.github.com/users/electron-userland/received_events","type":"Organization","site_admin":false},"repo":{"id":32707901,"name":"electron-packager","full_name":"electron-userland/electron-packager","owner":{"login":"electron-userland","id":17519142,"avatar_url":"https://avatars.githubusercontent.com/u/17519142?v=3","gravatar_id":"","url":"https://api.github.com/users/electron-userland","html_url":"https://github.com/electron-userland","followers_url":"https://api.github.com/users/electron-userland/followers","following_url":"https://api.github.com/users/electron-userland/following{/other_user}","gists_url":"https://api.github.com/users/electron-userland/gists{/gist_id}","starred_url":"https://api.github.com/users/electron-userland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron-userland/subscriptions","organizations_url":"https://api.github.com/users/electron-userland/orgs","repos_url":"https://api.github.com/users/electron-userland/repos","events_url":"https://api.github.com/users/electron-userland/events{/privacy}","received_events_url":"https://api.github.com/users/electron-userland/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/electron-userland/electron-packager","description":"Package and distribute your Electron app with OS-specific bundles (.app, .exe etc) via JS or CLI","fork":false,"url":"https://api.github.com/repos/electron-userland/electron-packager","forks_url":"https://api.github.com/repos/electron-userland/electron-packager/forks","keys_url":"https://api.github.com/repos/electron-userland/electron-packager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron-userland/electron-packager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron-userland/electron-packager/teams","hooks_url":"https://api.github.com/repos/electron-userland/electron-packager/hooks","issue_events_url":"https://api.github.com/repos/electron-userland/electron-packager/issues/events{/number}","events_url":"https://api.github.com/repos/electron-userland/electron-packager/events","assignees_url":"https://api.github.com/repos/electron-userland/electron-packager/assignees{/user}","branches_url":"https://api.github.com/repos/electron-userland/electron-packager/branches{/branch}","tags_url":"https://api.github.com/repos/electron-userland/electron-packager/tags","blobs_url":"https://api.github.com/repos/electron-userland/electron-packager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron-userland/electron-packager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron-userland/electron-packager/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron-userland/electron-packager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron-userland/electron-packager/statuses/{sha}","languages_url":"https://api.github.com/repos/electron-userland/electron-packager/languages","stargazers_url":"https://api.github.com/repos/electron-userland/electron-packager/stargazers","contributors_url":"https://api.github.com/repos/electron-userland/electron-packager/contributors","subscribers_url":"https://api.github.com/repos/electron-userland/electron-packager/subscribers","subscription_url":"https://api.github.com/repos/electron-userland/electron-packager/subscription","commits_url":"https://api.github.com/repos/electron-userland/electron-packager/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron-userland/electron-packager/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron-userland/electron-packager/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron-userland/electron-packager/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron-userland/electron-packager/contents/{+path}","compare_url":"https://api.github.com/repos/electron-userland/electron-packager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron-userland/electron-packager/merges","archive_url":"https://api.github.com/repos/electron-userland/electron-packager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron-userland/electron-packager/downloads","issues_url":"https://api.github.com/repos/electron-userland/electron-packager/issues{/number}","pulls_url":"https://api.github.com/repos/electron-userland/electron-packager/pulls{/number}","milestones_url":"https://api.github.com/repos/electron-userland/electron-packager/milestones{/number}","notifications_url":"https://api.github.com/repos/electron-userland/electron-packager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron-userland/electron-packager/labels{/name}","releases_url":"https://api.github.com/repos/electron-userland/electron-packager/releases{/id}","deployments_url":"https://api.github.com/repos/electron-userland/electron-packager/deployments","created_at":"2015-03-23T02:54:14Z","updated_at":"2016-04-03T22:59:59Z","pushed_at":"2016-04-04T00:54:48Z","git_url":"git://github.com/electron-userland/electron-packager.git","ssh_url":"git@github.com:electron-userland/electron-packager.git","clone_url":"https://github.com/electron-userland/electron-packager.git","svn_url":"https://github.com/electron-userland/electron-packager","homepage":"https://www.npmjs.com/package/electron-packager","size":406,"stargazers_count":1693,"watchers_count":1693,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":149,"mirror_url":null,"open_issues_count":59,"forks":149,"open_issues":59,"watchers":1693,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron-userland/electron-packager/pulls/301"},"html":{"href":"https://github.com/electron-userland/electron-packager/pull/301"},"issue":{"href":"https://api.github.com/repos/electron-userland/electron-packager/issues/301"},"comments":{"href":"https://api.github.com/repos/electron-userland/electron-packager/issues/301/comments"},"review_comments":{"href":"https://api.github.com/repos/electron-userland/electron-packager/pulls/301/comments"},"review_comment":{"href":"https://api.github.com/repos/electron-userland/electron-packager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron-userland/electron-packager/pulls/301/commits"},"statuses":{"href":"https://api.github.com/repos/electron-userland/electron-packager/statuses/1d023947a826eb2a44106ad0bbe253d24f7642d5"}}}}