{"action":"created","issue":{"url":"https://api.github.com/repos/eacaps/es6-actioncable/issues/4","repository_url":"https://api.github.com/repos/eacaps/es6-actioncable","labels_url":"https://api.github.com/repos/eacaps/es6-actioncable/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/eacaps/es6-actioncable/issues/4/comments","events_url":"https://api.github.com/repos/eacaps/es6-actioncable/issues/4/events","html_url":"https://github.com/eacaps/es6-actioncable/pull/4","id":145242300,"number":4,"title":"Mattheworiordan node js support","user":{"login":"eacaps","id":8252280,"avatar_url":"https://avatars.githubusercontent.com/u/8252280?v=3","gravatar_id":"","url":"https://api.github.com/users/eacaps","html_url":"https://github.com/eacaps","followers_url":"https://api.github.com/users/eacaps/followers","following_url":"https://api.github.com/users/eacaps/following{/other_user}","gists_url":"https://api.github.com/users/eacaps/gists{/gist_id}","starred_url":"https://api.github.com/users/eacaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eacaps/subscriptions","organizations_url":"https://api.github.com/users/eacaps/orgs","repos_url":"https://api.github.com/users/eacaps/repos","events_url":"https://api.github.com/users/eacaps/events{/privacy}","received_events_url":"https://api.github.com/users/eacaps/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-01T17:52:26Z","updated_at":"2016-04-19T18:55:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eacaps/es6-actioncable/pulls/4","html_url":"https://github.com/eacaps/es6-actioncable/pull/4","diff_url":"https://github.com/eacaps/es6-actioncable/pull/4.diff","patch_url":"https://github.com/eacaps/es6-actioncable/pull/4.patch"},"body":"This project was initially created to only support action cable connections via the browser so it assumes that the WebSocket library would be provided by the browser. These changes allow users to specify a function to create the websocket in the options(createWebsocket). This allows action cable to be used in node.js via the https://www.npmjs.com/package/websocket package. An example is provided in the README. Thanks to @mattheworiordan for providing this use case."},"comment":{"url":"https://api.github.com/repos/eacaps/es6-actioncable/issues/comments/212067744","html_url":"https://github.com/eacaps/es6-actioncable/pull/4#issuecomment-212067744","issue_url":"https://api.github.com/repos/eacaps/es6-actioncable/issues/4","id":212067744,"user":{"login":"mattheworiordan","id":43789,"avatar_url":"https://avatars.githubusercontent.com/u/43789?v=3","gravatar_id":"","url":"https://api.github.com/users/mattheworiordan","html_url":"https://github.com/mattheworiordan","followers_url":"https://api.github.com/users/mattheworiordan/followers","following_url":"https://api.github.com/users/mattheworiordan/following{/other_user}","gists_url":"https://api.github.com/users/mattheworiordan/gists{/gist_id}","starred_url":"https://api.github.com/users/mattheworiordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattheworiordan/subscriptions","organizations_url":"https://api.github.com/users/mattheworiordan/orgs","repos_url":"https://api.github.com/users/mattheworiordan/repos","events_url":"https://api.github.com/users/mattheworiordan/events{/privacy}","received_events_url":"https://api.github.com/users/mattheworiordan/received_events","type":"User","site_admin":false},"created_at":"2016-04-19T18:55:45Z","updated_at":"2016-04-19T18:55:45Z","body":"Thanks @eacaps, sorry for the slow reply, been super busy!  I personally prefer the approach where an external dependency is  not required but can optionally be injected, however I also understand why you may not want to do this so this looks good to me."}}