{"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/73806323","id":73806323,"diff_hunk":"@@ -8156,6 +8156,13 @@ float Unit::GetUnitSpellCriticalChance(Unit* victim, SpellInfo const* spellProto\n     // not critting spell\n     if ((spellProto->HasAttribute(SPELL_ATTR2_CANT_CRIT)))\n         return 0.0f;\n+\t\n+    if (victim && HasNextSpellCritData(victim, spellProto->Id))","path":"src/server/game/Entities/Unit/Unit.cpp","position":5,"original_position":5,"commit_id":"f9193f68491a2180977b5e1e1bc723764014dce6","original_commit_id":"f9193f68491a2180977b5e1e1bc723764014dce6","user":{"login":"P-Kito","id":876676,"avatar_url":"https://avatars.githubusercontent.com/u/876676?v=3","gravatar_id":"","url":"https://api.github.com/users/P-Kito","html_url":"https://github.com/P-Kito","followers_url":"https://api.github.com/users/P-Kito/followers","following_url":"https://api.github.com/users/P-Kito/following{/other_user}","gists_url":"https://api.github.com/users/P-Kito/gists{/gist_id}","starred_url":"https://api.github.com/users/P-Kito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/P-Kito/subscriptions","organizations_url":"https://api.github.com/users/P-Kito/orgs","repos_url":"https://api.github.com/users/P-Kito/repos","events_url":"https://api.github.com/users/P-Kito/events{/privacy}","received_events_url":"https://api.github.com/users/P-Kito/received_events","type":"User","site_admin":false},"body":"does victim need to be checked here?","created_at":"2016-08-07T18:02:55Z","updated_at":"2016-08-07T18:02:55Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/17753#discussion_r73806323","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17753","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/73806323"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/17753#discussion_r73806323"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17753"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17753","id":80372917,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/17753","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/17753.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/17753.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17753","number":17753,"state":"open","locked":false,"title":"Core/Spells: Implemented the function to set the next crit/noncrit of a spell","user":{"login":"PortgasDAce","id":639817,"avatar_url":"https://avatars.githubusercontent.com/u/639817?v=3","gravatar_id":"","url":"https://api.github.com/users/PortgasDAce","html_url":"https://github.com/PortgasDAce","followers_url":"https://api.github.com/users/PortgasDAce/followers","following_url":"https://api.github.com/users/PortgasDAce/following{/other_user}","gists_url":"https://api.github.com/users/PortgasDAce/gists{/gist_id}","starred_url":"https://api.github.com/users/PortgasDAce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PortgasDAce/subscriptions","organizations_url":"https://api.github.com/users/PortgasDAce/orgs","repos_url":"https://api.github.com/users/PortgasDAce/repos","events_url":"https://api.github.com/users/PortgasDAce/events{/privacy}","received_events_url":"https://api.github.com/users/PortgasDAce/received_events","type":"User","site_admin":false},"body":"**Changes proposed:**\r\n\r\n-  Set the next spell crit/noncrit for a specific target\r\n\r\n**Target branch(es):** 6.x\r\n\r\n**Tests performed:** (Does it build, tested in-game, etc)\r\nTested with Demon hunter spell Chaos Strike.\r\nChaos Strike should have a shared crit roll for main and off hand and it worked.\r\nIf Main hand crits, off hand will too.. if main hand doesn't crit, the off hand won't too\r\n\r\n**Known issues and TODO list:**\r\n\r\n- [ ] \r\n- [ ] ","created_at":"2016-08-07T17:35:40Z","updated_at":"2016-08-07T18:02:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c28888cebbd386cfd36d0ea206642612ce0caacc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17753/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17753/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17753/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/f9193f68491a2180977b5e1e1bc723764014dce6","head":{"label":"PortgasDAce:6.x","ref":"6.x","sha":"f9193f68491a2180977b5e1e1bc723764014dce6","user":{"login":"PortgasDAce","id":639817,"avatar_url":"https://avatars.githubusercontent.com/u/639817?v=3","gravatar_id":"","url":"https://api.github.com/users/PortgasDAce","html_url":"https://github.com/PortgasDAce","followers_url":"https://api.github.com/users/PortgasDAce/followers","following_url":"https://api.github.com/users/PortgasDAce/following{/other_user}","gists_url":"https://api.github.com/users/PortgasDAce/gists{/gist_id}","starred_url":"https://api.github.com/users/PortgasDAce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PortgasDAce/subscriptions","organizations_url":"https://api.github.com/users/PortgasDAce/orgs","repos_url":"https://api.github.com/users/PortgasDAce/repos","events_url":"https://api.github.com/users/PortgasDAce/events{/privacy}","received_events_url":"https://api.github.com/users/PortgasDAce/received_events","type":"User","site_admin":false},"repo":{"id":65143358,"name":"TrinityCore","full_name":"PortgasDAce/TrinityCore","owner":{"login":"PortgasDAce","id":639817,"avatar_url":"https://avatars.githubusercontent.com/u/639817?v=3","gravatar_id":"","url":"https://api.github.com/users/PortgasDAce","html_url":"https://github.com/PortgasDAce","followers_url":"https://api.github.com/users/PortgasDAce/followers","following_url":"https://api.github.com/users/PortgasDAce/following{/other_user}","gists_url":"https://api.github.com/users/PortgasDAce/gists{/gist_id}","starred_url":"https://api.github.com/users/PortgasDAce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PortgasDAce/subscriptions","organizations_url":"https://api.github.com/users/PortgasDAce/orgs","repos_url":"https://api.github.com/users/PortgasDAce/repos","events_url":"https://api.github.com/users/PortgasDAce/events{/privacy}","received_events_url":"https://api.github.com/users/PortgasDAce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PortgasDAce/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/PortgasDAce/TrinityCore","forks_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/forks","keys_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/teams","hooks_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/events","assignees_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/tags","blobs_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/subscription","commits_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/merges","archive_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/downloads","issues_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/PortgasDAce/TrinityCore/deployments","created_at":"2016-08-07T16:34:27Z","updated_at":"2016-08-07T16:34:45Z","pushed_at":"2016-08-07T17:27:33Z","git_url":"git://github.com/PortgasDAce/TrinityCore.git","ssh_url":"git@github.com:PortgasDAce/TrinityCore.git","clone_url":"https://github.com/PortgasDAce/TrinityCore.git","svn_url":"https://github.com/PortgasDAce/TrinityCore","homepage":"http://www.trinitycore.org","size":362883,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"6.x"}},"base":{"label":"TrinityCore:6.x","ref":"6.x","sha":"93bf99fe70266c0702816c3aecdcb04e9e2cb4f9","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/deployments","created_at":"2010-12-28T23:40:07Z","updated_at":"2016-08-07T11:22:46Z","pushed_at":"2016-08-07T17:35:40Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":787066,"stargazers_count":3435,"watchers_count":3435,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3509,"mirror_url":null,"open_issues_count":1324,"forks":3509,"open_issues":1324,"watchers":3435,"default_branch":"6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17753"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/17753"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17753"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17753/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17753/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17753/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/f9193f68491a2180977b5e1e1bc723764014dce6"}}}}
{"actor":{"display_login":"P-Kito"}}