{"action":"created","issue":{"url":"https://api.github.com/repos/EddyVerbruggen/cordova-plugin-safariviewcontroller/issues/23","repository_url":"https://api.github.com/repos/EddyVerbruggen/cordova-plugin-safariviewcontroller","labels_url":"https://api.github.com/repos/EddyVerbruggen/cordova-plugin-safariviewcontroller/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/EddyVerbruggen/cordova-plugin-safariviewcontroller/issues/23/comments","events_url":"https://api.github.com/repos/EddyVerbruggen/cordova-plugin-safariviewcontroller/issues/23/events","html_url":"https://github.com/EddyVerbruggen/cordova-plugin-safariviewcontroller/pull/23","id":153439525,"number":23,"title":"[WIP] Chrome custome tabs","user":{"login":"yakirn","id":6659632,"avatar_url":"https://avatars.githubusercontent.com/u/6659632?v=3","gravatar_id":"","url":"https://api.github.com/users/yakirn","html_url":"https://github.com/yakirn","followers_url":"https://api.github.com/users/yakirn/followers","following_url":"https://api.github.com/users/yakirn/following{/other_user}","gists_url":"https://api.github.com/users/yakirn/gists{/gist_id}","starred_url":"https://api.github.com/users/yakirn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yakirn/subscriptions","organizations_url":"https://api.github.com/users/yakirn/orgs","repos_url":"https://api.github.com/users/yakirn/repos","events_url":"https://api.github.com/users/yakirn/events{/privacy}","received_events_url":"https://api.github.com/users/yakirn/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-05-06T12:19:50Z","updated_at":"2016-05-18T09:58:10Z","closed_at":"2016-05-17T14:07:40Z","pull_request":{"url":"https://api.github.com/repos/EddyVerbruggen/cordova-plugin-safariviewcontroller/pulls/23","html_url":"https://github.com/EddyVerbruggen/cordova-plugin-safariviewcontroller/pull/23","diff_url":"https://github.com/EddyVerbruggen/cordova-plugin-safariviewcontroller/pull/23.diff","patch_url":"https://github.com/EddyVerbruggen/cordova-plugin-safariviewcontroller/pull/23.patch"},"body":"Hi\r\nI think this plugin is a good alternative for the InAppBrowser plugin in terms of UI and UX, and I thought why not give Android users some of that awesomeness with [Chrome Custom Tabs](https://developer.chrome.com/multidevice/android/customtabs) :)\r\n\r\n> As of Chrome 45, Chrome Custom Tabs is now generally available to all users of Chrome, on all of Chrome's supported Android versions (Jellybean onwards).\r\n\r\nThere is still (a lot of) work to do on this PR, but I wanted to open it now in order to start a discussion.\r\nIs this something you see fit in this plugin? If yes, I think we will need to change it's name ;)\r\nThe link above lists many advantagas of Custom Tabs over WebView. some of them, like [Warm up](https://developer.chrome.com/multidevice/android/customtabs#warm-up chrome to make pages load faster) or the [Custom Action button](https://developer.chrome.com/multidevice/android/customtabs#configure-a custom action button) requires us to extend this plugin's current set of APIs to allow developers take advantage of. does this seems relevant to you?\r\n\r\nWork to be done:\r\n- [x] Really implement the `isAvailable ` function by trying to connect to Chrome's service\r\n- [ ] accept parametrs like transition animation, color and others in the `show` function\r\n- [ ] implement `hide` so that cordova's javacscript code can close the tab (not sure this can be fully supported)\r\n- [x] Implement a `warmUp` function\r\n- [ ] accept action buttons argument in `show` (optional)\r\n- [ ] Did I miss anything?"},"comment":{"url":"https://api.github.com/repos/EddyVerbruggen/cordova-plugin-safariviewcontroller/issues/comments/219980782","html_url":"https://github.com/EddyVerbruggen/cordova-plugin-safariviewcontroller/pull/23#issuecomment-219980782","issue_url":"https://api.github.com/repos/EddyVerbruggen/cordova-plugin-safariviewcontroller/issues/23","id":219980782,"user":{"login":"ezazwar1","id":13368631,"avatar_url":"https://avatars.githubusercontent.com/u/13368631?v=3","gravatar_id":"","url":"https://api.github.com/users/ezazwar1","html_url":"https://github.com/ezazwar1","followers_url":"https://api.github.com/users/ezazwar1/followers","following_url":"https://api.github.com/users/ezazwar1/following{/other_user}","gists_url":"https://api.github.com/users/ezazwar1/gists{/gist_id}","starred_url":"https://api.github.com/users/ezazwar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezazwar1/subscriptions","organizations_url":"https://api.github.com/users/ezazwar1/orgs","repos_url":"https://api.github.com/users/ezazwar1/repos","events_url":"https://api.github.com/users/ezazwar1/events{/privacy}","received_events_url":"https://api.github.com/users/ezazwar1/received_events","type":"User","site_admin":false},"created_at":"2016-05-18T09:58:10Z","updated_at":"2016-05-18T09:58:10Z","body":"Hey @EddyVerbruggen  Thanks \r\n\r\ni suggest @yakirn  to make his own repo because the name doesn't fit the cause of the plugin and @EddyVerbruggen  you can put a link in this repo to @yakirn  repo\r\n\r\nand @EddyVerbruggen  i have few issues in wkwebview if you can have a look at them please\r\n\r\nRegards \r\nEzaz"}}