{"action":"created","issue":{"url":"https://api.github.com/repos/scheib/chromium-latest-linux/issues/1","repository_url":"https://api.github.com/repos/scheib/chromium-latest-linux","labels_url":"https://api.github.com/repos/scheib/chromium-latest-linux/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/scheib/chromium-latest-linux/issues/1/comments","events_url":"https://api.github.com/repos/scheib/chromium-latest-linux/issues/1/events","html_url":"https://github.com/scheib/chromium-latest-linux/issues/1","id":148638111,"number":1,"title":"Your script is not complete.","user":{"login":"kuh3h3","id":23828,"avatar_url":"https://avatars.githubusercontent.com/u/23828?v=3","gravatar_id":"","url":"https://api.github.com/users/kuh3h3","html_url":"https://github.com/kuh3h3","followers_url":"https://api.github.com/users/kuh3h3/followers","following_url":"https://api.github.com/users/kuh3h3/following{/other_user}","gists_url":"https://api.github.com/users/kuh3h3/gists{/gist_id}","starred_url":"https://api.github.com/users/kuh3h3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuh3h3/subscriptions","organizations_url":"https://api.github.com/users/kuh3h3/orgs","repos_url":"https://api.github.com/users/kuh3h3/repos","events_url":"https://api.github.com/users/kuh3h3/events{/privacy}","received_events_url":"https://api.github.com/users/kuh3h3/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-15T11:42:38Z","updated_at":"2016-05-25T17:08:03Z","closed_at":null,"body":"download and update  part ok.\r\nbut. When run, not work.\r\nbecause without suid sandbox can`t run chrome directly.\r\nand need to add flash.\r\n1.\r\nsudo chmod 4755 latest/chrome_sandbox\r\n\r\n2. change run.sh to run chrome-wrapper like this\r\n=================================================\r\n#! /bin/bash\r\n\r\nBASEDIR=$(dirname $0)\r\nexport CHROME_DEVEL_SANDBOX=\"$BASEDIR/latest/chrome_sandbox\"\r\nLD_LIBRAY_PATH=`$BASEDIR/latest` $BASEDIR/latest/chrome-wrapper --ppapi-flash-path=/opt/google/chrome-unstable/PepperFlash/libpepflashplayer.so --ppapi-flash-version=21.0\r\n.0.216 --user-data-dir=\"$BASEDIR/user-data-dir\" $* &> /dev/null &\r\n\r\n\r\n\r\n "},"comment":{"url":"https://api.github.com/repos/scheib/chromium-latest-linux/issues/comments/221641757","html_url":"https://github.com/scheib/chromium-latest-linux/issues/1#issuecomment-221641757","issue_url":"https://api.github.com/repos/scheib/chromium-latest-linux/issues/1","id":221641757,"user":{"login":"smarek","id":384824,"avatar_url":"https://avatars.githubusercontent.com/u/384824?v=3","gravatar_id":"","url":"https://api.github.com/users/smarek","html_url":"https://github.com/smarek","followers_url":"https://api.github.com/users/smarek/followers","following_url":"https://api.github.com/users/smarek/following{/other_user}","gists_url":"https://api.github.com/users/smarek/gists{/gist_id}","starred_url":"https://api.github.com/users/smarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarek/subscriptions","organizations_url":"https://api.github.com/users/smarek/orgs","repos_url":"https://api.github.com/users/smarek/repos","events_url":"https://api.github.com/users/smarek/events{/privacy}","received_events_url":"https://api.github.com/users/smarek/received_events","type":"User","site_admin":false},"created_at":"2016-05-25T17:08:03Z","updated_at":"2016-05-25T17:08:03Z","body":"Regarding this issue, I've changed the repository differently, to achieve sandboxed functionality.\r\n\r\nChanges:\r\n  - Uses global user profile, not separate one\r\n  - Automatically after update changes ownership and permissions on latest/chrome_sandbox\r\n  - Runs through chrome-wrapper, not chrome binary\r\n  - Disabled Google Api Keys warning\r\n\r\nDiff as follows:\r\n\r\n```diff\r\ndiff --git a/run.sh b/run.sh\r\nindex 2d5f026..1ac7406 100755\r\n--- a/run.sh\r\n+++ b/run.sh\r\n@@ -1,5 +1,12 @@\r\n #! /bin/bash\r\n \r\n-BASEDIR=$(dirname $0)\r\n+# BASEDIR=$(dirname $0)\r\n \r\n-$BASEDIR/latest/chrome --user-data-dir=\"$BASEDIR/user-data-dir\" $* &> /dev/null &\r\n+# $BASEDIR/latest/chrome --user-data-dir=\"$BASEDIR/user-data-dir\" $* &> /dev/null &\r\n+\r\n+export GOOGLE_API_KEY=\"no\"\r\n+export GOOGLE_DEFAULT_CLIENT_ID=\"no\"\r\n+export GOOGLE_DEFAULT_CLIENT_SECRET=\"no\"\r\n+\r\n+CHROME_DEVEL_SANDBOX=~/.opt/chromium-latest-linux/latest/chrome_sandbox ~/.opt/chromium-latest-linux/latest/chrome-wrapper $*\r\n+#CHROME_DEVEL_SANDBOX=~/.opt/chromium-latest-linux/latest/chrome_sandbox ~/.opt/chromium-latest-linux/latest/chrome-wrapper --user-data-dir=\"$BASEDIR/user-data-dir\" $*\r\ndiff --git a/update.sh b/update.sh\r\nindex 6730185..4765fba 100755\r\n--- a/update.sh\r\n+++ b/update.sh\r\n@@ -29,3 +29,4 @@ popd\r\n rm -f ./latest\r\n ln -s $REVISION/chrome-linux/ ./latest\r\n \r\n+./wrapper.sh\r\ndiff --git a/wrapper.sh b/wrapper.sh\r\nnew file mode 100755\r\nindex 0000000..16d19b9\r\n--- /dev/null\r\n+++ b/wrapper.sh\r\n@@ -0,0 +1,6 @@\r\n+#!/bin/bash\r\n+\r\n+echo \"Chrome Wrapper Update\"\r\n+\r\n+sudo chown root:root latest/chrome_sandbox\r\n+sudo chmod 4755 latest/chrome_sandbox\r\n```"}}
{"actor":{"display_login":"smarek"}}