{"action":"created","comment":{"url":"https://api.github.com/repos/freeipa/freeipa/pulls/comments/80685583","pull_request_review_id":1723979,"id":80685583,"diff_hunk":"@@ -196,3 +197,36 @@ def test_install_master(self):\n \n     def test_install_kra(self):\n         tasks.install_kra(self.master, first_instance=True)\n+\n+\n+@pytest.mark.ds_acceptance\n+class TestDSAcceptance(IntegrationTest):\n+    num_replicas = 1\n+\n+    @classmethod\n+    def install(cls, mh):\n+        tasks.install_master(cls.master, setup_dns=True)\n+\n+    def test_install_replica0(self):\n+        tasks.install_replica(self.master, self.replicas[0], setup_ca=False,\n+                              setup_kra=False, setup_dns=False)\n+\n+\n+@pytest.mark.cs_acceptance\n+class TestCSAcceptance(IntegrationTest):","path":"ipatests/test_integration/test_installation.py","position":28,"original_position":28,"commit_id":"b63cb30e0f48b0b94a52b909372f924d17d2ab3c","original_commit_id":"b63cb30e0f48b0b94a52b909372f924d17d2ab3c","user":{"login":"mbasti-rh","id":20207783,"avatar_url":"https://avatars.githubusercontent.com/u/20207783?v=3","gravatar_id":"","url":"https://api.github.com/users/mbasti-rh","html_url":"https://github.com/mbasti-rh","followers_url":"https://api.github.com/users/mbasti-rh/followers","following_url":"https://api.github.com/users/mbasti-rh/following{/other_user}","gists_url":"https://api.github.com/users/mbasti-rh/gists{/gist_id}","starred_url":"https://api.github.com/users/mbasti-rh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbasti-rh/subscriptions","organizations_url":"https://api.github.com/users/mbasti-rh/orgs","repos_url":"https://api.github.com/users/mbasti-rh/repos","events_url":"https://api.github.com/users/mbasti-rh/events{/privacy}","received_events_url":"https://api.github.com/users/mbasti-rh/received_events","type":"User","site_admin":false},"body":"This looks for me like just duplication of some installation tests, would be better to mark whole TestInstallWithCA_KRA_DNS1 test?","created_at":"2016-09-27T13:01:10Z","updated_at":"2016-09-27T13:03:15Z","html_url":"https://github.com/freeipa/freeipa/pull/122#discussion_r80685583","pull_request_url":"https://api.github.com/repos/freeipa/freeipa/pulls/122","_links":{"self":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/comments/80685583"},"html":{"href":"https://github.com/freeipa/freeipa/pull/122#discussion_r80685583"},"pull_request":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/122"}}},"pull_request":{"url":"https://api.github.com/repos/freeipa/freeipa/pulls/122","id":86922840,"html_url":"https://github.com/freeipa/freeipa/pull/122","diff_url":"https://github.com/freeipa/freeipa/pull/122.diff","patch_url":"https://github.com/freeipa/freeipa/pull/122.patch","issue_url":"https://api.github.com/repos/freeipa/freeipa/issues/122","number":122,"state":"open","locked":false,"title":"Acceptance tests","user":{"login":"dkupka","id":19951675,"avatar_url":"https://avatars.githubusercontent.com/u/19951675?v=3","gravatar_id":"","url":"https://api.github.com/users/dkupka","html_url":"https://github.com/dkupka","followers_url":"https://api.github.com/users/dkupka/followers","following_url":"https://api.github.com/users/dkupka/following{/other_user}","gists_url":"https://api.github.com/users/dkupka/gists{/gist_id}","starred_url":"https://api.github.com/users/dkupka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkupka/subscriptions","organizations_url":"https://api.github.com/users/dkupka/orgs","repos_url":"https://api.github.com/users/dkupka/repos","events_url":"https://api.github.com/users/dkupka/events{/privacy}","received_events_url":"https://api.github.com/users/dkupka/received_events","type":"User","site_admin":false},"body":"Starting with minimal suite that will grow as necessary.","created_at":"2016-09-27T12:48:46Z","updated_at":"2016-09-27T13:03:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec8cf236b6ca005e907b6aff8273f3ff2ea9bc39","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/freeipa/freeipa/pulls/122/commits","review_comments_url":"https://api.github.com/repos/freeipa/freeipa/pulls/122/comments","review_comment_url":"https://api.github.com/repos/freeipa/freeipa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freeipa/freeipa/issues/122/comments","statuses_url":"https://api.github.com/repos/freeipa/freeipa/statuses/b63cb30e0f48b0b94a52b909372f924d17d2ab3c","head":{"label":"dkupka:acceptance_tests","ref":"acceptance_tests","sha":"b63cb30e0f48b0b94a52b909372f924d17d2ab3c","user":{"login":"dkupka","id":19951675,"avatar_url":"https://avatars.githubusercontent.com/u/19951675?v=3","gravatar_id":"","url":"https://api.github.com/users/dkupka","html_url":"https://github.com/dkupka","followers_url":"https://api.github.com/users/dkupka/followers","following_url":"https://api.github.com/users/dkupka/following{/other_user}","gists_url":"https://api.github.com/users/dkupka/gists{/gist_id}","starred_url":"https://api.github.com/users/dkupka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkupka/subscriptions","organizations_url":"https://api.github.com/users/dkupka/orgs","repos_url":"https://api.github.com/users/dkupka/repos","events_url":"https://api.github.com/users/dkupka/events{/privacy}","received_events_url":"https://api.github.com/users/dkupka/received_events","type":"User","site_admin":false},"repo":{"id":61205120,"name":"freeipa","full_name":"dkupka/freeipa","owner":{"login":"dkupka","id":19951675,"avatar_url":"https://avatars.githubusercontent.com/u/19951675?v=3","gravatar_id":"","url":"https://api.github.com/users/dkupka","html_url":"https://github.com/dkupka","followers_url":"https://api.github.com/users/dkupka/followers","following_url":"https://api.github.com/users/dkupka/following{/other_user}","gists_url":"https://api.github.com/users/dkupka/gists{/gist_id}","starred_url":"https://api.github.com/users/dkupka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkupka/subscriptions","organizations_url":"https://api.github.com/users/dkupka/orgs","repos_url":"https://api.github.com/users/dkupka/repos","events_url":"https://api.github.com/users/dkupka/events{/privacy}","received_events_url":"https://api.github.com/users/dkupka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dkupka/freeipa","description":"Mirror of FreeIPA, an integrated security information management solution","fork":true,"url":"https://api.github.com/repos/dkupka/freeipa","forks_url":"https://api.github.com/repos/dkupka/freeipa/forks","keys_url":"https://api.github.com/repos/dkupka/freeipa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dkupka/freeipa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dkupka/freeipa/teams","hooks_url":"https://api.github.com/repos/dkupka/freeipa/hooks","issue_events_url":"https://api.github.com/repos/dkupka/freeipa/issues/events{/number}","events_url":"https://api.github.com/repos/dkupka/freeipa/events","assignees_url":"https://api.github.com/repos/dkupka/freeipa/assignees{/user}","branches_url":"https://api.github.com/repos/dkupka/freeipa/branches{/branch}","tags_url":"https://api.github.com/repos/dkupka/freeipa/tags","blobs_url":"https://api.github.com/repos/dkupka/freeipa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dkupka/freeipa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dkupka/freeipa/git/refs{/sha}","trees_url":"https://api.github.com/repos/dkupka/freeipa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dkupka/freeipa/statuses/{sha}","languages_url":"https://api.github.com/repos/dkupka/freeipa/languages","stargazers_url":"https://api.github.com/repos/dkupka/freeipa/stargazers","contributors_url":"https://api.github.com/repos/dkupka/freeipa/contributors","subscribers_url":"https://api.github.com/repos/dkupka/freeipa/subscribers","subscription_url":"https://api.github.com/repos/dkupka/freeipa/subscription","commits_url":"https://api.github.com/repos/dkupka/freeipa/commits{/sha}","git_commits_url":"https://api.github.com/repos/dkupka/freeipa/git/commits{/sha}","comments_url":"https://api.github.com/repos/dkupka/freeipa/comments{/number}","issue_comment_url":"https://api.github.com/repos/dkupka/freeipa/issues/comments{/number}","contents_url":"https://api.github.com/repos/dkupka/freeipa/contents/{+path}","compare_url":"https://api.github.com/repos/dkupka/freeipa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dkupka/freeipa/merges","archive_url":"https://api.github.com/repos/dkupka/freeipa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dkupka/freeipa/downloads","issues_url":"https://api.github.com/repos/dkupka/freeipa/issues{/number}","pulls_url":"https://api.github.com/repos/dkupka/freeipa/pulls{/number}","milestones_url":"https://api.github.com/repos/dkupka/freeipa/milestones{/number}","notifications_url":"https://api.github.com/repos/dkupka/freeipa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dkupka/freeipa/labels{/name}","releases_url":"https://api.github.com/repos/dkupka/freeipa/releases{/id}","deployments_url":"https://api.github.com/repos/dkupka/freeipa/deployments","created_at":"2016-06-15T12:08:03Z","updated_at":"2016-06-15T12:08:08Z","pushed_at":"2016-09-27T12:45:53Z","git_url":"git://github.com/dkupka/freeipa.git","ssh_url":"git@github.com:dkupka/freeipa.git","clone_url":"https://github.com/dkupka/freeipa.git","svn_url":"https://github.com/dkupka/freeipa","homepage":"http://freeipa.org/","size":32975,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freeipa:master","ref":"master","sha":"45e3aee35219c89c07d590003a334f8db658a3b2","user":{"login":"freeipa","id":10979201,"avatar_url":"https://avatars.githubusercontent.com/u/10979201?v=3","gravatar_id":"","url":"https://api.github.com/users/freeipa","html_url":"https://github.com/freeipa","followers_url":"https://api.github.com/users/freeipa/followers","following_url":"https://api.github.com/users/freeipa/following{/other_user}","gists_url":"https://api.github.com/users/freeipa/gists{/gist_id}","starred_url":"https://api.github.com/users/freeipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeipa/subscriptions","organizations_url":"https://api.github.com/users/freeipa/orgs","repos_url":"https://api.github.com/users/freeipa/repos","events_url":"https://api.github.com/users/freeipa/events{/privacy}","received_events_url":"https://api.github.com/users/freeipa/received_events","type":"Organization","site_admin":false},"repo":{"id":4340318,"name":"freeipa","full_name":"freeipa/freeipa","owner":{"login":"freeipa","id":10979201,"avatar_url":"https://avatars.githubusercontent.com/u/10979201?v=3","gravatar_id":"","url":"https://api.github.com/users/freeipa","html_url":"https://github.com/freeipa","followers_url":"https://api.github.com/users/freeipa/followers","following_url":"https://api.github.com/users/freeipa/following{/other_user}","gists_url":"https://api.github.com/users/freeipa/gists{/gist_id}","starred_url":"https://api.github.com/users/freeipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeipa/subscriptions","organizations_url":"https://api.github.com/users/freeipa/orgs","repos_url":"https://api.github.com/users/freeipa/repos","events_url":"https://api.github.com/users/freeipa/events{/privacy}","received_events_url":"https://api.github.com/users/freeipa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freeipa/freeipa","description":"Mirror of FreeIPA, an integrated security information management solution","fork":false,"url":"https://api.github.com/repos/freeipa/freeipa","forks_url":"https://api.github.com/repos/freeipa/freeipa/forks","keys_url":"https://api.github.com/repos/freeipa/freeipa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freeipa/freeipa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freeipa/freeipa/teams","hooks_url":"https://api.github.com/repos/freeipa/freeipa/hooks","issue_events_url":"https://api.github.com/repos/freeipa/freeipa/issues/events{/number}","events_url":"https://api.github.com/repos/freeipa/freeipa/events","assignees_url":"https://api.github.com/repos/freeipa/freeipa/assignees{/user}","branches_url":"https://api.github.com/repos/freeipa/freeipa/branches{/branch}","tags_url":"https://api.github.com/repos/freeipa/freeipa/tags","blobs_url":"https://api.github.com/repos/freeipa/freeipa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freeipa/freeipa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freeipa/freeipa/git/refs{/sha}","trees_url":"https://api.github.com/repos/freeipa/freeipa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freeipa/freeipa/statuses/{sha}","languages_url":"https://api.github.com/repos/freeipa/freeipa/languages","stargazers_url":"https://api.github.com/repos/freeipa/freeipa/stargazers","contributors_url":"https://api.github.com/repos/freeipa/freeipa/contributors","subscribers_url":"https://api.github.com/repos/freeipa/freeipa/subscribers","subscription_url":"https://api.github.com/repos/freeipa/freeipa/subscription","commits_url":"https://api.github.com/repos/freeipa/freeipa/commits{/sha}","git_commits_url":"https://api.github.com/repos/freeipa/freeipa/git/commits{/sha}","comments_url":"https://api.github.com/repos/freeipa/freeipa/comments{/number}","issue_comment_url":"https://api.github.com/repos/freeipa/freeipa/issues/comments{/number}","contents_url":"https://api.github.com/repos/freeipa/freeipa/contents/{+path}","compare_url":"https://api.github.com/repos/freeipa/freeipa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freeipa/freeipa/merges","archive_url":"https://api.github.com/repos/freeipa/freeipa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freeipa/freeipa/downloads","issues_url":"https://api.github.com/repos/freeipa/freeipa/issues{/number}","pulls_url":"https://api.github.com/repos/freeipa/freeipa/pulls{/number}","milestones_url":"https://api.github.com/repos/freeipa/freeipa/milestones{/number}","notifications_url":"https://api.github.com/repos/freeipa/freeipa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freeipa/freeipa/labels{/name}","releases_url":"https://api.github.com/repos/freeipa/freeipa/releases{/id}","deployments_url":"https://api.github.com/repos/freeipa/freeipa/deployments","created_at":"2012-05-15T20:34:40Z","updated_at":"2016-09-25T20:22:24Z","pushed_at":"2016-09-27T12:48:46Z","git_url":"git://github.com/freeipa/freeipa.git","ssh_url":"git@github.com:freeipa/freeipa.git","clone_url":"https://github.com/freeipa/freeipa.git","svn_url":"https://github.com/freeipa/freeipa","homepage":"http://www.freeipa.org","size":36893,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":17,"forks":47,"open_issues":17,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/122"},"html":{"href":"https://github.com/freeipa/freeipa/pull/122"},"issue":{"href":"https://api.github.com/repos/freeipa/freeipa/issues/122"},"comments":{"href":"https://api.github.com/repos/freeipa/freeipa/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/freeipa/freeipa/statuses/b63cb30e0f48b0b94a52b909372f924d17d2ab3c"}}}}
{"actor":{"display_login":"mbasti-rh"}}