{"action":"created","issue":{"url":"https://api.github.com/repos/Shopify/js-buy-sdk/issues/249","repository_url":"https://api.github.com/repos/Shopify/js-buy-sdk","labels_url":"https://api.github.com/repos/Shopify/js-buy-sdk/issues/249/labels{/name}","comments_url":"https://api.github.com/repos/Shopify/js-buy-sdk/issues/249/comments","events_url":"https://api.github.com/repos/Shopify/js-buy-sdk/issues/249/events","html_url":"https://github.com/Shopify/js-buy-sdk/pull/249","id":183068688,"number":249,"title":"ie9 error messaging when not runnning on https","user":{"login":"mikkoh","id":496903,"avatar_url":"https://avatars.githubusercontent.com/u/496903?v=3","gravatar_id":"","url":"https://api.github.com/users/mikkoh","html_url":"https://github.com/mikkoh","followers_url":"https://api.github.com/users/mikkoh/followers","following_url":"https://api.github.com/users/mikkoh/following{/other_user}","gists_url":"https://api.github.com/users/mikkoh/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkoh/subscriptions","organizations_url":"https://api.github.com/users/mikkoh/orgs","repos_url":"https://api.github.com/users/mikkoh/repos","events_url":"https://api.github.com/users/mikkoh/events{/privacy}","received_events_url":"https://api.github.com/users/mikkoh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-14T14:45:29Z","updated_at":"2016-10-14T15:40:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Shopify/js-buy-sdk/pulls/249","html_url":"https://github.com/Shopify/js-buy-sdk/pull/249","diff_url":"https://github.com/Shopify/js-buy-sdk/pull/249.diff","patch_url":"https://github.com/Shopify/js-buy-sdk/pull/249.patch"},"body":"This PR just simply adds error messaging for when the `js-buy-sdk` is not run on an https server.\r\n\r\n@minasmart @tessalt "},"comment":{"url":"https://api.github.com/repos/Shopify/js-buy-sdk/issues/comments/253837744","html_url":"https://github.com/Shopify/js-buy-sdk/pull/249#issuecomment-253837744","issue_url":"https://api.github.com/repos/Shopify/js-buy-sdk/issues/249","id":253837744,"user":{"login":"mikkoh","id":496903,"avatar_url":"https://avatars.githubusercontent.com/u/496903?v=3","gravatar_id":"","url":"https://api.github.com/users/mikkoh","html_url":"https://github.com/mikkoh","followers_url":"https://api.github.com/users/mikkoh/followers","following_url":"https://api.github.com/users/mikkoh/following{/other_user}","gists_url":"https://api.github.com/users/mikkoh/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkoh/subscriptions","organizations_url":"https://api.github.com/users/mikkoh/orgs","repos_url":"https://api.github.com/users/mikkoh/repos","events_url":"https://api.github.com/users/mikkoh/events{/privacy}","received_events_url":"https://api.github.com/users/mikkoh/received_events","type":"User","site_admin":false},"created_at":"2016-10-14T15:40:49Z","updated_at":"2016-10-14T15:40:49Z","body":"@tessalt for the error handling you wrote how do you feel about doing something like this:\r\n```\r\n    function handleError(error) {\r\n      reject(new Error(`There was an error with the XDR\\n${JSON.stringify(error)}`));\r\n    }\r\n```\r\nDo you agree that that error should not be handled by the logger?"}}
{"actor":{"display_login":"mikkoh"}}