{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/uncart/pulls/comments/66186349","id":66186349,"diff_hunk":"@@ -1,13 +1,16 @@\n-#include <string.h>\n-#include <stdlib.h>\n-#include <stdio.h>\n-\n #include \"draw.h\"\n #include \"hid.h\"\n #include \"i2c.h\"\n #include \"fatfs/ff.h\"\n #include \"gamecart/protocol.h\"\n #include \"gamecart/command_ctr.h\"\n+#include \"headers.h\"\n+#include \"i2c.h\"\n+\n+#include <string.h>","path":"source/main.c","position":14,"original_position":14,"commit_id":"4f1fd1a32bd9738749a620c0bf62e25476ebfff4","original_commit_id":"2c3870dbadae5c263225f4c2faa274393e0130de","user":{"login":"lioncash","id":712067,"avatar_url":"https://avatars.githubusercontent.com/u/712067?v=3","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"body":"These headers were initially above draw.h. ","created_at":"2016-06-08T03:02:55Z","updated_at":"2016-06-08T03:02:55Z","html_url":"https://github.com/citra-emu/uncart/pull/21#discussion_r66186349","pull_request_url":"https://api.github.com/repos/citra-emu/uncart/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/uncart/pulls/comments/66186349"},"html":{"href":"https://github.com/citra-emu/uncart/pull/21#discussion_r66186349"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/uncart/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/uncart/pulls/21","id":72872295,"html_url":"https://github.com/citra-emu/uncart/pull/21","diff_url":"https://github.com/citra-emu/uncart/pull/21.diff","patch_url":"https://github.com/citra-emu/uncart/pull/21.patch","issue_url":"https://api.github.com/repos/citra-emu/uncart/issues/21","number":21,"state":"open","locked":false,"title":"A9lh support, optional trim support, and cleanups","user":{"login":"gemarcano","id":4000062,"avatar_url":"https://avatars.githubusercontent.com/u/4000062?v=3","gravatar_id":"","url":"https://api.github.com/users/gemarcano","html_url":"https://github.com/gemarcano","followers_url":"https://api.github.com/users/gemarcano/followers","following_url":"https://api.github.com/users/gemarcano/following{/other_user}","gists_url":"https://api.github.com/users/gemarcano/gists{/gist_id}","starred_url":"https://api.github.com/users/gemarcano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemarcano/subscriptions","organizations_url":"https://api.github.com/users/gemarcano/orgs","repos_url":"https://api.github.com/users/gemarcano/repos","events_url":"https://api.github.com/users/gemarcano/events{/privacy}","received_events_url":"https://api.github.com/users/gemarcano/received_events","type":"User","site_admin":false},"body":"I'm the original author of the trimming code that's been making rounds in the form of a patch. I finally have permission to contribute openly to the homebrew community. Anyhow, this PR does what the title says: Enables A9LH support, provides users with a choice between dumping all of ROM or just what's in the partitions, and then does some cleanups with regards to memory management (refer to the commit messages for a longer explanation of what this entails).\r\n\r\nOne thing to note, this PR replaces Brahma support for A9LH support. If you want to keep both, I have work in my own master I can merge to this branch that allows both to co-exist. Or I can open another PR with that. Up to you. (I really hate how limiting the default 3DS Makefiles are... hard to specify different targets).\r\n\r\nAs an aside, to give credit where it is due, the inspiration for the trimming support came from rom_tool, which I noticed was doing something similar to trim files.","created_at":"2016-06-07T13:13:00Z","updated_at":"2016-06-08T03:02:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e626cd4110ec5ad1fe94764efa8c36f2d726e1d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/uncart/pulls/21/commits","review_comments_url":"https://api.github.com/repos/citra-emu/uncart/pulls/21/comments","review_comment_url":"https://api.github.com/repos/citra-emu/uncart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citra-emu/uncart/issues/21/comments","statuses_url":"https://api.github.com/repos/citra-emu/uncart/statuses/4f1fd1a32bd9738749a620c0bf62e25476ebfff4","head":{"label":"gemarcano:trim-cleanup","ref":"trim-cleanup","sha":"4f1fd1a32bd9738749a620c0bf62e25476ebfff4","user":{"login":"gemarcano","id":4000062,"avatar_url":"https://avatars.githubusercontent.com/u/4000062?v=3","gravatar_id":"","url":"https://api.github.com/users/gemarcano","html_url":"https://github.com/gemarcano","followers_url":"https://api.github.com/users/gemarcano/followers","following_url":"https://api.github.com/users/gemarcano/following{/other_user}","gists_url":"https://api.github.com/users/gemarcano/gists{/gist_id}","starred_url":"https://api.github.com/users/gemarcano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemarcano/subscriptions","organizations_url":"https://api.github.com/users/gemarcano/orgs","repos_url":"https://api.github.com/users/gemarcano/repos","events_url":"https://api.github.com/users/gemarcano/events{/privacy}","received_events_url":"https://api.github.com/users/gemarcano/received_events","type":"User","site_admin":false},"repo":{"id":59709476,"name":"uncart","full_name":"gemarcano/uncart","owner":{"login":"gemarcano","id":4000062,"avatar_url":"https://avatars.githubusercontent.com/u/4000062?v=3","gravatar_id":"","url":"https://api.github.com/users/gemarcano","html_url":"https://github.com/gemarcano","followers_url":"https://api.github.com/users/gemarcano/followers","following_url":"https://api.github.com/users/gemarcano/following{/other_user}","gists_url":"https://api.github.com/users/gemarcano/gists{/gist_id}","starred_url":"https://api.github.com/users/gemarcano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemarcano/subscriptions","organizations_url":"https://api.github.com/users/gemarcano/orgs","repos_url":"https://api.github.com/users/gemarcano/repos","events_url":"https://api.github.com/users/gemarcano/events{/privacy}","received_events_url":"https://api.github.com/users/gemarcano/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gemarcano/uncart","description":" 3DS homebrew utility program to dump game cartridges to the SD card","fork":true,"url":"https://api.github.com/repos/gemarcano/uncart","forks_url":"https://api.github.com/repos/gemarcano/uncart/forks","keys_url":"https://api.github.com/repos/gemarcano/uncart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gemarcano/uncart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gemarcano/uncart/teams","hooks_url":"https://api.github.com/repos/gemarcano/uncart/hooks","issue_events_url":"https://api.github.com/repos/gemarcano/uncart/issues/events{/number}","events_url":"https://api.github.com/repos/gemarcano/uncart/events","assignees_url":"https://api.github.com/repos/gemarcano/uncart/assignees{/user}","branches_url":"https://api.github.com/repos/gemarcano/uncart/branches{/branch}","tags_url":"https://api.github.com/repos/gemarcano/uncart/tags","blobs_url":"https://api.github.com/repos/gemarcano/uncart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gemarcano/uncart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gemarcano/uncart/git/refs{/sha}","trees_url":"https://api.github.com/repos/gemarcano/uncart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gemarcano/uncart/statuses/{sha}","languages_url":"https://api.github.com/repos/gemarcano/uncart/languages","stargazers_url":"https://api.github.com/repos/gemarcano/uncart/stargazers","contributors_url":"https://api.github.com/repos/gemarcano/uncart/contributors","subscribers_url":"https://api.github.com/repos/gemarcano/uncart/subscribers","subscription_url":"https://api.github.com/repos/gemarcano/uncart/subscription","commits_url":"https://api.github.com/repos/gemarcano/uncart/commits{/sha}","git_commits_url":"https://api.github.com/repos/gemarcano/uncart/git/commits{/sha}","comments_url":"https://api.github.com/repos/gemarcano/uncart/comments{/number}","issue_comment_url":"https://api.github.com/repos/gemarcano/uncart/issues/comments{/number}","contents_url":"https://api.github.com/repos/gemarcano/uncart/contents/{+path}","compare_url":"https://api.github.com/repos/gemarcano/uncart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gemarcano/uncart/merges","archive_url":"https://api.github.com/repos/gemarcano/uncart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gemarcano/uncart/downloads","issues_url":"https://api.github.com/repos/gemarcano/uncart/issues{/number}","pulls_url":"https://api.github.com/repos/gemarcano/uncart/pulls{/number}","milestones_url":"https://api.github.com/repos/gemarcano/uncart/milestones{/number}","notifications_url":"https://api.github.com/repos/gemarcano/uncart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gemarcano/uncart/labels{/name}","releases_url":"https://api.github.com/repos/gemarcano/uncart/releases{/id}","deployments_url":"https://api.github.com/repos/gemarcano/uncart/deployments","created_at":"2016-05-26T01:22:12Z","updated_at":"2016-05-26T01:32:13Z","pushed_at":"2016-06-07T13:32:30Z","git_url":"git://github.com/gemarcano/uncart.git","ssh_url":"git@github.com:gemarcano/uncart.git","clone_url":"https://github.com/gemarcano/uncart.git","svn_url":"https://github.com/gemarcano/uncart","homepage":"","size":763,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"13a9ad8ec52c509bfc057e0a435dbe82ce5d5021","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":36511442,"name":"uncart","full_name":"citra-emu/uncart","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/uncart","description":" 3DS homebrew utility program to dump game cartridges to the SD card","fork":false,"url":"https://api.github.com/repos/citra-emu/uncart","forks_url":"https://api.github.com/repos/citra-emu/uncart/forks","keys_url":"https://api.github.com/repos/citra-emu/uncart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/uncart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/uncart/teams","hooks_url":"https://api.github.com/repos/citra-emu/uncart/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/uncart/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/uncart/events","assignees_url":"https://api.github.com/repos/citra-emu/uncart/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/uncart/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/uncart/tags","blobs_url":"https://api.github.com/repos/citra-emu/uncart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/uncart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/uncart/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/uncart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/uncart/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/uncart/languages","stargazers_url":"https://api.github.com/repos/citra-emu/uncart/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/uncart/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/uncart/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/uncart/subscription","commits_url":"https://api.github.com/repos/citra-emu/uncart/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/uncart/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/uncart/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/uncart/issues/comments{/number}","contents_url":"https://api.github.com/repos/citra-emu/uncart/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/uncart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/uncart/merges","archive_url":"https://api.github.com/repos/citra-emu/uncart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/uncart/downloads","issues_url":"https://api.github.com/repos/citra-emu/uncart/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/uncart/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/uncart/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/uncart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/uncart/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/uncart/releases{/id}","deployments_url":"https://api.github.com/repos/citra-emu/uncart/deployments","created_at":"2015-05-29T15:07:09Z","updated_at":"2016-05-30T04:01:59Z","pushed_at":"2016-06-07T13:32:30Z","git_url":"git://github.com/citra-emu/uncart.git","ssh_url":"git@github.com:citra-emu/uncart.git","clone_url":"https://github.com/citra-emu/uncart.git","svn_url":"https://github.com/citra-emu/uncart","homepage":"","size":863,"stargazers_count":40,"watchers_count":40,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":12,"forks":24,"open_issues":12,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/uncart/pulls/21"},"html":{"href":"https://github.com/citra-emu/uncart/pull/21"},"issue":{"href":"https://api.github.com/repos/citra-emu/uncart/issues/21"},"comments":{"href":"https://api.github.com/repos/citra-emu/uncart/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/uncart/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/uncart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/uncart/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/uncart/statuses/4f1fd1a32bd9738749a620c0bf62e25476ebfff4"}}}}
{"actor":{"display_login":"lioncash"}}