{"action":"created","issue":{"url":"https://api.github.com/repos/apache/nifi/issues/1238","repository_url":"https://api.github.com/repos/apache/nifi","labels_url":"https://api.github.com/repos/apache/nifi/issues/1238/labels{/name}","comments_url":"https://api.github.com/repos/apache/nifi/issues/1238/comments","events_url":"https://api.github.com/repos/apache/nifi/issues/1238/events","html_url":"https://github.com/apache/nifi/pull/1238","id":189937576,"number":1238,"title":"NIFI-3051 Fixed issue serializing commented or empty login-identity-p…","user":{"login":"alopresto","id":798465,"avatar_url":"https://avatars.githubusercontent.com/u/798465?v=3","gravatar_id":"","url":"https://api.github.com/users/alopresto","html_url":"https://github.com/alopresto","followers_url":"https://api.github.com/users/alopresto/followers","following_url":"https://api.github.com/users/alopresto/following{/other_user}","gists_url":"https://api.github.com/users/alopresto/gists{/gist_id}","starred_url":"https://api.github.com/users/alopresto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alopresto/subscriptions","organizations_url":"https://api.github.com/users/alopresto/orgs","repos_url":"https://api.github.com/users/alopresto/repos","events_url":"https://api.github.com/users/alopresto/events{/privacy}","received_events_url":"https://api.github.com/users/alopresto/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-11-17T04:53:23Z","updated_at":"2016-11-18T01:27:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/nifi/pulls/1238","html_url":"https://github.com/apache/nifi/pull/1238","diff_url":"https://github.com/apache/nifi/pull/1238.diff","patch_url":"https://github.com/apache/nifi/pull/1238.patch"},"body":"Thank you for submitting a contribution to Apache NiFi.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [x] Is there a JIRA ticket associated with this PR? Is it referenced \r\n     in the commit message?\r\n\r\n- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen \"-\" character.\r\n\r\n- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?\r\n\r\n- [x] Is your initial contribution a single, squashed commit?\r\n\r\n### For code changes:\r\n- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?\r\n- [x] Have you written or updated unit tests to verify your changes?\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? \r\n- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?\r\n- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?\r\n- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?\r\n\r\n### For documentation related changes:\r\n- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.\r\n\r\n…roviders.xml.\r\n\r\nUpdated and added unit tests. (+1 squashed commit)\r\nSquashed commits:\r\n[b187202] NIFI-3051 - checked in test demonstrating failure to serialize commented ldap-provider section."},"comment":{"url":"https://api.github.com/repos/apache/nifi/issues/comments/261422977","html_url":"https://github.com/apache/nifi/pull/1238#issuecomment-261422977","issue_url":"https://api.github.com/repos/apache/nifi/issues/1238","id":261422977,"user":{"login":"alopresto","id":798465,"avatar_url":"https://avatars.githubusercontent.com/u/798465?v=3","gravatar_id":"","url":"https://api.github.com/users/alopresto","html_url":"https://github.com/alopresto","followers_url":"https://api.github.com/users/alopresto/followers","following_url":"https://api.github.com/users/alopresto/following{/other_user}","gists_url":"https://api.github.com/users/alopresto/gists{/gist_id}","starred_url":"https://api.github.com/users/alopresto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alopresto/subscriptions","organizations_url":"https://api.github.com/users/alopresto/orgs","repos_url":"https://api.github.com/users/alopresto/repos","events_url":"https://api.github.com/users/alopresto/events{/privacy}","received_events_url":"https://api.github.com/users/alopresto/received_events","type":"User","site_admin":false},"created_at":"2016-11-18T01:27:06Z","updated_at":"2016-11-18T01:27:06Z","body":"I talked to @YolandaMDavis -- she will review and give a final yes/no and then I can merge. "}}
{"actor":{"display_login":"alopresto"}}