{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/63168563","id":63168563,"diff_hunk":"@@ -501,4 +501,59 @@ Joomla.editors.instances = Joomla.editors.instances || {};\n \t\tJoomla.submitform( task );\n \t};\n \n+\t/**\n+\t * Add Joomla! loading image layer.\n+\t *\n+\t * @param   string   task         The taks to do (load, show, hide).\n+\t * @param   integer  topPosition  The layer top position.\n+\t *\n+\t * @return  void\n+\t *\n+\t * Used in: /administrator/components/com_installer/views/languages/tmpl/default.php\n+\t *          /installation/template/js/installation.js\n+\t *\n+\t * Since 3.6.0\n+\t */\n+\tJoomla.loadingLayer = function(task, topPosition) {\n+\t\t// Set default values.\n+\t\ttask        = typeof task !== 'undefined' ? task : 'show';\n+\t\ttopPosition = typeof topPosition !== 'undefined' ? topPosition : 0;\n+\n+\t\t// Create the loading layer (hidden by default).\n+\t\tif (task == \"load\")\n+\t\t{\n+\t\t\tvar loadingDiv = document.createElement(\"div\");\n+\n+\t\t\t// The loading layer CSS styles are JS hardcoded so they can be used without adding CSS.\n+\t\t\tloadingDiv.id = \"loading-logo\";\n+\t\t\tloadingDiv.style[\"position\"]              = \"fixed\";\n+\t\t\tloadingDiv.style[\"top\"]                   = (topPosition != 0) ? topPosition + \"px\" : \"0\";\n+\t\t\tloadingDiv.style[\"left\"]                  = \"0\";\n+\t\t\tloadingDiv.style[\"width\"]                 = \"100%\";\n+\t\t\tloadingDiv.style[\"height\"]                = \"100%\";\n+\t\t\tloadingDiv.style[\"background-image\"]      = \"url('../../../media/jui/images/ajax-loader.gif')\";\n+\t\t\tloadingDiv.style[\"background-color\"]      = \"#fff\";\n+\t\t\tloadingDiv.style[\"background-position\"]   = \"center\";\n+\t\t\tloadingDiv.style[\"background-repeat\"]     = \"no-repeat\";\n+\t\t\tloadingDiv.style[\"background-attachment\"] = \"fixed\";\n+\t\t\tloadingDiv.style[\"opacity\"]               = \"0.8\";\n+\t\t\tloadingDiv.style[\"filter\"]                = \"alpha(opacity=80)\";\n+\t\t\tloadingDiv.style[\"overflow\"]              = \"hidden\";\n+\t\t\tloadingDiv.style[\"z-index\"]               = \"10000\";\n+\t\t\tloadingDiv.style[\"display\"]               = \"none\";\n+\n+\t\t\tdocument.body.appendChild(loadingDiv);\n+\t\t}\n+\t\t// Show or hide the layer.\n+\t\telse \n+\t\t{\n+\t\t\tif (!document.getElementById('loading-logo'))\n+\t\t\t{\n+\t\t\t\tJoomla.loadingLayer = (\"load\", topPosition);\n+\t\t\t}\n+\n+\t\t\tdocument.getElementById(\"loading-logo\").style[\"display\"] = (task == \"show\") ? \"block\" : \"none\";","path":"media/system/js/core-uncompressed.js","position":55,"original_position":55,"commit_id":"0ed0f26d3335e5619e904528de37d953cf286c22","original_commit_id":"0ed0f26d3335e5619e904528de37d953cf286c22","user":{"login":"Fedik","id":1568198,"avatar_url":"https://avatars.githubusercontent.com/u/1568198?v=3","gravatar_id":"","url":"https://api.github.com/users/Fedik","html_url":"https://github.com/Fedik","followers_url":"https://api.github.com/users/Fedik/followers","following_url":"https://api.github.com/users/Fedik/following{/other_user}","gists_url":"https://api.github.com/users/Fedik/gists{/gist_id}","starred_url":"https://api.github.com/users/Fedik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fedik/subscriptions","organizations_url":"https://api.github.com/users/Fedik/orgs","repos_url":"https://api.github.com/users/Fedik/repos","events_url":"https://api.github.com/users/Fedik/events{/privacy}","received_events_url":"https://api.github.com/users/Fedik/received_events","type":"User","site_admin":false},"body":"this will fail if \"loading-logo\" does not exists","created_at":"2016-05-13T11:25:56Z","updated_at":"2016-05-13T11:25:56Z","html_url":"https://github.com/joomla/joomla-cms/pull/10396#discussion_r63168563","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10396","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/63168563"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/10396#discussion_r63168563"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/10396"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10396","id":69595606,"html_url":"https://github.com/joomla/joomla-cms/pull/10396","diff_url":"https://github.com/joomla/joomla-cms/pull/10396.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/10396.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10396","number":10396,"state":"open","locked":false,"title":"[Install Languages] Add logo layer on install languages packages","user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"body":"Pull Request for Improvement.\r\n\r\n#### Summary of Changes\r\n\r\nInstallations on backend use a layer with an animated Joomla! logo when installing something.\r\nAll except one. The install languages.\r\n\r\nThis PR adds the logo layer when installing languages too.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/9630530/15179527/48d007c6-1774-11e6-9527-4e855d5576b3.png)\r\n\r\n#### Testing Instructions\r\n\r\n1. Use latest staging, apply patch and clean browser cache\r\n2. Go to Extensions -> Manage -> Install Languages\r\n3. Install one or several languages.<br/>You will now see joomla logo when installing the languages packages.\r\n","created_at":"2016-05-10T23:45:08Z","updated_at":"2016-05-13T11:25:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e3f1a3118057e66b2ce86d145d2f7afd1b6cdaf","assignee":null,"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/12","html_url":"https://github.com/joomla/joomla-cms/milestones/Joomla%203.6.0","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/12/labels","id":1360635,"number":12,"title":"Joomla 3.6.0","description":"","creator":{"login":"roland-d","id":359377,"avatar_url":"https://avatars.githubusercontent.com/u/359377?v=3","gravatar_id":"","url":"https://api.github.com/users/roland-d","html_url":"https://github.com/roland-d","followers_url":"https://api.github.com/users/roland-d/followers","following_url":"https://api.github.com/users/roland-d/following{/other_user}","gists_url":"https://api.github.com/users/roland-d/gists{/gist_id}","starred_url":"https://api.github.com/users/roland-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roland-d/subscriptions","organizations_url":"https://api.github.com/users/roland-d/orgs","repos_url":"https://api.github.com/users/roland-d/repos","events_url":"https://api.github.com/users/roland-d/events{/privacy}","received_events_url":"https://api.github.com/users/roland-d/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":486,"state":"open","created_at":"2015-10-17T07:57:38Z","updated_at":"2016-05-13T08:01:47Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10396/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10396/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10396/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/0ed0f26d3335e5619e904528de37d953cf286c22","head":{"label":"andrepereiradasilva:logo-on-install-languages","ref":"logo-on-install-languages","sha":"0ed0f26d3335e5619e904528de37d953cf286c22","user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"repo":{"id":46170295,"name":"joomla-cms","full_name":"andrepereiradasilva/joomla-cms","owner":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrepereiradasilva/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms","forks_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/forks","keys_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/teams","hooks_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/events","assignees_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/tags","blobs_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/subscription","commits_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/merges","archive_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/downloads","issues_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/deployments","created_at":"2015-11-14T10:22:32Z","updated_at":"2016-03-03T00:12:42Z","pushed_at":"2016-05-13T10:41:34Z","git_url":"git://github.com/andrepereiradasilva/joomla-cms.git","ssh_url":"git@github.com:andrepereiradasilva/joomla-cms.git","clone_url":"https://github.com/andrepereiradasilva/joomla-cms.git","svn_url":"https://github.com/andrepereiradasilva/joomla-cms","homepage":"https://www.joomla.org","size":148580,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"268efcb92bbd6140ce5dd9eda3b5498a61d9e654","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-05-12T15:16:29Z","pushed_at":"2016-05-13T10:41:36Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":277223,"stargazers_count":2008,"watchers_count":2008,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2160,"mirror_url":null,"open_issues_count":392,"forks":2160,"open_issues":392,"watchers":2008,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/10396"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/10396"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/10396"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/10396/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/10396/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/10396/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/0ed0f26d3335e5619e904528de37d953cf286c22"}}}}