{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments/91428207","pull_request_review_id":11936434,"id":91428207,"diff_hunk":"@@ -110,7 +110,6 @@ func createCertificate(commonName string, caCertificate *x509.Certificate, caPri\n \t\ttemplate.KeyUsage |= x509.KeyUsageCertSign\n \t\ttemplate.IsCA = isCA\n \t} else if isServer {\n-\t\textraFQDNs = append(extraFQDNs, FQDN)","path":"pkg/acsengine/pki.go","position":4,"original_position":4,"commit_id":"50a4ab25df5dc34bc08759bc35f4a4fb8d2b5d48","original_commit_id":"50a4ab25df5dc34bc08759bc35f4a4fb8d2b5d48","user":{"login":"anhowe","id":12574506,"avatar_url":"https://avatars.githubusercontent.com/u/12574506?v=3","gravatar_id":"","url":"https://api.github.com/users/anhowe","html_url":"https://github.com/anhowe","followers_url":"https://api.github.com/users/anhowe/followers","following_url":"https://api.github.com/users/anhowe/following{/other_user}","gists_url":"https://api.github.com/users/anhowe/gists{/gist_id}","starred_url":"https://api.github.com/users/anhowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anhowe/subscriptions","organizations_url":"https://api.github.com/users/anhowe/orgs","repos_url":"https://api.github.com/users/anhowe/repos","events_url":"https://api.github.com/users/anhowe/events{/privacy}","received_events_url":"https://api.github.com/users/anhowe/received_events","type":"User","site_admin":false},"body":"Implement either of two recommendations:\r\n1. keep your change, but then remove FQDN through full call stack, or\r\n2. undo your change, and in setDefaultCerts remove the \"*\", and send in element 0 as the FQDN and [1:] as the FQDNs","created_at":"2016-12-08T01:50:55Z","updated_at":"2016-12-08T01:52:06Z","html_url":"https://github.com/Azure/acs-engine/pull/134#discussion_r91428207","pull_request_url":"https://api.github.com/repos/Azure/acs-engine/pulls/134","_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments/91428207"},"html":{"href":"https://github.com/Azure/acs-engine/pull/134#discussion_r91428207"},"pull_request":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/134"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/134","id":96990129,"html_url":"https://github.com/Azure/acs-engine/pull/134","diff_url":"https://github.com/Azure/acs-engine/pull/134.diff","patch_url":"https://github.com/Azure/acs-engine/pull/134.patch","issue_url":"https://api.github.com/repos/Azure/acs-engine/issues/134","number":134,"state":"open","locked":false,"title":"pki: remove wildcard from subject alt names","user":{"login":"gabrtv","id":231123,"avatar_url":"https://avatars.githubusercontent.com/u/231123?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrtv","html_url":"https://github.com/gabrtv","followers_url":"https://api.github.com/users/gabrtv/followers","following_url":"https://api.github.com/users/gabrtv/following{/other_user}","gists_url":"https://api.github.com/users/gabrtv/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrtv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrtv/subscriptions","organizations_url":"https://api.github.com/users/gabrtv/orgs","repos_url":"https://api.github.com/users/gabrtv/repos","events_url":"https://api.github.com/users/gabrtv/events{/privacy}","received_events_url":"https://api.github.com/users/gabrtv/received_events","type":"User","site_admin":false},"body":"This PR is designed to remove the wildcard FQDN from the end of the subjectAltNames in the APIServer certificate.  I was tempted to change some of the calling code to make the intent more clear, but opted for the 1-line change instead.\r\n\r\nThis PR resolves the following `pyopenssl` error:\r\n\r\n```console\r\nWARNING:requests.packages.urllib3.contrib.pyopenssl:A problem was encountered with the certificate that prevented urllib3 from finding the SubjectAlternativeName field. This can affect certificate validation. The error was Codepoint U+002A at position 1 of '*' not allowed\r\n/usr/local/lib/python3.5/dist-packages/requests/packages/urllib3/connection.py:337: SubjectAltNameWarning: Certificate for 10.0.0.1 has no `subjectAltName`, falling back to check for a `commonName` for now. This feature is being removed by major browsers and deprecated by RFC 2818. (See https://github.com/shazow/urllib3/issues/497 for details.)\r\n  SubjectAltNameWarning\r\nERROR:requests.packages.urllib3.connection:Certificate did not match expected hostname: 10.0.0.1. Certificate: {'subject': ((('commonName', 'apiserver'),),), 'subjectAltName': []}\r\nERROR There was a problem retrieving data from the Kubernetes API server. URL: https://10.0.0.1:443/api/v1/namespaces/test-288243432, params: {}\r\nERROR:scheduler:There was a problem retrieving data from the Kubernetes API server. URL: https://10.0.0.1:443/api/v1/namespaces/test-288243432, params: {}\r\n```","created_at":"2016-12-07T19:26:01Z","updated_at":"2016-12-08T01:52:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1841f58728799ffb0d213d34204d58c8ed5ca95","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/acs-engine/pulls/134/commits","review_comments_url":"https://api.github.com/repos/Azure/acs-engine/pulls/134/comments","review_comment_url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/acs-engine/issues/134/comments","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/50a4ab25df5dc34bc08759bc35f4a4fb8d2b5d48","head":{"label":"gabrtv:remove-wildcard","ref":"remove-wildcard","sha":"50a4ab25df5dc34bc08759bc35f4a4fb8d2b5d48","user":{"login":"gabrtv","id":231123,"avatar_url":"https://avatars.githubusercontent.com/u/231123?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrtv","html_url":"https://github.com/gabrtv","followers_url":"https://api.github.com/users/gabrtv/followers","following_url":"https://api.github.com/users/gabrtv/following{/other_user}","gists_url":"https://api.github.com/users/gabrtv/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrtv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrtv/subscriptions","organizations_url":"https://api.github.com/users/gabrtv/orgs","repos_url":"https://api.github.com/users/gabrtv/repos","events_url":"https://api.github.com/users/gabrtv/events{/privacy}","received_events_url":"https://api.github.com/users/gabrtv/received_events","type":"User","site_admin":false},"repo":{"id":75867989,"name":"acs-engine","full_name":"gabrtv/acs-engine","owner":{"login":"gabrtv","id":231123,"avatar_url":"https://avatars.githubusercontent.com/u/231123?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrtv","html_url":"https://github.com/gabrtv","followers_url":"https://api.github.com/users/gabrtv/followers","following_url":"https://api.github.com/users/gabrtv/following{/other_user}","gists_url":"https://api.github.com/users/gabrtv/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrtv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrtv/subscriptions","organizations_url":"https://api.github.com/users/gabrtv/orgs","repos_url":"https://api.github.com/users/gabrtv/repos","events_url":"https://api.github.com/users/gabrtv/events{/privacy}","received_events_url":"https://api.github.com/users/gabrtv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabrtv/acs-engine","description":"Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.","fork":true,"url":"https://api.github.com/repos/gabrtv/acs-engine","forks_url":"https://api.github.com/repos/gabrtv/acs-engine/forks","keys_url":"https://api.github.com/repos/gabrtv/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabrtv/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabrtv/acs-engine/teams","hooks_url":"https://api.github.com/repos/gabrtv/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/gabrtv/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/gabrtv/acs-engine/events","assignees_url":"https://api.github.com/repos/gabrtv/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/gabrtv/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/gabrtv/acs-engine/tags","blobs_url":"https://api.github.com/repos/gabrtv/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabrtv/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabrtv/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabrtv/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabrtv/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/gabrtv/acs-engine/languages","stargazers_url":"https://api.github.com/repos/gabrtv/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/gabrtv/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/gabrtv/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/gabrtv/acs-engine/subscription","commits_url":"https://api.github.com/repos/gabrtv/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabrtv/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabrtv/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabrtv/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabrtv/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/gabrtv/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabrtv/acs-engine/merges","archive_url":"https://api.github.com/repos/gabrtv/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabrtv/acs-engine/downloads","issues_url":"https://api.github.com/repos/gabrtv/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/gabrtv/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/gabrtv/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/gabrtv/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabrtv/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/gabrtv/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/gabrtv/acs-engine/deployments","created_at":"2016-12-07T19:19:23Z","updated_at":"2016-12-07T19:19:24Z","pushed_at":"2016-12-07T19:20:37Z","git_url":"git://github.com/gabrtv/acs-engine.git","ssh_url":"git@github.com:gabrtv/acs-engine.git","clone_url":"https://github.com/gabrtv/acs-engine.git","svn_url":"https://github.com/gabrtv/acs-engine","homepage":"","size":4294,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"4fa61af3df69ad2601d1c2e672a4c9c8d18393dd","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":66011370,"name":"acs-engine","full_name":"Azure/acs-engine","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/acs-engine","description":"Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.","fork":false,"url":"https://api.github.com/repos/Azure/acs-engine","forks_url":"https://api.github.com/repos/Azure/acs-engine/forks","keys_url":"https://api.github.com/repos/Azure/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/acs-engine/teams","hooks_url":"https://api.github.com/repos/Azure/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/Azure/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/acs-engine/events","assignees_url":"https://api.github.com/repos/Azure/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/acs-engine/tags","blobs_url":"https://api.github.com/repos/Azure/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/acs-engine/languages","stargazers_url":"https://api.github.com/repos/Azure/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/Azure/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/Azure/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/Azure/acs-engine/subscription","commits_url":"https://api.github.com/repos/Azure/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/acs-engine/merges","archive_url":"https://api.github.com/repos/Azure/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/acs-engine/downloads","issues_url":"https://api.github.com/repos/Azure/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/Azure/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/acs-engine/deployments","created_at":"2016-08-18T16:05:16Z","updated_at":"2016-12-07T09:25:52Z","pushed_at":"2016-12-08T01:36:45Z","git_url":"git://github.com/Azure/acs-engine.git","ssh_url":"git@github.com:Azure/acs-engine.git","clone_url":"https://github.com/Azure/acs-engine.git","svn_url":"https://github.com/Azure/acs-engine","homepage":"","size":4764,"stargazers_count":155,"watchers_count":155,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":41,"forks":39,"open_issues":41,"watchers":155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/134"},"html":{"href":"https://github.com/Azure/acs-engine/pull/134"},"issue":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/134"},"comments":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/acs-engine/statuses/50a4ab25df5dc34bc08759bc35f4a4fb8d2b5d48"}}}}
{"actor":{"display_login":"anhowe"}}