{"action":"created","comment":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/comments/76983955","id":76983955,"diff_hunk":"@@ -12,519 +12,604 @@\n  * <http://creativecommons.org/publicdomain/zero/1.0/>.\n  */\n \n-// [**libgit2**][lg] is a portable, pure C implementation of the Git core\n-// methods provided as a re-entrant linkable library with a solid API,\n-// allowing you to write native speed custom Git applications in any\n-// language which supports C bindings.\n-//\n-// This file is an example of using that API in a real, compilable C file.\n-// As the API is updated, this file will be updated to demonstrate the new\n-// functionality.\n-//\n-// If you're trying to write something in C using [libgit2][lg], you should\n-// also check out the generated [API documentation][ap]. We try to link to\n-// the relevant sections of the API docs in each section in this file.\n-//\n-// **libgit2** (for the most part) only implements the core plumbing\n-// functions, not really the higher level porcelain stuff. For a primer on\n-// Git Internals that you will need to know to work with Git at this level,\n-// check out [Chapter 10][pg] of the Pro Git book.\n-//\n-// [lg]: http://libgit2.github.com\n-// [ap]: http://libgit2.github.com/libgit2\n-// [pg]: https://git-scm.com/book/en/v2/Git-Internals-Plumbing-and-Porcelain\n-\n-// ### Includes\n-\n-// Including the `git2.h` header will include all the other libgit2 headers\n-// that you need.  It should be the only thing you need to include in order\n-// to compile properly and get all the libgit2 API.\n+/* [**libgit2**][lg] is a portable, pure C implementation of the Git core","path":"examples/general.c","position":31,"original_position":31,"commit_id":"b1162d2a20de4d0f4e3259050fc174a4115e4dc1","original_commit_id":"b1162d2a20de4d0f4e3259050fc174a4115e4dc1","user":{"login":"carlosmn","id":335443,"avatar_url":"https://avatars.githubusercontent.com/u/335443?v=3","gravatar_id":"","url":"https://api.github.com/users/carlosmn","html_url":"https://github.com/carlosmn","followers_url":"https://api.github.com/users/carlosmn/followers","following_url":"https://api.github.com/users/carlosmn/following{/other_user}","gists_url":"https://api.github.com/users/carlosmn/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosmn/subscriptions","organizations_url":"https://api.github.com/users/carlosmn/orgs","repos_url":"https://api.github.com/users/carlosmn/repos","events_url":"https://api.github.com/users/carlosmn/events{/privacy}","received_events_url":"https://api.github.com/users/carlosmn/received_events","type":"User","site_admin":true},"body":"This would hide this text from the docco output. We need C++ comments or `/**` here for it to show.","created_at":"2016-08-31T13:11:16Z","updated_at":"2016-08-31T13:11:16Z","html_url":"https://github.com/libgit2/libgit2/pull/3897#discussion_r76983955","pull_request_url":"https://api.github.com/repos/libgit2/libgit2/pulls/3897","_links":{"self":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/comments/76983955"},"html":{"href":"https://github.com/libgit2/libgit2/pull/3897#discussion_r76983955"},"pull_request":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3897"}}},"pull_request":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/3897","id":81437651,"html_url":"https://github.com/libgit2/libgit2/pull/3897","diff_url":"https://github.com/libgit2/libgit2/pull/3897.diff","patch_url":"https://github.com/libgit2/libgit2/pull/3897.patch","issue_url":"https://api.github.com/repos/libgit2/libgit2/issues/3897","number":3897,"state":"open","locked":false,"title":"Squelch example warnings, enable CI","user":{"login":"pks-t","id":4056630,"avatar_url":"https://avatars.githubusercontent.com/u/4056630?v=3","gravatar_id":"","url":"https://api.github.com/users/pks-t","html_url":"https://github.com/pks-t","followers_url":"https://api.github.com/users/pks-t/followers","following_url":"https://api.github.com/users/pks-t/following{/other_user}","gists_url":"https://api.github.com/users/pks-t/gists{/gist_id}","starred_url":"https://api.github.com/users/pks-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pks-t/subscriptions","organizations_url":"https://api.github.com/users/pks-t/orgs","repos_url":"https://api.github.com/users/pks-t/repos","events_url":"https://api.github.com/users/pks-t/events{/privacy}","received_events_url":"https://api.github.com/users/pks-t/received_events","type":"User","site_admin":false},"body":"Recently, I wanted to build our examples and was hugely annoyed by all those warnings that were spilled left and right. So I cleaned up our tests, particularly the `examples/general.c` one, so that no warnings get thrown anymore.\r\n\r\nFurthermore, I've changed CI scripts to build all tests to catch errors early on. I know that the examples aren't of huge importance, but considering they might be the first contact point with libgit2 for new developers, I'd say they should be reasonably clean and, as a bare minimum, compile. So that's why I think it is only sensible to break our CI builds when changes inside libgit2 break our examples.","created_at":"2016-08-16T09:08:48Z","updated_at":"2016-08-31T13:11:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c541bd45ae5708f398d7a92b4cad76b6001e1e9e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/libgit2/libgit2/pulls/3897/commits","review_comments_url":"https://api.github.com/repos/libgit2/libgit2/pulls/3897/comments","review_comment_url":"https://api.github.com/repos/libgit2/libgit2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libgit2/libgit2/issues/3897/comments","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/b1162d2a20de4d0f4e3259050fc174a4115e4dc1","head":{"label":"pks-t:pks/squelch-example-warnings","ref":"pks/squelch-example-warnings","sha":"b1162d2a20de4d0f4e3259050fc174a4115e4dc1","user":{"login":"pks-t","id":4056630,"avatar_url":"https://avatars.githubusercontent.com/u/4056630?v=3","gravatar_id":"","url":"https://api.github.com/users/pks-t","html_url":"https://github.com/pks-t","followers_url":"https://api.github.com/users/pks-t/followers","following_url":"https://api.github.com/users/pks-t/following{/other_user}","gists_url":"https://api.github.com/users/pks-t/gists{/gist_id}","starred_url":"https://api.github.com/users/pks-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pks-t/subscriptions","organizations_url":"https://api.github.com/users/pks-t/orgs","repos_url":"https://api.github.com/users/pks-t/repos","events_url":"https://api.github.com/users/pks-t/events{/privacy}","received_events_url":"https://api.github.com/users/pks-t/received_events","type":"User","site_admin":false},"repo":{"id":29849449,"name":"libgit2","full_name":"pks-t/libgit2","owner":{"login":"pks-t","id":4056630,"avatar_url":"https://avatars.githubusercontent.com/u/4056630?v=3","gravatar_id":"","url":"https://api.github.com/users/pks-t","html_url":"https://github.com/pks-t","followers_url":"https://api.github.com/users/pks-t/followers","following_url":"https://api.github.com/users/pks-t/following{/other_user}","gists_url":"https://api.github.com/users/pks-t/gists{/gist_id}","starred_url":"https://api.github.com/users/pks-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pks-t/subscriptions","organizations_url":"https://api.github.com/users/pks-t/orgs","repos_url":"https://api.github.com/users/pks-t/repos","events_url":"https://api.github.com/users/pks-t/events{/privacy}","received_events_url":"https://api.github.com/users/pks-t/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pks-t/libgit2","description":"The Library","fork":true,"url":"https://api.github.com/repos/pks-t/libgit2","forks_url":"https://api.github.com/repos/pks-t/libgit2/forks","keys_url":"https://api.github.com/repos/pks-t/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pks-t/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pks-t/libgit2/teams","hooks_url":"https://api.github.com/repos/pks-t/libgit2/hooks","issue_events_url":"https://api.github.com/repos/pks-t/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/pks-t/libgit2/events","assignees_url":"https://api.github.com/repos/pks-t/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/pks-t/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/pks-t/libgit2/tags","blobs_url":"https://api.github.com/repos/pks-t/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pks-t/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pks-t/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/pks-t/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pks-t/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/pks-t/libgit2/languages","stargazers_url":"https://api.github.com/repos/pks-t/libgit2/stargazers","contributors_url":"https://api.github.com/repos/pks-t/libgit2/contributors","subscribers_url":"https://api.github.com/repos/pks-t/libgit2/subscribers","subscription_url":"https://api.github.com/repos/pks-t/libgit2/subscription","commits_url":"https://api.github.com/repos/pks-t/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/pks-t/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/pks-t/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/pks-t/libgit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/pks-t/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/pks-t/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pks-t/libgit2/merges","archive_url":"https://api.github.com/repos/pks-t/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pks-t/libgit2/downloads","issues_url":"https://api.github.com/repos/pks-t/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/pks-t/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/pks-t/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/pks-t/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pks-t/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/pks-t/libgit2/releases{/id}","deployments_url":"https://api.github.com/repos/pks-t/libgit2/deployments","created_at":"2015-01-26T07:12:59Z","updated_at":"2016-08-04T12:14:54Z","pushed_at":"2016-08-30T06:02:20Z","git_url":"git://github.com/pks-t/libgit2.git","ssh_url":"git@github.com:pks-t/libgit2.git","clone_url":"https://github.com/pks-t/libgit2.git","svn_url":"https://github.com/pks-t/libgit2","homepage":"http://libgit2.github.com","size":21435,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"libgit2:master","ref":"master","sha":"26a8617d96ba96875304d56a7ce698a85e559c43","user":{"login":"libgit2","id":394745,"avatar_url":"https://avatars.githubusercontent.com/u/394745?v=3","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"repo":{"id":901662,"name":"libgit2","full_name":"libgit2/libgit2","owner":{"login":"libgit2","id":394745,"avatar_url":"https://avatars.githubusercontent.com/u/394745?v=3","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libgit2/libgit2","description":"The Library","fork":false,"url":"https://api.github.com/repos/libgit2/libgit2","forks_url":"https://api.github.com/repos/libgit2/libgit2/forks","keys_url":"https://api.github.com/repos/libgit2/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libgit2/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libgit2/libgit2/teams","hooks_url":"https://api.github.com/repos/libgit2/libgit2/hooks","issue_events_url":"https://api.github.com/repos/libgit2/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/libgit2/libgit2/events","assignees_url":"https://api.github.com/repos/libgit2/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/libgit2/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/libgit2/libgit2/tags","blobs_url":"https://api.github.com/repos/libgit2/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libgit2/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libgit2/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/libgit2/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/libgit2/libgit2/languages","stargazers_url":"https://api.github.com/repos/libgit2/libgit2/stargazers","contributors_url":"https://api.github.com/repos/libgit2/libgit2/contributors","subscribers_url":"https://api.github.com/repos/libgit2/libgit2/subscribers","subscription_url":"https://api.github.com/repos/libgit2/libgit2/subscription","commits_url":"https://api.github.com/repos/libgit2/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/libgit2/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/libgit2/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/libgit2/libgit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/libgit2/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/libgit2/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libgit2/libgit2/merges","archive_url":"https://api.github.com/repos/libgit2/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libgit2/libgit2/downloads","issues_url":"https://api.github.com/repos/libgit2/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/libgit2/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/libgit2/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/libgit2/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libgit2/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/libgit2/libgit2/releases{/id}","deployments_url":"https://api.github.com/repos/libgit2/libgit2/deployments","created_at":"2010-09-10T16:17:48Z","updated_at":"2016-08-31T11:08:17Z","pushed_at":"2016-08-31T13:06:23Z","git_url":"git://github.com/libgit2/libgit2.git","ssh_url":"git@github.com:libgit2/libgit2.git","clone_url":"https://github.com/libgit2/libgit2.git","svn_url":"https://github.com/libgit2/libgit2","homepage":"http://libgit2.github.com","size":66221,"stargazers_count":5752,"watchers_count":5752,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1413,"mirror_url":null,"open_issues_count":173,"forks":1413,"open_issues":173,"watchers":5752,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3897"},"html":{"href":"https://github.com/libgit2/libgit2/pull/3897"},"issue":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/3897"},"comments":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/3897/comments"},"review_comments":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3897/comments"},"review_comment":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3897/commits"},"statuses":{"href":"https://api.github.com/repos/libgit2/libgit2/statuses/b1162d2a20de4d0f4e3259050fc174a4115e4dc1"}}}}
{"actor":{"display_login":"carlosmn"}}