{"action":"created","comment":{"url":"https://api.github.com/repos/akretion/account-financial-reporting/pulls/comments/65536209","id":65536209,"diff_hunk":"@@ -812,11 +815,12 @@ class IntrastatProductComputationLine(models.Model):\n         'res.country', string='Country of Origin of the Product',\n         help=\"Country of origin of the product i.e. product 'made in ____'\")\n \n-    @api.one\n+    @api.multi\n     @api.depends('transport_id')\n     def _check_validity(self):\n         \"\"\" TO DO: logic based upon fields \"\"\"\n-        self.valid = True\n+        for this in self:\n+            this.valid = True","path":"intrastat_product/models/intrastat_product_declaration.py","position":75,"original_position":75,"commit_id":"0943c5daf68a5a4cf95af8dca5ce2e2d189c819d","original_commit_id":"0943c5daf68a5a4cf95af8dca5ce2e2d189c819d","user":{"login":"alexis-via","id":1157917,"avatar_url":"https://avatars.githubusercontent.com/u/1157917?v=3","gravatar_id":"","url":"https://api.github.com/users/alexis-via","html_url":"https://github.com/alexis-via","followers_url":"https://api.github.com/users/alexis-via/followers","following_url":"https://api.github.com/users/alexis-via/following{/other_user}","gists_url":"https://api.github.com/users/alexis-via/gists{/gist_id}","starred_url":"https://api.github.com/users/alexis-via/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexis-via/subscriptions","organizations_url":"https://api.github.com/users/alexis-via/orgs","repos_url":"https://api.github.com/users/alexis-via/repos","events_url":"https://api.github.com/users/alexis-via/events{/privacy}","received_events_url":"https://api.github.com/users/alexis-via/received_events","type":"User","site_admin":false},"body":"We can avoid the loop, no ?","created_at":"2016-06-02T13:14:11Z","updated_at":"2016-06-02T13:14:11Z","html_url":"https://github.com/akretion/account-financial-reporting/pull/12#discussion_r65536209","pull_request_url":"https://api.github.com/repos/akretion/account-financial-reporting/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/akretion/account-financial-reporting/pulls/comments/65536209"},"html":{"href":"https://github.com/akretion/account-financial-reporting/pull/12#discussion_r65536209"},"pull_request":{"href":"https://api.github.com/repos/akretion/account-financial-reporting/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/akretion/account-financial-reporting/pulls/12","id":71886635,"html_url":"https://github.com/akretion/account-financial-reporting/pull/12","diff_url":"https://github.com/akretion/account-financial-reporting/pull/12.diff","patch_url":"https://github.com/akretion/account-financial-reporting/pull/12.patch","issue_url":"https://api.github.com/repos/akretion/account-financial-reporting/issues/12","number":12,"state":"open","locked":false,"title":"[FIX] this week's ci errors","user":{"login":"hbrunn","id":2563186,"avatar_url":"https://avatars.githubusercontent.com/u/2563186?v=3","gravatar_id":"","url":"https://api.github.com/users/hbrunn","html_url":"https://github.com/hbrunn","followers_url":"https://api.github.com/users/hbrunn/followers","following_url":"https://api.github.com/users/hbrunn/following{/other_user}","gists_url":"https://api.github.com/users/hbrunn/gists{/gist_id}","starred_url":"https://api.github.com/users/hbrunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbrunn/subscriptions","organizations_url":"https://api.github.com/users/hbrunn/orgs","repos_url":"https://api.github.com/users/hbrunn/repos","events_url":"https://api.github.com/users/hbrunn/events{/privacy}","received_events_url":"https://api.github.com/users/hbrunn/received_events","type":"User","site_admin":false},"body":"This is meant to fix the problems runbot sees with the intrastat branch currently","created_at":"2016-05-30T11:06:02Z","updated_at":"2016-06-02T13:14:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5604dd071fa839c0899f0262d14cc41df86b417","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/akretion/account-financial-reporting/pulls/12/commits","review_comments_url":"https://api.github.com/repos/akretion/account-financial-reporting/pulls/12/comments","review_comment_url":"https://api.github.com/repos/akretion/account-financial-reporting/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akretion/account-financial-reporting/issues/12/comments","statuses_url":"https://api.github.com/repos/akretion/account-financial-reporting/statuses/0943c5daf68a5a4cf95af8dca5ce2e2d189c819d","head":{"label":"hbrunn:8.0-add-intrastat-v3","ref":"8.0-add-intrastat-v3","sha":"0943c5daf68a5a4cf95af8dca5ce2e2d189c819d","user":{"login":"hbrunn","id":2563186,"avatar_url":"https://avatars.githubusercontent.com/u/2563186?v=3","gravatar_id":"","url":"https://api.github.com/users/hbrunn","html_url":"https://github.com/hbrunn","followers_url":"https://api.github.com/users/hbrunn/followers","following_url":"https://api.github.com/users/hbrunn/following{/other_user}","gists_url":"https://api.github.com/users/hbrunn/gists{/gist_id}","starred_url":"https://api.github.com/users/hbrunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbrunn/subscriptions","organizations_url":"https://api.github.com/users/hbrunn/orgs","repos_url":"https://api.github.com/users/hbrunn/repos","events_url":"https://api.github.com/users/hbrunn/events{/privacy}","received_events_url":"https://api.github.com/users/hbrunn/received_events","type":"User","site_admin":false},"repo":{"id":36067484,"name":"account-financial-reporting","full_name":"hbrunn/account-financial-reporting","owner":{"login":"hbrunn","id":2563186,"avatar_url":"https://avatars.githubusercontent.com/u/2563186?v=3","gravatar_id":"","url":"https://api.github.com/users/hbrunn","html_url":"https://github.com/hbrunn","followers_url":"https://api.github.com/users/hbrunn/followers","following_url":"https://api.github.com/users/hbrunn/following{/other_user}","gists_url":"https://api.github.com/users/hbrunn/gists{/gist_id}","starred_url":"https://api.github.com/users/hbrunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbrunn/subscriptions","organizations_url":"https://api.github.com/users/hbrunn/orgs","repos_url":"https://api.github.com/users/hbrunn/repos","events_url":"https://api.github.com/users/hbrunn/events{/privacy}","received_events_url":"https://api.github.com/users/hbrunn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hbrunn/account-financial-reporting","description":"Financial reports for Odoo","fork":true,"url":"https://api.github.com/repos/hbrunn/account-financial-reporting","forks_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/forks","keys_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/teams","hooks_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/hooks","issue_events_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/issues/events{/number}","events_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/events","assignees_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/assignees{/user}","branches_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/branches{/branch}","tags_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/tags","blobs_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/git/refs{/sha}","trees_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/statuses/{sha}","languages_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/languages","stargazers_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/stargazers","contributors_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/contributors","subscribers_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/subscribers","subscription_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/subscription","commits_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/commits{/sha}","git_commits_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/git/commits{/sha}","comments_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/comments{/number}","issue_comment_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/issues/comments{/number}","contents_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/contents/{+path}","compare_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/merges","archive_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/downloads","issues_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/issues{/number}","pulls_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/pulls{/number}","milestones_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/milestones{/number}","notifications_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/labels{/name}","releases_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/releases{/id}","deployments_url":"https://api.github.com/repos/hbrunn/account-financial-reporting/deployments","created_at":"2015-05-22T10:53:11Z","updated_at":"2015-05-22T10:53:12Z","pushed_at":"2016-05-30T11:03:22Z","git_url":"git://github.com/hbrunn/account-financial-reporting.git","ssh_url":"git@github.com:hbrunn/account-financial-reporting.git","clone_url":"https://github.com/hbrunn/account-financial-reporting.git","svn_url":"https://github.com/hbrunn/account-financial-reporting","homepage":"http://community.odoo.com","size":4791,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"8.0"}},"base":{"label":"akretion:8.0-add-intrastat-v3","ref":"8.0-add-intrastat-v3","sha":"fa492845501f80c2ada6483f26c72d023f172786","user":{"login":"akretion","id":1853423,"avatar_url":"https://avatars.githubusercontent.com/u/1853423?v=3","gravatar_id":"","url":"https://api.github.com/users/akretion","html_url":"https://github.com/akretion","followers_url":"https://api.github.com/users/akretion/followers","following_url":"https://api.github.com/users/akretion/following{/other_user}","gists_url":"https://api.github.com/users/akretion/gists{/gist_id}","starred_url":"https://api.github.com/users/akretion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akretion/subscriptions","organizations_url":"https://api.github.com/users/akretion/orgs","repos_url":"https://api.github.com/users/akretion/repos","events_url":"https://api.github.com/users/akretion/events{/privacy}","received_events_url":"https://api.github.com/users/akretion/received_events","type":"Organization","site_admin":false},"repo":{"id":36252194,"name":"account-financial-reporting","full_name":"akretion/account-financial-reporting","owner":{"login":"akretion","id":1853423,"avatar_url":"https://avatars.githubusercontent.com/u/1853423?v=3","gravatar_id":"","url":"https://api.github.com/users/akretion","html_url":"https://github.com/akretion","followers_url":"https://api.github.com/users/akretion/followers","following_url":"https://api.github.com/users/akretion/following{/other_user}","gists_url":"https://api.github.com/users/akretion/gists{/gist_id}","starred_url":"https://api.github.com/users/akretion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akretion/subscriptions","organizations_url":"https://api.github.com/users/akretion/orgs","repos_url":"https://api.github.com/users/akretion/repos","events_url":"https://api.github.com/users/akretion/events{/privacy}","received_events_url":"https://api.github.com/users/akretion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akretion/account-financial-reporting","description":"Financial reports for Odoo","fork":true,"url":"https://api.github.com/repos/akretion/account-financial-reporting","forks_url":"https://api.github.com/repos/akretion/account-financial-reporting/forks","keys_url":"https://api.github.com/repos/akretion/account-financial-reporting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akretion/account-financial-reporting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akretion/account-financial-reporting/teams","hooks_url":"https://api.github.com/repos/akretion/account-financial-reporting/hooks","issue_events_url":"https://api.github.com/repos/akretion/account-financial-reporting/issues/events{/number}","events_url":"https://api.github.com/repos/akretion/account-financial-reporting/events","assignees_url":"https://api.github.com/repos/akretion/account-financial-reporting/assignees{/user}","branches_url":"https://api.github.com/repos/akretion/account-financial-reporting/branches{/branch}","tags_url":"https://api.github.com/repos/akretion/account-financial-reporting/tags","blobs_url":"https://api.github.com/repos/akretion/account-financial-reporting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akretion/account-financial-reporting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akretion/account-financial-reporting/git/refs{/sha}","trees_url":"https://api.github.com/repos/akretion/account-financial-reporting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akretion/account-financial-reporting/statuses/{sha}","languages_url":"https://api.github.com/repos/akretion/account-financial-reporting/languages","stargazers_url":"https://api.github.com/repos/akretion/account-financial-reporting/stargazers","contributors_url":"https://api.github.com/repos/akretion/account-financial-reporting/contributors","subscribers_url":"https://api.github.com/repos/akretion/account-financial-reporting/subscribers","subscription_url":"https://api.github.com/repos/akretion/account-financial-reporting/subscription","commits_url":"https://api.github.com/repos/akretion/account-financial-reporting/commits{/sha}","git_commits_url":"https://api.github.com/repos/akretion/account-financial-reporting/git/commits{/sha}","comments_url":"https://api.github.com/repos/akretion/account-financial-reporting/comments{/number}","issue_comment_url":"https://api.github.com/repos/akretion/account-financial-reporting/issues/comments{/number}","contents_url":"https://api.github.com/repos/akretion/account-financial-reporting/contents/{+path}","compare_url":"https://api.github.com/repos/akretion/account-financial-reporting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akretion/account-financial-reporting/merges","archive_url":"https://api.github.com/repos/akretion/account-financial-reporting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akretion/account-financial-reporting/downloads","issues_url":"https://api.github.com/repos/akretion/account-financial-reporting/issues{/number}","pulls_url":"https://api.github.com/repos/akretion/account-financial-reporting/pulls{/number}","milestones_url":"https://api.github.com/repos/akretion/account-financial-reporting/milestones{/number}","notifications_url":"https://api.github.com/repos/akretion/account-financial-reporting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akretion/account-financial-reporting/labels{/name}","releases_url":"https://api.github.com/repos/akretion/account-financial-reporting/releases{/id}","deployments_url":"https://api.github.com/repos/akretion/account-financial-reporting/deployments","created_at":"2015-05-25T20:09:24Z","updated_at":"2016-05-30T19:54:31Z","pushed_at":"2016-05-30T11:06:02Z","git_url":"git://github.com/akretion/account-financial-reporting.git","ssh_url":"git@github.com:akretion/account-financial-reporting.git","clone_url":"https://github.com/akretion/account-financial-reporting.git","svn_url":"https://github.com/akretion/account-financial-reporting","homepage":"http://community.odoo.com","size":4976,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"8.0"}},"_links":{"self":{"href":"https://api.github.com/repos/akretion/account-financial-reporting/pulls/12"},"html":{"href":"https://github.com/akretion/account-financial-reporting/pull/12"},"issue":{"href":"https://api.github.com/repos/akretion/account-financial-reporting/issues/12"},"comments":{"href":"https://api.github.com/repos/akretion/account-financial-reporting/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/akretion/account-financial-reporting/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/akretion/account-financial-reporting/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akretion/account-financial-reporting/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/akretion/account-financial-reporting/statuses/0943c5daf68a5a4cf95af8dca5ce2e2d189c819d"}}}}
{"actor":{"display_login":"alexis-via"}}