{"action":"created","comment":{"url":"https://api.github.com/repos/pilight/pilight/pulls/comments/91853774","pull_request_review_id":12365034,"id":91853774,"diff_hunk":"@@ -77,7 +77,7 @@ static void parseCode(void) {\n \n \tid = binToDecRev(binary, 0, 7);\n \tbattery = binary[8];\n-\ttemperature = binToDecRev(binary, 14, 23);\n+\ttemperature = binToSignedRev(binary, 14, 23);","path":"libs/pilight/protocols/433.92/teknihall.c","position":5,"original_position":5,"commit_id":"2f97e6a52b2c8fcdecaeff8e8748728446121e40","original_commit_id":"2f97e6a52b2c8fcdecaeff8e8748728446121e40","user":{"login":"puuu","id":19514939,"avatar_url":"https://avatars.githubusercontent.com/u/19514939?v=3","gravatar_id":"","url":"https://api.github.com/users/puuu","html_url":"https://github.com/puuu","followers_url":"https://api.github.com/users/puuu/followers","following_url":"https://api.github.com/users/puuu/following{/other_user}","gists_url":"https://api.github.com/users/puuu/gists{/gist_id}","starred_url":"https://api.github.com/users/puuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puuu/subscriptions","organizations_url":"https://api.github.com/users/puuu/orgs","repos_url":"https://api.github.com/users/puuu/repos","events_url":"https://api.github.com/users/puuu/events{/privacy}","received_events_url":"https://api.github.com/users/puuu/received_events","type":"User","site_admin":false},"body":"This will not work. As discussed we need to include bit 13: `temperature = binToSignedRev(binary, 13, 23);`","created_at":"2016-12-11T11:25:38Z","updated_at":"2016-12-11T11:25:38Z","html_url":"https://github.com/pilight/pilight/pull/221#discussion_r91853774","pull_request_url":"https://api.github.com/repos/pilight/pilight/pulls/221","_links":{"self":{"href":"https://api.github.com/repos/pilight/pilight/pulls/comments/91853774"},"html":{"href":"https://github.com/pilight/pilight/pull/221#discussion_r91853774"},"pull_request":{"href":"https://api.github.com/repos/pilight/pilight/pulls/221"}}},"pull_request":{"url":"https://api.github.com/repos/pilight/pilight/pulls/221","id":55189779,"html_url":"https://github.com/pilight/pilight/pull/221","diff_url":"https://github.com/pilight/pilight/pull/221.diff","patch_url":"https://github.com/pilight/pilight/pull/221.patch","issue_url":"https://api.github.com/repos/pilight/pilight/issues/221","number":221,"state":"closed","locked":false,"title":"Teknihall: Fix negative temperatures","user":{"login":"pilino1234","id":11665015,"avatar_url":"https://avatars.githubusercontent.com/u/11665015?v=3","gravatar_id":"","url":"https://api.github.com/users/pilino1234","html_url":"https://github.com/pilino1234","followers_url":"https://api.github.com/users/pilino1234/followers","following_url":"https://api.github.com/users/pilino1234/following{/other_user}","gists_url":"https://api.github.com/users/pilino1234/gists{/gist_id}","starred_url":"https://api.github.com/users/pilino1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilino1234/subscriptions","organizations_url":"https://api.github.com/users/pilino1234/orgs","repos_url":"https://api.github.com/users/pilino1234/repos","events_url":"https://api.github.com/users/pilino1234/events{/privacy}","received_events_url":"https://api.github.com/users/pilino1234/received_events","type":"User","site_admin":false},"body":"The values were distorted, fixed by checking for unreasonably high value and subtracting 102.4°.\nDiscussion: https://forum.pilight.org/Thread-negative-Temperature-for?pid=16687#pid16687\n","created_at":"2016-01-06T08:49:56Z","updated_at":"2016-12-11T11:25:38Z","closed_at":"2016-12-11T11:18:48Z","merged_at":"2016-12-11T11:18:48Z","merge_commit_sha":"ee35320236dbd3c6acf4858cce0211dd67ee96cd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pilight/pilight/pulls/221/commits","review_comments_url":"https://api.github.com/repos/pilight/pilight/pulls/221/comments","review_comment_url":"https://api.github.com/repos/pilight/pilight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pilight/pilight/issues/221/comments","statuses_url":"https://api.github.com/repos/pilight/pilight/statuses/2f97e6a52b2c8fcdecaeff8e8748728446121e40","head":{"label":"pilino1234:teknihall-negative","ref":"teknihall-negative","sha":"2f97e6a52b2c8fcdecaeff8e8748728446121e40","user":{"login":"pilino1234","id":11665015,"avatar_url":"https://avatars.githubusercontent.com/u/11665015?v=3","gravatar_id":"","url":"https://api.github.com/users/pilino1234","html_url":"https://github.com/pilino1234","followers_url":"https://api.github.com/users/pilino1234/followers","following_url":"https://api.github.com/users/pilino1234/following{/other_user}","gists_url":"https://api.github.com/users/pilino1234/gists{/gist_id}","starred_url":"https://api.github.com/users/pilino1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilino1234/subscriptions","organizations_url":"https://api.github.com/users/pilino1234/orgs","repos_url":"https://api.github.com/users/pilino1234/repos","events_url":"https://api.github.com/users/pilino1234/events{/privacy}","received_events_url":"https://api.github.com/users/pilino1234/received_events","type":"User","site_admin":false},"repo":{"id":40720413,"name":"pilight","full_name":"pilino1234/pilight","owner":{"login":"pilino1234","id":11665015,"avatar_url":"https://avatars.githubusercontent.com/u/11665015?v=3","gravatar_id":"","url":"https://api.github.com/users/pilino1234","html_url":"https://github.com/pilino1234","followers_url":"https://api.github.com/users/pilino1234/followers","following_url":"https://api.github.com/users/pilino1234/following{/other_user}","gists_url":"https://api.github.com/users/pilino1234/gists{/gist_id}","starred_url":"https://api.github.com/users/pilino1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilino1234/subscriptions","organizations_url":"https://api.github.com/users/pilino1234/orgs","repos_url":"https://api.github.com/users/pilino1234/repos","events_url":"https://api.github.com/users/pilino1234/events{/privacy}","received_events_url":"https://api.github.com/users/pilino1234/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pilino1234/pilight","description":"open source domotica solution","fork":true,"url":"https://api.github.com/repos/pilino1234/pilight","forks_url":"https://api.github.com/repos/pilino1234/pilight/forks","keys_url":"https://api.github.com/repos/pilino1234/pilight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pilino1234/pilight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pilino1234/pilight/teams","hooks_url":"https://api.github.com/repos/pilino1234/pilight/hooks","issue_events_url":"https://api.github.com/repos/pilino1234/pilight/issues/events{/number}","events_url":"https://api.github.com/repos/pilino1234/pilight/events","assignees_url":"https://api.github.com/repos/pilino1234/pilight/assignees{/user}","branches_url":"https://api.github.com/repos/pilino1234/pilight/branches{/branch}","tags_url":"https://api.github.com/repos/pilino1234/pilight/tags","blobs_url":"https://api.github.com/repos/pilino1234/pilight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pilino1234/pilight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pilino1234/pilight/git/refs{/sha}","trees_url":"https://api.github.com/repos/pilino1234/pilight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pilino1234/pilight/statuses/{sha}","languages_url":"https://api.github.com/repos/pilino1234/pilight/languages","stargazers_url":"https://api.github.com/repos/pilino1234/pilight/stargazers","contributors_url":"https://api.github.com/repos/pilino1234/pilight/contributors","subscribers_url":"https://api.github.com/repos/pilino1234/pilight/subscribers","subscription_url":"https://api.github.com/repos/pilino1234/pilight/subscription","commits_url":"https://api.github.com/repos/pilino1234/pilight/commits{/sha}","git_commits_url":"https://api.github.com/repos/pilino1234/pilight/git/commits{/sha}","comments_url":"https://api.github.com/repos/pilino1234/pilight/comments{/number}","issue_comment_url":"https://api.github.com/repos/pilino1234/pilight/issues/comments{/number}","contents_url":"https://api.github.com/repos/pilino1234/pilight/contents/{+path}","compare_url":"https://api.github.com/repos/pilino1234/pilight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pilino1234/pilight/merges","archive_url":"https://api.github.com/repos/pilino1234/pilight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pilino1234/pilight/downloads","issues_url":"https://api.github.com/repos/pilino1234/pilight/issues{/number}","pulls_url":"https://api.github.com/repos/pilino1234/pilight/pulls{/number}","milestones_url":"https://api.github.com/repos/pilino1234/pilight/milestones{/number}","notifications_url":"https://api.github.com/repos/pilino1234/pilight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pilino1234/pilight/labels{/name}","releases_url":"https://api.github.com/repos/pilino1234/pilight/releases{/id}","deployments_url":"https://api.github.com/repos/pilino1234/pilight/deployments","created_at":"2015-08-14T14:53:52Z","updated_at":"2016-01-26T09:51:38Z","pushed_at":"2016-12-11T11:15:17Z","git_url":"git://github.com/pilino1234/pilight.git","ssh_url":"git@github.com:pilino1234/pilight.git","clone_url":"https://github.com/pilino1234/pilight.git","svn_url":"https://github.com/pilino1234/pilight","homepage":"www.pilight.org","size":11490,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"pilight:development","ref":"development","sha":"20742babc7700e40f6858d007de061f242617dbe","user":{"login":"pilight","id":5197912,"avatar_url":"https://avatars.githubusercontent.com/u/5197912?v=3","gravatar_id":"","url":"https://api.github.com/users/pilight","html_url":"https://github.com/pilight","followers_url":"https://api.github.com/users/pilight/followers","following_url":"https://api.github.com/users/pilight/following{/other_user}","gists_url":"https://api.github.com/users/pilight/gists{/gist_id}","starred_url":"https://api.github.com/users/pilight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilight/subscriptions","organizations_url":"https://api.github.com/users/pilight/orgs","repos_url":"https://api.github.com/users/pilight/repos","events_url":"https://api.github.com/users/pilight/events{/privacy}","received_events_url":"https://api.github.com/users/pilight/received_events","type":"Organization","site_admin":false},"repo":{"id":5966572,"name":"pilight","full_name":"pilight/pilight","owner":{"login":"pilight","id":5197912,"avatar_url":"https://avatars.githubusercontent.com/u/5197912?v=3","gravatar_id":"","url":"https://api.github.com/users/pilight","html_url":"https://github.com/pilight","followers_url":"https://api.github.com/users/pilight/followers","following_url":"https://api.github.com/users/pilight/following{/other_user}","gists_url":"https://api.github.com/users/pilight/gists{/gist_id}","starred_url":"https://api.github.com/users/pilight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilight/subscriptions","organizations_url":"https://api.github.com/users/pilight/orgs","repos_url":"https://api.github.com/users/pilight/repos","events_url":"https://api.github.com/users/pilight/events{/privacy}","received_events_url":"https://api.github.com/users/pilight/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pilight/pilight","description":"open source domotica solution","fork":false,"url":"https://api.github.com/repos/pilight/pilight","forks_url":"https://api.github.com/repos/pilight/pilight/forks","keys_url":"https://api.github.com/repos/pilight/pilight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pilight/pilight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pilight/pilight/teams","hooks_url":"https://api.github.com/repos/pilight/pilight/hooks","issue_events_url":"https://api.github.com/repos/pilight/pilight/issues/events{/number}","events_url":"https://api.github.com/repos/pilight/pilight/events","assignees_url":"https://api.github.com/repos/pilight/pilight/assignees{/user}","branches_url":"https://api.github.com/repos/pilight/pilight/branches{/branch}","tags_url":"https://api.github.com/repos/pilight/pilight/tags","blobs_url":"https://api.github.com/repos/pilight/pilight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pilight/pilight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pilight/pilight/git/refs{/sha}","trees_url":"https://api.github.com/repos/pilight/pilight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pilight/pilight/statuses/{sha}","languages_url":"https://api.github.com/repos/pilight/pilight/languages","stargazers_url":"https://api.github.com/repos/pilight/pilight/stargazers","contributors_url":"https://api.github.com/repos/pilight/pilight/contributors","subscribers_url":"https://api.github.com/repos/pilight/pilight/subscribers","subscription_url":"https://api.github.com/repos/pilight/pilight/subscription","commits_url":"https://api.github.com/repos/pilight/pilight/commits{/sha}","git_commits_url":"https://api.github.com/repos/pilight/pilight/git/commits{/sha}","comments_url":"https://api.github.com/repos/pilight/pilight/comments{/number}","issue_comment_url":"https://api.github.com/repos/pilight/pilight/issues/comments{/number}","contents_url":"https://api.github.com/repos/pilight/pilight/contents/{+path}","compare_url":"https://api.github.com/repos/pilight/pilight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pilight/pilight/merges","archive_url":"https://api.github.com/repos/pilight/pilight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pilight/pilight/downloads","issues_url":"https://api.github.com/repos/pilight/pilight/issues{/number}","pulls_url":"https://api.github.com/repos/pilight/pilight/pulls{/number}","milestones_url":"https://api.github.com/repos/pilight/pilight/milestones{/number}","notifications_url":"https://api.github.com/repos/pilight/pilight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pilight/pilight/labels{/name}","releases_url":"https://api.github.com/repos/pilight/pilight/releases{/id}","deployments_url":"https://api.github.com/repos/pilight/pilight/deployments","created_at":"2012-09-26T13:56:20Z","updated_at":"2016-12-06T00:20:01Z","pushed_at":"2016-12-11T11:18:48Z","git_url":"git://github.com/pilight/pilight.git","ssh_url":"git@github.com:pilight/pilight.git","clone_url":"https://github.com/pilight/pilight.git","svn_url":"https://github.com/pilight/pilight","homepage":"www.pilight.org","size":15100,"stargazers_count":183,"watchers_count":183,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":137,"mirror_url":null,"open_issues_count":35,"forks":137,"open_issues":35,"watchers":183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pilight/pilight/pulls/221"},"html":{"href":"https://github.com/pilight/pilight/pull/221"},"issue":{"href":"https://api.github.com/repos/pilight/pilight/issues/221"},"comments":{"href":"https://api.github.com/repos/pilight/pilight/issues/221/comments"},"review_comments":{"href":"https://api.github.com/repos/pilight/pilight/pulls/221/comments"},"review_comment":{"href":"https://api.github.com/repos/pilight/pilight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pilight/pilight/pulls/221/commits"},"statuses":{"href":"https://api.github.com/repos/pilight/pilight/statuses/2f97e6a52b2c8fcdecaeff8e8748728446121e40"}}}}
{"actor":{"display_login":"puuu"}}