{"action":"opened","number":1068,"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1068","id":98576416,"html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/1068","diff_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/1068.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/1068.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/1068","number":1068,"state":"open","locked":false,"title":"Refactor for full auto-config","user":{"login":"jvalkeal","id":50398,"avatar_url":"https://avatars.githubusercontent.com/u/50398?v=3","gravatar_id":"","url":"https://api.github.com/users/jvalkeal","html_url":"https://github.com/jvalkeal","followers_url":"https://api.github.com/users/jvalkeal/followers","following_url":"https://api.github.com/users/jvalkeal/following{/other_user}","gists_url":"https://api.github.com/users/jvalkeal/gists{/gist_id}","starred_url":"https://api.github.com/users/jvalkeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvalkeal/subscriptions","organizations_url":"https://api.github.com/users/jvalkeal/orgs","repos_url":"https://api.github.com/users/jvalkeal/repos","events_url":"https://api.github.com/users/jvalkeal/events{/privacy}","received_events_url":"https://api.github.com/users/jvalkeal/received_events","type":"User","site_admin":false},"body":"- This commit has one goal, Removal of @EnableAutoConfiguration\r\n  from DataFlowServerConfiguration so that dataflow server can be\r\n  build and run by just having needed deps and @SpringBootApplication\r\n  in a main class.\r\n- NOTE: This will be a breaking change with our use of @EnableDataFlowServer\r\n  as it will no longer enable auto configuration thus it will now be\r\n  required to use i.e. @SpringBootApplication.\r\n- Add DataFlowServerAutoConfiguration which is a passthrough for\r\n  @EnableDataFlowServer. For conveniance 'dataflow.server.enabled' is\r\n  added for conditionally disable this autoconfig. JacksonAutoConfiguration\r\n  needs to happen after as otherwise we hit issues with\r\n  github.com/spring-projects/spring-boot/issues/5984. Previously\r\n  DataFlowServerConfiguration enabled autoconfig and pretty much did\r\n  same thing because of a use of @EnableDataFlowServer in a\r\n  main class.\r\n- Adding package for LocalDataFlowServerAutoConfiguration to get\r\n  DelegatingResourceLoader(for docker and maven) created as previously\r\n  this was imported manually from LocalDataFlowServer. Property\r\n  'dataflow.server.local.enabled' is also added.\r\n- Refactor some of a tests which previously relied auto-config to kick\r\n  in automatically via DataFlowServerConfiguration.\r\n- SessionAutoConfiguration used to be explicitely exluded via annotation\r\n  as it will cause failure if redis is not available and we need to have\r\n  a way to disable things around that. Boot guys recommended to set\r\n  'spring.session.store-type=none' instead of disabling that autoconfig.\r\n  This is now explicitely on DefaultEnvironmentPostProcessor which\r\n  adds new yml file META-INF/dataflow-server-defaults.yml where we\r\n  can place internal default props.\r\n- Fixes #1026","created_at":"2016-12-19T14:40:46Z","updated_at":"2016-12-19T14:40:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1068/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1068/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/1068/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/c598070449795e90d1ddae6b94f240b012a70d4f","head":{"label":"jvalkeal:gh1026","ref":"gh1026","sha":"c598070449795e90d1ddae6b94f240b012a70d4f","user":{"login":"jvalkeal","id":50398,"avatar_url":"https://avatars.githubusercontent.com/u/50398?v=3","gravatar_id":"","url":"https://api.github.com/users/jvalkeal","html_url":"https://github.com/jvalkeal","followers_url":"https://api.github.com/users/jvalkeal/followers","following_url":"https://api.github.com/users/jvalkeal/following{/other_user}","gists_url":"https://api.github.com/users/jvalkeal/gists{/gist_id}","starred_url":"https://api.github.com/users/jvalkeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvalkeal/subscriptions","organizations_url":"https://api.github.com/users/jvalkeal/orgs","repos_url":"https://api.github.com/users/jvalkeal/repos","events_url":"https://api.github.com/users/jvalkeal/events{/privacy}","received_events_url":"https://api.github.com/users/jvalkeal/received_events","type":"User","site_admin":false},"repo":{"id":40263722,"name":"spring-cloud-dataflow","full_name":"jvalkeal/spring-cloud-dataflow","owner":{"login":"jvalkeal","id":50398,"avatar_url":"https://avatars.githubusercontent.com/u/50398?v=3","gravatar_id":"","url":"https://api.github.com/users/jvalkeal","html_url":"https://github.com/jvalkeal","followers_url":"https://api.github.com/users/jvalkeal/followers","following_url":"https://api.github.com/users/jvalkeal/following{/other_user}","gists_url":"https://api.github.com/users/jvalkeal/gists{/gist_id}","starred_url":"https://api.github.com/users/jvalkeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvalkeal/subscriptions","organizations_url":"https://api.github.com/users/jvalkeal/orgs","repos_url":"https://api.github.com/users/jvalkeal/repos","events_url":"https://api.github.com/users/jvalkeal/events{/privacy}","received_events_url":"https://api.github.com/users/jvalkeal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jvalkeal/spring-cloud-dataflow","description":null,"fork":true,"url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow","forks_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/forks","keys_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/teams","hooks_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/hooks","issue_events_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/events","assignees_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/tags","blobs_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/languages","stargazers_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/stargazers","contributors_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/contributors","subscribers_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/subscribers","subscription_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/subscription","commits_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/merges","archive_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/downloads","issues_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/releases{/id}","deployments_url":"https://api.github.com/repos/jvalkeal/spring-cloud-dataflow/deployments","created_at":"2015-08-05T19:03:25Z","updated_at":"2016-11-03T12:49:49Z","pushed_at":"2016-12-19T14:40:08Z","git_url":"git://github.com/jvalkeal/spring-cloud-dataflow.git","ssh_url":"git@github.com:jvalkeal/spring-cloud-dataflow.git","clone_url":"https://github.com/jvalkeal/spring-cloud-dataflow.git","svn_url":"https://github.com/jvalkeal/spring-cloud-dataflow","homepage":null,"size":15969,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"9dd230c3006585320b0b78ab19a59770ae68f011","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":39469487,"name":"spring-cloud-dataflow","full_name":"spring-cloud/spring-cloud-dataflow","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-dataflow","description":"Spring Cloud Data Flow provides orchestration for data microservices, including both stream and task processing","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/deployments","created_at":"2015-07-21T20:56:11Z","updated_at":"2016-12-19T06:24:57Z","pushed_at":"2016-12-19T09:47:09Z","git_url":"git://github.com/spring-cloud/spring-cloud-dataflow.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-dataflow.git","clone_url":"https://github.com/spring-cloud/spring-cloud-dataflow.git","svn_url":"https://github.com/spring-cloud/spring-cloud-dataflow","homepage":"http://cloud.spring.io/spring-cloud-dataflow/","size":16686,"stargazers_count":114,"watchers_count":114,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":93,"mirror_url":null,"open_issues_count":120,"forks":93,"open_issues":120,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1068"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/1068"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/1068"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/1068/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1068/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1068/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/c598070449795e90d1ddae6b94f240b012a70d4f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":295,"deletions":25,"changed_files":20}}
{"actor":{"display_login":"jvalkeal"}}