{"push_id":994319661,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"98c837faf47ba0c7ae6abcf15f4a9d7426e26e0e","before":"ec3e14b6ae4fac7fee0a96e2caa653836923b0a3","commits":[{"sha":"e203232abc8273b5bde3bec47c2ab7d049167156","author":{"email":"387ba1943871e60965e6b44638a2f2e1ab9b8469@gazlene.net","name":"Colleen Murphy"},"message":"Don't purge apt sources on infracloud\n\nWithout this change, puppetting an infracloud machine from scratch\nresults in an error[1]. The order of events that causes this issue is:\n\n1) Puppet purges /etc/apt/sources.list, removing all of apt's knowledge\n   of other sources\n2) Puppet creates /etc/apt/sources.list.d/openstack-infra.list, but\n   this will have no effect on apt's knowledge of other sources until\n   an apt-get update is run\n3) The puppet-openstack_extras module runs an exec to install the\n   ubuntu-cloud-keyring package. (This is done with an exec type rather\n   than a package type because it needs to be run before\n   Exec['apt_update'] which is defined in the puppetlabs-apt module.)\n   Since apt at this point knows of no apt sources in the world, it\n   fails to find the package.\n4) Apt-get update is run and the world is right again, so subsequent\n   puppet runs or manual installs of ubuntu-cloud-keyring are\n   confusingly successful.\n\nA potential fix for this is to create another exec resource that runs\napt-get update after adding openstack-infra.list but before installing\nubuntu-cloud-keyring, after which apt-get update will run once again.\nThis is inefficient and ugly. Since on these particular nodes we\ncontrol the base images, and the default apt sources list is sane and\nmatches what we have set in openstack-infra.list anyway, we can just\ndisable the purging of the original sources.list and there will no\nlonger be any point during which apt has no sources.\n\n[1] http://paste.openstack.org/show/488079/\n\nChange-Id: I2cb375979d55e612fe8acc4cc7abdd393f39c2b9","distinct":true,"url":"https://api.github.com/repos/openstack-infra/system-config/commits/e203232abc8273b5bde3bec47c2ab7d049167156"},{"sha":"98c837faf47ba0c7ae6abcf15f4a9d7426e26e0e","author":{"email":"d95b56ce41a2e1ac4cecdd398defd7414407cc08@review.openstack.org","name":"Jenkins"},"message":"Merge \"Don't purge apt sources on infracloud\"","distinct":true,"url":"https://api.github.com/repos/openstack-infra/system-config/commits/98c837faf47ba0c7ae6abcf15f4a9d7426e26e0e"}]}