{"action":"opened","number":57,"pull_request":{"url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/pulls/57","id":77794167,"html_url":"https://github.com/wildfly-swarm/wildfly-swarm-core/pull/57","diff_url":"https://github.com/wildfly-swarm/wildfly-swarm-core/pull/57.diff","patch_url":"https://github.com/wildfly-swarm/wildfly-swarm-core/pull/57.patch","issue_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/issues/57","number":57,"state":"open","locked":false,"title":"SWARM-565: Encupsulate dependency resolution","user":{"login":"heiko-braun","id":369380,"avatar_url":"https://avatars.githubusercontent.com/u/369380?v=3","gravatar_id":"","url":"https://api.github.com/users/heiko-braun","html_url":"https://github.com/heiko-braun","followers_url":"https://api.github.com/users/heiko-braun/followers","following_url":"https://api.github.com/users/heiko-braun/following{/other_user}","gists_url":"https://api.github.com/users/heiko-braun/gists{/gist_id}","starred_url":"https://api.github.com/users/heiko-braun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heiko-braun/subscriptions","organizations_url":"https://api.github.com/users/heiko-braun/orgs","repos_url":"https://api.github.com/users/heiko-braun/repos","events_url":"https://api.github.com/users/heiko-braun/events{/privacy}","received_events_url":"https://api.github.com/users/heiko-braun/received_events","type":"User","site_admin":false},"body":"This relates to https://issues.jboss.org/browse/SWARM-565\r\n\r\nI've been trying to improve the resolution of dependencies that happens when `deployment.addAllDependencies();` is called, i.e. in `org.wildfly.swarm.examples.jaxrs.shrinkwrap.Main()`\r\n\r\nThis first commit is merely for reviewing purposes, to discuss the approach in general. Some notable changes are:\r\n\r\n- the algo works inclusive (define the inclusion and discard the rest), in contrast the previous impl. that worked exclusive (define the exclusion and keep the remainder)\r\n- the property \"user.dir\" still works unreliably (i.e. in multi-module IDE setups)\r\n- it's not clear how/if to process `target/classes`\r\n","created_at":"2016-07-18T11:34:59Z","updated_at":"2016-07-18T11:34:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/pulls/57/commits","review_comments_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/pulls/57/comments","review_comment_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/issues/57/comments","statuses_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/statuses/05734743e1497af1f5b343a000bbf8d9b28e1d2c","head":{"label":"heiko-braun:SWARM-565","ref":"SWARM-565","sha":"05734743e1497af1f5b343a000bbf8d9b28e1d2c","user":{"login":"heiko-braun","id":369380,"avatar_url":"https://avatars.githubusercontent.com/u/369380?v=3","gravatar_id":"","url":"https://api.github.com/users/heiko-braun","html_url":"https://github.com/heiko-braun","followers_url":"https://api.github.com/users/heiko-braun/followers","following_url":"https://api.github.com/users/heiko-braun/following{/other_user}","gists_url":"https://api.github.com/users/heiko-braun/gists{/gist_id}","starred_url":"https://api.github.com/users/heiko-braun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heiko-braun/subscriptions","organizations_url":"https://api.github.com/users/heiko-braun/orgs","repos_url":"https://api.github.com/users/heiko-braun/repos","events_url":"https://api.github.com/users/heiko-braun/events{/privacy}","received_events_url":"https://api.github.com/users/heiko-braun/received_events","type":"User","site_admin":false},"repo":{"id":52597837,"name":"wildfly-swarm-core","full_name":"heiko-braun/wildfly-swarm-core","owner":{"login":"heiko-braun","id":369380,"avatar_url":"https://avatars.githubusercontent.com/u/369380?v=3","gravatar_id":"","url":"https://api.github.com/users/heiko-braun","html_url":"https://github.com/heiko-braun","followers_url":"https://api.github.com/users/heiko-braun/followers","following_url":"https://api.github.com/users/heiko-braun/following{/other_user}","gists_url":"https://api.github.com/users/heiko-braun/gists{/gist_id}","starred_url":"https://api.github.com/users/heiko-braun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heiko-braun/subscriptions","organizations_url":"https://api.github.com/users/heiko-braun/orgs","repos_url":"https://api.github.com/users/heiko-braun/repos","events_url":"https://api.github.com/users/heiko-braun/events{/privacy}","received_events_url":"https://api.github.com/users/heiko-braun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/heiko-braun/wildfly-swarm-core","description":"","fork":true,"url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core","forks_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/forks","keys_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/teams","hooks_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/hooks","issue_events_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/issues/events{/number}","events_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/events","assignees_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/assignees{/user}","branches_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/branches{/branch}","tags_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/tags","blobs_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/languages","stargazers_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/stargazers","contributors_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/contributors","subscribers_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/subscribers","subscription_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/subscription","commits_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/contents/{+path}","compare_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/merges","archive_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/downloads","issues_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/issues{/number}","pulls_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/labels{/name}","releases_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/releases{/id}","deployments_url":"https://api.github.com/repos/heiko-braun/wildfly-swarm-core/deployments","created_at":"2016-02-26T10:41:44Z","updated_at":"2016-02-26T10:41:46Z","pushed_at":"2016-07-18T11:15:36Z","git_url":"git://github.com/heiko-braun/wildfly-swarm-core.git","ssh_url":"git@github.com:heiko-braun/wildfly-swarm-core.git","clone_url":"https://github.com/heiko-braun/wildfly-swarm-core.git","svn_url":"https://github.com/heiko-braun/wildfly-swarm-core","homepage":null,"size":7849,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly-swarm:master","ref":"master","sha":"ddcf1569ee0f2cf9b3b96755e2e96f093a11fbaf","user":{"login":"wildfly-swarm","id":11523816,"avatar_url":"https://avatars.githubusercontent.com/u/11523816?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly-swarm","html_url":"https://github.com/wildfly-swarm","followers_url":"https://api.github.com/users/wildfly-swarm/followers","following_url":"https://api.github.com/users/wildfly-swarm/following{/other_user}","gists_url":"https://api.github.com/users/wildfly-swarm/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly-swarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly-swarm/subscriptions","organizations_url":"https://api.github.com/users/wildfly-swarm/orgs","repos_url":"https://api.github.com/users/wildfly-swarm/repos","events_url":"https://api.github.com/users/wildfly-swarm/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly-swarm/received_events","type":"Organization","site_admin":false},"repo":{"id":52040340,"name":"wildfly-swarm-core","full_name":"wildfly-swarm/wildfly-swarm-core","owner":{"login":"wildfly-swarm","id":11523816,"avatar_url":"https://avatars.githubusercontent.com/u/11523816?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly-swarm","html_url":"https://github.com/wildfly-swarm","followers_url":"https://api.github.com/users/wildfly-swarm/followers","following_url":"https://api.github.com/users/wildfly-swarm/following{/other_user}","gists_url":"https://api.github.com/users/wildfly-swarm/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly-swarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly-swarm/subscriptions","organizations_url":"https://api.github.com/users/wildfly-swarm/orgs","repos_url":"https://api.github.com/users/wildfly-swarm/repos","events_url":"https://api.github.com/users/wildfly-swarm/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly-swarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly-swarm/wildfly-swarm-core","description":"Core fractions","fork":false,"url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core","forks_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/forks","keys_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/teams","hooks_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/hooks","issue_events_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/events","assignees_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/tags","blobs_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/languages","stargazers_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/stargazers","contributors_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/contributors","subscribers_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/subscribers","subscription_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/subscription","commits_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/merges","archive_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/downloads","issues_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/labels{/name}","releases_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/deployments","created_at":"2016-02-18T21:32:47Z","updated_at":"2016-07-18T10:50:32Z","pushed_at":"2016-07-18T11:34:59Z","git_url":"git://github.com/wildfly-swarm/wildfly-swarm-core.git","ssh_url":"git@github.com:wildfly-swarm/wildfly-swarm-core.git","clone_url":"https://github.com/wildfly-swarm/wildfly-swarm-core.git","svn_url":"https://github.com/wildfly-swarm/wildfly-swarm-core","homepage":"","size":7920,"stargazers_count":22,"watchers_count":22,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":5,"forks":35,"open_issues":5,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/pulls/57"},"html":{"href":"https://github.com/wildfly-swarm/wildfly-swarm-core/pull/57"},"issue":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/issues/57"},"comments":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly-swarm/wildfly-swarm-core/statuses/05734743e1497af1f5b343a000bbf8d9b28e1d2c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":355,"deletions":110,"changed_files":6}}
{"actor":{"display_login":"heiko-braun"}}