{"action":"created","issue":{"url":"https://api.github.com/repos/openid/AppAuth-iOS/issues/30","repository_url":"https://api.github.com/repos/openid/AppAuth-iOS","labels_url":"https://api.github.com/repos/openid/AppAuth-iOS/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/openid/AppAuth-iOS/issues/30/comments","events_url":"https://api.github.com/repos/openid/AppAuth-iOS/issues/30/events","html_url":"https://github.com/openid/AppAuth-iOS/pull/30","id":163186535,"number":30,"title":"First step to add support for macOS.","user":{"login":"msarda","id":2102957,"avatar_url":"https://avatars.githubusercontent.com/u/2102957?v=3","gravatar_id":"","url":"https://api.github.com/users/msarda","html_url":"https://github.com/msarda","followers_url":"https://api.github.com/users/msarda/followers","following_url":"https://api.github.com/users/msarda/following{/other_user}","gists_url":"https://api.github.com/users/msarda/gists{/gist_id}","starred_url":"https://api.github.com/users/msarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msarda/subscriptions","organizations_url":"https://api.github.com/users/msarda/orgs","repos_url":"https://api.github.com/users/msarda/repos","events_url":"https://api.github.com/users/msarda/events{/privacy}","received_events_url":"https://api.github.com/users/msarda/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openid/AppAuth-iOS/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-06-30T14:57:05Z","updated_at":"2016-07-06T20:44:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openid/AppAuth-iOS/pulls/30","html_url":"https://github.com/openid/AppAuth-iOS/pull/30","diff_url":"https://github.com/openid/AppAuth-iOS/pull/30.diff","patch_url":"https://github.com/openid/AppAuth-iOS/pull/30.patch"},"body":"This PR is a first step in adding support for macOS in AppAuth. It follows the proposal on the following discussion on github https://github.com/openid/AppAuth-iOS/issues/20\r\n\r\nThis PR adds an authorization UI coordinator that is responsible to present the authorization UI. The iOS implementation continues to present a Safari View Controller or to open the Safari app is Safari View Controller is not supported on that iOS version.\r\n\r\nThis PR basically allows a user to provide a custom implementation of a authorization UI coordinator. Clients may thus provide a custom implementation that follows the guidelines in https://developers.google.com/identity/protocols/OAuth2InstalledApp for a mac that would take the user to the default browser and do the authorization flow.\r\n\r\nTESTED=Locally using the Sample iOS application.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/openid/appauth-ios/30)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/openid/AppAuth-iOS/issues/comments/230900586","html_url":"https://github.com/openid/AppAuth-iOS/pull/30#issuecomment-230900586","issue_url":"https://api.github.com/repos/openid/AppAuth-iOS/issues/30","id":230900586,"user":{"login":"StevenEWright","id":484872,"avatar_url":"https://avatars.githubusercontent.com/u/484872?v=3","gravatar_id":"","url":"https://api.github.com/users/StevenEWright","html_url":"https://github.com/StevenEWright","followers_url":"https://api.github.com/users/StevenEWright/followers","following_url":"https://api.github.com/users/StevenEWright/following{/other_user}","gists_url":"https://api.github.com/users/StevenEWright/gists{/gist_id}","starred_url":"https://api.github.com/users/StevenEWright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StevenEWright/subscriptions","organizations_url":"https://api.github.com/users/StevenEWright/orgs","repos_url":"https://api.github.com/users/StevenEWright/repos","events_url":"https://api.github.com/users/StevenEWright/events{/privacy}","received_events_url":"https://api.github.com/users/StevenEWright/received_events","type":"User","site_admin":false},"created_at":"2016-07-06T20:44:49Z","updated_at":"2016-07-06T20:44:49Z","body":"\n\n\n\nReview status: 6 of 16 files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.\n\n---\n\n*[Source/iOS/OIDAuthorizationService+IOS.h, line 38 \\[r6\\]](https://reviewable.io:443/reviews/openid/appauth-ios/30#-KM0uqEX4Eu8mtB-J4_S:-KM0uqEY_GQN39yP9guF:-1156274965) ([raw file](https://github.com/openid/appauth-ios/blob/e6115b1b478dfeb63bf8e58bcd977f450483ffe2/Source/iOS/OIDAuthorizationService+IOS.h#L38)):*\n> ```objc\n>  */\n> + (id<OIDAuthorizationFlowSession>)presentAuthorizationRequest:(OIDAuthorizationRequest *)request\n>                                       presentingViewController:\n> ```\n\nNit Monster: In this case we usually make following parameters left-aligned with the longest name starting in the 5th column (indented 4 spaces.) \n\n---\n\n*[Source/iOS/OIDAuthorizationUICoordinatorIOS.m, line 89 \\[r6\\]](https://reviewable.io:443/reviews/openid/appauth-ios/30#-KM0vpgJS7sBneNEHsep:-KM0vpgJS7sBneNEHseq:1676885860) ([raw file](https://github.com/openid/appauth-ios/blob/e6115b1b478dfeb63bf8e58bcd977f450483ffe2/Source/iOS/OIDAuthorizationUICoordinatorIOS.m#L89)):*\n> ```objc\n> }\n> \n> - (void)cleanUp {\n> ```\n\nA comment stating that the weak references are being set to nil to avoid accidentally using them while none in an authorization flow may be warranted since it's not immediately apparent why these weak references are being set to nil here.\n\n---\n\n*[Source/iOS/OIDAuthState+IOS.h, line 42 \\[r6\\]](https://reviewable.io:443/reviews/openid/appauth-ios/30#-KM0wp75UuebJXofPwjb:-KM0wp76LWiqiHcL0Sa5:-1587373238) ([raw file](https://github.com/openid/appauth-ios/blob/e6115b1b478dfeb63bf8e58bcd977f450483ffe2/Source/iOS/OIDAuthState+IOS.h#L42)):*\n> ```objc\n>                      presentingViewController:(UIViewController *)presentingViewController\n>                                      callback:(OIDAuthStateAuthorizationCallback)callback;\n> @end\n> ```\n\nNit: In the other files we have generally left a blank line before `@end`.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/openid/appauth-ios/30)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"StevenEWright"}}