{"action":"created","issue":{"url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/issues/685","repository_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin","labels_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/issues/685/labels{/name}","comments_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/issues/685/comments","events_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/issues/685/events","html_url":"https://github.com/fabric8io/fabric8-maven-plugin/pull/685","id":192009259,"number":685,"title":"Pull request with fix for issue #6599: JavaExecGenerator in maven plugin 3.2: Problems with main class treatment in non-fat-jar deployments ","user":{"login":"oweise","id":1698045,"avatar_url":"https://avatars.githubusercontent.com/u/1698045?v=3","gravatar_id":"","url":"https://api.github.com/users/oweise","html_url":"https://github.com/oweise","followers_url":"https://api.github.com/users/oweise/followers","following_url":"https://api.github.com/users/oweise/following{/other_user}","gists_url":"https://api.github.com/users/oweise/gists{/gist_id}","starred_url":"https://api.github.com/users/oweise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oweise/subscriptions","organizations_url":"https://api.github.com/users/oweise/orgs","repos_url":"https://api.github.com/users/oweise/repos","events_url":"https://api.github.com/users/oweise/events{/privacy}","received_events_url":"https://api.github.com/users/oweise/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-28T13:43:53Z","updated_at":"2016-12-07T12:47:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/pulls/685","html_url":"https://github.com/fabric8io/fabric8-maven-plugin/pull/685","diff_url":"https://github.com/fabric8io/fabric8-maven-plugin/pull/685.diff","patch_url":"https://github.com/fabric8io/fabric8-maven-plugin/pull/685.patch"},"body":"I settled with removing the superfluous check of Config.mainClass, which is already done inside MainClassDetector, and let the getMainClass() call actually fill the var. This will let the JAVA_MAIN_CLASS_ENV_VAR be set for all non-fat-jar deployments and no longer be skipped.\r\n\r\nAlso the hasMainClass() method now should return true for any content of Config.mainClass.\r\n\r\nAlso a UnitTest was added to check for setting of the env var in three possible situations: \r\n\r\n- Configured main class in non-fat-jar\r\n- Detected main class in non-fat-jar\r\n- Fat-jar"},"comment":{"url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/issues/comments/265438618","html_url":"https://github.com/fabric8io/fabric8-maven-plugin/pull/685#issuecomment-265438618","issue_url":"https://api.github.com/repos/fabric8io/fabric8-maven-plugin/issues/685","id":265438618,"user":{"login":"davsclaus","id":477100,"avatar_url":"https://avatars.githubusercontent.com/u/477100?v=3","gravatar_id":"","url":"https://api.github.com/users/davsclaus","html_url":"https://github.com/davsclaus","followers_url":"https://api.github.com/users/davsclaus/followers","following_url":"https://api.github.com/users/davsclaus/following{/other_user}","gists_url":"https://api.github.com/users/davsclaus/gists{/gist_id}","starred_url":"https://api.github.com/users/davsclaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davsclaus/subscriptions","organizations_url":"https://api.github.com/users/davsclaus/orgs","repos_url":"https://api.github.com/users/davsclaus/repos","events_url":"https://api.github.com/users/davsclaus/events{/privacy}","received_events_url":"https://api.github.com/users/davsclaus/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T12:47:30Z","updated_at":"2016-12-07T12:47:30Z","body":"ok to test"}}
{"actor":{"display_login":"davsclaus"}}