{"action":"created","comment":{"url":"https://api.github.com/repos/LExpress/doctrine1/pulls/comments/67341179","id":67341179,"diff_hunk":"@@ -673,21 +676,157 @@ public function buildPhpDocs(array $definition)\n                     $name = $name;\n                 }\n \n-                $name = trim($name);\n+                $phpTypeMap = array(\n+                    \"enum\"      => \"string\",\n+                    \"datetime\"  => \"string\",\n+                    \"clob\"      => \"string\",\n+                    \"date\"      => \"string\",\n+                    \"time\"      => \"string\",\n+                    \"varchar\"   => \"string\",\n+                    \"char\"      => \"string\",\n+                    \"decimal\"   => \"float\",\n+                    \"blob\"      => \"object\",\n+                    \"gzip\"      => \"object\",\n+                    \"bit\"       => \"binary\",\n+                    \"varbit\"    => \"binary\",\n+                    \"inet\"      => \"string\",\n+                    \"boolean\"   => \"bool\",\n+                    \"integer\"   => \"int\",\n+                    \"string\"    => \"string\"\n+                );\n+\n+                /**\n+                 * @var double $phpCommentMap;\n+                 */\n+                $phpCommentMap = array(\n+                    \"time\"  => \"Time in ISO-8601 format (HH:MI:SS) format\",\n+                    \"date\"  => \"Date in ISO-8601 format (YYYY-MM-DD) format\",\n+                    \"datetime\"  => \"Date and time in ISO-8601 format (YYYY-MM-DD HH:MI) format\",\n+                    \"gzip\"      => \"A gzipped object\",\n+                    \"object\"    => \"A doctrine serialized object\",\n+                    \"enum\"      => \"Possible values (%s)\"\n+                );\n+\n+                $phpType = $column[\"type\"];\n+                if (isset($phpTypeMap[$column[\"type\"]]))\n+                {\n+                    $phpType = $phpTypeMap[$column[\"type\"]];\n+                }\n+\n+                $commentOptions = array();\n+\n+                if (isset($column[\"length\"]) && $column[\"length\"] != null)\n+                {\n+                    if (isset($column[\"fixed\"]) && $column[\"fixed\"] == true)\n+                    {\n+                        $commentOptions[] = sprintf(\"Type: %s(%s) fixed-size\", $column[\"type\"], $column[\"length\"]);\n+                    } else {\n+                        $commentOptions[] = sprintf(\"Type: %s(%s)\", $column[\"type\"], $column[\"length\"]);\n+                    }\n+                } else {","path":"lib/Doctrine/Import/Builder.php","position":90,"original_position":90,"commit_id":"7db622cb2b37946f0263dfe07f779134db15b762","original_commit_id":"7db622cb2b37946f0263dfe07f779134db15b762","user":{"login":"j0k3r","id":62333,"avatar_url":"https://avatars.githubusercontent.com/u/62333?v=3","gravatar_id":"","url":"https://api.github.com/users/j0k3r","html_url":"https://github.com/j0k3r","followers_url":"https://api.github.com/users/j0k3r/followers","following_url":"https://api.github.com/users/j0k3r/following{/other_user}","gists_url":"https://api.github.com/users/j0k3r/gists{/gist_id}","starred_url":"https://api.github.com/users/j0k3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j0k3r/subscriptions","organizations_url":"https://api.github.com/users/j0k3r/orgs","repos_url":"https://api.github.com/users/j0k3r/repos","events_url":"https://api.github.com/users/j0k3r/events{/privacy}","received_events_url":"https://api.github.com/users/j0k3r/received_events","type":"User","site_admin":false},"body":"Be careful about CS, we are in symfony1 not Symfony 2.\r\nShould be :\r\n\r\n```php\r\n}\r\nelse\r\n{\r\n```","created_at":"2016-06-16T13:14:46Z","updated_at":"2016-06-16T13:14:46Z","html_url":"https://github.com/LExpress/doctrine1/pull/21#discussion_r67341179","pull_request_url":"https://api.github.com/repos/LExpress/doctrine1/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/LExpress/doctrine1/pulls/comments/67341179"},"html":{"href":"https://github.com/LExpress/doctrine1/pull/21#discussion_r67341179"},"pull_request":{"href":"https://api.github.com/repos/LExpress/doctrine1/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/LExpress/doctrine1/pulls/21","id":74075208,"html_url":"https://github.com/LExpress/doctrine1/pull/21","diff_url":"https://github.com/LExpress/doctrine1/pull/21.diff","patch_url":"https://github.com/LExpress/doctrine1/pull/21.patch","issue_url":"https://api.github.com/repos/LExpress/doctrine1/issues/21","number":21,"state":"open","locked":false,"title":"Phpdoc improvements","user":{"login":"arendvw","id":1571317,"avatar_url":"https://avatars.githubusercontent.com/u/1571317?v=3","gravatar_id":"","url":"https://api.github.com/users/arendvw","html_url":"https://github.com/arendvw","followers_url":"https://api.github.com/users/arendvw/followers","following_url":"https://api.github.com/users/arendvw/following{/other_user}","gists_url":"https://api.github.com/users/arendvw/gists{/gist_id}","starred_url":"https://api.github.com/users/arendvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arendvw/subscriptions","organizations_url":"https://api.github.com/users/arendvw/orgs","repos_url":"https://api.github.com/users/arendvw/repos","events_url":"https://api.github.com/users/arendvw/events{/privacy}","received_events_url":"https://api.github.com/users/arendvw/received_events","type":"User","site_admin":false},"body":"- Improved comments from the doctrine point of view\r\n- Added getter/setter @method comments for base comments\r\n- Added better indenting of @property comments\r\n- Added better type annotations (conversion from doctrine type to php, and hinting for date and time formats)\r\n- Added available options for enum types (and format for time based formats)","created_at":"2016-06-16T12:53:32Z","updated_at":"2016-06-16T13:14:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7eb035ef49f364a6742caed205f82a27012fb192","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LExpress/doctrine1/pulls/21/commits","review_comments_url":"https://api.github.com/repos/LExpress/doctrine1/pulls/21/comments","review_comment_url":"https://api.github.com/repos/LExpress/doctrine1/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LExpress/doctrine1/issues/21/comments","statuses_url":"https://api.github.com/repos/LExpress/doctrine1/statuses/7db622cb2b37946f0263dfe07f779134db15b762","head":{"label":"arendvw:dev-phpdoc-improvements","ref":"dev-phpdoc-improvements","sha":"7db622cb2b37946f0263dfe07f779134db15b762","user":{"login":"arendvw","id":1571317,"avatar_url":"https://avatars.githubusercontent.com/u/1571317?v=3","gravatar_id":"","url":"https://api.github.com/users/arendvw","html_url":"https://github.com/arendvw","followers_url":"https://api.github.com/users/arendvw/followers","following_url":"https://api.github.com/users/arendvw/following{/other_user}","gists_url":"https://api.github.com/users/arendvw/gists{/gist_id}","starred_url":"https://api.github.com/users/arendvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arendvw/subscriptions","organizations_url":"https://api.github.com/users/arendvw/orgs","repos_url":"https://api.github.com/users/arendvw/repos","events_url":"https://api.github.com/users/arendvw/events{/privacy}","received_events_url":"https://api.github.com/users/arendvw/received_events","type":"User","site_admin":false},"repo":{"id":61109770,"name":"doctrine1","full_name":"arendvw/doctrine1","owner":{"login":"arendvw","id":1571317,"avatar_url":"https://avatars.githubusercontent.com/u/1571317?v=3","gravatar_id":"","url":"https://api.github.com/users/arendvw","html_url":"https://github.com/arendvw","followers_url":"https://api.github.com/users/arendvw/followers","following_url":"https://api.github.com/users/arendvw/following{/other_user}","gists_url":"https://api.github.com/users/arendvw/gists{/gist_id}","starred_url":"https://api.github.com/users/arendvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arendvw/subscriptions","organizations_url":"https://api.github.com/users/arendvw/orgs","repos_url":"https://api.github.com/users/arendvw/repos","events_url":"https://api.github.com/users/arendvw/events{/privacy}","received_events_url":"https://api.github.com/users/arendvw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arendvw/doctrine1","description":"Doctrine 1 Object Relational Mapper","fork":true,"url":"https://api.github.com/repos/arendvw/doctrine1","forks_url":"https://api.github.com/repos/arendvw/doctrine1/forks","keys_url":"https://api.github.com/repos/arendvw/doctrine1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arendvw/doctrine1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arendvw/doctrine1/teams","hooks_url":"https://api.github.com/repos/arendvw/doctrine1/hooks","issue_events_url":"https://api.github.com/repos/arendvw/doctrine1/issues/events{/number}","events_url":"https://api.github.com/repos/arendvw/doctrine1/events","assignees_url":"https://api.github.com/repos/arendvw/doctrine1/assignees{/user}","branches_url":"https://api.github.com/repos/arendvw/doctrine1/branches{/branch}","tags_url":"https://api.github.com/repos/arendvw/doctrine1/tags","blobs_url":"https://api.github.com/repos/arendvw/doctrine1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arendvw/doctrine1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arendvw/doctrine1/git/refs{/sha}","trees_url":"https://api.github.com/repos/arendvw/doctrine1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arendvw/doctrine1/statuses/{sha}","languages_url":"https://api.github.com/repos/arendvw/doctrine1/languages","stargazers_url":"https://api.github.com/repos/arendvw/doctrine1/stargazers","contributors_url":"https://api.github.com/repos/arendvw/doctrine1/contributors","subscribers_url":"https://api.github.com/repos/arendvw/doctrine1/subscribers","subscription_url":"https://api.github.com/repos/arendvw/doctrine1/subscription","commits_url":"https://api.github.com/repos/arendvw/doctrine1/commits{/sha}","git_commits_url":"https://api.github.com/repos/arendvw/doctrine1/git/commits{/sha}","comments_url":"https://api.github.com/repos/arendvw/doctrine1/comments{/number}","issue_comment_url":"https://api.github.com/repos/arendvw/doctrine1/issues/comments{/number}","contents_url":"https://api.github.com/repos/arendvw/doctrine1/contents/{+path}","compare_url":"https://api.github.com/repos/arendvw/doctrine1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arendvw/doctrine1/merges","archive_url":"https://api.github.com/repos/arendvw/doctrine1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arendvw/doctrine1/downloads","issues_url":"https://api.github.com/repos/arendvw/doctrine1/issues{/number}","pulls_url":"https://api.github.com/repos/arendvw/doctrine1/pulls{/number}","milestones_url":"https://api.github.com/repos/arendvw/doctrine1/milestones{/number}","notifications_url":"https://api.github.com/repos/arendvw/doctrine1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arendvw/doctrine1/labels{/name}","releases_url":"https://api.github.com/repos/arendvw/doctrine1/releases{/id}","deployments_url":"https://api.github.com/repos/arendvw/doctrine1/deployments","created_at":"2016-06-14T09:28:06Z","updated_at":"2016-06-14T09:28:10Z","pushed_at":"2016-06-16T12:49:46Z","git_url":"git://github.com/arendvw/doctrine1.git","ssh_url":"git@github.com:arendvw/doctrine1.git","clone_url":"https://github.com/arendvw/doctrine1.git","svn_url":"https://github.com/arendvw/doctrine1","homepage":"http://www.doctrine-project.org","size":1301,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LExpress:master","ref":"master","sha":"fccdf97cd55bdcbd2c281962aa0d3b12edf03e5b","user":{"login":"LExpress","id":1262762,"avatar_url":"https://avatars.githubusercontent.com/u/1262762?v=3","gravatar_id":"","url":"https://api.github.com/users/LExpress","html_url":"https://github.com/LExpress","followers_url":"https://api.github.com/users/LExpress/followers","following_url":"https://api.github.com/users/LExpress/following{/other_user}","gists_url":"https://api.github.com/users/LExpress/gists{/gist_id}","starred_url":"https://api.github.com/users/LExpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LExpress/subscriptions","organizations_url":"https://api.github.com/users/LExpress/orgs","repos_url":"https://api.github.com/users/LExpress/repos","events_url":"https://api.github.com/users/LExpress/events{/privacy}","received_events_url":"https://api.github.com/users/LExpress/received_events","type":"Organization","site_admin":false},"repo":{"id":2991861,"name":"doctrine1","full_name":"LExpress/doctrine1","owner":{"login":"LExpress","id":1262762,"avatar_url":"https://avatars.githubusercontent.com/u/1262762?v=3","gravatar_id":"","url":"https://api.github.com/users/LExpress","html_url":"https://github.com/LExpress","followers_url":"https://api.github.com/users/LExpress/followers","following_url":"https://api.github.com/users/LExpress/following{/other_user}","gists_url":"https://api.github.com/users/LExpress/gists{/gist_id}","starred_url":"https://api.github.com/users/LExpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LExpress/subscriptions","organizations_url":"https://api.github.com/users/LExpress/orgs","repos_url":"https://api.github.com/users/LExpress/repos","events_url":"https://api.github.com/users/LExpress/events{/privacy}","received_events_url":"https://api.github.com/users/LExpress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LExpress/doctrine1","description":"Doctrine 1 Object Relational Mapper","fork":true,"url":"https://api.github.com/repos/LExpress/doctrine1","forks_url":"https://api.github.com/repos/LExpress/doctrine1/forks","keys_url":"https://api.github.com/repos/LExpress/doctrine1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LExpress/doctrine1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LExpress/doctrine1/teams","hooks_url":"https://api.github.com/repos/LExpress/doctrine1/hooks","issue_events_url":"https://api.github.com/repos/LExpress/doctrine1/issues/events{/number}","events_url":"https://api.github.com/repos/LExpress/doctrine1/events","assignees_url":"https://api.github.com/repos/LExpress/doctrine1/assignees{/user}","branches_url":"https://api.github.com/repos/LExpress/doctrine1/branches{/branch}","tags_url":"https://api.github.com/repos/LExpress/doctrine1/tags","blobs_url":"https://api.github.com/repos/LExpress/doctrine1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LExpress/doctrine1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LExpress/doctrine1/git/refs{/sha}","trees_url":"https://api.github.com/repos/LExpress/doctrine1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LExpress/doctrine1/statuses/{sha}","languages_url":"https://api.github.com/repos/LExpress/doctrine1/languages","stargazers_url":"https://api.github.com/repos/LExpress/doctrine1/stargazers","contributors_url":"https://api.github.com/repos/LExpress/doctrine1/contributors","subscribers_url":"https://api.github.com/repos/LExpress/doctrine1/subscribers","subscription_url":"https://api.github.com/repos/LExpress/doctrine1/subscription","commits_url":"https://api.github.com/repos/LExpress/doctrine1/commits{/sha}","git_commits_url":"https://api.github.com/repos/LExpress/doctrine1/git/commits{/sha}","comments_url":"https://api.github.com/repos/LExpress/doctrine1/comments{/number}","issue_comment_url":"https://api.github.com/repos/LExpress/doctrine1/issues/comments{/number}","contents_url":"https://api.github.com/repos/LExpress/doctrine1/contents/{+path}","compare_url":"https://api.github.com/repos/LExpress/doctrine1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LExpress/doctrine1/merges","archive_url":"https://api.github.com/repos/LExpress/doctrine1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LExpress/doctrine1/downloads","issues_url":"https://api.github.com/repos/LExpress/doctrine1/issues{/number}","pulls_url":"https://api.github.com/repos/LExpress/doctrine1/pulls{/number}","milestones_url":"https://api.github.com/repos/LExpress/doctrine1/milestones{/number}","notifications_url":"https://api.github.com/repos/LExpress/doctrine1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LExpress/doctrine1/labels{/name}","releases_url":"https://api.github.com/repos/LExpress/doctrine1/releases{/id}","deployments_url":"https://api.github.com/repos/LExpress/doctrine1/deployments","created_at":"2011-12-16T01:27:53Z","updated_at":"2016-05-31T14:57:05Z","pushed_at":"2016-06-16T12:53:32Z","git_url":"git://github.com/LExpress/doctrine1.git","ssh_url":"git@github.com:LExpress/doctrine1.git","clone_url":"https://github.com/LExpress/doctrine1.git","svn_url":"https://github.com/LExpress/doctrine1","homepage":"http://www.doctrine-project.org","size":1409,"stargazers_count":11,"watchers_count":11,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":5,"forks":16,"open_issues":5,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LExpress/doctrine1/pulls/21"},"html":{"href":"https://github.com/LExpress/doctrine1/pull/21"},"issue":{"href":"https://api.github.com/repos/LExpress/doctrine1/issues/21"},"comments":{"href":"https://api.github.com/repos/LExpress/doctrine1/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/LExpress/doctrine1/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/LExpress/doctrine1/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LExpress/doctrine1/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/LExpress/doctrine1/statuses/7db622cb2b37946f0263dfe07f779134db15b762"}}}}
{"actor":{"display_login":"j0k3r"}}