{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/omr/issues/480","repository_url":"https://api.github.com/repos/eclipse/omr","labels_url":"https://api.github.com/repos/eclipse/omr/issues/480/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/480/comments","events_url":"https://api.github.com/repos/eclipse/omr/issues/480/events","html_url":"https://github.com/eclipse/omr/pull/480","id":188831746,"number":480,"title":"Add evaluator for UnsignedAddWithOverFlow","user":{"login":"ShuyuLi-ca","id":22401274,"avatar_url":"https://avatars.githubusercontent.com/u/22401274?v=3","gravatar_id":"","url":"https://api.github.com/users/ShuyuLi-ca","html_url":"https://github.com/ShuyuLi-ca","followers_url":"https://api.github.com/users/ShuyuLi-ca/followers","following_url":"https://api.github.com/users/ShuyuLi-ca/following{/other_user}","gists_url":"https://api.github.com/users/ShuyuLi-ca/gists{/gist_id}","starred_url":"https://api.github.com/users/ShuyuLi-ca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShuyuLi-ca/subscriptions","organizations_url":"https://api.github.com/users/ShuyuLi-ca/orgs","repos_url":"https://api.github.com/users/ShuyuLi-ca/repos","events_url":"https://api.github.com/users/ShuyuLi-ca/events{/privacy}","received_events_url":"https://api.github.com/users/ShuyuLi-ca/received_events","type":"User","site_admin":false},"labels":[{"id":463261830,"url":"https://api.github.com/repos/eclipse/omr/labels/compiler","name":"compiler","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-11T19:25:14Z","updated_at":"2016-11-24T18:51:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/480","html_url":"https://github.com/eclipse/omr/pull/480","diff_url":"https://github.com/eclipse/omr/pull/480.diff","patch_url":"https://github.com/eclipse/omr/pull/480.patch"},"body":"Add evaluator for `UnsignedAddWithOverFlow`\r\n\r\nIssue: #276\r\nSigned-off-by: Shuyu Li <shuyuli@ca.ibm.com>"},"comment":{"url":"https://api.github.com/repos/eclipse/omr/issues/comments/262831701","html_url":"https://github.com/eclipse/omr/pull/480#issuecomment-262831701","issue_url":"https://api.github.com/repos/eclipse/omr/issues/480","id":262831701,"user":{"login":"cathyzhyi","id":14285834,"avatar_url":"https://avatars.githubusercontent.com/u/14285834?v=3","gravatar_id":"","url":"https://api.github.com/users/cathyzhyi","html_url":"https://github.com/cathyzhyi","followers_url":"https://api.github.com/users/cathyzhyi/followers","following_url":"https://api.github.com/users/cathyzhyi/following{/other_user}","gists_url":"https://api.github.com/users/cathyzhyi/gists{/gist_id}","starred_url":"https://api.github.com/users/cathyzhyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathyzhyi/subscriptions","organizations_url":"https://api.github.com/users/cathyzhyi/orgs","repos_url":"https://api.github.com/users/cathyzhyi/repos","events_url":"https://api.github.com/users/cathyzhyi/events{/privacy}","received_events_url":"https://api.github.com/users/cathyzhyi/received_events","type":"User","site_admin":false},"created_at":"2016-11-24T18:51:07Z","updated_at":"2016-11-24T18:51:07Z","body":"@andrewcraik In both badd and cadd, if the second child is a const our evaluator would change those to 4 bytes lea. It works only when the overflow flags can be ignored. For, cadd, even the most general form uses \"temp.integerAddAnalyser(node, ADD4RegReg, ADD2RegMem);\" to save 1 byte because ADD4RegReg is 1 byte shorter than ADD2RegReg. This also doesn't work for overflow check. "}}
{"actor":{"display_login":"cathyzhyi"}}