{"action":"closed","number":7670,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7670","id":65008216,"html_url":"https://github.com/ManageIQ/manageiq/pull/7670","diff_url":"https://github.com/ManageIQ/manageiq/pull/7670.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/7670.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7670","number":7670,"state":"closed","locked":false,"title":"Fix Settings issue where Arrays would merge instead of overwrite","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"body":"The ability to override Arrays has been made into a PR upstream at\r\nhttps://github.com/railsconfig/config/pull/137 and\r\nhttps://github.com/danielsdeleo/deep_merge/pull/21 . However, they\r\nare not yet merged.  When they are merged and released, we can\r\nswitch back to a released version.\r\n\r\nSupercedes #7656\r\nPaired on this with @carbonin \r\n\r\n@jrafanie Please review.","created_at":"2016-04-01T21:33:10Z","updated_at":"2016-04-05T14:26:42Z","closed_at":"2016-04-05T14:26:42Z","merged_at":"2016-04-05T14:26:42Z","merge_commit_sha":"ba1813ae4ae6f3e88d8d0410d58de88fcd310048","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7670/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7670/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7670/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/5e0215c89ec7c225eba512e4c67ce34adabd3054","head":{"label":"Fryguy:overwrite_arrays","ref":"overwrite_arrays","sha":"5e0215c89ec7c225eba512e4c67ce34adabd3054","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"repo":{"id":20789885,"name":"manageiq","full_name":"Fryguy/manageiq","owner":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fryguy/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/Fryguy/manageiq","forks_url":"https://api.github.com/repos/Fryguy/manageiq/forks","keys_url":"https://api.github.com/repos/Fryguy/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fryguy/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fryguy/manageiq/teams","hooks_url":"https://api.github.com/repos/Fryguy/manageiq/hooks","issue_events_url":"https://api.github.com/repos/Fryguy/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/Fryguy/manageiq/events","assignees_url":"https://api.github.com/repos/Fryguy/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/Fryguy/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/Fryguy/manageiq/tags","blobs_url":"https://api.github.com/repos/Fryguy/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fryguy/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fryguy/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fryguy/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fryguy/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/Fryguy/manageiq/languages","stargazers_url":"https://api.github.com/repos/Fryguy/manageiq/stargazers","contributors_url":"https://api.github.com/repos/Fryguy/manageiq/contributors","subscribers_url":"https://api.github.com/repos/Fryguy/manageiq/subscribers","subscription_url":"https://api.github.com/repos/Fryguy/manageiq/subscription","commits_url":"https://api.github.com/repos/Fryguy/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fryguy/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fryguy/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fryguy/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fryguy/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/Fryguy/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fryguy/manageiq/merges","archive_url":"https://api.github.com/repos/Fryguy/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fryguy/manageiq/downloads","issues_url":"https://api.github.com/repos/Fryguy/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/Fryguy/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/Fryguy/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/Fryguy/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fryguy/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/Fryguy/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/Fryguy/manageiq/deployments","created_at":"2014-06-13T02:37:50Z","updated_at":"2014-07-02T02:07:48Z","pushed_at":"2016-04-05T13:59:42Z","git_url":"git://github.com/Fryguy/manageiq.git","ssh_url":"git@github.com:Fryguy/manageiq.git","clone_url":"https://github.com/Fryguy/manageiq.git","svn_url":"https://github.com/Fryguy/manageiq","homepage":null,"size":115061,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"41fb7d38bdd3c02c6f2dd54d6a97cf174775b7c7","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-04-05T11:38:51Z","pushed_at":"2016-04-05T14:26:42Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":153195,"stargazers_count":249,"watchers_count":249,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":267,"mirror_url":null,"open_issues_count":656,"forks":267,"open_issues":656,"watchers":249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7670"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/7670"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/7670"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/7670/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7670/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7670/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/5e0215c89ec7c225eba512e4c67ce34adabd3054"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"chessbyte","id":82161,"avatar_url":"https://avatars.githubusercontent.com/u/82161?v=3","gravatar_id":"","url":"https://api.github.com/users/chessbyte","html_url":"https://github.com/chessbyte","followers_url":"https://api.github.com/users/chessbyte/followers","following_url":"https://api.github.com/users/chessbyte/following{/other_user}","gists_url":"https://api.github.com/users/chessbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/chessbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chessbyte/subscriptions","organizations_url":"https://api.github.com/users/chessbyte/orgs","repos_url":"https://api.github.com/users/chessbyte/repos","events_url":"https://api.github.com/users/chessbyte/events{/privacy}","received_events_url":"https://api.github.com/users/chessbyte/received_events","type":"User","site_admin":false},"comments":3,"review_comments":8,"commits":1,"additions":36,"deletions":1,"changed_files":3}}