{"action":"created","comment":{"url":"https://api.github.com/repos/lerna/lerna/pulls/comments/63798927","id":63798927,"diff_hunk":"@@ -27,7 +40,7 @@ export default class BootstrapCommand extends Command {\n     this.progressBar.init(this.packages.length);\n     this.logger.info(\"Linking all dependencies\");\n \n-    async.parallelLimit(this.packages.map(pkg => done => {\n+    async.parallelLimit(this.packages.filter(pkg => !pkg.ignored).map(pkg => done => {","path":"src/commands/BootstrapCommand.js","position":31,"original_position":31,"commit_id":"898c8377bcfcce64af0aed6ad04430a09155d21f","original_commit_id":"898c8377bcfcce64af0aed6ad04430a09155d21f","user":{"login":"thejameskyle","id":952783,"avatar_url":"https://avatars.githubusercontent.com/u/952783?v=3","gravatar_id":"","url":"https://api.github.com/users/thejameskyle","html_url":"https://github.com/thejameskyle","followers_url":"https://api.github.com/users/thejameskyle/followers","following_url":"https://api.github.com/users/thejameskyle/following{/other_user}","gists_url":"https://api.github.com/users/thejameskyle/gists{/gist_id}","starred_url":"https://api.github.com/users/thejameskyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thejameskyle/subscriptions","organizations_url":"https://api.github.com/users/thejameskyle/orgs","repos_url":"https://api.github.com/users/thejameskyle/repos","events_url":"https://api.github.com/users/thejameskyle/events{/privacy}","received_events_url":"https://api.github.com/users/thejameskyle/received_events","type":"User","site_admin":false},"body":"I would rather structure this differently where we don't pass down ignore packages into the package graph and instead we do the check here if the package has been ignored.\r\n\r\nThis should remove a lot of the complexity of this feature.","created_at":"2016-05-18T23:08:42Z","updated_at":"2016-05-18T23:08:42Z","html_url":"https://github.com/lerna/lerna/pull/148#discussion_r63798927","pull_request_url":"https://api.github.com/repos/lerna/lerna/pulls/148","_links":{"self":{"href":"https://api.github.com/repos/lerna/lerna/pulls/comments/63798927"},"html":{"href":"https://github.com/lerna/lerna/pull/148#discussion_r63798927"},"pull_request":{"href":"https://api.github.com/repos/lerna/lerna/pulls/148"}}},"pull_request":{"url":"https://api.github.com/repos/lerna/lerna/pulls/148","id":70597179,"html_url":"https://github.com/lerna/lerna/pull/148","diff_url":"https://github.com/lerna/lerna/pull/148.diff","patch_url":"https://github.com/lerna/lerna/pull/148.patch","issue_url":"https://api.github.com/repos/lerna/lerna/issues/148","number":148,"state":"open","locked":false,"title":"Add option to ignore packages when bootstrapping (fixes #117)","user":{"login":"rygine","id":2925672,"avatar_url":"https://avatars.githubusercontent.com/u/2925672?v=3","gravatar_id":"","url":"https://api.github.com/users/rygine","html_url":"https://github.com/rygine","followers_url":"https://api.github.com/users/rygine/followers","following_url":"https://api.github.com/users/rygine/following{/other_user}","gists_url":"https://api.github.com/users/rygine/gists{/gist_id}","starred_url":"https://api.github.com/users/rygine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rygine/subscriptions","organizations_url":"https://api.github.com/users/rygine/orgs","repos_url":"https://api.github.com/users/rygine/repos","events_url":"https://api.github.com/users/rygine/events{/privacy}","received_events_url":"https://api.github.com/users/rygine/received_events","type":"User","site_admin":false},"body":"* Added `bootstrap-ignore` flag to CLI\r\n* Check `bootstrapConfig.ignore` key in `lerna.json`\r\n\r\nThe CLI flag will override the `bootstrapConfig` option in `lerna.json`. Both the flag and the option allow one or more packages to be specified. The CLI flag accepts comma-separated values while the `bootstrapConfig` option can also accept an array.","created_at":"2016-05-18T20:52:17Z","updated_at":"2016-05-18T23:08:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b09e14292c37989cf96f689c3cc27a7616596412","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lerna/lerna/pulls/148/commits","review_comments_url":"https://api.github.com/repos/lerna/lerna/pulls/148/comments","review_comment_url":"https://api.github.com/repos/lerna/lerna/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lerna/lerna/issues/148/comments","statuses_url":"https://api.github.com/repos/lerna/lerna/statuses/898c8377bcfcce64af0aed6ad04430a09155d21f","head":{"label":"rygine:ignore-bootstrap-packages","ref":"ignore-bootstrap-packages","sha":"898c8377bcfcce64af0aed6ad04430a09155d21f","user":{"login":"rygine","id":2925672,"avatar_url":"https://avatars.githubusercontent.com/u/2925672?v=3","gravatar_id":"","url":"https://api.github.com/users/rygine","html_url":"https://github.com/rygine","followers_url":"https://api.github.com/users/rygine/followers","following_url":"https://api.github.com/users/rygine/following{/other_user}","gists_url":"https://api.github.com/users/rygine/gists{/gist_id}","starred_url":"https://api.github.com/users/rygine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rygine/subscriptions","organizations_url":"https://api.github.com/users/rygine/orgs","repos_url":"https://api.github.com/users/rygine/repos","events_url":"https://api.github.com/users/rygine/events{/privacy}","received_events_url":"https://api.github.com/users/rygine/received_events","type":"User","site_admin":false},"repo":{"id":58682271,"name":"lerna","full_name":"rygine/lerna","owner":{"login":"rygine","id":2925672,"avatar_url":"https://avatars.githubusercontent.com/u/2925672?v=3","gravatar_id":"","url":"https://api.github.com/users/rygine","html_url":"https://github.com/rygine","followers_url":"https://api.github.com/users/rygine/followers","following_url":"https://api.github.com/users/rygine/following{/other_user}","gists_url":"https://api.github.com/users/rygine/gists{/gist_id}","starred_url":"https://api.github.com/users/rygine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rygine/subscriptions","organizations_url":"https://api.github.com/users/rygine/orgs","repos_url":"https://api.github.com/users/rygine/repos","events_url":"https://api.github.com/users/rygine/events{/privacy}","received_events_url":"https://api.github.com/users/rygine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rygine/lerna","description":":dragon: A tool for managing JavaScript projects with multiple packages.","fork":true,"url":"https://api.github.com/repos/rygine/lerna","forks_url":"https://api.github.com/repos/rygine/lerna/forks","keys_url":"https://api.github.com/repos/rygine/lerna/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rygine/lerna/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rygine/lerna/teams","hooks_url":"https://api.github.com/repos/rygine/lerna/hooks","issue_events_url":"https://api.github.com/repos/rygine/lerna/issues/events{/number}","events_url":"https://api.github.com/repos/rygine/lerna/events","assignees_url":"https://api.github.com/repos/rygine/lerna/assignees{/user}","branches_url":"https://api.github.com/repos/rygine/lerna/branches{/branch}","tags_url":"https://api.github.com/repos/rygine/lerna/tags","blobs_url":"https://api.github.com/repos/rygine/lerna/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rygine/lerna/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rygine/lerna/git/refs{/sha}","trees_url":"https://api.github.com/repos/rygine/lerna/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rygine/lerna/statuses/{sha}","languages_url":"https://api.github.com/repos/rygine/lerna/languages","stargazers_url":"https://api.github.com/repos/rygine/lerna/stargazers","contributors_url":"https://api.github.com/repos/rygine/lerna/contributors","subscribers_url":"https://api.github.com/repos/rygine/lerna/subscribers","subscription_url":"https://api.github.com/repos/rygine/lerna/subscription","commits_url":"https://api.github.com/repos/rygine/lerna/commits{/sha}","git_commits_url":"https://api.github.com/repos/rygine/lerna/git/commits{/sha}","comments_url":"https://api.github.com/repos/rygine/lerna/comments{/number}","issue_comment_url":"https://api.github.com/repos/rygine/lerna/issues/comments{/number}","contents_url":"https://api.github.com/repos/rygine/lerna/contents/{+path}","compare_url":"https://api.github.com/repos/rygine/lerna/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rygine/lerna/merges","archive_url":"https://api.github.com/repos/rygine/lerna/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rygine/lerna/downloads","issues_url":"https://api.github.com/repos/rygine/lerna/issues{/number}","pulls_url":"https://api.github.com/repos/rygine/lerna/pulls{/number}","milestones_url":"https://api.github.com/repos/rygine/lerna/milestones{/number}","notifications_url":"https://api.github.com/repos/rygine/lerna/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rygine/lerna/labels{/name}","releases_url":"https://api.github.com/repos/rygine/lerna/releases{/id}","deployments_url":"https://api.github.com/repos/rygine/lerna/deployments","created_at":"2016-05-12T22:45:52Z","updated_at":"2016-05-12T22:45:53Z","pushed_at":"2016-05-18T20:51:22Z","git_url":"git://github.com/rygine/lerna.git","ssh_url":"git@github.com:rygine/lerna.git","clone_url":"https://github.com/rygine/lerna.git","svn_url":"https://github.com/rygine/lerna","homepage":"","size":195,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lerna:master","ref":"master","sha":"a02cadfec68052b3a6cda9e06c0707562b35cf26","user":{"login":"lerna","id":19333396,"avatar_url":"https://avatars.githubusercontent.com/u/19333396?v=3","gravatar_id":"","url":"https://api.github.com/users/lerna","html_url":"https://github.com/lerna","followers_url":"https://api.github.com/users/lerna/followers","following_url":"https://api.github.com/users/lerna/following{/other_user}","gists_url":"https://api.github.com/users/lerna/gists{/gist_id}","starred_url":"https://api.github.com/users/lerna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lerna/subscriptions","organizations_url":"https://api.github.com/users/lerna/orgs","repos_url":"https://api.github.com/users/lerna/repos","events_url":"https://api.github.com/users/lerna/events{/privacy}","received_events_url":"https://api.github.com/users/lerna/received_events","type":"Organization","site_admin":false},"repo":{"id":47394776,"name":"lerna","full_name":"lerna/lerna","owner":{"login":"lerna","id":19333396,"avatar_url":"https://avatars.githubusercontent.com/u/19333396?v=3","gravatar_id":"","url":"https://api.github.com/users/lerna","html_url":"https://github.com/lerna","followers_url":"https://api.github.com/users/lerna/followers","following_url":"https://api.github.com/users/lerna/following{/other_user}","gists_url":"https://api.github.com/users/lerna/gists{/gist_id}","starred_url":"https://api.github.com/users/lerna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lerna/subscriptions","organizations_url":"https://api.github.com/users/lerna/orgs","repos_url":"https://api.github.com/users/lerna/repos","events_url":"https://api.github.com/users/lerna/events{/privacy}","received_events_url":"https://api.github.com/users/lerna/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lerna/lerna","description":":dragon: A tool for managing JavaScript projects with multiple packages.","fork":false,"url":"https://api.github.com/repos/lerna/lerna","forks_url":"https://api.github.com/repos/lerna/lerna/forks","keys_url":"https://api.github.com/repos/lerna/lerna/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lerna/lerna/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lerna/lerna/teams","hooks_url":"https://api.github.com/repos/lerna/lerna/hooks","issue_events_url":"https://api.github.com/repos/lerna/lerna/issues/events{/number}","events_url":"https://api.github.com/repos/lerna/lerna/events","assignees_url":"https://api.github.com/repos/lerna/lerna/assignees{/user}","branches_url":"https://api.github.com/repos/lerna/lerna/branches{/branch}","tags_url":"https://api.github.com/repos/lerna/lerna/tags","blobs_url":"https://api.github.com/repos/lerna/lerna/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lerna/lerna/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lerna/lerna/git/refs{/sha}","trees_url":"https://api.github.com/repos/lerna/lerna/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lerna/lerna/statuses/{sha}","languages_url":"https://api.github.com/repos/lerna/lerna/languages","stargazers_url":"https://api.github.com/repos/lerna/lerna/stargazers","contributors_url":"https://api.github.com/repos/lerna/lerna/contributors","subscribers_url":"https://api.github.com/repos/lerna/lerna/subscribers","subscription_url":"https://api.github.com/repos/lerna/lerna/subscription","commits_url":"https://api.github.com/repos/lerna/lerna/commits{/sha}","git_commits_url":"https://api.github.com/repos/lerna/lerna/git/commits{/sha}","comments_url":"https://api.github.com/repos/lerna/lerna/comments{/number}","issue_comment_url":"https://api.github.com/repos/lerna/lerna/issues/comments{/number}","contents_url":"https://api.github.com/repos/lerna/lerna/contents/{+path}","compare_url":"https://api.github.com/repos/lerna/lerna/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lerna/lerna/merges","archive_url":"https://api.github.com/repos/lerna/lerna/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lerna/lerna/downloads","issues_url":"https://api.github.com/repos/lerna/lerna/issues{/number}","pulls_url":"https://api.github.com/repos/lerna/lerna/pulls{/number}","milestones_url":"https://api.github.com/repos/lerna/lerna/milestones{/number}","notifications_url":"https://api.github.com/repos/lerna/lerna/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lerna/lerna/labels{/name}","releases_url":"https://api.github.com/repos/lerna/lerna/releases{/id}","deployments_url":"https://api.github.com/repos/lerna/lerna/deployments","created_at":"2015-12-04T09:36:55Z","updated_at":"2016-05-18T16:09:28Z","pushed_at":"2016-05-18T21:21:58Z","git_url":"git://github.com/lerna/lerna.git","ssh_url":"git@github.com:lerna/lerna.git","clone_url":"https://github.com/lerna/lerna.git","svn_url":"https://github.com/lerna/lerna","homepage":"https://lernajs.io","size":242,"stargazers_count":600,"watchers_count":600,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":39,"forks":45,"open_issues":39,"watchers":600,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lerna/lerna/pulls/148"},"html":{"href":"https://github.com/lerna/lerna/pull/148"},"issue":{"href":"https://api.github.com/repos/lerna/lerna/issues/148"},"comments":{"href":"https://api.github.com/repos/lerna/lerna/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/lerna/lerna/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/lerna/lerna/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lerna/lerna/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/lerna/lerna/statuses/898c8377bcfcce64af0aed6ad04430a09155d21f"}}}}