{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/81306097","pull_request_review_id":2294911,"id":81306097,"diff_hunk":"@@ -0,0 +1,138 @@\n+/*\n+Copyright 2016 The Kubernetes Authors.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package node\n+\n+import (\n+\t\"fmt\"\n+\t\"os\"\n+\t\"time\"\n+\n+\t\"github.com/golang/glog\"\n+\n+\tkubeadmapi \"k8s.io/kubernetes/cmd/kubeadm/app/api\"\n+\tkubeadmutil \"k8s.io/kubernetes/cmd/kubeadm/app/util\"\n+\t\"k8s.io/kubernetes/pkg/apis/certificates\"\n+\tclientset \"k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset\"\n+\t\"k8s.io/kubernetes/pkg/client/typed/discovery\"\n+\t\"k8s.io/kubernetes/pkg/client/unversioned/clientcmd\"\n+\t\"k8s.io/kubernetes/pkg/types\"\n+\t\"k8s.io/kubernetes/pkg/util/wait\"\n+)\n+\n+// RetryTimeout between the subsequent attempts to connect\n+// to an API endpoint\n+const retryTimeout = 5\n+\n+// EstablishMasterConnection with exactly one of the provided API endpoints.","path":"cmd/kubeadm/app/node/bootstrap.go","position":null,"original_position":40,"commit_id":"64181d718db336932e7d99863ff3d8cddbab93a0","original_commit_id":"4e23468dce80f3221819dd0e88b32eeafbe60817","user":{"login":"taimir","id":8666527,"avatar_url":"https://avatars.githubusercontent.com/u/8666527?v=3","gravatar_id":"","url":"https://api.github.com/users/taimir","html_url":"https://github.com/taimir","followers_url":"https://api.github.com/users/taimir/followers","following_url":"https://api.github.com/users/taimir/following{/other_user}","gists_url":"https://api.github.com/users/taimir/gists{/gist_id}","starred_url":"https://api.github.com/users/taimir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taimir/subscriptions","organizations_url":"https://api.github.com/users/taimir/orgs","repos_url":"https://api.github.com/users/taimir/repos","events_url":"https://api.github.com/users/taimir/events{/privacy}","received_events_url":"https://api.github.com/users/taimir/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2016-09-30T09:23:38Z","updated_at":"2016-09-30T09:23:39Z","html_url":"https://github.com/kubernetes/kubernetes/pull/33543#discussion_r81306097","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33543","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/81306097"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/33543#discussion_r81306097"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33543"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33543","id":86891578,"html_url":"https://github.com/kubernetes/kubernetes/pull/33543","diff_url":"https://github.com/kubernetes/kubernetes/pull/33543.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/33543.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/33543","number":33543,"state":"open","locked":false,"title":"Decouple master bootstrap from CSR in kubeadm","user":{"login":"taimir","id":8666527,"avatar_url":"https://avatars.githubusercontent.com/u/8666527?v=3","gravatar_id":"","url":"https://api.github.com/users/taimir","html_url":"https://github.com/taimir","followers_url":"https://api.github.com/users/taimir/followers","following_url":"https://api.github.com/users/taimir/following{/other_user}","gists_url":"https://api.github.com/users/taimir/gists{/gist_id}","starred_url":"https://api.github.com/users/taimir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taimir/subscriptions","organizations_url":"https://api.github.com/users/taimir/orgs","repos_url":"https://api.github.com/users/taimir/repos","events_url":"https://api.github.com/users/taimir/events{/privacy}","received_events_url":"https://api.github.com/users/taimir/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md\r\n2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md\r\n3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes\r\n-->\r\n\r\n**What this PR does / why we need it**: enhance `kubeadm` to allow for parallel provisioning of API endpoints and slave nodes\r\n\r\n**Fixes**: https://github.com/kubernetes/kubernetes/issues/33542\r\n\r\n**Special notes for your reviewer**:\r\nThis is work in progress, trying to \r\n\r\n * Introduce a concurrent retry mechanism for bootstrapping\r\n   with a single API endpoint\r\n * Refactor API client creation, decouple from CSR\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/33543)\n<!-- Reviewable:end -->\n","created_at":"2016-09-27T09:22:33Z","updated_at":"2016-09-30T09:23:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ecd92c4bd54ca47b15ba820ee62d764f1ad1514","assignee":{"login":"krousey","id":157083,"avatar_url":"https://avatars.githubusercontent.com/u/157083?v=3","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},"assignees":[{"login":"krousey","id":157083,"avatar_url":"https://avatars.githubusercontent.com/u/157083?v=3","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33543/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33543/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/33543/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/64181d718db336932e7d99863ff3d8cddbab93a0","head":{"label":"taimir:kubeadm","ref":"kubeadm","sha":"64181d718db336932e7d99863ff3d8cddbab93a0","user":{"login":"taimir","id":8666527,"avatar_url":"https://avatars.githubusercontent.com/u/8666527?v=3","gravatar_id":"","url":"https://api.github.com/users/taimir","html_url":"https://github.com/taimir","followers_url":"https://api.github.com/users/taimir/followers","following_url":"https://api.github.com/users/taimir/following{/other_user}","gists_url":"https://api.github.com/users/taimir/gists{/gist_id}","starred_url":"https://api.github.com/users/taimir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taimir/subscriptions","organizations_url":"https://api.github.com/users/taimir/orgs","repos_url":"https://api.github.com/users/taimir/repos","events_url":"https://api.github.com/users/taimir/events{/privacy}","received_events_url":"https://api.github.com/users/taimir/received_events","type":"User","site_admin":false},"repo":{"id":52962277,"name":"kubernetes","full_name":"taimir/kubernetes","owner":{"login":"taimir","id":8666527,"avatar_url":"https://avatars.githubusercontent.com/u/8666527?v=3","gravatar_id":"","url":"https://api.github.com/users/taimir","html_url":"https://github.com/taimir","followers_url":"https://api.github.com/users/taimir/followers","following_url":"https://api.github.com/users/taimir/following{/other_user}","gists_url":"https://api.github.com/users/taimir/gists{/gist_id}","starred_url":"https://api.github.com/users/taimir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taimir/subscriptions","organizations_url":"https://api.github.com/users/taimir/orgs","repos_url":"https://api.github.com/users/taimir/repos","events_url":"https://api.github.com/users/taimir/events{/privacy}","received_events_url":"https://api.github.com/users/taimir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/taimir/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/taimir/kubernetes","forks_url":"https://api.github.com/repos/taimir/kubernetes/forks","keys_url":"https://api.github.com/repos/taimir/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taimir/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taimir/kubernetes/teams","hooks_url":"https://api.github.com/repos/taimir/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/taimir/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/taimir/kubernetes/events","assignees_url":"https://api.github.com/repos/taimir/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/taimir/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/taimir/kubernetes/tags","blobs_url":"https://api.github.com/repos/taimir/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taimir/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taimir/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/taimir/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taimir/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/taimir/kubernetes/languages","stargazers_url":"https://api.github.com/repos/taimir/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/taimir/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/taimir/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/taimir/kubernetes/subscription","commits_url":"https://api.github.com/repos/taimir/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/taimir/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/taimir/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/taimir/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/taimir/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/taimir/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taimir/kubernetes/merges","archive_url":"https://api.github.com/repos/taimir/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taimir/kubernetes/downloads","issues_url":"https://api.github.com/repos/taimir/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/taimir/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/taimir/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/taimir/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taimir/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/taimir/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/taimir/kubernetes/deployments","created_at":"2016-03-02T12:48:56Z","updated_at":"2016-03-02T12:49:09Z","pushed_at":"2016-09-30T09:21:08Z","git_url":"git://github.com/taimir/kubernetes.git","ssh_url":"git@github.com:taimir/kubernetes.git","clone_url":"https://github.com/taimir/kubernetes.git","svn_url":"https://github.com/taimir/kubernetes","homepage":"http://kubernetes.io","size":326286,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"448ceb38813092633618e93ab2585da615ace729","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-09-30T09:14:02Z","pushed_at":"2016-09-30T09:21:18Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":574647,"stargazers_count":17222,"watchers_count":17222,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5586,"mirror_url":null,"open_issues_count":4711,"forks":5586,"open_issues":4711,"watchers":17222,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33543"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/33543"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/33543"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/33543/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33543/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33543/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/64181d718db336932e7d99863ff3d8cddbab93a0"}}}}
{"actor":{"display_login":"taimir"}}