{"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/72183265","id":72183265,"diff_hunk":"@@ -465,29 +465,21 @@ The first part identifies which template is missing. In this case, it's the\n then it will attempt to load a template called `application/new`. It looks for\n one here because the `ArticlesController` inherits from `ApplicationController`.\n \n-The next part of the message contains a hash. The `:locale` key in this hash\n-simply indicates which spoken language template should be retrieved. By default,\n-this is the English - or \"en\" - template. The next key, `:formats` specifies the\n-format of the template to be served in response. The default format is `:html`, and\n-so Rails is looking for an HTML template. The final key, `:handlers`, is telling\n-us what _template handlers_ could be used to render our template. `:erb` is most\n-commonly used for HTML templates, `:builder` is used for XML templates, and\n-`:coffee` uses CoffeeScript to build JavaScript templates.\n-\n-The message also contains `request.formats` which specifies the format of template to be\n-served in response. It is set to `text/html` as we requested this page via browser, so Rails\n-is looking for an HTML template.\n+The next part of the message contains `request.formats` which specifies\n+the format of template to be served in response. It is set to `text/html` as we\n+requested this page via browser, so Rails is looking for an HTML template.\n+`request.variants` specifies what kind of physical devices would be served by\n+the response and helps Rails determine which template to use in the response.\n+It is empty because no information has been provided.\n \n The simplest template that would work in this case would be one located at\n `app/views/articles/new.html.erb`. The extension of this file name is important:\n the first extension is the _format_ of the template, and the second extension\n-is the _handler_ that will be used. Rails is attempting to find a template\n-called `articles/new` within `app/views` for the application. The format for\n-this template can only be `html` and the handler must be one of `erb`,\n-`builder` or `coffee`. `:erb` is most commonly used for HTML templates, `:builder` is\n-used for XML templates, and `:coffee` uses CoffeeScript to build JavaScript templates.\n-Because you want to create a new HTML form, you will be\n-using the `ERB` language which is designed to embed Ruby in HTML.","path":"guides/source/getting_started.md","position":32,"original_position":32,"commit_id":"de0716f09d973d74f30a23bd692c2ec923612034","original_commit_id":"de0716f09d973d74f30a23bd692c2ec923612034","user":{"login":"prathamesh-sonpatki","id":621238,"avatar_url":"https://avatars.githubusercontent.com/u/621238?v=3","gravatar_id":"","url":"https://api.github.com/users/prathamesh-sonpatki","html_url":"https://github.com/prathamesh-sonpatki","followers_url":"https://api.github.com/users/prathamesh-sonpatki/followers","following_url":"https://api.github.com/users/prathamesh-sonpatki/following{/other_user}","gists_url":"https://api.github.com/users/prathamesh-sonpatki/gists{/gist_id}","starred_url":"https://api.github.com/users/prathamesh-sonpatki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prathamesh-sonpatki/subscriptions","organizations_url":"https://api.github.com/users/prathamesh-sonpatki/orgs","repos_url":"https://api.github.com/users/prathamesh-sonpatki/repos","events_url":"https://api.github.com/users/prathamesh-sonpatki/events{/privacy}","received_events_url":"https://api.github.com/users/prathamesh-sonpatki/received_events","type":"User","site_admin":false},"body":"Lets keep this information as it is useful. Can you change the wording as you did below but keep this info?","created_at":"2016-07-26T03:33:57Z","updated_at":"2016-07-26T03:33:57Z","html_url":"https://github.com/rails/rails/pull/25952#discussion_r72183265","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/25952","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/72183265"},"html":{"href":"https://github.com/rails/rails/pull/25952#discussion_r72183265"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/25952"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/25952","id":78729523,"html_url":"https://github.com/rails/rails/pull/25952","diff_url":"https://github.com/rails/rails/pull/25952.diff","patch_url":"https://github.com/rails/rails/pull/25952.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/25952","number":25952,"state":"open","locked":false,"title":"Updated getting_started.md guide source text to reflect the change in error message …","user":{"login":"harfangk","id":545064,"avatar_url":"https://avatars.githubusercontent.com/u/545064?v=3","gravatar_id":"","url":"https://api.github.com/users/harfangk","html_url":"https://github.com/harfangk","followers_url":"https://api.github.com/users/harfangk/followers","following_url":"https://api.github.com/users/harfangk/following{/other_user}","gists_url":"https://api.github.com/users/harfangk/gists{/gist_id}","starred_url":"https://api.github.com/users/harfangk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harfangk/subscriptions","organizations_url":"https://api.github.com/users/harfangk/orgs","repos_url":"https://api.github.com/users/harfangk/repos","events_url":"https://api.github.com/users/harfangk/events{/privacy}","received_events_url":"https://api.github.com/users/harfangk/received_events","type":"User","site_admin":false},"body":"### Summary\r\n\r\nThis is a simple update to the source text for Getting Started portion of the Rails Guide. When the guide discusses the error message in ActionController::UnknownFormat in Articles#new, the error message and explanation text do not match. I guess this is because the error message got updated in Rails 4, but explanation was not. \r\n\r\nI removed the discussion about hash in the error message because the hash is no longer included in the error message, and added description about formats.variants. I also made some minor changes to paragraph structure to make it sound natural after the change.\r\n\r\n…for ActionController::UnknownFromat in ArticlesController#new","created_at":"2016-07-25T18:33:15Z","updated_at":"2016-07-26T03:33:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01202a3224cc1e5ce1152df3a00eadfde3cd92ef","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/25952/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/25952/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/25952/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/de0716f09d973d74f30a23bd692c2ec923612034","head":{"label":"harfangk:master","ref":"master","sha":"de0716f09d973d74f30a23bd692c2ec923612034","user":{"login":"harfangk","id":545064,"avatar_url":"https://avatars.githubusercontent.com/u/545064?v=3","gravatar_id":"","url":"https://api.github.com/users/harfangk","html_url":"https://github.com/harfangk","followers_url":"https://api.github.com/users/harfangk/followers","following_url":"https://api.github.com/users/harfangk/following{/other_user}","gists_url":"https://api.github.com/users/harfangk/gists{/gist_id}","starred_url":"https://api.github.com/users/harfangk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harfangk/subscriptions","organizations_url":"https://api.github.com/users/harfangk/orgs","repos_url":"https://api.github.com/users/harfangk/repos","events_url":"https://api.github.com/users/harfangk/events{/privacy}","received_events_url":"https://api.github.com/users/harfangk/received_events","type":"User","site_admin":false},"repo":{"id":64156615,"name":"rails","full_name":"harfangk/rails","owner":{"login":"harfangk","id":545064,"avatar_url":"https://avatars.githubusercontent.com/u/545064?v=3","gravatar_id":"","url":"https://api.github.com/users/harfangk","html_url":"https://github.com/harfangk","followers_url":"https://api.github.com/users/harfangk/followers","following_url":"https://api.github.com/users/harfangk/following{/other_user}","gists_url":"https://api.github.com/users/harfangk/gists{/gist_id}","starred_url":"https://api.github.com/users/harfangk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harfangk/subscriptions","organizations_url":"https://api.github.com/users/harfangk/orgs","repos_url":"https://api.github.com/users/harfangk/repos","events_url":"https://api.github.com/users/harfangk/events{/privacy}","received_events_url":"https://api.github.com/users/harfangk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harfangk/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/harfangk/rails","forks_url":"https://api.github.com/repos/harfangk/rails/forks","keys_url":"https://api.github.com/repos/harfangk/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harfangk/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harfangk/rails/teams","hooks_url":"https://api.github.com/repos/harfangk/rails/hooks","issue_events_url":"https://api.github.com/repos/harfangk/rails/issues/events{/number}","events_url":"https://api.github.com/repos/harfangk/rails/events","assignees_url":"https://api.github.com/repos/harfangk/rails/assignees{/user}","branches_url":"https://api.github.com/repos/harfangk/rails/branches{/branch}","tags_url":"https://api.github.com/repos/harfangk/rails/tags","blobs_url":"https://api.github.com/repos/harfangk/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harfangk/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harfangk/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/harfangk/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harfangk/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/harfangk/rails/languages","stargazers_url":"https://api.github.com/repos/harfangk/rails/stargazers","contributors_url":"https://api.github.com/repos/harfangk/rails/contributors","subscribers_url":"https://api.github.com/repos/harfangk/rails/subscribers","subscription_url":"https://api.github.com/repos/harfangk/rails/subscription","commits_url":"https://api.github.com/repos/harfangk/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/harfangk/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/harfangk/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/harfangk/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/harfangk/rails/contents/{+path}","compare_url":"https://api.github.com/repos/harfangk/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harfangk/rails/merges","archive_url":"https://api.github.com/repos/harfangk/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harfangk/rails/downloads","issues_url":"https://api.github.com/repos/harfangk/rails/issues{/number}","pulls_url":"https://api.github.com/repos/harfangk/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/harfangk/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/harfangk/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harfangk/rails/labels{/name}","releases_url":"https://api.github.com/repos/harfangk/rails/releases{/id}","deployments_url":"https://api.github.com/repos/harfangk/rails/deployments","created_at":"2016-07-25T18:03:12Z","updated_at":"2016-07-25T18:04:20Z","pushed_at":"2016-07-26T02:15:19Z","git_url":"git://github.com/harfangk/rails.git","ssh_url":"git@github.com:harfangk/rails.git","clone_url":"https://github.com/harfangk/rails.git","svn_url":"https://github.com/harfangk/rails","homepage":"http://rubyonrails.org","size":128669,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"245c64d428279122c5ae2ddfdc4d420a87a88f9a","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","deployments_url":"https://api.github.com/repos/rails/rails/deployments","created_at":"2008-04-11T02:19:47Z","updated_at":"2016-07-26T03:24:12Z","pushed_at":"2016-07-26T02:15:23Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":332309,"stargazers_count":32130,"watchers_count":32130,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13052,"mirror_url":null,"open_issues_count":1117,"forks":13052,"open_issues":1117,"watchers":32130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/25952"},"html":{"href":"https://github.com/rails/rails/pull/25952"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/25952"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/25952/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/25952/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/25952/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/de0716f09d973d74f30a23bd692c2ec923612034"}}}}
{"actor":{"display_login":"prathamesh-sonpatki"}}