{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/60413630","id":60413630,"diff_hunk":"@@ -88,7 +88,7 @@ sudo docker run -d --name=\"origin\" \\\n \t--privileged --net=host --pid=host \\\n \t-v /:/rootfs:ro -v /var/run:/var/run:rw -v /sys:/sys:ro -v /var/lib/docker:/var/lib/docker:rw \\\n \t-v \"${VOLUME_DIR}:${VOLUME_DIR}\" -v \"${VOLUME_DIR}/etcd\":/var/lib/origin/openshift.local.etcd:rw \\\n-\t\"openshift/origin:${TAG}\" start --loglevel=4 --volume-dir=${VOLUME_DIR} --images=\"${USE_IMAGES}\"\n+\t\"openshift/origin:${TAG}\" start --dns=${API_HOST}:53 --loglevel=4 --volume-dir=${VOLUME_DIR} --images=\"${USE_IMAGES}\"","path":"hack/test-end-to-end-docker.sh","position":5,"original_position":5,"commit_id":"102da1b70b5f7ed73e1a082a39423c898fbc6a02","original_commit_id":"102da1b70b5f7ed73e1a082a39423c898fbc6a02","user":{"login":"sgallagher","id":739555,"avatar_url":"https://avatars.githubusercontent.com/u/739555?v=3","gravatar_id":"","url":"https://api.github.com/users/sgallagher","html_url":"https://github.com/sgallagher","followers_url":"https://api.github.com/users/sgallagher/followers","following_url":"https://api.github.com/users/sgallagher/following{/other_user}","gists_url":"https://api.github.com/users/sgallagher/gists{/gist_id}","starred_url":"https://api.github.com/users/sgallagher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgallagher/subscriptions","organizations_url":"https://api.github.com/users/sgallagher/orgs","repos_url":"https://api.github.com/users/sgallagher/repos","events_url":"https://api.github.com/users/sgallagher/events{/privacy}","received_events_url":"https://api.github.com/users/sgallagher/received_events","type":"User","site_admin":false},"body":"Sure, will do.","created_at":"2016-04-20T14:10:18Z","updated_at":"2016-04-20T14:10:18Z","html_url":"https://github.com/openshift/origin/pull/8572#discussion_r60413630","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/8572","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/60413630"},"html":{"href":"https://github.com/openshift/origin/pull/8572#discussion_r60413630"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/8572"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/8572","id":67186897,"html_url":"https://github.com/openshift/origin/pull/8572","diff_url":"https://github.com/openshift/origin/pull/8572.diff","patch_url":"https://github.com/openshift/origin/pull/8572.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/8572","number":8572,"state":"open","locked":false,"title":"[test] end-to-end-docker test: Bind DNS only to API_HOST address","user":{"login":"sgallagher","id":739555,"avatar_url":"https://avatars.githubusercontent.com/u/739555?v=3","gravatar_id":"","url":"https://api.github.com/users/sgallagher","html_url":"https://github.com/sgallagher","followers_url":"https://api.github.com/users/sgallagher/followers","following_url":"https://api.github.com/users/sgallagher/following{/other_user}","gists_url":"https://api.github.com/users/sgallagher/gists{/gist_id}","starred_url":"https://api.github.com/users/sgallagher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgallagher/subscriptions","organizations_url":"https://api.github.com/users/sgallagher/orgs","repos_url":"https://api.github.com/users/sgallagher/repos","events_url":"https://api.github.com/users/sgallagher/events{/privacy}","received_events_url":"https://api.github.com/users/sgallagher/received_events","type":"User","site_admin":false},"body":"These tests fail on many developer systems because the default\r\nconfiguration attempts to bind port 53 on all interfaces. This means\r\nthat systems running libvirt or dnsmasq for local caching will fail\r\nand be unable to run the tests. With this patch, we restrict the DNS\r\nto bind only to the public address of the API_HOST.\r\n\r\nAddresses https://github.com/openshift/origin/issues/8034\r\n\r\nSigned-off-by: Stephen Gallagher <sgallagh@redhat.com>","created_at":"2016-04-20T13:31:57Z","updated_at":"2016-04-20T14:10:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"600dec61a662b158ac53e6362c67f6539795e816","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/8572/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/8572/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/8572/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/102da1b70b5f7ed73e1a082a39423c898fbc6a02","head":{"label":"sgallagher:extended-tests","ref":"extended-tests","sha":"102da1b70b5f7ed73e1a082a39423c898fbc6a02","user":{"login":"sgallagher","id":739555,"avatar_url":"https://avatars.githubusercontent.com/u/739555?v=3","gravatar_id":"","url":"https://api.github.com/users/sgallagher","html_url":"https://github.com/sgallagher","followers_url":"https://api.github.com/users/sgallagher/followers","following_url":"https://api.github.com/users/sgallagher/following{/other_user}","gists_url":"https://api.github.com/users/sgallagher/gists{/gist_id}","starred_url":"https://api.github.com/users/sgallagher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgallagher/subscriptions","organizations_url":"https://api.github.com/users/sgallagher/orgs","repos_url":"https://api.github.com/users/sgallagher/repos","events_url":"https://api.github.com/users/sgallagher/events{/privacy}","received_events_url":"https://api.github.com/users/sgallagher/received_events","type":"User","site_admin":false},"repo":{"id":50381938,"name":"origin","full_name":"sgallagher/origin","owner":{"login":"sgallagher","id":739555,"avatar_url":"https://avatars.githubusercontent.com/u/739555?v=3","gravatar_id":"","url":"https://api.github.com/users/sgallagher","html_url":"https://github.com/sgallagher","followers_url":"https://api.github.com/users/sgallagher/followers","following_url":"https://api.github.com/users/sgallagher/following{/other_user}","gists_url":"https://api.github.com/users/sgallagher/gists{/gist_id}","starred_url":"https://api.github.com/users/sgallagher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgallagher/subscriptions","organizations_url":"https://api.github.com/users/sgallagher/orgs","repos_url":"https://api.github.com/users/sgallagher/repos","events_url":"https://api.github.com/users/sgallagher/events{/privacy}","received_events_url":"https://api.github.com/users/sgallagher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sgallagher/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/sgallagher/origin","forks_url":"https://api.github.com/repos/sgallagher/origin/forks","keys_url":"https://api.github.com/repos/sgallagher/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sgallagher/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sgallagher/origin/teams","hooks_url":"https://api.github.com/repos/sgallagher/origin/hooks","issue_events_url":"https://api.github.com/repos/sgallagher/origin/issues/events{/number}","events_url":"https://api.github.com/repos/sgallagher/origin/events","assignees_url":"https://api.github.com/repos/sgallagher/origin/assignees{/user}","branches_url":"https://api.github.com/repos/sgallagher/origin/branches{/branch}","tags_url":"https://api.github.com/repos/sgallagher/origin/tags","blobs_url":"https://api.github.com/repos/sgallagher/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sgallagher/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sgallagher/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/sgallagher/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sgallagher/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/sgallagher/origin/languages","stargazers_url":"https://api.github.com/repos/sgallagher/origin/stargazers","contributors_url":"https://api.github.com/repos/sgallagher/origin/contributors","subscribers_url":"https://api.github.com/repos/sgallagher/origin/subscribers","subscription_url":"https://api.github.com/repos/sgallagher/origin/subscription","commits_url":"https://api.github.com/repos/sgallagher/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/sgallagher/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/sgallagher/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/sgallagher/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/sgallagher/origin/contents/{+path}","compare_url":"https://api.github.com/repos/sgallagher/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sgallagher/origin/merges","archive_url":"https://api.github.com/repos/sgallagher/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sgallagher/origin/downloads","issues_url":"https://api.github.com/repos/sgallagher/origin/issues{/number}","pulls_url":"https://api.github.com/repos/sgallagher/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/sgallagher/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/sgallagher/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sgallagher/origin/labels{/name}","releases_url":"https://api.github.com/repos/sgallagher/origin/releases{/id}","deployments_url":"https://api.github.com/repos/sgallagher/origin/deployments","created_at":"2016-01-25T21:23:57Z","updated_at":"2016-01-25T21:24:03Z","pushed_at":"2016-04-20T13:31:14Z","git_url":"git://github.com/sgallagher/origin.git","ssh_url":"git@github.com:sgallagher/origin.git","clone_url":"https://github.com/sgallagher/origin.git","svn_url":"https://github.com/sgallagher/origin","homepage":"http://www.openshift.org","size":253227,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"3b1e43dbd7cbff10a5314a4187bee5c18eda3f2a","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"The Continuous Application Platform - build, deploy, and manage cloud-native and legacy applications on Kubernetes and Docker","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-04-20T12:36:25Z","pushed_at":"2016-04-20T14:08:27Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":329912,"stargazers_count":1235,"watchers_count":1235,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":747,"mirror_url":null,"open_issues_count":1024,"forks":747,"open_issues":1024,"watchers":1235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/8572"},"html":{"href":"https://github.com/openshift/origin/pull/8572"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/8572"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/8572/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/8572/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/8572/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/102da1b70b5f7ed73e1a082a39423c898fbc6a02"}}}}