{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-cli/pulls/comments/82405571","pull_request_review_id":3317427,"id":82405571,"diff_hunk":"@@ -16,22 +16,28 @@ class ENDPOINT_URLS: #pylint: disable=too-few-public-methods,old-style-class,no-\n     MANAGEMENT = 'management'\n     ACTIVE_DIRECTORY_AUTHORITY = 'active_directory_authority'\n     ACTIVE_DIRECTORY_GRAPH_RESOURCE_ID = 'active_directory_graph_resource_id'\n+    KEY_VAULT = 'key_vault'\n \n _environments = {\n     ENV_DEFAULT: {\n         ENDPOINT_URLS.MANAGEMENT: 'https://management.core.windows.net/',\n         ENDPOINT_URLS.ACTIVE_DIRECTORY_AUTHORITY : 'https://login.microsoftonline.com',\n-        ENDPOINT_URLS.ACTIVE_DIRECTORY_GRAPH_RESOURCE_ID: 'https://graph.windows.net/'\n+        ENDPOINT_URLS.ACTIVE_DIRECTORY_GRAPH_RESOURCE_ID: 'https://graph.windows.net/',\n+        ENDPOINT_URLS.KEY_VAULT: 'https://vault.azure.net'\n         },\n     ENV_CHINA: {\n         ENDPOINT_URLS.MANAGEMENT: 'https://management.core.chinacloudapi.cn/',\n         ENDPOINT_URLS.ACTIVE_DIRECTORY_AUTHORITY: 'https://login.chinacloudapi.cn',\n-        ENDPOINT_URLS.ACTIVE_DIRECTORY_GRAPH_RESOURCE_ID: 'https://graph.chinacloudapi.cn/'\n+        ENDPOINT_URLS.ACTIVE_DIRECTORY_GRAPH_RESOURCE_ID: 'https://graph.chinacloudapi.cn/',\n+        # TODO: Verify KeyVault endpoint\n+        ENDPOINT_URLS.KEY_VAULT: 'https://vault.chinacloudapi.cn'","path":"src/azure-cli-core/azure/cli/core/_azure_env.py","position":20,"original_position":20,"commit_id":"b1aa0d2e0224cc91c2b7f06cd80fd6b8b85f177d","original_commit_id":"b1aa0d2e0224cc91c2b7f06cd80fd6b8b85f177d","user":{"login":"tjprescott","id":5723682,"avatar_url":"https://avatars.githubusercontent.com/u/5723682?v=3","gravatar_id":"","url":"https://api.github.com/users/tjprescott","html_url":"https://github.com/tjprescott","followers_url":"https://api.github.com/users/tjprescott/followers","following_url":"https://api.github.com/users/tjprescott/following{/other_user}","gists_url":"https://api.github.com/users/tjprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/tjprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjprescott/subscriptions","organizations_url":"https://api.github.com/users/tjprescott/orgs","repos_url":"https://api.github.com/users/tjprescott/repos","events_url":"https://api.github.com/users/tjprescott/events{/privacy}","received_events_url":"https://api.github.com/users/tjprescott/received_events","type":"User","site_admin":false},"body":"@yugangw-msft how do I verify this URL?","created_at":"2016-10-07T14:55:07Z","updated_at":"2016-10-07T14:55:07Z","html_url":"https://github.com/Azure/azure-cli/pull/1037#discussion_r82405571","pull_request_url":"https://api.github.com/repos/Azure/azure-cli/pulls/1037","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/comments/82405571"},"html":{"href":"https://github.com/Azure/azure-cli/pull/1037#discussion_r82405571"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/1037"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-cli/pulls/1037","id":88292460,"html_url":"https://github.com/Azure/azure-cli/pull/1037","diff_url":"https://github.com/Azure/azure-cli/pull/1037.diff","patch_url":"https://github.com/Azure/azure-cli/pull/1037.patch","issue_url":"https://api.github.com/repos/Azure/azure-cli/issues/1037","number":1037,"state":"open","locked":false,"title":"[KeyVault] Onboard KeyVault Round 1","user":{"login":"tjprescott","id":5723682,"avatar_url":"https://avatars.githubusercontent.com/u/5723682?v=3","gravatar_id":"","url":"https://api.github.com/users/tjprescott","html_url":"https://github.com/tjprescott","followers_url":"https://api.github.com/users/tjprescott/followers","following_url":"https://api.github.com/users/tjprescott/following{/other_user}","gists_url":"https://api.github.com/users/tjprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/tjprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjprescott/subscriptions","organizations_url":"https://api.github.com/users/tjprescott/orgs","repos_url":"https://api.github.com/users/tjprescott/repos","events_url":"https://api.github.com/users/tjprescott/events{/privacy}","received_events_url":"https://api.github.com/users/tjprescott/received_events","type":"User","site_admin":false},"body":"This is the first in a series of PRs which will onboard the KeyVault data plane commands. This PR:\r\n\r\n- Updates management plane commands to enable certificates\r\n- Adds majority of commands (and test scenarios) for keys and secrets\r\n- Includes first draft of the Python convenience layer (which does NOT include the authentication piece)\r\n\r\nNote that the client was generated in autorest and will be removed in favor of direct import once the Python SDK is approved and released.\r\n\r\n@yugangw-msft for the changes to profile and @derekbekoe for the changes to the management plane commands. Anyone feel free to drop feedback on the commands themselves. :smile:","created_at":"2016-10-06T16:04:50Z","updated_at":"2016-10-07T14:55:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4aaf8e30d741c67d2f122ba45e82e73369ba53e7","assignee":{"login":"yugangw-msft","id":6014209,"avatar_url":"https://avatars.githubusercontent.com/u/6014209?v=3","gravatar_id":"","url":"https://api.github.com/users/yugangw-msft","html_url":"https://github.com/yugangw-msft","followers_url":"https://api.github.com/users/yugangw-msft/followers","following_url":"https://api.github.com/users/yugangw-msft/following{/other_user}","gists_url":"https://api.github.com/users/yugangw-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/yugangw-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yugangw-msft/subscriptions","organizations_url":"https://api.github.com/users/yugangw-msft/orgs","repos_url":"https://api.github.com/users/yugangw-msft/repos","events_url":"https://api.github.com/users/yugangw-msft/events{/privacy}","received_events_url":"https://api.github.com/users/yugangw-msft/received_events","type":"User","site_admin":false},"assignees":[{"login":"yugangw-msft","id":6014209,"avatar_url":"https://avatars.githubusercontent.com/u/6014209?v=3","gravatar_id":"","url":"https://api.github.com/users/yugangw-msft","html_url":"https://github.com/yugangw-msft","followers_url":"https://api.github.com/users/yugangw-msft/followers","following_url":"https://api.github.com/users/yugangw-msft/following{/other_user}","gists_url":"https://api.github.com/users/yugangw-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/yugangw-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yugangw-msft/subscriptions","organizations_url":"https://api.github.com/users/yugangw-msft/orgs","repos_url":"https://api.github.com/users/yugangw-msft/repos","events_url":"https://api.github.com/users/yugangw-msft/events{/privacy}","received_events_url":"https://api.github.com/users/yugangw-msft/received_events","type":"User","site_admin":false},{"login":"derekbekoe","id":16448634,"avatar_url":"https://avatars.githubusercontent.com/u/16448634?v=3","gravatar_id":"","url":"https://api.github.com/users/derekbekoe","html_url":"https://github.com/derekbekoe","followers_url":"https://api.github.com/users/derekbekoe/followers","following_url":"https://api.github.com/users/derekbekoe/following{/other_user}","gists_url":"https://api.github.com/users/derekbekoe/gists{/gist_id}","starred_url":"https://api.github.com/users/derekbekoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekbekoe/subscriptions","organizations_url":"https://api.github.com/users/derekbekoe/orgs","repos_url":"https://api.github.com/users/derekbekoe/repos","events_url":"https://api.github.com/users/derekbekoe/events{/privacy}","received_events_url":"https://api.github.com/users/derekbekoe/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Azure/azure-cli/milestones/5","html_url":"https://github.com/Azure/azure-cli/milestones/Sprint%204","labels_url":"https://api.github.com/repos/Azure/azure-cli/milestones/5/labels","id":2005073,"number":5,"title":"Sprint 4","description":"","creator":{"login":"mayurid","id":5912228,"avatar_url":"https://avatars.githubusercontent.com/u/5912228?v=3","gravatar_id":"","url":"https://api.github.com/users/mayurid","html_url":"https://github.com/mayurid","followers_url":"https://api.github.com/users/mayurid/followers","following_url":"https://api.github.com/users/mayurid/following{/other_user}","gists_url":"https://api.github.com/users/mayurid/gists{/gist_id}","starred_url":"https://api.github.com/users/mayurid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayurid/subscriptions","organizations_url":"https://api.github.com/users/mayurid/orgs","repos_url":"https://api.github.com/users/mayurid/repos","events_url":"https://api.github.com/users/mayurid/events{/privacy}","received_events_url":"https://api.github.com/users/mayurid/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":15,"state":"open","created_at":"2016-09-14T20:14:37Z","updated_at":"2016-10-07T14:35:07Z","due_on":"2016-10-08T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Azure/azure-cli/pulls/1037/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-cli/pulls/1037/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-cli/issues/1037/comments","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/b1aa0d2e0224cc91c2b7f06cd80fd6b8b85f177d","head":{"label":"tjprescott:KeyVaultDataPlane","ref":"KeyVaultDataPlane","sha":"b1aa0d2e0224cc91c2b7f06cd80fd6b8b85f177d","user":{"login":"tjprescott","id":5723682,"avatar_url":"https://avatars.githubusercontent.com/u/5723682?v=3","gravatar_id":"","url":"https://api.github.com/users/tjprescott","html_url":"https://github.com/tjprescott","followers_url":"https://api.github.com/users/tjprescott/followers","following_url":"https://api.github.com/users/tjprescott/following{/other_user}","gists_url":"https://api.github.com/users/tjprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/tjprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjprescott/subscriptions","organizations_url":"https://api.github.com/users/tjprescott/orgs","repos_url":"https://api.github.com/users/tjprescott/repos","events_url":"https://api.github.com/users/tjprescott/events{/privacy}","received_events_url":"https://api.github.com/users/tjprescott/received_events","type":"User","site_admin":false},"repo":{"id":64678451,"name":"azure-cli","full_name":"tjprescott/azure-cli","owner":{"login":"tjprescott","id":5723682,"avatar_url":"https://avatars.githubusercontent.com/u/5723682?v=3","gravatar_id":"","url":"https://api.github.com/users/tjprescott","html_url":"https://github.com/tjprescott","followers_url":"https://api.github.com/users/tjprescott/followers","following_url":"https://api.github.com/users/tjprescott/following{/other_user}","gists_url":"https://api.github.com/users/tjprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/tjprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjprescott/subscriptions","organizations_url":"https://api.github.com/users/tjprescott/orgs","repos_url":"https://api.github.com/users/tjprescott/repos","events_url":"https://api.github.com/users/tjprescott/events{/privacy}","received_events_url":"https://api.github.com/users/tjprescott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tjprescott/azure-cli","description":"Command-line tools for Azure.","fork":true,"url":"https://api.github.com/repos/tjprescott/azure-cli","forks_url":"https://api.github.com/repos/tjprescott/azure-cli/forks","keys_url":"https://api.github.com/repos/tjprescott/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tjprescott/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tjprescott/azure-cli/teams","hooks_url":"https://api.github.com/repos/tjprescott/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/tjprescott/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/tjprescott/azure-cli/events","assignees_url":"https://api.github.com/repos/tjprescott/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/tjprescott/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/tjprescott/azure-cli/tags","blobs_url":"https://api.github.com/repos/tjprescott/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tjprescott/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tjprescott/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/tjprescott/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tjprescott/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/tjprescott/azure-cli/languages","stargazers_url":"https://api.github.com/repos/tjprescott/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/tjprescott/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/tjprescott/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/tjprescott/azure-cli/subscription","commits_url":"https://api.github.com/repos/tjprescott/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/tjprescott/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/tjprescott/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/tjprescott/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/tjprescott/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/tjprescott/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tjprescott/azure-cli/merges","archive_url":"https://api.github.com/repos/tjprescott/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tjprescott/azure-cli/downloads","issues_url":"https://api.github.com/repos/tjprescott/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/tjprescott/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/tjprescott/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/tjprescott/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tjprescott/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/tjprescott/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/tjprescott/azure-cli/deployments","created_at":"2016-08-01T15:24:25Z","updated_at":"2016-08-01T15:24:28Z","pushed_at":"2016-10-07T14:50:41Z","git_url":"git://github.com/tjprescott/azure-cli.git","ssh_url":"git@github.com:tjprescott/azure-cli.git","clone_url":"https://github.com/tjprescott/azure-cli.git","svn_url":"https://github.com/tjprescott/azure-cli","homepage":null,"size":11311,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"1a82a2487d45d9d70cb43508a77d5e47face066c","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":51040886,"name":"azure-cli","full_name":"Azure/azure-cli","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-cli","description":"Command-line tools for Azure.","fork":false,"url":"https://api.github.com/repos/Azure/azure-cli","forks_url":"https://api.github.com/repos/Azure/azure-cli/forks","keys_url":"https://api.github.com/repos/Azure/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-cli/teams","hooks_url":"https://api.github.com/repos/Azure/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-cli/events","assignees_url":"https://api.github.com/repos/Azure/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-cli/tags","blobs_url":"https://api.github.com/repos/Azure/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-cli/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-cli/subscription","commits_url":"https://api.github.com/repos/Azure/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-cli/merges","archive_url":"https://api.github.com/repos/Azure/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-cli/downloads","issues_url":"https://api.github.com/repos/Azure/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-cli/deployments","created_at":"2016-02-04T00:21:51Z","updated_at":"2016-10-07T13:31:46Z","pushed_at":"2016-10-07T14:50:41Z","git_url":"git://github.com/Azure/azure-cli.git","ssh_url":"git@github.com:Azure/azure-cli.git","clone_url":"https://github.com/Azure/azure-cli.git","svn_url":"https://github.com/Azure/azure-cli","homepage":null,"size":14479,"stargazers_count":163,"watchers_count":163,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":146,"forks":34,"open_issues":146,"watchers":163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/1037"},"html":{"href":"https://github.com/Azure/azure-cli/pull/1037"},"issue":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/1037"},"comments":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/1037/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/1037/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/1037/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-cli/statuses/b1aa0d2e0224cc91c2b7f06cd80fd6b8b85f177d"}}}}
{"actor":{"display_login":"tjprescott"}}