{"action":"created","comment":{"url":"https://api.github.com/repos/convox/rack/pulls/comments/72593230","id":72593230,"diff_hunk":"@@ -23,24 +30,45 @@ type Service struct {\n \tImage       string      `yaml:\"image,omitempty\"`\n \tLabels      Labels      `yaml:\"labels,omitempty\"`\n \tLinks       []string    `yaml:\"links,omitempty\"`\n-\tNetworks    []string    `yaml:\"networks,omitempty\"`\n+\tNetworks    Networks    `yaml:\"-\"`\n \tPorts       Ports       `yaml:\"ports,omitempty\"`\n \tPrivileged  bool        `yaml:\"privileged,omitempty\"`\n \tVolumes     []string    `yaml:\"volumes,omitempty\"`\n+\n+\t//TODO from models manifest, not passive and used at runtime\n+\tExports  map[string]string        `yaml:\"-\"`\n+\tLinkVars map[string]template.HTML `yaml:\"-\"`\n+\n+\tPrimary bool `yaml:\"-\"`\n+\n+\trandoms map[string]int\n }\n \n // see yaml.go for unmarshallers\n type Build struct {\n-\tContext    string\n-\tDockerfile string\n-\tArgs       map[string]string\n+\tContext    string            `yaml:\"context,omitempty\"`\n+\tDockerfile string            `yaml:\"dockerfile,omitempty\"`\n+\tArgs       map[string]string `yaml:\"args,omitempty\"`\n }\n type Command []string\n type Environment map[string]string\n type Labels map[string]string\n \n-func (s *Service) Process(app string) Process {\n-\treturn NewProcess(app, *s)\n+type Networks map[string]InternalNetwork\n+\n+type InternalNetwork map[string]ExternalNetwork","path":"manifest/service.go","position":56,"original_position":56,"commit_id":"6eebfed0a7b5ae3ca604ce9dadd88a68abad085f","original_commit_id":"6eebfed0a7b5ae3ca604ce9dadd88a68abad085f","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"exported type InternalNetwork should have comment or be unexported","created_at":"2016-07-28T09:43:56Z","updated_at":"2016-07-28T09:43:56Z","html_url":"https://github.com/convox/rack/pull/885#discussion_r72593230","pull_request_url":"https://api.github.com/repos/convox/rack/pulls/885","_links":{"self":{"href":"https://api.github.com/repos/convox/rack/pulls/comments/72593230"},"html":{"href":"https://github.com/convox/rack/pull/885#discussion_r72593230"},"pull_request":{"href":"https://api.github.com/repos/convox/rack/pulls/885"}}},"pull_request":{"url":"https://api.github.com/repos/convox/rack/pulls/885","id":78110257,"html_url":"https://github.com/convox/rack/pull/885","diff_url":"https://github.com/convox/rack/pull/885.diff","patch_url":"https://github.com/convox/rack/pull/885.patch","issue_url":"https://api.github.com/repos/convox/rack/issues/885","number":885,"state":"open","locked":false,"title":"[WIP] One manifest to rule them all","user":{"login":"awsmsrc","id":994907,"avatar_url":"https://avatars.githubusercontent.com/u/994907?v=3","gravatar_id":"","url":"https://api.github.com/users/awsmsrc","html_url":"https://github.com/awsmsrc","followers_url":"https://api.github.com/users/awsmsrc/followers","following_url":"https://api.github.com/users/awsmsrc/following{/other_user}","gists_url":"https://api.github.com/users/awsmsrc/gists{/gist_id}","starred_url":"https://api.github.com/users/awsmsrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awsmsrc/subscriptions","organizations_url":"https://api.github.com/users/awsmsrc/orgs","repos_url":"https://api.github.com/users/awsmsrc/repos","events_url":"https://api.github.com/users/awsmsrc/events{/privacy}","received_events_url":"https://api.github.com/users/awsmsrc/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-20T08:53:45Z","updated_at":"2016-07-28T09:43:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b561b0412347a55fc9775a62da84c201d8a0b0e","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/convox/rack/milestones/17","html_url":"https://github.com/convox/rack/milestones/One%20Manifest%20Refactor","labels_url":"https://api.github.com/repos/convox/rack/milestones/17/labels","id":1905288,"number":17,"title":"One Manifest Refactor","description":"","creator":{"login":"MiguelMoll","id":643960,"avatar_url":"https://avatars.githubusercontent.com/u/643960?v=3","gravatar_id":"","url":"https://api.github.com/users/MiguelMoll","html_url":"https://github.com/MiguelMoll","followers_url":"https://api.github.com/users/MiguelMoll/followers","following_url":"https://api.github.com/users/MiguelMoll/following{/other_user}","gists_url":"https://api.github.com/users/MiguelMoll/gists{/gist_id}","starred_url":"https://api.github.com/users/MiguelMoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiguelMoll/subscriptions","organizations_url":"https://api.github.com/users/MiguelMoll/orgs","repos_url":"https://api.github.com/users/MiguelMoll/repos","events_url":"https://api.github.com/users/MiguelMoll/events{/privacy}","received_events_url":"https://api.github.com/users/MiguelMoll/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":4,"state":"open","created_at":"2016-07-26T16:06:10Z","updated_at":"2016-07-28T08:40:16Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/convox/rack/pulls/885/commits","review_comments_url":"https://api.github.com/repos/convox/rack/pulls/885/comments","review_comment_url":"https://api.github.com/repos/convox/rack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/convox/rack/issues/885/comments","statuses_url":"https://api.github.com/repos/convox/rack/statuses/6eebfed0a7b5ae3ca604ce9dadd88a68abad085f","head":{"label":"convox:one_manifest_to_rule_them_all","ref":"one_manifest_to_rule_them_all","sha":"6eebfed0a7b5ae3ca604ce9dadd88a68abad085f","user":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"repo":{"id":42454540,"name":"rack","full_name":"convox/rack","owner":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/convox/rack","description":"Open-source PaaS on AWS","fork":false,"url":"https://api.github.com/repos/convox/rack","forks_url":"https://api.github.com/repos/convox/rack/forks","keys_url":"https://api.github.com/repos/convox/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/convox/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/convox/rack/teams","hooks_url":"https://api.github.com/repos/convox/rack/hooks","issue_events_url":"https://api.github.com/repos/convox/rack/issues/events{/number}","events_url":"https://api.github.com/repos/convox/rack/events","assignees_url":"https://api.github.com/repos/convox/rack/assignees{/user}","branches_url":"https://api.github.com/repos/convox/rack/branches{/branch}","tags_url":"https://api.github.com/repos/convox/rack/tags","blobs_url":"https://api.github.com/repos/convox/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/convox/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/convox/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/convox/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/convox/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/convox/rack/languages","stargazers_url":"https://api.github.com/repos/convox/rack/stargazers","contributors_url":"https://api.github.com/repos/convox/rack/contributors","subscribers_url":"https://api.github.com/repos/convox/rack/subscribers","subscription_url":"https://api.github.com/repos/convox/rack/subscription","commits_url":"https://api.github.com/repos/convox/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/convox/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/convox/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/convox/rack/issues/comments{/number}","contents_url":"https://api.github.com/repos/convox/rack/contents/{+path}","compare_url":"https://api.github.com/repos/convox/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/convox/rack/merges","archive_url":"https://api.github.com/repos/convox/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/convox/rack/downloads","issues_url":"https://api.github.com/repos/convox/rack/issues{/number}","pulls_url":"https://api.github.com/repos/convox/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/convox/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/convox/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/convox/rack/labels{/name}","releases_url":"https://api.github.com/repos/convox/rack/releases{/id}","deployments_url":"https://api.github.com/repos/convox/rack/deployments","created_at":"2015-09-14T14:41:30Z","updated_at":"2016-07-28T03:11:27Z","pushed_at":"2016-07-28T09:43:43Z","git_url":"git://github.com/convox/rack.git","ssh_url":"git@github.com:convox/rack.git","clone_url":"https://github.com/convox/rack.git","svn_url":"https://github.com/convox/rack","homepage":"https://convox.com","size":53656,"stargazers_count":1237,"watchers_count":1237,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"open_issues_count":145,"forks":81,"open_issues":145,"watchers":1237,"default_branch":"master"}},"base":{"label":"convox:master","ref":"master","sha":"e16821d35889bcc9aa9227c14de981587550cfea","user":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"repo":{"id":42454540,"name":"rack","full_name":"convox/rack","owner":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/convox/rack","description":"Open-source PaaS on AWS","fork":false,"url":"https://api.github.com/repos/convox/rack","forks_url":"https://api.github.com/repos/convox/rack/forks","keys_url":"https://api.github.com/repos/convox/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/convox/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/convox/rack/teams","hooks_url":"https://api.github.com/repos/convox/rack/hooks","issue_events_url":"https://api.github.com/repos/convox/rack/issues/events{/number}","events_url":"https://api.github.com/repos/convox/rack/events","assignees_url":"https://api.github.com/repos/convox/rack/assignees{/user}","branches_url":"https://api.github.com/repos/convox/rack/branches{/branch}","tags_url":"https://api.github.com/repos/convox/rack/tags","blobs_url":"https://api.github.com/repos/convox/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/convox/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/convox/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/convox/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/convox/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/convox/rack/languages","stargazers_url":"https://api.github.com/repos/convox/rack/stargazers","contributors_url":"https://api.github.com/repos/convox/rack/contributors","subscribers_url":"https://api.github.com/repos/convox/rack/subscribers","subscription_url":"https://api.github.com/repos/convox/rack/subscription","commits_url":"https://api.github.com/repos/convox/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/convox/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/convox/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/convox/rack/issues/comments{/number}","contents_url":"https://api.github.com/repos/convox/rack/contents/{+path}","compare_url":"https://api.github.com/repos/convox/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/convox/rack/merges","archive_url":"https://api.github.com/repos/convox/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/convox/rack/downloads","issues_url":"https://api.github.com/repos/convox/rack/issues{/number}","pulls_url":"https://api.github.com/repos/convox/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/convox/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/convox/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/convox/rack/labels{/name}","releases_url":"https://api.github.com/repos/convox/rack/releases{/id}","deployments_url":"https://api.github.com/repos/convox/rack/deployments","created_at":"2015-09-14T14:41:30Z","updated_at":"2016-07-28T03:11:27Z","pushed_at":"2016-07-28T09:43:43Z","git_url":"git://github.com/convox/rack.git","ssh_url":"git@github.com:convox/rack.git","clone_url":"https://github.com/convox/rack.git","svn_url":"https://github.com/convox/rack","homepage":"https://convox.com","size":53656,"stargazers_count":1237,"watchers_count":1237,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"open_issues_count":145,"forks":81,"open_issues":145,"watchers":1237,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/convox/rack/pulls/885"},"html":{"href":"https://github.com/convox/rack/pull/885"},"issue":{"href":"https://api.github.com/repos/convox/rack/issues/885"},"comments":{"href":"https://api.github.com/repos/convox/rack/issues/885/comments"},"review_comments":{"href":"https://api.github.com/repos/convox/rack/pulls/885/comments"},"review_comment":{"href":"https://api.github.com/repos/convox/rack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/convox/rack/pulls/885/commits"},"statuses":{"href":"https://api.github.com/repos/convox/rack/statuses/6eebfed0a7b5ae3ca604ce9dadd88a68abad085f"}}}}
{"actor":{"display_login":"houndci-bot"}}