{"action":"opened","number":901,"pull_request":{"url":"https://api.github.com/repos/phpredis/phpredis/pulls/901","id":78458588,"html_url":"https://github.com/phpredis/phpredis/pull/901","diff_url":"https://github.com/phpredis/phpredis/pull/901.diff","patch_url":"https://github.com/phpredis/phpredis/pull/901.patch","issue_url":"https://api.github.com/repos/phpredis/phpredis/issues/901","number":901,"state":"open","locked":false,"title":"BF: fix the 'Timed out attempting...' because of NULL stream using","user":{"login":"JacketWoo","id":8059339,"avatar_url":"https://avatars.githubusercontent.com/u/8059339?v=3","gravatar_id":"","url":"https://api.github.com/users/JacketWoo","html_url":"https://github.com/JacketWoo","followers_url":"https://api.github.com/users/JacketWoo/followers","following_url":"https://api.github.com/users/JacketWoo/following{/other_user}","gists_url":"https://api.github.com/users/JacketWoo/gists{/gist_id}","starred_url":"https://api.github.com/users/JacketWoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacketWoo/subscriptions","organizations_url":"https://api.github.com/users/JacketWoo/orgs","repos_url":"https://api.github.com/users/JacketWoo/repos","events_url":"https://api.github.com/users/JacketWoo/events{/privacy}","received_events_url":"https://api.github.com/users/JacketWoo/received_events","type":"User","site_admin":false},"body":"In our online long connection practice, sometimes there are \"Timed out attempting to find data in the correct node!\" errors (which is report in cluster_library.c:1619)。\r\nThe reason path that causing this error is: when a connection is bad for some reasons, the 'redis_check_eof' procedure in CLUSTER_SEND_PAYLOAD macro will detect the error connection, and rebuild the connection, but if after 10 times tries, the connect cannot still be established, and 'redis_check_eof' procedure will exit with stream being NULL, lazy_connect being 0, status being REDIS_SOCK_STATUS_FAILED, then this connect has no chance to be rebuilded again, even if the connection could be established。\r\nSo I add a stream NULL branch in CLUSTER_LAZY_CONNECT macro， and it works。","created_at":"2016-07-22T10:46:54Z","updated_at":"2016-07-22T10:46:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e084ae4b1a5077e825b88db5c21012e605236f6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/phpredis/phpredis/pulls/901/commits","review_comments_url":"https://api.github.com/repos/phpredis/phpredis/pulls/901/comments","review_comment_url":"https://api.github.com/repos/phpredis/phpredis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phpredis/phpredis/issues/901/comments","statuses_url":"https://api.github.com/repos/phpredis/phpredis/statuses/ece8fcc2f8792070a861a67b53e0558d4b3a289b","head":{"label":"JacketWoo:develop_pr","ref":"develop_pr","sha":"ece8fcc2f8792070a861a67b53e0558d4b3a289b","user":{"login":"JacketWoo","id":8059339,"avatar_url":"https://avatars.githubusercontent.com/u/8059339?v=3","gravatar_id":"","url":"https://api.github.com/users/JacketWoo","html_url":"https://github.com/JacketWoo","followers_url":"https://api.github.com/users/JacketWoo/followers","following_url":"https://api.github.com/users/JacketWoo/following{/other_user}","gists_url":"https://api.github.com/users/JacketWoo/gists{/gist_id}","starred_url":"https://api.github.com/users/JacketWoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacketWoo/subscriptions","organizations_url":"https://api.github.com/users/JacketWoo/orgs","repos_url":"https://api.github.com/users/JacketWoo/repos","events_url":"https://api.github.com/users/JacketWoo/events{/privacy}","received_events_url":"https://api.github.com/users/JacketWoo/received_events","type":"User","site_admin":false},"repo":{"id":60679026,"name":"phpredis","full_name":"JacketWoo/phpredis","owner":{"login":"JacketWoo","id":8059339,"avatar_url":"https://avatars.githubusercontent.com/u/8059339?v=3","gravatar_id":"","url":"https://api.github.com/users/JacketWoo","html_url":"https://github.com/JacketWoo","followers_url":"https://api.github.com/users/JacketWoo/followers","following_url":"https://api.github.com/users/JacketWoo/following{/other_user}","gists_url":"https://api.github.com/users/JacketWoo/gists{/gist_id}","starred_url":"https://api.github.com/users/JacketWoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacketWoo/subscriptions","organizations_url":"https://api.github.com/users/JacketWoo/orgs","repos_url":"https://api.github.com/users/JacketWoo/repos","events_url":"https://api.github.com/users/JacketWoo/events{/privacy}","received_events_url":"https://api.github.com/users/JacketWoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JacketWoo/phpredis","description":"A PHP extension for Redis","fork":true,"url":"https://api.github.com/repos/JacketWoo/phpredis","forks_url":"https://api.github.com/repos/JacketWoo/phpredis/forks","keys_url":"https://api.github.com/repos/JacketWoo/phpredis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JacketWoo/phpredis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JacketWoo/phpredis/teams","hooks_url":"https://api.github.com/repos/JacketWoo/phpredis/hooks","issue_events_url":"https://api.github.com/repos/JacketWoo/phpredis/issues/events{/number}","events_url":"https://api.github.com/repos/JacketWoo/phpredis/events","assignees_url":"https://api.github.com/repos/JacketWoo/phpredis/assignees{/user}","branches_url":"https://api.github.com/repos/JacketWoo/phpredis/branches{/branch}","tags_url":"https://api.github.com/repos/JacketWoo/phpredis/tags","blobs_url":"https://api.github.com/repos/JacketWoo/phpredis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JacketWoo/phpredis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JacketWoo/phpredis/git/refs{/sha}","trees_url":"https://api.github.com/repos/JacketWoo/phpredis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JacketWoo/phpredis/statuses/{sha}","languages_url":"https://api.github.com/repos/JacketWoo/phpredis/languages","stargazers_url":"https://api.github.com/repos/JacketWoo/phpredis/stargazers","contributors_url":"https://api.github.com/repos/JacketWoo/phpredis/contributors","subscribers_url":"https://api.github.com/repos/JacketWoo/phpredis/subscribers","subscription_url":"https://api.github.com/repos/JacketWoo/phpredis/subscription","commits_url":"https://api.github.com/repos/JacketWoo/phpredis/commits{/sha}","git_commits_url":"https://api.github.com/repos/JacketWoo/phpredis/git/commits{/sha}","comments_url":"https://api.github.com/repos/JacketWoo/phpredis/comments{/number}","issue_comment_url":"https://api.github.com/repos/JacketWoo/phpredis/issues/comments{/number}","contents_url":"https://api.github.com/repos/JacketWoo/phpredis/contents/{+path}","compare_url":"https://api.github.com/repos/JacketWoo/phpredis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JacketWoo/phpredis/merges","archive_url":"https://api.github.com/repos/JacketWoo/phpredis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JacketWoo/phpredis/downloads","issues_url":"https://api.github.com/repos/JacketWoo/phpredis/issues{/number}","pulls_url":"https://api.github.com/repos/JacketWoo/phpredis/pulls{/number}","milestones_url":"https://api.github.com/repos/JacketWoo/phpredis/milestones{/number}","notifications_url":"https://api.github.com/repos/JacketWoo/phpredis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JacketWoo/phpredis/labels{/name}","releases_url":"https://api.github.com/repos/JacketWoo/phpredis/releases{/id}","deployments_url":"https://api.github.com/repos/JacketWoo/phpredis/deployments","created_at":"2016-06-08T07:47:36Z","updated_at":"2016-06-08T07:47:38Z","pushed_at":"2016-07-22T10:29:15Z","git_url":"git://github.com/JacketWoo/phpredis.git","ssh_url":"git@github.com:JacketWoo/phpredis.git","clone_url":"https://github.com/JacketWoo/phpredis.git","svn_url":"https://github.com/JacketWoo/phpredis","homepage":"","size":3681,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"phpredis:develop","ref":"develop","sha":"1343d9b12f3fd039629e40ce582e892537d55e3c","user":{"login":"phpredis","id":10171267,"avatar_url":"https://avatars.githubusercontent.com/u/10171267?v=3","gravatar_id":"","url":"https://api.github.com/users/phpredis","html_url":"https://github.com/phpredis","followers_url":"https://api.github.com/users/phpredis/followers","following_url":"https://api.github.com/users/phpredis/following{/other_user}","gists_url":"https://api.github.com/users/phpredis/gists{/gist_id}","starred_url":"https://api.github.com/users/phpredis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpredis/subscriptions","organizations_url":"https://api.github.com/users/phpredis/orgs","repos_url":"https://api.github.com/users/phpredis/repos","events_url":"https://api.github.com/users/phpredis/events{/privacy}","received_events_url":"https://api.github.com/users/phpredis/received_events","type":"Organization","site_admin":false},"repo":{"id":1482997,"name":"phpredis","full_name":"phpredis/phpredis","owner":{"login":"phpredis","id":10171267,"avatar_url":"https://avatars.githubusercontent.com/u/10171267?v=3","gravatar_id":"","url":"https://api.github.com/users/phpredis","html_url":"https://github.com/phpredis","followers_url":"https://api.github.com/users/phpredis/followers","following_url":"https://api.github.com/users/phpredis/following{/other_user}","gists_url":"https://api.github.com/users/phpredis/gists{/gist_id}","starred_url":"https://api.github.com/users/phpredis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpredis/subscriptions","organizations_url":"https://api.github.com/users/phpredis/orgs","repos_url":"https://api.github.com/users/phpredis/repos","events_url":"https://api.github.com/users/phpredis/events{/privacy}","received_events_url":"https://api.github.com/users/phpredis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpredis/phpredis","description":"A PHP extension for Redis","fork":true,"url":"https://api.github.com/repos/phpredis/phpredis","forks_url":"https://api.github.com/repos/phpredis/phpredis/forks","keys_url":"https://api.github.com/repos/phpredis/phpredis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpredis/phpredis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpredis/phpredis/teams","hooks_url":"https://api.github.com/repos/phpredis/phpredis/hooks","issue_events_url":"https://api.github.com/repos/phpredis/phpredis/issues/events{/number}","events_url":"https://api.github.com/repos/phpredis/phpredis/events","assignees_url":"https://api.github.com/repos/phpredis/phpredis/assignees{/user}","branches_url":"https://api.github.com/repos/phpredis/phpredis/branches{/branch}","tags_url":"https://api.github.com/repos/phpredis/phpredis/tags","blobs_url":"https://api.github.com/repos/phpredis/phpredis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpredis/phpredis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpredis/phpredis/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpredis/phpredis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpredis/phpredis/statuses/{sha}","languages_url":"https://api.github.com/repos/phpredis/phpredis/languages","stargazers_url":"https://api.github.com/repos/phpredis/phpredis/stargazers","contributors_url":"https://api.github.com/repos/phpredis/phpredis/contributors","subscribers_url":"https://api.github.com/repos/phpredis/phpredis/subscribers","subscription_url":"https://api.github.com/repos/phpredis/phpredis/subscription","commits_url":"https://api.github.com/repos/phpredis/phpredis/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpredis/phpredis/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpredis/phpredis/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpredis/phpredis/issues/comments{/number}","contents_url":"https://api.github.com/repos/phpredis/phpredis/contents/{+path}","compare_url":"https://api.github.com/repos/phpredis/phpredis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpredis/phpredis/merges","archive_url":"https://api.github.com/repos/phpredis/phpredis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpredis/phpredis/downloads","issues_url":"https://api.github.com/repos/phpredis/phpredis/issues{/number}","pulls_url":"https://api.github.com/repos/phpredis/phpredis/pulls{/number}","milestones_url":"https://api.github.com/repos/phpredis/phpredis/milestones{/number}","notifications_url":"https://api.github.com/repos/phpredis/phpredis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpredis/phpredis/labels{/name}","releases_url":"https://api.github.com/repos/phpredis/phpredis/releases{/id}","deployments_url":"https://api.github.com/repos/phpredis/phpredis/deployments","created_at":"2011-03-15T14:40:14Z","updated_at":"2016-07-22T09:08:18Z","pushed_at":"2016-07-22T10:46:54Z","git_url":"git://github.com/phpredis/phpredis.git","ssh_url":"git@github.com:phpredis/phpredis.git","clone_url":"https://github.com/phpredis/phpredis.git","svn_url":"https://github.com/phpredis/phpredis","homepage":"","size":6207,"stargazers_count":4014,"watchers_count":4014,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1188,"mirror_url":null,"open_issues_count":269,"forks":1188,"open_issues":269,"watchers":4014,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/phpredis/phpredis/pulls/901"},"html":{"href":"https://github.com/phpredis/phpredis/pull/901"},"issue":{"href":"https://api.github.com/repos/phpredis/phpredis/issues/901"},"comments":{"href":"https://api.github.com/repos/phpredis/phpredis/issues/901/comments"},"review_comments":{"href":"https://api.github.com/repos/phpredis/phpredis/pulls/901/comments"},"review_comment":{"href":"https://api.github.com/repos/phpredis/phpredis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phpredis/phpredis/pulls/901/commits"},"statuses":{"href":"https://api.github.com/repos/phpredis/phpredis/statuses/ece8fcc2f8792070a861a67b53e0558d4b3a289b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"JacketWoo"}}