{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/64290241","id":64290241,"diff_hunk":"@@ -0,0 +1,207 @@\n+/*\n+Copyright 2016 The Kubernetes Authors All rights reserved.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package certificates\n+\n+import (\n+\t\"crypto/x509\"\n+\t\"encoding/base64\"\n+\t\"encoding/pem\"\n+\t\"fmt\"\n+\n+\t\"github.com/golang/glog\"\n+\n+\t\"k8s.io/kubernetes/pkg/api\"\n+\t\"k8s.io/kubernetes/pkg/apis/certificates\"\n+\t\"k8s.io/kubernetes/pkg/apis/certificates/validation\"\n+\t\"k8s.io/kubernetes/pkg/fields\"\n+\t\"k8s.io/kubernetes/pkg/labels\"\n+\t\"k8s.io/kubernetes/pkg/registry/generic\"\n+\t\"k8s.io/kubernetes/pkg/runtime\"\n+\t\"k8s.io/kubernetes/pkg/util/validation/field\"\n+)\n+\n+// csrStrategy implements behavior for CSRs\n+type csrStrategy struct {\n+\truntime.ObjectTyper\n+\tapi.NameGenerator\n+}\n+\n+// csrStrategy is the default logic that applies when creating and updating\n+// CSR objects.\n+var Strategy = csrStrategy{api.Scheme, api.SimpleNameGenerator}\n+\n+// NamespaceScoped is true for CSRs.\n+func (csrStrategy) NamespaceScoped() bool {\n+\treturn true","path":"pkg/registry/certificates/strategy.go","position":47,"original_position":49,"commit_id":"4251588bca45575aa849c48c5a20c839db0a4c24","original_commit_id":"afed65aae2c99893dc2593a3691614ea9cfe6733","user":{"login":"gtank","id":622063,"avatar_url":"https://avatars.githubusercontent.com/u/622063?v=3","gravatar_id":"","url":"https://api.github.com/users/gtank","html_url":"https://github.com/gtank","followers_url":"https://api.github.com/users/gtank/followers","following_url":"https://api.github.com/users/gtank/following{/other_user}","gists_url":"https://api.github.com/users/gtank/gists{/gist_id}","starred_url":"https://api.github.com/users/gtank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtank/subscriptions","organizations_url":"https://api.github.com/users/gtank/orgs","repos_url":"https://api.github.com/users/gtank/repos","events_url":"https://api.github.com/users/gtank/events{/privacy}","received_events_url":"https://api.github.com/users/gtank/received_events","type":"User","site_admin":false},"body":"I agree, and think this should be determined in node flags rather than hard coded. Perhaps `kube-system` by convention, but leaving the option to do namespaced certificate approval or even hand off to a third party tool?","created_at":"2016-05-23T21:13:44Z","updated_at":"2016-05-23T21:13:44Z","html_url":"https://github.com/kubernetes/kubernetes/pull/25562#discussion_r64290241","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25562","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/64290241"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25562#discussion_r64290241"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25562"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25562","id":69947604,"html_url":"https://github.com/kubernetes/kubernetes/pull/25562","diff_url":"https://github.com/kubernetes/kubernetes/pull/25562.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/25562.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25562","number":25562,"state":"open","locked":false,"title":"TLS bootstrap API group (alpha)","user":{"login":"gtank","id":622063,"avatar_url":"https://avatars.githubusercontent.com/u/622063?v=3","gravatar_id":"","url":"https://api.github.com/users/gtank","html_url":"https://github.com/gtank","followers_url":"https://api.github.com/users/gtank/followers","following_url":"https://api.github.com/users/gtank/following{/other_user}","gists_url":"https://api.github.com/users/gtank/gists{/gist_id}","starred_url":"https://api.github.com/users/gtank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtank/subscriptions","organizations_url":"https://api.github.com/users/gtank/orgs","repos_url":"https://api.github.com/users/gtank/repos","events_url":"https://api.github.com/users/gtank/events{/privacy}","received_events_url":"https://api.github.com/users/gtank/received_events","type":"User","site_admin":false},"body":"This PR only covers the new types and related client/storage code- the vast majority of the line count is codegen. The implementation differs slightly from the current proposal document based on discussions in design thread (#20439). The controller logic and kubelet support mentioned in the proposal are forthcoming in separate requests.\r\n\r\nI submit that #18762 (\"Creating a new API group is really hard\") is, if anything, understating it. I've tried to structure the commits to illustrate the process.\r\n\r\n@mikedanese @erictune @smarterclayton @deads2k\r\n\r\n```release-note-experimental\r\nAn alpha implementation of the the TLS bootstrap API described in docs/proposals/kubelet-tls-bootstrap.md.\r\n```\r\n\r\n[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/.github/PULL_REQUEST_TEMPLATE.md?pixel)]()","created_at":"2016-05-13T06:11:17Z","updated_at":"2016-05-23T21:13:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c847a89d34dab8693a88764687bdf110e74f8d5","assignee":{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25562/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25562/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25562/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/4251588bca45575aa849c48c5a20c839db0a4c24","head":{"label":"gtank:certificates-api-v9","ref":"certificates-api-v9","sha":"4251588bca45575aa849c48c5a20c839db0a4c24","user":{"login":"gtank","id":622063,"avatar_url":"https://avatars.githubusercontent.com/u/622063?v=3","gravatar_id":"","url":"https://api.github.com/users/gtank","html_url":"https://github.com/gtank","followers_url":"https://api.github.com/users/gtank/followers","following_url":"https://api.github.com/users/gtank/following{/other_user}","gists_url":"https://api.github.com/users/gtank/gists{/gist_id}","starred_url":"https://api.github.com/users/gtank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtank/subscriptions","organizations_url":"https://api.github.com/users/gtank/orgs","repos_url":"https://api.github.com/users/gtank/repos","events_url":"https://api.github.com/users/gtank/events{/privacy}","received_events_url":"https://api.github.com/users/gtank/received_events","type":"User","site_admin":false},"repo":{"id":50872973,"name":"kubernetes","full_name":"gtank/kubernetes","owner":{"login":"gtank","id":622063,"avatar_url":"https://avatars.githubusercontent.com/u/622063?v=3","gravatar_id":"","url":"https://api.github.com/users/gtank","html_url":"https://github.com/gtank","followers_url":"https://api.github.com/users/gtank/followers","following_url":"https://api.github.com/users/gtank/following{/other_user}","gists_url":"https://api.github.com/users/gtank/gists{/gist_id}","starred_url":"https://api.github.com/users/gtank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtank/subscriptions","organizations_url":"https://api.github.com/users/gtank/orgs","repos_url":"https://api.github.com/users/gtank/repos","events_url":"https://api.github.com/users/gtank/events{/privacy}","received_events_url":"https://api.github.com/users/gtank/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gtank/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/gtank/kubernetes","forks_url":"https://api.github.com/repos/gtank/kubernetes/forks","keys_url":"https://api.github.com/repos/gtank/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gtank/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gtank/kubernetes/teams","hooks_url":"https://api.github.com/repos/gtank/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/gtank/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/gtank/kubernetes/events","assignees_url":"https://api.github.com/repos/gtank/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/gtank/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/gtank/kubernetes/tags","blobs_url":"https://api.github.com/repos/gtank/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gtank/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gtank/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/gtank/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gtank/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/gtank/kubernetes/languages","stargazers_url":"https://api.github.com/repos/gtank/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/gtank/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/gtank/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/gtank/kubernetes/subscription","commits_url":"https://api.github.com/repos/gtank/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/gtank/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/gtank/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/gtank/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/gtank/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/gtank/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gtank/kubernetes/merges","archive_url":"https://api.github.com/repos/gtank/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gtank/kubernetes/downloads","issues_url":"https://api.github.com/repos/gtank/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/gtank/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/gtank/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/gtank/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gtank/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/gtank/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/gtank/kubernetes/deployments","created_at":"2016-02-01T21:36:29Z","updated_at":"2016-02-01T21:36:41Z","pushed_at":"2016-05-17T18:12:11Z","git_url":"git://github.com/gtank/kubernetes.git","ssh_url":"git@github.com:gtank/kubernetes.git","clone_url":"https://github.com/gtank/kubernetes.git","svn_url":"https://github.com/gtank/kubernetes","homepage":"http://kubernetes.io","size":197495,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"11cd07ef2240238f09954159b05a80989aa008ae","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-05-23T20:40:00Z","pushed_at":"2016-05-23T21:13:11Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":446407,"stargazers_count":14518,"watchers_count":14518,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4411,"mirror_url":null,"open_issues_count":3611,"forks":4411,"open_issues":3611,"watchers":14518,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25562"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25562"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25562"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25562/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25562/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25562/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/4251588bca45575aa849c48c5a20c839db0a4c24"}}}}
{"actor":{"display_login":"gtank"}}