{"action":"created","comment":{"url":"https://api.github.com/repos/Kitware/CMake/pulls/comments/66446355","id":66446355,"diff_hunk":"@@ -197,10 +198,11 @@ function(PROTOBUF_GENERATE_PYTHON SRCS)\n   foreach(FIL ${ARGN})\n     get_filename_component(ABS_FIL ${FIL} ABSOLUTE)","path":"Modules/FindProtobuf.cmake","position":2,"original_position":21,"commit_id":"e3c1e47f9f707c257a4a3aae2e821c8e99b28e94","original_commit_id":"e3c1e47f9f707c257a4a3aae2e821c8e99b28e94","user":{"login":"bradking","id":87268,"avatar_url":"https://avatars.githubusercontent.com/u/87268?v=3","gravatar_id":"","url":"https://api.github.com/users/bradking","html_url":"https://github.com/bradking","followers_url":"https://api.github.com/users/bradking/followers","following_url":"https://api.github.com/users/bradking/following{/other_user}","gists_url":"https://api.github.com/users/bradking/gists{/gist_id}","starred_url":"https://api.github.com/users/bradking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradking/subscriptions","organizations_url":"https://api.github.com/users/bradking/orgs","repos_url":"https://api.github.com/users/bradking/repos","events_url":"https://api.github.com/users/bradking/events{/privacy}","received_events_url":"https://api.github.com/users/bradking/received_events","type":"User","site_admin":false},"body":"In the case that there is not a subdirectory path, this may generate double slashes.  Please revise to avoid that.\r\n","created_at":"2016-06-09T14:03:24Z","updated_at":"2016-06-09T14:03:24Z","html_url":"https://github.com/Kitware/CMake/pull/252#discussion_r66446355","pull_request_url":"https://api.github.com/repos/Kitware/CMake/pulls/252","_links":{"self":{"href":"https://api.github.com/repos/Kitware/CMake/pulls/comments/66446355"},"html":{"href":"https://github.com/Kitware/CMake/pull/252#discussion_r66446355"},"pull_request":{"href":"https://api.github.com/repos/Kitware/CMake/pulls/252"}}},"pull_request":{"url":"https://api.github.com/repos/Kitware/CMake/pulls/252","id":73204102,"html_url":"https://github.com/Kitware/CMake/pull/252","diff_url":"https://github.com/Kitware/CMake/pull/252.diff","patch_url":"https://github.com/Kitware/CMake/pull/252.patch","issue_url":"https://api.github.com/repos/Kitware/CMake/issues/252","number":252,"state":"open","locked":false,"title":"FindProtobuf: make protobuf_generate_*() work with subdirectories.","user":{"login":"mosra","id":344828,"avatar_url":"https://avatars.githubusercontent.com/u/344828?v=3","gravatar_id":"","url":"https://api.github.com/users/mosra","html_url":"https://github.com/mosra","followers_url":"https://api.github.com/users/mosra/followers","following_url":"https://api.github.com/users/mosra/following{/other_user}","gists_url":"https://api.github.com/users/mosra/gists{/gist_id}","starred_url":"https://api.github.com/users/mosra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosra/subscriptions","organizations_url":"https://api.github.com/users/mosra/orgs","repos_url":"https://api.github.com/users/mosra/repos","events_url":"https://api.github.com/users/mosra/events{/privacy}","received_events_url":"https://api.github.com/users/mosra/received_events","type":"User","site_admin":false},"body":"This now works flawlessly when I have `*.proto` files in subdirectories and pass them to `protobuf_generate_cpp()` like this:\r\n```cmake\r\nprotobuf_generate_cpp(App_PB_SRCS App_PB_HEADERS\r\n    services/general.proto\r\n    services/app.proto)\r\n```\r\n\r\nDid not encounter any other limitations that would prevent this to work, so I also removed the note from the documentation.","created_at":"2016-06-09T12:23:49Z","updated_at":"2016-06-09T14:03:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4170da299ba90cbf1eba3e07db72a4068bba9e5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Kitware/CMake/pulls/252/commits","review_comments_url":"https://api.github.com/repos/Kitware/CMake/pulls/252/comments","review_comment_url":"https://api.github.com/repos/Kitware/CMake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kitware/CMake/issues/252/comments","statuses_url":"https://api.github.com/repos/Kitware/CMake/statuses/e3c1e47f9f707c257a4a3aae2e821c8e99b28e94","head":{"label":"mosra:findprotobuf-subdirectories-fix","ref":"findprotobuf-subdirectories-fix","sha":"e3c1e47f9f707c257a4a3aae2e821c8e99b28e94","user":{"login":"mosra","id":344828,"avatar_url":"https://avatars.githubusercontent.com/u/344828?v=3","gravatar_id":"","url":"https://api.github.com/users/mosra","html_url":"https://github.com/mosra","followers_url":"https://api.github.com/users/mosra/followers","following_url":"https://api.github.com/users/mosra/following{/other_user}","gists_url":"https://api.github.com/users/mosra/gists{/gist_id}","starred_url":"https://api.github.com/users/mosra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosra/subscriptions","organizations_url":"https://api.github.com/users/mosra/orgs","repos_url":"https://api.github.com/users/mosra/repos","events_url":"https://api.github.com/users/mosra/events{/privacy}","received_events_url":"https://api.github.com/users/mosra/received_events","type":"User","site_admin":false},"repo":{"id":60771539,"name":"CMake","full_name":"mosra/CMake","owner":{"login":"mosra","id":344828,"avatar_url":"https://avatars.githubusercontent.com/u/344828?v=3","gravatar_id":"","url":"https://api.github.com/users/mosra","html_url":"https://github.com/mosra","followers_url":"https://api.github.com/users/mosra/followers","following_url":"https://api.github.com/users/mosra/following{/other_user}","gists_url":"https://api.github.com/users/mosra/gists{/gist_id}","starred_url":"https://api.github.com/users/mosra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosra/subscriptions","organizations_url":"https://api.github.com/users/mosra/orgs","repos_url":"https://api.github.com/users/mosra/repos","events_url":"https://api.github.com/users/mosra/events{/privacy}","received_events_url":"https://api.github.com/users/mosra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mosra/CMake","description":"CMake, the cross-platform, open-source build system.","fork":true,"url":"https://api.github.com/repos/mosra/CMake","forks_url":"https://api.github.com/repos/mosra/CMake/forks","keys_url":"https://api.github.com/repos/mosra/CMake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mosra/CMake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mosra/CMake/teams","hooks_url":"https://api.github.com/repos/mosra/CMake/hooks","issue_events_url":"https://api.github.com/repos/mosra/CMake/issues/events{/number}","events_url":"https://api.github.com/repos/mosra/CMake/events","assignees_url":"https://api.github.com/repos/mosra/CMake/assignees{/user}","branches_url":"https://api.github.com/repos/mosra/CMake/branches{/branch}","tags_url":"https://api.github.com/repos/mosra/CMake/tags","blobs_url":"https://api.github.com/repos/mosra/CMake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mosra/CMake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mosra/CMake/git/refs{/sha}","trees_url":"https://api.github.com/repos/mosra/CMake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mosra/CMake/statuses/{sha}","languages_url":"https://api.github.com/repos/mosra/CMake/languages","stargazers_url":"https://api.github.com/repos/mosra/CMake/stargazers","contributors_url":"https://api.github.com/repos/mosra/CMake/contributors","subscribers_url":"https://api.github.com/repos/mosra/CMake/subscribers","subscription_url":"https://api.github.com/repos/mosra/CMake/subscription","commits_url":"https://api.github.com/repos/mosra/CMake/commits{/sha}","git_commits_url":"https://api.github.com/repos/mosra/CMake/git/commits{/sha}","comments_url":"https://api.github.com/repos/mosra/CMake/comments{/number}","issue_comment_url":"https://api.github.com/repos/mosra/CMake/issues/comments{/number}","contents_url":"https://api.github.com/repos/mosra/CMake/contents/{+path}","compare_url":"https://api.github.com/repos/mosra/CMake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mosra/CMake/merges","archive_url":"https://api.github.com/repos/mosra/CMake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mosra/CMake/downloads","issues_url":"https://api.github.com/repos/mosra/CMake/issues{/number}","pulls_url":"https://api.github.com/repos/mosra/CMake/pulls{/number}","milestones_url":"https://api.github.com/repos/mosra/CMake/milestones{/number}","notifications_url":"https://api.github.com/repos/mosra/CMake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mosra/CMake/labels{/name}","releases_url":"https://api.github.com/repos/mosra/CMake/releases{/id}","deployments_url":"https://api.github.com/repos/mosra/CMake/deployments","created_at":"2016-06-09T12:00:26Z","updated_at":"2016-06-09T12:00:46Z","pushed_at":"2016-06-09T13:55:02Z","git_url":"git://github.com/mosra/CMake.git","ssh_url":"git@github.com:mosra/CMake.git","clone_url":"https://github.com/mosra/CMake.git","svn_url":"https://github.com/mosra/CMake","homepage":"http://www.cmake.org","size":70582,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Kitware:master","ref":"master","sha":"8f3bd1f454fe50a641fd9666ca5e5bc8064c09c7","user":{"login":"Kitware","id":87549,"avatar_url":"https://avatars.githubusercontent.com/u/87549?v=3","gravatar_id":"","url":"https://api.github.com/users/Kitware","html_url":"https://github.com/Kitware","followers_url":"https://api.github.com/users/Kitware/followers","following_url":"https://api.github.com/users/Kitware/following{/other_user}","gists_url":"https://api.github.com/users/Kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/Kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kitware/subscriptions","organizations_url":"https://api.github.com/users/Kitware/orgs","repos_url":"https://api.github.com/users/Kitware/repos","events_url":"https://api.github.com/users/Kitware/events{/privacy}","received_events_url":"https://api.github.com/users/Kitware/received_events","type":"Organization","site_admin":false},"repo":{"id":537699,"name":"CMake","full_name":"Kitware/CMake","owner":{"login":"Kitware","id":87549,"avatar_url":"https://avatars.githubusercontent.com/u/87549?v=3","gravatar_id":"","url":"https://api.github.com/users/Kitware","html_url":"https://github.com/Kitware","followers_url":"https://api.github.com/users/Kitware/followers","following_url":"https://api.github.com/users/Kitware/following{/other_user}","gists_url":"https://api.github.com/users/Kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/Kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kitware/subscriptions","organizations_url":"https://api.github.com/users/Kitware/orgs","repos_url":"https://api.github.com/users/Kitware/repos","events_url":"https://api.github.com/users/Kitware/events{/privacy}","received_events_url":"https://api.github.com/users/Kitware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kitware/CMake","description":"CMake, the cross-platform, open-source build system.","fork":false,"url":"https://api.github.com/repos/Kitware/CMake","forks_url":"https://api.github.com/repos/Kitware/CMake/forks","keys_url":"https://api.github.com/repos/Kitware/CMake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kitware/CMake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kitware/CMake/teams","hooks_url":"https://api.github.com/repos/Kitware/CMake/hooks","issue_events_url":"https://api.github.com/repos/Kitware/CMake/issues/events{/number}","events_url":"https://api.github.com/repos/Kitware/CMake/events","assignees_url":"https://api.github.com/repos/Kitware/CMake/assignees{/user}","branches_url":"https://api.github.com/repos/Kitware/CMake/branches{/branch}","tags_url":"https://api.github.com/repos/Kitware/CMake/tags","blobs_url":"https://api.github.com/repos/Kitware/CMake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kitware/CMake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kitware/CMake/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kitware/CMake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kitware/CMake/statuses/{sha}","languages_url":"https://api.github.com/repos/Kitware/CMake/languages","stargazers_url":"https://api.github.com/repos/Kitware/CMake/stargazers","contributors_url":"https://api.github.com/repos/Kitware/CMake/contributors","subscribers_url":"https://api.github.com/repos/Kitware/CMake/subscribers","subscription_url":"https://api.github.com/repos/Kitware/CMake/subscription","commits_url":"https://api.github.com/repos/Kitware/CMake/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kitware/CMake/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kitware/CMake/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kitware/CMake/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kitware/CMake/contents/{+path}","compare_url":"https://api.github.com/repos/Kitware/CMake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kitware/CMake/merges","archive_url":"https://api.github.com/repos/Kitware/CMake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kitware/CMake/downloads","issues_url":"https://api.github.com/repos/Kitware/CMake/issues{/number}","pulls_url":"https://api.github.com/repos/Kitware/CMake/pulls{/number}","milestones_url":"https://api.github.com/repos/Kitware/CMake/milestones{/number}","notifications_url":"https://api.github.com/repos/Kitware/CMake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kitware/CMake/labels{/name}","releases_url":"https://api.github.com/repos/Kitware/CMake/releases{/id}","deployments_url":"https://api.github.com/repos/Kitware/CMake/deployments","created_at":"2010-02-26T18:26:53Z","updated_at":"2016-06-09T11:42:30Z","pushed_at":"2016-06-09T13:55:07Z","git_url":"git://github.com/Kitware/CMake.git","ssh_url":"git@github.com:Kitware/CMake.git","clone_url":"https://github.com/Kitware/CMake.git","svn_url":"https://github.com/Kitware/CMake","homepage":"http://www.cmake.org","size":144283,"stargazers_count":928,"watchers_count":928,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":526,"mirror_url":null,"open_issues_count":7,"forks":526,"open_issues":7,"watchers":928,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kitware/CMake/pulls/252"},"html":{"href":"https://github.com/Kitware/CMake/pull/252"},"issue":{"href":"https://api.github.com/repos/Kitware/CMake/issues/252"},"comments":{"href":"https://api.github.com/repos/Kitware/CMake/issues/252/comments"},"review_comments":{"href":"https://api.github.com/repos/Kitware/CMake/pulls/252/comments"},"review_comment":{"href":"https://api.github.com/repos/Kitware/CMake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kitware/CMake/pulls/252/commits"},"statuses":{"href":"https://api.github.com/repos/Kitware/CMake/statuses/e3c1e47f9f707c257a4a3aae2e821c8e99b28e94"}}}}
{"actor":{"display_login":"bradking"}}