{"action":"created","issue":{"url":"https://api.github.com/repos/Talend/data-prep/issues/366","repository_url":"https://api.github.com/repos/Talend/data-prep","labels_url":"https://api.github.com/repos/Talend/data-prep/issues/366/labels{/name}","comments_url":"https://api.github.com/repos/Talend/data-prep/issues/366/comments","events_url":"https://api.github.com/repos/Talend/data-prep/issues/366/events","html_url":"https://github.com/Talend/data-prep/pull/366","id":193808150,"number":366,"title":"fix(TDP-2936): fixed the show modal condition","user":{"login":"amaalej","id":12463931,"avatar_url":"https://avatars.githubusercontent.com/u/12463931?v=3","gravatar_id":"","url":"https://api.github.com/users/amaalej","html_url":"https://github.com/amaalej","followers_url":"https://api.github.com/users/amaalej/followers","following_url":"https://api.github.com/users/amaalej/following{/other_user}","gists_url":"https://api.github.com/users/amaalej/gists{/gist_id}","starred_url":"https://api.github.com/users/amaalej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaalej/subscriptions","organizations_url":"https://api.github.com/users/amaalej/orgs","repos_url":"https://api.github.com/users/amaalej/repos","events_url":"https://api.github.com/users/amaalej/events{/privacy}","received_events_url":"https://api.github.com/users/amaalej/received_events","type":"User","site_admin":false},"labels":[{"id":447624830,"url":"https://api.github.com/repos/Talend/data-prep/labels/frontend","name":"frontend","color":"5319e7","default":false},{"id":447624534,"url":"https://api.github.com/repos/Talend/data-prep/labels/need%20review","name":"need review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"charlesnguyen","id":13314851,"avatar_url":"https://avatars.githubusercontent.com/u/13314851?v=3","gravatar_id":"","url":"https://api.github.com/users/charlesnguyen","html_url":"https://github.com/charlesnguyen","followers_url":"https://api.github.com/users/charlesnguyen/followers","following_url":"https://api.github.com/users/charlesnguyen/following{/other_user}","gists_url":"https://api.github.com/users/charlesnguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesnguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesnguyen/subscriptions","organizations_url":"https://api.github.com/users/charlesnguyen/orgs","repos_url":"https://api.github.com/users/charlesnguyen/repos","events_url":"https://api.github.com/users/charlesnguyen/events{/privacy}","received_events_url":"https://api.github.com/users/charlesnguyen/received_events","type":"User","site_admin":false},"assignees":[{"login":"charlesnguyen","id":13314851,"avatar_url":"https://avatars.githubusercontent.com/u/13314851?v=3","gravatar_id":"","url":"https://api.github.com/users/charlesnguyen","html_url":"https://github.com/charlesnguyen","followers_url":"https://api.github.com/users/charlesnguyen/followers","following_url":"https://api.github.com/users/charlesnguyen/following{/other_user}","gists_url":"https://api.github.com/users/charlesnguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesnguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesnguyen/subscriptions","organizations_url":"https://api.github.com/users/charlesnguyen/orgs","repos_url":"https://api.github.com/users/charlesnguyen/repos","events_url":"https://api.github.com/users/charlesnguyen/events{/privacy}","received_events_url":"https://api.github.com/users/charlesnguyen/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-12-06T15:51:43Z","updated_at":"2016-12-07T13:38:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Talend/data-prep/pulls/366","html_url":"https://github.com/Talend/data-prep/pull/366","diff_url":"https://github.com/Talend/data-prep/pull/366.diff","patch_url":"https://github.com/Talend/data-prep/pull/366.patch"},"body":"**Link to the JIRA issue**\r\nhttps://jira.talendforge.org/browse/TDP-2936\r\n\r\n**Please check if the PR fulfills these requirements**\r\n- [x] The commit(s) message(s) follows our [guidelines](https://github.com/talend/tools/blob/master/tools-root-github/CONTRIBUTING.md#commit-message-format)\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n- [ ] The code coverage on new code is > 75 % for backend and > 95% for frontend\r\n- [x] The new code does not introduce new technical issues (sonar / eslint)\r\n- [x] Functional tests have been performed\r\n\r\n**Please check the browsers you've tested on**\r\n- [ ] Chrome, Firefox, Safari, Edge, IE11\r\n- [ ] No, that's bad, this PR should not be merged !\r\n- [x] No, and no need to\r\n\r\n**(Optional) What is the current behavior?**\r\nThe group similar modal was always displayed du to wrong ng-if condition.\r\n\r\n**(Optional) What is the new behavior?**\r\nThe group similar modal disappears when not clicked."},"comment":{"url":"https://api.github.com/repos/Talend/data-prep/issues/comments/265448940","html_url":"https://github.com/Talend/data-prep/pull/366#issuecomment-265448940","issue_url":"https://api.github.com/repos/Talend/data-prep/issues/366","id":265448940,"user":{"login":"amaalej","id":12463931,"avatar_url":"https://avatars.githubusercontent.com/u/12463931?v=3","gravatar_id":"","url":"https://api.github.com/users/amaalej","html_url":"https://github.com/amaalej","followers_url":"https://api.github.com/users/amaalej/followers","following_url":"https://api.github.com/users/amaalej/following{/other_user}","gists_url":"https://api.github.com/users/amaalej/gists{/gist_id}","starred_url":"https://api.github.com/users/amaalej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaalej/subscriptions","organizations_url":"https://api.github.com/users/amaalej/orgs","repos_url":"https://api.github.com/users/amaalej/repos","events_url":"https://api.github.com/users/amaalej/events{/privacy}","received_events_url":"https://api.github.com/users/amaalej/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T13:38:25Z","updated_at":"2016-12-07T13:38:25Z","body":"@charlesnguyen I fixed the TU, however fixing the display issue was not that quick so I created a jira issue (TDP-3077)."}}
{"actor":{"display_login":"amaalej"}}