{"action":"opened","number":4297,"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/4297","id":88231015,"html_url":"https://github.com/systemd/systemd/pull/4297","diff_url":"https://github.com/systemd/systemd/pull/4297.diff","patch_url":"https://github.com/systemd/systemd/pull/4297.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/4297","number":4297,"state":"open","locked":false,"title":"Ensure mount unit goes into failed state when mount command times out","user":{"login":"edolstra","id":1148549,"avatar_url":"https://avatars.githubusercontent.com/u/1148549?v=3","gravatar_id":"","url":"https://api.github.com/users/edolstra","html_url":"https://github.com/edolstra","followers_url":"https://api.github.com/users/edolstra/followers","following_url":"https://api.github.com/users/edolstra/following{/other_user}","gists_url":"https://api.github.com/users/edolstra/gists{/gist_id}","starred_url":"https://api.github.com/users/edolstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edolstra/subscriptions","organizations_url":"https://api.github.com/users/edolstra/orgs","repos_url":"https://api.github.com/users/edolstra/repos","events_url":"https://api.github.com/users/edolstra/events{/privacy}","received_events_url":"https://api.github.com/users/edolstra/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/systemd/systemd/issues/4275.\r\n\r\nThe problem here is that while mount_dispatch_timer() sets m->result to\r\nMOUNT_FAILURE_TIMEOUT, this is then overwritten by mount_sigchld_event() to\r\nMOUNT_SUCCESS. This is because of\r\n\r\n        if (is_clean_exit(code, status, NULL))\r\n                f = MOUNT_SUCCESS;\r\n\r\nand is_clean_exit() considers the SIGTERM status from the mount process a clean\r\nexit. Then later on, we do\r\n\r\n                if (f == MOUNT_SUCCESS)\r\n                        mount_enter_mounted(m, f);\r\n\r\ncausing the mount unit to incorrectly reach \"mounted\" state.\r\n\r\nThe fix is to use the original m->result rather than \"f\". (Note that \"f\" is\r\nassigned to m->result if the latter is MOUNT_SUCCESS, so we don't lose errors\r\nindicated by \"f\" if the unit is still in a successful state.)","created_at":"2016-10-06T09:55:21Z","updated_at":"2016-10-06T09:55:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99823f787ae555fbfd7c117fa0ab94e10c8ba5ca","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/4297/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/4297/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/4297/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/3fe5c0d4f41bc29fa43531725f98096b80295dce","head":{"label":"edolstra:fix-4275","ref":"fix-4275","sha":"3fe5c0d4f41bc29fa43531725f98096b80295dce","user":{"login":"edolstra","id":1148549,"avatar_url":"https://avatars.githubusercontent.com/u/1148549?v=3","gravatar_id":"","url":"https://api.github.com/users/edolstra","html_url":"https://github.com/edolstra","followers_url":"https://api.github.com/users/edolstra/followers","following_url":"https://api.github.com/users/edolstra/following{/other_user}","gists_url":"https://api.github.com/users/edolstra/gists{/gist_id}","starred_url":"https://api.github.com/users/edolstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edolstra/subscriptions","organizations_url":"https://api.github.com/users/edolstra/orgs","repos_url":"https://api.github.com/users/edolstra/repos","events_url":"https://api.github.com/users/edolstra/events{/privacy}","received_events_url":"https://api.github.com/users/edolstra/received_events","type":"User","site_admin":false},"repo":{"id":70140068,"name":"systemd","full_name":"edolstra/systemd","owner":{"login":"edolstra","id":1148549,"avatar_url":"https://avatars.githubusercontent.com/u/1148549?v=3","gravatar_id":"","url":"https://api.github.com/users/edolstra","html_url":"https://github.com/edolstra","followers_url":"https://api.github.com/users/edolstra/followers","following_url":"https://api.github.com/users/edolstra/following{/other_user}","gists_url":"https://api.github.com/users/edolstra/gists{/gist_id}","starred_url":"https://api.github.com/users/edolstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edolstra/subscriptions","organizations_url":"https://api.github.com/users/edolstra/orgs","repos_url":"https://api.github.com/users/edolstra/repos","events_url":"https://api.github.com/users/edolstra/events{/privacy}","received_events_url":"https://api.github.com/users/edolstra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edolstra/systemd","description":"systemd upstream","fork":true,"url":"https://api.github.com/repos/edolstra/systemd","forks_url":"https://api.github.com/repos/edolstra/systemd/forks","keys_url":"https://api.github.com/repos/edolstra/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edolstra/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edolstra/systemd/teams","hooks_url":"https://api.github.com/repos/edolstra/systemd/hooks","issue_events_url":"https://api.github.com/repos/edolstra/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/edolstra/systemd/events","assignees_url":"https://api.github.com/repos/edolstra/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/edolstra/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/edolstra/systemd/tags","blobs_url":"https://api.github.com/repos/edolstra/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edolstra/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edolstra/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/edolstra/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edolstra/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/edolstra/systemd/languages","stargazers_url":"https://api.github.com/repos/edolstra/systemd/stargazers","contributors_url":"https://api.github.com/repos/edolstra/systemd/contributors","subscribers_url":"https://api.github.com/repos/edolstra/systemd/subscribers","subscription_url":"https://api.github.com/repos/edolstra/systemd/subscription","commits_url":"https://api.github.com/repos/edolstra/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/edolstra/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/edolstra/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/edolstra/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/edolstra/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/edolstra/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edolstra/systemd/merges","archive_url":"https://api.github.com/repos/edolstra/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edolstra/systemd/downloads","issues_url":"https://api.github.com/repos/edolstra/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/edolstra/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/edolstra/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/edolstra/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edolstra/systemd/labels{/name}","releases_url":"https://api.github.com/repos/edolstra/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/edolstra/systemd/deployments","created_at":"2016-10-06T09:25:07Z","updated_at":"2016-10-06T09:25:14Z","pushed_at":"2016-10-06T09:25:25Z","git_url":"git://github.com/edolstra/systemd.git","ssh_url":"git@github.com:edolstra/systemd.git","clone_url":"https://github.com/edolstra/systemd.git","svn_url":"https://github.com/edolstra/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":74903,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"197e2809320357772c0d2def0b53474a4b1f07fd","user":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"name":"systemd","full_name":"systemd/systemd","owner":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systemd/systemd","description":"systemd upstream","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/systemd/systemd/deployments","created_at":"2015-03-25T15:27:27Z","updated_at":"2016-10-06T08:07:21Z","pushed_at":"2016-10-06T09:55:21Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"git@github.com:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":74903,"stargazers_count":1394,"watchers_count":1394,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":590,"mirror_url":null,"open_issues_count":504,"forks":590,"open_issues":504,"watchers":1394,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/4297"},"html":{"href":"https://github.com/systemd/systemd/pull/4297"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/4297"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/4297/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/4297/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/4297/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/3fe5c0d4f41bc29fa43531725f98096b80295dce"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":10,"changed_files":1}}
{"actor":{"display_login":"edolstra"}}