{"action":"closed","number":770,"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/770","id":57694994,"html_url":"https://github.com/solidusio/solidus/pull/770","diff_url":"https://github.com/solidusio/solidus/pull/770.diff","patch_url":"https://github.com/solidusio/solidus/pull/770.patch","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/770","number":770,"state":"closed","locked":false,"title":"Use model translations for option types forms","user":{"login":"Murph33","id":12613649,"avatar_url":"https://avatars.githubusercontent.com/u/12613649?v=3","gravatar_id":"","url":"https://api.github.com/users/Murph33","html_url":"https://github.com/Murph33","followers_url":"https://api.github.com/users/Murph33/followers","following_url":"https://api.github.com/users/Murph33/following{/other_user}","gists_url":"https://api.github.com/users/Murph33/gists{/gist_id}","starred_url":"https://api.github.com/users/Murph33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Murph33/subscriptions","organizations_url":"https://api.github.com/users/Murph33/orgs","repos_url":"https://api.github.com/users/Murph33/repos","events_url":"https://api.github.com/users/Murph33/events{/privacy}","received_events_url":"https://api.github.com/users/Murph33/received_events","type":"User","site_admin":false},"body":"This is to better use I18n to help localization into other languages.  Translations off of model attributes will be used in lieu of pulling words from the dictionary located somewhere in there.\r\n\r\nThis is cherry picked from #549 and is part of an ongoing attempt to improve the I18n logic as discussed in #735.","created_at":"2016-01-29T19:58:07Z","updated_at":"2016-02-02T18:24:47Z","closed_at":"2016-02-02T18:24:47Z","merged_at":"2016-02-02T18:24:47Z","merge_commit_sha":"15752881c0930f7698f2d203b5253b84e92c4922","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/solidusio/solidus/pulls/770/commits","review_comments_url":"https://api.github.com/repos/solidusio/solidus/pulls/770/comments","review_comment_url":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/770/comments","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/2a341dea9feda85cee624f56cebe58cbfbdaef70","head":{"label":"Murph33:model_translations_option_types_form","ref":"model_translations_option_types_form","sha":"2a341dea9feda85cee624f56cebe58cbfbdaef70","user":{"login":"Murph33","id":12613649,"avatar_url":"https://avatars.githubusercontent.com/u/12613649?v=3","gravatar_id":"","url":"https://api.github.com/users/Murph33","html_url":"https://github.com/Murph33","followers_url":"https://api.github.com/users/Murph33/followers","following_url":"https://api.github.com/users/Murph33/following{/other_user}","gists_url":"https://api.github.com/users/Murph33/gists{/gist_id}","starred_url":"https://api.github.com/users/Murph33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Murph33/subscriptions","organizations_url":"https://api.github.com/users/Murph33/orgs","repos_url":"https://api.github.com/users/Murph33/repos","events_url":"https://api.github.com/users/Murph33/events{/privacy}","received_events_url":"https://api.github.com/users/Murph33/received_events","type":"User","site_admin":false},"repo":{"id":50465112,"name":"solidus","full_name":"Murph33/solidus","owner":{"login":"Murph33","id":12613649,"avatar_url":"https://avatars.githubusercontent.com/u/12613649?v=3","gravatar_id":"","url":"https://api.github.com/users/Murph33","html_url":"https://github.com/Murph33","followers_url":"https://api.github.com/users/Murph33/followers","following_url":"https://api.github.com/users/Murph33/following{/other_user}","gists_url":"https://api.github.com/users/Murph33/gists{/gist_id}","starred_url":"https://api.github.com/users/Murph33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Murph33/subscriptions","organizations_url":"https://api.github.com/users/Murph33/orgs","repos_url":"https://api.github.com/users/Murph33/repos","events_url":"https://api.github.com/users/Murph33/events{/privacy}","received_events_url":"https://api.github.com/users/Murph33/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Murph33/solidus","description":"Solidus, Rails eCommerce System","fork":true,"url":"https://api.github.com/repos/Murph33/solidus","forks_url":"https://api.github.com/repos/Murph33/solidus/forks","keys_url":"https://api.github.com/repos/Murph33/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Murph33/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Murph33/solidus/teams","hooks_url":"https://api.github.com/repos/Murph33/solidus/hooks","issue_events_url":"https://api.github.com/repos/Murph33/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/Murph33/solidus/events","assignees_url":"https://api.github.com/repos/Murph33/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/Murph33/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/Murph33/solidus/tags","blobs_url":"https://api.github.com/repos/Murph33/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Murph33/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Murph33/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Murph33/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Murph33/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/Murph33/solidus/languages","stargazers_url":"https://api.github.com/repos/Murph33/solidus/stargazers","contributors_url":"https://api.github.com/repos/Murph33/solidus/contributors","subscribers_url":"https://api.github.com/repos/Murph33/solidus/subscribers","subscription_url":"https://api.github.com/repos/Murph33/solidus/subscription","commits_url":"https://api.github.com/repos/Murph33/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Murph33/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Murph33/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Murph33/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Murph33/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/Murph33/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Murph33/solidus/merges","archive_url":"https://api.github.com/repos/Murph33/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Murph33/solidus/downloads","issues_url":"https://api.github.com/repos/Murph33/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/Murph33/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/Murph33/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/Murph33/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Murph33/solidus/labels{/name}","releases_url":"https://api.github.com/repos/Murph33/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/Murph33/solidus/deployments","created_at":"2016-01-26T22:50:39Z","updated_at":"2016-01-26T22:50:43Z","pushed_at":"2016-02-02T18:19:45Z","git_url":"git://github.com/Murph33/solidus.git","ssh_url":"git@github.com:Murph33/solidus.git","clone_url":"https://github.com/Murph33/solidus.git","svn_url":"https://github.com/Murph33/solidus","homepage":"http://solidus.io/","size":61627,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solidusio:master","ref":"master","sha":"7589d2008970dfbd3a68b848516a24fddec938cd","user":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"repo":{"id":30985840,"name":"solidus","full_name":"solidusio/solidus","owner":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solidusio/solidus","description":"Solidus, Rails eCommerce System","fork":false,"url":"https://api.github.com/repos/solidusio/solidus","forks_url":"https://api.github.com/repos/solidusio/solidus/forks","keys_url":"https://api.github.com/repos/solidusio/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solidusio/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solidusio/solidus/teams","hooks_url":"https://api.github.com/repos/solidusio/solidus/hooks","issue_events_url":"https://api.github.com/repos/solidusio/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/solidusio/solidus/events","assignees_url":"https://api.github.com/repos/solidusio/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/solidusio/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/solidusio/solidus/tags","blobs_url":"https://api.github.com/repos/solidusio/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solidusio/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solidusio/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/solidusio/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/solidusio/solidus/languages","stargazers_url":"https://api.github.com/repos/solidusio/solidus/stargazers","contributors_url":"https://api.github.com/repos/solidusio/solidus/contributors","subscribers_url":"https://api.github.com/repos/solidusio/solidus/subscribers","subscription_url":"https://api.github.com/repos/solidusio/solidus/subscription","commits_url":"https://api.github.com/repos/solidusio/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/solidusio/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/solidusio/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/solidusio/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/solidusio/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/solidusio/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solidusio/solidus/merges","archive_url":"https://api.github.com/repos/solidusio/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solidusio/solidus/downloads","issues_url":"https://api.github.com/repos/solidusio/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/solidusio/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/solidusio/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/solidusio/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solidusio/solidus/labels{/name}","releases_url":"https://api.github.com/repos/solidusio/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/solidusio/solidus/deployments","created_at":"2015-02-18T20:41:58Z","updated_at":"2016-02-02T17:34:23Z","pushed_at":"2016-02-02T18:24:47Z","git_url":"git://github.com/solidusio/solidus.git","ssh_url":"git@github.com:solidusio/solidus.git","clone_url":"https://github.com/solidusio/solidus.git","svn_url":"https://github.com/solidusio/solidus","homepage":"http://solidus.io/","size":67138,"stargazers_count":797,"watchers_count":797,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":179,"mirror_url":null,"open_issues_count":104,"forks":179,"open_issues":104,"watchers":797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/770"},"html":{"href":"https://github.com/solidusio/solidus/pull/770"},"issue":{"href":"https://api.github.com/repos/solidusio/solidus/issues/770"},"comments":{"href":"https://api.github.com/repos/solidusio/solidus/issues/770/comments"},"review_comments":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/770/comments"},"review_comment":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/770/commits"},"statuses":{"href":"https://api.github.com/repos/solidusio/solidus/statuses/2a341dea9feda85cee624f56cebe58cbfbdaef70"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jhawthorn","id":131752,"avatar_url":"https://avatars.githubusercontent.com/u/131752?v=3","gravatar_id":"","url":"https://api.github.com/users/jhawthorn","html_url":"https://github.com/jhawthorn","followers_url":"https://api.github.com/users/jhawthorn/followers","following_url":"https://api.github.com/users/jhawthorn/following{/other_user}","gists_url":"https://api.github.com/users/jhawthorn/gists{/gist_id}","starred_url":"https://api.github.com/users/jhawthorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhawthorn/subscriptions","organizations_url":"https://api.github.com/users/jhawthorn/orgs","repos_url":"https://api.github.com/users/jhawthorn/repos","events_url":"https://api.github.com/users/jhawthorn/events{/privacy}","received_events_url":"https://api.github.com/users/jhawthorn/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":9,"deletions":6,"changed_files":4}}