{"action":"closed","number":8693,"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/8693","id":70351448,"html_url":"https://github.com/angular/angular/pull/8693","diff_url":"https://github.com/angular/angular/pull/8693.diff","patch_url":"https://github.com/angular/angular/pull/8693.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/8693","number":8693,"state":"closed","locked":false,"title":"G3_MASTER: Ignore unused import strong-mode warnings in generated Dart code","user":{"login":"ochafik","id":273860,"avatar_url":"https://avatars.githubusercontent.com/u/273860?v=3","gravatar_id":"","url":"https://api.github.com/users/ochafik","html_url":"https://github.com/ochafik","followers_url":"https://api.github.com/users/ochafik/followers","following_url":"https://api.github.com/users/ochafik/following{/other_user}","gists_url":"https://api.github.com/users/ochafik/gists{/gist_id}","starred_url":"https://api.github.com/users/ochafik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ochafik/subscriptions","organizations_url":"https://api.github.com/users/ochafik/orgs","repos_url":"https://api.github.com/users/ochafik/repos","events_url":"https://api.github.com/users/ochafik/events{/privacy}","received_events_url":"https://api.github.com/users/ochafik/received_events","type":"User","site_admin":false},"body":"**Please check if the PR fulfills these requirements**\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n**What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...)\r\n- [x] Bugfix\r\n- [ ] Feature\r\n- [ ] Code style update (formatting, local variables)\r\n- [ ] Refactoring (no functional changes, no api changes)\r\n- [ ] Build related changes\r\n- [ ] CI related changes\r\n- [ ] Other... Please describe:\r\n\r\n**What is the current behavior?** (You can also link to an open issue here)\r\n\r\nGenerated code triggers lots of unused import warnings with `dartanalyzer --strong`.\r\n\r\n**What is the new behavior?**\r\n\r\nUnused imports and unused \"shown\" names in imports in generated are silently ignored by the Dart analyzer in strong-mode.\r\n\r\n**Does this PR introduce a breaking change?**\r\n- [ ] Yes\r\n- [x] No\r\n\r\n**Other information**:\r\n\r\n","created_at":"2016-05-17T12:54:20Z","updated_at":"2016-05-19T18:25:35Z","closed_at":"2016-05-19T18:25:35Z","merged_at":"2016-05-19T18:25:35Z","merge_commit_sha":"220be8e816c554633c12e8d32261817fe99b5834","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/8693/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/8693/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/8693/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/e9b86061a52b9ed4e378fb28b28738467a4dc84a","head":{"label":"ochafik:ochafik-ignore-unused-imports-warnings-g3_master","ref":"ochafik-ignore-unused-imports-warnings-g3_master","sha":"e9b86061a52b9ed4e378fb28b28738467a4dc84a","user":{"login":"ochafik","id":273860,"avatar_url":"https://avatars.githubusercontent.com/u/273860?v=3","gravatar_id":"","url":"https://api.github.com/users/ochafik","html_url":"https://github.com/ochafik","followers_url":"https://api.github.com/users/ochafik/followers","following_url":"https://api.github.com/users/ochafik/following{/other_user}","gists_url":"https://api.github.com/users/ochafik/gists{/gist_id}","starred_url":"https://api.github.com/users/ochafik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ochafik/subscriptions","organizations_url":"https://api.github.com/users/ochafik/orgs","repos_url":"https://api.github.com/users/ochafik/repos","events_url":"https://api.github.com/users/ochafik/events{/privacy}","received_events_url":"https://api.github.com/users/ochafik/received_events","type":"User","site_admin":false},"repo":{"id":46451281,"name":"angular","full_name":"ochafik/angular","owner":{"login":"ochafik","id":273860,"avatar_url":"https://avatars.githubusercontent.com/u/273860?v=3","gravatar_id":"","url":"https://api.github.com/users/ochafik","html_url":"https://github.com/ochafik","followers_url":"https://api.github.com/users/ochafik/followers","following_url":"https://api.github.com/users/ochafik/following{/other_user}","gists_url":"https://api.github.com/users/ochafik/gists{/gist_id}","starred_url":"https://api.github.com/users/ochafik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ochafik/subscriptions","organizations_url":"https://api.github.com/users/ochafik/orgs","repos_url":"https://api.github.com/users/ochafik/repos","events_url":"https://api.github.com/users/ochafik/events{/privacy}","received_events_url":"https://api.github.com/users/ochafik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ochafik/angular","description":"","fork":true,"url":"https://api.github.com/repos/ochafik/angular","forks_url":"https://api.github.com/repos/ochafik/angular/forks","keys_url":"https://api.github.com/repos/ochafik/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ochafik/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ochafik/angular/teams","hooks_url":"https://api.github.com/repos/ochafik/angular/hooks","issue_events_url":"https://api.github.com/repos/ochafik/angular/issues/events{/number}","events_url":"https://api.github.com/repos/ochafik/angular/events","assignees_url":"https://api.github.com/repos/ochafik/angular/assignees{/user}","branches_url":"https://api.github.com/repos/ochafik/angular/branches{/branch}","tags_url":"https://api.github.com/repos/ochafik/angular/tags","blobs_url":"https://api.github.com/repos/ochafik/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ochafik/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ochafik/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/ochafik/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ochafik/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/ochafik/angular/languages","stargazers_url":"https://api.github.com/repos/ochafik/angular/stargazers","contributors_url":"https://api.github.com/repos/ochafik/angular/contributors","subscribers_url":"https://api.github.com/repos/ochafik/angular/subscribers","subscription_url":"https://api.github.com/repos/ochafik/angular/subscription","commits_url":"https://api.github.com/repos/ochafik/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/ochafik/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/ochafik/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/ochafik/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/ochafik/angular/contents/{+path}","compare_url":"https://api.github.com/repos/ochafik/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ochafik/angular/merges","archive_url":"https://api.github.com/repos/ochafik/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ochafik/angular/downloads","issues_url":"https://api.github.com/repos/ochafik/angular/issues{/number}","pulls_url":"https://api.github.com/repos/ochafik/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/ochafik/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/ochafik/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ochafik/angular/labels{/name}","releases_url":"https://api.github.com/repos/ochafik/angular/releases{/id}","deployments_url":"https://api.github.com/repos/ochafik/angular/deployments","created_at":"2015-11-18T22:20:40Z","updated_at":"2016-01-17T14:21:28Z","pushed_at":"2016-05-19T10:46:40Z","git_url":"git://github.com/ochafik/angular.git","ssh_url":"git@github.com:ochafik/angular.git","clone_url":"https://github.com/ochafik/angular.git","svn_url":"https://github.com/ochafik/angular","homepage":"https://angular.io","size":34518,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:g3_master","ref":"g3_master","sha":"c05306ad4e5547926a079dba1a788c3e38894d50","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2016-05-19T17:36:46Z","pushed_at":"2016-05-19T18:25:35Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":598874,"stargazers_count":12037,"watchers_count":12037,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3155,"mirror_url":null,"open_issues_count":1666,"forks":3155,"open_issues":1666,"watchers":12037,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/8693"},"html":{"href":"https://github.com/angular/angular/pull/8693"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/8693"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/8693/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/8693/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/8693/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/e9b86061a52b9ed4e378fb28b28738467a4dc84a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jeffbcross","id":463703,"avatar_url":"https://avatars.githubusercontent.com/u/463703?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffbcross","html_url":"https://github.com/jeffbcross","followers_url":"https://api.github.com/users/jeffbcross/followers","following_url":"https://api.github.com/users/jeffbcross/following{/other_user}","gists_url":"https://api.github.com/users/jeffbcross/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffbcross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffbcross/subscriptions","organizations_url":"https://api.github.com/users/jeffbcross/orgs","repos_url":"https://api.github.com/users/jeffbcross/repos","events_url":"https://api.github.com/users/jeffbcross/events{/privacy}","received_events_url":"https://api.github.com/users/jeffbcross/received_events","type":"User","site_admin":false},"comments":11,"review_comments":0,"commits":1,"additions":35,"deletions":0,"changed_files":15}}