{"action":"created","comment":{"url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments/94210596","pull_request_review_id":14741063,"id":94210596,"diff_hunk":"@@ -38,7 +38,8 @@ SetCompressorDictSize 24\n ; The name of the installer\n Name \"${APP_NAME}\"\n \n-OutFile \"output\\pcsx2-${APP_VERSION}-${OUTFILE_POSTFIX}.exe\"\n+; Output the installer to the nsis folder (in git repo)\n+OutFile \"pcsx2-${APP_VERSION}-${OUTFILE_POSTFIX}.exe\"","path":"nsis/SharedBase.nsh","position":39,"original_position":6,"commit_id":"57913e06c1e1ef090bd674ac16390ea0d4d68404","original_commit_id":"2db02caa781cd6e11e0ee2e1e9c3962ef47dfdcd","user":{"login":"MrCK1","id":16314399,"avatar_url":"https://avatars.githubusercontent.com/u/16314399?v=3","gravatar_id":"","url":"https://api.github.com/users/MrCK1","html_url":"https://github.com/MrCK1","followers_url":"https://api.github.com/users/MrCK1/followers","following_url":"https://api.github.com/users/MrCK1/following{/other_user}","gists_url":"https://api.github.com/users/MrCK1/gists{/gist_id}","starred_url":"https://api.github.com/users/MrCK1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrCK1/subscriptions","organizations_url":"https://api.github.com/users/MrCK1/orgs","repos_url":"https://api.github.com/users/MrCK1/repos","events_url":"https://api.github.com/users/MrCK1/events{/privacy}","received_events_url":"https://api.github.com/users/MrCK1/received_events","type":"User","site_admin":false},"body":"The only way to create a directory at compile time in MakeNSIS (remember we can't use functions) is to run some code through command line; so it's rather pointless in that matter.\r\n\r\nNot sure about the gitignore though, maybe it'll make more sense after I get some rest ;)","created_at":"2016-12-30T08:38:19Z","updated_at":"2016-12-30T08:38:19Z","html_url":"https://github.com/PCSX2/pcsx2/pull/1699#discussion_r94210596","pull_request_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1699","_links":{"self":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments/94210596"},"html":{"href":"https://github.com/PCSX2/pcsx2/pull/1699#discussion_r94210596"},"pull_request":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1699"}}},"pull_request":{"url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1699","id":98084994,"html_url":"https://github.com/PCSX2/pcsx2/pull/1699","diff_url":"https://github.com/PCSX2/pcsx2/pull/1699.diff","patch_url":"https://github.com/PCSX2/pcsx2/pull/1699.patch","issue_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1699","number":1699,"state":"open","locked":false,"title":"NSIS: Update installer scripts, bug fixes, added some new goodies","user":{"login":"MrCK1","id":16314399,"avatar_url":"https://avatars.githubusercontent.com/u/16314399?v=3","gravatar_id":"","url":"https://api.github.com/users/MrCK1","html_url":"https://github.com/MrCK1","followers_url":"https://api.github.com/users/MrCK1/followers","following_url":"https://api.github.com/users/MrCK1/following{/other_user}","gists_url":"https://api.github.com/users/MrCK1/gists{/gist_id}","starred_url":"https://api.github.com/users/MrCK1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrCK1/subscriptions","organizations_url":"https://api.github.com/users/MrCK1/orgs","repos_url":"https://api.github.com/users/MrCK1/repos","events_url":"https://api.github.com/users/MrCK1/events{/privacy}","received_events_url":"https://api.github.com/users/MrCK1/received_events","type":"User","site_admin":false},"body":"Summary of changes:\r\n\r\nMain Installer Changes:\r\n- Conducted compatibility testing for installer and build scripts in NSIS 3.01\r\n\r\n- Implemented uninstall script for future version detection. If an older or equivalent PCSX2 version is detected, the user is prompted to silently uninstall/overwrite or abort the installer. (The function is not compatible with any current stable releases because they lack the new registry string required for version detection.) \r\n\r\n- We can launch PCSX2 directly from the installer now 👍 \r\n\r\nYou can try the new installer(s) with version detection [here](https://drive.google.com/open?id=0Bw4EU0WRGcbbZGN2cmhyd2RTMFU)\r\n\r\nMakeNSIS: \r\n- Suppressed errors related to unused plugins\r\n- Replaced some functions \r\n- Removed an leftover parameter.\r\n\r\nUninstaller: \r\n- Added section that allows users to keep just memory cards/savestates. \r\n- Fixed an issue with a registry key left behind by the uninstaller. \r\n- Fixed an issue with .ini files being deleted unintentionally \r\n- Removed obsolete function\r\n\r\nMisc:\r\n- Updated copyright, added icon to installer\r\n- Reformatted installer instructions and added additional sections, fixed broken VC++ URL.","created_at":"2016-12-15T04:22:44Z","updated_at":"2016-12-30T08:38:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0439cac531e87efb4e5f65026145fb196bf42ff5","assignee":{"login":"ramapcsx2","id":6278722,"avatar_url":"https://avatars.githubusercontent.com/u/6278722?v=3","gravatar_id":"","url":"https://api.github.com/users/ramapcsx2","html_url":"https://github.com/ramapcsx2","followers_url":"https://api.github.com/users/ramapcsx2/followers","following_url":"https://api.github.com/users/ramapcsx2/following{/other_user}","gists_url":"https://api.github.com/users/ramapcsx2/gists{/gist_id}","starred_url":"https://api.github.com/users/ramapcsx2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramapcsx2/subscriptions","organizations_url":"https://api.github.com/users/ramapcsx2/orgs","repos_url":"https://api.github.com/users/ramapcsx2/repos","events_url":"https://api.github.com/users/ramapcsx2/events{/privacy}","received_events_url":"https://api.github.com/users/ramapcsx2/received_events","type":"User","site_admin":false},"assignees":[{"login":"ramapcsx2","id":6278722,"avatar_url":"https://avatars.githubusercontent.com/u/6278722?v=3","gravatar_id":"","url":"https://api.github.com/users/ramapcsx2","html_url":"https://github.com/ramapcsx2","followers_url":"https://api.github.com/users/ramapcsx2/followers","following_url":"https://api.github.com/users/ramapcsx2/following{/other_user}","gists_url":"https://api.github.com/users/ramapcsx2/gists{/gist_id}","starred_url":"https://api.github.com/users/ramapcsx2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramapcsx2/subscriptions","organizations_url":"https://api.github.com/users/ramapcsx2/orgs","repos_url":"https://api.github.com/users/ramapcsx2/repos","events_url":"https://api.github.com/users/ramapcsx2/events{/privacy}","received_events_url":"https://api.github.com/users/ramapcsx2/received_events","type":"User","site_admin":false},{"login":"refractionpcsx2","id":6278726,"avatar_url":"https://avatars.githubusercontent.com/u/6278726?v=3","gravatar_id":"","url":"https://api.github.com/users/refractionpcsx2","html_url":"https://github.com/refractionpcsx2","followers_url":"https://api.github.com/users/refractionpcsx2/followers","following_url":"https://api.github.com/users/refractionpcsx2/following{/other_user}","gists_url":"https://api.github.com/users/refractionpcsx2/gists{/gist_id}","starred_url":"https://api.github.com/users/refractionpcsx2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refractionpcsx2/subscriptions","organizations_url":"https://api.github.com/users/refractionpcsx2/orgs","repos_url":"https://api.github.com/users/refractionpcsx2/repos","events_url":"https://api.github.com/users/refractionpcsx2/events{/privacy}","received_events_url":"https://api.github.com/users/refractionpcsx2/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1699/commits","review_comments_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1699/comments","review_comment_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1699/comments","statuses_url":"https://api.github.com/repos/PCSX2/pcsx2/statuses/57913e06c1e1ef090bd674ac16390ea0d4d68404","head":{"label":"MrCK1:NSIS3.01_upgrade_CK1","ref":"NSIS3.01_upgrade_CK1","sha":"57913e06c1e1ef090bd674ac16390ea0d4d68404","user":{"login":"MrCK1","id":16314399,"avatar_url":"https://avatars.githubusercontent.com/u/16314399?v=3","gravatar_id":"","url":"https://api.github.com/users/MrCK1","html_url":"https://github.com/MrCK1","followers_url":"https://api.github.com/users/MrCK1/followers","following_url":"https://api.github.com/users/MrCK1/following{/other_user}","gists_url":"https://api.github.com/users/MrCK1/gists{/gist_id}","starred_url":"https://api.github.com/users/MrCK1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrCK1/subscriptions","organizations_url":"https://api.github.com/users/MrCK1/orgs","repos_url":"https://api.github.com/users/MrCK1/repos","events_url":"https://api.github.com/users/MrCK1/events{/privacy}","received_events_url":"https://api.github.com/users/MrCK1/received_events","type":"User","site_admin":false},"repo":{"id":68653581,"name":"pcsx2","full_name":"MrCK1/pcsx2","owner":{"login":"MrCK1","id":16314399,"avatar_url":"https://avatars.githubusercontent.com/u/16314399?v=3","gravatar_id":"","url":"https://api.github.com/users/MrCK1","html_url":"https://github.com/MrCK1","followers_url":"https://api.github.com/users/MrCK1/followers","following_url":"https://api.github.com/users/MrCK1/following{/other_user}","gists_url":"https://api.github.com/users/MrCK1/gists{/gist_id}","starred_url":"https://api.github.com/users/MrCK1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrCK1/subscriptions","organizations_url":"https://api.github.com/users/MrCK1/orgs","repos_url":"https://api.github.com/users/MrCK1/repos","events_url":"https://api.github.com/users/MrCK1/events{/privacy}","received_events_url":"https://api.github.com/users/MrCK1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MrCK1/pcsx2","description":"PCSX2 - The Playstation 2 Emulator","fork":true,"url":"https://api.github.com/repos/MrCK1/pcsx2","forks_url":"https://api.github.com/repos/MrCK1/pcsx2/forks","keys_url":"https://api.github.com/repos/MrCK1/pcsx2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MrCK1/pcsx2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MrCK1/pcsx2/teams","hooks_url":"https://api.github.com/repos/MrCK1/pcsx2/hooks","issue_events_url":"https://api.github.com/repos/MrCK1/pcsx2/issues/events{/number}","events_url":"https://api.github.com/repos/MrCK1/pcsx2/events","assignees_url":"https://api.github.com/repos/MrCK1/pcsx2/assignees{/user}","branches_url":"https://api.github.com/repos/MrCK1/pcsx2/branches{/branch}","tags_url":"https://api.github.com/repos/MrCK1/pcsx2/tags","blobs_url":"https://api.github.com/repos/MrCK1/pcsx2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MrCK1/pcsx2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MrCK1/pcsx2/git/refs{/sha}","trees_url":"https://api.github.com/repos/MrCK1/pcsx2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MrCK1/pcsx2/statuses/{sha}","languages_url":"https://api.github.com/repos/MrCK1/pcsx2/languages","stargazers_url":"https://api.github.com/repos/MrCK1/pcsx2/stargazers","contributors_url":"https://api.github.com/repos/MrCK1/pcsx2/contributors","subscribers_url":"https://api.github.com/repos/MrCK1/pcsx2/subscribers","subscription_url":"https://api.github.com/repos/MrCK1/pcsx2/subscription","commits_url":"https://api.github.com/repos/MrCK1/pcsx2/commits{/sha}","git_commits_url":"https://api.github.com/repos/MrCK1/pcsx2/git/commits{/sha}","comments_url":"https://api.github.com/repos/MrCK1/pcsx2/comments{/number}","issue_comment_url":"https://api.github.com/repos/MrCK1/pcsx2/issues/comments{/number}","contents_url":"https://api.github.com/repos/MrCK1/pcsx2/contents/{+path}","compare_url":"https://api.github.com/repos/MrCK1/pcsx2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MrCK1/pcsx2/merges","archive_url":"https://api.github.com/repos/MrCK1/pcsx2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MrCK1/pcsx2/downloads","issues_url":"https://api.github.com/repos/MrCK1/pcsx2/issues{/number}","pulls_url":"https://api.github.com/repos/MrCK1/pcsx2/pulls{/number}","milestones_url":"https://api.github.com/repos/MrCK1/pcsx2/milestones{/number}","notifications_url":"https://api.github.com/repos/MrCK1/pcsx2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MrCK1/pcsx2/labels{/name}","releases_url":"https://api.github.com/repos/MrCK1/pcsx2/releases{/id}","deployments_url":"https://api.github.com/repos/MrCK1/pcsx2/deployments","created_at":"2016-09-19T22:57:59Z","updated_at":"2016-09-19T22:58:10Z","pushed_at":"2016-12-29T20:23:15Z","git_url":"git://github.com/MrCK1/pcsx2.git","ssh_url":"git@github.com:MrCK1/pcsx2.git","clone_url":"https://github.com/MrCK1/pcsx2.git","svn_url":"https://github.com/MrCK1/pcsx2","homepage":"http://pcsx2.net/","size":87898,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PCSX2:master","ref":"master","sha":"29d229264dbf1df85e77c63bff6ac394c5b333f6","user":{"login":"PCSX2","id":6278711,"avatar_url":"https://avatars.githubusercontent.com/u/6278711?v=3","gravatar_id":"","url":"https://api.github.com/users/PCSX2","html_url":"https://github.com/PCSX2","followers_url":"https://api.github.com/users/PCSX2/followers","following_url":"https://api.github.com/users/PCSX2/following{/other_user}","gists_url":"https://api.github.com/users/PCSX2/gists{/gist_id}","starred_url":"https://api.github.com/users/PCSX2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCSX2/subscriptions","organizations_url":"https://api.github.com/users/PCSX2/orgs","repos_url":"https://api.github.com/users/PCSX2/repos","events_url":"https://api.github.com/users/PCSX2/events{/privacy}","received_events_url":"https://api.github.com/users/PCSX2/received_events","type":"Organization","site_admin":false},"repo":{"id":15379620,"name":"pcsx2","full_name":"PCSX2/pcsx2","owner":{"login":"PCSX2","id":6278711,"avatar_url":"https://avatars.githubusercontent.com/u/6278711?v=3","gravatar_id":"","url":"https://api.github.com/users/PCSX2","html_url":"https://github.com/PCSX2","followers_url":"https://api.github.com/users/PCSX2/followers","following_url":"https://api.github.com/users/PCSX2/following{/other_user}","gists_url":"https://api.github.com/users/PCSX2/gists{/gist_id}","starred_url":"https://api.github.com/users/PCSX2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCSX2/subscriptions","organizations_url":"https://api.github.com/users/PCSX2/orgs","repos_url":"https://api.github.com/users/PCSX2/repos","events_url":"https://api.github.com/users/PCSX2/events{/privacy}","received_events_url":"https://api.github.com/users/PCSX2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PCSX2/pcsx2","description":"PCSX2 - The Playstation 2 Emulator","fork":false,"url":"https://api.github.com/repos/PCSX2/pcsx2","forks_url":"https://api.github.com/repos/PCSX2/pcsx2/forks","keys_url":"https://api.github.com/repos/PCSX2/pcsx2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PCSX2/pcsx2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PCSX2/pcsx2/teams","hooks_url":"https://api.github.com/repos/PCSX2/pcsx2/hooks","issue_events_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/events{/number}","events_url":"https://api.github.com/repos/PCSX2/pcsx2/events","assignees_url":"https://api.github.com/repos/PCSX2/pcsx2/assignees{/user}","branches_url":"https://api.github.com/repos/PCSX2/pcsx2/branches{/branch}","tags_url":"https://api.github.com/repos/PCSX2/pcsx2/tags","blobs_url":"https://api.github.com/repos/PCSX2/pcsx2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PCSX2/pcsx2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PCSX2/pcsx2/git/refs{/sha}","trees_url":"https://api.github.com/repos/PCSX2/pcsx2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PCSX2/pcsx2/statuses/{sha}","languages_url":"https://api.github.com/repos/PCSX2/pcsx2/languages","stargazers_url":"https://api.github.com/repos/PCSX2/pcsx2/stargazers","contributors_url":"https://api.github.com/repos/PCSX2/pcsx2/contributors","subscribers_url":"https://api.github.com/repos/PCSX2/pcsx2/subscribers","subscription_url":"https://api.github.com/repos/PCSX2/pcsx2/subscription","commits_url":"https://api.github.com/repos/PCSX2/pcsx2/commits{/sha}","git_commits_url":"https://api.github.com/repos/PCSX2/pcsx2/git/commits{/sha}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/comments{/number}","issue_comment_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/comments{/number}","contents_url":"https://api.github.com/repos/PCSX2/pcsx2/contents/{+path}","compare_url":"https://api.github.com/repos/PCSX2/pcsx2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PCSX2/pcsx2/merges","archive_url":"https://api.github.com/repos/PCSX2/pcsx2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PCSX2/pcsx2/downloads","issues_url":"https://api.github.com/repos/PCSX2/pcsx2/issues{/number}","pulls_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls{/number}","milestones_url":"https://api.github.com/repos/PCSX2/pcsx2/milestones{/number}","notifications_url":"https://api.github.com/repos/PCSX2/pcsx2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PCSX2/pcsx2/labels{/name}","releases_url":"https://api.github.com/repos/PCSX2/pcsx2/releases{/id}","deployments_url":"https://api.github.com/repos/PCSX2/pcsx2/deployments","created_at":"2013-12-22T17:56:48Z","updated_at":"2016-12-30T08:09:41Z","pushed_at":"2016-12-29T20:23:16Z","git_url":"git://github.com/PCSX2/pcsx2.git","ssh_url":"git@github.com:PCSX2/pcsx2.git","clone_url":"https://github.com/PCSX2/pcsx2.git","svn_url":"https://github.com/PCSX2/pcsx2","homepage":"http://pcsx2.net/","size":87697,"stargazers_count":1489,"watchers_count":1489,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":339,"mirror_url":null,"open_issues_count":299,"forks":339,"open_issues":299,"watchers":1489,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1699"},"html":{"href":"https://github.com/PCSX2/pcsx2/pull/1699"},"issue":{"href":"https://api.github.com/repos/PCSX2/pcsx2/issues/1699"},"comments":{"href":"https://api.github.com/repos/PCSX2/pcsx2/issues/1699/comments"},"review_comments":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1699/comments"},"review_comment":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1699/commits"},"statuses":{"href":"https://api.github.com/repos/PCSX2/pcsx2/statuses/57913e06c1e1ef090bd674ac16390ea0d4d68404"}}}}
{"actor":{"display_login":"MrCK1"}}