{"action":"closed","number":263,"pull_request":{"url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/pulls/263","id":75725946,"html_url":"https://github.com/cloudfour/cloudfour.com-patterns/pull/263","diff_url":"https://github.com/cloudfour/cloudfour.com-patterns/pull/263.diff","patch_url":"https://github.com/cloudfour/cloudfour.com-patterns/pull/263.patch","issue_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/issues/263","number":263,"state":"closed","locked":false,"title":"SVG icons: sprite → inline","user":{"login":"tylersticka","id":69633,"avatar_url":"https://avatars.githubusercontent.com/u/69633?v=3","gravatar_id":"","url":"https://api.github.com/users/tylersticka","html_url":"https://github.com/tylersticka","followers_url":"https://api.github.com/users/tylersticka/followers","following_url":"https://api.github.com/users/tylersticka/following{/other_user}","gists_url":"https://api.github.com/users/tylersticka/gists{/gist_id}","starred_url":"https://api.github.com/users/tylersticka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylersticka/subscriptions","organizations_url":"https://api.github.com/users/tylersticka/orgs","repos_url":"https://api.github.com/users/tylersticka/repos","events_url":"https://api.github.com/users/tylersticka/events{/privacy}","received_events_url":"https://api.github.com/users/tylersticka/received_events","type":"User","site_admin":false},"body":"Well, _that_ was a pain.\r\n\r\nThis PR refactors our icons to be inline instead of using a sprite. This [follows GitHub's example](https://github.com/blog/2112-delivering-octicons-with-svg) and overcomes issues related to external `<use>` references and CDNs (which we'll likely encounter on WPEngine).\r\n\r\nI originally wanted to make these updates to the base icon pattern so I wouldn't have to update every instance. Unfortunately, there were just too many differences between the idiosyncratic attribute names and structure of the pattern to easily \"pass through\" the old syntax to the new one, so I had to go replace them all by hand. There were also several instances of icons being reference directly without the helper, so those had to be tracked down as well.\r\n\r\nI decided it wasn't worth the time right now to update old sandbox prototypes, except those that were dependent on patterns that are removed as a result of this PR. So some older sandbox prototypes may have broken icons for a while.\r\n\r\nI'd love if someone could pull and try this locally before we merge because it touched so many individual files.\r\n\r\n---\r\n\r\n@saralohr @nicolemors @mrgerardorodriguez ","created_at":"2016-06-29T21:36:06Z","updated_at":"2016-06-29T21:51:49Z","closed_at":"2016-06-29T21:51:49Z","merged_at":"2016-06-29T21:51:49Z","merge_commit_sha":"10589999e46f910e947f42b6d66e8d950639179a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/pulls/263/commits","review_comments_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/pulls/263/comments","review_comment_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/issues/263/comments","statuses_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/statuses/ac1573896fd567bfd1ccd683a840a53b3ce24d19","head":{"label":"cloudfour:chore-inline_svg","ref":"chore-inline_svg","sha":"ac1573896fd567bfd1ccd683a840a53b3ce24d19","user":{"login":"cloudfour","id":1273956,"avatar_url":"https://avatars.githubusercontent.com/u/1273956?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudfour","html_url":"https://github.com/cloudfour","followers_url":"https://api.github.com/users/cloudfour/followers","following_url":"https://api.github.com/users/cloudfour/following{/other_user}","gists_url":"https://api.github.com/users/cloudfour/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfour/subscriptions","organizations_url":"https://api.github.com/users/cloudfour/orgs","repos_url":"https://api.github.com/users/cloudfour/repos","events_url":"https://api.github.com/users/cloudfour/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfour/received_events","type":"Organization","site_admin":false},"repo":{"id":36455267,"name":"cloudfour.com-patterns","full_name":"cloudfour/cloudfour.com-patterns","owner":{"login":"cloudfour","id":1273956,"avatar_url":"https://avatars.githubusercontent.com/u/1273956?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudfour","html_url":"https://github.com/cloudfour","followers_url":"https://api.github.com/users/cloudfour/followers","following_url":"https://api.github.com/users/cloudfour/following{/other_user}","gists_url":"https://api.github.com/users/cloudfour/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfour/subscriptions","organizations_url":"https://api.github.com/users/cloudfour/orgs","repos_url":"https://api.github.com/users/cloudfour/repos","events_url":"https://api.github.com/users/cloudfour/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfour/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudfour/cloudfour.com-patterns","description":"The Pattern Library for cloudfour.com","fork":false,"url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns","forks_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/forks","keys_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/teams","hooks_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/hooks","issue_events_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/issues/events{/number}","events_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/events","assignees_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/assignees{/user}","branches_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/branches{/branch}","tags_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/tags","blobs_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/languages","stargazers_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/stargazers","contributors_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/contributors","subscribers_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/subscribers","subscription_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/subscription","commits_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/contents/{+path}","compare_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/merges","archive_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/downloads","issues_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/issues{/number}","pulls_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/labels{/name}","releases_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/releases{/id}","deployments_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/deployments","created_at":"2015-05-28T17:39:24Z","updated_at":"2016-06-16T10:48:33Z","pushed_at":"2016-06-29T21:51:49Z","git_url":"git://github.com/cloudfour/cloudfour.com-patterns.git","ssh_url":"git@github.com:cloudfour/cloudfour.com-patterns.git","clone_url":"https://github.com/cloudfour/cloudfour.com-patterns.git","svn_url":"https://github.com/cloudfour/cloudfour.com-patterns","homepage":"","size":9872,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"cloudfour:master","ref":"master","sha":"6f3b27a723546afbd744f11c85b19a442fa2abcd","user":{"login":"cloudfour","id":1273956,"avatar_url":"https://avatars.githubusercontent.com/u/1273956?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudfour","html_url":"https://github.com/cloudfour","followers_url":"https://api.github.com/users/cloudfour/followers","following_url":"https://api.github.com/users/cloudfour/following{/other_user}","gists_url":"https://api.github.com/users/cloudfour/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfour/subscriptions","organizations_url":"https://api.github.com/users/cloudfour/orgs","repos_url":"https://api.github.com/users/cloudfour/repos","events_url":"https://api.github.com/users/cloudfour/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfour/received_events","type":"Organization","site_admin":false},"repo":{"id":36455267,"name":"cloudfour.com-patterns","full_name":"cloudfour/cloudfour.com-patterns","owner":{"login":"cloudfour","id":1273956,"avatar_url":"https://avatars.githubusercontent.com/u/1273956?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudfour","html_url":"https://github.com/cloudfour","followers_url":"https://api.github.com/users/cloudfour/followers","following_url":"https://api.github.com/users/cloudfour/following{/other_user}","gists_url":"https://api.github.com/users/cloudfour/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfour/subscriptions","organizations_url":"https://api.github.com/users/cloudfour/orgs","repos_url":"https://api.github.com/users/cloudfour/repos","events_url":"https://api.github.com/users/cloudfour/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfour/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudfour/cloudfour.com-patterns","description":"The Pattern Library for cloudfour.com","fork":false,"url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns","forks_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/forks","keys_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/teams","hooks_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/hooks","issue_events_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/issues/events{/number}","events_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/events","assignees_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/assignees{/user}","branches_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/branches{/branch}","tags_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/tags","blobs_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/languages","stargazers_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/stargazers","contributors_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/contributors","subscribers_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/subscribers","subscription_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/subscription","commits_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/contents/{+path}","compare_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/merges","archive_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/downloads","issues_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/issues{/number}","pulls_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/labels{/name}","releases_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/releases{/id}","deployments_url":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/deployments","created_at":"2015-05-28T17:39:24Z","updated_at":"2016-06-16T10:48:33Z","pushed_at":"2016-06-29T21:51:49Z","git_url":"git://github.com/cloudfour/cloudfour.com-patterns.git","ssh_url":"git@github.com:cloudfour/cloudfour.com-patterns.git","clone_url":"https://github.com/cloudfour/cloudfour.com-patterns.git","svn_url":"https://github.com/cloudfour/cloudfour.com-patterns","homepage":"","size":9872,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/pulls/263"},"html":{"href":"https://github.com/cloudfour/cloudfour.com-patterns/pull/263"},"issue":{"href":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/issues/263"},"comments":{"href":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/issues/263/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/pulls/263/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/pulls/263/commits"},"statuses":{"href":"https://api.github.com/repos/cloudfour/cloudfour.com-patterns/statuses/ac1573896fd567bfd1ccd683a840a53b3ce24d19"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tylersticka","id":69633,"avatar_url":"https://avatars.githubusercontent.com/u/69633?v=3","gravatar_id":"","url":"https://api.github.com/users/tylersticka","html_url":"https://github.com/tylersticka","followers_url":"https://api.github.com/users/tylersticka/followers","following_url":"https://api.github.com/users/tylersticka/following{/other_user}","gists_url":"https://api.github.com/users/tylersticka/gists{/gist_id}","starred_url":"https://api.github.com/users/tylersticka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylersticka/subscriptions","organizations_url":"https://api.github.com/users/tylersticka/orgs","repos_url":"https://api.github.com/users/tylersticka/repos","events_url":"https://api.github.com/users/tylersticka/events{/privacy}","received_events_url":"https://api.github.com/users/tylersticka/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":8,"additions":143,"deletions":507,"changed_files":66}}
{"actor":{"display_login":"tylersticka"}}