{"action":"created","issue":{"url":"https://api.github.com/repos/BRAINSia/BRAINSTools/issues/284","repository_url":"https://api.github.com/repos/BRAINSia/BRAINSTools","labels_url":"https://api.github.com/repos/BRAINSia/BRAINSTools/issues/284/labels{/name}","comments_url":"https://api.github.com/repos/BRAINSia/BRAINSTools/issues/284/comments","events_url":"https://api.github.com/repos/BRAINSia/BRAINSTools/issues/284/events","html_url":"https://github.com/BRAINSia/BRAINSTools/pull/284","id":161571016,"number":284,"title":"Simplify buildsystem","user":{"login":"jcfr","id":219043,"avatar_url":"https://avatars.githubusercontent.com/u/219043?v=3","gravatar_id":"","url":"https://api.github.com/users/jcfr","html_url":"https://github.com/jcfr","followers_url":"https://api.github.com/users/jcfr/followers","following_url":"https://api.github.com/users/jcfr/following{/other_user}","gists_url":"https://api.github.com/users/jcfr/gists{/gist_id}","starred_url":"https://api.github.com/users/jcfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcfr/subscriptions","organizations_url":"https://api.github.com/users/jcfr/orgs","repos_url":"https://api.github.com/users/jcfr/repos","events_url":"https://api.github.com/users/jcfr/events{/privacy}","received_events_url":"https://api.github.com/users/jcfr/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"ajjl","id":10674287,"avatar_url":"https://avatars.githubusercontent.com/u/10674287?v=3","gravatar_id":"","url":"https://api.github.com/users/ajjl","html_url":"https://github.com/ajjl","followers_url":"https://api.github.com/users/ajjl/followers","following_url":"https://api.github.com/users/ajjl/following{/other_user}","gists_url":"https://api.github.com/users/ajjl/gists{/gist_id}","starred_url":"https://api.github.com/users/ajjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajjl/subscriptions","organizations_url":"https://api.github.com/users/ajjl/orgs","repos_url":"https://api.github.com/users/ajjl/repos","events_url":"https://api.github.com/users/ajjl/events{/privacy}","received_events_url":"https://api.github.com/users/ajjl/received_events","type":"User","site_admin":false},"milestone":null,"comments":9,"created_at":"2016-06-22T00:42:03Z","updated_at":"2016-06-22T18:43:24Z","closed_at":"2016-06-22T01:46:39Z","pull_request":{"url":"https://api.github.com/repos/BRAINSia/BRAINSTools/pulls/284","html_url":"https://github.com/BRAINSia/BRAINSTools/pull/284","diff_url":"https://github.com/BRAINSia/BRAINSTools/pull/284.diff","patch_url":"https://github.com/BRAINSia/BRAINSTools/pull/284.patch"},"body":"This PR simplifies the buildsystem and should also address the issue reported by @lassoan:\r\n\r\n```\r\nIn c:\\D\\S4R\\Slicer-build\\CMakeCache.txt there are just two configs:\r\n\r\nCMAKE_CONFIGURATION_TYPES:STRING=Release;Debug\r\n\r\nIn the high-level Slicer build and in all external projects the list of configurations are complete (4 configs; except Python – but that’s a different matter, it’s fine; and Slicer-build).\r\n\r\nI’ve only found one place in the Slicer build tree where somebody manipulates configuration types: in c:\\D\\S4R\\BRAINSTools\\CMakeLists.txt:\r\n\r\nif(DEFINED CMAKE_CONFIGURATION_TYPES)\r\n  set(CMAKE_CONFIGURATION_TYPES \"Release;Debug\" CACHE STRING \"\" FORCE) # setting only two configuration types\r\nendif()\r\n\r\nI haven’t tested if this code changes the configurations available in Slicer but it’s quite likely. The configuration list override has been introduced by this commit:\r\nhttps://github.com/BRAINSia/BRAINSTools/commit/831eab6bc8a77b7fb224c7dc23d89bb38a16d56c\r\n\r\nWhich later Jc tuned:\r\nhttps://github.com/BRAINSia/BRAINSTools/commit/1a8e84b5b850a9f08338b23d80c18e459e0b01a1\r\n```"},"comment":{"url":"https://api.github.com/repos/BRAINSia/BRAINSTools/issues/comments/227839292","html_url":"https://github.com/BRAINSia/BRAINSTools/pull/284#issuecomment-227839292","issue_url":"https://api.github.com/repos/BRAINSia/BRAINSTools/issues/284","id":227839292,"user":{"login":"jcfr","id":219043,"avatar_url":"https://avatars.githubusercontent.com/u/219043?v=3","gravatar_id":"","url":"https://api.github.com/users/jcfr","html_url":"https://github.com/jcfr","followers_url":"https://api.github.com/users/jcfr/followers","following_url":"https://api.github.com/users/jcfr/following{/other_user}","gists_url":"https://api.github.com/users/jcfr/gists{/gist_id}","starred_url":"https://api.github.com/users/jcfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcfr/subscriptions","organizations_url":"https://api.github.com/users/jcfr/orgs","repos_url":"https://api.github.com/users/jcfr/repos","events_url":"https://api.github.com/users/jcfr/events{/privacy}","received_events_url":"https://api.github.com/users/jcfr/received_events","type":"User","site_admin":false},"created_at":"2016-06-22T18:43:24Z","updated_at":"2016-06-22T18:43:24Z","body":"@ajjl Thanks for the detailed report.\r\n\r\nWill investigate later today. We need to get this sorted out."}}
{"actor":{"display_login":"jcfr"}}