{"action":"created","issue":{"url":"https://api.github.com/repos/waterlink/rspec-json_expectations/issues/22","repository_url":"https://api.github.com/repos/waterlink/rspec-json_expectations","labels_url":"https://api.github.com/repos/waterlink/rspec-json_expectations/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/waterlink/rspec-json_expectations/issues/22/comments","events_url":"https://api.github.com/repos/waterlink/rspec-json_expectations/issues/22/events","html_url":"https://github.com/waterlink/rspec-json_expectations/issues/22","id":189345752,"number":22,"title":"include_unordered_json does not take missing items into account","user":{"login":"jeroenj","id":76424,"avatar_url":"https://avatars.githubusercontent.com/u/76424?v=3","gravatar_id":"","url":"https://api.github.com/users/jeroenj","html_url":"https://github.com/jeroenj","followers_url":"https://api.github.com/users/jeroenj/followers","following_url":"https://api.github.com/users/jeroenj/following{/other_user}","gists_url":"https://api.github.com/users/jeroenj/gists{/gist_id}","starred_url":"https://api.github.com/users/jeroenj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeroenj/subscriptions","organizations_url":"https://api.github.com/users/jeroenj/orgs","repos_url":"https://api.github.com/users/jeroenj/repos","events_url":"https://api.github.com/users/jeroenj/events{/privacy}","received_events_url":"https://api.github.com/users/jeroenj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-15T09:52:34Z","updated_at":"2016-11-16T12:55:00Z","closed_at":null,"body":"If the expected Array has less values than the actual Array the matcher succeeds:\r\n\r\n```ruby\r\nexpect(%([\"foo\", \"bar\", \"baz\"])).to include_unordered_json([\"foo\", \"bar\"]) # this will pass\r\n```\r\n\r\n/cc @esjee (since it was your contribution in #17)"},"comment":{"url":"https://api.github.com/repos/waterlink/rspec-json_expectations/issues/comments/260939364","html_url":"https://github.com/waterlink/rspec-json_expectations/issues/22#issuecomment-260939364","issue_url":"https://api.github.com/repos/waterlink/rspec-json_expectations/issues/22","id":260939364,"user":{"login":"jeroenj","id":76424,"avatar_url":"https://avatars.githubusercontent.com/u/76424?v=3","gravatar_id":"","url":"https://api.github.com/users/jeroenj","html_url":"https://github.com/jeroenj","followers_url":"https://api.github.com/users/jeroenj/followers","following_url":"https://api.github.com/users/jeroenj/following{/other_user}","gists_url":"https://api.github.com/users/jeroenj/gists{/gist_id}","starred_url":"https://api.github.com/users/jeroenj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeroenj/subscriptions","organizations_url":"https://api.github.com/users/jeroenj/orgs","repos_url":"https://api.github.com/users/jeroenj/repos","events_url":"https://api.github.com/users/jeroenj/events{/privacy}","received_events_url":"https://api.github.com/users/jeroenj/received_events","type":"User","site_admin":false},"created_at":"2016-11-16T12:55:00Z","updated_at":"2016-11-16T12:55:00Z","body":"Looks like a good idea but it might add some confusion. Maybe the naming wasn't optimal to start with. I haven't checked but I'd say that `match_json` and `match_unordered_json` would have been more clear to start with.\r\n\r\nI'd see what @waterlink has to say about it. Having `match_unordered_json` next to `include_unordered_json` would definately be a step in the right direction. 👍 "}}
{"actor":{"display_login":"jeroenj"}}