{"action":"created","issue":{"url":"https://api.github.com/repos/stormz/omniauth-base/issues/2","labels_url":"https://api.github.com/repos/stormz/omniauth-base/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/stormz/omniauth-base/issues/2/comments","events_url":"https://api.github.com/repos/stormz/omniauth-base/issues/2/events","html_url":"https://github.com/stormz/omniauth-base/pull/2","id":125470081,"number":2,"title":"Use provider compatible #callback_url implementation","user":{"login":"febeling","id":4313,"avatar_url":"https://avatars.githubusercontent.com/u/4313?v=3","gravatar_id":"","url":"https://api.github.com/users/febeling","html_url":"https://github.com/febeling","followers_url":"https://api.github.com/users/febeling/followers","following_url":"https://api.github.com/users/febeling/following{/other_user}","gists_url":"https://api.github.com/users/febeling/gists{/gist_id}","starred_url":"https://api.github.com/users/febeling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/febeling/subscriptions","organizations_url":"https://api.github.com/users/febeling/orgs","repos_url":"https://api.github.com/users/febeling/repos","events_url":"https://api.github.com/users/febeling/events{/privacy}","received_events_url":"https://api.github.com/users/febeling/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-01-07T19:40:59Z","updated_at":"2016-01-12T19:54:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stormz/omniauth-base/pulls/2","html_url":"https://github.com/stormz/omniauth-base/pull/2","diff_url":"https://github.com/stormz/omniauth-base/pull/2.diff","patch_url":"https://github.com/stormz/omniauth-base/pull/2.patch"},"body":"The implementation of `#callback_url` in omniauth-oauth2 base strategy\r\nchanged in a way that is more correct according to oauth spec, but breaks\r\nmany oauth providers.\r\n\r\nThis change adapts this strategy to the old behavior. That way\r\nomniauth-oauth2 1.4 can be used. That is better, as version 1.3.1 [seems\r\nto be incompatible with Rails 5](https://github.com/intridea/omniauth-oauth2/issues/81#issuecomment-168456154). \r\n\r\nThis fix is similar to what other strategies do. See e.g. [here](https://github.com/Shopify/omniauth-shopify-oauth2/commit/1a04cf0b4d168d91c0929dff731076bb04fb19ea) and [here](https://github.com/iainbeeston/omniauth-linkedin-oauth2/commit/a44d2cb39091665c6cc71a8ab861b3e8f30ea049)."},"comment":{"url":"https://api.github.com/repos/stormz/omniauth-base/issues/comments/171034434","html_url":"https://github.com/stormz/omniauth-base/pull/2#issuecomment-171034434","issue_url":"https://api.github.com/repos/stormz/omniauth-base/issues/2","id":171034434,"user":{"login":"francois2metz","id":86659,"avatar_url":"https://avatars.githubusercontent.com/u/86659?v=3","gravatar_id":"","url":"https://api.github.com/users/francois2metz","html_url":"https://github.com/francois2metz","followers_url":"https://api.github.com/users/francois2metz/followers","following_url":"https://api.github.com/users/francois2metz/following{/other_user}","gists_url":"https://api.github.com/users/francois2metz/gists{/gist_id}","starred_url":"https://api.github.com/users/francois2metz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francois2metz/subscriptions","organizations_url":"https://api.github.com/users/francois2metz/orgs","repos_url":"https://api.github.com/users/francois2metz/repos","events_url":"https://api.github.com/users/francois2metz/events{/privacy}","received_events_url":"https://api.github.com/users/francois2metz/received_events","type":"User","site_admin":false},"created_at":"2016-01-12T19:54:27Z","updated_at":"2016-01-12T19:54:27Z","body":":+1:"}}