{"action":"created","comment":{"url":"https://api.github.com/repos/zalando-stups/senza/pulls/comments/63042671","id":63042671,"diff_hunk":"@@ -19,5 +23,7 @@ def get_templates() -> dict:\n             # ignore bad entry points\n             continue\n         else:\n-            template_modules[e.name] = module\n+            # make sure the entry point resolves to a module with the essential interface functions\n+            if isinstance(module, ModuleType) and has_functions(module, ('gather_user_variables', 'generate_definition')):\n+                template_modules[e.name] = module","path":"senza/templates/__init__.py","position":23,"original_position":23,"commit_id":"c6f0f151fecdfb2acd6daf98e4956346988e6aa3","original_commit_id":"c6f0f151fecdfb2acd6daf98e4956346988e6aa3","user":{"login":"rafaelcaricio","id":107613,"avatar_url":"https://avatars.githubusercontent.com/u/107613?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelcaricio","html_url":"https://github.com/rafaelcaricio","followers_url":"https://api.github.com/users/rafaelcaricio/followers","following_url":"https://api.github.com/users/rafaelcaricio/following{/other_user}","gists_url":"https://api.github.com/users/rafaelcaricio/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelcaricio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelcaricio/subscriptions","organizations_url":"https://api.github.com/users/rafaelcaricio/orgs","repos_url":"https://api.github.com/users/rafaelcaricio/repos","events_url":"https://api.github.com/users/rafaelcaricio/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelcaricio/received_events","type":"User","site_admin":false},"body":"Would be nice to log in case templates do not conform with expectations. It is good for debugging, etc.","created_at":"2016-05-12T15:36:19Z","updated_at":"2016-05-12T15:36:19Z","html_url":"https://github.com/zalando-stups/senza/pull/213#discussion_r63042671","pull_request_url":"https://api.github.com/repos/zalando-stups/senza/pulls/213","_links":{"self":{"href":"https://api.github.com/repos/zalando-stups/senza/pulls/comments/63042671"},"html":{"href":"https://github.com/zalando-stups/senza/pull/213#discussion_r63042671"},"pull_request":{"href":"https://api.github.com/repos/zalando-stups/senza/pulls/213"}}},"pull_request":{"url":"https://api.github.com/repos/zalando-stups/senza/pulls/213","id":69845883,"html_url":"https://github.com/zalando-stups/senza/pull/213","diff_url":"https://github.com/zalando-stups/senza/pull/213.diff","patch_url":"https://github.com/zalando-stups/senza/pull/213.patch","issue_url":"https://api.github.com/repos/zalando-stups/senza/issues/213","number":213,"state":"open","locked":false,"title":"Fix minor issues with pluggable templates.","user":{"login":"alexeyklyukin","id":339913,"avatar_url":"https://avatars.githubusercontent.com/u/339913?v=3","gravatar_id":"","url":"https://api.github.com/users/alexeyklyukin","html_url":"https://github.com/alexeyklyukin","followers_url":"https://api.github.com/users/alexeyklyukin/followers","following_url":"https://api.github.com/users/alexeyklyukin/following{/other_user}","gists_url":"https://api.github.com/users/alexeyklyukin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeyklyukin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeyklyukin/subscriptions","organizations_url":"https://api.github.com/users/alexeyklyukin/orgs","repos_url":"https://api.github.com/users/alexeyklyukin/repos","events_url":"https://api.github.com/users/alexeyklyukin/events{/privacy}","received_events_url":"https://api.github.com/users/alexeyklyukin/received_events","type":"User","site_admin":false},"body":"- avoid crashing on a module without the description\r\n- make sure a template to plug is always a module (i.e. not a function).","created_at":"2016-05-12T14:26:05Z","updated_at":"2016-05-12T15:36:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04d70dc4d6d56157d9e77640a40ffeb954834636","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zalando-stups/senza/pulls/213/commits","review_comments_url":"https://api.github.com/repos/zalando-stups/senza/pulls/213/comments","review_comment_url":"https://api.github.com/repos/zalando-stups/senza/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando-stups/senza/issues/213/comments","statuses_url":"https://api.github.com/repos/zalando-stups/senza/statuses/c6f0f151fecdfb2acd6daf98e4956346988e6aa3","head":{"label":"alexeyklyukin:bugfix/entrypoints-templates","ref":"bugfix/entrypoints-templates","sha":"c6f0f151fecdfb2acd6daf98e4956346988e6aa3","user":{"login":"alexeyklyukin","id":339913,"avatar_url":"https://avatars.githubusercontent.com/u/339913?v=3","gravatar_id":"","url":"https://api.github.com/users/alexeyklyukin","html_url":"https://github.com/alexeyklyukin","followers_url":"https://api.github.com/users/alexeyklyukin/followers","following_url":"https://api.github.com/users/alexeyklyukin/following{/other_user}","gists_url":"https://api.github.com/users/alexeyklyukin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeyklyukin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeyklyukin/subscriptions","organizations_url":"https://api.github.com/users/alexeyklyukin/orgs","repos_url":"https://api.github.com/users/alexeyklyukin/repos","events_url":"https://api.github.com/users/alexeyklyukin/events{/privacy}","received_events_url":"https://api.github.com/users/alexeyklyukin/received_events","type":"User","site_admin":false},"repo":{"id":35435128,"name":"senza","full_name":"alexeyklyukin/senza","owner":{"login":"alexeyklyukin","id":339913,"avatar_url":"https://avatars.githubusercontent.com/u/339913?v=3","gravatar_id":"","url":"https://api.github.com/users/alexeyklyukin","html_url":"https://github.com/alexeyklyukin","followers_url":"https://api.github.com/users/alexeyklyukin/followers","following_url":"https://api.github.com/users/alexeyklyukin/following{/other_user}","gists_url":"https://api.github.com/users/alexeyklyukin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeyklyukin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeyklyukin/subscriptions","organizations_url":"https://api.github.com/users/alexeyklyukin/orgs","repos_url":"https://api.github.com/users/alexeyklyukin/repos","events_url":"https://api.github.com/users/alexeyklyukin/events{/privacy}","received_events_url":"https://api.github.com/users/alexeyklyukin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexeyklyukin/senza","description":"Create and execute AWS CloudFormation templates in a sane way.","fork":true,"url":"https://api.github.com/repos/alexeyklyukin/senza","forks_url":"https://api.github.com/repos/alexeyklyukin/senza/forks","keys_url":"https://api.github.com/repos/alexeyklyukin/senza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexeyklyukin/senza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexeyklyukin/senza/teams","hooks_url":"https://api.github.com/repos/alexeyklyukin/senza/hooks","issue_events_url":"https://api.github.com/repos/alexeyklyukin/senza/issues/events{/number}","events_url":"https://api.github.com/repos/alexeyklyukin/senza/events","assignees_url":"https://api.github.com/repos/alexeyklyukin/senza/assignees{/user}","branches_url":"https://api.github.com/repos/alexeyklyukin/senza/branches{/branch}","tags_url":"https://api.github.com/repos/alexeyklyukin/senza/tags","blobs_url":"https://api.github.com/repos/alexeyklyukin/senza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexeyklyukin/senza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexeyklyukin/senza/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexeyklyukin/senza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexeyklyukin/senza/statuses/{sha}","languages_url":"https://api.github.com/repos/alexeyklyukin/senza/languages","stargazers_url":"https://api.github.com/repos/alexeyklyukin/senza/stargazers","contributors_url":"https://api.github.com/repos/alexeyklyukin/senza/contributors","subscribers_url":"https://api.github.com/repos/alexeyklyukin/senza/subscribers","subscription_url":"https://api.github.com/repos/alexeyklyukin/senza/subscription","commits_url":"https://api.github.com/repos/alexeyklyukin/senza/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexeyklyukin/senza/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexeyklyukin/senza/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexeyklyukin/senza/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexeyklyukin/senza/contents/{+path}","compare_url":"https://api.github.com/repos/alexeyklyukin/senza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexeyklyukin/senza/merges","archive_url":"https://api.github.com/repos/alexeyklyukin/senza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexeyklyukin/senza/downloads","issues_url":"https://api.github.com/repos/alexeyklyukin/senza/issues{/number}","pulls_url":"https://api.github.com/repos/alexeyklyukin/senza/pulls{/number}","milestones_url":"https://api.github.com/repos/alexeyklyukin/senza/milestones{/number}","notifications_url":"https://api.github.com/repos/alexeyklyukin/senza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexeyklyukin/senza/labels{/name}","releases_url":"https://api.github.com/repos/alexeyklyukin/senza/releases{/id}","deployments_url":"https://api.github.com/repos/alexeyklyukin/senza/deployments","created_at":"2015-05-11T16:15:13Z","updated_at":"2015-05-11T16:15:13Z","pushed_at":"2016-05-12T15:32:14Z","git_url":"git://github.com/alexeyklyukin/senza.git","ssh_url":"git@github.com:alexeyklyukin/senza.git","clone_url":"https://github.com/alexeyklyukin/senza.git","svn_url":"https://github.com/alexeyklyukin/senza","homepage":"http://stups.readthedocs.org/en/latest/components/senza.html","size":622,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zalando-stups:master","ref":"master","sha":"fa5f9c672aa125b83845a529b360ea3132492dd4","user":{"login":"zalando-stups","id":11431876,"avatar_url":"https://avatars.githubusercontent.com/u/11431876?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-stups","html_url":"https://github.com/zalando-stups","followers_url":"https://api.github.com/users/zalando-stups/followers","following_url":"https://api.github.com/users/zalando-stups/following{/other_user}","gists_url":"https://api.github.com/users/zalando-stups/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-stups/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-stups/subscriptions","organizations_url":"https://api.github.com/users/zalando-stups/orgs","repos_url":"https://api.github.com/users/zalando-stups/repos","events_url":"https://api.github.com/users/zalando-stups/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-stups/received_events","type":"Organization","site_admin":false},"repo":{"id":33120392,"name":"senza","full_name":"zalando-stups/senza","owner":{"login":"zalando-stups","id":11431876,"avatar_url":"https://avatars.githubusercontent.com/u/11431876?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-stups","html_url":"https://github.com/zalando-stups","followers_url":"https://api.github.com/users/zalando-stups/followers","following_url":"https://api.github.com/users/zalando-stups/following{/other_user}","gists_url":"https://api.github.com/users/zalando-stups/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-stups/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-stups/subscriptions","organizations_url":"https://api.github.com/users/zalando-stups/orgs","repos_url":"https://api.github.com/users/zalando-stups/repos","events_url":"https://api.github.com/users/zalando-stups/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-stups/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-stups/senza","description":"Deploy immutable application stacks and create and execute AWS CloudFormation templates in a sane way.","fork":false,"url":"https://api.github.com/repos/zalando-stups/senza","forks_url":"https://api.github.com/repos/zalando-stups/senza/forks","keys_url":"https://api.github.com/repos/zalando-stups/senza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-stups/senza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-stups/senza/teams","hooks_url":"https://api.github.com/repos/zalando-stups/senza/hooks","issue_events_url":"https://api.github.com/repos/zalando-stups/senza/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-stups/senza/events","assignees_url":"https://api.github.com/repos/zalando-stups/senza/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-stups/senza/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-stups/senza/tags","blobs_url":"https://api.github.com/repos/zalando-stups/senza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-stups/senza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-stups/senza/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-stups/senza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-stups/senza/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-stups/senza/languages","stargazers_url":"https://api.github.com/repos/zalando-stups/senza/stargazers","contributors_url":"https://api.github.com/repos/zalando-stups/senza/contributors","subscribers_url":"https://api.github.com/repos/zalando-stups/senza/subscribers","subscription_url":"https://api.github.com/repos/zalando-stups/senza/subscription","commits_url":"https://api.github.com/repos/zalando-stups/senza/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-stups/senza/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-stups/senza/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-stups/senza/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-stups/senza/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-stups/senza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-stups/senza/merges","archive_url":"https://api.github.com/repos/zalando-stups/senza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-stups/senza/downloads","issues_url":"https://api.github.com/repos/zalando-stups/senza/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-stups/senza/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-stups/senza/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-stups/senza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-stups/senza/labels{/name}","releases_url":"https://api.github.com/repos/zalando-stups/senza/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-stups/senza/deployments","created_at":"2015-03-30T11:56:30Z","updated_at":"2016-05-12T12:44:46Z","pushed_at":"2016-05-12T15:32:14Z","git_url":"git://github.com/zalando-stups/senza.git","ssh_url":"git@github.com:zalando-stups/senza.git","clone_url":"https://github.com/zalando-stups/senza.git","svn_url":"https://github.com/zalando-stups/senza","homepage":"http://docs.stups.io/en/latest/components/senza.html","size":709,"stargazers_count":42,"watchers_count":42,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":38,"forks":34,"open_issues":38,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando-stups/senza/pulls/213"},"html":{"href":"https://github.com/zalando-stups/senza/pull/213"},"issue":{"href":"https://api.github.com/repos/zalando-stups/senza/issues/213"},"comments":{"href":"https://api.github.com/repos/zalando-stups/senza/issues/213/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando-stups/senza/pulls/213/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando-stups/senza/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando-stups/senza/pulls/213/commits"},"statuses":{"href":"https://api.github.com/repos/zalando-stups/senza/statuses/c6f0f151fecdfb2acd6daf98e4956346988e6aa3"}}}}