{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/13323","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/13323/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/13323/comments","events_url":"https://api.github.com/repos/servo/servo/issues/13323/events","html_url":"https://github.com/servo/servo/pull/13323","id":177848444,"number":13323,"title":"Implement the Fetch method","user":{"login":"jeenalee","id":8248574,"avatar_url":"https://avatars.githubusercontent.com/u/8248574?v=3","gravatar_id":"","url":"https://api.github.com/users/jeenalee","html_url":"https://github.com/jeenalee","followers_url":"https://api.github.com/users/jeenalee/followers","following_url":"https://api.github.com/users/jeenalee/following{/other_user}","gists_url":"https://api.github.com/users/jeenalee/gists{/gist_id}","starred_url":"https://api.github.com/users/jeenalee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeenalee/subscriptions","organizations_url":"https://api.github.com/users/jeenalee/orgs","repos_url":"https://api.github.com/users/jeenalee/repos","events_url":"https://api.github.com/users/jeenalee/events{/privacy}","received_events_url":"https://api.github.com/users/jeenalee/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"assignees":[{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false}],"milestone":null,"comments":64,"created_at":"2016-09-19T17:37:37Z","updated_at":"2016-09-28T03:33:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/13323","html_url":"https://github.com/servo/servo/pull/13323","diff_url":"https://github.com/servo/servo/pull/13323.diff","patch_url":"https://github.com/servo/servo/pull/13323.patch"},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\nThis PR implements the fetch method, which is described in [the Fetch Spec](https://fetch.spec.whatwg.org/#fetch-method). The expected wpt results are updated as well.\r\n\r\nA few comments about the current fetch implementation:\r\n- The fetch method manually calls `JSAutoCompartment` in order to prevent SpiderMonkey from crashing. This may have to change in the future.\r\n- Not all `FetchResponseListener` methods are implemented.\r\n- `net_traits::CoreResourceMsg::Fetch` message takes a `net_traits::request::RequestInit`. However, when the fetch method is called, a `RequestBinding::RequestInit` is given. The fetch method constructs a `dom::request::Request` with the given `RequestInit`, then creates `net_traits::request::RequestInit` from the dom Request object for the fetch message.\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [X] These changes fix #11898 (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [X] There are tests for these changes OR\r\n- [ ] These changes do not require tests because _____\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/13323)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/250063221","html_url":"https://github.com/servo/servo/pull/13323#issuecomment-250063221","issue_url":"https://api.github.com/repos/servo/servo/issues/13323","id":250063221,"user":{"login":"bors-servo","id":4368172,"avatar_url":"https://avatars.githubusercontent.com/u/4368172?v=3","gravatar_id":"","url":"https://api.github.com/users/bors-servo","html_url":"https://github.com/bors-servo","followers_url":"https://api.github.com/users/bors-servo/followers","following_url":"https://api.github.com/users/bors-servo/following{/other_user}","gists_url":"https://api.github.com/users/bors-servo/gists{/gist_id}","starred_url":"https://api.github.com/users/bors-servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors-servo/subscriptions","organizations_url":"https://api.github.com/users/bors-servo/orgs","repos_url":"https://api.github.com/users/bors-servo/repos","events_url":"https://api.github.com/users/bors-servo/events{/privacy}","received_events_url":"https://api.github.com/users/bors-servo/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T03:33:24Z","updated_at":"2016-09-28T03:33:24Z","body":":pushpin: Commit 8a15e78 has been approved by `jdm`\n\n<!-- @bors-servo r=jdm 8a15e784fc11266479691750c6465488fefddfa5 -->"}}
{"actor":{"display_login":"bors-servo"}}