{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaOpt/Optim.jl/issues/149","labels_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/issues/149/labels{/name}","comments_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/issues/149/comments","events_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/issues/149/events","html_url":"https://github.com/JuliaOpt/Optim.jl/pull/149","id":113148559,"number":149,"title":"[WIP] Replace method symbols with abstract types","user":{"login":"Evizero","id":10854026,"avatar_url":"https://avatars.githubusercontent.com/u/10854026?v=3","gravatar_id":"","url":"https://api.github.com/users/Evizero","html_url":"https://github.com/Evizero","followers_url":"https://api.github.com/users/Evizero/followers","following_url":"https://api.github.com/users/Evizero/following{/other_user}","gists_url":"https://api.github.com/users/Evizero/gists{/gist_id}","starred_url":"https://api.github.com/users/Evizero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Evizero/subscriptions","organizations_url":"https://api.github.com/users/Evizero/orgs","repos_url":"https://api.github.com/users/Evizero/repos","events_url":"https://api.github.com/users/Evizero/events{/privacy}","received_events_url":"https://api.github.com/users/Evizero/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":21,"created_at":"2015-10-24T10:01:26Z","updated_at":"2016-02-01T16:43:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JuliaOpt/Optim.jl/pulls/149","html_url":"https://github.com/JuliaOpt/Optim.jl/pull/149","diff_url":"https://github.com/JuliaOpt/Optim.jl/pull/149.diff","patch_url":"https://github.com/JuliaOpt/Optim.jl/pull/149.patch"},"body":"As discussed in #145 . \r\n\r\n- [x] Replace method symbols with abstract types to exploit type dispatch and simplify exposing custom keyword arguments for different methods\r\n- [x] remove nnls\r\n- [x] clean up tests to use types instead of symbols to specify the method\r\n- [x] deprecate old standalone methods (e.g. Optim.l_bfgs)\r\n- [ ] add tests for deprecated methods (?)\r\n- [x] Use hashtable for method symbols\r\n- [ ] Adapt readme to new API\r\n\r\n~~This works right now although the tests still need some clean-up.~~\r\n\r\nI thought this would be a good point to gather feedback"},"comment":{"url":"https://api.github.com/repos/JuliaOpt/Optim.jl/issues/comments/178061949","html_url":"https://github.com/JuliaOpt/Optim.jl/pull/149#issuecomment-178061949","issue_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/issues/149","id":178061949,"user":{"login":"Evizero","id":10854026,"avatar_url":"https://avatars.githubusercontent.com/u/10854026?v=3","gravatar_id":"","url":"https://api.github.com/users/Evizero","html_url":"https://github.com/Evizero","followers_url":"https://api.github.com/users/Evizero/followers","following_url":"https://api.github.com/users/Evizero/following{/other_user}","gists_url":"https://api.github.com/users/Evizero/gists{/gist_id}","starred_url":"https://api.github.com/users/Evizero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Evizero/subscriptions","organizations_url":"https://api.github.com/users/Evizero/orgs","repos_url":"https://api.github.com/users/Evizero/repos","events_url":"https://api.github.com/users/Evizero/events{/privacy}","received_events_url":"https://api.github.com/users/Evizero/received_events","type":"User","site_admin":false},"created_at":"2016-02-01T16:43:37Z","updated_at":"2016-02-01T16:43:37Z","body":"I completely forgot about the readme. I'll adapt it as well"}}