{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcsfuse/issues/194","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/gcsfuse","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/gcsfuse/issues/194/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcsfuse/issues/194/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcsfuse/issues/194/events","html_url":"https://github.com/GoogleCloudPlatform/gcsfuse/pull/194","id":180705385,"number":194,"title":"Patch for gcsfuse systemd integration","user":{"login":"jbaublitz","id":4952094,"avatar_url":"https://avatars.githubusercontent.com/u/4952094?v=3","gravatar_id":"","url":"https://api.github.com/users/jbaublitz","html_url":"https://github.com/jbaublitz","followers_url":"https://api.github.com/users/jbaublitz/followers","following_url":"https://api.github.com/users/jbaublitz/following{/other_user}","gists_url":"https://api.github.com/users/jbaublitz/gists{/gist_id}","starred_url":"https://api.github.com/users/jbaublitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbaublitz/subscriptions","organizations_url":"https://api.github.com/users/jbaublitz/orgs","repos_url":"https://api.github.com/users/jbaublitz/repos","events_url":"https://api.github.com/users/jbaublitz/events{/privacy}","received_events_url":"https://api.github.com/users/jbaublitz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-03T18:01:48Z","updated_at":"2016-10-07T02:47:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcsfuse/pulls/194","html_url":"https://github.com/GoogleCloudPlatform/gcsfuse/pull/194","diff_url":"https://github.com/GoogleCloudPlatform/gcsfuse/pull/194.diff","patch_url":"https://github.com/GoogleCloudPlatform/gcsfuse/pull/194.patch"},"body":"This pull request is meant to enable gcsfuse mounting from systemd. After digging a little bit, it seems systemd supplies the ```-n``` (```--no-mtab```) option to whatever mount executable helper is invoked based on the type of filesystem specified as the mount in the ```.mount``` file. See [this link](https://www.freedesktop.org/software/systemd/man/systemd.mount.html#) for more information on ```.mount``` files but the basic idea is to expose filesystem mounts as a service that is callable from systemd and allows service dependency resolution based on what filesystems have been mounted. While including the ```-n``` flag might make sense in the systemd context given the developments around turning ```/etc/mtab``` into a symlink to ```/proc/self/mounts``` which is read only on my system, gcsfuse sees this as a bad flag so it cannot be integrated into a systemd mount file. There does not seem to be a flag to disable the ```-n``` flag when systemd invokes the mount helper so the simplest solution seems to be to ignore the ```-n``` flag from the gcsfuse mount helper. I'm open to discussion around this but given that ```-n``` is a standard flag in the ```mount``` command, I think it might be beneficial not just for this use case but for others as well to accept and ignore it for compatibility reasons similar to this one. I'm going to add an integration test so this is not yet ready to be merged but have submitted this patch so that we can at least start a discussion in case anyone working on this project is opposed or has other suggestions."},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcsfuse/issues/comments/252141016","html_url":"https://github.com/GoogleCloudPlatform/gcsfuse/pull/194#issuecomment-252141016","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/gcsfuse/issues/194","id":252141016,"user":{"login":"jacobsa","id":202895,"avatar_url":"https://avatars.githubusercontent.com/u/202895?v=3","gravatar_id":"","url":"https://api.github.com/users/jacobsa","html_url":"https://github.com/jacobsa","followers_url":"https://api.github.com/users/jacobsa/followers","following_url":"https://api.github.com/users/jacobsa/following{/other_user}","gists_url":"https://api.github.com/users/jacobsa/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobsa/subscriptions","organizations_url":"https://api.github.com/users/jacobsa/orgs","repos_url":"https://api.github.com/users/jacobsa/repos","events_url":"https://api.github.com/users/jacobsa/events{/privacy}","received_events_url":"https://api.github.com/users/jacobsa/received_events","type":"User","site_admin":false},"created_at":"2016-10-07T02:47:11Z","updated_at":"2016-10-07T02:47:11Z","body":"I'm happy with this in principle, thanks. Please add a bit more context to the comment in the code and an integration test."}}
{"actor":{"display_login":"jacobsa"}}