{"action":"created","comment":{"url":"https://api.github.com/repos/jwforres/origin/pulls/comments/60741319","id":60741319,"diff_hunk":"@@ -886,12 +918,19 @@ DataService.prototype.createStream = function(resource, name, context, opts, isR\n       }).success(function(data, status, headerFunc, config, statusText) {\n         self._listOpComplete(resource, context, data);\n       }).error(function(data, status, headers, config) {\n-        var msg = \"Failed to list \" + resource;\n-        if (status !== 0) {\n-          msg += \" (\" + status + \")\";\n+        // mark list op as complete\n+        self._listInFlight(resource, context, false);","path":"assets/app/scripts/services/data.js","position":116,"original_position":116,"commit_id":"c167400c2098923dac5f6e54e125740baf4ffeab","original_commit_id":"c167400c2098923dac5f6e54e125740baf4ffeab","user":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars.githubusercontent.com/u/280512?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"body":"Above comment about `_listOpError()` could eliminate duplicate code here.","created_at":"2016-04-22T13:51:00Z","updated_at":"2016-04-22T13:51:01Z","html_url":"https://github.com/jwforres/origin/pull/62#discussion_r60741319","pull_request_url":"https://api.github.com/repos/jwforres/origin/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/jwforres/origin/pulls/comments/60741319"},"html":{"href":"https://github.com/jwforres/origin/pull/62#discussion_r60741319"},"pull_request":{"href":"https://api.github.com/repos/jwforres/origin/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/jwforres/origin/pulls/62","id":67432326,"html_url":"https://github.com/jwforres/origin/pull/62","diff_url":"https://github.com/jwforres/origin/pull/62.diff","patch_url":"https://github.com/jwforres/origin/pull/62.patch","issue_url":"https://api.github.com/repos/jwforres/origin/issues/62","number":62,"state":"open","locked":false,"title":"[WIP] return promise from DataService.list","user":{"login":"jwforres","id":1467629,"avatar_url":"https://avatars.githubusercontent.com/u/1467629?v=3","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-21T22:25:13Z","updated_at":"2016-04-22T13:51:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5995e74b59a102da8a40b49b611145cc5ffa41c1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jwforres/origin/pulls/62/commits","review_comments_url":"https://api.github.com/repos/jwforres/origin/pulls/62/comments","review_comment_url":"https://api.github.com/repos/jwforres/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jwforres/origin/issues/62/comments","statuses_url":"https://api.github.com/repos/jwforres/origin/statuses/c167400c2098923dac5f6e54e125740baf4ffeab","head":{"label":"jwforres:list_promises","ref":"list_promises","sha":"c167400c2098923dac5f6e54e125740baf4ffeab","user":{"login":"jwforres","id":1467629,"avatar_url":"https://avatars.githubusercontent.com/u/1467629?v=3","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"repo":{"id":22971182,"name":"origin","full_name":"jwforres/origin","owner":{"login":"jwforres","id":1467629,"avatar_url":"https://avatars.githubusercontent.com/u/1467629?v=3","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jwforres/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/jwforres/origin","forks_url":"https://api.github.com/repos/jwforres/origin/forks","keys_url":"https://api.github.com/repos/jwforres/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwforres/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwforres/origin/teams","hooks_url":"https://api.github.com/repos/jwforres/origin/hooks","issue_events_url":"https://api.github.com/repos/jwforres/origin/issues/events{/number}","events_url":"https://api.github.com/repos/jwforres/origin/events","assignees_url":"https://api.github.com/repos/jwforres/origin/assignees{/user}","branches_url":"https://api.github.com/repos/jwforres/origin/branches{/branch}","tags_url":"https://api.github.com/repos/jwforres/origin/tags","blobs_url":"https://api.github.com/repos/jwforres/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwforres/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwforres/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwforres/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwforres/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/jwforres/origin/languages","stargazers_url":"https://api.github.com/repos/jwforres/origin/stargazers","contributors_url":"https://api.github.com/repos/jwforres/origin/contributors","subscribers_url":"https://api.github.com/repos/jwforres/origin/subscribers","subscription_url":"https://api.github.com/repos/jwforres/origin/subscription","commits_url":"https://api.github.com/repos/jwforres/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwforres/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwforres/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwforres/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwforres/origin/contents/{+path}","compare_url":"https://api.github.com/repos/jwforres/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwforres/origin/merges","archive_url":"https://api.github.com/repos/jwforres/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwforres/origin/downloads","issues_url":"https://api.github.com/repos/jwforres/origin/issues{/number}","pulls_url":"https://api.github.com/repos/jwforres/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/jwforres/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/jwforres/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwforres/origin/labels{/name}","releases_url":"https://api.github.com/repos/jwforres/origin/releases{/id}","deployments_url":"https://api.github.com/repos/jwforres/origin/deployments","created_at":"2014-08-14T22:53:50Z","updated_at":"2016-03-23T15:27:09Z","pushed_at":"2016-04-22T13:34:24Z","git_url":"git://github.com/jwforres/origin.git","ssh_url":"git@github.com:jwforres/origin.git","clone_url":"https://github.com/jwforres/origin.git","svn_url":"https://github.com/jwforres/origin","homepage":"https://openshift.github.io","size":259145,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"jwforres:console_1.3","ref":"console_1.3","sha":"cb6a5f9516c5f0b449a932f8fdebc1285acd276c","user":{"login":"jwforres","id":1467629,"avatar_url":"https://avatars.githubusercontent.com/u/1467629?v=3","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"repo":{"id":22971182,"name":"origin","full_name":"jwforres/origin","owner":{"login":"jwforres","id":1467629,"avatar_url":"https://avatars.githubusercontent.com/u/1467629?v=3","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jwforres/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/jwforres/origin","forks_url":"https://api.github.com/repos/jwforres/origin/forks","keys_url":"https://api.github.com/repos/jwforres/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwforres/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwforres/origin/teams","hooks_url":"https://api.github.com/repos/jwforres/origin/hooks","issue_events_url":"https://api.github.com/repos/jwforres/origin/issues/events{/number}","events_url":"https://api.github.com/repos/jwforres/origin/events","assignees_url":"https://api.github.com/repos/jwforres/origin/assignees{/user}","branches_url":"https://api.github.com/repos/jwforres/origin/branches{/branch}","tags_url":"https://api.github.com/repos/jwforres/origin/tags","blobs_url":"https://api.github.com/repos/jwforres/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwforres/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwforres/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwforres/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwforres/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/jwforres/origin/languages","stargazers_url":"https://api.github.com/repos/jwforres/origin/stargazers","contributors_url":"https://api.github.com/repos/jwforres/origin/contributors","subscribers_url":"https://api.github.com/repos/jwforres/origin/subscribers","subscription_url":"https://api.github.com/repos/jwforres/origin/subscription","commits_url":"https://api.github.com/repos/jwforres/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwforres/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwforres/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwforres/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwforres/origin/contents/{+path}","compare_url":"https://api.github.com/repos/jwforres/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwforres/origin/merges","archive_url":"https://api.github.com/repos/jwforres/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwforres/origin/downloads","issues_url":"https://api.github.com/repos/jwforres/origin/issues{/number}","pulls_url":"https://api.github.com/repos/jwforres/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/jwforres/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/jwforres/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwforres/origin/labels{/name}","releases_url":"https://api.github.com/repos/jwforres/origin/releases{/id}","deployments_url":"https://api.github.com/repos/jwforres/origin/deployments","created_at":"2014-08-14T22:53:50Z","updated_at":"2016-03-23T15:27:09Z","pushed_at":"2016-04-22T13:34:24Z","git_url":"git://github.com/jwforres/origin.git","ssh_url":"git@github.com:jwforres/origin.git","clone_url":"https://github.com/jwforres/origin.git","svn_url":"https://github.com/jwforres/origin","homepage":"https://openshift.github.io","size":259145,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jwforres/origin/pulls/62"},"html":{"href":"https://github.com/jwforres/origin/pull/62"},"issue":{"href":"https://api.github.com/repos/jwforres/origin/issues/62"},"comments":{"href":"https://api.github.com/repos/jwforres/origin/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/jwforres/origin/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/jwforres/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jwforres/origin/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/jwforres/origin/statuses/c167400c2098923dac5f6e54e125740baf4ffeab"}}}}