{"action":"created","issue":{"url":"https://api.github.com/repos/bazelbuild/bazel/issues/1906","repository_url":"https://api.github.com/repos/bazelbuild/bazel","labels_url":"https://api.github.com/repos/bazelbuild/bazel/issues/1906/labels{/name}","comments_url":"https://api.github.com/repos/bazelbuild/bazel/issues/1906/comments","events_url":"https://api.github.com/repos/bazelbuild/bazel/issues/1906/events","html_url":"https://github.com/bazelbuild/bazel/issues/1906","id":181810062,"number":1906,"title":"`bazel clean --expunge_async` silently orphans output dir on Mac (and fails on Win?)","user":{"login":"mmdriley","id":1052311,"avatar_url":"https://avatars.githubusercontent.com/u/1052311?v=3","gravatar_id":"","url":"https://api.github.com/users/mmdriley","html_url":"https://github.com/mmdriley","followers_url":"https://api.github.com/users/mmdriley/followers","following_url":"https://api.github.com/users/mmdriley/following{/other_user}","gists_url":"https://api.github.com/users/mmdriley/gists{/gist_id}","starred_url":"https://api.github.com/users/mmdriley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmdriley/subscriptions","organizations_url":"https://api.github.com/users/mmdriley/orgs","repos_url":"https://api.github.com/users/mmdriley/repos","events_url":"https://api.github.com/users/mmdriley/events{/privacy}","received_events_url":"https://api.github.com/users/mmdriley/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bazelbuild/bazel/labels/category:%20multi-platform%20%3E%20other","name":"category: multi-platform > other","color":"d4c5f9"},{"url":"https://api.github.com/repos/bazelbuild/bazel/labels/P1","name":"P1","color":"d93f0b"},{"url":"https://api.github.com/repos/bazelbuild/bazel/labels/type:%20bug","name":"type: bug","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/bazelbuild/bazel/milestones/3","html_url":"https://github.com/bazelbuild/bazel/milestones/0.4","labels_url":"https://api.github.com/repos/bazelbuild/bazel/milestones/3/labels","id":1582921,"number":3,"title":"0.4","description":"","creator":{"login":"damienmg","id":3721087,"avatar_url":"https://avatars.githubusercontent.com/u/3721087?v=3","gravatar_id":"","url":"https://api.github.com/users/damienmg","html_url":"https://github.com/damienmg","followers_url":"https://api.github.com/users/damienmg/followers","following_url":"https://api.github.com/users/damienmg/following{/other_user}","gists_url":"https://api.github.com/users/damienmg/gists{/gist_id}","starred_url":"https://api.github.com/users/damienmg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienmg/subscriptions","organizations_url":"https://api.github.com/users/damienmg/orgs","repos_url":"https://api.github.com/users/damienmg/repos","events_url":"https://api.github.com/users/damienmg/events{/privacy}","received_events_url":"https://api.github.com/users/damienmg/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":71,"state":"open","created_at":"2016-02-15T10:16:35Z","updated_at":"2016-10-12T10:54:53Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-10-08T07:15:54Z","updated_at":"2016-10-12T16:56:59Z","closed_at":null,"body":"`bazel clean --expunge_async` tries to run the same command, independent of OS:\r\n`exec >&- 2>&- <&- && (/usr/bin/setsid /bin/rm -rf %s &)&`\r\n(https://github.com/bazelbuild/bazel/blob/c484f19a2cf7427887d6e4c71c8534806e1ba83e/src/main/java/com/google/devtools/build/lib/runtime/commands/CleanCommand.java#L152)\r\n\r\n`/usr/bin/setsid` doesn't exist on Mac OS X, so `blaze clean --expunge_async` effectively means: move the big cache somewhere else and leave it there forever. Even though the code claims to look at the error result, this fails _silently_ for me on OS X.\r\n\r\nI can only imagine how this fails on Windows.\r\n\r\nP0 should be to fail the `expunge_async` command on any non-Linux platforms. P2 would be to make it work."},"comment":{"url":"https://api.github.com/repos/bazelbuild/bazel/issues/comments/253272616","html_url":"https://github.com/bazelbuild/bazel/issues/1906#issuecomment-253272616","issue_url":"https://api.github.com/repos/bazelbuild/bazel/issues/1906","id":253272616,"user":{"login":"mmdriley","id":1052311,"avatar_url":"https://avatars.githubusercontent.com/u/1052311?v=3","gravatar_id":"","url":"https://api.github.com/users/mmdriley","html_url":"https://github.com/mmdriley","followers_url":"https://api.github.com/users/mmdriley/followers","following_url":"https://api.github.com/users/mmdriley/following{/other_user}","gists_url":"https://api.github.com/users/mmdriley/gists{/gist_id}","starred_url":"https://api.github.com/users/mmdriley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmdriley/subscriptions","organizations_url":"https://api.github.com/users/mmdriley/orgs","repos_url":"https://api.github.com/users/mmdriley/repos","events_url":"https://api.github.com/users/mmdriley/events{/privacy}","received_events_url":"https://api.github.com/users/mmdriley/received_events","type":"User","site_admin":false},"created_at":"2016-10-12T16:56:59Z","updated_at":"2016-10-12T16:56:59Z","body":"I don't think so. #1586 is about `clean --expunge`, which seems to use a cross-platform delete: https://github.com/bazelbuild/bazel/blob/c484f19a2cf7427887d6e4c71c8534806e1ba83e/src/main/java/com/google/devtools/build/lib/runtime/commands/CleanCommand.java#L137\r\n\r\nIn this case, the command fails on Windows because Windows isn't Linux."}}
{"actor":{"display_login":"mmdriley"}}