{"action":"created","comment":{"url":"https://api.github.com/repos/remind101/empire/pulls/comments/69830793","id":69830793,"diff_hunk":"@@ -274,9 +277,138 @@ func (s *Scheduler) submit(ctx context.Context, tx *sql.Tx, app *scheduler.App,\n \t\t}\n \t}\n \n+\tgo s.waitForDeploymentToStabilize(ctx, app, stackName, events, done)","path":"scheduler/cloudformation/cloudformation.go","position":57,"original_position":57,"commit_id":"c1ea348005d0c4eb832858810a87cf7926295118","original_commit_id":"c1ea348005d0c4eb832858810a87cf7926295118","user":{"login":"mhahn","id":704593,"avatar_url":"https://avatars.githubusercontent.com/u/704593?v=3","gravatar_id":"","url":"https://api.github.com/users/mhahn","html_url":"https://github.com/mhahn","followers_url":"https://api.github.com/users/mhahn/followers","following_url":"https://api.github.com/users/mhahn/following{/other_user}","gists_url":"https://api.github.com/users/mhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/mhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhahn/subscriptions","organizations_url":"https://api.github.com/users/mhahn/orgs","repos_url":"https://api.github.com/users/mhahn/repos","events_url":"https://api.github.com/users/mhahn/events{/privacy}","received_events_url":"https://api.github.com/users/mhahn/received_events","type":"User","site_admin":false},"body":"this needs to handle if `wait` is specified","created_at":"2016-07-06T23:37:37Z","updated_at":"2016-07-06T23:37:37Z","html_url":"https://github.com/remind101/empire/pull/916#discussion_r69830793","pull_request_url":"https://api.github.com/repos/remind101/empire/pulls/916","_links":{"self":{"href":"https://api.github.com/repos/remind101/empire/pulls/comments/69830793"},"html":{"href":"https://github.com/remind101/empire/pull/916#discussion_r69830793"},"pull_request":{"href":"https://api.github.com/repos/remind101/empire/pulls/916"}}},"pull_request":{"url":"https://api.github.com/repos/remind101/empire/pulls/916","id":76519030,"html_url":"https://github.com/remind101/empire/pull/916","diff_url":"https://github.com/remind101/empire/pull/916.diff","patch_url":"https://github.com/remind101/empire/pull/916.patch","issue_url":"https://api.github.com/repos/remind101/empire/issues/916","number":916,"state":"open","locked":false,"title":"Deployment notifications","user":{"login":"mhahn","id":704593,"avatar_url":"https://avatars.githubusercontent.com/u/704593?v=3","gravatar_id":"","url":"https://api.github.com/users/mhahn","html_url":"https://github.com/mhahn","followers_url":"https://api.github.com/users/mhahn/followers","following_url":"https://api.github.com/users/mhahn/following{/other_user}","gists_url":"https://api.github.com/users/mhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/mhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhahn/subscriptions","organizations_url":"https://api.github.com/users/mhahn/orgs","repos_url":"https://api.github.com/users/mhahn/repos","events_url":"https://api.github.com/users/mhahn/events{/privacy}","received_events_url":"https://api.github.com/users/mhahn/received_events","type":"User","site_admin":false},"body":"Still a WIP but I wanted to publish this for discussion.\r\n\r\nSample output\r\n```\r\n$ emp deploy remind101/acme-inc:master\r\nmaster: Pulling from remind101/acme-inc\r\n\r\n420890c9e918: Already exists\r\na3ed95caeb02: Already exists\r\n1e14aab0083d: Already exists\r\n4393485f2bb3: Already exists\r\na2a051cf14f7: Already exists\r\n1f9177248efa: Already exists\r\nDigest: sha256:d05682347b56191a950f55ab06f11a6c6e34041921af32281b01f4a6a9a0f75f\r\nStatus: Image is up to date for remind101/acme-inc:master\r\nStatus: Created new release v64 for acme-inc\r\nStatus: Updating stack \"acme-inc\"\r\nStatus: Stack updated\r\nStatus: Deployment in progress for web\r\nStatus: Deployment in progress for worker\r\nStatus: Deployment stable for web\r\nStatus: Deployment stable for worker\r\nStatus: Closing event stream for release v64\r\n```\r\n\r\nThere are issues with these tests: github.com/remind101/empire/tests/api. Relying on the Done channel to be closed via the EventsChan receiving an `Event{Close: true}` is really brittle.","created_at":"2016-07-06T23:34:21Z","updated_at":"2016-07-06T23:37:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e196c37e2f1fb6338ae231b3281e078b43b3dceb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/remind101/empire/pulls/916/commits","review_comments_url":"https://api.github.com/repos/remind101/empire/pulls/916/comments","review_comment_url":"https://api.github.com/repos/remind101/empire/pulls/comments{/number}","comments_url":"https://api.github.com/repos/remind101/empire/issues/916/comments","statuses_url":"https://api.github.com/repos/remind101/empire/statuses/c1ea348005d0c4eb832858810a87cf7926295118","head":{"label":"mhahn:deployment-notifications","ref":"deployment-notifications","sha":"c1ea348005d0c4eb832858810a87cf7926295118","user":{"login":"mhahn","id":704593,"avatar_url":"https://avatars.githubusercontent.com/u/704593?v=3","gravatar_id":"","url":"https://api.github.com/users/mhahn","html_url":"https://github.com/mhahn","followers_url":"https://api.github.com/users/mhahn/followers","following_url":"https://api.github.com/users/mhahn/following{/other_user}","gists_url":"https://api.github.com/users/mhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/mhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhahn/subscriptions","organizations_url":"https://api.github.com/users/mhahn/orgs","repos_url":"https://api.github.com/users/mhahn/repos","events_url":"https://api.github.com/users/mhahn/events{/privacy}","received_events_url":"https://api.github.com/users/mhahn/received_events","type":"User","site_admin":false},"repo":{"id":39921607,"name":"empire","full_name":"mhahn/empire","owner":{"login":"mhahn","id":704593,"avatar_url":"https://avatars.githubusercontent.com/u/704593?v=3","gravatar_id":"","url":"https://api.github.com/users/mhahn","html_url":"https://github.com/mhahn","followers_url":"https://api.github.com/users/mhahn/followers","following_url":"https://api.github.com/users/mhahn/following{/other_user}","gists_url":"https://api.github.com/users/mhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/mhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhahn/subscriptions","organizations_url":"https://api.github.com/users/mhahn/orgs","repos_url":"https://api.github.com/users/mhahn/repos","events_url":"https://api.github.com/users/mhahn/events{/privacy}","received_events_url":"https://api.github.com/users/mhahn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhahn/empire","description":"A PaaS built on top of Amazon EC2 Container Service (ECS)","fork":true,"url":"https://api.github.com/repos/mhahn/empire","forks_url":"https://api.github.com/repos/mhahn/empire/forks","keys_url":"https://api.github.com/repos/mhahn/empire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhahn/empire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhahn/empire/teams","hooks_url":"https://api.github.com/repos/mhahn/empire/hooks","issue_events_url":"https://api.github.com/repos/mhahn/empire/issues/events{/number}","events_url":"https://api.github.com/repos/mhahn/empire/events","assignees_url":"https://api.github.com/repos/mhahn/empire/assignees{/user}","branches_url":"https://api.github.com/repos/mhahn/empire/branches{/branch}","tags_url":"https://api.github.com/repos/mhahn/empire/tags","blobs_url":"https://api.github.com/repos/mhahn/empire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhahn/empire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhahn/empire/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhahn/empire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhahn/empire/statuses/{sha}","languages_url":"https://api.github.com/repos/mhahn/empire/languages","stargazers_url":"https://api.github.com/repos/mhahn/empire/stargazers","contributors_url":"https://api.github.com/repos/mhahn/empire/contributors","subscribers_url":"https://api.github.com/repos/mhahn/empire/subscribers","subscription_url":"https://api.github.com/repos/mhahn/empire/subscription","commits_url":"https://api.github.com/repos/mhahn/empire/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhahn/empire/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhahn/empire/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhahn/empire/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhahn/empire/contents/{+path}","compare_url":"https://api.github.com/repos/mhahn/empire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhahn/empire/merges","archive_url":"https://api.github.com/repos/mhahn/empire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhahn/empire/downloads","issues_url":"https://api.github.com/repos/mhahn/empire/issues{/number}","pulls_url":"https://api.github.com/repos/mhahn/empire/pulls{/number}","milestones_url":"https://api.github.com/repos/mhahn/empire/milestones{/number}","notifications_url":"https://api.github.com/repos/mhahn/empire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhahn/empire/labels{/name}","releases_url":"https://api.github.com/repos/mhahn/empire/releases{/id}","deployments_url":"https://api.github.com/repos/mhahn/empire/deployments","created_at":"2015-07-29T23:44:02Z","updated_at":"2016-01-29T09:20:13Z","pushed_at":"2016-07-06T23:30:14Z","git_url":"git://github.com/mhahn/empire.git","ssh_url":"git@github.com:mhahn/empire.git","clone_url":"https://github.com/mhahn/empire.git","svn_url":"https://github.com/mhahn/empire","homepage":"","size":16729,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"remind101:master","ref":"master","sha":"bd469460a1fc75b387bc49cdc686e05e896bb9d4","user":{"login":"remind101","id":376343,"avatar_url":"https://avatars.githubusercontent.com/u/376343?v=3","gravatar_id":"","url":"https://api.github.com/users/remind101","html_url":"https://github.com/remind101","followers_url":"https://api.github.com/users/remind101/followers","following_url":"https://api.github.com/users/remind101/following{/other_user}","gists_url":"https://api.github.com/users/remind101/gists{/gist_id}","starred_url":"https://api.github.com/users/remind101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remind101/subscriptions","organizations_url":"https://api.github.com/users/remind101/orgs","repos_url":"https://api.github.com/users/remind101/repos","events_url":"https://api.github.com/users/remind101/events{/privacy}","received_events_url":"https://api.github.com/users/remind101/received_events","type":"Organization","site_admin":false},"repo":{"id":30091667,"name":"empire","full_name":"remind101/empire","owner":{"login":"remind101","id":376343,"avatar_url":"https://avatars.githubusercontent.com/u/376343?v=3","gravatar_id":"","url":"https://api.github.com/users/remind101","html_url":"https://github.com/remind101","followers_url":"https://api.github.com/users/remind101/followers","following_url":"https://api.github.com/users/remind101/following{/other_user}","gists_url":"https://api.github.com/users/remind101/gists{/gist_id}","starred_url":"https://api.github.com/users/remind101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remind101/subscriptions","organizations_url":"https://api.github.com/users/remind101/orgs","repos_url":"https://api.github.com/users/remind101/repos","events_url":"https://api.github.com/users/remind101/events{/privacy}","received_events_url":"https://api.github.com/users/remind101/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/remind101/empire","description":"A PaaS built on top of Amazon EC2 Container Service (ECS)","fork":false,"url":"https://api.github.com/repos/remind101/empire","forks_url":"https://api.github.com/repos/remind101/empire/forks","keys_url":"https://api.github.com/repos/remind101/empire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/remind101/empire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/remind101/empire/teams","hooks_url":"https://api.github.com/repos/remind101/empire/hooks","issue_events_url":"https://api.github.com/repos/remind101/empire/issues/events{/number}","events_url":"https://api.github.com/repos/remind101/empire/events","assignees_url":"https://api.github.com/repos/remind101/empire/assignees{/user}","branches_url":"https://api.github.com/repos/remind101/empire/branches{/branch}","tags_url":"https://api.github.com/repos/remind101/empire/tags","blobs_url":"https://api.github.com/repos/remind101/empire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/remind101/empire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/remind101/empire/git/refs{/sha}","trees_url":"https://api.github.com/repos/remind101/empire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/remind101/empire/statuses/{sha}","languages_url":"https://api.github.com/repos/remind101/empire/languages","stargazers_url":"https://api.github.com/repos/remind101/empire/stargazers","contributors_url":"https://api.github.com/repos/remind101/empire/contributors","subscribers_url":"https://api.github.com/repos/remind101/empire/subscribers","subscription_url":"https://api.github.com/repos/remind101/empire/subscription","commits_url":"https://api.github.com/repos/remind101/empire/commits{/sha}","git_commits_url":"https://api.github.com/repos/remind101/empire/git/commits{/sha}","comments_url":"https://api.github.com/repos/remind101/empire/comments{/number}","issue_comment_url":"https://api.github.com/repos/remind101/empire/issues/comments{/number}","contents_url":"https://api.github.com/repos/remind101/empire/contents/{+path}","compare_url":"https://api.github.com/repos/remind101/empire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/remind101/empire/merges","archive_url":"https://api.github.com/repos/remind101/empire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/remind101/empire/downloads","issues_url":"https://api.github.com/repos/remind101/empire/issues{/number}","pulls_url":"https://api.github.com/repos/remind101/empire/pulls{/number}","milestones_url":"https://api.github.com/repos/remind101/empire/milestones{/number}","notifications_url":"https://api.github.com/repos/remind101/empire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/remind101/empire/labels{/name}","releases_url":"https://api.github.com/repos/remind101/empire/releases{/id}","deployments_url":"https://api.github.com/repos/remind101/empire/deployments","created_at":"2015-01-30T21:32:09Z","updated_at":"2016-07-06T09:23:27Z","pushed_at":"2016-07-06T23:34:21Z","git_url":"git://github.com/remind101/empire.git","ssh_url":"git@github.com:remind101/empire.git","clone_url":"https://github.com/remind101/empire.git","svn_url":"https://github.com/remind101/empire","homepage":"","size":24918,"stargazers_count":1833,"watchers_count":1833,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":65,"forks":85,"open_issues":65,"watchers":1833,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/remind101/empire/pulls/916"},"html":{"href":"https://github.com/remind101/empire/pull/916"},"issue":{"href":"https://api.github.com/repos/remind101/empire/issues/916"},"comments":{"href":"https://api.github.com/repos/remind101/empire/issues/916/comments"},"review_comments":{"href":"https://api.github.com/repos/remind101/empire/pulls/916/comments"},"review_comment":{"href":"https://api.github.com/repos/remind101/empire/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/remind101/empire/pulls/916/commits"},"statuses":{"href":"https://api.github.com/repos/remind101/empire/statuses/c1ea348005d0c4eb832858810a87cf7926295118"}}}}
{"actor":{"display_login":"mhahn"}}