{"action":"opened","issue":{"url":"https://api.github.com/repos/legion0/kjlib-python/issues/1","repository_url":"https://api.github.com/repos/legion0/kjlib-python","labels_url":"https://api.github.com/repos/legion0/kjlib-python/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/legion0/kjlib-python/issues/1/comments","events_url":"https://api.github.com/repos/legion0/kjlib-python/issues/1/events","html_url":"https://github.com/legion0/kjlib-python/issues/1","id":163334932,"number":1,"title":"Logger instance can't register log folder when user provide optional param","user":{"login":"hemulin","id":1885510,"avatar_url":"https://avatars.githubusercontent.com/u/1885510?v=3","gravatar_id":"","url":"https://api.github.com/users/hemulin","html_url":"https://github.com/hemulin","followers_url":"https://api.github.com/users/hemulin/followers","following_url":"https://api.github.com/users/hemulin/following{/other_user}","gists_url":"https://api.github.com/users/hemulin/gists{/gist_id}","starred_url":"https://api.github.com/users/hemulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hemulin/subscriptions","organizations_url":"https://api.github.com/users/hemulin/orgs","repos_url":"https://api.github.com/users/hemulin/repos","events_url":"https://api.github.com/users/hemulin/events{/privacy}","received_events_url":"https://api.github.com/users/hemulin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-07-01T07:22:01Z","updated_at":"2016-07-01T07:22:01Z","closed_at":null,"body":"So,\r\nThe Logger.instance() is able to receive an optional param of log_dir.\r\nThe problem is that in the code you can find those lines:\r\n```\r\nself.__log_dir = log_dir\r\n\r\nif self.__log_dir is None:\r\n\tself.__LOG_DIR = self.__app_dirs.logs()\r\nAppDirs.mkdir(self.__LOG_DIR)\r\n```\r\n\r\nWhile I believe it should be:\r\n```\r\nself.__log_dir = log_dir\r\n\r\nif self.__log_dir is None:\r\n\tself.__LOG_DIR = self.__app_dirs.logs()\r\nelse:\r\n\tself.__LOG_DIR = self.__log_dir\r\nAppDirs.mkdir(self.__LOG_DIR)\r\n```\r\n"}}
{"actor":{"display_login":"hemulin"}}