{"action":"created","issue":{"url":"https://api.github.com/repos/timvandermeij/mobile-radio-tomography/issues/61","repository_url":"https://api.github.com/repos/timvandermeij/mobile-radio-tomography","labels_url":"https://api.github.com/repos/timvandermeij/mobile-radio-tomography/issues/61/labels{/name}","comments_url":"https://api.github.com/repos/timvandermeij/mobile-radio-tomography/issues/61/comments","events_url":"https://api.github.com/repos/timvandermeij/mobile-radio-tomography/issues/61/events","html_url":"https://github.com/timvandermeij/mobile-radio-tomography/pull/61","id":139883684,"number":61,"title":"Remove unused imports, installations and files","user":{"login":"timvandermeij","id":1993262,"avatar_url":"https://avatars.githubusercontent.com/u/1993262?v=3","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-03-10T13:22:33Z","updated_at":"2016-03-10T15:02:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/timvandermeij/mobile-radio-tomography/pulls/61","html_url":"https://github.com/timvandermeij/mobile-radio-tomography/pull/61","diff_url":"https://github.com/timvandermeij/mobile-radio-tomography/pull/61.diff","patch_url":"https://github.com/timvandermeij/mobile-radio-tomography/pull/61.patch"},"body":"I found out that there exists a tool called \"importchecker\" that finds unused imports in Python code. Running this tool on our code base resulted in quite a list of unused imports. This patch removes those unused imports.\r\n\r\nUnfortunately the tool thinks our `__package__` imports are also unused, so we cannot use it in our testing script as it would produce false positives, but at least it helped to clean up our imports quite a bit.\r\n\r\n@lhelwerd Could you:\r\n- Review this patch?\r\n- Let me know if we still need the files `trajectory/simple_crash.py`, `trajectory/simple_goto.py` and `vehicle_state.py`? I think they are unused as we do all that ourselves now in the mission scripts. On top of that, I think they were from the old DroneKit version and we can always find them in the DroneKit repository. If we do not use these anymore, I'll add a commit to remove these."},"comment":{"url":"https://api.github.com/repos/timvandermeij/mobile-radio-tomography/issues/comments/194889907","html_url":"https://github.com/timvandermeij/mobile-radio-tomography/pull/61#issuecomment-194889907","issue_url":"https://api.github.com/repos/timvandermeij/mobile-radio-tomography/issues/61","id":194889907,"user":{"login":"timvandermeij","id":1993262,"avatar_url":"https://avatars.githubusercontent.com/u/1993262?v=3","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"created_at":"2016-03-10T15:02:49Z","updated_at":"2016-03-10T15:02:49Z","body":"Sounds like a good plan to me, I'll look into that. Note that the module error is also intermittent."}}