{"action":"created","issue":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/994","repository_url":"https://api.github.com/repos/greenplum-db/gpdb","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/994/labels{/name}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/994/comments","events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/994/events","html_url":"https://github.com/greenplum-db/gpdb/pull/994","id":167962659,"number":994,"title":"Avoid aborting based on PT entry without consulting clog.","user":{"login":"ashwinstar","id":11396815,"avatar_url":"https://avatars.githubusercontent.com/u/11396815?v=3","gravatar_id":"","url":"https://api.github.com/users/ashwinstar","html_url":"https://github.com/ashwinstar","followers_url":"https://api.github.com/users/ashwinstar/followers","following_url":"https://api.github.com/users/ashwinstar/following{/other_user}","gists_url":"https://api.github.com/users/ashwinstar/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwinstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwinstar/subscriptions","organizations_url":"https://api.github.com/users/ashwinstar/orgs","repos_url":"https://api.github.com/users/ashwinstar/repos","events_url":"https://api.github.com/users/ashwinstar/events{/privacy}","received_events_url":"https://api.github.com/users/ashwinstar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-07-27T21:36:54Z","updated_at":"2016-08-02T18:33:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/994","html_url":"https://github.com/greenplum-db/gpdb/pull/994","diff_url":"https://github.com/greenplum-db/gpdb/pull/994.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/994.patch"},"body":"High level theory of the issue if checkpoint happens after recording\r\nCOMMIT to clog, xactHashTable won't know the status of the xact during\r\nrecovery, since no REDO records corresponding to the same would be\r\nlooked into. But its incorrect without consulting CLOG to ABORT the xact\r\nbased on having CREATE_PENDING entry in PT. Hence should check CLOG to\r\nverify if it was COMMITTED. If we don't perform this check, the recovery\r\nwould try to mark COMMITED Xact Aborted, seeing Create-Pending entry\r\nassociated with the Xact and double fault.\r\nDo not have repro as wasn't able to find scenario in which this can\r\nhappen, but was seen in field and hence better to add protection to\r\navoid double fault."},"comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments/236998697","html_url":"https://github.com/greenplum-db/gpdb/pull/994#issuecomment-236998697","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/994","id":236998697,"user":{"login":"ashwinstar","id":11396815,"avatar_url":"https://avatars.githubusercontent.com/u/11396815?v=3","gravatar_id":"","url":"https://api.github.com/users/ashwinstar","html_url":"https://github.com/ashwinstar","followers_url":"https://api.github.com/users/ashwinstar/followers","following_url":"https://api.github.com/users/ashwinstar/following{/other_user}","gists_url":"https://api.github.com/users/ashwinstar/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwinstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwinstar/subscriptions","organizations_url":"https://api.github.com/users/ashwinstar/orgs","repos_url":"https://api.github.com/users/ashwinstar/repos","events_url":"https://api.github.com/users/ashwinstar/events{/privacy}","received_events_url":"https://api.github.com/users/ashwinstar/received_events","type":"User","site_admin":false},"created_at":"2016-08-02T18:33:20Z","updated_at":"2016-08-02T18:33:20Z","body":"Added comments for few critical functions during crash recovery. We will be adding separate document to describe the full recovery passes in detail as README soon as separate PR."}}
{"actor":{"display_login":"ashwinstar"}}