{"action":"created","comment":{"url":"https://api.github.com/repos/swarren/uboot-test-hooks/pulls/comments/76493468","id":76493468,"diff_hunk":"@@ -0,0 +1,63 @@\n+#!/bin/bash\n+\n+# Copyright (c) 2016 Stephen Warren <swarren@wwwdotorg.org>\n+# Copyright (c) 2016 Konsulko Group\n+# All rights reserved.\n+#\n+# Redistribution and use in source and binary forms, with or without\n+# modification, are permitted provided that the following conditions are met:\n+# * Redistributions of source code must retain the above copyright notice,\n+#   this list of conditions and the following disclaimer.\n+# * Redistributions in binary form must reproduce the above copyright notice,\n+#   this list of conditions and the following disclaimer in the documentation\n+#   and/or other materials provided with the distribution.\n+# * Neither the name of the copyright holder nor the names of its contributors\n+#   may be used to endorse or promote products derived from this software\n+#   without specific prior written permission.\n+#\n+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n+# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE\n+# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR\n+# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF\n+# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS\n+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN\n+# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)\n+# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE\n+# POSSIBILITY OF SUCH DAMAGE.\n+\n+flashair_rmlist=`mktemp`\n+\n+case \"${board_type}\" in\n+rpi)\n+    kernel_dst=kernel.img\n+    ;;\n+rpi_2)\n+    kernel_dst=kernel7.img\n+    ;;\n+rpi_3)\n+    kernel_dst=kernel8.img\n+    ;;\n+rpi_3_32b)","path":"bin/flashair.rpi","position":42,"original_position":42,"commit_id":"0c57f738228b65719101b914689aff4b85a35b0c","original_commit_id":"0c57f738228b65719101b914689aff4b85a35b0c","user":{"login":"trini","id":508192,"avatar_url":"https://avatars.githubusercontent.com/u/508192?v=3","gravatar_id":"","url":"https://api.github.com/users/trini","html_url":"https://github.com/trini","followers_url":"https://api.github.com/users/trini/followers","following_url":"https://api.github.com/users/trini/following{/other_user}","gists_url":"https://api.github.com/users/trini/gists{/gist_id}","starred_url":"https://api.github.com/users/trini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trini/subscriptions","organizations_url":"https://api.github.com/users/trini/orgs","repos_url":"https://api.github.com/users/trini/repos","events_url":"https://api.github.com/users/trini/events{/privacy}","received_events_url":"https://api.github.com/users/trini/received_events","type":"User","site_admin":false},"body":"Wait, no, rpi_3_32b is also a config today :)  I think that should set aside the rest of your concern about that.  I am testing the 32 and 64bit modes on mine, for example, as is here.  If you really want tho, I can do a ${flashair_rpi_board_type:${board_type}} to allow the conf files to really override if you think it's needed still.","created_at":"2016-08-26T21:49:40Z","updated_at":"2016-08-26T21:49:40Z","html_url":"https://github.com/swarren/uboot-test-hooks/pull/4#discussion_r76493468","pull_request_url":"https://api.github.com/repos/swarren/uboot-test-hooks/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/swarren/uboot-test-hooks/pulls/comments/76493468"},"html":{"href":"https://github.com/swarren/uboot-test-hooks/pull/4#discussion_r76493468"},"pull_request":{"href":"https://api.github.com/repos/swarren/uboot-test-hooks/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/swarren/uboot-test-hooks/pulls/4","id":82404385,"html_url":"https://github.com/swarren/uboot-test-hooks/pull/4","diff_url":"https://github.com/swarren/uboot-test-hooks/pull/4.diff","patch_url":"https://github.com/swarren/uboot-test-hooks/pull/4.patch","issue_url":"https://api.github.com/repos/swarren/uboot-test-hooks/issues/4","number":4,"state":"open","locked":false,"title":"bin: Add flashair hooks for flashing U-Boot","user":{"login":"trini","id":508192,"avatar_url":"https://avatars.githubusercontent.com/u/508192?v=3","gravatar_id":"","url":"https://api.github.com/users/trini","html_url":"https://github.com/trini","followers_url":"https://api.github.com/users/trini/followers","following_url":"https://api.github.com/users/trini/following{/other_user}","gists_url":"https://api.github.com/users/trini/gists{/gist_id}","starred_url":"https://api.github.com/users/trini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trini/subscriptions","organizations_url":"https://api.github.com/users/trini/orgs","repos_url":"https://api.github.com/users/trini/repos","events_url":"https://api.github.com/users/trini/events{/privacy}","received_events_url":"https://api.github.com/users/trini/received_events","type":"User","site_admin":false},"body":"- We copy push-flashair.py from Stephen's rpi-dev-scripts repository to\r\n  talk with the Toshiba \"FlashAir\" SD cards, which are full size SD\r\n  cards that use the iSDIO specification to also have 802.11 wireless\r\n  capability and a certain amount of remote functionality.  With UPLOAD=1\r\n  set in the config file you can upload files to these cards.\r\n- We copy and then modify uboot-gen.sh from the rpi-dev-scripts\r\n  repository to figure out what the u-boot.bin file needs to be called\r\n  on the target RPi.\r\n- I've added a flashair.ti-omap script that will copy MLO/u-boot.img\r\n  files as these are what most TI platforms use to boot.\r\n\r\nSigned-off-by: Tom Rini <trini@konsulko.com>\r\n\r\n--- \r\nChanges in v2:\r\n- I added ARGS to flash.flashair so that we can put in rmlist: only if we have files to remove and then append the push:dir to the args after.  Tested on both TI platforms and RPi 3 (32bit and 64bit).","created_at":"2016-08-23T17:09:59Z","updated_at":"2016-08-26T21:49:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87ec762207ecb8b3fb4ed523c95f54bc15a8392f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/swarren/uboot-test-hooks/pulls/4/commits","review_comments_url":"https://api.github.com/repos/swarren/uboot-test-hooks/pulls/4/comments","review_comment_url":"https://api.github.com/repos/swarren/uboot-test-hooks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swarren/uboot-test-hooks/issues/4/comments","statuses_url":"https://api.github.com/repos/swarren/uboot-test-hooks/statuses/0c57f738228b65719101b914689aff4b85a35b0c","head":{"label":"trini:add-flashair","ref":"add-flashair","sha":"0c57f738228b65719101b914689aff4b85a35b0c","user":{"login":"trini","id":508192,"avatar_url":"https://avatars.githubusercontent.com/u/508192?v=3","gravatar_id":"","url":"https://api.github.com/users/trini","html_url":"https://github.com/trini","followers_url":"https://api.github.com/users/trini/followers","following_url":"https://api.github.com/users/trini/following{/other_user}","gists_url":"https://api.github.com/users/trini/gists{/gist_id}","starred_url":"https://api.github.com/users/trini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trini/subscriptions","organizations_url":"https://api.github.com/users/trini/orgs","repos_url":"https://api.github.com/users/trini/repos","events_url":"https://api.github.com/users/trini/events{/privacy}","received_events_url":"https://api.github.com/users/trini/received_events","type":"User","site_admin":false},"repo":{"id":65642705,"name":"uboot-test-hooks","full_name":"trini/uboot-test-hooks","owner":{"login":"trini","id":508192,"avatar_url":"https://avatars.githubusercontent.com/u/508192?v=3","gravatar_id":"","url":"https://api.github.com/users/trini","html_url":"https://github.com/trini","followers_url":"https://api.github.com/users/trini/followers","following_url":"https://api.github.com/users/trini/following{/other_user}","gists_url":"https://api.github.com/users/trini/gists{/gist_id}","starred_url":"https://api.github.com/users/trini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trini/subscriptions","organizations_url":"https://api.github.com/users/trini/orgs","repos_url":"https://api.github.com/users/trini/repos","events_url":"https://api.github.com/users/trini/events{/privacy}","received_events_url":"https://api.github.com/users/trini/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trini/uboot-test-hooks","description":"Example \"hook\" scripts for the test framework I proposed for U-Boot","fork":true,"url":"https://api.github.com/repos/trini/uboot-test-hooks","forks_url":"https://api.github.com/repos/trini/uboot-test-hooks/forks","keys_url":"https://api.github.com/repos/trini/uboot-test-hooks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trini/uboot-test-hooks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trini/uboot-test-hooks/teams","hooks_url":"https://api.github.com/repos/trini/uboot-test-hooks/hooks","issue_events_url":"https://api.github.com/repos/trini/uboot-test-hooks/issues/events{/number}","events_url":"https://api.github.com/repos/trini/uboot-test-hooks/events","assignees_url":"https://api.github.com/repos/trini/uboot-test-hooks/assignees{/user}","branches_url":"https://api.github.com/repos/trini/uboot-test-hooks/branches{/branch}","tags_url":"https://api.github.com/repos/trini/uboot-test-hooks/tags","blobs_url":"https://api.github.com/repos/trini/uboot-test-hooks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trini/uboot-test-hooks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trini/uboot-test-hooks/git/refs{/sha}","trees_url":"https://api.github.com/repos/trini/uboot-test-hooks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trini/uboot-test-hooks/statuses/{sha}","languages_url":"https://api.github.com/repos/trini/uboot-test-hooks/languages","stargazers_url":"https://api.github.com/repos/trini/uboot-test-hooks/stargazers","contributors_url":"https://api.github.com/repos/trini/uboot-test-hooks/contributors","subscribers_url":"https://api.github.com/repos/trini/uboot-test-hooks/subscribers","subscription_url":"https://api.github.com/repos/trini/uboot-test-hooks/subscription","commits_url":"https://api.github.com/repos/trini/uboot-test-hooks/commits{/sha}","git_commits_url":"https://api.github.com/repos/trini/uboot-test-hooks/git/commits{/sha}","comments_url":"https://api.github.com/repos/trini/uboot-test-hooks/comments{/number}","issue_comment_url":"https://api.github.com/repos/trini/uboot-test-hooks/issues/comments{/number}","contents_url":"https://api.github.com/repos/trini/uboot-test-hooks/contents/{+path}","compare_url":"https://api.github.com/repos/trini/uboot-test-hooks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trini/uboot-test-hooks/merges","archive_url":"https://api.github.com/repos/trini/uboot-test-hooks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trini/uboot-test-hooks/downloads","issues_url":"https://api.github.com/repos/trini/uboot-test-hooks/issues{/number}","pulls_url":"https://api.github.com/repos/trini/uboot-test-hooks/pulls{/number}","milestones_url":"https://api.github.com/repos/trini/uboot-test-hooks/milestones{/number}","notifications_url":"https://api.github.com/repos/trini/uboot-test-hooks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trini/uboot-test-hooks/labels{/name}","releases_url":"https://api.github.com/repos/trini/uboot-test-hooks/releases{/id}","deployments_url":"https://api.github.com/repos/trini/uboot-test-hooks/deployments","created_at":"2016-08-14T00:26:21Z","updated_at":"2016-08-14T00:26:23Z","pushed_at":"2016-08-26T18:55:30Z","git_url":"git://github.com/trini/uboot-test-hooks.git","ssh_url":"git@github.com:trini/uboot-test-hooks.git","clone_url":"https://github.com/trini/uboot-test-hooks.git","svn_url":"https://github.com/trini/uboot-test-hooks","homepage":null,"size":132,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"swarren:master","ref":"master","sha":"00f86275da329f72c748f9e21a0ed446ba2e6654","user":{"login":"swarren","id":208160,"avatar_url":"https://avatars.githubusercontent.com/u/208160?v=3","gravatar_id":"","url":"https://api.github.com/users/swarren","html_url":"https://github.com/swarren","followers_url":"https://api.github.com/users/swarren/followers","following_url":"https://api.github.com/users/swarren/following{/other_user}","gists_url":"https://api.github.com/users/swarren/gists{/gist_id}","starred_url":"https://api.github.com/users/swarren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swarren/subscriptions","organizations_url":"https://api.github.com/users/swarren/orgs","repos_url":"https://api.github.com/users/swarren/repos","events_url":"https://api.github.com/users/swarren/events{/privacy}","received_events_url":"https://api.github.com/users/swarren/received_events","type":"User","site_admin":false},"repo":{"id":47702435,"name":"uboot-test-hooks","full_name":"swarren/uboot-test-hooks","owner":{"login":"swarren","id":208160,"avatar_url":"https://avatars.githubusercontent.com/u/208160?v=3","gravatar_id":"","url":"https://api.github.com/users/swarren","html_url":"https://github.com/swarren","followers_url":"https://api.github.com/users/swarren/followers","following_url":"https://api.github.com/users/swarren/following{/other_user}","gists_url":"https://api.github.com/users/swarren/gists{/gist_id}","starred_url":"https://api.github.com/users/swarren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swarren/subscriptions","organizations_url":"https://api.github.com/users/swarren/orgs","repos_url":"https://api.github.com/users/swarren/repos","events_url":"https://api.github.com/users/swarren/events{/privacy}","received_events_url":"https://api.github.com/users/swarren/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swarren/uboot-test-hooks","description":"Example \"hook\" scripts for the test framework I proposed for U-Boot","fork":false,"url":"https://api.github.com/repos/swarren/uboot-test-hooks","forks_url":"https://api.github.com/repos/swarren/uboot-test-hooks/forks","keys_url":"https://api.github.com/repos/swarren/uboot-test-hooks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swarren/uboot-test-hooks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swarren/uboot-test-hooks/teams","hooks_url":"https://api.github.com/repos/swarren/uboot-test-hooks/hooks","issue_events_url":"https://api.github.com/repos/swarren/uboot-test-hooks/issues/events{/number}","events_url":"https://api.github.com/repos/swarren/uboot-test-hooks/events","assignees_url":"https://api.github.com/repos/swarren/uboot-test-hooks/assignees{/user}","branches_url":"https://api.github.com/repos/swarren/uboot-test-hooks/branches{/branch}","tags_url":"https://api.github.com/repos/swarren/uboot-test-hooks/tags","blobs_url":"https://api.github.com/repos/swarren/uboot-test-hooks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swarren/uboot-test-hooks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swarren/uboot-test-hooks/git/refs{/sha}","trees_url":"https://api.github.com/repos/swarren/uboot-test-hooks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swarren/uboot-test-hooks/statuses/{sha}","languages_url":"https://api.github.com/repos/swarren/uboot-test-hooks/languages","stargazers_url":"https://api.github.com/repos/swarren/uboot-test-hooks/stargazers","contributors_url":"https://api.github.com/repos/swarren/uboot-test-hooks/contributors","subscribers_url":"https://api.github.com/repos/swarren/uboot-test-hooks/subscribers","subscription_url":"https://api.github.com/repos/swarren/uboot-test-hooks/subscription","commits_url":"https://api.github.com/repos/swarren/uboot-test-hooks/commits{/sha}","git_commits_url":"https://api.github.com/repos/swarren/uboot-test-hooks/git/commits{/sha}","comments_url":"https://api.github.com/repos/swarren/uboot-test-hooks/comments{/number}","issue_comment_url":"https://api.github.com/repos/swarren/uboot-test-hooks/issues/comments{/number}","contents_url":"https://api.github.com/repos/swarren/uboot-test-hooks/contents/{+path}","compare_url":"https://api.github.com/repos/swarren/uboot-test-hooks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swarren/uboot-test-hooks/merges","archive_url":"https://api.github.com/repos/swarren/uboot-test-hooks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swarren/uboot-test-hooks/downloads","issues_url":"https://api.github.com/repos/swarren/uboot-test-hooks/issues{/number}","pulls_url":"https://api.github.com/repos/swarren/uboot-test-hooks/pulls{/number}","milestones_url":"https://api.github.com/repos/swarren/uboot-test-hooks/milestones{/number}","notifications_url":"https://api.github.com/repos/swarren/uboot-test-hooks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swarren/uboot-test-hooks/labels{/name}","releases_url":"https://api.github.com/repos/swarren/uboot-test-hooks/releases{/id}","deployments_url":"https://api.github.com/repos/swarren/uboot-test-hooks/deployments","created_at":"2015-12-09T16:07:07Z","updated_at":"2016-04-22T19:45:53Z","pushed_at":"2016-08-26T18:55:31Z","git_url":"git://github.com/swarren/uboot-test-hooks.git","ssh_url":"git@github.com:swarren/uboot-test-hooks.git","clone_url":"https://github.com/swarren/uboot-test-hooks.git","svn_url":"https://github.com/swarren/uboot-test-hooks","homepage":null,"size":127,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/swarren/uboot-test-hooks/pulls/4"},"html":{"href":"https://github.com/swarren/uboot-test-hooks/pull/4"},"issue":{"href":"https://api.github.com/repos/swarren/uboot-test-hooks/issues/4"},"comments":{"href":"https://api.github.com/repos/swarren/uboot-test-hooks/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/swarren/uboot-test-hooks/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/swarren/uboot-test-hooks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swarren/uboot-test-hooks/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/swarren/uboot-test-hooks/statuses/0c57f738228b65719101b914689aff4b85a35b0c"}}}}
{"actor":{"display_login":"trini"}}