{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/79815030","id":79815030,"diff_hunk":"@@ -20,18 +20,39 @@ module Api\n   class Upgrade < Tableless\n     def status\n       {\n-        crowbar: crowbar_upgrade_status,\n-        checks: check\n-      }\n+        crowbar: crowbar_upgrade_status\n+      }.merge!(check)\n     end\n \n     def check\n       {\n-        sanity_checks: sanity_checks,\n-        maintenance_updates_installed: maintenance_updates_installed?,\n-        clusters_healthy: clusters_healthy?,\n-        compute_resources_available: compute_resources_available?,\n-        ceph_healthy: ceph_healthy?\n+        checks: {\n+          sanity_checks: {\n+            required: true,\n+            passed: sanity_checks.empty?,\n+            errors: sanity_check_errors\n+          },\n+          maintenance_updates_installed: {\n+            required: true,\n+            passed: maintenance_updates_status[:passed],","path":"crowbar_framework/app/models/api/upgrade.rb","position":26,"original_position":26,"commit_id":"d0a6ea23e191052dff427ccae8d24f5a5619ba12","original_commit_id":"d0a6ea23e191052dff427ccae8d24f5a5619ba12","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"body":"good point, that is redundant information","created_at":"2016-09-21T11:50:28Z","updated_at":"2016-09-21T11:50:28Z","html_url":"https://github.com/crowbar/crowbar-core/pull/672#discussion_r79815030","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/672","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/79815030"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/672#discussion_r79815030"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/672"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/672","id":86130204,"html_url":"https://github.com/crowbar/crowbar-core/pull/672","diff_url":"https://github.com/crowbar/crowbar-core/pull/672.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/672.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/672","number":672,"state":"open","locked":false,"title":"adapt the prechecks API","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"body":"we are including specific errors now in the response\r\n\r\nexample:\r\n\r\n```json\r\n{\r\n  \"checks\": {\r\n    \"sanity_checks\": {\r\n      \"required\": true,\r\n      \"passed\": true,\r\n      \"errors\": []\r\n    },\r\n    \"maintenance_updates_installed\": {\r\n      \"required\": true,\r\n      \"passed\": false,\r\n      \"errors\": [\r\n        {\r\n          \"code\": \"maintenance_updates_installed\",\r\n          \"data\": [\r\n            \"ZYPPER_EXIT_INF_UPDATE_NEEDED: patches available for installation.\"\r\n          ],\r\n          \"help\": \"make sure maintenance updates are installed\"\r\n        }\r\n      ]\r\n    },\r\n    \"clusters_healthy\": {\r\n      \"required\": true,\r\n      \"passed\": true,\r\n      \"errors\": []\r\n    },\r\n    \"compute_resources_available\": {\r\n      \"required\": false,\r\n      \"passed\": true,\r\n      \"errors\": []\r\n    },\r\n    \"ceph_healthy\": {\r\n      \"required\": true,\r\n      \"passed\": true,\r\n      \"errors\": []\r\n    }\r\n  }\r\n}\r\n```","created_at":"2016-09-21T09:48:46Z","updated_at":"2016-09-21T11:50:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d11b236183e380ba657a440781326369651922c","assignee":{"login":"aspiers","id":100738,"avatar_url":"https://avatars.githubusercontent.com/u/100738?v=3","gravatar_id":"","url":"https://api.github.com/users/aspiers","html_url":"https://github.com/aspiers","followers_url":"https://api.github.com/users/aspiers/followers","following_url":"https://api.github.com/users/aspiers/following{/other_user}","gists_url":"https://api.github.com/users/aspiers/gists{/gist_id}","starred_url":"https://api.github.com/users/aspiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspiers/subscriptions","organizations_url":"https://api.github.com/users/aspiers/orgs","repos_url":"https://api.github.com/users/aspiers/repos","events_url":"https://api.github.com/users/aspiers/events{/privacy}","received_events_url":"https://api.github.com/users/aspiers/received_events","type":"User","site_admin":false},"assignees":[{"login":"aspiers","id":100738,"avatar_url":"https://avatars.githubusercontent.com/u/100738?v=3","gravatar_id":"","url":"https://api.github.com/users/aspiers","html_url":"https://github.com/aspiers","followers_url":"https://api.github.com/users/aspiers/followers","following_url":"https://api.github.com/users/aspiers/following{/other_user}","gists_url":"https://api.github.com/users/aspiers/gists{/gist_id}","starred_url":"https://api.github.com/users/aspiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspiers/subscriptions","organizations_url":"https://api.github.com/users/aspiers/orgs","repos_url":"https://api.github.com/users/aspiers/repos","events_url":"https://api.github.com/users/aspiers/events{/privacy}","received_events_url":"https://api.github.com/users/aspiers/received_events","type":"User","site_admin":false},{"login":"jsuchome","id":910000,"avatar_url":"https://avatars.githubusercontent.com/u/910000?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/672/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/672/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/672/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/d0a6ea23e191052dff427ccae8d24f5a5619ba12","head":{"label":"MaximilianMeister:apisync/prechecks","ref":"apisync/prechecks","sha":"d0a6ea23e191052dff427ccae8d24f5a5619ba12","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"repo":{"id":40901479,"name":"crowbar-core","full_name":"MaximilianMeister/crowbar-core","owner":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MaximilianMeister/crowbar-core","description":"Core deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/MaximilianMeister/crowbar-core","forks_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/forks","keys_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/teams","hooks_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/events","assignees_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/tags","blobs_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/subscription","commits_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/merges","archive_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/downloads","issues_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/MaximilianMeister/crowbar-core/deployments","created_at":"2015-08-17T14:29:21Z","updated_at":"2015-08-17T14:29:23Z","pushed_at":"2016-09-21T11:10:34Z","git_url":"git://github.com/MaximilianMeister/crowbar-core.git","ssh_url":"git@github.com:MaximilianMeister/crowbar-core.git","clone_url":"https://github.com/MaximilianMeister/crowbar-core.git","svn_url":"https://github.com/MaximilianMeister/crowbar-core","homepage":null,"size":106828,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"2177939d38b45de4f5b16417fa4395e2c8a0895c","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39003227,"name":"crowbar-core","full_name":"crowbar/crowbar-core","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-core","description":"Core deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-core","forks_url":"https://api.github.com/repos/crowbar/crowbar-core/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-core/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-core/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-core/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-core/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-core/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-core/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-core/deployments","created_at":"2015-07-13T09:31:28Z","updated_at":"2016-04-10T12:47:20Z","pushed_at":"2016-09-21T11:10:35Z","git_url":"git://github.com/crowbar/crowbar-core.git","ssh_url":"git@github.com:crowbar/crowbar-core.git","clone_url":"https://github.com/crowbar/crowbar-core.git","svn_url":"https://github.com/crowbar/crowbar-core","homepage":null,"size":121269,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":39,"forks":34,"open_issues":39,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/672"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/672"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/672"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/672/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/672/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/672/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-core/statuses/d0a6ea23e191052dff427ccae8d24f5a5619ba12"}}}}
{"actor":{"display_login":"MaximilianMeister"}}