{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/79690396","id":79690396,"diff_hunk":"@@ -232,6 +234,23 @@ def test_unit(self, test_name=None, package=None):\n         if result != 0:\n             return result\n \n+    @Command('test-stylo',\n+             description='Run stylo unit tests',\n+             category='testing')\n+    def test_stylo(self):\n+        self.set_use_stable_rust()\n+        self.ensure_bootstrapped()\n+\n+        env = self.build_env()\n+        env[\"RUST_BACKTRACE\"] = \"1\"\n+        env[\"CARGO_TARGET_DIR\"] = path.join(self.context.topdir, \"target\", \"geckolib\").encode(\"UTF-8\")\n+\n+        with cd(path.join(\"ports\", \"geckolib\")):\n+            result = call([\"cargo\", \"test\", \"-p\", \"stylo_tests\"], env=env)\n+\n+        if result != 0:","path":"python/servo/testing_commands.py","position":36,"original_position":36,"commit_id":"1d497828a76ae0739463ef6a196fa4b98b06173c","original_commit_id":"1d497828a76ae0739463ef6a196fa4b98b06173c","user":{"login":"aneeshusa","id":2085567,"avatar_url":"https://avatars.githubusercontent.com/u/2085567?v=3","gravatar_id":"","url":"https://api.github.com/users/aneeshusa","html_url":"https://github.com/aneeshusa","followers_url":"https://api.github.com/users/aneeshusa/followers","following_url":"https://api.github.com/users/aneeshusa/following{/other_user}","gists_url":"https://api.github.com/users/aneeshusa/gists{/gist_id}","starred_url":"https://api.github.com/users/aneeshusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneeshusa/subscriptions","organizations_url":"https://api.github.com/users/aneeshusa/orgs","repos_url":"https://api.github.com/users/aneeshusa/repos","events_url":"https://api.github.com/users/aneeshusa/events{/privacy}","received_events_url":"https://api.github.com/users/aneeshusa/received_events","type":"User","site_admin":false},"body":"Why not always `return result` instead of hiding it behind the conditional?","created_at":"2016-09-20T19:16:41Z","updated_at":"2016-09-20T19:16:41Z","html_url":"https://github.com/servo/servo/pull/13335#discussion_r79690396","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/13335","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/79690396"},"html":{"href":"https://github.com/servo/servo/pull/13335#discussion_r79690396"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/13335"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/13335","id":85992468,"html_url":"https://github.com/servo/servo/pull/13335","diff_url":"https://github.com/servo/servo/pull/13335.diff","patch_url":"https://github.com/servo/servo/pull/13335.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/13335","number":13335,"state":"open","locked":false,"title":"Add unit test crate for stylo","user":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"body":"@canaltinova needs this for his mask work -- we need a way to test stylo code (or style code that's conditionally compiled out for gecko)\n\nWe can add this to the CI as well.\n\nr? @emilio\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/13335)\n<!-- Reviewable:end -->\n","created_at":"2016-09-20T14:55:42Z","updated_at":"2016-09-20T19:16:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b9dc73aa8a8f2bdc689d4e13d87d08b3d9ad6bc","assignee":{"login":"emilio","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false},"assignees":[{"login":"emilio","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/13335/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/13335/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/13335/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/1d497828a76ae0739463ef6a196fa4b98b06173c","head":{"label":"Manishearth:stylo-tests","ref":"stylo-tests","sha":"1d497828a76ae0739463ef6a196fa4b98b06173c","user":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"repo":{"id":17138296,"name":"servo","full_name":"Manishearth/servo","owner":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Manishearth/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/Manishearth/servo","forks_url":"https://api.github.com/repos/Manishearth/servo/forks","keys_url":"https://api.github.com/repos/Manishearth/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Manishearth/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Manishearth/servo/teams","hooks_url":"https://api.github.com/repos/Manishearth/servo/hooks","issue_events_url":"https://api.github.com/repos/Manishearth/servo/issues/events{/number}","events_url":"https://api.github.com/repos/Manishearth/servo/events","assignees_url":"https://api.github.com/repos/Manishearth/servo/assignees{/user}","branches_url":"https://api.github.com/repos/Manishearth/servo/branches{/branch}","tags_url":"https://api.github.com/repos/Manishearth/servo/tags","blobs_url":"https://api.github.com/repos/Manishearth/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Manishearth/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Manishearth/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Manishearth/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Manishearth/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/Manishearth/servo/languages","stargazers_url":"https://api.github.com/repos/Manishearth/servo/stargazers","contributors_url":"https://api.github.com/repos/Manishearth/servo/contributors","subscribers_url":"https://api.github.com/repos/Manishearth/servo/subscribers","subscription_url":"https://api.github.com/repos/Manishearth/servo/subscription","commits_url":"https://api.github.com/repos/Manishearth/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Manishearth/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Manishearth/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Manishearth/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/Manishearth/servo/contents/{+path}","compare_url":"https://api.github.com/repos/Manishearth/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Manishearth/servo/merges","archive_url":"https://api.github.com/repos/Manishearth/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Manishearth/servo/downloads","issues_url":"https://api.github.com/repos/Manishearth/servo/issues{/number}","pulls_url":"https://api.github.com/repos/Manishearth/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/Manishearth/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/Manishearth/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Manishearth/servo/labels{/name}","releases_url":"https://api.github.com/repos/Manishearth/servo/releases{/id}","deployments_url":"https://api.github.com/repos/Manishearth/servo/deployments","created_at":"2014-02-24T14:18:00Z","updated_at":"2015-10-18T11:13:31Z","pushed_at":"2016-09-20T18:36:06Z","git_url":"git://github.com/Manishearth/servo.git","ssh_url":"git@github.com:Manishearth/servo.git","clone_url":"https://github.com/Manishearth/servo.git","svn_url":"https://github.com/Manishearth/servo","homepage":"","size":208093,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"0d7e747acb7815dfc0cabeed8bd1df7d057f289e","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2016-09-20T18:56:13Z","pushed_at":"2016-09-20T19:02:01Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":295829,"stargazers_count":7927,"watchers_count":7927,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1271,"mirror_url":null,"open_issues_count":1728,"forks":1271,"open_issues":1728,"watchers":7927,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/13335"},"html":{"href":"https://github.com/servo/servo/pull/13335"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/13335"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/13335/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/13335/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/13335/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/1d497828a76ae0739463ef6a196fa4b98b06173c"}}}}
{"actor":{"display_login":"aneeshusa"}}