{"action":"opened","number":26,"pull_request":{"url":"https://api.github.com/repos/serilog/serilog-sinks-file/pulls/26","id":94513076,"html_url":"https://github.com/serilog/serilog-sinks-file/pull/26","diff_url":"https://github.com/serilog/serilog-sinks-file/pull/26.diff","patch_url":"https://github.com/serilog/serilog-sinks-file/pull/26.patch","issue_url":"https://api.github.com/repos/serilog/serilog-sinks-file/issues/26","number":26,"state":"open","locked":false,"title":"Preparations for https://github.com/serilog/serilog-sinks-rollingfile…","user":{"login":"hmvs","id":2255040,"avatar_url":"https://avatars.githubusercontent.com/u/2255040?v=3","gravatar_id":"","url":"https://api.github.com/users/hmvs","html_url":"https://github.com/hmvs","followers_url":"https://api.github.com/users/hmvs/followers","following_url":"https://api.github.com/users/hmvs/following{/other_user}","gists_url":"https://api.github.com/users/hmvs/gists{/gist_id}","starred_url":"https://api.github.com/users/hmvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmvs/subscriptions","organizations_url":"https://api.github.com/users/hmvs/orgs","repos_url":"https://api.github.com/users/hmvs/repos","events_url":"https://api.github.com/users/hmvs/events{/privacy}","received_events_url":"https://api.github.com/users/hmvs/received_events","type":"User","site_admin":false},"body":"It's preparation for https://github.com/serilog/serilog-sinks-rollingfile/issues/33\r\n\r\nIs there any reason why `PeriodicFlushToDiskSink` uses `ILogEventSink`  as a parameter for the constructor? I propose to not do [downcasting](http://codebetter.com/jeremymiller/2006/12/26/downcasting-is-a-code-smell/). Do we have some file-based sync that can't be flushed in one way or another?\r\nI believe we should make an interface `IFileSink` that will be inherited from both `ISizeLimitedFileSink`, `IFlushableFileSink`.  \r\n\r\nWill do it in next commit if you  accept this refactoring. ","created_at":"2016-11-20T10:02:31Z","updated_at":"2016-11-20T10:02:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/serilog/serilog-sinks-file/pulls/26/commits","review_comments_url":"https://api.github.com/repos/serilog/serilog-sinks-file/pulls/26/comments","review_comment_url":"https://api.github.com/repos/serilog/serilog-sinks-file/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serilog/serilog-sinks-file/issues/26/comments","statuses_url":"https://api.github.com/repos/serilog/serilog-sinks-file/statuses/e62352989b18cc6738ed90bde6fcbab6ff8b5ec0","head":{"label":"hmvs:dev","ref":"dev","sha":"e62352989b18cc6738ed90bde6fcbab6ff8b5ec0","user":{"login":"hmvs","id":2255040,"avatar_url":"https://avatars.githubusercontent.com/u/2255040?v=3","gravatar_id":"","url":"https://api.github.com/users/hmvs","html_url":"https://github.com/hmvs","followers_url":"https://api.github.com/users/hmvs/followers","following_url":"https://api.github.com/users/hmvs/following{/other_user}","gists_url":"https://api.github.com/users/hmvs/gists{/gist_id}","starred_url":"https://api.github.com/users/hmvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmvs/subscriptions","organizations_url":"https://api.github.com/users/hmvs/orgs","repos_url":"https://api.github.com/users/hmvs/repos","events_url":"https://api.github.com/users/hmvs/events{/privacy}","received_events_url":"https://api.github.com/users/hmvs/received_events","type":"User","site_admin":false},"repo":{"id":74262884,"name":"serilog-sinks-file","full_name":"hmvs/serilog-sinks-file","owner":{"login":"hmvs","id":2255040,"avatar_url":"https://avatars.githubusercontent.com/u/2255040?v=3","gravatar_id":"","url":"https://api.github.com/users/hmvs","html_url":"https://github.com/hmvs","followers_url":"https://api.github.com/users/hmvs/followers","following_url":"https://api.github.com/users/hmvs/following{/other_user}","gists_url":"https://api.github.com/users/hmvs/gists{/gist_id}","starred_url":"https://api.github.com/users/hmvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmvs/subscriptions","organizations_url":"https://api.github.com/users/hmvs/orgs","repos_url":"https://api.github.com/users/hmvs/repos","events_url":"https://api.github.com/users/hmvs/events{/privacy}","received_events_url":"https://api.github.com/users/hmvs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hmvs/serilog-sinks-file","description":"The file sink for Serilog","fork":true,"url":"https://api.github.com/repos/hmvs/serilog-sinks-file","forks_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/forks","keys_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/teams","hooks_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/hooks","issue_events_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/issues/events{/number}","events_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/events","assignees_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/assignees{/user}","branches_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/branches{/branch}","tags_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/tags","blobs_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/statuses/{sha}","languages_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/languages","stargazers_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/stargazers","contributors_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/contributors","subscribers_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/subscribers","subscription_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/subscription","commits_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/contents/{+path}","compare_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/merges","archive_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/downloads","issues_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/issues{/number}","pulls_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/pulls{/number}","milestones_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/milestones{/number}","notifications_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/labels{/name}","releases_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/releases{/id}","deployments_url":"https://api.github.com/repos/hmvs/serilog-sinks-file/deployments","created_at":"2016-11-20T08:56:14Z","updated_at":"2016-11-20T08:56:15Z","pushed_at":"2016-11-20T09:45:08Z","git_url":"git://github.com/hmvs/serilog-sinks-file.git","ssh_url":"git@github.com:hmvs/serilog-sinks-file.git","clone_url":"https://github.com/hmvs/serilog-sinks-file.git","svn_url":"https://github.com/hmvs/serilog-sinks-file","homepage":null,"size":75,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"serilog:dev","ref":"dev","sha":"77eed1b5772be8ad549cdbbcc2d8dcfa2ef92a54","user":{"login":"serilog","id":5691010,"avatar_url":"https://avatars.githubusercontent.com/u/5691010?v=3","gravatar_id":"","url":"https://api.github.com/users/serilog","html_url":"https://github.com/serilog","followers_url":"https://api.github.com/users/serilog/followers","following_url":"https://api.github.com/users/serilog/following{/other_user}","gists_url":"https://api.github.com/users/serilog/gists{/gist_id}","starred_url":"https://api.github.com/users/serilog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serilog/subscriptions","organizations_url":"https://api.github.com/users/serilog/orgs","repos_url":"https://api.github.com/users/serilog/repos","events_url":"https://api.github.com/users/serilog/events{/privacy}","received_events_url":"https://api.github.com/users/serilog/received_events","type":"Organization","site_admin":false},"repo":{"id":53472131,"name":"serilog-sinks-file","full_name":"serilog/serilog-sinks-file","owner":{"login":"serilog","id":5691010,"avatar_url":"https://avatars.githubusercontent.com/u/5691010?v=3","gravatar_id":"","url":"https://api.github.com/users/serilog","html_url":"https://github.com/serilog","followers_url":"https://api.github.com/users/serilog/followers","following_url":"https://api.github.com/users/serilog/following{/other_user}","gists_url":"https://api.github.com/users/serilog/gists{/gist_id}","starred_url":"https://api.github.com/users/serilog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serilog/subscriptions","organizations_url":"https://api.github.com/users/serilog/orgs","repos_url":"https://api.github.com/users/serilog/repos","events_url":"https://api.github.com/users/serilog/events{/privacy}","received_events_url":"https://api.github.com/users/serilog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serilog/serilog-sinks-file","description":"The file sink for Serilog","fork":false,"url":"https://api.github.com/repos/serilog/serilog-sinks-file","forks_url":"https://api.github.com/repos/serilog/serilog-sinks-file/forks","keys_url":"https://api.github.com/repos/serilog/serilog-sinks-file/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serilog/serilog-sinks-file/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serilog/serilog-sinks-file/teams","hooks_url":"https://api.github.com/repos/serilog/serilog-sinks-file/hooks","issue_events_url":"https://api.github.com/repos/serilog/serilog-sinks-file/issues/events{/number}","events_url":"https://api.github.com/repos/serilog/serilog-sinks-file/events","assignees_url":"https://api.github.com/repos/serilog/serilog-sinks-file/assignees{/user}","branches_url":"https://api.github.com/repos/serilog/serilog-sinks-file/branches{/branch}","tags_url":"https://api.github.com/repos/serilog/serilog-sinks-file/tags","blobs_url":"https://api.github.com/repos/serilog/serilog-sinks-file/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serilog/serilog-sinks-file/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serilog/serilog-sinks-file/git/refs{/sha}","trees_url":"https://api.github.com/repos/serilog/serilog-sinks-file/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serilog/serilog-sinks-file/statuses/{sha}","languages_url":"https://api.github.com/repos/serilog/serilog-sinks-file/languages","stargazers_url":"https://api.github.com/repos/serilog/serilog-sinks-file/stargazers","contributors_url":"https://api.github.com/repos/serilog/serilog-sinks-file/contributors","subscribers_url":"https://api.github.com/repos/serilog/serilog-sinks-file/subscribers","subscription_url":"https://api.github.com/repos/serilog/serilog-sinks-file/subscription","commits_url":"https://api.github.com/repos/serilog/serilog-sinks-file/commits{/sha}","git_commits_url":"https://api.github.com/repos/serilog/serilog-sinks-file/git/commits{/sha}","comments_url":"https://api.github.com/repos/serilog/serilog-sinks-file/comments{/number}","issue_comment_url":"https://api.github.com/repos/serilog/serilog-sinks-file/issues/comments{/number}","contents_url":"https://api.github.com/repos/serilog/serilog-sinks-file/contents/{+path}","compare_url":"https://api.github.com/repos/serilog/serilog-sinks-file/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serilog/serilog-sinks-file/merges","archive_url":"https://api.github.com/repos/serilog/serilog-sinks-file/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serilog/serilog-sinks-file/downloads","issues_url":"https://api.github.com/repos/serilog/serilog-sinks-file/issues{/number}","pulls_url":"https://api.github.com/repos/serilog/serilog-sinks-file/pulls{/number}","milestones_url":"https://api.github.com/repos/serilog/serilog-sinks-file/milestones{/number}","notifications_url":"https://api.github.com/repos/serilog/serilog-sinks-file/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serilog/serilog-sinks-file/labels{/name}","releases_url":"https://api.github.com/repos/serilog/serilog-sinks-file/releases{/id}","deployments_url":"https://api.github.com/repos/serilog/serilog-sinks-file/deployments","created_at":"2016-03-09T05:54:08Z","updated_at":"2016-11-15T03:18:51Z","pushed_at":"2016-11-15T03:20:58Z","git_url":"git://github.com/serilog/serilog-sinks-file.git","ssh_url":"git@github.com:serilog/serilog-sinks-file.git","clone_url":"https://github.com/serilog/serilog-sinks-file.git","svn_url":"https://github.com/serilog/serilog-sinks-file","homepage":null,"size":75,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":2,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/serilog/serilog-sinks-file/pulls/26"},"html":{"href":"https://github.com/serilog/serilog-sinks-file/pull/26"},"issue":{"href":"https://api.github.com/repos/serilog/serilog-sinks-file/issues/26"},"comments":{"href":"https://api.github.com/repos/serilog/serilog-sinks-file/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/serilog/serilog-sinks-file/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/serilog/serilog-sinks-file/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serilog/serilog-sinks-file/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/serilog/serilog-sinks-file/statuses/e62352989b18cc6738ed90bde6fcbab6ff8b5ec0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":63,"deletions":17,"changed_files":4}}
{"actor":{"display_login":"hmvs"}}