{"action":"created","issue":{"url":"https://api.github.com/repos/mgwidmann/scrivener_html/issues/42","repository_url":"https://api.github.com/repos/mgwidmann/scrivener_html","labels_url":"https://api.github.com/repos/mgwidmann/scrivener_html/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/mgwidmann/scrivener_html/issues/42/comments","events_url":"https://api.github.com/repos/mgwidmann/scrivener_html/issues/42/events","html_url":"https://github.com/mgwidmann/scrivener_html/pull/42","id":191373997,"number":42,"title":"adding support for params defined with a keyword list","user":{"login":"martinos","id":104921,"avatar_url":"https://avatars.githubusercontent.com/u/104921?v=3","gravatar_id":"","url":"https://api.github.com/users/martinos","html_url":"https://github.com/martinos","followers_url":"https://api.github.com/users/martinos/followers","following_url":"https://api.github.com/users/martinos/following{/other_user}","gists_url":"https://api.github.com/users/martinos/gists{/gist_id}","starred_url":"https://api.github.com/users/martinos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinos/subscriptions","organizations_url":"https://api.github.com/users/martinos/orgs","repos_url":"https://api.github.com/users/martinos/repos","events_url":"https://api.github.com/users/martinos/events{/privacy}","received_events_url":"https://api.github.com/users/martinos/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-23T20:34:32Z","updated_at":"2016-12-01T13:34:39Z","closed_at":"2016-12-01T13:32:32Z","pull_request":{"url":"https://api.github.com/repos/mgwidmann/scrivener_html/pulls/42","html_url":"https://github.com/mgwidmann/scrivener_html/pull/42","diff_url":"https://github.com/mgwidmann/scrivener_html/pull/42.diff","patch_url":"https://github.com/mgwidmann/scrivener_html/pull/42.patch"},"body":"I was trying to pass a nested keyword list as a query param to the pagination_links function:\r\n\r\n```\r\npagination_links(@orders, [q: [name: \"joe\"]])\r\n```\r\nI was getting the following error:\r\n\r\n```\r\n** (exit) an exception was raised:\r\n    ** (ArgumentError) cannot convert the given list to a string.\r\n\r\nTo be converted to a string, a list must contain only:\r\n\r\n  * strings\r\n  * integers representing Unicode codepoints\r\n  * or a list containing one of these three elements\r\n\r\nPlease check the given list or call inspect/1 to get the list representation, got:\r\n\r\n[name: \"joe\"]\r\n\r\n        (elixir) lib/list.ex:624: List.to_string/1\r\n        (scrivener_html) lib/scrivener/html.ex:41: anonymous fn/2 in Scrivener.HTML.Default.path/3\r\n```\r\nI replaced the code that generates the query params by the `Plug.Conn.Query.encode` function. I think it will make the function more generic.\r\n\r\nI hope that this makes sense."},"comment":{"url":"https://api.github.com/repos/mgwidmann/scrivener_html/issues/comments/264174215","html_url":"https://github.com/mgwidmann/scrivener_html/pull/42#issuecomment-264174215","issue_url":"https://api.github.com/repos/mgwidmann/scrivener_html/issues/42","id":264174215,"user":{"login":"mgwidmann","id":5035724,"avatar_url":"https://avatars.githubusercontent.com/u/5035724?v=3","gravatar_id":"","url":"https://api.github.com/users/mgwidmann","html_url":"https://github.com/mgwidmann","followers_url":"https://api.github.com/users/mgwidmann/followers","following_url":"https://api.github.com/users/mgwidmann/following{/other_user}","gists_url":"https://api.github.com/users/mgwidmann/gists{/gist_id}","starred_url":"https://api.github.com/users/mgwidmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgwidmann/subscriptions","organizations_url":"https://api.github.com/users/mgwidmann/orgs","repos_url":"https://api.github.com/users/mgwidmann/repos","events_url":"https://api.github.com/users/mgwidmann/events{/privacy}","received_events_url":"https://api.github.com/users/mgwidmann/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T13:34:39Z","updated_at":"2016-12-01T13:34:39Z","body":"Released as v1.4.0"}}
{"actor":{"display_login":"mgwidmann"}}