{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/62567818","id":62567818,"diff_hunk":"@@ -0,0 +1,38 @@\n+#ifndef DATAFORMATS_HCALRECHIT_HFPRERECHIT_H\n+#define DATAFORMATS_HCALRECHIT_HFPRERECHIT_H\n+\n+#include \"DataFormats/HcalRecHit/interface/HFQIE10Info.h\"\n+\n+/** \\class HFPreRecHit\n+*\n+* Class to contain the info needed to perform HF reconstruction\n+* using QIE10 chips and dual-anode readout. Groups the information\n+* provided by a single PMT.\n+*/\n+class HFPreRecHit\n+{\n+public:\n+    typedef HcalDetId key_type;\n+\n+    HFPreRecHit();\n+\n+    // In the constructor below, either \"first\" or \"second\"\n+    // pointer can be nullptr\n+    HFPreRecHit(const HcalDetId& id, const HFQIE10Info* first,\n+                const HFQIE10Info* second);\n+\n+    inline HcalDetId id() const {return id_;}\n+\n+    // Get a pointer to the QIE10 info. nullptr will be returned\n+    // if the info with the given index does not exist or if the\n+    // index is out of range.\n+    const HFQIE10Info* getHFQIE10Info(unsigned index) const;\n+\n+private:\n+    HcalDetId id_;\n+\n+    HFQIE10Info hfQIE10Info_[2];\n+    uint8_t hasInfo_[2];","path":"DataFormats/HcalRecHit/interface/HFPreRecHit.h","position":35,"original_position":35,"commit_id":"d13235f9c646cc3c33425064ddf2551a81a4bef7","original_commit_id":"d13235f9c646cc3c33425064ddf2551a81a4bef7","user":{"login":"igv4321","id":5552377,"avatar_url":"https://avatars.githubusercontent.com/u/5552377?v=3","gravatar_id":"","url":"https://api.github.com/users/igv4321","html_url":"https://github.com/igv4321","followers_url":"https://api.github.com/users/igv4321/followers","following_url":"https://api.github.com/users/igv4321/following{/other_user}","gists_url":"https://api.github.com/users/igv4321/gists{/gist_id}","starred_url":"https://api.github.com/users/igv4321/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igv4321/subscriptions","organizations_url":"https://api.github.com/users/igv4321/orgs","repos_url":"https://api.github.com/users/igv4321/repos","events_url":"https://api.github.com/users/igv4321/events{/privacy}","received_events_url":"https://api.github.com/users/igv4321/received_events","type":"User","site_admin":false},"body":"Please make sure to mention next time everything you\nare waiting for. Enforcing your personal preferences\non somebody else's perfectly functional code in a very\nobscure manner slows down the code development\nprocess significantly.\n\nOn 05/09/2016 03:11 PM, Slava Krutelyov wrote:\n>\n> In DataFormats/HcalRecHit/interface/HFPreRecHit.h <https://github.com/cms-sw/cmssw/pull/14383#discussion_r62564272>:\n>\n> > +    // pointer can be nullptr\n> > +    HFPreRecHit(const HcalDetId& id, const HFQIE10Info* first,\n> > +                const HFQIE10Info* second);\n> > +\n> > +    inline HcalDetId id() const {return id_;}\n> > +\n> > +    // Get a pointer to the QIE10 info. nullptr will be returned\n> > +    // if the info with the given index does not exist or if the\n> > +    // index is out of range.\n> > +    const HFQIE10Info* getHFQIE10Info(unsigned index) const;\n> > +\n> > +private:\n> > +    HcalDetId id_;\n> > +\n> > +    HFQIE10Info hfQIE10Info_[2];\n> > +    uint8_t hasInfo_[2];\n>\n> I was actually waiting for a change to |bool|\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly or view it on GitHub <https://github.com/cms-sw/cmssw/pull/14383/files/d13235f9c646cc3c33425064ddf2551a81a4bef7#r62564272>\n>\n\n","created_at":"2016-05-09T20:32:43Z","updated_at":"2016-05-09T20:32:43Z","html_url":"https://github.com/cms-sw/cmssw/pull/14383#discussion_r62567818","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/14383","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/62567818"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/14383#discussion_r62567818"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/14383"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/14383","id":68980304,"html_url":"https://github.com/cms-sw/cmssw/pull/14383","diff_url":"https://github.com/cms-sw/cmssw/pull/14383.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/14383.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14383","number":14383,"state":"open","locked":false,"title":"Initial implementation of the pre-reco stage for the Phase 1 HF reco","user":{"login":"igv4321","id":5552377,"avatar_url":"https://avatars.githubusercontent.com/u/5552377?v=3","gravatar_id":"","url":"https://api.github.com/users/igv4321","html_url":"https://github.com/igv4321","followers_url":"https://api.github.com/users/igv4321/followers","following_url":"https://api.github.com/users/igv4321/following{/other_user}","gists_url":"https://api.github.com/users/igv4321/gists{/gist_id}","starred_url":"https://api.github.com/users/igv4321/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igv4321/subscriptions","organizations_url":"https://api.github.com/users/igv4321/orgs","repos_url":"https://api.github.com/users/igv4321/repos","events_url":"https://api.github.com/users/igv4321/events{/privacy}","received_events_url":"https://api.github.com/users/igv4321/received_events","type":"User","site_admin":false},"body":"Creating an intermediate collection to hold the extended information for split-anode Phase 1 HF PMT readouts. When we understand better how to use the TDC data from the QIE10 front-end chips, a collection of HFRecHit objects will be created from this one.\r\n\r\nThis pull request does not modify any existing data structures or algorithms.\r\n","created_at":"2016-05-05T08:44:50Z","updated_at":"2016-05-09T20:32:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2cbc431eff94acc77b9dd4021df5c2fe2b0e99c","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":81,"closed_issues":549,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-05-09T17:37:44Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/14383/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/14383/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14383/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/d13235f9c646cc3c33425064ddf2551a81a4bef7","head":{"label":"igv4321:hf-reco-phase1","ref":"hf-reco-phase1","sha":"d13235f9c646cc3c33425064ddf2551a81a4bef7","user":{"login":"igv4321","id":5552377,"avatar_url":"https://avatars.githubusercontent.com/u/5552377?v=3","gravatar_id":"","url":"https://api.github.com/users/igv4321","html_url":"https://github.com/igv4321","followers_url":"https://api.github.com/users/igv4321/followers","following_url":"https://api.github.com/users/igv4321/following{/other_user}","gists_url":"https://api.github.com/users/igv4321/gists{/gist_id}","starred_url":"https://api.github.com/users/igv4321/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igv4321/subscriptions","organizations_url":"https://api.github.com/users/igv4321/orgs","repos_url":"https://api.github.com/users/igv4321/repos","events_url":"https://api.github.com/users/igv4321/events{/privacy}","received_events_url":"https://api.github.com/users/igv4321/received_events","type":"User","site_admin":false},"repo":{"id":18013692,"name":"cmssw","full_name":"igv4321/cmssw","owner":{"login":"igv4321","id":5552377,"avatar_url":"https://avatars.githubusercontent.com/u/5552377?v=3","gravatar_id":"","url":"https://api.github.com/users/igv4321","html_url":"https://github.com/igv4321","followers_url":"https://api.github.com/users/igv4321/followers","following_url":"https://api.github.com/users/igv4321/following{/other_user}","gists_url":"https://api.github.com/users/igv4321/gists{/gist_id}","starred_url":"https://api.github.com/users/igv4321/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igv4321/subscriptions","organizations_url":"https://api.github.com/users/igv4321/orgs","repos_url":"https://api.github.com/users/igv4321/repos","events_url":"https://api.github.com/users/igv4321/events{/privacy}","received_events_url":"https://api.github.com/users/igv4321/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/igv4321/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/igv4321/cmssw","forks_url":"https://api.github.com/repos/igv4321/cmssw/forks","keys_url":"https://api.github.com/repos/igv4321/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/igv4321/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/igv4321/cmssw/teams","hooks_url":"https://api.github.com/repos/igv4321/cmssw/hooks","issue_events_url":"https://api.github.com/repos/igv4321/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/igv4321/cmssw/events","assignees_url":"https://api.github.com/repos/igv4321/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/igv4321/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/igv4321/cmssw/tags","blobs_url":"https://api.github.com/repos/igv4321/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/igv4321/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/igv4321/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/igv4321/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/igv4321/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/igv4321/cmssw/languages","stargazers_url":"https://api.github.com/repos/igv4321/cmssw/stargazers","contributors_url":"https://api.github.com/repos/igv4321/cmssw/contributors","subscribers_url":"https://api.github.com/repos/igv4321/cmssw/subscribers","subscription_url":"https://api.github.com/repos/igv4321/cmssw/subscription","commits_url":"https://api.github.com/repos/igv4321/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/igv4321/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/igv4321/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/igv4321/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/igv4321/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/igv4321/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/igv4321/cmssw/merges","archive_url":"https://api.github.com/repos/igv4321/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/igv4321/cmssw/downloads","issues_url":"https://api.github.com/repos/igv4321/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/igv4321/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/igv4321/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/igv4321/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/igv4321/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/igv4321/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/igv4321/cmssw/deployments","created_at":"2014-03-22T16:11:12Z","updated_at":"2014-05-20T07:41:30Z","pushed_at":"2016-05-05T09:06:20Z","git_url":"git://github.com/igv4321/cmssw.git","ssh_url":"git@github.com:igv4321/cmssw.git","clone_url":"https://github.com/igv4321/cmssw.git","svn_url":"https://github.com/igv4321/cmssw","homepage":"cms-sw.github.io/cmssw","size":835037,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_1_X"}},"base":{"label":"cms-sw:CMSSW_8_1_X","ref":"CMSSW_8_1_X","sha":"90d539f43b68eb47513c4e34fc7b8243c411f127","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2016-05-08T23:32:55Z","pushed_at":"2016-05-09T19:21:52Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1076956,"stargazers_count":308,"watchers_count":308,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1811,"mirror_url":null,"open_issues_count":345,"forks":1811,"open_issues":345,"watchers":308,"default_branch":"CMSSW_8_1_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/14383"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/14383"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/14383"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/14383/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/14383/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/14383/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/d13235f9c646cc3c33425064ddf2551a81a4bef7"}}}}