{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7312","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7312/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7312/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7312/events","html_url":"https://github.com/cockroachdb/cockroach/pull/7312","id":160958526,"number":7312,"title":"Change SetupMultinodeTestCluster so that it waits for at least one of…","user":{"login":"WillHaack","id":766792,"avatar_url":"https://avatars.githubusercontent.com/u/766792?v=3","gravatar_id":"","url":"https://api.github.com/users/WillHaack","html_url":"https://github.com/WillHaack","followers_url":"https://api.github.com/users/WillHaack/followers","following_url":"https://api.github.com/users/WillHaack/following{/other_user}","gists_url":"https://api.github.com/users/WillHaack/gists{/gist_id}","starred_url":"https://api.github.com/users/WillHaack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WillHaack/subscriptions","organizations_url":"https://api.github.com/users/WillHaack/orgs","repos_url":"https://api.github.com/users/WillHaack/repos","events_url":"https://api.github.com/users/WillHaack/events{/privacy}","received_events_url":"https://api.github.com/users/WillHaack/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":25,"created_at":"2016-06-17T19:26:43Z","updated_at":"2016-06-30T16:59:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/7312","html_url":"https://github.com/cockroachdb/cockroach/pull/7312","diff_url":"https://github.com/cockroachdb/cockroach/pull/7312.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/7312.patch"},"body":"… the joining nodes to receive a replication before returning the set of clusters in order to make the multinode test more meaningful. In addition, every SQL benchmark test was given a corresponding multinode test. Addresses https://github.com/cockroachdb/cockroach/issues/6890\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/7312)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/229721466","html_url":"https://github.com/cockroachdb/cockroach/pull/7312#issuecomment-229721466","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7312","id":229721466,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T16:59:17Z","updated_at":"2016-06-30T16:59:17Z","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/>\n\nplease squash\n\n---\n\nReviewed 3 of 4 files at r44, 2 of 2 files at r45.\nReview status: all files reviewed at latest revision, 15 unresolved discussions, all commit checks successful.\n\n---\n\n*[server/testserver.go, line 157 \\[r45\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/7312#-KLX2uW4AcPuaJg-ilfU:-KLX2uW4AcPuaJg-ilfV:-51283596) ([raw file](https://github.com/cockroachdb/cockroach/blob/1bfdc675cd95505157ffe17e8453d56f059e4ed9/server/testserver.go#L157)):*\n> ```Go\n> }\n> \n> // StartParams are knobs that determine the properties of a testserver when it initializes.\n> ```\n\nwrap at 80\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/7312#-:-KLXEzCY7CtReb2pViZI:-1434931708)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"tamird"}}