{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/67605710","id":67605710,"diff_hunk":"@@ -147,5 +151,6 @@ export class ViewMetadata {\n     this.pipes = pipes;\n     this.encapsulation = encapsulation;\n     this.animations = animations;\n+    this.interpolation = interpolation;","path":"modules/@angular/core/src/metadata/view.ts","position":27,"original_position":27,"commit_id":"adc9e82510af10aaebb6dc5f6f5259bdd2705a13","original_commit_id":"adc9e82510af10aaebb6dc5f6f5259bdd2705a13","user":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"body":"Please assert here","created_at":"2016-06-18T19:48:37Z","updated_at":"2016-06-18T19:48:37Z","html_url":"https://github.com/angular/angular/pull/9158#discussion_r67605710","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/9158","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/67605710"},"html":{"href":"https://github.com/angular/angular/pull/9158#discussion_r67605710"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/9158"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/9158","id":73472039,"html_url":"https://github.com/angular/angular/pull/9158","diff_url":"https://github.com/angular/angular/pull/9158.diff","patch_url":"https://github.com/angular/angular/pull/9158.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/9158","number":9158,"state":"open","locked":false,"title":"feat(compiler): Introduce InterpolationConfig into component","user":{"login":"laco0416","id":1529180,"avatar_url":"https://avatars.githubusercontent.com/u/1529180?v=3","gravatar_id":"","url":"https://api.github.com/users/laco0416","html_url":"https://github.com/laco0416","followers_url":"https://api.github.com/users/laco0416/followers","following_url":"https://api.github.com/users/laco0416/following{/other_user}","gists_url":"https://api.github.com/users/laco0416/gists{/gist_id}","starred_url":"https://api.github.com/users/laco0416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laco0416/subscriptions","organizations_url":"https://api.github.com/users/laco0416/orgs","repos_url":"https://api.github.com/users/laco0416/repos","events_url":"https://api.github.com/users/laco0416/events{/privacy}","received_events_url":"https://api.github.com/users/laco0416/received_events","type":"User","site_admin":false},"body":"**Please check if the PR fulfills these requirements**\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n**What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...)\r\n- [x] Feature\r\n\r\n**What is the current behavior?** (You can also link to an open issue here)\r\n\r\nInterpolation symbols are defined as const `INTERPOLATION_REGEXP`.\r\nThis is not friendly to collaboration with other templating engines. (e.g. Python jinja)\r\n\r\n**What is the new behavior?**\r\n\r\nComponentMetadata has a new property, `interpolation`, which has start/end symbols for interpolation. \r\n \r\n```ts\r\n@Component({\r\n  template: `\r\n  {% someProp %}\r\n  `,\r\n  interpolation: ['{%', '%}']\r\n})\r\nclass SomeComp {\r\n  someProp;\r\n}\r\n```\r\n\r\n**Does this PR introduce a breaking change?**\r\n- [x] No\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\r\n\r\n\r\n**Other information**:\r\nThis is re-implementation from https://github.com/angular/angular/pull/8906\r\n\r\ncc/ @vicb \r\n\r\n","created_at":"2016-06-11T16:27:31Z","updated_at":"2016-06-18T19:48:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c9069e763d650654a7695decb3ab13c55df0bfc","assignee":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/9158/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/9158/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/9158/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/adc9e82510af10aaebb6dc5f6f5259bdd2705a13","head":{"label":"laco0416:laco-component-interpolation-config","ref":"laco-component-interpolation-config","sha":"adc9e82510af10aaebb6dc5f6f5259bdd2705a13","user":{"login":"laco0416","id":1529180,"avatar_url":"https://avatars.githubusercontent.com/u/1529180?v=3","gravatar_id":"","url":"https://api.github.com/users/laco0416","html_url":"https://github.com/laco0416","followers_url":"https://api.github.com/users/laco0416/followers","following_url":"https://api.github.com/users/laco0416/following{/other_user}","gists_url":"https://api.github.com/users/laco0416/gists{/gist_id}","starred_url":"https://api.github.com/users/laco0416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laco0416/subscriptions","organizations_url":"https://api.github.com/users/laco0416/orgs","repos_url":"https://api.github.com/users/laco0416/repos","events_url":"https://api.github.com/users/laco0416/events{/privacy}","received_events_url":"https://api.github.com/users/laco0416/received_events","type":"User","site_admin":false},"repo":{"id":49241823,"name":"angular","full_name":"laco0416/angular","owner":{"login":"laco0416","id":1529180,"avatar_url":"https://avatars.githubusercontent.com/u/1529180?v=3","gravatar_id":"","url":"https://api.github.com/users/laco0416","html_url":"https://github.com/laco0416","followers_url":"https://api.github.com/users/laco0416/followers","following_url":"https://api.github.com/users/laco0416/following{/other_user}","gists_url":"https://api.github.com/users/laco0416/gists{/gist_id}","starred_url":"https://api.github.com/users/laco0416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laco0416/subscriptions","organizations_url":"https://api.github.com/users/laco0416/orgs","repos_url":"https://api.github.com/users/laco0416/repos","events_url":"https://api.github.com/users/laco0416/events{/privacy}","received_events_url":"https://api.github.com/users/laco0416/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laco0416/angular","description":":jp: Issue Tracker for Japanese Angularists","fork":true,"url":"https://api.github.com/repos/laco0416/angular","forks_url":"https://api.github.com/repos/laco0416/angular/forks","keys_url":"https://api.github.com/repos/laco0416/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laco0416/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laco0416/angular/teams","hooks_url":"https://api.github.com/repos/laco0416/angular/hooks","issue_events_url":"https://api.github.com/repos/laco0416/angular/issues/events{/number}","events_url":"https://api.github.com/repos/laco0416/angular/events","assignees_url":"https://api.github.com/repos/laco0416/angular/assignees{/user}","branches_url":"https://api.github.com/repos/laco0416/angular/branches{/branch}","tags_url":"https://api.github.com/repos/laco0416/angular/tags","blobs_url":"https://api.github.com/repos/laco0416/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laco0416/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laco0416/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/laco0416/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laco0416/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/laco0416/angular/languages","stargazers_url":"https://api.github.com/repos/laco0416/angular/stargazers","contributors_url":"https://api.github.com/repos/laco0416/angular/contributors","subscribers_url":"https://api.github.com/repos/laco0416/angular/subscribers","subscription_url":"https://api.github.com/repos/laco0416/angular/subscription","commits_url":"https://api.github.com/repos/laco0416/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/laco0416/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/laco0416/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/laco0416/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/laco0416/angular/contents/{+path}","compare_url":"https://api.github.com/repos/laco0416/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laco0416/angular/merges","archive_url":"https://api.github.com/repos/laco0416/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laco0416/angular/downloads","issues_url":"https://api.github.com/repos/laco0416/angular/issues{/number}","pulls_url":"https://api.github.com/repos/laco0416/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/laco0416/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/laco0416/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laco0416/angular/labels{/name}","releases_url":"https://api.github.com/repos/laco0416/angular/releases{/id}","deployments_url":"https://api.github.com/repos/laco0416/angular/deployments","created_at":"2016-01-08T01:38:43Z","updated_at":"2016-06-18T08:18:54Z","pushed_at":"2016-06-18T05:26:55Z","git_url":"git://github.com/laco0416/angular.git","ssh_url":"git@github.com:laco0416/angular.git","clone_url":"https://github.com/laco0416/angular.git","svn_url":"https://github.com/laco0416/angular","homepage":"https://angular.io","size":254237,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"issue-tracker"}},"base":{"label":"angular:master","ref":"master","sha":"dee1b774f2ef2f873e765c81a559fe3ed6df5d89","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2016-06-18T18:22:36Z","pushed_at":"2016-06-18T16:59:57Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":627756,"stargazers_count":12974,"watchers_count":12974,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3356,"mirror_url":null,"open_issues_count":1387,"forks":3356,"open_issues":1387,"watchers":12974,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/9158"},"html":{"href":"https://github.com/angular/angular/pull/9158"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/9158"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/9158/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/9158/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/9158/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/adc9e82510af10aaebb6dc5f6f5259bdd2705a13"}}}}
{"actor":{"display_login":"vicb"}}