{"action":"created","comment":{"url":"https://api.github.com/repos/almende/vis/pulls/comments/91834360","pull_request_review_id":12347084,"id":91834360,"diff_hunk":"@@ -1021,6 +1021,14 @@ <h2 id=\"Configuration_Options\">Configuration Options</h2>\n       <td>A template function used to generate the contents of the items. The function is called by the Timeline with an items data as the first argument and the item element as the second, and must return HTML code as result. When the option template is specified, the items do not need to have a field <code>content</code>. See section <a href=\"#Templates\">Templates</a> for a detailed explanation.</td>\n     </tr>\n \n+    <tr>\n+      <td>visibleFrameTemplate</td>\n+      <td>function</td>\n+      <td>none</td>\n+      <td>A template function used to generate the visible frame of the items. The function is called by the Timeline with an items data as the first argument and the item frame element as the second, and must return HTML code as result. When the option template is specified, the items do not need to have a field <code>content</code>. See section <a href=\"#Templates\">Templates</a> for a detailed explanation.\n+      This would be used as an additional way to add content that is constant in size with the visible frame of the item and does not get visibly hidden with the item's internal container: <code>vis-item-overflow</code> which is <code>overflow:hidden</code>. [see <a href=\"https://github.com/almende/vis/issues/1126\">example</a>]</td>","path":"docs/timeline/index.html","position":9,"original_position":9,"commit_id":"6ab43f58827c8e866a0a73cb89e05842f777f3b0","original_commit_id":"6ab43f58827c8e866a0a73cb89e05842f777f3b0","user":{"login":"yotamberk","id":4319928,"avatar_url":"https://avatars.githubusercontent.com/u/4319928?v=3","gravatar_id":"","url":"https://api.github.com/users/yotamberk","html_url":"https://github.com/yotamberk","followers_url":"https://api.github.com/users/yotamberk/followers","following_url":"https://api.github.com/users/yotamberk/following{/other_user}","gists_url":"https://api.github.com/users/yotamberk/gists{/gist_id}","starred_url":"https://api.github.com/users/yotamberk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yotamberk/subscriptions","organizations_url":"https://api.github.com/users/yotamberk/orgs","repos_url":"https://api.github.com/users/yotamberk/repos","events_url":"https://api.github.com/users/yotamberk/events{/privacy}","received_events_url":"https://api.github.com/users/yotamberk/received_events","type":"User","site_admin":false},"body":"Probably not a good idea. you're right. ","created_at":"2016-12-10T12:17:42Z","updated_at":"2016-12-10T12:17:42Z","html_url":"https://github.com/almende/vis/pull/2437#discussion_r91834360","pull_request_url":"https://api.github.com/repos/almende/vis/pulls/2437","_links":{"self":{"href":"https://api.github.com/repos/almende/vis/pulls/comments/91834360"},"html":{"href":"https://github.com/almende/vis/pull/2437#discussion_r91834360"},"pull_request":{"href":"https://api.github.com/repos/almende/vis/pulls/2437"}}},"pull_request":{"url":"https://api.github.com/repos/almende/vis/pulls/2437","id":97420353,"html_url":"https://github.com/almende/vis/pull/2437","diff_url":"https://github.com/almende/vis/pull/2437.diff","patch_url":"https://github.com/almende/vis/pull/2437.patch","issue_url":"https://api.github.com/repos/almende/vis/issues/2437","number":2437,"state":"open","locked":false,"title":"Add visibleFrameTemplate option for higher item dom content","user":{"login":"yotamberk","id":4319928,"avatar_url":"https://avatars.githubusercontent.com/u/4319928?v=3","gravatar_id":"","url":"https://api.github.com/users/yotamberk","html_url":"https://github.com/yotamberk","followers_url":"https://api.github.com/users/yotamberk/followers","following_url":"https://api.github.com/users/yotamberk/following{/other_user}","gists_url":"https://api.github.com/users/yotamberk/gists{/gist_id}","starred_url":"https://api.github.com/users/yotamberk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yotamberk/subscriptions","organizations_url":"https://api.github.com/users/yotamberk/orgs","repos_url":"https://api.github.com/users/yotamberk/repos","events_url":"https://api.github.com/users/yotamberk/events{/privacy}","received_events_url":"https://api.github.com/users/yotamberk/received_events","type":"User","site_admin":false},"body":"look at #1126. This is the solution for this problem and many similar problems.","created_at":"2016-12-10T10:25:05Z","updated_at":"2016-12-10T12:17:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9858eedb8bd2f80bfba24c3e01be0b95b5c673b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/almende/vis/pulls/2437/commits","review_comments_url":"https://api.github.com/repos/almende/vis/pulls/2437/comments","review_comment_url":"https://api.github.com/repos/almende/vis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/almende/vis/issues/2437/comments","statuses_url":"https://api.github.com/repos/almende/vis/statuses/6ab43f58827c8e866a0a73cb89e05842f777f3b0","head":{"label":"yotamberk:item-dynamic-content","ref":"item-dynamic-content","sha":"6ab43f58827c8e866a0a73cb89e05842f777f3b0","user":{"login":"yotamberk","id":4319928,"avatar_url":"https://avatars.githubusercontent.com/u/4319928?v=3","gravatar_id":"","url":"https://api.github.com/users/yotamberk","html_url":"https://github.com/yotamberk","followers_url":"https://api.github.com/users/yotamberk/followers","following_url":"https://api.github.com/users/yotamberk/following{/other_user}","gists_url":"https://api.github.com/users/yotamberk/gists{/gist_id}","starred_url":"https://api.github.com/users/yotamberk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yotamberk/subscriptions","organizations_url":"https://api.github.com/users/yotamberk/orgs","repos_url":"https://api.github.com/users/yotamberk/repos","events_url":"https://api.github.com/users/yotamberk/events{/privacy}","received_events_url":"https://api.github.com/users/yotamberk/received_events","type":"User","site_admin":false},"repo":{"id":53567798,"name":"vis","full_name":"yotamberk/vis","owner":{"login":"yotamberk","id":4319928,"avatar_url":"https://avatars.githubusercontent.com/u/4319928?v=3","gravatar_id":"","url":"https://api.github.com/users/yotamberk","html_url":"https://github.com/yotamberk","followers_url":"https://api.github.com/users/yotamberk/followers","following_url":"https://api.github.com/users/yotamberk/following{/other_user}","gists_url":"https://api.github.com/users/yotamberk/gists{/gist_id}","starred_url":"https://api.github.com/users/yotamberk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yotamberk/subscriptions","organizations_url":"https://api.github.com/users/yotamberk/orgs","repos_url":"https://api.github.com/users/yotamberk/repos","events_url":"https://api.github.com/users/yotamberk/events{/privacy}","received_events_url":"https://api.github.com/users/yotamberk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yotamberk/vis","description":"Dynamic, browser-based visualization library","fork":true,"url":"https://api.github.com/repos/yotamberk/vis","forks_url":"https://api.github.com/repos/yotamberk/vis/forks","keys_url":"https://api.github.com/repos/yotamberk/vis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yotamberk/vis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yotamberk/vis/teams","hooks_url":"https://api.github.com/repos/yotamberk/vis/hooks","issue_events_url":"https://api.github.com/repos/yotamberk/vis/issues/events{/number}","events_url":"https://api.github.com/repos/yotamberk/vis/events","assignees_url":"https://api.github.com/repos/yotamberk/vis/assignees{/user}","branches_url":"https://api.github.com/repos/yotamberk/vis/branches{/branch}","tags_url":"https://api.github.com/repos/yotamberk/vis/tags","blobs_url":"https://api.github.com/repos/yotamberk/vis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yotamberk/vis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yotamberk/vis/git/refs{/sha}","trees_url":"https://api.github.com/repos/yotamberk/vis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yotamberk/vis/statuses/{sha}","languages_url":"https://api.github.com/repos/yotamberk/vis/languages","stargazers_url":"https://api.github.com/repos/yotamberk/vis/stargazers","contributors_url":"https://api.github.com/repos/yotamberk/vis/contributors","subscribers_url":"https://api.github.com/repos/yotamberk/vis/subscribers","subscription_url":"https://api.github.com/repos/yotamberk/vis/subscription","commits_url":"https://api.github.com/repos/yotamberk/vis/commits{/sha}","git_commits_url":"https://api.github.com/repos/yotamberk/vis/git/commits{/sha}","comments_url":"https://api.github.com/repos/yotamberk/vis/comments{/number}","issue_comment_url":"https://api.github.com/repos/yotamberk/vis/issues/comments{/number}","contents_url":"https://api.github.com/repos/yotamberk/vis/contents/{+path}","compare_url":"https://api.github.com/repos/yotamberk/vis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yotamberk/vis/merges","archive_url":"https://api.github.com/repos/yotamberk/vis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yotamberk/vis/downloads","issues_url":"https://api.github.com/repos/yotamberk/vis/issues{/number}","pulls_url":"https://api.github.com/repos/yotamberk/vis/pulls{/number}","milestones_url":"https://api.github.com/repos/yotamberk/vis/milestones{/number}","notifications_url":"https://api.github.com/repos/yotamberk/vis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yotamberk/vis/labels{/name}","releases_url":"https://api.github.com/repos/yotamberk/vis/releases{/id}","deployments_url":"https://api.github.com/repos/yotamberk/vis/deployments","created_at":"2016-03-10T08:25:03Z","updated_at":"2016-03-10T08:25:05Z","pushed_at":"2016-12-10T10:22:09Z","git_url":"git://github.com/yotamberk/vis.git","ssh_url":"git@github.com:yotamberk/vis.git","clone_url":"https://github.com/yotamberk/vis.git","svn_url":"https://github.com/yotamberk/vis","homepage":"http://visjs.org","size":127134,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"almende:develop","ref":"develop","sha":"58cc1d93e601a82f3962959173393ff8802a2dd8","user":{"login":"almende","id":1436571,"avatar_url":"https://avatars.githubusercontent.com/u/1436571?v=3","gravatar_id":"","url":"https://api.github.com/users/almende","html_url":"https://github.com/almende","followers_url":"https://api.github.com/users/almende/followers","following_url":"https://api.github.com/users/almende/following{/other_user}","gists_url":"https://api.github.com/users/almende/gists{/gist_id}","starred_url":"https://api.github.com/users/almende/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almende/subscriptions","organizations_url":"https://api.github.com/users/almende/orgs","repos_url":"https://api.github.com/users/almende/repos","events_url":"https://api.github.com/users/almende/events{/privacy}","received_events_url":"https://api.github.com/users/almende/received_events","type":"Organization","site_admin":false},"repo":{"id":9467421,"name":"vis","full_name":"almende/vis","owner":{"login":"almende","id":1436571,"avatar_url":"https://avatars.githubusercontent.com/u/1436571?v=3","gravatar_id":"","url":"https://api.github.com/users/almende","html_url":"https://github.com/almende","followers_url":"https://api.github.com/users/almende/followers","following_url":"https://api.github.com/users/almende/following{/other_user}","gists_url":"https://api.github.com/users/almende/gists{/gist_id}","starred_url":"https://api.github.com/users/almende/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almende/subscriptions","organizations_url":"https://api.github.com/users/almende/orgs","repos_url":"https://api.github.com/users/almende/repos","events_url":"https://api.github.com/users/almende/events{/privacy}","received_events_url":"https://api.github.com/users/almende/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/almende/vis","description":"Dynamic, browser-based visualization library","fork":false,"url":"https://api.github.com/repos/almende/vis","forks_url":"https://api.github.com/repos/almende/vis/forks","keys_url":"https://api.github.com/repos/almende/vis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/almende/vis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/almende/vis/teams","hooks_url":"https://api.github.com/repos/almende/vis/hooks","issue_events_url":"https://api.github.com/repos/almende/vis/issues/events{/number}","events_url":"https://api.github.com/repos/almende/vis/events","assignees_url":"https://api.github.com/repos/almende/vis/assignees{/user}","branches_url":"https://api.github.com/repos/almende/vis/branches{/branch}","tags_url":"https://api.github.com/repos/almende/vis/tags","blobs_url":"https://api.github.com/repos/almende/vis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/almende/vis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/almende/vis/git/refs{/sha}","trees_url":"https://api.github.com/repos/almende/vis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/almende/vis/statuses/{sha}","languages_url":"https://api.github.com/repos/almende/vis/languages","stargazers_url":"https://api.github.com/repos/almende/vis/stargazers","contributors_url":"https://api.github.com/repos/almende/vis/contributors","subscribers_url":"https://api.github.com/repos/almende/vis/subscribers","subscription_url":"https://api.github.com/repos/almende/vis/subscription","commits_url":"https://api.github.com/repos/almende/vis/commits{/sha}","git_commits_url":"https://api.github.com/repos/almende/vis/git/commits{/sha}","comments_url":"https://api.github.com/repos/almende/vis/comments{/number}","issue_comment_url":"https://api.github.com/repos/almende/vis/issues/comments{/number}","contents_url":"https://api.github.com/repos/almende/vis/contents/{+path}","compare_url":"https://api.github.com/repos/almende/vis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/almende/vis/merges","archive_url":"https://api.github.com/repos/almende/vis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/almende/vis/downloads","issues_url":"https://api.github.com/repos/almende/vis/issues{/number}","pulls_url":"https://api.github.com/repos/almende/vis/pulls{/number}","milestones_url":"https://api.github.com/repos/almende/vis/milestones{/number}","notifications_url":"https://api.github.com/repos/almende/vis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/almende/vis/labels{/name}","releases_url":"https://api.github.com/repos/almende/vis/releases{/id}","deployments_url":"https://api.github.com/repos/almende/vis/deployments","created_at":"2013-04-16T08:01:02Z","updated_at":"2016-12-09T23:10:31Z","pushed_at":"2016-12-10T10:25:05Z","git_url":"git://github.com/almende/vis.git","ssh_url":"git@github.com:almende/vis.git","clone_url":"https://github.com/almende/vis.git","svn_url":"https://github.com/almende/vis","homepage":"http://visjs.org","size":136082,"stargazers_count":4482,"watchers_count":4482,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":764,"mirror_url":null,"open_issues_count":372,"forks":764,"open_issues":372,"watchers":4482,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/almende/vis/pulls/2437"},"html":{"href":"https://github.com/almende/vis/pull/2437"},"issue":{"href":"https://api.github.com/repos/almende/vis/issues/2437"},"comments":{"href":"https://api.github.com/repos/almende/vis/issues/2437/comments"},"review_comments":{"href":"https://api.github.com/repos/almende/vis/pulls/2437/comments"},"review_comment":{"href":"https://api.github.com/repos/almende/vis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/almende/vis/pulls/2437/commits"},"statuses":{"href":"https://api.github.com/repos/almende/vis/statuses/6ab43f58827c8e866a0a73cb89e05842f777f3b0"}}}}
{"actor":{"display_login":"yotamberk"}}