{"action":"created","comment":{"url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments/75917192","id":75917192,"diff_hunk":"@@ -282,16 +282,16 @@ internal static string GetApplicationBase(string shellId)\n \n         /// <summary>\n         /// Specifies the per-user configuration settings directory in a platform agnostic manner.\n-        /// Windows Ex:\n-        ///     %LOCALAPPDATA%\\PowerShell\n-        /// Non-Windows Ex:\n-        ///     ~/.config/PowerShell\n         /// </summary>\n         /// <returns>The current user's configuration settings directory</returns>\n-        internal static string GetUserSettingsDirectory()\n+        internal static string GetUserConfigurationDirectory()\n         {\n-            string appDataPath = Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData);\n-            return Path.Combine(appDataPath, \"PowerShell\");\n+#if UNIX\n+            return Platform.SelectProductNameForDirectory(Platform.XDG_Type.CONFIG);","path":"src/System.Management.Automation/engine/Utils.cs","position":16,"original_position":16,"commit_id":"606148ff19fc82cb1f8bd4d99e7fceebd0330c4b","original_commit_id":"606148ff19fc82cb1f8bd4d99e7fceebd0330c4b","user":{"login":"andschwa","id":2226434,"avatar_url":"https://avatars.githubusercontent.com/u/2226434?v=3","gravatar_id":"","url":"https://api.github.com/users/andschwa","html_url":"https://github.com/andschwa","followers_url":"https://api.github.com/users/andschwa/followers","following_url":"https://api.github.com/users/andschwa/following{/other_user}","gists_url":"https://api.github.com/users/andschwa/gists{/gist_id}","starred_url":"https://api.github.com/users/andschwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andschwa/subscriptions","organizations_url":"https://api.github.com/users/andschwa/orgs","repos_url":"https://api.github.com/users/andschwa/repos","events_url":"https://api.github.com/users/andschwa/events{/privacy}","received_events_url":"https://api.github.com/users/andschwa/received_events","type":"User","site_admin":false},"body":"LGTM","created_at":"2016-08-23T17:50:37Z","updated_at":"2016-08-23T17:50:37Z","html_url":"https://github.com/PowerShell/PowerShell/pull/2036#discussion_r75917192","pull_request_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/2036","_links":{"self":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments/75917192"},"html":{"href":"https://github.com/PowerShell/PowerShell/pull/2036#discussion_r75917192"},"pull_request":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/2036"}}},"pull_request":{"url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/2036","id":82407540,"html_url":"https://github.com/PowerShell/PowerShell/pull/2036","diff_url":"https://github.com/PowerShell/PowerShell/pull/2036.diff","patch_url":"https://github.com/PowerShell/PowerShell/pull/2036.patch","issue_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/2036","number":2036,"state":"open","locked":false,"title":"Fixing the path to the user's JSON configuration file","user":{"login":"mirichmo","id":12738734,"avatar_url":"https://avatars.githubusercontent.com/u/12738734?v=3","gravatar_id":"","url":"https://api.github.com/users/mirichmo","html_url":"https://github.com/mirichmo","followers_url":"https://api.github.com/users/mirichmo/followers","following_url":"https://api.github.com/users/mirichmo/following{/other_user}","gists_url":"https://api.github.com/users/mirichmo/gists{/gist_id}","starred_url":"https://api.github.com/users/mirichmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirichmo/subscriptions","organizations_url":"https://api.github.com/users/mirichmo/orgs","repos_url":"https://api.github.com/users/mirichmo/repos","events_url":"https://api.github.com/users/mirichmo/events{/privacy}","received_events_url":"https://api.github.com/users/mirichmo/received_events","type":"User","site_admin":false},"body":"This PR fixes the confusion caused by the camel cased \"PowerShell\" in the user's configuration directory. It now uses the same directory where the user's profile is stored.\r\nI added additional test coverage to verify that the JSON config file in that directory properly handles IO.\r\n\r\nThis resolves issue #1823","created_at":"2016-08-23T17:31:15Z","updated_at":"2016-08-23T17:50:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84135d13c474f193f1cead5cf72e789f1eb27990","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/2036/commits","review_comments_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/2036/comments","review_comment_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/2036/comments","statuses_url":"https://api.github.com/repos/PowerShell/PowerShell/statuses/606148ff19fc82cb1f8bd4d99e7fceebd0330c4b","head":{"label":"mirichmo:mirichmo/fixing-user-config-path","ref":"mirichmo/fixing-user-config-path","sha":"606148ff19fc82cb1f8bd4d99e7fceebd0330c4b","user":{"login":"mirichmo","id":12738734,"avatar_url":"https://avatars.githubusercontent.com/u/12738734?v=3","gravatar_id":"","url":"https://api.github.com/users/mirichmo","html_url":"https://github.com/mirichmo","followers_url":"https://api.github.com/users/mirichmo/followers","following_url":"https://api.github.com/users/mirichmo/following{/other_user}","gists_url":"https://api.github.com/users/mirichmo/gists{/gist_id}","starred_url":"https://api.github.com/users/mirichmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirichmo/subscriptions","organizations_url":"https://api.github.com/users/mirichmo/orgs","repos_url":"https://api.github.com/users/mirichmo/repos","events_url":"https://api.github.com/users/mirichmo/events{/privacy}","received_events_url":"https://api.github.com/users/mirichmo/received_events","type":"User","site_admin":false},"repo":{"id":66016866,"name":"PowerShell","full_name":"mirichmo/PowerShell","owner":{"login":"mirichmo","id":12738734,"avatar_url":"https://avatars.githubusercontent.com/u/12738734?v=3","gravatar_id":"","url":"https://api.github.com/users/mirichmo","html_url":"https://github.com/mirichmo","followers_url":"https://api.github.com/users/mirichmo/followers","following_url":"https://api.github.com/users/mirichmo/following{/other_user}","gists_url":"https://api.github.com/users/mirichmo/gists{/gist_id}","starred_url":"https://api.github.com/users/mirichmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirichmo/subscriptions","organizations_url":"https://api.github.com/users/mirichmo/orgs","repos_url":"https://api.github.com/users/mirichmo/repos","events_url":"https://api.github.com/users/mirichmo/events{/privacy}","received_events_url":"https://api.github.com/users/mirichmo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mirichmo/PowerShell","description":"PowerShell on Linux using dotnet-cli","fork":true,"url":"https://api.github.com/repos/mirichmo/PowerShell","forks_url":"https://api.github.com/repos/mirichmo/PowerShell/forks","keys_url":"https://api.github.com/repos/mirichmo/PowerShell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mirichmo/PowerShell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mirichmo/PowerShell/teams","hooks_url":"https://api.github.com/repos/mirichmo/PowerShell/hooks","issue_events_url":"https://api.github.com/repos/mirichmo/PowerShell/issues/events{/number}","events_url":"https://api.github.com/repos/mirichmo/PowerShell/events","assignees_url":"https://api.github.com/repos/mirichmo/PowerShell/assignees{/user}","branches_url":"https://api.github.com/repos/mirichmo/PowerShell/branches{/branch}","tags_url":"https://api.github.com/repos/mirichmo/PowerShell/tags","blobs_url":"https://api.github.com/repos/mirichmo/PowerShell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mirichmo/PowerShell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mirichmo/PowerShell/git/refs{/sha}","trees_url":"https://api.github.com/repos/mirichmo/PowerShell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mirichmo/PowerShell/statuses/{sha}","languages_url":"https://api.github.com/repos/mirichmo/PowerShell/languages","stargazers_url":"https://api.github.com/repos/mirichmo/PowerShell/stargazers","contributors_url":"https://api.github.com/repos/mirichmo/PowerShell/contributors","subscribers_url":"https://api.github.com/repos/mirichmo/PowerShell/subscribers","subscription_url":"https://api.github.com/repos/mirichmo/PowerShell/subscription","commits_url":"https://api.github.com/repos/mirichmo/PowerShell/commits{/sha}","git_commits_url":"https://api.github.com/repos/mirichmo/PowerShell/git/commits{/sha}","comments_url":"https://api.github.com/repos/mirichmo/PowerShell/comments{/number}","issue_comment_url":"https://api.github.com/repos/mirichmo/PowerShell/issues/comments{/number}","contents_url":"https://api.github.com/repos/mirichmo/PowerShell/contents/{+path}","compare_url":"https://api.github.com/repos/mirichmo/PowerShell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mirichmo/PowerShell/merges","archive_url":"https://api.github.com/repos/mirichmo/PowerShell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mirichmo/PowerShell/downloads","issues_url":"https://api.github.com/repos/mirichmo/PowerShell/issues{/number}","pulls_url":"https://api.github.com/repos/mirichmo/PowerShell/pulls{/number}","milestones_url":"https://api.github.com/repos/mirichmo/PowerShell/milestones{/number}","notifications_url":"https://api.github.com/repos/mirichmo/PowerShell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mirichmo/PowerShell/labels{/name}","releases_url":"https://api.github.com/repos/mirichmo/PowerShell/releases{/id}","deployments_url":"https://api.github.com/repos/mirichmo/PowerShell/deployments","created_at":"2016-08-18T17:21:36Z","updated_at":"2016-08-18T17:21:45Z","pushed_at":"2016-08-23T17:23:30Z","git_url":"git://github.com/mirichmo/PowerShell.git","ssh_url":"git@github.com:mirichmo/PowerShell.git","clone_url":"https://github.com/mirichmo/PowerShell.git","svn_url":"https://github.com/mirichmo/PowerShell","homepage":"","size":16632,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PowerShell:master","ref":"master","sha":"e6148ed67718e931a5a0b2891d0e6bd5b0b903d1","user":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars.githubusercontent.com/u/11524380?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"repo":{"id":49609581,"name":"PowerShell","full_name":"PowerShell/PowerShell","owner":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars.githubusercontent.com/u/11524380?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PowerShell/PowerShell","description":"PowerShell for every system!","fork":false,"url":"https://api.github.com/repos/PowerShell/PowerShell","forks_url":"https://api.github.com/repos/PowerShell/PowerShell/forks","keys_url":"https://api.github.com/repos/PowerShell/PowerShell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerShell/PowerShell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerShell/PowerShell/teams","hooks_url":"https://api.github.com/repos/PowerShell/PowerShell/hooks","issue_events_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/events{/number}","events_url":"https://api.github.com/repos/PowerShell/PowerShell/events","assignees_url":"https://api.github.com/repos/PowerShell/PowerShell/assignees{/user}","branches_url":"https://api.github.com/repos/PowerShell/PowerShell/branches{/branch}","tags_url":"https://api.github.com/repos/PowerShell/PowerShell/tags","blobs_url":"https://api.github.com/repos/PowerShell/PowerShell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerShell/PowerShell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerShell/PowerShell/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerShell/PowerShell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerShell/PowerShell/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerShell/PowerShell/languages","stargazers_url":"https://api.github.com/repos/PowerShell/PowerShell/stargazers","contributors_url":"https://api.github.com/repos/PowerShell/PowerShell/contributors","subscribers_url":"https://api.github.com/repos/PowerShell/PowerShell/subscribers","subscription_url":"https://api.github.com/repos/PowerShell/PowerShell/subscription","commits_url":"https://api.github.com/repos/PowerShell/PowerShell/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerShell/PowerShell/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerShell/PowerShell/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerShell/PowerShell/contents/{+path}","compare_url":"https://api.github.com/repos/PowerShell/PowerShell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerShell/PowerShell/merges","archive_url":"https://api.github.com/repos/PowerShell/PowerShell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerShell/PowerShell/downloads","issues_url":"https://api.github.com/repos/PowerShell/PowerShell/issues{/number}","pulls_url":"https://api.github.com/repos/PowerShell/PowerShell/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerShell/PowerShell/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerShell/PowerShell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerShell/PowerShell/labels{/name}","releases_url":"https://api.github.com/repos/PowerShell/PowerShell/releases{/id}","deployments_url":"https://api.github.com/repos/PowerShell/PowerShell/deployments","created_at":"2016-01-13T23:41:35Z","updated_at":"2016-08-23T17:48:08Z","pushed_at":"2016-08-23T17:38:25Z","git_url":"git://github.com/PowerShell/PowerShell.git","ssh_url":"git@github.com:PowerShell/PowerShell.git","clone_url":"https://github.com/PowerShell/PowerShell.git","svn_url":"https://github.com/PowerShell/PowerShell","homepage":"https://microsoft.com/powershell","size":22292,"stargazers_count":4323,"watchers_count":4323,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":393,"mirror_url":null,"open_issues_count":339,"forks":393,"open_issues":339,"watchers":4323,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/2036"},"html":{"href":"https://github.com/PowerShell/PowerShell/pull/2036"},"issue":{"href":"https://api.github.com/repos/PowerShell/PowerShell/issues/2036"},"comments":{"href":"https://api.github.com/repos/PowerShell/PowerShell/issues/2036/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/2036/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerShell/PowerShell/pulls/2036/commits"},"statuses":{"href":"https://api.github.com/repos/PowerShell/PowerShell/statuses/606148ff19fc82cb1f8bd4d99e7fceebd0330c4b"}}}}
{"actor":{"display_login":"andschwa"}}