{"action":"created","issue":{"url":"https://api.github.com/repos/OneDrive/onedrive-sdk-python/issues/83","repository_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-python","labels_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-python/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-python/issues/83/comments","events_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-python/issues/83/events","html_url":"https://github.com/OneDrive/onedrive-sdk-python/issues/83","id":189566739,"number":83,"title":"Upload sockets left open with FIN_WAIT","user":{"login":"ybizeul","id":182035,"avatar_url":"https://avatars.githubusercontent.com/u/182035?v=3","gravatar_id":"","url":"https://api.github.com/users/ybizeul","html_url":"https://github.com/ybizeul","followers_url":"https://api.github.com/users/ybizeul/followers","following_url":"https://api.github.com/users/ybizeul/following{/other_user}","gists_url":"https://api.github.com/users/ybizeul/gists{/gist_id}","starred_url":"https://api.github.com/users/ybizeul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ybizeul/subscriptions","organizations_url":"https://api.github.com/users/ybizeul/orgs","repos_url":"https://api.github.com/users/ybizeul/repos","events_url":"https://api.github.com/users/ybizeul/events{/privacy}","received_events_url":"https://api.github.com/users/ybizeul/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-16T02:37:41Z","updated_at":"2016-12-02T08:18:56Z","closed_at":null,"body":"Looking at sockets used by the big file upload I noticed sockets left open in `FinWait2` state.\r\n\r\nEvery single socket used to upload the 10m pieces. After some research, I saw this documentation :\r\n\r\nhttps://kb.iu.edu/d/ajmi\r\n\r\nIs it possible onedrive-sdk-python code doesn't cleanly close the socket?\r\n\r\n```\r\n[...]\r\n   tcp4 10.0.1.136:58718<->a-0011.a-msedge.net:443                                          en0      FinWait2        6026 B            10 MiB     0 B       0 B\r\n   tcp4 10.0.1.136:58727<->a-0011.a-msedge.net:443                                          en0      FinWait2        6026 B            10 MiB     0 B       0 B\r\n   tcp4 10.0.1.136:58739<->a-0011.a-msedge.net:443                                          en0      FinWait2        6026 B            10 MiB     0 B       0 B\r\n```"},"comment":{"url":"https://api.github.com/repos/OneDrive/onedrive-sdk-python/issues/comments/264398576","html_url":"https://github.com/OneDrive/onedrive-sdk-python/issues/83#issuecomment-264398576","issue_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-python/issues/83","id":264398576,"user":{"login":"D4N14L","id":3473356,"avatar_url":"https://avatars.githubusercontent.com/u/3473356?v=3","gravatar_id":"","url":"https://api.github.com/users/D4N14L","html_url":"https://github.com/D4N14L","followers_url":"https://api.github.com/users/D4N14L/followers","following_url":"https://api.github.com/users/D4N14L/following{/other_user}","gists_url":"https://api.github.com/users/D4N14L/gists{/gist_id}","starred_url":"https://api.github.com/users/D4N14L/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D4N14L/subscriptions","organizations_url":"https://api.github.com/users/D4N14L/orgs","repos_url":"https://api.github.com/users/D4N14L/repos","events_url":"https://api.github.com/users/D4N14L/events{/privacy}","received_events_url":"https://api.github.com/users/D4N14L/received_events","type":"User","site_admin":false},"created_at":"2016-12-02T08:18:56Z","updated_at":"2016-12-02T08:18:56Z","body":"The SDK code uses the requests library to accomplish the task of posting the slices in the fragment_upload_async method. The only time I can think of this happening is when there is an error in the connection and the socket wasn't closed properly, however you seem to be indicating that this occurs on each session? If I could get more info from you on that, it would really help. Thanks!"}}
{"actor":{"display_login":"D4N14L"}}