{"comment":{"url":"https://api.github.com/repos/jruby/jruby/comments/16741031","html_url":"https://github.com/jruby/jruby/commit/d1c95c2d96e7214942e3e7a1d7f63f445eec6816#commitcomment-16741031","id":16741031,"user":{"login":"nirvdrum","id":12584,"avatar_url":"https://avatars.githubusercontent.com/u/12584?v=3","gravatar_id":"","url":"https://api.github.com/users/nirvdrum","html_url":"https://github.com/nirvdrum","followers_url":"https://api.github.com/users/nirvdrum/followers","following_url":"https://api.github.com/users/nirvdrum/following{/other_user}","gists_url":"https://api.github.com/users/nirvdrum/gists{/gist_id}","starred_url":"https://api.github.com/users/nirvdrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirvdrum/subscriptions","organizations_url":"https://api.github.com/users/nirvdrum/orgs","repos_url":"https://api.github.com/users/nirvdrum/repos","events_url":"https://api.github.com/users/nirvdrum/events{/privacy}","received_events_url":"https://api.github.com/users/nirvdrum/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"d1c95c2d96e7214942e3e7a1d7f63f445eec6816","created_at":"2016-03-17T05:42:57Z","updated_at":"2016-03-17T05:42:57Z","body":"Looks good. Since you're expanding the use of the rope table, we should really fix the disappearing key problem. Just to recap, the keys in the rope table aren't retained anywhere else and since everything is a weak reference, values could be expunged from the table even if they're being held."}}