{"action":"created","comment":{"url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments/87296807","pull_request_review_id":7913451,"id":87296807,"diff_hunk":"@@ -249,3 +278,81 @@ func TestSimpleRoundTrip(t *testing.T) {\n \t\t}\n \t}\n }\n+\n+func TestSimpleRoundTripOneway(t *testing.T) {\n+\ttrans := httpTransport{t}\n+\n+\ttests := []struct {\n+\t\tname           string\n+\t\trequestHeaders transport.Headers\n+\t\trequestBody    string\n+\t}{\n+\t\t{\n+\t\t\tname:           \"hello world\",\n+\t\t\trequestHeaders: transport.NewHeaders().With(\"foo\", \"bar\"),\n+\t\t\trequestBody:    \"hello world\",\n+\t\t},\n+\t\t{\n+\t\t\tname:           \"empty\",\n+\t\t\trequestHeaders: transport.NewHeaders(),\n+\t\t\trequestBody:    \"\",\n+\t\t},\n+\t}\n+\n+\trootCtx := context.Background()\n+\n+\tfor _, tt := range tests {\n+\t\tt.Run(tt.name, func(t *testing.T) {\n+\n+\t\t\trequestMatcher := transporttest.NewRequestMatcher(t, &transport.Request{\n+\t\t\t\tCaller:    testCaller,\n+\t\t\t\tService:   testService,\n+\t\t\t\tProcedure: testProcedureOneway,\n+\t\t\t\tEncoding:  raw.Encoding,\n+\t\t\t\tHeaders:   tt.requestHeaders,\n+\t\t\t\tBody:      bytes.NewReader([]byte(tt.requestBody)),\n+\t\t\t})\n+\n+\t\t\thandlerDone := make(chan struct{})\n+\n+\t\t\tonewayHandler := onewayHandlerFunc(func(_ context.Context, r *transport.Request) error {\n+\t\t\t\tassert.True(t, requestMatcher.Matches(r), \"request mismatch: received %v\", r)\n+\n+\t\t\t\t// Pretend to work: this delay should not slow down tests since it is a\n+\t\t\t\t// server-side operation","path":"transport/roundtrip_test.go","position":116,"original_position":116,"commit_id":"e6bd2907e5c0637740053c7051588fc2d56bcef8","original_commit_id":"e6bd2907e5c0637740053c7051588fc2d56bcef8","user":{"login":"abhinav","id":41730,"avatar_url":"https://avatars.githubusercontent.com/u/41730?v=3","gravatar_id":"","url":"https://api.github.com/users/abhinav","html_url":"https://github.com/abhinav","followers_url":"https://api.github.com/users/abhinav/followers","following_url":"https://api.github.com/users/abhinav/following{/other_user}","gists_url":"https://api.github.com/users/abhinav/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinav/subscriptions","organizations_url":"https://api.github.com/users/abhinav/orgs","repos_url":"https://api.github.com/users/abhinav/repos","events_url":"https://api.github.com/users/abhinav/events{/privacy}","received_events_url":"https://api.github.com/users/abhinav/received_events","type":"User","site_admin":false},"body":"You probably meant \"client-side operation\"?","created_at":"2016-11-09T23:01:34Z","updated_at":"2016-11-09T23:05:37Z","html_url":"https://github.com/yarpc/yarpc-go/pull/412#discussion_r87296807","pull_request_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/412","_links":{"self":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments/87296807"},"html":{"href":"https://github.com/yarpc/yarpc-go/pull/412#discussion_r87296807"},"pull_request":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/412"}}},"pull_request":{"url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/412","id":92439390,"html_url":"https://github.com/yarpc/yarpc-go/pull/412","diff_url":"https://github.com/yarpc/yarpc-go/pull/412.diff","patch_url":"https://github.com/yarpc/yarpc-go/pull/412.patch","issue_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/412","number":412,"state":"open","locked":false,"title":"[Oneway][Part 6] Encoding layers and http use CallOneway","user":{"login":"AlexAPB","id":3745201,"avatar_url":"https://avatars.githubusercontent.com/u/3745201?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexAPB","html_url":"https://github.com/AlexAPB","followers_url":"https://api.github.com/users/AlexAPB/followers","following_url":"https://api.github.com/users/AlexAPB/following{/other_user}","gists_url":"https://api.github.com/users/AlexAPB/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexAPB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexAPB/subscriptions","organizations_url":"https://api.github.com/users/AlexAPB/orgs","repos_url":"https://api.github.com/users/AlexAPB/repos","events_url":"https://api.github.com/users/AlexAPB/events{/privacy}","received_events_url":"https://api.github.com/users/AlexAPB/received_events","type":"User","site_admin":false},"body":" All encoding layers implement CallOneway, which in turn call CallOneway on the appropriate OnewayOutbound given by the channel. Thrift code generation template now supports oneway calls. Additionally, a roundtrip test is added using HTTP.","created_at":"2016-11-05T02:31:33Z","updated_at":"2016-11-09T23:05:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2eb098112530c243f3984319c809e25cce3d493c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/412/commits","review_comments_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/412/comments","review_comment_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/412/comments","statuses_url":"https://api.github.com/repos/yarpc/yarpc-go/statuses/e6bd2907e5c0637740053c7051588fc2d56bcef8","head":{"label":"yarpc:oneway-6-call","ref":"oneway-6-call","sha":"e6bd2907e5c0637740053c7051588fc2d56bcef8","user":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"repo":{"id":50390111,"name":"yarpc-go","full_name":"yarpc/yarpc-go","owner":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarpc/yarpc-go","description":"YARPC for Golang","fork":false,"url":"https://api.github.com/repos/yarpc/yarpc-go","forks_url":"https://api.github.com/repos/yarpc/yarpc-go/forks","keys_url":"https://api.github.com/repos/yarpc/yarpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarpc/yarpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarpc/yarpc-go/teams","hooks_url":"https://api.github.com/repos/yarpc/yarpc-go/hooks","issue_events_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/yarpc/yarpc-go/events","assignees_url":"https://api.github.com/repos/yarpc/yarpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/yarpc/yarpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/yarpc/yarpc-go/tags","blobs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarpc/yarpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarpc/yarpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarpc/yarpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/yarpc/yarpc-go/languages","stargazers_url":"https://api.github.com/repos/yarpc/yarpc-go/stargazers","contributors_url":"https://api.github.com/repos/yarpc/yarpc-go/contributors","subscribers_url":"https://api.github.com/repos/yarpc/yarpc-go/subscribers","subscription_url":"https://api.github.com/repos/yarpc/yarpc-go/subscription","commits_url":"https://api.github.com/repos/yarpc/yarpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarpc/yarpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarpc/yarpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarpc/yarpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/yarpc/yarpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarpc/yarpc-go/merges","archive_url":"https://api.github.com/repos/yarpc/yarpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarpc/yarpc-go/downloads","issues_url":"https://api.github.com/repos/yarpc/yarpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/yarpc/yarpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/yarpc/yarpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarpc/yarpc-go/labels{/name}","releases_url":"https://api.github.com/repos/yarpc/yarpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/yarpc/yarpc-go/deployments","created_at":"2016-01-26T00:04:14Z","updated_at":"2016-11-05T06:10:44Z","pushed_at":"2016-11-09T21:34:42Z","git_url":"git://github.com/yarpc/yarpc-go.git","ssh_url":"git@github.com:yarpc/yarpc-go.git","clone_url":"https://github.com/yarpc/yarpc-go.git","svn_url":"https://github.com/yarpc/yarpc-go","homepage":"","size":7559,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":59,"forks":1,"open_issues":59,"watchers":8,"default_branch":"dev"}},"base":{"label":"yarpc:oneway-5-validate","ref":"oneway-5-validate","sha":"c76dd942bb0ac0498a7ac7db763d92c07e9e4652","user":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"repo":{"id":50390111,"name":"yarpc-go","full_name":"yarpc/yarpc-go","owner":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarpc/yarpc-go","description":"YARPC for Golang","fork":false,"url":"https://api.github.com/repos/yarpc/yarpc-go","forks_url":"https://api.github.com/repos/yarpc/yarpc-go/forks","keys_url":"https://api.github.com/repos/yarpc/yarpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarpc/yarpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarpc/yarpc-go/teams","hooks_url":"https://api.github.com/repos/yarpc/yarpc-go/hooks","issue_events_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/yarpc/yarpc-go/events","assignees_url":"https://api.github.com/repos/yarpc/yarpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/yarpc/yarpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/yarpc/yarpc-go/tags","blobs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarpc/yarpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarpc/yarpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarpc/yarpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/yarpc/yarpc-go/languages","stargazers_url":"https://api.github.com/repos/yarpc/yarpc-go/stargazers","contributors_url":"https://api.github.com/repos/yarpc/yarpc-go/contributors","subscribers_url":"https://api.github.com/repos/yarpc/yarpc-go/subscribers","subscription_url":"https://api.github.com/repos/yarpc/yarpc-go/subscription","commits_url":"https://api.github.com/repos/yarpc/yarpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarpc/yarpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarpc/yarpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarpc/yarpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/yarpc/yarpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarpc/yarpc-go/merges","archive_url":"https://api.github.com/repos/yarpc/yarpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarpc/yarpc-go/downloads","issues_url":"https://api.github.com/repos/yarpc/yarpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/yarpc/yarpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/yarpc/yarpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarpc/yarpc-go/labels{/name}","releases_url":"https://api.github.com/repos/yarpc/yarpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/yarpc/yarpc-go/deployments","created_at":"2016-01-26T00:04:14Z","updated_at":"2016-11-05T06:10:44Z","pushed_at":"2016-11-09T21:34:42Z","git_url":"git://github.com/yarpc/yarpc-go.git","ssh_url":"git@github.com:yarpc/yarpc-go.git","clone_url":"https://github.com/yarpc/yarpc-go.git","svn_url":"https://github.com/yarpc/yarpc-go","homepage":"","size":7559,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":59,"forks":1,"open_issues":59,"watchers":8,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/412"},"html":{"href":"https://github.com/yarpc/yarpc-go/pull/412"},"issue":{"href":"https://api.github.com/repos/yarpc/yarpc-go/issues/412"},"comments":{"href":"https://api.github.com/repos/yarpc/yarpc-go/issues/412/comments"},"review_comments":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/412/comments"},"review_comment":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/412/commits"},"statuses":{"href":"https://api.github.com/repos/yarpc/yarpc-go/statuses/e6bd2907e5c0637740053c7051588fc2d56bcef8"}}}}
{"actor":{"display_login":"abhinav"}}