{"action":"created","comment":{"url":"https://api.github.com/repos/Comcast/traffic_control/pulls/comments/83134394","pull_request_review_id":3995158,"id":83134394,"diff_hunk":"@@ -147,9 +147,9 @@ sub get_example_urls {\n \t\t\t\t\t? $example_urls[ $re->{set_number} ]\n \t\t\t\t\t: \"\";\n \t\t\t\tif ( $re->{set_number} == 0 ) {\n-\t\t\t\t\t$example_urls[ $re->{set_number} ] = $scheme . '://ccr.' . $host . \".\" . $cdn_domain . $p;\n+\t\t\t\t\t$example_urls[ $re->{set_number} ] = $scheme . '://tr.' . $host . \".\" . $cdn_domain . $p;","path":"traffic_ops/app/lib/UI/DeliveryService.pm","position":5,"original_position":5,"commit_id":"66920166dfd4fb6f96a1d9c3cb71047ef4820407","original_commit_id":"66920166dfd4fb6f96a1d9c3cb71047ef4820407","user":{"login":"mitchell852","id":251272,"avatar_url":"https://avatars.githubusercontent.com/u/251272?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchell852","html_url":"https://github.com/mitchell852","followers_url":"https://api.github.com/users/mitchell852/followers","following_url":"https://api.github.com/users/mitchell852/following{/other_user}","gists_url":"https://api.github.com/users/mitchell852/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchell852/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchell852/subscriptions","organizations_url":"https://api.github.com/users/mitchell852/orgs","repos_url":"https://api.github.com/users/mitchell852/repos","events_url":"https://api.github.com/users/mitchell852/events{/privacy}","received_events_url":"https://api.github.com/users/mitchell852/received_events","type":"User","site_admin":false},"body":"the only problem is that these \"example\" urls are exposed thru the traffic ops API which means they show up in the traffic portal - https://github.com/Comcast/traffic_control/blob/master/traffic_ops/app/lib/API/DeliveryService.pm#L80 \r\n\r\nso if you have http.routing.name=foo in applicationContext.xml, the example urls will still show as tr.ds-name.example.domain.com rather than the correct url of foo.ds-name.example.domain.com\r\n\r\n","created_at":"2016-10-13T02:16:40Z","updated_at":"2016-10-13T02:16:41Z","html_url":"https://github.com/Comcast/traffic_control/pull/2002#discussion_r83134394","pull_request_url":"https://api.github.com/repos/Comcast/traffic_control/pulls/2002","_links":{"self":{"href":"https://api.github.com/repos/Comcast/traffic_control/pulls/comments/83134394"},"html":{"href":"https://github.com/Comcast/traffic_control/pull/2002#discussion_r83134394"},"pull_request":{"href":"https://api.github.com/repos/Comcast/traffic_control/pulls/2002"}}},"pull_request":{"url":"https://api.github.com/repos/Comcast/traffic_control/pulls/2002","id":88886050,"html_url":"https://github.com/Comcast/traffic_control/pull/2002","diff_url":"https://github.com/Comcast/traffic_control/pull/2002.diff","patch_url":"https://github.com/Comcast/traffic_control/pull/2002.patch","issue_url":"https://api.github.com/repos/Comcast/traffic_control/issues/2002","number":2002,"state":"open","locked":false,"title":"Changed ccr. to tr. for Example Delivery Service URLs","user":{"login":"sandmanahoy","id":13696609,"avatar_url":"https://avatars.githubusercontent.com/u/13696609?v=3","gravatar_id":"","url":"https://api.github.com/users/sandmanahoy","html_url":"https://github.com/sandmanahoy","followers_url":"https://api.github.com/users/sandmanahoy/followers","following_url":"https://api.github.com/users/sandmanahoy/following{/other_user}","gists_url":"https://api.github.com/users/sandmanahoy/gists{/gist_id}","starred_url":"https://api.github.com/users/sandmanahoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandmanahoy/subscriptions","organizations_url":"https://api.github.com/users/sandmanahoy/orgs","repos_url":"https://api.github.com/users/sandmanahoy/repos","events_url":"https://api.github.com/users/sandmanahoy/events{/privacy}","received_events_url":"https://api.github.com/users/sandmanahoy/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-11T18:33:26Z","updated_at":"2016-10-13T02:16:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e56f4438f22974344986647b7ba74808c0c2c6f3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Comcast/traffic_control/pulls/2002/commits","review_comments_url":"https://api.github.com/repos/Comcast/traffic_control/pulls/2002/comments","review_comment_url":"https://api.github.com/repos/Comcast/traffic_control/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Comcast/traffic_control/issues/2002/comments","statuses_url":"https://api.github.com/repos/Comcast/traffic_control/statuses/66920166dfd4fb6f96a1d9c3cb71047ef4820407","head":{"label":"sandmanahoy:master","ref":"master","sha":"66920166dfd4fb6f96a1d9c3cb71047ef4820407","user":{"login":"sandmanahoy","id":13696609,"avatar_url":"https://avatars.githubusercontent.com/u/13696609?v=3","gravatar_id":"","url":"https://api.github.com/users/sandmanahoy","html_url":"https://github.com/sandmanahoy","followers_url":"https://api.github.com/users/sandmanahoy/followers","following_url":"https://api.github.com/users/sandmanahoy/following{/other_user}","gists_url":"https://api.github.com/users/sandmanahoy/gists{/gist_id}","starred_url":"https://api.github.com/users/sandmanahoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandmanahoy/subscriptions","organizations_url":"https://api.github.com/users/sandmanahoy/orgs","repos_url":"https://api.github.com/users/sandmanahoy/repos","events_url":"https://api.github.com/users/sandmanahoy/events{/privacy}","received_events_url":"https://api.github.com/users/sandmanahoy/received_events","type":"User","site_admin":false},"repo":{"id":70623532,"name":"traffic_control","full_name":"sandmanahoy/traffic_control","owner":{"login":"sandmanahoy","id":13696609,"avatar_url":"https://avatars.githubusercontent.com/u/13696609?v=3","gravatar_id":"","url":"https://api.github.com/users/sandmanahoy","html_url":"https://github.com/sandmanahoy","followers_url":"https://api.github.com/users/sandmanahoy/followers","following_url":"https://api.github.com/users/sandmanahoy/following{/other_user}","gists_url":"https://api.github.com/users/sandmanahoy/gists{/gist_id}","starred_url":"https://api.github.com/users/sandmanahoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandmanahoy/subscriptions","organizations_url":"https://api.github.com/users/sandmanahoy/orgs","repos_url":"https://api.github.com/users/sandmanahoy/repos","events_url":"https://api.github.com/users/sandmanahoy/events{/privacy}","received_events_url":"https://api.github.com/users/sandmanahoy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sandmanahoy/traffic_control","description":"Traffic Control CDN","fork":true,"url":"https://api.github.com/repos/sandmanahoy/traffic_control","forks_url":"https://api.github.com/repos/sandmanahoy/traffic_control/forks","keys_url":"https://api.github.com/repos/sandmanahoy/traffic_control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sandmanahoy/traffic_control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sandmanahoy/traffic_control/teams","hooks_url":"https://api.github.com/repos/sandmanahoy/traffic_control/hooks","issue_events_url":"https://api.github.com/repos/sandmanahoy/traffic_control/issues/events{/number}","events_url":"https://api.github.com/repos/sandmanahoy/traffic_control/events","assignees_url":"https://api.github.com/repos/sandmanahoy/traffic_control/assignees{/user}","branches_url":"https://api.github.com/repos/sandmanahoy/traffic_control/branches{/branch}","tags_url":"https://api.github.com/repos/sandmanahoy/traffic_control/tags","blobs_url":"https://api.github.com/repos/sandmanahoy/traffic_control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sandmanahoy/traffic_control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sandmanahoy/traffic_control/git/refs{/sha}","trees_url":"https://api.github.com/repos/sandmanahoy/traffic_control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sandmanahoy/traffic_control/statuses/{sha}","languages_url":"https://api.github.com/repos/sandmanahoy/traffic_control/languages","stargazers_url":"https://api.github.com/repos/sandmanahoy/traffic_control/stargazers","contributors_url":"https://api.github.com/repos/sandmanahoy/traffic_control/contributors","subscribers_url":"https://api.github.com/repos/sandmanahoy/traffic_control/subscribers","subscription_url":"https://api.github.com/repos/sandmanahoy/traffic_control/subscription","commits_url":"https://api.github.com/repos/sandmanahoy/traffic_control/commits{/sha}","git_commits_url":"https://api.github.com/repos/sandmanahoy/traffic_control/git/commits{/sha}","comments_url":"https://api.github.com/repos/sandmanahoy/traffic_control/comments{/number}","issue_comment_url":"https://api.github.com/repos/sandmanahoy/traffic_control/issues/comments{/number}","contents_url":"https://api.github.com/repos/sandmanahoy/traffic_control/contents/{+path}","compare_url":"https://api.github.com/repos/sandmanahoy/traffic_control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sandmanahoy/traffic_control/merges","archive_url":"https://api.github.com/repos/sandmanahoy/traffic_control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sandmanahoy/traffic_control/downloads","issues_url":"https://api.github.com/repos/sandmanahoy/traffic_control/issues{/number}","pulls_url":"https://api.github.com/repos/sandmanahoy/traffic_control/pulls{/number}","milestones_url":"https://api.github.com/repos/sandmanahoy/traffic_control/milestones{/number}","notifications_url":"https://api.github.com/repos/sandmanahoy/traffic_control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sandmanahoy/traffic_control/labels{/name}","releases_url":"https://api.github.com/repos/sandmanahoy/traffic_control/releases{/id}","deployments_url":"https://api.github.com/repos/sandmanahoy/traffic_control/deployments","created_at":"2016-10-11T18:30:18Z","updated_at":"2016-10-11T18:30:25Z","pushed_at":"2016-10-11T18:33:10Z","git_url":"git://github.com/sandmanahoy/traffic_control.git","ssh_url":"git@github.com:sandmanahoy/traffic_control.git","clone_url":"https://github.com/sandmanahoy/traffic_control.git","svn_url":"https://github.com/sandmanahoy/traffic_control","homepage":"http://traffic-control-cdn.net","size":49217,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Comcast:master","ref":"master","sha":"857400e2fe03a814a3b17fd7babe9536eaaea565","user":{"login":"Comcast","id":709212,"avatar_url":"https://avatars.githubusercontent.com/u/709212?v=3","gravatar_id":"","url":"https://api.github.com/users/Comcast","html_url":"https://github.com/Comcast","followers_url":"https://api.github.com/users/Comcast/followers","following_url":"https://api.github.com/users/Comcast/following{/other_user}","gists_url":"https://api.github.com/users/Comcast/gists{/gist_id}","starred_url":"https://api.github.com/users/Comcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Comcast/subscriptions","organizations_url":"https://api.github.com/users/Comcast/orgs","repos_url":"https://api.github.com/users/Comcast/repos","events_url":"https://api.github.com/users/Comcast/events{/privacy}","received_events_url":"https://api.github.com/users/Comcast/received_events","type":"Organization","site_admin":false},"repo":{"id":30432982,"name":"traffic_control","full_name":"Comcast/traffic_control","owner":{"login":"Comcast","id":709212,"avatar_url":"https://avatars.githubusercontent.com/u/709212?v=3","gravatar_id":"","url":"https://api.github.com/users/Comcast","html_url":"https://github.com/Comcast","followers_url":"https://api.github.com/users/Comcast/followers","following_url":"https://api.github.com/users/Comcast/following{/other_user}","gists_url":"https://api.github.com/users/Comcast/gists{/gist_id}","starred_url":"https://api.github.com/users/Comcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Comcast/subscriptions","organizations_url":"https://api.github.com/users/Comcast/orgs","repos_url":"https://api.github.com/users/Comcast/repos","events_url":"https://api.github.com/users/Comcast/events{/privacy}","received_events_url":"https://api.github.com/users/Comcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Comcast/traffic_control","description":"Traffic Control CDN","fork":false,"url":"https://api.github.com/repos/Comcast/traffic_control","forks_url":"https://api.github.com/repos/Comcast/traffic_control/forks","keys_url":"https://api.github.com/repos/Comcast/traffic_control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Comcast/traffic_control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Comcast/traffic_control/teams","hooks_url":"https://api.github.com/repos/Comcast/traffic_control/hooks","issue_events_url":"https://api.github.com/repos/Comcast/traffic_control/issues/events{/number}","events_url":"https://api.github.com/repos/Comcast/traffic_control/events","assignees_url":"https://api.github.com/repos/Comcast/traffic_control/assignees{/user}","branches_url":"https://api.github.com/repos/Comcast/traffic_control/branches{/branch}","tags_url":"https://api.github.com/repos/Comcast/traffic_control/tags","blobs_url":"https://api.github.com/repos/Comcast/traffic_control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Comcast/traffic_control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Comcast/traffic_control/git/refs{/sha}","trees_url":"https://api.github.com/repos/Comcast/traffic_control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Comcast/traffic_control/statuses/{sha}","languages_url":"https://api.github.com/repos/Comcast/traffic_control/languages","stargazers_url":"https://api.github.com/repos/Comcast/traffic_control/stargazers","contributors_url":"https://api.github.com/repos/Comcast/traffic_control/contributors","subscribers_url":"https://api.github.com/repos/Comcast/traffic_control/subscribers","subscription_url":"https://api.github.com/repos/Comcast/traffic_control/subscription","commits_url":"https://api.github.com/repos/Comcast/traffic_control/commits{/sha}","git_commits_url":"https://api.github.com/repos/Comcast/traffic_control/git/commits{/sha}","comments_url":"https://api.github.com/repos/Comcast/traffic_control/comments{/number}","issue_comment_url":"https://api.github.com/repos/Comcast/traffic_control/issues/comments{/number}","contents_url":"https://api.github.com/repos/Comcast/traffic_control/contents/{+path}","compare_url":"https://api.github.com/repos/Comcast/traffic_control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Comcast/traffic_control/merges","archive_url":"https://api.github.com/repos/Comcast/traffic_control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Comcast/traffic_control/downloads","issues_url":"https://api.github.com/repos/Comcast/traffic_control/issues{/number}","pulls_url":"https://api.github.com/repos/Comcast/traffic_control/pulls{/number}","milestones_url":"https://api.github.com/repos/Comcast/traffic_control/milestones{/number}","notifications_url":"https://api.github.com/repos/Comcast/traffic_control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Comcast/traffic_control/labels{/name}","releases_url":"https://api.github.com/repos/Comcast/traffic_control/releases{/id}","deployments_url":"https://api.github.com/repos/Comcast/traffic_control/deployments","created_at":"2015-02-06T21:05:10Z","updated_at":"2016-10-07T20:05:47Z","pushed_at":"2016-10-12T22:07:24Z","git_url":"git://github.com/Comcast/traffic_control.git","ssh_url":"git@github.com:Comcast/traffic_control.git","clone_url":"https://github.com/Comcast/traffic_control.git","svn_url":"https://github.com/Comcast/traffic_control","homepage":"http://traffic-control-cdn.net","size":54393,"stargazers_count":92,"watchers_count":92,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":188,"forks":88,"open_issues":188,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Comcast/traffic_control/pulls/2002"},"html":{"href":"https://github.com/Comcast/traffic_control/pull/2002"},"issue":{"href":"https://api.github.com/repos/Comcast/traffic_control/issues/2002"},"comments":{"href":"https://api.github.com/repos/Comcast/traffic_control/issues/2002/comments"},"review_comments":{"href":"https://api.github.com/repos/Comcast/traffic_control/pulls/2002/comments"},"review_comment":{"href":"https://api.github.com/repos/Comcast/traffic_control/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Comcast/traffic_control/pulls/2002/commits"},"statuses":{"href":"https://api.github.com/repos/Comcast/traffic_control/statuses/66920166dfd4fb6f96a1d9c3cb71047ef4820407"}}}}
{"actor":{"display_login":"mitchell852"}}