{"action":"created","issue":{"url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/issues/207","repository_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui","labels_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/issues/207/labels{/name}","comments_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/issues/207/comments","events_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/issues/207/events","html_url":"https://github.com/Brightspace/d2l-navigation-ui/pull/207","id":186870629,"number":207,"title":"Hoping to fix More chomper sometimes not working either in Chrome in …","user":{"login":"capajon","id":5125171,"avatar_url":"https://avatars.githubusercontent.com/u/5125171?v=3","gravatar_id":"","url":"https://api.github.com/users/capajon","html_url":"https://github.com/capajon","followers_url":"https://api.github.com/users/capajon/followers","following_url":"https://api.github.com/users/capajon/following{/other_user}","gists_url":"https://api.github.com/users/capajon/gists{/gist_id}","starred_url":"https://api.github.com/users/capajon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capajon/subscriptions","organizations_url":"https://api.github.com/users/capajon/orgs","repos_url":"https://api.github.com/users/capajon/repos","events_url":"https://api.github.com/users/capajon/events{/privacy}","received_events_url":"https://api.github.com/users/capajon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"dlockhart","id":5491151,"avatar_url":"https://avatars.githubusercontent.com/u/5491151?v=3","gravatar_id":"","url":"https://api.github.com/users/dlockhart","html_url":"https://github.com/dlockhart","followers_url":"https://api.github.com/users/dlockhart/followers","following_url":"https://api.github.com/users/dlockhart/following{/other_user}","gists_url":"https://api.github.com/users/dlockhart/gists{/gist_id}","starred_url":"https://api.github.com/users/dlockhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlockhart/subscriptions","organizations_url":"https://api.github.com/users/dlockhart/orgs","repos_url":"https://api.github.com/users/dlockhart/repos","events_url":"https://api.github.com/users/dlockhart/events{/privacy}","received_events_url":"https://api.github.com/users/dlockhart/received_events","type":"User","site_admin":false},"assignees":[{"login":"dlockhart","id":5491151,"avatar_url":"https://avatars.githubusercontent.com/u/5491151?v=3","gravatar_id":"","url":"https://api.github.com/users/dlockhart","html_url":"https://github.com/dlockhart","followers_url":"https://api.github.com/users/dlockhart/followers","following_url":"https://api.github.com/users/dlockhart/following{/other_user}","gists_url":"https://api.github.com/users/dlockhart/gists{/gist_id}","starred_url":"https://api.github.com/users/dlockhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlockhart/subscriptions","organizations_url":"https://api.github.com/users/dlockhart/orgs","repos_url":"https://api.github.com/users/dlockhart/repos","events_url":"https://api.github.com/users/dlockhart/events{/privacy}","received_events_url":"https://api.github.com/users/dlockhart/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-11-02T17:39:53Z","updated_at":"2016-11-02T18:26:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/pulls/207","html_url":"https://github.com/Brightspace/d2l-navigation-ui/pull/207","diff_url":"https://github.com/Brightspace/d2l-navigation-ui/pull/207.diff","patch_url":"https://github.com/Brightspace/d2l-navigation-ui/pull/207.patch"},"body":"…IOS and/or faster PCs\r\n\r\nSo this is the best I could come up with for now.... not very satisfied with it though.\r\n\r\n- Right now the first chomp is triggered on a dom update\r\n- This triggers twice, once when the nav is empty, and a second time after the API comes back essentially\r\n- Inside the dom change handler - inside an async block, it queries the dom for nav items and does its chompiness on them\r\n- My theory is that the handlers are firing exceptionally close together and the query is coming back with something not really \"ready\" the first time through, and then erroring out.  I'm not really sure though. :) \r\n\r\nTwo main changes:\r\n- I check for the # of items (in the property) so that hopefully we only try to chomp on the second dom update event (ie when there are actually items present)\r\n- I increased a timeout from 20 to 100.  This might also help.\r\n\r\nA word about that timeout:\r\n- It's a really smelly part of the code that I'm not happy or proud of, but I'm yet to come up with a very good alternative given the nature of the problem to solve, that isn't very complicated in code.  But I am thinking about it.\r\n- Even with some extreme throttling in place on my browser, I see absolutely no difference increasing it to 100 from 20.  Even at 300 I couldn't see any flicker effect, actually.\r\n\r\nSo while I am still thinking about better approaches I think these changes do not make anything worse, and have a pretty good chance of solving the problem for now."},"comment":{"url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/issues/comments/257956215","html_url":"https://github.com/Brightspace/d2l-navigation-ui/pull/207#issuecomment-257956215","issue_url":"https://api.github.com/repos/Brightspace/d2l-navigation-ui/issues/207","id":257956215,"user":{"login":"dlockhart","id":5491151,"avatar_url":"https://avatars.githubusercontent.com/u/5491151?v=3","gravatar_id":"","url":"https://api.github.com/users/dlockhart","html_url":"https://github.com/dlockhart","followers_url":"https://api.github.com/users/dlockhart/followers","following_url":"https://api.github.com/users/dlockhart/following{/other_user}","gists_url":"https://api.github.com/users/dlockhart/gists{/gist_id}","starred_url":"https://api.github.com/users/dlockhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlockhart/subscriptions","organizations_url":"https://api.github.com/users/dlockhart/orgs","repos_url":"https://api.github.com/users/dlockhart/repos","events_url":"https://api.github.com/users/dlockhart/events{/privacy}","received_events_url":"https://api.github.com/users/dlockhart/received_events","type":"User","site_admin":false},"created_at":"2016-11-02T18:26:48Z","updated_at":"2016-11-02T18:26:48Z","body":"Agreed. I think we should be able to just iterate over the items that are there and figure out how many we need to chomp and then chomp them all at once. Instead of measure-chomp-measure-chomp-..."}}
{"actor":{"display_login":"dlockhart"}}