{"action":"created","comment":{"url":"https://api.github.com/repos/druid-io/druid/pulls/comments/93824064","pull_request_review_id":14348429,"id":93824064,"diff_hunk":"@@ -46,34 +45,25 @@\n   private final TreeSet<Interval> intervals;\n   private final QueryGranularity queryGranularity;\n   private final Boolean rollup;\n-  private final String timezone;\n \n   @JsonCreator\n   public ArbitraryGranularitySpec(\n       @JsonProperty(\"queryGranularity\") QueryGranularity queryGranularity,\n       @JsonProperty(\"rollup\") Boolean rollup,\n-      @JsonProperty(\"intervals\") List<Interval> inputIntervals,\n-      @JsonProperty(\"timezone\") String timezone","path":"server/src/main/java/io/druid/segment/indexing/granularity/ArbitraryGranularitySpec.java","position":24,"original_position":24,"commit_id":"a559deb68b057753d4d17e6d8394fee7e491ad37","original_commit_id":"a559deb68b057753d4d17e6d8394fee7e491ad37","user":{"login":"leventov","id":609240,"avatar_url":"https://avatars.githubusercontent.com/u/609240?v=3","gravatar_id":"","url":"https://api.github.com/users/leventov","html_url":"https://github.com/leventov","followers_url":"https://api.github.com/users/leventov/followers","following_url":"https://api.github.com/users/leventov/following{/other_user}","gists_url":"https://api.github.com/users/leventov/gists{/gist_id}","starred_url":"https://api.github.com/users/leventov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leventov/subscriptions","organizations_url":"https://api.github.com/users/leventov/orgs","repos_url":"https://api.github.com/users/leventov/repos","events_url":"https://api.github.com/users/leventov/events{/privacy}","received_events_url":"https://api.github.com/users/leventov/received_events","type":"User","site_admin":false},"body":"Isn't this change backwards-incompatible?","created_at":"2016-12-25T04:56:45Z","updated_at":"2016-12-25T04:57:33Z","html_url":"https://github.com/druid-io/druid/pull/3766#discussion_r93824064","pull_request_url":"https://api.github.com/repos/druid-io/druid/pulls/3766","_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments/93824064"},"html":{"href":"https://github.com/druid-io/druid/pull/3766#discussion_r93824064"},"pull_request":{"href":"https://api.github.com/repos/druid-io/druid/pulls/3766"}}},"pull_request":{"url":"https://api.github.com/repos/druid-io/druid/pulls/3766","id":97233524,"html_url":"https://github.com/druid-io/druid/pull/3766","diff_url":"https://github.com/druid-io/druid/pull/3766.diff","patch_url":"https://github.com/druid-io/druid/pull/3766.patch","issue_url":"https://api.github.com/repos/druid-io/druid/issues/3766","number":3766,"state":"open","locked":false,"title":"Refactor Segment Granularity","user":{"login":"praveev","id":297278,"avatar_url":"https://avatars.githubusercontent.com/u/297278?v=3","gravatar_id":"","url":"https://api.github.com/users/praveev","html_url":"https://github.com/praveev","followers_url":"https://api.github.com/users/praveev/followers","following_url":"https://api.github.com/users/praveev/following{/other_user}","gists_url":"https://api.github.com/users/praveev/gists{/gist_id}","starred_url":"https://api.github.com/users/praveev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveev/subscriptions","organizations_url":"https://api.github.com/users/praveev/orgs","repos_url":"https://api.github.com/users/praveev/repos","events_url":"https://api.github.com/users/praveev/events{/privacy}","received_events_url":"https://api.github.com/users/praveev/received_events","type":"User","site_admin":false},"body":"The goal of this PR is to remove the `Granularity` enum which was used earlier and replace it with something more sophisticated that takes timezones into account.  Hence the new `SegmentGranularity`. The new class is modeled after `QueryGranularity`.\r\n\r\nThe earlier timezone support I created had some caveats https://github.com/druid-io/druid/pull/3528 Timezone wasn't respected for real time and also for batch ingestion without intervals. With this change, timezone can now be enforced with segment granularity for both batch ingestion and real time ingestion. Only batch ingestion has been tested.\r\n\r\n`Granularity` had plenty of unused methods. Those have been thrown away and all its tests have been ported for `SegmentGranularity`. \r\n\r\nCore files that were added/modified:\r\n1. SegmentGranularity\r\n2. PeriodSegmentGranularity\r\n3. UniformGranularitySpec\r\n4. PeriodGranularity\r\n5. PeriodQueryGranularity\r\n\r\nAll the other files are mostly side effects of these changes.","created_at":"2016-12-09T01:09:30Z","updated_at":"2016-12-25T04:57:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a86f4c61fbfa9382d91b3def1ec41a50dac241fd","assignee":{"login":"himanshug","id":246308,"avatar_url":"https://avatars.githubusercontent.com/u/246308?v=3","gravatar_id":"","url":"https://api.github.com/users/himanshug","html_url":"https://github.com/himanshug","followers_url":"https://api.github.com/users/himanshug/followers","following_url":"https://api.github.com/users/himanshug/following{/other_user}","gists_url":"https://api.github.com/users/himanshug/gists{/gist_id}","starred_url":"https://api.github.com/users/himanshug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himanshug/subscriptions","organizations_url":"https://api.github.com/users/himanshug/orgs","repos_url":"https://api.github.com/users/himanshug/repos","events_url":"https://api.github.com/users/himanshug/events{/privacy}","received_events_url":"https://api.github.com/users/himanshug/received_events","type":"User","site_admin":false},"assignees":[{"login":"himanshug","id":246308,"avatar_url":"https://avatars.githubusercontent.com/u/246308?v=3","gravatar_id":"","url":"https://api.github.com/users/himanshug","html_url":"https://github.com/himanshug","followers_url":"https://api.github.com/users/himanshug/followers","following_url":"https://api.github.com/users/himanshug/following{/other_user}","gists_url":"https://api.github.com/users/himanshug/gists{/gist_id}","starred_url":"https://api.github.com/users/himanshug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himanshug/subscriptions","organizations_url":"https://api.github.com/users/himanshug/orgs","repos_url":"https://api.github.com/users/himanshug/repos","events_url":"https://api.github.com/users/himanshug/events{/privacy}","received_events_url":"https://api.github.com/users/himanshug/received_events","type":"User","site_admin":false},{"login":"fjy","id":428325,"avatar_url":"https://avatars.githubusercontent.com/u/428325?v=3","gravatar_id":"","url":"https://api.github.com/users/fjy","html_url":"https://github.com/fjy","followers_url":"https://api.github.com/users/fjy/followers","following_url":"https://api.github.com/users/fjy/following{/other_user}","gists_url":"https://api.github.com/users/fjy/gists{/gist_id}","starred_url":"https://api.github.com/users/fjy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjy/subscriptions","organizations_url":"https://api.github.com/users/fjy/orgs","repos_url":"https://api.github.com/users/fjy/repos","events_url":"https://api.github.com/users/fjy/events{/privacy}","received_events_url":"https://api.github.com/users/fjy/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/druid-io/druid/milestones/21","html_url":"https://github.com/druid-io/druid/milestone/21","labels_url":"https://api.github.com/repos/druid-io/druid/milestones/21/labels","id":1831000,"number":21,"title":"0.10.0","description":"","creator":{"login":"fjy","id":428325,"avatar_url":"https://avatars.githubusercontent.com/u/428325?v=3","gravatar_id":"","url":"https://api.github.com/users/fjy","html_url":"https://github.com/fjy","followers_url":"https://api.github.com/users/fjy/followers","following_url":"https://api.github.com/users/fjy/following{/other_user}","gists_url":"https://api.github.com/users/fjy/gists{/gist_id}","starred_url":"https://api.github.com/users/fjy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjy/subscriptions","organizations_url":"https://api.github.com/users/fjy/orgs","repos_url":"https://api.github.com/users/fjy/repos","events_url":"https://api.github.com/users/fjy/events{/privacy}","received_events_url":"https://api.github.com/users/fjy/received_events","type":"User","site_admin":false},"open_issues":36,"closed_issues":141,"state":"open","created_at":"2016-06-15T22:35:58Z","updated_at":"2016-12-24T02:04:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/druid-io/druid/pulls/3766/commits","review_comments_url":"https://api.github.com/repos/druid-io/druid/pulls/3766/comments","review_comment_url":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/druid-io/druid/issues/3766/comments","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/a559deb68b057753d4d17e6d8394fee7e491ad37","head":{"label":"praveev:segment-granularity","ref":"segment-granularity","sha":"a559deb68b057753d4d17e6d8394fee7e491ad37","user":{"login":"praveev","id":297278,"avatar_url":"https://avatars.githubusercontent.com/u/297278?v=3","gravatar_id":"","url":"https://api.github.com/users/praveev","html_url":"https://github.com/praveev","followers_url":"https://api.github.com/users/praveev/followers","following_url":"https://api.github.com/users/praveev/following{/other_user}","gists_url":"https://api.github.com/users/praveev/gists{/gist_id}","starred_url":"https://api.github.com/users/praveev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveev/subscriptions","organizations_url":"https://api.github.com/users/praveev/orgs","repos_url":"https://api.github.com/users/praveev/repos","events_url":"https://api.github.com/users/praveev/events{/privacy}","received_events_url":"https://api.github.com/users/praveev/received_events","type":"User","site_admin":false},"repo":{"id":69693894,"name":"druid","full_name":"praveev/druid","owner":{"login":"praveev","id":297278,"avatar_url":"https://avatars.githubusercontent.com/u/297278?v=3","gravatar_id":"","url":"https://api.github.com/users/praveev","html_url":"https://github.com/praveev","followers_url":"https://api.github.com/users/praveev/followers","following_url":"https://api.github.com/users/praveev/following{/other_user}","gists_url":"https://api.github.com/users/praveev/gists{/gist_id}","starred_url":"https://api.github.com/users/praveev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveev/subscriptions","organizations_url":"https://api.github.com/users/praveev/orgs","repos_url":"https://api.github.com/users/praveev/repos","events_url":"https://api.github.com/users/praveev/events{/privacy}","received_events_url":"https://api.github.com/users/praveev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/praveev/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":true,"url":"https://api.github.com/repos/praveev/druid","forks_url":"https://api.github.com/repos/praveev/druid/forks","keys_url":"https://api.github.com/repos/praveev/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praveev/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praveev/druid/teams","hooks_url":"https://api.github.com/repos/praveev/druid/hooks","issue_events_url":"https://api.github.com/repos/praveev/druid/issues/events{/number}","events_url":"https://api.github.com/repos/praveev/druid/events","assignees_url":"https://api.github.com/repos/praveev/druid/assignees{/user}","branches_url":"https://api.github.com/repos/praveev/druid/branches{/branch}","tags_url":"https://api.github.com/repos/praveev/druid/tags","blobs_url":"https://api.github.com/repos/praveev/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praveev/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praveev/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/praveev/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praveev/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/praveev/druid/languages","stargazers_url":"https://api.github.com/repos/praveev/druid/stargazers","contributors_url":"https://api.github.com/repos/praveev/druid/contributors","subscribers_url":"https://api.github.com/repos/praveev/druid/subscribers","subscription_url":"https://api.github.com/repos/praveev/druid/subscription","commits_url":"https://api.github.com/repos/praveev/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/praveev/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/praveev/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/praveev/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/praveev/druid/contents/{+path}","compare_url":"https://api.github.com/repos/praveev/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praveev/druid/merges","archive_url":"https://api.github.com/repos/praveev/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praveev/druid/downloads","issues_url":"https://api.github.com/repos/praveev/druid/issues{/number}","pulls_url":"https://api.github.com/repos/praveev/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/praveev/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/praveev/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praveev/druid/labels{/name}","releases_url":"https://api.github.com/repos/praveev/druid/releases{/id}","deployments_url":"https://api.github.com/repos/praveev/druid/deployments","created_at":"2016-09-30T18:59:41Z","updated_at":"2016-09-30T18:59:51Z","pushed_at":"2016-12-23T19:35:51Z","git_url":"git://github.com/praveev/druid.git","ssh_url":"git@github.com:praveev/druid.git","clone_url":"https://github.com/praveev/druid.git","svn_url":"https://github.com/praveev/druid","homepage":"http://druid.io","size":117264,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"druid-io:master","ref":"master","sha":"35160e55953a476ca17b8676bf984a68a2a8f192","user":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":6358188,"name":"druid","full_name":"druid-io/druid","owner":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druid-io/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":false,"url":"https://api.github.com/repos/druid-io/druid","forks_url":"https://api.github.com/repos/druid-io/druid/forks","keys_url":"https://api.github.com/repos/druid-io/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/druid/teams","hooks_url":"https://api.github.com/repos/druid-io/druid/hooks","issue_events_url":"https://api.github.com/repos/druid-io/druid/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/druid/events","assignees_url":"https://api.github.com/repos/druid-io/druid/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/druid/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/druid/tags","blobs_url":"https://api.github.com/repos/druid-io/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/druid/languages","stargazers_url":"https://api.github.com/repos/druid-io/druid/stargazers","contributors_url":"https://api.github.com/repos/druid-io/druid/contributors","subscribers_url":"https://api.github.com/repos/druid-io/druid/subscribers","subscription_url":"https://api.github.com/repos/druid-io/druid/subscription","commits_url":"https://api.github.com/repos/druid-io/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/druid-io/druid/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/druid/merges","archive_url":"https://api.github.com/repos/druid-io/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/druid/downloads","issues_url":"https://api.github.com/repos/druid-io/druid/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/druid/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/druid/releases{/id}","deployments_url":"https://api.github.com/repos/druid-io/druid/deployments","created_at":"2012-10-23T19:08:07Z","updated_at":"2016-12-24T21:37:55Z","pushed_at":"2016-12-24T05:34:33Z","git_url":"git://github.com/druid-io/druid.git","ssh_url":"git@github.com:druid-io/druid.git","clone_url":"https://github.com/druid-io/druid.git","svn_url":"https://github.com/druid-io/druid","homepage":"http://druid.io","size":116150,"stargazers_count":4190,"watchers_count":4190,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":997,"mirror_url":null,"open_issues_count":572,"forks":997,"open_issues":572,"watchers":4190,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/3766"},"html":{"href":"https://github.com/druid-io/druid/pull/3766"},"issue":{"href":"https://api.github.com/repos/druid-io/druid/issues/3766"},"comments":{"href":"https://api.github.com/repos/druid-io/druid/issues/3766/comments"},"review_comments":{"href":"https://api.github.com/repos/druid-io/druid/pulls/3766/comments"},"review_comment":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/druid-io/druid/pulls/3766/commits"},"statuses":{"href":"https://api.github.com/repos/druid-io/druid/statuses/a559deb68b057753d4d17e6d8394fee7e491ad37"}}}}
{"actor":{"display_login":"leventov"}}