{"action":"opened","number":362,"pull_request":{"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/362","id":94988258,"html_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/362","diff_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/362.diff","patch_url":"https://github.com/ISISComputingGroup/ibex_gui/pull/362.patch","issue_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/362","number":362,"state":"open","locked":false,"title":"Ticket1727 dialog if overwriting existing config","user":{"login":"AdrianPotter","id":10273443,"avatar_url":"https://avatars.githubusercontent.com/u/10273443?v=3","gravatar_id":"","url":"https://api.github.com/users/AdrianPotter","html_url":"https://github.com/AdrianPotter","followers_url":"https://api.github.com/users/AdrianPotter/followers","following_url":"https://api.github.com/users/AdrianPotter/following{/other_user}","gists_url":"https://api.github.com/users/AdrianPotter/gists{/gist_id}","starred_url":"https://api.github.com/users/AdrianPotter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdrianPotter/subscriptions","organizations_url":"https://api.github.com/users/AdrianPotter/orgs","repos_url":"https://api.github.com/users/AdrianPotter/repos","events_url":"https://api.github.com/users/AdrianPotter/events{/privacy}","received_events_url":"https://api.github.com/users/AdrianPotter/received_events","type":"User","site_admin":false},"body":"### Description of work\r\n\r\n- A dialog now appears if you try and save a config with an existing name\r\n- The GUI won't let you save a dialog if the name matches the current configuration from the `save as` dialog. Changes can only be made from `Edit current configuration`\r\n\r\n### To test\r\n\r\nhttps://github.com/ISISComputingGroup/IBEX/issues/1727\r\n\r\n### Acceptance criteria\r\n\r\n- [ ] Can still edit the current configuration from the appropriate dialog\r\n- [ ] When creating a new configuration, can't save the configuration with the name of the current configuration\r\n- [ ] When creating a new configuration, a confirmation dialog appears after pressing `ok` when the configuration has the name of an existing configuration\r\n    - [ ] The configuration is saved when `Yes` is pressed\r\n    - [ ] The configuration is discarded when `No` is pressed\r\n- [ ] As above for editing a configuration and then click `Save as`\r\n\r\n---\r\n\r\n#### Code Review\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/GUI-Coding-Conventions)? Is it well structured with small focussed classes/methods/functions?\r\n- [ ] Are there unit tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] Are there [system tests](https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/System-Testing-with-RCPTT) in place? Do they test a minimal set of functionality and leave the gui as close as possible to its original state?\r\n- [ ] Did any existing system test break as a result of the current changes? \r\n- [ ] Have the changes been documented in the [release notes](https://github.com/ISISComputingGroup/IBEX/wiki/ReleaseNotes_Dev). If so, do they describe the changes appropriately?\r\n- [ ] Has the [manual system tests spreadsheet](https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Manual-system-tests) been updated?\r\n\r\n### Functional Tests\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed.\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n### Final Steps\r\n- [ ] Reviewer has moved the [release notes](https://github.com/ISISComputingGroup/IBEX/wiki/ReleaseNotes_Dev) entry for this ticket in the \"Changes merged into master\" section\r\n","created_at":"2016-11-23T11:48:20Z","updated_at":"2016-11-23T11:48:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/362/commits","review_comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/362/comments","review_comment_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/362/comments","statuses_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/statuses/b6ced4f3be1200dabc13d9bbe1d049a420dfd799","head":{"label":"ISISComputingGroup:Ticket1727_Dialog_if_overwriting_existing_config","ref":"Ticket1727_Dialog_if_overwriting_existing_config","sha":"b6ced4f3be1200dabc13d9bbe1d049a420dfd799","user":{"login":"ISISComputingGroup","id":7941980,"avatar_url":"https://avatars.githubusercontent.com/u/7941980?v=3","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":36387668,"name":"ibex_gui","full_name":"ISISComputingGroup/ibex_gui","owner":{"login":"ISISComputingGroup","id":7941980,"avatar_url":"https://avatars.githubusercontent.com/u/7941980?v=3","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ISISComputingGroup/ibex_gui","description":"The IBEX GUI repository","fork":false,"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui","forks_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/forks","keys_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/teams","hooks_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/hooks","issue_events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/events{/number}","events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/events","assignees_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/assignees{/user}","branches_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/branches{/branch}","tags_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/tags","blobs_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/statuses/{sha}","languages_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/languages","stargazers_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/stargazers","contributors_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/contributors","subscribers_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/subscribers","subscription_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/subscription","commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/contents/{+path}","compare_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/merges","archive_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/downloads","issues_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues{/number}","pulls_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls{/number}","milestones_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/milestones{/number}","notifications_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/labels{/name}","releases_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/releases{/id}","deployments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/deployments","created_at":"2015-05-27T18:37:00Z","updated_at":"2016-10-22T11:01:46Z","pushed_at":"2016-11-23T11:40:26Z","git_url":"git://github.com/ISISComputingGroup/ibex_gui.git","ssh_url":"git@github.com:ISISComputingGroup/ibex_gui.git","clone_url":"https://github.com/ISISComputingGroup/ibex_gui.git","svn_url":"https://github.com/ISISComputingGroup/ibex_gui","homepage":"","size":22891,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"ISISComputingGroup:master","ref":"master","sha":"19b986c4f33c4bc8123c1ad1ea5b128616cceadc","user":{"login":"ISISComputingGroup","id":7941980,"avatar_url":"https://avatars.githubusercontent.com/u/7941980?v=3","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":36387668,"name":"ibex_gui","full_name":"ISISComputingGroup/ibex_gui","owner":{"login":"ISISComputingGroup","id":7941980,"avatar_url":"https://avatars.githubusercontent.com/u/7941980?v=3","gravatar_id":"","url":"https://api.github.com/users/ISISComputingGroup","html_url":"https://github.com/ISISComputingGroup","followers_url":"https://api.github.com/users/ISISComputingGroup/followers","following_url":"https://api.github.com/users/ISISComputingGroup/following{/other_user}","gists_url":"https://api.github.com/users/ISISComputingGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/ISISComputingGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISISComputingGroup/subscriptions","organizations_url":"https://api.github.com/users/ISISComputingGroup/orgs","repos_url":"https://api.github.com/users/ISISComputingGroup/repos","events_url":"https://api.github.com/users/ISISComputingGroup/events{/privacy}","received_events_url":"https://api.github.com/users/ISISComputingGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ISISComputingGroup/ibex_gui","description":"The IBEX GUI repository","fork":false,"url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui","forks_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/forks","keys_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/teams","hooks_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/hooks","issue_events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/events{/number}","events_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/events","assignees_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/assignees{/user}","branches_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/branches{/branch}","tags_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/tags","blobs_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/statuses/{sha}","languages_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/languages","stargazers_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/stargazers","contributors_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/contributors","subscribers_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/subscribers","subscription_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/subscription","commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/contents/{+path}","compare_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/merges","archive_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/downloads","issues_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues{/number}","pulls_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls{/number}","milestones_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/milestones{/number}","notifications_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/labels{/name}","releases_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/releases{/id}","deployments_url":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/deployments","created_at":"2015-05-27T18:37:00Z","updated_at":"2016-10-22T11:01:46Z","pushed_at":"2016-11-23T11:40:26Z","git_url":"git://github.com/ISISComputingGroup/ibex_gui.git","ssh_url":"git@github.com:ISISComputingGroup/ibex_gui.git","clone_url":"https://github.com/ISISComputingGroup/ibex_gui.git","svn_url":"https://github.com/ISISComputingGroup/ibex_gui","homepage":"","size":22891,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/362"},"html":{"href":"https://github.com/ISISComputingGroup/ibex_gui/pull/362"},"issue":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/362"},"comments":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/issues/362/comments"},"review_comments":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/362/comments"},"review_comment":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/pulls/362/commits"},"statuses":{"href":"https://api.github.com/repos/ISISComputingGroup/ibex_gui/statuses/b6ced4f3be1200dabc13d9bbe1d049a420dfd799"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":143,"deletions":13,"changed_files":2}}
{"actor":{"display_login":"AdrianPotter"}}