{"action":"created","comment":{"url":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/comments/82491194","pull_request_review_id":3398602,"id":82491194,"diff_hunk":"@@ -314,6 +314,20 @@ def run_domain_checks(rounded_time, env, output, pool):\n \tfor domain in sort_domains(ret, env):\n \t\tret[domain].playback(output)\n \n+\trun_custom_domain_checks(env, output)\n+\n+def run_custom_domain_checks(env, output):\n+\theader_pending = True\n+\tfor qname, rtype, value in get_custom_dns_config(env):\n+\t\tif header_pending:\n+\t\t\toutput.add_heading(\"Custom\")\n+\t\t\theader_pending = False\n+\t\tresult = query_dns(qname, rtype).replace('\" \"', '')\n+\t\tif value == result or '\"' + value + '\"' in result:","path":"management/status_checks.py","position":22,"original_position":22,"commit_id":"f389603f01bb9c82f212cbc48e48dedfebfc5b10","original_commit_id":"f389603f01bb9c82f212cbc48e48dedfebfc5b10","user":{"login":"bronson","id":1776,"avatar_url":"https://avatars.githubusercontent.com/u/1776?v=3","gravatar_id":"","url":"https://api.github.com/users/bronson","html_url":"https://github.com/bronson","followers_url":"https://api.github.com/users/bronson/followers","following_url":"https://api.github.com/users/bronson/following{/other_user}","gists_url":"https://api.github.com/users/bronson/gists{/gist_id}","starred_url":"https://api.github.com/users/bronson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bronson/subscriptions","organizations_url":"https://api.github.com/users/bronson/orgs","repos_url":"https://api.github.com/users/bronson/repos","events_url":"https://api.github.com/users/bronson/events{/privacy}","received_events_url":"https://api.github.com/users/bronson/received_events","type":"User","site_admin":false},"body":"because result is a list and value is a string...  == wouldn't work in that case, right?\r\n\r\nI'm not a Python programmer so I'm happy to hear where my style is lacking!","created_at":"2016-10-08T00:58:43Z","updated_at":"2016-10-08T00:58:44Z","html_url":"https://github.com/mail-in-a-box/mailinabox/pull/955#discussion_r82491194","pull_request_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/955","_links":{"self":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/comments/82491194"},"html":{"href":"https://github.com/mail-in-a-box/mailinabox/pull/955#discussion_r82491194"},"pull_request":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/955"}}},"pull_request":{"url":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/955","id":87582698,"html_url":"https://github.com/mail-in-a-box/mailinabox/pull/955","diff_url":"https://github.com/mail-in-a-box/mailinabox/pull/955.diff","patch_url":"https://github.com/mail-in-a-box/mailinabox/pull/955.patch","issue_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/issues/955","number":955,"state":"open","locked":false,"title":"add SPF and DMARC records to the DNS status checks","user":{"login":"bronson","id":1776,"avatar_url":"https://avatars.githubusercontent.com/u/1776?v=3","gravatar_id":"","url":"https://api.github.com/users/bronson","html_url":"https://github.com/bronson","followers_url":"https://api.github.com/users/bronson/followers","following_url":"https://api.github.com/users/bronson/following{/other_user}","gists_url":"https://api.github.com/users/bronson/gists{/gist_id}","starred_url":"https://api.github.com/users/bronson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bronson/subscriptions","organizations_url":"https://api.github.com/users/bronson/orgs","repos_url":"https://api.github.com/users/bronson/repos","events_url":"https://api.github.com/users/bronson/events{/privacy}","received_events_url":"https://api.github.com/users/bronson/received_events","type":"User","site_admin":false},"body":"This is the first in a series of patches to ensure every DNS record gets checked.\r\n\r\n* SPF and DMARC (#955, this one)\r\n* DKIM (#956)\r\n* caldav and carddav (#957)\r\n* Custom user-set records (#958)\r\n\r\nOnce all those are in, #649 might be considered fixed.  And maybe #692 as well.","created_at":"2016-09-30T23:52:15Z","updated_at":"2016-10-08T00:58:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6c9b5850d41848f96779fee96428994dfba9dd2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/955/commits","review_comments_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/955/comments","review_comment_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/issues/955/comments","statuses_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/statuses/f389603f01bb9c82f212cbc48e48dedfebfc5b10","head":{"label":"bronson:check_spf","ref":"check_spf","sha":"f389603f01bb9c82f212cbc48e48dedfebfc5b10","user":{"login":"bronson","id":1776,"avatar_url":"https://avatars.githubusercontent.com/u/1776?v=3","gravatar_id":"","url":"https://api.github.com/users/bronson","html_url":"https://github.com/bronson","followers_url":"https://api.github.com/users/bronson/followers","following_url":"https://api.github.com/users/bronson/following{/other_user}","gists_url":"https://api.github.com/users/bronson/gists{/gist_id}","starred_url":"https://api.github.com/users/bronson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bronson/subscriptions","organizations_url":"https://api.github.com/users/bronson/orgs","repos_url":"https://api.github.com/users/bronson/repos","events_url":"https://api.github.com/users/bronson/events{/privacy}","received_events_url":"https://api.github.com/users/bronson/received_events","type":"User","site_admin":false},"repo":{"id":47038426,"name":"mailinabox","full_name":"bronson/mailinabox","owner":{"login":"bronson","id":1776,"avatar_url":"https://avatars.githubusercontent.com/u/1776?v=3","gravatar_id":"","url":"https://api.github.com/users/bronson","html_url":"https://github.com/bronson","followers_url":"https://api.github.com/users/bronson/followers","following_url":"https://api.github.com/users/bronson/following{/other_user}","gists_url":"https://api.github.com/users/bronson/gists{/gist_id}","starred_url":"https://api.github.com/users/bronson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bronson/subscriptions","organizations_url":"https://api.github.com/users/bronson/orgs","repos_url":"https://api.github.com/users/bronson/repos","events_url":"https://api.github.com/users/bronson/events{/privacy}","received_events_url":"https://api.github.com/users/bronson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bronson/mailinabox","description":"Mail-in-a-Box helps individuals take back control of their email by defining a one-click, easy-to-deploy SMTP+everything else server: a mail server in a box.","fork":true,"url":"https://api.github.com/repos/bronson/mailinabox","forks_url":"https://api.github.com/repos/bronson/mailinabox/forks","keys_url":"https://api.github.com/repos/bronson/mailinabox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bronson/mailinabox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bronson/mailinabox/teams","hooks_url":"https://api.github.com/repos/bronson/mailinabox/hooks","issue_events_url":"https://api.github.com/repos/bronson/mailinabox/issues/events{/number}","events_url":"https://api.github.com/repos/bronson/mailinabox/events","assignees_url":"https://api.github.com/repos/bronson/mailinabox/assignees{/user}","branches_url":"https://api.github.com/repos/bronson/mailinabox/branches{/branch}","tags_url":"https://api.github.com/repos/bronson/mailinabox/tags","blobs_url":"https://api.github.com/repos/bronson/mailinabox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bronson/mailinabox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bronson/mailinabox/git/refs{/sha}","trees_url":"https://api.github.com/repos/bronson/mailinabox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bronson/mailinabox/statuses/{sha}","languages_url":"https://api.github.com/repos/bronson/mailinabox/languages","stargazers_url":"https://api.github.com/repos/bronson/mailinabox/stargazers","contributors_url":"https://api.github.com/repos/bronson/mailinabox/contributors","subscribers_url":"https://api.github.com/repos/bronson/mailinabox/subscribers","subscription_url":"https://api.github.com/repos/bronson/mailinabox/subscription","commits_url":"https://api.github.com/repos/bronson/mailinabox/commits{/sha}","git_commits_url":"https://api.github.com/repos/bronson/mailinabox/git/commits{/sha}","comments_url":"https://api.github.com/repos/bronson/mailinabox/comments{/number}","issue_comment_url":"https://api.github.com/repos/bronson/mailinabox/issues/comments{/number}","contents_url":"https://api.github.com/repos/bronson/mailinabox/contents/{+path}","compare_url":"https://api.github.com/repos/bronson/mailinabox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bronson/mailinabox/merges","archive_url":"https://api.github.com/repos/bronson/mailinabox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bronson/mailinabox/downloads","issues_url":"https://api.github.com/repos/bronson/mailinabox/issues{/number}","pulls_url":"https://api.github.com/repos/bronson/mailinabox/pulls{/number}","milestones_url":"https://api.github.com/repos/bronson/mailinabox/milestones{/number}","notifications_url":"https://api.github.com/repos/bronson/mailinabox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bronson/mailinabox/labels{/name}","releases_url":"https://api.github.com/repos/bronson/mailinabox/releases{/id}","deployments_url":"https://api.github.com/repos/bronson/mailinabox/deployments","created_at":"2015-11-28T20:29:47Z","updated_at":"2016-09-18T07:31:42Z","pushed_at":"2016-10-05T22:32:08Z","git_url":"git://github.com/bronson/mailinabox.git","ssh_url":"git@github.com:bronson/mailinabox.git","clone_url":"https://github.com/bronson/mailinabox.git","svn_url":"https://github.com/bronson/mailinabox","homepage":"https://mailinabox.email/","size":2177,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mail-in-a-box:master","ref":"master","sha":"da5497cd1cce54e4601d616e333de98b04b95d2e","user":{"login":"mail-in-a-box","id":8107370,"avatar_url":"https://avatars.githubusercontent.com/u/8107370?v=3","gravatar_id":"","url":"https://api.github.com/users/mail-in-a-box","html_url":"https://github.com/mail-in-a-box","followers_url":"https://api.github.com/users/mail-in-a-box/followers","following_url":"https://api.github.com/users/mail-in-a-box/following{/other_user}","gists_url":"https://api.github.com/users/mail-in-a-box/gists{/gist_id}","starred_url":"https://api.github.com/users/mail-in-a-box/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mail-in-a-box/subscriptions","organizations_url":"https://api.github.com/users/mail-in-a-box/orgs","repos_url":"https://api.github.com/users/mail-in-a-box/repos","events_url":"https://api.github.com/users/mail-in-a-box/events{/privacy}","received_events_url":"https://api.github.com/users/mail-in-a-box/received_events","type":"Organization","site_admin":false},"repo":{"id":12271469,"name":"mailinabox","full_name":"mail-in-a-box/mailinabox","owner":{"login":"mail-in-a-box","id":8107370,"avatar_url":"https://avatars.githubusercontent.com/u/8107370?v=3","gravatar_id":"","url":"https://api.github.com/users/mail-in-a-box","html_url":"https://github.com/mail-in-a-box","followers_url":"https://api.github.com/users/mail-in-a-box/followers","following_url":"https://api.github.com/users/mail-in-a-box/following{/other_user}","gists_url":"https://api.github.com/users/mail-in-a-box/gists{/gist_id}","starred_url":"https://api.github.com/users/mail-in-a-box/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mail-in-a-box/subscriptions","organizations_url":"https://api.github.com/users/mail-in-a-box/orgs","repos_url":"https://api.github.com/users/mail-in-a-box/repos","events_url":"https://api.github.com/users/mail-in-a-box/events{/privacy}","received_events_url":"https://api.github.com/users/mail-in-a-box/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mail-in-a-box/mailinabox","description":"Mail-in-a-Box helps individuals take back control of their email by defining a one-click, easy-to-deploy SMTP+everything else server: a mail server in a box.","fork":false,"url":"https://api.github.com/repos/mail-in-a-box/mailinabox","forks_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/forks","keys_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/teams","hooks_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/hooks","issue_events_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/issues/events{/number}","events_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/events","assignees_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/assignees{/user}","branches_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/branches{/branch}","tags_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/tags","blobs_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/git/refs{/sha}","trees_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/statuses/{sha}","languages_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/languages","stargazers_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/stargazers","contributors_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/contributors","subscribers_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/subscribers","subscription_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/subscription","commits_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/commits{/sha}","git_commits_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/git/commits{/sha}","comments_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/comments{/number}","issue_comment_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/issues/comments{/number}","contents_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/contents/{+path}","compare_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/merges","archive_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/downloads","issues_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/issues{/number}","pulls_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls{/number}","milestones_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/milestones{/number}","notifications_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/labels{/name}","releases_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/releases{/id}","deployments_url":"https://api.github.com/repos/mail-in-a-box/mailinabox/deployments","created_at":"2013-08-21T13:56:50Z","updated_at":"2016-10-07T20:32:55Z","pushed_at":"2016-10-07T21:29:25Z","git_url":"git://github.com/mail-in-a-box/mailinabox.git","ssh_url":"git@github.com:mail-in-a-box/mailinabox.git","clone_url":"https://github.com/mail-in-a-box/mailinabox.git","svn_url":"https://github.com/mail-in-a-box/mailinabox","homepage":"https://mailinabox.email/","size":3537,"stargazers_count":5128,"watchers_count":5128,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":440,"mirror_url":null,"open_issues_count":143,"forks":440,"open_issues":143,"watchers":5128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/955"},"html":{"href":"https://github.com/mail-in-a-box/mailinabox/pull/955"},"issue":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/issues/955"},"comments":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/issues/955/comments"},"review_comments":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/955/comments"},"review_comment":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/pulls/955/commits"},"statuses":{"href":"https://api.github.com/repos/mail-in-a-box/mailinabox/statuses/f389603f01bb9c82f212cbc48e48dedfebfc5b10"}}}}
{"actor":{"display_login":"bronson"}}