{"action":"created","issue":{"url":"https://api.github.com/repos/scala/scala/issues/5376","repository_url":"https://api.github.com/repos/scala/scala","labels_url":"https://api.github.com/repos/scala/scala/issues/5376/labels{/name}","comments_url":"https://api.github.com/repos/scala/scala/issues/5376/comments","events_url":"https://api.github.com/repos/scala/scala/issues/5376/events","html_url":"https://github.com/scala/scala/pull/5376","id":175074916,"number":5376,"title":"Clean up of code guarded by bare -Xexperimental","user":{"login":"milessabin","id":131183,"avatar_url":"https://avatars.githubusercontent.com/u/131183?v=3","gravatar_id":"","url":"https://api.github.com/users/milessabin","html_url":"https://github.com/milessabin","followers_url":"https://api.github.com/users/milessabin/followers","following_url":"https://api.github.com/users/milessabin/following{/other_user}","gists_url":"https://api.github.com/users/milessabin/gists{/gist_id}","starred_url":"https://api.github.com/users/milessabin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milessabin/subscriptions","organizations_url":"https://api.github.com/users/milessabin/orgs","repos_url":"https://api.github.com/users/milessabin/repos","events_url":"https://api.github.com/users/milessabin/events{/privacy}","received_events_url":"https://api.github.com/users/milessabin/received_events","type":"User","site_admin":false},"labels":[{"id":216463557,"url":"https://api.github.com/repos/scala/scala/labels/release-notes","name":"release-notes","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/scala/scala/milestones/55","html_url":"https://github.com/scala/scala/milestones/2.12.1","labels_url":"https://api.github.com/repos/scala/scala/milestones/55/labels","id":1840949,"number":55,"title":"2.12.1","description":"New PRs will default to 2.12.2 to meet our Nov 30 release deadline.","creator":{"login":"adriaanm","id":91083,"avatar_url":"https://avatars.githubusercontent.com/u/91083?v=3","gravatar_id":"","url":"https://api.github.com/users/adriaanm","html_url":"https://github.com/adriaanm","followers_url":"https://api.github.com/users/adriaanm/followers","following_url":"https://api.github.com/users/adriaanm/following{/other_user}","gists_url":"https://api.github.com/users/adriaanm/gists{/gist_id}","starred_url":"https://api.github.com/users/adriaanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriaanm/subscriptions","organizations_url":"https://api.github.com/users/adriaanm/orgs","repos_url":"https://api.github.com/users/adriaanm/repos","events_url":"https://api.github.com/users/adriaanm/events{/privacy}","received_events_url":"https://api.github.com/users/adriaanm/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":83,"state":"open","created_at":"2016-06-21T15:54:47Z","updated_at":"2016-11-25T18:57:29Z","due_on":"2016-11-30T00:00:00Z","closed_at":null},"comments":28,"created_at":"2016-09-05T13:46:04Z","updated_at":"2016-11-28T14:56:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scala/scala/pulls/5376","html_url":"https://github.com/scala/scala/pull/5376","diff_url":"https://github.com/scala/scala/pull/5376.diff","patch_url":"https://github.com/scala/scala/pull/5376.patch"},"body":"I've removed all the code which is guarded by a bare -Xexperimental flag setting. In the case of the things that were covered by `enableTypeVarExperimentals` the status of all tests remains the same, so I think that the functionality it was intended to enable has become part of the default case.\n\nI have also disabled the code supporting match virtualization ... I'd be happy to put it back under a `-Yvirtpatmat` flag.\n\nAnd I've removed the disabling of the handling of SAMs where 2.11.x source code compatibility has been requested. Again, I would be happy to put this back under a `-Ysam` flag, but I'm not convinced that partial downgrades make a lot of sense, so I would prefer to just remove this functionality.\n"},"comment":{"url":"https://api.github.com/repos/scala/scala/issues/comments/263291610","html_url":"https://github.com/scala/scala/pull/5376#issuecomment-263291610","issue_url":"https://api.github.com/repos/scala/scala/issues/5376","id":263291610,"user":{"login":"milessabin","id":131183,"avatar_url":"https://avatars.githubusercontent.com/u/131183?v=3","gravatar_id":"","url":"https://api.github.com/users/milessabin","html_url":"https://github.com/milessabin","followers_url":"https://api.github.com/users/milessabin/followers","following_url":"https://api.github.com/users/milessabin/following{/other_user}","gists_url":"https://api.github.com/users/milessabin/gists{/gist_id}","starred_url":"https://api.github.com/users/milessabin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milessabin/subscriptions","organizations_url":"https://api.github.com/users/milessabin/orgs","repos_url":"https://api.github.com/users/milessabin/repos","events_url":"https://api.github.com/users/milessabin/events{/privacy}","received_events_url":"https://api.github.com/users/milessabin/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T14:56:15Z","updated_at":"2016-11-28T14:56:15Z","body":"I've taken a close look at [SI-5729](https://issues.scala-lang.org/browse/SI-5729), [SLS 6.26.3](http://scala-lang.org/files/archive/spec/2.11/06-expressions.html#overloading-resolution) and concluded that the implementation of [`asSpecificAs`](https://github.com/scala/scala/blob/2.12.x/src/compiler/scala/tools/nsc/typechecker/Infer.scala#L808-L833) matches the spec, hence that the ambiguity reported in SI-5729 is the correct behaviour, not a bug: the spec provides no justification for preferring the polymorphic join[S] over the monomorphic (albeit existential) join.\r\n\r\nSo I've enabled the improved inference by default and moved t5729.scala from pos to neg."}}
{"actor":{"display_login":"milessabin"}}