{"action":"created","issue":{"url":"https://api.github.com/repos/serverless/serverless/issues/2460","repository_url":"https://api.github.com/repos/serverless/serverless","labels_url":"https://api.github.com/repos/serverless/serverless/issues/2460/labels{/name}","comments_url":"https://api.github.com/repos/serverless/serverless/issues/2460/comments","events_url":"https://api.github.com/repos/serverless/serverless/issues/2460/events","html_url":"https://github.com/serverless/serverless/issues/2460","id":183932567,"number":2460,"title":"Rework include/exclude","user":{"login":"mthenw","id":455261,"avatar_url":"https://avatars.githubusercontent.com/u/455261?v=3","gravatar_id":"","url":"https://api.github.com/users/mthenw","html_url":"https://github.com/mthenw","followers_url":"https://api.github.com/users/mthenw/followers","following_url":"https://api.github.com/users/mthenw/following{/other_user}","gists_url":"https://api.github.com/users/mthenw/gists{/gist_id}","starred_url":"https://api.github.com/users/mthenw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mthenw/subscriptions","organizations_url":"https://api.github.com/users/mthenw/orgs","repos_url":"https://api.github.com/users/mthenw/repos","events_url":"https://api.github.com/users/mthenw/events{/privacy}","received_events_url":"https://api.github.com/users/mthenw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-10-19T11:11:52Z","updated_at":"2016-10-19T21:54:25Z","closed_at":null,"body":"# This is a Feature Proposal\r\n\r\n## Description\r\n\r\nCurrent solution is super confusing. After reading docs I have no idea how this thing works and what to expect. It's also not obvious for users:\r\n* https://github.com/serverless/serverless/issues/2414\r\n* https://github.com/serverless/serverless/issues/2264\r\n* https://github.com/serverless/serverless/issues/2231\r\n* https://github.com/serverless/serverless/issues/2071\r\n* https://github.com/serverless/serverless/pull/2194\r\n* https://github.com/serverless/serverless/issues/2139\r\n\r\n## Solution: `.serverlessignore`\r\n\r\nInstead of reinventing the wheel we should use well-known solution used by git, npm, eslint and many many other tools out there.\r\n\r\nUser should be able to place this file in a root dir or any other dir, exactly the same as `.gitignore`.\r\n\r\neslint is using this module https://www.npmjs.com/package/ignore (3,016,506 downloads in the last month). I think we could also use that. "},"comment":{"url":"https://api.github.com/repos/serverless/serverless/issues/comments/254952344","html_url":"https://github.com/serverless/serverless/issues/2460#issuecomment-254952344","issue_url":"https://api.github.com/repos/serverless/serverless/issues/2460","id":254952344,"user":{"login":"mthenw","id":455261,"avatar_url":"https://avatars.githubusercontent.com/u/455261?v=3","gravatar_id":"","url":"https://api.github.com/users/mthenw","html_url":"https://github.com/mthenw","followers_url":"https://api.github.com/users/mthenw/followers","following_url":"https://api.github.com/users/mthenw/following{/other_user}","gists_url":"https://api.github.com/users/mthenw/gists{/gist_id}","starred_url":"https://api.github.com/users/mthenw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mthenw/subscriptions","organizations_url":"https://api.github.com/users/mthenw/orgs","repos_url":"https://api.github.com/users/mthenw/repos","events_url":"https://api.github.com/users/mthenw/events{/privacy}","received_events_url":"https://api.github.com/users/mthenw/received_events","type":"User","site_admin":false},"created_at":"2016-10-19T21:54:25Z","updated_at":"2016-10-19T21:54:25Z","body":"@ac360 it always problematic to change existing feature but I always wonder if we would add a exactly the same feature again. If not we should not block ourselves from changing what is wrong. Users will appreciate even if they use that.\r\n\r\nThe main problem with using ignore package with 'package.exclude' is that user will be able to also include a file ('!') there. Super confusing. Another 'sls deploy --noDeploy'. We should be very careful with that."}}
{"actor":{"display_login":"mthenw"}}