{"action":"created","comment":{"url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments/52795772","id":52795772,"diff_hunk":"@@ -0,0 +1,173 @@\n+require 'test_helper'\n+\n+module ActiveModel\n+  class Serializer\n+    module Adapter\n+      class JsonApi\n+        class RelationshipTest < ActiveSupport::TestCase\n+          RelationshipAuthor = Class.new(::Model)\n+          class RelationshipAuthorSerializer < ActiveModel::Serializer\n+            has_one :bio do\n+              link :self, '//example.com/link_author/relationships/bio'\n+            end\n+\n+            has_one :profile do\n+              link :related do\n+                \"//example.com/profiles/#{object.profile.id}\"\n+              end\n+            end\n+\n+            has_many :locations do\n+              link :related do\n+                ids = object.locations.map!(&:id).join(',')\n+                href \"//example.com/locations/#{ids}\"\n+              end\n+            end\n+\n+            has_many :posts do\n+              link :related do\n+                ids = object.posts.map!(&:id).join(',')\n+                href \"//example.com/posts/#{ids}\"","path":"test/adapter/json_api/relationship_test.rb","position":30,"original_position":30,"commit_id":"b1fd43303cb10cc636e06ccddf1a76a18981c70b","original_commit_id":"b1fd43303cb10cc636e06ccddf1a76a18981c70b","user":{"login":"bf4","id":142914,"avatar_url":"https://avatars.githubusercontent.com/u/142914?v=3","gravatar_id":"","url":"https://api.github.com/users/bf4","html_url":"https://github.com/bf4","followers_url":"https://api.github.com/users/bf4/followers","following_url":"https://api.github.com/users/bf4/following{/other_user}","gists_url":"https://api.github.com/users/bf4/gists{/gist_id}","starred_url":"https://api.github.com/users/bf4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bf4/subscriptions","organizations_url":"https://api.github.com/users/bf4/orgs","repos_url":"https://api.github.com/users/bf4/repos","events_url":"https://api.github.com/users/bf4/events{/privacy}","received_events_url":"https://api.github.com/users/bf4/received_events","type":"User","site_admin":false},"body":":exclamation: :scream: :100: ","created_at":"2016-02-12T20:42:44Z","updated_at":"2016-02-12T20:42:44Z","html_url":"https://github.com/rails-api/active_model_serializers/pull/1504#discussion_r52795772","pull_request_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1504","_links":{"self":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments/52795772"},"html":{"href":"https://github.com/rails-api/active_model_serializers/pull/1504#discussion_r52795772"},"pull_request":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1504"}}},"pull_request":{"url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1504","id":58832289,"html_url":"https://github.com/rails-api/active_model_serializers/pull/1504","diff_url":"https://github.com/rails-api/active_model_serializers/pull/1504.diff","patch_url":"https://github.com/rails-api/active_model_serializers/pull/1504.patch","issue_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1504","number":1504,"state":"open","locked":false,"title":"Follow up to #1454","user":{"login":"groyoh","id":7434196,"avatar_url":"https://avatars.githubusercontent.com/u/7434196?v=3","gravatar_id":"","url":"https://api.github.com/users/groyoh","html_url":"https://github.com/groyoh","followers_url":"https://api.github.com/users/groyoh/followers","following_url":"https://api.github.com/users/groyoh/following{/other_user}","gists_url":"https://api.github.com/users/groyoh/gists{/gist_id}","starred_url":"https://api.github.com/users/groyoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groyoh/subscriptions","organizations_url":"https://api.github.com/users/groyoh/orgs","repos_url":"https://api.github.com/users/groyoh/repos","events_url":"https://api.github.com/users/groyoh/events{/privacy}","received_events_url":"https://api.github.com/users/groyoh/received_events","type":"User","site_admin":false},"body":"PR #1454 was merged with some missing fixes. All these fixes are addressed by this PR:\r\n- Rename `ActiveModel::Serializer::Adapter::JsonApi::Association` to `ActiveModel::Serializer::Adapter::JsonApi::Relationship`\r\n- `Move ActiveModel::Serializer::Adapter:: JsonApi::Relationship` and `ActiveModel::Serializer::Adapter::JsonApi::ResourceIdentifier` to `ActiveModel::Serializer::Adapter::JsonApi::ApiObjects` module\r\n- Add unit test for `ActiveModel::Serializer::Adapter::JsonApi::Relationship`\r\n- Add unit test for `ActiveModel::Serializer::Adapter::JsonApi::ResourceIdentifier`\r\n\r\n@bf4 here you go ;)","created_at":"2016-02-10T00:34:53Z","updated_at":"2016-02-12T20:42:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc4e42551670f91c53557230c0287e0ded453d5b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1504/commits","review_comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1504/comments","review_comment_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1504/comments","statuses_url":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/b1fd43303cb10cc636e06ccddf1a76a18981c70b","head":{"label":"groyoh:association-blocks","ref":"association-blocks","sha":"b1fd43303cb10cc636e06ccddf1a76a18981c70b","user":{"login":"groyoh","id":7434196,"avatar_url":"https://avatars.githubusercontent.com/u/7434196?v=3","gravatar_id":"","url":"https://api.github.com/users/groyoh","html_url":"https://github.com/groyoh","followers_url":"https://api.github.com/users/groyoh/followers","following_url":"https://api.github.com/users/groyoh/following{/other_user}","gists_url":"https://api.github.com/users/groyoh/gists{/gist_id}","starred_url":"https://api.github.com/users/groyoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groyoh/subscriptions","organizations_url":"https://api.github.com/users/groyoh/orgs","repos_url":"https://api.github.com/users/groyoh/repos","events_url":"https://api.github.com/users/groyoh/events{/privacy}","received_events_url":"https://api.github.com/users/groyoh/received_events","type":"User","site_admin":false},"repo":{"id":33311083,"name":"active_model_serializers","full_name":"groyoh/active_model_serializers","owner":{"login":"groyoh","id":7434196,"avatar_url":"https://avatars.githubusercontent.com/u/7434196?v=3","gravatar_id":"","url":"https://api.github.com/users/groyoh","html_url":"https://github.com/groyoh","followers_url":"https://api.github.com/users/groyoh/followers","following_url":"https://api.github.com/users/groyoh/following{/other_user}","gists_url":"https://api.github.com/users/groyoh/gists{/gist_id}","starred_url":"https://api.github.com/users/groyoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groyoh/subscriptions","organizations_url":"https://api.github.com/users/groyoh/orgs","repos_url":"https://api.github.com/users/groyoh/repos","events_url":"https://api.github.com/users/groyoh/events{/privacy}","received_events_url":"https://api.github.com/users/groyoh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/groyoh/active_model_serializers","description":"ActiveModel::Serializer implementation and Rails hooks","fork":true,"url":"https://api.github.com/repos/groyoh/active_model_serializers","forks_url":"https://api.github.com/repos/groyoh/active_model_serializers/forks","keys_url":"https://api.github.com/repos/groyoh/active_model_serializers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/groyoh/active_model_serializers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/groyoh/active_model_serializers/teams","hooks_url":"https://api.github.com/repos/groyoh/active_model_serializers/hooks","issue_events_url":"https://api.github.com/repos/groyoh/active_model_serializers/issues/events{/number}","events_url":"https://api.github.com/repos/groyoh/active_model_serializers/events","assignees_url":"https://api.github.com/repos/groyoh/active_model_serializers/assignees{/user}","branches_url":"https://api.github.com/repos/groyoh/active_model_serializers/branches{/branch}","tags_url":"https://api.github.com/repos/groyoh/active_model_serializers/tags","blobs_url":"https://api.github.com/repos/groyoh/active_model_serializers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/groyoh/active_model_serializers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/groyoh/active_model_serializers/git/refs{/sha}","trees_url":"https://api.github.com/repos/groyoh/active_model_serializers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/groyoh/active_model_serializers/statuses/{sha}","languages_url":"https://api.github.com/repos/groyoh/active_model_serializers/languages","stargazers_url":"https://api.github.com/repos/groyoh/active_model_serializers/stargazers","contributors_url":"https://api.github.com/repos/groyoh/active_model_serializers/contributors","subscribers_url":"https://api.github.com/repos/groyoh/active_model_serializers/subscribers","subscription_url":"https://api.github.com/repos/groyoh/active_model_serializers/subscription","commits_url":"https://api.github.com/repos/groyoh/active_model_serializers/commits{/sha}","git_commits_url":"https://api.github.com/repos/groyoh/active_model_serializers/git/commits{/sha}","comments_url":"https://api.github.com/repos/groyoh/active_model_serializers/comments{/number}","issue_comment_url":"https://api.github.com/repos/groyoh/active_model_serializers/issues/comments{/number}","contents_url":"https://api.github.com/repos/groyoh/active_model_serializers/contents/{+path}","compare_url":"https://api.github.com/repos/groyoh/active_model_serializers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/groyoh/active_model_serializers/merges","archive_url":"https://api.github.com/repos/groyoh/active_model_serializers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/groyoh/active_model_serializers/downloads","issues_url":"https://api.github.com/repos/groyoh/active_model_serializers/issues{/number}","pulls_url":"https://api.github.com/repos/groyoh/active_model_serializers/pulls{/number}","milestones_url":"https://api.github.com/repos/groyoh/active_model_serializers/milestones{/number}","notifications_url":"https://api.github.com/repos/groyoh/active_model_serializers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/groyoh/active_model_serializers/labels{/name}","releases_url":"https://api.github.com/repos/groyoh/active_model_serializers/releases{/id}","deployments_url":"https://api.github.com/repos/groyoh/active_model_serializers/deployments","created_at":"2015-04-02T13:44:27Z","updated_at":"2015-04-10T06:54:21Z","pushed_at":"2016-02-10T20:46:12Z","git_url":"git://github.com/groyoh/active_model_serializers.git","ssh_url":"git@github.com:groyoh/active_model_serializers.git","clone_url":"https://github.com/groyoh/active_model_serializers.git","svn_url":"https://github.com/groyoh/active_model_serializers","homepage":"","size":2435,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails-api:master","ref":"master","sha":"fb48bced5e45ea0fe5e4454d772d2f1f1b9cf3e3","user":{"login":"rails-api","id":2820360,"avatar_url":"https://avatars.githubusercontent.com/u/2820360?v=3","gravatar_id":"","url":"https://api.github.com/users/rails-api","html_url":"https://github.com/rails-api","followers_url":"https://api.github.com/users/rails-api/followers","following_url":"https://api.github.com/users/rails-api/following{/other_user}","gists_url":"https://api.github.com/users/rails-api/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-api/subscriptions","organizations_url":"https://api.github.com/users/rails-api/orgs","repos_url":"https://api.github.com/users/rails-api/repos","events_url":"https://api.github.com/users/rails-api/events{/privacy}","received_events_url":"https://api.github.com/users/rails-api/received_events","type":"Organization","site_admin":false},"repo":{"id":2889230,"name":"active_model_serializers","full_name":"rails-api/active_model_serializers","owner":{"login":"rails-api","id":2820360,"avatar_url":"https://avatars.githubusercontent.com/u/2820360?v=3","gravatar_id":"","url":"https://api.github.com/users/rails-api","html_url":"https://github.com/rails-api","followers_url":"https://api.github.com/users/rails-api/followers","following_url":"https://api.github.com/users/rails-api/following{/other_user}","gists_url":"https://api.github.com/users/rails-api/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-api/subscriptions","organizations_url":"https://api.github.com/users/rails-api/orgs","repos_url":"https://api.github.com/users/rails-api/repos","events_url":"https://api.github.com/users/rails-api/events{/privacy}","received_events_url":"https://api.github.com/users/rails-api/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails-api/active_model_serializers","description":"ActiveModel::Serializer implementation and Rails hooks","fork":false,"url":"https://api.github.com/repos/rails-api/active_model_serializers","forks_url":"https://api.github.com/repos/rails-api/active_model_serializers/forks","keys_url":"https://api.github.com/repos/rails-api/active_model_serializers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails-api/active_model_serializers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails-api/active_model_serializers/teams","hooks_url":"https://api.github.com/repos/rails-api/active_model_serializers/hooks","issue_events_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/events{/number}","events_url":"https://api.github.com/repos/rails-api/active_model_serializers/events","assignees_url":"https://api.github.com/repos/rails-api/active_model_serializers/assignees{/user}","branches_url":"https://api.github.com/repos/rails-api/active_model_serializers/branches{/branch}","tags_url":"https://api.github.com/repos/rails-api/active_model_serializers/tags","blobs_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/{sha}","languages_url":"https://api.github.com/repos/rails-api/active_model_serializers/languages","stargazers_url":"https://api.github.com/repos/rails-api/active_model_serializers/stargazers","contributors_url":"https://api.github.com/repos/rails-api/active_model_serializers/contributors","subscribers_url":"https://api.github.com/repos/rails-api/active_model_serializers/subscribers","subscription_url":"https://api.github.com/repos/rails-api/active_model_serializers/subscription","commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails-api/active_model_serializers/contents/{+path}","compare_url":"https://api.github.com/repos/rails-api/active_model_serializers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails-api/active_model_serializers/merges","archive_url":"https://api.github.com/repos/rails-api/active_model_serializers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails-api/active_model_serializers/downloads","issues_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues{/number}","pulls_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls{/number}","milestones_url":"https://api.github.com/repos/rails-api/active_model_serializers/milestones{/number}","notifications_url":"https://api.github.com/repos/rails-api/active_model_serializers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails-api/active_model_serializers/labels{/name}","releases_url":"https://api.github.com/repos/rails-api/active_model_serializers/releases{/id}","deployments_url":"https://api.github.com/repos/rails-api/active_model_serializers/deployments","created_at":"2011-12-01T06:39:26Z","updated_at":"2016-02-12T15:27:38Z","pushed_at":"2016-02-12T20:13:40Z","git_url":"git://github.com/rails-api/active_model_serializers.git","ssh_url":"git@github.com:rails-api/active_model_serializers.git","clone_url":"https://github.com/rails-api/active_model_serializers.git","svn_url":"https://github.com/rails-api/active_model_serializers","homepage":"","size":3912,"stargazers_count":3312,"watchers_count":3312,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":800,"mirror_url":null,"open_issues_count":198,"forks":800,"open_issues":198,"watchers":3312,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1504"},"html":{"href":"https://github.com/rails-api/active_model_serializers/pull/1504"},"issue":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1504"},"comments":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1504/comments"},"review_comments":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1504/comments"},"review_comment":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1504/commits"},"statuses":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/b1fd43303cb10cc636e06ccddf1a76a18981c70b"}}}}