{"action":"created","issue":{"url":"https://api.github.com/repos/greenplum-db/gporca/issues/90","repository_url":"https://api.github.com/repos/greenplum-db/gporca","labels_url":"https://api.github.com/repos/greenplum-db/gporca/issues/90/labels{/name}","comments_url":"https://api.github.com/repos/greenplum-db/gporca/issues/90/comments","events_url":"https://api.github.com/repos/greenplum-db/gporca/issues/90/events","html_url":"https://github.com/greenplum-db/gporca/pull/90","id":170918747,"number":90,"title":"[#128239337] Fix constraint bug in preprocessor","user":{"login":"cramja","id":5708822,"avatar_url":"https://avatars.githubusercontent.com/u/5708822?v=3","gravatar_id":"","url":"https://api.github.com/users/cramja","html_url":"https://github.com/cramja","followers_url":"https://api.github.com/users/cramja/followers","following_url":"https://api.github.com/users/cramja/following{/other_user}","gists_url":"https://api.github.com/users/cramja/gists{/gist_id}","starred_url":"https://api.github.com/users/cramja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramja/subscriptions","organizations_url":"https://api.github.com/users/cramja/orgs","repos_url":"https://api.github.com/users/cramja/repos","events_url":"https://api.github.com/users/cramja/events{/privacy}","received_events_url":"https://api.github.com/users/cramja/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-12T17:21:26Z","updated_at":"2016-08-13T08:17:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gporca/pulls/90","html_url":"https://github.com/greenplum-db/gporca/pull/90","diff_url":"https://github.com/greenplum-db/gporca/pull/90.diff","patch_url":"https://github.com/greenplum-db/gporca/pull/90.patch"},"body":"We ran into cases where the preprocessor step 'PexprConvert2In' would\r\ntry to create a constraint but fail and get a null value returned to it,\r\nwhich would cause ORCA to crash. This was because the constraints\r\nframework can only create constraints on certain types. By adding an\r\nadditional check for constrainable types we guarantee that a constraint\r\nwill be returned.\r\n\r\nAlso added an ASSERT to check for this condition."},"comment":{"url":"https://api.github.com/repos/greenplum-db/gporca/issues/comments/239609363","html_url":"https://github.com/greenplum-db/gporca/pull/90#issuecomment-239609363","issue_url":"https://api.github.com/repos/greenplum-db/gporca/issues/90","id":239609363,"user":{"login":"vraghavan78","id":12649877,"avatar_url":"https://avatars.githubusercontent.com/u/12649877?v=3","gravatar_id":"","url":"https://api.github.com/users/vraghavan78","html_url":"https://github.com/vraghavan78","followers_url":"https://api.github.com/users/vraghavan78/followers","following_url":"https://api.github.com/users/vraghavan78/following{/other_user}","gists_url":"https://api.github.com/users/vraghavan78/gists{/gist_id}","starred_url":"https://api.github.com/users/vraghavan78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vraghavan78/subscriptions","organizations_url":"https://api.github.com/users/vraghavan78/orgs","repos_url":"https://api.github.com/users/vraghavan78/repos","events_url":"https://api.github.com/users/vraghavan78/events{/privacy}","received_events_url":"https://api.github.com/users/vraghavan78/received_events","type":"User","site_admin":false},"created_at":"2016-08-13T08:17:13Z","updated_at":"2016-08-13T08:17:13Z","body":"First, I do not know what the problem that you were trying to fix. Was there a test that failed? If so which one and if not why not?\r\n\r\nSecond, as it stands now I cannot understand the reasoning for these constraints? Can we update that. Also indentation makes it damn hard."}}
{"actor":{"display_login":"vraghavan78"}}