{"action":"created","issue":{"url":"https://api.github.com/repos/Zuehlke/cookbook-windev/issues/21","repository_url":"https://api.github.com/repos/Zuehlke/cookbook-windev","labels_url":"https://api.github.com/repos/Zuehlke/cookbook-windev/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/Zuehlke/cookbook-windev/issues/21/comments","events_url":"https://api.github.com/repos/Zuehlke/cookbook-windev/issues/21/events","html_url":"https://github.com/Zuehlke/cookbook-windev/pull/21","id":175098992,"number":21,"title":"Added option to package.rb to unzip and then install","user":{"login":"mrkita","id":8996289,"avatar_url":"https://avatars.githubusercontent.com/u/8996289?v=3","gravatar_id":"","url":"https://api.github.com/users/mrkita","html_url":"https://github.com/mrkita","followers_url":"https://api.github.com/users/mrkita/followers","following_url":"https://api.github.com/users/mrkita/following{/other_user}","gists_url":"https://api.github.com/users/mrkita/gists{/gist_id}","starred_url":"https://api.github.com/users/mrkita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrkita/subscriptions","organizations_url":"https://api.github.com/users/mrkita/orgs","repos_url":"https://api.github.com/users/mrkita/repos","events_url":"https://api.github.com/users/mrkita/events{/privacy}","received_events_url":"https://api.github.com/users/mrkita/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-05T16:04:46Z","updated_at":"2016-10-04T09:33:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Zuehlke/cookbook-windev/pulls/21","html_url":"https://github.com/Zuehlke/cookbook-windev/pull/21","diff_url":"https://github.com/Zuehlke/cookbook-windev/pull/21.diff","patch_url":"https://github.com/Zuehlke/cookbook-windev/pull/21.patch"},"body":"Perhaps this is not the cleanest way to do it, but I wanted to create this now before it gets lost as it makes installing loose leaf custom package installs much easier and still something that can be fetched."},"comment":{"url":"https://api.github.com/repos/Zuehlke/cookbook-windev/issues/comments/251340565","html_url":"https://github.com/Zuehlke/cookbook-windev/pull/21#issuecomment-251340565","issue_url":"https://api.github.com/repos/Zuehlke/cookbook-windev/issues/21","id":251340565,"user":{"login":"mrkita","id":8996289,"avatar_url":"https://avatars.githubusercontent.com/u/8996289?v=3","gravatar_id":"","url":"https://api.github.com/users/mrkita","html_url":"https://github.com/mrkita","followers_url":"https://api.github.com/users/mrkita/followers","following_url":"https://api.github.com/users/mrkita/following{/other_user}","gists_url":"https://api.github.com/users/mrkita/gists{/gist_id}","starred_url":"https://api.github.com/users/mrkita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrkita/subscriptions","organizations_url":"https://api.github.com/users/mrkita/orgs","repos_url":"https://api.github.com/users/mrkita/repos","events_url":"https://api.github.com/users/mrkita/events{/privacy}","received_events_url":"https://api.github.com/users/mrkita/received_events","type":"User","site_admin":false},"created_at":"2016-10-04T09:33:08Z","updated_at":"2016-10-04T09:33:08Z","body":"I don't want any magic either, just after flexibility. My commit @d9fb3ca1 is an alternative, removing the automagic unpack step. However, my original line of thinking is, we only download individual files. Either the file is an executable of some sort, and will be run, or its a zip containing multiple files which must first be unpacked.\r\n\r\nThis alternative I introduce would require the use of an unpack keyword to invoke the unzip before using the installer. I'm not really sure I like it better.\r\n\r\nHowever, I see the original chain as follows:\r\n\r\nDefault\r\nThe 'installer' key alone means the package was already prepared and is sitting somewhere in the cache, so use it direct to run the install.\r\n\r\nSourced as in first commit:\r\nDoes the file need to be cached first because the 'source' key is present? If yes then download it.\r\nIf no 'installer' is specified, then just assume to use the 'save_as' target as the install package.\r\nIf an 'installer' is specified then there must be more than one file in the download... since we don't download directories it must be a zip (what else can it be that we support?), so unzip it.\r\nWe use 'installer' as a local path that was first created by the above. The semantic meaning of the key is the same.\r\n\r\nSourced as in second commit:\r\nDoes the file need to be cached first because the 'source' key is present? If yes then download it.\r\nIf no 'installer' is specified, then just assume to use the 'save_as' target as the install package.\r\nIf 'unpack' is specified, then the file is a zip and must be unpacked first to the relative (not forced) local path.\r\nWe use 'installer' as a local path that was first created by the above. The semantic meaning of the key is the same.\r\n\r\nWhat I don't like in the second version , is that the unpack seems superfluous if we don't support other file types than single installer packages or zip files. Also in this case the use of 'unpack' would require 'installer' as there can be no assumption of which file to run in the unpacked directory.\r\n\r\nEither case; however, is functional and can be documented for clarity.\r\n\r\nWhat do you think? Would be nice to get this in ACI3 to close this hole...\r\n"}}
{"actor":{"display_login":"mrkita"}}