{"action":"created","issue":{"url":"https://api.github.com/repos/kripken/emscripten/issues/4558","repository_url":"https://api.github.com/repos/kripken/emscripten","labels_url":"https://api.github.com/repos/kripken/emscripten/issues/4558/labels{/name}","comments_url":"https://api.github.com/repos/kripken/emscripten/issues/4558/comments","events_url":"https://api.github.com/repos/kripken/emscripten/issues/4558/events","html_url":"https://github.com/kripken/emscripten/pull/4558","id":176789798,"number":4558,"title":"Allow for empty EM_ASM consts","user":{"login":"jgravelle-google","id":20847303,"avatar_url":"https://avatars.githubusercontent.com/u/20847303?v=3","gravatar_id":"","url":"https://api.github.com/users/jgravelle-google","html_url":"https://github.com/jgravelle-google","followers_url":"https://api.github.com/users/jgravelle-google/followers","following_url":"https://api.github.com/users/jgravelle-google/following{/other_user}","gists_url":"https://api.github.com/users/jgravelle-google/gists{/gist_id}","starred_url":"https://api.github.com/users/jgravelle-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgravelle-google/subscriptions","organizations_url":"https://api.github.com/users/jgravelle-google/orgs","repos_url":"https://api.github.com/users/jgravelle-google/repos","events_url":"https://api.github.com/users/jgravelle-google/events{/privacy}","received_events_url":"https://api.github.com/users/jgravelle-google/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-14T01:09:19Z","updated_at":"2016-09-14T21:19:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/4558","html_url":"https://github.com/kripken/emscripten/pull/4558","diff_url":"https://github.com/kripken/emscripten/pull/4558.diff","patch_url":"https://github.com/kripken/emscripten/pull/4558.patch"},"body":"Dependency on https://github.com/WebAssembly/binaryen/pull/697 to successfully emit empty EM_ASMs."},"comment":{"url":"https://api.github.com/repos/kripken/emscripten/issues/comments/247157628","html_url":"https://github.com/kripken/emscripten/pull/4558#issuecomment-247157628","issue_url":"https://api.github.com/repos/kripken/emscripten/issues/4558","id":247157628,"user":{"login":"jgravelle-google","id":20847303,"avatar_url":"https://avatars.githubusercontent.com/u/20847303?v=3","gravatar_id":"","url":"https://api.github.com/users/jgravelle-google","html_url":"https://github.com/jgravelle-google","followers_url":"https://api.github.com/users/jgravelle-google/followers","following_url":"https://api.github.com/users/jgravelle-google/following{/other_user}","gists_url":"https://api.github.com/users/jgravelle-google/gists{/gist_id}","starred_url":"https://api.github.com/users/jgravelle-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgravelle-google/subscriptions","organizations_url":"https://api.github.com/users/jgravelle-google/orgs","repos_url":"https://api.github.com/users/jgravelle-google/repos","events_url":"https://api.github.com/users/jgravelle-google/events{/privacy}","received_events_url":"https://api.github.com/users/jgravelle-google/received_events","type":"User","site_admin":false},"created_at":"2016-09-14T21:19:08Z","updated_at":"2016-09-14T21:19:08Z","body":"We *do* though, in particular for https://github.com/kripken/emscripten/blob/incoming/tests/unistd/unlink.c#L28 asm2wasm correctly generates `ASM_CONSTS = [function($0) { }];` when `NODEFS` isn't defined.\r\nSo in theory we could optimize these away and never bother with them, but that's not what it seems to be doing."}}
{"actor":{"display_login":"jgravelle-google"}}