{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/50773366","id":50773366,"diff_hunk":"@@ -114,6 +116,8 @@ def get_locale():\n     '''\n     Get the current system locale\n \n+    .. versionchanged:: Boron","path":"salt/modules/localemod.py","position":13,"original_position":13,"commit_id":"4ec64e966861d8b35f8c3da84e9fda62df29bcb4","original_commit_id":"4ec64e966861d8b35f8c3da84e9fda62df29bcb4","user":{"login":"basepi","id":702318,"avatar_url":"https://avatars.githubusercontent.com/u/702318?v=3","gravatar_id":"","url":"https://api.github.com/users/basepi","html_url":"https://github.com/basepi","followers_url":"https://api.github.com/users/basepi/followers","following_url":"https://api.github.com/users/basepi/following{/other_user}","gists_url":"https://api.github.com/users/basepi/gists{/gist_id}","starred_url":"https://api.github.com/users/basepi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basepi/subscriptions","organizations_url":"https://api.github.com/users/basepi/orgs","repos_url":"https://api.github.com/users/basepi/repos","events_url":"https://api.github.com/users/basepi/events{/privacy}","received_events_url":"https://api.github.com/users/basepi/received_events","type":"User","site_admin":false},"body":"I'm not sure if this is useful without any indication of *what* changed. I would just remove it. The only time we need this is when there's a backwards incompatible change anyway.","created_at":"2016-01-25T23:21:10Z","updated_at":"2016-01-25T23:21:10Z","html_url":"https://github.com/saltstack/salt/pull/30579#discussion_r50773366","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/30579","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/50773366"},"html":{"href":"https://github.com/saltstack/salt/pull/30579#discussion_r50773366"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/30579"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/30579","id":56989379,"html_url":"https://github.com/saltstack/salt/pull/30579","diff_url":"https://github.com/saltstack/salt/pull/30579.diff","patch_url":"https://github.com/saltstack/salt/pull/30579.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/30579","number":30579,"state":"open","locked":false,"title":"Fix up salt.modules.locale(mod) for Solaris and some generic improvements","user":{"login":"sjorge","id":379665,"avatar_url":"https://avatars.githubusercontent.com/u/379665?v=3","gravatar_id":"","url":"https://api.github.com/users/sjorge","html_url":"https://github.com/sjorge","followers_url":"https://api.github.com/users/sjorge/followers","following_url":"https://api.github.com/users/sjorge/following{/other_user}","gists_url":"https://api.github.com/users/sjorge/gists{/gist_id}","starred_url":"https://api.github.com/users/sjorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjorge/subscriptions","organizations_url":"https://api.github.com/users/sjorge/orgs","repos_url":"https://api.github.com/users/sjorge/repos","events_url":"https://api.github.com/users/sjorge/events{/privacy}","received_events_url":"https://api.github.com/users/sjorge/received_events","type":"User","site_admin":false},"body":"I also fixed a few unit tests, it assumed a cmd.run that we can skip on unknown/unsupported platforms.\r\nRunning __salt__['cmd.run']('') is kind of pointless!\r\n\r\nOriginally i had set_locale to return False on unknown/unsupported platforms, I changed this back to True to not break unit tests.\r\n\r\nCurrently: we pretend to success, meaning when called via salt.states.locale... we keep hitting 1 state that will always return a change (as we 'pretend to set' but don't actually set it)\r\n\r\nI would prefer to just hard fail on that, that way a sysadmin won't assume the locale got set correctly when it obviously didn't.\r\n\r\nIf you agree I can do a follow up commit to change it set_locale to return False.","created_at":"2016-01-23T23:06:30Z","updated_at":"2016-01-25T23:21:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a63d7a6fd9bc899842fdef4ace4a6fb778d31c1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/30579/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/30579/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/30579/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/4ec64e966861d8b35f8c3da84e9fda62df29bcb4","head":{"label":"sjorge:module-localemod","ref":"module-localemod","sha":"4ec64e966861d8b35f8c3da84e9fda62df29bcb4","user":{"login":"sjorge","id":379665,"avatar_url":"https://avatars.githubusercontent.com/u/379665?v=3","gravatar_id":"","url":"https://api.github.com/users/sjorge","html_url":"https://github.com/sjorge","followers_url":"https://api.github.com/users/sjorge/followers","following_url":"https://api.github.com/users/sjorge/following{/other_user}","gists_url":"https://api.github.com/users/sjorge/gists{/gist_id}","starred_url":"https://api.github.com/users/sjorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjorge/subscriptions","organizations_url":"https://api.github.com/users/sjorge/orgs","repos_url":"https://api.github.com/users/sjorge/repos","events_url":"https://api.github.com/users/sjorge/events{/privacy}","received_events_url":"https://api.github.com/users/sjorge/received_events","type":"User","site_admin":false},"repo":{"id":40401491,"name":"salt","full_name":"sjorge/salt","owner":{"login":"sjorge","id":379665,"avatar_url":"https://avatars.githubusercontent.com/u/379665?v=3","gravatar_id":"","url":"https://api.github.com/users/sjorge","html_url":"https://github.com/sjorge","followers_url":"https://api.github.com/users/sjorge/followers","following_url":"https://api.github.com/users/sjorge/following{/other_user}","gists_url":"https://api.github.com/users/sjorge/gists{/gist_id}","starred_url":"https://api.github.com/users/sjorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjorge/subscriptions","organizations_url":"https://api.github.com/users/sjorge/orgs","repos_url":"https://api.github.com/users/sjorge/repos","events_url":"https://api.github.com/users/sjorge/events{/privacy}","received_events_url":"https://api.github.com/users/sjorge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sjorge/salt","description":"Infrastructure automation and management system","fork":true,"url":"https://api.github.com/repos/sjorge/salt","forks_url":"https://api.github.com/repos/sjorge/salt/forks","keys_url":"https://api.github.com/repos/sjorge/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sjorge/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sjorge/salt/teams","hooks_url":"https://api.github.com/repos/sjorge/salt/hooks","issue_events_url":"https://api.github.com/repos/sjorge/salt/issues/events{/number}","events_url":"https://api.github.com/repos/sjorge/salt/events","assignees_url":"https://api.github.com/repos/sjorge/salt/assignees{/user}","branches_url":"https://api.github.com/repos/sjorge/salt/branches{/branch}","tags_url":"https://api.github.com/repos/sjorge/salt/tags","blobs_url":"https://api.github.com/repos/sjorge/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sjorge/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sjorge/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/sjorge/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sjorge/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/sjorge/salt/languages","stargazers_url":"https://api.github.com/repos/sjorge/salt/stargazers","contributors_url":"https://api.github.com/repos/sjorge/salt/contributors","subscribers_url":"https://api.github.com/repos/sjorge/salt/subscribers","subscription_url":"https://api.github.com/repos/sjorge/salt/subscription","commits_url":"https://api.github.com/repos/sjorge/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/sjorge/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/sjorge/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/sjorge/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/sjorge/salt/contents/{+path}","compare_url":"https://api.github.com/repos/sjorge/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sjorge/salt/merges","archive_url":"https://api.github.com/repos/sjorge/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sjorge/salt/downloads","issues_url":"https://api.github.com/repos/sjorge/salt/issues{/number}","pulls_url":"https://api.github.com/repos/sjorge/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/sjorge/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/sjorge/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sjorge/salt/labels{/name}","releases_url":"https://api.github.com/repos/sjorge/salt/releases{/id}","deployments_url":"https://api.github.com/repos/sjorge/salt/deployments","created_at":"2015-08-08T11:58:03Z","updated_at":"2016-01-12T19:43:52Z","pushed_at":"2016-01-25T23:18:57Z","git_url":"git://github.com/sjorge/salt.git","ssh_url":"git@github.com:sjorge/salt.git","clone_url":"https://github.com/sjorge/salt.git","svn_url":"https://github.com/sjorge/salt","homepage":"saltstack.com","size":138123,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"8823d7f56a0e3012d57cad4199f7c78bbbe8d1df","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt Open software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2016-01-25T13:24:41Z","pushed_at":"2016-01-25T23:19:46Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":152506,"stargazers_count":6139,"watchers_count":6139,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2663,"mirror_url":null,"open_issues_count":3263,"forks":2663,"open_issues":3263,"watchers":6139,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/30579"},"html":{"href":"https://github.com/saltstack/salt/pull/30579"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/30579"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/30579/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/30579/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/30579/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/4ec64e966861d8b35f8c3da84e9fda62df29bcb4"}}}}