{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/26542","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/26542/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/26542/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/26542/events","html_url":"https://github.com/owncloud/core/pull/26542","id":187078836,"number":26542,"title":"Fix file permissions at read time when wrong in DB","user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?v=3","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"labels":[{"id":17709846,"url":"https://api.github.com/repos/owncloud/core/labels/3%20-%20To%20Review","name":"3 - To Review","color":"ededed","default":false},{"id":132150275,"url":"https://api.github.com/repos/owncloud/core/labels/backport-request","name":"backport-request","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/76","html_url":"https://github.com/owncloud/core/milestones/9.2","labels_url":"https://api.github.com/repos/owncloud/core/milestones/76/labels","id":1632230,"number":76,"title":"9.2","description":null,"creator":{"login":"MorrisJobke","id":245432,"avatar_url":"https://avatars.githubusercontent.com/u/245432?v=3","gravatar_id":"","url":"https://api.github.com/users/MorrisJobke","html_url":"https://github.com/MorrisJobke","followers_url":"https://api.github.com/users/MorrisJobke/followers","following_url":"https://api.github.com/users/MorrisJobke/following{/other_user}","gists_url":"https://api.github.com/users/MorrisJobke/gists{/gist_id}","starred_url":"https://api.github.com/users/MorrisJobke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorrisJobke/subscriptions","organizations_url":"https://api.github.com/users/MorrisJobke/orgs","repos_url":"https://api.github.com/users/MorrisJobke/repos","events_url":"https://api.github.com/users/MorrisJobke/events{/privacy}","received_events_url":"https://api.github.com/users/MorrisJobke/received_events","type":"User","site_admin":false},"open_issues":469,"closed_issues":409,"state":"open","created_at":"2016-03-09T07:18:43Z","updated_at":"2016-11-07T09:46:25Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-11-03T14:41:51Z","updated_at":"2016-11-07T10:07:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/26542","html_url":"https://github.com/owncloud/core/pull/26542","diff_url":"https://github.com/owncloud/core/pull/26542.diff","patch_url":"https://github.com/owncloud/core/pull/26542.patch"},"body":"<!--\r\nThanks for submitting a change to ownCloud!\r\n\r\nThis is the bug tracker for the Server component. Find other components at https://github.com/owncloud/core/blob/master/.github/CONTRIBUTING.md#guidelines\r\n\r\nFor fixing potential security issues please see https://owncloud.org/security/\r\n\r\nTo make it possible for us to get your change reviewed and merged please fill out below information carefully.\r\n\r\nPlease note that any kind of change first has to be submitted to the master branch which holds the next major version of ownCloud.\r\n\r\nWe will carefully discuss if your change can or has to be backported to stable branches.\r\n-->\r\n\r\n## Description\r\nIn some past situations it was possible to create file shares with\r\ninvalid permissions. Since such entries still exist in some databases,\r\nthe share provider now automatically masks these permissions with the\r\nallowed ones. This will prevent some code paths like ownership transfer\r\nto trigger problems where permissions cannot be changed.\r\n\r\n## Related Issue\r\nFixes https://github.com/owncloud/core/issues/26541\r\n\r\n## Motivation and Context\r\nSee linked issue.\r\nNote that I decided against doing this in the manager directly because the manager is doing validation and is not supposed to change input data.\r\n\r\n## How Has This Been Tested?\r\nUnit tests and see steps in ticket.\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n\r\n### Backports\r\n- [ ] stable9.1\r\n- [ ] stable9\r\n\r\n@DeepDiver1975 @jvillafanez @PhilippSchaffrath "},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/258794747","html_url":"https://github.com/owncloud/core/pull/26542#issuecomment-258794747","issue_url":"https://api.github.com/repos/owncloud/core/issues/26542","id":258794747,"user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?v=3","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T10:07:19Z","updated_at":"2016-11-07T10:07:19Z","body":"> The user can still create shares with wrong permissions through the ocs api and the api will return something different\r\n\r\nNo, this isn't possible any more already. It's only in OC < 9.0 that it used to be possible.\r\n\r\nA repair step, maybe yes.\r\n- [ ] add repair step\r\n\r\n> There is also the problem with the permissions: web UI shows 5 kind of permissions (if I remember correctly), this PR only offers 3 so, what happens with the rest? \r\n\r\nFor file shares the web UI offers only two kind of permissions: \"can edit\" and \"can share\".\r\nFor folders there's more. But this PR is only required for file shares.\r\n"}}
{"actor":{"display_login":"PVince81"}}