{"action":"created","issue":{"url":"https://api.github.com/repos/octokit/octokit.net/issues/1247","repository_url":"https://api.github.com/repos/octokit/octokit.net","labels_url":"https://api.github.com/repos/octokit/octokit.net/issues/1247/labels{/name}","comments_url":"https://api.github.com/repos/octokit/octokit.net/issues/1247/comments","events_url":"https://api.github.com/repos/octokit/octokit.net/issues/1247/events","html_url":"https://github.com/octokit/octokit.net/pull/1247","id":146263057,"number":1247,"title":"[WIP]Add ApiOption overloads to methods on IRepositoryCommitsClient","user":{"login":"prayankmathur","id":11440349,"avatar_url":"https://avatars.githubusercontent.com/u/11440349?v=3","gravatar_id":"","url":"https://api.github.com/users/prayankmathur","html_url":"https://github.com/prayankmathur","followers_url":"https://api.github.com/users/prayankmathur/followers","following_url":"https://api.github.com/users/prayankmathur/following{/other_user}","gists_url":"https://api.github.com/users/prayankmathur/gists{/gist_id}","starred_url":"https://api.github.com/users/prayankmathur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prayankmathur/subscriptions","organizations_url":"https://api.github.com/users/prayankmathur/orgs","repos_url":"https://api.github.com/users/prayankmathur/repos","events_url":"https://api.github.com/users/prayankmathur/events{/privacy}","received_events_url":"https://api.github.com/users/prayankmathur/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-06T10:11:02Z","updated_at":"2016-04-06T17:11:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/octokit/octokit.net/pulls/1247","html_url":"https://github.com/octokit/octokit.net/pull/1247","diff_url":"https://github.com/octokit/octokit.net/pull/1247.diff","patch_url":"https://github.com/octokit/octokit.net/pull/1247.patch"},"body":"Refer to issue #1176\r\n\r\n- [x] Adding overloads for `Task<IReadOnlyList<GitHubCommit>> GetAll(String owner, String name)` (reactive too)\r\n- [x] Adding overloads for `Task<IReadOnlyList<GitHubCommit>> GetAll(String owner, String name, CommitRequest request)`\r\n- [x] Adding unit test\r\n- [ ] Adding integration tests.\r\n\r\n//cc @shiftkey @ryangribble"},"comment":{"url":"https://api.github.com/repos/octokit/octokit.net/issues/comments/206469227","html_url":"https://github.com/octokit/octokit.net/pull/1247#issuecomment-206469227","issue_url":"https://api.github.com/repos/octokit/octokit.net/issues/1247","id":206469227,"user":{"login":"prayankmathur","id":11440349,"avatar_url":"https://avatars.githubusercontent.com/u/11440349?v=3","gravatar_id":"","url":"https://api.github.com/users/prayankmathur","html_url":"https://github.com/prayankmathur","followers_url":"https://api.github.com/users/prayankmathur/followers","following_url":"https://api.github.com/users/prayankmathur/following{/other_user}","gists_url":"https://api.github.com/users/prayankmathur/gists{/gist_id}","starred_url":"https://api.github.com/users/prayankmathur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prayankmathur/subscriptions","organizations_url":"https://api.github.com/users/prayankmathur/orgs","repos_url":"https://api.github.com/users/prayankmathur/repos","events_url":"https://api.github.com/users/prayankmathur/events{/privacy}","received_events_url":"https://api.github.com/users/prayankmathur/received_events","type":"User","site_admin":false},"created_at":"2016-04-06T17:11:53Z","updated_at":"2016-04-06T17:11:53Z","body":"@shiftkey \r\n@ryangribble \r\nI require some help in implementing the `GetAndFlattenAllPages` overload that i have implemented. I don't think if it is correct.\r\n\r\nAlso due to this, the `IObservable<GitHubCommit> GetAll(string owner, string name, CommitRequest request, ApiOptions options)` function doesn't return a list and am not able to write a test for it."}}