{"action":"created","comment":{"url":"https://api.github.com/repos/realm/realm-java/pulls/comments/65878080","id":65878080,"diff_hunk":"@@ -1025,6 +1030,39 @@ private Table getPrimaryKeyTable() {\n         return pkTable;\n     }\n \n+    /**\n+     * Rename the primary key column for the table. This needs to be called manually before inserting data into the table.\n+     *\n+     * @param newFieldName the name of the field replacing old primary key field name.\n+     * @throws {@link IllegalArgumentException} if {@code newFieldName} is an empty string, or exceeds field name length limit.\n+     * @throws {@link io.realm.exceptions.RealmException} if a primary key does not exist.\n+     */\n+    public void renamePrimaryKeyColumn(String newFieldName) {","path":"realm/realm-library/src/main/java/io/realm/internal/Table.java","position":23,"original_position":23,"commit_id":"e29c00e94561defaae41713caf07eb0b638d160c","original_commit_id":"e29c00e94561defaae41713caf07eb0b638d160c","user":{"login":"cmelchior","id":406066,"avatar_url":"https://avatars.githubusercontent.com/u/406066?v=3","gravatar_id":"","url":"https://api.github.com/users/cmelchior","html_url":"https://github.com/cmelchior","followers_url":"https://api.github.com/users/cmelchior/followers","following_url":"https://api.github.com/users/cmelchior/following{/other_user}","gists_url":"https://api.github.com/users/cmelchior/gists{/gist_id}","starred_url":"https://api.github.com/users/cmelchior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmelchior/subscriptions","organizations_url":"https://api.github.com/users/cmelchior/orgs","repos_url":"https://api.github.com/users/cmelchior/repos","events_url":"https://api.github.com/users/cmelchior/events{/privacy}","received_events_url":"https://api.github.com/users/cmelchior/received_events","type":"User","site_admin":false},"body":"Instead of having a separate method for this, why not check for this special case in `renameColumn` ? Right now this is a bit inconsistent with addColumn and removeColumn which do not have a special `*PrimaryKeyColumn` method (nor do they need one IMO)","created_at":"2016-06-06T11:58:49Z","updated_at":"2016-06-06T11:58:49Z","html_url":"https://github.com/realm/realm-java/pull/2920#discussion_r65878080","pull_request_url":"https://api.github.com/repos/realm/realm-java/pulls/2920","_links":{"self":{"href":"https://api.github.com/repos/realm/realm-java/pulls/comments/65878080"},"html":{"href":"https://github.com/realm/realm-java/pull/2920#discussion_r65878080"},"pull_request":{"href":"https://api.github.com/repos/realm/realm-java/pulls/2920"}}},"pull_request":{"url":"https://api.github.com/repos/realm/realm-java/pulls/2920","id":72172815,"html_url":"https://github.com/realm/realm-java/pull/2920","diff_url":"https://github.com/realm/realm-java/pull/2920.diff","patch_url":"https://github.com/realm/realm-java/pull/2920.patch","issue_url":"https://api.github.com/repos/realm/realm-java/issues/2920","number":2920,"state":"open","locked":false,"title":" PrimaryKey index rearrangement in migration revisited ","user":{"login":"stk1m1","id":16395854,"avatar_url":"https://avatars.githubusercontent.com/u/16395854?v=3","gravatar_id":"","url":"https://api.github.com/users/stk1m1","html_url":"https://github.com/stk1m1","followers_url":"https://api.github.com/users/stk1m1/followers","following_url":"https://api.github.com/users/stk1m1/following{/other_user}","gists_url":"https://api.github.com/users/stk1m1/gists{/gist_id}","starred_url":"https://api.github.com/users/stk1m1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stk1m1/subscriptions","organizations_url":"https://api.github.com/users/stk1m1/orgs","repos_url":"https://api.github.com/users/stk1m1/repos","events_url":"https://api.github.com/users/stk1m1/events{/privacy}","received_events_url":"https://api.github.com/users/stk1m1/received_events","type":"User","site_admin":false},"body":"This PR fixes followings. \r\n\r\n1. When a column with a smaller index than that of a primary key field gets removed, the primary key field index decrements, which causes a cached primary key index to point a wrong field. \r\n\r\n2. When a primary key field is renamed, primary key table is not updated accordingly.\r\n\r\nCloses #2829. \r\n\r\n@realm/java please review.","created_at":"2016-06-01T12:37:08Z","updated_at":"2016-06-06T11:58:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd9eb0c92945cfe49986a9a69b71cadd78edcc1c","assignee":{"login":"stk1m1","id":16395854,"avatar_url":"https://avatars.githubusercontent.com/u/16395854?v=3","gravatar_id":"","url":"https://api.github.com/users/stk1m1","html_url":"https://github.com/stk1m1","followers_url":"https://api.github.com/users/stk1m1/followers","following_url":"https://api.github.com/users/stk1m1/following{/other_user}","gists_url":"https://api.github.com/users/stk1m1/gists{/gist_id}","starred_url":"https://api.github.com/users/stk1m1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stk1m1/subscriptions","organizations_url":"https://api.github.com/users/stk1m1/orgs","repos_url":"https://api.github.com/users/stk1m1/repos","events_url":"https://api.github.com/users/stk1m1/events{/privacy}","received_events_url":"https://api.github.com/users/stk1m1/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/realm/realm-java/pulls/2920/commits","review_comments_url":"https://api.github.com/repos/realm/realm-java/pulls/2920/comments","review_comment_url":"https://api.github.com/repos/realm/realm-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/realm/realm-java/issues/2920/comments","statuses_url":"https://api.github.com/repos/realm/realm-java/statuses/e29c00e94561defaae41713caf07eb0b638d160c","head":{"label":"realm:stk/bug/migratingpk","ref":"stk/bug/migratingpk","sha":"e29c00e94561defaae41713caf07eb0b638d160c","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":4084908,"name":"realm-java","full_name":"realm/realm-java","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/realm-java","description":"Realm is a mobile database: a replacement for SQLite & ORMs","fork":false,"url":"https://api.github.com/repos/realm/realm-java","forks_url":"https://api.github.com/repos/realm/realm-java/forks","keys_url":"https://api.github.com/repos/realm/realm-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/realm-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/realm-java/teams","hooks_url":"https://api.github.com/repos/realm/realm-java/hooks","issue_events_url":"https://api.github.com/repos/realm/realm-java/issues/events{/number}","events_url":"https://api.github.com/repos/realm/realm-java/events","assignees_url":"https://api.github.com/repos/realm/realm-java/assignees{/user}","branches_url":"https://api.github.com/repos/realm/realm-java/branches{/branch}","tags_url":"https://api.github.com/repos/realm/realm-java/tags","blobs_url":"https://api.github.com/repos/realm/realm-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/realm-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/realm-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/realm-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/realm-java/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/realm-java/languages","stargazers_url":"https://api.github.com/repos/realm/realm-java/stargazers","contributors_url":"https://api.github.com/repos/realm/realm-java/contributors","subscribers_url":"https://api.github.com/repos/realm/realm-java/subscribers","subscription_url":"https://api.github.com/repos/realm/realm-java/subscription","commits_url":"https://api.github.com/repos/realm/realm-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/realm-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/realm-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/realm-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/realm-java/contents/{+path}","compare_url":"https://api.github.com/repos/realm/realm-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/realm-java/merges","archive_url":"https://api.github.com/repos/realm/realm-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/realm-java/downloads","issues_url":"https://api.github.com/repos/realm/realm-java/issues{/number}","pulls_url":"https://api.github.com/repos/realm/realm-java/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/realm-java/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/realm-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/realm-java/labels{/name}","releases_url":"https://api.github.com/repos/realm/realm-java/releases{/id}","deployments_url":"https://api.github.com/repos/realm/realm-java/deployments","created_at":"2012-04-20T09:18:42Z","updated_at":"2016-06-06T10:22:29Z","pushed_at":"2016-06-06T11:42:09Z","git_url":"git://github.com/realm/realm-java.git","ssh_url":"git@github.com:realm/realm-java.git","clone_url":"https://github.com/realm/realm-java.git","svn_url":"https://github.com/realm/realm-java","homepage":"http://realm.io","size":62034,"stargazers_count":5139,"watchers_count":5139,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":674,"mirror_url":null,"open_issues_count":232,"forks":674,"open_issues":232,"watchers":5139,"default_branch":"master"}},"base":{"label":"realm:releases","ref":"releases","sha":"a1e34f996c342ae3e24f92b93687673a99357906","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":4084908,"name":"realm-java","full_name":"realm/realm-java","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/realm-java","description":"Realm is a mobile database: a replacement for SQLite & ORMs","fork":false,"url":"https://api.github.com/repos/realm/realm-java","forks_url":"https://api.github.com/repos/realm/realm-java/forks","keys_url":"https://api.github.com/repos/realm/realm-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/realm-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/realm-java/teams","hooks_url":"https://api.github.com/repos/realm/realm-java/hooks","issue_events_url":"https://api.github.com/repos/realm/realm-java/issues/events{/number}","events_url":"https://api.github.com/repos/realm/realm-java/events","assignees_url":"https://api.github.com/repos/realm/realm-java/assignees{/user}","branches_url":"https://api.github.com/repos/realm/realm-java/branches{/branch}","tags_url":"https://api.github.com/repos/realm/realm-java/tags","blobs_url":"https://api.github.com/repos/realm/realm-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/realm-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/realm-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/realm-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/realm-java/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/realm-java/languages","stargazers_url":"https://api.github.com/repos/realm/realm-java/stargazers","contributors_url":"https://api.github.com/repos/realm/realm-java/contributors","subscribers_url":"https://api.github.com/repos/realm/realm-java/subscribers","subscription_url":"https://api.github.com/repos/realm/realm-java/subscription","commits_url":"https://api.github.com/repos/realm/realm-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/realm-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/realm-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/realm-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/realm-java/contents/{+path}","compare_url":"https://api.github.com/repos/realm/realm-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/realm-java/merges","archive_url":"https://api.github.com/repos/realm/realm-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/realm-java/downloads","issues_url":"https://api.github.com/repos/realm/realm-java/issues{/number}","pulls_url":"https://api.github.com/repos/realm/realm-java/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/realm-java/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/realm-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/realm-java/labels{/name}","releases_url":"https://api.github.com/repos/realm/realm-java/releases{/id}","deployments_url":"https://api.github.com/repos/realm/realm-java/deployments","created_at":"2012-04-20T09:18:42Z","updated_at":"2016-06-06T10:22:29Z","pushed_at":"2016-06-06T11:42:09Z","git_url":"git://github.com/realm/realm-java.git","ssh_url":"git@github.com:realm/realm-java.git","clone_url":"https://github.com/realm/realm-java.git","svn_url":"https://github.com/realm/realm-java","homepage":"http://realm.io","size":62034,"stargazers_count":5139,"watchers_count":5139,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":674,"mirror_url":null,"open_issues_count":232,"forks":674,"open_issues":232,"watchers":5139,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/realm/realm-java/pulls/2920"},"html":{"href":"https://github.com/realm/realm-java/pull/2920"},"issue":{"href":"https://api.github.com/repos/realm/realm-java/issues/2920"},"comments":{"href":"https://api.github.com/repos/realm/realm-java/issues/2920/comments"},"review_comments":{"href":"https://api.github.com/repos/realm/realm-java/pulls/2920/comments"},"review_comment":{"href":"https://api.github.com/repos/realm/realm-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/realm/realm-java/pulls/2920/commits"},"statuses":{"href":"https://api.github.com/repos/realm/realm-java/statuses/e29c00e94561defaae41713caf07eb0b638d160c"}}}}
{"actor":{"display_login":"cmelchior"}}