{"action":"created","issue":{"url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/895","repository_url":"https://api.github.com/repos/voxpupuli/puppet-nginx","labels_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/895/labels{/name}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/895/comments","events_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/895/events","html_url":"https://github.com/voxpupuli/puppet-nginx/issues/895","id":180655944,"number":895,"title":"log_dir works in vhost context, but not in main context","user":{"login":"ubellavance","id":4943465,"avatar_url":"https://avatars.githubusercontent.com/u/4943465?v=3","gravatar_id":"","url":"https://api.github.com/users/ubellavance","html_url":"https://github.com/ubellavance","followers_url":"https://api.github.com/users/ubellavance/followers","following_url":"https://api.github.com/users/ubellavance/following{/other_user}","gists_url":"https://api.github.com/users/ubellavance/gists{/gist_id}","starred_url":"https://api.github.com/users/ubellavance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubellavance/subscriptions","organizations_url":"https://api.github.com/users/ubellavance/orgs","repos_url":"https://api.github.com/users/ubellavance/repos","events_url":"https://api.github.com/users/ubellavance/events{/privacy}","received_events_url":"https://api.github.com/users/ubellavance/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"wyardley","id":10714426,"avatar_url":"https://avatars.githubusercontent.com/u/10714426?v=3","gravatar_id":"","url":"https://api.github.com/users/wyardley","html_url":"https://github.com/wyardley","followers_url":"https://api.github.com/users/wyardley/followers","following_url":"https://api.github.com/users/wyardley/following{/other_user}","gists_url":"https://api.github.com/users/wyardley/gists{/gist_id}","starred_url":"https://api.github.com/users/wyardley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyardley/subscriptions","organizations_url":"https://api.github.com/users/wyardley/orgs","repos_url":"https://api.github.com/users/wyardley/repos","events_url":"https://api.github.com/users/wyardley/events{/privacy}","received_events_url":"https://api.github.com/users/wyardley/received_events","type":"User","site_admin":false},"assignees":[{"login":"wyardley","id":10714426,"avatar_url":"https://avatars.githubusercontent.com/u/10714426?v=3","gravatar_id":"","url":"https://api.github.com/users/wyardley","html_url":"https://github.com/wyardley","followers_url":"https://api.github.com/users/wyardley/followers","following_url":"https://api.github.com/users/wyardley/following{/other_user}","gists_url":"https://api.github.com/users/wyardley/gists{/gist_id}","starred_url":"https://api.github.com/users/wyardley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyardley/subscriptions","organizations_url":"https://api.github.com/users/wyardley/orgs","repos_url":"https://api.github.com/users/wyardley/repos","events_url":"https://api.github.com/users/wyardley/events{/privacy}","received_events_url":"https://api.github.com/users/wyardley/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2016-10-03T14:32:56Z","updated_at":"2016-10-09T16:06:42Z","closed_at":null,"body":"Hi,\r\n\r\nI defined nginx::config::conf_dir and it works perfectly for vhosts (it puts access log in $log_dir/vhostname.access.log), but if we also want to use a different path for the base nginx logs, we have to explicitely define them, even when nginx::config::conf_dir is defined.\r\n\r\nnginx::config::log_dir: '/var/opt/rh/rh-nginx18/log/nginx'\r\nnginx::http_access_log: '/var/opt/rh/rh-nginx18/log/nginx/access.log'\r\nnginx::nginx_error_log: '/var/opt/rh/rh-nginx18/log/nginx/error.log'"},"comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/comments/252495157","html_url":"https://github.com/voxpupuli/puppet-nginx/issues/895#issuecomment-252495157","issue_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/895","id":252495157,"user":{"login":"ubellavance","id":4943465,"avatar_url":"https://avatars.githubusercontent.com/u/4943465?v=3","gravatar_id":"","url":"https://api.github.com/users/ubellavance","html_url":"https://github.com/ubellavance","followers_url":"https://api.github.com/users/ubellavance/followers","following_url":"https://api.github.com/users/ubellavance/following{/other_user}","gists_url":"https://api.github.com/users/ubellavance/gists{/gist_id}","starred_url":"https://api.github.com/users/ubellavance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubellavance/subscriptions","organizations_url":"https://api.github.com/users/ubellavance/orgs","repos_url":"https://api.github.com/users/ubellavance/repos","events_url":"https://api.github.com/users/ubellavance/events{/privacy}","received_events_url":"https://api.github.com/users/ubellavance/received_events","type":"User","site_admin":false},"created_at":"2016-10-09T16:06:42Z","updated_at":"2016-10-09T16:06:42Z","body":"Thanks for the links to releases.  I guess that a release is what is pushed to the forge?\r\n\r\nRegarding the nginx::config namespace, I understand what you are saying but it doesn't seem to be consistent with the code, unless I've got something wrong in my config or there have been many changes in master since the release.\r\n\r\nHere's what I have in the nginx::config namespace:\r\n```\r\nnginx::config::http_cfg_append:\r\nnginx::config::conf_dir: '/etc/opt/rh/rh-nginx18/nginx'\r\nnginx::config::client_body_temp_path: '/var/opt/rh/rh-nginx18/lib/nginx/tmp/client_body'\r\nnginx::config::proxy_temp_path: '/var/opt/rh/rh-nginx18/lib/nginx/tmp/proxy'\r\nnginx::config::vhost_purge: true\r\nnginx::config::confd_purge: true\r\nnginx::config::log_dir: '/var/opt/rh/rh-nginx18/log/nginx'\r\nnginx::config::gzip_types: 'text/plain text/css application/json application/x-javascript text/xml application/xml application/xml+rss text/javascript'\r\n\r\n```Here's what I have in the nginx:: namespace:\r\n```\r\nnginx::worker_processes: 'auto'\r\nnginx::manage_repo: false\r\nnginx::package_name: 'rh-nginx18-nginx'\r\nnginx::pid: '/var/opt/rh/rh-nginx18/run/nginx/nginx.pid'\r\nnginx::http_access_log: '/var/opt/rh/rh-nginx18/log/nginx/access.log'\r\nnginx::nginx_error_log: '/var/opt/rh/rh-nginx18/log/nginx/error.log'\r\nnginx::server_tokens: 'off'\r\nnginx::log_format:\r\nnginx::proxy_connect_timeout: '5400'\r\nnginx::proxy_read_timeout:    '5400'\r\nnginx::proxy_send_timeout:    '5400'\r\nnginx::proxy_hide_header:\r\nnginx::proxy_set_header:\r\nnginx::nginx_vhosts:\r\nnginx::nginx_locations:\r\n```\r\nHonestly, I may not know puppet or nginx enough, but I can't easily make the difference between what needs to be in `nginx::config`\r\n\r\nThanks,"}}
{"actor":{"display_login":"ubellavance"}}