{"action":"created","comment":{"url":"https://api.github.com/repos/cozy/cozy-proxy/pulls/comments/84727354","pull_request_review_id":5486684,"id":84727354,"diff_hunk":"@@ -11,9 +25,29 @@ module.exports = class WelcomeView extends StepView\n     events:\n         'click @ui.next': 'onSubmit'\n \n+\n     onSubmit: (event) ->\n         event.preventDefault()\n-        @model.submit()\n+        @model.submit() unless @isDisabled()\n+        @setDisabled()\n+\n+\n+    setDisabled: ($el = @ui.next) ->\n+        if $el[0].tagName.toLowerCase() in FORMS_DIS_ELEMENTS\n+            $el\n+                .prop 'disabled', true\n+                .attr 'aria-busy', true\n+        else\n+            $el.attr\n+                'aria-disabled': true\n+                'aria-busy':     true\n+\n+\n+    isDisabled: ($el = @ui.next) ->\n+        if $el[0].tagName.toLowerCase() in FORMS_DIS_ELEMENTS","path":"client/app/views/steps/welcome.coffee","position":45,"original_position":45,"commit_id":"69b32a3b93a6cecab0a2184dc54b6218c9fd1280","original_commit_id":"69b32a3b93a6cecab0a2184dc54b6218c9fd1280","user":{"login":"m4dz","id":471486,"avatar_url":"https://avatars.githubusercontent.com/u/471486?v=3","gravatar_id":"","url":"https://api.github.com/users/m4dz","html_url":"https://github.com/m4dz","followers_url":"https://api.github.com/users/m4dz/followers","following_url":"https://api.github.com/users/m4dz/following{/other_user}","gists_url":"https://api.github.com/users/m4dz/gists{/gist_id}","starred_url":"https://api.github.com/users/m4dz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4dz/subscriptions","organizations_url":"https://api.github.com/users/m4dz/orgs","repos_url":"https://api.github.com/users/m4dz/repos","events_url":"https://api.github.com/users/m4dz/events{/privacy}","received_events_url":"https://api.github.com/users/m4dz/received_events","type":"User","site_admin":false},"body":"I understand your argument but I can't figure out if it's really releant or not: using a script like this one, which allaow to submit again, is clearly an volunteer, malintentioned action. I'm not sure if it a good reason to store Ui states in JS instead of using the markup. But your opinion seems reasonnable… I need to think about it a little more…","created_at":"2016-10-24T16:29:36Z","updated_at":"2016-10-24T16:29:36Z","html_url":"https://github.com/cozy/cozy-proxy/pull/321#discussion_r84727354","pull_request_url":"https://api.github.com/repos/cozy/cozy-proxy/pulls/321","_links":{"self":{"href":"https://api.github.com/repos/cozy/cozy-proxy/pulls/comments/84727354"},"html":{"href":"https://github.com/cozy/cozy-proxy/pull/321#discussion_r84727354"},"pull_request":{"href":"https://api.github.com/repos/cozy/cozy-proxy/pulls/321"}}},"pull_request":{"url":"https://api.github.com/repos/cozy/cozy-proxy/pulls/321","id":89594808,"html_url":"https://github.com/cozy/cozy-proxy/pull/321","diff_url":"https://github.com/cozy/cozy-proxy/pull/321.diff","patch_url":"https://github.com/cozy/cozy-proxy/pull/321.patch","issue_url":"https://api.github.com/repos/cozy/cozy-proxy/issues/321","number":321,"state":"open","locked":false,"title":"Add disabled state on next button","user":{"login":"m4dz","id":471486,"avatar_url":"https://avatars.githubusercontent.com/u/471486?v=3","gravatar_id":"","url":"https://api.github.com/users/m4dz","html_url":"https://github.com/m4dz","followers_url":"https://api.github.com/users/m4dz/followers","following_url":"https://api.github.com/users/m4dz/following{/other_user}","gists_url":"https://api.github.com/users/m4dz/gists{/gist_id}","starred_url":"https://api.github.com/users/m4dz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4dz/subscriptions","organizations_url":"https://api.github.com/users/m4dz/orgs","repos_url":"https://api.github.com/users/m4dz/repos","events_url":"https://api.github.com/users/m4dz/events{/privacy}","received_events_url":"https://api.github.com/users/m4dz/received_events","type":"User","site_admin":false},"body":null,"created_at":"2016-10-17T10:10:15Z","updated_at":"2016-10-24T16:29:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87269c62b020f8e0c9743f9dd3bbebef22c95f6b","assignee":{"login":"gregorylegarec","id":776764,"avatar_url":"https://avatars.githubusercontent.com/u/776764?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorylegarec","html_url":"https://github.com/gregorylegarec","followers_url":"https://api.github.com/users/gregorylegarec/followers","following_url":"https://api.github.com/users/gregorylegarec/following{/other_user}","gists_url":"https://api.github.com/users/gregorylegarec/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorylegarec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorylegarec/subscriptions","organizations_url":"https://api.github.com/users/gregorylegarec/orgs","repos_url":"https://api.github.com/users/gregorylegarec/repos","events_url":"https://api.github.com/users/gregorylegarec/events{/privacy}","received_events_url":"https://api.github.com/users/gregorylegarec/received_events","type":"User","site_admin":false},"assignees":[{"login":"gregorylegarec","id":776764,"avatar_url":"https://avatars.githubusercontent.com/u/776764?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorylegarec","html_url":"https://github.com/gregorylegarec","followers_url":"https://api.github.com/users/gregorylegarec/followers","following_url":"https://api.github.com/users/gregorylegarec/following{/other_user}","gists_url":"https://api.github.com/users/gregorylegarec/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorylegarec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorylegarec/subscriptions","organizations_url":"https://api.github.com/users/gregorylegarec/orgs","repos_url":"https://api.github.com/users/gregorylegarec/repos","events_url":"https://api.github.com/users/gregorylegarec/events{/privacy}","received_events_url":"https://api.github.com/users/gregorylegarec/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cozy/cozy-proxy/pulls/321/commits","review_comments_url":"https://api.github.com/repos/cozy/cozy-proxy/pulls/321/comments","review_comment_url":"https://api.github.com/repos/cozy/cozy-proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cozy/cozy-proxy/issues/321/comments","statuses_url":"https://api.github.com/repos/cozy/cozy-proxy/statuses/69b32a3b93a6cecab0a2184dc54b6218c9fd1280","head":{"label":"m4dz:onboarding-welcome-markup","ref":"onboarding-welcome-markup","sha":"69b32a3b93a6cecab0a2184dc54b6218c9fd1280","user":{"login":"m4dz","id":471486,"avatar_url":"https://avatars.githubusercontent.com/u/471486?v=3","gravatar_id":"","url":"https://api.github.com/users/m4dz","html_url":"https://github.com/m4dz","followers_url":"https://api.github.com/users/m4dz/followers","following_url":"https://api.github.com/users/m4dz/following{/other_user}","gists_url":"https://api.github.com/users/m4dz/gists{/gist_id}","starred_url":"https://api.github.com/users/m4dz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4dz/subscriptions","organizations_url":"https://api.github.com/users/m4dz/orgs","repos_url":"https://api.github.com/users/m4dz/repos","events_url":"https://api.github.com/users/m4dz/events{/privacy}","received_events_url":"https://api.github.com/users/m4dz/received_events","type":"User","site_admin":false},"repo":{"id":30074392,"name":"cozy-proxy","full_name":"m4dz/cozy-proxy","owner":{"login":"m4dz","id":471486,"avatar_url":"https://avatars.githubusercontent.com/u/471486?v=3","gravatar_id":"","url":"https://api.github.com/users/m4dz","html_url":"https://github.com/m4dz","followers_url":"https://api.github.com/users/m4dz/followers","following_url":"https://api.github.com/users/m4dz/following{/other_user}","gists_url":"https://api.github.com/users/m4dz/gists{/gist_id}","starred_url":"https://api.github.com/users/m4dz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4dz/subscriptions","organizations_url":"https://api.github.com/users/m4dz/orgs","repos_url":"https://api.github.com/users/m4dz/repos","events_url":"https://api.github.com/users/m4dz/events{/privacy}","received_events_url":"https://api.github.com/users/m4dz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/m4dz/cozy-proxy","description":"Cozy application manager","fork":true,"url":"https://api.github.com/repos/m4dz/cozy-proxy","forks_url":"https://api.github.com/repos/m4dz/cozy-proxy/forks","keys_url":"https://api.github.com/repos/m4dz/cozy-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m4dz/cozy-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m4dz/cozy-proxy/teams","hooks_url":"https://api.github.com/repos/m4dz/cozy-proxy/hooks","issue_events_url":"https://api.github.com/repos/m4dz/cozy-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/m4dz/cozy-proxy/events","assignees_url":"https://api.github.com/repos/m4dz/cozy-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/m4dz/cozy-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/m4dz/cozy-proxy/tags","blobs_url":"https://api.github.com/repos/m4dz/cozy-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m4dz/cozy-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m4dz/cozy-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/m4dz/cozy-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m4dz/cozy-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/m4dz/cozy-proxy/languages","stargazers_url":"https://api.github.com/repos/m4dz/cozy-proxy/stargazers","contributors_url":"https://api.github.com/repos/m4dz/cozy-proxy/contributors","subscribers_url":"https://api.github.com/repos/m4dz/cozy-proxy/subscribers","subscription_url":"https://api.github.com/repos/m4dz/cozy-proxy/subscription","commits_url":"https://api.github.com/repos/m4dz/cozy-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/m4dz/cozy-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/m4dz/cozy-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/m4dz/cozy-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/m4dz/cozy-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/m4dz/cozy-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m4dz/cozy-proxy/merges","archive_url":"https://api.github.com/repos/m4dz/cozy-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m4dz/cozy-proxy/downloads","issues_url":"https://api.github.com/repos/m4dz/cozy-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/m4dz/cozy-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/m4dz/cozy-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/m4dz/cozy-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m4dz/cozy-proxy/labels{/name}","releases_url":"https://api.github.com/repos/m4dz/cozy-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/m4dz/cozy-proxy/deployments","created_at":"2015-01-30T14:05:46Z","updated_at":"2015-01-30T14:05:46Z","pushed_at":"2016-10-17T10:14:28Z","git_url":"git://github.com/m4dz/cozy-proxy.git","ssh_url":"git@github.com:m4dz/cozy-proxy.git","clone_url":"https://github.com/m4dz/cozy-proxy.git","svn_url":"https://github.com/m4dz/cozy-proxy","homepage":"http:/cozy.io","size":7294,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cozy:development","ref":"development","sha":"c158f3d0c87cb1b0c5377d59e4ce0f7e217273ac","user":{"login":"cozy","id":7690525,"avatar_url":"https://avatars.githubusercontent.com/u/7690525?v=3","gravatar_id":"","url":"https://api.github.com/users/cozy","html_url":"https://github.com/cozy","followers_url":"https://api.github.com/users/cozy/followers","following_url":"https://api.github.com/users/cozy/following{/other_user}","gists_url":"https://api.github.com/users/cozy/gists{/gist_id}","starred_url":"https://api.github.com/users/cozy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cozy/subscriptions","organizations_url":"https://api.github.com/users/cozy/orgs","repos_url":"https://api.github.com/users/cozy/repos","events_url":"https://api.github.com/users/cozy/events{/privacy}","received_events_url":"https://api.github.com/users/cozy/received_events","type":"Organization","site_admin":false},"repo":{"id":3812481,"name":"cozy-proxy","full_name":"cozy/cozy-proxy","owner":{"login":"cozy","id":7690525,"avatar_url":"https://avatars.githubusercontent.com/u/7690525?v=3","gravatar_id":"","url":"https://api.github.com/users/cozy","html_url":"https://github.com/cozy","followers_url":"https://api.github.com/users/cozy/followers","following_url":"https://api.github.com/users/cozy/following{/other_user}","gists_url":"https://api.github.com/users/cozy/gists{/gist_id}","starred_url":"https://api.github.com/users/cozy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cozy/subscriptions","organizations_url":"https://api.github.com/users/cozy/orgs","repos_url":"https://api.github.com/users/cozy/repos","events_url":"https://api.github.com/users/cozy/events{/privacy}","received_events_url":"https://api.github.com/users/cozy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cozy/cozy-proxy","description":"Cozy authentication and routing layer","fork":false,"url":"https://api.github.com/repos/cozy/cozy-proxy","forks_url":"https://api.github.com/repos/cozy/cozy-proxy/forks","keys_url":"https://api.github.com/repos/cozy/cozy-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cozy/cozy-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cozy/cozy-proxy/teams","hooks_url":"https://api.github.com/repos/cozy/cozy-proxy/hooks","issue_events_url":"https://api.github.com/repos/cozy/cozy-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/cozy/cozy-proxy/events","assignees_url":"https://api.github.com/repos/cozy/cozy-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/cozy/cozy-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/cozy/cozy-proxy/tags","blobs_url":"https://api.github.com/repos/cozy/cozy-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cozy/cozy-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cozy/cozy-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/cozy/cozy-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cozy/cozy-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/cozy/cozy-proxy/languages","stargazers_url":"https://api.github.com/repos/cozy/cozy-proxy/stargazers","contributors_url":"https://api.github.com/repos/cozy/cozy-proxy/contributors","subscribers_url":"https://api.github.com/repos/cozy/cozy-proxy/subscribers","subscription_url":"https://api.github.com/repos/cozy/cozy-proxy/subscription","commits_url":"https://api.github.com/repos/cozy/cozy-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/cozy/cozy-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/cozy/cozy-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/cozy/cozy-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/cozy/cozy-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/cozy/cozy-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cozy/cozy-proxy/merges","archive_url":"https://api.github.com/repos/cozy/cozy-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cozy/cozy-proxy/downloads","issues_url":"https://api.github.com/repos/cozy/cozy-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/cozy/cozy-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/cozy/cozy-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/cozy/cozy-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cozy/cozy-proxy/labels{/name}","releases_url":"https://api.github.com/repos/cozy/cozy-proxy/releases{/id}","deployments_url":"https://api.github.com/repos/cozy/cozy-proxy/deployments","created_at":"2012-03-23T20:53:26Z","updated_at":"2016-10-03T14:31:10Z","pushed_at":"2016-10-24T15:31:38Z","git_url":"git://github.com/cozy/cozy-proxy.git","ssh_url":"git@github.com:cozy/cozy-proxy.git","clone_url":"https://github.com/cozy/cozy-proxy.git","svn_url":"https://github.com/cozy/cozy-proxy","homepage":"https://cozy.io","size":8007,"stargazers_count":29,"watchers_count":29,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":30,"forks":35,"open_issues":30,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cozy/cozy-proxy/pulls/321"},"html":{"href":"https://github.com/cozy/cozy-proxy/pull/321"},"issue":{"href":"https://api.github.com/repos/cozy/cozy-proxy/issues/321"},"comments":{"href":"https://api.github.com/repos/cozy/cozy-proxy/issues/321/comments"},"review_comments":{"href":"https://api.github.com/repos/cozy/cozy-proxy/pulls/321/comments"},"review_comment":{"href":"https://api.github.com/repos/cozy/cozy-proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cozy/cozy-proxy/pulls/321/commits"},"statuses":{"href":"https://api.github.com/repos/cozy/cozy-proxy/statuses/69b32a3b93a6cecab0a2184dc54b6218c9fd1280"}}}}
{"actor":{"display_login":"m4dz"}}