{"action":"created","issue":{"url":"https://api.github.com/repos/sourcelair/xterm.js/issues/197","repository_url":"https://api.github.com/repos/sourcelair/xterm.js","labels_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/197/labels{/name}","comments_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/197/comments","events_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/197/events","html_url":"https://github.com/sourcelair/xterm.js/issues/197","id":166404769,"number":197,"title":"Proposal: adopt semantic versioning rules and postpone 1.0.0 release","user":{"login":"jerch","id":6193135,"avatar_url":"https://avatars.githubusercontent.com/u/6193135?v=3","gravatar_id":"","url":"https://api.github.com/users/jerch","html_url":"https://github.com/jerch","followers_url":"https://api.github.com/users/jerch/followers","following_url":"https://api.github.com/users/jerch/following{/other_user}","gists_url":"https://api.github.com/users/jerch/gists{/gist_id}","starred_url":"https://api.github.com/users/jerch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerch/subscriptions","organizations_url":"https://api.github.com/users/jerch/orgs","repos_url":"https://api.github.com/users/jerch/repos","events_url":"https://api.github.com/users/jerch/events{/privacy}","received_events_url":"https://api.github.com/users/jerch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-19T18:42:29Z","updated_at":"2016-07-19T19:12:01Z","closed_at":null,"body":"Semantic versioning is a great way for peeps to get an idea of the state of some piece of software. Since xterm.js will have some impact in the node and browser world Im suggesting to adopt rules from semantic versioning to give the audience a chance to catch the actual state of xterm.js and its development.\r\n\r\nTo phrase it differently - is xterm.js ready for a 1.0.0. release yet?\r\n\r\nI have to admit that I would expect at least the following for a so called stable release:\r\n- at least 95% test coverage (not a good marker for a parser driven piece of software since it will neglect the edge cases, but better than nothing)\r\n- if there is a demo, it should work (the demo still has many glitches)\r\n- 95% documentation of exported features (API and stuff)\r\n- somewhat stable (no big refactoring in sight including API changes)\r\n\r\nIf you like the idea of adopting semantic versioning I propose to leave the 1.0.0 version idea and change it to an interim beta release with some minor version number. This would lower the burden to maintain a stable release with already known flaws and give time to focus on the problems at hand like refactoring and test coverage."},"comment":{"url":"https://api.github.com/repos/sourcelair/xterm.js/issues/comments/233735511","html_url":"https://github.com/sourcelair/xterm.js/issues/197#issuecomment-233735511","issue_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/197","id":233735511,"user":{"login":"Tyriar","id":2193314,"avatar_url":"https://avatars.githubusercontent.com/u/2193314?v=3","gravatar_id":"","url":"https://api.github.com/users/Tyriar","html_url":"https://github.com/Tyriar","followers_url":"https://api.github.com/users/Tyriar/followers","following_url":"https://api.github.com/users/Tyriar/following{/other_user}","gists_url":"https://api.github.com/users/Tyriar/gists{/gist_id}","starred_url":"https://api.github.com/users/Tyriar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tyriar/subscriptions","organizations_url":"https://api.github.com/users/Tyriar/orgs","repos_url":"https://api.github.com/users/Tyriar/repos","events_url":"https://api.github.com/users/Tyriar/events{/privacy}","received_events_url":"https://api.github.com/users/Tyriar/received_events","type":"User","site_admin":false},"created_at":"2016-07-19T19:12:01Z","updated_at":"2016-07-19T19:12:01Z","body":"v1 doesn't necessarily mean everything is amazing. If anything a v1 release would *enable* semantic versioning to do what it does which would be helpful for consumers as the API will not get any *breaking* changes until there is another major version bump. Before v1, API breakages are disregarded as the API is seen as unstable, meaning consumers need to lock against the patch version, not the minor version. Also as far as I can tell, there haven't really been any breaking changes recently, only fixes and additions.\r\n\r\nThat being said, it may make sense to backtrack until discussions that I just started today, https://github.com/sourcelair/xterm.js/issues/195 and https://github.com/sourcelair/xterm.js/pull/196 are resolved. I do not think the lack of tests is a reason not to do a v1 release though, tests and documentation can be continuously improved in minor/patch releases."}}
{"actor":{"display_login":"Tyriar"}}