{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/64136372","id":64136372,"diff_hunk":"@@ -169,6 +169,23 @@ func findNodesThatFit(pod *api.Pod, nodeNameToInfo map[string]*schedulercache.No\n \t\t\tif err != nil {\n \t\t\t\treturn api.NodeList{}, FailedPredicateMap{}, err\n \t\t\t}\n+\t\t\t//add the extender failed info to failedPredicateMap\n+\t\t\tfor _, filteredNode := range filtered {","path":"plugin/pkg/scheduler/generic_scheduler.go","position":5,"original_position":5,"commit_id":"9634d813473535b01ae852f1b97cc7b7be08ee44","original_commit_id":"0a2401bcf22544dbe4f09b1b6929c4862a2439e5","user":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"body":"This is already running in generic scheduler for every extenders! It should just require the interface to return it.\r\nAn extender can return nil or empty if unnecessary.","created_at":"2016-05-21T15:54:13Z","updated_at":"2016-05-21T15:54:13Z","html_url":"https://github.com/kubernetes/kubernetes/pull/25797#discussion_r64136372","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25797","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/64136372"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25797#discussion_r64136372"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25797"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25797","id":70500156,"html_url":"https://github.com/kubernetes/kubernetes/pull/25797","diff_url":"https://github.com/kubernetes/kubernetes/pull/25797.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/25797.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25797","number":25797,"state":"open","locked":false,"title":"Add extenders information to “failedPredicateMap” in findNodesThatFit","user":{"login":"ping035627","id":17894459,"avatar_url":"https://avatars.githubusercontent.com/u/17894459?v=3","gravatar_id":"","url":"https://api.github.com/users/ping035627","html_url":"https://github.com/ping035627","followers_url":"https://api.github.com/users/ping035627/followers","following_url":"https://api.github.com/users/ping035627/following{/other_user}","gists_url":"https://api.github.com/users/ping035627/gists{/gist_id}","starred_url":"https://api.github.com/users/ping035627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ping035627/subscriptions","organizations_url":"https://api.github.com/users/ping035627/orgs","repos_url":"https://api.github.com/users/ping035627/repos","events_url":"https://api.github.com/users/ping035627/events{/privacy}","received_events_url":"https://api.github.com/users/ping035627/received_events","type":"User","site_admin":false},"body":"When all the filtered nodes that passed \"predicateFuncs\" don’t pass the extenders filter, the failedPredicateMap hasn’t the extenders information, should add it, I think. So when the length of the “filteredNodes.Items” is 0, we can know the integral information. (The length of the “filteredNodes.Items” is 0, may be because the extenders filter failed.)","created_at":"2016-05-18T10:03:47Z","updated_at":"2016-05-21T15:54:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29e3ddafb50b0bc8baf96e6d9b670d647604d7dd","assignee":{"login":"davidopp","id":8264113,"avatar_url":"https://avatars.githubusercontent.com/u/8264113?v=3","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25797/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25797/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25797/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/9634d813473535b01ae852f1b97cc7b7be08ee44","head":{"label":"ping035627:ping035627-patch-1","ref":"ping035627-patch-1","sha":"9634d813473535b01ae852f1b97cc7b7be08ee44","user":{"login":"ping035627","id":17894459,"avatar_url":"https://avatars.githubusercontent.com/u/17894459?v=3","gravatar_id":"","url":"https://api.github.com/users/ping035627","html_url":"https://github.com/ping035627","followers_url":"https://api.github.com/users/ping035627/followers","following_url":"https://api.github.com/users/ping035627/following{/other_user}","gists_url":"https://api.github.com/users/ping035627/gists{/gist_id}","starred_url":"https://api.github.com/users/ping035627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ping035627/subscriptions","organizations_url":"https://api.github.com/users/ping035627/orgs","repos_url":"https://api.github.com/users/ping035627/repos","events_url":"https://api.github.com/users/ping035627/events{/privacy}","received_events_url":"https://api.github.com/users/ping035627/received_events","type":"User","site_admin":false},"repo":{"id":59103826,"name":"kubernetes","full_name":"ping035627/kubernetes","owner":{"login":"ping035627","id":17894459,"avatar_url":"https://avatars.githubusercontent.com/u/17894459?v=3","gravatar_id":"","url":"https://api.github.com/users/ping035627","html_url":"https://github.com/ping035627","followers_url":"https://api.github.com/users/ping035627/followers","following_url":"https://api.github.com/users/ping035627/following{/other_user}","gists_url":"https://api.github.com/users/ping035627/gists{/gist_id}","starred_url":"https://api.github.com/users/ping035627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ping035627/subscriptions","organizations_url":"https://api.github.com/users/ping035627/orgs","repos_url":"https://api.github.com/users/ping035627/repos","events_url":"https://api.github.com/users/ping035627/events{/privacy}","received_events_url":"https://api.github.com/users/ping035627/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ping035627/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/ping035627/kubernetes","forks_url":"https://api.github.com/repos/ping035627/kubernetes/forks","keys_url":"https://api.github.com/repos/ping035627/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ping035627/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ping035627/kubernetes/teams","hooks_url":"https://api.github.com/repos/ping035627/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/ping035627/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/ping035627/kubernetes/events","assignees_url":"https://api.github.com/repos/ping035627/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/ping035627/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/ping035627/kubernetes/tags","blobs_url":"https://api.github.com/repos/ping035627/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ping035627/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ping035627/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/ping035627/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ping035627/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/ping035627/kubernetes/languages","stargazers_url":"https://api.github.com/repos/ping035627/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/ping035627/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/ping035627/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/ping035627/kubernetes/subscription","commits_url":"https://api.github.com/repos/ping035627/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/ping035627/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/ping035627/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/ping035627/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/ping035627/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/ping035627/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ping035627/kubernetes/merges","archive_url":"https://api.github.com/repos/ping035627/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ping035627/kubernetes/downloads","issues_url":"https://api.github.com/repos/ping035627/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/ping035627/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/ping035627/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/ping035627/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ping035627/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/ping035627/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/ping035627/kubernetes/deployments","created_at":"2016-05-18T09:57:33Z","updated_at":"2016-05-18T09:57:48Z","pushed_at":"2016-05-21T03:36:04Z","git_url":"git://github.com/ping035627/kubernetes.git","ssh_url":"git@github.com:ping035627/kubernetes.git","clone_url":"https://github.com/ping035627/kubernetes.git","svn_url":"https://github.com/ping035627/kubernetes","homepage":"http://kubernetes.io","size":226432,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"5ffebfa3035d6db82d9e2825f97177731cd84e4f","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-05-21T15:24:11Z","pushed_at":"2016-05-21T15:53:22Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":445073,"stargazers_count":14486,"watchers_count":14486,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4397,"mirror_url":null,"open_issues_count":3606,"forks":4397,"open_issues":3606,"watchers":14486,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25797"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25797"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25797"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25797/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25797/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25797/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/9634d813473535b01ae852f1b97cc7b7be08ee44"}}}}
{"actor":{"display_login":"hongchaodeng"}}