{"action":"opened","number":10,"pull_request":{"url":"https://api.github.com/repos/Snyk/broker/pulls/10","id":88366770,"html_url":"https://github.com/Snyk/broker/pull/10","diff_url":"https://github.com/Snyk/broker/pull/10.diff","patch_url":"https://github.com/Snyk/broker/pull/10.patch","issue_url":"https://api.github.com/repos/Snyk/broker/issues/10","number":10,"state":"open","locked":false,"title":"feat: support yaml config","user":{"login":"iameugenejo","id":1054824,"avatar_url":"https://avatars.githubusercontent.com/u/1054824?v=3","gravatar_id":"","url":"https://api.github.com/users/iameugenejo","html_url":"https://github.com/iameugenejo","followers_url":"https://api.github.com/users/iameugenejo/followers","following_url":"https://api.github.com/users/iameugenejo/following{/other_user}","gists_url":"https://api.github.com/users/iameugenejo/gists{/gist_id}","starred_url":"https://api.github.com/users/iameugenejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iameugenejo/subscriptions","organizations_url":"https://api.github.com/users/iameugenejo/orgs","repos_url":"https://api.github.com/users/iameugenejo/repos","events_url":"https://api.github.com/users/iameugenejo/events{/privacy}","received_events_url":"https://api.github.com/users/iameugenejo/received_events","type":"User","site_admin":false},"body":"- [ ] Ready for review\r\n- [ ] Follows CONTRIBUTING rules\r\n- [ ] Reviewed by @ … (Snyk internal team)\r\n\r\n#### What does this PR do?\r\nIt supports yaml config parsing in addition to js/json config parsing\r\n\r\n#### Where should the reviewer start?\r\n`lib/index.js`\r\n\r\n#### How should this be manually tested?\r\n- `npm install` to install js-yaml\r\n- copy and convert existing json config into yaml config\r\n- `npm start` and observe the config being loaded\r\n\r\n#### Any background context you want to provide?\r\nCommenting is allowed in yaml files which is a huge advantage over using json files.\r\n\r\n#### What are the relevant tickets?\r\n#7 \r\n\r\n#### Screenshots\r\nN/A\r\n\r\n#### Additional questions\r\nN/A\r\n","created_at":"2016-10-07T01:00:31Z","updated_at":"2016-10-07T01:00:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Snyk/broker/pulls/10/commits","review_comments_url":"https://api.github.com/repos/Snyk/broker/pulls/10/comments","review_comment_url":"https://api.github.com/repos/Snyk/broker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Snyk/broker/issues/10/comments","statuses_url":"https://api.github.com/repos/Snyk/broker/statuses/578db042038fad18a21e1ce59cd0bbf783f3e509","head":{"label":"iameugenejo:develop","ref":"develop","sha":"578db042038fad18a21e1ce59cd0bbf783f3e509","user":{"login":"iameugenejo","id":1054824,"avatar_url":"https://avatars.githubusercontent.com/u/1054824?v=3","gravatar_id":"","url":"https://api.github.com/users/iameugenejo","html_url":"https://github.com/iameugenejo","followers_url":"https://api.github.com/users/iameugenejo/followers","following_url":"https://api.github.com/users/iameugenejo/following{/other_user}","gists_url":"https://api.github.com/users/iameugenejo/gists{/gist_id}","starred_url":"https://api.github.com/users/iameugenejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iameugenejo/subscriptions","organizations_url":"https://api.github.com/users/iameugenejo/orgs","repos_url":"https://api.github.com/users/iameugenejo/repos","events_url":"https://api.github.com/users/iameugenejo/events{/privacy}","received_events_url":"https://api.github.com/users/iameugenejo/received_events","type":"User","site_admin":false},"repo":{"id":70204079,"name":"broker","full_name":"iameugenejo/broker","owner":{"login":"iameugenejo","id":1054824,"avatar_url":"https://avatars.githubusercontent.com/u/1054824?v=3","gravatar_id":"","url":"https://api.github.com/users/iameugenejo","html_url":"https://github.com/iameugenejo","followers_url":"https://api.github.com/users/iameugenejo/followers","following_url":"https://api.github.com/users/iameugenejo/following{/other_user}","gists_url":"https://api.github.com/users/iameugenejo/gists{/gist_id}","starred_url":"https://api.github.com/users/iameugenejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iameugenejo/subscriptions","organizations_url":"https://api.github.com/users/iameugenejo/orgs","repos_url":"https://api.github.com/users/iameugenejo/repos","events_url":"https://api.github.com/users/iameugenejo/events{/privacy}","received_events_url":"https://api.github.com/users/iameugenejo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iameugenejo/broker","description":"A broker system between a public service and a private service","fork":true,"url":"https://api.github.com/repos/iameugenejo/broker","forks_url":"https://api.github.com/repos/iameugenejo/broker/forks","keys_url":"https://api.github.com/repos/iameugenejo/broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iameugenejo/broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iameugenejo/broker/teams","hooks_url":"https://api.github.com/repos/iameugenejo/broker/hooks","issue_events_url":"https://api.github.com/repos/iameugenejo/broker/issues/events{/number}","events_url":"https://api.github.com/repos/iameugenejo/broker/events","assignees_url":"https://api.github.com/repos/iameugenejo/broker/assignees{/user}","branches_url":"https://api.github.com/repos/iameugenejo/broker/branches{/branch}","tags_url":"https://api.github.com/repos/iameugenejo/broker/tags","blobs_url":"https://api.github.com/repos/iameugenejo/broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iameugenejo/broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iameugenejo/broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/iameugenejo/broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iameugenejo/broker/statuses/{sha}","languages_url":"https://api.github.com/repos/iameugenejo/broker/languages","stargazers_url":"https://api.github.com/repos/iameugenejo/broker/stargazers","contributors_url":"https://api.github.com/repos/iameugenejo/broker/contributors","subscribers_url":"https://api.github.com/repos/iameugenejo/broker/subscribers","subscription_url":"https://api.github.com/repos/iameugenejo/broker/subscription","commits_url":"https://api.github.com/repos/iameugenejo/broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/iameugenejo/broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/iameugenejo/broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/iameugenejo/broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/iameugenejo/broker/contents/{+path}","compare_url":"https://api.github.com/repos/iameugenejo/broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iameugenejo/broker/merges","archive_url":"https://api.github.com/repos/iameugenejo/broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iameugenejo/broker/downloads","issues_url":"https://api.github.com/repos/iameugenejo/broker/issues{/number}","pulls_url":"https://api.github.com/repos/iameugenejo/broker/pulls{/number}","milestones_url":"https://api.github.com/repos/iameugenejo/broker/milestones{/number}","notifications_url":"https://api.github.com/repos/iameugenejo/broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iameugenejo/broker/labels{/name}","releases_url":"https://api.github.com/repos/iameugenejo/broker/releases{/id}","deployments_url":"https://api.github.com/repos/iameugenejo/broker/deployments","created_at":"2016-10-07T00:39:24Z","updated_at":"2016-10-07T00:39:27Z","pushed_at":"2016-10-07T00:54:11Z","git_url":"git://github.com/iameugenejo/broker.git","ssh_url":"git@github.com:iameugenejo/broker.git","clone_url":"https://github.com/iameugenejo/broker.git","svn_url":"https://github.com/iameugenejo/broker","homepage":"","size":127,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Snyk:develop","ref":"develop","sha":"9082fff37a057cacd7c7db1e17806e1e941a83fd","user":{"login":"Snyk","id":12959162,"avatar_url":"https://avatars.githubusercontent.com/u/12959162?v=3","gravatar_id":"","url":"https://api.github.com/users/Snyk","html_url":"https://github.com/Snyk","followers_url":"https://api.github.com/users/Snyk/followers","following_url":"https://api.github.com/users/Snyk/following{/other_user}","gists_url":"https://api.github.com/users/Snyk/gists{/gist_id}","starred_url":"https://api.github.com/users/Snyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snyk/subscriptions","organizations_url":"https://api.github.com/users/Snyk/orgs","repos_url":"https://api.github.com/users/Snyk/repos","events_url":"https://api.github.com/users/Snyk/events{/privacy}","received_events_url":"https://api.github.com/users/Snyk/received_events","type":"Organization","site_admin":false},"repo":{"id":65483017,"name":"broker","full_name":"Snyk/broker","owner":{"login":"Snyk","id":12959162,"avatar_url":"https://avatars.githubusercontent.com/u/12959162?v=3","gravatar_id":"","url":"https://api.github.com/users/Snyk","html_url":"https://github.com/Snyk","followers_url":"https://api.github.com/users/Snyk/followers","following_url":"https://api.github.com/users/Snyk/following{/other_user}","gists_url":"https://api.github.com/users/Snyk/gists{/gist_id}","starred_url":"https://api.github.com/users/Snyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snyk/subscriptions","organizations_url":"https://api.github.com/users/Snyk/orgs","repos_url":"https://api.github.com/users/Snyk/repos","events_url":"https://api.github.com/users/Snyk/events{/privacy}","received_events_url":"https://api.github.com/users/Snyk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Snyk/broker","description":"A broker system between a public service and a private service","fork":false,"url":"https://api.github.com/repos/Snyk/broker","forks_url":"https://api.github.com/repos/Snyk/broker/forks","keys_url":"https://api.github.com/repos/Snyk/broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Snyk/broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Snyk/broker/teams","hooks_url":"https://api.github.com/repos/Snyk/broker/hooks","issue_events_url":"https://api.github.com/repos/Snyk/broker/issues/events{/number}","events_url":"https://api.github.com/repos/Snyk/broker/events","assignees_url":"https://api.github.com/repos/Snyk/broker/assignees{/user}","branches_url":"https://api.github.com/repos/Snyk/broker/branches{/branch}","tags_url":"https://api.github.com/repos/Snyk/broker/tags","blobs_url":"https://api.github.com/repos/Snyk/broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Snyk/broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Snyk/broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/Snyk/broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Snyk/broker/statuses/{sha}","languages_url":"https://api.github.com/repos/Snyk/broker/languages","stargazers_url":"https://api.github.com/repos/Snyk/broker/stargazers","contributors_url":"https://api.github.com/repos/Snyk/broker/contributors","subscribers_url":"https://api.github.com/repos/Snyk/broker/subscribers","subscription_url":"https://api.github.com/repos/Snyk/broker/subscription","commits_url":"https://api.github.com/repos/Snyk/broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/Snyk/broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/Snyk/broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/Snyk/broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/Snyk/broker/contents/{+path}","compare_url":"https://api.github.com/repos/Snyk/broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Snyk/broker/merges","archive_url":"https://api.github.com/repos/Snyk/broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Snyk/broker/downloads","issues_url":"https://api.github.com/repos/Snyk/broker/issues{/number}","pulls_url":"https://api.github.com/repos/Snyk/broker/pulls{/number}","milestones_url":"https://api.github.com/repos/Snyk/broker/milestones{/number}","notifications_url":"https://api.github.com/repos/Snyk/broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Snyk/broker/labels{/name}","releases_url":"https://api.github.com/repos/Snyk/broker/releases{/id}","deployments_url":"https://api.github.com/repos/Snyk/broker/deployments","created_at":"2016-08-11T16:05:13Z","updated_at":"2016-09-26T12:05:15Z","pushed_at":"2016-10-07T01:00:31Z","git_url":"git://github.com/Snyk/broker.git","ssh_url":"git@github.com:Snyk/broker.git","clone_url":"https://github.com/Snyk/broker.git","svn_url":"https://github.com/Snyk/broker","homepage":"","size":127,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Snyk/broker/pulls/10"},"html":{"href":"https://github.com/Snyk/broker/pull/10"},"issue":{"href":"https://api.github.com/repos/Snyk/broker/issues/10"},"comments":{"href":"https://api.github.com/repos/Snyk/broker/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/Snyk/broker/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/Snyk/broker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Snyk/broker/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/Snyk/broker/statuses/578db042038fad18a21e1ce59cd0bbf783f3e509"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":11,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"iameugenejo"}}