{"action":"created","issue":{"url":"https://api.github.com/repos/open-craft/opencraft/issues/48","repository_url":"https://api.github.com/repos/open-craft/opencraft","labels_url":"https://api.github.com/repos/open-craft/opencraft/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/open-craft/opencraft/issues/48/comments","events_url":"https://api.github.com/repos/open-craft/opencraft/issues/48/events","html_url":"https://github.com/open-craft/opencraft/pull/48","id":142912169,"number":48,"title":"Clean temporary directories left from previous provisioning runs.","user":{"login":"jbzdak","id":112872,"avatar_url":"https://avatars.githubusercontent.com/u/112872?v=3","gravatar_id":"","url":"https://api.github.com/users/jbzdak","html_url":"https://github.com/jbzdak","followers_url":"https://api.github.com/users/jbzdak/followers","following_url":"https://api.github.com/users/jbzdak/following{/other_user}","gists_url":"https://api.github.com/users/jbzdak/gists{/gist_id}","starred_url":"https://api.github.com/users/jbzdak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbzdak/subscriptions","organizations_url":"https://api.github.com/users/jbzdak/orgs","repos_url":"https://api.github.com/users/jbzdak/repos","events_url":"https://api.github.com/users/jbzdak/events{/privacy}","received_events_url":"https://api.github.com/users/jbzdak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-23T09:47:58Z","updated_at":"2016-03-25T10:39:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/open-craft/opencraft/pulls/48","html_url":"https://github.com/open-craft/opencraft/pull/48","diff_url":"https://github.com/open-craft/opencraft/pull/48.diff","patch_url":"https://github.com/open-craft/opencraft/pull/48.patch"},"body":"# Reproduce steps\r\n\r\n1. Install IM and setup environment settings\r\n2. Go to `/localhost/admin` and create an instance. \r\n3. Wait until provisioning is started\r\n4. Log in to shell account to you vagrant instance ``vagrant ssh`` and go to ``/tmp`` dir. Note that quite a lot of folders was created. \r\n5. Run ``ps -aef | grep python``, and kill the ansible process (killing step is not-neccessary, as venv's are not deleted at all, but it makes it faster)\r\n6. Due to the fact provisioning is restarted you might need to kill it three times. \r\n7. Note that some of the folders in ``/tmp`` are not deleted. There should be as many folders left as many propositioning runs you started, these folders contain virtualenvs created during provisioning runs. \r\n8. (For bonus points) If you kill ansible in a \"proper\" moment it will left a tmp file with a role contents.\r\n\r\n# Verification steps\r\n\r\n1. Repeat the procedure and note that virtualenves are removes\r\n2. (For bonus points) Note that ansible role files are not being left over. \r\n3. (For bonus points) Check also that it works for full provisionings (that is if you provision succesfully the sandbox all temporary files/folders are deleted). "},"comment":{"url":"https://api.github.com/repos/open-craft/opencraft/issues/comments/201236223","html_url":"https://github.com/open-craft/opencraft/pull/48#issuecomment-201236223","issue_url":"https://api.github.com/repos/open-craft/opencraft/issues/48","id":201236223,"user":{"login":"omarkhan","id":793379,"avatar_url":"https://avatars.githubusercontent.com/u/793379?v=3","gravatar_id":"","url":"https://api.github.com/users/omarkhan","html_url":"https://github.com/omarkhan","followers_url":"https://api.github.com/users/omarkhan/followers","following_url":"https://api.github.com/users/omarkhan/following{/other_user}","gists_url":"https://api.github.com/users/omarkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/omarkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarkhan/subscriptions","organizations_url":"https://api.github.com/users/omarkhan/orgs","repos_url":"https://api.github.com/users/omarkhan/repos","events_url":"https://api.github.com/users/omarkhan/events{/privacy}","received_events_url":"https://api.github.com/users/omarkhan/received_events","type":"User","site_admin":false},"created_at":"2016-03-25T10:39:51Z","updated_at":"2016-03-25T10:39:51Z","body":"@jbzdak I had a look through the diff, looks great. See my comments on the diff. I'm going to test this manually now..."}}