{"action":"created","comment":{"url":"https://api.github.com/repos/guzzle/oauth-subscriber/pulls/comments/93722615","pull_request_review_id":14256372,"id":93722615,"diff_hunk":"@@ -257,8 +258,14 @@ private function signUsingRsaSha1($baseString)\n                 . 'requires the OpenSSL extension.');\n         }\n \n+        if (isset($this->config['private_key'])) {\n+            $privateKeyData = $this->config['private_key'];\n+        } else {\n+            $privateKeyData = file_get_contents($this->config['private_key_file']);\n+        }","path":"src/Oauth1.php","position":16,"original_position":16,"commit_id":"ff63e9727e08471fbf435d878f03624d92be979d","original_commit_id":"ff63e9727e08471fbf435d878f03624d92be979d","user":{"login":"sagikazarmark","id":1226384,"avatar_url":"https://avatars.githubusercontent.com/u/1226384?v=3","gravatar_id":"","url":"https://api.github.com/users/sagikazarmark","html_url":"https://github.com/sagikazarmark","followers_url":"https://api.github.com/users/sagikazarmark/followers","following_url":"https://api.github.com/users/sagikazarmark/following{/other_user}","gists_url":"https://api.github.com/users/sagikazarmark/gists{/gist_id}","starred_url":"https://api.github.com/users/sagikazarmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagikazarmark/subscriptions","organizations_url":"https://api.github.com/users/sagikazarmark/orgs","repos_url":"https://api.github.com/users/sagikazarmark/repos","events_url":"https://api.github.com/users/sagikazarmark/events{/privacy}","received_events_url":"https://api.github.com/users/sagikazarmark/received_events","type":"User","site_admin":false},"body":"I think it makes sense to have a check like this: https://github.com/guzzle/oauth-subscriber/pull/55/files#diff-b39c1f44cc7e5e46b562bae636876623R266 WDYT?","created_at":"2016-12-23T01:38:56Z","updated_at":"2016-12-23T01:39:25Z","html_url":"https://github.com/guzzle/oauth-subscriber/pull/57#discussion_r93722615","pull_request_url":"https://api.github.com/repos/guzzle/oauth-subscriber/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/guzzle/oauth-subscriber/pulls/comments/93722615"},"html":{"href":"https://github.com/guzzle/oauth-subscriber/pull/57#discussion_r93722615"},"pull_request":{"href":"https://api.github.com/repos/guzzle/oauth-subscriber/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/guzzle/oauth-subscriber/pulls/57","id":92936629,"html_url":"https://github.com/guzzle/oauth-subscriber/pull/57","diff_url":"https://github.com/guzzle/oauth-subscriber/pull/57.diff","patch_url":"https://github.com/guzzle/oauth-subscriber/pull/57.patch","issue_url":"https://api.github.com/repos/guzzle/oauth-subscriber/issues/57","number":57,"state":"open","locked":false,"title":"Added option to supply private key as a string","user":{"login":"spamoom","id":99203,"avatar_url":"https://avatars.githubusercontent.com/u/99203?v=3","gravatar_id":"","url":"https://api.github.com/users/spamoom","html_url":"https://github.com/spamoom","followers_url":"https://api.github.com/users/spamoom/followers","following_url":"https://api.github.com/users/spamoom/following{/other_user}","gists_url":"https://api.github.com/users/spamoom/gists{/gist_id}","starred_url":"https://api.github.com/users/spamoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spamoom/subscriptions","organizations_url":"https://api.github.com/users/spamoom/orgs","repos_url":"https://api.github.com/users/spamoom/repos","events_url":"https://api.github.com/users/spamoom/events{/privacy}","received_events_url":"https://api.github.com/users/spamoom/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-09T10:20:30Z","updated_at":"2016-12-23T01:39:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f0da64941d541805c23745daa9f79da4d3b98cf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/guzzle/oauth-subscriber/pulls/57/commits","review_comments_url":"https://api.github.com/repos/guzzle/oauth-subscriber/pulls/57/comments","review_comment_url":"https://api.github.com/repos/guzzle/oauth-subscriber/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guzzle/oauth-subscriber/issues/57/comments","statuses_url":"https://api.github.com/repos/guzzle/oauth-subscriber/statuses/ff63e9727e08471fbf435d878f03624d92be979d","head":{"label":"spamoom:string_private_key","ref":"string_private_key","sha":"ff63e9727e08471fbf435d878f03624d92be979d","user":{"login":"spamoom","id":99203,"avatar_url":"https://avatars.githubusercontent.com/u/99203?v=3","gravatar_id":"","url":"https://api.github.com/users/spamoom","html_url":"https://github.com/spamoom","followers_url":"https://api.github.com/users/spamoom/followers","following_url":"https://api.github.com/users/spamoom/following{/other_user}","gists_url":"https://api.github.com/users/spamoom/gists{/gist_id}","starred_url":"https://api.github.com/users/spamoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spamoom/subscriptions","organizations_url":"https://api.github.com/users/spamoom/orgs","repos_url":"https://api.github.com/users/spamoom/repos","events_url":"https://api.github.com/users/spamoom/events{/privacy}","received_events_url":"https://api.github.com/users/spamoom/received_events","type":"User","site_admin":false},"repo":{"id":73120503,"name":"oauth-subscriber","full_name":"spamoom/oauth-subscriber","owner":{"login":"spamoom","id":99203,"avatar_url":"https://avatars.githubusercontent.com/u/99203?v=3","gravatar_id":"","url":"https://api.github.com/users/spamoom","html_url":"https://github.com/spamoom","followers_url":"https://api.github.com/users/spamoom/followers","following_url":"https://api.github.com/users/spamoom/following{/other_user}","gists_url":"https://api.github.com/users/spamoom/gists{/gist_id}","starred_url":"https://api.github.com/users/spamoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spamoom/subscriptions","organizations_url":"https://api.github.com/users/spamoom/orgs","repos_url":"https://api.github.com/users/spamoom/repos","events_url":"https://api.github.com/users/spamoom/events{/privacy}","received_events_url":"https://api.github.com/users/spamoom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spamoom/oauth-subscriber","description":"Signs Guzzle requests using OAuth 1.0 (Guzzle 6+)","fork":true,"url":"https://api.github.com/repos/spamoom/oauth-subscriber","forks_url":"https://api.github.com/repos/spamoom/oauth-subscriber/forks","keys_url":"https://api.github.com/repos/spamoom/oauth-subscriber/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spamoom/oauth-subscriber/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spamoom/oauth-subscriber/teams","hooks_url":"https://api.github.com/repos/spamoom/oauth-subscriber/hooks","issue_events_url":"https://api.github.com/repos/spamoom/oauth-subscriber/issues/events{/number}","events_url":"https://api.github.com/repos/spamoom/oauth-subscriber/events","assignees_url":"https://api.github.com/repos/spamoom/oauth-subscriber/assignees{/user}","branches_url":"https://api.github.com/repos/spamoom/oauth-subscriber/branches{/branch}","tags_url":"https://api.github.com/repos/spamoom/oauth-subscriber/tags","blobs_url":"https://api.github.com/repos/spamoom/oauth-subscriber/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spamoom/oauth-subscriber/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spamoom/oauth-subscriber/git/refs{/sha}","trees_url":"https://api.github.com/repos/spamoom/oauth-subscriber/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spamoom/oauth-subscriber/statuses/{sha}","languages_url":"https://api.github.com/repos/spamoom/oauth-subscriber/languages","stargazers_url":"https://api.github.com/repos/spamoom/oauth-subscriber/stargazers","contributors_url":"https://api.github.com/repos/spamoom/oauth-subscriber/contributors","subscribers_url":"https://api.github.com/repos/spamoom/oauth-subscriber/subscribers","subscription_url":"https://api.github.com/repos/spamoom/oauth-subscriber/subscription","commits_url":"https://api.github.com/repos/spamoom/oauth-subscriber/commits{/sha}","git_commits_url":"https://api.github.com/repos/spamoom/oauth-subscriber/git/commits{/sha}","comments_url":"https://api.github.com/repos/spamoom/oauth-subscriber/comments{/number}","issue_comment_url":"https://api.github.com/repos/spamoom/oauth-subscriber/issues/comments{/number}","contents_url":"https://api.github.com/repos/spamoom/oauth-subscriber/contents/{+path}","compare_url":"https://api.github.com/repos/spamoom/oauth-subscriber/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spamoom/oauth-subscriber/merges","archive_url":"https://api.github.com/repos/spamoom/oauth-subscriber/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spamoom/oauth-subscriber/downloads","issues_url":"https://api.github.com/repos/spamoom/oauth-subscriber/issues{/number}","pulls_url":"https://api.github.com/repos/spamoom/oauth-subscriber/pulls{/number}","milestones_url":"https://api.github.com/repos/spamoom/oauth-subscriber/milestones{/number}","notifications_url":"https://api.github.com/repos/spamoom/oauth-subscriber/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spamoom/oauth-subscriber/labels{/name}","releases_url":"https://api.github.com/repos/spamoom/oauth-subscriber/releases{/id}","deployments_url":"https://api.github.com/repos/spamoom/oauth-subscriber/deployments","created_at":"2016-11-07T21:00:25Z","updated_at":"2016-11-07T21:00:27Z","pushed_at":"2016-11-07T21:29:02Z","git_url":"git://github.com/spamoom/oauth-subscriber.git","ssh_url":"git@github.com:spamoom/oauth-subscriber.git","clone_url":"https://github.com/spamoom/oauth-subscriber.git","svn_url":"https://github.com/spamoom/oauth-subscriber","homepage":"","size":90,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"guzzle:master","ref":"master","sha":"6e13e78049b977dde1fbf37b1559e47e4d416e00","user":{"login":"guzzle","id":638632,"avatar_url":"https://avatars.githubusercontent.com/u/638632?v=3","gravatar_id":"","url":"https://api.github.com/users/guzzle","html_url":"https://github.com/guzzle","followers_url":"https://api.github.com/users/guzzle/followers","following_url":"https://api.github.com/users/guzzle/following{/other_user}","gists_url":"https://api.github.com/users/guzzle/gists{/gist_id}","starred_url":"https://api.github.com/users/guzzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guzzle/subscriptions","organizations_url":"https://api.github.com/users/guzzle/orgs","repos_url":"https://api.github.com/users/guzzle/repos","events_url":"https://api.github.com/users/guzzle/events{/privacy}","received_events_url":"https://api.github.com/users/guzzle/received_events","type":"Organization","site_admin":false},"repo":{"id":17303422,"name":"oauth-subscriber","full_name":"guzzle/oauth-subscriber","owner":{"login":"guzzle","id":638632,"avatar_url":"https://avatars.githubusercontent.com/u/638632?v=3","gravatar_id":"","url":"https://api.github.com/users/guzzle","html_url":"https://github.com/guzzle","followers_url":"https://api.github.com/users/guzzle/followers","following_url":"https://api.github.com/users/guzzle/following{/other_user}","gists_url":"https://api.github.com/users/guzzle/gists{/gist_id}","starred_url":"https://api.github.com/users/guzzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guzzle/subscriptions","organizations_url":"https://api.github.com/users/guzzle/orgs","repos_url":"https://api.github.com/users/guzzle/repos","events_url":"https://api.github.com/users/guzzle/events{/privacy}","received_events_url":"https://api.github.com/users/guzzle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guzzle/oauth-subscriber","description":"Signs Guzzle requests using OAuth 1.0 (Guzzle 6+)","fork":false,"url":"https://api.github.com/repos/guzzle/oauth-subscriber","forks_url":"https://api.github.com/repos/guzzle/oauth-subscriber/forks","keys_url":"https://api.github.com/repos/guzzle/oauth-subscriber/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guzzle/oauth-subscriber/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guzzle/oauth-subscriber/teams","hooks_url":"https://api.github.com/repos/guzzle/oauth-subscriber/hooks","issue_events_url":"https://api.github.com/repos/guzzle/oauth-subscriber/issues/events{/number}","events_url":"https://api.github.com/repos/guzzle/oauth-subscriber/events","assignees_url":"https://api.github.com/repos/guzzle/oauth-subscriber/assignees{/user}","branches_url":"https://api.github.com/repos/guzzle/oauth-subscriber/branches{/branch}","tags_url":"https://api.github.com/repos/guzzle/oauth-subscriber/tags","blobs_url":"https://api.github.com/repos/guzzle/oauth-subscriber/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guzzle/oauth-subscriber/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guzzle/oauth-subscriber/git/refs{/sha}","trees_url":"https://api.github.com/repos/guzzle/oauth-subscriber/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guzzle/oauth-subscriber/statuses/{sha}","languages_url":"https://api.github.com/repos/guzzle/oauth-subscriber/languages","stargazers_url":"https://api.github.com/repos/guzzle/oauth-subscriber/stargazers","contributors_url":"https://api.github.com/repos/guzzle/oauth-subscriber/contributors","subscribers_url":"https://api.github.com/repos/guzzle/oauth-subscriber/subscribers","subscription_url":"https://api.github.com/repos/guzzle/oauth-subscriber/subscription","commits_url":"https://api.github.com/repos/guzzle/oauth-subscriber/commits{/sha}","git_commits_url":"https://api.github.com/repos/guzzle/oauth-subscriber/git/commits{/sha}","comments_url":"https://api.github.com/repos/guzzle/oauth-subscriber/comments{/number}","issue_comment_url":"https://api.github.com/repos/guzzle/oauth-subscriber/issues/comments{/number}","contents_url":"https://api.github.com/repos/guzzle/oauth-subscriber/contents/{+path}","compare_url":"https://api.github.com/repos/guzzle/oauth-subscriber/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guzzle/oauth-subscriber/merges","archive_url":"https://api.github.com/repos/guzzle/oauth-subscriber/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guzzle/oauth-subscriber/downloads","issues_url":"https://api.github.com/repos/guzzle/oauth-subscriber/issues{/number}","pulls_url":"https://api.github.com/repos/guzzle/oauth-subscriber/pulls{/number}","milestones_url":"https://api.github.com/repos/guzzle/oauth-subscriber/milestones{/number}","notifications_url":"https://api.github.com/repos/guzzle/oauth-subscriber/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guzzle/oauth-subscriber/labels{/name}","releases_url":"https://api.github.com/repos/guzzle/oauth-subscriber/releases{/id}","deployments_url":"https://api.github.com/repos/guzzle/oauth-subscriber/deployments","created_at":"2014-02-28T23:45:39Z","updated_at":"2016-12-20T15:23:10Z","pushed_at":"2016-12-22T13:33:51Z","git_url":"git://github.com/guzzle/oauth-subscriber.git","ssh_url":"git@github.com:guzzle/oauth-subscriber.git","clone_url":"https://github.com/guzzle/oauth-subscriber.git","svn_url":"https://github.com/guzzle/oauth-subscriber","homepage":"","size":519,"stargazers_count":102,"watchers_count":102,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":15,"forks":57,"open_issues":15,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guzzle/oauth-subscriber/pulls/57"},"html":{"href":"https://github.com/guzzle/oauth-subscriber/pull/57"},"issue":{"href":"https://api.github.com/repos/guzzle/oauth-subscriber/issues/57"},"comments":{"href":"https://api.github.com/repos/guzzle/oauth-subscriber/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/guzzle/oauth-subscriber/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/guzzle/oauth-subscriber/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guzzle/oauth-subscriber/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/guzzle/oauth-subscriber/statuses/ff63e9727e08471fbf435d878f03624d92be979d"}}}}
{"actor":{"display_login":"sagikazarmark"}}