{"action":"created","comment":{"url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/comments/73956534","id":73956534,"diff_hunk":"@@ -62,7 +62,7 @@ qx.Bootstrap.define(\"qx.bom.Cookie\",\n         end = document.cookie.length;\n       }\n \n-      return decodeURI(document.cookie.substring(len, end));\n+      return unescape(document.cookie.substring(len, end));\n     },","path":"framework/source/class/qx/bom/Cookie.js","position":null,"original_position":6,"commit_id":"369704956d867487aae8d7ba61338a9aacd19dc4","original_commit_id":"90aff38fdfd00606b9bf0331b5f19d7502b8c79d","user":{"login":"yybalam","id":579563,"avatar_url":"https://avatars.githubusercontent.com/u/579563?v=3","gravatar_id":"","url":"https://api.github.com/users/yybalam","html_url":"https://github.com/yybalam","followers_url":"https://api.github.com/users/yybalam/followers","following_url":"https://api.github.com/users/yybalam/following{/other_user}","gists_url":"https://api.github.com/users/yybalam/gists{/gist_id}","starred_url":"https://api.github.com/users/yybalam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yybalam/subscriptions","organizations_url":"https://api.github.com/users/yybalam/orgs","repos_url":"https://api.github.com/users/yybalam/repos","events_url":"https://api.github.com/users/yybalam/events{/privacy}","received_events_url":"https://api.github.com/users/yybalam/received_events","type":"User","site_admin":false},"body":"Nope. That is fixed by another PR that is no merged yet, so I think this PR must avoid that change, so this PR don't break anything with actual sate of master. :sweat_smile: ","created_at":"2016-08-08T21:16:57Z","updated_at":"2016-08-08T21:16:57Z","html_url":"https://github.com/qooxdoo/qooxdoo/pull/9111#discussion_r73956534","pull_request_url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9111","_links":{"self":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/comments/73956534"},"html":{"href":"https://github.com/qooxdoo/qooxdoo/pull/9111#discussion_r73956534"},"pull_request":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9111"}}},"pull_request":{"url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9111","id":78559947,"html_url":"https://github.com/qooxdoo/qooxdoo/pull/9111","diff_url":"https://github.com/qooxdoo/qooxdoo/pull/9111.diff","patch_url":"https://github.com/qooxdoo/qooxdoo/pull/9111.patch","issue_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9111","number":9111,"state":"open","locked":false,"title":"[RFC] Issue #9104 Provide dialog widgets","user":{"login":"yybalam","id":579563,"avatar_url":"https://avatars.githubusercontent.com/u/579563?v=3","gravatar_id":"","url":"https://api.github.com/users/yybalam","html_url":"https://github.com/yybalam","followers_url":"https://api.github.com/users/yybalam/followers","following_url":"https://api.github.com/users/yybalam/following{/other_user}","gists_url":"https://api.github.com/users/yybalam/gists{/gist_id}","starred_url":"https://api.github.com/users/yybalam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yybalam/subscriptions","organizations_url":"https://api.github.com/users/yybalam/orgs","repos_url":"https://api.github.com/users/yybalam/repos","events_url":"https://api.github.com/users/yybalam/events{/privacy}","received_events_url":"https://api.github.com/users/yybalam/received_events","type":"User","site_admin":false},"body":"This PR try to provide to qooxdoo a default basic dialog widgets. Basically this PR add :\r\n\r\n1. A Message dialog for alert messaged.\r\n2. A Confirm dialog with support for attach function to buttons.\r\n3. A BusyIndicator.\r\n\r\nA `qx.ui.Dialog` static class provide a short way for launch dialogs.:\r\n\r\n    qx.ui.Dialog.alert(\"Yay, some dialog!\");\r\n    qx.ui.Dialog.error(\"Some was wrong. :(\");\r\n\r\nAlso this PR include an `MBusyBlocker` mixin. This mixin extend `MBlocker` for provide an loading gif while the widget is blocked. Also is possible to show a custom text if `allowBusyPopup` is set to `true`.\r\n\r\nRight now there is only two test, one for `Message` and another for `Confirm`.\r\n\r\n## Whats missing?\r\n\r\nWell, some documentation of course. Also I thing a test for  `MBusyBlocker`, but I don found a test for `MBlocker` so I'm not sure how to test it.\r\n\r\nAlso when I compile using 'Tango' icon theme, the icons are shown, but I can't get it work for Oxygen.\r\n\r\nI know this PR actually is not complete (sorry) to be merge, but maybe heps to get the way.\r\n\r\nCheers.\r\n","created_at":"2016-07-23T01:54:00Z","updated_at":"2016-08-08T21:16:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a034ffff2340a13d7c72a0678dfb694e0fa6b15","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9111/commits","review_comments_url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9111/comments","review_comment_url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9111/comments","statuses_url":"https://api.github.com/repos/qooxdoo/qooxdoo/statuses/369704956d867487aae8d7ba61338a9aacd19dc4","head":{"label":"yybalam:dialoglab","ref":"dialoglab","sha":"369704956d867487aae8d7ba61338a9aacd19dc4","user":{"login":"yybalam","id":579563,"avatar_url":"https://avatars.githubusercontent.com/u/579563?v=3","gravatar_id":"","url":"https://api.github.com/users/yybalam","html_url":"https://github.com/yybalam","followers_url":"https://api.github.com/users/yybalam/followers","following_url":"https://api.github.com/users/yybalam/following{/other_user}","gists_url":"https://api.github.com/users/yybalam/gists{/gist_id}","starred_url":"https://api.github.com/users/yybalam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yybalam/subscriptions","organizations_url":"https://api.github.com/users/yybalam/orgs","repos_url":"https://api.github.com/users/yybalam/repos","events_url":"https://api.github.com/users/yybalam/events{/privacy}","received_events_url":"https://api.github.com/users/yybalam/received_events","type":"User","site_admin":false},"repo":{"id":62923101,"name":"qooxdoo","full_name":"yybalam/qooxdoo","owner":{"login":"yybalam","id":579563,"avatar_url":"https://avatars.githubusercontent.com/u/579563?v=3","gravatar_id":"","url":"https://api.github.com/users/yybalam","html_url":"https://github.com/yybalam","followers_url":"https://api.github.com/users/yybalam/followers","following_url":"https://api.github.com/users/yybalam/following{/other_user}","gists_url":"https://api.github.com/users/yybalam/gists{/gist_id}","starred_url":"https://api.github.com/users/yybalam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yybalam/subscriptions","organizations_url":"https://api.github.com/users/yybalam/orgs","repos_url":"https://api.github.com/users/yybalam/repos","events_url":"https://api.github.com/users/yybalam/events{/privacy}","received_events_url":"https://api.github.com/users/yybalam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yybalam/qooxdoo","description":"qooxdoo - Universal JavaScript Framework","fork":true,"url":"https://api.github.com/repos/yybalam/qooxdoo","forks_url":"https://api.github.com/repos/yybalam/qooxdoo/forks","keys_url":"https://api.github.com/repos/yybalam/qooxdoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yybalam/qooxdoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yybalam/qooxdoo/teams","hooks_url":"https://api.github.com/repos/yybalam/qooxdoo/hooks","issue_events_url":"https://api.github.com/repos/yybalam/qooxdoo/issues/events{/number}","events_url":"https://api.github.com/repos/yybalam/qooxdoo/events","assignees_url":"https://api.github.com/repos/yybalam/qooxdoo/assignees{/user}","branches_url":"https://api.github.com/repos/yybalam/qooxdoo/branches{/branch}","tags_url":"https://api.github.com/repos/yybalam/qooxdoo/tags","blobs_url":"https://api.github.com/repos/yybalam/qooxdoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yybalam/qooxdoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yybalam/qooxdoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/yybalam/qooxdoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yybalam/qooxdoo/statuses/{sha}","languages_url":"https://api.github.com/repos/yybalam/qooxdoo/languages","stargazers_url":"https://api.github.com/repos/yybalam/qooxdoo/stargazers","contributors_url":"https://api.github.com/repos/yybalam/qooxdoo/contributors","subscribers_url":"https://api.github.com/repos/yybalam/qooxdoo/subscribers","subscription_url":"https://api.github.com/repos/yybalam/qooxdoo/subscription","commits_url":"https://api.github.com/repos/yybalam/qooxdoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/yybalam/qooxdoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/yybalam/qooxdoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/yybalam/qooxdoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/yybalam/qooxdoo/contents/{+path}","compare_url":"https://api.github.com/repos/yybalam/qooxdoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yybalam/qooxdoo/merges","archive_url":"https://api.github.com/repos/yybalam/qooxdoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yybalam/qooxdoo/downloads","issues_url":"https://api.github.com/repos/yybalam/qooxdoo/issues{/number}","pulls_url":"https://api.github.com/repos/yybalam/qooxdoo/pulls{/number}","milestones_url":"https://api.github.com/repos/yybalam/qooxdoo/milestones{/number}","notifications_url":"https://api.github.com/repos/yybalam/qooxdoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yybalam/qooxdoo/labels{/name}","releases_url":"https://api.github.com/repos/yybalam/qooxdoo/releases{/id}","deployments_url":"https://api.github.com/repos/yybalam/qooxdoo/deployments","created_at":"2016-07-08T23:34:46Z","updated_at":"2016-07-08T23:34:58Z","pushed_at":"2016-08-08T20:15:20Z","git_url":"git://github.com/yybalam/qooxdoo.git","ssh_url":"git@github.com:yybalam/qooxdoo.git","clone_url":"https://github.com/yybalam/qooxdoo.git","svn_url":"https://github.com/yybalam/qooxdoo","homepage":"http://qooxdoo.org","size":229413,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qooxdoo:master","ref":"master","sha":"121f145c37146de93dbee7d9205436483a2ddf4d","user":{"login":"qooxdoo","id":105118,"avatar_url":"https://avatars.githubusercontent.com/u/105118?v=3","gravatar_id":"","url":"https://api.github.com/users/qooxdoo","html_url":"https://github.com/qooxdoo","followers_url":"https://api.github.com/users/qooxdoo/followers","following_url":"https://api.github.com/users/qooxdoo/following{/other_user}","gists_url":"https://api.github.com/users/qooxdoo/gists{/gist_id}","starred_url":"https://api.github.com/users/qooxdoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qooxdoo/subscriptions","organizations_url":"https://api.github.com/users/qooxdoo/orgs","repos_url":"https://api.github.com/users/qooxdoo/repos","events_url":"https://api.github.com/users/qooxdoo/events{/privacy}","received_events_url":"https://api.github.com/users/qooxdoo/received_events","type":"Organization","site_admin":false},"repo":{"id":548213,"name":"qooxdoo","full_name":"qooxdoo/qooxdoo","owner":{"login":"qooxdoo","id":105118,"avatar_url":"https://avatars.githubusercontent.com/u/105118?v=3","gravatar_id":"","url":"https://api.github.com/users/qooxdoo","html_url":"https://github.com/qooxdoo","followers_url":"https://api.github.com/users/qooxdoo/followers","following_url":"https://api.github.com/users/qooxdoo/following{/other_user}","gists_url":"https://api.github.com/users/qooxdoo/gists{/gist_id}","starred_url":"https://api.github.com/users/qooxdoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qooxdoo/subscriptions","organizations_url":"https://api.github.com/users/qooxdoo/orgs","repos_url":"https://api.github.com/users/qooxdoo/repos","events_url":"https://api.github.com/users/qooxdoo/events{/privacy}","received_events_url":"https://api.github.com/users/qooxdoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qooxdoo/qooxdoo","description":"qooxdoo - Universal JavaScript Framework","fork":false,"url":"https://api.github.com/repos/qooxdoo/qooxdoo","forks_url":"https://api.github.com/repos/qooxdoo/qooxdoo/forks","keys_url":"https://api.github.com/repos/qooxdoo/qooxdoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qooxdoo/qooxdoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qooxdoo/qooxdoo/teams","hooks_url":"https://api.github.com/repos/qooxdoo/qooxdoo/hooks","issue_events_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/events{/number}","events_url":"https://api.github.com/repos/qooxdoo/qooxdoo/events","assignees_url":"https://api.github.com/repos/qooxdoo/qooxdoo/assignees{/user}","branches_url":"https://api.github.com/repos/qooxdoo/qooxdoo/branches{/branch}","tags_url":"https://api.github.com/repos/qooxdoo/qooxdoo/tags","blobs_url":"https://api.github.com/repos/qooxdoo/qooxdoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qooxdoo/qooxdoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qooxdoo/qooxdoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/qooxdoo/qooxdoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qooxdoo/qooxdoo/statuses/{sha}","languages_url":"https://api.github.com/repos/qooxdoo/qooxdoo/languages","stargazers_url":"https://api.github.com/repos/qooxdoo/qooxdoo/stargazers","contributors_url":"https://api.github.com/repos/qooxdoo/qooxdoo/contributors","subscribers_url":"https://api.github.com/repos/qooxdoo/qooxdoo/subscribers","subscription_url":"https://api.github.com/repos/qooxdoo/qooxdoo/subscription","commits_url":"https://api.github.com/repos/qooxdoo/qooxdoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/qooxdoo/qooxdoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/qooxdoo/qooxdoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/qooxdoo/qooxdoo/contents/{+path}","compare_url":"https://api.github.com/repos/qooxdoo/qooxdoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qooxdoo/qooxdoo/merges","archive_url":"https://api.github.com/repos/qooxdoo/qooxdoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qooxdoo/qooxdoo/downloads","issues_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues{/number}","pulls_url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls{/number}","milestones_url":"https://api.github.com/repos/qooxdoo/qooxdoo/milestones{/number}","notifications_url":"https://api.github.com/repos/qooxdoo/qooxdoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qooxdoo/qooxdoo/labels{/name}","releases_url":"https://api.github.com/repos/qooxdoo/qooxdoo/releases{/id}","deployments_url":"https://api.github.com/repos/qooxdoo/qooxdoo/deployments","created_at":"2010-03-05T10:01:27Z","updated_at":"2016-08-08T12:06:27Z","pushed_at":"2016-08-08T20:15:23Z","git_url":"git://github.com/qooxdoo/qooxdoo.git","ssh_url":"git@github.com:qooxdoo/qooxdoo.git","clone_url":"https://github.com/qooxdoo/qooxdoo.git","svn_url":"https://github.com/qooxdoo/qooxdoo","homepage":"http://qooxdoo.org","size":264719,"stargazers_count":522,"watchers_count":522,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":189,"mirror_url":null,"open_issues_count":36,"forks":189,"open_issues":36,"watchers":522,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9111"},"html":{"href":"https://github.com/qooxdoo/qooxdoo/pull/9111"},"issue":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9111"},"comments":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9111/comments"},"review_comments":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9111/comments"},"review_comment":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9111/commits"},"statuses":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/statuses/369704956d867487aae8d7ba61338a9aacd19dc4"}}}}
{"actor":{"display_login":"yybalam"}}