{"action":"opened","number":10467,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10467","id":81301524,"html_url":"https://github.com/ManageIQ/manageiq/pull/10467","diff_url":"https://github.com/ManageIQ/manageiq/pull/10467.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/10467.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10467","number":10467,"state":"open","locked":false,"title":"Fix filtering by registry in reports","user":{"login":"lpichler","id":14937244,"avatar_url":"https://avatars.githubusercontent.com/u/14937244?v=3","gravatar_id":"","url":"https://api.github.com/users/lpichler","html_url":"https://github.com/lpichler","followers_url":"https://api.github.com/users/lpichler/followers","following_url":"https://api.github.com/users/lpichler/following{/other_user}","gists_url":"https://api.github.com/users/lpichler/gists{/gist_id}","starred_url":"https://api.github.com/users/lpichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpichler/subscriptions","organizations_url":"https://api.github.com/users/lpichler/orgs","repos_url":"https://api.github.com/users/lpichler/repos","events_url":"https://api.github.com/users/lpichler/events{/privacy}","received_events_url":"https://api.github.com/users/lpichler/received_events","type":"User","site_admin":false},"body":"Purpose or Intent\r\n-----------------\r\nFixes https://github.com/ManageIQ/manageiq/issues/10436. \r\nGeneration a report with Registry condition is throwing error message(https://github.com/ManageIQ/manageiq/issues/10436)\r\n\r\nIt looks like we should return false in method MiqExpression#sql_supports_atom?(exp)\r\nThis was throwing an error:\r\n\r\n```\r\n exp = {\"=\" => {\"regkey\" => \"test\", \"regval\" => \"value\", \"value\" => \"data\"}}\r\n MiqExpression.new(exp).to_sql\r\n```\r\nFor filtering this in RBAC, there are loaded relations with RegistryItem table and then it is filtered in https://github.com/ManageIQ/manageiq/blob/master/lib/rbac/filterer.rb#L213\r\n\r\nLinks\r\n-----\r\nhttps://github.com/ManageIQ/manageiq/issues/10436\r\n\r\nSteps for Testing/QA\r\n--------------------\r\n> Run report with filtering as is shown in https://github.com/ManageIQ/manageiq/issues/10436\r\n\r\n@imtayadeway \r\n@miq-bot assign @gtanzillo \r\n@miq-bot add_label reporting, bug\r\n\r\n","created_at":"2016-08-15T11:43:19Z","updated_at":"2016-08-15T11:43:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41c25b5f97d0c7ca421ff58cb70a60abfafdd601","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10467/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10467/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/10467/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/e8210afdc2151911f29b73368cb4c29e6e3fd44c","head":{"label":"lpichler:fix_filtering_by_registry_in_reports","ref":"fix_filtering_by_registry_in_reports","sha":"e8210afdc2151911f29b73368cb4c29e6e3fd44c","user":{"login":"lpichler","id":14937244,"avatar_url":"https://avatars.githubusercontent.com/u/14937244?v=3","gravatar_id":"","url":"https://api.github.com/users/lpichler","html_url":"https://github.com/lpichler","followers_url":"https://api.github.com/users/lpichler/followers","following_url":"https://api.github.com/users/lpichler/following{/other_user}","gists_url":"https://api.github.com/users/lpichler/gists{/gist_id}","starred_url":"https://api.github.com/users/lpichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpichler/subscriptions","organizations_url":"https://api.github.com/users/lpichler/orgs","repos_url":"https://api.github.com/users/lpichler/repos","events_url":"https://api.github.com/users/lpichler/events{/privacy}","received_events_url":"https://api.github.com/users/lpichler/received_events","type":"User","site_admin":false},"repo":{"id":43540953,"name":"manageiq","full_name":"lpichler/manageiq","owner":{"login":"lpichler","id":14937244,"avatar_url":"https://avatars.githubusercontent.com/u/14937244?v=3","gravatar_id":"","url":"https://api.github.com/users/lpichler","html_url":"https://github.com/lpichler","followers_url":"https://api.github.com/users/lpichler/followers","following_url":"https://api.github.com/users/lpichler/following{/other_user}","gists_url":"https://api.github.com/users/lpichler/gists{/gist_id}","starred_url":"https://api.github.com/users/lpichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpichler/subscriptions","organizations_url":"https://api.github.com/users/lpichler/orgs","repos_url":"https://api.github.com/users/lpichler/repos","events_url":"https://api.github.com/users/lpichler/events{/privacy}","received_events_url":"https://api.github.com/users/lpichler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lpichler/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/lpichler/manageiq","forks_url":"https://api.github.com/repos/lpichler/manageiq/forks","keys_url":"https://api.github.com/repos/lpichler/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lpichler/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lpichler/manageiq/teams","hooks_url":"https://api.github.com/repos/lpichler/manageiq/hooks","issue_events_url":"https://api.github.com/repos/lpichler/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/lpichler/manageiq/events","assignees_url":"https://api.github.com/repos/lpichler/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/lpichler/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/lpichler/manageiq/tags","blobs_url":"https://api.github.com/repos/lpichler/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lpichler/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lpichler/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/lpichler/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lpichler/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/lpichler/manageiq/languages","stargazers_url":"https://api.github.com/repos/lpichler/manageiq/stargazers","contributors_url":"https://api.github.com/repos/lpichler/manageiq/contributors","subscribers_url":"https://api.github.com/repos/lpichler/manageiq/subscribers","subscription_url":"https://api.github.com/repos/lpichler/manageiq/subscription","commits_url":"https://api.github.com/repos/lpichler/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/lpichler/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/lpichler/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/lpichler/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/lpichler/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/lpichler/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lpichler/manageiq/merges","archive_url":"https://api.github.com/repos/lpichler/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lpichler/manageiq/downloads","issues_url":"https://api.github.com/repos/lpichler/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/lpichler/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/lpichler/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/lpichler/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lpichler/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/lpichler/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/lpichler/manageiq/deployments","created_at":"2015-10-02T07:37:28Z","updated_at":"2016-01-11T09:22:37Z","pushed_at":"2016-08-15T11:34:40Z","git_url":"git://github.com/lpichler/manageiq.git","ssh_url":"git@github.com:lpichler/manageiq.git","clone_url":"https://github.com/lpichler/manageiq.git","svn_url":"https://github.com/lpichler/manageiq","homepage":"manageiq.org","size":148325,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"e6cd56645751c986b23309b2cb2c753581cd4375","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-08-15T02:36:28Z","pushed_at":"2016-08-15T11:43:19Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":193917,"stargazers_count":303,"watchers_count":303,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":337,"mirror_url":null,"open_issues_count":770,"forks":337,"open_issues":770,"watchers":303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10467"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/10467"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/10467"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/10467/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10467/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/10467/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/e8210afdc2151911f29b73368cb4c29e6e3fd44c"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":48,"deletions":0,"changed_files":3}}
{"actor":{"display_login":"lpichler"}}