{"action":"created","issue":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/6729","repository_url":"https://api.github.com/repos/code-dot-org/code-dot-org","labels_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/6729/labels{/name}","comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/6729/comments","events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/6729/events","html_url":"https://github.com/code-dot-org/code-dot-org/pull/6729","id":132582902,"number":6729,"title":"Add Set Pattern block","user":{"login":"kozzi","id":1885340,"avatar_url":"https://avatars.githubusercontent.com/u/1885340?v=3","gravatar_id":"","url":"https://api.github.com/users/kozzi","html_url":"https://github.com/kozzi","followers_url":"https://api.github.com/users/kozzi/followers","following_url":"https://api.github.com/users/kozzi/following{/other_user}","gists_url":"https://api.github.com/users/kozzi/gists{/gist_id}","starred_url":"https://api.github.com/users/kozzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kozzi/subscriptions","organizations_url":"https://api.github.com/users/kozzi/orgs","repos_url":"https://api.github.com/users/kozzi/repos","events_url":"https://api.github.com/users/kozzi/events{/privacy}","received_events_url":"https://api.github.com/users/kozzi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"breville","id":2205926,"avatar_url":"https://avatars.githubusercontent.com/u/2205926?v=3","gravatar_id":"","url":"https://api.github.com/users/breville","html_url":"https://github.com/breville","followers_url":"https://api.github.com/users/breville/followers","following_url":"https://api.github.com/users/breville/following{/other_user}","gists_url":"https://api.github.com/users/breville/gists{/gist_id}","starred_url":"https://api.github.com/users/breville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breville/subscriptions","organizations_url":"https://api.github.com/users/breville/orgs","repos_url":"https://api.github.com/users/breville/repos","events_url":"https://api.github.com/users/breville/events{/privacy}","received_events_url":"https://api.github.com/users/breville/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-02-10T01:12:13Z","updated_at":"2016-02-10T01:21:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/6729","html_url":"https://github.com/code-dot-org/code-dot-org/pull/6729","diff_url":"https://github.com/code-dot-org/code-dot-org/pull/6729.diff","patch_url":"https://github.com/code-dot-org/code-dot-org/pull/6729.patch"},"body":"This change adds the Set Pattern block to artist.\r\n\r\n![pattern-artist2](https://cloud.githubusercontent.com/assets/1885340/12935773/50fcca66-cf4d-11e5-8525-7afafa24be61.gif)\r\n\r\nMost of the work is actually already in place and ready to go. A lot of this change simply wired it all back together so that it can be used in artist.\r\n\r\nNote: There is a lot of custom work done for the Frozen skins that make them not work well with patterns other than their own lines. During testing, I found that when Anna/Elsa drew other patterns, they all look distorted or is weirdly offset. So for the Anna and Elsa skin, I don't allow patterns other than their own in the Set Patterns block dropdown.\r\n\r\n### Testing\r\n- Tested this with the artist, elsa, and anna skins.\r\n- Tested the Frozen tutorial for good measure.\r\n- Ran `grunt mochaTest` per [the testing doc](https://github.com/code-dot-org/code-dot-org/blob/staging/TESTING.md#mocha-tests) \r\n- This is my first time make changes in this area; are there other things I should test?\r\n\r\n### Todo\r\n- We probably need to replace all the line art assets"},"comment":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/comments/182158514","html_url":"https://github.com/code-dot-org/code-dot-org/pull/6729#issuecomment-182158514","issue_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/6729","id":182158514,"user":{"login":"breville","id":2205926,"avatar_url":"https://avatars.githubusercontent.com/u/2205926?v=3","gravatar_id":"","url":"https://api.github.com/users/breville","html_url":"https://github.com/breville","followers_url":"https://api.github.com/users/breville/followers","following_url":"https://api.github.com/users/breville/following{/other_user}","gists_url":"https://api.github.com/users/breville/gists{/gist_id}","starred_url":"https://api.github.com/users/breville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breville/subscriptions","organizations_url":"https://api.github.com/users/breville/orgs","repos_url":"https://api.github.com/users/breville/repos","events_url":"https://api.github.com/users/breville/events{/privacy}","received_events_url":"https://api.github.com/users/breville/received_events","type":"User","site_admin":false},"created_at":"2016-02-10T01:21:40Z","updated_at":"2016-02-10T01:21:40Z","body":"Anna & Elsa patterns are rendered based on the fact that we draw their lines step by step rather than all at once.  Hopefully one day we can add that feature to regular artist too.\r\n\r\nbtw, those two skins should only ever appear as part of the frozen tutorial, and not be selectable anywhere else.\r\n\r\nAs discussed by email, we need to create our own pattern images.\r\n\r\nOne suggestion, otherwise lgtm.\r\n"}}