{"action":"created","comment":{"url":"https://api.github.com/repos/nightwatchjs/nightwatch/pulls/comments/74657944","id":74657944,"diff_hunk":"@@ -53,15 +53,20 @@ module.exports = {\n       var match = true;\n \n       if (!Array.isArray(moduleTags)) {\n-        return typeof opts.tag_filter == 'undefined' && typeof opts.skiptags != 'undefined';\n+        return typeof opts.tag_filter == 'undefined' && typeof opts.tags_filter == 'undefined' && typeof opts.skiptags != 'undefined';\n       }\n \n-      if (opts.tag_filter || opts.skiptags){\n+      if (opts.tag_filter || opts.tags_filter || opts.skiptags){\n         moduleTags = this.convertTagsToString(moduleTags);\n \n         if (opts.tag_filter) {\n           match = this.containsTag(moduleTags, this.convertTagsToString(opts.tag_filter));\n         }\n+        \n+        if (opts.tags_filter) {","path":"lib/runner/filematcher.js","position":16,"original_position":16,"commit_id":"59eb8083edc48fae658cadfc0b16dca1c80884c1","original_commit_id":"59eb8083edc48fae658cadfc0b16dca1c80884c1","user":{"login":"beatfactor","id":419506,"avatar_url":"https://avatars.githubusercontent.com/u/419506?v=3","gravatar_id":"","url":"https://api.github.com/users/beatfactor","html_url":"https://github.com/beatfactor","followers_url":"https://api.github.com/users/beatfactor/followers","following_url":"https://api.github.com/users/beatfactor/following{/other_user}","gists_url":"https://api.github.com/users/beatfactor/gists{/gist_id}","starred_url":"https://api.github.com/users/beatfactor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beatfactor/subscriptions","organizations_url":"https://api.github.com/users/beatfactor/orgs","repos_url":"https://api.github.com/users/beatfactor/repos","events_url":"https://api.github.com/users/beatfactor/events{/privacy}","received_events_url":"https://api.github.com/users/beatfactor/received_events","type":"User","site_admin":false},"body":"shouldn't this be an else if? what happens if there both `--tag` and `--tags` are present?","created_at":"2016-08-12T20:47:53Z","updated_at":"2016-08-12T20:47:53Z","html_url":"https://github.com/nightwatchjs/nightwatch/pull/987#discussion_r74657944","pull_request_url":"https://api.github.com/repos/nightwatchjs/nightwatch/pulls/987","_links":{"self":{"href":"https://api.github.com/repos/nightwatchjs/nightwatch/pulls/comments/74657944"},"html":{"href":"https://github.com/nightwatchjs/nightwatch/pull/987#discussion_r74657944"},"pull_request":{"href":"https://api.github.com/repos/nightwatchjs/nightwatch/pulls/987"}}},"pull_request":{"url":"https://api.github.com/repos/nightwatchjs/nightwatch/pulls/987","id":70910967,"html_url":"https://github.com/nightwatchjs/nightwatch/pull/987","diff_url":"https://github.com/nightwatchjs/nightwatch/pull/987.diff","patch_url":"https://github.com/nightwatchjs/nightwatch/pull/987.patch","issue_url":"https://api.github.com/repos/nightwatchjs/nightwatch/issues/987","number":987,"state":"open","locked":false,"title":"Fixes #955 - Added --tags command to filter by multiple comma-separat…","user":{"login":"maxmarkus","id":1720843,"avatar_url":"https://avatars.githubusercontent.com/u/1720843?v=3","gravatar_id":"","url":"https://api.github.com/users/maxmarkus","html_url":"https://github.com/maxmarkus","followers_url":"https://api.github.com/users/maxmarkus/followers","following_url":"https://api.github.com/users/maxmarkus/following{/other_user}","gists_url":"https://api.github.com/users/maxmarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/maxmarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxmarkus/subscriptions","organizations_url":"https://api.github.com/users/maxmarkus/orgs","repos_url":"https://api.github.com/users/maxmarkus/repos","events_url":"https://api.github.com/users/maxmarkus/events{/privacy}","received_events_url":"https://api.github.com/users/maxmarkus/received_events","type":"User","site_admin":false},"body":"Added `--tags` command to filter by multiple comma-separated tags. \r\nIt is similar to `--skiptags`, but the other way round forces all tags to be present in order to run a test.\r\nThis does not address #874 and will face the same issue.\r\n\r\nThis would run all tests that have stage AND products as tag.\r\n`nightwatch --tags stage,products`\r\n","created_at":"2016-05-20T20:13:06Z","updated_at":"2016-08-12T20:47:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7baec51cf155c0031efe4844108ae1e77e1bbb01","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nightwatchjs/nightwatch/pulls/987/commits","review_comments_url":"https://api.github.com/repos/nightwatchjs/nightwatch/pulls/987/comments","review_comment_url":"https://api.github.com/repos/nightwatchjs/nightwatch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nightwatchjs/nightwatch/issues/987/comments","statuses_url":"https://api.github.com/repos/nightwatchjs/nightwatch/statuses/59eb8083edc48fae658cadfc0b16dca1c80884c1","head":{"label":"maxmarkus:feature/955-multiple-tags-and-selector","ref":"feature/955-multiple-tags-and-selector","sha":"59eb8083edc48fae658cadfc0b16dca1c80884c1","user":{"login":"maxmarkus","id":1720843,"avatar_url":"https://avatars.githubusercontent.com/u/1720843?v=3","gravatar_id":"","url":"https://api.github.com/users/maxmarkus","html_url":"https://github.com/maxmarkus","followers_url":"https://api.github.com/users/maxmarkus/followers","following_url":"https://api.github.com/users/maxmarkus/following{/other_user}","gists_url":"https://api.github.com/users/maxmarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/maxmarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxmarkus/subscriptions","organizations_url":"https://api.github.com/users/maxmarkus/orgs","repos_url":"https://api.github.com/users/maxmarkus/repos","events_url":"https://api.github.com/users/maxmarkus/events{/privacy}","received_events_url":"https://api.github.com/users/maxmarkus/received_events","type":"User","site_admin":false},"repo":{"id":59315176,"name":"nightwatch","full_name":"maxmarkus/nightwatch","owner":{"login":"maxmarkus","id":1720843,"avatar_url":"https://avatars.githubusercontent.com/u/1720843?v=3","gravatar_id":"","url":"https://api.github.com/users/maxmarkus","html_url":"https://github.com/maxmarkus","followers_url":"https://api.github.com/users/maxmarkus/followers","following_url":"https://api.github.com/users/maxmarkus/following{/other_user}","gists_url":"https://api.github.com/users/maxmarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/maxmarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxmarkus/subscriptions","organizations_url":"https://api.github.com/users/maxmarkus/orgs","repos_url":"https://api.github.com/users/maxmarkus/repos","events_url":"https://api.github.com/users/maxmarkus/events{/privacy}","received_events_url":"https://api.github.com/users/maxmarkus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxmarkus/nightwatch","description":"Automated testing and continous integration framework based on node.js and selenium webdriver","fork":true,"url":"https://api.github.com/repos/maxmarkus/nightwatch","forks_url":"https://api.github.com/repos/maxmarkus/nightwatch/forks","keys_url":"https://api.github.com/repos/maxmarkus/nightwatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxmarkus/nightwatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxmarkus/nightwatch/teams","hooks_url":"https://api.github.com/repos/maxmarkus/nightwatch/hooks","issue_events_url":"https://api.github.com/repos/maxmarkus/nightwatch/issues/events{/number}","events_url":"https://api.github.com/repos/maxmarkus/nightwatch/events","assignees_url":"https://api.github.com/repos/maxmarkus/nightwatch/assignees{/user}","branches_url":"https://api.github.com/repos/maxmarkus/nightwatch/branches{/branch}","tags_url":"https://api.github.com/repos/maxmarkus/nightwatch/tags","blobs_url":"https://api.github.com/repos/maxmarkus/nightwatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxmarkus/nightwatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxmarkus/nightwatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxmarkus/nightwatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxmarkus/nightwatch/statuses/{sha}","languages_url":"https://api.github.com/repos/maxmarkus/nightwatch/languages","stargazers_url":"https://api.github.com/repos/maxmarkus/nightwatch/stargazers","contributors_url":"https://api.github.com/repos/maxmarkus/nightwatch/contributors","subscribers_url":"https://api.github.com/repos/maxmarkus/nightwatch/subscribers","subscription_url":"https://api.github.com/repos/maxmarkus/nightwatch/subscription","commits_url":"https://api.github.com/repos/maxmarkus/nightwatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxmarkus/nightwatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxmarkus/nightwatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxmarkus/nightwatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxmarkus/nightwatch/contents/{+path}","compare_url":"https://api.github.com/repos/maxmarkus/nightwatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxmarkus/nightwatch/merges","archive_url":"https://api.github.com/repos/maxmarkus/nightwatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxmarkus/nightwatch/downloads","issues_url":"https://api.github.com/repos/maxmarkus/nightwatch/issues{/number}","pulls_url":"https://api.github.com/repos/maxmarkus/nightwatch/pulls{/number}","milestones_url":"https://api.github.com/repos/maxmarkus/nightwatch/milestones{/number}","notifications_url":"https://api.github.com/repos/maxmarkus/nightwatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxmarkus/nightwatch/labels{/name}","releases_url":"https://api.github.com/repos/maxmarkus/nightwatch/releases{/id}","deployments_url":"https://api.github.com/repos/maxmarkus/nightwatch/deployments","created_at":"2016-05-20T17:56:24Z","updated_at":"2016-05-20T17:56:26Z","pushed_at":"2016-06-02T15:04:28Z","git_url":"git://github.com/maxmarkus/nightwatch.git","ssh_url":"git@github.com:maxmarkus/nightwatch.git","clone_url":"https://github.com/maxmarkus/nightwatch.git","svn_url":"https://github.com/maxmarkus/nightwatch","homepage":"http://nightwatchjs.org","size":46229,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nightwatchjs:master","ref":"master","sha":"4ff5ff29a2e7c4ddef618b291f73b0791f881f6b","user":{"login":"nightwatchjs","id":12559275,"avatar_url":"https://avatars.githubusercontent.com/u/12559275?v=3","gravatar_id":"","url":"https://api.github.com/users/nightwatchjs","html_url":"https://github.com/nightwatchjs","followers_url":"https://api.github.com/users/nightwatchjs/followers","following_url":"https://api.github.com/users/nightwatchjs/following{/other_user}","gists_url":"https://api.github.com/users/nightwatchjs/gists{/gist_id}","starred_url":"https://api.github.com/users/nightwatchjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nightwatchjs/subscriptions","organizations_url":"https://api.github.com/users/nightwatchjs/orgs","repos_url":"https://api.github.com/users/nightwatchjs/repos","events_url":"https://api.github.com/users/nightwatchjs/events{/privacy}","received_events_url":"https://api.github.com/users/nightwatchjs/received_events","type":"Organization","site_admin":false},"repo":{"id":3750921,"name":"nightwatch","full_name":"nightwatchjs/nightwatch","owner":{"login":"nightwatchjs","id":12559275,"avatar_url":"https://avatars.githubusercontent.com/u/12559275?v=3","gravatar_id":"","url":"https://api.github.com/users/nightwatchjs","html_url":"https://github.com/nightwatchjs","followers_url":"https://api.github.com/users/nightwatchjs/followers","following_url":"https://api.github.com/users/nightwatchjs/following{/other_user}","gists_url":"https://api.github.com/users/nightwatchjs/gists{/gist_id}","starred_url":"https://api.github.com/users/nightwatchjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nightwatchjs/subscriptions","organizations_url":"https://api.github.com/users/nightwatchjs/orgs","repos_url":"https://api.github.com/users/nightwatchjs/repos","events_url":"https://api.github.com/users/nightwatchjs/events{/privacy}","received_events_url":"https://api.github.com/users/nightwatchjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nightwatchjs/nightwatch","description":"Automated testing and continous integration framework based on node.js and selenium webdriver","fork":false,"url":"https://api.github.com/repos/nightwatchjs/nightwatch","forks_url":"https://api.github.com/repos/nightwatchjs/nightwatch/forks","keys_url":"https://api.github.com/repos/nightwatchjs/nightwatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nightwatchjs/nightwatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nightwatchjs/nightwatch/teams","hooks_url":"https://api.github.com/repos/nightwatchjs/nightwatch/hooks","issue_events_url":"https://api.github.com/repos/nightwatchjs/nightwatch/issues/events{/number}","events_url":"https://api.github.com/repos/nightwatchjs/nightwatch/events","assignees_url":"https://api.github.com/repos/nightwatchjs/nightwatch/assignees{/user}","branches_url":"https://api.github.com/repos/nightwatchjs/nightwatch/branches{/branch}","tags_url":"https://api.github.com/repos/nightwatchjs/nightwatch/tags","blobs_url":"https://api.github.com/repos/nightwatchjs/nightwatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nightwatchjs/nightwatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nightwatchjs/nightwatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/nightwatchjs/nightwatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nightwatchjs/nightwatch/statuses/{sha}","languages_url":"https://api.github.com/repos/nightwatchjs/nightwatch/languages","stargazers_url":"https://api.github.com/repos/nightwatchjs/nightwatch/stargazers","contributors_url":"https://api.github.com/repos/nightwatchjs/nightwatch/contributors","subscribers_url":"https://api.github.com/repos/nightwatchjs/nightwatch/subscribers","subscription_url":"https://api.github.com/repos/nightwatchjs/nightwatch/subscription","commits_url":"https://api.github.com/repos/nightwatchjs/nightwatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/nightwatchjs/nightwatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/nightwatchjs/nightwatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/nightwatchjs/nightwatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/nightwatchjs/nightwatch/contents/{+path}","compare_url":"https://api.github.com/repos/nightwatchjs/nightwatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nightwatchjs/nightwatch/merges","archive_url":"https://api.github.com/repos/nightwatchjs/nightwatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nightwatchjs/nightwatch/downloads","issues_url":"https://api.github.com/repos/nightwatchjs/nightwatch/issues{/number}","pulls_url":"https://api.github.com/repos/nightwatchjs/nightwatch/pulls{/number}","milestones_url":"https://api.github.com/repos/nightwatchjs/nightwatch/milestones{/number}","notifications_url":"https://api.github.com/repos/nightwatchjs/nightwatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nightwatchjs/nightwatch/labels{/name}","releases_url":"https://api.github.com/repos/nightwatchjs/nightwatch/releases{/id}","deployments_url":"https://api.github.com/repos/nightwatchjs/nightwatch/deployments","created_at":"2012-03-17T21:28:18Z","updated_at":"2016-08-12T18:45:54Z","pushed_at":"2016-08-12T19:51:44Z","git_url":"git://github.com/nightwatchjs/nightwatch.git","ssh_url":"git@github.com:nightwatchjs/nightwatch.git","clone_url":"https://github.com/nightwatchjs/nightwatch.git","svn_url":"https://github.com/nightwatchjs/nightwatch","homepage":"http://nightwatchjs.org","size":47224,"stargazers_count":4829,"watchers_count":4829,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":434,"mirror_url":null,"open_issues_count":213,"forks":434,"open_issues":213,"watchers":4829,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nightwatchjs/nightwatch/pulls/987"},"html":{"href":"https://github.com/nightwatchjs/nightwatch/pull/987"},"issue":{"href":"https://api.github.com/repos/nightwatchjs/nightwatch/issues/987"},"comments":{"href":"https://api.github.com/repos/nightwatchjs/nightwatch/issues/987/comments"},"review_comments":{"href":"https://api.github.com/repos/nightwatchjs/nightwatch/pulls/987/comments"},"review_comment":{"href":"https://api.github.com/repos/nightwatchjs/nightwatch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nightwatchjs/nightwatch/pulls/987/commits"},"statuses":{"href":"https://api.github.com/repos/nightwatchjs/nightwatch/statuses/59eb8083edc48fae658cadfc0b16dca1c80884c1"}}}}
{"actor":{"display_login":"beatfactor"}}