{"action":"created","issue":{"url":"https://api.github.com/repos/relayrides/pushy/issues/292","repository_url":"https://api.github.com/repos/relayrides/pushy","labels_url":"https://api.github.com/repos/relayrides/pushy/issues/292/labels{/name}","comments_url":"https://api.github.com/repos/relayrides/pushy/issues/292/comments","events_url":"https://api.github.com/repos/relayrides/pushy/issues/292/events","html_url":"https://github.com/relayrides/pushy/issues/292","id":154073587,"number":292,"title":"P12Util didn't reject a keystore with multiple private keys","user":{"login":"jchambers","id":31352,"avatar_url":"https://avatars.githubusercontent.com/u/31352?v=3","gravatar_id":"","url":"https://api.github.com/users/jchambers","html_url":"https://github.com/jchambers","followers_url":"https://api.github.com/users/jchambers/followers","following_url":"https://api.github.com/users/jchambers/following{/other_user}","gists_url":"https://api.github.com/users/jchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/jchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchambers/subscriptions","organizations_url":"https://api.github.com/users/jchambers/orgs","repos_url":"https://api.github.com/users/jchambers/repos","events_url":"https://api.github.com/users/jchambers/events{/privacy}","received_events_url":"https://api.github.com/users/jchambers/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/relayrides/pushy/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/relayrides/pushy/milestones/16","html_url":"https://github.com/relayrides/pushy/milestones/v0.7.3","labels_url":"https://api.github.com/repos/relayrides/pushy/milestones/16/labels","id":1748564,"number":16,"title":"v0.7.3","description":"","creator":{"login":"jchambers","id":31352,"avatar_url":"https://avatars.githubusercontent.com/u/31352?v=3","gravatar_id":"","url":"https://api.github.com/users/jchambers","html_url":"https://github.com/jchambers","followers_url":"https://api.github.com/users/jchambers/followers","following_url":"https://api.github.com/users/jchambers/following{/other_user}","gists_url":"https://api.github.com/users/jchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/jchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchambers/subscriptions","organizations_url":"https://api.github.com/users/jchambers/orgs","repos_url":"https://api.github.com/users/jchambers/repos","events_url":"https://api.github.com/users/jchambers/events{/privacy}","received_events_url":"https://api.github.com/users/jchambers/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":8,"state":"open","created_at":"2016-05-04T20:37:21Z","updated_at":"2016-05-28T21:23:40Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-05-10T18:22:27Z","updated_at":"2016-06-04T19:14:15Z","closed_at":null,"body":"As [discussed on the mailing list](https://groups.google.com/d/msg/pushy-apns/3HonwEuUxYk/oBioFgMyFAAJ), it sounds like `P12Util` may not be rejecting all keystores with multiple private key entries."},"comment":{"url":"https://api.github.com/repos/relayrides/pushy/issues/comments/223772910","html_url":"https://github.com/relayrides/pushy/issues/292#issuecomment-223772910","issue_url":"https://api.github.com/repos/relayrides/pushy/issues/292","id":223772910,"user":{"login":"jchambers","id":31352,"avatar_url":"https://avatars.githubusercontent.com/u/31352?v=3","gravatar_id":"","url":"https://api.github.com/users/jchambers","html_url":"https://github.com/jchambers","followers_url":"https://api.github.com/users/jchambers/followers","following_url":"https://api.github.com/users/jchambers/following{/other_user}","gists_url":"https://api.github.com/users/jchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/jchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchambers/subscriptions","organizations_url":"https://api.github.com/users/jchambers/orgs","repos_url":"https://api.github.com/users/jchambers/repos","events_url":"https://api.github.com/users/jchambers/events{/privacy}","received_events_url":"https://api.github.com/users/jchambers/received_events","type":"User","site_admin":false},"created_at":"2016-06-04T19:14:15Z","updated_at":"2016-06-04T19:14:15Z","body":"I filed a bug report with Oracle about the issue, which is under review as `JI-9038550`. I don't know if or when it will be considered a real bug, much less when it might be fixed.\r\n\r\nSo now the ironic situation is that the case we're most worried about (since it's a really easy [situation](https://github.com/relayrides/pushy/wiki/Certificates) to get into with Keychain Access) is also the case we know we can't detect.\r\n\r\nWe can continue to complain about multi-key keystores *when we can detect them*, but that doesn't really change the guarantees we can make to users. At that point I wonder if it would be better to drop the check entirely and point out that the behavior for a multi-key keystore is undefined. At least then we wouldn't be giving a sense that we're offering protection against something we can't control. I took a shot at exactly that in [`undefined_multiple_key_behavior`](https://github.com/relayrides/pushy/compare/undefined_multiple_key_behavior).\r\n\r\nTo the audience, what do you all think?"}}
{"actor":{"display_login":"jchambers"}}