{"action":"created","comment":{"url":"https://api.github.com/repos/Geal/nom/pulls/comments/94228910","pull_request_review_id":14759745,"id":94228910,"diff_hunk":"@@ -235,7 +235,7 @@ pub fn slice_to_offsets(input: &[u8], s: &[u8]) -> (usize, usize) {\n \n #[cfg(not(feature = \"core\"))]\n #[cfg(feature = \"verbose-errors\")]\n-pub fn prepare_errors<O,E: Clone>(input: &[u8], res: IResult<&[u8],O,E>) -> Option<Vec<(ErrorKind<E>, usize, usize)> > {\n+pub fn prepare_errors<O,E: Clone>(input: &[u8], res: IResult<&[u8], O, E>) -> Option<Vec<(ErrorKind<E>, usize, usize)> > {","path":"src/util.rs","position":5,"original_position":5,"commit_id":"75340c3a531c29072a1086499504c1788d100a4a","original_commit_id":"75340c3a531c29072a1086499504c1788d100a4a","user":{"login":"Geal","id":119296,"avatar_url":"https://avatars.githubusercontent.com/u/119296?v=3","gravatar_id":"","url":"https://api.github.com/users/Geal","html_url":"https://github.com/Geal","followers_url":"https://api.github.com/users/Geal/followers","following_url":"https://api.github.com/users/Geal/following{/other_user}","gists_url":"https://api.github.com/users/Geal/gists{/gist_id}","starred_url":"https://api.github.com/users/Geal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geal/subscriptions","organizations_url":"https://api.github.com/users/Geal/orgs","repos_url":"https://api.github.com/users/Geal/repos","events_url":"https://api.github.com/users/Geal/events{/privacy}","received_events_url":"https://api.github.com/users/Geal/received_events","type":"User","site_admin":false},"body":"please avoid cosmetic changes in unrelated parts of the code","created_at":"2016-12-30T13:54:30Z","updated_at":"2016-12-30T13:55:20Z","html_url":"https://github.com/Geal/nom/pull/413#discussion_r94228910","pull_request_url":"https://api.github.com/repos/Geal/nom/pulls/413","_links":{"self":{"href":"https://api.github.com/repos/Geal/nom/pulls/comments/94228910"},"html":{"href":"https://github.com/Geal/nom/pull/413#discussion_r94228910"},"pull_request":{"href":"https://api.github.com/repos/Geal/nom/pulls/413"}}},"pull_request":{"url":"https://api.github.com/repos/Geal/nom/pulls/413","id":99740773,"html_url":"https://github.com/Geal/nom/pull/413","diff_url":"https://github.com/Geal/nom/pull/413.diff","patch_url":"https://github.com/Geal/nom/pull/413.patch","issue_url":"https://api.github.com/repos/Geal/nom/issues/413","number":413,"state":"open","locked":false,"title":"[WIP] Propagated error type.","user":{"login":"kdy1997","id":18233865,"avatar_url":"https://avatars.githubusercontent.com/u/18233865?v=3","gravatar_id":"","url":"https://api.github.com/users/kdy1997","html_url":"https://github.com/kdy1997","followers_url":"https://api.github.com/users/kdy1997/followers","following_url":"https://api.github.com/users/kdy1997/following{/other_user}","gists_url":"https://api.github.com/users/kdy1997/gists{/gist_id}","starred_url":"https://api.github.com/users/kdy1997/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdy1997/subscriptions","organizations_url":"https://api.github.com/users/kdy1997/orgs","repos_url":"https://api.github.com/users/kdy1997/repos","events_url":"https://api.github.com/users/kdy1997/events{/privacy}","received_events_url":"https://api.github.com/users/kdy1997/received_events","type":"User","site_admin":false},"body":"Error types are implicitly passed around, and gives hints about type of error to rustc.\r\n\r\nFixes #302  #308 #394 \r\n\r\n\r\n\r\nSome macros are currently broken. \r\n## Fix:\r\n \r\n- [x] many1\r\n- [x] many0\r\n- [x] separated_list\r\n- [x] separated_nonempty_list\r\n- [ ] delimited\r\n- [x] many_till\r\n- [ ] and some more..\r\n\r\n\r\nI need some help to fix delimited!(), what does tuple_parser!() do?\r\nHow can I get it's error value?\r\n\r\n\r\n","created_at":"2016-12-30T10:44:54Z","updated_at":"2016-12-30T13:55:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0019abd05b64a32ed3b8ad20a5dcb665c71ef07","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Geal/nom/pulls/413/commits","review_comments_url":"https://api.github.com/repos/Geal/nom/pulls/413/comments","review_comment_url":"https://api.github.com/repos/Geal/nom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Geal/nom/issues/413/comments","statuses_url":"https://api.github.com/repos/Geal/nom/statuses/75340c3a531c29072a1086499504c1788d100a4a","head":{"label":"kdy1997:master","ref":"master","sha":"75340c3a531c29072a1086499504c1788d100a4a","user":{"login":"kdy1997","id":18233865,"avatar_url":"https://avatars.githubusercontent.com/u/18233865?v=3","gravatar_id":"","url":"https://api.github.com/users/kdy1997","html_url":"https://github.com/kdy1997","followers_url":"https://api.github.com/users/kdy1997/followers","following_url":"https://api.github.com/users/kdy1997/following{/other_user}","gists_url":"https://api.github.com/users/kdy1997/gists{/gist_id}","starred_url":"https://api.github.com/users/kdy1997/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdy1997/subscriptions","organizations_url":"https://api.github.com/users/kdy1997/orgs","repos_url":"https://api.github.com/users/kdy1997/repos","events_url":"https://api.github.com/users/kdy1997/events{/privacy}","received_events_url":"https://api.github.com/users/kdy1997/received_events","type":"User","site_admin":false},"repo":{"id":77615140,"name":"nom","full_name":"kdy1997/nom","owner":{"login":"kdy1997","id":18233865,"avatar_url":"https://avatars.githubusercontent.com/u/18233865?v=3","gravatar_id":"","url":"https://api.github.com/users/kdy1997","html_url":"https://github.com/kdy1997","followers_url":"https://api.github.com/users/kdy1997/followers","following_url":"https://api.github.com/users/kdy1997/following{/other_user}","gists_url":"https://api.github.com/users/kdy1997/gists{/gist_id}","starred_url":"https://api.github.com/users/kdy1997/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdy1997/subscriptions","organizations_url":"https://api.github.com/users/kdy1997/orgs","repos_url":"https://api.github.com/users/kdy1997/repos","events_url":"https://api.github.com/users/kdy1997/events{/privacy}","received_events_url":"https://api.github.com/users/kdy1997/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kdy1997/nom","description":"Rust parser combinator framework","fork":true,"url":"https://api.github.com/repos/kdy1997/nom","forks_url":"https://api.github.com/repos/kdy1997/nom/forks","keys_url":"https://api.github.com/repos/kdy1997/nom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kdy1997/nom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kdy1997/nom/teams","hooks_url":"https://api.github.com/repos/kdy1997/nom/hooks","issue_events_url":"https://api.github.com/repos/kdy1997/nom/issues/events{/number}","events_url":"https://api.github.com/repos/kdy1997/nom/events","assignees_url":"https://api.github.com/repos/kdy1997/nom/assignees{/user}","branches_url":"https://api.github.com/repos/kdy1997/nom/branches{/branch}","tags_url":"https://api.github.com/repos/kdy1997/nom/tags","blobs_url":"https://api.github.com/repos/kdy1997/nom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kdy1997/nom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kdy1997/nom/git/refs{/sha}","trees_url":"https://api.github.com/repos/kdy1997/nom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kdy1997/nom/statuses/{sha}","languages_url":"https://api.github.com/repos/kdy1997/nom/languages","stargazers_url":"https://api.github.com/repos/kdy1997/nom/stargazers","contributors_url":"https://api.github.com/repos/kdy1997/nom/contributors","subscribers_url":"https://api.github.com/repos/kdy1997/nom/subscribers","subscription_url":"https://api.github.com/repos/kdy1997/nom/subscription","commits_url":"https://api.github.com/repos/kdy1997/nom/commits{/sha}","git_commits_url":"https://api.github.com/repos/kdy1997/nom/git/commits{/sha}","comments_url":"https://api.github.com/repos/kdy1997/nom/comments{/number}","issue_comment_url":"https://api.github.com/repos/kdy1997/nom/issues/comments{/number}","contents_url":"https://api.github.com/repos/kdy1997/nom/contents/{+path}","compare_url":"https://api.github.com/repos/kdy1997/nom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kdy1997/nom/merges","archive_url":"https://api.github.com/repos/kdy1997/nom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kdy1997/nom/downloads","issues_url":"https://api.github.com/repos/kdy1997/nom/issues{/number}","pulls_url":"https://api.github.com/repos/kdy1997/nom/pulls{/number}","milestones_url":"https://api.github.com/repos/kdy1997/nom/milestones{/number}","notifications_url":"https://api.github.com/repos/kdy1997/nom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kdy1997/nom/labels{/name}","releases_url":"https://api.github.com/repos/kdy1997/nom/releases{/id}","deployments_url":"https://api.github.com/repos/kdy1997/nom/deployments","created_at":"2016-12-29T13:46:54Z","updated_at":"2016-12-29T13:46:57Z","pushed_at":"2016-12-30T13:30:04Z","git_url":"git://github.com/kdy1997/nom.git","ssh_url":"git@github.com:kdy1997/nom.git","clone_url":"https://github.com/kdy1997/nom.git","svn_url":"https://github.com/kdy1997/nom","homepage":"","size":6802,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Geal:master","ref":"master","sha":"80a1deab58d1faf41c05a5d741d9e3f51bde3a55","user":{"login":"Geal","id":119296,"avatar_url":"https://avatars.githubusercontent.com/u/119296?v=3","gravatar_id":"","url":"https://api.github.com/users/Geal","html_url":"https://github.com/Geal","followers_url":"https://api.github.com/users/Geal/followers","following_url":"https://api.github.com/users/Geal/following{/other_user}","gists_url":"https://api.github.com/users/Geal/gists{/gist_id}","starred_url":"https://api.github.com/users/Geal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geal/subscriptions","organizations_url":"https://api.github.com/users/Geal/orgs","repos_url":"https://api.github.com/users/Geal/repos","events_url":"https://api.github.com/users/Geal/events{/privacy}","received_events_url":"https://api.github.com/users/Geal/received_events","type":"User","site_admin":false},"repo":{"id":27029984,"name":"nom","full_name":"Geal/nom","owner":{"login":"Geal","id":119296,"avatar_url":"https://avatars.githubusercontent.com/u/119296?v=3","gravatar_id":"","url":"https://api.github.com/users/Geal","html_url":"https://github.com/Geal","followers_url":"https://api.github.com/users/Geal/followers","following_url":"https://api.github.com/users/Geal/following{/other_user}","gists_url":"https://api.github.com/users/Geal/gists{/gist_id}","starred_url":"https://api.github.com/users/Geal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geal/subscriptions","organizations_url":"https://api.github.com/users/Geal/orgs","repos_url":"https://api.github.com/users/Geal/repos","events_url":"https://api.github.com/users/Geal/events{/privacy}","received_events_url":"https://api.github.com/users/Geal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Geal/nom","description":"Rust parser combinator framework","fork":false,"url":"https://api.github.com/repos/Geal/nom","forks_url":"https://api.github.com/repos/Geal/nom/forks","keys_url":"https://api.github.com/repos/Geal/nom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Geal/nom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Geal/nom/teams","hooks_url":"https://api.github.com/repos/Geal/nom/hooks","issue_events_url":"https://api.github.com/repos/Geal/nom/issues/events{/number}","events_url":"https://api.github.com/repos/Geal/nom/events","assignees_url":"https://api.github.com/repos/Geal/nom/assignees{/user}","branches_url":"https://api.github.com/repos/Geal/nom/branches{/branch}","tags_url":"https://api.github.com/repos/Geal/nom/tags","blobs_url":"https://api.github.com/repos/Geal/nom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Geal/nom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Geal/nom/git/refs{/sha}","trees_url":"https://api.github.com/repos/Geal/nom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Geal/nom/statuses/{sha}","languages_url":"https://api.github.com/repos/Geal/nom/languages","stargazers_url":"https://api.github.com/repos/Geal/nom/stargazers","contributors_url":"https://api.github.com/repos/Geal/nom/contributors","subscribers_url":"https://api.github.com/repos/Geal/nom/subscribers","subscription_url":"https://api.github.com/repos/Geal/nom/subscription","commits_url":"https://api.github.com/repos/Geal/nom/commits{/sha}","git_commits_url":"https://api.github.com/repos/Geal/nom/git/commits{/sha}","comments_url":"https://api.github.com/repos/Geal/nom/comments{/number}","issue_comment_url":"https://api.github.com/repos/Geal/nom/issues/comments{/number}","contents_url":"https://api.github.com/repos/Geal/nom/contents/{+path}","compare_url":"https://api.github.com/repos/Geal/nom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Geal/nom/merges","archive_url":"https://api.github.com/repos/Geal/nom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Geal/nom/downloads","issues_url":"https://api.github.com/repos/Geal/nom/issues{/number}","pulls_url":"https://api.github.com/repos/Geal/nom/pulls{/number}","milestones_url":"https://api.github.com/repos/Geal/nom/milestones{/number}","notifications_url":"https://api.github.com/repos/Geal/nom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Geal/nom/labels{/name}","releases_url":"https://api.github.com/repos/Geal/nom/releases{/id}","deployments_url":"https://api.github.com/repos/Geal/nom/deployments","created_at":"2014-11-23T11:16:23Z","updated_at":"2016-12-30T01:19:45Z","pushed_at":"2016-12-30T13:30:05Z","git_url":"git://github.com/Geal/nom.git","ssh_url":"git@github.com:Geal/nom.git","clone_url":"https://github.com/Geal/nom.git","svn_url":"https://github.com/Geal/nom","homepage":"","size":6931,"stargazers_count":1123,"watchers_count":1123,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":134,"mirror_url":null,"open_issues_count":85,"forks":134,"open_issues":85,"watchers":1123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Geal/nom/pulls/413"},"html":{"href":"https://github.com/Geal/nom/pull/413"},"issue":{"href":"https://api.github.com/repos/Geal/nom/issues/413"},"comments":{"href":"https://api.github.com/repos/Geal/nom/issues/413/comments"},"review_comments":{"href":"https://api.github.com/repos/Geal/nom/pulls/413/comments"},"review_comment":{"href":"https://api.github.com/repos/Geal/nom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Geal/nom/pulls/413/commits"},"statuses":{"href":"https://api.github.com/repos/Geal/nom/statuses/75340c3a531c29072a1086499504c1788d100a4a"}}}}
{"actor":{"display_login":"Geal"}}