{"action":"closed","issue":{"url":"https://api.github.com/repos/shama/gaze/issues/173","repository_url":"https://api.github.com/repos/shama/gaze","labels_url":"https://api.github.com/repos/shama/gaze/issues/173/labels{/name}","comments_url":"https://api.github.com/repos/shama/gaze/issues/173/comments","events_url":"https://api.github.com/repos/shama/gaze/issues/173/events","html_url":"https://github.com/shama/gaze/issues/173","id":54550419,"number":173,"title":"io.js support","user":{"login":"timoxley","id":43438,"avatar_url":"https://avatars.githubusercontent.com/u/43438?v=3","gravatar_id":"","url":"https://api.github.com/users/timoxley","html_url":"https://github.com/timoxley","followers_url":"https://api.github.com/users/timoxley/followers","following_url":"https://api.github.com/users/timoxley/following{/other_user}","gists_url":"https://api.github.com/users/timoxley/gists{/gist_id}","starred_url":"https://api.github.com/users/timoxley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timoxley/subscriptions","organizations_url":"https://api.github.com/users/timoxley/orgs","repos_url":"https://api.github.com/users/timoxley/repos","events_url":"https://api.github.com/users/timoxley/events{/privacy}","received_events_url":"https://api.github.com/users/timoxley/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/shama/gaze/labels/priority","name":"priority","color":"eb6420"}],"state":"closed","locked":false,"assignee":{"login":"shama","id":99604,"avatar_url":"https://avatars.githubusercontent.com/u/99604?v=3","gravatar_id":"","url":"https://api.github.com/users/shama","html_url":"https://github.com/shama","followers_url":"https://api.github.com/users/shama/followers","following_url":"https://api.github.com/users/shama/following{/other_user}","gists_url":"https://api.github.com/users/shama/gists{/gist_id}","starred_url":"https://api.github.com/users/shama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shama/subscriptions","organizations_url":"https://api.github.com/users/shama/orgs","repos_url":"https://api.github.com/users/shama/repos","events_url":"https://api.github.com/users/shama/events{/privacy}","received_events_url":"https://api.github.com/users/shama/received_events","type":"User","site_admin":false},"assignees":[{"login":"shama","id":99604,"avatar_url":"https://avatars.githubusercontent.com/u/99604?v=3","gravatar_id":"","url":"https://api.github.com/users/shama","html_url":"https://github.com/shama","followers_url":"https://api.github.com/users/shama/followers","following_url":"https://api.github.com/users/shama/following{/other_user}","gists_url":"https://api.github.com/users/shama/gists{/gist_id}","starred_url":"https://api.github.com/users/shama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shama/subscriptions","organizations_url":"https://api.github.com/users/shama/orgs","repos_url":"https://api.github.com/users/shama/repos","events_url":"https://api.github.com/users/shama/events{/privacy}","received_events_url":"https://api.github.com/users/shama/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2015-01-16T08:16:25Z","updated_at":"2016-08-03T03:57:12Z","closed_at":"2016-08-03T03:57:12Z","body":"Updated to latest nan to get io.js support, but looks like there are some code changes required to get gaze to build on io.js.\r\n\r\n```\r\n> npm install nan@latest --save\r\nnpm http request GET https://registry.npmjs.org/nan\r\nnpm http 304 https://registry.npmjs.org/nan\r\nnan@1.5.1 node_modules/nan\r\n\r\n> npm install\r\n\r\n> gaze@0.6.4 install /Users/timoxley/Projects/libs/gaze\r\n> node build.js\r\n\r\nchild_process: customFds option is deprecated, use stdio instead.\r\nchild_process: customFds option is deprecated, use stdio instead.\r\n  CXX(target) Release/obj.target/pathwatcher/src/main.o\r\nIn file included from ../src/main.cc:22:\r\nIn file included from ../src/handle_map.h:27:\r\n../src/unsafe_persistent.h:38:38: error: expected ')'\r\n  NAN_INLINE(v8::Persistent<TypeName>* persistent()) {\r\n                                     ^\r\n../src/unsafe_persistent.h:38:13: note: to match this '('\r\n  NAN_INLINE(v8::Persistent<TypeName>* persistent()) {\r\n            ^\r\n../src/unsafe_persistent.h:38:18: error: non-friend class member 'Persistent' cannot have a qualified name\r\n  NAN_INLINE(v8::Persistent<TypeName>* persistent()) {\r\n             ~~~~^\r\n../src/unsafe_persistent.h:38:18: error: C++ requires a type specifier for all declarations\r\n  NAN_INLINE(v8::Persistent<TypeName>* persistent()) {\r\n  ~~~~~~~~~~     ^\r\n../src/unsafe_persistent.h:38:3: error: 'inline' can only appear on functions\r\n  NAN_INLINE(v8::Persistent<TypeName>* persistent()) {\r\n  ^\r\n../node_modules/nan/nan.h:36:21: note: expanded from macro 'NAN_INLINE'\r\n# define NAN_INLINE inline __attribute__((always_inline))\r\n                    ^\r\nIn file included from ../src/main.cc:22:\r\nIn file included from ../src/handle_map.h:27:\r\n../src/unsafe_persistent.h:38:3: warning: 'always_inline' attribute only applies to functions [-Wignored-attributes]\r\n../node_modules/nan/nan.h:36:43: note: expanded from macro 'NAN_INLINE'\r\n# define NAN_INLINE inline __attribute__((always_inline))\r\n                                          ^\r\nIn file included from ../src/main.cc:22:\r\nIn file included from ../src/handle_map.h:27:\r\n../src/unsafe_persistent.h:40:5: error: expected member name or ';' after declaration specifiers\r\n    return handle;\r\n    ^~~~~~\r\n../src/unsafe_persistent.h:29:27: error: member initializer 'value' does not name a non-static data member or base class\r\n  NanUnsafePersistent() : value(0) { }\r\n                          ^~~~~~~~\r\n../src/unsafe_persistent.h:31:5: error: use of undeclared identifier 'value'\r\n    value = handle->ClearAndLeak();\r\n    ^\r\n../src/unsafe_persistent.h:34:41: error: use of undeclared identifier 'nan_isolate'\r\n    v8::Persistent<TypeName> persistent(nan_isolate, handle);\r\n                                        ^\r\n../src/unsafe_persistent.h:35:5: error: use of undeclared identifier 'value'\r\n    value = persistent.ClearAndLeak();\r\n    ^\r\n../src/unsafe_persistent.h:41:4: error: expected ';' after class\r\n  }\r\n   ^\r\n   ;\r\n../src/unsafe_persistent.h:43:14: error: expected unqualified-id\r\n  NAN_INLINE(void Dispose()) {\r\n             ^\r\n../src/unsafe_persistent.h:43:14: error: expected ')'\r\n../src/unsafe_persistent.h:43:13: note: to match this '('\r\n  NAN_INLINE(void Dispose()) {\r\n            ^\r\n../src/unsafe_persistent.h:48:14: error: expected unqualified-id\r\n  NAN_INLINE(void Clear()) {\r\n             ^\r\n../src/unsafe_persistent.h:48:14: error: expected ')'\r\n../src/unsafe_persistent.h:48:13: note: to match this '('\r\n  NAN_INLINE(void Clear()) {\r\n            ^\r\n../src/unsafe_persistent.h:52:24: error: use of undeclared identifier 'TypeName'; did you mean 'typename'?\r\n  NAN_INLINE(v8::Local<TypeName> NewLocal()) {\r\n                       ^~~~~~~~\r\n                       typename\r\n../src/unsafe_persistent.h:52:32: error: expected a qualified name after 'typename'\r\n  NAN_INLINE(v8::Local<TypeName> NewLocal()) {\r\n                               ^\r\n../src/unsafe_persistent.h:52:32: error: expected a type\r\n../src/unsafe_persistent.h:52:34: error: C++ requires a type specifier for all declarations\r\n  NAN_INLINE(v8::Local<TypeName> NewLocal()) {\r\n  ~~~~~~~~~~                     ^\r\n../src/unsafe_persistent.h:53:22: error: use of undeclared identifier 'TypeName'; did you mean 'typename'?\r\n    return v8::Local<TypeName>::New(nan_isolate, *persistent());\r\n                     ^~~~~~~~\r\n                     typename\r\nfatal error: too many errors emitted, stopping now [-ferror-limit=]\r\n1 warning and 20 errors generated.\r\nmake: *** [Release/obj.target/pathwatcher/src/main.o] Error 1\r\ngyp ERR! build error\r\ngyp ERR! stack Error: `make` failed with exit code: 2\r\ngyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23)\r\ngyp ERR! stack     at ChildProcess.emit (events.js:98:17)\r\ngyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:1038:12)\r\ngyp ERR! System Darwin 14.1.0\r\ngyp ERR! command \"node\" \"/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js\" \"rebuild\"\r\ngyp ERR! cwd /Users/timoxley/Projects/libs/gaze\r\ngyp ERR! node -v v1.0.2\r\ngyp ERR! node-gyp -v v1.0.2\r\ngyp ERR! not ok\r\nBuild failed\r\n\r\nnpm ERR! Darwin 14.1.0\r\nnpm ERR! argv \"node\" \"/usr/local/bin/npm\" \"install\"\r\nnpm ERR! node v1.0.2\r\nnpm ERR! npm  v2.1.18\r\nnpm ERR! code ELIFECYCLE\r\nnpm ERR! gaze@0.6.4 install: `node build.js`\r\nnpm ERR! Exit status 1\r\nnpm ERR!\r\nnpm ERR! Failed at the gaze@0.6.4 install script 'node build.js'.\r\nnpm ERR! This is most likely a problem with the gaze package,\r\nnpm ERR! not with npm itself.\r\nnpm ERR! Tell the author that this fails on your system:\r\nnpm ERR!     node build.js\r\nnpm ERR! You can get their info via:\r\nnpm ERR!     npm owner ls gaze\r\nnpm ERR! There is likely additional logging output above.\r\n\r\nnpm ERR! Please include the following file with any support request:\r\nnpm ERR!     /Users/timoxley/Projects/libs/gaze/npm-debug.log\r\n```"}}
{"actor":{"display_login":"shama"}}