{"action":"closed","number":18,"pull_request":{"url":"https://api.github.com/repos/chevah/styleguide/pulls/18","id":62687150,"html_url":"https://github.com/chevah/styleguide/pull/18","diff_url":"https://github.com/chevah/styleguide/pull/18.diff","patch_url":"https://github.com/chevah/styleguide/pull/18.patch","issue_url":"https://api.github.com/repos/chevah/styleguide/issues/18","number":18,"state":"closed","locked":false,"title":"Update the documentation about our review process.","user":{"login":"adiroiban","id":204609,"avatar_url":"https://avatars.githubusercontent.com/u/204609?v=3","gravatar_id":"","url":"https://api.github.com/users/adiroiban","html_url":"https://github.com/adiroiban","followers_url":"https://api.github.com/users/adiroiban/followers","following_url":"https://api.github.com/users/adiroiban/following{/other_user}","gists_url":"https://api.github.com/users/adiroiban/gists{/gist_id}","starred_url":"https://api.github.com/users/adiroiban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adiroiban/subscriptions","organizations_url":"https://api.github.com/users/adiroiban/orgs","repos_url":"https://api.github.com/users/adiroiban/repos","events_url":"https://api.github.com/users/adiroiban/events{/privacy}","received_events_url":"https://api.github.com/users/adiroiban/received_events","type":"User","site_admin":false},"body":"Scope\r\n=====\r\n\r\nBased on the feedback received from @brunogola I tried to update the documentation for our review process.\r\n\r\n\r\nChanges\r\n=======\r\n\r\nReviewer's check list was split based on roles as the dev will do a different type of review as from the QA role.\r\n\r\nUpdated the command lines used as helpers for the review process.\r\n\r\n\r\nHow to try and test the changes\r\n===============================\r\n\r\nreviewers: @brunogola @alibotean @lgheorghiu \r\n\r\ncheck that changes make sense and please suggest changes.\r\n\r\n@brunogola I think that most of the review related info from your https://github.com/chevah/styleguide/tree/github-and-trac-integration-docs branch is already here... just that it is hidden.\r\n\r\nYou might want to contribute to this branch and create a quick section descriting just the github - trac integration in term of review process. The needs-review and needs-changes marker are not only for Trac sync but to also allow us to create a sound workflow on top of the primitive tools provided by GitHub.\r\n\r\n","created_at":"2016-03-13T23:12:45Z","updated_at":"2016-04-14T16:18:59Z","closed_at":"2016-04-14T16:18:59Z","merged_at":"2016-04-14T16:18:59Z","merge_commit_sha":"d688ccc6aaadf1cf3c4c41cf5aadedb62d434a52","assignee":{"login":"adiroiban","id":204609,"avatar_url":"https://avatars.githubusercontent.com/u/204609?v=3","gravatar_id":"","url":"https://api.github.com/users/adiroiban","html_url":"https://github.com/adiroiban","followers_url":"https://api.github.com/users/adiroiban/followers","following_url":"https://api.github.com/users/adiroiban/following{/other_user}","gists_url":"https://api.github.com/users/adiroiban/gists{/gist_id}","starred_url":"https://api.github.com/users/adiroiban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adiroiban/subscriptions","organizations_url":"https://api.github.com/users/adiroiban/orgs","repos_url":"https://api.github.com/users/adiroiban/repos","events_url":"https://api.github.com/users/adiroiban/events{/privacy}","received_events_url":"https://api.github.com/users/adiroiban/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/chevah/styleguide/pulls/18/commits","review_comments_url":"https://api.github.com/repos/chevah/styleguide/pulls/18/comments","review_comment_url":"https://api.github.com/repos/chevah/styleguide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chevah/styleguide/issues/18/comments","statuses_url":"https://api.github.com/repos/chevah/styleguide/statuses/21e393bd1e489c0ffeab40e538b8d17e917022f8","head":{"label":"chevah:reviewer-checklist","ref":"reviewer-checklist","sha":"21e393bd1e489c0ffeab40e538b8d17e917022f8","user":{"login":"chevah","id":1153635,"avatar_url":"https://avatars.githubusercontent.com/u/1153635?v=3","gravatar_id":"","url":"https://api.github.com/users/chevah","html_url":"https://github.com/chevah","followers_url":"https://api.github.com/users/chevah/followers","following_url":"https://api.github.com/users/chevah/following{/other_user}","gists_url":"https://api.github.com/users/chevah/gists{/gist_id}","starred_url":"https://api.github.com/users/chevah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chevah/subscriptions","organizations_url":"https://api.github.com/users/chevah/orgs","repos_url":"https://api.github.com/users/chevah/repos","events_url":"https://api.github.com/users/chevah/events{/privacy}","received_events_url":"https://api.github.com/users/chevah/received_events","type":"Organization","site_admin":false},"repo":{"id":5093780,"name":"styleguide","full_name":"chevah/styleguide","owner":{"login":"chevah","id":1153635,"avatar_url":"https://avatars.githubusercontent.com/u/1153635?v=3","gravatar_id":"","url":"https://api.github.com/users/chevah","html_url":"https://github.com/chevah","followers_url":"https://api.github.com/users/chevah/followers","following_url":"https://api.github.com/users/chevah/following{/other_user}","gists_url":"https://api.github.com/users/chevah/gists{/gist_id}","starred_url":"https://api.github.com/users/chevah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chevah/subscriptions","organizations_url":"https://api.github.com/users/chevah/orgs","repos_url":"https://api.github.com/users/chevah/repos","events_url":"https://api.github.com/users/chevah/events{/privacy}","received_events_url":"https://api.github.com/users/chevah/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chevah/styleguide","description":"Guides and standards used by the Chevah project.","fork":false,"url":"https://api.github.com/repos/chevah/styleguide","forks_url":"https://api.github.com/repos/chevah/styleguide/forks","keys_url":"https://api.github.com/repos/chevah/styleguide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chevah/styleguide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chevah/styleguide/teams","hooks_url":"https://api.github.com/repos/chevah/styleguide/hooks","issue_events_url":"https://api.github.com/repos/chevah/styleguide/issues/events{/number}","events_url":"https://api.github.com/repos/chevah/styleguide/events","assignees_url":"https://api.github.com/repos/chevah/styleguide/assignees{/user}","branches_url":"https://api.github.com/repos/chevah/styleguide/branches{/branch}","tags_url":"https://api.github.com/repos/chevah/styleguide/tags","blobs_url":"https://api.github.com/repos/chevah/styleguide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chevah/styleguide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chevah/styleguide/git/refs{/sha}","trees_url":"https://api.github.com/repos/chevah/styleguide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chevah/styleguide/statuses/{sha}","languages_url":"https://api.github.com/repos/chevah/styleguide/languages","stargazers_url":"https://api.github.com/repos/chevah/styleguide/stargazers","contributors_url":"https://api.github.com/repos/chevah/styleguide/contributors","subscribers_url":"https://api.github.com/repos/chevah/styleguide/subscribers","subscription_url":"https://api.github.com/repos/chevah/styleguide/subscription","commits_url":"https://api.github.com/repos/chevah/styleguide/commits{/sha}","git_commits_url":"https://api.github.com/repos/chevah/styleguide/git/commits{/sha}","comments_url":"https://api.github.com/repos/chevah/styleguide/comments{/number}","issue_comment_url":"https://api.github.com/repos/chevah/styleguide/issues/comments{/number}","contents_url":"https://api.github.com/repos/chevah/styleguide/contents/{+path}","compare_url":"https://api.github.com/repos/chevah/styleguide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chevah/styleguide/merges","archive_url":"https://api.github.com/repos/chevah/styleguide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chevah/styleguide/downloads","issues_url":"https://api.github.com/repos/chevah/styleguide/issues{/number}","pulls_url":"https://api.github.com/repos/chevah/styleguide/pulls{/number}","milestones_url":"https://api.github.com/repos/chevah/styleguide/milestones{/number}","notifications_url":"https://api.github.com/repos/chevah/styleguide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chevah/styleguide/labels{/name}","releases_url":"https://api.github.com/repos/chevah/styleguide/releases{/id}","deployments_url":"https://api.github.com/repos/chevah/styleguide/deployments","created_at":"2012-07-18T08:52:10Z","updated_at":"2016-02-18T11:35:51Z","pushed_at":"2016-04-14T16:18:59Z","git_url":"git://github.com/chevah/styleguide.git","ssh_url":"git@github.com:chevah/styleguide.git","clone_url":"https://github.com/chevah/styleguide.git","svn_url":"https://github.com/chevah/styleguide","homepage":"http://styleguide.chevah.com/","size":1781,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"chevah:master","ref":"master","sha":"2923528e61947989c08709f72a950d1d35820fa5","user":{"login":"chevah","id":1153635,"avatar_url":"https://avatars.githubusercontent.com/u/1153635?v=3","gravatar_id":"","url":"https://api.github.com/users/chevah","html_url":"https://github.com/chevah","followers_url":"https://api.github.com/users/chevah/followers","following_url":"https://api.github.com/users/chevah/following{/other_user}","gists_url":"https://api.github.com/users/chevah/gists{/gist_id}","starred_url":"https://api.github.com/users/chevah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chevah/subscriptions","organizations_url":"https://api.github.com/users/chevah/orgs","repos_url":"https://api.github.com/users/chevah/repos","events_url":"https://api.github.com/users/chevah/events{/privacy}","received_events_url":"https://api.github.com/users/chevah/received_events","type":"Organization","site_admin":false},"repo":{"id":5093780,"name":"styleguide","full_name":"chevah/styleguide","owner":{"login":"chevah","id":1153635,"avatar_url":"https://avatars.githubusercontent.com/u/1153635?v=3","gravatar_id":"","url":"https://api.github.com/users/chevah","html_url":"https://github.com/chevah","followers_url":"https://api.github.com/users/chevah/followers","following_url":"https://api.github.com/users/chevah/following{/other_user}","gists_url":"https://api.github.com/users/chevah/gists{/gist_id}","starred_url":"https://api.github.com/users/chevah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chevah/subscriptions","organizations_url":"https://api.github.com/users/chevah/orgs","repos_url":"https://api.github.com/users/chevah/repos","events_url":"https://api.github.com/users/chevah/events{/privacy}","received_events_url":"https://api.github.com/users/chevah/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chevah/styleguide","description":"Guides and standards used by the Chevah project.","fork":false,"url":"https://api.github.com/repos/chevah/styleguide","forks_url":"https://api.github.com/repos/chevah/styleguide/forks","keys_url":"https://api.github.com/repos/chevah/styleguide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chevah/styleguide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chevah/styleguide/teams","hooks_url":"https://api.github.com/repos/chevah/styleguide/hooks","issue_events_url":"https://api.github.com/repos/chevah/styleguide/issues/events{/number}","events_url":"https://api.github.com/repos/chevah/styleguide/events","assignees_url":"https://api.github.com/repos/chevah/styleguide/assignees{/user}","branches_url":"https://api.github.com/repos/chevah/styleguide/branches{/branch}","tags_url":"https://api.github.com/repos/chevah/styleguide/tags","blobs_url":"https://api.github.com/repos/chevah/styleguide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chevah/styleguide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chevah/styleguide/git/refs{/sha}","trees_url":"https://api.github.com/repos/chevah/styleguide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chevah/styleguide/statuses/{sha}","languages_url":"https://api.github.com/repos/chevah/styleguide/languages","stargazers_url":"https://api.github.com/repos/chevah/styleguide/stargazers","contributors_url":"https://api.github.com/repos/chevah/styleguide/contributors","subscribers_url":"https://api.github.com/repos/chevah/styleguide/subscribers","subscription_url":"https://api.github.com/repos/chevah/styleguide/subscription","commits_url":"https://api.github.com/repos/chevah/styleguide/commits{/sha}","git_commits_url":"https://api.github.com/repos/chevah/styleguide/git/commits{/sha}","comments_url":"https://api.github.com/repos/chevah/styleguide/comments{/number}","issue_comment_url":"https://api.github.com/repos/chevah/styleguide/issues/comments{/number}","contents_url":"https://api.github.com/repos/chevah/styleguide/contents/{+path}","compare_url":"https://api.github.com/repos/chevah/styleguide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chevah/styleguide/merges","archive_url":"https://api.github.com/repos/chevah/styleguide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chevah/styleguide/downloads","issues_url":"https://api.github.com/repos/chevah/styleguide/issues{/number}","pulls_url":"https://api.github.com/repos/chevah/styleguide/pulls{/number}","milestones_url":"https://api.github.com/repos/chevah/styleguide/milestones{/number}","notifications_url":"https://api.github.com/repos/chevah/styleguide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chevah/styleguide/labels{/name}","releases_url":"https://api.github.com/repos/chevah/styleguide/releases{/id}","deployments_url":"https://api.github.com/repos/chevah/styleguide/deployments","created_at":"2012-07-18T08:52:10Z","updated_at":"2016-02-18T11:35:51Z","pushed_at":"2016-04-14T16:18:59Z","git_url":"git://github.com/chevah/styleguide.git","ssh_url":"git@github.com:chevah/styleguide.git","clone_url":"https://github.com/chevah/styleguide.git","svn_url":"https://github.com/chevah/styleguide","homepage":"http://styleguide.chevah.com/","size":1781,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chevah/styleguide/pulls/18"},"html":{"href":"https://github.com/chevah/styleguide/pull/18"},"issue":{"href":"https://api.github.com/repos/chevah/styleguide/issues/18"},"comments":{"href":"https://api.github.com/repos/chevah/styleguide/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/chevah/styleguide/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/chevah/styleguide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chevah/styleguide/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/chevah/styleguide/statuses/21e393bd1e489c0ffeab40e538b8d17e917022f8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"adiroiban","id":204609,"avatar_url":"https://avatars.githubusercontent.com/u/204609?v=3","gravatar_id":"","url":"https://api.github.com/users/adiroiban","html_url":"https://github.com/adiroiban","followers_url":"https://api.github.com/users/adiroiban/followers","following_url":"https://api.github.com/users/adiroiban/following{/other_user}","gists_url":"https://api.github.com/users/adiroiban/gists{/gist_id}","starred_url":"https://api.github.com/users/adiroiban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adiroiban/subscriptions","organizations_url":"https://api.github.com/users/adiroiban/orgs","repos_url":"https://api.github.com/users/adiroiban/repos","events_url":"https://api.github.com/users/adiroiban/events{/privacy}","received_events_url":"https://api.github.com/users/adiroiban/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":7,"additions":68,"deletions":16,"changed_files":1}}