{"action":"created","comment":{"url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/pulls/comments/71131214","id":71131214,"diff_hunk":"@@ -738,43 +738,63 @@ def get_status_color(cls, status_code, project_id=None):\n         return status_color\n \n     @classmethod\n-    def field_is_editable(cls, sg_entity_type, field_name):\n+    def field_is_editable(cls, sg_entity_type, field_name, project_id=None):\n         \"\"\"\n         Returns a boolean identifying the editability of the entity's field.\n \n         :param str sg_entity_type: the entity type\n         :param str field_name: the field name to check editibility\n+        :param project_id:  The id of the project.\n+                            If None, the current context's project will be used.","path":"python/shotgun_globals/cached_schema.py","position":12,"original_position":12,"commit_id":"621058cfaeecdc59e10c4d6f8f4c6c331d619501","original_commit_id":"621058cfaeecdc59e10c4d6f8f4c6c331d619501","user":{"login":"manneohrstrom","id":337710,"avatar_url":"https://avatars.githubusercontent.com/u/337710?v=3","gravatar_id":"","url":"https://api.github.com/users/manneohrstrom","html_url":"https://github.com/manneohrstrom","followers_url":"https://api.github.com/users/manneohrstrom/followers","following_url":"https://api.github.com/users/manneohrstrom/following{/other_user}","gists_url":"https://api.github.com/users/manneohrstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/manneohrstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manneohrstrom/subscriptions","organizations_url":"https://api.github.com/users/manneohrstrom/orgs","repos_url":"https://api.github.com/users/manneohrstrom/repos","events_url":"https://api.github.com/users/manneohrstrom/events{/privacy}","received_events_url":"https://api.github.com/users/manneohrstrom/received_events","type":"User","site_admin":false},"body":"Looked at existing methods in the class and they say\r\n\r\n```\r\n        :param project_id:  The project Entity id. If None, the current\r\n                            context's project will be used, or the \"site\"\r\n                            cache location will be returned if the current\r\n                            context does not have an associated project.\r\n```\r\n\r\nThis seems good to me - maybe all we need to do is to make sure the docstring better reflect \r\nthe actual logic in the case when a site context is being used?","created_at":"2016-07-18T11:15:16Z","updated_at":"2016-07-18T11:15:16Z","html_url":"https://github.com/shotgunsoftware/tk-framework-shotgunutils/pull/46#discussion_r71131214","pull_request_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/pulls/comments/71131214"},"html":{"href":"https://github.com/shotgunsoftware/tk-framework-shotgunutils/pull/46#discussion_r71131214"},"pull_request":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/pulls/46","id":77647250,"html_url":"https://github.com/shotgunsoftware/tk-framework-shotgunutils/pull/46","diff_url":"https://github.com/shotgunsoftware/tk-framework-shotgunutils/pull/46.diff","patch_url":"https://github.com/shotgunsoftware/tk-framework-shotgunutils/pull/46.patch","issue_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/issues/46","number":46,"state":"open","locked":false,"title":"#37467 Updates field editable/visible to use project id based schema caches","user":{"login":"josh-t","id":2604646,"avatar_url":"https://avatars.githubusercontent.com/u/2604646?v=3","gravatar_id":"","url":"https://api.github.com/users/josh-t","html_url":"https://github.com/josh-t","followers_url":"https://api.github.com/users/josh-t/followers","following_url":"https://api.github.com/users/josh-t/following{/other_user}","gists_url":"https://api.github.com/users/josh-t/gists{/gist_id}","starred_url":"https://api.github.com/users/josh-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh-t/subscriptions","organizations_url":"https://api.github.com/users/josh-t/orgs","repos_url":"https://api.github.com/users/josh-t/repos","events_url":"https://api.github.com/users/josh-t/events{/privacy}","received_events_url":"https://api.github.com/users/josh-t/received_events","type":"User","site_admin":false},"body":"This changes updates the `field_is_editable` and `field_is_visible` methods to use the new style schema caches which key off of the `project_id`. ","created_at":"2016-07-15T17:05:11Z","updated_at":"2016-07-18T11:15:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d3da2541f79bef9dd6316413e7e2267ea9d3b38","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/pulls/46/commits","review_comments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/pulls/46/comments","review_comment_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/issues/46/comments","statuses_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/statuses/621058cfaeecdc59e10c4d6f8f4c6c331d619501","head":{"label":"shotgunsoftware:37467_sg_utils_fix","ref":"37467_sg_utils_fix","sha":"621058cfaeecdc59e10c4d6f8f4c6c331d619501","user":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":14639855,"name":"tk-framework-shotgunutils","full_name":"shotgunsoftware/tk-framework-shotgunutils","owner":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shotgunsoftware/tk-framework-shotgunutils","description":"Shotgun Related Utilities","fork":false,"url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils","forks_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/forks","keys_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/teams","hooks_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/hooks","issue_events_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/issues/events{/number}","events_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/events","assignees_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/assignees{/user}","branches_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/branches{/branch}","tags_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/tags","blobs_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/git/refs{/sha}","trees_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/statuses/{sha}","languages_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/languages","stargazers_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/stargazers","contributors_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/contributors","subscribers_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/subscribers","subscription_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/subscription","commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/commits{/sha}","git_commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/git/commits{/sha}","comments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/comments{/number}","issue_comment_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/issues/comments{/number}","contents_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/contents/{+path}","compare_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/merges","archive_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/downloads","issues_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/issues{/number}","pulls_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/pulls{/number}","milestones_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/milestones{/number}","notifications_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/labels{/name}","releases_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/releases{/id}","deployments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/deployments","created_at":"2013-11-23T09:36:59Z","updated_at":"2016-01-15T13:45:19Z","pushed_at":"2016-07-17T08:21:22Z","git_url":"git://github.com/shotgunsoftware/tk-framework-shotgunutils.git","ssh_url":"git@github.com:shotgunsoftware/tk-framework-shotgunutils.git","clone_url":"https://github.com/shotgunsoftware/tk-framework-shotgunutils.git","svn_url":"https://github.com/shotgunsoftware/tk-framework-shotgunutils","homepage":"http://developer.shotgunsoftware.com/tk-framework-shotgunutils","size":11956,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":5,"forks":7,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"shotgunsoftware:master","ref":"master","sha":"cb61a6092f3d44aadf0e746c69e999055e0a54e8","user":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":14639855,"name":"tk-framework-shotgunutils","full_name":"shotgunsoftware/tk-framework-shotgunutils","owner":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shotgunsoftware/tk-framework-shotgunutils","description":"Shotgun Related Utilities","fork":false,"url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils","forks_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/forks","keys_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/teams","hooks_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/hooks","issue_events_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/issues/events{/number}","events_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/events","assignees_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/assignees{/user}","branches_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/branches{/branch}","tags_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/tags","blobs_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/git/refs{/sha}","trees_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/statuses/{sha}","languages_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/languages","stargazers_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/stargazers","contributors_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/contributors","subscribers_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/subscribers","subscription_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/subscription","commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/commits{/sha}","git_commits_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/git/commits{/sha}","comments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/comments{/number}","issue_comment_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/issues/comments{/number}","contents_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/contents/{+path}","compare_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/merges","archive_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/downloads","issues_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/issues{/number}","pulls_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/pulls{/number}","milestones_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/milestones{/number}","notifications_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/labels{/name}","releases_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/releases{/id}","deployments_url":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/deployments","created_at":"2013-11-23T09:36:59Z","updated_at":"2016-01-15T13:45:19Z","pushed_at":"2016-07-17T08:21:22Z","git_url":"git://github.com/shotgunsoftware/tk-framework-shotgunutils.git","ssh_url":"git@github.com:shotgunsoftware/tk-framework-shotgunutils.git","clone_url":"https://github.com/shotgunsoftware/tk-framework-shotgunutils.git","svn_url":"https://github.com/shotgunsoftware/tk-framework-shotgunutils","homepage":"http://developer.shotgunsoftware.com/tk-framework-shotgunutils","size":11956,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":5,"forks":7,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/pulls/46"},"html":{"href":"https://github.com/shotgunsoftware/tk-framework-shotgunutils/pull/46"},"issue":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/issues/46"},"comments":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/shotgunsoftware/tk-framework-shotgunutils/statuses/621058cfaeecdc59e10c4d6f8f4c6c331d619501"}}}}
{"actor":{"display_login":"manneohrstrom"}}