{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/68590944","id":68590944,"diff_hunk":"@@ -449,7 +452,7 @@ TEST(BitAllocator, test_bmap_alloc)\n   alloc->alloc_blocks(16, &start_block);\n   delete alloc;\n \n-  total_blocks = pow(BITMAP_SPAN_SIZE, 2) * 4;\n+  total_blocks = pow(zone_size, 2) * 4;\n   alloc_size = 16;\n   alloc = new BitAllocator(total_blocks, zone_size, CONCURRENT, false);\n   for (int64_t iter = 0; iter < 3; iter++) {","path":"src/test/objectstore/BitAllocator_test.cc","position":null,"original_position":30,"commit_id":"eee408b078cfbd09dc06be8e7cc57cebfc0ecd51","original_commit_id":"8539c0ad1378e44794db42696b17a70fa0be3233","user":{"login":"chhabaramesh","id":17556205,"avatar_url":"https://avatars.githubusercontent.com/u/17556205?v=3","gravatar_id":"","url":"https://api.github.com/users/chhabaramesh","html_url":"https://github.com/chhabaramesh","followers_url":"https://api.github.com/users/chhabaramesh/followers","following_url":"https://api.github.com/users/chhabaramesh/following{/other_user}","gists_url":"https://api.github.com/users/chhabaramesh/gists{/gist_id}","starred_url":"https://api.github.com/users/chhabaramesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chhabaramesh/subscriptions","organizations_url":"https://api.github.com/users/chhabaramesh/orgs","repos_url":"https://api.github.com/users/chhabaramesh/repos","events_url":"https://api.github.com/users/chhabaramesh/events{/privacy}","received_events_url":"https://api.github.com/users/chhabaramesh/received_events","type":"User","site_admin":false},"body":"@xiexingguo  is this change because you hit some issue while testing multiple zone size? Actually I wanted to keep span size and zone size independent as zone size controls maximum contiguous allocation that can be requested and span size controls height of the bitmap tree. Unless you see any logical reason both cannot coexist, I would request to keep them separate. ","created_at":"2016-06-27T14:55:18Z","updated_at":"2016-06-27T14:55:18Z","html_url":"https://github.com/ceph/ceph/pull/9935#discussion_r68590944","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/9935","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/68590944"},"html":{"href":"https://github.com/ceph/ceph/pull/9935#discussion_r68590944"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9935"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/9935","id":75220308,"html_url":"https://github.com/ceph/ceph/pull/9935","diff_url":"https://github.com/ceph/ceph/pull/9935.diff","patch_url":"https://github.com/ceph/ceph/pull/9935.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/9935","number":9935,"state":"open","locked":false,"title":"os/bluestore: make zone size of bit allocator configurable","user":{"login":"xiexingguo","id":14193361,"avatar_url":"https://avatars.githubusercontent.com/u/14193361?v=3","gravatar_id":"","url":"https://api.github.com/users/xiexingguo","html_url":"https://github.com/xiexingguo","followers_url":"https://api.github.com/users/xiexingguo/followers","following_url":"https://api.github.com/users/xiexingguo/following{/other_user}","gists_url":"https://api.github.com/users/xiexingguo/gists{/gist_id}","starred_url":"https://api.github.com/users/xiexingguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiexingguo/subscriptions","organizations_url":"https://api.github.com/users/xiexingguo/orgs","repos_url":"https://api.github.com/users/xiexingguo/repos","events_url":"https://api.github.com/users/xiexingguo/events{/privacy}","received_events_url":"https://api.github.com/users/xiexingguo/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-26T03:18:26Z","updated_at":"2016-06-27T14:55:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"520e3d9b2f50329160f76ae881a9b728e0aa6e07","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/9935/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/9935/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/9935/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/eee408b078cfbd09dc06be8e7cc57cebfc0ecd51","head":{"label":"xiexingguo:xxg-wip-make-zone-configurable","ref":"xxg-wip-make-zone-configurable","sha":"eee408b078cfbd09dc06be8e7cc57cebfc0ecd51","user":{"login":"xiexingguo","id":14193361,"avatar_url":"https://avatars.githubusercontent.com/u/14193361?v=3","gravatar_id":"","url":"https://api.github.com/users/xiexingguo","html_url":"https://github.com/xiexingguo","followers_url":"https://api.github.com/users/xiexingguo/followers","following_url":"https://api.github.com/users/xiexingguo/following{/other_user}","gists_url":"https://api.github.com/users/xiexingguo/gists{/gist_id}","starred_url":"https://api.github.com/users/xiexingguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiexingguo/subscriptions","organizations_url":"https://api.github.com/users/xiexingguo/orgs","repos_url":"https://api.github.com/users/xiexingguo/repos","events_url":"https://api.github.com/users/xiexingguo/events{/privacy}","received_events_url":"https://api.github.com/users/xiexingguo/received_events","type":"User","site_admin":false},"repo":{"id":45168396,"name":"ceph","full_name":"xiexingguo/ceph","owner":{"login":"xiexingguo","id":14193361,"avatar_url":"https://avatars.githubusercontent.com/u/14193361?v=3","gravatar_id":"","url":"https://api.github.com/users/xiexingguo","html_url":"https://github.com/xiexingguo","followers_url":"https://api.github.com/users/xiexingguo/followers","following_url":"https://api.github.com/users/xiexingguo/following{/other_user}","gists_url":"https://api.github.com/users/xiexingguo/gists{/gist_id}","starred_url":"https://api.github.com/users/xiexingguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiexingguo/subscriptions","organizations_url":"https://api.github.com/users/xiexingguo/orgs","repos_url":"https://api.github.com/users/xiexingguo/repos","events_url":"https://api.github.com/users/xiexingguo/events{/privacy}","received_events_url":"https://api.github.com/users/xiexingguo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xiexingguo/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/xiexingguo/ceph","forks_url":"https://api.github.com/repos/xiexingguo/ceph/forks","keys_url":"https://api.github.com/repos/xiexingguo/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiexingguo/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiexingguo/ceph/teams","hooks_url":"https://api.github.com/repos/xiexingguo/ceph/hooks","issue_events_url":"https://api.github.com/repos/xiexingguo/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/xiexingguo/ceph/events","assignees_url":"https://api.github.com/repos/xiexingguo/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/xiexingguo/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/xiexingguo/ceph/tags","blobs_url":"https://api.github.com/repos/xiexingguo/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiexingguo/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiexingguo/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiexingguo/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiexingguo/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/xiexingguo/ceph/languages","stargazers_url":"https://api.github.com/repos/xiexingguo/ceph/stargazers","contributors_url":"https://api.github.com/repos/xiexingguo/ceph/contributors","subscribers_url":"https://api.github.com/repos/xiexingguo/ceph/subscribers","subscription_url":"https://api.github.com/repos/xiexingguo/ceph/subscription","commits_url":"https://api.github.com/repos/xiexingguo/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiexingguo/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiexingguo/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiexingguo/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiexingguo/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/xiexingguo/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiexingguo/ceph/merges","archive_url":"https://api.github.com/repos/xiexingguo/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiexingguo/ceph/downloads","issues_url":"https://api.github.com/repos/xiexingguo/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/xiexingguo/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/xiexingguo/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/xiexingguo/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiexingguo/ceph/labels{/name}","releases_url":"https://api.github.com/repos/xiexingguo/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/xiexingguo/ceph/deployments","created_at":"2015-10-29T07:51:41Z","updated_at":"2016-01-11T08:49:47Z","pushed_at":"2016-06-27T14:40:05Z","git_url":"git://github.com/xiexingguo/ceph.git","ssh_url":"git@github.com:xiexingguo/ceph.git","clone_url":"https://github.com/xiexingguo/ceph.git","svn_url":"https://github.com/xiexingguo/ceph","homepage":"http://ceph.com","size":167256,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"63b82de32fa7e02ee519eede500268ee2d81ca3c","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-06-27T13:59:11Z","pushed_at":"2016-06-27T14:55:17Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":223244,"stargazers_count":2260,"watchers_count":2260,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1345,"mirror_url":null,"open_issues_count":427,"forks":1345,"open_issues":427,"watchers":2260,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9935"},"html":{"href":"https://github.com/ceph/ceph/pull/9935"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/9935"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/9935/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9935/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9935/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/eee408b078cfbd09dc06be8e7cc57cebfc0ecd51"}}}}
{"actor":{"display_login":"chhabaramesh"}}