{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang-nursery/fmt-rfcs/issues/1","repository_url":"https://api.github.com/repos/rust-lang-nursery/fmt-rfcs","labels_url":"https://api.github.com/repos/rust-lang-nursery/fmt-rfcs/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang-nursery/fmt-rfcs/issues/1/comments","events_url":"https://api.github.com/repos/rust-lang-nursery/fmt-rfcs/issues/1/events","html_url":"https://github.com/rust-lang-nursery/fmt-rfcs/issues/1","id":152897365,"number":1,"title":"Line and indent width","user":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":62,"created_at":"2016-05-03T23:28:27Z","updated_at":"2016-09-26T16:44:55Z","closed_at":null,"body":"Decide on the options and defaults for the maximum width of lines and indents.\r\n\r\nRustfmt currently has the following options:\r\n\r\n```\r\n    max_width: usize, 100, \"Maximum width of each line\";\r\n    ideal_width: usize, 80, \"Ideal width of each line\";\r\n    tab_spaces: usize, 4, \"Number of spaces per tab\";\r\n    hard_tabs: bool, false, \"Use tab characters for indentation, spaces for alignment\";\r\n```\r\n\r\nThe [style guide](https://github.com/rust-lang/rust/blob/master/src/doc/style/style/whitespace.md) specifies a maximum line width of 99 chars and 4 spaces (no tabs) for indentation. `make tidy` enforces 100 char width for the Rust repo.\r\n\r\nMostly these defaults seem reasonable. Points to discuss:\r\n\r\n* 99 or 100 char width,\r\n* 'ideal width' concept,\r\n* which options should remain,\r\n* names of options.\r\n\r\nNotes:\r\n\r\n* ideal width is not really used by rustfmt any more, in retrospect it was a bad idea. The only place it is used (I think) is for comments. I do think wrapping comments at 80 chars is nice, since reading prose is easier in narrower columns and the solid text of large comment blocks looks bad. It might be nice to keep the comment width at 80 and either remove the option to change it, or rename the option.\r\n* the 99 chars thing is to cope with diffs in 100 chars or newlines in terminals."},"comment":{"url":"https://api.github.com/repos/rust-lang-nursery/fmt-rfcs/issues/comments/249626355","html_url":"https://github.com/rust-lang-nursery/fmt-rfcs/issues/1#issuecomment-249626355","issue_url":"https://api.github.com/repos/rust-lang-nursery/fmt-rfcs/issues/1","id":249626355,"user":{"login":"aturon","id":709807,"avatar_url":"https://avatars.githubusercontent.com/u/709807?v=3","gravatar_id":"","url":"https://api.github.com/users/aturon","html_url":"https://github.com/aturon","followers_url":"https://api.github.com/users/aturon/followers","following_url":"https://api.github.com/users/aturon/following{/other_user}","gists_url":"https://api.github.com/users/aturon/gists{/gist_id}","starred_url":"https://api.github.com/users/aturon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aturon/subscriptions","organizations_url":"https://api.github.com/users/aturon/orgs","repos_url":"https://api.github.com/users/aturon/repos","events_url":"https://api.github.com/users/aturon/events{/privacy}","received_events_url":"https://api.github.com/users/aturon/received_events","type":"User","site_admin":false},"created_at":"2016-09-26T16:44:55Z","updated_at":"2016-09-26T16:44:55Z","body":"@joshtriplett \r\n\r\n> there's a much higher bar to switch from one alternative to the other than there would be to decide between two alternatives.\r\n\r\nI tend to agree, not least because we've long been plagued by out of date blog posts and StackOverflow answers, etc. While formatting changes aren't breaking changes per se, changing the indentation size does radically change the look and feel, which would create yet another old Rust/new Rust split, fueling the sense that Rust is still \"unstable\"."}}
{"actor":{"display_login":"aturon"}}