{"push_id":959525660,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"fce0109822823fcdb217feee9dc3318eb51d5582","before":"730de1b6e5e32499c19e4c8057fedd0c1d8c89be","commits":[{"sha":"fce0109822823fcdb217feee9dc3318eb51d5582","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"When dragging nodes, clone them\n\nSummary:\nRef T5240. Currently, when dragging nodes, we leave them where they are in the document and apply \"position: relative;\" so we can move them around on screen.\n\n  - Pros: All the CSS still works.\n  - Cons: Can't drag them outside the nearest containing element with \"overflow: hidden;\", many subtle positioning bugs with scrollable containers.\n\nInstead, this diff leaves the thing we're dragging exactly where it is, clones it, and drags the clone instead.\n\n  - Pros: You can drag it anywhere. Seems to fix all the scrolling container problems.\n  - Cons: CSS which depends on a container class no longer works.\n\nThe CSS thing is bad, but doesn't seem too unreasonable to fix. Basically, we just need to put some `phui-this-is-a-workboard-card` class on the cards, and use that to style them instead of `phui-workboard-view`, and then do something similar for draggable lists.\n\nAlthough we no longer need to drag cards to tabs with the current design, I think there's a reasonable chance we'll revisit that later. The current design also calls for scrollable columns, but there would be no way to drag cards outside of their current column with the current approach.\n\nNOTE: This does not attempt to fix the CSS, so dragging is pretty rough, since the \"clone\" loses a number of container classes and thus a number of rules. I'll clean up the CSS in the next change.\n\nTest Plan:\n  - Dragged stuff around on task lists, workboards, and sort lists (e.g., pinned applications) in Safari, Firefox and Chrome.\n  - Scrolled window and containers (workboards) during drag.\n  - Dragged stuff out of the workboard.\n  - Dragged stuff offscreen.\n  - CSS is funky, but I can no longer find any positioning or layout issues in any browser.\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T5240\n\nDifferential Revision: https://secure.phabricator.com/D15160","distinct":true,"url":"https://api.github.com/repos/phacility/phabricator/commits/fce0109822823fcdb217feee9dc3318eb51d5582"}]}