{"action":"created","comment":{"url":"https://api.github.com/repos/adRise/rule-parser/pulls/comments/55526253","id":55526253,"diff_hunk":"@@ -40,6 +40,7 @@\n [0-9]+(\".\"[0-9]+)?\\b  return 'NUMBER'\n \\\"[^\\\"]*\\\"            return 'STRING'\n [a-z]+                return 'VARIABLE'\n+\\[.*?\\]               return 'ARRAY'","path":"rule.jison","position":4,"original_position":4,"commit_id":"73643162ec83117b4c44097d9c843f6b13c4093c","original_commit_id":"73643162ec83117b4c44097d9c843f6b13c4093c","user":{"login":"tyrchen","id":473888,"avatar_url":"https://avatars.githubusercontent.com/u/473888?v=3","gravatar_id":"","url":"https://api.github.com/users/tyrchen","html_url":"https://github.com/tyrchen","followers_url":"https://api.github.com/users/tyrchen/followers","following_url":"https://api.github.com/users/tyrchen/following{/other_user}","gists_url":"https://api.github.com/users/tyrchen/gists{/gist_id}","starred_url":"https://api.github.com/users/tyrchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyrchen/subscriptions","organizations_url":"https://api.github.com/users/tyrchen/orgs","repos_url":"https://api.github.com/users/tyrchen/repos","events_url":"https://api.github.com/users/tyrchen/events{/privacy}","received_events_url":"https://api.github.com/users/tyrchen/received_events","type":"User","site_admin":false},"body":"It might not be a good idea to tokenize array like this. It shall be parsed by grammar to take care of a lot of cases. What if someone write an array like this: operators in [ \"(\", \")\", \"[\", \"]\", \"+\" ]?","created_at":"2016-03-09T14:36:05Z","updated_at":"2016-03-09T14:36:05Z","html_url":"https://github.com/adRise/rule-parser/pull/2#discussion_r55526253","pull_request_url":"https://api.github.com/repos/adRise/rule-parser/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/adRise/rule-parser/pulls/comments/55526253"},"html":{"href":"https://github.com/adRise/rule-parser/pull/2#discussion_r55526253"},"pull_request":{"href":"https://api.github.com/repos/adRise/rule-parser/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/adRise/rule-parser/pulls/2","id":62187095,"html_url":"https://github.com/adRise/rule-parser/pull/2","diff_url":"https://github.com/adRise/rule-parser/pull/2.diff","patch_url":"https://github.com/adRise/rule-parser/pull/2.patch","issue_url":"https://api.github.com/repos/adRise/rule-parser/issues/2","number":2,"state":"open","locked":false,"title":"Feature/validator","user":{"login":"wanghaofei90","id":8593195,"avatar_url":"https://avatars.githubusercontent.com/u/8593195?v=3","gravatar_id":"","url":"https://api.github.com/users/wanghaofei90","html_url":"https://github.com/wanghaofei90","followers_url":"https://api.github.com/users/wanghaofei90/followers","following_url":"https://api.github.com/users/wanghaofei90/following{/other_user}","gists_url":"https://api.github.com/users/wanghaofei90/gists{/gist_id}","starred_url":"https://api.github.com/users/wanghaofei90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wanghaofei90/subscriptions","organizations_url":"https://api.github.com/users/wanghaofei90/orgs","repos_url":"https://api.github.com/users/wanghaofei90/repos","events_url":"https://api.github.com/users/wanghaofei90/events{/privacy}","received_events_url":"https://api.github.com/users/wanghaofei90/received_events","type":"User","site_admin":false},"body":"- Add validator as 3rd parameter of parser\r\n- Add Array type\r\n- Test cases for validator\r\n\r\nPlease CR @tyrchen ","created_at":"2016-03-09T06:54:00Z","updated_at":"2016-03-09T14:36:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db1235ced4668dd4e2c8624e7718d387181cf299","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/adRise/rule-parser/pulls/2/commits","review_comments_url":"https://api.github.com/repos/adRise/rule-parser/pulls/2/comments","review_comment_url":"https://api.github.com/repos/adRise/rule-parser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adRise/rule-parser/issues/2/comments","statuses_url":"https://api.github.com/repos/adRise/rule-parser/statuses/73643162ec83117b4c44097d9c843f6b13c4093c","head":{"label":"adRise:feature/validator","ref":"feature/validator","sha":"73643162ec83117b4c44097d9c843f6b13c4093c","user":{"login":"adRise","id":1291806,"avatar_url":"https://avatars.githubusercontent.com/u/1291806?v=3","gravatar_id":"","url":"https://api.github.com/users/adRise","html_url":"https://github.com/adRise","followers_url":"https://api.github.com/users/adRise/followers","following_url":"https://api.github.com/users/adRise/following{/other_user}","gists_url":"https://api.github.com/users/adRise/gists{/gist_id}","starred_url":"https://api.github.com/users/adRise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adRise/subscriptions","organizations_url":"https://api.github.com/users/adRise/orgs","repos_url":"https://api.github.com/users/adRise/repos","events_url":"https://api.github.com/users/adRise/events{/privacy}","received_events_url":"https://api.github.com/users/adRise/received_events","type":"Organization","site_admin":false},"repo":{"id":53234461,"name":"rule-parser","full_name":"adRise/rule-parser","owner":{"login":"adRise","id":1291806,"avatar_url":"https://avatars.githubusercontent.com/u/1291806?v=3","gravatar_id":"","url":"https://api.github.com/users/adRise","html_url":"https://github.com/adRise","followers_url":"https://api.github.com/users/adRise/followers","following_url":"https://api.github.com/users/adRise/following{/other_user}","gists_url":"https://api.github.com/users/adRise/gists{/gist_id}","starred_url":"https://api.github.com/users/adRise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adRise/subscriptions","organizations_url":"https://api.github.com/users/adRise/orgs","repos_url":"https://api.github.com/users/adRise/repos","events_url":"https://api.github.com/users/adRise/events{/privacy}","received_events_url":"https://api.github.com/users/adRise/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adRise/rule-parser","description":"a tiny parser to parse expressions","fork":false,"url":"https://api.github.com/repos/adRise/rule-parser","forks_url":"https://api.github.com/repos/adRise/rule-parser/forks","keys_url":"https://api.github.com/repos/adRise/rule-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adRise/rule-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adRise/rule-parser/teams","hooks_url":"https://api.github.com/repos/adRise/rule-parser/hooks","issue_events_url":"https://api.github.com/repos/adRise/rule-parser/issues/events{/number}","events_url":"https://api.github.com/repos/adRise/rule-parser/events","assignees_url":"https://api.github.com/repos/adRise/rule-parser/assignees{/user}","branches_url":"https://api.github.com/repos/adRise/rule-parser/branches{/branch}","tags_url":"https://api.github.com/repos/adRise/rule-parser/tags","blobs_url":"https://api.github.com/repos/adRise/rule-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adRise/rule-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adRise/rule-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/adRise/rule-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adRise/rule-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/adRise/rule-parser/languages","stargazers_url":"https://api.github.com/repos/adRise/rule-parser/stargazers","contributors_url":"https://api.github.com/repos/adRise/rule-parser/contributors","subscribers_url":"https://api.github.com/repos/adRise/rule-parser/subscribers","subscription_url":"https://api.github.com/repos/adRise/rule-parser/subscription","commits_url":"https://api.github.com/repos/adRise/rule-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/adRise/rule-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/adRise/rule-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/adRise/rule-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/adRise/rule-parser/contents/{+path}","compare_url":"https://api.github.com/repos/adRise/rule-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adRise/rule-parser/merges","archive_url":"https://api.github.com/repos/adRise/rule-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adRise/rule-parser/downloads","issues_url":"https://api.github.com/repos/adRise/rule-parser/issues{/number}","pulls_url":"https://api.github.com/repos/adRise/rule-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/adRise/rule-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/adRise/rule-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adRise/rule-parser/labels{/name}","releases_url":"https://api.github.com/repos/adRise/rule-parser/releases{/id}","deployments_url":"https://api.github.com/repos/adRise/rule-parser/deployments","created_at":"2016-03-06T02:51:43Z","updated_at":"2016-03-06T03:07:59Z","pushed_at":"2016-03-09T06:54:03Z","git_url":"git://github.com/adRise/rule-parser.git","ssh_url":"git@github.com:adRise/rule-parser.git","clone_url":"https://github.com/adRise/rule-parser.git","svn_url":"https://github.com/adRise/rule-parser","homepage":null,"size":14,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"adRise:master","ref":"master","sha":"f1cd7c3dddd7f8d8af0aa098ad3b2cfab9d71a70","user":{"login":"adRise","id":1291806,"avatar_url":"https://avatars.githubusercontent.com/u/1291806?v=3","gravatar_id":"","url":"https://api.github.com/users/adRise","html_url":"https://github.com/adRise","followers_url":"https://api.github.com/users/adRise/followers","following_url":"https://api.github.com/users/adRise/following{/other_user}","gists_url":"https://api.github.com/users/adRise/gists{/gist_id}","starred_url":"https://api.github.com/users/adRise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adRise/subscriptions","organizations_url":"https://api.github.com/users/adRise/orgs","repos_url":"https://api.github.com/users/adRise/repos","events_url":"https://api.github.com/users/adRise/events{/privacy}","received_events_url":"https://api.github.com/users/adRise/received_events","type":"Organization","site_admin":false},"repo":{"id":53234461,"name":"rule-parser","full_name":"adRise/rule-parser","owner":{"login":"adRise","id":1291806,"avatar_url":"https://avatars.githubusercontent.com/u/1291806?v=3","gravatar_id":"","url":"https://api.github.com/users/adRise","html_url":"https://github.com/adRise","followers_url":"https://api.github.com/users/adRise/followers","following_url":"https://api.github.com/users/adRise/following{/other_user}","gists_url":"https://api.github.com/users/adRise/gists{/gist_id}","starred_url":"https://api.github.com/users/adRise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adRise/subscriptions","organizations_url":"https://api.github.com/users/adRise/orgs","repos_url":"https://api.github.com/users/adRise/repos","events_url":"https://api.github.com/users/adRise/events{/privacy}","received_events_url":"https://api.github.com/users/adRise/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adRise/rule-parser","description":"a tiny parser to parse expressions","fork":false,"url":"https://api.github.com/repos/adRise/rule-parser","forks_url":"https://api.github.com/repos/adRise/rule-parser/forks","keys_url":"https://api.github.com/repos/adRise/rule-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adRise/rule-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adRise/rule-parser/teams","hooks_url":"https://api.github.com/repos/adRise/rule-parser/hooks","issue_events_url":"https://api.github.com/repos/adRise/rule-parser/issues/events{/number}","events_url":"https://api.github.com/repos/adRise/rule-parser/events","assignees_url":"https://api.github.com/repos/adRise/rule-parser/assignees{/user}","branches_url":"https://api.github.com/repos/adRise/rule-parser/branches{/branch}","tags_url":"https://api.github.com/repos/adRise/rule-parser/tags","blobs_url":"https://api.github.com/repos/adRise/rule-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adRise/rule-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adRise/rule-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/adRise/rule-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adRise/rule-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/adRise/rule-parser/languages","stargazers_url":"https://api.github.com/repos/adRise/rule-parser/stargazers","contributors_url":"https://api.github.com/repos/adRise/rule-parser/contributors","subscribers_url":"https://api.github.com/repos/adRise/rule-parser/subscribers","subscription_url":"https://api.github.com/repos/adRise/rule-parser/subscription","commits_url":"https://api.github.com/repos/adRise/rule-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/adRise/rule-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/adRise/rule-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/adRise/rule-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/adRise/rule-parser/contents/{+path}","compare_url":"https://api.github.com/repos/adRise/rule-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adRise/rule-parser/merges","archive_url":"https://api.github.com/repos/adRise/rule-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adRise/rule-parser/downloads","issues_url":"https://api.github.com/repos/adRise/rule-parser/issues{/number}","pulls_url":"https://api.github.com/repos/adRise/rule-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/adRise/rule-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/adRise/rule-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adRise/rule-parser/labels{/name}","releases_url":"https://api.github.com/repos/adRise/rule-parser/releases{/id}","deployments_url":"https://api.github.com/repos/adRise/rule-parser/deployments","created_at":"2016-03-06T02:51:43Z","updated_at":"2016-03-06T03:07:59Z","pushed_at":"2016-03-09T06:54:03Z","git_url":"git://github.com/adRise/rule-parser.git","ssh_url":"git@github.com:adRise/rule-parser.git","clone_url":"https://github.com/adRise/rule-parser.git","svn_url":"https://github.com/adRise/rule-parser","homepage":null,"size":14,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adRise/rule-parser/pulls/2"},"html":{"href":"https://github.com/adRise/rule-parser/pull/2"},"issue":{"href":"https://api.github.com/repos/adRise/rule-parser/issues/2"},"comments":{"href":"https://api.github.com/repos/adRise/rule-parser/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/adRise/rule-parser/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/adRise/rule-parser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adRise/rule-parser/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/adRise/rule-parser/statuses/73643162ec83117b4c44097d9c843f6b13c4093c"}}}}