{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/alertmanager/pulls/comments/79501775","id":79501775,"diff_hunk":"@@ -106,6 +108,50 @@ type Silences struct {\n \tst  gossipData\n }\n \n+type metrics struct {\n+\tgcDuration       prometheus.Summary\n+\tsnapshotDuration prometheus.Summary\n+\tqueriesTotal     prometheus.Counter\n+\tqueryErrorsTotal prometheus.Counter\n+\tqueryDuration    prometheus.Histogram\n+}\n+\n+func newMetrics(r prometheus.Registerer) *metrics {\n+\tm := &metrics{}\n+\n+\tm.gcDuration = prometheus.NewSummary(prometheus.SummaryOpts{\n+\t\tName: \"alertmanager_silences_gc_duration_seconds\",\n+\t\tHelp: \"Duration of the last garbage collection cycle.\",","path":"silence/silence.go","position":33,"original_position":33,"commit_id":"988ea232fd5239c1201403039d2fe96b91899bee","original_commit_id":"988ea232fd5239c1201403039d2fe96b91899bee","user":{"login":"juliusv","id":538008,"avatar_url":"https://avatars.githubusercontent.com/u/538008?v=3","gravatar_id":"","url":"https://api.github.com/users/juliusv","html_url":"https://github.com/juliusv","followers_url":"https://api.github.com/users/juliusv/followers","following_url":"https://api.github.com/users/juliusv/following{/other_user}","gists_url":"https://api.github.com/users/juliusv/gists{/gist_id}","starred_url":"https://api.github.com/users/juliusv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliusv/subscriptions","organizations_url":"https://api.github.com/users/juliusv/orgs","repos_url":"https://api.github.com/users/juliusv/repos","events_url":"https://api.github.com/users/juliusv/events{/privacy}","received_events_url":"https://api.github.com/users/juliusv/received_events","type":"User","site_admin":false},"body":"\"last silence garbage collection cycle\" for people to not confuse the HELP string with general Go garbage collection?","created_at":"2016-09-19T22:17:44Z","updated_at":"2016-09-19T22:17:44Z","html_url":"https://github.com/prometheus/alertmanager/pull/509#discussion_r79501775","pull_request_url":"https://api.github.com/repos/prometheus/alertmanager/pulls/509","_links":{"self":{"href":"https://api.github.com/repos/prometheus/alertmanager/pulls/comments/79501775"},"html":{"href":"https://github.com/prometheus/alertmanager/pull/509#discussion_r79501775"},"pull_request":{"href":"https://api.github.com/repos/prometheus/alertmanager/pulls/509"}}},"pull_request":{"url":"https://api.github.com/repos/prometheus/alertmanager/pulls/509","id":85858633,"html_url":"https://github.com/prometheus/alertmanager/pull/509","diff_url":"https://github.com/prometheus/alertmanager/pull/509.diff","patch_url":"https://github.com/prometheus/alertmanager/pull/509.patch","issue_url":"https://api.github.com/repos/prometheus/alertmanager/issues/509","number":509,"state":"open","locked":false,"title":"silence: add metrics","user":{"login":"fabxc","id":4948210,"avatar_url":"https://avatars.githubusercontent.com/u/4948210?v=3","gravatar_id":"","url":"https://api.github.com/users/fabxc","html_url":"https://github.com/fabxc","followers_url":"https://api.github.com/users/fabxc/followers","following_url":"https://api.github.com/users/fabxc/following{/other_user}","gists_url":"https://api.github.com/users/fabxc/gists{/gist_id}","starred_url":"https://api.github.com/users/fabxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabxc/subscriptions","organizations_url":"https://api.github.com/users/fabxc/orgs","repos_url":"https://api.github.com/users/fabxc/repos","events_url":"https://api.github.com/users/fabxc/events{/privacy}","received_events_url":"https://api.github.com/users/fabxc/received_events","type":"User","site_admin":false},"body":"This adds metrics for querying as it is done internally and critical. The create/modification actions are basically covered by the API handler instrumentation and would just bloat here.\r\n\r\n@discordianfish ","created_at":"2016-09-19T19:58:18Z","updated_at":"2016-09-19T22:17:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efd80dc3c0cf08bbdb588d0eb7292d47347af746","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/alertmanager/pulls/509/commits","review_comments_url":"https://api.github.com/repos/prometheus/alertmanager/pulls/509/comments","review_comment_url":"https://api.github.com/repos/prometheus/alertmanager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/alertmanager/issues/509/comments","statuses_url":"https://api.github.com/repos/prometheus/alertmanager/statuses/988ea232fd5239c1201403039d2fe96b91899bee","head":{"label":"prometheus:sil-metrics","ref":"sil-metrics","sha":"988ea232fd5239c1201403039d2fe96b91899bee","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":11452538,"name":"alertmanager","full_name":"prometheus/alertmanager","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/alertmanager","description":"Prometheus Alertmanager","fork":false,"url":"https://api.github.com/repos/prometheus/alertmanager","forks_url":"https://api.github.com/repos/prometheus/alertmanager/forks","keys_url":"https://api.github.com/repos/prometheus/alertmanager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/alertmanager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/alertmanager/teams","hooks_url":"https://api.github.com/repos/prometheus/alertmanager/hooks","issue_events_url":"https://api.github.com/repos/prometheus/alertmanager/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/alertmanager/events","assignees_url":"https://api.github.com/repos/prometheus/alertmanager/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/alertmanager/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/alertmanager/tags","blobs_url":"https://api.github.com/repos/prometheus/alertmanager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/alertmanager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/alertmanager/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/alertmanager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/alertmanager/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/alertmanager/languages","stargazers_url":"https://api.github.com/repos/prometheus/alertmanager/stargazers","contributors_url":"https://api.github.com/repos/prometheus/alertmanager/contributors","subscribers_url":"https://api.github.com/repos/prometheus/alertmanager/subscribers","subscription_url":"https://api.github.com/repos/prometheus/alertmanager/subscription","commits_url":"https://api.github.com/repos/prometheus/alertmanager/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/alertmanager/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/alertmanager/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/alertmanager/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/alertmanager/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/alertmanager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/alertmanager/merges","archive_url":"https://api.github.com/repos/prometheus/alertmanager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/alertmanager/downloads","issues_url":"https://api.github.com/repos/prometheus/alertmanager/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/alertmanager/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/alertmanager/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/alertmanager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/alertmanager/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/alertmanager/releases{/id}","deployments_url":"https://api.github.com/repos/prometheus/alertmanager/deployments","created_at":"2013-07-16T15:06:31Z","updated_at":"2016-09-17T15:56:30Z","pushed_at":"2016-09-19T20:28:32Z","git_url":"git://github.com/prometheus/alertmanager.git","ssh_url":"git@github.com:prometheus/alertmanager.git","clone_url":"https://github.com/prometheus/alertmanager.git","svn_url":"https://github.com/prometheus/alertmanager","homepage":"","size":8806,"stargazers_count":238,"watchers_count":238,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":61,"forks":145,"open_issues":61,"watchers":238,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"9396976771acc7a72d8b4022d395fd08175113eb","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":11452538,"name":"alertmanager","full_name":"prometheus/alertmanager","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/alertmanager","description":"Prometheus Alertmanager","fork":false,"url":"https://api.github.com/repos/prometheus/alertmanager","forks_url":"https://api.github.com/repos/prometheus/alertmanager/forks","keys_url":"https://api.github.com/repos/prometheus/alertmanager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/alertmanager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/alertmanager/teams","hooks_url":"https://api.github.com/repos/prometheus/alertmanager/hooks","issue_events_url":"https://api.github.com/repos/prometheus/alertmanager/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/alertmanager/events","assignees_url":"https://api.github.com/repos/prometheus/alertmanager/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/alertmanager/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/alertmanager/tags","blobs_url":"https://api.github.com/repos/prometheus/alertmanager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/alertmanager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/alertmanager/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/alertmanager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/alertmanager/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/alertmanager/languages","stargazers_url":"https://api.github.com/repos/prometheus/alertmanager/stargazers","contributors_url":"https://api.github.com/repos/prometheus/alertmanager/contributors","subscribers_url":"https://api.github.com/repos/prometheus/alertmanager/subscribers","subscription_url":"https://api.github.com/repos/prometheus/alertmanager/subscription","commits_url":"https://api.github.com/repos/prometheus/alertmanager/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/alertmanager/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/alertmanager/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/alertmanager/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/alertmanager/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/alertmanager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/alertmanager/merges","archive_url":"https://api.github.com/repos/prometheus/alertmanager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/alertmanager/downloads","issues_url":"https://api.github.com/repos/prometheus/alertmanager/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/alertmanager/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/alertmanager/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/alertmanager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/alertmanager/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/alertmanager/releases{/id}","deployments_url":"https://api.github.com/repos/prometheus/alertmanager/deployments","created_at":"2013-07-16T15:06:31Z","updated_at":"2016-09-17T15:56:30Z","pushed_at":"2016-09-19T20:28:32Z","git_url":"git://github.com/prometheus/alertmanager.git","ssh_url":"git@github.com:prometheus/alertmanager.git","clone_url":"https://github.com/prometheus/alertmanager.git","svn_url":"https://github.com/prometheus/alertmanager","homepage":"","size":8806,"stargazers_count":238,"watchers_count":238,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":61,"forks":145,"open_issues":61,"watchers":238,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/alertmanager/pulls/509"},"html":{"href":"https://github.com/prometheus/alertmanager/pull/509"},"issue":{"href":"https://api.github.com/repos/prometheus/alertmanager/issues/509"},"comments":{"href":"https://api.github.com/repos/prometheus/alertmanager/issues/509/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/alertmanager/pulls/509/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/alertmanager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/alertmanager/pulls/509/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/alertmanager/statuses/988ea232fd5239c1201403039d2fe96b91899bee"}}}}
{"actor":{"display_login":"juliusv"}}