{"action":"created","issue":{"url":"https://api.github.com/repos/jbosstm/narayana/issues/1076","repository_url":"https://api.github.com/repos/jbosstm/narayana","labels_url":"https://api.github.com/repos/jbosstm/narayana/issues/1076/labels{/name}","comments_url":"https://api.github.com/repos/jbosstm/narayana/issues/1076/comments","events_url":"https://api.github.com/repos/jbosstm/narayana/issues/1076/events","html_url":"https://github.com/jbosstm/narayana/pull/1076","id":180668969,"number":1076,"title":"[JBTM-2334] Narayana Tomcat module","user":{"login":"gytis","id":196395,"avatar_url":"https://avatars.githubusercontent.com/u/196395?v=3","gravatar_id":"","url":"https://api.github.com/users/gytis","html_url":"https://github.com/gytis","followers_url":"https://api.github.com/users/gytis/followers","following_url":"https://api.github.com/users/gytis/following{/other_user}","gists_url":"https://api.github.com/users/gytis/gists{/gist_id}","starred_url":"https://api.github.com/users/gytis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gytis/subscriptions","organizations_url":"https://api.github.com/users/gytis/orgs","repos_url":"https://api.github.com/users/gytis/repos","events_url":"https://api.github.com/users/gytis/events{/privacy}","received_events_url":"https://api.github.com/users/gytis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jbosstm/narayana/labels/Ready%20For%20Review","name":"Ready For Review","color":"006b75"}],"state":"open","locked":false,"assignee":{"login":"tomjenkinson","id":317340,"avatar_url":"https://avatars.githubusercontent.com/u/317340?v=3","gravatar_id":"","url":"https://api.github.com/users/tomjenkinson","html_url":"https://github.com/tomjenkinson","followers_url":"https://api.github.com/users/tomjenkinson/followers","following_url":"https://api.github.com/users/tomjenkinson/following{/other_user}","gists_url":"https://api.github.com/users/tomjenkinson/gists{/gist_id}","starred_url":"https://api.github.com/users/tomjenkinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomjenkinson/subscriptions","organizations_url":"https://api.github.com/users/tomjenkinson/orgs","repos_url":"https://api.github.com/users/tomjenkinson/repos","events_url":"https://api.github.com/users/tomjenkinson/events{/privacy}","received_events_url":"https://api.github.com/users/tomjenkinson/received_events","type":"User","site_admin":false},"assignees":[{"login":"tomjenkinson","id":317340,"avatar_url":"https://avatars.githubusercontent.com/u/317340?v=3","gravatar_id":"","url":"https://api.github.com/users/tomjenkinson","html_url":"https://github.com/tomjenkinson","followers_url":"https://api.github.com/users/tomjenkinson/followers","following_url":"https://api.github.com/users/tomjenkinson/following{/other_user}","gists_url":"https://api.github.com/users/tomjenkinson/gists{/gist_id}","starred_url":"https://api.github.com/users/tomjenkinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomjenkinson/subscriptions","organizations_url":"https://api.github.com/users/tomjenkinson/orgs","repos_url":"https://api.github.com/users/tomjenkinson/repos","events_url":"https://api.github.com/users/tomjenkinson/events{/privacy}","received_events_url":"https://api.github.com/users/tomjenkinson/received_events","type":"User","site_admin":false}],"milestone":null,"comments":32,"created_at":"2016-10-03T15:22:53Z","updated_at":"2016-10-05T14:34:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jbosstm/narayana/pulls/1076","html_url":"https://github.com/jbosstm/narayana/pull/1076","diff_url":"https://github.com/jbosstm/narayana/pull/1076.diff","patch_url":"https://github.com/jbosstm/narayana/pull/1076.patch"},"body":"https://issues.jboss.org/browse/JBTM-2334\r\n\r\n!XTS !BLACKTIE !PERF !QA_JTA !QA_JTS_JDKORB"},"comment":{"url":"https://api.github.com/repos/jbosstm/narayana/issues/comments/251692748","html_url":"https://github.com/jbosstm/narayana/pull/1076#issuecomment-251692748","issue_url":"https://api.github.com/repos/jbosstm/narayana/issues/1076","id":251692748,"user":{"login":"gytis","id":196395,"avatar_url":"https://avatars.githubusercontent.com/u/196395?v=3","gravatar_id":"","url":"https://api.github.com/users/gytis","html_url":"https://github.com/gytis","followers_url":"https://api.github.com/users/gytis/followers","following_url":"https://api.github.com/users/gytis/following{/other_user}","gists_url":"https://api.github.com/users/gytis/gists{/gist_id}","starred_url":"https://api.github.com/users/gytis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gytis/subscriptions","organizations_url":"https://api.github.com/users/gytis/orgs","repos_url":"https://api.github.com/users/gytis/repos","events_url":"https://api.github.com/users/gytis/events{/privacy}","received_events_url":"https://api.github.com/users/gytis/received_events","type":"User","site_admin":false},"created_at":"2016-10-05T14:34:16Z","updated_at":"2016-10-05T14:34:16Z","body":"Tomcat is a bit different from WildFly in that sense, and config should go in the application for this. So we would need to provide a custom configuration file for that.\r\n\r\nHow about we shade all bits for jta and jts (basically copy narayana-jts-idlj) but don't add properties file into the fat jar.  Then if user doesn't provide his jbossts-properites.xml we configure default options (jta) programatically.\r\nAlso, user can provide any options he wants with his own jbossts-properites.xml which will be taken instead of defaults.\r\nAnd in addition, we add a new config field for the user to enable jts via jbossts-properites.xml."}}
{"actor":{"display_login":"gytis"}}