{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/81928444","pull_request_review_id":2871158,"id":81928444,"diff_hunk":"@@ -92,6 +92,17 @@ def _prepare_gain(forward, info, noise_cov, pca, depth, loose, weights,\n         raise ValueError('Depth parameter must be positive (got %s).'\n                          % depth)\n \n+    if len(forward['src']) == 1:","path":"mne/inverse_sparse/mxne_inverse.py","position":22,"original_position":22,"commit_id":"057ccbba103bfd5b4baf709097e50639996fd70d","original_commit_id":"057ccbba103bfd5b4baf709097e50639996fd70d","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"body":"You can't go by the length, you need to look at the type. Discrete source spaces can be constructed with legitimate normals, for example.","created_at":"2016-10-05T08:59:02Z","updated_at":"2016-10-05T08:59:02Z","html_url":"https://github.com/mne-tools/mne-python/pull/3641#discussion_r81928444","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3641","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/81928444"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3641#discussion_r81928444"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3641"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3641","id":88038487,"html_url":"https://github.com/mne-tools/mne-python/pull/3641","diff_url":"https://github.com/mne-tools/mne-python/pull/3641.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/3641.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3641","number":3641,"state":"open","locked":false,"title":"WIP: Volume source estimates with sparse inverse methods","user":{"login":"joewalter","id":1483010,"avatar_url":"https://avatars.githubusercontent.com/u/1483010?v=3","gravatar_id":"","url":"https://api.github.com/users/joewalter","html_url":"https://github.com/joewalter","followers_url":"https://api.github.com/users/joewalter/followers","following_url":"https://api.github.com/users/joewalter/following{/other_user}","gists_url":"https://api.github.com/users/joewalter/gists{/gist_id}","starred_url":"https://api.github.com/users/joewalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joewalter/subscriptions","organizations_url":"https://api.github.com/users/joewalter/orgs","repos_url":"https://api.github.com/users/joewalter/repos","events_url":"https://api.github.com/users/joewalter/events{/privacy}","received_events_url":"https://api.github.com/users/joewalter/received_events","type":"User","site_admin":false},"body":"Open issues:\r\n- Visualization could be improved\r\n- Unify representation of dipolar sources (dipole fitting and sparse inverse methods)\r\n- Improve depth weighting","created_at":"2016-10-05T08:54:19Z","updated_at":"2016-10-05T09:00:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7ac9d56279d907af3c3b1ba3a8cb7e18ed82260","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3641/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3641/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3641/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/057ccbba103bfd5b4baf709097e50639996fd70d","head":{"label":"joewalter:vol_mxne","ref":"vol_mxne","sha":"057ccbba103bfd5b4baf709097e50639996fd70d","user":{"login":"joewalter","id":1483010,"avatar_url":"https://avatars.githubusercontent.com/u/1483010?v=3","gravatar_id":"","url":"https://api.github.com/users/joewalter","html_url":"https://github.com/joewalter","followers_url":"https://api.github.com/users/joewalter/followers","following_url":"https://api.github.com/users/joewalter/following{/other_user}","gists_url":"https://api.github.com/users/joewalter/gists{/gist_id}","starred_url":"https://api.github.com/users/joewalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joewalter/subscriptions","organizations_url":"https://api.github.com/users/joewalter/orgs","repos_url":"https://api.github.com/users/joewalter/repos","events_url":"https://api.github.com/users/joewalter/events{/privacy}","received_events_url":"https://api.github.com/users/joewalter/received_events","type":"User","site_admin":false},"repo":{"id":7405227,"name":"mne-python","full_name":"joewalter/mne-python","owner":{"login":"joewalter","id":1483010,"avatar_url":"https://avatars.githubusercontent.com/u/1483010?v=3","gravatar_id":"","url":"https://api.github.com/users/joewalter","html_url":"https://github.com/joewalter","followers_url":"https://api.github.com/users/joewalter/followers","following_url":"https://api.github.com/users/joewalter/following{/other_user}","gists_url":"https://api.github.com/users/joewalter/gists{/gist_id}","starred_url":"https://api.github.com/users/joewalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joewalter/subscriptions","organizations_url":"https://api.github.com/users/joewalter/orgs","repos_url":"https://api.github.com/users/joewalter/repos","events_url":"https://api.github.com/users/joewalter/events{/privacy}","received_events_url":"https://api.github.com/users/joewalter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joewalter/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":true,"url":"https://api.github.com/repos/joewalter/mne-python","forks_url":"https://api.github.com/repos/joewalter/mne-python/forks","keys_url":"https://api.github.com/repos/joewalter/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joewalter/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joewalter/mne-python/teams","hooks_url":"https://api.github.com/repos/joewalter/mne-python/hooks","issue_events_url":"https://api.github.com/repos/joewalter/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/joewalter/mne-python/events","assignees_url":"https://api.github.com/repos/joewalter/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/joewalter/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/joewalter/mne-python/tags","blobs_url":"https://api.github.com/repos/joewalter/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joewalter/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joewalter/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/joewalter/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joewalter/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/joewalter/mne-python/languages","stargazers_url":"https://api.github.com/repos/joewalter/mne-python/stargazers","contributors_url":"https://api.github.com/repos/joewalter/mne-python/contributors","subscribers_url":"https://api.github.com/repos/joewalter/mne-python/subscribers","subscription_url":"https://api.github.com/repos/joewalter/mne-python/subscription","commits_url":"https://api.github.com/repos/joewalter/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/joewalter/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/joewalter/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/joewalter/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/joewalter/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/joewalter/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joewalter/mne-python/merges","archive_url":"https://api.github.com/repos/joewalter/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joewalter/mne-python/downloads","issues_url":"https://api.github.com/repos/joewalter/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/joewalter/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/joewalter/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/joewalter/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joewalter/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/joewalter/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/joewalter/mne-python/deployments","created_at":"2013-01-02T10:36:08Z","updated_at":"2016-10-05T08:49:35Z","pushed_at":"2016-10-05T08:51:29Z","git_url":"git://github.com/joewalter/mne-python.git","ssh_url":"git@github.com:joewalter/mne-python.git","clone_url":"https://github.com/joewalter/mne-python.git","svn_url":"https://github.com/joewalter/mne-python","homepage":"http://martinos.org/mne/","size":76018,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"a9723e8215cdbf2721497516173c82f2ed64cf42","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/mne-tools/mne-python/deployments","created_at":"2011-01-28T03:31:13Z","updated_at":"2016-10-04T12:07:01Z","pushed_at":"2016-10-05T08:54:19Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":181822,"stargazers_count":233,"watchers_count":233,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":219,"mirror_url":null,"open_issues_count":200,"forks":219,"open_issues":200,"watchers":233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3641"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3641"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3641"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3641/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3641/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3641/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/057ccbba103bfd5b4baf709097e50639996fd70d"}}}}
{"actor":{"display_login":"Eric89GXL"}}