{"action":"created","issue":{"url":"https://api.github.com/repos/databricks/spark-avro/issues/148","repository_url":"https://api.github.com/repos/databricks/spark-avro","labels_url":"https://api.github.com/repos/databricks/spark-avro/issues/148/labels{/name}","comments_url":"https://api.github.com/repos/databricks/spark-avro/issues/148/comments","events_url":"https://api.github.com/repos/databricks/spark-avro/issues/148/events","html_url":"https://github.com/databricks/spark-avro/pull/148","id":169030543,"number":148,"title":"Fix Kryo-serializability of SerializableConfiguration","user":{"login":"JoshRosen","id":50748,"avatar_url":"https://avatars.githubusercontent.com/u/50748?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshRosen","html_url":"https://github.com/JoshRosen","followers_url":"https://api.github.com/users/JoshRosen/followers","following_url":"https://api.github.com/users/JoshRosen/following{/other_user}","gists_url":"https://api.github.com/users/JoshRosen/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshRosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshRosen/subscriptions","organizations_url":"https://api.github.com/users/JoshRosen/orgs","repos_url":"https://api.github.com/users/JoshRosen/repos","events_url":"https://api.github.com/users/JoshRosen/events{/privacy}","received_events_url":"https://api.github.com/users/JoshRosen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"liancheng","id":230655,"avatar_url":"https://avatars.githubusercontent.com/u/230655?v=3","gravatar_id":"","url":"https://api.github.com/users/liancheng","html_url":"https://github.com/liancheng","followers_url":"https://api.github.com/users/liancheng/followers","following_url":"https://api.github.com/users/liancheng/following{/other_user}","gists_url":"https://api.github.com/users/liancheng/gists{/gist_id}","starred_url":"https://api.github.com/users/liancheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liancheng/subscriptions","organizations_url":"https://api.github.com/users/liancheng/orgs","repos_url":"https://api.github.com/users/liancheng/repos","events_url":"https://api.github.com/users/liancheng/events{/privacy}","received_events_url":"https://api.github.com/users/liancheng/received_events","type":"User","site_admin":false},"assignees":[{"login":"liancheng","id":230655,"avatar_url":"https://avatars.githubusercontent.com/u/230655?v=3","gravatar_id":"","url":"https://api.github.com/users/liancheng","html_url":"https://github.com/liancheng","followers_url":"https://api.github.com/users/liancheng/followers","following_url":"https://api.github.com/users/liancheng/following{/other_user}","gists_url":"https://api.github.com/users/liancheng/gists{/gist_id}","starred_url":"https://api.github.com/users/liancheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liancheng/subscriptions","organizations_url":"https://api.github.com/users/liancheng/orgs","repos_url":"https://api.github.com/users/liancheng/repos","events_url":"https://api.github.com/users/liancheng/events{/privacy}","received_events_url":"https://api.github.com/users/liancheng/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/databricks/spark-avro/milestones/2","html_url":"https://github.com/databricks/spark-avro/milestones/3.0.1","labels_url":"https://api.github.com/repos/databricks/spark-avro/milestones/2/labels","id":1919705,"number":2,"title":"3.0.1","description":"","creator":{"login":"JoshRosen","id":50748,"avatar_url":"https://avatars.githubusercontent.com/u/50748?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshRosen","html_url":"https://github.com/JoshRosen","followers_url":"https://api.github.com/users/JoshRosen/followers","following_url":"https://api.github.com/users/JoshRosen/following{/other_user}","gists_url":"https://api.github.com/users/JoshRosen/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshRosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshRosen/subscriptions","organizations_url":"https://api.github.com/users/JoshRosen/orgs","repos_url":"https://api.github.com/users/JoshRosen/repos","events_url":"https://api.github.com/users/JoshRosen/events{/privacy}","received_events_url":"https://api.github.com/users/JoshRosen/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2016-08-03T01:59:10Z","updated_at":"2016-08-03T02:02:26Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-08-03T02:02:22Z","updated_at":"2016-08-03T14:25:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/databricks/spark-avro/pulls/148","html_url":"https://github.com/databricks/spark-avro/pull/148","diff_url":"https://github.com/databricks/spark-avro/pull/148.diff","patch_url":"https://github.com/databricks/spark-avro/pull/148.patch"},"body":"This library's inlined copy of `SerializableConfiguration` doesn't behave properly when serialized with Kryo, since its `readObject` and `writeObject` methods won't be invoked. In Spark's version of that class, this was handled by [registering](https://github.com/apache/spark/blob/ae226283e19ce396216c73b0ae2470efa122b65b/core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala#L108) the serializer with Kryo, but this library's copy did not do that, leading to NullPointerExceptions if Kryo serialization is enabled.\r\n\r\nIn order to fix this bug, this patch uses Kryo's `@DefaultSerializer` annotation to indicate that `SerializableConfiguration` should use Kryo's `JavaSerializer` instead of the default Kryo serializer.\r\n\r\nFixes #147."},"comment":{"url":"https://api.github.com/repos/databricks/spark-avro/issues/comments/237251849","html_url":"https://github.com/databricks/spark-avro/pull/148#issuecomment-237251849","issue_url":"https://api.github.com/repos/databricks/spark-avro/issues/148","id":237251849,"user":{"login":"liancheng","id":230655,"avatar_url":"https://avatars.githubusercontent.com/u/230655?v=3","gravatar_id":"","url":"https://api.github.com/users/liancheng","html_url":"https://github.com/liancheng","followers_url":"https://api.github.com/users/liancheng/followers","following_url":"https://api.github.com/users/liancheng/following{/other_user}","gists_url":"https://api.github.com/users/liancheng/gists{/gist_id}","starred_url":"https://api.github.com/users/liancheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liancheng/subscriptions","organizations_url":"https://api.github.com/users/liancheng/orgs","repos_url":"https://api.github.com/users/liancheng/repos","events_url":"https://api.github.com/users/liancheng/events{/privacy}","received_events_url":"https://api.github.com/users/liancheng/received_events","type":"User","site_admin":false},"created_at":"2016-08-03T14:25:23Z","updated_at":"2016-08-03T14:25:23Z","body":"LGTM."}}
{"actor":{"display_login":"liancheng"}}