{"action":"created","comment":{"url":"https://api.github.com/repos/Shark-ML/Shark/pulls/comments/60044699","id":60044699,"diff_hunk":"@@ -37,43 +37,40 @@\n #include <boost/fusion/adapted/std_pair.hpp>\n #include <shark/Data/SparseData.h>\n \n+using namespace shark;\n+\n namespace {\n \n-typedef std::pair<int, std::vector<std::pair<std::size_t, double> > > LibSVMPoint;\n+typedef std::pair<double, std::vector<std::pair<std::size_t, double> > > LibSVMPoint;\n inline std::vector<LibSVMPoint> \n-importSparseDataReader(\n-\tstd::istream& stream\n-) {\t\n-\tstd::vector<LibSVMPoint>  fileContents;\n-\twhile(stream){\n+importSparseDataReader(std::istream& stream) {","path":"src/Data/SparseData.cpp","position":31,"original_position":31,"commit_id":"f23a40098dc483f5256c543a26816bcb37de3ad0","original_commit_id":"f23a40098dc483f5256c543a26816bcb37de3ad0","user":{"login":"Ulfgard","id":15045382,"avatar_url":"https://avatars.githubusercontent.com/u/15045382?v=3","gravatar_id":"","url":"https://api.github.com/users/Ulfgard","html_url":"https://github.com/Ulfgard","followers_url":"https://api.github.com/users/Ulfgard/followers","following_url":"https://api.github.com/users/Ulfgard/following{/other_user}","gists_url":"https://api.github.com/users/Ulfgard/gists{/gist_id}","starred_url":"https://api.github.com/users/Ulfgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ulfgard/subscriptions","organizations_url":"https://api.github.com/users/Ulfgard/orgs","repos_url":"https://api.github.com/users/Ulfgard/repos","events_url":"https://api.github.com/users/Ulfgard/events{/privacy}","received_events_url":"https://api.github.com/users/Ulfgard/received_events","type":"User","site_admin":false},"body":"for VC++ it might help to put this into a separate compilation unit and add a header entry for it. Spirit takes a lot of ressources during compilation","created_at":"2016-04-18T11:51:28Z","updated_at":"2016-04-18T11:51:28Z","html_url":"https://github.com/Shark-ML/Shark/pull/71#discussion_r60044699","pull_request_url":"https://api.github.com/repos/Shark-ML/Shark/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/Shark-ML/Shark/pulls/comments/60044699"},"html":{"href":"https://github.com/Shark-ML/Shark/pull/71#discussion_r60044699"},"pull_request":{"href":"https://api.github.com/repos/Shark-ML/Shark/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/Shark-ML/Shark/pulls/71","id":66777346,"html_url":"https://github.com/Shark-ML/Shark/pull/71","diff_url":"https://github.com/Shark-ML/Shark/pull/71.diff","patch_url":"https://github.com/Shark-ML/Shark/pull/71.patch","issue_url":"https://api.github.com/repos/Shark-ML/Shark/issues/71","number":71,"state":"open","locked":false,"title":"Sparse data regression","user":{"login":"TGlas","id":4291427,"avatar_url":"https://avatars.githubusercontent.com/u/4291427?v=3","gravatar_id":"","url":"https://api.github.com/users/TGlas","html_url":"https://github.com/TGlas","followers_url":"https://api.github.com/users/TGlas/followers","following_url":"https://api.github.com/users/TGlas/following{/other_user}","gists_url":"https://api.github.com/users/TGlas/gists{/gist_id}","starred_url":"https://api.github.com/users/TGlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TGlas/subscriptions","organizations_url":"https://api.github.com/users/TGlas/orgs","repos_url":"https://api.github.com/users/TGlas/repos","events_url":"https://api.github.com/users/TGlas/events{/privacy}","received_events_url":"https://api.github.com/users/TGlas/received_events","type":"User","site_admin":false},"body":"This should fix the following issue\r\nhttps://github.com/Shark-ML/Shark/issues/70\r\nwhich I opened two days ago.\r\n","created_at":"2016-04-17T19:01:51Z","updated_at":"2016-04-18T11:51:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c523cf967949f217a4f78b1a412b54b7b9dd243","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Shark-ML/Shark/pulls/71/commits","review_comments_url":"https://api.github.com/repos/Shark-ML/Shark/pulls/71/comments","review_comment_url":"https://api.github.com/repos/Shark-ML/Shark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shark-ML/Shark/issues/71/comments","statuses_url":"https://api.github.com/repos/Shark-ML/Shark/statuses/f23a40098dc483f5256c543a26816bcb37de3ad0","head":{"label":"Shark-ML:SparseDataRegression","ref":"SparseDataRegression","sha":"f23a40098dc483f5256c543a26816bcb37de3ad0","user":{"login":"Shark-ML","id":14577069,"avatar_url":"https://avatars.githubusercontent.com/u/14577069?v=3","gravatar_id":"","url":"https://api.github.com/users/Shark-ML","html_url":"https://github.com/Shark-ML","followers_url":"https://api.github.com/users/Shark-ML/followers","following_url":"https://api.github.com/users/Shark-ML/following{/other_user}","gists_url":"https://api.github.com/users/Shark-ML/gists{/gist_id}","starred_url":"https://api.github.com/users/Shark-ML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shark-ML/subscriptions","organizations_url":"https://api.github.com/users/Shark-ML/orgs","repos_url":"https://api.github.com/users/Shark-ML/repos","events_url":"https://api.github.com/users/Shark-ML/events{/privacy}","received_events_url":"https://api.github.com/users/Shark-ML/received_events","type":"Organization","site_admin":false},"repo":{"id":43938541,"name":"Shark","full_name":"Shark-ML/Shark","owner":{"login":"Shark-ML","id":14577069,"avatar_url":"https://avatars.githubusercontent.com/u/14577069?v=3","gravatar_id":"","url":"https://api.github.com/users/Shark-ML","html_url":"https://github.com/Shark-ML","followers_url":"https://api.github.com/users/Shark-ML/followers","following_url":"https://api.github.com/users/Shark-ML/following{/other_user}","gists_url":"https://api.github.com/users/Shark-ML/gists{/gist_id}","starred_url":"https://api.github.com/users/Shark-ML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shark-ML/subscriptions","organizations_url":"https://api.github.com/users/Shark-ML/orgs","repos_url":"https://api.github.com/users/Shark-ML/repos","events_url":"https://api.github.com/users/Shark-ML/events{/privacy}","received_events_url":"https://api.github.com/users/Shark-ML/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shark-ML/Shark","description":"The Shark Machine Leaning Library. See more:","fork":false,"url":"https://api.github.com/repos/Shark-ML/Shark","forks_url":"https://api.github.com/repos/Shark-ML/Shark/forks","keys_url":"https://api.github.com/repos/Shark-ML/Shark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shark-ML/Shark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shark-ML/Shark/teams","hooks_url":"https://api.github.com/repos/Shark-ML/Shark/hooks","issue_events_url":"https://api.github.com/repos/Shark-ML/Shark/issues/events{/number}","events_url":"https://api.github.com/repos/Shark-ML/Shark/events","assignees_url":"https://api.github.com/repos/Shark-ML/Shark/assignees{/user}","branches_url":"https://api.github.com/repos/Shark-ML/Shark/branches{/branch}","tags_url":"https://api.github.com/repos/Shark-ML/Shark/tags","blobs_url":"https://api.github.com/repos/Shark-ML/Shark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shark-ML/Shark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shark-ML/Shark/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shark-ML/Shark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shark-ML/Shark/statuses/{sha}","languages_url":"https://api.github.com/repos/Shark-ML/Shark/languages","stargazers_url":"https://api.github.com/repos/Shark-ML/Shark/stargazers","contributors_url":"https://api.github.com/repos/Shark-ML/Shark/contributors","subscribers_url":"https://api.github.com/repos/Shark-ML/Shark/subscribers","subscription_url":"https://api.github.com/repos/Shark-ML/Shark/subscription","commits_url":"https://api.github.com/repos/Shark-ML/Shark/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shark-ML/Shark/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shark-ML/Shark/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shark-ML/Shark/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shark-ML/Shark/contents/{+path}","compare_url":"https://api.github.com/repos/Shark-ML/Shark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shark-ML/Shark/merges","archive_url":"https://api.github.com/repos/Shark-ML/Shark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shark-ML/Shark/downloads","issues_url":"https://api.github.com/repos/Shark-ML/Shark/issues{/number}","pulls_url":"https://api.github.com/repos/Shark-ML/Shark/pulls{/number}","milestones_url":"https://api.github.com/repos/Shark-ML/Shark/milestones{/number}","notifications_url":"https://api.github.com/repos/Shark-ML/Shark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shark-ML/Shark/labels{/name}","releases_url":"https://api.github.com/repos/Shark-ML/Shark/releases{/id}","deployments_url":"https://api.github.com/repos/Shark-ML/Shark/deployments","created_at":"2015-10-09T07:02:53Z","updated_at":"2016-04-13T13:14:04Z","pushed_at":"2016-04-17T19:01:53Z","git_url":"git://github.com/Shark-ML/Shark.git","ssh_url":"git@github.com:Shark-ML/Shark.git","clone_url":"https://github.com/Shark-ML/Shark.git","svn_url":"https://github.com/Shark-ML/Shark","homepage":"http://image.diku.dk/shark","size":27596,"stargazers_count":73,"watchers_count":73,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"open_issues_count":29,"forks":31,"open_issues":29,"watchers":73,"default_branch":"master"}},"base":{"label":"Shark-ML:master","ref":"master","sha":"daa05492fa8946486cc5dd0d73c0450552f8a0eb","user":{"login":"Shark-ML","id":14577069,"avatar_url":"https://avatars.githubusercontent.com/u/14577069?v=3","gravatar_id":"","url":"https://api.github.com/users/Shark-ML","html_url":"https://github.com/Shark-ML","followers_url":"https://api.github.com/users/Shark-ML/followers","following_url":"https://api.github.com/users/Shark-ML/following{/other_user}","gists_url":"https://api.github.com/users/Shark-ML/gists{/gist_id}","starred_url":"https://api.github.com/users/Shark-ML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shark-ML/subscriptions","organizations_url":"https://api.github.com/users/Shark-ML/orgs","repos_url":"https://api.github.com/users/Shark-ML/repos","events_url":"https://api.github.com/users/Shark-ML/events{/privacy}","received_events_url":"https://api.github.com/users/Shark-ML/received_events","type":"Organization","site_admin":false},"repo":{"id":43938541,"name":"Shark","full_name":"Shark-ML/Shark","owner":{"login":"Shark-ML","id":14577069,"avatar_url":"https://avatars.githubusercontent.com/u/14577069?v=3","gravatar_id":"","url":"https://api.github.com/users/Shark-ML","html_url":"https://github.com/Shark-ML","followers_url":"https://api.github.com/users/Shark-ML/followers","following_url":"https://api.github.com/users/Shark-ML/following{/other_user}","gists_url":"https://api.github.com/users/Shark-ML/gists{/gist_id}","starred_url":"https://api.github.com/users/Shark-ML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shark-ML/subscriptions","organizations_url":"https://api.github.com/users/Shark-ML/orgs","repos_url":"https://api.github.com/users/Shark-ML/repos","events_url":"https://api.github.com/users/Shark-ML/events{/privacy}","received_events_url":"https://api.github.com/users/Shark-ML/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shark-ML/Shark","description":"The Shark Machine Leaning Library. See more:","fork":false,"url":"https://api.github.com/repos/Shark-ML/Shark","forks_url":"https://api.github.com/repos/Shark-ML/Shark/forks","keys_url":"https://api.github.com/repos/Shark-ML/Shark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shark-ML/Shark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shark-ML/Shark/teams","hooks_url":"https://api.github.com/repos/Shark-ML/Shark/hooks","issue_events_url":"https://api.github.com/repos/Shark-ML/Shark/issues/events{/number}","events_url":"https://api.github.com/repos/Shark-ML/Shark/events","assignees_url":"https://api.github.com/repos/Shark-ML/Shark/assignees{/user}","branches_url":"https://api.github.com/repos/Shark-ML/Shark/branches{/branch}","tags_url":"https://api.github.com/repos/Shark-ML/Shark/tags","blobs_url":"https://api.github.com/repos/Shark-ML/Shark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shark-ML/Shark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shark-ML/Shark/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shark-ML/Shark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shark-ML/Shark/statuses/{sha}","languages_url":"https://api.github.com/repos/Shark-ML/Shark/languages","stargazers_url":"https://api.github.com/repos/Shark-ML/Shark/stargazers","contributors_url":"https://api.github.com/repos/Shark-ML/Shark/contributors","subscribers_url":"https://api.github.com/repos/Shark-ML/Shark/subscribers","subscription_url":"https://api.github.com/repos/Shark-ML/Shark/subscription","commits_url":"https://api.github.com/repos/Shark-ML/Shark/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shark-ML/Shark/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shark-ML/Shark/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shark-ML/Shark/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shark-ML/Shark/contents/{+path}","compare_url":"https://api.github.com/repos/Shark-ML/Shark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shark-ML/Shark/merges","archive_url":"https://api.github.com/repos/Shark-ML/Shark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shark-ML/Shark/downloads","issues_url":"https://api.github.com/repos/Shark-ML/Shark/issues{/number}","pulls_url":"https://api.github.com/repos/Shark-ML/Shark/pulls{/number}","milestones_url":"https://api.github.com/repos/Shark-ML/Shark/milestones{/number}","notifications_url":"https://api.github.com/repos/Shark-ML/Shark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shark-ML/Shark/labels{/name}","releases_url":"https://api.github.com/repos/Shark-ML/Shark/releases{/id}","deployments_url":"https://api.github.com/repos/Shark-ML/Shark/deployments","created_at":"2015-10-09T07:02:53Z","updated_at":"2016-04-13T13:14:04Z","pushed_at":"2016-04-17T19:01:53Z","git_url":"git://github.com/Shark-ML/Shark.git","ssh_url":"git@github.com:Shark-ML/Shark.git","clone_url":"https://github.com/Shark-ML/Shark.git","svn_url":"https://github.com/Shark-ML/Shark","homepage":"http://image.diku.dk/shark","size":27596,"stargazers_count":73,"watchers_count":73,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"open_issues_count":29,"forks":31,"open_issues":29,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shark-ML/Shark/pulls/71"},"html":{"href":"https://github.com/Shark-ML/Shark/pull/71"},"issue":{"href":"https://api.github.com/repos/Shark-ML/Shark/issues/71"},"comments":{"href":"https://api.github.com/repos/Shark-ML/Shark/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/Shark-ML/Shark/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/Shark-ML/Shark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shark-ML/Shark/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/Shark-ML/Shark/statuses/f23a40098dc483f5256c543a26816bcb37de3ad0"}}}}