{"action":"created","comment":{"url":"https://api.github.com/repos/openvstorage/framework/pulls/comments/87974982","pull_request_review_id":8562589,"id":87974982,"diff_hunk":"@@ -163,7 +163,7 @@ def get_free_ports(selected_range, exclude=None, nr=1, client=None):\n         if client is None:\n             output = check_output(cmd, shell=True)\n         else:\n-            output = client.run(cmd)\n+            output = client.run(cmd.split(' '))","path":"ovs/extensions/generic/system.py","position":23,"original_position":23,"commit_id":"285e6c96b6855d854cd2ab2adee84f677fb83f74","original_commit_id":"285e6c96b6855d854cd2ab2adee84f677fb83f74","user":{"login":"kvanhijf","id":13535590,"avatar_url":"https://avatars.githubusercontent.com/u/13535590?v=3","gravatar_id":"","url":"https://api.github.com/users/kvanhijf","html_url":"https://github.com/kvanhijf","followers_url":"https://api.github.com/users/kvanhijf/followers","following_url":"https://api.github.com/users/kvanhijf/following{/other_user}","gists_url":"https://api.github.com/users/kvanhijf/gists{/gist_id}","starred_url":"https://api.github.com/users/kvanhijf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvanhijf/subscriptions","organizations_url":"https://api.github.com/users/kvanhijf/orgs","repos_url":"https://api.github.com/users/kvanhijf/repos","events_url":"https://api.github.com/users/kvanhijf/events{/privacy}","received_events_url":"https://api.github.com/users/kvanhijf/received_events","type":"User","site_admin":false},"body":"Its better to use ```cmd.split()```, because ```split()``` will strip all whitespaces and ```split(' ')``` will keep whitespaces\r\nEg:\r\n```\r\nIn [3]: cmd = 'cat  /proc/sys/net/ipv4/ip_local_port_range'   <-- 2 spaces\r\n\r\nIn [4]: cmd.split(' ')\r\nOut[4]: ['cat', '', '/proc/sys/net/ipv4/ip_local_port_range']\r\n```\r\n\r\n","created_at":"2016-11-15T09:19:30Z","updated_at":"2016-11-15T09:19:30Z","html_url":"https://github.com/openvstorage/framework/pull/1137#discussion_r87974982","pull_request_url":"https://api.github.com/repos/openvstorage/framework/pulls/1137","_links":{"self":{"href":"https://api.github.com/repos/openvstorage/framework/pulls/comments/87974982"},"html":{"href":"https://github.com/openvstorage/framework/pull/1137#discussion_r87974982"},"pull_request":{"href":"https://api.github.com/repos/openvstorage/framework/pulls/1137"}}},"pull_request":{"url":"https://api.github.com/repos/openvstorage/framework/pulls/1137","id":92794807,"html_url":"https://github.com/openvstorage/framework/pull/1137","diff_url":"https://github.com/openvstorage/framework/pull/1137.diff","patch_url":"https://github.com/openvstorage/framework/pull/1137.patch","issue_url":"https://api.github.com/repos/openvstorage/framework/issues/1137","number":1137,"state":"open","locked":false,"title":"More secure shell","user":{"login":"khenderick","id":1453214,"avatar_url":"https://avatars.githubusercontent.com/u/1453214?v=3","gravatar_id":"","url":"https://api.github.com/users/khenderick","html_url":"https://github.com/khenderick","followers_url":"https://api.github.com/users/khenderick/followers","following_url":"https://api.github.com/users/khenderick/following{/other_user}","gists_url":"https://api.github.com/users/khenderick/gists{/gist_id}","starred_url":"https://api.github.com/users/khenderick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khenderick/subscriptions","organizations_url":"https://api.github.com/users/khenderick/orgs","repos_url":"https://api.github.com/users/khenderick/repos","events_url":"https://api.github.com/users/khenderick/events{/privacy}","received_events_url":"https://api.github.com/users/khenderick/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-08T15:05:33Z","updated_at":"2016-11-15T09:20:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56fa64e942959930537ad10247fdcf36c1a2161f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openvstorage/framework/pulls/1137/commits","review_comments_url":"https://api.github.com/repos/openvstorage/framework/pulls/1137/comments","review_comment_url":"https://api.github.com/repos/openvstorage/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openvstorage/framework/issues/1137/comments","statuses_url":"https://api.github.com/repos/openvstorage/framework/statuses/285e6c96b6855d854cd2ab2adee84f677fb83f74","head":{"label":"openvstorage:more-secure-shell","ref":"more-secure-shell","sha":"285e6c96b6855d854cd2ab2adee84f677fb83f74","user":{"login":"openvstorage","id":12763393,"avatar_url":"https://avatars.githubusercontent.com/u/12763393?v=3","gravatar_id":"","url":"https://api.github.com/users/openvstorage","html_url":"https://github.com/openvstorage","followers_url":"https://api.github.com/users/openvstorage/followers","following_url":"https://api.github.com/users/openvstorage/following{/other_user}","gists_url":"https://api.github.com/users/openvstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/openvstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openvstorage/subscriptions","organizations_url":"https://api.github.com/users/openvstorage/orgs","repos_url":"https://api.github.com/users/openvstorage/repos","events_url":"https://api.github.com/users/openvstorage/events{/privacy}","received_events_url":"https://api.github.com/users/openvstorage/received_events","type":"Organization","site_admin":false},"repo":{"id":39504796,"name":"framework","full_name":"openvstorage/framework","owner":{"login":"openvstorage","id":12763393,"avatar_url":"https://avatars.githubusercontent.com/u/12763393?v=3","gravatar_id":"","url":"https://api.github.com/users/openvstorage","html_url":"https://github.com/openvstorage","followers_url":"https://api.github.com/users/openvstorage/followers","following_url":"https://api.github.com/users/openvstorage/following{/other_user}","gists_url":"https://api.github.com/users/openvstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/openvstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openvstorage/subscriptions","organizations_url":"https://api.github.com/users/openvstorage/orgs","repos_url":"https://api.github.com/users/openvstorage/repos","events_url":"https://api.github.com/users/openvstorage/events{/privacy}","received_events_url":"https://api.github.com/users/openvstorage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openvstorage/framework","description":"The Framework is a set of components and tools which brings the user an interface (GUI / API) to setup, extend and manage an Open vStorage platform.","fork":false,"url":"https://api.github.com/repos/openvstorage/framework","forks_url":"https://api.github.com/repos/openvstorage/framework/forks","keys_url":"https://api.github.com/repos/openvstorage/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openvstorage/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openvstorage/framework/teams","hooks_url":"https://api.github.com/repos/openvstorage/framework/hooks","issue_events_url":"https://api.github.com/repos/openvstorage/framework/issues/events{/number}","events_url":"https://api.github.com/repos/openvstorage/framework/events","assignees_url":"https://api.github.com/repos/openvstorage/framework/assignees{/user}","branches_url":"https://api.github.com/repos/openvstorage/framework/branches{/branch}","tags_url":"https://api.github.com/repos/openvstorage/framework/tags","blobs_url":"https://api.github.com/repos/openvstorage/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openvstorage/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openvstorage/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/openvstorage/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openvstorage/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/openvstorage/framework/languages","stargazers_url":"https://api.github.com/repos/openvstorage/framework/stargazers","contributors_url":"https://api.github.com/repos/openvstorage/framework/contributors","subscribers_url":"https://api.github.com/repos/openvstorage/framework/subscribers","subscription_url":"https://api.github.com/repos/openvstorage/framework/subscription","commits_url":"https://api.github.com/repos/openvstorage/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/openvstorage/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/openvstorage/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/openvstorage/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/openvstorage/framework/contents/{+path}","compare_url":"https://api.github.com/repos/openvstorage/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openvstorage/framework/merges","archive_url":"https://api.github.com/repos/openvstorage/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openvstorage/framework/downloads","issues_url":"https://api.github.com/repos/openvstorage/framework/issues{/number}","pulls_url":"https://api.github.com/repos/openvstorage/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/openvstorage/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/openvstorage/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openvstorage/framework/labels{/name}","releases_url":"https://api.github.com/repos/openvstorage/framework/releases{/id}","deployments_url":"https://api.github.com/repos/openvstorage/framework/deployments","created_at":"2015-07-22T12:29:15Z","updated_at":"2016-10-25T08:06:16Z","pushed_at":"2016-11-14T12:35:30Z","git_url":"git://github.com/openvstorage/framework.git","ssh_url":"git@github.com:openvstorage/framework.git","clone_url":"https://github.com/openvstorage/framework.git","svn_url":"https://github.com/openvstorage/framework","homepage":"","size":13109,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":126,"forks":18,"open_issues":126,"watchers":17,"default_branch":"master"}},"base":{"label":"openvstorage:master","ref":"master","sha":"6612d8c1422de154ee126b159914d9c0f1fc6e4b","user":{"login":"openvstorage","id":12763393,"avatar_url":"https://avatars.githubusercontent.com/u/12763393?v=3","gravatar_id":"","url":"https://api.github.com/users/openvstorage","html_url":"https://github.com/openvstorage","followers_url":"https://api.github.com/users/openvstorage/followers","following_url":"https://api.github.com/users/openvstorage/following{/other_user}","gists_url":"https://api.github.com/users/openvstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/openvstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openvstorage/subscriptions","organizations_url":"https://api.github.com/users/openvstorage/orgs","repos_url":"https://api.github.com/users/openvstorage/repos","events_url":"https://api.github.com/users/openvstorage/events{/privacy}","received_events_url":"https://api.github.com/users/openvstorage/received_events","type":"Organization","site_admin":false},"repo":{"id":39504796,"name":"framework","full_name":"openvstorage/framework","owner":{"login":"openvstorage","id":12763393,"avatar_url":"https://avatars.githubusercontent.com/u/12763393?v=3","gravatar_id":"","url":"https://api.github.com/users/openvstorage","html_url":"https://github.com/openvstorage","followers_url":"https://api.github.com/users/openvstorage/followers","following_url":"https://api.github.com/users/openvstorage/following{/other_user}","gists_url":"https://api.github.com/users/openvstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/openvstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openvstorage/subscriptions","organizations_url":"https://api.github.com/users/openvstorage/orgs","repos_url":"https://api.github.com/users/openvstorage/repos","events_url":"https://api.github.com/users/openvstorage/events{/privacy}","received_events_url":"https://api.github.com/users/openvstorage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openvstorage/framework","description":"The Framework is a set of components and tools which brings the user an interface (GUI / API) to setup, extend and manage an Open vStorage platform.","fork":false,"url":"https://api.github.com/repos/openvstorage/framework","forks_url":"https://api.github.com/repos/openvstorage/framework/forks","keys_url":"https://api.github.com/repos/openvstorage/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openvstorage/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openvstorage/framework/teams","hooks_url":"https://api.github.com/repos/openvstorage/framework/hooks","issue_events_url":"https://api.github.com/repos/openvstorage/framework/issues/events{/number}","events_url":"https://api.github.com/repos/openvstorage/framework/events","assignees_url":"https://api.github.com/repos/openvstorage/framework/assignees{/user}","branches_url":"https://api.github.com/repos/openvstorage/framework/branches{/branch}","tags_url":"https://api.github.com/repos/openvstorage/framework/tags","blobs_url":"https://api.github.com/repos/openvstorage/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openvstorage/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openvstorage/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/openvstorage/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openvstorage/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/openvstorage/framework/languages","stargazers_url":"https://api.github.com/repos/openvstorage/framework/stargazers","contributors_url":"https://api.github.com/repos/openvstorage/framework/contributors","subscribers_url":"https://api.github.com/repos/openvstorage/framework/subscribers","subscription_url":"https://api.github.com/repos/openvstorage/framework/subscription","commits_url":"https://api.github.com/repos/openvstorage/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/openvstorage/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/openvstorage/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/openvstorage/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/openvstorage/framework/contents/{+path}","compare_url":"https://api.github.com/repos/openvstorage/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openvstorage/framework/merges","archive_url":"https://api.github.com/repos/openvstorage/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openvstorage/framework/downloads","issues_url":"https://api.github.com/repos/openvstorage/framework/issues{/number}","pulls_url":"https://api.github.com/repos/openvstorage/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/openvstorage/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/openvstorage/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openvstorage/framework/labels{/name}","releases_url":"https://api.github.com/repos/openvstorage/framework/releases{/id}","deployments_url":"https://api.github.com/repos/openvstorage/framework/deployments","created_at":"2015-07-22T12:29:15Z","updated_at":"2016-10-25T08:06:16Z","pushed_at":"2016-11-14T12:35:30Z","git_url":"git://github.com/openvstorage/framework.git","ssh_url":"git@github.com:openvstorage/framework.git","clone_url":"https://github.com/openvstorage/framework.git","svn_url":"https://github.com/openvstorage/framework","homepage":"","size":13109,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":126,"forks":18,"open_issues":126,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openvstorage/framework/pulls/1137"},"html":{"href":"https://github.com/openvstorage/framework/pull/1137"},"issue":{"href":"https://api.github.com/repos/openvstorage/framework/issues/1137"},"comments":{"href":"https://api.github.com/repos/openvstorage/framework/issues/1137/comments"},"review_comments":{"href":"https://api.github.com/repos/openvstorage/framework/pulls/1137/comments"},"review_comment":{"href":"https://api.github.com/repos/openvstorage/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openvstorage/framework/pulls/1137/commits"},"statuses":{"href":"https://api.github.com/repos/openvstorage/framework/statuses/285e6c96b6855d854cd2ab2adee84f677fb83f74"}}}}
{"actor":{"display_login":"kvanhijf"}}