{"action":"created","issue":{"url":"https://api.github.com/repos/solidusio/solidus/issues/918","repository_url":"https://api.github.com/repos/solidusio/solidus","labels_url":"https://api.github.com/repos/solidusio/solidus/issues/918/labels{/name}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/918/comments","events_url":"https://api.github.com/repos/solidusio/solidus/issues/918/events","html_url":"https://github.com/solidusio/solidus/pull/918","id":136775971,"number":918,"title":"Make TaxHelper method accept params","user":{"login":"mamhoff","id":703401,"avatar_url":"https://avatars.githubusercontent.com/u/703401?v=3","gravatar_id":"","url":"https://api.github.com/users/mamhoff","html_url":"https://github.com/mamhoff","followers_url":"https://api.github.com/users/mamhoff/followers","following_url":"https://api.github.com/users/mamhoff/following{/other_user}","gists_url":"https://api.github.com/users/mamhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/mamhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamhoff/subscriptions","organizations_url":"https://api.github.com/users/mamhoff/orgs","repos_url":"https://api.github.com/users/mamhoff/repos","events_url":"https://api.github.com/users/mamhoff/events{/privacy}","received_events_url":"https://api.github.com/users/mamhoff/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-26T18:28:55Z","updated_at":"2016-02-26T19:56:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/918","html_url":"https://github.com/solidusio/solidus/pull/918","diff_url":"https://github.com/solidusio/solidus/pull/918.diff","patch_url":"https://github.com/solidusio/solidus/pull/918.patch"},"body":"While reviewing the PR that would add a ShippingRateTaxer object,\r\nwe found that having these method implicitly rely on an `order` method\r\ndefined in the including code is not so desirable.\r\n\r\nThis commit changes the signatures of the tax helper methods so they always\r\nexplicitly take an order object.\r\n\r\nThere's a second commit coming up in this PR. It's tiny. "},"comment":{"url":"https://api.github.com/repos/solidusio/solidus/issues/comments/189456215","html_url":"https://github.com/solidusio/solidus/pull/918#issuecomment-189456215","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/918","id":189456215,"user":{"login":"cbrunsdon","id":279013,"avatar_url":"https://avatars.githubusercontent.com/u/279013?v=3","gravatar_id":"","url":"https://api.github.com/users/cbrunsdon","html_url":"https://github.com/cbrunsdon","followers_url":"https://api.github.com/users/cbrunsdon/followers","following_url":"https://api.github.com/users/cbrunsdon/following{/other_user}","gists_url":"https://api.github.com/users/cbrunsdon/gists{/gist_id}","starred_url":"https://api.github.com/users/cbrunsdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbrunsdon/subscriptions","organizations_url":"https://api.github.com/users/cbrunsdon/orgs","repos_url":"https://api.github.com/users/cbrunsdon/repos","events_url":"https://api.github.com/users/cbrunsdon/events{/privacy}","received_events_url":"https://api.github.com/users/cbrunsdon/received_events","type":"User","site_admin":false},"created_at":"2016-02-26T19:56:36Z","updated_at":"2016-02-26T19:56:36Z","body":"I'm :+1: this, I think its cleaner and clearer than the  module expecting specific methods defined by anything that includes. "}}