{"action":"closed","number":3659,"pull_request":{"url":"https://api.github.com/repos/mitchellh/packer/pulls/3659","id":75571755,"html_url":"https://github.com/mitchellh/packer/pull/3659","diff_url":"https://github.com/mitchellh/packer/pull/3659.diff","patch_url":"https://github.com/mitchellh/packer/pull/3659.patch","issue_url":"https://api.github.com/repos/mitchellh/packer/issues/3659","number":3659,"state":"closed","locked":false,"title":"azure: handle non-OK responses for key vault","user":{"login":"boumenot","id":91112,"avatar_url":"https://avatars.githubusercontent.com/u/91112?v=3","gravatar_id":"","url":"https://api.github.com/users/boumenot","html_url":"https://github.com/boumenot","followers_url":"https://api.github.com/users/boumenot/followers","following_url":"https://api.github.com/users/boumenot/following{/other_user}","gists_url":"https://api.github.com/users/boumenot/gists{/gist_id}","starred_url":"https://api.github.com/users/boumenot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boumenot/subscriptions","organizations_url":"https://api.github.com/users/boumenot/orgs","repos_url":"https://api.github.com/users/boumenot/repos","events_url":"https://api.github.com/users/boumenot/events{/privacy}","received_events_url":"https://api.github.com/users/boumenot/received_events","type":"User","site_admin":false},"body":"Check the response when fetching a secret from KeyVault.  Any non-OK (200) are considered to be an error.  This will provide a more informed error message for the user.\r\n\r\nCloses #3581","created_at":"2016-06-29T00:26:33Z","updated_at":"2016-06-29T00:42:27Z","closed_at":"2016-06-29T00:42:25Z","merged_at":"2016-06-29T00:42:25Z","merge_commit_sha":"63edbd40edc5a55394f8532aa9958bbe257b31b5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mitchellh/packer/pulls/3659/commits","review_comments_url":"https://api.github.com/repos/mitchellh/packer/pulls/3659/comments","review_comment_url":"https://api.github.com/repos/mitchellh/packer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mitchellh/packer/issues/3659/comments","statuses_url":"https://api.github.com/repos/mitchellh/packer/statuses/fed72ded0d137a76edec7261d58232e08c403738","head":{"label":"boumenot:pr-certificate-nil-ref","ref":"pr-certificate-nil-ref","sha":"fed72ded0d137a76edec7261d58232e08c403738","user":{"login":"boumenot","id":91112,"avatar_url":"https://avatars.githubusercontent.com/u/91112?v=3","gravatar_id":"","url":"https://api.github.com/users/boumenot","html_url":"https://github.com/boumenot","followers_url":"https://api.github.com/users/boumenot/followers","following_url":"https://api.github.com/users/boumenot/following{/other_user}","gists_url":"https://api.github.com/users/boumenot/gists{/gist_id}","starred_url":"https://api.github.com/users/boumenot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boumenot/subscriptions","organizations_url":"https://api.github.com/users/boumenot/orgs","repos_url":"https://api.github.com/users/boumenot/repos","events_url":"https://api.github.com/users/boumenot/events{/privacy}","received_events_url":"https://api.github.com/users/boumenot/received_events","type":"User","site_admin":false},"repo":{"id":50624785,"name":"packer","full_name":"boumenot/packer","owner":{"login":"boumenot","id":91112,"avatar_url":"https://avatars.githubusercontent.com/u/91112?v=3","gravatar_id":"","url":"https://api.github.com/users/boumenot","html_url":"https://github.com/boumenot","followers_url":"https://api.github.com/users/boumenot/followers","following_url":"https://api.github.com/users/boumenot/following{/other_user}","gists_url":"https://api.github.com/users/boumenot/gists{/gist_id}","starred_url":"https://api.github.com/users/boumenot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boumenot/subscriptions","organizations_url":"https://api.github.com/users/boumenot/orgs","repos_url":"https://api.github.com/users/boumenot/repos","events_url":"https://api.github.com/users/boumenot/events{/privacy}","received_events_url":"https://api.github.com/users/boumenot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/boumenot/packer","description":"Packer is a tool for creating identical machine images for multiple platforms from a single source configuration.","fork":true,"url":"https://api.github.com/repos/boumenot/packer","forks_url":"https://api.github.com/repos/boumenot/packer/forks","keys_url":"https://api.github.com/repos/boumenot/packer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boumenot/packer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boumenot/packer/teams","hooks_url":"https://api.github.com/repos/boumenot/packer/hooks","issue_events_url":"https://api.github.com/repos/boumenot/packer/issues/events{/number}","events_url":"https://api.github.com/repos/boumenot/packer/events","assignees_url":"https://api.github.com/repos/boumenot/packer/assignees{/user}","branches_url":"https://api.github.com/repos/boumenot/packer/branches{/branch}","tags_url":"https://api.github.com/repos/boumenot/packer/tags","blobs_url":"https://api.github.com/repos/boumenot/packer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boumenot/packer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boumenot/packer/git/refs{/sha}","trees_url":"https://api.github.com/repos/boumenot/packer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boumenot/packer/statuses/{sha}","languages_url":"https://api.github.com/repos/boumenot/packer/languages","stargazers_url":"https://api.github.com/repos/boumenot/packer/stargazers","contributors_url":"https://api.github.com/repos/boumenot/packer/contributors","subscribers_url":"https://api.github.com/repos/boumenot/packer/subscribers","subscription_url":"https://api.github.com/repos/boumenot/packer/subscription","commits_url":"https://api.github.com/repos/boumenot/packer/commits{/sha}","git_commits_url":"https://api.github.com/repos/boumenot/packer/git/commits{/sha}","comments_url":"https://api.github.com/repos/boumenot/packer/comments{/number}","issue_comment_url":"https://api.github.com/repos/boumenot/packer/issues/comments{/number}","contents_url":"https://api.github.com/repos/boumenot/packer/contents/{+path}","compare_url":"https://api.github.com/repos/boumenot/packer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boumenot/packer/merges","archive_url":"https://api.github.com/repos/boumenot/packer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boumenot/packer/downloads","issues_url":"https://api.github.com/repos/boumenot/packer/issues{/number}","pulls_url":"https://api.github.com/repos/boumenot/packer/pulls{/number}","milestones_url":"https://api.github.com/repos/boumenot/packer/milestones{/number}","notifications_url":"https://api.github.com/repos/boumenot/packer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boumenot/packer/labels{/name}","releases_url":"https://api.github.com/repos/boumenot/packer/releases{/id}","deployments_url":"https://api.github.com/repos/boumenot/packer/deployments","created_at":"2016-01-29T00:27:21Z","updated_at":"2016-01-29T00:27:24Z","pushed_at":"2016-06-29T00:42:28Z","git_url":"git://github.com/boumenot/packer.git","ssh_url":"git@github.com:boumenot/packer.git","clone_url":"https://github.com/boumenot/packer.git","svn_url":"https://github.com/boumenot/packer","homepage":"http://www.packer.io","size":18726,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mitchellh:master","ref":"master","sha":"97b536e5c52b8488fe1cbbf5737f9e9b1b3506af","user":{"login":"mitchellh","id":1299,"avatar_url":"https://avatars.githubusercontent.com/u/1299?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellh","html_url":"https://github.com/mitchellh","followers_url":"https://api.github.com/users/mitchellh/followers","following_url":"https://api.github.com/users/mitchellh/following{/other_user}","gists_url":"https://api.github.com/users/mitchellh/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellh/subscriptions","organizations_url":"https://api.github.com/users/mitchellh/orgs","repos_url":"https://api.github.com/users/mitchellh/repos","events_url":"https://api.github.com/users/mitchellh/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellh/received_events","type":"User","site_admin":false},"repo":{"id":8966356,"name":"packer","full_name":"mitchellh/packer","owner":{"login":"mitchellh","id":1299,"avatar_url":"https://avatars.githubusercontent.com/u/1299?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellh","html_url":"https://github.com/mitchellh","followers_url":"https://api.github.com/users/mitchellh/followers","following_url":"https://api.github.com/users/mitchellh/following{/other_user}","gists_url":"https://api.github.com/users/mitchellh/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellh/subscriptions","organizations_url":"https://api.github.com/users/mitchellh/orgs","repos_url":"https://api.github.com/users/mitchellh/repos","events_url":"https://api.github.com/users/mitchellh/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mitchellh/packer","description":"Packer is a tool for creating identical machine images for multiple platforms from a single source configuration.","fork":false,"url":"https://api.github.com/repos/mitchellh/packer","forks_url":"https://api.github.com/repos/mitchellh/packer/forks","keys_url":"https://api.github.com/repos/mitchellh/packer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitchellh/packer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitchellh/packer/teams","hooks_url":"https://api.github.com/repos/mitchellh/packer/hooks","issue_events_url":"https://api.github.com/repos/mitchellh/packer/issues/events{/number}","events_url":"https://api.github.com/repos/mitchellh/packer/events","assignees_url":"https://api.github.com/repos/mitchellh/packer/assignees{/user}","branches_url":"https://api.github.com/repos/mitchellh/packer/branches{/branch}","tags_url":"https://api.github.com/repos/mitchellh/packer/tags","blobs_url":"https://api.github.com/repos/mitchellh/packer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitchellh/packer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitchellh/packer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitchellh/packer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitchellh/packer/statuses/{sha}","languages_url":"https://api.github.com/repos/mitchellh/packer/languages","stargazers_url":"https://api.github.com/repos/mitchellh/packer/stargazers","contributors_url":"https://api.github.com/repos/mitchellh/packer/contributors","subscribers_url":"https://api.github.com/repos/mitchellh/packer/subscribers","subscription_url":"https://api.github.com/repos/mitchellh/packer/subscription","commits_url":"https://api.github.com/repos/mitchellh/packer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitchellh/packer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitchellh/packer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitchellh/packer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitchellh/packer/contents/{+path}","compare_url":"https://api.github.com/repos/mitchellh/packer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitchellh/packer/merges","archive_url":"https://api.github.com/repos/mitchellh/packer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitchellh/packer/downloads","issues_url":"https://api.github.com/repos/mitchellh/packer/issues{/number}","pulls_url":"https://api.github.com/repos/mitchellh/packer/pulls{/number}","milestones_url":"https://api.github.com/repos/mitchellh/packer/milestones{/number}","notifications_url":"https://api.github.com/repos/mitchellh/packer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitchellh/packer/labels{/name}","releases_url":"https://api.github.com/repos/mitchellh/packer/releases{/id}","deployments_url":"https://api.github.com/repos/mitchellh/packer/deployments","created_at":"2013-03-23T05:43:03Z","updated_at":"2016-06-27T22:39:21Z","pushed_at":"2016-06-29T00:42:25Z","git_url":"git://github.com/mitchellh/packer.git","ssh_url":"git@github.com:mitchellh/packer.git","clone_url":"https://github.com/mitchellh/packer.git","svn_url":"https://github.com/mitchellh/packer","homepage":"http://www.packer.io","size":35648,"stargazers_count":5440,"watchers_count":5440,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1269,"mirror_url":null,"open_issues_count":518,"forks":1269,"open_issues":518,"watchers":5440,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mitchellh/packer/pulls/3659"},"html":{"href":"https://github.com/mitchellh/packer/pull/3659"},"issue":{"href":"https://api.github.com/repos/mitchellh/packer/issues/3659"},"comments":{"href":"https://api.github.com/repos/mitchellh/packer/issues/3659/comments"},"review_comments":{"href":"https://api.github.com/repos/mitchellh/packer/pulls/3659/comments"},"review_comment":{"href":"https://api.github.com/repos/mitchellh/packer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mitchellh/packer/pulls/3659/commits"},"statuses":{"href":"https://api.github.com/repos/mitchellh/packer/statuses/fed72ded0d137a76edec7261d58232e08c403738"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"boumenot","id":91112,"avatar_url":"https://avatars.githubusercontent.com/u/91112?v=3","gravatar_id":"","url":"https://api.github.com/users/boumenot","html_url":"https://github.com/boumenot","followers_url":"https://api.github.com/users/boumenot/followers","following_url":"https://api.github.com/users/boumenot/following{/other_user}","gists_url":"https://api.github.com/users/boumenot/gists{/gist_id}","starred_url":"https://api.github.com/users/boumenot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boumenot/subscriptions","organizations_url":"https://api.github.com/users/boumenot/orgs","repos_url":"https://api.github.com/users/boumenot/repos","events_url":"https://api.github.com/users/boumenot/events{/privacy}","received_events_url":"https://api.github.com/users/boumenot/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":10,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"boumenot"}}