{"action":"created","issue":{"url":"https://api.github.com/repos/dotse/zonemaster-engine/issues/231","repository_url":"https://api.github.com/repos/dotse/zonemaster-engine","labels_url":"https://api.github.com/repos/dotse/zonemaster-engine/issues/231/labels{/name}","comments_url":"https://api.github.com/repos/dotse/zonemaster-engine/issues/231/comments","events_url":"https://api.github.com/repos/dotse/zonemaster-engine/issues/231/events","html_url":"https://github.com/dotse/zonemaster-engine/issues/231","id":181395674,"number":231,"title":"Using alternative config with logfilter fails","user":{"login":"aabdnn","id":1058891,"avatar_url":"https://avatars.githubusercontent.com/u/1058891?v=3","gravatar_id":"","url":"https://api.github.com/users/aabdnn","html_url":"https://github.com/aabdnn","followers_url":"https://api.github.com/users/aabdnn/followers","following_url":"https://api.github.com/users/aabdnn/following{/other_user}","gists_url":"https://api.github.com/users/aabdnn/gists{/gist_id}","starred_url":"https://api.github.com/users/aabdnn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabdnn/subscriptions","organizations_url":"https://api.github.com/users/aabdnn/orgs","repos_url":"https://api.github.com/users/aabdnn/repos","events_url":"https://api.github.com/users/aabdnn/events{/privacy}","received_events_url":"https://api.github.com/users/aabdnn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-06T11:59:43Z","updated_at":"2016-10-13T08:42:19Z","closed_at":null,"body":"I'm testing with zonemaster-engine HEAD. When I try to use an alternative config with a logfilter, I am getting an error:\r\n\r\n```\r\n$ zonemaster-cli bb --raw --ns ns1.barbadosdomain.net --ns ns2.barbadosdomain.net --ns ns.ripe.net --config /etc/zonemaster/predelegation.json \r\nLoading configuration from /etc/zonemaster/predelegation.json.\r\n\r\nNot an ARRAY reference at /opt/zonemaster/lib/perl5/Zonemaster/Logger.pm line 51, <DATA> line 20.\r\n```\r\n\r\nMy config looks like this:\r\n\r\n```\r\n{\r\n   \"asnroots\" : [\r\n      \"asnlookup.zonemaster.net\",\r\n      \"asnlookup.iis.se\",\r\n      \"asn.cymru.com\"\r\n   ],\r\n   \"net\" : {\r\n      \"ipv4\" : 1,\r\n      \"ipv6\" : 1\r\n   },\r\n   \"no_network\" : 0,\r\n   \"resolver\" : {\r\n      \"defaults\" : {\r\n         \"debug\" : 0,\r\n         \"dnssec\" : 0,\r\n         \"edns_size\" : 0,\r\n         \"igntc\" : 0,\r\n         \"recurse\" : 0,\r\n         \"retrans\" : 3,\r\n         \"retry\" : 2,\r\n         \"usevc\" : 0\r\n      }\r\n   },\r\n   \"logfilter\": {\r\n    \"BASIC\": {\r\n        \"NS_FAILED\": {\r\n            \"when\": {\r\n                \"ns\" : \"ns.ripe.net\"\r\n            },\r\n            \"set\" : \"WARNING\"\r\n        }\r\n    },\r\n    \"DELEGATION\": {\r\n        \"SOA_NOT_EXISTS\": {\r\n            \"when\": {\r\n                \"ns\": \"ns.ripe.net\"\r\n            },\r\n            \"set\": \"WARNING\"\r\n        },\r\n        \"EXTRA_NAME_PARENT\": {\r\n            \"when\": {\r\n                \"extra\": \"ns.ripe.net\"\r\n            },\r\n            \"set\": \"WARNING\"\r\n        }\r\n    }\r\n   }\r\n}\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/dotse/zonemaster-engine/issues/comments/253451457","html_url":"https://github.com/dotse/zonemaster-engine/issues/231#issuecomment-253451457","issue_url":"https://api.github.com/repos/dotse/zonemaster-engine/issues/231","id":253451457,"user":{"login":"mtoma","id":5492426,"avatar_url":"https://avatars.githubusercontent.com/u/5492426?v=3","gravatar_id":"","url":"https://api.github.com/users/mtoma","html_url":"https://github.com/mtoma","followers_url":"https://api.github.com/users/mtoma/followers","following_url":"https://api.github.com/users/mtoma/following{/other_user}","gists_url":"https://api.github.com/users/mtoma/gists{/gist_id}","starred_url":"https://api.github.com/users/mtoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtoma/subscriptions","organizations_url":"https://api.github.com/users/mtoma/orgs","repos_url":"https://api.github.com/users/mtoma/repos","events_url":"https://api.github.com/users/mtoma/events{/privacy}","received_events_url":"https://api.github.com/users/mtoma/received_events","type":"User","site_admin":false},"created_at":"2016-10-13T08:42:18Z","updated_at":"2016-10-13T08:42:18Z","body":"Hi Anand, as of now each logfilter rule is expected to be a list of hashes even if this list contains only one hash.\r\n\r\nHere is your config file fixed accordingly:\r\n\r\n```\r\n{\r\n\t\"asnroots\" : [\r\n\t\t\"asnlookup.zonemaster.net\",\r\n\t\t\"asnlookup.iis.se\",\r\n\t\t\"asn.cymru.com\"\r\n\t],\r\n\t\"net\" : {\r\n\t\t\"ipv4\" : 1,\r\n\t\t\"ipv6\" : 1\r\n\t},\r\n\t\"no_network\" : 0,\r\n\t\"resolver\" : {\r\n\t\t\"defaults\" : {\r\n\t\t\t\"debug\" : 0,\r\n\t\t\t\"dnssec\" : 0,\r\n\t\t\t\"edns_size\" : 0,\r\n\t\t\t\"igntc\" : 0,\r\n\t\t\t\"recurse\" : 0,\r\n\t\t\t\"retrans\" : 3,\r\n\t\t\t\"retry\" : 2,\r\n\t\t\t\"usevc\" : 0\r\n\t\t}\r\n\t},\r\n\t\"logfilter\": {\r\n\t\t\"BASIC\": {\r\n\t\t\t\"NS_FAILED\": [\r\n\t\t\t\t{\r\n\t\t\t\t\t\"when\": {\r\n\t\t\t\t\t\t\"ns\" : \"ns.ripe.net\"\r\n\t\t\t\t\t},\r\n\t\t\t\t\t\"set\" : \"WARNING\"\r\n\t\t\t\t}\r\n\t\t\t]\r\n\t\t},\r\n\t\t\"DELEGATION\": {\r\n\t\t\t\"SOA_NOT_EXISTS\": [\r\n\t\t\t\t{\r\n\t\t\t\t\t\"when\": {\r\n\t\t\t\t\t\t\"ns\": \"ns.ripe.net\"\r\n\t\t\t\t\t},\r\n\t\t\t\t\t\"set\": \"WARNING\"\r\n\t\t\t\t}\r\n\t\t\t],\r\n\t\t\t\"EXTRA_NAME_PARENT\": [\r\n\t\t\t\t{\r\n\t\t\t\t\t\"when\": {\r\n\t\t\t\t\t\t\"extra\": \"ns.ripe.net\"\r\n\t\t\t\t\t},\r\n\t\t\t\t\t\"set\": \"WARNING\"\r\n\t\t\t\t}\r\n\t\t\t]\r\n\t\t}\r\n\t}\r\n}\r\n\r\n```"}}
{"actor":{"display_login":"mtoma"}}