{"action":"created","comment":{"url":"https://api.github.com/repos/javaslang/javaslang/pulls/comments/67419040","id":67419040,"diff_hunk":"@@ -147,6 +148,12 @@\n     <K2, V2> SortedMap<K2, V2> map(BiFunction<? super K, ? super V, Tuple2<K2, V2>> mapper);\n \n     @Override\n+    <K2> SortedMap<K2, V> mapKeys(Function<? super K, ? extends K2> keyMapper);\n+\n+    @Override\n+    <K2> SortedMap<K2, V> mapKeys(Function<? super K, ? extends K2> keyMapper, Function2<V, V, V> valueMerge);","path":"javaslang/src/main/java/javaslang/collection/SortedMap.java","position":15,"original_position":15,"commit_id":"8003d687d649e92bc070c958375ef6e1c7593ff8","original_commit_id":"8003d687d649e92bc070c958375ef6e1c7593ff8","user":{"login":"danieldietrich","id":743833,"avatar_url":"https://avatars.githubusercontent.com/u/743833?v=3","gravatar_id":"","url":"https://api.github.com/users/danieldietrich","html_url":"https://github.com/danieldietrich","followers_url":"https://api.github.com/users/danieldietrich/followers","following_url":"https://api.github.com/users/danieldietrich/following{/other_user}","gists_url":"https://api.github.com/users/danieldietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/danieldietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieldietrich/subscriptions","organizations_url":"https://api.github.com/users/danieldietrich/orgs","repos_url":"https://api.github.com/users/danieldietrich/repos","events_url":"https://api.github.com/users/danieldietrich/events{/privacy}","received_events_url":"https://api.github.com/users/danieldietrich/received_events","type":"User","site_admin":false},"body":"Also `BiFunction<? super V, ? super V, ? extends V>` instead of `Function<V, V, V>`","created_at":"2016-06-16T20:34:37Z","updated_at":"2016-06-16T20:34:37Z","html_url":"https://github.com/javaslang/javaslang/pull/1383#discussion_r67419040","pull_request_url":"https://api.github.com/repos/javaslang/javaslang/pulls/1383","_links":{"self":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/comments/67419040"},"html":{"href":"https://github.com/javaslang/javaslang/pull/1383#discussion_r67419040"},"pull_request":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/1383"}}},"pull_request":{"url":"https://api.github.com/repos/javaslang/javaslang/pulls/1383","id":74023077,"html_url":"https://github.com/javaslang/javaslang/pull/1383","diff_url":"https://github.com/javaslang/javaslang/pull/1383.diff","patch_url":"https://github.com/javaslang/javaslang/pull/1383.patch","issue_url":"https://api.github.com/repos/javaslang/javaslang/issues/1383","number":1383,"state":"open","locked":false,"title":"Implement new method: Map#mapKeys()","user":{"login":"valery1707","id":83507,"avatar_url":"https://avatars.githubusercontent.com/u/83507?v=3","gravatar_id":"","url":"https://api.github.com/users/valery1707","html_url":"https://github.com/valery1707","followers_url":"https://api.github.com/users/valery1707/followers","following_url":"https://api.github.com/users/valery1707/following{/other_user}","gists_url":"https://api.github.com/users/valery1707/gists{/gist_id}","starred_url":"https://api.github.com/users/valery1707/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valery1707/subscriptions","organizations_url":"https://api.github.com/users/valery1707/orgs","repos_url":"https://api.github.com/users/valery1707/repos","events_url":"https://api.github.com/users/valery1707/events{/privacy}","received_events_url":"https://api.github.com/users/valery1707/received_events","type":"User","site_admin":false},"body":"fix #1379.\r\n\r\n@danieldietrich, I don't known how to remove hack from `TreeMap#mapKeys(Function<? super K,? extends K2>, Function2<V,V,V>)`.\r\nIf I describe `K2` in `TreeMap` as `K2 extends Comparable<? super K2>` then I must describe it with same limit in `SortedMap` (it's ok) and `Map` (this is not ok).\r\n","created_at":"2016-06-16T05:11:21Z","updated_at":"2016-06-16T20:34:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5fb9b72e82a4d2c03cc03541ee953f49ac09035f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/javaslang/javaslang/pulls/1383/commits","review_comments_url":"https://api.github.com/repos/javaslang/javaslang/pulls/1383/comments","review_comment_url":"https://api.github.com/repos/javaslang/javaslang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/javaslang/javaslang/issues/1383/comments","statuses_url":"https://api.github.com/repos/javaslang/javaslang/statuses/8003d687d649e92bc070c958375ef6e1c7593ff8","head":{"label":"valery1707:map_mapKeys","ref":"map_mapKeys","sha":"8003d687d649e92bc070c958375ef6e1c7593ff8","user":{"login":"valery1707","id":83507,"avatar_url":"https://avatars.githubusercontent.com/u/83507?v=3","gravatar_id":"","url":"https://api.github.com/users/valery1707","html_url":"https://github.com/valery1707","followers_url":"https://api.github.com/users/valery1707/followers","following_url":"https://api.github.com/users/valery1707/following{/other_user}","gists_url":"https://api.github.com/users/valery1707/gists{/gist_id}","starred_url":"https://api.github.com/users/valery1707/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valery1707/subscriptions","organizations_url":"https://api.github.com/users/valery1707/orgs","repos_url":"https://api.github.com/users/valery1707/repos","events_url":"https://api.github.com/users/valery1707/events{/privacy}","received_events_url":"https://api.github.com/users/valery1707/received_events","type":"User","site_admin":false},"repo":{"id":60245353,"name":"javaslang","full_name":"valery1707/javaslang","owner":{"login":"valery1707","id":83507,"avatar_url":"https://avatars.githubusercontent.com/u/83507?v=3","gravatar_id":"","url":"https://api.github.com/users/valery1707","html_url":"https://github.com/valery1707","followers_url":"https://api.github.com/users/valery1707/followers","following_url":"https://api.github.com/users/valery1707/following{/other_user}","gists_url":"https://api.github.com/users/valery1707/gists{/gist_id}","starred_url":"https://api.github.com/users/valery1707/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valery1707/subscriptions","organizations_url":"https://api.github.com/users/valery1707/orgs","repos_url":"https://api.github.com/users/valery1707/repos","events_url":"https://api.github.com/users/valery1707/events{/privacy}","received_events_url":"https://api.github.com/users/valery1707/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/valery1707/javaslang","description":"A functional library for Java 8+ that provides persistent data types and functional control structures.","fork":true,"url":"https://api.github.com/repos/valery1707/javaslang","forks_url":"https://api.github.com/repos/valery1707/javaslang/forks","keys_url":"https://api.github.com/repos/valery1707/javaslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/valery1707/javaslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/valery1707/javaslang/teams","hooks_url":"https://api.github.com/repos/valery1707/javaslang/hooks","issue_events_url":"https://api.github.com/repos/valery1707/javaslang/issues/events{/number}","events_url":"https://api.github.com/repos/valery1707/javaslang/events","assignees_url":"https://api.github.com/repos/valery1707/javaslang/assignees{/user}","branches_url":"https://api.github.com/repos/valery1707/javaslang/branches{/branch}","tags_url":"https://api.github.com/repos/valery1707/javaslang/tags","blobs_url":"https://api.github.com/repos/valery1707/javaslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/valery1707/javaslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/valery1707/javaslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/valery1707/javaslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/valery1707/javaslang/statuses/{sha}","languages_url":"https://api.github.com/repos/valery1707/javaslang/languages","stargazers_url":"https://api.github.com/repos/valery1707/javaslang/stargazers","contributors_url":"https://api.github.com/repos/valery1707/javaslang/contributors","subscribers_url":"https://api.github.com/repos/valery1707/javaslang/subscribers","subscription_url":"https://api.github.com/repos/valery1707/javaslang/subscription","commits_url":"https://api.github.com/repos/valery1707/javaslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/valery1707/javaslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/valery1707/javaslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/valery1707/javaslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/valery1707/javaslang/contents/{+path}","compare_url":"https://api.github.com/repos/valery1707/javaslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/valery1707/javaslang/merges","archive_url":"https://api.github.com/repos/valery1707/javaslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/valery1707/javaslang/downloads","issues_url":"https://api.github.com/repos/valery1707/javaslang/issues{/number}","pulls_url":"https://api.github.com/repos/valery1707/javaslang/pulls{/number}","milestones_url":"https://api.github.com/repos/valery1707/javaslang/milestones{/number}","notifications_url":"https://api.github.com/repos/valery1707/javaslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/valery1707/javaslang/labels{/name}","releases_url":"https://api.github.com/repos/valery1707/javaslang/releases{/id}","deployments_url":"https://api.github.com/repos/valery1707/javaslang/deployments","created_at":"2016-06-02T08:14:52Z","updated_at":"2016-06-02T08:14:54Z","pushed_at":"2016-06-16T12:38:25Z","git_url":"git://github.com/valery1707/javaslang.git","ssh_url":"git@github.com:valery1707/javaslang.git","clone_url":"https://github.com/valery1707/javaslang.git","svn_url":"https://github.com/valery1707/javaslang","homepage":"http://javaslang.io","size":11520,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"javaslang:master","ref":"master","sha":"c47d5c57e01015ccc686f824eac7dd92f17563c3","user":{"login":"javaslang","id":5786132,"avatar_url":"https://avatars.githubusercontent.com/u/5786132?v=3","gravatar_id":"","url":"https://api.github.com/users/javaslang","html_url":"https://github.com/javaslang","followers_url":"https://api.github.com/users/javaslang/followers","following_url":"https://api.github.com/users/javaslang/following{/other_user}","gists_url":"https://api.github.com/users/javaslang/gists{/gist_id}","starred_url":"https://api.github.com/users/javaslang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javaslang/subscriptions","organizations_url":"https://api.github.com/users/javaslang/orgs","repos_url":"https://api.github.com/users/javaslang/repos","events_url":"https://api.github.com/users/javaslang/events{/privacy}","received_events_url":"https://api.github.com/users/javaslang/received_events","type":"Organization","site_admin":false},"repo":{"id":16378879,"name":"javaslang","full_name":"javaslang/javaslang","owner":{"login":"javaslang","id":5786132,"avatar_url":"https://avatars.githubusercontent.com/u/5786132?v=3","gravatar_id":"","url":"https://api.github.com/users/javaslang","html_url":"https://github.com/javaslang","followers_url":"https://api.github.com/users/javaslang/followers","following_url":"https://api.github.com/users/javaslang/following{/other_user}","gists_url":"https://api.github.com/users/javaslang/gists{/gist_id}","starred_url":"https://api.github.com/users/javaslang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javaslang/subscriptions","organizations_url":"https://api.github.com/users/javaslang/orgs","repos_url":"https://api.github.com/users/javaslang/repos","events_url":"https://api.github.com/users/javaslang/events{/privacy}","received_events_url":"https://api.github.com/users/javaslang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/javaslang/javaslang","description":"A functional library for Java 8+ that provides persistent data types and functional control structures.","fork":false,"url":"https://api.github.com/repos/javaslang/javaslang","forks_url":"https://api.github.com/repos/javaslang/javaslang/forks","keys_url":"https://api.github.com/repos/javaslang/javaslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javaslang/javaslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javaslang/javaslang/teams","hooks_url":"https://api.github.com/repos/javaslang/javaslang/hooks","issue_events_url":"https://api.github.com/repos/javaslang/javaslang/issues/events{/number}","events_url":"https://api.github.com/repos/javaslang/javaslang/events","assignees_url":"https://api.github.com/repos/javaslang/javaslang/assignees{/user}","branches_url":"https://api.github.com/repos/javaslang/javaslang/branches{/branch}","tags_url":"https://api.github.com/repos/javaslang/javaslang/tags","blobs_url":"https://api.github.com/repos/javaslang/javaslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javaslang/javaslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javaslang/javaslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/javaslang/javaslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javaslang/javaslang/statuses/{sha}","languages_url":"https://api.github.com/repos/javaslang/javaslang/languages","stargazers_url":"https://api.github.com/repos/javaslang/javaslang/stargazers","contributors_url":"https://api.github.com/repos/javaslang/javaslang/contributors","subscribers_url":"https://api.github.com/repos/javaslang/javaslang/subscribers","subscription_url":"https://api.github.com/repos/javaslang/javaslang/subscription","commits_url":"https://api.github.com/repos/javaslang/javaslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/javaslang/javaslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/javaslang/javaslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/javaslang/javaslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/javaslang/javaslang/contents/{+path}","compare_url":"https://api.github.com/repos/javaslang/javaslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javaslang/javaslang/merges","archive_url":"https://api.github.com/repos/javaslang/javaslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javaslang/javaslang/downloads","issues_url":"https://api.github.com/repos/javaslang/javaslang/issues{/number}","pulls_url":"https://api.github.com/repos/javaslang/javaslang/pulls{/number}","milestones_url":"https://api.github.com/repos/javaslang/javaslang/milestones{/number}","notifications_url":"https://api.github.com/repos/javaslang/javaslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javaslang/javaslang/labels{/name}","releases_url":"https://api.github.com/repos/javaslang/javaslang/releases{/id}","deployments_url":"https://api.github.com/repos/javaslang/javaslang/deployments","created_at":"2014-01-30T14:07:25Z","updated_at":"2016-06-16T14:39:46Z","pushed_at":"2016-06-16T12:38:25Z","git_url":"git://github.com/javaslang/javaslang.git","ssh_url":"git@github.com:javaslang/javaslang.git","clone_url":"https://github.com/javaslang/javaslang.git","svn_url":"https://github.com/javaslang/javaslang","homepage":"http://javaslang.io","size":11503,"stargazers_count":942,"watchers_count":942,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"open_issues_count":100,"forks":111,"open_issues":100,"watchers":942,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/1383"},"html":{"href":"https://github.com/javaslang/javaslang/pull/1383"},"issue":{"href":"https://api.github.com/repos/javaslang/javaslang/issues/1383"},"comments":{"href":"https://api.github.com/repos/javaslang/javaslang/issues/1383/comments"},"review_comments":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/1383/comments"},"review_comment":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/1383/commits"},"statuses":{"href":"https://api.github.com/repos/javaslang/javaslang/statuses/8003d687d649e92bc070c958375ef6e1c7593ff8"}}}}
{"actor":{"display_login":"danieldietrich"}}