{"action":"created","comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/86556507","pull_request_review_id":7210693,"id":86556507,"diff_hunk":"@@ -182,17 +183,25 @@\n     }\n \n     Cesium.when(Cesium.sampleTerrain(viewer.terrainProvider, 9, terrainSamplePositions), sampleTerrainSuccess);\n+\n+    var target = new Cesium.Cartesian3(300770.50872389384, 5634912.131394585, 2978152.2865545116);","path":"Apps/Sandcastle/gallery/Terrain.html","position":null,"original_position":42,"commit_id":"3a62aaae98970ea980bbafe05a32da6d634add07","original_commit_id":"4c021aa39dc43218a4e430fd0e346bb8e2b3ec06","user":{"login":"abhishekvp","id":2259697,"avatar_url":"https://avatars.githubusercontent.com/u/2259697?v=3","gravatar_id":"","url":"https://api.github.com/users/abhishekvp","html_url":"https://github.com/abhishekvp","followers_url":"https://api.github.com/users/abhishekvp/followers","following_url":"https://api.github.com/users/abhishekvp/following{/other_user}","gists_url":"https://api.github.com/users/abhishekvp/gists{/gist_id}","starred_url":"https://api.github.com/users/abhishekvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhishekvp/subscriptions","organizations_url":"https://api.github.com/users/abhishekvp/orgs","repos_url":"https://api.github.com/users/abhishekvp/repos","events_url":"https://api.github.com/users/abhishekvp/events{/privacy}","received_events_url":"https://api.github.com/users/abhishekvp/received_events","type":"User","site_admin":false},"body":"@hpinkos Thanks for the review. I have made the suggested changes. I have added the function - `lookAtMtEverest()`.","created_at":"2016-11-04T14:31:34Z","updated_at":"2016-11-04T14:31:34Z","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4596#discussion_r86556507","pull_request_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4596","_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/86556507"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4596#discussion_r86556507"},"pull_request":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4596"}}},"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4596","id":92202006,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4596","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4596.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4596.patch","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4596","number":4596,"state":"open","locked":false,"title":"Changed Toggle to Enable Lighting in Sandcastle Terrain Example","user":{"login":"abhishekvp","id":2259697,"avatar_url":"https://avatars.githubusercontent.com/u/2259697?v=3","gravatar_id":"","url":"https://api.github.com/users/abhishekvp","html_url":"https://github.com/abhishekvp","followers_url":"https://api.github.com/users/abhishekvp/followers","following_url":"https://api.github.com/users/abhishekvp/following{/other_user}","gists_url":"https://api.github.com/users/abhishekvp/gists{/gist_id}","starred_url":"https://api.github.com/users/abhishekvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhishekvp/subscriptions","organizations_url":"https://api.github.com/users/abhishekvp/orgs","repos_url":"https://api.github.com/users/abhishekvp/repos","events_url":"https://api.github.com/users/abhishekvp/events{/privacy}","received_events_url":"https://api.github.com/users/abhishekvp/received_events","type":"User","site_admin":false},"body":"#4575\r\n\r\nThanks @erikmaarten  for the review. I checked the [documentation](http://cesiumjs.org/Cesium/Build/Documentation/Globe.html#enableLighting) of enableLighting. It says that the if true, the light source should be the sun. So the code works correctly, when a user checks the Enable Lighting checkbox, the light source becomes the sun and the globe illuminates accordingly. Please correct me if I understood this wrong.","created_at":"2016-11-03T17:27:35Z","updated_at":"2016-11-04T14:31:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"124ba858174657906149ba3c0db450c1d8cbbcee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4596/commits","review_comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4596/comments","review_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4596/comments","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/3a62aaae98970ea980bbafe05a32da6d634add07","head":{"label":"abhishekvp:issue-4575","ref":"issue-4575","sha":"3a62aaae98970ea980bbafe05a32da6d634add07","user":{"login":"abhishekvp","id":2259697,"avatar_url":"https://avatars.githubusercontent.com/u/2259697?v=3","gravatar_id":"","url":"https://api.github.com/users/abhishekvp","html_url":"https://github.com/abhishekvp","followers_url":"https://api.github.com/users/abhishekvp/followers","following_url":"https://api.github.com/users/abhishekvp/following{/other_user}","gists_url":"https://api.github.com/users/abhishekvp/gists{/gist_id}","starred_url":"https://api.github.com/users/abhishekvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhishekvp/subscriptions","organizations_url":"https://api.github.com/users/abhishekvp/orgs","repos_url":"https://api.github.com/users/abhishekvp/repos","events_url":"https://api.github.com/users/abhishekvp/events{/privacy}","received_events_url":"https://api.github.com/users/abhishekvp/received_events","type":"User","site_admin":false},"repo":{"id":72760207,"name":"cesium","full_name":"abhishekvp/cesium","owner":{"login":"abhishekvp","id":2259697,"avatar_url":"https://avatars.githubusercontent.com/u/2259697?v=3","gravatar_id":"","url":"https://api.github.com/users/abhishekvp","html_url":"https://github.com/abhishekvp","followers_url":"https://api.github.com/users/abhishekvp/followers","following_url":"https://api.github.com/users/abhishekvp/following{/other_user}","gists_url":"https://api.github.com/users/abhishekvp/gists{/gist_id}","starred_url":"https://api.github.com/users/abhishekvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhishekvp/subscriptions","organizations_url":"https://api.github.com/users/abhishekvp/orgs","repos_url":"https://api.github.com/users/abhishekvp/repos","events_url":"https://api.github.com/users/abhishekvp/events{/privacy}","received_events_url":"https://api.github.com/users/abhishekvp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abhishekvp/cesium","description":"An open-source JavaScript library for world-class 3D globes and maps :earth_americas:","fork":true,"url":"https://api.github.com/repos/abhishekvp/cesium","forks_url":"https://api.github.com/repos/abhishekvp/cesium/forks","keys_url":"https://api.github.com/repos/abhishekvp/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abhishekvp/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abhishekvp/cesium/teams","hooks_url":"https://api.github.com/repos/abhishekvp/cesium/hooks","issue_events_url":"https://api.github.com/repos/abhishekvp/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/abhishekvp/cesium/events","assignees_url":"https://api.github.com/repos/abhishekvp/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/abhishekvp/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/abhishekvp/cesium/tags","blobs_url":"https://api.github.com/repos/abhishekvp/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abhishekvp/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abhishekvp/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/abhishekvp/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abhishekvp/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/abhishekvp/cesium/languages","stargazers_url":"https://api.github.com/repos/abhishekvp/cesium/stargazers","contributors_url":"https://api.github.com/repos/abhishekvp/cesium/contributors","subscribers_url":"https://api.github.com/repos/abhishekvp/cesium/subscribers","subscription_url":"https://api.github.com/repos/abhishekvp/cesium/subscription","commits_url":"https://api.github.com/repos/abhishekvp/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/abhishekvp/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/abhishekvp/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/abhishekvp/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/abhishekvp/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/abhishekvp/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abhishekvp/cesium/merges","archive_url":"https://api.github.com/repos/abhishekvp/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abhishekvp/cesium/downloads","issues_url":"https://api.github.com/repos/abhishekvp/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/abhishekvp/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/abhishekvp/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/abhishekvp/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abhishekvp/cesium/labels{/name}","releases_url":"https://api.github.com/repos/abhishekvp/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/abhishekvp/cesium/deployments","created_at":"2016-11-03T15:37:08Z","updated_at":"2016-11-03T15:37:23Z","pushed_at":"2016-11-04T14:28:33Z","git_url":"git://github.com/abhishekvp/cesium.git","ssh_url":"git@github.com:abhishekvp/cesium.git","clone_url":"https://github.com/abhishekvp/cesium.git","svn_url":"https://github.com/abhishekvp/cesium","homepage":"http://cesiumjs.org/","size":255385,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AnalyticalGraphicsInc:master","ref":"master","sha":"d695d49a931d27c70d55379e93ab8e6864090137","user":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"repo":{"id":3606738,"name":"cesium","full_name":"AnalyticalGraphicsInc/cesium","owner":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium","description":"An open-source JavaScript library for world-class 3D globes and maps :earth_americas:","fork":false,"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium","forks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/forks","keys_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/teams","hooks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/hooks","issue_events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/events","assignees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/tags","blobs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/languages","stargazers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/stargazers","contributors_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contributors","subscribers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscribers","subscription_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscription","commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/merges","archive_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/downloads","issues_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/labels{/name}","releases_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/deployments","created_at":"2012-03-02T22:27:14Z","updated_at":"2016-11-04T00:57:40Z","pushed_at":"2016-11-04T14:28:34Z","git_url":"git://github.com/AnalyticalGraphicsInc/cesium.git","ssh_url":"git@github.com:AnalyticalGraphicsInc/cesium.git","clone_url":"https://github.com/AnalyticalGraphicsInc/cesium.git","svn_url":"https://github.com/AnalyticalGraphicsInc/cesium","homepage":"http://cesiumjs.org/","size":411899,"stargazers_count":1785,"watchers_count":1785,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":862,"mirror_url":null,"open_issues_count":492,"forks":862,"open_issues":492,"watchers":1785,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4596"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4596"},"issue":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4596"},"comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4596/comments"},"review_comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4596/comments"},"review_comment":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4596/commits"},"statuses":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/3a62aaae98970ea980bbafe05a32da6d634add07"}}}}
{"actor":{"display_login":"abhishekvp"}}