{"action":"created","issue":{"url":"https://api.github.com/repos/artsy/force/issues/306","repository_url":"https://api.github.com/repos/artsy/force","labels_url":"https://api.github.com/repos/artsy/force/issues/306/labels{/name}","comments_url":"https://api.github.com/repos/artsy/force/issues/306/comments","events_url":"https://api.github.com/repos/artsy/force/issues/306/events","html_url":"https://github.com/artsy/force/pull/306","id":184231347,"number":306,"title":"@sweir27 account for longer titles in auction reminder","user":{"login":"erikdstock","id":9088720,"avatar_url":"https://avatars.githubusercontent.com/u/9088720?v=3","gravatar_id":"","url":"https://api.github.com/users/erikdstock","html_url":"https://github.com/erikdstock","followers_url":"https://api.github.com/users/erikdstock/followers","following_url":"https://api.github.com/users/erikdstock/following{/other_user}","gists_url":"https://api.github.com/users/erikdstock/gists{/gist_id}","starred_url":"https://api.github.com/users/erikdstock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikdstock/subscriptions","organizations_url":"https://api.github.com/users/erikdstock/orgs","repos_url":"https://api.github.com/users/erikdstock/repos","events_url":"https://api.github.com/users/erikdstock/events{/privacy}","received_events_url":"https://api.github.com/users/erikdstock/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"acjay","id":1256382,"avatar_url":"https://avatars.githubusercontent.com/u/1256382?v=3","gravatar_id":"","url":"https://api.github.com/users/acjay","html_url":"https://github.com/acjay","followers_url":"https://api.github.com/users/acjay/followers","following_url":"https://api.github.com/users/acjay/following{/other_user}","gists_url":"https://api.github.com/users/acjay/gists{/gist_id}","starred_url":"https://api.github.com/users/acjay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acjay/subscriptions","organizations_url":"https://api.github.com/users/acjay/orgs","repos_url":"https://api.github.com/users/acjay/repos","events_url":"https://api.github.com/users/acjay/events{/privacy}","received_events_url":"https://api.github.com/users/acjay/received_events","type":"User","site_admin":false},"assignees":[{"login":"acjay","id":1256382,"avatar_url":"https://avatars.githubusercontent.com/u/1256382?v=3","gravatar_id":"","url":"https://api.github.com/users/acjay","html_url":"https://github.com/acjay","followers_url":"https://api.github.com/users/acjay/followers","following_url":"https://api.github.com/users/acjay/following{/other_user}","gists_url":"https://api.github.com/users/acjay/gists{/gist_id}","starred_url":"https://api.github.com/users/acjay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acjay/subscriptions","organizations_url":"https://api.github.com/users/acjay/orgs","repos_url":"https://api.github.com/users/acjay/repos","events_url":"https://api.github.com/users/acjay/events{/privacy}","received_events_url":"https://api.github.com/users/acjay/received_events","type":"User","site_admin":false},{"login":"sweir27","id":2081340,"avatar_url":"https://avatars.githubusercontent.com/u/2081340?v=3","gravatar_id":"","url":"https://api.github.com/users/sweir27","html_url":"https://github.com/sweir27","followers_url":"https://api.github.com/users/sweir27/followers","following_url":"https://api.github.com/users/sweir27/following{/other_user}","gists_url":"https://api.github.com/users/sweir27/gists{/gist_id}","starred_url":"https://api.github.com/users/sweir27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sweir27/subscriptions","organizations_url":"https://api.github.com/users/sweir27/orgs","repos_url":"https://api.github.com/users/sweir27/repos","events_url":"https://api.github.com/users/sweir27/events{/privacy}","received_events_url":"https://api.github.com/users/sweir27/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-10-20T13:35:42Z","updated_at":"2016-10-20T19:03:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/artsy/force/pulls/306","html_url":"https://github.com/artsy/force/pull/306","diff_url":"https://github.com/artsy/force/pull/306.diff","patch_url":"https://github.com/artsy/force/pull/306.patch"},"body":"references https://github.com/artsy/auctions/issues/146\r\n\r\nI made the change discussed in the ticket but I'm not sure if there should be more to it: basically, text that wraps to a third line will start to cause the `a.auction-reminder` to expand already- it seems like it would look better if this only happened when absolutely necessary. I don't think there is a simple way to know for sure how many lines a text will take up, but assuming the words have spaces and we aren't hyphenating it looks like a max of around 35 characters- i thought about adding a class in this case and only setting min-height for that (basically aiming to remove the height restriction only if the text is going to go to a 4th line), but maybe i'm overthinking it.\r\n\r\nWith min-height: 120px\r\n![image](https://cloud.githubusercontent.com/assets/9088720/19561576/3935fda4-96a7-11e6-8c37-fed8278ff8cc.png)\r\n\r\n\r\nBefore change (height: 120px)\r\n![image](https://cloud.githubusercontent.com/assets/9088720/19561696/b6bccb7c-96a7-11e6-805e-20bf79a7fcb7.png)\r\n"},"comment":{"url":"https://api.github.com/repos/artsy/force/issues/comments/255198019","html_url":"https://github.com/artsy/force/pull/306#issuecomment-255198019","issue_url":"https://api.github.com/repos/artsy/force/issues/306","id":255198019,"user":{"login":"erikdstock","id":9088720,"avatar_url":"https://avatars.githubusercontent.com/u/9088720?v=3","gravatar_id":"","url":"https://api.github.com/users/erikdstock","html_url":"https://github.com/erikdstock","followers_url":"https://api.github.com/users/erikdstock/followers","following_url":"https://api.github.com/users/erikdstock/following{/other_user}","gists_url":"https://api.github.com/users/erikdstock/gists{/gist_id}","starred_url":"https://api.github.com/users/erikdstock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikdstock/subscriptions","organizations_url":"https://api.github.com/users/erikdstock/orgs","repos_url":"https://api.github.com/users/erikdstock/repos","events_url":"https://api.github.com/users/erikdstock/events{/privacy}","received_events_url":"https://api.github.com/users/erikdstock/received_events","type":"User","site_admin":false},"created_at":"2016-10-20T19:03:21Z","updated_at":"2016-10-20T19:03:21Z","body":"@acjay in the interest of fixing the formatting bug maybe @devangt suggested maybe this should go out and I can do the rest seaparately"}}
{"actor":{"display_login":"erikdstock"}}