{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/markstos/HTML-FillInForm/pulls/10","id":70678799,"html_url":"https://github.com/markstos/HTML-FillInForm/pull/10","diff_url":"https://github.com/markstos/HTML-FillInForm/pull/10.diff","patch_url":"https://github.com/markstos/HTML-FillInForm/pull/10.patch","issue_url":"https://api.github.com/repos/markstos/HTML-FillInForm/issues/10","number":10,"state":"closed","locked":false,"title":"Don't call _get_param(undef) for <select> box without name attribute","user":{"login":"cventers","id":391669,"avatar_url":"https://avatars.githubusercontent.com/u/391669?v=3","gravatar_id":"","url":"https://api.github.com/users/cventers","html_url":"https://github.com/cventers","followers_url":"https://api.github.com/users/cventers/followers","following_url":"https://api.github.com/users/cventers/following{/other_user}","gists_url":"https://api.github.com/users/cventers/gists{/gist_id}","starred_url":"https://api.github.com/users/cventers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cventers/subscriptions","organizations_url":"https://api.github.com/users/cventers/orgs","repos_url":"https://api.github.com/users/cventers/repos","events_url":"https://api.github.com/users/cventers/events{/privacy}","received_events_url":"https://api.github.com/users/cventers/received_events","type":"User","site_admin":false},"body":"Modern forms sometimes contain <select> boxes with no name, since their\r\nvalue is not intended to be submitted with the form (but rather used by\r\nJavascript via the <select> DOM ID).\r\n\r\nIf HTML::FillInForm encounters such a <select> box, selectName will be\r\nundefined when handling the <option> tag and the current code will try\r\nto call $self->_get_param(undef).\r\n\r\nIf $self->_get_param(undef) is called with an fobject tied to a\r\nCatalyst::Request, it will carp a warning about asking for an undefined\r\nparameter.\r\n\r\nThis patch fixes the issue.\r\n\r\nSigned-off-by: Chase Venters <chase.venters@chaseventers.com>","created_at":"2016-05-19T11:35:43Z","updated_at":"2016-05-19T14:09:47Z","closed_at":"2016-05-19T14:09:46Z","merged_at":"2016-05-19T14:09:46Z","merge_commit_sha":"eddf1f937215b44edb4a1f94c5486f1ae118e633","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/markstos/HTML-FillInForm/pulls/10/commits","review_comments_url":"https://api.github.com/repos/markstos/HTML-FillInForm/pulls/10/comments","review_comment_url":"https://api.github.com/repos/markstos/HTML-FillInForm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/markstos/HTML-FillInForm/issues/10/comments","statuses_url":"https://api.github.com/repos/markstos/HTML-FillInForm/statuses/d73e80418347967d45a15e8625b10afbd473cef6","head":{"label":"cventers:selectName","ref":"selectName","sha":"d73e80418347967d45a15e8625b10afbd473cef6","user":{"login":"cventers","id":391669,"avatar_url":"https://avatars.githubusercontent.com/u/391669?v=3","gravatar_id":"","url":"https://api.github.com/users/cventers","html_url":"https://github.com/cventers","followers_url":"https://api.github.com/users/cventers/followers","following_url":"https://api.github.com/users/cventers/following{/other_user}","gists_url":"https://api.github.com/users/cventers/gists{/gist_id}","starred_url":"https://api.github.com/users/cventers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cventers/subscriptions","organizations_url":"https://api.github.com/users/cventers/orgs","repos_url":"https://api.github.com/users/cventers/repos","events_url":"https://api.github.com/users/cventers/events{/privacy}","received_events_url":"https://api.github.com/users/cventers/received_events","type":"User","site_admin":false},"repo":{"id":59200320,"name":"HTML-FillInForm","full_name":"cventers/HTML-FillInForm","owner":{"login":"cventers","id":391669,"avatar_url":"https://avatars.githubusercontent.com/u/391669?v=3","gravatar_id":"","url":"https://api.github.com/users/cventers","html_url":"https://github.com/cventers","followers_url":"https://api.github.com/users/cventers/followers","following_url":"https://api.github.com/users/cventers/following{/other_user}","gists_url":"https://api.github.com/users/cventers/gists{/gist_id}","starred_url":"https://api.github.com/users/cventers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cventers/subscriptions","organizations_url":"https://api.github.com/users/cventers/orgs","repos_url":"https://api.github.com/users/cventers/repos","events_url":"https://api.github.com/users/cventers/events{/privacy}","received_events_url":"https://api.github.com/users/cventers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cventers/HTML-FillInForm","description":"Perl 5 HTML::FillInForm module, helps fill in HTML  forms from a data structure","fork":true,"url":"https://api.github.com/repos/cventers/HTML-FillInForm","forks_url":"https://api.github.com/repos/cventers/HTML-FillInForm/forks","keys_url":"https://api.github.com/repos/cventers/HTML-FillInForm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cventers/HTML-FillInForm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cventers/HTML-FillInForm/teams","hooks_url":"https://api.github.com/repos/cventers/HTML-FillInForm/hooks","issue_events_url":"https://api.github.com/repos/cventers/HTML-FillInForm/issues/events{/number}","events_url":"https://api.github.com/repos/cventers/HTML-FillInForm/events","assignees_url":"https://api.github.com/repos/cventers/HTML-FillInForm/assignees{/user}","branches_url":"https://api.github.com/repos/cventers/HTML-FillInForm/branches{/branch}","tags_url":"https://api.github.com/repos/cventers/HTML-FillInForm/tags","blobs_url":"https://api.github.com/repos/cventers/HTML-FillInForm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cventers/HTML-FillInForm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cventers/HTML-FillInForm/git/refs{/sha}","trees_url":"https://api.github.com/repos/cventers/HTML-FillInForm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cventers/HTML-FillInForm/statuses/{sha}","languages_url":"https://api.github.com/repos/cventers/HTML-FillInForm/languages","stargazers_url":"https://api.github.com/repos/cventers/HTML-FillInForm/stargazers","contributors_url":"https://api.github.com/repos/cventers/HTML-FillInForm/contributors","subscribers_url":"https://api.github.com/repos/cventers/HTML-FillInForm/subscribers","subscription_url":"https://api.github.com/repos/cventers/HTML-FillInForm/subscription","commits_url":"https://api.github.com/repos/cventers/HTML-FillInForm/commits{/sha}","git_commits_url":"https://api.github.com/repos/cventers/HTML-FillInForm/git/commits{/sha}","comments_url":"https://api.github.com/repos/cventers/HTML-FillInForm/comments{/number}","issue_comment_url":"https://api.github.com/repos/cventers/HTML-FillInForm/issues/comments{/number}","contents_url":"https://api.github.com/repos/cventers/HTML-FillInForm/contents/{+path}","compare_url":"https://api.github.com/repos/cventers/HTML-FillInForm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cventers/HTML-FillInForm/merges","archive_url":"https://api.github.com/repos/cventers/HTML-FillInForm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cventers/HTML-FillInForm/downloads","issues_url":"https://api.github.com/repos/cventers/HTML-FillInForm/issues{/number}","pulls_url":"https://api.github.com/repos/cventers/HTML-FillInForm/pulls{/number}","milestones_url":"https://api.github.com/repos/cventers/HTML-FillInForm/milestones{/number}","notifications_url":"https://api.github.com/repos/cventers/HTML-FillInForm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cventers/HTML-FillInForm/labels{/name}","releases_url":"https://api.github.com/repos/cventers/HTML-FillInForm/releases{/id}","deployments_url":"https://api.github.com/repos/cventers/HTML-FillInForm/deployments","created_at":"2016-05-19T11:30:14Z","updated_at":"2016-05-19T11:30:15Z","pushed_at":"2016-05-19T11:35:32Z","git_url":"git://github.com/cventers/HTML-FillInForm.git","ssh_url":"git@github.com:cventers/HTML-FillInForm.git","clone_url":"https://github.com/cventers/HTML-FillInForm.git","svn_url":"https://github.com/cventers/HTML-FillInForm","homepage":null,"size":34,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"markstos:master","ref":"master","sha":"f5760e929ea4e653b7b50f764176880b7790b5ec","user":{"login":"markstos","id":25829,"avatar_url":"https://avatars.githubusercontent.com/u/25829?v=3","gravatar_id":"","url":"https://api.github.com/users/markstos","html_url":"https://github.com/markstos","followers_url":"https://api.github.com/users/markstos/followers","following_url":"https://api.github.com/users/markstos/following{/other_user}","gists_url":"https://api.github.com/users/markstos/gists{/gist_id}","starred_url":"https://api.github.com/users/markstos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstos/subscriptions","organizations_url":"https://api.github.com/users/markstos/orgs","repos_url":"https://api.github.com/users/markstos/repos","events_url":"https://api.github.com/users/markstos/events{/privacy}","received_events_url":"https://api.github.com/users/markstos/received_events","type":"User","site_admin":false},"repo":{"id":10458036,"name":"HTML-FillInForm","full_name":"markstos/HTML-FillInForm","owner":{"login":"markstos","id":25829,"avatar_url":"https://avatars.githubusercontent.com/u/25829?v=3","gravatar_id":"","url":"https://api.github.com/users/markstos","html_url":"https://github.com/markstos","followers_url":"https://api.github.com/users/markstos/followers","following_url":"https://api.github.com/users/markstos/following{/other_user}","gists_url":"https://api.github.com/users/markstos/gists{/gist_id}","starred_url":"https://api.github.com/users/markstos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstos/subscriptions","organizations_url":"https://api.github.com/users/markstos/orgs","repos_url":"https://api.github.com/users/markstos/repos","events_url":"https://api.github.com/users/markstos/events{/privacy}","received_events_url":"https://api.github.com/users/markstos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markstos/HTML-FillInForm","description":"Perl 5 HTML::FillInForm module, helps fill in HTML  forms from a data structure","fork":false,"url":"https://api.github.com/repos/markstos/HTML-FillInForm","forks_url":"https://api.github.com/repos/markstos/HTML-FillInForm/forks","keys_url":"https://api.github.com/repos/markstos/HTML-FillInForm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markstos/HTML-FillInForm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markstos/HTML-FillInForm/teams","hooks_url":"https://api.github.com/repos/markstos/HTML-FillInForm/hooks","issue_events_url":"https://api.github.com/repos/markstos/HTML-FillInForm/issues/events{/number}","events_url":"https://api.github.com/repos/markstos/HTML-FillInForm/events","assignees_url":"https://api.github.com/repos/markstos/HTML-FillInForm/assignees{/user}","branches_url":"https://api.github.com/repos/markstos/HTML-FillInForm/branches{/branch}","tags_url":"https://api.github.com/repos/markstos/HTML-FillInForm/tags","blobs_url":"https://api.github.com/repos/markstos/HTML-FillInForm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markstos/HTML-FillInForm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markstos/HTML-FillInForm/git/refs{/sha}","trees_url":"https://api.github.com/repos/markstos/HTML-FillInForm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markstos/HTML-FillInForm/statuses/{sha}","languages_url":"https://api.github.com/repos/markstos/HTML-FillInForm/languages","stargazers_url":"https://api.github.com/repos/markstos/HTML-FillInForm/stargazers","contributors_url":"https://api.github.com/repos/markstos/HTML-FillInForm/contributors","subscribers_url":"https://api.github.com/repos/markstos/HTML-FillInForm/subscribers","subscription_url":"https://api.github.com/repos/markstos/HTML-FillInForm/subscription","commits_url":"https://api.github.com/repos/markstos/HTML-FillInForm/commits{/sha}","git_commits_url":"https://api.github.com/repos/markstos/HTML-FillInForm/git/commits{/sha}","comments_url":"https://api.github.com/repos/markstos/HTML-FillInForm/comments{/number}","issue_comment_url":"https://api.github.com/repos/markstos/HTML-FillInForm/issues/comments{/number}","contents_url":"https://api.github.com/repos/markstos/HTML-FillInForm/contents/{+path}","compare_url":"https://api.github.com/repos/markstos/HTML-FillInForm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markstos/HTML-FillInForm/merges","archive_url":"https://api.github.com/repos/markstos/HTML-FillInForm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markstos/HTML-FillInForm/downloads","issues_url":"https://api.github.com/repos/markstos/HTML-FillInForm/issues{/number}","pulls_url":"https://api.github.com/repos/markstos/HTML-FillInForm/pulls{/number}","milestones_url":"https://api.github.com/repos/markstos/HTML-FillInForm/milestones{/number}","notifications_url":"https://api.github.com/repos/markstos/HTML-FillInForm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markstos/HTML-FillInForm/labels{/name}","releases_url":"https://api.github.com/repos/markstos/HTML-FillInForm/releases{/id}","deployments_url":"https://api.github.com/repos/markstos/HTML-FillInForm/deployments","created_at":"2013-06-03T15:42:43Z","updated_at":"2015-04-03T14:41:31Z","pushed_at":"2016-05-19T14:09:46Z","git_url":"git://github.com/markstos/HTML-FillInForm.git","ssh_url":"git@github.com:markstos/HTML-FillInForm.git","clone_url":"https://github.com/markstos/HTML-FillInForm.git","svn_url":"https://github.com/markstos/HTML-FillInForm","homepage":null,"size":256,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/markstos/HTML-FillInForm/pulls/10"},"html":{"href":"https://github.com/markstos/HTML-FillInForm/pull/10"},"issue":{"href":"https://api.github.com/repos/markstos/HTML-FillInForm/issues/10"},"comments":{"href":"https://api.github.com/repos/markstos/HTML-FillInForm/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/markstos/HTML-FillInForm/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/markstos/HTML-FillInForm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/markstos/HTML-FillInForm/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/markstos/HTML-FillInForm/statuses/d73e80418347967d45a15e8625b10afbd473cef6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"markstos","id":25829,"avatar_url":"https://avatars.githubusercontent.com/u/25829?v=3","gravatar_id":"","url":"https://api.github.com/users/markstos","html_url":"https://github.com/markstos","followers_url":"https://api.github.com/users/markstos/followers","following_url":"https://api.github.com/users/markstos/following{/other_user}","gists_url":"https://api.github.com/users/markstos/gists{/gist_id}","starred_url":"https://api.github.com/users/markstos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstos/subscriptions","organizations_url":"https://api.github.com/users/markstos/orgs","repos_url":"https://api.github.com/users/markstos/repos","events_url":"https://api.github.com/users/markstos/events{/privacy}","received_events_url":"https://api.github.com/users/markstos/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}