{"action":"created","issue":{"url":"https://api.github.com/repos/atom/atom/issues/11345","repository_url":"https://api.github.com/repos/atom/atom","labels_url":"https://api.github.com/repos/atom/atom/issues/11345/labels{/name}","comments_url":"https://api.github.com/repos/atom/atom/issues/11345/comments","events_url":"https://api.github.com/repos/atom/atom/issues/11345/events","html_url":"https://github.com/atom/atom/pull/11345","id":145189087,"number":11345,"title":"Disable zoom every time a display gets added or removed","user":{"login":"as-cii","id":482957,"avatar_url":"https://avatars.githubusercontent.com/u/482957?v=3","gravatar_id":"","url":"https://api.github.com/users/as-cii","html_url":"https://github.com/as-cii","followers_url":"https://api.github.com/users/as-cii/followers","following_url":"https://api.github.com/users/as-cii/following{/other_user}","gists_url":"https://api.github.com/users/as-cii/gists{/gist_id}","starred_url":"https://api.github.com/users/as-cii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/as-cii/subscriptions","organizations_url":"https://api.github.com/users/as-cii/orgs","repos_url":"https://api.github.com/users/as-cii/repos","events_url":"https://api.github.com/users/as-cii/events{/privacy}","received_events_url":"https://api.github.com/users/as-cii/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-01T14:03:29Z","updated_at":"2016-04-01T15:14:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/atom/atom/pulls/11345","html_url":"https://github.com/atom/atom/pull/11345","diff_url":"https://github.com/atom/atom/pull/11345.diff","patch_url":"https://github.com/atom/atom/pull/11345.patch"},"body":"Fixes #8850. This continues the investigation started on #11326 and attempts to fix it using a different approach.\r\n\r\nIt turns out that the issue with pinch-to-zoom occurs only under certain circumstances; on my MacBook, it happens only whenever I do the following:\r\n\r\n1. Start Atom with my MacBook closed and my external monitor on;\r\n2. Open my Macbook, so that both displays are on;\r\n3. Try to pinch the tree-view;\r\n4. :boom: \r\n\r\n_(The above never happens if my MacBook is open when Atom is launched)_\r\n\r\nAs soon as a new display gets added or removed, in facts, the zoom level limit of the web frame is reset to the default and hence the page becomes zoomable again. This doesn't happen when changing the display's metrics (e.g. screen resolution), so I assume it must be something related to adding/removing displays. I have verified this arises also when enabling/disabling mirroring, which is considered by OS X as adding/removing one display.\r\n\r\nElectron provides two events which allow us to detect when a display gets added or removed, so that we can reset the zoom level limits to `(1, 1)` every time this happens. I suspect this is what is happening in #8850, and this PR should fix it once for all.\r\n\r\n/cc: @joshaber @nathansobo @mnquintana @atom/feedback for extra :eyes: :eyes: :eyes:."},"comment":{"url":"https://api.github.com/repos/atom/atom/issues/comments/204434079","html_url":"https://github.com/atom/atom/pull/11345#issuecomment-204434079","issue_url":"https://api.github.com/repos/atom/atom/issues/11345","id":204434079,"user":{"login":"thomasjo","id":3622,"avatar_url":"https://avatars.githubusercontent.com/u/3622?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasjo","html_url":"https://github.com/thomasjo","followers_url":"https://api.github.com/users/thomasjo/followers","following_url":"https://api.github.com/users/thomasjo/following{/other_user}","gists_url":"https://api.github.com/users/thomasjo/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasjo/subscriptions","organizations_url":"https://api.github.com/users/thomasjo/orgs","repos_url":"https://api.github.com/users/thomasjo/repos","events_url":"https://api.github.com/users/thomasjo/events{/privacy}","received_events_url":"https://api.github.com/users/thomasjo/received_events","type":"User","site_admin":false},"created_at":"2016-04-01T15:14:15Z","updated_at":"2016-04-01T15:14:15Z","body":"Awesome detective work! :heart: "}}