{"action":"created","issue":{"url":"https://api.github.com/repos/piwik/piwik/issues/10245","repository_url":"https://api.github.com/repos/piwik/piwik","labels_url":"https://api.github.com/repos/piwik/piwik/issues/10245/labels{/name}","comments_url":"https://api.github.com/repos/piwik/piwik/issues/10245/comments","events_url":"https://api.github.com/repos/piwik/piwik/issues/10245/events","html_url":"https://github.com/piwik/piwik/issues/10245","id":161367436,"number":10245,"title":"Should VisitorProfile popup display segmented data?","user":{"login":"wronan","id":11873141,"avatar_url":"https://avatars.githubusercontent.com/u/11873141?v=3","gravatar_id":"","url":"https://api.github.com/users/wronan","html_url":"https://github.com/wronan","followers_url":"https://api.github.com/users/wronan/followers","following_url":"https://api.github.com/users/wronan/following{/other_user}","gists_url":"https://api.github.com/users/wronan/gists{/gist_id}","starred_url":"https://api.github.com/users/wronan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wronan/subscriptions","organizations_url":"https://api.github.com/users/wronan/orgs","repos_url":"https://api.github.com/users/wronan/repos","events_url":"https://api.github.com/users/wronan/events{/privacy}","received_events_url":"https://api.github.com/users/wronan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-21T07:33:31Z","updated_at":"2016-06-23T15:07:47Z","closed_at":null,"body":"I wonder, because I stumbled on such problem:\r\n- I've created visitCount>=2 segment\r\n- such segment works OK (meaning: it filters visits at least in Visitor Log as expected)\r\n- problems start when I would like to view Visitor Profile Popup\r\n\r\nOn Visitor Profile Popup same segment is applied (https://github.com/piwik/piwik/blob/master/plugins/Live/API.php#L204), so when app looks for previous visits to be counted and listed below the current one, I get one less visit then I should (this is for for visitCount>=2 segment, for for visitCount>=3 there probably would be 2 missing, for for visitCount>=4 there would be 3 missing, etc... haven't check that behavior but it seems as a logical consequence).\r\n\r\nThis is misguiding, since most of such visits have visitCount=2, when I open respective visitor's profile, it looks like there are no additional visits.\r\n\r\nAt this I wonder whether data on Visitor's Profile Popup should be segmented at all. Since it just should show logs for specified visitor ID (https://github.com/piwik/piwik/blob/master/plugins/Live/API.php#L218) anything else shouldn't be filtered out. Ie. when I put segment for visits with more actions then 5, I expect Visitor Log to present such visits, but when I view the specific Visitor's Profile from such list, I expect it to show me full profile. Or at least it should be stated in some explicit manner, that segment was applied while generating that profile so the profile is not \"full\". What's your opinion guys? Personally I would vote for option 1.\r\n\r\n\r\nVisitor's Profile Popup is disabled on Demo, but a links to start looking at that issue would be:\r\nhttp://demo.piwik.org/index.php?module=CoreHome&action=index&idSite=7&period=day&date=yesterday#?module=Live&action=indexVisitorLog&idSite=7&period=day&date=yesterday\r\nand\r\nhttp://demo.piwik.org/index.php?module=CoreHome&action=index&idSite=7&period=day&date=yesterday#/?module=Live&action=indexVisitorLog&idSite=7&period=day&date=yesterday&segment=visitCount%3E%3D2"},"comment":{"url":"https://api.github.com/repos/piwik/piwik/issues/comments/228080549","html_url":"https://github.com/piwik/piwik/issues/10245#issuecomment-228080549","issue_url":"https://api.github.com/repos/piwik/piwik/issues/10245","id":228080549,"user":{"login":"wronan","id":11873141,"avatar_url":"https://avatars.githubusercontent.com/u/11873141?v=3","gravatar_id":"","url":"https://api.github.com/users/wronan","html_url":"https://github.com/wronan","followers_url":"https://api.github.com/users/wronan/followers","following_url":"https://api.github.com/users/wronan/following{/other_user}","gists_url":"https://api.github.com/users/wronan/gists{/gist_id}","starred_url":"https://api.github.com/users/wronan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wronan/subscriptions","organizations_url":"https://api.github.com/users/wronan/orgs","repos_url":"https://api.github.com/users/wronan/repos","events_url":"https://api.github.com/users/wronan/events{/privacy}","received_events_url":"https://api.github.com/users/wronan/received_events","type":"User","site_admin":false},"created_at":"2016-06-23T15:07:47Z","updated_at":"2016-06-23T15:07:47Z","body":"@mattab || @tsteur , could you give me some opinion on the subject? I'll prepare the PR, just want to know how to proceed. Thx in advance :)"}}
{"actor":{"display_login":"wronan"}}