{"action":"created","comment":{"url":"https://api.github.com/repos/Katello/katello-installer/pulls/comments/64247532","id":64247532,"diff_hunk":"@@ -59,6 +67,24 @@ def remove_nodes_distributors\n   Kafo::Helpers.execute(\"mongo pulp_database --eval  'db.repo_distributors.remove({'distributor_type_id': \\\"nodes_http_distributor\\\"});'\")\n end\n \n+def fix_pulp_httpd_conf\n+  return true unless File.exist?('/etc/httpd/conf.d/pulp.conf.rpmnew')\n+\n+  Kafo::Helpers.execute('cp /etc/httpd/conf.d/pulp.conf.rpmnew /etc/httpd/conf.d/pulp.conf')\n+end","path":"hooks/pre/30-upgrade.rb","position":23,"original_position":23,"commit_id":"69f5b803960afc7d27f002e086a0165a3c66412e","original_commit_id":"69f5b803960afc7d27f002e086a0165a3c66412e","user":{"login":"bbuckingham","id":1319246,"avatar_url":"https://avatars.githubusercontent.com/u/1319246?v=3","gravatar_id":"","url":"https://api.github.com/users/bbuckingham","html_url":"https://github.com/bbuckingham","followers_url":"https://api.github.com/users/bbuckingham/followers","following_url":"https://api.github.com/users/bbuckingham/following{/other_user}","gists_url":"https://api.github.com/users/bbuckingham/gists{/gist_id}","starred_url":"https://api.github.com/users/bbuckingham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbuckingham/subscriptions","organizations_url":"https://api.github.com/users/bbuckingham/orgs","repos_url":"https://api.github.com/users/bbuckingham/repos","events_url":"https://api.github.com/users/bbuckingham/events{/privacy}","received_events_url":"https://api.github.com/users/bbuckingham/received_events","type":"User","site_admin":false},"body":"It is hard to be 100% certain; however, given the types of changes that go in to the z-releases, it seems like this should still be Ok.  That said, we'll need to ensure that we continue to always run --upgrade on those releases and perform proper regression testing.\r\n\r\nI did perform multiple --upgrade runs with the installer using these changes and have not seen any adverse affects; however, I do realize that those tests do not involve additional software updates being introduced.","created_at":"2016-05-23T16:29:51Z","updated_at":"2016-05-23T16:29:51Z","html_url":"https://github.com/Katello/katello-installer/pull/339#discussion_r64247532","pull_request_url":"https://api.github.com/repos/Katello/katello-installer/pulls/339","_links":{"self":{"href":"https://api.github.com/repos/Katello/katello-installer/pulls/comments/64247532"},"html":{"href":"https://github.com/Katello/katello-installer/pull/339#discussion_r64247532"},"pull_request":{"href":"https://api.github.com/repos/Katello/katello-installer/pulls/339"}}},"pull_request":{"url":"https://api.github.com/repos/Katello/katello-installer/pulls/339","id":70953378,"html_url":"https://github.com/Katello/katello-installer/pull/339","diff_url":"https://github.com/Katello/katello-installer/pull/339.diff","patch_url":"https://github.com/Katello/katello-installer/pull/339.patch","issue_url":"https://api.github.com/repos/Katello/katello-installer/issues/339","number":339,"state":"open","locked":false,"title":"Fixes #15117 - Upgrade steps required for 2.3 to 3.0","user":{"login":"ehelms","id":293363,"avatar_url":"https://avatars.githubusercontent.com/u/293363?v=3","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"body":"This is an alternative approach to #338 where I am centralizing all the \"unique\" logic required for these upgrades into the pre-upgrade script and attempting to provide as much idempotent behavior as possible. Another approach would be to add \"upgrade.d\" functionality similar to migrations and mark upgrades that have run and perform these there. \r\n\r\nNote: This is only from a 2.3 to 3.0 upgrade which we say we support currently. There is one outstanding issue with this that I did not include a fix for yet. The Foreman PR (https://github.com/theforeman/foreman/pull/3519) is not currently in 1.11 and the migrations fail because of it. As I see it our options then are:\r\n\r\n 1) Push to get https://github.com/theforeman/foreman/pull/3519 into 1.11.3 and wait for GA until then\r\n 2) Add upgrade instructions that do the following (and yes this worked testing locally):\r\n   - disable katello as a gem\r\n   - run foreman-rake db:migrate to migrate Foreman\r\n   - renable katello as a gem\r\n   - re-run foreman-rake db:migrate to migrate Katello\r\n 2) Require users to upgrade to 2.4 and then to 3.0","created_at":"2016-05-21T16:15:04Z","updated_at":"2016-05-23T16:29:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6212381000206858c8386614a4be94aee2a2b155","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Katello/katello-installer/pulls/339/commits","review_comments_url":"https://api.github.com/repos/Katello/katello-installer/pulls/339/comments","review_comment_url":"https://api.github.com/repos/Katello/katello-installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Katello/katello-installer/issues/339/comments","statuses_url":"https://api.github.com/repos/Katello/katello-installer/statuses/69f5b803960afc7d27f002e086a0165a3c66412e","head":{"label":"ehelms:fixes-15117","ref":"fixes-15117","sha":"69f5b803960afc7d27f002e086a0165a3c66412e","user":{"login":"ehelms","id":293363,"avatar_url":"https://avatars.githubusercontent.com/u/293363?v=3","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"repo":{"id":16705745,"name":"katello-installer","full_name":"ehelms/katello-installer","owner":{"login":"ehelms","id":293363,"avatar_url":"https://avatars.githubusercontent.com/u/293363?v=3","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ehelms/katello-installer","description":"Installation script for Katello nodes","fork":true,"url":"https://api.github.com/repos/ehelms/katello-installer","forks_url":"https://api.github.com/repos/ehelms/katello-installer/forks","keys_url":"https://api.github.com/repos/ehelms/katello-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ehelms/katello-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ehelms/katello-installer/teams","hooks_url":"https://api.github.com/repos/ehelms/katello-installer/hooks","issue_events_url":"https://api.github.com/repos/ehelms/katello-installer/issues/events{/number}","events_url":"https://api.github.com/repos/ehelms/katello-installer/events","assignees_url":"https://api.github.com/repos/ehelms/katello-installer/assignees{/user}","branches_url":"https://api.github.com/repos/ehelms/katello-installer/branches{/branch}","tags_url":"https://api.github.com/repos/ehelms/katello-installer/tags","blobs_url":"https://api.github.com/repos/ehelms/katello-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ehelms/katello-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ehelms/katello-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ehelms/katello-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ehelms/katello-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/ehelms/katello-installer/languages","stargazers_url":"https://api.github.com/repos/ehelms/katello-installer/stargazers","contributors_url":"https://api.github.com/repos/ehelms/katello-installer/contributors","subscribers_url":"https://api.github.com/repos/ehelms/katello-installer/subscribers","subscription_url":"https://api.github.com/repos/ehelms/katello-installer/subscription","commits_url":"https://api.github.com/repos/ehelms/katello-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ehelms/katello-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ehelms/katello-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ehelms/katello-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ehelms/katello-installer/contents/{+path}","compare_url":"https://api.github.com/repos/ehelms/katello-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ehelms/katello-installer/merges","archive_url":"https://api.github.com/repos/ehelms/katello-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ehelms/katello-installer/downloads","issues_url":"https://api.github.com/repos/ehelms/katello-installer/issues{/number}","pulls_url":"https://api.github.com/repos/ehelms/katello-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/ehelms/katello-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/ehelms/katello-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ehelms/katello-installer/labels{/name}","releases_url":"https://api.github.com/repos/ehelms/katello-installer/releases{/id}","deployments_url":"https://api.github.com/repos/ehelms/katello-installer/deployments","created_at":"2014-02-10T19:02:31Z","updated_at":"2014-06-24T20:16:50Z","pushed_at":"2016-05-21T16:10:14Z","git_url":"git://github.com/ehelms/katello-installer.git","ssh_url":"git@github.com:ehelms/katello-installer.git","clone_url":"https://github.com/ehelms/katello-installer.git","svn_url":"https://github.com/ehelms/katello-installer","homepage":null,"size":6216,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Katello:master","ref":"master","sha":"fe37561e43779b283414405b4d9ad9ad9da9b6bd","user":{"login":"Katello","id":1316386,"avatar_url":"https://avatars.githubusercontent.com/u/1316386?v=3","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"repo":{"id":12600670,"name":"katello-installer","full_name":"Katello/katello-installer","owner":{"login":"Katello","id":1316386,"avatar_url":"https://avatars.githubusercontent.com/u/1316386?v=3","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Katello/katello-installer","description":"Puppet-based installer for Katello","fork":false,"url":"https://api.github.com/repos/Katello/katello-installer","forks_url":"https://api.github.com/repos/Katello/katello-installer/forks","keys_url":"https://api.github.com/repos/Katello/katello-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Katello/katello-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Katello/katello-installer/teams","hooks_url":"https://api.github.com/repos/Katello/katello-installer/hooks","issue_events_url":"https://api.github.com/repos/Katello/katello-installer/issues/events{/number}","events_url":"https://api.github.com/repos/Katello/katello-installer/events","assignees_url":"https://api.github.com/repos/Katello/katello-installer/assignees{/user}","branches_url":"https://api.github.com/repos/Katello/katello-installer/branches{/branch}","tags_url":"https://api.github.com/repos/Katello/katello-installer/tags","blobs_url":"https://api.github.com/repos/Katello/katello-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Katello/katello-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Katello/katello-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Katello/katello-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Katello/katello-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/Katello/katello-installer/languages","stargazers_url":"https://api.github.com/repos/Katello/katello-installer/stargazers","contributors_url":"https://api.github.com/repos/Katello/katello-installer/contributors","subscribers_url":"https://api.github.com/repos/Katello/katello-installer/subscribers","subscription_url":"https://api.github.com/repos/Katello/katello-installer/subscription","commits_url":"https://api.github.com/repos/Katello/katello-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Katello/katello-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Katello/katello-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Katello/katello-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Katello/katello-installer/contents/{+path}","compare_url":"https://api.github.com/repos/Katello/katello-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Katello/katello-installer/merges","archive_url":"https://api.github.com/repos/Katello/katello-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Katello/katello-installer/downloads","issues_url":"https://api.github.com/repos/Katello/katello-installer/issues{/number}","pulls_url":"https://api.github.com/repos/Katello/katello-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/Katello/katello-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/Katello/katello-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Katello/katello-installer/labels{/name}","releases_url":"https://api.github.com/repos/Katello/katello-installer/releases{/id}","deployments_url":"https://api.github.com/repos/Katello/katello-installer/deployments","created_at":"2013-09-04T19:56:27Z","updated_at":"2016-03-25T20:43:11Z","pushed_at":"2016-05-21T16:15:04Z","git_url":"git://github.com/Katello/katello-installer.git","ssh_url":"git@github.com:Katello/katello-installer.git","clone_url":"https://github.com/Katello/katello-installer.git","svn_url":"https://github.com/Katello/katello-installer","homepage":"http://www.katello.org/","size":7507,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":12,"forks":46,"open_issues":12,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Katello/katello-installer/pulls/339"},"html":{"href":"https://github.com/Katello/katello-installer/pull/339"},"issue":{"href":"https://api.github.com/repos/Katello/katello-installer/issues/339"},"comments":{"href":"https://api.github.com/repos/Katello/katello-installer/issues/339/comments"},"review_comments":{"href":"https://api.github.com/repos/Katello/katello-installer/pulls/339/comments"},"review_comment":{"href":"https://api.github.com/repos/Katello/katello-installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Katello/katello-installer/pulls/339/commits"},"statuses":{"href":"https://api.github.com/repos/Katello/katello-installer/statuses/69f5b803960afc7d27f002e086a0165a3c66412e"}}}}
{"actor":{"display_login":"bbuckingham"}}