{"action":"created","comment":{"url":"https://api.github.com/repos/projecthydra/sufia/pulls/comments/53813487","id":53813487,"diff_hunk":"@@ -0,0 +1,46 @@\n+require 'spec_helper'\n+\n+describe Sufia::Forms::WorkForm do\n+  before do\n+    class PirateShip < ActiveFedora::Base\n+      include CurationConcerns::RequiredMetadata\n+      include CurationConcerns::BasicMetadata\n+      include CurationConcerns::HasRepresentative\n+    end\n+\n+    class PirateShipForm < described_class","path":"spec/form/work_form_spec.rb","position":11,"original_position":11,"commit_id":"db22fb8dbd75bbde52a4e49104211912ded15c39","original_commit_id":"db22fb8dbd75bbde52a4e49104211912ded15c39","user":{"login":"jcoyne","id":92044,"avatar_url":"https://avatars.githubusercontent.com/u/92044?v=3","gravatar_id":"","url":"https://api.github.com/users/jcoyne","html_url":"https://github.com/jcoyne","followers_url":"https://api.github.com/users/jcoyne/followers","following_url":"https://api.github.com/users/jcoyne/following{/other_user}","gists_url":"https://api.github.com/users/jcoyne/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoyne/subscriptions","organizations_url":"https://api.github.com/users/jcoyne/orgs","repos_url":"https://api.github.com/users/jcoyne/repos","events_url":"https://api.github.com/users/jcoyne/events{/privacy}","received_events_url":"https://api.github.com/users/jcoyne/received_events","type":"User","site_admin":false},"body":"we don't need this either. you can just use `Sufia::Forms::WorkForm`","created_at":"2016-02-23T17:10:28Z","updated_at":"2016-02-23T17:10:28Z","html_url":"https://github.com/projecthydra/sufia/pull/1596#discussion_r53813487","pull_request_url":"https://api.github.com/repos/projecthydra/sufia/pulls/1596","_links":{"self":{"href":"https://api.github.com/repos/projecthydra/sufia/pulls/comments/53813487"},"html":{"href":"https://github.com/projecthydra/sufia/pull/1596#discussion_r53813487"},"pull_request":{"href":"https://api.github.com/repos/projecthydra/sufia/pulls/1596"}}},"pull_request":{"url":"https://api.github.com/repos/projecthydra/sufia/pulls/1596","id":60181093,"html_url":"https://github.com/projecthydra/sufia/pull/1596","diff_url":"https://github.com/projecthydra/sufia/pull/1596.diff","patch_url":"https://github.com/projecthydra/sufia/pull/1596.patch","issue_url":"https://api.github.com/repos/projecthydra/sufia/issues/1596","number":1596,"state":"open","locked":false,"title":"update rights input field selector","user":{"login":"njaffer","id":12487929,"avatar_url":"https://avatars.githubusercontent.com/u/12487929?v=3","gravatar_id":"","url":"https://api.github.com/users/njaffer","html_url":"https://github.com/njaffer","followers_url":"https://api.github.com/users/njaffer/followers","following_url":"https://api.github.com/users/njaffer/following{/other_user}","gists_url":"https://api.github.com/users/njaffer/gists{/gist_id}","starred_url":"https://api.github.com/users/njaffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njaffer/subscriptions","organizations_url":"https://api.github.com/users/njaffer/orgs","repos_url":"https://api.github.com/users/njaffer/repos","events_url":"https://api.github.com/users/njaffer/events{/privacy}","received_events_url":"https://api.github.com/users/njaffer/received_events","type":"User","site_admin":false},"body":"Present tense short summary (50 characters or less)\r\nThe right property does not get saved when a New Work is created or edited. \r\n\r\nHere is the debugger output before the change\r\nbyebug\r\n    7:     # set the @files ivar then remove the files attribute so it isn't set by default.\r\n=>  8:     files && attributes.delete(:files)\r\n    9:     self.raw_attributes = attributes.dup\r\n   10:     # Files must be attached before saving in order to persist their relationship to the work\r\n   11:     assign_pid && interpret_visibility && attach_files && super && assign_representative\r\n   12:   end\r\n(byebug) attributes\r\n{\"title\"=>[\"Test Work 333\"], \"creator\"=>[], \"contributor\"=>[], \"description\"=>[], \"tag\"=>[], \"publisher\"=>[], \"date_created\"=>[], \"subject\"=>[], \"language\"=>[], \"identifier\"=>[], \"based_near\"=>[], \"related_url\"=>[], \"visibility_during_embargo\"=>\"restricted\", \"embargo_release_date\"=>\"2016-02-23\", \"visibility_after_embargo\"=>\"open\", \"visibility_during_lease\"=>\"open\", \"lease_expiration_date\"=>\"2016-02-23\", \"visibility_after_lease\"=>\"restricted\", \"visibility\"=>\"restricted\", \"resource_type\"=>[]}\r\n\r\nHere is the debugger output after the change\r\n(byebug) attributes\r\n{\"title\"=>[\"Test Work 333\"], \"creator\"=>[], \"contributor\"=>[], \"description\"=>[], \"tag\"=>[], \"rights\"=>[\"http://creativecommons.org/licenses/by-nc/3.0/us/\"], \"publisher\"=>[], \"date_created\"=>[], \"subject\"=>[], \"language\"=>[], \"identifier\"=>[], \"based_near\"=>[], \"related_url\"=>[], \"visibility_during_embargo\"=>\"restricted\", \"embargo_release_date\"=>\"2016-02-23\", \"visibility_after_embargo\"=>\"open\", \"visibility_during_lease\"=>\"open\", \"lease_expiration_date\"=>\"2016-02-23\", \"visibility_after_lease\"=>\"restricted\", \"visibility\"=>\"restricted\", \"resource_type\"=>[]}\r\n\r\nChanges proposed in this pull request:\r\n* override multiple? in WorkForm, set rights to true\r\n* \r\n* \r\n\r\n@projecthydra/sufia-code-reviewers\r\n\r\n","created_at":"2016-02-22T14:31:57Z","updated_at":"2016-02-23T17:10:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fdef1832a2915cca6d99ed0d88ddc037c6b54c2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projecthydra/sufia/pulls/1596/commits","review_comments_url":"https://api.github.com/repos/projecthydra/sufia/pulls/1596/comments","review_comment_url":"https://api.github.com/repos/projecthydra/sufia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projecthydra/sufia/issues/1596/comments","statuses_url":"https://api.github.com/repos/projecthydra/sufia/statuses/db22fb8dbd75bbde52a4e49104211912ded15c39","head":{"label":"njaffer:rights_array","ref":"rights_array","sha":"db22fb8dbd75bbde52a4e49104211912ded15c39","user":{"login":"njaffer","id":12487929,"avatar_url":"https://avatars.githubusercontent.com/u/12487929?v=3","gravatar_id":"","url":"https://api.github.com/users/njaffer","html_url":"https://github.com/njaffer","followers_url":"https://api.github.com/users/njaffer/followers","following_url":"https://api.github.com/users/njaffer/following{/other_user}","gists_url":"https://api.github.com/users/njaffer/gists{/gist_id}","starred_url":"https://api.github.com/users/njaffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njaffer/subscriptions","organizations_url":"https://api.github.com/users/njaffer/orgs","repos_url":"https://api.github.com/users/njaffer/repos","events_url":"https://api.github.com/users/njaffer/events{/privacy}","received_events_url":"https://api.github.com/users/njaffer/received_events","type":"User","site_admin":false},"repo":{"id":47587212,"name":"sufia","full_name":"njaffer/sufia","owner":{"login":"njaffer","id":12487929,"avatar_url":"https://avatars.githubusercontent.com/u/12487929?v=3","gravatar_id":"","url":"https://api.github.com/users/njaffer","html_url":"https://github.com/njaffer","followers_url":"https://api.github.com/users/njaffer/followers","following_url":"https://api.github.com/users/njaffer/following{/other_user}","gists_url":"https://api.github.com/users/njaffer/gists{/gist_id}","starred_url":"https://api.github.com/users/njaffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njaffer/subscriptions","organizations_url":"https://api.github.com/users/njaffer/orgs","repos_url":"https://api.github.com/users/njaffer/repos","events_url":"https://api.github.com/users/njaffer/events{/privacy}","received_events_url":"https://api.github.com/users/njaffer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/njaffer/sufia","description":"Sufia is a Rails engine for creating a self-deposit institutional repository. A web application for ingest, curation, search, and display of digital assets. Powered by Hydra technologies (Rails, Hydra-head, Blacklight, Solr, Fedora Commons, etc.)","fork":true,"url":"https://api.github.com/repos/njaffer/sufia","forks_url":"https://api.github.com/repos/njaffer/sufia/forks","keys_url":"https://api.github.com/repos/njaffer/sufia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/njaffer/sufia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/njaffer/sufia/teams","hooks_url":"https://api.github.com/repos/njaffer/sufia/hooks","issue_events_url":"https://api.github.com/repos/njaffer/sufia/issues/events{/number}","events_url":"https://api.github.com/repos/njaffer/sufia/events","assignees_url":"https://api.github.com/repos/njaffer/sufia/assignees{/user}","branches_url":"https://api.github.com/repos/njaffer/sufia/branches{/branch}","tags_url":"https://api.github.com/repos/njaffer/sufia/tags","blobs_url":"https://api.github.com/repos/njaffer/sufia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/njaffer/sufia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/njaffer/sufia/git/refs{/sha}","trees_url":"https://api.github.com/repos/njaffer/sufia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/njaffer/sufia/statuses/{sha}","languages_url":"https://api.github.com/repos/njaffer/sufia/languages","stargazers_url":"https://api.github.com/repos/njaffer/sufia/stargazers","contributors_url":"https://api.github.com/repos/njaffer/sufia/contributors","subscribers_url":"https://api.github.com/repos/njaffer/sufia/subscribers","subscription_url":"https://api.github.com/repos/njaffer/sufia/subscription","commits_url":"https://api.github.com/repos/njaffer/sufia/commits{/sha}","git_commits_url":"https://api.github.com/repos/njaffer/sufia/git/commits{/sha}","comments_url":"https://api.github.com/repos/njaffer/sufia/comments{/number}","issue_comment_url":"https://api.github.com/repos/njaffer/sufia/issues/comments{/number}","contents_url":"https://api.github.com/repos/njaffer/sufia/contents/{+path}","compare_url":"https://api.github.com/repos/njaffer/sufia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/njaffer/sufia/merges","archive_url":"https://api.github.com/repos/njaffer/sufia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/njaffer/sufia/downloads","issues_url":"https://api.github.com/repos/njaffer/sufia/issues{/number}","pulls_url":"https://api.github.com/repos/njaffer/sufia/pulls{/number}","milestones_url":"https://api.github.com/repos/njaffer/sufia/milestones{/number}","notifications_url":"https://api.github.com/repos/njaffer/sufia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/njaffer/sufia/labels{/name}","releases_url":"https://api.github.com/repos/njaffer/sufia/releases{/id}","deployments_url":"https://api.github.com/repos/njaffer/sufia/deployments","created_at":"2015-12-08T00:06:56Z","updated_at":"2016-01-14T18:06:08Z","pushed_at":"2016-02-23T14:28:33Z","git_url":"git://github.com/njaffer/sufia.git","ssh_url":"git@github.com:njaffer/sufia.git","clone_url":"https://github.com/njaffer/sufia.git","svn_url":"https://github.com/njaffer/sufia","homepage":"","size":54139,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projecthydra:master","ref":"master","sha":"351c6eeef5886c88ca712f088a42f458c5010985","user":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"repo":{"id":7653178,"name":"sufia","full_name":"projecthydra/sufia","owner":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecthydra/sufia","description":"Sufia extends the robust Hydra framework to provide a user interface around common repository features and social features. Sufia offers self-deposit and proxy deposit workflows with plans to develop one or more mediated deposit workflows in 2016. Sufia delivers its rich and growing set of features via a modern, responsive UI.","fork":false,"url":"https://api.github.com/repos/projecthydra/sufia","forks_url":"https://api.github.com/repos/projecthydra/sufia/forks","keys_url":"https://api.github.com/repos/projecthydra/sufia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecthydra/sufia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecthydra/sufia/teams","hooks_url":"https://api.github.com/repos/projecthydra/sufia/hooks","issue_events_url":"https://api.github.com/repos/projecthydra/sufia/issues/events{/number}","events_url":"https://api.github.com/repos/projecthydra/sufia/events","assignees_url":"https://api.github.com/repos/projecthydra/sufia/assignees{/user}","branches_url":"https://api.github.com/repos/projecthydra/sufia/branches{/branch}","tags_url":"https://api.github.com/repos/projecthydra/sufia/tags","blobs_url":"https://api.github.com/repos/projecthydra/sufia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecthydra/sufia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecthydra/sufia/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecthydra/sufia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecthydra/sufia/statuses/{sha}","languages_url":"https://api.github.com/repos/projecthydra/sufia/languages","stargazers_url":"https://api.github.com/repos/projecthydra/sufia/stargazers","contributors_url":"https://api.github.com/repos/projecthydra/sufia/contributors","subscribers_url":"https://api.github.com/repos/projecthydra/sufia/subscribers","subscription_url":"https://api.github.com/repos/projecthydra/sufia/subscription","commits_url":"https://api.github.com/repos/projecthydra/sufia/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecthydra/sufia/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecthydra/sufia/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecthydra/sufia/issues/comments{/number}","contents_url":"https://api.github.com/repos/projecthydra/sufia/contents/{+path}","compare_url":"https://api.github.com/repos/projecthydra/sufia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecthydra/sufia/merges","archive_url":"https://api.github.com/repos/projecthydra/sufia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecthydra/sufia/downloads","issues_url":"https://api.github.com/repos/projecthydra/sufia/issues{/number}","pulls_url":"https://api.github.com/repos/projecthydra/sufia/pulls{/number}","milestones_url":"https://api.github.com/repos/projecthydra/sufia/milestones{/number}","notifications_url":"https://api.github.com/repos/projecthydra/sufia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecthydra/sufia/labels{/name}","releases_url":"https://api.github.com/repos/projecthydra/sufia/releases{/id}","deployments_url":"https://api.github.com/repos/projecthydra/sufia/deployments","created_at":"2013-01-16T20:23:18Z","updated_at":"2016-02-23T16:26:03Z","pushed_at":"2016-02-23T14:28:33Z","git_url":"git://github.com/projecthydra/sufia.git","ssh_url":"git@github.com:projecthydra/sufia.git","clone_url":"https://github.com/projecthydra/sufia.git","svn_url":"https://github.com/projecthydra/sufia","homepage":"http://sufia.io/","size":54682,"stargazers_count":88,"watchers_count":88,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":74,"forks":68,"open_issues":74,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projecthydra/sufia/pulls/1596"},"html":{"href":"https://github.com/projecthydra/sufia/pull/1596"},"issue":{"href":"https://api.github.com/repos/projecthydra/sufia/issues/1596"},"comments":{"href":"https://api.github.com/repos/projecthydra/sufia/issues/1596/comments"},"review_comments":{"href":"https://api.github.com/repos/projecthydra/sufia/pulls/1596/comments"},"review_comment":{"href":"https://api.github.com/repos/projecthydra/sufia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projecthydra/sufia/pulls/1596/commits"},"statuses":{"href":"https://api.github.com/repos/projecthydra/sufia/statuses/db22fb8dbd75bbde52a4e49104211912ded15c39"}}}}