{"action":"created","issue":{"url":"https://api.github.com/repos/agnwinds/python/issues/226","repository_url":"https://api.github.com/repos/agnwinds/python","labels_url":"https://api.github.com/repos/agnwinds/python/issues/226/labels{/name}","comments_url":"https://api.github.com/repos/agnwinds/python/issues/226/comments","events_url":"https://api.github.com/repos/agnwinds/python/issues/226/events","html_url":"https://github.com/agnwinds/python/issues/226","id":191710162,"number":226,"title":"Units in spectrum output files","user":{"login":"jhmatthews","id":3007249,"avatar_url":"https://avatars.githubusercontent.com/u/3007249?v=3","gravatar_id":"","url":"https://api.github.com/users/jhmatthews","html_url":"https://github.com/jhmatthews","followers_url":"https://api.github.com/users/jhmatthews/followers","following_url":"https://api.github.com/users/jhmatthews/following{/other_user}","gists_url":"https://api.github.com/users/jhmatthews/gists{/gist_id}","starred_url":"https://api.github.com/users/jhmatthews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhmatthews/subscriptions","organizations_url":"https://api.github.com/users/jhmatthews/orgs","repos_url":"https://api.github.com/users/jhmatthews/repos","events_url":"https://api.github.com/users/jhmatthews/events{/privacy}","received_events_url":"https://api.github.com/users/jhmatthews/received_events","type":"User","site_admin":false},"labels":[{"id":126292739,"url":"https://api.github.com/repos/agnwinds/python/labels/admin","name":"admin","color":"f7c6c7","default":false},{"id":25197020,"url":"https://api.github.com/repos/agnwinds/python/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-25T14:12:40Z","updated_at":"2016-11-25T14:57:38Z","closed_at":null,"body":"Spectral output files should include units to prevent confusion. I think these are the units adopted if one chooses \"flambda\" units in the parameter file:\r\n\r\n* .spec: erg/cm^2/s/A (Flambda)\r\n* .log_spec: erg/cm^2/s/A (Flambda)\r\n* .spec: erg/s/Hz (LNU)\r\n* .log_spec: erg/s/Hz (LNU)\r\n\r\nDo we agree, @Higginbottom @kslong ?"},"comment":{"url":"https://api.github.com/repos/agnwinds/python/issues/comments/262972779","html_url":"https://github.com/agnwinds/python/issues/226#issuecomment-262972779","issue_url":"https://api.github.com/repos/agnwinds/python/issues/226","id":262972779,"user":{"login":"jhmatthews","id":3007249,"avatar_url":"https://avatars.githubusercontent.com/u/3007249?v=3","gravatar_id":"","url":"https://api.github.com/users/jhmatthews","html_url":"https://github.com/jhmatthews","followers_url":"https://api.github.com/users/jhmatthews/followers","following_url":"https://api.github.com/users/jhmatthews/following{/other_user}","gists_url":"https://api.github.com/users/jhmatthews/gists{/gist_id}","starred_url":"https://api.github.com/users/jhmatthews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhmatthews/subscriptions","organizations_url":"https://api.github.com/users/jhmatthews/orgs","repos_url":"https://api.github.com/users/jhmatthews/repos","events_url":"https://api.github.com/users/jhmatthews/events{/privacy}","received_events_url":"https://api.github.com/users/jhmatthews/received_events","type":"User","site_admin":false},"created_at":"2016-11-25T14:57:38Z","updated_at":"2016-11-25T14:57:38Z","body":"I think the point is Knox, that the metadata in most of those examples is set by an astropy assignment command, rather than in the file on is reading. The exception is if you provide a formatting file. I would probably be in favour of searching for a units string in the spectrum output file and assigning that to the table object, but I'm open to suggestions. Bottom line is that astropy units functionality is neat, but it would still require a degree of maintenance on our part. We can discuss in telecon."}}
{"actor":{"display_login":"jhmatthews"}}