{"action":"created","issue":{"url":"https://api.github.com/repos/flycheck/flycheck/issues/1057","repository_url":"https://api.github.com/repos/flycheck/flycheck","labels_url":"https://api.github.com/repos/flycheck/flycheck/issues/1057/labels{/name}","comments_url":"https://api.github.com/repos/flycheck/flycheck/issues/1057/comments","events_url":"https://api.github.com/repos/flycheck/flycheck/issues/1057/events","html_url":"https://github.com/flycheck/flycheck/pull/1057","id":173998010,"number":1057,"title":"let luacheck find luacheck itself","user":{"login":"ghprince","id":1623110,"avatar_url":"https://avatars.githubusercontent.com/u/1623110?v=3","gravatar_id":"","url":"https://api.github.com/users/ghprince","html_url":"https://github.com/ghprince","followers_url":"https://api.github.com/users/ghprince/followers","following_url":"https://api.github.com/users/ghprince/following{/other_user}","gists_url":"https://api.github.com/users/ghprince/gists{/gist_id}","starred_url":"https://api.github.com/users/ghprince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghprince/subscriptions","organizations_url":"https://api.github.com/users/ghprince/orgs","repos_url":"https://api.github.com/users/ghprince/repos","events_url":"https://api.github.com/users/ghprince/events{/privacy}","received_events_url":"https://api.github.com/users/ghprince/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/flycheck/flycheck/labels/language%20support","name":"language support","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-08-30T11:46:46Z","updated_at":"2016-08-31T08:16:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/flycheck/flycheck/pulls/1057","html_url":"https://github.com/flycheck/flycheck/pull/1057","diff_url":"https://github.com/flycheck/flycheck/pull/1057.diff","patch_url":"https://github.com/flycheck/flycheck/pull/1057.patch"},"body":"As discussed in #1047, `luacheck` is capable of finding its config file `.luacheckrc` itself, it also works better with `--filename` option.\r\n\r\nTherefore, we should remove `config-file` call for `lua-luacheck`"},"comment":{"url":"https://api.github.com/repos/flycheck/flycheck/issues/comments/243691930","html_url":"https://github.com/flycheck/flycheck/pull/1057#issuecomment-243691930","issue_url":"https://api.github.com/repos/flycheck/flycheck/issues/1057","id":243691930,"user":{"login":"lunaryorn","id":224922,"avatar_url":"https://avatars.githubusercontent.com/u/224922?v=3","gravatar_id":"","url":"https://api.github.com/users/lunaryorn","html_url":"https://github.com/lunaryorn","followers_url":"https://api.github.com/users/lunaryorn/followers","following_url":"https://api.github.com/users/lunaryorn/following{/other_user}","gists_url":"https://api.github.com/users/lunaryorn/gists{/gist_id}","starred_url":"https://api.github.com/users/lunaryorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunaryorn/subscriptions","organizations_url":"https://api.github.com/users/lunaryorn/orgs","repos_url":"https://api.github.com/users/lunaryorn/repos","events_url":"https://api.github.com/users/lunaryorn/events{/privacy}","received_events_url":"https://api.github.com/users/lunaryorn/received_events","type":"User","site_admin":false},"created_at":"2016-08-31T08:16:11Z","updated_at":"2016-08-31T08:16:11Z","body":"@ghprince Oh, thanks for fixing these test cases.  I wished we could run them on Travis CI, and in fact we used to do that long ago but it didn't work so well.  Travis CI took ages to install all the syntax checker tools that we support, and tests would constantly break due to minor changes in the output of some tool so we'd spend a non-trivial amount of time on constantly updating the test cases.  \r\n\r\nIt got out of hand and that's where I got fed up, split the integration tests from the rest and decided to stop running the integration tests on Travis CI.  Our builds are a lot more stable now, and feedback for contributors comes much faster.\r\n\r\nWe now only use the integration tests for local testing when making changes to syntax checkers, i.e. I sometimes ask contributors to run `make LANGUAGE=foo integ` to run the integration tests for a particular language they've been making changes to.\r\n\r\nIf you've got any idea how we could run the language tests or at least a subset thereof on Travis CI or any other CI platform I'd be happy to hear it.\r\n\r\n----\r\n\r\nAs to this PR, please rebase on master and resolve the merge conflict in `CHANGES.rst`.  Please put the breaking changes section first, before `New syntax checkers`.\r\n"}}
{"actor":{"display_login":"lunaryorn"}}