{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/cli/pulls/comments/75929394","id":75929394,"diff_hunk":"@@ -0,0 +1,32 @@\n+﻿{\n+  \"version\": \"1.0.0-featmsbuild-*\",\n+  \"buildOptions\": {\n+    \"warningsAsErrors\": true\n+  },\n+  \"dependencies\": {\n+    \"Microsoft.DotNet.Compiler.Common\": {\n+      \"target\": \"project\"\n+    },\n+    \"Microsoft.DotNet.Cli.Utils\": {\n+      \"target\": \"project\"\n+    },\n+    \"Microsoft.DotNet.ProjectModel\": {\n+      \"target\": \"project\"\n+    },\n+    \"Microsoft.Win32.Registry\": {\n+      \"version\": \"4.0.0\",\n+      \"exclude\": \"compile\"\n+    },\n+    \"MSBuild\": \"0.1.0-preview-00029-160805\",","path":"src/Microsoft.DotNet.ProjectJsonMigration/project.json","position":20,"original_position":20,"commit_id":"34f815c1ee97f12bb4c21a34e867ab26ff60380b","original_commit_id":"34f815c1ee97f12bb4c21a34e867ab26ff60380b","user":{"login":"brthor","id":14280892,"avatar_url":"https://avatars.githubusercontent.com/u/14280892?v=3","gravatar_id":"","url":"https://api.github.com/users/brthor","html_url":"https://github.com/brthor","followers_url":"https://api.github.com/users/brthor/followers","following_url":"https://api.github.com/users/brthor/following{/other_user}","gists_url":"https://api.github.com/users/brthor/gists{/gist_id}","starred_url":"https://api.github.com/users/brthor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brthor/subscriptions","organizations_url":"https://api.github.com/users/brthor/orgs","repos_url":"https://api.github.com/users/brthor/repos","events_url":"https://api.github.com/users/brthor/events{/privacy}","received_events_url":"https://api.github.com/users/brthor/received_events","type":"User","site_admin":false},"body":"fixed.","created_at":"2016-08-23T18:57:02Z","updated_at":"2016-08-23T18:57:02Z","html_url":"https://github.com/dotnet/cli/pull/4074#discussion_r75929394","pull_request_url":"https://api.github.com/repos/dotnet/cli/pulls/4074","_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments/75929394"},"html":{"href":"https://github.com/dotnet/cli/pull/4074#discussion_r75929394"},"pull_request":{"href":"https://api.github.com/repos/dotnet/cli/pulls/4074"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/cli/pulls/4074","id":82248639,"html_url":"https://github.com/dotnet/cli/pull/4074","diff_url":"https://github.com/dotnet/cli/pull/4074.diff","patch_url":"https://github.com/dotnet/cli/pull/4074.patch","issue_url":"https://api.github.com/repos/dotnet/cli/issues/4074","number":4074,"state":"open","locked":false,"title":"ProjectJson to  CSProj Migration","user":{"login":"brthor","id":14280892,"avatar_url":"https://avatars.githubusercontent.com/u/14280892?v=3","gravatar_id":"","url":"https://api.github.com/users/brthor","html_url":"https://github.com/brthor","followers_url":"https://api.github.com/users/brthor/followers","following_url":"https://api.github.com/users/brthor/following{/other_user}","gists_url":"https://api.github.com/users/brthor/gists{/gist_id}","starred_url":"https://api.github.com/users/brthor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brthor/subscriptions","organizations_url":"https://api.github.com/users/brthor/orgs","repos_url":"https://api.github.com/users/brthor/repos","events_url":"https://api.github.com/users/brthor/events{/privacy}","received_events_url":"https://api.github.com/users/brthor/received_events","type":"User","site_admin":false},"body":"Notable features not present in this initial cut:\r\n - Script environment variables migration\r\n - Multi-TFM Support\r\n - PackOptions\r\n - `\"mappings\"` support in project.json\r\n - Migrating Globs that resolve to directories: `/some/path/**/somedir` correctly (not migrate able)\r\n - Excludes inside of a configuration that differ from excludes outside of configuration (need msbuild remove)\r\n\r\nI'm confident there are small bits of cleanup to be done here. Will fix these as we go.\r\n\r\nPlease take a look @eerhardt @davkean @piotrpMSFT @livarcocc \r\n\r\nA simple migrated app:\r\n```\r\n<?xml version=\"1.0\" encoding=\"utf-8\"?>\r\n<Project ToolsVersion=\"14.0\" xmlns=\"http://schemas.microsoft.com/developer/msbuild/2003\">\r\n  <Import Project=\"$(MSBuildExtensionsPath)\\$(MSBuildToolsVersion)\\Microsoft.Common.props\" />\r\n  <PropertyGroup />\r\n  <PropertyGroup>\r\n    <VersionPrefix>1.0.0</VersionPrefix>\r\n    <OutputPath>bin/$(Configuration)/netcoreapp1.0</OutputPath>\r\n    <TargetFrameworkIdentifier>.NETCoreApp</TargetFrameworkIdentifier>\r\n    <TargetFrameworkVersion>v1.0</TargetFrameworkVersion>\r\n    <DefineConstants>NETCOREAPP1_0</DefineConstants>\r\n    <AssemblyName>TestAppWithRuntimeOptions</AssemblyName>\r\n    <OutputType>Exe</OutputType>\r\n    <TargetExt>.dll</TargetExt>\r\n  </PropertyGroup>\r\n  <ItemGroup>\r\n    <None Include=\"project.json\" />\r\n  </ItemGroup>\r\n  <ItemGroup>\r\n    <Compile Include=\"**\\*.cs\" Exclude=\"$(GlobalExclude);bin\\**;obj\\**;**\\*.xproj;packages\\**\" />\r\n    <EmbeddedResource Include=\"**\\*.resx\" Exclude=\"$(GlobalExclude);bin\\**;obj\\**;**\\*.xproj;packages\\**\" />\r\n    <EmbeddedResource Include=\"compiler\\resources\\**\\*\" Exclude=\"bin\\**;obj\\**;**\\*.xproj;packages\\**\" />\r\n  </ItemGroup>\r\n  <PropertyGroup Condition=\" '$(Configuration)' == 'Debug' \">\r\n    <DefineConstants>DEBUG;TRACE;NETCOREAPP1_0</DefineConstants>\r\n  </PropertyGroup>\r\n  <PropertyGroup Condition=\" '$(Configuration)' == 'Release' \">\r\n    <DefineConstants>RELEASE;TRACE;NETCOREAPP1_0</DefineConstants>\r\n    <Optimize>true</Optimize>\r\n  </PropertyGroup>\r\n  <Import Project=\"$(MSBuildToolsPath)\\Microsoft.CSharp.targets\" />\r\n</Project>\r\n```","created_at":"2016-08-22T19:30:16Z","updated_at":"2016-08-23T18:57:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"057101940df97b620d7e1eec4ef50367447b4f74","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/cli/pulls/4074/commits","review_comments_url":"https://api.github.com/repos/dotnet/cli/pulls/4074/comments","review_comment_url":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/cli/issues/4074/comments","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/34f815c1ee97f12bb4c21a34e867ab26ff60380b","head":{"label":"brthor:brthor/migrate-reviewable","ref":"brthor/migrate-reviewable","sha":"34f815c1ee97f12bb4c21a34e867ab26ff60380b","user":{"login":"brthor","id":14280892,"avatar_url":"https://avatars.githubusercontent.com/u/14280892?v=3","gravatar_id":"","url":"https://api.github.com/users/brthor","html_url":"https://github.com/brthor","followers_url":"https://api.github.com/users/brthor/followers","following_url":"https://api.github.com/users/brthor/following{/other_user}","gists_url":"https://api.github.com/users/brthor/gists{/gist_id}","starred_url":"https://api.github.com/users/brthor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brthor/subscriptions","organizations_url":"https://api.github.com/users/brthor/orgs","repos_url":"https://api.github.com/users/brthor/repos","events_url":"https://api.github.com/users/brthor/events{/privacy}","received_events_url":"https://api.github.com/users/brthor/received_events","type":"User","site_admin":false},"repo":{"id":46514660,"name":"cli","full_name":"brthor/cli","owner":{"login":"brthor","id":14280892,"avatar_url":"https://avatars.githubusercontent.com/u/14280892?v=3","gravatar_id":"","url":"https://api.github.com/users/brthor","html_url":"https://github.com/brthor","followers_url":"https://api.github.com/users/brthor/followers","following_url":"https://api.github.com/users/brthor/following{/other_user}","gists_url":"https://api.github.com/users/brthor/gists{/gist_id}","starred_url":"https://api.github.com/users/brthor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brthor/subscriptions","organizations_url":"https://api.github.com/users/brthor/orgs","repos_url":"https://api.github.com/users/brthor/repos","events_url":"https://api.github.com/users/brthor/events{/privacy}","received_events_url":"https://api.github.com/users/brthor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brthor/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":true,"url":"https://api.github.com/repos/brthor/cli","forks_url":"https://api.github.com/repos/brthor/cli/forks","keys_url":"https://api.github.com/repos/brthor/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brthor/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brthor/cli/teams","hooks_url":"https://api.github.com/repos/brthor/cli/hooks","issue_events_url":"https://api.github.com/repos/brthor/cli/issues/events{/number}","events_url":"https://api.github.com/repos/brthor/cli/events","assignees_url":"https://api.github.com/repos/brthor/cli/assignees{/user}","branches_url":"https://api.github.com/repos/brthor/cli/branches{/branch}","tags_url":"https://api.github.com/repos/brthor/cli/tags","blobs_url":"https://api.github.com/repos/brthor/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brthor/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brthor/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/brthor/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brthor/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/brthor/cli/languages","stargazers_url":"https://api.github.com/repos/brthor/cli/stargazers","contributors_url":"https://api.github.com/repos/brthor/cli/contributors","subscribers_url":"https://api.github.com/repos/brthor/cli/subscribers","subscription_url":"https://api.github.com/repos/brthor/cli/subscription","commits_url":"https://api.github.com/repos/brthor/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/brthor/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/brthor/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/brthor/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/brthor/cli/contents/{+path}","compare_url":"https://api.github.com/repos/brthor/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brthor/cli/merges","archive_url":"https://api.github.com/repos/brthor/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brthor/cli/downloads","issues_url":"https://api.github.com/repos/brthor/cli/issues{/number}","pulls_url":"https://api.github.com/repos/brthor/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/brthor/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/brthor/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brthor/cli/labels{/name}","releases_url":"https://api.github.com/repos/brthor/cli/releases{/id}","deployments_url":"https://api.github.com/repos/brthor/cli/deployments","created_at":"2015-11-19T19:17:23Z","updated_at":"2016-06-01T22:27:26Z","pushed_at":"2016-08-22T21:07:13Z","git_url":"git://github.com/brthor/cli.git","ssh_url":"git@github.com:brthor/cli.git","clone_url":"https://github.com/brthor/cli.git","svn_url":"https://github.com/brthor/cli","homepage":"http://dotnet.github.io/","size":103861,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:feature/msbuild","ref":"feature/msbuild","sha":"b5e00acc15797c3df41519cffdc9a16d652dd04f","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":43568107,"name":"cli","full_name":"dotnet/cli","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":false,"url":"https://api.github.com/repos/dotnet/cli","forks_url":"https://api.github.com/repos/dotnet/cli/forks","keys_url":"https://api.github.com/repos/dotnet/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/cli/teams","hooks_url":"https://api.github.com/repos/dotnet/cli/hooks","issue_events_url":"https://api.github.com/repos/dotnet/cli/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/cli/events","assignees_url":"https://api.github.com/repos/dotnet/cli/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/cli/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/cli/tags","blobs_url":"https://api.github.com/repos/dotnet/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/cli/languages","stargazers_url":"https://api.github.com/repos/dotnet/cli/stargazers","contributors_url":"https://api.github.com/repos/dotnet/cli/contributors","subscribers_url":"https://api.github.com/repos/dotnet/cli/subscribers","subscription_url":"https://api.github.com/repos/dotnet/cli/subscription","commits_url":"https://api.github.com/repos/dotnet/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/cli/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/cli/merges","archive_url":"https://api.github.com/repos/dotnet/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/cli/downloads","issues_url":"https://api.github.com/repos/dotnet/cli/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/cli/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/cli/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/cli/deployments","created_at":"2015-10-02T18:03:15Z","updated_at":"2016-08-23T12:37:03Z","pushed_at":"2016-08-23T18:45:11Z","git_url":"git://github.com/dotnet/cli.git","ssh_url":"git@github.com:dotnet/cli.git","clone_url":"https://github.com/dotnet/cli.git","svn_url":"https://github.com/dotnet/cli","homepage":"https://docs.microsoft.com/dotnet/ ","size":119185,"stargazers_count":1379,"watchers_count":1379,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":335,"mirror_url":null,"open_issues_count":709,"forks":335,"open_issues":709,"watchers":1379,"default_branch":"rel/1.0.0"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/4074"},"html":{"href":"https://github.com/dotnet/cli/pull/4074"},"issue":{"href":"https://api.github.com/repos/dotnet/cli/issues/4074"},"comments":{"href":"https://api.github.com/repos/dotnet/cli/issues/4074/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/cli/pulls/4074/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/cli/pulls/4074/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/cli/statuses/34f815c1ee97f12bb4c21a34e867ab26ff60380b"}}}}
{"actor":{"display_login":"brthor"}}