{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/blueprint/issues/349","repository_url":"https://api.github.com/repos/palantir/blueprint","labels_url":"https://api.github.com/repos/palantir/blueprint/issues/349/labels{/name}","comments_url":"https://api.github.com/repos/palantir/blueprint/issues/349/comments","events_url":"https://api.github.com/repos/palantir/blueprint/issues/349/events","html_url":"https://github.com/palantir/blueprint/pull/349","id":194896003,"number":349,"title":"Button now accepts optional isLoading prop","user":{"login":"greglo","id":2872321,"avatar_url":"https://avatars.githubusercontent.com/u/2872321?v=3","gravatar_id":"","url":"https://api.github.com/users/greglo","html_url":"https://github.com/greglo","followers_url":"https://api.github.com/users/greglo/followers","following_url":"https://api.github.com/users/greglo/following{/other_user}","gists_url":"https://api.github.com/users/greglo/gists{/gist_id}","starred_url":"https://api.github.com/users/greglo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greglo/subscriptions","organizations_url":"https://api.github.com/users/greglo/orgs","repos_url":"https://api.github.com/users/greglo/repos","events_url":"https://api.github.com/users/greglo/events{/privacy}","received_events_url":"https://api.github.com/users/greglo/received_events","type":"User","site_admin":false},"labels":[{"id":480887469,"url":"https://api.github.com/repos/palantir/blueprint/labels/Package:%20core","name":"Package: core","color":"f5f8fa","default":false},{"id":478396701,"url":"https://api.github.com/repos/palantir/blueprint/labels/Type:%20feature%20request","name":"Type: feature request","color":"CED9E0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-12T05:53:34Z","updated_at":"2016-12-12T18:18:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/palantir/blueprint/pulls/349","html_url":"https://github.com/palantir/blueprint/pull/349","diff_url":"https://github.com/palantir/blueprint/pull/349.diff","patch_url":"https://github.com/palantir/blueprint/pull/349.patch"},"body":"#### Fixes #198\r\n\r\n### Button now accepts optional isLoading prop\r\n\r\nDefault: false\r\n\r\nIf set to true, the button will display a centered loading spinner instead of\r\nthe button contents. The size of the button will not change based on the\r\nvalue of the isLoading prop.\r\n\r\n### Disable on loading?\r\n\r\nRight now the button gets disabled if `isLoading` is set to true. At least for my own use-case that is the desired behavior, and I struggled to cook up a compelling counterexample in my head, but can believe someone might object. Thoughts?\r\n\r\n### Screenshots\r\n\r\nDefault:\r\n![image](https://cloud.githubusercontent.com/assets/2872321/21089385/81b7b946-bfec-11e6-8e95-507f889832e7.png)\r\n\r\nPrimary\r\n![image](https://cloud.githubusercontent.com/assets/2872321/21089394/8e7d763e-bfec-11e6-9dd5-2e037e57a308.png)\r\n\r\nPrimary, minimal\r\n![image](https://cloud.githubusercontent.com/assets/2872321/21089408/a53efbd6-bfec-11e6-9d79-9c5f762af747.png)\r\n\r\n\r\nDark\r\n![image](https://cloud.githubusercontent.com/assets/2872321/21089414/b543525c-bfec-11e6-8f07-4c388ae3d0bb.png)\r\n\r\nDark, primary\r\n![image](https://cloud.githubusercontent.com/assets/2872321/21089421/bd576280-bfec-11e6-9693-020bf991feb8.png)\r\n\r\nDark, primary, minimal\r\n![image](https://cloud.githubusercontent.com/assets/2872321/21089435/db062fbe-bfec-11e6-9c25-be0fe8e86f1a.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/palantir/blueprint/issues/comments/266508064","html_url":"https://github.com/palantir/blueprint/pull/349#issuecomment-266508064","issue_url":"https://api.github.com/repos/palantir/blueprint/issues/349","id":266508064,"user":{"login":"llorca","id":199754,"avatar_url":"https://avatars.githubusercontent.com/u/199754?v=3","gravatar_id":"","url":"https://api.github.com/users/llorca","html_url":"https://github.com/llorca","followers_url":"https://api.github.com/users/llorca/followers","following_url":"https://api.github.com/users/llorca/following{/other_user}","gists_url":"https://api.github.com/users/llorca/gists{/gist_id}","starred_url":"https://api.github.com/users/llorca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llorca/subscriptions","organizations_url":"https://api.github.com/users/llorca/orgs","repos_url":"https://api.github.com/users/llorca/repos","events_url":"https://api.github.com/users/llorca/events{/privacy}","received_events_url":"https://api.github.com/users/llorca/received_events","type":"User","site_admin":false},"created_at":"2016-12-12T18:18:49Z","updated_at":"2016-12-12T18:18:49Z","body":"Wow thanks for contributing this awesome little feature! I'll do a thorough review today. Looks like you even nailed the visual design (spinner coloring), major props"}}
{"actor":{"display_login":"llorca"}}