{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/7011","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/7011/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/7011/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/7011/events","html_url":"https://github.com/facebook/react-native/pull/7011","id":148811174,"number":7011,"title":"[Text] Set LayoutParams in ReactTextView to fix crash","user":{"login":"ide","id":379606,"avatar_url":"https://avatars.githubusercontent.com/u/379606?v=3","gravatar_id":"","url":"https://api.github.com/users/ide","html_url":"https://github.com/ide","followers_url":"https://api.github.com/users/ide/followers","following_url":"https://api.github.com/users/ide/following{/other_user}","gists_url":"https://api.github.com/users/ide/gists{/gist_id}","starred_url":"https://api.github.com/users/ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ide/subscriptions","organizations_url":"https://api.github.com/users/ide/orgs","repos_url":"https://api.github.com/users/ide/repos","events_url":"https://api.github.com/users/ide/events{/privacy}","received_events_url":"https://api.github.com/users/ide/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7"},{"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"dmmiller","id":4934258,"avatar_url":"https://avatars.githubusercontent.com/u/4934258?v=3","gravatar_id":"","url":"https://api.github.com/users/dmmiller","html_url":"https://github.com/dmmiller","followers_url":"https://api.github.com/users/dmmiller/followers","following_url":"https://api.github.com/users/dmmiller/following{/other_user}","gists_url":"https://api.github.com/users/dmmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/dmmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmmiller/subscriptions","organizations_url":"https://api.github.com/users/dmmiller/orgs","repos_url":"https://api.github.com/users/dmmiller/repos","events_url":"https://api.github.com/users/dmmiller/events{/privacy}","received_events_url":"https://api.github.com/users/dmmiller/received_events","type":"User","site_admin":false},"milestone":null,"comments":14,"created_at":"2016-04-16T03:00:19Z","updated_at":"2016-05-31T02:59:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/7011","html_url":"https://github.com/facebook/react-native/pull/7011","diff_url":"https://github.com/facebook/react-native/pull/7011.diff","patch_url":"https://github.com/facebook/react-native/pull/7011.patch"},"body":"ReactTextView occasionally crashes when `setText` is called. Doing some cursory research, it looks like this could be a bug in Android. We also suspect it might be related to removeClippedSubviews though.\r\n\r\nThe LayoutParams don't actually matter because RN controls layout, but on occasion (haven't narrowed down what this is...) `mLayout` is non-null and triggers relayout during `setText`, which fails because the LayoutParams are null. @jesseruder came up with this fix and it appears to be working well.\r\n\r\nStack trace: http://pastebin.com/P8VbxvPz\r\n\r\nTest Plan: Run an Android app that was sporadically crashing with the stack trace linked above. With this patch the crashes appear to have disappeared and the app is performing fine."},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/222582269","html_url":"https://github.com/facebook/react-native/pull/7011#issuecomment-222582269","issue_url":"https://api.github.com/repos/facebook/react-native/issues/7011","id":222582269,"user":{"login":"fov42550564","id":2950773,"avatar_url":"https://avatars.githubusercontent.com/u/2950773?v=3","gravatar_id":"","url":"https://api.github.com/users/fov42550564","html_url":"https://github.com/fov42550564","followers_url":"https://api.github.com/users/fov42550564/followers","following_url":"https://api.github.com/users/fov42550564/following{/other_user}","gists_url":"https://api.github.com/users/fov42550564/gists{/gist_id}","starred_url":"https://api.github.com/users/fov42550564/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fov42550564/subscriptions","organizations_url":"https://api.github.com/users/fov42550564/orgs","repos_url":"https://api.github.com/users/fov42550564/repos","events_url":"https://api.github.com/users/fov42550564/events{/privacy}","received_events_url":"https://api.github.com/users/fov42550564/received_events","type":"User","site_admin":false},"created_at":"2016-05-31T02:59:42Z","updated_at":"2016-05-31T02:59:42Z","body":"why not merge to master, newest version is crash, too"}}
{"actor":{"display_login":"fov42550564"}}