{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2325","repository_url":"https://api.github.com/repos/cfpb/cfgov-refresh","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2325/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2325/comments","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2325/events","html_url":"https://github.com/cfpb/cfgov-refresh/pull/2325","id":172189171,"number":2325,"title":"Updates backend.sh message to use envvar value","user":{"login":"anselmbradford","id":704760,"avatar_url":"https://avatars.githubusercontent.com/u/704760?v=3","gravatar_id":"","url":"https://api.github.com/users/anselmbradford","html_url":"https://github.com/anselmbradford","followers_url":"https://api.github.com/users/anselmbradford/followers","following_url":"https://api.github.com/users/anselmbradford/following{/other_user}","gists_url":"https://api.github.com/users/anselmbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/anselmbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anselmbradford/subscriptions","organizations_url":"https://api.github.com/users/anselmbradford/orgs","repos_url":"https://api.github.com/users/anselmbradford/repos","events_url":"https://api.github.com/users/anselmbradford/events{/privacy}","received_events_url":"https://api.github.com/users/anselmbradford/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"CFPBot","id":11428556,"avatar_url":"https://avatars.githubusercontent.com/u/11428556?v=3","gravatar_id":"","url":"https://api.github.com/users/CFPBot","html_url":"https://github.com/CFPBot","followers_url":"https://api.github.com/users/CFPBot/followers","following_url":"https://api.github.com/users/CFPBot/following{/other_user}","gists_url":"https://api.github.com/users/CFPBot/gists{/gist_id}","starred_url":"https://api.github.com/users/CFPBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CFPBot/subscriptions","organizations_url":"https://api.github.com/users/CFPBot/orgs","repos_url":"https://api.github.com/users/CFPBot/repos","events_url":"https://api.github.com/users/CFPBot/events{/privacy}","received_events_url":"https://api.github.com/users/CFPBot/received_events","type":"User","site_admin":false},"assignees":[{"login":"CFPBot","id":11428556,"avatar_url":"https://avatars.githubusercontent.com/u/11428556?v=3","gravatar_id":"","url":"https://api.github.com/users/CFPBot","html_url":"https://github.com/CFPBot","followers_url":"https://api.github.com/users/CFPBot/followers","following_url":"https://api.github.com/users/CFPBot/following{/other_user}","gists_url":"https://api.github.com/users/CFPBot/gists{/gist_id}","starred_url":"https://api.github.com/users/CFPBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CFPBot/subscriptions","organizations_url":"https://api.github.com/users/CFPBot/orgs","repos_url":"https://api.github.com/users/CFPBot/repos","events_url":"https://api.github.com/users/CFPBot/events{/privacy}","received_events_url":"https://api.github.com/users/CFPBot/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-08-19T18:14:30Z","updated_at":"2016-08-19T18:26:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/2325","html_url":"https://github.com/cfpb/cfgov-refresh/pull/2325","diff_url":"https://github.com/cfpb/cfgov-refresh/pull/2325.diff","patch_url":"https://github.com/cfpb/cfgov-refresh/pull/2325.patch"},"body":"## Changes\r\n\r\n- Makes `backend.sh` message about activating virtual environment use name stored in local `.env` file.\r\n\r\n## Testing\r\n\r\n- Open a new tab and cd to the project directory.\r\n- Run `deactivate` if a virtual environment was activated.\r\n- Run `./backend.sh` and see that the message tells you to activate the correct virtual environment name.\r\n- Change the value in `.env` for `VENV_NAME` and see that it changes in the output message.\r\n\r\n## Review\r\n\r\n- @richaagarwal \r\n- @chosak \r\n- @kurtrwall \r\n"},"comment":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments/241097057","html_url":"https://github.com/cfpb/cfgov-refresh/pull/2325#issuecomment-241097057","issue_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2325","id":241097057,"user":{"login":"chosak","id":654645,"avatar_url":"https://avatars.githubusercontent.com/u/654645?v=3","gravatar_id":"","url":"https://api.github.com/users/chosak","html_url":"https://github.com/chosak","followers_url":"https://api.github.com/users/chosak/followers","following_url":"https://api.github.com/users/chosak/following{/other_user}","gists_url":"https://api.github.com/users/chosak/gists{/gist_id}","starred_url":"https://api.github.com/users/chosak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chosak/subscriptions","organizations_url":"https://api.github.com/users/chosak/orgs","repos_url":"https://api.github.com/users/chosak/repos","events_url":"https://api.github.com/users/chosak/events{/privacy}","received_events_url":"https://api.github.com/users/chosak/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T18:26:44Z","updated_at":"2016-08-19T18:26:44Z","body":"This seems okay to me, with the big caveat of \"we have too many setup scripts that interact with each other in an overly complicated way\". One thing is, can we add a check before this to enforce that `VENV_NAME` is set? Since we're forcing use of `bash` in this script, we could do something like:\r\n\r\n```sh\r\n: \"${VENV_NAME?Looking for virtualenv name in \\$VENV_NAME}\"\r\n```\r\n\r\nAlthough, as I write this, part of me thinks we should just remove this variable and the suggested `workon` message from this script. It assumes that people are using `virtualenvwrapper` (which they might not be), and then adds this other dependency on an external environment variable, which really has nothing to do with what this script is actually doing."}}
{"actor":{"display_login":"chosak"}}