{"action":"created","comment":{"url":"https://api.github.com/repos/gwik/geventhttpclient/pulls/comments/74549283","id":74549283,"diff_hunk":"@@ -204,8 +204,13 @@ def _create_tcp_socket(self, family, socktype, protocol):\n                 family, socktype, protocol)\n \n             if self.ssl_context_factory is None:\n-                ssl_options = self.default_options.copy()\n-                ssl_options.update(self.ssl_options)\n+                ssl_options = {}\n+                if not self.insecure:\n+                    ssl_options = self.default_options.copy()\n+                    ssl_options.update(self.ssl_options)\n                 return gevent.ssl.wrap_socket(sock, **ssl_options)\n             else:\n+                if self.insecure:\n+                    self.ssl_options = {}","path":"src/geventhttpclient/connectionpool.py","position":13,"original_position":13,"commit_id":"ec852e79c163476b59dc50ac7b730301a293048e","original_commit_id":"ec852e79c163476b59dc50ac7b730301a293048e","user":{"login":"rmohr","id":4534621,"avatar_url":"https://avatars.githubusercontent.com/u/4534621?v=3","gravatar_id":"","url":"https://api.github.com/users/rmohr","html_url":"https://github.com/rmohr","followers_url":"https://api.github.com/users/rmohr/followers","following_url":"https://api.github.com/users/rmohr/following{/other_user}","gists_url":"https://api.github.com/users/rmohr/gists{/gist_id}","starred_url":"https://api.github.com/users/rmohr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmohr/subscriptions","organizations_url":"https://api.github.com/users/rmohr/orgs","repos_url":"https://api.github.com/users/rmohr/repos","events_url":"https://api.github.com/users/rmohr/events{/privacy}","received_events_url":"https://api.github.com/users/rmohr/received_events","type":"User","site_admin":false},"body":"The same for this flow. We don't need to override the custom flags.","created_at":"2016-08-12T07:09:18Z","updated_at":"2016-08-12T07:09:18Z","html_url":"https://github.com/gwik/geventhttpclient/pull/61#discussion_r74549283","pull_request_url":"https://api.github.com/repos/gwik/geventhttpclient/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/gwik/geventhttpclient/pulls/comments/74549283"},"html":{"href":"https://github.com/gwik/geventhttpclient/pull/61#discussion_r74549283"},"pull_request":{"href":"https://api.github.com/repos/gwik/geventhttpclient/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/gwik/geventhttpclient/pulls/61","id":28988891,"html_url":"https://github.com/gwik/geventhttpclient/pull/61","diff_url":"https://github.com/gwik/geventhttpclient/pull/61.diff","patch_url":"https://github.com/gwik/geventhttpclient/pull/61.patch","issue_url":"https://api.github.com/repos/gwik/geventhttpclient/issues/61","number":61,"state":"open","locked":false,"title":"Fix insecure flag does't work without ca_certs.","user":{"login":"charz","id":620340,"avatar_url":"https://avatars.githubusercontent.com/u/620340?v=3","gravatar_id":"","url":"https://api.github.com/users/charz","html_url":"https://github.com/charz","followers_url":"https://api.github.com/users/charz/followers","following_url":"https://api.github.com/users/charz/following{/other_user}","gists_url":"https://api.github.com/users/charz/gists{/gist_id}","starred_url":"https://api.github.com/users/charz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charz/subscriptions","organizations_url":"https://api.github.com/users/charz/orgs","repos_url":"https://api.github.com/users/charz/repos","events_url":"https://api.github.com/users/charz/events{/privacy}","received_events_url":"https://api.github.com/users/charz/received_events","type":"User","site_admin":false},"body":"When enable `insecure` in ssl_options, it should keep ssl_options is\r\nempty to ssl.wrap_socket.\r\n\r\nThe default ssl_options is enable 'ca_certs', 'ssl_version' and\r\n'cert_reqs' even if `insecure` is enabled.","created_at":"2015-02-10T08:35:10Z","updated_at":"2016-08-12T07:09:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea952f34453c5ea297b1df98528cc5f50b656547","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gwik/geventhttpclient/pulls/61/commits","review_comments_url":"https://api.github.com/repos/gwik/geventhttpclient/pulls/61/comments","review_comment_url":"https://api.github.com/repos/gwik/geventhttpclient/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gwik/geventhttpclient/issues/61/comments","statuses_url":"https://api.github.com/repos/gwik/geventhttpclient/statuses/ec852e79c163476b59dc50ac7b730301a293048e","head":{"label":"charz:fix_insecure_does_not_work","ref":"fix_insecure_does_not_work","sha":"ec852e79c163476b59dc50ac7b730301a293048e","user":{"login":"charz","id":620340,"avatar_url":"https://avatars.githubusercontent.com/u/620340?v=3","gravatar_id":"","url":"https://api.github.com/users/charz","html_url":"https://github.com/charz","followers_url":"https://api.github.com/users/charz/followers","following_url":"https://api.github.com/users/charz/following{/other_user}","gists_url":"https://api.github.com/users/charz/gists{/gist_id}","starred_url":"https://api.github.com/users/charz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charz/subscriptions","organizations_url":"https://api.github.com/users/charz/orgs","repos_url":"https://api.github.com/users/charz/repos","events_url":"https://api.github.com/users/charz/events{/privacy}","received_events_url":"https://api.github.com/users/charz/received_events","type":"User","site_admin":false},"repo":{"id":30581138,"name":"geventhttpclient","full_name":"charz/geventhttpclient","owner":{"login":"charz","id":620340,"avatar_url":"https://avatars.githubusercontent.com/u/620340?v=3","gravatar_id":"","url":"https://api.github.com/users/charz","html_url":"https://github.com/charz","followers_url":"https://api.github.com/users/charz/followers","following_url":"https://api.github.com/users/charz/following{/other_user}","gists_url":"https://api.github.com/users/charz/gists{/gist_id}","starred_url":"https://api.github.com/users/charz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charz/subscriptions","organizations_url":"https://api.github.com/users/charz/orgs","repos_url":"https://api.github.com/users/charz/repos","events_url":"https://api.github.com/users/charz/events{/privacy}","received_events_url":"https://api.github.com/users/charz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/charz/geventhttpclient","description":"A high performance, concurrent http client library for python with gevent","fork":true,"url":"https://api.github.com/repos/charz/geventhttpclient","forks_url":"https://api.github.com/repos/charz/geventhttpclient/forks","keys_url":"https://api.github.com/repos/charz/geventhttpclient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/charz/geventhttpclient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/charz/geventhttpclient/teams","hooks_url":"https://api.github.com/repos/charz/geventhttpclient/hooks","issue_events_url":"https://api.github.com/repos/charz/geventhttpclient/issues/events{/number}","events_url":"https://api.github.com/repos/charz/geventhttpclient/events","assignees_url":"https://api.github.com/repos/charz/geventhttpclient/assignees{/user}","branches_url":"https://api.github.com/repos/charz/geventhttpclient/branches{/branch}","tags_url":"https://api.github.com/repos/charz/geventhttpclient/tags","blobs_url":"https://api.github.com/repos/charz/geventhttpclient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/charz/geventhttpclient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/charz/geventhttpclient/git/refs{/sha}","trees_url":"https://api.github.com/repos/charz/geventhttpclient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/charz/geventhttpclient/statuses/{sha}","languages_url":"https://api.github.com/repos/charz/geventhttpclient/languages","stargazers_url":"https://api.github.com/repos/charz/geventhttpclient/stargazers","contributors_url":"https://api.github.com/repos/charz/geventhttpclient/contributors","subscribers_url":"https://api.github.com/repos/charz/geventhttpclient/subscribers","subscription_url":"https://api.github.com/repos/charz/geventhttpclient/subscription","commits_url":"https://api.github.com/repos/charz/geventhttpclient/commits{/sha}","git_commits_url":"https://api.github.com/repos/charz/geventhttpclient/git/commits{/sha}","comments_url":"https://api.github.com/repos/charz/geventhttpclient/comments{/number}","issue_comment_url":"https://api.github.com/repos/charz/geventhttpclient/issues/comments{/number}","contents_url":"https://api.github.com/repos/charz/geventhttpclient/contents/{+path}","compare_url":"https://api.github.com/repos/charz/geventhttpclient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/charz/geventhttpclient/merges","archive_url":"https://api.github.com/repos/charz/geventhttpclient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/charz/geventhttpclient/downloads","issues_url":"https://api.github.com/repos/charz/geventhttpclient/issues{/number}","pulls_url":"https://api.github.com/repos/charz/geventhttpclient/pulls{/number}","milestones_url":"https://api.github.com/repos/charz/geventhttpclient/milestones{/number}","notifications_url":"https://api.github.com/repos/charz/geventhttpclient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/charz/geventhttpclient/labels{/name}","releases_url":"https://api.github.com/repos/charz/geventhttpclient/releases{/id}","deployments_url":"https://api.github.com/repos/charz/geventhttpclient/deployments","created_at":"2015-02-10T07:52:29Z","updated_at":"2016-08-11T10:37:47Z","pushed_at":"2016-08-11T14:18:08Z","git_url":"git://github.com/charz/geventhttpclient.git","ssh_url":"git@github.com:charz/geventhttpclient.git","clone_url":"https://github.com/charz/geventhttpclient.git","svn_url":"https://github.com/charz/geventhttpclient","homepage":"","size":457,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gwik:master","ref":"master","sha":"34be8801718932f18c51becd71089cd0f4b9f17a","user":{"login":"gwik","id":11162,"avatar_url":"https://avatars.githubusercontent.com/u/11162?v=3","gravatar_id":"","url":"https://api.github.com/users/gwik","html_url":"https://github.com/gwik","followers_url":"https://api.github.com/users/gwik/followers","following_url":"https://api.github.com/users/gwik/following{/other_user}","gists_url":"https://api.github.com/users/gwik/gists{/gist_id}","starred_url":"https://api.github.com/users/gwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwik/subscriptions","organizations_url":"https://api.github.com/users/gwik/orgs","repos_url":"https://api.github.com/users/gwik/repos","events_url":"https://api.github.com/users/gwik/events{/privacy}","received_events_url":"https://api.github.com/users/gwik/received_events","type":"User","site_admin":false},"repo":{"id":3003791,"name":"geventhttpclient","full_name":"gwik/geventhttpclient","owner":{"login":"gwik","id":11162,"avatar_url":"https://avatars.githubusercontent.com/u/11162?v=3","gravatar_id":"","url":"https://api.github.com/users/gwik","html_url":"https://github.com/gwik","followers_url":"https://api.github.com/users/gwik/followers","following_url":"https://api.github.com/users/gwik/following{/other_user}","gists_url":"https://api.github.com/users/gwik/gists{/gist_id}","starred_url":"https://api.github.com/users/gwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwik/subscriptions","organizations_url":"https://api.github.com/users/gwik/orgs","repos_url":"https://api.github.com/users/gwik/repos","events_url":"https://api.github.com/users/gwik/events{/privacy}","received_events_url":"https://api.github.com/users/gwik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gwik/geventhttpclient","description":"A high performance, concurrent http client library for python with gevent","fork":false,"url":"https://api.github.com/repos/gwik/geventhttpclient","forks_url":"https://api.github.com/repos/gwik/geventhttpclient/forks","keys_url":"https://api.github.com/repos/gwik/geventhttpclient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gwik/geventhttpclient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gwik/geventhttpclient/teams","hooks_url":"https://api.github.com/repos/gwik/geventhttpclient/hooks","issue_events_url":"https://api.github.com/repos/gwik/geventhttpclient/issues/events{/number}","events_url":"https://api.github.com/repos/gwik/geventhttpclient/events","assignees_url":"https://api.github.com/repos/gwik/geventhttpclient/assignees{/user}","branches_url":"https://api.github.com/repos/gwik/geventhttpclient/branches{/branch}","tags_url":"https://api.github.com/repos/gwik/geventhttpclient/tags","blobs_url":"https://api.github.com/repos/gwik/geventhttpclient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gwik/geventhttpclient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gwik/geventhttpclient/git/refs{/sha}","trees_url":"https://api.github.com/repos/gwik/geventhttpclient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gwik/geventhttpclient/statuses/{sha}","languages_url":"https://api.github.com/repos/gwik/geventhttpclient/languages","stargazers_url":"https://api.github.com/repos/gwik/geventhttpclient/stargazers","contributors_url":"https://api.github.com/repos/gwik/geventhttpclient/contributors","subscribers_url":"https://api.github.com/repos/gwik/geventhttpclient/subscribers","subscription_url":"https://api.github.com/repos/gwik/geventhttpclient/subscription","commits_url":"https://api.github.com/repos/gwik/geventhttpclient/commits{/sha}","git_commits_url":"https://api.github.com/repos/gwik/geventhttpclient/git/commits{/sha}","comments_url":"https://api.github.com/repos/gwik/geventhttpclient/comments{/number}","issue_comment_url":"https://api.github.com/repos/gwik/geventhttpclient/issues/comments{/number}","contents_url":"https://api.github.com/repos/gwik/geventhttpclient/contents/{+path}","compare_url":"https://api.github.com/repos/gwik/geventhttpclient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gwik/geventhttpclient/merges","archive_url":"https://api.github.com/repos/gwik/geventhttpclient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gwik/geventhttpclient/downloads","issues_url":"https://api.github.com/repos/gwik/geventhttpclient/issues{/number}","pulls_url":"https://api.github.com/repos/gwik/geventhttpclient/pulls{/number}","milestones_url":"https://api.github.com/repos/gwik/geventhttpclient/milestones{/number}","notifications_url":"https://api.github.com/repos/gwik/geventhttpclient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gwik/geventhttpclient/labels{/name}","releases_url":"https://api.github.com/repos/gwik/geventhttpclient/releases{/id}","deployments_url":"https://api.github.com/repos/gwik/geventhttpclient/deployments","created_at":"2011-12-17T23:56:24Z","updated_at":"2016-08-10T02:36:06Z","pushed_at":"2016-08-11T21:41:56Z","git_url":"git://github.com/gwik/geventhttpclient.git","ssh_url":"git@github.com:gwik/geventhttpclient.git","clone_url":"https://github.com/gwik/geventhttpclient.git","svn_url":"https://github.com/gwik/geventhttpclient","homepage":"","size":632,"stargazers_count":286,"watchers_count":286,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":14,"forks":71,"open_issues":14,"watchers":286,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gwik/geventhttpclient/pulls/61"},"html":{"href":"https://github.com/gwik/geventhttpclient/pull/61"},"issue":{"href":"https://api.github.com/repos/gwik/geventhttpclient/issues/61"},"comments":{"href":"https://api.github.com/repos/gwik/geventhttpclient/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/gwik/geventhttpclient/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/gwik/geventhttpclient/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gwik/geventhttpclient/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/gwik/geventhttpclient/statuses/ec852e79c163476b59dc50ac7b730301a293048e"}}}}
{"actor":{"display_login":"rmohr"}}