{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/92398907","pull_request_review_id":12912663,"id":92398907,"diff_hunk":"@@ -209,6 +209,16 @@ class cosh(HyperbolicFunction):\n     sinh, tanh, acosh\n     \"\"\"\n \n+    @property\n+    def is_positive(self):\n+        if self.args[0].is_real:\n+            return True","path":"sympy/functions/elementary/hyperbolic.py","position":7,"original_position":7,"commit_id":"dd6bf0dbdb2bb151db09b0adaf70197a73a6a45b","original_commit_id":"dd6bf0dbdb2bb151db09b0adaf70197a73a6a45b","user":{"login":"jksuom","id":6929119,"avatar_url":"https://avatars.githubusercontent.com/u/6929119?v=3","gravatar_id":"","url":"https://api.github.com/users/jksuom","html_url":"https://github.com/jksuom","followers_url":"https://api.github.com/users/jksuom/followers","following_url":"https://api.github.com/users/jksuom/following{/other_user}","gists_url":"https://api.github.com/users/jksuom/gists{/gist_id}","starred_url":"https://api.github.com/users/jksuom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jksuom/subscriptions","organizations_url":"https://api.github.com/users/jksuom/orgs","repos_url":"https://api.github.com/users/jksuom/repos","events_url":"https://api.github.com/users/jksuom/events{/privacy}","received_events_url":"https://api.github.com/users/jksuom/received_events","type":"User","site_admin":false},"body":"Correction: That is not exactly wrong but there are other (non-real) argument values for which cosh is positive or negative. Perhaps this should include all of them?","created_at":"2016-12-14T14:07:34Z","updated_at":"2016-12-14T14:07:34Z","html_url":"https://github.com/sympy/sympy/pull/11924#discussion_r92398907","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/11924","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/92398907"},"html":{"href":"https://github.com/sympy/sympy/pull/11924#discussion_r92398907"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/11924"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/11924","id":97248733,"html_url":"https://github.com/sympy/sympy/pull/11924","diff_url":"https://github.com/sympy/sympy/pull/11924.diff","patch_url":"https://github.com/sympy/sympy/pull/11924.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/11924","number":11924,"state":"open","locked":false,"title":"Modified is_positive for cosh function","user":{"login":"rohitrango","id":15312514,"avatar_url":"https://avatars.githubusercontent.com/u/15312514?v=3","gravatar_id":"","url":"https://api.github.com/users/rohitrango","html_url":"https://github.com/rohitrango","followers_url":"https://api.github.com/users/rohitrango/followers","following_url":"https://api.github.com/users/rohitrango/following{/other_user}","gists_url":"https://api.github.com/users/rohitrango/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitrango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitrango/subscriptions","organizations_url":"https://api.github.com/users/rohitrango/orgs","repos_url":"https://api.github.com/users/rohitrango/repos","events_url":"https://api.github.com/users/rohitrango/events{/privacy}","received_events_url":"https://api.github.com/users/rohitrango/received_events","type":"User","site_admin":false},"body":"Fixes #11721.\r\n\r\n`cosh(x).is_positive` returns `True` if x is real.\r\nAlso modified the `Abs` function to return the function itself or its negative if the function is positive or negative.\r\n\r\nExample:\r\n```\r\nIn [1]: r=symbols('r',real=True)\r\n\r\nIn [2]: abs(cosh(x))\r\nOut[2]: │cosh(x)│\r\n\r\nIn [3]: abs(cosh(r))\r\nOut[3]: cosh(r)\r\n\r\nIn [4]: abs(cosh(r)) == cosh(r)\r\nOut[4]: True\r\n\r\nIn [5]: abs(cosh(x)) == cosh(x)\r\nOut[5]: False\r\n\r\nIn [6]: cosh(r).is_positive\r\nOut[6]: True\r\n\r\nIn [7]: cosh(x).is_positive\r\n\r\nIn [8]:      \r\n```","created_at":"2016-12-09T04:15:48Z","updated_at":"2016-12-14T14:07:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de46f877d6f1dbc2a9faf925fb12a35ce782afcf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/11924/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/11924/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/11924/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/dd6bf0dbdb2bb151db09b0adaf70197a73a6a45b","head":{"label":"rohitrango:cosh_abs_fix","ref":"cosh_abs_fix","sha":"dd6bf0dbdb2bb151db09b0adaf70197a73a6a45b","user":{"login":"rohitrango","id":15312514,"avatar_url":"https://avatars.githubusercontent.com/u/15312514?v=3","gravatar_id":"","url":"https://api.github.com/users/rohitrango","html_url":"https://github.com/rohitrango","followers_url":"https://api.github.com/users/rohitrango/followers","following_url":"https://api.github.com/users/rohitrango/following{/other_user}","gists_url":"https://api.github.com/users/rohitrango/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitrango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitrango/subscriptions","organizations_url":"https://api.github.com/users/rohitrango/orgs","repos_url":"https://api.github.com/users/rohitrango/repos","events_url":"https://api.github.com/users/rohitrango/events{/privacy}","received_events_url":"https://api.github.com/users/rohitrango/received_events","type":"User","site_admin":false},"repo":{"id":63971972,"name":"sympy","full_name":"rohitrango/sympy","owner":{"login":"rohitrango","id":15312514,"avatar_url":"https://avatars.githubusercontent.com/u/15312514?v=3","gravatar_id":"","url":"https://api.github.com/users/rohitrango","html_url":"https://github.com/rohitrango","followers_url":"https://api.github.com/users/rohitrango/followers","following_url":"https://api.github.com/users/rohitrango/following{/other_user}","gists_url":"https://api.github.com/users/rohitrango/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitrango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitrango/subscriptions","organizations_url":"https://api.github.com/users/rohitrango/orgs","repos_url":"https://api.github.com/users/rohitrango/repos","events_url":"https://api.github.com/users/rohitrango/events{/privacy}","received_events_url":"https://api.github.com/users/rohitrango/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rohitrango/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/rohitrango/sympy","forks_url":"https://api.github.com/repos/rohitrango/sympy/forks","keys_url":"https://api.github.com/repos/rohitrango/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rohitrango/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rohitrango/sympy/teams","hooks_url":"https://api.github.com/repos/rohitrango/sympy/hooks","issue_events_url":"https://api.github.com/repos/rohitrango/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/rohitrango/sympy/events","assignees_url":"https://api.github.com/repos/rohitrango/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/rohitrango/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/rohitrango/sympy/tags","blobs_url":"https://api.github.com/repos/rohitrango/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rohitrango/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rohitrango/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/rohitrango/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rohitrango/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/rohitrango/sympy/languages","stargazers_url":"https://api.github.com/repos/rohitrango/sympy/stargazers","contributors_url":"https://api.github.com/repos/rohitrango/sympy/contributors","subscribers_url":"https://api.github.com/repos/rohitrango/sympy/subscribers","subscription_url":"https://api.github.com/repos/rohitrango/sympy/subscription","commits_url":"https://api.github.com/repos/rohitrango/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/rohitrango/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/rohitrango/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/rohitrango/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/rohitrango/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/rohitrango/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rohitrango/sympy/merges","archive_url":"https://api.github.com/repos/rohitrango/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rohitrango/sympy/downloads","issues_url":"https://api.github.com/repos/rohitrango/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/rohitrango/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/rohitrango/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/rohitrango/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rohitrango/sympy/labels{/name}","releases_url":"https://api.github.com/repos/rohitrango/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/rohitrango/sympy/deployments","created_at":"2016-07-22T17:40:39Z","updated_at":"2016-07-22T17:40:46Z","pushed_at":"2016-12-14T09:05:00Z","git_url":"git://github.com/rohitrango/sympy.git","ssh_url":"git@github.com:rohitrango/sympy.git","clone_url":"https://github.com/rohitrango/sympy.git","svn_url":"https://github.com/rohitrango/sympy","homepage":"http://sympy.org/","size":76648,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"5827cafb1e1840915b3e7c9f62cd0d58fff9fc48","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","deployments_url":"https://api.github.com/repos/sympy/sympy/deployments","created_at":"2010-04-30T20:37:14Z","updated_at":"2016-12-14T06:32:30Z","pushed_at":"2016-12-14T13:24:48Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":76744,"stargazers_count":3421,"watchers_count":3421,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1713,"mirror_url":null,"open_issues_count":2686,"forks":1713,"open_issues":2686,"watchers":3421,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/11924"},"html":{"href":"https://github.com/sympy/sympy/pull/11924"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/11924"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/11924/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/11924/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/11924/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/dd6bf0dbdb2bb151db09b0adaf70197a73a6a45b"}}}}
{"actor":{"display_login":"jksuom"}}