{"action":"created","issue":{"url":"https://api.github.com/repos/lhorie/mithril.js/issues/1438","repository_url":"https://api.github.com/repos/lhorie/mithril.js","labels_url":"https://api.github.com/repos/lhorie/mithril.js/issues/1438/labels{/name}","comments_url":"https://api.github.com/repos/lhorie/mithril.js/issues/1438/comments","events_url":"https://api.github.com/repos/lhorie/mithril.js/issues/1438/events","html_url":"https://github.com/lhorie/mithril.js/issues/1438","id":192412825,"number":1438,"title":"[rewrite] Documentation of how auto redraw works","user":{"login":"inuwan","id":260190,"avatar_url":"https://avatars.githubusercontent.com/u/260190?v=3","gravatar_id":"","url":"https://api.github.com/users/inuwan","html_url":"https://github.com/inuwan","followers_url":"https://api.github.com/users/inuwan/followers","following_url":"https://api.github.com/users/inuwan/following{/other_user}","gists_url":"https://api.github.com/users/inuwan/gists{/gist_id}","starred_url":"https://api.github.com/users/inuwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inuwan/subscriptions","organizations_url":"https://api.github.com/users/inuwan/orgs","repos_url":"https://api.github.com/users/inuwan/repos","events_url":"https://api.github.com/users/inuwan/events{/privacy}","received_events_url":"https://api.github.com/users/inuwan/received_events","type":"User","site_admin":false},"labels":[{"id":193884386,"url":"https://api.github.com/repos/lhorie/mithril.js/labels/contribution%20welcome","name":"contribution welcome","color":"5319e7","default":false},{"id":394673449,"url":"https://api.github.com/repos/lhorie/mithril.js/labels/documentation","name":"documentation","color":"1d76db","default":false},{"id":362013854,"url":"https://api.github.com/repos/lhorie/mithril.js/labels/rewrite","name":"rewrite","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/lhorie/mithril.js/milestones/1","html_url":"https://github.com/lhorie/mithril.js/milestones/1.0%20(Rewrite)","labels_url":"https://api.github.com/repos/lhorie/mithril.js/milestones/1/labels","id":1835772,"number":1,"title":"1.0 (Rewrite)","description":"Issues and pull requests geared towards completing the rewrite.","creator":{"login":"isiahmeadows","id":4483844,"avatar_url":"https://avatars.githubusercontent.com/u/4483844?v=3","gravatar_id":"","url":"https://api.github.com/users/isiahmeadows","html_url":"https://github.com/isiahmeadows","followers_url":"https://api.github.com/users/isiahmeadows/followers","following_url":"https://api.github.com/users/isiahmeadows/following{/other_user}","gists_url":"https://api.github.com/users/isiahmeadows/gists{/gist_id}","starred_url":"https://api.github.com/users/isiahmeadows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isiahmeadows/subscriptions","organizations_url":"https://api.github.com/users/isiahmeadows/orgs","repos_url":"https://api.github.com/users/isiahmeadows/repos","events_url":"https://api.github.com/users/isiahmeadows/events{/privacy}","received_events_url":"https://api.github.com/users/isiahmeadows/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":34,"state":"open","created_at":"2016-06-18T08:01:00Z","updated_at":"2016-11-29T22:41:04Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-11-29T21:54:17Z","updated_at":"2016-11-30T06:45:21Z","closed_at":null,"body":"The doc for the rewrite version is very helpful.  However, one area of confusion for me (having used the v0.2.x) is how auto redraw works in the rewrite.  \r\n\r\nIn version 0.2.x, the m.request triggered a redraw if options.background = false, when the request completed.  Does m.request still trigger an auto redraw?  Looking at the source code, it seems like it doesn't?\r\n\r\nAlso m.startComputation and m.endComputation are no longer available in the rewrite,  I did not see any mention of this in the migration document.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/lhorie/mithril.js/issues/comments/263796651","html_url":"https://github.com/lhorie/mithril.js/issues/1438#issuecomment-263796651","issue_url":"https://api.github.com/repos/lhorie/mithril.js/issues/1438","id":263796651,"user":{"login":"inuwan","id":260190,"avatar_url":"https://avatars.githubusercontent.com/u/260190?v=3","gravatar_id":"","url":"https://api.github.com/users/inuwan","html_url":"https://github.com/inuwan","followers_url":"https://api.github.com/users/inuwan/followers","following_url":"https://api.github.com/users/inuwan/following{/other_user}","gists_url":"https://api.github.com/users/inuwan/gists{/gist_id}","starred_url":"https://api.github.com/users/inuwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inuwan/subscriptions","organizations_url":"https://api.github.com/users/inuwan/orgs","repos_url":"https://api.github.com/users/inuwan/repos","events_url":"https://api.github.com/users/inuwan/events{/privacy}","received_events_url":"https://api.github.com/users/inuwan/received_events","type":"User","site_admin":false},"created_at":"2016-11-30T06:45:20Z","updated_at":"2016-11-30T06:45:20Z","body":"Agree.  Was just pointing out the migration document (https://github.com/lhorie/mithril.js/blob/rewrite/docs/v1.x-migration.md) provides no mention that start/endComputation has been eliminated.\r\n\r\nFrom: tropperlabs [mailto:notifications@github.com]\r\nSent: Tuesday, November 29, 2016 6:35 PM\r\nTo: lhorie/mithril.js <mithril.js@noreply.github.com>\r\nCc: Mori, Ken <Ken_Mori@intuit.com>; Mention <mention@noreply.github.com>\r\nSubject: Re: [lhorie/mithril.js] [rewrite] Documentation of how auto redraw works (#1438)\r\n\r\n\r\n@inuwan<https://github.com/inuwan> What is your use case for m.start|endCompuation? I brought this up in gitter a while ago and was told it was code smell<https://gitter.im/lhorie/mithril.js?at=577eacb8b79455146f5e46ff>.\r\n\r\nI build web-view based mobile apps that mirror native components with mithril 0.2. It has been necessary to be aware of every redraw to ensure a smooth user experience. Even a single excess redraw could cause an animation or transition to perform poorly. start|endComputation was essential to preventing these issues.\r\n\r\nI was told this will not be a problem in 1.0. I have my doubts, but I am starting on the 1.0 port tonight.\r\n\r\n—\r\nYou are receiving this because you were mentioned.\r\nReply to this email directly, view it on GitHub<https://github.com/lhorie/mithril.js/issues/1438#issuecomment-263765677>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAP4XpGZMycG93WklFGykklwSplEOWtAks5rDODFgaJpZM4K_iJH>.\r\n"}}
{"actor":{"display_login":"inuwan"}}