{"action":"created","issue":{"url":"https://api.github.com/repos/GlowstoneMC/Glowstone/issues/304","repository_url":"https://api.github.com/repos/GlowstoneMC/Glowstone","labels_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/issues/304/labels{/name}","comments_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/issues/304/comments","events_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/issues/304/events","html_url":"https://github.com/GlowstoneMC/Glowstone/pull/304","id":162026281,"number":304,"title":"Added support for legacy pings/queries.","user":{"login":"GreenBeard","id":2000704,"avatar_url":"https://avatars.githubusercontent.com/u/2000704?v=3","gravatar_id":"","url":"https://api.github.com/users/GreenBeard","html_url":"https://github.com/GreenBeard","followers_url":"https://api.github.com/users/GreenBeard/followers","following_url":"https://api.github.com/users/GreenBeard/following{/other_user}","gists_url":"https://api.github.com/users/GreenBeard/gists{/gist_id}","starred_url":"https://api.github.com/users/GreenBeard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GreenBeard/subscriptions","organizations_url":"https://api.github.com/users/GreenBeard/orgs","repos_url":"https://api.github.com/users/GreenBeard/repos","events_url":"https://api.github.com/users/GreenBeard/events{/privacy}","received_events_url":"https://api.github.com/users/GreenBeard/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-06-23T21:22:06Z","updated_at":"2016-06-29T00:20:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GlowstoneMC/Glowstone/pulls/304","html_url":"https://github.com/GlowstoneMC/Glowstone/pull/304","diff_url":"https://github.com/GlowstoneMC/Glowstone/pull/304.diff","patch_url":"https://github.com/GlowstoneMC/Glowstone/pull/304.patch"},"body":"This pull request is intended to add support for legacy pings/queries. These come mostly from automated scripts that use the simpler form of pinging compared to the more modern complicated method.\r\n\r\nThe [WIP] tag is because I was not sure if there was a better method to get the instance of GlowServer in LegacyPingHandler.channelRead than to add another method to GlowNetworkServer. Any comments on these would be appreciated.\r\n\r\n~~Also I would like to warn that the normal notchian servers have less checks on legacy pings than this. Specifically in the `case 1` switch block (line 49 of LegacyPingHandler), they don't check if the second byte is 0x01 (they just check if it has a second byte) while this implementation does. If others believe that I should do exactly what the notchian server does I will revise it to do so.~~\r\n\r\nThis pull request should address #186."},"comment":{"url":"https://api.github.com/repos/GlowstoneMC/Glowstone/issues/comments/229222512","html_url":"https://github.com/GlowstoneMC/Glowstone/pull/304#issuecomment-229222512","issue_url":"https://api.github.com/repos/GlowstoneMC/Glowstone/issues/304","id":229222512,"user":{"login":"kamcio96","id":1339911,"avatar_url":"https://avatars.githubusercontent.com/u/1339911?v=3","gravatar_id":"","url":"https://api.github.com/users/kamcio96","html_url":"https://github.com/kamcio96","followers_url":"https://api.github.com/users/kamcio96/followers","following_url":"https://api.github.com/users/kamcio96/following{/other_user}","gists_url":"https://api.github.com/users/kamcio96/gists{/gist_id}","starred_url":"https://api.github.com/users/kamcio96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamcio96/subscriptions","organizations_url":"https://api.github.com/users/kamcio96/orgs","repos_url":"https://api.github.com/users/kamcio96/repos","events_url":"https://api.github.com/users/kamcio96/events{/privacy}","received_events_url":"https://api.github.com/users/kamcio96/received_events","type":"User","site_admin":false},"created_at":"2016-06-29T00:20:25Z","updated_at":"2016-06-29T00:20:25Z","body":"@greenbeard you shouldn't call it from netty thread(I know bukkit does it). You can add boolean or other field to StatusRequest packet, named legacy. Decode it in your channel handler and then handle like other packets. "}}
{"actor":{"display_login":"kamcio96"}}