{"action":"created","comment":{"url":"https://api.github.com/repos/libssh2/libssh2/pulls/comments/86673373","pull_request_review_id":7321803,"id":86673373,"diff_hunk":"@@ -98,6 +98,44 @@\n             }                                                              \\\n     }\n \n+/*\n+ * Generic Diffie-Hellman computation support.\n+ *\n+ * DH context should be a _libssh2_bn *.\n+ */\n+\n+#ifndef libssh2_dh_key_pair","path":"src/kex.c","position":10,"original_position":10,"commit_id":"0b482a378f23d82b4dca104373d341bb423e501a","original_commit_id":"0b482a378f23d82b4dca104373d341bb423e501a","user":{"login":"alamaison","id":596743,"avatar_url":"https://avatars.githubusercontent.com/u/596743?v=3","gravatar_id":"","url":"https://api.github.com/users/alamaison","html_url":"https://github.com/alamaison","followers_url":"https://api.github.com/users/alamaison/followers","following_url":"https://api.github.com/users/alamaison/following{/other_user}","gists_url":"https://api.github.com/users/alamaison/gists{/gist_id}","starred_url":"https://api.github.com/users/alamaison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alamaison/subscriptions","organizations_url":"https://api.github.com/users/alamaison/orgs","repos_url":"https://api.github.com/users/alamaison/repos","events_url":"https://api.github.com/users/alamaison/events{/privacy}","received_events_url":"https://api.github.com/users/alamaison/received_events","type":"User","site_admin":false},"body":"> Would'nt it be then preferable to implement both phases of Diffie-Hellman computation + constructor/destructor as crypto backend specific procedures\r\n\r\nYes, that makes sense to me.  Sorry for the long delay in responding","created_at":"2016-11-05T21:10:14Z","updated_at":"2016-11-05T21:10:14Z","html_url":"https://github.com/libssh2/libssh2/pull/118#discussion_r86673373","pull_request_url":"https://api.github.com/repos/libssh2/libssh2/pulls/118","_links":{"self":{"href":"https://api.github.com/repos/libssh2/libssh2/pulls/comments/86673373"},"html":{"href":"https://github.com/libssh2/libssh2/pull/118#discussion_r86673373"},"pull_request":{"href":"https://api.github.com/repos/libssh2/libssh2/pulls/118"}}},"pull_request":{"url":"https://api.github.com/repos/libssh2/libssh2/pulls/118","id":79411160,"html_url":"https://github.com/libssh2/libssh2/pull/118","diff_url":"https://github.com/libssh2/libssh2/pull/118.diff","patch_url":"https://github.com/libssh2/libssh2/pull/118.patch","issue_url":"https://api.github.com/repos/libssh2/libssh2/issues/118","number":118,"state":"open","locked":false,"title":"Make libssh2 work again on os400.","user":{"login":"monnerat","id":227821,"avatar_url":"https://avatars.githubusercontent.com/u/227821?v=3","gravatar_id":"","url":"https://api.github.com/users/monnerat","html_url":"https://github.com/monnerat","followers_url":"https://api.github.com/users/monnerat/followers","following_url":"https://api.github.com/users/monnerat/following{/other_user}","gists_url":"https://api.github.com/users/monnerat/gists{/gist_id}","starred_url":"https://api.github.com/users/monnerat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monnerat/subscriptions","organizations_url":"https://api.github.com/users/monnerat/orgs","repos_url":"https://api.github.com/users/monnerat/repos","events_url":"https://api.github.com/users/monnerat/events{/privacy}","received_events_url":"https://api.github.com/users/monnerat/received_events","type":"User","site_admin":false},"body":"Hi,\n\nThe CVE-2016-0787 fixes broke libssh2 on os400.\nThis pull request makes it work again.\nSee comment of commit 0b482a378f23d82b4dca104373d341bb423e501a and HACKING.CRYPTO for more information.\n\nI tested it successfully with all crypto backends except wincng (not tested).\n\nThanks for pulling,\n\nPatrick\n","created_at":"2016-07-29T19:27:51Z","updated_at":"2016-11-05T21:10:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"185fb3a3ccc978c87e61e539cb797b72cdddea03","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/libssh2/libssh2/pulls/118/commits","review_comments_url":"https://api.github.com/repos/libssh2/libssh2/pulls/118/comments","review_comment_url":"https://api.github.com/repos/libssh2/libssh2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libssh2/libssh2/issues/118/comments","statuses_url":"https://api.github.com/repos/libssh2/libssh2/statuses/0b482a378f23d82b4dca104373d341bb423e501a","head":{"label":"monnerat:master","ref":"master","sha":"0b482a378f23d82b4dca104373d341bb423e501a","user":{"login":"monnerat","id":227821,"avatar_url":"https://avatars.githubusercontent.com/u/227821?v=3","gravatar_id":"","url":"https://api.github.com/users/monnerat","html_url":"https://github.com/monnerat","followers_url":"https://api.github.com/users/monnerat/followers","following_url":"https://api.github.com/users/monnerat/following{/other_user}","gists_url":"https://api.github.com/users/monnerat/gists{/gist_id}","starred_url":"https://api.github.com/users/monnerat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monnerat/subscriptions","organizations_url":"https://api.github.com/users/monnerat/orgs","repos_url":"https://api.github.com/users/monnerat/repos","events_url":"https://api.github.com/users/monnerat/events{/privacy}","received_events_url":"https://api.github.com/users/monnerat/received_events","type":"User","site_admin":false},"repo":{"id":64470670,"name":"libssh2","full_name":"monnerat/libssh2","owner":{"login":"monnerat","id":227821,"avatar_url":"https://avatars.githubusercontent.com/u/227821?v=3","gravatar_id":"","url":"https://api.github.com/users/monnerat","html_url":"https://github.com/monnerat","followers_url":"https://api.github.com/users/monnerat/followers","following_url":"https://api.github.com/users/monnerat/following{/other_user}","gists_url":"https://api.github.com/users/monnerat/gists{/gist_id}","starred_url":"https://api.github.com/users/monnerat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monnerat/subscriptions","organizations_url":"https://api.github.com/users/monnerat/orgs","repos_url":"https://api.github.com/users/monnerat/repos","events_url":"https://api.github.com/users/monnerat/events{/privacy}","received_events_url":"https://api.github.com/users/monnerat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/monnerat/libssh2","description":"the SSH library","fork":true,"url":"https://api.github.com/repos/monnerat/libssh2","forks_url":"https://api.github.com/repos/monnerat/libssh2/forks","keys_url":"https://api.github.com/repos/monnerat/libssh2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monnerat/libssh2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monnerat/libssh2/teams","hooks_url":"https://api.github.com/repos/monnerat/libssh2/hooks","issue_events_url":"https://api.github.com/repos/monnerat/libssh2/issues/events{/number}","events_url":"https://api.github.com/repos/monnerat/libssh2/events","assignees_url":"https://api.github.com/repos/monnerat/libssh2/assignees{/user}","branches_url":"https://api.github.com/repos/monnerat/libssh2/branches{/branch}","tags_url":"https://api.github.com/repos/monnerat/libssh2/tags","blobs_url":"https://api.github.com/repos/monnerat/libssh2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monnerat/libssh2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monnerat/libssh2/git/refs{/sha}","trees_url":"https://api.github.com/repos/monnerat/libssh2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monnerat/libssh2/statuses/{sha}","languages_url":"https://api.github.com/repos/monnerat/libssh2/languages","stargazers_url":"https://api.github.com/repos/monnerat/libssh2/stargazers","contributors_url":"https://api.github.com/repos/monnerat/libssh2/contributors","subscribers_url":"https://api.github.com/repos/monnerat/libssh2/subscribers","subscription_url":"https://api.github.com/repos/monnerat/libssh2/subscription","commits_url":"https://api.github.com/repos/monnerat/libssh2/commits{/sha}","git_commits_url":"https://api.github.com/repos/monnerat/libssh2/git/commits{/sha}","comments_url":"https://api.github.com/repos/monnerat/libssh2/comments{/number}","issue_comment_url":"https://api.github.com/repos/monnerat/libssh2/issues/comments{/number}","contents_url":"https://api.github.com/repos/monnerat/libssh2/contents/{+path}","compare_url":"https://api.github.com/repos/monnerat/libssh2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monnerat/libssh2/merges","archive_url":"https://api.github.com/repos/monnerat/libssh2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monnerat/libssh2/downloads","issues_url":"https://api.github.com/repos/monnerat/libssh2/issues{/number}","pulls_url":"https://api.github.com/repos/monnerat/libssh2/pulls{/number}","milestones_url":"https://api.github.com/repos/monnerat/libssh2/milestones{/number}","notifications_url":"https://api.github.com/repos/monnerat/libssh2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monnerat/libssh2/labels{/name}","releases_url":"https://api.github.com/repos/monnerat/libssh2/releases{/id}","deployments_url":"https://api.github.com/repos/monnerat/libssh2/deployments","created_at":"2016-07-29T09:57:38Z","updated_at":"2016-07-29T09:57:40Z","pushed_at":"2016-07-29T19:14:33Z","git_url":"git://github.com/monnerat/libssh2.git","ssh_url":"git@github.com:monnerat/libssh2.git","clone_url":"https://github.com/monnerat/libssh2.git","svn_url":"https://github.com/monnerat/libssh2","homepage":"https://www.libssh2.org/","size":2198,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libssh2:master","ref":"master","sha":"7934c9ce2a029c43e3642a492d3b9e494d1542be","user":{"login":"libssh2","id":11430937,"avatar_url":"https://avatars.githubusercontent.com/u/11430937?v=3","gravatar_id":"","url":"https://api.github.com/users/libssh2","html_url":"https://github.com/libssh2","followers_url":"https://api.github.com/users/libssh2/followers","following_url":"https://api.github.com/users/libssh2/following{/other_user}","gists_url":"https://api.github.com/users/libssh2/gists{/gist_id}","starred_url":"https://api.github.com/users/libssh2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libssh2/subscriptions","organizations_url":"https://api.github.com/users/libssh2/orgs","repos_url":"https://api.github.com/users/libssh2/repos","events_url":"https://api.github.com/users/libssh2/events{/privacy}","received_events_url":"https://api.github.com/users/libssh2/received_events","type":"Organization","site_admin":false},"repo":{"id":31701703,"name":"libssh2","full_name":"libssh2/libssh2","owner":{"login":"libssh2","id":11430937,"avatar_url":"https://avatars.githubusercontent.com/u/11430937?v=3","gravatar_id":"","url":"https://api.github.com/users/libssh2","html_url":"https://github.com/libssh2","followers_url":"https://api.github.com/users/libssh2/followers","following_url":"https://api.github.com/users/libssh2/following{/other_user}","gists_url":"https://api.github.com/users/libssh2/gists{/gist_id}","starred_url":"https://api.github.com/users/libssh2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libssh2/subscriptions","organizations_url":"https://api.github.com/users/libssh2/orgs","repos_url":"https://api.github.com/users/libssh2/repos","events_url":"https://api.github.com/users/libssh2/events{/privacy}","received_events_url":"https://api.github.com/users/libssh2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libssh2/libssh2","description":"the SSH library","fork":false,"url":"https://api.github.com/repos/libssh2/libssh2","forks_url":"https://api.github.com/repos/libssh2/libssh2/forks","keys_url":"https://api.github.com/repos/libssh2/libssh2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libssh2/libssh2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libssh2/libssh2/teams","hooks_url":"https://api.github.com/repos/libssh2/libssh2/hooks","issue_events_url":"https://api.github.com/repos/libssh2/libssh2/issues/events{/number}","events_url":"https://api.github.com/repos/libssh2/libssh2/events","assignees_url":"https://api.github.com/repos/libssh2/libssh2/assignees{/user}","branches_url":"https://api.github.com/repos/libssh2/libssh2/branches{/branch}","tags_url":"https://api.github.com/repos/libssh2/libssh2/tags","blobs_url":"https://api.github.com/repos/libssh2/libssh2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libssh2/libssh2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libssh2/libssh2/git/refs{/sha}","trees_url":"https://api.github.com/repos/libssh2/libssh2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libssh2/libssh2/statuses/{sha}","languages_url":"https://api.github.com/repos/libssh2/libssh2/languages","stargazers_url":"https://api.github.com/repos/libssh2/libssh2/stargazers","contributors_url":"https://api.github.com/repos/libssh2/libssh2/contributors","subscribers_url":"https://api.github.com/repos/libssh2/libssh2/subscribers","subscription_url":"https://api.github.com/repos/libssh2/libssh2/subscription","commits_url":"https://api.github.com/repos/libssh2/libssh2/commits{/sha}","git_commits_url":"https://api.github.com/repos/libssh2/libssh2/git/commits{/sha}","comments_url":"https://api.github.com/repos/libssh2/libssh2/comments{/number}","issue_comment_url":"https://api.github.com/repos/libssh2/libssh2/issues/comments{/number}","contents_url":"https://api.github.com/repos/libssh2/libssh2/contents/{+path}","compare_url":"https://api.github.com/repos/libssh2/libssh2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libssh2/libssh2/merges","archive_url":"https://api.github.com/repos/libssh2/libssh2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libssh2/libssh2/downloads","issues_url":"https://api.github.com/repos/libssh2/libssh2/issues{/number}","pulls_url":"https://api.github.com/repos/libssh2/libssh2/pulls{/number}","milestones_url":"https://api.github.com/repos/libssh2/libssh2/milestones{/number}","notifications_url":"https://api.github.com/repos/libssh2/libssh2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libssh2/libssh2/labels{/name}","releases_url":"https://api.github.com/repos/libssh2/libssh2/releases{/id}","deployments_url":"https://api.github.com/repos/libssh2/libssh2/deployments","created_at":"2015-03-05T07:38:30Z","updated_at":"2016-11-03T12:31:10Z","pushed_at":"2016-11-05T21:05:22Z","git_url":"git://github.com/libssh2/libssh2.git","ssh_url":"git@github.com:libssh2/libssh2.git","clone_url":"https://github.com/libssh2/libssh2.git","svn_url":"https://github.com/libssh2/libssh2","homepage":"https://www.libssh2.org/","size":3183,"stargazers_count":131,"watchers_count":131,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":109,"mirror_url":null,"open_issues_count":45,"forks":109,"open_issues":45,"watchers":131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libssh2/libssh2/pulls/118"},"html":{"href":"https://github.com/libssh2/libssh2/pull/118"},"issue":{"href":"https://api.github.com/repos/libssh2/libssh2/issues/118"},"comments":{"href":"https://api.github.com/repos/libssh2/libssh2/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/libssh2/libssh2/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/libssh2/libssh2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libssh2/libssh2/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/libssh2/libssh2/statuses/0b482a378f23d82b4dca104373d341bb423e501a"}}}}
{"actor":{"display_login":"alamaison"}}