{"action":"created","comment":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments/81277088","pull_request_review_id":2268069,"id":81277088,"diff_hunk":"@@ -40,17 +40,20 @@\n     private RenderTaskListGenerator taskListGenerator; // TODO: investigate ways to remove nodes influence on taskList\n     private boolean enabled = true;\n \n-    protected FBO requiresFBO(FBOConfig fboConfig, BaseFBOsManager frameBuffersManager) {\n+    public void initialise(Object initialData) { } // added here to avoid adding it to all other nodes.","path":"engine/src/main/java/org/terasology/rendering/dag/AbstractNode.java","position":5,"original_position":5,"commit_id":"5c19879bbe6f5047d0f8dfcaeb604e71eb9b683b","original_commit_id":"5c19879bbe6f5047d0f8dfcaeb604e71eb9b683b","user":{"login":"Cervator","id":1063833,"avatar_url":"https://avatars.githubusercontent.com/u/1063833?v=3","gravatar_id":"","url":"https://api.github.com/users/Cervator","html_url":"https://github.com/Cervator","followers_url":"https://api.github.com/users/Cervator/followers","following_url":"https://api.github.com/users/Cervator/following{/other_user}","gists_url":"https://api.github.com/users/Cervator/gists{/gist_id}","starred_url":"https://api.github.com/users/Cervator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cervator/subscriptions","organizations_url":"https://api.github.com/users/Cervator/orgs","repos_url":"https://api.github.com/users/Cervator/repos","events_url":"https://api.github.com/users/Cervator/events{/privacy}","received_events_url":"https://api.github.com/users/Cervator/received_events","type":"User","site_admin":false},"body":"Will try to test out the branch here over the weekend then, if @tdgunes (moving IRL right now?) or @indianajohn don't beat me to it :-)","created_at":"2016-09-30T04:33:34Z","updated_at":"2016-09-30T04:33:34Z","html_url":"https://github.com/MovingBlocks/Terasology/pull/2491#discussion_r81277088","pull_request_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2491","_links":{"self":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments/81277088"},"html":{"href":"https://github.com/MovingBlocks/Terasology/pull/2491#discussion_r81277088"},"pull_request":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2491"}}},"pull_request":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2491","id":87212258,"html_url":"https://github.com/MovingBlocks/Terasology/pull/2491","diff_url":"https://github.com/MovingBlocks/Terasology/pull/2491.diff","patch_url":"https://github.com/MovingBlocks/Terasology/pull/2491.patch","issue_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2491","number":2491,"state":"open","locked":false,"title":"Rendering engine: refactored 2 nodes + new node type","user":{"login":"emanuele3d","id":6934584,"avatar_url":"https://avatars.githubusercontent.com/u/6934584?v=3","gravatar_id":"","url":"https://api.github.com/users/emanuele3d","html_url":"https://github.com/emanuele3d","followers_url":"https://api.github.com/users/emanuele3d/followers","following_url":"https://api.github.com/users/emanuele3d/following{/other_user}","gists_url":"https://api.github.com/users/emanuele3d/gists{/gist_id}","starred_url":"https://api.github.com/users/emanuele3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanuele3d/subscriptions","organizations_url":"https://api.github.com/users/emanuele3d/orgs","repos_url":"https://api.github.com/users/emanuele3d/repos","events_url":"https://api.github.com/users/emanuele3d/events{/privacy}","received_events_url":"https://api.github.com/users/emanuele3d/received_events","type":"User","site_admin":false},"body":"**WARNING! NOT FOR MERGE**: introduces a bug. See below.\r\n\r\n### Contains\r\n* Refactored ShadowMapNode to fully take advantage of the new architecture\r\n* Refactored WorldReflectionNode by extracting a new BackdropReflectionNode class from it, both taking advantage of the new architecture.\r\n* Added and using a new BufferClearingNode class\r\n* Added a new NodeFactory.createInstance(Class<T>, Object) method to allow passing initial data to the new Node.initialise(Object) method.\r\n* Changed FBOConfig class to hold information about the fbo manager to be associated with a given FBO. \r\n\r\n### How to test\r\n\r\n* Start Terasology\r\n* Create/Load a game\r\n* try changing Video Settings / Shadows\r\n* try changing Video Settings / Water Reflections\r\n* everything should look unchanged\r\n\r\n### Outstanding before merging\r\nAt this stage this PR and in particular commit e737750e introduce a bug: when the Water Reflections are set to \"Sky Only\" the sky goes grey. This is probably due to the interactions between the old rendering engine architecture and the new one, as some nodes are still using the old architecture.\r\n\r\nI intend to fix this bug before we merge this. However, most if not all the changes already visible in this PR are likely to be left untouched by the debugging process and I thought we could start the review process already.\r\n\r\n\r\n","created_at":"2016-09-28T22:15:49Z","updated_at":"2016-09-30T04:33:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b29c40c0c1d6f29e95d38c9ff3e57ea806a503c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2491/commits","review_comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2491/comments","review_comment_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2491/comments","statuses_url":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/5c19879bbe6f5047d0f8dfcaeb604e71eb9b683b","head":{"label":"emanuele3d:WorkOnShadowMapNode_rebased","ref":"WorkOnShadowMapNode_rebased","sha":"5c19879bbe6f5047d0f8dfcaeb604e71eb9b683b","user":{"login":"emanuele3d","id":6934584,"avatar_url":"https://avatars.githubusercontent.com/u/6934584?v=3","gravatar_id":"","url":"https://api.github.com/users/emanuele3d","html_url":"https://github.com/emanuele3d","followers_url":"https://api.github.com/users/emanuele3d/followers","following_url":"https://api.github.com/users/emanuele3d/following{/other_user}","gists_url":"https://api.github.com/users/emanuele3d/gists{/gist_id}","starred_url":"https://api.github.com/users/emanuele3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanuele3d/subscriptions","organizations_url":"https://api.github.com/users/emanuele3d/orgs","repos_url":"https://api.github.com/users/emanuele3d/repos","events_url":"https://api.github.com/users/emanuele3d/events{/privacy}","received_events_url":"https://api.github.com/users/emanuele3d/received_events","type":"User","site_admin":false},"repo":{"id":18476733,"name":"Terasology","full_name":"emanuele3d/Terasology","owner":{"login":"emanuele3d","id":6934584,"avatar_url":"https://avatars.githubusercontent.com/u/6934584?v=3","gravatar_id":"","url":"https://api.github.com/users/emanuele3d","html_url":"https://github.com/emanuele3d","followers_url":"https://api.github.com/users/emanuele3d/followers","following_url":"https://api.github.com/users/emanuele3d/following{/other_user}","gists_url":"https://api.github.com/users/emanuele3d/gists{/gist_id}","starred_url":"https://api.github.com/users/emanuele3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanuele3d/subscriptions","organizations_url":"https://api.github.com/users/emanuele3d/orgs","repos_url":"https://api.github.com/users/emanuele3d/repos","events_url":"https://api.github.com/users/emanuele3d/events{/privacy}","received_events_url":"https://api.github.com/users/emanuele3d/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emanuele3d/Terasology","description":"Terasology is an open source project started by Benjamin \"begla\" Glatzel to research procedural terrain generation and efficient rendering techniques in Java using the LWJGL. The engine uses a block-based voxel-like approach as seen in Minecraft.  After proving itself as a solid tech demo begla was joined at first by Anton \"small-jeeper\" Kireev and Rasmus \"Cervator\" Praestholm and a full-fledged game concept was born. Our goal is a game that pays ample tribute to Minecraft in initial look and origin, but stakes out its own niche by adopting the NPC-helper and caretaker feel from such games as Dwarf Fortress and Dungeon Keeper, while striving for added depth and sophistication in the foundation systems akin to DF.","fork":true,"url":"https://api.github.com/repos/emanuele3d/Terasology","forks_url":"https://api.github.com/repos/emanuele3d/Terasology/forks","keys_url":"https://api.github.com/repos/emanuele3d/Terasology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emanuele3d/Terasology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emanuele3d/Terasology/teams","hooks_url":"https://api.github.com/repos/emanuele3d/Terasology/hooks","issue_events_url":"https://api.github.com/repos/emanuele3d/Terasology/issues/events{/number}","events_url":"https://api.github.com/repos/emanuele3d/Terasology/events","assignees_url":"https://api.github.com/repos/emanuele3d/Terasology/assignees{/user}","branches_url":"https://api.github.com/repos/emanuele3d/Terasology/branches{/branch}","tags_url":"https://api.github.com/repos/emanuele3d/Terasology/tags","blobs_url":"https://api.github.com/repos/emanuele3d/Terasology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emanuele3d/Terasology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emanuele3d/Terasology/git/refs{/sha}","trees_url":"https://api.github.com/repos/emanuele3d/Terasology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emanuele3d/Terasology/statuses/{sha}","languages_url":"https://api.github.com/repos/emanuele3d/Terasology/languages","stargazers_url":"https://api.github.com/repos/emanuele3d/Terasology/stargazers","contributors_url":"https://api.github.com/repos/emanuele3d/Terasology/contributors","subscribers_url":"https://api.github.com/repos/emanuele3d/Terasology/subscribers","subscription_url":"https://api.github.com/repos/emanuele3d/Terasology/subscription","commits_url":"https://api.github.com/repos/emanuele3d/Terasology/commits{/sha}","git_commits_url":"https://api.github.com/repos/emanuele3d/Terasology/git/commits{/sha}","comments_url":"https://api.github.com/repos/emanuele3d/Terasology/comments{/number}","issue_comment_url":"https://api.github.com/repos/emanuele3d/Terasology/issues/comments{/number}","contents_url":"https://api.github.com/repos/emanuele3d/Terasology/contents/{+path}","compare_url":"https://api.github.com/repos/emanuele3d/Terasology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emanuele3d/Terasology/merges","archive_url":"https://api.github.com/repos/emanuele3d/Terasology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emanuele3d/Terasology/downloads","issues_url":"https://api.github.com/repos/emanuele3d/Terasology/issues{/number}","pulls_url":"https://api.github.com/repos/emanuele3d/Terasology/pulls{/number}","milestones_url":"https://api.github.com/repos/emanuele3d/Terasology/milestones{/number}","notifications_url":"https://api.github.com/repos/emanuele3d/Terasology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emanuele3d/Terasology/labels{/name}","releases_url":"https://api.github.com/repos/emanuele3d/Terasology/releases{/id}","deployments_url":"https://api.github.com/repos/emanuele3d/Terasology/deployments","created_at":"2014-04-05T21:11:26Z","updated_at":"2015-04-12T09:51:25Z","pushed_at":"2016-09-28T21:42:38Z","git_url":"git://github.com/emanuele3d/Terasology.git","ssh_url":"git@github.com:emanuele3d/Terasology.git","clone_url":"https://github.com/emanuele3d/Terasology.git","svn_url":"https://github.com/emanuele3d/Terasology","homepage":"http://terasology.org/","size":210468,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"MovingBlocks:develop","ref":"develop","sha":"4e0c6b0d9b0b77e4572de3decc18338bbfc2b48f","user":{"login":"MovingBlocks","id":1292442,"avatar_url":"https://avatars.githubusercontent.com/u/1292442?v=3","gravatar_id":"","url":"https://api.github.com/users/MovingBlocks","html_url":"https://github.com/MovingBlocks","followers_url":"https://api.github.com/users/MovingBlocks/followers","following_url":"https://api.github.com/users/MovingBlocks/following{/other_user}","gists_url":"https://api.github.com/users/MovingBlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/MovingBlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MovingBlocks/subscriptions","organizations_url":"https://api.github.com/users/MovingBlocks/orgs","repos_url":"https://api.github.com/users/MovingBlocks/repos","events_url":"https://api.github.com/users/MovingBlocks/events{/privacy}","received_events_url":"https://api.github.com/users/MovingBlocks/received_events","type":"Organization","site_admin":false},"repo":{"id":1438007,"name":"Terasology","full_name":"MovingBlocks/Terasology","owner":{"login":"MovingBlocks","id":1292442,"avatar_url":"https://avatars.githubusercontent.com/u/1292442?v=3","gravatar_id":"","url":"https://api.github.com/users/MovingBlocks","html_url":"https://github.com/MovingBlocks","followers_url":"https://api.github.com/users/MovingBlocks/followers","following_url":"https://api.github.com/users/MovingBlocks/following{/other_user}","gists_url":"https://api.github.com/users/MovingBlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/MovingBlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MovingBlocks/subscriptions","organizations_url":"https://api.github.com/users/MovingBlocks/orgs","repos_url":"https://api.github.com/users/MovingBlocks/repos","events_url":"https://api.github.com/users/MovingBlocks/events{/privacy}","received_events_url":"https://api.github.com/users/MovingBlocks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MovingBlocks/Terasology","description":"Terasology - open source voxel world","fork":false,"url":"https://api.github.com/repos/MovingBlocks/Terasology","forks_url":"https://api.github.com/repos/MovingBlocks/Terasology/forks","keys_url":"https://api.github.com/repos/MovingBlocks/Terasology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MovingBlocks/Terasology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MovingBlocks/Terasology/teams","hooks_url":"https://api.github.com/repos/MovingBlocks/Terasology/hooks","issue_events_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/events{/number}","events_url":"https://api.github.com/repos/MovingBlocks/Terasology/events","assignees_url":"https://api.github.com/repos/MovingBlocks/Terasology/assignees{/user}","branches_url":"https://api.github.com/repos/MovingBlocks/Terasology/branches{/branch}","tags_url":"https://api.github.com/repos/MovingBlocks/Terasology/tags","blobs_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/refs{/sha}","trees_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/{sha}","languages_url":"https://api.github.com/repos/MovingBlocks/Terasology/languages","stargazers_url":"https://api.github.com/repos/MovingBlocks/Terasology/stargazers","contributors_url":"https://api.github.com/repos/MovingBlocks/Terasology/contributors","subscribers_url":"https://api.github.com/repos/MovingBlocks/Terasology/subscribers","subscription_url":"https://api.github.com/repos/MovingBlocks/Terasology/subscription","commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/commits{/sha}","git_commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/commits{/sha}","comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/comments{/number}","issue_comment_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/comments{/number}","contents_url":"https://api.github.com/repos/MovingBlocks/Terasology/contents/{+path}","compare_url":"https://api.github.com/repos/MovingBlocks/Terasology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MovingBlocks/Terasology/merges","archive_url":"https://api.github.com/repos/MovingBlocks/Terasology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MovingBlocks/Terasology/downloads","issues_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues{/number}","pulls_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls{/number}","milestones_url":"https://api.github.com/repos/MovingBlocks/Terasology/milestones{/number}","notifications_url":"https://api.github.com/repos/MovingBlocks/Terasology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MovingBlocks/Terasology/labels{/name}","releases_url":"https://api.github.com/repos/MovingBlocks/Terasology/releases{/id}","deployments_url":"https://api.github.com/repos/MovingBlocks/Terasology/deployments","created_at":"2011-03-04T03:49:19Z","updated_at":"2016-09-29T21:00:20Z","pushed_at":"2016-09-28T22:15:50Z","git_url":"git://github.com/MovingBlocks/Terasology.git","ssh_url":"git@github.com:MovingBlocks/Terasology.git","clone_url":"https://github.com/MovingBlocks/Terasology.git","svn_url":"https://github.com/MovingBlocks/Terasology","homepage":"http://terasology.org","size":344596,"stargazers_count":1634,"watchers_count":1634,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":657,"mirror_url":null,"open_issues_count":334,"forks":657,"open_issues":334,"watchers":1634,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2491"},"html":{"href":"https://github.com/MovingBlocks/Terasology/pull/2491"},"issue":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2491"},"comments":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2491/comments"},"review_comments":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2491/comments"},"review_comment":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2491/commits"},"statuses":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/5c19879bbe6f5047d0f8dfcaeb604e71eb9b683b"}}}}
{"actor":{"display_login":"Cervator"}}