{"action":"created","issue":{"url":"https://api.github.com/repos/ctz/rustls/issues/36","repository_url":"https://api.github.com/repos/ctz/rustls","labels_url":"https://api.github.com/repos/ctz/rustls/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/ctz/rustls/issues/36/comments","events_url":"https://api.github.com/repos/ctz/rustls/issues/36/events","html_url":"https://github.com/ctz/rustls/pull/36","id":191769006,"number":36,"title":"Laying ground work to remove more allocations.","user":{"login":"valarauca","id":19227148,"avatar_url":"https://avatars.githubusercontent.com/u/19227148?v=3","gravatar_id":"","url":"https://api.github.com/users/valarauca","html_url":"https://github.com/valarauca","followers_url":"https://api.github.com/users/valarauca/followers","following_url":"https://api.github.com/users/valarauca/following{/other_user}","gists_url":"https://api.github.com/users/valarauca/gists{/gist_id}","starred_url":"https://api.github.com/users/valarauca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valarauca/subscriptions","organizations_url":"https://api.github.com/users/valarauca/orgs","repos_url":"https://api.github.com/users/valarauca/repos","events_url":"https://api.github.com/users/valarauca/events{/privacy}","received_events_url":"https://api.github.com/users/valarauca/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2016-11-25T21:58:33Z","updated_at":"2016-12-18T18:17:15Z","closed_at":"2016-11-28T21:15:20Z","pull_request":{"url":"https://api.github.com/repos/ctz/rustls/pulls/36","html_url":"https://github.com/ctz/rustls/pull/36","diff_url":"https://github.com/ctz/rustls/pull/36.diff","patch_url":"https://github.com/ctz/rustls/pull/36.patch"},"body":"I'm trying to remove some of the dependency on the short lived small vectors where I can.\r\n\r\nThis patch really just cleans up `SessionID` and shrinks `Random`'s size. I want to make `PayLoad` be a slice in the future, and try to get `VecBuf` so it's using internal slices. I'm not sure we'll see. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ctz/rustls/issues/comments/267836939","html_url":"https://github.com/ctz/rustls/pull/36#issuecomment-267836939","issue_url":"https://api.github.com/repos/ctz/rustls/issues/36","id":267836939,"user":{"login":"valarauca","id":19227148,"avatar_url":"https://avatars.githubusercontent.com/u/19227148?v=3","gravatar_id":"","url":"https://api.github.com/users/valarauca","html_url":"https://github.com/valarauca","followers_url":"https://api.github.com/users/valarauca/followers","following_url":"https://api.github.com/users/valarauca/following{/other_user}","gists_url":"https://api.github.com/users/valarauca/gists{/gist_id}","starred_url":"https://api.github.com/users/valarauca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valarauca/subscriptions","organizations_url":"https://api.github.com/users/valarauca/orgs","repos_url":"https://api.github.com/users/valarauca/repos","events_url":"https://api.github.com/users/valarauca/events{/privacy}","received_events_url":"https://api.github.com/users/valarauca/received_events","type":"User","site_admin":false},"created_at":"2016-12-18T18:17:15Z","updated_at":"2016-12-18T18:17:15Z","body":"How should I do preformance testing? We should standardize, or you dictate an approach so we don't approach this with separate methodologies. \r\n\r\nLike maybe a stand alone application to just route across 127.0.01(?)\r\n\r\n---\r\n\r\nI'll start merging in the changes peice meal. Dropping the whole diff and once maybe a bit hard to review. There's minor changes to every file, some changes (especially in msg/ become major).\r\n\r\nThat approach will regress preformance (Initially). But it'll make the changes understandable, traceable, and we can ensure no tests get dropped during the process. \r\n\r\nCould a branch be made to test against?\r\n"}}
{"actor":{"display_login":"valarauca"}}