{"action":"created","comment":{"url":"https://api.github.com/repos/robotframework/Selenium2Library/pulls/comments/90754725","pull_request_review_id":11274884,"id":90754725,"diff_hunk":"@@ -63,12 +70,15 @@ def send_head(self):\n         self.send_response(200)\n         self.send_header(\"Content-type\", ctype)\n         fs = os.fstat(f.fileno())\n-        self.send_header(\"Content-Length\", str(fs[6]))\n+        # chrome hangs if this server runs on windows\n+        # it probably waits for more data -> os.fstat() does not return correct length?\n+        # we are responding with HTTP 1.0 = we do not need content-length header\n+        #self.send_header(\"Content-Length\", str(fs[6]))\n         self.send_header(\"Last-Modified\", self.date_time_string(fs.st_mtime))\n+        #self.send_header(\"Connection\", \"close\")\n         self.end_headers()\n         return f\n \n-","path":"test/resources/testserver/testserver.py","position":41,"original_position":41,"commit_id":"3a642b4bd7f8c3b980af91a005828b480c4d8eef","original_commit_id":"3a642b4bd7f8c3b980af91a005828b480c4d8eef","user":{"login":"aaltat","id":2665023,"avatar_url":"https://avatars.githubusercontent.com/u/2665023?v=3","gravatar_id":"","url":"https://api.github.com/users/aaltat","html_url":"https://github.com/aaltat","followers_url":"https://api.github.com/users/aaltat/followers","following_url":"https://api.github.com/users/aaltat/following{/other_user}","gists_url":"https://api.github.com/users/aaltat/gists{/gist_id}","starred_url":"https://api.github.com/users/aaltat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaltat/subscriptions","organizations_url":"https://api.github.com/users/aaltat/orgs","repos_url":"https://api.github.com/users/aaltat/repos","events_url":"https://api.github.com/users/aaltat/events{/privacy}","received_events_url":"https://api.github.com/users/aaltat/received_events","type":"User","site_admin":false},"body":"Two empty lines before the class definition","created_at":"2016-12-03T10:25:49Z","updated_at":"2016-12-03T10:27:07Z","html_url":"https://github.com/robotframework/Selenium2Library/pull/694#discussion_r90754725","pull_request_url":"https://api.github.com/repos/robotframework/Selenium2Library/pulls/694","_links":{"self":{"href":"https://api.github.com/repos/robotframework/Selenium2Library/pulls/comments/90754725"},"html":{"href":"https://github.com/robotframework/Selenium2Library/pull/694#discussion_r90754725"},"pull_request":{"href":"https://api.github.com/repos/robotframework/Selenium2Library/pulls/694"}}},"pull_request":{"url":"https://api.github.com/repos/robotframework/Selenium2Library/pulls/694","id":95787081,"html_url":"https://github.com/robotframework/Selenium2Library/pull/694","diff_url":"https://github.com/robotframework/Selenium2Library/pull/694.diff","patch_url":"https://github.com/robotframework/Selenium2Library/pull/694.patch","issue_url":"https://api.github.com/repos/robotframework/Selenium2Library/issues/694","number":694,"state":"open","locked":false,"title":"Fixes Chromedriver tests under Windows, by @yahman72","user":{"login":"HelioGuilherme66","id":2866630,"avatar_url":"https://avatars.githubusercontent.com/u/2866630?v=3","gravatar_id":"","url":"https://api.github.com/users/HelioGuilherme66","html_url":"https://github.com/HelioGuilherme66","followers_url":"https://api.github.com/users/HelioGuilherme66/followers","following_url":"https://api.github.com/users/HelioGuilherme66/following{/other_user}","gists_url":"https://api.github.com/users/HelioGuilherme66/gists{/gist_id}","starred_url":"https://api.github.com/users/HelioGuilherme66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HelioGuilherme66/subscriptions","organizations_url":"https://api.github.com/users/HelioGuilherme66/orgs","repos_url":"https://api.github.com/users/HelioGuilherme66/repos","events_url":"https://api.github.com/users/HelioGuilherme66/events{/privacy}","received_events_url":"https://api.github.com/users/HelioGuilherme66/received_events","type":"User","site_admin":false},"body":"(from his commit: webdriver process management)","created_at":"2016-11-29T22:14:09Z","updated_at":"2016-12-03T10:27:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f07c1917932a9af119815c26098a8f1ac09b5cb9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/robotframework/Selenium2Library/pulls/694/commits","review_comments_url":"https://api.github.com/repos/robotframework/Selenium2Library/pulls/694/comments","review_comment_url":"https://api.github.com/repos/robotframework/Selenium2Library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/robotframework/Selenium2Library/issues/694/comments","statuses_url":"https://api.github.com/repos/robotframework/Selenium2Library/statuses/3a642b4bd7f8c3b980af91a005828b480c4d8eef","head":{"label":"HelioGuilherme66:fix_chrome_testing","ref":"fix_chrome_testing","sha":"3a642b4bd7f8c3b980af91a005828b480c4d8eef","user":{"login":"HelioGuilherme66","id":2866630,"avatar_url":"https://avatars.githubusercontent.com/u/2866630?v=3","gravatar_id":"","url":"https://api.github.com/users/HelioGuilherme66","html_url":"https://github.com/HelioGuilherme66","followers_url":"https://api.github.com/users/HelioGuilherme66/followers","following_url":"https://api.github.com/users/HelioGuilherme66/following{/other_user}","gists_url":"https://api.github.com/users/HelioGuilherme66/gists{/gist_id}","starred_url":"https://api.github.com/users/HelioGuilherme66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HelioGuilherme66/subscriptions","organizations_url":"https://api.github.com/users/HelioGuilherme66/orgs","repos_url":"https://api.github.com/users/HelioGuilherme66/repos","events_url":"https://api.github.com/users/HelioGuilherme66/events{/privacy}","received_events_url":"https://api.github.com/users/HelioGuilherme66/received_events","type":"User","site_admin":false},"repo":{"id":22084962,"name":"robotframework-selenium2library","full_name":"HelioGuilherme66/robotframework-selenium2library","owner":{"login":"HelioGuilherme66","id":2866630,"avatar_url":"https://avatars.githubusercontent.com/u/2866630?v=3","gravatar_id":"","url":"https://api.github.com/users/HelioGuilherme66","html_url":"https://github.com/HelioGuilherme66","followers_url":"https://api.github.com/users/HelioGuilherme66/followers","following_url":"https://api.github.com/users/HelioGuilherme66/following{/other_user}","gists_url":"https://api.github.com/users/HelioGuilherme66/gists{/gist_id}","starred_url":"https://api.github.com/users/HelioGuilherme66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HelioGuilherme66/subscriptions","organizations_url":"https://api.github.com/users/HelioGuilherme66/orgs","repos_url":"https://api.github.com/users/HelioGuilherme66/repos","events_url":"https://api.github.com/users/HelioGuilherme66/events{/privacy}","received_events_url":"https://api.github.com/users/HelioGuilherme66/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HelioGuilherme66/robotframework-selenium2library","description":"Web testing library for Robot Framework","fork":true,"url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library","forks_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/forks","keys_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/teams","hooks_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/hooks","issue_events_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/issues/events{/number}","events_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/events","assignees_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/assignees{/user}","branches_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/branches{/branch}","tags_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/tags","blobs_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/git/refs{/sha}","trees_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/statuses/{sha}","languages_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/languages","stargazers_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/stargazers","contributors_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/contributors","subscribers_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/subscribers","subscription_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/subscription","commits_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/commits{/sha}","git_commits_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/git/commits{/sha}","comments_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/comments{/number}","issue_comment_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/issues/comments{/number}","contents_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/contents/{+path}","compare_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/merges","archive_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/downloads","issues_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/issues{/number}","pulls_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/pulls{/number}","milestones_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/milestones{/number}","notifications_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/labels{/name}","releases_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/releases{/id}","deployments_url":"https://api.github.com/repos/HelioGuilherme66/robotframework-selenium2library/deployments","created_at":"2014-07-22T00:21:55Z","updated_at":"2016-11-27T01:12:19Z","pushed_at":"2016-11-29T21:56:02Z","git_url":"git://github.com/HelioGuilherme66/robotframework-selenium2library.git","ssh_url":"git@github.com:HelioGuilherme66/robotframework-selenium2library.git","clone_url":"https://github.com/HelioGuilherme66/robotframework-selenium2library.git","svn_url":"https://github.com/HelioGuilherme66/robotframework-selenium2library","homepage":"","size":110942,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":4,"default_branch":"code_futurized"}},"base":{"label":"robotframework:master","ref":"master","sha":"f168c35846d4e50b6f68ecc99f0ca578e2dcec89","user":{"login":"robotframework","id":574284,"avatar_url":"https://avatars.githubusercontent.com/u/574284?v=3","gravatar_id":"","url":"https://api.github.com/users/robotframework","html_url":"https://github.com/robotframework","followers_url":"https://api.github.com/users/robotframework/followers","following_url":"https://api.github.com/users/robotframework/following{/other_user}","gists_url":"https://api.github.com/users/robotframework/gists{/gist_id}","starred_url":"https://api.github.com/users/robotframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotframework/subscriptions","organizations_url":"https://api.github.com/users/robotframework/orgs","repos_url":"https://api.github.com/users/robotframework/repos","events_url":"https://api.github.com/users/robotframework/events{/privacy}","received_events_url":"https://api.github.com/users/robotframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2625205,"name":"Selenium2Library","full_name":"robotframework/Selenium2Library","owner":{"login":"robotframework","id":574284,"avatar_url":"https://avatars.githubusercontent.com/u/574284?v=3","gravatar_id":"","url":"https://api.github.com/users/robotframework","html_url":"https://github.com/robotframework","followers_url":"https://api.github.com/users/robotframework/followers","following_url":"https://api.github.com/users/robotframework/following{/other_user}","gists_url":"https://api.github.com/users/robotframework/gists{/gist_id}","starred_url":"https://api.github.com/users/robotframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotframework/subscriptions","organizations_url":"https://api.github.com/users/robotframework/orgs","repos_url":"https://api.github.com/users/robotframework/repos","events_url":"https://api.github.com/users/robotframework/events{/privacy}","received_events_url":"https://api.github.com/users/robotframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/robotframework/Selenium2Library","description":"Web testing library for Robot Framework","fork":false,"url":"https://api.github.com/repos/robotframework/Selenium2Library","forks_url":"https://api.github.com/repos/robotframework/Selenium2Library/forks","keys_url":"https://api.github.com/repos/robotframework/Selenium2Library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robotframework/Selenium2Library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robotframework/Selenium2Library/teams","hooks_url":"https://api.github.com/repos/robotframework/Selenium2Library/hooks","issue_events_url":"https://api.github.com/repos/robotframework/Selenium2Library/issues/events{/number}","events_url":"https://api.github.com/repos/robotframework/Selenium2Library/events","assignees_url":"https://api.github.com/repos/robotframework/Selenium2Library/assignees{/user}","branches_url":"https://api.github.com/repos/robotframework/Selenium2Library/branches{/branch}","tags_url":"https://api.github.com/repos/robotframework/Selenium2Library/tags","blobs_url":"https://api.github.com/repos/robotframework/Selenium2Library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robotframework/Selenium2Library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robotframework/Selenium2Library/git/refs{/sha}","trees_url":"https://api.github.com/repos/robotframework/Selenium2Library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robotframework/Selenium2Library/statuses/{sha}","languages_url":"https://api.github.com/repos/robotframework/Selenium2Library/languages","stargazers_url":"https://api.github.com/repos/robotframework/Selenium2Library/stargazers","contributors_url":"https://api.github.com/repos/robotframework/Selenium2Library/contributors","subscribers_url":"https://api.github.com/repos/robotframework/Selenium2Library/subscribers","subscription_url":"https://api.github.com/repos/robotframework/Selenium2Library/subscription","commits_url":"https://api.github.com/repos/robotframework/Selenium2Library/commits{/sha}","git_commits_url":"https://api.github.com/repos/robotframework/Selenium2Library/git/commits{/sha}","comments_url":"https://api.github.com/repos/robotframework/Selenium2Library/comments{/number}","issue_comment_url":"https://api.github.com/repos/robotframework/Selenium2Library/issues/comments{/number}","contents_url":"https://api.github.com/repos/robotframework/Selenium2Library/contents/{+path}","compare_url":"https://api.github.com/repos/robotframework/Selenium2Library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robotframework/Selenium2Library/merges","archive_url":"https://api.github.com/repos/robotframework/Selenium2Library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robotframework/Selenium2Library/downloads","issues_url":"https://api.github.com/repos/robotframework/Selenium2Library/issues{/number}","pulls_url":"https://api.github.com/repos/robotframework/Selenium2Library/pulls{/number}","milestones_url":"https://api.github.com/repos/robotframework/Selenium2Library/milestones{/number}","notifications_url":"https://api.github.com/repos/robotframework/Selenium2Library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robotframework/Selenium2Library/labels{/name}","releases_url":"https://api.github.com/repos/robotframework/Selenium2Library/releases{/id}","deployments_url":"https://api.github.com/repos/robotframework/Selenium2Library/deployments","created_at":"2011-10-22T08:01:34Z","updated_at":"2016-11-25T13:13:05Z","pushed_at":"2016-12-02T16:46:50Z","git_url":"git://github.com/robotframework/Selenium2Library.git","ssh_url":"git@github.com:robotframework/Selenium2Library.git","clone_url":"https://github.com/robotframework/Selenium2Library.git","svn_url":"https://github.com/robotframework/Selenium2Library","homepage":"","size":112725,"stargazers_count":339,"watchers_count":339,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":313,"mirror_url":null,"open_issues_count":153,"forks":313,"open_issues":153,"watchers":339,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/robotframework/Selenium2Library/pulls/694"},"html":{"href":"https://github.com/robotframework/Selenium2Library/pull/694"},"issue":{"href":"https://api.github.com/repos/robotframework/Selenium2Library/issues/694"},"comments":{"href":"https://api.github.com/repos/robotframework/Selenium2Library/issues/694/comments"},"review_comments":{"href":"https://api.github.com/repos/robotframework/Selenium2Library/pulls/694/comments"},"review_comment":{"href":"https://api.github.com/repos/robotframework/Selenium2Library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/robotframework/Selenium2Library/pulls/694/commits"},"statuses":{"href":"https://api.github.com/repos/robotframework/Selenium2Library/statuses/3a642b4bd7f8c3b980af91a005828b480c4d8eef"}}}}
{"actor":{"display_login":"aaltat"}}