{"action":"created","comment":{"url":"https://api.github.com/repos/Katello/puppet-certs/pulls/comments/54413187","id":54413187,"diff_hunk":"@@ -41,14 +41,9 @@\n     mode    => '0644',\n     require => File[$certs::katello_server_ca_cert],\n   } ~>\n-  # Generate the the rhsm setup script in the pub dir for rhsm setup\n-  file { \"${katello_www_pub_dir}/${katello_rhsm_setup_script}\":\n-    ensure  => file,\n-    owner   => 'root',\n-    group   => 'root',\n-    mode    => '0755',\n-    content => template('certs/rhsm-katello-reconfigure.erb'),\n-    require => Class['::certs'],\n+  rhsm_reconfigure_script { \"${katello_www_pub_dir}/${katello_rhsm_setup_script}\":","path":"manifests/katello.pp","position":12,"original_position":12,"commit_id":"fbc09125cd1757a98e5809c72e1e46921161a0bb","original_commit_id":"fbc09125cd1757a98e5809c72e1e46921161a0bb","user":{"login":"ekohl","id":155810,"avatar_url":"https://avatars.githubusercontent.com/u/155810?v=3","gravatar_id":"","url":"https://api.github.com/users/ekohl","html_url":"https://github.com/ekohl","followers_url":"https://api.github.com/users/ekohl/followers","following_url":"https://api.github.com/users/ekohl/following{/other_user}","gists_url":"https://api.github.com/users/ekohl/gists{/gist_id}","starred_url":"https://api.github.com/users/ekohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekohl/subscriptions","organizations_url":"https://api.github.com/users/ekohl/orgs","repos_url":"https://api.github.com/users/ekohl/repos","events_url":"https://api.github.com/users/ekohl/events{/privacy}","received_events_url":"https://api.github.com/users/ekohl/received_events","type":"User","site_admin":false},"body":"Shouldn't this be certs::rhsm_reconfigure_script?","created_at":"2016-02-29T14:09:12Z","updated_at":"2016-02-29T14:09:12Z","html_url":"https://github.com/Katello/puppet-certs/pull/77#discussion_r54413187","pull_request_url":"https://api.github.com/repos/Katello/puppet-certs/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/Katello/puppet-certs/pulls/comments/54413187"},"html":{"href":"https://github.com/Katello/puppet-certs/pull/77#discussion_r54413187"},"pull_request":{"href":"https://api.github.com/repos/Katello/puppet-certs/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/Katello/puppet-certs/pulls/77","id":60932202,"html_url":"https://github.com/Katello/puppet-certs/pull/77","diff_url":"https://github.com/Katello/puppet-certs/pull/77.diff","patch_url":"https://github.com/Katello/puppet-certs/pull/77.patch","issue_url":"https://api.github.com/repos/Katello/puppet-certs/issues/77","number":77,"state":"open","locked":false,"title":"Fixes #13925: Use concat to build reconfigure script","user":{"login":"ehelms","id":293363,"avatar_url":"https://avatars.githubusercontent.com/u/293363?v=3","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"body":"On Puppet 3.6 the use of File.read in the reconfigure template\r\ncauses the certs to be empty given the template is evaluated\r\nat the beginning. This switches to concat to build up the reconfigure\r\nscript using the source parameter to read from the cert files.","created_at":"2016-02-27T02:27:34Z","updated_at":"2016-02-29T14:09:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce7cb22ea6aada1b0c58e2edcdb9452145856460","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Katello/puppet-certs/pulls/77/commits","review_comments_url":"https://api.github.com/repos/Katello/puppet-certs/pulls/77/comments","review_comment_url":"https://api.github.com/repos/Katello/puppet-certs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Katello/puppet-certs/issues/77/comments","statuses_url":"https://api.github.com/repos/Katello/puppet-certs/statuses/fbc09125cd1757a98e5809c72e1e46921161a0bb","head":{"label":"ehelms:fixes-13925","ref":"fixes-13925","sha":"fbc09125cd1757a98e5809c72e1e46921161a0bb","user":{"login":"ehelms","id":293363,"avatar_url":"https://avatars.githubusercontent.com/u/293363?v=3","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"repo":{"id":15426880,"name":"puppet-certs","full_name":"ehelms/puppet-certs","owner":{"login":"ehelms","id":293363,"avatar_url":"https://avatars.githubusercontent.com/u/293363?v=3","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ehelms/puppet-certs","description":"Puppet module for dealing with SSL certs accross other moduls used in Katello","fork":true,"url":"https://api.github.com/repos/ehelms/puppet-certs","forks_url":"https://api.github.com/repos/ehelms/puppet-certs/forks","keys_url":"https://api.github.com/repos/ehelms/puppet-certs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ehelms/puppet-certs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ehelms/puppet-certs/teams","hooks_url":"https://api.github.com/repos/ehelms/puppet-certs/hooks","issue_events_url":"https://api.github.com/repos/ehelms/puppet-certs/issues/events{/number}","events_url":"https://api.github.com/repos/ehelms/puppet-certs/events","assignees_url":"https://api.github.com/repos/ehelms/puppet-certs/assignees{/user}","branches_url":"https://api.github.com/repos/ehelms/puppet-certs/branches{/branch}","tags_url":"https://api.github.com/repos/ehelms/puppet-certs/tags","blobs_url":"https://api.github.com/repos/ehelms/puppet-certs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ehelms/puppet-certs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ehelms/puppet-certs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ehelms/puppet-certs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ehelms/puppet-certs/statuses/{sha}","languages_url":"https://api.github.com/repos/ehelms/puppet-certs/languages","stargazers_url":"https://api.github.com/repos/ehelms/puppet-certs/stargazers","contributors_url":"https://api.github.com/repos/ehelms/puppet-certs/contributors","subscribers_url":"https://api.github.com/repos/ehelms/puppet-certs/subscribers","subscription_url":"https://api.github.com/repos/ehelms/puppet-certs/subscription","commits_url":"https://api.github.com/repos/ehelms/puppet-certs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ehelms/puppet-certs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ehelms/puppet-certs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ehelms/puppet-certs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ehelms/puppet-certs/contents/{+path}","compare_url":"https://api.github.com/repos/ehelms/puppet-certs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ehelms/puppet-certs/merges","archive_url":"https://api.github.com/repos/ehelms/puppet-certs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ehelms/puppet-certs/downloads","issues_url":"https://api.github.com/repos/ehelms/puppet-certs/issues{/number}","pulls_url":"https://api.github.com/repos/ehelms/puppet-certs/pulls{/number}","milestones_url":"https://api.github.com/repos/ehelms/puppet-certs/milestones{/number}","notifications_url":"https://api.github.com/repos/ehelms/puppet-certs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ehelms/puppet-certs/labels{/name}","releases_url":"https://api.github.com/repos/ehelms/puppet-certs/releases{/id}","deployments_url":"https://api.github.com/repos/ehelms/puppet-certs/deployments","created_at":"2013-12-25T00:00:33Z","updated_at":"2014-06-19T19:07:16Z","pushed_at":"2016-02-27T02:38:03Z","git_url":"git://github.com/ehelms/puppet-certs.git","ssh_url":"git@github.com:ehelms/puppet-certs.git","clone_url":"https://github.com/ehelms/puppet-certs.git","svn_url":"https://github.com/ehelms/puppet-certs","homepage":null,"size":179,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Katello:master","ref":"master","sha":"3559d9be44b5d4cc155b79e5ecd0854d5c70d5f6","user":{"login":"Katello","id":1316386,"avatar_url":"https://avatars.githubusercontent.com/u/1316386?v=3","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"repo":{"id":13797797,"name":"puppet-certs","full_name":"Katello/puppet-certs","owner":{"login":"Katello","id":1316386,"avatar_url":"https://avatars.githubusercontent.com/u/1316386?v=3","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Katello/puppet-certs","description":"Puppet module for dealing with SSL certs accross other moduls used in Katello","fork":false,"url":"https://api.github.com/repos/Katello/puppet-certs","forks_url":"https://api.github.com/repos/Katello/puppet-certs/forks","keys_url":"https://api.github.com/repos/Katello/puppet-certs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Katello/puppet-certs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Katello/puppet-certs/teams","hooks_url":"https://api.github.com/repos/Katello/puppet-certs/hooks","issue_events_url":"https://api.github.com/repos/Katello/puppet-certs/issues/events{/number}","events_url":"https://api.github.com/repos/Katello/puppet-certs/events","assignees_url":"https://api.github.com/repos/Katello/puppet-certs/assignees{/user}","branches_url":"https://api.github.com/repos/Katello/puppet-certs/branches{/branch}","tags_url":"https://api.github.com/repos/Katello/puppet-certs/tags","blobs_url":"https://api.github.com/repos/Katello/puppet-certs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Katello/puppet-certs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Katello/puppet-certs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Katello/puppet-certs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Katello/puppet-certs/statuses/{sha}","languages_url":"https://api.github.com/repos/Katello/puppet-certs/languages","stargazers_url":"https://api.github.com/repos/Katello/puppet-certs/stargazers","contributors_url":"https://api.github.com/repos/Katello/puppet-certs/contributors","subscribers_url":"https://api.github.com/repos/Katello/puppet-certs/subscribers","subscription_url":"https://api.github.com/repos/Katello/puppet-certs/subscription","commits_url":"https://api.github.com/repos/Katello/puppet-certs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Katello/puppet-certs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Katello/puppet-certs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Katello/puppet-certs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Katello/puppet-certs/contents/{+path}","compare_url":"https://api.github.com/repos/Katello/puppet-certs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Katello/puppet-certs/merges","archive_url":"https://api.github.com/repos/Katello/puppet-certs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Katello/puppet-certs/downloads","issues_url":"https://api.github.com/repos/Katello/puppet-certs/issues{/number}","pulls_url":"https://api.github.com/repos/Katello/puppet-certs/pulls{/number}","milestones_url":"https://api.github.com/repos/Katello/puppet-certs/milestones{/number}","notifications_url":"https://api.github.com/repos/Katello/puppet-certs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Katello/puppet-certs/labels{/name}","releases_url":"https://api.github.com/repos/Katello/puppet-certs/releases{/id}","deployments_url":"https://api.github.com/repos/Katello/puppet-certs/deployments","created_at":"2013-10-23T08:46:31Z","updated_at":"2016-01-31T13:58:15Z","pushed_at":"2016-02-27T02:38:03Z","git_url":"git://github.com/Katello/puppet-certs.git","ssh_url":"git@github.com:Katello/puppet-certs.git","clone_url":"https://github.com/Katello/puppet-certs.git","svn_url":"https://github.com/Katello/puppet-certs","homepage":null,"size":186,"stargazers_count":1,"watchers_count":1,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":2,"forks":18,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Katello/puppet-certs/pulls/77"},"html":{"href":"https://github.com/Katello/puppet-certs/pull/77"},"issue":{"href":"https://api.github.com/repos/Katello/puppet-certs/issues/77"},"comments":{"href":"https://api.github.com/repos/Katello/puppet-certs/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/Katello/puppet-certs/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/Katello/puppet-certs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Katello/puppet-certs/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/Katello/puppet-certs/statuses/fbc09125cd1757a98e5809c72e1e46921161a0bb"}}}}