{"action":"created","comment":{"url":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/comments/62323487","id":62323487,"diff_hunk":"@@ -34,7 +34,7 @@\n         .content#tabt3{role: \"tabpanel\", \"aria-hidden\" => false }\n           %br\n             .tab-container\n-              = render \"rubrics/components/rubric_table\", presenter: presenter, include_grade_info: false\n+              = render \"rubrics/components/rubric_table\", rubric: presenter.rubric, student: nil, include_grade_info: false","path":"app/views/assignments/_show_instructor.haml","position":5,"original_position":5,"commit_id":"48b67812809b6de9000fe92b65924fd86f5a80c8","original_commit_id":"48b67812809b6de9000fe92b65924fd86f5a80c8","user":{"login":"acousticrobot","id":1138350,"avatar_url":"https://avatars.githubusercontent.com/u/1138350?v=3","gravatar_id":"","url":"https://api.github.com/users/acousticrobot","html_url":"https://github.com/acousticrobot","followers_url":"https://api.github.com/users/acousticrobot/followers","following_url":"https://api.github.com/users/acousticrobot/following{/other_user}","gists_url":"https://api.github.com/users/acousticrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/acousticrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acousticrobot/subscriptions","organizations_url":"https://api.github.com/users/acousticrobot/orgs","repos_url":"https://api.github.com/users/acousticrobot/repos","events_url":"https://api.github.com/users/acousticrobot/events{/privacy}","received_events_url":"https://api.github.com/users/acousticrobot/received_events","type":"User","site_admin":false},"body":"We should to change this to use `partial:` and `locals:`, but I'm guessing you left this for @ksofa2 ","created_at":"2016-05-06T12:30:54Z","updated_at":"2016-05-06T12:30:54Z","html_url":"https://github.com/UM-USElab/gradecraft-development/pull/1959#discussion_r62323487","pull_request_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/1959","_links":{"self":{"href":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/comments/62323487"},"html":{"href":"https://github.com/UM-USElab/gradecraft-development/pull/1959#discussion_r62323487"},"pull_request":{"href":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/1959"}}},"pull_request":{"url":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/1959","id":68950977,"html_url":"https://github.com/UM-USElab/gradecraft-development/pull/1959","diff_url":"https://github.com/UM-USElab/gradecraft-development/pull/1959.diff","patch_url":"https://github.com/UM-USElab/gradecraft-development/pull/1959.patch","issue_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/1959","number":1959,"state":"open","locked":false,"title":"1747 grade routes redux 3","user":{"login":"jwright","id":35017,"avatar_url":"https://avatars.githubusercontent.com/u/35017?v=3","gravatar_id":"","url":"https://api.github.com/users/jwright","html_url":"https://github.com/jwright","followers_url":"https://api.github.com/users/jwright/followers","following_url":"https://api.github.com/users/jwright/following{/other_user}","gists_url":"https://api.github.com/users/jwright/gists{/gist_id}","starred_url":"https://api.github.com/users/jwright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwright/subscriptions","organizations_url":"https://api.github.com/users/jwright/orgs","repos_url":"https://api.github.com/users/jwright/repos","events_url":"https://api.github.com/users/jwright/events{/privacy}","received_events_url":"https://api.github.com/users/jwright/received_events","type":"User","site_admin":false},"body":"This PR moves the `Grade` show route from `/assignments/:assignment_id/grade/:id` to `/grades/:id`.\r\n\r\nIn order to do this, the `AssignmentPresenter` had to be removed from usage within the `GradesController`. This refactor cleaned up a lot of presenter pollution since the `Grade` resource should not of used the `AssignmentPresenter`.\r\n\r\nSome of the more complicated methods that were being used on the `Presenter` were moved to the `Level` model.\r\n\r\nSince the param `?student_id=x` was being removed for the faculty view, the `current_student` could no longer be used in certain views (i.e. `rubric_table` partial) and so the `student` was passed down to the partials through the controller.\r\n\r\nIn addition, anytime a partial was being rendered, the \"explicit long form\" was used. (This will affect a lot of views @ksofa2).\r\n\r\nCloses #1747 ","created_at":"2016-05-05T00:01:28Z","updated_at":"2016-05-06T12:30:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23f1786b87156bfa41fbc89cf03c1f965d024e38","assignee":{"login":"acousticrobot","id":1138350,"avatar_url":"https://avatars.githubusercontent.com/u/1138350?v=3","gravatar_id":"","url":"https://api.github.com/users/acousticrobot","html_url":"https://github.com/acousticrobot","followers_url":"https://api.github.com/users/acousticrobot/followers","following_url":"https://api.github.com/users/acousticrobot/following{/other_user}","gists_url":"https://api.github.com/users/acousticrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/acousticrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acousticrobot/subscriptions","organizations_url":"https://api.github.com/users/acousticrobot/orgs","repos_url":"https://api.github.com/users/acousticrobot/repos","events_url":"https://api.github.com/users/acousticrobot/events{/privacy}","received_events_url":"https://api.github.com/users/acousticrobot/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/1959/commits","review_comments_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/1959/comments","review_comment_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/1959/comments","statuses_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/statuses/48b67812809b6de9000fe92b65924fd86f5a80c8","head":{"label":"UM-USElab:1747-grade-routes-redux-3","ref":"1747-grade-routes-redux-3","sha":"48b67812809b6de9000fe92b65924fd86f5a80c8","user":{"login":"UM-USElab","id":4459066,"avatar_url":"https://avatars.githubusercontent.com/u/4459066?v=3","gravatar_id":"","url":"https://api.github.com/users/UM-USElab","html_url":"https://github.com/UM-USElab","followers_url":"https://api.github.com/users/UM-USElab/followers","following_url":"https://api.github.com/users/UM-USElab/following{/other_user}","gists_url":"https://api.github.com/users/UM-USElab/gists{/gist_id}","starred_url":"https://api.github.com/users/UM-USElab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UM-USElab/subscriptions","organizations_url":"https://api.github.com/users/UM-USElab/orgs","repos_url":"https://api.github.com/users/UM-USElab/repos","events_url":"https://api.github.com/users/UM-USElab/events{/privacy}","received_events_url":"https://api.github.com/users/UM-USElab/received_events","type":"Organization","site_admin":false},"repo":{"id":8105769,"name":"gradecraft-development","full_name":"UM-USElab/gradecraft-development","owner":{"login":"UM-USElab","id":4459066,"avatar_url":"https://avatars.githubusercontent.com/u/4459066?v=3","gravatar_id":"","url":"https://api.github.com/users/UM-USElab","html_url":"https://github.com/UM-USElab","followers_url":"https://api.github.com/users/UM-USElab/followers","following_url":"https://api.github.com/users/UM-USElab/following{/other_user}","gists_url":"https://api.github.com/users/UM-USElab/gists{/gist_id}","starred_url":"https://api.github.com/users/UM-USElab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UM-USElab/subscriptions","organizations_url":"https://api.github.com/users/UM-USElab/orgs","repos_url":"https://api.github.com/users/UM-USElab/repos","events_url":"https://api.github.com/users/UM-USElab/events{/privacy}","received_events_url":"https://api.github.com/users/UM-USElab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UM-USElab/gradecraft-development","description":"GradeCraft is a gameful learning management system, intended to help motivate students to be more engaged in their own learning.","fork":false,"url":"https://api.github.com/repos/UM-USElab/gradecraft-development","forks_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/forks","keys_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/teams","hooks_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/hooks","issue_events_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/events{/number}","events_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/events","assignees_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/assignees{/user}","branches_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/branches{/branch}","tags_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/tags","blobs_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/git/refs{/sha}","trees_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/statuses/{sha}","languages_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/languages","stargazers_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/stargazers","contributors_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/contributors","subscribers_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/subscribers","subscription_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/subscription","commits_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/commits{/sha}","git_commits_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/git/commits{/sha}","comments_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/comments{/number}","issue_comment_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/comments{/number}","contents_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/contents/{+path}","compare_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/merges","archive_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/downloads","issues_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues{/number}","pulls_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls{/number}","milestones_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/milestones{/number}","notifications_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/labels{/name}","releases_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/releases{/id}","deployments_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/deployments","created_at":"2013-02-09T03:44:54Z","updated_at":"2016-01-27T18:03:56Z","pushed_at":"2016-05-06T12:00:03Z","git_url":"git://github.com/UM-USElab/gradecraft-development.git","ssh_url":"git@github.com:UM-USElab/gradecraft-development.git","clone_url":"https://github.com/UM-USElab/gradecraft-development.git","svn_url":"https://github.com/UM-USElab/gradecraft-development","homepage":"","size":67232,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":156,"forks":18,"open_issues":156,"watchers":27,"default_branch":"master"}},"base":{"label":"UM-USElab:master","ref":"master","sha":"3911c99678cc15d40a63a09a6fb47432fb576638","user":{"login":"UM-USElab","id":4459066,"avatar_url":"https://avatars.githubusercontent.com/u/4459066?v=3","gravatar_id":"","url":"https://api.github.com/users/UM-USElab","html_url":"https://github.com/UM-USElab","followers_url":"https://api.github.com/users/UM-USElab/followers","following_url":"https://api.github.com/users/UM-USElab/following{/other_user}","gists_url":"https://api.github.com/users/UM-USElab/gists{/gist_id}","starred_url":"https://api.github.com/users/UM-USElab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UM-USElab/subscriptions","organizations_url":"https://api.github.com/users/UM-USElab/orgs","repos_url":"https://api.github.com/users/UM-USElab/repos","events_url":"https://api.github.com/users/UM-USElab/events{/privacy}","received_events_url":"https://api.github.com/users/UM-USElab/received_events","type":"Organization","site_admin":false},"repo":{"id":8105769,"name":"gradecraft-development","full_name":"UM-USElab/gradecraft-development","owner":{"login":"UM-USElab","id":4459066,"avatar_url":"https://avatars.githubusercontent.com/u/4459066?v=3","gravatar_id":"","url":"https://api.github.com/users/UM-USElab","html_url":"https://github.com/UM-USElab","followers_url":"https://api.github.com/users/UM-USElab/followers","following_url":"https://api.github.com/users/UM-USElab/following{/other_user}","gists_url":"https://api.github.com/users/UM-USElab/gists{/gist_id}","starred_url":"https://api.github.com/users/UM-USElab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UM-USElab/subscriptions","organizations_url":"https://api.github.com/users/UM-USElab/orgs","repos_url":"https://api.github.com/users/UM-USElab/repos","events_url":"https://api.github.com/users/UM-USElab/events{/privacy}","received_events_url":"https://api.github.com/users/UM-USElab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UM-USElab/gradecraft-development","description":"GradeCraft is a gameful learning management system, intended to help motivate students to be more engaged in their own learning.","fork":false,"url":"https://api.github.com/repos/UM-USElab/gradecraft-development","forks_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/forks","keys_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/teams","hooks_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/hooks","issue_events_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/events{/number}","events_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/events","assignees_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/assignees{/user}","branches_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/branches{/branch}","tags_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/tags","blobs_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/git/refs{/sha}","trees_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/statuses/{sha}","languages_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/languages","stargazers_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/stargazers","contributors_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/contributors","subscribers_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/subscribers","subscription_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/subscription","commits_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/commits{/sha}","git_commits_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/git/commits{/sha}","comments_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/comments{/number}","issue_comment_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/comments{/number}","contents_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/contents/{+path}","compare_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/merges","archive_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/downloads","issues_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues{/number}","pulls_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls{/number}","milestones_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/milestones{/number}","notifications_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/labels{/name}","releases_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/releases{/id}","deployments_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/deployments","created_at":"2013-02-09T03:44:54Z","updated_at":"2016-01-27T18:03:56Z","pushed_at":"2016-05-06T12:00:03Z","git_url":"git://github.com/UM-USElab/gradecraft-development.git","ssh_url":"git@github.com:UM-USElab/gradecraft-development.git","clone_url":"https://github.com/UM-USElab/gradecraft-development.git","svn_url":"https://github.com/UM-USElab/gradecraft-development","homepage":"","size":67232,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":156,"forks":18,"open_issues":156,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/1959"},"html":{"href":"https://github.com/UM-USElab/gradecraft-development/pull/1959"},"issue":{"href":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/1959"},"comments":{"href":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/1959/comments"},"review_comments":{"href":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/1959/comments"},"review_comment":{"href":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/1959/commits"},"statuses":{"href":"https://api.github.com/repos/UM-USElab/gradecraft-development/statuses/48b67812809b6de9000fe92b65924fd86f5a80c8"}}}}