{"action":"created","comment":{"url":"https://api.github.com/repos/gandalfcode/gandalf/pulls/comments/93016491","pull_request_review_id":13534914,"id":93016491,"diff_hunk":"@@ -547,6 +550,8 @@ void OctTree<ndim,ParticleType,TreeCell>::StockTree\n               if (partdata[i].v[k] > cell.vbox.max[k]) cell.vbox.max[k] = partdata[i].v[k];\n               if (partdata[i].v[k] < cell.vbox.min[k]) cell.vbox.min[k] = partdata[i].v[k];\n             }\n+            cell.amin = min(cell.amin,\n+                            sqrt(DotProduct(partdata[i].atree,partdata[i].atree,ndim)));","path":"src/Tree/OctTree.cpp","position":27,"original_position":27,"commit_id":"5d61c6ddea3f91a7e009c178855caaf9188b468b","original_commit_id":"5d61c6ddea3f91a7e009c178855caaf9188b468b","user":{"login":"giovanni-rosotti","id":1528450,"avatar_url":"https://avatars.githubusercontent.com/u/1528450?v=3","gravatar_id":"","url":"https://api.github.com/users/giovanni-rosotti","html_url":"https://github.com/giovanni-rosotti","followers_url":"https://api.github.com/users/giovanni-rosotti/followers","following_url":"https://api.github.com/users/giovanni-rosotti/following{/other_user}","gists_url":"https://api.github.com/users/giovanni-rosotti/gists{/gist_id}","starred_url":"https://api.github.com/users/giovanni-rosotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giovanni-rosotti/subscriptions","organizations_url":"https://api.github.com/users/giovanni-rosotti/orgs","repos_url":"https://api.github.com/users/giovanni-rosotti/repos","events_url":"https://api.github.com/users/giovanni-rosotti/events{/privacy}","received_events_url":"https://api.github.com/users/giovanni-rosotti/received_events","type":"User","site_admin":false},"body":"Any chance we can avoid the sqrt, and store aminsqd?","created_at":"2016-12-19T11:45:13Z","updated_at":"2016-12-19T11:54:28Z","html_url":"https://github.com/gandalfcode/gandalf/pull/118#discussion_r93016491","pull_request_url":"https://api.github.com/repos/gandalfcode/gandalf/pulls/118","_links":{"self":{"href":"https://api.github.com/repos/gandalfcode/gandalf/pulls/comments/93016491"},"html":{"href":"https://github.com/gandalfcode/gandalf/pull/118#discussion_r93016491"},"pull_request":{"href":"https://api.github.com/repos/gandalfcode/gandalf/pulls/118"}}},"pull_request":{"url":"https://api.github.com/repos/gandalfcode/gandalf/pulls/118","id":98377873,"html_url":"https://github.com/gandalfcode/gandalf/pull/118","diff_url":"https://github.com/gandalfcode/gandalf/pull/118.diff","patch_url":"https://github.com/gandalfcode/gandalf/pull/118.patch","issue_url":"https://api.github.com/repos/gandalfcode/gandalf/issues/118","number":118,"state":"open","locked":false,"title":"Relative opening","user":{"login":"rbooth200","id":15370420,"avatar_url":"https://avatars.githubusercontent.com/u/15370420?v=3","gravatar_id":"","url":"https://api.github.com/users/rbooth200","html_url":"https://github.com/rbooth200","followers_url":"https://api.github.com/users/rbooth200/followers","following_url":"https://api.github.com/users/rbooth200/following{/other_user}","gists_url":"https://api.github.com/users/rbooth200/gists{/gist_id}","starred_url":"https://api.github.com/users/rbooth200/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbooth200/subscriptions","organizations_url":"https://api.github.com/users/rbooth200/orgs","repos_url":"https://api.github.com/users/rbooth200/repos","events_url":"https://api.github.com/users/rbooth200/events{/privacy}","received_events_url":"https://api.github.com/users/rbooth200/received_events","type":"User","site_admin":false},"body":"I've added a GADGET-2 like relative opening criterion, in the hope of having a force calculation that is accurate even when the terms all nearly cancel. \r\n\r\nWe need to see whether:\r\n1) This helps\r\n2) The eigenmac criterion isn't already better.\r\n\r\nCurrently I can't get anything sensible with the Jeans tests at all though...","created_at":"2016-12-16T18:02:49Z","updated_at":"2016-12-19T11:54:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0dd48ec1ce3428c8bd84b64a01dce033527dfea","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gandalfcode/gandalf/pulls/118/commits","review_comments_url":"https://api.github.com/repos/gandalfcode/gandalf/pulls/118/comments","review_comment_url":"https://api.github.com/repos/gandalfcode/gandalf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gandalfcode/gandalf/issues/118/comments","statuses_url":"https://api.github.com/repos/gandalfcode/gandalf/statuses/5d61c6ddea3f91a7e009c178855caaf9188b468b","head":{"label":"gandalfcode:relative_opening","ref":"relative_opening","sha":"5d61c6ddea3f91a7e009c178855caaf9188b468b","user":{"login":"gandalfcode","id":5112953,"avatar_url":"https://avatars.githubusercontent.com/u/5112953?v=3","gravatar_id":"","url":"https://api.github.com/users/gandalfcode","html_url":"https://github.com/gandalfcode","followers_url":"https://api.github.com/users/gandalfcode/followers","following_url":"https://api.github.com/users/gandalfcode/following{/other_user}","gists_url":"https://api.github.com/users/gandalfcode/gists{/gist_id}","starred_url":"https://api.github.com/users/gandalfcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gandalfcode/subscriptions","organizations_url":"https://api.github.com/users/gandalfcode/orgs","repos_url":"https://api.github.com/users/gandalfcode/repos","events_url":"https://api.github.com/users/gandalfcode/events{/privacy}","received_events_url":"https://api.github.com/users/gandalfcode/received_events","type":"Organization","site_admin":false},"repo":{"id":11739204,"name":"gandalf","full_name":"gandalfcode/gandalf","owner":{"login":"gandalfcode","id":5112953,"avatar_url":"https://avatars.githubusercontent.com/u/5112953?v=3","gravatar_id":"","url":"https://api.github.com/users/gandalfcode","html_url":"https://github.com/gandalfcode","followers_url":"https://api.github.com/users/gandalfcode/followers","following_url":"https://api.github.com/users/gandalfcode/following{/other_user}","gists_url":"https://api.github.com/users/gandalfcode/gists{/gist_id}","starred_url":"https://api.github.com/users/gandalfcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gandalfcode/subscriptions","organizations_url":"https://api.github.com/users/gandalfcode/orgs","repos_url":"https://api.github.com/users/gandalfcode/repos","events_url":"https://api.github.com/users/gandalfcode/events{/privacy}","received_events_url":"https://api.github.com/users/gandalfcode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gandalfcode/gandalf","description":"GANDALF (Graphical Astrophysics code for N-body Dynamics And Lagrangian Fluids)","fork":false,"url":"https://api.github.com/repos/gandalfcode/gandalf","forks_url":"https://api.github.com/repos/gandalfcode/gandalf/forks","keys_url":"https://api.github.com/repos/gandalfcode/gandalf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gandalfcode/gandalf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gandalfcode/gandalf/teams","hooks_url":"https://api.github.com/repos/gandalfcode/gandalf/hooks","issue_events_url":"https://api.github.com/repos/gandalfcode/gandalf/issues/events{/number}","events_url":"https://api.github.com/repos/gandalfcode/gandalf/events","assignees_url":"https://api.github.com/repos/gandalfcode/gandalf/assignees{/user}","branches_url":"https://api.github.com/repos/gandalfcode/gandalf/branches{/branch}","tags_url":"https://api.github.com/repos/gandalfcode/gandalf/tags","blobs_url":"https://api.github.com/repos/gandalfcode/gandalf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gandalfcode/gandalf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gandalfcode/gandalf/git/refs{/sha}","trees_url":"https://api.github.com/repos/gandalfcode/gandalf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gandalfcode/gandalf/statuses/{sha}","languages_url":"https://api.github.com/repos/gandalfcode/gandalf/languages","stargazers_url":"https://api.github.com/repos/gandalfcode/gandalf/stargazers","contributors_url":"https://api.github.com/repos/gandalfcode/gandalf/contributors","subscribers_url":"https://api.github.com/repos/gandalfcode/gandalf/subscribers","subscription_url":"https://api.github.com/repos/gandalfcode/gandalf/subscription","commits_url":"https://api.github.com/repos/gandalfcode/gandalf/commits{/sha}","git_commits_url":"https://api.github.com/repos/gandalfcode/gandalf/git/commits{/sha}","comments_url":"https://api.github.com/repos/gandalfcode/gandalf/comments{/number}","issue_comment_url":"https://api.github.com/repos/gandalfcode/gandalf/issues/comments{/number}","contents_url":"https://api.github.com/repos/gandalfcode/gandalf/contents/{+path}","compare_url":"https://api.github.com/repos/gandalfcode/gandalf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gandalfcode/gandalf/merges","archive_url":"https://api.github.com/repos/gandalfcode/gandalf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gandalfcode/gandalf/downloads","issues_url":"https://api.github.com/repos/gandalfcode/gandalf/issues{/number}","pulls_url":"https://api.github.com/repos/gandalfcode/gandalf/pulls{/number}","milestones_url":"https://api.github.com/repos/gandalfcode/gandalf/milestones{/number}","notifications_url":"https://api.github.com/repos/gandalfcode/gandalf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gandalfcode/gandalf/labels{/name}","releases_url":"https://api.github.com/repos/gandalfcode/gandalf/releases{/id}","deployments_url":"https://api.github.com/repos/gandalfcode/gandalf/deployments","created_at":"2013-07-29T12:36:37Z","updated_at":"2016-10-28T10:23:15Z","pushed_at":"2016-12-19T10:27:45Z","git_url":"git://github.com/gandalfcode/gandalf.git","ssh_url":"git@github.com:gandalfcode/gandalf.git","clone_url":"https://github.com/gandalfcode/gandalf.git","svn_url":"https://github.com/gandalfcode/gandalf","homepage":null,"size":7023,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":35,"forks":3,"open_issues":35,"watchers":10,"default_branch":"master"}},"base":{"label":"gandalfcode:master","ref":"master","sha":"84862b37ced1fe10ef5550a37c51a5d5066410c7","user":{"login":"gandalfcode","id":5112953,"avatar_url":"https://avatars.githubusercontent.com/u/5112953?v=3","gravatar_id":"","url":"https://api.github.com/users/gandalfcode","html_url":"https://github.com/gandalfcode","followers_url":"https://api.github.com/users/gandalfcode/followers","following_url":"https://api.github.com/users/gandalfcode/following{/other_user}","gists_url":"https://api.github.com/users/gandalfcode/gists{/gist_id}","starred_url":"https://api.github.com/users/gandalfcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gandalfcode/subscriptions","organizations_url":"https://api.github.com/users/gandalfcode/orgs","repos_url":"https://api.github.com/users/gandalfcode/repos","events_url":"https://api.github.com/users/gandalfcode/events{/privacy}","received_events_url":"https://api.github.com/users/gandalfcode/received_events","type":"Organization","site_admin":false},"repo":{"id":11739204,"name":"gandalf","full_name":"gandalfcode/gandalf","owner":{"login":"gandalfcode","id":5112953,"avatar_url":"https://avatars.githubusercontent.com/u/5112953?v=3","gravatar_id":"","url":"https://api.github.com/users/gandalfcode","html_url":"https://github.com/gandalfcode","followers_url":"https://api.github.com/users/gandalfcode/followers","following_url":"https://api.github.com/users/gandalfcode/following{/other_user}","gists_url":"https://api.github.com/users/gandalfcode/gists{/gist_id}","starred_url":"https://api.github.com/users/gandalfcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gandalfcode/subscriptions","organizations_url":"https://api.github.com/users/gandalfcode/orgs","repos_url":"https://api.github.com/users/gandalfcode/repos","events_url":"https://api.github.com/users/gandalfcode/events{/privacy}","received_events_url":"https://api.github.com/users/gandalfcode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gandalfcode/gandalf","description":"GANDALF (Graphical Astrophysics code for N-body Dynamics And Lagrangian Fluids)","fork":false,"url":"https://api.github.com/repos/gandalfcode/gandalf","forks_url":"https://api.github.com/repos/gandalfcode/gandalf/forks","keys_url":"https://api.github.com/repos/gandalfcode/gandalf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gandalfcode/gandalf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gandalfcode/gandalf/teams","hooks_url":"https://api.github.com/repos/gandalfcode/gandalf/hooks","issue_events_url":"https://api.github.com/repos/gandalfcode/gandalf/issues/events{/number}","events_url":"https://api.github.com/repos/gandalfcode/gandalf/events","assignees_url":"https://api.github.com/repos/gandalfcode/gandalf/assignees{/user}","branches_url":"https://api.github.com/repos/gandalfcode/gandalf/branches{/branch}","tags_url":"https://api.github.com/repos/gandalfcode/gandalf/tags","blobs_url":"https://api.github.com/repos/gandalfcode/gandalf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gandalfcode/gandalf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gandalfcode/gandalf/git/refs{/sha}","trees_url":"https://api.github.com/repos/gandalfcode/gandalf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gandalfcode/gandalf/statuses/{sha}","languages_url":"https://api.github.com/repos/gandalfcode/gandalf/languages","stargazers_url":"https://api.github.com/repos/gandalfcode/gandalf/stargazers","contributors_url":"https://api.github.com/repos/gandalfcode/gandalf/contributors","subscribers_url":"https://api.github.com/repos/gandalfcode/gandalf/subscribers","subscription_url":"https://api.github.com/repos/gandalfcode/gandalf/subscription","commits_url":"https://api.github.com/repos/gandalfcode/gandalf/commits{/sha}","git_commits_url":"https://api.github.com/repos/gandalfcode/gandalf/git/commits{/sha}","comments_url":"https://api.github.com/repos/gandalfcode/gandalf/comments{/number}","issue_comment_url":"https://api.github.com/repos/gandalfcode/gandalf/issues/comments{/number}","contents_url":"https://api.github.com/repos/gandalfcode/gandalf/contents/{+path}","compare_url":"https://api.github.com/repos/gandalfcode/gandalf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gandalfcode/gandalf/merges","archive_url":"https://api.github.com/repos/gandalfcode/gandalf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gandalfcode/gandalf/downloads","issues_url":"https://api.github.com/repos/gandalfcode/gandalf/issues{/number}","pulls_url":"https://api.github.com/repos/gandalfcode/gandalf/pulls{/number}","milestones_url":"https://api.github.com/repos/gandalfcode/gandalf/milestones{/number}","notifications_url":"https://api.github.com/repos/gandalfcode/gandalf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gandalfcode/gandalf/labels{/name}","releases_url":"https://api.github.com/repos/gandalfcode/gandalf/releases{/id}","deployments_url":"https://api.github.com/repos/gandalfcode/gandalf/deployments","created_at":"2013-07-29T12:36:37Z","updated_at":"2016-10-28T10:23:15Z","pushed_at":"2016-12-19T10:27:45Z","git_url":"git://github.com/gandalfcode/gandalf.git","ssh_url":"git@github.com:gandalfcode/gandalf.git","clone_url":"https://github.com/gandalfcode/gandalf.git","svn_url":"https://github.com/gandalfcode/gandalf","homepage":null,"size":7023,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":35,"forks":3,"open_issues":35,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gandalfcode/gandalf/pulls/118"},"html":{"href":"https://github.com/gandalfcode/gandalf/pull/118"},"issue":{"href":"https://api.github.com/repos/gandalfcode/gandalf/issues/118"},"comments":{"href":"https://api.github.com/repos/gandalfcode/gandalf/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/gandalfcode/gandalf/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/gandalfcode/gandalf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gandalfcode/gandalf/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/gandalfcode/gandalf/statuses/5d61c6ddea3f91a7e009c178855caaf9188b468b"}}}}
{"actor":{"display_login":"giovanni-rosotti"}}