{"action":"created","comment":{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/comments/80220603","id":80220603,"diff_hunk":"@@ -92,4 +96,6 @@ default boolean forceSpawnEntity(Entity entity) {\n \n     void triggerInternalExplosion(Explosion explosion);\n \n+    void playSound(@Nullable EntityPlayer player, double x, double y, double z, String soundIn, SoundCategory category, float volume, float pitch);","path":"src/main/java/org/spongepowered/common/interfaces/world/IMixinWorldServer.java","position":22,"original_position":22,"commit_id":"60d472f7ac3ac658f72df677cb5c75916915ef0a","original_commit_id":"60d472f7ac3ac658f72df677cb5c75916915ef0a","user":{"login":"kashike","id":5474071,"avatar_url":"https://avatars.githubusercontent.com/u/5474071?v=3","gravatar_id":"","url":"https://api.github.com/users/kashike","html_url":"https://github.com/kashike","followers_url":"https://api.github.com/users/kashike/followers","following_url":"https://api.github.com/users/kashike/following{/other_user}","gists_url":"https://api.github.com/users/kashike/gists{/gist_id}","starred_url":"https://api.github.com/users/kashike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kashike/subscriptions","organizations_url":"https://api.github.com/users/kashike/orgs","repos_url":"https://api.github.com/users/kashike/repos","events_url":"https://api.github.com/users/kashike/events{/privacy}","received_events_url":"https://api.github.com/users/kashike/received_events","type":"User","site_admin":false},"body":"Again, why `String` method","created_at":"2016-09-23T10:36:00Z","updated_at":"2016-09-23T10:36:08Z","html_url":"https://github.com/SpongePowered/SpongeCommon/pull/955#discussion_r80220603","pull_request_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/955","_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/comments/80220603"},"html":{"href":"https://github.com/SpongePowered/SpongeCommon/pull/955#discussion_r80220603"},"pull_request":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/955"}}},"pull_request":{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/955","id":86449347,"html_url":"https://github.com/SpongePowered/SpongeCommon/pull/955","diff_url":"https://github.com/SpongePowered/SpongeCommon/pull/955.diff","patch_url":"https://github.com/SpongePowered/SpongeCommon/pull/955.patch","issue_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/955","number":955,"state":"open","locked":false,"title":"Implement SoundType changes","user":{"login":"ZephireNZ","id":1644496,"avatar_url":"https://avatars.githubusercontent.com/u/1644496?v=3","gravatar_id":"","url":"https://api.github.com/users/ZephireNZ","html_url":"https://github.com/ZephireNZ","followers_url":"https://api.github.com/users/ZephireNZ/followers","following_url":"https://api.github.com/users/ZephireNZ/following{/other_user}","gists_url":"https://api.github.com/users/ZephireNZ/gists{/gist_id}","starred_url":"https://api.github.com/users/ZephireNZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZephireNZ/subscriptions","organizations_url":"https://api.github.com/users/ZephireNZ/orgs","repos_url":"https://api.github.com/users/ZephireNZ/repos","events_url":"https://api.github.com/users/ZephireNZ/events{/privacy}","received_events_url":"https://api.github.com/users/ZephireNZ/received_events","type":"User","site_admin":false},"body":"[API](https://github.com/SpongePowered/SpongeAPI/pull/1364) | **Common** | [Forge](https://github.com/SpongePowered/SpongeForge/pull/923)\r\n\r\nThis PR fixed the issues with the `SoundType` implementation seen here: #954\r\n\r\n- Allow for building a `SoundType`\r\n- Redirect non-registered sounds to use the custom sound packet, as they do not have an int ID\r\n- Fix up the registry so that IDs can be fetched by \"my.sound.id\" instead of \"my_sound_id\"\r\n- Make registry support additional sounds (which are added in the forge PR)\r\n\r\nTest code:\r\n```\r\nTO COME\r\n```","created_at":"2016-09-23T03:33:14Z","updated_at":"2016-09-23T10:36:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fba33495b2179d1dcebb2ba7a3f1609942e3c26","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/955/commits","review_comments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/955/comments","review_comment_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/955/comments","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/statuses/60d472f7ac3ac658f72df677cb5c75916915ef0a","head":{"label":"ZephireNZ:feature/sounds","ref":"feature/sounds","sha":"60d472f7ac3ac658f72df677cb5c75916915ef0a","user":{"login":"ZephireNZ","id":1644496,"avatar_url":"https://avatars.githubusercontent.com/u/1644496?v=3","gravatar_id":"","url":"https://api.github.com/users/ZephireNZ","html_url":"https://github.com/ZephireNZ","followers_url":"https://api.github.com/users/ZephireNZ/followers","following_url":"https://api.github.com/users/ZephireNZ/following{/other_user}","gists_url":"https://api.github.com/users/ZephireNZ/gists{/gist_id}","starred_url":"https://api.github.com/users/ZephireNZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZephireNZ/subscriptions","organizations_url":"https://api.github.com/users/ZephireNZ/orgs","repos_url":"https://api.github.com/users/ZephireNZ/repos","events_url":"https://api.github.com/users/ZephireNZ/events{/privacy}","received_events_url":"https://api.github.com/users/ZephireNZ/received_events","type":"User","site_admin":false},"repo":{"id":42989058,"name":"SpongeCommon","full_name":"ZephireNZ/SpongeCommon","owner":{"login":"ZephireNZ","id":1644496,"avatar_url":"https://avatars.githubusercontent.com/u/1644496?v=3","gravatar_id":"","url":"https://api.github.com/users/ZephireNZ","html_url":"https://github.com/ZephireNZ","followers_url":"https://api.github.com/users/ZephireNZ/followers","following_url":"https://api.github.com/users/ZephireNZ/following{/other_user}","gists_url":"https://api.github.com/users/ZephireNZ/gists{/gist_id}","starred_url":"https://api.github.com/users/ZephireNZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZephireNZ/subscriptions","organizations_url":"https://api.github.com/users/ZephireNZ/orgs","repos_url":"https://api.github.com/users/ZephireNZ/repos","events_url":"https://api.github.com/users/ZephireNZ/events{/privacy}","received_events_url":"https://api.github.com/users/ZephireNZ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ZephireNZ/SpongeCommon","description":"Shared code between Sponge and SpongeVanilla","fork":true,"url":"https://api.github.com/repos/ZephireNZ/SpongeCommon","forks_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/forks","keys_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/teams","hooks_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/hooks","issue_events_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/issues/events{/number}","events_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/events","assignees_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/assignees{/user}","branches_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/branches{/branch}","tags_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/tags","blobs_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/statuses/{sha}","languages_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/languages","stargazers_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/stargazers","contributors_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/contributors","subscribers_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/subscribers","subscription_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/subscription","commits_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/contents/{+path}","compare_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/merges","archive_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/downloads","issues_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/issues{/number}","pulls_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/pulls{/number}","milestones_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/milestones{/number}","notifications_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/labels{/name}","releases_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/releases{/id}","deployments_url":"https://api.github.com/repos/ZephireNZ/SpongeCommon/deployments","created_at":"2015-09-23T08:42:46Z","updated_at":"2016-01-15T01:50:01Z","pushed_at":"2016-09-23T03:21:58Z","git_url":"git://github.com/ZephireNZ/SpongeCommon.git","ssh_url":"git@github.com:ZephireNZ/SpongeCommon.git","clone_url":"https://github.com/ZephireNZ/SpongeCommon.git","svn_url":"https://github.com/ZephireNZ/SpongeCommon","homepage":null,"size":16421,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SpongePowered:bleeding","ref":"bleeding","sha":"e9e69aa29a7e18e423c1483dc5855706ca54242c","user":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":33791453,"name":"SpongeCommon","full_name":"SpongePowered/SpongeCommon","owner":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpongePowered/SpongeCommon","description":"Shared code between SpongeForge and SpongeVanilla","fork":false,"url":"https://api.github.com/repos/SpongePowered/SpongeCommon","forks_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/forks","keys_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/teams","hooks_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/events","assignees_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/tags","blobs_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/subscription","commits_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/merges","archive_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/downloads","issues_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/releases{/id}","deployments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/deployments","created_at":"2015-04-11T20:38:48Z","updated_at":"2016-09-14T20:12:48Z","pushed_at":"2016-09-23T03:33:14Z","git_url":"git://github.com/SpongePowered/SpongeCommon.git","ssh_url":"git@github.com:SpongePowered/SpongeCommon.git","clone_url":"https://github.com/SpongePowered/SpongeCommon.git","svn_url":"https://github.com/SpongePowered/SpongeCommon","homepage":"","size":22409,"stargazers_count":93,"watchers_count":93,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":89,"mirror_url":null,"open_issues_count":131,"forks":89,"open_issues":131,"watchers":93,"default_branch":"bleeding"}},"_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/955"},"html":{"href":"https://github.com/SpongePowered/SpongeCommon/pull/955"},"issue":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/955"},"comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/955/comments"},"review_comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/955/comments"},"review_comment":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/955/commits"},"statuses":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/statuses/60d472f7ac3ac658f72df677cb5c75916915ef0a"}}}}
{"actor":{"display_login":"kashike"}}