{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/college-costs/issues/73","labels_url":"https://api.github.com/repos/cfpb/college-costs/issues/73/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/college-costs/issues/73/comments","events_url":"https://api.github.com/repos/cfpb/college-costs/issues/73/events","html_url":"https://github.com/cfpb/college-costs/pull/73","id":127436261,"number":73,"title":"Functional tests for evaluating an offer","user":{"login":"marteki","id":1183435,"avatar_url":"https://avatars.githubusercontent.com/u/1183435?v=3","gravatar_id":"","url":"https://api.github.com/users/marteki","html_url":"https://github.com/marteki","followers_url":"https://api.github.com/users/marteki/followers","following_url":"https://api.github.com/users/marteki/following{/other_user}","gists_url":"https://api.github.com/users/marteki/gists{/gist_id}","starred_url":"https://api.github.com/users/marteki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marteki/subscriptions","organizations_url":"https://api.github.com/users/marteki/orgs","repos_url":"https://api.github.com/users/marteki/repos","events_url":"https://api.github.com/users/marteki/events{/privacy}","received_events_url":"https://api.github.com/users/marteki/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-01-19T12:35:30Z","updated_at":"2016-01-22T22:10:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cfpb/college-costs/pulls/73","html_url":"https://github.com/cfpb/college-costs/pull/73","diff_url":"https://github.com/cfpb/college-costs/pull/73.diff","patch_url":"https://github.com/cfpb/college-costs/pull/73.patch"},"body":"More functional tests. This time for evaluating an offer.\r\n\r\n## Additions\r\n- Added new tests for estimated monthly expenses (with added IDs to the worksheet).\r\n- Added commented-out placeholder tests for incoming JS functions for estimated expenses\r\n\r\n## Testing\r\n\r\nPull in the `functional-tests` branch and run `npm install`.\r\n\r\nMake sure you have webdriver and protractor all set up:\r\n\r\n```bash\r\nnpm install -g webdriver-manager protractor\r\nwebdriver-manager update --standalone\r\n```\r\n\r\nRun `gulp`, and load the standalone server using `python manage.py runserver`. \r\n\r\nTo run the tests:\r\n\r\n```bash\r\n# Open a new terminal tab, and start webdriver:\r\nwebdriver-manager start\r\n# Open a third tab, and run:\r\nprotractor test/functional/conf.js\r\n```\r\n\r\nYou should eventually see something like the following:\r\n\r\n```\r\nUsing the selenium server at http://localhost:4444/wd/hub\r\n[launcher] Running 1 instances of WebDriver\r\nStarted\r\n................................\r\n\r\n\r\n32 specs, 0 failures\r\nFinished in 55.862 seconds\r\n[launcher] 0 instance(s) of WebDriver still running\r\n[launcher] chrome #1 passed\r\n```\r\n\r\n## Review\r\n\r\n- Some combination of: @mistergone @higs4281 @niqjohnson @ascott1 or any other interested parties\r\n\r\n## To do next\r\n\r\n- Work with @mistergone on creating tests for multiple private loans\r\n\r\n## Checklist\r\n\r\n* [X] Changes are limited to a single goal (no scope creep)\r\n* [X] Code can be automatically merged (no conflicts)\r\n* [X] Code follows the standards laid out in the [front end playbook](https://github.com/cfpb/front-end)\r\n* [ ] Passes all existing automated tests\r\n* [X] Placeholder code is flagged\r\n* [X] Visually tested in supported browsers and devices"},"comment":{"url":"https://api.github.com/repos/cfpb/college-costs/issues/comments/174069211","html_url":"https://github.com/cfpb/college-costs/pull/73#issuecomment-174069211","issue_url":"https://api.github.com/repos/cfpb/college-costs/issues/73","id":174069211,"user":{"login":"marteki","id":1183435,"avatar_url":"https://avatars.githubusercontent.com/u/1183435?v=3","gravatar_id":"","url":"https://api.github.com/users/marteki","html_url":"https://github.com/marteki","followers_url":"https://api.github.com/users/marteki/followers","following_url":"https://api.github.com/users/marteki/following{/other_user}","gists_url":"https://api.github.com/users/marteki/gists{/gist_id}","starred_url":"https://api.github.com/users/marteki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marteki/subscriptions","organizations_url":"https://api.github.com/users/marteki/orgs","repos_url":"https://api.github.com/users/marteki/repos","events_url":"https://api.github.com/users/marteki/events{/privacy}","received_events_url":"https://api.github.com/users/marteki/received_events","type":"User","site_admin":false},"created_at":"2016-01-22T22:10:59Z","updated_at":"2016-01-22T22:10:59Z","body":"Merging, and we can improve as we go from here."}}