{"action":"created","issue":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1837","repository_url":"https://api.github.com/repos/hpcugent/easybuild-framework","labels_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1837/labels{/name}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1837/comments","events_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1837/events","html_url":"https://github.com/hpcugent/easybuild-framework/pull/1837","id":164332233,"number":1837,"title":"Add support for 'hidden=True' easyconfig parameter","user":{"login":"geimer","id":5525690,"avatar_url":"https://avatars.githubusercontent.com/u/5525690?v=3","gravatar_id":"","url":"https://api.github.com/users/geimer","html_url":"https://github.com/geimer","followers_url":"https://api.github.com/users/geimer/followers","following_url":"https://api.github.com/users/geimer/following{/other_user}","gists_url":"https://api.github.com/users/geimer/gists{/gist_id}","starred_url":"https://api.github.com/users/geimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geimer/subscriptions","organizations_url":"https://api.github.com/users/geimer/orgs","repos_url":"https://api.github.com/users/geimer/repos","events_url":"https://api.github.com/users/geimer/events{/privacy}","received_events_url":"https://api.github.com/users/geimer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/milestones/37","html_url":"https://github.com/hpcugent/easybuild-framework/milestones/v2.9.0","labels_url":"https://api.github.com/repos/hpcugent/easybuild-framework/milestones/37/labels","id":1758736,"number":37,"title":"v2.9.0","description":"","creator":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":43,"state":"open","created_at":"2016-05-10T19:31:46Z","updated_at":"2016-07-07T15:16:37Z","due_on":"2016-08-30T22:00:00Z","closed_at":null},"comments":5,"created_at":"2016-07-07T15:06:59Z","updated_at":"2016-07-08T07:18:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1837","html_url":"https://github.com/hpcugent/easybuild-framework/pull/1837","diff_url":"https://github.com/hpcugent/easybuild-framework/pull/1837.diff","patch_url":"https://github.com/hpcugent/easybuild-framework/pull/1837.patch"},"body":"This complements the '--hidden' command-line option."},"comment":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/comments/231292264","html_url":"https://github.com/hpcugent/easybuild-framework/pull/1837#issuecomment-231292264","issue_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1837","id":231292264,"user":{"login":"geimer","id":5525690,"avatar_url":"https://avatars.githubusercontent.com/u/5525690?v=3","gravatar_id":"","url":"https://api.github.com/users/geimer","html_url":"https://github.com/geimer","followers_url":"https://api.github.com/users/geimer/followers","following_url":"https://api.github.com/users/geimer/following{/other_user}","gists_url":"https://api.github.com/users/geimer/gists{/gist_id}","starred_url":"https://api.github.com/users/geimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geimer/subscriptions","organizations_url":"https://api.github.com/users/geimer/orgs","repos_url":"https://api.github.com/users/geimer/repos","events_url":"https://api.github.com/users/geimer/events{/privacy}","received_events_url":"https://api.github.com/users/geimer/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T07:18:21Z","updated_at":"2016-07-08T07:18:21Z","body":"@boegel: Still trying to understand the code...\r\n\r\nShouldn't the update in https://github.com/geimer/easybuild-framework/blob/5d9a56a543eb7f8e078d6aa737077cfc23be40ed/easybuild/framework/easyconfig/easyconfig.py#L1230 be `'hidden': ec.hidden`?  Then the first query to `build_option('hidden')` only affects the cache lookup, which should be OK as the data in the cache should already include parsed values.  The update then takes the actual parsed value into account, determined in the `EasyConfig` constructor based on the build option and the easyconfig parameter.\r\n\r\nThe thing is that the `easyconfig` unit tests all pass, regardless of what the update does.  I can even hard-code it to `True` or `False`...\r\n\r\nBTW: There is a docstring for the `parse_only` parameter missing."}}
{"actor":{"display_login":"geimer"}}