{"action":"created","comment":{"url":"https://api.github.com/repos/pydata/pandas/pulls/comments/71970999","id":71970999,"diff_hunk":"@@ -184,6 +185,52 @@ def test_get_reverse_indexer(self):\n         self.assertTrue(np.array_equal(result, expected))\n \n \n+class TestNullObj(tm.TestCase):\n+\n+    def test_basic(self):\n+        arr = np.array([1, None, 'foo', -5.1, pd.NaT, np.nan])\n+        expected = np.array([False, True, False, False, True, True])\n+\n+        result = lib.isnullobj(arr)\n+        tm.assert_numpy_array_equal(result, expected)\n+\n+    def test_non_ndarray_inp(self):\n+        ind = pd.Index([1, None, 'foo', -5.1, pd.NaT, np.nan])","path":"pandas/tests/test_lib.py","position":22,"original_position":22,"commit_id":"eb1e8ee974760a60e3bd1c2dfc0add2bf609f55d","original_commit_id":"eb1e8ee974760a60e3bd1c2dfc0add2bf609f55d","user":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"put all of these tests with the null tests - you will have to find them ","created_at":"2016-07-23T10:54:28Z","updated_at":"2016-07-23T10:54:28Z","html_url":"https://github.com/pydata/pandas/pull/13764#discussion_r71970999","pull_request_url":"https://api.github.com/repos/pydata/pandas/pulls/13764","_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/71970999"},"html":{"href":"https://github.com/pydata/pandas/pull/13764#discussion_r71970999"},"pull_request":{"href":"https://api.github.com/repos/pydata/pandas/pulls/13764"}}},"pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/13764","id":78568545,"html_url":"https://github.com/pydata/pandas/pull/13764","diff_url":"https://github.com/pydata/pandas/pull/13764.diff","patch_url":"https://github.com/pydata/pandas/pull/13764.patch","issue_url":"https://api.github.com/repos/pydata/pandas/issues/13764","number":13764,"state":"open","locked":false,"title":"BUG: Fix segfault in lib.isnullobj","user":{"login":"gfyoung","id":9273653,"avatar_url":"https://avatars.githubusercontent.com/u/9273653?v=3","gravatar_id":"","url":"https://api.github.com/users/gfyoung","html_url":"https://github.com/gfyoung","followers_url":"https://api.github.com/users/gfyoung/followers","following_url":"https://api.github.com/users/gfyoung/following{/other_user}","gists_url":"https://api.github.com/users/gfyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/gfyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfyoung/subscriptions","organizations_url":"https://api.github.com/users/gfyoung/orgs","repos_url":"https://api.github.com/users/gfyoung/repos","events_url":"https://api.github.com/users/gfyoung/events{/privacy}","received_events_url":"https://api.github.com/users/gfyoung/received_events","type":"User","site_admin":false},"body":"Weird segfault arises when you call `lib.isnullobj` with an array that uses 0-field values to mean `None`.\r\nChanged input to be a `Python` object (i.e. no typing), and the segfault went away.  Discovered when there were segfaults in printing a `DataFrame` containing such an array.\r\n\r\nCloses #13717.","created_at":"2016-07-23T09:54:08Z","updated_at":"2016-07-23T10:54:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"440d840471a3f2abbc307a778b9615f20ba36918","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pydata/pandas/pulls/13764/commits","review_comments_url":"https://api.github.com/repos/pydata/pandas/pulls/13764/comments","review_comment_url":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/13764/comments","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/eb1e8ee974760a60e3bd1c2dfc0add2bf609f55d","head":{"label":"gfyoung:isnullobj-segfault","ref":"isnullobj-segfault","sha":"eb1e8ee974760a60e3bd1c2dfc0add2bf609f55d","user":{"login":"gfyoung","id":9273653,"avatar_url":"https://avatars.githubusercontent.com/u/9273653?v=3","gravatar_id":"","url":"https://api.github.com/users/gfyoung","html_url":"https://github.com/gfyoung","followers_url":"https://api.github.com/users/gfyoung/followers","following_url":"https://api.github.com/users/gfyoung/following{/other_user}","gists_url":"https://api.github.com/users/gfyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/gfyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfyoung/subscriptions","organizations_url":"https://api.github.com/users/gfyoung/orgs","repos_url":"https://api.github.com/users/gfyoung/repos","events_url":"https://api.github.com/users/gfyoung/events{/privacy}","received_events_url":"https://api.github.com/users/gfyoung/received_events","type":"User","site_admin":false},"repo":{"id":51449909,"name":"pandas","full_name":"gfyoung/pandas","owner":{"login":"gfyoung","id":9273653,"avatar_url":"https://avatars.githubusercontent.com/u/9273653?v=3","gravatar_id":"","url":"https://api.github.com/users/gfyoung","html_url":"https://github.com/gfyoung","followers_url":"https://api.github.com/users/gfyoung/followers","following_url":"https://api.github.com/users/gfyoung/following{/other_user}","gists_url":"https://api.github.com/users/gfyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/gfyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfyoung/subscriptions","organizations_url":"https://api.github.com/users/gfyoung/orgs","repos_url":"https://api.github.com/users/gfyoung/repos","events_url":"https://api.github.com/users/gfyoung/events{/privacy}","received_events_url":"https://api.github.com/users/gfyoung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gfyoung/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/gfyoung/pandas","forks_url":"https://api.github.com/repos/gfyoung/pandas/forks","keys_url":"https://api.github.com/repos/gfyoung/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gfyoung/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gfyoung/pandas/teams","hooks_url":"https://api.github.com/repos/gfyoung/pandas/hooks","issue_events_url":"https://api.github.com/repos/gfyoung/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/gfyoung/pandas/events","assignees_url":"https://api.github.com/repos/gfyoung/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/gfyoung/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/gfyoung/pandas/tags","blobs_url":"https://api.github.com/repos/gfyoung/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gfyoung/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gfyoung/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/gfyoung/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gfyoung/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/gfyoung/pandas/languages","stargazers_url":"https://api.github.com/repos/gfyoung/pandas/stargazers","contributors_url":"https://api.github.com/repos/gfyoung/pandas/contributors","subscribers_url":"https://api.github.com/repos/gfyoung/pandas/subscribers","subscription_url":"https://api.github.com/repos/gfyoung/pandas/subscription","commits_url":"https://api.github.com/repos/gfyoung/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/gfyoung/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/gfyoung/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/gfyoung/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/gfyoung/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/gfyoung/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gfyoung/pandas/merges","archive_url":"https://api.github.com/repos/gfyoung/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gfyoung/pandas/downloads","issues_url":"https://api.github.com/repos/gfyoung/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/gfyoung/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/gfyoung/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/gfyoung/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gfyoung/pandas/labels{/name}","releases_url":"https://api.github.com/repos/gfyoung/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/gfyoung/pandas/deployments","created_at":"2016-02-10T15:31:30Z","updated_at":"2016-02-10T15:31:35Z","pushed_at":"2016-07-23T09:53:23Z","git_url":"git://github.com/gfyoung/pandas.git","ssh_url":"git@github.com:gfyoung/pandas.git","clone_url":"https://github.com/gfyoung/pandas.git","svn_url":"https://github.com/gfyoung/pandas","homepage":"http://pandas.pydata.org","size":83433,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"9f94e6a04564e8269b43c5b4e83854d277ea30bd","user":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pydata/pandas","owner":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydata/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pydata/pandas","forks_url":"https://api.github.com/repos/pydata/pandas/forks","keys_url":"https://api.github.com/repos/pydata/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/pandas/teams","hooks_url":"https://api.github.com/repos/pydata/pandas/hooks","issue_events_url":"https://api.github.com/repos/pydata/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/pandas/events","assignees_url":"https://api.github.com/repos/pydata/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/pandas/tags","blobs_url":"https://api.github.com/repos/pydata/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/pandas/languages","stargazers_url":"https://api.github.com/repos/pydata/pandas/stargazers","contributors_url":"https://api.github.com/repos/pydata/pandas/contributors","subscribers_url":"https://api.github.com/repos/pydata/pandas/subscribers","subscription_url":"https://api.github.com/repos/pydata/pandas/subscription","commits_url":"https://api.github.com/repos/pydata/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pydata/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/pandas/merges","archive_url":"https://api.github.com/repos/pydata/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/pandas/downloads","issues_url":"https://api.github.com/repos/pydata/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pydata/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pydata/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2016-07-23T00:59:59Z","pushed_at":"2016-07-23T09:54:09Z","git_url":"git://github.com/pydata/pandas.git","ssh_url":"git@github.com:pydata/pandas.git","clone_url":"https://github.com/pydata/pandas.git","svn_url":"https://github.com/pydata/pandas","homepage":"http://pandas.pydata.org","size":153726,"stargazers_count":6695,"watchers_count":6695,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2768,"mirror_url":null,"open_issues_count":1827,"forks":2768,"open_issues":1827,"watchers":6695,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/13764"},"html":{"href":"https://github.com/pydata/pandas/pull/13764"},"issue":{"href":"https://api.github.com/repos/pydata/pandas/issues/13764"},"comments":{"href":"https://api.github.com/repos/pydata/pandas/issues/13764/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/pandas/pulls/13764/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pydata/pandas/pulls/13764/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/pandas/statuses/eb1e8ee974760a60e3bd1c2dfc0add2bf609f55d"}}}}
{"actor":{"display_login":"jreback"}}