{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8589","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8589/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8589/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8589/events","html_url":"https://github.com/cockroachdb/cockroach/pull/8589","id":171495396,"number":8589,"title":"storage: add service definitions for CollectChecksum()","user":{"login":"eisenstatdavid","id":3858570,"avatar_url":"https://avatars.githubusercontent.com/u/3858570?v=3","gravatar_id":"","url":"https://api.github.com/users/eisenstatdavid","html_url":"https://github.com/eisenstatdavid","followers_url":"https://api.github.com/users/eisenstatdavid/followers","following_url":"https://api.github.com/users/eisenstatdavid/following{/other_user}","gists_url":"https://api.github.com/users/eisenstatdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/eisenstatdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eisenstatdavid/subscriptions","organizations_url":"https://api.github.com/users/eisenstatdavid/orgs","repos_url":"https://api.github.com/users/eisenstatdavid/repos","events_url":"https://api.github.com/users/eisenstatdavid/events{/privacy}","received_events_url":"https://api.github.com/users/eisenstatdavid/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-16T19:17:43Z","updated_at":"2016-08-16T19:30:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/8589","html_url":"https://github.com/cockroachdb/cockroach/pull/8589","diff_url":"https://github.com/cockroachdb/cockroach/pull/8589.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/8589.patch"},"body":"We're changing how consistency checks exchange snaphots, per #7739 and\r\nthe updated consistency checker RFC.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/8589)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/240211768","html_url":"https://github.com/cockroachdb/cockroach/pull/8589#issuecomment-240211768","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8589","id":240211768,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T19:30:19Z","updated_at":"2016-08-16T19:30:19Z","body":"Seems OK at a glance, but -1 on merging this by itself before there's code using it.\n\n---\n\nReviewed 1 of 1 files at r1.\nReview status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks pending.\n\n---\n\n*[storage/api.proto, line 22 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/8589#-KPJohyeiFtYT0gYV8NC:-KPJohyeiFtYT0gYV8ND:b-15e1qv) ([raw file](https://github.com/cockroachdb/cockroach/blob/bffd4dcba32c172ec3d450d3d10b0606708d694e/storage/api.proto#L22)):*\n> ```protobuf\n> \n> import \"cockroach/roachpb/metadata.proto\";\n> import weak \"cockroach/roachpb/internal_raft.proto\";\n> ```\n\n\"weak\" is incorrect here. it is used for `gogo.proto` because that proto provides only compile-time annotations and is not needed at runtime.\n\n---\n\n*[storage/api.proto, line 78 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/8589#-KPJoqkdQcS1gF_HHDBZ:-KPJoqkdQcS1gF_HHDB_:b-b4uyr5) ([raw file](https://github.com/cockroachdb/cockroach/blob/bffd4dcba32c172ec3d450d3d10b0606708d694e/storage/api.proto#L78)):*\n> ```protobuf\n> // blocks until the checksum is ready.\n> message CollectChecksumRequest {\n>   roachpb.ReplicaDescriptor replica = 1 [ (gogoproto.nullable = false) ];\n> ```\n\nthroughout: spurious spaces after `[` and before `]`\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/8589#-:-KPJpF3oFqtNo4_FEtsH:b-gwyulu)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"tamird"}}