{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/50844994","id":50844994,"diff_hunk":"@@ -126,7 +128,16 @@ def validate_proposal_after_save proposal\n       if backend_driver == \"rbd\"\n         rbd_crowbar ||= volume[\"rbd\"][\"use_crowbar\"]\n         rbd_ceph_conf ||= !volume[\"rbd\"][\"use_crowbar\"] && (volume[\"rbd\"][\"config_file\"].strip == \"/etc/ceph/ceph.conf\")\n+\n+        # Because of the limitation in libvirt that you can define one secret UUID per each username,\n+        # we have to check and prevent this scenario when we define multiply RADOS instances.\n+        if rbd_ceph_users[volume[\"rbd\"][\"user\"]]\n+          rbd_virsh_users_check ||= rbd_ceph_users[volume[\"rbd\"][\"user\"]] != volume[\"rbd\"][\"config_file\"]","path":"crowbar_framework/app/models/cinder_service.rb","position":17,"original_position":17,"commit_id":"484d990eb46a57d08379539624af3fd7d1de91fe","original_commit_id":"484d990eb46a57d08379539624af3fd7d1de91fe","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Metrics/LineLength: Line is too long. [105/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)","created_at":"2016-01-26T15:00:15Z","updated_at":"2016-01-26T15:00:15Z","html_url":"https://github.com/crowbar/crowbar-openstack/pull/221#discussion_r50844994","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/221","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/50844994"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/221#discussion_r50844994"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/221"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/221","id":56897944,"html_url":"https://github.com/crowbar/crowbar-openstack/pull/221","diff_url":"https://github.com/crowbar/crowbar-openstack/pull/221.diff","patch_url":"https://github.com/crowbar/crowbar-openstack/pull/221.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/221","number":221,"state":"open","locked":false,"title":"Fix issue with \"libvirtError: Secret not found\" for multi rbd backend,  (bsc#963029)","user":{"login":"mjura","id":4455471,"avatar_url":"https://avatars.githubusercontent.com/u/4455471?v=3","gravatar_id":"","url":"https://api.github.com/users/mjura","html_url":"https://github.com/mjura","followers_url":"https://api.github.com/users/mjura/followers","following_url":"https://api.github.com/users/mjura/following{/other_user}","gists_url":"https://api.github.com/users/mjura/gists{/gist_id}","starred_url":"https://api.github.com/users/mjura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjura/subscriptions","organizations_url":"https://api.github.com/users/mjura/orgs","repos_url":"https://api.github.com/users/mjura/repos","events_url":"https://api.github.com/users/mjura/events{/privacy}","received_events_url":"https://api.github.com/users/mjura/received_events","type":"User","site_admin":false},"body":"This change is fixing issue with \"libvirtError: Secret not found: rbd no secret matches uuid\"\r\n\r\nFor more details please go to https://bugzilla.suse.com/show_bug.cgi?id=963029","created_at":"2016-01-22T15:02:38Z","updated_at":"2016-01-26T15:00:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cd04b79ebc202ece828a196003f525cb4b2716f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/221/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/221/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/221/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/484d990eb46a57d08379539624af3fd7d1de91fe","head":{"label":"mjura:virsh_secret","ref":"virsh_secret","sha":"484d990eb46a57d08379539624af3fd7d1de91fe","user":{"login":"mjura","id":4455471,"avatar_url":"https://avatars.githubusercontent.com/u/4455471?v=3","gravatar_id":"","url":"https://api.github.com/users/mjura","html_url":"https://github.com/mjura","followers_url":"https://api.github.com/users/mjura/followers","following_url":"https://api.github.com/users/mjura/following{/other_user}","gists_url":"https://api.github.com/users/mjura/gists{/gist_id}","starred_url":"https://api.github.com/users/mjura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjura/subscriptions","organizations_url":"https://api.github.com/users/mjura/orgs","repos_url":"https://api.github.com/users/mjura/repos","events_url":"https://api.github.com/users/mjura/events{/privacy}","received_events_url":"https://api.github.com/users/mjura/received_events","type":"User","site_admin":false},"repo":{"id":42586630,"name":"crowbar-openstack","full_name":"mjura/crowbar-openstack","owner":{"login":"mjura","id":4455471,"avatar_url":"https://avatars.githubusercontent.com/u/4455471?v=3","gravatar_id":"","url":"https://api.github.com/users/mjura","html_url":"https://github.com/mjura","followers_url":"https://api.github.com/users/mjura/followers","following_url":"https://api.github.com/users/mjura/following{/other_user}","gists_url":"https://api.github.com/users/mjura/gists{/gist_id}","starred_url":"https://api.github.com/users/mjura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjura/subscriptions","organizations_url":"https://api.github.com/users/mjura/orgs","repos_url":"https://api.github.com/users/mjura/repos","events_url":"https://api.github.com/users/mjura/events{/privacy}","received_events_url":"https://api.github.com/users/mjura/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjura/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/mjura/crowbar-openstack","forks_url":"https://api.github.com/repos/mjura/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/mjura/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjura/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjura/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/mjura/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/mjura/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/mjura/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/mjura/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/mjura/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/mjura/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/mjura/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjura/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjura/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjura/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjura/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/mjura/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/mjura/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/mjura/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/mjura/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/mjura/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/mjura/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjura/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjura/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjura/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjura/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/mjura/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjura/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/mjura/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjura/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/mjura/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/mjura/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/mjura/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/mjura/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjura/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/mjura/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/mjura/crowbar-openstack/deployments","created_at":"2015-09-16T12:48:05Z","updated_at":"2015-09-16T12:48:07Z","pushed_at":"2016-01-26T15:00:09Z","git_url":"git://github.com/mjura/crowbar-openstack.git","ssh_url":"git@github.com:mjura/crowbar-openstack.git","clone_url":"https://github.com/mjura/crowbar-openstack.git","svn_url":"https://github.com/mjura/crowbar-openstack","homepage":null,"size":15959,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"b150efdf164d854d022142eab1983f0d58fd47de","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006903,"name":"crowbar-openstack","full_name":"crowbar/crowbar-openstack","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-openstack","forks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/deployments","created_at":"2015-07-13T10:55:33Z","updated_at":"2016-01-11T12:29:07Z","pushed_at":"2016-01-26T15:00:09Z","git_url":"git://github.com/crowbar/crowbar-openstack.git","ssh_url":"git@github.com:crowbar/crowbar-openstack.git","clone_url":"https://github.com/crowbar/crowbar-openstack.git","svn_url":"https://github.com/crowbar/crowbar-openstack","homepage":null,"size":16267,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":27,"forks":21,"open_issues":27,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/221"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/221"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/221"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/221/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/221/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/221/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/484d990eb46a57d08379539624af3fd7d1de91fe"}}}}