{"action":"created","comment":{"url":"https://api.github.com/repos/pypa/setuptools/pulls/comments/77599874","id":77599874,"diff_hunk":"@@ -212,6 +221,19 @@ def msvc14_get_vc_env(plat_spec):\n         raise\n \n \n+def msvc14_gen_lib_options(*args, **kwargs):\n+    \"\"\"\n+    Patched \"distutils._msvccompiler.gen_lib_options\" for fix \n+    compatibility between \"numpy.distutils\" and \"distutils._msvccompiler\"\n+    (for Numpy < 1.11.2)\n+    \"\"\"\n+    if \"numpy.distutils\" in sys.modules:\n+        import numpy as np\n+        if StrictVersion(np.__version__) < StrictVersion('1.11.2'):","path":"setuptools/msvc.py","position":48,"original_position":48,"commit_id":"8d1eecaef52a1baf2b9fc6c772880d8c537b562f","original_commit_id":"8d1eecaef52a1baf2b9fc6c772880d8c537b562f","user":{"login":"vallsv","id":7579321,"avatar_url":"https://avatars.githubusercontent.com/u/7579321?v=3","gravatar_id":"","url":"https://api.github.com/users/vallsv","html_url":"https://github.com/vallsv","followers_url":"https://api.github.com/users/vallsv/followers","following_url":"https://api.github.com/users/vallsv/following{/other_user}","gists_url":"https://api.github.com/users/vallsv/gists{/gist_id}","starred_url":"https://api.github.com/users/vallsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vallsv/subscriptions","organizations_url":"https://api.github.com/users/vallsv/orgs","repos_url":"https://api.github.com/users/vallsv/repos","events_url":"https://api.github.com/users/vallsv/events{/privacy}","received_events_url":"https://api.github.com/users/vallsv/received_events","type":"User","site_admin":false},"body":"One more patch https://github.com/pypa/setuptools/pull/775","created_at":"2016-09-06T09:20:54Z","updated_at":"2016-09-06T09:20:54Z","html_url":"https://github.com/pypa/setuptools/pull/739#discussion_r77599874","pull_request_url":"https://api.github.com/repos/pypa/setuptools/pulls/739","_links":{"self":{"href":"https://api.github.com/repos/pypa/setuptools/pulls/comments/77599874"},"html":{"href":"https://github.com/pypa/setuptools/pull/739#discussion_r77599874"},"pull_request":{"href":"https://api.github.com/repos/pypa/setuptools/pulls/739"}}},"pull_request":{"url":"https://api.github.com/repos/pypa/setuptools/pulls/739","id":81450405,"html_url":"https://github.com/pypa/setuptools/pull/739","diff_url":"https://github.com/pypa/setuptools/pull/739.diff","patch_url":"https://github.com/pypa/setuptools/pull/739.patch","issue_url":"https://api.github.com/repos/pypa/setuptools/issues/739","number":739,"state":"closed","locked":false,"title":"numpy.distutils and distutils._msvccompiler compatibility","user":{"login":"JGoutin","id":13535894,"avatar_url":"https://avatars.githubusercontent.com/u/13535894?v=3","gravatar_id":"","url":"https://api.github.com/users/JGoutin","html_url":"https://github.com/JGoutin","followers_url":"https://api.github.com/users/JGoutin/followers","following_url":"https://api.github.com/users/JGoutin/following{/other_user}","gists_url":"https://api.github.com/users/JGoutin/gists{/gist_id}","starred_url":"https://api.github.com/users/JGoutin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JGoutin/subscriptions","organizations_url":"https://api.github.com/users/JGoutin/orgs","repos_url":"https://api.github.com/users/JGoutin/repos","events_url":"https://api.github.com/users/JGoutin/events{/privacy}","received_events_url":"https://api.github.com/users/JGoutin/received_events","type":"User","site_admin":false},"body":"- Fix compatibility between `numpy.distutils` and `distutils._msvccompiler`. See #728 : Setuptools 24 `msvc.py` improvement import `distutils._msvccompiler` (New Python 3.5 C compiler for MSVC >= 14), but this one is not compatible with `numpy.distutils` (because not patched with `numpy.distutils.ccompiler.gen_lib_options`) and return unquoted libpaths when linking. The problem was patched in Numpy, but need to be patched also in Setuptools for compatibility between older versions of Numpy and `distutils._msvccompiler` (and indirectly Setuptools > 24).\r\n\r\nAlso some minor changes :\r\n- Replace some residuals `except Exception`.\r\n- PEP8.\r\n- Better history of the problem in Change.rst.","created_at":"2016-08-16T10:44:04Z","updated_at":"2016-09-06T09:20:54Z","closed_at":"2016-08-19T19:29:42Z","merged_at":"2016-08-19T19:29:42Z","merge_commit_sha":"5c940cc9d2e40a2f6717dd23e95342bad32a3b26","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pypa/setuptools/pulls/739/commits","review_comments_url":"https://api.github.com/repos/pypa/setuptools/pulls/739/comments","review_comment_url":"https://api.github.com/repos/pypa/setuptools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pypa/setuptools/issues/739/comments","statuses_url":"https://api.github.com/repos/pypa/setuptools/statuses/8d1eecaef52a1baf2b9fc6c772880d8c537b562f","head":{"label":"JGoutin:patch-1","ref":"patch-1","sha":"8d1eecaef52a1baf2b9fc6c772880d8c537b562f","user":{"login":"JGoutin","id":13535894,"avatar_url":"https://avatars.githubusercontent.com/u/13535894?v=3","gravatar_id":"","url":"https://api.github.com/users/JGoutin","html_url":"https://github.com/JGoutin","followers_url":"https://api.github.com/users/JGoutin/followers","following_url":"https://api.github.com/users/JGoutin/following{/other_user}","gists_url":"https://api.github.com/users/JGoutin/gists{/gist_id}","starred_url":"https://api.github.com/users/JGoutin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JGoutin/subscriptions","organizations_url":"https://api.github.com/users/JGoutin/orgs","repos_url":"https://api.github.com/users/JGoutin/repos","events_url":"https://api.github.com/users/JGoutin/events{/privacy}","received_events_url":"https://api.github.com/users/JGoutin/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"pypa:master","ref":"master","sha":"0addcafeb1c80ba1ffc57756ffe7e3f0210cee1f","user":{"login":"pypa","id":647025,"avatar_url":"https://avatars.githubusercontent.com/u/647025?v=3","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"repo":{"id":54980593,"name":"setuptools","full_name":"pypa/setuptools","owner":{"login":"pypa","id":647025,"avatar_url":"https://avatars.githubusercontent.com/u/647025?v=3","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pypa/setuptools","description":"Official project repository for the Setuptools build system","fork":false,"url":"https://api.github.com/repos/pypa/setuptools","forks_url":"https://api.github.com/repos/pypa/setuptools/forks","keys_url":"https://api.github.com/repos/pypa/setuptools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pypa/setuptools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pypa/setuptools/teams","hooks_url":"https://api.github.com/repos/pypa/setuptools/hooks","issue_events_url":"https://api.github.com/repos/pypa/setuptools/issues/events{/number}","events_url":"https://api.github.com/repos/pypa/setuptools/events","assignees_url":"https://api.github.com/repos/pypa/setuptools/assignees{/user}","branches_url":"https://api.github.com/repos/pypa/setuptools/branches{/branch}","tags_url":"https://api.github.com/repos/pypa/setuptools/tags","blobs_url":"https://api.github.com/repos/pypa/setuptools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pypa/setuptools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pypa/setuptools/git/refs{/sha}","trees_url":"https://api.github.com/repos/pypa/setuptools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pypa/setuptools/statuses/{sha}","languages_url":"https://api.github.com/repos/pypa/setuptools/languages","stargazers_url":"https://api.github.com/repos/pypa/setuptools/stargazers","contributors_url":"https://api.github.com/repos/pypa/setuptools/contributors","subscribers_url":"https://api.github.com/repos/pypa/setuptools/subscribers","subscription_url":"https://api.github.com/repos/pypa/setuptools/subscription","commits_url":"https://api.github.com/repos/pypa/setuptools/commits{/sha}","git_commits_url":"https://api.github.com/repos/pypa/setuptools/git/commits{/sha}","comments_url":"https://api.github.com/repos/pypa/setuptools/comments{/number}","issue_comment_url":"https://api.github.com/repos/pypa/setuptools/issues/comments{/number}","contents_url":"https://api.github.com/repos/pypa/setuptools/contents/{+path}","compare_url":"https://api.github.com/repos/pypa/setuptools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pypa/setuptools/merges","archive_url":"https://api.github.com/repos/pypa/setuptools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pypa/setuptools/downloads","issues_url":"https://api.github.com/repos/pypa/setuptools/issues{/number}","pulls_url":"https://api.github.com/repos/pypa/setuptools/pulls{/number}","milestones_url":"https://api.github.com/repos/pypa/setuptools/milestones{/number}","notifications_url":"https://api.github.com/repos/pypa/setuptools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pypa/setuptools/labels{/name}","releases_url":"https://api.github.com/repos/pypa/setuptools/releases{/id}","deployments_url":"https://api.github.com/repos/pypa/setuptools/deployments","created_at":"2016-03-29T14:02:33Z","updated_at":"2016-09-05T15:56:19Z","pushed_at":"2016-09-06T09:10:49Z","git_url":"git://github.com/pypa/setuptools.git","ssh_url":"git@github.com:pypa/setuptools.git","clone_url":"https://github.com/pypa/setuptools.git","svn_url":"https://github.com/pypa/setuptools","homepage":"https://pypi.python.org/pypi/setuptools","size":31680,"stargazers_count":99,"watchers_count":99,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":248,"forks":86,"open_issues":248,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pypa/setuptools/pulls/739"},"html":{"href":"https://github.com/pypa/setuptools/pull/739"},"issue":{"href":"https://api.github.com/repos/pypa/setuptools/issues/739"},"comments":{"href":"https://api.github.com/repos/pypa/setuptools/issues/739/comments"},"review_comments":{"href":"https://api.github.com/repos/pypa/setuptools/pulls/739/comments"},"review_comment":{"href":"https://api.github.com/repos/pypa/setuptools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pypa/setuptools/pulls/739/commits"},"statuses":{"href":"https://api.github.com/repos/pypa/setuptools/statuses/8d1eecaef52a1baf2b9fc6c772880d8c537b562f"}}}}
{"actor":{"display_login":"vallsv"}}