{"action":"closed","number":38238,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/38238","id":97813694,"html_url":"https://github.com/saltstack/salt/pull/38238","diff_url":"https://github.com/saltstack/salt/pull/38238.diff","patch_url":"https://github.com/saltstack/salt/pull/38238.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/38238","number":38238,"state":"closed","locked":false,"title":"bugfix for boto_rds.present with IAM profile","user":{"login":"bsherrod","id":1707056,"avatar_url":"https://avatars.githubusercontent.com/u/1707056?v=3","gravatar_id":"","url":"https://api.github.com/users/bsherrod","html_url":"https://github.com/bsherrod","followers_url":"https://api.github.com/users/bsherrod/followers","following_url":"https://api.github.com/users/bsherrod/following{/other_user}","gists_url":"https://api.github.com/users/bsherrod/gists{/gist_id}","starred_url":"https://api.github.com/users/bsherrod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsherrod/subscriptions","organizations_url":"https://api.github.com/users/bsherrod/orgs","repos_url":"https://api.github.com/users/bsherrod/repos","events_url":"https://api.github.com/users/bsherrod/events{/privacy}","received_events_url":"https://api.github.com/users/bsherrod/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nFix a bug where boto_rds.present does not work when using profile parameter, only works with key: and keyid parameters.   Without the profile parameter, it's not possible to run salt using IAM roles, only baked-in AWS credentials.\r\n\r\n### Previous Behavior\r\n\r\nThe current behavior is:\r\n```\r\nFile \"/venv/lib/python2.7/site-packages/salt/state.py\", line 1744, in call\r\n  **cdata['kwargs'])\r\nFile \"/venv/lib/python2.7/site-packages/salt/loader.py\", line 1702, in wrapper\r\n  return f(*args, **kwargs)\r\nFile \"/venv/lib/python2.7/site-packages/salt/states/boto_rds.py\", line 312, in present\r\n  r = __salt__['boto_rds.exists'](name, region, key, keyid, profile)\r\nFile \"/venv/lib/python2.7/site-packages/salt/modules/boto_rds.py\", line 155, in exists\r\n  conn = _get_conn(region=region, key=key, keyid=keyid, profile=profile)\r\nFile \"/venv/lib/python2.7/site-packages/salt/utils/boto3.py\", line 206, in get_connection\r\n  keyid, profile)\r\nFile \"/venv/lib/python2.7/site-packages/salt/utils/boto3.py\", line 132, in _get_profile\r\n  hash_string = region + keyid + key\r\nTypeError: cannot concatenate 'str' and 'NoneType' objects\r\n```\r\n### New Behavior\r\n\r\nboto_rds.present state works as expected.\r\n\r\n\r\n\r\n","created_at":"2016-12-13T19:01:15Z","updated_at":"2016-12-16T18:55:08Z","closed_at":"2016-12-16T18:55:08Z","merged_at":null,"merge_commit_sha":"2e2045ba78beb6546e1aa7f76c6d29a9dfcc2944","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/38238/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/38238/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/38238/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/1fde944e8c437b7117ddb3d9e82c8771e777301a","head":{"label":"bsherrod:hotfix-boto-rds-with-profile","ref":"hotfix-boto-rds-with-profile","sha":"1fde944e8c437b7117ddb3d9e82c8771e777301a","user":{"login":"bsherrod","id":1707056,"avatar_url":"https://avatars.githubusercontent.com/u/1707056?v=3","gravatar_id":"","url":"https://api.github.com/users/bsherrod","html_url":"https://github.com/bsherrod","followers_url":"https://api.github.com/users/bsherrod/followers","following_url":"https://api.github.com/users/bsherrod/following{/other_user}","gists_url":"https://api.github.com/users/bsherrod/gists{/gist_id}","starred_url":"https://api.github.com/users/bsherrod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsherrod/subscriptions","organizations_url":"https://api.github.com/users/bsherrod/orgs","repos_url":"https://api.github.com/users/bsherrod/repos","events_url":"https://api.github.com/users/bsherrod/events{/privacy}","received_events_url":"https://api.github.com/users/bsherrod/received_events","type":"User","site_admin":false},"repo":{"id":76388911,"name":"salt","full_name":"bsherrod/salt","owner":{"login":"bsherrod","id":1707056,"avatar_url":"https://avatars.githubusercontent.com/u/1707056?v=3","gravatar_id":"","url":"https://api.github.com/users/bsherrod","html_url":"https://github.com/bsherrod","followers_url":"https://api.github.com/users/bsherrod/followers","following_url":"https://api.github.com/users/bsherrod/following{/other_user}","gists_url":"https://api.github.com/users/bsherrod/gists{/gist_id}","starred_url":"https://api.github.com/users/bsherrod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsherrod/subscriptions","organizations_url":"https://api.github.com/users/bsherrod/orgs","repos_url":"https://api.github.com/users/bsherrod/repos","events_url":"https://api.github.com/users/bsherrod/events{/privacy}","received_events_url":"https://api.github.com/users/bsherrod/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bsherrod/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt Open software package repository here: ","fork":true,"url":"https://api.github.com/repos/bsherrod/salt","forks_url":"https://api.github.com/repos/bsherrod/salt/forks","keys_url":"https://api.github.com/repos/bsherrod/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsherrod/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsherrod/salt/teams","hooks_url":"https://api.github.com/repos/bsherrod/salt/hooks","issue_events_url":"https://api.github.com/repos/bsherrod/salt/issues/events{/number}","events_url":"https://api.github.com/repos/bsherrod/salt/events","assignees_url":"https://api.github.com/repos/bsherrod/salt/assignees{/user}","branches_url":"https://api.github.com/repos/bsherrod/salt/branches{/branch}","tags_url":"https://api.github.com/repos/bsherrod/salt/tags","blobs_url":"https://api.github.com/repos/bsherrod/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsherrod/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsherrod/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsherrod/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsherrod/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/bsherrod/salt/languages","stargazers_url":"https://api.github.com/repos/bsherrod/salt/stargazers","contributors_url":"https://api.github.com/repos/bsherrod/salt/contributors","subscribers_url":"https://api.github.com/repos/bsherrod/salt/subscribers","subscription_url":"https://api.github.com/repos/bsherrod/salt/subscription","commits_url":"https://api.github.com/repos/bsherrod/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsherrod/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsherrod/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsherrod/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsherrod/salt/contents/{+path}","compare_url":"https://api.github.com/repos/bsherrod/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsherrod/salt/merges","archive_url":"https://api.github.com/repos/bsherrod/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsherrod/salt/downloads","issues_url":"https://api.github.com/repos/bsherrod/salt/issues{/number}","pulls_url":"https://api.github.com/repos/bsherrod/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/bsherrod/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/bsherrod/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsherrod/salt/labels{/name}","releases_url":"https://api.github.com/repos/bsherrod/salt/releases{/id}","deployments_url":"https://api.github.com/repos/bsherrod/salt/deployments","created_at":"2016-12-13T18:55:54Z","updated_at":"2016-12-13T18:56:10Z","pushed_at":"2016-12-13T18:58:15Z","git_url":"git://github.com/bsherrod/salt.git","ssh_url":"git@github.com:bsherrod/salt.git","clone_url":"https://github.com/bsherrod/salt.git","svn_url":"https://github.com/bsherrod/salt","homepage":"https://repo.saltstack.com/","size":155501,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"0e1ffbc2100af6b0eef38f2339ca1f83f336b8d0","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2016-12-16T16:51:37Z","pushed_at":"2016-12-16T18:39:24Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":156008,"stargazers_count":7167,"watchers_count":7167,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3293,"mirror_url":null,"open_issues_count":4101,"forks":3293,"open_issues":4101,"watchers":7167,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/38238"},"html":{"href":"https://github.com/saltstack/salt/pull/38238"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/38238"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/38238/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/38238/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/38238/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/1fde944e8c437b7117ddb3d9e82c8771e777301a"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":7,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"bsherrod"}}