{"action":"opened","issue":{"url":"https://api.github.com/repos/pajlada/pajbot/issues/221","repository_url":"https://api.github.com/repos/pajlada/pajbot","labels_url":"https://api.github.com/repos/pajlada/pajbot/issues/221/labels{/name}","comments_url":"https://api.github.com/repos/pajlada/pajbot/issues/221/comments","events_url":"https://api.github.com/repos/pajlada/pajbot/issues/221/events","html_url":"https://github.com/pajlada/pajbot/issues/221","id":138788020,"number":221,"title":"Eloise sub alert/filter bug","user":{"login":"pajlada","id":962989,"avatar_url":"https://avatars.githubusercontent.com/u/962989?v=3","gravatar_id":"","url":"https://api.github.com/users/pajlada","html_url":"https://github.com/pajlada","followers_url":"https://api.github.com/users/pajlada/followers","following_url":"https://api.github.com/users/pajlada/following{/other_user}","gists_url":"https://api.github.com/users/pajlada/gists{/gist_id}","starred_url":"https://api.github.com/users/pajlada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pajlada/subscriptions","organizations_url":"https://api.github.com/users/pajlada/orgs","repos_url":"https://api.github.com/users/pajlada/repos","events_url":"https://api.github.com/users/pajlada/events{/privacy}","received_events_url":"https://api.github.com/users/pajlada/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pajlada/pajbot/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/pajlada/pajbot/labels/help%20wanted","name":"help wanted","color":"159818"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-03-06T12:36:01Z","updated_at":"2016-03-06T12:36:01Z","closed_at":null,"body":"Filters can be used both to ban people, or to just execute some code.\r\n\r\nRight now, in eloise's bot there's a filter running which looks for subs and resubs, and whispers them with \"Hi! Pls join our discord + some more stuff\".\r\nRecently we turned the \"filters/banphrase\" code into a module, which is called before every other module. This module will stop any further modules from executing in case it finds a filter or banphrase. \r\nThis has caused the Sub Alert module to stop working for Eloise.\r\n\r\nTwo possible solutions:\r\n1. If a filter is matched, don't return the value which stops the module, since filters can be both good and bad.\r\n2. Create a module for \"Sub whisper\" which simply whispers the sub when he subs, or rather after X seconds after he subbed.\r\n\r\nI think solution **2** is best."}}