{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/36492","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/36492/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/36492/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/36492/events","html_url":"https://github.com/kubernetes/kubernetes/pull/36492","id":188225343,"number":36492,"title":"[Federation] Make the dns provider configurable in kubefed init","user":{"login":"irfanurrehman","id":10027921,"avatar_url":"https://avatars.githubusercontent.com/u/10027921?v=3","gravatar_id":"","url":"https://api.github.com/users/irfanurrehman","html_url":"https://github.com/irfanurrehman","followers_url":"https://api.github.com/users/irfanurrehman/followers","following_url":"https://api.github.com/users/irfanurrehman/following{/other_user}","gists_url":"https://api.github.com/users/irfanurrehman/gists{/gist_id}","starred_url":"https://api.github.com/users/irfanurrehman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irfanurrehman/subscriptions","organizations_url":"https://api.github.com/users/irfanurrehman/orgs","repos_url":"https://api.github.com/users/irfanurrehman/repos","events_url":"https://api.github.com/users/irfanurrehman/events{/privacy}","received_events_url":"https://api.github.com/users/irfanurrehman/received_events","type":"User","site_admin":false},"labels":[{"id":176978828,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-11-09T11:31:20Z","updated_at":"2016-11-09T18:33:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/36492","html_url":"https://github.com/kubernetes/kubernetes/pull/36492","diff_url":"https://github.com/kubernetes/kubernetes/pull/36492.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/36492.patch"},"body":"This one implements one of the TODO items pending in the previous set of kubefed PRs.\r\nThis one is done on top of another todo PR https://github.com/kubernetes/kubernetes/pull/36447 which is being reviewed separately.\r\nPlease review only the last 2 commits in this one.\r\nThe design doc PR for kubefed is at #34484.\r\n\r\ncc @kubernetes/sig-cluster-federation @madhusudancs @nikhiljindal\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/36492)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/259488831","html_url":"https://github.com/kubernetes/kubernetes/pull/36492#issuecomment-259488831","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/36492","id":259488831,"user":{"login":"madhusudancs","id":10183,"avatar_url":"https://avatars.githubusercontent.com/u/10183?v=3","gravatar_id":"","url":"https://api.github.com/users/madhusudancs","html_url":"https://github.com/madhusudancs","followers_url":"https://api.github.com/users/madhusudancs/followers","following_url":"https://api.github.com/users/madhusudancs/following{/other_user}","gists_url":"https://api.github.com/users/madhusudancs/gists{/gist_id}","starred_url":"https://api.github.com/users/madhusudancs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhusudancs/subscriptions","organizations_url":"https://api.github.com/users/madhusudancs/orgs","repos_url":"https://api.github.com/users/madhusudancs/repos","events_url":"https://api.github.com/users/madhusudancs/events{/privacy}","received_events_url":"https://api.github.com/users/madhusudancs/received_events","type":"User","site_admin":false},"created_at":"2016-11-09T18:33:01Z","updated_at":"2016-11-09T18:33:01Z","body":"@irfanurrehman, @nikhiljindal has already LGTM'ed this. Can you please rebase this to be your first PR in your chain? Or you can even get this off the chain as a separate PR since this does not really depend on your previous PRs. This is a bug fix and I think we should get this into 1.5 to enable people not using Google Cloud DNS. The other PRs can go in, in 1.6.  "}}
{"actor":{"display_login":"madhusudancs"}}