{"action":"created","comment":{"url":"https://api.github.com/repos/square/p2/pulls/comments/93726650","pull_request_review_id":14260227,"id":93726650,"diff_hunk":"@@ -134,14 +134,14 @@ func (r replicator) initializeReplicationWithCheck(\n \toverrideLock bool,\n \tignoreControllers bool,\n \tconcurrentRealityRequests int,\n-\tcheckPreparers bool,\n+\tchekPreparers bool,","path":"pkg/replication/replicator.go","position":16,"original_position":16,"commit_id":"b372a4ecc39f7b4577620922692d2c19815d5618","original_commit_id":"b372a4ecc39f7b4577620922692d2c19815d5618","user":{"login":"mpuncel","id":1444855,"avatar_url":"https://avatars.githubusercontent.com/u/1444855?v=3","gravatar_id":"","url":"https://api.github.com/users/mpuncel","html_url":"https://github.com/mpuncel","followers_url":"https://api.github.com/users/mpuncel/followers","following_url":"https://api.github.com/users/mpuncel/following{/other_user}","gists_url":"https://api.github.com/users/mpuncel/gists{/gist_id}","starred_url":"https://api.github.com/users/mpuncel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpuncel/subscriptions","organizations_url":"https://api.github.com/users/mpuncel/orgs","repos_url":"https://api.github.com/users/mpuncel/repos","events_url":"https://api.github.com/users/mpuncel/events{/privacy}","received_events_url":"https://api.github.com/users/mpuncel/received_events","type":"User","site_admin":false},"body":"this is when I tried to do a sed to fix my previous sed :D i've learned a lesson now","created_at":"2016-12-23T03:23:05Z","updated_at":"2016-12-23T03:23:05Z","html_url":"https://github.com/square/p2/pull/725#discussion_r93726650","pull_request_url":"https://api.github.com/repos/square/p2/pulls/725","_links":{"self":{"href":"https://api.github.com/repos/square/p2/pulls/comments/93726650"},"html":{"href":"https://github.com/square/p2/pull/725#discussion_r93726650"},"pull_request":{"href":"https://api.github.com/repos/square/p2/pulls/725"}}},"pull_request":{"url":"https://api.github.com/repos/square/p2/pulls/725","id":99177557,"html_url":"https://github.com/square/p2/pull/725","diff_url":"https://github.com/square/p2/pull/725.diff","patch_url":"https://github.com/square/p2/pull/725.patch","issue_url":"https://api.github.com/repos/square/p2/issues/725","number":725,"state":"open","locked":false,"title":"Move pkg/kp underneath pkg/store and rename to consul.","user":{"login":"mpuncel","id":1444855,"avatar_url":"https://avatars.githubusercontent.com/u/1444855?v=3","gravatar_id":"","url":"https://api.github.com/users/mpuncel","html_url":"https://github.com/mpuncel","followers_url":"https://api.github.com/users/mpuncel/followers","following_url":"https://api.github.com/users/mpuncel/following{/other_user}","gists_url":"https://api.github.com/users/mpuncel/gists{/gist_id}","starred_url":"https://api.github.com/users/mpuncel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpuncel/subscriptions","organizations_url":"https://api.github.com/users/mpuncel/orgs","repos_url":"https://api.github.com/users/mpuncel/repos","events_url":"https://api.github.com/users/mpuncel/events{/privacy}","received_events_url":"https://api.github.com/users/mpuncel/received_events","type":"User","site_admin":false},"body":"pkg/kp is inextricably tied to Consul semantics. A lot of the operations\r\nare specific to consul, e.g. session creation, locking, and accepting a\r\nPodPrefix parameter in GetPod() and SetPod().\r\n\r\nThis PR organizationally paves the way to support multiple backends by\r\nnaming kp what it is: consul-specific.\r\n\r\nThe idea is that pkg/store will have constructors for separate backend\r\nobjects that provide the same functionality. For example, any package\r\nthat needs to operate on replication controllers might define an\r\ninterface like\r\n\r\ntype RCGetter interface {\r\n    GetRC(rc_fields.ID) rc_fields.ReplicationController\r\n}\r\n\r\nwhich it will take as an argument to its constructor.\r\n\r\npkg/store can offer multiple constructurs e.g. for ConsulStore and\r\nETCDStore, both of which implement the GetRC interface.","created_at":"2016-12-22T22:09:43Z","updated_at":"2016-12-23T03:23:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"959c56c5e35bdca48124ffd5a1a7b20e77fecbdf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/square/p2/pulls/725/commits","review_comments_url":"https://api.github.com/repos/square/p2/pulls/725/comments","review_comment_url":"https://api.github.com/repos/square/p2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/square/p2/issues/725/comments","statuses_url":"https://api.github.com/repos/square/p2/statuses/b372a4ecc39f7b4577620922692d2c19815d5618","head":{"label":"mpuncel:mpuncel/reorganize-kp","ref":"mpuncel/reorganize-kp","sha":"b372a4ecc39f7b4577620922692d2c19815d5618","user":{"login":"mpuncel","id":1444855,"avatar_url":"https://avatars.githubusercontent.com/u/1444855?v=3","gravatar_id":"","url":"https://api.github.com/users/mpuncel","html_url":"https://github.com/mpuncel","followers_url":"https://api.github.com/users/mpuncel/followers","following_url":"https://api.github.com/users/mpuncel/following{/other_user}","gists_url":"https://api.github.com/users/mpuncel/gists{/gist_id}","starred_url":"https://api.github.com/users/mpuncel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpuncel/subscriptions","organizations_url":"https://api.github.com/users/mpuncel/orgs","repos_url":"https://api.github.com/users/mpuncel/repos","events_url":"https://api.github.com/users/mpuncel/events{/privacy}","received_events_url":"https://api.github.com/users/mpuncel/received_events","type":"User","site_admin":false},"repo":{"id":25327874,"name":"p2","full_name":"mpuncel/p2","owner":{"login":"mpuncel","id":1444855,"avatar_url":"https://avatars.githubusercontent.com/u/1444855?v=3","gravatar_id":"","url":"https://api.github.com/users/mpuncel","html_url":"https://github.com/mpuncel","followers_url":"https://api.github.com/users/mpuncel/followers","following_url":"https://api.github.com/users/mpuncel/following{/other_user}","gists_url":"https://api.github.com/users/mpuncel/gists{/gist_id}","starred_url":"https://api.github.com/users/mpuncel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpuncel/subscriptions","organizations_url":"https://api.github.com/users/mpuncel/orgs","repos_url":"https://api.github.com/users/mpuncel/repos","events_url":"https://api.github.com/users/mpuncel/events{/privacy}","received_events_url":"https://api.github.com/users/mpuncel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpuncel/p2","description":"Platypus Platform: Tools for Scalable Deployment","fork":true,"url":"https://api.github.com/repos/mpuncel/p2","forks_url":"https://api.github.com/repos/mpuncel/p2/forks","keys_url":"https://api.github.com/repos/mpuncel/p2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpuncel/p2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpuncel/p2/teams","hooks_url":"https://api.github.com/repos/mpuncel/p2/hooks","issue_events_url":"https://api.github.com/repos/mpuncel/p2/issues/events{/number}","events_url":"https://api.github.com/repos/mpuncel/p2/events","assignees_url":"https://api.github.com/repos/mpuncel/p2/assignees{/user}","branches_url":"https://api.github.com/repos/mpuncel/p2/branches{/branch}","tags_url":"https://api.github.com/repos/mpuncel/p2/tags","blobs_url":"https://api.github.com/repos/mpuncel/p2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpuncel/p2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpuncel/p2/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpuncel/p2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpuncel/p2/statuses/{sha}","languages_url":"https://api.github.com/repos/mpuncel/p2/languages","stargazers_url":"https://api.github.com/repos/mpuncel/p2/stargazers","contributors_url":"https://api.github.com/repos/mpuncel/p2/contributors","subscribers_url":"https://api.github.com/repos/mpuncel/p2/subscribers","subscription_url":"https://api.github.com/repos/mpuncel/p2/subscription","commits_url":"https://api.github.com/repos/mpuncel/p2/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpuncel/p2/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpuncel/p2/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpuncel/p2/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpuncel/p2/contents/{+path}","compare_url":"https://api.github.com/repos/mpuncel/p2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpuncel/p2/merges","archive_url":"https://api.github.com/repos/mpuncel/p2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpuncel/p2/downloads","issues_url":"https://api.github.com/repos/mpuncel/p2/issues{/number}","pulls_url":"https://api.github.com/repos/mpuncel/p2/pulls{/number}","milestones_url":"https://api.github.com/repos/mpuncel/p2/milestones{/number}","notifications_url":"https://api.github.com/repos/mpuncel/p2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpuncel/p2/labels{/name}","releases_url":"https://api.github.com/repos/mpuncel/p2/releases{/id}","deployments_url":"https://api.github.com/repos/mpuncel/p2/deployments","created_at":"2014-10-16T23:47:47Z","updated_at":"2016-03-29T21:34:14Z","pushed_at":"2016-12-23T00:09:23Z","git_url":"git://github.com/mpuncel/p2.git","ssh_url":"git@github.com:mpuncel/p2.git","clone_url":"https://github.com/mpuncel/p2.git","svn_url":"https://github.com/mpuncel/p2","homepage":"","size":48657,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"73f74b6ff37e4e095ffc98fd8bad9adc9795e9b5","user":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":25320424,"name":"p2","full_name":"square/p2","owner":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/p2","description":"Platypus Platform: Tools for Scalable Deployment","fork":false,"url":"https://api.github.com/repos/square/p2","forks_url":"https://api.github.com/repos/square/p2/forks","keys_url":"https://api.github.com/repos/square/p2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/p2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/p2/teams","hooks_url":"https://api.github.com/repos/square/p2/hooks","issue_events_url":"https://api.github.com/repos/square/p2/issues/events{/number}","events_url":"https://api.github.com/repos/square/p2/events","assignees_url":"https://api.github.com/repos/square/p2/assignees{/user}","branches_url":"https://api.github.com/repos/square/p2/branches{/branch}","tags_url":"https://api.github.com/repos/square/p2/tags","blobs_url":"https://api.github.com/repos/square/p2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/p2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/p2/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/p2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/p2/statuses/{sha}","languages_url":"https://api.github.com/repos/square/p2/languages","stargazers_url":"https://api.github.com/repos/square/p2/stargazers","contributors_url":"https://api.github.com/repos/square/p2/contributors","subscribers_url":"https://api.github.com/repos/square/p2/subscribers","subscription_url":"https://api.github.com/repos/square/p2/subscription","commits_url":"https://api.github.com/repos/square/p2/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/p2/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/p2/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/p2/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/p2/contents/{+path}","compare_url":"https://api.github.com/repos/square/p2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/p2/merges","archive_url":"https://api.github.com/repos/square/p2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/p2/downloads","issues_url":"https://api.github.com/repos/square/p2/issues{/number}","pulls_url":"https://api.github.com/repos/square/p2/pulls{/number}","milestones_url":"https://api.github.com/repos/square/p2/milestones{/number}","notifications_url":"https://api.github.com/repos/square/p2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/p2/labels{/name}","releases_url":"https://api.github.com/repos/square/p2/releases{/id}","deployments_url":"https://api.github.com/repos/square/p2/deployments","created_at":"2014-10-16T20:31:12Z","updated_at":"2016-12-22T02:41:42Z","pushed_at":"2016-12-23T00:09:25Z","git_url":"git://github.com/square/p2.git","ssh_url":"git@github.com:square/p2.git","clone_url":"https://github.com/square/p2.git","svn_url":"https://github.com/square/p2","homepage":"","size":48409,"stargazers_count":134,"watchers_count":134,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":7,"forks":24,"open_issues":7,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/p2/pulls/725"},"html":{"href":"https://github.com/square/p2/pull/725"},"issue":{"href":"https://api.github.com/repos/square/p2/issues/725"},"comments":{"href":"https://api.github.com/repos/square/p2/issues/725/comments"},"review_comments":{"href":"https://api.github.com/repos/square/p2/pulls/725/comments"},"review_comment":{"href":"https://api.github.com/repos/square/p2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/square/p2/pulls/725/commits"},"statuses":{"href":"https://api.github.com/repos/square/p2/statuses/b372a4ecc39f7b4577620922692d2c19815d5618"}}}}
{"actor":{"display_login":"mpuncel"}}