{"action":"closed","issue":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/646","repository_url":"https://api.github.com/repos/GoogleChrome/lighthouse","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/646/labels{/name}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/646/comments","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/646/events","html_url":"https://github.com/GoogleChrome/lighthouse/issues/646","id":176779040,"number":646,"title":"Double device emulation when using Lighthouse against a device","user":{"login":"paulirish","id":39191,"avatar_url":"https://avatars.githubusercontent.com/u/39191?v=3","gravatar_id":"","url":"https://api.github.com/users/paulirish","html_url":"https://github.com/paulirish","followers_url":"https://api.github.com/users/paulirish/followers","following_url":"https://api.github.com/users/paulirish/following{/other_user}","gists_url":"https://api.github.com/users/paulirish/gists{/gist_id}","starred_url":"https://api.github.com/users/paulirish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulirish/subscriptions","organizations_url":"https://api.github.com/users/paulirish/orgs","repos_url":"https://api.github.com/users/paulirish/repos","events_url":"https://api.github.com/users/paulirish/events{/privacy}","received_events_url":"https://api.github.com/users/paulirish/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"samccone","id":883126,"avatar_url":"https://avatars.githubusercontent.com/u/883126?v=3","gravatar_id":"","url":"https://api.github.com/users/samccone","html_url":"https://github.com/samccone","followers_url":"https://api.github.com/users/samccone/followers","following_url":"https://api.github.com/users/samccone/following{/other_user}","gists_url":"https://api.github.com/users/samccone/gists{/gist_id}","starred_url":"https://api.github.com/users/samccone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samccone/subscriptions","organizations_url":"https://api.github.com/users/samccone/orgs","repos_url":"https://api.github.com/users/samccone/repos","events_url":"https://api.github.com/users/samccone/events{/privacy}","received_events_url":"https://api.github.com/users/samccone/received_events","type":"User","site_admin":false},"assignees":[{"login":"samccone","id":883126,"avatar_url":"https://avatars.githubusercontent.com/u/883126?v=3","gravatar_id":"","url":"https://api.github.com/users/samccone","html_url":"https://github.com/samccone","followers_url":"https://api.github.com/users/samccone/followers","following_url":"https://api.github.com/users/samccone/following{/other_user}","gists_url":"https://api.github.com/users/samccone/gists{/gist_id}","starred_url":"https://api.github.com/users/samccone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samccone/subscriptions","organizations_url":"https://api.github.com/users/samccone/orgs","repos_url":"https://api.github.com/users/samccone/repos","events_url":"https://api.github.com/users/samccone/events{/privacy}","received_events_url":"https://api.github.com/users/samccone/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-09-13T23:44:04Z","updated_at":"2016-11-02T21:26:29Z","closed_at":"2016-11-02T21:26:29Z","body":"[Lighthouse w/ mobile devices](https://github.com/GoogleChrome/lighthouse/blob/master/readme.md#lighthouse-w-mobile-devices) works well.\n\nHowever if you leave out `--mobile false` then we'll emulate the DPR and viewport of a mobile device **while we're on** a mobile device. weird but it actually works. No severe concerns, though I bet compositing performance suffers some.\n\n`--mobile false` fixes this, but it also disables network throttling.  It shouldn't.\n\nour `enableNexus5X()` does a few things: \n1. spoofs the UA\n2. emulates touch screen\n3. fixes ontouchstart evt handlers\n4. sets device metrics (dpr, viewport, overlay scrollbars etc)\n\nIf we're actually on a mobile device, we shouldn't do any of these 4 things. And network throttling should be handled separately.\n#### Proposal:\n- remove `mobile` flag from CLI and lighthouse API\n- add `disableDeviceEmulation` to both. Defaults to false. Setting to true means we don't do `enableNexus5X()`.\n- (optional) add extra `disableThrottling` flag for network (and soon CPU) throttling.\n\nthoughts?\n"}}
{"actor":{"display_login":"wardpeet"}}