{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/58587014","id":58587014,"diff_hunk":"@@ -88,6 +88,9 @@ public void of(Deadline expected) {\n     };\n   }\n \n+  // TODO(carl-mastrangelo):  Add a isNotWithin method once there is need for one.  Currently there","path":"testing/src/main/java/io/grpc/testing/DeadlineSubject.java","position":null,"original_position":4,"commit_id":"a9131ea1a5514072740ba47f12f6e82be9d4e8ee","original_commit_id":"a9131ea1a5514072740ba47f12f6e82be9d4e8ee","user":{"login":"ejona86","id":2811396,"avatar_url":"https://avatars.githubusercontent.com/u/2811396?v=3","gravatar_id":"","url":"https://api.github.com/users/ejona86","html_url":"https://github.com/ejona86","followers_url":"https://api.github.com/users/ejona86/followers","following_url":"https://api.github.com/users/ejona86/following{/other_user}","gists_url":"https://api.github.com/users/ejona86/gists{/gist_id}","starred_url":"https://api.github.com/users/ejona86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejona86/subscriptions","organizations_url":"https://api.github.com/users/ejona86/orgs","repos_url":"https://api.github.com/users/ejona86/repos","events_url":"https://api.github.com/users/ejona86/events{/privacy}","received_events_url":"https://api.github.com/users/ejona86/received_events","type":"User","site_admin":false},"body":"Ideally we would have a test for this class, but understand.","created_at":"2016-04-05T18:07:06Z","updated_at":"2016-04-05T18:07:06Z","html_url":"https://github.com/grpc/grpc-java/pull/1627#discussion_r58587014","pull_request_url":"https://api.github.com/repos/grpc/grpc-java/pulls/1627","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/58587014"},"html":{"href":"https://github.com/grpc/grpc-java/pull/1627#discussion_r58587014"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/1627"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/1627","id":65013348,"html_url":"https://github.com/grpc/grpc-java/pull/1627","diff_url":"https://github.com/grpc/grpc-java/pull/1627.diff","patch_url":"https://github.com/grpc/grpc-java/pull/1627.patch","issue_url":"https://api.github.com/repos/grpc/grpc-java/issues/1627","number":1627,"state":"open","locked":false,"title":"Try out using Truth library","user":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"body":"This change shows off converting one library to using the Truth fluent testing library.\r\n\r\nTruth makes it easy to do custom assertion behavior, and is easy to read from left to right as a sentence.  Truth is extensible and has widespread use inside Google since being announced.  Truth can and does coexist along side the existing Junit assertion methods, but for the sake of comparison I have converted all of CallOptionsTest to be an example.\r\n\r\nAlso in this PR is the change to make Deadlines comparable.  This is mainly to allow reuse of existing Truth Subject code.  I don't have any plans to add equals or hashCode to Deadline at this time.  The compareTo function is mainly used to support existing idioms, such as inRange, isAtMost, etc.\r\n\r\nLong term, I would like to make a useable library of test functions that users of gRPC Java can use to test their code that uses gRPC.  It would be nice if we could have good support for this internally.","created_at":"2016-04-01T22:24:04Z","updated_at":"2016-04-05T18:07:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"186ba128acf219d8890d4d804b75a707499c8874","assignee":{"login":"ejona86","id":2811396,"avatar_url":"https://avatars.githubusercontent.com/u/2811396?v=3","gravatar_id":"","url":"https://api.github.com/users/ejona86","html_url":"https://github.com/ejona86","followers_url":"https://api.github.com/users/ejona86/followers","following_url":"https://api.github.com/users/ejona86/following{/other_user}","gists_url":"https://api.github.com/users/ejona86/gists{/gist_id}","starred_url":"https://api.github.com/users/ejona86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejona86/subscriptions","organizations_url":"https://api.github.com/users/ejona86/orgs","repos_url":"https://api.github.com/users/ejona86/repos","events_url":"https://api.github.com/users/ejona86/events{/privacy}","received_events_url":"https://api.github.com/users/ejona86/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-java/pulls/1627/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-java/pulls/1627/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-java/issues/1627/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/a9131ea1a5514072740ba47f12f6e82be9d4e8ee","head":{"label":"carl-mastrangelo:work3","ref":"work3","sha":"a9131ea1a5514072740ba47f12f6e82be9d4e8ee","user":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"repo":{"id":38781678,"name":"grpc-java","full_name":"carl-mastrangelo/grpc-java","owner":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carl-mastrangelo/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/carl-mastrangelo/grpc-java","forks_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/forks","keys_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/teams","hooks_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/events","assignees_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/tags","blobs_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/languages","stargazers_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/subscription","commits_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/merges","archive_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/downloads","issues_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/deployments","created_at":"2015-07-08T21:45:19Z","updated_at":"2016-01-12T21:50:07Z","pushed_at":"2016-04-05T16:22:35Z","git_url":"git://github.com/carl-mastrangelo/grpc-java.git","ssh_url":"git@github.com:carl-mastrangelo/grpc-java.git","clone_url":"https://github.com/carl-mastrangelo/grpc-java.git","svn_url":"https://github.com/carl-mastrangelo/grpc-java","homepage":"","size":5939,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"f64a02f2ef38e09d69a45476f050f7e9cd838533","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729926,"name":"grpc-java","full_name":"grpc/grpc-java","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-java","forks_url":"https://api.github.com/repos/grpc/grpc-java/forks","keys_url":"https://api.github.com/repos/grpc/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-java/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-java/events","assignees_url":"https://api.github.com/repos/grpc/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-java/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-java/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-java/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-java/merges","archive_url":"https://api.github.com/repos/grpc/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-java/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-java/deployments","created_at":"2014-12-08T19:00:00Z","updated_at":"2016-04-05T05:55:18Z","pushed_at":"2016-04-05T17:57:48Z","git_url":"git://github.com/grpc/grpc-java.git","ssh_url":"git@github.com:grpc/grpc-java.git","clone_url":"https://github.com/grpc/grpc-java.git","svn_url":"https://github.com/grpc/grpc-java","homepage":"http://grpc.io","size":21882,"stargazers_count":1241,"watchers_count":1241,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":321,"mirror_url":null,"open_issues_count":149,"forks":321,"open_issues":149,"watchers":1241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/1627"},"html":{"href":"https://github.com/grpc/grpc-java/pull/1627"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/1627"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/1627/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/1627/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/1627/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-java/statuses/a9131ea1a5514072740ba47f12f6e82be9d4e8ee"}}}}