{"action":"created","issue":{"url":"https://api.github.com/repos/mrdoob/three.js/issues/8449","repository_url":"https://api.github.com/repos/mrdoob/three.js","labels_url":"https://api.github.com/repos/mrdoob/three.js/issues/8449/labels{/name}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/8449/comments","events_url":"https://api.github.com/repos/mrdoob/three.js/issues/8449/events","html_url":"https://github.com/mrdoob/three.js/issues/8449","id":142902577,"number":8449,"title":"Matrix3 getInverse affecting qunit tests for Three.js","user":{"login":"MasterJames","id":1840183,"avatar_url":"https://avatars.githubusercontent.com/u/1840183?v=3","gravatar_id":"","url":"https://api.github.com/users/MasterJames","html_url":"https://github.com/MasterJames","followers_url":"https://api.github.com/users/MasterJames/followers","following_url":"https://api.github.com/users/MasterJames/following{/other_user}","gists_url":"https://api.github.com/users/MasterJames/gists{/gist_id}","starred_url":"https://api.github.com/users/MasterJames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MasterJames/subscriptions","organizations_url":"https://api.github.com/users/MasterJames/orgs","repos_url":"https://api.github.com/users/MasterJames/repos","events_url":"https://api.github.com/users/MasterJames/events{/privacy}","received_events_url":"https://api.github.com/users/MasterJames/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-03-23T09:01:59Z","updated_at":"2016-03-30T00:45:15Z","closed_at":"2016-03-29T11:52:46Z","body":"##### Description of the problem \r\nWhen running this unit test\r\nhttp://127.0.0.1:8080/test/unit/unittests_three.html?hidepassed\r\nI see\r\n```\r\nMatrix3: getInverse (13, 22, 35) Rerun                              @17 ms\r\n\r\nPassed!                       @ 7 ms\r\nExpected: \t\r\nSource: \t\r\n    at http://127.0.0.1:8080/test/unit/qunit-1.18.0.js:1908:13\r\n    at Object.<anonymous> (http://127.0.0.1:8080/test/unit/math/Matrix3.js:185:3)\r\n    at Object.Test.run (http://127.0.0.1:8080/test/unit/qunit-1.18.0.js:895:28)\r\n    at http://127.0.0.1:8080/test/unit/qunit-1.18.0.js:1024:11\r\n    at process (http://127.0.0.1:8080/test/unit/qunit-1.18.0.js:583:24)\r\n    at begin (http://127.0.0.1:8080/test/unit/qunit-1.18.0.js:628:2)\r\n\r\n```\r\n\r\nAnd in the console the warnings show the issue. \"Determinant is Zero!\"\r\n\r\n```\r\nTHREE.Matrix3.getInverse no longer takes a Matrix4 argument.\r\nthree.js:4667 THREE.Matrix3.getInverse(): can't invert matrix, determinant is 0\r\n```\r\n...\r\n\r\n##### Three.js version\r\n\r\n- [x] Dev\r\n- [x] r75\r\n- [ ] ...\r\n\r\n##### Browser\r\n\r\n- [x] All of them\r\n- [ ] Chrome\r\n- [ ] Firefox\r\n- [ ] Internet Explorer\r\n\r\n##### OS\r\n\r\n- [x] All of them\r\n- [ ] Windows\r\n- [ ] Linux\r\n- [ ] Android\r\n- [ ] IOS\r\n\r\n##### Hardware Requirements (graphics card, VR Device, ...)\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mrdoob/three.js/issues/comments/203172332","html_url":"https://github.com/mrdoob/three.js/issues/8449#issuecomment-203172332","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/8449","id":203172332,"user":{"login":"MasterJames","id":1840183,"avatar_url":"https://avatars.githubusercontent.com/u/1840183?v=3","gravatar_id":"","url":"https://api.github.com/users/MasterJames","html_url":"https://github.com/MasterJames","followers_url":"https://api.github.com/users/MasterJames/followers","following_url":"https://api.github.com/users/MasterJames/following{/other_user}","gists_url":"https://api.github.com/users/MasterJames/gists{/gist_id}","starred_url":"https://api.github.com/users/MasterJames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MasterJames/subscriptions","organizations_url":"https://api.github.com/users/MasterJames/orgs","repos_url":"https://api.github.com/users/MasterJames/repos","events_url":"https://api.github.com/users/MasterJames/events{/privacy}","received_events_url":"https://api.github.com/users/MasterJames/received_events","type":"User","site_admin":false},"created_at":"2016-03-30T00:45:15Z","updated_at":"2016-03-30T00:45:15Z","body":"Ya tests are actually new for me. In the community it makes more sense to me to use them.\r\n\r\nQuinit test for ok\r\nhttps://api.qunitjs.com/ok/\r\n\r\nsecond argument  'message' is a String with \"A short description of the assertion\".\r\n\r\n\"Passed\" is not the right thing to put there. You really only see it when it fails.\r\n\r\n"}}