{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26161","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26161/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26161/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26161/events","html_url":"https://github.com/kubernetes/kubernetes/pull/26161","id":156500457,"number":26161,"title":"kubectl: move printObjectSpecificMessage in factory","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/component/kubectl","name":"component/kubectl","color":"0052cc"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900"}],"state":"open","locked":false,"assignee":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2016-05-24T12:57:34Z","updated_at":"2016-05-24T14:43:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26161","html_url":"https://github.com/kubernetes/kubernetes/pull/26161","diff_url":"https://github.com/kubernetes/kubernetes/pull/26161.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/26161.patch"},"body":"@smarterclayton @kubernetes/kubectl PTAL"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/221293604","html_url":"https://github.com/kubernetes/kubernetes/pull/26161#issuecomment-221293604","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26161","id":221293604,"user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"created_at":"2016-05-24T14:43:13Z","updated_at":"2016-05-24T14:43:13Z","body":"Factory itself could be split, but it essentially prevents us from\nlittering our command code with encapsulation problems.  For example, this\nerror only was printed in create, but it should also have been printed in\napply (and wasn't).  None of our commands should be deeply coupled to\nanything in pkg/api - the abstractions in factory are there to provide the\nhook.\n\nOn May 24, 2016, at 10:37 AM, TonyAdo <notifications@github.com> wrote:\n\n@kargakis <https://github.com/kargakis> @smarterclayton\n<https://github.com/smarterclayton> I am just wondering whether we should\nput so many things in Factory, we have a so big Factory struct now, it\nseems can get bigger and bigger, which makes it hard to control and\nunderstand.\n\n—\nYou are receiving this because you were mentioned.\nReply to this email directly or view it on GitHub\n<https://github.com/kubernetes/kubernetes/pull/26161#issuecomment-221291559>\n"}}
{"actor":{"display_login":"smarterclayton"}}