{"action":"closed","number":169,"pull_request":{"url":"https://api.github.com/repos/SocketCluster/socketcluster/pulls/169","id":65222232,"html_url":"https://github.com/SocketCluster/socketcluster/pull/169","diff_url":"https://github.com/SocketCluster/socketcluster/pull/169.diff","patch_url":"https://github.com/SocketCluster/socketcluster/pull/169.patch","issue_url":"https://api.github.com/repos/SocketCluster/socketcluster/issues/169","number":169,"state":"closed","locked":false,"title":"keep buffers as buffers","user":{"login":"mattkrick","id":5514175,"avatar_url":"https://avatars.githubusercontent.com/u/5514175?v=3","gravatar_id":"","url":"https://api.github.com/users/mattkrick","html_url":"https://github.com/mattkrick","followers_url":"https://api.github.com/users/mattkrick/followers","following_url":"https://api.github.com/users/mattkrick/following{/other_user}","gists_url":"https://api.github.com/users/mattkrick/gists{/gist_id}","starred_url":"https://api.github.com/users/mattkrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattkrick/subscriptions","organizations_url":"https://api.github.com/users/mattkrick/orgs","repos_url":"https://api.github.com/users/mattkrick/repos","events_url":"https://api.github.com/users/mattkrick/events{/privacy}","received_events_url":"https://api.github.com/users/mattkrick/received_events","type":"User","site_admin":false},"body":"fixes #168.\r\nan authKey can be a buffer.\r\nWhen it gets via the _workerCluster (message: 'init'), the buffer gets stringified & parsed back into an object representation of a buffer.\r\nThis rehydrates the buffer.\r\n\r\nnot sure about public/private keys, maybe they have the same problem?\r\nAlso, since security is at risk, it might be time to switch to `Buffer.from`, but that will require a recent version of node. \r\nhttps://nodejs.org/api/buffer.html","created_at":"2016-04-04T22:17:05Z","updated_at":"2016-04-06T02:12:35Z","closed_at":"2016-04-06T02:12:35Z","merged_at":"2016-04-06T02:12:35Z","merge_commit_sha":"9e44c6f3685fb10c282568b7fbac30cbfee064ed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SocketCluster/socketcluster/pulls/169/commits","review_comments_url":"https://api.github.com/repos/SocketCluster/socketcluster/pulls/169/comments","review_comment_url":"https://api.github.com/repos/SocketCluster/socketcluster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SocketCluster/socketcluster/issues/169/comments","statuses_url":"https://api.github.com/repos/SocketCluster/socketcluster/statuses/242b38a8660af47b0f9212206230e93d041ea5b6","head":{"label":"mattkrick:patch-1","ref":"patch-1","sha":"242b38a8660af47b0f9212206230e93d041ea5b6","user":{"login":"mattkrick","id":5514175,"avatar_url":"https://avatars.githubusercontent.com/u/5514175?v=3","gravatar_id":"","url":"https://api.github.com/users/mattkrick","html_url":"https://github.com/mattkrick","followers_url":"https://api.github.com/users/mattkrick/followers","following_url":"https://api.github.com/users/mattkrick/following{/other_user}","gists_url":"https://api.github.com/users/mattkrick/gists{/gist_id}","starred_url":"https://api.github.com/users/mattkrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattkrick/subscriptions","organizations_url":"https://api.github.com/users/mattkrick/orgs","repos_url":"https://api.github.com/users/mattkrick/repos","events_url":"https://api.github.com/users/mattkrick/events{/privacy}","received_events_url":"https://api.github.com/users/mattkrick/received_events","type":"User","site_admin":false},"repo":{"id":55449172,"name":"socketcluster","full_name":"mattkrick/socketcluster","owner":{"login":"mattkrick","id":5514175,"avatar_url":"https://avatars.githubusercontent.com/u/5514175?v=3","gravatar_id":"","url":"https://api.github.com/users/mattkrick","html_url":"https://github.com/mattkrick","followers_url":"https://api.github.com/users/mattkrick/followers","following_url":"https://api.github.com/users/mattkrick/following{/other_user}","gists_url":"https://api.github.com/users/mattkrick/gists{/gist_id}","starred_url":"https://api.github.com/users/mattkrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattkrick/subscriptions","organizations_url":"https://api.github.com/users/mattkrick/orgs","repos_url":"https://api.github.com/users/mattkrick/repos","events_url":"https://api.github.com/users/mattkrick/events{/privacy}","received_events_url":"https://api.github.com/users/mattkrick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattkrick/socketcluster","description":"Highly scalable realtime microframework","fork":true,"url":"https://api.github.com/repos/mattkrick/socketcluster","forks_url":"https://api.github.com/repos/mattkrick/socketcluster/forks","keys_url":"https://api.github.com/repos/mattkrick/socketcluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattkrick/socketcluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattkrick/socketcluster/teams","hooks_url":"https://api.github.com/repos/mattkrick/socketcluster/hooks","issue_events_url":"https://api.github.com/repos/mattkrick/socketcluster/issues/events{/number}","events_url":"https://api.github.com/repos/mattkrick/socketcluster/events","assignees_url":"https://api.github.com/repos/mattkrick/socketcluster/assignees{/user}","branches_url":"https://api.github.com/repos/mattkrick/socketcluster/branches{/branch}","tags_url":"https://api.github.com/repos/mattkrick/socketcluster/tags","blobs_url":"https://api.github.com/repos/mattkrick/socketcluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattkrick/socketcluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattkrick/socketcluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattkrick/socketcluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattkrick/socketcluster/statuses/{sha}","languages_url":"https://api.github.com/repos/mattkrick/socketcluster/languages","stargazers_url":"https://api.github.com/repos/mattkrick/socketcluster/stargazers","contributors_url":"https://api.github.com/repos/mattkrick/socketcluster/contributors","subscribers_url":"https://api.github.com/repos/mattkrick/socketcluster/subscribers","subscription_url":"https://api.github.com/repos/mattkrick/socketcluster/subscription","commits_url":"https://api.github.com/repos/mattkrick/socketcluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattkrick/socketcluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattkrick/socketcluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattkrick/socketcluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattkrick/socketcluster/contents/{+path}","compare_url":"https://api.github.com/repos/mattkrick/socketcluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattkrick/socketcluster/merges","archive_url":"https://api.github.com/repos/mattkrick/socketcluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattkrick/socketcluster/downloads","issues_url":"https://api.github.com/repos/mattkrick/socketcluster/issues{/number}","pulls_url":"https://api.github.com/repos/mattkrick/socketcluster/pulls{/number}","milestones_url":"https://api.github.com/repos/mattkrick/socketcluster/milestones{/number}","notifications_url":"https://api.github.com/repos/mattkrick/socketcluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattkrick/socketcluster/labels{/name}","releases_url":"https://api.github.com/repos/mattkrick/socketcluster/releases{/id}","deployments_url":"https://api.github.com/repos/mattkrick/socketcluster/deployments","created_at":"2016-04-04T22:13:24Z","updated_at":"2016-04-04T22:13:25Z","pushed_at":"2016-04-05T19:21:42Z","git_url":"git://github.com/mattkrick/socketcluster.git","ssh_url":"git@github.com:mattkrick/socketcluster.git","clone_url":"https://github.com/mattkrick/socketcluster.git","svn_url":"https://github.com/mattkrick/socketcluster","homepage":"http://socketcluster.io/","size":1039,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SocketCluster:master","ref":"master","sha":"b0e8438a3cf8816a9b5825196c5a2f0e87bffbeb","user":{"login":"SocketCluster","id":12481324,"avatar_url":"https://avatars.githubusercontent.com/u/12481324?v=3","gravatar_id":"","url":"https://api.github.com/users/SocketCluster","html_url":"https://github.com/SocketCluster","followers_url":"https://api.github.com/users/SocketCluster/followers","following_url":"https://api.github.com/users/SocketCluster/following{/other_user}","gists_url":"https://api.github.com/users/SocketCluster/gists{/gist_id}","starred_url":"https://api.github.com/users/SocketCluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SocketCluster/subscriptions","organizations_url":"https://api.github.com/users/SocketCluster/orgs","repos_url":"https://api.github.com/users/SocketCluster/repos","events_url":"https://api.github.com/users/SocketCluster/events{/privacy}","received_events_url":"https://api.github.com/users/SocketCluster/received_events","type":"Organization","site_admin":false},"repo":{"id":13034860,"name":"socketcluster","full_name":"SocketCluster/socketcluster","owner":{"login":"SocketCluster","id":12481324,"avatar_url":"https://avatars.githubusercontent.com/u/12481324?v=3","gravatar_id":"","url":"https://api.github.com/users/SocketCluster","html_url":"https://github.com/SocketCluster","followers_url":"https://api.github.com/users/SocketCluster/followers","following_url":"https://api.github.com/users/SocketCluster/following{/other_user}","gists_url":"https://api.github.com/users/SocketCluster/gists{/gist_id}","starred_url":"https://api.github.com/users/SocketCluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SocketCluster/subscriptions","organizations_url":"https://api.github.com/users/SocketCluster/orgs","repos_url":"https://api.github.com/users/SocketCluster/repos","events_url":"https://api.github.com/users/SocketCluster/events{/privacy}","received_events_url":"https://api.github.com/users/SocketCluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SocketCluster/socketcluster","description":"Highly scalable realtime microframework","fork":false,"url":"https://api.github.com/repos/SocketCluster/socketcluster","forks_url":"https://api.github.com/repos/SocketCluster/socketcluster/forks","keys_url":"https://api.github.com/repos/SocketCluster/socketcluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SocketCluster/socketcluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SocketCluster/socketcluster/teams","hooks_url":"https://api.github.com/repos/SocketCluster/socketcluster/hooks","issue_events_url":"https://api.github.com/repos/SocketCluster/socketcluster/issues/events{/number}","events_url":"https://api.github.com/repos/SocketCluster/socketcluster/events","assignees_url":"https://api.github.com/repos/SocketCluster/socketcluster/assignees{/user}","branches_url":"https://api.github.com/repos/SocketCluster/socketcluster/branches{/branch}","tags_url":"https://api.github.com/repos/SocketCluster/socketcluster/tags","blobs_url":"https://api.github.com/repos/SocketCluster/socketcluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SocketCluster/socketcluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SocketCluster/socketcluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/SocketCluster/socketcluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SocketCluster/socketcluster/statuses/{sha}","languages_url":"https://api.github.com/repos/SocketCluster/socketcluster/languages","stargazers_url":"https://api.github.com/repos/SocketCluster/socketcluster/stargazers","contributors_url":"https://api.github.com/repos/SocketCluster/socketcluster/contributors","subscribers_url":"https://api.github.com/repos/SocketCluster/socketcluster/subscribers","subscription_url":"https://api.github.com/repos/SocketCluster/socketcluster/subscription","commits_url":"https://api.github.com/repos/SocketCluster/socketcluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/SocketCluster/socketcluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/SocketCluster/socketcluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/SocketCluster/socketcluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/SocketCluster/socketcluster/contents/{+path}","compare_url":"https://api.github.com/repos/SocketCluster/socketcluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SocketCluster/socketcluster/merges","archive_url":"https://api.github.com/repos/SocketCluster/socketcluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SocketCluster/socketcluster/downloads","issues_url":"https://api.github.com/repos/SocketCluster/socketcluster/issues{/number}","pulls_url":"https://api.github.com/repos/SocketCluster/socketcluster/pulls{/number}","milestones_url":"https://api.github.com/repos/SocketCluster/socketcluster/milestones{/number}","notifications_url":"https://api.github.com/repos/SocketCluster/socketcluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SocketCluster/socketcluster/labels{/name}","releases_url":"https://api.github.com/repos/SocketCluster/socketcluster/releases{/id}","deployments_url":"https://api.github.com/repos/SocketCluster/socketcluster/deployments","created_at":"2013-09-23T12:11:47Z","updated_at":"2016-04-05T18:11:47Z","pushed_at":"2016-04-06T02:12:35Z","git_url":"git://github.com/SocketCluster/socketcluster.git","ssh_url":"git@github.com:SocketCluster/socketcluster.git","clone_url":"https://github.com/SocketCluster/socketcluster.git","svn_url":"https://github.com/SocketCluster/socketcluster","homepage":"http://socketcluster.io/","size":1326,"stargazers_count":3006,"watchers_count":3006,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"open_issues_count":14,"forks":105,"open_issues":14,"watchers":3006,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SocketCluster/socketcluster/pulls/169"},"html":{"href":"https://github.com/SocketCluster/socketcluster/pull/169"},"issue":{"href":"https://api.github.com/repos/SocketCluster/socketcluster/issues/169"},"comments":{"href":"https://api.github.com/repos/SocketCluster/socketcluster/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/SocketCluster/socketcluster/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/SocketCluster/socketcluster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SocketCluster/socketcluster/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/SocketCluster/socketcluster/statuses/242b38a8660af47b0f9212206230e93d041ea5b6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jondubois","id":1187447,"avatar_url":"https://avatars.githubusercontent.com/u/1187447?v=3","gravatar_id":"","url":"https://api.github.com/users/jondubois","html_url":"https://github.com/jondubois","followers_url":"https://api.github.com/users/jondubois/followers","following_url":"https://api.github.com/users/jondubois/following{/other_user}","gists_url":"https://api.github.com/users/jondubois/gists{/gist_id}","starred_url":"https://api.github.com/users/jondubois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jondubois/subscriptions","organizations_url":"https://api.github.com/users/jondubois/orgs","repos_url":"https://api.github.com/users/jondubois/repos","events_url":"https://api.github.com/users/jondubois/events{/privacy}","received_events_url":"https://api.github.com/users/jondubois/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":5,"deletions":1,"changed_files":1}}