{"action":"created","comment":{"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/comments/71912849","id":71912849,"diff_hunk":"@@ -0,0 +1,56 @@\n+/*\n+ * Copyright 2016 Facebook, Inc.\n+ * <p>\n+ *  Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with\n+ *  the License. You may obtain a copy of the License at\n+ *  <p>\n+ *  http://www.apache.org/licenses/LICENSE-2.0\n+ *  <p>\n+ *  Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on\n+ *  an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the\n+ *  specific language governing permissions and limitations under the License.\n+ */\n+\n+package io.reactivesocket.tckdrivers.common;\n+\n+import io.reactivesocket.Payload;\n+import io.reactivesocket.util.PayloadImpl;\n+import org.reactivestreams.Subscriber;\n+import org.reactivestreams.Subscription;\n+\n+import java.util.Queue;\n+import java.util.concurrent.ConcurrentLinkedQueue;\n+\n+public class EchoSubscription implements Subscription {","path":"reactivesocket-tck-drivers/src/main/java/io/reactivesocket/tckdrivers/common/EchoSubscription.java","position":24,"original_position":24,"commit_id":"519d79943d25cb092a6b0d2e468531bb0ad56035","original_commit_id":"519d79943d25cb092a6b0d2e468531bb0ad56035","user":{"login":"benjchristensen","id":813492,"avatar_url":"https://avatars.githubusercontent.com/u/813492?v=3","gravatar_id":"","url":"https://api.github.com/users/benjchristensen","html_url":"https://github.com/benjchristensen","followers_url":"https://api.github.com/users/benjchristensen/followers","following_url":"https://api.github.com/users/benjchristensen/following{/other_user}","gists_url":"https://api.github.com/users/benjchristensen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjchristensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjchristensen/subscriptions","organizations_url":"https://api.github.com/users/benjchristensen/orgs","repos_url":"https://api.github.com/users/benjchristensen/repos","events_url":"https://api.github.com/users/benjchristensen/events{/privacy}","received_events_url":"https://api.github.com/users/benjchristensen/received_events","type":"User","site_admin":false},"body":"It would help to have a javadoc explaining what this class is for.","created_at":"2016-07-22T17:14:13Z","updated_at":"2016-07-22T17:14:13Z","html_url":"https://github.com/ReactiveSocket/reactivesocket-java/pull/153#discussion_r71912849","pull_request_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/153","_links":{"self":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/comments/71912849"},"html":{"href":"https://github.com/ReactiveSocket/reactivesocket-java/pull/153#discussion_r71912849"},"pull_request":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/153"}}},"pull_request":{"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/153","id":78068550,"html_url":"https://github.com/ReactiveSocket/reactivesocket-java/pull/153","diff_url":"https://github.com/ReactiveSocket/reactivesocket-java/pull/153.diff","patch_url":"https://github.com/ReactiveSocket/reactivesocket-java/pull/153.patch","issue_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/153","number":153,"state":"open","locked":false,"title":"merging tck drivers with new code","user":{"login":"xytosis","id":7416628,"avatar_url":"https://avatars.githubusercontent.com/u/7416628?v=3","gravatar_id":"","url":"https://api.github.com/users/xytosis","html_url":"https://github.com/xytosis","followers_url":"https://api.github.com/users/xytosis/followers","following_url":"https://api.github.com/users/xytosis/following{/other_user}","gists_url":"https://api.github.com/users/xytosis/gists{/gist_id}","starred_url":"https://api.github.com/users/xytosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xytosis/subscriptions","organizations_url":"https://api.github.com/users/xytosis/orgs","repos_url":"https://api.github.com/users/xytosis/repos","events_url":"https://api.github.com/users/xytosis/events{/privacy}","received_events_url":"https://api.github.com/users/xytosis/received_events","type":"User","site_admin":false},"body":"I would like to integrate the TCK Java Drivers into this repository, as I think it would be the best organization to have each driver for each implementation live inside their own repos.\r\n\r\nThe problem I am having is that, for some reason, the channel tests that I wrote that worked for the 2.2 snapshot of the TCP transport does not work with the new TCP code, and the toy server and client in test just doesn't work at all (the client seems to randomly timeout before sending or receiving data from the server).\r\n\r\nThere is probably something wrong with the way I wrote the code. I think if I can get SimpleServer and Main in the `test` directory working, the driver code should start working too.","created_at":"2016-07-19T23:52:38Z","updated_at":"2016-07-22T17:14:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3baeff0b0232f021cc6a828c891ca9ce2a645653","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/153/commits","review_comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/153/comments","review_comment_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/153/comments","statuses_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/statuses/519d79943d25cb092a6b0d2e468531bb0ad56035","head":{"label":"xytosis:master","ref":"master","sha":"519d79943d25cb092a6b0d2e468531bb0ad56035","user":{"login":"xytosis","id":7416628,"avatar_url":"https://avatars.githubusercontent.com/u/7416628?v=3","gravatar_id":"","url":"https://api.github.com/users/xytosis","html_url":"https://github.com/xytosis","followers_url":"https://api.github.com/users/xytosis/followers","following_url":"https://api.github.com/users/xytosis/following{/other_user}","gists_url":"https://api.github.com/users/xytosis/gists{/gist_id}","starred_url":"https://api.github.com/users/xytosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xytosis/subscriptions","organizations_url":"https://api.github.com/users/xytosis/orgs","repos_url":"https://api.github.com/users/xytosis/repos","events_url":"https://api.github.com/users/xytosis/events{/privacy}","received_events_url":"https://api.github.com/users/xytosis/received_events","type":"User","site_admin":false},"repo":{"id":63642116,"name":"reactivesocket-java","full_name":"xytosis/reactivesocket-java","owner":{"login":"xytosis","id":7416628,"avatar_url":"https://avatars.githubusercontent.com/u/7416628?v=3","gravatar_id":"","url":"https://api.github.com/users/xytosis","html_url":"https://github.com/xytosis","followers_url":"https://api.github.com/users/xytosis/followers","following_url":"https://api.github.com/users/xytosis/following{/other_user}","gists_url":"https://api.github.com/users/xytosis/gists{/gist_id}","starred_url":"https://api.github.com/users/xytosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xytosis/subscriptions","organizations_url":"https://api.github.com/users/xytosis/orgs","repos_url":"https://api.github.com/users/xytosis/repos","events_url":"https://api.github.com/users/xytosis/events{/privacy}","received_events_url":"https://api.github.com/users/xytosis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xytosis/reactivesocket-java","description":"ReactiveSocket Protocol for Client/Server for Java","fork":true,"url":"https://api.github.com/repos/xytosis/reactivesocket-java","forks_url":"https://api.github.com/repos/xytosis/reactivesocket-java/forks","keys_url":"https://api.github.com/repos/xytosis/reactivesocket-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xytosis/reactivesocket-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xytosis/reactivesocket-java/teams","hooks_url":"https://api.github.com/repos/xytosis/reactivesocket-java/hooks","issue_events_url":"https://api.github.com/repos/xytosis/reactivesocket-java/issues/events{/number}","events_url":"https://api.github.com/repos/xytosis/reactivesocket-java/events","assignees_url":"https://api.github.com/repos/xytosis/reactivesocket-java/assignees{/user}","branches_url":"https://api.github.com/repos/xytosis/reactivesocket-java/branches{/branch}","tags_url":"https://api.github.com/repos/xytosis/reactivesocket-java/tags","blobs_url":"https://api.github.com/repos/xytosis/reactivesocket-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xytosis/reactivesocket-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xytosis/reactivesocket-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/xytosis/reactivesocket-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xytosis/reactivesocket-java/statuses/{sha}","languages_url":"https://api.github.com/repos/xytosis/reactivesocket-java/languages","stargazers_url":"https://api.github.com/repos/xytosis/reactivesocket-java/stargazers","contributors_url":"https://api.github.com/repos/xytosis/reactivesocket-java/contributors","subscribers_url":"https://api.github.com/repos/xytosis/reactivesocket-java/subscribers","subscription_url":"https://api.github.com/repos/xytosis/reactivesocket-java/subscription","commits_url":"https://api.github.com/repos/xytosis/reactivesocket-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/xytosis/reactivesocket-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/xytosis/reactivesocket-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/xytosis/reactivesocket-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/xytosis/reactivesocket-java/contents/{+path}","compare_url":"https://api.github.com/repos/xytosis/reactivesocket-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xytosis/reactivesocket-java/merges","archive_url":"https://api.github.com/repos/xytosis/reactivesocket-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xytosis/reactivesocket-java/downloads","issues_url":"https://api.github.com/repos/xytosis/reactivesocket-java/issues{/number}","pulls_url":"https://api.github.com/repos/xytosis/reactivesocket-java/pulls{/number}","milestones_url":"https://api.github.com/repos/xytosis/reactivesocket-java/milestones{/number}","notifications_url":"https://api.github.com/repos/xytosis/reactivesocket-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xytosis/reactivesocket-java/labels{/name}","releases_url":"https://api.github.com/repos/xytosis/reactivesocket-java/releases{/id}","deployments_url":"https://api.github.com/repos/xytosis/reactivesocket-java/deployments","created_at":"2016-07-18T22:42:33Z","updated_at":"2016-07-18T22:42:35Z","pushed_at":"2016-07-21T20:56:38Z","git_url":"git://github.com/xytosis/reactivesocket-java.git","ssh_url":"git@github.com:xytosis/reactivesocket-java.git","clone_url":"https://github.com/xytosis/reactivesocket-java.git","svn_url":"https://github.com/xytosis/reactivesocket-java","homepage":"reactivesocket.io","size":1390,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactiveSocket:master","ref":"master","sha":"b91721dc029529317143b5a5c02dd460b2c698fd","user":{"login":"ReactiveSocket","id":13168916,"avatar_url":"https://avatars.githubusercontent.com/u/13168916?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveSocket","html_url":"https://github.com/ReactiveSocket","followers_url":"https://api.github.com/users/ReactiveSocket/followers","following_url":"https://api.github.com/users/ReactiveSocket/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveSocket/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveSocket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveSocket/subscriptions","organizations_url":"https://api.github.com/users/ReactiveSocket/orgs","repos_url":"https://api.github.com/users/ReactiveSocket/repos","events_url":"https://api.github.com/users/ReactiveSocket/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveSocket/received_events","type":"Organization","site_admin":false},"repo":{"id":38732107,"name":"reactivesocket-java","full_name":"ReactiveSocket/reactivesocket-java","owner":{"login":"ReactiveSocket","id":13168916,"avatar_url":"https://avatars.githubusercontent.com/u/13168916?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveSocket","html_url":"https://github.com/ReactiveSocket","followers_url":"https://api.github.com/users/ReactiveSocket/followers","following_url":"https://api.github.com/users/ReactiveSocket/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveSocket/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveSocket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveSocket/subscriptions","organizations_url":"https://api.github.com/users/ReactiveSocket/orgs","repos_url":"https://api.github.com/users/ReactiveSocket/repos","events_url":"https://api.github.com/users/ReactiveSocket/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveSocket/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveSocket/reactivesocket-java","description":"ReactiveSocket Protocol for Client/Server for Java","fork":false,"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java","forks_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/forks","keys_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/teams","hooks_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/hooks","issue_events_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/events","assignees_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/tags","blobs_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/languages","stargazers_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/stargazers","contributors_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/contributors","subscribers_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/subscribers","subscription_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/subscription","commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/merges","archive_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/downloads","issues_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/releases{/id}","deployments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/deployments","created_at":"2015-07-08T04:36:42Z","updated_at":"2016-07-16T07:27:17Z","pushed_at":"2016-07-22T16:15:30Z","git_url":"git://github.com/ReactiveSocket/reactivesocket-java.git","ssh_url":"git@github.com:ReactiveSocket/reactivesocket-java.git","clone_url":"https://github.com/ReactiveSocket/reactivesocket-java.git","svn_url":"https://github.com/ReactiveSocket/reactivesocket-java","homepage":"reactivesocket.io","size":1729,"stargazers_count":80,"watchers_count":80,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":18,"forks":18,"open_issues":18,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/153"},"html":{"href":"https://github.com/ReactiveSocket/reactivesocket-java/pull/153"},"issue":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/153"},"comments":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-java/statuses/519d79943d25cb092a6b0d2e468531bb0ad56035"}}}}
{"actor":{"display_login":"benjchristensen"}}