{"action":"closed","issue":{"url":"https://api.github.com/repos/nilsteampassnet/TeamPass/issues/1436","repository_url":"https://api.github.com/repos/nilsteampassnet/TeamPass","labels_url":"https://api.github.com/repos/nilsteampassnet/TeamPass/issues/1436/labels{/name}","comments_url":"https://api.github.com/repos/nilsteampassnet/TeamPass/issues/1436/comments","events_url":"https://api.github.com/repos/nilsteampassnet/TeamPass/issues/1436/events","html_url":"https://github.com/nilsteampassnet/TeamPass/issues/1436","id":172203661,"number":1436,"title":"HTML tags in title=\"\" attribute used for tooltips","user":{"login":"qubez","id":1425520,"avatar_url":"https://avatars.githubusercontent.com/u/1425520?v=3","gravatar_id":"","url":"https://api.github.com/users/qubez","html_url":"https://github.com/qubez","followers_url":"https://api.github.com/users/qubez/followers","following_url":"https://api.github.com/users/qubez/following{/other_user}","gists_url":"https://api.github.com/users/qubez/gists{/gist_id}","starred_url":"https://api.github.com/users/qubez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qubez/subscriptions","organizations_url":"https://api.github.com/users/qubez/orgs","repos_url":"https://api.github.com/users/qubez/repos","events_url":"https://api.github.com/users/qubez/events{/privacy}","received_events_url":"https://api.github.com/users/qubez/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-19T19:30:26Z","updated_at":"2016-08-31T04:29:11Z","closed_at":"2016-08-31T04:29:11Z","body":"I'm working my way through a big HTML fix to reduce the 300+ validation errors, and found something that is beyond the mismatched <td> tags, unclosed elements, etc. An error by design.\r\n\r\nThe language files provide tooltip text, which is rendered in a title=\"tooltop\" element in various elements. However, some of the tooltips have HTML markup in them. **title** attributes can contain _only_ text. HTML delimiters are not permitted as contents of a title, only data.\r\n\r\n\r\n### Steps to reproduce\r\n1. View admin's \"Teampass settings\"\r\n2. Hover over \"Path to Upload folder\"'s (?) tooltip to enjoy HTML-coded tooltip\r\n3. view source to see broken HTML with elements like title=\"<span style='font-size:11px;max-width:30\r\n\r\n### Expected behaviour\r\nValid HTML is generated in compliance with the XHTML doctype\r\n\r\n### Actual behaviour\r\nBad HTML\r\n\r\n### Server configuration\r\n**Teampass version:** \r\n2.1.26 - master, 2016-08-17\r\n\r\n\r\nThe quick solution is to strip all HTML out of language files, reducing the tooltip appearance quality, but I am reluctant to do that without quorum. \r\nRestoring the multiline, formatted appearance of some tooltips would require css styling/javascript if deemed necessary.\r\n\r\nWant a pull request for non-html language files?\r\n"}}
{"actor":{"display_login":"qubez"}}