{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/14148","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14148/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14148/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14148/events","html_url":"https://github.com/cms-sw/cmssw/pull/14148","id":149467846,"number":14148,"title":"Update of BTagCalibrationReader and code move to CondTools/BTau","user":{"login":"HeinerTholen","id":4882000,"avatar_url":"https://avatars.githubusercontent.com/u/4882000?v=3","gravatar_id":"","url":"https://api.github.com/users/HeinerTholen","html_url":"https://github.com/HeinerTholen","followers_url":"https://api.github.com/users/HeinerTholen/followers","following_url":"https://api.github.com/users/HeinerTholen/following{/other_user}","gists_url":"https://api.github.com/users/HeinerTholen/gists{/gist_id}","starred_url":"https://api.github.com/users/HeinerTholen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeinerTholen/subscriptions","organizations_url":"https://api.github.com/users/HeinerTholen/orgs","repos_url":"https://api.github.com/users/HeinerTholen/repos","events_url":"https://api.github.com/users/HeinerTholen/events{/privacy}","received_events_url":"https://api.github.com/users/HeinerTholen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-approved","name":"alca-approved","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/db-approved","name":"db-approved","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/new-package-pending","name":"new-package-pending","color":"e11d21"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":76,"closed_issues":583,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-05-12T12:49:49Z","due_on":null,"closed_at":null},"comments":26,"created_at":"2016-04-19T13:53:53Z","updated_at":"2016-05-12T13:05:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/14148","html_url":"https://github.com/cms-sw/cmssw/pull/14148","diff_url":"https://github.com/cms-sw/cmssw/pull/14148.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/14148.patch"},"body":"The update of BTagCalibrationReader contains two new methods for users: `min_max_pt` and `eval_auto_bounds`. The interface and src files are still left in CondFormats/BTauObjects. The reason is that I found it a bit unnecessary to create a complete new library for just one class. Also, there would be a need for separate classes_def.xml and classes.h files, since we would like to have the BTagCalibrationReader accessible from python.\r\n\r\nFurthermore, all files in RecoBTag/PerformanceDB that are connected to BTagCalibration (new format) are moved into CondTools/BTau, which is a new Package. It seems to me that everything that is left in RecoBTag/PerformanceDB belongs to the old b tag scale factor format, but I can't say for sure."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/218750625","html_url":"https://github.com/cms-sw/cmssw/pull/14148#issuecomment-218750625","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14148","id":218750625,"user":{"login":"HeinerTholen","id":4882000,"avatar_url":"https://avatars.githubusercontent.com/u/4882000?v=3","gravatar_id":"","url":"https://api.github.com/users/HeinerTholen","html_url":"https://github.com/HeinerTholen","followers_url":"https://api.github.com/users/HeinerTholen/followers","following_url":"https://api.github.com/users/HeinerTholen/following{/other_user}","gists_url":"https://api.github.com/users/HeinerTholen/gists{/gist_id}","starred_url":"https://api.github.com/users/HeinerTholen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeinerTholen/subscriptions","organizations_url":"https://api.github.com/users/HeinerTholen/orgs","repos_url":"https://api.github.com/users/HeinerTholen/repos","events_url":"https://api.github.com/users/HeinerTholen/events{/privacy}","received_events_url":"https://api.github.com/users/HeinerTholen/received_events","type":"User","site_admin":false},"created_at":"2016-05-12T13:05:04Z","updated_at":"2016-05-12T13:05:04Z","body":"So it means that CondTools/BTau would actually the best choice for the code in question?\r\n(Actually I would like the reader to stay where it is, also because those 3 classes, BTagEntry, BTagCalibration and BTagCalibrationReader build on each other and form a unity, kind of...)"}}