{"action":"closed","number":541,"pull_request":{"url":"https://api.github.com/repos/yesodweb/wai/pulls/541","id":67546852,"html_url":"https://github.com/yesodweb/wai/pull/541","diff_url":"https://github.com/yesodweb/wai/pull/541.diff","patch_url":"https://github.com/yesodweb/wai/pull/541.patch","issue_url":"https://api.github.com/repos/yesodweb/wai/issues/541","number":541,"state":"closed","locked":false,"title":"don't launch if server fails; kill server on exit #537","user":{"login":"simonmichael","id":10144,"avatar_url":"https://avatars.githubusercontent.com/u/10144?v=3","gravatar_id":"","url":"https://api.github.com/users/simonmichael","html_url":"https://github.com/simonmichael","followers_url":"https://api.github.com/users/simonmichael/followers","following_url":"https://api.github.com/users/simonmichael/following{/other_user}","gists_url":"https://api.github.com/users/simonmichael/gists{/gist_id}","starred_url":"https://api.github.com/users/simonmichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonmichael/subscriptions","organizations_url":"https://api.github.com/users/simonmichael/orgs","repos_url":"https://api.github.com/users/simonmichael/repos","events_url":"https://api.github.com/users/simonmichael/events{/privacy}","received_events_url":"https://api.github.com/users/simonmichael/received_events","type":"User","site_admin":false},"body":"Make the server thread and launch/monitor thread more aware of each\r\nother's failures, using async. Now if the server fails to start we won't\r\nlaunch a browser. Also when the main thread terminates (eg from ctrl-c\r\nin GHCI), we make sure the server thread does too. There is now a 0.1s\r\ndelay before launching the browser, which also helps ensure the server\r\nis ready to serve.","created_at":"2016-04-22T17:37:12Z","updated_at":"2016-05-02T17:20:42Z","closed_at":"2016-05-02T17:20:42Z","merged_at":"2016-05-02T17:20:42Z","merge_commit_sha":"2a755b739dcc90a060f0a70b092c74ce7564ef12","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yesodweb/wai/pulls/541/commits","review_comments_url":"https://api.github.com/repos/yesodweb/wai/pulls/541/comments","review_comment_url":"https://api.github.com/repos/yesodweb/wai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yesodweb/wai/issues/541/comments","statuses_url":"https://api.github.com/repos/yesodweb/wai/statuses/8ee4d4ac47c948d979733c853068c43d733aefc5","head":{"label":"simonmichael:master","ref":"master","sha":"8ee4d4ac47c948d979733c853068c43d733aefc5","user":{"login":"simonmichael","id":10144,"avatar_url":"https://avatars.githubusercontent.com/u/10144?v=3","gravatar_id":"","url":"https://api.github.com/users/simonmichael","html_url":"https://github.com/simonmichael","followers_url":"https://api.github.com/users/simonmichael/followers","following_url":"https://api.github.com/users/simonmichael/following{/other_user}","gists_url":"https://api.github.com/users/simonmichael/gists{/gist_id}","starred_url":"https://api.github.com/users/simonmichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonmichael/subscriptions","organizations_url":"https://api.github.com/users/simonmichael/orgs","repos_url":"https://api.github.com/users/simonmichael/repos","events_url":"https://api.github.com/users/simonmichael/events{/privacy}","received_events_url":"https://api.github.com/users/simonmichael/received_events","type":"User","site_admin":false},"repo":{"id":56803410,"name":"wai","full_name":"simonmichael/wai","owner":{"login":"simonmichael","id":10144,"avatar_url":"https://avatars.githubusercontent.com/u/10144?v=3","gravatar_id":"","url":"https://api.github.com/users/simonmichael","html_url":"https://github.com/simonmichael","followers_url":"https://api.github.com/users/simonmichael/followers","following_url":"https://api.github.com/users/simonmichael/following{/other_user}","gists_url":"https://api.github.com/users/simonmichael/gists{/gist_id}","starred_url":"https://api.github.com/users/simonmichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonmichael/subscriptions","organizations_url":"https://api.github.com/users/simonmichael/orgs","repos_url":"https://api.github.com/users/simonmichael/repos","events_url":"https://api.github.com/users/simonmichael/events{/privacy}","received_events_url":"https://api.github.com/users/simonmichael/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simonmichael/wai","description":"Haskell Web Application Interface","fork":true,"url":"https://api.github.com/repos/simonmichael/wai","forks_url":"https://api.github.com/repos/simonmichael/wai/forks","keys_url":"https://api.github.com/repos/simonmichael/wai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simonmichael/wai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simonmichael/wai/teams","hooks_url":"https://api.github.com/repos/simonmichael/wai/hooks","issue_events_url":"https://api.github.com/repos/simonmichael/wai/issues/events{/number}","events_url":"https://api.github.com/repos/simonmichael/wai/events","assignees_url":"https://api.github.com/repos/simonmichael/wai/assignees{/user}","branches_url":"https://api.github.com/repos/simonmichael/wai/branches{/branch}","tags_url":"https://api.github.com/repos/simonmichael/wai/tags","blobs_url":"https://api.github.com/repos/simonmichael/wai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simonmichael/wai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simonmichael/wai/git/refs{/sha}","trees_url":"https://api.github.com/repos/simonmichael/wai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simonmichael/wai/statuses/{sha}","languages_url":"https://api.github.com/repos/simonmichael/wai/languages","stargazers_url":"https://api.github.com/repos/simonmichael/wai/stargazers","contributors_url":"https://api.github.com/repos/simonmichael/wai/contributors","subscribers_url":"https://api.github.com/repos/simonmichael/wai/subscribers","subscription_url":"https://api.github.com/repos/simonmichael/wai/subscription","commits_url":"https://api.github.com/repos/simonmichael/wai/commits{/sha}","git_commits_url":"https://api.github.com/repos/simonmichael/wai/git/commits{/sha}","comments_url":"https://api.github.com/repos/simonmichael/wai/comments{/number}","issue_comment_url":"https://api.github.com/repos/simonmichael/wai/issues/comments{/number}","contents_url":"https://api.github.com/repos/simonmichael/wai/contents/{+path}","compare_url":"https://api.github.com/repos/simonmichael/wai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simonmichael/wai/merges","archive_url":"https://api.github.com/repos/simonmichael/wai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simonmichael/wai/downloads","issues_url":"https://api.github.com/repos/simonmichael/wai/issues{/number}","pulls_url":"https://api.github.com/repos/simonmichael/wai/pulls{/number}","milestones_url":"https://api.github.com/repos/simonmichael/wai/milestones{/number}","notifications_url":"https://api.github.com/repos/simonmichael/wai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simonmichael/wai/labels{/name}","releases_url":"https://api.github.com/repos/simonmichael/wai/releases{/id}","deployments_url":"https://api.github.com/repos/simonmichael/wai/deployments","created_at":"2016-04-21T20:24:13Z","updated_at":"2016-04-21T20:24:14Z","pushed_at":"2016-05-02T16:03:05Z","git_url":"git://github.com/simonmichael/wai.git","ssh_url":"git@github.com:simonmichael/wai.git","clone_url":"https://github.com/simonmichael/wai.git","svn_url":"https://github.com/simonmichael/wai","homepage":"","size":7808,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yesodweb:master","ref":"master","sha":"082bd633cd6179a098437f131e14e10b701fb17c","user":{"login":"yesodweb","id":930379,"avatar_url":"https://avatars.githubusercontent.com/u/930379?v=3","gravatar_id":"","url":"https://api.github.com/users/yesodweb","html_url":"https://github.com/yesodweb","followers_url":"https://api.github.com/users/yesodweb/followers","following_url":"https://api.github.com/users/yesodweb/following{/other_user}","gists_url":"https://api.github.com/users/yesodweb/gists{/gist_id}","starred_url":"https://api.github.com/users/yesodweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yesodweb/subscriptions","organizations_url":"https://api.github.com/users/yesodweb/orgs","repos_url":"https://api.github.com/users/yesodweb/repos","events_url":"https://api.github.com/users/yesodweb/events{/privacy}","received_events_url":"https://api.github.com/users/yesodweb/received_events","type":"Organization","site_admin":false},"repo":{"id":476179,"name":"wai","full_name":"yesodweb/wai","owner":{"login":"yesodweb","id":930379,"avatar_url":"https://avatars.githubusercontent.com/u/930379?v=3","gravatar_id":"","url":"https://api.github.com/users/yesodweb","html_url":"https://github.com/yesodweb","followers_url":"https://api.github.com/users/yesodweb/followers","following_url":"https://api.github.com/users/yesodweb/following{/other_user}","gists_url":"https://api.github.com/users/yesodweb/gists{/gist_id}","starred_url":"https://api.github.com/users/yesodweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yesodweb/subscriptions","organizations_url":"https://api.github.com/users/yesodweb/orgs","repos_url":"https://api.github.com/users/yesodweb/repos","events_url":"https://api.github.com/users/yesodweb/events{/privacy}","received_events_url":"https://api.github.com/users/yesodweb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yesodweb/wai","description":"Haskell Web Application Interface","fork":false,"url":"https://api.github.com/repos/yesodweb/wai","forks_url":"https://api.github.com/repos/yesodweb/wai/forks","keys_url":"https://api.github.com/repos/yesodweb/wai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yesodweb/wai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yesodweb/wai/teams","hooks_url":"https://api.github.com/repos/yesodweb/wai/hooks","issue_events_url":"https://api.github.com/repos/yesodweb/wai/issues/events{/number}","events_url":"https://api.github.com/repos/yesodweb/wai/events","assignees_url":"https://api.github.com/repos/yesodweb/wai/assignees{/user}","branches_url":"https://api.github.com/repos/yesodweb/wai/branches{/branch}","tags_url":"https://api.github.com/repos/yesodweb/wai/tags","blobs_url":"https://api.github.com/repos/yesodweb/wai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yesodweb/wai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yesodweb/wai/git/refs{/sha}","trees_url":"https://api.github.com/repos/yesodweb/wai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yesodweb/wai/statuses/{sha}","languages_url":"https://api.github.com/repos/yesodweb/wai/languages","stargazers_url":"https://api.github.com/repos/yesodweb/wai/stargazers","contributors_url":"https://api.github.com/repos/yesodweb/wai/contributors","subscribers_url":"https://api.github.com/repos/yesodweb/wai/subscribers","subscription_url":"https://api.github.com/repos/yesodweb/wai/subscription","commits_url":"https://api.github.com/repos/yesodweb/wai/commits{/sha}","git_commits_url":"https://api.github.com/repos/yesodweb/wai/git/commits{/sha}","comments_url":"https://api.github.com/repos/yesodweb/wai/comments{/number}","issue_comment_url":"https://api.github.com/repos/yesodweb/wai/issues/comments{/number}","contents_url":"https://api.github.com/repos/yesodweb/wai/contents/{+path}","compare_url":"https://api.github.com/repos/yesodweb/wai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yesodweb/wai/merges","archive_url":"https://api.github.com/repos/yesodweb/wai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yesodweb/wai/downloads","issues_url":"https://api.github.com/repos/yesodweb/wai/issues{/number}","pulls_url":"https://api.github.com/repos/yesodweb/wai/pulls{/number}","milestones_url":"https://api.github.com/repos/yesodweb/wai/milestones{/number}","notifications_url":"https://api.github.com/repos/yesodweb/wai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yesodweb/wai/labels{/name}","releases_url":"https://api.github.com/repos/yesodweb/wai/releases{/id}","deployments_url":"https://api.github.com/repos/yesodweb/wai/deployments","created_at":"2010-01-17T15:44:09Z","updated_at":"2016-04-30T23:38:06Z","pushed_at":"2016-05-02T17:20:42Z","git_url":"git://github.com/yesodweb/wai.git","ssh_url":"git@github.com:yesodweb/wai.git","clone_url":"https://github.com/yesodweb/wai.git","svn_url":"https://github.com/yesodweb/wai","homepage":"","size":8065,"stargazers_count":348,"watchers_count":348,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":22,"forks":136,"open_issues":22,"watchers":348,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yesodweb/wai/pulls/541"},"html":{"href":"https://github.com/yesodweb/wai/pull/541"},"issue":{"href":"https://api.github.com/repos/yesodweb/wai/issues/541"},"comments":{"href":"https://api.github.com/repos/yesodweb/wai/issues/541/comments"},"review_comments":{"href":"https://api.github.com/repos/yesodweb/wai/pulls/541/comments"},"review_comment":{"href":"https://api.github.com/repos/yesodweb/wai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yesodweb/wai/pulls/541/commits"},"statuses":{"href":"https://api.github.com/repos/yesodweb/wai/statuses/8ee4d4ac47c948d979733c853068c43d733aefc5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"snoyberg","id":49415,"avatar_url":"https://avatars.githubusercontent.com/u/49415?v=3","gravatar_id":"","url":"https://api.github.com/users/snoyberg","html_url":"https://github.com/snoyberg","followers_url":"https://api.github.com/users/snoyberg/followers","following_url":"https://api.github.com/users/snoyberg/following{/other_user}","gists_url":"https://api.github.com/users/snoyberg/gists{/gist_id}","starred_url":"https://api.github.com/users/snoyberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snoyberg/subscriptions","organizations_url":"https://api.github.com/users/snoyberg/orgs","repos_url":"https://api.github.com/users/snoyberg/repos","events_url":"https://api.github.com/users/snoyberg/events{/privacy}","received_events_url":"https://api.github.com/users/snoyberg/received_events","type":"User","site_admin":false},"comments":4,"review_comments":3,"commits":2,"additions":23,"deletions":14,"changed_files":2}}