{"action":"created","issue":{"url":"https://api.github.com/repos/ruby-grape/grape/issues/1526","repository_url":"https://api.github.com/repos/ruby-grape/grape","labels_url":"https://api.github.com/repos/ruby-grape/grape/issues/1526/labels{/name}","comments_url":"https://api.github.com/repos/ruby-grape/grape/issues/1526/comments","events_url":"https://api.github.com/repos/ruby-grape/grape/issues/1526/events","html_url":"https://github.com/ruby-grape/grape/pull/1526","id":191668244,"number":1526,"title":"Avoid noise when code runs with Ruby warnings","user":{"login":"cpetschnig","id":48502,"avatar_url":"https://avatars.githubusercontent.com/u/48502?v=3","gravatar_id":"","url":"https://api.github.com/users/cpetschnig","html_url":"https://github.com/cpetschnig","followers_url":"https://api.github.com/users/cpetschnig/followers","following_url":"https://api.github.com/users/cpetschnig/following{/other_user}","gists_url":"https://api.github.com/users/cpetschnig/gists{/gist_id}","starred_url":"https://api.github.com/users/cpetschnig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpetschnig/subscriptions","organizations_url":"https://api.github.com/users/cpetschnig/orgs","repos_url":"https://api.github.com/users/cpetschnig/repos","events_url":"https://api.github.com/users/cpetschnig/events{/privacy}","received_events_url":"https://api.github.com/users/cpetschnig/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-25T10:17:34Z","updated_at":"2016-11-28T14:29:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ruby-grape/grape/pulls/1526","html_url":"https://github.com/ruby-grape/grape/pull/1526","diff_url":"https://github.com/ruby-grape/grape/pull/1526.diff","patch_url":"https://github.com/ruby-grape/grape/pull/1526.patch"},"body":"New versions of RSpec have warnings turned on by default:\r\n\r\n    # This setting enables warnings. It's recommended, but in some cases may\r\n    # be too noisy due to issues in dependencies.\r\n    config.warnings = true\r\n\r\nI believe these warnings are helpful in general to write better code. However, Grape and Grape Entity are very noisy. I get about 20 lines of warnings for one single test where Grape is involved.\r\n\r\nI hope you agree. Many of my changes could also be solved differently for sure. I am happy to discuss and change those cases. I also changed the specs for less warnings and turned them on in the test suite."},"comment":{"url":"https://api.github.com/repos/ruby-grape/grape/issues/comments/263284755","html_url":"https://github.com/ruby-grape/grape/pull/1526#issuecomment-263284755","issue_url":"https://api.github.com/repos/ruby-grape/grape/issues/1526","id":263284755,"user":{"login":"dblock","id":542335,"avatar_url":"https://avatars.githubusercontent.com/u/542335?v=3","gravatar_id":"","url":"https://api.github.com/users/dblock","html_url":"https://github.com/dblock","followers_url":"https://api.github.com/users/dblock/followers","following_url":"https://api.github.com/users/dblock/following{/other_user}","gists_url":"https://api.github.com/users/dblock/gists{/gist_id}","starred_url":"https://api.github.com/users/dblock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dblock/subscriptions","organizations_url":"https://api.github.com/users/dblock/orgs","repos_url":"https://api.github.com/users/dblock/repos","events_url":"https://api.github.com/users/dblock/events{/privacy}","received_events_url":"https://api.github.com/users/dblock/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T14:29:53Z","updated_at":"2016-11-28T14:29:53Z","body":"Because those are included? I am not a huge fan of side-effects of assigning something on return to `nil`, warning or convention or not. Anyone else has an opinion, maybe @namusyaka or @lefnord?"}}
{"actor":{"display_login":"dblock"}}