{"action":"created","issue":{"url":"https://api.github.com/repos/Wox-launcher/Wox/issues/954","repository_url":"https://api.github.com/repos/Wox-launcher/Wox","labels_url":"https://api.github.com/repos/Wox-launcher/Wox/issues/954/labels{/name}","comments_url":"https://api.github.com/repos/Wox-launcher/Wox/issues/954/comments","events_url":"https://api.github.com/repos/Wox-launcher/Wox/issues/954/events","html_url":"https://github.com/Wox-launcher/Wox/pull/954","id":174264024,"number":954,"title":"Improvements to UWP application indexing","user":{"login":"alexmg","id":131293,"avatar_url":"https://avatars.githubusercontent.com/u/131293?v=3","gravatar_id":"","url":"https://api.github.com/users/alexmg","html_url":"https://github.com/alexmg","followers_url":"https://api.github.com/users/alexmg/followers","following_url":"https://api.github.com/users/alexmg/following{/other_user}","gists_url":"https://api.github.com/users/alexmg/gists{/gist_id}","starred_url":"https://api.github.com/users/alexmg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexmg/subscriptions","organizations_url":"https://api.github.com/users/alexmg/orgs","repos_url":"https://api.github.com/users/alexmg/repos","events_url":"https://api.github.com/users/alexmg/events{/privacy}","received_events_url":"https://api.github.com/users/alexmg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-08-31T12:47:10Z","updated_at":"2016-08-31T14:49:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Wox-launcher/Wox/pulls/954","html_url":"https://github.com/Wox-launcher/Wox/pull/954","diff_url":"https://github.com/Wox-launcher/Wox/pull/954.diff","patch_url":"https://github.com/Wox-launcher/Wox/pull/954.patch"},"body":"I was testing out the UWP support and hit the same issue @talynone mentioned in https://github.com/Wox-launcher/Wox/issues/198#issuecomment-240597463.\r\n\r\nI too have a `Package` that throws when the `InstalledLocation` property is accessed. With the current structure this exception will result in all packages being ignored instead of only the problem package. A simple try-catch while filtering the packages does the trick.\r\n\r\nI also have Tweetium installed which is a WinJS based UWP app and does not have an `\"Executable\"` value in the manifest. As a result it is being filtered out in the UWP constructor. The Tweetium app can still be launched using its `UserModelId` so I don't think that the filter on `\"Executable\"` needs to be applied. I have removed this and can now also launch WinJS based applications. I've been running with these changes for about a week now and haven't noticed any problems."},"comment":{"url":"https://api.github.com/repos/Wox-launcher/Wox/issues/comments/243788668","html_url":"https://github.com/Wox-launcher/Wox/pull/954#issuecomment-243788668","issue_url":"https://api.github.com/repos/Wox-launcher/Wox/issues/954","id":243788668,"user":{"login":"alexmg","id":131293,"avatar_url":"https://avatars.githubusercontent.com/u/131293?v=3","gravatar_id":"","url":"https://api.github.com/users/alexmg","html_url":"https://github.com/alexmg","followers_url":"https://api.github.com/users/alexmg/followers","following_url":"https://api.github.com/users/alexmg/following{/other_user}","gists_url":"https://api.github.com/users/alexmg/gists{/gist_id}","starred_url":"https://api.github.com/users/alexmg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexmg/subscriptions","organizations_url":"https://api.github.com/users/alexmg/orgs","repos_url":"https://api.github.com/users/alexmg/repos","events_url":"https://api.github.com/users/alexmg/events{/privacy}","received_events_url":"https://api.github.com/users/alexmg/received_events","type":"User","site_admin":false},"created_at":"2016-08-31T14:49:12Z","updated_at":"2016-08-31T14:49:12Z","body":"There isn't actually a folder for that package. That package does have two dependencies though:\r\n\r\n- Microsoft.VCLibs.140.00.Debug_14.0.24210.0_x86__8wekyb3d8bbwe\r\n- Microsoft.VCLibs.120.00.Debug.Universal_12.0.30501.0_x86__8wekyb3d8bbwe\r\n\r\nMore interesting is that the package itself has the `IsDevelopmentMode` property set to `true`. Happy to update the PR to use that in the `Where` condition instead of the try-catch if that is what isn't sitting right with you."}}
{"actor":{"display_login":"alexmg"}}