{"action":"created","comment":{"url":"https://api.github.com/repos/google/openrtb/pulls/comments/64462091","id":64462091,"diff_hunk":"@@ -337,6 +337,11 @@ protected void readNativeField(JsonParser par, Native.Builder nativ, String fiel\n     }\n   }\n \n+  private void readNativeAsObject(Native.Builder nativ, JsonParser par) throws IOException {\n+    OpenRtbNativeJsonReader nativeObjectReader = factory().newNativeReader();\n+    nativ.setRequestNative(nativeObjectReader.readNativeRequest(par));\n+  }","path":"openrtb-core/src/main/java/com/google/openrtb/json/OpenRtbJsonReader.java","position":24,"original_position":24,"commit_id":"f00b379617a41ee50721ff80a262af6180518461","original_commit_id":"f00b379617a41ee50721ff80a262af6180518461","user":{"login":"opinali","id":3017776,"avatar_url":"https://avatars.githubusercontent.com/u/3017776?v=3","gravatar_id":"","url":"https://api.github.com/users/opinali","html_url":"https://github.com/opinali","followers_url":"https://api.github.com/users/opinali/followers","following_url":"https://api.github.com/users/opinali/following{/other_user}","gists_url":"https://api.github.com/users/opinali/gists{/gist_id}","starred_url":"https://api.github.com/users/opinali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opinali/subscriptions","organizations_url":"https://api.github.com/users/opinali/orgs","repos_url":"https://api.github.com/users/opinali/repos","events_url":"https://api.github.com/users/opinali/events{/privacy}","received_events_url":"https://api.github.com/users/opinali/received_events","type":"User","site_admin":false},"body":"Please avoid small refactored helpers like this unless it's invoked in more than one place, or potentially useful as an protected method that could be independently overridden. This class has a difficult balance between the large number of methods and the long `switch`/`case` inside each method, so I feel a \"dumber\" structure is the least evil, at least it makes easily to read and debug stuff linearly.","created_at":"2016-05-24T19:52:21Z","updated_at":"2016-05-24T19:52:21Z","html_url":"https://github.com/google/openrtb/pull/87#discussion_r64462091","pull_request_url":"https://api.github.com/repos/google/openrtb/pulls/87","_links":{"self":{"href":"https://api.github.com/repos/google/openrtb/pulls/comments/64462091"},"html":{"href":"https://github.com/google/openrtb/pull/87#discussion_r64462091"},"pull_request":{"href":"https://api.github.com/repos/google/openrtb/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/google/openrtb/pulls/87","id":70534212,"html_url":"https://github.com/google/openrtb/pull/87","diff_url":"https://github.com/google/openrtb/pull/87.diff","patch_url":"https://github.com/google/openrtb/pull/87.patch","issue_url":"https://api.github.com/repos/google/openrtb/issues/87","number":87,"state":"open","locked":false,"title":"Enable native Json object","user":{"login":"bundeskanzler4711","id":7062722,"avatar_url":"https://avatars.githubusercontent.com/u/7062722?v=3","gravatar_id":"","url":"https://api.github.com/users/bundeskanzler4711","html_url":"https://github.com/bundeskanzler4711","followers_url":"https://api.github.com/users/bundeskanzler4711/followers","following_url":"https://api.github.com/users/bundeskanzler4711/following{/other_user}","gists_url":"https://api.github.com/users/bundeskanzler4711/gists{/gist_id}","starred_url":"https://api.github.com/users/bundeskanzler4711/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bundeskanzler4711/subscriptions","organizations_url":"https://api.github.com/users/bundeskanzler4711/orgs","repos_url":"https://api.github.com/users/bundeskanzler4711/repos","events_url":"https://api.github.com/users/bundeskanzler4711/events{/privacy}","received_events_url":"https://api.github.com/users/bundeskanzler4711/received_events","type":"User","site_admin":false},"body":"According to https://github.com/google/openrtb/issues/85 this is my pull request.\r\n\r\nBid request:\r\n  - no root-native field, native as request field (String)\r\n  - including root-native field, native as request field (String)\r\n  - no root-native field, native as request_native field (Json-Object) **NEW**\r\n  - including root-native field, native as request_native field (Json-Object) **NEW**\r\n\r\nBid response:\r\n  - no root-native field, native as adm field (String)\r\n  - including root-native field, native as adm field (String)\r\n  - no root-native field, native as adm_native field (Json-Object) **NEW**\r\n  - including root-native field, native as adm_native field (Json-Object) **NEW**","created_at":"2016-05-18T14:08:13Z","updated_at":"2016-05-24T19:52:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c08e0e09b57fcc386c8cfc5ed7c1f0d38797e7b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/openrtb/pulls/87/commits","review_comments_url":"https://api.github.com/repos/google/openrtb/pulls/87/comments","review_comment_url":"https://api.github.com/repos/google/openrtb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/openrtb/issues/87/comments","statuses_url":"https://api.github.com/repos/google/openrtb/statuses/f00b379617a41ee50721ff80a262af6180518461","head":{"label":"bundeskanzler4711:master","ref":"master","sha":"f00b379617a41ee50721ff80a262af6180518461","user":{"login":"bundeskanzler4711","id":7062722,"avatar_url":"https://avatars.githubusercontent.com/u/7062722?v=3","gravatar_id":"","url":"https://api.github.com/users/bundeskanzler4711","html_url":"https://github.com/bundeskanzler4711","followers_url":"https://api.github.com/users/bundeskanzler4711/followers","following_url":"https://api.github.com/users/bundeskanzler4711/following{/other_user}","gists_url":"https://api.github.com/users/bundeskanzler4711/gists{/gist_id}","starred_url":"https://api.github.com/users/bundeskanzler4711/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bundeskanzler4711/subscriptions","organizations_url":"https://api.github.com/users/bundeskanzler4711/orgs","repos_url":"https://api.github.com/users/bundeskanzler4711/repos","events_url":"https://api.github.com/users/bundeskanzler4711/events{/privacy}","received_events_url":"https://api.github.com/users/bundeskanzler4711/received_events","type":"User","site_admin":false},"repo":{"id":57194664,"name":"openrtb","full_name":"bundeskanzler4711/openrtb","owner":{"login":"bundeskanzler4711","id":7062722,"avatar_url":"https://avatars.githubusercontent.com/u/7062722?v=3","gravatar_id":"","url":"https://api.github.com/users/bundeskanzler4711","html_url":"https://github.com/bundeskanzler4711","followers_url":"https://api.github.com/users/bundeskanzler4711/followers","following_url":"https://api.github.com/users/bundeskanzler4711/following{/other_user}","gists_url":"https://api.github.com/users/bundeskanzler4711/gists{/gist_id}","starred_url":"https://api.github.com/users/bundeskanzler4711/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bundeskanzler4711/subscriptions","organizations_url":"https://api.github.com/users/bundeskanzler4711/orgs","repos_url":"https://api.github.com/users/bundeskanzler4711/repos","events_url":"https://api.github.com/users/bundeskanzler4711/events{/privacy}","received_events_url":"https://api.github.com/users/bundeskanzler4711/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bundeskanzler4711/openrtb","description":"OpenRTB model for Java and other languages via protobuf; Helper OpenRTB libraries for Java including JSON serialization","fork":true,"url":"https://api.github.com/repos/bundeskanzler4711/openrtb","forks_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/forks","keys_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/teams","hooks_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/hooks","issue_events_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/issues/events{/number}","events_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/events","assignees_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/assignees{/user}","branches_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/branches{/branch}","tags_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/tags","blobs_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/git/refs{/sha}","trees_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/statuses/{sha}","languages_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/languages","stargazers_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/stargazers","contributors_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/contributors","subscribers_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/subscribers","subscription_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/subscription","commits_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/commits{/sha}","git_commits_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/git/commits{/sha}","comments_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/comments{/number}","issue_comment_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/issues/comments{/number}","contents_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/contents/{+path}","compare_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/merges","archive_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/downloads","issues_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/issues{/number}","pulls_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/pulls{/number}","milestones_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/milestones{/number}","notifications_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/labels{/name}","releases_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/releases{/id}","deployments_url":"https://api.github.com/repos/bundeskanzler4711/openrtb/deployments","created_at":"2016-04-27T07:52:24Z","updated_at":"2016-04-27T07:52:25Z","pushed_at":"2016-05-18T14:10:15Z","git_url":"git://github.com/bundeskanzler4711/openrtb.git","ssh_url":"git@github.com:bundeskanzler4711/openrtb.git","clone_url":"https://github.com/bundeskanzler4711/openrtb.git","svn_url":"https://github.com/bundeskanzler4711/openrtb","homepage":"","size":960,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"62fbd7864b59629956c476899e9e1747d9b0e00e","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":21432552,"name":"openrtb","full_name":"google/openrtb","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/openrtb","description":"OpenRTB model for Java and other languages via protobuf; Helper OpenRTB libraries for Java including JSON serialization","fork":false,"url":"https://api.github.com/repos/google/openrtb","forks_url":"https://api.github.com/repos/google/openrtb/forks","keys_url":"https://api.github.com/repos/google/openrtb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/openrtb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/openrtb/teams","hooks_url":"https://api.github.com/repos/google/openrtb/hooks","issue_events_url":"https://api.github.com/repos/google/openrtb/issues/events{/number}","events_url":"https://api.github.com/repos/google/openrtb/events","assignees_url":"https://api.github.com/repos/google/openrtb/assignees{/user}","branches_url":"https://api.github.com/repos/google/openrtb/branches{/branch}","tags_url":"https://api.github.com/repos/google/openrtb/tags","blobs_url":"https://api.github.com/repos/google/openrtb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/openrtb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/openrtb/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/openrtb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/openrtb/statuses/{sha}","languages_url":"https://api.github.com/repos/google/openrtb/languages","stargazers_url":"https://api.github.com/repos/google/openrtb/stargazers","contributors_url":"https://api.github.com/repos/google/openrtb/contributors","subscribers_url":"https://api.github.com/repos/google/openrtb/subscribers","subscription_url":"https://api.github.com/repos/google/openrtb/subscription","commits_url":"https://api.github.com/repos/google/openrtb/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/openrtb/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/openrtb/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/openrtb/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/openrtb/contents/{+path}","compare_url":"https://api.github.com/repos/google/openrtb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/openrtb/merges","archive_url":"https://api.github.com/repos/google/openrtb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/openrtb/downloads","issues_url":"https://api.github.com/repos/google/openrtb/issues{/number}","pulls_url":"https://api.github.com/repos/google/openrtb/pulls{/number}","milestones_url":"https://api.github.com/repos/google/openrtb/milestones{/number}","notifications_url":"https://api.github.com/repos/google/openrtb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/openrtb/labels{/name}","releases_url":"https://api.github.com/repos/google/openrtb/releases{/id}","deployments_url":"https://api.github.com/repos/google/openrtb/deployments","created_at":"2014-07-02T17:05:55Z","updated_at":"2016-05-22T15:57:17Z","pushed_at":"2016-05-18T14:08:13Z","git_url":"git://github.com/google/openrtb.git","ssh_url":"git@github.com:google/openrtb.git","clone_url":"https://github.com/google/openrtb.git","svn_url":"https://github.com/google/openrtb","homepage":"","size":1064,"stargazers_count":153,"watchers_count":153,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":4,"forks":55,"open_issues":4,"watchers":153,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/openrtb/pulls/87"},"html":{"href":"https://github.com/google/openrtb/pull/87"},"issue":{"href":"https://api.github.com/repos/google/openrtb/issues/87"},"comments":{"href":"https://api.github.com/repos/google/openrtb/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/google/openrtb/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/google/openrtb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/openrtb/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/google/openrtb/statuses/f00b379617a41ee50721ff80a262af6180518461"}}}}
{"actor":{"display_login":"opinali"}}