{"action":"created","comment":{"url":"https://api.github.com/repos/tablexi/nucore-open/pulls/comments/82084843","pull_request_review_id":3016922,"id":82084843,"diff_hunk":"@@ -60,7 +60,20 @@ def bulk_email_cancel_path\n     end\n \n     def cancel_params\n-      @cancel_params ||= params.slice(:start_date, :end_date, :bulk_email, :products)\n+      @cancel_params ||= params.slice(:start_date, :end_date, :bulk_email, :products, :return_path)\n+    end\n+\n+    def delivery_success_path\n+      return_path_from_params || facility_bulk_email_path\n+    end\n+\n+    def return_path_from_params\n+      return_path = params[:return_path].presence\n+      return_path if return_path &&\n+                     return_path.starts_with?(\"/\") &&\n+                     Rails.application.routes.recognize_path(return_path)","path":"vendor/engines/bulk_email/app/controllers/bulk_email/bulk_email_controller.rb","position":25,"original_position":25,"commit_id":"c33205dfe301a26276cd7073ed98f9428edf21fb","original_commit_id":"c33205dfe301a26276cd7073ed98f9428edf21fb","user":{"login":"drench","id":46662,"avatar_url":"https://avatars.githubusercontent.com/u/46662?v=3","gravatar_id":"","url":"https://api.github.com/users/drench","html_url":"https://github.com/drench","followers_url":"https://api.github.com/users/drench/followers","following_url":"https://api.github.com/users/drench/following{/other_user}","gists_url":"https://api.github.com/users/drench/gists{/gist_id}","starred_url":"https://api.github.com/users/drench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drench/subscriptions","organizations_url":"https://api.github.com/users/drench/orgs","repos_url":"https://api.github.com/users/drench/repos","events_url":"https://api.github.com/users/drench/events{/privacy}","received_events_url":"https://api.github.com/users/drench/received_events","type":"User","site_admin":false},"body":"Yeah this is the first time I've used it. One gotcha for me was that if you give it a full URL it looks like it ignores the \"scheme://hostname\" part so something like `https://github.com/` will pass. That's why there's the check that it starts with \"/\". I'll add that comment.","created_at":"2016-10-05T22:28:26Z","updated_at":"2016-10-05T22:28:26Z","html_url":"https://github.com/tablexi/nucore-open/pull/781#discussion_r82084843","pull_request_url":"https://api.github.com/repos/tablexi/nucore-open/pulls/781","_links":{"self":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/comments/82084843"},"html":{"href":"https://github.com/tablexi/nucore-open/pull/781#discussion_r82084843"},"pull_request":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/781"}}},"pull_request":{"url":"https://api.github.com/repos/tablexi/nucore-open/pulls/781","id":87788151,"html_url":"https://github.com/tablexi/nucore-open/pull/781","diff_url":"https://github.com/tablexi/nucore-open/pull/781.diff","patch_url":"https://github.com/tablexi/nucore-open/pull/781.patch","issue_url":"https://api.github.com/repos/tablexi/nucore-open/issues/781","number":781,"state":"open","locked":false,"title":"[#128124193 128124365 128124381] Add instrument down send mail button","user":{"login":"drench","id":46662,"avatar_url":"https://avatars.githubusercontent.com/u/46662?v=3","gravatar_id":"","url":"https://api.github.com/users/drench","html_url":"https://github.com/drench","followers_url":"https://api.github.com/users/drench/followers","following_url":"https://api.github.com/users/drench/following{/other_user}","gists_url":"https://api.github.com/users/drench/gists{/gist_id}","starred_url":"https://api.github.com/users/drench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drench/subscriptions","organizations_url":"https://api.github.com/users/drench/orgs","repos_url":"https://api.github.com/users/drench/repos","events_url":"https://api.github.com/users/drench/events{/privacy}","received_events_url":"https://api.github.com/users/drench/received_events","type":"User","site_admin":false},"body":"This adds a \"send mail\" button to the instrument admin screen to the right of the online/offline toggle button. When clicked, it sends the user into the bulk email flow with the current instrument selected and a range of the next seven days filled-in as start and end dates.\r\n\r\nIf canceled from the recipient search screen, the user should be sent back to instrument admin.\r\nAfter a successful send action, the user should be sent back to instrument admin.\r\nIf canceled on the mail composition screen, the user is sent back to the recipient search screen as before, and canceling from there should bring the user back to instrument admin.\r\n\r\nAs before, the user does not get redirected on CSV export though we may want to rethink that.","created_at":"2016-10-03T20:44:34Z","updated_at":"2016-10-05T22:28:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"547586df894153be7fb296a8524edc15763ffcb4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tablexi/nucore-open/pulls/781/commits","review_comments_url":"https://api.github.com/repos/tablexi/nucore-open/pulls/781/comments","review_comment_url":"https://api.github.com/repos/tablexi/nucore-open/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tablexi/nucore-open/issues/781/comments","statuses_url":"https://api.github.com/repos/tablexi/nucore-open/statuses/c33205dfe301a26276cd7073ed98f9428edf21fb","head":{"label":"tablexi:128124193-instrument_down-send_button","ref":"128124193-instrument_down-send_button","sha":"c33205dfe301a26276cd7073ed98f9428edf21fb","user":{"login":"tablexi","id":229702,"avatar_url":"https://avatars.githubusercontent.com/u/229702?v=3","gravatar_id":"","url":"https://api.github.com/users/tablexi","html_url":"https://github.com/tablexi","followers_url":"https://api.github.com/users/tablexi/followers","following_url":"https://api.github.com/users/tablexi/following{/other_user}","gists_url":"https://api.github.com/users/tablexi/gists{/gist_id}","starred_url":"https://api.github.com/users/tablexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tablexi/subscriptions","organizations_url":"https://api.github.com/users/tablexi/orgs","repos_url":"https://api.github.com/users/tablexi/repos","events_url":"https://api.github.com/users/tablexi/events{/privacy}","received_events_url":"https://api.github.com/users/tablexi/received_events","type":"Organization","site_admin":false},"repo":{"id":1439473,"name":"nucore-open","full_name":"tablexi/nucore-open","owner":{"login":"tablexi","id":229702,"avatar_url":"https://avatars.githubusercontent.com/u/229702?v=3","gravatar_id":"","url":"https://api.github.com/users/tablexi","html_url":"https://github.com/tablexi","followers_url":"https://api.github.com/users/tablexi/followers","following_url":"https://api.github.com/users/tablexi/following{/other_user}","gists_url":"https://api.github.com/users/tablexi/gists{/gist_id}","starred_url":"https://api.github.com/users/tablexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tablexi/subscriptions","organizations_url":"https://api.github.com/users/tablexi/orgs","repos_url":"https://api.github.com/users/tablexi/repos","events_url":"https://api.github.com/users/tablexi/events{/privacy}","received_events_url":"https://api.github.com/users/tablexi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tablexi/nucore-open","description":"Northwestern University Core Facility Management Software (NUCore)","fork":false,"url":"https://api.github.com/repos/tablexi/nucore-open","forks_url":"https://api.github.com/repos/tablexi/nucore-open/forks","keys_url":"https://api.github.com/repos/tablexi/nucore-open/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tablexi/nucore-open/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tablexi/nucore-open/teams","hooks_url":"https://api.github.com/repos/tablexi/nucore-open/hooks","issue_events_url":"https://api.github.com/repos/tablexi/nucore-open/issues/events{/number}","events_url":"https://api.github.com/repos/tablexi/nucore-open/events","assignees_url":"https://api.github.com/repos/tablexi/nucore-open/assignees{/user}","branches_url":"https://api.github.com/repos/tablexi/nucore-open/branches{/branch}","tags_url":"https://api.github.com/repos/tablexi/nucore-open/tags","blobs_url":"https://api.github.com/repos/tablexi/nucore-open/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tablexi/nucore-open/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tablexi/nucore-open/git/refs{/sha}","trees_url":"https://api.github.com/repos/tablexi/nucore-open/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tablexi/nucore-open/statuses/{sha}","languages_url":"https://api.github.com/repos/tablexi/nucore-open/languages","stargazers_url":"https://api.github.com/repos/tablexi/nucore-open/stargazers","contributors_url":"https://api.github.com/repos/tablexi/nucore-open/contributors","subscribers_url":"https://api.github.com/repos/tablexi/nucore-open/subscribers","subscription_url":"https://api.github.com/repos/tablexi/nucore-open/subscription","commits_url":"https://api.github.com/repos/tablexi/nucore-open/commits{/sha}","git_commits_url":"https://api.github.com/repos/tablexi/nucore-open/git/commits{/sha}","comments_url":"https://api.github.com/repos/tablexi/nucore-open/comments{/number}","issue_comment_url":"https://api.github.com/repos/tablexi/nucore-open/issues/comments{/number}","contents_url":"https://api.github.com/repos/tablexi/nucore-open/contents/{+path}","compare_url":"https://api.github.com/repos/tablexi/nucore-open/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tablexi/nucore-open/merges","archive_url":"https://api.github.com/repos/tablexi/nucore-open/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tablexi/nucore-open/downloads","issues_url":"https://api.github.com/repos/tablexi/nucore-open/issues{/number}","pulls_url":"https://api.github.com/repos/tablexi/nucore-open/pulls{/number}","milestones_url":"https://api.github.com/repos/tablexi/nucore-open/milestones{/number}","notifications_url":"https://api.github.com/repos/tablexi/nucore-open/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tablexi/nucore-open/labels{/name}","releases_url":"https://api.github.com/repos/tablexi/nucore-open/releases{/id}","deployments_url":"https://api.github.com/repos/tablexi/nucore-open/deployments","created_at":"2011-03-04T13:45:37Z","updated_at":"2016-08-31T15:02:19Z","pushed_at":"2016-10-05T18:37:02Z","git_url":"git://github.com/tablexi/nucore-open.git","ssh_url":"git@github.com:tablexi/nucore-open.git","clone_url":"https://github.com/tablexi/nucore-open.git","svn_url":"https://github.com/tablexi/nucore-open","homepage":"","size":66027,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":4,"default_branch":"master"}},"base":{"label":"tablexi:master","ref":"master","sha":"e1380da188c732612401b3d16b4a03192ff04402","user":{"login":"tablexi","id":229702,"avatar_url":"https://avatars.githubusercontent.com/u/229702?v=3","gravatar_id":"","url":"https://api.github.com/users/tablexi","html_url":"https://github.com/tablexi","followers_url":"https://api.github.com/users/tablexi/followers","following_url":"https://api.github.com/users/tablexi/following{/other_user}","gists_url":"https://api.github.com/users/tablexi/gists{/gist_id}","starred_url":"https://api.github.com/users/tablexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tablexi/subscriptions","organizations_url":"https://api.github.com/users/tablexi/orgs","repos_url":"https://api.github.com/users/tablexi/repos","events_url":"https://api.github.com/users/tablexi/events{/privacy}","received_events_url":"https://api.github.com/users/tablexi/received_events","type":"Organization","site_admin":false},"repo":{"id":1439473,"name":"nucore-open","full_name":"tablexi/nucore-open","owner":{"login":"tablexi","id":229702,"avatar_url":"https://avatars.githubusercontent.com/u/229702?v=3","gravatar_id":"","url":"https://api.github.com/users/tablexi","html_url":"https://github.com/tablexi","followers_url":"https://api.github.com/users/tablexi/followers","following_url":"https://api.github.com/users/tablexi/following{/other_user}","gists_url":"https://api.github.com/users/tablexi/gists{/gist_id}","starred_url":"https://api.github.com/users/tablexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tablexi/subscriptions","organizations_url":"https://api.github.com/users/tablexi/orgs","repos_url":"https://api.github.com/users/tablexi/repos","events_url":"https://api.github.com/users/tablexi/events{/privacy}","received_events_url":"https://api.github.com/users/tablexi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tablexi/nucore-open","description":"Northwestern University Core Facility Management Software (NUCore)","fork":false,"url":"https://api.github.com/repos/tablexi/nucore-open","forks_url":"https://api.github.com/repos/tablexi/nucore-open/forks","keys_url":"https://api.github.com/repos/tablexi/nucore-open/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tablexi/nucore-open/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tablexi/nucore-open/teams","hooks_url":"https://api.github.com/repos/tablexi/nucore-open/hooks","issue_events_url":"https://api.github.com/repos/tablexi/nucore-open/issues/events{/number}","events_url":"https://api.github.com/repos/tablexi/nucore-open/events","assignees_url":"https://api.github.com/repos/tablexi/nucore-open/assignees{/user}","branches_url":"https://api.github.com/repos/tablexi/nucore-open/branches{/branch}","tags_url":"https://api.github.com/repos/tablexi/nucore-open/tags","blobs_url":"https://api.github.com/repos/tablexi/nucore-open/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tablexi/nucore-open/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tablexi/nucore-open/git/refs{/sha}","trees_url":"https://api.github.com/repos/tablexi/nucore-open/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tablexi/nucore-open/statuses/{sha}","languages_url":"https://api.github.com/repos/tablexi/nucore-open/languages","stargazers_url":"https://api.github.com/repos/tablexi/nucore-open/stargazers","contributors_url":"https://api.github.com/repos/tablexi/nucore-open/contributors","subscribers_url":"https://api.github.com/repos/tablexi/nucore-open/subscribers","subscription_url":"https://api.github.com/repos/tablexi/nucore-open/subscription","commits_url":"https://api.github.com/repos/tablexi/nucore-open/commits{/sha}","git_commits_url":"https://api.github.com/repos/tablexi/nucore-open/git/commits{/sha}","comments_url":"https://api.github.com/repos/tablexi/nucore-open/comments{/number}","issue_comment_url":"https://api.github.com/repos/tablexi/nucore-open/issues/comments{/number}","contents_url":"https://api.github.com/repos/tablexi/nucore-open/contents/{+path}","compare_url":"https://api.github.com/repos/tablexi/nucore-open/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tablexi/nucore-open/merges","archive_url":"https://api.github.com/repos/tablexi/nucore-open/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tablexi/nucore-open/downloads","issues_url":"https://api.github.com/repos/tablexi/nucore-open/issues{/number}","pulls_url":"https://api.github.com/repos/tablexi/nucore-open/pulls{/number}","milestones_url":"https://api.github.com/repos/tablexi/nucore-open/milestones{/number}","notifications_url":"https://api.github.com/repos/tablexi/nucore-open/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tablexi/nucore-open/labels{/name}","releases_url":"https://api.github.com/repos/tablexi/nucore-open/releases{/id}","deployments_url":"https://api.github.com/repos/tablexi/nucore-open/deployments","created_at":"2011-03-04T13:45:37Z","updated_at":"2016-08-31T15:02:19Z","pushed_at":"2016-10-05T18:37:02Z","git_url":"git://github.com/tablexi/nucore-open.git","ssh_url":"git@github.com:tablexi/nucore-open.git","clone_url":"https://github.com/tablexi/nucore-open.git","svn_url":"https://github.com/tablexi/nucore-open","homepage":"","size":66027,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/781"},"html":{"href":"https://github.com/tablexi/nucore-open/pull/781"},"issue":{"href":"https://api.github.com/repos/tablexi/nucore-open/issues/781"},"comments":{"href":"https://api.github.com/repos/tablexi/nucore-open/issues/781/comments"},"review_comments":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/781/comments"},"review_comment":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tablexi/nucore-open/pulls/781/commits"},"statuses":{"href":"https://api.github.com/repos/tablexi/nucore-open/statuses/c33205dfe301a26276cd7073ed98f9428edf21fb"}}}}
{"actor":{"display_login":"drench"}}