{"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/58848050","id":58848050,"diff_hunk":"@@ -35,16 +38,19 @@\n  * Base class for various locking interceptors in this package.\n  *\n  * @author Mircea Markus\n- * @deprecated Since 8.2, no longer public API.\n  */\n-@Deprecated\n-public abstract class AbstractLockingInterceptor extends CommandInterceptor {\n-   private boolean trace = getLog().isTraceEnabled();\n+public abstract class AbstractLockingInterceptor extends DDSequentialInterceptor {\n+   private static final Log log = LogFactory.getLog(AbstractLockingInterceptor.class);","path":"core/src/main/java/org/infinispan/interceptors/locking/AbstractLockingInterceptor.java","position":29,"original_position":29,"commit_id":"1294ff4fcb2aec8ab2570e97f732d96ff13ff093","original_commit_id":"03db717acc029e65806f00d82c950f3e5dc31894","user":{"login":"danberindei","id":504907,"avatar_url":"https://avatars.githubusercontent.com/u/504907?v=3","gravatar_id":"","url":"https://api.github.com/users/danberindei","html_url":"https://github.com/danberindei","followers_url":"https://api.github.com/users/danberindei/followers","following_url":"https://api.github.com/users/danberindei/following{/other_user}","gists_url":"https://api.github.com/users/danberindei/gists{/gist_id}","starred_url":"https://api.github.com/users/danberindei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danberindei/subscriptions","organizations_url":"https://api.github.com/users/danberindei/orgs","repos_url":"https://api.github.com/users/danberindei/repos","events_url":"https://api.github.com/users/danberindei/events{/privacy}","received_events_url":"https://api.github.com/users/danberindei/received_events","type":"User","site_admin":false},"body":"The rest of the code was still using `getLog()` everywhere, so I just removed the field and the method body.","created_at":"2016-04-07T10:06:47Z","updated_at":"2016-04-07T10:06:47Z","html_url":"https://github.com/infinispan/infinispan/pull/3976#discussion_r58848050","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3976","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/58848050"},"html":{"href":"https://github.com/infinispan/infinispan/pull/3976#discussion_r58848050"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3976"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/3976","id":57852034,"html_url":"https://github.com/infinispan/infinispan/pull/3976","diff_url":"https://github.com/infinispan/infinispan/pull/3976.diff","patch_url":"https://github.com/infinispan/infinispan/pull/3976.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/3976","number":3976,"state":"open","locked":false,"title":"ISPN-5468 Make interceptors sequential","user":{"login":"danberindei","id":504907,"avatar_url":"https://avatars.githubusercontent.com/u/504907?v=3","gravatar_id":"","url":"https://api.github.com/users/danberindei","html_url":"https://github.com/danberindei","followers_url":"https://api.github.com/users/danberindei/followers","following_url":"https://api.github.com/users/danberindei/following{/other_user}","gists_url":"https://api.github.com/users/danberindei/gists{/gist_id}","starred_url":"https://api.github.com/users/danberindei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danberindei/subscriptions","organizations_url":"https://api.github.com/users/danberindei/orgs","repos_url":"https://api.github.com/users/danberindei/repos","events_url":"https://api.github.com/users/danberindei/events{/privacy}","received_events_url":"https://api.github.com/users/danberindei/received_events","type":"User","site_admin":false},"body":"Requires https://github.com/infinispan/infinispan/pull/3819\r\n\r\nMakes the interceptors implement the `SequentialInterceptor` interface, as opposed to extending `CommandInterceptor`. To ease rebasing, there are no meaningful code changes in the interceptors: `invokeNextInterceptor()` calls are replaced by `forkInvocationSync()`, and there are no return handlers or async interceptors.\r\n\r\nPerformance is 50% down from master for local mode reads, so it's not quite ready to integrate yet.\r\n\r\n","created_at":"2016-02-01T15:12:55Z","updated_at":"2016-04-07T10:06:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d69b93601541022b856aacd272dd1ca243cbd2a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3976/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3976/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/3976/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/1294ff4fcb2aec8ab2570e97f732d96ff13ff093","head":{"label":"danberindei:ISPN-5468_make_interceptors_sequential","ref":"ISPN-5468_make_interceptors_sequential","sha":"1294ff4fcb2aec8ab2570e97f732d96ff13ff093","user":{"login":"danberindei","id":504907,"avatar_url":"https://avatars.githubusercontent.com/u/504907?v=3","gravatar_id":"","url":"https://api.github.com/users/danberindei","html_url":"https://github.com/danberindei","followers_url":"https://api.github.com/users/danberindei/followers","following_url":"https://api.github.com/users/danberindei/following{/other_user}","gists_url":"https://api.github.com/users/danberindei/gists{/gist_id}","starred_url":"https://api.github.com/users/danberindei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danberindei/subscriptions","organizations_url":"https://api.github.com/users/danberindei/orgs","repos_url":"https://api.github.com/users/danberindei/repos","events_url":"https://api.github.com/users/danberindei/events{/privacy}","received_events_url":"https://api.github.com/users/danberindei/received_events","type":"User","site_admin":false},"repo":{"id":1128600,"name":"infinispan","full_name":"danberindei/infinispan","owner":{"login":"danberindei","id":504907,"avatar_url":"https://avatars.githubusercontent.com/u/504907?v=3","gravatar_id":"","url":"https://api.github.com/users/danberindei","html_url":"https://github.com/danberindei","followers_url":"https://api.github.com/users/danberindei/followers","following_url":"https://api.github.com/users/danberindei/following{/other_user}","gists_url":"https://api.github.com/users/danberindei/gists{/gist_id}","starred_url":"https://api.github.com/users/danberindei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danberindei/subscriptions","organizations_url":"https://api.github.com/users/danberindei/orgs","repos_url":"https://api.github.com/users/danberindei/repos","events_url":"https://api.github.com/users/danberindei/events{/privacy}","received_events_url":"https://api.github.com/users/danberindei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danberindei/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":true,"url":"https://api.github.com/repos/danberindei/infinispan","forks_url":"https://api.github.com/repos/danberindei/infinispan/forks","keys_url":"https://api.github.com/repos/danberindei/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danberindei/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danberindei/infinispan/teams","hooks_url":"https://api.github.com/repos/danberindei/infinispan/hooks","issue_events_url":"https://api.github.com/repos/danberindei/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/danberindei/infinispan/events","assignees_url":"https://api.github.com/repos/danberindei/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/danberindei/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/danberindei/infinispan/tags","blobs_url":"https://api.github.com/repos/danberindei/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danberindei/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danberindei/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/danberindei/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danberindei/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/danberindei/infinispan/languages","stargazers_url":"https://api.github.com/repos/danberindei/infinispan/stargazers","contributors_url":"https://api.github.com/repos/danberindei/infinispan/contributors","subscribers_url":"https://api.github.com/repos/danberindei/infinispan/subscribers","subscription_url":"https://api.github.com/repos/danberindei/infinispan/subscription","commits_url":"https://api.github.com/repos/danberindei/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/danberindei/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/danberindei/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/danberindei/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/danberindei/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/danberindei/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danberindei/infinispan/merges","archive_url":"https://api.github.com/repos/danberindei/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danberindei/infinispan/downloads","issues_url":"https://api.github.com/repos/danberindei/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/danberindei/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/danberindei/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/danberindei/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danberindei/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/danberindei/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/danberindei/infinispan/deployments","created_at":"2010-12-01T12:42:11Z","updated_at":"2015-05-05T12:41:53Z","pushed_at":"2016-04-07T08:18:42Z","git_url":"git://github.com/danberindei/infinispan.git","ssh_url":"git@github.com:danberindei/infinispan.git","clone_url":"https://github.com/danberindei/infinispan.git","svn_url":"https://github.com/danberindei/infinispan","homepage":"http://www.infinispan.org","size":83737,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"750564a5e44405ae47db9ade4399f5a24d1b2215","user":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":1050944,"name":"infinispan","full_name":"infinispan/infinispan","owner":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinispan/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","forks_url":"https://api.github.com/repos/infinispan/infinispan/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/infinispan/infinispan/deployments","created_at":"2010-11-04T12:33:19Z","updated_at":"2016-04-07T08:37:22Z","pushed_at":"2016-04-07T09:44:09Z","git_url":"git://github.com/infinispan/infinispan.git","ssh_url":"git@github.com:infinispan/infinispan.git","clone_url":"https://github.com/infinispan/infinispan.git","svn_url":"https://github.com/infinispan/infinispan","homepage":"http://www.infinispan.org","size":92748,"stargazers_count":460,"watchers_count":460,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":338,"mirror_url":null,"open_issues_count":15,"forks":338,"open_issues":15,"watchers":460,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3976"},"html":{"href":"https://github.com/infinispan/infinispan/pull/3976"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/3976"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/3976/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3976/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3976/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan/statuses/1294ff4fcb2aec8ab2570e97f732d96ff13ff093"}}}}