{"action":"created","comment":{"url":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/comments/92920948","pull_request_review_id":13445976,"id":92920948,"diff_hunk":"@@ -133,9 +134,29 @@ object SeqexecEngine {\n       val instSim = cfg.require[Boolean](\"seqexec-engine.instSim\")\n       val gcalSim = cfg.require[Boolean](\"seqexec-engine.gcalSim\")\n \n-      for {\n-        now <- Task(LocalDate.now)\n-      } yield Settings(odbHost, now, dhsServer, dhsSim, tcsSim, instSim, gcalSim)\n+\n+    // TODO: Review initialization of EPICS systems\n+    def initEpicsSystem(sys: EpicsSystem): Task[Unit] = Task(Option(CaService.getInstance()) match {\n+          case None => throw new Exception(\"Unable to start EPICS service.\")\n+          case Some(s) => {\n+            (sys.init(s)).leftMap {\n+                case SeqexecFailure.SeqexecException(ex) => throw ex\n+                case c: SeqexecFailure => throw new Exception(SeqexecFailure.explain(c))\n+            }\n+          }\n+        }\n+      )\n+\n+      val tcsInit = if(tcsSim) Task(()) else initEpicsSystem(TcsEpics)\n+      // More instruments to be added to the list here\n+      val instInit = if(instSim) Task(())\n+        else Nondeterminism[Task].gatherUnordered(List(Flamingos2Epics).map(initEpicsSystem(_)))","path":"modules/edu.gemini.seqexec.server/src/main/scala/edu/gemini/seqexec/server/SeqexecEngine.scala","position":31,"original_position":31,"commit_id":"3810e9b9b11d865d0b146ee502bf4937186f6a27","original_commit_id":"3810e9b9b11d865d0b146ee502bf4937186f6a27","user":{"login":"cquiroz","id":3615303,"avatar_url":"https://avatars.githubusercontent.com/u/3615303?v=3","gravatar_id":"","url":"https://api.github.com/users/cquiroz","html_url":"https://github.com/cquiroz","followers_url":"https://api.github.com/users/cquiroz/followers","following_url":"https://api.github.com/users/cquiroz/following{/other_user}","gists_url":"https://api.github.com/users/cquiroz/gists{/gist_id}","starred_url":"https://api.github.com/users/cquiroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cquiroz/subscriptions","organizations_url":"https://api.github.com/users/cquiroz/orgs","repos_url":"https://api.github.com/users/cquiroz/repos","events_url":"https://api.github.com/users/cquiroz/events{/privacy}","received_events_url":"https://api.github.com/users/cquiroz/received_events","type":"User","site_admin":false},"body":"It seems that when we'll have many instruments you'd call `initEpicsSystem` once per each instrument. Is that necessary given that `initEpicsSystem` just calls `CaService.getInstance` or will be there in the future instrument-specific initalization code?","created_at":"2016-12-17T12:23:46Z","updated_at":"2016-12-17T12:23:46Z","html_url":"https://github.com/gemini-hlsw/ocs3/pull/126#discussion_r92920948","pull_request_url":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/126","_links":{"self":{"href":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/comments/92920948"},"html":{"href":"https://github.com/gemini-hlsw/ocs3/pull/126#discussion_r92920948"},"pull_request":{"href":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/126"}}},"pull_request":{"url":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/126","id":98326821,"html_url":"https://github.com/gemini-hlsw/ocs3/pull/126","diff_url":"https://github.com/gemini-hlsw/ocs3/pull/126.diff","patch_url":"https://github.com/gemini-hlsw/ocs3/pull/126.patch","issue_url":"https://api.github.com/repos/gemini-hlsw/ocs3/issues/126","number":126,"state":"closed","locked":false,"title":"SEQNG-74 Bugfixes to make it work with EPICS systems.","user":{"login":"jluhrs","id":7621164,"avatar_url":"https://avatars.githubusercontent.com/u/7621164?v=3","gravatar_id":"","url":"https://api.github.com/users/jluhrs","html_url":"https://github.com/jluhrs","followers_url":"https://api.github.com/users/jluhrs/followers","following_url":"https://api.github.com/users/jluhrs/following{/other_user}","gists_url":"https://api.github.com/users/jluhrs/gists{/gist_id}","starred_url":"https://api.github.com/users/jluhrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jluhrs/subscriptions","organizations_url":"https://api.github.com/users/jluhrs/orgs","repos_url":"https://api.github.com/users/jluhrs/repos","events_url":"https://api.github.com/users/jluhrs/events{/privacy}","received_events_url":"https://api.github.com/users/jluhrs/received_events","type":"User","site_admin":false},"body":"The biggest change is the inclusion of initialization of the EPICS connections. Not sure if it is in the right place. The rest are small bug fixes or improvements to simulations.","created_at":"2016-12-16T12:28:03Z","updated_at":"2016-12-17T12:23:46Z","closed_at":"2016-12-16T17:57:19Z","merged_at":"2016-12-16T17:57:19Z","merge_commit_sha":"b13857c1c57d668152b5ae96647e94c89f311f76","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/126/commits","review_comments_url":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/126/comments","review_comment_url":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gemini-hlsw/ocs3/issues/126/comments","statuses_url":"https://api.github.com/repos/gemini-hlsw/ocs3/statuses/3810e9b9b11d865d0b146ee502bf4937186f6a27","head":{"label":"jluhrs:feature/SEQNG-74","ref":"feature/SEQNG-74","sha":"3810e9b9b11d865d0b146ee502bf4937186f6a27","user":{"login":"jluhrs","id":7621164,"avatar_url":"https://avatars.githubusercontent.com/u/7621164?v=3","gravatar_id":"","url":"https://api.github.com/users/jluhrs","html_url":"https://github.com/jluhrs","followers_url":"https://api.github.com/users/jluhrs/followers","following_url":"https://api.github.com/users/jluhrs/following{/other_user}","gists_url":"https://api.github.com/users/jluhrs/gists{/gist_id}","starred_url":"https://api.github.com/users/jluhrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jluhrs/subscriptions","organizations_url":"https://api.github.com/users/jluhrs/orgs","repos_url":"https://api.github.com/users/jluhrs/repos","events_url":"https://api.github.com/users/jluhrs/events{/privacy}","received_events_url":"https://api.github.com/users/jluhrs/received_events","type":"User","site_admin":false},"repo":{"id":55434986,"name":"ocs3","full_name":"jluhrs/ocs3","owner":{"login":"jluhrs","id":7621164,"avatar_url":"https://avatars.githubusercontent.com/u/7621164?v=3","gravatar_id":"","url":"https://api.github.com/users/jluhrs","html_url":"https://github.com/jluhrs","followers_url":"https://api.github.com/users/jluhrs/followers","following_url":"https://api.github.com/users/jluhrs/following{/other_user}","gists_url":"https://api.github.com/users/jluhrs/gists{/gist_id}","starred_url":"https://api.github.com/users/jluhrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jluhrs/subscriptions","organizations_url":"https://api.github.com/users/jluhrs/orgs","repos_url":"https://api.github.com/users/jluhrs/repos","events_url":"https://api.github.com/users/jluhrs/events{/privacy}","received_events_url":"https://api.github.com/users/jluhrs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jluhrs/ocs3","description":"Observatory Control Software - New Generation","fork":true,"url":"https://api.github.com/repos/jluhrs/ocs3","forks_url":"https://api.github.com/repos/jluhrs/ocs3/forks","keys_url":"https://api.github.com/repos/jluhrs/ocs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jluhrs/ocs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jluhrs/ocs3/teams","hooks_url":"https://api.github.com/repos/jluhrs/ocs3/hooks","issue_events_url":"https://api.github.com/repos/jluhrs/ocs3/issues/events{/number}","events_url":"https://api.github.com/repos/jluhrs/ocs3/events","assignees_url":"https://api.github.com/repos/jluhrs/ocs3/assignees{/user}","branches_url":"https://api.github.com/repos/jluhrs/ocs3/branches{/branch}","tags_url":"https://api.github.com/repos/jluhrs/ocs3/tags","blobs_url":"https://api.github.com/repos/jluhrs/ocs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jluhrs/ocs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jluhrs/ocs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/jluhrs/ocs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jluhrs/ocs3/statuses/{sha}","languages_url":"https://api.github.com/repos/jluhrs/ocs3/languages","stargazers_url":"https://api.github.com/repos/jluhrs/ocs3/stargazers","contributors_url":"https://api.github.com/repos/jluhrs/ocs3/contributors","subscribers_url":"https://api.github.com/repos/jluhrs/ocs3/subscribers","subscription_url":"https://api.github.com/repos/jluhrs/ocs3/subscription","commits_url":"https://api.github.com/repos/jluhrs/ocs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/jluhrs/ocs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/jluhrs/ocs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/jluhrs/ocs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/jluhrs/ocs3/contents/{+path}","compare_url":"https://api.github.com/repos/jluhrs/ocs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jluhrs/ocs3/merges","archive_url":"https://api.github.com/repos/jluhrs/ocs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jluhrs/ocs3/downloads","issues_url":"https://api.github.com/repos/jluhrs/ocs3/issues{/number}","pulls_url":"https://api.github.com/repos/jluhrs/ocs3/pulls{/number}","milestones_url":"https://api.github.com/repos/jluhrs/ocs3/milestones{/number}","notifications_url":"https://api.github.com/repos/jluhrs/ocs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jluhrs/ocs3/labels{/name}","releases_url":"https://api.github.com/repos/jluhrs/ocs3/releases{/id}","deployments_url":"https://api.github.com/repos/jluhrs/ocs3/deployments","created_at":"2016-04-04T18:30:23Z","updated_at":"2016-04-04T18:30:24Z","pushed_at":"2016-12-16T12:37:43Z","git_url":"git://github.com/jluhrs/ocs3.git","ssh_url":"git@github.com:jluhrs/ocs3.git","clone_url":"https://github.com/jluhrs/ocs3.git","svn_url":"https://github.com/jluhrs/ocs3","homepage":null,"size":4454,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"gemini-hlsw:develop","ref":"develop","sha":"b3fbdd93b12ced79981e257f8faf28fe29ee4b4b","user":{"login":"gemini-hlsw","id":8593735,"avatar_url":"https://avatars.githubusercontent.com/u/8593735?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-hlsw","html_url":"https://github.com/gemini-hlsw","followers_url":"https://api.github.com/users/gemini-hlsw/followers","following_url":"https://api.github.com/users/gemini-hlsw/following{/other_user}","gists_url":"https://api.github.com/users/gemini-hlsw/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-hlsw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-hlsw/subscriptions","organizations_url":"https://api.github.com/users/gemini-hlsw/orgs","repos_url":"https://api.github.com/users/gemini-hlsw/repos","events_url":"https://api.github.com/users/gemini-hlsw/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-hlsw/received_events","type":"Organization","site_admin":false},"repo":{"id":54653732,"name":"ocs3","full_name":"gemini-hlsw/ocs3","owner":{"login":"gemini-hlsw","id":8593735,"avatar_url":"https://avatars.githubusercontent.com/u/8593735?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-hlsw","html_url":"https://github.com/gemini-hlsw","followers_url":"https://api.github.com/users/gemini-hlsw/followers","following_url":"https://api.github.com/users/gemini-hlsw/following{/other_user}","gists_url":"https://api.github.com/users/gemini-hlsw/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-hlsw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-hlsw/subscriptions","organizations_url":"https://api.github.com/users/gemini-hlsw/orgs","repos_url":"https://api.github.com/users/gemini-hlsw/repos","events_url":"https://api.github.com/users/gemini-hlsw/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-hlsw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gemini-hlsw/ocs3","description":"Observatory Control Software - New Generation","fork":false,"url":"https://api.github.com/repos/gemini-hlsw/ocs3","forks_url":"https://api.github.com/repos/gemini-hlsw/ocs3/forks","keys_url":"https://api.github.com/repos/gemini-hlsw/ocs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gemini-hlsw/ocs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gemini-hlsw/ocs3/teams","hooks_url":"https://api.github.com/repos/gemini-hlsw/ocs3/hooks","issue_events_url":"https://api.github.com/repos/gemini-hlsw/ocs3/issues/events{/number}","events_url":"https://api.github.com/repos/gemini-hlsw/ocs3/events","assignees_url":"https://api.github.com/repos/gemini-hlsw/ocs3/assignees{/user}","branches_url":"https://api.github.com/repos/gemini-hlsw/ocs3/branches{/branch}","tags_url":"https://api.github.com/repos/gemini-hlsw/ocs3/tags","blobs_url":"https://api.github.com/repos/gemini-hlsw/ocs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gemini-hlsw/ocs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gemini-hlsw/ocs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/gemini-hlsw/ocs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gemini-hlsw/ocs3/statuses/{sha}","languages_url":"https://api.github.com/repos/gemini-hlsw/ocs3/languages","stargazers_url":"https://api.github.com/repos/gemini-hlsw/ocs3/stargazers","contributors_url":"https://api.github.com/repos/gemini-hlsw/ocs3/contributors","subscribers_url":"https://api.github.com/repos/gemini-hlsw/ocs3/subscribers","subscription_url":"https://api.github.com/repos/gemini-hlsw/ocs3/subscription","commits_url":"https://api.github.com/repos/gemini-hlsw/ocs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/gemini-hlsw/ocs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/gemini-hlsw/ocs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/gemini-hlsw/ocs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/gemini-hlsw/ocs3/contents/{+path}","compare_url":"https://api.github.com/repos/gemini-hlsw/ocs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gemini-hlsw/ocs3/merges","archive_url":"https://api.github.com/repos/gemini-hlsw/ocs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gemini-hlsw/ocs3/downloads","issues_url":"https://api.github.com/repos/gemini-hlsw/ocs3/issues{/number}","pulls_url":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls{/number}","milestones_url":"https://api.github.com/repos/gemini-hlsw/ocs3/milestones{/number}","notifications_url":"https://api.github.com/repos/gemini-hlsw/ocs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gemini-hlsw/ocs3/labels{/name}","releases_url":"https://api.github.com/repos/gemini-hlsw/ocs3/releases{/id}","deployments_url":"https://api.github.com/repos/gemini-hlsw/ocs3/deployments","created_at":"2016-03-24T15:40:39Z","updated_at":"2016-11-25T15:24:50Z","pushed_at":"2016-12-16T17:57:19Z","git_url":"git://github.com/gemini-hlsw/ocs3.git","ssh_url":"git@github.com:gemini-hlsw/ocs3.git","clone_url":"https://github.com/gemini-hlsw/ocs3.git","svn_url":"https://github.com/gemini-hlsw/ocs3","homepage":null,"size":4407,"stargazers_count":4,"watchers_count":4,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":13,"forks":3,"open_issues":13,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/126"},"html":{"href":"https://github.com/gemini-hlsw/ocs3/pull/126"},"issue":{"href":"https://api.github.com/repos/gemini-hlsw/ocs3/issues/126"},"comments":{"href":"https://api.github.com/repos/gemini-hlsw/ocs3/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gemini-hlsw/ocs3/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/gemini-hlsw/ocs3/statuses/3810e9b9b11d865d0b146ee502bf4937186f6a27"}}}}
{"actor":{"display_login":"cquiroz"}}