{"action":"created","comment":{"url":"https://api.github.com/repos/syncthing/syncthing/pulls/comments/51689725","id":51689725,"diff_hunk":"@@ -129,9 +129,17 @@ type ClusterConfigMessage struct {\n \tClientName    string   // max:64\n \tClientVersion string   // max:64\n \tFolders       []Folder // max:1000000\n+\tFlags         uint32\n \tOptions       []Option // max:64\n }\n \n+type DownloadProgressMessage struct {\n+\tFolder  string                       // max:64\n+\tUpdates []FileDownloadProgressUpdate // max:1000000","path":"lib/protocol/message.go","position":10,"original_position":10,"commit_id":"baf7b4f2922b8c178371969693941d4440765cb8","original_commit_id":"3b6a4ea39f0442d0993bb04bba0348e571894196","user":{"login":"calmh","id":125426,"avatar_url":"https://avatars.githubusercontent.com/u/125426?v=3","gravatar_id":"","url":"https://api.github.com/users/calmh","html_url":"https://github.com/calmh","followers_url":"https://api.github.com/users/calmh/followers","following_url":"https://api.github.com/users/calmh/following{/other_user}","gists_url":"https://api.github.com/users/calmh/gists{/gist_id}","starred_url":"https://api.github.com/users/calmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calmh/subscriptions","organizations_url":"https://api.github.com/users/calmh/orgs","repos_url":"https://api.github.com/users/calmh/repos","events_url":"https://api.github.com/users/calmh/events{/privacy}","received_events_url":"https://api.github.com/users/calmh/received_events","type":"User","site_admin":false},"body":"Just the wording difference between \"DownloadProgressSomething\" and \"FileDownloadProgressSomething\"; we could skip the \"File\" prefix.","created_at":"2016-02-03T08:09:45Z","updated_at":"2016-02-03T08:09:45Z","html_url":"https://github.com/syncthing/syncthing/pull/2252#discussion_r51689725","pull_request_url":"https://api.github.com/repos/syncthing/syncthing/pulls/2252","_links":{"self":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/comments/51689725"},"html":{"href":"https://github.com/syncthing/syncthing/pull/2252#discussion_r51689725"},"pull_request":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/2252"}}},"pull_request":{"url":"https://api.github.com/repos/syncthing/syncthing/pulls/2252","id":44461808,"html_url":"https://github.com/syncthing/syncthing/pull/2252","diff_url":"https://github.com/syncthing/syncthing/pull/2252.diff","patch_url":"https://github.com/syncthing/syncthing/pull/2252.patch","issue_url":"https://api.github.com/repos/syncthing/syncthing/issues/2252","number":2252,"state":"open","locked":false,"title":"Temporary indexes","user":{"login":"AudriusButkevicius","id":1144861,"avatar_url":"https://avatars.githubusercontent.com/u/1144861?v=3","gravatar_id":"","url":"https://api.github.com/users/AudriusButkevicius","html_url":"https://github.com/AudriusButkevicius","followers_url":"https://api.github.com/users/AudriusButkevicius/followers","following_url":"https://api.github.com/users/AudriusButkevicius/following{/other_user}","gists_url":"https://api.github.com/users/AudriusButkevicius/gists{/gist_id}","starred_url":"https://api.github.com/users/AudriusButkevicius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AudriusButkevicius/subscriptions","organizations_url":"https://api.github.com/users/AudriusButkevicius/orgs","repos_url":"https://api.github.com/users/AudriusButkevicius/repos","events_url":"https://api.github.com/users/AudriusButkevicius/events{/privacy}","received_events_url":"https://api.github.com/users/AudriusButkevicius/received_events","type":"User","site_admin":false},"body":"Last commit is not finished, but throwing this out here to discuss the general approach before I spend more effort.\r\nAlso needs tests fixed and so on.\r\n\r\n## TODO:\r\n- [X] Send block index as an integer, rather than the whole block.\r\n- [X] Add a flag to indicate this feature is off, don't send stuff if it's off.\r\n- [X] Fallback to Request() in-case temporary request fails (no longer applicable, given we don't do validation, so it's just a if branch)\r\n- [X] Address lint/vet/naming suggestions\r\n- [X] Fix tests\r\n- [X] Add tests\r\n\r\n## Maybe:\r\n- Limit number of entries we allow to receive, though people should just disable it.\r\n","created_at":"2015-09-08T17:47:24Z","updated_at":"2016-02-03T08:09:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d14466e32713a077e485ad5e69c3b0ec688df5e1","assignee":null,"milestone":{"url":"https://api.github.com/repos/syncthing/syncthing/milestones/2","html_url":"https://github.com/syncthing/syncthing/milestones/v1.0","labels_url":"https://api.github.com/repos/syncthing/syncthing/milestones/2/labels","id":528782,"number":2,"title":"v1.0","description":"Issues that *must* be resolved before releasing v1.0.","creator":{"login":"calmh","id":125426,"avatar_url":"https://avatars.githubusercontent.com/u/125426?v=3","gravatar_id":"","url":"https://api.github.com/users/calmh","html_url":"https://github.com/calmh","followers_url":"https://api.github.com/users/calmh/followers","following_url":"https://api.github.com/users/calmh/following{/other_user}","gists_url":"https://api.github.com/users/calmh/gists{/gist_id}","starred_url":"https://api.github.com/users/calmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calmh/subscriptions","organizations_url":"https://api.github.com/users/calmh/orgs","repos_url":"https://api.github.com/users/calmh/repos","events_url":"https://api.github.com/users/calmh/events{/privacy}","received_events_url":"https://api.github.com/users/calmh/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":85,"state":"open","created_at":"2014-01-07T11:09:27Z","updated_at":"2016-01-12T10:58:30Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/syncthing/syncthing/pulls/2252/commits","review_comments_url":"https://api.github.com/repos/syncthing/syncthing/pulls/2252/comments","review_comment_url":"https://api.github.com/repos/syncthing/syncthing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/syncthing/syncthing/issues/2252/comments","statuses_url":"https://api.github.com/repos/syncthing/syncthing/statuses/baf7b4f2922b8c178371969693941d4440765cb8","head":{"label":"AudriusButkevicius:dprog","ref":"dprog","sha":"baf7b4f2922b8c178371969693941d4440765cb8","user":{"login":"AudriusButkevicius","id":1144861,"avatar_url":"https://avatars.githubusercontent.com/u/1144861?v=3","gravatar_id":"","url":"https://api.github.com/users/AudriusButkevicius","html_url":"https://github.com/AudriusButkevicius","followers_url":"https://api.github.com/users/AudriusButkevicius/followers","following_url":"https://api.github.com/users/AudriusButkevicius/following{/other_user}","gists_url":"https://api.github.com/users/AudriusButkevicius/gists{/gist_id}","starred_url":"https://api.github.com/users/AudriusButkevicius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AudriusButkevicius/subscriptions","organizations_url":"https://api.github.com/users/AudriusButkevicius/orgs","repos_url":"https://api.github.com/users/AudriusButkevicius/repos","events_url":"https://api.github.com/users/AudriusButkevicius/events{/privacy}","received_events_url":"https://api.github.com/users/AudriusButkevicius/received_events","type":"User","site_admin":false},"repo":{"id":22119752,"name":"syncthing","full_name":"AudriusButkevicius/syncthing","owner":{"login":"AudriusButkevicius","id":1144861,"avatar_url":"https://avatars.githubusercontent.com/u/1144861?v=3","gravatar_id":"","url":"https://api.github.com/users/AudriusButkevicius","html_url":"https://github.com/AudriusButkevicius","followers_url":"https://api.github.com/users/AudriusButkevicius/followers","following_url":"https://api.github.com/users/AudriusButkevicius/following{/other_user}","gists_url":"https://api.github.com/users/AudriusButkevicius/gists{/gist_id}","starred_url":"https://api.github.com/users/AudriusButkevicius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AudriusButkevicius/subscriptions","organizations_url":"https://api.github.com/users/AudriusButkevicius/orgs","repos_url":"https://api.github.com/users/AudriusButkevicius/repos","events_url":"https://api.github.com/users/AudriusButkevicius/events{/privacy}","received_events_url":"https://api.github.com/users/AudriusButkevicius/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AudriusButkevicius/syncthing","description":"Open Source Continuous File Synchronization","fork":true,"url":"https://api.github.com/repos/AudriusButkevicius/syncthing","forks_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/forks","keys_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/teams","hooks_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/hooks","issue_events_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/issues/events{/number}","events_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/events","assignees_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/assignees{/user}","branches_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/branches{/branch}","tags_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/tags","blobs_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/git/refs{/sha}","trees_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/statuses/{sha}","languages_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/languages","stargazers_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/stargazers","contributors_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/contributors","subscribers_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/subscribers","subscription_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/subscription","commits_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/commits{/sha}","git_commits_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/git/commits{/sha}","comments_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/comments{/number}","issue_comment_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/issues/comments{/number}","contents_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/contents/{+path}","compare_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/merges","archive_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/downloads","issues_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/issues{/number}","pulls_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/pulls{/number}","milestones_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/milestones{/number}","notifications_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/labels{/name}","releases_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/releases{/id}","deployments_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/deployments","created_at":"2014-07-22T20:36:14Z","updated_at":"2015-03-30T20:58:54Z","pushed_at":"2016-01-30T12:39:14Z","git_url":"git://github.com/AudriusButkevicius/syncthing.git","ssh_url":"git@github.com:AudriusButkevicius/syncthing.git","clone_url":"https://github.com/AudriusButkevicius/syncthing.git","svn_url":"https://github.com/AudriusButkevicius/syncthing","homepage":"http://discourse.syncthing.net/","size":61519,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"syncthing:master","ref":"master","sha":"cc5f93e717d78a3ff8863081b6c27e20a6c3fa9a","user":{"login":"syncthing","id":7628018,"avatar_url":"https://avatars.githubusercontent.com/u/7628018?v=3","gravatar_id":"","url":"https://api.github.com/users/syncthing","html_url":"https://github.com/syncthing","followers_url":"https://api.github.com/users/syncthing/followers","following_url":"https://api.github.com/users/syncthing/following{/other_user}","gists_url":"https://api.github.com/users/syncthing/gists{/gist_id}","starred_url":"https://api.github.com/users/syncthing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syncthing/subscriptions","organizations_url":"https://api.github.com/users/syncthing/orgs","repos_url":"https://api.github.com/users/syncthing/repos","events_url":"https://api.github.com/users/syncthing/events{/privacy}","received_events_url":"https://api.github.com/users/syncthing/received_events","type":"Organization","site_admin":false},"repo":{"id":14712850,"name":"syncthing","full_name":"syncthing/syncthing","owner":{"login":"syncthing","id":7628018,"avatar_url":"https://avatars.githubusercontent.com/u/7628018?v=3","gravatar_id":"","url":"https://api.github.com/users/syncthing","html_url":"https://github.com/syncthing","followers_url":"https://api.github.com/users/syncthing/followers","following_url":"https://api.github.com/users/syncthing/following{/other_user}","gists_url":"https://api.github.com/users/syncthing/gists{/gist_id}","starred_url":"https://api.github.com/users/syncthing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syncthing/subscriptions","organizations_url":"https://api.github.com/users/syncthing/orgs","repos_url":"https://api.github.com/users/syncthing/repos","events_url":"https://api.github.com/users/syncthing/events{/privacy}","received_events_url":"https://api.github.com/users/syncthing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/syncthing/syncthing","description":"Open Source Continuous File Synchronization","fork":false,"url":"https://api.github.com/repos/syncthing/syncthing","forks_url":"https://api.github.com/repos/syncthing/syncthing/forks","keys_url":"https://api.github.com/repos/syncthing/syncthing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syncthing/syncthing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syncthing/syncthing/teams","hooks_url":"https://api.github.com/repos/syncthing/syncthing/hooks","issue_events_url":"https://api.github.com/repos/syncthing/syncthing/issues/events{/number}","events_url":"https://api.github.com/repos/syncthing/syncthing/events","assignees_url":"https://api.github.com/repos/syncthing/syncthing/assignees{/user}","branches_url":"https://api.github.com/repos/syncthing/syncthing/branches{/branch}","tags_url":"https://api.github.com/repos/syncthing/syncthing/tags","blobs_url":"https://api.github.com/repos/syncthing/syncthing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syncthing/syncthing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syncthing/syncthing/git/refs{/sha}","trees_url":"https://api.github.com/repos/syncthing/syncthing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syncthing/syncthing/statuses/{sha}","languages_url":"https://api.github.com/repos/syncthing/syncthing/languages","stargazers_url":"https://api.github.com/repos/syncthing/syncthing/stargazers","contributors_url":"https://api.github.com/repos/syncthing/syncthing/contributors","subscribers_url":"https://api.github.com/repos/syncthing/syncthing/subscribers","subscription_url":"https://api.github.com/repos/syncthing/syncthing/subscription","commits_url":"https://api.github.com/repos/syncthing/syncthing/commits{/sha}","git_commits_url":"https://api.github.com/repos/syncthing/syncthing/git/commits{/sha}","comments_url":"https://api.github.com/repos/syncthing/syncthing/comments{/number}","issue_comment_url":"https://api.github.com/repos/syncthing/syncthing/issues/comments{/number}","contents_url":"https://api.github.com/repos/syncthing/syncthing/contents/{+path}","compare_url":"https://api.github.com/repos/syncthing/syncthing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syncthing/syncthing/merges","archive_url":"https://api.github.com/repos/syncthing/syncthing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syncthing/syncthing/downloads","issues_url":"https://api.github.com/repos/syncthing/syncthing/issues{/number}","pulls_url":"https://api.github.com/repos/syncthing/syncthing/pulls{/number}","milestones_url":"https://api.github.com/repos/syncthing/syncthing/milestones{/number}","notifications_url":"https://api.github.com/repos/syncthing/syncthing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syncthing/syncthing/labels{/name}","releases_url":"https://api.github.com/repos/syncthing/syncthing/releases{/id}","deployments_url":"https://api.github.com/repos/syncthing/syncthing/deployments","created_at":"2013-11-26T09:48:21Z","updated_at":"2016-02-03T05:30:49Z","pushed_at":"2016-02-02T14:44:07Z","git_url":"git://github.com/syncthing/syncthing.git","ssh_url":"git@github.com:syncthing/syncthing.git","clone_url":"https://github.com/syncthing/syncthing.git","svn_url":"https://github.com/syncthing/syncthing","homepage":"http://forum.syncthing.net/","size":90442,"stargazers_count":11164,"watchers_count":11164,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":836,"mirror_url":null,"open_issues_count":180,"forks":836,"open_issues":180,"watchers":11164,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/2252"},"html":{"href":"https://github.com/syncthing/syncthing/pull/2252"},"issue":{"href":"https://api.github.com/repos/syncthing/syncthing/issues/2252"},"comments":{"href":"https://api.github.com/repos/syncthing/syncthing/issues/2252/comments"},"review_comments":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/2252/comments"},"review_comment":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/2252/commits"},"statuses":{"href":"https://api.github.com/repos/syncthing/syncthing/statuses/baf7b4f2922b8c178371969693941d4440765cb8"}}}}