{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/clj-i18n/issues/14","repository_url":"https://api.github.com/repos/puppetlabs/clj-i18n","labels_url":"https://api.github.com/repos/puppetlabs/clj-i18n/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/clj-i18n/issues/14/comments","events_url":"https://api.github.com/repos/puppetlabs/clj-i18n/issues/14/events","html_url":"https://github.com/puppetlabs/clj-i18n/pull/14","id":151209039,"number":14,"title":"i18n makefiles and message bundles should be compile-time artifacts","user":{"login":"senior","id":215910,"avatar_url":"https://avatars.githubusercontent.com/u/215910?v=3","gravatar_id":"","url":"https://api.github.com/users/senior","html_url":"https://github.com/senior","followers_url":"https://api.github.com/users/senior/followers","following_url":"https://api.github.com/users/senior/following{/other_user}","gists_url":"https://api.github.com/users/senior/gists{/gist_id}","starred_url":"https://api.github.com/users/senior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senior/subscriptions","organizations_url":"https://api.github.com/users/senior/orgs","repos_url":"https://api.github.com/users/senior/repos","events_url":"https://api.github.com/users/senior/events{/privacy}","received_events_url":"https://api.github.com/users/senior/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/puppetlabs/clj-i18n/labels/WIP%20(do%20not%20merge)","name":"WIP (do not merge)","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-04-26T18:40:18Z","updated_at":"2016-06-08T23:46:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/clj-i18n/pulls/14","html_url":"https://github.com/puppetlabs/clj-i18n/pull/14","diff_url":"https://github.com/puppetlabs/clj-i18n/pull/14.diff","patch_url":"https://github.com/puppetlabs/clj-i18n/pull/14.patch"},"body":"This PR is intended to start conversation around how this plugin currently works. This patch is against an older version of the codebase (before https://github.com/puppetlabs/clj-i18n/pull/13) . @ajroetker started the patch a couple of weeks ago and I finished it off yesterday. It conflicts pretty bad with that change in PR-13 and before I reworked the patch to accomodate those changes, it seemed like a good time to stop and ask if it's the direction we want to go in for this library.\r\n\r\nIn talking with @mruzicka, he was under the impression the translators would be working with the Makefiles directly and they wouldn't expect to use Leiningen. This PR would require that. It treats the Makefiles (and message bundles) as and internal detail of the plugin. The Makefile is copied into the target directory (configurable via Lein's :target-path) at compile time and the message bundles are generated and placed into the target/classes directory (configurable via Lein's :compile-path). I also refactored the logic in the i18n plugin into a separate namespace so that it could be invoked from lein before running the tests. This eliminates the need for invoking make out of band before running the tests (currently required)."},"comment":{"url":"https://api.github.com/repos/puppetlabs/clj-i18n/issues/comments/224764470","html_url":"https://github.com/puppetlabs/clj-i18n/pull/14#issuecomment-224764470","issue_url":"https://api.github.com/repos/puppetlabs/clj-i18n/issues/14","id":224764470,"user":{"login":"senior","id":215910,"avatar_url":"https://avatars.githubusercontent.com/u/215910?v=3","gravatar_id":"","url":"https://api.github.com/users/senior","html_url":"https://github.com/senior","followers_url":"https://api.github.com/users/senior/followers","following_url":"https://api.github.com/users/senior/following{/other_user}","gists_url":"https://api.github.com/users/senior/gists{/gist_id}","starred_url":"https://api.github.com/users/senior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/senior/subscriptions","organizations_url":"https://api.github.com/users/senior/orgs","repos_url":"https://api.github.com/users/senior/repos","events_url":"https://api.github.com/users/senior/events{/privacy}","received_events_url":"https://api.github.com/users/senior/received_events","type":"User","site_admin":false},"created_at":"2016-06-08T23:46:00Z","updated_at":"2016-06-08T23:46:00Z","body":"\r\n> 1. Does this PR stand on its own? Can we update it, pull it, and then address using lein over make in a ticket, so that we can focus the discussion a bit?\r\n\r\nWe could spend the time needed to get the PR rebased, but I think the question in my mind is what's the most efficient use of our time. I submitted the PR as-is because @ajroetker and I put a decent amount of time into already and wasn't sure this was a change that we wanted. Rather than pour more time into it, I figured I'd start the conversation.  If we had to wait a month before we were able to get a pure lein version of this plugin, would that be ok? Since this stuff isn't going to be used until January+, seems like we have some timing flexibilty\r\n\r\n> 2. Is updating this PR so complex now that it's not worth it unless other things are decided? If yes, what are those things?\r\n\r\nIf we wanted to go with lein, seems like there's more value in working on that than rebasing this. There's not just the ~3 hours to rework/merge with what's there. Each project will have to update the dep, remove their Makefile, change gitignore etc. I'm not sure if those users would have to make similar adjustments once a lein solution is in place.  @ajroetker any rough ideas on effort for writing a lein plugin to do this?\r\n\r\n> 3. Is startup time an issue? I couldn't tell from the comments above. It seems @ajroetker implies it's not. I frankly, don't know.\r\n\r\n@ajroetker and I don't have as much background on the users of this and the key factors going into the Makefile decision. I agree with AJ though, startup time isn't a big deal for me.\r\n\r\n> 4. There's a conversation around .pot files, and how translators most likely won't be dealing with anything but a .po file already in transifex. So whether it's lein or make - seems a non-issue, unless I'm misunderstanding. I will make sure to verify this.\r\n\r\nIf we can agree on this, sounds like we can have the make/lein discussion focusing just on devs and tech."}}
{"actor":{"display_login":"senior"}}