{"action":"created","comment":{"url":"https://api.github.com/repos/vega/vega-editor/pulls/comments/68874184","id":68874184,"diff_hunk":"@@ -300,6 +301,7 @@ ved.cql.init = function(data) {\n   ved.cql.schema = new cql.schema.Schema(fieldSchemas);\n   var summary = vg.util.summary(data);\n   ved.cql.stats = new cql.stats.Stats(summary);\n+  ved.cql.views = new d3.map();","path":"app/editor.js","position":14,"original_position":14,"commit_id":"2fcbdef7127808590e68ada7fdb5264768a11d61","original_commit_id":"2fcbdef7127808590e68ada7fdb5264768a11d61","user":{"login":"kanitw","id":111269,"avatar_url":"https://avatars.githubusercontent.com/u/111269?v=3","gravatar_id":"","url":"https://api.github.com/users/kanitw","html_url":"https://github.com/kanitw","followers_url":"https://api.github.com/users/kanitw/followers","following_url":"https://api.github.com/users/kanitw/following{/other_user}","gists_url":"https://api.github.com/users/kanitw/gists{/gist_id}","starred_url":"https://api.github.com/users/kanitw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanitw/subscriptions","organizations_url":"https://api.github.com/users/kanitw/orgs","repos_url":"https://api.github.com/users/kanitw/repos","events_url":"https://api.github.com/users/kanitw/events{/privacy}","received_events_url":"https://api.github.com/users/kanitw/received_events","type":"User","site_admin":false},"body":"just use object -- we don't use `d3.map` anywhere else so it's better to be consistent.  ","created_at":"2016-06-29T01:52:31Z","updated_at":"2016-06-29T01:52:31Z","html_url":"https://github.com/vega/vega-editor/pull/62#discussion_r68874184","pull_request_url":"https://api.github.com/repos/vega/vega-editor/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/vega/vega-editor/pulls/comments/68874184"},"html":{"href":"https://github.com/vega/vega-editor/pull/62#discussion_r68874184"},"pull_request":{"href":"https://api.github.com/repos/vega/vega-editor/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/vega/vega-editor/pulls/62","id":75573396,"html_url":"https://github.com/vega/vega-editor/pull/62","diff_url":"https://github.com/vega/vega-editor/pull/62.diff","patch_url":"https://github.com/vega/vega-editor/pull/62.patch","issue_url":"https://api.github.com/repos/vega/vega-editor/issues/62","number":62,"state":"open","locked":false,"title":"Unregister signals for unused views (for better performance)","user":{"login":"ZeningQu","id":822034,"avatar_url":"https://avatars.githubusercontent.com/u/822034?v=3","gravatar_id":"","url":"https://api.github.com/users/ZeningQu","html_url":"https://github.com/ZeningQu","followers_url":"https://api.github.com/users/ZeningQu/followers","following_url":"https://api.github.com/users/ZeningQu/following{/other_user}","gists_url":"https://api.github.com/users/ZeningQu/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeningQu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeningQu/subscriptions","organizations_url":"https://api.github.com/users/ZeningQu/orgs","repos_url":"https://api.github.com/users/ZeningQu/repos","events_url":"https://api.github.com/users/ZeningQu/events{/privacy}","received_events_url":"https://api.github.com/users/ZeningQu/received_events","type":"User","site_admin":false},"body":"`ved.cql.views` is a `map`, where the `key` is the `id` for each view (e.g., `vis-0-0-0-2-0`) and the `value` is the `view` object.\r\n\r\nI noticed that the view `id` is being re-used, which makes it less ideal for `key`. What's a better key for each view? Do views have globally unique names?","created_at":"2016-06-29T00:50:44Z","updated_at":"2016-06-29T01:52:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5eb7cf246b54a05dd69195de02fc2e05170bf8e2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vega/vega-editor/pulls/62/commits","review_comments_url":"https://api.github.com/repos/vega/vega-editor/pulls/62/comments","review_comment_url":"https://api.github.com/repos/vega/vega-editor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vega/vega-editor/issues/62/comments","statuses_url":"https://api.github.com/repos/vega/vega-editor/statuses/2fcbdef7127808590e68ada7fdb5264768a11d61","head":{"label":"vega:zqu/destroyview","ref":"zqu/destroyview","sha":"2fcbdef7127808590e68ada7fdb5264768a11d61","user":{"login":"vega","id":11796929,"avatar_url":"https://avatars.githubusercontent.com/u/11796929?v=3","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":38760297,"name":"vega-editor","full_name":"vega/vega-editor","owner":{"login":"vega","id":11796929,"avatar_url":"https://avatars.githubusercontent.com/u/11796929?v=3","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/vega-editor","description":"Web-based Vega and Vega-Lite authoring environment.","fork":false,"url":"https://api.github.com/repos/vega/vega-editor","forks_url":"https://api.github.com/repos/vega/vega-editor/forks","keys_url":"https://api.github.com/repos/vega/vega-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/vega-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/vega-editor/teams","hooks_url":"https://api.github.com/repos/vega/vega-editor/hooks","issue_events_url":"https://api.github.com/repos/vega/vega-editor/issues/events{/number}","events_url":"https://api.github.com/repos/vega/vega-editor/events","assignees_url":"https://api.github.com/repos/vega/vega-editor/assignees{/user}","branches_url":"https://api.github.com/repos/vega/vega-editor/branches{/branch}","tags_url":"https://api.github.com/repos/vega/vega-editor/tags","blobs_url":"https://api.github.com/repos/vega/vega-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/vega-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/vega-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/vega-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/vega-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/vega-editor/languages","stargazers_url":"https://api.github.com/repos/vega/vega-editor/stargazers","contributors_url":"https://api.github.com/repos/vega/vega-editor/contributors","subscribers_url":"https://api.github.com/repos/vega/vega-editor/subscribers","subscription_url":"https://api.github.com/repos/vega/vega-editor/subscription","commits_url":"https://api.github.com/repos/vega/vega-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/vega-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/vega-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/vega-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/vega-editor/contents/{+path}","compare_url":"https://api.github.com/repos/vega/vega-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/vega-editor/merges","archive_url":"https://api.github.com/repos/vega/vega-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/vega-editor/downloads","issues_url":"https://api.github.com/repos/vega/vega-editor/issues{/number}","pulls_url":"https://api.github.com/repos/vega/vega-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/vega-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/vega-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/vega-editor/labels{/name}","releases_url":"https://api.github.com/repos/vega/vega-editor/releases{/id}","deployments_url":"https://api.github.com/repos/vega/vega-editor/deployments","created_at":"2015-07-08T14:45:42Z","updated_at":"2016-03-28T21:32:39Z","pushed_at":"2016-06-29T00:50:44Z","git_url":"git://github.com/vega/vega-editor.git","ssh_url":"git@github.com:vega/vega-editor.git","clone_url":"https://github.com/vega/vega-editor.git","svn_url":"https://github.com/vega/vega-editor","homepage":"http://vega.github.io/vega-editor","size":8394,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":12,"forks":9,"open_issues":12,"watchers":19,"default_branch":"master"}},"base":{"label":"vega:compassql","ref":"compassql","sha":"8a04eaec939bd09951efa0164443464e2401baf5","user":{"login":"vega","id":11796929,"avatar_url":"https://avatars.githubusercontent.com/u/11796929?v=3","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":38760297,"name":"vega-editor","full_name":"vega/vega-editor","owner":{"login":"vega","id":11796929,"avatar_url":"https://avatars.githubusercontent.com/u/11796929?v=3","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/vega-editor","description":"Web-based Vega and Vega-Lite authoring environment.","fork":false,"url":"https://api.github.com/repos/vega/vega-editor","forks_url":"https://api.github.com/repos/vega/vega-editor/forks","keys_url":"https://api.github.com/repos/vega/vega-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/vega-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/vega-editor/teams","hooks_url":"https://api.github.com/repos/vega/vega-editor/hooks","issue_events_url":"https://api.github.com/repos/vega/vega-editor/issues/events{/number}","events_url":"https://api.github.com/repos/vega/vega-editor/events","assignees_url":"https://api.github.com/repos/vega/vega-editor/assignees{/user}","branches_url":"https://api.github.com/repos/vega/vega-editor/branches{/branch}","tags_url":"https://api.github.com/repos/vega/vega-editor/tags","blobs_url":"https://api.github.com/repos/vega/vega-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/vega-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/vega-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/vega-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/vega-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/vega-editor/languages","stargazers_url":"https://api.github.com/repos/vega/vega-editor/stargazers","contributors_url":"https://api.github.com/repos/vega/vega-editor/contributors","subscribers_url":"https://api.github.com/repos/vega/vega-editor/subscribers","subscription_url":"https://api.github.com/repos/vega/vega-editor/subscription","commits_url":"https://api.github.com/repos/vega/vega-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/vega-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/vega-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/vega-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/vega-editor/contents/{+path}","compare_url":"https://api.github.com/repos/vega/vega-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/vega-editor/merges","archive_url":"https://api.github.com/repos/vega/vega-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/vega-editor/downloads","issues_url":"https://api.github.com/repos/vega/vega-editor/issues{/number}","pulls_url":"https://api.github.com/repos/vega/vega-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/vega-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/vega-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/vega-editor/labels{/name}","releases_url":"https://api.github.com/repos/vega/vega-editor/releases{/id}","deployments_url":"https://api.github.com/repos/vega/vega-editor/deployments","created_at":"2015-07-08T14:45:42Z","updated_at":"2016-03-28T21:32:39Z","pushed_at":"2016-06-29T00:50:44Z","git_url":"git://github.com/vega/vega-editor.git","ssh_url":"git@github.com:vega/vega-editor.git","clone_url":"https://github.com/vega/vega-editor.git","svn_url":"https://github.com/vega/vega-editor","homepage":"http://vega.github.io/vega-editor","size":8394,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":12,"forks":9,"open_issues":12,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vega/vega-editor/pulls/62"},"html":{"href":"https://github.com/vega/vega-editor/pull/62"},"issue":{"href":"https://api.github.com/repos/vega/vega-editor/issues/62"},"comments":{"href":"https://api.github.com/repos/vega/vega-editor/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/vega/vega-editor/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/vega/vega-editor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vega/vega-editor/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/vega/vega-editor/statuses/2fcbdef7127808590e68ada7fdb5264768a11d61"}}}}
{"actor":{"display_login":"kanitw"}}