{"action":"created","issue":{"url":"https://api.github.com/repos/unexpectedjs/unexpected/issues/321","repository_url":"https://api.github.com/repos/unexpectedjs/unexpected","labels_url":"https://api.github.com/repos/unexpectedjs/unexpected/issues/321/labels{/name}","comments_url":"https://api.github.com/repos/unexpectedjs/unexpected/issues/321/comments","events_url":"https://api.github.com/repos/unexpectedjs/unexpected/issues/321/events","html_url":"https://github.com/unexpectedjs/unexpected/pull/321","id":165680670,"number":321,"title":"Allow assertions to succeed without settling all promises","user":{"login":"papandreou","id":373545,"avatar_url":"https://avatars.githubusercontent.com/u/373545?v=3","gravatar_id":"","url":"https://api.github.com/users/papandreou","html_url":"https://github.com/papandreou","followers_url":"https://api.github.com/users/papandreou/followers","following_url":"https://api.github.com/users/papandreou/following{/other_user}","gists_url":"https://api.github.com/users/papandreou/gists{/gist_id}","starred_url":"https://api.github.com/users/papandreou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papandreou/subscriptions","organizations_url":"https://api.github.com/users/papandreou/orgs","repos_url":"https://api.github.com/users/papandreou/repos","events_url":"https://api.github.com/users/papandreou/events{/privacy}","received_events_url":"https://api.github.com/users/papandreou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-14T23:23:38Z","updated_at":"2016-07-15T05:24:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/unexpectedjs/unexpected/pulls/321","html_url":"https://github.com/unexpectedjs/unexpected/pull/321","diff_url":"https://github.com/unexpectedjs/unexpected/pull/321.diff","patch_url":"https://github.com/unexpectedjs/unexpected/pull/321.patch"},"body":"In other words, disable the afterEach-based footgun protection for all but the top level expect.\r\n\r\nWe've run into a case in unexpected-mitm where we need to fail the assertion due to the wrong HTTP request being made, but in that case we cannot guarantee that the delegated-to assertion is ever settled.\r\n\r\nRelaxing the footgun protection fixes that, and will in general allow assertions a greater degree of freedom, while still protecting the end user from forgetting a `return`."},"comment":{"url":"https://api.github.com/repos/unexpectedjs/unexpected/issues/comments/232862515","html_url":"https://github.com/unexpectedjs/unexpected/pull/321#issuecomment-232862515","issue_url":"https://api.github.com/repos/unexpectedjs/unexpected/issues/321","id":232862515,"user":{"login":"sunesimonsen","id":90802,"avatar_url":"https://avatars.githubusercontent.com/u/90802?v=3","gravatar_id":"","url":"https://api.github.com/users/sunesimonsen","html_url":"https://github.com/sunesimonsen","followers_url":"https://api.github.com/users/sunesimonsen/followers","following_url":"https://api.github.com/users/sunesimonsen/following{/other_user}","gists_url":"https://api.github.com/users/sunesimonsen/gists{/gist_id}","starred_url":"https://api.github.com/users/sunesimonsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunesimonsen/subscriptions","organizations_url":"https://api.github.com/users/sunesimonsen/orgs","repos_url":"https://api.github.com/users/sunesimonsen/repos","events_url":"https://api.github.com/users/sunesimonsen/events{/privacy}","received_events_url":"https://api.github.com/users/sunesimonsen/received_events","type":"User","site_admin":false},"created_at":"2016-07-15T05:24:59Z","updated_at":"2016-07-15T05:24:59Z","body":"I'm okay with this, as you and @alexjeffburke is the main driving force behind the promise protection. This will of cause put a bit more responsibility on the plugin developers, but I think that is okay.\r\n\r\n👍 "}}
{"actor":{"display_login":"sunesimonsen"}}