{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/deck/pulls/comments/94074953","pull_request_review_id":14605527,"id":94074953,"diff_hunk":"@@ -0,0 +1,207 @@\n+import {module} from 'angular';\n+\n+import {IJob} from 'core/application/service/application.write.service';\n+import {ITask} from 'core/task/task.read.service';\n+import {ServerGroup, ISecurityGroup} from 'core/domain';\n+import {TASK_EXECUTOR, TaskExecutor} from 'core/task/taskExecutor';\n+\n+interface IServerGroupCommandApplication {\n+  name: string;\n+}\n+\n+interface ISource {\n+  asgName: string;\n+}\n+\n+interface IViewState {\n+  mode: string;\n+}\n+\n+interface IServerGroupTaskApplicationTask {\n+  refresh?: () => void;\n+}\n+\n+interface ICapacity {\n+  desired: number;\n+  max: number;\n+  min: number;\n+}\n+\n+export interface IServerGroupCommand {\n+  application: IServerGroupCommandApplication;\n+  freeFormDetails?: string;\n+  source?: ISource;\n+  stack?: string;\n+  type?: string;\n+  viewState: IViewState;\n+}\n+\n+export interface IServerGroupTaskApplication {\n+  name: string;\n+  tasks?: IServerGroupTaskApplicationTask;\n+}\n+\n+export interface IServerGroupJob extends IJob {\n+  amiName?: string;\n+  asgName?: string;\n+  capacity?: ICapacity;\n+  credentials?: string;\n+  cloudProvider?: string;\n+  region?: string;\n+  securityGroups?: string[];\n+  serverGroupName?: string;\n+}\n+\n+export class ServerGroupWriterService {\n+\n+  static get $inject(): string[] {\n+    return ['taskExecutor', 'serverGroupTransformer'];\n+  }\n+\n+  constructor(private executor: TaskExecutor, private transformer: any) {}\n+\n+  public cloneServerGroup(command: IServerGroupCommand,\n+                          application: IServerGroupTaskApplication): ng.IPromise<ITask> {","path":"app/scripts/modules/core/serverGroup/serverGroupWriter.service.ts","position":64,"original_position":64,"commit_id":"f4c78d18c5498d52c6a949322f7f239791781715","original_commit_id":"f4c78d18c5498d52c6a949322f7f239791781715","user":{"login":"anotherchrisberry","id":73450,"avatar_url":"https://avatars.githubusercontent.com/u/73450?v=3","gravatar_id":"","url":"https://api.github.com/users/anotherchrisberry","html_url":"https://github.com/anotherchrisberry","followers_url":"https://api.github.com/users/anotherchrisberry/followers","following_url":"https://api.github.com/users/anotherchrisberry/following{/other_user}","gists_url":"https://api.github.com/users/anotherchrisberry/gists{/gist_id}","starred_url":"https://api.github.com/users/anotherchrisberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anotherchrisberry/subscriptions","organizations_url":"https://api.github.com/users/anotherchrisberry/orgs","repos_url":"https://api.github.com/users/anotherchrisberry/repos","events_url":"https://api.github.com/users/anotherchrisberry/events{/privacy}","received_events_url":"https://api.github.com/users/anotherchrisberry/received_events","type":"User","site_admin":false},"body":"Can this just be an `Application`?","created_at":"2016-12-28T20:36:52Z","updated_at":"2016-12-28T20:36:52Z","html_url":"https://github.com/spinnaker/deck/pull/3121#discussion_r94074953","pull_request_url":"https://api.github.com/repos/spinnaker/deck/pulls/3121","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/comments/94074953"},"html":{"href":"https://github.com/spinnaker/deck/pull/3121#discussion_r94074953"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/3121"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/deck/pulls/3121","id":99307756,"html_url":"https://github.com/spinnaker/deck/pull/3121","diff_url":"https://github.com/spinnaker/deck/pull/3121.diff","patch_url":"https://github.com/spinnaker/deck/pull/3121.patch","issue_url":"https://api.github.com/repos/spinnaker/deck/issues/3121","number":3121,"state":"open","locked":false,"title":"(core): convert sg read/write svc to TS","user":{"login":"icfantv","id":370054,"avatar_url":"https://avatars.githubusercontent.com/u/370054?v=3","gravatar_id":"","url":"https://api.github.com/users/icfantv","html_url":"https://github.com/icfantv","followers_url":"https://api.github.com/users/icfantv/followers","following_url":"https://api.github.com/users/icfantv/following{/other_user}","gists_url":"https://api.github.com/users/icfantv/gists{/gist_id}","starred_url":"https://api.github.com/users/icfantv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icfantv/subscriptions","organizations_url":"https://api.github.com/users/icfantv/orgs","repos_url":"https://api.github.com/users/icfantv/repos","events_url":"https://api.github.com/users/icfantv/events{/privacy}","received_events_url":"https://api.github.com/users/icfantv/received_events","type":"User","site_admin":false},"body":"* convert server group reader service to TS\r\n* convert server group writer service to TS\r\n* update references and injection points","created_at":"2016-12-24T17:20:13Z","updated_at":"2016-12-28T20:36:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0412c9f9c3d7dcf60901d3082213a407cb069583","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/deck/pulls/3121/commits","review_comments_url":"https://api.github.com/repos/spinnaker/deck/pulls/3121/comments","review_comment_url":"https://api.github.com/repos/spinnaker/deck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/deck/issues/3121/comments","statuses_url":"https://api.github.com/repos/spinnaker/deck/statuses/f4c78d18c5498d52c6a949322f7f239791781715","head":{"label":"icfantv:servergroup_conversion","ref":"servergroup_conversion","sha":"f4c78d18c5498d52c6a949322f7f239791781715","user":{"login":"icfantv","id":370054,"avatar_url":"https://avatars.githubusercontent.com/u/370054?v=3","gravatar_id":"","url":"https://api.github.com/users/icfantv","html_url":"https://github.com/icfantv","followers_url":"https://api.github.com/users/icfantv/followers","following_url":"https://api.github.com/users/icfantv/following{/other_user}","gists_url":"https://api.github.com/users/icfantv/gists{/gist_id}","starred_url":"https://api.github.com/users/icfantv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icfantv/subscriptions","organizations_url":"https://api.github.com/users/icfantv/orgs","repos_url":"https://api.github.com/users/icfantv/repos","events_url":"https://api.github.com/users/icfantv/events{/privacy}","received_events_url":"https://api.github.com/users/icfantv/received_events","type":"User","site_admin":false},"repo":{"id":65839353,"name":"deck","full_name":"icfantv/deck","owner":{"login":"icfantv","id":370054,"avatar_url":"https://avatars.githubusercontent.com/u/370054?v=3","gravatar_id":"","url":"https://api.github.com/users/icfantv","html_url":"https://github.com/icfantv","followers_url":"https://api.github.com/users/icfantv/followers","following_url":"https://api.github.com/users/icfantv/following{/other_user}","gists_url":"https://api.github.com/users/icfantv/gists{/gist_id}","starred_url":"https://api.github.com/users/icfantv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icfantv/subscriptions","organizations_url":"https://api.github.com/users/icfantv/orgs","repos_url":"https://api.github.com/users/icfantv/repos","events_url":"https://api.github.com/users/icfantv/events{/privacy}","received_events_url":"https://api.github.com/users/icfantv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/icfantv/deck","description":"Management UI for Spinnaker","fork":true,"url":"https://api.github.com/repos/icfantv/deck","forks_url":"https://api.github.com/repos/icfantv/deck/forks","keys_url":"https://api.github.com/repos/icfantv/deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/icfantv/deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/icfantv/deck/teams","hooks_url":"https://api.github.com/repos/icfantv/deck/hooks","issue_events_url":"https://api.github.com/repos/icfantv/deck/issues/events{/number}","events_url":"https://api.github.com/repos/icfantv/deck/events","assignees_url":"https://api.github.com/repos/icfantv/deck/assignees{/user}","branches_url":"https://api.github.com/repos/icfantv/deck/branches{/branch}","tags_url":"https://api.github.com/repos/icfantv/deck/tags","blobs_url":"https://api.github.com/repos/icfantv/deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/icfantv/deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/icfantv/deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/icfantv/deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/icfantv/deck/statuses/{sha}","languages_url":"https://api.github.com/repos/icfantv/deck/languages","stargazers_url":"https://api.github.com/repos/icfantv/deck/stargazers","contributors_url":"https://api.github.com/repos/icfantv/deck/contributors","subscribers_url":"https://api.github.com/repos/icfantv/deck/subscribers","subscription_url":"https://api.github.com/repos/icfantv/deck/subscription","commits_url":"https://api.github.com/repos/icfantv/deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/icfantv/deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/icfantv/deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/icfantv/deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/icfantv/deck/contents/{+path}","compare_url":"https://api.github.com/repos/icfantv/deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/icfantv/deck/merges","archive_url":"https://api.github.com/repos/icfantv/deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/icfantv/deck/downloads","issues_url":"https://api.github.com/repos/icfantv/deck/issues{/number}","pulls_url":"https://api.github.com/repos/icfantv/deck/pulls{/number}","milestones_url":"https://api.github.com/repos/icfantv/deck/milestones{/number}","notifications_url":"https://api.github.com/repos/icfantv/deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/icfantv/deck/labels{/name}","releases_url":"https://api.github.com/repos/icfantv/deck/releases{/id}","deployments_url":"https://api.github.com/repos/icfantv/deck/deployments","created_at":"2016-08-16T17:20:24Z","updated_at":"2016-08-16T17:20:30Z","pushed_at":"2016-12-25T15:28:20Z","git_url":"git://github.com/icfantv/deck.git","ssh_url":"git@github.com:icfantv/deck.git","clone_url":"https://github.com/icfantv/deck.git","svn_url":"https://github.com/icfantv/deck","homepage":"","size":21881,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"4ddbd573d8362e481137295c2c07fcedc86ea4ad","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":21953642,"name":"deck","full_name":"spinnaker/deck","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/deck","description":"Management UI for Spinnaker","fork":false,"url":"https://api.github.com/repos/spinnaker/deck","forks_url":"https://api.github.com/repos/spinnaker/deck/forks","keys_url":"https://api.github.com/repos/spinnaker/deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/deck/teams","hooks_url":"https://api.github.com/repos/spinnaker/deck/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/deck/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/deck/events","assignees_url":"https://api.github.com/repos/spinnaker/deck/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/deck/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/deck/tags","blobs_url":"https://api.github.com/repos/spinnaker/deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/deck/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/deck/languages","stargazers_url":"https://api.github.com/repos/spinnaker/deck/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/deck/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/deck/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/deck/subscription","commits_url":"https://api.github.com/repos/spinnaker/deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/deck/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/deck/merges","archive_url":"https://api.github.com/repos/spinnaker/deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/deck/downloads","issues_url":"https://api.github.com/repos/spinnaker/deck/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/deck/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/deck/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/deck/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/deck/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/deck/deployments","created_at":"2014-07-17T18:51:00Z","updated_at":"2016-12-09T01:57:51Z","pushed_at":"2016-12-28T16:53:23Z","git_url":"git://github.com/spinnaker/deck.git","ssh_url":"git@github.com:spinnaker/deck.git","clone_url":"https://github.com/spinnaker/deck.git","svn_url":"https://github.com/spinnaker/deck","homepage":"","size":21829,"stargazers_count":71,"watchers_count":71,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"open_issues_count":9,"forks":103,"open_issues":9,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/3121"},"html":{"href":"https://github.com/spinnaker/deck/pull/3121"},"issue":{"href":"https://api.github.com/repos/spinnaker/deck/issues/3121"},"comments":{"href":"https://api.github.com/repos/spinnaker/deck/issues/3121/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/3121/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/3121/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/deck/statuses/f4c78d18c5498d52c6a949322f7f239791781715"}}}}
{"actor":{"display_login":"anotherchrisberry"}}