{"action":"created","comment":{"url":"https://api.github.com/repos/pentaho/mondrian/pulls/comments/56321945","id":56321945,"diff_hunk":"@@ -92,16 +128,28 @@ public static void addContextConstraint(\n             // request is impossible to satisfy.\n             return;\n         }\n+\n         if (disjointSlicerTuples) {\n+            slicerTupleList.add(slicerTuples);\n+        }\n+\n+        if (!disjointSlicerTuples && slicerTupleList.size() > 0) {\n+            disjointSlicerTuples = true;","path":"src/main/mondrian/rolap/SqlConstraintUtils.java","position":92,"original_position":92,"commit_id":"79ebf5e668ae22ae1f5b8324c162c9487e102cc9","original_commit_id":"79ebf5e668ae22ae1f5b8324c162c9487e102cc9","user":{"login":"mchen-len-son","id":17137219,"avatar_url":"https://avatars.githubusercontent.com/u/17137219?v=3","gravatar_id":"","url":"https://api.github.com/users/mchen-len-son","html_url":"https://github.com/mchen-len-son","followers_url":"https://api.github.com/users/mchen-len-son/followers","following_url":"https://api.github.com/users/mchen-len-son/following{/other_user}","gists_url":"https://api.github.com/users/mchen-len-son/gists{/gist_id}","starred_url":"https://api.github.com/users/mchen-len-son/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchen-len-son/subscriptions","organizations_url":"https://api.github.com/users/mchen-len-son/orgs","repos_url":"https://api.github.com/users/mchen-len-son/repos","events_url":"https://api.github.com/users/mchen-len-son/events{/privacy}","received_events_url":"https://api.github.com/users/mchen-len-son/received_events","type":"User","site_admin":false},"body":"this disjointSlicerTuples value is never used further","created_at":"2016-03-16T12:05:12Z","updated_at":"2016-03-16T12:05:12Z","html_url":"https://github.com/pentaho/mondrian/pull/672#discussion_r56321945","pull_request_url":"https://api.github.com/repos/pentaho/mondrian/pulls/672","_links":{"self":{"href":"https://api.github.com/repos/pentaho/mondrian/pulls/comments/56321945"},"html":{"href":"https://github.com/pentaho/mondrian/pull/672#discussion_r56321945"},"pull_request":{"href":"https://api.github.com/repos/pentaho/mondrian/pulls/672"}}},"pull_request":{"url":"https://api.github.com/repos/pentaho/mondrian/pulls/672","id":62878750,"html_url":"https://github.com/pentaho/mondrian/pull/672","diff_url":"https://github.com/pentaho/mondrian/pull/672.diff","patch_url":"https://github.com/pentaho/mondrian/pull/672.patch","issue_url":"https://api.github.com/repos/pentaho/mondrian/issues/672","number":672,"state":"open","locked":false,"title":"[MONDRIAN-2441] fixed calculated member set issue for multicolumn result","user":{"login":"andrey-markelov","id":9196179,"avatar_url":"https://avatars.githubusercontent.com/u/9196179?v=3","gravatar_id":"","url":"https://api.github.com/users/andrey-markelov","html_url":"https://github.com/andrey-markelov","followers_url":"https://api.github.com/users/andrey-markelov/followers","following_url":"https://api.github.com/users/andrey-markelov/following{/other_user}","gists_url":"https://api.github.com/users/andrey-markelov/gists{/gist_id}","starred_url":"https://api.github.com/users/andrey-markelov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrey-markelov/subscriptions","organizations_url":"https://api.github.com/users/andrey-markelov/orgs","repos_url":"https://api.github.com/users/andrey-markelov/repos","events_url":"https://api.github.com/users/andrey-markelov/events{/privacy}","received_events_url":"https://api.github.com/users/andrey-markelov/received_events","type":"User","site_admin":false},"body":"@mkambol please review it","created_at":"2016-03-15T09:51:14Z","updated_at":"2016-03-16T12:05:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f5f35d6a0425c850e61075c35c183d1d6d7598b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pentaho/mondrian/pulls/672/commits","review_comments_url":"https://api.github.com/repos/pentaho/mondrian/pulls/672/comments","review_comment_url":"https://api.github.com/repos/pentaho/mondrian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pentaho/mondrian/issues/672/comments","statuses_url":"https://api.github.com/repos/pentaho/mondrian/statuses/79ebf5e668ae22ae1f5b8324c162c9487e102cc9","head":{"label":"andrey-markelov:MONDRIAN-2441","ref":"MONDRIAN-2441","sha":"79ebf5e668ae22ae1f5b8324c162c9487e102cc9","user":{"login":"andrey-markelov","id":9196179,"avatar_url":"https://avatars.githubusercontent.com/u/9196179?v=3","gravatar_id":"","url":"https://api.github.com/users/andrey-markelov","html_url":"https://github.com/andrey-markelov","followers_url":"https://api.github.com/users/andrey-markelov/followers","following_url":"https://api.github.com/users/andrey-markelov/following{/other_user}","gists_url":"https://api.github.com/users/andrey-markelov/gists{/gist_id}","starred_url":"https://api.github.com/users/andrey-markelov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrey-markelov/subscriptions","organizations_url":"https://api.github.com/users/andrey-markelov/orgs","repos_url":"https://api.github.com/users/andrey-markelov/repos","events_url":"https://api.github.com/users/andrey-markelov/events{/privacy}","received_events_url":"https://api.github.com/users/andrey-markelov/received_events","type":"User","site_admin":false},"repo":{"id":51921081,"name":"mondrian","full_name":"andrey-markelov/mondrian","owner":{"login":"andrey-markelov","id":9196179,"avatar_url":"https://avatars.githubusercontent.com/u/9196179?v=3","gravatar_id":"","url":"https://api.github.com/users/andrey-markelov","html_url":"https://github.com/andrey-markelov","followers_url":"https://api.github.com/users/andrey-markelov/followers","following_url":"https://api.github.com/users/andrey-markelov/following{/other_user}","gists_url":"https://api.github.com/users/andrey-markelov/gists{/gist_id}","starred_url":"https://api.github.com/users/andrey-markelov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrey-markelov/subscriptions","organizations_url":"https://api.github.com/users/andrey-markelov/orgs","repos_url":"https://api.github.com/users/andrey-markelov/repos","events_url":"https://api.github.com/users/andrey-markelov/events{/privacy}","received_events_url":"https://api.github.com/users/andrey-markelov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrey-markelov/mondrian","description":"Mondrian is an Online Analytical Processing (OLAP) server that enables business users to analyze large quantities of data in real-time.","fork":true,"url":"https://api.github.com/repos/andrey-markelov/mondrian","forks_url":"https://api.github.com/repos/andrey-markelov/mondrian/forks","keys_url":"https://api.github.com/repos/andrey-markelov/mondrian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrey-markelov/mondrian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrey-markelov/mondrian/teams","hooks_url":"https://api.github.com/repos/andrey-markelov/mondrian/hooks","issue_events_url":"https://api.github.com/repos/andrey-markelov/mondrian/issues/events{/number}","events_url":"https://api.github.com/repos/andrey-markelov/mondrian/events","assignees_url":"https://api.github.com/repos/andrey-markelov/mondrian/assignees{/user}","branches_url":"https://api.github.com/repos/andrey-markelov/mondrian/branches{/branch}","tags_url":"https://api.github.com/repos/andrey-markelov/mondrian/tags","blobs_url":"https://api.github.com/repos/andrey-markelov/mondrian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrey-markelov/mondrian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrey-markelov/mondrian/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrey-markelov/mondrian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrey-markelov/mondrian/statuses/{sha}","languages_url":"https://api.github.com/repos/andrey-markelov/mondrian/languages","stargazers_url":"https://api.github.com/repos/andrey-markelov/mondrian/stargazers","contributors_url":"https://api.github.com/repos/andrey-markelov/mondrian/contributors","subscribers_url":"https://api.github.com/repos/andrey-markelov/mondrian/subscribers","subscription_url":"https://api.github.com/repos/andrey-markelov/mondrian/subscription","commits_url":"https://api.github.com/repos/andrey-markelov/mondrian/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrey-markelov/mondrian/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrey-markelov/mondrian/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrey-markelov/mondrian/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrey-markelov/mondrian/contents/{+path}","compare_url":"https://api.github.com/repos/andrey-markelov/mondrian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrey-markelov/mondrian/merges","archive_url":"https://api.github.com/repos/andrey-markelov/mondrian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrey-markelov/mondrian/downloads","issues_url":"https://api.github.com/repos/andrey-markelov/mondrian/issues{/number}","pulls_url":"https://api.github.com/repos/andrey-markelov/mondrian/pulls{/number}","milestones_url":"https://api.github.com/repos/andrey-markelov/mondrian/milestones{/number}","notifications_url":"https://api.github.com/repos/andrey-markelov/mondrian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrey-markelov/mondrian/labels{/name}","releases_url":"https://api.github.com/repos/andrey-markelov/mondrian/releases{/id}","deployments_url":"https://api.github.com/repos/andrey-markelov/mondrian/deployments","created_at":"2016-02-17T12:30:07Z","updated_at":"2016-02-17T12:30:12Z","pushed_at":"2016-03-16T11:46:46Z","git_url":"git://github.com/andrey-markelov/mondrian.git","ssh_url":"git@github.com:andrey-markelov/mondrian.git","clone_url":"https://github.com/andrey-markelov/mondrian.git","svn_url":"https://github.com/andrey-markelov/mondrian","homepage":"http://mondrian.pentaho.com/","size":310808,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pentaho:master","ref":"master","sha":"cba2de79bd507dfa3e20a9f34ced8a97f394a6aa","user":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars.githubusercontent.com/u/1022787?v=3","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"repo":{"id":3766330,"name":"mondrian","full_name":"pentaho/mondrian","owner":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars.githubusercontent.com/u/1022787?v=3","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pentaho/mondrian","description":"Mondrian is an Online Analytical Processing (OLAP) server that enables business users to analyze large quantities of data in real-time.","fork":false,"url":"https://api.github.com/repos/pentaho/mondrian","forks_url":"https://api.github.com/repos/pentaho/mondrian/forks","keys_url":"https://api.github.com/repos/pentaho/mondrian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pentaho/mondrian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pentaho/mondrian/teams","hooks_url":"https://api.github.com/repos/pentaho/mondrian/hooks","issue_events_url":"https://api.github.com/repos/pentaho/mondrian/issues/events{/number}","events_url":"https://api.github.com/repos/pentaho/mondrian/events","assignees_url":"https://api.github.com/repos/pentaho/mondrian/assignees{/user}","branches_url":"https://api.github.com/repos/pentaho/mondrian/branches{/branch}","tags_url":"https://api.github.com/repos/pentaho/mondrian/tags","blobs_url":"https://api.github.com/repos/pentaho/mondrian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pentaho/mondrian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pentaho/mondrian/git/refs{/sha}","trees_url":"https://api.github.com/repos/pentaho/mondrian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pentaho/mondrian/statuses/{sha}","languages_url":"https://api.github.com/repos/pentaho/mondrian/languages","stargazers_url":"https://api.github.com/repos/pentaho/mondrian/stargazers","contributors_url":"https://api.github.com/repos/pentaho/mondrian/contributors","subscribers_url":"https://api.github.com/repos/pentaho/mondrian/subscribers","subscription_url":"https://api.github.com/repos/pentaho/mondrian/subscription","commits_url":"https://api.github.com/repos/pentaho/mondrian/commits{/sha}","git_commits_url":"https://api.github.com/repos/pentaho/mondrian/git/commits{/sha}","comments_url":"https://api.github.com/repos/pentaho/mondrian/comments{/number}","issue_comment_url":"https://api.github.com/repos/pentaho/mondrian/issues/comments{/number}","contents_url":"https://api.github.com/repos/pentaho/mondrian/contents/{+path}","compare_url":"https://api.github.com/repos/pentaho/mondrian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pentaho/mondrian/merges","archive_url":"https://api.github.com/repos/pentaho/mondrian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pentaho/mondrian/downloads","issues_url":"https://api.github.com/repos/pentaho/mondrian/issues{/number}","pulls_url":"https://api.github.com/repos/pentaho/mondrian/pulls{/number}","milestones_url":"https://api.github.com/repos/pentaho/mondrian/milestones{/number}","notifications_url":"https://api.github.com/repos/pentaho/mondrian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pentaho/mondrian/labels{/name}","releases_url":"https://api.github.com/repos/pentaho/mondrian/releases{/id}","deployments_url":"https://api.github.com/repos/pentaho/mondrian/deployments","created_at":"2012-03-19T17:03:39Z","updated_at":"2016-03-14T14:24:30Z","pushed_at":"2016-03-16T11:46:48Z","git_url":"git://github.com/pentaho/mondrian.git","ssh_url":"git@github.com:pentaho/mondrian.git","clone_url":"https://github.com/pentaho/mondrian.git","svn_url":"https://github.com/pentaho/mondrian","homepage":"http://mondrian.pentaho.com/","size":312173,"stargazers_count":350,"watchers_count":350,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":340,"mirror_url":null,"open_issues_count":90,"forks":340,"open_issues":90,"watchers":350,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pentaho/mondrian/pulls/672"},"html":{"href":"https://github.com/pentaho/mondrian/pull/672"},"issue":{"href":"https://api.github.com/repos/pentaho/mondrian/issues/672"},"comments":{"href":"https://api.github.com/repos/pentaho/mondrian/issues/672/comments"},"review_comments":{"href":"https://api.github.com/repos/pentaho/mondrian/pulls/672/comments"},"review_comment":{"href":"https://api.github.com/repos/pentaho/mondrian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pentaho/mondrian/pulls/672/commits"},"statuses":{"href":"https://api.github.com/repos/pentaho/mondrian/statuses/79ebf5e668ae22ae1f5b8324c162c9487e102cc9"}}}}