{"action":"created","comment":{"url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/pulls/comments/54815278","id":54815278,"diff_hunk":"@@ -343,7 +373,7 @@ def build_us_rate_request(packages, origin_zip, destination_zip, options = {})\n       #\n       # package.options[:mail_type] -- one of [:package, :postcard, :matter_for_the_blind, :envelope].\n       #                                 Defaults to :package.\n-      def build_world_rate_request(origin, packages, destination, options)\n+      def build_world_rate_request(origin, destination, packages, options)","path":"lib/active_shipping/shipping/carriers/usps.rb","position":116,"original_position":116,"commit_id":"2d1f5843a9a1d68a1e9689eeb0105e69d5126b90","original_commit_id":"2d1f5843a9a1d68a1e9689eeb0105e69d5126b90","user":{"login":"dkubb","id":133,"avatar_url":"https://avatars.githubusercontent.com/u/133?v=3","gravatar_id":"","url":"https://api.github.com/users/dkubb","html_url":"https://github.com/dkubb","followers_url":"https://api.github.com/users/dkubb/followers","following_url":"https://api.github.com/users/dkubb/following{/other_user}","gists_url":"https://api.github.com/users/dkubb/gists{/gist_id}","starred_url":"https://api.github.com/users/dkubb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkubb/subscriptions","organizations_url":"https://api.github.com/users/dkubb/orgs","repos_url":"https://api.github.com/users/dkubb/repos","events_url":"https://api.github.com/users/dkubb/events{/privacy}","received_events_url":"https://api.github.com/users/dkubb/received_events","type":"User","site_admin":false},"body":"> Thx for fixing that order\r\n\r\nI needed for it to be consistent so that I could simplify some conditional logic. By trying to minimize the size of the logic branch it lead naturally to this change.","created_at":"2016-03-03T00:02:28Z","updated_at":"2016-03-03T00:02:28Z","html_url":"https://github.com/MountainRoseHerbs/active_shipping/pull/3#discussion_r54815278","pull_request_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/pulls/comments/54815278"},"html":{"href":"https://github.com/MountainRoseHerbs/active_shipping/pull/3#discussion_r54815278"},"pull_request":{"href":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/pulls/3","id":61484125,"html_url":"https://github.com/MountainRoseHerbs/active_shipping/pull/3","diff_url":"https://github.com/MountainRoseHerbs/active_shipping/pull/3.diff","patch_url":"https://github.com/MountainRoseHerbs/active_shipping/pull/3.patch","issue_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/issues/3","number":3,"state":"open","locked":false,"title":"Add ActiveShipping:Shipping::USPS#build_rate_request","user":{"login":"dkubb","id":133,"avatar_url":"https://avatars.githubusercontent.com/u/133?v=3","gravatar_id":"","url":"https://api.github.com/users/dkubb","html_url":"https://github.com/dkubb","followers_url":"https://api.github.com/users/dkubb/followers","following_url":"https://api.github.com/users/dkubb/following{/other_user}","gists_url":"https://api.github.com/users/dkubb/gists{/gist_id}","starred_url":"https://api.github.com/users/dkubb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkubb/subscriptions","organizations_url":"https://api.github.com/users/dkubb/orgs","repos_url":"https://api.github.com/users/dkubb/repos","events_url":"https://api.github.com/users/dkubb/events{/privacy}","received_events_url":"https://api.github.com/users/dkubb/received_events","type":"User","site_admin":false},"body":"* Refactor common code from ActiveMerchant::Shipping::USPS","created_at":"2016-03-02T23:12:23Z","updated_at":"2016-03-03T00:02:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88bfadfeae719b9e7e85b2f710373e0e555af05b","assignee":{"login":"dkubb","id":133,"avatar_url":"https://avatars.githubusercontent.com/u/133?v=3","gravatar_id":"","url":"https://api.github.com/users/dkubb","html_url":"https://github.com/dkubb","followers_url":"https://api.github.com/users/dkubb/followers","following_url":"https://api.github.com/users/dkubb/following{/other_user}","gists_url":"https://api.github.com/users/dkubb/gists{/gist_id}","starred_url":"https://api.github.com/users/dkubb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkubb/subscriptions","organizations_url":"https://api.github.com/users/dkubb/orgs","repos_url":"https://api.github.com/users/dkubb/repos","events_url":"https://api.github.com/users/dkubb/events{/privacy}","received_events_url":"https://api.github.com/users/dkubb/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/pulls/3/commits","review_comments_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/pulls/3/comments","review_comment_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/issues/3/comments","statuses_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/statuses/2d1f5843a9a1d68a1e9689eeb0105e69d5126b90","head":{"label":"MountainRoseHerbs:feature/add-usps-build-rate-request","ref":"feature/add-usps-build-rate-request","sha":"2d1f5843a9a1d68a1e9689eeb0105e69d5126b90","user":{"login":"MountainRoseHerbs","id":2074141,"avatar_url":"https://avatars.githubusercontent.com/u/2074141?v=3","gravatar_id":"","url":"https://api.github.com/users/MountainRoseHerbs","html_url":"https://github.com/MountainRoseHerbs","followers_url":"https://api.github.com/users/MountainRoseHerbs/followers","following_url":"https://api.github.com/users/MountainRoseHerbs/following{/other_user}","gists_url":"https://api.github.com/users/MountainRoseHerbs/gists{/gist_id}","starred_url":"https://api.github.com/users/MountainRoseHerbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MountainRoseHerbs/subscriptions","organizations_url":"https://api.github.com/users/MountainRoseHerbs/orgs","repos_url":"https://api.github.com/users/MountainRoseHerbs/repos","events_url":"https://api.github.com/users/MountainRoseHerbs/events{/privacy}","received_events_url":"https://api.github.com/users/MountainRoseHerbs/received_events","type":"Organization","site_admin":false},"repo":{"id":14555294,"name":"active_shipping","full_name":"MountainRoseHerbs/active_shipping","owner":{"login":"MountainRoseHerbs","id":2074141,"avatar_url":"https://avatars.githubusercontent.com/u/2074141?v=3","gravatar_id":"","url":"https://api.github.com/users/MountainRoseHerbs","html_url":"https://github.com/MountainRoseHerbs","followers_url":"https://api.github.com/users/MountainRoseHerbs/followers","following_url":"https://api.github.com/users/MountainRoseHerbs/following{/other_user}","gists_url":"https://api.github.com/users/MountainRoseHerbs/gists{/gist_id}","starred_url":"https://api.github.com/users/MountainRoseHerbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MountainRoseHerbs/subscriptions","organizations_url":"https://api.github.com/users/MountainRoseHerbs/orgs","repos_url":"https://api.github.com/users/MountainRoseHerbs/repos","events_url":"https://api.github.com/users/MountainRoseHerbs/events{/privacy}","received_events_url":"https://api.github.com/users/MountainRoseHerbs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MountainRoseHerbs/active_shipping","description":"Shipping API extension for Active Merchant.","fork":true,"url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping","forks_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/forks","keys_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/teams","hooks_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/hooks","issue_events_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/issues/events{/number}","events_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/events","assignees_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/assignees{/user}","branches_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/branches{/branch}","tags_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/tags","blobs_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/git/refs{/sha}","trees_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/statuses/{sha}","languages_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/languages","stargazers_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/stargazers","contributors_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/contributors","subscribers_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/subscribers","subscription_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/subscription","commits_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/commits{/sha}","git_commits_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/git/commits{/sha}","comments_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/comments{/number}","issue_comment_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/issues/comments{/number}","contents_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/contents/{+path}","compare_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/merges","archive_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/downloads","issues_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/issues{/number}","pulls_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/pulls{/number}","milestones_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/milestones{/number}","notifications_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/labels{/name}","releases_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/releases{/id}","deployments_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/deployments","created_at":"2013-11-20T11:55:53Z","updated_at":"2016-03-02T21:58:39Z","pushed_at":"2016-03-02T23:46:44Z","git_url":"git://github.com/MountainRoseHerbs/active_shipping.git","ssh_url":"git@github.com:MountainRoseHerbs/active_shipping.git","clone_url":"https://github.com/MountainRoseHerbs/active_shipping.git","svn_url":"https://github.com/MountainRoseHerbs/active_shipping","homepage":"","size":1804,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"MountainRoseHerbs:master","ref":"master","sha":"12ca0ea2fce2098e80c5c6bdf4af02a3b96c370a","user":{"login":"MountainRoseHerbs","id":2074141,"avatar_url":"https://avatars.githubusercontent.com/u/2074141?v=3","gravatar_id":"","url":"https://api.github.com/users/MountainRoseHerbs","html_url":"https://github.com/MountainRoseHerbs","followers_url":"https://api.github.com/users/MountainRoseHerbs/followers","following_url":"https://api.github.com/users/MountainRoseHerbs/following{/other_user}","gists_url":"https://api.github.com/users/MountainRoseHerbs/gists{/gist_id}","starred_url":"https://api.github.com/users/MountainRoseHerbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MountainRoseHerbs/subscriptions","organizations_url":"https://api.github.com/users/MountainRoseHerbs/orgs","repos_url":"https://api.github.com/users/MountainRoseHerbs/repos","events_url":"https://api.github.com/users/MountainRoseHerbs/events{/privacy}","received_events_url":"https://api.github.com/users/MountainRoseHerbs/received_events","type":"Organization","site_admin":false},"repo":{"id":14555294,"name":"active_shipping","full_name":"MountainRoseHerbs/active_shipping","owner":{"login":"MountainRoseHerbs","id":2074141,"avatar_url":"https://avatars.githubusercontent.com/u/2074141?v=3","gravatar_id":"","url":"https://api.github.com/users/MountainRoseHerbs","html_url":"https://github.com/MountainRoseHerbs","followers_url":"https://api.github.com/users/MountainRoseHerbs/followers","following_url":"https://api.github.com/users/MountainRoseHerbs/following{/other_user}","gists_url":"https://api.github.com/users/MountainRoseHerbs/gists{/gist_id}","starred_url":"https://api.github.com/users/MountainRoseHerbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MountainRoseHerbs/subscriptions","organizations_url":"https://api.github.com/users/MountainRoseHerbs/orgs","repos_url":"https://api.github.com/users/MountainRoseHerbs/repos","events_url":"https://api.github.com/users/MountainRoseHerbs/events{/privacy}","received_events_url":"https://api.github.com/users/MountainRoseHerbs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MountainRoseHerbs/active_shipping","description":"Shipping API extension for Active Merchant.","fork":true,"url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping","forks_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/forks","keys_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/teams","hooks_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/hooks","issue_events_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/issues/events{/number}","events_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/events","assignees_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/assignees{/user}","branches_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/branches{/branch}","tags_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/tags","blobs_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/git/refs{/sha}","trees_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/statuses/{sha}","languages_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/languages","stargazers_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/stargazers","contributors_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/contributors","subscribers_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/subscribers","subscription_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/subscription","commits_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/commits{/sha}","git_commits_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/git/commits{/sha}","comments_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/comments{/number}","issue_comment_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/issues/comments{/number}","contents_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/contents/{+path}","compare_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/merges","archive_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/downloads","issues_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/issues{/number}","pulls_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/pulls{/number}","milestones_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/milestones{/number}","notifications_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/labels{/name}","releases_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/releases{/id}","deployments_url":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/deployments","created_at":"2013-11-20T11:55:53Z","updated_at":"2016-03-02T21:58:39Z","pushed_at":"2016-03-02T23:46:44Z","git_url":"git://github.com/MountainRoseHerbs/active_shipping.git","ssh_url":"git@github.com:MountainRoseHerbs/active_shipping.git","clone_url":"https://github.com/MountainRoseHerbs/active_shipping.git","svn_url":"https://github.com/MountainRoseHerbs/active_shipping","homepage":"","size":1804,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/pulls/3"},"html":{"href":"https://github.com/MountainRoseHerbs/active_shipping/pull/3"},"issue":{"href":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/issues/3"},"comments":{"href":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/MountainRoseHerbs/active_shipping/statuses/2d1f5843a9a1d68a1e9689eeb0105e69d5126b90"}}}}