{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/52120936","id":52120936,"diff_hunk":"@@ -0,0 +1,117 @@\n+/* ares_build.h.  Generated from ares_build.h.in by configure.  */\n+#ifndef __CARES_BUILD_H\n+#define __CARES_BUILD_H\n+\n+\n+/* Copyright (C) 2009 by Daniel Stenberg et al\n+ *\n+ * Permission to use, copy, modify, and distribute this software and its\n+ * documentation for any purpose and without fee is hereby granted, provided\n+ * that the above copyright notice appear in all copies and that both that\n+ * copyright notice and this permission notice appear in supporting\n+ * documentation, and that the name of M.I.T. not be used in advertising or\n+ * publicity pertaining to distribution of the software without specific,\n+ * written prior permission.  M.I.T. makes no representations about the\n+ * suitability of this software for any purpose.  It is provided \"as is\"\n+ * without express or implied warranty.\n+ */\n+\n+/* ================================================================ */\n+/*               NOTES FOR CONFIGURE CAPABLE SYSTEMS                */\n+/* ================================================================ */\n+\n+/*\n+ * NOTE 1:\n+ * -------\n+ *\n+ * Nothing in this file is intended to be modified or adjusted by the\n+ * c-ares library user nor by the c-ares library builder.\n+ *\n+ * If you think that something actually needs to be changed, adjusted\n+ * or fixed in this file, then, report it on the c-ares development\n+ * mailing list: http://cool.haxx.se/mailman/listinfo/c-ares/\n+ *\n+ * This header file shall only export symbols which are 'cares' or 'CARES'\n+ * prefixed, otherwise public name space would be polluted.\n+ *\n+ * NOTE 2:\n+ * -------\n+ *\n+ * Right now you might be staring at file ares_build.h.in or ares_build.h,\n+ * this is due to the following reason:\n+ *\n+ * On systems capable of running the configure script, the configure process\n+ * will overwrite the distributed ares_build.h file with one that is suitable\n+ * and specific to the library being configured and built, which is generated\n+ * from the ares_build.h.in template file.\n+ *\n+ */\n+\n+/* ================================================================ */\n+/*  DEFINITION OF THESE SYMBOLS SHALL NOT TAKE PLACE ANYWHERE ELSE  */\n+/* ================================================================ */\n+\n+#ifdef CARES_SIZEOF_LONG\n+#  error \"CARES_SIZEOF_LONG shall not be defined except in ares_build.h\"\n+   Error Compilation_aborted_CARES_SIZEOF_LONG_already_defined\n+#endif\n+\n+#ifdef CARES_TYPEOF_ARES_SOCKLEN_T\n+#  error \"CARES_TYPEOF_ARES_SOCKLEN_T shall not be defined except in ares_build.h\"\n+   Error Compilation_aborted_CARES_TYPEOF_ARES_SOCKLEN_T_already_defined\n+#endif\n+\n+#ifdef CARES_SIZEOF_ARES_SOCKLEN_T\n+#  error \"CARES_SIZEOF_ARES_SOCKLEN_T shall not be defined except in ares_build.h\"\n+   Error Compilation_aborted_CARES_SIZEOF_ARES_SOCKLEN_T_already_defined\n+#endif\n+\n+/* ================================================================ */\n+/*  EXTERNAL INTERFACE SETTINGS FOR CONFIGURE CAPABLE SYSTEMS ONLY  */\n+/* ================================================================ */\n+\n+/* Configure process defines this to 1 when it finds out that system  */\n+/* header file ws2tcpip.h must be included by the external interface. */\n+\n+#ifdef WIN32","path":"deps/cares/include/ares_build.h","position":76,"original_position":76,"commit_id":"f4cc5cd1b4fccad983e2ec5a362ac741c43bb78f","original_commit_id":"f4cc5cd1b4fccad983e2ec5a362ac741c43bb78f","user":{"login":"saghul","id":317464,"avatar_url":"https://avatars.githubusercontent.com/u/317464?v=3","gravatar_id":"","url":"https://api.github.com/users/saghul","html_url":"https://github.com/saghul","followers_url":"https://api.github.com/users/saghul/followers","following_url":"https://api.github.com/users/saghul/following{/other_user}","gists_url":"https://api.github.com/users/saghul/gists{/gist_id}","starred_url":"https://api.github.com/users/saghul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghul/subscriptions","organizations_url":"https://api.github.com/users/saghul/orgs","repos_url":"https://api.github.com/users/saghul/repos","events_url":"https://api.github.com/users/saghul/events{/privacy}","received_events_url":"https://api.github.com/users/saghul/received_events","type":"User","site_admin":false},"body":"Maybe this should be _WIN32 instead? I see the CI failed because on the include in line 96, which wouldn't happen if we entered through here.","created_at":"2016-02-07T17:35:31Z","updated_at":"2016-02-07T17:35:31Z","html_url":"https://github.com/nodejs/node/pull/5090#discussion_r52120936","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/5090","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/52120936"},"html":{"href":"https://github.com/nodejs/node/pull/5090#discussion_r52120936"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/5090"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/5090","id":58353044,"html_url":"https://github.com/nodejs/node/pull/5090","diff_url":"https://github.com/nodejs/node/pull/5090.diff","patch_url":"https://github.com/nodejs/node/pull/5090.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/5090","number":5090,"state":"open","locked":false,"title":"Feature/update cares to 2bae2d56d7866defcee18455c1f2ecfef6c7663d","user":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"body":"R= @bnoordhuis \r\n\r\ncc @nodejs/collaborators ","created_at":"2016-02-04T21:37:07Z","updated_at":"2016-02-07T17:35:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9470faa1f72d0c2dc314457f26357c25ba1dcc31","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/5090/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/5090/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/5090/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/f4cc5cd1b4fccad983e2ec5a362ac741c43bb78f","head":{"label":"indutny:feature/update-cares-to-2bae2d56d7866defcee18455c1f2ecfef6c7663d","ref":"feature/update-cares-to-2bae2d56d7866defcee18455c1f2ecfef6c7663d","sha":"f4cc5cd1b4fccad983e2ec5a362ac741c43bb78f","user":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"repo":{"id":27231488,"name":"io.js","full_name":"indutny/io.js","owner":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/indutny/io.js","description":"Evented IO for V8 JavaScript","fork":true,"url":"https://api.github.com/repos/indutny/io.js","forks_url":"https://api.github.com/repos/indutny/io.js/forks","keys_url":"https://api.github.com/repos/indutny/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indutny/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indutny/io.js/teams","hooks_url":"https://api.github.com/repos/indutny/io.js/hooks","issue_events_url":"https://api.github.com/repos/indutny/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/indutny/io.js/events","assignees_url":"https://api.github.com/repos/indutny/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/indutny/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/indutny/io.js/tags","blobs_url":"https://api.github.com/repos/indutny/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indutny/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indutny/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/indutny/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indutny/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/indutny/io.js/languages","stargazers_url":"https://api.github.com/repos/indutny/io.js/stargazers","contributors_url":"https://api.github.com/repos/indutny/io.js/contributors","subscribers_url":"https://api.github.com/repos/indutny/io.js/subscribers","subscription_url":"https://api.github.com/repos/indutny/io.js/subscription","commits_url":"https://api.github.com/repos/indutny/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/indutny/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/indutny/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/indutny/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/indutny/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/indutny/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indutny/io.js/merges","archive_url":"https://api.github.com/repos/indutny/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indutny/io.js/downloads","issues_url":"https://api.github.com/repos/indutny/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/indutny/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/indutny/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/indutny/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indutny/io.js/labels{/name}","releases_url":"https://api.github.com/repos/indutny/io.js/releases{/id}","deployments_url":"https://api.github.com/repos/indutny/io.js/deployments","created_at":"2014-11-27T15:38:33Z","updated_at":"2015-02-18T15:41:43Z","pushed_at":"2016-02-06T05:53:37Z","git_url":"git://github.com/indutny/io.js.git","ssh_url":"git@github.com:indutny/io.js.git","clone_url":"https://github.com/indutny/io.js.git","svn_url":"https://github.com/indutny/io.js","homepage":null,"size":171669,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"v0.12"}},"base":{"label":"nodejs:master","ref":"master","sha":"25751bedfe7b227dd3690a1e4bdee14fc9a2d517","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-02-07T15:01:02Z","pushed_at":"2016-02-07T16:17:51Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":207493,"stargazers_count":20017,"watchers_count":20017,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2483,"mirror_url":null,"open_issues_count":727,"forks":2483,"open_issues":727,"watchers":20017,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/5090"},"html":{"href":"https://github.com/nodejs/node/pull/5090"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/5090"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/5090/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/5090/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/5090/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/f4cc5cd1b4fccad983e2ec5a362ac741c43bb78f"}}}}