{"action":"closed","number":67,"pull_request":{"url":"https://api.github.com/repos/percona/galera/pulls/67","id":75747677,"html_url":"https://github.com/percona/galera/pull/67","diff_url":"https://github.com/percona/galera/pull/67.diff","patch_url":"https://github.com/percona/galera/pull/67.patch","issue_url":"https://api.github.com/repos/percona/galera/issues/67","number":67,"state":"closed","locked":false,"title":"- #PXC-601: show status while updating group state can cause an assert (likely race)","user":{"login":"sysprg","id":10448138,"avatar_url":"https://avatars.githubusercontent.com/u/10448138?v=3","gravatar_id":"","url":"https://api.github.com/users/sysprg","html_url":"https://github.com/sysprg","followers_url":"https://api.github.com/users/sysprg/followers","following_url":"https://api.github.com/users/sysprg/following{/other_user}","gists_url":"https://api.github.com/users/sysprg/gists{/gist_id}","starred_url":"https://api.github.com/users/sysprg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sysprg/subscriptions","organizations_url":"https://api.github.com/users/sysprg/orgs","repos_url":"https://api.github.com/users/sysprg/repos","events_url":"https://api.github.com/users/sysprg/events{/privacy}","received_events_url":"https://api.github.com/users/sysprg/received_events","type":"User","site_admin":false},"body":"The gcs_group_get_status function does not check that the group->my_idx can be equal to -1 (for example, when node receives self-leave message during non-primary state or technically due to implementation details of the gcs_group_handle_comp_msg function). Therefore, gcs_group_get_status function refers to memory beyond the array, which leads to SIGFAULT during execution of the to_string function.\r\n\r\nTo fix this error we should not read desync counter until the gcs_group_handle_comp_msg function returns the group->my_idx to definite state.\r\n\r\nIn addition, we should handle the situation where node is in the non-primary state and we got self-leave message. In this case node is desynchronized from the cluster, therefore I propose to return desync counter = 1.\r\n\r\nPXC part of this patch is available here: https://github.com/percona/percona-xtradb-cluster/pull/173","created_at":"2016-06-30T01:29:07Z","updated_at":"2016-07-04T07:58:28Z","closed_at":"2016-07-04T07:58:27Z","merged_at":"2016-07-04T07:58:27Z","merge_commit_sha":"4392a6155b98161587a6a581b5d1f1f96a6b9f0e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/percona/galera/pulls/67/commits","review_comments_url":"https://api.github.com/repos/percona/galera/pulls/67/comments","review_comment_url":"https://api.github.com/repos/percona/galera/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/galera/issues/67/comments","statuses_url":"https://api.github.com/repos/percona/galera/statuses/d0f521506ff3bce598b626fb88e710bfbae96415","head":{"label":"natsys:3.x-pxc-601","ref":"3.x-pxc-601","sha":"d0f521506ff3bce598b626fb88e710bfbae96415","user":{"login":"natsys","id":8489938,"avatar_url":"https://avatars.githubusercontent.com/u/8489938?v=3","gravatar_id":"","url":"https://api.github.com/users/natsys","html_url":"https://github.com/natsys","followers_url":"https://api.github.com/users/natsys/followers","following_url":"https://api.github.com/users/natsys/following{/other_user}","gists_url":"https://api.github.com/users/natsys/gists{/gist_id}","starred_url":"https://api.github.com/users/natsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natsys/subscriptions","organizations_url":"https://api.github.com/users/natsys/orgs","repos_url":"https://api.github.com/users/natsys/repos","events_url":"https://api.github.com/users/natsys/events{/privacy}","received_events_url":"https://api.github.com/users/natsys/received_events","type":"Organization","site_admin":false},"repo":{"id":45468076,"name":"galera","full_name":"natsys/galera","owner":{"login":"natsys","id":8489938,"avatar_url":"https://avatars.githubusercontent.com/u/8489938?v=3","gravatar_id":"","url":"https://api.github.com/users/natsys","html_url":"https://github.com/natsys","followers_url":"https://api.github.com/users/natsys/followers","following_url":"https://api.github.com/users/natsys/following{/other_user}","gists_url":"https://api.github.com/users/natsys/gists{/gist_id}","starred_url":"https://api.github.com/users/natsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natsys/subscriptions","organizations_url":"https://api.github.com/users/natsys/orgs","repos_url":"https://api.github.com/users/natsys/repos","events_url":"https://api.github.com/users/natsys/events{/privacy}","received_events_url":"https://api.github.com/users/natsys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/natsys/galera","description":"Synchronous multi-master replication library","fork":true,"url":"https://api.github.com/repos/natsys/galera","forks_url":"https://api.github.com/repos/natsys/galera/forks","keys_url":"https://api.github.com/repos/natsys/galera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natsys/galera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natsys/galera/teams","hooks_url":"https://api.github.com/repos/natsys/galera/hooks","issue_events_url":"https://api.github.com/repos/natsys/galera/issues/events{/number}","events_url":"https://api.github.com/repos/natsys/galera/events","assignees_url":"https://api.github.com/repos/natsys/galera/assignees{/user}","branches_url":"https://api.github.com/repos/natsys/galera/branches{/branch}","tags_url":"https://api.github.com/repos/natsys/galera/tags","blobs_url":"https://api.github.com/repos/natsys/galera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natsys/galera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natsys/galera/git/refs{/sha}","trees_url":"https://api.github.com/repos/natsys/galera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natsys/galera/statuses/{sha}","languages_url":"https://api.github.com/repos/natsys/galera/languages","stargazers_url":"https://api.github.com/repos/natsys/galera/stargazers","contributors_url":"https://api.github.com/repos/natsys/galera/contributors","subscribers_url":"https://api.github.com/repos/natsys/galera/subscribers","subscription_url":"https://api.github.com/repos/natsys/galera/subscription","commits_url":"https://api.github.com/repos/natsys/galera/commits{/sha}","git_commits_url":"https://api.github.com/repos/natsys/galera/git/commits{/sha}","comments_url":"https://api.github.com/repos/natsys/galera/comments{/number}","issue_comment_url":"https://api.github.com/repos/natsys/galera/issues/comments{/number}","contents_url":"https://api.github.com/repos/natsys/galera/contents/{+path}","compare_url":"https://api.github.com/repos/natsys/galera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natsys/galera/merges","archive_url":"https://api.github.com/repos/natsys/galera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natsys/galera/downloads","issues_url":"https://api.github.com/repos/natsys/galera/issues{/number}","pulls_url":"https://api.github.com/repos/natsys/galera/pulls{/number}","milestones_url":"https://api.github.com/repos/natsys/galera/milestones{/number}","notifications_url":"https://api.github.com/repos/natsys/galera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natsys/galera/labels{/name}","releases_url":"https://api.github.com/repos/natsys/galera/releases{/id}","deployments_url":"https://api.github.com/repos/natsys/galera/deployments","created_at":"2015-11-03T13:26:28Z","updated_at":"2016-01-13T11:57:46Z","pushed_at":"2016-06-30T08:56:37Z","git_url":"git://github.com/natsys/galera.git","ssh_url":"git@github.com:natsys/galera.git","clone_url":"https://github.com/natsys/galera.git","svn_url":"https://github.com/natsys/galera","homepage":null,"size":14577,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.x"}},"base":{"label":"percona:3.x","ref":"3.x","sha":"74216ed019e3faac07e3c8f68e1d36e059fc76d0","user":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":19982228,"name":"galera","full_name":"percona/galera","owner":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/galera","description":"Synchronous multi-master replication library","fork":true,"url":"https://api.github.com/repos/percona/galera","forks_url":"https://api.github.com/repos/percona/galera/forks","keys_url":"https://api.github.com/repos/percona/galera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/galera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/galera/teams","hooks_url":"https://api.github.com/repos/percona/galera/hooks","issue_events_url":"https://api.github.com/repos/percona/galera/issues/events{/number}","events_url":"https://api.github.com/repos/percona/galera/events","assignees_url":"https://api.github.com/repos/percona/galera/assignees{/user}","branches_url":"https://api.github.com/repos/percona/galera/branches{/branch}","tags_url":"https://api.github.com/repos/percona/galera/tags","blobs_url":"https://api.github.com/repos/percona/galera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/galera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/galera/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/galera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/galera/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/galera/languages","stargazers_url":"https://api.github.com/repos/percona/galera/stargazers","contributors_url":"https://api.github.com/repos/percona/galera/contributors","subscribers_url":"https://api.github.com/repos/percona/galera/subscribers","subscription_url":"https://api.github.com/repos/percona/galera/subscription","commits_url":"https://api.github.com/repos/percona/galera/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/galera/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/galera/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/galera/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/galera/contents/{+path}","compare_url":"https://api.github.com/repos/percona/galera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/galera/merges","archive_url":"https://api.github.com/repos/percona/galera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/galera/downloads","issues_url":"https://api.github.com/repos/percona/galera/issues{/number}","pulls_url":"https://api.github.com/repos/percona/galera/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/galera/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/galera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/galera/labels{/name}","releases_url":"https://api.github.com/repos/percona/galera/releases{/id}","deployments_url":"https://api.github.com/repos/percona/galera/deployments","created_at":"2014-05-20T13:39:26Z","updated_at":"2016-06-11T19:06:50Z","pushed_at":"2016-07-04T07:58:28Z","git_url":"git://github.com/percona/galera.git","ssh_url":"git@github.com:percona/galera.git","clone_url":"https://github.com/percona/galera.git","svn_url":"https://github.com/percona/galera","homepage":null,"size":14597,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":7,"forks":9,"open_issues":7,"watchers":8,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/galera/pulls/67"},"html":{"href":"https://github.com/percona/galera/pull/67"},"issue":{"href":"https://api.github.com/repos/percona/galera/issues/67"},"comments":{"href":"https://api.github.com/repos/percona/galera/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/galera/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/galera/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/galera/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/percona/galera/statuses/d0f521506ff3bce598b626fb88e710bfbae96415"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kbauskar","id":14107301,"avatar_url":"https://avatars.githubusercontent.com/u/14107301?v=3","gravatar_id":"","url":"https://api.github.com/users/kbauskar","html_url":"https://github.com/kbauskar","followers_url":"https://api.github.com/users/kbauskar/followers","following_url":"https://api.github.com/users/kbauskar/following{/other_user}","gists_url":"https://api.github.com/users/kbauskar/gists{/gist_id}","starred_url":"https://api.github.com/users/kbauskar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbauskar/subscriptions","organizations_url":"https://api.github.com/users/kbauskar/orgs","repos_url":"https://api.github.com/users/kbauskar/repos","events_url":"https://api.github.com/users/kbauskar/events{/privacy}","received_events_url":"https://api.github.com/users/kbauskar/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"commits":1,"additions":54,"deletions":4,"changed_files":3}}
{"actor":{"display_login":"kbauskar"}}