{"action":"created","comment":{"url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/pulls/comments/52336906","id":52336906,"diff_hunk":"@@ -42,20 +69,23 @@ trait RolesSpec { self: MesosIntTestHelper =>\n     assert(m.sparkFramework.isDefined, \"The driver should be running\")\n \n     if (cfg.role != \"*\") {\n-      // TODO: add message\n-      assert(m.slaves.flatMap { x => x.roleResources.map { y => y.roleName } }.contains(cfg.role))\n+\n+      assert(m.slaves.flatMap { x => x.roleResources.map { y => y.roleName } }.contains(cfg.role), \"spark role should exist\")\n \n       // make sure reserved resources for that role are used\n       m.slaves.foreach {\n         x =>\n           val reserved = x.roleResources.filter(r => r.roleName == cfg.role).head\n-          val used = x.usedResources\n-          // TODO: add message\n-          assert(reserved.resources.cpu >= used.cpu)\n+          assert(reserved.resources.cpu == cfg.roleCpus.toInt, \"Reserved resources per slave\")\n+      }\n+      val totalCpus = {\n+        val tmp = m.slaves.map { x => x.resources.cpu }.sum","path":"test-runner/src/main/scala/com/typesafe/spark/test/mesos/RolesSpec.scala","position":86,"original_position":86,"commit_id":"461edcfac093f74a15d1ff3e4254d139599ac8fd","original_commit_id":"461edcfac093f74a15d1ff3e4254d139599ac8fd","user":{"login":"skonto","id":7945591,"avatar_url":"https://avatars.githubusercontent.com/u/7945591?v=3","gravatar_id":"","url":"https://api.github.com/users/skonto","html_url":"https://github.com/skonto","followers_url":"https://api.github.com/users/skonto/followers","following_url":"https://api.github.com/users/skonto/following{/other_user}","gists_url":"https://api.github.com/users/skonto/gists{/gist_id}","starred_url":"https://api.github.com/users/skonto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skonto/subscriptions","organizations_url":"https://api.github.com/users/skonto/orgs","repos_url":"https://api.github.com/users/skonto/repos","events_url":"https://api.github.com/users/skonto/events{/privacy}","received_events_url":"https://api.github.com/users/skonto/received_events","type":"User","site_admin":false},"body":"You have to do that while job is running as executors grow which is not easy, post check is what i do, making sure we have the correct resources at the end in different cases.","created_at":"2016-02-09T16:54:02Z","updated_at":"2016-02-09T16:54:02Z","html_url":"https://github.com/typesafehub/mesos-spark-integration-tests/pull/47#discussion_r52336906","pull_request_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/pulls/comments/52336906"},"html":{"href":"https://github.com/typesafehub/mesos-spark-integration-tests/pull/47#discussion_r52336906"},"pull_request":{"href":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/pulls/47","id":56879802,"html_url":"https://github.com/typesafehub/mesos-spark-integration-tests/pull/47","diff_url":"https://github.com/typesafehub/mesos-spark-integration-tests/pull/47.diff","patch_url":"https://github.com/typesafehub/mesos-spark-integration-tests/pull/47.patch","issue_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/issues/47","number":47,"state":"open","locked":false,"title":"fix-roles","user":{"login":"skonto","id":7945591,"avatar_url":"https://avatars.githubusercontent.com/u/7945591?v=3","gravatar_id":"","url":"https://api.github.com/users/skonto","html_url":"https://github.com/skonto","followers_url":"https://api.github.com/users/skonto/followers","following_url":"https://api.github.com/users/skonto/following{/other_user}","gists_url":"https://api.github.com/users/skonto/gists{/gist_id}","starred_url":"https://api.github.com/users/skonto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skonto/subscriptions","organizations_url":"https://api.github.com/users/skonto/orgs","repos_url":"https://api.github.com/users/skonto/repos","events_url":"https://api.github.com/users/skonto/events{/privacy}","received_events_url":"https://api.github.com/users/skonto/received_events","type":"User","site_admin":false},"body":"- make all resources double in StateDump\r\n- fix role tests","created_at":"2016-01-22T12:07:01Z","updated_at":"2016-02-09T16:54:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"412d030ae2852459e13c302e0cf6f3f197d4894e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/pulls/47/commits","review_comments_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/pulls/47/comments","review_comment_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/issues/47/comments","statuses_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/statuses/461edcfac093f74a15d1ff3e4254d139599ac8fd","head":{"label":"skonto:fix_roles","ref":"fix_roles","sha":"461edcfac093f74a15d1ff3e4254d139599ac8fd","user":{"login":"skonto","id":7945591,"avatar_url":"https://avatars.githubusercontent.com/u/7945591?v=3","gravatar_id":"","url":"https://api.github.com/users/skonto","html_url":"https://github.com/skonto","followers_url":"https://api.github.com/users/skonto/followers","following_url":"https://api.github.com/users/skonto/following{/other_user}","gists_url":"https://api.github.com/users/skonto/gists{/gist_id}","starred_url":"https://api.github.com/users/skonto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skonto/subscriptions","organizations_url":"https://api.github.com/users/skonto/orgs","repos_url":"https://api.github.com/users/skonto/repos","events_url":"https://api.github.com/users/skonto/events{/privacy}","received_events_url":"https://api.github.com/users/skonto/received_events","type":"User","site_admin":false},"repo":{"id":45947804,"name":"mesos-spark-integration-tests","full_name":"skonto/mesos-spark-integration-tests","owner":{"login":"skonto","id":7945591,"avatar_url":"https://avatars.githubusercontent.com/u/7945591?v=3","gravatar_id":"","url":"https://api.github.com/users/skonto","html_url":"https://github.com/skonto","followers_url":"https://api.github.com/users/skonto/followers","following_url":"https://api.github.com/users/skonto/following{/other_user}","gists_url":"https://api.github.com/users/skonto/gists{/gist_id}","starred_url":"https://api.github.com/users/skonto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skonto/subscriptions","organizations_url":"https://api.github.com/users/skonto/orgs","repos_url":"https://api.github.com/users/skonto/repos","events_url":"https://api.github.com/users/skonto/events{/privacy}","received_events_url":"https://api.github.com/users/skonto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skonto/mesos-spark-integration-tests","description":"Mesos Integration Tests on Docker/Ec2","fork":true,"url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests","forks_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/forks","keys_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/teams","hooks_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/hooks","issue_events_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/issues/events{/number}","events_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/events","assignees_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/assignees{/user}","branches_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/branches{/branch}","tags_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/tags","blobs_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/languages","stargazers_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/stargazers","contributors_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/contributors","subscribers_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/subscribers","subscription_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/subscription","commits_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/contents/{+path}","compare_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/merges","archive_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/downloads","issues_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/issues{/number}","pulls_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/labels{/name}","releases_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/releases{/id}","deployments_url":"https://api.github.com/repos/skonto/mesos-spark-integration-tests/deployments","created_at":"2015-11-10T23:41:20Z","updated_at":"2016-01-21T12:51:23Z","pushed_at":"2016-02-02T12:25:34Z","git_url":"git://github.com/skonto/mesos-spark-integration-tests.git","ssh_url":"git@github.com:skonto/mesos-spark-integration-tests.git","clone_url":"https://github.com/skonto/mesos-spark-integration-tests.git","svn_url":"https://github.com/skonto/mesos-spark-integration-tests","homepage":null,"size":198,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"typesafehub:master","ref":"master","sha":"df4e241308d52173419ab336918a8f418fac1b16","user":{"login":"typesafehub","id":784923,"avatar_url":"https://avatars.githubusercontent.com/u/784923?v=3","gravatar_id":"","url":"https://api.github.com/users/typesafehub","html_url":"https://github.com/typesafehub","followers_url":"https://api.github.com/users/typesafehub/followers","following_url":"https://api.github.com/users/typesafehub/following{/other_user}","gists_url":"https://api.github.com/users/typesafehub/gists{/gist_id}","starred_url":"https://api.github.com/users/typesafehub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typesafehub/subscriptions","organizations_url":"https://api.github.com/users/typesafehub/orgs","repos_url":"https://api.github.com/users/typesafehub/repos","events_url":"https://api.github.com/users/typesafehub/events{/privacy}","received_events_url":"https://api.github.com/users/typesafehub/received_events","type":"Organization","site_admin":false},"repo":{"id":45480608,"name":"mesos-spark-integration-tests","full_name":"typesafehub/mesos-spark-integration-tests","owner":{"login":"typesafehub","id":784923,"avatar_url":"https://avatars.githubusercontent.com/u/784923?v=3","gravatar_id":"","url":"https://api.github.com/users/typesafehub","html_url":"https://github.com/typesafehub","followers_url":"https://api.github.com/users/typesafehub/followers","following_url":"https://api.github.com/users/typesafehub/following{/other_user}","gists_url":"https://api.github.com/users/typesafehub/gists{/gist_id}","starred_url":"https://api.github.com/users/typesafehub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typesafehub/subscriptions","organizations_url":"https://api.github.com/users/typesafehub/orgs","repos_url":"https://api.github.com/users/typesafehub/repos","events_url":"https://api.github.com/users/typesafehub/events{/privacy}","received_events_url":"https://api.github.com/users/typesafehub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/typesafehub/mesos-spark-integration-tests","description":"Mesos Integration Tests on Docker/Ec2","fork":false,"url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests","forks_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/forks","keys_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/teams","hooks_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/hooks","issue_events_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/issues/events{/number}","events_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/events","assignees_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/assignees{/user}","branches_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/branches{/branch}","tags_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/tags","blobs_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/languages","stargazers_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/stargazers","contributors_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/contributors","subscribers_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/subscribers","subscription_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/subscription","commits_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/contents/{+path}","compare_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/merges","archive_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/downloads","issues_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/issues{/number}","pulls_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/labels{/name}","releases_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/releases{/id}","deployments_url":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/deployments","created_at":"2015-11-03T16:45:16Z","updated_at":"2016-01-18T11:44:42Z","pushed_at":"2016-02-09T13:41:29Z","git_url":"git://github.com/typesafehub/mesos-spark-integration-tests.git","ssh_url":"git@github.com:typesafehub/mesos-spark-integration-tests.git","clone_url":"https://github.com/typesafehub/mesos-spark-integration-tests.git","svn_url":"https://github.com/typesafehub/mesos-spark-integration-tests","homepage":null,"size":205,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":6,"forks":5,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/pulls/47"},"html":{"href":"https://github.com/typesafehub/mesos-spark-integration-tests/pull/47"},"issue":{"href":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/issues/47"},"comments":{"href":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/typesafehub/mesos-spark-integration-tests/statuses/461edcfac093f74a15d1ff3e4254d139599ac8fd"}}}}