{"action":"created","issue":{"url":"https://api.github.com/repos/ember-cli/ember-cli/issues/5792","repository_url":"https://api.github.com/repos/ember-cli/ember-cli","labels_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/5792/labels{/name}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/5792/comments","events_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/5792/events","html_url":"https://github.com/ember-cli/ember-cli/pull/5792","id":148183300,"number":5792,"title":"[WIP] Add \"rootURL\" setting to deprecate \"baseURL\"","user":{"login":"Turbo87","id":141300,"avatar_url":"https://avatars.githubusercontent.com/u/141300?v=3","gravatar_id":"","url":"https://api.github.com/users/Turbo87","html_url":"https://github.com/Turbo87","followers_url":"https://api.github.com/users/Turbo87/followers","following_url":"https://api.github.com/users/Turbo87/following{/other_user}","gists_url":"https://api.github.com/users/Turbo87/gists{/gist_id}","starred_url":"https://api.github.com/users/Turbo87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Turbo87/subscriptions","organizations_url":"https://api.github.com/users/Turbo87/orgs","repos_url":"https://api.github.com/users/Turbo87/repos","events_url":"https://api.github.com/users/Turbo87/events{/privacy}","received_events_url":"https://api.github.com/users/Turbo87/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ember-cli/ember-cli/labels/Bug","name":"Bug","color":"e11d21"},{"url":"https://api.github.com/repos/ember-cli/ember-cli/labels/Cleanup","name":"Cleanup","color":"0052cc"},{"url":"https://api.github.com/repos/ember-cli/ember-cli/labels/Enhancement","name":"Enhancement","color":"009800"},{"url":"https://api.github.com/repos/ember-cli/ember-cli/labels/Needs%20Code%20Review","name":"Needs Code Review","color":"9319E0"},{"url":"https://api.github.com/repos/ember-cli/ember-cli/labels/Needs%20Tests","name":"Needs Tests","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-04-13T21:06:24Z","updated_at":"2016-04-14T10:10:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/5792","html_url":"https://github.com/ember-cli/ember-cli/pull/5792","diff_url":"https://github.com/ember-cli/ember-cli/pull/5792.diff","patch_url":"https://github.com/ember-cli/ember-cli/pull/5792.patch"},"body":"This PR adds a new `rootURL` setting to `config/environment.js` that should be used instead of the old `baseURL` setting which had several issues related to the use of the `<base>` tag.\r\n\r\n- [x] `{{rootURL}}` in `index.html` files is replaced with the actual value\r\n- [x] `rootURL` is used instead of `baseURL` for `ember serve` (if it is set)\r\n- [x] a `testem-url-rewriter` middleware addon is added to rewrite URLs with `rootURL` prefix to URLs without that prefix to make testem happy\r\n- [x] adjust the app blueprint\r\n- [x] deprecate the usage of `baseURL`\r\n- [ ] test all the things!\r\n- [ ] no, srsly, write unit tests\r\n- [x] use all available label colors\r\n\r\n#### Test Cases\r\n\r\n- `baseURL: '/'`\r\n- `baseURL: '/foo/bar'`\r\n- `baseURL: '/', rootURL: '/'`\r\n- `baseURL: '/foo/bar', rootURL: '/'`\r\n- `baseURL: '/', rootURL: '/foo/bar'`\r\n- `baseURL: '/foo/bar', rootURL: '/foo/bar'`\r\n\r\n---\r\n\r\n- `ember serve` and checking if `/tests` (or `<rootURL>/tests`) works\r\n- `ember test`\r\n- `ember test --environment=production`\r\n- `ember test --server`\r\n\r\n---\r\n\r\nresolves #4905, resolves #4507, resolves #2989, resolves #2957, resolves #2633, resolves #417\r\n\r\n/cc @rwjblue @stefanpenner @nathanhammond "},"comment":{"url":"https://api.github.com/repos/ember-cli/ember-cli/issues/comments/209864100","html_url":"https://github.com/ember-cli/ember-cli/pull/5792#issuecomment-209864100","issue_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/5792","id":209864100,"user":{"login":"Turbo87","id":141300,"avatar_url":"https://avatars.githubusercontent.com/u/141300?v=3","gravatar_id":"","url":"https://api.github.com/users/Turbo87","html_url":"https://github.com/Turbo87","followers_url":"https://api.github.com/users/Turbo87/followers","following_url":"https://api.github.com/users/Turbo87/following{/other_user}","gists_url":"https://api.github.com/users/Turbo87/gists{/gist_id}","starred_url":"https://api.github.com/users/Turbo87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Turbo87/subscriptions","organizations_url":"https://api.github.com/users/Turbo87/orgs","repos_url":"https://api.github.com/users/Turbo87/repos","events_url":"https://api.github.com/users/Turbo87/events{/privacy}","received_events_url":"https://api.github.com/users/Turbo87/received_events","type":"User","site_admin":false},"created_at":"2016-04-14T10:10:19Z","updated_at":"2016-04-14T10:10:19Z","body":"whoa, even AppVeyor is green on this! :trollface: "}}