{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla-services/lua_sandbox/issues/168","repository_url":"https://api.github.com/repos/mozilla-services/lua_sandbox","labels_url":"https://api.github.com/repos/mozilla-services/lua_sandbox/issues/168/labels{/name}","comments_url":"https://api.github.com/repos/mozilla-services/lua_sandbox/issues/168/comments","events_url":"https://api.github.com/repos/mozilla-services/lua_sandbox/issues/168/events","html_url":"https://github.com/mozilla-services/lua_sandbox/issues/168","id":190670222,"number":168,"title":"test_write_heka_header fails on 32-bit architectures","user":{"login":"sathieu","id":741106,"avatar_url":"https://avatars.githubusercontent.com/u/741106?v=3","gravatar_id":"","url":"https://api.github.com/users/sathieu","html_url":"https://github.com/sathieu","followers_url":"https://api.github.com/users/sathieu/followers","following_url":"https://api.github.com/users/sathieu/following{/other_user}","gists_url":"https://api.github.com/users/sathieu/gists{/gist_id}","starred_url":"https://api.github.com/users/sathieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sathieu/subscriptions","organizations_url":"https://api.github.com/users/sathieu/orgs","repos_url":"https://api.github.com/users/sathieu/repos","events_url":"https://api.github.com/users/sathieu/events{/privacy}","received_events_url":"https://api.github.com/users/sathieu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-21T10:07:06Z","updated_at":"2016-12-05T06:19:16Z","closed_at":null,"body":"Since test_write_heka_header was introduced (b8f2516a83958a921d5f59b040cee2a0e3253c03 in 1.2.0), the Debian packages FTBFS (fail to build from source) on all 32-bit archs:\r\n```\r\n 7/14 Test  #7: test_heka_message ..................***Failed    0.00 sec\r\nline: 345 (hlen == 5 + i) i: 4 received 5\r\nTests run: 9\r\n```\r\n\r\nComplete build logs at: https://buildd.debian.org/status/package.php?p=lua-sandbox"},"comment":{"url":"https://api.github.com/repos/mozilla-services/lua_sandbox/issues/comments/264776270","html_url":"https://github.com/mozilla-services/lua_sandbox/issues/168#issuecomment-264776270","issue_url":"https://api.github.com/repos/mozilla-services/lua_sandbox/issues/168","id":264776270,"user":{"login":"sathieu","id":741106,"avatar_url":"https://avatars.githubusercontent.com/u/741106?v=3","gravatar_id":"","url":"https://api.github.com/users/sathieu","html_url":"https://github.com/sathieu","followers_url":"https://api.github.com/users/sathieu/followers","following_url":"https://api.github.com/users/sathieu/following{/other_user}","gists_url":"https://api.github.com/users/sathieu/gists{/gist_id}","starred_url":"https://api.github.com/users/sathieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sathieu/subscriptions","organizations_url":"https://api.github.com/users/sathieu/orgs","repos_url":"https://api.github.com/users/sathieu/repos","events_url":"https://api.github.com/users/sathieu/events{/privacy}","received_events_url":"https://api.github.com/users/sathieu/received_events","type":"User","site_admin":false},"created_at":"2016-12-05T06:19:16Z","updated_at":"2016-12-05T06:19:16Z","body":"What about doing this in the meantime:\r\n``` patch\r\ndiff --git a/src/util/test/test_heka_message.c b/src/util/test/test_heka_message.c\r\nindex 2a5aa3e..3b050a4 100644\r\n--- a/src/util/test/test_heka_message.c\r\n+++ b/src/util/test/test_heka_message.c\r\n@@ -340,7 +340,7 @@ static char* test_write_heka_header()\r\n   char header[LSB_MIN_HDR_SIZE];\r\n   size_t hlen;\r\n \r\n-  for (unsigned i = 0; i < 7; ++i) {\r\n+  for (unsigned i = 0; i < sizeof(void*)-1; ++i) {\r\n     hlen = lsb_write_heka_header(header, 1LL << (i * 8));\r\n     mu_assert(hlen == 5 + i, \"i: %u received %\" PRIuSIZE, i, hlen);\r\n   }\r\n```\r\n\r\nHeka message length is limited to 32bit anyway (https://hekad.readthedocs.io/en/v0.10.0/message/index.html#stream-framing)."}}
{"actor":{"display_login":"sathieu"}}