{"action":"created","comment":{"url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/pulls/comments/65748984","id":65748984,"diff_hunk":"@@ -0,0 +1,88 @@\n+package com.microsoft.graph.http;\n+\n+import android.test.AndroidTestCase;\n+\n+import com.google.gson.JsonObject;\n+import com.microsoft.graph.core.IBaseClient;\n+import com.microsoft.graph.core.MockBaseClient;\n+import com.microsoft.graph.serializer.ISerializer;\n+import com.microsoft.graph.serializer.MockSerializer;\n+\n+import java.util.ArrayList;\n+import java.util.List;\n+\n+/**\n+ * Test cases for {@see BaseCollectionPage}\n+ */\n+public class BaseCollectionPageTests extends AndroidTestCase {\n+\n+    private IRequestBuilder mRequestBuilder;\n+    private static ArrayList<String> list;\n+    private BaseCollectionPage baseCollectionPage;\n+    private String requestUrl = \"https://graph.microsoft.com/v1.0/me\";\n+\n+    @Override\n+    @SuppressWarnings(\"unchecked\")\n+    protected void setUp() throws Exception {\n+        super.setUp();\n+        list = new ArrayList<String>();\n+        list.add(\"Object1\");\n+        list.add(\"Object2\");\n+        list.add(\"Object3\");\n+        IBaseClient mBaseClient = new MockBaseClient();\n+        mRequestBuilder = new MockRequestBuilder(mBaseClient,requestUrl);\n+        baseCollectionPage = new BaseCollectionPage(list, mRequestBuilder) {\n+            @Override","path":"graphsdk/src/androidTest/java/com/microsoft/graph/http/BaseCollectionPageTests.java","position":35,"original_position":35,"commit_id":"b9dde90f20e258a51edd40c464482855b8d1e0f2","original_commit_id":"b9dde90f20e258a51edd40c464482855b8d1e0f2","user":{"login":"peternied","id":2754967,"avatar_url":"https://avatars.githubusercontent.com/u/2754967?v=3","gravatar_id":"","url":"https://api.github.com/users/peternied","html_url":"https://github.com/peternied","followers_url":"https://api.github.com/users/peternied/followers","following_url":"https://api.github.com/users/peternied/following{/other_user}","gists_url":"https://api.github.com/users/peternied/gists{/gist_id}","starred_url":"https://api.github.com/users/peternied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peternied/subscriptions","organizations_url":"https://api.github.com/users/peternied/orgs","repos_url":"https://api.github.com/users/peternied/repos","events_url":"https://api.github.com/users/peternied/events{/privacy}","received_events_url":"https://api.github.com/users/peternied/received_events","type":"User","site_admin":false},"body":"I'm not clear why you are override methods that you are just calling super on?","created_at":"2016-06-03T17:54:15Z","updated_at":"2016-06-03T17:54:15Z","html_url":"https://github.com/microsoftgraph/msgraph-sdk-android/pull/17#discussion_r65748984","pull_request_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/pulls/comments/65748984"},"html":{"href":"https://github.com/microsoftgraph/msgraph-sdk-android/pull/17#discussion_r65748984"},"pull_request":{"href":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/pulls/17","id":72535773,"html_url":"https://github.com/microsoftgraph/msgraph-sdk-android/pull/17","diff_url":"https://github.com/microsoftgraph/msgraph-sdk-android/pull/17.diff","patch_url":"https://github.com/microsoftgraph/msgraph-sdk-android/pull/17.patch","issue_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/issues/17","number":17,"state":"open","locked":false,"title":"Bug fix and adding unit tests.","user":{"login":"TBag","id":1407310,"avatar_url":"https://avatars.githubusercontent.com/u/1407310?v=3","gravatar_id":"","url":"https://api.github.com/users/TBag","html_url":"https://github.com/TBag","followers_url":"https://api.github.com/users/TBag/followers","following_url":"https://api.github.com/users/TBag/following{/other_user}","gists_url":"https://api.github.com/users/TBag/gists{/gist_id}","starred_url":"https://api.github.com/users/TBag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TBag/subscriptions","organizations_url":"https://api.github.com/users/TBag/orgs","repos_url":"https://api.github.com/users/TBag/repos","events_url":"https://api.github.com/users/TBag/events{/privacy}","received_events_url":"https://api.github.com/users/TBag/received_events","type":"User","site_admin":false},"body":"Commit d38fe22: Bug fix for getOptions function in the BaseRequest class.  Added mFunctionOptions to the LinkedList.  Added unit tests for BaseRequest class.\r\n\r\nCommit b9dde90: Adding unit tests for authentication, concurrency, core, http, logger, options, and serializer.","created_at":"2016-06-03T16:40:52Z","updated_at":"2016-06-03T17:54:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64fe83ed852c84ea9b7ea549dc0a9a47133e0b81","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/pulls/17/commits","review_comments_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/pulls/17/comments","review_comment_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/issues/17/comments","statuses_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/statuses/b9dde90f20e258a51edd40c464482855b8d1e0f2","head":{"label":"TBag:master","ref":"master","sha":"b9dde90f20e258a51edd40c464482855b8d1e0f2","user":{"login":"TBag","id":1407310,"avatar_url":"https://avatars.githubusercontent.com/u/1407310?v=3","gravatar_id":"","url":"https://api.github.com/users/TBag","html_url":"https://github.com/TBag","followers_url":"https://api.github.com/users/TBag/followers","following_url":"https://api.github.com/users/TBag/following{/other_user}","gists_url":"https://api.github.com/users/TBag/gists{/gist_id}","starred_url":"https://api.github.com/users/TBag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TBag/subscriptions","organizations_url":"https://api.github.com/users/TBag/orgs","repos_url":"https://api.github.com/users/TBag/repos","events_url":"https://api.github.com/users/TBag/events{/privacy}","received_events_url":"https://api.github.com/users/TBag/received_events","type":"User","site_admin":false},"repo":{"id":60361545,"name":"msgraph-sdk-android","full_name":"TBag/msgraph-sdk-android","owner":{"login":"TBag","id":1407310,"avatar_url":"https://avatars.githubusercontent.com/u/1407310?v=3","gravatar_id":"","url":"https://api.github.com/users/TBag","html_url":"https://github.com/TBag","followers_url":"https://api.github.com/users/TBag/followers","following_url":"https://api.github.com/users/TBag/following{/other_user}","gists_url":"https://api.github.com/users/TBag/gists{/gist_id}","starred_url":"https://api.github.com/users/TBag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TBag/subscriptions","organizations_url":"https://api.github.com/users/TBag/orgs","repos_url":"https://api.github.com/users/TBag/repos","events_url":"https://api.github.com/users/TBag/events{/privacy}","received_events_url":"https://api.github.com/users/TBag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TBag/msgraph-sdk-android","description":"Microsoft Graph SDK for Android! https://graph.microsoft.io","fork":true,"url":"https://api.github.com/repos/TBag/msgraph-sdk-android","forks_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/forks","keys_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/teams","hooks_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/hooks","issue_events_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/issues/events{/number}","events_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/events","assignees_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/assignees{/user}","branches_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/branches{/branch}","tags_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/tags","blobs_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/statuses/{sha}","languages_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/languages","stargazers_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/stargazers","contributors_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/contributors","subscribers_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/subscribers","subscription_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/subscription","commits_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/contents/{+path}","compare_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/merges","archive_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/downloads","issues_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/issues{/number}","pulls_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/pulls{/number}","milestones_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/milestones{/number}","notifications_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/labels{/name}","releases_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/releases{/id}","deployments_url":"https://api.github.com/repos/TBag/msgraph-sdk-android/deployments","created_at":"2016-06-03T16:18:26Z","updated_at":"2016-06-03T16:18:28Z","pushed_at":"2016-06-03T16:39:12Z","git_url":"git://github.com/TBag/msgraph-sdk-android.git","ssh_url":"git@github.com:TBag/msgraph-sdk-android.git","clone_url":"https://github.com/TBag/msgraph-sdk-android.git","svn_url":"https://github.com/TBag/msgraph-sdk-android","homepage":"","size":377,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"microsoftgraph:master","ref":"master","sha":"19240bde55c4218fb0da1651d37c90bd8062e485","user":{"login":"microsoftgraph","id":17304259,"avatar_url":"https://avatars.githubusercontent.com/u/17304259?v=3","gravatar_id":"","url":"https://api.github.com/users/microsoftgraph","html_url":"https://github.com/microsoftgraph","followers_url":"https://api.github.com/users/microsoftgraph/followers","following_url":"https://api.github.com/users/microsoftgraph/following{/other_user}","gists_url":"https://api.github.com/users/microsoftgraph/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoftgraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoftgraph/subscriptions","organizations_url":"https://api.github.com/users/microsoftgraph/orgs","repos_url":"https://api.github.com/users/microsoftgraph/repos","events_url":"https://api.github.com/users/microsoftgraph/events{/privacy}","received_events_url":"https://api.github.com/users/microsoftgraph/received_events","type":"Organization","site_admin":false},"repo":{"id":53154499,"name":"msgraph-sdk-android","full_name":"microsoftgraph/msgraph-sdk-android","owner":{"login":"microsoftgraph","id":17304259,"avatar_url":"https://avatars.githubusercontent.com/u/17304259?v=3","gravatar_id":"","url":"https://api.github.com/users/microsoftgraph","html_url":"https://github.com/microsoftgraph","followers_url":"https://api.github.com/users/microsoftgraph/followers","following_url":"https://api.github.com/users/microsoftgraph/following{/other_user}","gists_url":"https://api.github.com/users/microsoftgraph/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoftgraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoftgraph/subscriptions","organizations_url":"https://api.github.com/users/microsoftgraph/orgs","repos_url":"https://api.github.com/users/microsoftgraph/repos","events_url":"https://api.github.com/users/microsoftgraph/events{/privacy}","received_events_url":"https://api.github.com/users/microsoftgraph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/microsoftgraph/msgraph-sdk-android","description":"Microsoft Graph SDK for Android! https://graph.microsoft.io","fork":false,"url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android","forks_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/forks","keys_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/teams","hooks_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/hooks","issue_events_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/issues/events{/number}","events_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/events","assignees_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/assignees{/user}","branches_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/branches{/branch}","tags_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/tags","blobs_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/languages","stargazers_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/stargazers","contributors_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/contributors","subscribers_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/subscribers","subscription_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/subscription","commits_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/contents/{+path}","compare_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/merges","archive_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/downloads","issues_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/issues{/number}","pulls_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/labels{/name}","releases_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/releases{/id}","deployments_url":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/deployments","created_at":"2016-03-04T17:48:10Z","updated_at":"2016-03-30T19:42:04Z","pushed_at":"2016-06-03T16:40:52Z","git_url":"git://github.com/microsoftgraph/msgraph-sdk-android.git","ssh_url":"git@github.com:microsoftgraph/msgraph-sdk-android.git","clone_url":"https://github.com/microsoftgraph/msgraph-sdk-android.git","svn_url":"https://github.com/microsoftgraph/msgraph-sdk-android","homepage":"","size":400,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/pulls/17"},"html":{"href":"https://github.com/microsoftgraph/msgraph-sdk-android/pull/17"},"issue":{"href":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/issues/17"},"comments":{"href":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/microsoftgraph/msgraph-sdk-android/statuses/b9dde90f20e258a51edd40c464482855b8d1e0f2"}}}}
{"actor":{"display_login":"peternied"}}