{"action":"created","issue":{"url":"https://api.github.com/repos/hydrogen-music/hydrogen/issues/409","repository_url":"https://api.github.com/repos/hydrogen-music/hydrogen","labels_url":"https://api.github.com/repos/hydrogen-music/hydrogen/issues/409/labels{/name}","comments_url":"https://api.github.com/repos/hydrogen-music/hydrogen/issues/409/comments","events_url":"https://api.github.com/repos/hydrogen-music/hydrogen/issues/409/events","html_url":"https://github.com/hydrogen-music/hydrogen/pull/409","id":175129768,"number":409,"title":"Qt5 port","user":{"login":"elpescado","id":1619113,"avatar_url":"https://avatars.githubusercontent.com/u/1619113?v=3","gravatar_id":"","url":"https://api.github.com/users/elpescado","html_url":"https://github.com/elpescado","followers_url":"https://api.github.com/users/elpescado/followers","following_url":"https://api.github.com/users/elpescado/following{/other_user}","gists_url":"https://api.github.com/users/elpescado/gists{/gist_id}","starred_url":"https://api.github.com/users/elpescado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elpescado/subscriptions","organizations_url":"https://api.github.com/users/elpescado/orgs","repos_url":"https://api.github.com/users/elpescado/repos","events_url":"https://api.github.com/users/elpescado/events{/privacy}","received_events_url":"https://api.github.com/users/elpescado/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-05T21:42:04Z","updated_at":"2016-09-06T18:40:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hydrogen-music/hydrogen/pulls/409","html_url":"https://github.com/hydrogen-music/hydrogen/pull/409","diff_url":"https://github.com/hydrogen-music/hydrogen/pull/409.diff","patch_url":"https://github.com/hydrogen-music/hydrogen/pull/409.patch"},"body":"This branch adds compile time option to use Qt5. Qt5 support is optinal and by default off. To enable, `-DWANT_QT5=1` option has to be passed to `cmake`. This branch is pretty rudimentary - it does only the necessary changes required to compile with Qt5. I hadn't had time to test Qt5 build thoroughly - so I consider it \"buildable\", not \"working\". Qt4 build shouldn't be affected.\r\n\r\nI have tested this branch on Mac and Debian, both Qt4 (4.8.6) and Qt5 (5.6.1).\r\n\r\nOne issue I have noticed is that Plastique, default hteme used by Hydrogen is missing in Qt5, so Hydrogen looks a little weird. Changing theme to Fusion fixes this.\r\n\r\nI'd be grateful for testing this branch.\r\n\r\nRegards,\r\nPrzemek\r\n\r\nPS. I might be unavailable for the next 2-3 weeks."},"comment":{"url":"https://api.github.com/repos/hydrogen-music/hydrogen/issues/comments/245048065","html_url":"https://github.com/hydrogen-music/hydrogen/pull/409#issuecomment-245048065","issue_url":"https://api.github.com/repos/hydrogen-music/hydrogen/issues/409","id":245048065,"user":{"login":"mauser","id":202461,"avatar_url":"https://avatars.githubusercontent.com/u/202461?v=3","gravatar_id":"","url":"https://api.github.com/users/mauser","html_url":"https://github.com/mauser","followers_url":"https://api.github.com/users/mauser/followers","following_url":"https://api.github.com/users/mauser/following{/other_user}","gists_url":"https://api.github.com/users/mauser/gists{/gist_id}","starred_url":"https://api.github.com/users/mauser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauser/subscriptions","organizations_url":"https://api.github.com/users/mauser/orgs","repos_url":"https://api.github.com/users/mauser/repos","events_url":"https://api.github.com/users/mauser/events{/privacy}","received_events_url":"https://api.github.com/users/mauser/received_events","type":"User","site_admin":false},"created_at":"2016-09-06T18:40:34Z","updated_at":"2016-09-06T18:40:34Z","body":"Hi! \r\n\r\nPerfect! \r\nApart from the theme-problems you mentioned everything works for me. Did you make the QT5 support optional only for testing or is there a reason why we should keep that optional in the future? \r\n\r\nUntil now my thought was that we go qt5-only with Hydrogen 0.9.8. Especially since it is hard to avoid problems when using qt5-only methods.."}}
{"actor":{"display_login":"mauser"}}