{"action":"created","issue":{"url":"https://api.github.com/repos/opencontainers/runc/issues/470","labels_url":"https://api.github.com/repos/opencontainers/runc/issues/470/labels{/name}","comments_url":"https://api.github.com/repos/opencontainers/runc/issues/470/comments","events_url":"https://api.github.com/repos/opencontainers/runc/issues/470/events","html_url":"https://github.com/opencontainers/runc/pull/470","id":126392569,"number":470,"title":"fix failing Docker tests","user":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/opencontainers/runc/labels/status/0-triage","name":"status/0-triage","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-13T10:53:34Z","updated_at":"2016-01-13T14:44:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/470","html_url":"https://github.com/opencontainers/runc/pull/470","diff_url":"https://github.com/opencontainers/runc/pull/470.diff","patch_url":"https://github.com/opencontainers/runc/pull/470.patch"},"body":"There are two sets of tests failing with the current state of `runc`, and this PR solves both of these.\r\n\r\n1. Containers don't seem to be killed properly, causing a bunch of tests using `docker ps` to fail. This was caused by @crosbymichael's commit `fa24ebf26c0a0c26880bd8375b81df8f91a0bbb4`.\r\n2. Updating a container's state doesn't work for the memory cgroup, causing `docker update` tests to fail. This was caused by my commit `f36ed4b174bb7e8951db6b61e2202a45a7251e30`.\r\n\r\nBoth of these cases are solved here, and we should merge this in order to vendor `libcontainer` into `docker`."},"comment":{"url":"https://api.github.com/repos/opencontainers/runc/issues/comments/171313002","html_url":"https://github.com/opencontainers/runc/pull/470#issuecomment-171313002","issue_url":"https://api.github.com/repos/opencontainers/runc/issues/470","id":171313002,"user":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"created_at":"2016-01-13T14:44:48Z","updated_at":"2016-01-13T14:44:48Z","body":"The tests now pass on Docker `master` (as evidenced in the current state of the testbed PR docker/docker#19250).\r\n\r\n/ping @crosbymichael @mrunalp @dqminh @LK4D4 "}}