{"action":"created","issue":{"url":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/4198","repository_url":"https://api.github.com/repos/tomchristie/django-rest-framework","labels_url":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/4198/labels{/name}","comments_url":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/4198/comments","events_url":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/4198/events","html_url":"https://github.com/tomchristie/django-rest-framework/issues/4198","id":160210486,"number":4198,"title":"Always defer to explicit overrides.","user":{"login":"tomchristie","id":647359,"avatar_url":"https://avatars.githubusercontent.com/u/647359?v=3","gravatar_id":"","url":"https://api.github.com/users/tomchristie","html_url":"https://github.com/tomchristie","followers_url":"https://api.github.com/users/tomchristie/followers","following_url":"https://api.github.com/users/tomchristie/following{/other_user}","gists_url":"https://api.github.com/users/tomchristie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomchristie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomchristie/subscriptions","organizations_url":"https://api.github.com/users/tomchristie/orgs","repos_url":"https://api.github.com/users/tomchristie/repos","events_url":"https://api.github.com/users/tomchristie/events{/privacy}","received_events_url":"https://api.github.com/users/tomchristie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/tomchristie/django-rest-framework/milestones/35","html_url":"https://github.com/tomchristie/django-rest-framework/milestones/3.4.0%20Release","labels_url":"https://api.github.com/repos/tomchristie/django-rest-framework/milestones/35/labels","id":1381458,"number":35,"title":"3.4.0 Release","description":"","creator":{"login":"tomchristie","id":647359,"avatar_url":"https://avatars.githubusercontent.com/u/647359?v=3","gravatar_id":"","url":"https://api.github.com/users/tomchristie","html_url":"https://github.com/tomchristie","followers_url":"https://api.github.com/users/tomchristie/followers","following_url":"https://api.github.com/users/tomchristie/following{/other_user}","gists_url":"https://api.github.com/users/tomchristie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomchristie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomchristie/subscriptions","organizations_url":"https://api.github.com/users/tomchristie/orgs","repos_url":"https://api.github.com/users/tomchristie/repos","events_url":"https://api.github.com/users/tomchristie/events{/privacy}","received_events_url":"https://api.github.com/users/tomchristie/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":65,"state":"open","created_at":"2015-10-28T13:51:54Z","updated_at":"2016-06-14T15:24:43Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-06-14T15:24:41Z","updated_at":"2016-06-15T09:39:11Z","closed_at":null,"body":"Some of these may already be covered, but we should make sure that all the following are satisfied:\r\n\r\n* If a user declares a field explicitly, but also includes it in `extra_kwargs` then warn/error.\r\n* If a user declares a field explicitly, but also includes it in `read_only_fields` then warn/error.\r\n* Don't allow `get_uniqueness_extra_kwargs` to override a declared field.\r\n* Don't allow `get_uniqueness_extra_kwargs` to override a flag that has been set in `extra_kwargs`.\r\n* If a serializer field has a `default`, then ensure that uniqueness validators use that for empty, rather than forcing `required=True` \r\n"},"comment":{"url":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/comments/226138045","html_url":"https://github.com/tomchristie/django-rest-framework/issues/4198#issuecomment-226138045","issue_url":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/4198","id":226138045,"user":{"login":"gcbirzan","id":784229,"avatar_url":"https://avatars.githubusercontent.com/u/784229?v=3","gravatar_id":"","url":"https://api.github.com/users/gcbirzan","html_url":"https://github.com/gcbirzan","followers_url":"https://api.github.com/users/gcbirzan/followers","following_url":"https://api.github.com/users/gcbirzan/following{/other_user}","gists_url":"https://api.github.com/users/gcbirzan/gists{/gist_id}","starred_url":"https://api.github.com/users/gcbirzan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcbirzan/subscriptions","organizations_url":"https://api.github.com/users/gcbirzan/orgs","repos_url":"https://api.github.com/users/gcbirzan/repos","events_url":"https://api.github.com/users/gcbirzan/events{/privacy}","received_events_url":"https://api.github.com/users/gcbirzan/received_events","type":"User","site_admin":false},"created_at":"2016-06-15T09:39:11Z","updated_at":"2016-06-15T09:39:11Z","body":"> * Don't allow get_uniqueness_extra_kwargs to override a declared field.\r\n\r\n\r\nThis already happens, a declared field will not be re-declared with new args.\r\n\r\n> * If a serializer field has a default, then ensure that uniqueness validators use that for empty, rather than forcing required=True\r\n\r\nA default of None on a declared field will work for uniqueness validation.\r\n\r\n"}}
{"actor":{"display_login":"gcbirzan"}}