{"action":"opened","number":437,"pull_request":{"url":"https://api.github.com/repos/alphagov/gds-api-adapters/pulls/437","id":59023230,"html_url":"https://github.com/alphagov/gds-api-adapters/pull/437","diff_url":"https://github.com/alphagov/gds-api-adapters/pull/437.diff","patch_url":"https://github.com/alphagov/gds-api-adapters/pull/437.patch","issue_url":"https://api.github.com/repos/alphagov/gds-api-adapters/issues/437","number":437,"state":"open","locked":false,"title":"Don't test for request body if the argument is not supplied","user":{"login":"tijmenb","id":233676,"avatar_url":"https://avatars.githubusercontent.com/u/233676?v=3","gravatar_id":"","url":"https://api.github.com/users/tijmenb","html_url":"https://github.com/tijmenb","followers_url":"https://api.github.com/users/tijmenb/followers","following_url":"https://api.github.com/users/tijmenb/following{/other_user}","gists_url":"https://api.github.com/users/tijmenb/gists{/gist_id}","starred_url":"https://api.github.com/users/tijmenb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tijmenb/subscriptions","organizations_url":"https://api.github.com/users/tijmenb/orgs","repos_url":"https://api.github.com/users/tijmenb/repos","events_url":"https://api.github.com/users/tijmenb/events{/privacy}","received_events_url":"https://api.github.com/users/tijmenb/received_events","type":"User","site_admin":false},"body":"The default empty hash argument for `attributes_or_matcher` means\r\nthat the assertion only passes when the client has sent an empty hash to\r\nthe publishing-api.\r\n\r\nIn most cases where the second argument is not supplied, we don't care\r\nabout the payload. Webmock will not test the request body if it is nil.\r\n\r\nTo summarise, after this change:\r\n\r\n`assert_publishing_api_put_links(content_id)` will pass with any body\r\n`assert_publishing_api_put_links(content_id, {})` will only pass if the\r\nbody is empty\r\n","created_at":"2016-02-11T12:20:31Z","updated_at":"2016-02-11T12:20:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/gds-api-adapters/pulls/437/commits","review_comments_url":"https://api.github.com/repos/alphagov/gds-api-adapters/pulls/437/comments","review_comment_url":"https://api.github.com/repos/alphagov/gds-api-adapters/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/gds-api-adapters/issues/437/comments","statuses_url":"https://api.github.com/repos/alphagov/gds-api-adapters/statuses/cf6c37c2f76edfa625224d4445aed45325b505b5","head":{"label":"alphagov:dont-test-post-body","ref":"dont-test-post-body","sha":"cf6c37c2f76edfa625224d4445aed45325b505b5","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":2898846,"name":"gds-api-adapters","full_name":"alphagov/gds-api-adapters","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/gds-api-adapters","description":"A set of API adapters to work with the GDS APIs","fork":false,"url":"https://api.github.com/repos/alphagov/gds-api-adapters","forks_url":"https://api.github.com/repos/alphagov/gds-api-adapters/forks","keys_url":"https://api.github.com/repos/alphagov/gds-api-adapters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/gds-api-adapters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/gds-api-adapters/teams","hooks_url":"https://api.github.com/repos/alphagov/gds-api-adapters/hooks","issue_events_url":"https://api.github.com/repos/alphagov/gds-api-adapters/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/gds-api-adapters/events","assignees_url":"https://api.github.com/repos/alphagov/gds-api-adapters/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/gds-api-adapters/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/gds-api-adapters/tags","blobs_url":"https://api.github.com/repos/alphagov/gds-api-adapters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/gds-api-adapters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/gds-api-adapters/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/gds-api-adapters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/gds-api-adapters/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/gds-api-adapters/languages","stargazers_url":"https://api.github.com/repos/alphagov/gds-api-adapters/stargazers","contributors_url":"https://api.github.com/repos/alphagov/gds-api-adapters/contributors","subscribers_url":"https://api.github.com/repos/alphagov/gds-api-adapters/subscribers","subscription_url":"https://api.github.com/repos/alphagov/gds-api-adapters/subscription","commits_url":"https://api.github.com/repos/alphagov/gds-api-adapters/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/gds-api-adapters/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/gds-api-adapters/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/gds-api-adapters/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/gds-api-adapters/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/gds-api-adapters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/gds-api-adapters/merges","archive_url":"https://api.github.com/repos/alphagov/gds-api-adapters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/gds-api-adapters/downloads","issues_url":"https://api.github.com/repos/alphagov/gds-api-adapters/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/gds-api-adapters/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/gds-api-adapters/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/gds-api-adapters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/gds-api-adapters/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/gds-api-adapters/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/gds-api-adapters/deployments","created_at":"2011-12-02T14:13:57Z","updated_at":"2015-12-01T12:06:46Z","pushed_at":"2016-02-11T12:20:31Z","git_url":"git://github.com/alphagov/gds-api-adapters.git","ssh_url":"git@github.com:alphagov/gds-api-adapters.git","clone_url":"https://github.com/alphagov/gds-api-adapters.git","svn_url":"https://github.com/alphagov/gds-api-adapters","homepage":"","size":1370,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":6,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"076240dc7a88e4f459394d97962a0088188ca4cc","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":2898846,"name":"gds-api-adapters","full_name":"alphagov/gds-api-adapters","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/gds-api-adapters","description":"A set of API adapters to work with the GDS APIs","fork":false,"url":"https://api.github.com/repos/alphagov/gds-api-adapters","forks_url":"https://api.github.com/repos/alphagov/gds-api-adapters/forks","keys_url":"https://api.github.com/repos/alphagov/gds-api-adapters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/gds-api-adapters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/gds-api-adapters/teams","hooks_url":"https://api.github.com/repos/alphagov/gds-api-adapters/hooks","issue_events_url":"https://api.github.com/repos/alphagov/gds-api-adapters/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/gds-api-adapters/events","assignees_url":"https://api.github.com/repos/alphagov/gds-api-adapters/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/gds-api-adapters/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/gds-api-adapters/tags","blobs_url":"https://api.github.com/repos/alphagov/gds-api-adapters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/gds-api-adapters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/gds-api-adapters/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/gds-api-adapters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/gds-api-adapters/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/gds-api-adapters/languages","stargazers_url":"https://api.github.com/repos/alphagov/gds-api-adapters/stargazers","contributors_url":"https://api.github.com/repos/alphagov/gds-api-adapters/contributors","subscribers_url":"https://api.github.com/repos/alphagov/gds-api-adapters/subscribers","subscription_url":"https://api.github.com/repos/alphagov/gds-api-adapters/subscription","commits_url":"https://api.github.com/repos/alphagov/gds-api-adapters/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/gds-api-adapters/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/gds-api-adapters/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/gds-api-adapters/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/gds-api-adapters/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/gds-api-adapters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/gds-api-adapters/merges","archive_url":"https://api.github.com/repos/alphagov/gds-api-adapters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/gds-api-adapters/downloads","issues_url":"https://api.github.com/repos/alphagov/gds-api-adapters/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/gds-api-adapters/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/gds-api-adapters/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/gds-api-adapters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/gds-api-adapters/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/gds-api-adapters/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/gds-api-adapters/deployments","created_at":"2011-12-02T14:13:57Z","updated_at":"2015-12-01T12:06:46Z","pushed_at":"2016-02-11T12:20:31Z","git_url":"git://github.com/alphagov/gds-api-adapters.git","ssh_url":"git@github.com:alphagov/gds-api-adapters.git","clone_url":"https://github.com/alphagov/gds-api-adapters.git","svn_url":"https://github.com/alphagov/gds-api-adapters","homepage":"","size":1370,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/gds-api-adapters/pulls/437"},"html":{"href":"https://github.com/alphagov/gds-api-adapters/pull/437"},"issue":{"href":"https://api.github.com/repos/alphagov/gds-api-adapters/issues/437"},"comments":{"href":"https://api.github.com/repos/alphagov/gds-api-adapters/issues/437/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/gds-api-adapters/pulls/437/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/gds-api-adapters/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/gds-api-adapters/pulls/437/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/gds-api-adapters/statuses/cf6c37c2f76edfa625224d4445aed45325b505b5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":4,"changed_files":1}}