{"action":"created","issue":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/36979","repository_url":"https://api.github.com/repos/brianchandotcom/liferay-portal","labels_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/36979/labels{/name}","comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/36979/comments","events_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/36979/events","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/36979","id":137985832,"number":36979,"title":"Lps 63538","user":{"login":"shuyangzhou","id":173369,"avatar_url":"https://avatars.githubusercontent.com/u/173369?v=3","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-03-02T20:37:20Z","updated_at":"2016-03-03T05:17:14Z","closed_at":"2016-03-03T05:17:14Z","pull_request":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/36979","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/36979","diff_url":"https://github.com/brianchandotcom/liferay-portal/pull/36979.diff","patch_url":"https://github.com/brianchandotcom/liferay-portal/pull/36979.patch"},"body":"CC @cgoncas @migue I have not really test this, as I don't have any old 606 db with real data. Please run some test on your side, thanks!\r\n\r\nLet me know if anything is broken, I can deal with it."},"comment":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/comments/191588913","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/36979#issuecomment-191588913","issue_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/36979","id":191588913,"user":{"login":"brianchandotcom","id":282080,"avatar_url":"https://avatars.githubusercontent.com/u/282080?v=3","gravatar_id":"","url":"https://api.github.com/users/brianchandotcom","html_url":"https://github.com/brianchandotcom","followers_url":"https://api.github.com/users/brianchandotcom/followers","following_url":"https://api.github.com/users/brianchandotcom/following{/other_user}","gists_url":"https://api.github.com/users/brianchandotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/brianchandotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianchandotcom/subscriptions","organizations_url":"https://api.github.com/users/brianchandotcom/orgs","repos_url":"https://api.github.com/users/brianchandotcom/repos","events_url":"https://api.github.com/users/brianchandotcom/events{/privacy}","received_events_url":"https://api.github.com/users/brianchandotcom/received_events","type":"User","site_admin":false},"created_at":"2016-03-03T05:17:14Z","updated_at":"2016-03-03T05:17:14Z","body":"@cgoncas can you resend on top of https://github.com/cgoncas/liferay-portal/pull/198\r\n\r\n1.) can we remove portal-impl/src/com/liferay/portal/service/impl/RoleClassNameThreadLocal.java\r\n\r\nI don't see it used anywhere\r\n\r\n2.) Can you move portal-impl/src/com/liferay/portal/upgrade/ServiceWrapperProxyUtil.java out of upgrade? It's more a Spring or service wrapper util that the upgrade happens to use.\r\n\r\n3.) can you move portal-impl/src/resource-actions/portal-6.1.0.xml into upgrade/v6_1_0/dependencies/** I think we do that somewhere already, and you can call it resource-actions.xml \r\n\r\nPlease test and resend? Thx."}}