{"action":"created","comment":{"url":"https://api.github.com/repos/fusor/fusor/pulls/comments/49121393","id":49121393,"diff_hunk":"@@ -27,35 +29,68 @@ export default Ember.Controller.extend(NeedsDeploymentMixin, {\n   hasEngine: Ember.computed.alias('deploymentController.hasEngine'),\n   hasNoEngine: Ember.computed.not('hasEngine'),\n \n-  hasHypervisor: Ember.computed('deploymentController.model.discovered_hosts.[]', function() {\n-    return (this.get('deploymentController.model.discovered_hosts.length') > 0);\n-  }),\n+  hasHypervisor: Ember.computed(\n+    'deploymentController.model.discovered_hosts.[]',\n+    function() {\n+      return (this.get('deploymentController.model.discovered_hosts.length') > 0);\n+    }\n+  ),\n   hasNoHypervisor: Ember.computed.not('hasHypervisor'),\n \n+  isEngineHostnameValid: Ember.computed.not('engineDiscoveredHostController.isHostnameInvalid'),\n+  isHypervisorHostnameValid: Ember.computed.not('hypervisorDiscoveredHostController.isHostnameInvalid'),\n+  \n+\n   disableTabRhevHypervisors: Ember.computed(\n-    'deploymentController.model.rhev_is_self_hosted',\n-    'hasNoEngine',\n+    'isSelfHost',\n+    'validRhevEngine',\n     function() {\n-      return (!this.get('deploymentController.model.rhev_is_self_hosted') && this.get('hasNoEngine'));\n+      return (!this.get('isSelfHost') && !this.get('validRhevEngine'));\n     }\n   ),\n \n   disableTabRhevConfiguration: Ember.computed(\n-    'deploymentController.model.rhev_is_self_hosted',\n-    'hasNoEngine',\n-    'hasNoHypervisor',\n+    'isSelfHost',\n+    'validRhevEngine',\n+    'validRhevHypervisor',\n     function() {\n-      return ((this.get('deploymentController.model.rhev_is_self_hosted') && this.get('hasNoEngine')) ||\n-              (!this.get('deploymentController.model.rhev_is_self_hosted') && this.get('hasNoHypervisor'))\n-             );\n+      if (this.get('invalidRhevEngine')) {","path":"fusor-ember-cli/app/controllers/rhev.js","position":50,"original_position":50,"commit_id":"472914e87d9e0524bbeeff5e49c9e7adb5368111","original_commit_id":"472914e87d9e0524bbeeff5e49c9e7adb5368111","user":{"login":"cfchase","id":1448375,"avatar_url":"https://avatars.githubusercontent.com/u/1448375?v=3","gravatar_id":"","url":"https://api.github.com/users/cfchase","html_url":"https://github.com/cfchase","followers_url":"https://api.github.com/users/cfchase/followers","following_url":"https://api.github.com/users/cfchase/following{/other_user}","gists_url":"https://api.github.com/users/cfchase/gists{/gist_id}","starred_url":"https://api.github.com/users/cfchase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfchase/subscriptions","organizations_url":"https://api.github.com/users/cfchase/orgs","repos_url":"https://api.github.com/users/cfchase/repos","events_url":"https://api.github.com/users/cfchase/events{/privacy}","received_events_url":"https://api.github.com/users/cfchase/received_events","type":"User","site_admin":false},"body":"this is watching validRhevEngine but using invalidRhevEngine, which is a bit weird.  I think it could maybe have been:\r\n\r\n```javascript\r\nif (this.get('validRhevEngine')) {\r\n    return !this.get('isSelfHost') && this.get('invalidRhevHypervisor');\r\n}\r\nreturn true;\r\n```","created_at":"2016-01-07T20:25:36Z","updated_at":"2016-01-07T20:25:36Z","html_url":"https://github.com/fusor/fusor/pull/596#discussion_r49121393","pull_request_url":"https://api.github.com/repos/fusor/fusor/pulls/596","_links":{"self":{"href":"https://api.github.com/repos/fusor/fusor/pulls/comments/49121393"},"html":{"href":"https://github.com/fusor/fusor/pull/596#discussion_r49121393"},"pull_request":{"href":"https://api.github.com/repos/fusor/fusor/pulls/596"}}},"pull_request":{"url":"https://api.github.com/repos/fusor/fusor/pulls/596","id":55000029,"html_url":"https://github.com/fusor/fusor/pull/596","diff_url":"https://github.com/fusor/fusor/pull/596.diff","patch_url":"https://github.com/fusor/fusor/pull/596.patch","issue_url":"https://api.github.com/repos/fusor/fusor/issues/596","number":596,"state":"open","locked":false,"title":"1280423 - Invalid hostnames disable user's ability to continue","user":{"login":"dymurray","id":16140195,"avatar_url":"https://avatars.githubusercontent.com/u/16140195?v=3","gravatar_id":"","url":"https://api.github.com/users/dymurray","html_url":"https://github.com/dymurray","followers_url":"https://api.github.com/users/dymurray/followers","following_url":"https://api.github.com/users/dymurray/following{/other_user}","gists_url":"https://api.github.com/users/dymurray/gists{/gist_id}","starred_url":"https://api.github.com/users/dymurray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dymurray/subscriptions","organizations_url":"https://api.github.com/users/dymurray/orgs","repos_url":"https://api.github.com/users/dymurray/repos","events_url":"https://api.github.com/users/dymurray/events{/privacy}","received_events_url":"https://api.github.com/users/dymurray/received_events","type":"User","site_admin":false},"body":"When the host name for the engine or hypervisor is changed, the 'next' button and associated tab it will go to is grayed out whenever the host name is invalid.","created_at":"2016-01-04T17:29:15Z","updated_at":"2016-01-07T20:25:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58e4a8822d34e6ba1b1993debdf0fcf7e89781b1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fusor/fusor/pulls/596/commits","review_comments_url":"https://api.github.com/repos/fusor/fusor/pulls/596/comments","review_comment_url":"https://api.github.com/repos/fusor/fusor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fusor/fusor/issues/596/comments","statuses_url":"https://api.github.com/repos/fusor/fusor/statuses/472914e87d9e0524bbeeff5e49c9e7adb5368111","head":{"label":"dymurray:bz1280423","ref":"bz1280423","sha":"472914e87d9e0524bbeeff5e49c9e7adb5368111","user":{"login":"dymurray","id":16140195,"avatar_url":"https://avatars.githubusercontent.com/u/16140195?v=3","gravatar_id":"","url":"https://api.github.com/users/dymurray","html_url":"https://github.com/dymurray","followers_url":"https://api.github.com/users/dymurray/followers","following_url":"https://api.github.com/users/dymurray/following{/other_user}","gists_url":"https://api.github.com/users/dymurray/gists{/gist_id}","starred_url":"https://api.github.com/users/dymurray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dymurray/subscriptions","organizations_url":"https://api.github.com/users/dymurray/orgs","repos_url":"https://api.github.com/users/dymurray/repos","events_url":"https://api.github.com/users/dymurray/events{/privacy}","received_events_url":"https://api.github.com/users/dymurray/received_events","type":"User","site_admin":false},"repo":{"id":47559192,"name":"fusor","full_name":"dymurray/fusor","owner":{"login":"dymurray","id":16140195,"avatar_url":"https://avatars.githubusercontent.com/u/16140195?v=3","gravatar_id":"","url":"https://api.github.com/users/dymurray","html_url":"https://github.com/dymurray","followers_url":"https://api.github.com/users/dymurray/followers","following_url":"https://api.github.com/users/dymurray/following{/other_user}","gists_url":"https://api.github.com/users/dymurray/gists{/gist_id}","starred_url":"https://api.github.com/users/dymurray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dymurray/subscriptions","organizations_url":"https://api.github.com/users/dymurray/orgs","repos_url":"https://api.github.com/users/dymurray/repos","events_url":"https://api.github.com/users/dymurray/events{/privacy}","received_events_url":"https://api.github.com/users/dymurray/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dymurray/fusor","description":"","fork":true,"url":"https://api.github.com/repos/dymurray/fusor","forks_url":"https://api.github.com/repos/dymurray/fusor/forks","keys_url":"https://api.github.com/repos/dymurray/fusor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dymurray/fusor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dymurray/fusor/teams","hooks_url":"https://api.github.com/repos/dymurray/fusor/hooks","issue_events_url":"https://api.github.com/repos/dymurray/fusor/issues/events{/number}","events_url":"https://api.github.com/repos/dymurray/fusor/events","assignees_url":"https://api.github.com/repos/dymurray/fusor/assignees{/user}","branches_url":"https://api.github.com/repos/dymurray/fusor/branches{/branch}","tags_url":"https://api.github.com/repos/dymurray/fusor/tags","blobs_url":"https://api.github.com/repos/dymurray/fusor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dymurray/fusor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dymurray/fusor/git/refs{/sha}","trees_url":"https://api.github.com/repos/dymurray/fusor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dymurray/fusor/statuses/{sha}","languages_url":"https://api.github.com/repos/dymurray/fusor/languages","stargazers_url":"https://api.github.com/repos/dymurray/fusor/stargazers","contributors_url":"https://api.github.com/repos/dymurray/fusor/contributors","subscribers_url":"https://api.github.com/repos/dymurray/fusor/subscribers","subscription_url":"https://api.github.com/repos/dymurray/fusor/subscription","commits_url":"https://api.github.com/repos/dymurray/fusor/commits{/sha}","git_commits_url":"https://api.github.com/repos/dymurray/fusor/git/commits{/sha}","comments_url":"https://api.github.com/repos/dymurray/fusor/comments{/number}","issue_comment_url":"https://api.github.com/repos/dymurray/fusor/issues/comments{/number}","contents_url":"https://api.github.com/repos/dymurray/fusor/contents/{+path}","compare_url":"https://api.github.com/repos/dymurray/fusor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dymurray/fusor/merges","archive_url":"https://api.github.com/repos/dymurray/fusor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dymurray/fusor/downloads","issues_url":"https://api.github.com/repos/dymurray/fusor/issues{/number}","pulls_url":"https://api.github.com/repos/dymurray/fusor/pulls{/number}","milestones_url":"https://api.github.com/repos/dymurray/fusor/milestones{/number}","notifications_url":"https://api.github.com/repos/dymurray/fusor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dymurray/fusor/labels{/name}","releases_url":"https://api.github.com/repos/dymurray/fusor/releases{/id}","created_at":"2015-12-07T15:04:30Z","updated_at":"2015-12-07T15:04:31Z","pushed_at":"2016-01-07T20:18:46Z","git_url":"git://github.com/dymurray/fusor.git","ssh_url":"git@github.com:dymurray/fusor.git","clone_url":"https://github.com/dymurray/fusor.git","svn_url":"https://github.com/dymurray/fusor","homepage":null,"size":23219,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fusor:master","ref":"master","sha":"6794436e6f2f690e45b17261e3eb1de6779dcc1c","user":{"login":"fusor","id":9267379,"avatar_url":"https://avatars.githubusercontent.com/u/9267379?v=3","gravatar_id":"","url":"https://api.github.com/users/fusor","html_url":"https://github.com/fusor","followers_url":"https://api.github.com/users/fusor/followers","following_url":"https://api.github.com/users/fusor/following{/other_user}","gists_url":"https://api.github.com/users/fusor/gists{/gist_id}","starred_url":"https://api.github.com/users/fusor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fusor/subscriptions","organizations_url":"https://api.github.com/users/fusor/orgs","repos_url":"https://api.github.com/users/fusor/repos","events_url":"https://api.github.com/users/fusor/events{/privacy}","received_events_url":"https://api.github.com/users/fusor/received_events","type":"Organization","site_admin":false},"repo":{"id":25686301,"name":"fusor","full_name":"fusor/fusor","owner":{"login":"fusor","id":9267379,"avatar_url":"https://avatars.githubusercontent.com/u/9267379?v=3","gravatar_id":"","url":"https://api.github.com/users/fusor","html_url":"https://github.com/fusor","followers_url":"https://api.github.com/users/fusor/followers","following_url":"https://api.github.com/users/fusor/following{/other_user}","gists_url":"https://api.github.com/users/fusor/gists{/gist_id}","starred_url":"https://api.github.com/users/fusor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fusor/subscriptions","organizations_url":"https://api.github.com/users/fusor/orgs","repos_url":"https://api.github.com/users/fusor/repos","events_url":"https://api.github.com/users/fusor/events{/privacy}","received_events_url":"https://api.github.com/users/fusor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fusor/fusor","description":"","fork":false,"url":"https://api.github.com/repos/fusor/fusor","forks_url":"https://api.github.com/repos/fusor/fusor/forks","keys_url":"https://api.github.com/repos/fusor/fusor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fusor/fusor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fusor/fusor/teams","hooks_url":"https://api.github.com/repos/fusor/fusor/hooks","issue_events_url":"https://api.github.com/repos/fusor/fusor/issues/events{/number}","events_url":"https://api.github.com/repos/fusor/fusor/events","assignees_url":"https://api.github.com/repos/fusor/fusor/assignees{/user}","branches_url":"https://api.github.com/repos/fusor/fusor/branches{/branch}","tags_url":"https://api.github.com/repos/fusor/fusor/tags","blobs_url":"https://api.github.com/repos/fusor/fusor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fusor/fusor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fusor/fusor/git/refs{/sha}","trees_url":"https://api.github.com/repos/fusor/fusor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fusor/fusor/statuses/{sha}","languages_url":"https://api.github.com/repos/fusor/fusor/languages","stargazers_url":"https://api.github.com/repos/fusor/fusor/stargazers","contributors_url":"https://api.github.com/repos/fusor/fusor/contributors","subscribers_url":"https://api.github.com/repos/fusor/fusor/subscribers","subscription_url":"https://api.github.com/repos/fusor/fusor/subscription","commits_url":"https://api.github.com/repos/fusor/fusor/commits{/sha}","git_commits_url":"https://api.github.com/repos/fusor/fusor/git/commits{/sha}","comments_url":"https://api.github.com/repos/fusor/fusor/comments{/number}","issue_comment_url":"https://api.github.com/repos/fusor/fusor/issues/comments{/number}","contents_url":"https://api.github.com/repos/fusor/fusor/contents/{+path}","compare_url":"https://api.github.com/repos/fusor/fusor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fusor/fusor/merges","archive_url":"https://api.github.com/repos/fusor/fusor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fusor/fusor/downloads","issues_url":"https://api.github.com/repos/fusor/fusor/issues{/number}","pulls_url":"https://api.github.com/repos/fusor/fusor/pulls{/number}","milestones_url":"https://api.github.com/repos/fusor/fusor/milestones{/number}","notifications_url":"https://api.github.com/repos/fusor/fusor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fusor/fusor/labels{/name}","releases_url":"https://api.github.com/repos/fusor/fusor/releases{/id}","created_at":"2014-10-24T11:57:40Z","updated_at":"2015-12-22T19:30:24Z","pushed_at":"2016-01-07T20:18:46Z","git_url":"git://github.com/fusor/fusor.git","ssh_url":"git@github.com:fusor/fusor.git","clone_url":"https://github.com/fusor/fusor.git","svn_url":"https://github.com/fusor/fusor","homepage":null,"size":25036,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":4,"forks":20,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fusor/fusor/pulls/596"},"html":{"href":"https://github.com/fusor/fusor/pull/596"},"issue":{"href":"https://api.github.com/repos/fusor/fusor/issues/596"},"comments":{"href":"https://api.github.com/repos/fusor/fusor/issues/596/comments"},"review_comments":{"href":"https://api.github.com/repos/fusor/fusor/pulls/596/comments"},"review_comment":{"href":"https://api.github.com/repos/fusor/fusor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fusor/fusor/pulls/596/commits"},"statuses":{"href":"https://api.github.com/repos/fusor/fusor/statuses/472914e87d9e0524bbeeff5e49c9e7adb5368111"}}}}