{"action":"created","comment":{"url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/pulls/comments/89478219","pull_request_review_id":10022955,"id":89478219,"diff_hunk":"@@ -99,20 +99,17 @@ def student_view(self, context):\n             if hotspot.feedback.youtube:\n                 has_youtube = True\n \n-        sprite_url = self.runtime.local_resource_url(self, 'public/images/hotspot-sprite.png')\n-\n         context = {\n             'title': self.display_name,\n             'description_html': description,\n             'hotspots': hotspots,\n             'background': background,\n-            'sprite_url': sprite_url,\n         }\n \n         fragment = Fragment()\n         fragment.add_content(loader.render_template('/templates/html/image_explorer.html', context))\n-        fragment.add_css(loader.load_unicode('public/css/image_explorer.css'))\n-        fragment.add_javascript(loader.load_unicode('public/js/image_explorer.js'))\n+        fragment.add_css_url(self.runtime.local_resource_url(self, 'public/css/image_explorer.css'))\n+        fragment.add_javascript_url(self.runtime.local_resource_url(self, 'public/js/image_explorer.js'))","path":"image_explorer/image_explorer.py","position":19,"original_position":19,"commit_id":"2a5aa755c80a9427d626f4dc987de793275be950","original_commit_id":"2a5aa755c80a9427d626f4dc987de793275be950","user":{"login":"ziafazal","id":434995,"avatar_url":"https://avatars.githubusercontent.com/u/434995?v=3","gravatar_id":"","url":"https://api.github.com/users/ziafazal","html_url":"https://github.com/ziafazal","followers_url":"https://api.github.com/users/ziafazal/followers","following_url":"https://api.github.com/users/ziafazal/following{/other_user}","gists_url":"https://api.github.com/users/ziafazal/gists{/gist_id}","starred_url":"https://api.github.com/users/ziafazal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ziafazal/subscriptions","organizations_url":"https://api.github.com/users/ziafazal/orgs","repos_url":"https://api.github.com/users/ziafazal/repos","events_url":"https://api.github.com/users/ziafazal/events{/privacy}","received_events_url":"https://api.github.com/users/ziafazal/received_events","type":"User","site_admin":false},"body":"@itsjeyd L112 and L176 are drive-by changes but L111 is need to fix the issue. `fragment.add_css_url ` method adds xblock resource by url whereas `fragment.add_css` adds resource as inline piece of code and inline css is not picked up by asset pipeline.","created_at":"2016-11-24T11:10:00Z","updated_at":"2016-11-24T11:10:00Z","html_url":"https://github.com/edx-solutions/xblock-image-explorer/pull/26#discussion_r89478219","pull_request_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/pulls/comments/89478219"},"html":{"href":"https://github.com/edx-solutions/xblock-image-explorer/pull/26#discussion_r89478219"},"pull_request":{"href":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/pulls/26","id":94351010,"html_url":"https://github.com/edx-solutions/xblock-image-explorer/pull/26","diff_url":"https://github.com/edx-solutions/xblock-image-explorer/pull/26.diff","patch_url":"https://github.com/edx-solutions/xblock-image-explorer/pull/26.patch","issue_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/issues/26","number":26,"state":"open","locked":false,"title":"Fix for hot-spot sprite image not visible on production like environment","user":{"login":"ziafazal","id":434995,"avatar_url":"https://avatars.githubusercontent.com/u/434995?v=3","gravatar_id":"","url":"https://api.github.com/users/ziafazal","html_url":"https://github.com/ziafazal","followers_url":"https://api.github.com/users/ziafazal/followers","following_url":"https://api.github.com/users/ziafazal/following{/other_user}","gists_url":"https://api.github.com/users/ziafazal/gists{/gist_id}","starred_url":"https://api.github.com/users/ziafazal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ziafazal/subscriptions","organizations_url":"https://api.github.com/users/ziafazal/orgs","repos_url":"https://api.github.com/users/ziafazal/repos","events_url":"https://api.github.com/users/ziafazal/events{/privacy}","received_events_url":"https://api.github.com/users/ziafazal/received_events","type":"User","site_admin":false},"body":"This PR address an issue where hot-spot sprite image not visible when assets are compiled on production environment.  Sprite url was generated with this statement\r\n```\r\nsprite_url = self.runtime.local_resource_url(self, 'public/images/hotspot-sprite.png')\r\n```\r\nwhich give and invalid url relevant to studio environment some like this (`/c4x/MMBA/IE230/asset/xblock_resources_image_explorer.image_explorer_public_images_hotspot-sprite.8e637638fd95.8e637638fd95.png`)\r\n\r\nMore detail of the issue can be found [here](https://openedx.atlassian.net/browse/YONK-478)\r\n\r\n@bradenmacdonald can some one from you team review this?\r\n\r\n","created_at":"2016-11-18T12:08:18Z","updated_at":"2016-11-24T11:10:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"718398af25584510034030d094ffa359da2b0e49","assignee":{"login":"bradenmacdonald","id":945577,"avatar_url":"https://avatars.githubusercontent.com/u/945577?v=3","gravatar_id":"","url":"https://api.github.com/users/bradenmacdonald","html_url":"https://github.com/bradenmacdonald","followers_url":"https://api.github.com/users/bradenmacdonald/followers","following_url":"https://api.github.com/users/bradenmacdonald/following{/other_user}","gists_url":"https://api.github.com/users/bradenmacdonald/gists{/gist_id}","starred_url":"https://api.github.com/users/bradenmacdonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradenmacdonald/subscriptions","organizations_url":"https://api.github.com/users/bradenmacdonald/orgs","repos_url":"https://api.github.com/users/bradenmacdonald/repos","events_url":"https://api.github.com/users/bradenmacdonald/events{/privacy}","received_events_url":"https://api.github.com/users/bradenmacdonald/received_events","type":"User","site_admin":false},"assignees":[{"login":"bradenmacdonald","id":945577,"avatar_url":"https://avatars.githubusercontent.com/u/945577?v=3","gravatar_id":"","url":"https://api.github.com/users/bradenmacdonald","html_url":"https://github.com/bradenmacdonald","followers_url":"https://api.github.com/users/bradenmacdonald/followers","following_url":"https://api.github.com/users/bradenmacdonald/following{/other_user}","gists_url":"https://api.github.com/users/bradenmacdonald/gists{/gist_id}","starred_url":"https://api.github.com/users/bradenmacdonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradenmacdonald/subscriptions","organizations_url":"https://api.github.com/users/bradenmacdonald/orgs","repos_url":"https://api.github.com/users/bradenmacdonald/repos","events_url":"https://api.github.com/users/bradenmacdonald/events{/privacy}","received_events_url":"https://api.github.com/users/bradenmacdonald/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/pulls/26/commits","review_comments_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/pulls/26/comments","review_comment_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/issues/26/comments","statuses_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/statuses/2a5aa755c80a9427d626f4dc987de793275be950","head":{"label":"edx-solutions:ziafazal/YONK-478","ref":"ziafazal/YONK-478","sha":"2a5aa755c80a9427d626f4dc987de793275be950","user":{"login":"edx-solutions","id":6585054,"avatar_url":"https://avatars.githubusercontent.com/u/6585054?v=3","gravatar_id":"","url":"https://api.github.com/users/edx-solutions","html_url":"https://github.com/edx-solutions","followers_url":"https://api.github.com/users/edx-solutions/followers","following_url":"https://api.github.com/users/edx-solutions/following{/other_user}","gists_url":"https://api.github.com/users/edx-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-solutions/subscriptions","organizations_url":"https://api.github.com/users/edx-solutions/orgs","repos_url":"https://api.github.com/users/edx-solutions/repos","events_url":"https://api.github.com/users/edx-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/edx-solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":17566237,"name":"xblock-image-explorer","full_name":"edx-solutions/xblock-image-explorer","owner":{"login":"edx-solutions","id":6585054,"avatar_url":"https://avatars.githubusercontent.com/u/6585054?v=3","gravatar_id":"","url":"https://api.github.com/users/edx-solutions","html_url":"https://github.com/edx-solutions","followers_url":"https://api.github.com/users/edx-solutions/followers","following_url":"https://api.github.com/users/edx-solutions/following{/other_user}","gists_url":"https://api.github.com/users/edx-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-solutions/subscriptions","organizations_url":"https://api.github.com/users/edx-solutions/orgs","repos_url":"https://api.github.com/users/edx-solutions/repos","events_url":"https://api.github.com/users/edx-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/edx-solutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx-solutions/xblock-image-explorer","description":null,"fork":false,"url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer","forks_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/forks","keys_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/teams","hooks_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/hooks","issue_events_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/issues/events{/number}","events_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/events","assignees_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/assignees{/user}","branches_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/branches{/branch}","tags_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/tags","blobs_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/languages","stargazers_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/stargazers","contributors_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/contributors","subscribers_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/subscribers","subscription_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/subscription","commits_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/contents/{+path}","compare_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/merges","archive_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/downloads","issues_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/issues{/number}","pulls_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/labels{/name}","releases_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/releases{/id}","deployments_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/deployments","created_at":"2014-03-09T14:40:29Z","updated_at":"2016-05-23T02:48:52Z","pushed_at":"2016-11-18T12:08:19Z","git_url":"git://github.com/edx-solutions/xblock-image-explorer.git","ssh_url":"git@github.com:edx-solutions/xblock-image-explorer.git","clone_url":"https://github.com/edx-solutions/xblock-image-explorer.git","svn_url":"https://github.com/edx-solutions/xblock-image-explorer","homepage":null,"size":867,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"edx-solutions:master","ref":"master","sha":"00d601edbd2f541067022aaa87f1c4e136da6ad7","user":{"login":"edx-solutions","id":6585054,"avatar_url":"https://avatars.githubusercontent.com/u/6585054?v=3","gravatar_id":"","url":"https://api.github.com/users/edx-solutions","html_url":"https://github.com/edx-solutions","followers_url":"https://api.github.com/users/edx-solutions/followers","following_url":"https://api.github.com/users/edx-solutions/following{/other_user}","gists_url":"https://api.github.com/users/edx-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-solutions/subscriptions","organizations_url":"https://api.github.com/users/edx-solutions/orgs","repos_url":"https://api.github.com/users/edx-solutions/repos","events_url":"https://api.github.com/users/edx-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/edx-solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":17566237,"name":"xblock-image-explorer","full_name":"edx-solutions/xblock-image-explorer","owner":{"login":"edx-solutions","id":6585054,"avatar_url":"https://avatars.githubusercontent.com/u/6585054?v=3","gravatar_id":"","url":"https://api.github.com/users/edx-solutions","html_url":"https://github.com/edx-solutions","followers_url":"https://api.github.com/users/edx-solutions/followers","following_url":"https://api.github.com/users/edx-solutions/following{/other_user}","gists_url":"https://api.github.com/users/edx-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-solutions/subscriptions","organizations_url":"https://api.github.com/users/edx-solutions/orgs","repos_url":"https://api.github.com/users/edx-solutions/repos","events_url":"https://api.github.com/users/edx-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/edx-solutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx-solutions/xblock-image-explorer","description":null,"fork":false,"url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer","forks_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/forks","keys_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/teams","hooks_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/hooks","issue_events_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/issues/events{/number}","events_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/events","assignees_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/assignees{/user}","branches_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/branches{/branch}","tags_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/tags","blobs_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/languages","stargazers_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/stargazers","contributors_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/contributors","subscribers_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/subscribers","subscription_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/subscription","commits_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/contents/{+path}","compare_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/merges","archive_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/downloads","issues_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/issues{/number}","pulls_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/labels{/name}","releases_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/releases{/id}","deployments_url":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/deployments","created_at":"2014-03-09T14:40:29Z","updated_at":"2016-05-23T02:48:52Z","pushed_at":"2016-11-18T12:08:19Z","git_url":"git://github.com/edx-solutions/xblock-image-explorer.git","ssh_url":"git@github.com:edx-solutions/xblock-image-explorer.git","clone_url":"https://github.com/edx-solutions/xblock-image-explorer.git","svn_url":"https://github.com/edx-solutions/xblock-image-explorer","homepage":null,"size":867,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/pulls/26"},"html":{"href":"https://github.com/edx-solutions/xblock-image-explorer/pull/26"},"issue":{"href":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/issues/26"},"comments":{"href":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/edx-solutions/xblock-image-explorer/statuses/2a5aa755c80a9427d626f4dc987de793275be950"}}}}
{"actor":{"display_login":"ziafazal"}}