{"action":"opened","number":1887,"pull_request":{"url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/pulls/1887","id":80426203,"html_url":"https://github.com/SubtitleEdit/subtitleedit/pull/1887","diff_url":"https://github.com/SubtitleEdit/subtitleedit/pull/1887.diff","patch_url":"https://github.com/SubtitleEdit/subtitleedit/pull/1887.patch","issue_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/issues/1887","number":1887,"state":"open","locked":false,"title":"Descenders in PNGs, simplified line height calculation.","user":{"login":"ischeriad","id":1580928,"avatar_url":"https://avatars.githubusercontent.com/u/1580928?v=3","gravatar_id":"","url":"https://api.github.com/users/ischeriad","html_url":"https://github.com/ischeriad","followers_url":"https://api.github.com/users/ischeriad/followers","following_url":"https://api.github.com/users/ischeriad/following{/other_user}","gists_url":"https://api.github.com/users/ischeriad/gists{/gist_id}","starred_url":"https://api.github.com/users/ischeriad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ischeriad/subscriptions","organizations_url":"https://api.github.com/users/ischeriad/orgs","repos_url":"https://api.github.com/users/ischeriad/repos","events_url":"https://api.github.com/users/ischeriad/events{/privacy}","received_events_url":"https://api.github.com/users/ischeriad/received_events","type":"User","site_admin":false},"body":"For an upcoming project with Romanian subtitles, I needed to improve the baseline calculation for PNG creation.\r\n\r\nInstead of keeping a list with all possible characters and comparing line height to a line with these characters removed (textNoBelow), I just compare with a simple line \"a,\".\r\n\r\nThere is still an occasional difference of 1px in height for generated PNGs, this seems to be a rounding error somewhere. (Changing border width in 1px increments shows the offset on different lines).","created_at":"2016-08-08T10:14:53Z","updated_at":"2016-08-08T10:14:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/pulls/1887/commits","review_comments_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/pulls/1887/comments","review_comment_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/issues/1887/comments","statuses_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/statuses/f7e12707740613e5df36932cc86feb6a5f381ba5","head":{"label":"ischeriad:descenders","ref":"descenders","sha":"f7e12707740613e5df36932cc86feb6a5f381ba5","user":{"login":"ischeriad","id":1580928,"avatar_url":"https://avatars.githubusercontent.com/u/1580928?v=3","gravatar_id":"","url":"https://api.github.com/users/ischeriad","html_url":"https://github.com/ischeriad","followers_url":"https://api.github.com/users/ischeriad/followers","following_url":"https://api.github.com/users/ischeriad/following{/other_user}","gists_url":"https://api.github.com/users/ischeriad/gists{/gist_id}","starred_url":"https://api.github.com/users/ischeriad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ischeriad/subscriptions","organizations_url":"https://api.github.com/users/ischeriad/orgs","repos_url":"https://api.github.com/users/ischeriad/repos","events_url":"https://api.github.com/users/ischeriad/events{/privacy}","received_events_url":"https://api.github.com/users/ischeriad/received_events","type":"User","site_admin":false},"repo":{"id":65188447,"name":"subtitleedit","full_name":"ischeriad/subtitleedit","owner":{"login":"ischeriad","id":1580928,"avatar_url":"https://avatars.githubusercontent.com/u/1580928?v=3","gravatar_id":"","url":"https://api.github.com/users/ischeriad","html_url":"https://github.com/ischeriad","followers_url":"https://api.github.com/users/ischeriad/followers","following_url":"https://api.github.com/users/ischeriad/following{/other_user}","gists_url":"https://api.github.com/users/ischeriad/gists{/gist_id}","starred_url":"https://api.github.com/users/ischeriad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ischeriad/subscriptions","organizations_url":"https://api.github.com/users/ischeriad/orgs","repos_url":"https://api.github.com/users/ischeriad/repos","events_url":"https://api.github.com/users/ischeriad/events{/privacy}","received_events_url":"https://api.github.com/users/ischeriad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ischeriad/subtitleedit","description":"the subtitle editor :)","fork":true,"url":"https://api.github.com/repos/ischeriad/subtitleedit","forks_url":"https://api.github.com/repos/ischeriad/subtitleedit/forks","keys_url":"https://api.github.com/repos/ischeriad/subtitleedit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ischeriad/subtitleedit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ischeriad/subtitleedit/teams","hooks_url":"https://api.github.com/repos/ischeriad/subtitleedit/hooks","issue_events_url":"https://api.github.com/repos/ischeriad/subtitleedit/issues/events{/number}","events_url":"https://api.github.com/repos/ischeriad/subtitleedit/events","assignees_url":"https://api.github.com/repos/ischeriad/subtitleedit/assignees{/user}","branches_url":"https://api.github.com/repos/ischeriad/subtitleedit/branches{/branch}","tags_url":"https://api.github.com/repos/ischeriad/subtitleedit/tags","blobs_url":"https://api.github.com/repos/ischeriad/subtitleedit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ischeriad/subtitleedit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ischeriad/subtitleedit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ischeriad/subtitleedit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ischeriad/subtitleedit/statuses/{sha}","languages_url":"https://api.github.com/repos/ischeriad/subtitleedit/languages","stargazers_url":"https://api.github.com/repos/ischeriad/subtitleedit/stargazers","contributors_url":"https://api.github.com/repos/ischeriad/subtitleedit/contributors","subscribers_url":"https://api.github.com/repos/ischeriad/subtitleedit/subscribers","subscription_url":"https://api.github.com/repos/ischeriad/subtitleedit/subscription","commits_url":"https://api.github.com/repos/ischeriad/subtitleedit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ischeriad/subtitleedit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ischeriad/subtitleedit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ischeriad/subtitleedit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ischeriad/subtitleedit/contents/{+path}","compare_url":"https://api.github.com/repos/ischeriad/subtitleedit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ischeriad/subtitleedit/merges","archive_url":"https://api.github.com/repos/ischeriad/subtitleedit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ischeriad/subtitleedit/downloads","issues_url":"https://api.github.com/repos/ischeriad/subtitleedit/issues{/number}","pulls_url":"https://api.github.com/repos/ischeriad/subtitleedit/pulls{/number}","milestones_url":"https://api.github.com/repos/ischeriad/subtitleedit/milestones{/number}","notifications_url":"https://api.github.com/repos/ischeriad/subtitleedit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ischeriad/subtitleedit/labels{/name}","releases_url":"https://api.github.com/repos/ischeriad/subtitleedit/releases{/id}","deployments_url":"https://api.github.com/repos/ischeriad/subtitleedit/deployments","created_at":"2016-08-08T08:50:49Z","updated_at":"2016-08-08T08:50:53Z","pushed_at":"2016-08-08T10:09:00Z","git_url":"git://github.com/ischeriad/subtitleedit.git","ssh_url":"git@github.com:ischeriad/subtitleedit.git","clone_url":"https://github.com/ischeriad/subtitleedit.git","svn_url":"https://github.com/ischeriad/subtitleedit","homepage":"http://www.nikse.dk/SubtitleEdit/","size":143829,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SubtitleEdit:master","ref":"master","sha":"f05c2f77c06ae4f196f56616b87f710816a98f42","user":{"login":"SubtitleEdit","id":3008853,"avatar_url":"https://avatars.githubusercontent.com/u/3008853?v=3","gravatar_id":"","url":"https://api.github.com/users/SubtitleEdit","html_url":"https://github.com/SubtitleEdit","followers_url":"https://api.github.com/users/SubtitleEdit/followers","following_url":"https://api.github.com/users/SubtitleEdit/following{/other_user}","gists_url":"https://api.github.com/users/SubtitleEdit/gists{/gist_id}","starred_url":"https://api.github.com/users/SubtitleEdit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SubtitleEdit/subscriptions","organizations_url":"https://api.github.com/users/SubtitleEdit/orgs","repos_url":"https://api.github.com/users/SubtitleEdit/repos","events_url":"https://api.github.com/users/SubtitleEdit/events{/privacy}","received_events_url":"https://api.github.com/users/SubtitleEdit/received_events","type":"Organization","site_admin":false},"repo":{"id":16473585,"name":"subtitleedit","full_name":"SubtitleEdit/subtitleedit","owner":{"login":"SubtitleEdit","id":3008853,"avatar_url":"https://avatars.githubusercontent.com/u/3008853?v=3","gravatar_id":"","url":"https://api.github.com/users/SubtitleEdit","html_url":"https://github.com/SubtitleEdit","followers_url":"https://api.github.com/users/SubtitleEdit/followers","following_url":"https://api.github.com/users/SubtitleEdit/following{/other_user}","gists_url":"https://api.github.com/users/SubtitleEdit/gists{/gist_id}","starred_url":"https://api.github.com/users/SubtitleEdit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SubtitleEdit/subscriptions","organizations_url":"https://api.github.com/users/SubtitleEdit/orgs","repos_url":"https://api.github.com/users/SubtitleEdit/repos","events_url":"https://api.github.com/users/SubtitleEdit/events{/privacy}","received_events_url":"https://api.github.com/users/SubtitleEdit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SubtitleEdit/subtitleedit","description":"the subtitle editor :)","fork":false,"url":"https://api.github.com/repos/SubtitleEdit/subtitleedit","forks_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/forks","keys_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/teams","hooks_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/hooks","issue_events_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/issues/events{/number}","events_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/events","assignees_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/assignees{/user}","branches_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/branches{/branch}","tags_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/tags","blobs_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/git/refs{/sha}","trees_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/statuses/{sha}","languages_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/languages","stargazers_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/stargazers","contributors_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/contributors","subscribers_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/subscribers","subscription_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/subscription","commits_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/commits{/sha}","git_commits_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/git/commits{/sha}","comments_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/comments{/number}","issue_comment_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/issues/comments{/number}","contents_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/contents/{+path}","compare_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/merges","archive_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/downloads","issues_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/issues{/number}","pulls_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/pulls{/number}","milestones_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/milestones{/number}","notifications_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/labels{/name}","releases_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/releases{/id}","deployments_url":"https://api.github.com/repos/SubtitleEdit/subtitleedit/deployments","created_at":"2014-02-03T08:17:41Z","updated_at":"2016-08-08T07:55:38Z","pushed_at":"2016-08-08T07:21:28Z","git_url":"git://github.com/SubtitleEdit/subtitleedit.git","ssh_url":"git@github.com:SubtitleEdit/subtitleedit.git","clone_url":"https://github.com/SubtitleEdit/subtitleedit.git","svn_url":"https://github.com/SubtitleEdit/subtitleedit","homepage":"http://www.nikse.dk/SubtitleEdit/","size":143829,"stargazers_count":481,"watchers_count":481,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":117,"mirror_url":null,"open_issues_count":197,"forks":117,"open_issues":197,"watchers":481,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SubtitleEdit/subtitleedit/pulls/1887"},"html":{"href":"https://github.com/SubtitleEdit/subtitleedit/pull/1887"},"issue":{"href":"https://api.github.com/repos/SubtitleEdit/subtitleedit/issues/1887"},"comments":{"href":"https://api.github.com/repos/SubtitleEdit/subtitleedit/issues/1887/comments"},"review_comments":{"href":"https://api.github.com/repos/SubtitleEdit/subtitleedit/pulls/1887/comments"},"review_comment":{"href":"https://api.github.com/repos/SubtitleEdit/subtitleedit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SubtitleEdit/subtitleedit/pulls/1887/commits"},"statuses":{"href":"https://api.github.com/repos/SubtitleEdit/subtitleedit/statuses/f7e12707740613e5df36932cc86feb6a5f381ba5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":3,"deletions":11,"changed_files":1}}
{"actor":{"display_login":"ischeriad"}}