{"action":"created","comment":{"url":"https://api.github.com/repos/nens/threedi-qgis-plugin/pulls/comments/74417133","id":74417133,"diff_hunk":"@@ -441,8 +451,8 @@ def get_available_variables(self, only_subgrid_map=False,\n             possible_subgrid_map_vars = [v for v, _, _ in\r\n                                          SUBGRID_MAP_VARIABLES]\r\n             subgrid_map_vars = self.ds.variables.keys()\r\n-            available_subgrid_map_vars = set(\r\n-                possible_subgrid_map_vars).intersection(set(subgrid_map_vars))\r\n+            available_subgrid_map_vars = c = [v for v in possible_subgrid_map_vars\r","path":"datasource/netcdf.py","position":60,"original_position":60,"commit_id":"14afac2bb7c4e3575cf14dd2016868d506554316","original_commit_id":"14afac2bb7c4e3575cf14dd2016868d506554316","user":{"login":"jackieleng","id":7591667,"avatar_url":"https://avatars.githubusercontent.com/u/7591667?v=3","gravatar_id":"","url":"https://api.github.com/users/jackieleng","html_url":"https://github.com/jackieleng","followers_url":"https://api.github.com/users/jackieleng/followers","following_url":"https://api.github.com/users/jackieleng/following{/other_user}","gists_url":"https://api.github.com/users/jackieleng/gists{/gist_id}","starred_url":"https://api.github.com/users/jackieleng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackieleng/subscriptions","organizations_url":"https://api.github.com/users/jackieleng/orgs","repos_url":"https://api.github.com/users/jackieleng/repos","events_url":"https://api.github.com/users/jackieleng/events{/privacy}","received_events_url":"https://api.github.com/users/jackieleng/received_events","type":"User","site_admin":false},"body":"Dit lijkt me niet correct, c is ongebruikt.","created_at":"2016-08-11T13:01:40Z","updated_at":"2016-08-11T13:01:40Z","html_url":"https://github.com/nens/threedi-qgis-plugin/pull/61#discussion_r74417133","pull_request_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/nens/threedi-qgis-plugin/pulls/comments/74417133"},"html":{"href":"https://github.com/nens/threedi-qgis-plugin/pull/61#discussion_r74417133"},"pull_request":{"href":"https://api.github.com/repos/nens/threedi-qgis-plugin/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/nens/threedi-qgis-plugin/pulls/61","id":80640467,"html_url":"https://github.com/nens/threedi-qgis-plugin/pull/61","diff_url":"https://github.com/nens/threedi-qgis-plugin/pull/61.diff","patch_url":"https://github.com/nens/threedi-qgis-plugin/pull/61.patch","issue_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/issues/61","number":61,"state":"open","locked":false,"title":"Legend tree manager","user":{"login":"bastiaan-roos","id":1068991,"avatar_url":"https://avatars.githubusercontent.com/u/1068991?v=3","gravatar_id":"","url":"https://api.github.com/users/bastiaan-roos","html_url":"https://github.com/bastiaan-roos","followers_url":"https://api.github.com/users/bastiaan-roos/followers","following_url":"https://api.github.com/users/bastiaan-roos/following{/other_user}","gists_url":"https://api.github.com/users/bastiaan-roos/gists{/gist_id}","starred_url":"https://api.github.com/users/bastiaan-roos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bastiaan-roos/subscriptions","organizations_url":"https://api.github.com/users/bastiaan-roos/orgs","repos_url":"https://api.github.com/users/bastiaan-roos/repos","events_url":"https://api.github.com/users/bastiaan-roos/events{/privacy}","received_events_url":"https://api.github.com/users/bastiaan-roos/received_events","type":"User","site_admin":false},"body":"Legend tree manager (work in progress)\r\n\r\nMap animator (work in progress)\r\n\r\nImproved speed of spatialite generation for older versions of gdal.\r\n\r\nMade request of timeseries of netcdf with netcdf_id (so no magic with -1)\r\n\r\nRemoved some unused code\r\n\r\nUpdate parameter selection of graphs when selecting other result\r\n\r\nServeral minor bugfixes","created_at":"2016-08-09T15:21:20Z","updated_at":"2016-08-11T13:01:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4991859e040d4266e8786618afebf56a4aaf845","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/pulls/61/commits","review_comments_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/pulls/61/comments","review_comment_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/issues/61/comments","statuses_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/statuses/14afac2bb7c4e3575cf14dd2016868d506554316","head":{"label":"nens:legend-tree-manager","ref":"legend-tree-manager","sha":"14afac2bb7c4e3575cf14dd2016868d506554316","user":{"login":"nens","id":826981,"avatar_url":"https://avatars.githubusercontent.com/u/826981?v=3","gravatar_id":"","url":"https://api.github.com/users/nens","html_url":"https://github.com/nens","followers_url":"https://api.github.com/users/nens/followers","following_url":"https://api.github.com/users/nens/following{/other_user}","gists_url":"https://api.github.com/users/nens/gists{/gist_id}","starred_url":"https://api.github.com/users/nens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nens/subscriptions","organizations_url":"https://api.github.com/users/nens/orgs","repos_url":"https://api.github.com/users/nens/repos","events_url":"https://api.github.com/users/nens/events{/privacy}","received_events_url":"https://api.github.com/users/nens/received_events","type":"Organization","site_admin":false},"repo":{"id":55498704,"name":"threedi-qgis-plugin","full_name":"nens/threedi-qgis-plugin","owner":{"login":"nens","id":826981,"avatar_url":"https://avatars.githubusercontent.com/u/826981?v=3","gravatar_id":"","url":"https://api.github.com/users/nens","html_url":"https://github.com/nens","followers_url":"https://api.github.com/users/nens/followers","following_url":"https://api.github.com/users/nens/following{/other_user}","gists_url":"https://api.github.com/users/nens/gists{/gist_id}","starred_url":"https://api.github.com/users/nens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nens/subscriptions","organizations_url":"https://api.github.com/users/nens/orgs","repos_url":"https://api.github.com/users/nens/repos","events_url":"https://api.github.com/users/nens/events{/privacy}","received_events_url":"https://api.github.com/users/nens/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nens/threedi-qgis-plugin","description":"Plugins for working with 3di models in QGIS","fork":false,"url":"https://api.github.com/repos/nens/threedi-qgis-plugin","forks_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/forks","keys_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/teams","hooks_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/hooks","issue_events_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/events","assignees_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/tags","blobs_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/languages","stargazers_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/stargazers","contributors_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/contributors","subscribers_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/subscribers","subscription_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/subscription","commits_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/merges","archive_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/downloads","issues_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/labels{/name}","releases_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/deployments","created_at":"2016-04-05T10:25:10Z","updated_at":"2016-04-05T15:34:32Z","pushed_at":"2016-08-11T12:15:47Z","git_url":"git://github.com/nens/threedi-qgis-plugin.git","ssh_url":"git@github.com:nens/threedi-qgis-plugin.git","clone_url":"https://github.com/nens/threedi-qgis-plugin.git","svn_url":"https://github.com/nens/threedi-qgis-plugin","homepage":null,"size":3846,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"nens:master","ref":"master","sha":"4fe758a1ee6e1c10745b792516dc999b3a799abe","user":{"login":"nens","id":826981,"avatar_url":"https://avatars.githubusercontent.com/u/826981?v=3","gravatar_id":"","url":"https://api.github.com/users/nens","html_url":"https://github.com/nens","followers_url":"https://api.github.com/users/nens/followers","following_url":"https://api.github.com/users/nens/following{/other_user}","gists_url":"https://api.github.com/users/nens/gists{/gist_id}","starred_url":"https://api.github.com/users/nens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nens/subscriptions","organizations_url":"https://api.github.com/users/nens/orgs","repos_url":"https://api.github.com/users/nens/repos","events_url":"https://api.github.com/users/nens/events{/privacy}","received_events_url":"https://api.github.com/users/nens/received_events","type":"Organization","site_admin":false},"repo":{"id":55498704,"name":"threedi-qgis-plugin","full_name":"nens/threedi-qgis-plugin","owner":{"login":"nens","id":826981,"avatar_url":"https://avatars.githubusercontent.com/u/826981?v=3","gravatar_id":"","url":"https://api.github.com/users/nens","html_url":"https://github.com/nens","followers_url":"https://api.github.com/users/nens/followers","following_url":"https://api.github.com/users/nens/following{/other_user}","gists_url":"https://api.github.com/users/nens/gists{/gist_id}","starred_url":"https://api.github.com/users/nens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nens/subscriptions","organizations_url":"https://api.github.com/users/nens/orgs","repos_url":"https://api.github.com/users/nens/repos","events_url":"https://api.github.com/users/nens/events{/privacy}","received_events_url":"https://api.github.com/users/nens/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nens/threedi-qgis-plugin","description":"Plugins for working with 3di models in QGIS","fork":false,"url":"https://api.github.com/repos/nens/threedi-qgis-plugin","forks_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/forks","keys_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/teams","hooks_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/hooks","issue_events_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/events","assignees_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/tags","blobs_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/languages","stargazers_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/stargazers","contributors_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/contributors","subscribers_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/subscribers","subscription_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/subscription","commits_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/merges","archive_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/downloads","issues_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/labels{/name}","releases_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/nens/threedi-qgis-plugin/deployments","created_at":"2016-04-05T10:25:10Z","updated_at":"2016-04-05T15:34:32Z","pushed_at":"2016-08-11T12:15:47Z","git_url":"git://github.com/nens/threedi-qgis-plugin.git","ssh_url":"git@github.com:nens/threedi-qgis-plugin.git","clone_url":"https://github.com/nens/threedi-qgis-plugin.git","svn_url":"https://github.com/nens/threedi-qgis-plugin","homepage":null,"size":3846,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nens/threedi-qgis-plugin/pulls/61"},"html":{"href":"https://github.com/nens/threedi-qgis-plugin/pull/61"},"issue":{"href":"https://api.github.com/repos/nens/threedi-qgis-plugin/issues/61"},"comments":{"href":"https://api.github.com/repos/nens/threedi-qgis-plugin/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/nens/threedi-qgis-plugin/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/nens/threedi-qgis-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nens/threedi-qgis-plugin/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/nens/threedi-qgis-plugin/statuses/14afac2bb7c4e3575cf14dd2016868d506554316"}}}}
{"actor":{"display_login":"jackieleng"}}