{"action":"created","comment":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/comments/93582653","pull_request_review_id":14111704,"id":93582653,"diff_hunk":"@@ -307,19 +292,18 @@ class TrivialFactorWeightFstImpl\n \n   typedef unordered_map<Element, StateId, ElementKey, ElementEqual> ElementMap;\n \n-  const Fst<A> *fst_;\n+  std::unique_ptr<const Fst<A>> fst_;\n   float delta_;","path":"src/fstext/trivial-factor-weight.h","position":46,"original_position":46,"commit_id":"1167432c3cf5e5a2d94236b85f77e756b7947a73","original_commit_id":"1167432c3cf5e5a2d94236b85f77e756b7947a73","user":{"login":"jtrmal","id":11054175,"avatar_url":"https://avatars.githubusercontent.com/u/11054175?v=3","gravatar_id":"","url":"https://api.github.com/users/jtrmal","html_url":"https://github.com/jtrmal","followers_url":"https://api.github.com/users/jtrmal/followers","following_url":"https://api.github.com/users/jtrmal/following{/other_user}","gists_url":"https://api.github.com/users/jtrmal/gists{/gist_id}","starred_url":"https://api.github.com/users/jtrmal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtrmal/subscriptions","organizations_url":"https://api.github.com/users/jtrmal/orgs","repos_url":"https://api.github.com/users/jtrmal/repos","events_url":"https://api.github.com/users/jtrmal/events{/privacy}","received_events_url":"https://api.github.com/users/jtrmal/received_events","type":"User","site_admin":false},"body":"I see bellow this that you initialize unique_ptr using make_shared. Is that a correct way how to handle this? I know that make_unique exists only since C++14, but I'm not sure about interactions between assingments of unique_ptr and shared_ptr","created_at":"2016-12-22T08:31:27Z","updated_at":"2016-12-22T08:39:56Z","html_url":"https://github.com/kaldi-asr/kaldi/pull/1249#discussion_r93582653","pull_request_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/1249","_links":{"self":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/comments/93582653"},"html":{"href":"https://github.com/kaldi-asr/kaldi/pull/1249#discussion_r93582653"},"pull_request":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/1249"}}},"pull_request":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/1249","id":96682012,"html_url":"https://github.com/kaldi-asr/kaldi/pull/1249","diff_url":"https://github.com/kaldi-asr/kaldi/pull/1249.diff","patch_url":"https://github.com/kaldi-asr/kaldi/pull/1249.patch","issue_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1249","number":1249,"state":"open","locked":false,"title":"WIP: C++11 Upgrade","user":{"login":"dogancan","id":620222,"avatar_url":"https://avatars.githubusercontent.com/u/620222?v=3","gravatar_id":"","url":"https://api.github.com/users/dogancan","html_url":"https://github.com/dogancan","followers_url":"https://api.github.com/users/dogancan/followers","following_url":"https://api.github.com/users/dogancan/following{/other_user}","gists_url":"https://api.github.com/users/dogancan/gists{/gist_id}","starred_url":"https://api.github.com/users/dogancan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dogancan/subscriptions","organizations_url":"https://api.github.com/users/dogancan/orgs","repos_url":"https://api.github.com/users/dogancan/repos","events_url":"https://api.github.com/users/dogancan/events{/privacy}","received_events_url":"https://api.github.com/users/dogancan/received_events","type":"User","site_admin":false},"body":"This PR is a work in progress. See #1234 #1235 for earlier discussion.","created_at":"2016-12-06T08:44:32Z","updated_at":"2016-12-22T08:39:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca4461c0d674f411d6d39a6e356d5b49f37ad063","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/1249/commits","review_comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/1249/comments","review_comment_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1249/comments","statuses_url":"https://api.github.com/repos/kaldi-asr/kaldi/statuses/1167432c3cf5e5a2d94236b85f77e756b7947a73","head":{"label":"dogancan:c++11","ref":"c++11","sha":"1167432c3cf5e5a2d94236b85f77e756b7947a73","user":{"login":"dogancan","id":620222,"avatar_url":"https://avatars.githubusercontent.com/u/620222?v=3","gravatar_id":"","url":"https://api.github.com/users/dogancan","html_url":"https://github.com/dogancan","followers_url":"https://api.github.com/users/dogancan/followers","following_url":"https://api.github.com/users/dogancan/following{/other_user}","gists_url":"https://api.github.com/users/dogancan/gists{/gist_id}","starred_url":"https://api.github.com/users/dogancan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dogancan/subscriptions","organizations_url":"https://api.github.com/users/dogancan/orgs","repos_url":"https://api.github.com/users/dogancan/repos","events_url":"https://api.github.com/users/dogancan/events{/privacy}","received_events_url":"https://api.github.com/users/dogancan/received_events","type":"User","site_admin":false},"repo":{"id":75241405,"name":"kaldi","full_name":"dogancan/kaldi","owner":{"login":"dogancan","id":620222,"avatar_url":"https://avatars.githubusercontent.com/u/620222?v=3","gravatar_id":"","url":"https://api.github.com/users/dogancan","html_url":"https://github.com/dogancan","followers_url":"https://api.github.com/users/dogancan/followers","following_url":"https://api.github.com/users/dogancan/following{/other_user}","gists_url":"https://api.github.com/users/dogancan/gists{/gist_id}","starred_url":"https://api.github.com/users/dogancan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dogancan/subscriptions","organizations_url":"https://api.github.com/users/dogancan/orgs","repos_url":"https://api.github.com/users/dogancan/repos","events_url":"https://api.github.com/users/dogancan/events{/privacy}","received_events_url":"https://api.github.com/users/dogancan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dogancan/kaldi","description":"This is now the official location of the Kaldi project.","fork":true,"url":"https://api.github.com/repos/dogancan/kaldi","forks_url":"https://api.github.com/repos/dogancan/kaldi/forks","keys_url":"https://api.github.com/repos/dogancan/kaldi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dogancan/kaldi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dogancan/kaldi/teams","hooks_url":"https://api.github.com/repos/dogancan/kaldi/hooks","issue_events_url":"https://api.github.com/repos/dogancan/kaldi/issues/events{/number}","events_url":"https://api.github.com/repos/dogancan/kaldi/events","assignees_url":"https://api.github.com/repos/dogancan/kaldi/assignees{/user}","branches_url":"https://api.github.com/repos/dogancan/kaldi/branches{/branch}","tags_url":"https://api.github.com/repos/dogancan/kaldi/tags","blobs_url":"https://api.github.com/repos/dogancan/kaldi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dogancan/kaldi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dogancan/kaldi/git/refs{/sha}","trees_url":"https://api.github.com/repos/dogancan/kaldi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dogancan/kaldi/statuses/{sha}","languages_url":"https://api.github.com/repos/dogancan/kaldi/languages","stargazers_url":"https://api.github.com/repos/dogancan/kaldi/stargazers","contributors_url":"https://api.github.com/repos/dogancan/kaldi/contributors","subscribers_url":"https://api.github.com/repos/dogancan/kaldi/subscribers","subscription_url":"https://api.github.com/repos/dogancan/kaldi/subscription","commits_url":"https://api.github.com/repos/dogancan/kaldi/commits{/sha}","git_commits_url":"https://api.github.com/repos/dogancan/kaldi/git/commits{/sha}","comments_url":"https://api.github.com/repos/dogancan/kaldi/comments{/number}","issue_comment_url":"https://api.github.com/repos/dogancan/kaldi/issues/comments{/number}","contents_url":"https://api.github.com/repos/dogancan/kaldi/contents/{+path}","compare_url":"https://api.github.com/repos/dogancan/kaldi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dogancan/kaldi/merges","archive_url":"https://api.github.com/repos/dogancan/kaldi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dogancan/kaldi/downloads","issues_url":"https://api.github.com/repos/dogancan/kaldi/issues{/number}","pulls_url":"https://api.github.com/repos/dogancan/kaldi/pulls{/number}","milestones_url":"https://api.github.com/repos/dogancan/kaldi/milestones{/number}","notifications_url":"https://api.github.com/repos/dogancan/kaldi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dogancan/kaldi/labels{/name}","releases_url":"https://api.github.com/repos/dogancan/kaldi/releases{/id}","deployments_url":"https://api.github.com/repos/dogancan/kaldi/deployments","created_at":"2016-12-01T01:00:23Z","updated_at":"2016-12-01T01:00:35Z","pushed_at":"2016-12-21T22:17:27Z","git_url":"git://github.com/dogancan/kaldi.git","ssh_url":"git@github.com:dogancan/kaldi.git","clone_url":"https://github.com/dogancan/kaldi.git","svn_url":"https://github.com/dogancan/kaldi","homepage":"http://kaldi-asr.org","size":104425,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kaldi-asr:master","ref":"master","sha":"ba58e8e55ed1777969e670980dbbc17c0eef530c","user":{"login":"kaldi-asr","id":11650082,"avatar_url":"https://avatars.githubusercontent.com/u/11650082?v=3","gravatar_id":"","url":"https://api.github.com/users/kaldi-asr","html_url":"https://github.com/kaldi-asr","followers_url":"https://api.github.com/users/kaldi-asr/followers","following_url":"https://api.github.com/users/kaldi-asr/following{/other_user}","gists_url":"https://api.github.com/users/kaldi-asr/gists{/gist_id}","starred_url":"https://api.github.com/users/kaldi-asr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaldi-asr/subscriptions","organizations_url":"https://api.github.com/users/kaldi-asr/orgs","repos_url":"https://api.github.com/users/kaldi-asr/repos","events_url":"https://api.github.com/users/kaldi-asr/events{/privacy}","received_events_url":"https://api.github.com/users/kaldi-asr/received_events","type":"Organization","site_admin":false},"repo":{"id":34275045,"name":"kaldi","full_name":"kaldi-asr/kaldi","owner":{"login":"kaldi-asr","id":11650082,"avatar_url":"https://avatars.githubusercontent.com/u/11650082?v=3","gravatar_id":"","url":"https://api.github.com/users/kaldi-asr","html_url":"https://github.com/kaldi-asr","followers_url":"https://api.github.com/users/kaldi-asr/followers","following_url":"https://api.github.com/users/kaldi-asr/following{/other_user}","gists_url":"https://api.github.com/users/kaldi-asr/gists{/gist_id}","starred_url":"https://api.github.com/users/kaldi-asr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaldi-asr/subscriptions","organizations_url":"https://api.github.com/users/kaldi-asr/orgs","repos_url":"https://api.github.com/users/kaldi-asr/repos","events_url":"https://api.github.com/users/kaldi-asr/events{/privacy}","received_events_url":"https://api.github.com/users/kaldi-asr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaldi-asr/kaldi","description":"This is now the official location of the Kaldi project.","fork":false,"url":"https://api.github.com/repos/kaldi-asr/kaldi","forks_url":"https://api.github.com/repos/kaldi-asr/kaldi/forks","keys_url":"https://api.github.com/repos/kaldi-asr/kaldi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaldi-asr/kaldi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaldi-asr/kaldi/teams","hooks_url":"https://api.github.com/repos/kaldi-asr/kaldi/hooks","issue_events_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/events{/number}","events_url":"https://api.github.com/repos/kaldi-asr/kaldi/events","assignees_url":"https://api.github.com/repos/kaldi-asr/kaldi/assignees{/user}","branches_url":"https://api.github.com/repos/kaldi-asr/kaldi/branches{/branch}","tags_url":"https://api.github.com/repos/kaldi-asr/kaldi/tags","blobs_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaldi-asr/kaldi/statuses/{sha}","languages_url":"https://api.github.com/repos/kaldi-asr/kaldi/languages","stargazers_url":"https://api.github.com/repos/kaldi-asr/kaldi/stargazers","contributors_url":"https://api.github.com/repos/kaldi-asr/kaldi/contributors","subscribers_url":"https://api.github.com/repos/kaldi-asr/kaldi/subscribers","subscription_url":"https://api.github.com/repos/kaldi-asr/kaldi/subscription","commits_url":"https://api.github.com/repos/kaldi-asr/kaldi/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaldi-asr/kaldi/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaldi-asr/kaldi/contents/{+path}","compare_url":"https://api.github.com/repos/kaldi-asr/kaldi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaldi-asr/kaldi/merges","archive_url":"https://api.github.com/repos/kaldi-asr/kaldi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaldi-asr/kaldi/downloads","issues_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues{/number}","pulls_url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls{/number}","milestones_url":"https://api.github.com/repos/kaldi-asr/kaldi/milestones{/number}","notifications_url":"https://api.github.com/repos/kaldi-asr/kaldi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaldi-asr/kaldi/labels{/name}","releases_url":"https://api.github.com/repos/kaldi-asr/kaldi/releases{/id}","deployments_url":"https://api.github.com/repos/kaldi-asr/kaldi/deployments","created_at":"2015-04-20T17:23:16Z","updated_at":"2016-12-22T08:09:20Z","pushed_at":"2016-12-22T02:54:55Z","git_url":"git://github.com/kaldi-asr/kaldi.git","ssh_url":"git@github.com:kaldi-asr/kaldi.git","clone_url":"https://github.com/kaldi-asr/kaldi.git","svn_url":"https://github.com/kaldi-asr/kaldi","homepage":"http://kaldi-asr.org","size":104358,"stargazers_count":1385,"watchers_count":1385,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":706,"mirror_url":null,"open_issues_count":105,"forks":706,"open_issues":105,"watchers":1385,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/1249"},"html":{"href":"https://github.com/kaldi-asr/kaldi/pull/1249"},"issue":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1249"},"comments":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1249/comments"},"review_comments":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/1249/comments"},"review_comment":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/1249/commits"},"statuses":{"href":"https://api.github.com/repos/kaldi-asr/kaldi/statuses/1167432c3cf5e5a2d94236b85f77e756b7947a73"}}}}
{"actor":{"display_login":"jtrmal"}}