{"action":"created","issue":{"url":"https://api.github.com/repos/appnexus/sicksync/issues/47","repository_url":"https://api.github.com/repos/appnexus/sicksync","labels_url":"https://api.github.com/repos/appnexus/sicksync/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/appnexus/sicksync/issues/47/comments","events_url":"https://api.github.com/repos/appnexus/sicksync/issues/47/events","html_url":"https://github.com/appnexus/sicksync/issues/47","id":181623532,"number":47,"title":"Excludes aren't 100% excluded","user":{"login":"laggingreflex","id":2523987,"avatar_url":"https://avatars.githubusercontent.com/u/2523987?v=3","gravatar_id":"","url":"https://api.github.com/users/laggingreflex","html_url":"https://github.com/laggingreflex","followers_url":"https://api.github.com/users/laggingreflex/followers","following_url":"https://api.github.com/users/laggingreflex/following{/other_user}","gists_url":"https://api.github.com/users/laggingreflex/gists{/gist_id}","starred_url":"https://api.github.com/users/laggingreflex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laggingreflex/subscriptions","organizations_url":"https://api.github.com/users/laggingreflex/orgs","repos_url":"https://api.github.com/users/laggingreflex/repos","events_url":"https://api.github.com/users/laggingreflex/events{/privacy}","received_events_url":"https://api.github.com/users/laggingreflex/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-07T09:31:50Z","updated_at":"2016-10-07T09:42:09Z","closed_at":null,"body":"It seems ignored paths aren't 100% ignored. Like if I change something in the .git directory, surely it doesn't actually get uploaded but it still triggers a file change event, meaning it's still being monitored which is unnecessary. Having a huge node_modules or otherwise ignored folders cause it to take up considerable time to start up.\r\n\r\nThis can be tested by putting a console log here: [src\\local\\fs-helper.js](../blob/master/src/local/fs-helper.js#L38) and changing any file in one of the ignored folders, `.git/info/excludes`"},"comment":{"url":"https://api.github.com/repos/appnexus/sicksync/issues/comments/252198274","html_url":"https://github.com/appnexus/sicksync/issues/47#issuecomment-252198274","issue_url":"https://api.github.com/repos/appnexus/sicksync/issues/47","id":252198274,"user":{"login":"laggingreflex","id":2523987,"avatar_url":"https://avatars.githubusercontent.com/u/2523987?v=3","gravatar_id":"","url":"https://api.github.com/users/laggingreflex","html_url":"https://github.com/laggingreflex","followers_url":"https://api.github.com/users/laggingreflex/followers","following_url":"https://api.github.com/users/laggingreflex/following{/other_user}","gists_url":"https://api.github.com/users/laggingreflex/gists{/gist_id}","starred_url":"https://api.github.com/users/laggingreflex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laggingreflex/subscriptions","organizations_url":"https://api.github.com/users/laggingreflex/orgs","repos_url":"https://api.github.com/users/laggingreflex/repos","events_url":"https://api.github.com/users/laggingreflex/events{/privacy}","received_events_url":"https://api.github.com/users/laggingreflex/received_events","type":"User","site_admin":false},"created_at":"2016-10-07T09:42:09Z","updated_at":"2016-10-07T09:42:09Z","body":"It seems the cause of this is the format of exclude patterns. `.git/**`, and `.git/**/*` don't work, but what worked for me was `**/.git`. It has something to do with how [chokidar]/[anymatch] parses and matches these ignore patterns...\r\n\r\n[chokidar]: https://github.com/paulmillr/chokidar\r\n[anymatch]: https://github.com/es128/anymatch"}}
{"actor":{"display_login":"laggingreflex"}}