{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/54290839","id":54290839,"diff_hunk":"@@ -245,6 +257,9 @@ private void WatchForFileSystemEventsThreadStart(object arg)\n \n                         // When we get here, we've requested to stop so cleanup the EventStream and unschedule from the RunLoop\n                         Interop.EventStream.FSEventStreamStop(_eventStream);\n+\n+                        // Release the lock on the root directory\n+                        UnlockRootDirectory(_rootHandle);","path":"src/System.IO.FileSystem.Watcher/src/System/IO/FileSystemWatcher.OSX.cs","position":32,"original_position":32,"commit_id":"968045fc93b4350d152881e025ae704ef1b6ebd5","original_commit_id":"968045fc93b4350d152881e025ae704ef1b6ebd5","user":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"body":"I was relying on the underlying SafeFileHandle to unlock in this case, but I'll make it explicit and add a Catch statement and unlock in there","created_at":"2016-02-26T19:37:19Z","updated_at":"2016-02-26T19:37:19Z","html_url":"https://github.com/dotnet/corefx/pull/6319#discussion_r54290839","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/6319","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/54290839"},"html":{"href":"https://github.com/dotnet/corefx/pull/6319#discussion_r54290839"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6319"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/6319","id":60247171,"html_url":"https://github.com/dotnet/corefx/pull/6319","diff_url":"https://github.com/dotnet/corefx/pull/6319.diff","patch_url":"https://github.com/dotnet/corefx/pull/6319.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/6319","number":6319,"state":"open","locked":false,"title":"Fixing bug #2279 to lock the root folder of all FileSystemWatchers","user":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"body":"Fixing bug #2279 to lock the root folder of all FileSystemWatchers to match the functionality on Windows\r\n\r\ncc @stephentoub ","created_at":"2016-02-22T21:50:55Z","updated_at":"2016-02-26T19:37:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc45544da7262185c215e48ebfcd4296ef539103","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/6319/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/6319/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/6319/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/968045fc93b4350d152881e025ae704ef1b6ebd5","head":{"label":"sokket:fsw","ref":"fsw","sha":"968045fc93b4350d152881e025ae704ef1b6ebd5","user":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"repo":{"id":31975260,"name":"corefx","full_name":"sokket/corefx","owner":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sokket/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/sokket/corefx","forks_url":"https://api.github.com/repos/sokket/corefx/forks","keys_url":"https://api.github.com/repos/sokket/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sokket/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sokket/corefx/teams","hooks_url":"https://api.github.com/repos/sokket/corefx/hooks","issue_events_url":"https://api.github.com/repos/sokket/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/sokket/corefx/events","assignees_url":"https://api.github.com/repos/sokket/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/sokket/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/sokket/corefx/tags","blobs_url":"https://api.github.com/repos/sokket/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sokket/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sokket/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/sokket/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sokket/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/sokket/corefx/languages","stargazers_url":"https://api.github.com/repos/sokket/corefx/stargazers","contributors_url":"https://api.github.com/repos/sokket/corefx/contributors","subscribers_url":"https://api.github.com/repos/sokket/corefx/subscribers","subscription_url":"https://api.github.com/repos/sokket/corefx/subscription","commits_url":"https://api.github.com/repos/sokket/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/sokket/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/sokket/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/sokket/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/sokket/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/sokket/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sokket/corefx/merges","archive_url":"https://api.github.com/repos/sokket/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sokket/corefx/downloads","issues_url":"https://api.github.com/repos/sokket/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/sokket/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/sokket/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/sokket/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sokket/corefx/labels{/name}","releases_url":"https://api.github.com/repos/sokket/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/sokket/corefx/deployments","created_at":"2015-03-10T18:45:28Z","updated_at":"2016-01-12T19:55:50Z","pushed_at":"2016-02-25T22:47:13Z","git_url":"git://github.com/sokket/corefx.git","ssh_url":"git@github.com:sokket/corefx.git","clone_url":"https://github.com/sokket/corefx.git","svn_url":"https://github.com/sokket/corefx","homepage":"","size":56674,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"a311e2935705566e3369c3f9a8c659dc08abb992","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-02-26T18:37:02Z","pushed_at":"2016-02-26T19:10:04Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":67579,"stargazers_count":9201,"watchers_count":9201,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2151,"mirror_url":null,"open_issues_count":876,"forks":2151,"open_issues":876,"watchers":9201,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6319"},"html":{"href":"https://github.com/dotnet/corefx/pull/6319"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/6319"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/6319/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6319/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6319/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/968045fc93b4350d152881e025ae704ef1b6ebd5"}}}}