{"action":"created","comment":{"url":"https://api.github.com/repos/lbryio/lbry.io/pulls/comments/82790640","pull_request_review_id":3672789,"id":82790640,"diff_hunk":"@@ -45,13 +48,28 @@ public static function doCurl($method, $url, $params = [], $options = [])\n       throw new DomainException('Invalid curl options: ' . join(', ', array_keys($invalid)));\n     }\n \n-    $options = array_merge($defaults, $options);\n-\n     if (!in_array($method, [static::GET, static::POST, static::PUT]))\n     {\n       throw new DomainException('Invalid method: ' . $method);\n     }\n \n+    $options = array_merge($defaults, $options);\n+\n+    if (!Apc::isEnabled())\n+    {\n+      $options['cache'] = false;\n+    }\n+\n+    if ($options['cache'])","path":"lib/tools/Curl.class.php","position":49,"original_position":49,"commit_id":"01a14aa04ed3f0dd4b2cb6e876a72fb06f277e2c","original_commit_id":"5af86a3f9962519b247d0318e79e23f0b80d2dc5","user":{"login":"kauffj","id":530774,"avatar_url":"https://avatars.githubusercontent.com/u/530774?v=3","gravatar_id":"","url":"https://api.github.com/users/kauffj","html_url":"https://github.com/kauffj","followers_url":"https://api.github.com/users/kauffj/followers","following_url":"https://api.github.com/users/kauffj/following{/other_user}","gists_url":"https://api.github.com/users/kauffj/gists{/gist_id}","starred_url":"https://api.github.com/users/kauffj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kauffj/subscriptions","organizations_url":"https://api.github.com/users/kauffj/orgs","repos_url":"https://api.github.com/users/kauffj/repos","events_url":"https://api.github.com/users/kauffj/events{/privacy}","received_events_url":"https://api.github.com/users/kauffj/received_events","type":"User","site_admin":false},"body":"If the choices are either:\r\n1) Have an APC wrapper version of cURL\r\n2) Allow cURL to cache\r\n\r\nI pick the second. Feel free to refactor or suggest something else.","created_at":"2016-10-11T13:24:34Z","updated_at":"2016-10-11T13:24:34Z","html_url":"https://github.com/lbryio/lbry.io/pull/77#discussion_r82790640","pull_request_url":"https://api.github.com/repos/lbryio/lbry.io/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/lbryio/lbry.io/pulls/comments/82790640"},"html":{"href":"https://github.com/lbryio/lbry.io/pull/77#discussion_r82790640"},"pull_request":{"href":"https://api.github.com/repos/lbryio/lbry.io/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/lbryio/lbry.io/pulls/77","id":88354947,"html_url":"https://github.com/lbryio/lbry.io/pull/77","diff_url":"https://github.com/lbryio/lbry.io/pull/77.diff","patch_url":"https://github.com/lbryio/lbry.io/pull/77.patch","issue_url":"https://api.github.com/repos/lbryio/lbry.io/issues/77","number":77,"state":"open","locked":false,"title":"Roadmap","user":{"login":"kauffj","id":530774,"avatar_url":"https://avatars.githubusercontent.com/u/530774?v=3","gravatar_id":"","url":"https://api.github.com/users/kauffj","html_url":"https://github.com/kauffj","followers_url":"https://api.github.com/users/kauffj/followers","following_url":"https://api.github.com/users/kauffj/following{/other_user}","gists_url":"https://api.github.com/users/kauffj/gists{/gist_id}","starred_url":"https://api.github.com/users/kauffj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kauffj/subscriptions","organizations_url":"https://api.github.com/users/kauffj/orgs","repos_url":"https://api.github.com/users/kauffj/repos","events_url":"https://api.github.com/users/kauffj/events{/privacy}","received_events_url":"https://api.github.com/users/kauffj/received_events","type":"User","site_admin":false},"body":"If you don't know where you're going then any road will take you there","created_at":"2016-10-06T22:47:24Z","updated_at":"2016-10-11T13:24:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e541b45b68480e0b4a31d3f7847d41a97d5749f7","assignee":{"login":"kauffj","id":530774,"avatar_url":"https://avatars.githubusercontent.com/u/530774?v=3","gravatar_id":"","url":"https://api.github.com/users/kauffj","html_url":"https://github.com/kauffj","followers_url":"https://api.github.com/users/kauffj/followers","following_url":"https://api.github.com/users/kauffj/following{/other_user}","gists_url":"https://api.github.com/users/kauffj/gists{/gist_id}","starred_url":"https://api.github.com/users/kauffj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kauffj/subscriptions","organizations_url":"https://api.github.com/users/kauffj/orgs","repos_url":"https://api.github.com/users/kauffj/repos","events_url":"https://api.github.com/users/kauffj/events{/privacy}","received_events_url":"https://api.github.com/users/kauffj/received_events","type":"User","site_admin":false},"assignees":[{"login":"kauffj","id":530774,"avatar_url":"https://avatars.githubusercontent.com/u/530774?v=3","gravatar_id":"","url":"https://api.github.com/users/kauffj","html_url":"https://github.com/kauffj","followers_url":"https://api.github.com/users/kauffj/followers","following_url":"https://api.github.com/users/kauffj/following{/other_user}","gists_url":"https://api.github.com/users/kauffj/gists{/gist_id}","starred_url":"https://api.github.com/users/kauffj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kauffj/subscriptions","organizations_url":"https://api.github.com/users/kauffj/orgs","repos_url":"https://api.github.com/users/kauffj/repos","events_url":"https://api.github.com/users/kauffj/events{/privacy}","received_events_url":"https://api.github.com/users/kauffj/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/lbryio/lbry.io/pulls/77/commits","review_comments_url":"https://api.github.com/repos/lbryio/lbry.io/pulls/77/comments","review_comment_url":"https://api.github.com/repos/lbryio/lbry.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lbryio/lbry.io/issues/77/comments","statuses_url":"https://api.github.com/repos/lbryio/lbry.io/statuses/01a14aa04ed3f0dd4b2cb6e876a72fb06f277e2c","head":{"label":"lbryio:roadmap","ref":"roadmap","sha":"01a14aa04ed3f0dd4b2cb6e876a72fb06f277e2c","user":{"login":"lbryio","id":13889222,"avatar_url":"https://avatars.githubusercontent.com/u/13889222?v=3","gravatar_id":"","url":"https://api.github.com/users/lbryio","html_url":"https://github.com/lbryio","followers_url":"https://api.github.com/users/lbryio/followers","following_url":"https://api.github.com/users/lbryio/following{/other_user}","gists_url":"https://api.github.com/users/lbryio/gists{/gist_id}","starred_url":"https://api.github.com/users/lbryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbryio/subscriptions","organizations_url":"https://api.github.com/users/lbryio/orgs","repos_url":"https://api.github.com/users/lbryio/repos","events_url":"https://api.github.com/users/lbryio/events{/privacy}","received_events_url":"https://api.github.com/users/lbryio/received_events","type":"Organization","site_admin":false},"repo":{"id":43893530,"name":"lbry.io","full_name":"lbryio/lbry.io","owner":{"login":"lbryio","id":13889222,"avatar_url":"https://avatars.githubusercontent.com/u/13889222?v=3","gravatar_id":"","url":"https://api.github.com/users/lbryio","html_url":"https://github.com/lbryio","followers_url":"https://api.github.com/users/lbryio/followers","following_url":"https://api.github.com/users/lbryio/following{/other_user}","gists_url":"https://api.github.com/users/lbryio/gists{/gist_id}","starred_url":"https://api.github.com/users/lbryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbryio/subscriptions","organizations_url":"https://api.github.com/users/lbryio/orgs","repos_url":"https://api.github.com/users/lbryio/repos","events_url":"https://api.github.com/users/lbryio/events{/privacy}","received_events_url":"https://api.github.com/users/lbryio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lbryio/lbry.io","description":"The lbry.io website","fork":false,"url":"https://api.github.com/repos/lbryio/lbry.io","forks_url":"https://api.github.com/repos/lbryio/lbry.io/forks","keys_url":"https://api.github.com/repos/lbryio/lbry.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lbryio/lbry.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lbryio/lbry.io/teams","hooks_url":"https://api.github.com/repos/lbryio/lbry.io/hooks","issue_events_url":"https://api.github.com/repos/lbryio/lbry.io/issues/events{/number}","events_url":"https://api.github.com/repos/lbryio/lbry.io/events","assignees_url":"https://api.github.com/repos/lbryio/lbry.io/assignees{/user}","branches_url":"https://api.github.com/repos/lbryio/lbry.io/branches{/branch}","tags_url":"https://api.github.com/repos/lbryio/lbry.io/tags","blobs_url":"https://api.github.com/repos/lbryio/lbry.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lbryio/lbry.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lbryio/lbry.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/lbryio/lbry.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lbryio/lbry.io/statuses/{sha}","languages_url":"https://api.github.com/repos/lbryio/lbry.io/languages","stargazers_url":"https://api.github.com/repos/lbryio/lbry.io/stargazers","contributors_url":"https://api.github.com/repos/lbryio/lbry.io/contributors","subscribers_url":"https://api.github.com/repos/lbryio/lbry.io/subscribers","subscription_url":"https://api.github.com/repos/lbryio/lbry.io/subscription","commits_url":"https://api.github.com/repos/lbryio/lbry.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/lbryio/lbry.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/lbryio/lbry.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/lbryio/lbry.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/lbryio/lbry.io/contents/{+path}","compare_url":"https://api.github.com/repos/lbryio/lbry.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lbryio/lbry.io/merges","archive_url":"https://api.github.com/repos/lbryio/lbry.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lbryio/lbry.io/downloads","issues_url":"https://api.github.com/repos/lbryio/lbry.io/issues{/number}","pulls_url":"https://api.github.com/repos/lbryio/lbry.io/pulls{/number}","milestones_url":"https://api.github.com/repos/lbryio/lbry.io/milestones{/number}","notifications_url":"https://api.github.com/repos/lbryio/lbry.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lbryio/lbry.io/labels{/name}","releases_url":"https://api.github.com/repos/lbryio/lbry.io/releases{/id}","deployments_url":"https://api.github.com/repos/lbryio/lbry.io/deployments","created_at":"2015-10-08T14:20:20Z","updated_at":"2016-09-04T04:16:58Z","pushed_at":"2016-10-11T13:12:04Z","git_url":"git://github.com/lbryio/lbry.io.git","ssh_url":"git@github.com:lbryio/lbry.io.git","clone_url":"https://github.com/lbryio/lbry.io.git","svn_url":"https://github.com/lbryio/lbry.io","homepage":"https://lbry.io","size":76642,"stargazers_count":12,"watchers_count":12,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":2,"forks":20,"open_issues":2,"watchers":12,"default_branch":"master"}},"base":{"label":"lbryio:master","ref":"master","sha":"a972a3ba44f9ef39967440c8e9ef065c10cc31ce","user":{"login":"lbryio","id":13889222,"avatar_url":"https://avatars.githubusercontent.com/u/13889222?v=3","gravatar_id":"","url":"https://api.github.com/users/lbryio","html_url":"https://github.com/lbryio","followers_url":"https://api.github.com/users/lbryio/followers","following_url":"https://api.github.com/users/lbryio/following{/other_user}","gists_url":"https://api.github.com/users/lbryio/gists{/gist_id}","starred_url":"https://api.github.com/users/lbryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbryio/subscriptions","organizations_url":"https://api.github.com/users/lbryio/orgs","repos_url":"https://api.github.com/users/lbryio/repos","events_url":"https://api.github.com/users/lbryio/events{/privacy}","received_events_url":"https://api.github.com/users/lbryio/received_events","type":"Organization","site_admin":false},"repo":{"id":43893530,"name":"lbry.io","full_name":"lbryio/lbry.io","owner":{"login":"lbryio","id":13889222,"avatar_url":"https://avatars.githubusercontent.com/u/13889222?v=3","gravatar_id":"","url":"https://api.github.com/users/lbryio","html_url":"https://github.com/lbryio","followers_url":"https://api.github.com/users/lbryio/followers","following_url":"https://api.github.com/users/lbryio/following{/other_user}","gists_url":"https://api.github.com/users/lbryio/gists{/gist_id}","starred_url":"https://api.github.com/users/lbryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbryio/subscriptions","organizations_url":"https://api.github.com/users/lbryio/orgs","repos_url":"https://api.github.com/users/lbryio/repos","events_url":"https://api.github.com/users/lbryio/events{/privacy}","received_events_url":"https://api.github.com/users/lbryio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lbryio/lbry.io","description":"The lbry.io website","fork":false,"url":"https://api.github.com/repos/lbryio/lbry.io","forks_url":"https://api.github.com/repos/lbryio/lbry.io/forks","keys_url":"https://api.github.com/repos/lbryio/lbry.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lbryio/lbry.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lbryio/lbry.io/teams","hooks_url":"https://api.github.com/repos/lbryio/lbry.io/hooks","issue_events_url":"https://api.github.com/repos/lbryio/lbry.io/issues/events{/number}","events_url":"https://api.github.com/repos/lbryio/lbry.io/events","assignees_url":"https://api.github.com/repos/lbryio/lbry.io/assignees{/user}","branches_url":"https://api.github.com/repos/lbryio/lbry.io/branches{/branch}","tags_url":"https://api.github.com/repos/lbryio/lbry.io/tags","blobs_url":"https://api.github.com/repos/lbryio/lbry.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lbryio/lbry.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lbryio/lbry.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/lbryio/lbry.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lbryio/lbry.io/statuses/{sha}","languages_url":"https://api.github.com/repos/lbryio/lbry.io/languages","stargazers_url":"https://api.github.com/repos/lbryio/lbry.io/stargazers","contributors_url":"https://api.github.com/repos/lbryio/lbry.io/contributors","subscribers_url":"https://api.github.com/repos/lbryio/lbry.io/subscribers","subscription_url":"https://api.github.com/repos/lbryio/lbry.io/subscription","commits_url":"https://api.github.com/repos/lbryio/lbry.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/lbryio/lbry.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/lbryio/lbry.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/lbryio/lbry.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/lbryio/lbry.io/contents/{+path}","compare_url":"https://api.github.com/repos/lbryio/lbry.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lbryio/lbry.io/merges","archive_url":"https://api.github.com/repos/lbryio/lbry.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lbryio/lbry.io/downloads","issues_url":"https://api.github.com/repos/lbryio/lbry.io/issues{/number}","pulls_url":"https://api.github.com/repos/lbryio/lbry.io/pulls{/number}","milestones_url":"https://api.github.com/repos/lbryio/lbry.io/milestones{/number}","notifications_url":"https://api.github.com/repos/lbryio/lbry.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lbryio/lbry.io/labels{/name}","releases_url":"https://api.github.com/repos/lbryio/lbry.io/releases{/id}","deployments_url":"https://api.github.com/repos/lbryio/lbry.io/deployments","created_at":"2015-10-08T14:20:20Z","updated_at":"2016-09-04T04:16:58Z","pushed_at":"2016-10-11T13:12:04Z","git_url":"git://github.com/lbryio/lbry.io.git","ssh_url":"git@github.com:lbryio/lbry.io.git","clone_url":"https://github.com/lbryio/lbry.io.git","svn_url":"https://github.com/lbryio/lbry.io","homepage":"https://lbry.io","size":76642,"stargazers_count":12,"watchers_count":12,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":2,"forks":20,"open_issues":2,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lbryio/lbry.io/pulls/77"},"html":{"href":"https://github.com/lbryio/lbry.io/pull/77"},"issue":{"href":"https://api.github.com/repos/lbryio/lbry.io/issues/77"},"comments":{"href":"https://api.github.com/repos/lbryio/lbry.io/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/lbryio/lbry.io/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/lbryio/lbry.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lbryio/lbry.io/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/lbryio/lbry.io/statuses/01a14aa04ed3f0dd4b2cb6e876a72fb06f277e2c"}}}}
{"actor":{"display_login":"kauffj"}}