{"action":"created","comment":{"url":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments/75947857","id":75947857,"diff_hunk":"@@ -30,32 +30,22 @@ SERVICES=\"perfmon xapi v6d xenopsd xenopsd-xc xenopsd-xenlight xenopsd-simulator\n \n TO_RESTART=\"\"\n for svc in $SERVICES ; do\n-\t# mpathalert-daemon isn't a systemd service so needs to be handled specially\n-\tif [ $svc == mpathalert-daemon -a $POOLCONF == \"master\" ] ; then\n-\t\tTO_RESTART=\"$svc $TO_RESTART\"\n-\t\t@ETCDIR@/master.d/03-mpathalert-daemon stop\n-\t\tcontinue\n-\tfi\n+\tif [ $svc == mpathalert-daemon -a $POOLCONF == \"master\" ] ; then\t\t\n+ \t\tTO_RESTART=\"$svc $TO_RESTART\"\t\t\n+ \t\tcontinue\t\t\n+ \tfi\t\n \n-\t# restart other services only if systemd said they were enabled\n+\t# restart services only if systemd said they were enabled\n \tsystemctl is-enabled $svc >/dev/null 2>&1\n \n \tif [ $? -eq 0 ] ; then\n \t\tTO_RESTART=\"$svc $TO_RESTART\"\n-\t\taction \"systemctl stop $svc\" systemctl stop $svc\n \tfi\n done\n \n set -e\n \n-for svc in $TO_RESTART ; do\n-\t# mpathalert-daemon isn't a systemd service so needs to be handled specially\n-\tif [ $svc == mpathalert-daemon ] ; then \n-\t\t@ETCDIR@/master.d/03-mpathalert-daemon start\n-\t\tcontinue\n-\tfi\n-\taction \"systemctl start $svc\" systemctl start $svc\n-done\n+systemctl try-restart $TO_RESTART","path":"scripts/xe-toolstack-restart","position":null,"original_position":35,"commit_id":"dfa63ff0f5aefd2795b6f3fec7afa606128aed96","original_commit_id":"dfa63ff0f5aefd2795b6f3fec7afa606128aed96","user":{"login":"robhoes","id":413005,"avatar_url":"https://avatars.githubusercontent.com/u/413005?v=3","gravatar_id":"","url":"https://api.github.com/users/robhoes","html_url":"https://github.com/robhoes","followers_url":"https://api.github.com/users/robhoes/followers","following_url":"https://api.github.com/users/robhoes/following{/other_user}","gists_url":"https://api.github.com/users/robhoes/gists{/gist_id}","starred_url":"https://api.github.com/users/robhoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robhoes/subscriptions","organizations_url":"https://api.github.com/users/robhoes/orgs","repos_url":"https://api.github.com/users/robhoes/repos","events_url":"https://api.github.com/users/robhoes/events{/privacy}","received_events_url":"https://api.github.com/users/robhoes/received_events","type":"User","site_admin":false},"body":"Use `restart` so that the services get started even if not running.","created_at":"2016-08-23T20:49:40Z","updated_at":"2016-08-23T20:49:40Z","html_url":"https://github.com/xapi-project/xen-api/pull/2734#discussion_r75947857","pull_request_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2734","_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments/75947857"},"html":{"href":"https://github.com/xapi-project/xen-api/pull/2734#discussion_r75947857"},"pull_request":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2734"}}},"pull_request":{"url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2734","id":81807995,"html_url":"https://github.com/xapi-project/xen-api/pull/2734","diff_url":"https://github.com/xapi-project/xen-api/pull/2734.diff","patch_url":"https://github.com/xapi-project/xen-api/pull/2734.patch","issue_url":"https://api.github.com/repos/xapi-project/xen-api/issues/2734","number":2734,"state":"open","locked":false,"title":"CP-15132: Systemd conversion","user":{"login":"rafalmiel","id":3881998,"avatar_url":"https://avatars.githubusercontent.com/u/3881998?v=3","gravatar_id":"","url":"https://api.github.com/users/rafalmiel","html_url":"https://github.com/rafalmiel","followers_url":"https://api.github.com/users/rafalmiel/followers","following_url":"https://api.github.com/users/rafalmiel/following{/other_user}","gists_url":"https://api.github.com/users/rafalmiel/gists{/gist_id}","starred_url":"https://api.github.com/users/rafalmiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafalmiel/subscriptions","organizations_url":"https://api.github.com/users/rafalmiel/orgs","repos_url":"https://api.github.com/users/rafalmiel/repos","events_url":"https://api.github.com/users/rafalmiel/events{/privacy}","received_events_url":"https://api.github.com/users/rafalmiel/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-18T12:35:39Z","updated_at":"2016-08-23T20:49:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ffcb61199d63a8e91a8edf38cdf8daa97ad2465","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2734/commits","review_comments_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/2734/comments","review_comment_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xapi-project/xen-api/issues/2734/comments","statuses_url":"https://api.github.com/repos/xapi-project/xen-api/statuses/dfa63ff0f5aefd2795b6f3fec7afa606128aed96","head":{"label":"rafalmiel:systemd-cp-15132","ref":"systemd-cp-15132","sha":"dfa63ff0f5aefd2795b6f3fec7afa606128aed96","user":{"login":"rafalmiel","id":3881998,"avatar_url":"https://avatars.githubusercontent.com/u/3881998?v=3","gravatar_id":"","url":"https://api.github.com/users/rafalmiel","html_url":"https://github.com/rafalmiel","followers_url":"https://api.github.com/users/rafalmiel/followers","following_url":"https://api.github.com/users/rafalmiel/following{/other_user}","gists_url":"https://api.github.com/users/rafalmiel/gists{/gist_id}","starred_url":"https://api.github.com/users/rafalmiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafalmiel/subscriptions","organizations_url":"https://api.github.com/users/rafalmiel/orgs","repos_url":"https://api.github.com/users/rafalmiel/repos","events_url":"https://api.github.com/users/rafalmiel/events{/privacy}","received_events_url":"https://api.github.com/users/rafalmiel/received_events","type":"User","site_admin":false},"repo":{"id":65205935,"name":"xen-api","full_name":"rafalmiel/xen-api","owner":{"login":"rafalmiel","id":3881998,"avatar_url":"https://avatars.githubusercontent.com/u/3881998?v=3","gravatar_id":"","url":"https://api.github.com/users/rafalmiel","html_url":"https://github.com/rafalmiel","followers_url":"https://api.github.com/users/rafalmiel/followers","following_url":"https://api.github.com/users/rafalmiel/following{/other_user}","gists_url":"https://api.github.com/users/rafalmiel/gists{/gist_id}","starred_url":"https://api.github.com/users/rafalmiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafalmiel/subscriptions","organizations_url":"https://api.github.com/users/rafalmiel/orgs","repos_url":"https://api.github.com/users/rafalmiel/repos","events_url":"https://api.github.com/users/rafalmiel/events{/privacy}","received_events_url":"https://api.github.com/users/rafalmiel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rafalmiel/xen-api","description":"The Xapi Project's XenAPI Server","fork":true,"url":"https://api.github.com/repos/rafalmiel/xen-api","forks_url":"https://api.github.com/repos/rafalmiel/xen-api/forks","keys_url":"https://api.github.com/repos/rafalmiel/xen-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rafalmiel/xen-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rafalmiel/xen-api/teams","hooks_url":"https://api.github.com/repos/rafalmiel/xen-api/hooks","issue_events_url":"https://api.github.com/repos/rafalmiel/xen-api/issues/events{/number}","events_url":"https://api.github.com/repos/rafalmiel/xen-api/events","assignees_url":"https://api.github.com/repos/rafalmiel/xen-api/assignees{/user}","branches_url":"https://api.github.com/repos/rafalmiel/xen-api/branches{/branch}","tags_url":"https://api.github.com/repos/rafalmiel/xen-api/tags","blobs_url":"https://api.github.com/repos/rafalmiel/xen-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rafalmiel/xen-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rafalmiel/xen-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/rafalmiel/xen-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rafalmiel/xen-api/statuses/{sha}","languages_url":"https://api.github.com/repos/rafalmiel/xen-api/languages","stargazers_url":"https://api.github.com/repos/rafalmiel/xen-api/stargazers","contributors_url":"https://api.github.com/repos/rafalmiel/xen-api/contributors","subscribers_url":"https://api.github.com/repos/rafalmiel/xen-api/subscribers","subscription_url":"https://api.github.com/repos/rafalmiel/xen-api/subscription","commits_url":"https://api.github.com/repos/rafalmiel/xen-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/rafalmiel/xen-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/rafalmiel/xen-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/rafalmiel/xen-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/rafalmiel/xen-api/contents/{+path}","compare_url":"https://api.github.com/repos/rafalmiel/xen-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rafalmiel/xen-api/merges","archive_url":"https://api.github.com/repos/rafalmiel/xen-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rafalmiel/xen-api/downloads","issues_url":"https://api.github.com/repos/rafalmiel/xen-api/issues{/number}","pulls_url":"https://api.github.com/repos/rafalmiel/xen-api/pulls{/number}","milestones_url":"https://api.github.com/repos/rafalmiel/xen-api/milestones{/number}","notifications_url":"https://api.github.com/repos/rafalmiel/xen-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rafalmiel/xen-api/labels{/name}","releases_url":"https://api.github.com/repos/rafalmiel/xen-api/releases{/id}","deployments_url":"https://api.github.com/repos/rafalmiel/xen-api/deployments","created_at":"2016-08-08T13:21:43Z","updated_at":"2016-08-08T13:21:47Z","pushed_at":"2016-08-23T16:46:07Z","git_url":"git://github.com/rafalmiel/xen-api.git","ssh_url":"git@github.com:rafalmiel/xen-api.git","clone_url":"https://github.com/rafalmiel/xen-api.git","svn_url":"https://github.com/rafalmiel/xen-api","homepage":"http://xenproject.org/developers/teams/xapi.html","size":24394,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xapi-project:master","ref":"master","sha":"2e6d3e26408da0abde3ac35d72a2772a9a3fabf8","user":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars.githubusercontent.com/u/317268?v=3","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"repo":{"id":960233,"name":"xen-api","full_name":"xapi-project/xen-api","owner":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars.githubusercontent.com/u/317268?v=3","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xapi-project/xen-api","description":"The Xapi Project's XenAPI Server","fork":false,"url":"https://api.github.com/repos/xapi-project/xen-api","forks_url":"https://api.github.com/repos/xapi-project/xen-api/forks","keys_url":"https://api.github.com/repos/xapi-project/xen-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapi-project/xen-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapi-project/xen-api/teams","hooks_url":"https://api.github.com/repos/xapi-project/xen-api/hooks","issue_events_url":"https://api.github.com/repos/xapi-project/xen-api/issues/events{/number}","events_url":"https://api.github.com/repos/xapi-project/xen-api/events","assignees_url":"https://api.github.com/repos/xapi-project/xen-api/assignees{/user}","branches_url":"https://api.github.com/repos/xapi-project/xen-api/branches{/branch}","tags_url":"https://api.github.com/repos/xapi-project/xen-api/tags","blobs_url":"https://api.github.com/repos/xapi-project/xen-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapi-project/xen-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapi-project/xen-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapi-project/xen-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapi-project/xen-api/statuses/{sha}","languages_url":"https://api.github.com/repos/xapi-project/xen-api/languages","stargazers_url":"https://api.github.com/repos/xapi-project/xen-api/stargazers","contributors_url":"https://api.github.com/repos/xapi-project/xen-api/contributors","subscribers_url":"https://api.github.com/repos/xapi-project/xen-api/subscribers","subscription_url":"https://api.github.com/repos/xapi-project/xen-api/subscription","commits_url":"https://api.github.com/repos/xapi-project/xen-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapi-project/xen-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapi-project/xen-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapi-project/xen-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/xapi-project/xen-api/contents/{+path}","compare_url":"https://api.github.com/repos/xapi-project/xen-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapi-project/xen-api/merges","archive_url":"https://api.github.com/repos/xapi-project/xen-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapi-project/xen-api/downloads","issues_url":"https://api.github.com/repos/xapi-project/xen-api/issues{/number}","pulls_url":"https://api.github.com/repos/xapi-project/xen-api/pulls{/number}","milestones_url":"https://api.github.com/repos/xapi-project/xen-api/milestones{/number}","notifications_url":"https://api.github.com/repos/xapi-project/xen-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapi-project/xen-api/labels{/name}","releases_url":"https://api.github.com/repos/xapi-project/xen-api/releases{/id}","deployments_url":"https://api.github.com/repos/xapi-project/xen-api/deployments","created_at":"2010-10-04T10:52:57Z","updated_at":"2016-08-22T08:54:18Z","pushed_at":"2016-08-23T16:46:07Z","git_url":"git://github.com/xapi-project/xen-api.git","ssh_url":"git@github.com:xapi-project/xen-api.git","clone_url":"https://github.com/xapi-project/xen-api.git","svn_url":"https://github.com/xapi-project/xen-api","homepage":"http://xenproject.org/developers/teams/xapi.html","size":39269,"stargazers_count":218,"watchers_count":218,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"open_issues_count":16,"forks":154,"open_issues":16,"watchers":218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2734"},"html":{"href":"https://github.com/xapi-project/xen-api/pull/2734"},"issue":{"href":"https://api.github.com/repos/xapi-project/xen-api/issues/2734"},"comments":{"href":"https://api.github.com/repos/xapi-project/xen-api/issues/2734/comments"},"review_comments":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2734/comments"},"review_comment":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/2734/commits"},"statuses":{"href":"https://api.github.com/repos/xapi-project/xen-api/statuses/dfa63ff0f5aefd2795b6f3fec7afa606128aed96"}}}}
{"actor":{"display_login":"robhoes"}}