{"action":"created","comment":{"url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/pulls/comments/90255208","pull_request_review_id":10776494,"id":90255208,"diff_hunk":"@@ -24,72 +42,161 @@ Does:\n 4. Store default filter value, which selects DHCPACK and DHCPREQUESTS in a DHCP mask.\n 5. Store those values in DHCP-Forwarder.toml in the working directory.\n \n+Note: Do not select a Wireless device, it will not work.\n \n-dhcp-forwarder.exe\n-===========\n-A quick go tool to mirror a UDP DHCP packet capture based on a BPF and forward it to a configured host and port.\n-Support a configuration file in DHCP-Forwarder in TOML format, that needs to be present in the same directory as the binary.\n+The DHCP-Forwarder service needs to be restarted:\n \n-DHCP-Forwarder.toml file is expected to be present in the working directory, which is generated from dhcp-forwarder-config-generator.exe\n+1. After a configuration change\n+2. When the server goes to sleep and resumes\n \n \n-Native Compilation under x64:\n-===========\n-You will need:\n+The installer\n+-------------\n+The installer will:","path":"README.md","position":74,"original_position":74,"commit_id":"590e8ac4a5841cd5e5bd41fbf4a246cc8cf1483b","original_commit_id":"590e8ac4a5841cd5e5bd41fbf4a246cc8cf1483b","user":{"login":"extrafu","id":1616141,"avatar_url":"https://avatars.githubusercontent.com/u/1616141?v=3","gravatar_id":"","url":"https://api.github.com/users/extrafu","html_url":"https://github.com/extrafu","followers_url":"https://api.github.com/users/extrafu/followers","following_url":"https://api.github.com/users/extrafu/following{/other_user}","gists_url":"https://api.github.com/users/extrafu/gists{/gist_id}","starred_url":"https://api.github.com/users/extrafu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/extrafu/subscriptions","organizations_url":"https://api.github.com/users/extrafu/orgs","repos_url":"https://api.github.com/users/extrafu/repos","events_url":"https://api.github.com/users/extrafu/events{/privacy}","received_events_url":"https://api.github.com/users/extrafu/received_events","type":"User","site_admin":false},"body":"start each bullet with a lower-case letter, only the last line should have a trailing dot.","created_at":"2016-11-30T15:29:00Z","updated_at":"2016-11-30T15:29:00Z","html_url":"https://github.com/inverse-inc/packetfence-dhcp-forwarder/pull/4#discussion_r90255208","pull_request_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/pulls/comments/90255208"},"html":{"href":"https://github.com/inverse-inc/packetfence-dhcp-forwarder/pull/4#discussion_r90255208"},"pull_request":{"href":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/pulls/4","id":95349832,"html_url":"https://github.com/inverse-inc/packetfence-dhcp-forwarder/pull/4","diff_url":"https://github.com/inverse-inc/packetfence-dhcp-forwarder/pull/4.diff","patch_url":"https://github.com/inverse-inc/packetfence-dhcp-forwarder/pull/4.patch","issue_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/issues/4","number":4,"state":"open","locked":false,"title":"Binary deletion and doc preparation","user":{"login":"tlaurion","id":827570,"avatar_url":"https://avatars.githubusercontent.com/u/827570?v=3","gravatar_id":"","url":"https://api.github.com/users/tlaurion","html_url":"https://github.com/tlaurion","followers_url":"https://api.github.com/users/tlaurion/followers","following_url":"https://api.github.com/users/tlaurion/following{/other_user}","gists_url":"https://api.github.com/users/tlaurion/gists{/gist_id}","starred_url":"https://api.github.com/users/tlaurion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlaurion/subscriptions","organizations_url":"https://api.github.com/users/tlaurion/orgs","repos_url":"https://api.github.com/users/tlaurion/repos","events_url":"https://api.github.com/users/tlaurion/events{/privacy}","received_events_url":"https://api.github.com/users/tlaurion/received_events","type":"User","site_admin":false},"body":"# Description\r\nRead all the README.md\r\n* Binaries got deleted.\r\n* Documentation got segmented\r\n* Test report under dhcp-forwarder\r\n\r\n# Impacts\r\nreplaces udp-reflector for Windows, reduces future IP Helper configuration, mitigate 5/8 of DHCP traffic from tests ran on a 50000 packets capture.\r\n\r\n# Delete branch after merge\r\nYES \r\n\r\n# UPGRADE file entries\r\nReplaces udp-reflector for Windows.\r\n","created_at":"2016-11-25T21:53:46Z","updated_at":"2016-11-30T15:29:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd91e471d4e6110edcfff70a02528aaebce55675","assignee":{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"assignees":[{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/pulls/4/commits","review_comments_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/pulls/4/comments","review_comment_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/issues/4/comments","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/statuses/590e8ac4a5841cd5e5bd41fbf4a246cc8cf1483b","head":{"label":"inverse-inc:feature/Finalize_doc","ref":"feature/Finalize_doc","sha":"590e8ac4a5841cd5e5bd41fbf4a246cc8cf1483b","user":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"repo":{"id":73296702,"name":"packetfence-dhcp-forwarder","full_name":"inverse-inc/packetfence-dhcp-forwarder","owner":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inverse-inc/packetfence-dhcp-forwarder","description":"PacketFence DHCP Forwarder extension","fork":false,"url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder","forks_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/forks","keys_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/teams","hooks_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/hooks","issue_events_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/issues/events{/number}","events_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/events","assignees_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/assignees{/user}","branches_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/branches{/branch}","tags_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/tags","blobs_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/git/refs{/sha}","trees_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/statuses/{sha}","languages_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/languages","stargazers_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/stargazers","contributors_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/contributors","subscribers_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/subscribers","subscription_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/subscription","commits_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/commits{/sha}","git_commits_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/git/commits{/sha}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/comments{/number}","issue_comment_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/issues/comments{/number}","contents_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/contents/{+path}","compare_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/merges","archive_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/downloads","issues_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/issues{/number}","pulls_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/pulls{/number}","milestones_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/milestones{/number}","notifications_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/labels{/name}","releases_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/releases{/id}","deployments_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/deployments","created_at":"2016-11-09T15:34:44Z","updated_at":"2016-11-09T17:36:52Z","pushed_at":"2016-11-30T14:32:51Z","git_url":"git://github.com/inverse-inc/packetfence-dhcp-forwarder.git","ssh_url":"git@github.com:inverse-inc/packetfence-dhcp-forwarder.git","clone_url":"https://github.com/inverse-inc/packetfence-dhcp-forwarder.git","svn_url":"https://github.com/inverse-inc/packetfence-dhcp-forwarder","homepage":"https://packetfence.org/","size":53806,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"inverse-inc:master","ref":"master","sha":"8b2a2f63bfca67d2e12fd2aced0dee096c5afbfd","user":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"repo":{"id":73296702,"name":"packetfence-dhcp-forwarder","full_name":"inverse-inc/packetfence-dhcp-forwarder","owner":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inverse-inc/packetfence-dhcp-forwarder","description":"PacketFence DHCP Forwarder extension","fork":false,"url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder","forks_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/forks","keys_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/teams","hooks_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/hooks","issue_events_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/issues/events{/number}","events_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/events","assignees_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/assignees{/user}","branches_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/branches{/branch}","tags_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/tags","blobs_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/git/refs{/sha}","trees_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/statuses/{sha}","languages_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/languages","stargazers_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/stargazers","contributors_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/contributors","subscribers_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/subscribers","subscription_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/subscription","commits_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/commits{/sha}","git_commits_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/git/commits{/sha}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/comments{/number}","issue_comment_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/issues/comments{/number}","contents_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/contents/{+path}","compare_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/merges","archive_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/downloads","issues_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/issues{/number}","pulls_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/pulls{/number}","milestones_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/milestones{/number}","notifications_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/labels{/name}","releases_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/releases{/id}","deployments_url":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/deployments","created_at":"2016-11-09T15:34:44Z","updated_at":"2016-11-09T17:36:52Z","pushed_at":"2016-11-30T14:32:51Z","git_url":"git://github.com/inverse-inc/packetfence-dhcp-forwarder.git","ssh_url":"git@github.com:inverse-inc/packetfence-dhcp-forwarder.git","clone_url":"https://github.com/inverse-inc/packetfence-dhcp-forwarder.git","svn_url":"https://github.com/inverse-inc/packetfence-dhcp-forwarder","homepage":"https://packetfence.org/","size":53806,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/pulls/4"},"html":{"href":"https://github.com/inverse-inc/packetfence-dhcp-forwarder/pull/4"},"issue":{"href":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/issues/4"},"comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/inverse-inc/packetfence-dhcp-forwarder/statuses/590e8ac4a5841cd5e5bd41fbf4a246cc8cf1483b"}}}}
{"actor":{"display_login":"extrafu"}}