{"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/83560222","pull_request_review_id":4396704,"id":83560222,"diff_hunk":"@@ -1732,6 +1732,26 @@ char_u* skiptowhite_esc(char_u *p) {\n   return p;\n }\n \n+/// Get a number from a string and skip over it, signalling overflows\n+///\n+/// @param[out]  pp  A pointer to a pointer to char_u.\n+///                  It will be advanced past the read number.\n+/// @param[out]  nr  Number read from the string.\n+///\n+/// @return 0 on success, -1 on error\n+int getdigits_safe(char_u **pp, intmax_t *nr)\n+{\n+  errno = 0;\n+  *nr = strtoimax((char *)(*pp), (char **)pp, 10);\n+\n+  if ((*nr == INTMAX_MIN || *nr == INTMAX_MAX)\n+      && errno == ERANGE) {\n+    return -1;\n+  }\n+\n+  return 0;","path":"src/nvim/charset.c","position":21,"original_position":21,"commit_id":"fe2bfa4c8146ec89871021502443c54a017f7b51","original_commit_id":"fe2bfa4c8146ec89871021502443c54a017f7b51","user":{"login":"justinmk","id":1359421,"avatar_url":"https://avatars.githubusercontent.com/u/1359421?v=3","gravatar_id":"","url":"https://api.github.com/users/justinmk","html_url":"https://github.com/justinmk","followers_url":"https://api.github.com/users/justinmk/followers","following_url":"https://api.github.com/users/justinmk/following{/other_user}","gists_url":"https://api.github.com/users/justinmk/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmk/subscriptions","organizations_url":"https://api.github.com/users/justinmk/orgs","repos_url":"https://api.github.com/users/justinmk/repos","events_url":"https://api.github.com/users/justinmk/events{/privacy}","received_events_url":"https://api.github.com/users/justinmk/received_events","type":"User","site_admin":false},"body":"OK/FAIL/NOTDONE (from `vim.h`) is not a boolean, any objection to that? \r\n\r\nMost important is to try to keep the pattern the same. OK=1, if we return 0 in some places to mean \"ok\", that can be unsettling.","created_at":"2016-10-16T21:04:13Z","updated_at":"2016-10-16T21:04:13Z","html_url":"https://github.com/neovim/neovim/pull/5450#discussion_r83560222","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/5450","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/83560222"},"html":{"href":"https://github.com/neovim/neovim/pull/5450#discussion_r83560222"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/5450"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/5450","id":88550327,"html_url":"https://github.com/neovim/neovim/pull/5450","diff_url":"https://github.com/neovim/neovim/pull/5450.diff","patch_url":"https://github.com/neovim/neovim/pull/5450.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/5450","number":5450,"state":"open","locked":false,"title":"[RFC] Fix crash on invalid modelines","user":{"login":"florolf","id":1835,"avatar_url":"https://avatars.githubusercontent.com/u/1835?v=3","gravatar_id":"","url":"https://api.github.com/users/florolf","html_url":"https://github.com/florolf","followers_url":"https://api.github.com/users/florolf/followers","following_url":"https://api.github.com/users/florolf/following{/other_user}","gists_url":"https://api.github.com/users/florolf/gists{/gist_id}","starred_url":"https://api.github.com/users/florolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florolf/subscriptions","organizations_url":"https://api.github.com/users/florolf/orgs","repos_url":"https://api.github.com/users/florolf/repos","events_url":"https://api.github.com/users/florolf/events{/privacy}","received_events_url":"https://api.github.com/users/florolf/received_events","type":"User","site_admin":false},"body":"fixes #5449","created_at":"2016-10-08T16:04:40Z","updated_at":"2016-10-16T21:04:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5221048ca5a7a4b32a39a62ea282c77d4cc5347d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/5450/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/5450/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/5450/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/fe2bfa4c8146ec89871021502443c54a017f7b51","head":{"label":"florolf:fix-modeline-crash","ref":"fix-modeline-crash","sha":"fe2bfa4c8146ec89871021502443c54a017f7b51","user":{"login":"florolf","id":1835,"avatar_url":"https://avatars.githubusercontent.com/u/1835?v=3","gravatar_id":"","url":"https://api.github.com/users/florolf","html_url":"https://github.com/florolf","followers_url":"https://api.github.com/users/florolf/followers","following_url":"https://api.github.com/users/florolf/following{/other_user}","gists_url":"https://api.github.com/users/florolf/gists{/gist_id}","starred_url":"https://api.github.com/users/florolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florolf/subscriptions","organizations_url":"https://api.github.com/users/florolf/orgs","repos_url":"https://api.github.com/users/florolf/repos","events_url":"https://api.github.com/users/florolf/events{/privacy}","received_events_url":"https://api.github.com/users/florolf/received_events","type":"User","site_admin":false},"repo":{"id":70078145,"name":"neovim","full_name":"florolf/neovim","owner":{"login":"florolf","id":1835,"avatar_url":"https://avatars.githubusercontent.com/u/1835?v=3","gravatar_id":"","url":"https://api.github.com/users/florolf","html_url":"https://github.com/florolf","followers_url":"https://api.github.com/users/florolf/followers","following_url":"https://api.github.com/users/florolf/following{/other_user}","gists_url":"https://api.github.com/users/florolf/gists{/gist_id}","starred_url":"https://api.github.com/users/florolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florolf/subscriptions","organizations_url":"https://api.github.com/users/florolf/orgs","repos_url":"https://api.github.com/users/florolf/repos","events_url":"https://api.github.com/users/florolf/events{/privacy}","received_events_url":"https://api.github.com/users/florolf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/florolf/neovim","description":"Vim-fork focused on extensibility and agility.","fork":true,"url":"https://api.github.com/repos/florolf/neovim","forks_url":"https://api.github.com/repos/florolf/neovim/forks","keys_url":"https://api.github.com/repos/florolf/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/florolf/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/florolf/neovim/teams","hooks_url":"https://api.github.com/repos/florolf/neovim/hooks","issue_events_url":"https://api.github.com/repos/florolf/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/florolf/neovim/events","assignees_url":"https://api.github.com/repos/florolf/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/florolf/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/florolf/neovim/tags","blobs_url":"https://api.github.com/repos/florolf/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/florolf/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/florolf/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/florolf/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/florolf/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/florolf/neovim/languages","stargazers_url":"https://api.github.com/repos/florolf/neovim/stargazers","contributors_url":"https://api.github.com/repos/florolf/neovim/contributors","subscribers_url":"https://api.github.com/repos/florolf/neovim/subscribers","subscription_url":"https://api.github.com/repos/florolf/neovim/subscription","commits_url":"https://api.github.com/repos/florolf/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/florolf/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/florolf/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/florolf/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/florolf/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/florolf/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/florolf/neovim/merges","archive_url":"https://api.github.com/repos/florolf/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/florolf/neovim/downloads","issues_url":"https://api.github.com/repos/florolf/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/florolf/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/florolf/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/florolf/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/florolf/neovim/labels{/name}","releases_url":"https://api.github.com/repos/florolf/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/florolf/neovim/deployments","created_at":"2016-10-05T16:27:01Z","updated_at":"2016-10-05T16:27:08Z","pushed_at":"2016-10-16T20:34:47Z","git_url":"git://github.com/florolf/neovim.git","ssh_url":"git@github.com:florolf/neovim.git","clone_url":"https://github.com/florolf/neovim.git","svn_url":"https://github.com/florolf/neovim","homepage":"https://salt.bountysource.com/teams/neovim","size":42671,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"19840728228f66c7f2af88dfc4bcecc26ffa064b","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"Vim-fork focused on extensibility and agility.","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/neovim/neovim/deployments","created_at":"2014-01-31T13:39:22Z","updated_at":"2016-10-16T20:14:23Z","pushed_at":"2016-10-16T20:34:47Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"https://salt.bountysource.com/teams/neovim","size":71968,"stargazers_count":20317,"watchers_count":20317,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1448,"mirror_url":null,"open_issues_count":777,"forks":1448,"open_issues":777,"watchers":20317,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/5450"},"html":{"href":"https://github.com/neovim/neovim/pull/5450"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/5450"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/5450/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/5450/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/5450/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/fe2bfa4c8146ec89871021502443c54a017f7b51"}}}}
{"actor":{"display_login":"justinmk"}}