{"action":"created","issue":{"url":"https://api.github.com/repos/phetsims/joist/issues/374","repository_url":"https://api.github.com/repos/phetsims/joist","labels_url":"https://api.github.com/repos/phetsims/joist/issues/374/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/joist/issues/374/comments","events_url":"https://api.github.com/repos/phetsims/joist/issues/374/events","html_url":"https://github.com/phetsims/joist/issues/374","id":191355797,"number":374,"title":"Modifications to NavBar for Keyboard navigation","user":{"login":"ariel-phet","id":4051174,"avatar_url":"https://avatars.githubusercontent.com/u/4051174?v=3","gravatar_id":"","url":"https://api.github.com/users/ariel-phet","html_url":"https://github.com/ariel-phet","followers_url":"https://api.github.com/users/ariel-phet/followers","following_url":"https://api.github.com/users/ariel-phet/following{/other_user}","gists_url":"https://api.github.com/users/ariel-phet/gists{/gist_id}","starred_url":"https://api.github.com/users/ariel-phet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariel-phet/subscriptions","organizations_url":"https://api.github.com/users/ariel-phet/orgs","repos_url":"https://api.github.com/users/ariel-phet/repos","events_url":"https://api.github.com/users/ariel-phet/events{/privacy}","received_events_url":"https://api.github.com/users/ariel-phet/received_events","type":"User","site_admin":false},"labels":[{"id":322181628,"url":"https://api.github.com/repos/phetsims/joist/labels/design:general","name":"design:general","color":"F6CCDA","default":false},{"id":299601968,"url":"https://api.github.com/repos/phetsims/joist/labels/dev:a11y","name":"dev:a11y","color":"008080","default":false}],"state":"open","locked":false,"assignee":{"login":"ariel-phet","id":4051174,"avatar_url":"https://avatars.githubusercontent.com/u/4051174?v=3","gravatar_id":"","url":"https://api.github.com/users/ariel-phet","html_url":"https://github.com/ariel-phet","followers_url":"https://api.github.com/users/ariel-phet/followers","following_url":"https://api.github.com/users/ariel-phet/following{/other_user}","gists_url":"https://api.github.com/users/ariel-phet/gists{/gist_id}","starred_url":"https://api.github.com/users/ariel-phet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariel-phet/subscriptions","organizations_url":"https://api.github.com/users/ariel-phet/orgs","repos_url":"https://api.github.com/users/ariel-phet/repos","events_url":"https://api.github.com/users/ariel-phet/events{/privacy}","received_events_url":"https://api.github.com/users/ariel-phet/received_events","type":"User","site_admin":false},"assignees":[{"login":"ariel-phet","id":4051174,"avatar_url":"https://avatars.githubusercontent.com/u/4051174?v=3","gravatar_id":"","url":"https://api.github.com/users/ariel-phet","html_url":"https://github.com/ariel-phet","followers_url":"https://api.github.com/users/ariel-phet/followers","following_url":"https://api.github.com/users/ariel-phet/following{/other_user}","gists_url":"https://api.github.com/users/ariel-phet/gists{/gist_id}","starred_url":"https://api.github.com/users/ariel-phet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariel-phet/subscriptions","organizations_url":"https://api.github.com/users/ariel-phet/orgs","repos_url":"https://api.github.com/users/ariel-phet/repos","events_url":"https://api.github.com/users/ariel-phet/events{/privacy}","received_events_url":"https://api.github.com/users/ariel-phet/received_events","type":"User","site_admin":false},{"login":"jessegreenberg","id":6396244,"avatar_url":"https://avatars.githubusercontent.com/u/6396244?v=3","gravatar_id":"","url":"https://api.github.com/users/jessegreenberg","html_url":"https://github.com/jessegreenberg","followers_url":"https://api.github.com/users/jessegreenberg/followers","following_url":"https://api.github.com/users/jessegreenberg/following{/other_user}","gists_url":"https://api.github.com/users/jessegreenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jessegreenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessegreenberg/subscriptions","organizations_url":"https://api.github.com/users/jessegreenberg/orgs","repos_url":"https://api.github.com/users/jessegreenberg/repos","events_url":"https://api.github.com/users/jessegreenberg/events{/privacy}","received_events_url":"https://api.github.com/users/jessegreenberg/received_events","type":"User","site_admin":false}],"milestone":null,"comments":25,"created_at":"2016-11-23T19:01:02Z","updated_at":"2016-12-07T20:26:15Z","closed_at":null,"body":"The navbar is going to require some updates to accommodate a \"help button\" for keyboard navigation (a keyboard navigable button that will bring up a dialog that shows the various keyboard options available in a keyboard accessible simulation).\r\n\r\nThe proposed design is:\r\n![navbar_mods](https://cloud.githubusercontent.com/assets/4051174/20574772/779b4a4a-b173-11e6-80a4-d24dcd94054a.png)\r\n \r\nThis design has been made with the possibility of 5 total screens in mind, the proposed changes are:\r\n\r\n1. Change the \"hamburger\" menu button to 3 vertical dots (the PhET logo and 3 dots will all be one button that can open the current menu). This design saves horizontal space and the \"3 dot\" is currently used in chrome, and seen on mobile browsers\r\n2. Include the option for a \"keyboard\" icon that will appear if the sim includes keyboard accessibility.\r\n3. Move the homescreen button to the left of the screen selection buttons. This order seems fairly natural since you begin the sim on the home screen. In addition, when 5 screens are present the homescreen button and keyboard help button would be in close proximity, and this arrangement helps not confuse these buttons\r\n4. The homescreen icon has been reduced in size slightly\r\n5. The maximum width of the title may need to be reduced to accommodate these changes in a sim with many screens (4-5)\r\n\r\nIt will be good to discuss:\r\n\r\n- [ ] How invasive will these changes be?\r\n- [ ] Anything in this design we see as a road block that has not yet been anticipated?\r\n- [ ] If we want to keep look and feel consistent, is a maintenence release possible, or will that be a nightmare (we could live with rolling releases and some inconsistency in the navbar, it will be minor for most sims, mainly the new menu icon and the switch in position of the homescreen icon)"},"comment":{"url":"https://api.github.com/repos/phetsims/joist/issues/comments/265563373","html_url":"https://github.com/phetsims/joist/issues/374#issuecomment-265563373","issue_url":"https://api.github.com/repos/phetsims/joist/issues/374","id":265563373,"user":{"login":"pixelzoom","id":3046552,"avatar_url":"https://avatars.githubusercontent.com/u/3046552?v=3","gravatar_id":"","url":"https://api.github.com/users/pixelzoom","html_url":"https://github.com/pixelzoom","followers_url":"https://api.github.com/users/pixelzoom/followers","following_url":"https://api.github.com/users/pixelzoom/following{/other_user}","gists_url":"https://api.github.com/users/pixelzoom/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelzoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelzoom/subscriptions","organizations_url":"https://api.github.com/users/pixelzoom/orgs","repos_url":"https://api.github.com/users/pixelzoom/repos","events_url":"https://api.github.com/users/pixelzoom/events{/privacy}","received_events_url":"https://api.github.com/users/pixelzoom/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T20:26:15Z","updated_at":"2016-12-07T20:26:15Z","body":"Looks great. I asked because the last time I was modifying the navabar, `stringTest` was critical to verifying robustness of the layout."}}
{"actor":{"display_login":"pixelzoom"}}