{"action":"created","issue":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1129","repository_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware","labels_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1129/labels{/name}","comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1129/comments","events_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1129/events","html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/1129","id":138985084,"number":1129,"title":"Try to make qos~=0 work better","user":{"login":"pjsg","id":1508813,"avatar_url":"https://avatars.githubusercontent.com/u/1508813?v=3","gravatar_id":"","url":"https://api.github.com/users/pjsg","html_url":"https://github.com/pjsg","followers_url":"https://api.github.com/users/pjsg/followers","following_url":"https://api.github.com/users/pjsg/following{/other_user}","gists_url":"https://api.github.com/users/pjsg/gists{/gist_id}","starred_url":"https://api.github.com/users/pjsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjsg/subscriptions","organizations_url":"https://api.github.com/users/pjsg/orgs","repos_url":"https://api.github.com/users/pjsg/repos","events_url":"https://api.github.com/users/pjsg/events{/privacy}","received_events_url":"https://api.github.com/users/pjsg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-03-07T14:03:25Z","updated_at":"2016-03-16T02:34:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1129","html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/1129","diff_url":"https://github.com/nodemcu/nodemcu-firmware/pull/1129.diff","patch_url":"https://github.com/nodemcu/nodemcu-firmware/pull/1129.patch"},"body":"There are two things in the PR\r\n\r\n* Make sure that we send the next message in the queue whenever possible. This *should* fix all the delays. I can send multiple messages per second with non zero QOS now with no obvious delays (and no queue buildup). \r\n\r\n* Make sure that we don't save the lua_State pointer and use it later. This fails in all sorts of horrible ways in the presence of coroutines.\r\n\r\nAs a benefit, this actually reduces the number of lines of code....."},"comment":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/comments/197118849","html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/1129#issuecomment-197118849","issue_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1129","id":197118849,"user":{"login":"pjsg","id":1508813,"avatar_url":"https://avatars.githubusercontent.com/u/1508813?v=3","gravatar_id":"","url":"https://api.github.com/users/pjsg","html_url":"https://github.com/pjsg","followers_url":"https://api.github.com/users/pjsg/followers","following_url":"https://api.github.com/users/pjsg/following{/other_user}","gists_url":"https://api.github.com/users/pjsg/gists{/gist_id}","starred_url":"https://api.github.com/users/pjsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjsg/subscriptions","organizations_url":"https://api.github.com/users/pjsg/orgs","repos_url":"https://api.github.com/users/pjsg/repos","events_url":"https://api.github.com/users/pjsg/events{/privacy}","received_events_url":"https://api.github.com/users/pjsg/received_events","type":"User","site_admin":false},"created_at":"2016-03-16T02:34:25Z","updated_at":"2016-03-16T02:34:25Z","body":"I'll take a look at this in the morning...."}}