{"action":"created","issue":{"url":"https://api.github.com/repos/Wikia/app/issues/9589","repository_url":"https://api.github.com/repos/Wikia/app","labels_url":"https://api.github.com/repos/Wikia/app/issues/9589/labels{/name}","comments_url":"https://api.github.com/repos/Wikia/app/issues/9589/comments","events_url":"https://api.github.com/repos/Wikia/app/issues/9589/events","html_url":"https://github.com/Wikia/app/pull/9589","id":129669173,"number":9589,"title":"INT-322 New Upload Image / Video dialogs. Optimizely A/B test integra…","user":{"login":"perjg","id":651004,"avatar_url":"https://avatars.githubusercontent.com/u/651004?v=3","gravatar_id":"","url":"https://api.github.com/users/perjg","html_url":"https://github.com/perjg","followers_url":"https://api.github.com/users/perjg/followers","following_url":"https://api.github.com/users/perjg/following{/other_user}","gists_url":"https://api.github.com/users/perjg/gists{/gist_id}","starred_url":"https://api.github.com/users/perjg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perjg/subscriptions","organizations_url":"https://api.github.com/users/perjg/orgs","repos_url":"https://api.github.com/users/perjg/repos","events_url":"https://api.github.com/users/perjg/events{/privacy}","received_events_url":"https://api.github.com/users/perjg/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2016-01-29T05:14:07Z","updated_at":"2016-02-08T08:27:58Z","closed_at":"2016-02-08T06:04:26Z","pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/9589","html_url":"https://github.com/Wikia/app/pull/9589","diff_url":"https://github.com/Wikia/app/pull/9589.diff","patch_url":"https://github.com/Wikia/app/pull/9589.patch"},"body":"…tion.\r\n\r\nOverview\r\nAs part of the user testing we did in Japan, we realized that many users found it hard to even find where an image could be added inside the Visual Editor because it is probably one of the most commonly used forms of contribution, yet the button is hidden under a dropdown\r\nGoals\r\nThe goal is to run an A/B test with a version of the VE that shows the image upload functionality right on the tool bar.\r\n"},"comment":{"url":"https://api.github.com/repos/Wikia/app/issues/comments/181252930","html_url":"https://github.com/Wikia/app/pull/9589#issuecomment-181252930","issue_url":"https://api.github.com/repos/Wikia/app/issues/9589","id":181252930,"user":{"login":"inez","id":611259,"avatar_url":"https://avatars.githubusercontent.com/u/611259?v=3","gravatar_id":"","url":"https://api.github.com/users/inez","html_url":"https://github.com/inez","followers_url":"https://api.github.com/users/inez/followers","following_url":"https://api.github.com/users/inez/following{/other_user}","gists_url":"https://api.github.com/users/inez/gists{/gist_id}","starred_url":"https://api.github.com/users/inez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inez/subscriptions","organizations_url":"https://api.github.com/users/inez/orgs","repos_url":"https://api.github.com/users/inez/repos","events_url":"https://api.github.com/users/inez/events{/privacy}","received_events_url":"https://api.github.com/users/inez/received_events","type":"User","site_admin":false},"created_at":"2016-02-08T08:27:58Z","updated_at":"2016-02-08T08:27:58Z","body":"We do not have an official policy regarding squashing, some people actually prefer to see a lot of commits in the history, I personal don't find much value in commits such as \"addressing CR\", \"fixing typo\" and would rather read one, solid commit message :)\r\n(Btw. it's highly recommended to never push force to dev - however that sometimes happen anyways)\r\n\r\nWhen it comes to situation where one feature requires few tasks to be completed and those tasks can not be separately merged to dev what we do it to create a \"feature branch\" based on dev, and then create branches for tickets based on that feature branch. Code is to be code reviewed when it's merged from ticket branch to feature branch, and then there is no need to code review when merging from feature branch (at the end) to dev - however I always ask someone to review anyways."}}