{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/62656077","id":62656077,"diff_hunk":"@@ -337,16 +304,23 @@ func (r *Reflector) ListAndWatch(stopCh <-chan struct{}) error {\n \t\t\t}\n \t\t\treturn nil\n \t\t}\n-\t\tif err := r.watchHandler(w, &resourceVersion, resyncCh, stopCh); err != nil {\n-\t\t\tif err != errorResyncRequested && err != errorStopRequested {\n+\n+\t\tif err := r.watchHandler(w, &resourceVersion, stopCh); err != nil {\n+\t\t\tif err != errorStopRequested {\n \t\t\t\tglog.Warningf(\"%s: watch of %v ended with: %v\", r.name, r.expectedType, err)\n \t\t\t}\n \t\t\treturn nil\n \t\t}\n-\t\tif r.canForceResyncNow() {\n-\t\t\tglog.V(4).Infof(\"%s: next resync planned for %#v, forcing now\", r.name, r.nextResync)\n-\t\t\treturn nil\n-\t\t}\n+\t\t/*","path":"pkg/client/cache/reflector.go","position":96,"original_position":96,"commit_id":"5168833913b27499ec59eec2ad889a35f711d6d8","original_commit_id":"5168833913b27499ec59eec2ad889a35f711d6d8","user":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"body":"It that's really the case then there is a P0 bug - can you please file it. It should never happen no matter when watch is closing.","created_at":"2016-05-10T11:41:13Z","updated_at":"2016-05-10T11:41:13Z","html_url":"https://github.com/kubernetes/kubernetes/pull/24142#discussion_r62656077","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24142","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/62656077"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/24142#discussion_r62656077"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24142"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24142","id":66184125,"html_url":"https://github.com/kubernetes/kubernetes/pull/24142","diff_url":"https://github.com/kubernetes/kubernetes/pull/24142.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/24142.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/24142","number":24142,"state":"open","locked":false,"title":"Separated resync and relist functionality in reflector #23394","user":{"login":"rrati","id":87555,"avatar_url":"https://avatars.githubusercontent.com/u/87555?v=3","gravatar_id":"","url":"https://api.github.com/users/rrati","html_url":"https://github.com/rrati","followers_url":"https://api.github.com/users/rrati/followers","following_url":"https://api.github.com/users/rrati/following{/other_user}","gists_url":"https://api.github.com/users/rrati/gists{/gist_id}","starred_url":"https://api.github.com/users/rrati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrati/subscriptions","organizations_url":"https://api.github.com/users/rrati/orgs","repos_url":"https://api.github.com/users/rrati/repos","events_url":"https://api.github.com/users/rrati/events{/privacy}","received_events_url":"https://api.github.com/users/rrati/received_events","type":"User","site_admin":false},"body":"controller-manager #23394","created_at":"2016-04-12T16:04:58Z","updated_at":"2016-05-10T11:41:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47e8c0e6bd7d029a2d94bc2ae56bedf302fcc467","assignee":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24142/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24142/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/24142/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/5168833913b27499ec59eec2ad889a35f711d6d8","head":{"label":"rrati:controller-sync-interval-23394","ref":"controller-sync-interval-23394","sha":"5168833913b27499ec59eec2ad889a35f711d6d8","user":{"login":"rrati","id":87555,"avatar_url":"https://avatars.githubusercontent.com/u/87555?v=3","gravatar_id":"","url":"https://api.github.com/users/rrati","html_url":"https://github.com/rrati","followers_url":"https://api.github.com/users/rrati/followers","following_url":"https://api.github.com/users/rrati/following{/other_user}","gists_url":"https://api.github.com/users/rrati/gists{/gist_id}","starred_url":"https://api.github.com/users/rrati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrati/subscriptions","organizations_url":"https://api.github.com/users/rrati/orgs","repos_url":"https://api.github.com/users/rrati/repos","events_url":"https://api.github.com/users/rrati/events{/privacy}","received_events_url":"https://api.github.com/users/rrati/received_events","type":"User","site_admin":false},"repo":{"id":29687789,"name":"kubernetes","full_name":"rrati/kubernetes","owner":{"login":"rrati","id":87555,"avatar_url":"https://avatars.githubusercontent.com/u/87555?v=3","gravatar_id":"","url":"https://api.github.com/users/rrati","html_url":"https://github.com/rrati","followers_url":"https://api.github.com/users/rrati/followers","following_url":"https://api.github.com/users/rrati/following{/other_user}","gists_url":"https://api.github.com/users/rrati/gists{/gist_id}","starred_url":"https://api.github.com/users/rrati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrati/subscriptions","organizations_url":"https://api.github.com/users/rrati/orgs","repos_url":"https://api.github.com/users/rrati/repos","events_url":"https://api.github.com/users/rrati/events{/privacy}","received_events_url":"https://api.github.com/users/rrati/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rrati/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/rrati/kubernetes","forks_url":"https://api.github.com/repos/rrati/kubernetes/forks","keys_url":"https://api.github.com/repos/rrati/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rrati/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rrati/kubernetes/teams","hooks_url":"https://api.github.com/repos/rrati/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/rrati/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/rrati/kubernetes/events","assignees_url":"https://api.github.com/repos/rrati/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/rrati/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/rrati/kubernetes/tags","blobs_url":"https://api.github.com/repos/rrati/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rrati/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rrati/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/rrati/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rrati/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/rrati/kubernetes/languages","stargazers_url":"https://api.github.com/repos/rrati/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/rrati/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/rrati/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/rrati/kubernetes/subscription","commits_url":"https://api.github.com/repos/rrati/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/rrati/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/rrati/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/rrati/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/rrati/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/rrati/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rrati/kubernetes/merges","archive_url":"https://api.github.com/repos/rrati/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rrati/kubernetes/downloads","issues_url":"https://api.github.com/repos/rrati/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/rrati/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/rrati/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/rrati/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rrati/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/rrati/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/rrati/kubernetes/deployments","created_at":"2015-01-22T16:22:37Z","updated_at":"2016-03-09T16:53:01Z","pushed_at":"2016-05-09T22:06:59Z","git_url":"git://github.com/rrati/kubernetes.git","ssh_url":"git@github.com:rrati/kubernetes.git","clone_url":"https://github.com/rrati/kubernetes.git","svn_url":"https://github.com/rrati/kubernetes","homepage":"http://kubernetes.io","size":189954,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"ff339c77cfae61d664be3bcbe9a87a968696e545","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-05-10T10:52:17Z","pushed_at":"2016-05-10T11:39:12Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":391765,"stargazers_count":14290,"watchers_count":14290,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4287,"mirror_url":null,"open_issues_count":3567,"forks":4287,"open_issues":3567,"watchers":14290,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24142"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/24142"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/24142"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/24142/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24142/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/24142/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/5168833913b27499ec59eec2ad889a35f711d6d8"}}}}