{"action":"created","issue":{"url":"https://api.github.com/repos/kbower/tickettest1/issues/414","repository_url":"https://api.github.com/repos/kbower/tickettest1","labels_url":"https://api.github.com/repos/kbower/tickettest1/issues/414/labels{/name}","comments_url":"https://api.github.com/repos/kbower/tickettest1/issues/414/comments","events_url":"https://api.github.com/repos/kbower/tickettest1/issues/414/events","html_url":"https://github.com/kbower/tickettest1/issues/414","id":196234235,"number":414,"title":"When a user changes the price of a line after the books were closed, write a voided line for accounting","user":{"login":"kbower","id":4621154,"avatar_url":"https://avatars.githubusercontent.com/u/4621154?v=3","gravatar_id":"","url":"https://api.github.com/users/kbower","html_url":"https://github.com/kbower","followers_url":"https://api.github.com/users/kbower/followers","following_url":"https://api.github.com/users/kbower/following{/other_user}","gists_url":"https://api.github.com/users/kbower/gists{/gist_id}","starred_url":"https://api.github.com/users/kbower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbower/subscriptions","organizations_url":"https://api.github.com/users/kbower/orgs","repos_url":"https://api.github.com/users/kbower/repos","events_url":"https://api.github.com/users/kbower/events{/privacy}","received_events_url":"https://api.github.com/users/kbower/received_events","type":"User","site_admin":false},"labels":[{"id":502436440,"url":"https://api.github.com/repos/kbower/tickettest1/labels/allcustomers","name":"allcustomers","color":"fbca04","default":false},{"id":502425682,"url":"https://api.github.com/repos/kbower/tickettest1/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":502436281,"url":"https://api.github.com/repos/kbower/tickettest1/labels/mor","name":"mor","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":{"login":"kbower","id":4621154,"avatar_url":"https://avatars.githubusercontent.com/u/4621154?v=3","gravatar_id":"","url":"https://api.github.com/users/kbower","html_url":"https://github.com/kbower","followers_url":"https://api.github.com/users/kbower/followers","following_url":"https://api.github.com/users/kbower/following{/other_user}","gists_url":"https://api.github.com/users/kbower/gists{/gist_id}","starred_url":"https://api.github.com/users/kbower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbower/subscriptions","organizations_url":"https://api.github.com/users/kbower/orgs","repos_url":"https://api.github.com/users/kbower/repos","events_url":"https://api.github.com/users/kbower/events{/privacy}","received_events_url":"https://api.github.com/users/kbower/received_events","type":"User","site_admin":false},"assignees":[{"login":"kbower","id":4621154,"avatar_url":"https://avatars.githubusercontent.com/u/4621154?v=3","gravatar_id":"","url":"https://api.github.com/users/kbower","html_url":"https://github.com/kbower","followers_url":"https://api.github.com/users/kbower/followers","following_url":"https://api.github.com/users/kbower/following{/other_user}","gists_url":"https://api.github.com/users/kbower/gists{/gist_id}","starred_url":"https://api.github.com/users/kbower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbower/subscriptions","organizations_url":"https://api.github.com/users/kbower/orgs","repos_url":"https://api.github.com/users/kbower/repos","events_url":"https://api.github.com/users/kbower/events{/privacy}","received_events_url":"https://api.github.com/users/kbower/received_events","type":"User","site_admin":false}],"milestone":null,"comments":13,"created_at":"2016-12-17T17:58:23Z","updated_at":"2016-12-17T17:58:28Z","closed_at":null,"body":"_Imported from trac ticket 414.\nCreated by **kbower**\nOpened in trac: Oct 29, 2010, 5:32:09 PM\nLast modified in trac: Nov 14, 2014, 2:17:23 PM_\n***\nSee information in [#2085](2085)\n----\nOn 10/11/2010 9:10 AM, Kent Bower wrote:\n\nRegarding our conference call:\n\nSuppose you have an order with 1 line:\n\n1  QTY:1 SKUA $50\n\nAnd the price needs to change from $50 to $40.\n\nI want to know if it is acceptable to the sales reports to play a trick with the line numbers, which would save updating any links to line numbers, such as warranty/treatment/discounts, etc.  Can we write a line 2 as the voided line, and change the price on line 1:\n\n1  QTY:1 SKUA $40 Addondate: Today\n2  QTY:1 SKUA $50 Voiddate: Today Voided: Y\n\nI believe this will work well unless the reports are actually referencing individual line numbers.  I also think it would simplify keeping everything in sync greatly.  For example, if there were a warranty or treatment line referring to line 1, it would still be correct, as would any SO_LN2DISC records referring to line 1.\n\nAnother reason I like this approach is that it represents what is actually happening: that is, we are, in fact, not voiding line 1 at all, all we are really doing is changing the price on line 1 and, in effect, writing an audit record for the price change (in this case, the \"audit record\" is a voided SO_LN).\n\nLet me know if you think this would work,\nKent\n\nMore advantages:\nIf the line is already filled (or even already downloaded to the WMS and possibly being picked), this approach doesn't effect either of these cases.\n"},"comment":{"url":"https://api.github.com/repos/kbower/tickettest1/issues/comments/267776940","html_url":"https://github.com/kbower/tickettest1/issues/414#issuecomment-267776940","issue_url":"https://api.github.com/repos/kbower/tickettest1/issues/414","id":267776940,"user":{"login":"kbower","id":4621154,"avatar_url":"https://avatars.githubusercontent.com/u/4621154?v=3","gravatar_id":"","url":"https://api.github.com/users/kbower","html_url":"https://github.com/kbower","followers_url":"https://api.github.com/users/kbower/followers","following_url":"https://api.github.com/users/kbower/following{/other_user}","gists_url":"https://api.github.com/users/kbower/gists{/gist_id}","starred_url":"https://api.github.com/users/kbower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbower/subscriptions","organizations_url":"https://api.github.com/users/kbower/orgs","repos_url":"https://api.github.com/users/kbower/repos","events_url":"https://api.github.com/users/kbower/events{/privacy}","received_events_url":"https://api.github.com/users/kbower/received_events","type":"User","site_admin":false},"created_at":"2016-12-17T17:58:28Z","updated_at":"2016-12-17T17:58:28Z","body":"_**sjohnson** trac comment on Sep 22, 2014, 10:46:38 AM:_\n\nIt sounds like we need to revisit this in light of new initiatives at Morris.\n----\nI know we have dealt with this issue in the past and we decided that we would allow changes to order lines after the day is closed.  If my memory serves me correctly, one of the big problems was that discounts recalculate every time an order is saved and if the discount needed to update a line after the day is closed, the order wouldn’t save.\nAs I mentioned in my email earlier today, we are going to be intensely focusing on written business with our new VP of Sales. The problem now becomes the following: if we continue to ignore the fact that the day is closed, line items can be changed in a way that changes written business for a prior period.  We have to get to the point where written business for a day is constant and does not change. \nCurrently, if the price on an order line written yesterday is changed today, the written business for yesterday changes and there is no impact on written business for today. So if a retail price on an existing line was reduced from 500 to 450, the net change of the price change will not show under today’s business, the written business for yesterday’s business is reduced by 50.  I can’t see how this will be acceptable going forward as when we give sales a report of written business for today, it should always be the written business for today.\nDo you have any ideas on how we can make this work? I don’t know if anything substantial has changed with how the discounts are calculating or if maybe someone else is dealing with this another way and you would be willing to share how it works. \nCan you remember any additional reasons why we decided to go this route?\nDarlene\n----\nDarlene,\nAttached is the ticket that I believe captures this issue.\nThanks,\nScott\n----\nThis sounds about right. How will the recalculation of discounts work? Any idea when this might be addressed? This is going to quickly become an issue as we try to get written business reports under control and stable here.\nDarlene\n \n"}}
{"actor":{"display_login":"kbower"}}