{"action":"opened","number":117,"pull_request":{"url":"https://api.github.com/repos/felipernb/algorithms.js/pulls/117","id":82362565,"html_url":"https://github.com/felipernb/algorithms.js/pull/117","diff_url":"https://github.com/felipernb/algorithms.js/pull/117.diff","patch_url":"https://github.com/felipernb/algorithms.js/pull/117.patch","issue_url":"https://api.github.com/repos/felipernb/algorithms.js/issues/117","number":117,"state":"open","locked":false,"title":"Implementing classes using the new ES6 syntax","user":{"login":"leonardo-silva","id":7905740,"avatar_url":"https://avatars.githubusercontent.com/u/7905740?v=3","gravatar_id":"","url":"https://api.github.com/users/leonardo-silva","html_url":"https://github.com/leonardo-silva","followers_url":"https://api.github.com/users/leonardo-silva/followers","following_url":"https://api.github.com/users/leonardo-silva/following{/other_user}","gists_url":"https://api.github.com/users/leonardo-silva/gists{/gist_id}","starred_url":"https://api.github.com/users/leonardo-silva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonardo-silva/subscriptions","organizations_url":"https://api.github.com/users/leonardo-silva/orgs","repos_url":"https://api.github.com/users/leonardo-silva/repos","events_url":"https://api.github.com/users/leonardo-silva/events{/privacy}","received_events_url":"https://api.github.com/users/leonardo-silva/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nIn my PhD research, I am using algorithms.js in some experiments.\r\n\r\nAs a result, I detected the existence of at least 19 \"classes\" in the current codebase, mostly to implement data structures (MinHeap, MaxHeap, Stack, Queue, ...).\r\n\r\nSo, I decided to rewrote this code to follow the new syntax for classes provided by ECMAScript 2016, which I think is much more readable. All changes are just syntactical. I was also very careful to preserve the code style.\r\nFinally, all tests are green in the migrated code.\r\n\r\nDo you think it is worth to integrate these changes to the project?\r\n\r\nThank you\r\n","created_at":"2016-08-23T13:17:08Z","updated_at":"2016-08-23T13:17:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abde17b6f72c799cdfa518a351ea22b368fc368e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/felipernb/algorithms.js/pulls/117/commits","review_comments_url":"https://api.github.com/repos/felipernb/algorithms.js/pulls/117/comments","review_comment_url":"https://api.github.com/repos/felipernb/algorithms.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/felipernb/algorithms.js/issues/117/comments","statuses_url":"https://api.github.com/repos/felipernb/algorithms.js/statuses/23dd87cb8a3596cb002b1942bc8fa7eae582db10","head":{"label":"leonardo-silva:master","ref":"master","sha":"23dd87cb8a3596cb002b1942bc8fa7eae582db10","user":{"login":"leonardo-silva","id":7905740,"avatar_url":"https://avatars.githubusercontent.com/u/7905740?v=3","gravatar_id":"","url":"https://api.github.com/users/leonardo-silva","html_url":"https://github.com/leonardo-silva","followers_url":"https://api.github.com/users/leonardo-silva/followers","following_url":"https://api.github.com/users/leonardo-silva/following{/other_user}","gists_url":"https://api.github.com/users/leonardo-silva/gists{/gist_id}","starred_url":"https://api.github.com/users/leonardo-silva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonardo-silva/subscriptions","organizations_url":"https://api.github.com/users/leonardo-silva/orgs","repos_url":"https://api.github.com/users/leonardo-silva/repos","events_url":"https://api.github.com/users/leonardo-silva/events{/privacy}","received_events_url":"https://api.github.com/users/leonardo-silva/received_events","type":"User","site_admin":false},"repo":{"id":66204863,"name":"algorithms.js","full_name":"leonardo-silva/algorithms.js","owner":{"login":"leonardo-silva","id":7905740,"avatar_url":"https://avatars.githubusercontent.com/u/7905740?v=3","gravatar_id":"","url":"https://api.github.com/users/leonardo-silva","html_url":"https://github.com/leonardo-silva","followers_url":"https://api.github.com/users/leonardo-silva/followers","following_url":"https://api.github.com/users/leonardo-silva/following{/other_user}","gists_url":"https://api.github.com/users/leonardo-silva/gists{/gist_id}","starred_url":"https://api.github.com/users/leonardo-silva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonardo-silva/subscriptions","organizations_url":"https://api.github.com/users/leonardo-silva/orgs","repos_url":"https://api.github.com/users/leonardo-silva/repos","events_url":"https://api.github.com/users/leonardo-silva/events{/privacy}","received_events_url":"https://api.github.com/users/leonardo-silva/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leonardo-silva/algorithms.js","description":"Atwood's Law applied to CS101 - Classic algorithms and data structures implemented in JavaScript","fork":true,"url":"https://api.github.com/repos/leonardo-silva/algorithms.js","forks_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/forks","keys_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/teams","hooks_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/hooks","issue_events_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/issues/events{/number}","events_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/events","assignees_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/assignees{/user}","branches_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/branches{/branch}","tags_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/tags","blobs_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/statuses/{sha}","languages_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/languages","stargazers_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/stargazers","contributors_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/contributors","subscribers_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/subscribers","subscription_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/subscription","commits_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/contents/{+path}","compare_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/merges","archive_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/downloads","issues_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/issues{/number}","pulls_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/pulls{/number}","milestones_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/milestones{/number}","notifications_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/labels{/name}","releases_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/releases{/id}","deployments_url":"https://api.github.com/repos/leonardo-silva/algorithms.js/deployments","created_at":"2016-08-21T15:08:00Z","updated_at":"2016-08-21T15:08:01Z","pushed_at":"2016-08-23T12:10:42Z","git_url":"git://github.com/leonardo-silva/algorithms.js.git","ssh_url":"git@github.com:leonardo-silva/algorithms.js.git","clone_url":"https://github.com/leonardo-silva/algorithms.js.git","svn_url":"https://github.com/leonardo-silva/algorithms.js","homepage":"http://felipernb.github.io/algorithms.js","size":666,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"felipernb:master","ref":"master","sha":"dec8937fa3695c5b40e37616dcf6ecad19e645af","user":{"login":"felipernb","id":227059,"avatar_url":"https://avatars.githubusercontent.com/u/227059?v=3","gravatar_id":"","url":"https://api.github.com/users/felipernb","html_url":"https://github.com/felipernb","followers_url":"https://api.github.com/users/felipernb/followers","following_url":"https://api.github.com/users/felipernb/following{/other_user}","gists_url":"https://api.github.com/users/felipernb/gists{/gist_id}","starred_url":"https://api.github.com/users/felipernb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felipernb/subscriptions","organizations_url":"https://api.github.com/users/felipernb/orgs","repos_url":"https://api.github.com/users/felipernb/repos","events_url":"https://api.github.com/users/felipernb/events{/privacy}","received_events_url":"https://api.github.com/users/felipernb/received_events","type":"User","site_admin":false},"repo":{"id":16679350,"name":"algorithms.js","full_name":"felipernb/algorithms.js","owner":{"login":"felipernb","id":227059,"avatar_url":"https://avatars.githubusercontent.com/u/227059?v=3","gravatar_id":"","url":"https://api.github.com/users/felipernb","html_url":"https://github.com/felipernb","followers_url":"https://api.github.com/users/felipernb/followers","following_url":"https://api.github.com/users/felipernb/following{/other_user}","gists_url":"https://api.github.com/users/felipernb/gists{/gist_id}","starred_url":"https://api.github.com/users/felipernb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felipernb/subscriptions","organizations_url":"https://api.github.com/users/felipernb/orgs","repos_url":"https://api.github.com/users/felipernb/repos","events_url":"https://api.github.com/users/felipernb/events{/privacy}","received_events_url":"https://api.github.com/users/felipernb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/felipernb/algorithms.js","description":"Atwood's Law applied to CS101 - Classic algorithms and data structures implemented in JavaScript","fork":false,"url":"https://api.github.com/repos/felipernb/algorithms.js","forks_url":"https://api.github.com/repos/felipernb/algorithms.js/forks","keys_url":"https://api.github.com/repos/felipernb/algorithms.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/felipernb/algorithms.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/felipernb/algorithms.js/teams","hooks_url":"https://api.github.com/repos/felipernb/algorithms.js/hooks","issue_events_url":"https://api.github.com/repos/felipernb/algorithms.js/issues/events{/number}","events_url":"https://api.github.com/repos/felipernb/algorithms.js/events","assignees_url":"https://api.github.com/repos/felipernb/algorithms.js/assignees{/user}","branches_url":"https://api.github.com/repos/felipernb/algorithms.js/branches{/branch}","tags_url":"https://api.github.com/repos/felipernb/algorithms.js/tags","blobs_url":"https://api.github.com/repos/felipernb/algorithms.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/felipernb/algorithms.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/felipernb/algorithms.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/felipernb/algorithms.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/felipernb/algorithms.js/statuses/{sha}","languages_url":"https://api.github.com/repos/felipernb/algorithms.js/languages","stargazers_url":"https://api.github.com/repos/felipernb/algorithms.js/stargazers","contributors_url":"https://api.github.com/repos/felipernb/algorithms.js/contributors","subscribers_url":"https://api.github.com/repos/felipernb/algorithms.js/subscribers","subscription_url":"https://api.github.com/repos/felipernb/algorithms.js/subscription","commits_url":"https://api.github.com/repos/felipernb/algorithms.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/felipernb/algorithms.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/felipernb/algorithms.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/felipernb/algorithms.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/felipernb/algorithms.js/contents/{+path}","compare_url":"https://api.github.com/repos/felipernb/algorithms.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/felipernb/algorithms.js/merges","archive_url":"https://api.github.com/repos/felipernb/algorithms.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/felipernb/algorithms.js/downloads","issues_url":"https://api.github.com/repos/felipernb/algorithms.js/issues{/number}","pulls_url":"https://api.github.com/repos/felipernb/algorithms.js/pulls{/number}","milestones_url":"https://api.github.com/repos/felipernb/algorithms.js/milestones{/number}","notifications_url":"https://api.github.com/repos/felipernb/algorithms.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/felipernb/algorithms.js/labels{/name}","releases_url":"https://api.github.com/repos/felipernb/algorithms.js/releases{/id}","deployments_url":"https://api.github.com/repos/felipernb/algorithms.js/deployments","created_at":"2014-02-10T00:04:28Z","updated_at":"2016-08-23T10:18:30Z","pushed_at":"2016-08-23T13:17:08Z","git_url":"git://github.com/felipernb/algorithms.js.git","ssh_url":"git@github.com:felipernb/algorithms.js.git","clone_url":"https://github.com/felipernb/algorithms.js.git","svn_url":"https://github.com/felipernb/algorithms.js","homepage":"http://felipernb.github.io/algorithms.js","size":701,"stargazers_count":2206,"watchers_count":2206,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":199,"mirror_url":null,"open_issues_count":5,"forks":199,"open_issues":5,"watchers":2206,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/felipernb/algorithms.js/pulls/117"},"html":{"href":"https://github.com/felipernb/algorithms.js/pull/117"},"issue":{"href":"https://api.github.com/repos/felipernb/algorithms.js/issues/117"},"comments":{"href":"https://api.github.com/repos/felipernb/algorithms.js/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/felipernb/algorithms.js/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/felipernb/algorithms.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/felipernb/algorithms.js/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/felipernb/algorithms.js/statuses/23dd87cb8a3596cb002b1942bc8fa7eae582db10"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":1470,"deletions":1412,"changed_files":15}}
{"actor":{"display_login":"leonardo-silva"}}