{"action":"closed","number":35,"pull_request":{"url":"https://api.github.com/repos/apache/parquet-format/pulls/35","id":53650329,"html_url":"https://github.com/apache/parquet-format/pull/35","diff_url":"https://github.com/apache/parquet-format/pull/35.diff","patch_url":"https://github.com/apache/parquet-format/pull/35.patch","issue_url":"https://api.github.com/repos/apache/parquet-format/issues/35","number":35,"state":"closed","locked":false,"title":"PARQUET-407: Incorrect delta-encoding example","user":{"login":"socialpercon","id":3107724,"avatar_url":"https://avatars.githubusercontent.com/u/3107724?v=3","gravatar_id":"","url":"https://api.github.com/users/socialpercon","html_url":"https://github.com/socialpercon","followers_url":"https://api.github.com/users/socialpercon/followers","following_url":"https://api.github.com/users/socialpercon/following{/other_user}","gists_url":"https://api.github.com/users/socialpercon/gists{/gist_id}","starred_url":"https://api.github.com/users/socialpercon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socialpercon/subscriptions","organizations_url":"https://api.github.com/users/socialpercon/orgs","repos_url":"https://api.github.com/users/socialpercon/repos","events_url":"https://api.github.com/users/socialpercon/events{/privacy}","received_events_url":"https://api.github.com/users/socialpercon/received_events","type":"User","site_admin":false},"body":"https://issues.apache.org/jira/browse/PARQUET-407\r\n\r\nThe minimum and the number of bits are incorrect at delta encoding Example 2 In `Encodings.md`.\r\nIn the example, \r\n\r\n```\r\nExample 2\r\n\r\n7, 5, 3, 1, 2, 3, 4, 5, the deltas would be\r\n\r\n-2, -2, -2, 1, 1, 1, 1\r\nThe minimum is -2, so the relative deltas are:\r\n\r\n0, 0, 0, 3, 3, 3, 3\r\n\r\nThe encoded data is\r\n\r\nheader: 8 (block size), 1 (miniblock count), 8 (value count), 7 (first value)\r\n\r\nblock 0 (minimum delta), 2 (bitwidth), 000000111111b (0,0,0,3,3,3 packed on 2 bits)\r\n```\r\n\r\nThe minimum is -2 and the relative deltas are 0, 0, 0, 3, 3, 3, 3. So, this should be corrected as below:\r\n\r\n```\r\nblock -2 (minimum delta), 2 (bitwidth), 00000011111111b (0,0,0,3,3,3,3 packed on 2 bits)\r\n```","created_at":"2015-12-15T01:57:46Z","updated_at":"2016-01-06T23:49:12Z","closed_at":"2016-01-06T23:49:12Z","merged_at":null,"merge_commit_sha":"a63d194fa958c77cb7fbaa15e83811829fe12c53","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/parquet-format/pulls/35/commits","review_comments_url":"https://api.github.com/repos/apache/parquet-format/pulls/35/comments","review_comment_url":"https://api.github.com/repos/apache/parquet-format/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/parquet-format/issues/35/comments","statuses_url":"https://api.github.com/repos/apache/parquet-format/statuses/3d5886acfd72e12a76a169497589f68db950731a","head":{"label":"socialpercon:master","ref":"master","sha":"3d5886acfd72e12a76a169497589f68db950731a","user":{"login":"socialpercon","id":3107724,"avatar_url":"https://avatars.githubusercontent.com/u/3107724?v=3","gravatar_id":"","url":"https://api.github.com/users/socialpercon","html_url":"https://github.com/socialpercon","followers_url":"https://api.github.com/users/socialpercon/followers","following_url":"https://api.github.com/users/socialpercon/following{/other_user}","gists_url":"https://api.github.com/users/socialpercon/gists{/gist_id}","starred_url":"https://api.github.com/users/socialpercon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socialpercon/subscriptions","organizations_url":"https://api.github.com/users/socialpercon/orgs","repos_url":"https://api.github.com/users/socialpercon/repos","events_url":"https://api.github.com/users/socialpercon/events{/privacy}","received_events_url":"https://api.github.com/users/socialpercon/received_events","type":"User","site_admin":false},"repo":{"id":48013022,"name":"parquet-format-1","full_name":"socialpercon/parquet-format-1","owner":{"login":"socialpercon","id":3107724,"avatar_url":"https://avatars.githubusercontent.com/u/3107724?v=3","gravatar_id":"","url":"https://api.github.com/users/socialpercon","html_url":"https://github.com/socialpercon","followers_url":"https://api.github.com/users/socialpercon/followers","following_url":"https://api.github.com/users/socialpercon/following{/other_user}","gists_url":"https://api.github.com/users/socialpercon/gists{/gist_id}","starred_url":"https://api.github.com/users/socialpercon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socialpercon/subscriptions","organizations_url":"https://api.github.com/users/socialpercon/orgs","repos_url":"https://api.github.com/users/socialpercon/repos","events_url":"https://api.github.com/users/socialpercon/events{/privacy}","received_events_url":"https://api.github.com/users/socialpercon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/socialpercon/parquet-format-1","description":"Mirror of Apache Parquet","fork":true,"url":"https://api.github.com/repos/socialpercon/parquet-format-1","forks_url":"https://api.github.com/repos/socialpercon/parquet-format-1/forks","keys_url":"https://api.github.com/repos/socialpercon/parquet-format-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socialpercon/parquet-format-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socialpercon/parquet-format-1/teams","hooks_url":"https://api.github.com/repos/socialpercon/parquet-format-1/hooks","issue_events_url":"https://api.github.com/repos/socialpercon/parquet-format-1/issues/events{/number}","events_url":"https://api.github.com/repos/socialpercon/parquet-format-1/events","assignees_url":"https://api.github.com/repos/socialpercon/parquet-format-1/assignees{/user}","branches_url":"https://api.github.com/repos/socialpercon/parquet-format-1/branches{/branch}","tags_url":"https://api.github.com/repos/socialpercon/parquet-format-1/tags","blobs_url":"https://api.github.com/repos/socialpercon/parquet-format-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socialpercon/parquet-format-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socialpercon/parquet-format-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/socialpercon/parquet-format-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socialpercon/parquet-format-1/statuses/{sha}","languages_url":"https://api.github.com/repos/socialpercon/parquet-format-1/languages","stargazers_url":"https://api.github.com/repos/socialpercon/parquet-format-1/stargazers","contributors_url":"https://api.github.com/repos/socialpercon/parquet-format-1/contributors","subscribers_url":"https://api.github.com/repos/socialpercon/parquet-format-1/subscribers","subscription_url":"https://api.github.com/repos/socialpercon/parquet-format-1/subscription","commits_url":"https://api.github.com/repos/socialpercon/parquet-format-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/socialpercon/parquet-format-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/socialpercon/parquet-format-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/socialpercon/parquet-format-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/socialpercon/parquet-format-1/contents/{+path}","compare_url":"https://api.github.com/repos/socialpercon/parquet-format-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socialpercon/parquet-format-1/merges","archive_url":"https://api.github.com/repos/socialpercon/parquet-format-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socialpercon/parquet-format-1/downloads","issues_url":"https://api.github.com/repos/socialpercon/parquet-format-1/issues{/number}","pulls_url":"https://api.github.com/repos/socialpercon/parquet-format-1/pulls{/number}","milestones_url":"https://api.github.com/repos/socialpercon/parquet-format-1/milestones{/number}","notifications_url":"https://api.github.com/repos/socialpercon/parquet-format-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socialpercon/parquet-format-1/labels{/name}","releases_url":"https://api.github.com/repos/socialpercon/parquet-format-1/releases{/id}","created_at":"2015-12-15T01:53:37Z","updated_at":"2015-12-15T01:53:38Z","pushed_at":"2015-12-15T01:55:34Z","git_url":"git://github.com/socialpercon/parquet-format-1.git","ssh_url":"git@github.com:socialpercon/parquet-format-1.git","clone_url":"https://github.com/socialpercon/parquet-format-1.git","svn_url":"https://github.com/socialpercon/parquet-format-1","homepage":null,"size":391,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"6a17cf9c3138be672cabd003df227b2f794ca938","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20675635,"name":"parquet-format","full_name":"apache/parquet-format","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/parquet-format","description":"Mirror of Apache Parquet","fork":false,"url":"https://api.github.com/repos/apache/parquet-format","forks_url":"https://api.github.com/repos/apache/parquet-format/forks","keys_url":"https://api.github.com/repos/apache/parquet-format/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/parquet-format/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/parquet-format/teams","hooks_url":"https://api.github.com/repos/apache/parquet-format/hooks","issue_events_url":"https://api.github.com/repos/apache/parquet-format/issues/events{/number}","events_url":"https://api.github.com/repos/apache/parquet-format/events","assignees_url":"https://api.github.com/repos/apache/parquet-format/assignees{/user}","branches_url":"https://api.github.com/repos/apache/parquet-format/branches{/branch}","tags_url":"https://api.github.com/repos/apache/parquet-format/tags","blobs_url":"https://api.github.com/repos/apache/parquet-format/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/parquet-format/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/parquet-format/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/parquet-format/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/parquet-format/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/parquet-format/languages","stargazers_url":"https://api.github.com/repos/apache/parquet-format/stargazers","contributors_url":"https://api.github.com/repos/apache/parquet-format/contributors","subscribers_url":"https://api.github.com/repos/apache/parquet-format/subscribers","subscription_url":"https://api.github.com/repos/apache/parquet-format/subscription","commits_url":"https://api.github.com/repos/apache/parquet-format/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/parquet-format/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/parquet-format/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/parquet-format/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/parquet-format/contents/{+path}","compare_url":"https://api.github.com/repos/apache/parquet-format/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/parquet-format/merges","archive_url":"https://api.github.com/repos/apache/parquet-format/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/parquet-format/downloads","issues_url":"https://api.github.com/repos/apache/parquet-format/issues{/number}","pulls_url":"https://api.github.com/repos/apache/parquet-format/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/parquet-format/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/parquet-format/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/parquet-format/labels{/name}","releases_url":"https://api.github.com/repos/apache/parquet-format/releases{/id}","created_at":"2014-06-10T07:00:07Z","updated_at":"2016-01-06T21:33:36Z","pushed_at":"2016-01-06T23:49:11Z","git_url":"git://github.com/apache/parquet-format.git","ssh_url":"git@github.com:apache/parquet-format.git","clone_url":"https://github.com/apache/parquet-format.git","svn_url":"https://github.com/apache/parquet-format","homepage":null,"size":453,"stargazers_count":87,"watchers_count":87,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":"git://git.apache.org/parquet-format.git","open_issues_count":7,"forks":46,"open_issues":7,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-format/pulls/35"},"html":{"href":"https://github.com/apache/parquet-format/pull/35"},"issue":{"href":"https://api.github.com/repos/apache/parquet-format/issues/35"},"comments":{"href":"https://api.github.com/repos/apache/parquet-format/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/parquet-format/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/parquet-format/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/parquet-format/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/apache/parquet-format/statuses/3d5886acfd72e12a76a169497589f68db950731a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}