{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/comments/87096728","pull_request_review_id":7722904,"id":87096728,"diff_hunk":"@@ -0,0 +1,275 @@\n+#!/usr/bin/python\n+# -*- coding: utf-8 -*-\n+#\n+# Copyright (c) 2016 Red Hat, Inc.\n+#\n+# This file is part of Ansible\n+#\n+# Ansible is free software: you can redistribute it and/or modify\n+# it under the terms of the GNU General Public License as published by\n+# the Free Software Foundation, either version 3 of the License, or\n+# (at your option) any later version.\n+#\n+# Ansible is distributed in the hope that it will be useful,\n+# but WITHOUT ANY WARRANTY; without even the implied warranty of\n+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+# GNU General Public License for more details.\n+#\n+# You should have received a copy of the GNU General Public License\n+# along with Ansible.  If not, see <http://www.gnu.org/licenses/>.\n+#\n+\n+try:\n+    import ovirtsdk4 as sdk\n+    import ovirtsdk4.types as otypes","path":"cloud/ovirt/ovirt_permissions.py","position":24,"original_position":24,"commit_id":"61a13925730d2a28ff999489952a3feb11a08905","original_commit_id":"61a13925730d2a28ff999489952a3feb11a08905","user":{"login":"ryansb","id":636610,"avatar_url":"https://avatars.githubusercontent.com/u/636610?v=3","gravatar_id":"","url":"https://api.github.com/users/ryansb","html_url":"https://github.com/ryansb","followers_url":"https://api.github.com/users/ryansb/followers","following_url":"https://api.github.com/users/ryansb/following{/other_user}","gists_url":"https://api.github.com/users/ryansb/gists{/gist_id}","starred_url":"https://api.github.com/users/ryansb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryansb/subscriptions","organizations_url":"https://api.github.com/users/ryansb/orgs","repos_url":"https://api.github.com/users/ryansb/repos","events_url":"https://api.github.com/users/ryansb/events{/privacy}","received_events_url":"https://api.github.com/users/ryansb/received_events","type":"User","site_admin":false},"body":"Same comment - please look at how the AWS modules handle these imports to surface errors to users.","created_at":"2016-11-08T22:17:25Z","updated_at":"2016-11-08T22:17:25Z","html_url":"https://github.com/ansible/ansible-modules-extras/pull/3160#discussion_r87096728","pull_request_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/3160","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/comments/87096728"},"html":{"href":"https://github.com/ansible/ansible-modules-extras/pull/3160#discussion_r87096728"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/3160"}}},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/3160","id":89220284,"html_url":"https://github.com/ansible/ansible-modules-extras/pull/3160","diff_url":"https://github.com/ansible/ansible-modules-extras/pull/3160.diff","patch_url":"https://github.com/ansible/ansible-modules-extras/pull/3160.patch","issue_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/3160","number":3160,"state":"open","locked":false,"title":"Add oVirt ovirt_permissions and ovirt_permissions_facts modules","user":{"login":"machacekondra","id":3384302,"avatar_url":"https://avatars.githubusercontent.com/u/3384302?v=3","gravatar_id":"","url":"https://api.github.com/users/machacekondra","html_url":"https://github.com/machacekondra","followers_url":"https://api.github.com/users/machacekondra/followers","following_url":"https://api.github.com/users/machacekondra/following{/other_user}","gists_url":"https://api.github.com/users/machacekondra/gists{/gist_id}","starred_url":"https://api.github.com/users/machacekondra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/machacekondra/subscriptions","organizations_url":"https://api.github.com/users/machacekondra/orgs","repos_url":"https://api.github.com/users/machacekondra/repos","events_url":"https://api.github.com/users/machacekondra/events{/privacy}","received_events_url":"https://api.github.com/users/machacekondra/received_events","type":"User","site_admin":false},"body":"##### ISSUE TYPE\n\n<!--- Pick one below and delete the rest: -->\n- New Module Pull Request\n##### COMPONENT NAME\n\n<!--- Name of the plugin/module/task -->\n- ovirt_permissions\n- ovirt_permissions_facts\n##### SUMMARY\n\n<!--- Describe the change, including rationale and design decisions -->\n\nThis PR adds two new modules for managing permissions in oVIrt.\n","created_at":"2016-10-13T15:01:25Z","updated_at":"2016-11-08T22:17:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60ad713183c319920cb03625b900555efb0e1e40","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/3160/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/3160/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/3160/comments","statuses_url":"https://api.github.com/repos/ansible/ansible-modules-extras/statuses/61a13925730d2a28ff999489952a3feb11a08905","head":{"label":"machacekondra:ovirt_permissions","ref":"ovirt_permissions","sha":"61a13925730d2a28ff999489952a3feb11a08905","user":{"login":"machacekondra","id":3384302,"avatar_url":"https://avatars.githubusercontent.com/u/3384302?v=3","gravatar_id":"","url":"https://api.github.com/users/machacekondra","html_url":"https://github.com/machacekondra","followers_url":"https://api.github.com/users/machacekondra/followers","following_url":"https://api.github.com/users/machacekondra/following{/other_user}","gists_url":"https://api.github.com/users/machacekondra/gists{/gist_id}","starred_url":"https://api.github.com/users/machacekondra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/machacekondra/subscriptions","organizations_url":"https://api.github.com/users/machacekondra/orgs","repos_url":"https://api.github.com/users/machacekondra/repos","events_url":"https://api.github.com/users/machacekondra/events{/privacy}","received_events_url":"https://api.github.com/users/machacekondra/received_events","type":"User","site_admin":false},"repo":{"id":43626718,"name":"ansible-modules-extras","full_name":"machacekondra/ansible-modules-extras","owner":{"login":"machacekondra","id":3384302,"avatar_url":"https://avatars.githubusercontent.com/u/3384302?v=3","gravatar_id":"","url":"https://api.github.com/users/machacekondra","html_url":"https://github.com/machacekondra","followers_url":"https://api.github.com/users/machacekondra/followers","following_url":"https://api.github.com/users/machacekondra/following{/other_user}","gists_url":"https://api.github.com/users/machacekondra/gists{/gist_id}","starred_url":"https://api.github.com/users/machacekondra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/machacekondra/subscriptions","organizations_url":"https://api.github.com/users/machacekondra/orgs","repos_url":"https://api.github.com/users/machacekondra/repos","events_url":"https://api.github.com/users/machacekondra/events{/privacy}","received_events_url":"https://api.github.com/users/machacekondra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/machacekondra/ansible-modules-extras","description":"Ansible extra modules - these modules ship with ansible","fork":true,"url":"https://api.github.com/repos/machacekondra/ansible-modules-extras","forks_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/forks","keys_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/teams","hooks_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/hooks","issue_events_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/issues/events{/number}","events_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/events","assignees_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/assignees{/user}","branches_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/branches{/branch}","tags_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/tags","blobs_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/languages","stargazers_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/stargazers","contributors_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/contributors","subscribers_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/subscribers","subscription_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/subscription","commits_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/contents/{+path}","compare_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/merges","archive_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/downloads","issues_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/issues{/number}","pulls_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/labels{/name}","releases_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/releases{/id}","deployments_url":"https://api.github.com/repos/machacekondra/ansible-modules-extras/deployments","created_at":"2015-10-04T05:55:50Z","updated_at":"2016-07-28T07:55:12Z","pushed_at":"2016-11-08T18:47:03Z","git_url":"git://github.com/machacekondra/ansible-modules-extras.git","ssh_url":"git@github.com:machacekondra/ansible-modules-extras.git","clone_url":"https://github.com/machacekondra/ansible-modules-extras.git","svn_url":"https://github.com/machacekondra/ansible-modules-extras","homepage":"","size":8639,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"d439271f685c01ace04025f27e7046dd35d988f8","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":24474138,"name":"ansible-modules-extras","full_name":"ansible/ansible-modules-extras","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible-modules-extras","description":"Ansible extra modules - these modules ship with ansible","fork":false,"url":"https://api.github.com/repos/ansible/ansible-modules-extras","forks_url":"https://api.github.com/repos/ansible/ansible-modules-extras/forks","keys_url":"https://api.github.com/repos/ansible/ansible-modules-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible-modules-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible-modules-extras/teams","hooks_url":"https://api.github.com/repos/ansible/ansible-modules-extras/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible-modules-extras/events","assignees_url":"https://api.github.com/repos/ansible/ansible-modules-extras/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible-modules-extras/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible-modules-extras/tags","blobs_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible-modules-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible-modules-extras/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible-modules-extras/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible-modules-extras/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible-modules-extras/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible-modules-extras/subscription","commits_url":"https://api.github.com/repos/ansible/ansible-modules-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible-modules-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible-modules-extras/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible-modules-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible-modules-extras/merges","archive_url":"https://api.github.com/repos/ansible/ansible-modules-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible-modules-extras/downloads","issues_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible-modules-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible-modules-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible-modules-extras/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/deployments","created_at":"2014-09-25T20:28:42Z","updated_at":"2016-11-08T14:46:33Z","pushed_at":"2016-11-08T22:07:55Z","git_url":"git://github.com/ansible/ansible-modules-extras.git","ssh_url":"git@github.com:ansible/ansible-modules-extras.git","clone_url":"https://github.com/ansible/ansible-modules-extras.git","svn_url":"https://github.com/ansible/ansible-modules-extras","homepage":"","size":54589,"stargazers_count":766,"watchers_count":766,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1606,"mirror_url":null,"open_issues_count":699,"forks":1606,"open_issues":699,"watchers":766,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/3160"},"html":{"href":"https://github.com/ansible/ansible-modules-extras/pull/3160"},"issue":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/3160"},"comments":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/3160/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/3160/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/3160/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible-modules-extras/statuses/61a13925730d2a28ff999489952a3feb11a08905"}}}}
{"actor":{"display_login":"ryansb"}}