{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/61640843","id":61640843,"diff_hunk":"@@ -74,6 +74,9 @@ private slots:\n     void handleAssetGetReply(QSharedPointer<ReceivedMessage> message, SharedNodePointer senderNode);\n     void handleAssetUploadReply(QSharedPointer<ReceivedMessage> message, SharedNodePointer senderNode);\n \n+    void handleProgressCallback(const QWeakPointer<Node>& node, MessageID messageID, DataOffset length);\n+    void handleCompleteCallback(const QWeakPointer<Node>& node, MessageID messageID);","path":"libraries/networking/src/AssetClient.h","position":5,"original_position":5,"commit_id":"9a7bebaaa2a12ba5dff7305c1e3ee88c973ad729","original_commit_id":"9a7bebaaa2a12ba5dff7305c1e3ee88c973ad729","user":{"login":"huffman","id":167747,"avatar_url":"https://avatars.githubusercontent.com/u/167747?v=3","gravatar_id":"","url":"https://api.github.com/users/huffman","html_url":"https://github.com/huffman","followers_url":"https://api.github.com/users/huffman/followers","following_url":"https://api.github.com/users/huffman/following{/other_user}","gists_url":"https://api.github.com/users/huffman/gists{/gist_id}","starred_url":"https://api.github.com/users/huffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huffman/subscriptions","organizations_url":"https://api.github.com/users/huffman/orgs","repos_url":"https://api.github.com/users/huffman/repos","events_url":"https://api.github.com/users/huffman/events{/privacy}","received_events_url":"https://api.github.com/users/huffman/received_events","type":"User","site_admin":false},"body":"do these need to be slots?","created_at":"2016-04-29T20:36:02Z","updated_at":"2016-04-29T20:36:02Z","html_url":"https://github.com/highfidelity/hifi/pull/7792#discussion_r61640843","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/7792","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/61640843"},"html":{"href":"https://github.com/highfidelity/hifi/pull/7792#discussion_r61640843"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/7792"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/7792","id":68313592,"html_url":"https://github.com/highfidelity/hifi/pull/7792","diff_url":"https://github.com/highfidelity/hifi/pull/7792.diff","patch_url":"https://github.com/highfidelity/hifi/pull/7792.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/7792","number":7792,"state":"open","locked":false,"title":"Fix dangling reference into container","user":{"login":"Atlante45","id":4036492,"avatar_url":"https://avatars.githubusercontent.com/u/4036492?v=3","gravatar_id":"","url":"https://api.github.com/users/Atlante45","html_url":"https://github.com/Atlante45","followers_url":"https://api.github.com/users/Atlante45/followers","following_url":"https://api.github.com/users/Atlante45/following{/other_user}","gists_url":"https://api.github.com/users/Atlante45/gists{/gist_id}","starred_url":"https://api.github.com/users/Atlante45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Atlante45/subscriptions","organizations_url":"https://api.github.com/users/Atlante45/orgs","repos_url":"https://api.github.com/users/Atlante45/repos","events_url":"https://api.github.com/users/Atlante45/events{/privacy}","received_events_url":"https://api.github.com/users/Atlante45/received_events","type":"User","site_admin":false},"body":"Fixes a crash in asset client","created_at":"2016-04-29T01:05:35Z","updated_at":"2016-04-29T20:36:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3372f696c71435f1b91f02beab2f692c9f715dc6","assignee":{"login":"huffman","id":167747,"avatar_url":"https://avatars.githubusercontent.com/u/167747?v=3","gravatar_id":"","url":"https://api.github.com/users/huffman","html_url":"https://github.com/huffman","followers_url":"https://api.github.com/users/huffman/followers","following_url":"https://api.github.com/users/huffman/following{/other_user}","gists_url":"https://api.github.com/users/huffman/gists{/gist_id}","starred_url":"https://api.github.com/users/huffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huffman/subscriptions","organizations_url":"https://api.github.com/users/huffman/orgs","repos_url":"https://api.github.com/users/huffman/repos","events_url":"https://api.github.com/users/huffman/events{/privacy}","received_events_url":"https://api.github.com/users/huffman/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/7792/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/7792/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/7792/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/9a7bebaaa2a12ba5dff7305c1e3ee88c973ad729","head":{"label":"Atlante45:fix/crash-asset-request","ref":"fix/crash-asset-request","sha":"9a7bebaaa2a12ba5dff7305c1e3ee88c973ad729","user":{"login":"Atlante45","id":4036492,"avatar_url":"https://avatars.githubusercontent.com/u/4036492?v=3","gravatar_id":"","url":"https://api.github.com/users/Atlante45","html_url":"https://github.com/Atlante45","followers_url":"https://api.github.com/users/Atlante45/followers","following_url":"https://api.github.com/users/Atlante45/following{/other_user}","gists_url":"https://api.github.com/users/Atlante45/gists{/gist_id}","starred_url":"https://api.github.com/users/Atlante45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Atlante45/subscriptions","organizations_url":"https://api.github.com/users/Atlante45/orgs","repos_url":"https://api.github.com/users/Atlante45/repos","events_url":"https://api.github.com/users/Atlante45/events{/privacy}","received_events_url":"https://api.github.com/users/Atlante45/received_events","type":"User","site_admin":false},"repo":{"id":11436474,"name":"hifi","full_name":"Atlante45/hifi","owner":{"login":"Atlante45","id":4036492,"avatar_url":"https://avatars.githubusercontent.com/u/4036492?v=3","gravatar_id":"","url":"https://api.github.com/users/Atlante45","html_url":"https://github.com/Atlante45","followers_url":"https://api.github.com/users/Atlante45/followers","following_url":"https://api.github.com/users/Atlante45/following{/other_user}","gists_url":"https://api.github.com/users/Atlante45/gists{/gist_id}","starred_url":"https://api.github.com/users/Atlante45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Atlante45/subscriptions","organizations_url":"https://api.github.com/users/Atlante45/orgs","repos_url":"https://api.github.com/users/Atlante45/repos","events_url":"https://api.github.com/users/Atlante45/events{/privacy}","received_events_url":"https://api.github.com/users/Atlante45/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Atlante45/hifi","description":"Test platform for various render and interface tests for next-gen VR system","fork":true,"url":"https://api.github.com/repos/Atlante45/hifi","forks_url":"https://api.github.com/repos/Atlante45/hifi/forks","keys_url":"https://api.github.com/repos/Atlante45/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Atlante45/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Atlante45/hifi/teams","hooks_url":"https://api.github.com/repos/Atlante45/hifi/hooks","issue_events_url":"https://api.github.com/repos/Atlante45/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/Atlante45/hifi/events","assignees_url":"https://api.github.com/repos/Atlante45/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/Atlante45/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/Atlante45/hifi/tags","blobs_url":"https://api.github.com/repos/Atlante45/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Atlante45/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Atlante45/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/Atlante45/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Atlante45/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/Atlante45/hifi/languages","stargazers_url":"https://api.github.com/repos/Atlante45/hifi/stargazers","contributors_url":"https://api.github.com/repos/Atlante45/hifi/contributors","subscribers_url":"https://api.github.com/repos/Atlante45/hifi/subscribers","subscription_url":"https://api.github.com/repos/Atlante45/hifi/subscription","commits_url":"https://api.github.com/repos/Atlante45/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/Atlante45/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/Atlante45/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/Atlante45/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/Atlante45/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/Atlante45/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Atlante45/hifi/merges","archive_url":"https://api.github.com/repos/Atlante45/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Atlante45/hifi/downloads","issues_url":"https://api.github.com/repos/Atlante45/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/Atlante45/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/Atlante45/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/Atlante45/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Atlante45/hifi/labels{/name}","releases_url":"https://api.github.com/repos/Atlante45/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/Atlante45/hifi/deployments","created_at":"2013-07-15T23:52:30Z","updated_at":"2015-05-08T13:17:34Z","pushed_at":"2016-04-29T17:45:33Z","git_url":"git://github.com/Atlante45/hifi.git","ssh_url":"git@github.com:Atlante45/hifi.git","clone_url":"https://github.com/Atlante45/hifi.git","svn_url":"https://github.com/Atlante45/hifi","homepage":null,"size":225602,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"19e069f6ef381bce0ff224439eed2c124c60045c","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2016-04-28T20:55:45Z","pushed_at":"2016-04-29T20:27:09Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":264649,"stargazers_count":370,"watchers_count":370,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":217,"mirror_url":null,"open_issues_count":22,"forks":217,"open_issues":22,"watchers":370,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/7792"},"html":{"href":"https://github.com/highfidelity/hifi/pull/7792"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/7792"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/7792/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/7792/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/7792/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/9a7bebaaa2a12ba5dff7305c1e3ee88c973ad729"}}}}