{"action":"closed","issue":{"url":"https://api.github.com/repos/dankelley/oce/issues/845","labels_url":"https://api.github.com/repos/dankelley/oce/issues/845/labels{/name}","comments_url":"https://api.github.com/repos/dankelley/oce/issues/845/comments","events_url":"https://api.github.com/repos/dankelley/oce/issues/845/events","html_url":"https://github.com/dankelley/oce/issues/845","id":129646013,"number":845,"title":"imagep decimation shouldn't trigger warning with default options","user":{"login":"richardsc","id":233584,"avatar_url":"https://avatars.githubusercontent.com/u/233584?v=3","gravatar_id":"","url":"https://api.github.com/users/richardsc","html_url":"https://github.com/richardsc","followers_url":"https://api.github.com/users/richardsc/followers","following_url":"https://api.github.com/users/richardsc/following{/other_user}","gists_url":"https://api.github.com/users/richardsc/gists{/gist_id}","starred_url":"https://api.github.com/users/richardsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardsc/subscriptions","organizations_url":"https://api.github.com/users/richardsc/orgs","repos_url":"https://api.github.com/users/richardsc/repos","events_url":"https://api.github.com/users/richardsc/events{/privacy}","received_events_url":"https://api.github.com/users/richardsc/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dankelley/oce/labels/Needs%20recheck","name":"Needs recheck","color":"fbca04"},{"url":"https://api.github.com/repos/dankelley/oce/labels/Next%20Release","name":"Next Release","color":"e11d21"}],"state":"closed","locked":false,"assignee":{"login":"dankelley","id":99469,"avatar_url":"https://avatars.githubusercontent.com/u/99469?v=3","gravatar_id":"","url":"https://api.github.com/users/dankelley","html_url":"https://github.com/dankelley","followers_url":"https://api.github.com/users/dankelley/followers","following_url":"https://api.github.com/users/dankelley/following{/other_user}","gists_url":"https://api.github.com/users/dankelley/gists{/gist_id}","starred_url":"https://api.github.com/users/dankelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankelley/subscriptions","organizations_url":"https://api.github.com/users/dankelley/orgs","repos_url":"https://api.github.com/users/dankelley/repos","events_url":"https://api.github.com/users/dankelley/events{/privacy}","received_events_url":"https://api.github.com/users/dankelley/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2016-01-29T02:32:09Z","updated_at":"2016-02-02T11:50:47Z","closed_at":"2016-02-02T11:50:47Z","body":"What I mean is, if someone calls `imagep()` with the default options (in which `decimate=TRUE`), the decimation shouldn't result in the warning about over decimating. That should be reserved for situations where the `decimate` argument is numeric -- i.e. specified explicitly by the user.\r\n\r\nAn example -- start with a matrix that has a very rectangular aspect ratio:\r\n```r\r\nlibrary(oce)\r\nmat <- matrix(rnorm(100*1000), nrow=1000)\r\nimagep(mat)\r\nWarning message:\r\nIn imagep(mat) : decimation leaves less than 100 pixels in height or width\r\n```\r\n\r\nI'm starting to wonder if perhaps `imagep()` should *always* warn on decimation, to avoid confusion about what's being plotted, especially when the default is to decimate. I mean, yes, everybody should RTFM, but I'm a package co-author, and before I got the above error I spent 10 minutes trying to figure out why an Argo matrix with 116 profiles was coming out looking like it had 20 (because it had 1000 pressure levels, so decimation was kicking in)."}}