{"action":"created","issue":{"url":"https://api.github.com/repos/wireapp/generic-message-proto/issues/4","repository_url":"https://api.github.com/repos/wireapp/generic-message-proto","labels_url":"https://api.github.com/repos/wireapp/generic-message-proto/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/wireapp/generic-message-proto/issues/4/comments","events_url":"https://api.github.com/repos/wireapp/generic-message-proto/issues/4/events","html_url":"https://github.com/wireapp/generic-message-proto/pull/4","id":169912469,"number":4,"title":"Add ModificationType enum and version id, rename MsgDeleted","user":{"login":"daehn","id":4603353,"avatar_url":"https://avatars.githubusercontent.com/u/4603353?v=3","gravatar_id":"","url":"https://api.github.com/users/daehn","html_url":"https://github.com/daehn","followers_url":"https://api.github.com/users/daehn/followers","following_url":"https://api.github.com/users/daehn/following{/other_user}","gists_url":"https://api.github.com/users/daehn/gists{/gist_id}","starred_url":"https://api.github.com/users/daehn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daehn/subscriptions","organizations_url":"https://api.github.com/users/daehn/orgs","repos_url":"https://api.github.com/users/daehn/repos","events_url":"https://api.github.com/users/daehn/events{/privacy}","received_events_url":"https://api.github.com/users/daehn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/wireapp/generic-message-proto/labels/Internal","name":"Internal","color":"006b75"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-08T12:36:44Z","updated_at":"2016-08-08T13:15:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wireapp/generic-message-proto/pulls/4","html_url":"https://github.com/wireapp/generic-message-proto/pull/4","diff_url":"https://github.com/wireapp/generic-message-proto/pull/4.diff","patch_url":"https://github.com/wireapp/generic-message-proto/pull/4.patch"},"body":"This PR adds a new `ModificationType` enum to the spec. If a message needs to be edited or deleted (on all devices), the optional `modification` field needs to be set and the message. \r\nWe introduced a new field `version_id` which should be set to a time based UUID when inserting a message as well as when applying a modification. Updates to messages (like adding a link preview for example) are only valid if they share the same `version_id` as the original message. Using the `version_id` we can avoid race conditions, for example when a message containing a link gets edited before the link preview was fetched and sent, which then might no longer be the correct preview. No `version_id` should always be considered the oldest version to keep compatibility with older clients."},"comment":{"url":"https://api.github.com/repos/wireapp/generic-message-proto/issues/comments/238231512","html_url":"https://github.com/wireapp/generic-message-proto/pull/4#issuecomment-238231512","issue_url":"https://api.github.com/repos/wireapp/generic-message-proto/issues/4","id":238231512,"user":{"login":"bennyn","id":469989,"avatar_url":"https://avatars.githubusercontent.com/u/469989?v=3","gravatar_id":"","url":"https://api.github.com/users/bennyn","html_url":"https://github.com/bennyn","followers_url":"https://api.github.com/users/bennyn/followers","following_url":"https://api.github.com/users/bennyn/following{/other_user}","gists_url":"https://api.github.com/users/bennyn/gists{/gist_id}","starred_url":"https://api.github.com/users/bennyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bennyn/subscriptions","organizations_url":"https://api.github.com/users/bennyn/orgs","repos_url":"https://api.github.com/users/bennyn/repos","events_url":"https://api.github.com/users/bennyn/events{/privacy}","received_events_url":"https://api.github.com/users/bennyn/received_events","type":"User","site_admin":false},"created_at":"2016-08-08T13:15:52Z","updated_at":"2016-08-08T13:15:52Z","body":"Do be consistent we shouldn't shorten \"Message\" to \"Msg\" because we have already a `message GenericMessage`. \r\n\r\nSo I propose to call it `message MessageHide` instead of `message MsgHide`."}}
{"actor":{"display_login":"bennyn"}}