{"action":"closed","issue":{"url":"https://api.github.com/repos/phetsims/rutherford-scattering/issues/88","repository_url":"https://api.github.com/repos/phetsims/rutherford-scattering","labels_url":"https://api.github.com/repos/phetsims/rutherford-scattering/issues/88/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/rutherford-scattering/issues/88/comments","events_url":"https://api.github.com/repos/phetsims/rutherford-scattering/issues/88/events","html_url":"https://github.com/phetsims/rutherford-scattering/issues/88","id":166418820,"number":88,"title":"RutherfordNucleus.js: add documentation on when no unlink/dispose are needed.","user":{"login":"schmitzware","id":694045,"avatar_url":"https://avatars.githubusercontent.com/u/694045?v=3","gravatar_id":"","url":"https://api.github.com/users/schmitzware","html_url":"https://github.com/schmitzware","followers_url":"https://api.github.com/users/schmitzware/followers","following_url":"https://api.github.com/users/schmitzware/following{/other_user}","gists_url":"https://api.github.com/users/schmitzware/gists{/gist_id}","starred_url":"https://api.github.com/users/schmitzware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmitzware/subscriptions","organizations_url":"https://api.github.com/users/schmitzware/orgs","repos_url":"https://api.github.com/users/schmitzware/repos","events_url":"https://api.github.com/users/schmitzware/events{/privacy}","received_events_url":"https://api.github.com/users/schmitzware/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/phetsims/rutherford-scattering/labels/dev:code-review","name":"dev:code-review","color":"104E8B"}],"state":"closed","locked":false,"assignee":{"login":"jessegreenberg","id":6396244,"avatar_url":"https://avatars.githubusercontent.com/u/6396244?v=3","gravatar_id":"","url":"https://api.github.com/users/jessegreenberg","html_url":"https://github.com/jessegreenberg","followers_url":"https://api.github.com/users/jessegreenberg/followers","following_url":"https://api.github.com/users/jessegreenberg/following{/other_user}","gists_url":"https://api.github.com/users/jessegreenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jessegreenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessegreenberg/subscriptions","organizations_url":"https://api.github.com/users/jessegreenberg/orgs","repos_url":"https://api.github.com/users/jessegreenberg/repos","events_url":"https://api.github.com/users/jessegreenberg/events{/privacy}","received_events_url":"https://api.github.com/users/jessegreenberg/received_events","type":"User","site_admin":false},"assignees":[{"login":"jessegreenberg","id":6396244,"avatar_url":"https://avatars.githubusercontent.com/u/6396244?v=3","gravatar_id":"","url":"https://api.github.com/users/jessegreenberg","html_url":"https://github.com/jessegreenberg","followers_url":"https://api.github.com/users/jessegreenberg/followers","following_url":"https://api.github.com/users/jessegreenberg/following{/other_user}","gists_url":"https://api.github.com/users/jessegreenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jessegreenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessegreenberg/subscriptions","organizations_url":"https://api.github.com/users/jessegreenberg/orgs","repos_url":"https://api.github.com/users/jessegreenberg/repos","events_url":"https://api.github.com/users/jessegreenberg/events{/privacy}","received_events_url":"https://api.github.com/users/jessegreenberg/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-07-19T19:53:07Z","updated_at":"2016-08-03T16:25:25Z","closed_at":"2016-08-03T16:25:25Z","body":"Seems like this issue has popped up in discussions and added recently added to the checklist:\r\n\r\n> For each common-code component (sun, scenery-phet, vegas, …) that opaquely registers observers or listeners, is there a call to that component’s dispose function, or documentation about why dispose is unnecessary?\r\n\r\nKinda seems like overkill to me if there's no memory leaks (which there are not) but I thought I'd mention it. There's most likely other files where this is relevant as I believe this came up after I did the original JS version.  I'll just assume this issue covers those and leave it up to you to decide if we want go back and document this or not.\r\n\r\n```\r\n    protonCountProperty.link( function( protonCount ) {\r\n      configureNucleus( protonCount, 'proton' );\r\n    } );\r\n\r\n    neutronCountProperty.link( function( neutronCount ) {\r\n      configureNucleus( neutronCount, 'neutron' );\r\n    } );\r\n  }\r\n\r\n  rutherfordScattering.register( 'RutherfordNucleus', RutherfordNucleus );\r\n\r\n  return inherit( ParticleAtom, RutherfordNucleus );\r\n```"}}
{"actor":{"display_login":"jessegreenberg"}}