{"action":"created","issue":{"url":"https://api.github.com/repos/SparkFund/google-apps-clj/issues/16","repository_url":"https://api.github.com/repos/SparkFund/google-apps-clj","labels_url":"https://api.github.com/repos/SparkFund/google-apps-clj/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/SparkFund/google-apps-clj/issues/16/comments","events_url":"https://api.github.com/repos/SparkFund/google-apps-clj/issues/16/events","html_url":"https://github.com/SparkFund/google-apps-clj/pull/16","id":140044089,"number":16,"title":"Revamp Drive APIs; squash type checking errors","user":{"login":"jffry","id":602773,"avatar_url":"https://avatars.githubusercontent.com/u/602773?v=3","gravatar_id":"","url":"https://api.github.com/users/jffry","html_url":"https://github.com/jffry","followers_url":"https://api.github.com/users/jffry/followers","following_url":"https://api.github.com/users/jffry/following{/other_user}","gists_url":"https://api.github.com/users/jffry/gists{/gist_id}","starred_url":"https://api.github.com/users/jffry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jffry/subscriptions","organizations_url":"https://api.github.com/users/jffry/orgs","repos_url":"https://api.github.com/users/jffry/repos","events_url":"https://api.github.com/users/jffry/events{/privacy}","received_events_url":"https://api.github.com/users/jffry/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"dball","id":12763,"avatar_url":"https://avatars.githubusercontent.com/u/12763?v=3","gravatar_id":"","url":"https://api.github.com/users/dball","html_url":"https://github.com/dball","followers_url":"https://api.github.com/users/dball/followers","following_url":"https://api.github.com/users/dball/following{/other_user}","gists_url":"https://api.github.com/users/dball/gists{/gist_id}","starred_url":"https://api.github.com/users/dball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dball/subscriptions","organizations_url":"https://api.github.com/users/dball/orgs","repos_url":"https://api.github.com/users/dball/repos","events_url":"https://api.github.com/users/dball/events{/privacy}","received_events_url":"https://api.github.com/users/dball/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-03-10T23:54:45Z","updated_at":"2016-03-11T03:08:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SparkFund/google-apps-clj/pulls/16","html_url":"https://github.com/SparkFund/google-apps-clj/pull/16","diff_url":"https://github.com/SparkFund/google-apps-clj/pull/16.diff","patch_url":"https://github.com/SparkFund/google-apps-clj/pull/16.patch"},"body":"This branch introduces a large number of breaking changes to the `google-apps-clj.google-drive` namespace in the first part of a larger effort to better organize and document the code.  It also squashes type checking errors across the entire codebase.\r\n\r\nThere is one very notable breaking change - previously, when converting Google Drive API responses into Clojure maps, we would suffix the map key with a `?` if the value was literal `true`, but not for any other value (not even `false`).  We will no longer be doing this.\r\n\r\nFor example, previously, we would convert `{\"canInvite\" true}` to `{:can-invite? true}`.  After this change, it will instead be transformed to `{:can-invite true}` (note the lack of a question mark).  Keys for other values will remain unchanged, as before (e.g. `{\"canInvite\" false}` still becomes `{:can-invite false}`\r\n\r\nMany helper functions were renamed, and a lot of the file functions were changed and consolidated to push many \"optional\" config options into a separate, optional map argument rather than taking them as unnamed parameters.  This ultimately should make the simple-case calls easier, while making code performing more advanced customizations easier to read.\r\n\r\nIf your code interacts with the `google-drive` namespace, you should carefully scrutinize each call and update it to be correct given these API changes."},"comment":{"url":"https://api.github.com/repos/SparkFund/google-apps-clj/issues/comments/195157672","html_url":"https://github.com/SparkFund/google-apps-clj/pull/16#issuecomment-195157672","issue_url":"https://api.github.com/repos/SparkFund/google-apps-clj/issues/16","id":195157672,"user":{"login":"dball","id":12763,"avatar_url":"https://avatars.githubusercontent.com/u/12763?v=3","gravatar_id":"","url":"https://api.github.com/users/dball","html_url":"https://github.com/dball","followers_url":"https://api.github.com/users/dball/followers","following_url":"https://api.github.com/users/dball/following{/other_user}","gists_url":"https://api.github.com/users/dball/gists{/gist_id}","starred_url":"https://api.github.com/users/dball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dball/subscriptions","organizations_url":"https://api.github.com/users/dball/orgs","repos_url":"https://api.github.com/users/dball/repos","events_url":"https://api.github.com/users/dball/events{/privacy}","received_events_url":"https://api.github.com/users/dball/received_events","type":"User","site_admin":false},"created_at":"2016-03-11T03:08:50Z","updated_at":"2016-03-11T03:08:50Z","body":"@jffry This looks good and you're totally the hero for beating the types into shape.\r\n\r\nThe test ns doesn't compile now though, did you ever run 'em? I can take a stab at getting it into shape if not and you'd like."}}