{"action":"created","issue":{"url":"https://api.github.com/repos/OpenZWave/open-zwave/issues/771","repository_url":"https://api.github.com/repos/OpenZWave/open-zwave","labels_url":"https://api.github.com/repos/OpenZWave/open-zwave/issues/771/labels{/name}","comments_url":"https://api.github.com/repos/OpenZWave/open-zwave/issues/771/comments","events_url":"https://api.github.com/repos/OpenZWave/open-zwave/issues/771/events","html_url":"https://github.com/OpenZWave/open-zwave/issues/771","id":132155298,"number":771,"title":"Header files in subfolders have incorrect includes","user":{"login":"julienw","id":454175,"avatar_url":"https://avatars.githubusercontent.com/u/454175?v=3","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/OpenZWave/open-zwave/labels/wontfix","name":"wontfix","color":"ffffff"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-02-08T14:25:13Z","updated_at":"2016-02-17T01:26:28Z","closed_at":"2016-02-10T04:45:03Z","body":"Most headers include other headers using `#includes \"Header.h\"`. But the quote includes look in the same directory, and in directories specified by -I then.\r\n\r\nBut the headers in the subdirectories (eg: value_classes, or platform), that most include other open-zwave header using eg `#include \"Defs.h\"` fail when we don't use `-I path-to-openzwave-headers` to build.\r\n\r\nThis is too bad because this could be easy to fix by using relative paths instead."},"comment":{"url":"https://api.github.com/repos/OpenZWave/open-zwave/issues/comments/184963925","html_url":"https://github.com/OpenZWave/open-zwave/issues/771#issuecomment-184963925","issue_url":"https://api.github.com/repos/OpenZWave/open-zwave/issues/771","id":184963925,"user":{"login":"vexofp","id":15070192,"avatar_url":"https://avatars.githubusercontent.com/u/15070192?v=3","gravatar_id":"","url":"https://api.github.com/users/vexofp","html_url":"https://github.com/vexofp","followers_url":"https://api.github.com/users/vexofp/followers","following_url":"https://api.github.com/users/vexofp/following{/other_user}","gists_url":"https://api.github.com/users/vexofp/gists{/gist_id}","starred_url":"https://api.github.com/users/vexofp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vexofp/subscriptions","organizations_url":"https://api.github.com/users/vexofp/orgs","repos_url":"https://api.github.com/users/vexofp/repos","events_url":"https://api.github.com/users/vexofp/events{/privacy}","received_events_url":"https://api.github.com/users/vexofp/received_events","type":"User","site_admin":false},"created_at":"2016-02-17T01:26:28Z","updated_at":"2016-02-17T01:26:28Z","body":"Indeed. Changing #include's internal to the different headers should have no effect on how user code can include them. This change only _removes_ an implicit dependency on the users build environment being set up a particular way.\r\n\r\nThe current recommended setup of adding the openzwave root to the include path and including headers directly will continue to work, but the option of not doing so and including necessary headers by their full path will also be enabled.\r\n"}}