{"action":"closed","number":2369,"pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2369","id":63495935,"html_url":"https://github.com/ethereum/go-ethereum/pull/2369","diff_url":"https://github.com/ethereum/go-ethereum/pull/2369.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/2369.patch","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/2369","number":2369,"state":"closed","locked":false,"title":"Strip extraneous carriage return from end of entered password","user":{"login":"hiddentao","id":266594,"avatar_url":"https://avatars.githubusercontent.com/u/266594?v=3","gravatar_id":"","url":"https://api.github.com/users/hiddentao","html_url":"https://github.com/hiddentao","followers_url":"https://api.github.com/users/hiddentao/followers","following_url":"https://api.github.com/users/hiddentao/following{/other_user}","gists_url":"https://api.github.com/users/hiddentao/gists{/gist_id}","starred_url":"https://api.github.com/users/hiddentao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiddentao/subscriptions","organizations_url":"https://api.github.com/users/hiddentao/orgs","repos_url":"https://api.github.com/users/hiddentao/repos","events_url":"https://api.github.com/users/hiddentao/events{/privacy}","received_events_url":"https://api.github.com/users/hiddentao/received_events","type":"User","site_admin":false},"body":"Current users of the Mist wallet on OS X are [unable to import their presale wallets](https://github.com/ethereum/mist/issues/182). This is due to the fallback terminal password input mechanism failing to strip off the carriage return at the end of the input. I confirmed that this is a bug within geth itself.\r\n\r\nThis PR fixes this issue.","created_at":"2016-03-20T13:53:26Z","updated_at":"2016-03-21T20:35:49Z","closed_at":"2016-03-21T20:35:49Z","merged_at":null,"merge_commit_sha":"c701aaa86921f76f09a6c695bc9f9445b3428ece","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2369/commits","review_comments_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2369/comments","review_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/2369/comments","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/9fbf557d24984b8dd838a215149be3f446b7ef44","head":{"label":"hiddentao:fix_read_passwd","ref":"fix_read_passwd","sha":"9fbf557d24984b8dd838a215149be3f446b7ef44","user":{"login":"hiddentao","id":266594,"avatar_url":"https://avatars.githubusercontent.com/u/266594?v=3","gravatar_id":"","url":"https://api.github.com/users/hiddentao","html_url":"https://github.com/hiddentao","followers_url":"https://api.github.com/users/hiddentao/followers","following_url":"https://api.github.com/users/hiddentao/following{/other_user}","gists_url":"https://api.github.com/users/hiddentao/gists{/gist_id}","starred_url":"https://api.github.com/users/hiddentao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiddentao/subscriptions","organizations_url":"https://api.github.com/users/hiddentao/orgs","repos_url":"https://api.github.com/users/hiddentao/repos","events_url":"https://api.github.com/users/hiddentao/events{/privacy}","received_events_url":"https://api.github.com/users/hiddentao/received_events","type":"User","site_admin":false},"repo":{"id":54319570,"name":"go-ethereum","full_name":"hiddentao/go-ethereum","owner":{"login":"hiddentao","id":266594,"avatar_url":"https://avatars.githubusercontent.com/u/266594?v=3","gravatar_id":"","url":"https://api.github.com/users/hiddentao","html_url":"https://github.com/hiddentao","followers_url":"https://api.github.com/users/hiddentao/followers","following_url":"https://api.github.com/users/hiddentao/following{/other_user}","gists_url":"https://api.github.com/users/hiddentao/gists{/gist_id}","starred_url":"https://api.github.com/users/hiddentao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiddentao/subscriptions","organizations_url":"https://api.github.com/users/hiddentao/orgs","repos_url":"https://api.github.com/users/hiddentao/repos","events_url":"https://api.github.com/users/hiddentao/events{/privacy}","received_events_url":"https://api.github.com/users/hiddentao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hiddentao/go-ethereum","description":"Official golang implementation of the Ethereum protocol","fork":true,"url":"https://api.github.com/repos/hiddentao/go-ethereum","forks_url":"https://api.github.com/repos/hiddentao/go-ethereum/forks","keys_url":"https://api.github.com/repos/hiddentao/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hiddentao/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hiddentao/go-ethereum/teams","hooks_url":"https://api.github.com/repos/hiddentao/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/hiddentao/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/hiddentao/go-ethereum/events","assignees_url":"https://api.github.com/repos/hiddentao/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/hiddentao/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/hiddentao/go-ethereum/tags","blobs_url":"https://api.github.com/repos/hiddentao/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hiddentao/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hiddentao/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/hiddentao/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hiddentao/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/hiddentao/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/hiddentao/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/hiddentao/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/hiddentao/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/hiddentao/go-ethereum/subscription","commits_url":"https://api.github.com/repos/hiddentao/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/hiddentao/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/hiddentao/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/hiddentao/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/hiddentao/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/hiddentao/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hiddentao/go-ethereum/merges","archive_url":"https://api.github.com/repos/hiddentao/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hiddentao/go-ethereum/downloads","issues_url":"https://api.github.com/repos/hiddentao/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/hiddentao/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/hiddentao/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/hiddentao/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hiddentao/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/hiddentao/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/hiddentao/go-ethereum/deployments","created_at":"2016-03-20T13:39:59Z","updated_at":"2016-03-20T13:40:05Z","pushed_at":"2016-03-20T13:49:38Z","git_url":"git://github.com/hiddentao/go-ethereum.git","ssh_url":"git@github.com:hiddentao/go-ethereum.git","clone_url":"https://github.com/hiddentao/go-ethereum.git","svn_url":"https://github.com/hiddentao/go-ethereum","homepage":"http://ethereum.github.io/go-ethereum/","size":58903,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"506c9277911746dfbab0a585aee736bd3095f206","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15452919,"name":"go-ethereum","full_name":"ethereum/go-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/go-ethereum","description":"Official golang implementation of the Ethereum protocol","fork":false,"url":"https://api.github.com/repos/ethereum/go-ethereum","forks_url":"https://api.github.com/repos/ethereum/go-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/go-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/go-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/go-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/go-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/go-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/go-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/go-ethereum/deployments","created_at":"2013-12-26T13:05:46Z","updated_at":"2016-03-21T13:08:13Z","pushed_at":"2016-03-21T16:52:21Z","git_url":"git://github.com/ethereum/go-ethereum.git","ssh_url":"git@github.com:ethereum/go-ethereum.git","clone_url":"https://github.com/ethereum/go-ethereum.git","svn_url":"https://github.com/ethereum/go-ethereum","homepage":"http://ethereum.github.io/go-ethereum/","size":155555,"stargazers_count":1203,"watchers_count":1203,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":395,"mirror_url":null,"open_issues_count":203,"forks":395,"open_issues":203,"watchers":1203,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2369"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/2369"},"issue":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/2369"},"comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/2369/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2369/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2369/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/go-ethereum/statuses/9fbf557d24984b8dd838a215149be3f446b7ef44"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":10,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}