{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/djc/ladaemon/pulls/1","id":74622095,"html_url":"https://github.com/djc/ladaemon/pull/1","diff_url":"https://github.com/djc/ladaemon/pull/1.diff","patch_url":"https://github.com/djc/ladaemon/pull/1.patch","issue_url":"https://api.github.com/repos/djc/ladaemon/issues/1","number":1,"state":"closed","locked":false,"title":"Modularize","user":{"login":"callahad","id":24193,"avatar_url":"https://avatars.githubusercontent.com/u/24193?v=3","gravatar_id":"","url":"https://api.github.com/users/callahad","html_url":"https://github.com/callahad","followers_url":"https://api.github.com/users/callahad/followers","following_url":"https://api.github.com/users/callahad/following{/other_user}","gists_url":"https://api.github.com/users/callahad/gists{/gist_id}","starred_url":"https://api.github.com/users/callahad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callahad/subscriptions","organizations_url":"https://api.github.com/users/callahad/orgs","repos_url":"https://api.github.com/users/callahad/repos","events_url":"https://api.github.com/users/callahad/events{/privacy}","received_events_url":"https://api.github.com/users/callahad/received_events","type":"User","site_admin":false},"body":"The end goal is to split the library up into smaller modules with consistent interfaces, so we can isolate and better reason about interactions. This PR just moves lines of code into different files, without changing any logic, but it starts us down that path.\r\n\r\nMaybe something like this?\r\n\r\n```\r\n├── main\r\n├── lib\r\n├── handlers\r\n│   ├── openid_provider\r\n│   └── website\r\n└── providers\r\n    ├── gmail\r\n    └── smtp\r\n```\r\n\r\nI'd like to design the providers such that you can interrogate them, and they can respond with whether or not they can handle a given email address. E.g., `gmail::can_auth(\"example@gmail.com\")` would be `true`. Then we just just put them in priority order and use the first to say \"yes.\"","created_at":"2016-06-21T14:29:31Z","updated_at":"2016-06-24T16:42:15Z","closed_at":"2016-06-24T16:42:15Z","merged_at":null,"merge_commit_sha":"12b97d51a8d55acac4d2f03f1a40307b5f6fca84","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/djc/ladaemon/pulls/1/commits","review_comments_url":"https://api.github.com/repos/djc/ladaemon/pulls/1/comments","review_comment_url":"https://api.github.com/repos/djc/ladaemon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/djc/ladaemon/issues/1/comments","statuses_url":"https://api.github.com/repos/djc/ladaemon/statuses/e038b79f3d9be0838737c30152ebed24e6fdba6d","head":{"label":"callahad:modularize","ref":"modularize","sha":"e038b79f3d9be0838737c30152ebed24e6fdba6d","user":{"login":"callahad","id":24193,"avatar_url":"https://avatars.githubusercontent.com/u/24193?v=3","gravatar_id":"","url":"https://api.github.com/users/callahad","html_url":"https://github.com/callahad","followers_url":"https://api.github.com/users/callahad/followers","following_url":"https://api.github.com/users/callahad/following{/other_user}","gists_url":"https://api.github.com/users/callahad/gists{/gist_id}","starred_url":"https://api.github.com/users/callahad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callahad/subscriptions","organizations_url":"https://api.github.com/users/callahad/orgs","repos_url":"https://api.github.com/users/callahad/repos","events_url":"https://api.github.com/users/callahad/events{/privacy}","received_events_url":"https://api.github.com/users/callahad/received_events","type":"User","site_admin":false},"repo":{"id":61639362,"name":"ladaemon","full_name":"callahad/ladaemon","owner":{"login":"callahad","id":24193,"avatar_url":"https://avatars.githubusercontent.com/u/24193?v=3","gravatar_id":"","url":"https://api.github.com/users/callahad","html_url":"https://github.com/callahad","followers_url":"https://api.github.com/users/callahad/followers","following_url":"https://api.github.com/users/callahad/following{/other_user}","gists_url":"https://api.github.com/users/callahad/gists{/gist_id}","starred_url":"https://api.github.com/users/callahad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callahad/subscriptions","organizations_url":"https://api.github.com/users/callahad/orgs","repos_url":"https://api.github.com/users/callahad/repos","events_url":"https://api.github.com/users/callahad/events{/privacy}","received_events_url":"https://api.github.com/users/callahad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/callahad/ladaemon","description":"Let's Auth daemon, written in Rust","fork":true,"url":"https://api.github.com/repos/callahad/ladaemon","forks_url":"https://api.github.com/repos/callahad/ladaemon/forks","keys_url":"https://api.github.com/repos/callahad/ladaemon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callahad/ladaemon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callahad/ladaemon/teams","hooks_url":"https://api.github.com/repos/callahad/ladaemon/hooks","issue_events_url":"https://api.github.com/repos/callahad/ladaemon/issues/events{/number}","events_url":"https://api.github.com/repos/callahad/ladaemon/events","assignees_url":"https://api.github.com/repos/callahad/ladaemon/assignees{/user}","branches_url":"https://api.github.com/repos/callahad/ladaemon/branches{/branch}","tags_url":"https://api.github.com/repos/callahad/ladaemon/tags","blobs_url":"https://api.github.com/repos/callahad/ladaemon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callahad/ladaemon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callahad/ladaemon/git/refs{/sha}","trees_url":"https://api.github.com/repos/callahad/ladaemon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callahad/ladaemon/statuses/{sha}","languages_url":"https://api.github.com/repos/callahad/ladaemon/languages","stargazers_url":"https://api.github.com/repos/callahad/ladaemon/stargazers","contributors_url":"https://api.github.com/repos/callahad/ladaemon/contributors","subscribers_url":"https://api.github.com/repos/callahad/ladaemon/subscribers","subscription_url":"https://api.github.com/repos/callahad/ladaemon/subscription","commits_url":"https://api.github.com/repos/callahad/ladaemon/commits{/sha}","git_commits_url":"https://api.github.com/repos/callahad/ladaemon/git/commits{/sha}","comments_url":"https://api.github.com/repos/callahad/ladaemon/comments{/number}","issue_comment_url":"https://api.github.com/repos/callahad/ladaemon/issues/comments{/number}","contents_url":"https://api.github.com/repos/callahad/ladaemon/contents/{+path}","compare_url":"https://api.github.com/repos/callahad/ladaemon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callahad/ladaemon/merges","archive_url":"https://api.github.com/repos/callahad/ladaemon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callahad/ladaemon/downloads","issues_url":"https://api.github.com/repos/callahad/ladaemon/issues{/number}","pulls_url":"https://api.github.com/repos/callahad/ladaemon/pulls{/number}","milestones_url":"https://api.github.com/repos/callahad/ladaemon/milestones{/number}","notifications_url":"https://api.github.com/repos/callahad/ladaemon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callahad/ladaemon/labels{/name}","releases_url":"https://api.github.com/repos/callahad/ladaemon/releases{/id}","deployments_url":"https://api.github.com/repos/callahad/ladaemon/deployments","created_at":"2016-06-21T14:14:23Z","updated_at":"2016-06-21T14:14:23Z","pushed_at":"2016-06-24T16:41:43Z","git_url":"git://github.com/callahad/ladaemon.git","ssh_url":"git@github.com:callahad/ladaemon.git","clone_url":"https://github.com/callahad/ladaemon.git","svn_url":"https://github.com/callahad/ladaemon","homepage":null,"size":62,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"djc:master","ref":"master","sha":"7ee770bb1097d5f053dd5475b29bbc9d46e5c76f","user":{"login":"djc","id":158471,"avatar_url":"https://avatars.githubusercontent.com/u/158471?v=3","gravatar_id":"","url":"https://api.github.com/users/djc","html_url":"https://github.com/djc","followers_url":"https://api.github.com/users/djc/followers","following_url":"https://api.github.com/users/djc/following{/other_user}","gists_url":"https://api.github.com/users/djc/gists{/gist_id}","starred_url":"https://api.github.com/users/djc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djc/subscriptions","organizations_url":"https://api.github.com/users/djc/orgs","repos_url":"https://api.github.com/users/djc/repos","events_url":"https://api.github.com/users/djc/events{/privacy}","received_events_url":"https://api.github.com/users/djc/received_events","type":"User","site_admin":false},"repo":{"id":59147712,"name":"ladaemon","full_name":"djc/ladaemon","owner":{"login":"djc","id":158471,"avatar_url":"https://avatars.githubusercontent.com/u/158471?v=3","gravatar_id":"","url":"https://api.github.com/users/djc","html_url":"https://github.com/djc","followers_url":"https://api.github.com/users/djc/followers","following_url":"https://api.github.com/users/djc/following{/other_user}","gists_url":"https://api.github.com/users/djc/gists{/gist_id}","starred_url":"https://api.github.com/users/djc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djc/subscriptions","organizations_url":"https://api.github.com/users/djc/orgs","repos_url":"https://api.github.com/users/djc/repos","events_url":"https://api.github.com/users/djc/events{/privacy}","received_events_url":"https://api.github.com/users/djc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/djc/ladaemon","description":"Let's Auth daemon, written in Rust","fork":false,"url":"https://api.github.com/repos/djc/ladaemon","forks_url":"https://api.github.com/repos/djc/ladaemon/forks","keys_url":"https://api.github.com/repos/djc/ladaemon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djc/ladaemon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djc/ladaemon/teams","hooks_url":"https://api.github.com/repos/djc/ladaemon/hooks","issue_events_url":"https://api.github.com/repos/djc/ladaemon/issues/events{/number}","events_url":"https://api.github.com/repos/djc/ladaemon/events","assignees_url":"https://api.github.com/repos/djc/ladaemon/assignees{/user}","branches_url":"https://api.github.com/repos/djc/ladaemon/branches{/branch}","tags_url":"https://api.github.com/repos/djc/ladaemon/tags","blobs_url":"https://api.github.com/repos/djc/ladaemon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djc/ladaemon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djc/ladaemon/git/refs{/sha}","trees_url":"https://api.github.com/repos/djc/ladaemon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djc/ladaemon/statuses/{sha}","languages_url":"https://api.github.com/repos/djc/ladaemon/languages","stargazers_url":"https://api.github.com/repos/djc/ladaemon/stargazers","contributors_url":"https://api.github.com/repos/djc/ladaemon/contributors","subscribers_url":"https://api.github.com/repos/djc/ladaemon/subscribers","subscription_url":"https://api.github.com/repos/djc/ladaemon/subscription","commits_url":"https://api.github.com/repos/djc/ladaemon/commits{/sha}","git_commits_url":"https://api.github.com/repos/djc/ladaemon/git/commits{/sha}","comments_url":"https://api.github.com/repos/djc/ladaemon/comments{/number}","issue_comment_url":"https://api.github.com/repos/djc/ladaemon/issues/comments{/number}","contents_url":"https://api.github.com/repos/djc/ladaemon/contents/{+path}","compare_url":"https://api.github.com/repos/djc/ladaemon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djc/ladaemon/merges","archive_url":"https://api.github.com/repos/djc/ladaemon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djc/ladaemon/downloads","issues_url":"https://api.github.com/repos/djc/ladaemon/issues{/number}","pulls_url":"https://api.github.com/repos/djc/ladaemon/pulls{/number}","milestones_url":"https://api.github.com/repos/djc/ladaemon/milestones{/number}","notifications_url":"https://api.github.com/repos/djc/ladaemon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djc/ladaemon/labels{/name}","releases_url":"https://api.github.com/repos/djc/ladaemon/releases{/id}","deployments_url":"https://api.github.com/repos/djc/ladaemon/deployments","created_at":"2016-05-18T20:10:35Z","updated_at":"2016-05-18T20:12:37Z","pushed_at":"2016-06-24T16:41:43Z","git_url":"git://github.com/djc/ladaemon.git","ssh_url":"git@github.com:djc/ladaemon.git","clone_url":"https://github.com/djc/ladaemon.git","svn_url":"https://github.com/djc/ladaemon","homepage":null,"size":62,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/djc/ladaemon/pulls/1"},"html":{"href":"https://github.com/djc/ladaemon/pull/1"},"issue":{"href":"https://api.github.com/repos/djc/ladaemon/issues/1"},"comments":{"href":"https://api.github.com/repos/djc/ladaemon/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/djc/ladaemon/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/djc/ladaemon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/djc/ladaemon/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/djc/ladaemon/statuses/e038b79f3d9be0838737c30152ebed24e6fdba6d"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":7,"review_comments":0,"commits":13,"additions":840,"deletions":642,"changed_files":17}}
{"actor":{"display_login":"callahad"}}