{"push_id":1254271680,"size":12,"distinct_size":12,"ref":"refs/heads/develop","head":"5b74251c708fcb89e1ea912c595158cd11960b1f","before":"e5b5d0ca6c13ab9bb5acffdcd23b1fbf101f349f","commits":[{"sha":"1270303f01b2d8d85f9639e7bd58218508e65750","author":{"name":"Christopher O'Toole","email":"2075e6441f35eec2093ea0d45885f0e46169a959@gmail.com"},"message":"Added some tests for ChicagoObjectDecoder\n\nNot all of these tests pass.  The tests show my understanding of how\nthe decoder should be working, but my understanding might be off.\n\nThis is meant to start a conversation on what I'm not understanding\nor how the code can be improved.\n\nMy thoughts are that the encoder and decoder should be mirrors\nof each other.  Aggregating a STREAM_RESPONSE probably shouldn't\nbe in the decoder, that belongs in an Aggregator (Message->Message)\n\nTo handle the case where a STREAM_RESPONSE is spread over multiple\nnetty ByteBuf's there needs to be a token message sent to mark the\nend of a stream.  I see the decoder trying to add such a marking\nin the aggregated ChicagoMessage, but I don't see the encoder doing\nanything like that, which makes proper decoding difficult.","distinct":true,"url":"https://api.github.com/repos/smarth-madan/chicago/commits/1270303f01b2d8d85f9639e7bd58218508e65750"},{"sha":"f028ace5fa051f83275f3ac56f676af390340e1a","author":{"name":"Christopher O'Toole","email":"2075e6441f35eec2093ea0d45885f0e46169a959@gmail.com"},"message":"ChicagoObjectDecoder test one byte at a time","distinct":true,"url":"https://api.github.com/repos/smarth-madan/chicago/commits/f028ace5fa051f83275f3ac56f676af390340e1a"},{"sha":"6e9284532650970a5e5f6088f9444b1d1474df6b","author":{"name":"Christopher O'Toole","email":"2075e6441f35eec2093ea0d45885f0e46169a959@gmail.com"},"message":"Merge remote-tracking branch 'origin/develop' into multidecode-tests\n\nConflicts:\n\tsrc/main/java/com/xjeffrose/chicago/ChicagoObjectDecoder.java\n\tsrc/main/java/com/xjeffrose/chicago/DefaultChicagoMessage.java","distinct":true,"url":"https://api.github.com/repos/smarth-madan/chicago/commits/6e9284532650970a5e5f6088f9444b1d1474df6b"},{"sha":"8a17f430c1cba0831058c17ad88de8a24d311f4e","author":{"name":"Christopher O'Toole","email":"2075e6441f35eec2093ea0d45885f0e46169a959@gmail.com"},"message":"Update MessageDecoder and Aggregator test","distinct":true,"url":"https://api.github.com/repos/smarth-madan/chicago/commits/8a17f430c1cba0831058c17ad88de8a24d311f4e"},{"sha":"f35f507bd13bbaa658cab3a88f9d88adb86b11ba","author":{"name":"Christopher O'Toole","email":"2075e6441f35eec2093ea0d45885f0e46169a959@gmail.com"},"message":"Cleanup MessageAggregatorTest\n\nUnderstand now that all responses have \"true\" for keys as the\nrequestor will know what the key was.  Streams should not be\nappending the key after the delim.","distinct":true,"url":"https://api.github.com/repos/smarth-madan/chicago/commits/f35f507bd13bbaa658cab3a88f9d88adb86b11ba"},{"sha":"ef34b262409fed4f1a2821d82cd25f967d0434a8","author":{"name":"xjdr","email":"f0ec0d5328c50885a216b8586231fed33773b71b@gmail.com"},"message":"wip for smarth","distinct":true,"url":"https://api.github.com/repos/smarth-madan/chicago/commits/ef34b262409fed4f1a2821d82cd25f967d0434a8"},{"sha":"90de8986496ba1ec44facb102e41477c7185a298","author":{"name":"xjdr","email":"f0ec0d5328c50885a216b8586231fed33773b71b@gmail.com"},"message":"fixed leak","distinct":true,"url":"https://api.github.com/repos/smarth-madan/chicago/commits/90de8986496ba1ec44facb102e41477c7185a298"},{"sha":"8d780a2ec830f79607a6953cdf13b2b9346aa337","author":{"name":"Jeff Rose","email":"f0ec0d5328c50885a216b8586231fed33773b71b@Gmail.com"},"message":"Merge pull request #66 from otoolec/multidecode-tests\n\nMultidecode tests","distinct":true,"url":"https://api.github.com/repos/smarth-madan/chicago/commits/8d780a2ec830f79607a6953cdf13b2b9346aa337"},{"sha":"fe87504914f7ae40b370b6832d1704726fa8744e","author":{"name":"xjdr","email":"f0ec0d5328c50885a216b8586231fed33773b71b@gmail.com"},"message":"dynamic buffering","distinct":true,"url":"https://api.github.com/repos/smarth-madan/chicago/commits/fe87504914f7ae40b370b6832d1704726fa8744e"},{"sha":"6d60b9402e437149cd323f82da8e6be23f98e41a","author":{"name":"Madan, Smarth","email":"5a157c621a4cad0e7ffe0a0b3ec4b12f265142ec@paypal.com"},"message":"Fixing client","distinct":true,"url":"https://api.github.com/repos/smarth-madan/chicago/commits/6d60b9402e437149cd323f82da8e6be23f98e41a"},{"sha":"32728f69c823b76522fbde1809aed0d4512d97e2","author":{"name":"Madan, Smarth","email":"5a157c621a4cad0e7ffe0a0b3ec4b12f265142ec@paypal.com"},"message":"Merge branch 'develop' of https://github.com/xjdr/chicago into develop","distinct":true,"url":"https://api.github.com/repos/smarth-madan/chicago/commits/32728f69c823b76522fbde1809aed0d4512d97e2"},{"sha":"5b74251c708fcb89e1ea912c595158cd11960b1f","author":{"name":"Madan, Smarth","email":"5a157c621a4cad0e7ffe0a0b3ec4b12f265142ec@paypal.com"},"message":"FIxing the test","distinct":true,"url":"https://api.github.com/repos/smarth-madan/chicago/commits/5b74251c708fcb89e1ea912c595158cd11960b1f"}]}
{"actor":{"display_login":"smarth-madan"}}