{"action":"created","comment":{"url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/comments/88325651","pull_request_review_id":8903022,"id":88325651,"diff_hunk":"@@ -15,9 +15,9 @@ using asio::ip::tcp;\n using namespace hadoop::hdfs;\n \n // Default from CommonConfigurationKeysPublic.java#IO_FILE_BUFFER_SIZE_DEFAULT\n-const size_t PACKET_PAYLOAD_BYTES = 4096;\n+const size_t PACKET_PAYLOAD_BYTES = 4096 * 4;","path":"rice-datanode/source/data_transfer_server.cc","position":5,"original_position":5,"commit_id":"3a4d9bdc03a2e80c17f4349e9167500230959b72","original_commit_id":"d214985f7402918df7e7a2098fd0ad921c2961f4","user":{"login":"Vegetable26","id":8812233,"avatar_url":"https://avatars.githubusercontent.com/u/8812233?v=3","gravatar_id":"","url":"https://api.github.com/users/Vegetable26","html_url":"https://github.com/Vegetable26","followers_url":"https://api.github.com/users/Vegetable26/followers","following_url":"https://api.github.com/users/Vegetable26/following{/other_user}","gists_url":"https://api.github.com/users/Vegetable26/gists{/gist_id}","starred_url":"https://api.github.com/users/Vegetable26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vegetable26/subscriptions","organizations_url":"https://api.github.com/users/Vegetable26/orgs","repos_url":"https://api.github.com/users/Vegetable26/repos","events_url":"https://api.github.com/users/Vegetable26/events{/privacy}","received_events_url":"https://api.github.com/users/Vegetable26/received_events","type":"User","site_admin":false},"body":"I noticed significant speedups after this change too.","created_at":"2016-11-16T20:38:01Z","updated_at":"2016-11-16T20:38:01Z","html_url":"https://github.com/Rice-Comp413-2016/RDFS/pull/71#discussion_r88325651","pull_request_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/comments/88325651"},"html":{"href":"https://github.com/Rice-Comp413-2016/RDFS/pull/71#discussion_r88325651"},"pull_request":{"href":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/71","id":93893698,"html_url":"https://github.com/Rice-Comp413-2016/RDFS/pull/71","diff_url":"https://github.com/Rice-Comp413-2016/RDFS/pull/71.diff","patch_url":"https://github.com/Rice-Comp413-2016/RDFS/pull/71.patch","issue_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/issues/71","number":71,"state":"open","locked":false,"title":"Limit number of concurrent reads/writes in TransferServer to num_xmits","user":{"login":"nichhk","id":6537426,"avatar_url":"https://avatars.githubusercontent.com/u/6537426?v=3","gravatar_id":"","url":"https://api.github.com/users/nichhk","html_url":"https://github.com/nichhk","followers_url":"https://api.github.com/users/nichhk/followers","following_url":"https://api.github.com/users/nichhk/following{/other_user}","gists_url":"https://api.github.com/users/nichhk/gists{/gist_id}","starred_url":"https://api.github.com/users/nichhk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nichhk/subscriptions","organizations_url":"https://api.github.com/users/nichhk/orgs","repos_url":"https://api.github.com/users/nichhk/repos","events_url":"https://api.github.com/users/nichhk/events{/privacy}","received_events_url":"https://api.github.com/users/nichhk/received_events","type":"User","site_admin":false},"body":"testConcurrentRead in ReadWriteTest is not a great test because it does not assert that the number of transmits <= num_xmits, but I looked at the logging to make sure that dn->getNumXmits() is never greater than num_xmits. \r\n\r\nThe test also depends on the first two reads finishing in <1min, because the other two readers will timeout otherwise. But it hasn't failed yet... \r\n\r\n@pelmers @srdieffenbach ","created_at":"2016-11-16T03:06:27Z","updated_at":"2016-11-16T20:38:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da45b73bd6693e226ce40d1f702c06e89ddfd00e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/71/commits","review_comments_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/71/comments","review_comment_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/issues/71/comments","statuses_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/statuses/3a4d9bdc03a2e80c17f4349e9167500230959b72","head":{"label":"Rice-Comp413-2016:repl-dev","ref":"repl-dev","sha":"3a4d9bdc03a2e80c17f4349e9167500230959b72","user":{"login":"Rice-Comp413-2016","id":21268758,"avatar_url":"https://avatars.githubusercontent.com/u/21268758?v=3","gravatar_id":"","url":"https://api.github.com/users/Rice-Comp413-2016","html_url":"https://github.com/Rice-Comp413-2016","followers_url":"https://api.github.com/users/Rice-Comp413-2016/followers","following_url":"https://api.github.com/users/Rice-Comp413-2016/following{/other_user}","gists_url":"https://api.github.com/users/Rice-Comp413-2016/gists{/gist_id}","starred_url":"https://api.github.com/users/Rice-Comp413-2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rice-Comp413-2016/subscriptions","organizations_url":"https://api.github.com/users/Rice-Comp413-2016/orgs","repos_url":"https://api.github.com/users/Rice-Comp413-2016/repos","events_url":"https://api.github.com/users/Rice-Comp413-2016/events{/privacy}","received_events_url":"https://api.github.com/users/Rice-Comp413-2016/received_events","type":"Organization","site_admin":false},"repo":{"id":66678304,"name":"RDFS","full_name":"Rice-Comp413-2016/RDFS","owner":{"login":"Rice-Comp413-2016","id":21268758,"avatar_url":"https://avatars.githubusercontent.com/u/21268758?v=3","gravatar_id":"","url":"https://api.github.com/users/Rice-Comp413-2016","html_url":"https://github.com/Rice-Comp413-2016","followers_url":"https://api.github.com/users/Rice-Comp413-2016/followers","following_url":"https://api.github.com/users/Rice-Comp413-2016/following{/other_user}","gists_url":"https://api.github.com/users/Rice-Comp413-2016/gists{/gist_id}","starred_url":"https://api.github.com/users/Rice-Comp413-2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rice-Comp413-2016/subscriptions","organizations_url":"https://api.github.com/users/Rice-Comp413-2016/orgs","repos_url":"https://api.github.com/users/Rice-Comp413-2016/repos","events_url":"https://api.github.com/users/Rice-Comp413-2016/events{/privacy}","received_events_url":"https://api.github.com/users/Rice-Comp413-2016/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Rice-Comp413-2016/RDFS","description":"The Rice Comp413 class (2016-2017) implementation of HDFS. (This will eventually be put under an open source license, which one TBD).","fork":false,"url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS","forks_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/forks","keys_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/teams","hooks_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/hooks","issue_events_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/issues/events{/number}","events_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/events","assignees_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/assignees{/user}","branches_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/branches{/branch}","tags_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/tags","blobs_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/statuses/{sha}","languages_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/languages","stargazers_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/stargazers","contributors_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/contributors","subscribers_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/subscribers","subscription_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/subscription","commits_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/contents/{+path}","compare_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/merges","archive_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/downloads","issues_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/issues{/number}","pulls_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls{/number}","milestones_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/milestones{/number}","notifications_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/labels{/name}","releases_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/releases{/id}","deployments_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/deployments","created_at":"2016-08-26T20:46:18Z","updated_at":"2016-11-14T21:23:45Z","pushed_at":"2016-11-16T20:36:25Z","git_url":"git://github.com/Rice-Comp413-2016/RDFS.git","ssh_url":"git@github.com:Rice-Comp413-2016/RDFS.git","clone_url":"https://github.com/Rice-Comp413-2016/RDFS.git","svn_url":"https://github.com/Rice-Comp413-2016/RDFS","homepage":"","size":1352,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":24,"forks":1,"open_issues":24,"watchers":1,"default_branch":"develop"}},"base":{"label":"Rice-Comp413-2016:develop","ref":"develop","sha":"fae296ccac805d275f542d5519c4724600edb493","user":{"login":"Rice-Comp413-2016","id":21268758,"avatar_url":"https://avatars.githubusercontent.com/u/21268758?v=3","gravatar_id":"","url":"https://api.github.com/users/Rice-Comp413-2016","html_url":"https://github.com/Rice-Comp413-2016","followers_url":"https://api.github.com/users/Rice-Comp413-2016/followers","following_url":"https://api.github.com/users/Rice-Comp413-2016/following{/other_user}","gists_url":"https://api.github.com/users/Rice-Comp413-2016/gists{/gist_id}","starred_url":"https://api.github.com/users/Rice-Comp413-2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rice-Comp413-2016/subscriptions","organizations_url":"https://api.github.com/users/Rice-Comp413-2016/orgs","repos_url":"https://api.github.com/users/Rice-Comp413-2016/repos","events_url":"https://api.github.com/users/Rice-Comp413-2016/events{/privacy}","received_events_url":"https://api.github.com/users/Rice-Comp413-2016/received_events","type":"Organization","site_admin":false},"repo":{"id":66678304,"name":"RDFS","full_name":"Rice-Comp413-2016/RDFS","owner":{"login":"Rice-Comp413-2016","id":21268758,"avatar_url":"https://avatars.githubusercontent.com/u/21268758?v=3","gravatar_id":"","url":"https://api.github.com/users/Rice-Comp413-2016","html_url":"https://github.com/Rice-Comp413-2016","followers_url":"https://api.github.com/users/Rice-Comp413-2016/followers","following_url":"https://api.github.com/users/Rice-Comp413-2016/following{/other_user}","gists_url":"https://api.github.com/users/Rice-Comp413-2016/gists{/gist_id}","starred_url":"https://api.github.com/users/Rice-Comp413-2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rice-Comp413-2016/subscriptions","organizations_url":"https://api.github.com/users/Rice-Comp413-2016/orgs","repos_url":"https://api.github.com/users/Rice-Comp413-2016/repos","events_url":"https://api.github.com/users/Rice-Comp413-2016/events{/privacy}","received_events_url":"https://api.github.com/users/Rice-Comp413-2016/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Rice-Comp413-2016/RDFS","description":"The Rice Comp413 class (2016-2017) implementation of HDFS. (This will eventually be put under an open source license, which one TBD).","fork":false,"url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS","forks_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/forks","keys_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/teams","hooks_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/hooks","issue_events_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/issues/events{/number}","events_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/events","assignees_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/assignees{/user}","branches_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/branches{/branch}","tags_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/tags","blobs_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/statuses/{sha}","languages_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/languages","stargazers_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/stargazers","contributors_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/contributors","subscribers_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/subscribers","subscription_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/subscription","commits_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/contents/{+path}","compare_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/merges","archive_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/downloads","issues_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/issues{/number}","pulls_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls{/number}","milestones_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/milestones{/number}","notifications_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/labels{/name}","releases_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/releases{/id}","deployments_url":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/deployments","created_at":"2016-08-26T20:46:18Z","updated_at":"2016-11-14T21:23:45Z","pushed_at":"2016-11-16T20:36:25Z","git_url":"git://github.com/Rice-Comp413-2016/RDFS.git","ssh_url":"git@github.com:Rice-Comp413-2016/RDFS.git","clone_url":"https://github.com/Rice-Comp413-2016/RDFS.git","svn_url":"https://github.com/Rice-Comp413-2016/RDFS","homepage":"","size":1352,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":24,"forks":1,"open_issues":24,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/71"},"html":{"href":"https://github.com/Rice-Comp413-2016/RDFS/pull/71"},"issue":{"href":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/issues/71"},"comments":{"href":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/Rice-Comp413-2016/RDFS/statuses/3a4d9bdc03a2e80c17f4349e9167500230959b72"}}}}
{"actor":{"display_login":"Vegetable26"}}