{"action":"created","comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/52760919","id":52760919,"diff_hunk":"@@ -1846,6 +2384,210 @@ define([\n         });\n     };\n \n+    function getNetworkLinkUpdateCallback(dataSource, networkLink, newEntityCollection, networkLinks) {\n+        return function(rootElement) {\n+            var remove = false;\n+            var networkLinkControl = queryFirstNode(rootElement, 'NetworkLinkControl', namespaces.kml);\n+            var hasNetworkLinkControl = defined(networkLinkControl);\n+\n+            var minRefreshPeriod = 0;\n+            if (hasNetworkLinkControl) {\n+                if (defined(queryFirstNode(networkLinkControl, 'Update', namespaces.kml))) {\n+                    console.log('KML - NetworkLinkControl updates aren\\'t supported.');\n+                    networkLink.updating = false;\n+                    networkLinks.splice(networkLinks.indexOf(networkLink), 1);\n+                    return;\n+                }\n+                networkLink.cookie = defaultValue(queryStringValue(networkLinkControl, 'cookie', namespaces.kml), '');\n+                minRefreshPeriod = defaultValue(queryNumericValue(networkLinkControl, 'minRefreshPeriod', namespaces.kml), 0);\n+            }\n+\n+            var now = JulianDate.now();","path":"Source/DataSources/KmlDataSource.js","position":1182,"original_position":1182,"commit_id":"742444ab307ef1a9ccb7ba8d4061752a48a6daa1","original_commit_id":"742444ab307ef1a9ccb7ba8d4061752a48a6daa1","user":{"login":"mramato","id":1495196,"avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=3","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"body":"I assume all you really need here is a timestamp and not a full blown `JulianDate`.  I would use `getTimestamp` instead (it's in Core) everywhere you are using `JulianDate.now()`.  It will be faster, have less GC pressure and returns milliseconds so you can do basic math instead of calling JD functions.","created_at":"2016-02-12T16:13:36Z","updated_at":"2016-02-12T16:13:36Z","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3538#discussion_r52760919","pull_request_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3538","_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/52760919"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3538#discussion_r52760919"},"pull_request":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3538"}}},"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3538","id":58813498,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3538","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3538.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3538.patch","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3538","number":3538,"state":"open","locked":false,"title":"Kml network links","user":{"login":"tfili","id":1652382,"avatar_url":"https://avatars.githubusercontent.com/u/1652382?v=3","gravatar_id":"","url":"https://api.github.com/users/tfili","html_url":"https://github.com/tfili","followers_url":"https://api.github.com/users/tfili/followers","following_url":"https://api.github.com/users/tfili/following{/other_user}","gists_url":"https://api.github.com/users/tfili/gists{/gist_id}","starred_url":"https://api.github.com/users/tfili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfili/subscriptions","organizations_url":"https://api.github.com/users/tfili/orgs","repos_url":"https://api.github.com/users/tfili/repos","events_url":"https://api.github.com/users/tfili/events{/privacy}","received_events_url":"https://api.github.com/users/tfili/received_events","type":"User","site_admin":false},"body":"Added support for onInterval, onExpire and onStop kml refreshes and tests for each of the refresh modes.","created_at":"2016-02-09T21:45:10Z","updated_at":"2016-02-12T16:13:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b02d8c25b542b2b3af72542013cea179c00aea1f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3538/commits","review_comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3538/comments","review_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3538/comments","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/742444ab307ef1a9ccb7ba8d4061752a48a6daa1","head":{"label":"tfili:kml-network-links","ref":"kml-network-links","sha":"742444ab307ef1a9ccb7ba8d4061752a48a6daa1","user":{"login":"tfili","id":1652382,"avatar_url":"https://avatars.githubusercontent.com/u/1652382?v=3","gravatar_id":"","url":"https://api.github.com/users/tfili","html_url":"https://github.com/tfili","followers_url":"https://api.github.com/users/tfili/followers","following_url":"https://api.github.com/users/tfili/following{/other_user}","gists_url":"https://api.github.com/users/tfili/gists{/gist_id}","starred_url":"https://api.github.com/users/tfili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfili/subscriptions","organizations_url":"https://api.github.com/users/tfili/orgs","repos_url":"https://api.github.com/users/tfili/repos","events_url":"https://api.github.com/users/tfili/events{/privacy}","received_events_url":"https://api.github.com/users/tfili/received_events","type":"User","site_admin":false},"repo":{"id":12764777,"name":"cesium","full_name":"tfili/cesium","owner":{"login":"tfili","id":1652382,"avatar_url":"https://avatars.githubusercontent.com/u/1652382?v=3","gravatar_id":"","url":"https://api.github.com/users/tfili","html_url":"https://github.com/tfili","followers_url":"https://api.github.com/users/tfili/followers","following_url":"https://api.github.com/users/tfili/following{/other_user}","gists_url":"https://api.github.com/users/tfili/gists{/gist_id}","starred_url":"https://api.github.com/users/tfili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfili/subscriptions","organizations_url":"https://api.github.com/users/tfili/orgs","repos_url":"https://api.github.com/users/tfili/repos","events_url":"https://api.github.com/users/tfili/events{/privacy}","received_events_url":"https://api.github.com/users/tfili/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tfili/cesium","description":"WebGL virtual globe and map engine","fork":true,"url":"https://api.github.com/repos/tfili/cesium","forks_url":"https://api.github.com/repos/tfili/cesium/forks","keys_url":"https://api.github.com/repos/tfili/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tfili/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tfili/cesium/teams","hooks_url":"https://api.github.com/repos/tfili/cesium/hooks","issue_events_url":"https://api.github.com/repos/tfili/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/tfili/cesium/events","assignees_url":"https://api.github.com/repos/tfili/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/tfili/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/tfili/cesium/tags","blobs_url":"https://api.github.com/repos/tfili/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tfili/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tfili/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/tfili/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tfili/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/tfili/cesium/languages","stargazers_url":"https://api.github.com/repos/tfili/cesium/stargazers","contributors_url":"https://api.github.com/repos/tfili/cesium/contributors","subscribers_url":"https://api.github.com/repos/tfili/cesium/subscribers","subscription_url":"https://api.github.com/repos/tfili/cesium/subscription","commits_url":"https://api.github.com/repos/tfili/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/tfili/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/tfili/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/tfili/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/tfili/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/tfili/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tfili/cesium/merges","archive_url":"https://api.github.com/repos/tfili/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tfili/cesium/downloads","issues_url":"https://api.github.com/repos/tfili/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/tfili/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/tfili/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/tfili/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tfili/cesium/labels{/name}","releases_url":"https://api.github.com/repos/tfili/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/tfili/cesium/deployments","created_at":"2013-09-11T18:56:08Z","updated_at":"2015-02-05T19:52:30Z","pushed_at":"2016-02-12T13:10:11Z","git_url":"git://github.com/tfili/cesium.git","ssh_url":"git@github.com:tfili/cesium.git","clone_url":"https://github.com/tfili/cesium.git","svn_url":"https://github.com/tfili/cesium","homepage":"http://cesium.agi.com/","size":258014,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AnalyticalGraphicsInc:master","ref":"master","sha":"c81afdf34bbcb5cba307dd55cb8b27c85d31451e","user":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"repo":{"id":3606738,"name":"cesium","full_name":"AnalyticalGraphicsInc/cesium","owner":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium","description":"WebGL virtual globe and map engine","fork":false,"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium","forks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/forks","keys_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/teams","hooks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/hooks","issue_events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/events","assignees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/tags","blobs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/languages","stargazers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/stargazers","contributors_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contributors","subscribers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscribers","subscription_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscription","commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/merges","archive_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/downloads","issues_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/labels{/name}","releases_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/deployments","created_at":"2012-03-02T22:27:14Z","updated_at":"2016-02-11T21:06:58Z","pushed_at":"2016-02-12T16:11:03Z","git_url":"git://github.com/AnalyticalGraphicsInc/cesium.git","ssh_url":"git@github.com:AnalyticalGraphicsInc/cesium.git","clone_url":"https://github.com/AnalyticalGraphicsInc/cesium.git","svn_url":"https://github.com/AnalyticalGraphicsInc/cesium","homepage":"cesiumjs.org","size":256298,"stargazers_count":1139,"watchers_count":1139,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":675,"mirror_url":null,"open_issues_count":363,"forks":675,"open_issues":363,"watchers":1139,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3538"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3538"},"issue":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3538"},"comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3538/comments"},"review_comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3538/comments"},"review_comment":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3538/commits"},"statuses":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/742444ab307ef1a9ccb7ba8d4061752a48a6daa1"}}}}