{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/92302258","pull_request_review_id":12814943,"id":92302258,"diff_hunk":"@@ -5254,49 +5254,6 @@ int CGUIInfoManager::TranslateSingleString(const std::string &strCondition, bool\n       return SYSTEM_ALWAYS_FALSE;\n     else if (cat.name == \"true\" || cat.name == \"yes\")\n       return SYSTEM_ALWAYS_TRUE;\n-\n-    // deprecated begin\n-    // should be removed before L*** v18\n-    if (cat.name == \"isempty\" && cat.num_params() == 1)\n-      return AddMultiInfo(GUIInfo(STRING_IS_EMPTY, TranslateSingleString(cat.param(), listItemDependent)));\n-    else if (cat.name == \"stringcompare\" && cat.num_params() == 2)","path":"xbmc/GUIInfoManager.cpp","position":9,"original_position":9,"commit_id":"c45aa87a9259244e4a34ec64d52c6660c9ff160b","original_commit_id":"c45aa87a9259244e4a34ec64d52c6660c9ff160b","user":{"login":"AlwinEsch","id":6879739,"avatar_url":"https://avatars.githubusercontent.com/u/6879739?v=3","gravatar_id":"","url":"https://api.github.com/users/AlwinEsch","html_url":"https://github.com/AlwinEsch","followers_url":"https://api.github.com/users/AlwinEsch/followers","following_url":"https://api.github.com/users/AlwinEsch/following{/other_user}","gists_url":"https://api.github.com/users/AlwinEsch/gists{/gist_id}","starred_url":"https://api.github.com/users/AlwinEsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlwinEsch/subscriptions","organizations_url":"https://api.github.com/users/AlwinEsch/orgs","repos_url":"https://api.github.com/users/AlwinEsch/repos","events_url":"https://api.github.com/users/AlwinEsch/events{/privacy}","received_events_url":"https://api.github.com/users/AlwinEsch/received_events","type":"User","site_admin":false},"body":"This is used on pvr.vdr.vnsi, is there a alternative for a `<visible>StringCompare(Window.Property(menu),osd)</visible>\r\n`","created_at":"2016-12-14T00:55:42Z","updated_at":"2016-12-14T00:55:42Z","html_url":"https://github.com/xbmc/xbmc/pull/11058#discussion_r92302258","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/11058","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/92302258"},"html":{"href":"https://github.com/xbmc/xbmc/pull/11058#discussion_r92302258"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/11058"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/11058","id":96458580,"html_url":"https://github.com/xbmc/xbmc/pull/11058","diff_url":"https://github.com/xbmc/xbmc/pull/11058.diff","patch_url":"https://github.com/xbmc/xbmc/pull/11058.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/11058","number":11058,"state":"closed","locked":false,"title":"remove deprecated infobools","user":{"login":"ronie","id":687265,"avatar_url":"https://avatars.githubusercontent.com/u/687265?v=3","gravatar_id":"","url":"https://api.github.com/users/ronie","html_url":"https://github.com/ronie","followers_url":"https://api.github.com/users/ronie/followers","following_url":"https://api.github.com/users/ronie/following{/other_user}","gists_url":"https://api.github.com/users/ronie/gists{/gist_id}","starred_url":"https://api.github.com/users/ronie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronie/subscriptions","organizations_url":"https://api.github.com/users/ronie/orgs","repos_url":"https://api.github.com/users/ronie/repos","events_url":"https://api.github.com/users/ronie/events{/privacy}","received_events_url":"https://api.github.com/users/ronie/received_events","type":"User","site_admin":false},"body":"remove deprecated stringcompare infobools. ","created_at":"2016-12-05T01:55:39Z","updated_at":"2016-12-14T00:55:42Z","closed_at":"2016-12-12T20:17:34Z","merged_at":"2016-12-12T20:17:34Z","merge_commit_sha":"541576b03ea7a695b68cde557662991ace7f3f42","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/95","html_url":"https://github.com/xbmc/xbmc/milestone/95","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/95/labels","id":2166828,"number":95,"title":"L 18.0-alpha1","description":"","creator":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars.githubusercontent.com/u/907436?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":86,"state":"open","created_at":"2016-11-30T16:58:49Z","updated_at":"2016-12-13T23:41:14Z","due_on":"2017-01-31T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/11058/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/11058/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/11058/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/c45aa87a9259244e4a34ec64d52c6660c9ff160b","head":{"label":"ronie:stringcompare-cleanup","ref":"stringcompare-cleanup","sha":"c45aa87a9259244e4a34ec64d52c6660c9ff160b","user":{"login":"ronie","id":687265,"avatar_url":"https://avatars.githubusercontent.com/u/687265?v=3","gravatar_id":"","url":"https://api.github.com/users/ronie","html_url":"https://github.com/ronie","followers_url":"https://api.github.com/users/ronie/followers","following_url":"https://api.github.com/users/ronie/following{/other_user}","gists_url":"https://api.github.com/users/ronie/gists{/gist_id}","starred_url":"https://api.github.com/users/ronie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronie/subscriptions","organizations_url":"https://api.github.com/users/ronie/orgs","repos_url":"https://api.github.com/users/ronie/repos","events_url":"https://api.github.com/users/ronie/events{/privacy}","received_events_url":"https://api.github.com/users/ronie/received_events","type":"User","site_admin":false},"repo":{"id":1864663,"name":"xbmc","full_name":"ronie/xbmc","owner":{"login":"ronie","id":687265,"avatar_url":"https://avatars.githubusercontent.com/u/687265?v=3","gravatar_id":"","url":"https://api.github.com/users/ronie","html_url":"https://github.com/ronie","followers_url":"https://api.github.com/users/ronie/followers","following_url":"https://api.github.com/users/ronie/following{/other_user}","gists_url":"https://api.github.com/users/ronie/gists{/gist_id}","starred_url":"https://api.github.com/users/ronie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronie/subscriptions","organizations_url":"https://api.github.com/users/ronie/orgs","repos_url":"https://api.github.com/users/ronie/repos","events_url":"https://api.github.com/users/ronie/events{/privacy}","received_events_url":"https://api.github.com/users/ronie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ronie/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/ronie/xbmc","forks_url":"https://api.github.com/repos/ronie/xbmc/forks","keys_url":"https://api.github.com/repos/ronie/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ronie/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ronie/xbmc/teams","hooks_url":"https://api.github.com/repos/ronie/xbmc/hooks","issue_events_url":"https://api.github.com/repos/ronie/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/ronie/xbmc/events","assignees_url":"https://api.github.com/repos/ronie/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/ronie/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/ronie/xbmc/tags","blobs_url":"https://api.github.com/repos/ronie/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ronie/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ronie/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ronie/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ronie/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/ronie/xbmc/languages","stargazers_url":"https://api.github.com/repos/ronie/xbmc/stargazers","contributors_url":"https://api.github.com/repos/ronie/xbmc/contributors","subscribers_url":"https://api.github.com/repos/ronie/xbmc/subscribers","subscription_url":"https://api.github.com/repos/ronie/xbmc/subscription","commits_url":"https://api.github.com/repos/ronie/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ronie/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ronie/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ronie/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ronie/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/ronie/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ronie/xbmc/merges","archive_url":"https://api.github.com/repos/ronie/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ronie/xbmc/downloads","issues_url":"https://api.github.com/repos/ronie/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/ronie/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/ronie/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/ronie/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ronie/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/ronie/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/ronie/xbmc/deployments","created_at":"2011-06-08T10:12:50Z","updated_at":"2015-04-11T19:27:18Z","pushed_at":"2016-12-13T21:36:16Z","git_url":"git://github.com/ronie/xbmc.git","ssh_url":"git@github.com:ronie/xbmc.git","clone_url":"https://github.com/ronie/xbmc.git","svn_url":"https://github.com/ronie/xbmc","homepage":"http://xbmc.org","size":560829,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"74f03695dbeffb3331f3ef43e8a035a27761014e","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2016-12-13T22:55:22Z","pushed_at":"2016-12-14T00:04:03Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1389007,"stargazers_count":5268,"watchers_count":5268,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3791,"mirror_url":null,"open_issues_count":219,"forks":3791,"open_issues":219,"watchers":5268,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/11058"},"html":{"href":"https://github.com/xbmc/xbmc/pull/11058"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/11058"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/11058/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/11058/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/11058/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/c45aa87a9259244e4a34ec64d52c6660c9ff160b"}}}}
{"actor":{"display_login":"AlwinEsch"}}