{"action":"created","issue":{"url":"https://api.github.com/repos/spree/spree/issues/7716","repository_url":"https://api.github.com/repos/spree/spree","labels_url":"https://api.github.com/repos/spree/spree/issues/7716/labels{/name}","comments_url":"https://api.github.com/repos/spree/spree/issues/7716/comments","events_url":"https://api.github.com/repos/spree/spree/issues/7716/events","html_url":"https://github.com/spree/spree/pull/7716","id":192835743,"number":7716,"title":"Fix shipment issues and optimise shipment modules (3-1-stable)","user":{"login":"priyank-gupta","id":894818,"avatar_url":"https://avatars.githubusercontent.com/u/894818?v=3","gravatar_id":"","url":"https://api.github.com/users/priyank-gupta","html_url":"https://github.com/priyank-gupta","followers_url":"https://api.github.com/users/priyank-gupta/followers","following_url":"https://api.github.com/users/priyank-gupta/following{/other_user}","gists_url":"https://api.github.com/users/priyank-gupta/gists{/gist_id}","starred_url":"https://api.github.com/users/priyank-gupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priyank-gupta/subscriptions","organizations_url":"https://api.github.com/users/priyank-gupta/orgs","repos_url":"https://api.github.com/users/priyank-gupta/repos","events_url":"https://api.github.com/users/priyank-gupta/events{/privacy}","received_events_url":"https://api.github.com/users/priyank-gupta/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"damianlegawiec","id":55154,"avatar_url":"https://avatars.githubusercontent.com/u/55154?v=3","gravatar_id":"","url":"https://api.github.com/users/damianlegawiec","html_url":"https://github.com/damianlegawiec","followers_url":"https://api.github.com/users/damianlegawiec/followers","following_url":"https://api.github.com/users/damianlegawiec/following{/other_user}","gists_url":"https://api.github.com/users/damianlegawiec/gists{/gist_id}","starred_url":"https://api.github.com/users/damianlegawiec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianlegawiec/subscriptions","organizations_url":"https://api.github.com/users/damianlegawiec/orgs","repos_url":"https://api.github.com/users/damianlegawiec/repos","events_url":"https://api.github.com/users/damianlegawiec/events{/privacy}","received_events_url":"https://api.github.com/users/damianlegawiec/received_events","type":"User","site_admin":false},"assignees":[{"login":"damianlegawiec","id":55154,"avatar_url":"https://avatars.githubusercontent.com/u/55154?v=3","gravatar_id":"","url":"https://api.github.com/users/damianlegawiec","html_url":"https://github.com/damianlegawiec","followers_url":"https://api.github.com/users/damianlegawiec/followers","following_url":"https://api.github.com/users/damianlegawiec/following{/other_user}","gists_url":"https://api.github.com/users/damianlegawiec/gists{/gist_id}","starred_url":"https://api.github.com/users/damianlegawiec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianlegawiec/subscriptions","organizations_url":"https://api.github.com/users/damianlegawiec/orgs","repos_url":"https://api.github.com/users/damianlegawiec/repos","events_url":"https://api.github.com/users/damianlegawiec/events{/privacy}","received_events_url":"https://api.github.com/users/damianlegawiec/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-12-01T12:38:57Z","updated_at":"2016-12-01T17:06:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spree/spree/pulls/7716","html_url":"https://github.com/spree/spree/pull/7716","diff_url":"https://github.com/spree/spree/pull/7716.diff","patch_url":"https://github.com/spree/spree/pull/7716.patch"},"body":"Refer PR #7222 \r\n\r\nFixes 2 shipment issues, and optimises shipment modules like Coordinator, Prioritizer, Packer etc..\r\n\r\n**Issue 1**\r\n- Scenario: A product has 2 stock items for 2 stock locations. Each stock item has 1 quantity on hand and none is backorderable. User adds 2 quantity of that item in cart and moves to delivery step. Sees a shipment and an unshippable unit.\r\n- Expected: User should see 2 shipments (no unshippable unit) each having 1 associated inventory unit.\r\n\r\n**Issue 2**\r\n- In `order#create_proposed_shipments`, inventory units are destroyed using shipments `has_many inventory_units, dependent: :delete_all` association but units which are not associated to any shipment (like unshippable units) are never destroyed.\r\n"},"comment":{"url":"https://api.github.com/repos/spree/spree/issues/comments/264231456","html_url":"https://github.com/spree/spree/pull/7716#issuecomment-264231456","issue_url":"https://api.github.com/repos/spree/spree/issues/7716","id":264231456,"user":{"login":"damianlegawiec","id":55154,"avatar_url":"https://avatars.githubusercontent.com/u/55154?v=3","gravatar_id":"","url":"https://api.github.com/users/damianlegawiec","html_url":"https://github.com/damianlegawiec","followers_url":"https://api.github.com/users/damianlegawiec/followers","following_url":"https://api.github.com/users/damianlegawiec/following{/other_user}","gists_url":"https://api.github.com/users/damianlegawiec/gists{/gist_id}","starred_url":"https://api.github.com/users/damianlegawiec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianlegawiec/subscriptions","organizations_url":"https://api.github.com/users/damianlegawiec/orgs","repos_url":"https://api.github.com/users/damianlegawiec/repos","events_url":"https://api.github.com/users/damianlegawiec/events{/privacy}","received_events_url":"https://api.github.com/users/damianlegawiec/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T17:06:00Z","updated_at":"2016-12-01T17:06:00Z","body":"@Mafi88 @mauazua what do you think? \r\n\r\nFor me, it's too big for a minor patch release. This changes too many logic and should be part only of a bigger release like `3.2`"}}
{"actor":{"display_login":"damianlegawiec"}}