{"action":"opened","number":471,"pull_request":{"url":"https://api.github.com/repos/alphagov/e-petitions/pulls/471","id":71670686,"html_url":"https://github.com/alphagov/e-petitions/pull/471","diff_url":"https://github.com/alphagov/e-petitions/pull/471.diff","patch_url":"https://github.com/alphagov/e-petitions/pull/471.patch","issue_url":"https://api.github.com/repos/alphagov/e-petitions/issues/471","number":471,"state":"open","locked":false,"title":"Search for emails case-insensitively in the admin","user":{"login":"pixeltrix","id":6321,"avatar_url":"https://avatars.githubusercontent.com/u/6321?v=3","gravatar_id":"","url":"https://api.github.com/users/pixeltrix","html_url":"https://github.com/pixeltrix","followers_url":"https://api.github.com/users/pixeltrix/followers","following_url":"https://api.github.com/users/pixeltrix/following{/other_user}","gists_url":"https://api.github.com/users/pixeltrix/gists{/gist_id}","starred_url":"https://api.github.com/users/pixeltrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixeltrix/subscriptions","organizations_url":"https://api.github.com/users/pixeltrix/orgs","repos_url":"https://api.github.com/users/pixeltrix/repos","events_url":"https://api.github.com/users/pixeltrix/events{/privacy}","received_events_url":"https://api.github.com/users/pixeltrix/received_events","type":"User","site_admin":false},"body":"The default behaviour of PostgreSQL is for varchar columns to be case sensitive so to prevent people signing petitions again by altering the case of their email address we force it to lowercase when we create the signature record. Since this is not visible to the signer when they raise a query with the moderation team they give their upper/lower version of the email address and when it's copied and pasted into the search box in the admin it returns no results because the search is case sensitive.\r\n\r\nOne way to fix this would be to put a case-insensitive collation on the email address column in the signatures table but given the number of rows we have in the table it could mean taking the website down. So the simplest fix is just to make the `for_email` method convert the email address to lowercase before performing the search.\r\n\r\nhttps://www.pivotaltracker.com/story/show/120103205","created_at":"2016-05-27T07:25:01Z","updated_at":"2016-05-27T07:25:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/e-petitions/pulls/471/commits","review_comments_url":"https://api.github.com/repos/alphagov/e-petitions/pulls/471/comments","review_comment_url":"https://api.github.com/repos/alphagov/e-petitions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/e-petitions/issues/471/comments","statuses_url":"https://api.github.com/repos/alphagov/e-petitions/statuses/3e1f3a2a52e6b886921acce826091a27612ed558","head":{"label":"alphagov:search-for-email-case-insensitively","ref":"search-for-email-case-insensitively","sha":"3e1f3a2a52e6b886921acce826091a27612ed558","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":4434819,"name":"e-petitions","full_name":"alphagov/e-petitions","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/e-petitions","description":"This is the code base for the UK Government's e-petitions service (https://petition.parliament.uk)","fork":false,"url":"https://api.github.com/repos/alphagov/e-petitions","forks_url":"https://api.github.com/repos/alphagov/e-petitions/forks","keys_url":"https://api.github.com/repos/alphagov/e-petitions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/e-petitions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/e-petitions/teams","hooks_url":"https://api.github.com/repos/alphagov/e-petitions/hooks","issue_events_url":"https://api.github.com/repos/alphagov/e-petitions/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/e-petitions/events","assignees_url":"https://api.github.com/repos/alphagov/e-petitions/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/e-petitions/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/e-petitions/tags","blobs_url":"https://api.github.com/repos/alphagov/e-petitions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/e-petitions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/e-petitions/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/e-petitions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/e-petitions/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/e-petitions/languages","stargazers_url":"https://api.github.com/repos/alphagov/e-petitions/stargazers","contributors_url":"https://api.github.com/repos/alphagov/e-petitions/contributors","subscribers_url":"https://api.github.com/repos/alphagov/e-petitions/subscribers","subscription_url":"https://api.github.com/repos/alphagov/e-petitions/subscription","commits_url":"https://api.github.com/repos/alphagov/e-petitions/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/e-petitions/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/e-petitions/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/e-petitions/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/e-petitions/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/e-petitions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/e-petitions/merges","archive_url":"https://api.github.com/repos/alphagov/e-petitions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/e-petitions/downloads","issues_url":"https://api.github.com/repos/alphagov/e-petitions/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/e-petitions/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/e-petitions/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/e-petitions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/e-petitions/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/e-petitions/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/e-petitions/deployments","created_at":"2012-05-24T16:04:02Z","updated_at":"2016-05-24T14:19:18Z","pushed_at":"2016-05-27T07:24:12Z","git_url":"git://github.com/alphagov/e-petitions.git","ssh_url":"git@github.com:alphagov/e-petitions.git","clone_url":"https://github.com/alphagov/e-petitions.git","svn_url":"https://github.com/alphagov/e-petitions","homepage":"https://petition.parliament.uk","size":5832,"stargazers_count":48,"watchers_count":48,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":10,"forks":23,"open_issues":10,"watchers":48,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"ccbb1a25033054285975cde6cff777871cceef32","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":4434819,"name":"e-petitions","full_name":"alphagov/e-petitions","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/e-petitions","description":"This is the code base for the UK Government's e-petitions service (https://petition.parliament.uk)","fork":false,"url":"https://api.github.com/repos/alphagov/e-petitions","forks_url":"https://api.github.com/repos/alphagov/e-petitions/forks","keys_url":"https://api.github.com/repos/alphagov/e-petitions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/e-petitions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/e-petitions/teams","hooks_url":"https://api.github.com/repos/alphagov/e-petitions/hooks","issue_events_url":"https://api.github.com/repos/alphagov/e-petitions/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/e-petitions/events","assignees_url":"https://api.github.com/repos/alphagov/e-petitions/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/e-petitions/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/e-petitions/tags","blobs_url":"https://api.github.com/repos/alphagov/e-petitions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/e-petitions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/e-petitions/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/e-petitions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/e-petitions/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/e-petitions/languages","stargazers_url":"https://api.github.com/repos/alphagov/e-petitions/stargazers","contributors_url":"https://api.github.com/repos/alphagov/e-petitions/contributors","subscribers_url":"https://api.github.com/repos/alphagov/e-petitions/subscribers","subscription_url":"https://api.github.com/repos/alphagov/e-petitions/subscription","commits_url":"https://api.github.com/repos/alphagov/e-petitions/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/e-petitions/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/e-petitions/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/e-petitions/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/e-petitions/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/e-petitions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/e-petitions/merges","archive_url":"https://api.github.com/repos/alphagov/e-petitions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/e-petitions/downloads","issues_url":"https://api.github.com/repos/alphagov/e-petitions/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/e-petitions/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/e-petitions/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/e-petitions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/e-petitions/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/e-petitions/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/e-petitions/deployments","created_at":"2012-05-24T16:04:02Z","updated_at":"2016-05-24T14:19:18Z","pushed_at":"2016-05-27T07:24:12Z","git_url":"git://github.com/alphagov/e-petitions.git","ssh_url":"git@github.com:alphagov/e-petitions.git","clone_url":"https://github.com/alphagov/e-petitions.git","svn_url":"https://github.com/alphagov/e-petitions","homepage":"https://petition.parliament.uk","size":5832,"stargazers_count":48,"watchers_count":48,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":10,"forks":23,"open_issues":10,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/e-petitions/pulls/471"},"html":{"href":"https://github.com/alphagov/e-petitions/pull/471"},"issue":{"href":"https://api.github.com/repos/alphagov/e-petitions/issues/471"},"comments":{"href":"https://api.github.com/repos/alphagov/e-petitions/issues/471/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/e-petitions/pulls/471/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/e-petitions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/e-petitions/pulls/471/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/e-petitions/statuses/3e1f3a2a52e6b886921acce826091a27612ed558"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":13,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"pixeltrix"}}