{"action":"created","comment":{"url":"https://api.github.com/repos/apache/apex-malhar/pulls/comments/71096140","id":71096140,"diff_hunk":"@@ -0,0 +1,136 @@\n+package org.apache.apex.malhar.lib.window.impl;\n+\n+import java.util.List;\n+import java.util.Map;\n+\n+import javax.annotation.concurrent.Immutable;\n+import javax.validation.constraints.NotNull;\n+\n+import org.apache.apex.malhar.lib.state.spillable.SpillableByteArrayListMultimapImpl;\n+import org.apache.apex.malhar.lib.state.spillable.SpillableByteMapImpl;\n+import org.apache.apex.malhar.lib.state.spillable.managed.ManagedStateSpillableStateStore;\n+import org.apache.apex.malhar.lib.utils.serde.Serde;\n+import org.apache.apex.malhar.lib.window.Window;\n+import org.apache.apex.malhar.lib.window.WindowedStorage;\n+import org.apache.commons.lang3.tuple.ImmutablePair;\n+\n+import com.datatorrent.netlet.util.Slice;\n+\n+/**\n+ * Created by david on 7/15/16.\n+ */\n+public class SpillableWindowedKeyedStorage<K, V> implements WindowedStorage.WindowedKeyedStorage<K, V>\n+{\n+  @NotNull\n+  private final ManagedStateSpillableStateStore store;\n+\n+  protected final SpillableByteMapImpl<ImmutablePair<Window, K>, V> internValues;\n+  protected final SpillableByteArrayListMultimapImpl<Window, K> internKeys;","path":"library/src/main/java/org/apache/apex/malhar/lib/window/impl/SpillableWindowedKeyedStorage.java","position":28,"original_position":28,"commit_id":"37bca6bb5dee863e6cd8b1ce4574c89d80d38106","original_commit_id":"37bca6bb5dee863e6cd8b1ce4574c89d80d38106","user":{"login":"ilooner","id":8020165,"avatar_url":"https://avatars.githubusercontent.com/u/8020165?v=3","gravatar_id":"","url":"https://api.github.com/users/ilooner","html_url":"https://github.com/ilooner","followers_url":"https://api.github.com/users/ilooner/followers","following_url":"https://api.github.com/users/ilooner/following{/other_user}","gists_url":"https://api.github.com/users/ilooner/gists{/gist_id}","starred_url":"https://api.github.com/users/ilooner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilooner/subscriptions","organizations_url":"https://api.github.com/users/ilooner/orgs","repos_url":"https://api.github.com/users/ilooner/repos","events_url":"https://api.github.com/users/ilooner/events{/privacy}","received_events_url":"https://api.github.com/users/ilooner/received_events","type":"User","site_admin":false},"body":"This should be the SpillableByteArrayListMultimap interface","created_at":"2016-07-18T02:40:14Z","updated_at":"2016-07-18T02:40:14Z","html_url":"https://github.com/apache/apex-malhar/pull/345#discussion_r71096140","pull_request_url":"https://api.github.com/repos/apache/apex-malhar/pulls/345","_links":{"self":{"href":"https://api.github.com/repos/apache/apex-malhar/pulls/comments/71096140"},"html":{"href":"https://github.com/apache/apex-malhar/pull/345#discussion_r71096140"},"pull_request":{"href":"https://api.github.com/repos/apache/apex-malhar/pulls/345"}}},"pull_request":{"url":"https://api.github.com/repos/apache/apex-malhar/pulls/345","id":77653049,"html_url":"https://github.com/apache/apex-malhar/pull/345","diff_url":"https://github.com/apache/apex-malhar/pull/345.diff","patch_url":"https://github.com/apache/apex-malhar/pull/345.patch","issue_url":"https://api.github.com/repos/apache/apex-malhar/issues/345","number":345,"state":"open","locked":false,"title":"REVIEW ONLY (WindowedOperator): splitting WindowedStorage in preparation of incorporating Spillable data structures","user":{"login":"davidyan74","id":4419148,"avatar_url":"https://avatars.githubusercontent.com/u/4419148?v=3","gravatar_id":"","url":"https://api.github.com/users/davidyan74","html_url":"https://github.com/davidyan74","followers_url":"https://api.github.com/users/davidyan74/followers","following_url":"https://api.github.com/users/davidyan74/following{/other_user}","gists_url":"https://api.github.com/users/davidyan74/gists{/gist_id}","starred_url":"https://api.github.com/users/davidyan74/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidyan74/subscriptions","organizations_url":"https://api.github.com/users/davidyan74/orgs","repos_url":"https://api.github.com/users/davidyan74/repos","events_url":"https://api.github.com/users/davidyan74/events{/privacy}","received_events_url":"https://api.github.com/users/davidyan74/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-15T17:50:36Z","updated_at":"2016-07-18T02:40:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94a69302134afe46081aa1ad16e5437732e95b26","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/apex-malhar/pulls/345/commits","review_comments_url":"https://api.github.com/repos/apache/apex-malhar/pulls/345/comments","review_comment_url":"https://api.github.com/repos/apache/apex-malhar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/apex-malhar/issues/345/comments","statuses_url":"https://api.github.com/repos/apache/apex-malhar/statuses/37bca6bb5dee863e6cd8b1ce4574c89d80d38106","head":{"label":"davidyan74:windowedSpillable","ref":"windowedSpillable","sha":"37bca6bb5dee863e6cd8b1ce4574c89d80d38106","user":{"login":"davidyan74","id":4419148,"avatar_url":"https://avatars.githubusercontent.com/u/4419148?v=3","gravatar_id":"","url":"https://api.github.com/users/davidyan74","html_url":"https://github.com/davidyan74","followers_url":"https://api.github.com/users/davidyan74/followers","following_url":"https://api.github.com/users/davidyan74/following{/other_user}","gists_url":"https://api.github.com/users/davidyan74/gists{/gist_id}","starred_url":"https://api.github.com/users/davidyan74/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidyan74/subscriptions","organizations_url":"https://api.github.com/users/davidyan74/orgs","repos_url":"https://api.github.com/users/davidyan74/repos","events_url":"https://api.github.com/users/davidyan74/events{/privacy}","received_events_url":"https://api.github.com/users/davidyan74/received_events","type":"User","site_admin":false},"repo":{"id":41874937,"name":"apex-malhar","full_name":"davidyan74/apex-malhar","owner":{"login":"davidyan74","id":4419148,"avatar_url":"https://avatars.githubusercontent.com/u/4419148?v=3","gravatar_id":"","url":"https://api.github.com/users/davidyan74","html_url":"https://github.com/davidyan74","followers_url":"https://api.github.com/users/davidyan74/followers","following_url":"https://api.github.com/users/davidyan74/following{/other_user}","gists_url":"https://api.github.com/users/davidyan74/gists{/gist_id}","starred_url":"https://api.github.com/users/davidyan74/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidyan74/subscriptions","organizations_url":"https://api.github.com/users/davidyan74/orgs","repos_url":"https://api.github.com/users/davidyan74/repos","events_url":"https://api.github.com/users/davidyan74/events{/privacy}","received_events_url":"https://api.github.com/users/davidyan74/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidyan74/apex-malhar","description":"Mirror of Apache Apex malhar (Incubating)","fork":true,"url":"https://api.github.com/repos/davidyan74/apex-malhar","forks_url":"https://api.github.com/repos/davidyan74/apex-malhar/forks","keys_url":"https://api.github.com/repos/davidyan74/apex-malhar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidyan74/apex-malhar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidyan74/apex-malhar/teams","hooks_url":"https://api.github.com/repos/davidyan74/apex-malhar/hooks","issue_events_url":"https://api.github.com/repos/davidyan74/apex-malhar/issues/events{/number}","events_url":"https://api.github.com/repos/davidyan74/apex-malhar/events","assignees_url":"https://api.github.com/repos/davidyan74/apex-malhar/assignees{/user}","branches_url":"https://api.github.com/repos/davidyan74/apex-malhar/branches{/branch}","tags_url":"https://api.github.com/repos/davidyan74/apex-malhar/tags","blobs_url":"https://api.github.com/repos/davidyan74/apex-malhar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidyan74/apex-malhar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidyan74/apex-malhar/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidyan74/apex-malhar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidyan74/apex-malhar/statuses/{sha}","languages_url":"https://api.github.com/repos/davidyan74/apex-malhar/languages","stargazers_url":"https://api.github.com/repos/davidyan74/apex-malhar/stargazers","contributors_url":"https://api.github.com/repos/davidyan74/apex-malhar/contributors","subscribers_url":"https://api.github.com/repos/davidyan74/apex-malhar/subscribers","subscription_url":"https://api.github.com/repos/davidyan74/apex-malhar/subscription","commits_url":"https://api.github.com/repos/davidyan74/apex-malhar/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidyan74/apex-malhar/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidyan74/apex-malhar/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidyan74/apex-malhar/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidyan74/apex-malhar/contents/{+path}","compare_url":"https://api.github.com/repos/davidyan74/apex-malhar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidyan74/apex-malhar/merges","archive_url":"https://api.github.com/repos/davidyan74/apex-malhar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidyan74/apex-malhar/downloads","issues_url":"https://api.github.com/repos/davidyan74/apex-malhar/issues{/number}","pulls_url":"https://api.github.com/repos/davidyan74/apex-malhar/pulls{/number}","milestones_url":"https://api.github.com/repos/davidyan74/apex-malhar/milestones{/number}","notifications_url":"https://api.github.com/repos/davidyan74/apex-malhar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidyan74/apex-malhar/labels{/name}","releases_url":"https://api.github.com/repos/davidyan74/apex-malhar/releases{/id}","deployments_url":"https://api.github.com/repos/davidyan74/apex-malhar/deployments","created_at":"2015-09-03T17:51:54Z","updated_at":"2016-06-04T01:13:04Z","pushed_at":"2016-07-16T01:03:13Z","git_url":"git://github.com/davidyan74/apex-malhar.git","ssh_url":"git@github.com:davidyan74/apex-malhar.git","clone_url":"https://github.com/davidyan74/apex-malhar.git","svn_url":"https://github.com/davidyan74/apex-malhar","homepage":null,"size":86390,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"aaa4464f0bb03db4aca5f6efd9658c0a791d0b42","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":41348334,"name":"apex-malhar","full_name":"apache/apex-malhar","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/apex-malhar","description":"Mirror of Apache Apex malhar","fork":false,"url":"https://api.github.com/repos/apache/apex-malhar","forks_url":"https://api.github.com/repos/apache/apex-malhar/forks","keys_url":"https://api.github.com/repos/apache/apex-malhar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/apex-malhar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/apex-malhar/teams","hooks_url":"https://api.github.com/repos/apache/apex-malhar/hooks","issue_events_url":"https://api.github.com/repos/apache/apex-malhar/issues/events{/number}","events_url":"https://api.github.com/repos/apache/apex-malhar/events","assignees_url":"https://api.github.com/repos/apache/apex-malhar/assignees{/user}","branches_url":"https://api.github.com/repos/apache/apex-malhar/branches{/branch}","tags_url":"https://api.github.com/repos/apache/apex-malhar/tags","blobs_url":"https://api.github.com/repos/apache/apex-malhar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/apex-malhar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/apex-malhar/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/apex-malhar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/apex-malhar/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/apex-malhar/languages","stargazers_url":"https://api.github.com/repos/apache/apex-malhar/stargazers","contributors_url":"https://api.github.com/repos/apache/apex-malhar/contributors","subscribers_url":"https://api.github.com/repos/apache/apex-malhar/subscribers","subscription_url":"https://api.github.com/repos/apache/apex-malhar/subscription","commits_url":"https://api.github.com/repos/apache/apex-malhar/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/apex-malhar/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/apex-malhar/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/apex-malhar/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/apex-malhar/contents/{+path}","compare_url":"https://api.github.com/repos/apache/apex-malhar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/apex-malhar/merges","archive_url":"https://api.github.com/repos/apache/apex-malhar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/apex-malhar/downloads","issues_url":"https://api.github.com/repos/apache/apex-malhar/issues{/number}","pulls_url":"https://api.github.com/repos/apache/apex-malhar/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/apex-malhar/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/apex-malhar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/apex-malhar/labels{/name}","releases_url":"https://api.github.com/repos/apache/apex-malhar/releases{/id}","deployments_url":"https://api.github.com/repos/apache/apex-malhar/deployments","created_at":"2015-08-25T07:00:05Z","updated_at":"2016-07-17T13:08:16Z","pushed_at":"2016-07-18T02:05:17Z","git_url":"git://github.com/apache/apex-malhar.git","ssh_url":"git@github.com:apache/apex-malhar.git","clone_url":"https://github.com/apache/apex-malhar.git","svn_url":"https://github.com/apache/apex-malhar","homepage":"","size":96993,"stargazers_count":46,"watchers_count":46,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":89,"mirror_url":"git://git.apache.org/incubator-apex-malhar.git","open_issues_count":21,"forks":89,"open_issues":21,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/apex-malhar/pulls/345"},"html":{"href":"https://github.com/apache/apex-malhar/pull/345"},"issue":{"href":"https://api.github.com/repos/apache/apex-malhar/issues/345"},"comments":{"href":"https://api.github.com/repos/apache/apex-malhar/issues/345/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/apex-malhar/pulls/345/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/apex-malhar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/apex-malhar/pulls/345/commits"},"statuses":{"href":"https://api.github.com/repos/apache/apex-malhar/statuses/37bca6bb5dee863e6cd8b1ce4574c89d80d38106"}}}}
{"actor":{"display_login":"ilooner"}}