{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/86892001","pull_request_review_id":7527275,"id":86892001,"diff_hunk":"@@ -29,21 +28,31 @@ type Validator interface {\n \tValidate(SysSpec) error\n }\n \n-// validators are all the validators.\n-var validators = []Validator{\n-\t&OSValidator{},\n-\t&KernelValidator{},\n-\t&CgroupsValidator{},\n-\t&DockerValidator{},\n+// Reporter is the interface for the reporters for the validators.\n+type Reporter interface {\n+\t// Report reports the results of the system verification\n+\tReport(string, string, ValidationResultType) error\n }\n \n // Validate uses all validators to validate the system.\n-func Validate() error {\n+func Validate(spec SysSpec, report Reporter) error {\n \tvar errs []error\n-\tspec := DefaultSysSpec\n+\t// validators are all the validators.\n+\tvar validators = []Validator{\n+\t\t&OSValidator{Reporter: report},\n+\t\t&KernelValidator{Reporter: report},\n+\t\t&CgroupsValidator{Reporter: report},\n+\t\t&DockerValidator{Reporter: report},\n+\t}\n+\n \tfor _, v := range validators {\n-\t\tglog.Infof(\"Validating %s...\", v.Name())","path":"test/e2e_node/system/validators.go","position":38,"original_position":38,"commit_id":"44c9aeb744408e4ba6c2945edcf54e8843493f4a","original_commit_id":"44c9aeb744408e4ba6c2945edcf54e8843493f4a","user":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars.githubusercontent.com/u/5821883?v=3","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"body":"Why remove this? And same for above.","created_at":"2016-11-07T23:15:56Z","updated_at":"2016-11-07T23:15:56Z","html_url":"https://github.com/kubernetes/kubernetes/pull/36334#discussion_r86892001","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/36334","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/86892001"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/36334#discussion_r86892001"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/36334"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/36334","id":92516860,"html_url":"https://github.com/kubernetes/kubernetes/pull/36334","diff_url":"https://github.com/kubernetes/kubernetes/pull/36334.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/36334.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/36334","number":36334,"state":"open","locked":false,"title":"Add the system verification test to the kubeadm preflight checks","user":{"login":"luxas","id":5442475,"avatar_url":"https://avatars.githubusercontent.com/u/5442475?v=3","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},"body":"And refactor the system verification test to accept to write to a specific writer in order to customize the output\r\n\r\nThis PR is targeting v1.5, PTAL\r\ncc @Random-Liu @dchen1107 @kubernetes/sig-cluster-lifecycle\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/36334)\n<!-- Reviewable:end -->\n","created_at":"2016-11-07T02:53:34Z","updated_at":"2016-11-07T23:22:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adce7037e3b66276be3d842949c705f9a695dfa9","assignee":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars.githubusercontent.com/u/5821883?v=3","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"assignees":[{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars.githubusercontent.com/u/5821883?v=3","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/23","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.5","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/23/labels","id":1945978,"number":23,"title":"v1.5","description":"","creator":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"open_issues":263,"closed_issues":427,"state":"open","created_at":"2016-08-16T21:47:28Z","updated_at":"2016-11-07T22:27:57Z","due_on":"2016-12-09T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/36334/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/36334/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/36334/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/44c9aeb744408e4ba6c2945edcf54e8843493f4a","head":{"label":"luxas:add_preflight","ref":"add_preflight","sha":"44c9aeb744408e4ba6c2945edcf54e8843493f4a","user":{"login":"luxas","id":5442475,"avatar_url":"https://avatars.githubusercontent.com/u/5442475?v=3","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},"repo":{"id":37801743,"name":"kubernetes","full_name":"luxas/kubernetes","owner":{"login":"luxas","id":5442475,"avatar_url":"https://avatars.githubusercontent.com/u/5442475?v=3","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luxas/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/luxas/kubernetes","forks_url":"https://api.github.com/repos/luxas/kubernetes/forks","keys_url":"https://api.github.com/repos/luxas/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luxas/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luxas/kubernetes/teams","hooks_url":"https://api.github.com/repos/luxas/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/luxas/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/luxas/kubernetes/events","assignees_url":"https://api.github.com/repos/luxas/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/luxas/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/luxas/kubernetes/tags","blobs_url":"https://api.github.com/repos/luxas/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luxas/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luxas/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/luxas/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luxas/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/luxas/kubernetes/languages","stargazers_url":"https://api.github.com/repos/luxas/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/luxas/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/luxas/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/luxas/kubernetes/subscription","commits_url":"https://api.github.com/repos/luxas/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/luxas/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/luxas/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/luxas/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/luxas/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/luxas/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luxas/kubernetes/merges","archive_url":"https://api.github.com/repos/luxas/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luxas/kubernetes/downloads","issues_url":"https://api.github.com/repos/luxas/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/luxas/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/luxas/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/luxas/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luxas/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/luxas/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/luxas/kubernetes/deployments","created_at":"2015-06-21T08:14:15Z","updated_at":"2016-01-11T14:11:00Z","pushed_at":"2016-11-07T21:46:13Z","git_url":"git://github.com/luxas/kubernetes.git","ssh_url":"git@github.com:luxas/kubernetes.git","clone_url":"https://github.com/luxas/kubernetes.git","svn_url":"https://github.com/luxas/kubernetes","homepage":"http://kubernetes.io","size":345795,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"356230f8a1249568b4b707de81f94af3c1597c92","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-11-07T22:45:02Z","pushed_at":"2016-11-07T23:15:36Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":625694,"stargazers_count":18238,"watchers_count":18238,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5967,"mirror_url":null,"open_issues_count":5231,"forks":5967,"open_issues":5231,"watchers":18238,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/36334"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/36334"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/36334"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/36334/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/36334/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/36334/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/44c9aeb744408e4ba6c2945edcf54e8843493f4a"}}}}
{"actor":{"display_login":"Random-Liu"}}