{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/69453298","id":69453298,"diff_hunk":"@@ -417,18 +401,13 @@ func filterFunction(key string, keyFunc func(runtime.Object) (string, error), fi\n \n // Returns resource version to which the underlying cache is synced.\n func (c *Cacher) LastSyncResourceVersion() (uint64, error) {\n-\t// To avoid situation when LastSyncResourceVersion is processed before the\n-\t// underlying watchCache is propagated, we acquire 'usable' lock.\n-\tc.usable.RLock()\n-\tdefer c.usable.RUnlock()\n-\n-\tc.RLock()","path":"pkg/storage/cacher.go","position":92,"original_position":92,"commit_id":"5d6b423585362dd13620036bc44e1f3a1baec730","original_commit_id":"5d6b423585362dd13620036bc44e1f3a1baec730","user":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"body":"Why do you remove this one? It seems like a bug for me.","created_at":"2016-07-04T12:51:09Z","updated_at":"2016-07-04T12:51:09Z","html_url":"https://github.com/kubernetes/kubernetes/pull/26860#discussion_r69453298","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26860","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/69453298"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/26860#discussion_r69453298"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26860"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26860","id":72631807,"html_url":"https://github.com/kubernetes/kubernetes/pull/26860","diff_url":"https://github.com/kubernetes/kubernetes/pull/26860.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/26860.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26860","number":26860,"state":"open","locked":false,"title":"cacher: replace usable lock with conditional variable","user":{"login":"xiang90","id":4479947,"avatar_url":"https://avatars.githubusercontent.com/u/4479947?v=3","gravatar_id":"","url":"https://api.github.com/users/xiang90","html_url":"https://github.com/xiang90","followers_url":"https://api.github.com/users/xiang90/followers","following_url":"https://api.github.com/users/xiang90/following{/other_user}","gists_url":"https://api.github.com/users/xiang90/gists{/gist_id}","starred_url":"https://api.github.com/users/xiang90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiang90/subscriptions","organizations_url":"https://api.github.com/users/xiang90/orgs","repos_url":"https://api.github.com/users/xiang90/repos","events_url":"https://api.github.com/users/xiang90/events{/privacy}","received_events_url":"https://api.github.com/users/xiang90/received_events","type":"User","site_admin":false},"body":"Perviously we use a rwlock to indicate the ready information of the cacher. I feel it is not straightforward. Also it requires a few comments to explain. The pull request tries to replace the lock with a conditional variable for readability reason.\r\n\r\n/cc @lavalamp @wojtek-t   ","created_at":"2016-06-05T15:11:58Z","updated_at":"2016-07-04T12:51:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e760987fb6e47ee83777991a6023d2083fed00f6","assignee":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"assignees":[{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/22","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.4","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/22/labels","id":1777384,"number":22,"title":"v1.4","description":"","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":79,"closed_issues":16,"state":"open","created_at":"2016-05-19T18:50:19Z","updated_at":"2016-07-03T05:31:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26860/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26860/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26860/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/5d6b423585362dd13620036bc44e1f3a1baec730","head":{"label":"xiang90:cvar","ref":"cvar","sha":"5d6b423585362dd13620036bc44e1f3a1baec730","user":{"login":"xiang90","id":4479947,"avatar_url":"https://avatars.githubusercontent.com/u/4479947?v=3","gravatar_id":"","url":"https://api.github.com/users/xiang90","html_url":"https://github.com/xiang90","followers_url":"https://api.github.com/users/xiang90/followers","following_url":"https://api.github.com/users/xiang90/following{/other_user}","gists_url":"https://api.github.com/users/xiang90/gists{/gist_id}","starred_url":"https://api.github.com/users/xiang90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiang90/subscriptions","organizations_url":"https://api.github.com/users/xiang90/orgs","repos_url":"https://api.github.com/users/xiang90/repos","events_url":"https://api.github.com/users/xiang90/events{/privacy}","received_events_url":"https://api.github.com/users/xiang90/received_events","type":"User","site_admin":false},"repo":{"id":44561231,"name":"kubernetes","full_name":"xiang90/kubernetes","owner":{"login":"xiang90","id":4479947,"avatar_url":"https://avatars.githubusercontent.com/u/4479947?v=3","gravatar_id":"","url":"https://api.github.com/users/xiang90","html_url":"https://github.com/xiang90","followers_url":"https://api.github.com/users/xiang90/followers","following_url":"https://api.github.com/users/xiang90/following{/other_user}","gists_url":"https://api.github.com/users/xiang90/gists{/gist_id}","starred_url":"https://api.github.com/users/xiang90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiang90/subscriptions","organizations_url":"https://api.github.com/users/xiang90/orgs","repos_url":"https://api.github.com/users/xiang90/repos","events_url":"https://api.github.com/users/xiang90/events{/privacy}","received_events_url":"https://api.github.com/users/xiang90/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xiang90/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/xiang90/kubernetes","forks_url":"https://api.github.com/repos/xiang90/kubernetes/forks","keys_url":"https://api.github.com/repos/xiang90/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiang90/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiang90/kubernetes/teams","hooks_url":"https://api.github.com/repos/xiang90/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/xiang90/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/xiang90/kubernetes/events","assignees_url":"https://api.github.com/repos/xiang90/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/xiang90/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/xiang90/kubernetes/tags","blobs_url":"https://api.github.com/repos/xiang90/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiang90/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiang90/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiang90/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiang90/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/xiang90/kubernetes/languages","stargazers_url":"https://api.github.com/repos/xiang90/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/xiang90/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/xiang90/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/xiang90/kubernetes/subscription","commits_url":"https://api.github.com/repos/xiang90/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiang90/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiang90/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiang90/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiang90/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/xiang90/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiang90/kubernetes/merges","archive_url":"https://api.github.com/repos/xiang90/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiang90/kubernetes/downloads","issues_url":"https://api.github.com/repos/xiang90/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/xiang90/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/xiang90/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/xiang90/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiang90/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/xiang90/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/xiang90/kubernetes/deployments","created_at":"2015-10-19T20:13:19Z","updated_at":"2015-10-19T20:13:37Z","pushed_at":"2016-06-27T20:58:22Z","git_url":"git://github.com/xiang90/kubernetes.git","ssh_url":"git@github.com:xiang90/kubernetes.git","clone_url":"https://github.com/xiang90/kubernetes.git","svn_url":"https://github.com/xiang90/kubernetes","homepage":"http://kubernetes.io","size":269150,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"56af9acd6f0a36f974fe8a9d0bd06049b14d5d19","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-07-04T11:38:09Z","pushed_at":"2016-07-04T12:21:18Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":486674,"stargazers_count":15287,"watchers_count":15287,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4769,"mirror_url":null,"open_issues_count":3820,"forks":4769,"open_issues":3820,"watchers":15287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26860"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/26860"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/26860"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/26860/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26860/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26860/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/5d6b423585362dd13620036bc44e1f3a1baec730"}}}}
{"actor":{"display_login":"wojtek-t"}}