{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/16146","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/16146/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/16146/comments","events_url":"https://api.github.com/repos/apache/spark/issues/16146/events","html_url":"https://github.com/apache/spark/pull/16146","id":193498756,"number":16146,"title":"[SPARK-18091] [SQL] [BACKPORT-1.6] Deep if expressions cause Generated SpecificUnsafeProjection code to exceed JVM code size limit","user":{"login":"kapilsingh5050","id":15405233,"avatar_url":"https://avatars.githubusercontent.com/u/15405233?v=3","gravatar_id":"","url":"https://api.github.com/users/kapilsingh5050","html_url":"https://github.com/kapilsingh5050","followers_url":"https://api.github.com/users/kapilsingh5050/followers","following_url":"https://api.github.com/users/kapilsingh5050/following{/other_user}","gists_url":"https://api.github.com/users/kapilsingh5050/gists{/gist_id}","starred_url":"https://api.github.com/users/kapilsingh5050/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapilsingh5050/subscriptions","organizations_url":"https://api.github.com/users/kapilsingh5050/orgs","repos_url":"https://api.github.com/users/kapilsingh5050/repos","events_url":"https://api.github.com/users/kapilsingh5050/events{/privacy}","received_events_url":"https://api.github.com/users/kapilsingh5050/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-12-05T13:40:26Z","updated_at":"2016-12-12T13:05:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/16146","html_url":"https://github.com/apache/spark/pull/16146","diff_url":"https://github.com/apache/spark/pull/16146.diff","patch_url":"https://github.com/apache/spark/pull/16146.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nFix for SPARK-18091 which is a bug related to large if expressions causing generated SpecificUnsafeProjection code to exceed JVM code size limit.\r\n\r\nThis PR changes if expression's code generation to place its predicate, true value and false value expressions' generated code in separate methods in context so as to never generate too long combined code.\r\n\r\n## How was this patch tested?\r\n\r\nAdded a unit test and also tested manually with the application (having transformations similar to the unit test) which caused the issue to be identified in the first place."},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/266426307","html_url":"https://github.com/apache/spark/pull/16146#issuecomment-266426307","issue_url":"https://api.github.com/repos/apache/spark/issues/16146","id":266426307,"user":{"login":"SparkQA","id":8108735,"avatar_url":"https://avatars.githubusercontent.com/u/8108735?v=3","gravatar_id":"","url":"https://api.github.com/users/SparkQA","html_url":"https://github.com/SparkQA","followers_url":"https://api.github.com/users/SparkQA/followers","following_url":"https://api.github.com/users/SparkQA/following{/other_user}","gists_url":"https://api.github.com/users/SparkQA/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkQA/subscriptions","organizations_url":"https://api.github.com/users/SparkQA/orgs","repos_url":"https://api.github.com/users/SparkQA/repos","events_url":"https://api.github.com/users/SparkQA/events{/privacy}","received_events_url":"https://api.github.com/users/SparkQA/received_events","type":"User","site_admin":false},"created_at":"2016-12-12T13:05:19Z","updated_at":"2016-12-12T13:05:19Z","body":"**[Test build #70015 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70015/consoleFull)** for PR 16146 at commit [`73f1231`](https://github.com/apache/spark/commit/73f1231a37ccf9ec9be338072803a71bfff41726).\n * This patch **fails Spark unit tests**.\n * This patch merges cleanly.\n * This patch adds no public classes."}}
{"actor":{"display_login":"SparkQA"}}