{"action":"opened","issue":{"url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/5","labels_url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/5/comments","events_url":"https://api.github.com/repos/AtheMathmo/rusty-machine/issues/5/events","html_url":"https://github.com/AtheMathmo/rusty-machine/issues/5","id":127369059,"number":5,"title":"Improvements to linear regression","user":{"login":"AtheMathmo","id":10150986,"avatar_url":"https://avatars.githubusercontent.com/u/10150986?v=3","gravatar_id":"","url":"https://api.github.com/users/AtheMathmo","html_url":"https://github.com/AtheMathmo","followers_url":"https://api.github.com/users/AtheMathmo/followers","following_url":"https://api.github.com/users/AtheMathmo/following{/other_user}","gists_url":"https://api.github.com/users/AtheMathmo/gists{/gist_id}","starred_url":"https://api.github.com/users/AtheMathmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtheMathmo/subscriptions","organizations_url":"https://api.github.com/users/AtheMathmo/orgs","repos_url":"https://api.github.com/users/AtheMathmo/repos","events_url":"https://api.github.com/users/AtheMathmo/events{/privacy}","received_events_url":"https://api.github.com/users/AtheMathmo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-01-19T05:27:21Z","updated_at":"2016-01-19T05:27:21Z","closed_at":null,"body":"The linear regression model is currently incomplete and untidy. The following changes are required:\r\n\r\n- The LinRegressor field `b` is poorly named. Should be renamed to `parameters`. (Other suggestions welcome). This field should also be made private.\r\n- Need to include intercept term. This means adding a new row of ones to the input data, and an additional parameter. For now we will do this by default.\r\n- Need to implement the `Optimization` trait. Should also provide a method for optimized learning - `train_with_optimization` ?\r\n\r\nThe linear regression model will see reworking in the future as we implement regularization (ridge regression) and model optimization (lasso, forward/back selection, etc.). These things are currently unmapped but the above changes will be needed regardless.\r\n\r\nPlease comment if you see other things which should be changed. LinRegressor was the first machine learning algorithm implemented in this library and so undoubtedly could use some work!"}}