{"action":"opened","number":1031,"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/1031","id":99041294,"html_url":"https://github.com/grpc/grpc-go/pull/1031","diff_url":"https://github.com/grpc/grpc-go/pull/1031.diff","patch_url":"https://github.com/grpc/grpc-go/pull/1031.patch","issue_url":"https://api.github.com/repos/grpc/grpc-go/issues/1031","number":1031,"state":"open","locked":false,"title":"Remove defer in recv msg reader","user":{"login":"apolcyn","id":9566254,"avatar_url":"https://avatars.githubusercontent.com/u/9566254?v=3","gravatar_id":"","url":"https://api.github.com/users/apolcyn","html_url":"https://github.com/apolcyn","followers_url":"https://api.github.com/users/apolcyn/followers","following_url":"https://api.github.com/users/apolcyn/following{/other_user}","gists_url":"https://api.github.com/users/apolcyn/gists{/gist_id}","starred_url":"https://api.github.com/users/apolcyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apolcyn/subscriptions","organizations_url":"https://api.github.com/users/apolcyn/orgs","repos_url":"https://api.github.com/users/apolcyn/repos","events_url":"https://api.github.com/users/apolcyn/events{/privacy}","received_events_url":"https://api.github.com/users/apolcyn/received_events","type":"User","site_admin":false},"body":"based on https://github.com/grpc/grpc-go/pull/940 \r\n\r\nthis is also a minor improvement that seems visible on top of everything in #1029. \r\n\r\nappears to make ~5% further improvement on the protobuf streaming QPS test. (seeing QPS increase from ~840K to ~880K).\r\n\r\nThere's not seeing a dramatic change in the profile (multiple defers elsewhere), but the the cum cpu clock in `runtime.defferreturn` gets reduced from about ~4.5-5% to ~3.5-4%\r\n\r\nseems easy to remove this in the `recvBuffer.read` since there's no locking involved.\r\n\r\n","created_at":"2016-12-22T02:59:55Z","updated_at":"2016-12-22T02:59:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"iamqizhao","id":10121772,"avatar_url":"https://avatars.githubusercontent.com/u/10121772?v=3","gravatar_id":"","url":"https://api.github.com/users/iamqizhao","html_url":"https://github.com/iamqizhao","followers_url":"https://api.github.com/users/iamqizhao/followers","following_url":"https://api.github.com/users/iamqizhao/following{/other_user}","gists_url":"https://api.github.com/users/iamqizhao/gists{/gist_id}","starred_url":"https://api.github.com/users/iamqizhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamqizhao/subscriptions","organizations_url":"https://api.github.com/users/iamqizhao/orgs","repos_url":"https://api.github.com/users/iamqizhao/repos","events_url":"https://api.github.com/users/iamqizhao/events{/privacy}","received_events_url":"https://api.github.com/users/iamqizhao/received_events","type":"User","site_admin":false},"assignees":[{"login":"iamqizhao","id":10121772,"avatar_url":"https://avatars.githubusercontent.com/u/10121772?v=3","gravatar_id":"","url":"https://api.github.com/users/iamqizhao","html_url":"https://github.com/iamqizhao","followers_url":"https://api.github.com/users/iamqizhao/followers","following_url":"https://api.github.com/users/iamqizhao/following{/other_user}","gists_url":"https://api.github.com/users/iamqizhao/gists{/gist_id}","starred_url":"https://api.github.com/users/iamqizhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamqizhao/subscriptions","organizations_url":"https://api.github.com/users/iamqizhao/orgs","repos_url":"https://api.github.com/users/iamqizhao/repos","events_url":"https://api.github.com/users/iamqizhao/events{/privacy}","received_events_url":"https://api.github.com/users/iamqizhao/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-go/pulls/1031/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-go/pulls/1031/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-go/issues/1031/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/7308de8fcc748041b0c5c1a8e6a46fdf0f5e650f","head":{"label":"apolcyn:remove_defer_in_recv_msg_reader","ref":"remove_defer_in_recv_msg_reader","sha":"7308de8fcc748041b0c5c1a8e6a46fdf0f5e650f","user":{"login":"apolcyn","id":9566254,"avatar_url":"https://avatars.githubusercontent.com/u/9566254?v=3","gravatar_id":"","url":"https://api.github.com/users/apolcyn","html_url":"https://github.com/apolcyn","followers_url":"https://api.github.com/users/apolcyn/followers","following_url":"https://api.github.com/users/apolcyn/following{/other_user}","gists_url":"https://api.github.com/users/apolcyn/gists{/gist_id}","starred_url":"https://api.github.com/users/apolcyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apolcyn/subscriptions","organizations_url":"https://api.github.com/users/apolcyn/orgs","repos_url":"https://api.github.com/users/apolcyn/repos","events_url":"https://api.github.com/users/apolcyn/events{/privacy}","received_events_url":"https://api.github.com/users/apolcyn/received_events","type":"User","site_admin":false},"repo":{"id":68761767,"name":"grpc-go","full_name":"apolcyn/grpc-go","owner":{"login":"apolcyn","id":9566254,"avatar_url":"https://avatars.githubusercontent.com/u/9566254?v=3","gravatar_id":"","url":"https://api.github.com/users/apolcyn","html_url":"https://github.com/apolcyn","followers_url":"https://api.github.com/users/apolcyn/followers","following_url":"https://api.github.com/users/apolcyn/following{/other_user}","gists_url":"https://api.github.com/users/apolcyn/gists{/gist_id}","starred_url":"https://api.github.com/users/apolcyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apolcyn/subscriptions","organizations_url":"https://api.github.com/users/apolcyn/orgs","repos_url":"https://api.github.com/users/apolcyn/repos","events_url":"https://api.github.com/users/apolcyn/events{/privacy}","received_events_url":"https://api.github.com/users/apolcyn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apolcyn/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/apolcyn/grpc-go","forks_url":"https://api.github.com/repos/apolcyn/grpc-go/forks","keys_url":"https://api.github.com/repos/apolcyn/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apolcyn/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apolcyn/grpc-go/teams","hooks_url":"https://api.github.com/repos/apolcyn/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/apolcyn/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/apolcyn/grpc-go/events","assignees_url":"https://api.github.com/repos/apolcyn/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/apolcyn/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/apolcyn/grpc-go/tags","blobs_url":"https://api.github.com/repos/apolcyn/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apolcyn/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apolcyn/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/apolcyn/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apolcyn/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/apolcyn/grpc-go/languages","stargazers_url":"https://api.github.com/repos/apolcyn/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/apolcyn/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/apolcyn/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/apolcyn/grpc-go/subscription","commits_url":"https://api.github.com/repos/apolcyn/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/apolcyn/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/apolcyn/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/apolcyn/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/apolcyn/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/apolcyn/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apolcyn/grpc-go/merges","archive_url":"https://api.github.com/repos/apolcyn/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apolcyn/grpc-go/downloads","issues_url":"https://api.github.com/repos/apolcyn/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/apolcyn/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/apolcyn/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/apolcyn/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apolcyn/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/apolcyn/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/apolcyn/grpc-go/deployments","created_at":"2016-09-20T23:36:38Z","updated_at":"2016-09-20T23:36:41Z","pushed_at":"2016-12-22T02:24:41Z","git_url":"git://github.com/apolcyn/grpc-go.git","ssh_url":"git@github.com:apolcyn/grpc-go.git","clone_url":"https://github.com/apolcyn/grpc-go.git","svn_url":"https://github.com/apolcyn/grpc-go","homepage":"","size":2906,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"9d682f9293b408c42d17c587d0e2a31237ac3f10","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729907,"name":"grpc-go","full_name":"grpc/grpc-go","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-go","forks_url":"https://api.github.com/repos/grpc/grpc-go/forks","keys_url":"https://api.github.com/repos/grpc/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-go/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-go/events","assignees_url":"https://api.github.com/repos/grpc/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-go/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-go/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-go/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-go/merges","archive_url":"https://api.github.com/repos/grpc/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-go/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-go/deployments","created_at":"2014-12-08T18:59:34Z","updated_at":"2016-12-22T02:32:56Z","pushed_at":"2016-12-22T01:52:02Z","git_url":"git://github.com/grpc/grpc-go.git","ssh_url":"git@github.com:grpc/grpc-go.git","clone_url":"https://github.com/grpc/grpc-go.git","svn_url":"https://github.com/grpc/grpc-go","homepage":"","size":2652,"stargazers_count":2657,"watchers_count":2657,"language":"Go","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":448,"mirror_url":null,"open_issues_count":125,"forks":448,"open_issues":125,"watchers":2657,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1031"},"html":{"href":"https://github.com/grpc/grpc-go/pull/1031"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/1031"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/1031/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1031/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1031/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-go/statuses/7308de8fcc748041b0c5c1a8e6a46fdf0f5e650f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":14,"deletions":10,"changed_files":1}}
{"actor":{"display_login":"apolcyn"}}