{"action":"created","comment":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/comments/74668155","id":74668155,"diff_hunk":"@@ -69,6 +69,45 @@ - (void)dealloc\n     SAFE_ARC_SUPER_DEALLOC();\n }\n \n+- (id)cacheObjectForKey:(id<NSCopying>)key\n+{\n+    id object = nil;\n+    @synchronized(self)","path":"ADAL/src/cache/ADTokenCache.m","position":7,"original_position":7,"commit_id":"b6eaaeb21a0913105280ce4cefac9b9486f161c1","original_commit_id":"4e709cee5680d52d34871e44cdd024203623a09e","user":{"login":"atdrendel","id":202402,"avatar_url":"https://avatars.githubusercontent.com/u/202402?v=3","gravatar_id":"","url":"https://api.github.com/users/atdrendel","html_url":"https://github.com/atdrendel","followers_url":"https://api.github.com/users/atdrendel/followers","following_url":"https://api.github.com/users/atdrendel/following{/other_user}","gists_url":"https://api.github.com/users/atdrendel/gists{/gist_id}","starred_url":"https://api.github.com/users/atdrendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atdrendel/subscriptions","organizations_url":"https://api.github.com/users/atdrendel/orgs","repos_url":"https://api.github.com/users/atdrendel/repos","events_url":"https://api.github.com/users/atdrendel/events{/privacy}","received_events_url":"https://api.github.com/users/atdrendel/received_events","type":"User","site_admin":false},"body":"Looks good. How long do pull requests usually take to get merged?","created_at":"2016-08-12T22:13:15Z","updated_at":"2016-08-12T22:13:15Z","html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/721#discussion_r74668155","pull_request_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/721","_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/comments/74668155"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/721#discussion_r74668155"},"pull_request":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/721"}}},"pull_request":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/721","id":81178957,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/721","diff_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/721.diff","patch_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/721.patch","issue_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/721","number":721,"state":"open","locked":false,"title":"Fix thread safety issues in -[ADTokenCache serialize]","user":{"login":"atdrendel","id":202402,"avatar_url":"https://avatars.githubusercontent.com/u/202402?v=3","gravatar_id":"","url":"https://api.github.com/users/atdrendel","html_url":"https://github.com/atdrendel","followers_url":"https://api.github.com/users/atdrendel/followers","following_url":"https://api.github.com/users/atdrendel/following{/other_user}","gists_url":"https://api.github.com/users/atdrendel/gists{/gist_id}","starred_url":"https://api.github.com/users/atdrendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atdrendel/subscriptions","organizations_url":"https://api.github.com/users/atdrendel/orgs","repos_url":"https://api.github.com/users/atdrendel/repos","events_url":"https://api.github.com/users/atdrendel/events{/privacy}","received_events_url":"https://api.github.com/users/atdrendel/received_events","type":"User","site_admin":false},"body":"ADTokenCache accesses its _cache instance variable, which is an NSMutableDictionary, in an unsafe manner. This pull request naively synchronizes all access to the _cache. See https://github.com/AzureAD/azure-activedirectory-library-for-objc/issues/710","created_at":"2016-08-12T20:31:42Z","updated_at":"2016-08-12T22:13:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e3c5d1cbe657b86f50c4f7b1021da4afacfa5e3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/721/commits","review_comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/721/comments","review_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/721/comments","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/statuses/b6eaaeb21a0913105280ce4cefac9b9486f161c1","head":{"label":"msftberlin:Anthony/SerializeCrash","ref":"Anthony/SerializeCrash","sha":"b6eaaeb21a0913105280ce4cefac9b9486f161c1","user":{"login":"msftberlin","id":16759061,"avatar_url":"https://avatars.githubusercontent.com/u/16759061?v=3","gravatar_id":"","url":"https://api.github.com/users/msftberlin","html_url":"https://github.com/msftberlin","followers_url":"https://api.github.com/users/msftberlin/followers","following_url":"https://api.github.com/users/msftberlin/following{/other_user}","gists_url":"https://api.github.com/users/msftberlin/gists{/gist_id}","starred_url":"https://api.github.com/users/msftberlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msftberlin/subscriptions","organizations_url":"https://api.github.com/users/msftberlin/orgs","repos_url":"https://api.github.com/users/msftberlin/repos","events_url":"https://api.github.com/users/msftberlin/events{/privacy}","received_events_url":"https://api.github.com/users/msftberlin/received_events","type":"Organization","site_admin":false},"repo":{"id":59106210,"name":"azure-activedirectory-library-for-objc","full_name":"msftberlin/azure-activedirectory-library-for-objc","owner":{"login":"msftberlin","id":16759061,"avatar_url":"https://avatars.githubusercontent.com/u/16759061?v=3","gravatar_id":"","url":"https://api.github.com/users/msftberlin","html_url":"https://github.com/msftberlin","followers_url":"https://api.github.com/users/msftberlin/followers","following_url":"https://api.github.com/users/msftberlin/following{/other_user}","gists_url":"https://api.github.com/users/msftberlin/gists{/gist_id}","starred_url":"https://api.github.com/users/msftberlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msftberlin/subscriptions","organizations_url":"https://api.github.com/users/msftberlin/orgs","repos_url":"https://api.github.com/users/msftberlin/repos","events_url":"https://api.github.com/users/msftberlin/events{/privacy}","received_events_url":"https://api.github.com/users/msftberlin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/msftberlin/azure-activedirectory-library-for-objc","description":"The ADAL SDK for Objective C gives you the ability to add support for Work Accounts to your iOS and OS X applications with just a few lines of additional code. This SDK gives your application the full functionality of Microsoft Azure AD, including industry standard protocol support for OAuth2, Web API integration with user level consent, and two factor authentication support.","fork":true,"url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc","forks_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/forks","keys_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/teams","hooks_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/hooks","issue_events_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/issues/events{/number}","events_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/events","assignees_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/assignees{/user}","branches_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/branches{/branch}","tags_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/tags","blobs_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/git/refs{/sha}","trees_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/statuses/{sha}","languages_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/languages","stargazers_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/stargazers","contributors_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/contributors","subscribers_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/subscribers","subscription_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/subscription","commits_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/commits{/sha}","git_commits_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/git/commits{/sha}","comments_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/comments{/number}","issue_comment_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/issues/comments{/number}","contents_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/contents/{+path}","compare_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/merges","archive_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/downloads","issues_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/issues{/number}","pulls_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/pulls{/number}","milestones_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/milestones{/number}","notifications_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/labels{/name}","releases_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/releases{/id}","deployments_url":"https://api.github.com/repos/msftberlin/azure-activedirectory-library-for-objc/deployments","created_at":"2016-05-18T10:34:35Z","updated_at":"2016-05-18T10:34:37Z","pushed_at":"2016-08-12T21:32:27Z","git_url":"git://github.com/msftberlin/azure-activedirectory-library-for-objc.git","ssh_url":"git@github.com:msftberlin/azure-activedirectory-library-for-objc.git","clone_url":"https://github.com/msftberlin/azure-activedirectory-library-for-objc.git","svn_url":"https://github.com/msftberlin/azure-activedirectory-library-for-objc","homepage":"","size":11755,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AzureAD:dev","ref":"dev","sha":"66b18ab6831dd2ec09d941ef66ab872a867325de","user":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":14703038,"name":"azure-activedirectory-library-for-objc","full_name":"AzureAD/azure-activedirectory-library-for-objc","owner":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc","description":"The ADAL SDK for Objective C gives you the ability to add support for Work Accounts to your iOS and OS X applications with just a few lines of additional code. This SDK gives your application the full functionality of Microsoft Azure AD, including industry standard protocol support for OAuth2, Web API integration with user level consent, and two factor authentication support.","fork":false,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc","forks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/forks","keys_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/teams","hooks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/events","assignees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/tags","blobs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/languages","stargazers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/subscription","commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/merges","archive_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/downloads","issues_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/deployments","created_at":"2013-11-26T00:46:00Z","updated_at":"2016-08-04T19:01:35Z","pushed_at":"2016-08-12T21:36:26Z","git_url":"git://github.com/AzureAD/azure-activedirectory-library-for-objc.git","ssh_url":"git@github.com:AzureAD/azure-activedirectory-library-for-objc.git","clone_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc.git","svn_url":"https://github.com/AzureAD/azure-activedirectory-library-for-objc","homepage":"","size":13989,"stargazers_count":87,"watchers_count":87,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":22,"forks":52,"open_issues":22,"watchers":87,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/721"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-objc/pull/721"},"issue":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/721"},"comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/issues/721/comments"},"review_comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/721/comments"},"review_comment":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/pulls/721/commits"},"statuses":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-objc/statuses/b6eaaeb21a0913105280ce4cefac9b9486f161c1"}}}}
{"actor":{"display_login":"atdrendel"}}