{"action":"closed","number":21,"pull_request":{"url":"https://api.github.com/repos/rohe/pyjwkest/pulls/21","id":33469556,"html_url":"https://github.com/rohe/pyjwkest/pull/21","diff_url":"https://github.com/rohe/pyjwkest/pull/21.diff","patch_url":"https://github.com/rohe/pyjwkest/pull/21.patch","issue_url":"https://api.github.com/repos/rohe/pyjwkest/issues/21","number":21,"state":"closed","locked":false,"title":"pass in keys from sign_json to sign_compact","user":{"login":"otakup0pe","id":254586,"avatar_url":"https://avatars.githubusercontent.com/u/254586?v=3","gravatar_id":"","url":"https://api.github.com/users/otakup0pe","html_url":"https://github.com/otakup0pe","followers_url":"https://api.github.com/users/otakup0pe/followers","following_url":"https://api.github.com/users/otakup0pe/following{/other_user}","gists_url":"https://api.github.com/users/otakup0pe/gists{/gist_id}","starred_url":"https://api.github.com/users/otakup0pe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otakup0pe/subscriptions","organizations_url":"https://api.github.com/users/otakup0pe/orgs","repos_url":"https://api.github.com/users/otakup0pe/repos","events_url":"https://api.github.com/users/otakup0pe/events{/privacy}","received_events_url":"https://api.github.com/users/otakup0pe/received_events","type":"User","site_admin":false},"body":"This seemed like the easiest way to handle this but perhaps the right choice is to reuse the jws object here https://github.com/rohe/pyjwkest/blob/master/src/jwkest/jws.py#L553 ?\n\nOn the surface it seems like this _should_ work without the change as as Line 552 the full `kwargs` is passed in but that was _not_ what I was seeing.\n","created_at":"2015-04-16T16:38:51Z","updated_at":"2016-11-24T18:00:26Z","closed_at":"2016-11-24T18:00:26Z","merged_at":null,"merge_commit_sha":"71500677a539e69e30e7c87e4702b50ab170cdd5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rohe/pyjwkest/pulls/21/commits","review_comments_url":"https://api.github.com/repos/rohe/pyjwkest/pulls/21/comments","review_comment_url":"https://api.github.com/repos/rohe/pyjwkest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rohe/pyjwkest/issues/21/comments","statuses_url":"https://api.github.com/repos/rohe/pyjwkest/statuses/d1598d1f7872b2954e6004450b22e8b4715b286f","head":{"label":"otakup0pe:master","ref":"master","sha":"d1598d1f7872b2954e6004450b22e8b4715b286f","user":{"login":"otakup0pe","id":254586,"avatar_url":"https://avatars.githubusercontent.com/u/254586?v=3","gravatar_id":"","url":"https://api.github.com/users/otakup0pe","html_url":"https://github.com/otakup0pe","followers_url":"https://api.github.com/users/otakup0pe/followers","following_url":"https://api.github.com/users/otakup0pe/following{/other_user}","gists_url":"https://api.github.com/users/otakup0pe/gists{/gist_id}","starred_url":"https://api.github.com/users/otakup0pe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otakup0pe/subscriptions","organizations_url":"https://api.github.com/users/otakup0pe/orgs","repos_url":"https://api.github.com/users/otakup0pe/repos","events_url":"https://api.github.com/users/otakup0pe/events{/privacy}","received_events_url":"https://api.github.com/users/otakup0pe/received_events","type":"User","site_admin":false},"repo":{"id":33707700,"name":"pyjwkest","full_name":"otakup0pe/pyjwkest","owner":{"login":"otakup0pe","id":254586,"avatar_url":"https://avatars.githubusercontent.com/u/254586?v=3","gravatar_id":"","url":"https://api.github.com/users/otakup0pe","html_url":"https://github.com/otakup0pe","followers_url":"https://api.github.com/users/otakup0pe/followers","following_url":"https://api.github.com/users/otakup0pe/following{/other_user}","gists_url":"https://api.github.com/users/otakup0pe/gists{/gist_id}","starred_url":"https://api.github.com/users/otakup0pe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otakup0pe/subscriptions","organizations_url":"https://api.github.com/users/otakup0pe/orgs","repos_url":"https://api.github.com/users/otakup0pe/repos","events_url":"https://api.github.com/users/otakup0pe/events{/privacy}","received_events_url":"https://api.github.com/users/otakup0pe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/otakup0pe/pyjwkest","description":"Implementation of JWT, JWS, JWE and JWK","fork":true,"url":"https://api.github.com/repos/otakup0pe/pyjwkest","forks_url":"https://api.github.com/repos/otakup0pe/pyjwkest/forks","keys_url":"https://api.github.com/repos/otakup0pe/pyjwkest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otakup0pe/pyjwkest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otakup0pe/pyjwkest/teams","hooks_url":"https://api.github.com/repos/otakup0pe/pyjwkest/hooks","issue_events_url":"https://api.github.com/repos/otakup0pe/pyjwkest/issues/events{/number}","events_url":"https://api.github.com/repos/otakup0pe/pyjwkest/events","assignees_url":"https://api.github.com/repos/otakup0pe/pyjwkest/assignees{/user}","branches_url":"https://api.github.com/repos/otakup0pe/pyjwkest/branches{/branch}","tags_url":"https://api.github.com/repos/otakup0pe/pyjwkest/tags","blobs_url":"https://api.github.com/repos/otakup0pe/pyjwkest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otakup0pe/pyjwkest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otakup0pe/pyjwkest/git/refs{/sha}","trees_url":"https://api.github.com/repos/otakup0pe/pyjwkest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otakup0pe/pyjwkest/statuses/{sha}","languages_url":"https://api.github.com/repos/otakup0pe/pyjwkest/languages","stargazers_url":"https://api.github.com/repos/otakup0pe/pyjwkest/stargazers","contributors_url":"https://api.github.com/repos/otakup0pe/pyjwkest/contributors","subscribers_url":"https://api.github.com/repos/otakup0pe/pyjwkest/subscribers","subscription_url":"https://api.github.com/repos/otakup0pe/pyjwkest/subscription","commits_url":"https://api.github.com/repos/otakup0pe/pyjwkest/commits{/sha}","git_commits_url":"https://api.github.com/repos/otakup0pe/pyjwkest/git/commits{/sha}","comments_url":"https://api.github.com/repos/otakup0pe/pyjwkest/comments{/number}","issue_comment_url":"https://api.github.com/repos/otakup0pe/pyjwkest/issues/comments{/number}","contents_url":"https://api.github.com/repos/otakup0pe/pyjwkest/contents/{+path}","compare_url":"https://api.github.com/repos/otakup0pe/pyjwkest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otakup0pe/pyjwkest/merges","archive_url":"https://api.github.com/repos/otakup0pe/pyjwkest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otakup0pe/pyjwkest/downloads","issues_url":"https://api.github.com/repos/otakup0pe/pyjwkest/issues{/number}","pulls_url":"https://api.github.com/repos/otakup0pe/pyjwkest/pulls{/number}","milestones_url":"https://api.github.com/repos/otakup0pe/pyjwkest/milestones{/number}","notifications_url":"https://api.github.com/repos/otakup0pe/pyjwkest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otakup0pe/pyjwkest/labels{/name}","releases_url":"https://api.github.com/repos/otakup0pe/pyjwkest/releases{/id}","deployments_url":"https://api.github.com/repos/otakup0pe/pyjwkest/deployments","created_at":"2015-04-10T04:07:46Z","updated_at":"2015-04-16T16:36:49Z","pushed_at":"2015-05-28T18:49:23Z","git_url":"git://github.com/otakup0pe/pyjwkest.git","ssh_url":"git@github.com:otakup0pe/pyjwkest.git","clone_url":"https://github.com/otakup0pe/pyjwkest.git","svn_url":"https://github.com/otakup0pe/pyjwkest","homepage":null,"size":2852,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rohe:master","ref":"master","sha":"8200a1844083ed4482cecad07cb2ba5856a8b682","user":{"login":"rohe","id":99900,"avatar_url":"https://avatars.githubusercontent.com/u/99900?v=3","gravatar_id":"","url":"https://api.github.com/users/rohe","html_url":"https://github.com/rohe","followers_url":"https://api.github.com/users/rohe/followers","following_url":"https://api.github.com/users/rohe/following{/other_user}","gists_url":"https://api.github.com/users/rohe/gists{/gist_id}","starred_url":"https://api.github.com/users/rohe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohe/subscriptions","organizations_url":"https://api.github.com/users/rohe/orgs","repos_url":"https://api.github.com/users/rohe/repos","events_url":"https://api.github.com/users/rohe/events{/privacy}","received_events_url":"https://api.github.com/users/rohe/received_events","type":"User","site_admin":false},"repo":{"id":6060959,"name":"pyjwkest","full_name":"rohe/pyjwkest","owner":{"login":"rohe","id":99900,"avatar_url":"https://avatars.githubusercontent.com/u/99900?v=3","gravatar_id":"","url":"https://api.github.com/users/rohe","html_url":"https://github.com/rohe","followers_url":"https://api.github.com/users/rohe/followers","following_url":"https://api.github.com/users/rohe/following{/other_user}","gists_url":"https://api.github.com/users/rohe/gists{/gist_id}","starred_url":"https://api.github.com/users/rohe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohe/subscriptions","organizations_url":"https://api.github.com/users/rohe/orgs","repos_url":"https://api.github.com/users/rohe/repos","events_url":"https://api.github.com/users/rohe/events{/privacy}","received_events_url":"https://api.github.com/users/rohe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rohe/pyjwkest","description":"Implementation of JWT, JWS, JWE and JWK","fork":false,"url":"https://api.github.com/repos/rohe/pyjwkest","forks_url":"https://api.github.com/repos/rohe/pyjwkest/forks","keys_url":"https://api.github.com/repos/rohe/pyjwkest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rohe/pyjwkest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rohe/pyjwkest/teams","hooks_url":"https://api.github.com/repos/rohe/pyjwkest/hooks","issue_events_url":"https://api.github.com/repos/rohe/pyjwkest/issues/events{/number}","events_url":"https://api.github.com/repos/rohe/pyjwkest/events","assignees_url":"https://api.github.com/repos/rohe/pyjwkest/assignees{/user}","branches_url":"https://api.github.com/repos/rohe/pyjwkest/branches{/branch}","tags_url":"https://api.github.com/repos/rohe/pyjwkest/tags","blobs_url":"https://api.github.com/repos/rohe/pyjwkest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rohe/pyjwkest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rohe/pyjwkest/git/refs{/sha}","trees_url":"https://api.github.com/repos/rohe/pyjwkest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rohe/pyjwkest/statuses/{sha}","languages_url":"https://api.github.com/repos/rohe/pyjwkest/languages","stargazers_url":"https://api.github.com/repos/rohe/pyjwkest/stargazers","contributors_url":"https://api.github.com/repos/rohe/pyjwkest/contributors","subscribers_url":"https://api.github.com/repos/rohe/pyjwkest/subscribers","subscription_url":"https://api.github.com/repos/rohe/pyjwkest/subscription","commits_url":"https://api.github.com/repos/rohe/pyjwkest/commits{/sha}","git_commits_url":"https://api.github.com/repos/rohe/pyjwkest/git/commits{/sha}","comments_url":"https://api.github.com/repos/rohe/pyjwkest/comments{/number}","issue_comment_url":"https://api.github.com/repos/rohe/pyjwkest/issues/comments{/number}","contents_url":"https://api.github.com/repos/rohe/pyjwkest/contents/{+path}","compare_url":"https://api.github.com/repos/rohe/pyjwkest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rohe/pyjwkest/merges","archive_url":"https://api.github.com/repos/rohe/pyjwkest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rohe/pyjwkest/downloads","issues_url":"https://api.github.com/repos/rohe/pyjwkest/issues{/number}","pulls_url":"https://api.github.com/repos/rohe/pyjwkest/pulls{/number}","milestones_url":"https://api.github.com/repos/rohe/pyjwkest/milestones{/number}","notifications_url":"https://api.github.com/repos/rohe/pyjwkest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rohe/pyjwkest/labels{/name}","releases_url":"https://api.github.com/repos/rohe/pyjwkest/releases{/id}","deployments_url":"https://api.github.com/repos/rohe/pyjwkest/deployments","created_at":"2012-10-03T14:07:48Z","updated_at":"2016-11-22T01:26:22Z","pushed_at":"2016-11-17T17:15:19Z","git_url":"git://github.com/rohe/pyjwkest.git","ssh_url":"git@github.com:rohe/pyjwkest.git","clone_url":"https://github.com/rohe/pyjwkest.git","svn_url":"https://github.com/rohe/pyjwkest","homepage":null,"size":3031,"stargazers_count":52,"watchers_count":52,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":16,"forks":34,"open_issues":16,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rohe/pyjwkest/pulls/21"},"html":{"href":"https://github.com/rohe/pyjwkest/pull/21"},"issue":{"href":"https://api.github.com/repos/rohe/pyjwkest/issues/21"},"comments":{"href":"https://api.github.com/repos/rohe/pyjwkest/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/rohe/pyjwkest/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/rohe/pyjwkest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rohe/pyjwkest/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/rohe/pyjwkest/statuses/d1598d1f7872b2954e6004450b22e8b4715b286f"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"commits":3,"additions":20,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"rohe"}}