{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/cargo/pulls/comments/65811663","id":65811663,"diff_hunk":"@@ -140,7 +140,7 @@ fn run_doc_tests(options: &TestOptions,\n                 arg.push(rust_dep);\n                 p.arg(\"-L\").arg(arg);\n             }\n-            for native_dep in compilation.native_dirs.values() {\n+            for native_dep in &compilation.native_dirs {","path":"src/cargo/ops/cargo_test.rs","position":5,"original_position":5,"commit_id":"1db502786f88595c391fd18ed5ab0adef0a30262","original_commit_id":"1db502786f88595c391fd18ed5ab0adef0a30262","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"I personally don't prefer this syntax, so could it stick with what it was before?","created_at":"2016-06-05T05:47:15Z","updated_at":"2016-06-05T05:47:15Z","html_url":"https://github.com/rust-lang/cargo/pull/2763#discussion_r65811663","pull_request_url":"https://api.github.com/repos/rust-lang/cargo/pulls/2763","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/comments/65811663"},"html":{"href":"https://github.com/rust-lang/cargo/pull/2763#discussion_r65811663"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/2763"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/cargo/pulls/2763","id":72396636,"html_url":"https://github.com/rust-lang/cargo/pull/2763","diff_url":"https://github.com/rust-lang/cargo/pull/2763.diff","patch_url":"https://github.com/rust-lang/cargo/pull/2763.patch","issue_url":"https://api.github.com/repos/rust-lang/cargo/issues/2763","number":2763,"state":"open","locked":false,"title":"Correctly record multiple native dirs per package","user":{"login":"mbrubeck","id":5920,"avatar_url":"https://avatars.githubusercontent.com/u/5920?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrubeck","html_url":"https://github.com/mbrubeck","followers_url":"https://api.github.com/users/mbrubeck/followers","following_url":"https://api.github.com/users/mbrubeck/following{/other_user}","gists_url":"https://api.github.com/users/mbrubeck/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrubeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrubeck/subscriptions","organizations_url":"https://api.github.com/users/mbrubeck/orgs","repos_url":"https://api.github.com/users/mbrubeck/repos","events_url":"https://api.github.com/users/mbrubeck/events{/privacy}","received_events_url":"https://api.github.com/users/mbrubeck/received_events","type":"User","site_admin":false},"body":"This fixes a bug when a package's build script outputs multiple library search\npaths.  Because Compilation::native_dirs is a `HashMap<PackageId, PathBuf>` it\ncan only store one path per package.  Currently if there are multiple paths,\nall but the last will be inserted and then overwritten.\n\nThe key from this map is never used anyway, so this fixes the bug by changing\nit from a HashMap to a HashSet.","created_at":"2016-06-02T18:42:07Z","updated_at":"2016-06-05T05:47:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"934b22fb56d67d0fe2510642d4fba359d47f9b8a","assignee":{"login":"wycats","id":4,"avatar_url":"https://avatars.githubusercontent.com/u/4?v=3","gravatar_id":"","url":"https://api.github.com/users/wycats","html_url":"https://github.com/wycats","followers_url":"https://api.github.com/users/wycats/followers","following_url":"https://api.github.com/users/wycats/following{/other_user}","gists_url":"https://api.github.com/users/wycats/gists{/gist_id}","starred_url":"https://api.github.com/users/wycats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wycats/subscriptions","organizations_url":"https://api.github.com/users/wycats/orgs","repos_url":"https://api.github.com/users/wycats/repos","events_url":"https://api.github.com/users/wycats/events{/privacy}","received_events_url":"https://api.github.com/users/wycats/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/cargo/pulls/2763/commits","review_comments_url":"https://api.github.com/repos/rust-lang/cargo/pulls/2763/comments","review_comment_url":"https://api.github.com/repos/rust-lang/cargo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/cargo/issues/2763/comments","statuses_url":"https://api.github.com/repos/rust-lang/cargo/statuses/1db502786f88595c391fd18ed5ab0adef0a30262","head":{"label":"mbrubeck:native-dirs","ref":"native-dirs","sha":"1db502786f88595c391fd18ed5ab0adef0a30262","user":{"login":"mbrubeck","id":5920,"avatar_url":"https://avatars.githubusercontent.com/u/5920?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrubeck","html_url":"https://github.com/mbrubeck","followers_url":"https://api.github.com/users/mbrubeck/followers","following_url":"https://api.github.com/users/mbrubeck/following{/other_user}","gists_url":"https://api.github.com/users/mbrubeck/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrubeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrubeck/subscriptions","organizations_url":"https://api.github.com/users/mbrubeck/orgs","repos_url":"https://api.github.com/users/mbrubeck/repos","events_url":"https://api.github.com/users/mbrubeck/events{/privacy}","received_events_url":"https://api.github.com/users/mbrubeck/received_events","type":"User","site_admin":false},"repo":{"id":23894398,"name":"cargo","full_name":"mbrubeck/cargo","owner":{"login":"mbrubeck","id":5920,"avatar_url":"https://avatars.githubusercontent.com/u/5920?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrubeck","html_url":"https://github.com/mbrubeck","followers_url":"https://api.github.com/users/mbrubeck/followers","following_url":"https://api.github.com/users/mbrubeck/following{/other_user}","gists_url":"https://api.github.com/users/mbrubeck/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrubeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrubeck/subscriptions","organizations_url":"https://api.github.com/users/mbrubeck/orgs","repos_url":"https://api.github.com/users/mbrubeck/repos","events_url":"https://api.github.com/users/mbrubeck/events{/privacy}","received_events_url":"https://api.github.com/users/mbrubeck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbrubeck/cargo","description":"The Rust package manager","fork":true,"url":"https://api.github.com/repos/mbrubeck/cargo","forks_url":"https://api.github.com/repos/mbrubeck/cargo/forks","keys_url":"https://api.github.com/repos/mbrubeck/cargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbrubeck/cargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbrubeck/cargo/teams","hooks_url":"https://api.github.com/repos/mbrubeck/cargo/hooks","issue_events_url":"https://api.github.com/repos/mbrubeck/cargo/issues/events{/number}","events_url":"https://api.github.com/repos/mbrubeck/cargo/events","assignees_url":"https://api.github.com/repos/mbrubeck/cargo/assignees{/user}","branches_url":"https://api.github.com/repos/mbrubeck/cargo/branches{/branch}","tags_url":"https://api.github.com/repos/mbrubeck/cargo/tags","blobs_url":"https://api.github.com/repos/mbrubeck/cargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbrubeck/cargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbrubeck/cargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbrubeck/cargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbrubeck/cargo/statuses/{sha}","languages_url":"https://api.github.com/repos/mbrubeck/cargo/languages","stargazers_url":"https://api.github.com/repos/mbrubeck/cargo/stargazers","contributors_url":"https://api.github.com/repos/mbrubeck/cargo/contributors","subscribers_url":"https://api.github.com/repos/mbrubeck/cargo/subscribers","subscription_url":"https://api.github.com/repos/mbrubeck/cargo/subscription","commits_url":"https://api.github.com/repos/mbrubeck/cargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbrubeck/cargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbrubeck/cargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbrubeck/cargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbrubeck/cargo/contents/{+path}","compare_url":"https://api.github.com/repos/mbrubeck/cargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbrubeck/cargo/merges","archive_url":"https://api.github.com/repos/mbrubeck/cargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbrubeck/cargo/downloads","issues_url":"https://api.github.com/repos/mbrubeck/cargo/issues{/number}","pulls_url":"https://api.github.com/repos/mbrubeck/cargo/pulls{/number}","milestones_url":"https://api.github.com/repos/mbrubeck/cargo/milestones{/number}","notifications_url":"https://api.github.com/repos/mbrubeck/cargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbrubeck/cargo/labels{/name}","releases_url":"https://api.github.com/repos/mbrubeck/cargo/releases{/id}","deployments_url":"https://api.github.com/repos/mbrubeck/cargo/deployments","created_at":"2014-09-10T22:13:22Z","updated_at":"2016-04-26T17:44:01Z","pushed_at":"2016-06-02T20:57:18Z","git_url":"git://github.com/mbrubeck/cargo.git","ssh_url":"git@github.com:mbrubeck/cargo.git","clone_url":"https://github.com/mbrubeck/cargo.git","svn_url":"https://github.com/mbrubeck/cargo","homepage":"http://crates.io/","size":9636,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"7d79da08238e3d47e0bc4406155bdcc45ccb8c82","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":17420913,"name":"cargo","full_name":"rust-lang/cargo","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/cargo","description":"The Rust package manager","fork":false,"url":"https://api.github.com/repos/rust-lang/cargo","forks_url":"https://api.github.com/repos/rust-lang/cargo/forks","keys_url":"https://api.github.com/repos/rust-lang/cargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/cargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/cargo/teams","hooks_url":"https://api.github.com/repos/rust-lang/cargo/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/cargo/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/cargo/events","assignees_url":"https://api.github.com/repos/rust-lang/cargo/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/cargo/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/cargo/tags","blobs_url":"https://api.github.com/repos/rust-lang/cargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/cargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/cargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/cargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/cargo/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/cargo/languages","stargazers_url":"https://api.github.com/repos/rust-lang/cargo/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/cargo/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/cargo/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/cargo/subscription","commits_url":"https://api.github.com/repos/rust-lang/cargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/cargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/cargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/cargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/cargo/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/cargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/cargo/merges","archive_url":"https://api.github.com/repos/rust-lang/cargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/cargo/downloads","issues_url":"https://api.github.com/repos/rust-lang/cargo/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/cargo/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/cargo/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/cargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/cargo/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/cargo/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/cargo/deployments","created_at":"2014-03-04T23:20:42Z","updated_at":"2016-06-04T19:03:28Z","pushed_at":"2016-06-05T05:31:26Z","git_url":"git://github.com/rust-lang/cargo.git","ssh_url":"git@github.com:rust-lang/cargo.git","clone_url":"https://github.com/rust-lang/cargo.git","svn_url":"https://github.com/rust-lang/cargo","homepage":"http://crates.io/","size":61912,"stargazers_count":1664,"watchers_count":1664,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":381,"mirror_url":null,"open_issues_count":312,"forks":381,"open_issues":312,"watchers":1664,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/2763"},"html":{"href":"https://github.com/rust-lang/cargo/pull/2763"},"issue":{"href":"https://api.github.com/repos/rust-lang/cargo/issues/2763"},"comments":{"href":"https://api.github.com/repos/rust-lang/cargo/issues/2763/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/2763/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/2763/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/cargo/statuses/1db502786f88595c391fd18ed5ab0adef0a30262"}}}}
{"actor":{"display_login":"alexcrichton"}}