{"action":"created","issue":{"url":"https://api.github.com/repos/gramps-project/gramps/issues/268","repository_url":"https://api.github.com/repos/gramps-project/gramps","labels_url":"https://api.github.com/repos/gramps-project/gramps/issues/268/labels{/name}","comments_url":"https://api.github.com/repos/gramps-project/gramps/issues/268/comments","events_url":"https://api.github.com/repos/gramps-project/gramps/issues/268/events","html_url":"https://github.com/gramps-project/gramps/pull/268","id":188029807,"number":268,"title":"bug 9771; fix missing right-click menu items on gallerytab","user":{"login":"prculley","id":18122203,"avatar_url":"https://avatars.githubusercontent.com/u/18122203?v=3","gravatar_id":"","url":"https://api.github.com/users/prculley","html_url":"https://github.com/prculley","followers_url":"https://api.github.com/users/prculley/followers","following_url":"https://api.github.com/users/prculley/following{/other_user}","gists_url":"https://api.github.com/users/prculley/gists{/gist_id}","starred_url":"https://api.github.com/users/prculley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prculley/subscriptions","organizations_url":"https://api.github.com/users/prculley/orgs","repos_url":"https://api.github.com/users/prculley/repos","events_url":"https://api.github.com/users/prculley/events{/privacy}","received_events_url":"https://api.github.com/users/prculley/received_events","type":"User","site_admin":false},"labels":[{"id":163706671,"url":"https://api.github.com/repos/gramps-project/gramps/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-08T15:57:02Z","updated_at":"2016-11-12T01:18:26Z","closed_at":"2016-11-12T01:18:17Z","pull_request":{"url":"https://api.github.com/repos/gramps-project/gramps/pulls/268","html_url":"https://github.com/gramps-project/gramps/pull/268","diff_url":"https://github.com/gramps-project/gramps/pull/268.diff","patch_url":"https://github.com/gramps-project/gramps/pull/268.patch"},"body":"Decided to remove (almost) all the right-click menu icons and make sure that text was present.  The missing text was the cause of the initial bug.\r\n\r\nThis icons were not being shown due to a Gtk bug in the deprecated Gtk.ImageMenuItem() method.\r\n\r\nI did a sweep search of all our code for these right-click menus and tried to patch everything I could find.  The Addons were also searched and will be the subject of another PR.\r\n\r\nAfter icons were removed, I also removed the left side space where the icons used to reside via\r\n`self.menu.set_reserve_toggle_size(False)`\r\n\r\nThe reason I say 'almost' all menu icons were removed is that the Gramps left sidebar (dropdown version) also used menu icons.  I judged that we would like to keep these.  So the dropdownsidebar got fixed with icons and labels in a box inside of the menu item.\r\n\r\nDuring testing of the updated code, I also observed some additional issues, which I also patched.\r\n\r\n1) bookdialog right-click menu got a real menu seperator instead of a large empty space.\r\n2) in pedigreeview, widget `self.get_style().font_desc` was deprecated two ways, I changed to\r\n    `self.get_style_context().get_font(Gtk.StateFlags.NORMAL)`\r\n  unfortunately the `get_font()` is also deprecated, (more recently), but I could not figure out a way to correct this that worked.\r\n3) in pedigreeview, `Gtk.ArrowType` is also deprecated; I switched this out for icons.\r\n4) in pedigreeview, the `window.get_hadjustment()` was pointing to the wrong level of the Gtk hierarchy, a ViewPort rather than the ScrolledWindow.\r\n5) in relview (relationship view) the right-click menu and tooltip were originally labeled with\r\n    `label=_(\"Edit %s\") % name`\r\nAt first glance, I thought a persons name started with \"Edit Smith, John\" so I changed it to\r\n    `label=_(\"Edit Person (%s)\") % name`\r\nso it now looks like \"Edit Person (Smith, John)\".  The new text string was already in the .pot file so no new translation work for that.\r\n6) in configure.py I added an optional parameter to the add_slide method to allow for a wider slider; I observed it was not possible to slide this on one of the configure dialog boxes for an addon because it was so narrow.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/gramps-project/gramps/issues/comments/260091339","html_url":"https://github.com/gramps-project/gramps/pull/268#issuecomment-260091339","issue_url":"https://api.github.com/repos/gramps-project/gramps/issues/268","id":260091339,"user":{"login":"sam-m888","id":8924713,"avatar_url":"https://avatars.githubusercontent.com/u/8924713?v=3","gravatar_id":"","url":"https://api.github.com/users/sam-m888","html_url":"https://github.com/sam-m888","followers_url":"https://api.github.com/users/sam-m888/followers","following_url":"https://api.github.com/users/sam-m888/following{/other_user}","gists_url":"https://api.github.com/users/sam-m888/gists{/gist_id}","starred_url":"https://api.github.com/users/sam-m888/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam-m888/subscriptions","organizations_url":"https://api.github.com/users/sam-m888/orgs","repos_url":"https://api.github.com/users/sam-m888/repos","events_url":"https://api.github.com/users/sam-m888/events{/privacy}","received_events_url":"https://api.github.com/users/sam-m888/received_events","type":"User","site_admin":false},"created_at":"2016-11-12T01:18:26Z","updated_at":"2016-11-12T01:18:26Z","body":"Tested 1 to 5 and assume that that 6 works. As well as fixing 9771's issue.\r\n\r\nThank you"}}
{"actor":{"display_login":"sam-m888"}}