{"action":"created","comment":{"url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/comments/79096183","id":79096183,"diff_hunk":"@@ -39,24 +40,40 @@ namespace gr {\n       : sync_block(\"nlog10_ff\",\n \t\t      io_signature::make (1, 1, sizeof(float)*vlen),\n \t\t      io_signature::make (1, 1, sizeof(float)*vlen)),\n-\td_n(n), d_vlen(vlen), d_k(k)\n+        d_vlen(vlen)\n     {\n+      setk(k);\n+      setn(n);\n+      //TODO message handlers\n+    }\n+\n+    void\n+    nlog10_ff_impl::setk(float k)\n+    {\n+      d_k = k;\n+    }\n+\n+    void\n+    nlog10_ff_impl::setn(float n)\n+    {\n+      d_prefactor = n / log2f(10.0f);\n     }\n \n     int\n     nlog10_ff_impl::work(int noutput_items,\n \t\t\t      gr_vector_const_void_star &input_items,\n \t\t\t      gr_vector_void_star &output_items)\n     {\n+      #define novolk  0","path":"gr-blocks/lib/nlog10_ff_impl.cc","position":37,"original_position":37,"commit_id":"22f637f30e54f6a46c8c40c8923ef3d8c66104e9","original_commit_id":"22f637f30e54f6a46c8c40c8923ef3d8c66104e9","user":{"login":"jmcorgan","id":1492956,"avatar_url":"https://avatars.githubusercontent.com/u/1492956?v=3","gravatar_id":"","url":"https://api.github.com/users/jmcorgan","html_url":"https://github.com/jmcorgan","followers_url":"https://api.github.com/users/jmcorgan/followers","following_url":"https://api.github.com/users/jmcorgan/following{/other_user}","gists_url":"https://api.github.com/users/jmcorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcorgan/subscriptions","organizations_url":"https://api.github.com/users/jmcorgan/orgs","repos_url":"https://api.github.com/users/jmcorgan/repos","events_url":"https://api.github.com/users/jmcorgan/events{/privacy}","received_events_url":"https://api.github.com/users/jmcorgan/received_events","type":"User","site_admin":false},"body":"This looks like a stray debug line that should have been removed.","created_at":"2016-09-16T01:52:49Z","updated_at":"2016-09-16T01:56:53Z","html_url":"https://github.com/gnuradio/gnuradio/pull/915#discussion_r79096183","pull_request_url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/915","_links":{"self":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/comments/79096183"},"html":{"href":"https://github.com/gnuradio/gnuradio/pull/915#discussion_r79096183"},"pull_request":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/915"}}},"pull_request":{"url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/915","id":85508591,"html_url":"https://github.com/gnuradio/gnuradio/pull/915","diff_url":"https://github.com/gnuradio/gnuradio/pull/915.diff","patch_url":"https://github.com/gnuradio/gnuradio/pull/915.patch","issue_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/915","number":915,"state":"open","locked":false,"title":"VOLKized nlog10","user":{"login":"marcusmueller","id":958972,"avatar_url":"https://avatars.githubusercontent.com/u/958972?v=3","gravatar_id":"","url":"https://api.github.com/users/marcusmueller","html_url":"https://github.com/marcusmueller","followers_url":"https://api.github.com/users/marcusmueller/followers","following_url":"https://api.github.com/users/marcusmueller/following{/other_user}","gists_url":"https://api.github.com/users/marcusmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusmueller/subscriptions","organizations_url":"https://api.github.com/users/marcusmueller/orgs","repos_url":"https://api.github.com/users/marcusmueller/repos","events_url":"https://api.github.com/users/marcusmueller/events{/privacy}","received_events_url":"https://api.github.com/users/marcusmueller/received_events","type":"User","site_admin":false},"body":"The inner VOLK demanded improvement of this.\n\nStill not perfect; a volk_32f_s32f_log2_scaled kernel would be better.","created_at":"2016-09-16T01:48:48Z","updated_at":"2016-09-16T01:56:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc1240d9a1b7e52c6aa9772b8a3b1c7d411f23ca","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/915/commits","review_comments_url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/915/comments","review_comment_url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/915/comments","statuses_url":"https://api.github.com/repos/gnuradio/gnuradio/statuses/22f637f30e54f6a46c8c40c8923ef3d8c66104e9","head":{"label":"marcusmueller:speed_up_nlog10","ref":"speed_up_nlog10","sha":"22f637f30e54f6a46c8c40c8923ef3d8c66104e9","user":{"login":"marcusmueller","id":958972,"avatar_url":"https://avatars.githubusercontent.com/u/958972?v=3","gravatar_id":"","url":"https://api.github.com/users/marcusmueller","html_url":"https://github.com/marcusmueller","followers_url":"https://api.github.com/users/marcusmueller/followers","following_url":"https://api.github.com/users/marcusmueller/following{/other_user}","gists_url":"https://api.github.com/users/marcusmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusmueller/subscriptions","organizations_url":"https://api.github.com/users/marcusmueller/orgs","repos_url":"https://api.github.com/users/marcusmueller/repos","events_url":"https://api.github.com/users/marcusmueller/events{/privacy}","received_events_url":"https://api.github.com/users/marcusmueller/received_events","type":"User","site_admin":false},"repo":{"id":10241331,"name":"gnuradio","full_name":"marcusmueller/gnuradio","owner":{"login":"marcusmueller","id":958972,"avatar_url":"https://avatars.githubusercontent.com/u/958972?v=3","gravatar_id":"","url":"https://api.github.com/users/marcusmueller","html_url":"https://github.com/marcusmueller","followers_url":"https://api.github.com/users/marcusmueller/followers","following_url":"https://api.github.com/users/marcusmueller/following{/other_user}","gists_url":"https://api.github.com/users/marcusmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusmueller/subscriptions","organizations_url":"https://api.github.com/users/marcusmueller/orgs","repos_url":"https://api.github.com/users/marcusmueller/repos","events_url":"https://api.github.com/users/marcusmueller/events{/privacy}","received_events_url":"https://api.github.com/users/marcusmueller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcusmueller/gnuradio","description":"GNU Radio","fork":true,"url":"https://api.github.com/repos/marcusmueller/gnuradio","forks_url":"https://api.github.com/repos/marcusmueller/gnuradio/forks","keys_url":"https://api.github.com/repos/marcusmueller/gnuradio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcusmueller/gnuradio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcusmueller/gnuradio/teams","hooks_url":"https://api.github.com/repos/marcusmueller/gnuradio/hooks","issue_events_url":"https://api.github.com/repos/marcusmueller/gnuradio/issues/events{/number}","events_url":"https://api.github.com/repos/marcusmueller/gnuradio/events","assignees_url":"https://api.github.com/repos/marcusmueller/gnuradio/assignees{/user}","branches_url":"https://api.github.com/repos/marcusmueller/gnuradio/branches{/branch}","tags_url":"https://api.github.com/repos/marcusmueller/gnuradio/tags","blobs_url":"https://api.github.com/repos/marcusmueller/gnuradio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcusmueller/gnuradio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcusmueller/gnuradio/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcusmueller/gnuradio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcusmueller/gnuradio/statuses/{sha}","languages_url":"https://api.github.com/repos/marcusmueller/gnuradio/languages","stargazers_url":"https://api.github.com/repos/marcusmueller/gnuradio/stargazers","contributors_url":"https://api.github.com/repos/marcusmueller/gnuradio/contributors","subscribers_url":"https://api.github.com/repos/marcusmueller/gnuradio/subscribers","subscription_url":"https://api.github.com/repos/marcusmueller/gnuradio/subscription","commits_url":"https://api.github.com/repos/marcusmueller/gnuradio/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcusmueller/gnuradio/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcusmueller/gnuradio/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcusmueller/gnuradio/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcusmueller/gnuradio/contents/{+path}","compare_url":"https://api.github.com/repos/marcusmueller/gnuradio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcusmueller/gnuradio/merges","archive_url":"https://api.github.com/repos/marcusmueller/gnuradio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcusmueller/gnuradio/downloads","issues_url":"https://api.github.com/repos/marcusmueller/gnuradio/issues{/number}","pulls_url":"https://api.github.com/repos/marcusmueller/gnuradio/pulls{/number}","milestones_url":"https://api.github.com/repos/marcusmueller/gnuradio/milestones{/number}","notifications_url":"https://api.github.com/repos/marcusmueller/gnuradio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcusmueller/gnuradio/labels{/name}","releases_url":"https://api.github.com/repos/marcusmueller/gnuradio/releases{/id}","deployments_url":"https://api.github.com/repos/marcusmueller/gnuradio/deployments","created_at":"2013-05-23T10:25:46Z","updated_at":"2014-11-23T20:49:35Z","pushed_at":"2016-09-16T01:48:37Z","git_url":"git://github.com/marcusmueller/gnuradio.git","ssh_url":"git@github.com:marcusmueller/gnuradio.git","clone_url":"https://github.com/marcusmueller/gnuradio.git","svn_url":"https://github.com/marcusmueller/gnuradio","homepage":"gnuradio.org","size":46401,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"gnuradio:next","ref":"next","sha":"e5e1b0f5b64073632a27d711c06a75728596670e","user":{"login":"gnuradio","id":1278659,"avatar_url":"https://avatars.githubusercontent.com/u/1278659?v=3","gravatar_id":"","url":"https://api.github.com/users/gnuradio","html_url":"https://github.com/gnuradio","followers_url":"https://api.github.com/users/gnuradio/followers","following_url":"https://api.github.com/users/gnuradio/following{/other_user}","gists_url":"https://api.github.com/users/gnuradio/gists{/gist_id}","starred_url":"https://api.github.com/users/gnuradio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnuradio/subscriptions","organizations_url":"https://api.github.com/users/gnuradio/orgs","repos_url":"https://api.github.com/users/gnuradio/repos","events_url":"https://api.github.com/users/gnuradio/events{/privacy}","received_events_url":"https://api.github.com/users/gnuradio/received_events","type":"Organization","site_admin":false},"repo":{"id":3030065,"name":"gnuradio","full_name":"gnuradio/gnuradio","owner":{"login":"gnuradio","id":1278659,"avatar_url":"https://avatars.githubusercontent.com/u/1278659?v=3","gravatar_id":"","url":"https://api.github.com/users/gnuradio","html_url":"https://github.com/gnuradio","followers_url":"https://api.github.com/users/gnuradio/followers","following_url":"https://api.github.com/users/gnuradio/following{/other_user}","gists_url":"https://api.github.com/users/gnuradio/gists{/gist_id}","starred_url":"https://api.github.com/users/gnuradio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnuradio/subscriptions","organizations_url":"https://api.github.com/users/gnuradio/orgs","repos_url":"https://api.github.com/users/gnuradio/repos","events_url":"https://api.github.com/users/gnuradio/events{/privacy}","received_events_url":"https://api.github.com/users/gnuradio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gnuradio/gnuradio","description":"GNU Radio","fork":false,"url":"https://api.github.com/repos/gnuradio/gnuradio","forks_url":"https://api.github.com/repos/gnuradio/gnuradio/forks","keys_url":"https://api.github.com/repos/gnuradio/gnuradio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnuradio/gnuradio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnuradio/gnuradio/teams","hooks_url":"https://api.github.com/repos/gnuradio/gnuradio/hooks","issue_events_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/events{/number}","events_url":"https://api.github.com/repos/gnuradio/gnuradio/events","assignees_url":"https://api.github.com/repos/gnuradio/gnuradio/assignees{/user}","branches_url":"https://api.github.com/repos/gnuradio/gnuradio/branches{/branch}","tags_url":"https://api.github.com/repos/gnuradio/gnuradio/tags","blobs_url":"https://api.github.com/repos/gnuradio/gnuradio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnuradio/gnuradio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnuradio/gnuradio/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnuradio/gnuradio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnuradio/gnuradio/statuses/{sha}","languages_url":"https://api.github.com/repos/gnuradio/gnuradio/languages","stargazers_url":"https://api.github.com/repos/gnuradio/gnuradio/stargazers","contributors_url":"https://api.github.com/repos/gnuradio/gnuradio/contributors","subscribers_url":"https://api.github.com/repos/gnuradio/gnuradio/subscribers","subscription_url":"https://api.github.com/repos/gnuradio/gnuradio/subscription","commits_url":"https://api.github.com/repos/gnuradio/gnuradio/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnuradio/gnuradio/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnuradio/gnuradio/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnuradio/gnuradio/contents/{+path}","compare_url":"https://api.github.com/repos/gnuradio/gnuradio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnuradio/gnuradio/merges","archive_url":"https://api.github.com/repos/gnuradio/gnuradio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnuradio/gnuradio/downloads","issues_url":"https://api.github.com/repos/gnuradio/gnuradio/issues{/number}","pulls_url":"https://api.github.com/repos/gnuradio/gnuradio/pulls{/number}","milestones_url":"https://api.github.com/repos/gnuradio/gnuradio/milestones{/number}","notifications_url":"https://api.github.com/repos/gnuradio/gnuradio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnuradio/gnuradio/labels{/name}","releases_url":"https://api.github.com/repos/gnuradio/gnuradio/releases{/id}","deployments_url":"https://api.github.com/repos/gnuradio/gnuradio/deployments","created_at":"2011-12-21T22:05:37Z","updated_at":"2016-09-12T10:59:29Z","pushed_at":"2016-09-16T01:48:49Z","git_url":"git://github.com/gnuradio/gnuradio.git","ssh_url":"git@github.com:gnuradio/gnuradio.git","clone_url":"https://github.com/gnuradio/gnuradio.git","svn_url":"https://github.com/gnuradio/gnuradio","homepage":"gnuradio.org","size":55987,"stargazers_count":523,"watchers_count":523,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":482,"mirror_url":null,"open_issues_count":2,"forks":482,"open_issues":2,"watchers":523,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/915"},"html":{"href":"https://github.com/gnuradio/gnuradio/pull/915"},"issue":{"href":"https://api.github.com/repos/gnuradio/gnuradio/issues/915"},"comments":{"href":"https://api.github.com/repos/gnuradio/gnuradio/issues/915/comments"},"review_comments":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/915/comments"},"review_comment":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/915/commits"},"statuses":{"href":"https://api.github.com/repos/gnuradio/gnuradio/statuses/22f637f30e54f6a46c8c40c8923ef3d8c66104e9"}}}}
{"actor":{"display_login":"jmcorgan"}}