{"action":"created","issue":{"url":"https://api.github.com/repos/sabnzbd/sabnzbd/issues/677","repository_url":"https://api.github.com/repos/sabnzbd/sabnzbd","labels_url":"https://api.github.com/repos/sabnzbd/sabnzbd/issues/677/labels{/name}","comments_url":"https://api.github.com/repos/sabnzbd/sabnzbd/issues/677/comments","events_url":"https://api.github.com/repos/sabnzbd/sabnzbd/issues/677/events","html_url":"https://github.com/sabnzbd/sabnzbd/pull/677","id":175777376,"number":677,"title":"New SSL approach","user":{"login":"Safihre","id":5703454,"avatar_url":"https://avatars.githubusercontent.com/u/5703454?v=3","gravatar_id":"","url":"https://api.github.com/users/Safihre","html_url":"https://github.com/Safihre","followers_url":"https://api.github.com/users/Safihre/followers","following_url":"https://api.github.com/users/Safihre/following{/other_user}","gists_url":"https://api.github.com/users/Safihre/gists{/gist_id}","starred_url":"https://api.github.com/users/Safihre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Safihre/subscriptions","organizations_url":"https://api.github.com/users/Safihre/orgs","repos_url":"https://api.github.com/users/Safihre/repos","events_url":"https://api.github.com/users/Safihre/events{/privacy}","received_events_url":"https://api.github.com/users/Safihre/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/sabnzbd/sabnzbd/milestones/9","html_url":"https://github.com/sabnzbd/sabnzbd/milestones/1.2.0","labels_url":"https://api.github.com/repos/sabnzbd/sabnzbd/milestones/9/labels","id":1585421,"number":9,"title":"1.2.0","description":"Speed optimizations.\r\nImproved SSL (with verification and cypher choice).\r\nPossibly: NZB auto-split.\r\n","creator":{"login":"shypike","id":851163,"avatar_url":"https://avatars.githubusercontent.com/u/851163?v=3","gravatar_id":"","url":"https://api.github.com/users/shypike","html_url":"https://github.com/shypike","followers_url":"https://api.github.com/users/shypike/followers","following_url":"https://api.github.com/users/shypike/following{/other_user}","gists_url":"https://api.github.com/users/shypike/gists{/gist_id}","starred_url":"https://api.github.com/users/shypike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shypike/subscriptions","organizations_url":"https://api.github.com/users/shypike/orgs","repos_url":"https://api.github.com/users/shypike/repos","events_url":"https://api.github.com/users/shypike/events{/privacy}","received_events_url":"https://api.github.com/users/shypike/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":1,"state":"open","created_at":"2016-02-16T11:32:24Z","updated_at":"2016-09-09T08:34:56Z","due_on":"2016-12-18T00:00:00Z","closed_at":null},"comments":7,"created_at":"2016-09-08T15:00:12Z","updated_at":"2016-09-09T09:40:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sabnzbd/sabnzbd/pulls/677","html_url":"https://github.com/sabnzbd/sabnzbd/pull/677","diff_url":"https://github.com/sabnzbd/sabnzbd/pull/677.diff","patch_url":"https://github.com/sabnzbd/sabnzbd/pull/677.patch"},"body":"## **Of course this is not for 1.1.0, but 1.2.0**\r\n\r\nAfter discussion in #628, this is my attempt at removing our dependency on pyOpenSSL and using native ```ssl``` module.\r\n\r\n- The user can no longer select what protocol to use, it will always use the best possible. The used protocol and cipher will now be logged after connection is completed.\r\n- There is a new Switch, where you can select the level of verification: Off, Normal (only require a good certificate) and Strict (also force hostname check). \r\n- To test:\r\n```news.surfino.com``` which only works when it's set to Off. \r\n```eunews.frugalusenet.com``` won't work in Strict-mode.\r\n- Updated CherryPy to version 8.1.0 to use ```ssl``` instead of PyOpenSSL as SSL provider. They have patched almost everything we did, but I still had to make 1 custom patch, see: https://github.com/cherrypy/cherrypy/issues/1497\r\n- 301 redirect HTTP->HTTPS on the HTTPS port doesn't work yet, but that's for later.\r\n\r\nSo, what do you think? 🐹 "},"comment":{"url":"https://api.github.com/repos/sabnzbd/sabnzbd/issues/comments/245867967","html_url":"https://github.com/sabnzbd/sabnzbd/pull/677#issuecomment-245867967","issue_url":"https://api.github.com/repos/sabnzbd/sabnzbd/issues/677","id":245867967,"user":{"login":"Safihre","id":5703454,"avatar_url":"https://avatars.githubusercontent.com/u/5703454?v=3","gravatar_id":"","url":"https://api.github.com/users/Safihre","html_url":"https://github.com/Safihre","followers_url":"https://api.github.com/users/Safihre/followers","following_url":"https://api.github.com/users/Safihre/following{/other_user}","gists_url":"https://api.github.com/users/Safihre/gists{/gist_id}","starred_url":"https://api.github.com/users/Safihre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Safihre/subscriptions","organizations_url":"https://api.github.com/users/Safihre/orgs","repos_url":"https://api.github.com/users/Safihre/repos","events_url":"https://api.github.com/users/Safihre/events{/privacy}","received_events_url":"https://api.github.com/users/Safihre/received_events","type":"User","site_admin":false},"created_at":"2016-09-09T09:40:48Z","updated_at":"2016-09-09T09:40:48Z","body":"Completed the PyOpenSSL-ectomy! \r\n```cryptography``` will now take care of the self-signed certificate generation.\r\n@shypike maybe you can test if this eases the binary creating?\r\n\r\nIt's still a work-in-progress:\r\n- CherryPy still needs a patch to do 301 redirect HTTP->HTTPS on the HTTPS port. That became a bit more complicated due to the way CherryPy changed where it throws an error in that case.\r\n- It sometimes throws ```SSLError: ('_ssl.c:574: The handshake operation timed out',)```, have to see what causes that and how to correctly catch it. Seems to happen when a connection is attempted before CherryPy is ready, for example when a previous Glitter is still open in the browser while SABnzbd is (re)starting."}}
{"actor":{"display_login":"Safihre"}}