{"action":"created","issue":{"url":"https://api.github.com/repos/Elgg/Elgg/issues/8953","repository_url":"https://api.github.com/repos/Elgg/Elgg","labels_url":"https://api.github.com/repos/Elgg/Elgg/issues/8953/labels{/name}","comments_url":"https://api.github.com/repos/Elgg/Elgg/issues/8953/comments","events_url":"https://api.github.com/repos/Elgg/Elgg/issues/8953/events","html_url":"https://github.com/Elgg/Elgg/issues/8953","id":107067605,"number":8953,"title":"Deprecate logged-in-user magic from permission checks","user":{"login":"juho-jaakkola","id":883920,"avatar_url":"https://avatars.githubusercontent.com/u/883920?v=3","gravatar_id":"","url":"https://api.github.com/users/juho-jaakkola","html_url":"https://github.com/juho-jaakkola","followers_url":"https://api.github.com/users/juho-jaakkola/followers","following_url":"https://api.github.com/users/juho-jaakkola/following{/other_user}","gists_url":"https://api.github.com/users/juho-jaakkola/gists{/gist_id}","starred_url":"https://api.github.com/users/juho-jaakkola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juho-jaakkola/subscriptions","organizations_url":"https://api.github.com/users/juho-jaakkola/orgs","repos_url":"https://api.github.com/users/juho-jaakkola/repos","events_url":"https://api.github.com/users/juho-jaakkola/events{/privacy}","received_events_url":"https://api.github.com/users/juho-jaakkola/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Elgg/Elgg/labels/easy","name":"easy","color":"d7e102"},{"url":"https://api.github.com/repos/Elgg/Elgg/labels/engine","name":"engine","color":"444444"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/Elgg/Elgg/milestones/79","html_url":"https://github.com/Elgg/Elgg/milestones/Elgg%202.x","labels_url":"https://api.github.com/repos/Elgg/Elgg/milestones/79/labels","id":1310532,"number":79,"title":"Elgg 2.x","description":"","creator":{"login":"juho-jaakkola","id":883920,"avatar_url":"https://avatars.githubusercontent.com/u/883920?v=3","gravatar_id":"","url":"https://api.github.com/users/juho-jaakkola","html_url":"https://github.com/juho-jaakkola","followers_url":"https://api.github.com/users/juho-jaakkola/followers","following_url":"https://api.github.com/users/juho-jaakkola/following{/other_user}","gists_url":"https://api.github.com/users/juho-jaakkola/gists{/gist_id}","starred_url":"https://api.github.com/users/juho-jaakkola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juho-jaakkola/subscriptions","organizations_url":"https://api.github.com/users/juho-jaakkola/orgs","repos_url":"https://api.github.com/users/juho-jaakkola/repos","events_url":"https://api.github.com/users/juho-jaakkola/events{/privacy}","received_events_url":"https://api.github.com/users/juho-jaakkola/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":3,"state":"open","created_at":"2015-09-17T14:22:36Z","updated_at":"2016-02-22T15:22:18Z","due_on":"2016-03-14T04:00:00Z","closed_at":null},"comments":6,"created_at":"2015-09-17T20:27:31Z","updated_at":"2016-03-03T22:38:56Z","closed_at":null,"body":"Most of our permission checks default to the logged in user in case a user is not explicitly passed into the permission check functions.\r\n\r\nDeprecating this feature will:\r\n - Make permission checks safer as it forces devs to think what they're doing instead of relying on magic\r\n - Reduce the complexity of core"},"comment":{"url":"https://api.github.com/repos/Elgg/Elgg/issues/comments/191999637","html_url":"https://github.com/Elgg/Elgg/issues/8953#issuecomment-191999637","issue_url":"https://api.github.com/repos/Elgg/Elgg/issues/8953","id":191999637,"user":{"login":"mrclay","id":170687,"avatar_url":"https://avatars.githubusercontent.com/u/170687?v=3","gravatar_id":"","url":"https://api.github.com/users/mrclay","html_url":"https://github.com/mrclay","followers_url":"https://api.github.com/users/mrclay/followers","following_url":"https://api.github.com/users/mrclay/following{/other_user}","gists_url":"https://api.github.com/users/mrclay/gists{/gist_id}","starred_url":"https://api.github.com/users/mrclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrclay/subscriptions","organizations_url":"https://api.github.com/users/mrclay/orgs","repos_url":"https://api.github.com/users/mrclay/repos","events_url":"https://api.github.com/users/mrclay/events{/privacy}","received_events_url":"https://api.github.com/users/mrclay/received_events","type":"User","site_admin":false},"created_at":"2016-03-03T22:38:56Z","updated_at":"2016-03-03T22:38:56Z","body":"Using entityTable->getUserForPermissionsCheck() internally, this seems no longer a big problem. If it's really worth breaking a ton of API to be more strict, we can use something [like this](https://gist.github.com/mrclay/d80696e5ad6a71b70bb2), which can unambiguously represent a logged out user."}}