{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/8564","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/8564/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/8564/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/8564/events","html_url":"https://github.com/Microsoft/vscode/issues/8564","id":163113264,"number":8564,"title":"Tabs: Coloring issues","user":{"login":"bpasero","id":900690,"avatar_url":"https://avatars.githubusercontent.com/u/900690?v=3","gravatar_id":"","url":"https://api.github.com/users/bpasero","html_url":"https://github.com/bpasero","followers_url":"https://api.github.com/users/bpasero/followers","following_url":"https://api.github.com/users/bpasero/following{/other_user}","gists_url":"https://api.github.com/users/bpasero/gists{/gist_id}","starred_url":"https://api.github.com/users/bpasero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpasero/subscriptions","organizations_url":"https://api.github.com/users/bpasero/orgs","repos_url":"https://api.github.com/users/bpasero/repos","events_url":"https://api.github.com/users/bpasero/events{/privacy}","received_events_url":"https://api.github.com/users/bpasero/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Microsoft/vscode/labels/polish","name":"polish","color":"fbca04"},{"url":"https://api.github.com/repos/Microsoft/vscode/labels/tabs","name":"tabs","color":"c7def8"},{"url":"https://api.github.com/repos/Microsoft/vscode/labels/ux","name":"ux","color":"c7def8"},{"url":"https://api.github.com/repos/Microsoft/vscode/labels/verification-needed","name":"verification-needed","color":"c2e0c6"}],"state":"closed","locked":false,"assignee":{"login":"bgashler1","id":11839736,"avatar_url":"https://avatars.githubusercontent.com/u/11839736?v=3","gravatar_id":"","url":"https://api.github.com/users/bgashler1","html_url":"https://github.com/bgashler1","followers_url":"https://api.github.com/users/bgashler1/followers","following_url":"https://api.github.com/users/bgashler1/following{/other_user}","gists_url":"https://api.github.com/users/bgashler1/gists{/gist_id}","starred_url":"https://api.github.com/users/bgashler1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgashler1/subscriptions","organizations_url":"https://api.github.com/users/bgashler1/orgs","repos_url":"https://api.github.com/users/bgashler1/repos","events_url":"https://api.github.com/users/bgashler1/events{/privacy}","received_events_url":"https://api.github.com/users/bgashler1/received_events","type":"User","site_admin":false},"assignees":[{"login":"bgashler1","id":11839736,"avatar_url":"https://avatars.githubusercontent.com/u/11839736?v=3","gravatar_id":"","url":"https://api.github.com/users/bgashler1","html_url":"https://github.com/bgashler1","followers_url":"https://api.github.com/users/bgashler1/followers","following_url":"https://api.github.com/users/bgashler1/following{/other_user}","gists_url":"https://api.github.com/users/bgashler1/gists{/gist_id}","starred_url":"https://api.github.com/users/bgashler1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgashler1/subscriptions","organizations_url":"https://api.github.com/users/bgashler1/orgs","repos_url":"https://api.github.com/users/bgashler1/repos","events_url":"https://api.github.com/users/bgashler1/events{/privacy}","received_events_url":"https://api.github.com/users/bgashler1/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/20","html_url":"https://github.com/Microsoft/vscode/milestones/June%202016","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/20/labels","id":1774575,"number":20,"title":"June 2016","description":"","creator":{"login":"bgashler1","id":11839736,"avatar_url":"https://avatars.githubusercontent.com/u/11839736?v=3","gravatar_id":"","url":"https://api.github.com/users/bgashler1","html_url":"https://github.com/bgashler1","followers_url":"https://api.github.com/users/bgashler1/followers","following_url":"https://api.github.com/users/bgashler1/following{/other_user}","gists_url":"https://api.github.com/users/bgashler1/gists{/gist_id}","starred_url":"https://api.github.com/users/bgashler1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgashler1/subscriptions","organizations_url":"https://api.github.com/users/bgashler1/orgs","repos_url":"https://api.github.com/users/bgashler1/repos","events_url":"https://api.github.com/users/bgashler1/events{/privacy}","received_events_url":"https://api.github.com/users/bgashler1/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":543,"state":"open","created_at":"2016-05-18T17:48:57Z","updated_at":"2016-07-01T11:03:35Z","due_on":"2016-06-30T07:00:00Z","closed_at":null},"comments":1,"created_at":"2016-06-30T08:48:36Z","updated_at":"2016-07-01T11:06:49Z","closed_at":"2016-07-01T11:03:35Z","body":"Summary of collected issues for coloring in tabs\r\n* editor find widget blends too easy into tab background in dark theme (https://github.com/Microsoft/vscode/issues/7649, https://github.com/Microsoft/vscode/issues/8294)\r\n* we use a lot of opacity to get the different shading to work with the different themes\r\n* people find it hard to distinguish the active tab from the inactive\r\n* in HC theme it is hard to distinguish tabs that are in an inactive group (https://github.com/Microsoft/vscode/issues/8550)\r\n* in HC theme the active tab shifts down (https://github.com/Microsoft/vscode/issues/8551)\r\n\r\nProposed solution from @bgashler1 in https://github.com/Microsoft/vscode/pull/8587"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/229920622","html_url":"https://github.com/Microsoft/vscode/issues/8564#issuecomment-229920622","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/8564","id":229920622,"user":{"login":"bpasero","id":900690,"avatar_url":"https://avatars.githubusercontent.com/u/900690?v=3","gravatar_id":"","url":"https://api.github.com/users/bpasero","html_url":"https://github.com/bpasero","followers_url":"https://api.github.com/users/bpasero/followers","following_url":"https://api.github.com/users/bpasero/following{/other_user}","gists_url":"https://api.github.com/users/bpasero/gists{/gist_id}","starred_url":"https://api.github.com/users/bpasero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpasero/subscriptions","organizations_url":"https://api.github.com/users/bpasero/orgs","repos_url":"https://api.github.com/users/bpasero/repos","events_url":"https://api.github.com/users/bpasero/events{/privacy}","received_events_url":"https://api.github.com/users/bpasero/received_events","type":"User","site_admin":false},"created_at":"2016-07-01T11:06:49Z","updated_at":"2016-07-01T11:06:49Z","body":"@bgashler1 I pushed a variant of your commit (https://github.com/Microsoft/vscode/commit/681e42f8061cdeb12823be626e0bd28b6aa86c6b) to master for June with the following changes:\r\n* I also use mix-blend-mode for the ::before element so that the border blends nicely in other themes (not sure why you did not set it)?\r\n* I avoid the trick/hack you do with changing the tab size between 34-36px by using z-index for the ::before element. in your solution I noticed the active tab jumping a bit when getting active\r\n\r\nThere is one thing which I don't like is the dropfeedback color over tabs and tabs container in light theme. It used to be the same blue you get when dragging over the tree or editor area but now with the mixed blend mode, I cannot get this colour to work. It seems this CSS property is inherited like opacity and you cannot disable it? If you have ideas how to solve that, we can still push for it."}}
{"actor":{"display_login":"bpasero"}}