{"action":"created","issue":{"url":"https://api.github.com/repos/errbotio/errbot/issues/823","repository_url":"https://api.github.com/repos/errbotio/errbot","labels_url":"https://api.github.com/repos/errbotio/errbot/issues/823/labels{/name}","comments_url":"https://api.github.com/repos/errbotio/errbot/issues/823/comments","events_url":"https://api.github.com/repos/errbotio/errbot/issues/823/events","html_url":"https://github.com/errbotio/errbot/issues/823","id":168138694,"number":823,"title":"XMPP passworded room errbot 4.2.2","user":{"login":"richiebbb","id":11758026,"avatar_url":"https://avatars.githubusercontent.com/u/11758026?v=3","gravatar_id":"","url":"https://api.github.com/users/richiebbb","html_url":"https://github.com/richiebbb","followers_url":"https://api.github.com/users/richiebbb/followers","following_url":"https://api.github.com/users/richiebbb/following{/other_user}","gists_url":"https://api.github.com/users/richiebbb/gists{/gist_id}","starred_url":"https://api.github.com/users/richiebbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richiebbb/subscriptions","organizations_url":"https://api.github.com/users/richiebbb/orgs","repos_url":"https://api.github.com/users/richiebbb/repos","events_url":"https://api.github.com/users/richiebbb/events{/privacy}","received_events_url":"https://api.github.com/users/richiebbb/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-28T16:26:39Z","updated_at":"2016-07-28T17:00:40Z","closed_at":"2016-07-28T16:30:11Z","body":"Hi, I briefly searched for this, sorry if it was already reported.\r\n\r\nIn _join_chat http://errbot.io/en/latest/_modules/errbot/core_plugins/chatRoom.html\r\n\r\nJoining a passworded XMPP room doesn't initiate `self.query_room(room).join` because it is indented one more than it should be. **The final line of the following code**.\r\n\r\n```python\r\n    def _join_room(self, room):\r\n        if isinstance(room, (tuple, list)):\r\n            room_name = compat_str(room[0])\r\n            room_password = compat_str(room[1])\r\n            room, username, password = (room_name, self.bot_config.CHATROOM_FN, room_password)\r\n            self.log.info(\"Joining room {} with username {} and password\".format(room, username))\r\n        else:\r\n            room_name = compat_str(room)\r\n            room, username, password = (room_name, self.bot_config.CHATROOM_FN, None)\r\n            self.log.info(\"Joining room {} with username {}\".format(room, username))\r\n            self.query_room(room).join(username=self.bot_config.CHATROOM_FN, password=password)\r\n```\r\nI've fixed this locally with \r\n```python\r\n    def _join_room(self, room):\r\n        if isinstance(room, (tuple, list)):\r\n            room_name = compat_str(room[0])\r\n            room_password = compat_str(room[1])\r\n            room, username, password = (room_name, self.bot_config.CHATROOM_FN, room_password)\r\n            self.log.info(\"Joining room {} with username {} and password\".format(room, username))\r\n        else:\r\n            room_name = compat_str(room)\r\n            room, username, password = (room_name, self.bot_config.CHATROOM_FN, None)\r\n            self.log.info(\"Joining room {} with username {}\".format(room, username))\r\n        self.query_room(room).join(username=self.bot_config.CHATROOM_FN, password=password)\r\n```\r\n\r\nThanks, love the software."},"comment":{"url":"https://api.github.com/repos/errbotio/errbot/issues/comments/235958026","html_url":"https://github.com/errbotio/errbot/issues/823#issuecomment-235958026","issue_url":"https://api.github.com/repos/errbotio/errbot/issues/823","id":235958026,"user":{"login":"zoni","id":145285,"avatar_url":"https://avatars.githubusercontent.com/u/145285?v=3","gravatar_id":"","url":"https://api.github.com/users/zoni","html_url":"https://github.com/zoni","followers_url":"https://api.github.com/users/zoni/followers","following_url":"https://api.github.com/users/zoni/following{/other_user}","gists_url":"https://api.github.com/users/zoni/gists{/gist_id}","starred_url":"https://api.github.com/users/zoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoni/subscriptions","organizations_url":"https://api.github.com/users/zoni/orgs","repos_url":"https://api.github.com/users/zoni/repos","events_url":"https://api.github.com/users/zoni/events{/privacy}","received_events_url":"https://api.github.com/users/zoni/received_events","type":"User","site_admin":false},"created_at":"2016-07-28T17:00:40Z","updated_at":"2016-07-28T17:00:40Z","body":"No worries! Thanks for taking the time to report this so well, even if it was already fixed. :smile: "}}
{"actor":{"display_login":"zoni"}}