{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10929","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10929/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10929/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10929/events","html_url":"https://github.com/cockroachdb/cockroach/pull/10929","id":190881694,"number":10929,"title":"storage: tune raft.Config.{MaxSizePerMsg,MaxInflightMsgs}","user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bdarnell","id":160562,"avatar_url":"https://avatars.githubusercontent.com/u/160562?v=3","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false},"assignees":[{"login":"bdarnell","id":160562,"avatar_url":"https://avatars.githubusercontent.com/u/160562?v=3","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-11-22T01:13:42Z","updated_at":"2016-11-22T14:58:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10929","html_url":"https://github.com/cockroachdb/cockroach/pull/10929","diff_url":"https://github.com/cockroachdb/cockroach/pull/10929.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/10929.patch"},"body":"The previous settings allowed up to 256 MB of Raft log entries to be\ninflight to a follower, resulting in a single Replica.handleRaftReady\ncall processing thousands or 10s of thousands of commands.\n\nLog the number of commands processed when Replica.handleRaftReady takes\ntoo long.\n\nFixes #10917\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/10929)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/262262468","html_url":"https://github.com/cockroachdb/cockroach/pull/10929#issuecomment-262262468","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10929","id":262262468,"user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"created_at":"2016-11-22T14:58:01Z","updated_at":"2016-11-22T14:58:01Z","body":"\n\n\n\nReview status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.\n\n---\n\n*[pkg/storage/replica.go, line 2447 at r1](https://reviewable.io:443/reviews/cockroachdb/cockroach/10929#-KX9VNCVbHqDez5lRPYL:-KXBWd7VLVRT9thFneWW:b-896fix) ([raw file](https://github.com/cockroachdb/cockroach/blob/30402710864091423b78c367f05654f0cc07919a/pkg/storage/replica.go#L2447)):*\n<details><summary><i>Previously, bdarnell (Ben Darnell) wrote…</i></summary>\n> Also increment stats.processed here.\n</details>\nDone.\n\n---\n\n*[pkg/storage/store.go, line 177 at r1](https://reviewable.io:443/reviews/cockroachdb/cockroach/10929#-KX9UhI826ExjlKs6hV-:-KXBWf6LfC0T-mI_JNKt:b-d546sv) ([raw file](https://github.com/cockroachdb/cockroach/blob/30402710864091423b78c367f05654f0cc07919a/pkg/storage/store.go#L177)):*\n<details><summary><i>Previously, bdarnell (Ben Darnell) wrote…</i></summary>\n> That's really going to hurt performance of hot ranges in geographically-distributed deployments. Maybe after this change we should figure out how to release the lock in between processing commands instead of limiting throughput so much. \n</details>\nReleasing the lock between processing commands is problematic as we're still running on the Raft scheduler which guarantees only a single worker is processing a range. Tossing the execution of `CommittedEntries` to another worker is going to be mildly complicated as we need to ensure they are executed in order. Whacking `raft.Ready.HardState.Commit` as I do in the second commit is ugly, but it accomplishes that effect without significant complexity. Maybe we should see about an upstream change to raft to provide a better signal that only a fraction of the `CommittedEntries` have been executed.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/10929)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"petermattis"}}