{"action":"created","comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/79157183","id":79157183,"diff_hunk":"@@ -72,6 +74,76 @@ class TestDelegate : public threads::ThreadDelegate {\n   bool check_value_;\n };\n \n+class InfiniteMainTestDelegate : public threads::ThreadDelegate {\n+ public:\n+  InfiniteMainTestDelegate()\n+      : notified_(false), notify_running_(false), check_value_(false) {}\n+\n+  void threadMain() {\n+    {\n+      AutoLock test_lock(test_mutex_);\n+      check_value_ = true;\n+      notify_running_ = true;\n+      cond_var_.Broadcast();\n+    }\n+\n+    while (!notified_) {\n+      threads::sleep(1);","path":"src/components/utils/test/thread_test.cc","position":61,"original_position":41,"commit_id":"c51a8fe6f628f68a56ccf24e34f6812962fd1aeb","original_commit_id":"5d72bfda62a83e17c814c23307aae3d916fc230c","user":{"login":"AGritsevich","id":13793836,"avatar_url":"https://avatars.githubusercontent.com/u/13793836?v=3","gravatar_id":"","url":"https://api.github.com/users/AGritsevich","html_url":"https://github.com/AGritsevich","followers_url":"https://api.github.com/users/AGritsevich/followers","following_url":"https://api.github.com/users/AGritsevich/following{/other_user}","gists_url":"https://api.github.com/users/AGritsevich/gists{/gist_id}","starred_url":"https://api.github.com/users/AGritsevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AGritsevich/subscriptions","organizations_url":"https://api.github.com/users/AGritsevich/orgs","repos_url":"https://api.github.com/users/AGritsevich/repos","events_url":"https://api.github.com/users/AGritsevich/events{/privacy}","received_events_url":"https://api.github.com/users/AGritsevich/received_events","type":"User","site_admin":false},"body":"@pvvasilev, I think that 1 extra boolean param it's less price then most likely new problem with those tests, when some process in SDL will take more or less time. I think better use ConVat then sleep.","created_at":"2016-09-16T12:17:38Z","updated_at":"2016-09-16T12:17:38Z","html_url":"https://github.com/smartdevicelink/sdl_core/pull/821#discussion_r79157183","pull_request_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/821","_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/79157183"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/821#discussion_r79157183"},"pull_request":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/821"}}},"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/821","id":85382640,"html_url":"https://github.com/smartdevicelink/sdl_core/pull/821","diff_url":"https://github.com/smartdevicelink/sdl_core/pull/821.diff","patch_url":"https://github.com/smartdevicelink/sdl_core/pull/821.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/821","number":821,"state":"open","locked":false,"title":"Cover cases with Thread restarting/joining","user":{"login":"pvvasilev","id":20396512,"avatar_url":"https://avatars.githubusercontent.com/u/20396512?v=3","gravatar_id":"","url":"https://api.github.com/users/pvvasilev","html_url":"https://github.com/pvvasilev","followers_url":"https://api.github.com/users/pvvasilev/followers","following_url":"https://api.github.com/users/pvvasilev/following{/other_user}","gists_url":"https://api.github.com/users/pvvasilev/gists{/gist_id}","starred_url":"https://api.github.com/users/pvvasilev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvvasilev/subscriptions","organizations_url":"https://api.github.com/users/pvvasilev/orgs","repos_url":"https://api.github.com/users/pvvasilev/repos","events_url":"https://api.github.com/users/pvvasilev/events{/privacy}","received_events_url":"https://api.github.com/users/pvvasilev/received_events","type":"User","site_admin":false},"body":"start/join thread with force -> check that thread has been stopped\r\nstart/join thread without force -> check that thread has been joined and delegate's threadMain function has been called\r\nstart/stop/start thread -> check that thread has been restarted\r\nstart/join/start thread -> check that thread has been restarted\r\ndelete running joinable thread -> check that destructor are waiting for finishing\r\n\r\nRelated issue: [APPLINK-27515](https://adc.luxoft.com/jira/browse/APPLINK-27515)","created_at":"2016-09-15T10:53:26Z","updated_at":"2016-09-16T12:17:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83904183180ed0218bf7b6c731f83f5e69fd4bf9","assignee":{"login":"AGritsevich","id":13793836,"avatar_url":"https://avatars.githubusercontent.com/u/13793836?v=3","gravatar_id":"","url":"https://api.github.com/users/AGritsevich","html_url":"https://github.com/AGritsevich","followers_url":"https://api.github.com/users/AGritsevich/followers","following_url":"https://api.github.com/users/AGritsevich/following{/other_user}","gists_url":"https://api.github.com/users/AGritsevich/gists{/gist_id}","starred_url":"https://api.github.com/users/AGritsevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AGritsevich/subscriptions","organizations_url":"https://api.github.com/users/AGritsevich/orgs","repos_url":"https://api.github.com/users/AGritsevich/repos","events_url":"https://api.github.com/users/AGritsevich/events{/privacy}","received_events_url":"https://api.github.com/users/AGritsevich/received_events","type":"User","site_admin":false},"assignees":[{"login":"AGritsevich","id":13793836,"avatar_url":"https://avatars.githubusercontent.com/u/13793836?v=3","gravatar_id":"","url":"https://api.github.com/users/AGritsevich","html_url":"https://github.com/AGritsevich","followers_url":"https://api.github.com/users/AGritsevich/followers","following_url":"https://api.github.com/users/AGritsevich/following{/other_user}","gists_url":"https://api.github.com/users/AGritsevich/gists{/gist_id}","starred_url":"https://api.github.com/users/AGritsevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AGritsevich/subscriptions","organizations_url":"https://api.github.com/users/AGritsevich/orgs","repos_url":"https://api.github.com/users/AGritsevich/repos","events_url":"https://api.github.com/users/AGritsevich/events{/privacy}","received_events_url":"https://api.github.com/users/AGritsevich/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/821/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/821/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/821/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/c51a8fe6f628f68a56ccf24e34f6812962fd1aeb","head":{"label":"pvvasilev:Cover_cases_with_Thread_restarting_joining","ref":"Cover_cases_with_Thread_restarting_joining","sha":"c51a8fe6f628f68a56ccf24e34f6812962fd1aeb","user":{"login":"pvvasilev","id":20396512,"avatar_url":"https://avatars.githubusercontent.com/u/20396512?v=3","gravatar_id":"","url":"https://api.github.com/users/pvvasilev","html_url":"https://github.com/pvvasilev","followers_url":"https://api.github.com/users/pvvasilev/followers","following_url":"https://api.github.com/users/pvvasilev/following{/other_user}","gists_url":"https://api.github.com/users/pvvasilev/gists{/gist_id}","starred_url":"https://api.github.com/users/pvvasilev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvvasilev/subscriptions","organizations_url":"https://api.github.com/users/pvvasilev/orgs","repos_url":"https://api.github.com/users/pvvasilev/repos","events_url":"https://api.github.com/users/pvvasilev/events{/privacy}","received_events_url":"https://api.github.com/users/pvvasilev/received_events","type":"User","site_admin":false},"repo":{"id":63159535,"name":"sdl_core","full_name":"pvvasilev/sdl_core","owner":{"login":"pvvasilev","id":20396512,"avatar_url":"https://avatars.githubusercontent.com/u/20396512?v=3","gravatar_id":"","url":"https://api.github.com/users/pvvasilev","html_url":"https://github.com/pvvasilev","followers_url":"https://api.github.com/users/pvvasilev/followers","following_url":"https://api.github.com/users/pvvasilev/following{/other_user}","gists_url":"https://api.github.com/users/pvvasilev/gists{/gist_id}","starred_url":"https://api.github.com/users/pvvasilev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvvasilev/subscriptions","organizations_url":"https://api.github.com/users/pvvasilev/orgs","repos_url":"https://api.github.com/users/pvvasilev/repos","events_url":"https://api.github.com/users/pvvasilev/events{/privacy}","received_events_url":"https://api.github.com/users/pvvasilev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pvvasilev/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":true,"url":"https://api.github.com/repos/pvvasilev/sdl_core","forks_url":"https://api.github.com/repos/pvvasilev/sdl_core/forks","keys_url":"https://api.github.com/repos/pvvasilev/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pvvasilev/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pvvasilev/sdl_core/teams","hooks_url":"https://api.github.com/repos/pvvasilev/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/pvvasilev/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/pvvasilev/sdl_core/events","assignees_url":"https://api.github.com/repos/pvvasilev/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/pvvasilev/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/pvvasilev/sdl_core/tags","blobs_url":"https://api.github.com/repos/pvvasilev/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pvvasilev/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pvvasilev/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/pvvasilev/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pvvasilev/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/pvvasilev/sdl_core/languages","stargazers_url":"https://api.github.com/repos/pvvasilev/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/pvvasilev/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/pvvasilev/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/pvvasilev/sdl_core/subscription","commits_url":"https://api.github.com/repos/pvvasilev/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/pvvasilev/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/pvvasilev/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/pvvasilev/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/pvvasilev/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/pvvasilev/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pvvasilev/sdl_core/merges","archive_url":"https://api.github.com/repos/pvvasilev/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pvvasilev/sdl_core/downloads","issues_url":"https://api.github.com/repos/pvvasilev/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/pvvasilev/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/pvvasilev/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/pvvasilev/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pvvasilev/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/pvvasilev/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/pvvasilev/sdl_core/deployments","created_at":"2016-07-12T13:18:54Z","updated_at":"2016-07-12T13:19:02Z","pushed_at":"2016-09-16T12:10:56Z","git_url":"git://github.com/pvvasilev/sdl_core.git","ssh_url":"git@github.com:pvvasilev/sdl_core.git","clone_url":"https://github.com/pvvasilev/sdl_core.git","svn_url":"https://github.com/pvvasilev/sdl_core","homepage":"","size":176083,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smartdevicelink:develop","ref":"develop","sha":"fc74b8fd2e8c76f93544fd62d07fc871ac590323","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24724170,"name":"sdl_core","full_name":"smartdevicelink/sdl_core","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_core","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_core/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_core/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_core/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_core/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/deployments","created_at":"2014-10-02T15:16:26Z","updated_at":"2016-09-15T14:24:22Z","pushed_at":"2016-09-16T12:10:57Z","git_url":"git://github.com/smartdevicelink/sdl_core.git","ssh_url":"git@github.com:smartdevicelink/sdl_core.git","clone_url":"https://github.com/smartdevicelink/sdl_core.git","svn_url":"https://github.com/smartdevicelink/sdl_core","homepage":"","size":312517,"stargazers_count":78,"watchers_count":78,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":101,"forks":95,"open_issues":101,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/821"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/821"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/821"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/821/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/821/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/821/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/c51a8fe6f628f68a56ccf24e34f6812962fd1aeb"}}}}
{"actor":{"display_login":"AGritsevich"}}