{"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/88802135","pull_request_review_id":9364755,"id":88802135,"diff_hunk":"@@ -6,198 +6,24 @@\n   require \"abstract_unit\"\n   require \"active_support/xml_mini\"\n   require \"active_support/core_ext/hash/conversions\"\n+  require_relative \"./common\"","path":"activesupport/test/xml_mini/libxml_engine_test.rb","position":4,"original_position":4,"commit_id":"e30c4f600dce297b21454fdeaeda5cc94fcfc4dd","original_commit_id":"eb8b30852d2ed77a0f7ab39e531c55033a6f34f0","user":{"login":"kaspth","id":350807,"avatar_url":"https://avatars.githubusercontent.com/u/350807?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspth","html_url":"https://github.com/kaspth","followers_url":"https://api.github.com/users/kaspth/followers","following_url":"https://api.github.com/users/kaspth/following{/other_user}","gists_url":"https://api.github.com/users/kaspth/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspth/subscriptions","organizations_url":"https://api.github.com/users/kaspth/orgs","repos_url":"https://api.github.com/users/kaspth/repos","events_url":"https://api.github.com/users/kaspth/events{/privacy}","received_events_url":"https://api.github.com/users/kaspth/received_events","type":"User","site_admin":false},"body":"Why do we need `./` when we require relatively to the current dir?","created_at":"2016-11-20T14:01:09Z","updated_at":"2016-11-20T14:32:50Z","html_url":"https://github.com/rails/rails/pull/27111#discussion_r88802135","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/27111","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/88802135"},"html":{"href":"https://github.com/rails/rails/pull/27111#discussion_r88802135"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/27111"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/27111","id":94494912,"html_url":"https://github.com/rails/rails/pull/27111","diff_url":"https://github.com/rails/rails/pull/27111.diff","patch_url":"https://github.com/rails/rails/pull/27111.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/27111","number":27111,"state":"open","locked":false,"title":"Refactor ActiveSupport::XMLMini test suite","user":{"login":"maclover7","id":3020626,"avatar_url":"https://avatars.githubusercontent.com/u/3020626?v=3","gravatar_id":"","url":"https://api.github.com/users/maclover7","html_url":"https://github.com/maclover7","followers_url":"https://api.github.com/users/maclover7/followers","following_url":"https://api.github.com/users/maclover7/following{/other_user}","gists_url":"https://api.github.com/users/maclover7/gists{/gist_id}","starred_url":"https://api.github.com/users/maclover7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maclover7/subscriptions","organizations_url":"https://api.github.com/users/maclover7/orgs","repos_url":"https://api.github.com/users/maclover7/repos","events_url":"https://api.github.com/users/maclover7/events{/privacy}","received_events_url":"https://api.github.com/users/maclover7/received_events","type":"User","site_admin":false},"body":"### Summary\r\n\r\nAs I am working on getting Active Support's test suite running on JRuby, I noticed many inconsistencies with the test suite for `ActiveSupport::XMLMini`, including many tests missing from certain adapters. This PR aims to standardize the tests run for each of the different `XMLMini` backends. Also, I noticed that tests for the libxml engine were not running locally due to a missing gem. I added the gem to the Gemfile so all future contributors will be able to run the full suite without needing to install another gem.","created_at":"2016-11-19T20:44:46Z","updated_at":"2016-11-20T14:32:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63f4e57e51da8132d9c5a4f67e2a938a2365987a","assignee":{"login":"maclover7","id":3020626,"avatar_url":"https://avatars.githubusercontent.com/u/3020626?v=3","gravatar_id":"","url":"https://api.github.com/users/maclover7","html_url":"https://github.com/maclover7","followers_url":"https://api.github.com/users/maclover7/followers","following_url":"https://api.github.com/users/maclover7/following{/other_user}","gists_url":"https://api.github.com/users/maclover7/gists{/gist_id}","starred_url":"https://api.github.com/users/maclover7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maclover7/subscriptions","organizations_url":"https://api.github.com/users/maclover7/orgs","repos_url":"https://api.github.com/users/maclover7/repos","events_url":"https://api.github.com/users/maclover7/events{/privacy}","received_events_url":"https://api.github.com/users/maclover7/received_events","type":"User","site_admin":false},"assignees":[{"login":"maclover7","id":3020626,"avatar_url":"https://avatars.githubusercontent.com/u/3020626?v=3","gravatar_id":"","url":"https://api.github.com/users/maclover7","html_url":"https://github.com/maclover7","followers_url":"https://api.github.com/users/maclover7/followers","following_url":"https://api.github.com/users/maclover7/following{/other_user}","gists_url":"https://api.github.com/users/maclover7/gists{/gist_id}","starred_url":"https://api.github.com/users/maclover7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maclover7/subscriptions","organizations_url":"https://api.github.com/users/maclover7/orgs","repos_url":"https://api.github.com/users/maclover7/repos","events_url":"https://api.github.com/users/maclover7/events{/privacy}","received_events_url":"https://api.github.com/users/maclover7/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/27111/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/27111/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/27111/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/e30c4f600dce297b21454fdeaeda5cc94fcfc4dd","head":{"label":"maclover7:jm-xmlmini","ref":"jm-xmlmini","sha":"e30c4f600dce297b21454fdeaeda5cc94fcfc4dd","user":{"login":"maclover7","id":3020626,"avatar_url":"https://avatars.githubusercontent.com/u/3020626?v=3","gravatar_id":"","url":"https://api.github.com/users/maclover7","html_url":"https://github.com/maclover7","followers_url":"https://api.github.com/users/maclover7/followers","following_url":"https://api.github.com/users/maclover7/following{/other_user}","gists_url":"https://api.github.com/users/maclover7/gists{/gist_id}","starred_url":"https://api.github.com/users/maclover7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maclover7/subscriptions","organizations_url":"https://api.github.com/users/maclover7/orgs","repos_url":"https://api.github.com/users/maclover7/repos","events_url":"https://api.github.com/users/maclover7/events{/privacy}","received_events_url":"https://api.github.com/users/maclover7/received_events","type":"User","site_admin":false},"repo":{"id":40943063,"name":"rails","full_name":"maclover7/rails","owner":{"login":"maclover7","id":3020626,"avatar_url":"https://avatars.githubusercontent.com/u/3020626?v=3","gravatar_id":"","url":"https://api.github.com/users/maclover7","html_url":"https://github.com/maclover7","followers_url":"https://api.github.com/users/maclover7/followers","following_url":"https://api.github.com/users/maclover7/following{/other_user}","gists_url":"https://api.github.com/users/maclover7/gists{/gist_id}","starred_url":"https://api.github.com/users/maclover7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maclover7/subscriptions","organizations_url":"https://api.github.com/users/maclover7/orgs","repos_url":"https://api.github.com/users/maclover7/repos","events_url":"https://api.github.com/users/maclover7/events{/privacy}","received_events_url":"https://api.github.com/users/maclover7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maclover7/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/maclover7/rails","forks_url":"https://api.github.com/repos/maclover7/rails/forks","keys_url":"https://api.github.com/repos/maclover7/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maclover7/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maclover7/rails/teams","hooks_url":"https://api.github.com/repos/maclover7/rails/hooks","issue_events_url":"https://api.github.com/repos/maclover7/rails/issues/events{/number}","events_url":"https://api.github.com/repos/maclover7/rails/events","assignees_url":"https://api.github.com/repos/maclover7/rails/assignees{/user}","branches_url":"https://api.github.com/repos/maclover7/rails/branches{/branch}","tags_url":"https://api.github.com/repos/maclover7/rails/tags","blobs_url":"https://api.github.com/repos/maclover7/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maclover7/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maclover7/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/maclover7/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maclover7/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/maclover7/rails/languages","stargazers_url":"https://api.github.com/repos/maclover7/rails/stargazers","contributors_url":"https://api.github.com/repos/maclover7/rails/contributors","subscribers_url":"https://api.github.com/repos/maclover7/rails/subscribers","subscription_url":"https://api.github.com/repos/maclover7/rails/subscription","commits_url":"https://api.github.com/repos/maclover7/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/maclover7/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/maclover7/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/maclover7/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/maclover7/rails/contents/{+path}","compare_url":"https://api.github.com/repos/maclover7/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maclover7/rails/merges","archive_url":"https://api.github.com/repos/maclover7/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maclover7/rails/downloads","issues_url":"https://api.github.com/repos/maclover7/rails/issues{/number}","pulls_url":"https://api.github.com/repos/maclover7/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/maclover7/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/maclover7/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maclover7/rails/labels{/name}","releases_url":"https://api.github.com/repos/maclover7/rails/releases{/id}","deployments_url":"https://api.github.com/repos/maclover7/rails/deployments","created_at":"2015-08-18T01:26:06Z","updated_at":"2016-06-21T20:33:31Z","pushed_at":"2016-11-20T14:06:21Z","git_url":"git://github.com/maclover7/rails.git","ssh_url":"git@github.com:maclover7/rails.git","clone_url":"https://github.com/maclover7/rails.git","svn_url":"https://github.com/maclover7/rails","homepage":"http://rubyonrails.org","size":136825,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"64127cde8c0bfff9b88710f83a8305f1ee96374b","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","deployments_url":"https://api.github.com/repos/rails/rails/deployments","created_at":"2008-04-11T02:19:47Z","updated_at":"2016-11-20T14:07:11Z","pushed_at":"2016-11-20T14:06:26Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":350906,"stargazers_count":33439,"watchers_count":33439,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13635,"mirror_url":null,"open_issues_count":1221,"forks":13635,"open_issues":1221,"watchers":33439,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/27111"},"html":{"href":"https://github.com/rails/rails/pull/27111"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/27111"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/27111/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/27111/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/27111/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/e30c4f600dce297b21454fdeaeda5cc94fcfc4dd"}}}}
{"actor":{"display_login":"kaspth"}}