{"action":"created","issue":{"url":"https://api.github.com/repos/doctrine/DoctrineBundle/issues/245","repository_url":"https://api.github.com/repos/doctrine/DoctrineBundle","labels_url":"https://api.github.com/repos/doctrine/DoctrineBundle/issues/245/labels{/name}","comments_url":"https://api.github.com/repos/doctrine/DoctrineBundle/issues/245/comments","events_url":"https://api.github.com/repos/doctrine/DoctrineBundle/issues/245/events","html_url":"https://github.com/doctrine/DoctrineBundle/pull/245","id":26098330,"number":245,"title":"Retrieve and use tagged filters","user":{"login":"nicoschoenmaker","id":1469323,"avatar_url":"https://avatars.githubusercontent.com/u/1469323?v=3","gravatar_id":"","url":"https://api.github.com/users/nicoschoenmaker","html_url":"https://github.com/nicoschoenmaker","followers_url":"https://api.github.com/users/nicoschoenmaker/followers","following_url":"https://api.github.com/users/nicoschoenmaker/following{/other_user}","gists_url":"https://api.github.com/users/nicoschoenmaker/gists{/gist_id}","starred_url":"https://api.github.com/users/nicoschoenmaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicoschoenmaker/subscriptions","organizations_url":"https://api.github.com/users/nicoschoenmaker/orgs","repos_url":"https://api.github.com/users/nicoschoenmaker/repos","events_url":"https://api.github.com/users/nicoschoenmaker/events{/privacy}","received_events_url":"https://api.github.com/users/nicoschoenmaker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2014-01-22T15:42:33Z","updated_at":"2016-06-21T09:25:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/doctrine/DoctrineBundle/pulls/245","html_url":"https://github.com/doctrine/DoctrineBundle/pull/245","diff_url":"https://github.com/doctrine/DoctrineBundle/pull/245.diff","patch_url":"https://github.com/doctrine/DoctrineBundle/pull/245.patch"},"body":"Allows bundles to add their own filters.\r\n\r\nUsing tags for the filters feels nicer in the Symfony ecosystem. It also allows setter injection of application specific dependencies that one might want to use in a filter.\r\n\r\nThe author of a bundle can say whether a filter should be enabled by default\r\n```\r\n   my_bundle.valid_date_filter:\r\n        class: Hostnet\\MyBundle\\Filter\\ValidDateFilter\r\n        arguments: [\"@doctrine.orm.entity_manager\"]\r\n        tags:\r\n            - { name: doctrine.filter, filter_name: page_valid_date, enabled: true }\r\n```\r\n\r\nThe user of the bundle can, of course, ignore the authors suggestion and do something different in ```config.yml```:\r\n```\r\n                filters:\r\n                    page_valid_date:\r\n                        enabled: false\r\n```\r\n\r\nThe current implementation requires some adjustment in Doctrine\\ORM as well\r\n- ```Doctrine\\ORM\\EntityManager``` gets a setFilters method.\r\n- In ```Doctrine\\ORM\\Query\\FilterCollection``` $enabledFilters and $filtersState become protected.\r\n\r\nAdding filters as is done right now is still supported. Tips & tricks to improve this PR are appreciated :)"},"comment":{"url":"https://api.github.com/repos/doctrine/DoctrineBundle/issues/comments/227387267","html_url":"https://github.com/doctrine/DoctrineBundle/pull/245#issuecomment-227387267","issue_url":"https://api.github.com/repos/doctrine/DoctrineBundle/issues/245","id":227387267,"user":{"login":"kimhemsoe","id":568787,"avatar_url":"https://avatars.githubusercontent.com/u/568787?v=3","gravatar_id":"","url":"https://api.github.com/users/kimhemsoe","html_url":"https://github.com/kimhemsoe","followers_url":"https://api.github.com/users/kimhemsoe/followers","following_url":"https://api.github.com/users/kimhemsoe/following{/other_user}","gists_url":"https://api.github.com/users/kimhemsoe/gists{/gist_id}","starred_url":"https://api.github.com/users/kimhemsoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimhemsoe/subscriptions","organizations_url":"https://api.github.com/users/kimhemsoe/orgs","repos_url":"https://api.github.com/users/kimhemsoe/repos","events_url":"https://api.github.com/users/kimhemsoe/events{/privacy}","received_events_url":"https://api.github.com/users/kimhemsoe/received_events","type":"User","site_admin":false},"created_at":"2016-06-21T09:25:00Z","updated_at":"2016-06-21T09:25:00Z","body":"Is this still alive or should i close it?"}}
{"actor":{"display_login":"kimhemsoe"}}