{"action":"created","issue":{"url":"https://api.github.com/repos/reactjs/react-redux/issues/557","repository_url":"https://api.github.com/repos/reactjs/react-redux","labels_url":"https://api.github.com/repos/reactjs/react-redux/issues/557/labels{/name}","comments_url":"https://api.github.com/repos/reactjs/react-redux/issues/557/comments","events_url":"https://api.github.com/repos/reactjs/react-redux/issues/557/events","html_url":"https://github.com/reactjs/react-redux/pull/557","id":192598220,"number":557,"title":"Fixes #525 (cursor bug) by moving notify from setState callback to componentDidUpdate. [DO NOT MERGE YET - NEEDS PERF TESTING FIRST] ","user":{"login":"jimbolla","id":1851364,"avatar_url":"https://avatars.githubusercontent.com/u/1851364?v=3","gravatar_id":"","url":"https://api.github.com/users/jimbolla","html_url":"https://github.com/jimbolla","followers_url":"https://api.github.com/users/jimbolla/followers","following_url":"https://api.github.com/users/jimbolla/following{/other_user}","gists_url":"https://api.github.com/users/jimbolla/gists{/gist_id}","starred_url":"https://api.github.com/users/jimbolla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimbolla/subscriptions","organizations_url":"https://api.github.com/users/jimbolla/orgs","repos_url":"https://api.github.com/users/jimbolla/repos","events_url":"https://api.github.com/users/jimbolla/events{/privacy}","received_events_url":"https://api.github.com/users/jimbolla/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-30T15:38:46Z","updated_at":"2016-11-30T18:03:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/reactjs/react-redux/pulls/557","html_url":"https://github.com/reactjs/react-redux/pull/557","diff_url":"https://github.com/reactjs/react-redux/pull/557.diff","patch_url":"https://github.com/reactjs/react-redux/pull/557.patch"},"body":"Instead of using the `setState` callback, doing `notifyNestedSubs` in `componentDidUpdate` seems to avoid the cursor bug (#525) without the need for the compatibility setting BS. (I swear the first time I tried this, it didn't work; I must've screwed something up. /shruggie) I'll perf test this tonight when I'm at my home PC with all my test projects. Assuming that goes well, this is a much cleaner solution. Thanks @istarkov.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/reactjs/react-redux/issues/comments/263947171","html_url":"https://github.com/reactjs/react-redux/pull/557#issuecomment-263947171","issue_url":"https://api.github.com/repos/reactjs/react-redux/issues/557","id":263947171,"user":{"login":"jimbolla","id":1851364,"avatar_url":"https://avatars.githubusercontent.com/u/1851364?v=3","gravatar_id":"","url":"https://api.github.com/users/jimbolla","html_url":"https://github.com/jimbolla","followers_url":"https://api.github.com/users/jimbolla/followers","following_url":"https://api.github.com/users/jimbolla/following{/other_user}","gists_url":"https://api.github.com/users/jimbolla/gists{/gist_id}","starred_url":"https://api.github.com/users/jimbolla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimbolla/subscriptions","organizations_url":"https://api.github.com/users/jimbolla/orgs","repos_url":"https://api.github.com/users/jimbolla/repos","events_url":"https://api.github.com/users/jimbolla/events{/privacy}","received_events_url":"https://api.github.com/users/jimbolla/received_events","type":"User","site_admin":false},"created_at":"2016-11-30T18:03:21Z","updated_at":"2016-11-30T18:03:21Z","body":"Not sure yet, but what I learned is `componentDidUpdate` is called *before* the `setState` callback. Unless implementing `componentDidUpdate` adds some unexpected perf overhead, this change should perform as good or better than the previous way. But I won't be able to test for sure I'm home."}}
{"actor":{"display_login":"jimbolla"}}