{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/comments/91786751","pull_request_review_id":12299248,"id":91786751,"diff_hunk":"@@ -4,17 +4,33 @@\n   register: resolvconf\n   ignore_errors: yes\n   changed_when: false\n+  tags: facts\n+\n+- name: check kubelet","path":"roles/kubernetes/preinstall/tasks/resolvconf.yml","position":6,"original_position":6,"commit_id":"a15d626771871613f98f2bc2c45156ae6c9caece","original_commit_id":"1722ace703bf069a62ecd33ff52ef8d4a9b07904","user":{"login":"mattymo","id":1229061,"avatar_url":"https://avatars.githubusercontent.com/u/1229061?v=3","gravatar_id":"","url":"https://api.github.com/users/mattymo","html_url":"https://github.com/mattymo","followers_url":"https://api.github.com/users/mattymo/followers","following_url":"https://api.github.com/users/mattymo/following{/other_user}","gists_url":"https://api.github.com/users/mattymo/gists{/gist_id}","starred_url":"https://api.github.com/users/mattymo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattymo/subscriptions","organizations_url":"https://api.github.com/users/mattymo/orgs","repos_url":"https://api.github.com/users/mattymo/repos","events_url":"https://api.github.com/users/mattymo/events{/privacy}","received_events_url":"https://api.github.com/users/mattymo/received_events","type":"User","site_admin":false},"body":"The better check is if there's a kubelet service running, but this is almost as good.","created_at":"2016-12-09T20:11:06Z","updated_at":"2016-12-09T20:11:06Z","html_url":"https://github.com/kubernetes-incubator/kargo/pull/696#discussion_r91786751","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/696","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/comments/91786751"},"html":{"href":"https://github.com/kubernetes-incubator/kargo/pull/696#discussion_r91786751"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/696"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/696","id":96965339,"html_url":"https://github.com/kubernetes-incubator/kargo/pull/696","diff_url":"https://github.com/kubernetes-incubator/kargo/pull/696.diff","patch_url":"https://github.com/kubernetes-incubator/kargo/pull/696.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/kargo/issues/696","number":696,"state":"open","locked":false,"title":"Preconfigure dns stack early","user":{"login":"bogdando","id":2795820,"avatar_url":"https://avatars.githubusercontent.com/u/2795820?v=3","gravatar_id":"","url":"https://api.github.com/users/bogdando","html_url":"https://github.com/bogdando","followers_url":"https://api.github.com/users/bogdando/followers","following_url":"https://api.github.com/users/bogdando/following{/other_user}","gists_url":"https://api.github.com/users/bogdando/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdando/subscriptions","organizations_url":"https://api.github.com/users/bogdando/orgs","repos_url":"https://api.github.com/users/bogdando/repos","events_url":"https://api.github.com/users/bogdando/events{/privacy}","received_events_url":"https://api.github.com/users/bogdando/received_events","type":"User","site_admin":false},"body":"In order to enable offline/intranet installation cases:\r\n* Move DNS/resolvconf configuration to preinstall role. Remove\r\n  skip_dnsmasq_k8s var as not needed anymore.\r\n\r\n* Preconfigure DNS stack early, which may be the case when downloading\r\n  artifacts from intranet repositories. Do not configure\r\n  K8s DNS resolvers for hosts /etc/resolv.conf yet early (as they may be\r\n  not existing).\r\n\r\n* Reconfigure K8s DNS resolvers for hosts only after kubedns/dnsmasq \r\n  was set up and before K8s apps to be created.\r\n\r\n* Move docker install task to early stage as well and unbind it from the\r\n  etcd role's specific install path. Fix external flannel dependency on\r\n  docker role handlers. Also fix the docker restart handlers' steps\r\n  ordering to match the expected sequence (the socket then the service).\r\n\r\n* Add default resolver fact, which is\r\n  the cloud provider specific and remove hardcoded GCE resolver.\r\n\r\n* Reduce default ndots for hosts /etc/resolv.conf to 2. Multiple search\r\n  domains combined with high ndots values lead to poor performance of\r\n  DNS stack and make ansible workers to fail very often with the\r\n  \"Timeout (12s) waiting for privilege escalation prompt:\" error.\r\n\r\n* Update docs.\r\n\r\nSigned-off-by: Bogdan Dobrelya <bdobrelia@mirantis.com>","created_at":"2016-12-07T17:05:03Z","updated_at":"2016-12-09T20:11:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34916801bc99cf735b0d3e66be1cc19328631a82","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/696/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/696/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kargo/issues/696/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/kargo/statuses/a15d626771871613f98f2bc2c45156ae6c9caece","head":{"label":"bogdando:intranet_dns","ref":"intranet_dns","sha":"a15d626771871613f98f2bc2c45156ae6c9caece","user":{"login":"bogdando","id":2795820,"avatar_url":"https://avatars.githubusercontent.com/u/2795820?v=3","gravatar_id":"","url":"https://api.github.com/users/bogdando","html_url":"https://github.com/bogdando","followers_url":"https://api.github.com/users/bogdando/followers","following_url":"https://api.github.com/users/bogdando/following{/other_user}","gists_url":"https://api.github.com/users/bogdando/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdando/subscriptions","organizations_url":"https://api.github.com/users/bogdando/orgs","repos_url":"https://api.github.com/users/bogdando/repos","events_url":"https://api.github.com/users/bogdando/events{/privacy}","received_events_url":"https://api.github.com/users/bogdando/received_events","type":"User","site_admin":false},"repo":{"id":62630531,"name":"kargo","full_name":"bogdando/kargo","owner":{"login":"bogdando","id":2795820,"avatar_url":"https://avatars.githubusercontent.com/u/2795820?v=3","gravatar_id":"","url":"https://api.github.com/users/bogdando","html_url":"https://github.com/bogdando","followers_url":"https://api.github.com/users/bogdando/followers","following_url":"https://api.github.com/users/bogdando/following{/other_user}","gists_url":"https://api.github.com/users/bogdando/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdando/subscriptions","organizations_url":"https://api.github.com/users/bogdando/orgs","repos_url":"https://api.github.com/users/bogdando/repos","events_url":"https://api.github.com/users/bogdando/events{/privacy}","received_events_url":"https://api.github.com/users/bogdando/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bogdando/kargo","description":"Setup a kubernetes cluster with Ansible","fork":true,"url":"https://api.github.com/repos/bogdando/kargo","forks_url":"https://api.github.com/repos/bogdando/kargo/forks","keys_url":"https://api.github.com/repos/bogdando/kargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bogdando/kargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bogdando/kargo/teams","hooks_url":"https://api.github.com/repos/bogdando/kargo/hooks","issue_events_url":"https://api.github.com/repos/bogdando/kargo/issues/events{/number}","events_url":"https://api.github.com/repos/bogdando/kargo/events","assignees_url":"https://api.github.com/repos/bogdando/kargo/assignees{/user}","branches_url":"https://api.github.com/repos/bogdando/kargo/branches{/branch}","tags_url":"https://api.github.com/repos/bogdando/kargo/tags","blobs_url":"https://api.github.com/repos/bogdando/kargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bogdando/kargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bogdando/kargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/bogdando/kargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bogdando/kargo/statuses/{sha}","languages_url":"https://api.github.com/repos/bogdando/kargo/languages","stargazers_url":"https://api.github.com/repos/bogdando/kargo/stargazers","contributors_url":"https://api.github.com/repos/bogdando/kargo/contributors","subscribers_url":"https://api.github.com/repos/bogdando/kargo/subscribers","subscription_url":"https://api.github.com/repos/bogdando/kargo/subscription","commits_url":"https://api.github.com/repos/bogdando/kargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/bogdando/kargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/bogdando/kargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/bogdando/kargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/bogdando/kargo/contents/{+path}","compare_url":"https://api.github.com/repos/bogdando/kargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bogdando/kargo/merges","archive_url":"https://api.github.com/repos/bogdando/kargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bogdando/kargo/downloads","issues_url":"https://api.github.com/repos/bogdando/kargo/issues{/number}","pulls_url":"https://api.github.com/repos/bogdando/kargo/pulls{/number}","milestones_url":"https://api.github.com/repos/bogdando/kargo/milestones{/number}","notifications_url":"https://api.github.com/repos/bogdando/kargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bogdando/kargo/labels{/name}","releases_url":"https://api.github.com/repos/bogdando/kargo/releases{/id}","deployments_url":"https://api.github.com/repos/bogdando/kargo/deployments","created_at":"2016-07-05T11:09:31Z","updated_at":"2016-10-27T23:37:39Z","pushed_at":"2016-12-09T16:41:05Z","git_url":"git://github.com/bogdando/kargo.git","ssh_url":"git@github.com:bogdando/kargo.git","clone_url":"https://github.com/bogdando/kargo.git","svn_url":"https://github.com/bogdando/kargo","homepage":"","size":4585,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"fb774d431718f528ece265825ae5e06a7b9f042a","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":43613404,"name":"kargo","full_name":"kubernetes-incubator/kargo","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/kargo","description":"Setup a kubernetes cluster","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/kargo","forks_url":"https://api.github.com/repos/kubernetes-incubator/kargo/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/kargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/kargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/kargo/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/kargo/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/kargo/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/kargo/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/kargo/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/kargo/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/kargo/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/kargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/kargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/kargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/kargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/kargo/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/kargo/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/kargo/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/kargo/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/kargo/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/kargo/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/kargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/kargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/kargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/kargo/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/kargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/kargo/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/kargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/kargo/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/kargo/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/kargo/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/kargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/kargo/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/kargo/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/kargo/deployments","created_at":"2015-10-03T20:18:11Z","updated_at":"2016-12-09T13:49:42Z","pushed_at":"2016-12-09T18:46:17Z","git_url":"git://github.com/kubernetes-incubator/kargo.git","ssh_url":"git@github.com:kubernetes-incubator/kargo.git","clone_url":"https://github.com/kubernetes-incubator/kargo.git","svn_url":"https://github.com/kubernetes-incubator/kargo","homepage":"","size":5147,"stargazers_count":431,"watchers_count":431,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":89,"forks":136,"open_issues":89,"watchers":431,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/696"},"html":{"href":"https://github.com/kubernetes-incubator/kargo/pull/696"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/issues/696"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/issues/696/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/696/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/696/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/statuses/a15d626771871613f98f2bc2c45156ae6c9caece"}}}}
{"actor":{"display_login":"mattymo"}}