{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/30660","labels_url":"https://api.github.com/repos/saltstack/salt/issues/30660/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/30660/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/30660/events","html_url":"https://github.com/saltstack/salt/pull/30660","id":128993321,"number":30660,"title":"Revert service.mod_watch() bug introduced in Issue 21084","user":{"login":"invsblduck","id":1899464,"avatar_url":"https://avatars.githubusercontent.com/u/1899464?v=3","gravatar_id":"","url":"https://api.github.com/users/invsblduck","html_url":"https://github.com/invsblduck","followers_url":"https://api.github.com/users/invsblduck/followers","following_url":"https://api.github.com/users/invsblduck/following{/other_user}","gists_url":"https://api.github.com/users/invsblduck/gists{/gist_id}","starred_url":"https://api.github.com/users/invsblduck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invsblduck/subscriptions","organizations_url":"https://api.github.com/users/invsblduck/orgs","repos_url":"https://api.github.com/users/invsblduck/repos","events_url":"https://api.github.com/users/invsblduck/events{/privacy}","received_events_url":"https://api.github.com/users/invsblduck/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-27T01:06:44Z","updated_at":"2016-01-27T01:31:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/30660","html_url":"https://github.com/saltstack/salt/pull/30660","diff_url":"https://github.com/saltstack/salt/pull/30660.diff","patch_url":"https://github.com/saltstack/salt/pull/30660.patch"},"body":"This reverts commits 61ed479 and dd60432, which blatantly break\r\n`test=True` protections.\r\n\r\nThe code should be reverted for the following reasons:\r\n\r\n1. The block of code modified relates *purely* to variable assignment\r\n       only&#8212;it determines which action will be taken _after_ the `test`\r\n       option is checked. This block of code represents over 60% of the\r\n       function and is for reconnaissance/assignment only.\r\n2. The change was originally made because a sysv init script didn't\r\n       support the `status` argument; the correct way to work around\r\n       this in salt is by passing the `sig` argument into the service\r\n       state (as seen in Issue #7614, which was closed for this reason)."},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/175331504","html_url":"https://github.com/saltstack/salt/pull/30660#issuecomment-175331504","issue_url":"https://api.github.com/repos/saltstack/salt/issues/30660","id":175331504,"user":{"login":"steverweber","id":1800619,"avatar_url":"https://avatars.githubusercontent.com/u/1800619?v=3","gravatar_id":"","url":"https://api.github.com/users/steverweber","html_url":"https://github.com/steverweber","followers_url":"https://api.github.com/users/steverweber/followers","following_url":"https://api.github.com/users/steverweber/following{/other_user}","gists_url":"https://api.github.com/users/steverweber/gists{/gist_id}","starred_url":"https://api.github.com/users/steverweber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steverweber/subscriptions","organizations_url":"https://api.github.com/users/steverweber/orgs","repos_url":"https://api.github.com/users/steverweber/repos","events_url":"https://api.github.com/users/steverweber/events{/privacy}","received_events_url":"https://api.github.com/users/steverweber/received_events","type":"User","site_admin":false},"created_at":"2016-01-27T01:31:30Z","updated_at":"2016-01-27T01:31:30Z","body":"ah opps i see the issue.  sorry about that.  lets preform a revert and a fix.\r\n\r\n\r\n"}}