{"action":"created","issue":{"url":"https://api.github.com/repos/astropy/astropy/issues/5544","repository_url":"https://api.github.com/repos/astropy/astropy","labels_url":"https://api.github.com/repos/astropy/astropy/issues/5544/labels{/name}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/5544/comments","events_url":"https://api.github.com/repos/astropy/astropy/issues/5544/events","html_url":"https://github.com/astropy/astropy/pull/5544","id":193174144,"number":5544,"title":"io.fits: limit the number of read extensions in convenience functions","user":{"login":"juliantaylor","id":542663,"avatar_url":"https://avatars.githubusercontent.com/u/542663?v=3","gravatar_id":"","url":"https://api.github.com/users/juliantaylor","html_url":"https://github.com/juliantaylor","followers_url":"https://api.github.com/users/juliantaylor/followers","following_url":"https://api.github.com/users/juliantaylor/following{/other_user}","gists_url":"https://api.github.com/users/juliantaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/juliantaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliantaylor/subscriptions","organizations_url":"https://api.github.com/users/juliantaylor/orgs","repos_url":"https://api.github.com/users/juliantaylor/repos","events_url":"https://api.github.com/users/juliantaylor/events{/privacy}","received_events_url":"https://api.github.com/users/juliantaylor/received_events","type":"User","site_admin":false},"labels":[{"id":68702422,"url":"https://api.github.com/repos/astropy/astropy/labels/Affects-release","name":"Affects-release","color":"0052cc","default":false},{"id":145666575,"url":"https://api.github.com/repos/astropy/astropy/labels/Enhancement","name":"Enhancement","color":"fad8c7","default":false},{"id":3496818,"url":"https://api.github.com/repos/astropy/astropy/labels/io.fits","name":"io.fits","color":"c7def8","default":false},{"id":133220484,"url":"https://api.github.com/repos/astropy/astropy/labels/Performance","name":"Performance","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-02T17:35:11Z","updated_at":"2016-12-07T14:45:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/5544","html_url":"https://github.com/astropy/astropy/pull/5544","diff_url":"https://github.com/astropy/astropy/pull/5544.diff","patch_url":"https://github.com/astropy/astropy/pull/5544.patch"},"body":"In the convenience functions only read as many extensions as necessary\r\nto satisfy the users request. This can greatly increase performance when\r\none is only interested in an early subset of extensions.\r\nIt adds the `_last_read_ext` keyword to the fitsopen function so it will\r\nalso be accepted by the top level fits.open function, but this is an\r\nimplementational detail and not documented.\r\n\r\nCloses gh-4589\r\n\r\nThis is an updated version of gh-4634 and has the same effect as lazy loaded hdulists proposed in gh-5065 within the deprecation period that requires.\r\nUpdated names as suggested, split _getext extension parsing to make getdata a bit simpler.\r\nAlso added some extra explicit tests of getdata, there is likely some duplication with other tests but they are fast."},"comment":{"url":"https://api.github.com/repos/astropy/astropy/issues/comments/265465049","html_url":"https://github.com/astropy/astropy/pull/5544#issuecomment-265465049","issue_url":"https://api.github.com/repos/astropy/astropy/issues/5544","id":265465049,"user":{"login":"juliantaylor","id":542663,"avatar_url":"https://avatars.githubusercontent.com/u/542663?v=3","gravatar_id":"","url":"https://api.github.com/users/juliantaylor","html_url":"https://github.com/juliantaylor","followers_url":"https://api.github.com/users/juliantaylor/followers","following_url":"https://api.github.com/users/juliantaylor/following{/other_user}","gists_url":"https://api.github.com/users/juliantaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/juliantaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliantaylor/subscriptions","organizations_url":"https://api.github.com/users/juliantaylor/orgs","repos_url":"https://api.github.com/users/juliantaylor/repos","events_url":"https://api.github.com/users/juliantaylor/events{/privacy}","received_events_url":"https://api.github.com/users/juliantaylor/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T14:45:25Z","updated_at":"2016-12-07T14:45:25Z","body":"@astrofrog can get a confirmation that either this or the lazy loading variant will go into the next release. I want to stop worrying about this getting merged in time.\r\nIt has no changes to the user facing interface and fixes a significant issue that rules out the use of astropy for e.g. data organization tasks due to its poor performance."}}
{"actor":{"display_login":"juliantaylor"}}