{"action":"closed","number":130,"pull_request":{"url":"https://api.github.com/repos/droolsjbpm/drools-wb/pulls/130","id":60690782,"html_url":"https://github.com/droolsjbpm/drools-wb/pull/130","diff_url":"https://github.com/droolsjbpm/drools-wb/pull/130.diff","patch_url":"https://github.com/droolsjbpm/drools-wb/pull/130.patch","issue_url":"https://api.github.com/repos/droolsjbpm/drools-wb/issues/130","number":130,"state":"closed","locked":false,"title":"BZ1310208: When converting .XLS to GDT, Globals defined with short Class Names are converted to invalid Globals file","user":{"login":"manstis","id":497544,"avatar_url":"https://avatars.githubusercontent.com/u/497544?v=3","gravatar_id":"","url":"https://api.github.com/users/manstis","html_url":"https://github.com/manstis","followers_url":"https://api.github.com/users/manstis/followers","following_url":"https://api.github.com/users/manstis/following{/other_user}","gists_url":"https://api.github.com/users/manstis/gists{/gist_id}","starred_url":"https://api.github.com/users/manstis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manstis/subscriptions","organizations_url":"https://api.github.com/users/manstis/orgs","repos_url":"https://api.github.com/users/manstis/repos","events_url":"https://api.github.com/users/manstis/events{/privacy}","received_events_url":"https://api.github.com/users/manstis/received_events","type":"User","site_admin":false},"body":"See https://bugzilla.redhat.com/show_bug.cgi?id=1310208\r\n\r\nThe \"Globals\" Editor in the Workbench creates \"Globals\" with Fully Qualified Class Names; however the conversion of XLS Decision Table to Guided Decision Table creates \"Globals\" with whatever was defined in the XLS. \r\n\r\nThis is not a problem for XLS->DRL generation as a single DRL ```String``` containing ```import``` and ```global``` is generated and hence short-names can be resolved. However since Guided Decision Table->DRL generation uses a separate \"Globals\" DRL definition file that cannot contain ```imports``` short-class names fail to resolve. This PR ensures generated \"Global\" definitions are FQCNs.","created_at":"2016-02-25T14:56:47Z","updated_at":"2016-02-29T09:04:32Z","closed_at":"2016-02-29T09:04:32Z","merged_at":"2016-02-29T09:04:32Z","merge_commit_sha":"d2727deb44e805f7cc971346188742d9bdc4216a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/droolsjbpm/drools-wb/pulls/130/commits","review_comments_url":"https://api.github.com/repos/droolsjbpm/drools-wb/pulls/130/comments","review_comment_url":"https://api.github.com/repos/droolsjbpm/drools-wb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/droolsjbpm/drools-wb/issues/130/comments","statuses_url":"https://api.github.com/repos/droolsjbpm/drools-wb/statuses/9d53f8925daa3d3e65ad4401aea3300735d18eb1","head":{"label":"manstis:BZ1310208","ref":"BZ1310208","sha":"9d53f8925daa3d3e65ad4401aea3300735d18eb1","user":{"login":"manstis","id":497544,"avatar_url":"https://avatars.githubusercontent.com/u/497544?v=3","gravatar_id":"","url":"https://api.github.com/users/manstis","html_url":"https://github.com/manstis","followers_url":"https://api.github.com/users/manstis/followers","following_url":"https://api.github.com/users/manstis/following{/other_user}","gists_url":"https://api.github.com/users/manstis/gists{/gist_id}","starred_url":"https://api.github.com/users/manstis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manstis/subscriptions","organizations_url":"https://api.github.com/users/manstis/orgs","repos_url":"https://api.github.com/users/manstis/repos","events_url":"https://api.github.com/users/manstis/events{/privacy}","received_events_url":"https://api.github.com/users/manstis/received_events","type":"User","site_admin":false},"repo":{"id":35999216,"name":"drools-wb","full_name":"manstis/drools-wb","owner":{"login":"manstis","id":497544,"avatar_url":"https://avatars.githubusercontent.com/u/497544?v=3","gravatar_id":"","url":"https://api.github.com/users/manstis","html_url":"https://github.com/manstis","followers_url":"https://api.github.com/users/manstis/followers","following_url":"https://api.github.com/users/manstis/following{/other_user}","gists_url":"https://api.github.com/users/manstis/gists{/gist_id}","starred_url":"https://api.github.com/users/manstis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manstis/subscriptions","organizations_url":"https://api.github.com/users/manstis/orgs","repos_url":"https://api.github.com/users/manstis/repos","events_url":"https://api.github.com/users/manstis/events{/privacy}","received_events_url":"https://api.github.com/users/manstis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/manstis/drools-wb","description":"Drools Workbench is the web application and repository to govern Drools assets.","fork":true,"url":"https://api.github.com/repos/manstis/drools-wb","forks_url":"https://api.github.com/repos/manstis/drools-wb/forks","keys_url":"https://api.github.com/repos/manstis/drools-wb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manstis/drools-wb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manstis/drools-wb/teams","hooks_url":"https://api.github.com/repos/manstis/drools-wb/hooks","issue_events_url":"https://api.github.com/repos/manstis/drools-wb/issues/events{/number}","events_url":"https://api.github.com/repos/manstis/drools-wb/events","assignees_url":"https://api.github.com/repos/manstis/drools-wb/assignees{/user}","branches_url":"https://api.github.com/repos/manstis/drools-wb/branches{/branch}","tags_url":"https://api.github.com/repos/manstis/drools-wb/tags","blobs_url":"https://api.github.com/repos/manstis/drools-wb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manstis/drools-wb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manstis/drools-wb/git/refs{/sha}","trees_url":"https://api.github.com/repos/manstis/drools-wb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manstis/drools-wb/statuses/{sha}","languages_url":"https://api.github.com/repos/manstis/drools-wb/languages","stargazers_url":"https://api.github.com/repos/manstis/drools-wb/stargazers","contributors_url":"https://api.github.com/repos/manstis/drools-wb/contributors","subscribers_url":"https://api.github.com/repos/manstis/drools-wb/subscribers","subscription_url":"https://api.github.com/repos/manstis/drools-wb/subscription","commits_url":"https://api.github.com/repos/manstis/drools-wb/commits{/sha}","git_commits_url":"https://api.github.com/repos/manstis/drools-wb/git/commits{/sha}","comments_url":"https://api.github.com/repos/manstis/drools-wb/comments{/number}","issue_comment_url":"https://api.github.com/repos/manstis/drools-wb/issues/comments{/number}","contents_url":"https://api.github.com/repos/manstis/drools-wb/contents/{+path}","compare_url":"https://api.github.com/repos/manstis/drools-wb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manstis/drools-wb/merges","archive_url":"https://api.github.com/repos/manstis/drools-wb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manstis/drools-wb/downloads","issues_url":"https://api.github.com/repos/manstis/drools-wb/issues{/number}","pulls_url":"https://api.github.com/repos/manstis/drools-wb/pulls{/number}","milestones_url":"https://api.github.com/repos/manstis/drools-wb/milestones{/number}","notifications_url":"https://api.github.com/repos/manstis/drools-wb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manstis/drools-wb/labels{/name}","releases_url":"https://api.github.com/repos/manstis/drools-wb/releases{/id}","deployments_url":"https://api.github.com/repos/manstis/drools-wb/deployments","created_at":"2015-05-21T07:56:14Z","updated_at":"2016-01-15T12:14:08Z","pushed_at":"2016-02-26T11:05:51Z","git_url":"git://github.com/manstis/drools-wb.git","ssh_url":"git@github.com:manstis/drools-wb.git","clone_url":"https://github.com/manstis/drools-wb.git","svn_url":"https://github.com/manstis/drools-wb","homepage":"","size":132866,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"droolsjbpm:master","ref":"master","sha":"9058ac86dcc15f50fac7bb8edf915cef3b1df606","user":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"repo":{"id":10522020,"name":"drools-wb","full_name":"droolsjbpm/drools-wb","owner":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/droolsjbpm/drools-wb","description":"Drools Workbench is the web application and repository to govern Drools assets.","fork":false,"url":"https://api.github.com/repos/droolsjbpm/drools-wb","forks_url":"https://api.github.com/repos/droolsjbpm/drools-wb/forks","keys_url":"https://api.github.com/repos/droolsjbpm/drools-wb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/droolsjbpm/drools-wb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/droolsjbpm/drools-wb/teams","hooks_url":"https://api.github.com/repos/droolsjbpm/drools-wb/hooks","issue_events_url":"https://api.github.com/repos/droolsjbpm/drools-wb/issues/events{/number}","events_url":"https://api.github.com/repos/droolsjbpm/drools-wb/events","assignees_url":"https://api.github.com/repos/droolsjbpm/drools-wb/assignees{/user}","branches_url":"https://api.github.com/repos/droolsjbpm/drools-wb/branches{/branch}","tags_url":"https://api.github.com/repos/droolsjbpm/drools-wb/tags","blobs_url":"https://api.github.com/repos/droolsjbpm/drools-wb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/droolsjbpm/drools-wb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/droolsjbpm/drools-wb/git/refs{/sha}","trees_url":"https://api.github.com/repos/droolsjbpm/drools-wb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/droolsjbpm/drools-wb/statuses/{sha}","languages_url":"https://api.github.com/repos/droolsjbpm/drools-wb/languages","stargazers_url":"https://api.github.com/repos/droolsjbpm/drools-wb/stargazers","contributors_url":"https://api.github.com/repos/droolsjbpm/drools-wb/contributors","subscribers_url":"https://api.github.com/repos/droolsjbpm/drools-wb/subscribers","subscription_url":"https://api.github.com/repos/droolsjbpm/drools-wb/subscription","commits_url":"https://api.github.com/repos/droolsjbpm/drools-wb/commits{/sha}","git_commits_url":"https://api.github.com/repos/droolsjbpm/drools-wb/git/commits{/sha}","comments_url":"https://api.github.com/repos/droolsjbpm/drools-wb/comments{/number}","issue_comment_url":"https://api.github.com/repos/droolsjbpm/drools-wb/issues/comments{/number}","contents_url":"https://api.github.com/repos/droolsjbpm/drools-wb/contents/{+path}","compare_url":"https://api.github.com/repos/droolsjbpm/drools-wb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/droolsjbpm/drools-wb/merges","archive_url":"https://api.github.com/repos/droolsjbpm/drools-wb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/droolsjbpm/drools-wb/downloads","issues_url":"https://api.github.com/repos/droolsjbpm/drools-wb/issues{/number}","pulls_url":"https://api.github.com/repos/droolsjbpm/drools-wb/pulls{/number}","milestones_url":"https://api.github.com/repos/droolsjbpm/drools-wb/milestones{/number}","notifications_url":"https://api.github.com/repos/droolsjbpm/drools-wb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/droolsjbpm/drools-wb/labels{/name}","releases_url":"https://api.github.com/repos/droolsjbpm/drools-wb/releases{/id}","deployments_url":"https://api.github.com/repos/droolsjbpm/drools-wb/deployments","created_at":"2013-06-06T08:26:25Z","updated_at":"2016-01-14T16:27:02Z","pushed_at":"2016-02-29T09:04:31Z","git_url":"git://github.com/droolsjbpm/drools-wb.git","ssh_url":"git@github.com:droolsjbpm/drools-wb.git","clone_url":"https://github.com/droolsjbpm/drools-wb.git","svn_url":"https://github.com/droolsjbpm/drools-wb","homepage":"","size":132822,"stargazers_count":16,"watchers_count":16,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"open_issues_count":3,"forks":105,"open_issues":3,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/droolsjbpm/drools-wb/pulls/130"},"html":{"href":"https://github.com/droolsjbpm/drools-wb/pull/130"},"issue":{"href":"https://api.github.com/repos/droolsjbpm/drools-wb/issues/130"},"comments":{"href":"https://api.github.com/repos/droolsjbpm/drools-wb/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/droolsjbpm/drools-wb/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/droolsjbpm/drools-wb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/droolsjbpm/drools-wb/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/droolsjbpm/drools-wb/statuses/9d53f8925daa3d3e65ad4401aea3300735d18eb1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"psiroky","id":670547,"avatar_url":"https://avatars.githubusercontent.com/u/670547?v=3","gravatar_id":"","url":"https://api.github.com/users/psiroky","html_url":"https://github.com/psiroky","followers_url":"https://api.github.com/users/psiroky/followers","following_url":"https://api.github.com/users/psiroky/following{/other_user}","gists_url":"https://api.github.com/users/psiroky/gists{/gist_id}","starred_url":"https://api.github.com/users/psiroky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psiroky/subscriptions","organizations_url":"https://api.github.com/users/psiroky/orgs","repos_url":"https://api.github.com/users/psiroky/repos","events_url":"https://api.github.com/users/psiroky/events{/privacy}","received_events_url":"https://api.github.com/users/psiroky/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":2318,"deletions":2027,"changed_files":5}}