{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/61514167","id":61514167,"diff_hunk":"@@ -0,0 +1,137 @@\n+// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+// See the LICENSE file in the project root for more information.\n+\n+#include \"common.h\"\n+#include \"stablehashcode.h\"\n+#include \"typehashingalgorithms.h\"\n+\n+// DIFFERENT FROM CORERT: Hashing code currently different from CoreRT","path":"src/vm/stablehashcode.cpp","position":9,"original_position":9,"commit_id":"e04f112313c6a6a6bf6e518a5c93537386975a27","original_commit_id":"e04f112313c6a6a6bf6e518a5c93537386975a27","user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"Could you please add this comment to the specific lines that differ? I believe it should be mostly the same ... there are just a few details that differ.","created_at":"2016-04-28T22:39:53Z","updated_at":"2016-04-28T22:39:53Z","html_url":"https://github.com/dotnet/coreclr/pull/4556#discussion_r61514167","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/4556","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/61514167"},"html":{"href":"https://github.com/dotnet/coreclr/pull/4556#discussion_r61514167"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/4556"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/4556","id":67685815,"html_url":"https://github.com/dotnet/coreclr/pull/4556","diff_url":"https://github.com/dotnet/coreclr/pull/4556.diff","patch_url":"https://github.com/dotnet/coreclr/pull/4556.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/4556","number":4556,"state":"open","locked":false,"title":"Ready-to-Run support for generic methods without generic dictionary","user":{"login":"JohnChen0","id":10659588,"avatar_url":"https://avatars.githubusercontent.com/u/10659588?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnChen0","html_url":"https://github.com/JohnChen0","followers_url":"https://api.github.com/users/JohnChen0/followers","following_url":"https://api.github.com/users/JohnChen0/following{/other_user}","gists_url":"https://api.github.com/users/JohnChen0/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnChen0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnChen0/subscriptions","organizations_url":"https://api.github.com/users/JohnChen0/orgs","repos_url":"https://api.github.com/users/JohnChen0/repos","events_url":"https://api.github.com/users/JohnChen0/events{/privacy}","received_events_url":"https://api.github.com/users/JohnChen0/received_events","type":"User","site_admin":false},"body":"Add support in Ready-to-Run images for generic methods that do not use generic dictionary. The change is feature complete, but still needs more testing.","created_at":"2016-04-25T09:03:11Z","updated_at":"2016-04-28T22:39:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4eee66c718fb408f3bc89834f6718566af69a1f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/4556/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/4556/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/4556/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/e04f112313c6a6a6bf6e518a5c93537386975a27","head":{"label":"JohnChen0:r2r","ref":"r2r","sha":"e04f112313c6a6a6bf6e518a5c93537386975a27","user":{"login":"JohnChen0","id":10659588,"avatar_url":"https://avatars.githubusercontent.com/u/10659588?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnChen0","html_url":"https://github.com/JohnChen0","followers_url":"https://api.github.com/users/JohnChen0/followers","following_url":"https://api.github.com/users/JohnChen0/following{/other_user}","gists_url":"https://api.github.com/users/JohnChen0/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnChen0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnChen0/subscriptions","organizations_url":"https://api.github.com/users/JohnChen0/orgs","repos_url":"https://api.github.com/users/JohnChen0/repos","events_url":"https://api.github.com/users/JohnChen0/events{/privacy}","received_events_url":"https://api.github.com/users/JohnChen0/received_events","type":"User","site_admin":false},"repo":{"id":33200840,"name":"coreclr","full_name":"JohnChen0/coreclr","owner":{"login":"JohnChen0","id":10659588,"avatar_url":"https://avatars.githubusercontent.com/u/10659588?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnChen0","html_url":"https://github.com/JohnChen0","followers_url":"https://api.github.com/users/JohnChen0/followers","following_url":"https://api.github.com/users/JohnChen0/following{/other_user}","gists_url":"https://api.github.com/users/JohnChen0/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnChen0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnChen0/subscriptions","organizations_url":"https://api.github.com/users/JohnChen0/orgs","repos_url":"https://api.github.com/users/JohnChen0/repos","events_url":"https://api.github.com/users/JohnChen0/events{/privacy}","received_events_url":"https://api.github.com/users/JohnChen0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JohnChen0/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/JohnChen0/coreclr","forks_url":"https://api.github.com/repos/JohnChen0/coreclr/forks","keys_url":"https://api.github.com/repos/JohnChen0/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JohnChen0/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JohnChen0/coreclr/teams","hooks_url":"https://api.github.com/repos/JohnChen0/coreclr/hooks","issue_events_url":"https://api.github.com/repos/JohnChen0/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/JohnChen0/coreclr/events","assignees_url":"https://api.github.com/repos/JohnChen0/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/JohnChen0/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/JohnChen0/coreclr/tags","blobs_url":"https://api.github.com/repos/JohnChen0/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JohnChen0/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JohnChen0/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/JohnChen0/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JohnChen0/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/JohnChen0/coreclr/languages","stargazers_url":"https://api.github.com/repos/JohnChen0/coreclr/stargazers","contributors_url":"https://api.github.com/repos/JohnChen0/coreclr/contributors","subscribers_url":"https://api.github.com/repos/JohnChen0/coreclr/subscribers","subscription_url":"https://api.github.com/repos/JohnChen0/coreclr/subscription","commits_url":"https://api.github.com/repos/JohnChen0/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/JohnChen0/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/JohnChen0/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/JohnChen0/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/JohnChen0/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/JohnChen0/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JohnChen0/coreclr/merges","archive_url":"https://api.github.com/repos/JohnChen0/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JohnChen0/coreclr/downloads","issues_url":"https://api.github.com/repos/JohnChen0/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/JohnChen0/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/JohnChen0/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/JohnChen0/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JohnChen0/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/JohnChen0/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/JohnChen0/coreclr/deployments","created_at":"2015-03-31T17:56:31Z","updated_at":"2016-01-11T16:36:13Z","pushed_at":"2016-04-28T22:03:12Z","git_url":"git://github.com/JohnChen0/coreclr.git","ssh_url":"git@github.com:JohnChen0/coreclr.git","clone_url":"https://github.com/JohnChen0/coreclr.git","svn_url":"https://github.com/JohnChen0/coreclr","homepage":"","size":96144,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"661e5d078fdbbb4b0acd98a023d8a66762af5a4a","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-04-28T21:03:58Z","pushed_at":"2016-04-28T22:26:11Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"http://dotnet.github.io/","size":84124,"stargazers_count":6253,"watchers_count":6253,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1425,"mirror_url":null,"open_issues_count":817,"forks":1425,"open_issues":817,"watchers":6253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/4556"},"html":{"href":"https://github.com/dotnet/coreclr/pull/4556"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/4556"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/4556/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/4556/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/4556/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/e04f112313c6a6a6bf6e518a5c93537386975a27"}}}}