{"action":"created","comment":{"url":"https://api.github.com/repos/balloob/home-assistant/pulls/comments/59122951","id":59122951,"diff_hunk":"@@ -10,7 +10,10 @@\n     ATTR_TITLE, DOMAIN, BaseNotificationService)\n from homeassistant.helpers import validate_config\n \n-REQUIREMENTS = ['sleekxmpp==1.3.1', 'dnspython3==1.12.0']\n+REQUIREMENTS = ['sleekxmpp==1.3.1',\n+                'dnspython3==1.12.0',\n+                'pyasn1==0.1.9',\n+                'pyasn1-modules==0.0.8']","path":"homeassistant/components/notify/xmpp.py","position":8,"original_position":8,"commit_id":"33e87c2d24494382762ac8f2d8b85d74bf7f687a","original_commit_id":"33e87c2d24494382762ac8f2d8b85d74bf7f687a","user":{"login":"balloob","id":1444314,"avatar_url":"https://avatars.githubusercontent.com/u/1444314?v=3","gravatar_id":"","url":"https://api.github.com/users/balloob","html_url":"https://github.com/balloob","followers_url":"https://api.github.com/users/balloob/followers","following_url":"https://api.github.com/users/balloob/following{/other_user}","gists_url":"https://api.github.com/users/balloob/gists{/gist_id}","starred_url":"https://api.github.com/users/balloob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloob/subscriptions","organizations_url":"https://api.github.com/users/balloob/orgs","repos_url":"https://api.github.com/users/balloob/repos","events_url":"https://api.github.com/users/balloob/events{/privacy}","received_events_url":"https://api.github.com/users/balloob/received_events","type":"User","site_admin":false},"body":"The setup.py for sleekxmpp is wrong. The keyword for `setup` should be `install_requires` instead of `requires`: http://python-packaging.readthedocs.org/en/latest/dependencies.html#specifying-dependencies . This is what is causing us to having to explicitly write the requirements.\r\n\r\nI think we should open a PR with sleekxmpp to fix this issue.","created_at":"2016-04-09T22:45:49Z","updated_at":"2016-04-09T22:45:49Z","html_url":"https://github.com/balloob/home-assistant/pull/1763#discussion_r59122951","pull_request_url":"https://api.github.com/repos/balloob/home-assistant/pulls/1763","_links":{"self":{"href":"https://api.github.com/repos/balloob/home-assistant/pulls/comments/59122951"},"html":{"href":"https://github.com/balloob/home-assistant/pull/1763#discussion_r59122951"},"pull_request":{"href":"https://api.github.com/repos/balloob/home-assistant/pulls/1763"}}},"pull_request":{"url":"https://api.github.com/repos/balloob/home-assistant/pulls/1763","id":65878923,"html_url":"https://github.com/balloob/home-assistant/pull/1763","diff_url":"https://github.com/balloob/home-assistant/pull/1763.diff","patch_url":"https://github.com/balloob/home-assistant/pull/1763.patch","issue_url":"https://api.github.com/repos/balloob/home-assistant/issues/1763","number":1763,"state":"open","locked":false,"title":"Enable certificate verification and allow non-encrypted communication","user":{"login":"fabaff","id":116184,"avatar_url":"https://avatars.githubusercontent.com/u/116184?v=3","gravatar_id":"","url":"https://api.github.com/users/fabaff","html_url":"https://github.com/fabaff","followers_url":"https://api.github.com/users/fabaff/followers","following_url":"https://api.github.com/users/fabaff/following{/other_user}","gists_url":"https://api.github.com/users/fabaff/gists{/gist_id}","starred_url":"https://api.github.com/users/fabaff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabaff/subscriptions","organizations_url":"https://api.github.com/users/fabaff/orgs","repos_url":"https://api.github.com/users/fabaff/repos","events_url":"https://api.github.com/users/fabaff/events{/privacy}","received_events_url":"https://api.github.com/users/fabaff/received_events","type":"User","site_admin":false},"body":"**Description:**\r\nThis PR allows one to use the XMPP notification platform with servers which don't not support encrypted communication and for encrypted connections the verification of the certificates is enabled now.\r\n\r\n**Related issue (if applicable):** https://community.home-assistant.io/t/how-to-disable-tls-ssl-in-jabber-xmpp-notification/488\r\n\r\n**Example entry for `configuration.yaml` (if applicable):**\r\n```yaml\r\n  - platform: xmpp\r\n    name: jabber\r\n    sender: sender@jabber-server.tld\r\n    password: sender-password\r\n    recipient: recipient@jabber-server.tld\r\n    tls: False\r\n```\r\n\r\n**Checklist:**\r\n\r\nIf code communicates with devices:\r\n  - [x] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [x] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - [x] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - [x] New dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n\r\n[fork]: http://stackoverflow.com/a/7244456\r\n[squash]: https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit\r\n[ex-requir]: https://github.com/balloob/home-assistant/blob/dev/homeassistant/components/keyboard.py#L16\r\n[ex-import]: https://github.com/balloob/home-assistant/blob/dev/homeassistant/components/keyboard.py#L51\r\n\r\n\r\n","created_at":"2016-04-09T11:45:01Z","updated_at":"2016-04-09T22:45:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5828c3e50a5be26352758cd7b76c63330dcfd73","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/balloob/home-assistant/pulls/1763/commits","review_comments_url":"https://api.github.com/repos/balloob/home-assistant/pulls/1763/comments","review_comment_url":"https://api.github.com/repos/balloob/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/balloob/home-assistant/issues/1763/comments","statuses_url":"https://api.github.com/repos/balloob/home-assistant/statuses/33e87c2d24494382762ac8f2d8b85d74bf7f687a","head":{"label":"fabaff:xmpp","ref":"xmpp","sha":"33e87c2d24494382762ac8f2d8b85d74bf7f687a","user":{"login":"fabaff","id":116184,"avatar_url":"https://avatars.githubusercontent.com/u/116184?v=3","gravatar_id":"","url":"https://api.github.com/users/fabaff","html_url":"https://github.com/fabaff","followers_url":"https://api.github.com/users/fabaff/followers","following_url":"https://api.github.com/users/fabaff/following{/other_user}","gists_url":"https://api.github.com/users/fabaff/gists{/gist_id}","starred_url":"https://api.github.com/users/fabaff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabaff/subscriptions","organizations_url":"https://api.github.com/users/fabaff/orgs","repos_url":"https://api.github.com/users/fabaff/repos","events_url":"https://api.github.com/users/fabaff/events{/privacy}","received_events_url":"https://api.github.com/users/fabaff/received_events","type":"User","site_admin":false},"repo":{"id":36302973,"name":"home-assistant","full_name":"fabaff/home-assistant","owner":{"login":"fabaff","id":116184,"avatar_url":"https://avatars.githubusercontent.com/u/116184?v=3","gravatar_id":"","url":"https://api.github.com/users/fabaff","html_url":"https://github.com/fabaff","followers_url":"https://api.github.com/users/fabaff/followers","following_url":"https://api.github.com/users/fabaff/following{/other_user}","gists_url":"https://api.github.com/users/fabaff/gists{/gist_id}","starred_url":"https://api.github.com/users/fabaff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabaff/subscriptions","organizations_url":"https://api.github.com/users/fabaff/orgs","repos_url":"https://api.github.com/users/fabaff/repos","events_url":"https://api.github.com/users/fabaff/events{/privacy}","received_events_url":"https://api.github.com/users/fabaff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabaff/home-assistant","description":"Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/fabaff/home-assistant","forks_url":"https://api.github.com/repos/fabaff/home-assistant/forks","keys_url":"https://api.github.com/repos/fabaff/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabaff/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabaff/home-assistant/teams","hooks_url":"https://api.github.com/repos/fabaff/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/fabaff/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/fabaff/home-assistant/events","assignees_url":"https://api.github.com/repos/fabaff/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/fabaff/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/fabaff/home-assistant/tags","blobs_url":"https://api.github.com/repos/fabaff/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabaff/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabaff/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabaff/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabaff/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/fabaff/home-assistant/languages","stargazers_url":"https://api.github.com/repos/fabaff/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/fabaff/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/fabaff/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/fabaff/home-assistant/subscription","commits_url":"https://api.github.com/repos/fabaff/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabaff/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabaff/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabaff/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabaff/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/fabaff/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabaff/home-assistant/merges","archive_url":"https://api.github.com/repos/fabaff/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabaff/home-assistant/downloads","issues_url":"https://api.github.com/repos/fabaff/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/fabaff/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/fabaff/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/fabaff/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabaff/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/fabaff/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/fabaff/home-assistant/deployments","created_at":"2015-05-26T14:52:30Z","updated_at":"2016-01-22T12:13:41Z","pushed_at":"2016-04-09T11:35:39Z","git_url":"git://github.com/fabaff/home-assistant.git","ssh_url":"git@github.com:fabaff/home-assistant.git","clone_url":"https://github.com/fabaff/home-assistant.git","svn_url":"https://github.com/fabaff/home-assistant","homepage":"https://home-assistant.io","size":28729,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"balloob:dev","ref":"dev","sha":"c210242c80a844956f705870302682886fb47964","user":{"login":"balloob","id":1444314,"avatar_url":"https://avatars.githubusercontent.com/u/1444314?v=3","gravatar_id":"","url":"https://api.github.com/users/balloob","html_url":"https://github.com/balloob","followers_url":"https://api.github.com/users/balloob/followers","following_url":"https://api.github.com/users/balloob/following{/other_user}","gists_url":"https://api.github.com/users/balloob/gists{/gist_id}","starred_url":"https://api.github.com/users/balloob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloob/subscriptions","organizations_url":"https://api.github.com/users/balloob/orgs","repos_url":"https://api.github.com/users/balloob/repos","events_url":"https://api.github.com/users/balloob/events{/privacy}","received_events_url":"https://api.github.com/users/balloob/received_events","type":"User","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"balloob/home-assistant","owner":{"login":"balloob","id":1444314,"avatar_url":"https://avatars.githubusercontent.com/u/1444314?v=3","gravatar_id":"","url":"https://api.github.com/users/balloob","html_url":"https://github.com/balloob","followers_url":"https://api.github.com/users/balloob/followers","following_url":"https://api.github.com/users/balloob/following{/other_user}","gists_url":"https://api.github.com/users/balloob/gists{/gist_id}","starred_url":"https://api.github.com/users/balloob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloob/subscriptions","organizations_url":"https://api.github.com/users/balloob/orgs","repos_url":"https://api.github.com/users/balloob/repos","events_url":"https://api.github.com/users/balloob/events{/privacy}","received_events_url":"https://api.github.com/users/balloob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/balloob/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/balloob/home-assistant","forks_url":"https://api.github.com/repos/balloob/home-assistant/forks","keys_url":"https://api.github.com/repos/balloob/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/balloob/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/balloob/home-assistant/teams","hooks_url":"https://api.github.com/repos/balloob/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/balloob/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/balloob/home-assistant/events","assignees_url":"https://api.github.com/repos/balloob/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/balloob/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/balloob/home-assistant/tags","blobs_url":"https://api.github.com/repos/balloob/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/balloob/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/balloob/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/balloob/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/balloob/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/balloob/home-assistant/languages","stargazers_url":"https://api.github.com/repos/balloob/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/balloob/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/balloob/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/balloob/home-assistant/subscription","commits_url":"https://api.github.com/repos/balloob/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/balloob/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/balloob/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/balloob/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/balloob/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/balloob/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/balloob/home-assistant/merges","archive_url":"https://api.github.com/repos/balloob/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/balloob/home-assistant/downloads","issues_url":"https://api.github.com/repos/balloob/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/balloob/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/balloob/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/balloob/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/balloob/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/balloob/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/balloob/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2016-04-09T22:42:03Z","pushed_at":"2016-04-09T22:25:44Z","git_url":"git://github.com/balloob/home-assistant.git","ssh_url":"git@github.com:balloob/home-assistant.git","clone_url":"https://github.com/balloob/home-assistant.git","svn_url":"https://github.com/balloob/home-assistant","homepage":"https://home-assistant.io","size":55046,"stargazers_count":3135,"watchers_count":3135,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":570,"mirror_url":null,"open_issues_count":140,"forks":570,"open_issues":140,"watchers":3135,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/balloob/home-assistant/pulls/1763"},"html":{"href":"https://github.com/balloob/home-assistant/pull/1763"},"issue":{"href":"https://api.github.com/repos/balloob/home-assistant/issues/1763"},"comments":{"href":"https://api.github.com/repos/balloob/home-assistant/issues/1763/comments"},"review_comments":{"href":"https://api.github.com/repos/balloob/home-assistant/pulls/1763/comments"},"review_comment":{"href":"https://api.github.com/repos/balloob/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/balloob/home-assistant/pulls/1763/commits"},"statuses":{"href":"https://api.github.com/repos/balloob/home-assistant/statuses/33e87c2d24494382762ac8f2d8b85d74bf7f687a"}}}}