{"action":"created","comment":{"url":"https://api.github.com/repos/opentx/opentx/pulls/comments/72158891","id":72158891,"diff_hunk":"@@ -95,7 +95,7 @@ void OpenTxSimulator::start(QByteArray & ee, bool tests)\n \n void OpenTxSimulator::start(const char * filename, bool tests)\n {\n-#if defined(PCBSKY9X) && !defined(REVX)\n+#if defined(PCBSKY9X) && !defined(REVX) && !defined(AR9X)","path":"radio/src/targets/simu/opentxsimulator.cpp","position":5,"original_position":5,"commit_id":"893ae215afddf404eb0ed0d15d1fc5c3b181a1c4","original_commit_id":"893ae215afddf404eb0ed0d15d1fc5c3b181a1c4","user":{"login":"schwabe","id":1038539,"avatar_url":"https://avatars.githubusercontent.com/u/1038539?v=3","gravatar_id":"","url":"https://api.github.com/users/schwabe","html_url":"https://github.com/schwabe","followers_url":"https://api.github.com/users/schwabe/followers","following_url":"https://api.github.com/users/schwabe/following{/other_user}","gists_url":"https://api.github.com/users/schwabe/gists{/gist_id}","starred_url":"https://api.github.com/users/schwabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwabe/subscriptions","organizations_url":"https://api.github.com/users/schwabe/orgs","repos_url":"https://api.github.com/users/schwabe/repos","events_url":"https://api.github.com/users/schwabe/events{/privacy}","received_events_url":"https://api.github.com/users/schwabe/received_events","type":"User","site_admin":false},"body":"Neither am I ","created_at":"2016-07-25T22:45:33Z","updated_at":"2016-07-25T22:45:33Z","html_url":"https://github.com/opentx/opentx/pull/3666#discussion_r72158891","pull_request_url":"https://api.github.com/repos/opentx/opentx/pulls/3666","_links":{"self":{"href":"https://api.github.com/repos/opentx/opentx/pulls/comments/72158891"},"html":{"href":"https://github.com/opentx/opentx/pull/3666#discussion_r72158891"},"pull_request":{"href":"https://api.github.com/repos/opentx/opentx/pulls/3666"}}},"pull_request":{"url":"https://api.github.com/repos/opentx/opentx/pulls/3666","id":78703526,"html_url":"https://github.com/opentx/opentx/pull/3666","diff_url":"https://github.com/opentx/opentx/pull/3666.diff","patch_url":"https://github.com/opentx/opentx/pull/3666.patch","issue_url":"https://api.github.com/repos/opentx/opentx/issues/3666","number":3666,"state":"open","locked":false,"title":"Fix AR9X build and add it to regular commit tests.","user":{"login":"schwabe","id":1038539,"avatar_url":"https://avatars.githubusercontent.com/u/1038539?v=3","gravatar_id":"","url":"https://api.github.com/users/schwabe","html_url":"https://github.com/schwabe","followers_url":"https://api.github.com/users/schwabe/followers","following_url":"https://api.github.com/users/schwabe/following{/other_user}","gists_url":"https://api.github.com/users/schwabe/gists{/gist_id}","starred_url":"https://api.github.com/users/schwabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwabe/subscriptions","organizations_url":"https://api.github.com/users/schwabe/orgs","repos_url":"https://api.github.com/users/schwabe/repos","events_url":"https://api.github.com/users/schwabe/events{/privacy}","received_events_url":"https://api.github.com/users/schwabe/received_events","type":"User","site_admin":false},"body":"Note that simu still crashes on startup in the readRtc function","created_at":"2016-07-25T15:39:07Z","updated_at":"2016-07-25T22:45:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b91fa67ca80f27577684f75a82aea0b519658cb2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opentx/opentx/pulls/3666/commits","review_comments_url":"https://api.github.com/repos/opentx/opentx/pulls/3666/comments","review_comment_url":"https://api.github.com/repos/opentx/opentx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentx/opentx/issues/3666/comments","statuses_url":"https://api.github.com/repos/opentx/opentx/statuses/893ae215afddf404eb0ed0d15d1fc5c3b181a1c4","head":{"label":"opentx:schwabe/ar9x_test_and_fix","ref":"schwabe/ar9x_test_and_fix","sha":"893ae215afddf404eb0ed0d15d1fc5c3b181a1c4","user":{"login":"opentx","id":6073522,"avatar_url":"https://avatars.githubusercontent.com/u/6073522?v=3","gravatar_id":"","url":"https://api.github.com/users/opentx","html_url":"https://github.com/opentx","followers_url":"https://api.github.com/users/opentx/followers","following_url":"https://api.github.com/users/opentx/following{/other_user}","gists_url":"https://api.github.com/users/opentx/gists{/gist_id}","starred_url":"https://api.github.com/users/opentx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentx/subscriptions","organizations_url":"https://api.github.com/users/opentx/orgs","repos_url":"https://api.github.com/users/opentx/repos","events_url":"https://api.github.com/users/opentx/events{/privacy}","received_events_url":"https://api.github.com/users/opentx/received_events","type":"Organization","site_admin":false},"repo":{"id":14794708,"name":"opentx","full_name":"opentx/opentx","owner":{"login":"opentx","id":6073522,"avatar_url":"https://avatars.githubusercontent.com/u/6073522?v=3","gravatar_id":"","url":"https://api.github.com/users/opentx","html_url":"https://github.com/opentx","followers_url":"https://api.github.com/users/opentx/followers","following_url":"https://api.github.com/users/opentx/following{/other_user}","gists_url":"https://api.github.com/users/opentx/gists{/gist_id}","starred_url":"https://api.github.com/users/opentx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentx/subscriptions","organizations_url":"https://api.github.com/users/opentx/orgs","repos_url":"https://api.github.com/users/opentx/repos","events_url":"https://api.github.com/users/opentx/events{/privacy}","received_events_url":"https://api.github.com/users/opentx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentx/opentx","description":"OpenTX custom firmware for Transmitters","fork":false,"url":"https://api.github.com/repos/opentx/opentx","forks_url":"https://api.github.com/repos/opentx/opentx/forks","keys_url":"https://api.github.com/repos/opentx/opentx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentx/opentx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentx/opentx/teams","hooks_url":"https://api.github.com/repos/opentx/opentx/hooks","issue_events_url":"https://api.github.com/repos/opentx/opentx/issues/events{/number}","events_url":"https://api.github.com/repos/opentx/opentx/events","assignees_url":"https://api.github.com/repos/opentx/opentx/assignees{/user}","branches_url":"https://api.github.com/repos/opentx/opentx/branches{/branch}","tags_url":"https://api.github.com/repos/opentx/opentx/tags","blobs_url":"https://api.github.com/repos/opentx/opentx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentx/opentx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentx/opentx/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentx/opentx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentx/opentx/statuses/{sha}","languages_url":"https://api.github.com/repos/opentx/opentx/languages","stargazers_url":"https://api.github.com/repos/opentx/opentx/stargazers","contributors_url":"https://api.github.com/repos/opentx/opentx/contributors","subscribers_url":"https://api.github.com/repos/opentx/opentx/subscribers","subscription_url":"https://api.github.com/repos/opentx/opentx/subscription","commits_url":"https://api.github.com/repos/opentx/opentx/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentx/opentx/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentx/opentx/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentx/opentx/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentx/opentx/contents/{+path}","compare_url":"https://api.github.com/repos/opentx/opentx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentx/opentx/merges","archive_url":"https://api.github.com/repos/opentx/opentx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentx/opentx/downloads","issues_url":"https://api.github.com/repos/opentx/opentx/issues{/number}","pulls_url":"https://api.github.com/repos/opentx/opentx/pulls{/number}","milestones_url":"https://api.github.com/repos/opentx/opentx/milestones{/number}","notifications_url":"https://api.github.com/repos/opentx/opentx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentx/opentx/labels{/name}","releases_url":"https://api.github.com/repos/opentx/opentx/releases{/id}","deployments_url":"https://api.github.com/repos/opentx/opentx/deployments","created_at":"2013-11-29T07:02:56Z","updated_at":"2016-07-25T12:59:37Z","pushed_at":"2016-07-25T22:39:52Z","git_url":"git://github.com/opentx/opentx.git","ssh_url":"git@github.com:opentx/opentx.git","clone_url":"https://github.com/opentx/opentx.git","svn_url":"https://github.com/opentx/opentx","homepage":"","size":148262,"stargazers_count":417,"watchers_count":417,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":255,"mirror_url":null,"open_issues_count":442,"forks":255,"open_issues":442,"watchers":417,"default_branch":"master"}},"base":{"label":"opentx:next","ref":"next","sha":"3b90b0d6c0c3cdeb9f333efacf0f3621337316be","user":{"login":"opentx","id":6073522,"avatar_url":"https://avatars.githubusercontent.com/u/6073522?v=3","gravatar_id":"","url":"https://api.github.com/users/opentx","html_url":"https://github.com/opentx","followers_url":"https://api.github.com/users/opentx/followers","following_url":"https://api.github.com/users/opentx/following{/other_user}","gists_url":"https://api.github.com/users/opentx/gists{/gist_id}","starred_url":"https://api.github.com/users/opentx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentx/subscriptions","organizations_url":"https://api.github.com/users/opentx/orgs","repos_url":"https://api.github.com/users/opentx/repos","events_url":"https://api.github.com/users/opentx/events{/privacy}","received_events_url":"https://api.github.com/users/opentx/received_events","type":"Organization","site_admin":false},"repo":{"id":14794708,"name":"opentx","full_name":"opentx/opentx","owner":{"login":"opentx","id":6073522,"avatar_url":"https://avatars.githubusercontent.com/u/6073522?v=3","gravatar_id":"","url":"https://api.github.com/users/opentx","html_url":"https://github.com/opentx","followers_url":"https://api.github.com/users/opentx/followers","following_url":"https://api.github.com/users/opentx/following{/other_user}","gists_url":"https://api.github.com/users/opentx/gists{/gist_id}","starred_url":"https://api.github.com/users/opentx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentx/subscriptions","organizations_url":"https://api.github.com/users/opentx/orgs","repos_url":"https://api.github.com/users/opentx/repos","events_url":"https://api.github.com/users/opentx/events{/privacy}","received_events_url":"https://api.github.com/users/opentx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentx/opentx","description":"OpenTX custom firmware for Transmitters","fork":false,"url":"https://api.github.com/repos/opentx/opentx","forks_url":"https://api.github.com/repos/opentx/opentx/forks","keys_url":"https://api.github.com/repos/opentx/opentx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentx/opentx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentx/opentx/teams","hooks_url":"https://api.github.com/repos/opentx/opentx/hooks","issue_events_url":"https://api.github.com/repos/opentx/opentx/issues/events{/number}","events_url":"https://api.github.com/repos/opentx/opentx/events","assignees_url":"https://api.github.com/repos/opentx/opentx/assignees{/user}","branches_url":"https://api.github.com/repos/opentx/opentx/branches{/branch}","tags_url":"https://api.github.com/repos/opentx/opentx/tags","blobs_url":"https://api.github.com/repos/opentx/opentx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentx/opentx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentx/opentx/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentx/opentx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentx/opentx/statuses/{sha}","languages_url":"https://api.github.com/repos/opentx/opentx/languages","stargazers_url":"https://api.github.com/repos/opentx/opentx/stargazers","contributors_url":"https://api.github.com/repos/opentx/opentx/contributors","subscribers_url":"https://api.github.com/repos/opentx/opentx/subscribers","subscription_url":"https://api.github.com/repos/opentx/opentx/subscription","commits_url":"https://api.github.com/repos/opentx/opentx/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentx/opentx/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentx/opentx/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentx/opentx/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentx/opentx/contents/{+path}","compare_url":"https://api.github.com/repos/opentx/opentx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentx/opentx/merges","archive_url":"https://api.github.com/repos/opentx/opentx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentx/opentx/downloads","issues_url":"https://api.github.com/repos/opentx/opentx/issues{/number}","pulls_url":"https://api.github.com/repos/opentx/opentx/pulls{/number}","milestones_url":"https://api.github.com/repos/opentx/opentx/milestones{/number}","notifications_url":"https://api.github.com/repos/opentx/opentx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentx/opentx/labels{/name}","releases_url":"https://api.github.com/repos/opentx/opentx/releases{/id}","deployments_url":"https://api.github.com/repos/opentx/opentx/deployments","created_at":"2013-11-29T07:02:56Z","updated_at":"2016-07-25T12:59:37Z","pushed_at":"2016-07-25T22:39:52Z","git_url":"git://github.com/opentx/opentx.git","ssh_url":"git@github.com:opentx/opentx.git","clone_url":"https://github.com/opentx/opentx.git","svn_url":"https://github.com/opentx/opentx","homepage":"","size":148262,"stargazers_count":417,"watchers_count":417,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":255,"mirror_url":null,"open_issues_count":442,"forks":255,"open_issues":442,"watchers":417,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opentx/opentx/pulls/3666"},"html":{"href":"https://github.com/opentx/opentx/pull/3666"},"issue":{"href":"https://api.github.com/repos/opentx/opentx/issues/3666"},"comments":{"href":"https://api.github.com/repos/opentx/opentx/issues/3666/comments"},"review_comments":{"href":"https://api.github.com/repos/opentx/opentx/pulls/3666/comments"},"review_comment":{"href":"https://api.github.com/repos/opentx/opentx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentx/opentx/pulls/3666/commits"},"statuses":{"href":"https://api.github.com/repos/opentx/opentx/statuses/893ae215afddf404eb0ed0d15d1fc5c3b181a1c4"}}}}
{"actor":{"display_login":"schwabe"}}