{"action":"opened","number":1748,"pull_request":{"url":"https://api.github.com/repos/ethcore/parity/pulls/1748","id":79111632,"html_url":"https://github.com/ethcore/parity/pull/1748","diff_url":"https://github.com/ethcore/parity/pull/1748.diff","patch_url":"https://github.com/ethcore/parity/pull/1748.patch","issue_url":"https://api.github.com/repos/ethcore/parity/issues/1748","number":1748,"state":"open","locked":false,"title":"Make miner::TransactionQueue a private interface","user":{"login":"nipunn1313","id":1300387,"avatar_url":"https://avatars.githubusercontent.com/u/1300387?v=3","gravatar_id":"","url":"https://api.github.com/users/nipunn1313","html_url":"https://github.com/nipunn1313","followers_url":"https://api.github.com/users/nipunn1313/followers","following_url":"https://api.github.com/users/nipunn1313/following{/other_user}","gists_url":"https://api.github.com/users/nipunn1313/gists{/gist_id}","starred_url":"https://api.github.com/users/nipunn1313/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipunn1313/subscriptions","organizations_url":"https://api.github.com/users/nipunn1313/orgs","repos_url":"https://api.github.com/users/nipunn1313/repos","events_url":"https://api.github.com/users/nipunn1313/events{/privacy}","received_events_url":"https://api.github.com/users/nipunn1313/received_events","type":"User","site_admin":false},"body":"Noticed while investigating TransactionQueue that it is only used within the miner, so made it into a private interface.","created_at":"2016-07-27T22:53:38Z","updated_at":"2016-07-27T22:53:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethcore/parity/pulls/1748/commits","review_comments_url":"https://api.github.com/repos/ethcore/parity/pulls/1748/comments","review_comment_url":"https://api.github.com/repos/ethcore/parity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethcore/parity/issues/1748/comments","statuses_url":"https://api.github.com/repos/ethcore/parity/statuses/733a7e5dbe050bc20825b968803656308c8f67b1","head":{"label":"nipunn1313:transaction_queue_private","ref":"transaction_queue_private","sha":"733a7e5dbe050bc20825b968803656308c8f67b1","user":{"login":"nipunn1313","id":1300387,"avatar_url":"https://avatars.githubusercontent.com/u/1300387?v=3","gravatar_id":"","url":"https://api.github.com/users/nipunn1313","html_url":"https://github.com/nipunn1313","followers_url":"https://api.github.com/users/nipunn1313/followers","following_url":"https://api.github.com/users/nipunn1313/following{/other_user}","gists_url":"https://api.github.com/users/nipunn1313/gists{/gist_id}","starred_url":"https://api.github.com/users/nipunn1313/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipunn1313/subscriptions","organizations_url":"https://api.github.com/users/nipunn1313/orgs","repos_url":"https://api.github.com/users/nipunn1313/repos","events_url":"https://api.github.com/users/nipunn1313/events{/privacy}","received_events_url":"https://api.github.com/users/nipunn1313/received_events","type":"User","site_admin":false},"repo":{"id":62439810,"name":"parity","full_name":"nipunn1313/parity","owner":{"login":"nipunn1313","id":1300387,"avatar_url":"https://avatars.githubusercontent.com/u/1300387?v=3","gravatar_id":"","url":"https://api.github.com/users/nipunn1313","html_url":"https://github.com/nipunn1313","followers_url":"https://api.github.com/users/nipunn1313/followers","following_url":"https://api.github.com/users/nipunn1313/following{/other_user}","gists_url":"https://api.github.com/users/nipunn1313/gists{/gist_id}","starred_url":"https://api.github.com/users/nipunn1313/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipunn1313/subscriptions","organizations_url":"https://api.github.com/users/nipunn1313/orgs","repos_url":"https://api.github.com/users/nipunn1313/repos","events_url":"https://api.github.com/users/nipunn1313/events{/privacy}","received_events_url":"https://api.github.com/users/nipunn1313/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nipunn1313/parity","description":"Fast, light, robust Ethereum implementation","fork":true,"url":"https://api.github.com/repos/nipunn1313/parity","forks_url":"https://api.github.com/repos/nipunn1313/parity/forks","keys_url":"https://api.github.com/repos/nipunn1313/parity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nipunn1313/parity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nipunn1313/parity/teams","hooks_url":"https://api.github.com/repos/nipunn1313/parity/hooks","issue_events_url":"https://api.github.com/repos/nipunn1313/parity/issues/events{/number}","events_url":"https://api.github.com/repos/nipunn1313/parity/events","assignees_url":"https://api.github.com/repos/nipunn1313/parity/assignees{/user}","branches_url":"https://api.github.com/repos/nipunn1313/parity/branches{/branch}","tags_url":"https://api.github.com/repos/nipunn1313/parity/tags","blobs_url":"https://api.github.com/repos/nipunn1313/parity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nipunn1313/parity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nipunn1313/parity/git/refs{/sha}","trees_url":"https://api.github.com/repos/nipunn1313/parity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nipunn1313/parity/statuses/{sha}","languages_url":"https://api.github.com/repos/nipunn1313/parity/languages","stargazers_url":"https://api.github.com/repos/nipunn1313/parity/stargazers","contributors_url":"https://api.github.com/repos/nipunn1313/parity/contributors","subscribers_url":"https://api.github.com/repos/nipunn1313/parity/subscribers","subscription_url":"https://api.github.com/repos/nipunn1313/parity/subscription","commits_url":"https://api.github.com/repos/nipunn1313/parity/commits{/sha}","git_commits_url":"https://api.github.com/repos/nipunn1313/parity/git/commits{/sha}","comments_url":"https://api.github.com/repos/nipunn1313/parity/comments{/number}","issue_comment_url":"https://api.github.com/repos/nipunn1313/parity/issues/comments{/number}","contents_url":"https://api.github.com/repos/nipunn1313/parity/contents/{+path}","compare_url":"https://api.github.com/repos/nipunn1313/parity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nipunn1313/parity/merges","archive_url":"https://api.github.com/repos/nipunn1313/parity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nipunn1313/parity/downloads","issues_url":"https://api.github.com/repos/nipunn1313/parity/issues{/number}","pulls_url":"https://api.github.com/repos/nipunn1313/parity/pulls{/number}","milestones_url":"https://api.github.com/repos/nipunn1313/parity/milestones{/number}","notifications_url":"https://api.github.com/repos/nipunn1313/parity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nipunn1313/parity/labels{/name}","releases_url":"https://api.github.com/repos/nipunn1313/parity/releases{/id}","deployments_url":"https://api.github.com/repos/nipunn1313/parity/deployments","created_at":"2016-07-02T07:36:42Z","updated_at":"2016-07-02T07:36:45Z","pushed_at":"2016-07-27T22:52:46Z","git_url":"git://github.com/nipunn1313/parity.git","ssh_url":"git@github.com:nipunn1313/parity.git","clone_url":"https://github.com/nipunn1313/parity.git","svn_url":"https://github.com/nipunn1313/parity","homepage":"","size":13076,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethcore:master","ref":"master","sha":"6b1e722a6b876ce922c5f269bbd2b09933e55ffa","user":{"login":"ethcore","id":14176906,"avatar_url":"https://avatars.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/ethcore","html_url":"https://github.com/ethcore","followers_url":"https://api.github.com/users/ethcore/followers","following_url":"https://api.github.com/users/ethcore/following{/other_user}","gists_url":"https://api.github.com/users/ethcore/gists{/gist_id}","starred_url":"https://api.github.com/users/ethcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethcore/subscriptions","organizations_url":"https://api.github.com/users/ethcore/orgs","repos_url":"https://api.github.com/users/ethcore/repos","events_url":"https://api.github.com/users/ethcore/events{/privacy}","received_events_url":"https://api.github.com/users/ethcore/received_events","type":"Organization","site_admin":false},"repo":{"id":46714939,"name":"parity","full_name":"ethcore/parity","owner":{"login":"ethcore","id":14176906,"avatar_url":"https://avatars.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/ethcore","html_url":"https://github.com/ethcore","followers_url":"https://api.github.com/users/ethcore/followers","following_url":"https://api.github.com/users/ethcore/following{/other_user}","gists_url":"https://api.github.com/users/ethcore/gists{/gist_id}","starred_url":"https://api.github.com/users/ethcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethcore/subscriptions","organizations_url":"https://api.github.com/users/ethcore/orgs","repos_url":"https://api.github.com/users/ethcore/repos","events_url":"https://api.github.com/users/ethcore/events{/privacy}","received_events_url":"https://api.github.com/users/ethcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethcore/parity","description":"Fast, light, robust Ethereum implementation","fork":false,"url":"https://api.github.com/repos/ethcore/parity","forks_url":"https://api.github.com/repos/ethcore/parity/forks","keys_url":"https://api.github.com/repos/ethcore/parity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethcore/parity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethcore/parity/teams","hooks_url":"https://api.github.com/repos/ethcore/parity/hooks","issue_events_url":"https://api.github.com/repos/ethcore/parity/issues/events{/number}","events_url":"https://api.github.com/repos/ethcore/parity/events","assignees_url":"https://api.github.com/repos/ethcore/parity/assignees{/user}","branches_url":"https://api.github.com/repos/ethcore/parity/branches{/branch}","tags_url":"https://api.github.com/repos/ethcore/parity/tags","blobs_url":"https://api.github.com/repos/ethcore/parity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethcore/parity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethcore/parity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethcore/parity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethcore/parity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethcore/parity/languages","stargazers_url":"https://api.github.com/repos/ethcore/parity/stargazers","contributors_url":"https://api.github.com/repos/ethcore/parity/contributors","subscribers_url":"https://api.github.com/repos/ethcore/parity/subscribers","subscription_url":"https://api.github.com/repos/ethcore/parity/subscription","commits_url":"https://api.github.com/repos/ethcore/parity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethcore/parity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethcore/parity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethcore/parity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethcore/parity/contents/{+path}","compare_url":"https://api.github.com/repos/ethcore/parity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethcore/parity/merges","archive_url":"https://api.github.com/repos/ethcore/parity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethcore/parity/downloads","issues_url":"https://api.github.com/repos/ethcore/parity/issues{/number}","pulls_url":"https://api.github.com/repos/ethcore/parity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethcore/parity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethcore/parity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethcore/parity/labels{/name}","releases_url":"https://api.github.com/repos/ethcore/parity/releases{/id}","deployments_url":"https://api.github.com/repos/ethcore/parity/deployments","created_at":"2015-11-23T11:07:32Z","updated_at":"2016-07-27T18:09:56Z","pushed_at":"2016-07-27T22:53:38Z","git_url":"git://github.com/ethcore/parity.git","ssh_url":"git@github.com:ethcore/parity.git","clone_url":"https://github.com/ethcore/parity.git","svn_url":"https://github.com/ethcore/parity","homepage":"","size":19989,"stargazers_count":461,"watchers_count":461,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":74,"mirror_url":null,"open_issues_count":112,"forks":74,"open_issues":112,"watchers":461,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethcore/parity/pulls/1748"},"html":{"href":"https://github.com/ethcore/parity/pull/1748"},"issue":{"href":"https://api.github.com/repos/ethcore/parity/issues/1748"},"comments":{"href":"https://api.github.com/repos/ethcore/parity/issues/1748/comments"},"review_comments":{"href":"https://api.github.com/repos/ethcore/parity/pulls/1748/comments"},"review_comment":{"href":"https://api.github.com/repos/ethcore/parity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethcore/parity/pulls/1748/commits"},"statuses":{"href":"https://api.github.com/repos/ethcore/parity/statuses/733a7e5dbe050bc20825b968803656308c8f67b1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"nipunn1313"}}