{"push_id":1420548681,"size":3,"distinct_size":3,"ref":"refs/heads/master","head":"35247e22935a312f9a3244d757a86d7a5ae5da96","before":"e95b1e137c604a612291fd223fce89c2095cddf2","commits":[{"sha":"976c190f89daff064361af3ffa2402d704f0def6","author":{"name":"avg","email":"b24d11afb16644e3ff52469bebd6e863d3282d4e@FreeBSD.org"},"message":"MFV r308988: 7199, 7200 dsl_dataset_rollback_sync may try to free\nalready free blocks\n\n7199 dsl_dataset_rollback_sync may try to free already free blocks\n7200 no blocks must be born in a txg after a snaphot is created\n\nillumos/illumos-gate@bfaed0b91e57062c38bc16b4f89db3c8f0052a9b\nhttps://github.com/illumos/illumos-gate/commit/bfaed0b91e57062c38bc16b4f89db3c8f0052a9b\n\nhttps://www.illumos.org/issues/7199\n  dsl_dataset_rollback_sync may try to free already freed blocks when it calls\n  dsl_destroy_head_sync_impl to destroy a temporary clone.\n  That happens if a snapshot to which we are rolling back and from which the\n  clone is created has some ZIL records.\n\nhttps://www.illumos.org/issues/7200\n  No new blocks must be born in a dataset in the same TXG after a snapshot of the\n  dataset is taken.\n  Those blocks would have the same blk_birth as the dataset's ds_prev_snap_txg\n  and as such they would be presumed to belong o the snapshot while in fact they\n  do not.\n  All the datasets must be clean before sync tasks are run, so the described\n  scenario may happen only if one of the sync tasks dirties the dataset and\n  another sync task takes its snapshot.\n  Then, there will be another sync pass because of the dirty data and the new\n  blocks will be born in the same TXG when the data is written out.\n  It seems that almost all of the existing sync tasks modify only MOS and do not\n  dirty any objsets.\n  The only exception that I've been able to identify so far is the rollback which\n  can modify an objset when it zeroes out the objset's ZIL.\n\nReviewed by: Matthew Ahrens <mahrens@delphix.com>\nReviewed by: Brad Lewis <brad.lewis@delphix.com>\nApproved by: Gordon Ross <gordon.w.ross@gmail.com>\nAuthor: Andriy Gapon <andriy.gapon@clusterhq.com>\n\nMFC after:\t3 weeks","distinct":true,"url":"https://api.github.com/repos/freebsd/freebsd/commits/976c190f89daff064361af3ffa2402d704f0def6"},{"sha":"f807b35944a11bbfc24d7f2971bcee70c54fa138","author":{"name":"avg","email":"b24d11afb16644e3ff52469bebd6e863d3282d4e@FreeBSD.org"},"message":"MFV r308990: 7181 race between zfs_mount and zfs_ioc_rollback\n\nillumos/illumos-gate@90f2c094b3822f4825f21cef2c2faf7d03b55139\nhttps://github.com/illumos/illumos-gate/commit/90f2c094b3822f4825f21cef2c2faf7d03b55139\n\nhttps://www.illumos.org/issues/7181\n  zfsvfs_setup() is called in both zfs_mount and zfs_resume_fs paths.\n  dmu_objset_set_user(zfsvfs->z_os, zfsvfs) is called early in zfsvfs_setup()\n  before the setup is actually completed,\n  thus an under-constructed zfsvfs becomes visible.\n  Additionally, there is nothing to serialize the two call paths. As a result two\n  threads can step on each other's toes.\n  assertion failed: zilog->zl_clean_taskq == NULL, file:\n  ../../common/fs/zfs/zil.c, line: 1772\n\n  > $c\n  vpanic()\n  0xfffffffffbdf6928()\n  zil_open+0x45(ffffff1bbc5dd000, fffffffff7993880)\n  zfsvfs_setup+0x84(ffffffb378d77000, 0)\n  zfs_resume_fs+0x132(ffffffb378d77000, ffffffb37ddcf000)\n  zfs_ioc_rollback+0x96(ffffffb37ddcf000, ffffff01dcdc4cd0, ffffff01aa091000)\n  zfsdev_ioctl+0x215(10a00000000, 5a19, 80465f8, 100003, ffffff01ab318368,\n  ffffff0004b59e58)\n  cdev_ioctl+0x39(10a00000000, 5a19, 80465f8, 100003, ffffff01ab318368,\n  ffffff0004b59e58)\n  spec_ioctl+0x60(ffffff0197737700, 5a19, 80465f8, 100003,\n  ffffff01ab318368, ffffff0004b59e58)\n  fop_ioctl+0x55(ffffff0197737700, 5a19, 80465f8, 100003,\n  ffffff01ab318368, ffffff0004b59e58)\n  ioctl+0x9b(7, 5a19, 80465f8)\n  sys_syscall32+0x1f7()\n\n  > ffffff1bbc5dd000::print objset_t os_zil\n  os_zil = 0xffffff1c053cf7c0\n  > 0xffffff1c053cf7c0::print zilog_t zl_clean_taskq\n\nReviewed by: Matthew Ahrens <mahrens@delphix.com>\nApproved by: Gordon Ross <gordon.w.ross@gmail.com>\nAuthor: Andriy Gapon <andriy.gapon@clusterhq.com>\n\nMFC after:\t2 weeks","distinct":true,"url":"https://api.github.com/repos/freebsd/freebsd/commits/f807b35944a11bbfc24d7f2971bcee70c54fa138"},{"sha":"35247e22935a312f9a3244d757a86d7a5ae5da96","author":{"name":"brueffer","email":"3773b0dbb1b9f1832085e105c5fd200d81ae554e@FreeBSD.org"},"message":"Sync the rtwn(4) entry with the manpage.","distinct":true,"url":"https://api.github.com/repos/freebsd/freebsd/commits/35247e22935a312f9a3244d757a86d7a5ae5da96"}]}
{"actor":{"display_login":"uqs"}}