{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments/61630793","id":61630793,"diff_hunk":"@@ -662,12 +659,19 @@ inline uint8_t get_nibble_from_character(int character) {\n   const char* dec = \"0123456789\";\n   const char* lower = \"abcdef\";\n   const char* upper = \"ABCDEF\";\n-  const char* p = nullptr;\n-  if ((p = strchr(dec, character))) {\n+  const char* p = p = strchr(dec, character);","path":"source/util/hex_float.h","position":25,"original_position":25,"commit_id":"fdbcfbe8ba02d88ee8ac75eb08112ffad2574cee","original_commit_id":"fdbcfbe8ba02d88ee8ac75eb08112ffad2574cee","user":{"login":"dekimir","id":1635074,"avatar_url":"https://avatars.githubusercontent.com/u/1635074?v=3","gravatar_id":"","url":"https://api.github.com/users/dekimir","html_url":"https://github.com/dekimir","followers_url":"https://api.github.com/users/dekimir/followers","following_url":"https://api.github.com/users/dekimir/following{/other_user}","gists_url":"https://api.github.com/users/dekimir/gists{/gist_id}","starred_url":"https://api.github.com/users/dekimir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dekimir/subscriptions","organizations_url":"https://api.github.com/users/dekimir/orgs","repos_url":"https://api.github.com/users/dekimir/repos","events_url":"https://api.github.com/users/dekimir/events{/privacy}","received_events_url":"https://api.github.com/users/dekimir/received_events","type":"User","site_admin":false},"body":"Interestingly, this line seems to break the gcc build (see \"checks have failed\" below).","created_at":"2016-04-29T19:12:30Z","updated_at":"2016-04-29T19:12:30Z","html_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/206#discussion_r61630793","pull_request_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/206","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments/61630793"},"html":{"href":"https://github.com/KhronosGroup/SPIRV-Tools/pull/206#discussion_r61630793"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/206"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/206","id":68417192,"html_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/206","diff_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/206.diff","patch_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/206.patch","issue_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/206","number":206,"state":"open","locked":false,"title":"Fix several warnings exposed in MSVS.","user":{"login":"null77","id":541607,"avatar_url":"https://avatars.githubusercontent.com/u/541607?v=3","gravatar_id":"","url":"https://api.github.com/users/null77","html_url":"https://github.com/null77","followers_url":"https://api.github.com/users/null77/followers","following_url":"https://api.github.com/users/null77/following{/other_user}","gists_url":"https://api.github.com/users/null77/gists{/gist_id}","starred_url":"https://api.github.com/users/null77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/null77/subscriptions","organizations_url":"https://api.github.com/users/null77/orgs","repos_url":"https://api.github.com/users/null77/repos","events_url":"https://api.github.com/users/null77/events{/privacy}","received_events_url":"https://api.github.com/users/null77/received_events","type":"User","site_admin":false},"body":"diagnostic.cpp:\r\n- unreachable code\r\n\r\noperand.cpp\r\n- conversion between int and uint32_t\r\n- unreachable code\r\n\r\ntext.cpp:\r\n- assignment within conditional expression\r\n\r\nhex_float.h:\r\n- assignment within conditional expression\r\n- conversion from 'const int' to 'unsigned int'\r\n- unreachable code\r\n\r\nvalidate_id.cpp\r\n- forcing value to bool 'true' or 'false'\r\n\r\nvalidate_types.cpp:\r\n- forcing value to bool 'true' or 'false'","created_at":"2016-04-29T18:53:26Z","updated_at":"2016-04-29T19:12:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef2d9f45cdf9230e1aa746a2d33f7b34296bc719","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/206/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/206/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/206/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/fdbcfbe8ba02d88ee8ac75eb08112ffad2574cee","head":{"label":"null77:fix-warnings","ref":"fix-warnings","sha":"fdbcfbe8ba02d88ee8ac75eb08112ffad2574cee","user":{"login":"null77","id":541607,"avatar_url":"https://avatars.githubusercontent.com/u/541607?v=3","gravatar_id":"","url":"https://api.github.com/users/null77","html_url":"https://github.com/null77","followers_url":"https://api.github.com/users/null77/followers","following_url":"https://api.github.com/users/null77/following{/other_user}","gists_url":"https://api.github.com/users/null77/gists{/gist_id}","starred_url":"https://api.github.com/users/null77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/null77/subscriptions","organizations_url":"https://api.github.com/users/null77/orgs","repos_url":"https://api.github.com/users/null77/repos","events_url":"https://api.github.com/users/null77/events{/privacy}","received_events_url":"https://api.github.com/users/null77/received_events","type":"User","site_admin":false},"repo":{"id":57405462,"name":"SPIRV-Tools","full_name":"null77/SPIRV-Tools","owner":{"login":"null77","id":541607,"avatar_url":"https://avatars.githubusercontent.com/u/541607?v=3","gravatar_id":"","url":"https://api.github.com/users/null77","html_url":"https://github.com/null77","followers_url":"https://api.github.com/users/null77/followers","following_url":"https://api.github.com/users/null77/following{/other_user}","gists_url":"https://api.github.com/users/null77/gists{/gist_id}","starred_url":"https://api.github.com/users/null77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/null77/subscriptions","organizations_url":"https://api.github.com/users/null77/orgs","repos_url":"https://api.github.com/users/null77/repos","events_url":"https://api.github.com/users/null77/events{/privacy}","received_events_url":"https://api.github.com/users/null77/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/null77/SPIRV-Tools","description":"","fork":true,"url":"https://api.github.com/repos/null77/SPIRV-Tools","forks_url":"https://api.github.com/repos/null77/SPIRV-Tools/forks","keys_url":"https://api.github.com/repos/null77/SPIRV-Tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/null77/SPIRV-Tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/null77/SPIRV-Tools/teams","hooks_url":"https://api.github.com/repos/null77/SPIRV-Tools/hooks","issue_events_url":"https://api.github.com/repos/null77/SPIRV-Tools/issues/events{/number}","events_url":"https://api.github.com/repos/null77/SPIRV-Tools/events","assignees_url":"https://api.github.com/repos/null77/SPIRV-Tools/assignees{/user}","branches_url":"https://api.github.com/repos/null77/SPIRV-Tools/branches{/branch}","tags_url":"https://api.github.com/repos/null77/SPIRV-Tools/tags","blobs_url":"https://api.github.com/repos/null77/SPIRV-Tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/null77/SPIRV-Tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/null77/SPIRV-Tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/null77/SPIRV-Tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/null77/SPIRV-Tools/statuses/{sha}","languages_url":"https://api.github.com/repos/null77/SPIRV-Tools/languages","stargazers_url":"https://api.github.com/repos/null77/SPIRV-Tools/stargazers","contributors_url":"https://api.github.com/repos/null77/SPIRV-Tools/contributors","subscribers_url":"https://api.github.com/repos/null77/SPIRV-Tools/subscribers","subscription_url":"https://api.github.com/repos/null77/SPIRV-Tools/subscription","commits_url":"https://api.github.com/repos/null77/SPIRV-Tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/null77/SPIRV-Tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/null77/SPIRV-Tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/null77/SPIRV-Tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/null77/SPIRV-Tools/contents/{+path}","compare_url":"https://api.github.com/repos/null77/SPIRV-Tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/null77/SPIRV-Tools/merges","archive_url":"https://api.github.com/repos/null77/SPIRV-Tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/null77/SPIRV-Tools/downloads","issues_url":"https://api.github.com/repos/null77/SPIRV-Tools/issues{/number}","pulls_url":"https://api.github.com/repos/null77/SPIRV-Tools/pulls{/number}","milestones_url":"https://api.github.com/repos/null77/SPIRV-Tools/milestones{/number}","notifications_url":"https://api.github.com/repos/null77/SPIRV-Tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/null77/SPIRV-Tools/labels{/name}","releases_url":"https://api.github.com/repos/null77/SPIRV-Tools/releases{/id}","deployments_url":"https://api.github.com/repos/null77/SPIRV-Tools/deployments","created_at":"2016-04-29T18:37:34Z","updated_at":"2016-04-29T18:37:35Z","pushed_at":"2016-04-29T18:53:03Z","git_url":"git://github.com/null77/SPIRV-Tools.git","ssh_url":"git@github.com:null77/SPIRV-Tools.git","clone_url":"https://github.com/null77/SPIRV-Tools.git","svn_url":"https://github.com/null77/SPIRV-Tools","homepage":null,"size":1607,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"13877a3b0e9d9e3217f726178f6d26f1bf1867cc","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":45981801,"name":"SPIRV-Tools","full_name":"KhronosGroup/SPIRV-Tools","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/SPIRV-Tools","description":"","fork":false,"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools","forks_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/forks","keys_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/events","assignees_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/merges","archive_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/deployments","created_at":"2015-11-11T12:56:25Z","updated_at":"2016-04-29T14:18:00Z","pushed_at":"2016-04-29T18:58:40Z","git_url":"git://github.com/KhronosGroup/SPIRV-Tools.git","ssh_url":"git@github.com:KhronosGroup/SPIRV-Tools.git","clone_url":"https://github.com/KhronosGroup/SPIRV-Tools.git","svn_url":"https://github.com/KhronosGroup/SPIRV-Tools","homepage":null,"size":2006,"stargazers_count":118,"watchers_count":118,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":12,"forks":27,"open_issues":12,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/206"},"html":{"href":"https://github.com/KhronosGroup/SPIRV-Tools/pull/206"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/206"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/206/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/206/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/206/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/fdbcfbe8ba02d88ee8ac75eb08112ffad2574cee"}}}}