{"action":"created","issue":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/5283","repository_url":"https://api.github.com/repos/ampproject/amphtml","labels_url":"https://api.github.com/repos/ampproject/amphtml/issues/5283/labels{/name}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/5283/comments","events_url":"https://api.github.com/repos/ampproject/amphtml/issues/5283/events","html_url":"https://github.com/ampproject/amphtml/pull/5283","id":179829396,"number":5283,"title":"Amp reddit extension","user":{"login":"samiamorwas","id":2023433,"avatar_url":"https://avatars.githubusercontent.com/u/2023433?v=3","gravatar_id":"","url":"https://api.github.com/users/samiamorwas","html_url":"https://github.com/samiamorwas","followers_url":"https://api.github.com/users/samiamorwas/followers","following_url":"https://api.github.com/users/samiamorwas/following{/other_user}","gists_url":"https://api.github.com/users/samiamorwas/gists{/gist_id}","starred_url":"https://api.github.com/users/samiamorwas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samiamorwas/subscriptions","organizations_url":"https://api.github.com/users/samiamorwas/orgs","repos_url":"https://api.github.com/users/samiamorwas/repos","events_url":"https://api.github.com/users/samiamorwas/events{/privacy}","received_events_url":"https://api.github.com/users/samiamorwas/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ampproject/amphtml/labels/3P","name":"3P","color":"006b75"},{"url":"https://api.github.com/repos/ampproject/amphtml/labels/LGTM","name":"LGTM","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"erwinmombay","id":354746,"avatar_url":"https://avatars.githubusercontent.com/u/354746?v=3","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false},"assignees":[{"login":"erwinmombay","id":354746,"avatar_url":"https://avatars.githubusercontent.com/u/354746?v=3","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false},{"login":"lannka","id":8496897,"avatar_url":"https://avatars.githubusercontent.com/u/8496897?v=3","gravatar_id":"","url":"https://api.github.com/users/lannka","html_url":"https://github.com/lannka","followers_url":"https://api.github.com/users/lannka/followers","following_url":"https://api.github.com/users/lannka/following{/other_user}","gists_url":"https://api.github.com/users/lannka/gists{/gist_id}","starred_url":"https://api.github.com/users/lannka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lannka/subscriptions","organizations_url":"https://api.github.com/users/lannka/orgs","repos_url":"https://api.github.com/users/lannka/repos","events_url":"https://api.github.com/users/lannka/events{/privacy}","received_events_url":"https://api.github.com/users/lannka/received_events","type":"User","site_admin":false}],"milestone":null,"comments":19,"created_at":"2016-09-28T17:00:35Z","updated_at":"2016-10-18T22:23:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/5283","html_url":"https://github.com/ampproject/amphtml/pull/5283","diff_url":"https://github.com/ampproject/amphtml/pull/5283.diff","patch_url":"https://github.com/ampproject/amphtml/pull/5283.patch"},"body":"Reddit embeds appear to require iframes bootstrapped with external scripts, but I'm not sure if there are performance concerns with this approach. In the process of getting a corporate CLA taken care of."},"comment":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/comments/254657029","html_url":"https://github.com/ampproject/amphtml/pull/5283#issuecomment-254657029","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/5283","id":254657029,"user":{"login":"samiamorwas","id":2023433,"avatar_url":"https://avatars.githubusercontent.com/u/2023433?v=3","gravatar_id":"","url":"https://api.github.com/users/samiamorwas","html_url":"https://github.com/samiamorwas","followers_url":"https://api.github.com/users/samiamorwas/followers","following_url":"https://api.github.com/users/samiamorwas/following{/other_user}","gists_url":"https://api.github.com/users/samiamorwas/gists{/gist_id}","starred_url":"https://api.github.com/users/samiamorwas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samiamorwas/subscriptions","organizations_url":"https://api.github.com/users/samiamorwas/orgs","repos_url":"https://api.github.com/users/samiamorwas/repos","events_url":"https://api.github.com/users/samiamorwas/events{/privacy}","received_events_url":"https://api.github.com/users/samiamorwas/received_events","type":"User","site_admin":false},"created_at":"2016-10-18T22:23:34Z","updated_at":"2016-10-18T22:23:34Z","body":"Sorry about the delay, I've been on vacation.\r\n\r\n@lannka Thanks for checking that out!\r\n\r\n@honeybadgerdontcare Those attributes need to be passed into the 3p script, which seems to get data attributes passed in as a parameter by default. Is there a better way to name them and still access them correctly from the element? (I took this from the facebook and twitter 3p scripts, which also seem to be using data attributes to pass required attributes).\r\n\r\nIs there a recommended way to document the requirements for other attributes inside the code? If not, I can provide it here."}}
{"actor":{"display_login":"samiamorwas"}}