{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/dxr/issues/541","repository_url":"https://api.github.com/repos/mozilla/dxr","labels_url":"https://api.github.com/repos/mozilla/dxr/issues/541/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/dxr/issues/541/comments","events_url":"https://api.github.com/repos/mozilla/dxr/issues/541/events","html_url":"https://github.com/mozilla/dxr/pull/541","id":154120775,"number":541,"title":"Path promotion, take 2","user":{"login":"pelmers","id":2406051,"avatar_url":"https://avatars.githubusercontent.com/u/2406051?v=3","gravatar_id":"","url":"https://api.github.com/users/pelmers","html_url":"https://github.com/pelmers","followers_url":"https://api.github.com/users/pelmers/followers","following_url":"https://api.github.com/users/pelmers/following{/other_user}","gists_url":"https://api.github.com/users/pelmers/gists{/gist_id}","starred_url":"https://api.github.com/users/pelmers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelmers/subscriptions","organizations_url":"https://api.github.com/users/pelmers/orgs","repos_url":"https://api.github.com/users/pelmers/repos","events_url":"https://api.github.com/users/pelmers/events{/privacy}","received_events_url":"https://api.github.com/users/pelmers/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2016-05-10T22:26:27Z","updated_at":"2016-05-19T04:35:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/dxr/pulls/541","html_url":"https://github.com/mozilla/dxr/pull/541","diff_url":"https://github.com/mozilla/dxr/pull/541.diff","patch_url":"https://github.com/mozilla/dxr/pull/541.patch"},"body":"Replaces #443 \r\n\r\nI update the previous work on path promotion to the latest head, passing all tests. I remove the path highlighting code because @kleintom has a much better one in #519.\r\nI draw a box on the right side of search results that holds up to 5 path results for single unfiltered term searches.\r\nRemark: the switch tree selector then shows up to the left of this box, rather than the far right of the screen. When the box does not appear then it's at the far right. (well, it's possible 'absolute' the thing to the right always...)"},"comment":{"url":"https://api.github.com/repos/mozilla/dxr/issues/comments/220225563","html_url":"https://github.com/mozilla/dxr/pull/541#issuecomment-220225563","issue_url":"https://api.github.com/repos/mozilla/dxr/issues/541","id":220225563,"user":{"login":"kleintom","id":632915,"avatar_url":"https://avatars.githubusercontent.com/u/632915?v=3","gravatar_id":"","url":"https://api.github.com/users/kleintom","html_url":"https://github.com/kleintom","followers_url":"https://api.github.com/users/kleintom/followers","following_url":"https://api.github.com/users/kleintom/following{/other_user}","gists_url":"https://api.github.com/users/kleintom/gists{/gist_id}","starred_url":"https://api.github.com/users/kleintom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kleintom/subscriptions","organizations_url":"https://api.github.com/users/kleintom/orgs","repos_url":"https://api.github.com/users/kleintom/repos","events_url":"https://api.github.com/users/kleintom/events{/privacy}","received_events_url":"https://api.github.com/users/kleintom/received_events","type":"User","site_admin":false},"created_at":"2016-05-19T04:35:53Z","updated_at":"2016-05-19T04:35:53Z","body":"Looks like that fixed it :-)\r\n\r\nI like the \"Showing first few of\" change, thanks!, but could we only show that when there are more results than are being displayed?\r\n\r\nI guess having the tree selector inside the path results box works, but it occurred to me that maybe we just had a miscommunication (sorry if that's the case): I had been thinking of \"below\" in the sense of the way the nav pane is below the tree selector (lower on the page) when the page loads, not in the sense of underneath.  Just throwing that out there in case you prefer it.\r\n\r\nNice touch including FILE operators in the path results :D  It looks like there's one small issue though: if you include a `-file:` negation, for example, it's referenced in the `n path results` link without the `-`.  For a concrete example, search for `-file:fish folder` in the fish tests index, which returns 4 path results, and then click on the `4 path results` link in the path results box, which takes you to the 3 results for `file:fish path:folder`.\r\n\r\n\r\n\r\n"}}