{"push_id":1078071234,"size":12,"distinct_size":12,"ref":"refs/heads/master","head":"327392d0fb122a99886b4802510f9b711042ce86","before":"5728a7fe5d6bb69598a94801cc44561f494643ec","commits":[{"sha":"51d7c98d4952da94a3f639dd1371d63b348408dc","author":{"email":"d29abca83a1597ca642bb9df8ee75044b5399044@gmail.com","name":"Marchenko Alexandr"},"message":"hyperv differencing disk","distinct":true,"url":"https://api.github.com/repos/kamigerami/vagrant/commits/51d7c98d4952da94a3f639dd1371d63b348408dc"},{"sha":"cb80286a4ac22b9c55ee3d213d980ea73b11cd14","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@gilles.cornu.name","name":"Gilles Cornu"},"message":"ansible_local: put json extra-vars in double quotes\n\nWithout this change, the JSON string generated from the `extra_vars`\nRuby hash is passed without enclosing quotes and is then not parseable\nby the ansible-playbook command when exectuted in a usual shell context.\n\nIn this changeset, the ansible (remote) unit test coverage is improved\nto cover both usage of `extra_vars` (ansible_local unit tests are still\nmissing).\n\nAdditional Notes:\n\n - Double quotes are favored to single quotes in order to allow usage of\n   any character for the variable values. For this reason additional\n   escaping is appended to JSON-inner double quotes and backslashes.\n\n - This problem was not affecting the `ansible` remote provisioner\n   (which is running the ansible-playbook command via the childprocess\n   Ruby library). But with this change, the `verbose` output will also\n   now be correct for a copy-paste reuse.\n\n - After this change, all the \"--extra-vars\" arguments (also a var\n   file passed with the @-syntax or anything coming via the\n   `raw_arguments` option) are \"blindly\" and systematically enclosed\n   in double quoted and double-escaped.\n   This is not optimal and can potentially break with peculiar values\n   (e.g. a double quote character (\") cannot be used in a json value\n   when using `raw_arguments`). That said, I think that the current\n   solution is a reasonable trade-off, since the official `extra_vars`\n   option should now be able to cover a great majority of use cases.\n\nFix #6726","distinct":true,"url":"https://api.github.com/repos/kamigerami/vagrant/commits/cb80286a4ac22b9c55ee3d213d980ea73b11cd14"},{"sha":"47c08332773719e913833608f723e52263c0581d","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@gilles.cornu.name","name":"Gilles Cornu"},"message":"ansible_local: use double quotes instead of single quotes\n\nBefore this minor change, the '--limit' and '--start-at-task'\nansible-playbook command line arguments were enclosed into single\nquotes. Using double quotes adds a bit more flexibility, especially\nabout the task name referred by `start_at_task` option.\n\nIt also aligns with the handling of the '--extra-vars' parameter\n(see cb80286).","distinct":true,"url":"https://api.github.com/repos/kamigerami/vagrant/commits/47c08332773719e913833608f723e52263c0581d"},{"sha":"6c01aaf6aba425620751d9a7b21572a889380f72","author":{"email":"81550dbf04dfd8537ff7b3c014c6fbf86e0889dc@gmail.com","name":"Seth Vargo"},"message":"Merge pull request #7090 from mac2000/master\n\nhyperv differencing disk","distinct":true,"url":"https://api.github.com/repos/kamigerami/vagrant/commits/6c01aaf6aba425620751d9a7b21572a889380f72"},{"sha":"2c553290b80c607c0b34f36a8426dba584e3cb8b","author":{"email":"81550dbf04dfd8537ff7b3c014c6fbf86e0889dc@gmail.com","name":"Seth Vargo"},"message":"Update CHANGELOG","distinct":true,"url":"https://api.github.com/repos/kamigerami/vagrant/commits/2c553290b80c607c0b34f36a8426dba584e3cb8b"},{"sha":"cdb62d7977e9f7c5805a40df02e6ba16a185dcb9","author":{"email":"862e7d5a0fb9d140977139304c7071f53f6735e6@Nicholass-MacBook-Pro.local","name":"Nicholas Byfleet"},"message":"Fixed typo: incorrect key name for environment_path option.","distinct":true,"url":"https://api.github.com/repos/kamigerami/vagrant/commits/cdb62d7977e9f7c5805a40df02e6ba16a185dcb9"},{"sha":"e04bce860776220f892c5ba1ce33f82e5db483f3","author":{"email":"81550dbf04dfd8537ff7b3c014c6fbf86e0889dc@gmail.com","name":"Seth Vargo"},"message":"Merge pull request #7239 from nickbyfleet/master\n\nFixed typo: incorrect key name for environment_path option.","distinct":true,"url":"https://api.github.com/repos/kamigerami/vagrant/commits/e04bce860776220f892c5ba1ce33f82e5db483f3"},{"sha":"ab036ddd0bcb5d844756b48adcaef063a12b5d2f","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@gilles.cornu.name","name":"Gilles Cornu"},"message":"provisioners/ansible: don't format raw_arguments\n\nWith cb80286a4ac22b9c55ee3d213d980ea73b11cd14, the helper function\nstringify_ansible_playbook_command was also applied on the\n`raw_arguments` content, which is not wanted. Given that users have used\nthe `raw_arguments` option as a workaround to avoid the bug GH-6726,\nthis new change ensure that any `--extra-vars` option passed as a raw\nargument won't be additonally enquoted by the ansible_local\nprovisioner.\n\nThis change also improves the ansible remote provisioner verbose output,\nbut has no impact on its behaviour, which was already correct.\n\nNote that this refactoring introduces some code duplications that are not\nvery elegant (see ansible_playbook_command_for_shell_execution in\nhost.rb and execute_ansible_playbook_from_host in base.rb). I hope we\ncan find a better implementation later, but it is good enough for now\nsince all these parts are covered by corresponding unit tests (the\n`ansible_local` stuff being tested via the verbose output of the ansible\nremote provisioner).","distinct":true,"url":"https://api.github.com/repos/kamigerami/vagrant/commits/ab036ddd0bcb5d844756b48adcaef063a12b5d2f"},{"sha":"b2286388f085135cfdd4a91f4a6d0c2676875050","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@gilles.cornu.name","name":"Gilles Cornu"},"message":"provisioners/ansible: add basic config validators\n\nWith this change, the `raw_arguments` and `raw_ssh_args` options are:\n- STILL automatically converted as an Array when they are set a String\n  (no behaviour change)\n- rejected if they are not of Array data type otherwise\n\nAdditional Notes:\n- the 'as_array' tiny helper has been removed since it was no longer\n  used.\n- there is for now no deeper validation (i.e. verifying that the Array\n  elements are only *String* objects)","distinct":true,"url":"https://api.github.com/repos/kamigerami/vagrant/commits/b2286388f085135cfdd4a91f4a6d0c2676875050"},{"sha":"b6a3f0e8f1a9375a09c4546d640ebbd75d91c2ce","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@gilles.cornu.name","name":"Gilles Cornu"},"message":"Merge pull request #7103 from mitchellh/gildegoma/fix-6726\n\nansible_local: use double quoting for 'extra-vars', 'limit' and 'start-at-task' options (except if defined via `raw_arguments` option)","distinct":true,"url":"https://api.github.com/repos/kamigerami/vagrant/commits/b6a3f0e8f1a9375a09c4546d640ebbd75d91c2ce"},{"sha":"afb9af1549fe30ff7b9d6fef45a84f21e8ea7004","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@gilles.cornu.name","name":"Gilles Cornu"},"message":"Update CHANGELOG\n\n[ci skip]","distinct":true,"url":"https://api.github.com/repos/kamigerami/vagrant/commits/afb9af1549fe30ff7b9d6fef45a84f21e8ea7004"},{"sha":"327392d0fb122a99886b4802510f9b711042ce86","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@gilles.cornu.name","name":"Gilles Cornu"},"message":"Fix a CHANGELOG entry\n\n[ci skip]","distinct":true,"url":"https://api.github.com/repos/kamigerami/vagrant/commits/327392d0fb122a99886b4802510f9b711042ce86"}]}