{"action":"closed","number":31,"pull_request":{"url":"https://api.github.com/repos/behrang/YamlSwift/pulls/31","id":72609871,"html_url":"https://github.com/behrang/YamlSwift/pull/31","diff_url":"https://github.com/behrang/YamlSwift/pull/31.diff","patch_url":"https://github.com/behrang/YamlSwift/pull/31.patch","issue_url":"https://api.github.com/repos/behrang/YamlSwift/issues/31","number":31,"state":"closed","locked":false,"title":"Some refactoring for the Yaml type","user":{"login":"ole","id":5010,"avatar_url":"https://avatars.githubusercontent.com/u/5010?v=3","gravatar_id":"","url":"https://api.github.com/users/ole","html_url":"https://github.com/ole","followers_url":"https://api.github.com/users/ole/followers","following_url":"https://api.github.com/users/ole/following{/other_user}","gists_url":"https://api.github.com/users/ole/gists{/gist_id}","starred_url":"https://api.github.com/users/ole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ole/subscriptions","organizations_url":"https://api.github.com/users/ole/orgs","repos_url":"https://api.github.com/users/ole/repos","events_url":"https://api.github.com/users/ole/events{/privacy}","received_events_url":"https://api.github.com/users/ole/received_events","type":"User","site_admin":false},"body":"Most of these are minor things and I’m not sure if you like them, so feel free to not merge this or only pick the things you like. I do think the `==` function becomes clearer by switching over tuples instead of the nested switch statements. The only cases where it becomes a little tricky are `.Int` and `.Double` because they need two cases each.\r\n\r\nThe tests pass though I admit I haven’t verified whether all of the code paths I changed are executed by the tests.\r\n\r\nAs far as I can tell, these changes should have no effect on performance. I re-ran the performance tests and I did not see any discernible effect by the changes. The measured times did vary quite wildly on my machine though, so I'm not sure if that says anything. For example, in the iOS simulator the measured time fluctuated between 0.05s and 0.15s between runs (this was true on both master and on my branch).\r\n\r\nThanks for reading!","created_at":"2016-06-04T18:51:45Z","updated_at":"2016-06-05T05:00:45Z","closed_at":"2016-06-05T05:00:45Z","merged_at":"2016-06-05T05:00:45Z","merge_commit_sha":"19b7975e31108a4f3a8a01b74476b601da766040","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/behrang/YamlSwift/pulls/31/commits","review_comments_url":"https://api.github.com/repos/behrang/YamlSwift/pulls/31/comments","review_comment_url":"https://api.github.com/repos/behrang/YamlSwift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/behrang/YamlSwift/issues/31/comments","statuses_url":"https://api.github.com/repos/behrang/YamlSwift/statuses/66402347cfb519e6e46339c8fe1a6145a8999332","head":{"label":"ole:yaml-refactor","ref":"yaml-refactor","sha":"66402347cfb519e6e46339c8fe1a6145a8999332","user":{"login":"ole","id":5010,"avatar_url":"https://avatars.githubusercontent.com/u/5010?v=3","gravatar_id":"","url":"https://api.github.com/users/ole","html_url":"https://github.com/ole","followers_url":"https://api.github.com/users/ole/followers","following_url":"https://api.github.com/users/ole/following{/other_user}","gists_url":"https://api.github.com/users/ole/gists{/gist_id}","starred_url":"https://api.github.com/users/ole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ole/subscriptions","organizations_url":"https://api.github.com/users/ole/orgs","repos_url":"https://api.github.com/users/ole/repos","events_url":"https://api.github.com/users/ole/events{/privacy}","received_events_url":"https://api.github.com/users/ole/received_events","type":"User","site_admin":false},"repo":{"id":60425099,"name":"YamlSwift","full_name":"ole/YamlSwift","owner":{"login":"ole","id":5010,"avatar_url":"https://avatars.githubusercontent.com/u/5010?v=3","gravatar_id":"","url":"https://api.github.com/users/ole","html_url":"https://github.com/ole","followers_url":"https://api.github.com/users/ole/followers","following_url":"https://api.github.com/users/ole/following{/other_user}","gists_url":"https://api.github.com/users/ole/gists{/gist_id}","starred_url":"https://api.github.com/users/ole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ole/subscriptions","organizations_url":"https://api.github.com/users/ole/orgs","repos_url":"https://api.github.com/users/ole/repos","events_url":"https://api.github.com/users/ole/events{/privacy}","received_events_url":"https://api.github.com/users/ole/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ole/YamlSwift","description":"Load YAML and JSON documents using Swift","fork":true,"url":"https://api.github.com/repos/ole/YamlSwift","forks_url":"https://api.github.com/repos/ole/YamlSwift/forks","keys_url":"https://api.github.com/repos/ole/YamlSwift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ole/YamlSwift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ole/YamlSwift/teams","hooks_url":"https://api.github.com/repos/ole/YamlSwift/hooks","issue_events_url":"https://api.github.com/repos/ole/YamlSwift/issues/events{/number}","events_url":"https://api.github.com/repos/ole/YamlSwift/events","assignees_url":"https://api.github.com/repos/ole/YamlSwift/assignees{/user}","branches_url":"https://api.github.com/repos/ole/YamlSwift/branches{/branch}","tags_url":"https://api.github.com/repos/ole/YamlSwift/tags","blobs_url":"https://api.github.com/repos/ole/YamlSwift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ole/YamlSwift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ole/YamlSwift/git/refs{/sha}","trees_url":"https://api.github.com/repos/ole/YamlSwift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ole/YamlSwift/statuses/{sha}","languages_url":"https://api.github.com/repos/ole/YamlSwift/languages","stargazers_url":"https://api.github.com/repos/ole/YamlSwift/stargazers","contributors_url":"https://api.github.com/repos/ole/YamlSwift/contributors","subscribers_url":"https://api.github.com/repos/ole/YamlSwift/subscribers","subscription_url":"https://api.github.com/repos/ole/YamlSwift/subscription","commits_url":"https://api.github.com/repos/ole/YamlSwift/commits{/sha}","git_commits_url":"https://api.github.com/repos/ole/YamlSwift/git/commits{/sha}","comments_url":"https://api.github.com/repos/ole/YamlSwift/comments{/number}","issue_comment_url":"https://api.github.com/repos/ole/YamlSwift/issues/comments{/number}","contents_url":"https://api.github.com/repos/ole/YamlSwift/contents/{+path}","compare_url":"https://api.github.com/repos/ole/YamlSwift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ole/YamlSwift/merges","archive_url":"https://api.github.com/repos/ole/YamlSwift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ole/YamlSwift/downloads","issues_url":"https://api.github.com/repos/ole/YamlSwift/issues{/number}","pulls_url":"https://api.github.com/repos/ole/YamlSwift/pulls{/number}","milestones_url":"https://api.github.com/repos/ole/YamlSwift/milestones{/number}","notifications_url":"https://api.github.com/repos/ole/YamlSwift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ole/YamlSwift/labels{/name}","releases_url":"https://api.github.com/repos/ole/YamlSwift/releases{/id}","deployments_url":"https://api.github.com/repos/ole/YamlSwift/deployments","created_at":"2016-06-04T18:44:52Z","updated_at":"2016-06-04T18:44:53Z","pushed_at":"2016-06-04T18:45:17Z","git_url":"git://github.com/ole/YamlSwift.git","ssh_url":"git@github.com:ole/YamlSwift.git","clone_url":"https://github.com/ole/YamlSwift.git","svn_url":"https://github.com/ole/YamlSwift","homepage":"","size":183,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"behrang:master","ref":"master","sha":"9fdbff81a1bbac84b7eb349eec4ed24745e37691","user":{"login":"behrang","id":397111,"avatar_url":"https://avatars.githubusercontent.com/u/397111?v=3","gravatar_id":"","url":"https://api.github.com/users/behrang","html_url":"https://github.com/behrang","followers_url":"https://api.github.com/users/behrang/followers","following_url":"https://api.github.com/users/behrang/following{/other_user}","gists_url":"https://api.github.com/users/behrang/gists{/gist_id}","starred_url":"https://api.github.com/users/behrang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behrang/subscriptions","organizations_url":"https://api.github.com/users/behrang/orgs","repos_url":"https://api.github.com/users/behrang/repos","events_url":"https://api.github.com/users/behrang/events{/privacy}","received_events_url":"https://api.github.com/users/behrang/received_events","type":"User","site_admin":false},"repo":{"id":25120032,"name":"YamlSwift","full_name":"behrang/YamlSwift","owner":{"login":"behrang","id":397111,"avatar_url":"https://avatars.githubusercontent.com/u/397111?v=3","gravatar_id":"","url":"https://api.github.com/users/behrang","html_url":"https://github.com/behrang","followers_url":"https://api.github.com/users/behrang/followers","following_url":"https://api.github.com/users/behrang/following{/other_user}","gists_url":"https://api.github.com/users/behrang/gists{/gist_id}","starred_url":"https://api.github.com/users/behrang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behrang/subscriptions","organizations_url":"https://api.github.com/users/behrang/orgs","repos_url":"https://api.github.com/users/behrang/repos","events_url":"https://api.github.com/users/behrang/events{/privacy}","received_events_url":"https://api.github.com/users/behrang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/behrang/YamlSwift","description":"Load YAML and JSON documents using Swift","fork":false,"url":"https://api.github.com/repos/behrang/YamlSwift","forks_url":"https://api.github.com/repos/behrang/YamlSwift/forks","keys_url":"https://api.github.com/repos/behrang/YamlSwift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/behrang/YamlSwift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/behrang/YamlSwift/teams","hooks_url":"https://api.github.com/repos/behrang/YamlSwift/hooks","issue_events_url":"https://api.github.com/repos/behrang/YamlSwift/issues/events{/number}","events_url":"https://api.github.com/repos/behrang/YamlSwift/events","assignees_url":"https://api.github.com/repos/behrang/YamlSwift/assignees{/user}","branches_url":"https://api.github.com/repos/behrang/YamlSwift/branches{/branch}","tags_url":"https://api.github.com/repos/behrang/YamlSwift/tags","blobs_url":"https://api.github.com/repos/behrang/YamlSwift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/behrang/YamlSwift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/behrang/YamlSwift/git/refs{/sha}","trees_url":"https://api.github.com/repos/behrang/YamlSwift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/behrang/YamlSwift/statuses/{sha}","languages_url":"https://api.github.com/repos/behrang/YamlSwift/languages","stargazers_url":"https://api.github.com/repos/behrang/YamlSwift/stargazers","contributors_url":"https://api.github.com/repos/behrang/YamlSwift/contributors","subscribers_url":"https://api.github.com/repos/behrang/YamlSwift/subscribers","subscription_url":"https://api.github.com/repos/behrang/YamlSwift/subscription","commits_url":"https://api.github.com/repos/behrang/YamlSwift/commits{/sha}","git_commits_url":"https://api.github.com/repos/behrang/YamlSwift/git/commits{/sha}","comments_url":"https://api.github.com/repos/behrang/YamlSwift/comments{/number}","issue_comment_url":"https://api.github.com/repos/behrang/YamlSwift/issues/comments{/number}","contents_url":"https://api.github.com/repos/behrang/YamlSwift/contents/{+path}","compare_url":"https://api.github.com/repos/behrang/YamlSwift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/behrang/YamlSwift/merges","archive_url":"https://api.github.com/repos/behrang/YamlSwift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/behrang/YamlSwift/downloads","issues_url":"https://api.github.com/repos/behrang/YamlSwift/issues{/number}","pulls_url":"https://api.github.com/repos/behrang/YamlSwift/pulls{/number}","milestones_url":"https://api.github.com/repos/behrang/YamlSwift/milestones{/number}","notifications_url":"https://api.github.com/repos/behrang/YamlSwift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/behrang/YamlSwift/labels{/name}","releases_url":"https://api.github.com/repos/behrang/YamlSwift/releases{/id}","deployments_url":"https://api.github.com/repos/behrang/YamlSwift/deployments","created_at":"2014-10-12T13:25:49Z","updated_at":"2016-06-04T19:19:14Z","pushed_at":"2016-06-05T05:00:45Z","git_url":"git://github.com/behrang/YamlSwift.git","ssh_url":"git@github.com:behrang/YamlSwift.git","clone_url":"https://github.com/behrang/YamlSwift.git","svn_url":"https://github.com/behrang/YamlSwift","homepage":"","size":193,"stargazers_count":125,"watchers_count":125,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":7,"forks":26,"open_issues":7,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/behrang/YamlSwift/pulls/31"},"html":{"href":"https://github.com/behrang/YamlSwift/pull/31"},"issue":{"href":"https://api.github.com/repos/behrang/YamlSwift/issues/31"},"comments":{"href":"https://api.github.com/repos/behrang/YamlSwift/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/behrang/YamlSwift/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/behrang/YamlSwift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/behrang/YamlSwift/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/behrang/YamlSwift/statuses/66402347cfb519e6e46339c8fe1a6145a8999332"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"behrang","id":397111,"avatar_url":"https://avatars.githubusercontent.com/u/397111?v=3","gravatar_id":"","url":"https://api.github.com/users/behrang","html_url":"https://github.com/behrang","followers_url":"https://api.github.com/users/behrang/followers","following_url":"https://api.github.com/users/behrang/following{/other_user}","gists_url":"https://api.github.com/users/behrang/gists{/gist_id}","starred_url":"https://api.github.com/users/behrang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behrang/subscriptions","organizations_url":"https://api.github.com/users/behrang/orgs","repos_url":"https://api.github.com/users/behrang/repos","events_url":"https://api.github.com/users/behrang/events{/privacy}","received_events_url":"https://api.github.com/users/behrang/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":4,"additions":23,"deletions":82,"changed_files":1}}
{"actor":{"display_login":"behrang"}}