{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/61041144","id":61041144,"diff_hunk":"@@ -81,5 +81,5 @@ in\n   }\n   //\n   mapAttrs (v: h: mkWithAutotools stable (toVersion v) h) {\n-    v1_7_5 = \"18x6cy2xn31am97vn6jli7kmb2fbp4c8kmv7jm97vggh0x55flsc\";\n+    v1_9_0 = \"0sq8c8n7xixn2xxp35crprvh35ry18i5mcxgwh12lydwv9ks0d4k\";","path":"pkgs/development/libraries/libuv/default.nix","position":5,"original_position":5,"commit_id":"9de2efffe67c183add811921ee6a7838cbca363f","original_commit_id":"9de2efffe67c183add811921ee6a7838cbca363f","user":{"login":"gilligan","id":27668,"avatar_url":"https://avatars.githubusercontent.com/u/27668?v=3","gravatar_id":"","url":"https://api.github.com/users/gilligan","html_url":"https://github.com/gilligan","followers_url":"https://api.github.com/users/gilligan/followers","following_url":"https://api.github.com/users/gilligan/following{/other_user}","gists_url":"https://api.github.com/users/gilligan/gists{/gist_id}","starred_url":"https://api.github.com/users/gilligan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilligan/subscriptions","organizations_url":"https://api.github.com/users/gilligan/orgs","repos_url":"https://api.github.com/users/gilligan/repos","events_url":"https://api.github.com/users/gilligan/events{/privacy}","received_events_url":"https://api.github.com/users/gilligan/received_events","type":"User","site_admin":false},"body":"@adnelson I guess I should have asked someone before I did the PR. I first exposed both versions and then changed it to only expose one default version. I basically was just unsure what the idiomatic/right nix way would be for this.\r\n\r\nThanks for your feedback. I will update the PR to expose both versions.","created_at":"2016-04-26T07:45:38Z","updated_at":"2016-04-26T07:45:38Z","html_url":"https://github.com/NixOS/nixpkgs/pull/14973#discussion_r61041144","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14973","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/61041144"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/14973#discussion_r61041144"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14973"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14973","id":67727418,"html_url":"https://github.com/NixOS/nixpkgs/pull/14973","diff_url":"https://github.com/NixOS/nixpkgs/pull/14973.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/14973.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/14973","number":14973,"state":"open","locked":false,"title":"libuv: 1.7.5 -> 1.9.0","user":{"login":"gilligan","id":27668,"avatar_url":"https://avatars.githubusercontent.com/u/27668?v=3","gravatar_id":"","url":"https://api.github.com/users/gilligan","html_url":"https://github.com/gilligan","followers_url":"https://api.github.com/users/gilligan/followers","following_url":"https://api.github.com/users/gilligan/following{/other_user}","gists_url":"https://api.github.com/users/gilligan/gists{/gist_id}","starred_url":"https://api.github.com/users/gilligan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilligan/subscriptions","organizations_url":"https://api.github.com/users/gilligan/orgs","repos_url":"https://api.github.com/users/gilligan/repos","events_url":"https://api.github.com/users/gilligan/events{/privacy}","received_events_url":"https://api.github.com/users/gilligan/received_events","type":"User","site_admin":false},"body":"###### Things done\r\n- Built on platform(s)\r\n   - [X] OS X\r\n- [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n\r\n\r\n","created_at":"2016-04-25T14:18:56Z","updated_at":"2016-04-26T07:45:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef30aebe4feff451e5a526a3f53f8f2e21687ba8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14973/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14973/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/14973/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/9de2efffe67c183add811921ee6a7838cbca363f","head":{"label":"holidaycheck:update-libuv","ref":"update-libuv","sha":"9de2efffe67c183add811921ee6a7838cbca363f","user":{"login":"holidaycheck","id":2122343,"avatar_url":"https://avatars.githubusercontent.com/u/2122343?v=3","gravatar_id":"","url":"https://api.github.com/users/holidaycheck","html_url":"https://github.com/holidaycheck","followers_url":"https://api.github.com/users/holidaycheck/followers","following_url":"https://api.github.com/users/holidaycheck/following{/other_user}","gists_url":"https://api.github.com/users/holidaycheck/gists{/gist_id}","starred_url":"https://api.github.com/users/holidaycheck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidaycheck/subscriptions","organizations_url":"https://api.github.com/users/holidaycheck/orgs","repos_url":"https://api.github.com/users/holidaycheck/repos","events_url":"https://api.github.com/users/holidaycheck/events{/privacy}","received_events_url":"https://api.github.com/users/holidaycheck/received_events","type":"Organization","site_admin":false},"repo":{"id":50023434,"name":"nixpkgs","full_name":"holidaycheck/nixpkgs","owner":{"login":"holidaycheck","id":2122343,"avatar_url":"https://avatars.githubusercontent.com/u/2122343?v=3","gravatar_id":"","url":"https://api.github.com/users/holidaycheck","html_url":"https://github.com/holidaycheck","followers_url":"https://api.github.com/users/holidaycheck/followers","following_url":"https://api.github.com/users/holidaycheck/following{/other_user}","gists_url":"https://api.github.com/users/holidaycheck/gists{/gist_id}","starred_url":"https://api.github.com/users/holidaycheck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidaycheck/subscriptions","organizations_url":"https://api.github.com/users/holidaycheck/orgs","repos_url":"https://api.github.com/users/holidaycheck/repos","events_url":"https://api.github.com/users/holidaycheck/events{/privacy}","received_events_url":"https://api.github.com/users/holidaycheck/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/holidaycheck/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/holidaycheck/nixpkgs","forks_url":"https://api.github.com/repos/holidaycheck/nixpkgs/forks","keys_url":"https://api.github.com/repos/holidaycheck/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holidaycheck/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holidaycheck/nixpkgs/teams","hooks_url":"https://api.github.com/repos/holidaycheck/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/holidaycheck/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/holidaycheck/nixpkgs/events","assignees_url":"https://api.github.com/repos/holidaycheck/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/holidaycheck/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/holidaycheck/nixpkgs/tags","blobs_url":"https://api.github.com/repos/holidaycheck/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holidaycheck/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holidaycheck/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/holidaycheck/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holidaycheck/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/holidaycheck/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/holidaycheck/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/holidaycheck/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/holidaycheck/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/holidaycheck/nixpkgs/subscription","commits_url":"https://api.github.com/repos/holidaycheck/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/holidaycheck/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/holidaycheck/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/holidaycheck/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/holidaycheck/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/holidaycheck/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holidaycheck/nixpkgs/merges","archive_url":"https://api.github.com/repos/holidaycheck/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holidaycheck/nixpkgs/downloads","issues_url":"https://api.github.com/repos/holidaycheck/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/holidaycheck/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/holidaycheck/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/holidaycheck/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holidaycheck/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/holidaycheck/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/holidaycheck/nixpkgs/deployments","created_at":"2016-01-20T10:40:25Z","updated_at":"2016-04-08T09:57:25Z","pushed_at":"2016-04-25T16:01:51Z","git_url":"git://github.com/holidaycheck/nixpkgs.git","ssh_url":"git@github.com:holidaycheck/nixpkgs.git","clone_url":"https://github.com/holidaycheck/nixpkgs.git","svn_url":"https://github.com/holidaycheck/nixpkgs","homepage":null,"size":323372,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dx"}},"base":{"label":"NixOS:master","ref":"master","sha":"f9e5eccb13ffbbac3381cfa85ffd1748d3dacd77","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2016-04-26T02:43:02Z","pushed_at":"2016-04-26T07:24:35Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":517697,"stargazers_count":1054,"watchers_count":1054,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1365,"mirror_url":null,"open_issues_count":1294,"forks":1365,"open_issues":1294,"watchers":1054,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14973"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/14973"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/14973"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/14973/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14973/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14973/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/9de2efffe67c183add811921ee6a7838cbca363f"}}}}