{"action":"closed","number":335,"pull_request":{"url":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls/335","id":95980228,"html_url":"https://github.com/ocsigen/ocsigen-start/pull/335","diff_url":"https://github.com/ocsigen/ocsigen-start/pull/335.diff","patch_url":"https://github.com/ocsigen/ocsigen-start/pull/335.patch","issue_url":"https://api.github.com/repos/ocsigen/ocsigen-start/issues/335","number":335,"state":"closed","locked":false,"title":"Remove ImageMagick binding dependency","user":{"login":"dannywillems","id":6018454,"avatar_url":"https://avatars.githubusercontent.com/u/6018454?v=3","gravatar_id":"","url":"https://api.github.com/users/dannywillems","html_url":"https://github.com/dannywillems","followers_url":"https://api.github.com/users/dannywillems/followers","following_url":"https://api.github.com/users/dannywillems/following{/other_user}","gists_url":"https://api.github.com/users/dannywillems/gists{/gist_id}","starred_url":"https://api.github.com/users/dannywillems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannywillems/subscriptions","organizations_url":"https://api.github.com/users/dannywillems/orgs","repos_url":"https://api.github.com/users/dannywillems/repos","events_url":"https://api.github.com/users/dannywillems/events{/privacy}","received_events_url":"https://api.github.com/users/dannywillems/received_events","type":"User","site_admin":false},"body":"Fix #231.\r\n\r\n`Os_uploader` was never used...\r\n\r\n@balat @vouillon Cropping is totally broken and Ocsigen Start uses `Ot_picture_uploader` which is not simple (and I think it's done client-side? Possible?). Work must be done for that! Please, take a look.\r\n\r\nThere are related issues (like #326), and first version can not be released without this! We can not finish the settings page (#317) and the style (#227, related to settings page). I remember you have an elegant and working solution with `convert` and by using `Sys.command`.\r\n\r\nA simple `convert` use can be `convert [image] -crop 120x120+50+50 [out_image]` to have a 120x120 square and it must be done server-side (I don't know how it's done in `Ot_picture_uploader`).\r\n\r\nI can propose a simple solution but I think it's useless if you have already the appropriate solution. \r\n\r\n\r\n","created_at":"2016-11-30T21:45:50Z","updated_at":"2016-12-08T16:47:10Z","closed_at":"2016-12-08T16:47:10Z","merged_at":null,"merge_commit_sha":"85538e5ae1b7499a93063a9e854acb21bce6175d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls/335/commits","review_comments_url":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls/335/comments","review_comment_url":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocsigen/ocsigen-start/issues/335/comments","statuses_url":"https://api.github.com/repos/ocsigen/ocsigen-start/statuses/426b30cc31b06936d8e5df9f1c4d706566362a00","head":{"label":"dannywillems:imagemagick","ref":"imagemagick","sha":"426b30cc31b06936d8e5df9f1c4d706566362a00","user":{"login":"dannywillems","id":6018454,"avatar_url":"https://avatars.githubusercontent.com/u/6018454?v=3","gravatar_id":"","url":"https://api.github.com/users/dannywillems","html_url":"https://github.com/dannywillems","followers_url":"https://api.github.com/users/dannywillems/followers","following_url":"https://api.github.com/users/dannywillems/following{/other_user}","gists_url":"https://api.github.com/users/dannywillems/gists{/gist_id}","starred_url":"https://api.github.com/users/dannywillems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannywillems/subscriptions","organizations_url":"https://api.github.com/users/dannywillems/orgs","repos_url":"https://api.github.com/users/dannywillems/repos","events_url":"https://api.github.com/users/dannywillems/events{/privacy}","received_events_url":"https://api.github.com/users/dannywillems/received_events","type":"User","site_admin":false},"repo":{"id":67039409,"name":"ocsigen-start","full_name":"dannywillems/ocsigen-start","owner":{"login":"dannywillems","id":6018454,"avatar_url":"https://avatars.githubusercontent.com/u/6018454?v=3","gravatar_id":"","url":"https://api.github.com/users/dannywillems","html_url":"https://github.com/dannywillems","followers_url":"https://api.github.com/users/dannywillems/followers","following_url":"https://api.github.com/users/dannywillems/following{/other_user}","gists_url":"https://api.github.com/users/dannywillems/gists{/gist_id}","starred_url":"https://api.github.com/users/dannywillems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannywillems/subscriptions","organizations_url":"https://api.github.com/users/dannywillems/orgs","repos_url":"https://api.github.com/users/dannywillems/repos","events_url":"https://api.github.com/users/dannywillems/events{/privacy}","received_events_url":"https://api.github.com/users/dannywillems/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dannywillems/ocsigen-start","description":"Ocsigen-start: an Eliom application skeleton ready to use to build your own application with users, (pre)registration, notifications, etc.","fork":true,"url":"https://api.github.com/repos/dannywillems/ocsigen-start","forks_url":"https://api.github.com/repos/dannywillems/ocsigen-start/forks","keys_url":"https://api.github.com/repos/dannywillems/ocsigen-start/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dannywillems/ocsigen-start/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dannywillems/ocsigen-start/teams","hooks_url":"https://api.github.com/repos/dannywillems/ocsigen-start/hooks","issue_events_url":"https://api.github.com/repos/dannywillems/ocsigen-start/issues/events{/number}","events_url":"https://api.github.com/repos/dannywillems/ocsigen-start/events","assignees_url":"https://api.github.com/repos/dannywillems/ocsigen-start/assignees{/user}","branches_url":"https://api.github.com/repos/dannywillems/ocsigen-start/branches{/branch}","tags_url":"https://api.github.com/repos/dannywillems/ocsigen-start/tags","blobs_url":"https://api.github.com/repos/dannywillems/ocsigen-start/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dannywillems/ocsigen-start/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dannywillems/ocsigen-start/git/refs{/sha}","trees_url":"https://api.github.com/repos/dannywillems/ocsigen-start/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dannywillems/ocsigen-start/statuses/{sha}","languages_url":"https://api.github.com/repos/dannywillems/ocsigen-start/languages","stargazers_url":"https://api.github.com/repos/dannywillems/ocsigen-start/stargazers","contributors_url":"https://api.github.com/repos/dannywillems/ocsigen-start/contributors","subscribers_url":"https://api.github.com/repos/dannywillems/ocsigen-start/subscribers","subscription_url":"https://api.github.com/repos/dannywillems/ocsigen-start/subscription","commits_url":"https://api.github.com/repos/dannywillems/ocsigen-start/commits{/sha}","git_commits_url":"https://api.github.com/repos/dannywillems/ocsigen-start/git/commits{/sha}","comments_url":"https://api.github.com/repos/dannywillems/ocsigen-start/comments{/number}","issue_comment_url":"https://api.github.com/repos/dannywillems/ocsigen-start/issues/comments{/number}","contents_url":"https://api.github.com/repos/dannywillems/ocsigen-start/contents/{+path}","compare_url":"https://api.github.com/repos/dannywillems/ocsigen-start/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dannywillems/ocsigen-start/merges","archive_url":"https://api.github.com/repos/dannywillems/ocsigen-start/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dannywillems/ocsigen-start/downloads","issues_url":"https://api.github.com/repos/dannywillems/ocsigen-start/issues{/number}","pulls_url":"https://api.github.com/repos/dannywillems/ocsigen-start/pulls{/number}","milestones_url":"https://api.github.com/repos/dannywillems/ocsigen-start/milestones{/number}","notifications_url":"https://api.github.com/repos/dannywillems/ocsigen-start/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dannywillems/ocsigen-start/labels{/name}","releases_url":"https://api.github.com/repos/dannywillems/ocsigen-start/releases{/id}","deployments_url":"https://api.github.com/repos/dannywillems/ocsigen-start/deployments","created_at":"2016-08-31T13:22:31Z","updated_at":"2016-10-28T15:33:55Z","pushed_at":"2016-12-08T16:15:17Z","git_url":"git://github.com/dannywillems/ocsigen-start.git","ssh_url":"git@github.com:dannywillems/ocsigen-start.git","clone_url":"https://github.com/dannywillems/ocsigen-start.git","svn_url":"https://github.com/dannywillems/ocsigen-start","homepage":"https://ocsigen.org/ocsigen-start","size":3210,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ocsigen:master","ref":"master","sha":"6597e74a9d654e4129f4e7b6f6543ea096b5be61","user":{"login":"ocsigen","id":4729424,"avatar_url":"https://avatars.githubusercontent.com/u/4729424?v=3","gravatar_id":"","url":"https://api.github.com/users/ocsigen","html_url":"https://github.com/ocsigen","followers_url":"https://api.github.com/users/ocsigen/followers","following_url":"https://api.github.com/users/ocsigen/following{/other_user}","gists_url":"https://api.github.com/users/ocsigen/gists{/gist_id}","starred_url":"https://api.github.com/users/ocsigen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocsigen/subscriptions","organizations_url":"https://api.github.com/users/ocsigen/orgs","repos_url":"https://api.github.com/users/ocsigen/repos","events_url":"https://api.github.com/users/ocsigen/events{/privacy}","received_events_url":"https://api.github.com/users/ocsigen/received_events","type":"Organization","site_admin":false},"repo":{"id":11151396,"name":"ocsigen-start","full_name":"ocsigen/ocsigen-start","owner":{"login":"ocsigen","id":4729424,"avatar_url":"https://avatars.githubusercontent.com/u/4729424?v=3","gravatar_id":"","url":"https://api.github.com/users/ocsigen","html_url":"https://github.com/ocsigen","followers_url":"https://api.github.com/users/ocsigen/followers","following_url":"https://api.github.com/users/ocsigen/following{/other_user}","gists_url":"https://api.github.com/users/ocsigen/gists{/gist_id}","starred_url":"https://api.github.com/users/ocsigen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocsigen/subscriptions","organizations_url":"https://api.github.com/users/ocsigen/orgs","repos_url":"https://api.github.com/users/ocsigen/repos","events_url":"https://api.github.com/users/ocsigen/events{/privacy}","received_events_url":"https://api.github.com/users/ocsigen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocsigen/ocsigen-start","description":"Ocsigen-start: an Eliom application skeleton ready to use to build your own application with users, (pre)registration, notifications, etc.","fork":false,"url":"https://api.github.com/repos/ocsigen/ocsigen-start","forks_url":"https://api.github.com/repos/ocsigen/ocsigen-start/forks","keys_url":"https://api.github.com/repos/ocsigen/ocsigen-start/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocsigen/ocsigen-start/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocsigen/ocsigen-start/teams","hooks_url":"https://api.github.com/repos/ocsigen/ocsigen-start/hooks","issue_events_url":"https://api.github.com/repos/ocsigen/ocsigen-start/issues/events{/number}","events_url":"https://api.github.com/repos/ocsigen/ocsigen-start/events","assignees_url":"https://api.github.com/repos/ocsigen/ocsigen-start/assignees{/user}","branches_url":"https://api.github.com/repos/ocsigen/ocsigen-start/branches{/branch}","tags_url":"https://api.github.com/repos/ocsigen/ocsigen-start/tags","blobs_url":"https://api.github.com/repos/ocsigen/ocsigen-start/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocsigen/ocsigen-start/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocsigen/ocsigen-start/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocsigen/ocsigen-start/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocsigen/ocsigen-start/statuses/{sha}","languages_url":"https://api.github.com/repos/ocsigen/ocsigen-start/languages","stargazers_url":"https://api.github.com/repos/ocsigen/ocsigen-start/stargazers","contributors_url":"https://api.github.com/repos/ocsigen/ocsigen-start/contributors","subscribers_url":"https://api.github.com/repos/ocsigen/ocsigen-start/subscribers","subscription_url":"https://api.github.com/repos/ocsigen/ocsigen-start/subscription","commits_url":"https://api.github.com/repos/ocsigen/ocsigen-start/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocsigen/ocsigen-start/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocsigen/ocsigen-start/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocsigen/ocsigen-start/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocsigen/ocsigen-start/contents/{+path}","compare_url":"https://api.github.com/repos/ocsigen/ocsigen-start/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocsigen/ocsigen-start/merges","archive_url":"https://api.github.com/repos/ocsigen/ocsigen-start/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocsigen/ocsigen-start/downloads","issues_url":"https://api.github.com/repos/ocsigen/ocsigen-start/issues{/number}","pulls_url":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls{/number}","milestones_url":"https://api.github.com/repos/ocsigen/ocsigen-start/milestones{/number}","notifications_url":"https://api.github.com/repos/ocsigen/ocsigen-start/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocsigen/ocsigen-start/labels{/name}","releases_url":"https://api.github.com/repos/ocsigen/ocsigen-start/releases{/id}","deployments_url":"https://api.github.com/repos/ocsigen/ocsigen-start/deployments","created_at":"2013-07-03T13:24:21Z","updated_at":"2016-11-10T18:13:54Z","pushed_at":"2016-12-08T16:38:58Z","git_url":"git://github.com/ocsigen/ocsigen-start.git","ssh_url":"git@github.com:ocsigen/ocsigen-start.git","clone_url":"https://github.com/ocsigen/ocsigen-start.git","svn_url":"https://github.com/ocsigen/ocsigen-start","homepage":"","size":3520,"stargazers_count":22,"watchers_count":22,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":51,"forks":14,"open_issues":51,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls/335"},"html":{"href":"https://github.com/ocsigen/ocsigen-start/pull/335"},"issue":{"href":"https://api.github.com/repos/ocsigen/ocsigen-start/issues/335"},"comments":{"href":"https://api.github.com/repos/ocsigen/ocsigen-start/issues/335/comments"},"review_comments":{"href":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls/335/comments"},"review_comment":{"href":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocsigen/ocsigen-start/pulls/335/commits"},"statuses":{"href":"https://api.github.com/repos/ocsigen/ocsigen-start/statuses/426b30cc31b06936d8e5df9f1c4d706566362a00"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":1,"deletions":105,"changed_files":4}}
{"actor":{"display_login":"dannywillems"}}