{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/49115790","id":49115790,"diff_hunk":"@@ -20,26 +22,35 @@ internal DefaultArrayPool(int maxLength, int arraysPerBucket)\n             if (arraysPerBucket <= 0)\n                 throw new ArgumentOutOfRangeException(\"arraysPerBucket\");\n \n+            _eventSource = new ArrayPoolEventSource();\n+\n             // Our bucketing algorithm has a minimum length of 16\n             if (maxLength < MinimiumArraySize)\n                 maxLength = MinimiumArraySize;\n             \n             int maxBuckets = Utilities.SelectBucketIndex(maxLength);\n-            _buckets = new ArrayPoolBucket<T>[maxBuckets + 1];\n+            _buckets = new DefaultArrayPoolBucket<T>[maxBuckets + 1];\n             for (int i = 0; i < _buckets.Length; i++)\n-                _buckets[i] = new ArrayPoolBucket<T>(Utilities.GetMaxSizeForBucket(i), arraysPerBucket);\n+                _buckets[i] = new DefaultArrayPoolBucket<T>(Utilities.GetMaxSizeForBucket(i), arraysPerBucket, _eventSource);\n         }\n \n+        public override EventSource TraceEventSource","path":"src/System.Buffers/src/System/Buffers/DefaultArrayPool.cs","position":36,"original_position":36,"commit_id":"cc1ebac3b74db1c70a66c385686e23fc1cf50251","original_commit_id":"cc1ebac3b74db1c70a66c385686e23fc1cf50251","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"This shouldn't be exposed publically.","created_at":"2016-01-07T19:38:27Z","updated_at":"2016-01-07T19:38:27Z","html_url":"https://github.com/dotnet/corefx/pull/5231#discussion_r49115790","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/5231","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/49115790"},"html":{"href":"https://github.com/dotnet/corefx/pull/5231#discussion_r49115790"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/5231"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/5231","id":55378853,"html_url":"https://github.com/dotnet/corefx/pull/5231","diff_url":"https://github.com/dotnet/corefx/pull/5231.diff","patch_url":"https://github.com/dotnet/corefx/pull/5231.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/5231","number":5231,"state":"open","locked":false,"title":"Adding EventSource ETW tracing to the System.Buffers code","user":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"body":"This adds EventSource events to the Buffer Pool default implementation so consumers can attach listeners to aid in debugging code consuming the Buffer Pool as well as to measure performance and usage statistics around consumption of the Buffer Pool.\r\n\r\n/cc @KrzysztofCwalina ","created_at":"2016-01-07T19:26:59Z","updated_at":"2016-01-07T19:38:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5d3f749d4a5f852165fa054e0caa58f007a88bd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/5231/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/5231/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/5231/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/cc1ebac3b74db1c70a66c385686e23fc1cf50251","head":{"label":"sokket:buffers","ref":"buffers","sha":"cc1ebac3b74db1c70a66c385686e23fc1cf50251","user":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"repo":{"id":31975260,"name":"corefx","full_name":"sokket/corefx","owner":{"login":"sokket","id":1761798,"avatar_url":"https://avatars.githubusercontent.com/u/1761798?v=3","gravatar_id":"","url":"https://api.github.com/users/sokket","html_url":"https://github.com/sokket","followers_url":"https://api.github.com/users/sokket/followers","following_url":"https://api.github.com/users/sokket/following{/other_user}","gists_url":"https://api.github.com/users/sokket/gists{/gist_id}","starred_url":"https://api.github.com/users/sokket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokket/subscriptions","organizations_url":"https://api.github.com/users/sokket/orgs","repos_url":"https://api.github.com/users/sokket/repos","events_url":"https://api.github.com/users/sokket/events{/privacy}","received_events_url":"https://api.github.com/users/sokket/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sokket/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/sokket/corefx","forks_url":"https://api.github.com/repos/sokket/corefx/forks","keys_url":"https://api.github.com/repos/sokket/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sokket/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sokket/corefx/teams","hooks_url":"https://api.github.com/repos/sokket/corefx/hooks","issue_events_url":"https://api.github.com/repos/sokket/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/sokket/corefx/events","assignees_url":"https://api.github.com/repos/sokket/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/sokket/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/sokket/corefx/tags","blobs_url":"https://api.github.com/repos/sokket/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sokket/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sokket/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/sokket/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sokket/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/sokket/corefx/languages","stargazers_url":"https://api.github.com/repos/sokket/corefx/stargazers","contributors_url":"https://api.github.com/repos/sokket/corefx/contributors","subscribers_url":"https://api.github.com/repos/sokket/corefx/subscribers","subscription_url":"https://api.github.com/repos/sokket/corefx/subscription","commits_url":"https://api.github.com/repos/sokket/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/sokket/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/sokket/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/sokket/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/sokket/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/sokket/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sokket/corefx/merges","archive_url":"https://api.github.com/repos/sokket/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sokket/corefx/downloads","issues_url":"https://api.github.com/repos/sokket/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/sokket/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/sokket/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/sokket/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sokket/corefx/labels{/name}","releases_url":"https://api.github.com/repos/sokket/corefx/releases{/id}","created_at":"2015-03-10T18:45:28Z","updated_at":"2015-05-06T18:55:19Z","pushed_at":"2016-01-07T19:24:39Z","git_url":"git://github.com/sokket/corefx.git","ssh_url":"git@github.com:sokket/corefx.git","clone_url":"https://github.com/sokket/corefx.git","svn_url":"https://github.com/sokket/corefx","homepage":"","size":43730,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"c1a37804405382f2ab62dd3b4a6dd14f75825fd0","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-01-07T19:21:47Z","pushed_at":"2016-01-07T19:28:36Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":54322,"stargazers_count":8893,"watchers_count":8893,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2046,"mirror_url":null,"open_issues_count":831,"forks":2046,"open_issues":831,"watchers":8893,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/5231"},"html":{"href":"https://github.com/dotnet/corefx/pull/5231"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/5231"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/5231/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/5231/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/5231/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/cc1ebac3b74db1c70a66c385686e23fc1cf50251"}}}}