{"action":"created","issue":{"url":"https://api.github.com/repos/hadley/devtools/issues/1027","labels_url":"https://api.github.com/repos/hadley/devtools/issues/1027/labels{/name}","comments_url":"https://api.github.com/repos/hadley/devtools/issues/1027/comments","events_url":"https://api.github.com/repos/hadley/devtools/issues/1027/events","html_url":"https://github.com/hadley/devtools/pull/1027","id":126801544,"number":1027,"title":"Install sha (second attempt)","user":{"login":"rmflight","id":1509626,"avatar_url":"https://avatars.githubusercontent.com/u/1509626?v=3","gravatar_id":"","url":"https://api.github.com/users/rmflight","html_url":"https://github.com/rmflight","followers_url":"https://api.github.com/users/rmflight/followers","following_url":"https://api.github.com/users/rmflight/following{/other_user}","gists_url":"https://api.github.com/users/rmflight/gists{/gist_id}","starred_url":"https://api.github.com/users/rmflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmflight/subscriptions","organizations_url":"https://api.github.com/users/rmflight/orgs","repos_url":"https://api.github.com/users/rmflight/repos","events_url":"https://api.github.com/users/rmflight/events{/privacy}","received_events_url":"https://api.github.com/users/rmflight/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-15T03:33:10Z","updated_at":"2016-01-15T13:27:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hadley/devtools/pulls/1027","html_url":"https://github.com/hadley/devtools/pull/1027","diff_url":"https://github.com/hadley/devtools/pull/1027.diff","patch_url":"https://github.com/hadley/devtools/pull/1027.patch"},"body":"@jimhester, based on our earlier conversations, here is a second attempt at adding the SHA1 to the package install. It uses `git_committed` as we discussed as the default function of `add_sha`, and then if that passes, will then use `install_local` to copy the package to a temp directory and do the install from there, which automatically adds the SHA1.\r\n\r\nNote that the call to `install_local` probably needs to have all the other `install` arguments added to it to truly work as intended, but this currently passes all the tests, including the ones I added. \r\n\r\nIf this passes muster, I will add the rest of the install arguments to the `install_local` call.\r\n\r\nThe only ugly part of this I don't like is the `return()` statement that keeps a second round of `install` from happening and installing the one in the current directory, because that causes a `NULL` return value. I don't know how to avoid that ATM."},"comment":{"url":"https://api.github.com/repos/hadley/devtools/issues/comments/171961658","html_url":"https://github.com/hadley/devtools/pull/1027#issuecomment-171961658","issue_url":"https://api.github.com/repos/hadley/devtools/issues/1027","id":171961658,"user":{"login":"jimhester","id":205275,"avatar_url":"https://avatars.githubusercontent.com/u/205275?v=3","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"created_at":"2016-01-15T13:27:54Z","updated_at":"2016-01-15T13:27:54Z","body":"See proof on concept https://github.com/jimhester/devtools/commit/aa15cd0f3e9e8c8eadfc8e9c962f4bd958ec060f which works with limited testing on my machine."}}