{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/comments/83043929","pull_request_review_id":3909591,"id":83043929,"diff_hunk":"@@ -0,0 +1,86 @@\n+/*\n+ * The MIT License\n+ *\n+ * Copyright (c) 2016, CloudBees, Inc.","path":"src/test/java/org/jenkinsci/plugins/workflow/job/properties/QueryingMockTrigger.java","position":4,"original_position":4,"commit_id":"d49d3c275e5fdccdab9f126e20eb553ece847ae6","original_commit_id":"d49d3c275e5fdccdab9f126e20eb553ece847ae6","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"Presumably you could pick the copyright holder (IANAL).","created_at":"2016-10-12T16:24:00Z","updated_at":"2016-10-12T16:28:43Z","html_url":"https://github.com/jenkinsci/workflow-job-plugin/pull/28#discussion_r83043929","pull_request_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/comments/83043929"},"html":{"href":"https://github.com/jenkinsci/workflow-job-plugin/pull/28#discussion_r83043929"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/28","id":88563954,"html_url":"https://github.com/jenkinsci/workflow-job-plugin/pull/28","diff_url":"https://github.com/jenkinsci/workflow-job-plugin/pull/28.diff","patch_url":"https://github.com/jenkinsci/workflow-job-plugin/pull/28.patch","issue_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/issues/28","number":28,"state":"open","locked":false,"title":"[FIXED JENKINS-38454] Make sure we add the triggers before starting.","user":{"login":"KostyaSha","id":231611,"avatar_url":"https://avatars.githubusercontent.com/u/231611?v=3","gravatar_id":"","url":"https://api.github.com/users/KostyaSha","html_url":"https://github.com/KostyaSha","followers_url":"https://api.github.com/users/KostyaSha/followers","following_url":"https://api.github.com/users/KostyaSha/following{/other_user}","gists_url":"https://api.github.com/users/KostyaSha/gists{/gist_id}","starred_url":"https://api.github.com/users/KostyaSha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KostyaSha/subscriptions","organizations_url":"https://api.github.com/users/KostyaSha/orgs","repos_url":"https://api.github.com/users/KostyaSha/repos","events_url":"https://api.github.com/users/KostyaSha/events{/privacy}","received_events_url":"https://api.github.com/users/KostyaSha/received_events","type":"User","site_admin":false},"body":"https://issues.jenkins-ci.org/browse/JENKINS-38454\r\nabayer: \r\n```\r\nThis was...complex. But it works. We make sure the triggers property\r\nhas been added before starting, in case the start method for a trigger\r\nclass expects the trigger to already be present on the job. Existing\r\ntests all pass, and the new test failed without the changes to\r\nWorkflowJob and PipelineTriggersJobProperty. Phew.\r\n\r\nNote - I'm working on getting rid of the need for posting hardcoded\r\nJSON and just using form manipulation.\r\n```\r\n\r\nCreating PR to get artifact for testing.","created_at":"2016-10-09T00:48:03Z","updated_at":"2016-10-12T16:28:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0b1675966becd8d7e0be3529dd0ff0dea88258a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/28/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/28/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/issues/28/comments","statuses_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/statuses/d49d3c275e5fdccdab9f126e20eb553ece847ae6","head":{"label":"abayer:jenkins-38454","ref":"jenkins-38454","sha":"d49d3c275e5fdccdab9f126e20eb553ece847ae6","user":{"login":"abayer","id":120218,"avatar_url":"https://avatars.githubusercontent.com/u/120218?v=3","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},"repo":{"id":59842920,"name":"workflow-job-plugin","full_name":"abayer/workflow-job-plugin","owner":{"login":"abayer","id":120218,"avatar_url":"https://avatars.githubusercontent.com/u/120218?v=3","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abayer/workflow-job-plugin","description":"","fork":true,"url":"https://api.github.com/repos/abayer/workflow-job-plugin","forks_url":"https://api.github.com/repos/abayer/workflow-job-plugin/forks","keys_url":"https://api.github.com/repos/abayer/workflow-job-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abayer/workflow-job-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abayer/workflow-job-plugin/teams","hooks_url":"https://api.github.com/repos/abayer/workflow-job-plugin/hooks","issue_events_url":"https://api.github.com/repos/abayer/workflow-job-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/abayer/workflow-job-plugin/events","assignees_url":"https://api.github.com/repos/abayer/workflow-job-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/abayer/workflow-job-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/abayer/workflow-job-plugin/tags","blobs_url":"https://api.github.com/repos/abayer/workflow-job-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abayer/workflow-job-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abayer/workflow-job-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/abayer/workflow-job-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abayer/workflow-job-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/abayer/workflow-job-plugin/languages","stargazers_url":"https://api.github.com/repos/abayer/workflow-job-plugin/stargazers","contributors_url":"https://api.github.com/repos/abayer/workflow-job-plugin/contributors","subscribers_url":"https://api.github.com/repos/abayer/workflow-job-plugin/subscribers","subscription_url":"https://api.github.com/repos/abayer/workflow-job-plugin/subscription","commits_url":"https://api.github.com/repos/abayer/workflow-job-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/abayer/workflow-job-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/abayer/workflow-job-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/abayer/workflow-job-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/abayer/workflow-job-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/abayer/workflow-job-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abayer/workflow-job-plugin/merges","archive_url":"https://api.github.com/repos/abayer/workflow-job-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abayer/workflow-job-plugin/downloads","issues_url":"https://api.github.com/repos/abayer/workflow-job-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/abayer/workflow-job-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/abayer/workflow-job-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/abayer/workflow-job-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abayer/workflow-job-plugin/labels{/name}","releases_url":"https://api.github.com/repos/abayer/workflow-job-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/abayer/workflow-job-plugin/deployments","created_at":"2016-05-27T15:03:51Z","updated_at":"2016-05-27T15:03:52Z","pushed_at":"2016-09-23T01:31:29Z","git_url":"git://github.com/abayer/workflow-job-plugin.git","ssh_url":"git@github.com:abayer/workflow-job-plugin.git","clone_url":"https://github.com/abayer/workflow-job-plugin.git","svn_url":"https://github.com/abayer/workflow-job-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Job+Plugin","size":421,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"0a4c59edc2353acbdd7b45c0b259612c4b4f7dad","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":55543389,"name":"workflow-job-plugin","full_name":"jenkinsci/workflow-job-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/workflow-job-plugin","description":"","fork":false,"url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin","forks_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/deployments","created_at":"2016-04-05T20:27:07Z","updated_at":"2016-09-19T12:02:45Z","pushed_at":"2016-10-11T00:17:06Z","git_url":"git://github.com/jenkinsci/workflow-job-plugin.git","ssh_url":"git@github.com:jenkinsci/workflow-job-plugin.git","clone_url":"https://github.com/jenkinsci/workflow-job-plugin.git","svn_url":"https://github.com/jenkinsci/workflow-job-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Job+Plugin","size":442,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":4,"forks":13,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/28"},"html":{"href":"https://github.com/jenkinsci/workflow-job-plugin/pull/28"},"issue":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/issues/28"},"comments":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/workflow-job-plugin/statuses/d49d3c275e5fdccdab9f126e20eb553ece847ae6"}}}}
{"actor":{"display_login":"jglick"}}