{"push_id":933825204,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"04149ef268110c042fc924b45350483593c166aa","before":"81ba8307e5a97f0fb413264917230ed0fb93ad54","commits":[{"sha":"88bc753c5ae2595749126d37124c20dee63793a6","author":{"email":"ccbe6589b53d87898eb7ece96901c85c4e3d115e@fb.com","name":"Chad Parry"},"message":"Moar time\n\nSummary: Since this test occasionally times out, I'm increasing the timeout interval. The Thrift codebase doesn't support our internal test runner or `SKIP` macro, which would have led to a cleaner solution.\n\nReviewed By: yfeldblum, mmcduff\n\nDifferential Revision: D2825718\n\nfb-gh-sync-id: a59b2f510437574eafb6ffdcb69187baecec95f0","distinct":true,"url":"https://api.github.com/repos/facebook/fbthrift/commits/88bc753c5ae2595749126d37124c20dee63793a6"},{"sha":"04149ef268110c042fc924b45350483593c166aa","author":{"email":"ccbe6589b53d87898eb7ece96901c85c4e3d115e@fb.com","name":"Chad Parry"},"message":"Consistent enum parsing\n\nSummary:\nWe should allow qualified enum values to be specified, (e.g., `SomeEnum.Value1` instead of only `Value1`). This should work whether or not the enum was defined in an included Thrift file. Unqualified enum values should still work.\n\nThis also fixes some broken parsing where non-existent qualifiers would be accepted by the old code.\n\nSuppose this is in the file `included.thrift`:\n\n  enum IncludedEnum {\n    IncludedValue1 = 1,\n  }\n\nThen this example shows how enums can be qualified:\n\n  include \"included.thrift\"\n\n  enum SomeEnum {\n    Value1 = 1,\n  }\n\n  struct SomeStruct {\n    1: SomeEnum value1 = Value1, // Bare enums are still allowed.\n    2: SomeEnum value2 = SomeEnum.Value1, // Qualified enums are still allowed.\n    3: included.IncludedEnum value3 = included.IncludedValue1, // Bare enums from an included namespace are still allowed.\n    4: included.IncludedEnum value4 = included.IncludedEnum.IncludedValue1, // Qualified enums from an included namespace used to fail but now are allowed.\n    5: SomeEnum value5 = AnyMadeUpIdentifier.Value1, // Incorrect qualifiers used to be allowed but now generate an error.\n  }\n\nReviewed By: haijunz\n\nDifferential Revision: D2822265\n\nfb-gh-sync-id: 01646b20fecf73c8f215eff9becc7a3a131cfcb5","distinct":true,"url":"https://api.github.com/repos/facebook/fbthrift/commits/04149ef268110c042fc924b45350483593c166aa"}]}