{"action":"created","comment":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/80348212","id":80348212,"diff_hunk":"@@ -175,6 +176,7 @@ def reconfigService(self, server, username, reviewCB=DEFAULT_REVIEW,\n         self.summaryCB = summaryCB\n         self.summaryArg = summaryArg\n         self.builders = builders\n+        self.gerrit_notify = notify","path":"master/buildbot/reporters/gerrit.py","position":18,"original_position":18,"commit_id":"edf38373c0ecc01b9ed70bf7b1bd87a9ac8e52e3","original_commit_id":"edf38373c0ecc01b9ed70bf7b1bd87a9ac8e52e3","user":{"login":"sa2ajj","id":447092,"avatar_url":"https://avatars.githubusercontent.com/u/447092?v=3","gravatar_id":"","url":"https://api.github.com/users/sa2ajj","html_url":"https://github.com/sa2ajj","followers_url":"https://api.github.com/users/sa2ajj/followers","following_url":"https://api.github.com/users/sa2ajj/following{/other_user}","gists_url":"https://api.github.com/users/sa2ajj/gists{/gist_id}","starred_url":"https://api.github.com/users/sa2ajj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sa2ajj/subscriptions","organizations_url":"https://api.github.com/users/sa2ajj/orgs","repos_url":"https://api.github.com/users/sa2ajj/repos","events_url":"https://api.github.com/users/sa2ajj/events{/privacy}","received_events_url":"https://api.github.com/users/sa2ajj/received_events","type":"User","site_admin":false},"body":"while legacy code extensively uses public members, the new code is expected to be aware whether it's a part of the class' API or not.  I'd suggest to use `_gerrit_notify`","created_at":"2016-09-24T00:41:27Z","updated_at":"2016-09-24T00:41:27Z","html_url":"https://github.com/buildbot/buildbot/pull/2411#discussion_r80348212","pull_request_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2411","_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/80348212"},"html":{"href":"https://github.com/buildbot/buildbot/pull/2411#discussion_r80348212"},"pull_request":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2411"}}},"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/2411","id":86553471,"html_url":"https://github.com/buildbot/buildbot/pull/2411","diff_url":"https://github.com/buildbot/buildbot/pull/2411.diff","patch_url":"https://github.com/buildbot/buildbot/pull/2411.patch","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/2411","number":2411,"state":"open","locked":false,"title":"Control who gets notified by GerritStatusPush","user":{"login":"dinatale2","id":13680976,"avatar_url":"https://avatars.githubusercontent.com/u/13680976?v=3","gravatar_id":"","url":"https://api.github.com/users/dinatale2","html_url":"https://github.com/dinatale2","followers_url":"https://api.github.com/users/dinatale2/followers","following_url":"https://api.github.com/users/dinatale2/following{/other_user}","gists_url":"https://api.github.com/users/dinatale2/gists{/gist_id}","starred_url":"https://api.github.com/users/dinatale2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dinatale2/subscriptions","organizations_url":"https://api.github.com/users/dinatale2/orgs","repos_url":"https://api.github.com/users/dinatale2/repos","events_url":"https://api.github.com/users/dinatale2/events{/privacy}","received_events_url":"https://api.github.com/users/dinatale2/received_events","type":"User","site_admin":false},"body":"Allow the GerritStatusPush object to accept who to notify as an argument. The notify argument is a string\r\nwhich accepts values found in the gerrit documentation for the `--notify` flag. The argument is set to None by\r\ndefault to maintain current functionality.\r\n\r\nSigned-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>","created_at":"2016-09-23T17:48:19Z","updated_at":"2016-09-24T00:44:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8c1edf6c83d63c2a8cb078046fe1223e1e93eb2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2411/commits","review_comments_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2411/comments","review_comment_url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/2411/comments","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/edf38373c0ecc01b9ed70bf7b1bd87a9ac8e52e3","head":{"label":"dinatale2:upstream/GerritStatusPush","ref":"upstream/GerritStatusPush","sha":"edf38373c0ecc01b9ed70bf7b1bd87a9ac8e52e3","user":{"login":"dinatale2","id":13680976,"avatar_url":"https://avatars.githubusercontent.com/u/13680976?v=3","gravatar_id":"","url":"https://api.github.com/users/dinatale2","html_url":"https://github.com/dinatale2","followers_url":"https://api.github.com/users/dinatale2/followers","following_url":"https://api.github.com/users/dinatale2/following{/other_user}","gists_url":"https://api.github.com/users/dinatale2/gists{/gist_id}","starred_url":"https://api.github.com/users/dinatale2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dinatale2/subscriptions","organizations_url":"https://api.github.com/users/dinatale2/orgs","repos_url":"https://api.github.com/users/dinatale2/repos","events_url":"https://api.github.com/users/dinatale2/events{/privacy}","received_events_url":"https://api.github.com/users/dinatale2/received_events","type":"User","site_admin":false},"repo":{"id":55157414,"name":"buildbot","full_name":"dinatale2/buildbot","owner":{"login":"dinatale2","id":13680976,"avatar_url":"https://avatars.githubusercontent.com/u/13680976?v=3","gravatar_id":"","url":"https://api.github.com/users/dinatale2","html_url":"https://github.com/dinatale2","followers_url":"https://api.github.com/users/dinatale2/followers","following_url":"https://api.github.com/users/dinatale2/following{/other_user}","gists_url":"https://api.github.com/users/dinatale2/gists{/gist_id}","starred_url":"https://api.github.com/users/dinatale2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dinatale2/subscriptions","organizations_url":"https://api.github.com/users/dinatale2/orgs","repos_url":"https://api.github.com/users/dinatale2/repos","events_url":"https://api.github.com/users/dinatale2/events{/privacy}","received_events_url":"https://api.github.com/users/dinatale2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dinatale2/buildbot","description":"OpenSFS's fork of Buildbot for ","fork":true,"url":"https://api.github.com/repos/dinatale2/buildbot","forks_url":"https://api.github.com/repos/dinatale2/buildbot/forks","keys_url":"https://api.github.com/repos/dinatale2/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dinatale2/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dinatale2/buildbot/teams","hooks_url":"https://api.github.com/repos/dinatale2/buildbot/hooks","issue_events_url":"https://api.github.com/repos/dinatale2/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/dinatale2/buildbot/events","assignees_url":"https://api.github.com/repos/dinatale2/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/dinatale2/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/dinatale2/buildbot/tags","blobs_url":"https://api.github.com/repos/dinatale2/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dinatale2/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dinatale2/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/dinatale2/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dinatale2/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/dinatale2/buildbot/languages","stargazers_url":"https://api.github.com/repos/dinatale2/buildbot/stargazers","contributors_url":"https://api.github.com/repos/dinatale2/buildbot/contributors","subscribers_url":"https://api.github.com/repos/dinatale2/buildbot/subscribers","subscription_url":"https://api.github.com/repos/dinatale2/buildbot/subscription","commits_url":"https://api.github.com/repos/dinatale2/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/dinatale2/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/dinatale2/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/dinatale2/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/dinatale2/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/dinatale2/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dinatale2/buildbot/merges","archive_url":"https://api.github.com/repos/dinatale2/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dinatale2/buildbot/downloads","issues_url":"https://api.github.com/repos/dinatale2/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/dinatale2/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/dinatale2/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/dinatale2/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dinatale2/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/dinatale2/buildbot/releases{/id}","deployments_url":"https://api.github.com/repos/dinatale2/buildbot/deployments","created_at":"2016-03-31T14:34:22Z","updated_at":"2016-03-31T14:34:26Z","pushed_at":"2016-09-23T23:21:51Z","git_url":"git://github.com/dinatale2/buildbot.git","ssh_url":"git@github.com:dinatale2/buildbot.git","clone_url":"https://github.com/dinatale2/buildbot.git","svn_url":"https://github.com/dinatale2/buildbot","homepage":"http://build.lustre.org","size":40779,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.8.13-pre-lustre"}},"base":{"label":"buildbot:master","ref":"master","sha":"45b3d5ae7e503a550956d236209563bdeae8d6f2","user":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"repo":{"id":760165,"name":"buildbot","full_name":"buildbot/buildbot","owner":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildbot/buildbot","description":"Python-based continuous integration testing framework; your pull requests are more than welcome!","fork":false,"url":"https://api.github.com/repos/buildbot/buildbot","forks_url":"https://api.github.com/repos/buildbot/buildbot/forks","keys_url":"https://api.github.com/repos/buildbot/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildbot/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildbot/buildbot/teams","hooks_url":"https://api.github.com/repos/buildbot/buildbot/hooks","issue_events_url":"https://api.github.com/repos/buildbot/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/buildbot/buildbot/events","assignees_url":"https://api.github.com/repos/buildbot/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/buildbot/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/buildbot/buildbot/tags","blobs_url":"https://api.github.com/repos/buildbot/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildbot/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildbot/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildbot/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/buildbot/buildbot/languages","stargazers_url":"https://api.github.com/repos/buildbot/buildbot/stargazers","contributors_url":"https://api.github.com/repos/buildbot/buildbot/contributors","subscribers_url":"https://api.github.com/repos/buildbot/buildbot/subscribers","subscription_url":"https://api.github.com/repos/buildbot/buildbot/subscription","commits_url":"https://api.github.com/repos/buildbot/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildbot/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildbot/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildbot/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildbot/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/buildbot/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildbot/buildbot/merges","archive_url":"https://api.github.com/repos/buildbot/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildbot/buildbot/downloads","issues_url":"https://api.github.com/repos/buildbot/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/buildbot/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/buildbot/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/buildbot/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildbot/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/buildbot/buildbot/releases{/id}","deployments_url":"https://api.github.com/repos/buildbot/buildbot/deployments","created_at":"2010-07-06T17:56:53Z","updated_at":"2016-09-23T19:06:46Z","pushed_at":"2016-09-23T23:21:52Z","git_url":"git://github.com/buildbot/buildbot.git","ssh_url":"git@github.com:buildbot/buildbot.git","clone_url":"https://github.com/buildbot/buildbot.git","svn_url":"https://github.com/buildbot/buildbot","homepage":"http://buildbot.net","size":90152,"stargazers_count":2355,"watchers_count":2355,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":957,"mirror_url":null,"open_issues_count":16,"forks":957,"open_issues":16,"watchers":2355,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2411"},"html":{"href":"https://github.com/buildbot/buildbot/pull/2411"},"issue":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/2411"},"comments":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/2411/comments"},"review_comments":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2411/comments"},"review_comment":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2411/commits"},"statuses":{"href":"https://api.github.com/repos/buildbot/buildbot/statuses/edf38373c0ecc01b9ed70bf7b1bd87a9ac8e52e3"}}}}
{"actor":{"display_login":"sa2ajj"}}