{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/9906","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/9906/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/9906/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/9906/events","html_url":"https://github.com/cockroachdb/cockroach/pull/9906","id":182530439,"number":9906,"title":"storage: fix TestTxnObeysLeaseExpiration","user":{"login":"vivekmenezes","id":11774212,"avatar_url":"https://avatars.githubusercontent.com/u/11774212?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekmenezes","html_url":"https://github.com/vivekmenezes","followers_url":"https://api.github.com/users/vivekmenezes/followers","following_url":"https://api.github.com/users/vivekmenezes/following{/other_user}","gists_url":"https://api.github.com/users/vivekmenezes/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekmenezes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekmenezes/subscriptions","organizations_url":"https://api.github.com/users/vivekmenezes/orgs","repos_url":"https://api.github.com/users/vivekmenezes/repos","events_url":"https://api.github.com/users/vivekmenezes/events{/privacy}","received_events_url":"https://api.github.com/users/vivekmenezes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"andreimatei","id":377201,"avatar_url":"https://avatars.githubusercontent.com/u/377201?v=3","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false},"assignees":[{"login":"andreimatei","id":377201,"avatar_url":"https://avatars.githubusercontent.com/u/377201?v=3","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false}],"milestone":null,"comments":28,"created_at":"2016-10-12T13:47:57Z","updated_at":"2016-11-03T15:43:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/9906","html_url":"https://github.com/cockroachdb/cockroach/pull/9906","diff_url":"https://github.com/cockroachdb/cockroach/pull/9906.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/9906.patch"},"body":"Return an error with the transaction in the PENDING state\nwhen a transaction doesn't meet its deadline. This allows\nthe client to issue a Rollback() that cleans up the transaction\nintents. This mechanism is a bit unreliable because if the client\nfails before issuing a Rollback(), the transaction remains pending\nwith the intents alive. But it is deemed to be a good solution for\nthe deadline exceeds case, which is a rare event. A rare failure\nfollowed by a rare client failure will result in intents lying\naround until the transaction record itself expires.\n\nfixes #7031\n\n<!-- Reviewable:start -->\n---\n\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/9906)\n\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/258181390","html_url":"https://github.com/cockroachdb/cockroach/pull/9906#issuecomment-258181390","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/9906","id":258181390,"user":{"login":"vivekmenezes","id":11774212,"avatar_url":"https://avatars.githubusercontent.com/u/11774212?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekmenezes","html_url":"https://github.com/vivekmenezes","followers_url":"https://api.github.com/users/vivekmenezes/followers","following_url":"https://api.github.com/users/vivekmenezes/following{/other_user}","gists_url":"https://api.github.com/users/vivekmenezes/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekmenezes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekmenezes/subscriptions","organizations_url":"https://api.github.com/users/vivekmenezes/orgs","repos_url":"https://api.github.com/users/vivekmenezes/repos","events_url":"https://api.github.com/users/vivekmenezes/events{/privacy}","received_events_url":"https://api.github.com/users/vivekmenezes/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T15:43:48Z","updated_at":"2016-11-03T15:43:48Z","body":"\n\n\n\nReview status: 6 of 7 files reviewed at latest revision, 7 unresolved discussions, all commit checks successful.\n\n---\n\n*[pkg/kv/txn_coord_sender.go, line 838 at r6](https://reviewable.io:443/reviews/cockroachdb/cockroach/9906#-KVehEELwmvqIaumlfwr:-KVeqIorA9RsAYI5P7OC:b-896fix) ([raw file](https://github.com/cockroachdb/cockroach/blob/2bcd9ff1fb31a2725a84fd54eeef14ecf3cf8d7a/pkg/kv/txn_coord_sender.go#L838)):*\n<details><summary><i>Previously, bdarnell (Ben Darnell) wrote…</i></summary>\n> Remove \"might still want to continue\". I'm pretty sure the transaction can't be continued, but we are leaving cancellation up to the client anyway. \n</details>\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/9906)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"vivekmenezes"}}