{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/48692140","id":48692140,"diff_hunk":"@@ -109,4 +109,23 @@ def textual_se_linux_level\n   def textual_run_as_non_root\n     {:label => \"Run As Non Root\", :value => @record.container_definition.run_as_non_root} unless @record.container_definition.run_as_non_root.nil?\n   end\n+\n+  def textual_group_env\n+    {\n+      :additional_table_class => \"table-fixed\",\n+      :expandable             => true,\n+      :labels                 => [_(\"Name\"), _(\"Type\"), _(\"value\")],\n+      :values                 => collect_env\n+    }\n+  end\n+\n+  def collect_env\n+    @record.container_definition.container_env_vars.collect do |var|\n+      [\n+        var.name,\n+        var.value.nil? ? \"REFERENCE\" : \"VALUE\",","path":"app/helpers/container_helper/textual_summary.rb","position":18,"original_position":18,"commit_id":"4d1b2d96aeda1c68a027a0e09abccd82f1b5b075","original_commit_id":"8f0f1ecc845ece60204cb55312803f92c48f4aeb","user":{"login":"abonas","id":6277245,"avatar_url":"https://avatars.githubusercontent.com/u/6277245?v=3","gravatar_id":"","url":"https://api.github.com/users/abonas","html_url":"https://github.com/abonas","followers_url":"https://api.github.com/users/abonas/followers","following_url":"https://api.github.com/users/abonas/following{/other_user}","gists_url":"https://api.github.com/users/abonas/gists{/gist_id}","starred_url":"https://api.github.com/users/abonas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abonas/subscriptions","organizations_url":"https://api.github.com/users/abonas/orgs","repos_url":"https://api.github.com/users/abonas/repos","events_url":"https://api.github.com/users/abonas/events{/privacy}","received_events_url":"https://api.github.com/users/abonas/received_events","type":"User","site_admin":false},"body":"> The value of an env var can be a string (that includes other vars) called value OR a reference to other fields called valueFrom[1]\r\n> \r\n> [1] https://github.com/kubernetes/kubernetes/blob/master/pkg/api/types.go#L701\r\n\r\nI wonder if it still requires hardcoded strings on miq side or it can be somehow generically extracted from k8s output","created_at":"2016-01-03T11:46:12Z","updated_at":"2016-01-03T11:46:12Z","html_url":"https://github.com/ManageIQ/manageiq/pull/6013#discussion_r48692140","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6013","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/48692140"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/6013#discussion_r48692140"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6013"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6013","id":54907393,"html_url":"https://github.com/ManageIQ/manageiq/pull/6013","diff_url":"https://github.com/ManageIQ/manageiq/pull/6013.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/6013.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/6013","number":6013,"state":"open","locked":false,"title":"Add container environment variables table","user":{"login":"alongoldboim","id":11405684,"avatar_url":"https://avatars.githubusercontent.com/u/11405684?v=3","gravatar_id":"","url":"https://api.github.com/users/alongoldboim","html_url":"https://github.com/alongoldboim","followers_url":"https://api.github.com/users/alongoldboim/followers","following_url":"https://api.github.com/users/alongoldboim/following{/other_user}","gists_url":"https://api.github.com/users/alongoldboim/gists{/gist_id}","starred_url":"https://api.github.com/users/alongoldboim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alongoldboim/subscriptions","organizations_url":"https://api.github.com/users/alongoldboim/orgs","repos_url":"https://api.github.com/users/alongoldboim/repos","events_url":"https://api.github.com/users/alongoldboim/events{/privacy}","received_events_url":"https://api.github.com/users/alongoldboim/received_events","type":"User","site_admin":false},"body":"ref to : https://github.com/ManageIQ/manageiq/issues/5617","created_at":"2016-01-02T15:17:07Z","updated_at":"2016-01-03T11:46:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e37f82ff44b443225f803bde363a2f08471b6bdc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6013/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6013/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/6013/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/4d1b2d96aeda1c68a027a0e09abccd82f1b5b075","head":{"label":"alongoldboim:container_env_vars","ref":"container_env_vars","sha":"4d1b2d96aeda1c68a027a0e09abccd82f1b5b075","user":{"login":"alongoldboim","id":11405684,"avatar_url":"https://avatars.githubusercontent.com/u/11405684?v=3","gravatar_id":"","url":"https://api.github.com/users/alongoldboim","html_url":"https://github.com/alongoldboim","followers_url":"https://api.github.com/users/alongoldboim/followers","following_url":"https://api.github.com/users/alongoldboim/following{/other_user}","gists_url":"https://api.github.com/users/alongoldboim/gists{/gist_id}","starred_url":"https://api.github.com/users/alongoldboim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alongoldboim/subscriptions","organizations_url":"https://api.github.com/users/alongoldboim/orgs","repos_url":"https://api.github.com/users/alongoldboim/repos","events_url":"https://api.github.com/users/alongoldboim/events{/privacy}","received_events_url":"https://api.github.com/users/alongoldboim/received_events","type":"User","site_admin":false},"repo":{"id":48227094,"name":"manageiq","full_name":"alongoldboim/manageiq","owner":{"login":"alongoldboim","id":11405684,"avatar_url":"https://avatars.githubusercontent.com/u/11405684?v=3","gravatar_id":"","url":"https://api.github.com/users/alongoldboim","html_url":"https://github.com/alongoldboim","followers_url":"https://api.github.com/users/alongoldboim/followers","following_url":"https://api.github.com/users/alongoldboim/following{/other_user}","gists_url":"https://api.github.com/users/alongoldboim/gists{/gist_id}","starred_url":"https://api.github.com/users/alongoldboim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alongoldboim/subscriptions","organizations_url":"https://api.github.com/users/alongoldboim/orgs","repos_url":"https://api.github.com/users/alongoldboim/repos","events_url":"https://api.github.com/users/alongoldboim/events{/privacy}","received_events_url":"https://api.github.com/users/alongoldboim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alongoldboim/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/alongoldboim/manageiq","forks_url":"https://api.github.com/repos/alongoldboim/manageiq/forks","keys_url":"https://api.github.com/repos/alongoldboim/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alongoldboim/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alongoldboim/manageiq/teams","hooks_url":"https://api.github.com/repos/alongoldboim/manageiq/hooks","issue_events_url":"https://api.github.com/repos/alongoldboim/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/alongoldboim/manageiq/events","assignees_url":"https://api.github.com/repos/alongoldboim/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/alongoldboim/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/alongoldboim/manageiq/tags","blobs_url":"https://api.github.com/repos/alongoldboim/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alongoldboim/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alongoldboim/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/alongoldboim/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alongoldboim/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/alongoldboim/manageiq/languages","stargazers_url":"https://api.github.com/repos/alongoldboim/manageiq/stargazers","contributors_url":"https://api.github.com/repos/alongoldboim/manageiq/contributors","subscribers_url":"https://api.github.com/repos/alongoldboim/manageiq/subscribers","subscription_url":"https://api.github.com/repos/alongoldboim/manageiq/subscription","commits_url":"https://api.github.com/repos/alongoldboim/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/alongoldboim/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/alongoldboim/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/alongoldboim/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/alongoldboim/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/alongoldboim/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alongoldboim/manageiq/merges","archive_url":"https://api.github.com/repos/alongoldboim/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alongoldboim/manageiq/downloads","issues_url":"https://api.github.com/repos/alongoldboim/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/alongoldboim/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/alongoldboim/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/alongoldboim/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alongoldboim/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/alongoldboim/manageiq/releases{/id}","created_at":"2015-12-18T09:42:32Z","updated_at":"2015-12-18T09:42:48Z","pushed_at":"2016-01-03T11:42:02Z","git_url":"git://github.com/alongoldboim/manageiq.git","ssh_url":"git@github.com:alongoldboim/manageiq.git","clone_url":"https://github.com/alongoldboim/manageiq.git","svn_url":"https://github.com/alongoldboim/manageiq","homepage":"manageiq.org","size":99934,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"83871151c8191ddc88f7a13b705d3ce9f2c4a414","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-12-31T06:38:07Z","pushed_at":"2016-01-03T11:42:59Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":134309,"stargazers_count":186,"watchers_count":186,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":198,"mirror_url":null,"open_issues_count":499,"forks":198,"open_issues":499,"watchers":186,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6013"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/6013"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/6013"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/6013/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6013/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6013/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/4d1b2d96aeda1c68a027a0e09abccd82f1b5b075"}}}}