{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/65277111","id":65277111,"diff_hunk":"@@ -16,10 +16,16 @@\n \n # This script contains skeletons of helper functions that each provider hosting\n # Kubernetes must implement to use cluster/kube-*.sh scripts.\n-# It sets KUBERNETES_PROVIDER to its default value (gce) if it is unset, and\n+# It sets KUBERNETES_PROVIDER to its default value (gce) if it is unset\n+# and KUBERNETES_CONFORMANCE_TEST is unset, and\n # then sources cluster/${KUBERNETES_PROVIDER}/util.sh.\n \n-KUBERNETES_PROVIDER=\"${KUBERNETES_PROVIDER:-gce}\"\n+if [[ -n \"${KUBERNETES_CONFORMANCE_TEST:-}\" ]]; then\n+    KUBERNETES_PROVIDER=\"\"","path":"cluster/kube-util.sh","position":11,"original_position":11,"commit_id":"aaf66b60fa2329f1fe184652297b13cde05083ee","original_commit_id":"3adccf10ce53c8bb4922bb103edfea2fb33c7b59","user":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"body":"I'm not sure why we do that. if anything, I'd be for removing that line in ginkgo-e2e.sh.","created_at":"2016-05-31T22:53:15Z","updated_at":"2016-05-31T22:53:15Z","html_url":"https://github.com/kubernetes/kubernetes/pull/26530#discussion_r65277111","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26530","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/65277111"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/26530#discussion_r65277111"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26530"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26530","id":71905499,"html_url":"https://github.com/kubernetes/kubernetes/pull/26530","diff_url":"https://github.com/kubernetes/kubernetes/pull/26530.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/26530.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26530","number":26530,"state":"open","locked":false,"title":"Unset KUBERNETES_PROVIDER  when KUBERNETES_CONFORMANCE_TEST is set","user":{"login":"pskrzyns","id":16152568,"avatar_url":"https://avatars.githubusercontent.com/u/16152568?v=3","gravatar_id":"","url":"https://api.github.com/users/pskrzyns","html_url":"https://github.com/pskrzyns","followers_url":"https://api.github.com/users/pskrzyns/followers","following_url":"https://api.github.com/users/pskrzyns/following{/other_user}","gists_url":"https://api.github.com/users/pskrzyns/gists{/gist_id}","starred_url":"https://api.github.com/users/pskrzyns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pskrzyns/subscriptions","organizations_url":"https://api.github.com/users/pskrzyns/orgs","repos_url":"https://api.github.com/users/pskrzyns/repos","events_url":"https://api.github.com/users/pskrzyns/events{/privacy}","received_events_url":"https://api.github.com/users/pskrzyns/received_events","type":"User","site_admin":false},"body":"fixes #26269 ","created_at":"2016-05-30T14:00:32Z","updated_at":"2016-05-31T22:53:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85d2a0bff8633add2d53e9f42955431ff93c1dc5","assignee":{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26530/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26530/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/26530/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/aaf66b60fa2329f1fe184652297b13cde05083ee","head":{"label":"intelsdi-x:dont_set_provider_for_conformance_tests","ref":"dont_set_provider_for_conformance_tests","sha":"aaf66b60fa2329f1fe184652297b13cde05083ee","user":{"login":"intelsdi-x","id":8398747,"avatar_url":"https://avatars.githubusercontent.com/u/8398747?v=3","gravatar_id":"","url":"https://api.github.com/users/intelsdi-x","html_url":"https://github.com/intelsdi-x","followers_url":"https://api.github.com/users/intelsdi-x/followers","following_url":"https://api.github.com/users/intelsdi-x/following{/other_user}","gists_url":"https://api.github.com/users/intelsdi-x/gists{/gist_id}","starred_url":"https://api.github.com/users/intelsdi-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intelsdi-x/subscriptions","organizations_url":"https://api.github.com/users/intelsdi-x/orgs","repos_url":"https://api.github.com/users/intelsdi-x/repos","events_url":"https://api.github.com/users/intelsdi-x/events{/privacy}","received_events_url":"https://api.github.com/users/intelsdi-x/received_events","type":"Organization","site_admin":false},"repo":{"id":44242341,"name":"kubernetes","full_name":"intelsdi-x/kubernetes","owner":{"login":"intelsdi-x","id":8398747,"avatar_url":"https://avatars.githubusercontent.com/u/8398747?v=3","gravatar_id":"","url":"https://api.github.com/users/intelsdi-x","html_url":"https://github.com/intelsdi-x","followers_url":"https://api.github.com/users/intelsdi-x/followers","following_url":"https://api.github.com/users/intelsdi-x/following{/other_user}","gists_url":"https://api.github.com/users/intelsdi-x/gists{/gist_id}","starred_url":"https://api.github.com/users/intelsdi-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intelsdi-x/subscriptions","organizations_url":"https://api.github.com/users/intelsdi-x/orgs","repos_url":"https://api.github.com/users/intelsdi-x/repos","events_url":"https://api.github.com/users/intelsdi-x/events{/privacy}","received_events_url":"https://api.github.com/users/intelsdi-x/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intelsdi-x/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/intelsdi-x/kubernetes","forks_url":"https://api.github.com/repos/intelsdi-x/kubernetes/forks","keys_url":"https://api.github.com/repos/intelsdi-x/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intelsdi-x/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intelsdi-x/kubernetes/teams","hooks_url":"https://api.github.com/repos/intelsdi-x/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/intelsdi-x/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/intelsdi-x/kubernetes/events","assignees_url":"https://api.github.com/repos/intelsdi-x/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/intelsdi-x/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/intelsdi-x/kubernetes/tags","blobs_url":"https://api.github.com/repos/intelsdi-x/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intelsdi-x/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intelsdi-x/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/intelsdi-x/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intelsdi-x/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/intelsdi-x/kubernetes/languages","stargazers_url":"https://api.github.com/repos/intelsdi-x/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/intelsdi-x/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/intelsdi-x/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/intelsdi-x/kubernetes/subscription","commits_url":"https://api.github.com/repos/intelsdi-x/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/intelsdi-x/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/intelsdi-x/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/intelsdi-x/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/intelsdi-x/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/intelsdi-x/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intelsdi-x/kubernetes/merges","archive_url":"https://api.github.com/repos/intelsdi-x/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intelsdi-x/kubernetes/downloads","issues_url":"https://api.github.com/repos/intelsdi-x/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/intelsdi-x/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/intelsdi-x/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/intelsdi-x/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intelsdi-x/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/intelsdi-x/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/intelsdi-x/kubernetes/deployments","created_at":"2015-10-14T11:07:22Z","updated_at":"2016-03-22T18:29:29Z","pushed_at":"2016-05-30T16:26:36Z","git_url":"git://github.com/intelsdi-x/kubernetes.git","ssh_url":"git@github.com:intelsdi-x/kubernetes.git","clone_url":"https://github.com/intelsdi-x/kubernetes.git","svn_url":"https://github.com/intelsdi-x/kubernetes","homepage":"http://kubernetes.io","size":242905,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"dff1ed149710ce6dd1caaf995308c781b0e997de","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-05-31T22:24:17Z","pushed_at":"2016-05-31T22:25:13Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":449849,"stargazers_count":14678,"watchers_count":14678,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4495,"mirror_url":null,"open_issues_count":3668,"forks":4495,"open_issues":3668,"watchers":14678,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26530"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/26530"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/26530"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/26530/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26530/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/26530/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/aaf66b60fa2329f1fe184652297b13cde05083ee"}}}}
{"actor":{"display_login":"ixdy"}}