{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/14159","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14159/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14159/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14159/events","html_url":"https://github.com/cms-sw/cmssw/pull/14159","id":149709136,"number":14159,"title":"Enable pixel templates for phase1 pixel","user":{"login":"makortel","id":33993,"avatar_url":"https://avatars.githubusercontent.com/u/33993?v=3","gravatar_id":"","url":"https://api.github.com/users/makortel","html_url":"https://github.com/makortel","followers_url":"https://api.github.com/users/makortel/followers","following_url":"https://api.github.com/users/makortel/following{/other_user}","gists_url":"https://api.github.com/users/makortel/gists{/gist_id}","starred_url":"https://api.github.com/users/makortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makortel/subscriptions","organizations_url":"https://api.github.com/users/makortel/orgs","repos_url":"https://api.github.com/users/makortel/repos","events_url":"https://api.github.com/users/makortel/events{/privacy}","received_events_url":"https://api.github.com/users/makortel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":79,"closed_issues":448,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-04-26T13:22:00Z","due_on":null,"closed_at":null},"comments":21,"created_at":"2016-04-20T09:15:34Z","updated_at":"2016-04-26T14:21:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/14159","html_url":"https://github.com/cms-sw/cmssw/pull/14159","diff_url":"https://github.com/cms-sw/cmssw/pull/14159.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/14159.patch"},"body":"The title says it all. The templates are already part of the GTs, so enabling them is just a matter of removing all customizations changing TransientTrackingRecHitBuilder to \"WithTrackAngle\".\r\n\r\nTested in 8_1_0_pre2, small changes expected in tracking and downstream (most notably dxy and dz resolutions improve). I have the usual set of MTV plots with 1000 TTbar+35PU events here (RAW from 810pre1, ideal GT) https://mkortela.web.cern.ch/mkortela/tracking/validation/CMSSW_8_1_0_pre2_template\r\n\r\n@rovere @VinInn @dkotlins "},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/214761210","html_url":"https://github.com/cms-sw/cmssw/pull/14159#issuecomment-214761210","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14159","id":214761210,"user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"created_at":"2016-04-26T14:21:09Z","updated_at":"2016-04-26T14:21:09Z","body":"+1\r\n\r\nfor https://github.com/cms-sw/cmssw/pull/14159\tef463c1\r\n- code changes are in line with the description\r\n- jenkins tests pass and comparisons with baseline show no differences in workflows up to run2 2016 and there are small differences in 2017 workflows as expected\r\n- local tests in 810pre3 of 2017 workflows show some degradations more noticeable in pixel endcap (somewhat expected, but they should go away after updates to the pixel geometry); \r\n    - the decision to sign off is based on conceptually correct use of templates and on improvements in resolution as mentioned in https://mkortela.web.cern.ch/mkortela/tracking/validation/CMSSW_8_1_0_pre2_template/ttbar_pu_ootb/resolutionsPt.pdf\r\n<img width=\"836\" alt=\"wf_makortel_resolutionspt\" src=\"https://cloud.githubusercontent.com/assets/4676718/14821347/b832bd9e-0bca-11e6-9382-bde12f85b57c.png\">\r\n"}}