{"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/pyramid_zipkin/pulls/comments/50497919","id":50497919,"diff_hunk":"@@ -8,11 +8,13 @@ Features include:\n \n * Blacklisting specific route/paths from getting traced.\n \n-* `zipkin_tracing_percent` to control the %age of requests getting sampled.\n+* ``zipkin_tracing_percent`` to control the percentage of requests getting sampled.\n \n-* API `create_headers_for_new_span` to generate new client headers.\n+* API ``create_headers_for_new_span`` to generate new client headers.\n \n-* Creates `http.uri` binary annotation automatically for each trace.\n+* Adds ``http.uri`` and ``http.uri.qs`` binary annotations automatically for each trace.","path":"docs/source/index.rst","position":11,"original_position":11,"commit_id":"691126a8aeb2938e9215f1c90cce4189cbe9491c","original_commit_id":"691126a8aeb2938e9215f1c90cce4189cbe9491c","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"body":"late to the party, but there's a proposal to move to \"http/path\" and \"http/url\" for these keys. Mind speaking up here? https://github.com/openzipkin/zipkin/pull/909","created_at":"2016-01-22T03:08:45Z","updated_at":"2016-01-22T03:08:45Z","html_url":"https://github.com/Yelp/pyramid_zipkin/pull/12#discussion_r50497919","pull_request_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/Yelp/pyramid_zipkin/pulls/comments/50497919"},"html":{"href":"https://github.com/Yelp/pyramid_zipkin/pull/12#discussion_r50497919"},"pull_request":{"href":"https://api.github.com/repos/Yelp/pyramid_zipkin/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/Yelp/pyramid_zipkin/pulls/12","id":56118379,"html_url":"https://github.com/Yelp/pyramid_zipkin/pull/12","diff_url":"https://github.com/Yelp/pyramid_zipkin/pull/12.diff","patch_url":"https://github.com/Yelp/pyramid_zipkin/pull/12.patch","issue_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/issues/12","number":12,"state":"closed","locked":false,"title":"add ability to add arbitrary binary annotations","user":{"login":"mjbryant","id":6538298,"avatar_url":"https://avatars.githubusercontent.com/u/6538298?v=3","gravatar_id":"","url":"https://api.github.com/users/mjbryant","html_url":"https://github.com/mjbryant","followers_url":"https://api.github.com/users/mjbryant/followers","following_url":"https://api.github.com/users/mjbryant/following{/other_user}","gists_url":"https://api.github.com/users/mjbryant/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbryant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbryant/subscriptions","organizations_url":"https://api.github.com/users/mjbryant/orgs","repos_url":"https://api.github.com/users/mjbryant/repos","events_url":"https://api.github.com/users/mjbryant/events{/privacy}","received_events_url":"https://api.github.com/users/mjbryant/received_events","type":"User","site_admin":false},"body":"This doesn't quite address issue #11, but it's very close. All tests are green and coverage is still at 100%.","created_at":"2016-01-15T01:08:27Z","updated_at":"2016-01-22T03:08:45Z","closed_at":"2016-01-15T21:46:22Z","merged_at":"2016-01-15T21:46:22Z","merge_commit_sha":"157af0ab87bfaa8ab686a891776b6a6b6b075fef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/pulls/12/commits","review_comments_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/pulls/12/comments","review_comment_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/issues/12/comments","statuses_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/statuses/691126a8aeb2938e9215f1c90cce4189cbe9491c","head":{"label":"mjbryant:mbryant-add-extra-binary-annotations-callback","ref":"mbryant-add-extra-binary-annotations-callback","sha":"691126a8aeb2938e9215f1c90cce4189cbe9491c","user":{"login":"mjbryant","id":6538298,"avatar_url":"https://avatars.githubusercontent.com/u/6538298?v=3","gravatar_id":"","url":"https://api.github.com/users/mjbryant","html_url":"https://github.com/mjbryant","followers_url":"https://api.github.com/users/mjbryant/followers","following_url":"https://api.github.com/users/mjbryant/following{/other_user}","gists_url":"https://api.github.com/users/mjbryant/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbryant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbryant/subscriptions","organizations_url":"https://api.github.com/users/mjbryant/orgs","repos_url":"https://api.github.com/users/mjbryant/repos","events_url":"https://api.github.com/users/mjbryant/events{/privacy}","received_events_url":"https://api.github.com/users/mjbryant/received_events","type":"User","site_admin":false},"repo":{"id":49679561,"name":"pyramid_zipkin","full_name":"mjbryant/pyramid_zipkin","owner":{"login":"mjbryant","id":6538298,"avatar_url":"https://avatars.githubusercontent.com/u/6538298?v=3","gravatar_id":"","url":"https://api.github.com/users/mjbryant","html_url":"https://github.com/mjbryant","followers_url":"https://api.github.com/users/mjbryant/followers","following_url":"https://api.github.com/users/mjbryant/following{/other_user}","gists_url":"https://api.github.com/users/mjbryant/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbryant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbryant/subscriptions","organizations_url":"https://api.github.com/users/mjbryant/orgs","repos_url":"https://api.github.com/users/mjbryant/repos","events_url":"https://api.github.com/users/mjbryant/events{/privacy}","received_events_url":"https://api.github.com/users/mjbryant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjbryant/pyramid_zipkin","description":"Pyramid tween to add Zipkin service spans","fork":true,"url":"https://api.github.com/repos/mjbryant/pyramid_zipkin","forks_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/forks","keys_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/teams","hooks_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/hooks","issue_events_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/issues/events{/number}","events_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/events","assignees_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/assignees{/user}","branches_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/branches{/branch}","tags_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/tags","blobs_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/statuses/{sha}","languages_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/languages","stargazers_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/stargazers","contributors_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/contributors","subscribers_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/subscribers","subscription_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/subscription","commits_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/contents/{+path}","compare_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/merges","archive_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/downloads","issues_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/issues{/number}","pulls_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/pulls{/number}","milestones_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/milestones{/number}","notifications_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/labels{/name}","releases_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/releases{/id}","deployments_url":"https://api.github.com/repos/mjbryant/pyramid_zipkin/deployments","created_at":"2016-01-14T22:31:01Z","updated_at":"2016-01-14T22:31:02Z","pushed_at":"2016-01-15T21:47:44Z","git_url":"git://github.com/mjbryant/pyramid_zipkin.git","ssh_url":"git@github.com:mjbryant/pyramid_zipkin.git","clone_url":"https://github.com/mjbryant/pyramid_zipkin.git","svn_url":"https://github.com/mjbryant/pyramid_zipkin","homepage":"","size":53,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"f2466287d603cd14988744112d608d9fb50f7b78","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":45487210,"name":"pyramid_zipkin","full_name":"Yelp/pyramid_zipkin","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/pyramid_zipkin","description":"Pyramid tween to add Zipkin service spans","fork":false,"url":"https://api.github.com/repos/Yelp/pyramid_zipkin","forks_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/forks","keys_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/teams","hooks_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/hooks","issue_events_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/events","assignees_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/tags","blobs_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/languages","stargazers_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/stargazers","contributors_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/contributors","subscribers_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/subscribers","subscription_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/subscription","commits_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/merges","archive_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/downloads","issues_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/pyramid_zipkin/deployments","created_at":"2015-11-03T18:33:27Z","updated_at":"2016-01-19T05:33:09Z","pushed_at":"2016-01-20T00:09:08Z","git_url":"git://github.com/Yelp/pyramid_zipkin.git","ssh_url":"git@github.com:Yelp/pyramid_zipkin.git","clone_url":"https://github.com/Yelp/pyramid_zipkin.git","svn_url":"https://github.com/Yelp/pyramid_zipkin","homepage":"","size":53,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/pyramid_zipkin/pulls/12"},"html":{"href":"https://github.com/Yelp/pyramid_zipkin/pull/12"},"issue":{"href":"https://api.github.com/repos/Yelp/pyramid_zipkin/issues/12"},"comments":{"href":"https://api.github.com/repos/Yelp/pyramid_zipkin/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/pyramid_zipkin/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/pyramid_zipkin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/pyramid_zipkin/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/pyramid_zipkin/statuses/691126a8aeb2938e9215f1c90cce4189cbe9491c"}}}}