{"action":"created","comment":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/77909806","id":77909806,"diff_hunk":"@@ -96,12 +99,20 @@ dnl # These commands may take different command line arguments.\n dnl #\n AC_DEFUN([ZFS_AC_CONFIG_USER_COMMANDS_LINUX], [\n \tAC_PATH_TOOL(BLOCKDEV, blockdev, \"\")\n+\tAC_PATH_TOOL(CHACL, chacl, \"\")","path":"config/user-commands.m4","position":25,"original_position":25,"commit_id":"f83133cf5518ca1fd6486746c9df80b2484749fe","original_commit_id":"f83133cf5518ca1fd6486746c9df80b2484749fe","user":{"login":"behlendorf","id":148917,"avatar_url":"https://avatars.githubusercontent.com/u/148917?v=3","gravatar_id":"","url":"https://api.github.com/users/behlendorf","html_url":"https://github.com/behlendorf","followers_url":"https://api.github.com/users/behlendorf/followers","following_url":"https://api.github.com/users/behlendorf/following{/other_user}","gists_url":"https://api.github.com/users/behlendorf/gists{/gist_id}","starred_url":"https://api.github.com/users/behlendorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behlendorf/subscriptions","organizations_url":"https://api.github.com/users/behlendorf/orgs","repos_url":"https://api.github.com/users/behlendorf/repos","events_url":"https://api.github.com/users/behlendorf/events{/privacy}","received_events_url":"https://api.github.com/users/behlendorf/received_events","type":"User","site_admin":false},"body":"Good point, but we still really should add this dependency.  It's fine if you want to keep it in a separate patch.","created_at":"2016-09-07T21:43:30Z","updated_at":"2016-09-07T21:43:30Z","html_url":"https://github.com/zfsonlinux/zfs/pull/4929#discussion_r77909806","pull_request_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4929","_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/77909806"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/4929#discussion_r77909806"},"pull_request":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4929"}}},"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4929","id":79984906,"html_url":"https://github.com/zfsonlinux/zfs/pull/4929","diff_url":"https://github.com/zfsonlinux/zfs/pull/4929.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/4929.patch","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/4929","number":4929,"state":"open","locked":false,"title":"OpenZFS - Performance regression suite for zfstest","user":{"login":"don-brady","id":12415697,"avatar_url":"https://avatars.githubusercontent.com/u/12415697?v=3","gravatar_id":"","url":"https://api.github.com/users/don-brady","html_url":"https://github.com/don-brady","followers_url":"https://api.github.com/users/don-brady/followers","following_url":"https://api.github.com/users/don-brady/following{/other_user}","gists_url":"https://api.github.com/users/don-brady/gists{/gist_id}","starred_url":"https://api.github.com/users/don-brady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/don-brady/subscriptions","organizations_url":"https://api.github.com/users/don-brady/orgs","repos_url":"https://api.github.com/users/don-brady/repos","events_url":"https://api.github.com/users/don-brady/events{/privacy}","received_events_url":"https://api.github.com/users/don-brady/received_events","type":"User","site_admin":false},"body":"Author: John Wren Kennedy <john.kennedy@delphix.com>\r\nReviewed by: Prakash Surya <prakash.surya@delphix.com>\r\nReviewed by: Dan Kimmel <dan.kimmel@delphix.com>\r\nReviewed by: Matt Ahrens <mahrens@delphix.com>\r\nReviewed by: Paul Dagnelie <pcd@delphix.com>\r\nReviewed by: Don Brady <don.brady@intel.com>\r\nReviewed by: Richard Elling <Richard.Elling@RichardElling.com>\r\nApproved by: Richard Lowe <richlowe@richlowe.net>\r\nPorted-by: Don Brady <don.brady@intel.com>\r\n\r\nOpenZFS-issue: https://www.illumos.org/issues/6950\r\nOpenZFS-commit: https://github.com/openzfs/openzfs/commit/dcbf3bd6\r\nDelphix-commit: https://github.com/delphix/delphix-os/commit/978ed49\r\n\r\nZFS Test Suite Performance Regression Tests\r\n\r\nThis was pulled into OpenZFS via the compressed arc featureand was\r\nseparated out in zfsonlinux as a separate pull request from PR-4768.\r\nIt originally came in as QA-4903 in Delphix-OS from John Kennedy.\r\n\r\nPorting Notes:\r\n1. Added assertions in the setup script to make sure required tools\r\n   (fio, mpstat, ...) are present.\r\n2. For the config.json generation in perf.shlib used arcstats and\r\n    other binaries instead of dtrace to query the values.\r\n3. For the perf data collection:\r\n   - use \"zpool iostat -lpvyL\" instead of the io.d dtrace script\r\n    (currently not collecting zfs_read/write latency stats)\r\n   - mpstat and iostat take different arguments\r\n   - prefetch_io.sh is a placeholder that uses arcstats instead of\r\n     dtrace\r\n4. Build machines require fio, mdadm and sysstat packages (YMMV).\r\n\r\nFuture Work:\r\n   - Need a way to measure zfs_read and zfs_write latencies per pool.\r\n   - Need tools to takes two sets of output and display/graph the\r\n     differences\r\n   - Bring over additional regression tests from Delphix","created_at":"2016-08-03T21:46:08Z","updated_at":"2016-09-07T21:43:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3753a2f25a75f35d5132a7fa9daa554ea624a113","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4929/commits","review_comments_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4929/comments","review_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/4929/comments","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/f83133cf5518ca1fd6486746c9df80b2484749fe","head":{"label":"don-brady:zfs-tests-perf-regression","ref":"zfs-tests-perf-regression","sha":"f83133cf5518ca1fd6486746c9df80b2484749fe","user":{"login":"don-brady","id":12415697,"avatar_url":"https://avatars.githubusercontent.com/u/12415697?v=3","gravatar_id":"","url":"https://api.github.com/users/don-brady","html_url":"https://github.com/don-brady","followers_url":"https://api.github.com/users/don-brady/followers","following_url":"https://api.github.com/users/don-brady/following{/other_user}","gists_url":"https://api.github.com/users/don-brady/gists{/gist_id}","starred_url":"https://api.github.com/users/don-brady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/don-brady/subscriptions","organizations_url":"https://api.github.com/users/don-brady/orgs","repos_url":"https://api.github.com/users/don-brady/repos","events_url":"https://api.github.com/users/don-brady/events{/privacy}","received_events_url":"https://api.github.com/users/don-brady/received_events","type":"User","site_admin":false},"repo":{"id":35576270,"name":"zfs","full_name":"don-brady/zfs","owner":{"login":"don-brady","id":12415697,"avatar_url":"https://avatars.githubusercontent.com/u/12415697?v=3","gravatar_id":"","url":"https://api.github.com/users/don-brady","html_url":"https://github.com/don-brady","followers_url":"https://api.github.com/users/don-brady/followers","following_url":"https://api.github.com/users/don-brady/following{/other_user}","gists_url":"https://api.github.com/users/don-brady/gists{/gist_id}","starred_url":"https://api.github.com/users/don-brady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/don-brady/subscriptions","organizations_url":"https://api.github.com/users/don-brady/orgs","repos_url":"https://api.github.com/users/don-brady/repos","events_url":"https://api.github.com/users/don-brady/events{/privacy}","received_events_url":"https://api.github.com/users/don-brady/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/don-brady/zfs","description":"Native ZFS for Linux","fork":true,"url":"https://api.github.com/repos/don-brady/zfs","forks_url":"https://api.github.com/repos/don-brady/zfs/forks","keys_url":"https://api.github.com/repos/don-brady/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/don-brady/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/don-brady/zfs/teams","hooks_url":"https://api.github.com/repos/don-brady/zfs/hooks","issue_events_url":"https://api.github.com/repos/don-brady/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/don-brady/zfs/events","assignees_url":"https://api.github.com/repos/don-brady/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/don-brady/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/don-brady/zfs/tags","blobs_url":"https://api.github.com/repos/don-brady/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/don-brady/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/don-brady/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/don-brady/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/don-brady/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/don-brady/zfs/languages","stargazers_url":"https://api.github.com/repos/don-brady/zfs/stargazers","contributors_url":"https://api.github.com/repos/don-brady/zfs/contributors","subscribers_url":"https://api.github.com/repos/don-brady/zfs/subscribers","subscription_url":"https://api.github.com/repos/don-brady/zfs/subscription","commits_url":"https://api.github.com/repos/don-brady/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/don-brady/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/don-brady/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/don-brady/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/don-brady/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/don-brady/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/don-brady/zfs/merges","archive_url":"https://api.github.com/repos/don-brady/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/don-brady/zfs/downloads","issues_url":"https://api.github.com/repos/don-brady/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/don-brady/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/don-brady/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/don-brady/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/don-brady/zfs/labels{/name}","releases_url":"https://api.github.com/repos/don-brady/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/don-brady/zfs/deployments","created_at":"2015-05-13T21:58:38Z","updated_at":"2016-03-16T23:19:41Z","pushed_at":"2016-08-31T22:36:41Z","git_url":"git://github.com/don-brady/zfs.git","ssh_url":"git@github.com:don-brady/zfs.git","clone_url":"https://github.com/don-brady/zfs.git","svn_url":"https://github.com/don-brady/zfs","homepage":"http://zfsonlinux.org/","size":31635,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"zfsonlinux:master","ref":"master","sha":"cf2731e65b2015988b2cae7970886279e11b013f","user":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":437011,"name":"zfs","full_name":"zfsonlinux/zfs","owner":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zfsonlinux/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":false,"url":"https://api.github.com/repos/zfsonlinux/zfs","forks_url":"https://api.github.com/repos/zfsonlinux/zfs/forks","keys_url":"https://api.github.com/repos/zfsonlinux/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfsonlinux/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfsonlinux/zfs/teams","hooks_url":"https://api.github.com/repos/zfsonlinux/zfs/hooks","issue_events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/zfsonlinux/zfs/events","assignees_url":"https://api.github.com/repos/zfsonlinux/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/zfsonlinux/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/zfsonlinux/zfs/tags","blobs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfsonlinux/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfsonlinux/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/zfsonlinux/zfs/languages","stargazers_url":"https://api.github.com/repos/zfsonlinux/zfs/stargazers","contributors_url":"https://api.github.com/repos/zfsonlinux/zfs/contributors","subscribers_url":"https://api.github.com/repos/zfsonlinux/zfs/subscribers","subscription_url":"https://api.github.com/repos/zfsonlinux/zfs/subscription","commits_url":"https://api.github.com/repos/zfsonlinux/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfsonlinux/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zfsonlinux/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/zfsonlinux/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfsonlinux/zfs/merges","archive_url":"https://api.github.com/repos/zfsonlinux/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfsonlinux/zfs/downloads","issues_url":"https://api.github.com/repos/zfsonlinux/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/zfsonlinux/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/zfsonlinux/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/labels{/name}","releases_url":"https://api.github.com/repos/zfsonlinux/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/zfsonlinux/zfs/deployments","created_at":"2009-12-14T20:20:34Z","updated_at":"2016-09-07T19:17:48Z","pushed_at":"2016-09-07T20:52:17Z","git_url":"git://github.com/zfsonlinux/zfs.git","ssh_url":"git@github.com:zfsonlinux/zfs.git","clone_url":"https://github.com/zfsonlinux/zfs.git","svn_url":"https://github.com/zfsonlinux/zfs","homepage":"http://zfsonlinux.org/","size":59515,"stargazers_count":2027,"watchers_count":2027,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":508,"mirror_url":null,"open_issues_count":1043,"forks":508,"open_issues":1043,"watchers":2027,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4929"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/4929"},"issue":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/4929"},"comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/4929/comments"},"review_comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4929/comments"},"review_comment":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4929/commits"},"statuses":{"href":"https://api.github.com/repos/zfsonlinux/zfs/statuses/f83133cf5518ca1fd6486746c9df80b2484749fe"}}}}
{"actor":{"display_login":"behlendorf"}}