{"action":"created","issue":{"url":"https://api.github.com/repos/linkedin/photon-ml/issues/133","repository_url":"https://api.github.com/repos/linkedin/photon-ml","labels_url":"https://api.github.com/repos/linkedin/photon-ml/issues/133/labels{/name}","comments_url":"https://api.github.com/repos/linkedin/photon-ml/issues/133/comments","events_url":"https://api.github.com/repos/linkedin/photon-ml/issues/133/events","html_url":"https://github.com/linkedin/photon-ml/issues/133","id":163058147,"number":133,"title":"Make LibSVM format automatically detect feature dimension","user":{"login":"timyitong","id":1464240,"avatar_url":"https://avatars.githubusercontent.com/u/1464240?v=3","gravatar_id":"","url":"https://api.github.com/users/timyitong","html_url":"https://github.com/timyitong","followers_url":"https://api.github.com/users/timyitong/followers","following_url":"https://api.github.com/users/timyitong/following{/other_user}","gists_url":"https://api.github.com/users/timyitong/gists{/gist_id}","starred_url":"https://api.github.com/users/timyitong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timyitong/subscriptions","organizations_url":"https://api.github.com/users/timyitong/orgs","repos_url":"https://api.github.com/users/timyitong/repos","events_url":"https://api.github.com/users/timyitong/events{/privacy}","received_events_url":"https://api.github.com/users/timyitong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-06-30T00:41:33Z","updated_at":"2016-08-23T20:00:07Z","closed_at":null,"body":"@XianXing : I'm just about to implement the auto feature dimension scanning and then realized that there is an issue with previous approach I'm thinking about\r\n```\r\n// Like what we are doing in GLMSuite\r\n\r\nwhen #loadLabledPoints method is called, we try to see whether an indexMap is already loaded.\r\n   If yes:\r\n       we use that one.\r\n   If not:\r\n       we scan dataset one more time to figure out the indexMap (or feature dimension in LibSVM's scenario)\r\n```\r\n\r\nThis approach has a side effect that we are basically assuming indexMapLoader is not gonna be used anywhere before we load training dataset first (and it has to be the training dataset as the 1st dataset we loaded to guarantee that all the indexing is done correctly). Such assumption cannot be derived from trait definitions which made me feel a bit uneasy.\r\n\r\nMaybe we should consider introduce an ```initialize``` method in ```InputFormat``` and configure the indexMap diligently instead of lazily?"},"comment":{"url":"https://api.github.com/repos/linkedin/photon-ml/issues/comments/241857616","html_url":"https://github.com/linkedin/photon-ml/issues/133#issuecomment-241857616","issue_url":"https://api.github.com/repos/linkedin/photon-ml/issues/133","id":241857616,"user":{"login":"XianXing","id":2010084,"avatar_url":"https://avatars.githubusercontent.com/u/2010084?v=3","gravatar_id":"","url":"https://api.github.com/users/XianXing","html_url":"https://github.com/XianXing","followers_url":"https://api.github.com/users/XianXing/followers","following_url":"https://api.github.com/users/XianXing/following{/other_user}","gists_url":"https://api.github.com/users/XianXing/gists{/gist_id}","starred_url":"https://api.github.com/users/XianXing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XianXing/subscriptions","organizations_url":"https://api.github.com/users/XianXing/orgs","repos_url":"https://api.github.com/users/XianXing/repos","events_url":"https://api.github.com/users/XianXing/events{/privacy}","received_events_url":"https://api.github.com/users/XianXing/received_events","type":"User","site_admin":false},"created_at":"2016-08-23T20:00:07Z","updated_at":"2016-08-23T20:00:07Z","body":"Sounds good to me."}}
{"actor":{"display_login":"XianXing"}}