{"action":"created","comment":{"url":"https://api.github.com/repos/glossier/solidus_retail/pulls/comments/80039716","id":80039716,"diff_hunk":"@@ -0,0 +1,24 @@\n+module Shopify","path":"app/services/shopify/association_saver.rb","position":1,"original_position":1,"commit_id":"2272bef1003dca0c57768c8b8ea2ebac6cfbd65f","original_commit_id":"2272bef1003dca0c57768c8b8ea2ebac6cfbd65f","user":{"login":"braidn","id":203346,"avatar_url":"https://avatars.githubusercontent.com/u/203346?v=3","gravatar_id":"","url":"https://api.github.com/users/braidn","html_url":"https://github.com/braidn","followers_url":"https://api.github.com/users/braidn/followers","following_url":"https://api.github.com/users/braidn/following{/other_user}","gists_url":"https://api.github.com/users/braidn/gists{/gist_id}","starred_url":"https://api.github.com/users/braidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braidn/subscriptions","organizations_url":"https://api.github.com/users/braidn/orgs","repos_url":"https://api.github.com/users/braidn/repos","events_url":"https://api.github.com/users/braidn/events{/privacy}","received_events_url":"https://api.github.com/users/braidn/received_events","type":"User","site_admin":false},"body":"Cool! So in this branch this has been moved out to it's own file? I guess you can ignore the other comment in the other branch.","created_at":"2016-09-22T13:29:37Z","updated_at":"2016-09-22T13:32:20Z","html_url":"https://github.com/glossier/solidus_retail/pull/16#discussion_r80039716","pull_request_url":"https://api.github.com/repos/glossier/solidus_retail/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/glossier/solidus_retail/pulls/comments/80039716"},"html":{"href":"https://github.com/glossier/solidus_retail/pull/16#discussion_r80039716"},"pull_request":{"href":"https://api.github.com/repos/glossier/solidus_retail/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/glossier/solidus_retail/pulls/16","id":84579033,"html_url":"https://github.com/glossier/solidus_retail/pull/16","diff_url":"https://github.com/glossier/solidus_retail/pull/16.diff","patch_url":"https://github.com/glossier/solidus_retail/pull/16.patch","issue_url":"https://api.github.com/repos/glossier/solidus_retail/issues/16","number":16,"state":"open","locked":false,"title":"Export variants (master variant) during the first export","user":{"login":"cabouffard","id":1725061,"avatar_url":"https://avatars.githubusercontent.com/u/1725061?v=3","gravatar_id":"","url":"https://api.github.com/users/cabouffard","html_url":"https://github.com/cabouffard","followers_url":"https://api.github.com/users/cabouffard/followers","following_url":"https://api.github.com/users/cabouffard/following{/other_user}","gists_url":"https://api.github.com/users/cabouffard/gists{/gist_id}","starred_url":"https://api.github.com/users/cabouffard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cabouffard/subscriptions","organizations_url":"https://api.github.com/users/cabouffard/orgs","repos_url":"https://api.github.com/users/cabouffard/repos","events_url":"https://api.github.com/users/cabouffard/events{/privacy}","received_events_url":"https://api.github.com/users/cabouffard/received_events","type":"User","site_admin":false},"body":"The way that it works right now is that the exporter will export the\r\nwhole product, which means all of its variant.\r\n\r\nUpdaters will now only update self. So if we go in the admin and we\r\ndecide to update a unique product or a unique variant, then it will\r\nupdate itself instead of saving the whole product will all of its\r\nvariant.\r\n\r\nThere is still some work to do in order to reduce the code that is\r\nduplicated but that should still be good for CRing.\r\n\r\nThe goal is to run the exporter only once at the beginning of the\r\nproject, so fill the Shopify store with proper data. We were kind of\r\nobligated to do that, since if we don't assign any variant to the\r\nproduct when we create it, it assigns a dummy variant that is hard to\r\nget rid of. I tried just to export the master variant when creating a\r\nnew product but it was really pain in the arse. This came out to be the\r\nbest solution I could come up with.","created_at":"2016-09-09T01:04:14Z","updated_at":"2016-09-22T13:32:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef93590d6eb4867c6a0e145285cefa61be0684e0","assignee":{"login":"cabouffard","id":1725061,"avatar_url":"https://avatars.githubusercontent.com/u/1725061?v=3","gravatar_id":"","url":"https://api.github.com/users/cabouffard","html_url":"https://github.com/cabouffard","followers_url":"https://api.github.com/users/cabouffard/followers","following_url":"https://api.github.com/users/cabouffard/following{/other_user}","gists_url":"https://api.github.com/users/cabouffard/gists{/gist_id}","starred_url":"https://api.github.com/users/cabouffard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cabouffard/subscriptions","organizations_url":"https://api.github.com/users/cabouffard/orgs","repos_url":"https://api.github.com/users/cabouffard/repos","events_url":"https://api.github.com/users/cabouffard/events{/privacy}","received_events_url":"https://api.github.com/users/cabouffard/received_events","type":"User","site_admin":false},"assignees":[{"login":"cabouffard","id":1725061,"avatar_url":"https://avatars.githubusercontent.com/u/1725061?v=3","gravatar_id":"","url":"https://api.github.com/users/cabouffard","html_url":"https://github.com/cabouffard","followers_url":"https://api.github.com/users/cabouffard/followers","following_url":"https://api.github.com/users/cabouffard/following{/other_user}","gists_url":"https://api.github.com/users/cabouffard/gists{/gist_id}","starred_url":"https://api.github.com/users/cabouffard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cabouffard/subscriptions","organizations_url":"https://api.github.com/users/cabouffard/orgs","repos_url":"https://api.github.com/users/cabouffard/repos","events_url":"https://api.github.com/users/cabouffard/events{/privacy}","received_events_url":"https://api.github.com/users/cabouffard/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/glossier/solidus_retail/pulls/16/commits","review_comments_url":"https://api.github.com/repos/glossier/solidus_retail/pulls/16/comments","review_comment_url":"https://api.github.com/repos/glossier/solidus_retail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/glossier/solidus_retail/issues/16/comments","statuses_url":"https://api.github.com/repos/glossier/solidus_retail/statuses/2272bef1003dca0c57768c8b8ea2ebac6cfbd65f","head":{"label":"glossier:feature/shopify/master-variant-export","ref":"feature/shopify/master-variant-export","sha":"2272bef1003dca0c57768c8b8ea2ebac6cfbd65f","user":{"login":"glossier","id":13021459,"avatar_url":"https://avatars.githubusercontent.com/u/13021459?v=3","gravatar_id":"","url":"https://api.github.com/users/glossier","html_url":"https://github.com/glossier","followers_url":"https://api.github.com/users/glossier/followers","following_url":"https://api.github.com/users/glossier/following{/other_user}","gists_url":"https://api.github.com/users/glossier/gists{/gist_id}","starred_url":"https://api.github.com/users/glossier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glossier/subscriptions","organizations_url":"https://api.github.com/users/glossier/orgs","repos_url":"https://api.github.com/users/glossier/repos","events_url":"https://api.github.com/users/glossier/events{/privacy}","received_events_url":"https://api.github.com/users/glossier/received_events","type":"Organization","site_admin":false},"repo":{"id":65317430,"name":"solidus_retail","full_name":"glossier/solidus_retail","owner":{"login":"glossier","id":13021459,"avatar_url":"https://avatars.githubusercontent.com/u/13021459?v=3","gravatar_id":"","url":"https://api.github.com/users/glossier","html_url":"https://github.com/glossier","followers_url":"https://api.github.com/users/glossier/followers","following_url":"https://api.github.com/users/glossier/following{/other_user}","gists_url":"https://api.github.com/users/glossier/gists{/gist_id}","starred_url":"https://api.github.com/users/glossier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glossier/subscriptions","organizations_url":"https://api.github.com/users/glossier/orgs","repos_url":"https://api.github.com/users/glossier/repos","events_url":"https://api.github.com/users/glossier/events{/privacy}","received_events_url":"https://api.github.com/users/glossier/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/glossier/solidus_retail","description":"Solidus Extension to Support Retail Operations","fork":false,"url":"https://api.github.com/repos/glossier/solidus_retail","forks_url":"https://api.github.com/repos/glossier/solidus_retail/forks","keys_url":"https://api.github.com/repos/glossier/solidus_retail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glossier/solidus_retail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glossier/solidus_retail/teams","hooks_url":"https://api.github.com/repos/glossier/solidus_retail/hooks","issue_events_url":"https://api.github.com/repos/glossier/solidus_retail/issues/events{/number}","events_url":"https://api.github.com/repos/glossier/solidus_retail/events","assignees_url":"https://api.github.com/repos/glossier/solidus_retail/assignees{/user}","branches_url":"https://api.github.com/repos/glossier/solidus_retail/branches{/branch}","tags_url":"https://api.github.com/repos/glossier/solidus_retail/tags","blobs_url":"https://api.github.com/repos/glossier/solidus_retail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glossier/solidus_retail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glossier/solidus_retail/git/refs{/sha}","trees_url":"https://api.github.com/repos/glossier/solidus_retail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glossier/solidus_retail/statuses/{sha}","languages_url":"https://api.github.com/repos/glossier/solidus_retail/languages","stargazers_url":"https://api.github.com/repos/glossier/solidus_retail/stargazers","contributors_url":"https://api.github.com/repos/glossier/solidus_retail/contributors","subscribers_url":"https://api.github.com/repos/glossier/solidus_retail/subscribers","subscription_url":"https://api.github.com/repos/glossier/solidus_retail/subscription","commits_url":"https://api.github.com/repos/glossier/solidus_retail/commits{/sha}","git_commits_url":"https://api.github.com/repos/glossier/solidus_retail/git/commits{/sha}","comments_url":"https://api.github.com/repos/glossier/solidus_retail/comments{/number}","issue_comment_url":"https://api.github.com/repos/glossier/solidus_retail/issues/comments{/number}","contents_url":"https://api.github.com/repos/glossier/solidus_retail/contents/{+path}","compare_url":"https://api.github.com/repos/glossier/solidus_retail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glossier/solidus_retail/merges","archive_url":"https://api.github.com/repos/glossier/solidus_retail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glossier/solidus_retail/downloads","issues_url":"https://api.github.com/repos/glossier/solidus_retail/issues{/number}","pulls_url":"https://api.github.com/repos/glossier/solidus_retail/pulls{/number}","milestones_url":"https://api.github.com/repos/glossier/solidus_retail/milestones{/number}","notifications_url":"https://api.github.com/repos/glossier/solidus_retail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glossier/solidus_retail/labels{/name}","releases_url":"https://api.github.com/repos/glossier/solidus_retail/releases{/id}","deployments_url":"https://api.github.com/repos/glossier/solidus_retail/deployments","created_at":"2016-08-09T18:08:51Z","updated_at":"2016-08-09T18:55:10Z","pushed_at":"2016-09-21T18:32:50Z","git_url":"git://github.com/glossier/solidus_retail.git","ssh_url":"git@github.com:glossier/solidus_retail.git","clone_url":"https://github.com/glossier/solidus_retail.git","svn_url":"https://github.com/glossier/solidus_retail","homepage":null,"size":989,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":0,"default_branch":"master"}},"base":{"label":"glossier:master","ref":"master","sha":"de4a42481a3f3e26f98c98d14bc2de7f37ccf190","user":{"login":"glossier","id":13021459,"avatar_url":"https://avatars.githubusercontent.com/u/13021459?v=3","gravatar_id":"","url":"https://api.github.com/users/glossier","html_url":"https://github.com/glossier","followers_url":"https://api.github.com/users/glossier/followers","following_url":"https://api.github.com/users/glossier/following{/other_user}","gists_url":"https://api.github.com/users/glossier/gists{/gist_id}","starred_url":"https://api.github.com/users/glossier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glossier/subscriptions","organizations_url":"https://api.github.com/users/glossier/orgs","repos_url":"https://api.github.com/users/glossier/repos","events_url":"https://api.github.com/users/glossier/events{/privacy}","received_events_url":"https://api.github.com/users/glossier/received_events","type":"Organization","site_admin":false},"repo":{"id":65317430,"name":"solidus_retail","full_name":"glossier/solidus_retail","owner":{"login":"glossier","id":13021459,"avatar_url":"https://avatars.githubusercontent.com/u/13021459?v=3","gravatar_id":"","url":"https://api.github.com/users/glossier","html_url":"https://github.com/glossier","followers_url":"https://api.github.com/users/glossier/followers","following_url":"https://api.github.com/users/glossier/following{/other_user}","gists_url":"https://api.github.com/users/glossier/gists{/gist_id}","starred_url":"https://api.github.com/users/glossier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glossier/subscriptions","organizations_url":"https://api.github.com/users/glossier/orgs","repos_url":"https://api.github.com/users/glossier/repos","events_url":"https://api.github.com/users/glossier/events{/privacy}","received_events_url":"https://api.github.com/users/glossier/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/glossier/solidus_retail","description":"Solidus Extension to Support Retail Operations","fork":false,"url":"https://api.github.com/repos/glossier/solidus_retail","forks_url":"https://api.github.com/repos/glossier/solidus_retail/forks","keys_url":"https://api.github.com/repos/glossier/solidus_retail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glossier/solidus_retail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glossier/solidus_retail/teams","hooks_url":"https://api.github.com/repos/glossier/solidus_retail/hooks","issue_events_url":"https://api.github.com/repos/glossier/solidus_retail/issues/events{/number}","events_url":"https://api.github.com/repos/glossier/solidus_retail/events","assignees_url":"https://api.github.com/repos/glossier/solidus_retail/assignees{/user}","branches_url":"https://api.github.com/repos/glossier/solidus_retail/branches{/branch}","tags_url":"https://api.github.com/repos/glossier/solidus_retail/tags","blobs_url":"https://api.github.com/repos/glossier/solidus_retail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glossier/solidus_retail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glossier/solidus_retail/git/refs{/sha}","trees_url":"https://api.github.com/repos/glossier/solidus_retail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glossier/solidus_retail/statuses/{sha}","languages_url":"https://api.github.com/repos/glossier/solidus_retail/languages","stargazers_url":"https://api.github.com/repos/glossier/solidus_retail/stargazers","contributors_url":"https://api.github.com/repos/glossier/solidus_retail/contributors","subscribers_url":"https://api.github.com/repos/glossier/solidus_retail/subscribers","subscription_url":"https://api.github.com/repos/glossier/solidus_retail/subscription","commits_url":"https://api.github.com/repos/glossier/solidus_retail/commits{/sha}","git_commits_url":"https://api.github.com/repos/glossier/solidus_retail/git/commits{/sha}","comments_url":"https://api.github.com/repos/glossier/solidus_retail/comments{/number}","issue_comment_url":"https://api.github.com/repos/glossier/solidus_retail/issues/comments{/number}","contents_url":"https://api.github.com/repos/glossier/solidus_retail/contents/{+path}","compare_url":"https://api.github.com/repos/glossier/solidus_retail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glossier/solidus_retail/merges","archive_url":"https://api.github.com/repos/glossier/solidus_retail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glossier/solidus_retail/downloads","issues_url":"https://api.github.com/repos/glossier/solidus_retail/issues{/number}","pulls_url":"https://api.github.com/repos/glossier/solidus_retail/pulls{/number}","milestones_url":"https://api.github.com/repos/glossier/solidus_retail/milestones{/number}","notifications_url":"https://api.github.com/repos/glossier/solidus_retail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glossier/solidus_retail/labels{/name}","releases_url":"https://api.github.com/repos/glossier/solidus_retail/releases{/id}","deployments_url":"https://api.github.com/repos/glossier/solidus_retail/deployments","created_at":"2016-08-09T18:08:51Z","updated_at":"2016-08-09T18:55:10Z","pushed_at":"2016-09-21T18:32:50Z","git_url":"git://github.com/glossier/solidus_retail.git","ssh_url":"git@github.com:glossier/solidus_retail.git","clone_url":"https://github.com/glossier/solidus_retail.git","svn_url":"https://github.com/glossier/solidus_retail","homepage":null,"size":989,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/glossier/solidus_retail/pulls/16"},"html":{"href":"https://github.com/glossier/solidus_retail/pull/16"},"issue":{"href":"https://api.github.com/repos/glossier/solidus_retail/issues/16"},"comments":{"href":"https://api.github.com/repos/glossier/solidus_retail/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/glossier/solidus_retail/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/glossier/solidus_retail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/glossier/solidus_retail/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/glossier/solidus_retail/statuses/2272bef1003dca0c57768c8b8ea2ebac6cfbd65f"}}}}
{"actor":{"display_login":"braidn"}}