{"action":"opened","number":8215,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/8215","id":82116751,"html_url":"https://github.com/nodejs/node/pull/8215","diff_url":"https://github.com/nodejs/node/pull/8215.diff","patch_url":"https://github.com/nodejs/node/pull/8215.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/8215","number":8215,"state":"open","locked":false,"title":"url: keep auth in `url.resolve()` if host matches","user":{"login":"imyller","id":1898870,"avatar_url":"https://avatars.githubusercontent.com/u/1898870?v=3","gravatar_id":"","url":"https://api.github.com/users/imyller","html_url":"https://github.com/imyller","followers_url":"https://api.github.com/users/imyller/followers","following_url":"https://api.github.com/users/imyller/following{/other_user}","gists_url":"https://api.github.com/users/imyller/gists{/gist_id}","starred_url":"https://api.github.com/users/imyller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imyller/subscriptions","organizations_url":"https://api.github.com/users/imyller/orgs","repos_url":"https://api.github.com/users/imyller/repos","events_url":"https://api.github.com/users/imyller/events{/privacy}","received_events_url":"https://api.github.com/users/imyller/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\n\r\nurl\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\nKeep `auth` in URL if `host` and `hostname` is not changed.\r\n\r\nFixes regression introduced in PR #1480\r\n\r\nFixes: https://github.com/nodejs/node/issues/8165","created_at":"2016-08-21T20:50:34Z","updated_at":"2016-08-21T20:50:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e098a7eac60ef81294a5b5ec5f4b929ff06ae58","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/8215/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/8215/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/8215/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/5cbab64a168a8ec8f0f3a63d0b226ef64d45e361","head":{"label":"imyller:url-resolve-auth","ref":"url-resolve-auth","sha":"5cbab64a168a8ec8f0f3a63d0b226ef64d45e361","user":{"login":"imyller","id":1898870,"avatar_url":"https://avatars.githubusercontent.com/u/1898870?v=3","gravatar_id":"","url":"https://api.github.com/users/imyller","html_url":"https://github.com/imyller","followers_url":"https://api.github.com/users/imyller/followers","following_url":"https://api.github.com/users/imyller/following{/other_user}","gists_url":"https://api.github.com/users/imyller/gists{/gist_id}","starred_url":"https://api.github.com/users/imyller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imyller/subscriptions","organizations_url":"https://api.github.com/users/imyller/orgs","repos_url":"https://api.github.com/users/imyller/repos","events_url":"https://api.github.com/users/imyller/events{/privacy}","received_events_url":"https://api.github.com/users/imyller/received_events","type":"User","site_admin":false},"repo":{"id":35809730,"name":"node","full_name":"imyller/node","owner":{"login":"imyller","id":1898870,"avatar_url":"https://avatars.githubusercontent.com/u/1898870?v=3","gravatar_id":"","url":"https://api.github.com/users/imyller","html_url":"https://github.com/imyller","followers_url":"https://api.github.com/users/imyller/followers","following_url":"https://api.github.com/users/imyller/following{/other_user}","gists_url":"https://api.github.com/users/imyller/gists{/gist_id}","starred_url":"https://api.github.com/users/imyller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imyller/subscriptions","organizations_url":"https://api.github.com/users/imyller/orgs","repos_url":"https://api.github.com/users/imyller/repos","events_url":"https://api.github.com/users/imyller/events{/privacy}","received_events_url":"https://api.github.com/users/imyller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imyller/node","description":"Node.js JavaScript runtime ✨🐢🚀✨","fork":true,"url":"https://api.github.com/repos/imyller/node","forks_url":"https://api.github.com/repos/imyller/node/forks","keys_url":"https://api.github.com/repos/imyller/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imyller/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imyller/node/teams","hooks_url":"https://api.github.com/repos/imyller/node/hooks","issue_events_url":"https://api.github.com/repos/imyller/node/issues/events{/number}","events_url":"https://api.github.com/repos/imyller/node/events","assignees_url":"https://api.github.com/repos/imyller/node/assignees{/user}","branches_url":"https://api.github.com/repos/imyller/node/branches{/branch}","tags_url":"https://api.github.com/repos/imyller/node/tags","blobs_url":"https://api.github.com/repos/imyller/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imyller/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imyller/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/imyller/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imyller/node/statuses/{sha}","languages_url":"https://api.github.com/repos/imyller/node/languages","stargazers_url":"https://api.github.com/repos/imyller/node/stargazers","contributors_url":"https://api.github.com/repos/imyller/node/contributors","subscribers_url":"https://api.github.com/repos/imyller/node/subscribers","subscription_url":"https://api.github.com/repos/imyller/node/subscription","commits_url":"https://api.github.com/repos/imyller/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/imyller/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/imyller/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/imyller/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/imyller/node/contents/{+path}","compare_url":"https://api.github.com/repos/imyller/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imyller/node/merges","archive_url":"https://api.github.com/repos/imyller/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imyller/node/downloads","issues_url":"https://api.github.com/repos/imyller/node/issues{/number}","pulls_url":"https://api.github.com/repos/imyller/node/pulls{/number}","milestones_url":"https://api.github.com/repos/imyller/node/milestones{/number}","notifications_url":"https://api.github.com/repos/imyller/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imyller/node/labels{/name}","releases_url":"https://api.github.com/repos/imyller/node/releases{/id}","deployments_url":"https://api.github.com/repos/imyller/node/deployments","created_at":"2015-05-18T09:45:06Z","updated_at":"2016-08-11T20:27:03Z","pushed_at":"2016-08-21T20:30:02Z","git_url":"git://github.com/imyller/node.git","ssh_url":"git@github.com:imyller/node.git","clone_url":"https://github.com/imyller/node.git","svn_url":"https://github.com/imyller/node","homepage":"https://nodejs.org","size":217301,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"ce8753a4cef57d94fb46b6a76a2bf59a8e969fbb","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-08-21T16:57:12Z","pushed_at":"2016-08-21T20:50:35Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":292980,"stargazers_count":25932,"watchers_count":25932,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4003,"mirror_url":null,"open_issues_count":760,"forks":4003,"open_issues":760,"watchers":25932,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/8215"},"html":{"href":"https://github.com/nodejs/node/pull/8215"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/8215"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/8215/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/8215/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/8215/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/5cbab64a168a8ec8f0f3a63d0b226ef64d45e361"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"imyller"}}