{"action":"created","comment":{"url":"https://api.github.com/repos/getlantern/lantern/pulls/comments/61529574","id":61529574,"diff_hunk":"@@ -199,10 +184,27 @@ func processFeed(provider FeedProvider) {\n \t\tif desc == \"\" {\n \t\t\tdesc = entry.Content\n \t\t}\n-\n \t\tfeed.Entries[i].Description = desc\n \t}\n \n+\t// the 'all' tab contains every article that's not associated with an\n+\t// excluded feed.\n+\tall := make(FeedItems, 0, len(feed.Entries))\n+\tfor _, entry := range feed.Entries {\n+\t\tif !feed.Feeds[entry.Source].ExcludeFromAll {\n+\t\t\tall = append(all, entry)\n+\t\t}\n+\t}\n+\tfeed.Items[allStr] = all\n+\n+\t// Get a list of feed sources & send those back to the UI\n+\tfor _, s := range feed.Sorted {\n+\t\tif entry, ok := feed.Feeds[s]; ok {\n+\t\t\tlog.Debugf(\"Adding feed source: %s\", entry.Title)\n+\t\t\tprovider.AddSource(entry.Title)\n+\t\t}","path":"src/github.com/getlantern/lantern/feed.go","position":80,"original_position":80,"commit_id":"5d4752d6ab6afad83036ffb4849d2d4a65893fc5","original_commit_id":"5d4752d6ab6afad83036ffb4849d2d4a65893fc5","user":{"login":"myleshorton","id":1143966,"avatar_url":"https://avatars.githubusercontent.com/u/1143966?v=3","gravatar_id":"","url":"https://api.github.com/users/myleshorton","html_url":"https://github.com/myleshorton","followers_url":"https://api.github.com/users/myleshorton/followers","following_url":"https://api.github.com/users/myleshorton/following{/other_user}","gists_url":"https://api.github.com/users/myleshorton/gists{/gist_id}","starred_url":"https://api.github.com/users/myleshorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myleshorton/subscriptions","organizations_url":"https://api.github.com/users/myleshorton/orgs","repos_url":"https://api.github.com/users/myleshorton/repos","events_url":"https://api.github.com/users/myleshorton/events{/privacy}","received_events_url":"https://api.github.com/users/myleshorton/received_events","type":"User","site_admin":false},"body":"Also would be useful to log an error here if we are trying to find a feed that's not in the map (would again indicate a pretty big issue with the feed).","created_at":"2016-04-29T02:33:53Z","updated_at":"2016-04-29T02:33:53Z","html_url":"https://github.com/getlantern/lantern/pull/4154#discussion_r61529574","pull_request_url":"https://api.github.com/repos/getlantern/lantern/pulls/4154","_links":{"self":{"href":"https://api.github.com/repos/getlantern/lantern/pulls/comments/61529574"},"html":{"href":"https://github.com/getlantern/lantern/pull/4154#discussion_r61529574"},"pull_request":{"href":"https://api.github.com/repos/getlantern/lantern/pulls/4154"}}},"pull_request":{"url":"https://api.github.com/repos/getlantern/lantern/pulls/4154","id":68300968,"html_url":"https://github.com/getlantern/lantern/pull/4154","diff_url":"https://github.com/getlantern/lantern/pull/4154.diff","patch_url":"https://github.com/getlantern/lantern/pull/4154.patch","issue_url":"https://api.github.com/repos/getlantern/lantern/issues/4154","number":4154,"state":"open","locked":false,"title":"Sort feeds on mobile","user":{"login":"atavism","id":6346213,"avatar_url":"https://avatars.githubusercontent.com/u/6346213?v=3","gravatar_id":"","url":"https://api.github.com/users/atavism","html_url":"https://github.com/atavism","followers_url":"https://api.github.com/users/atavism/followers","following_url":"https://api.github.com/users/atavism/following{/other_user}","gists_url":"https://api.github.com/users/atavism/gists{/gist_id}","starred_url":"https://api.github.com/users/atavism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atavism/subscriptions","organizations_url":"https://api.github.com/users/atavism/orgs","repos_url":"https://api.github.com/users/atavism/repos","events_url":"https://api.github.com/users/atavism/events{/privacy}","received_events_url":"https://api.github.com/users/atavism/received_events","type":"User","site_admin":false},"body":"This resolves https://github.com/getlantern/lantern/issues/4153 and it also a fixes an issue where we were using \"all\" instead of the translated string resource for the feed containing every article.","created_at":"2016-04-28T22:29:27Z","updated_at":"2016-04-29T02:33:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cc4321f390f7edf001ac98fdae44404cf08c45d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/getlantern/lantern/pulls/4154/commits","review_comments_url":"https://api.github.com/repos/getlantern/lantern/pulls/4154/comments","review_comment_url":"https://api.github.com/repos/getlantern/lantern/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getlantern/lantern/issues/4154/comments","statuses_url":"https://api.github.com/repos/getlantern/lantern/statuses/5d4752d6ab6afad83036ffb4849d2d4a65893fc5","head":{"label":"getlantern:release-2.2.0-sort-feeds","ref":"release-2.2.0-sort-feeds","sha":"5d4752d6ab6afad83036ffb4849d2d4a65893fc5","user":{"login":"getlantern","id":624178,"avatar_url":"https://avatars.githubusercontent.com/u/624178?v=3","gravatar_id":"","url":"https://api.github.com/users/getlantern","html_url":"https://github.com/getlantern","followers_url":"https://api.github.com/users/getlantern/followers","following_url":"https://api.github.com/users/getlantern/following{/other_user}","gists_url":"https://api.github.com/users/getlantern/gists{/gist_id}","starred_url":"https://api.github.com/users/getlantern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getlantern/subscriptions","organizations_url":"https://api.github.com/users/getlantern/orgs","repos_url":"https://api.github.com/users/getlantern/repos","events_url":"https://api.github.com/users/getlantern/events{/privacy}","received_events_url":"https://api.github.com/users/getlantern/received_events","type":"Organization","site_admin":false},"repo":{"id":1380117,"name":"lantern","full_name":"getlantern/lantern","owner":{"login":"getlantern","id":624178,"avatar_url":"https://avatars.githubusercontent.com/u/624178?v=3","gravatar_id":"","url":"https://api.github.com/users/getlantern","html_url":"https://github.com/getlantern","followers_url":"https://api.github.com/users/getlantern/followers","following_url":"https://api.github.com/users/getlantern/following{/other_user}","gists_url":"https://api.github.com/users/getlantern/gists{/gist_id}","starred_url":"https://api.github.com/users/getlantern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getlantern/subscriptions","organizations_url":"https://api.github.com/users/getlantern/orgs","repos_url":"https://api.github.com/users/getlantern/repos","events_url":"https://api.github.com/users/getlantern/events{/privacy}","received_events_url":"https://api.github.com/users/getlantern/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getlantern/lantern","description":":zap: Open Internet for everyone. Lantern is a free desktop application that delivers fast, reliable and secure access to the open Internet for users in censored regions. It uses a variety of techniques to stay unblocked, including P2P and domain fronting. Lantern relies on users in uncensored regions acting as access points to the open Internet.","fork":false,"url":"https://api.github.com/repos/getlantern/lantern","forks_url":"https://api.github.com/repos/getlantern/lantern/forks","keys_url":"https://api.github.com/repos/getlantern/lantern/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getlantern/lantern/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getlantern/lantern/teams","hooks_url":"https://api.github.com/repos/getlantern/lantern/hooks","issue_events_url":"https://api.github.com/repos/getlantern/lantern/issues/events{/number}","events_url":"https://api.github.com/repos/getlantern/lantern/events","assignees_url":"https://api.github.com/repos/getlantern/lantern/assignees{/user}","branches_url":"https://api.github.com/repos/getlantern/lantern/branches{/branch}","tags_url":"https://api.github.com/repos/getlantern/lantern/tags","blobs_url":"https://api.github.com/repos/getlantern/lantern/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getlantern/lantern/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getlantern/lantern/git/refs{/sha}","trees_url":"https://api.github.com/repos/getlantern/lantern/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getlantern/lantern/statuses/{sha}","languages_url":"https://api.github.com/repos/getlantern/lantern/languages","stargazers_url":"https://api.github.com/repos/getlantern/lantern/stargazers","contributors_url":"https://api.github.com/repos/getlantern/lantern/contributors","subscribers_url":"https://api.github.com/repos/getlantern/lantern/subscribers","subscription_url":"https://api.github.com/repos/getlantern/lantern/subscription","commits_url":"https://api.github.com/repos/getlantern/lantern/commits{/sha}","git_commits_url":"https://api.github.com/repos/getlantern/lantern/git/commits{/sha}","comments_url":"https://api.github.com/repos/getlantern/lantern/comments{/number}","issue_comment_url":"https://api.github.com/repos/getlantern/lantern/issues/comments{/number}","contents_url":"https://api.github.com/repos/getlantern/lantern/contents/{+path}","compare_url":"https://api.github.com/repos/getlantern/lantern/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getlantern/lantern/merges","archive_url":"https://api.github.com/repos/getlantern/lantern/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getlantern/lantern/downloads","issues_url":"https://api.github.com/repos/getlantern/lantern/issues{/number}","pulls_url":"https://api.github.com/repos/getlantern/lantern/pulls{/number}","milestones_url":"https://api.github.com/repos/getlantern/lantern/milestones{/number}","notifications_url":"https://api.github.com/repos/getlantern/lantern/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getlantern/lantern/labels{/name}","releases_url":"https://api.github.com/repos/getlantern/lantern/releases{/id}","deployments_url":"https://api.github.com/repos/getlantern/lantern/deployments","created_at":"2011-02-17T22:12:29Z","updated_at":"2016-04-29T01:51:28Z","pushed_at":"2016-04-29T00:58:33Z","git_url":"git://github.com/getlantern/lantern.git","ssh_url":"git@github.com:getlantern/lantern.git","clone_url":"https://github.com/getlantern/lantern.git","svn_url":"https://github.com/getlantern/lantern","homepage":"https://getlantern.org","size":1223503,"stargazers_count":13963,"watchers_count":13963,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3591,"mirror_url":null,"open_issues_count":407,"forks":3591,"open_issues":407,"watchers":13963,"default_branch":"devel"}},"base":{"label":"getlantern:release-2.2.0","ref":"release-2.2.0","sha":"815c5af496c27c20a3cc7ecac83d7f4c07a9dace","user":{"login":"getlantern","id":624178,"avatar_url":"https://avatars.githubusercontent.com/u/624178?v=3","gravatar_id":"","url":"https://api.github.com/users/getlantern","html_url":"https://github.com/getlantern","followers_url":"https://api.github.com/users/getlantern/followers","following_url":"https://api.github.com/users/getlantern/following{/other_user}","gists_url":"https://api.github.com/users/getlantern/gists{/gist_id}","starred_url":"https://api.github.com/users/getlantern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getlantern/subscriptions","organizations_url":"https://api.github.com/users/getlantern/orgs","repos_url":"https://api.github.com/users/getlantern/repos","events_url":"https://api.github.com/users/getlantern/events{/privacy}","received_events_url":"https://api.github.com/users/getlantern/received_events","type":"Organization","site_admin":false},"repo":{"id":1380117,"name":"lantern","full_name":"getlantern/lantern","owner":{"login":"getlantern","id":624178,"avatar_url":"https://avatars.githubusercontent.com/u/624178?v=3","gravatar_id":"","url":"https://api.github.com/users/getlantern","html_url":"https://github.com/getlantern","followers_url":"https://api.github.com/users/getlantern/followers","following_url":"https://api.github.com/users/getlantern/following{/other_user}","gists_url":"https://api.github.com/users/getlantern/gists{/gist_id}","starred_url":"https://api.github.com/users/getlantern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getlantern/subscriptions","organizations_url":"https://api.github.com/users/getlantern/orgs","repos_url":"https://api.github.com/users/getlantern/repos","events_url":"https://api.github.com/users/getlantern/events{/privacy}","received_events_url":"https://api.github.com/users/getlantern/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getlantern/lantern","description":":zap: Open Internet for everyone. Lantern is a free desktop application that delivers fast, reliable and secure access to the open Internet for users in censored regions. It uses a variety of techniques to stay unblocked, including P2P and domain fronting. Lantern relies on users in uncensored regions acting as access points to the open Internet.","fork":false,"url":"https://api.github.com/repos/getlantern/lantern","forks_url":"https://api.github.com/repos/getlantern/lantern/forks","keys_url":"https://api.github.com/repos/getlantern/lantern/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getlantern/lantern/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getlantern/lantern/teams","hooks_url":"https://api.github.com/repos/getlantern/lantern/hooks","issue_events_url":"https://api.github.com/repos/getlantern/lantern/issues/events{/number}","events_url":"https://api.github.com/repos/getlantern/lantern/events","assignees_url":"https://api.github.com/repos/getlantern/lantern/assignees{/user}","branches_url":"https://api.github.com/repos/getlantern/lantern/branches{/branch}","tags_url":"https://api.github.com/repos/getlantern/lantern/tags","blobs_url":"https://api.github.com/repos/getlantern/lantern/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getlantern/lantern/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getlantern/lantern/git/refs{/sha}","trees_url":"https://api.github.com/repos/getlantern/lantern/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getlantern/lantern/statuses/{sha}","languages_url":"https://api.github.com/repos/getlantern/lantern/languages","stargazers_url":"https://api.github.com/repos/getlantern/lantern/stargazers","contributors_url":"https://api.github.com/repos/getlantern/lantern/contributors","subscribers_url":"https://api.github.com/repos/getlantern/lantern/subscribers","subscription_url":"https://api.github.com/repos/getlantern/lantern/subscription","commits_url":"https://api.github.com/repos/getlantern/lantern/commits{/sha}","git_commits_url":"https://api.github.com/repos/getlantern/lantern/git/commits{/sha}","comments_url":"https://api.github.com/repos/getlantern/lantern/comments{/number}","issue_comment_url":"https://api.github.com/repos/getlantern/lantern/issues/comments{/number}","contents_url":"https://api.github.com/repos/getlantern/lantern/contents/{+path}","compare_url":"https://api.github.com/repos/getlantern/lantern/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getlantern/lantern/merges","archive_url":"https://api.github.com/repos/getlantern/lantern/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getlantern/lantern/downloads","issues_url":"https://api.github.com/repos/getlantern/lantern/issues{/number}","pulls_url":"https://api.github.com/repos/getlantern/lantern/pulls{/number}","milestones_url":"https://api.github.com/repos/getlantern/lantern/milestones{/number}","notifications_url":"https://api.github.com/repos/getlantern/lantern/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getlantern/lantern/labels{/name}","releases_url":"https://api.github.com/repos/getlantern/lantern/releases{/id}","deployments_url":"https://api.github.com/repos/getlantern/lantern/deployments","created_at":"2011-02-17T22:12:29Z","updated_at":"2016-04-29T01:51:28Z","pushed_at":"2016-04-29T00:58:33Z","git_url":"git://github.com/getlantern/lantern.git","ssh_url":"git@github.com:getlantern/lantern.git","clone_url":"https://github.com/getlantern/lantern.git","svn_url":"https://github.com/getlantern/lantern","homepage":"https://getlantern.org","size":1223503,"stargazers_count":13963,"watchers_count":13963,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3591,"mirror_url":null,"open_issues_count":407,"forks":3591,"open_issues":407,"watchers":13963,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/getlantern/lantern/pulls/4154"},"html":{"href":"https://github.com/getlantern/lantern/pull/4154"},"issue":{"href":"https://api.github.com/repos/getlantern/lantern/issues/4154"},"comments":{"href":"https://api.github.com/repos/getlantern/lantern/issues/4154/comments"},"review_comments":{"href":"https://api.github.com/repos/getlantern/lantern/pulls/4154/comments"},"review_comment":{"href":"https://api.github.com/repos/getlantern/lantern/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getlantern/lantern/pulls/4154/commits"},"statuses":{"href":"https://api.github.com/repos/getlantern/lantern/statuses/5d4752d6ab6afad83036ffb4849d2d4a65893fc5"}}}}