{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/12374","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/12374/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/12374/comments","events_url":"https://api.github.com/repos/apache/spark/issues/12374/events","html_url":"https://github.com/apache/spark/pull/12374","id":148214176,"number":12374,"title":"[SPARK-14610][ML] Remove superfluous split for continuous features in decision tree training","user":{"login":"sethah","id":7275795,"avatar_url":"https://avatars.githubusercontent.com/u/7275795?v=3","gravatar_id":"","url":"https://api.github.com/users/sethah","html_url":"https://github.com/sethah","followers_url":"https://api.github.com/users/sethah/followers","following_url":"https://api.github.com/users/sethah/following{/other_user}","gists_url":"https://api.github.com/users/sethah/gists{/gist_id}","starred_url":"https://api.github.com/users/sethah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethah/subscriptions","organizations_url":"https://api.github.com/users/sethah/orgs","repos_url":"https://api.github.com/users/sethah/repos","events_url":"https://api.github.com/users/sethah/events{/privacy}","received_events_url":"https://api.github.com/users/sethah/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-04-13T23:54:25Z","updated_at":"2016-07-06T23:00:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/12374","html_url":"https://github.com/apache/spark/pull/12374","diff_url":"https://github.com/apache/spark/pull/12374.diff","patch_url":"https://github.com/apache/spark/pull/12374.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nA nonsensical split is produced from method `findSplitsForContinuousFeature` for decision trees. This PR removes the superfluous split and updates unit tests accordingly. Additionally, an assertion to check that the number of found splits is `> 0` is removed, and instead features with zero possible splits are ignored. \r\n\r\n## How was this patch tested?\r\n\r\nA unit test was added to check that finding splits for a constant feature produces an empty array.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/230933025","html_url":"https://github.com/apache/spark/pull/12374#issuecomment-230933025","issue_url":"https://api.github.com/repos/apache/spark/issues/12374","id":230933025,"user":{"login":"MechCoder","id":1867024,"avatar_url":"https://avatars.githubusercontent.com/u/1867024?v=3","gravatar_id":"","url":"https://api.github.com/users/MechCoder","html_url":"https://github.com/MechCoder","followers_url":"https://api.github.com/users/MechCoder/followers","following_url":"https://api.github.com/users/MechCoder/following{/other_user}","gists_url":"https://api.github.com/users/MechCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/MechCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MechCoder/subscriptions","organizations_url":"https://api.github.com/users/MechCoder/orgs","repos_url":"https://api.github.com/users/MechCoder/repos","events_url":"https://api.github.com/users/MechCoder/events{/privacy}","received_events_url":"https://api.github.com/users/MechCoder/received_events","type":"User","site_admin":false},"created_at":"2016-07-06T23:00:20Z","updated_at":"2016-07-06T23:00:20Z","body":"@sethah Nice catch! This superfluous split seems to be only for continuous features in which the number of unique values - 1 is lesser than or equal to the number of splits. Can you update the PR title or description to reflect this change? Thanks!"}}
{"actor":{"display_login":"MechCoder"}}