{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/pulls/17","id":87623076,"html_url":"https://github.com/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/pull/17","diff_url":"https://github.com/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/pull/17.diff","patch_url":"https://github.com/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/pull/17.patch","issue_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/issues/17","number":17,"state":"closed","locked":false,"title":"Add methods to restore user session from cache without showing sign in UI","user":{"login":"ericpapamarcos","id":282771,"avatar_url":"https://avatars.githubusercontent.com/u/282771?v=3","gravatar_id":"","url":"https://api.github.com/users/ericpapamarcos","html_url":"https://github.com/ericpapamarcos","followers_url":"https://api.github.com/users/ericpapamarcos/followers","following_url":"https://api.github.com/users/ericpapamarcos/following{/other_user}","gists_url":"https://api.github.com/users/ericpapamarcos/gists{/gist_id}","starred_url":"https://api.github.com/users/ericpapamarcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericpapamarcos/subscriptions","organizations_url":"https://api.github.com/users/ericpapamarcos/orgs","repos_url":"https://api.github.com/users/ericpapamarcos/repos","events_url":"https://api.github.com/users/ericpapamarcos/events{/privacy}","received_events_url":"https://api.github.com/users/ericpapamarcos/received_events","type":"User","site_admin":false},"body":"In 1.0.4, support was added to cache and restore a session so that it was unnecessary to prompt the user to sign in each time the service was accessed. However, this new method coupled together restoring the session and showing the sign in UI if the credentials were invalid.\r\n\r\nThis is problematic because there are several scenarios where it's important to separate out restoring a session and showing sign in UI:\r\n - Restoring a session from a background task where UI cannot be raised.\r\n - Restoring a session from within an app, but where it's important for the app to have full control over the sign in flow. For example, if an app automatically contacts the service on app launch, it would be far more elegant for the app to show an inline message that the user must re-authenticate, rather than just randomly showing the sign in UI without explanation.\r\n \r\nTo address these scenarios, this change adds a new set of methods that only restores the session without showing the sign in UI.\r\n \r\nTested changes with a UWP targeting the 14393 SDK, both in the foreground and in a background task.","created_at":"2016-10-02T03:18:39Z","updated_at":"2016-10-11T15:38:31Z","closed_at":"2016-10-11T15:38:30Z","merged_at":"2016-10-11T15:38:30Z","merge_commit_sha":"b523e9c891c552ac182db22ca42bc4d1c3022e18","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/pulls/17/commits","review_comments_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/pulls/17/comments","review_comment_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/issues/17/comments","statuses_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/statuses/449dda724b377452e51e04cc42013dbd5fda3fdc","head":{"label":"ericpapamarcos:master","ref":"master","sha":"449dda724b377452e51e04cc42013dbd5fda3fdc","user":{"login":"ericpapamarcos","id":282771,"avatar_url":"https://avatars.githubusercontent.com/u/282771?v=3","gravatar_id":"","url":"https://api.github.com/users/ericpapamarcos","html_url":"https://github.com/ericpapamarcos","followers_url":"https://api.github.com/users/ericpapamarcos/followers","following_url":"https://api.github.com/users/ericpapamarcos/following{/other_user}","gists_url":"https://api.github.com/users/ericpapamarcos/gists{/gist_id}","starred_url":"https://api.github.com/users/ericpapamarcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericpapamarcos/subscriptions","organizations_url":"https://api.github.com/users/ericpapamarcos/orgs","repos_url":"https://api.github.com/users/ericpapamarcos/repos","events_url":"https://api.github.com/users/ericpapamarcos/events{/privacy}","received_events_url":"https://api.github.com/users/ericpapamarcos/received_events","type":"User","site_admin":false},"repo":{"id":69180069,"name":"onedrive-sdk-dotnet-msa-auth-adapter","full_name":"ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter","owner":{"login":"ericpapamarcos","id":282771,"avatar_url":"https://avatars.githubusercontent.com/u/282771?v=3","gravatar_id":"","url":"https://api.github.com/users/ericpapamarcos","html_url":"https://github.com/ericpapamarcos","followers_url":"https://api.github.com/users/ericpapamarcos/followers","following_url":"https://api.github.com/users/ericpapamarcos/following{/other_user}","gists_url":"https://api.github.com/users/ericpapamarcos/gists{/gist_id}","starred_url":"https://api.github.com/users/ericpapamarcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericpapamarcos/subscriptions","organizations_url":"https://api.github.com/users/ericpapamarcos/orgs","repos_url":"https://api.github.com/users/ericpapamarcos/repos","events_url":"https://api.github.com/users/ericpapamarcos/events{/privacy}","received_events_url":"https://api.github.com/users/ericpapamarcos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter","description":null,"fork":true,"url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter","forks_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/forks","keys_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/teams","hooks_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/hooks","issue_events_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/events","assignees_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/tags","blobs_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/languages","stargazers_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/stargazers","contributors_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/contributors","subscribers_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/subscribers","subscription_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/subscription","commits_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/merges","archive_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/downloads","issues_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/labels{/name}","releases_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter/deployments","created_at":"2016-09-25T17:41:59Z","updated_at":"2016-09-25T17:42:00Z","pushed_at":"2016-10-11T15:36:29Z","git_url":"git://github.com/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter.git","ssh_url":"git@github.com:ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter.git","clone_url":"https://github.com/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter.git","svn_url":"https://github.com/ericpapamarcos/onedrive-sdk-dotnet-msa-auth-adapter","homepage":null,"size":316,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OneDrive:master","ref":"master","sha":"27c753164310b7da62cd96ebc23cb27d78578dde","user":{"login":"OneDrive","id":7130569,"avatar_url":"https://avatars.githubusercontent.com/u/7130569?v=3","gravatar_id":"","url":"https://api.github.com/users/OneDrive","html_url":"https://github.com/OneDrive","followers_url":"https://api.github.com/users/OneDrive/followers","following_url":"https://api.github.com/users/OneDrive/following{/other_user}","gists_url":"https://api.github.com/users/OneDrive/gists{/gist_id}","starred_url":"https://api.github.com/users/OneDrive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneDrive/subscriptions","organizations_url":"https://api.github.com/users/OneDrive/orgs","repos_url":"https://api.github.com/users/OneDrive/repos","events_url":"https://api.github.com/users/OneDrive/events{/privacy}","received_events_url":"https://api.github.com/users/OneDrive/received_events","type":"Organization","site_admin":false},"repo":{"id":61155903,"name":"onedrive-sdk-dotnet-msa-auth-adapter","full_name":"OneDrive/onedrive-sdk-dotnet-msa-auth-adapter","owner":{"login":"OneDrive","id":7130569,"avatar_url":"https://avatars.githubusercontent.com/u/7130569?v=3","gravatar_id":"","url":"https://api.github.com/users/OneDrive","html_url":"https://github.com/OneDrive","followers_url":"https://api.github.com/users/OneDrive/followers","following_url":"https://api.github.com/users/OneDrive/following{/other_user}","gists_url":"https://api.github.com/users/OneDrive/gists{/gist_id}","starred_url":"https://api.github.com/users/OneDrive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneDrive/subscriptions","organizations_url":"https://api.github.com/users/OneDrive/orgs","repos_url":"https://api.github.com/users/OneDrive/repos","events_url":"https://api.github.com/users/OneDrive/events{/privacy}","received_events_url":"https://api.github.com/users/OneDrive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter","description":"","fork":false,"url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter","forks_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/forks","keys_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/teams","hooks_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/hooks","issue_events_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/events","assignees_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/tags","blobs_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/languages","stargazers_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/stargazers","contributors_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/contributors","subscribers_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/subscribers","subscription_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/subscription","commits_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/merges","archive_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/downloads","issues_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/labels{/name}","releases_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/deployments","created_at":"2016-06-14T21:08:27Z","updated_at":"2016-09-28T06:11:45Z","pushed_at":"2016-10-11T15:38:31Z","git_url":"git://github.com/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter.git","ssh_url":"git@github.com:OneDrive/onedrive-sdk-dotnet-msa-auth-adapter.git","clone_url":"https://github.com/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter.git","svn_url":"https://github.com/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter","homepage":null,"size":327,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/pulls/17"},"html":{"href":"https://github.com/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/pull/17"},"issue":{"href":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/issues/17"},"comments":{"href":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/statuses/449dda724b377452e51e04cc42013dbd5fda3fdc"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cdmayer","id":10051097,"avatar_url":"https://avatars.githubusercontent.com/u/10051097?v=3","gravatar_id":"","url":"https://api.github.com/users/cdmayer","html_url":"https://github.com/cdmayer","followers_url":"https://api.github.com/users/cdmayer/followers","following_url":"https://api.github.com/users/cdmayer/following{/other_user}","gists_url":"https://api.github.com/users/cdmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/cdmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdmayer/subscriptions","organizations_url":"https://api.github.com/users/cdmayer/orgs","repos_url":"https://api.github.com/users/cdmayer/repos","events_url":"https://api.github.com/users/cdmayer/events{/privacy}","received_events_url":"https://api.github.com/users/cdmayer/received_events","type":"User","site_admin":false},"comments":2,"review_comments":1,"commits":4,"additions":31,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"cdmayer"}}