{"action":"created","issue":{"url":"https://api.github.com/repos/openzipkin/zipkin/issues/1234","repository_url":"https://api.github.com/repos/openzipkin/zipkin","labels_url":"https://api.github.com/repos/openzipkin/zipkin/issues/1234/labels{/name}","comments_url":"https://api.github.com/repos/openzipkin/zipkin/issues/1234/comments","events_url":"https://api.github.com/repos/openzipkin/zipkin/issues/1234/events","html_url":"https://github.com/openzipkin/zipkin/pull/1234","id":170426238,"number":1234,"title":"Enable Cross-Origin requests on /api/v1","user":{"login":"hyleung","id":247802,"avatar_url":"https://avatars.githubusercontent.com/u/247802?v=3","gravatar_id":"","url":"https://api.github.com/users/hyleung","html_url":"https://github.com/hyleung","followers_url":"https://api.github.com/users/hyleung/followers","following_url":"https://api.github.com/users/hyleung/following{/other_user}","gists_url":"https://api.github.com/users/hyleung/gists{/gist_id}","starred_url":"https://api.github.com/users/hyleung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyleung/subscriptions","organizations_url":"https://api.github.com/users/hyleung/orgs","repos_url":"https://api.github.com/users/hyleung/repos","events_url":"https://api.github.com/users/hyleung/events{/privacy}","received_events_url":"https://api.github.com/users/hyleung/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-10T14:08:05Z","updated_at":"2016-08-12T10:11:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openzipkin/zipkin/pulls/1234","html_url":"https://github.com/openzipkin/zipkin/pull/1234","diff_url":"https://github.com/openzipkin/zipkin/pull/1234.diff","patch_url":"https://github.com/openzipkin/zipkin/pull/1234.patch"},"body":"Closes #1135 (unless, of course, I totally misunderstood the issue 😃)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/openzipkin/zipkin/issues/comments/239410644","html_url":"https://github.com/openzipkin/zipkin/pull/1234#issuecomment-239410644","issue_url":"https://api.github.com/repos/openzipkin/zipkin/issues/1234","id":239410644,"user":{"login":"shakuzen","id":8924140,"avatar_url":"https://avatars.githubusercontent.com/u/8924140?v=3","gravatar_id":"","url":"https://api.github.com/users/shakuzen","html_url":"https://github.com/shakuzen","followers_url":"https://api.github.com/users/shakuzen/followers","following_url":"https://api.github.com/users/shakuzen/following{/other_user}","gists_url":"https://api.github.com/users/shakuzen/gists{/gist_id}","starred_url":"https://api.github.com/users/shakuzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakuzen/subscriptions","organizations_url":"https://api.github.com/users/shakuzen/orgs","repos_url":"https://api.github.com/users/shakuzen/repos","events_url":"https://api.github.com/users/shakuzen/events{/privacy}","received_events_url":"https://api.github.com/users/shakuzen/received_events","type":"User","site_admin":false},"created_at":"2016-08-12T10:11:50Z","updated_at":"2016-08-12T10:11:50Z","body":"First of all, thank you for the PR @hyleung!\r\n\r\nAs of Spring 4.3, the `@CrossOrigin`'s `origins` parameter supports placeholders ([SPR-14010](https://jira.spring.io/browse/SPR-14010)). Zipkin is already on Spring 4.3.x, and thus, we could just put the annotation on the `ZipkinQueryApiV1` controller with some property like `zipkin.query.cors-origins` to configure the origins, with a default of `*` in `zipkin-server.yml`. This way people can customize it.\r\n\r\nIt feels a little weird to me to be able to configure the allowed CORS origins for any path on the Zipkin server via properties, as the implementation at the time of this comment allows. I don't think we want to allow that, actually."}}
{"actor":{"display_login":"shakuzen"}}