{"action":"created","issue":{"url":"https://api.github.com/repos/rakshasa/libtorrent/issues/134","repository_url":"https://api.github.com/repos/rakshasa/libtorrent","labels_url":"https://api.github.com/repos/rakshasa/libtorrent/issues/134/labels{/name}","comments_url":"https://api.github.com/repos/rakshasa/libtorrent/issues/134/comments","events_url":"https://api.github.com/repos/rakshasa/libtorrent/issues/134/events","html_url":"https://github.com/rakshasa/libtorrent/pull/134","id":188452740,"number":134,"title":"async DNS resolution via udns, take 3","user":{"login":"slingamn","id":376448,"avatar_url":"https://avatars.githubusercontent.com/u/376448?v=3","gravatar_id":"","url":"https://api.github.com/users/slingamn","html_url":"https://github.com/slingamn","followers_url":"https://api.github.com/users/slingamn/followers","following_url":"https://api.github.com/users/slingamn/following{/other_user}","gists_url":"https://api.github.com/users/slingamn/gists{/gist_id}","starred_url":"https://api.github.com/users/slingamn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slingamn/subscriptions","organizations_url":"https://api.github.com/users/slingamn/orgs","repos_url":"https://api.github.com/users/slingamn/repos","events_url":"https://api.github.com/users/slingamn/events{/privacy}","received_events_url":"https://api.github.com/users/slingamn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2016-11-10T08:58:34Z","updated_at":"2016-11-22T14:20:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rakshasa/libtorrent/pulls/134","html_url":"https://github.com/rakshasa/libtorrent/pull/134","diff_url":"https://github.com/rakshasa/libtorrent/pull/134.diff","patch_url":"https://github.com/rakshasa/libtorrent/pull/134.patch"},"body":"This is #133, but with actual autoconf changes, and a green Travis build (with the two additional configurations you suggested).\r\n\r\nRight now, the build requires udns by default and fails if it's not found; to build without udns, you need `--disable-udns`."},"comment":{"url":"https://api.github.com/repos/rakshasa/libtorrent/issues/comments/262252300","html_url":"https://github.com/rakshasa/libtorrent/pull/134#issuecomment-262252300","issue_url":"https://api.github.com/repos/rakshasa/libtorrent/issues/134","id":262252300,"user":{"login":"slingamn","id":376448,"avatar_url":"https://avatars.githubusercontent.com/u/376448?v=3","gravatar_id":"","url":"https://api.github.com/users/slingamn","html_url":"https://github.com/slingamn","followers_url":"https://api.github.com/users/slingamn/followers","following_url":"https://api.github.com/users/slingamn/following{/other_user}","gists_url":"https://api.github.com/users/slingamn/gists{/gist_id}","starred_url":"https://api.github.com/users/slingamn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slingamn/subscriptions","organizations_url":"https://api.github.com/users/slingamn/orgs","repos_url":"https://api.github.com/users/slingamn/repos","events_url":"https://api.github.com/users/slingamn/events{/privacy}","received_events_url":"https://api.github.com/users/slingamn/received_events","type":"User","site_admin":false},"created_at":"2016-11-22T14:20:07Z","updated_at":"2016-11-22T14:20:07Z","body":"Sorry, I was misusing the term \"locality\": I meant it in a code organization sense, not in the performance sense.\r\n\r\nAnyway, `unique_ptr` makes sense for the mock resolver code in `AsyncResolver`, so I'm using it there now.\r\n\r\nThe issue is that the same `udns_query` object is used to store both valid and malformed queries, so memory management for both should follow the same patterns. My interpretation is that the library is managing the lifecycle: the structure is allocated by `enqueue_resolve` and then freed either automatically by callback execution or manually by `cancel`."}}
{"actor":{"display_login":"slingamn"}}