{"action":"closed","number":17138,"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17138","id":70192542,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/17138","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/17138.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/17138.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17138","number":17138,"state":"closed","locked":false,"title":"Core: define CREATURE_FAMILY_NONE to avoid magic numbers in code","user":{"login":"ForesterDev","id":11771800,"avatar_url":"https://avatars.githubusercontent.com/u/11771800?v=3","gravatar_id":"","url":"https://api.github.com/users/ForesterDev","html_url":"https://github.com/ForesterDev","followers_url":"https://api.github.com/users/ForesterDev/followers","following_url":"https://api.github.com/users/ForesterDev/following{/other_user}","gists_url":"https://api.github.com/users/ForesterDev/gists{/gist_id}","starred_url":"https://api.github.com/users/ForesterDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForesterDev/subscriptions","organizations_url":"https://api.github.com/users/ForesterDev/orgs","repos_url":"https://api.github.com/users/ForesterDev/repos","events_url":"https://api.github.com/users/ForesterDev/events{/privacy}","received_events_url":"https://api.github.com/users/ForesterDev/received_events","type":"User","site_admin":false},"body":"**Changes proposed**:\r\n- define CREATURE_FAMILY_NONE to avoid magic numbers in code\r\n\r\n**Target branch(es)**: 335/6x\r\n","created_at":"2016-05-16T12:56:21Z","updated_at":"2016-05-27T09:29:12Z","closed_at":"2016-05-27T09:29:12Z","merged_at":"2016-05-27T09:29:12Z","merge_commit_sha":"62635f07d0838ac94c2d1329849e1825406eaaff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17138/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17138/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17138/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/c73c51d7b106c11e96e8f11054f3c87e5de426e5","head":{"label":"ForesterDev:creature_family","ref":"creature_family","sha":"c73c51d7b106c11e96e8f11054f3c87e5de426e5","user":{"login":"ForesterDev","id":11771800,"avatar_url":"https://avatars.githubusercontent.com/u/11771800?v=3","gravatar_id":"","url":"https://api.github.com/users/ForesterDev","html_url":"https://github.com/ForesterDev","followers_url":"https://api.github.com/users/ForesterDev/followers","following_url":"https://api.github.com/users/ForesterDev/following{/other_user}","gists_url":"https://api.github.com/users/ForesterDev/gists{/gist_id}","starred_url":"https://api.github.com/users/ForesterDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForesterDev/subscriptions","organizations_url":"https://api.github.com/users/ForesterDev/orgs","repos_url":"https://api.github.com/users/ForesterDev/repos","events_url":"https://api.github.com/users/ForesterDev/events{/privacy}","received_events_url":"https://api.github.com/users/ForesterDev/received_events","type":"User","site_admin":false},"repo":{"id":58718197,"name":"TrinityCore","full_name":"ForesterDev/TrinityCore","owner":{"login":"ForesterDev","id":11771800,"avatar_url":"https://avatars.githubusercontent.com/u/11771800?v=3","gravatar_id":"","url":"https://api.github.com/users/ForesterDev","html_url":"https://github.com/ForesterDev","followers_url":"https://api.github.com/users/ForesterDev/followers","following_url":"https://api.github.com/users/ForesterDev/following{/other_user}","gists_url":"https://api.github.com/users/ForesterDev/gists{/gist_id}","starred_url":"https://api.github.com/users/ForesterDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForesterDev/subscriptions","organizations_url":"https://api.github.com/users/ForesterDev/orgs","repos_url":"https://api.github.com/users/ForesterDev/repos","events_url":"https://api.github.com/users/ForesterDev/events{/privacy}","received_events_url":"https://api.github.com/users/ForesterDev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ForesterDev/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/ForesterDev/TrinityCore","forks_url":"https://api.github.com/repos/ForesterDev/TrinityCore/forks","keys_url":"https://api.github.com/repos/ForesterDev/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ForesterDev/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ForesterDev/TrinityCore/teams","hooks_url":"https://api.github.com/repos/ForesterDev/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/ForesterDev/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/ForesterDev/TrinityCore/events","assignees_url":"https://api.github.com/repos/ForesterDev/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/ForesterDev/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/ForesterDev/TrinityCore/tags","blobs_url":"https://api.github.com/repos/ForesterDev/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ForesterDev/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ForesterDev/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/ForesterDev/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ForesterDev/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/ForesterDev/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/ForesterDev/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/ForesterDev/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/ForesterDev/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/ForesterDev/TrinityCore/subscription","commits_url":"https://api.github.com/repos/ForesterDev/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/ForesterDev/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/ForesterDev/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/ForesterDev/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/ForesterDev/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/ForesterDev/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ForesterDev/TrinityCore/merges","archive_url":"https://api.github.com/repos/ForesterDev/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ForesterDev/TrinityCore/downloads","issues_url":"https://api.github.com/repos/ForesterDev/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/ForesterDev/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/ForesterDev/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/ForesterDev/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ForesterDev/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/ForesterDev/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/ForesterDev/TrinityCore/deployments","created_at":"2016-05-13T08:31:35Z","updated_at":"2016-05-13T08:31:52Z","pushed_at":"2016-05-27T08:51:40Z","git_url":"git://github.com/ForesterDev/TrinityCore.git","ssh_url":"git@github.com:ForesterDev/TrinityCore.git","clone_url":"https://github.com/ForesterDev/TrinityCore.git","svn_url":"https://github.com/ForesterDev/TrinityCore","homepage":"http://www.trinitycore.org","size":347614,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"6.x"}},"base":{"label":"TrinityCore:3.3.5","ref":"3.3.5","sha":"dc67505a081fed7d59fe833ad9ec5a3741a78e8f","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/deployments","created_at":"2010-12-28T23:40:07Z","updated_at":"2016-05-26T12:23:25Z","pushed_at":"2016-05-27T09:29:12Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":773878,"stargazers_count":3345,"watchers_count":3345,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3415,"mirror_url":null,"open_issues_count":1404,"forks":3415,"open_issues":1404,"watchers":3345,"default_branch":"6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17138"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/17138"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17138"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17138/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17138/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17138/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/c73c51d7b106c11e96e8f11054f3c87e5de426e5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Shocker","id":511388,"avatar_url":"https://avatars.githubusercontent.com/u/511388?v=3","gravatar_id":"","url":"https://api.github.com/users/Shocker","html_url":"https://github.com/Shocker","followers_url":"https://api.github.com/users/Shocker/followers","following_url":"https://api.github.com/users/Shocker/following{/other_user}","gists_url":"https://api.github.com/users/Shocker/gists{/gist_id}","starred_url":"https://api.github.com/users/Shocker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shocker/subscriptions","organizations_url":"https://api.github.com/users/Shocker/orgs","repos_url":"https://api.github.com/users/Shocker/repos","events_url":"https://api.github.com/users/Shocker/events{/privacy}","received_events_url":"https://api.github.com/users/Shocker/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"commits":5,"additions":11,"deletions":8,"changed_files":6}}
{"actor":{"display_login":"Shocker"}}