{"action":"created","comment":{"url":"https://api.github.com/repos/apache/maven-plugins/pulls/comments/89669996","pull_request_review_id":10213796,"id":89669996,"diff_hunk":"@@ -0,0 +1,130 @@\n+package org.apache.maven.plugins.shade.resource;\n+\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ *   http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied.  See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+\n+import org.apache.maven.plugins.shade.relocation.Relocator;\n+\n+import java.io.IOException;\n+import java.io.InputStream;\n+import java.util.ArrayList;\n+import java.util.Collection;\n+import java.util.Collections;\n+import java.util.Iterator;\n+import java.util.List;\n+import java.util.Properties;\n+import java.util.jar.JarEntry;\n+import java.util.jar.JarOutputStream;\n+\n+/**\n+ * @author <a href=\"mailto:julien@julienviet.com\">Julien Viet</a>\n+ */\n+public class GroovyResourceTransformer implements ResourceTransformer\n+{\n+\n+    static final String EXT_MODULE_NAME = \"META-INF/services/org.codehaus.groovy.runtime.ExtensionModule\";\n+    private List<String> extensionClassesList = new ArrayList<String>();\n+    private List<String> staticExtensionClassesList = new ArrayList<String>();\n+    String extModuleName = \"no-module-name\";\n+    String extModuleVersion = \"1.0\";","path":"maven-shade-plugin/src/main/java/org/apache/maven/plugins/shade/resource/GroovyResourceTransformer.java","position":45,"original_position":45,"commit_id":"f0b667d5296792a2a1a6c163eac97dfbea950fa0","original_commit_id":"f0b667d5296792a2a1a6c163eac97dfbea950fa0","user":{"login":"olamy","id":19728,"avatar_url":"https://avatars.githubusercontent.com/u/19728?v=3","gravatar_id":"","url":"https://api.github.com/users/olamy","html_url":"https://github.com/olamy","followers_url":"https://api.github.com/users/olamy/followers","following_url":"https://api.github.com/users/olamy/following{/other_user}","gists_url":"https://api.github.com/users/olamy/gists{/gist_id}","starred_url":"https://api.github.com/users/olamy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olamy/subscriptions","organizations_url":"https://api.github.com/users/olamy/orgs","repos_url":"https://api.github.com/users/olamy/repos","events_url":"https://api.github.com/users/olamy/events{/privacy}","received_events_url":"https://api.github.com/users/olamy/received_events","type":"User","site_admin":false},"body":"Well I'm not familiar with this groovy. But should those values be configurable?","created_at":"2016-11-26T11:02:36Z","updated_at":"2016-11-26T11:02:36Z","html_url":"https://github.com/apache/maven-plugins/pull/96#discussion_r89669996","pull_request_url":"https://api.github.com/repos/apache/maven-plugins/pulls/96","_links":{"self":{"href":"https://api.github.com/repos/apache/maven-plugins/pulls/comments/89669996"},"html":{"href":"https://github.com/apache/maven-plugins/pull/96#discussion_r89669996"},"pull_request":{"href":"https://api.github.com/repos/apache/maven-plugins/pulls/96"}}},"pull_request":{"url":"https://api.github.com/repos/apache/maven-plugins/pulls/96","id":95365684,"html_url":"https://github.com/apache/maven-plugins/pull/96","diff_url":"https://github.com/apache/maven-plugins/pull/96.diff","patch_url":"https://github.com/apache/maven-plugins/pull/96.patch","issue_url":"https://api.github.com/repos/apache/maven-plugins/issues/96","number":96,"state":"open","locked":false,"title":"Groovy extension module transformer","user":{"login":"vietj","id":225674,"avatar_url":"https://avatars.githubusercontent.com/u/225674?v=3","gravatar_id":"","url":"https://api.github.com/users/vietj","html_url":"https://github.com/vietj","followers_url":"https://api.github.com/users/vietj/followers","following_url":"https://api.github.com/users/vietj/following{/other_user}","gists_url":"https://api.github.com/users/vietj/gists{/gist_id}","starred_url":"https://api.github.com/users/vietj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vietj/subscriptions","organizations_url":"https://api.github.com/users/vietj/orgs","repos_url":"https://api.github.com/users/vietj/repos","events_url":"https://api.github.com/users/vietj/events{/privacy}","received_events_url":"https://api.github.com/users/vietj/received_events","type":"User","site_admin":false},"body":"https://issues.apache.org/jira/browse/MSHADE-241","created_at":"2016-11-26T08:52:31Z","updated_at":"2016-11-26T11:02:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be2b223f5f8fde81aece67733d2bd8ff46af3175","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/maven-plugins/pulls/96/commits","review_comments_url":"https://api.github.com/repos/apache/maven-plugins/pulls/96/comments","review_comment_url":"https://api.github.com/repos/apache/maven-plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/maven-plugins/issues/96/comments","statuses_url":"https://api.github.com/repos/apache/maven-plugins/statuses/f0b667d5296792a2a1a6c163eac97dfbea950fa0","head":{"label":"vietj:trunk","ref":"trunk","sha":"f0b667d5296792a2a1a6c163eac97dfbea950fa0","user":{"login":"vietj","id":225674,"avatar_url":"https://avatars.githubusercontent.com/u/225674?v=3","gravatar_id":"","url":"https://api.github.com/users/vietj","html_url":"https://github.com/vietj","followers_url":"https://api.github.com/users/vietj/followers","following_url":"https://api.github.com/users/vietj/following{/other_user}","gists_url":"https://api.github.com/users/vietj/gists{/gist_id}","starred_url":"https://api.github.com/users/vietj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vietj/subscriptions","organizations_url":"https://api.github.com/users/vietj/orgs","repos_url":"https://api.github.com/users/vietj/repos","events_url":"https://api.github.com/users/vietj/events{/privacy}","received_events_url":"https://api.github.com/users/vietj/received_events","type":"User","site_admin":false},"repo":{"id":74773302,"name":"maven-plugins","full_name":"vietj/maven-plugins","owner":{"login":"vietj","id":225674,"avatar_url":"https://avatars.githubusercontent.com/u/225674?v=3","gravatar_id":"","url":"https://api.github.com/users/vietj","html_url":"https://github.com/vietj","followers_url":"https://api.github.com/users/vietj/followers","following_url":"https://api.github.com/users/vietj/following{/other_user}","gists_url":"https://api.github.com/users/vietj/gists{/gist_id}","starred_url":"https://api.github.com/users/vietj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vietj/subscriptions","organizations_url":"https://api.github.com/users/vietj/orgs","repos_url":"https://api.github.com/users/vietj/repos","events_url":"https://api.github.com/users/vietj/events{/privacy}","received_events_url":"https://api.github.com/users/vietj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vietj/maven-plugins","description":"Mirror of Apache Maven plugins","fork":true,"url":"https://api.github.com/repos/vietj/maven-plugins","forks_url":"https://api.github.com/repos/vietj/maven-plugins/forks","keys_url":"https://api.github.com/repos/vietj/maven-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vietj/maven-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vietj/maven-plugins/teams","hooks_url":"https://api.github.com/repos/vietj/maven-plugins/hooks","issue_events_url":"https://api.github.com/repos/vietj/maven-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/vietj/maven-plugins/events","assignees_url":"https://api.github.com/repos/vietj/maven-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/vietj/maven-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/vietj/maven-plugins/tags","blobs_url":"https://api.github.com/repos/vietj/maven-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vietj/maven-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vietj/maven-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/vietj/maven-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vietj/maven-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/vietj/maven-plugins/languages","stargazers_url":"https://api.github.com/repos/vietj/maven-plugins/stargazers","contributors_url":"https://api.github.com/repos/vietj/maven-plugins/contributors","subscribers_url":"https://api.github.com/repos/vietj/maven-plugins/subscribers","subscription_url":"https://api.github.com/repos/vietj/maven-plugins/subscription","commits_url":"https://api.github.com/repos/vietj/maven-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/vietj/maven-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/vietj/maven-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/vietj/maven-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/vietj/maven-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/vietj/maven-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vietj/maven-plugins/merges","archive_url":"https://api.github.com/repos/vietj/maven-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vietj/maven-plugins/downloads","issues_url":"https://api.github.com/repos/vietj/maven-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/vietj/maven-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/vietj/maven-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/vietj/maven-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vietj/maven-plugins/labels{/name}","releases_url":"https://api.github.com/repos/vietj/maven-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/vietj/maven-plugins/deployments","created_at":"2016-11-25T16:26:41Z","updated_at":"2016-11-25T16:27:01Z","pushed_at":"2016-11-26T08:51:51Z","git_url":"git://github.com/vietj/maven-plugins.git","ssh_url":"git@github.com:vietj/maven-plugins.git","clone_url":"https://github.com/vietj/maven-plugins.git","svn_url":"https://github.com/vietj/maven-plugins","homepage":null,"size":52066,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"0c025120341a2427fe2fa2a89320830c055eb355","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":206322,"name":"maven-plugins","full_name":"apache/maven-plugins","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/maven-plugins","description":"Mirror of Apache Maven plugins","fork":false,"url":"https://api.github.com/repos/apache/maven-plugins","forks_url":"https://api.github.com/repos/apache/maven-plugins/forks","keys_url":"https://api.github.com/repos/apache/maven-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/maven-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/maven-plugins/teams","hooks_url":"https://api.github.com/repos/apache/maven-plugins/hooks","issue_events_url":"https://api.github.com/repos/apache/maven-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/apache/maven-plugins/events","assignees_url":"https://api.github.com/repos/apache/maven-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/apache/maven-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/apache/maven-plugins/tags","blobs_url":"https://api.github.com/repos/apache/maven-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/maven-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/maven-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/maven-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/maven-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/maven-plugins/languages","stargazers_url":"https://api.github.com/repos/apache/maven-plugins/stargazers","contributors_url":"https://api.github.com/repos/apache/maven-plugins/contributors","subscribers_url":"https://api.github.com/repos/apache/maven-plugins/subscribers","subscription_url":"https://api.github.com/repos/apache/maven-plugins/subscription","commits_url":"https://api.github.com/repos/apache/maven-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/maven-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/maven-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/maven-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/maven-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/apache/maven-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/maven-plugins/merges","archive_url":"https://api.github.com/repos/apache/maven-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/maven-plugins/downloads","issues_url":"https://api.github.com/repos/apache/maven-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/apache/maven-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/maven-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/maven-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/maven-plugins/labels{/name}","releases_url":"https://api.github.com/repos/apache/maven-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/apache/maven-plugins/deployments","created_at":"2009-05-21T00:33:19Z","updated_at":"2016-11-17T15:12:18Z","pushed_at":"2016-11-26T08:52:31Z","git_url":"git://github.com/apache/maven-plugins.git","ssh_url":"git@github.com:apache/maven-plugins.git","clone_url":"https://github.com/apache/maven-plugins.git","svn_url":"https://github.com/apache/maven-plugins","homepage":null,"size":71850,"stargazers_count":152,"watchers_count":152,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":197,"mirror_url":"git://git.apache.org/maven-plugins.git","open_issues_count":4,"forks":197,"open_issues":4,"watchers":152,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/maven-plugins/pulls/96"},"html":{"href":"https://github.com/apache/maven-plugins/pull/96"},"issue":{"href":"https://api.github.com/repos/apache/maven-plugins/issues/96"},"comments":{"href":"https://api.github.com/repos/apache/maven-plugins/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/maven-plugins/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/maven-plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/maven-plugins/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/apache/maven-plugins/statuses/f0b667d5296792a2a1a6c163eac97dfbea950fa0"}}}}
{"actor":{"display_login":"olamy"}}