{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/87655952","pull_request_review_id":8263584,"id":87655952,"diff_hunk":"@@ -1665,10 +1657,11 @@ def prepare_RECOBEFMIX(self, sequence = \"reconstruction\"):\n \n     def prepare_PAT(self, sequence = \"miniAOD\"):\n         ''' Enrich the schedule with PAT '''\n-\tself.prepare_PATFILTER(self)\n-        self.loadDefaultOrSpecifiedCFF(sequence,self.PATDefaultCFF,1) #this is unscheduled\n-\tif not self._options.runUnscheduled:\t\n-\t\traise Exception(\"MiniAOD production can only run in unscheduled mode, please run cmsDriver with --runUnscheduled\")\n+        self.prepare_PATFILTER(self)\n+        self.loadDefaultOrSpecifiedCFF(sequence,self.PATDefaultCFF)\n+        self.scheduleSequence(sequence.split('.')[-1], 'pat_step')\n+        if not self._options.runUnscheduled:","path":"Configuration/Applications/python/ConfigBuilder.py","position":67,"original_position":67,"commit_id":"ba97499f30803b09c205d792c660a6cdb8bba842","original_commit_id":"ba97499f30803b09c205d792c660a6cdb8bba842","user":{"login":"wddgit","id":4295891,"avatar_url":"https://avatars.githubusercontent.com/u/4295891?v=3","gravatar_id":"","url":"https://api.github.com/users/wddgit","html_url":"https://github.com/wddgit","followers_url":"https://api.github.com/users/wddgit/followers","following_url":"https://api.github.com/users/wddgit/following{/other_user}","gists_url":"https://api.github.com/users/wddgit/gists{/gist_id}","starred_url":"https://api.github.com/users/wddgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wddgit/subscriptions","organizations_url":"https://api.github.com/users/wddgit/orgs","repos_url":"https://api.github.com/users/wddgit/repos","events_url":"https://api.github.com/users/wddgit/events{/privacy}","received_events_url":"https://api.github.com/users/wddgit/received_events","type":"User","site_admin":false},"body":"It did.","created_at":"2016-11-11T20:46:27Z","updated_at":"2016-11-11T20:46:27Z","html_url":"https://github.com/cms-sw/cmssw/pull/16538#discussion_r87655952","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/16538","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/87655952"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/16538#discussion_r87655952"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/16538"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/16538","id":93024084,"html_url":"https://github.com/cms-sw/cmssw/pull/16538","diff_url":"https://github.com/cms-sw/cmssw/pull/16538.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/16538.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16538","number":16538,"state":"open","locked":false,"title":"Initial implementation of Task feature in CMS Core configuration code","user":{"login":"wddgit","id":4295891,"avatar_url":"https://avatars.githubusercontent.com/u/4295891?v=3","gravatar_id":"","url":"https://api.github.com/users/wddgit","html_url":"https://github.com/wddgit","followers_url":"https://api.github.com/users/wddgit/followers","following_url":"https://api.github.com/users/wddgit/following{/other_user}","gists_url":"https://api.github.com/users/wddgit/gists{/gist_id}","starred_url":"https://api.github.com/users/wddgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wddgit/subscriptions","organizations_url":"https://api.github.com/users/wddgit/orgs","repos_url":"https://api.github.com/users/wddgit/repos","events_url":"https://api.github.com/users/wddgit/events{/privacy}","received_events_url":"https://api.github.com/users/wddgit/received_events","type":"User","site_admin":false},"body":"This includes the initial implementation of the Task feature in the Core CMS configuration code. It allows creating Tasks, adding modules to them, and associating them to sequences, paths, end paths, and the schedule. In many ways they behave like Sequences except that the order modules appear on Tasks does not matter. New unit tests were added to test the Core code changes.\r\n\r\nThis PR also includes fixes for the runTheMatrix.py tests that I could run on cmsdev04 and IB unit tests. The intent of these python fixes was to have exactly the same modules run in unscheduled mode as before this change so the behavior should not change at all. I ran tests to verify this. But in the long run it would be a positive development for experts to use the Task feature to specify a smaller set of modules so resources are not wasted creating modules that will never need to be run. (I will monitor the full IBs and centrally fix any additional failures that show up)\r\n\r\nThere is much work remaining to be done to migrate all CMS configurations to use the Task feature.\r\nThis PR only does the minimum amount of migration needed to keep runTheMatrix.py and the unit tests working. A large amount of additional work will be needed to convert all CMS configuration code to use this new Task feature to specify modules that should be run in unscheduled mode instead of relying on the convertToUnscheduled function.\r\n\r\nThis PR modifies the convertToUnscheduled function to work properly with the new Task feature. EDProducers and EDFilters removed from paths and endpaths are automatically placed on a Task.\r\n","created_at":"2016-11-09T19:30:58Z","updated_at":"2016-11-11T20:46:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49523ce0bdfd5621b4a954d96235449f7b3ce001","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/16538/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/16538/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16538/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/ba97499f30803b09c205d792c660a6cdb8bba842","head":{"label":"wddgit:taskInitialVersion9","ref":"taskInitialVersion9","sha":"ba97499f30803b09c205d792c660a6cdb8bba842","user":{"login":"wddgit","id":4295891,"avatar_url":"https://avatars.githubusercontent.com/u/4295891?v=3","gravatar_id":"","url":"https://api.github.com/users/wddgit","html_url":"https://github.com/wddgit","followers_url":"https://api.github.com/users/wddgit/followers","following_url":"https://api.github.com/users/wddgit/following{/other_user}","gists_url":"https://api.github.com/users/wddgit/gists{/gist_id}","starred_url":"https://api.github.com/users/wddgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wddgit/subscriptions","organizations_url":"https://api.github.com/users/wddgit/orgs","repos_url":"https://api.github.com/users/wddgit/repos","events_url":"https://api.github.com/users/wddgit/events{/privacy}","received_events_url":"https://api.github.com/users/wddgit/received_events","type":"User","site_admin":false},"repo":{"id":11036606,"name":"cmssw","full_name":"wddgit/cmssw","owner":{"login":"wddgit","id":4295891,"avatar_url":"https://avatars.githubusercontent.com/u/4295891?v=3","gravatar_id":"","url":"https://api.github.com/users/wddgit","html_url":"https://github.com/wddgit","followers_url":"https://api.github.com/users/wddgit/followers","following_url":"https://api.github.com/users/wddgit/following{/other_user}","gists_url":"https://api.github.com/users/wddgit/gists{/gist_id}","starred_url":"https://api.github.com/users/wddgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wddgit/subscriptions","organizations_url":"https://api.github.com/users/wddgit/orgs","repos_url":"https://api.github.com/users/wddgit/repos","events_url":"https://api.github.com/users/wddgit/events{/privacy}","received_events_url":"https://api.github.com/users/wddgit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wddgit/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/wddgit/cmssw","forks_url":"https://api.github.com/repos/wddgit/cmssw/forks","keys_url":"https://api.github.com/repos/wddgit/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wddgit/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wddgit/cmssw/teams","hooks_url":"https://api.github.com/repos/wddgit/cmssw/hooks","issue_events_url":"https://api.github.com/repos/wddgit/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/wddgit/cmssw/events","assignees_url":"https://api.github.com/repos/wddgit/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/wddgit/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/wddgit/cmssw/tags","blobs_url":"https://api.github.com/repos/wddgit/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wddgit/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wddgit/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/wddgit/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wddgit/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/wddgit/cmssw/languages","stargazers_url":"https://api.github.com/repos/wddgit/cmssw/stargazers","contributors_url":"https://api.github.com/repos/wddgit/cmssw/contributors","subscribers_url":"https://api.github.com/repos/wddgit/cmssw/subscribers","subscription_url":"https://api.github.com/repos/wddgit/cmssw/subscription","commits_url":"https://api.github.com/repos/wddgit/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/wddgit/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/wddgit/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/wddgit/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/wddgit/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/wddgit/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wddgit/cmssw/merges","archive_url":"https://api.github.com/repos/wddgit/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wddgit/cmssw/downloads","issues_url":"https://api.github.com/repos/wddgit/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/wddgit/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/wddgit/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/wddgit/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wddgit/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/wddgit/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/wddgit/cmssw/deployments","created_at":"2013-06-28T20:02:04Z","updated_at":"2015-05-08T19:48:35Z","pushed_at":"2016-11-10T20:49:44Z","git_url":"git://github.com/wddgit/cmssw.git","ssh_url":"git@github.com:wddgit/cmssw.git","clone_url":"https://github.com/wddgit/cmssw.git","svn_url":"https://github.com/wddgit/cmssw","homepage":null,"size":784411,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_8_1_X"}},"base":{"label":"cms-sw:CMSSW_8_1_DEVEL_X","ref":"CMSSW_8_1_DEVEL_X","sha":"f4a033778b55b229f1ae13cc8c26d7649cd6afe1","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2016-11-11T20:29:31Z","pushed_at":"2016-11-11T20:17:34Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1145128,"stargazers_count":357,"watchers_count":357,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2019,"mirror_url":null,"open_issues_count":379,"forks":2019,"open_issues":379,"watchers":357,"default_branch":"CMSSW_8_1_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/16538"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/16538"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/16538"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/16538/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/16538/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/16538/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/ba97499f30803b09c205d792c660a6cdb8bba842"}}}}
{"actor":{"display_login":"wddgit"}}