{"action":"created","comment":{"url":"https://api.github.com/repos/BroadsoftLabs/hubUi/pulls/comments/88539170","pull_request_review_id":9101206,"id":88539170,"diff_hunk":"@@ -0,0 +1,6 @@\n+ng-transclude(ng-class=\"{'expanded': expanded}\" ng-attr-style='-webkit-line-clamp: {{expanded ? \"initial\" : lines || 2}}')","path":"app/directives/expand/expand.template.pug","position":1,"original_position":1,"commit_id":"4b20fadb8819a55b2e9ab2f9422503708bf56b43","original_commit_id":"4b20fadb8819a55b2e9ab2f9422503708bf56b43","user":{"login":"dominiksteiner","id":344704,"avatar_url":"https://avatars.githubusercontent.com/u/344704?v=3","gravatar_id":"","url":"https://api.github.com/users/dominiksteiner","html_url":"https://github.com/dominiksteiner","followers_url":"https://api.github.com/users/dominiksteiner/followers","following_url":"https://api.github.com/users/dominiksteiner/following{/other_user}","gists_url":"https://api.github.com/users/dominiksteiner/gists{/gist_id}","starred_url":"https://api.github.com/users/dominiksteiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominiksteiner/subscriptions","organizations_url":"https://api.github.com/users/dominiksteiner/orgs","repos_url":"https://api.github.com/users/dominiksteiner/repos","events_url":"https://api.github.com/users/dominiksteiner/events{/privacy}","received_events_url":"https://api.github.com/users/dominiksteiner/received_events","type":"User","site_admin":false},"body":"instead of using transclude could we simply pass in the text into the directive and have the element be rendered in the directive itself? That way we would avoid having to specify the same value twice as the usage is right now\r\n\r\n```\r\ndiv(expand=\"\" selected=\"selectedApp === app.name\" hover=\"hover\" lines=3 item=\"item.snippet && item.snippet.label || item.snippet || item.description\" item-id=\"item.id\")\r\n\t\t.emailDescription(ng-bind-html='item.snippet && item.snippet.label || item.snippet || item.description', ng-if=\"item.snippet && item.snippet.label || item.snippet || item.description\", ng-click=\"handleItemClick()\")\r\n```\r\n\r\nThis might also simplify the handling of not having to clone the element and add it then into the directive. We might also be able to get rid of the itemId and hover, as we would simply check on mouseenter on this element itself\r\n\r\n```\r\nscope.showExpand = this.offsetWidth < this.scrollWidth;\r\n```","created_at":"2016-11-17T20:27:10Z","updated_at":"2016-11-17T20:27:38Z","html_url":"https://github.com/BroadsoftLabs/hubUi/pull/44#discussion_r88539170","pull_request_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/BroadsoftLabs/hubUi/pulls/comments/88539170"},"html":{"href":"https://github.com/BroadsoftLabs/hubUi/pull/44#discussion_r88539170"},"pull_request":{"href":"https://api.github.com/repos/BroadsoftLabs/hubUi/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/BroadsoftLabs/hubUi/pulls/44","id":94226348,"html_url":"https://github.com/BroadsoftLabs/hubUi/pull/44","diff_url":"https://github.com/BroadsoftLabs/hubUi/pull/44.diff","patch_url":"https://github.com/BroadsoftLabs/hubUi/pull/44.patch","issue_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/issues/44","number":44,"state":"open","locked":false,"title":"Added a new expand directive","user":{"login":"jfeigel","id":4389385,"avatar_url":"https://avatars.githubusercontent.com/u/4389385?v=3","gravatar_id":"","url":"https://api.github.com/users/jfeigel","html_url":"https://github.com/jfeigel","followers_url":"https://api.github.com/users/jfeigel/followers","following_url":"https://api.github.com/users/jfeigel/following{/other_user}","gists_url":"https://api.github.com/users/jfeigel/gists{/gist_id}","starred_url":"https://api.github.com/users/jfeigel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfeigel/subscriptions","organizations_url":"https://api.github.com/users/jfeigel/orgs","repos_url":"https://api.github.com/users/jfeigel/repos","events_url":"https://api.github.com/users/jfeigel/events{/privacy}","received_events_url":"https://api.github.com/users/jfeigel/received_events","type":"User","site_admin":false},"body":"Takes care of BroadsoftLabs/hubCore#1263","created_at":"2016-11-17T18:47:22Z","updated_at":"2016-11-17T20:27:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01bcc7ff1ca6f3b955f2bdaa668131000f8f3b7c","assignee":{"login":"dominiksteiner","id":344704,"avatar_url":"https://avatars.githubusercontent.com/u/344704?v=3","gravatar_id":"","url":"https://api.github.com/users/dominiksteiner","html_url":"https://github.com/dominiksteiner","followers_url":"https://api.github.com/users/dominiksteiner/followers","following_url":"https://api.github.com/users/dominiksteiner/following{/other_user}","gists_url":"https://api.github.com/users/dominiksteiner/gists{/gist_id}","starred_url":"https://api.github.com/users/dominiksteiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominiksteiner/subscriptions","organizations_url":"https://api.github.com/users/dominiksteiner/orgs","repos_url":"https://api.github.com/users/dominiksteiner/repos","events_url":"https://api.github.com/users/dominiksteiner/events{/privacy}","received_events_url":"https://api.github.com/users/dominiksteiner/received_events","type":"User","site_admin":false},"assignees":[{"login":"dominiksteiner","id":344704,"avatar_url":"https://avatars.githubusercontent.com/u/344704?v=3","gravatar_id":"","url":"https://api.github.com/users/dominiksteiner","html_url":"https://github.com/dominiksteiner","followers_url":"https://api.github.com/users/dominiksteiner/followers","following_url":"https://api.github.com/users/dominiksteiner/following{/other_user}","gists_url":"https://api.github.com/users/dominiksteiner/gists{/gist_id}","starred_url":"https://api.github.com/users/dominiksteiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominiksteiner/subscriptions","organizations_url":"https://api.github.com/users/dominiksteiner/orgs","repos_url":"https://api.github.com/users/dominiksteiner/repos","events_url":"https://api.github.com/users/dominiksteiner/events{/privacy}","received_events_url":"https://api.github.com/users/dominiksteiner/received_events","type":"User","site_admin":false},{"login":"amirmehmood","id":2733966,"avatar_url":"https://avatars.githubusercontent.com/u/2733966?v=3","gravatar_id":"","url":"https://api.github.com/users/amirmehmood","html_url":"https://github.com/amirmehmood","followers_url":"https://api.github.com/users/amirmehmood/followers","following_url":"https://api.github.com/users/amirmehmood/following{/other_user}","gists_url":"https://api.github.com/users/amirmehmood/gists{/gist_id}","starred_url":"https://api.github.com/users/amirmehmood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amirmehmood/subscriptions","organizations_url":"https://api.github.com/users/amirmehmood/orgs","repos_url":"https://api.github.com/users/amirmehmood/repos","events_url":"https://api.github.com/users/amirmehmood/events{/privacy}","received_events_url":"https://api.github.com/users/amirmehmood/received_events","type":"User","site_admin":false},{"login":"albi34","id":6742170,"avatar_url":"https://avatars.githubusercontent.com/u/6742170?v=3","gravatar_id":"","url":"https://api.github.com/users/albi34","html_url":"https://github.com/albi34","followers_url":"https://api.github.com/users/albi34/followers","following_url":"https://api.github.com/users/albi34/following{/other_user}","gists_url":"https://api.github.com/users/albi34/gists{/gist_id}","starred_url":"https://api.github.com/users/albi34/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albi34/subscriptions","organizations_url":"https://api.github.com/users/albi34/orgs","repos_url":"https://api.github.com/users/albi34/repos","events_url":"https://api.github.com/users/albi34/events{/privacy}","received_events_url":"https://api.github.com/users/albi34/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/pulls/44/commits","review_comments_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/pulls/44/comments","review_comment_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/issues/44/comments","statuses_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/statuses/4b20fadb8819a55b2e9ab2f9422503708bf56b43","head":{"label":"BroadsoftLabs:jf-expand-directive","ref":"jf-expand-directive","sha":"4b20fadb8819a55b2e9ab2f9422503708bf56b43","user":{"login":"BroadsoftLabs","id":16388966,"avatar_url":"https://avatars.githubusercontent.com/u/16388966?v=3","gravatar_id":"","url":"https://api.github.com/users/BroadsoftLabs","html_url":"https://github.com/BroadsoftLabs","followers_url":"https://api.github.com/users/BroadsoftLabs/followers","following_url":"https://api.github.com/users/BroadsoftLabs/following{/other_user}","gists_url":"https://api.github.com/users/BroadsoftLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/BroadsoftLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BroadsoftLabs/subscriptions","organizations_url":"https://api.github.com/users/BroadsoftLabs/orgs","repos_url":"https://api.github.com/users/BroadsoftLabs/repos","events_url":"https://api.github.com/users/BroadsoftLabs/events{/privacy}","received_events_url":"https://api.github.com/users/BroadsoftLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":62733573,"name":"hubUi","full_name":"BroadsoftLabs/hubUi","owner":{"login":"BroadsoftLabs","id":16388966,"avatar_url":"https://avatars.githubusercontent.com/u/16388966?v=3","gravatar_id":"","url":"https://api.github.com/users/BroadsoftLabs","html_url":"https://github.com/BroadsoftLabs","followers_url":"https://api.github.com/users/BroadsoftLabs/followers","following_url":"https://api.github.com/users/BroadsoftLabs/following{/other_user}","gists_url":"https://api.github.com/users/BroadsoftLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/BroadsoftLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BroadsoftLabs/subscriptions","organizations_url":"https://api.github.com/users/BroadsoftLabs/orgs","repos_url":"https://api.github.com/users/BroadsoftLabs/repos","events_url":"https://api.github.com/users/BroadsoftLabs/events{/privacy}","received_events_url":"https://api.github.com/users/BroadsoftLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BroadsoftLabs/hubUi","description":null,"fork":false,"url":"https://api.github.com/repos/BroadsoftLabs/hubUi","forks_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/forks","keys_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/teams","hooks_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/hooks","issue_events_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/issues/events{/number}","events_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/events","assignees_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/assignees{/user}","branches_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/branches{/branch}","tags_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/tags","blobs_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/git/refs{/sha}","trees_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/statuses/{sha}","languages_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/languages","stargazers_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/stargazers","contributors_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/contributors","subscribers_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/subscribers","subscription_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/subscription","commits_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/commits{/sha}","git_commits_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/git/commits{/sha}","comments_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/comments{/number}","issue_comment_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/issues/comments{/number}","contents_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/contents/{+path}","compare_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/merges","archive_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/downloads","issues_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/issues{/number}","pulls_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/pulls{/number}","milestones_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/milestones{/number}","notifications_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/labels{/name}","releases_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/releases{/id}","deployments_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/deployments","created_at":"2016-07-06T15:47:52Z","updated_at":"2016-09-07T16:27:44Z","pushed_at":"2016-11-17T18:47:22Z","git_url":"git://github.com/BroadsoftLabs/hubUi.git","ssh_url":"git@github.com:BroadsoftLabs/hubUi.git","clone_url":"https://github.com/BroadsoftLabs/hubUi.git","svn_url":"https://github.com/BroadsoftLabs/hubUi","homepage":null,"size":243,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"BroadsoftLabs:master","ref":"master","sha":"17d2aaf58bb7edbd92ac249cff141f69fedce66c","user":{"login":"BroadsoftLabs","id":16388966,"avatar_url":"https://avatars.githubusercontent.com/u/16388966?v=3","gravatar_id":"","url":"https://api.github.com/users/BroadsoftLabs","html_url":"https://github.com/BroadsoftLabs","followers_url":"https://api.github.com/users/BroadsoftLabs/followers","following_url":"https://api.github.com/users/BroadsoftLabs/following{/other_user}","gists_url":"https://api.github.com/users/BroadsoftLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/BroadsoftLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BroadsoftLabs/subscriptions","organizations_url":"https://api.github.com/users/BroadsoftLabs/orgs","repos_url":"https://api.github.com/users/BroadsoftLabs/repos","events_url":"https://api.github.com/users/BroadsoftLabs/events{/privacy}","received_events_url":"https://api.github.com/users/BroadsoftLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":62733573,"name":"hubUi","full_name":"BroadsoftLabs/hubUi","owner":{"login":"BroadsoftLabs","id":16388966,"avatar_url":"https://avatars.githubusercontent.com/u/16388966?v=3","gravatar_id":"","url":"https://api.github.com/users/BroadsoftLabs","html_url":"https://github.com/BroadsoftLabs","followers_url":"https://api.github.com/users/BroadsoftLabs/followers","following_url":"https://api.github.com/users/BroadsoftLabs/following{/other_user}","gists_url":"https://api.github.com/users/BroadsoftLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/BroadsoftLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BroadsoftLabs/subscriptions","organizations_url":"https://api.github.com/users/BroadsoftLabs/orgs","repos_url":"https://api.github.com/users/BroadsoftLabs/repos","events_url":"https://api.github.com/users/BroadsoftLabs/events{/privacy}","received_events_url":"https://api.github.com/users/BroadsoftLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BroadsoftLabs/hubUi","description":null,"fork":false,"url":"https://api.github.com/repos/BroadsoftLabs/hubUi","forks_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/forks","keys_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/teams","hooks_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/hooks","issue_events_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/issues/events{/number}","events_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/events","assignees_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/assignees{/user}","branches_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/branches{/branch}","tags_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/tags","blobs_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/git/refs{/sha}","trees_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/statuses/{sha}","languages_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/languages","stargazers_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/stargazers","contributors_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/contributors","subscribers_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/subscribers","subscription_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/subscription","commits_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/commits{/sha}","git_commits_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/git/commits{/sha}","comments_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/comments{/number}","issue_comment_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/issues/comments{/number}","contents_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/contents/{+path}","compare_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/merges","archive_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/downloads","issues_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/issues{/number}","pulls_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/pulls{/number}","milestones_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/milestones{/number}","notifications_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/labels{/name}","releases_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/releases{/id}","deployments_url":"https://api.github.com/repos/BroadsoftLabs/hubUi/deployments","created_at":"2016-07-06T15:47:52Z","updated_at":"2016-09-07T16:27:44Z","pushed_at":"2016-11-17T18:47:22Z","git_url":"git://github.com/BroadsoftLabs/hubUi.git","ssh_url":"git@github.com:BroadsoftLabs/hubUi.git","clone_url":"https://github.com/BroadsoftLabs/hubUi.git","svn_url":"https://github.com/BroadsoftLabs/hubUi","homepage":null,"size":243,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BroadsoftLabs/hubUi/pulls/44"},"html":{"href":"https://github.com/BroadsoftLabs/hubUi/pull/44"},"issue":{"href":"https://api.github.com/repos/BroadsoftLabs/hubUi/issues/44"},"comments":{"href":"https://api.github.com/repos/BroadsoftLabs/hubUi/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/BroadsoftLabs/hubUi/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/BroadsoftLabs/hubUi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BroadsoftLabs/hubUi/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/BroadsoftLabs/hubUi/statuses/4b20fadb8819a55b2e9ab2f9422503708bf56b43"}}}}
{"actor":{"display_login":"dominiksteiner"}}