{"action":"created","issue":{"url":"https://api.github.com/repos/android-ia/external-drm_hwcomposer/issues/13","repository_url":"https://api.github.com/repos/android-ia/external-drm_hwcomposer","labels_url":"https://api.github.com/repos/android-ia/external-drm_hwcomposer/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/android-ia/external-drm_hwcomposer/issues/13/comments","events_url":"https://api.github.com/repos/android-ia/external-drm_hwcomposer/issues/13/events","html_url":"https://github.com/android-ia/external-drm_hwcomposer/pull/13","id":193432684,"number":13,"title":"drm_hwcomposer: Fallback to Blocking commit in case Non-Blocking repo…","user":{"login":"kalyankondapally","id":975889,"avatar_url":"https://avatars.githubusercontent.com/u/975889?v=3","gravatar_id":"","url":"https://api.github.com/users/kalyankondapally","html_url":"https://github.com/kalyankondapally","followers_url":"https://api.github.com/users/kalyankondapally/followers","following_url":"https://api.github.com/users/kalyankondapally/following{/other_user}","gists_url":"https://api.github.com/users/kalyankondapally/gists{/gist_id}","starred_url":"https://api.github.com/users/kalyankondapally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalyankondapally/subscriptions","organizations_url":"https://api.github.com/users/kalyankondapally/orgs","repos_url":"https://api.github.com/users/kalyankondapally/repos","events_url":"https://api.github.com/users/kalyankondapally/events{/privacy}","received_events_url":"https://api.github.com/users/kalyankondapally/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-05T07:57:00Z","updated_at":"2016-12-07T10:47:42Z","closed_at":"2016-12-05T09:44:48Z","pull_request":{"url":"https://api.github.com/repos/android-ia/external-drm_hwcomposer/pulls/13","html_url":"https://github.com/android-ia/external-drm_hwcomposer/pull/13","diff_url":"https://github.com/android-ia/external-drm_hwcomposer/pull/13.diff","patch_url":"https://github.com/android-ia/external-drm_hwcomposer/pull/13.patch"},"body":"…rts EBUSY.\r\n\r\nWe probably should have mechanism to follow Atomic events and\r\nhandle non blocking commits. For now, have a fallback to use\r\nBlocking commit in case Non Blocking commit failed.\r\n\r\nBug: #11.\r\nTest: Observe no flickers.\r\nSigned-off-by: Kalyan Kondapally <kalyan.kondapally@intel.com>"},"comment":{"url":"https://api.github.com/repos/android-ia/external-drm_hwcomposer/issues/comments/265415944","html_url":"https://github.com/android-ia/external-drm_hwcomposer/pull/13#issuecomment-265415944","issue_url":"https://api.github.com/repos/android-ia/external-drm_hwcomposer/issues/13","id":265415944,"user":{"login":"kalyankondapally","id":975889,"avatar_url":"https://avatars.githubusercontent.com/u/975889?v=3","gravatar_id":"","url":"https://api.github.com/users/kalyankondapally","html_url":"https://github.com/kalyankondapally","followers_url":"https://api.github.com/users/kalyankondapally/followers","following_url":"https://api.github.com/users/kalyankondapally/following{/other_user}","gists_url":"https://api.github.com/users/kalyankondapally/gists{/gist_id}","starred_url":"https://api.github.com/users/kalyankondapally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalyankondapally/subscriptions","organizations_url":"https://api.github.com/users/kalyankondapally/orgs","repos_url":"https://api.github.com/users/kalyankondapally/repos","events_url":"https://api.github.com/users/kalyankondapally/events{/privacy}","received_events_url":"https://api.github.com/users/kalyankondapally/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T10:47:42Z","updated_at":"2016-12-07T10:47:42Z","body":"I do see odd flickers but I dont think they are related to this. It needs investigation, if they are related to watermark stuff. I did try initial idea of dropping of frames but it caused unnecessary cases where a frame wouldnt chang giving an impression of hang, every time u dropped more than 2 frames (We could have no pending frames to draw from surfaceflinger pov). Eventually, we either should poll for the atomice events, have a queue and make sure we submit requests after the last one is handled, ideally we have a vblank queue in kernel side....."}}
{"actor":{"display_login":"kalyankondapally"}}