{"action":"closed","number":19,"pull_request":{"url":"https://api.github.com/repos/Lever-age/api/pulls/19","id":86666735,"html_url":"https://github.com/Lever-age/api/pull/19","diff_url":"https://github.com/Lever-age/api/pull/19.diff","patch_url":"https://github.com/Lever-age/api/pull/19.patch","issue_url":"https://api.github.com/repos/Lever-age/api/issues/19","number":19,"state":"closed","locked":false,"title":"Models","user":{"login":"kgdiem","id":13109365,"avatar_url":"https://avatars.githubusercontent.com/u/13109365?v=3","gravatar_id":"","url":"https://api.github.com/users/kgdiem","html_url":"https://github.com/kgdiem","followers_url":"https://api.github.com/users/kgdiem/followers","following_url":"https://api.github.com/users/kgdiem/following{/other_user}","gists_url":"https://api.github.com/users/kgdiem/gists{/gist_id}","starred_url":"https://api.github.com/users/kgdiem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgdiem/subscriptions","organizations_url":"https://api.github.com/users/kgdiem/orgs","repos_url":"https://api.github.com/users/kgdiem/repos","events_url":"https://api.github.com/users/kgdiem/events{/privacy}","received_events_url":"https://api.github.com/users/kgdiem/received_events","type":"User","site_admin":false},"body":"Pull request for #4 #5 #6 #7 #8 \r\n# Development checklist (To be completed by main developer)\r\n\r\n- [X ] Code is working as expected\r\n- [ X] Acceptance criteria met\r\n- [ X] Passes coding standards\r\n- [ NA] Unit tests written and passing\r\n- [ X] PR open and linked to issue\r\n- [ X] PR using correct template\r\n- [ X] Issue closed\r\n- [ X] A quick self code review performed\r\n\r\n\r\n# Code Review Checklist\r\n## Code\r\n - No syntax/runtime errors and warnings in the code\r\n - No deprecated functions in the code\r\n - “Dead Code” should be removed. If it is a temporary hack, it should be identified as such.\r\n - All code follows coding standard (preferably https://github.com/airbnb/javascript)\r\n - No magic numbers. There should be no magic numbers like 6,10 etc… any numbers like this should be defined as a constant. And Constants should be well commented about the purpose.\r\n \r\n- [X ] Above criteria met\r\n\r\n## Documentation\r\n - All methods are commented in clear language. If it is unclear to the reader, it is unclear to the user.\r\n - All class, variable, and method modifiers should be examined for correctness.\r\n - Describe behaviour for known input corner-cases.\r\n - Complex algorithms should be explained with references. For example,  document the reference that identifies the equation, formula, or pattern. In all cases, examine the algorithm and determine if it can be simplified.\r\n - Incomplete code is marked with `//TODO` or `//FIXME` markers.\r\n - All public and private APIs are examined for updates.\r\n\r\n- [X ] Above criteria met\r\n\r\n## Unit Tests\r\n - Unit tests are added for each code path, and behaviour.\r\n - Unit tests must cover error conditions and invalid parameter cases.\r\n - Unit tests for standard algorithms should be examined against the standard for expected results.\r\n - Ensure that the code fixes the issue, or implements the requirement, and that the unit test confirms it. If the unit test confirms a fix for issue, add the issue number to the doc block.\r\n - Unit tests must have assertions\r\n - Regression tests for fixes are included.\r\n - As a reviewer, you should understand the code. If you don’t, the review may not be complete, or the code may not be well commented.\r\n\r\n- [NA ] Above criteria met\r\n\r\n## Error Handling\r\n - Invalid parameter values are handled properly early in methods (Fast Fail/Return Early).\r\n - **Don't swallow exceptions!** You should at least log the exception.\r\n\r\n- [ X] Above criteria met\r\n\r\n# Testing checklist\r\n\r\n- [NA ] All unit tests pass\r\n- [ X] All acceptance criteria are met and working as expected\r\n- [ X] Spot checks have been performed on existing functionality that may have been affected","created_at":"2016-09-25T23:37:25Z","updated_at":"2016-09-26T03:09:06Z","closed_at":"2016-09-26T03:09:06Z","merged_at":null,"merge_commit_sha":"cce43748e3974b73c1f61382f84a41942ca0dc1e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Lever-age/api/pulls/19/commits","review_comments_url":"https://api.github.com/repos/Lever-age/api/pulls/19/comments","review_comment_url":"https://api.github.com/repos/Lever-age/api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Lever-age/api/issues/19/comments","statuses_url":"https://api.github.com/repos/Lever-age/api/statuses/5c0f6e51db0cd3d401a530feec44730db83b0dd3","head":{"label":"Lever-age:models","ref":"models","sha":"5c0f6e51db0cd3d401a530feec44730db83b0dd3","user":{"login":"Lever-age","id":18223346,"avatar_url":"https://avatars.githubusercontent.com/u/18223346?v=3","gravatar_id":"","url":"https://api.github.com/users/Lever-age","html_url":"https://github.com/Lever-age","followers_url":"https://api.github.com/users/Lever-age/followers","following_url":"https://api.github.com/users/Lever-age/following{/other_user}","gists_url":"https://api.github.com/users/Lever-age/gists{/gist_id}","starred_url":"https://api.github.com/users/Lever-age/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lever-age/subscriptions","organizations_url":"https://api.github.com/users/Lever-age/orgs","repos_url":"https://api.github.com/users/Lever-age/repos","events_url":"https://api.github.com/users/Lever-age/events{/privacy}","received_events_url":"https://api.github.com/users/Lever-age/received_events","type":"Organization","site_admin":false},"repo":{"id":69125868,"name":"api","full_name":"Lever-age/api","owner":{"login":"Lever-age","id":18223346,"avatar_url":"https://avatars.githubusercontent.com/u/18223346?v=3","gravatar_id":"","url":"https://api.github.com/users/Lever-age","html_url":"https://github.com/Lever-age","followers_url":"https://api.github.com/users/Lever-age/followers","following_url":"https://api.github.com/users/Lever-age/following{/other_user}","gists_url":"https://api.github.com/users/Lever-age/gists{/gist_id}","starred_url":"https://api.github.com/users/Lever-age/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lever-age/subscriptions","organizations_url":"https://api.github.com/users/Lever-age/orgs","repos_url":"https://api.github.com/users/Lever-age/repos","events_url":"https://api.github.com/users/Lever-age/events{/privacy}","received_events_url":"https://api.github.com/users/Lever-age/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Lever-age/api","description":null,"fork":false,"url":"https://api.github.com/repos/Lever-age/api","forks_url":"https://api.github.com/repos/Lever-age/api/forks","keys_url":"https://api.github.com/repos/Lever-age/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lever-age/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lever-age/api/teams","hooks_url":"https://api.github.com/repos/Lever-age/api/hooks","issue_events_url":"https://api.github.com/repos/Lever-age/api/issues/events{/number}","events_url":"https://api.github.com/repos/Lever-age/api/events","assignees_url":"https://api.github.com/repos/Lever-age/api/assignees{/user}","branches_url":"https://api.github.com/repos/Lever-age/api/branches{/branch}","tags_url":"https://api.github.com/repos/Lever-age/api/tags","blobs_url":"https://api.github.com/repos/Lever-age/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lever-age/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lever-age/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lever-age/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lever-age/api/statuses/{sha}","languages_url":"https://api.github.com/repos/Lever-age/api/languages","stargazers_url":"https://api.github.com/repos/Lever-age/api/stargazers","contributors_url":"https://api.github.com/repos/Lever-age/api/contributors","subscribers_url":"https://api.github.com/repos/Lever-age/api/subscribers","subscription_url":"https://api.github.com/repos/Lever-age/api/subscription","commits_url":"https://api.github.com/repos/Lever-age/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lever-age/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lever-age/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lever-age/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lever-age/api/contents/{+path}","compare_url":"https://api.github.com/repos/Lever-age/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lever-age/api/merges","archive_url":"https://api.github.com/repos/Lever-age/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lever-age/api/downloads","issues_url":"https://api.github.com/repos/Lever-age/api/issues{/number}","pulls_url":"https://api.github.com/repos/Lever-age/api/pulls{/number}","milestones_url":"https://api.github.com/repos/Lever-age/api/milestones{/number}","notifications_url":"https://api.github.com/repos/Lever-age/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lever-age/api/labels{/name}","releases_url":"https://api.github.com/repos/Lever-age/api/releases{/id}","deployments_url":"https://api.github.com/repos/Lever-age/api/deployments","created_at":"2016-09-24T20:27:16Z","updated_at":"2016-09-24T20:51:30Z","pushed_at":"2016-09-26T03:06:41Z","git_url":"git://github.com/Lever-age/api.git","ssh_url":"git@github.com:Lever-age/api.git","clone_url":"https://github.com/Lever-age/api.git","svn_url":"https://github.com/Lever-age/api","homepage":null,"size":45,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":16,"forks":5,"open_issues":16,"watchers":0,"default_branch":"master"}},"base":{"label":"Lever-age:master","ref":"master","sha":"228b528440100b564a4f845ec5542a08488c191b","user":{"login":"Lever-age","id":18223346,"avatar_url":"https://avatars.githubusercontent.com/u/18223346?v=3","gravatar_id":"","url":"https://api.github.com/users/Lever-age","html_url":"https://github.com/Lever-age","followers_url":"https://api.github.com/users/Lever-age/followers","following_url":"https://api.github.com/users/Lever-age/following{/other_user}","gists_url":"https://api.github.com/users/Lever-age/gists{/gist_id}","starred_url":"https://api.github.com/users/Lever-age/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lever-age/subscriptions","organizations_url":"https://api.github.com/users/Lever-age/orgs","repos_url":"https://api.github.com/users/Lever-age/repos","events_url":"https://api.github.com/users/Lever-age/events{/privacy}","received_events_url":"https://api.github.com/users/Lever-age/received_events","type":"Organization","site_admin":false},"repo":{"id":69125868,"name":"api","full_name":"Lever-age/api","owner":{"login":"Lever-age","id":18223346,"avatar_url":"https://avatars.githubusercontent.com/u/18223346?v=3","gravatar_id":"","url":"https://api.github.com/users/Lever-age","html_url":"https://github.com/Lever-age","followers_url":"https://api.github.com/users/Lever-age/followers","following_url":"https://api.github.com/users/Lever-age/following{/other_user}","gists_url":"https://api.github.com/users/Lever-age/gists{/gist_id}","starred_url":"https://api.github.com/users/Lever-age/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lever-age/subscriptions","organizations_url":"https://api.github.com/users/Lever-age/orgs","repos_url":"https://api.github.com/users/Lever-age/repos","events_url":"https://api.github.com/users/Lever-age/events{/privacy}","received_events_url":"https://api.github.com/users/Lever-age/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Lever-age/api","description":null,"fork":false,"url":"https://api.github.com/repos/Lever-age/api","forks_url":"https://api.github.com/repos/Lever-age/api/forks","keys_url":"https://api.github.com/repos/Lever-age/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lever-age/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lever-age/api/teams","hooks_url":"https://api.github.com/repos/Lever-age/api/hooks","issue_events_url":"https://api.github.com/repos/Lever-age/api/issues/events{/number}","events_url":"https://api.github.com/repos/Lever-age/api/events","assignees_url":"https://api.github.com/repos/Lever-age/api/assignees{/user}","branches_url":"https://api.github.com/repos/Lever-age/api/branches{/branch}","tags_url":"https://api.github.com/repos/Lever-age/api/tags","blobs_url":"https://api.github.com/repos/Lever-age/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lever-age/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lever-age/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lever-age/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lever-age/api/statuses/{sha}","languages_url":"https://api.github.com/repos/Lever-age/api/languages","stargazers_url":"https://api.github.com/repos/Lever-age/api/stargazers","contributors_url":"https://api.github.com/repos/Lever-age/api/contributors","subscribers_url":"https://api.github.com/repos/Lever-age/api/subscribers","subscription_url":"https://api.github.com/repos/Lever-age/api/subscription","commits_url":"https://api.github.com/repos/Lever-age/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lever-age/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lever-age/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lever-age/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lever-age/api/contents/{+path}","compare_url":"https://api.github.com/repos/Lever-age/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lever-age/api/merges","archive_url":"https://api.github.com/repos/Lever-age/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lever-age/api/downloads","issues_url":"https://api.github.com/repos/Lever-age/api/issues{/number}","pulls_url":"https://api.github.com/repos/Lever-age/api/pulls{/number}","milestones_url":"https://api.github.com/repos/Lever-age/api/milestones{/number}","notifications_url":"https://api.github.com/repos/Lever-age/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lever-age/api/labels{/name}","releases_url":"https://api.github.com/repos/Lever-age/api/releases{/id}","deployments_url":"https://api.github.com/repos/Lever-age/api/deployments","created_at":"2016-09-24T20:27:16Z","updated_at":"2016-09-24T20:51:30Z","pushed_at":"2016-09-26T03:06:41Z","git_url":"git://github.com/Lever-age/api.git","ssh_url":"git@github.com:Lever-age/api.git","clone_url":"https://github.com/Lever-age/api.git","svn_url":"https://github.com/Lever-age/api","homepage":null,"size":45,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":16,"forks":5,"open_issues":16,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Lever-age/api/pulls/19"},"html":{"href":"https://github.com/Lever-age/api/pull/19"},"issue":{"href":"https://api.github.com/repos/Lever-age/api/issues/19"},"comments":{"href":"https://api.github.com/repos/Lever-age/api/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/Lever-age/api/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/Lever-age/api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Lever-age/api/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/Lever-age/api/statuses/5c0f6e51db0cd3d401a530feec44730db83b0dd3"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":10,"additions":195,"deletions":22,"changed_files":15}}
{"actor":{"display_login":"kgdiem"}}