{"action":"opened","number":5177,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/5177","id":58910813,"html_url":"https://github.com/nodejs/node/pull/5177","diff_url":"https://github.com/nodejs/node/pull/5177.diff","patch_url":"https://github.com/nodejs/node/pull/5177.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/5177","number":5177,"state":"open","locked":false,"title":"Benchmark cleanup","user":{"login":"AndreasMadsen","id":505333,"avatar_url":"https://avatars.githubusercontent.com/u/505333?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreasMadsen","html_url":"https://github.com/AndreasMadsen","followers_url":"https://api.github.com/users/AndreasMadsen/followers","following_url":"https://api.github.com/users/AndreasMadsen/following{/other_user}","gists_url":"https://api.github.com/users/AndreasMadsen/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreasMadsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreasMadsen/subscriptions","organizations_url":"https://api.github.com/users/AndreasMadsen/orgs","repos_url":"https://api.github.com/users/AndreasMadsen/repos","events_url":"https://api.github.com/users/AndreasMadsen/events{/privacy}","received_events_url":"https://api.github.com/users/AndreasMadsen/received_events","type":"User","site_admin":false},"body":"I'm working on a big refactor of the benchmark suite. While I'm finishing that, I would like to get these less controversial changes merged.\r\n\r\n**benchmark: move misc to categorized directories**\r\n_I'm not sure why these tests where in misc, they where quite easy to categorize._\r\n\r\n**benchmark: merge url.js with url-resolve.js**\r\nurl.js was broken since it didn't use the common.js runner. This fixes\r\nthat issue by merging it with url-resolve.js, which also benchmarks\r\nurl.resolve.\r\n\r\n**benchmark: move dgram to its own directory**\r\n_Again, trying to give the directories a bit more meaning._\r\n\r\n**benchmark: fix configuation parameters**\r\nThe benchmark runner spawns new processes for each configuration. The\r\nspecific configuration is transfered by process.argv. This means that\r\nthe values have to be parsed. As of right now only numbers and strings\r\nare parsed correctly. However other values such as objects where used.\r\n\r\nThis fixes the benchmarks that used non-string/number values and\r\nprevents future issues by asserting the type.","created_at":"2016-02-10T15:59:26Z","updated_at":"2016-02-10T15:59:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/5177/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/5177/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/5177/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/c1dd725b288488b260db135de11a9c2b18fd231a","head":{"label":"AndreasMadsen:benchmark-cleanup","ref":"benchmark-cleanup","sha":"c1dd725b288488b260db135de11a9c2b18fd231a","user":{"login":"AndreasMadsen","id":505333,"avatar_url":"https://avatars.githubusercontent.com/u/505333?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreasMadsen","html_url":"https://github.com/AndreasMadsen","followers_url":"https://api.github.com/users/AndreasMadsen/followers","following_url":"https://api.github.com/users/AndreasMadsen/following{/other_user}","gists_url":"https://api.github.com/users/AndreasMadsen/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreasMadsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreasMadsen/subscriptions","organizations_url":"https://api.github.com/users/AndreasMadsen/orgs","repos_url":"https://api.github.com/users/AndreasMadsen/repos","events_url":"https://api.github.com/users/AndreasMadsen/events{/privacy}","received_events_url":"https://api.github.com/users/AndreasMadsen/received_events","type":"User","site_admin":false},"repo":{"id":42876352,"name":"node","full_name":"AndreasMadsen/node","owner":{"login":"AndreasMadsen","id":505333,"avatar_url":"https://avatars.githubusercontent.com/u/505333?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreasMadsen","html_url":"https://github.com/AndreasMadsen","followers_url":"https://api.github.com/users/AndreasMadsen/followers","following_url":"https://api.github.com/users/AndreasMadsen/following{/other_user}","gists_url":"https://api.github.com/users/AndreasMadsen/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreasMadsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreasMadsen/subscriptions","organizations_url":"https://api.github.com/users/AndreasMadsen/orgs","repos_url":"https://api.github.com/users/AndreasMadsen/repos","events_url":"https://api.github.com/users/AndreasMadsen/events{/privacy}","received_events_url":"https://api.github.com/users/AndreasMadsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AndreasMadsen/node","description":"✨Node.js  ✨","fork":true,"url":"https://api.github.com/repos/AndreasMadsen/node","forks_url":"https://api.github.com/repos/AndreasMadsen/node/forks","keys_url":"https://api.github.com/repos/AndreasMadsen/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndreasMadsen/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndreasMadsen/node/teams","hooks_url":"https://api.github.com/repos/AndreasMadsen/node/hooks","issue_events_url":"https://api.github.com/repos/AndreasMadsen/node/issues/events{/number}","events_url":"https://api.github.com/repos/AndreasMadsen/node/events","assignees_url":"https://api.github.com/repos/AndreasMadsen/node/assignees{/user}","branches_url":"https://api.github.com/repos/AndreasMadsen/node/branches{/branch}","tags_url":"https://api.github.com/repos/AndreasMadsen/node/tags","blobs_url":"https://api.github.com/repos/AndreasMadsen/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndreasMadsen/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndreasMadsen/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndreasMadsen/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndreasMadsen/node/statuses/{sha}","languages_url":"https://api.github.com/repos/AndreasMadsen/node/languages","stargazers_url":"https://api.github.com/repos/AndreasMadsen/node/stargazers","contributors_url":"https://api.github.com/repos/AndreasMadsen/node/contributors","subscribers_url":"https://api.github.com/repos/AndreasMadsen/node/subscribers","subscription_url":"https://api.github.com/repos/AndreasMadsen/node/subscription","commits_url":"https://api.github.com/repos/AndreasMadsen/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndreasMadsen/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndreasMadsen/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndreasMadsen/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/AndreasMadsen/node/contents/{+path}","compare_url":"https://api.github.com/repos/AndreasMadsen/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndreasMadsen/node/merges","archive_url":"https://api.github.com/repos/AndreasMadsen/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndreasMadsen/node/downloads","issues_url":"https://api.github.com/repos/AndreasMadsen/node/issues{/number}","pulls_url":"https://api.github.com/repos/AndreasMadsen/node/pulls{/number}","milestones_url":"https://api.github.com/repos/AndreasMadsen/node/milestones{/number}","notifications_url":"https://api.github.com/repos/AndreasMadsen/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndreasMadsen/node/labels{/name}","releases_url":"https://api.github.com/repos/AndreasMadsen/node/releases{/id}","deployments_url":"https://api.github.com/repos/AndreasMadsen/node/deployments","created_at":"2015-09-21T15:48:29Z","updated_at":"2015-09-21T15:48:34Z","pushed_at":"2016-02-10T15:56:50Z","git_url":"git://github.com/AndreasMadsen/node.git","ssh_url":"git@github.com:AndreasMadsen/node.git","clone_url":"https://github.com/AndreasMadsen/node.git","svn_url":"https://github.com/AndreasMadsen/node","homepage":"https://nodejs.org","size":172232,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"4e4693140698eeb1b45e682a577142bcde2bd7be","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-02-10T15:18:16Z","pushed_at":"2016-02-10T15:55:27Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":209341,"stargazers_count":20091,"watchers_count":20091,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2474,"mirror_url":null,"open_issues_count":720,"forks":2474,"open_issues":720,"watchers":20091,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/5177"},"html":{"href":"https://github.com/nodejs/node/pull/5177"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/5177"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/5177/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/5177/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/5177/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/c1dd725b288488b260db135de11a9c2b18fd231a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":61,"deletions":78,"changed_files":21}}