{"action":"created","comment":{"url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls/comments/83864770","pull_request_review_id":4678694,"id":83864770,"diff_hunk":"@@ -1,45 +1,51 @@\n package com.github.eirslett.maven.plugins.frontend.mojo;\n \n-import com.github.eirslett.maven.plugins.frontend.lib.FrontendPluginFactory;\n-import com.github.eirslett.maven.plugins.frontend.lib.InstallationException;\n-import com.github.eirslett.maven.plugins.frontend.lib.NodeAndNPMInstaller;\n-import com.github.eirslett.maven.plugins.frontend.lib.ProxyConfig;\n import org.apache.maven.execution.MavenSession;\n import org.apache.maven.plugins.annotations.Component;\n import org.apache.maven.plugins.annotations.LifecyclePhase;\n import org.apache.maven.plugins.annotations.Mojo;\n import org.apache.maven.plugins.annotations.Parameter;\n-import org.apache.maven.settings.crypto.SettingsDecrypter;\n import org.apache.maven.settings.Server;\n+import org.apache.maven.settings.crypto.SettingsDecrypter;\n+\n+import com.github.eirslett.maven.plugins.frontend.lib.FrontendPluginFactory;\n+import com.github.eirslett.maven.plugins.frontend.lib.InstallationException;\n+import com.github.eirslett.maven.plugins.frontend.lib.NPMInstaller;\n+import com.github.eirslett.maven.plugins.frontend.lib.NodeInstaller;\n+import com.github.eirslett.maven.plugins.frontend.lib.ProxyConfig;\n ","path":"frontend-maven-plugin/src/main/java/com/github/eirslett/maven/plugins/frontend/mojo/InstallNodeAndNpmMojo.java","position":21,"original_position":21,"commit_id":"1de6ef227ed1e0cb82c1ef905b918b684e188562","original_commit_id":"1de6ef227ed1e0cb82c1ef905b918b684e188562","user":{"login":"mriehema","id":2276886,"avatar_url":"https://avatars.githubusercontent.com/u/2276886?v=3","gravatar_id":"","url":"https://api.github.com/users/mriehema","html_url":"https://github.com/mriehema","followers_url":"https://api.github.com/users/mriehema/followers","following_url":"https://api.github.com/users/mriehema/following{/other_user}","gists_url":"https://api.github.com/users/mriehema/gists{/gist_id}","starred_url":"https://api.github.com/users/mriehema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mriehema/subscriptions","organizations_url":"https://api.github.com/users/mriehema/orgs","repos_url":"https://api.github.com/users/mriehema/repos","events_url":"https://api.github.com/users/mriehema/events{/privacy}","received_events_url":"https://api.github.com/users/mriehema/received_events","type":"User","site_admin":false},"body":"Please revert all changes, which are not needed for yarn. That would help us to review your PR.","created_at":"2016-10-18T14:21:55Z","updated_at":"2016-10-18T14:33:27Z","html_url":"https://github.com/eirslett/frontend-maven-plugin/pull/492#discussion_r83864770","pull_request_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls/492","_links":{"self":{"href":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls/comments/83864770"},"html":{"href":"https://github.com/eirslett/frontend-maven-plugin/pull/492#discussion_r83864770"},"pull_request":{"href":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls/492"}}},"pull_request":{"url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls/492","id":89328532,"html_url":"https://github.com/eirslett/frontend-maven-plugin/pull/492","diff_url":"https://github.com/eirslett/frontend-maven-plugin/pull/492.diff","patch_url":"https://github.com/eirslett/frontend-maven-plugin/pull/492.patch","issue_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/issues/492","number":492,"state":"open","locked":false,"title":"first implementation yarn support","user":{"login":"maybeec","id":1427255,"avatar_url":"https://avatars.githubusercontent.com/u/1427255?v=3","gravatar_id":"","url":"https://api.github.com/users/maybeec","html_url":"https://github.com/maybeec","followers_url":"https://api.github.com/users/maybeec/followers","following_url":"https://api.github.com/users/maybeec/following{/other_user}","gists_url":"https://api.github.com/users/maybeec/gists{/gist_id}","starred_url":"https://api.github.com/users/maybeec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maybeec/subscriptions","organizations_url":"https://api.github.com/users/maybeec/orgs","repos_url":"https://api.github.com/users/maybeec/repos","events_url":"https://api.github.com/users/maybeec/events{/privacy}","received_events_url":"https://api.github.com/users/maybeec/received_events","type":"User","site_admin":false},"body":"This is a PR for #490.\r\nIt just provides the first support for installing and running yarn. It has not yet been testing extensively, but embedded in a local build. It has been tested for windows only until now.","created_at":"2016-10-14T05:58:28Z","updated_at":"2016-10-18T14:33:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de2273044261041302727e89d477610c7ca0e373","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls/492/commits","review_comments_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls/492/comments","review_comment_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/issues/492/comments","statuses_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/statuses/1de6ef227ed1e0cb82c1ef905b918b684e188562","head":{"label":"maybeec:feature/yarn_support","ref":"feature/yarn_support","sha":"1de6ef227ed1e0cb82c1ef905b918b684e188562","user":{"login":"maybeec","id":1427255,"avatar_url":"https://avatars.githubusercontent.com/u/1427255?v=3","gravatar_id":"","url":"https://api.github.com/users/maybeec","html_url":"https://github.com/maybeec","followers_url":"https://api.github.com/users/maybeec/followers","following_url":"https://api.github.com/users/maybeec/following{/other_user}","gists_url":"https://api.github.com/users/maybeec/gists{/gist_id}","starred_url":"https://api.github.com/users/maybeec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maybeec/subscriptions","organizations_url":"https://api.github.com/users/maybeec/orgs","repos_url":"https://api.github.com/users/maybeec/repos","events_url":"https://api.github.com/users/maybeec/events{/privacy}","received_events_url":"https://api.github.com/users/maybeec/received_events","type":"User","site_admin":false},"repo":{"id":70781000,"name":"frontend-maven-plugin","full_name":"maybeec/frontend-maven-plugin","owner":{"login":"maybeec","id":1427255,"avatar_url":"https://avatars.githubusercontent.com/u/1427255?v=3","gravatar_id":"","url":"https://api.github.com/users/maybeec","html_url":"https://github.com/maybeec","followers_url":"https://api.github.com/users/maybeec/followers","following_url":"https://api.github.com/users/maybeec/following{/other_user}","gists_url":"https://api.github.com/users/maybeec/gists{/gist_id}","starred_url":"https://api.github.com/users/maybeec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maybeec/subscriptions","organizations_url":"https://api.github.com/users/maybeec/orgs","repos_url":"https://api.github.com/users/maybeec/repos","events_url":"https://api.github.com/users/maybeec/events{/privacy}","received_events_url":"https://api.github.com/users/maybeec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maybeec/frontend-maven-plugin","description":"\"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins.\" A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.","fork":true,"url":"https://api.github.com/repos/maybeec/frontend-maven-plugin","forks_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/forks","keys_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/teams","hooks_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/hooks","issue_events_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/events","assignees_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/tags","blobs_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/languages","stargazers_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/stargazers","contributors_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/contributors","subscribers_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/subscribers","subscription_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/subscription","commits_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/merges","archive_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/downloads","issues_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/labels{/name}","releases_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/maybeec/frontend-maven-plugin/deployments","created_at":"2016-10-13T07:33:58Z","updated_at":"2016-10-13T07:34:00Z","pushed_at":"2016-10-16T21:18:00Z","git_url":"git://github.com/maybeec/frontend-maven-plugin.git","ssh_url":"git@github.com:maybeec/frontend-maven-plugin.git","clone_url":"https://github.com/maybeec/frontend-maven-plugin.git","svn_url":"https://github.com/maybeec/frontend-maven-plugin","homepage":"","size":642,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eirslett:master","ref":"master","sha":"4bbf472e3db001362d529322886faff209890836","user":{"login":"eirslett","id":1872593,"avatar_url":"https://avatars.githubusercontent.com/u/1872593?v=3","gravatar_id":"","url":"https://api.github.com/users/eirslett","html_url":"https://github.com/eirslett","followers_url":"https://api.github.com/users/eirslett/followers","following_url":"https://api.github.com/users/eirslett/following{/other_user}","gists_url":"https://api.github.com/users/eirslett/gists{/gist_id}","starred_url":"https://api.github.com/users/eirslett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eirslett/subscriptions","organizations_url":"https://api.github.com/users/eirslett/orgs","repos_url":"https://api.github.com/users/eirslett/repos","events_url":"https://api.github.com/users/eirslett/events{/privacy}","received_events_url":"https://api.github.com/users/eirslett/received_events","type":"User","site_admin":false},"repo":{"id":12488647,"name":"frontend-maven-plugin","full_name":"eirslett/frontend-maven-plugin","owner":{"login":"eirslett","id":1872593,"avatar_url":"https://avatars.githubusercontent.com/u/1872593?v=3","gravatar_id":"","url":"https://api.github.com/users/eirslett","html_url":"https://github.com/eirslett","followers_url":"https://api.github.com/users/eirslett/followers","following_url":"https://api.github.com/users/eirslett/following{/other_user}","gists_url":"https://api.github.com/users/eirslett/gists{/gist_id}","starred_url":"https://api.github.com/users/eirslett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eirslett/subscriptions","organizations_url":"https://api.github.com/users/eirslett/orgs","repos_url":"https://api.github.com/users/eirslett/repos","events_url":"https://api.github.com/users/eirslett/events{/privacy}","received_events_url":"https://api.github.com/users/eirslett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eirslett/frontend-maven-plugin","description":"\"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins.\" A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.","fork":false,"url":"https://api.github.com/repos/eirslett/frontend-maven-plugin","forks_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/forks","keys_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/teams","hooks_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/hooks","issue_events_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/events","assignees_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/tags","blobs_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/languages","stargazers_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/stargazers","contributors_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/contributors","subscribers_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/subscribers","subscription_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/subscription","commits_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/merges","archive_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/downloads","issues_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/labels{/name}","releases_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/deployments","created_at":"2013-08-30T14:44:38Z","updated_at":"2016-10-18T09:14:29Z","pushed_at":"2016-10-16T21:18:01Z","git_url":"git://github.com/eirslett/frontend-maven-plugin.git","ssh_url":"git@github.com:eirslett/frontend-maven-plugin.git","clone_url":"https://github.com/eirslett/frontend-maven-plugin.git","svn_url":"https://github.com/eirslett/frontend-maven-plugin","homepage":"","size":985,"stargazers_count":1353,"watchers_count":1353,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":351,"mirror_url":null,"open_issues_count":93,"forks":351,"open_issues":93,"watchers":1353,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls/492"},"html":{"href":"https://github.com/eirslett/frontend-maven-plugin/pull/492"},"issue":{"href":"https://api.github.com/repos/eirslett/frontend-maven-plugin/issues/492"},"comments":{"href":"https://api.github.com/repos/eirslett/frontend-maven-plugin/issues/492/comments"},"review_comments":{"href":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls/492/comments"},"review_comment":{"href":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls/492/commits"},"statuses":{"href":"https://api.github.com/repos/eirslett/frontend-maven-plugin/statuses/1de6ef227ed1e0cb82c1ef905b918b684e188562"}}}}
{"actor":{"display_login":"mriehema"}}