{"action":"created","comment":{"url":"https://api.github.com/repos/seegno/angular-oauth2/pulls/comments/51871723","id":51871723,"diff_hunk":"@@ -407,7 +412,9 @@ describe('OAuthProvider', function() {\n         OAuthToken.setToken({ token_type: 'bearer', access_token: 'foo', expires_in: 3600, refresh_token: 'bar' });\n \n         var data = queryString.stringify({\n-          token: 'bar'\n+          client_id: default.clientId,\n+          token: 'bar',\n+          client_secret: default.clientSecret","path":"test/unit/providers/oauth-provider.spec.js","position":36,"original_position":36,"commit_id":"1a982fb3dd23779ebc6fb23429a3500fda92ffd5","original_commit_id":"1a982fb3dd23779ebc6fb23429a3500fda92ffd5","user":{"login":"ruipenso","id":73298,"avatar_url":"https://avatars.githubusercontent.com/u/73298?v=3","gravatar_id":"","url":"https://api.github.com/users/ruipenso","html_url":"https://github.com/ruipenso","followers_url":"https://api.github.com/users/ruipenso/followers","following_url":"https://api.github.com/users/ruipenso/following{/other_user}","gists_url":"https://api.github.com/users/ruipenso/gists{/gist_id}","starred_url":"https://api.github.com/users/ruipenso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruipenso/subscriptions","organizations_url":"https://api.github.com/users/ruipenso/orgs","repos_url":"https://api.github.com/users/ruipenso/repos","events_url":"https://api.github.com/users/ruipenso/events{/privacy}","received_events_url":"https://api.github.com/users/ruipenso/received_events","type":"User","site_admin":false},"body":"Sort params.","created_at":"2016-02-04T13:33:12Z","updated_at":"2016-02-04T13:33:12Z","html_url":"https://github.com/seegno/angular-oauth2/pull/71#discussion_r51871723","pull_request_url":"https://api.github.com/repos/seegno/angular-oauth2/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/seegno/angular-oauth2/pulls/comments/51871723"},"html":{"href":"https://github.com/seegno/angular-oauth2/pull/71#discussion_r51871723"},"pull_request":{"href":"https://api.github.com/repos/seegno/angular-oauth2/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/seegno/angular-oauth2/pulls/71","id":54996017,"html_url":"https://github.com/seegno/angular-oauth2/pull/71","diff_url":"https://github.com/seegno/angular-oauth2/pull/71.diff","patch_url":"https://github.com/seegno/angular-oauth2/pull/71.patch","issue_url":"https://api.github.com/repos/seegno/angular-oauth2/issues/71","number":71,"state":"open","locked":false,"title":"Add `client_id` and `client_secret` on revoke_token","user":{"login":"tinogomes","id":6305,"avatar_url":"https://avatars.githubusercontent.com/u/6305?v=3","gravatar_id":"","url":"https://api.github.com/users/tinogomes","html_url":"https://github.com/tinogomes","followers_url":"https://api.github.com/users/tinogomes/followers","following_url":"https://api.github.com/users/tinogomes/following{/other_user}","gists_url":"https://api.github.com/users/tinogomes/gists{/gist_id}","starred_url":"https://api.github.com/users/tinogomes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinogomes/subscriptions","organizations_url":"https://api.github.com/users/tinogomes/orgs","repos_url":"https://api.github.com/users/tinogomes/repos","events_url":"https://api.github.com/users/tinogomes/events{/privacy}","received_events_url":"https://api.github.com/users/tinogomes/received_events","type":"User","site_admin":false},"body":"Adapted from [Django OAuth Tookit - Part 4 - Revoking an OAuth2 Token](http://django-oauth-toolkit.readthedocs.org/en/latest/tutorial/tutorial_04.html#setup-a-request)\r\n\r\nDepending on the client type you’re using, the token revocation request you may submit to the authentication server may vary. A Public client, for example, will not have access to your Client Secret. A revoke request from a public client would omit that secret, but requires `client_id`. If your application type is Confidential , it requires the `client_secret`, so you will have to add it as one of the parameters.\r\n","created_at":"2016-01-04T16:53:48Z","updated_at":"2016-02-04T13:33:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6efdd114a974e0a67d4edd0f09f86a0be4d6a280","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/seegno/angular-oauth2/pulls/71/commits","review_comments_url":"https://api.github.com/repos/seegno/angular-oauth2/pulls/71/comments","review_comment_url":"https://api.github.com/repos/seegno/angular-oauth2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/seegno/angular-oauth2/issues/71/comments","statuses_url":"https://api.github.com/repos/seegno/angular-oauth2/statuses/1a982fb3dd23779ebc6fb23429a3500fda92ffd5","head":{"label":"tinogomes:pullrequest","ref":"pullrequest","sha":"1a982fb3dd23779ebc6fb23429a3500fda92ffd5","user":{"login":"tinogomes","id":6305,"avatar_url":"https://avatars.githubusercontent.com/u/6305?v=3","gravatar_id":"","url":"https://api.github.com/users/tinogomes","html_url":"https://github.com/tinogomes","followers_url":"https://api.github.com/users/tinogomes/followers","following_url":"https://api.github.com/users/tinogomes/following{/other_user}","gists_url":"https://api.github.com/users/tinogomes/gists{/gist_id}","starred_url":"https://api.github.com/users/tinogomes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinogomes/subscriptions","organizations_url":"https://api.github.com/users/tinogomes/orgs","repos_url":"https://api.github.com/users/tinogomes/repos","events_url":"https://api.github.com/users/tinogomes/events{/privacy}","received_events_url":"https://api.github.com/users/tinogomes/received_events","type":"User","site_admin":false},"repo":{"id":48248675,"name":"angular-oauth2","full_name":"tinogomes/angular-oauth2","owner":{"login":"tinogomes","id":6305,"avatar_url":"https://avatars.githubusercontent.com/u/6305?v=3","gravatar_id":"","url":"https://api.github.com/users/tinogomes","html_url":"https://github.com/tinogomes","followers_url":"https://api.github.com/users/tinogomes/followers","following_url":"https://api.github.com/users/tinogomes/following{/other_user}","gists_url":"https://api.github.com/users/tinogomes/gists{/gist_id}","starred_url":"https://api.github.com/users/tinogomes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinogomes/subscriptions","organizations_url":"https://api.github.com/users/tinogomes/orgs","repos_url":"https://api.github.com/users/tinogomes/repos","events_url":"https://api.github.com/users/tinogomes/events{/privacy}","received_events_url":"https://api.github.com/users/tinogomes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tinogomes/angular-oauth2","description":"AngularJS OAuth2","fork":true,"url":"https://api.github.com/repos/tinogomes/angular-oauth2","forks_url":"https://api.github.com/repos/tinogomes/angular-oauth2/forks","keys_url":"https://api.github.com/repos/tinogomes/angular-oauth2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tinogomes/angular-oauth2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tinogomes/angular-oauth2/teams","hooks_url":"https://api.github.com/repos/tinogomes/angular-oauth2/hooks","issue_events_url":"https://api.github.com/repos/tinogomes/angular-oauth2/issues/events{/number}","events_url":"https://api.github.com/repos/tinogomes/angular-oauth2/events","assignees_url":"https://api.github.com/repos/tinogomes/angular-oauth2/assignees{/user}","branches_url":"https://api.github.com/repos/tinogomes/angular-oauth2/branches{/branch}","tags_url":"https://api.github.com/repos/tinogomes/angular-oauth2/tags","blobs_url":"https://api.github.com/repos/tinogomes/angular-oauth2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tinogomes/angular-oauth2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tinogomes/angular-oauth2/git/refs{/sha}","trees_url":"https://api.github.com/repos/tinogomes/angular-oauth2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tinogomes/angular-oauth2/statuses/{sha}","languages_url":"https://api.github.com/repos/tinogomes/angular-oauth2/languages","stargazers_url":"https://api.github.com/repos/tinogomes/angular-oauth2/stargazers","contributors_url":"https://api.github.com/repos/tinogomes/angular-oauth2/contributors","subscribers_url":"https://api.github.com/repos/tinogomes/angular-oauth2/subscribers","subscription_url":"https://api.github.com/repos/tinogomes/angular-oauth2/subscription","commits_url":"https://api.github.com/repos/tinogomes/angular-oauth2/commits{/sha}","git_commits_url":"https://api.github.com/repos/tinogomes/angular-oauth2/git/commits{/sha}","comments_url":"https://api.github.com/repos/tinogomes/angular-oauth2/comments{/number}","issue_comment_url":"https://api.github.com/repos/tinogomes/angular-oauth2/issues/comments{/number}","contents_url":"https://api.github.com/repos/tinogomes/angular-oauth2/contents/{+path}","compare_url":"https://api.github.com/repos/tinogomes/angular-oauth2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tinogomes/angular-oauth2/merges","archive_url":"https://api.github.com/repos/tinogomes/angular-oauth2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tinogomes/angular-oauth2/downloads","issues_url":"https://api.github.com/repos/tinogomes/angular-oauth2/issues{/number}","pulls_url":"https://api.github.com/repos/tinogomes/angular-oauth2/pulls{/number}","milestones_url":"https://api.github.com/repos/tinogomes/angular-oauth2/milestones{/number}","notifications_url":"https://api.github.com/repos/tinogomes/angular-oauth2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tinogomes/angular-oauth2/labels{/name}","releases_url":"https://api.github.com/repos/tinogomes/angular-oauth2/releases{/id}","deployments_url":"https://api.github.com/repos/tinogomes/angular-oauth2/deployments","created_at":"2015-12-18T17:52:39Z","updated_at":"2015-12-18T17:52:40Z","pushed_at":"2016-01-04T16:51:42Z","git_url":"git://github.com/tinogomes/angular-oauth2.git","ssh_url":"git@github.com:tinogomes/angular-oauth2.git","clone_url":"https://github.com/tinogomes/angular-oauth2.git","svn_url":"https://github.com/tinogomes/angular-oauth2","homepage":"http://seegno.com","size":50,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"seegno:master","ref":"master","sha":"6519e27c234f0aac28c2a66bbc2e7f4d508757c8","user":{"login":"seegno","id":1326469,"avatar_url":"https://avatars.githubusercontent.com/u/1326469?v=3","gravatar_id":"","url":"https://api.github.com/users/seegno","html_url":"https://github.com/seegno","followers_url":"https://api.github.com/users/seegno/followers","following_url":"https://api.github.com/users/seegno/following{/other_user}","gists_url":"https://api.github.com/users/seegno/gists{/gist_id}","starred_url":"https://api.github.com/users/seegno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seegno/subscriptions","organizations_url":"https://api.github.com/users/seegno/orgs","repos_url":"https://api.github.com/users/seegno/repos","events_url":"https://api.github.com/users/seegno/events{/privacy}","received_events_url":"https://api.github.com/users/seegno/received_events","type":"Organization","site_admin":false},"repo":{"id":29157050,"name":"angular-oauth2","full_name":"seegno/angular-oauth2","owner":{"login":"seegno","id":1326469,"avatar_url":"https://avatars.githubusercontent.com/u/1326469?v=3","gravatar_id":"","url":"https://api.github.com/users/seegno","html_url":"https://github.com/seegno","followers_url":"https://api.github.com/users/seegno/followers","following_url":"https://api.github.com/users/seegno/following{/other_user}","gists_url":"https://api.github.com/users/seegno/gists{/gist_id}","starred_url":"https://api.github.com/users/seegno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seegno/subscriptions","organizations_url":"https://api.github.com/users/seegno/orgs","repos_url":"https://api.github.com/users/seegno/repos","events_url":"https://api.github.com/users/seegno/events{/privacy}","received_events_url":"https://api.github.com/users/seegno/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/seegno/angular-oauth2","description":"AngularJS OAuth2","fork":false,"url":"https://api.github.com/repos/seegno/angular-oauth2","forks_url":"https://api.github.com/repos/seegno/angular-oauth2/forks","keys_url":"https://api.github.com/repos/seegno/angular-oauth2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seegno/angular-oauth2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seegno/angular-oauth2/teams","hooks_url":"https://api.github.com/repos/seegno/angular-oauth2/hooks","issue_events_url":"https://api.github.com/repos/seegno/angular-oauth2/issues/events{/number}","events_url":"https://api.github.com/repos/seegno/angular-oauth2/events","assignees_url":"https://api.github.com/repos/seegno/angular-oauth2/assignees{/user}","branches_url":"https://api.github.com/repos/seegno/angular-oauth2/branches{/branch}","tags_url":"https://api.github.com/repos/seegno/angular-oauth2/tags","blobs_url":"https://api.github.com/repos/seegno/angular-oauth2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seegno/angular-oauth2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seegno/angular-oauth2/git/refs{/sha}","trees_url":"https://api.github.com/repos/seegno/angular-oauth2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seegno/angular-oauth2/statuses/{sha}","languages_url":"https://api.github.com/repos/seegno/angular-oauth2/languages","stargazers_url":"https://api.github.com/repos/seegno/angular-oauth2/stargazers","contributors_url":"https://api.github.com/repos/seegno/angular-oauth2/contributors","subscribers_url":"https://api.github.com/repos/seegno/angular-oauth2/subscribers","subscription_url":"https://api.github.com/repos/seegno/angular-oauth2/subscription","commits_url":"https://api.github.com/repos/seegno/angular-oauth2/commits{/sha}","git_commits_url":"https://api.github.com/repos/seegno/angular-oauth2/git/commits{/sha}","comments_url":"https://api.github.com/repos/seegno/angular-oauth2/comments{/number}","issue_comment_url":"https://api.github.com/repos/seegno/angular-oauth2/issues/comments{/number}","contents_url":"https://api.github.com/repos/seegno/angular-oauth2/contents/{+path}","compare_url":"https://api.github.com/repos/seegno/angular-oauth2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seegno/angular-oauth2/merges","archive_url":"https://api.github.com/repos/seegno/angular-oauth2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seegno/angular-oauth2/downloads","issues_url":"https://api.github.com/repos/seegno/angular-oauth2/issues{/number}","pulls_url":"https://api.github.com/repos/seegno/angular-oauth2/pulls{/number}","milestones_url":"https://api.github.com/repos/seegno/angular-oauth2/milestones{/number}","notifications_url":"https://api.github.com/repos/seegno/angular-oauth2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seegno/angular-oauth2/labels{/name}","releases_url":"https://api.github.com/repos/seegno/angular-oauth2/releases{/id}","deployments_url":"https://api.github.com/repos/seegno/angular-oauth2/deployments","created_at":"2015-01-12T21:09:21Z","updated_at":"2016-01-28T18:54:31Z","pushed_at":"2016-01-18T10:34:57Z","git_url":"git://github.com/seegno/angular-oauth2.git","ssh_url":"git@github.com:seegno/angular-oauth2.git","clone_url":"https://github.com/seegno/angular-oauth2.git","svn_url":"https://github.com/seegno/angular-oauth2","homepage":"http://seegno.com","size":588,"stargazers_count":336,"watchers_count":336,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":16,"forks":92,"open_issues":16,"watchers":336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/seegno/angular-oauth2/pulls/71"},"html":{"href":"https://github.com/seegno/angular-oauth2/pull/71"},"issue":{"href":"https://api.github.com/repos/seegno/angular-oauth2/issues/71"},"comments":{"href":"https://api.github.com/repos/seegno/angular-oauth2/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/seegno/angular-oauth2/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/seegno/angular-oauth2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/seegno/angular-oauth2/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/seegno/angular-oauth2/statuses/1a982fb3dd23779ebc6fb23429a3500fda92ffd5"}}}}