{"action":"created","issue":{"url":"https://api.github.com/repos/feathersjs/feathers-nedb/issues/20","repository_url":"https://api.github.com/repos/feathersjs/feathers-nedb","labels_url":"https://api.github.com/repos/feathersjs/feathers-nedb/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/feathersjs/feathers-nedb/issues/20/comments","events_url":"https://api.github.com/repos/feathersjs/feathers-nedb/issues/20/events","html_url":"https://github.com/feathersjs/feathers-nedb/pull/20","id":150616835,"number":20,"title":"fix errors in update and patch with custom id","user":{"login":"farwayer","id":2343101,"avatar_url":"https://avatars.githubusercontent.com/u/2343101?v=3","gravatar_id":"","url":"https://api.github.com/users/farwayer","html_url":"https://github.com/farwayer","followers_url":"https://api.github.com/users/farwayer/followers","following_url":"https://api.github.com/users/farwayer/following{/other_user}","gists_url":"https://api.github.com/users/farwayer/gists{/gist_id}","starred_url":"https://api.github.com/users/farwayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farwayer/subscriptions","organizations_url":"https://api.github.com/users/farwayer/orgs","repos_url":"https://api.github.com/users/farwayer/repos","events_url":"https://api.github.com/users/farwayer/events{/privacy}","received_events_url":"https://api.github.com/users/farwayer/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-04-24T02:23:15Z","updated_at":"2016-06-17T02:28:55Z","closed_at":"2016-06-17T02:28:38Z","pull_request":{"url":"https://api.github.com/repos/feathersjs/feathers-nedb/pulls/20","html_url":"https://github.com/feathersjs/feathers-nedb/pull/20","diff_url":"https://github.com/feathersjs/feathers-nedb/pull/20.diff","patch_url":"https://github.com/feathersjs/feathers-nedb/pull/20.patch"},"body":"@ekryski \r\nOh sorry I was very sleepy yesterday :sleepy:\r\n\r\nPR fixs two problems:\r\n\r\n1. If we remove custom id from the data then `update` will remove it from database (behavior in current realization). So we need to set custom id to old value in the input data to make it read only. It is need for future `_findOrGet()` call.\r\n\r\n2. If data contains `_id` field different from current then nedb will throw exception (`_id` is read only). So we need to remove it from input data."},"comment":{"url":"https://api.github.com/repos/feathersjs/feathers-nedb/issues/comments/226665540","html_url":"https://github.com/feathersjs/feathers-nedb/pull/20#issuecomment-226665540","issue_url":"https://api.github.com/repos/feathersjs/feathers-nedb/issues/20","id":226665540,"user":{"login":"daffl","id":338316,"avatar_url":"https://avatars.githubusercontent.com/u/338316?v=3","gravatar_id":"","url":"https://api.github.com/users/daffl","html_url":"https://github.com/daffl","followers_url":"https://api.github.com/users/daffl/followers","following_url":"https://api.github.com/users/daffl/following{/other_user}","gists_url":"https://api.github.com/users/daffl/gists{/gist_id}","starred_url":"https://api.github.com/users/daffl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daffl/subscriptions","organizations_url":"https://api.github.com/users/daffl/orgs","repos_url":"https://api.github.com/users/daffl/repos","events_url":"https://api.github.com/users/daffl/events{/privacy}","received_events_url":"https://api.github.com/users/daffl/received_events","type":"User","site_admin":false},"created_at":"2016-06-17T02:28:55Z","updated_at":"2016-06-17T02:28:55Z","body":"I'm just going to get it in. Doesn't seem to break anything else."}}
{"actor":{"display_login":"daffl"}}