{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/53525915","id":53525915,"diff_hunk":"@@ -206,6 +212,34 @@ func getConflictFreeConfiguration(configFile string, flags *flag.FlagSet) (*Conf\n \t\t\treturn nil, err\n \t\t}\n \n+\t\t// make sure that values set in the config file with nullable values, like `false`,","path":"daemon/config.go","position":29,"original_position":29,"commit_id":"caa7742ad3773e2fdf34cca82937adf3fa74f391","original_commit_id":"caa7742ad3773e2fdf34cca82937adf3fa74f391","user":{"login":"calavera","id":1050,"avatar_url":"https://avatars.githubusercontent.com/u/1050?v=3","gravatar_id":"","url":"https://api.github.com/users/calavera","html_url":"https://github.com/calavera","followers_url":"https://api.github.com/users/calavera/followers","following_url":"https://api.github.com/users/calavera/following{/other_user}","gists_url":"https://api.github.com/users/calavera/gists{/gist_id}","starred_url":"https://api.github.com/users/calavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calavera/subscriptions","organizations_url":"https://api.github.com/users/calavera/orgs","repos_url":"https://api.github.com/users/calavera/repos","events_url":"https://api.github.com/users/calavera/events{/privacy}","received_events_url":"https://api.github.com/users/calavera/received_events","type":"User","site_admin":false},"body":"fair","created_at":"2016-02-19T22:11:36Z","updated_at":"2016-02-19T22:11:36Z","html_url":"https://github.com/docker/docker/pull/20471#discussion_r53525915","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/20471","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/53525915"},"html":{"href":"https://github.com/docker/docker/pull/20471#discussion_r53525915"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/20471"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/20471","id":59889949,"html_url":"https://github.com/docker/docker/pull/20471","diff_url":"https://github.com/docker/docker/pull/20471.diff","patch_url":"https://github.com/docker/docker/pull/20471.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/20471","number":20471,"state":"open","locked":false,"title":"Avoid setting default truthy values from flags that are not set.","user":{"login":"calavera","id":1050,"avatar_url":"https://avatars.githubusercontent.com/u/1050?v=3","gravatar_id":"","url":"https://api.github.com/users/calavera","html_url":"https://github.com/calavera","followers_url":"https://api.github.com/users/calavera/followers","following_url":"https://api.github.com/users/calavera/following{/other_user}","gists_url":"https://api.github.com/users/calavera/gists{/gist_id}","starred_url":"https://api.github.com/users/calavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calavera/subscriptions","organizations_url":"https://api.github.com/users/calavera/orgs","repos_url":"https://api.github.com/users/calavera/repos","events_url":"https://api.github.com/users/calavera/events{/privacy}","received_events_url":"https://api.github.com/users/calavera/received_events","type":"User","site_admin":false},"body":"When the value for a configuration option in the file is `false`,\nand the default value for a flag is `true`, we should not\ntake the value from the later as final value for the option,\nbecause the user explicitly set `false`.\n\nThis change overrides the default value in the flagSet with\nthe value in the configuration file so we get the correct\nresult when we merge the two configurations together.\n\nFixes #20289.\n\nSigned-off-by: David Calavera <david.calavera@gmail.com>","created_at":"2016-02-19T01:04:11Z","updated_at":"2016-02-19T22:11:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba4ab2903c45c4ad21443e9c7ad587f41dec9467","assignee":null,"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/51","html_url":"https://github.com/docker/docker/milestones/1.10.2","labels_url":"https://api.github.com/repos/docker/docker/milestones/51/labels","id":1578592,"number":51,"title":"1.10.2","description":"\r\n","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":13,"state":"open","created_at":"2016-02-11T21:54:15Z","updated_at":"2016-02-19T21:41:00Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker/pulls/20471/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/20471/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/20471/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/caa7742ad3773e2fdf34cca82937adf3fa74f391","head":{"label":"calavera:userland_proxy_config_fix","ref":"userland_proxy_config_fix","sha":"caa7742ad3773e2fdf34cca82937adf3fa74f391","user":{"login":"calavera","id":1050,"avatar_url":"https://avatars.githubusercontent.com/u/1050?v=3","gravatar_id":"","url":"https://api.github.com/users/calavera","html_url":"https://github.com/calavera","followers_url":"https://api.github.com/users/calavera/followers","following_url":"https://api.github.com/users/calavera/following{/other_user}","gists_url":"https://api.github.com/users/calavera/gists{/gist_id}","starred_url":"https://api.github.com/users/calavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calavera/subscriptions","organizations_url":"https://api.github.com/users/calavera/orgs","repos_url":"https://api.github.com/users/calavera/repos","events_url":"https://api.github.com/users/calavera/events{/privacy}","received_events_url":"https://api.github.com/users/calavera/received_events","type":"User","site_admin":false},"repo":{"id":11697698,"name":"docker","full_name":"calavera/docker","owner":{"login":"calavera","id":1050,"avatar_url":"https://avatars.githubusercontent.com/u/1050?v=3","gravatar_id":"","url":"https://api.github.com/users/calavera","html_url":"https://github.com/calavera","followers_url":"https://api.github.com/users/calavera/followers","following_url":"https://api.github.com/users/calavera/following{/other_user}","gists_url":"https://api.github.com/users/calavera/gists{/gist_id}","starred_url":"https://api.github.com/users/calavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calavera/subscriptions","organizations_url":"https://api.github.com/users/calavera/orgs","repos_url":"https://api.github.com/users/calavera/repos","events_url":"https://api.github.com/users/calavera/events{/privacy}","received_events_url":"https://api.github.com/users/calavera/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/calavera/docker","description":"Docker - the Linux container runtime","fork":true,"url":"https://api.github.com/repos/calavera/docker","forks_url":"https://api.github.com/repos/calavera/docker/forks","keys_url":"https://api.github.com/repos/calavera/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/calavera/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/calavera/docker/teams","hooks_url":"https://api.github.com/repos/calavera/docker/hooks","issue_events_url":"https://api.github.com/repos/calavera/docker/issues/events{/number}","events_url":"https://api.github.com/repos/calavera/docker/events","assignees_url":"https://api.github.com/repos/calavera/docker/assignees{/user}","branches_url":"https://api.github.com/repos/calavera/docker/branches{/branch}","tags_url":"https://api.github.com/repos/calavera/docker/tags","blobs_url":"https://api.github.com/repos/calavera/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/calavera/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/calavera/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/calavera/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/calavera/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/calavera/docker/languages","stargazers_url":"https://api.github.com/repos/calavera/docker/stargazers","contributors_url":"https://api.github.com/repos/calavera/docker/contributors","subscribers_url":"https://api.github.com/repos/calavera/docker/subscribers","subscription_url":"https://api.github.com/repos/calavera/docker/subscription","commits_url":"https://api.github.com/repos/calavera/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/calavera/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/calavera/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/calavera/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/calavera/docker/contents/{+path}","compare_url":"https://api.github.com/repos/calavera/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/calavera/docker/merges","archive_url":"https://api.github.com/repos/calavera/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/calavera/docker/downloads","issues_url":"https://api.github.com/repos/calavera/docker/issues{/number}","pulls_url":"https://api.github.com/repos/calavera/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/calavera/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/calavera/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/calavera/docker/labels{/name}","releases_url":"https://api.github.com/repos/calavera/docker/releases{/id}","deployments_url":"https://api.github.com/repos/calavera/docker/deployments","created_at":"2013-07-27T00:49:52Z","updated_at":"2014-07-24T21:22:23Z","pushed_at":"2016-02-19T21:27:05Z","git_url":"git://github.com/calavera/docker.git","ssh_url":"git@github.com:calavera/docker.git","clone_url":"https://github.com/calavera/docker.git","svn_url":"https://github.com/calavera/docker","homepage":"http://docker.io","size":84270,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"aa1fdf42da8536d69c40322856aeaae197698fcd","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-02-19T22:03:47Z","pushed_at":"2016-02-19T21:37:32Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":136701,"stargazers_count":28805,"watchers_count":28805,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8012,"mirror_url":null,"open_issues_count":1357,"forks":8012,"open_issues":1357,"watchers":28805,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/20471"},"html":{"href":"https://github.com/docker/docker/pull/20471"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/20471"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/20471/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/20471/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/20471/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/caa7742ad3773e2fdf34cca82937adf3fa74f391"}}}}