{"action":"created","comment":{"url":"https://api.github.com/repos/biolab/orange3/pulls/comments/62660051","id":62660051,"diff_hunk":"@@ -26,7 +28,65 @@ def transform(self, c):\n         return numpy.where(numpy.isnan(c), self.value, c)\n \n \n-class Average:\n+class BaseImputeMethod:\n+    name = \"\"\n+    short_name = \"\"\n+    description = \"\"\n+    format = \"{var.name} -> {short_name}\"","path":"Orange/preprocess/impute.py","position":22,"original_position":22,"commit_id":"91f83090292a154a85c5bc8f615f2d952b16e952","original_commit_id":"91f83090292a154a85c5bc8f615f2d952b16e952","user":{"login":"kernc","id":684364,"avatar_url":"https://avatars.githubusercontent.com/u/684364?v=3","gravatar_id":"","url":"https://api.github.com/users/kernc","html_url":"https://github.com/kernc","followers_url":"https://api.github.com/users/kernc/followers","following_url":"https://api.github.com/users/kernc/following{/other_user}","gists_url":"https://api.github.com/users/kernc/gists{/gist_id}","starred_url":"https://api.github.com/users/kernc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kernc/subscriptions","organizations_url":"https://api.github.com/users/kernc/orgs","repos_url":"https://api.github.com/users/kernc/repos","events_url":"https://api.github.com/users/kernc/events{/privacy}","received_events_url":"https://api.github.com/users/kernc/received_events","type":"User","site_admin":false},"body":"How about specifying this as `\"{var.name} → {self.short_name}\"`. Then `format_variable()` method below could call format it with `self.format.format(var=var, self=self)` and there would be no reason to override the method if `format` is already overriden?","created_at":"2016-05-10T12:16:14Z","updated_at":"2016-05-10T12:16:14Z","html_url":"https://github.com/biolab/orange3/pull/1094#discussion_r62660051","pull_request_url":"https://api.github.com/repos/biolab/orange3/pulls/1094","_links":{"self":{"href":"https://api.github.com/repos/biolab/orange3/pulls/comments/62660051"},"html":{"href":"https://github.com/biolab/orange3/pull/1094#discussion_r62660051"},"pull_request":{"href":"https://api.github.com/repos/biolab/orange3/pulls/1094"}}},"pull_request":{"url":"https://api.github.com/repos/biolab/orange3/pulls/1094","id":62321435,"html_url":"https://github.com/biolab/orange3/pull/1094","diff_url":"https://github.com/biolab/orange3/pull/1094.diff","patch_url":"https://github.com/biolab/orange3/pull/1094.patch","issue_url":"https://api.github.com/repos/biolab/orange3/issues/1094","number":1094,"state":"open","locked":false,"title":"OWImpute: fix model based imputer. Fixes #1082.","user":{"login":"s-alexey","id":9372243,"avatar_url":"https://avatars.githubusercontent.com/u/9372243?v=3","gravatar_id":"","url":"https://api.github.com/users/s-alexey","html_url":"https://github.com/s-alexey","followers_url":"https://api.github.com/users/s-alexey/followers","following_url":"https://api.github.com/users/s-alexey/following{/other_user}","gists_url":"https://api.github.com/users/s-alexey/gists{/gist_id}","starred_url":"https://api.github.com/users/s-alexey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-alexey/subscriptions","organizations_url":"https://api.github.com/users/s-alexey/orgs","repos_url":"https://api.github.com/users/s-alexey/repos","events_url":"https://api.github.com/users/s-alexey/events{/privacy}","received_events_url":"https://api.github.com/users/s-alexey/received_events","type":"User","site_admin":false},"body":"<!--\r\nSquash the commits, as appropriate. See .github/CONTRIBUTING.md for\r\nmore information.\r\n\r\nDescribe the relevant changes in the commit messages, if they need explaining.\r\n \r\nIf the pull request introduces a new feature or an important bug fix, consider\r\nadding _one_ of the below tags, enclosed in square brackets, in its title:\r\n\r\n    ENH, FIX, DOC, WIP\r\n\r\nFor some example:\r\n\r\n    [ENH] CrossValidation: Parallelize computation\r\n    [FIX] NaiveBayesLearner: Don't crash on input containing nan values\r\n    [DOC] Extend documentation for widget development\r\n    [WIP] Working on X ... RFC please\r\n\r\nPull-requests not so tagged will be batched as \"other features and bugfixes,\"\r\nwhich is fine for stuff you don't go home and brag to your mother about.\r\n-->\r\n\r\nSwitch to Model-based imputer in case learner is provided.\r\n\r\nAdded learner adequacy checker.","created_at":"2016-03-10T00:37:40Z","updated_at":"2016-05-10T12:16:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4e34b99956828bd327a3ae81e30b1b7da7f9bc1","assignee":{"login":"astaric","id":588601,"avatar_url":"https://avatars.githubusercontent.com/u/588601?v=3","gravatar_id":"","url":"https://api.github.com/users/astaric","html_url":"https://github.com/astaric","followers_url":"https://api.github.com/users/astaric/followers","following_url":"https://api.github.com/users/astaric/following{/other_user}","gists_url":"https://api.github.com/users/astaric/gists{/gist_id}","starred_url":"https://api.github.com/users/astaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astaric/subscriptions","organizations_url":"https://api.github.com/users/astaric/orgs","repos_url":"https://api.github.com/users/astaric/repos","events_url":"https://api.github.com/users/astaric/events{/privacy}","received_events_url":"https://api.github.com/users/astaric/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/biolab/orange3/pulls/1094/commits","review_comments_url":"https://api.github.com/repos/biolab/orange3/pulls/1094/comments","review_comment_url":"https://api.github.com/repos/biolab/orange3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/biolab/orange3/issues/1094/comments","statuses_url":"https://api.github.com/repos/biolab/orange3/statuses/91f83090292a154a85c5bc8f615f2d952b16e952","head":{"label":"s-alexey:iss1082","ref":"iss1082","sha":"91f83090292a154a85c5bc8f615f2d952b16e952","user":{"login":"s-alexey","id":9372243,"avatar_url":"https://avatars.githubusercontent.com/u/9372243?v=3","gravatar_id":"","url":"https://api.github.com/users/s-alexey","html_url":"https://github.com/s-alexey","followers_url":"https://api.github.com/users/s-alexey/followers","following_url":"https://api.github.com/users/s-alexey/following{/other_user}","gists_url":"https://api.github.com/users/s-alexey/gists{/gist_id}","starred_url":"https://api.github.com/users/s-alexey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-alexey/subscriptions","organizations_url":"https://api.github.com/users/s-alexey/orgs","repos_url":"https://api.github.com/users/s-alexey/repos","events_url":"https://api.github.com/users/s-alexey/events{/privacy}","received_events_url":"https://api.github.com/users/s-alexey/received_events","type":"User","site_admin":false},"repo":{"id":53073917,"name":"orange3","full_name":"s-alexey/orange3","owner":{"login":"s-alexey","id":9372243,"avatar_url":"https://avatars.githubusercontent.com/u/9372243?v=3","gravatar_id":"","url":"https://api.github.com/users/s-alexey","html_url":"https://github.com/s-alexey","followers_url":"https://api.github.com/users/s-alexey/followers","following_url":"https://api.github.com/users/s-alexey/following{/other_user}","gists_url":"https://api.github.com/users/s-alexey/gists{/gist_id}","starred_url":"https://api.github.com/users/s-alexey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-alexey/subscriptions","organizations_url":"https://api.github.com/users/s-alexey/orgs","repos_url":"https://api.github.com/users/s-alexey/repos","events_url":"https://api.github.com/users/s-alexey/events{/privacy}","received_events_url":"https://api.github.com/users/s-alexey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/s-alexey/orange3","description":"Orange 3 data mining suite: http://orange.biolab.si ","fork":true,"url":"https://api.github.com/repos/s-alexey/orange3","forks_url":"https://api.github.com/repos/s-alexey/orange3/forks","keys_url":"https://api.github.com/repos/s-alexey/orange3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/s-alexey/orange3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/s-alexey/orange3/teams","hooks_url":"https://api.github.com/repos/s-alexey/orange3/hooks","issue_events_url":"https://api.github.com/repos/s-alexey/orange3/issues/events{/number}","events_url":"https://api.github.com/repos/s-alexey/orange3/events","assignees_url":"https://api.github.com/repos/s-alexey/orange3/assignees{/user}","branches_url":"https://api.github.com/repos/s-alexey/orange3/branches{/branch}","tags_url":"https://api.github.com/repos/s-alexey/orange3/tags","blobs_url":"https://api.github.com/repos/s-alexey/orange3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/s-alexey/orange3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/s-alexey/orange3/git/refs{/sha}","trees_url":"https://api.github.com/repos/s-alexey/orange3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/s-alexey/orange3/statuses/{sha}","languages_url":"https://api.github.com/repos/s-alexey/orange3/languages","stargazers_url":"https://api.github.com/repos/s-alexey/orange3/stargazers","contributors_url":"https://api.github.com/repos/s-alexey/orange3/contributors","subscribers_url":"https://api.github.com/repos/s-alexey/orange3/subscribers","subscription_url":"https://api.github.com/repos/s-alexey/orange3/subscription","commits_url":"https://api.github.com/repos/s-alexey/orange3/commits{/sha}","git_commits_url":"https://api.github.com/repos/s-alexey/orange3/git/commits{/sha}","comments_url":"https://api.github.com/repos/s-alexey/orange3/comments{/number}","issue_comment_url":"https://api.github.com/repos/s-alexey/orange3/issues/comments{/number}","contents_url":"https://api.github.com/repos/s-alexey/orange3/contents/{+path}","compare_url":"https://api.github.com/repos/s-alexey/orange3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/s-alexey/orange3/merges","archive_url":"https://api.github.com/repos/s-alexey/orange3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/s-alexey/orange3/downloads","issues_url":"https://api.github.com/repos/s-alexey/orange3/issues{/number}","pulls_url":"https://api.github.com/repos/s-alexey/orange3/pulls{/number}","milestones_url":"https://api.github.com/repos/s-alexey/orange3/milestones{/number}","notifications_url":"https://api.github.com/repos/s-alexey/orange3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/s-alexey/orange3/labels{/name}","releases_url":"https://api.github.com/repos/s-alexey/orange3/releases{/id}","deployments_url":"https://api.github.com/repos/s-alexey/orange3/deployments","created_at":"2016-03-03T18:36:52Z","updated_at":"2016-03-03T18:36:55Z","pushed_at":"2016-05-09T11:08:46Z","git_url":"git://github.com/s-alexey/orange3.git","ssh_url":"git@github.com:s-alexey/orange3.git","clone_url":"https://github.com/s-alexey/orange3.git","svn_url":"https://github.com/s-alexey/orange3","homepage":"","size":37117,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"biolab:master","ref":"master","sha":"c2bf08943b523b8f56692276b0022064a29263b0","user":{"login":"biolab","id":555189,"avatar_url":"https://avatars.githubusercontent.com/u/555189?v=3","gravatar_id":"","url":"https://api.github.com/users/biolab","html_url":"https://github.com/biolab","followers_url":"https://api.github.com/users/biolab/followers","following_url":"https://api.github.com/users/biolab/following{/other_user}","gists_url":"https://api.github.com/users/biolab/gists{/gist_id}","starred_url":"https://api.github.com/users/biolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biolab/subscriptions","organizations_url":"https://api.github.com/users/biolab/orgs","repos_url":"https://api.github.com/users/biolab/repos","events_url":"https://api.github.com/users/biolab/events{/privacy}","received_events_url":"https://api.github.com/users/biolab/received_events","type":"Organization","site_admin":false},"repo":{"id":8357227,"name":"orange3","full_name":"biolab/orange3","owner":{"login":"biolab","id":555189,"avatar_url":"https://avatars.githubusercontent.com/u/555189?v=3","gravatar_id":"","url":"https://api.github.com/users/biolab","html_url":"https://github.com/biolab","followers_url":"https://api.github.com/users/biolab/followers","following_url":"https://api.github.com/users/biolab/following{/other_user}","gists_url":"https://api.github.com/users/biolab/gists{/gist_id}","starred_url":"https://api.github.com/users/biolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biolab/subscriptions","organizations_url":"https://api.github.com/users/biolab/orgs","repos_url":"https://api.github.com/users/biolab/repos","events_url":"https://api.github.com/users/biolab/events{/privacy}","received_events_url":"https://api.github.com/users/biolab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biolab/orange3","description":"Orange 3 data mining suite: http://orange.biolab.si ","fork":false,"url":"https://api.github.com/repos/biolab/orange3","forks_url":"https://api.github.com/repos/biolab/orange3/forks","keys_url":"https://api.github.com/repos/biolab/orange3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biolab/orange3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biolab/orange3/teams","hooks_url":"https://api.github.com/repos/biolab/orange3/hooks","issue_events_url":"https://api.github.com/repos/biolab/orange3/issues/events{/number}","events_url":"https://api.github.com/repos/biolab/orange3/events","assignees_url":"https://api.github.com/repos/biolab/orange3/assignees{/user}","branches_url":"https://api.github.com/repos/biolab/orange3/branches{/branch}","tags_url":"https://api.github.com/repos/biolab/orange3/tags","blobs_url":"https://api.github.com/repos/biolab/orange3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biolab/orange3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biolab/orange3/git/refs{/sha}","trees_url":"https://api.github.com/repos/biolab/orange3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biolab/orange3/statuses/{sha}","languages_url":"https://api.github.com/repos/biolab/orange3/languages","stargazers_url":"https://api.github.com/repos/biolab/orange3/stargazers","contributors_url":"https://api.github.com/repos/biolab/orange3/contributors","subscribers_url":"https://api.github.com/repos/biolab/orange3/subscribers","subscription_url":"https://api.github.com/repos/biolab/orange3/subscription","commits_url":"https://api.github.com/repos/biolab/orange3/commits{/sha}","git_commits_url":"https://api.github.com/repos/biolab/orange3/git/commits{/sha}","comments_url":"https://api.github.com/repos/biolab/orange3/comments{/number}","issue_comment_url":"https://api.github.com/repos/biolab/orange3/issues/comments{/number}","contents_url":"https://api.github.com/repos/biolab/orange3/contents/{+path}","compare_url":"https://api.github.com/repos/biolab/orange3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biolab/orange3/merges","archive_url":"https://api.github.com/repos/biolab/orange3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biolab/orange3/downloads","issues_url":"https://api.github.com/repos/biolab/orange3/issues{/number}","pulls_url":"https://api.github.com/repos/biolab/orange3/pulls{/number}","milestones_url":"https://api.github.com/repos/biolab/orange3/milestones{/number}","notifications_url":"https://api.github.com/repos/biolab/orange3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biolab/orange3/labels{/name}","releases_url":"https://api.github.com/repos/biolab/orange3/releases{/id}","deployments_url":"https://api.github.com/repos/biolab/orange3/deployments","created_at":"2013-02-22T12:52:56Z","updated_at":"2016-05-10T00:39:34Z","pushed_at":"2016-05-10T10:45:23Z","git_url":"git://github.com/biolab/orange3.git","ssh_url":"git@github.com:biolab/orange3.git","clone_url":"https://github.com/biolab/orange3.git","svn_url":"https://github.com/biolab/orange3","homepage":"","size":76375,"stargazers_count":283,"watchers_count":283,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":125,"mirror_url":null,"open_issues_count":48,"forks":125,"open_issues":48,"watchers":283,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biolab/orange3/pulls/1094"},"html":{"href":"https://github.com/biolab/orange3/pull/1094"},"issue":{"href":"https://api.github.com/repos/biolab/orange3/issues/1094"},"comments":{"href":"https://api.github.com/repos/biolab/orange3/issues/1094/comments"},"review_comments":{"href":"https://api.github.com/repos/biolab/orange3/pulls/1094/comments"},"review_comment":{"href":"https://api.github.com/repos/biolab/orange3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/biolab/orange3/pulls/1094/commits"},"statuses":{"href":"https://api.github.com/repos/biolab/orange3/statuses/91f83090292a154a85c5bc8f615f2d952b16e952"}}}}