{"action":"created","comment":{"url":"https://api.github.com/repos/oh-my-fish/plugin-tab/pulls/comments/91241615","pull_request_review_id":11749471,"id":91241615,"diff_hunk":"@@ -0,0 +1,3 @@\n+function tab.xfce4_terminal -a cdto\n+  xfce4-terminal --tab --working-directory \"$cdto\"","path":"functions/tab.xfce4_terminal.fish","position":2,"original_position":2,"commit_id":"ae64f96258e3fa727fbb77db33775346814e8ab3","original_commit_id":"ae64f96258e3fa727fbb77db33775346814e8ab3","user":{"login":"bobthecow","id":53660,"avatar_url":"https://avatars.githubusercontent.com/u/53660?v=3","gravatar_id":"","url":"https://api.github.com/users/bobthecow","html_url":"https://github.com/bobthecow","followers_url":"https://api.github.com/users/bobthecow/followers","following_url":"https://api.github.com/users/bobthecow/following{/other_user}","gists_url":"https://api.github.com/users/bobthecow/gists{/gist_id}","starred_url":"https://api.github.com/users/bobthecow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobthecow/subscriptions","organizations_url":"https://api.github.com/users/bobthecow/orgs","repos_url":"https://api.github.com/users/bobthecow/repos","events_url":"https://api.github.com/users/bobthecow/events{/privacy}","received_events_url":"https://api.github.com/users/bobthecow/received_events","type":"User","site_admin":false},"body":"it looks like `xfce4-terminal` includes an `-e` flag for executing a command inside the new terminal. does that execute the command and end the session, or does the window stick around after?\r\n\r\nif it doesn't automatically close the session, let's add support for the second `$cmd` argument as well.","created_at":"2016-12-07T07:57:25Z","updated_at":"2016-12-07T07:57:36Z","html_url":"https://github.com/oh-my-fish/plugin-tab/pull/10#discussion_r91241615","pull_request_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/oh-my-fish/plugin-tab/pulls/comments/91241615"},"html":{"href":"https://github.com/oh-my-fish/plugin-tab/pull/10#discussion_r91241615"},"pull_request":{"href":"https://api.github.com/repos/oh-my-fish/plugin-tab/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/oh-my-fish/plugin-tab/pulls/10","id":96872954,"html_url":"https://github.com/oh-my-fish/plugin-tab/pull/10","diff_url":"https://github.com/oh-my-fish/plugin-tab/pull/10.diff","patch_url":"https://github.com/oh-my-fish/plugin-tab/pull/10.patch","issue_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/issues/10","number":10,"state":"open","locked":false,"title":"Add xfce4-terminal capability","user":{"login":"chadfrost","id":6821561,"avatar_url":"https://avatars.githubusercontent.com/u/6821561?v=3","gravatar_id":"","url":"https://api.github.com/users/chadfrost","html_url":"https://github.com/chadfrost","followers_url":"https://api.github.com/users/chadfrost/followers","following_url":"https://api.github.com/users/chadfrost/following{/other_user}","gists_url":"https://api.github.com/users/chadfrost/gists{/gist_id}","starred_url":"https://api.github.com/users/chadfrost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadfrost/subscriptions","organizations_url":"https://api.github.com/users/chadfrost/orgs","repos_url":"https://api.github.com/users/chadfrost/repos","events_url":"https://api.github.com/users/chadfrost/events{/privacy}","received_events_url":"https://api.github.com/users/chadfrost/received_events","type":"User","site_admin":false},"body":"Tested on fish 2.4.0, on my rather clunky old Chromebook, running xfce4-terminal 0.6.3 (Xfce 4.10) under\r\nDISTRIB_ID=Ubuntu\r\nDISTRIB_RELEASE=14.04\r\nDISTRIB_CODENAME=trusty\r\nDISTRIB_DESCRIPTION=\"Ubuntu 14.04.4 LTS\"\r\n","created_at":"2016-12-07T07:41:57Z","updated_at":"2016-12-07T07:57:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed02cfa6d35ea8ed175a5510600f773ce61b5527","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/pulls/10/commits","review_comments_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/pulls/10/comments","review_comment_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/issues/10/comments","statuses_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/statuses/ae64f96258e3fa727fbb77db33775346814e8ab3","head":{"label":"chadfrost:xfce4-terminal","ref":"xfce4-terminal","sha":"ae64f96258e3fa727fbb77db33775346814e8ab3","user":{"login":"chadfrost","id":6821561,"avatar_url":"https://avatars.githubusercontent.com/u/6821561?v=3","gravatar_id":"","url":"https://api.github.com/users/chadfrost","html_url":"https://github.com/chadfrost","followers_url":"https://api.github.com/users/chadfrost/followers","following_url":"https://api.github.com/users/chadfrost/following{/other_user}","gists_url":"https://api.github.com/users/chadfrost/gists{/gist_id}","starred_url":"https://api.github.com/users/chadfrost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadfrost/subscriptions","organizations_url":"https://api.github.com/users/chadfrost/orgs","repos_url":"https://api.github.com/users/chadfrost/repos","events_url":"https://api.github.com/users/chadfrost/events{/privacy}","received_events_url":"https://api.github.com/users/chadfrost/received_events","type":"User","site_admin":false},"repo":{"id":75810751,"name":"plugin-tab","full_name":"chadfrost/plugin-tab","owner":{"login":"chadfrost","id":6821561,"avatar_url":"https://avatars.githubusercontent.com/u/6821561?v=3","gravatar_id":"","url":"https://api.github.com/users/chadfrost","html_url":"https://github.com/chadfrost","followers_url":"https://api.github.com/users/chadfrost/followers","following_url":"https://api.github.com/users/chadfrost/following{/other_user}","gists_url":"https://api.github.com/users/chadfrost/gists{/gist_id}","starred_url":"https://api.github.com/users/chadfrost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadfrost/subscriptions","organizations_url":"https://api.github.com/users/chadfrost/orgs","repos_url":"https://api.github.com/users/chadfrost/repos","events_url":"https://api.github.com/users/chadfrost/events{/privacy}","received_events_url":"https://api.github.com/users/chadfrost/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chadfrost/plugin-tab","description":"Open the current directory (or any other directory) in a new tab.","fork":true,"url":"https://api.github.com/repos/chadfrost/plugin-tab","forks_url":"https://api.github.com/repos/chadfrost/plugin-tab/forks","keys_url":"https://api.github.com/repos/chadfrost/plugin-tab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chadfrost/plugin-tab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chadfrost/plugin-tab/teams","hooks_url":"https://api.github.com/repos/chadfrost/plugin-tab/hooks","issue_events_url":"https://api.github.com/repos/chadfrost/plugin-tab/issues/events{/number}","events_url":"https://api.github.com/repos/chadfrost/plugin-tab/events","assignees_url":"https://api.github.com/repos/chadfrost/plugin-tab/assignees{/user}","branches_url":"https://api.github.com/repos/chadfrost/plugin-tab/branches{/branch}","tags_url":"https://api.github.com/repos/chadfrost/plugin-tab/tags","blobs_url":"https://api.github.com/repos/chadfrost/plugin-tab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chadfrost/plugin-tab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chadfrost/plugin-tab/git/refs{/sha}","trees_url":"https://api.github.com/repos/chadfrost/plugin-tab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chadfrost/plugin-tab/statuses/{sha}","languages_url":"https://api.github.com/repos/chadfrost/plugin-tab/languages","stargazers_url":"https://api.github.com/repos/chadfrost/plugin-tab/stargazers","contributors_url":"https://api.github.com/repos/chadfrost/plugin-tab/contributors","subscribers_url":"https://api.github.com/repos/chadfrost/plugin-tab/subscribers","subscription_url":"https://api.github.com/repos/chadfrost/plugin-tab/subscription","commits_url":"https://api.github.com/repos/chadfrost/plugin-tab/commits{/sha}","git_commits_url":"https://api.github.com/repos/chadfrost/plugin-tab/git/commits{/sha}","comments_url":"https://api.github.com/repos/chadfrost/plugin-tab/comments{/number}","issue_comment_url":"https://api.github.com/repos/chadfrost/plugin-tab/issues/comments{/number}","contents_url":"https://api.github.com/repos/chadfrost/plugin-tab/contents/{+path}","compare_url":"https://api.github.com/repos/chadfrost/plugin-tab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chadfrost/plugin-tab/merges","archive_url":"https://api.github.com/repos/chadfrost/plugin-tab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chadfrost/plugin-tab/downloads","issues_url":"https://api.github.com/repos/chadfrost/plugin-tab/issues{/number}","pulls_url":"https://api.github.com/repos/chadfrost/plugin-tab/pulls{/number}","milestones_url":"https://api.github.com/repos/chadfrost/plugin-tab/milestones{/number}","notifications_url":"https://api.github.com/repos/chadfrost/plugin-tab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chadfrost/plugin-tab/labels{/name}","releases_url":"https://api.github.com/repos/chadfrost/plugin-tab/releases{/id}","deployments_url":"https://api.github.com/repos/chadfrost/plugin-tab/deployments","created_at":"2016-12-07T07:25:36Z","updated_at":"2016-12-07T07:25:37Z","pushed_at":"2016-12-07T07:34:05Z","git_url":"git://github.com/chadfrost/plugin-tab.git","ssh_url":"git@github.com:chadfrost/plugin-tab.git","clone_url":"https://github.com/chadfrost/plugin-tab.git","svn_url":"https://github.com/chadfrost/plugin-tab","homepage":"","size":13,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oh-my-fish:master","ref":"master","sha":"bdb107842c4861f3cc3eb5836255d5e2f1fa46bf","user":{"login":"oh-my-fish","id":11728505,"avatar_url":"https://avatars.githubusercontent.com/u/11728505?v=3","gravatar_id":"","url":"https://api.github.com/users/oh-my-fish","html_url":"https://github.com/oh-my-fish","followers_url":"https://api.github.com/users/oh-my-fish/followers","following_url":"https://api.github.com/users/oh-my-fish/following{/other_user}","gists_url":"https://api.github.com/users/oh-my-fish/gists{/gist_id}","starred_url":"https://api.github.com/users/oh-my-fish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oh-my-fish/subscriptions","organizations_url":"https://api.github.com/users/oh-my-fish/orgs","repos_url":"https://api.github.com/users/oh-my-fish/repos","events_url":"https://api.github.com/users/oh-my-fish/events{/privacy}","received_events_url":"https://api.github.com/users/oh-my-fish/received_events","type":"Organization","site_admin":false},"repo":{"id":36608518,"name":"plugin-tab","full_name":"oh-my-fish/plugin-tab","owner":{"login":"oh-my-fish","id":11728505,"avatar_url":"https://avatars.githubusercontent.com/u/11728505?v=3","gravatar_id":"","url":"https://api.github.com/users/oh-my-fish","html_url":"https://github.com/oh-my-fish","followers_url":"https://api.github.com/users/oh-my-fish/followers","following_url":"https://api.github.com/users/oh-my-fish/following{/other_user}","gists_url":"https://api.github.com/users/oh-my-fish/gists{/gist_id}","starred_url":"https://api.github.com/users/oh-my-fish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oh-my-fish/subscriptions","organizations_url":"https://api.github.com/users/oh-my-fish/orgs","repos_url":"https://api.github.com/users/oh-my-fish/repos","events_url":"https://api.github.com/users/oh-my-fish/events{/privacy}","received_events_url":"https://api.github.com/users/oh-my-fish/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oh-my-fish/plugin-tab","description":"Open the current directory (or any other directory) in a new tab.","fork":false,"url":"https://api.github.com/repos/oh-my-fish/plugin-tab","forks_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/forks","keys_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/teams","hooks_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/hooks","issue_events_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/issues/events{/number}","events_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/events","assignees_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/assignees{/user}","branches_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/branches{/branch}","tags_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/tags","blobs_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/git/refs{/sha}","trees_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/statuses/{sha}","languages_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/languages","stargazers_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/stargazers","contributors_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/contributors","subscribers_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/subscribers","subscription_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/subscription","commits_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/commits{/sha}","git_commits_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/git/commits{/sha}","comments_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/comments{/number}","issue_comment_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/issues/comments{/number}","contents_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/contents/{+path}","compare_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/merges","archive_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/downloads","issues_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/issues{/number}","pulls_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/pulls{/number}","milestones_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/milestones{/number}","notifications_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/labels{/name}","releases_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/releases{/id}","deployments_url":"https://api.github.com/repos/oh-my-fish/plugin-tab/deployments","created_at":"2015-05-31T15:11:13Z","updated_at":"2016-11-09T17:55:13Z","pushed_at":"2016-12-07T07:41:57Z","git_url":"git://github.com/oh-my-fish/plugin-tab.git","ssh_url":"git@github.com:oh-my-fish/plugin-tab.git","clone_url":"https://github.com/oh-my-fish/plugin-tab.git","svn_url":"https://github.com/oh-my-fish/plugin-tab","homepage":"","size":13,"stargazers_count":7,"watchers_count":7,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oh-my-fish/plugin-tab/pulls/10"},"html":{"href":"https://github.com/oh-my-fish/plugin-tab/pull/10"},"issue":{"href":"https://api.github.com/repos/oh-my-fish/plugin-tab/issues/10"},"comments":{"href":"https://api.github.com/repos/oh-my-fish/plugin-tab/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/oh-my-fish/plugin-tab/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/oh-my-fish/plugin-tab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oh-my-fish/plugin-tab/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/oh-my-fish/plugin-tab/statuses/ae64f96258e3fa727fbb77db33775346814e8ab3"}}}}
{"actor":{"display_login":"bobthecow"}}