{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/53648432","id":53648432,"diff_hunk":"@@ -10,112 +10,30 @@ namespace System.Globalization.Tests\n {\n     public class DateTimeFormatInfoAbbreviatedMonthGenitiveNames\n     {\n-        // PosTest1: Call AbbreviatedMonthGenitiveNames getter method should return correct value for InvariantInfo\n         [Fact]\n-        public void TestGetter()\n+        public void AbbreviatedMonthNames_InvariantInfo()\n         {\n-            VerificationHelper(DateTimeFormatInfo.InvariantInfo,\n-                    new string[] {\n-                    \"Jan\",\n-                    \"Feb\",\n-                    \"Mar\",\n-                    \"Apr\",\n-                    \"May\",\n-                    \"Jun\",\n-                    \"Jul\",\n-                    \"Aug\",\n-                    \"Sep\",\n-                    \"Oct\",\n-                    \"Nov\",\n-                    \"Dec\",\n-                    \"\"\n-                    },\n-                    false);\n+            Assert.Equal(new string[] { \"Jan\", \"Feb\", \"Mar\", \"Apr\", \"May\", \"Jun\", \"Jul\", \"Aug\", \"Sep\", \"Oct\", \"Nov\", \"Dec\", \"\" }, DateTimeFormatInfo.InvariantInfo.AbbreviatedMonthGenitiveNames);\n         }\n \n-        // PosTest2: Call AbbreviatedMonthGenitiveNames setter method should return correct value\n         [Fact]\n-        public void TestSetter()\n+        public void AbbreviatedMonthNames_Set()\n         {\n-            VerificationHelper(new DateTimeFormatInfo(),\n-                    new string[] {\n-                    \"1\",\n-                    \"2\",\n-                    \"3\",\n-                    \"4\",\n-                    \"5\",\n-                    \"6\",\n-                    \"7\",\n-                    \"8\",\n-                    \"9\",\n-                    \"10\",\n-                    \"11\",\n-                    \"12\",\n-                    \"\"\n-                    },\n-                    true);\n+            string[] newAbbreviatedMonthGenitiveNames = new string[] { \"1\", \"2\", \"3\", \"4\", \"5\", \"6\", \"7\", \"8\", \"9\", \"10\", \"11\", \"12\", \"\" };","path":"src/System.Globalization/tests/DateTimeFormatInfo/DateTimeFormatInfoAbbreviatedMonthGenitiveNames.cs","position":51,"original_position":51,"commit_id":"ee4f9fe82439e0f44a7af46a6d49468aea82a0a7","original_commit_id":"ee4f9fe82439e0f44a7af46a6d49468aea82a0a7","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"> I was told off for adding tests in a precious refactoring PR\r\n\r\nIf you want to add additional test cases, that's fine, but please do it in a separate commit.  When reviewing a refactoring, we need to be able to correlate the old with the new, and that because much more difficult when meaningful test changes are mixed in.","created_at":"2016-02-22T16:17:18Z","updated_at":"2016-02-22T16:17:18Z","html_url":"https://github.com/dotnet/corefx/pull/6301#discussion_r53648432","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/6301","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/53648432"},"html":{"href":"https://github.com/dotnet/corefx/pull/6301#discussion_r53648432"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6301"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/6301","id":60111637,"html_url":"https://github.com/dotnet/corefx/pull/6301","diff_url":"https://github.com/dotnet/corefx/pull/6301.diff","patch_url":"https://github.com/dotnet/corefx/pull/6301.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/6301","number":6301,"state":"open","locked":false,"title":"Fix #2336 for DateTimeFormatInfo","user":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars.githubusercontent.com/u/1275900?v=3","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"body":"The Ubuntu build might fail, as I don't have an Ubuntu VM on hand.\r\n\r\nOther related System.Globalization.Tests PRs may cause merge conflicts, as the csproj file changes often","created_at":"2016-02-22T00:22:16Z","updated_at":"2016-02-22T16:17:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b46463cec6bbd2586a9758e7967f9eeb95def23f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/6301/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/6301/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/6301/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/ee4f9fe82439e0f44a7af46a6d49468aea82a0a7","head":{"label":"hughbe:globalization-tests-datetime-format-info","ref":"globalization-tests-datetime-format-info","sha":"ee4f9fe82439e0f44a7af46a6d49468aea82a0a7","user":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars.githubusercontent.com/u/1275900?v=3","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"repo":{"id":47085914,"name":"corefx","full_name":"hughbe/corefx","owner":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars.githubusercontent.com/u/1275900?v=3","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hughbe/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/hughbe/corefx","forks_url":"https://api.github.com/repos/hughbe/corefx/forks","keys_url":"https://api.github.com/repos/hughbe/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hughbe/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hughbe/corefx/teams","hooks_url":"https://api.github.com/repos/hughbe/corefx/hooks","issue_events_url":"https://api.github.com/repos/hughbe/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/hughbe/corefx/events","assignees_url":"https://api.github.com/repos/hughbe/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/hughbe/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/hughbe/corefx/tags","blobs_url":"https://api.github.com/repos/hughbe/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hughbe/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hughbe/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/hughbe/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hughbe/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/hughbe/corefx/languages","stargazers_url":"https://api.github.com/repos/hughbe/corefx/stargazers","contributors_url":"https://api.github.com/repos/hughbe/corefx/contributors","subscribers_url":"https://api.github.com/repos/hughbe/corefx/subscribers","subscription_url":"https://api.github.com/repos/hughbe/corefx/subscription","commits_url":"https://api.github.com/repos/hughbe/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/hughbe/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/hughbe/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/hughbe/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/hughbe/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/hughbe/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hughbe/corefx/merges","archive_url":"https://api.github.com/repos/hughbe/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hughbe/corefx/downloads","issues_url":"https://api.github.com/repos/hughbe/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/hughbe/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/hughbe/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/hughbe/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hughbe/corefx/labels{/name}","releases_url":"https://api.github.com/repos/hughbe/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/hughbe/corefx/deployments","created_at":"2015-11-30T00:15:59Z","updated_at":"2016-01-17T12:57:11Z","pushed_at":"2016-02-22T15:56:52Z","git_url":"git://github.com/hughbe/corefx.git","ssh_url":"git@github.com:hughbe/corefx.git","clone_url":"https://github.com/hughbe/corefx.git","svn_url":"https://github.com/hughbe/corefx","homepage":"http://dotnet.github.io/","size":57804,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"ce4686ae4c21e691333e673969a6a6e6efcf594b","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-02-22T10:49:44Z","pushed_at":"2016-02-22T15:52:44Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":66931,"stargazers_count":9173,"watchers_count":9173,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2144,"mirror_url":null,"open_issues_count":837,"forks":2144,"open_issues":837,"watchers":9173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6301"},"html":{"href":"https://github.com/dotnet/corefx/pull/6301"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/6301"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/6301/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6301/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6301/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/ee4f9fe82439e0f44a7af46a6d49468aea82a0a7"}}}}