{"action":"created","issue":{"url":"https://api.github.com/repos/mhallsmoore/qstrader/issues/86","repository_url":"https://api.github.com/repos/mhallsmoore/qstrader","labels_url":"https://api.github.com/repos/mhallsmoore/qstrader/issues/86/labels{/name}","comments_url":"https://api.github.com/repos/mhallsmoore/qstrader/issues/86/comments","events_url":"https://api.github.com/repos/mhallsmoore/qstrader/issues/86/events","html_url":"https://github.com/mhallsmoore/qstrader/pull/86","id":165924251,"number":86,"title":"Arithmetic optimisation","user":{"login":"ryankennedyio","id":11158006,"avatar_url":"https://avatars.githubusercontent.com/u/11158006?v=3","gravatar_id":"","url":"https://api.github.com/users/ryankennedyio","html_url":"https://github.com/ryankennedyio","followers_url":"https://api.github.com/users/ryankennedyio/followers","following_url":"https://api.github.com/users/ryankennedyio/following{/other_user}","gists_url":"https://api.github.com/users/ryankennedyio/gists{/gist_id}","starred_url":"https://api.github.com/users/ryankennedyio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryankennedyio/subscriptions","organizations_url":"https://api.github.com/users/ryankennedyio/orgs","repos_url":"https://api.github.com/users/ryankennedyio/repos","events_url":"https://api.github.com/users/ryankennedyio/events{/privacy}","received_events_url":"https://api.github.com/users/ryankennedyio/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-16T10:55:09Z","updated_at":"2016-07-16T13:55:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mhallsmoore/qstrader/pulls/86","html_url":"https://github.com/mhallsmoore/qstrader/pull/86","diff_url":"https://github.com/mhallsmoore/qstrader/pull/86.diff","patch_url":"https://github.com/mhallsmoore/qstrader/pull/86.patch"},"body":"NOT YET READY FOR MERGE -- Need to fix for several tests.\r\n\r\nJust want a review of style. @mhallsmoore @femtotrader. Very close to being done.\r\nApologies for delay -- workload leading into product launch got a bit ridiculous.\r\n\r\nSupporting multiple types (int, float, Decimal) internally is going to add a lot of complexity and overhead. I prefer the simple idea of a one-time parse for numbers going _into_ qstrader, and a one-time parse for numbers coming _out_ of qstrader. If the input numbers are already `int`, we shouldn't parse them. As such, the user should probably explicitly pass numbers in as floats.\r\n\r\nJust mentioning that.. Need to update the price handlers to force all data from the CSVs to be float.\r\n\r\nNote that this is only relevant for price too, volume, etc needs no parsing. Because of this, I've named the parser a simple `PriceParser`, to remove any ambiguity as to when & how it should be used."},"comment":{"url":"https://api.github.com/repos/mhallsmoore/qstrader/issues/comments/233131511","html_url":"https://github.com/mhallsmoore/qstrader/pull/86#issuecomment-233131511","issue_url":"https://api.github.com/repos/mhallsmoore/qstrader/issues/86","id":233131511,"user":{"login":"ryankennedyio","id":11158006,"avatar_url":"https://avatars.githubusercontent.com/u/11158006?v=3","gravatar_id":"","url":"https://api.github.com/users/ryankennedyio","html_url":"https://github.com/ryankennedyio","followers_url":"https://api.github.com/users/ryankennedyio/followers","following_url":"https://api.github.com/users/ryankennedyio/following{/other_user}","gists_url":"https://api.github.com/users/ryankennedyio/gists{/gist_id}","starred_url":"https://api.github.com/users/ryankennedyio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryankennedyio/subscriptions","organizations_url":"https://api.github.com/users/ryankennedyio/orgs","repos_url":"https://api.github.com/users/ryankennedyio/repos","events_url":"https://api.github.com/users/ryankennedyio/events{/privacy}","received_events_url":"https://api.github.com/users/ryankennedyio/received_events","type":"User","site_admin":false},"created_at":"2016-07-16T13:55:46Z","updated_at":"2016-07-16T13:55:46Z","body":"Now passing all tests except for one. Will deal with that tomorrow morning, then quickly run through linting. Will see if I can find out what's causing my 1 cent error too, and re-enable that test.\r\n\r\nThink something is definitely up with the source CSV file accuracy. Tests have been refactored to accommodate at some point but I think they're erroneous. Won't actually make a technical difference, just not pretty."}}
{"actor":{"display_login":"ryankennedyio"}}