{"action":"created","issue":{"url":"https://api.github.com/repos/PyroTeam/robocup-pkg/issues/132","repository_url":"https://api.github.com/repos/PyroTeam/robocup-pkg","labels_url":"https://api.github.com/repos/PyroTeam/robocup-pkg/issues/132/labels{/name}","comments_url":"https://api.github.com/repos/PyroTeam/robocup-pkg/issues/132/comments","events_url":"https://api.github.com/repos/PyroTeam/robocup-pkg/issues/132/events","html_url":"https://github.com/PyroTeam/robocup-pkg/pull/132","id":183206735,"number":132,"title":"Feature/communication/inter robots","user":{"login":"vcoelen","id":7904996,"avatar_url":"https://avatars.githubusercontent.com/u/7904996?v=3","gravatar_id":"","url":"https://api.github.com/users/vcoelen","html_url":"https://github.com/vcoelen","followers_url":"https://api.github.com/users/vcoelen/followers","following_url":"https://api.github.com/users/vcoelen/following{/other_user}","gists_url":"https://api.github.com/users/vcoelen/gists{/gist_id}","starred_url":"https://api.github.com/users/vcoelen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcoelen/subscriptions","organizations_url":"https://api.github.com/users/vcoelen/orgs","repos_url":"https://api.github.com/users/vcoelen/repos","events_url":"https://api.github.com/users/vcoelen/events{/privacy}","received_events_url":"https://api.github.com/users/vcoelen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/PyroTeam/robocup-pkg/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/PyroTeam/robocup-pkg/labels/normal","name":"normal","color":"fef2c0"}],"state":"open","locked":false,"assignee":{"login":"ValentinVERGEZ","id":6777198,"avatar_url":"https://avatars.githubusercontent.com/u/6777198?v=3","gravatar_id":"","url":"https://api.github.com/users/ValentinVERGEZ","html_url":"https://github.com/ValentinVERGEZ","followers_url":"https://api.github.com/users/ValentinVERGEZ/followers","following_url":"https://api.github.com/users/ValentinVERGEZ/following{/other_user}","gists_url":"https://api.github.com/users/ValentinVERGEZ/gists{/gist_id}","starred_url":"https://api.github.com/users/ValentinVERGEZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ValentinVERGEZ/subscriptions","organizations_url":"https://api.github.com/users/ValentinVERGEZ/orgs","repos_url":"https://api.github.com/users/ValentinVERGEZ/repos","events_url":"https://api.github.com/users/ValentinVERGEZ/events{/privacy}","received_events_url":"https://api.github.com/users/ValentinVERGEZ/received_events","type":"User","site_admin":false},"assignees":[{"login":"ValentinVERGEZ","id":6777198,"avatar_url":"https://avatars.githubusercontent.com/u/6777198?v=3","gravatar_id":"","url":"https://api.github.com/users/ValentinVERGEZ","html_url":"https://github.com/ValentinVERGEZ","followers_url":"https://api.github.com/users/ValentinVERGEZ/followers","following_url":"https://api.github.com/users/ValentinVERGEZ/following{/other_user}","gists_url":"https://api.github.com/users/ValentinVERGEZ/gists{/gist_id}","starred_url":"https://api.github.com/users/ValentinVERGEZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ValentinVERGEZ/subscriptions","organizations_url":"https://api.github.com/users/ValentinVERGEZ/orgs","repos_url":"https://api.github.com/users/ValentinVERGEZ/repos","events_url":"https://api.github.com/users/ValentinVERGEZ/events{/privacy}","received_events_url":"https://api.github.com/users/ValentinVERGEZ/received_events","type":"User","site_admin":false},{"login":"tdanel","id":7900949,"avatar_url":"https://avatars.githubusercontent.com/u/7900949?v=3","gravatar_id":"","url":"https://api.github.com/users/tdanel","html_url":"https://github.com/tdanel","followers_url":"https://api.github.com/users/tdanel/followers","following_url":"https://api.github.com/users/tdanel/following{/other_user}","gists_url":"https://api.github.com/users/tdanel/gists{/gist_id}","starred_url":"https://api.github.com/users/tdanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdanel/subscriptions","organizations_url":"https://api.github.com/users/tdanel/orgs","repos_url":"https://api.github.com/users/tdanel/repos","events_url":"https://api.github.com/users/tdanel/events{/privacy}","received_events_url":"https://api.github.com/users/tdanel/received_events","type":"User","site_admin":false},{"login":"SandraHage","id":10849170,"avatar_url":"https://avatars.githubusercontent.com/u/10849170?v=3","gravatar_id":"","url":"https://api.github.com/users/SandraHage","html_url":"https://github.com/SandraHage","followers_url":"https://api.github.com/users/SandraHage/followers","following_url":"https://api.github.com/users/SandraHage/following{/other_user}","gists_url":"https://api.github.com/users/SandraHage/gists{/gist_id}","starred_url":"https://api.github.com/users/SandraHage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SandraHage/subscriptions","organizations_url":"https://api.github.com/users/SandraHage/orgs","repos_url":"https://api.github.com/users/SandraHage/repos","events_url":"https://api.github.com/users/SandraHage/events{/privacy}","received_events_url":"https://api.github.com/users/SandraHage/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/PyroTeam/robocup-pkg/milestones/2","html_url":"https://github.com/PyroTeam/robocup-pkg/milestones/V2.0%20(STUART)","labels_url":"https://api.github.com/repos/PyroTeam/robocup-pkg/milestones/2/labels","id":1423997,"number":2,"title":"V2.0 (STUART)","description":"Objectif : Production mono-robot","creator":{"login":"ValentinVERGEZ","id":6777198,"avatar_url":"https://avatars.githubusercontent.com/u/6777198?v=3","gravatar_id":"","url":"https://api.github.com/users/ValentinVERGEZ","html_url":"https://github.com/ValentinVERGEZ","followers_url":"https://api.github.com/users/ValentinVERGEZ/followers","following_url":"https://api.github.com/users/ValentinVERGEZ/following{/other_user}","gists_url":"https://api.github.com/users/ValentinVERGEZ/gists{/gist_id}","starred_url":"https://api.github.com/users/ValentinVERGEZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ValentinVERGEZ/subscriptions","organizations_url":"https://api.github.com/users/ValentinVERGEZ/orgs","repos_url":"https://api.github.com/users/ValentinVERGEZ/repos","events_url":"https://api.github.com/users/ValentinVERGEZ/events{/privacy}","received_events_url":"https://api.github.com/users/ValentinVERGEZ/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":33,"state":"open","created_at":"2015-11-22T21:50:09Z","updated_at":"2016-10-15T12:18:04Z","due_on":"2017-04-28T00:00:00Z","closed_at":null},"comments":1,"created_at":"2016-10-15T12:18:04Z","updated_at":"2016-10-15T12:42:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PyroTeam/robocup-pkg/pulls/132","html_url":"https://github.com/PyroTeam/robocup-pkg/pull/132","diff_url":"https://github.com/PyroTeam/robocup-pkg/pull/132.diff","patch_url":"https://github.com/PyroTeam/robocup-pkg/pull/132.patch"},"body":"Après une demande répétée et une attente insoutenable ^^, PR pour réintégration de la branche communication. \r\nFonctionnalités : \r\n- ajout du message beacon\r\n- échange de Topics\r\n- communication chiffrée\r\n\r\n(La branche peut être supprimée)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pyroteam/robocup-pkg/132)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/PyroTeam/robocup-pkg/issues/comments/253982024","html_url":"https://github.com/PyroTeam/robocup-pkg/pull/132#issuecomment-253982024","issue_url":"https://api.github.com/repos/PyroTeam/robocup-pkg/issues/132","id":253982024,"user":{"login":"tdanel","id":7900949,"avatar_url":"https://avatars.githubusercontent.com/u/7900949?v=3","gravatar_id":"","url":"https://api.github.com/users/tdanel","html_url":"https://github.com/tdanel","followers_url":"https://api.github.com/users/tdanel/followers","following_url":"https://api.github.com/users/tdanel/following{/other_user}","gists_url":"https://api.github.com/users/tdanel/gists{/gist_id}","starred_url":"https://api.github.com/users/tdanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdanel/subscriptions","organizations_url":"https://api.github.com/users/tdanel/orgs","repos_url":"https://api.github.com/users/tdanel/repos","events_url":"https://api.github.com/users/tdanel/events{/privacy}","received_events_url":"https://api.github.com/users/tdanel/received_events","type":"User","site_admin":false},"created_at":"2016-10-15T12:42:11Z","updated_at":"2016-10-15T12:42:11Z","body":"\n\n\n\nReviewed 1 of 8 files at r1, 7 of 26 files at r4, 2 of 9 files at r5, 8 of 18 files at r6, 2 of 2 files at r7, 6 of 10 files at r8, 12 of 12 files at r9.\nReview status: all files reviewed at latest revision, 6 unresolved discussions, some commit checks failed.\n\n---\n\n*[communication/robot_comm/include/udpToTopicBeacon.h, line 48 at r9](https://reviewable.io:443/reviews/pyroteam/robocup-pkg/132#-KU7IFAiNwPu7dR9VT8C:-KU7IFAjWq7sUGU04WTT:bq0lq96) ([raw file](https://github.com/pyroteam/robocup-pkg/blob/df239ea49ceddd863ee135023f89c30d1b8cd15c/communication/robot_comm/include/udpToTopicBeacon.h#L48)):*\n> ```objc\n>     robot.nb_robot = 0;\n>     robot.ip = \"\";\n>     robot.last_time_active.sec = 0;\n> ```\n\nbetter way to do that BIATCH :P\n\n---\n\n*[communication/robot_comm/include/udpToTopicBeacon.h, line 76 at r9](https://reviewable.io:443/reviews/pyroteam/robocup-pkg/132#-KU7IR81OMaQ4LhAlzib:-KU7IR81OMaQ4LhAlzic:b-5acyo7) ([raw file](https://github.com/pyroteam/robocup-pkg/blob/df239ea49ceddd863ee135023f89c30d1b8cd15c/communication/robot_comm/include/udpToTopicBeacon.h#L76)):*\n> ```objc\n>     m_activeRobots[m.nb_robot()].nb_robot = m.nb_robot();\n>     Time* time = m.mutable_timestamp();\n>     m_activeRobots[m.nb_robot()].last_time_active.sec = time->sec();\n> ```\n\nsame thing\n\n---\n\n*[communication/robot_comm/launch/robotComm.launch, line 7 at r9](https://reviewable.io:443/reviews/pyroteam/robocup-pkg/132#-KU7IjWW8zKogv9SKahr:-KU7IjWW8zKogv9SKahs:b-k7m072) ([raw file](https://github.com/pyroteam/robocup-pkg/blob/df239ea49ceddd863ee135023f89c30d1b8cd15c/communication/robot_comm/launch/robotComm.launch#L7)):*\n> ```XML\n>     <param name=\"portIn\" value=\"5001\" />\n>     <param name=\"portOut\" value=\"5001\" />\n>     <param name=\"adresseIP\" value=\"127.0.0.255\" />\n> ```\n\nipAdress\n\n---\n\n*[communication/robot_comm/src/encryptUtils.cpp, line 70 at r9](https://reviewable.io:443/reviews/pyroteam/robocup-pkg/132#-KU7K9sFPkKubk2ODhrI:-KU7K9sFPkKubk2ODhrJ:boxaygg) ([raw file](https://github.com/pyroteam/robocup-pkg/blob/df239ea49ceddd863ee135023f89c30d1b8cd15c/communication/robot_comm/src/encryptUtils.cpp#L70)):*\n> ```cpp\n> {\n>     unsigned char decryptedMsg[encryptedMessage.size()+16];\n>     //Buffer_type encryptedMessage = .push_back(0);\n> ```\n\nsome cleaning to do\n\n---\n\n*[communication/robot_comm/src/encryptUtils.cpp, line 91 at r9](https://reviewable.io:443/reviews/pyroteam/robocup-pkg/132#-KU7M8mzB_EpNcSp6Z4o:-KU7M8mzB_EpNcSp6Z4p:b-yj8wm) ([raw file](https://github.com/pyroteam/robocup-pkg/blob/df239ea49ceddd863ee135023f89c30d1b8cd15c/communication/robot_comm/src/encryptUtils.cpp#L91)):*\n> ```cpp\n> \n>   /* Create and initialise the context */\n>   if(!(ctx = EVP_CIPHER_CTX_new())) handleErrors();\n> ```\n\npas sur la meme ligne enfin ! :P\n\n---\n\n*[communication/robot_comm/src/encryptUtils.cpp, line 142 at r9](https://reviewable.io:443/reviews/pyroteam/robocup-pkg/132#-KU7MDXg_wicNNeFFmlw:-KU7MDXhRJxPGUOzeJYY:b3kre) ([raw file](https://github.com/pyroteam/robocup-pkg/blob/df239ea49ceddd863ee135023f89c30d1b8cd15c/communication/robot_comm/src/encryptUtils.cpp#L142)):*\n> ```cpp\n>    * IV size for *most* modes is the same as the block size. For AES this\n>    * is 128 bits */\n>    std::cout << key << std::endl;\n> ```\n\n?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/pyroteam/robocup-pkg/132)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"tdanel"}}