{"action":"created","issue":{"url":"https://api.github.com/repos/viritin/viritin/issues/66","repository_url":"https://api.github.com/repos/viritin/viritin","labels_url":"https://api.github.com/repos/viritin/viritin/issues/66/labels{/name}","comments_url":"https://api.github.com/repos/viritin/viritin/issues/66/comments","events_url":"https://api.github.com/repos/viritin/viritin/issues/66/events","html_url":"https://github.com/viritin/viritin/issues/66","id":60814025,"number":66,"title":"LazyComboBox implementations","user":{"login":"lorenzobenvenuti","id":7447650,"avatar_url":"https://avatars.githubusercontent.com/u/7447650?v=3","gravatar_id":"","url":"https://api.github.com/users/lorenzobenvenuti","html_url":"https://github.com/lorenzobenvenuti","followers_url":"https://api.github.com/users/lorenzobenvenuti/followers","following_url":"https://api.github.com/users/lorenzobenvenuti/following{/other_user}","gists_url":"https://api.github.com/users/lorenzobenvenuti/gists{/gist_id}","starred_url":"https://api.github.com/users/lorenzobenvenuti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorenzobenvenuti/subscriptions","organizations_url":"https://api.github.com/users/lorenzobenvenuti/orgs","repos_url":"https://api.github.com/users/lorenzobenvenuti/repos","events_url":"https://api.github.com/users/lorenzobenvenuti/events{/privacy}","received_events_url":"https://api.github.com/users/lorenzobenvenuti/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2015-03-12T12:52:11Z","updated_at":"2016-08-26T12:22:48Z","closed_at":"2016-08-26T12:22:48Z","body":"Hi Matti,\r\n\r\nI played a bit with the LazyComboBox implementation and IMHO there are a couple of features that could make it less resource intensive:\r\n\r\n- Introduce something similar to the TextField.setTextChangeEventMode to choose how often the combo should filter the data; I noticed that right now the count (and possibly filterEntities) are called more or less for every keystroke. I'm not sure how easy it could be, the VFilterSelect/ComboBox API don't seem so extension-friendly.\r\n\r\n- With real large datasets the method setValue triggers a lot of calls to the filterEntities to \"search\" the current element (expecially if the value is one of the last in the dataset). It would be nice to set an (optional?) IndexProvider to allow the component to load only the page where the current value is stored. I'm thinking to something like\r\n\r\n```java\r\ninterface IndexProvider<T> {\r\n\r\n    int getEntityIndex(T entity, String filter);\r\n\r\n}\r\n```\r\n\r\nThank you and keep up the good work!\r\n\r\nlorenzo"},"comment":{"url":"https://api.github.com/repos/viritin/viritin/issues/comments/242721059","html_url":"https://github.com/viritin/viritin/issues/66#issuecomment-242721059","issue_url":"https://api.github.com/repos/viritin/viritin/issues/66","id":242721059,"user":{"login":"mstahv","id":1478052,"avatar_url":"https://avatars.githubusercontent.com/u/1478052?v=3","gravatar_id":"","url":"https://api.github.com/users/mstahv","html_url":"https://github.com/mstahv","followers_url":"https://api.github.com/users/mstahv/followers","following_url":"https://api.github.com/users/mstahv/following{/other_user}","gists_url":"https://api.github.com/users/mstahv/gists{/gist_id}","starred_url":"https://api.github.com/users/mstahv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstahv/subscriptions","organizations_url":"https://api.github.com/users/mstahv/orgs","repos_url":"https://api.github.com/users/mstahv/repos","events_url":"https://api.github.com/users/mstahv/events{/privacy}","received_events_url":"https://api.github.com/users/mstahv/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T12:22:48Z","updated_at":"2016-08-26T12:22:48Z","body":"Finally the fix in the core is published with 7.7!"}}
{"actor":{"display_login":"mstahv"}}