{"action":"created","comment":{"url":"https://api.github.com/repos/peec/ember-css-transitions/pulls/comments/80122597","id":80122597,"diff_hunk":"@@ -26,203 +75,164 @@ export default Mixin.create({\n     return this.get('transitionClasses').join(' ');\n   }),\n \n-  addClass(className, $element) {\n+  addClass(className, element) {\n     if (!this.get('isDestroying')) {\n-      run(() => {\n-        this.get('transitionClasses').addObject(className);\n-      });\n+      this.get('transitionClasses').addObject(className);","path":"addon/mixins/transition-mixin.js","position":99,"original_position":99,"commit_id":"47401a02a4ca44a85c24bd56940a15242defbc90","original_commit_id":"47401a02a4ca44a85c24bd56940a15242defbc90","user":{"login":"snewcomer","id":7374640,"avatar_url":"https://avatars.githubusercontent.com/u/7374640?v=3","gravatar_id":"","url":"https://api.github.com/users/snewcomer","html_url":"https://github.com/snewcomer","followers_url":"https://api.github.com/users/snewcomer/followers","following_url":"https://api.github.com/users/snewcomer/following{/other_user}","gists_url":"https://api.github.com/users/snewcomer/gists{/gist_id}","starred_url":"https://api.github.com/users/snewcomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snewcomer/subscriptions","organizations_url":"https://api.github.com/users/snewcomer/orgs","repos_url":"https://api.github.com/users/snewcomer/repos","events_url":"https://api.github.com/users/snewcomer/events{/privacy}","received_events_url":"https://api.github.com/users/snewcomer/received_events","type":"User","site_admin":false},"body":"@miguelcobain I think this `run` is required?? I was getting errors related to the run loop in testing.  Thoughts?","created_at":"2016-09-22T19:53:23Z","updated_at":"2016-09-22T19:53:40Z","html_url":"https://github.com/peec/ember-css-transitions/pull/15#discussion_r80122597","pull_request_url":"https://api.github.com/repos/peec/ember-css-transitions/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/peec/ember-css-transitions/pulls/comments/80122597"},"html":{"href":"https://github.com/peec/ember-css-transitions/pull/15#discussion_r80122597"},"pull_request":{"href":"https://api.github.com/repos/peec/ember-css-transitions/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/peec/ember-css-transitions/pulls/15","id":81908793,"html_url":"https://github.com/peec/ember-css-transitions/pull/15","diff_url":"https://github.com/peec/ember-css-transitions/pull/15.diff","patch_url":"https://github.com/peec/ember-css-transitions/pull/15.patch","issue_url":"https://api.github.com/repos/peec/ember-css-transitions/issues/15","number":15,"state":"open","locked":false,"title":"BIG update","user":{"login":"miguelcobain","id":631691,"avatar_url":"https://avatars.githubusercontent.com/u/631691?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelcobain","html_url":"https://github.com/miguelcobain","followers_url":"https://api.github.com/users/miguelcobain/followers","following_url":"https://api.github.com/users/miguelcobain/following{/other_user}","gists_url":"https://api.github.com/users/miguelcobain/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelcobain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelcobain/subscriptions","organizations_url":"https://api.github.com/users/miguelcobain/orgs","repos_url":"https://api.github.com/users/miguelcobain/repos","events_url":"https://api.github.com/users/miguelcobain/events{/privacy}","received_events_url":"https://api.github.com/users/miguelcobain/received_events","type":"User","site_admin":false},"body":"* update to ember-cli 2.7.0\r\n* fixes bugs in some browsers\r\n  * perhaps the most important change is that this no longer uses the `transitionend` event. tl;dr it is useless and buggy. We now use timeouts according to the transition times. and more interesting info: https://github.com/facebook/react/pull/4561\r\n* adds some tests\r\n* **A LOT** of clean up:\r\n  * Should have perf improvements, no more queues, etc\r\n  * codebase much easier to follow\r\n  * removed unnecessary service\r\n  * better api: more aligned with react/angular namings. Less confusing.\r\n  * the process was reviewed step by step\r\n* adds `ember-suave` for stylish code","created_at":"2016-08-19T00:11:20Z","updated_at":"2016-09-22T19:53:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6eac3a982428ee221f9d0fbf0a8add4d832d2c79","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/peec/ember-css-transitions/pulls/15/commits","review_comments_url":"https://api.github.com/repos/peec/ember-css-transitions/pulls/15/comments","review_comment_url":"https://api.github.com/repos/peec/ember-css-transitions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/peec/ember-css-transitions/issues/15/comments","statuses_url":"https://api.github.com/repos/peec/ember-css-transitions/statuses/47401a02a4ca44a85c24bd56940a15242defbc90","head":{"label":"miguelcobain:master","ref":"master","sha":"47401a02a4ca44a85c24bd56940a15242defbc90","user":{"login":"miguelcobain","id":631691,"avatar_url":"https://avatars.githubusercontent.com/u/631691?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelcobain","html_url":"https://github.com/miguelcobain","followers_url":"https://api.github.com/users/miguelcobain/followers","following_url":"https://api.github.com/users/miguelcobain/following{/other_user}","gists_url":"https://api.github.com/users/miguelcobain/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelcobain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelcobain/subscriptions","organizations_url":"https://api.github.com/users/miguelcobain/orgs","repos_url":"https://api.github.com/users/miguelcobain/repos","events_url":"https://api.github.com/users/miguelcobain/events{/privacy}","received_events_url":"https://api.github.com/users/miguelcobain/received_events","type":"User","site_admin":false},"repo":{"id":49498981,"name":"ember-css-transitions","full_name":"miguelcobain/ember-css-transitions","owner":{"login":"miguelcobain","id":631691,"avatar_url":"https://avatars.githubusercontent.com/u/631691?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelcobain","html_url":"https://github.com/miguelcobain","followers_url":"https://api.github.com/users/miguelcobain/followers","following_url":"https://api.github.com/users/miguelcobain/following{/other_user}","gists_url":"https://api.github.com/users/miguelcobain/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelcobain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelcobain/subscriptions","organizations_url":"https://api.github.com/users/miguelcobain/orgs","repos_url":"https://api.github.com/users/miguelcobain/repos","events_url":"https://api.github.com/users/miguelcobain/events{/privacy}","received_events_url":"https://api.github.com/users/miguelcobain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miguelcobain/ember-css-transitions","description":"Ember implementation of CSS Transitions. Just like ng-animate and react animation but for Ember :)","fork":true,"url":"https://api.github.com/repos/miguelcobain/ember-css-transitions","forks_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/forks","keys_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/teams","hooks_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/hooks","issue_events_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/issues/events{/number}","events_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/events","assignees_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/assignees{/user}","branches_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/branches{/branch}","tags_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/tags","blobs_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/git/refs{/sha}","trees_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/statuses/{sha}","languages_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/languages","stargazers_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/stargazers","contributors_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/contributors","subscribers_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/subscribers","subscription_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/subscription","commits_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/commits{/sha}","git_commits_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/git/commits{/sha}","comments_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/comments{/number}","issue_comment_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/issues/comments{/number}","contents_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/contents/{+path}","compare_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/merges","archive_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/downloads","issues_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/issues{/number}","pulls_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/pulls{/number}","milestones_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/milestones{/number}","notifications_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/labels{/name}","releases_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/releases{/id}","deployments_url":"https://api.github.com/repos/miguelcobain/ember-css-transitions/deployments","created_at":"2016-01-12T12:33:54Z","updated_at":"2016-01-12T12:33:54Z","pushed_at":"2016-09-02T11:18:31Z","git_url":"git://github.com/miguelcobain/ember-css-transitions.git","ssh_url":"git@github.com:miguelcobain/ember-css-transitions.git","clone_url":"https://github.com/miguelcobain/ember-css-transitions.git","svn_url":"https://github.com/miguelcobain/ember-css-transitions","homepage":"http://peec.github.io/ember-css-transitions","size":282,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"peec:master","ref":"master","sha":"f7f7ac60e40723a55aaecbd4e5c7d2c383a02cbc","user":{"login":"peec","id":131546,"avatar_url":"https://avatars.githubusercontent.com/u/131546?v=3","gravatar_id":"","url":"https://api.github.com/users/peec","html_url":"https://github.com/peec","followers_url":"https://api.github.com/users/peec/followers","following_url":"https://api.github.com/users/peec/following{/other_user}","gists_url":"https://api.github.com/users/peec/gists{/gist_id}","starred_url":"https://api.github.com/users/peec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peec/subscriptions","organizations_url":"https://api.github.com/users/peec/orgs","repos_url":"https://api.github.com/users/peec/repos","events_url":"https://api.github.com/users/peec/events{/privacy}","received_events_url":"https://api.github.com/users/peec/received_events","type":"User","site_admin":false},"repo":{"id":40732752,"name":"ember-css-transitions","full_name":"peec/ember-css-transitions","owner":{"login":"peec","id":131546,"avatar_url":"https://avatars.githubusercontent.com/u/131546?v=3","gravatar_id":"","url":"https://api.github.com/users/peec","html_url":"https://github.com/peec","followers_url":"https://api.github.com/users/peec/followers","following_url":"https://api.github.com/users/peec/following{/other_user}","gists_url":"https://api.github.com/users/peec/gists{/gist_id}","starred_url":"https://api.github.com/users/peec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peec/subscriptions","organizations_url":"https://api.github.com/users/peec/orgs","repos_url":"https://api.github.com/users/peec/repos","events_url":"https://api.github.com/users/peec/events{/privacy}","received_events_url":"https://api.github.com/users/peec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peec/ember-css-transitions","description":"Ember implementation of CSS Transitions. Just like ng-animate and react animation but for Ember :)","fork":false,"url":"https://api.github.com/repos/peec/ember-css-transitions","forks_url":"https://api.github.com/repos/peec/ember-css-transitions/forks","keys_url":"https://api.github.com/repos/peec/ember-css-transitions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peec/ember-css-transitions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peec/ember-css-transitions/teams","hooks_url":"https://api.github.com/repos/peec/ember-css-transitions/hooks","issue_events_url":"https://api.github.com/repos/peec/ember-css-transitions/issues/events{/number}","events_url":"https://api.github.com/repos/peec/ember-css-transitions/events","assignees_url":"https://api.github.com/repos/peec/ember-css-transitions/assignees{/user}","branches_url":"https://api.github.com/repos/peec/ember-css-transitions/branches{/branch}","tags_url":"https://api.github.com/repos/peec/ember-css-transitions/tags","blobs_url":"https://api.github.com/repos/peec/ember-css-transitions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peec/ember-css-transitions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peec/ember-css-transitions/git/refs{/sha}","trees_url":"https://api.github.com/repos/peec/ember-css-transitions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peec/ember-css-transitions/statuses/{sha}","languages_url":"https://api.github.com/repos/peec/ember-css-transitions/languages","stargazers_url":"https://api.github.com/repos/peec/ember-css-transitions/stargazers","contributors_url":"https://api.github.com/repos/peec/ember-css-transitions/contributors","subscribers_url":"https://api.github.com/repos/peec/ember-css-transitions/subscribers","subscription_url":"https://api.github.com/repos/peec/ember-css-transitions/subscription","commits_url":"https://api.github.com/repos/peec/ember-css-transitions/commits{/sha}","git_commits_url":"https://api.github.com/repos/peec/ember-css-transitions/git/commits{/sha}","comments_url":"https://api.github.com/repos/peec/ember-css-transitions/comments{/number}","issue_comment_url":"https://api.github.com/repos/peec/ember-css-transitions/issues/comments{/number}","contents_url":"https://api.github.com/repos/peec/ember-css-transitions/contents/{+path}","compare_url":"https://api.github.com/repos/peec/ember-css-transitions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peec/ember-css-transitions/merges","archive_url":"https://api.github.com/repos/peec/ember-css-transitions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peec/ember-css-transitions/downloads","issues_url":"https://api.github.com/repos/peec/ember-css-transitions/issues{/number}","pulls_url":"https://api.github.com/repos/peec/ember-css-transitions/pulls{/number}","milestones_url":"https://api.github.com/repos/peec/ember-css-transitions/milestones{/number}","notifications_url":"https://api.github.com/repos/peec/ember-css-transitions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peec/ember-css-transitions/labels{/name}","releases_url":"https://api.github.com/repos/peec/ember-css-transitions/releases{/id}","deployments_url":"https://api.github.com/repos/peec/ember-css-transitions/deployments","created_at":"2015-08-14T19:33:28Z","updated_at":"2016-09-19T20:43:31Z","pushed_at":"2016-09-02T11:18:32Z","git_url":"git://github.com/peec/ember-css-transitions.git","ssh_url":"git@github.com:peec/ember-css-transitions.git","clone_url":"https://github.com/peec/ember-css-transitions.git","svn_url":"https://github.com/peec/ember-css-transitions","homepage":"http://peec.github.io/ember-css-transitions","size":269,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":6,"forks":6,"open_issues":6,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/peec/ember-css-transitions/pulls/15"},"html":{"href":"https://github.com/peec/ember-css-transitions/pull/15"},"issue":{"href":"https://api.github.com/repos/peec/ember-css-transitions/issues/15"},"comments":{"href":"https://api.github.com/repos/peec/ember-css-transitions/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/peec/ember-css-transitions/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/peec/ember-css-transitions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/peec/ember-css-transitions/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/peec/ember-css-transitions/statuses/47401a02a4ca44a85c24bd56940a15242defbc90"}}}}
{"actor":{"display_login":"snewcomer"}}