{"action":"created","issue":{"url":"https://api.github.com/repos/thesawolf/TrinityCore/issues/7","repository_url":"https://api.github.com/repos/thesawolf/TrinityCore","labels_url":"https://api.github.com/repos/thesawolf/TrinityCore/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/thesawolf/TrinityCore/issues/7/comments","events_url":"https://api.github.com/repos/thesawolf/TrinityCore/issues/7/events","html_url":"https://github.com/thesawolf/TrinityCore/issues/7","id":179035104,"number":7,"title":"updating help","user":{"login":"timothystewart6","id":1322205,"avatar_url":"https://avatars.githubusercontent.com/u/1322205?v=3","gravatar_id":"","url":"https://api.github.com/users/timothystewart6","html_url":"https://github.com/timothystewart6","followers_url":"https://api.github.com/users/timothystewart6/followers","following_url":"https://api.github.com/users/timothystewart6/following{/other_user}","gists_url":"https://api.github.com/users/timothystewart6/gists{/gist_id}","starred_url":"https://api.github.com/users/timothystewart6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothystewart6/subscriptions","organizations_url":"https://api.github.com/users/timothystewart6/orgs","repos_url":"https://api.github.com/users/timothystewart6/repos","events_url":"https://api.github.com/users/timothystewart6/events{/privacy}","received_events_url":"https://api.github.com/users/timothystewart6/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-24T15:19:13Z","updated_at":"2016-10-14T04:46:03Z","closed_at":null,"body":"**Description**:\r\nHi. I am looking for some guidance on how to update this to the latest TrinityCore.  I am comfortable merging and resolving conflicts however I was just hoping I could get some guidance on the best way to update.  Is there any way you can share more information about how to add NewNPCBots to a clean TrinityCore335?  Thank you so much.\r\n\r\n**Current behaviour**: Tell us what happens\r\nNA\r\n**Expected behaviour**: Tell us what should happen instead\r\nNA\r\n**Steps to reproduce the problem**:\r\n\r\n1. NA\r\n2. \r\n3. \r\n\r\n**Branch(es)**: 335/6x  \r\n335\r\n**TC hash/commit**:  \r\nNA\r\n**TDB version**:  \r\nNA\r\n**Operating system**:  \r\nNA\r\n\r\n[//]: # (This template is for problem reports, for other type of reports edit it accordingly)\r\n[//]: # (If this is a crash report, include the crashlog with https://gist.github.com/)\r\n"},"comment":{"url":"https://api.github.com/repos/thesawolf/TrinityCore/issues/comments/253708532","html_url":"https://github.com/thesawolf/TrinityCore/issues/7#issuecomment-253708532","issue_url":"https://api.github.com/repos/thesawolf/TrinityCore/issues/7","id":253708532,"user":{"login":"hooptie","id":7018723,"avatar_url":"https://avatars.githubusercontent.com/u/7018723?v=3","gravatar_id":"","url":"https://api.github.com/users/hooptie","html_url":"https://github.com/hooptie","followers_url":"https://api.github.com/users/hooptie/followers","following_url":"https://api.github.com/users/hooptie/following{/other_user}","gists_url":"https://api.github.com/users/hooptie/gists{/gist_id}","starred_url":"https://api.github.com/users/hooptie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hooptie/subscriptions","organizations_url":"https://api.github.com/users/hooptie/orgs","repos_url":"https://api.github.com/users/hooptie/repos","events_url":"https://api.github.com/users/hooptie/events{/privacy}","received_events_url":"https://api.github.com/users/hooptie/received_events","type":"User","site_admin":false},"created_at":"2016-10-14T04:46:03Z","updated_at":"2016-10-14T04:46:03Z","body":"The jist of the changes revolves around bringing the bot code up to date with the changes to TrinityCore, so you're basically always going to accept the TrinityCore changes, and then have to figure out what modifications make sense. For example, the latest merge I did, the TrinityCore folks removed several #define statements that caused alot of compilation errors in the bot code. The proper change would be to go change all the bot code files to remove the defines and call the methods directly. The easy change was to just add the defines back into the TrinityCore file (which is what I did). \r\n\r\nExample file in question is: src/server/game/AI/ScriptedAI/ScriptedGossip.h\r\n\r\nThe defines can be found in the thesawolf version of the file, and then those defines can be copied and appended to the end of the TrinityCore version of the file (in your merged repo).\r\n\r\nI believe there were maybe 20 or so other conflict issues and such. Didn't take too long this time. "}}
{"actor":{"display_login":"hooptie"}}