{"action":"created","issue":{"url":"https://api.github.com/repos/schrepfler/puppet-jdk_oracle/issues/8","repository_url":"https://api.github.com/repos/schrepfler/puppet-jdk_oracle","labels_url":"https://api.github.com/repos/schrepfler/puppet-jdk_oracle/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/schrepfler/puppet-jdk_oracle/issues/8/comments","events_url":"https://api.github.com/repos/schrepfler/puppet-jdk_oracle/issues/8/events","html_url":"https://github.com/schrepfler/puppet-jdk_oracle/issues/8","id":163570802,"number":8,"title":"Enhancement: hiera lookup not required as this is default since puppet 3","user":{"login":"030","id":7524528,"avatar_url":"https://avatars.githubusercontent.com/u/7524528?v=3","gravatar_id":"","url":"https://api.github.com/users/030","html_url":"https://github.com/030","followers_url":"https://api.github.com/users/030/followers","following_url":"https://api.github.com/users/030/following{/other_user}","gists_url":"https://api.github.com/users/030/gists{/gist_id}","starred_url":"https://api.github.com/users/030/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/030/subscriptions","organizations_url":"https://api.github.com/users/030/orgs","repos_url":"https://api.github.com/users/030/repos","events_url":"https://api.github.com/users/030/events{/privacy}","received_events_url":"https://api.github.com/users/030/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-03T17:08:24Z","updated_at":"2016-07-03T20:30:51Z","closed_at":null,"body":"```\r\n  $version      = hiera('jdk_oracle::version',        '8' ),\r\n  $arch         = hiera('jdk_oracle::arch',           'x64' ),\r\n  $install_dir  = hiera('jdk_oracle::install_dir',    '/usr/java' ),\r\n  $tmp_dir      = hiera('jdk_oracle::tmp_dir',        '/tmp' ),\r\n  $use_cache    = hiera('jdk_oracle::use_cache',      false ),\r\n  $cache_source = 'puppet:///modules/jdk_oracle/',\r\n  $jce          = hiera('jdk_oracle::jce',            false ),\r\n  $default_java = hiera('jdk_oracle::default_java',   true),\r\n```\r\n\r\ncould be changed to\r\n\r\n```\r\n  $version      =   8 ,\r\n  $arch         =  'x64' ,\r\n  $install_dir  =   '/usr/java',\r\n  $tmp_dir      =  '/tmp',\r\n  $use_cache    =  false ,\r\n  $cache_source = 'puppet:///modules/jdk_oracle/',\r\n  $jce          = false,\r\n  $default_java = true,\r\n```"},"comment":{"url":"https://api.github.com/repos/schrepfler/puppet-jdk_oracle/issues/comments/230173665","html_url":"https://github.com/schrepfler/puppet-jdk_oracle/issues/8#issuecomment-230173665","issue_url":"https://api.github.com/repos/schrepfler/puppet-jdk_oracle/issues/8","id":230173665,"user":{"login":"030","id":7524528,"avatar_url":"https://avatars.githubusercontent.com/u/7524528?v=3","gravatar_id":"","url":"https://api.github.com/users/030","html_url":"https://github.com/030","followers_url":"https://api.github.com/users/030/followers","following_url":"https://api.github.com/users/030/following{/other_user}","gists_url":"https://api.github.com/users/030/gists{/gist_id}","starred_url":"https://api.github.com/users/030/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/030/subscriptions","organizations_url":"https://api.github.com/users/030/orgs","repos_url":"https://api.github.com/users/030/repos","events_url":"https://api.github.com/users/030/events{/privacy}","received_events_url":"https://api.github.com/users/030/received_events","type":"User","site_admin":false},"created_at":"2016-07-03T20:30:51Z","updated_at":"2016-07-03T20:30:51Z","body":"That is a good question. Users that use an old version of Puppet are restricted to use 0.9.7 and if puppet4 is used then users could use newer version. We could also check if the version of puppet is 4. \r\n```\r\nif !($::puppetversion > '4.0.0') {\r\n    fail(\"Incompatible with \\\"${::puppetversion}\\\". Greater than: \\\"${supported_puppetversion}\\\" is required\")\r\n}\r\n```"}}
{"actor":{"display_login":"030"}}