{"action":"closed","issue":{"url":"https://api.github.com/repos/aframevr/aframe/issues/2187","repository_url":"https://api.github.com/repos/aframevr/aframe","labels_url":"https://api.github.com/repos/aframevr/aframe/issues/2187/labels{/name}","comments_url":"https://api.github.com/repos/aframevr/aframe/issues/2187/comments","events_url":"https://api.github.com/repos/aframevr/aframe/issues/2187/events","html_url":"https://github.com/aframevr/aframe/issues/2187","id":196309008,"number":2187,"title":"Browserify / husky causing issues with A-Frame as dependency","user":{"login":"donmccurdy","id":1848368,"avatar_url":"https://avatars.githubusercontent.com/u/1848368?v=3","gravatar_id":"","url":"https://api.github.com/users/donmccurdy","html_url":"https://github.com/donmccurdy","followers_url":"https://api.github.com/users/donmccurdy/followers","following_url":"https://api.github.com/users/donmccurdy/following{/other_user}","gists_url":"https://api.github.com/users/donmccurdy/gists{/gist_id}","starred_url":"https://api.github.com/users/donmccurdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donmccurdy/subscriptions","organizations_url":"https://api.github.com/users/donmccurdy/orgs","repos_url":"https://api.github.com/users/donmccurdy/repos","events_url":"https://api.github.com/users/donmccurdy/events{/privacy}","received_events_url":"https://api.github.com/users/donmccurdy/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-19T00:09:00Z","updated_at":"2016-12-20T21:33:31Z","closed_at":"2016-12-20T21:33:31Z","body":"My actual build involves Browserify + Karma etc., but simplified steps to reproduce the issue:\r\n\r\n1. Install `aframe` as dep:\r\n\r\n```shell\r\nnpm i aframe\r\n```\r\n\r\n2. Create fake test: \r\n\r\n```js\r\n// test.js\r\nrequire('aframe');\r\nconsole.log('done');\r\n```\r\n\r\n3. Attempt to serve test file:\r\n\r\n```shell\r\nbrowserify test.js -o output.js\r\n```\r\n\r\n4. Error:\r\n\r\n```\r\nError: Cannot find module 'envify' from '/Users/donmccurdy/Desktop/test/node_modules/aframe'\r\n    at /Users/donmccurdy/.nvm/versions/node/v6.2.2/lib/node_modules/browserify/node_modules/resolve/lib/async.js:46:17\r\n    at process (/Users/donmccurdy/.nvm/versions/node/v6.2.2/lib/node_modules/browserify/node_modules/resolve/lib/async.js:173:43)\r\n    at ondir (/Users/donmccurdy/.nvm/versions/node/v6.2.2/lib/node_modules/browserify/node_modules/resolve/lib/async.js:188:17)\r\n    at load (/Users/donmccurdy/.nvm/versions/node/v6.2.2/lib/node_modules/browserify/node_modules/resolve/lib/async.js:69:43)\r\n    at onex (/Users/donmccurdy/.nvm/versions/node/v6.2.2/lib/node_modules/browserify/node_modules/resolve/lib/async.js:92:31)\r\n    at /Users/donmccurdy/.nvm/versions/node/v6.2.2/lib/node_modules/browserify/node_modules/resolve/lib/async.js:22:47\r\n    at FSReqWrap.oncomplete (fs.js:117:15)\r\n```\r\n\r\n5. Attempt to debug\r\n\r\n```\r\ncd node_modules/aframe\r\nnpm i\r\n```\r\n\r\n6. [husky](https://github.com/typicode/husky) installs A-Frame's precommit git hook into my parent package, and it runs on future commits. 😐\r\n\r\n\r\n***\r\n\r\nIn retrospect, what I should have done was just `npm i envify`, but it would be great if we could remove the need. Is there a way to mark envify as a browserify dependency for production?\r\n\r\n***\r\n\r\n- A-Frame Version: 0.4.0\r\n\r\n\r\n"}}
{"actor":{"display_login":"ngokevin"}}