{"action":"created","issue":{"url":"https://api.github.com/repos/OTRS/otrs/issues/1305","repository_url":"https://api.github.com/repos/OTRS/otrs","labels_url":"https://api.github.com/repos/OTRS/otrs/issues/1305/labels{/name}","comments_url":"https://api.github.com/repos/OTRS/otrs/issues/1305/comments","events_url":"https://api.github.com/repos/OTRS/otrs/issues/1305/events","html_url":"https://github.com/OTRS/otrs/pull/1305","id":162443161,"number":1305,"title":"Master - JS refactoring - Error, Warning and NoPermission","user":{"login":"s7design","id":6348760,"avatar_url":"https://avatars.githubusercontent.com/u/6348760?v=3","gravatar_id":"","url":"https://api.github.com/users/s7design","html_url":"https://github.com/s7design","followers_url":"https://api.github.com/users/s7design/followers","following_url":"https://api.github.com/users/s7design/following{/other_user}","gists_url":"https://api.github.com/users/s7design/gists{/gist_id}","starred_url":"https://api.github.com/users/s7design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s7design/subscriptions","organizations_url":"https://api.github.com/users/s7design/orgs","repos_url":"https://api.github.com/users/s7design/repos","events_url":"https://api.github.com/users/s7design/events{/privacy}","received_events_url":"https://api.github.com/users/s7design/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/OTRS/otrs/labels/needs%20update%20by%20contributor","name":"needs update by contributor","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"zottto","id":481410,"avatar_url":"https://avatars.githubusercontent.com/u/481410?v=3","gravatar_id":"","url":"https://api.github.com/users/zottto","html_url":"https://github.com/zottto","followers_url":"https://api.github.com/users/zottto/followers","following_url":"https://api.github.com/users/zottto/following{/other_user}","gists_url":"https://api.github.com/users/zottto/gists{/gist_id}","starred_url":"https://api.github.com/users/zottto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zottto/subscriptions","organizations_url":"https://api.github.com/users/zottto/orgs","repos_url":"https://api.github.com/users/zottto/repos","events_url":"https://api.github.com/users/zottto/events{/privacy}","received_events_url":"https://api.github.com/users/zottto/received_events","type":"User","site_admin":false},"assignees":[{"login":"zottto","id":481410,"avatar_url":"https://avatars.githubusercontent.com/u/481410?v=3","gravatar_id":"","url":"https://api.github.com/users/zottto","html_url":"https://github.com/zottto","followers_url":"https://api.github.com/users/zottto/followers","following_url":"https://api.github.com/users/zottto/following{/other_user}","gists_url":"https://api.github.com/users/zottto/gists{/gist_id}","starred_url":"https://api.github.com/users/zottto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zottto/subscriptions","organizations_url":"https://api.github.com/users/zottto/orgs","repos_url":"https://api.github.com/users/zottto/repos","events_url":"https://api.github.com/users/zottto/events{/privacy}","received_events_url":"https://api.github.com/users/zottto/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-06-27T12:44:18Z","updated_at":"2016-07-05T08:08:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OTRS/otrs/pulls/1305","html_url":"https://github.com/OTRS/otrs/pull/1305","diff_url":"https://github.com/OTRS/otrs/pull/1305.diff","patch_url":"https://github.com/OTRS/otrs/pull/1305.patch"},"body":"Hello @zoto,\r\n\r\nHereby is refactored JS for Error, Warning and NoPermission screen. Included these three in same PR since they all share same JS which bind function on button 'Go to previous screen'. Created new JS file Core.Warn.js , please take this name with reservation and feel free to change it into anything you think suits better to reflect all three in one string.\r\n\r\nIf you have any issues or questions regarding this PR, do not hesitate to ask.\r\n\r\nRegards,\r\nSanjin"},"comment":{"url":"https://api.github.com/repos/OTRS/otrs/issues/comments/230413144","html_url":"https://github.com/OTRS/otrs/pull/1305#issuecomment-230413144","issue_url":"https://api.github.com/repos/OTRS/otrs/issues/1305","id":230413144,"user":{"login":"zottto","id":481410,"avatar_url":"https://avatars.githubusercontent.com/u/481410?v=3","gravatar_id":"","url":"https://api.github.com/users/zottto","html_url":"https://github.com/zottto","followers_url":"https://api.github.com/users/zottto/followers","following_url":"https://api.github.com/users/zottto/following{/other_user}","gists_url":"https://api.github.com/users/zottto/gists{/gist_id}","starred_url":"https://api.github.com/users/zottto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zottto/subscriptions","organizations_url":"https://api.github.com/users/zottto/orgs","repos_url":"https://api.github.com/users/zottto/repos","events_url":"https://api.github.com/users/zottto/events{/privacy}","received_events_url":"https://api.github.com/users/zottto/received_events","type":"User","site_admin":false},"created_at":"2016-07-05T08:08:07Z","updated_at":"2016-07-05T08:08:07Z","body":"Hi Sanjin / @s7design,\r\n\r\nthe function \"PreviousPage()\" makes no sense within Core.Exception.js because the content of the function is in no way related to an Exception (it is called on warning and error pages but the functionality itself is not related).\r\n\r\nPlease move it to Core.App and also rename it to a proper function name like \"ReturnToPreviousPage()\". The link should also have a more clear identifier instead of \"PreviousPage\". And the identifier should better be a class instead of an id to allow multiple links of this type in one page.\r\n\r\nThanks,\r\nMarc\r\n\r\n\r\n"}}
{"actor":{"display_login":"zottto"}}