{"action":"created","comment":{"url":"https://api.github.com/repos/superdesk/web-publisher/pulls/comments/76593178","id":76593178,"diff_hunk":"@@ -25,16 +24,11 @@ class ContentController extends Controller\n     /**\n      * @param Request $request\n      * @param string  $contentTemplate\n-     * @param null    $contentDocument\n      *\n      * @return \\Symfony\\Component\\HttpFoundation\\Response\n      */\n-    public function renderPageAction(Request $request, $contentTemplate, $contentDocument = null)\n+    public function renderPageAction(Request $request, $contentTemplate)","path":"src/SWP/Bundle/CoreBundle/Controller/ContentController.php","position":17,"original_position":17,"commit_id":"ac3b7bb24472038ed8546d0014bc1f3a696c37dc","original_commit_id":"ac3b7bb24472038ed8546d0014bc1f3a696c37dc","user":{"login":"ahilles107","id":298610,"avatar_url":"https://avatars.githubusercontent.com/u/298610?v=3","gravatar_id":"","url":"https://api.github.com/users/ahilles107","html_url":"https://github.com/ahilles107","followers_url":"https://api.github.com/users/ahilles107/followers","following_url":"https://api.github.com/users/ahilles107/following{/other_user}","gists_url":"https://api.github.com/users/ahilles107/gists{/gist_id}","starred_url":"https://api.github.com/users/ahilles107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahilles107/subscriptions","organizations_url":"https://api.github.com/users/ahilles107/orgs","repos_url":"https://api.github.com/users/ahilles107/repos","events_url":"https://api.github.com/users/ahilles107/events{/privacy}","received_events_url":"https://api.github.com/users/ahilles107/received_events","type":"User","site_admin":false},"body":"The parameter $request is not used and could be removed.","created_at":"2016-08-29T11:41:50Z","updated_at":"2016-08-29T11:41:50Z","html_url":"https://github.com/superdesk/web-publisher/pull/120#discussion_r76593178","pull_request_url":"https://api.github.com/repos/superdesk/web-publisher/pulls/120","_links":{"self":{"href":"https://api.github.com/repos/superdesk/web-publisher/pulls/comments/76593178"},"html":{"href":"https://github.com/superdesk/web-publisher/pull/120#discussion_r76593178"},"pull_request":{"href":"https://api.github.com/repos/superdesk/web-publisher/pulls/120"}}},"pull_request":{"url":"https://api.github.com/repos/superdesk/web-publisher/pulls/120","id":83080471,"html_url":"https://github.com/superdesk/web-publisher/pull/120","diff_url":"https://github.com/superdesk/web-publisher/pull/120.diff","patch_url":"https://github.com/superdesk/web-publisher/pull/120.patch","issue_url":"https://api.github.com/repos/superdesk/web-publisher/issues/120","number":120,"state":"open","locked":false,"title":"[WIP][ContentBundle] fixed parent routes assign, routes of collection type are not accessible","user":{"login":"takeit","id":562536,"avatar_url":"https://avatars.githubusercontent.com/u/562536?v=3","gravatar_id":"","url":"https://api.github.com/users/takeit","html_url":"https://github.com/takeit","followers_url":"https://api.github.com/users/takeit/followers","following_url":"https://api.github.com/users/takeit/following{/other_user}","gists_url":"https://api.github.com/users/takeit/gists{/gist_id}","starred_url":"https://api.github.com/users/takeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takeit/subscriptions","organizations_url":"https://api.github.com/users/takeit/orgs","repos_url":"https://api.github.com/users/takeit/repos","events_url":"https://api.github.com/users/takeit/events{/privacy}","received_events_url":"https://api.github.com/users/takeit/received_events","type":"User","site_admin":false},"body":"| Q                         | A\r\n| ------------------------- | ---\r\n| Bug fix?                  | yes\r\n| New feature?              | yes\r\n| BC breaks?                | no\r\n| Deprecations?             | no\r\n| Tests pass?               | [yes|no]\r\n| Changelog update required | yes\r\n| Fixed tickets             | [SWP-256](https://dev.sourcefabric.org/browse/SWP-256)\r\n| License                   | AGPLv3\r\n\r\n- If there is route of collection type and it has template assigned and has no content assigned, it will load template file assigned to the route\r\n- if route of type of collection has content assigned and this content has template assigned, it will load content's template instead of route template.\r\n- If there is route of collection type and it doesnt have template assigned and has no content assigned, it will return exception that the template is not loaded\r\n- If there is route of collection type and it doesn't have template assigned and has content assigned, it will load template file assigned to the route\r\n- Additionally if route of collection type is assigned to some articles it is possible to access articles via '/news/<article-slug>' url.\r\n\r\n\r\nTODO:\r\n- [ ] tests\r\n- [ ] docs","created_at":"2016-08-29T10:57:46Z","updated_at":"2016-08-29T11:41:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f070d40a5faf8461498b8bed6f0459e746bf2342","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/superdesk/web-publisher/pulls/120/commits","review_comments_url":"https://api.github.com/repos/superdesk/web-publisher/pulls/120/comments","review_comment_url":"https://api.github.com/repos/superdesk/web-publisher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/superdesk/web-publisher/issues/120/comments","statuses_url":"https://api.github.com/repos/superdesk/web-publisher/statuses/ac3b7bb24472038ed8546d0014bc1f3a696c37dc","head":{"label":"takeit:routes_fix","ref":"routes_fix","sha":"ac3b7bb24472038ed8546d0014bc1f3a696c37dc","user":{"login":"takeit","id":562536,"avatar_url":"https://avatars.githubusercontent.com/u/562536?v=3","gravatar_id":"","url":"https://api.github.com/users/takeit","html_url":"https://github.com/takeit","followers_url":"https://api.github.com/users/takeit/followers","following_url":"https://api.github.com/users/takeit/following{/other_user}","gists_url":"https://api.github.com/users/takeit/gists{/gist_id}","starred_url":"https://api.github.com/users/takeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takeit/subscriptions","organizations_url":"https://api.github.com/users/takeit/orgs","repos_url":"https://api.github.com/users/takeit/repos","events_url":"https://api.github.com/users/takeit/events{/privacy}","received_events_url":"https://api.github.com/users/takeit/received_events","type":"User","site_admin":false},"repo":{"id":36218538,"name":"web-renderer","full_name":"takeit/web-renderer","owner":{"login":"takeit","id":562536,"avatar_url":"https://avatars.githubusercontent.com/u/562536?v=3","gravatar_id":"","url":"https://api.github.com/users/takeit","html_url":"https://github.com/takeit","followers_url":"https://api.github.com/users/takeit/followers","following_url":"https://api.github.com/users/takeit/following{/other_user}","gists_url":"https://api.github.com/users/takeit/gists{/gist_id}","starred_url":"https://api.github.com/users/takeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takeit/subscriptions","organizations_url":"https://api.github.com/users/takeit/orgs","repos_url":"https://api.github.com/users/takeit/repos","events_url":"https://api.github.com/users/takeit/events{/privacy}","received_events_url":"https://api.github.com/users/takeit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/takeit/web-renderer","description":"Superdesk Web renderer","fork":true,"url":"https://api.github.com/repos/takeit/web-renderer","forks_url":"https://api.github.com/repos/takeit/web-renderer/forks","keys_url":"https://api.github.com/repos/takeit/web-renderer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/takeit/web-renderer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/takeit/web-renderer/teams","hooks_url":"https://api.github.com/repos/takeit/web-renderer/hooks","issue_events_url":"https://api.github.com/repos/takeit/web-renderer/issues/events{/number}","events_url":"https://api.github.com/repos/takeit/web-renderer/events","assignees_url":"https://api.github.com/repos/takeit/web-renderer/assignees{/user}","branches_url":"https://api.github.com/repos/takeit/web-renderer/branches{/branch}","tags_url":"https://api.github.com/repos/takeit/web-renderer/tags","blobs_url":"https://api.github.com/repos/takeit/web-renderer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/takeit/web-renderer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/takeit/web-renderer/git/refs{/sha}","trees_url":"https://api.github.com/repos/takeit/web-renderer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/takeit/web-renderer/statuses/{sha}","languages_url":"https://api.github.com/repos/takeit/web-renderer/languages","stargazers_url":"https://api.github.com/repos/takeit/web-renderer/stargazers","contributors_url":"https://api.github.com/repos/takeit/web-renderer/contributors","subscribers_url":"https://api.github.com/repos/takeit/web-renderer/subscribers","subscription_url":"https://api.github.com/repos/takeit/web-renderer/subscription","commits_url":"https://api.github.com/repos/takeit/web-renderer/commits{/sha}","git_commits_url":"https://api.github.com/repos/takeit/web-renderer/git/commits{/sha}","comments_url":"https://api.github.com/repos/takeit/web-renderer/comments{/number}","issue_comment_url":"https://api.github.com/repos/takeit/web-renderer/issues/comments{/number}","contents_url":"https://api.github.com/repos/takeit/web-renderer/contents/{+path}","compare_url":"https://api.github.com/repos/takeit/web-renderer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/takeit/web-renderer/merges","archive_url":"https://api.github.com/repos/takeit/web-renderer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/takeit/web-renderer/downloads","issues_url":"https://api.github.com/repos/takeit/web-renderer/issues{/number}","pulls_url":"https://api.github.com/repos/takeit/web-renderer/pulls{/number}","milestones_url":"https://api.github.com/repos/takeit/web-renderer/milestones{/number}","notifications_url":"https://api.github.com/repos/takeit/web-renderer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/takeit/web-renderer/labels{/name}","releases_url":"https://api.github.com/repos/takeit/web-renderer/releases{/id}","deployments_url":"https://api.github.com/repos/takeit/web-renderer/deployments","created_at":"2015-05-25T08:08:52Z","updated_at":"2016-02-11T10:08:35Z","pushed_at":"2016-08-29T10:57:22Z","git_url":"git://github.com/takeit/web-renderer.git","ssh_url":"git@github.com:takeit/web-renderer.git","clone_url":"https://github.com/takeit/web-renderer.git","svn_url":"https://github.com/takeit/web-renderer","homepage":null,"size":2009,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"superdesk:master","ref":"master","sha":"1e2ddf27d37fee3baffc2004950e5b681348da0e","user":{"login":"superdesk","id":5527298,"avatar_url":"https://avatars.githubusercontent.com/u/5527298?v=3","gravatar_id":"","url":"https://api.github.com/users/superdesk","html_url":"https://github.com/superdesk","followers_url":"https://api.github.com/users/superdesk/followers","following_url":"https://api.github.com/users/superdesk/following{/other_user}","gists_url":"https://api.github.com/users/superdesk/gists{/gist_id}","starred_url":"https://api.github.com/users/superdesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superdesk/subscriptions","organizations_url":"https://api.github.com/users/superdesk/orgs","repos_url":"https://api.github.com/users/superdesk/repos","events_url":"https://api.github.com/users/superdesk/events{/privacy}","received_events_url":"https://api.github.com/users/superdesk/received_events","type":"Organization","site_admin":false},"repo":{"id":36218357,"name":"web-publisher","full_name":"superdesk/web-publisher","owner":{"login":"superdesk","id":5527298,"avatar_url":"https://avatars.githubusercontent.com/u/5527298?v=3","gravatar_id":"","url":"https://api.github.com/users/superdesk","html_url":"https://github.com/superdesk","followers_url":"https://api.github.com/users/superdesk/followers","following_url":"https://api.github.com/users/superdesk/following{/other_user}","gists_url":"https://api.github.com/users/superdesk/gists{/gist_id}","starred_url":"https://api.github.com/users/superdesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superdesk/subscriptions","organizations_url":"https://api.github.com/users/superdesk/orgs","repos_url":"https://api.github.com/users/superdesk/repos","events_url":"https://api.github.com/users/superdesk/events{/privacy}","received_events_url":"https://api.github.com/users/superdesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/superdesk/web-publisher","description":"Superdesk Web Publisher - the next generation publishing platform for journalists and newsrooms.","fork":false,"url":"https://api.github.com/repos/superdesk/web-publisher","forks_url":"https://api.github.com/repos/superdesk/web-publisher/forks","keys_url":"https://api.github.com/repos/superdesk/web-publisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/superdesk/web-publisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/superdesk/web-publisher/teams","hooks_url":"https://api.github.com/repos/superdesk/web-publisher/hooks","issue_events_url":"https://api.github.com/repos/superdesk/web-publisher/issues/events{/number}","events_url":"https://api.github.com/repos/superdesk/web-publisher/events","assignees_url":"https://api.github.com/repos/superdesk/web-publisher/assignees{/user}","branches_url":"https://api.github.com/repos/superdesk/web-publisher/branches{/branch}","tags_url":"https://api.github.com/repos/superdesk/web-publisher/tags","blobs_url":"https://api.github.com/repos/superdesk/web-publisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/superdesk/web-publisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/superdesk/web-publisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/superdesk/web-publisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/superdesk/web-publisher/statuses/{sha}","languages_url":"https://api.github.com/repos/superdesk/web-publisher/languages","stargazers_url":"https://api.github.com/repos/superdesk/web-publisher/stargazers","contributors_url":"https://api.github.com/repos/superdesk/web-publisher/contributors","subscribers_url":"https://api.github.com/repos/superdesk/web-publisher/subscribers","subscription_url":"https://api.github.com/repos/superdesk/web-publisher/subscription","commits_url":"https://api.github.com/repos/superdesk/web-publisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/superdesk/web-publisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/superdesk/web-publisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/superdesk/web-publisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/superdesk/web-publisher/contents/{+path}","compare_url":"https://api.github.com/repos/superdesk/web-publisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/superdesk/web-publisher/merges","archive_url":"https://api.github.com/repos/superdesk/web-publisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/superdesk/web-publisher/downloads","issues_url":"https://api.github.com/repos/superdesk/web-publisher/issues{/number}","pulls_url":"https://api.github.com/repos/superdesk/web-publisher/pulls{/number}","milestones_url":"https://api.github.com/repos/superdesk/web-publisher/milestones{/number}","notifications_url":"https://api.github.com/repos/superdesk/web-publisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/superdesk/web-publisher/labels{/name}","releases_url":"https://api.github.com/repos/superdesk/web-publisher/releases{/id}","deployments_url":"https://api.github.com/repos/superdesk/web-publisher/deployments","created_at":"2015-05-25T08:04:59Z","updated_at":"2016-07-01T01:41:29Z","pushed_at":"2016-08-29T11:16:45Z","git_url":"git://github.com/superdesk/web-publisher.git","ssh_url":"git@github.com:superdesk/web-publisher.git","clone_url":"https://github.com/superdesk/web-publisher.git","svn_url":"https://github.com/superdesk/web-publisher","homepage":"","size":4858,"stargazers_count":6,"watchers_count":6,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":8,"forks":11,"open_issues":8,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/superdesk/web-publisher/pulls/120"},"html":{"href":"https://github.com/superdesk/web-publisher/pull/120"},"issue":{"href":"https://api.github.com/repos/superdesk/web-publisher/issues/120"},"comments":{"href":"https://api.github.com/repos/superdesk/web-publisher/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/superdesk/web-publisher/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/superdesk/web-publisher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/superdesk/web-publisher/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/superdesk/web-publisher/statuses/ac3b7bb24472038ed8546d0014bc1f3a696c37dc"}}}}
{"actor":{"display_login":"ahilles107"}}